1 2010-05-20 Marek Safar <marek.safar@gmail.com>
4 * anonymous.cs: Any issued error in probing mode means no match.
6 2010-05-20 Marek Safar <marek.safar@gmail.com>
8 * expression.cs: Search for base indexer using the closest match
11 2010-05-20 Marek Safar <marek.safar@gmail.com>
14 * method.cs: Set override constraints using unexpanded interface
17 2010-05-20 Marek Safar <marek.safar@gmail.com>
20 * ecore.cs: Include secondary extension method lookup in probing
23 2010-05-19 Marek Safar <marek.safar@gmail.com>
26 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
29 2010-05-19 Marek Safar <marek.safar@gmail.com>
32 * pending.cs: Advance counter correctly.
34 2010-05-19 Marek Safar <marek.safar@gmail.com>
37 * method.cs, pending.cs: Indexer override uses base name.
39 2010-05-19 Marek Safar <marek.safar@gmail.com>
42 * generic.cs: Replace original with inflated type parameter on
45 2010-05-19 Marek Safar <marek.safar@gmail.com>
48 * parameter.cs: Extension attribute can be defined in each assembly.
50 2010-05-18 Marek Safar <marek.safar@gmail.com>
53 * method.cs: Only one method can implement an interface.
55 2010-05-18 Marek Safar <marek.safar@gmail.com>
58 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
59 Typed null can be used as a source for expression methods.
61 2010-05-18 Marek Safar <marek.safar@gmail.com>
64 * namespace.cs: Using directive imports only types and not nested
67 2010-05-17 Marek Safar <marek.safar@gmail.com>
69 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
70 delegate.cs: Member instance is resolved after member overload
71 definitely resolves static/instance property of member expression.
72 Fixes #545047, #358848, #456605, #460016, #603299
74 2010-05-12 Marek Safar <marek.safar@gmail.com>
77 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
78 details for nested anonymous methods stories.
80 2010-05-11 Marek Safar <marek.safar@gmail.com>
83 * namespace.cs: Don't report namespace collision.
85 2010-05-11 Marek Safar <marek.safar@gmail.com>
88 * class.cs, typespec.cs: Search full imported attribute hierarchy
91 2010-05-11 Marek Safar <marek.safar@gmail.com>
93 * namespace.cs: Ignore missing dependencies failure at
96 2010-05-11 Marek Safar <marek.safar@gmail.com>
99 * namespace.cs: Don't resolve using constraints too early.
101 2010-05-11 Marek Safar <marek.safar@gmail.com>
103 A fix for bug #604239
104 * generic.cs: Copy partial type constraints to partial container.
106 2010-05-10 Marek Safar <marek.safar@gmail.com>
108 A fix for bug #557210
109 * import.cs: Relax underlying enum field rules.
111 2010-05-10 Marek Safar <marek.safar@gmail.com>
113 A fix for bug #603476
114 * property.cs: Implement IParametersMember for indexer accessors.
116 2010-05-07 Marek Safar <marek.safar@gmail.com>
118 A fix for bug #601141
119 * class.cs: Update all partial modifiers.
121 2010-05-06 Marek Safar <marek.safar@gmail.com>
123 A fix for bug #601708
124 * method.cs, membercache.cs: Destructors cannot be hidden.
126 2010-05-06 Marek Safar <marek.safar@gmail.com>
128 A fix for bug #602551
129 * class.cs: Resursive reference of type definition is allowed.
131 2010-05-06 Marek Safar <marek.safar@gmail.com>
133 * anonymous.cs: Mutate cached storey instance types too.
135 2010-05-06 Marek Safar <marek.safar@gmail.com>
137 A fix for bug #602443
138 * convert.cs: Explicit enum conversion cannot involve user operators
140 2010-05-05 Miguel de Icaza <miguel@novell.com>
142 * class.cs (TypeContainer.DefineBaseTypes)
143 (TypeContainer.CheckRecursiveDefinition): check for the iface not
144 being null, as we could have failed resolution and crashed;
147 * cs-parser.jay: Productions to catch common mistakes when other
148 punctuation operators are used instead of comma. Fixes 571702
150 2010-05-05 Marek Safar <marek.safar@gmail.com>
152 * anonymous.cs: Mutate correct set of constraints.
154 2010-05-05 Marek Safar <marek.safar@gmail.com>
156 A fix for bug #602842
157 * expression.cs: Resolve all array bound arguments.
159 2010-05-05 Marek Safar <marek.safar@gmail.com>
161 * import.cs: Don't import private fields.
163 2010-04-30 Marek Safar <marek.safar@gmail.com>
165 Partially based on patch by <sami.lamti@gmail.com>
167 * eval.cs, ecore.cs: Fixed eval show methods.
169 2010-04-30 Marek Safar <marek.safar@gmail.com>
171 * generic.cs, delegate.cs: Implement output type inference of
172 methodgroup now when the specification was cleared at least little
175 2010-04-29 Marek Safar <marek.safar@gmail.com>
177 A fix for bug #575611
178 * class.cs: Fix recursive unmanaged recursice sruct check.
180 2010-04-29 Marek Safar <marek.safar@gmail.com>
182 A fix for bug #479776
183 * expression.cs: Implement typeof unbounded nested generic types.
185 2010-04-29 Marek Safar <marek.safar@gmail.com>
187 A fix for bug #474953
188 * class.cs: Fix valid recursive base type definition.
190 2010-04-29 Marek Safar <marek.safar@gmail.com>
192 A fix for bug #421737
193 * convert.cs, expression.cs: A boxing conversion exists from a
194 nullable-type to a reference type, if a boxing conversion exists
195 from the underlying non-nullable-value-type to the reference type.
197 2010-04-29 Marek Safar <marek.safar@gmail.com>
199 A fix for bug #376875
200 * import.cs: Import volatile modifier.
202 2010-04-29 Marek Safar <marek.safar@gmail.com>
204 A fix for bug #372412
205 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
208 2010-04-29 Marek Safar <marek.safar@gmail.com>
210 A fix for bug #568955
211 * statements.cs: Handle recursive scope initializers.
213 2010-04-28 Marek Safar <marek.safar@gmail.com>
215 A fix for bug #566511
216 * anonymous.cs: Always get inflated version of hoisted variable
217 on generic type definition.
219 2010-04-28 Marek Safar <marek.safar@gmail.com>
221 * import.cs, membercache.cs: Relax rules for valid properties.
223 2010-04-28 Marek Safar <marek.safar@gmail.com>
225 * import.cs: Intern arrays used in generic arguments.
227 2010-04-28 Marek Safar <marek.safar@gmail.com>
229 A fix for bug #600398
230 * convert.cs: Actually use effective base type for the comparison.
232 2010-04-28 Marek Safar <marek.safar@gmail.com>
234 A fix for bug #600326
235 * ecore.cs: Pass arity to base member lookup.
237 2010-04-28 Marek Safar <marek.safar@gmail.com>
239 A fix for bug #573385
240 * expression.cs: MemberAccess is of generic type based on right
243 2010-05-28 Marek Safar <marek.safar@gmail.com>
245 * cs-tokenizer.cs: Made tab size configurable.
247 2010-05-27 Marek Safar <marek.safar@gmail.com>
249 * attribute.cs: Ensure Obsolete members are defined before doing
252 2010-05-27 Marek Safar <marek.safar@gmail.com>
254 * visit.cs: Add DOM visitor skeleton.
258 2010-05-27 Marek Safar <marek.safar@gmail.com>
260 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
262 2010-05-27 Marek Safar <marek.safar@gmail.com>
264 * *.cs: Major rewrite of compiler internals to better work with
265 unmodified System.Reflection.Emit. Some of the key changes are
266 - TypeSpec replaces reflection specific System.Type.
267 - All Type(TypeSpec) operations are now done in compiler therefore
268 no dependency on SRE to inflate generic members and types or to
269 query unclosed types.
270 - MemberCache is now the only and full hierarchical topology.
271 - Generic constraints are implemented properly.
272 - And as a bonus compilation is on average 30% faster.
274 2010-04-15 Jb Evain <jbevain@novell.com>
276 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
278 2010-04-12 Marek Safar <marek.safar@gmail.com>
280 * expression.cs, attribute.cs, parameter.cs: More attribute type
283 2010-04-12 Marek Safar <marek.safar@gmail.com>
285 A fix for bug #593342
287 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
288 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
289 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
290 codegen.cs: Add custom attribute encoder to deal with unfinished
291 types and easier corlib bootstrap from its own types.
293 2010-03-26 Marek Safar <marek.safar@gmail.com>
295 * cs-parser.jay: Report invalid constraint types.
297 2010-03-16 Jb Evain <jbevain@novell.com>
299 * Makefile: rename the net_2_1 profile to moonlight.
301 2010-03-11 Marek Safar <marek.safar@gmail.com>
303 * statement.cs, cs-parser.jay: Use correct location for empty
306 2010-03-11 Marek Safar <marek.safar@gmail.com>
308 * cs-parser.jay: Disable Location from expression.
310 * generic.cs: Check constraints for overrides in the parser.
312 2010-03-09 Marek Safar <marek.safar@gmail.com>
314 * cs-parser.jay (GetLocation): Use an expression when available.
316 2010-03-04 Marek Safar <marek.safar@gmail.com>
318 A fix for bug #582579
319 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
321 2010-03-04 Marek Safar <marek.safar@gmail.com>
323 A patch by kornelpal@gmail.com
325 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
326 compiler generated classes sealed by default. Emit and close top
327 level compiler generated classes as well.
329 * support.cs: Use RuntimeHelpers.GetHashCode.
331 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
333 * Makefile: We need to use the internal bootstrapping gmcs for
334 net_2_1_bootstrap too now.
336 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
338 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
340 2010-03-02 Marek Safar <marek.safar@gmail.com>
342 * cs-tokenizer.cs: Missed few locations in previous fix.
344 2010-03-02 Marek Safar <marek.safar@gmail.com>
346 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
347 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
348 Report correct location for operator errors.
350 2010-03-02 Marek Safar <marek.safar@gmail.com>
352 * typemanager.cs (IsDynamicType): Don't check external types when
353 the attribute is not external.
355 2010-02-24 Marek Safar <marek.safar@gmail.com>
357 A fix for bug #582579
358 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
361 2010-02-24 Marek Safar <marek.safar@gmail.com>
363 A fix for bug #581804
364 * ecore.cs: Fixed type comparison.
366 2010-02-08 Miguel de Icaza <miguel@novell.com>
368 * namespace.cs (CompletionGetTypesStartingWith): Do not include
369 private types in the completion results.
371 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
374 2010-02-17 Marek Safar <marek.safar@gmail.com>
376 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
379 2010-02-14 Miguel de Icaza <miguel@novell.com>
381 * eval.cs: Do not do the report printer dance unless the user has
382 set the DescribeTypes feature.
384 2010-02-10 Marek Safar <marek.safar@gmail.com>
386 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
388 2010-02-08 Marek Safar <marek.safar@gmail.com>
390 A fix for bug #577029
391 * anonymous.cs: Fixed TypeBuilder* check.
393 2010-02-06 Miguel de Icaza <miguel@novell.com>
395 * eval.cs (CompileBlock): Also undo if there are problems during
396 semantic analysis, fixes various cases where invalid C# code would
397 be reported, but the internal changes would not be undone.
399 2010-02-03 Miguel de Icaza <miguel@novell.com>
401 * driver.cs: Change the --fatal flag to allow a number to be
402 passed, this ignores the first N fatal errors. Useful to debug
403 errors that do not happen on the first hit.
405 * cs-parser.jay (invocation_expression): accept both the
406 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
407 inside an invocation.
409 * driver.cs: Expose FatalErrors.
411 * eval.cs: Initialize the printer's Fatal property from the
412 Driver's FatalError flag, this allows csharp --fatal to work
415 Add support for calling Describe (typeof (TYPE)) if the expression
418 2010-02-02 Marek Safar <marek.safar@gmail.com>
420 A fix for bug #574991
421 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
424 2010-02-02 Marek Safar <marek.safar@gmail.com>
426 A fix for bug #575986
427 * expression.cs: Don't mutate typeof type definitions.
429 2010-01-28 Marek Safar <marek.safar@gmail.com>
431 * decl.cs: Use only one set of modifiers.
433 2010-01-26 Marek Safar <marek.safar@gmail.com>
435 A fix for bug #573329
436 * eval.cs: Don't disable error reporting completely on silent mode.
438 2010-01-25 Marek Safar <marek.safar@gmail.com>
440 A fix for bug #573312
441 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
442 pointer index of unknown size types greater than 2.
444 2010-01-15 Marek Safar <marek.safar@gmail.com>
446 * *.cs: Use only 1 member kind enum.
448 2010-01-15 Marek Safar <marek.safar@gmail.com>
450 * *.cs: Add event specification.
452 2010-01-14 Marek Safar <marek.safar@gmail.com>
454 * membercache.cs: Extracted from decl.cs.
456 * *.cs: Put more infrastructure in place.
458 2010-01-13 Marek Safar <marek.safar@gmail.com>
460 * *.cs: Add property specification, unused yet.
462 2010-01-13 Marek Safar <marek.safar@gmail.com>
464 * property.cs: Move all property based declarations into a new file.
466 2010-01-13 Marek Safar <marek.safar at gmail.com>
468 * expression.cs (Conditional): Resolve reduced expression.
470 2010-01-13 Marek Safar <marek.safar at gmail.com>
472 * *.cs: Introduced non-generic method specification.
474 2010-01-07 Marek Safar <marek.safar@gmail.com>
476 * method.cs: Move all method based declarations into a new file.
478 2010-01-07 Marek Safar <marek.safar@gmail.com>
480 * *.cs: Extract field specification.
482 2009-12-17 Marek Safar <marek.safar@gmail.com>
484 * field.cs: Extracted from class.cs
486 2009-12-15 Marek Safar <marek.safar@gmail.com>
488 * attribute.cs (GetFixedBuffer): Work on field definition only.
490 2009-12-15 Marek Safar <marek.safar@gmail.com>
492 * *.cs: Clean up NET_4_0 conditional where possible.
494 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
496 support.cs (DynamicType): Assembly property returns the assembly builder.
497 This is required due to how compiler context works in corlib.
499 2009-12-14 Marek Safar <marek.safar@gmail.com>
501 A fix for bug #564376
502 * assign.cs (LocalTemporary): Removed no longer needed special
505 2009-12-11 Marek Safar <marek.safar@gmail.com>
507 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
508 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
509 enum for easier debugging.
511 2009-12-10 Marek Safar <marek.safar@gmail.com>
513 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
516 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
519 2009-12-10 Marek Safar <marek.safar@gmail.com>
521 * cs-parser.jay, statement.cs: Handle parser error in code
524 2009-12-10 Marek Safar <marek.safar@gmail.com>
526 * ecore.cs: Ignore base imported methods when they are already
529 * eval.cs: Handle non-existent keys.
531 * report.cs, driver.cs: Make fatal work with console printer only.
533 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
535 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
537 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
539 * typemanager.cs: Add MakeGenericMethod that checks if the method
540 is really the generic method definition.
542 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
543 to inflate generic methods.
545 2009-12-08 Marek Safar <marek.safar@gmail.com>
547 A fix for bug #561149
548 * anonymous.cs: Use actual type parameters when checking for generic
551 2009-12-08 Marek Safar <marek.safar@gmail.com>
553 A fix for bug #561369
554 * expression.cs (DoNumericPromotion): Fixed typo.
556 2009-12-08 Marek Safar <marek.safar@gmail.com>
558 *.cs: Moving to generics world.
560 cs-parser.jay: Removed current_array_type.
562 2009-12-07 Marek Safar <marek.safar@gmail.com>
564 *.cs: Moving to generics world.
566 2009-12-04 Marek Safar <marek.safar@gmail.com>
568 *.cs: Moving to generics world (day 2).
570 2009-12-03 Marek Safar <marek.safar@gmail.com>
572 *.cs: Moving to generics world.
574 2009-12-02 Marek Safar <marek.safar@gmail.com>
576 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
577 Encode dynamic type attribute for elements where attributes cannot
580 2009-12-01 Marek Safar <marek.safar@gmail.com>
582 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
585 2009-12-01 Marek Safar <marek.safar@gmail.com>
587 A fix for bug #360455
588 * class.cs: Never report a unused warning for generic events to
589 workaround wrong expression type.
591 2009-11-30 Marek Safar <marek.safar@gmail.com>
593 A fix for bug #558305
594 * decl.cs, class.cs: Check partial method definitions using correct
597 2009-11-30 Marek Safar <marek.safar@gmail.com>
599 * argument.cs: Don't cache rarely used dynamic flag.
601 2009-11-27 Marek Safar <marek.safar@gmail.com>
603 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
605 2009-11-27 Marek Safar <marek.safar@gmail.com>
607 * ecore.cs (SimpleName): Removed no longer needed in_transit as
608 Resolve is now non-reentrant (saves ~0.6MB for corlib).
610 2009-11-26 Marek Safar <marek.safar@gmail.com>
612 A fix for bug #545081
613 * decl.cs: Check private nested types of nested types recursively.
615 2009-11-26 Marek Safar <marek.safar@gmail.com>
617 A fix for bug #558305
618 * location.cs: Ignore self referencing #line directive
620 2009-11-26 Marek Safar <marek.safar@gmail.com>
622 A fix for bug #558292
623 * class.cs: Allow single unsafe fixed buffer fields.
625 2009-11-26 Marek Safar <marek.safar@gmail.com>
627 * expression: Optimize few more zero-based operations.
629 2009-11-26 Marek Safar <marek.safar@gmail.com>
631 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
632 avoids boxing of literal values.
634 2009-11-26 Marek Safar <marek.safar@gmail.com>
636 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
637 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
638 codegen.cs: LocatedToken redesing to avoid excessive allocation and
639 boxing (saves ~7MB for corlib). Also fixes presise token location.
641 2009-11-25 Marek Safar <marek.safar@gmail.com>
643 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
646 2009-11-24 Marek Safar <marek.safar@gmail.com>
648 * expression.cs: Lower static array initializer barrier.
650 * support.cs, driver.cs: Share reader buffer.
652 2009-11-23 Marek Safar <marek.safar@gmail.com>
654 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
656 2009-11-23 Marek Safar <marek.safar@gmail.com>
658 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
659 cleanup some obsolete code.
661 2009-11-20 Marek Safar <marek.safar@gmail.com>
663 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
666 2009-11-20 Marek Safar <marek.safar@gmail.com>
668 * *.cs: Resolved expressions are never resolved again, this helps to
669 uncover some not easy to find bugs and improve the performance.
671 2009-11-19 Marek Safar <marek.safar@gmail.com>
673 * *.cs: Made constant expressions fully compatible with any other
676 2009-11-19 Marek Safar <marek.safar@gmail.com>
678 * *.cs: DoResolve is a worker method and has to be protected.
680 2009-11-18 Marek Safar <marek.safar@gmail.com>
682 * *.cs: More context specific handling.
684 2009-11-17 Marek Safar <marek.safar@gmail.com>
686 * *.cs: More context specific handling.
688 2009-11-16 Marek Safar <marek.safar@gmail.com>
690 * dynamic.cs, class.cs: Removed few fixed user types conversions.
692 * symbolwriter.cs: Uses public ILOffset.
694 2009-11-13 Marek Safar <marek.safar@gmail.com>
696 A fix for bug #553650
697 * generic.cs: Another missing TypeToCoreType, still too many to fix.
699 2009-11-13 Marek Safar <marek.safar@gmail.com>
701 A fix for bug #555170
703 * class.cs, delegate.cs, enum.cs: Constants have to be available
704 for parameters resolve.
706 2009-11-12 Marek Safar <marek.safar@gmail.com>
708 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
711 2009-11-12 Marek Safar <marek.safar@gmail.com>
713 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
714 with a statically known candidate set.
716 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
718 * generic.cs: Made type inflation for generic constraint checks
719 recursive. This fixes BGO #553655.
721 2009-11-11 Marek Safar <marek.safar@gmail.com>
723 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
726 2009-11-10 Marek Safar <marek.safar@gmail.com>
728 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
729 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
730 attribute.cs: Add some dynamic error checking.
732 2009-11-07 Marek Safar <marek.safar@gmail.com>
734 A fix for bug #553465
736 * expression.cs: Fixed mixed version of expression tree anonymous
739 2009-11-06 Marek Safar <marek.safar@gmail.com>
741 A fix for bug #553031
743 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
744 expression tree version of anonymous type with members declaration.
746 2009-11-05 Marek Safar <marek.safar@gmail.com>
748 * parameter.cs: Handle nullable parameter default expression.
750 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
751 class.cs, attribute.cs: Check for wrong dynamic arguments.
753 2009-11-05 Marek Safar <marek.safar@gmail.com>
755 * statement.cs: Dynamic statements.
757 2009-11-04 Marek Safar <marek.safar@gmail.com>
759 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
760 Compound assignments over dynamic type.
762 2009-11-03 Marek Safar <marek.safar@gmail.com>
764 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
765 constructor arguments.
767 2009-10-30 Marek Safar <marek.safar@gmail.com>
769 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
770 codegen.cs: Unary mutator on dynamic member access expression.
772 2009-10-29 Marek Safar <marek.safar@gmail.com>
774 A fix for bug #550580
775 * convert.cs: Don't eliminate explicit precission casts.
777 2009-10-28 Marek Safar <marek.safar@gmail.com>
779 A fix for bug #550404
781 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
782 expression.cs, statement.cs, ecore.cs: Quote any nested expression
785 2009-10-27 Marek Safar <marek.safar@gmail.com>
787 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
790 * class.cs: Allow nullable binary user operators.
792 2009-10-26 Marek Safar <marek.safar@gmail.com>
794 * expression.cs: Move binary expression optimization at the end of
797 2009-10-23 Marek Safar <marek.safar@gmail.com>
799 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
800 Separate NullConstant from NullLiteral.
802 2009-10-23 Marek Safar <marek.safar@gmail.com>
804 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
805 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
806 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
807 ModuleContainer. Add common unclosed member check routine.
809 2009-10-22 Marek Safar <marek.safar@gmail.com>
811 * argument.cs: Use literal flag for real literals only.
813 * dynamic.cs: Use correct return type for custom delegates.
815 2009-10-22 Marek Safar <marek.safar@gmail.com>
817 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
820 2009-10-22 Marek Safar <marek.safar@gmail.com>
822 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
824 2009-10-21 Marek Safar <marek.safar@gmail.com>
826 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
829 2009-10-21 Marek Safar <marek.safar@gmail.com>
831 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
834 2009-10-20 Marek Safar <marek.safar@gmail.com>
836 * argument.cs, dynamic.cs, expression.cs: Latest API update.
838 2009-10-19 Marek Safar <marek.safar@gmail.com>
840 * typemanager.cs, expression.cs: Dynamic array initializer.
842 2009-10-16 Marek Safar <marek.safar@gmail.com>
844 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
847 2009-10-16 Marek Safar <marek.safar@gmail.com>
849 A fix for bug #493523, #507067
850 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
851 standard nullable conversion using underlying standard conversion
852 and not full conversion.
854 2009-10-15 Marek Safar <marek.safar@gmail.com>
856 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
857 type in VerifyArgumentsCompat.
859 2009-10-15 Marek Safar <marek.safar@gmail.com>
861 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
862 Reject variable used with type arguments.
864 2009-10-14 Marek Safar <marek.safar@gmail.com>
866 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
867 Implement dynamic expressions assignment.
869 2009-10-14 Marek Safar <marek.safar@gmail.com>
871 * expression.cs: Build underlying expression when resolving unary
874 2009-10-14 Marek Safar <marek.safar@gmail.com>
876 * expression.cs: Emit enum array initializer using binary blob.
878 2009-10-08 Marek Safar <marek.safar@gmail.com>
880 * typemanager.cs, constant.cs: Optimize decimal constants which fit
883 2009-10-07 Marek Safar <marek.safar@gmail.com>
885 * typemanager.cs: Reset object_type.
887 * assign: Made SimpleAssign public.
889 2009-10-06 Marek Safar <marek.safar@gmail.com>
891 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
892 invocation assembly to IsThisOrFriendAssembly.
894 2009-10-05 Marek Safar <marek.safar@gmail.com>
896 * expression.cs: Equality comparison of generic parameter with
899 2009-10-05 Marek Safar <marek.safar@gmail.com>
901 A fix for bug #543570
902 * generic.cs: Import predefined constraints correctly.
904 2009-10-02 Marek Safar <marek.safar@gmail.com>
906 * ecore.cs: Don't crash on overloads with optional paremeters where
907 arguments count overflows.
909 * parameter.cs: Import optional parameter constants using optional
912 2009-10-01 Marek Safar <marek.safar@gmail.com>
914 * Makefile: Default is gmcs compiler.
916 2009-10-01 Marek Safar <marek.safar@gmail.com>
918 * cs-parser.jay: Fixed few NRE.
920 2009-10-01 Marek Safar <marek.safar@gmail.com>
922 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
924 2009-09-30 Marek Safar <marek.safar@gmail.com>
926 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
927 ShimExpression, ImplicitCast.
929 2009-09-30 Marek Safar <marek.safar@gmail.com>
931 A fix for bug #542959
932 * delegate.cs: Emit correct delegate instance variable when there
933 are static and non-static overloads.
935 2009-09-29 Marek Safar <marek.safar@gmail.com>
937 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
938 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
940 2009-09-28 Marek Safar <marek.safar@gmail.com>
942 A fix for bug #542487
943 * ecore.cs: Resolve extension methods hidden by properties.
945 2009-09-25 Marek Safar <marek.safar@gmail.com>
947 * expression.cs, ecore.cs: More dynamic binary expressions.
949 2009-09-22 Marek Safar <marek.safar@gmail.com>
951 * nullable.cs, expression.cs: Fixed null lifted conversion for
952 bitwise enum operations.
954 2009-09-22 Marek Safar <marek.safar@gmail.com>
956 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
957 values in checked context.
959 2009-09-22 Marek Safar <marek.safar@gmail.com>
961 * expression.cs, ecore.cs: Fixed array index constant conversion.
963 2009-09-20 Miguel de Icaza <miguel@novell.com>
965 * expression.cs: Do not crash when MemberLookup returns something
966 that is not a MemberExpr here. Report error 582 instead.
970 2009-09-18 Marek Safar <marek.safar@gmail.com>
972 * decl.cs, class.cs: Check protected property accessors.
974 2009-09-18 Marek Safar <marek.safar@gmail.com>
976 * dynamic.cs, assign.cs: Dynamic compound assignment.
978 2009-09-17 Marek Safar <marek.safar@gmail.com>
980 * expression.cs: Fixed compound assignment explicit conversion.
982 2009-09-17 Marek Safar <marek.safar@gmail.com>
984 * expression.cs, ecore.cs: Cannot infer variables from method group.
986 2009-09-16 Marek Safar <marek.safar@gmail.com>
988 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
989 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
990 codegen.cs: Dynamic binary operations scaffolding.
992 2009-09-15 Marek Safar <marek.safar@gmail.com>
994 * expression.cs: Fixes nullable promotion for enum type variables.
996 2009-09-11 Marek Safar <marek.safar@gmail.com>
998 * driver.cs, dynamic.cs: Reset more static variables.
1000 2009-09-11 Marek Safar <marek.safar@gmail.com>
1002 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1003 driver.cs: Introduced Expression::MakeExpression.
1005 2009-09-11 Marek Safar <marek.safar@gmail.com>
1007 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1009 2009-09-09 Marek Safar <marek.safar@gmail.com>
1011 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1014 2009-09-09 Marek Safar <marek.safar@gmail.com>
1016 A fix for bug #518707
1017 * expression.cs (Is): Optimize only generic parameter type
1018 expression probing value type generic parameter.
1020 2009-09-09 Marek Safar <marek.safar@gmail.com>
1022 A fix for bug #532571
1023 * ecore.cs: Check for simple name type arguments used with
1026 2009-09-08 Marek Safar <marek.safar@gmail.com>
1028 A fix for bug #497421
1029 * generic.cs (CheckConstraint): Don't use buildin types to check for
1030 parameterless constructor.
1032 2009-09-08 Marek Safar <marek.safar@gmail.com>
1034 A fix for bug #537402
1035 * generic.cs (CheckConstraint): Correctly inflate generic type
1036 arguments when checking generic method.
1038 2009-09-08 Marek Safar <marek.safar@gmail.com>
1040 A fix for bug #536463
1041 * decl.cs (AddToContainer): Don't report collision between explicit
1042 and parameterless non-explicit members.
1044 2009-09-08 Marek Safar <marek.safar@gmail.com>
1046 * eval.cs: Reset more static stuff.
1048 2009-09-07 Marek Safar <marek.safar@gmail.com>
1050 A fix for bug #324625
1051 * expression.cs, ecore.cs: Create nested generic type expression
1052 using declaring and not current type.
1054 2009-09-07 Marek Safar <marek.safar@gmail.com>
1056 * *.cs: Changed Report class to accept various output printers and
1057 be an instance class. An expression resolver can now use different
1058 message reporter for each call and Report.Error can safely throw
1059 an exception. Part of ongoing work to turn mcs into proper library.
1061 2009-09-04 Marek Safar <marek.safar@gmail.com>
1063 * statement.cs, ecore.cs: Removed error reporting from emit code.
1065 2009-09-04 Marek Safar <marek.safar@gmail.com>
1067 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1069 2009-09-03 Marek Safar <marek.safar@gmail.com>
1071 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1072 parser checks out of constructors.
1074 2009-09-02 Marek Safar <marek.safar@gmail.com>
1076 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1078 2009-09-02 Marek Safar <marek.safar@gmail.com>
1080 A fix for bug #535448
1081 * anonymous.cs, class.cs: Copy return label between all contexts.
1083 2009-09-02 Marek Safar <marek.safar@gmail.com>
1085 A fix for bug #535395
1086 * namespace.cs: Resolve context can be null.
1088 2009-08-25 Marek Safar <marek.safar@gmail.com>
1090 A fix for bug #533912
1091 * generic.cs: Use correct context for constraints resolving.
1093 2009-08-25 Marek Safar <marek.safar@gmail.com>
1095 A fix for bug #532630
1096 * driver.cs: Trim conditional symbols.
1098 2009-08-25 Marek Safar <marek.safar@gmail.com>
1100 * context.cs: New file.
1102 * *.exe.sources, *.csproj: Updated.
1104 2009-08-25 Marek Safar <marek.safar@gmail.com>
1106 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1107 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1108 IMembercontext, some small cleanups.
1110 2009-08-24 Marek Safar <marek.safar@gmail.com>
1112 * *.cs: Split ResolveContext and EmitContext.
1114 2009-08-24 Marek Safar <marek.safar@gmail.com>
1116 * *.cs: Only ResolveContext implements IMemberContext.
1118 2009-08-21 Marek Safar <marek.safar@gmail.com>
1120 * *.cs: Renamed IResolveContext to IMemberContext.
1122 2009-08-21 Marek Safar <marek.safar@gmail.com>
1124 * *.cs: Detached ResolveContext from EmitContext.
1126 2009-08-21 Marek Safar <marek.safar@gmail.com>
1128 * codegen.cs: Moved flow-analysis to BlockContext.
1130 2009-08-21 Marek Safar <marek.safar@gmail.com>
1132 * *.cs: Detached BlockContext from EmitContext.
1134 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1136 * statement.cs: avoid nullref when the return value of GetEnumerator()
1137 does not contain any MoveNext() method.
1139 2009-08-19 Marek Safar <marek.safar@gmail.com>
1141 * *.cs: Removed IResolveContext::GenericDeclContainer.
1143 2009-08-19 Marek Safar <marek.safar@gmail.com>
1145 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1147 2009-08-19 Marek Safar <marek.safar@gmail.com>
1149 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1150 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1152 2009-08-18 Marek Safar <marek.safar@gmail.com>
1154 * *.cs: Removed boolean fields from EmitContext.
1156 2009-08-18 Marek Safar <marek.safar@gmail.com>
1158 * *.cs: Add IResolveContext::IsStatic.
1160 2009-08-18 Marek Safar <marek.safar@gmail.com>
1162 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1164 2009-08-17 Marek Safar <marek.safar@gmail.com>
1166 * *.cs: Removed DeclContainer from EmitContext.
1168 2009-08-17 Marek Safar <marek.safar@gmail.com>
1170 * *.cs: Add IResolveContext::CurrentTypeParameters.
1172 2009-08-14 Marek Safar <marek.safar@gmail.com>
1174 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1176 2009-08-14 Marek Safar <marek.safar@gmail.com>
1178 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1179 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1181 2009-08-13 Marek Safar <marek.safar@gmail.com>
1183 * decl.cs: Look in PartialContainer for parent type parameters.
1185 2009-08-13 Marek Safar <marek.safar@gmail.com>
1187 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1188 codegen.cs: Add IResolveContext::LookupTypeParameter.
1190 2009-08-13 Marek Safar <marek.safar@gmail.com>
1192 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1193 Moved resolved logic from Emit to Resolve.
1195 2009-08-13 Marek Safar <marek.safar@gmail.com>
1197 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1198 codegen.cs: Reworked atttributes handling of ResolveContext.
1200 2009-08-12 Marek Safar <marek.safar@gmail.com>
1202 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1203 LookupNamespaceOrType to ResolveContext.
1205 2009-08-12 Marek Safar <marek.safar@gmail.com>
1207 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1208 class.cs: Removed unused parameters and methods.
1210 2009-08-11 Marek Safar <marek.safar@gmail.com>
1212 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1213 codegen.cs: Finding the best common type of a set of expressions for
1216 2009-08-07 Marek Safar <marek.safar@gmail.com>
1218 * dynamic.cs, expression.cs: More dynamic conversions.
1220 2009-08-06 Miguel de Icaza <miguel@novell.com>
1222 * generic.cs: This loop was incorrect, it was increment ii, but
1223 checking for `i'. This was a change introduced to fix #327497,
1226 * class.cs: Catch another case for cs0533 error, fixes #324782.
1228 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1230 * typemanager.cs (GetGenericArguments): SRE returns null for
1231 generic methods on type builder instances if they are not generic
1232 themselves. For example, for Foo<int>::Bar() it returns null, but
1233 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1235 2009-08-05 Marek Safar <marek.safar@gmail.com>
1237 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1238 delegate.cs: Work on dynamic binding.
1240 2009-08-04 Marek Safar <marek.safar@gmail.com>
1242 A second fix for bug #525342
1243 * class.cs: Attach partial method attributes to method
1246 2009-08-03 Marek Safar <marek.safar@gmail.com>
1248 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1251 * rootcontext.cs: Default to langversion v4.
1253 2009-08-03 Marek Safar <marek.safar@gmail.com>
1255 * pending.cs: Check return type before member info is set.
1257 2009-08-03 Marek Safar <marek.safar@gmail.com>
1259 * anonymous.cs: Fully initialize generic hoisted field expression.
1261 2009-08-02 Miguel de Icaza <miguel@novell.com>
1263 * cs-parser.jay: Flag variables declared on the interactive shell
1264 as used to prevent the 168 warning about local variable not being
1267 2009-07-31 Marek Safar <marek.safar@gmail.com>
1269 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1270 attribute.cs: Emit dynamic export attribute.
1272 2009-07-30 Marek Safar <marek.safar@gmail.com>
1274 * expression.cs: More verifier work.
1276 2009-07-29 Marek Safar <marek.safar@gmail.com>
1278 * nullable.cs: Fixed SRE crash during corlib compilation.
1280 2009-07-29 Marek Safar <marek.safar@gmail.com>
1282 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1283 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1284 More TypeManager.TypeToCoreType needed.
1286 2009-07-29 Marek Safar <marek.safar@gmail.com>
1288 * anonymous.cs: Update after recent SRE fixes.
1290 2009-07-28 Marek Safar <marek.safar@gmail.com>
1292 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1293 version of GetFieldHandle for fields of generic types.
1295 2009-07-27 Marek Safar <marek.safar@gmail.com>
1297 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1298 ecore.cs: Add TypeManager.IsDynamicType,
1299 PredefinedAttributes.Dynamic.
1301 2009-07-27 Marek Safar <marek.safar@gmail.com>
1303 A fix for bug #415375
1304 * expression.cs: Fixed object and reference type parameter
1307 2009-07-27 Marek Safar <marek.safar@gmail.com>
1309 A fix for bug #525342
1310 * class.cs: Attach partial method attributes to method
1313 2009-07-24 Marek Safar <marek.safar@gmail.com>
1315 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1318 2009-07-24 Marek Safar <marek.safar@gmail.com>
1320 * anonymous.cs (MutateField): Add imported types handling.
1322 2009-07-23 Marek Safar <marek.safar@gmail.com>
1324 * expression.cs, delegate.cs: Moved arguments resolve into their
1325 counterparts expressions. Removed argument resolve from
1326 CollectionElementInitializer.
1328 2009-07-23 Marek Safar <marek.safar@gmail.com>
1330 A fix for bug #523683
1331 * convert.cs, delegate.cs: Use common overload mechanism for method
1332 group conversion check.
1334 2009-07-22 Marek Safar <marek.safar@gmail.com>
1336 A fix for bug #523899
1337 * generics.cs: Exact type inference with other bound types.
1339 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1341 Don't complain when the same type is implemented by the output
1342 assembly as well as multiple referenced assemblies
1343 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1344 'must_be_unique' flag.
1345 (GlobalRootNamespace): Update to changes.
1346 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1347 already have a type in hand.
1349 2009-07-22 Marek Safar <marek.safar@gmail.com>
1351 * expression.cs: More verifier instrumentation.
1353 * statement.cs: Do proper throw expression conversion.
1355 2009-07-22 Marek Safar <marek.safar@gmail.com>
1357 A fix for bug #522789
1358 * expression.cs: Mutate invocation return type.
1360 2009-07-16 Marek Safar <marek.safar@gmail.com>
1362 * anonymous.cs: Split assignable and readonly generated variable
1365 2009-07-16 Marek Safar <marek.safar@gmail.com>
1367 A fix for bug #521671
1368 * statement.cs: Fixed crash when checking missing type.
1370 2009-07-16 Marek Safar <marek.safar@gmail.com>
1372 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1373 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1374 class.cs, driver.cs: Work on dynamic binding.
1376 * dynamic.cs: New file.
1378 * *.sources, *.proj: Updated.
1380 2009-07-15 Marek Safar <marek.safar@gmail.com>
1382 * expression.cs (Conditional): Avoid double Resolve.
1384 2009-07-13 Marcus Griep <marcus@griep.us>
1386 * ecore.cs: Fix obscure bug with resolving members of interfaces
1387 that hide parent interface members. Fixes bug #444388 and corrects
1390 2009-07-13 Marek Safar <marek.safar@gmail.com>
1392 * expression.cs (LocalVariableReference): Bounce resolve.
1394 2009-07-10 Marek Safar <marek.safar@gmail.com>
1396 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1397 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1400 * support.cs: New dynamic type wrapper.
1402 2009-07-08 Marek Safar <marek.safar@gmail.com>
1404 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1405 typed local variable.
1407 2009-07-06 Marek Safar <marek.safar@gmail.com>
1409 A fix for bug #519005
1410 * anonymous.cs: Use null_type as no return type placeholder.
1412 2009-07-02 Marek Safar <marek.safar@gmail.com>
1414 * generic.cs: Handle type inference of identical type parameters
1415 with different bounds.
1417 2009-07-01 Marek Safar <marek.safar@gmail.com>
1419 * expression.cs, class.cs: Events variance.
1421 * cs-parser.jay: Interface events error messages.
1423 2009-07-01 Marek Safar <marek.safar@gmail.com>
1425 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1427 2009-06-29 Marek Safar <marek.safar@gmail.com>
1429 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1430 parameter expression can be value-type New.
1432 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1434 2009-06-26 Marek Safar <marek.safar@gmail.com>
1436 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1437 Implemented C# 4.0 named arguments.
1439 2009-06-24 Marek Safar <marek.safar@gmail.com>
1441 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1442 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1443 parameter modifier. Also fixes bug #515497.
1445 2009-06-24 Marek Safar <marek.safar@gmail.com>
1447 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1448 arguments expression to be implemented.
1450 *.sources: Add argument.cs
1452 2009-06-23 Marek Safar <marek.safar@gmail.com>
1454 * parameter.cs: Moved GetParameterIndexByName to base class.
1456 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1457 unused AType. Use argument's version of GetExpressionTree.
1459 2009-06-22 Marek Safar <marek.safar@gmail.com>
1461 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1464 2009-06-17 Marek Safar <marek.safar@gmail.com>
1466 A fix for bug #514096
1467 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1469 2009-06-17 Marek Safar <marek.safar@gmail.com>
1471 * expression.cs: The first multi-dimensional array nested array
1472 initializers was not checked.
1474 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1476 2009-06-17 Marek Safar <marek.safar@gmail.com>
1478 A fix for bug #513400
1479 * nullable.cs (EmitEquality): Operands emit could be simplified for
1480 built-in types when we now emit user operators differently.
1482 2009-06-16 Marek Safar <marek.safar@gmail.com>
1484 * ecore.cs: Report inaccessible delegate methods correctly.
1486 2009-06-16 Marek Safar <marek.safar@gmail.com>
1488 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1489 cs-parser.jay: Implemented C# 4.0 optional parameters.
1491 2009-06-16 Marek Safar <marek.safar@gmail.com>
1493 * driver.cs: Removed broken DefineManifestResource.
1495 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1497 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1498 Use $(BOOTSTRAP_PROFILE) instead.
1500 2009-06-12 Jb Evain <jbevain@novell.com>
1502 * rootcontext.cs: add a Platform field.
1503 * driver.cs: handle /platform.
1504 * codegen.cs: pass the proper flags according to
1505 the platform when saving the assembly.
1507 2009-06-11 Marek Safar <marek.safar@gmail.com>
1509 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1510 Add optional parameters grammar.
1512 2009-06-10 Marek Safar <marek.safar@gmail.com>
1514 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1515 driver.cs: Split lang version and metadata version.
1517 2009-06-10 Marek Safar <marek.safar@gmail.com>
1519 * decl.cs: Better overload ctor collision error message.
1521 2009-06-05 Jb Evain <jbevain@novell.com>
1523 * driver.cs (EmbededResource): avoid using an internal method
1524 in gmcs to embed manifest resources.
1526 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1528 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1529 the compiler from older mono versions (like moon's bots)
1531 2009-06-04 Marek Safar <marek.safar@gmail.com>
1533 * namespace.cs (LookupTypeReflection): Ignore collisions between
1536 2009-06-04 Marek Safar <marek.safar@gmail.com>
1538 * codegen.cs: Enabled generic type forwarders.
1540 2009-06-04 Marek Safar <marek.safar@gmail.com>
1542 * dmcs.*: Add another version of SRE compiler.
1544 2009-06-03 Marek Safar <marek.safar@gmail.com>
1546 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1547 generic-mcs.cs: Fixed variant type conversions.
1549 2009-06-02 Marek Safar <marek.safar@gmail.com>
1551 A fix for bug #507863
1552 * codegen.cs: Fixes a crash on invalid string value attribute.
1554 2009-06-01 Marek Safar <marek.safar@gmail.com>
1556 A fix for bug #508334
1557 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1558 cs-parser.jay: Fully import __arglist modifier.
1560 2009-05-29 Marek Safar <marek.safar@gmail.com>
1562 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1563 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1564 actually work with closed generic types.
1566 2009-05-27 Alan McGovern <amcgovern@novell.com>
1568 * class.cs, decl.cs, delegate.cs, parameter.cs:
1569 Fix the build by replacing the use of 'var' with the actual type.
1571 2009-05-27 Marek Safar <marek.safar@gmail.com>
1573 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1574 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1577 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1580 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1581 Marek Safar <marek.safar@gmail.com>
1583 A fix for bug #377509
1584 * parameter.cs: Use predefined and not empty name for implicit
1587 2009-05-21 Marek Safar <marek.safar@gmail.com>
1589 * class.cs: Don't report wrong warnings for event fields.
1591 2009-05-21 Marek Safar <marek.safar@gmail.com>
1593 A fix for bug #504667
1594 * class.cs: Check for static class using parent container instead of
1597 2009-05-08 Marek Safar <marek.safar@gmail.com>
1599 A fix for bug #496922
1600 * expression.cs: Always use temporary variable when using object
1603 2009-04-28 Marek Safar <marek.safar@gmail.com>
1605 A fix for bug #495112
1606 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1609 2009-04-27 Miguel de Icaza <miguel@novell.com>
1611 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1613 2009-04-24 Miguel de Icaza <miguel@novell.com>
1615 * complete.cs: No idea how gonzalo got a null in the list, but
1618 2009-04-24 Miguel de Icaza <miguel@novell.com>
1620 * complete.cs (CompletionElementInitializer): New completion class
1621 to support completing inside a C# 3 element initializer, so this
1622 allows completion for Silverlight situations where it is very
1625 new TextBlock () { Fo<TAB>
1627 (CompletionSimpleName): Expose the prefix that was
1628 passed to the simple name.
1630 * cs-parser.jay (object_or_collection_initializer): Add support
1631 for element_initializers.
1633 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1634 special case completion expressions as this method aggressively
1635 collects data before it operates, and errors were being thrown
1636 earlier than we were able to complete.
1638 2009-04-23 Miguel de Icaza <miguel@novell.com>
1640 * eval.cs: Make getcompletions silent and enable debugging output
1641 if the -v option is passed.
1643 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1644 Consider looking up the namespace that matches the prefix being
1647 This is part of the support for allowing completions like:
1648 `System.Co<TAB>' to complete to System.Console.
1650 * complete.cs (CompletionSimpleName.AppendResults): Make this
1653 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1655 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1656 COMPLETE_COMPLETION as internal.
1658 2009-04-17 Miguel de Icaza <miguel@novell.com>
1660 * complete.cs: Include namespace resolution in simple names as
1661 well as global types and types in the using scope in the
1664 * namespace.cs: Supporting infrastrcture to provide completions
1665 based on the current using scope.
1667 * eval.cs: Introduce an entry point that allows for initialization
1668 to return a list of the files passed on the command line.
1670 2009-04-14 Marek Safar <marek.safar@gmail.com>
1672 A fix for bug #494243
1673 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1675 2009-04-13 Marek Safar <marek.safar@gmail.com>
1677 A fix for bug #493887
1678 * statement.cs: Don't skip string multi-section with default or
1679 null label when populating string hashtable.
1681 2009-04-06 Marek Safar <marek.safar@gmail.com>
1683 A fix for bug #492329
1684 * expression.cs (New): Load variable when assigning type parameter
1687 2009-04-06 Marek Safar <marek.safar@gmail.com>
1689 A fix for bug #488960
1690 * decl.cs: Compare MVAR types using non-null values.
1692 2009-03-27 Marek Safar <marek.safar@gmail.com>
1694 * typemanager.cs, expression.cs: Removed unused nullable checks.
1696 2009-03-27 Marek Safar <marek.safar@gmail.com>
1698 * *.cs: Removed some gmcs conditionals.
1700 2009-03-26 Marek Safar <marek.safar@gmail.com>
1702 * generic.cs, support.cs: Moved generics stuff out of support.cs
1704 2009-03-24 Marek Safar <marek.safar@gmail.com>
1706 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1709 2009-03-23 Marek Safar <marek.safar@gmail.com>
1711 * attribute.cs: Consider all members for error reporting when
1712 checking named arguments.
1714 2009-03-23 Marek Safar <marek.safar@gmail.com>
1716 A fix for bug #487625
1717 * namespace.cs: Use a warning for all predefined type conflicts.
1719 2009-03-23 Marek Safar <marek.safar@gmail.com>
1721 A fix for bug #485706
1722 * statement.cs: Explicitly type catch type argument to pass verifier
1725 2009-03-22 Miguel de Icaza <miguel@novell.com>
1727 Initial support to provide code completion facilities to consumers
1728 of the evaluator API.
1730 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1731 support the completion engine. When we reach the end of the
1732 input stream instead of returning EOF, when this flag is true the
1733 tokenizer instead produces:
1735 One GENERATE_COMPLETION token: this token then must be
1736 handled in the grammar at every point where the user
1737 would likely request a completion.
1739 As many COMPLETE_COMPLETION tokens as necessary. These
1740 tokens are generated to assist the parser in unwinding and
1741 producing a valid parse tree.
1743 The parser rules do not have to be perfect, the parser needs to be
1744 augmented with judicious use of GENERATE_COMPLETION tokens to
1745 improve the areas where we can provide completion and the parser
1746 needs to add support for COMPLETE_COMPLETION tokens in productions
1749 It is common to not have enough support for COMPLETE_COMPLETION
1750 under certain rules and that even if we generated the
1751 GENERATE_COMPLETION token that the resulting tree will be invalid
1752 due to the missing rules that support COMPLETE_COMPLETION.
1754 The final EOF token is produced by having the parser notify the
1755 tokenizer when it reaches the root production that the next token
1758 * support.cs (CompletionResult): New Exception. This exception
1759 is thrown to return the completion results when one of the special
1760 completion expressions is reached.
1762 This exception is thrown by the completing ExpressionStatements
1763 classes that live in complete.cs
1765 * complete.cs (CompletingExpression): a new base class for
1766 completing expressions. This derives from the
1767 ExpressionStatement class and not from Expression as it allows
1768 completion to happen not only where expressions are expected in
1769 the grammar, but also where statements are expected.
1771 (CompletionSimpleName): A new class used to provide completions
1772 for SimpleNames. This currently only resolves to local
1773 variables from the evaluator context (GetVars call).
1775 (CompletionMemberAccess): Implements support for completing member
1778 * cs-parser.jay: Add support for completion in a few places.
1780 * eval.cs (GetCompletions): New public API for the evaluator that
1781 returns a list of possible completions given the input. The
1782 return value is an array of completions
1784 * anonymous.cs (Compatible): If the exception thrown from the
1785 resolved expression is a CompletionResult exception let that one
1786 through instead of printing a diagnostic error in the try/catch.
1788 2009-03-22 Miguel de Icaza <miguel@novell.com>
1792 * driver.cs (Main): Use Environment.Exit to quit quickly and
1793 prevent the compiler from doing the usual wait for helper thread
1796 This is to prevent a slowdown that was reported by Gonzalo on
1799 2009-03-19 Marek Safar <marek.safar@gmail.com>
1801 * ecore.cs: Load build-in types directly instead of accessing
1804 2009-03-18 Marek Safar <marek.safar@gmail.com>
1806 * ecore.cs: Always use unbox.any when available.
1808 2009-03-18 Marek Safar <marek.safar@gmail.com>
1810 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1812 2009-03-17 Marek Safar <marek.safar@gmail.com>
1814 * generic.cs: Removed obsolete version of type inference.
1816 2009-03-16 Marek Safar <marek.safar@gmail.com>
1818 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1819 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1820 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1821 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1823 2009-03-11 Marek Safar <marek.safar@gmail.com>
1825 A fix for bug #482996
1826 * anonymous.cs: Make sure we are not infering return type when
1827 checking type compatibility.
1829 2009-03-11 Marek Safar <marek.safar@gmail.com>
1831 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1832 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1833 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1834 attributes in their own structure. Needed when accessing their
1835 properties before they are resolved.
1837 2009-03-09 Marek Safar <marek.safar@gmail.com>
1839 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1840 hashtable (~10x faster).
1842 * driver.cs: Removed wrong Reset.
1844 2009-03-08 Marek Safar <marek.safar@gmail.com>
1846 * class.cs: Use correct common base type for unmanaged delayed
1849 * rootcontext.cs: Wrap unhandled exception.
1851 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1853 Make SeekableStreamReader self-tuning and arbitrarily seekable
1854 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1856 (SeekableStreamReader.Position.set): Use it. Simplify logic
1857 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1858 buffer size when the stream needs to be re-read from the beginning.
1860 2009-03-05 Marek Safar <marek.safar@gmail.com>
1862 A fix for bug #480100
1863 * parameter.cs: A parameter is not hoisted when used directly as ET.
1865 2009-03-04 Marek Safar <marek.safar@gmail.com>
1867 * statement.cs: Fixed an issue when using variable is of interface
1870 2009-03-03 Marek Safar <marek.safar@gmail.com>
1872 A fix for bug #480319
1873 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1875 2009-03-03 Marek Safar <marek.safar@gmail.com>
1877 A fix for bug #480867
1878 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1879 expression to have no valid type.
1881 2009-03-03 Marek Safar <marek.safar@gmail.com>
1883 A fix for bug #481258
1884 * class.cs: Set extension method flag in partial container.
1886 2009-03-03 Marek Safar <marek.safar@gmail.com>
1888 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1890 * attribute.cs: Add sanity check.
1892 2009-02-27 Marek Safar <marek.safar@gmail.com>
1894 * class.cs: Add external constructor error.
1896 2009-02-26 Marek Safar <marek.safar@gmail.com>
1898 A fix for bug #475354
1899 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1900 correctly user defined nullable equality operators.
1902 2009-02-25 Marek Safar <marek.safar@gmail.com>
1904 A fix for bug #479532
1905 * expression.cs: Implement NewInitialize::AddressOf.
1907 2009-02-25 Marek Safar <marek.safar@gmail.com>
1909 A fix for bug #413633
1910 * expression.cs: Iterate all base class-constraint types.
1912 2009-02-24 Marek Safar <marek.safar@gmail.com>
1914 A fix for bug #479209
1915 * literal.cs: Mutate null underlying type.
1917 2009-02-24 Marek Safar <marek.safar@gmail.com>
1919 A fix for bug #476295
1920 * convert.cs: Avoid wrapping implicitly convertible reference type.
1922 2009-02-23 Marek Safar <marek.safar@gmail.com>
1924 * iterators.cs: Create MemberName correctly.
1926 2009-02-23 Marek Safar <marek.safar@gmail.com>
1928 A fix for bug #478655
1929 * literal.cs: Check also underlying null type conversion.
1931 2009-02-21 Marek Safar <marek.safar@gmail.com>
1933 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1935 2009-02-20 Marek Safar <marek.safar@gmail.com>
1937 A fix for bug #477447
1938 * statement.cs: Add reference to correct parent storey when this
1939 is accessible from deep children storey (more than 1 level).
1941 2009-02-19 Marek Safar <marek.safar@gmail.com>
1943 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1944 * class.cs: Define base type members before setting up member cache.
1946 2009-02-18 Marek Safar <marek.safar@gmail.com>
1948 A fix for bug #477378
1949 * nullable.cs, expression.cs, statement.cs: More precise null type
1952 2009-02-18 Marek Safar <marek.safar@gmail.com>
1954 A fix for bug #472805
1955 * typemanager.cs, namespace.cs: Import only visible extension method
1958 2009-02-18 Marek Safar <marek.safar@gmail.com>
1960 A fix for bug #476895
1961 * attribute.cs: Use correct resolve context for attribute type.
1963 2009-02-18 Marek Safar <marek.safar@gmail.com>
1965 A fix for bug #476266
1966 * anonymous.cs: Mutate multi-dimensional arrays.
1968 2009-02-18 Marek Safar <marek.safar@gmail.com>
1970 A fix for bug #476400
1971 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1973 2009-02-18 Marek Safar <marek.safar@gmail.com>
1975 A fix for bug #476811
1976 * generics.cs: Fixed null-literal check.
1978 2009-02-17 Marek Safar <marek.safar@gmail.com>
1980 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1981 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1982 messing with static variables.
1984 2009-02-16 Marek Safar <marek.safar@gmail.com>
1986 A fix for bug #475965
1987 * generics.cs: Check generic parameter type after extracting from
1990 2009-02-16 Marek Safar <marek.safar@gmail.com>
1992 A fix for bug #475823
1993 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1996 2009-02-14 Marek Safar <marek.safar@gmail.com>
1998 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1999 Simplified event field definition using backing field and not
2000 field builder directly.
2002 * expression.cs (EmitLdArg): Optimize fast paths.
2004 2009-02-13 Marek Safar <marek.safar@gmail.com>
2006 A fix for bug #475327
2007 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2009 2009-02-13 Marek Safar <marek.safar@gmail.com>
2011 A fix for bug #475342
2012 * cs-parser.jay: Using 'super' instead of 'base' to call base
2013 constructor crashes compiler.
2015 2009-02-13 Marek Safar <marek.safar@gmail.com>
2017 A fix for bug #475354
2018 * expression.cs (Constantify): Add nullable types.
2020 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2022 2009-02-12 Marek Safar <marek.safar@gmail.com>
2024 A fix for bug #475246
2025 * expression.cs: More broken flowanalysis hacking needed.
2027 2009-02-12 Marek Safar <marek.safar@gmail.com>
2029 * attribute.cs: Compare only ref/out array modifiers.
2031 2009-02-11 Marek Safar <marek.safar@gmail.com>
2033 * statement.cs: Use member cache when looking for foreach members.
2035 2009-02-11 Marek Safar <marek.safar@gmail.com>
2037 * expression.cs: Don't expose internal initializer types.
2039 * statement.cs: Check also explicit conversions for goto case.
2041 2009-02-11 Marek Safar <marek.safar@gmail.com>
2043 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2045 2009-02-10 Marek Safar <marek.safar@gmail.com>
2047 * *.cs: Replace null-type with NullLiteral where appropriate.
2049 2009-02-09 Marek Safar <marek.safar@gmail.com>
2051 * expression.cs: Initializer of reference argument use temporary
2052 variable to be verifiable.
2054 * parameter.cs: Share EmitLdArg.
2056 2009-02-09 Marek Safar <marek.safar@gmail.com>
2058 A fix for bug #473559
2059 * class.cs: Fixed: Not reporting error about nested class with the
2062 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2064 Contributed under the MIT/X11 license.
2066 * generic.cs: Added VerifyVariantTypeParameters which performs new
2067 variance verification logic. The old logic, based on the spec, was
2068 wrong because the spec is full of LIES!
2070 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2072 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2075 * ecore.cs: Added calls to the new variance verification logic.
2078 * delegate.cs: Removed calls to the old variance verification logic.
2080 2009-02-06 Marek Safar <marek.safar@gmail.com>
2082 * delegate.cs: Use cached Invoke method directly.
2084 2009-02-06 Marek Safar <marek.safar@gmail.com>
2086 * expression.cs: Emit expression tree for hoisted variable access.
2088 2009-02-04 Marek Safar <marek.safar@gmail.com>
2090 * namespace.cs: Add better extension class check.
2092 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2094 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2096 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2098 This patch adds initial generic variance support to the compiler.
2099 It is contributed under the MIT/X11 license.
2101 * typemanager.cs: Modified ImplementsInterface to check variance.
2102 Added VerifyVariantTypeParameters which checks the specified type to see
2103 if it uses a variant type parameter as a type argument (which is not
2104 allowed). Added IsVariantOf which determins if the first type is a
2105 variant of the second. NOTE: This only supports reference types at
2106 the moment to conform with the current level of VM support. When the
2107 VM supports value types, this will follow step.
2109 * generic.cs: Added the Variance enum. Added a Variance property to
2110 TypeParameter and added variance support to definition phase. Added a
2111 Variance property to TypeParameterName. Also check to make sure that
2112 no variant types appear in generic method parameters.
2114 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2115 keywords if the langversion supports it.
2117 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2118 that variant types are only used in legal positions. Also added
2119 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2122 * decl.cs: Construct TypeParameter with the variance information.
2124 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2125 and ImplicitConversionStandard.
2127 * rootcontext.cs: Added new "Future" language version.
2129 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2130 type parameters are not used as type arguments in interface inheritance.
2131 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2132 parameters are not used as method return types. In MemberBase.
2133 ResolveMemberType, ensure that variant type parameters are not used
2134 as type arguments. Also call VerifyNoVariantTypeParameters on every
2135 set of parameters which are resolved.
2137 * delegate.cs: Modified Delegate.Define to ensure that variant
2138 parameters are not used as type arguments and that a contravariant
2139 parameter is not used as the return type. Also call
2140 VerifyNoVariantTypeParameters on the delegate parameters.
2142 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2143 to specify generic variance.
2145 * driver.cs: Added support for LanguageVersion.Future in the form of
2146 "-langversion:future".
2148 * generic-mcs.cs: Stubbed out new members in generic.cs.
2150 2009-02-03 Marek Safar <marek.safar@gmail.com>
2152 * class.cs, generic.cs: Emit type parameter constraints for nested
2155 2009-02-02 Marek Safar <marek.safar@gmail.com>
2157 A fix for bug #471213
2158 * class.cs: Avoid emitting backing field for abstract event fields.
2160 2009-02-01 Marek Safar <marek.safar@gmail.com>
2162 A fix for bug #359731
2163 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2166 2009-01-30 Marek Safar <marek.safar@gmail.com>
2168 A fix for bug #470767
2169 * statement.cs: Introduced BlockScopeExpression, needed when
2170 expression tree conversion has to emit scope variables.
2172 2009-01-29 Marek Safar <marek.safar@gmail.com>
2174 * class.cs: Remove duplicate CallingConvention.
2176 2009-01-29 Marek Safar <marek.safar@gmail.com>
2178 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2179 when I finally found the right naming convention.
2181 2009-01-29 Marek Safar <marek.safar@gmail.com>
2183 * cs-tokenizer.cs: Put back different open parens optimization.
2185 2009-01-28 Marek Safar <marek.safar@gmail.com>
2187 A fix for bug #470227
2188 * cs-tokenizer.cs: Remove too agressive parser optimization.
2190 2009-01-28 Marek Safar <marek.safar@gmail.com>
2192 A fix for bug #324319
2193 * class.cs: Remove too early base type resolve.
2195 2009-01-27 Marek Safar <marek.safar@gmail.com>
2197 A fix for bug #324319
2198 * ecore.cs: Explicitly type null when assigning to type argument to
2199 make pass verifier check.
2201 2009-01-27 Marek Safar <marek.safar@gmail.com>
2203 * anonymous.cs: Fixed recent regression when initializing captured
2206 2009-01-26 Marek Safar <marek.safar@gmail.com>
2208 A fix for bug #469019
2209 * anonymous.cs: Use all parent type parameters when instantiating
2210 nested generic storey.
2212 2009-01-26 Marek Safar <marek.safar@gmail.com>
2214 * expression.cs: Check for null instance methodgroup expression.
2216 2009-01-26 Marek Safar <marek.safar@gmail.com>
2218 A fix for bug #469244
2219 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2220 instance inside a conditional expression.
2222 2009-01-23 Marek Safar <marek.safar@gmail.com>
2224 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2225 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2226 GetElementType and HasElementType. IsValueType clean up.
2228 2009-01-23 Marek Safar <marek.safar@gmail.com>
2230 * nullable.cs: Use common EmitCall.
2232 * expression.cs: Emit constraint. for virtual calls only.
2234 2009-01-23 Marek Safar <marek.safar@gmail.com>
2236 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2237 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2238 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2241 2009-01-22 Jb Evain <jbevain@novell.com>
2243 * anonymous.cs: make anonymous types' ToString implementation
2244 match what csc outputs.
2246 2009-01-21 Marek Safar <marek.safar@gmail.com>
2248 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2251 2009-01-17 Marek Safar <marek.safar@gmail.com>
2253 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2256 2009-01-16 Marek Safar <marek.safar@gmail.com>
2258 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2261 2009-01-15 Marek Safar <marek.safar@gmail.com>
2263 A fix for bug #466634
2264 * statement.cs: Add reference for nested storey when only this
2267 2009-01-15 Marek Safar <marek.safar@gmail.com>
2269 A fix for bug #466474
2270 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2273 2009-01-15 Marek Safar <marek.safar@gmail.com>
2275 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2276 Fixed nested stories parent referencing process. Also fixes #463985.
2278 2009-01-06 Marek Safar <marek.safar@gmail.com>
2280 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2281 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2282 implementation. Also fixes #463108.
2284 2009-01-05 Marek Safar <marek.safar@gmail.com>
2286 A fix for bug #416109
2287 * decl.cs: Issue correct CLSAttribute warning location.
2289 2009-01-05 Marek Safar <marek.safar@gmail.com>
2291 A fix for bug #456775
2292 * attribute.cs: Use attribute owner scope when resolving attribute
2295 2009-01-05 Marek Safar <marek.safar@gmail.com>
2297 A fix for bug #457257
2298 * decl.cs: Fixed incorrect member declaring type comparison.
2300 2009-01-05 Marek Safar <marek.safar@gmail.com>
2302 A fix for bug #460896
2303 * driver.cs: Handle /RES resources as embeddable.
2305 2009-01-05 Marek Safar <marek.safar@gmail.com>
2307 A fix for bug #462515
2308 * ecore.cs: Report inacessible members upwards.
2310 2009-01-05 Marek Safar <marek.safar@gmail.com>
2312 A fix for bug #463190, #463192
2313 * decl.cs, namespace.cs: Also import internal extension classes.
2315 2009-01-04 Marek Safar <marek.safar@gmail.com>
2317 A fix for bug #463415
2318 * generic.cs: Use right index for RemoveDependentTypes.
2320 2009-01-02 Marek Safar <marek.safar@gmail.com>
2322 A fix for bug #463196
2323 * expression.cs: Fixed enum to null comparison.
2325 2009-01-02 Marek Safar <marek.safar@gmail.com>
2327 A fix for bug #463121
2328 * nullable.cs: Fixed nullable user equality operator comparison.
2330 2009-01-02 Marek Safar <marek.safar@gmail.com>
2332 A fix for bug #462950
2333 * class.cs, decl.cs: Use full explicit name when defining automatic
2334 property backing field.
2336 2009-01-02 Marek Safar <marek.safar@gmail.com>
2338 A fix for bug #462592
2339 * pending.cs: Emit type arguments for generic proxy method.
2341 2008-12-30 Marek Safar <marek.safar@gmail.com>
2343 * expression.cs (As): Mutate all type arguments.
2345 2008-12-29 Marek Safar <marek.safar@gmail.com>
2347 A fix for bug #462622
2348 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2351 2008-12-29 Marek Safar <marek.safar@gmail.com>
2353 A fix for bug #450782
2354 * ecore.cs: Consider more variables of form V.I to be fixed.
2356 2008-12-29 Marek Safar <marek.safar@gmail.com>
2358 A fix for bug #460712
2359 * typemanager.cs: Core types could be imported.
2361 2008-12-28 Marek Safar <marek.safar@gmail.com>
2363 A fix for bugs #460847, #460772, #458049, #457339, #447807
2364 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2365 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2366 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2367 user lambdas used inside query clauses.
2369 2008-12-18 Marek Safar <marek.safar@gmail.com>
2371 A fix for bug #460229
2372 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2374 2008-12-18 Marek Safar <marek.safar@gmail.com>
2376 A fix for bug #459952
2377 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2379 2008-12-18 Marek Safar <marek.safar@gmail.com>
2381 A fix for bug #459630
2382 * convert.cs: Enum to valuetype conversion is not allowed.
2384 2008-12-18 Marek Safar <marek.safar@gmail.com>
2386 A fix for bug #457087
2387 * generic.cs: Don't crash when constraint comes from type
2390 2008-12-16 Marek Safar <marek.safar@gmail.com>
2392 A fix for bug #459221
2393 * anonymous.cs, statement.cs: Delay only captured this
2396 2008-12-12 Marek Safar <marek.safar@gmail.com>
2398 A fix for bug #457489
2399 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2400 and initialization to capture scope initializers correctly.
2402 2008-12-11 Marek Safar <marek.safar@gmail.com>
2404 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2405 ParameterReference refactoring.
2407 2008-12-03 Marek Safar <marek.safar@gmail.com>
2409 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2410 to be imported from any assembly.
2412 2008-12-03 Marek Safar <marek.safar@gmail.com>
2414 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2415 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2416 from anonymous method and lambda expression.
2418 2008-12-01 Marek Safar <marek.safar@gmail.com>
2420 A fix for bug #448560
2421 * expression.cs (As): Box any generic type arguments to be
2424 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2426 Add tripwire for implicit conversion bugs
2427 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2429 (MethodGroupExpr.OverloadResolve): Add sanity check between
2430 IsApplicable and VerifyArgumentsCompat.
2431 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2433 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2435 Fix build break in System.Data_test
2436 * convert.cs (ImplicitConversionExists): Move NullLiteral
2438 (ImplicitStandardConversionExists): ... here.
2440 2008-11-28 Marek Safar <marek.safar@gmail.com>
2442 * literal.cs: Emit correctly explicit null to nullable cast.
2444 2008-11-28 Marek Safar <marek.safar@gmail.com>
2446 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2449 2008-11-28 Marek Safar <marek.safar@gmail.com>
2451 A fix for bug #449005
2452 * convert.cs, nullable.cs: Use only one implicit nullable
2455 2008-11-27 Marek Safar <marek.safar@gmail.com>
2457 * convert.cs, literal.cs: More Convert cleanup is needed.
2459 2008-11-27 Marek Safar <marek.safar@gmail.com>
2461 * decl.cs, class.cs: Fixed misleading error message.
2463 2008-11-26 Marek Safar <marek.safar@gmail.com>
2465 A fix for bug #449005
2466 * nullable.cs (EmitEquality): Disable optimization for user operator
2469 2008-11-25 Marek Safar <marek.safar@gmail.com>
2471 A fix for bug #447027
2472 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2473 with context variables stored as expression instances.
2475 2008-11-25 Marek Safar <marek.safar@gmail.com>
2477 A fix for bug #447027
2478 * delegate.cs: Fixed delegate VerifyMethod logic.
2480 2008-11-24 Marek Safar <marek.safar@gmail.com>
2482 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2485 2008-11-21 Marek Safar <marek.safar@gmail.com>
2487 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2488 member type resolve to follow normal flow, instead of random
2491 2008-11-21 Marek Safar <marek.safar@gmail.com>
2493 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2496 2008-11-21 Marek Safar <marek.safar@gmail.com>
2498 * const.cs: Emit decimal array constant as literal.
2500 2008-11-20 Marek Safar <marek.safar@gmail.com>
2502 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2504 2008-11-19 Marek Safar <marek.safar@gmail.com>
2506 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2507 into real property (saves 8 MB for corlib compilation).
2509 2008-11-19 Marek Safar <marek.safar@gmail.com>
2511 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2512 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2513 generic-mcs.cs: Small cleanup of TypeArguments.
2515 2008-11-18 Marek Safar <marek.safar@gmail.com>
2517 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2518 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2519 of ConstructedType expression, renamed to GenericTypeExpr.
2521 2008-11-17 Marek Safar <marek.safar@gmail.com>
2523 A fix for bug #445303
2524 * location.cs (IsConditionalDefined): Handle undefined global
2527 2008-11-17 Marek Safar <marek.safar@gmail.com>
2529 A fix for bug #444678
2530 * expression.cs (TryReduceConstant): Always create new constant
2533 2008-11-17 Marek Safar <marek.safar@gmail.com>
2535 A fix for bug #444673
2536 * ecore.cs: Ignore open generic types when used as generic type
2539 2008-11-17 Marek Safar <marek.safar@gmail.com>
2541 A fix for bug #445458
2542 * expression.cs, cs-parser.jay: Don't crash when an expression
2545 2008-11-17 Marek Safar <marek.safar@gmail.com>
2547 A fix for bug #445464
2548 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2549 inside unbound type.
2551 2008-11-14 Jb Evain <jbevain@novell.com>
2553 * driver.cs: ignore empty -nowarn argument such as
2554 the one in -nowarn:12,13,,.
2556 2008-11-13 Marek Safar <marek.safar@gmail.com>
2558 A fix for bug #444271
2559 * anonymous.cs: Rescan parent storeys when best candidate was
2562 2008-11-13 Marek Safar <marek.safar@gmail.com>
2564 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2565 useless UnboundTypeExpression.
2567 * attribute.cs: Do check obsolete attribute on generic types.
2569 2008-11-12 Marek Safar <marek.safar@gmail.com>
2571 A fix for bugs #425680, #400139
2572 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2575 2008-11-11 Marek Safar <marek.safar@gmail.com>
2577 A fix for bug #435747
2578 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2579 compound value types assignment. Few micro optimizations added.
2581 2008-11-10 Marek Safar <marek.safar@gmail.com>
2583 A fix for bug #442610
2584 * anonymous.cs (MutateConstructor): More SRE hacking.
2586 2008-11-10 Marek Safar <marek.safar@gmail.com>
2588 A fix for bug #442579
2589 * ecore.cs: Also initialize expanded form of a method with 1 params
2592 2008-11-06 Marek Safar <marek.safar@gmail.com>
2594 * expression.cs (UnaryMutator): Do early l-side check.
2596 2008-11-05 Miguel de Icaza <miguel@novell.com>
2598 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2599 Init, otherwise we would crash later on when checking for friend
2602 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2603 Otherwise we never get any meaningful information as to what
2606 2008-11-05 Marek Safar <marek.safar@gmail.com>
2608 A fix for bug #436318
2609 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2611 2008-11-05 Miguel de Icaza <miguel@novell.com>
2613 * namespace.cs: Turns out that it was a really bad idea to hide
2614 the errors for namespaces not found here in eval mode.
2616 * eval.cs: When we process using clauses, only enter those into
2617 the list of valid using clauses after they have been validated.
2619 The above change gives the proper semantics: it does not
2620 senselessly report the same errors with broken using statements by
2621 never storing them in the first place when they are invalid.
2623 2008-11-05 Marek Safar <marek.safar@gmail.com>
2625 A fix for bug #421839
2626 * cs-parser.jay: Remove expression from coalesce rule to force lower
2627 priority than the assignment operator.
2629 2008-11-05 Marek Safar <marek.safar@gmail.com>
2631 A fix for bug #437875
2632 * nullable.cs: Compile correctly method group operand used with null
2633 coalescing operator.
2635 2008-11-04 Marek Safar <marek.safar@gmail.com>
2637 A fix for bug #434589
2638 * expression.cs (Binary): Ignore lifted conversions when at least
2639 one operand is of reference type.
2641 2008-11-04 Marek Safar <marek.safar@gmail.com>
2643 * cs-parser.jay: Better syntax error report.
2645 2008-11-03 Marek Safar <marek.safar@gmail.com>
2647 A fix for bug #436792
2648 * cs-parser.jay: Use GetLocation to access location.
2650 2008-11-03 Marek Safar <marek.safar@gmail.com>
2652 A fix for bug #440774
2653 * cs-parser.jay: Also set current_array_type when parsing local
2656 2008-11-03 Marek Safar <marek.safar@gmail.com>
2658 A fix for bug #440785
2659 * expression.cs (As): Don't resolve self modifing expression
2662 2008-11-03 Marek Safar <marek.safar@gmail.com>
2664 A fix for bug #439447
2665 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2667 2008-11-03 Marek Safar <marek.safar@gmail.com>
2669 A fix for bug #437571
2670 * cs-parser.jay: Fixes internal error for invalid expression
2673 2008-10-17 Marek Safar <marek.safar@gmail.com>
2675 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2677 2008-10-17 Marek Safar <marek.safar@gmail.com>
2679 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2681 2008-10-17 Marek Safar <marek.safar@gmail.com>
2683 * cs-tokenizer.cs: More precise cast parsing.
2685 2008-10-16 Martin Baulig <martin@ximian.com>
2687 * anonymous.cs (AnonymousMethodStorey): Put back the
2688 `hoisted_locals' hashtable and use it in EmitType().
2690 2008-10-15 Marek Safar <marek.safar@gmail.com>
2692 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2693 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2696 2008-10-14 Marek Safar <marek.safar@gmail.com>
2698 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2700 2008-10-14 Marek Safar <marek.safar@gmail.com>
2702 * statement.cs: Mutate scope initializers.
2704 2008-10-14 Marek Safar <marek.safar@gmail.com>
2706 * expression.cs: Use typeless value for This constant.
2708 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2710 2008-10-14 Marek Safar <marek.safar@gmail.com>
2712 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2715 2008-10-13 Marek Safar <marek.safar@gmail.com>
2717 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2720 2008-10-13 Marek Safar <marek.safar@gmail.com>
2722 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2723 parser and tokenizer. Fixes many ambiguities including #433258.
2725 2008-10-10 Marek Safar <marek.safar@gmail.com>
2727 * cs-parser.jay: Fixed missing accessor recovery.
2729 2008-10-10 Marek Safar <marek.safar@gmail.com>
2731 A fix for bug #433701
2732 * expression.cs: Better error message.
2734 2008-10-10 Marek Safar <marek.safar@gmail.com>
2736 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2738 * Makefile: Disabled unused debug symbols.
2740 Also fixes: #320556, #321097, #321656, #321876, #351316
2742 2008-10-09 Miguel de Icaza <miguel@novell.com>
2744 * eval.cs: rename "<interactive>" to "{interactive}", to work
2745 around a requirement in the compiler that this be a valid
2746 filename, and in Windows it is not (433886).
2748 2008-10-09 Marek Safar <marek.safar@gmail.com>
2750 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2752 2008-10-08 Marek Safar <marek.safar@gmail.com>
2754 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2755 cs-parser.jay: Generic type declaration and type arguments cleanup.
2757 2008-10-05 Marek Safar <marek.safar@gmail.com>
2759 * cs-parser.jay: Allow parsing weird array creation construct.
2761 2008-10-05 Marek Safar <marek.safar@gmail.com>
2763 * cs-parser.jay: Conflicts reduction.
2765 2008-10-04 Marek Safar <marek.safar@gmail.com>
2767 * cs-parser.jay: Conflicts reduction.
2769 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2772 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2773 property. Add a 'count' hint about the use of the shared vector.
2774 Ensure that we don't leak out dirty bits.
2775 (UsageVector.MergeChild): Throw away information about variables
2777 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2779 2008-10-03 Marek Safar <marek.safar@gmail.com>
2781 A fix for bug #431746
2782 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2783 parameters when iterator is created.
2785 2008-10-03 Marek Safar <marek.safar@gmail.com>
2787 A fix for bug #431827
2788 * expression.cs: Fixed right based pointer arithmetic operations
2791 2008-10-03 Marek Safar <marek.safar@gmail.com>
2793 A fix for bug #353779
2794 * assign.cs, expression.cs: Fixed compound assignment conversions.
2796 2008-10-02 Marek Safar <marek.safar@gmail.com>
2798 A fix for bug #375262
2799 * statement.cs: Refactor ArrayForeach to be usable with string
2800 indexer. Optimized single dimentional arrays foreach.
2802 2008-10-02 Marek Safar <marek.safar@gmail.com>
2804 A fix for bug #431255
2805 * anonymous.cs, expression.cs: Removed broken optimization.
2807 2008-10-01 Marek Safar <marek.safar@gmail.com>
2809 * anonymous.cs: Use full type parameters of parent generic
2810 containers. Removed unnecessary AddParentStoreyReference call.
2812 2008-10-01 Marek Safar <marek.safar@gmail.com>
2814 A fix for bug #324702
2815 * class.cs: Use better shorter names for explicit interface member
2818 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2820 2008-10-01 Marek Safar <marek.safar@gmail.com>
2822 * expression.cs: Use new interface to check fixed expression.
2824 2008-10-01 Marek Safar <marek.safar@gmail.com>
2826 A fix for bug #421101
2827 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2828 interface to check for fixed fixed-buffers.
2830 2008-10-01 Marek Safar <marek.safar@gmail.com>
2832 A fix for bug #429264
2833 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2835 * delegate.cs: Removed unnecessary casts.
2837 2008-09-30 Marek Safar <marek.safar@gmail.com>
2839 A fix for bug #352151
2840 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2841 class.cs: Fixed already defined explicit interface members check.
2843 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2845 cs-tokenizer.cs: Fix typo.
2847 2008-09-28 Miguel de Icaza <miguel@novell.com>
2849 * eval.cs (InteractiveBase): The quit command now just sets a
2850 flag, instead of calling Environment.Exit(), it is milder on
2853 CompiledMethod is now in Mono.CSharp, not nested inside
2854 the Evaluator, it was inconvenient to use.
2856 2008-09-27 Miguel de Icaza <miguel@novell.com>
2858 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2859 code to be invoked without having to reparse.
2861 2008-09-27 Miguel de Icaza <miguel@novell.com>
2863 * ecore.cs: The recent changes to FieldExpr broke this as well.
2864 Fixes LINQ queries in the interactive shell.
2866 * Multiple files: indentation fixing for the Mono coding
2867 guidelines for the switch statement.
2869 * eval.cs: Make the Evaluator API thread safe.
2871 2008-09-26 Marek Safar <marek.safar@gmail.com>
2873 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2874 constructor parsing.
2876 2008-09-26 Marek Safar <marek.safar@gmail.com>
2878 A fix for bug #325326
2879 * statement.cs: Check possible mistaken empty statement using
2880 explicit blocks only.
2882 2008-09-25 Miguel de Icaza <miguel@novell.com>
2884 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2885 RootNamespace.ComputeNamespaces to update the internal list of
2886 namespaces, this is no longer done for us.
2888 (InteractiveBase): Use the Evaluator APIs instead of calling into
2891 2008-09-25 Marek Safar <marek.safar@gmail.com>
2893 A fix for bug #429264
2894 * expression.cs: Missing mutator for access to multidimensional
2897 2008-09-25 Marek Safar <marek.safar@gmail.com>
2899 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2902 * driver.cs: Missing input argument check.
2904 2008-09-25 Marek Safar <marek.safar@gmail.com>
2906 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2907 expression.cs, statement.cs, rootcontext.cs, class.cs,
2908 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2911 2008-09-24 Miguel de Icaza <miguel@novell.com>
2913 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2914 fully constructed FieldExpr, fixes the regression introduced in
2917 * ecore.cs, expression.cs: Plug back the eclass initialization as
2918 otherwise it regresses `csharp'.
2920 2008-09-24 Marek Safar <marek.safar@gmail.com>
2922 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2923 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2924 phase to resolve phase. It resolves problems with expression trees
2925 and fixes bugs #323796, #325156.
2927 2008-09-23 Marek Safar <marek.safar@gmail.com>
2929 * codegen.cs: Report better error when symbol writer is missing.
2931 2008-09-23 Marek Safar <marek.safar@gmail.com>
2933 * codegen.cs: Set .NET symbol writer.
2935 * decl.cs: Guard against null generic arguments.
2937 * report.cs: Don't report exactly same additional details.
2939 2008-09-22 Marek Safar <marek.safar@gmail.com>
2941 A fix for bug #324917
2942 * cs-parser.jay: Add missing multidimensional non-expression type
2945 2008-09-22 Marek Safar <marek.safar@gmail.com>
2947 A fix for bug #428191
2948 * anonymous.cs: Create an outer generic fields also for non-storey
2951 2008-09-22 Marek Safar <marek.safar@gmail.com>
2953 A fix for bug #378294
2954 * class.cs: Make fixed size buffers gmcs feature only.
2956 2008-09-22 Marek Safar <marek.safar@gmail.com>
2958 A fix for bug #355622, #324993
2959 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2962 2008-09-19 Marek Safar <marek.safar@gmail.com>
2964 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2967 2008-09-19 Marek Safar <marek.safar@gmail.com>
2969 A fix for bug #416110
2970 * generic.cs: Struct constraint results in default ctor and
2971 ValueType base type constraint to be set.
2973 2008-09-19 Marek Safar <marek.safar@gmail.com>
2975 A fix for bug #423791
2976 * generic.cs: Fixed params output type type-inference.
2978 2008-09-19 Marek Safar <marek.safar@gmail.com>
2980 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2982 2008-09-19 Marek Safar <marek.safar@gmail.com>
2984 * cs-tokenizer.cs: Don't break on extra partial modifier.
2986 2008-09-19 Marek Safar <marek.safar@gmail.com>
2988 A fix for bug #427592
2989 * generic.cs: Use common parameter resolve method.
2991 2008-09-18 Marek Safar <marek.safar@gmail.com>
2993 A fix for bug #414758
2994 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2997 2008-09-18 Marek Safar <marek.safar@gmail.com>
2999 * driver.cs, namespace.cs: Read types and namespaces after all
3000 requested assemblies are loaded, fixes issues with System.Core
3001 auto-reference, and #419888.
3003 2008-09-18 Marek Safar <marek.safar@gmail.com>
3005 A fix for bug #417705
3006 * cs-parser.jay: Fixed as/is operator expression split.
3008 2008-09-18 Marek Safar <marek.safar@gmail.com>
3010 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3011 Fixed expression tree representation of empty new expression and
3012 new initializer expression.
3014 2008-09-18 Miguel de Icaza <miguel@novell.com>
3016 * eval.cs: Remove warning, keep reference to driver around.
3018 * Hide fields that do not need to be public.
3020 2008-09-17 Marek Safar <marek.safar@gmail.com>
3022 A fix for bug #426385
3023 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3024 conversion for array elements.
3026 2008-09-17 Marek Safar <marek.safar@gmail.com>
3028 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3029 void parsing conflicts.
3031 2008-09-15 Marek Safar <marek.safar@gmail.com>
3033 A fix for bug #425601
3034 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3035 System.Core only when there is no custom ExtensionAttribute
3038 2008-09-15 Miguel de Icaza <miguel@novell.com>
3040 * namespace.cs: Do not report CS0246 (name
3042 2008-09-12 Marek Safar <marek.safar@gmail.com>
3044 A fix for bug #425669
3045 * generic.cs: Don't cache generic static anonymous method
3048 2008-09-12 Marek Safar <marek.safar@gmail.com>
3050 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3051 conflicting constraints.
3053 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3055 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3058 2008-09-12 Marek Safar <marek.safar@gmail.com>
3060 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3061 to null pointer conversion fixes.
3063 2008-09-11 Marek Safar <marek.safar@gmail.com>
3065 * cs-parser.jay, expression.cs: An implicitly typed local variable
3066 declarator cannot use an array initializer.
3068 2008-09-11 Marek Safar <marek.safar@gmail.com>
3070 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3072 2008-09-11 Marek Safar <marek.safar@gmail.com>
3074 * generic.cs (InflatedConstraints): Don't crash when constraints
3077 * cs-parser.jay: const_declarator is a block.
3079 * constant.cs: Check for not allowed NaN conversions.
3081 2008-09-10 Miguel de Icaza <miguel@novell.com>
3083 * driver.cs: Drop --shell argument, the compiler is no longer a
3086 * eval.cs: Move most of the code that deals with evaluation into
3087 this file and document the public API from repl.cs
3089 * repl.cs: Remove from here.
3091 2008-09-10 Marek Safar <marek.safar@gmail.com>
3093 A fix for bug #424684
3094 * generic.cs: Generic class constraints must come first.
3096 2008-09-09 Miguel de Icaza <miguel@novell.com>
3098 * cs-parser.jay: Improve error reporting for syntax errors in
3099 statements and expressions, we now report the expected tokens
3100 instead of reporting the useless "; expected".
3102 Drop the strings from the token declaration, it turns out that
3103 they did not do what I thought they did. Instead they were adding
3104 two sets of tokens to the tables.
3106 2008-09-09 Marek Safar <marek.safar@gmail.com>
3108 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3109 delegate.cs: Share special type check.
3111 2008-09-09 Marek Safar <marek.safar@gmail.com>
3113 A fix for bug #423981
3114 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3116 2008-09-09 Marek Safar <marek.safar@gmail.com>
3118 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3121 2008-09-09 Marek Safar <marek.safar@gmail.com>
3123 A fix for bugs: #324750, #335946
3124 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3125 lookup rule to determine ?-based tokens.
3127 2008-09-08 Miguel de Icaza <miguel@novell.com>
3129 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3130 expressions (like event adding or removing) end up here, so we
3131 need to treat those as statements.
3133 Add LoadAssembly method.
3135 2008-09-04 Miguel de Icaza <miguel@novell.com>
3137 * repl.cs: Add Time method.
3139 2008-09-05 Marek Safar <marek.safar@gmail.com>
3141 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3143 2008-09-05 Miguel de Icaza <miguel@novell.com>
3145 * repl.cs: Add workaround for old compilers.
3147 2008-09-04 Jb Evain <jbevain@novell.com>
3149 * repl.cs (PrettyPrint): pretty print everything that
3150 implements IDictionary, as well as IEnumerables. Also,
3151 add a quit helper property.
3153 2008-09-04 Marek Safar <marek.safar@gmail.com>
3155 * constant.cs: Better error reporting for decimal literals.
3157 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3160 2008-09-04 Marek Safar <marek.safar@gmail.com>
3161 Miguel de Icaza <miguel@novell.com>
3163 A fix for bug #422951
3164 * assign.cs (Assign.DoResolve): Perform the type conversions
3165 checks before we attempt to initialize `New' initializers.
3167 2008-09-04 Marek Safar <marek.safar@gmail.com>
3169 A fix for bug #422853
3170 * delegate.cs (DelegateCreation): Add special handling for
3171 EmptyExpression.Null instance expression which is just another
3172 hack for undecided member instance exression.
3174 2008-09-04 Marek Safar <marek.safar@gmail.com>
3176 * expression.cs, ecore.cs: Emit full expression tree for reduced
3179 2008-09-04 Marek Safar <marek.safar@gmail.com>
3181 * expression.cs (This): Guard against multi-resolving.
3183 * ecore.cs, statement.cs (Throw): Simplified.
3185 * flowanalysis.cs: Also verify event fields.
3187 2008-09-04 Miguel de Icaza <miguel@novell.com>
3189 * assign.cs (Assign.DoResolve): Perform the type conversions
3190 checks before we attempt to initialize `New' initializers.
3192 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3194 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3197 * repl.cs: Update help.
3199 2008-09-03 Miguel de Icaza <miguel@novell.com>
3201 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3202 handling of the default config handling, including the special
3203 treatment of System.Core assembly.
3205 Fixes the REPL processing for LINQ.
3207 2008-09-03 Marek Safar <marek.safar@gmail.com>
3209 A fix for bug #422507
3210 * expression.cs (UnboxCast): Add missing child expression mutator.
3212 2008-09-03 Marek Safar <marek.safar@gmail.com>
3214 * driver.cs: Don't self reference System.Core assembly.
3216 2008-09-03 Marek Safar <marek.safar@gmail.com>
3218 A fix for bug #422507
3219 * expression.cs (StringConcat): Add missing type mutator.
3221 2008-09-03 Marek Safar <marek.safar@gmail.com>
3223 * generic.cs (TypeInferenceContext): Follow equality rule for
3224 constructed type lower bound type inference.
3226 2008-09-02 Miguel de Icaza <miguel@novell.com>
3228 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3229 <dblank@cs.brynmawr.edu> which updates the cursor position on
3232 2008-09-02 Marek Safar <marek.safar@gmail.com>
3234 A fix for bug #367145
3235 * driver.cs: Fixed import of extension methods when using -noconfig
3238 2008-09-02 Marek Safar <marek.safar@gmail.com>
3240 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3241 version from non-generic implementation instead.
3243 2008-09-01 Marek Safar <marek.safar@gmail.com>
3245 A fix for bug #418908
3246 * class.cs: Use AddScopeStatement for field initializers.
3248 2008-09-01 Marek Safar <marek.safar@gmail.com>
3250 A fix for bug #415385
3251 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3253 2008-09-01 Marek Safar <marek.safar@gmail.com>
3255 A fix for bug #421736
3256 * iterators.cs: Don't crash on unreachable iterators.
3258 2008-09-01 Marek Safar <marek.safar@gmail.com>
3260 A fix for bug #421628
3261 * parameter.cs, attribute.cs: Clone also parameter attributes.
3263 2008-08-30 Miguel de Icaza <miguel@novell.com>
3265 * namespace.cs (LookupType): In EvalMode, try to replace
3266 the TypeBuilder from our cache with a Type as Reflection.Emit does
3267 not like to mix code from older assemblies emitted and new
3270 This sounds like a serious Mono bug that prevents multiple
3271 assemblies to be generated and consumed at the same time.
3273 * cs-parser.jay (push_current_class): Do not make interactive
3274 classes internal or private, make them public as we currently
3275 generate each new class in a new assembly.
3277 2008-08-29 Miguel de Icaza <miguel@novell.com>
3279 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3280 remove types that are entered into the global namespace during
3281 parsing so that we can remove them on failure.
3283 * cs-parser.jay: Parsing: we now keep track of types that are
3284 entered into global variables and queue those in case the parsing
3287 This happens in a few situations: during partial-input, we invoke
3288 the parser repeatedly for example with the string "class X", this
3289 would cause X to be registed, and we need to remove this
3290 registration so that another parse attempt later with say "class X {"
3291 would actually work.
3293 Additionally, if there is an error in the resolution phase, for
3294 example: "class X : NonExistant {}" th
3296 * cs-parser.jay: Be more precise with the errors being raised,
3297 instead of flagging all exceptions during parsing to be attributed
3298 to the parsing process, distinguish those from errors happening in
3299 the actions and hint that using -v would produce the actual
3302 * repl.cs: Do not load all compiler references on each reset,
3303 doing the partial reset takes care of this.
3305 2008-08-28 Miguel de Icaza <miguel@novell.com>
3307 * repl.cs: Add support for loading all the files from
3308 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3311 Introduce a micro-parser that is able to deambiguate on its input
3312 whether we are dealing with a compilation unit (namespace, class,
3313 interface, struct, delegate) declaration or a statement. This
3314 allows both declarations and statements to be entered.
3316 Set history size by default to 300 lines.
3318 Instead of distinguishing based on the parser.InteractiveResult,
3319 have only two cases: statements were parsed, or a compilation unit
3320 was. Always pull the Using statement additions from the
3321 compilation unit parse.
3323 * cs-tokenizer.cs: Rename tokens to better describe their intent
3324 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3326 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3327 EvalMode is used to trigger the lookup of global variables while
3328 StatementMode is used turn variable declarations into static
3331 * getline.cs: Allow history size to be set.
3333 2008-08-29 Marek Safar <marek.safar@gmail.com>
3335 A fix for bug #360755
3336 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3338 2008-08-29 Marek Safar <marek.safar@gmail.com>
3340 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3342 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3343 member name, it is too confusing
3345 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3347 * rootcontext.cs: Finally default to warning level 4.
3349 2008-08-28 Marek Safar <marek.safar@gmail.com>
3351 * class.cs (CheckBase): Ignore overloaded operators.
3353 2008-08-28 Marek Safar <marek.safar@gmail.com>
3355 A fix for bug #420830
3356 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3358 2008-08-28 Marek Safar <marek.safar@gmail.com>
3360 A fix for bug #420832
3361 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3363 2008-08-28 Marek Safar <marek.safar@gmail.com>
3365 A fix for bug #420386
3366 * nullables.cs: Fixed logic of nullable user comparison operators involving
3369 2008-08-28 Marek Safar <marek.safar@gmail.com>
3371 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3373 2008-08-27 Miguel de Icaza <miguel@novell.com>
3375 * repl.cs: Add support for aborting the running code with C-c.
3377 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3379 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3381 2008-08-27 Miguel de Icaza <miguel@novell.com>
3383 * cs-parser.jay (interactive_statement_list): A new set of rules
3384 for hosting statements that uses the "interactive_" prefix.
3386 * repl.cs: Add support for parsing `using' as a statement or as a
3387 directive. Deambiguating before passing this to the parser.
3389 We need to distinguish statement_expressions that occur at the
3390 toplevel vs those that occur embedded into expressions.
3392 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3393 that fixes the cursor key handling, and a history bug.
3395 2008-08-26 Miguel de Icaza <miguel@novell.com>
3397 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3398 limitations in Console, instead the 2.0 bootstrap libraries now
3399 include the Console bits.
3401 Also, remove the use of Nullables from getline.cs
3405 Interactive support for the C# compiler. Use gmcs --shell to
3406 enter a read-eval-print loop shell.
3408 Docs: http://www.mono-project.com/CsharpRepl
3410 * sources: include repl.cs here and getline.cs for gmcs.exe,
3411 everything else is getline.cs impaired.
3413 * Makefile: when bootstrapping pass a special flag
3414 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3415 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3416 This distinguishes those two cases.
3418 * repl.cs: Support for a read-eval-print loop. Will be soon
3419 refactored into eval support and then REPL on top of it.
3421 * ecore.cs: If a simplename lookup fails, before erroring out,
3422 if we are in EvalMode to resolve the name to a declaration in the
3425 This means that variable declarations that happened in previous
3426 classes (as repl puts every statement in a separate class) are
3427 made visible in this way.
3429 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3430 triggered an error due to the end of file being reached. This is
3431 used to do multi-line input, and notify the caller that the user
3432 needs to provide more text before a successful parse.
3434 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3435 to drive the evaluation with a custom wrapper.
3437 * driver.cs: Add support for --shell, and refactor some code to be
3440 * namespace.cs: Add support for serializing the contents of the
3441 namespaces and reloading them.
3443 * getline.cs: A managed implementation of ReadLine under
3444 X11/Apache2 license terms. Easy to embed in other applications as
3447 * namespace.cs: Add some functions to save and restore the
3450 * rootcontext.cs: New public field.
3452 * cs-tokenizer.cs: Add support for one of the possible characters
3453 we introduce into the token stream.
3455 This patch does not affect the regular tokenization process, the
3456 only performance hit would happen if there is an invalid character
3457 on the input string.
3459 * support.cs: Move isatty helper routine here.
3461 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3462 code generator for in-memory assemblies.
3464 2008-08-26 Marek Safar <marek.safar@gmail.com>
3466 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3467 parameter cannot be always used as a type.
3469 2008-08-21 Marek Safar <marek.safar@gmail.com>
3471 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3473 2008-08-21 Marek Safar <marek.safar@gmail.com>
3475 * convert.cs: Implement explicit array to IList<T> conversion.
3477 2008-08-20 Marek Safar <marek.safar@gmail.com>
3479 A fix for bug #362740
3480 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3482 2008-08-20 Marek Safar <marek.safar@gmail.com>
3484 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3485 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3486 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3487 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3488 handling to use just one type of infrastructure and deal with generics
3491 2008-07-23 Martin Baulig <martin@ximian.com>
3493 *** Merged this from trunk revision 108527 ***
3496 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3497 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3500 2008-08-15 Marek Safar <marek.safar@gmail.com>
3502 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3505 2008-08-15 Marek Safar <marek.safar@gmail.com>
3507 * delegate.cs: Fixed compiler crash when creating delegate using partial
3510 * typemanager.cs: MulticastDelegate is not a delegate.
3512 2008-08-14 Marek Safar <marek.safar@gmail.com>
3514 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3517 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3519 * cs-parser.jay (type): Allow 'var' in mcs too.
3520 (local_variable_type): Likewise.
3522 2008-08-14 Marek Safar <marek.safar@gmail.com>
3524 * driver.cs: Removed broken -noconfig variants.
3526 2008-08-14 Marek Safar <marek.safar@gmail.com>
3528 A fix for bug #417078
3529 * expression.cs: Emit correctly left side pointer operators.
3531 2008-08-13 Marek Safar <marek.safar@gmail.com>
3533 * generic.cs, lambda.cs: Inflate method generic arguments only.
3535 2008-08-12 Marek Safar <marek.safar@gmail.com>
3537 * class.cs: Fixed struct layout check regression.
3539 2008-08-12 Marek Safar <marek.safar@gmail.com>
3541 * cs-parser.jay, enum.cs: Simplified enum parsing.
3543 * decl.cs: Check all type parameters conflicts.
3545 * expression.cs, statement.cs, attribute.cs: More expression checks.
3547 2008-08-11 Marek Safar <marek.safar@gmail.com>
3549 * generic.cs: Add type inference types restriction.
3551 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3552 anonymous.cs, expression.cs: Allocate less accessor parameters.
3554 2008-08-08 Marek Safar <marek.safar@gmail.com>
3556 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3559 2008-08-08 Marek Safar <marek.safar@gmail.com>
3561 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3563 2008-08-07 Marek Safar <marek.safar@gmail.com>
3565 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3566 Also fixes #362146 and #381592.
3568 2008-08-07 Marek Safar <marek.safar@gmail.com>
3570 * ecore.cs: Reduced constant cannot be used as an attribute value.
3572 * cs-parser.jay: Base expression has to be a type.
3574 * expression.cs (Conditional): Uses ReducedExpression.
3576 2008-08-06 Marek Safar <marek.safar@gmail.com>
3578 A fix for bug #376826
3579 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3580 address of hoisted local variable or parameter cannot be taken.
3582 2008-08-05 Marek Safar <marek.safar@gmail.com>
3584 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3585 anonymous method inside checked/unchecked expression.
3587 2008-08-05 Marek Safar <marek.safar@gmail.com>
3589 * typemanager.cs (IsEqual): Guard against null.
3591 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3592 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3593 routine. Fixed few misleading conversion errors.
3595 2008-08-04 Marek Safar <marek.safar@gmail.com>
3597 * class.cs: Consider generics when checking cycles in struct layout.
3599 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3601 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3603 2008-08-04 Marek Safar <marek.safar@gmail.com>
3605 A fix for bug #414165
3606 * anonymous.cs: Use same anonymous implementation method for all anonymous
3609 2008-08-04 Marek Safar <marek.safar@gmail.com>
3611 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3614 2008-08-04 Marek Safar <marek.safar@gmail.com>
3616 * cs-parser.jay: Typeof argument has to be a type expression.
3618 * namespace.cs: Check alias and namespace definitions collisions.
3620 * class.cs, pending.cs: Moved explicit interface accessor implementation
3623 * delegate.cs, expression.cs: Verify special name invocations.
3625 2008-08-01 Marek Safar <marek.safar@gmail.com>
3627 * cs-parser.jay: Don't choke on empty generic type arguments.
3629 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3631 * expression.cs, ecore.cs: Minor expressions bugs.
3633 2008-08-01 Marek Safar <marek.safar@gmail.com>
3635 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3636 and added more error handling.
3638 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3640 * modifiers.cs, enum.cs: Fixed.
3642 2008-07-31 Jb Evain <jbevain@novell.com>
3644 * driver.cs: remove -pkg ability of smcs.
3646 2008-07-30 Marek Safar <marek.safar@gmail.com>
3648 * statement.cs (Switch): Correctly set empty default target for single
3651 2008-07-30 Marek Safar <marek.safar@gmail.com>
3653 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3654 string switch statement implementation to use string dictionary which
3655 significantly (2-8x) improves performance of generated code.
3657 2008-07-29 Marek Safar <marek.safar@gmail.com>
3659 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3660 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3662 2008-07-29 Marek Safar <marek.safar@gmail.com>
3664 A fix for bug #412595
3665 * typemanager.cs, convert.cs, expression.cs: Some types are never
3666 convertible to each other.
3668 2008-07-29 Marek Safar <marek.safar@gmail.com>
3670 * nullable.cs (CreateNullConstant): An error messages update.
3672 2008-07-29 Marek Safar <marek.safar@gmail.com>
3674 A fix for bug #412595
3675 * cfold.cs: Don't cast undefined bool constant.
3677 2008-07-29 Martin Baulig <martin@ximian.com>
3680 (SymbolWriter.Reset): New public static method.
3683 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3685 2008-07-28 Marek Safar <marek.safar@gmail.com>
3687 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3689 * expression.cs (ElementAccess): Exact size allocation.
3691 2008-07-26 Marek Safar <marek.safar@gmail.com>
3693 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3695 2008-07-25 Marek Safar <marek.safar@gmail.com>
3697 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3699 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3702 2008-07-25 Marek Safar <marek.safar@gmail.com>
3704 A fix for bug #412217
3705 * assign.cs: Mutate also assignment type.
3707 2008-07-25 Marek Safar <marek.safar@gmail.com>
3709 A fix for bug #323644
3710 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3713 2008-07-25 Marek Safar <marek.safar@gmail.com>
3715 A fix for bug #412134
3716 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3717 non-enumerable operands when overloading equality or bitwise operators.
3719 2008-07-25 Marek Safar <marek.safar@gmail.com>
3721 * anonymous.cs: Cache closed generic anonymous method delegates.
3723 2008-07-24 Marek Safar <marek.safar@gmail.com>
3725 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3726 anonymous.cs, statement.cs: Always emit anonymous method as static method
3727 when is instance free. Use nesting for nested anynomous methods blocks.
3729 2008-07-23 Marek Safar <marek.safar@gmail.com>
3731 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3734 2008-07-23 Marek Safar <marek.safar@gmail.com>
3736 * expression.cs: Removed MakeSimpleCall.
3738 2008-07-23 Marek Safar <marek.safar@gmail.com>
3740 A fix for bug #323012
3741 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3742 Base method implementing interface has to be public.
3744 2008-07-23 Marek Safar <marek.safar@gmail.com>
3746 * cs-parser.jay: Don't break on missing argument.
3748 2008-07-22 Marek Safar <marek.safar@gmail.com>
3750 A fix for bug #320993
3751 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3752 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3754 2008-07-22 Marek Safar <marek.safar@gmail.com>
3756 A fix for bug #320748
3757 * convert.cs: Implicit user operators cannot convert to interfaces
3759 2008-07-22 Marek Safar <marek.safar@gmail.com>
3761 A fix for bug #312686
3762 * driver.cs: Ignore empty assembly references.
3764 2008-07-22 Marek Safar <marek.safar@gmail.com>
3766 A fix for bug #387040
3767 * ecore.cs: Skip constrains check for an explicit implementation.
3769 2008-07-21 Marek Safar <marek.safar@gmail.com>
3771 A fix for bug #409045
3772 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3773 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3774 identifiers are file specific unless passed as input arguments.
3776 2008-07-21 Marek Safar <marek.safar@gmail.com>
3778 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3779 to emit UnmanagedMarshal data under 2.0 profile.
3781 2008-07-21 Marek Safar <marek.safar@gmail.com>
3783 A fix for bug #410369
3784 * parameter.cs: Clone correctly ParamsParameter.
3786 2008-07-21 Marek Safar <marek.safar@gmail.com>
3788 * expression.cs (Argument): Always report type for type based expressions
3791 2008-07-18 Marek Safar <marek.safar@gmail.com>
3793 A fix for bug #410666
3794 * anonymous.cs: Correctly initialize generic storey reference.
3796 2008-07-18 Marek Safar <marek.safar@gmail.com>
3798 * convert.cs: Don't box same type arguments.
3800 2008-07-18 Marek Safar <marek.safar@gmail.com>
3802 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3803 Finished missing generic type mutators.
3805 2008-07-18 Marek Safar <marek.safar@gmail.com>
3807 * iterators.cs, statement.cs: Finished statements CloneTo.
3809 2008-07-18 Marek Safar <marek.safar@gmail.com>
3811 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3813 * expression.cs: Emit optimized default value expressions in expression tree
3816 2008-07-18 Marek Safar <marek.safar@gmail.com>
3818 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3820 2008-07-17 Marek Safar <marek.safar@gmail.com>
3822 A fix for bug #367536
3823 * cs-parser.jay: Check static constructor of generic types for an access
3826 2008-07-17 Marek Safar <marek.safar@gmail.com>
3828 A fix for bug #353800
3829 * lambda.cs: Emit ret for contextual statements.
3831 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3832 up emitting redundant ret for all anonymous methods with return.
3834 2008-07-17 Marek Safar <marek.safar@gmail.com>
3836 A fix for bug #365188
3837 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3838 create anonymous method storey in unreachable block.
3840 2008-07-17 Marek Safar <marek.safar@gmail.com>
3842 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3843 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3844 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3845 statement.cs: Fixed relevant defects found by Gendarme.
3847 2008-07-17 Marek Safar <marek.safar@gmail.com>
3849 A fix for bug #325291
3850 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3851 statement.cs: Replaced IAnonymousHost with top level block flag.
3853 2008-07-17 Marek Safar <marek.safar@gmail.com>
3855 * cs-parser.jay: Clean up unused open_parens.
3857 2008-07-17 Marek Safar <marek.safar@gmail.com>
3859 * ecore.cs: Custom error message for a range variable assignment.
3861 2008-07-16 Marek Safar <marek.safar@gmail.com>
3863 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3866 2008-07-16 Marek Safar <marek.safar@gmail.com>
3868 * literal.cs: Null literal is of object type.
3870 2008-07-16 Marek Safar <marek.safar@gmail.com>
3872 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3873 expression of nullable equality comparison.
3875 2008-07-15 Marek Safar <marek.safar@gmail.com>
3877 * expression.cs(PointerArithmetic): Removed redundant assignment.
3879 2008-07-15 Marek Safar <marek.safar@gmail.com>
3881 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3883 2008-07-14 Marek Safar <marek.safar@gmail.com>
3885 A fix for bug #408361
3886 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3887 they are replaced by GetMethod.
3889 2008-07-14 Marek Safar <marek.safar@gmail.com>
3891 A fix for bug #408721 by jeremie.laval@gmail.com
3892 * expression.cs (Indirection): Implemented CloneTo.
3894 2008-07-14 Marek Safar <marek.safar@gmail.com>
3896 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3899 2008-07-14 Marek Safar <marek.safar@gmail.com>
3901 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3903 2008-07-11 Marek Safar <marek.safar@gmail.com>
3905 * linq.cs: Reset tranparent parameter counter in probing mode.
3907 2008-07-11 Marek Safar <marek.safar@gmail.com>
3909 * anonymous.cs: Mutate anonymous method type.
3911 2008-07-11 Marek Safar <marek.safar@gmail.com>
3913 * ecore.cs, anonymous.cs: Mutate field expressions.
3915 2008-07-10 Marek Safar <marek.safar@gmail.com>
3917 A fix for bug #369670
3918 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3920 2008-07-10 Marek Safar <marek.safar@gmail.com>
3922 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3924 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3927 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3928 only one '>', and finds a '>>', abort the generic lookahead.
3930 2008-07-10 Marek Safar <marek.safar@gmail.com>
3932 A fix for bug #319902
3933 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3935 2008-07-10 Marek Safar <marek.safar@gmail.com>
3937 A fix for bug #406371
3938 * statement.cs: Moved EmitSymbolInfo to Block.
3940 2008-07-09 Marek Safar <marek.safar@gmail.com>
3942 * ecore.cs: Report better error for extension method overload failures.
3944 2008-07-09 Marek Safar <marek.safar@gmail.com>
3946 * expression.cs (Is): No need to box reference values.
3948 2008-07-09 Marek Safar <marek.safar@gmail.com>
3950 * class.cs: Use event resolve context when initializing CreateEmitContext.
3952 2008-07-09 Marek Safar <marek.safar@gmail.com>
3954 A fix for bug #394436
3955 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3956 method used inside expression trees. Added more LINQ to expression tree
3959 2008-07-08 Marek Safar <marek.safar@gmail.com>
3961 A fix for bug #378189, #370577
3962 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3965 2008-07-08 Marek Safar <marek.safar@gmail.com>
3967 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3970 2008-07-08 Marek Safar <marek.safar@gmail.com>
3972 A fix for bug #406702
3973 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3975 2008-07-07 Marek Safar <marek.safar@gmail.com>
3977 A fix for bug #406648
3978 * cs-parser.jay: Report nullable use in mcs for some cases.
3980 2008-07-07 Marek Safar <marek.safar@gmail.com>
3982 * ecore.cs: Improved argument mismatch error messages.
3984 2008-07-07 Marek Safar <marek.safar@gmail.com>
3986 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3988 2008-07-07 Marek Safar <marek.safar@gmail.com>
3990 * expression.cs (TypeOf): Mutate type argument.
3992 2008-07-04 Marek Safar <marek.safar@gmail.com>
3994 * class.cs: Report missing partial modifier for correct type.
3996 2008-07-04 Marek Safar <marek.safar@gmail.com>
3998 * ecore.cs, expression.cs (VariableReference): Variable property is
4001 2008-07-04 Marek Safar <marek.safar@gmail.com>
4003 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4005 2008-07-04 Marek Safar <marek.safar@gmail.com>
4007 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4010 2008-07-04 Marek Safar <marek.safar@gmail.com>
4012 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4013 anonymous method storey to an instance method when only "this" is hoisted.
4015 2008-07-03 Marek Safar <marek.safar@gmail.com>
4017 A fix for bug #321615
4018 * expression.cs: Pointer comparisons use unsigned operator.
4020 2008-07-03 Marek Safar <marek.safar@gmail.com>
4022 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4024 2008-07-02 Marek Safar <marek.safar@gmail.com>
4026 A fix for bug #404905
4027 * class.cs: Always initialize local unsafe variables.
4029 2008-06-30 Marek Safar <marek.safar@gmail.com>
4031 A fix for bug #396987
4032 * expression.cs (NewInitialize): Clear local temporary variable for next run
4034 2008-06-27 Marek Safar <marek.safar@gmail.com>
4036 A fix for bug #401020
4037 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4039 2008-06-27 Marek Safar <marek.safar@gmail.com>
4041 A fix for bug #398319
4042 * cs-parser.jay: Implemented undocumented base access expression inside
4045 2008-06-26 Marek Safar <marek.safar@gmail.com>
4047 A fix for bug #404227
4048 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4050 2008-06-26 Marek Safar <marek.safar@gmail.com>
4052 A fix for bug #404227
4053 * convert.cs: Fixed explicit array to interface cast.
4055 2008-06-26 Marek Safar <marek.safar@gmail.com>
4057 A fix for bug #403894
4058 * delegate.cs: Mutate DelegateInvocation type.
4060 2008-06-26 Marek Safar <marek.safar@gmail.com>
4062 A fix for bug #379348
4063 * delegate.cs: Box a load of generic parameters.
4065 2008-06-26 Marek Safar <marek.safar@gmail.com>
4067 * expression.cs: Add an array creation arguments mutate.
4069 2008-06-26 Marek Safar <marek.safar@gmail.com>
4071 A fix for bug #386068
4072 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4075 2008-06-25 Marek Safar <marek.safar@gmail.com>
4077 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4080 2008-06-25 Marek Safar <marek.safar@gmail.com>
4082 A fix for bug #403518
4083 * delegate.cs: Type correctly anonymous method new invocation.
4085 2008-06-24 Marek Safar <marek.safar@gmail.com>
4087 A fix for bug #394826
4088 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4091 2008-06-24 Marek Safar <marek.safar@gmail.com>
4093 A fix for bug #394826
4094 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4097 2008-06-24 Marek Safar <marek.safar@gmail.com>
4099 * class.cs: Clone indexer parameters for localized capturing.
4101 2008-06-24 Marek Safar <marek.safar@gmail.com>
4103 A fix for bug #402379
4104 * expression.cs: Don't crash when an object initializer resolve fails.
4106 2008-06-24 Marek Safar <marek.safar@gmail.com>
4108 A fix for bug #402888
4109 * expression.cs: Mutate conditional expression.
4111 2008-06-24 Marek Safar <marek.safar@gmail.com>
4113 A fix for bug #401012
4114 * class.cs: Keep StructLayout in shared container.
4116 2008-06-24 Marek Safar <marek.safar@gmail.com>
4118 A fix for bug #400438
4119 * decl.cs, class.cs: Only properties can be automatically implemented.
4121 2008-06-24 Marek Safar <marek.safar@gmail.com>
4123 * statement.cs (ChangeToIterator): Copy also labels.
4125 2008-06-23 Marek Safar <marek.safar@gmail.com>
4127 * ecore.cs: Pass type argument details to parent extension method.
4129 2008-06-23 Marek Safar <marek.safar@gmail.com>
4131 A fix for bug #375966
4132 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4134 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4136 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4138 2008-06-22 Marek Safar <marek.safar@gmail.com>
4140 A fix for bug #394347
4141 * anonymous.cs: Cache compatible delegates as compatibility check produces
4142 a new method every time.
4144 2008-06-20 Marek Safar <marek.safar@gmail.com>
4146 * anonymous.cs: Propagate storey reference for single references.
4148 2008-06-20 Marek Safar <marek.safar@gmail.com>
4150 A fix for bug #387615
4151 * assign.cs, expression.cs: Correctly clone compound assignment.
4153 2008-06-19 Marek Safar <marek.safar@gmail.com>
4155 A fix for bug #359611, #359604
4156 * anonymous.cs: Mutate all types of hoisted parameters.
4158 2008-06-19 Marek Safar <marek.safar@gmail.com>
4160 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4161 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4162 expression.cs, codegen.cs, statement.cs
4164 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4165 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4167 ** Anonymous methods, lambda expressions rewrite **
4169 Anonymous expressions are now resolved when an explicit block is resolved
4170 and they don't require any registration procedure anymore. Further,
4171 anonymous methods are defined when explicit block is emitted which allows
4172 better control of whole process and opens possibilities for more
4173 optimizations as well as alternative to reverse whole process.
4175 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4176 process consistent and to correctly emit hoisted generic methods when they
4177 have at least 1 hoisted variable.
4179 2008-06-17 Martin Baulig <martin@ximian.com>
4181 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4183 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4184 virtual property; check it in Emit().
4185 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4187 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4189 (Indexer.Define): Likewise.
4191 2008-06-17 Marek Safar <marek.safar@gmail.com>
4193 * convert.cs: Don't use IsInterface on type arguments.
4195 * delegate.cs: DelegateInvocation uses MethodInfo.
4197 * parameter.cs: Removed IsTypeParameter.
4199 * generic-mcs.cs: More missing stuff.
4201 2008-06-16 Martin Baulig <martin@ximian.com>
4204 (Modifiers.DEBUGGER_HIDDEN): New public const.
4207 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4210 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4211 (AbstractPropertyEventMethod): Likewise.
4212 (Constructor.Emit): Likewise.
4213 (SourceMethod.SetCompilerGenerated): Removed.
4215 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4219 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4220 if we're an `IteratorHost'.
4221 (AnonymousMethodMethod..ctor): Don't set
4222 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4225 2008-06-16 Marek Safar <marek.safar@gmail.com>
4227 * statement.cs: Clean-up foreach statements.
4229 2008-06-12 Marek Safar <marek.safar@gmail.com>
4231 * class.cs: Stop using public method which should not exist
4232 (MethodBuilder.SetGenericMethodSignature).
4234 2008-06-11 Martin Baulig <martin@ximian.com>
4237 (Location.LookupFile): Add `CompilationUnit' argument; when given
4238 a relative file name, make it relative to the directory the .cs
4239 file is located in instead of using the current directory.
4241 2008-06-11 Martin Baulig <martin@ximian.com>
4244 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4245 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4246 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4247 (SourceMethod.SetCompilerGenerated): Likewise.
4249 2008-06-11 Marek Safar <marek.safar@gmail.com>
4251 * codegen.cs, driver: Only write symbol file when it's asked for.
4253 2008-06-11 Marek Safar <marek.safar@gmail.com>
4255 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4257 2008-06-10 Martin Baulig <martin@ximian.com>
4259 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4261 2008-06-09 Marek Safar <marek.safar@gmail.com>
4263 A fix for bug #316290
4264 * expression.cs: Include decimal operators in predefined table.
4266 * parameters.cs: More readonlyness.
4268 2008-06-09 Marek Safar <marek.safar@gmail.com>
4270 A fix for bug #397213
4271 * cs-parser.jay: One more missing current_local_parameters reset.
4273 2008-06-09 Marek Safar <marek.safar@gmail.com>
4275 A fix for bug #396633
4276 * class.cs: Host backing field in partial container.
4278 2008-06-09 Marek Safar <marek.safar@gmail.com>
4280 A fix for bug #397068
4281 * expression.cs: Check both operand types when predefined operator is used.
4283 2008-06-05 Martin Baulig <martin@ximian.com>
4285 Merged the `debugger-kahalo' branch.
4288 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4289 we're an iterator method.
4290 (SourceMethod): Reflect latest symbol writer changes;
4291 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4292 now `start_row' and `end_row'.
4293 (Constructor.Emit): Fix the logic whether to emit symbol information.
4295 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4299 (CompilationUnit): New public class; derives from `SourceFile'.
4300 (SourceFileEntry.DefineSymbolInfo): New public method.
4301 (SourceFileEntry.SetChecksum): New public method.
4302 (Location): Encode hidden line numbers by using `column == 255';
4303 the .ctor now accepts `column == -1' to mark a hidden line number.
4304 (Location.Hidden): New public property.
4305 (Location.CheckPoint): Add `CompilationUnit'.
4306 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4307 (Location.Push): Add `CompilationUnit compile_unit' argument.
4308 (Location.CompilationUnit): New public property.
4311 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4313 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4315 * driver.cs: `SourceFile' -> `CompilationUnit'.
4317 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4319 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4321 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4325 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4326 new symbol writer API to also pass the file.
4328 2008-06-05 Marek Safar <marek.safar@gmail.com>
4330 * statement.cs: Emit catch variable assignment using variable expression.
4332 2008-06-05 Marek Safar <marek.safar@gmail.com>
4334 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4335 with other variable types.
4337 2008-06-04 Marek Safar <marek.safar@gmail.com>
4339 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4340 GetLength method emit, it breaks resolve rules.
4342 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4343 Marek Safar <marek.safar@gmail.com>
4345 A fix for bug #395542
4346 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4349 2008-06-02 Marek Safar <marek.safar@gmail.com>
4351 A fix for bug #395287
4352 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4354 2008-05-31 Marek Safar <marek.safar@gmail.com>
4356 A fix for bug #395845
4357 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4358 non-nullable parameter type.
4360 2008-05-31 Marek Safar <marek.safar@gmail.com>
4362 * class.cs: Handle contructor initializer as a statement in top-level block.
4364 2008-05-30 Marek Safar <marek.safar@gmail.com>
4366 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4367 security attributes.
4369 2008-05-24 Marek Safar <marek.safar@gmail.com>
4371 * ecore.cs, expression.cs: Small IVariable refactoring.
4373 2008-05-22 Marek Safar <marek.safar@gmail.com>
4375 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4377 2008-05-21 Marek Safar <marek.safar@gmail.com>
4379 * cs-parser.jay: Removed redundant catch type check.
4381 2008-05-21 Marek Safar <marek.safar@gmail.com>
4383 A fix for bug #390372
4384 * nullable.cs: Set correct return type.
4386 2008-05-21 Marek Safar <marek.safar@gmail.com>
4388 A fix for bug #391062
4389 * typemanager.cs: Fixed crash when comparing null types.
4391 2008-05-21 Marek Safar <marek.safar@gmail.com>
4393 A fix for bug #391871
4394 * cs-parser.jay: Better error handling for invalid catch type.
4396 2008-05-20 Marek Safar <marek.safar@gmail.com>
4398 A fix for bug #392155
4399 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4401 2008-05-15 Marek Safar <marek.safar@gmail.com>
4403 A fix for bug #390666
4404 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4407 2008-05-15 Marek Safar <marek.safar@gmail.com>
4409 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4412 2008-05-13 Marek Safar <marek.safar@gmail.com>
4414 A fix for bug #389625
4415 * delegate.cs, generic.cs: Some progress on method group return type
4418 2008-05-13 Marek Safar <marek.safar@gmail.com>
4420 A fix for bug #378419
4421 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4423 2008-05-12 Marek Safar <marek.safar@gmail.com>
4425 * class.cs (Constructor): Added IsCompilerGenerated.
4427 2008-05-12 Marek Safar <marek.safar@gmail.com>
4429 * expression.cs: Enum binary operators can accept non-enum operand only when
4430 is implicitly convertible to underlying type.
4432 2008-05-12 Marek Safar <marek.safar@gmail.com>
4434 A fix for bug #389272
4435 * support.cs: Workaround System.InvalidOperationException for enums.
4437 2008-05-12 Marek Safar <marek.safar@gmail.com>
4439 A fix for bug #389073
4440 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4442 2008-05-10 Marek Safar <marek.safar@gmail.com>
4444 * driver.cs: Split Parse.
4446 * location.cs (LookupFile): Uses string.Empty.
4448 2008-05-07 Marek Safar <marek.safar@gmail.com>
4450 * expression.cs, parameter.cs: Small ParameterReference clean up.
4452 2008-05-07 Marek Safar <marek.safar@gmail.com>
4454 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4455 hack. Fixes #387502.
4457 2008-05-06 Martin Baulig <martin@ximian.com>
4459 * class.cs (Constructor.Emit): Fix the logic whether to emit
4462 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4465 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4466 InvalidOperationException when the iterator is before the start or
4469 2008-05-06 Marek Safar <marek.safar@gmail.com>
4471 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4472 when left is nullable type.
4474 2008-05-06 Marek Safar <marek.safar@gmail.com>
4476 A fix for bug #386628
4477 * expression.cs (LocalVariableReference): Continue in resolving when
4478 variable is not assigned.
4480 2008-05-05 Marek Safar <marek.safar@gmail.com>
4482 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4483 nullable operations.
4485 2008-05-04 Marek Safar <marek.safar@gmail.com>
4487 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4488 it saves many redundant temporary variables for nullable operations.
4490 2008-05-03 Marek Safar <marek.safar@gmail.com>
4492 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4494 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4497 * nullable.cs: Constant coalescing operator optimizations.
4499 2008-05-03 Marek Safar <marek.safar@gmail.com>
4501 * constant.cs: Use unsigned conversion for values which are unsigned only.
4503 2008-05-03 Marek Safar <marek.safar@gmail.com>
4505 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4506 coalescing operator as it should be.
4508 2008-05-02 Marek Safar <marek.safar@gmail.com>
4510 A fix for bug #371016
4511 * expression.cs: All predefined delegate operators require implicit method
4514 2008-05-02 Marek Safar <marek.safar@gmail.com>
4516 * constant.cs: Emit long constant as uint when fits the range.
4518 * convert.cs, expression.cs: Fixed few unsafe conversions.
4520 2008-05-02 Marek Safar <marek.safar@gmail.com>
4522 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4524 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4527 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4529 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4531 2008-05-01 Marek Safar <marek.safar@gmail.com>
4533 * constant.cs, literal.cs: IsLiteral property for error reporting.
4535 * ecore.cs, expression.cs: Implemented Property expression.
4537 2008-05-01 Marek Safar <marek.safar@gmail.com>
4539 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4541 * nullable.cs: Implemented nullable coalescing null operator.
4543 * ecore.cs, expression.cs: Expression trees work.
4545 2008-05-01 Marek Safar <marek.safar@gmail.com>
4547 * ecore.cs: CreateExpressionTree is finally abstract.
4549 * expression.cs, linq.cs: Updated.
4551 2008-05-01 Marek Safar <marek.safar@gmail.com>
4553 * expression.cs, ecore.cs: Block base access expression inside expression
4556 2008-05-01 Marek Safar <marek.safar@gmail.com>
4558 A fix for bug #385058
4559 * expression.cs: User-defined operator implementations always take
4560 precedence over predefined operator implementations.
4562 2008-04-30 Marek Safar <marek.safar@gmail.com>
4564 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4565 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4566 expression tree conversions.
4568 2008-04-30 Marek Safar <marek.safar@gmail.com>
4570 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4571 operators method details to Operator class.
4573 2008-04-30 Marek Safar <marek.safar@gmail.com>
4575 * anonymous.cs: Pass unsafe flags to anonymous container.
4577 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4578 inside expression tree.
4580 2008-04-29 Martin Baulig <martin@ximian.com>
4582 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4583 (Tokenizer.PopPosition): Also restore the `line'.
4585 2008-04-29 Marek Safar <marek.safar@gmail.com>
4587 * delegate.cs: Implemented Invoke expression.
4589 2008-04-29 Marek Safar <marek.safar@gmail.com>
4591 * expression.cs: Fixed equality reference comparison regression.
4593 2008-04-29 Marek Safar <marek.safar@gmail.com>
4595 * ecore.cs: Clean up EmptyCast hack.
4597 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4598 using correct conversion rules. Also fixes #383993.
4600 2008-04-28 Martin Baulig <martin@ximian.com>
4602 * class.cs (Constructor.Emit): Don't emit debugging information
4603 for generated default .ctor's.
4605 2008-04-28 Marek Safar <marek.safar@gmail.com>
4607 * convert.cs: Empty-cast ushort to int conversion.
4609 2008-04-28 Marek Safar <marek.safar@gmail.com>
4611 A fix for bug #384191
4612 * ecore.cs, expression.cs: Fixed expression cloning.
4614 2008-04-28 Marek Safar <marek.safar@gmail.com>
4616 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4618 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4620 Fix #381559, test-638.cs, test-639.cs
4621 * assign.cs (CompoundAssign.Helper): New wrapper.
4622 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4624 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4625 Pass unconverted expressions to the params array creation expression.
4626 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4627 (PropertyExpr.EmitAssign): Likewise.
4628 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4629 element if it is of kind CompoundAssign.Helper.
4630 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4631 first before anything else.
4632 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4633 (ArrayAccess.LoadArrayAndArguments): Simplify.
4635 2008-04-27 Marek Safar <marek.safar@gmail.com>
4637 * expression.cs: Fixed cloning of typeof(void).
4639 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4641 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4642 (Assign.Emit): Likewise. Move it to ...
4643 (CompoundAssign.DoResolve): ... here and ...
4644 (CompoundAssign.Emit): ... here.
4645 (EventAddOrRemove): New helper to handle += and -= on events, and
4646 avoid the use of BinaryDelegates.
4647 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4648 (EventExpr.EmitAddOrRemove): Improve.
4649 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4651 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4652 create VarExprs for 'foo.bar.var'.
4653 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4654 is a highly inappropriate name for its functionality.
4656 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4658 Simplify handling of multiple assignments
4659 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4661 (SimpleAssign): New. Class to be used for normal assignments.
4662 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4663 * expression.cs, parameter.cs, statement.cs: Likewise.
4665 2008-04-25 Marek Safar <marek.safar@gmail.com>
4667 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4668 for incompatible underlying types, more to come, uff.
4670 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4673 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4674 Handle 'leave_copy'.
4676 2008-04-25 Marek Safar <marek.safar@gmail.com>
4678 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4680 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4682 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4683 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4684 * statement.cs (While, Do, For): Allow test to have side effects.
4685 (For.DoEmit): Always emit InitStatement.
4688 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4689 Always create SideEffectConstant.
4690 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4691 of type EnumConstant.
4693 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4694 Handle 'right' being SideEffectConstant of type 'bool'.
4696 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4697 Use left.EmitBranchable instead of open coding it, so as to
4698 improve optimization opportunities.
4700 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4702 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4704 (Expression.EmitSideEffect): Document.
4706 2008-04-23 Marek Safar <marek.safar@gmail.com>
4708 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4710 2008-04-23 Marek Safar <marek.safar@gmail.com>
4712 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4714 2008-04-23 Marek Safar <marek.safar@gmail.com>
4716 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4717 conversion to expression tree.
4719 2008-04-23 Marek Safar <marek.safar@gmail.com>
4721 * ecore.cs: Removed unused expression.
4723 2008-04-22 Marek Safar <marek.safar@gmail.com>
4725 * expression.cs: Implemented NegateChecked and New expressions.
4727 2008-04-22 Marek Safar <marek.safar@gmail.com>
4729 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4731 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4734 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4735 needing final 'ret' instruction.
4737 2008-04-22 Marek Safar <marek.safar@gmail.com>
4739 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4741 2008-04-21 Marek Safar <marek.safar@gmail.com>
4743 * expression.cs: Emit ldnull and not null expression as an instance argument
4744 of static method expression calls.
4746 2008-04-21 Marek Safar <marek.safar@gmail.com>
4748 A fix for bug #378200
4749 * expression.cs: Fixed crash when creating parameterless expression tree
4752 2008-04-21 Marek Safar <marek.safar@gmail.com>
4754 A fix for bug #375297
4755 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4758 2008-04-21 Marek Safar <marek.safar@gmail.com>
4760 A fix for bug #377596
4761 * decl.cs, class.cs: Emit delegate type argument attributes.
4763 2008-04-21 Marek Safar <marek.safar@gmail.com>
4765 A fix for bug #365314
4766 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4768 2008-04-21 Marek Safar <marek.safar@gmail.com>
4770 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4773 2008-04-21 Marek Safar <marek.safar@gmail.com>
4775 * generic.cs (TypeParameter): Removed redundant location.
4777 2008-04-19 Marek Safar <marek.safar@gmail.com>
4779 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4780 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4781 FullNamedExpression in all declaration type expression, statements will come
4784 2008-04-18 Marek Safar <marek.safar@gmail.com>
4786 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4787 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4789 2008-04-18 Marek Safar <marek.safar@gmail.com>
4791 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4794 2008-04-17 Marek Safar <marek.safar@gmail.com>
4796 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4799 2008-04-17 Marek Safar <marek.safar@gmail.com>
4801 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4805 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4807 Hook up 'EmitSideEffect'
4808 * constant.cs (Constant.EmitSideEffect): New.
4809 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4810 (SideEffectConstant.EmitSideEffect): New.
4811 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4812 unconditional branch in EmitBranchable.
4813 (FieldExpr.EmitBranchable): New.
4814 * expression.cs (Unary.EmitSideEffect): New.
4815 (Binary.EmitSideEffect): New.
4816 (VariableReference.EmitSideEffect): New. Do nothing.
4818 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4820 Introduce 'EmitSideEffect'
4821 * ecore.cs (Expression.EmitSideEffect): New.
4822 (TypeCast): Rename from EmptyCast.
4824 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4825 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4826 * convert.cs, nullable.cs: Update to changes.
4828 2008-04-16 Marek Safar <marek.safar@gmail.com>
4830 * class.cs, cs-parser.jay: Early check for base types expression.
4832 2008-04-16 Marek Safar <marek.safar@gmail.com>
4834 * decl.cs (MemberName): Declare PrettyName as obsolete.
4836 2008-04-16 Marek Safar <marek.safar@gmail.com>
4838 * namespace.cs: Use MemberName comparison.
4840 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4843 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4845 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4846 (MemberName.FullyQualifiedName): New. Provides the functionality
4847 that users assume FullName would have.
4848 * ecore.cs, namespace.cs: Update to changes.
4850 * statement.cs (Using.assign): Make into ExpressionStatement.
4851 (Using.EmitPreTryBody): Simplify.
4853 2008-04-16 Marek Safar <marek.safar@gmail.com>
4855 * report.cs: ColorFormat is protected.
4857 * rootcontext.cs: Unused fields clean-up.
4859 * namespace.cs: Made UsingEntry name private.
4861 2008-04-16 Marek Safar <marek.safar@gmail.com>
4863 * cs-tokenizer.cs, location.cs: Removed unused field.
4865 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4866 Raja R Harinath <harinath@hurrynot.org>
4869 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4870 (SideEffectConstant.side_effect): Rename from 'right'.
4871 (SideEffectConstant..ctor): Normalize 'side_effect'.
4872 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4873 value of this constant.
4874 * cfold.cs: Update to changes.
4876 2008-04-15 Marek Safar <marek.safar@gmail.com>
4878 * cs-paser.jay: Removed unused variable.
4880 * driver.cs: Made Compile instance method.
4882 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4884 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4886 2008-04-15 Marek Safar <marek.safar@gmail.com>
4888 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4890 2008-04-13 Jb Evain <jbevain@novell.com>
4892 * namespace.cs: update the System.Core fullname for 2.1
4893 * driver.cs: update the list of required assemblies for 2.1.
4894 Merged from the Moonlight 2 branch.
4896 2008-04-11 Marek Safar <marek.safar@gmail.com>
4898 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4899 types and user defined operators. User operators arguments has to be checked
4900 for null value before invocation, which also means no operator is called
4901 when any argument is not convertible to unwrapped nullable type.
4903 2008-04-09 Marek Safar <marek.safar@gmail.com>
4905 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4906 of Unary expressions to follow operator overloading rules precisely.
4907 Also fixes #321794, #323794
4909 2008-04-08 Marek Safar <marek.safar@gmail.com>
4911 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4914 2008-04-08 Marek Safar <marek.safar@gmail.com>
4916 * expression.cs, ecore.cs: Implemented MemberInit expression.
4918 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4920 Fix mono/tests/exception4.cs
4921 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4922 ec.NeedReturnLabel () rather emitting a 'nop'.
4924 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4926 (TryCatch.SomeCodeFollows): Likewise.
4927 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4928 for 'break', 'continue' and 'return' statements inside a try.
4929 We're fairly sure that the generated IL stream will have more
4930 instructions textually following the try.
4931 (FlowBranchingTryCatch): Likewise.
4933 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4934 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4937 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4938 wrapper -- forward everything to CollectionForeach.
4939 (CollectionForeach.NonDisposableWrapper): New.
4940 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4941 instead of a pop + branch to end.
4943 2008-04-07 Marek Safar <marek.safar@gmail.com>
4945 A fix for bug #377485
4946 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4947 Propagate location for extension method groups. Report conversion failure at
4950 2008-04-07 Marek Safar <marek.safar@gmail.com>
4952 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4953 ListInit and Field expressions.
4955 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4957 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4958 Since $PC is always -1 inside the body of MoveNext, the fault
4960 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4961 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4962 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4964 The denouement! Fix #324708
4965 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4966 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4967 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4968 'finally' inside the finally clause.
4970 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4971 inside an iterator. Don't emit the body of the 'finally' inside
4972 the finally clause yet.
4974 Use the ResumableStatement infrastructure for MoveNext ()
4975 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4976 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4977 'old_resume_points'. Move dispatcher upfront.
4978 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4979 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4980 in an enumerator. This encodes the main fix in this patch series
4981 -- we can only jump into the first instruction of a try from the
4982 outside, but we want to emit try/finally regions in iterators and
4983 resume in the middle of them.
4985 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4987 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4988 of NeedReturnLabel here.
4990 Introduce a common point for emitting try/finally to IL
4991 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4992 features of the various subclasses, which are now driven by ...
4993 (ExceptionStatement.EmitPreTryBody): ... this and ...
4994 (ExceptionStatement.EmitTryBody): ... this and the original
4996 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4997 Remove DoEmit and update to follow above protocol.
4999 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5000 of the dispatcher are the same, skip emitting the 'switch'.
5001 * iterator.cs (Iterator.EmitDispose): Update to changes.
5003 Clean up handling of 'using' statement
5004 * statement.cs (UsingTemporary): New. Carved out of ...
5005 (Using): ... this. Simplify drastically. Handle exactly
5007 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5008 or Using as appropriate. If there are multiple variable declared,
5009 create nested Using statements.
5010 (resource_acquisition): Kill.
5012 * statement.cs (ExceptionStatement.EmitForDispose): Use
5013 EmitFinallyBody, not EmitFinally.
5015 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5016 * iterator.cs: Update to changes.
5018 Start using the ResumableStatement infrastructure
5019 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5020 (ResumableStatement.EmitForDispose): New.
5021 (ExceptionStatement): Override them.
5022 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5023 EmitForDispose to create the body of the Dispose method. Don't
5026 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5027 * statement.cs (Toplevel.AddResumePoint): ... here.
5028 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5029 * flowanalysis.cs (FlowBranchingIterator): New.
5030 * codegen.cs (EmitContext): Update to changes.
5032 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5033 (Iterator.old_resume_points): Rename from 'resume_points'.
5034 (Iterator.MoveNextStatement): Remove unused class.
5036 New infrastructure for try/finally in iterators (still unused)
5037 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5038 (FlowBranchingToplevel.AddResumePoint): Hook into
5039 ToplevelBlock.AddResumePoint.
5040 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5041 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5042 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5043 resume points and assign program-counter values.
5044 (ExceptionBlock.AddResumePoint): Collect resume points for
5045 de-muxer at the top of try block.
5046 * iterators.cs (Yield.CheckContext): Simplify.
5047 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5049 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5051 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5052 argument to an ExitStatement.
5053 (FlowBranchingException): Refactor saved origins code.
5054 * statement.cs (ExitStatement): Update to cahges.
5055 * iterator.cs (YieldBreak): Likewise.
5057 * statement.cs (ResumableStatement): New. Common base class for
5058 YieldReturn and ExceptionStatement.
5059 (ExitStatement): New. Common base class for Return and YieldBreak.
5060 (Return): Update to changes.
5061 * iterator.cs (YieldBreak): Likewise.
5062 * lambda.cs (ContextualReturn): Likewise.
5065 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5066 emit a meaningful error message.
5068 Fix #324765, #319508
5069 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5070 (VariableInfo.SetAssigned): Set it.
5071 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5072 determine if CS0219 or CS0168 is appropriate. Don't use
5073 flow-analysis information.
5074 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5075 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5076 (EmitContext.EndFlowBranching): ... this.
5078 2008-04-03 Marek Safar <marek.safar@gmail.com>
5080 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5082 2008-04-03 Marek Safar <marek.safar@gmail.com>
5084 A fix for bug #376508
5085 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5086 ImplicitConversionExists.
5088 2008-04-03 Marek Safar <marek.safar@gmail.com>
5090 * expression.cs (Binary): Added remaining binary operators to expression
5093 * nullable.cs: Optimize shift with null argument.
5095 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5097 Fix minor IL regression
5098 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5099 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5100 * cs-parser.jay (try_statement): Update to changes.
5102 * statement.cs (TryFinally.need_exc_block): Delete.
5103 (TryFinally): Update to changes.
5105 Now all ExceptionStatements are unconditional
5106 * statement.cs (CollectionForeach.DisposableWrapper): New.
5107 Extract out the try/finally code into a new wrapper.
5108 (CollectionForeach.Resolve): Use it to simplify the code.
5110 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5112 Start at simplifying ExceptionStatement semantics a bit
5113 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5114 * cs-parser.jay (try_statement): Update to changes.
5115 (opt_catch_clauses): Remove.
5116 * flowanalysis.cs: Update to changes.
5117 (FlowBranching.BranchingType.TryCatch): New.
5118 (FlowBranchingTryCatch): New.
5120 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5121 (FlowBranching.CreateBranching): Update to changes.
5122 (FlowBranchingBlock.AddSibling): Add sanity check.
5123 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5126 * iterators.cs (Iterator.MarkFinally): Remove.
5127 * statement.cs (ExceptionStatement): Update to changes.
5129 Add support for skipping over finally blocks at runtime. First
5130 in a series to fix #324708
5131 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5132 (Iterator.EmitMoveNext): Initialize it.
5133 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5134 branch over the body of the 'finally' clause.
5136 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5138 Avoid lopsided use of Foo/DoFoo names
5139 * statement.cs (ExpressionStatement.EmitFinallyBody):
5140 Rename from EmitFinally.
5141 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5142 * iterator.cs: Update to changes.
5144 2008-04-02 Marek Safar <marek.safar@gmail.com>
5146 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5147 based on UserOperatorCall. More binary nullable operators clean up.
5149 2008-04-02 Martin Baulig <martin@ximian.com>
5151 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5153 2008-04-02 Marek Safar <marek.safar@gmail.com>
5155 * nullable.cs: Merge user and empty conversions when lifting expression
5158 * expression.cs (StringConcat): Implemented expression tree representation.
5160 2008-04-01 Marek Safar <marek.safar@gmail.com>
5162 * nullable.cs: When lifting null literal and a user operator exists, no call
5165 2008-04-01 Marek Safar <marek.safar@gmail.com>
5167 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5170 2008-04-01 Marek Safar <marek.safar@gmail.com>
5172 * nullable.cs, expression.cs: Use namespace instead heavily nested
5173 monster abstract class.
5175 2008-04-01 Marek Safar <marek.safar@gmail.com>
5177 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5178 lifting of null literal and user operators. Clean up of some temporary
5181 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5183 Fix #368224, test-629.cs
5184 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5185 if it crossed an unwind-protect boundary.
5186 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5187 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5188 inside an unwind-protected region.
5189 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5190 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5191 'leave' instead of a 'br' if unwind-protected.
5192 (Iterator.EmitYieldBreak): Likewise.
5194 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5196 * driver.cs: Only define versioninfo resources if no win32 resource
5199 2008-03-28 Marek Safar <marek.safar@gmail.com>
5201 A fix for bug #372375
5202 * convert.cs: Fixed boxing of nullable types.
5204 2008-03-28 Marek Safar <marek.safar@gmail.com>
5206 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5209 2008-03-28 Marek Safar <marek.safar@gmail.com>
5211 A fix for bug #374619
5212 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5214 2008-03-27 Marek Safar <marek.safar@gmail.com>
5216 * lambda.cs: Check return type only for invocation.
5218 2008-03-27 Marek Safar <marek.safar@gmail.com>
5220 A fix for bug #374214
5221 * ecore.cs: Correctly report argument type mismatch.
5223 2008-03-27 Marek Safar <marek.safar@gmail.com>
5225 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5226 and not rely on broken IsEnum.
5228 2008-03-27 Marek Safar <marek.safar@gmail.com>
5230 * nullable.cs: New file, extracted from generic.cs.
5232 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5234 2008-03-27 Marek Safar <marek.safar@gmail.com>
5236 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5237 predefined comparison operators and null literals.
5239 * report.cs: New warning ID.
5241 2008-03-25 Marek Safar <marek.safar@gmail.com>
5243 A fix for bug #370577
5244 * lambda.cs: Check return type too.
5246 2008-03-25 Marek Safar <marek.safar@gmail.com>
5248 A fix for bug #372846
5249 * class.cs: Automatic properties can be declared as unsafe.
5251 2008-03-20 Marek Safar <marek.safar@gmail.com>
5253 * location.cs: Use string based concatenation.
5255 * expression.cs: LiftedBinaryOperator is gmcs only.
5257 2008-03-20 Marek Safar <marek.safar@gmail.com>
5259 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5260 conversions rules and expression trees.
5262 2008-03-19 Marek Safar <marek.safar@gmail.com>
5264 * delegate.cs: Use extension method source as delegate target.
5266 2008-03-19 Marek Safar <marek.safar@gmail.com>
5268 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5269 binary operations to be purely based on binary operations and optimized
5270 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5271 and other ET refactoring.
5273 * typemanager.cs: Fixed warning.
5275 2008-03-17 Marek Safar <marek.safar@gmail.com>
5277 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5279 * symbolwriter.cs: Fixed.
5281 2008-03-17 Marek Safar <marek.safar@gmail.com>
5283 * anonymous.cs, driver.cs: Reset anonymous types counters.
5285 2008-03-17 Marek Safar <marek.safar@gmail.com>
5287 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5289 * class.cs: Use fullname for all type member definitions.
5291 2008-02-19 Martin Baulig <martin@ximian.com>
5294 (IMethodData.EmitExtraSymbolInfo): New interface method.
5295 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5296 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5297 interface method here as an empty public virtual method.
5300 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5301 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5302 CodeGen.SymbolWriter.SetRealMethodName().
5304 2008-02-18 Martin Baulig <martin@ximian.com>
5307 (ScopeInfo.EmitType): Override this and emit debugging
5308 information for captured variables.
5309 (RootScopeInfo.EmitType): Override this and emit symbol
5310 information for a captured `this'.
5312 2008-02-15 Martin Baulig <martin@ximian.com>
5314 * iterators.cs: Emit debugging info.
5317 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5318 (EmitContext.OmitDebuggingInfo): New public property.
5321 (While): Override Emit() and don't emit symbol info there; do it
5322 inside DoEmit() instead.
5323 (Block.Emit): Omit symbol information while emitting the scope
5324 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5326 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5327 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5328 .ctor to make `IsIterator' work.
5330 2008-03-14 Martin Baulig <martin@ximian.com>
5332 * symbolwriter.cs: Added the new symbol writer function from the
5333 debugger's `terrania' branch; temporarily enclose them inside
5334 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5337 2008-03-14 Martin Baulig <martin@ximian.com>
5340 (SymbolWriter): Make this a public static class.
5343 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5344 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5346 2008-03-14 Marek Safar <marek.safar@gmail.com>
5348 A fix for bug #370577
5349 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5352 2008-03-14 Marek Safar <marek.safar@gmail.com>
5354 * typemanager.cs (CSharpName): Made 250 times faster.
5356 2008-03-13 Marek Safar <marek.safar@gmail.com>
5358 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5360 2008-03-12 Marek Safar <marek.safar@gmail.com>
5362 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5363 crash when predefined field does not exist.
5365 2008-03-12 Marek Safar <marek.safar@gmail.com>
5367 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5369 2008-03-12 Marek Safar <marek.safar@gmail.com>
5371 * class.cs (FixedField): Don't crash when contructors are missing.
5373 2008-03-11 Marek Safar <marek.safar@gmail.com>
5375 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5376 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5377 check internal types accessibility for internal and external types.
5378 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5380 2008-03-11 Marek Safar <marek.safar@gmail.com>
5382 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5383 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5384 attribute.cs, statement: Use corect instance of predefined types (work
5385 related to #364674).
5387 2008-03-07 Marek Safar <marek.safar@gmail.com>
5389 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5391 2008-03-07 Marek Safar <marek.safar@gmail.com>
5393 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5394 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5395 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5396 predefined types clean up, delayed predefined types members initialization
5397 (work related to #364674).
5399 2008-03-05 Marek Safar <marek.safar@gmail.com>
5401 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5403 2008-03-05 Marek Safar <marek.safar@gmail.com>
5405 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5406 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5407 predefined types clean up (work related to #364674).
5409 2008-03-04 Marek Safar <marek.safar@gmail.com>
5411 * ecore.cs: Print an error message instead of throwing exception.
5413 2008-03-04 Marek Safar <marek.safar@gmail.com>
5415 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5416 expression.cs, statement.cs: Unififed null literal representation.
5418 2008-03-03 Marek Safar <marek.safar@gmail.com>
5420 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5421 expression.cs: Refactored binary operators resolve phase and improved speed.
5422 The nullable code is still missing and won't work correctly, more fixes
5425 It also fixes #323726, #324312, #324248, and many other unreported issues.
5427 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5429 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5432 2008-02-27 Marek Safar <marek.safar@gmail.com>
5434 * ecore.cs: Clean-up and split BetterConversion.
5436 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5439 * enum.cs (EnumMember.Value): Only access 'value' if
5440 ResolveValue says it's ok.
5441 (EnumMember.DoResolveValue): Don't set prev_member.value.
5442 (Enum.GetDefinition): Reverse arguments of Equals --
5443 EnumMember.Value can return 'null'.
5445 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5447 2008-02-22 Marek Safar <marek.safar@gmail.com>
5449 * generic.cs, expression.cs: More ongoing work on expression trees.
5451 2008-02-21 Marek Safar <marek.safar@gmail.com>
5453 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5454 handle missing matches when mutiple operators exist.
5456 2008-02-20 Marek Safar <marek.safar@gmail.com>
5458 A fix for bug #363218
5459 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5462 2008-02-20 Marek Safar <marek.safar@gmail.com>
5464 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5465 update. This time to deal correctly with SideEffectConstant expression used
5466 as an argument for another constant folding.
5468 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5470 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5473 2008-02-19 Marek Safar <marek.safar@gmail.com>
5475 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5477 2008-02-19 Marek Safar <marek.safar@gmail.com>
5479 A fix for bug #328136
5480 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5481 side is a false constant, because we still need to evaluate the right-hand
5484 * statement.cs (If): Emit two types of boolean constants (simple constant,
5485 side-effect constant).
5487 2008-02-19 Marek Safar <marek.safar@gmail.com>
5489 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5491 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5494 2008-02-18 Marek Safar <marek.safar@gmail.com>
5496 A fix for bug #361457
5497 * ecore.cs (IsApplicable): Params methods have lower priority.
5499 * support.cs: Return correct parameter modifier for params types.
5501 2008-02-18 Marek Safar <marek.safar@gmail.com>
5503 * generic.cs (TypeParameter): Cache attribute target name.
5505 * support.cs: Removed unused variable.
5507 * typemanager.cs: Removed debugging leftover.
5509 * ecore.cs: Use local type instead of a property;
5511 * class.cs (VerifyMembers): Consider also parent to test whether type member
5514 * expression.cs (FullMethodDesc): Removed.
5516 * attribute.cs (IsValidArgumentType): Made static.
5518 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5520 Cleanup to be more readable.
5521 * Makefile (GMCS_PROFILE): Remove.
5522 (COMPILER_NAME): New helper.
5524 2008-02-15 Miguel de Icaza <miguel@novell.com>
5526 * cs-tokenizer.cs: if a conditional expression happens inside a
5527 (...) this also means that we do not need to de-ambiguate between
5528 an parenthesized expression and a cast.
5532 * constant.cs (SideEffectConstant): a constant value that happens
5533 to have a side effect.
5535 Fixes the build regressions introduced by the fix for #359789
5537 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5539 * expression.cs (Conditional.Emit): when emitting the ternary
5540 operator, use local variables to generate code verifiable code.
5542 The verifier cannot infer that the type on stack before the
5543 stloc.0 is executed is of type ParentB. This happens because the
5544 stack merge algorithm uses only parent types when deciding which
5545 is the common type. This is described in Part III 1.8.1.3 of ECMA
5548 This code compiled with mcs is not verifiable under MS. The MS
5549 verifier picks the first common interface of Foo and Bar, which is
5550 wrong, but doesn't use a full join type of the 2 interfaces.
5552 CSC uses a clever hack to compile such code in a verifiable
5553 way. It stores the intermediate values in a local variable with
5558 2008-02-14 Miguel de Icaza <miguel@novell.com>
5560 * expression.cs: Do not fold BitwiseAnd operators when the left
5561 side is a false constant, because we still need to evaluate the
5566 * support.cs: Instead of throwing an InternalErrorException when
5567 the position of the stream is outside the boundary of our buffer,
5568 reset the state of the reader, and restart the reading from the
5569 beginning of the file.
5571 2008-02-14 Marek Safar <marek.safar@gmail.com>
5573 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5575 2008-02-14 Marek Safar <marek.safar@gmail.com>
5577 A fix for bug #361686
5578 * decl.cs: A protected types used inside a private class which parents
5579 derives from the protected class are accessible.
5581 2008-02-13 Marek Safar <marek.safar@gmail.com>
5583 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5584 the parameterless constructor.
5586 2008-02-13 Marek Safar <marek.safar@gmail.com>
5588 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5589 lookup methods to use standard member cache when doing member lookup.
5591 2008-02-12 Marek Safar <marek.safar@gmail.com>
5593 * driver.cs: Don't report full path for referenced module as assembly error.
5595 2008-02-12 Marek Safar <marek.safar@gmail.com>
5597 * Makefile: Fixed `qh' target to work on all machines.
5599 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5600 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5601 and HasElementType with TypeManager implementation.
5603 2008-02-08 Marek Safar <marek.safar@gmail.com>
5605 A fix for bugs #325134, #359749
5606 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5607 first binds point to non-method member expression.
5609 2008-02-08 Marek Safar <marek.safar@gmail.com>
5611 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5613 2008-02-08 Marek Safar <marek.safar@gmail.com>
5615 A fix for bugs #321394, #323028
5616 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5617 Reworked naive IsAccessibleAs implementation to handle nested types.
5619 2008-02-05 Jb Evain <jbevain@novell.com>
5621 * class.cs: use generic type comparison for parameters
5624 2008-02-05 Marek Safar <marek.safar@gmail.com>
5626 A fix for bug #325372
5627 * class.cs: Use generic type comparison when testing method signatures.
5629 2008-02-05 Marek Safar <marek.safar@gmail.com>
5631 A fix for bug #357047
5632 * ecore.cs: Applied C# 3.0 changes to better conversion.
5634 2008-02-05 Marek Safar <marek.safar@gmail.com>
5636 A fix for bug #358374
5637 * cs-parser.jay: Correctly set modifiers for all constructor types.
5639 2008-02-04 Marek Safar <marek.safar@gmail.com>
5641 A fix for bug #355251
5642 * generic.cs: Added base class constraint based type inference.
5644 2008-02-01 Marek Safar <marek.safar@gmail.com>
5646 A fix for bug #357255
5647 * decl.cs: One more missing visibility check.
5649 2008-02-01 Marek Safar <marek.safar@gmail.com>
5651 * support.cs: Fixed broken return.
5653 2008-01-25 Marek Safar <marek.safar@gmail.com>
5655 * report.cs: Correctly reset warnings count after probing.
5657 2008-01-25 Martin Baulig <martin@ximian.com>
5660 (NamespaceEntry.SymbolFileID): Make this work again after
5661 MemberName.ToString() is gone.
5663 2008-01-25 Marek Safar <marek.safar@gmail.com>
5665 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5668 2008-01-25 Marek Safar <marek.safar@gmail.com>
5670 * generic.cs: Use full implicit conversion for type inference fixing.
5672 2008-01-24 Marek Safar <marek.safar@gmail.com>
5674 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5675 Fixed user operator conversions.
5677 2008-01-24 Marek Safar <marek.safar@gmail.com>
5679 * generic.cs: Do nullable type to null comparison optimization during
5682 2008-01-24 Marek Safar <marek.safar@gmail.com>
5684 A fix for bug #355163
5685 * generic.cs: Enabled l-value resolve on nullable expressions.
5687 2008-01-24 Marek Safar <marek.safar@gmail.com>
5689 A fix for bug #353986
5690 * class.cs: Ingore static ctors with parameters for any further checks.
5692 2008-01-24 Marek Safar <marek.safar@gmail.com>
5694 A fix for bug #354310
5695 * namespace.cs: Removed redundant check.
5697 2008-01-24 Marek Safar <marek.safar@gmail.com>
5699 A fix for bug #354928
5700 * expression.cs: ElementInitializers can be resolved only once.
5702 2008-01-24 Marek Safar <marek.safar@gmail.com>
5704 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5705 Condition expressions.
5707 2008-01-23 Marek Safar <marek.safar@gmail.com>
5709 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5711 2008-01-22 Marek Safar <marek.safar@gmail.com>
5713 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5716 * generic.cs: Implemented coalesce expression.
5718 2008-01-22 Marek Safar <marek.safar@gmail.com>
5720 A fix for bug #355145
5721 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5722 expression tree type inference.
5724 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5727 * expression.cs (Binary.IsUnsignedType): Fix typo.
5729 2008-01-22 Marek Safar <marek.safar@gmail.com>
5731 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5733 2008-01-22 Marek Safar <marek.safar@gmail.com>
5735 A fix for bug #355161
5736 * ecore.cs, expression.cs: Wider range of extension method supported
5739 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5741 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5742 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5745 2008-01-22 Marek Safar <marek.safar@gmail.com>
5747 A fix for bug #355148
5748 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5750 2008-01-22 Miguel de Icaza <miguel@novell.com>
5752 * expression.cs (CreateExpressionTree): Add support for or and
5753 logical or, and indent following the coding conventions.
5755 * typemanager.cs (LinqExpression): renamed from
5756 ExpressionTreeManager, for a shorter name.
5758 Use TypeManager.CoreLookupType to lookup types from our core
5759 assemblies and turn those into "Type" variables.
5761 Consumers that previously used "Namespace" and "Type" from this
5762 class should instead use the TypeExpression which is a type that
5763 is fully resolved (without involving the regular C# resolution
5766 This typically looks like this:
5768 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5769 new MemberAccess (texpr, name, type_arguments, loc)
5771 This avoids the problem in: #355178
5773 2008-01-21 Marek Safar <marek.safar@gmail.com>
5775 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5776 feature in parser only as we do in other cases.
5778 2008-01-21 Marek Safar <marek.safar@gmail.com>
5780 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5781 typemanager.cs: A refactoring of params arguments to reuse existing
5782 expressions (params -> array initializer) to emit params argument instead
5783 of specialized handling.
5784 It was required by expression tree implementation and it has other benefits
5785 as well, we now apply same optimization for params arguments as we do for
5788 2008-01-18 Marek Safar <marek.safar@gmail.com>
5790 A fix for bug #353526
5791 * generic.cs: A type inference of params arguments may not required any
5792 temporary array creation.
5794 2008-01-18 Marek Safar <marek.safar@gmail.com>
5796 A fix for bug #353534
5797 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5798 supported for delegates only.
5800 2008-01-18 Marek Safar <marek.safar@gmail.com>
5802 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5803 type for more than 1 candidates.
5805 2008-01-18 Marek Safar <marek.safar@gmail.com>
5807 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5810 2008-01-16 Marek Safar <marek.safar@gmail.com>
5812 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5813 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5814 operator) expressions.
5816 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5818 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5819 not accessed from the generated IL.
5821 2008-01-14 Marek Safar <marek.safar@gmail.com>
5823 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5824 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5825 statement.cs: The first expression tree implementation drop, mostly
5826 infrastructure work.
5828 2008-01-14 Marek Safar <marek.safar@gmail.com>
5830 * ecore.cs (IsNestedChild): Refactored.
5832 2008-01-11 Marek Safar <marek.safar@gmail.com>
5834 * lambda.cs: Don't use a cast on unknown expression statement.
5836 2008-01-10 Geoff Norton <gnorton@novell.com>
5838 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5841 2008-01-09 Marek Safar <marek.safar@gmail.com>
5843 * doc.cs: Report better /doc crash details.
5845 2008-01-09 Marek Safar <marek.safar@gmail.com>
5847 A fix for bug #352536
5848 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5850 2008-01-08 Marek Safar <marek.safar@gmail.com>
5852 A fix for bug #352287
5853 * ecore.cs, expression.cs: Do `this' access checking in all member access
5856 2008-01-08 Marek Safar <marek.safar@gmail.com>
5858 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5860 * report.cs: Reset message stacks.
5862 2008-01-08 Marek Safar <marek.safar@gmail.com>
5864 * generic.cs (InferInPhases): Correctly calculate params position.
5866 2008-01-08 Marek Safar <marek.safar@gmail.com>
5868 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5871 2008-01-07 Marek Safar <marek.safar@gmail.com>
5873 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5875 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5877 * driver.cs: Updated --help option.
5879 2008-01-07 Marek Safar <marek.safar@gmail.com>
5881 * generic.cs (InferParamsTypeArguments): Removed.
5882 (InferInPhases): Add params type inference.
5883 (LowerBoundInference): Fixed scoring mechanism.
5885 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5887 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5889 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5890 byte array for unsigned "baked" assemblies.
5892 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5894 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5895 array for assemblies that are not strongnamed.
5897 2008-01-04 Marek Safar <marek.safar@gmail.com>
5899 A fix for bug #351481
5900 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5901 declaring type for nested generic types.
5903 2008-01-04 Marek Safar <marek.safar@gmail.com>
5905 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5906 instead of ToString.
5908 2008-01-03 Marek Safar <marek.safar@gmail.com>
5910 A fix for bug #351047
5911 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5912 null and structs only when equality and inequality operators are defined
5913 either as an user-operators or predefined operators.
5915 2008-01-03 Marek Safar <marek.safar@gmail.com>
5917 A fix for bug #351047
5918 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5920 2008-01-03 Marek Safar <marek.safar@gmail.com>
5922 A fix for bug #351257
5923 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5925 2008-01-03 Marek Safar <marek.safar@gmail.com>
5927 A fix for bug #351157
5928 * class.cs (Using): Fixed yet another broken cloning.
5930 (Block): Put back more sensible default value for statements.
5932 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5934 * codegen.cs: Allow AssemblyVersion with only major version component.
5937 2007-12-29 Marek Safar <marek.safar@gmail.com>
5939 A fix for bug #324654
5940 * class.cs: Use FullName property as member name.
5942 2007-12-28 Marek Safar <marek.safar@gmail.com>
5944 A fix for bug #342117
5945 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5946 constructor constraint.
5948 2007-12-28 Marek Safar <marek.safar@gmail.com>
5950 A fix for bug #338273
5951 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5954 2007-12-28 Marek Safar <marek.safar@gmail.com>
5956 A fix for bug #350839
5957 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5959 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5961 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5964 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5966 * statement.cs: Changed some Hashtables to use HybridDictionaries
5967 instead. It was observed that some HashTables only contained a few
5968 items in the vast majority of cases. Since HybridDictionary is
5969 more efficient on small sets (<10 elements), "known_variables"
5970 from class ExplicitBlock as well as "labels" and "constants " from
5971 class Block were changed to HybridDictionaries.
5973 Atsai results: (56216kb->54987kb)
5975 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5978 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5980 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5983 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5985 * expression.cs: foreach loop to for loop, saved on allocation of
5986 enumerator (59333kb->59141kb)
5988 * statement.cs. Changed foreach loops to for loops, saved on
5989 allocation of enumerator (59141kb->59006kb)
5991 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5992 when constructed with no specified capacity. This was causing a
5993 few ArrayLists to allocate more memory than they would potentially
5994 need in the Block class and MemberCache class. Setting the
5995 ArrayLists to construct with a capacity of 1 saves some
5996 memory. (56216kb->55585kb)
5998 2007-12-27 Marek Safar <marek.safar@gmail.com>
6000 A fix for bug #347189 (2nd issue)
6001 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6004 2007-12-27 Miguel de Icaza <miguel@novell.com>
6006 * report.cs: Do not use colors if stdout and stderr are not a
6009 2007-12-27 Marek Safar <marek.safar@gmail.com>
6011 A fix for bug #346998
6012 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6015 2007-12-27 Marek Safar <marek.safar@gmail.com>
6017 A fix for bug #343465
6018 * class.cs: Explicit method name for nested types uses dots only.
6020 2007-12-27 Marek Safar <marek.safar@gmail.com>
6022 A fix for bug #343707
6023 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6025 2007-12-27 Marek Safar <marek.safar@gmail.com>
6027 * ecore.cs: Report type inference errors only when arguments count matches
6030 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6032 * expression.cs, report.cs: New warning.
6034 * typemanager.cs: Catch anonymous method type too.
6036 2007-12-23 Marek Safar <marek.safar@gmail.com>
6038 A fix for bug #346379
6039 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6041 2007-12-23 Marek Safar <marek.safar@gmail.com>
6043 A fix for bug #347359
6044 * expression.cs (Invocation): Don't resolve already resolved expression.
6046 2007-12-23 Marek Safar <marek.safar@gmail.com>
6048 A fix for bug #347189
6049 * class.cs (FixedField): Use non-dependent code only in the define phase.
6051 2007-12-23 Marek Safar <marek.safar@gmail.com>
6053 A fix for bug #348076
6054 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6056 2007-12-22 Marek Safar <marek.safar@gmail.com>
6058 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6059 discovered extension methods.
6061 2007-12-22 Marek Safar <marek.safar@gmail.com>
6063 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6066 2007-12-21 Miguel de Icaza <miguel@novell.com>
6068 * report.cs (ErrorMessage): Add support for using colors on
6069 terminals that support it.
6071 2007-12-21 Marek Safar <marek.safar@gmail.com>
6073 * ecore.cs: Use information about expanded params for error reporting.
6075 2007-12-21 Marek Safar <marek.safar@gmail.com>
6077 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6078 and logic for params overloads.
6080 2007-12-15 Miguel de Icaza <miguel@novell.com>
6082 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6083 as this is also created from the parser. Fixes #349034
6085 2007-12-12 Miguel de Icaza <miguel@novell.com>
6087 * statement.cs (Throw.CloneTo): it is valid to have empty
6088 expressions for throw.
6090 2007-12-03 Marek Safar <marek.safar@gmail.com>
6092 * cs-parser.jay: Set delegate constraint parsing region correctly.
6094 2007-12-03 Marek Safar <marek.safar@gmail.com>
6096 A fix for bug #345467
6097 * typemanager.cs (IsEqual): Compare generic parameters position only.
6099 2007-11-28 Marek Safar <marek.safar@gmail.com>
6101 * expression.cs (BaseAccess): Type arguments can be null.
6103 2007-11-27 Raja R Harinath <harinath@gmail.com>
6105 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6106 consistent even when an error has occured.
6107 (Switch.Resolve): Likewise.
6109 2007-11-22 Marek Safar <marek.safar@gmail.com>
6111 A fix for bug #334505
6112 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6115 2007-11-22 Marek Safar <marek.safar@gmail.com>
6117 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6118 refactorings required to resolve extension methods correctly when mixing
6119 generics and non-generics members.
6121 2007-11-20 Marek Safar <marek.safar@gmail.com>
6123 A fix for bug #342584
6124 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6127 2007-11-19 Marek Safar <marek.safar@gmail.com>
6129 A fix for bug #342512
6130 * delegate.cs: Use delegate argument expression when is available. Don't
6131 emit virtual call when class is sealed.
6133 2007-11-16 Marek Safar <marek.safar@gmail.com>
6135 A fix for bug #325423
6136 * assign.cs (FieldInitializer): Use resolved expression for emit.
6138 * class.cs: Print less confusing error message.
6140 2007-11-16 Marek Safar <marek.safar@gmail.com>
6142 * cs-tokenizer.cs: Removed GMCS ifdefs.
6144 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6147 * cs-parser.jay: Disabled nullable check.
6149 * generic-mcs: Copied more generic stuff.
6151 2007-11-16 Marek Safar <marek.safar@gmail.com>
6153 * gcs-parser.jay: Merged to cs-parser.jay.
6155 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6156 * *.csproj, *.sources: Updated to use only jay parser file.
6158 2007-11-16 Marek Safar <marek.safar@gmail.com>
6160 * gcs-parser.jay: Added nullable and default expression feature checks.
6162 2007-11-16 Marek Safar <marek.safar@gmail.com>
6164 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6165 it fixes many TODOs and hidden bugs.
6167 * expression: Removed duplicate error check.
6169 2007-11-15 Marek Safar <marek.safar@gmail.com>
6171 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6172 implicitly type local variable only when it is used in a declaration.
6174 2007-11-15 Marek Safar <marek.safar@gmail.com>
6176 * attribute.cs: Use CS0612 for empty strings.
6178 2007-11-14 Marek Safar <marek.safar@gmail.com>
6180 * lambda.cs, statement.cs: Contextual return may act as a statement.
6182 2007-11-14 Marek Safar <marek.safar@gmail.com>
6184 A fix for a regression cause by #324222
6185 * class.cs: Don't report unused even when it implements an interface.
6187 2007-11-13 Marek Safar <marek.safar@gmail.com>
6189 A fix for bug #341205
6190 * ecore.cs, expression.cs: Method group expression cannot do static
6191 method access with an instance reference check before overloading takes
6194 2007-11-13 Marek Safar <marek.safar@gmail.com>
6196 A fix for bug #325359
6197 * class.cs: Use predictable name for automatically generated property.
6199 2007-11-12 Marek Safar <marek.safar@gmail.com>
6201 A fix for bug #324996
6202 * expression.cs (Is): Handle case where D is nullable and T is not
6205 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6207 2007-11-12 Marek Safar <marek.safar@gmail.com>
6209 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6210 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6211 Flush small error reporting changes.
6213 2007-11-09 Marek Safar <marek.safar@gmail.com>
6215 A fix for bug #324996
6216 * expression.cs: Rewrote Is expression implementation to work with
6217 generics, nullable types, anonymous method. A const result expression
6218 uses existing infrastructure instead of custom not fully-featured one.
6220 2007-11-08 Marek Safar <marek.safar@gmail.com>
6222 A fix for bug #340202
6223 * class.cs: Consider generics for volatile field.
6225 2007-11-08 Marek Safar <marek.safar@gmail.com>
6227 A fix for bug #335594
6228 * expression.cs: Use conversion rules when handling string addition.
6230 2007-11-07 Marek Safar <marek.safar@gmail.com>
6232 A fix for bug #336651
6233 * expression.cs: Fixed a crash when probing is on.
6235 2007-11-07 Marek Safar <marek.safar@gmail.com>
6237 A fix for bug #324242
6238 * covert.cs: Added a conversion from any nullable-type with an
6239 underlying enum-type to the type System.Enum.
6241 2007-11-07 Marek Safar <marek.safar@gmail.com>
6243 A fix for bug #324222
6244 * class.cs: Report all non-used event fields.
6246 2007-11-07 Marek Safar <marek.safar@gmail.com>
6248 A fix for bug #325161
6249 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6250 qualifier for generic types.
6252 2007-11-07 Marek Safar <marek.safar@gmail.com>
6254 A fix for bug #322971
6255 * expression.cs, ecore.cs: Added intermediate result value check for
6258 2007-11-07 Marek Safar <marek.safar@gmail.com>
6260 A fix for bug #324754
6261 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6262 when it was requested.
6264 2007-11-07 Marek Safar <marek.safar@gmail.com>
6266 A fix for bug #325101
6267 * expression.cs: Do type not value comparison for `is' expression.
6269 2007-11-07 Marek Safar <marek.safar@gmail.com>
6271 A fix for bug #320236
6272 * convert.cs: Don't apply user conversion on underlying target type.
6274 2007-11-06 Marek Safar <marek.safar@gmail.com>
6276 * expression.cs: Don't use unresolved expression for error reporting.
6278 2007-11-06 Marek Safar <marek.safar@gmail.com>
6280 A fix for bugs #337712, #324490
6281 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6282 overloading resolution too.
6284 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6285 the process consistent and more robust.
6287 * expression.cs, linq.cs, report.cs: Update.
6289 2007-11-02 Marek Safar <marek.safar@gmail.com>
6291 A fix for bug #332909
6292 * attribute.cs: Resolve attributes in correct context using error
6295 * rootcontext.cs: Define Obsolete attribute members as core members.
6297 2007-11-02 Marek Safar <marek.safar@gmail.com>
6299 * statement.cs: Removed unused methods.
6301 2007-10-31 Wade Berrier <wberrier@novell.com>
6303 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6304 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6307 2007-10-31 Marek Safar <marek.safar@gmail.com>
6309 A fix for bug #338102
6310 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6311 methods registered as non-generics.
6313 2007-10-31 Marek Safar <marek.safar@gmail.com>
6315 A fix for bugs #337712, #324490
6316 * delegate.cs: Delegate covariance and contravariance is not allowed for
6319 2007-10-31 Marek Safar <marek.safar@gmail.com>
6321 A fix for bug #337719
6322 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6325 2007-10-30 Marek Safar <marek.safar@gmail.com>
6327 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6329 2007-10-29 Marek Safar <marek.safar@gmail.com>
6331 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6334 2007-10-29 Raja R Harinath <rharinath@novell.com>
6336 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6338 2007-10-29 Marek Safar <marek.safar@gmail.com>
6340 A fix for bug #334652
6341 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6342 extension methods when we have not found the best candidate in normal
6345 2007-10-27 Marek Safar <marek.safar@gmail.com>
6347 * AssemblyInfo.cs: Keep up-to-date.
6349 2007-10-27 Marek Safar <marek.safar@gmail.com>
6351 * Makefile: Fixed generics compiler name.
6353 2007-10-27 Marek Safar <marek.safar@gmail.com>
6355 * lambda.test: removed, lambda parsing is done differently.
6357 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6359 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6361 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6363 2007-10-27 Marek Safar <marek.safar@gmail.com>
6365 * Makefile, *.sources : All C# compilers are in mcs folder.
6367 * *.cs: Use existing 2_1 define for smcs.
6369 2007-10-26 Marek Safar <marek.safar@gmail.com>
6371 A fix for bug #335847
6372 * assign.cs, expression.cs: Couple of changes to avoid creating a
6373 temporary variable for each object initializer assignment statement. It
6374 simplifies struct initialization too, otherwise two temporary variables
6376 Implemented optimization of redundant default element initializers.
6378 2007-10-25 Marek Safar <marek.safar@gmail.com>
6380 A fix for bug #336766
6381 * expression.cs (Class.CheckBase): Use generic name when method is
6384 2007-10-25 Marek Safar <marek.safar@gmail.com>
6386 A fix for bug #334737
6387 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6388 variable and not variable argument for prepared copies.
6390 2007-10-24 Marek Safar <marek.safar@gmail.com>
6392 A fix for bug #325110
6393 * class.cs, expression.cs, attribute.cs: Use open generic method when
6394 checking conditional attribute.
6396 2007-10-24 Marek Safar <marek.safar@gmail.com>
6398 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6399 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6400 FeatureIsNotAvailable.
6402 2007-10-24 Marek Safar <marek.safar@gmail.com>
6404 ** C# 3.0 Partial methods
6406 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6407 methods support. Because of member cache issue with generics only
6408 non-generics partial methods are fully supported.
6410 2007-10-23 Marek Safar <marek.safar@gmail.com>
6412 * class.cs, decl.cs: Rewrote member overloads check to cope with
6413 generics and to use member cache for member checking. It also improves
6414 performance and fixes remaining overloads issues.
6416 2007-10-20 Marek Safar <marek.safar@gmail.com>
6418 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6419 roottypes.cs, typemanager.cs:
6421 A member cache creation logic changed to add members immediately and
6422 not rely on fallback. The member cache is now only prefered way
6423 how to access and find type declaration members. It saves 5 MB of memory
6424 during MWF compilation and makes code ready for more optimizations and
6425 clean-ups, it's also a pre-requirement for partial methods.
6427 2007-10-18 Raja R Harinath <harinath@gmail.com>
6429 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6430 handling for generic parameters.
6432 2007-10-15 Marek Safar <marek.safar@gmail.com>
6434 * class.cs (FixedField): Removed redundant volatile check.
6436 2007-10-15 Marek Safar <marek.safar@gmail.com>
6438 * class.cs, decl.cs: Fixed overload members verification to do only one
6439 check per possible collision.
6441 2007-10-13 Marek Safar <marek.safar@gmail.com>
6443 A fix for bug #325478
6444 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6445 and create only one disposable flags container.
6447 2007-10-12 Marek Safar <marek.safar@gmail.com>
6449 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6450 * statement.cs (Fixed): Fixed variables cloning.
6452 2007-10-12 Marek Safar <marek.safar@gmail.com>
6454 A fix for bug #333342
6455 * class.cs (EventField): Don't mark value type event as synchronized.
6457 2007-10-12 Marek Safar <marek.safar@gmail.com>
6459 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6460 inference to identify best candidate method correctly.
6461 (ProperyExpr): A range variable is read only and cannot be modified.
6463 2007-10-11 Marek Safar <marek.safar@gmail.com>
6465 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6466 logic to identify best candidate method correctly.
6468 2007-10-11 Marek Safar <marek.safar@gmail.com>
6470 * location.cs (Equals, GetHashCode): Removed.
6472 2007-10-11 Marek Safar <marek.safar@gmail.com>
6474 * report.cs: Implemented message recorder. It is used mainly for lambda
6475 expressions to capture otherwise swallowed error messages.
6477 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6479 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6481 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6483 * expression.cs (MemberAccess): Always report lookup failure.
6485 * location.cs: Implemented Equals, GetHashCode.
6487 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6489 2007-10-10 Jb Evain <jbevain@novell.com>
6491 * codegen.cs: re-enable assembly version check.
6493 2007-10-09 Marek Safar <marek.safar@gmail.com>
6495 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6498 * namespace.cs (UsingAlias): Do correct version check.
6500 2007-10-08 Marek Safar <marek.safar@gmail.com>
6502 * expresison.cs, ecore.cs: Issue extension method error message when
6505 * rootcontext.cs: Added ISO_2 compiler mode option.
6507 2007-10-08 Marek Safar <marek.safar@gmail.com>
6509 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6512 2007-10-08 Marek Safar <marek.safar@gmail.com>
6514 * attribute.cs (GetString, GetBoolean): Work with both literal and
6517 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6518 Moved method overload specific methods to MethodGroupExpr.
6520 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6521 it should be less memory consuming.
6523 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6525 * codegen.cs: remove the assembly version check until the buildbot is
6528 2007-10-07 Jb Evain <jbevain@novell.com>
6530 * attribute.cs (Attribute.GetString): if the value
6531 expression is a StringConstant, return its string value.
6533 2007-10-07 Jb Evain <jbevain@novell.com>
6535 * typemanager.cs: add `assembly_version_attribute_type`.
6536 * codegen.cs: on attribute emission, check that the
6537 AssemblyVersionAttribute doesn't overflow.
6539 2007-10-05 Marek Safar <marek.safar@gmail.com>
6541 A fix for bug #324677
6542 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6543 parent container of a scope container with currently resolved one.
6545 2007-10-05 Marek Safar <marek.safar@gmail.com>
6547 A fix for bug #325534
6548 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6551 2007-10-05 Marek Safar <marek.safar@gmail.com>
6553 A fix for bug #327504
6554 * class.cs (Operator.Define): Refactored implicit and explicit user
6555 operator conversion rules.
6557 2007-10-05 Marek Safar <marek.safar@gmail.com>
6559 A fix for bug #327520
6560 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6562 2007-10-04 Marek Safar <marek.safar@gmail.com>
6564 A fix for bug #328022
6565 * class.cs (MethodData.Define): Use correct method to check whether
6566 a method implementents an accessor.
6568 2007-10-04 Marek Safar <marek.safar@gmail.com>
6570 A fix for bug #330069
6571 * statement.cs (Fixed.Resolve): Read the first array element only when
6572 an array is instantiated.
6574 2007-10-04 Marek Safar <marek.safar@gmail.com>
6576 * expression.cs, assign.cs, generics.cs: Print correct operator when
6577 compound assignment is used.
6579 2007-10-04 Marek Safar <marek.safar@gmail.com>
6581 A fix for bug #325841
6582 * expression.cs (ArrayAccess): Use full argument cloning only for
6583 string compound concatenation.
6585 2007-10-03 Marek Safar <marek.safar@gmail.com>
6587 A fix for bug #328774
6588 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6590 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6593 2007-10-03 Raja R Harinath <rharinath@novell.com>
6596 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6597 Event accessibility checks here. Remove some bogus code that
6598 accidently made GenericMethods work.
6599 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6601 2007-09-25 Marek Safar <marek.safar@gmail.com>
6603 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6605 * statement.cs (Block): Refactored AddVariable to allow error handling
6608 * generic.cs: New stub.
6610 2007-09-23 Marek Safar <marek.safar@gmail.com>
6612 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6615 2007-09-17 Marek Safar <marek.safar@gmail.com>
6617 * class.cs: Use partial container to record whether any partial part
6618 contains static field initializer and therefore default contructor has
6621 2007-09-14 Marek Safar <marek.safar@gmail.com>
6623 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6624 mono-list when only one of two partial parts has defined accessibility
6627 2007-09-14 Marek Safar <marek.safar@gmail.com>
6629 A fix for bug #82845
6631 * class.cs (TypeContainer): Set correct resolve context for all field
6634 2007-09-13 Marek Safar <marek.safar@gmail.com>
6636 * assign.cs: Fixed a crash when field is resolved twice with an error.
6638 * codegen.cs: Changed InFieldInitializer to be flag.
6640 * anonymous.cs, ecore.cs, expression.cs: Update after
6641 IsInFieldInitializer rename.
6643 * const.cs: Removed unused parameter.
6645 * class.cs: Changed the way how we resolve and emit field initializers.
6646 The field initilizers have to have access to contructor block to emit
6647 compiler generated code.
6649 2007-09-13 Marek Safar <marek.safar@gmail.com>
6651 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6652 generics use TypeContainer instead.
6654 2007-09-12 Marek Safar <marek.safar@gmail.com>
6656 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6658 * lambda.cs (ResolveParameters): Use more powerful
6659 InflateGenericArgument.
6661 * parameters.cs: Better exception message.
6663 2007-09-10 Marek Safar <marek.safar@gmail.com>
6665 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6666 correct expression block type.
6668 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6670 * expression.cs (Invocation): Extracted method group resolve to
6673 2007-09-07 Marek Safar <marek.safar@gmail.com>
6675 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6676 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6678 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6679 generic extension methods.
6681 2007-09-06 Marek Safar <marek.safar@gmail.com>
6683 A fix for bug #82676 (Do I get it right now?)
6684 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6685 object before a standard conversion is applied.
6687 2007-09-06 Marek Safar <marek.safar@gmail.com>
6689 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6692 2007-09-05 Marek Safar <marek.safar@gmail.com>
6694 A fix for bug #82676
6695 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6696 non-generic interface types.
6698 2007-09-05 Marek Safar <marek.safar@gmail.com>
6700 A fix for bug #82690
6701 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6703 2007-09-05 Marek Safar <marek.safar@gmail.com>
6705 A fix for bug #82571
6706 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6707 modifier for container based methods.
6709 2007-09-05 Marek Safar <marek.safar@gmail.com>
6711 A fix for bug #82676
6712 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6713 any interface-type T means to any of interface type T.
6715 2007-09-04 Marek Safar <marek.safar@gmail.com>
6717 * namespace.cs: We have 2 versions of System.Core assembly.
6719 2007-09-04 Marek Safar <marek.safar@gmail.com>
6721 A fix for bug #82652
6722 * class.cs (Class.GetClassBases): Compare types and not expressions.
6724 2007-09-04 Marek Safar <marek.safar@gmail.com>
6726 A fix for bug #82620
6727 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6728 actually never worked before.
6729 (IndexerAccess): Emit prepared arguments before they are modified.
6731 2007-09-04 Marek Safar <marek.safar@gmail.com>
6733 A fix for bug #82563
6734 * assign.cs: Revert wrong fix.
6736 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6738 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6739 Instead of ldelema/stdind we have to use temporary variables to handle
6740 cases like String.Concat (params string[]).
6742 2007-08-31 Marek Safar <marek.safar@gmail.com>
6744 * class.cs: EmitAttributes to Emit rename.
6746 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6748 (MemberCore.HasClsCompliantAttribute): Don't depend on
6749 GetClsCompliantAttributeValue execution.
6751 2007-08-31 Marek Safar <marek.safar@gmail.com>
6753 * anonymous.cs: Use shorter type prefix.
6755 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6758 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6759 variables when probing is on.
6761 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6762 unresolved variables.
6763 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6764 handle transparent identifiers.
6766 2007-08-26 Marek Safar <marek.safar@gmail.com>
6768 * attribute.cs (IsClsCompliant): Add nullable types test.
6770 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6772 * doc.cs : catch other types of exception than XmlException to
6773 report CS1570. Fixed bug #82565.
6775 2007-08-23 Marek Safar <marek.safar@gmail.com>
6777 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6778 The number of delegate parameters has to match.
6779 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6782 2007-08-21 Marek Safar <marek.safar@gmail.com>
6784 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6785 to fix problem with private arguments.
6787 2007-08-20 Marek Safar <marek.safar@gmail.com>
6789 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6791 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6793 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6794 empty. Add cloning suport.
6796 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6798 2007-08-20 Marek Safar <marek.safar@gmail.com>
6800 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6801 to create EmptyCast. It handles EmptyConstantCast specialization for
6804 2007-08-18 Marek Safar <marek.safar@gmail.com>
6806 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6807 (EmitArrayArgument): One routine for array arguments.
6808 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6810 2007-08-17 Marek Safar <marek.safar@gmail.com>
6812 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6814 2007-08-17 Marek Safar <marek.safar@gmail.com>
6816 * anonymous.cs: MemberLookupFinal update.
6818 * class.cs (ConstructorInitializer): Is expression based.
6820 * delegate.cs: MethodGroupExpr update.
6822 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6824 (Error_MemberLookupFailed): Customizable error override.
6825 (MethodGroupExpr): Keep queried type for later usage.
6826 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6829 * expression.cs: Error_MemberLookupFailed refactoring.
6830 (New.DoResolve): Resolve as much as possible.
6831 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6832 customization for invalid member types.
6834 * statement.cs: MethodGroupExpr update.
6836 2007-08-16 Marek Safar <marek.safar@gmail.com>
6838 * modifier.cs (Check): Check all modifiers and not only accessibility
6841 2007-08-16 Marek Safar <marek.safar@gmail.com>
6843 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6844 type and not an expression.
6846 2007-08-16 Marek Safar <marek.safar@gmail.com>
6848 * statement.cs (Catch.Clone): Type and variable can be null.
6850 2007-08-16 Marek Safar <marek.safar@gmail.com>
6852 A fix for bug #81979
6853 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6854 I am really not sure whether this is the best fix.
6856 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6859 2007-08-14 Marek Safar <marek.safar@gmail.com>
6861 ** C# 3.0 Object and collection initializers (major re-write)
6863 * assign.cs (DoResolve): Initializers are not assign related.
6865 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6866 used during collection or object initialization.
6868 * expression.cs (Error_InvalidArguments): Add initializers specific
6869 messages. More will come later because it requires some general
6871 (New.DoResolve): Better error handling for unsafe types.
6872 (EmptyExpressionStatement): New class.
6873 (ElementInitializer): An object initializer expression.
6874 (CollectionElementInitializer): A collection initializer expression.
6875 (CollectionOrObjectInitializers): A block of object or collection
6877 (NewInitialize): New expression with element/object initializers.
6879 * statement.cs: Reverted object/collection initializer hacks.
6881 * typemanager.cs (CSharpName): Filter __arglist type.
6883 2007-08-09 Marek Safar <marek.safar@gmail.com>
6885 ** C# 3.0 Anonymous Types (update to the latest standard)
6887 * expression.cs (Binary.ResolveOperator): Threat all null based types
6889 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6890 (AnonymousTypeParameter): Updated.
6892 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6893 (AnonymousTypeClass): New anonymous type container.
6895 * class.cs (AddField): Return operation result.
6897 * generic.cs: Another empty TypeArguments overload.
6899 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6900 are stored at top of normal hierarchy.
6902 * typemanager.cs (CSharpName): Filter anonymous types.
6904 2007-08-09 Marek Safar <marek.safar@gmail.com>
6906 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6907 as single Concat call. How could we miss that :-(
6909 2007-08-08 Marek Safar <marek.safar@gmail.com>
6911 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6913 2007-08-07 Miguel de Icaza <miguel@novell.com>
6915 * expression.cs: Fix the previous commit, the creation of the
6916 arguments array list needs also to be conditional on the arguments
6919 * class.cs: Add a little bit of help to help narrow down problems.
6921 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6922 not try to copy in that case.
6924 * driver.cs: When building SMCS, include a new different set of
6925 default assemblies here. Do this here so we can control whether
6926 to include the default assemblies with /noconfig.
6928 2007-08-03 Marek Safar <marek.safar@gmail.com>
6930 A fix for bug #81979
6931 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6934 2007-08-03 Marek Safar <marek.safar@gmail.com>
6936 A fix for bug #82300
6938 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6939 we are in probing scope.
6941 2007-08-03 Marek Safar <marek.safar@gmail.com>
6943 A fix for bug #82301
6945 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6946 (Statement.CloneTo): Clone and not map children blocks.
6948 2007-08-03 Marek Safar <marek.safar@gmail.com>
6950 A fix for bug #82299
6952 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6955 * statement.cs (Statement.CloneTo): Clone variables before statements
6956 to allow remaping of local variables.
6958 2007-08-03 Marek Safar <marek.safar@gmail.com>
6960 A fix for bug #82296
6963 * report.cs: Log crash details for future clone problems.
6965 * statement.cs (Return.Clone): Don't clone non-existent expression.
6967 2007-08-03 Raja R Harinath <harinath@gmail.com>
6969 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6970 (Class.AddBasesForPart): Move CS0537 check here from ...
6971 * cs-parser.jay (class_declaration): ... here. Move calling of
6972 'AddBasesForPart' to ...
6973 (class_bases): ... here.
6974 (struct_declaration, interface_declaration): Update to changes.
6976 2007-08-02 Marek Safar <marek.safar@gmail.com>
6978 A fix for bug #81923
6980 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6981 conversion is allowed.
6983 2007-08-02 Marek Safar <marek.safar@gmail.com>
6985 A fix for bug #81564
6987 * ecore.cs (EventExpr): Add IsBase handling.
6989 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6992 2007-08-02 Raja R Harinath <harinath@gmail.com>
6994 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6995 * cs-parser.jay: Some whitespace cleanups.
6996 (current_delegate): New.
6998 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6999 a dummy code block, and use 'type_name' instead of 'member_name'.
7000 (interface_declaration, class_declaration): Likewise.
7001 (delegate_declaration): Likewise. Rearrange slightly and use
7003 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7004 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7006 2007-08-02 Marek Safar <marek.safar@gmail.com>
7008 A fix for bug #82039
7010 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7013 * typemanager.cs (CSharpName): Split to string overload.
7015 2007-08-02 Marek Safar <marek.safar@gmail.com>
7018 * report.cs: Updated warning CS0472.
7020 2007-08-01 Marek Safar <marek.safar@gmail.com>
7022 A fix for bug #82181
7024 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7026 2007-08-01 Marek Safar <marek.safar@gmail.com>
7028 A fix for bug #82277
7029 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7031 2007-08-01 Marek Safar <marek.safar@gmail.com>
7033 ** C# 3.0 Type Inference (major bits are working)
7035 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7036 (.ImplicitStandardConversionExists): Uses compatible.
7037 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7038 (.InferReturnType): New method.
7039 (.Compatible): Refactored.
7040 (.ResolveParameters): Uses factory to create resolved parameters.
7041 (.CompatibleMethod): Add probing mode support.
7042 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7043 clearly distinguish between 2 different operations.
7044 (LambdaMethod): Moved to lambda.cs.
7045 (AnonymousMethod): Removed unused fields and methods.
7046 (AnonymousDelegate): Simplified.
7048 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7050 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7052 * delegate.cs (Delegate): New mehods to reduce code duplication.
7053 (.GetConstructor): New method.
7054 (.GetInvokeMethod): New method.
7055 (DelegateCreation): Updated.
7057 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7059 (OverloadResolve): Made probing little bit faster.
7061 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7064 * generic.cs (TypeInferenceContext): Dummy implementation.
7066 * iterators.cs: Updated after Resolve/Define rename.
7068 * lambda.cs (LambdaExpression)
7069 (.ResolveParameters): Handles both type of arguments and type inference too.
7071 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7072 (InflateTypes): Updated.
7074 * support.cs (InflateTypes): Changed signature and updated.
7076 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7077 (MemberLookup_FindMembers): More MS tricks.
7078 (GetParameterData): Ditto.
7079 (GetDelegateParameters): Uses quick path for dynamic types.
7081 2007-08-01 Marek Safar <marek.safar@gmail.com>
7083 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7086 2007-07-31 Marek Safar <marek.safar@gmail.com>
7088 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7091 2007-07-26 Jb Evain <jbevain@novell.com>
7093 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7094 which takes a boolean 'report_errors', similar to the GetMethod.
7095 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7096 in .net 2.1, do not report errors here.
7098 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7099 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7100 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7103 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7104 of the type InternalsVisibleToAttribute before the first call
7105 to CoreLookupType which is allowed to fail (third boolean parameter
7106 to true). Because, during the resolution for a type that is not
7107 immediately found, we try to check if the type is not defined in
7108 a friend assembly, and to do so, we need the
7109 InternalVisibleToAttribute.
7111 2007-07-23 Miguel de Icaza <miguel@novell.com>
7113 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7114 feature that allows structs to be compared against null and inline
7115 the result as true or false.
7117 Notice that the same code is not permitted inside a generic block
7118 of code that would do:
7120 class Foo<T> where T : struct {
7127 It is only allowed if the type of T is not bound (no where
7128 clause). In my opinion, this CSC 2 behavior is broken but people
7129 seem to be using it (IronRuby does, a few bug reports on bugzilla
7130 have it and some people have complained about it).
7132 All of the users that depend on this behavior have code that is
7135 * report.cs (Warning, Error): make these take object arguments,
7136 not strings, as that allows us to take advantage of Format.
7138 2007-07-20 William Holmes <billholmes54@gmail.com>
7140 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7141 Left member variable for the Count.
7142 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7143 MemberName.CountTypeArguments to avoid a NRE.
7145 This code is contributed under the MIT X11 license
7147 2007-07-18 Marek Safar <marek.safar@gmail.com>
7149 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7151 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7153 * doc.cs : generic method arguments are written as ``x while generic
7154 type arguments are `x. Combined with the previous change, fixed bug
7157 2007-07-18 Raja R Harinath <rharinath@novell.com>
7160 * expression.cs (Binary.ResolveOperator): When converting
7161 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7163 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7165 * doc.cs : when T: or whatever x: is specified, it does not really
7166 check the doc comment's syntax correctness. Fixed bug #82006.
7168 2007-07-18 Marek Safar <marek.safar@gmail.com>
7170 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7171 LambdaExpression better.
7173 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7175 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7177 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7178 as it can be generated.
7180 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7183 * lambda.cs (LambdaExpression): Refactored to share same code with
7184 AnonymousMethodExpression.
7186 2007-07-17 Marek Safar <marek.safar@gmail.com>
7188 * anonymous.cs (MakeName): Include host name for easier debugging.
7189 (LambdaMethod): New class for lambda spcecific stuff.
7191 * attribute.cs: Set EmitContext return type.
7193 * class.cs: Set EmitContext return type.
7195 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7196 with null/void meaning.
7198 * iterators.cs (ContainerType): Implemented.
7200 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7202 * statement.cs (Return): Updated to lambda expressions.
7203 (Block.CloneTo): Parent can be null.
7205 2007-07-13 Marek Safar <marek.safar@gmail.com>
7207 A fix for bug #81917
7208 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7210 * class.cs (FixedField): Check whether field is in unsafe scope.
7212 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7213 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7215 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7218 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7220 2007-07-13 Marek Safar <marek.safar@gmail.com>
7222 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7223 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7226 2007-07-13 Marek Safar <marek.safar@gmail.com>
7228 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7230 2007-07-13 Marek Safar <marek.safar@gmail.com>
7232 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7233 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7235 * codegen.cs(EmitContext): Add ProbingMode flag.
7237 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7239 * driver.cs: For now set both warning values.
7241 * ecore.cs (SimpleName): Name is readonly.
7242 (MethodGroup.OverloadResolve): One quick path for probing.
7244 * expression.cs (Unary): Set Oper r/o.
7245 (Binary): Set Oper r/o.
7246 (ParameterReference): Set few instance variables as r/o.
7247 (ParameterReference.DoResolveBase): Don't capture aruments when
7249 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7250 (Arglist): arguments are private.
7251 (SizeOf): type is private and r/o.
7252 (MemberAccess): arguments are private.
7254 * report.cs: Enhanced reporting on/off capabilities.
7256 * lambda.cs: Uses ec.IsInProbingMode.
7257 (ContextualReturn): Derives from return.
7259 * rootcontext.cs: For now set both warning values.
7261 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7263 (Return.Resolve): Don't die immediately.
7264 (Block.Resolve): Speed-up probing.
7265 (Block.CloneTo): Clone only child blocks.
7267 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7269 * iterators.cs: reverted Miguel's latest change (r81925) as it
7270 breaks the build in System.
7272 2007-07-13 Miguel de Icaza <miguel@novell.com>
7274 * iterators.cs (Yield.CheckContext): Check for the iterator type
7275 also here as we can call into Yield even in codepaths that are not
7277 (MethodOrOperator is the only path that was checked).
7279 In addition to the standard check, use a more specific check for
7280 constructors to report a more verbose error.
7282 2007-07-12 Miguel de Icaza <miguel@novell.com>
7284 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7285 report the warning and continue
7287 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7288 values on the stack on the call to Emit. Use EmitStatement if
7289 possible, or using Emit + Pop if not possible. Fixes #82064
7291 2007-07-12 Raja R Harinath <rharinath@novell.com>
7293 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7294 avoid try...finally in some cases.
7296 2007-07-10 Marek Safar <marek.safar@gmail.com>
7298 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7300 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7301 instead of method. Re-use standard error handling.
7302 (ConstructorInitializer.Emit): Simplified.
7304 * delegate.cs: Updated after Invocation.EmitCall change.
7306 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7307 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7308 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7309 method and don't permanently changing input arguments.
7310 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7311 is resolved it has one of the candidates is the best one which is later
7312 used to emit. Removed a few unused method.
7313 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7315 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7316 (Binary.ResolveOperator): Ditto.
7317 (ConditionalLogicalOperator.DoResolve): Ditto.
7318 (Invocation): Uses method group.
7319 (Invocation.DoResolve): Simplified.
7320 (Invocation.EmitCall): Removed useless is_static.
7321 (Invocation.Emit): Delegate to method group.
7322 (Invocation.EmitStatement): Simplified.
7323 (New): Uses method group.
7324 (MemberAccess.DoResolve): Don't destroy original expression.
7326 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7328 2007-07-04 Marek Safar <marek.safar@gmail.com>
7330 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7333 * lambda.cs: Add custom error message type.
7335 2007-07-03 Marek Safar <marek.safar@gmail.com>
7337 * lambda.cs: Simplified little bit.
7339 * parameter.cs: Introduced ImplicitLambdaParameter.
7340 (Parameters.CreateFullyResolved): New factory instead of ctor.
7344 * delegate.cs: Updated parameter creation.
7346 2007-07-03 Marek Safar <marek.safar@gmail.com>
7348 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7351 * generic.cs: Synchronized with gmcs.
7353 2007-07-03 Marek Safar <marek.safar@gmail.com>
7355 * class.cs (Indexer): Check return type as soon as possible.
7357 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7360 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7362 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7364 * parameter.cs (Parameter): Use expression type when it is available.
7366 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7367 method modifier for the first parameter only.
7369 2007-06-24 Marek Safar <marek.safar@gmail.com>
7371 A fix for bug #81938
7372 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7374 * constant.cs: Tide up an exception message.
7376 2007-06-22 Marek Safar <marek.safar@gmail.com>
7378 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7379 an uninitialized variable is used.
7381 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7383 2007-06-22 Marek Safar <marek.safar@gmail.com>
7385 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7386 not found error handling.
7388 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7390 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7391 (ArrayCreation.DoResolve): Simplified.
7392 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7393 its own resolve process.
7394 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7396 2007-06-20 Marek Safar <marek.safar@gmail.com>
7398 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7401 2007-06-20 Marek Safar <marek.safar@gmail.com>
7403 * cs-tokenizer.cs: Removed var related stuff.
7405 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7406 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7407 a type and a keyword at same time.
7409 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7412 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7413 implicitly typed arrays, more changes will follow.
7415 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7417 2007-06-19 Marek Safar <marek.safar@gmail.com>
7419 * ecore.cs (VarExpr): Removed Handled field.
7421 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7422 build-in assign functionality.
7423 (ForEach.Resolve): Removed all implicitly typed local variable code and
7425 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7426 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7428 2007-06-18 Marek Safar <marek.safar@gmail.com>
7430 * assign.cs: Removed implicitly typed local variable check.
7432 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7433 referencing implicitly typed local variable.
7434 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7437 * statement.cs (Fixed): Removed unsupported implicitly typed local
7440 2007-06-15 Marek Safar <marek.safar@gmail.com>
7442 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7444 2007-06-14 Marek Safar <marek.safar@gmail.com>
7446 A fix for bugs #81855 and #76274
7447 * attribute.cs (AttachTo): Always set owner for global attributes to
7450 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7453 * cs-parser.jay: Assembly and module attributes must precede all other
7454 elements except using clauses and extern alias declarations.
7456 2007-06-13 Marek Safar <marek.safar@gmail.com>
7458 A fix for bug #81748
7460 * expression.cs: More checks for non ISO-1 features.
7462 2007-06-12 Marek Safar <marek.safar@gmail.com>
7464 A fix for bug #81807
7465 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7466 present inside switch statement and it is required by nullable check.
7468 2007-06-12 Marek Safar <marek.safar@gmail.com>
7470 A fix for bug #81840
7471 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7472 when type matching fails.
7474 * namespace.cs: Tiny error message change.
7476 2007-06-12 Marek Safar <marek.safar@gmail.com>
7478 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7479 reporting. Added automatic property check.
7481 * class.cs: Updated after CheckAbstractAndExtern relocation.
7482 (AEventPropertyAccessor.GetSignatureForError): Customized.
7484 2007-06-11 Marek Safar <marek.safar@gmail.com>
7486 * class.cs (DefineBaseTypes): Base type can be undefined.
7488 * ecore.cs (TypeLookup): Minor refactoring.
7489 (DoResolveAsTypeStep): Removed redundant check.
7491 * namespace.cs (Lookup): Removed redundant check.
7493 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7494 ResolveAsTypeTerminal step.
7495 (BootstrapCorlib_*): Simplified.
7496 (PopulateCoreType): Core types can be now external.
7498 2007-06-07 Marek Safar <marek.safar@gmail.com>
7500 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7502 (InferTypeArguments): Infers anonymous expression type arguments.
7503 (Compatible): Split to Compatible and InferTypeArguments.
7505 * lambda.cs: Updated.
7507 2007-06-08 Marek Safar <marek.safar@gmail.com>
7509 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7511 2007-06-07 Raja R Harinath <harinath@gmail.com>
7513 Fix #80477, cs0135-2.cs, cs0135-3.cs
7514 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7515 names to the "known" variables list.
7516 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7517 parameter names are also "known".
7518 (Block.CheckError136): Remove.
7519 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7522 2007-06-07 Marek Safar <marek.safar@gmail.com>
7524 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7526 2007-06-06 Marek Safar <marek.safar@gmail.com>
7528 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7529 internal error not an user error.
7531 * expression.cs (IsApplicable): Refactored to make debugging easier.
7533 * support.cs: More tricks for non-mono runtimes.
7535 * typemanager.cs (CoreLookupType): Made public.
7536 (InitSystemCore): All linq specific stuff moved to linq.cs
7538 2007-06-05 Marek Safar <marek.safar@gmail.com>
7540 * typemanager.cs (CSharpSignature): One more missing build-in types
7542 More tricks for non-mono runtime.
7544 2007-06-05 Raja R Harinath <harinath@gmail.com>
7546 * statement.cs (Block.CheckError136_InParents): Remove.
7547 (Block.AddVariable): Use GetParameterInfo instead.
7548 (ToplevelBlock.ProcessArguments): Likewise.
7550 2007-06-04 Raja R Harinath <rharinath@novell.com>
7552 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7554 (ToplevelBlock.GetParameterInfo): Split out of ...
7555 (ToplevelBlock.GetParameterRefernce): ... this.
7556 (ToplevelBlock.ParameterMap): Remove.
7557 * expression.cs (ParameterReference): Update to use
7558 ToplevelParameterInfo.
7560 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7563 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7564 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7566 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7567 (ToplevelBlock.ProcessParameters) ... here.
7568 (ToplevelBlock..ctor): Invoke it.
7570 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7573 * statement.cs (IKnownVariable): New interface.
7574 (LocalInfo): Implement it.
7575 (ToplevelParameterInfo): New class.
7576 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7577 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7578 GetKnownVariableInfo.
7580 2007-06-03 Raja R Harinath <harinath@gmail.com>
7582 Partly speed up CS0136 error checks.
7583 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7584 'recurse' parameter.
7585 (Block.DoCheckError136): Only check errors in parameters. Move
7586 local variable checks ...
7587 (Block.AddVariable): ... here, and ...
7588 (ToplevelBlock.ResolveMeta): ... here.
7590 2007-06-02 Raja R Harinath <harinath@gmail.com>
7592 * statement.cs (Block.IsChildOf): Remove.
7594 * statement.cs (Statement.Clone): Move special case code ...
7595 (Block.CloneTo): ... here.
7597 2007-05-29 Raja R Harinath <rharinath@novell.com>
7599 * statement.cs (ToplevelBlock.container): Remove field. It's
7600 redundant with 'Parent'.
7601 (ToplevelBlock.ContainerBlock): Remove accessor.
7602 (ToplevelBlock..ctor): Update to changes. Register anonymous
7603 child with parent here, ...
7604 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7606 (start_anonymous): Don't save current_block.
7607 (top_current_block): Remove.
7609 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7610 (Block.Resolve): Update to changes.
7611 (Block..ctor): Move setting of "correct" 'Toplevel'
7612 and 'Explicit' fields to ...
7613 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7615 2007-05-27 Raja R Harinath <harinath@gmail.com>
7618 * statement.cs (Block.Implicit): Remove.
7619 (Block): Update to changes.
7620 * flowanalysis.cs: Likewise.
7622 Mildly speed up CheckInvariantMeaningInBlock
7623 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7624 Recursively call AddKnownVariable to all enclosing blocks.
7625 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7626 Remove recursive calls.
7627 (Block): Update to changes.
7629 New ExplicitBlock invariants
7630 * statement.cs (Block.Explicit): New field. It points to the
7631 immediately enclosing non-implicit block.
7632 (Block..ctor): Maintain the invariant.
7633 * cs-parser.jay: Take advantage of invariant.
7635 Introduce ExplicitBlock
7636 * statement.cs (ExplicitBlock): New.
7637 (ToplevelBlock): Derive from it.
7638 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7640 (Block.Implicit): Update to changes.
7641 * cs-parser.jay: Update to changes.
7644 * codegen.cs (EmitContext.IsLastStatement): Remove.
7645 * statement.cs (Block.DoEmit): Update to changes.
7647 2007-05-25 Raja R Harinath <rharinath@novell.com>
7649 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7650 modifying current_block directly.
7652 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7654 * class.cs: Implemented automatic properties (C# 3.0)
7655 Thanks to Marek for the help.
7657 2007-05-23 Raja R Harinath <rharinath@novell.com>
7659 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7660 variable as assigned, note also that all its components are
7662 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7664 2007-05-19 Marek Safar <marek.safar@gmail.com>
7666 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7667 member is marked as compiler generated.
7669 * decl.cs (MemberCore): Refactored ModFlags into property.
7671 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7672 (Check): Check only accessibility modifiers.
7674 2007-05-18 Raja R Harinath <rharinath@novell.com>
7676 Track all assignable slots in one bit array
7677 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7678 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7679 logic from VariableMap constructor here. Use the same 'offset'
7680 variable that's later used for computing offsets of local
7682 * flowanalysis.cs (UsageVector.parameters): Remove.
7683 (UsageVector): Update to changes.
7684 (VariableMap): Remove.
7686 Avoid creating ParameterMap in every block
7687 * statement.cs (Block.ParameterMap): Move ...
7688 (ToplevelBlock.ParameterMap): ... here.
7689 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7691 * flowanalysis.cs (FlowBranching.param_map): Remove.
7692 (FlowBranching.UsageVector): Update to changes.
7693 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7695 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7697 * expression.cs (ParameterReference): Distinguish between block
7698 where parameter was referenced and declared.
7700 2007-05-18 Marek Safar <marek.safar@gmail.com>
7702 * flowanalysis.cs, statement.cs: Put back improved error handling.
7704 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7708 Imporved object and collection initialization (C# 3.0).
7710 2007-05-15 Marek Safar <marek.safar@gmail.com>
7712 A fix for bug #81380
7713 * expression.cs (Is.DoResolve): Only value types have constant `is'
7716 2007-05-15 Raja R Harinath <rharinath@novell.com>
7718 * statement.cs (ToplevelBlock.child): Remove.
7720 2007-05-15 Raja R Harinath <harinath@gmail.com>
7722 Rationalize ResolveMeta: refactoring
7723 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7724 out constant handling code into ...
7725 (Block.DoResolveConstants): ... this.
7727 Rationalize ResolveMeta: kill local_map
7728 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7729 (Block.AssignableSlots): New.
7730 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7731 for locals -- move code from VariableMap here. Avoid unnecessary
7733 * flowanalysis.cs (FlowBranching.local_map): Remove.
7734 (FlowBranching..ctor): Use Block.AssignableSlots.
7735 (VariableMap): Remove unused constructors.
7737 2007-05-11 Raja R Harinath <rharinath@novell.com>
7739 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7741 2007-05-11 Marek Safar <marek.safar@gmail.com>
7743 * typemanager.cs (IsFriendAssembly): Should not be called for building
7746 2007-05-09 Marek Safar <marek.safar@gmail.com>
7748 * literal.cs (NullConstant): Print null in all cases.
7750 * expression.cs (Binary.ResolveOperator): Implemented delegate
7751 comparison based on C# 2.0 changes.
7753 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7755 This code is contributed under the MIT X11 license
7757 The following enables support for several C# 3.0 language features:
7759 * cs-tokenizer.cs: Added support for the "var" keyword.
7761 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7762 Added VarExpr class to facilitate type inferencing.
7764 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7765 to support anonymous types.
7767 * assign.cs: Added support for type inferencing and initialization.
7769 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7771 * expression.cs: Added implicit array support to ArrayCreation.
7772 Added 5 types and 1 interface:
7774 IInitializable Implementing classes can inject initializing
7775 statements after object instantiation.
7777 Initializer Stores data for object initialization.
7779 AnonymousType An expression for anonymous types.
7781 AnonymousTypeParameter Stores data about an anonymous type's field.
7783 NewInitialize An expression for object initialization.
7785 CollectionInitialize An expression for collection initialization.
7787 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7790 2007-05-06 Marek Safar <marek.safar@gmail.com>
7792 A fix for bug #81500
7793 * cs-tokenizer.cs: Add special handling for coalescing operator.
7795 2007-05-06 Marek Safar <marek.safar@gmail.com>
7797 A fix for bug #81529
7798 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7799 its value from base class until it is redefined.
7801 2007-05-02 Raja R Harinath <rharinath@novell.com>
7803 Fix regression in cs0631-3.cs
7804 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7805 fallback. Make error fallback catch more cases.
7807 2007-05-01 Miguel de Icaza <miguel@novell.com>
7809 * cs-parser.jay: Allow parameters in operator declarations to have
7812 2007-04-27 Miguel de Icaza <miguel@novell.com>
7814 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7817 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7818 inside the ContextualReturn, it does not have to be an
7819 ExpressionStatement.
7821 2007-04-24 Miguel de Icaza <miguel@novell.com>
7823 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7826 2007-04-23 Miguel de Icaza <miguel@novell.com>
7828 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7829 method in two methods: ResolveNoDefine and Resolve.
7831 ResolveNoDefine will stop just after ResolveTopBlock has been
7834 Resolve will then continue by creating a method and issuing the
7835 call to method.Define ().
7837 (AnonymousMethod): Split and implement the new Resolve and
7838 ResolveNoDefine as well.
7840 * lambda.cs (LambdaExpression): Split the anonymous method
7841 resolution code into a separate routine (CoreCompatibilityTest)
7842 from DoCompatibleTest.
7844 (LambdaExpression.TryBuild): New method, this method tries to
7845 build the LambdaExpression with the given set of types to be used
7846 as the types for the various parameters of the lambda expression.
7848 If the compilation succeed with the given types, the infered type
7849 of the Anonymous method is returned, otherwise null is returned.
7851 2007-04-23 Marek Safar <marek.safar@gmail.com>
7853 A fix for bug #81414
7854 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7856 2007-04-22 Miguel de Icaza <miguel@novell.com>
7858 * cs-tokenizer.cs: Change various identifiers here from the
7859 camelCasing to the recommended Linux-like style for instance
7860 variables from the Coding Guidelines.
7862 2007-04-19 Martin Baulig <martin@ximian.com>
7865 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7866 System.Enum to System.ValueType.
7868 2007-04-13 Martin Baulig <martin@ximian.com>
7870 Rewrote implicit reference conversions. We need to distinguish
7871 between implicit reference conversions (13.1.4) and implicit
7872 boxing conversions (13.1.5).
7874 According to the spec, there's an an implicit conversion
7875 "From a one-dimensional array-type S[] to IList<T> and base
7876 interfaces of this interface, provided there is an implicit
7877 reference conversion from S to T." Note that this does not
7878 include boxing conversions.
7881 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7882 (Convert.ImplicitReferenceConversion): Split into
7883 ImplicitReferenceConversionCore() and
7884 ImplicitBoxingConversionExist().
7885 (Convert.ImplicitReferenceConversionExists): Use the new
7886 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7888 2007-04-12 Martin Baulig <martin@ximian.com>
7890 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7891 `TypeManager.null_type' checks up to the top of the method.
7893 2007-04-11 Marek Safar <marek.safar@gmail.com>
7895 A fix for bug #81350
7896 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7899 2007-04-11 Martin Baulig <martin@ximian.com>
7901 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7902 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7903 to make this work for generic classes; fixes #79561.
7905 2007-04-11 Martin Baulig <martin@ximian.com>
7907 * expression.cs (As): Add support for nullable types; fixes #79371.
7909 2007-04-11 Martin Baulig <martin@ximian.com>
7911 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7912 `type.FullName' is null; fixes #80243.
7914 2007-04-11 Martin Baulig <martin@ximian.com>
7916 * expression.cs (Invocation.IsApplicable): Don't modify the method
7917 if type inference succeeded, but the method was not applicable.
7920 2007-04-10 Marek Safar <marek.safar@gmail.com>
7922 A fix for bug #81324
7923 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7924 internal and external namespaces containers.
7926 2007-04-10 Martin Baulig <martin@ximian.com>
7928 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7929 TypeManager.DropGenericMethodArguments() so we also call
7930 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7932 2007-04-10 Martin Baulig <martin@ximian.com>
7934 * iterators.cs (Iterator.CreateIterator): Don't crash if
7935 `method.ReturnType' is null. This happens if something went wrong
7936 while resolving that typ (we already reported an error in this case).
7938 2007-04-10 Martin Baulig <martin@ximian.com>
7940 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7941 generic interfaces; report the CS0144 directly.
7943 2007-04-10 Martin Baulig <martin@ximian.com>
7945 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7946 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7948 2007-04-10 Martin Baulig <martin@ximian.com>
7950 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7952 2007-04-09 Raja R Harinath <rharinath@novell.com>
7955 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7956 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7959 * statement.cs (For.Resolve): If resolution fails, use
7962 2007-04-08 Marek Safar <marek.safar@gmail.com>
7964 * anonymous.cs (MakeName): Make faster and zero-based.
7965 (VerifyExplicitParameterCompatibility): Back to mode where generic
7966 parameter is ignored.
7967 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7969 * class.cs (EmitType): Method can emit another new method.
7971 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7973 * driver.cs: Updated.
7975 * lambda.cs: Reuse predefined empty parameters.
7977 * parameter.cs: Updated
7979 * support.cs: Implemented InflateTypes.
7981 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7982 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7984 2007-04-03 Martin Baulig <martin@ximian.com>
7988 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7989 version of TypeManager.IsOverride() which also works with generic
7992 2007-04-03 Martin Baulig <martin@ximian.com>
7997 (Convert.ExplicitReferenceConversion): We need to cast when
7998 converting from IList<T> to S[].
8000 2007-04-01 Marek Safar <marek.safar@gmail.com>
8002 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8005 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8007 2007-03-31 Marek Safar <marek.safar@gmail.com>
8009 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8010 argument and return type inferring.
8012 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8013 (ReturnType): Turned to property.
8015 * statement.cs (Return): Implemented return type inferring.
8017 * support.cs (ReflectionParameters): Use local types if possible.
8019 2007-03-30 Raja R Harinath <rharinath@novell.com>
8021 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8022 (FlowBranching.UsageVector): Update to changes.
8024 Prepare to kill 'Reachability'
8025 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8026 argument of constructor.
8028 2007-03-29 Raja R Harinath <rharinath@novell.com>
8030 Prepare to kill 'Reachability'
8031 * flowanalysis.cs (UsageVector.is_unreachable): New.
8032 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8033 'reachability', and verify they're consistent.
8036 * expression.cs (New.EmitStatement): Handle type parameters here too.
8038 2007-03-29 Martin Baulig <martin@ximian.com>
8043 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8044 CompilerGeneratedClass.
8045 (ScopeInfo.EmitScopeInstance): Make this protected.
8046 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8047 `ec.CurrentAnonymousMethod.Scope == Scope'.
8049 * statement.cs (Block.ScopeInfo): Make this a property.
8051 2007-03-27 Raja R Harinath <harinath@gmail.com>
8053 Prepare to kill 'Reachability'
8054 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8055 (FlowBranching.UsageVector.Reachability): Remove property.
8056 (FlowBranching.UsageVector.IsUnreachable): New property.
8057 (FlowBranching.UsageVector.ResetBarrier): New.
8058 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8059 * codegen.cs, statement.cs: Update to changes.
8061 2007-03-27 Martin Baulig <martin@ximian.com>
8066 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8069 2007-03-26 Raja R Harinath <rharinath@novell.com>
8071 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8072 instead of TriState. Remove all mention of TriState.
8074 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8075 replaced by a boolean. Add boolean 'is_unreachable' field, check
8076 and maintain invariants.
8078 2007-03-25 Marek Safar <marek.safar@gmail.com>
8080 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8082 2007-03-25 Marek Safar <marek.safar@gmail.com>
8084 * expression.cs: Stop using obsolete 2.0 opcodes.
8086 2007-03-25 Marek Safar <marek.safar@gmail.com>
8088 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8089 one of the latests Martin's fixes.
8091 2007-03-23 Miguel de Icaza <miguel@novell.com>
8093 * expression.cs: On BigEndian systems, swap the bytes, temporary
8094 solution until we get a new bitconverter class.
8096 2007-03-23 Martin Baulig <martin@ximian.com>
8100 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8101 "Method" and "Method`1". Normally, a cache lookup is done on the
8102 "Method" form (ie. without the generic arity), but this one makes
8103 lookups on the full form work as well.
8105 2007-03-22 Raja R Harinath <rharinath@novell.com>
8107 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8110 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8112 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8113 ordered_member_list, to TypeBuilder to store members to be defined
8114 in the order they were parsed in.
8115 - ordered_explicit_member_list contains all properties indexers
8116 and methods that are defined as explicit implementation of an
8117 interface or base class.
8118 - ordered_member_list contains all properties indexers and methods
8119 that are not defined as explicit implementation of an interface
8122 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8123 functionality in these removed classes has been replaced with
8124 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8125 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8127 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8128 to CheckForDuplications inside GetMethod and SetMethod Define Method
8129 to handle method property and indexer name conflicts.
8133 All code is contributed under the MIT/X11 license.
8135 2007-03-20 Martin Baulig <martin@ximian.com>
8137 * class.cs (TypeContainer.Interfaces): Removed; they're now
8138 included in `TypeContainer.Types'.
8140 2007-03-20 Martin Baulig <martin@ximian.com>
8142 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8144 * class.cs (TypeContainer.CreateType): New public method. This is
8145 now called before DefineType() to create the TypeBuilders.
8146 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8147 has already been created by CreateType().
8148 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8149 don't resolve our base classes here; this has been moved into
8150 DefineBaseTypes(). We're now called from CreateType().
8151 (TypeContainer.DefineBaseTypes): New private method; resolve our
8152 base classes here. We're now called from DefineType().
8155 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8156 our types first to create all the TypeBuilders. After that, call
8157 TypeContainer.DefineType() on all the types which'll resolve their
8158 base classes and setup the resolve order.
8160 2007-03-20 Martin Baulig <martin@ximian.com>
8162 * class.cs (TypeContainer.Enums): Removed; they're now included in
8163 `TypeContainer.Types'.
8165 2007-03-20 Martin Baulig <martin@ximian.com>
8168 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8169 (TypeContainer.DoResolveMembers): Call DefineType() on our
8170 `compiler_generated' classes; moved here from DefineNestedTypes().
8173 (RootContext.ResolveTree): Call ResolveMembers() on all
8174 TypeContainer's in the `type_container_resolve_order'.
8176 2007-03-19 Marek Safar <marek.safar@gmail.com>
8178 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8180 2007-03-17 Marek Safar <marek.safar@gmail.com>
8182 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8183 implementation flags.
8185 2007-03-17 Marek Safar <marek.safar@gmail.com>
8187 * class.cs: More optimizations for type parameters.
8189 2007-03-15 Marek Safar <marek.safar@gmail.com>
8191 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8193 * ecore.cs, parameter.cs: More common code for both corlibs.
8195 * typemanager.cs (IsGenericMethod): Simplified.
8197 2007-03-15 Raja R Harinath <rharinath@novell.com>
8199 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8201 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8203 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8204 unconditionally. Simplify explanation.
8205 (Try.Resolve, Using.Resolve): Likewise.
8207 2007-03-15 Martin Baulig <martin@ximian.com>
8211 * decl.cs (DeclSpace): If we're a partial class, use our
8212 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8214 2007-03-15 Raja R Harinath <rharinath@novell.com>
8216 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8218 (FlowBranching.UsageVector): Update to changes.
8219 (FlowBranching.MergeSiblings): Likewise.
8220 * statement.cs: Likewise.
8222 2007-03-15 Martin Baulig <martin@ximian.com>
8227 (MemberCache): Added a special .ctor for type parameters.
8230 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8233 2007-03-09 Martin Baulig <martin@ximian.com>
8235 * enum.cs (Enum): Make this a TypeContainer.
8236 (EnumMember): Derive from `Const'.
8239 (Const.DoResolveValue): New protected virtual method; move most of
8240 the functionality of ResolveValue() here so we can override it in
8242 (Const.CreateConstantReference): Make this virtual.
8244 * class.cs (Kind): Add `Kind.Enum'.
8245 (TypeContainer.Emit): Don't emit the enums here; they're already
8246 in the `RootContext.typecontainer_resolve_order'.
8248 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8249 here; they're already in the `typecontainer_resolve_order'.
8251 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8252 TypeManager.DropGenericTypeArguments().
8255 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8256 (TypeManager.IsEnumType): Likewise.
8257 (TypeManager.EnumToUnderlying): Likewise.
8258 (TypeManager.IsEqual): Add support for enums.
8260 2007-03-12 Raja R Harinath <rharinath@novell.com>
8262 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8263 DefaultParameterValueAttribute to be undefined, say if System.dll
8266 2007-03-11 Marek Safar <marek.safar@gmail.com>
8268 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8271 2007-03-10 Marek Safar <marek.safar@gmail.com>
8273 * class.cs, parameter.cs: Unified parameters verification.
8275 2007-03-08 Martin Baulig <martin@ximian.com>
8277 * cs-parser.jay (constructor_header): Pass the location to the
8278 newly created TopLevelBlock.
8280 2007-03-07 Martin Baulig <martin@ximian.com>
8282 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8284 2007-03-06 Miguel de Icaza <miguel@novell.com>
8286 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8287 with the changes from David, fixes the build.
8289 2007-03-05 David Mitchell <dmitchell@logos.com>
8291 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8292 and its base interfaces to a one-dimensional array type S[],
8293 provided there is an implicit or explicit reference conversion
8296 2007-03-03 Marek Safar <marek.safar@gmail.com>
8298 * cs-tokenizer.cs: Implemented basic linq grammar.
8300 * driver.cs: Set linq lang version on demand.
8302 2007-02-26 Marek Safar <marek.safar@gmail.com>
8304 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8306 2007-02-25 Marek Safar <marek.safar@gmail.com>
8308 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8311 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8313 Check property and event extern attributes.
8315 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8318 2007-02-24 Marek Safar <marek.safar@gmail.com>
8320 A fix for bug #80407
8321 * ecore.cs: Don't report ambiguity error when methods have same parent.
8323 2007-02-23 Marek Safar <marek.safar@gmail.com>
8325 A fix for bug #80878
8326 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8328 2007-02-22 Marek Safar <marek.safar@gmail.com>
8330 * attribute.cs: Enable ExtensionAttribute presence test.
8332 2007-02-22 Marek Safar <marek.safar@gmail.com>
8334 * class.cs: Warn about missing GetHashCode only when Equals is override.
8336 * decl.cs: Check accessibility of type arguments.
8338 * typemanager.cs: Correctly report nullable array.
8340 2007-02-20 Marek Safar <marek.safar@gmail.com>
8342 * class.cs, report.cs: Capture more details when things go wrong.
8344 2007-02-20 Marek Safar <marek.safar@gmail.com>
8346 A fix for bug #80650
8347 * cs-parser.jay: Anonymous container starts at constructor declaration
8348 and not at block beginning because it has to be usable in constructor
8351 * statement.cs: Use context location and not block one for error reporting.
8353 2007-02-18 Marek Safar <marek.safar@gmail.com>
8355 A fix for bug #78712
8356 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8359 2007-02-18 Marek Safar <marek.safar@gmail.com>
8361 A fix for bug #80493 by Atsushi Enomoto
8362 * cs-parser.jay: Ignore invalid attribute target.
8364 2007-02-18 Marek Safar <marek.safar@gmail.com>
8366 * cs-tokenizer.cs: Ignore '\0' as white space character.
8368 2007-02-17 Miguel de Icaza <miguel@novell.com>
8370 * cs-parser.jay: Add support for lambda expressions to the mcs
8373 * lambda.cs: Only clone when we are probing, not on the final call
8374 (Compatible is the final call).
8376 * statement.cs (CloneContext): Introduce class to provide block
8377 remapping during clone.
8379 All statements Clone themselves now.
8381 (Clone): special handling for blocks, when we clone a block, we
8382 register the block inside this routine, as children of the block
8383 might trigger a lookup.
8385 * expression.cs: Add support for CloneContext in all expressions.
8387 2007-02-17 Marek Safar <marek.safar@gmail.com>
8389 A fix for bug #80493
8390 * statement.cs: Report ambiguous warning when interfaces are not related.
8392 2007-02-15 Marek Safar <marek.safar@gmail.com>
8394 C# 3.0 extension methods.
8396 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8397 cannot be used directly.
8399 * class.cs (Class.Emit): Emit extension attribute if any class method
8400 is extension method.
8401 (Method.Define): Add basic extension method validation conditions.
8402 (Method.Emit): Emit extension attribute for method.
8404 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8405 extension method exists. Currently we follow same approach as Microsoft
8406 does, emit even if a method or a class are private but this can change
8409 * cs-parser.jay: Add handling of `this' keyword in method parameters
8412 * decl.cs (DeclSpace.IsStaticClass): New property.
8413 (MemberCache.FindExtensionMethods): Looks for extension methods with
8414 defined name and extension type.
8416 * doc.cs: Updated after OverloadResolve changes.
8418 * driver.cs: Add new soft reference to System.Core.dll.
8420 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8421 (ExtensionMethodGroupExpr): Represents group of extension methods.
8423 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8424 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8425 to MethodGroupExpr and made non-static for easier customization.
8426 (Invocation.DoResolve): Add extension method lookup when no standard
8428 (MemberAccess.DoResolve): Try extension methods if no member exists.
8430 * modifiers.cs: Add METHOD_EXTENSION modifier.
8432 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8433 as well as candidate extension type.
8434 (ComputeNamespaces): When assembly constains extension methods registers
8436 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8437 extension method lookup.
8438 (Namespace.LookupExtensionMethod): Looks for extension method in this
8440 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8441 find a method which matches name and extensionType.
8443 * parameter.cs (Parameter): Add This modifer.
8444 (HasExtensionMethodModifier): New property.
8445 (Resolve): Add extension parameter check.
8446 (ModFlags): turned to property to exclude this modifier as it is not real
8448 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8450 * support.cs (ParameterData): Add ExtensionMethodType.
8451 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8453 * typemanager.cs: Add type and ctor extension attribute type.
8455 2007-02-15 Miguel de Icaza <miguel@novell.com>
8457 * report.cs (DisableErrors, EnableErrors): used to prevent error
8458 output when we are "trying" to compile various methods with
8461 * ecore.cs (Expression): Add Clone method that calls the virtual
8462 CloneTo method. The current CloneTo method in Expression throws
8463 an exception so we can track down all the places where this must
8464 be implemented (not using abstract, because that would be a lot of
8465 up-front-work before we can start testing the implementation
8468 Important: we only need Clone capabilities for expressions created
8469 by the parser, as the expressions we will be cloning are
8470 expressions in the pre-resolved state. This vastly simplifies
8473 (SimpleName): Add CloneTo that does nothing.
8474 (EmptyCast): Add CloneTo.
8476 * expression.cs (Binary): Implement CloneTo.
8477 (Invocation.IsApplicable): Store the current ec in
8478 EmitContext.TempEc and restore it on return. This is used so we
8479 do not have to sprinkle hundres of methods with an extra
8480 EmitContext, we know that the only user is the lambda expression
8481 ImplicitConversionExists code.
8483 (Argument): Add Cloning capabilities.
8484 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8485 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8486 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8487 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8488 IndexerAccess): Add Clone capability.
8490 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8492 (Argument): Add cloning capability.
8494 * assign.cs (Assign): Implement CloneTo.
8496 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8498 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8499 version by calling Convert with the EmitContext (that we are
8500 currently storing in ec, this is not great, but will do for now,
8501 to avoid passing EmitContext parameters to hundreds of functions
8502 that do not need them now).
8504 (SetExpression): Remove, it is not needed.
8506 (ContextualReturn): Implement CloneTo.
8508 * statement.cs (Statement): Implement cloning infrastructure,
8509 similar to expressions.
8511 (Block): Partial implementation of Clone for statements.
8513 (Return): Implement clone.
8515 * constant.cs (Constant.CloneTo): New method, does nothing.
8517 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8518 solution, until we decide how to exactly do this.
8520 2007-02-14 Marek Safar <marek.safar@gmail.com>
8522 A fix for bug #80493
8523 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8524 a property is override we need to use second accessor.
8526 2007-02-13 Marek Safar <marek.safar@gmail.com>
8528 A fix for bug #80418
8529 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8532 2007-02-13 Marek Safar <marek.safar@gmail.com>
8534 Another fix for bug #80749
8535 * pending.cs: Abstract class has priority over interfaces.
8537 2007-02-13 Marek Safar <marek.safar@gmail.com>
8539 Another fix for bug #80749
8540 * pending.cs: Abstract class has priority over interfaces.
8542 2007-02-13 Marek Safar <marek.safar@gmail.com>
8544 Another fix for bug #80749
8545 * pending.cs: Abstract class has priority over interfaces.
8547 2007-02-13 Marek Safar <marek.safar@gmail.com>
8549 Another fix for bug #80749
8550 * pending.cs: Abstract class has priority over interfaces.
8552 2007-02-13 Marek Safar <marek.safar@gmail.com>
8554 * class.cs Better error message.
8556 * driver.cs: Add shorter versions of -optimize option.
8558 2007-02-13 Martin Baulig <martin@ximian.com>
8560 * class.cs (Constructor.Emit): Check the return value of
8561 ec.ResolveTopBlock() and return on error.
8563 2007-02-13 Raja R Harinath <rharinath@novell.com>
8565 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8566 message to fix error message regression.
8568 2007-02-12 Marek Safar <marek.safar@gmail.com>
8570 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8572 2007-02-12 Marek Safar <marek.safar@gmail.com>
8574 A fix for bug #80749
8575 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8576 its parent container.
8578 * class.cs (DefineFieldInitializers): Each initializer can has different
8581 * const.cs: Updated.
8583 2007-02-11 Miguel de Icaza <miguel@novell.com>
8585 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8586 now all the heavy lifting to check that embedded statements or
8587 expressions have the right form is done in the ContextualReturn.
8589 (ContextualReturn): New class.
8591 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8592 method that can be invoked to report 201, so we do not replicate
8595 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8597 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8598 treating tabs as spaces.
8600 2007-02-09 Marek Safar <marek.safar@gmail.com>
8602 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8603 * assign.cs: Use full implicit conversion for right side check.
8605 2007-02-09 Marek Safar <marek.safar@gmail.com>
8607 * statement.cs (Switch): Switch over boolean type is not standardized.
8609 2007-02-08 Marek Safar <marek.safar@gmail.com>
8611 A fix for bug #80755
8612 * decl.cs (FindBaseEvent): Don't use method cache for events.
8614 2007-02-07 Marek Safar <marek.safar@gmail.com>
8616 * cs-parser.jay: Better syntax error handling.
8618 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8619 instead of underlying type value.
8621 2007-02-06 Marek Safar <marek.safar@gmail.com>
8623 * driver.cs: Check define identifier before is registered.
8625 * namespace.cs: Use existing error message.
8627 * report.cs: New warning.
8629 2007-02-06 Marek Safar <marek.safar@gmail.com>
8631 A fix for bug #80742
8632 * expression.cs: Delegate Invoke method can be called directly.
8634 2007-02-06 Marek Safar <marek.safar@gmail.com>
8636 A fix for bug #80676
8637 * class.cs (IsEntryPoint): The Main method can have params modifier.
8639 2007-02-04 Miguel de Icaza <miguel@novell.com>
8641 * parameter.cs (Parameter, Parameters): Add Clone method.
8643 * anonymous.cs (Compatible): Turn method into virtual method, so
8644 LambdaExpression can implement a different behavior.
8646 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8647 out the basic checking here, so it can be used by
8650 * lambda.cs: Introduce "Compatible" function that will do the
8653 2007-02-02 Marek Safar <marek.safar@gmail.com>
8655 * attribute.cs: Unified one error message.
8657 * class.cs (Class): Use type attributes and not properties to test static
8659 (IsEntryPoint): Don's pass local variable.
8661 * convert.cs: Removed duplicate check.
8663 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8665 * driver.cs: Don't crash when soft reference does not exist.
8667 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8668 (UsingEntry): Removed redundant allocation.
8670 * parameter.cs: Add fast path for type parameters.
8672 * support.cs: Don't allocate attribute when it's not used.
8674 2007-01-30 Miguel de Icaza <miguel@novell.com>
8677 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8678 this into a virtual method, so we can override it in LambdaExpression.
8680 * driver.cs: Improve diagnostics in case of failure.
8682 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8683 write a function that is slightly more complex and that parses:
8685 type identifier [, type identifier]* )
8687 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8690 (canEmpty ? i >= 0 : i > 0)
8692 2007-01-30 Raja R Harinath <rharinath@novell.com>
8694 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8695 exception on possibly valid code.
8697 2007-01-29 Raja R Harinath <rharinath@novell.com>
8699 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8701 (parse_opt_type_arguments): Remove. It's almost the same as
8703 (parse_namespace_or_typename): Use parse_less_than.
8705 2007-01-28 Miguel de Icaza <miguel@novell.com>
8707 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8708 this bug took a few hours to find, because the state saved and
8709 restored by PushPosition and PopPosition was ignoring the state of
8710 parse_generic_less_than.
8712 I can also now remove the handling of OP_LT and OP_GT, this solves
8715 * cs-tokenizer.cs: store the location for the ARROW token, we use
8718 (PushPosition, PopPosition): save/restore also `current_token',
8719 restore `parse_generic_less_than' (was missing).
8721 (parse_opt_type_arguments): use parse_type, not
8722 parse_namespace_or_typename to parse types.
8724 * lambda.cs: Empty new file, will eventually have the lambda
8725 expression implementation.
8727 * lambda.test: used to test the internal tokenizer.
8729 * report.cs (FeatureIsNotISO1): Rename from
8730 FeatureIsNotStandardized, because it was about the language level
8731 (1 vs 2) it was not about standarization.
8733 (FeatureRequiresLINQ): New.
8735 * support.cs (SeekableStreamReader): Only require that the reader
8736 is a TextReader, not a StreamReader, so we can plug StringReader.
8738 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8739 given position in the input stream the following tokens can be
8740 parsed as a type followed by an identifier.
8742 (is_punct): after a '(' if parse_type_and_parameter returns true,
8743 then return a special token OPEN_PARENS_LAMBDA which is used to
8744 avoid reduce/reduce errors in the grammar for the
8745 lambda_expression rules.
8747 (parse_type): implement a type parser inside the
8748 tokenizer, the parser only returns true or false depending on
8749 whether the input at a given position can be parsed as a type.
8751 (peek_token): new method used during type parsing.
8753 2007-01-28 Raja R Harinath <rharinath@novell.com>
8756 * anonymous.cs (ScopeInfo.InflateParameters): New.
8757 (AnonymousContainer.Resolve): Use it to redirect types of
8758 delegate parameters.
8760 2007-01-27 Raja R Harinath <rharinath@novell.com>
8763 * expression.cs (Error_InvalidArguments): Don't use two different
8764 messages for CS1503. Use ExtraInformation and
8765 SymbolRelatedToPreviousError instead.
8768 * decl.cs (DeclSpace.initialize_type_params): Don't access
8769 'type_params' of a partial class directly.
8771 2007-01-26 Miguel de Icaza <miguel@novell.com>
8773 * constant.cs: Removed a handful of out-of-range checks that were
8776 2007-01-25 Marek Safar <marek.safar@gmail.com>
8778 * expression.cs (CheckUselessComparison): Add additional check for char
8781 * namespace.cs: Fixed typo.
8783 2007-01-23 Miguel de Icaza <miguel@novell.com>
8785 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8786 gone, instead we inline the test, preventing the needless casts to
8787 longs, ulongs and doubles for the parameters, avoiding calls to
8788 methods that overchecked stuff, and instead inlined things
8791 2007-01-20 Marek Safar <marek.safar@gmail.com>
8793 * cs-parser.jay: Better parameter error handling.
8795 2007-01-17 Marek Safar <marek.safar@gmail.com>
8797 A fix for bug #80368, #80522
8798 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8799 whether array initializer contains constants only.
8800 (ArrayCreation.Emit): Use better formula to decide when
8801 are array initializers for static initialization.
8802 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8803 have to emit even constants otherwise they are pre-initialized.
8805 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8806 Raja R Harinath <rharinath@novell.com>
8808 Fix emit order of 'get' vs. 'set'.
8809 * support.cs (Accessors): New.
8810 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8811 Note the order in which accessors are declared in the source.
8812 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8813 Refactored from Property.Define and Indexer.Define.
8814 (PropertyBase.DefineAccessors): New helper that calls the above in
8815 appropriate order as noted by the parser.
8816 (Property.Define, Indexer.Define): Update to changes.
8817 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8819 2007-01-17 Raja R Harinath <rharinath@novell.com>
8821 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8822 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8823 there's an implicit conversion from the current type to the target
8824 type before converting the underlying constant.
8826 2007-01-16 Marek Safar <marek.safar@gmail.com>
8828 * const.cs (ResolveValue): Updated after constant conversion was made more
8831 * constant.cs (GetAttributableValue): constant to object conversion is
8832 used for attributes only.
8833 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8834 constant conversions.
8835 (LongConstant.ConvertImplicitly): Ditto.
8837 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8838 (ImplicitConversionStandard): Handle constant conversion as extra step.
8839 It solves the issue when constant conversion was called indirectly like
8840 inside array initializer and constant folding was skipped.
8842 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8845 * statement.cs(ImplicitConversionStandard): Updated after constant
8846 conversion was made more generic.
8848 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8850 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8851 Constraints, solves the problem where the compiler incorrectly
8852 reported that a type parameter was not constrained to a class (Bug
8855 2007-01-14 Marek Habersack <grendello@gmail.com>
8857 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8859 2007-01-14 Marek Safar <marek.safar@gmail.com>
8861 A fix for bug #80368
8862 * assign.cs (FieldInitializer): New class implements field
8863 initializer statement.
8865 * attribute.cs: Update after FieldMember rename.
8867 * class.cs (PropertyBasedMember): New common class for property based
8869 (InterfaceMemberBase): New base class for all members which can be used as
8870 an interface members.
8871 (MethodCore): Moved really common code to InterfaceMemberBase.
8872 (Method.Define): Equal and GetHasCode detection is relevant for methods
8874 (MethodData.Define): Don't assume that public event implements an
8875 interface automatically.
8876 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8878 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8879 (FieldMember): Merged with FieldBase.
8880 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8881 event extern modifier can be used.
8882 (EventField.EventFieldAccessor): Moved event field specific code here.
8883 (Event.AllowedModifiers): Even event can be extern.
8884 (Event.FindOutBaseMethod): New override specific to events.
8885 (Indexer.parameters): Reintroduce parameters because base class holds
8886 only properties common data.
8887 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8888 need do extra parameters check.
8890 * const.cs: Update after FieldMember rename.
8892 * decl.cs (MemberCache.FindBaseEvent): New method.
8894 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8895 to reflect that indexer is now derived from PropertyBased.
8897 * ecore.cs (GetMemberType): Made public.
8898 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8901 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8903 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8904 (RegisterEvent): Removed.
8905 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8906 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8908 2007-01-11 Raja R Harinath <rharinath@novell.com>
8911 * statement.cs (CollectionForeach.TryType): Prefer generic
8912 GetEnumerator over non-generic variant. Fix code to follow comments.
8914 2007-01-09 Raja R Harinath <rharinath@novell.com>
8917 * support.cs (ReflectionParameter): Don't use an invalid index on
8918 the generic parameter data.
8920 2007-01-08 Miguel de Icaza <miguel@novell.com>
8922 * driver.cs: Just add a tiny bit of infrastructure.
8924 2007-01-02 Marek Safar <marek.safar@gmail.com>
8926 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8927 where field type is struct from current assembly.
8929 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8932 2007-01-02 Marek Safar <marek.safar@gmail.com>
8934 A fix for bug #80381
8935 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8938 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8940 (Namespace.LookupType): Always use core types from corlib when speficied.
8942 * report.cs: A new warning.
8944 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8945 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8946 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8948 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8949 (InitCoreTypes): Set expression type of object_type and value_type
8950 immediately after lookup.
8952 2007-01-01 Miguel de Icaza <miguel@novell.com>
8954 * cs-tokenizer.cs: Accept Pc class characters (Connector
8955 Punctuation) as valid identifiers. Fixes #78259
8957 * expression.cs (Invocation.DoResolve): Moved the check for the
8958 use of `this' for doing method calls to the Invocation resolution
8959 step, after overload resolution has taken place instead of doing
8960 the check at the low-level `This.DoResolve' level.
8962 The `This.DoResolve'(appens before overload resolution, so it has
8963 no way of knowing if the method that will be called will be
8964 instace or static, triggering an erroneous report for cs0188 (Bug
8967 We now do the check for instance method invocations after we know
8968 what method will be called.
8970 (This.CheckThisUsage): Move the actual use of this structure
8971 checking into its own method and expose it.
8973 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8976 Exceptions: Null.ConvertImplicitly,
8977 Constant.ImplicitConversionRequired as there are too many call
8978 sites for passing the ec.
8980 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8981 EmitContext, if the value is null, then we do not try to provide
8982 the extra information from the error (If a userdefined conversion
8983 exists, as UserDefinedConversion requires a non null-EmitContext).
8987 2006-12-30 Raja R Harinath <rharinath@novell.com>
8989 * flowanalysis.cs (MyBitVector): Document some invariants.
8990 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8991 introduced below, and add a couple of others,
8993 2006-12-30 Marek Safar <marek.safar@gmail.com>
8995 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8996 GetPropertyFromAccessor and GetEventFromAccessor.
8998 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8999 overrides non-obsolete one.
9000 (Indexer.Define): Error message has been moved to the parser.
9002 * cs-parser.jay: Better syntax errors handling.
9004 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9005 when an invocation has no arguments.
9007 * ecore.cs: Removed not used caching.
9009 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9012 * report.cs: Add a new warning.
9014 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9016 * typemanager.cs (enumeration_type): Removed.
9017 (CSharpSignature): Reuses IsSpecialMethod.
9018 (IsEqual): Hack for MS BCL.
9019 (GetPropertyFromAccessor): New method.
9020 (GetEventFromAccessor): New method.
9021 (IsSpecialMethod): Fixed to handle more cases.
9023 2006-12-30 Marek Safar <marek.safar@gmail.com>
9025 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9026 Made white spaces array static.
9028 * ecore.cs (RemoveGenericArity): Optimized.
9030 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9032 (MyBitVector.initialize_vector): Simplified.
9034 2006-12-22 Miguel de Icaza <miguel@novell.com>
9036 * ecore.cs: Am not entirely happy with this hack, but it seems to
9037 address the issue in 80257 (a small test case for
9040 I set the MethodGroupExpr.Type to an internal compiler type
9041 (itself in this case) to force the resolution to take place. Why
9042 it does not take place with a null is beyond me.
9044 2006-12-20 Marek Safar <marek.safar@gmail.com>
9046 A fix for bug #80288
9047 * expression.cs (ResolveOperator): Consider user defined conversion for
9048 logical and operator too.
9049 (EmitBranchable): Optimization for logical and when full constant folding
9050 could not be applied but one operand is constant.
9052 2006-12-19 Marek Safar <marek.safar@gmail.com>
9054 * class.cs (GetClassBases): Write 5 times every day, will never use
9055 FullName for error reporting.
9057 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9059 2006-12-19 Martin Baulig <martin@ximian.com>
9061 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9062 the symbol file info here.
9064 2006-12-18 Marek Safar <marek.safar@gmail.com>
9066 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9067 of `elseif' is taking then following sections are not taking.
9068 Fixes an issue reported on mono mailing list.
9070 2006-12-18 Marek Safar <marek.safar@gmail.com>
9072 A fix for bug #80300
9073 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9074 a caller is not taking.
9076 2006-12-18 Raja R Harinath <rharinath@novell.com>
9078 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9079 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9080 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9081 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9082 * class.cs: Update to changes.
9084 2006-12-17 Marek Safar <marek.safar@gmail.com>
9086 A fix for bug #79934
9087 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9090 * class.cs (ResolveMembers): Register an iterator in current container and
9093 2006-12-16 Raja R Harinath <rharinath@novell.com>
9096 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9097 satisfy a params annotated parameter.
9099 2006-12-16 Marek Safar <marek.safar@gmail.com>
9101 A fix for bug #77014
9102 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9103 paramters correctly and not rely on hacks in Parameters class.
9104 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9106 (Invocation.VerifyArgumentsCompat): Ditto.
9107 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9110 * parameter.cs (HasParams): Don't assume that params is the last one.
9112 * support.cs (ReflectionParameters.ctor): Look for params attribute
9114 (ReflectionParameters.ParameterType): Removed hack when we returned last
9115 parameter for out of range parameters.
9116 (ParameterName, ParameterModifier): Ditto.
9118 2006-12-14 Marek Safar <marek.safar@gmail.com>
9120 A fix for bug #79987
9121 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9122 when assembly is not CLS compliant but type is. I have no idea why is this
9125 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9127 2006-12-13 Miguel de Icaza <miguel@novell.com>
9129 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9130 in struct constructors, they are basically no-ops.
9132 2006-12-12 Marek Safar <marek.safar@gmail.com>
9134 * cs-tokenizer.cs (Position): Save preprocessor status too.
9136 2006-12-12 Marek Safar <marek.safar@gmail.com>
9138 A fix for bug #77794
9139 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9141 2006-12-12 Marek Safar <marek.safar@gmail.com>
9143 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9145 (pp_expr): Report error for an invalid expression.
9146 (handle_preprocessing_directive): Simplified; add more error checking.
9148 2006-12-11 Marek Safar <marek.safar@gmail.com>
9150 A fix for bug #74939
9151 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9152 directives handling.
9154 2006-12-10 Marek Safar <marek.safar@gmail.com>
9156 A fix for bugs #80093, and #75984
9157 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9158 logic, it seems to me as it worked before "by coincidence".
9159 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9160 (cleanup): Enabled endif check.
9162 2006-12-09 Marek Safar <marek.safar@gmail.com>
9164 A fix for bug #80162
9165 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9166 enumerators are never ambiguous.
9168 2006-12-08 Raja R Harinath <rharinath@novell.com>
9171 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9173 2006-12-06 Marek Safar <marek.safar@gmail.com>
9175 A fix for bug #80144
9176 * class.cs (EventProperty.Define): Explicit implementation means
9177 that an even is used.
9179 2006-12-06 Marek Safar <marek.safar@gmail.com>
9181 Fixes the operators implementation (part II)
9183 * cfold.cs (DoConstantNumericPromotions): Renamed to
9184 DoBinaryNumericPromotions and simplified.
9185 (BinaryFold): Couple of conversion fixes; simplified.
9187 * constant.cs, ecore.cs, literal.cs
9188 (ToType): Renamed to ConvertImplicitly.
9189 (Reduce): Renamed to ConvertExplicitly.
9191 * class.cs, convert.cs: Updated.
9193 * expression.cs: TryReduce doesn't throw an exception.
9195 2006-12-01 Marek Safar <marek.safar@gmail.com>
9197 A fix for bug #80108
9198 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9201 2006-11-30 Marek Safar <marek.safar@gmail.com>
9203 Fixes unary operators implementation (part I)
9206 * cfold.cs (Error_CompileTimeOverflow): Made internal
9208 * const.cs (IConstant): Changed to use reference to constant and
9209 not constant itself.
9210 Updated IConstant implementations.
9212 * constant.cs (CreateConstant): New factory method.
9213 Updated IConstant implementation.
9215 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9217 * ecore.cs: Updated to use CreateConstantReference.
9219 * enum.cs: Reflects IConstant changes.
9221 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9223 * literal.cs (NullConstant): Change to be independently usable.
9225 2006-11-29 Martin Baulig <martin@ximian.com>
9227 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9228 we need to emit the scope initializer before calling the base .ctor.
9230 * anonymous.cs: Merged back from the new anonymous methods branch.
9231 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9233 * expression.cs (ParameterReference.DoResolveBase): Create a
9234 "normal" ScopeInfo when capturing parameters rather than using the
9235 root scope; this makes things work with anonymous methods having
9239 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9241 2006-11-22 Marek Safar <marek.safar@gmail.com>
9243 A fix for bug #79987
9244 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9245 check to a base class.
9246 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9247 only when assembly has missing attribute.
9248 * report.cs: Update.
9250 2006-11-21 Marek Safar <marek.safar@gmail.com>
9252 * cs-tokenizer.cs: Merged with gmcs version.
9254 2006-11-20 Marek Safar <marek.safar@gmail.com>
9257 * cs-parser.jay: Better error message when partial keyword is misplaced.
9259 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9261 A fix for bug #79810
9262 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9263 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9264 a RuntimeWrappedException by default.
9266 2006-11-18 Marek Safar <marek.safar@gmail.com>
9268 A fix for bug #79843
9269 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9271 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9273 2006-11-18 Marek Safar <marek.safar@gmail.com>
9275 * driver.cs, namespace.cs: Uses faster IndexOf version.
9277 2006-11-17 Marek Safar <marek.safar@gmail.com>
9279 A fix for bug #79941
9280 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9282 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9283 even if internal name is different.
9284 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9285 (UserDefinedConversion): Simplified as the operators cannot be internal.
9286 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9288 (MethodLookup): Replaced EmitContext with parentType.
9289 * expression.cs: Updated.
9291 2006-11-09 Raja R Harinath <rharinath@novell.com>
9293 * driver.cs (BadAssembly): Handle all the ugliness of
9294 DefineDynamicAssembly.
9296 2006-11-08 Raja R Harinath <rharinath@novell.com>
9298 Address parts of #58244 -- most of what's left is in the runtime
9299 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9300 CS1509 error checks, and handle them for all assembly loads, not
9301 just the first invocation.
9302 (LoadModule): Likewise. Move handling of 'adder_method' ...
9303 * codegen.cs (AssemblyClass.AddModule): ... here.
9305 2006-11-02 Marek Safar <marek.safar@gmail.com>
9307 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9308 IEnumerable<T> is ambiguous.
9310 2006-10-31 Marek Safar <marek.safar@gmail.com>
9312 A fix for bug #67689
9313 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9314 GetEnumerator is ambiguous.
9316 * report.cs: Add new warning.
9318 2006-10-29 Marek Safar <marek.safar@gmail.com>
9320 A fix for bug #78602
9321 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9322 to protected member can be nested type.
9324 2006-10-28 Marek Safar <marek.safar@gmail.com>
9326 A fix for bug #78965
9327 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9328 to protected member must derive from current type.
9330 2006-10-27 Marek Safar <marek.safar@gmail.com>
9332 assign.cs: Reuses error method.
9334 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9335 instead of type for constants.
9336 (Expression.Error_ValueAssignment): Common error method.
9338 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9341 2006-10-27 Marek Safar <marek.safar@gmail.com>
9343 A fix for bug #79081
9344 * expression.cs (MemberAccess.DoResolve): Check nested type
9347 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9349 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9351 2006-10-26 Marek Safar <marek.safar@gmail.com>
9353 A fix for bug #76591
9354 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9356 2006-10-26 Marek Safar <marek.safar@gmail.com>
9358 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9359 type forwarder of the same type multiple times.
9361 2006-10-26 Raja R Harinath <rharinath@novell.com>
9364 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9365 instance as an rvalue, even when we later resolve as an lvalue.
9367 2006-10-25 Martin Baulig <martin@ximian.com>
9369 * anonymous.cs: Fix #79673.
9371 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9373 A fix for bug #79666
9374 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9375 ignored when is optimized (= default value) as its value is already set.
9377 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9379 A fix for bug #79724
9380 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9381 TypeContainer for type lookup.
9383 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9385 A fix for bug #79231
9386 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9387 * expression.cs (OverloadResolve): Always convert type name for
9389 (ResolveNamespaceOrType): Don't confuse a nested type with any
9392 2006-10-18 Martin Baulig <martin@ximian.com>
9394 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9396 2006-10-17 Miguel de Icaza <miguel@novell.com>
9398 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9399 an int32, but requesting an int64 from the conversion
9401 2006-10-12 Martin Baulig <martin@ximian.com>
9404 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9406 2006-10-12 Martin Baulig <martin@ximian.com>
9409 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9411 2006-10-11 Miguel de Icaza <miguel@novell.com>
9413 * convert.cs: Remove broken code: I was doing the "Existance"
9414 tests for Implicit conversions.
9416 2006-10-10 Miguel de Icaza <miguel@novell.com>
9418 * convert.cs: Added one missing case in
9419 ImplicitStandardConversionExists uint64 to intptr.
9423 * typemanager.cs (uintptr_type): another core known type.
9425 * ecore.cs (OperatorCast): routine used to do cast operations that
9426 depend on op_Explicit. We could change some of the Decimal
9427 conversions to use this.
9429 This one has a probe mechanism that checks both types for an op_
9430 which it coudl be used to eliminate two classes: CastToDecimal
9431 and CastFromDecimal.
9433 * convert.cs: Implement the conversions documented in #59800
9435 2006-10-10 Martin Baulig <martin@ximian.com>
9437 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9438 before RootScope.ResolveMembers().
9440 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9441 `CurrentType' if appropriate.
9443 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9445 A fix for bug #78568
9446 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9447 when contains binary operators.
9448 * cs-parser.jay: Updated.
9450 2006-10-09 Martin Baulig <martin@ximian.com>
9453 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9454 moved that into Define() and also do the other type parameter
9455 checks there. Fixes #79094. Added gtest-292.cs.
9458 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9459 since that doesn't include type parameters; don't use `Ldelema'
9460 for type parameters. Fixes #78980. Added gtest-293.cs.
9462 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9465 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9466 conversion is allowed.
9468 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9470 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9471 error reporting when no error occurs.
9473 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9475 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9478 2006-10-06 Raja R Harinath <rharinath@novell.com>
9481 * class.cs (DefineTypeBuilder): Check circular dependencies before
9482 setting the parent of the TypeBuilder.
9483 (CheckRecursiveDefinition): Don't use 'BaseType', since
9484 it may not be valid until after DefineTypeBuilder. Use
9485 'base_type' instead.
9487 2006-10-04 Martin Baulig <martin@ximian.com>
9489 Merged the Anonymous Methods patch.
9491 * anonymous.cs, iterators.cs: The new anonymous methods code.
9493 * statement.cs (Variable): New public abstract class.
9494 (LocalInfo.Variable): New public property.
9495 (LocalInfo.ResolveVariable): New public method.
9496 (Block.Flags): Add `IsIterator'.
9497 (Block.AddVariable): Improved the CS0136 check.
9498 (Block.AnonymousChildren): New public property.
9499 (Block.AddAnonymousChild): New public method.
9500 (ToplevelBlock): Update to use the new anonymous method framework.
9501 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9502 `ToplevelBlock'; this is required to correctly implement the
9504 (Fixed, Using): Use `TemporaryVariable' instead of directly
9505 creating the `LocalBuilder'.
9507 * parameter.cs (Parameter.ResolveVariable): New public method.
9508 (Parameters.ResolveVariable): Likewise.
9510 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9512 * class.cs (TypeContainer): Replaced the `iterators' list and
9513 corresponding methods with a list of `CompilerGeneratedClass'es.
9514 (TypeContainer.ResolveMembers): New public method.
9515 (Method): `IIteratorContainer' has been replaced by
9518 * expression.cs (VariableReference): New public abstract base
9519 class for `LocalVariableReference', `ParameterReference' and
9522 * codegen.cs (EmitContext): Removed `capture_context',
9523 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9524 (EmitContext.EmitThis): Removed.
9526 * cs-parser.jay: Replace `iterator_container' with
9529 2006-10-04 Martin Baulig <martin@ximian.com>
9531 * generic.cs (GenericMethod): Don't make this abstract.
9532 (Constraints.Clone): Added dummy implementation.
9534 2006-10-04 Raja R Harinath <harinath@gmail.com>
9537 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9538 'declspaces'. Avoid allocating arrays willy-nilly.
9541 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9542 cases out of the switch.
9544 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9546 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9547 message when non-generic type is used with the type arguments.
9548 * expression.cs: Updated.
9550 2006-09-28 Raja R Harinath <rharinath@novell.com>
9553 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9554 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9555 Change semantics slightly. Don't insist on having only one
9556 temporary EmptyExpression -- just throttle the creation of new ones.
9559 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9560 non-interfaces too. If no methods are found, don't try to create
9563 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9565 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9568 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9569 us produce better error message.
9571 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9573 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9574 of the `|' operator.
9576 * report.cs: A new warning added.
9578 2006-09-27 Martin Baulig <martin@ximian.com>
9580 * generic.cs (GenericMethod): Don't make this abstract.
9582 2006-09-27 Martin Baulig <martin@ximian.com>
9585 (InternalErrorException): Added overloaded ctor taking a params array.
9587 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9589 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9590 Fixed the cases when same error was reported twice.
9592 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9593 now report symbol information.
9595 2006-09-25 Martin Baulig <martin@ximian.com>
9597 * class.cs: Completely unified with the gmcs version.
9599 2006-09-25 Martin Baulig <martin@ximian.com>
9601 * typemanager.cs (TypeManager.IsNullableType): New public function.
9602 (TypeManager.IsNullableTypeOf): Likewise.
9603 (TypeManager.IsNullableValueType): Likewise.
9605 * class.cs (MethodCore): Added the `GenericMethod' argument from
9606 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9608 2006-09-24 Raja R Harinath <harinath@gmail.com>
9610 * convert.cs: Unify with gmcs version.
9612 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9614 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9615 verify them as well.
9617 * report.cs: New warning.
9619 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9621 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9622 for anonymous block with out argument.
9624 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9626 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9627 not used private events only.
9629 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9631 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9633 * const.cs (Const.Define): Check for constant type.
9634 (Const.IsConstantTypeValid): Looks for valid constant types.
9636 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9638 * ecore.cs (EmptyConstantCast): New common class for all constant based
9641 * expression.cs (Is.DoResolve): Handle null constant especially.
9642 (New.DoResolve): Check for new void().
9643 (MemberAccess.DoResolve): Cope with all kind of nulls.
9645 * literal.cs (NullConstant): Uses EmptyConstantCast.
9646 (NullDefault): Based on EmptyConstantCast.
9647 (NullLiteral): Uses EmptyConstantCast.
9649 * statement.cs (Block.ResolveMeta): Check for constant type.
9651 2006-09-22 Martin Baulig <martin@ximian.com>
9653 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9655 2006-09-22 Raja R Harinath <rharinath@novell.com>
9657 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9661 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9662 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9665 2006-09-22 Martin Baulig <martin@ximian.com>
9667 * ecore.cs: Merged with the gmcs version.
9669 * generic.cs (ConstructedType): New dummy class.
9670 (TypeArguments): Don't make this abstract.
9673 (TypeManager.IsGenericTypeDefinition): New method.
9674 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9676 2006-09-22 Raja R Harinath <rharinath@novell.com>
9678 * expression.cs (ComposedCast): Check for arrays of TypedReference
9679 before creating the type, not after.
9681 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9683 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9684 after ToType change.
9686 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9687 when constant must be implicitly convertible.
9689 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9691 * ecore.cs (NullCast): Derives from NullConstant.
9693 * expression.cs (Is.DoResolve): Removed useless variables.
9694 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9695 (New.Constantify): Add enum support.
9696 (MemberAccess.DoResolve): Add warning when accessing null constant or
9699 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9702 * literal.cs (NullConstant): New abstract class with common
9703 functionality for all null specializations.
9704 (NullDefault): Represents default(X) when result can be
9706 (NullLiteral): Updated.
9708 * report.cs: Add new warning.
9710 2006-09-21 Martin Baulig <martin@ximian.com>
9712 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9714 2006-09-21 Martin Baulig <martin@ximian.com>
9716 * generic.cs (GenericConstraints): New dummy class.
9717 (Constraints): Likewise.
9718 (TypeParameter): Likewise.
9719 (TypeParameterName): Likewise.
9720 (GenericMethod): Likewise.
9722 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9724 * decl.cs: Merged with the gmcs version.
9726 2006-09-21 Raja R Harinath <rharinath@novell.com>
9728 * generic.cs (TypeParameter): Implement IMemberContainer.
9729 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9731 * rootcontext.cs: Unify with gmcs version.
9733 * report.cs: Unify with gmcs version.
9734 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9735 from gmcs/generics.cs.
9736 * generics.cs (TypeParameter): New dummy class.
9738 * support.cs: Unify with gmcs version.
9740 2006-09-20 Raja R Harinath <rharinath@novell.com>
9742 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9743 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9745 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9746 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9747 * mcs.exe.sources: Add generic.cs.
9749 * codegen.cs: Unify with gmcs version.
9751 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9752 (EmitContext): Add GenericDeclContainer implementation.
9753 * decl.cs (MemberCore, DeclSpace): Likewise.
9754 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9756 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9757 MCS TypeManager has a corresponding dummy method.
9759 2006-09-19 Martin Baulig <martin@ximian.com>
9761 * expression.cs: Completely merged with the gmcs version.
9763 2006-09-19 Martin Baulig <martin@ximian.com>
9765 * expression.cs (Invocation): Merged with the gmcs version.
9766 (ArrayAccess.GetStoreOpcode): Likewise.
9768 2006-09-19 Martin Baulig <martin@ximian.com>
9771 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9772 (TypeManager.IsGenericMethodDefinition): Likewise.
9774 2006-09-19 Martin Baulig <martin@ximian.com>
9777 (TypeManager.IsEqual): Moved the gmcs implementation here.
9778 (TypeManager.DropGenericTypeArguments): Likewise.
9779 (TypeManager.DropGenericMethodArguments): Likewise.
9780 (TypeManager.GetTypeArguments): Moved here from gmcs.
9781 (TypeManager.HasGenericArguments): Likewise.
9783 2006-09-19 Martin Baulig <martin@ximian.com>
9785 * expression.cs (Binary): Merged with the gmcs version.
9787 2006-09-19 Martin Baulig <martin@ximian.com>
9789 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9791 2006-09-19 Martin Baulig <martin@ximian.com>
9793 * typemanager.cs: Merged with the gmcs version.
9795 2006-09-16 Raja R Harinath <rharinath@novell.com>
9797 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9798 * driver.cs: Likewise.
9800 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9803 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9804 only if parent type is class.
9805 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9808 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9811 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9813 * typemanager.cs(CSharpName): Converts NullType to null.
9815 2006-09-15 Martin Baulig <martin@ximian.com>
9818 (TypeManager.GetMethodName): Added mcs implementation.
9819 (TypeManager.IsEqual): Likewise.
9822 (SimpleName.RemoveGenericArity): Added dummy implementation.
9824 * pending.cs: Merged with the gmcs version.
9826 2006-09-15 Martin Baulig <martin@ximian.com>
9828 * statement.cs: Merge with the gmcs version.
9830 2006-09-15 Martin Baulig <martin@ximian.com>
9832 * statement.cs (Switch): Merge with the gmcs implementation
9833 (without nullables), which is newer.
9835 2006-09-15 Martin Baulig <martin@ximian.com>
9837 * statement.cs (Block.Variables): Make this public.
9838 (ToplevelBlock.Parameters): Make this a property.
9839 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9841 2006-09-15 Martin Baulig <martin@ximian.com>
9843 * namespace.cs: Merge with the gmcs version.
9845 2006-09-15 Martin Baulig <martin@ximian.com>
9847 * decl.cs (MemberName): Minor code cleanups.
9849 2006-09-15 Martin Baulig <martin@ximian.com>
9851 * parameter.cs: Merge with the gmcs version.
9853 2006-09-15 Martin Baulig <martin@ximian.com>
9855 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9856 and an error in mcs.
9858 2006-09-15 Martin Baulig <martin@ximian.com>
9860 * flowanalysis.cs: Merged from GMCS; added the generics code into
9861 a `GMCS_SOURCE' conditional so we can share this file.
9863 2006-09-08 Martin Baulig <martin@ximian.com>
9865 * typemanager.cs (TypeManager.interlocked_type): New public field.
9866 (TypeManager.int_interlocked_compare-exchange): New public field.
9867 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9868 enumerator types here and call InitGenericCoreTypes().
9869 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9870 after calling InitEnumUnderlyingTypes().
9873 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9874 `classes_second_stage'.
9876 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9878 * assign.cs, ecore.cs, expression.cs: Share error message text.
9879 * class.cs (FieldMember.Define): Check for varible of static type.
9880 * driver.cs (LoadAssembly): Uses error output for errors.
9881 * statement.cs: Updated.
9883 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9885 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9888 2006-09-07 Martin Baulig <martin@ximian.com>
9891 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9893 2006-08-29 Miguel de Icaza <miguel@novell.com>
9895 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9897 2006-08-17 Miguel de Icaza <miguel@novell.com>
9899 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9900 #52019 and #79064, the use of the \uXXXX sequence in source code
9901 to represent unicode characters.
9903 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9905 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9907 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9909 2006-08-13 Miguel de Icaza <miguel@novell.com>
9911 * assign.cs: Catch attempts to assign to a method groups in += and
9914 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9917 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9919 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9921 * class.cs (Method.Define): Issue a warning when generic method looks like
9923 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9926 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9928 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9930 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9931 search all base interfaces as a member can be ambiguous.
9932 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9933 Constructor member type filter.
9934 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9935 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9936 reporting for returned memberinfos.
9937 * report.cs: Updated.
9938 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9939 version to work on all runtimes.
9940 (TypeManager.RealMemberLookup): Removed members filtering.
9942 2006-08-08 Raja R Harinath <rharinath@novell.com>
9944 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9945 (PropertyExpr.EmitAssign): Likewise.
9946 * expression.cs (Indirection.EmitAssign): Likewise.
9947 (LocalVariableReference.EmitAssign): Likewise.
9948 (ParameterReference.EmitAssign): Likewise.
9949 (Invocation.EmitArguments): Likewise.
9950 (ArrayAccess.EmitAssign): Likewise.
9951 (IndexerAccess.EmitAssign): Likewise.
9952 (This.EmitAssign): Likewise.
9953 (ConditionalLogicalOperator.Emit): Likewise.
9956 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9957 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9958 leave it in after returning it.
9959 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9961 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9963 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9966 2006-08-03 Raja R Harinath <rharinath@novell.com>
9968 Fix cs0146-3.cs and cs0146-4.cs.
9969 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9970 enclosing types don't depend on the current type.
9972 2006-08-02 Raja R Harinath <rharinath@novell.com>
9975 * class.cs (TypeContainer.DoDefineMembers): Use
9976 FindBaseMemberWithSameName on Parent, since we're interested in
9977 whether we hide inherited members or not.
9978 (FindBaseMemberWithSameName): Make slightly more robust.
9980 Fix the non-generic testcase from #77396
9981 * decl.cs (DeclSpace.DeclContainer): Remove override.
9983 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9984 declspaces for doppelgangers too.
9985 (UsingEntry): Implement IResolveContext.
9986 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9987 'this' as the resolve context.
9988 (LocalAliasEntry): Likewise.
9990 Implement parts of #77403
9991 * roottypes.cs (RootDeclSpace): New. Used to represent the
9992 toplevel declaration space. Each namespace declaration introduces
9993 a "partial" root declaretion space.
9994 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9995 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9996 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9997 from 'current_namespace.SlaveDeclSpace'.
9998 (namespace_declaration): Likewise.
9999 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10000 check. It can't happen now.
10001 * decl.cs (DeclSpace.LookupType): Likewise.
10002 * driver.cs (MainDriver): Sanity check.
10004 2006-08-01 Raja R Harinath <rharinath@novell.com>
10006 * decl.cs (DeclSpace.FindNestedType): Remove.
10007 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10008 LookupTypeContainer to get the container of the nested type.
10009 * class.cs (TypeContainer.FindNestedType): Make non-override.
10011 2006-07-31 Raja R Harinath <rharinath@novell.com>
10013 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10014 * class.cs (TypeContainer.PartialContainer): ... here.
10015 (TypeContainer.AddBasesForPart): New helper.
10016 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10018 * cs-parser.jay (current_class): Convert to DeclSpace.
10019 (struct_declaration, interface_declaration, class_declaration):
10020 Use AddBasesForPart instead of .Bases directly.
10021 * const.cs, iterators.cs: Update to changes.
10023 2006-07-28 Raja R Harinath <rharinath@novell.com>
10025 * class.cs (TypeContainer.AddMemberType): Rename from
10026 AddToTypeContainer.
10027 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10028 (AddTypeContainer): New. Combine AddClassOrStruct and
10030 (AddPartial): Update. Add 'is_partial' argument.
10031 * roottypes.cs: Update to changes.
10032 * cs-parser.jay (push_current_class): New helper for handling
10033 current_container and current_class.
10034 (struct_declaration, interface_declaration, class_declaration):
10037 2006-07-26 Raja R Harinath <rharinath@novell.com>
10039 * roottypes.cs: Rename from tree.cs.
10041 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10042 * tree.cs (Tree, ITreeDump): Remove types.
10043 * rootcontext.cs (tree, Tree): Remove fields.
10044 (root, ToplevelTypes): New.
10045 * *.cs: Update to rename.
10047 * tree.cs (Tree.RecordDecl): Remove.
10048 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10050 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10052 2006-07-23 Raja R Harinath <harinath@gmail.com>
10054 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10055 DoFlowAnalysis and OmitStructFlowAnalysis here.
10056 (ec.With): Rename from WithUnsafe and generalize.
10057 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10058 (ec.WithFlowAnalyis): New.
10059 * ecore.cs, expression.cs, statement.cs: Update.
10061 2006-07-22 Raja R Harinath <harinath@gmail.com>
10063 * statement.cs (Block.ResolveMeta): Simplify slightly.
10065 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10066 multiple boolean fields. Convert InUnsafe, constant_check_state,
10067 check_state to flags.
10068 (CheckState, ConstantCheckState): Update.
10069 (InUnsafe): New read-only property.
10070 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10072 (WithUnsafe): New helper similar to WithCheckState.
10073 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10074 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10076 2006-07-21 Raja R Harinath <rharinath@novell.com>
10078 Make comparisons use the same IL irrespective of whether they're
10079 in a 'checked' or 'unchecked' context: one of the issues in #78899
10080 * codegen.cs (EmitContext.CheckState): Make read-only property.
10081 (EmitContext.ConstantCheckState): Likewise.
10082 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10083 helper that implement a save/restore stack for CheckState
10084 values. This is the only way to change check-state.
10085 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10086 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10087 (CheckedExpr.EmitBranchable): New forwarding method.
10088 (UnCheckedExpr): Likewise.
10089 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10090 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10091 (Checked.Resolve, checked.DoEmit): Likewise.
10093 2006-07-20 Miguel de Icaza <miguel@novell.com>
10095 * anonymous.cs: Cache the resolved anonymous delegate, and return
10096 this so that the ResolveTopBlock is only triggered once, not
10099 Currently we trigger ResolvetopBlock twice due to a first pass of
10100 argument check compatibility, and a second pass that does the
10103 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10105 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10107 * rootcontext.cs (Reset): Add helper_classes.
10109 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10112 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10115 2006-07-13 Miguel de Icaza <miguel@novell.com>
10117 * statement.cs (Lock): Handle expressions of type
10118 TypeManager.null_type specially. Fixes #78770
10120 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10122 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10125 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10127 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10128 for accessors as well.
10129 * ecore.cs (EventExpr): Add AccessorTable.
10131 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10134 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10135 for CS0122 where appropriate.
10136 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10138 (Filter): Assembly can be null in the case of top level attributes.
10140 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10144 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10145 is done at global level.
10147 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10149 A fix for #77002, Implemented TypeForwarder support.
10151 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10152 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10153 * typemanager.cs (): Add type_forwarder_attr_type.
10155 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10157 * report.cs: Add CS0469 warning.
10159 2006-06-21 Martin Baulig <martin@ximian.com>
10161 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10162 the `try'-block, so we also report CS0016 etc. there.
10164 2006-06-21 Martin Baulig <martin@ximian.com>
10167 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10169 2006-06-21 Martin Baulig <martin@ximian.com>
10171 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10172 also report CS1686 for parameters.
10174 2006-06-21 Martin Baulig <martin@ximian.com>
10176 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10177 instead of an error if the value is not implicitly convertible to
10178 the switch types; fixes #77964.
10180 2006-06-21 Raja R Harinath <rharinath@novell.com>
10183 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10184 FieldBuilder is null.
10187 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10188 'left' and 'right' before error-checking.
10190 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10192 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10194 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10195 (FieldExpr.DoResolve): likewise.
10196 (PropertyExpr.InstanceResolve): likewise.
10197 (EventExpr.InstanceResolve): likewise.
10199 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10201 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10202 attribute applicable tests for attribute argument.
10204 2006-06-02 Raja R Harinath <rharinath@novell.com>
10207 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10208 (Binary.OverloadResolve_PredefinedIntegral): New.
10209 (Binary.OverloadResolve_PredefinedFloating): New.
10210 (Binary.OverloadResolve_PredefinedString): New.
10211 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10212 Follow the standard more closely, and treat numeric promotions in
10213 terms of overload resolution.
10214 (Binary.CheckShiftArguments): Simplify.
10216 2006-06-01 Raja R Harinath <rharinath@novell.com>
10218 * flowanalysis.cs (MyBitVector): Simplify representation.
10219 (MyBitVector.Clone): Avoid allocating BitArray.
10220 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10221 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10222 (*): Update. Change all references to MyBitVector.And and
10223 MyBitVector.Or to &= and |=.
10225 2006-05-29 Raja R Harinath <rharinath@novell.com>
10227 Fix cs0231-[34].cs.
10228 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10229 to param arguments too.
10231 2006-05-26 Miguel de Icaza <miguel@novell.com>
10233 * cs-parser.jay: Catch another parsing form for arglist being
10234 followed by other arguments. Fixes #78313.
10236 2006-05-24 Raja R Harinath <rharinath@novell.com>
10238 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10239 checking of out parameters to ...
10240 (FlowBranchingToplevel.Merge): ... here.
10241 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10242 set, propagate the origin upward, and only complain if there was
10244 (FlowBranchingException.AddContinueOrigin): Likewise.
10245 (FlowBranchingException.AddReturnOrigin): Likewise.
10246 (FlowBranchingException.AddGotoOrigin): Likewise.
10248 2006-05-23 Raja R Harinath <rharinath@novell.com>
10250 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10251 unreachable, skip it.
10252 (FlowBranchingException.Merge): Always propagate jumps, even if
10253 the finally block renders subsequent code unreachable.
10255 2006-05-18 Raja R Harinath <rharinath@novell.com>
10258 * statement.cs (Goto.Resolve): Move responsibility for resolving
10259 'goto' to FlowBranching.AddGotoOrigin.
10260 (Goto.SetResolvedTarget): New. Callback to set the
10261 LabeledStatement that's the target of the goto.
10262 (Goto.DoEmit): Use Leave instead of Br when crossing an
10263 unwind-protect boundary.
10264 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10265 LookupLabel and adjust to new semantics.
10266 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10267 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10268 Goto.SetResolvedTarget to update target.
10269 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10270 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10271 AddBreakOrigin & co. Delay propagation until ...
10272 (FlowBranchingException.Merge): ... this.
10274 * statement.cs (Block.Resolve): Always depend on flow-branching to
10275 determine unreachability. Kill workaround that originally emitted
10276 only one statement after an "unreachable" label (see infloop in
10279 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10280 This is still "wrong", but anything better would probably need a
10281 multi-pass algorithm.
10282 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10283 usage vector. Force current usage vector to be reachable, to
10284 optimistically signify backward jumps.
10285 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10287 (FlowBranchingLabeled.Merge): New. If no backward jump was
10288 detected, return the original salted-away usage vector instead,
10289 updated with appropriate changes. Print unreachable warning if
10291 * statement.cs (Block.Resolve): Don't print unreachable warning on
10292 a labeled statement.
10294 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10296 * driver.cs: Pass filename without path to AssemblyBuilder's
10297 AddResourceFile. Fixes bug #78407.
10299 2006-05-17 Raja R Harinath <rharinath@novell.com>
10301 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10302 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10303 (FlowBranching.MergeChild): Overwrite
10304 reachability information from Labeled branchings too.
10306 2006-05-16 Raja R Harinath <rharinath@novell.com>
10308 * statement.cs (Goto.Resolve): Merge jump origins here ...
10309 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10311 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10312 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10313 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10314 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10316 * statement.cs (Goto.Resolve): ... not here.
10317 (Goto.Emit): Remove CS1632 check.
10319 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10321 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10324 2006-05-11 Raja R Harinath <rharinath@novell.com>
10326 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10327 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10328 (FlowBranchingException.Label): Likewise.
10330 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10332 (MyBitVector.Or): Use it to avoid losing information (Count).
10333 (FlowBranching.MergeOrigins): Likewise.
10335 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10336 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10337 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10338 (UsageVector.ToString): Simplify.
10339 (UsageVector.MergeSiblings): Move here from ...
10340 (FlowBranching.Merge): ... here.
10341 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10344 2006-05-10 Raja R Harinath <rharinath@novell.com>
10346 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10347 null bitvector is treated as all-true.
10349 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10350 (MyBitVector): Rationalize invariants. 'vector != null' implies
10351 that we have our own copy of the bitvector. Otherwise,
10352 'InheritsFrom == null' implies all inherited bits are true.
10354 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10356 * statement.cs (LocalInfo): Add IsConstant.
10357 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10358 local variable for constants.
10360 2006-05-09 Raja R Harinath <rharinath@novell.com>
10362 * flowanalysis.cs (MyBitVector.Empty): New.
10363 (MyBitVector): Don't allow InheritedFrom to be null.
10364 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10365 (UsageVector, FlowBranching): Update to changes.
10367 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10368 recursion. The 'Parent == null' condition isn't sufficient for
10370 (FlowBranching.AddBreakOrigin): Likewise.
10371 (FlowBranching.AddContinueOrigin): Likewise.
10372 (FlowBranching.AddReturnOrigin): Likewise.
10373 (FlowBranching.StealFinallyClauses): Likewise.
10374 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10375 (FlowBranching.CheckOutParameters): Likewise.
10376 (FlowBranchingToplevel): Terminate all the above recursions here.
10377 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10378 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10380 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10382 (FlowBranchingToplevel): New. Empty for now.
10383 (FlowBranching.MergeTopBlock): Update.
10384 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10385 branching for the anonymous delegate.
10386 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10388 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10389 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10390 information at the start of the merge. Reorganize.
10392 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10394 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10396 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10398 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10399 to newly introduced ctor.
10401 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10402 message to one place.
10403 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10406 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10408 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10410 * ecore.cs (Expression.ResolveAsConstant): Updated.
10412 * statement.cs (ResolveMeta): Updated.
10414 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10416 * cs-parser.jay: __arglist cannot be used in initializer.
10418 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10421 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10424 2006-05-05 Raja R Harinath <rharinath@novell.com>
10426 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10427 (LabeledStatement): Add 'name' parameter.
10428 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10429 (Block.AddLabel): Update to changes.
10430 * cs-parser.jay (labeled_statement): Likewise.
10432 * flowanalysis.cs (BranchingType.Labeled): New.
10433 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10434 (FlowBranchingLabeled): New. Does nothing for now, but will
10435 eventually handle 'goto' flows.
10436 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10437 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10438 that's terminated ...
10439 (Block.Resolve): ... here.
10441 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10442 (UsageVector.MergeFinallyOrigins): Likewise.
10443 (FlowBranching.InTryOrCatch): Likewise.
10444 (FlowBranching.AddFinallyVector): Likewise.
10445 (FlowBranchingException): Update to changes.
10448 * statement.cs (Return.Resolve): Move error checking to ...
10449 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10450 (FlowBranchingException): Handle return origins like break and
10452 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10454 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10457 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10460 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10463 * class.cs (MethodData.Define): Do public accessor check only when method
10464 implements an interface.
10466 2006-05-04 Raja R Harinath <rharinath@novell.com>
10468 Remove special handling of 'break'
10469 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10470 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10471 (UsageVector.Break): Remove.
10472 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10474 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10476 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10477 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10479 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10482 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10483 be the interface member.
10485 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10488 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10489 for emitting small (int) values.
10491 2006-05-03 Raja R Harinath <rharinath@novell.com>
10494 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10495 control-flow passes through the 'finally' after merging-in all the
10496 control-flows from 'try' and the 'catch' clauses.
10498 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10499 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10500 always true at the only non-recursive entry point.
10501 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10502 FlowBranchingBreakable.
10503 (FlowBranchingLoop): Remove.
10504 * statement.cs (Return.DoResolve): Update to changes.
10507 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10508 (FlowBranching.CreateBranching): Handle it: create a
10509 FlowBranchingContinuable.
10510 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10511 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10512 except that it handles the 'continue' command.
10513 (FlowBranching.UsageVector.MergeOrigins): Rename from
10515 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10516 except that it overrides AddContinueOrigin.
10517 (FlowBranchingException): Override AddContinueOrigin, similar to
10519 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10520 Create a new branching around the embedded statement.
10521 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10522 control flow after the embedded statement.
10523 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10525 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10526 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10527 FlowBranchingBreakable.
10528 (FlowBranchingSwitch): Remove.
10531 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10532 error reporting to ...
10533 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10534 Rename from 'AddBreakVector'. Add new location argument. Return
10535 a bool indicating whether the 'break' crosses an unwind-protect.
10536 (FlowBranchingException.AddBreakOrigin): Add.
10537 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10538 flowbranching after updating with the effects of the 'finally'
10540 (FlowBranchingBreakable): New common base class for
10541 FlowBranchingLoop and FlowBranchingSwitch.
10543 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10544 embedded statement.
10545 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10547 2006-05-02 Raja R Harinath <rharinath@novell.com>
10549 * statement.cs (Do.Resolve): If the loop is infinite, set the
10551 (While.Resolve, For.Resolve): Set a barrier after the embedded
10552 statement. There's no direct control flow that goes from the end
10553 of the embedded statement to the end of the loop.
10554 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10555 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10556 above ensure that the reachability is correctly computed.
10558 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10559 (UsageVector.MergeBreakOrigins): If the current path is
10560 unreachable, treat it as if all parameters/locals are initialized.
10561 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10562 infinite loops before merging-in break origins.
10564 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10565 (Reachability.Reachable): Split part into ...
10566 (Reachability.Unreachable): ... this. Simplify.
10567 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10569 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10570 (Reachability.SetThrowsSometimes): Likewise.
10571 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10572 TriState.Always, use corresponding property.
10573 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10574 (Block.Resolve): Likewise. Remove some redundant checks.
10576 2006-05-02 Raja R Harinath <harinath@gmail.com>
10578 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10579 (Reachability.Meet): Don't bother checking AlwaysThrows --
10580 barrier is always set.
10581 (FlowBranchingBlock.Merge): Likewise.
10583 2006-05-01 Raja R Harinath <harinath@gmail.com>
10585 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10586 checks for unreachable.
10588 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10591 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10593 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10594 whether field is really assigned.
10596 2006-04-30 Raja R Harinath <harinath@gmail.com>
10598 * flowanalysis.cs (Reachability): Make 4-argument constructor
10600 (Reachability.Meet): Rename from 'And'. Remove static variant.
10601 (Reachability.Always): Rename from the highly misleading
10602 'Reachability.Never'.
10603 (FlowBranching.Merge): Update to changes. Mark an impossible
10604 situation with a 'throw'.
10605 (*): Update to changes.
10607 2006-04-29 Raja R Harinath <harinath@gmail.com>
10609 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10610 Remove 'Undefined'.
10611 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10612 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10613 (*): Update to changes.
10614 * statement.cs: Update to changes.
10616 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10619 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10621 2006-04-28 Raja R Harinath <harinath@gmail.com>
10623 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10626 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10627 argument to two arguments: an usage-vector and a bool. Move call
10628 to FlowBranching.Merge () ...
10629 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10631 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10632 handling of loop and switch reachability to ...
10633 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10635 2006-04-27 Raja R Harinath <harinath@gmail.com>
10637 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10638 handling to FlowBranchingLoop.InLoop.
10639 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10641 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10644 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10645 anonymous method is allowed from AnonymousContainer here.
10647 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10649 2006-04-24 Raja R Harinath <rharinath@novell.com>
10652 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10654 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10657 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10658 (DoubleConstant.Reduce): Ditto.
10660 2006-04-23 Raja R Harinath <rharinath@novell.com>
10662 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10663 Remove 'lvalue_right_side' argument. Move parts to ...
10664 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10665 (LocalVariable.DoResolveLValue): ... these.
10667 2006-04-21 Raja R Harinath <rharinath@novell.com>
10670 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10671 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10672 (LocalVariableReference.DoResolveBase): Use it to implement new
10674 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10675 (Argument.Resolve): Simplify. Move CS1510 check ...
10676 * ecore.cs (Expression.ResolveLValue): ... here.
10677 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10678 (PropertyExpr.DoResolveLValue): Likewise.
10679 (FieldExpr.Report_AssignToReadonly): Likewise.
10680 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10681 LValueMemberAccess or LValueMemberOutAccess on instance depending
10683 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10684 DoResolve as appropriate.
10686 2006-04-20 Raja R Harinath <rharinath@novell.com>
10689 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10690 implicit conversions on 'out' and 'ref' arguments.
10692 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10693 improve clarity. Remove dead code.
10696 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10697 (Catch.Resolve): Resolve VarBlock if it exists.
10699 2006-04-19 Miguel de Icaza <miguel@novell.com>
10701 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10702 twice, this was some residual code, the enumerator was emitted
10703 properly in the two branche of if later.
10705 2006-04-19 Raja R Harinath <rharinath@novell.com>
10707 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10708 cast is never an lvalue.
10709 (Cast.DoResolve, Cast.ResolveRest): Combine.
10710 (Argument.Emit): Simplify slightly. Move 'Expr is
10711 IMemoryLocation' check ...
10712 (Argument.Resolve): ... here.
10713 (Argument.Error_LValueRequired): Remove. Inline into only user.
10715 Simplifications. Fix cs0191-2.cs
10716 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10717 CS1649 and CS1651 to ...
10718 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10719 the actual selection of the error code and message to a lookup
10720 table. Add a dummy return value to simplify callsites.
10721 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10722 readonly fields of other instances of the same type. Move CS0197
10724 * expression.cs (Argument.Resolve): ... here. Simplify code.
10725 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10726 resolution of an out or ref argument. The code simplification
10727 above uses this invariant.
10729 2006-04-18 Raja R Harinath <rharinath@novell.com>
10731 Possibly fix #77752. Fix cs1690-[4-7].cs.
10732 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10733 CheckMarshallByRefAccess. Drop parameter.
10734 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10736 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10737 InstanceExpression.
10738 * report.cs (AllWarnings): Add CS1690.
10739 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10740 for ref access too.
10741 (LocalVariableReference.DoResolveBase): Update.
10743 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10745 * class.cs (MethodOrOperator): Moved common parts from method class.
10746 detect obsolete attributes.
10747 (Method.Define): Simplified as it reuses code from base.
10748 (Constructor.ValidAttributeTargets): Fixed issue found during
10750 (Destructor.ValidAttributeTargets): Fixed issue found during
10752 (Operator): Finished refactoring set off by #78020. Operator class is now
10753 ordinary method class.
10755 * anonymous.cs: Updated.
10757 * decl.cs (DeclSpace): Add IsGeneric
10759 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10761 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10763 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10765 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10766 detect obsolete attributes.
10767 (Method.CreateEmitContext): Moved to MethodOrOperator.
10769 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10772 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10773 customized exception to make crash detection easier.
10774 (MethodOrOperator): Started to work on new base class for methods and
10776 (Method): Derives from MethodOrOperator.
10777 (Constructor.Emit): Emits its own attributes.
10778 (AbstractPropertyEventMethod.Emit): Ditto.
10779 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10781 (Operator.Emit): It's temporary more tricky than should be.
10783 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10785 * report.cs (InternalErrorException): Add ctor with inner exception.
10787 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10790 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10793 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10796 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10799 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10801 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10802 attribute is present and Guid not.
10803 (Interface.ApplyAttributeBuilder): Ditto.
10805 * attribute.cs: Add error message.
10807 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10811 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10812 sources (it's composite) so hold them in extra array as they are used in
10813 Emit phase only. It worked in the previous versions by mistake.
10814 (Attribute.Emit): Emit attribute for more owners when exist.
10816 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10817 it has now different behaviour.
10819 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10821 * constant.cs (Constant.IsDefaultInitializer): New method.
10823 * class.cs: Updated.
10825 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10826 re-initialize default values. It saves KBs almost for every assembly.
10827 Thanks Zoltan for the idea.
10828 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10829 (ArrayCreation.DoResolve): Resolve only once.
10830 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10831 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10833 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10835 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10838 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10840 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10841 in an embedded statement too.
10843 2006-04-01 Raja R Harinath <rharinath@novell.com>
10846 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10848 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10852 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10855 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10857 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10859 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10862 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10863 LocalTemporary change.
10865 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10867 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10868 initializers optimization.
10869 (ClassOrStruct.TypeAttr): Moved from modifiers.
10870 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10871 (FieldBase.ResolveInitializer): Resolves initializer.
10872 (FieldBase.HasDefaultInitializer): New property.
10874 * cs-parser.jay: Removed message.
10876 * expression.cs (CompilerGeneratedThis): New specialization.
10878 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10880 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10882 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10884 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10886 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10887 be now EnumConstants only.
10889 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10891 * attribute.cs, driver.cs: Reset more caches.
10893 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10895 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10897 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10899 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10900 for easier reuse. Updated all overrides.
10901 (IntegralConstant): New base class for all integral constants.
10902 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10903 of the constant range, report custom error.
10904 (UIntConstant.Reduce): Fixed uint conversion.
10906 * ecore.cs, literal.cs: Reduce updates.
10908 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10912 * class.cs (Constructor.Define): Removed extra if for default ctors.
10913 A patch from Atsushi Enomoto.
10915 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10917 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10918 GetAttributableValue.
10920 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10923 * convert.cs (ImplicitConversionRequired): Error message moved to
10926 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10927 automatic implicit conversion of an output value.
10928 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10930 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10932 (TypeOf.GetAttributableValue): Add extra handling for object type.
10934 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10935 special error message.
10937 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10939 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10941 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10942 compatible with MS runtime.
10944 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10946 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10947 attribute arguments here.
10949 * class.cs (Indexer.Define): The check was moved to attribute class.
10951 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10953 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10954 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10957 2006-03-22 Raja R Harinath <rharinath@novell.com>
10959 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10960 mcs to keep code differences small.
10961 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10962 * typemanager.cs (parameter_default_value_attribute_type): New.
10963 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10966 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10968 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10970 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10972 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10974 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10977 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10979 * doc-bootstrap.cs : fix build.
10981 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10983 * expression.cs (StringConcat.Append): Issue a warning when empty string
10984 is going to append.
10986 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10988 * assign.cs (CompoundAssign.ResolveSource): Removed.
10990 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10993 * class.cs (TypeContainer.FindMethods): Removed.
10994 (TypeContainer.CheckMemberUsage): Made static.
10996 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10998 * constant.cs (CheckRange): Removed unused type argument.
10999 (CheckUnsigned): Removed unused type argument.
11001 * cs-parser.jay: Updated after MemberAccess clean up.
11002 Uses Length for empty string test.
11004 * cs-tokenizer.cs: Uses Length for empty string test.
11005 (IsCastToken): Made static.
11006 (is_hex): Made static.
11007 (real_type_suffix): Made static.
11009 * decl.cs (SetupCache): Made static.
11010 (OnGenerateDocComment): Removed unused ds argument.
11012 * delegate.cs (VerifyDelegate): Removed unused argument.
11014 * doc.cs: Uses Length for empty string test.
11016 * driver.cs: Uses Length for empty string test.
11018 * enum.cs (IsValidEnumType): Made static
11020 * expression.cs (EnumLiftUp): Removed unused argument.
11021 (ResolveMethodGroup): Ditto.
11022 (BetterConversion): Ditto.
11023 (GetVarargsTypes): Ditto.
11024 (UpdateIndices): Ditto.
11025 (ValidateInitializers): Ditto.
11026 (MemberAccess.ctor): Ditto.
11027 (GetIndexersForType): Ditto.
11029 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11031 * iterators.cs: Updated after MemberAccess clean up.
11033 * location.cs: Uses Length for empty string test.
11035 * namespace.cs: Uses Length for empty string test.
11037 * report.cs (CheckWarningCode): Made static.
11039 * statement.cs (LabeledStatement): Removed unused argument.
11041 * typemanager.cs (FilterNone): Removed.
11043 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11045 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11048 * class.cs: Updated.
11050 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11052 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11054 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11058 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11059 reporting, it's more tricky than I thought.
11061 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11065 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11067 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11068 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11069 Add more error reporting; Fixed issue with params.
11071 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11073 * cs-parser.jay: AnonymousMethod requires host container.
11075 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11077 2006-03-18 Raja R Harinath <harinath@gmail.com>
11079 * class.cs: Change 'TypeContainer ds' constructor argument to
11080 'DeclSpace parent'. Some classes were missed below due to
11081 different naming convention.
11083 * class.cs (MemberCore.Parent): Delete. This makes the
11084 ParentContainer changes below enforceable by the compiler.
11086 Treat pointers to enclosing declaration space as 'DeclSpace', not
11088 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11089 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11091 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11093 (Block.AddThisVariable): Likewise.
11094 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11095 (AbstractPropertyEventMethod.Emit): Likewise.
11096 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11097 (GetMethod.Define, SetMethod.Define): Likewise.
11098 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11099 (DelegateMethod.EmitMethod): Likewise.
11101 Fix regression test-partial-13.cs.
11102 Rationalize use of PartialContainer. Ensure that the partial
11103 class semantics can be tied to type-correctness, i.e., any
11104 violation will cause a compile error.
11105 * class.cs, const.cs: Access all fields that belong to class
11106 TypeContainer via ParentContainer. Arguments of EmitContexts and
11107 Resolve()-like functions still use 'Parent'.
11109 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11110 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11111 (PropertyMethod.CheckModifiers): Remove unused argument.
11112 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11115 2006-03-17 Raja R Harinath <harinath@gmail.com>
11117 Make semantics of PartialContainer simpler.
11118 * decl.cs (DeclSpace.IsPartial): Remove.
11119 * class.cs (TypeContainer.IsPartial): Likewise.
11120 (TypeContainer..ctor): Set PartialContainer to point to self.
11121 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11122 (TypeContainer.FindNestedType): Likewise.
11123 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11125 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11127 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11129 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11131 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11134 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11136 * class.cs (Operator.Define): An error for base conversion was not
11137 reported correctly.
11139 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11141 * iterator.cs : yield break is allowed in try statement which has
11142 catch clauses. Fixed bug #77767.
11144 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11146 A fix for #77593, #77574.
11148 * class.cs (MethodCore.CheckBase): Another if for operator.
11150 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11152 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11155 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11156 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11159 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11162 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11163 Updated after another emitcontext usage was clean up. It should help us to
11164 synchronize with gmcs easier.
11166 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11170 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11171 (Event.Define): ditto
11172 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11174 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11175 Removed redundant code and set NewSlot for Invoke method too.
11177 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11178 (Parameters.MergeGenerated): New method. Use this method when you merge
11179 compiler generated argument with user arguments.
11181 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11183 * attribute.cs (ResolveAsTypeTerminal): Removed.
11185 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11186 specialization for predefined types; 30% speed up.
11187 Finally placed obsolete check to right place.
11188 (Expression.ResolveType): Removed.
11190 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11191 Updated after ResolveType was removed.
11193 * expression.cs (Cast.ctor): Check void cast.
11194 (Binary.ResolveAsTypeTerminal): Is never type.
11195 (Conditional.ResolveAsTypeTerminal): Is never type.
11197 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11199 2006-03-01 Raja R Harinath <rharinath@novell.com>
11202 * expression.cs (ParameterReference.DoResolveBase): Change return
11204 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11208 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11211 * typemanager.cs (GetFullNameSignature): Don't nullref on
11212 protected accessors.
11214 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11216 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11217 these two separated members to simplify the code.
11218 (Attribute.Resolve): Refactored to use new fields and methods.
11219 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11220 implemented obsolete attribute checking.
11221 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11222 implemented obsolete checking again. It look line never ending quest ;-)
11223 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11225 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11227 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11229 *class.cs (Property.Define): Add RegisterProperty call.
11231 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11232 argument groups (only 2).
11234 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11235 encoding expression to arguments.
11236 (Expression.ExprClassToResolveFlags): Just turned to property.
11238 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11239 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11240 optimized as well as implemented support for zero-length attributes.
11242 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11243 Add caching of PropertyInfo's.
11245 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11247 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11248 error multiple times.
11250 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11252 New partial class implementation.
11253 A fix for #77027, #77029, #77403
11255 * attribute.cs (Attributable): Made attributes protected.
11257 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11258 the replacements of ClassPart and PartialContainer.
11259 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11260 (TypeContainer.AddInterface): Ditto.
11261 (TypeContainer.AddPartial): The main method for partial classes. It checks
11262 for errors and merges ModFlags and attributes. At the end class is added to
11263 partial_parts list.
11264 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11266 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11267 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11268 from the rest of partial classes.
11269 (TypeContainer.GetClassBases): Simplified.
11270 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11272 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11273 (TypeContainer.HasExplicitLayout): Uses Flags now.
11274 (PartialContainer): Removed.
11275 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11276 (StaticClass): Was merged with Class.
11277 (Class.GetClassBases): class and static class bases are verified here.
11278 (Class.TypeAttr): Added static attributes when class is static.
11279 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11280 (MemberBase): In some cases we need to call parent container for partial
11281 class. It should be eliminated but it's not easy now.
11283 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11285 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11286 partial classed to accumulate class comments.
11287 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11289 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11291 * driver.cs (MainDriver): Tree.GetDecl was removed.
11293 * modifiers.cs (Modifiers): Add partial modifier.
11295 * tree.cs (Tree.decl): Removed.
11296 (RootTypes): Started to use this class more often for root types
11299 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11303 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11304 external interface does not have an attribute.
11306 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11308 Another prerequisites for new partial classs implementation.
11310 * attribute.cs (Attribute.Equal): Implemented.
11311 (Attribute.Emit): Changed as attributes can be applied more than twice.
11312 (Attributes.Emit): Check for duplicate attributes here.
11314 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11315 as a parameter, clean-up.
11317 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11321 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11322 contains obsolete attribute check which can in some cases look for base
11323 type of current class which is not initialized yet.
11324 (TypeContainer.BaseType): Replacement of ptype.
11326 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11328 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11330 First of prerequisites for new partial classs implemention.
11332 * attribute.cs (Attributable): Extended by ResolveContext;
11333 Attributes finally have correct context for resolving in all cases.
11334 (AttachTo): Attribute owner is assigned here.
11336 * codegen.cs (IResolveContext): Introduce new interface to hold
11337 all information needed in resolving phase.
11338 (EmitContext): Implements IResolveContext; more clean-up needed here.
11340 * decl.cs (MemberCore): Implemented IResolveContext.
11342 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11343 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11344 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11345 Refactored to use new IResolveContext instead of EmitContext; cleanup
11347 2006-02-06 Miguel de Icaza <miguel@novell.com>
11349 * codegen.cs (EmitScopeInitFromBlock): check here the
11350 capture_context, there is no need to make two calls to the
11353 * anonymous.cs: Add some debugging messages that might help me
11354 track other instances of this problem in the future (the
11355 regression of test 467).
11357 * cs-parser.jay: track the variable block, as we need to initalize
11358 any captured variables declared in this block for the "catch"
11359 portion of the "Try" statement.
11361 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11362 scope initialization for captured variables.
11364 Also, move the emit for the variables after the block location has
11367 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11369 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11371 2006-02-02 Miguel de Icaza <miguel@novell.com>
11373 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11374 commit yesterday, the initialization for the roots is necessary.
11375 What is not necessary is the scope activation.
11377 2006-02-02 Raja R Harinath <rharinath@novell.com>
11379 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11380 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11382 (Argument.Resolve): Remove CS0206 checks.
11384 2006-02-01 Miguel de Icaza <miguel@novell.com>
11386 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11387 scopes for all the roots, the scopes will now be emitted when the
11388 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11390 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11391 code. This reduces a lot of existing cruft.
11393 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11394 that the ScopeInfo is generated as we enter the scope, not at the
11395 time of use, which is what we used to do before.
11397 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11398 every time a Block is about to be emitted if we have a
11401 2006-02-01 Raja R Harinath <rharinath@novell.com>
11403 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11405 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11407 * typemanager.cs (cons_param_array_attribute): Make private.
11408 (Reset): Set it to null.
11409 (InitCoreHelpers): Don't initialize it.
11410 (ConsParamArrayAttribute): New. Initialize it as needed.
11411 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11413 2006-01-31 Miguel de Icaza <miguel@novell.com>
11415 * expression.cs: There might be errors reported during the
11416 selection of applicable methods. If there are errors, do not
11417 continue execution as it will lead the compiler to crash.
11419 2006-01-30 Miguel de Icaza <miguel@novell.com>
11421 * expression.cs: Member access is not allowed on anonymous
11422 methods. Fixes #77402.
11424 2006-01-30 Raja R Harinath <rharinath@novell.com>
11427 * cs-parser.jay (VariableDeclaration): Don't set
11428 current_array_type to null.
11429 (field_declaration, event_declaration, declaration_statement):
11430 Set it to null here.
11432 2006-01-28 Raja R Harinath <harinath@gmail.com>
11434 * typemanager.cs (GenericParameterPosition): New.
11437 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11439 * doc.cs : To process "include" elements, first we should create
11440 another list than XmlNodeList, because it could result in node
11441 removal, which could result in that the XmlNodeList gives up
11442 yielding next node.
11444 (Also made code identical to gmcs again.)
11446 2006-01-25 Miguel de Icaza <miguel@novell.com>
11448 * ecore.cs: Introduce an error report that we were not catching
11449 before, if not silent, we must report the error. Gonzalo ran into
11452 2006-01-23 Miguel de Icaza <miguel@novell.com>
11454 A fix for bug: #76957
11456 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11457 ComputeMethodHost before creating the method, this is a new
11460 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11461 that this method references (RegisterScope). The actual scope
11462 where the method is hosted is computed with the ComputeMethodHost
11463 before we create the method.
11465 Moved the Deepest routine here.
11467 (AnonymousContainer.ComputeMethodHost): New routine used to
11468 compute the proper ScopeInfo that will host the anonymous method.
11470 (ScopeInfo): Deal with multiple roots. The problem was that we
11471 did not have a unique root where all ScopeInfos could be hanged
11472 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11475 Remove AdjustMethodScope which is now computed at the end. Remove
11476 LinkScope which did a partial link, instead link all ScopeInfos
11477 before code generation from the new "LinkScopes" routine.
11479 Simplify all the Add* routines as they no longer need to maintain
11480 the tree, they just need to record that they are using variables
11483 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11484 routines to produce the forest of ScopeInfo trees.
11486 * class.cs (TypeContainer.AppendMethod): This is just like
11487 AddMethod, but ensures that an interface implementation method
11488 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11489 methods, but at the end.
11491 We use this functionality to ensure that the generated MoveNext
11492 method in the iterator class is resolved/emitted before the
11493 enumerator methods created.
11495 This is required because the MoveNext method computes the right
11496 ScopeInfo for the method. And the other methods will eventually
11497 need to resolve and fetch information computed from the anonymous
11500 2006-01-21 Raja R Harinath <harinath@gmail.com>
11501 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11503 Fix rest of #76995.
11504 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11505 the 'aliases' hash.
11506 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11507 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11509 2006-01-18 Raja R Harinath <rharinath@novell.com>
11511 Fix #76656, cs0231-2.cs.
11512 * cs-parser.jay (formal_parameter_list): Make error case catch
11514 (parenthesized_expression_0): Add CS1026 check.
11515 (invocation_expression): Remove unused { $$ = lexer.Location }.
11517 2006-01-17 Raja R Harinath <rharinath@novell.com>
11520 * cs-parser.jay (statement_expression): Don't list out the
11521 individual statement-expressions. Convert syntax error into
11524 2006-01-16 Raja R Harinath <rharinath@novell.com>
11527 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11528 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11529 CheckIntermediateModification.
11530 (FieldExpr.DoResolve): Add new two-argument version that
11531 allows us to resolve the InstanceExpression as an lvalue.
11532 The one-argument variant is now just a wrapper.
11533 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11534 Resolve the lhs as an lvalue if the it has a value type.
11535 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11536 from Assign.DoResolve.
11537 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11538 resolved as an lvalue.
11539 (PropertyExpr.DoResolve): Update.
11540 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11541 has a value type. Move CS1612 check here from
11542 CheckIntermediateModification.
11543 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11544 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11545 'right_side' of a ResolveLValue on an 'out' argument.
11546 (EmptyExpression.LValueMemberAccess): New. Used as the
11547 'right_side' of a propagated ResolveLValue on a value type.
11548 (LocalVariableReference.DoResolveBase): Recognize
11549 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11551 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11552 EmptyExpression.Null.
11554 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11556 * typemanager.cs : added IsGenericParameter(). In mcs it always
11558 * doc.cs : for generic parameters, use GenericParameterPosition,
11561 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11563 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11565 2006-01-12 Miguel de Icaza <miguel@novell.com>
11567 This fixes the problem where we used ldfld instead of ldflda to
11568 load the "THIS" pointer on captured parameters, when THIS is a
11569 value type. See bug #77205.
11571 * iterators.cs (CapturedThisReference.Emit): Pass false to
11572 EmitThis (we do not need the address).
11574 * codegen.cs (EmitThis): it needs to know whether we need the
11575 address of `this' or not. This is used by value types.
11577 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11578 every other call passes false.
11580 2006-01-12 Raja R Harinath <rharinath@novell.com>
11583 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11585 * expression.cs (Invocation.OverloadResolve): Update.
11586 (Invocation.DoResolve): Avoid double resolution of invocation.
11588 2006-01-11 Raja R Harinath <rharinath@novell.com>
11591 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11592 unary negation of floating point types as 0-expr; negation cannot
11593 overflow in floating point types.
11596 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11597 on operands of 'void' type.
11600 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11601 and ExclusiveOr for boolean constants too.
11603 2006-01-09 Raja R Harinath <rharinath@novell.com>
11606 * expression.cs (Invocation.OverloadResolve): Replace reflected
11607 override methods with their base virtual methods, rather than
11608 skipping over them.
11609 * typemanager.cs (TypeManager.GetOverride): New.
11611 2006-01-05 Jb Evain <jbevain@gmail.com>
11613 * class.cs (Property.Define, Indexer.Define): do not tag the
11614 properties as SpecialName | RTSpecialName.
11616 2006-01-04 Miguel de Icaza <miguel@novell.com>
11618 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11619 doing a low-level comparission of parameter types. It was lacking
11620 a check for __argslist.
11622 2005-12-30 Miguel de Icaza <miguel@novell.com>
11624 * expression.cs (ParameterReference.DoResolveBase): Allow
11625 reference parameters if they are local to this block.
11627 This allows the ref and out parameters of a delegate to be used in
11628 an anonymous method, for example:
11630 delegate void set (out int x);
11632 set s = delegate (out int x){
11636 This is used by functionality introduced late in the C# language.
11638 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11639 method that take ref and out parameters.
11641 Fixes #77119 which was a late change in the spec.
11643 2005-12-23 Miguel de Icaza <miguel@novell.com>
11645 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11646 parent if its the same scope. Fixes #77060.
11648 2005-12-21 Miguel de Icaza <miguel@novell.com>
11650 * driver.cs: Report the case of no source files and no -out:
11653 2005-12-20 Raja R Harinath <rharinath@novell.com>
11656 * expression.cs (ComposedCast.GetSignatureForError): Define.
11658 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11662 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11663 ListDictionary, to contain the ExternAliasEntry entries (in
11664 addition to the NamespaceEntry.aliases hashtable). This field is
11665 shared between the original entry and its doppelganger (bodyless
11667 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11668 extern_aliases field.
11669 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11670 lookup in extern_aliases.
11672 2005-12-16 Raja R Harinath <rharinath@novell.com>
11675 * class.cs (TypeContainer.Mark_HasEquals): New.
11676 (TypeContainer.Mark_HasGetHashCode): New.
11677 (ClassPart): Override them.
11678 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11681 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11682 'parent' argument to the base constructor.
11684 Remove all mention of TypeContainer from decl.cs.
11685 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11686 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11687 (DeclSpace.DeclSpace): Likewise.
11688 (DeclSpace.DefineMembers): Remove unused argument.
11689 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11690 debugging check -- we don't care if the debug code throws an
11691 InvalidCastException instead of an InternalErrorException.
11692 * class.cs (TypeContainer.DefineMembers): Update to changes.
11693 (TypeContainer.DoDefineMembers): Likewise.
11694 (TypeContainer.GetMethods): Likewise.
11695 (PropertyMember.Define): Likewise.
11696 (MemberBase.Parent): New property that forwards to
11697 MemberCore.Parent, but ensures that we get a TypeContainer.
11698 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11699 (RootContext.PopulateTypes): Likewise. Remove special case code
11700 for !RootContext.StdLib: DefineMembers is idempotent.
11702 2005-12-14 Miguel de Icaza <miguel@novell.com>
11704 * convert.cs (ExplicitConversionCore): Check the return value from
11705 ExplicitConversionCore which can return null on failure. Fixes #76914
11707 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11709 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11711 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11713 * doc.cs : The search for referenced namespace was insufficient to
11714 get global one as it used to do. Fixed bug #76965.
11716 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11718 * doc.cs : check name in cref in the last phase that whether it is
11721 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11723 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11726 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11728 * doc.cs : so it turned out that we cannot skip override check for
11729 interface members. Fixed bug #76954.
11731 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11733 * cs-tokenizer.cs : fixed bug #75984:
11734 - #warning and #error should not be handled when the source line
11736 - #line is not checked strictly when the source line is disabled.
11737 - #define and #undef is on the other hand checked strictly at any
11740 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11742 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11745 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11747 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11749 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11750 event initializers.
11751 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11752 (FieldBase.Initializer): Initializer is now optional.
11753 (EventField.Define): Only event field can have initializer.
11755 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11757 * const.cs (Const): Reuse initializer.
11759 * cs-parser.jay: Updated after FieldBase changes.
11760 Added current_array_type to simplify array initializers.
11762 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11764 * expression.cs, iterators.cs: Updated.
11766 * namespace.cs (NamespaceEntry): Made UsingFound private.
11768 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11770 * parameterCollection.cs: Obsolete, removed.
11771 * parser.cs: Obsolete, removed.
11773 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11776 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11778 * enum.cs (Enum.Define): Set obsolete context here.
11780 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11783 - FindDocumentedMember() now expects 1) paramList as null
11784 when "we don't have to check the number of parameters" and
11785 2) Type.EmptyTypes when "there is no arguments".
11786 - Introduced FoundMember struct to hold the exact type which was
11787 used to find the documented member (the above change broke
11788 test-xml-044; it might be better just to use DeclaringType than
11789 what MS does, like this change does, but it depends on usage.)
11791 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11793 * doc.cs : documented member might be from DeclaringType for nested
11794 types. Fixed bug #76782.
11796 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11798 * anonymous.cs: Have the param code handle leaving copies on the
11799 stack etc. Allows anonymous params to take part in the assignment
11800 code (++, +=, etc). Fixes bug #76550
11802 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11803 it down to the anon code.
11805 * iterators.cs: Use dummy var here
11807 * codegen.cs: Handle new vars
11809 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11812 * class.cs (MethodData.Define): Set proper Obsolete context.
11814 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11816 (FieldExpr.DoResolve): Ditto.
11818 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11821 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11822 parent is not obsolete.
11824 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11826 * doc.cs : (FindDocumentedMember) find parameterless members first
11827 and get CS0419 in the early stage. Fixed first case of bug #76727.
11829 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11832 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11833 no error was reported.
11835 *expression.cs (Binary.DoResolve): left can be null.
11837 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11840 * class.cs (MethodData.Emit): Parameters should be labeled first.
11842 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11845 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11847 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11849 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11851 * class.cs (MethodCore): Parameter clean up.
11852 (IMethodData): Added ParameterInfo.
11853 (MethodData): Parameter clean up.
11854 (Indexer.Define): Parameter clean up.
11866 * typemanager.cs: Parameter clean up.
11868 * delegate.cs (Define): Get rid of duplicated code.
11870 * expression.cs (ParameterReference): Removed useless parameters
11872 (Invocation): Ditto.
11874 * parameter.cs (ParamsParameter): New class, params specialization.
11875 (ArglistParameter): Attemp to separate arglist.
11876 (Parameter): Refactored to be reusable and faster.
11877 (Parameter.Modifier): Made understandable.
11878 (Parameters): Changed to be used as a class for `this' assembly
11879 parameters. Refactored to use new specialized classes.
11881 * support.cs (ParameterData): Added Types property.
11882 (InternalParameters): Deleted.
11884 2005-08-20 Martin Baulig <martin@ximian.com>
11886 Merging this patch from GMCS to fix #75867.
11888 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11889 scope if we don't already have it.
11891 2005-11-17 Martin Baulig <martin@ximian.com>
11894 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11895 inherit the scope from our parent. Fixes #76653.
11897 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11899 * doc.cs : the previous patch does not actually fix the bug.
11900 PropertyInfo override check is now implemented and really fixed it.
11901 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11903 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11905 * doc.cs : apply "override filter" also to properties.
11908 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11910 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11911 no need to check overrides. For classes, omit those results from
11912 interfaces since they must exist in the class. Fixed bug #76726.
11914 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11916 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11917 with different parameters. Fixed the second problem in #76685.
11919 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11921 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11922 get expected 'protected' access in CheckValidFamilyAccess()).
11925 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11927 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11928 Fixed bug #76705. CS1569 was incorrectly commented out.
11930 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11932 * doc.cs : use Invocation.IsOverride() to do real override check.
11933 * expression.cs : made Invocation.IsOverride() internal.
11935 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11937 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11938 TypeBuilder.FindMembers() and filter overriden base members out.
11941 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11943 * doc.cs : ref/out parameters are represented as '@' (instead of
11944 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11946 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11948 * doc.cs : when there was no '.' in cref to methods in doc comment,
11949 then parameters were missing in the output. Fixed bug #76691.
11951 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11953 * driver.cs : don't output docs when there is an error.
11956 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11959 Now it should detect indexers. Fixed primary concern in bug #76685.
11960 Fixed CS0419 message to not show the identical member signature in
11963 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11965 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11966 instead of Type.FindMembers() since it does not handle events.
11969 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11971 * codegen.cs: Fixed typo (speficied -> specified).
11973 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11976 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11978 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11980 * attribute.cs: Changed error message.
11982 * cs-tokenizer.cs: One more check.
11984 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11986 * statement.cs (Block.Resolve): Ignore empty statement.
11988 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11990 * report.cs: Made error/warning methods more strict to avoid
11993 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11994 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11995 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11996 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11998 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12000 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12001 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12003 * class.cs (TypeContainer.IsComImport): New property.
12004 (Constructor.Define): Create proper ctor for ComImport types.
12006 * expression.cs (New.CheckComImport): Fixed.
12008 2005-11-07 Miguel de Icaza <miguel@novell.com>
12010 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12011 that a parameter has been captured does not mean that we do not
12012 have to do the rest of the processing. This fixes the second part
12013 of #76592. If there was another anonymous method capturing
12014 values in the past, the Scope would never be set for the second
12015 method that captured the same parameter.
12017 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12018 properly manipulate the stack. Second part of fix for #76592.
12020 * expression.cs (New): Add support for invoking "new" on
12021 interfaces that have been flagged with the ComImport attribute and
12022 the CoClass. Fixes #76637
12024 * statement.cs (Try.DoEmit): When a variable is captured, do not
12025 try to emit the vi.LocalBuilder variable as it has been captured.
12026 Create a temporary variable and store the results on the
12027 FieldBuilder. Fixes #76642
12029 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12031 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12033 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12035 * expression.cs (Binary.DoResolve): Added && optimalization.
12037 * typemanager.cs (AddUserType): Removed useless argument.
12039 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12041 * statement.cs (Block.variables): Uses ListDictionary.
12043 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12046 * class.cs (PartialContainer.EmitType): Customized to emit
12047 security attributes.
12048 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12049 for partial classes.
12051 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12054 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12055 access has to be fixed.
12057 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12059 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12062 * ecore.cs (NullCast.Reduce): Implemented.
12064 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12067 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12069 (Foreach.Resolve): Catch null properly.
12071 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12073 * cs-tokenizer.cs: Warning text fix.
12075 * driver.cs: AllWarningNumbers exposed on public interface.
12077 * report.cs (): Reviewed warning numbers.
12078 (IsValidWarning): Use binary search.
12080 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12082 * driver.cs: Implemeted resource visibility.
12083 (Resources): New class for code sharing between /res: and
12086 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12089 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12092 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12095 * ecore.cs (NullCast): Child is contant only.
12097 * literal.cs (NullLiteral.Reduce): null can be converted to any
12100 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12102 * driver.cs: Use Encoding.Default as default code page instead
12105 2005-10-27 Raja R Harinath <rharinath@novell.com>
12108 * expression.cs (Invocation.Error_InvalidArguments): Handle
12109 __arglist parameters.
12110 (Invocation.VerifyArgumentsCompat): Likewise.
12111 * support.cs (ReflectionParameters.GetSignatureForError): Print
12112 __arglist parameters.
12113 (InternalParamters.GetSignatureForError): Likewise.
12114 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12116 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12118 * attribute.cs (GetPropertyValue): Made public.
12120 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12122 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12124 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12127 * driver.cs: Reflect method name change.
12129 * statement.cs (Try.Resolve): Warn when try has both general
12130 exception handlers.
12132 * typemanager.cs: runtime_compatibility_attr_type new predefined
12135 2005-10-26 Raja R Harinath <harinath@gmail.com>
12138 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12139 treat it as an empty parameter list.
12141 2005-10-26 Raja R Harinath <rharinath@novell.com>
12144 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12145 ResolveAsTypeStep silent.
12146 * statement.cs (Block.AddConstant): Mark block as used.
12147 (Block.ResolveMeta): Avoid piling on error messages
12148 if a constant initializer resolution fails.
12150 2005-10-25 Raja R Harinath <rharinath@novell.com>
12152 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12154 (NamespaceEntry.VerifyAllUsing): New.
12155 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12156 behaviour. Delegates actual resolution of alias to ...
12157 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12158 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12160 * driver.cs (Driver.MainDriver): Update.
12162 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12163 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12165 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12167 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12168 RootNamespace.DefineNamespacesForAll.
12170 2005-10-24 Raja R Harinath <harinath@gmail.com>
12172 * typemanager.cs (assemblies, external_aliases, modules)
12173 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12174 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12175 overhead. Move resposibility ...
12176 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12177 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12179 2005-10-23 Raja R Harinath <harinath@gmail.com>
12181 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12182 cached_namespaces. Improve usage.
12183 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12184 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12185 Move from GlobalRootNamespace and simplify.
12186 (RootNamespace.Global): Make instance variable.
12187 (RootNamespace.RootNamespace): Add "alias name" parameter.
12188 (GlobalRootNamespace): Simplify drastically.
12189 (Namespace.Lookup): Don't use GetNamespace.
12190 * typemanager.cs (GetRootNamespace): Rename from
12191 ComputeNamespaceForAlias.
12192 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12194 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12196 * anonymous.cs (AnonymousContainer): Don't crash when container
12199 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12201 * expression.cs (Binary.DoResolve): Warn when comparing same
12204 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12207 * expression.cs (Binary.DoResolve): It looks like there are no
12208 convetsion rules in enum context.
12210 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12212 Add support for extern alias qualifiers.
12213 * typemanager.cs: Move some LookupTypeReflection code
12214 to namespace.cs, to have cleaner code. Added some methods
12215 to help us keep track of the extern aliased references.
12216 * driver.cs: Add suport for extern alias assemblies on command
12217 line and check for their warnings/errors. Also keep track of the
12218 extern aliased assemblies.
12219 * namespace.cs: Move the global functionality of Namespace
12220 to GlobalRootNamespace/RootNamespace. Now the global namespace
12221 is GlobalRootNamespace.Globa. Also the code moved from
12222 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12223 Finally added LocalAliasEntry (AliasEntry before) and
12224 ExternAliasEntry, to handle alias statements.
12225 * cs-parser.jay: Add support in the grammar for extern alias
12227 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12228 Update callings to Namespace (now in GlobalRootNamespace).
12230 2005-10-18 Raja R Harinath <rharinath@novell.com>
12233 * class.cs (TypeContainer.DefineType): Move updating of
12234 topological sort earlier in the code.
12235 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12237 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12240 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12242 * constant.cs (Constant.TryReduce): Moved from Cast class.
12243 (Reduce): Made little bit more OO and fixed missing conversions.
12245 * ecore.cs (Reduce): Implemented.
12246 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12248 * literal.cs (Reduce): Implemented.
12250 * class.cs: Reverted Miguel's wrong commit.
12252 2005-10-14 Miguel de Icaza <miguel@novell.com>
12254 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12256 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12258 * cs-parser.jay, expression.cs : CS0214 was missing error location
12259 for constants. Fixed bug #76404.
12261 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12264 * convert.cs (ExplicitConversionCore): Fixed object->enum
12267 2005-10-10 Raja R Harinath <rharinath@novell.com>
12269 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12270 InstanceExpression.
12271 (PropertyExpr.EmitCall): Likewise.
12272 * expression.cs (Invocation.EmitArguments): Handle case where
12274 (Invocation.EmitCall): Avoid allocating temporary variable if
12275 there are no arguments.
12277 2005-10-07 Raja R Harinath <rharinath@novell.com>
12280 * convert.cs (ImplicitConversionStandard): Move conversion of
12281 void* to arbitrary pointer types ...
12282 (ExplicitConversionStandard): .. here.
12283 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12284 error to always print typenames.
12286 2005-10-07 Raja R Harinath <rharinath@novell.com>
12288 * convert.cs (GetConversionOperator): Rename from
12289 GetConversionOperators. Move operator selection code from ...
12290 (UserDefinedConversion): ... here.
12292 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12294 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12297 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12299 * assign.cs (Assign.DoResolve): Error method changed.
12301 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12303 * const.cs (ResolveValue): Reset in_transit immediately.
12305 * constant.cs: Error method changed.
12307 * convert.cs: Removed useless location parameter.
12308 (ExplicitNumericConversion): Don't do double enum check.
12309 (ExplicitConversionCore): Renamed from ExplicitConversion.
12310 (ExplicitUnsafe): Extracted from ExplicitConversion.
12311 (ExplicitConversion): Uses for error reporting.
12313 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12315 (ResolveBoolean): Uses common error method.
12316 (CastToDecimal): Get rid of ec.
12317 (CastFromDecimal): Optimized.
12318 (ConvCast): Get rid of ec.
12320 * enum.cs (ResolveValue): Reset in_transit immediately.
12321 (Emit): Return after first error.
12323 * expression.cs: Convert changes.
12325 * literal.cs: Error method changed.
12327 * statement.cs: Error method changed.
12329 2005-10-03 Raja R Harinath <rharinath@novell.com>
12331 * support.cs (SeekableStreamReader.Position): Don't error out when
12332 the requested position is just beyond the end of the current
12335 2005-09-28 Raja R Harinath <rharinath@novell.com>
12337 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12338 try to keep in sync with the byte count of the underlying Stream.
12339 However, this limits us to a window size of 2048 characters: i.e.,
12340 the maximum lookahead of our lexer/parser can be 2048 characters.
12342 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12345 * driver.cs: Fix compilation files with full root path.
12347 2005-09-25 Miguel de Icaza <miguel@novell.com>
12349 * report.cs (SymbolRelatedToPreviousError): Format the output so
12350 it does not use an open parenthesis that is never closed.
12352 * driver.cs: Follow coding guidelines
12354 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12357 * const.cs (Const.ResolveValue): Check for assigning non-null
12358 value to reference type.
12360 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12362 * anonymous.cs: Implemented ExprClassName.
12364 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12367 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12370 * class.cs (StaticClass.DefineContainerMembers): Report protected
12373 * codegen.cs: if(ed) PRODUCTION.
12375 * convert.cs (Error_CannotImplicitConversion): Better error
12378 * cs-parser.jay: More error checks.
12380 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12382 * driver.cs (CSCParseOption): Enabled wrong option check.
12384 * ecore.cs (Expression.ExprClassName): Turned to property.
12385 (MemberExpr.CheckIntermediateModification): For checking boxed
12386 value types modification.
12388 * statement.cs (Fixed.Resolve): Expression type must be
12389 convertible to fixed type.
12390 (CollectionForeach.GetEnumeratorFilter,TryType):
12391 Small refactoring for easier error checking.
12393 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12395 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12398 * class.cs (GeneratedBaseInitializer): New class for customization
12399 compiler generated initializers.
12400 (MemberBase.DoDefine): Check Obsolete attribute here.
12401 (FieldMember.DoDefine): Ditto.
12403 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12406 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12407 (MemberCore.GetObsoleteAttribute): Removed argument.
12408 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12409 (MemberCore.CheckObsoleteType): New helper.
12413 * statement.cs: Updates after MemberCore changes.
12415 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12416 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12418 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12419 obsolete attribute for compiler construct.
12420 (As.DoResolve): Cache result.
12422 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12424 2005-09-26 Raja R Harinath <rharinath@novell.com>
12427 * expression.cs (This.VerifyFixed): In a value type T, the type of
12428 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12429 value type R, 'this' is treated as a value parameter.
12431 2005-09-22 Miguel de Icaza <miguel@novell.com>
12433 * statement.cs (Lock): Use the TemporaryVariable class instead of
12434 manually using local variables as those do not work when variables
12437 * ecore.cs: Moved the TemporaryVariable class from being a nested
12438 class inside Foreach to be a public class that can be employed in
12441 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12443 * cs-parser.jay: interface_accessors replaced by
12444 accessor_declarations.
12446 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12449 * statement.cs (GotoCase.Resolve): Convert null constant to
12451 (SwitchLabel.ResolveAndReduce): Ditto.
12452 (SwitchLabel.NullStringCase): Custom null stamp.
12453 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12455 typemanager.cs (CSharpSignature): Don't skip first argument
12458 2005-09-18 Miguel de Icaza <miguel@novell.com>
12460 * driver.cs: Set InEmacs based on the environment variable EMACS.
12462 * location.cs (InEmacs): in this mode, do not report column
12463 location as it confuses Emacs.
12465 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12467 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12468 expression.cs, iterators.cs, literal.cs: Store constants and
12471 * class.cs (MemberBase.ShortName): Pass location.
12473 * cs-parser.jay: Some location fixes.
12475 * ecore.cs (Expression.Location): Made virtual.
12477 2005-09-05 Miguel de Icaza <miguel@novell.com>
12479 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12480 if the underlying types are the same, otherwise we need to produce
12481 code that will do the proper cast.
12483 This was exposed by Marek's constant rewrite which produced
12484 invalid code for the call site:
12486 enum X : long { a }
12487 void Method (X v) {}
12491 This fixes test-49.cs
12493 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12495 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12496 Type/Object should be allowed as well. Fixed bug #75968.
12498 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12500 * expression.cs : (Binary.DoResolve): when one is enum constant and
12501 another is constant 0, then return enum one *as enum type*.
12504 2005-09-02 Raja R Harinath <rharinath@novell.com>
12506 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12510 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12511 flow-branching for LocalVariableReferences in case we were invoked
12512 from a MemberAccess.
12513 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12515 (LocalVariableReference.DoResolveBase): ... this.
12516 (MemberAccess.Resolve): Do the check that was disabled during
12519 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12522 (PartialContainer.Create): check abstract/sealed/static strictly
12523 but abstract/sealed can exist only at one side. Fixed bug #75883.
12525 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12528 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12529 specified, don't default to UnmanagedType.I4.
12531 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12533 * expression.cs : conditional operator should check possibly
12534 incorrect assign expression. Fixed bug #75946.
12536 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12538 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12539 Reverting the change. gmcs is much complex than mcs on this matter.
12541 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12543 * cs-tokenizer.cs : To read another token ahead of the actual
12544 consumption, use new SavedToken and cache token instead of moving
12545 back the stream with SeekableStreamReader (it seemed problematic).
12547 driver.cs : Thus use StreamReader directly.
12548 * support.cs : Thus removed SeekableStreamReader.
12550 2005-08-30 Raja R Harinath <rharinath@novell.com>
12553 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12554 (ScopeInfo.EmitScopeType): Use it to construct field names from
12555 names of captured locals.
12558 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12559 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12560 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12561 (ExplicitConversion): Remove enum cases already handled by
12562 implicit conversion. Move implicit conversion check to the beginning.
12563 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12564 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12565 Don't treat System.Enum as a struct.
12567 2005-08-30 Jb Evain <jbevain@gmail.com>
12569 * attribute.cs: handles as expression in parameters.
12571 2005-08-30 Raja R Harinath <rharinath@novell.com>
12574 * class.cs (TypeContainer.VerifyClsName): Don't use a
12575 PartialContainer when verifying CLS compliance.
12576 (AbstractPropertyEventMethod): Set Parent here, ...
12577 (PropertyMethod): ... not here.
12579 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12581 * attribute.cs : escaped attribute name should not be allowed to be
12582 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12584 2005-08-29 Raja R Harinath <rharinath@novell.com>
12587 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12588 when converting a long constant to unsigned long.
12589 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12590 detect where IsApplicable and VerifyArgumentsCompat disagree.
12592 2005-08-29 Raja R Harinath <rharinath@novell.com>
12593 and Carlos Alberto Cortez <carlos@unixmexico.org>
12596 * class.cs (TypeContainer.CanElideInitializer): New helper.
12597 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12598 can safely emitting the initializer of a field.
12600 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12602 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12603 allowed inside a switch (without loop). Fixed bug #75433.
12605 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12607 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12608 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12610 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12612 * driver.cs : kinda reverting the default encoding changes (not exact
12613 revert since I noticed that "codepage:reset" might not work fine).
12615 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12617 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12618 Location. Now getter and setter store location correctly.
12619 (errors/cs0111-12.cs now reports the expected location.)
12621 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12623 * driver.cs : Use default encoding on the environment.
12624 Removed (now that) extra parameter for SeekableStreamReader.
12625 * support.cs : (SeekableStreamReader) third .ctor() argument for
12626 StreamReader is not required (always true). preamble size could
12627 be acquired in simpler and safe way.
12629 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12631 * cs-parser.jay: report CS0642 at warning level 3
12632 and report CS0642 for an if else statement also
12633 fixes bug #74745. Patch by John Luke (and a bit
12635 Removed extra CS0642 warning check for "while",
12637 * statement.cs: In Block.Resolve(), CS0642 check
12638 is reimplemented to check a sequence of an empty
12639 statement and a block.
12641 Both fix bug #66777.
12643 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12645 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12646 detection until I fix it.
12648 * cs-tokenizer.cs: Changed error message.
12650 * cs-parser.jay: Fixed 2 error locations.
12652 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12653 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12656 * enum.cs (GetSignatureForError): Fixed.
12658 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12662 * typemanager.cs (RegisterProperty): Removed.
12664 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12666 2005-08-24 Raja R Harinath <rharinath@novell.com>
12669 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12670 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12672 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12674 * expression.cs : tiny fix is required for not warning positive ulong.
12677 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12679 * expression.cs : add CS0652 check for constant and integral
12680 expression. Fixed bug #53974.
12682 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12684 * expression.cs : in DoNumericPromotions(), check if there is implicit
12685 conversion overload for string (to check CS0034). Fixed bug #52492.
12687 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12689 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12691 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12693 * ecore.cs : report location when it is *not* Null.
12695 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12701 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12702 correctly. Fixed bug #75721.
12704 2005-08-23 Raja R Harinath <rharinath@novell.com>
12706 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12707 loop that performs 'min (pos, char_count)'.
12710 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12711 converted value in Operator.OnesComplement.
12713 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12715 * anonymous.cs: If the anon method is pulled into a helper class,
12716 it needs to be `internal' not `private'. Fixes runtime behavior on
12719 2005-08-20 Martin Baulig <martin@ximian.com>
12721 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12722 scope if we don't already have it.
12724 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12725 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12728 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12731 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12732 is a partial class.
12734 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12736 The big constants rewrite
12737 Fix #75746, #75685 and more
12738 As a side effect saved 1MB for MWF ;-)
12740 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12741 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12742 enum based for corlib compilation.
12744 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12747 * class.cs (FixedField.Define): Use ResolveAsConstant.
12749 * const.cs (IConstant): Interface constants and enums.
12750 (Const.ResolveValue): New method for constant resolvning.
12751 (ExternalConstant): Constants from imported assemblies.
12753 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12754 conversion; like enums.
12755 (Constant.ToType): Converts this constant to different type.
12756 (Constant.Increment): Adds 1.
12758 * convert.cs (ImplicitConversionRequired): Simplified.
12760 * cs-parser.jay: Create EnumMember directly.
12762 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12764 * doc.cs (GenerateEnumDocComment): Removed.
12766 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12767 (ConvertIntLiteral): Removed.
12768 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12770 * enum.cs (EnumMember): Implement IConstant.
12771 (Enum.IsValidEnumConstant): Removed.
12772 (Enum.GetNextDefaultValue): Removed.
12773 (Enum.FindMembers): Updated.
12774 (Enum.GenerateDocComment): Iterate enum members.
12776 * expression.cs (Cast.TryReduce): Handle enums correctly.
12777 (New.Constantify): Made public.
12778 (MemberAccess.DoResolve): Removed contant specific if(s).
12780 * literal.cs (NullLiteral): Implement new abstract methods.
12782 * statement.cs (GotoCase.Resolve): Use new constant methods.
12783 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12785 * typemanager.cs (LookupEnum): Removed.
12786 (IsEnumType): Fixed to work with corlib.
12787 (RegisterConstant): Removed.
12788 (LookupConstant): Removed.
12789 (GetConstant): Changed to work with IConstant.
12791 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12793 * location.cs : Fixed overflown (>255) column number.
12795 2005-08-03 Raja R Harinath <rharinath@novell.com>
12797 First cut of the qualified-alias-member feature.
12798 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12800 * cs-parser.jay (DOUBLE_COLON): New token.
12801 (namespace_or_type_name): Add rule for recognizing
12802 qualified-alias-members.
12803 (primary_expression): Likewise.
12804 (element_access): Allow QualifiedAliasMember as a possible
12805 type-bearing expression.
12806 (local_variable_type, local_variable_pointer_type): Likewise.
12807 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12808 aliases in the current and enclosing namespace declarations.
12809 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12810 * decl.cs (MemberName.is_double_colon): New.
12811 (MemberName.MemberName): Add new constructor for alias-member.
12812 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12813 * expression.cs (QualifiedAliasMember): New expression type.
12815 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12817 * location.cs : it borked when no argument was specified.
12819 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12821 * location.cs : tiny ToString() format fix.
12823 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12825 * statement.cs : oops, it was missing.
12827 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12829 A set of fixes for precise line/column location.
12832 "token" field now holds a file/line "delta", a line number offset
12833 from the segment, and a column number. See also:
12834 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12835 December/009508.html
12836 Removed static IsNull. Use instance IsNull property instead.
12837 * cs-tokenizer.cs :
12838 For some tokens it stores Location. For Identifier it stores
12839 LocatedToken which is a pair of string name and location.
12840 Column numbers are adjusted only at getChar().
12842 Use Location.ToString() for reporting (it now contains column).
12844 Largely modified to use LocatedToken instead of
12845 string (IDENTIFIER), and to acquire Location from some tokens.
12846 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12847 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12849 Now MemberName holds Location. DeclSpace.ctor() receives Location
12850 as a parameter. Removed extra parameters to all derived classes.
12851 Replaced Location.IsNull() with instance property.
12852 * assign.cs, expression.cs :
12853 Added .ctor() overload that omits Location.
12855 Added "nameEscaped" flag that indicates the identifier was escaped
12856 in the source file. This fixes bug #57047.
12858 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12860 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12861 New method, looking for lo-case imported cls type.
12863 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12866 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12868 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12870 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12871 all_imported_types.
12872 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12874 Optimized to save 3.5 MB for SWF compilation.
12876 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12878 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12879 (PartialContainer.Create): Moved logic AddToContainer.
12880 (PartialContainer.MarkForDuplicationCheck): Shares name.
12882 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12885 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12887 (Namespace.GetSignatureForError): New method.
12889 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12890 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12892 2005-08-01 Raja R Harinath <rharinath@novell.com>
12895 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12896 member lookup rather than qualifier_type, since qualifier_type can
12899 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12901 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12904 2005-07-31 Miguel de Icaza <miguel@novell.com>
12906 * statement.cs: Copy the local exception into the exception
12907 captured local. Fixes 75674
12909 2005-07-31 Raja R Harinath <harinath@gmail.com>
12912 * expression.cs (Invocation.OverloadResolve): Don't report error
12913 CS1501 if error CS1502 has been reported.
12914 (New.DoResolve): Delegate CS1501 reporting to
12915 Invocation.OverloadResolve.
12918 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12919 invariant-meaning-in-block property in an enclosing block if
12922 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12924 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12925 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12926 (Switch.CheckSwitch): Just save 50kb for SWF.
12928 2005-07-27 Martin Baulig <martin@ximian.com>
12930 * anonymous.cs (CaptureContext.AddField): Added
12931 `AnonymousContainer am' argument; compute its toplevel scope if
12932 it's not already computed. Fixes #75649.
12934 2005-07-26 Raja R Harinath <rharinath@novell.com>
12937 * class.cs (Constructor.Emit): Reset block to null if the block
12940 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12942 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12944 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12946 * class.cs (MethodData.Define): Check whether accessor implementing
12947 interface is public.
12949 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12951 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12954 * namespace.cs (LookupType): Moved same type check to...
12956 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12957 with the same name.
12959 2005-07-21 Raja R Harinath <rharinath@novell.com>
12961 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12962 already found a typebuilder.
12963 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12964 MemberNames, not strings.
12966 * const.cs (Error_ExpressionMustBeConst):
12967 Rename from Error_EpressionMustBeConst.
12968 * const.cs, class.cs, statement.cd: Update.
12970 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12974 * const.cs (Const.LookupConstantValue): Report missing contant expression
12976 (Error_EpressionMustBeConstant): Only one error method.
12978 * class.cs, statement.c: Updated.
12980 2005-07-20 Raja R Harinath <rharinath@novell.com>
12982 * statement.cs (Block.Flags): Add back HasVarargs.
12983 (Block.flags): Make protected.
12984 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12986 * typemanager.cs (types, typecontainers, user_types): Remove.
12987 (UserTypes, TypeContainers): Likewise.
12988 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12989 (CleanUp, Reset): Update.
12990 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12991 (GetNestedType): Use Type.GetNestedType.
12992 (CoreLookupType): Take two arguments, the namespace and the
12993 basename of the type. Update to use the Namespace.Lookup
12995 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12996 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12997 string concatenation and substring matches.
12998 * class.cs, enum.cs, delegate.cs: Update to changes.
13000 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13002 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13003 Expression and made virtual.
13005 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13006 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13008 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13010 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13013 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13016 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13019 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13020 AssemblyCultureAttribute is not used on executable.
13023 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13025 2005-07-16 Raja R Harinath <rharinath@novell.com>
13028 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13029 New. Reports CS0252/CS0253.
13030 Mostly taken from preliminary patch by Duncak Mak.
13031 (Binary.DoResolveOperator): Store results of operator lookup.
13032 Use them to detect if we need to warn about unintended reference
13035 2005-07-15 Raja R Harinath <rharinath@novell.com>
13038 * namespace.cs (Namespace.Lookup): Add back location parameter.
13039 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13040 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13042 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13043 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13044 (Namespace.LookupType): ... this.
13045 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13047 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13048 purported to handle pointers.
13049 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13052 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13054 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13057 2005-07-15 Raja R Harinath <rharinath@novell.com>
13059 * namespace.cs (Namespace.Lookup): Drop location parameter.
13060 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13061 (NamespaceEntry.Lookup): ... this.
13062 (NamespaceEntry.Error_AmbiguousTypeReference):
13063 Move here from DeclSpace.
13064 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13066 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13067 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13068 Move to NamespaceEntry.
13069 * delegate.cs, expression.cs: Update to changes.
13071 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13073 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13074 CheckAttributeType and refactored.
13075 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13076 ResolveAsTypeTerminal error handling.
13077 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13079 (GetSignatureForError): Print errors in same way.
13082 * codegen.cs: Reflect attribute GetSignatureForError change.
13085 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13087 * namespace.cs (UsingEntry): Refactored to make fields private.
13090 statement.cs: Error_UnexpectedKind has extra parameter.
13092 2005-07-14 Raja R Harinath <rharinath@novell.com>
13094 * ecore.cs (IAlias): Remove.
13095 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13096 that implement the interface.
13097 * namespace.cs (Namespace): Likewise.
13098 (Namespace.declspaces): Renamed from 'defined_names'.
13099 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13100 DeclSpace instead of an IAlias.
13101 * tree.cs (Tree.AddDecl): Update.
13103 2005-07-12 Raja R Harinath <rharinath@novell.com>
13105 * statement.cs (Block.Flags); Remove HasVarargs.
13106 (Block.HasVarargs): Move to ToplevelBlock.
13107 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13108 (Block.Variables): Make protected. Initialize variable hashtable
13110 (Block.AddVariable): Update.
13111 (Block.Resolve): Update to changes.
13112 (ToplevelBlock.HasVarargs): New boolean.
13113 (ToplevelBlock.ThisVariable): Move here from Block.
13114 (ToplevelBlock.AddThisVariable): Likewise.
13115 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13116 * expression.cs (This.ResolveBase): Update to changes.
13117 (ArglistAccess.DoResolve): Likewise.
13119 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13122 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13124 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13125 not used and not used & assigned.
13126 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13128 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13131 * expression.cs (Is.DoResolve): null is never provided type.
13133 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13136 * cs-parser.jay: Less strict event error rule to catch more errors.
13138 2005-07-08 Martin Baulig <martin@ximian.com>
13140 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13141 gettter (allowed) or setter (not allowed).
13143 * class.cs (Accessor): Implement IIteratorContainer.
13144 (Accessor.Yields): New public field.
13145 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13146 per-accessor basis.
13149 (get_accessor_declaration, set_accessor_declaration): Set the
13150 `yields' flag on the accessor, not the property.
13151 (property_declaration): Do the iterators check on a per-accessor
13152 basis and not for the whole property.
13154 2005-07-08 Martin Baulig <martin@ximian.com>
13156 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13157 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13159 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13162 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13163 (ExtractSecurityPermissionSet): Cope with self referencing security
13164 attributes properly.
13166 * driver.cs (SetOutputFile): Made public property OutputFile.
13168 2005-07-07 Raja R Harinath <rharinath@novell.com>
13171 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13172 has_nonstatic_fields. Make into a FieldBase pointer.
13173 (TypeContainer.AddField): Add CS0282 check.
13174 (TypeContainer.EmitType): Update.
13176 2005-07-06 Miguel de Icaza <miguel@novell.com>
13178 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13179 compare if they start with __.
13181 2005-07-06 Raja R Harinath <rharinath@novell.com>
13183 * statement.cs (Switch.SwitchGoverningType): Only look at
13184 UserCasts that don't need implicit standard conversions to one of
13185 the allowed switch types (Fixes test-322.cs).
13186 (LocalInfo.Resolve): Re-enable sanity-test.
13188 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13190 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13192 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13194 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13196 2005-07-06 Raja R Harinath <rharinath@novell.com>
13199 * ecore.cs (SimpleName.GetSignatureForError): Add.
13200 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13201 (MemberAccess.GetSignatureForError): Add.
13203 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13205 The big error and warning messages review.
13235 * typemanager.cs: Updated.
13237 * class.cs: (MethodCore.SetYields): Moved here to share.
13238 (PropertyMethod.Define): Moved iterator setup here.
13240 * iterators.cs: Add orig_method to have full access to parent
13243 2005-07-05 Raja R Harinath <rharinath@novell.com>
13245 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13246 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13247 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13248 variable of struct type.
13249 * expression.cs (Unary.ResolveOperator): Update to change.
13250 (Indirection.VerifyFixed): Likewise.
13251 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13252 (ParameterReference.VerifyFixed): Value parameters are fixed.
13253 (This.VerifyFixed): Treat 'this' as a value parameter.
13254 * statement.cs (LocalInfo.IsFixed): Remove.
13256 2005-07-01 Martin Baulig <martin@ximian.com>
13258 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13259 `ec.EmitThis ()' to get the correct scope.
13261 2005-07-01 Martin Baulig <martin@ximian.com>
13263 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13264 instance is a ParameterReference; fixes #75299.
13266 2005-07-01 Martin Baulig <martin@ximian.com>
13268 Reverted Marek's latest patch (r46725):
13269 - it contains structural changes which are neither mentioned in
13270 the ChangeLog nor explained anywhere; for example the additional
13271 argument of EmitContext's and Iterator's .ctor's and the
13272 TypeContainer.DefineMembers() change.
13273 - structural changes like this should go in in seperate patches
13274 and not be hidden in a huge patch which just seems to affect
13275 warnings and errors.
13276 a big and hard to understand patch.
13277 - it breaks iterators and causes regressions, for instance in
13280 2005-06-30 Raja R Harinath <rharinath@novell.com>
13283 * expression.cs (Indexers.map): Remove.
13284 (Indexers.Append): Filter out inaccessible setters and getters.
13285 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13288 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13289 Refactored from ...
13290 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13291 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13292 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13293 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13295 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13298 * class.cs (FieldBase.GetInitializerExpression): One more field
13301 2005-06-28 Miguel de Icaza <miguel@novell.com>
13303 * pending.cs: Do not define a proxy if the base method is virtual,
13304 it will be picked up by the runtime (bug 75270).
13306 2005-06-08 Martin Baulig <martin@ximian.com>
13308 The big Iterators rewrite :-)
13310 * iterators.cs: Rewrite this to use the anonymous methods framework.
13312 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13313 before the TypeContainers; see 2test-21.cs.
13316 (TypeContainer.DefineType): Don't create a new EmitContext if we
13317 already have one (this only happens if we're an Iterator).
13318 (TypeContainer.Define): Also call Define() on all our iterators.
13319 (Method.CreateEmitContext): Added support for iterators.
13322 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13323 (AnonymousContainer.CreateMethodHost): Moved here from
13324 AnonymousMethod and made abstract.
13325 (AnonymousContainer.CreateScopeType): New abstract method.
13326 (AnonymousContainer.IsIterator): New public property.
13327 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13328 get the ScopeTypeBuilder rather than manually defining it here.
13329 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13332 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13333 before RootContext.DefineTypes().
13335 * codegen.cs (EmitContext.RemapToProxy): Removed.
13336 (EmitContext.CurrentAnonymousMethod): Changed type from
13337 AnonymousMethod -> AnonymousContainer.
13338 (EmitContext.ResolveTopBlock): Protect from being called twice.
13339 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13340 (EmitContext.EmitThis): Removed the iterators hacks; use the
13341 anonymous methods framework for that.
13344 (ToplevelBlock.Container): Make this a property, not a field.
13345 (ToplevelBlock.ReParent): New public method; move the
13346 ToplevelBlock into a new container.
13347 (Foreach.TemporaryVariable): Simplify.
13349 2005-06-05 Martin Baulig <martin@ximian.com>
13351 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13352 (Block.AddTemporaryVariable): New public method; creates a new
13353 `LocalInfo' for a temporary variable.
13354 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13356 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13357 non-iterator variables.
13359 2005-06-05 Martin Baulig <martin@ximian.com>
13361 * statement.cs (Foreach.TemporaryVariable): Create the
13362 LocalBuilder in the Emit phase and not in Resolve since in some
13363 situations, we don't have an ILGenerator during Resolve; see
13364 2test-19.cs for an example.
13366 2005-06-04 Martin Baulig <martin@ximian.com>
13368 **** Merged r45395 from GCS ****
13370 The big Foreach rewrite - Part II.
13372 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13373 with `PropertyInfo ienumerator_getcurrent'.
13375 * codegen.cs (VariableStorage): Removed.
13378 (Foreach): Derive from Statement, not ExceptionStatement.
13379 (Foreach.CollectionForeach): New nested class. Moved all the code
13380 dealing with collection foreach here.
13381 (Foreach.ForeachHelperMethods): Removed.
13382 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13384 2005-05-23 Martin Baulig <martin@ximian.com>
13386 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13387 don't need to. Fix #75014.
13389 2005-05-20 Martin Baulig <martin@ximian.com>
13391 Merged r44808 from GMCS.
13393 * class.cs (TypeContainer.CircularDepException): Removed.
13394 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13395 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13396 (CS0146) and interface (CS0529) dependencies here.
13398 2005-06-21 Raja R Harinath <rharinath@novell.com>
13400 * expression.cs (Invocation.EmitCall): Fix initialization
13401 'this_call' to reflect current behaviour. Fix indentation.
13403 * convert.cs (FindMostEncompassedType): Add two trivial special
13404 cases (number_of_types == 0 || number_of_types == 1).
13405 (FindMostEncompasingType): Likewise.
13407 2005-06-17 Raja R Harinath <rharinath@novell.com>
13409 Some cleanups preparing for the fix of #75283.
13410 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13412 (EventExpr.InstanceResolve): Likewise.
13413 (EventExpr.DoResolve): Remove redundant checks.
13415 2005-06-10 Duncan Mak <duncan@novell.com>
13417 * cs-tokenizer.cs (process_directives): New flag for controlling
13418 the processing of preprocessor directives.
13419 (x_token): After seeing a '#', return Token.NONE instead of going
13420 to handle_preprocessing_directive() when not processing
13421 directives. This avoids unnecessary processing during the token peek in
13426 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13427 the existing error reporting methods instead of Report.Error.
13429 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13430 after Raja's rewrite.
13432 2005-06-08 Miguel de Icaza <miguel@novell.com>
13434 * class.cs: Small fix.
13436 2005-06-08 Raja R Harinath <rharinath@novell.com>
13439 * class.cs (GetPartialBases): Fix return value check of
13440 part.GetClassBases.
13442 2005-06-07 Raja R Harinath <rharinath@novell.com>
13444 Ensure that partial classes are registered in their enclosing
13445 namespace. Initial part of fix of #75160.
13446 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13447 Register declspace with namespace here, not in
13448 DeclSpace.RecordDecl.
13449 * cs-parser.jay: Pass namespace to RecordDecl.
13450 * class.cs (PartialContainer.Create): Likewise.
13451 (ClassPart.DefineType): New sanity-check. Throws an exception if
13453 * decl.cs (Declspace.RecordDecl): Remove.
13454 * namespace.cs (NamespaceEntry.DefineName): Remove.
13456 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13458 * rootcontext.cs: Reset TargetExt as well.
13460 2005-06-03 Raja R Harinath <rharinath@novell.com>
13462 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13463 -langversion:ISO-1.
13465 2005-06-02 Raja R Harinath <rharinath@novell.com>
13467 Fix #75080, cs0119.cs.
13468 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13470 (Expression.Resolve): ... this. Use it. Remove bogus code
13471 allowing ExprClass.Type and ExprClass.Namespace for
13472 ResolveFlags.VariableOrValue.
13473 (Expression.Resolve) [1-argument variant]: Change default resolve
13474 flags based on language version.
13475 (Expression.Error_UnexpectedKind): Use a simple string array
13476 rather than an ArrayList.
13477 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13478 not ExprClass.Type.
13479 (TypeOfVoid.DoResolve): Likewise.
13480 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13481 flags argument -- it always has the same value.
13483 2005-05-31 Raja R Harinath <rharinath@novell.com>
13486 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13487 Use it in the error message.
13488 * assign.cs, expression.cs, statement.cs: Update.
13490 2005-05-30 Raja R Harinath <rharinath@novell.com>
13493 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13494 the "almostMatchedMember" case too.
13495 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13496 that failed the accessibility checks to 'almost_match'.
13498 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13500 * attribute.cs: Use internal MethodBuilder methods to set
13501 ExactSpelling and SetLastError on PInvoke methods, instead
13502 of passing them via charset. Fixes #75060.
13504 2005-05-27 Raja R Harinath <rharinath@novell.com>
13506 * parameter.cs (Parameter): Remove TODO comment.
13507 (Parameter.DefineParameter): Remove Location parameter.
13508 (Parameters.LabelParameters): Likewise.
13509 * class.cs (Constructor.Emit): Update to change.
13510 (MethodData.Emit): Likewise.
13511 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13512 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13514 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13517 Removed Parameters.Location and added Parameter.Location instead.
13518 Removed Location parameter from Emit() and GetSignature().
13525 Modified all related calls.
13527 2005-05-26 Raja R Harinath <rharinath@novell.com>
13529 Improve user-defined conversion handling.
13530 * convert.cs (GetConversionOperators): Rewrite. Return only the
13531 applicable operators.
13532 (AddConversionOperators): New. Helper for GetConversionOperators.
13533 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13534 there is only one most encompassed/encompassing type.
13535 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13536 "applicable operator" handling.
13537 (UserConversion): Move cache here from GetConversionOperators.
13538 Directly cache the chosen operator, rather than the whole
13540 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13541 case. Allow conversion of decimal to sbyte and byte too.
13542 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13543 New static methods. Used to avoid allocating EmptyExpressions in
13546 2005-05-24 Duncan Mak <duncan@novell.com>
13548 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13549 another class, used in Convert.ExplicitNumericConversion.
13550 (CastToDecimal): New class, similar to above, but casts to
13551 System.Decimal, used in Convert.ImplicitNumericConversion and also
13552 in explicit convesion from double/float to decimal.
13554 * convert.cs (ImplicitNumericConversion): Handle implicit
13555 conversions to System.Decimal.
13556 (ExplicitNumericConversion): handle explicit conversions to
13561 2005-05-20 Miguel de Icaza <miguel@novell.com>
13563 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13564 know the type at this stage, just break through. Fixes #75008
13566 2005-05-19 Martin Baulig <martin@ximian.com>
13569 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13570 to disable error reporting.
13572 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13573 here since we don't want to report an error; see the new test-336.cs.
13575 2005-05-19 Raja R Harinath <rharinath@novell.com>
13577 * statement.cs (ToplevelBlock.GetParameterReference)
13578 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13579 Move here from class Block.
13580 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13581 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13583 2005-05-18 Martin Baulig <martin@ximian.com>
13588 (FlowBranching.Reachability): Add non-static public And() and Or()
13590 (FlowBranchingSwitch): New class; do the `break_origins' thing
13591 like in FlowBranchingLoop.
13592 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13593 reachability, not just locals and parameters.
13594 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13595 switch; MergeBreakOrigins() now takes care of that.
13597 2005-05-18 Martin Baulig <martin@ximian.com>
13599 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13600 a loop and may leave it, reset the barrier; fixes #74974.
13602 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13604 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13607 * cs-parser.jay: Catch more lexical errors.
13609 * report.cs: Add one more Error method.
13612 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13614 2005-05-17 Martin Baulig <martin@ximian.com>
13616 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13619 2005-05-16 Raja R Harinath <rharinath@novell.com>
13621 Fix test-382.cs. Emit values of decimal constants.
13622 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13624 (TypeContainer.AddField): ... this.
13625 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13626 with initializers to include 'Const's.
13627 (ClassPart.RegisterFieldForInitialization): Forward to
13629 * const.cs (Const.Const): Pass initializer to base class.
13630 (Const.Define): In case of decimal constants, register them for
13631 initialization in a static constructor.
13633 2005-05-14 Martin Baulig <martin@ximian.com>
13635 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13636 do not call ResolveUnreachable() on unreachable statements in
13637 here, see the comment in the source code.
13639 2005-05-13 Raja R Harinath <rharinath@novell.com>
13642 * expression.cs (BinaryResolveOperator): If one of the operands of
13643 an equality comparison is 'null' and the other is a pointer type,
13644 convert the null to a NullPointer.
13645 * convert.cs (ImplicitReferenceConversion): If the expression is a
13646 NullLiteral and the target type is a pointer type, return a
13647 NullPointer instead.
13648 (ImplicitConversionStandard): Likewise.
13650 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13652 * cs-parser.jay: Set readonly context based on special constructs.
13654 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13655 readonly variable error handling.
13657 * rootcontext.cs (EmitCode): Don't verify members when error
13660 * statement.cs (LocalInfo): Add reaodnly context information.
13661 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13663 2005-05-13 Raja R Harinath <rharinath@novell.com>
13665 * statement.cs (Block.Resolve): Revert change below. Modify fix
13666 for #74041 to initialize 'resolved' to false only for explicit
13667 blocks. Fixes #74873.
13669 2005-05-12 Raja R Harinath <harinath@gmail.com>
13672 * typemanager.cs (unmanaged_enclosing_types): New.
13673 (IsUnmanagedType): Avoid infloops by using
13674 'unmanaged_enclosing_types' to talk with recursive invocations.
13676 2005-05-13 Martin Baulig <martin@ximian.com>
13678 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13679 instance variable, not a local. Fix #74873.
13680 (Block.ResolveUnreachable): Set it to true here.
13682 2005-05-11 Duncan Mak <duncan@novell.com>
13684 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13685 continuing to process for 'arg'.
13686 (handle_preprocessing_directive): Check the argument of the #endif
13687 directive and report error CS1025 if there are any trailing
13690 According to the C# spec, having even whitespace after the #endif
13691 directive is illegal; however, because we call arg.TrimEnd ()
13692 beforehand, we have the same behavior as csc, allowing whitespace
13693 after the directive.
13697 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13701 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13702 (Constructor.GetObsoleteAttribute): Implemented correctly.
13704 2005-05-10 Martin Baulig <martin@ximian.com>
13706 * support.cs (ReflectionParameters.ParameterModifier): Use
13707 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13708 and `ParameterAttributes.In'. Fixes #74884.
13710 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13712 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13714 * expression.cs (Argument.GetParameterModifier): Turned to property.
13715 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13717 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13720 2005-05-09 Raja R Harinath <rharinath@novell.com>
13723 * decl.cs (MemberCache.AddMethods): Register override methods,
13724 rather than non-override methods.
13725 * typemanager.cs (RegisterOverride): New.
13726 (IsOverride): Update.
13728 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13732 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13733 recursive declaration.
13735 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13737 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13739 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13741 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13743 2005-05-05 Raja R Harinath <rharinath@novell.com>
13746 * decl.cs (DeclSpace.FamilyAccessible):
13747 Use TypeManager.IsNestedFamilyAccessible.
13749 Fix reopened #64812.
13750 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13753 2005-05-04 Raja R Harinath <rharinath@novell.com>
13754 Abin Thomas <projectmonokochi@rediffmail.com>
13755 Anoob V E <projectmonokochi@rediffmail.com>
13756 Harilal P R <projectmonokochi@rediffmail.com>
13759 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13760 allow access to all static members.
13762 2005-05-04 Martin Baulig <martin@ximian.com>
13764 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13766 2005-05-04 Martin Baulig <martin@ximian.com>
13770 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13771 section at the end; make things work if `default' is not the last
13774 2005-05-04 Martin Baulig <martin@ximian.com>
13778 * statement.cs (Switch): Replaced the `got_default' field with a
13779 `default_section' one.
13780 (Switch.CheckSwitch): Set `default_section' here.
13781 (Switch.Resolve): If we're a constant switch and the constant is
13782 not found, use the default section.
13784 2005-05-03 Martin Baulig <martin@ximian.com>
13786 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13788 * statement.cs (Foreach.ArrayForeach): New nested class.
13789 (Foreach.TemporaryVariable): New nested class.
13790 (Foreach.EmitArrayForeach): Removed; this is now in the new
13791 ArrayForeach class.
13793 2005-05-03 Raja R Harinath <rharinath@novell.com>
13795 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13797 (VerifyPendingMethods): Revert change below.
13799 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13800 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13801 that used to trigger warning -28. Remove warning -28.
13802 * expression.cs (Invocation.OverloadResolve): Use
13803 TypeManager.IsOverride to distinguish override methods.
13806 * pending.cs (VerifyPendingMethods): If a base type implements the
13807 requested interface, don't bother checking individual methods of
13808 the base type. As a side-effect, this prevents the creation of
13809 unnecessary proxies.
13811 2005-05-02 Martin Baulig <martin@ximian.com>
13815 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13816 Also `And' the locals if the old vector is null.
13817 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13818 null; in this case we basically reset all the variables.
13820 2005-05-02 Martin Baulig <martin@ximian.com>
13824 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13825 Added `FlowBranching branching' argument; always `and' the
13826 variables instead of `or'ing them unless we're an infinite loop.
13828 * statement.cs (While.Resolve): Create a new sibling unless we're
13831 2005-05-02 Martin Baulig <martin@ximian.com>
13835 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13836 arguments; use it instead of creating a new TopLevelBlock.
13837 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13838 our ConstructorInitializer.
13841 (TopLevelBlock.TopLevelBranching): New public property.
13842 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13843 and create our `TopLevelBranching'.
13845 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13846 anonymous method host, use `block.TopLevelBranching' rather than
13847 creating a new branching.
13849 2005-04-20 Miguel de Icaza <miguel@novell.com>
13851 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13852 a ScopeInfo, if any of the current children is a child of the new
13853 entry, move those children there.
13855 2005-04-30 Martin Baulig <martin@ximian.com>
13857 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13858 at the beginning of a SwitchSection. Fix #73335.
13860 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13863 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13865 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13866 (FieldExpr.DoResolve): Obsolete members are ignored for field
13869 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13871 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13872 of arrays detection.
13874 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13876 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13878 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13881 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13883 * cs-parser.jay: Use the prefered version of -unsafe in error
13886 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13888 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13891 2005-04-20 John Luke <john.luke@gmail.com>
13893 * driver.cs: fix typo in error message, --outout to --output
13895 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13897 * codegen.cs (InRefOutArgumentResolving): New field.
13899 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13900 fields outside contructor.
13902 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13904 2005-04-19 Miguel de Icaza <miguel@novell.com>
13906 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13907 parameter code was not completed ever, so it was not as up-to-date
13908 as local variables. Must finish it.
13910 The bug fix was to compare the Toplevel of the block, not the
13911 current block. Thanks for Ben for pointing this out.
13913 2005-04-19 Raja R Harinath <rharinath@novell.com>
13915 * decl.cs (AddMethods): Use the declaring type of the problem
13916 method to determine if we want to squash a warning.
13918 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13920 * attribute.cs: Removed debug output.
13922 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13924 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13927 2005-04-18 Raja R Harinath <rharinath@novell.com>
13930 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13931 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13932 all null comparisons against reference types.
13934 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13937 * class.cs (TypeContainer.CircularDepException) New nested
13939 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13940 (TypeContainer.DefineType): Removed error, reset InTransit before
13942 (Class.DefineType): Throw exception when is in Transit.
13943 Catch exception and report error.
13944 (Struct.DefineType): Throw exception when is in Transit.
13945 Catch exception and report error.
13946 (Interface.DefineType): Throw exception when is in Transit.
13947 Catch exception and report error.
13949 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13950 handle nested exception handlers.
13952 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13955 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13956 InFinally and InCatch storage.
13958 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13959 (Catch.Resolve): Set and Restore ec.InCatch.
13960 (Try.Resolve): Set and Restore ec.InFinally.
13961 (Try.HasCatch): True when try has catch.
13963 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13965 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13966 for the same event member, so exclude such cases from warning 419.
13969 2005-04-16 Miguel de Icaza <miguel@novell.com>
13971 * expression.cs (Binary.ResolveOperator): Apply patch from John
13972 Luke to fix bug 59864: operators &, | and ^ on enumerations
13973 require that the same enum type on both sides.
13975 * driver.cs: Add warnings to old flag usage, this is to assist
13976 people who produce Makefiles and hope that the Makefiles will be
13979 * class.cs (TypeContainer.EmitType): Moved the definition of the
13980 special $PRIVATE$ field from the resolve phase to the Emit phase.
13981 During resolve we do not know if we are a struct with
13982 HasExplicitLayout, we know this only after the attributes for the
13985 Set the FieldOffset to zero on the dummy field that we create for
13986 the class. Fixes 74590.
13988 2005-04-16 Raja R Harinath <rharinath@novell.com>
13991 * ecore.cs (PropertyExpr.resolved): New.
13992 (DoResolve): Use it to handle a case of double resolution here.
13993 Handle a case of identical-name-and-type-name.
13994 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13995 resolution by storing the results of expression resolution back
13996 into the "probes" array.
13998 2005-04-15 Raja R Harinath <rharinath@novell.com>
14000 Fix cs0208-7.cs and cs0208-8.cs.
14001 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14002 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14003 error reporting to point out the reason a struct is not unmanaged.
14005 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14007 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14008 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14010 2005-04-13 Raja R Harinath <rharinath@novell.com>
14013 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14014 IdenticalNameAndTypeName here.
14015 (EventExpr.InstanceResolve): Likewise.
14017 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14019 C# 2.0 DefaultCharSetAttribute implementation
14021 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14022 which allows us to set GlobalNamespace for every resolve.
14023 (Attribute.ResolveArguments): Cut from Resolve.
14024 (Attribute.GetCharSetValue): Returns CharSet named argument.
14025 (Attribute.DefinePInvokeMethod): Gets default charset from
14027 (GlobalAttribute.ResolveAsTypeStep): Override.
14028 (GlobalAttribute.ResolveArguments): Override.
14030 * class.cs (TypeAttr): Is protected.
14032 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14033 (ModuleClass.DefaultCharSetType): New memeber.
14034 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14036 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14037 charset from module.
14039 * delegate.cs (TypeAttr): Override.
14040 (Delegate.DefineType): Use this TypeAttr.
14042 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14043 at very early stage (before types are defined) to resolve model
14044 module attributes. It will probably not work with corlib but it
14047 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14048 charset from module.
14050 * typemanager.cs (default_charset_type): New type.
14052 2005-04-13 Raja R Harinath <rharinath@novell.com>
14054 * decl.cs (MemberCache.AddMethods): Don't warn if
14055 System.Object.Finalize has buggy MethodAttributes.
14057 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14060 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14062 * doc.cs : detect ambiguous reference to overloaded members.
14063 Fixed bug #71603. MS 1.1 csc does not detect it.
14065 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14067 * doc.cs : delegates must not be referenced with parameters.
14070 2005-04-12 Miguel de Icaza <miguel@novell.com>
14072 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14074 2005-04-10 Miguel de Icaza <miguel@novell.com>
14076 * driver.cs (MainDriver): Stop processing if the CLS stage found
14079 (CompilerCallableEntryPoint.InvokeCompiler): Always
14080 reset after execution; Take a TextWriter argument for the
14083 * report.cs: Use the error stream instead of hardcoding stderr.
14085 2005-04-09 Miguel de Icaza <miguel@novell.com>
14087 * class.cs: Reduce code paths to test, too small of an
14088 optimization to make it worth the extra testing. Always perform
14091 2005-04-08 Raja R Harinath <rharinath@novell.com>
14094 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14095 operators that had errors reported on them.
14097 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14099 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14101 (Attribute.Resolve): Add named argument type checking.
14103 * class.cs (FixedField.Define): Use IsPrimitiveType
14105 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14107 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14108 unsafe parameter types.
14110 * statement.cs (Using.ResolveExpression): Add better error description.
14112 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14114 2005-04-08 Raja R Harinath <rharinath@novell.com>
14117 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14118 AttributeUsageAttribute in the emitcontext of the attribute class,
14119 not in the emitcontext of the attributable entity it was attached to.
14120 * cs-parser.jay: Use 'current_class', not 'current_container',
14121 when creating a GlobalAttribute.
14123 2005-04-08 Alp Toker <alp@atoker.com>
14125 * pending.cs: The fix to #58413 failed to compile methods implementing
14126 interfaces with/without params modifiers and vice versa, even though
14127 params modifiers aren't part of the signature. Make the modifier check
14128 less strict as in csc.
14130 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14131 Anoob V E <projectmonokochi@rediffmail.com>
14132 Harilal P R <projectmonokochi@rediffmail.com>
14135 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14136 modifiers of pending methods.
14137 (PendingImplementation.PendingImplementation): Initialize it.
14138 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14139 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14140 with ParameterData. Add check for modifiers.
14141 * class.cs (MethodData.Define): Update to changes.
14143 2005-04-07 Raja R Harinath <rharinath@novell.com>
14145 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14147 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14149 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14152 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14155 * typemanager.cs: Registered RequiredAttributeAttribute.
14157 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14159 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14160 Warning CS0169 is back at level 3.
14161 (IMethodData.SetMemberIsUsed): New method.
14163 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14164 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14166 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14168 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14170 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14173 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14176 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14177 to avoid the problems with nested types.
14179 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14180 Anoob V.E <projectmonokochi@rediffmail.com>
14181 Harilal P.R <projectmonokochi@rediffmail.com>
14182 Raja R Harinath <rharinath@novell.com>
14185 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14187 * typemanager (GetConstructor): Make public.
14189 2005-04-05 John Luke <john.luke@gmail.com>
14190 Raja R Harinath <rharinath@novell.com>
14193 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14194 struct too. Return false quicker in a few cases.
14195 (VerifyUnManaged): Use it.
14197 2005-04-05 Raja R Harinath <rharinath@novell.com>
14200 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14201 not 'unreachable_seen'.
14203 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14205 * attribute.cs (Attribute.GetValue): Removed unused.
14207 * codegen.cs (CodeGen.TrimExt): Removed unused.
14209 * cs-parser.jay (output): Removed unused.
14211 * cs-tokenizer.cs (hex_digits): Removed unused.
14213 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14215 * expression.cs (Indirection.LoadExprValue): Removed unused.
14216 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14218 * iterators.cs (Iterator.param_types): Removed unused.
14220 * statement.cs (Goto.block): Removed unused.
14221 (ToplevelBlock.did): Removed unused.
14222 (Switch.ResolveConstantSwitch): Removed unused.
14224 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14226 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14229 2005-04-01 Raja R Harinath <rharinath@novell.com>
14231 Fix #74232 and cs0208-3.cs.
14232 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14233 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14234 unmanaged type. Don't use FieldBuilders when 't' is a
14235 TypeBuilder. Use ModFlags and MemberType fields.
14236 * class.cs (MemberBase.member_type): Rename from MemberType.
14237 (MemberBase.MemberType): New property. Determines member_type on
14239 (MemberBase.DoDefine): Don't initialize MemberType here.
14240 (FieldMember.Define): Likewise.
14242 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14245 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14246 Attributes are emitted there.
14248 2005-04-01 Raja R Harinath <rharinath@novell.com>
14250 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14251 keyword in 'partial enum' too.
14252 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14254 Report from Kamil Skalski <nazgul@omega.pl>.
14257 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14258 have partial containers too.
14260 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14261 in block' checks to Block.CheckInvariantMeaningInBlock.
14262 * statement.cs (Block.GetKnownVariableInfo): Make private.
14263 (Block.IsVariableUsedInChildBlock): Remove.
14264 (Block.IsVariableUsedInBlock): Likewise.
14265 (Block.CheckInvariantMeaningInBlock): New. Show location of
14266 conflicting declaration.
14267 (Block.AddVariable): Make error messages less long-winded and more
14268 specific. Show location of conflicting declaration.
14269 * parameter.cs (Parameters.Location): New readonly property.
14271 2005-03-31 Raja R Harinath <rharinath@novell.com>
14273 Clean up semantics of invoking ResolveMemberAccess.
14274 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14275 can have an instance, ensure that we pass in a non-TypeExpression
14276 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14277 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14278 argument. Update to changes and simplify.
14279 (FieldExpr.Emitinstance): Remove CS0120 check.
14280 (PropertyExpr.EmitInstance): Likewise.
14281 * expression.cs (Argument.Resolve): Likewise.
14282 (Invocation.DoResolve): Update to changes in semantics of
14283 InstanceExpression.
14285 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14288 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14291 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14293 2005-03-31 Raja R Harinath <rharinath@novell.com>
14295 Fix difference in behaviour with commandline invocation.
14296 * driver.cs (Driver.Reset): New.
14297 (CompilerCallableEntryPoint): Call it.
14299 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14300 variable" warnings if the boolean expression failed to resolve.
14302 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14304 * attribute.cs: Fix the union of several permissions when some of them
14305 are unrestricted (so the result isn't an unrestricted permission set).
14308 2005-03-30 Raja R Harinath <rharinath@novell.com>
14310 * ecore.cs (MemberExpr): New class. Convert from interface
14312 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14313 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14315 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14316 (MethodGroupExpr.IsExplicitImpl): Remove.
14317 (Expression.GetFieldFromEvent): Remove.
14318 (SimpleName.MemberStaticCheck): Remove.
14319 (SimpleName.DoSimpleNameResolve): Update to changes.
14320 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14321 (MemberAccess.IdenticalNameAndTypeName): Remove.
14322 (MemberAccess.error176): Move to MemberExpr.
14323 (MemberAccess.DoResolve): Update to changes.
14324 (BaseAccess.DoResolve): Likewise.
14326 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14328 C# 2.0 Conditional attribute class implementation
14330 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14331 Analyzes class whether it has attribute which has ConditionalAttribute
14332 and its condition is not defined.
14334 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14335 (Class.IsExcluded): New method. Search for at least one defined
14336 condition in ConditionalAttribute of attribute class.
14338 2005-03-30 Raja R Harinath <rharinath@novell.com>
14340 * ecore.cs (PropertyExpr): Derive from Expression, not
14341 ExpressionStatement.
14342 (PropertyExpr.EmitStatement): Remove.
14344 2005-03-29 Raja R Harinath <rharinath@novell.com>
14347 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14348 internal field "value__" of an enum be private. The examples for
14349 "value__" that I found on MSDN all used FieldAttributes.Private.
14351 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14352 Don't mention IL method attribute names.
14354 Fix #47991. Remove a TODO.
14355 * statement.cs (Block.Toplevel): Make into a field.
14356 (Block.Parameters): Move into ToplevelBlock.
14357 (Block.known_variables): Rename from child_variable_names.
14358 (Block.Block): Remove variants that take Parameters. Initialize
14359 'Toplevel' with the immediately surrounding toplevel block.
14360 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14361 LocalInfo parameter.
14362 (Block.GetKnownVariableInfo): New.
14363 (Block.IsVariableNameUsedInChildBlock): Update.
14364 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14365 the block, even though it may not be in scope.
14366 (Block.AddVariable): Remove Parameters parameter. Use
14367 Toplevel.Parameters instead.
14368 (Block.AddConstant): Remove Parameters parameter.
14369 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14370 (Block.IsParamaterReference): Likewise.
14371 (Block.IsLocalParameter): Likewise. Simplify a lot.
14372 (ToplevelBlock.Parameters): New. Moved from Block.
14373 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14374 initialize Parameters to a non-null value.
14375 * cs-parser.jay: Update to changes.
14376 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14377 simple names that mean different things in the same block. Use
14378 Block.IsVariableNameUsedInBlock.
14380 2005-03-28 Raja R Harinath <rharinath@novell.com>
14382 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14383 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14384 GetTypeHandle. It is possible for a reflected type to derive from
14385 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14386 System.Array during mscorlib compilation).
14387 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14388 contain a method_hash, don't create one either. Don't create a
14389 deep copy of the base cache's method_hash.
14390 (MemberCache.SetupCache): Rename back from DeepCopy.
14391 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14392 already initialized. If we see an override function, add its
14393 underlying base virtual function to the member_hash too.
14395 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14397 2005-03-26 Raja R Harinath <harinath@acm.org>
14400 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14401 fails to resolve, ensure that the LHS is still resolved as an
14404 2005-03-25 Raja R Harinath <harinath@acm.org>
14406 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14408 (Enum.current_ec): Remove.
14409 (Enum.LookupEnumValue): Remove EmitContext argument.
14410 Just uses the one created during DefineType.
14411 (Enum.FindMembers): Update.
14412 * expression.cs (MemberAccess.DoResolve): Update.
14414 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14416 * assign.cs (Assign.DoResolve): Check for CS1717 when
14417 source and target are same (uses Equals).
14419 * expression.cs (LocalVariableReference, ParameterReference,
14420 This): Implemented Equals, GetHashCode.
14422 * statement.cs (Block.GetParameterReference): Removed useless
14425 2005-03-22 Raja R Harinath <rharinath@novell.com>
14428 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14429 blocks before deciding whether the error is cs0136 or cs0128.
14431 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14432 (using_alias_directive, using_namespace_directive): Pass
14433 MemberName, not an expression to Namespace.UsingAlias and
14435 (MakeName): Use the MemberName of the namespace.
14436 * namespace.cs (Namespace.MemberName): New.
14437 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14438 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14440 * decl.cs (MemberName.Name): Make readonly.
14441 (MemberName.FromDotted): New "constructor".
14442 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14443 (MemberCore.Name): Compute from MemberName on demand.
14444 (MemberCore.SetMemberName): Provide a way to change the
14446 (MemberCore.AddToContainer): Don't take a fullname parameter.
14447 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14448 fully qualified name of the container to the member name.
14449 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14450 only if the type is a member of the root container.
14451 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14452 MemberName.Left rather than searching for an embedded ".".
14453 (PartialContainer.CreatePart): Update to changes in RootContext.
14454 (MemberBase.ShortName): Turn into a property. Use
14455 MemberCore.SetMemberName.
14456 (MemberBase.ExplicitInterfaceName): Remove.
14457 (MemberBase.UpdateMemberName): Remove.
14458 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14459 (PropertyBase.SetMemberName): New override.
14460 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14461 (Tree.GetDecl): New.
14462 (Tree.AllDecls): Rename from Decls.
14463 * attribute.cs, enum.cs, report.cs: Update to changes.
14464 * driver.cs (MainDriver): Use MemberName.FromDotted on
14465 RootContext.MainClass.
14467 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14469 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14472 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14474 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14476 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14477 property accessor modifiers.
14479 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14480 fixed buffer attribute (CS1716).
14481 (PropertyMethod.HasCustomAccessModifier): When property accessor
14482 has custom modifier.
14484 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14486 (PropertyExpr.DoResolveLValue): Add CS0272.
14488 2005-03-17 Miguel de Icaza <miguel@novell.com>
14490 * convert.cs: When converting to a pointer, use the proper Conv.U
14491 or Conv.I depending on the source data type.
14493 * cs-tokenizer.cs: Make the size for large decimal constants,
14496 2005-03-17 Martin Baulig <martin@ximian.com>
14498 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14499 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14501 2005-03-17 Martin Baulig <martin@ximian.com>
14503 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14504 to bool so we can return an error condition.
14505 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14508 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14510 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14513 2005-03-16 Raja R Harinath <rharinath@novell.com>
14515 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14516 Refactor to avoid traversing the list of assemblies, and to avoid
14517 string concatenation.
14518 * typemanager.cs (guid_attr_type): Remove.
14519 (negative_hits, pointers, references): Remove hashes.
14521 (GetConstructedType): New. Uses type_hash to handle constructed
14522 types (arrays, references, pointers).
14523 (GetReferenceType, GetPointerType): Use it.
14524 (GetNestedType): New. Uses type_hash to handle nested types of
14526 (LookupType, LookupTypeDirect): Remove.
14527 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14528 'types' hash and LookupTypeReflection directly.
14529 (params_string, params_object): Use GetConstructedType.
14530 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14532 (Namespace.Lookup): Use cached_types.
14533 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14534 provided by old TypeManager.LookupType.
14535 * rootcontext.cs (MakeFQN): Remove.
14536 * decl.cs (DeclSpace.MakeFQN): Likewise.
14537 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14538 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14539 TypeManager.GetConstructedType.
14540 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14542 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14544 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14547 * cs-parser.jay: Reports CS1527 for any namespace element.
14549 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14552 * expression.cs (ParameterReference.IsAssigned): Changed error to
14554 (Error_WrongNumArguments): Moved CS0245 detection here.
14556 * statement.cs (Return.Resolve): Add CS1622 report.
14558 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14560 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14562 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14564 * attribute.cs expression.cs: Get rid of some allocations.
14566 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14568 * doc.cs : just eliminate the latest change.
14570 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14572 * doc.cs : commented out the latest change. It breaks xml-030.cs
14574 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14576 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14577 fail. So invoke CreateType() in FindDocumentedType().
14579 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14581 * cs-tokenizer.cs : added IsKeyword().
14582 * doc.cs : Detect keyword incorrectly used as identifier.
14583 Allow identifiers prefixed by @.
14585 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14587 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14588 It caused exception in namespace resolving (again!).
14590 * class.cs (Class.ctor): Removed exit.
14591 (PropertyMethod.ctor): ditto.
14593 * codegen.cs (Codegen.Reset): Reset static data.
14594 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14596 * cs-tokenizer.cs (Cleanup): Removed.
14598 * driver.cs (GetSystemDir): Rewrote to one line command.
14599 It caused problem with unloaded dynamic modules.
14600 (UnixParseOption): Removed Exit.
14601 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14602 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14603 Now can be mcs used as library.
14605 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14608 * location.cs (Reset): Reset static data.
14610 * namespace.cs (Reset): Reset static data.
14612 * report.cs (Report.Reset): Reset static data.
14614 * rootcontext.cs (RootContext.Reset): Reset static data.
14616 * tree.cs (RootTypes.ctor): Use Location.Null
14618 * typemanager.cs (TypeManager.Reset): Reset static data.
14619 (CoreLookupType): Removed Exit.
14620 (TypeHandle.Reset): Reset static data.
14622 2005-03-10 Raja R Harinath <rharinath@novell.com>
14625 * typemanager.cs (ComputeNamespaces): Import namespaces from
14626 referenced modules too.
14628 2005-03-09 Raja R Harinath <rharinath@novell.com>
14630 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14633 2005-03-09 Raja R Harinath <rharinath@novell.com>
14635 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14636 enclosing DeclSpace. This ensures that a name-lookup populates
14637 more caches and there are fewer 'TypeExpression's. Carve out
14638 nested type lookup into ...
14639 (LookupNestedTypeInHierarchy): ... this.
14641 2005-03-09 Raja R Harinath <rharinath@novell.com>
14643 Clean up a few partial-class semantics.
14644 Fixes test-357.cs and cs1618-2.cs.
14645 * cs-parser.jay (struct_declaration): Use 'current_class' as
14646 parent of newly-created struct. Remove call to Register ().
14647 Use 'pop_current_class' to complete handing the current struct.
14648 (interface_declaration): Likewise.
14649 (class_declaration): Likewise.
14650 (enum_declaration): Use 'current_class' as parent of newly created
14652 (delegate_declaration): Likewise.
14653 (pop_current_class): New function. This is used to handle closing
14654 up the 'current_class' and 'current_container', and pointing them
14655 to the enclosing class/container.
14656 (CSharpParser): Initialize 'current_class' too.
14657 * decl.cs (MemberCore): Add check for invariant: a partial
14658 container is not a parsed entity, and thus does not enclose any
14660 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14661 (DeclSpace.BaseTypeExpr): Use it.
14662 (DeclSpace.LookupType): Add check for invariant.
14663 * class.cs (TypeContainer): Add check for invariant: a nested
14664 class should have the same NamespaceEntry as its enclosing class.
14665 (TypeContainer.EmitFieldInitializers): Make virtual.
14666 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14668 (TypeContainer.Register): Remove.
14669 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14670 null. Use TypeResolveEmitContext for resolving base types and
14671 interfaces. Move initialization of Parts.TypeBuilder here from
14673 (TypeContainer.DefineNestedTypes): ... here.
14674 (PartialContainer): Take a Namespace not a NamespaceEntry.
14675 (PartialContainer.Create): Don't use Register. Call the
14676 appropriate Add... function directly.
14677 (ClassPart): Take both the PartialContainer and the enclosing
14678 class as constructor arguments.
14679 (ClassPart.EmitFieldInitializers): Override.
14680 (ClassPart.PartFindNestedTypes): Remove.
14681 (FieldBase.GetInitializerExpression): Resolve the initializer
14682 expression in the emit context of the enclosing class.
14683 * tree.cs (RootTypes): Remove Register ().
14685 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14687 * cs-parser.jay: Removed CS0134.
14689 * driver.cs: Removed CS1901.
14691 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14692 for predefined types.
14694 2005-03-07 Duncan Mak <duncan@novell.com>
14696 * codegen.cs (Save): Catch UnauthorizedAccessException as
14697 well. Fixes bug #73454.
14699 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14701 * cs-tokenizer.cs (xtoken): Add CS1035.
14703 * class.cs (MethodData.Define): Add CS0683.
14704 (FieldMember.ctor): Add CS0681.
14706 2005-03-07 Raja R Harinath <rharinath@novell.com>
14708 * ecore.cs (SimpleName.DoResolve): Rename from
14709 SimpleName.DoResolveAllowStatic.
14710 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14711 Pass 'intermediate' flag to MemberStaticCheck.
14712 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14713 of "intermediate" lookups via MemberAccess.
14714 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14715 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14717 2005-03-07 Raja R Harinath <rharinath@novell.com>
14720 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14721 slipped in because of variable names that are identical to a
14722 builtin type's BCL equivalent ('string String;', 'int Int32;').
14723 (PropertyExpr.EmitInstance): Likewise.
14725 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14727 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14729 * report.cs (warning_ignore_table): Made public.
14731 2005-03-04 Raja R Harinath <rharinath@novell.com>
14734 * class.cs (MethodData.Emit): Pass 'container' to
14735 container.GetObsoleteAttribute instead of 'container.Parent'.
14737 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14739 * cs-parser.jay: Add 1534 error test.
14741 * iterators.cs (Yield.CheckContext): Add error 1629.
14742 (Iterator.ctor): Save unsafe modifier.
14743 (MoveNextMethod.DoEmit): Restore unsafe context.
14745 * namespace.cs (UsingAlias): Better error message.
14747 2005-03-03 Dan Winship <danw@novell.com>
14749 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14750 the warning message [#73219]
14752 2005-03-03 Raja R Harinath <rharinath@novell.com>
14754 Fix compile with MCS 1.0.0.0.
14755 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14756 w_restore to not depend on string constant folding.
14758 2005-03-03 Raja R Harinath <rharinath@novell.com>
14760 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14761 CS0246 check to users who passed 'silent = false'.
14762 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14764 (SimpleName.SimpleNameResolve): Update.
14765 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14766 (MemberAccess.IdenticalNameAndTypeName): Update.
14767 * doc.cs (FindDocumentedTypeNonArray): Update.
14769 2005-03-03 Raja R Harinath <rharinath@novell.com>
14771 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14772 * parameters.cs (ComputeAndDefineParameters): Remove.
14773 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14774 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14775 Use GetParameterInfo.
14777 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14779 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14781 2005-03-02 Raja R Harinath <rharinath@novell.com>
14783 Unify DeclSpace.LookupType and DeclSpace.FindType.
14784 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14785 is in charge of defining nested types on demand.
14786 (DeclSpace.LookupType): Use it when the current_type is a
14787 TypeBuilder. Use LookupTypeDirect for reflected types.
14788 (DeclSpace.FindType): Remove.
14789 (DeclSpace.LookupInterfaceOrClass): Likewise.
14790 (DeclSpace.DefineTypeAndParents): Likewise.
14791 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14792 DeclSpace.LookupType.
14793 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14794 * typemanager.cs (LookupType): Simplify.
14795 (AddUserType): Remove type from negative_hits.
14796 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14797 * class.cs (TypeContainer.FindMembers): Move handling of nested
14799 (TypeContainer.FindMembers_NestedTypes): ... here.
14800 (TypeContainer.FindNestedType): Implement override.
14801 (ClassPart.FindNestedType): Delegate to PartialContainer.
14802 (ClassPart.PartFindNestedType): Looks up the nested types of the
14805 2005-03-02 Martin Baulig <martin@ximian.com>
14807 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14808 static constructor in static classes.
14810 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14812 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14813 sizeParamIndex is not specified.
14815 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14818 * report.cs (WarningMessage.IsEnabled): Missing null check.
14820 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14822 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14823 in the fields and not in the properties.
14825 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14827 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14830 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14832 * attribute.cs: Small refactoring (improved robustness).
14833 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14834 (ValidateGuid): Removed.
14835 (Resolve): Removed referenced to above mentioned.
14836 (GetAttributeUsage): Made private and changed to work without
14838 (GetIndexerAttributeValue): Don't crash.
14839 (GetConditionalAttributeValue): Ditto.
14840 (GetClsCompliantAttributeValue): Ditto.
14841 (ExtractSecurityPermissionSet): All attributes exceptions are
14843 (GetPropertyValue): New helper.
14844 (GetMethodImplOptions): New method.
14845 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14846 some missing properties.
14848 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14849 (Method.ApplyAttributeBuilder): Updated.
14851 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14854 2005-02-28 Raja R Harinath <rharinath@novell.com>
14857 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14858 non-simple types (array, pointer, reference).
14860 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14862 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14864 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14866 (Method.CheckBase): Catch wrong destructor here.
14867 (MethodData.Define): Add errors 550, 668.
14869 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14871 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14873 * pending.cs (VerifyPendingMethods): Add error 551.
14875 * typemanager.cs (CSharpName): Next error report helper.
14877 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14879 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14880 attributes. Removed useless attribute double check.
14881 It saves almost 2MBs for corlib.
14883 2005-02-25 Raja R Harinath <rharinath@novell.com>
14886 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14887 called twice in case of error.
14889 2005-02-23 Chris Toshok <toshok@ximian.com>
14891 Fix compiler portions of #72827.
14892 * statement.cs (Block.Emit): call Begin/EndScope on the
14893 EmitContext instead of the ILGenerator.
14895 * codegen.cs (EmitContext.BeginScope): new method, call
14896 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14898 (EmitContext.BeginScope): same, but EndScope and CloseScope
14900 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14901 offset and call the superclass's OpenScope(int) with it.
14902 (SymbolWriter.CloseScope): get the current il
14903 offset and call superclass's CloseScope(int) with it.
14905 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14907 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14908 CS1677 for out and ref as well.
14910 * class.cs (Method.Define): Add error CS1599 detection.
14912 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14914 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14916 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14918 * support.cs.cs (ModifierDesc): New helper method.
14920 2005-02-23 Raja R Harinath <rharinath@novell.com>
14921 Abin Thomas <projectmonokochi@rediffmail.com>
14922 Anoob V E <projectmonokochi@rediffmail.com>
14923 Harilal P R <projectmonokochi@rediffmail.com>
14925 Fix #57851, #72718.
14926 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14927 MemberLookup (used for error reporting) actually returns a result.
14928 Fix error report number (122, not 112).
14930 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14931 Anoob V E <projectmonokochi@rediffmail.com>
14932 Harilal P R <projectmonokochi@rediffmail.com>
14935 * pending.cs (PendingImplementation.GetAbstractMethods):
14936 Find NonPublic members too.
14938 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14940 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14943 * class.cs (MethodCore.CheckMethodAgainstBase):
14944 Add error 239 report.
14946 2005-02-21 Raja R Harinath <rharinath@novell.com>
14949 * expression.cs (Invocation.IsApplicable): Make public.
14950 (Invocation.IsParamsMethodApplicable): Likewise.
14951 * delegate.cs (Delegate.VerifyApplicability): Don't use
14952 Invocation.VerifyArgumentCompat for parameter applicability
14953 testing. Use Invocation.IsApplicable and
14954 Invocation.IsParamsMethodApplicable.
14956 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14958 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14960 * class.cs (Operator.Define): Add error 217 report.
14962 2005-02-21 Raja R Harinath <rharinath@novell.com>
14964 * namespace.cs (UsingEntry.Resolve): Undo change below.
14966 2005-02-21 Raja R Harinath <rharinath@novell.com>
14969 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14970 disable the error message when the extended MemberLookup also
14972 (Expression.MemberLookupFinal): Update.
14973 (SimpleName.DoSimpleNameResolve): Update.
14974 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14975 Don't use MemberLookupFinal.
14976 (New.DoResolve): Update.
14977 (BaseAccess.CommonResolve): Update.
14979 2005-02-21 Raja R Harinath <rharinath@novell.com>
14982 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14983 occured previously, don't resolve again.
14985 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14988 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14989 argument. Call ResolveAttributeUsage for unresolved.
14990 when types doesn't match ctor arguments.
14992 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14993 for nested attribute classes.
14994 (Class.attribute_usage): Removed.
14995 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14996 for attribute class.
14998 * ecore.cs (IsAttribute): Removed.
15000 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15002 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15004 (attribute_types): Removed.
15005 (EmitCode): Global attributes are emited as the latest.
15007 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15009 * class.cs (EmitFieldInitializers): Don't emit field initializer
15010 for default values when optimilization is on.
15012 * constant.cs (Constant.IsDefaultValue): New property.
15014 * driver.cs: Add /optimize handling.
15018 * literal.cs: Implement new IsDefaultValue property.
15020 * rootcontext.cs (Optimize): New field, holds /optimize option.
15022 2005-02-18 Raja R Harinath <rharinath@novell.com>
15024 Fix crasher in re-opened #72347.
15025 * namespace.cs (Namespace.Lookup): Return null if
15026 DeclSpace.DefineType returns null.
15029 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15031 2005-02-18 Raja R Harinath <rharinath@novell.com>
15033 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15034 now returns null if it cannot resolve to an lvalue.
15035 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15036 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15037 returned null. Remove check for SimpleName.
15038 (EventExpr.DoResolveLValue): New.
15039 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15040 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15042 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15043 avoid CS0131 error.
15044 (Unary.ResolveOperator): Move CS0211 check ...
15045 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15047 (Unary.DoResolveLValue): Simplify.
15048 (AddressOf.DoResolveLValue): New.
15049 (ArrayAccess.DoResolveLValue): New.
15051 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15053 * attribute.cs (Attribute.Resolve): Add arguments casting for
15054 when types doesn't match ctor arguments.
15056 2005-02-16 Raja R Harinath <rharinath@novell.com>
15058 Fix parts of #63202.
15059 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15060 lookup of operator in base type. Ensure that all checks happen
15061 when the operator resolves to an "op_..." method.
15063 2005-02-15 Raja R Harinath <rharinath@novell.com>
15066 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15067 'ignore_cs0104' parameter. Pass it to ...
15068 (NamespaceEntry.Lookup): ... this.
15069 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15070 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15071 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15072 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15073 Update. Request that cs0104 errors be ignored.
15074 (ComposedCast.ResolveAsTypeStep): Update.
15076 2005-02-14 Raja R Harinath <rharinath@novell.com>
15079 * expression.cs (Invocation.BetterFunction): Remove support for
15080 comparing virtual functions and their overrides.
15081 (Invocation.IsOverride): New.
15082 (Invocation.OverloadResolve): Don't consider 'override' functions
15083 during candidate selection. Store them in a lookaside list.
15084 If the selected method is a 'virtual' function, use the list to
15085 find any overrides that are closer to the LHS type.
15087 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15089 * expression.cs (New.DoResolve): Add complex core type reduction.
15090 (New.Constantify): Converts complex core type syntax like 'new int ()'
15091 to simple constant.
15093 2005-02-14 Raja R Harinath <rharinath@novell.com>
15095 * decl.cs (EntryType.EntryType): New constructor to create an
15096 updated copy of a cache entry.
15097 (MemberCache.AddMethods): Use it.
15098 (MemberCache.ClearDeclaredOnly): Remove.
15099 (MemberCache.MemberCache): Update.
15101 2005-02-11 Miguel de Icaza <miguel@novell.com>
15103 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15104 variable. This one is represents the actual low-level declaration
15105 of the method, as opposed to the semantic level `IsStatic'.
15107 An anonymous method which is hosted into a static method might be
15108 actually an instance method. IsStatic would reflect the
15109 container, while MethodIsStatic represents the actual code
15112 * expression.cs (ParameterReference): Use the new MethodIsStatic
15113 instead of IsStatic.
15115 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15116 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15117 set on the current EmitContext.
15119 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15120 resolve our casted expression as an LValue. This triggers the
15121 proper LValue processing that is later required by Assign.
15125 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15127 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15129 C# 2.0 Fixed buffer implementation
15131 * anonymous.cs: Update after RegisterHelperClass renaming.
15133 * attribute.cs (AttributeTester.fixed_buffer_cache):
15134 Cache of external fixed buffers.
15135 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15136 implementation if field is fixed buffer else null.
15139 (TypeContainer.AddField): Accept FieldMember instead of Field.
15140 (FieldBase.IsFieldClsCompliant): Extracted code from
15141 VerifyClsCompliance descendant customization.
15142 (FixedField): New class handles fixed buffer fields.
15143 (FixedFieldExternal): Keeps information about imported fixed
15145 (IFixedField): Make access to internal or external fixed buffer
15148 * cs-parser.jay: Add fixed buffer parsing.
15150 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15153 * expression.cs (Indirection): Extended implementation to accept
15154 fixed buffer field.
15155 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15156 (ElementAccess.MakePointerAccess): Get type as parameter.
15157 (DoResolve): Add fixed buffer field expression conversion.
15158 (DoResolveLValue): Ditto.
15159 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15160 (ArrayPtr): Derives from FixedBufferPtr.
15161 (ArrayPtr.Emit): Add extra emit for array elements.
15163 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15165 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15166 for compiler generated types.
15167 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15169 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15170 and consume less memory.
15171 (Fixed.Resolve): Add fixed buffer case.
15173 * typemanager.cs (compiler_generated_attr_ctor,
15174 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15175 (HasElementType): Add our own implementation to work on every
15178 2005-02-11 Miguel de Icaza <miguel@novell.com>
15180 * anonymous.cs (CaptureContext): Track whether `this' has been
15183 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15184 only captured `this' if it was implicitly done (instance
15185 methods/variables were used).
15187 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15188 `this' must be captured.
15190 2005-01-30 Miguel de Icaza <miguel@novell.com>
15192 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15193 is null it means that there has been no need to capture anything,
15194 so we just create a sibling.
15196 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15198 Just a partial fix. The other half is fairly elusive.
15200 2005-02-10 Raja R Harinath <rharinath@novell.com>
15202 Fix #52586, cs0121-4.cs.
15203 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15204 and return a hashtable.
15205 (MemberCache.ClearDeclaredOnly): New.
15206 (MemberCache.MemberCache): Update to change. Make a deep copy of
15207 the method_hash of a base type too.
15208 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15209 type methods. Overwrite entries with the same MethodHandle so
15210 that the ReflectedType is correct. The process leaves in base
15211 virtual functions and their overrides as distinct entries.
15212 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15213 matters since it was boxed in a ArrayList before.
15214 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15216 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15217 case of a virtual function and its override (choose the overload
15219 (Invocation.OverloadResolve): Avoid 'override' members during
15220 'applicable_type' calculation.
15222 2005-02-09 Raja R Harinath <rharinath@novell.com>
15224 Combine two near-redundant caches.
15225 * typemanager.cs (method_params): Rename from method_internal_params.
15226 (TypeManager.GetParameterData): New. Replace
15227 Invocation.GetParameterData.
15228 (TypeManager.LookupParametersByBuilder): Remove.
15229 * expression.cs (Invocation.method_parameter_cache): Remove.
15230 (Invocation.GetParameterData): Remove.
15232 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15235 2005-02-08 Raja R Harinath <rharinath@novell.com>
15238 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15239 TypeManager.multicast_delegate_type is null, resolve it by looking
15240 up "System.MulticastDelegate".
15241 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15243 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15244 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15245 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15248 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15249 (LabeledStatement.AddReference): New. Set 'referenced'.
15250 (Goto.Resolve): Use it.
15252 2005-02-05 John Luke <john.luke@gmail.com>
15254 * driver.cs: remove duplicate -doc line in Usage ()
15256 2005-02-04 Raja R Harinath <rharinath@novell.com>
15258 * location.cs (Location.AddFile): Fix CS2002 error report.
15260 2005-02-02 Martin Baulig <martin@ximian.com>
15262 * delegate.cs (Delegate.DefineType): Report an internal error if
15263 TypeManager.multicast_delegate_type is null. See bug #72015 for
15266 2005-02-02 Raja R Harinath <rharinath@novell.com>
15268 Fix a crasher in a variant of #31984.
15269 * const.cs (Constant.CheckBase): New override that defers the
15270 new-or-override check in case the base type hasn't been populated
15272 (Constant.Define): Ensure the new-or-override check is performed.
15274 2005-02-01 Duncan Mak <duncan@ximian.com>
15276 * const.cs (LookupConstantValue): Check that `ce' is not null
15277 before calling GetValue ().
15279 2005-02-01 Raja R Harinath <rharinath@novell.com>
15281 Fix test-334.cs (#69519).
15282 * cs-parser.jay (using_alias_directive): Pass in an expression to
15283 NamespaceEntry.UsingAlias.
15284 (using_namespace_directive): Pass in an expression to
15285 NamespaceEntry.Using.
15286 (namespace_name): Don't flatten to a string.
15287 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15288 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15290 (NamespaceEntry.UsingEntry): Likewise.
15291 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15293 (NamespaceEntry.LookupForUsing): Remove.
15294 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15296 (NamespaceEntry.Lookup): Remove support for dotted names.
15298 2005-02-01 Raja R Harinath <rharinath@novell.com>
15300 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15302 (NamespaceEntry.ImplicitParent): Compute on demand.
15303 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15304 parallels the current.
15305 (NamespaceEntry.LookupForUsing): Use it.
15306 (NamespaceEntry.Lookup): If the current namespace-entry is
15307 implicit, don't search aliases and using tables.
15309 2005-02-01 Raja R Harinath <rharinath@novell.com>
15312 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15314 (TypeContainer.BaseCache): Compute on demand.
15315 (TypeContainer.FindMembers): Define constants and types if they're
15316 not already created.
15317 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15319 * const.cs (Constant.Define): Make idempotent.
15321 2005-01-29 Miguel de Icaza <miguel@novell.com>
15323 * pending.cs: Produce better code (no nops produced by using Ldarg
15326 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15327 i - 1' it should be arg + 1.
15331 2005-01-28 Raja R Harinath <rharinath@novell.com>
15333 * attribute.cs (Attribute.CheckAttributeType): Make private
15335 (Attribute.ResolveType): Make virtual.
15336 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15337 handling of RootContext.Tree.Types.
15339 2005-01-27 Raja R Harinath <rharinath@novell.com>
15341 Update attribute-handling to use the SimpleName/MemberAccess
15343 * cs-parser.jay (attribute): Pass in an expression to the
15344 constructors of Attribute and GlobalAttribute.
15345 * attribute.cs (Attribute): Take an expression for the name.
15346 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15347 passed in attribute name expression.
15348 (Attribute.CheckAttributeType): Use it.
15349 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15350 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15351 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15352 argument to prevent error messages if the lookup fails.
15354 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15356 * expression.cs (Indirection): Implemented IVariable interface
15357 to support indirection in AddressOf operator.
15358 (PointerArithmetic.Emit): Add optimalization for case where
15359 result can be precomputed.
15361 2005-01-26 Martin Baulig <martin@ximian.com>
15363 * class.cs (TypeContainer.AttributeTargets): Return the correct
15364 AttributeTargets depending on our `Kind' instead of throwing an
15365 exception; fixes #71632.
15367 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15370 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15373 2005-01-25 Raja R Harinath <rharinath@novell.com>
15376 * expression.cs (MemberAccess.DoResolve): Don't complain with
15377 cs0572 when the LHS of a member access has identical name and type
15380 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15383 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15385 Create custom PermissionSet only for PermissionSetAttribute.
15387 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15390 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15391 delegates in static class.
15393 2005-01-24 Martin Baulig <martin@ximian.com>
15395 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15396 merging an implicit block, just use its reachability.
15398 * statement.cs (Block.Resolve): Make the unreachable code check
15399 work wrt. implicit blocks; see test-337 from #63842.
15401 2005-01-21 Alp Toker <alp@atoker.com>
15403 * cs-parser.jay: destructor_declaration's container is PartialContainer
15404 not Class when partial types are used, so use Kind prop instead of
15407 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15409 * cs-parser.jay: Improve error reporting when an interface
15410 declares new types.
15412 2005-01-20 Dick Porter <dick@ximian.com>
15414 * support.cs: SeekableStreamReader fix from Sandor Dobos
15415 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15416 chars are read. Fixes bug 70369.
15418 2005-01-20 Raja R Harinath <rharinath@novell.com>
15420 * cs-parser.jay (catch_clause): Simplify current_block handling
15423 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15425 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15426 code with ImplicitStandardConversion to handle the implicit
15427 conversion of method groups into valid delegate invocations.
15429 The problem is that in parameter handling we were using this code
15430 path. Fixes bug #64698
15432 2005-01-19 Raja R Harinath <rharinath@novell.com>
15434 * cs-parser.jay: Fix several infelicities.
15435 - Avoid assigning to the parser value stack. Code like
15436 '$3 = null' is unclean. Synthesize a value for the code block
15438 - Avoid using oob_stack for storing location information. Use ...
15439 (_mark_): ... this. New (empty) rule. Saves the current location
15441 (foreach_statement): Avoid using oob_stack for current_block
15442 handling. Use technique used in for_statement and
15443 using_statement. Synthesize a value for the code block to store
15444 additional intermediate information.
15446 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15448 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15449 of a different type is only allowed to private fields of a
15450 containing type, not on fields of a base class.
15452 See test-174.cs and error cs0122-9.cs
15454 2005-01-13 Raja R Harinath <rharinath@novell.com>
15456 Fix test-335.cs (bug #58126).
15457 * cs-parser.jay (argument): Split out non-expression parts of the
15458 rule into 'non_simple_argument'.
15459 (invocation_expression): Support parenthesized invocations with
15460 multiple arguments, and with single non-simple arguments.
15462 2005-01-13 Raja R Harinath <rharinath@novell.com>
15464 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15467 2005-01-12 Raja R Harinath <rharinath@novell.com>
15469 Fix cs0038-1.cs, cs1640-6.cs.
15470 * ecore.cs (Expression.Resolve): Remove special-case for
15471 SimpleName in error-handling.
15472 (Expression.almostMatchedMembers): Relax access permission to
15474 (Expression.MemberLookupFailed): Handle duplicates in
15475 almostMatchedMembers list.
15476 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15477 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15478 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15479 overload if the passed in MemberInfo is a MethodBase.
15481 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15484 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15485 for non-CAS & merge permission sets properly.
15487 2005-01-11 Raja R Harinath <rharinath@novell.com>
15489 Improve standard-compliance of simple name and member access
15490 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15491 * ecore.cs (FullNamedExpression): New abstract base class
15492 for Namespaces and TypeExpressions.
15493 (ResolveFlags.SimpleName): Remove.
15494 (SimpleName): Remove support for dotted names.
15495 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15496 DeclSpace.FindType and DeclSpace.LookupType.
15497 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15498 (Expression.ExprClassName): Make member function.
15499 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15500 a namespace. Remove creation of dotted "SimpleName"s.
15501 (MemberAccess.DoResolve): Likewise.
15502 * decl.cs (DeclSpace.Cache): Make private.
15503 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15504 (DeclSpace.FindType): Update.
15505 (DeclSpace.LookupType): Move here from RootContext. Return a
15506 FullNamedExpression.
15507 * namespace.cs (Namespace): Derive from FullNamedExpression
15508 so that it can be part of expression resolution.
15509 (Namespace.Lookup): Return an FullNamedExpression.
15510 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15512 * rootcontext.cs (NamespaceLookup): Remove.
15513 (LookupType): Move to DeclSpace.
15514 * attribute.cs (CheckAttributeType): Update.
15515 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15516 (FindDocumentedTypeNonArray): Likewise.
15518 2005-01-11 Raja R Harinath <rharinath@novell.com>
15520 Fix cs0509.cs, cs1632.cs.
15521 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15522 is the same as IsInterface.
15523 (TypeContainer.GetClassBases): Likewise.
15524 * statement.cs (LabeledStatement.ig): New field.
15525 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15527 (LabeledStatement.DoEmit): Check that the label was created with
15528 the same ILGenerator.
15530 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15533 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15534 accessors to its properties.
15536 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15537 from accessors to property.
15539 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15542 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15543 only for overrides.
15545 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15547 * attribute.cs: Check for null and empty strings.
15549 I have lost another battle to Paolo.
15551 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15554 * class.cs (PropertyMethod): Set Parent field in ctors.
15555 (SetMethod.InternalParameters): Add unsafe switch hack.
15556 Override MarkForDuplicationCheck where it is appropriate.
15558 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15559 It says whether container allows members with the same name.
15560 Base default is no.
15561 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15562 Removed is_method parameter.
15564 2005-01-06 Duncan Mak <duncan@ximian.com>
15566 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15567 because the previous change led to incorrect reporting of CS1032
15568 ("Cannot define/undefine preprocessor symbols after first token in
15569 file"). Instead of using `tokens_seen' as the only flag that
15570 triggers CS1040, introduce `comments_seen'. This new flag is used
15571 to signify having seen comments on the current line, so it is
15572 unset after a newline.
15574 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15576 * doc.cs : When searching for a type, find nested type too.
15577 This fixes bug #71040.
15579 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15582 - Warn missing member comment on those classes which also does not
15583 have doc comments. Fixed bug #71041.
15584 - Don't warn missing doc comment on default constructor.
15587 2005-01-06 Duncan Mak <duncan@ximian.com>
15589 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15590 comments, set `tokens_seen' to true. This allows us to detect
15591 misplaced preprocessor directives (i.e. not at the beginning of
15592 the a line, nor after whitespaces). In that case, report error
15593 CS1040. This fixes bug #56460.
15595 * cs-parser.jay (interface_member_declaration): Add checks for
15596 IsExplicitImpl, and report CS0541 error if an interface member is
15597 defined as an explicit interface declaration.
15599 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15602 * class.cs (PropertyMethod): Set Parent field in ctors.
15603 (SetMethod.InternalParameters): Add unsafe switch hack.
15605 * decl.cs (MemberCore.Parent): Cannot be readonly.
15607 2005-01-06 Raja R Harinath <rharinath@novell.com>
15609 * decl.cs (DeclSpace.ResolveType): Remove.
15610 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15611 Merge in code from ...
15612 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15613 * class.cs, enum.cs: Update to changes.
15615 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15617 * anonymous.cs: Ensure that we init the scope of our parent if it
15618 has not been initialized yet.
15620 2004-12-30 Duncan Mak <duncan@ximian.com>
15622 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15623 if field.FieldBuilder is null. Fixes #70758.
15625 * convert.cs: Fixed some typos and updated some of the comments.
15626 (ImplicitStandardConversionExists):
15627 (TryImplicitIntConversion): If `target_type' is an interface and
15628 the type of `ic' implements this interface, return true or a new
15629 BoxedCast instead of null. This fixes #70468.
15631 2004-12-29 Duncan Mak <duncan@ximian.com>
15633 * expression.cs (Argument.Emit): Check that Expr is
15634 IMemoryLocation before casting to it, and report CS1510 otherwise.
15638 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15640 * statement.cs (Block.ThisVariable): remove the recursion here, to
15641 make the --profile more sane.
15643 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15645 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15646 assembly, by JB Evain.
15648 2004-12-17 Raja R Harinath <rharinath@novell.com>
15650 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15651 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15652 "parent" refers to enclosing type/class. "base" refers to superclass.
15654 2004-12-17 Raja R Harinath <rharinath@novell.com>
15656 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15657 Ensure that we only have GlobalAttributes.
15658 * attribute.cs (Attribute.Emit): Make non-virtual.
15659 (GlobalAttribute.Emit): Remove.
15660 (Attribute.Resolve): Make virtual.
15661 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15662 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15663 the argument. Don't create one.
15664 (Attribute.GetObsoleteAttribute): Likewise.
15665 (Attribute.GetClsCompliantAttributeValue): Likewise.
15666 * class.cs, decl.cs: Update to changes.
15668 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15670 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15672 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15674 * statement.cs (Foreach.Resolve): Add error 186 report.
15676 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15678 * expression.cs (Conditional.DoResolve): Add warning 429.
15680 * statement.cs (If.Resolve): Add warning 665.
15682 2004-12-16 Raja R Harinath <rharinath@novell.com>
15684 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15685 except when in the parser, and in GlobalAttribute.
15686 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15687 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15688 RootContext.Tree.Types.NamespaceEntry once work is done.
15689 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15690 and resets RootContext.Tree.Types.NamespaceEntry.
15692 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15694 * cs-parser.jay: Don't create a block for every variable.
15696 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15698 * location.cs: Provide extra information.
15700 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15701 variables from the captured environment, it is the ldarg_0.
15703 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15705 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15708 * class.cs: Changed warning level for 169 to avoid developer
15709 displeasure from warning flooding. It will be changed back when they
15710 fix most of current BCL warnings.
15712 * RootContext.cs: Pushed default WarningLevel to 3.
15714 * statement.cs: Removed unused variable.
15716 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15718 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15719 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15720 Add error 502 report.
15721 (StaticClass.DefineType): Add error 441 report.
15722 (Class.AllowedModifiersProp): New virtual property as temporary
15723 extension to AllowedModifiers.
15724 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15725 to share implementation with StaticClass and don't call virtual
15728 * driver.cs (MainDriver): Add error 1558 test.
15730 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15731 report. Moved error 36 test here.
15733 * statement.cs (Throw.Resolve): Add error 724 report.
15735 * typemanager.cs: Add out_attribute_type core type.
15737 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15739 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15741 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15743 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15746 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15748 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15749 Add error 3023 report.
15750 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15752 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15755 2004-12-12 John Luke <john.luke@gmail.com>
15757 * driver.cs (AddArgs): take -- into account when
15758 adding arguments, fixes bug 65710
15760 2004-12-12 Martin Baulig <martin@ximian.com>
15762 * expression.cs (Unary.TryReduceNegative): Added support for
15763 SByteConstant and ByteConstant.
15764 (Unary.Reduce): Check error values from TryReduceNegative().
15766 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15768 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15769 and report exception as error 182.
15771 2004-12-10 Raja R Harinath <rharinath@novell.com>
15773 * driver.cs (Main): Fix message when there are warnings.
15775 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15777 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15779 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15781 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15782 Reduced number of warnings.
15784 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15786 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15788 * driver.cs: Removed message.
15790 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15792 2004-12-08 <vargaz@freemail.hu>
15794 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15796 2004-12-08 Martin Baulig <martin@ximian.com>
15798 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15799 instead of a CS3002 for properties and indexer.
15801 2004-12-08 Martin Baulig <martin@ximian.com>
15803 * decl.cs (MemberName.ToString): Make this work again.
15805 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15807 * attribute.cs (Resolve): Add error 591 detection.
15809 * class.cs (FieldMember.Define): Add error 1547 detection.
15810 (Indexer.Define): Add error 620 detection.
15811 (Operator.Define): Add error 590 detection.
15813 * ecore.cs: Missing argument for error 79.
15815 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15818 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15821 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15824 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15826 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15827 Some operator comments were suppressed.
15828 * doc.cs : Implicit/explicit operator name in doc comments are like
15829 "op_Explicit(type)~returnType", so added suffix handling.
15831 2004-12-07 Martin Baulig <martin@ximian.com>
15834 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15835 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15836 (DeclSpace.ec): New protected field; store the EmitContext here.
15837 (DeclSpace.EmitContext): New public property; moved here from
15839 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15842 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15843 (Enum.Emit): Don't create a new EmitContext.
15845 * delegate.cs (Delegate.DefineType): Always create the
15848 * iterators.cs (Iterators.DefineIterator): Create a new
15849 EmitContext and store it in `ec'.
15851 2004-08-24 Martin Baulig <martin@ximian.com>
15854 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15855 this for accessibility checks.
15856 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15857 IsNestedFamilyAccessible.
15858 (TypeManager.IsSubclassOf): New method, do what the name actually
15861 2004-12-06 Raja R Harinath <rharinath@novell.com>
15863 Fix crash on cs0657-17.cs.
15864 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15865 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15866 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15867 the case where the NamespaceEntry gets overwritten.
15869 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15871 Fixed #69195, #56821
15872 * ecore.cs (ResolveBoolean): Tiny refactoring.
15874 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15875 of right expression resolving when left is false constant and
15876 operator is LogicalAnd OR true constant and operator is LogicalOr.
15878 * statement.cs (ResolveUnreachable): Always reports warning.
15880 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15882 * class.cs: Distinguish between 1721 and 1722 (just a little help
15883 for the programmer).
15885 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15887 * delegate.cs: Only allow this on new versions of the language.
15889 2004-12-02 Duncan Mak <duncan@ximian.com>
15891 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15893 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15894 here as a static method. Take an additional bool out parameter
15895 `must_do_cs1540_check' for signaling to InstanceResolve.
15896 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15897 member field from PropertyExpr class and made it an argument of
15898 the method instead.
15899 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15900 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15901 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15902 and `remove_accessor' as well as InstanceResolve: report CS0122
15907 2004-12-03 Raja R Harinath <rharinath@novell.com>
15909 Fix test-327.cs, test-328.cs, and put in early infrastructure
15910 for eventually fixing #52697.
15911 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15912 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15913 from other methods.
15914 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15915 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15916 (VerifyUsing, error246): Update.
15917 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15918 'NamespaceEntry.LookupNamespaceOrType'.
15920 2004-12-03 Martin Baulig <martin@ximian.com>
15922 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15923 method as our child, call AnonymousMethod.Compatible() on it.
15925 2004-12-03 Raja R Harinath <rharinath@novell.com>
15927 Disable XML documentation support in 'basic' profile.
15928 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15929 Redirect XmlElement to System.Object.
15930 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15931 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15932 * mcs.exe.sources: Add doc-bootstrap.cs.
15933 * doc-bootstrap.cs: New file. Contains empty stub implementation
15936 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15938 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15939 comments are allowed.
15941 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15943 * delegate.cs: Add checks for subtypes in paramaters and return values
15944 in VerifyMethod () to add support for Covariance/Contravariance
15947 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15949 * report.cs: Remove extra closing parenthesis.
15951 * convert.cs (Error_CannotImplicitConversion): If the name of the
15952 types are the same, provide some extra information.
15954 * class.cs (FieldBase): Use an unused bit field from the field to
15955 encode the `has_offset' property from the FieldMember. This saves
15956 a couple of Ks on bootstrap compilation.
15958 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15959 method as our child, return the AnonymousMethod resolved
15962 * expression.cs (New.DoResolve): Allow return values from
15963 NewDelegate to also include AnonymousMethods.
15967 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15970 * attribute.cs (Resolve): Improved implementation of params
15971 attribute arguments.
15973 * support.cs (ParameterData): Add HasParams to be faster.
15975 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15977 all things are for /doc support:
15979 * doc.cs: new file that supports XML documentation generation.
15980 * mcs.exe.sources: added doc.cs.
15982 Handle /doc command line option.
15983 Report error 2006 instead of 5 for missing file name for /doc.
15984 Generate XML documentation when required, after type resolution.
15986 Added support for picking up documentation (/// and /** ... */),
15987 including a new XmlCommentState enumeration.
15989 Added lines to fill Documentation element for field, constant,
15990 property, indexer, method, constructor, destructor, operator, event
15991 and class, struct, interface, delegate, enum.
15992 Added lines to warn incorrect comment.
15994 Added Documentation field (passed only when /doc was specified).
15996 Added DocComment, DocCommentHeader, GenerateDocComment() and
15997 OnGenerateDocComment() and some supporting private members for
15998 /doc feature to MemberCore.
16000 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16002 Added overriden DocCommentHeader.
16004 Added overriden DocCommentHeader and GenerateDocComment().
16006 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16008 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16009 unwrapping the enumeration values, chain to
16010 DoConstantNumericPromotions again, so we can promote things to the
16011 fundamental types (takes care of enums that are bytes, sbytes).
16015 2004-12-01 Raja R Harinath <rharinath@novell.com>
16017 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16018 Fix long-standing bug in type-lookup. Use FindType instead of
16019 LookupType when ec.ResolvingTypeTree.
16020 (Attribute.ResolveType, Attribute.Resolve)
16021 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16023 (Attributes.Search): Remove internal version. Update.
16024 (Attributes.SearchMulti): Update.
16025 (Attributes.GetClsCompliantAttribute): Remove.
16026 (Attributes.GetIndexerNameAttribute): Remove.
16027 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16028 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16029 * class.cs (Indexer.Define): Likewise.
16031 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16034 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16035 MarshallByReference members access.
16037 * expression.cs: Use CheckMarshallByRefAccess;
16038 Better error CS0197 message.
16040 * report.cs: Print whole related error message.
16042 2004-11-30 Raja R Harinath <rharinath@novell.com>
16044 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16045 the current directory to help debugging.
16047 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16049 * class (GetClassBases): Better error 60 report.
16050 (EventProperty): Disabled warning 67 detection.
16052 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16055 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16057 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16060 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16063 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16065 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16067 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16069 * attribute.cs (Attribute.Resolve): Refine error reporting and
16070 report a cs0117 if the identifier does not exist, to distinguish
16071 from 0617 which is a miss-use of the actual identifier.
16073 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16074 between cs0070 and cs0079.
16076 * class.cs (MemberBase.DoDefine): When reporting a wrong
16077 accessibility level, we use MethodCore to compare instead of
16078 Method (this was a regression in some refactoring effort).
16080 So now we correctly report cs0056 again.
16082 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16083 testing the target_type (which was known to be object_type) and
16084 not the source type (which is anonymous_method).
16086 Fixed reporting of error cs1660.
16088 * expression.cs (UserCast.Source): Expose the underlying cast.
16090 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16091 allowed types to find a match to int32 first (most common).
16093 In addition, it ignores any ImplicitUserConversions that did an
16094 internal implicit conversion (as the switch statement allows only
16095 one integral conversion to exist).
16097 * class.cs (PartialContainer.Create): rename `name' to
16098 `member_name' for clarity. Then replace the string calls with a
16099 call to MemberName.GetPartialName, as now using
16100 MemberName.ToString is an error (this is due to the side effects
16101 it had, that were fixed in the past).
16103 This will restore the error reporting on a number of partial class
16104 errors that were missusing this (and getting an exception as a
16105 results, which is now just a plain textual warning, because
16106 yyparse debug output would crash otherwise).
16108 2004-11-26 Raja R Harinath <rharinath@novell.com>
16110 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16112 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16114 * rootcontext.cs (LookupType): Make sure to cache lookups that
16115 don't give us a negative result. This saves about 5% of corlib
16118 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16120 * report.cs (AbstractMessage.Print): messages are sent to stderr
16122 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16123 non-interface in the list of interfaces (at this point, either
16124 parent was properly set, or a base class is being listed in the
16125 interfaces section).
16127 This flags error 1722, and resolves the crash from bug 69259.
16129 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16131 * statement.cs (Using.EmitExpressionFinally): make this work right
16132 for valuetypes. Fixes 69926.
16134 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16136 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16137 converted to an enum" here, before we try to change the underlying
16138 type. This code exists, but it is a different code path than the
16139 one used while encoding constants.
16141 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16142 old bug: when converting from the null literal to a pointer,
16143 return an EmptyCast, not the NullLiteral.
16145 This fixes #69921, the recent null_type changes probably made this
16146 bug more prominent.
16148 (ImplicitReferenceConversionExists): In addition, resynchronized
16149 the code here, so it matches the same code in
16150 ImplicitReferenceConversionExists for the `from any class-type S
16151 to any interface-type T'.
16154 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16156 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16158 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16160 * cs-parser.jay: Use verbosity accordingly.
16162 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16164 * expression.cs (Unary.ResolveOperator): Do not report warning;
16165 AddressOf reads from variable.
16167 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16169 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16173 * attribute.cs (Attributable): Removed CheckTargets.
16174 (Attributes.Emit): Explicit attribute targets are tested here.
16176 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16177 not enabled for interfaces.
16179 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16180 (GetAssemblyName): Ouch next bug there.
16182 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16184 * expression.cs: Error 275 added.
16186 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16188 Fix bug #69177 (Implemented decimal constant support)
16190 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16191 (BinaryFold): Add DecimalConstant.
16193 * const.cs (Define): Decimal constant
16195 (ChangeType): Add decimal type handling.
16196 (LookupConstantValue): Don't set value for decimal type but
16197 emit DecimalConstantAttribute. Needed for constant optimization.
16199 * constant.cs (ToDecimal): New method.
16200 (ConvertToDecimal): New method.
16201 (IntConstant): Implemented ConvertToDecimal.
16202 (DecimalConstant.Emit): Emit optimized version for decimals in
16205 * expression.cs (ResolveOperator): Changed order of constant
16206 reduction to work correctly with native types which have
16207 overloaded operators.
16208 (ResolveMemberAccess): Extract constant value from attribute
16211 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16213 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16214 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16215 (ChangeType): Decimal is special.
16216 (TypeToCoreType): Add decimal type.
16218 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16220 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16223 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16225 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16228 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16230 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16232 * pending.cs (PendingImplementation): Grab only interfaces.
16234 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16236 * statement.cs (ForeachHelperMethods): Add location member and
16237 error 202 detection.
16239 2004-11-19 Raja R Harinath <rharinath@novell.com>
16241 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16242 automatically handled by executable.make.
16243 (PROGRAM): Make profile-specific.
16245 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16247 * expression.cs (DoResolveBase): Fixed wrong warning for out
16250 2004-11-18 Martin Baulig <martin@ximian.com>
16252 Merged latest changes into gmcs. Please keep this comment in
16253 here, it makes it easier for me to see what changed in MCS since
16254 the last time I merged.
16256 2004-11-17 Raja R Harinath <rharinath@novell.com>
16258 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16259 (TypeHandle.GetMemberCache): New.
16260 (TypeHandle.TypeHandle): Update.
16261 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16262 (TypeManager.LookupParentInterfacesCache):
16263 Rename from LookupInterfaceCache. Optimize slightly.
16264 (TypeManager.MemberLookup_FindMembers): Update.
16265 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16266 multi-type variant.
16267 (AddCacheContents): Rename from AddHashtable.
16268 * class.cs (TypeContainer.parent_container): Remove.
16269 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16270 (TypeContainer.DoDefineMembers): Don't initialize it.
16271 Update to name changes.
16273 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16275 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16276 that factors the code to check access modifiers on override.
16278 (PropertyBase): Use the code here.
16280 Patch from Lluis S'anchez, fixes bug #69361.
16282 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16284 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16285 routine that is used to report the use of a captured variable
16286 whose address has been taken.
16288 There are two checks: one when variables are being captured and
16289 the other check is when the address of a variable is taken.
16291 (because an anonymous methods might be resolved before *or* after
16292 the address has been taken) and
16294 * expression.cs (Conditional.DoResolve): Remove the special
16295 casing that Martin added to trueExpr and falseExpr being both
16296 NullLiteral. We get the right behavior now just by introducing
16297 the null_type into the compiler.
16299 * convert.cs (ExplicitConversion): Change the code to use
16300 null_type instead of testing `expr is NullLiteral'.
16301 (ImplicitConversionStandard): use null_type too.
16302 (ImplicitReferenceConversionExists): use null_type too.
16303 (ImplicitReferenceConversion): use null_type too.
16305 * literal.cs: The type of `NullLiteral' is now null_type instead
16307 (Resolve): Set the type here.
16309 * typemanager.cs: Introduce null_type.
16311 2004-11-17 Martin Baulig <martin@ximian.com>
16313 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16314 direction, like FindMembers() does. Fixes #69546, testcase is in
16317 2004-11-16 Martin Baulig <martin@ximian.com>
16319 This is based on a patch from Marek Safar, see bug #69082.
16320 Fixes bugs #63705 and #67130.
16322 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16323 method; create a MemberCache for an interface type and cache the
16326 * decl.cs (IMemberContainer.ParentContainer): Removed.
16327 (IMemberContainer.ParentCache): New property.
16328 (MemberCache.SetupCacheForInterface): Removed.
16329 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16330 to create a cache for an interface's "parent".
16332 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16335 2004-11-16 Martin Baulig <martin@ximian.com>
16337 Merged back from gmcs; these changes already went into gmcs a
16338 couple of weeks ago.
16341 (TypeManager.AddUserType): Removed the `ifaces' argument.
16342 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16344 (TypeManager.AddUserInterface): Removed.
16345 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16347 (TypeManager.GetInterfaces): Likewise.
16348 (TypeManager.GetExplicitInterfaces): Likewise.
16350 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16352 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16353 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16355 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16357 * statement.cs: Avoid adding bools to a hashtable.
16359 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16361 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16362 calling an unsafe method from a safe location.
16364 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16367 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16369 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16371 * namespace.cs (VerifyUsing): use GetPartialName instead of
16374 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16376 * statement.cs (Return.Resolve): Fix regression in typo: if
16377 `in_exc', we have to request a NeedReturnLabel, this was a typo
16378 introduced in the anonymous method check-in. Fixes #69131.
16380 * Indexers were using the ShortName when defining themselves,
16381 causing a regression in the compiler bootstrap when applying the
16382 patch from 2004-11-02 (first part), now they use their full name
16383 and the bug is gone.
16385 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16387 * driver.cs: Strip the path from the names of embedded resources. Fixes
16390 2004-11-04 Raja R Harinath <rharinath@novell.com>
16392 Fix error message regression: cs0104-2.cs.
16393 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16394 (AliasEntry.Resolve): Update.
16395 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16397 (RootContext.LookupType): Update.
16399 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16401 * cs-parser.jay: Add support for handling accessor modifiers
16402 * class: Add support port accessor modifiers and error checking,
16403 define PropertyMethod.Define as virtual (not abstract anymore)
16404 * ecore.cs: Add checking for proeprties access with access modifiers
16405 * iterators.cs: Modify Accessor constructor call based in the modified
16407 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16409 * expression.cs (StringConcat): Handle being called twice,
16410 as when we have a concat in a field init with more than two
16413 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16415 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16416 special case explicit implementations, we should always produce
16417 the .property or .event declaration.
16419 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16420 since it will not return correct data if people use this
16421 unresolved in the presence of using statements (see test-313).
16423 * class.cs (MethodData.Define): If we are an explicit interface
16424 implementation, set the method name to the full name of the
16425 interface plus the name of the method.
16427 Notice that using the method.MethodName.GetFullName() does not
16428 work, as it will only contain the name as declared on the source
16429 file (it can be a shorthand in the presence of using statements)
16430 and not the fully qualifed type name, for example:
16434 class D : ICloneable {
16435 object ICloneable.Clone () {
16439 Would produce a method called `ICloneable.Clone' instead of
16440 `System.ICloneable.Clone'.
16442 * namespace.cs (Alias.Resolve): Use GetPartialName.
16444 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16446 * cs-parser.jay: Add error 1055 report.
16448 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16450 * assign.cs (Assign.DoResolve): Only do the transform of
16451 assignment into a New if the types are compatible, if not, fall
16452 through and let the implicit code deal with the errors and with
16453 the necessary conversions.
16455 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16457 * cs-parser.jay: Add error 1031 report.
16459 * cs-tokenizer.cs: Add location for error 1038.
16461 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16463 * cs-parser.jay: Add error 1016 report.
16465 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16467 * cs-parser.jay: Add errors 1575,1611 report.
16469 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16471 * cs-parser.jay: Add error 1001 report.
16473 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16476 * attribute.cs (GetMarshal): Add method argument for
16477 caller identification.
16479 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16480 agument for GetMarshal and RuntimeMissingSupport.
16482 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16484 * attribute.cs (ExtractSecurityPermissionSet): Removed
16485 TypeManager.code_access_permission_type.
16487 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16489 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16491 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16492 for obsolete use of a variable here. Fixes regression on errors
16493 cs0619-25 and cs0619-26.
16495 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16497 Fix #62358, implemented security attribute encoding.
16499 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16500 Tests permitted SecurityAction for assembly or other types.
16501 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16502 data from SecurityPermissionAttribute to PermisionSet class.
16504 * class.cs (ApplyAttributeBuilder): Added special handling
16505 for System.Security.Permissions.SecurityAttribute based types.
16507 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16508 special handling for System.Security.Permissions.SecurityAttribute
16511 * enum.cs (ApplyAttributeBuilder): Added special handling
16512 for System.Security.Permissions.SecurityAttribute based types.
16514 * parameter.cs (ApplyAttributeBuilder): Added special handling
16515 for System.Security.Permissions.SecurityAttribute based types.
16517 * rootcontext.cs: Next 2 core types.
16519 * typemanager.cs (TypeManager.security_permission_attr_type):
16520 Built in type for the SecurityPermission Attribute.
16521 (code_access_permission_type): Build in type.
16523 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16525 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16526 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16527 all of this information into
16528 EmitContext.EmitCapturedVariableInstance.
16530 * codegen.cs (EmitCapturedVariableInstance): move here the
16531 funcionality of emitting an ldarg.0 in the presence of a
16532 remapping. This centralizes the instance emit code.
16534 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16535 then emit a load of this: it means that we have reached the
16536 topmost ScopeInfo: the one that contains the pointer to the
16537 instance of the class hosting the anonymous method.
16539 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16540 captures to the topmost CaptureContext.
16542 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16544 * expression.cs (LocalVariableReference): Move the knowledge about
16545 the iterators into codegen's EmitCapturedVariableInstance.
16547 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16549 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16550 all code paths return a value from an anonymous method (it is the
16551 same as the 161 error, but for anonymous methods).
16553 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16555 The introduction of anonymous methods in the compiler changed
16556 various ways of doing things in the compiler. The most
16557 significant one is the hard split between the resolution phase
16558 and the emission phases of the compiler.
16560 For instance, routines that referenced local variables no
16561 longer can safely create temporary variables during the
16562 resolution phase: they must do so from the emission phase,
16563 since the variable might have been "captured", hence access to
16564 it can not be done with the local-variable operations from the runtime.
16568 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16569 is a toplevel block.
16571 (ToplevelBlock): A new kind of Block, these are the blocks that
16572 are created by the parser for all toplevel method bodies. These
16573 include methods, accessors and anonymous methods.
16575 These contain some extra information not found in regular blocks:
16576 A pointer to an optional CaptureContext (for tracking captured
16577 local variables and parameters). A pointer to the parent
16580 (Return.Resolve): Catch missmatches when returning a value from an
16581 anonymous method (error 1662).
16582 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16585 (Break.Resolve): ditto.
16587 (SwitchLabel): instead of defining the labels during the
16588 resolution phase, we now turned the public ILLabel and ILLabelCode
16589 labels into methods called GetILLabelCode() and GetILLabel() that
16590 only define the label during the Emit phase.
16592 (GotoCase): Track the SwitchLabel instead of the computed label
16593 (its contained therein). Emit the code by using
16594 SwitchLabel.GetILLabelCode ().
16596 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16597 whether the Local has been captured or not.
16599 (LocalInfo.IsCaptured): New property, used to tell whether the
16600 local has been captured.
16602 * anonymous.cs: Vastly updated to contain the anonymous method
16605 The main classes here are: CaptureContext which tracks any
16606 captured information for a toplevel block and ScopeInfo used to
16607 track the activation frames for various local variables.
16609 Each toplevel block has an optional capture context associated
16610 with it. When a method contains an anonymous method both the
16611 toplevel method and the anonymous method will create a capture
16612 context. When variables or parameters are captured, they are
16613 recorded on the CaptureContext that owns them, for example:
16617 MyDelegate d = delegate {
16622 Here `a' will be recorded as captured on the toplevel
16623 CapturedContext, the inner captured context will not have anything
16624 (it will only have data if local variables or parameters from it
16625 are captured in a nested anonymous method.
16627 The ScopeInfo is used to track the activation frames for local
16628 variables, for example:
16630 for (int i = 0; i < 10; i++)
16631 for (int j = 0; j < 10; j++){
16632 MyDelegate d = delegate {
16637 At runtime this captures a single captured variable `i', but it
16638 captures 10 different versions of the variable `j'. The variable
16639 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16640 recorded on a child.
16642 The toplevel ScopeInfo will also track information like the `this'
16643 pointer if instance variables were referenced (this is necessary
16644 as the anonymous method lives inside a nested class in the host
16645 type of the method).
16647 (AnonymousMethod): Expanded to track the Toplevel, implement
16648 `AnonymousMethod.Compatible' to tell whether an anonymous method
16649 can be converted to a target delegate type.
16651 The routine now also produces the anonymous method content
16653 (AnonymousDelegate): A helper class that derives from
16654 DelegateCreation, this is used to generate the code necessary to
16655 produce the delegate for the anonymous method that was created.
16657 * assign.cs: API adjustments for new changes in
16658 Convert.ImplicitStandardConversionExists.
16660 * class.cs: Adjustments to cope with the fact that now toplevel
16661 blocks are of type `ToplevelBlock'.
16663 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16664 insteda of standard blocks.
16666 Flag errors if params arguments are passed to anonymous methods.
16668 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16669 `CurrentAnonymousMethod' which points to the current Anonymous
16670 Method. The variable points to the AnonymousMethod class that
16671 holds the code being compiled. It is set in the new EmitContext
16672 created for the anonymous method.
16674 (EmitContext.Phase): Introduce a variable and an enumeration to
16675 assist in enforcing some rules about when and where we are allowed
16676 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16677 only one that enfonces this right now).
16679 (EmitContext.HaveCaptureInfo): new helper method that returns
16680 whether we have a CapturedContext initialized.
16682 (EmitContext.CaptureVariable): New method used to register that a
16683 LocalInfo must be flagged for capturing.
16685 (EmitContext.CapturedParameter): New method used to register that a
16686 parameters must be flagged for capturing.
16688 (EmitContext.CapturedField): New method used to register that a
16689 field must be flagged for capturing.
16691 (EmitContext.HaveCapturedVariables,
16692 EmitContext.HaveCapturedFields): Return whether there are captured
16693 variables or fields.
16695 (EmitContext.EmitMethodHostInstance): This is used to emit the
16696 instance for the anonymous method. The instance might be null
16697 (static methods), this (for anonymous methods that capture nothing
16698 and happen to live side-by-side with the current method body) or a
16699 more complicated expression if the method has a CaptureContext.
16701 (EmitContext.EmitTopBlock): Routine that drives the emission of
16702 code: it will first resolve the top block, then emit any metadata
16703 and then emit the code. The split is done so that we can extract
16704 any anonymous methods and flag any captured variables/parameters.
16706 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16707 during this phase, the ILGenerator should not be used as labels
16708 and local variables declared here might not be accessible to any
16709 code that is part of an anonymous method.
16711 Exceptions to this include the temporary variables that are
16712 created by some statements internally for holding temporary
16715 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16718 (EmitContext.TemporaryReturn): This method is typically called
16719 from the Emit phase, and its the only place where we allow the
16720 ReturnLabel to be defined other than the EmitMeta. The reason is
16721 that otherwise we would have to duplicate a lot of logic in the
16722 Resolve phases of various methods that today is on the Emit
16725 (EmitContext.NeedReturnLabel): This no longer creates the label,
16726 as the ILGenerator is not valid during the resolve phase.
16728 (EmitContext.EmitThis): Extended the knowledge in this class to
16729 work in anonymous methods in addition to iterators.
16731 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16732 code is necessary on the stack to access the instance to a local
16733 variable (the variable will be accessed as a field).
16735 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16736 EmitContext.EmitAddressOfParameter): Routines to support
16737 parameters (not completed at this point).
16739 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16740 will also remove the parameters.
16742 * convert.cs (Convert): Define a `ConstantEC' which points to a
16743 null. This is just to prefity some code that uses
16744 ImplicitStandardConversion code and do not have an EmitContext
16747 The idea is to flag explicitly that at that point in time, it is
16748 known that the conversion will not trigger the delegate checking
16749 code in implicit conversions (which requires a valid
16752 Everywhere: pass new EmitContext parameter since
16753 ImplicitStandardConversionExists now requires it to check for
16754 anonymous method conversions.
16756 (Convert.ImplicitStandardConversionExists): If the type of an
16757 expression is the anonymous_method_type, and the type is a
16758 delegate, we invoke the AnonymousMethod.Compatible method to check
16759 whether an implicit conversion is possible.
16761 (Convert.ImplicitConversionStandard): Only do implicit method
16762 group conversions if the language level is not ISO_1.
16764 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16765 MethodInfo for the Invoke method. used by Delegate and
16768 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16769 method conversions if the target type is a delegate.
16771 Removed extra debugging nops.
16773 (LocalVariableReference): Turn the `local_info' into a public
16776 Add `prepared' field, the same hack used for FieldExprs to cope
16777 with composed assignments, as Local variables do not necessarily
16778 operate purely on the stack as they used to: they can be captured
16781 Add `temp' for a temporary result, like fields.
16783 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16785 It now copes with Local variables that are captured and emits the
16786 proper instance variable to load it from a field in the captured
16789 (ParameterReference.DoResolveBase): During the resolve phase,
16790 capture parameters if we are in an anonymous method.
16792 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16793 anonymous method, use the EmitContext helper routines to emit the
16794 parameter reference.
16796 * iterators.cs: Set RemapToProxy to true/false during the
16799 * parameters.cs (GetParameterByName): New helper method.
16801 * typemanager.cs (anonymous_method_type) a new type that
16802 represents an anonyous method. This is always an internal type,
16803 used as a fencepost to test against the anonymous-methodness of an
16806 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16808 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16810 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16812 2004-10-18 Martin Baulig <martin@ximian.com>
16814 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16815 `Type' directly, but call ResolveType() on it.
16816 (Catch.Resolve): Likewise.
16817 (Foreach.Resolve): Likewise.
16819 2004-10-18 Martin Baulig <martin@ximian.com>
16821 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16822 `Type' directly, but call ResolveType() on it.
16823 (Probe.DoResolve): Likewise.
16824 (ArrayCreation.LookupType): Likewise.
16825 (TypeOf.DoResolve): Likewise.
16826 (SizeOf.DoResolve): Likewise.
16828 2004-10-18 Martin Baulig <martin@ximian.com>
16830 * expression.cs (Invocation.BetterFunction): Put back
16831 TypeManager.TypeToCoreType().
16833 2004-10-18 Raja R Harinath <rharinath@novell.com>
16835 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16838 2004-10-18 Martin Baulig <martin@ximian.com>
16840 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16841 `Type' directly, but call ResolveType() on it.
16843 2004-10-18 Martin Baulig <martin@ximian.com>
16845 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16846 `Type' directly, but call ResolveType() on it.
16847 (MemberBase.DoDefine): Likewise.
16849 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16850 `Type' directly, but call ResolveType() on it.
16851 (ComposedCast.DoResolveAsTypeStep): Likewise.
16853 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16854 `Type' directly, but call ResolveType() on it.
16856 2004-10-17 John Luke <john.luke@gmail.com>
16858 * class.cs (Operator.GetSignatureForError): use CSharpName
16860 * parameter.cs (Parameter.GetSignatureForError): Returns
16861 correct name even if was not defined.
16863 2004-10-13 Raja R Harinath <rharinath@novell.com>
16866 * class.cs (TypeContainer.EmitContext): New property.
16867 (DefineNestedTypes): Create an emitcontext for each part.
16868 (MethodCore.DoDefineParameters): Use container's emitcontext.
16869 Pass type array to InternalParameters.
16870 (MemberBase.DoDefine): Use container's emitcontext.
16871 (FieldMember.Define): Likewise.
16872 (Event.Define): Likewise.
16873 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16874 Pass type array to InternalParameters.
16875 (SetIndexerMethod.GetParameterInfo): Likewise.
16876 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16877 * delegate.cs (Define): Pass emitcontext to
16878 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16879 array to InternalParameters.
16880 * expression.cs (ParameterReference.DoResolveBase): Pass
16881 emitcontext to GetParameterInfo.
16882 (ComposedCast.DoResolveAsTypeStep): Remove check on
16883 ec.ResolvingTypeTree.
16884 * parameter.cs (Parameter.Resolve): Change argument to
16885 EmitContext. Use ResolveAsTypeTerminal.
16886 (Parameter.GetSignature): Change argument to EmitContext.
16887 (Parameters.ComputeSignature): Likewise.
16888 (Parameters.ComputeParameterTypes): Likewise.
16889 (Parameters.GetParameterInfo): Likewise.
16890 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16891 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16892 * support.cs (InternalParameters..ctor): Remove variant that takes
16894 * typemanager.cs (system_intptr_expr): New.
16895 (InitExpressionTypes): Initialize it.
16897 2004-10-12 Chris Toshok <toshok@ximian.com>
16899 * cs-parser.jay: fix location for try_statement and catch_clause.
16901 2004-10-11 Martin Baulig <martin@ximian.com>
16903 * report.cs: Don't make --fatal abort on warnings, we have
16904 -warnaserror for that.
16906 2004-10-07 Raja R Harinath <rharinath@novell.com>
16908 More DeclSpace.ResolveType avoidance.
16909 * decl.cs (MemberCore.InUnsafe): New property.
16910 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16911 with newly created EmitContext.
16912 (FieldMember.Define): Likewise.
16913 * delegate.cs (Delegate.Define): Likewise.
16914 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16915 only if normal name-lookup fails.
16916 (TypeExpr.DoResolve): Enable error-checking.
16917 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16918 (SizeOf.DoResolve): Likewise.
16919 (ComposedCast.DoResolveAsTypeStep): Likewise.
16920 (StackAlloc.DoResolve): Likewise.
16921 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16922 (Block.Unsafe): New property.
16923 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16924 (Unsafe): Set 'unsafe' flag of contained block.
16925 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16926 (Fixed.Resolve): Likewise.
16927 (Catch.Resolve): Likewise.
16928 (Using.ResolveLocalVariableDecls): Likewise.
16929 (Foreach.Resolve): Likewise.
16931 2004-10-05 John Luke <john.luke@gmail.com>
16933 * cs-parser.jay: add location to error CS0175
16935 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16937 * ecore.cs (Expression.Constantity): Add support for turning null
16940 * const.cs (Const.Define): Allow constants to be reference types
16941 as long as the value is Null.
16943 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16945 * namespace.cs (NamespaceEntry.Using): No matter which warning
16946 level is set, check if this namespace name has already been added.
16948 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16950 * expression.cs: reftype [!=]= null should always use br[true,false].
16953 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16956 * attribute.cs: Enum conversion moved to
16957 GetAttributeArgumentExpression to be applied to the all
16960 2004-10-01 Raja R Harinath <rharinath@novell.com>
16962 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16963 * class.c (TypeContainer.DefineType): Flag error if
16964 base types aren't accessible due to access permissions.
16965 * decl.cs (DeclSpace.ResolveType): Move logic to
16966 Expression.ResolveAsTypeTerminal.
16967 (DeclSpace.ResolveTypeExpr): Thin layer over
16968 Expression.ResolveAsTypeTerminal.
16969 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16970 Refactor code into NestedAccess. Use it.
16971 (DeclSpace.NestedAccess): New.
16972 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16973 argument to silence errors. Check access permissions.
16974 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16975 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16976 (Cast.DoResolve): Likewise.
16977 (New.DoResolve): Likewise.
16978 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16979 (TypeOf.DoResolve): Likewise.
16981 * expression.cs (Invocation.BetterConversion): Return the Type of
16982 the better conversion. Implement section 14.4.2.3 more faithfully.
16983 (Invocation.BetterFunction): Make boolean. Make correspondence to
16984 section 14.4.2.2 explicit.
16985 (Invocation.OverloadResolve): Update.
16986 (Invocation): Remove is_base field.
16987 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16988 (Invocation.Emit): Likewise.
16990 2004-09-27 Raja R Harinath <rharinath@novell.com>
16992 * README: Update to changes.
16994 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16996 * cs-parser.jay: Reverted 642 warning fix.
16998 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17001 * decl.cs (FindMemberWithSameName): Indexer can have more than
17004 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17006 * expression.cs (LocalVariableReference.DoResolveLValue):
17007 Do not report warning 219 for out values.
17008 (EmptyExpression.Null): New member to avoid extra allocations.
17010 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17012 * cs-parser.jay: Fix wrong warning 642 report.
17014 * cs-tokenizer.cs (CheckNextToken): New helper;
17015 Inspect next character if is same as expected.
17017 2004-09-23 Martin Baulig <martin@ximian.com>
17019 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17020 (Convert.ImplicitReferenceConversionExists): Likewise.
17022 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17024 * class.cs (Operator.Define): Add error 448 and 559 report.
17026 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17028 * class.cs (MemberBase.IsTypePermitted): New protected
17029 method for checking error CS0610.
17031 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17033 * class.cs (TypeContainer.HasExplicitLayout): New property
17034 Returns whether container has StructLayout attribute set Explicit.
17035 (FieldMember): New abstract class for consts and fields.
17036 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17037 (Field): Reuse FieldMember.
17039 * const.cs (Const): Reuse FieldMember.
17041 * rootcontext.cs: EmitConstants call moved to class.
17043 2004-09-22 Martin Baulig <martin@ximian.com>
17045 Thanks to Peter Sestoft for this bug report.
17047 * expression.cs (Conditional): If both the `trueExpr' and the
17048 `falseExpr' is a NullLiteral, return a NullLiteral.
17050 2004-09-22 Martin Baulig <martin@ximian.com>
17052 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17053 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17054 for the "get_Current" call.
17056 2004-09-22 Martin Baulig <martin@ximian.com>
17058 Marek and me just fixed one of our oldest bugs: #28562 :-)
17060 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17062 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17063 we're an EnumConstant, just return that.
17064 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17065 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17066 to get the value which'll actually be written into the attribute.
17067 However, we have to use GetValue() to access the attribute's value
17070 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17072 * constant.cs (Constant.IsNegative): New abstract property
17075 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17076 (StackAlloc.DoResolve): Reused IsNegative.
17078 2004-09-21 Martin Baulig <martin@ximian.com>
17080 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17081 if we're used in an iterator, we may be called from different
17084 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17085 we actually have an exception block.
17087 2004-09-20 John Luke <jluke@cfl.rr.com>
17089 * class.cs, cs-parser.jay: Improve the error report for 1520:
17090 report the actual line where the error happens, not where the
17091 class was declared.
17093 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17094 Pass location information that was available elsewhere.
17096 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17098 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17099 runtime to delay sign assemblies.
17101 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17103 * cs-parser.jay: Do not report the stack trace, this is barely
17106 2004-08-22 John Luke <john.luke@gmail.com>
17108 * driver.cs : check that a resource id is not already used
17109 before adding it, report CS1508 if it is, bug #63637
17111 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17113 * ecore.cs: Removed dead code.
17115 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17117 * class.cs: Do not report warning CS0067 on the interfaces.
17119 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17121 * cs-parser.jay: Add error 504 report.
17123 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17125 * rootcontext.cs: WarningLevel is 4 by default now.
17127 * statement.cs (Fixed.Resolve): Do not null
17130 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17133 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17134 deep search when property is not virtual.
17135 (PropertyExpr.ResolveAccessors): Make one call for both
17138 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17141 * statement.cs: Error 152 report constains also location.
17143 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17146 * const.cs: Explicitly set constant as static.
17148 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17151 * cs-parser.jay: Add error 1017 report.
17153 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17155 Fixed bug #59980, #64224
17156 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17158 * typemanager.cs (IsSpecialMethod): Simplified
17160 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17162 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17163 condition with better params.
17165 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17168 * attribute.cs (Resolve): Property has to have both
17171 2004-09-14 Martin Baulig <martin@ximian.com>
17173 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17175 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17178 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17179 called and is obsolete then this member suppress message
17180 when call is inside next [Obsolete] method or type.
17182 * expression.cs: Use TestObsoleteMethodUsage member.
17184 2004-09-14 Martin Baulig <martin@ximian.com>
17186 * cs-parser.jay: Sync a bit with the GMCS version.
17188 2004-09-14 Martin Baulig <martin@ximian.com>
17190 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17191 (CSharpParser.yacc_verbose_flag): New public field.
17193 * genericparser.cs: Removed.
17195 2004-09-14 Raja R Harinath <rharinath@novell.com>
17197 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17199 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17201 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17203 2004-09-10 Martin Baulig <martin@ximian.com>
17205 Backported my MemberName changes from GMCS into MCS.
17207 - we are now using a special `MemberName' class instead of using
17208 strings; in GMCS, the `MemberName' also contains the type
17211 - changed the grammar rules a bit:
17212 * the old `member_name' is now a `namespace_or_type_name':
17213 The rule is that we use `namespace_or_type_name' everywhere
17214 where we expect either a "member name" (GetEnumerator) or a
17215 "member name" with an explicit interface name
17216 (IEnumerable.GetEnumerator).
17217 In GMCS, the explicit interface name may include type arguments
17218 (IEnumerable<T>.GetEnumerator).
17219 * we use `member_name' instead of just `IDENTIFIER' for
17221 The rule is that we use `member_name' wherever a member may
17222 have type parameters in GMCS.
17224 * decl.cs (MemberName): New public class.
17225 (MemberCore.MemberName): New public readonly field.
17226 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17227 (DeclSpace): Likewise.
17229 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17230 * enum.cs (Enum.ctor): Likewise.
17232 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17234 (AliasEntry.ctor): Take a MemberName, not an Expression.
17235 (AliasEntry.UsingAlias): Likewise.
17237 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17238 (IMethodData.MemberName): Changed type from string to MemberName.
17239 (MemberBase.ExplicitInterfaceName): Likewise.
17240 (AbstractPropertyEventMethod.SetupName): Make this private.
17241 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17242 argument; compute the member name here.
17243 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17244 on the `member.MemberName' and the `prefix'.
17246 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17248 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17249 thus, we get a `MemberName' instead of a `string'. These
17250 declarations may have type parameters in GMCS.
17251 (interface_method_declaration, delegate_declaration): Likewise.
17252 (class_declaration, interface_declaration): Likewise.
17253 (method_header): Use `namespace_or_type_name' instead of
17254 `member_name'. We may be an explicit interface implementation.
17255 (property_declaration, event_declaration): Likewise.
17256 (member_name): This is now just an `IDENTIFIER', not a
17257 `namespace_or_type_name'.
17258 (type_name, interface_type): Removed.
17259 (namespace_or_type_name): Return a MemberName, not an Expression.
17260 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17261 call GetTypeExpression() on the MemberName to get an expression.
17262 (IndexerDeclaration.interface_type): Changed type from string to
17264 (MakeName): Operate on MemberName's instead of string's.
17266 2004-09-13 Raja R Harinath <rharinath@novell.com>
17269 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17270 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17271 lookup to avoid symbols introduced by 'using'.
17272 * rootcontext.cs (NamespaceLookup): Update.
17274 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17276 * class.cs (TypeContainer.DoDefineMembers): Do not call
17277 DefineDefaultConstructor for static classes.
17279 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17281 * attribute.cs (Attribute.Resolve): Add error 653 report.
17283 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17285 (Method.ApplyAttributeBuilder): Add error 685 report.
17286 (Operator.Define): Add error 564 report.
17288 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17290 * expression.cs (Invocation.DoResolve): Add error
17291 245 and 250 report.
17293 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17296 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17298 * class.cs (ConstructorInitializer.Resolve):
17299 Wrong error number (515->516).
17301 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17303 * class.cs (Indexer.Define): Add error 631 report.
17305 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17307 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17309 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17311 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17313 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17315 * cs-parser.jay: Added error CS0241 report.
17317 2004-09-10 Raja R Harinath <rharinath@novell.com>
17319 * cs-parser.jay (fixed_statement): Introduce a scope for the
17320 declaration in the 'fixed' statement.
17322 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17324 * cs-parser.jay: Added CS0230 error report.
17326 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17328 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17330 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17332 * expression.cs (Argument.Resolve): Added error CS0192 and
17335 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17337 C# 2.0 #pragma warning feature
17339 * cs-tokenizer.cs (PreProcessPragma): New method;
17340 Handles #pragma directive.
17342 * report.cs (WarningRegions): New class; Support
17343 class for #pragma warning directive. It tests whether
17344 warning is enabled for a given line.
17346 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17348 * const.cs: Add more descriptive error report, tahnks to
17351 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17353 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17355 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17357 * expression.cs: Apply patch from Ben: Remove dead code from
17358 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17359 as that code just threw an exception anwyays.
17361 * const.cs: Remove the call to the turnintoconstant, for details
17364 * literal.cs: The type of the null-literal is the null type; So
17365 we use a placeholder type (literal.cs:System.Null, defined here)
17368 * expression.cs (Conditional.DoResolve): Remove some old code that
17369 is no longer needed, conversions have been fixed.
17371 (ArrayCreationExpression.DoResolve): Return false if we fail to
17372 resolve the inner expression.
17374 2004-09-07 Raja R Harinath <rharinath@novell.com>
17377 * cs-parser.jay (delegate_declaration): Record a delegate
17378 declaration as a type declaration.
17379 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17381 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17383 * parameter.cs: Do not crash if the type can not be resolved.
17385 * expression.cs: Report errors with unsafe pointers, fixes #64896
17387 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17389 * expression.cs: Pointer arith always needs to do a conv.i
17390 if the operand is a long. fix 65320
17392 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17394 Fixed cs0619-37.cs, cs0619-38.cs
17396 * enum.cs (GetObsoleteAttribute): Removed.
17398 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17399 on Enum member is double staged. The first is tested member
17402 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17404 Fixed #56986, #63631, #65231
17406 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17407 adds member to name container.
17408 (TypeContainer.AddToTypeContainer): New method, adds type to
17410 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17411 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17412 AddOperator): Simplified by reusing AddToMemberContainer.
17413 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17415 (Method.CheckForDuplications): Fixed implementation to test all
17417 (MemberBase): Detection whether member is explicit interface
17418 implementation is now in constructor.
17419 (MemberBase.UpdateMemberName): Handles IndexerName.
17420 (Accessor): Changed to keep also location information.
17421 (AbstractPropertyEventMethod): Is derived from MemberCore.
17422 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17423 will be emited or not.
17424 (PropertyBase.AreAccessorsDuplicateImplementation):
17425 Tests whether accessors are not in collision with some method.
17426 (Operator): Is derived from MethodCore to simplify common
17429 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17431 (DeclSpace.AddToContainer): Adds the member to defined_names
17432 table. It tests for duplications and enclosing name conflicts.
17434 * enum.cs (EnumMember): Clean up to reuse the base structures
17436 2004-09-03 Martin Baulig <martin@ximian.com>
17438 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17439 into TypeContainer, to make partial classes work again.
17441 2004-09-03 Martin Baulig <martin@ximian.com>
17443 * rootcontext.cs (RootContext.V2): Removed.
17445 2004-03-23 Martin Baulig <martin@ximian.com>
17447 * expression.cs (Invocation.OverloadResolve): Added `bool
17448 may_fail' argument and use it instead of the Location.IsNull() hack.
17450 2004-09-03 Martin Baulig <martin@ximian.com>
17452 Merged latest changes into gmcs. Please keep this comment in
17453 here, it makes it easier for me to see what changed in MCS since
17454 the last time I merged.
17456 2004-09-03 Raja R Harinath <rharinath@novell.com>
17459 * expression.cs (BetterConversion): Don't allow either conversion
17460 to be null. Remove redundant implicit conversion test when 'q ==
17461 null' -- when this function is invoked, we already know that the
17462 implicit conversion exists.
17463 (BetterFunction): Assume that 'best' is non-null. Remove
17464 redundant reimplementation of IsApplicable when 'best' is null.
17465 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17466 number of arguments.
17467 (IsAncestralType): Extract from OverloadResolve.
17468 (OverloadResolve): Make robust to the MethodGroupExpr being
17469 unsorted. Implement all the logic of Section 14.5.5.1, and
17470 support overloading of methods from multiple applicable types.
17471 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17473 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17474 (RealError, Warning): Append type of report to related symbol.
17476 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17478 * enum.cs: Fixed CLS-Compliance checks for enum members.
17479 Error tests cs3008-8.cs, cs3014-8.cs
17481 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17483 Fixed bug #62342, #63102
17484 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17485 like ImplementMethod.
17487 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17489 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17492 2004-09-02 Martin Baulig <martin@ximian.com>
17494 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17495 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17498 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17500 C# 2.0 Static classes implemented
17502 * class.cs (TypeContainer): instance_constructors,
17503 initialized_fields, initialized_static_fields,
17504 default_constructor, base_inteface_types are protected to be
17505 accessible from StaticClass.
17506 (TypeContainer.DefineDefaultConstructor): New virtual method
17507 for custom default constructor generating
17508 (StaticClass): New class to handle "Static classes" feature.
17510 * cs-parser.jay: Handle static keyword on class like instance
17513 * driver.cs: Added "/langversion" command line switch with two
17514 options (iso-1, default).
17516 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17518 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17520 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17522 * delegate.cs: Style.
17524 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17526 * delegate.cs: Add seperate instance expr field for miguel.
17528 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17530 * PointerArithmetic (Resolve): make sure we are not doing
17531 pointer arith on void*. Also, make sure we are resolved
17532 by not setting eclass until resolve.
17534 All callers: Make sure that PointerArithmetic gets resolved.
17536 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17538 * ArrayCreation (LookupType): If the type does not resolve
17539 to an array, give an error.
17541 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17543 * statement.cs (Try.Resolve): Fixed bug #64222
17545 2004-08-27 Martin Baulig <martin@ximian.com>
17548 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17551 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17553 * ecore.cs (Constantify): Get underlying type via
17554 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17555 Windows in special cases.
17557 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17559 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17560 for obtaining also private methods.
17561 (GetRemoveMethod): Used GetRemoveMethod (true)
17562 for obtaining also private methods.
17564 2004-08-24 Martin Baulig <martin@ximian.com>
17566 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17567 MethodAttributes.HideBySig for operators.
17569 2004-08-23 Martin Baulig <martin@ximian.com>
17571 Back to the old error reporting system :-)
17573 * report.cs (Message): Removed.
17574 (Report.MessageData, ErrorData, WarningData): Removed.
17575 (Report.Error, Warning): Back to the old system.
17577 2004-08-23 Martin Baulig <martin@ximian.com>
17579 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17581 * class.cs (TypeContainer.ParentContainer): New public virtual
17582 method; replaces the explicit interface implementation.
17583 (ClassPart.ParentContainer): Override.
17585 2004-08-23 Martin Baulig <martin@ximian.com>
17587 * statement.cs (Switch): Added support for constant switches; see
17588 #59428 or test-285.cs.
17590 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17593 * statement.cs (GetEnumeratorFilter): Removed useless
17594 logic because C# specs is strict. GetEnumerator must be
17597 2004-08-22 Martin Baulig <martin@ximian.com>
17599 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17600 a switch and may break, reset the barrier. Fixes #59867.
17602 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17604 CLS-Compliance speed up (~5% for corlib)
17606 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17607 New method. Tests container for CLS-Compliant names
17609 * class.cs (TypeContainer.VerifyClsName): New method.
17610 Checks whether container name is CLS Compliant.
17611 (Constructor): Implements IMethodData.
17613 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17614 low-case table for CLS Compliance test.
17615 (MemberCache.VerifyClsParameterConflict): New method.
17616 Checks method parameters for CS3006 error.
17618 * enum.cs (EnumMember): Is derived from MemberCore.
17619 (Enum.VerifyClsName): Optimized for better performance.
17621 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17623 * report.cs: Renamed Error_T to Error and changed all
17626 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17628 * class.cs (TypeContainer.IndexerArrayList): New inner class
17629 container for indexers.
17630 (TypeContainer.DefaultIndexerName): New constant for default
17631 indexer name. Replaced all "Item" with this constant.
17632 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17634 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17635 DefaultMemberAttribute constructor.
17637 2004-08-05 Martin Baulig <martin@ximian.com>
17639 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17642 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17644 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17645 multi platforms problem.
17647 * compiler.csproj: Included shared files.
17649 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17651 Fix bug 60333, 55971 in the more general way
17652 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17653 Added arg_type argument for constant conversion.
17654 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17656 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17659 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17660 OperatorArrayList, MethodCoreArrayList for typecontainer
17661 containers. Changed class member types to these new types.
17662 (MethodArrayList.DefineMembers): Added test for CS0659.
17664 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17666 * cfold.cs: Synchronize the folding with the code in expression.cs
17667 Binary.DoNumericPromotions for uint operands.
17669 * attribute.cs: Revert patch from Raja, it introduced a regression
17670 while building Blam-1.2.1 (hard to isolate a test case).
17672 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17676 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17678 (MethodCore.parent_method): New member. The method we're overriding
17679 if this is an override method.
17680 (MethodCore.CheckBase): Moved from Method class and made common.
17681 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17683 (MethodCore.CheckForDuplications): New abstract method. For custom
17684 member duplication search in a container
17685 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17686 method and its return type.
17687 (Event.conflict_symbol): New member. Symbol with same name in the
17691 (MemberCache.FindMemberWithSameName): New method. The method
17692 is looking for conflict with inherited symbols.
17694 2004-08-04 Martin Baulig <martin@ximian.com>
17696 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17698 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17700 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17702 * report.cs (Message): New enum for better error, warning reference in
17704 (MessageData): New inner abstract class. It generally handles printing of
17705 error and warning messages.
17706 Removed unused Error, Warning, Message methods.
17708 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17710 Fix for cs0592-8.cs test
17712 (Attributable.ValidAttributeTargets): Made public.
17713 (Attribute.ExplicitTarget): New member for explicit target value.
17714 (Attribute.CheckTargets): Now we translate explicit attribute
17715 target to Target here.
17717 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17719 * ecore.cs (MethodGroupExpr): new IsBase property.
17721 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17723 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17724 rather than an instance expr.
17726 (DelegateCreation.Emit): Use the method group rather than
17727 the instance expression. Also, if you have base.Foo as the
17728 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17730 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17732 (NewDelegate.DoResolve): Only check for the existance of Invoke
17733 if the method is going to be needed. Use MethodGroupExpr.
17735 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17737 * expression.cs: For pointer arith., make sure to use
17738 the size of the type, not the size of the pointer to
17741 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17744 * class.cs (Class): Added error CS0502 test.
17746 2004-08-03 John Luke <jluke@cfl.rr.com>
17747 Raja R Harinath <rharinath@novell.com>
17750 * attribute.cs (Attribute.complained_before): New flag.
17751 (Attribute.ResolveType, Attribute.Resolve),
17752 (Attribute.DefinePInvokeMethod): Set it.
17753 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17755 2004-08-03 Martin Baulig <martin@ximian.com>
17757 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17758 use a user-defined operator; we still need to do numeric
17759 promotions in case one argument is a builtin type and the other
17760 one has an implicit conversion to that type. Fixes #62322.
17762 2004-08-02 Martin Baulig <martin@ximian.com>
17764 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17765 (LocalInfo.IsThis): New public property.
17766 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17768 2004-08-01 Martin Baulig <martin@ximian.com>
17770 * class.cs (TypeContainer.GetClassBases): Don't set the default
17771 here since we may get called from GetPartialBases().
17772 (TypeContainer.DefineType): If GetClassBases() didn't return a
17773 parent, use the default one.
17775 2004-07-30 Duncan Mak <duncan@ximian.com>
17777 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17779 2004-07-30 Martin Baulig <martin@ximian.com>
17781 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17783 * class.cs (SourceMethod): New public class, derive from the
17784 symbol writer's ISourceMethod.
17785 (Method): Use the new symbol writer API.
17787 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17788 as argument and use the new symbol writer.
17791 (SourceFile): Implement the symbol writer's ISourceFile.
17792 (Location.SymbolDocument): Removed.
17793 (Location.SourceFile): New public property.
17795 * symbolwriter.cs: Use the new symbol writer API.
17797 2004-07-30 Raja R Harinath <rharinath@novell.com>
17799 * Makefile (install-local): Remove. Functionality moved to
17802 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17804 * Makefile: Install mcs.exe.config file together with mcs.exe.
17805 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17806 correct runtime version.
17808 2004-07-25 Martin Baulig <martin@ximian.com>
17811 (TypeContainer.RegisterOrder): Removed, this was unused.
17812 (TypeContainer, interface_order): Removed.
17813 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17814 TypeContainer as argument since we can also be called with a
17815 `PartialContainer' for a partial class/struct/interface.
17816 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17817 of checking whether we're an `Interface' - we could be a
17818 `PartialContainer'.
17819 (PartialContainer.Register): Override; call
17820 AddClass()/AddStruct()/AddInterface() on our parent.
17822 * cs-parser.jay (interface_member_declaration): Add things to the
17823 `current_container', not the `current_class'.
17825 * rootcontext.cs (RegisterOrder): The overloaded version which
17826 takes an `Interface' was unused, removed.
17828 * typemanager.cs (TypeManager.LookupInterface): Return a
17829 `TypeContainer', not an `Interface'.
17830 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17831 contain a `PartialContainer' for an interface, so check it's
17832 `Kind' to figure out what it is.
17834 2004-07-25 Martin Baulig <martin@ximian.com>
17836 * class.cs (Class.DefaultTypeAttributes): New public constant.
17837 (Struct.DefaultTypeAttributes): Likewise.
17838 (Interface.DefaultTypeAttributes): Likewise.
17839 (PartialContainer.TypeAttr): Override this and add the
17840 DefaultTypeAttributes.
17842 2004-07-25 Martin Baulig <martin@ximian.com>
17844 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17845 we can just use the `Parent' field instead.
17847 2004-07-25 Martin Baulig <martin@ximian.com>
17849 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17851 2004-07-25 Martin Baulig <martin@ximian.com>
17853 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17854 our parts before defining any methods.
17855 (TypeContainer.VerifyImplements): Make this virtual.
17856 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17857 on our PartialContainer.
17859 2004-07-25 Martin Baulig <martin@ximian.com>
17861 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17863 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17864 argument, we can just use the `Parent' field instead.
17867 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17868 (MemberBase.DoDefine): Likewise.
17870 2004-07-24 Martin Baulig <martin@ximian.com>
17872 * decl.cs (MemberCore.Parent): New public field.
17873 (DeclSpace.Parent): Moved to MemberCore.
17875 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17876 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17878 (FieldBase, Field, Operator): Likewise.
17879 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17880 (EventField, Event): Likewise.
17882 2004-07-23 Martin Baulig <martin@ximian.com>
17884 * class.cs (PartialContainer): New public class.
17885 (ClassPart): New public class.
17886 (TypeContainer): Added support for partial classes.
17887 (TypeContainer.GetClassBases): Splitted some of the functionality
17888 out into GetNormalBases() and GetPartialBases().
17890 * cs-tokenizer.cs (Token.PARTIAL): New token.
17891 (Tokenizer.consume_identifier): Added some hacks to recognize
17892 `partial', but only if it's immediately followed by `class',
17893 `struct' or `interface'.
17895 * cs-parser.jay: Added support for partial clases.
17897 2004-07-23 Martin Baulig <martin@ximian.com>
17899 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17900 a `DeclSpace' and also made it readonly.
17901 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17902 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17903 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17905 * cs-parser.jay: Pass the `current_class', not the
17906 `current_container' (at the moment, this is still the same thing)
17907 to a new Method, Property, Event, Indexer or Constructor.
17909 2004-07-23 Martin Baulig <martin@ximian.com>
17911 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17912 and removed the `current_interface' one.
17913 (struct_declaration, class_declaration, interface_declaration):
17914 Set `current_class' to the newly created class/struct/interface;
17915 set their `Bases' and call Register() before parsing their body.
17917 2004-07-23 Martin Baulig <martin@ximian.com>
17919 * class.cs (Kind): New public enum.
17920 (TypeContainer): Made this class abstract.
17921 (TypeContainer.Kind): New public readonly field.
17922 (TypeContainer.CheckDef): New public method; moved here from
17924 (TypeContainer.Register): New public abstract method.
17925 (TypeContainer.GetPendingImplementations): New public abstract
17927 (TypeContainer.GetClassBases): Removed the `is_class' and
17928 `is_iface' parameters.
17929 (TypeContainer.DefineNestedTypes): Formerly known as
17931 (ClassOrStruct): Made this class abstract.
17933 * tree.cs (RootTypes): New public type.
17935 2004-07-20 Martin Baulig <martin@ximian.com>
17937 * tree.cs (Tree.RecordNamespace): Removed.
17938 (Tree.Namespaces): Removed.
17940 * rootcontext.cs (RootContext.IsNamespace): Removed.
17942 * cs-parser.jay (namespace_declaration): Just create a new
17943 NamespaceEntry here.
17945 2004-07-20 Martin Baulig <martin@ximian.com>
17947 * statement.cs (ExceptionStatement): New abstract class. This is
17948 now used as a base class for everyone who's using `finally'.
17949 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17950 our local variables before using them.
17952 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17953 virtual method. This is used by Yield.Resolve() to "steal" an
17954 outer block's `finally' clauses.
17955 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17958 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17959 version which takes an ExceptionStatement. This version must be
17960 used to create exception branchings.
17963 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17964 (Iterator.EmitMoveNext): Added exception support; protect the
17965 block with a `fault' clause, properly handle 'finally' clauses.
17966 (Iterator.EmitDispose): Run all the `finally' clauses here.
17968 2004-07-20 Martin Baulig <martin@ximian.com>
17970 * iterator.cs: This is the first of a set of changes in the
17971 iterator code. Match the spec more closely: if we're an
17972 IEnumerable, then GetEnumerator() must be called. The first time
17973 GetEnumerator() is called, it returns the current instance; all
17974 subsequent invocations (if any) must create a copy.
17976 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17978 * expression.cs: Resolve the constant expression before returning
17981 2004-07-19 Martin Baulig <martin@ximian.com>
17983 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17984 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17985 the return type of the new EmitContext.
17987 2004-07-18 Martin Baulig <martin@ximian.com>
17989 * class.cs (Property.Define): Fix iterators.
17991 * iterators.cs (Iterator.Define): Moved the
17992 `container.AddInterator (this)' call here from the .ctor; only do
17993 it if we resolved successfully.
17995 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17997 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17998 `true' for preprocessing directives that we parse. The return
17999 value indicates whether we should return to regular tokenizing or
18000 not, not whether it was parsed successfully.
18002 In the past if we were in: #if false ... #line #endif, we would
18003 resume parsing after `#line'. See bug 61604.
18005 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18006 building: IsEnumType should return true only for enums, not for
18007 enums or System.Enum itself. This fixes #61593.
18009 Likely what happened is that corlib was wrong: mcs depended on
18010 this bug in some places. The bug got fixed, we had to add the
18011 hack, which caused bug 61593.
18013 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18014 that was a workaround for the older conditions.
18016 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18018 * assign.cs: IAssignMethod has a new interface, as documented
18019 inline. All assignment code now uses this new api.
18021 * ecore.cs, expression.cs: All classes which implement
18022 IAssignMethod now use the new interface.
18024 * expression.cs (Invocation): add a hack to EmitCall so that
18025 IndexerAccess can be the target of a compound assignment without
18026 evaluating its arguments twice.
18028 * statement.cs: Handle changes in Invocation api.
18030 2004-07-16 Martin Baulig <martin@ximian.com>
18032 * iterators.cs: Rewrote this. We're now using one single Proxy
18033 class for both the IEnumerable and the IEnumerator interface and
18034 `Iterator' derives from Class so we can use the high-level API.
18036 * class.cs (TypeContainer.AddIterator): New method.
18037 (TypeContainer.DoDefineType): New protected virtual method, which
18038 is called from DefineType().
18039 (TypeContainer.DoDefineMembers): Call DefineType() and
18040 DefineMembers() on all our iterators.
18041 (TypeContainer.Emit): Call Emit() on all our iterators.
18042 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18044 * codegen.cs (EmitContext.CurrentIterator): New public field.
18046 2004-07-15 Martin Baulig <martin@ximian.com>
18049 (TypeManager.not_supported_exception_type): New type.
18051 2004-07-14 Martin Baulig <martin@ximian.com>
18053 * iterators.cs: Use real error numbers.
18055 2004-07-14 Martin Baulig <martin@ximian.com>
18057 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18058 requires this to be a System.Collection.IEnumerable and not a
18059 class implementing that interface.
18060 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18062 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18064 * class.cs: Fixed previous fix, it broke some error tests.
18066 2004-07-12 Martin Baulig <martin@ximian.com>
18068 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18071 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18073 * assign.cs (LocalTemporary): Add new argument: is_address,If
18074 `is_address' is true, then the value that we store is the address
18075 to the real value, and not the value itself.
18077 * ecore.cs (PropertyExpr): use the new local temporary
18078 stuff to allow us to handle X.Y += z (where X is a struct)
18080 2004-07-08 Martin Baulig <martin@ximian.com>
18082 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18083 not always return, just like we're doing in Using.Resolve().
18085 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18087 * cs-parser.jay (fixed_statement): flag this as Pinned.
18089 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18091 * typemanager.cs (TypeManager): Removed MakePinned method, this
18092 mechanism is replaced with the .NET 2.x compatible mechanism of
18093 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18095 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18096 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18097 `IsFixed' property which has a different meaning.
18099 2004-07-02 Raja R Harinath <rharinath@novell.com>
18101 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18102 visible from inside a nested class, not just the names of the
18103 immediately enclosing class.
18104 Fix for bug #60730.
18106 2004-06-24 Raja R Harinath <rharinath@novell.com>
18108 * expression.cs (BetterConversion): Remove buggy special-case
18109 handling of "implicit constant expression conversions". At this
18110 point, we already know that the conversion is possible -- we're
18111 only checking to see which is better.
18113 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18115 * cs-parser.jay: Added error CS0210 test.
18117 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18119 * cs-parser.jay: Added error CS0134 test.
18121 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18124 * cs-parser.jay: Added error CS0145 test.
18126 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18128 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18130 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18132 * expression.cs (StackAlloc.Resolve): The argument may not
18133 be a constant; deal with this case.
18135 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18137 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18138 GetIndexerAttributeValue.
18139 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18141 * class.cs (Indexer.Define): Added error tests for CS0415,
18144 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18146 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18149 2004-06-23 Martin Baulig <martin@ximian.com>
18151 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18152 neither return nor throw, reset the barrier as well. Fixes #60457.
18154 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18156 * class.cs : EventAttributes is now set to None by default.
18157 This fixes bug #60459.
18159 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18162 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18163 Don't throw exception but return null (it's sufficient now).
18165 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18167 * typemanager.cs (GetArgumentTypes): Faster implementation.
18169 2004-06-18 Martin Baulig <martin@ximian.com>
18171 * attribute.cs (Attribute.Resolve): Check whether we're an
18172 EmptyCast which a Constant child. Fixes #60333.
18174 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18176 * statement.cs (EmitCollectionForeach): Account for the fact that
18177 not all valuetypes are in areas which we can take the address of.
18178 For these variables, we store to a temporary variable. Also, make
18179 sure that we dont emit a `callvirt' on a valuetype method.
18181 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18183 * expression.cs (StackAlloc.DoReSolve): Added test for
18184 negative parameter (CS0247).
18186 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18189 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18191 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18194 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18197 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18199 Fix bug #58254 & cs1555.cs, cs1556.cs
18200 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18202 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18204 * cs-parser.jay: Added error CS1669 test for indexers.
18206 2004-06-11 Martin Baulig <martin@ximian.com>
18208 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18209 call this twice: for params and varargs methods.
18211 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18214 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18216 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18218 * attribute.cs (Attribute.GetValidTargets): Made public.
18221 (AbstractPropertyEventMethod): New class for better code sharing.
18222 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18224 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18226 2004-06-11 Raja R Harinath <rharinath@novell.com>
18229 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18230 that the call to Resolve is part of a MemberAccess.
18231 (Expression.Resolve): Use it for SimpleName resolution.
18232 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18233 Add 'intermediate' boolean argument.
18234 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18235 error message when the SimpleName can be resolved ambiguously
18236 between an expression and a type.
18237 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18239 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18240 call on the left-side.
18242 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18245 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18247 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18249 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18251 2004-06-11 Martin Baulig <martin@ximian.com>
18253 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18254 varargs methods if applicable.
18256 2004-06-11 Martin Baulig <martin@ximian.com>
18258 * expression.cs (Invocation.EmitCall): Don't use
18259 `method.CallingConvention == CallingConventions.VarArgs' since the
18260 method could also have `CallingConventions.HasThis'.
18262 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18264 * class.cs (Event.GetSignatureForError): Implemented.
18265 Fixed crash in error test cs3010.cs
18267 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18269 * cs-tokenizer.cs: Change the way we track __arglist to be
18270 consistent with the other keywords.
18272 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18274 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18277 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18279 * codegen.cs: Check that all referenced assemblies have a strongname
18280 before strongnaming the compiled assembly. If not report error CS1577.
18281 Fix bug #56563. Patch by Jackson Harper.
18282 * typemanager.cs: Added a method to return all referenced assemblies.
18283 Fix bug #56563. Patch by Jackson Harper.
18285 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18288 (Method.ApplyAttributeBuilder): Moved and added conditional
18289 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18292 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18294 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18297 * class.cs: (EventField.attribute_targets): Changed default target.
18299 2004-06-08 Martin Baulig <martin@ximian.com>
18301 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18303 2004-06-08 Martin Baulig <martin@ximian.com>
18305 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18307 2004-06-07 Martin Baulig <martin@ximian.com>
18309 Added support for varargs methods.
18311 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18314 * cs-parser.jay: Added support for `__arglist'.
18316 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18318 * expression.cs (Argument.AType): Added `ArgList'.
18319 (Invocation): Added support for varargs methods.
18320 (ArglistAccess): New public class.
18321 (Arglist): New public class.
18323 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18325 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18326 a method's top-level block if the method has varargs.
18328 * support.cs (ReflectionParameters, InternalParameters): Added
18329 support for varargs methods.
18331 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18333 * class.cs: Provide location in indexer error report.
18335 * driver.cs: Use standard names.
18337 * namespace.cs: Catch the use of using after a namespace has been
18338 declared also on using aliases.
18340 2004-06-03 Raja R Harinath <rharinath@novell.com>
18343 * typemanager.cs (closure_private_ok, closure_invocation_type)
18344 (closure_qualifier_type, closure_invocation_assembly)
18345 (FilterWithClosure): Move to ...
18346 (Closure): New internal nested class.
18347 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18348 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18349 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18350 (MemberLookup, MemberLookupFailed): Use it.
18351 * expression.cs (New.DoResolve): Treat the lookup for the
18352 constructor as being qualified by the 'new'ed type.
18353 (Indexers.GetIndexersForTypeOrInterface): Update.
18355 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18358 (GetConditionalAttributeValue): New method. Returns
18359 condition of ConditionalAttribute.
18360 (SearchMulti): New method. Returns all attributes of type 't'.
18361 Use it when attribute is AllowMultiple = true.
18362 (IsConditionalMethodExcluded): New method.
18365 (Method.IsExcluded): Implemented. Returns true if method has conditional
18366 attribute and the conditions is not defined (method is excluded).
18367 (IMethodData): Extended interface for ConditionalAttribute support.
18368 (PropertyMethod.IsExcluded): Implemented.
18371 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18374 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18377 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18379 * expression.cs (ArrayCreationExpression): Make this just an
18380 `expression'. It can't be a statement, so the code here was
18383 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18386 * typemanager.cs (GetFullNameSignature): New method for
18389 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18392 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18393 Use this method when MethodBuilder is null.
18394 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18395 Added test for error CS0626 (MONO reports error for this situation).
18396 (IMethodData.GetSignatureForError): Extended interface.
18398 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18401 (AttributeTester.GetObsoleteAttribute): Returns instance of
18402 ObsoleteAttribute when type is obsolete.
18405 (TypeContainer.VerifyObsoleteAttribute): Override.
18406 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18407 (MethodCode.VerifyObsoleteAttribute): Override.
18408 (MemberBase.VerifyObsoleteAttribute): Override.
18411 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18412 and report proper error.
18415 Delegate.VerifyObsoleteAttribute): Override.
18418 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18419 and report proper error.
18420 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18423 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18427 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18428 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18429 Added test for ObsoleteAttribute.
18432 (Catch): Derived from Statement.
18434 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18436 Fixed bug #59071 & cs0160.cs
18438 * statement.cs (Try.Resolve): Check here whether order of catch
18439 clauses matches their dependencies.
18441 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18443 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18444 caused a regression: #59343. Referencing nested classes from an
18445 assembly stopped working.
18447 2004-05-31 Martin Baulig <martin@ximian.com>
18449 MCS is now frozen for beta 2.
18451 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18453 * convert.cs: add a trivial cache for overload operator resolution.
18455 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18457 * decl.cs: If possible, use lookuptypedirect here. We can only do
18458 this if there is no `.' after the namespace. Avoids using
18459 LookupType, which does lots of slow processing.
18460 (FindNestedType) New method, does what it says :-).
18461 * namespace.cs: use LookupTypeDirect.
18462 * rootcontext.cs: use membercache, if possible.
18463 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18465 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18468 According to the spec,
18470 In a member access of the form E.I, if E is a single identifier,
18471 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18472 field, property, localvariable, or parameter with the same type as
18473 the meaning of E as a type-name (§3.8), then both possible
18474 meanings of E are permitted.
18476 We did not check that E as a simple-name had the same type as E as
18479 This trivial check gives us 5-7% on bootstrap time.
18481 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18483 * expression.cs (Invocation.OverloadResolve): Avoid the
18484 use of hashtables and boxing here by allocating on demand.
18486 2004-05-30 Martin Baulig <martin@ximian.com>
18488 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18489 we're doing a silent lookup. Don't try to lookup nested types in
18490 TypeManager.object_type (thanks to Ben Maurer).
18492 2004-05-30 Martin Baulig <martin@ximian.com>
18494 Committing a patch from Ben Maurer.
18496 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18498 2004-05-29 Martin Baulig <martin@ximian.com>
18500 * class.cs (IMethodData.ShouldIgnore): New method.
18502 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18503 `Location' argument, we don't need it anywhere. Use
18504 `IMethodData.ShouldIgnore ()' instead of
18505 `MethodData.GetMethodFlags ()'.
18506 (TypeManager.AddMethod): Removed.
18507 (TypeManager.AddMethod2): Renamed to AddMethod.
18509 2004-05-29 Martin Baulig <martin@ximian.com>
18511 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18513 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18514 converting from a class type S to an interface type and we already
18515 have an object on the stack, don't box it again. Fixes #52578.
18517 2004-05-29 Martin Baulig <martin@ximian.com>
18519 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18520 Added support for `params' parameters. Fixes #59267.
18522 2004-05-29 Martin Baulig <martin@ximian.com>
18524 * literal.cs (NullPointer): Provide a private .ctor which sets
18525 `type' to TypeManager.object_type. Fixes #59048.
18527 2004-05-29 Martin Baulig <martin@ximian.com>
18529 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18530 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18532 * ecore.cs (EventExpr.instance_expr): Make the field private.
18534 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18536 Fixed bug #50080 & cs0214-2.cs
18537 * expression.cs (Cast.DoResolve): Check unsafe context here.
18539 * statement.cs (Resolve.DoResolve): Likewise.
18541 2004-05-26 Martin Baulig <martin@ximian.com>
18543 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18545 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18546 (RootContext.LookupType): Pass down the `silent' flag.
18548 2004-05-25 Martin Baulig <martin@ximian.com>
18551 (MethodGroupExpr.IdenticalTypeName): New public property.
18552 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18553 expression actually refers to a type.
18555 2004-05-25 Martin Baulig <martin@ximian.com>
18557 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18558 for #56176 and made it actually work.
18560 2004-05-25 Martin Baulig <martin@ximian.com>
18562 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18563 (FieldExpr, PropertyExpr): Override and implement
18564 CacheTemporaries. Fixes #52279.
18566 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18568 * location.cs: In the new compiler listing a file twice is a
18569 warning, not an error.
18571 2004-05-24 Martin Baulig <martin@ximian.com>
18573 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18574 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18576 2004-05-24 Martin Baulig <martin@ximian.com>
18578 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18579 walking the `using' list. Fixes #53921.
18581 2004-05-24 Martin Baulig <martin@ximian.com>
18583 * const.cs (Const.LookupConstantValue): Added support for
18584 EmptyCast's; fixes #55251.
18586 2004-05-24 Martin Baulig <martin@ximian.com>
18588 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18589 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18590 which does the CS0135 check. The reason is that we first need to
18591 check whether the variable actually exists.
18593 2004-05-24 Martin Baulig <martin@ximian.com>
18595 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18596 than RootContext.LookupType() to find the explicit interface
18597 type. Fixes #58584.
18599 2004-05-24 Raja R Harinath <rharinath@novell.com>
18601 * Makefile: Simplify. Use executable.make.
18602 * mcs.exe.sources: New file. List of sources of mcs.exe.
18604 2004-05-24 Anders Carlsson <andersca@gnome.org>
18608 Use the invariant culture when doing String.Compare for CLS case
18611 2004-05-23 Martin Baulig <martin@ximian.com>
18613 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18614 don't have any dots. Fixes #52622, added cs0246-8.cs.
18616 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18618 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18620 * class.cs (MemberBase.Define): Reuse MemberType member for
18621 resolved type. Other methods can use it too.
18623 2004-05-23 Martin Baulig <martin@ximian.com>
18625 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18626 the variable also exists in the current block (otherwise, we need
18627 to report a CS0103). Fixes #58670.
18629 2004-05-23 Martin Baulig <martin@ximian.com>
18631 * flowanalysis.cs (Reachability.Reachable): Compute this
18632 on-the-fly rather than storing it as a field.
18634 2004-05-23 Martin Baulig <martin@ximian.com>
18636 * flowanalysis.cs (Reachability.And): Manually compute the
18637 resulting `barrier' from the reachability.
18639 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18642 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18643 instance of ObsoleteAttribute when symbol is obsolete.
18646 (IMethodData): Extended interface for ObsoleteAttribute support.
18648 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18650 * attribute.cs: Fix bug #55970
18652 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18656 (GetObsoleteAttribute): New method. Creates the instance of
18658 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18659 ObsoleteAttribute when member is obsolete.
18660 (AttributeTester.Report_ObsoleteMessage): Common method for
18661 Obsolete error/warning reporting.
18664 (TypeContainer.base_classs_type): New member for storing parent type.
18667 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18668 for this MemberCore.
18670 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18672 * attribute.cs, const.cs: Fix bug #58590
18674 2004-05-21 Martin Baulig <martin@ximian.com>
18676 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18677 out parameters if the end of the method is unreachable. Fixes
18680 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18682 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18683 Hari was right, why extra method.
18685 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18687 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18689 2004-05-20 Martin Baulig <martin@ximian.com>
18691 Merged this back from gmcs to keep the differences to a minumum.
18693 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18694 instead of a Declspace.
18695 (Attribute.ResolveType): Likewise.
18696 (Attributes.Search): Likewise.
18697 (Attributes.Contains): Likewise.
18698 (Attributes.GetClsCompliantAttribute): Likewise.
18700 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18702 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18705 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18707 Fix bug #58688 (MCS does not report error when the same attribute
18710 * attribute.cs (Attribute.Emit): Distinction between null and default.
18712 2004-05-19 Raja R Harinath <rharinath@novell.com>
18714 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18715 of a top-level attribute without an attribute target.
18716 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18718 (Attribute.Conditional_GetConditionName),
18719 (Attribute.Obsolete_GetObsoleteMessage): Update.
18720 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18721 part of ScanForIndexerName.
18722 (Attribute.CanIgnoreInvalidAttribute): New function.
18723 (Attribute.ScanForIndexerName): Move to ...
18724 (Attributes.ScanForIndexerName): ... here.
18725 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18726 (Attributes.Search): New internal variant that can choose not to
18727 complain if types aren't resolved. The original signature now
18729 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18730 complaints suppressed.
18731 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18732 only if it not useful.
18733 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18734 top-level for attributes that are shared between the assembly
18735 and a top-level class.
18736 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18737 * class.cs: Update to reflect changes.
18738 (DefineIndexers): Fuse loops.
18739 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18740 a couple more variants of attribute names.
18742 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18744 Fix bug #52585 (Implemented explicit attribute declaration)
18747 (Attributable.ValidAttributeTargets): New abstract method. It gets
18748 list of valid attribute targets for explicit target declaration.
18749 (Attribute.Target): It holds target itself.
18750 (AttributeSection): Removed.
18751 (Attribute.CheckTargets): New method. It checks whether attribute
18752 target is valid for the current element.
18755 (EventProperty): New class. For events that are declared like
18756 property (with add and remove accessors).
18757 (EventField): New class. For events that are declared like field.
18760 * cs-parser.jay: Implemented explicit attribute target declaration.
18762 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18763 Override ValidAttributeTargets.
18766 (ReturnParameter): Class for applying custom attributes on
18768 (ParameterAtribute): New class. Class for applying custom
18769 attributes on the parameter type.
18771 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18773 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18776 (Method): Allow UNSAFE here.
18778 * modifiers.cs: Support unsafe reporting.
18780 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18782 * decl.cs: Fix bug #58478.
18784 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18786 * statement.cs: When checking for unreachable code on an EmptyStatement,
18787 set the location. Fixes bug #58488.
18789 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18791 * driver.cs: Add -pkg handling.
18793 From Gonzalo: UseShelLExecute=false
18795 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18798 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18800 (Attribute.IsClsCompliaceRequired): Moved to base for better
18802 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18803 when attribute is AttributeUsageAttribute.
18804 (Attribute.GetValidTargets): Simplified.
18805 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18806 attribute for this type.
18807 (Attribute.ApplyAttributes): Method renamed to Emit and make
18809 (GlobalAttributeSection): New class for special handling of global
18810 attributes (assembly, module).
18811 (AttributeSection.Emit): New method.
18813 * class.cs: Implemented Attributable abstract methods.
18814 (MethodCore.LabelParameters): Moved to Parameter class.
18815 (Accessor): Is back simple class.
18816 (PropertyMethod): Implemented Attributable abstract class.
18817 (DelegateMethod): Implemented Attributable abstract class.
18818 (Event): New constructor for disctintion between normal Event
18819 and Event with accessors.
18821 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18823 * codegen.cs, const.cs, decl.cs, delegate.cs:
18824 (CommonAssemblyModulClass): Implemented Attributable abstract class
18827 * enum.cs: Implement IAttributeSupport interface.
18828 (EnumMember): New class for emum members. Implemented Attributable
18832 (ParameterBase): Is abstract.
18833 (ReturnParameter): New class for easier [return:] attribute handling.
18835 * typemanager.cs: Removed builder_to_attr.
18837 2004-05-11 Raja R Harinath <rharinath@novell.com>
18840 * attribute.cs (Attribute.GetPositionalValue): New function.
18841 * class.cs (TypeContainer.VerifyMembers): New function.
18842 (TypeContainer.Emit): Use it.
18843 (ClassOrStruct): New base class for Class and Struct.
18844 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18845 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18847 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18848 then each non-static field should have a FieldOffset attribute.
18849 Otherwise, none of the fields should have a FieldOffset attribute.
18850 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18851 and FieldOffset attributes.
18852 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18853 (TypeManager.field_offset_attribute_type): New core types.
18854 (TypeManager.InitCoreTypes): Initialize them.
18856 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18858 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18859 Return correct type.
18862 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18864 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18865 be implicitly converted to ulong.
18867 * expression.cs: The logic for allowing operator &, | and ^ worked
18868 was wrong, it worked before because we did not report an error in
18869 an else branch. Fixes 57895.
18871 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18872 allow volatile fields to be reference types.
18874 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18876 * driver.cs: Add support for /debug-
18878 2004-05-07 Raja R Harinath <rharinath@novell.com>
18880 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18881 Add a 'complain' parameter to silence errors.
18882 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18883 silently overlooked type-resolutions.
18884 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18885 to reflect changes.
18886 (Attributes.Search): New function.
18887 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18888 (Attributes.GetAttributeFullName): Remove hack.
18889 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18890 Update to reflect changes.
18891 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18892 Use Attributes.Search instead of nested loops.
18894 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18897 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18898 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18899 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18901 * report.cs: (Report.Warning): Renamed to Warning_T because of
18902 parameter collision.
18904 2004-05-05 Raja R Harinath <rharinath@novell.com>
18906 * expression.cs (MemberAccess.ResolveMemberAccess):
18907 Exit with non-zero status after Report.Error.
18908 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18910 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18912 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18914 * support.cs: Don't hang when the file is empty.
18916 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18918 * support.cs: In SeekableStreamReader, compute the preamble size of the
18919 underlying stream. Position changes should take into account that initial
18922 2004-05-03 Todd Berman <tberman@sevenl.net>
18924 * driver.cs: remove unused GetSysVersion function.
18926 2004-05-03 Todd Berman <tberman@sevenl.net>
18928 * driver.cs: Remove the hack from saturday, as well as the hack
18929 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18930 link_paths to get that bit proper.
18932 2004-05-01 Todd Berman <tberman@sevenl.net>
18934 * driver.cs: Try a LoadFrom before a Load, this checks the current
18935 path. This is currently a bug in mono that is be fixed, however, this
18936 provides a workaround for now. This will be removed when the bug
18939 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18941 * CryptoConvert.cs: Updated to latest version. Fix issue with
18942 incomplete key pairs (#57941).
18944 2004-05-01 Todd Berman <tberman@sevenl.net>
18946 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18949 2004-04-30 Jackson Harper <jackson@ximian.com>
18951 * codegen.cs: Open keys readonly.
18953 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18955 * typemanager.cs: don't report cyclic struct layout when a struct
18956 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18957 which has 2 Pango.Rectangle fields.
18959 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18961 * expression.cs: Handle IntPtr comparisons with IL code
18962 rather than a method call.
18964 2004-04-29 Martin Baulig <martin@ximian.com>
18966 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18967 the list of PropertyInfo's in class hierarchy and find the
18968 accessor. Fixes #56013.
18970 2004-04-29 Martin Baulig <martin@ximian.com>
18972 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18974 2004-04-29 Martin Baulig <martin@ximian.com>
18976 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18978 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18980 2004-04-29 Martin Baulig <martin@ximian.com>
18982 * class.cs (ConstructorInitializer.Resolve): Check whether the
18983 parent .ctor is accessible. Fixes #52146.
18985 2004-04-29 Martin Baulig <martin@ximian.com>
18987 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18989 * statement.cs (Using.EmitLocalVariableDecls): Use
18990 TypeManager.idisposable_type, not typeof (IDisposable).
18991 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18993 2004-04-29 Martin Baulig <martin@ximian.com>
18995 * class.cs (Event.Define): Don't emit the field and don't set
18996 RTSpecialName and SpecialName for events on interfaces. Fixes
18999 2004-04-29 Raja R Harinath <rharinath@novell.com>
19001 Refactor Attribute.ApplyAttributes.
19002 * attribute.cs (Attributable): New base class for objects that can
19003 have Attributes applied on them.
19004 (Attribute): Make AttributeUsage fields public.
19005 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19006 (Attribute.IsInternalCall): New property.
19007 (Attribute.UsageAttr): Convert to a public read-only property.
19008 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19009 (Attribute.ResolveType, Attribute.Resolve)
19010 (Attribute.ScanForIndexerName): Update to reflect changes.
19011 (Attribute.CheckAttributeTarget): Re-format.
19012 (Attribute.ApplyAttributes): Refactor, to various
19013 Attributable.ApplyAttributeBuilder methods.
19014 * decl.cs (MemberCore): Make Attributable.
19015 * class.cs (Accessor): Make Attributable.
19016 (MethodData.ApplyAttributes): Use proper attribute types, not
19018 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19019 (TypeContainer.ApplyAttributeBuilder)
19020 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19021 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19022 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19023 (Operator.ApplyAttributeBuilder): New factored-out methods.
19024 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19025 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19026 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19027 * parameter.cs (ParameterBase): New Attributable base class
19028 that can also represent Return types.
19029 (Parameter): Update to the changes.
19031 2004-04-29 Jackson Harper <jackson@ximian.com>
19033 * driver.cs: Prefer the corlib system version when looking for
19034 assemblies in the GAC. This is still a hack, but its a better hack
19037 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19039 * decl.cs, enum.cs: Improved error 3005 reporting.
19041 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19042 (related_symbols): New private member for list of symbols
19043 related to reported error/warning.
19045 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19047 2004-04-29 Martin Baulig <martin@ximian.com>
19049 * ecore.cs (Expression.Constantify): If we're an enum and
19050 TypeManager.TypeToCoreType() doesn't give us another type, use
19051 t.UnderlyingSystemType. Fixes #56178.
19053 2004-04-29 Martin Baulig <martin@ximian.com>
19055 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19056 interfaces and for each interface, only add members directly
19057 declared in that interface. Fixes #53255.
19059 2004-04-28 Martin Baulig <martin@ximian.com>
19061 * expression.cs (ConditionalLogicalOperator): Use a temporary
19062 variable for `left' to avoid that we evaluate it more than once;
19065 2004-04-28 Martin Baulig <martin@ximian.com>
19067 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19070 2004-04-28 Martin Baulig <martin@ximian.com>
19072 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19075 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19076 whether the type is not void (CS1547).
19078 2004-04-28 Martin Baulig <martin@ximian.com>
19080 * expression.cs (Unary.DoResolveLValue): Override this and report
19081 CS0131 for anything but Operator.Indirection.
19083 2004-04-28 Martin Baulig <martin@ximian.com>
19085 Committing a patch from Ben Maurer; see bug #50820.
19087 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19090 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19093 2004-04-28 Martin Baulig <martin@ximian.com>
19095 Committing a patch from Ben Maurer; see bug #50820.
19097 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19100 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19103 2004-04-28 Martin Baulig <martin@ximian.com>
19105 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19106 (Block.AddLabel): Call DoLookupLabel() to only search in the
19109 2004-04-28 Martin Baulig <martin@ximian.com>
19111 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19112 comparing StringConstants and NullLiterals in Equality and Inequality.
19114 2004-04-28 Jackson Harper <jackson@ximian.com>
19116 * driver.cs: Attempt to load referenced assemblies from the
19117 GAC. This is the quick and dirty version of this method that
19118 doesnt take into account versions and just takes the first
19119 canidate found. Will be good enough for now as we will not have more
19120 then one version installed into the GAC until I update this method.
19122 2004-04-28 Martin Baulig <martin@ximian.com>
19124 * typemanager.cs (TypeManager.CheckStructCycles): New public
19125 static method to check for cycles in the struct layout.
19127 * rootcontext.cs (RootContext.PopulateTypes): Call
19128 TypeManager.CheckStructCycles() for each TypeContainer.
19129 [Note: We only need to visit each type once.]
19131 2004-04-28 Martin Baulig <martin@ximian.com>
19133 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19135 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19136 success and added `out object value'. Use a `bool resolved' field
19137 to check whether we've already been called rather than
19138 `ConstantValue != null' since this breaks for NullLiterals.
19140 2004-04-28 Raja R Harinath <rharinath@novell.com>
19142 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19143 setting of this flag, since the 'set' method may be non-public.
19145 2004-04-28 Raja R Harinath <rharinath@novell.com>
19147 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19148 check on current_vector.Block.
19150 2004-04-27 Martin Baulig <martin@ximian.com>
19152 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19153 a field initializer. Fixes #56459.
19155 2004-04-27 Martin Baulig <martin@ximian.com>
19157 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19158 we're not attempting to use an indexer. Fixes #52154.
19160 2004-04-27 Martin Baulig <martin@ximian.com>
19162 * statement.cs (Return): Don't create a return label if we don't
19163 need it; reverts my change from January 20th. Thanks to Ben
19166 2004-04-27 Martin Baulig <martin@ximian.com>
19168 According to the spec, `goto' can only leave a nested scope, but
19171 * statement.cs (Block.LookupLabel): Only lookup in the current
19172 block, don't recurse into parent or child blocks.
19173 (Block.AddLabel): Check in parent and child blocks, report
19174 CS0140/CS0158 if we find a duplicate.
19175 (Block): Removed this indexer for label lookups.
19176 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19177 this already does the error reporting for us.
19180 (FlowBranching.UsageVector.Block): New public variable; may be null.
19181 (FlowBranching.CreateSibling): Added `Block' argument.
19182 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19183 label for the target of a `goto' and check whether we're not
19184 leaving a `finally'.
19186 2004-04-27 Martin Baulig <martin@ximian.com>
19188 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19189 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19192 2004-04-27 Martin Baulig <martin@ximian.com>
19194 * statement.cs (Block.AddLabel): Also check for implicit blocks
19195 and added a CS0158 check.
19197 2004-04-27 Martin Baulig <martin@ximian.com>
19199 * flowanalysis.cs (FlowBranchingLoop): New class.
19200 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19201 UsageVector's instead of an ArrayList.
19202 (FlowBranching.Label): Likewise.
19203 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19204 (FlowBranching.AddBreakVector): New method.
19206 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19208 * attribute.cs: Small regression fix: only convert the type if we
19209 the type is different, fixes System.Drawing build.
19211 2004-04-27 Martin Baulig <martin@ximian.com>
19213 * attribute.cs (Attribute.Resolve): If we have a constant value
19214 for a named field or property, implicity convert it to the correct
19217 2004-04-27 Raja R Harinath <rharinath@novell.com>
19219 * statement.cs (Block.Block): Implicit blocks share
19220 'child_variable_names' fields with parent blocks.
19221 (Block.AddChildVariableNames): Remove.
19222 (Block.AddVariable): Mark variable as "used by a child block" in
19223 every surrounding block.
19224 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19225 been used in a child block, complain about violation of "Invariant
19226 meaning in blocks" rule.
19227 * cs-parser.jay (declare_local_variables): Don't use
19228 AddChildVariableNames.
19229 (foreach_statement): Don't create an implicit block: 'foreach'
19230 introduces a scope.
19232 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19234 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19235 converting from 0L to ulong. Fixes 57522.
19237 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19239 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19240 derived class hides via 'new' keyword field from base class (test-242.cs).
19241 TODO: Handle this in the more general way.
19243 * class.cs (CheckBase): Ditto.
19245 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19247 * decl.cs (caching_flags): New member for storing cached values
19249 (MemberCore.Flags): New enum where bit flags for caching_flags
19251 (MemberCore.cls_compliance): Moved to caching_flags.
19252 (DeclSpace.Created): Moved to caching_flags.
19254 * class.cs: Use caching_flags instead of DeclSpace.Created
19256 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19258 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19259 if we are only a derived class, not a nested class.
19261 * typemanager.cs: Same as above, but do this at the MemberLookup
19262 level (used by field and methods, properties are handled in
19263 PropertyExpr). Allow for the qualified access if we are a nested
19266 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19268 * class.cs: Refactoring.
19269 (IMethodData): New inteface; Holds links to parent members
19270 to avoid member duplication (reduced memory allocation).
19271 (Method): Implemented IMethodData interface.
19272 (PropertyBase): New inner classes for get/set methods.
19273 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19274 (Event): New inner classes for add/remove methods.
19275 (Event.DelegateMethod): Implemented IMethodData interface.
19277 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19278 EmitContext (related to class.cs refactoring).
19280 2004-04-21 Raja R Harinath <rharinath@novell.com>
19282 * delegate.cs (Delegate.VerifyApplicability): If the number of
19283 arguments are the same as the number of parameters, first try to
19284 verify applicability ignoring any 'params' modifier on the last
19288 2004-04-16 Raja R Harinath <rharinath@novell.com>
19290 * class.cs (TypeContainer.AddIndexer): Use
19291 'ExplicitInterfaceName' to determine if interface name was
19292 explicitly specified. 'InterfaceType' is not initialized at this time.
19293 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19294 Indexers array is already in the required order. Initialize
19295 'IndexerName' only if there are normal indexers.
19296 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19297 (TypeContainer.Emit): Emit DefaultMember attribute only if
19298 IndexerName is initialized.
19301 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19303 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19306 2004-04-15 Raja R Harinath <rharinath@novell.com>
19308 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19312 * attribute.cs (Attribute.Resolve): Check for duplicate named
19316 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19318 * iterators.cs (MarkYield): track whether we are in an exception,
19319 and generate code accordingly. Use a temporary value to store the
19320 result for our state.
19322 I had ignored a bit the interaction of try/catch with iterators
19323 since their behavior was not entirely obvious, but now it is
19324 possible to verify that our behavior is the same as MS .NET 2.0
19328 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19330 * iterators.cs: Avoid creating temporaries if there is no work to
19333 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19334 Enumerations, use TypeManager.EnumToUnderlying and call
19337 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19340 (This.Emit): Use EmitContext.EmitThis to emit our
19343 (This.EmitAssign): Ditto.
19345 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19346 codepaths, we will move all the functionality into
19349 (FieldExpr.EmitAssign): Ditto.
19351 This fixes several hidden bugs that I uncovered while doing a code
19352 review of this today.
19354 * codegen.cs (EmitThis): reworked so the semantics are more clear
19355 and also support value types "this" instances.
19357 * iterators.cs: Changed so that for iterators in value types, we
19358 do not pass the value type as a parameter.
19360 Initialization of the enumerator helpers is now done in the caller
19361 instead of passing the parameters to the constructors and having
19362 the constructor set the fields.
19364 The fields have now `assembly' visibility instead of private.
19366 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19368 * expression.cs (Argument.Resolve): Check if fields passed as ref
19369 or out are contained in a MarshalByRefObject.
19371 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19372 another compiler type.
19374 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19376 * class.cs (Indexer.Define): use the new name checking method.
19377 Also, return false on an error.
19378 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19379 (is_identifier_[start/part]_character): make static.
19381 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19383 * expression.cs (Binary.ResolveOperator): Do no append strings
19384 twice: since we can be invoked more than once (array evaluation)
19385 on the same concatenation, take care of this here. Based on a fix
19386 from Ben (bug #56454)
19388 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19390 * codegen.cs: Fix another case where CS1548 must be reported (when
19391 delay-sign isn't specified and no private is available #56564). Fix
19392 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19393 error when MCS is used on the MS runtime and we need to delay-sign
19394 (which seems unsupported by AssemblyBuilder - see #56621).
19396 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19398 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19399 (TypeManager.ComputeNamespaces): Faster implementation for
19402 * compiler.csproj: Updated AssemblyName to mcs.
19404 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19406 * rootcontext.cs: Add new types to the boot resolution.
19408 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19409 MulticastDelegate is not allowed.
19411 * typemanager.cs: Add new types to lookup: System.TypedReference
19414 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19415 check for TypedReference or ArgIterator, they are not allowed.
19417 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19418 makes us properly catch 1510 in some conditions (see bug 56016 for
19421 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19423 * CryptoConvert.cs: update from corlib version
19426 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19428 * class.cs (Indexer.Define): Check indexername declaration
19430 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19432 * attribute.cs (IsClsCompliant): Fixed problem with handling
19433 all three states (compliant, not-compliant, undetected).
19435 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19437 * attribute.cs (Attribute): Location is now public.
19438 (Resolve): Store resolved arguments (pos_values) in attribute class.
19439 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19440 (GetClsCompliantAttributeValue): New method that gets
19441 CLSCompliantAttribute value.
19442 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19443 if exists else null.
19444 (AttributeTester): New class for CLS-Compliant verification routines.
19446 * class.cs (Emit): Add CLS-Compliant verification.
19447 (Method.GetSignatureForError): Implemented.
19448 (Constructor.GetSignatureForError): Implemented
19449 (Constructor.HasCompliantArgs): Returns if constructor has
19450 CLS-Compliant arguments.
19451 (Constructor.Emit): Override.
19452 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19453 is needed to test only parameters.
19454 (FieldBase.GetSignatureForError): Implemented.
19455 (TypeContainer): New member for storing base interfaces.
19456 (TypeContainer.FindMembers): Search in base interfaces too.
19458 * codegen.cs (GetClsComplianceAttribute): New method that gets
19459 assembly or module CLSCompliantAttribute value.
19460 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19462 (ModuleClass.Emit): Add error 3012 test.
19464 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19466 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19467 state for all decl types.
19468 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19469 if CLS-Compliant tests are required.
19470 (IsClsCompliaceRequired): New method. Analyze whether code
19471 must be CLS-Compliant.
19472 (IsExposedFromAssembly): New method. Returns true when MemberCore
19473 is exposed from assembly.
19474 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19475 value or gets cached value.
19476 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19477 is explicitly marked with CLSCompliantAttribute.
19478 (IsIdentifierClsCompliant): New abstract method. This method is
19479 used to testing error 3005.
19480 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19481 for identifier and parameters CLS-Compliant testing.
19482 (VerifyClsCompliance): New method. The main virtual method for
19483 CLS-Compliant verifications.
19484 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19485 null. I don't know why is null (too many public members !).
19486 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19487 and get value of first CLSCompliantAttribute that found.
19489 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19490 (VerifyClsCompliance): Override and add extra tests.
19492 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19493 clscheck- disable CLS-Compliant verification event if assembly is has
19494 CLSCompliantAttribute(true).
19496 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19497 ApllyAttribute is now called in emit section as in the other cases.
19498 Possible future Emit integration.
19499 (IsIdentifierClsCompliant): New override.
19500 (VerifyClsCompliance): New override.
19501 (GetEnumeratorName): Returns full enum name.
19503 * parameter.cs (GetSignatureForError): Implemented.
19505 * report.cs (WarningData): New struct for Warning message information.
19506 (LocationOfPreviousError): New method.
19507 (Warning): New method. Reports warning based on the warning table.
19508 (Error_T): New method. Reports error based on the error table.
19510 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19511 verifications are done here.
19513 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19515 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19516 CLSCompliantAttribute.
19517 (all_imported_types): New member holds all imported types from other
19519 (LoadAllImportedTypes): New method fills static table with exported types
19520 from all referenced assemblies.
19521 (Modules): New property returns all assembly modules.
19523 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19525 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19526 throwing a parser error.
19528 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19529 which removes the hardcoded get_/set_ prefixes for properties, as
19530 IL allows for the properties to be named something else.
19534 * expression.cs: Do not override operand before we know if it is
19535 non-null. Fix 56207
19537 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19539 * typemanager.cs: support for pinned variables.
19541 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19543 * decl.cs, typemanager.cs: Avoid using an arraylist
19544 as a buffer if there is only one result set.
19546 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19548 * expression.cs: Make sure you cant call a static method
19549 with an instance expression, bug #56174.
19551 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19553 * class.cs (IsDuplicateImplementation): Improve error reporting to
19554 flag 663 (method only differs in parameter modifier).
19556 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19557 in preprocessor directives.
19559 * location.cs (LookupFile): Allow for the empty path.
19561 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19562 better approach for some of that patch, but its failing with the
19563 CharSet enumeration. For now try/catch will do.
19565 * typemanager.cs: Do not crash if a struct does not have fields.
19568 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19570 * expression.cs: cs0213, cant fix a fixed expression.
19573 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19575 * cs-parser.jay: detect invalid embeded statements gracefully.
19578 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19580 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19583 the invocation type may not be a subclass of the tye of the item/
19584 The type of the item must be a subclass of the invocation item.
19589 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19591 * attribute.cs: Added methods to get a string and a bool from an
19592 attribute. Required to information from AssemblyKeyFileAttribute,
19593 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19594 * codegen.cs: Modified AssemblyName creation to include support for
19595 strongnames. Catch additional exceptions to report them as CS1548.
19596 * compiler.csproj: Updated include CryptoConvert.cs.
19597 * compiler.csproj.user: Removed file - user specific configuration.
19598 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19599 Mono.Security assembly. The original class is maintained and tested in
19600 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19601 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19602 like CSC 8.0 (C# v2) supports.
19603 * Makefile: Added CryptoConvert.cs to mcs sources.
19604 * rootcontext.cs: Added new options for strongnames.
19606 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19608 * driver.cs: For --expect-error, report error code `2'
19609 if the program compiled with no errors, error code `1' if
19610 it compiled with an error other than the one expected.
19612 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19614 * compiler.csproj: Updated for Visual Studio .NET 2003.
19615 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19616 * compiler.sln: Updated for Visual Studio .NET 2003.
19618 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19620 * expression.cs: Fix bug #47234. We basically need to apply the
19621 rule that we prefer the conversion of null to a reference type
19622 when faced with a conversion to 'object' (csc behaviour).
19624 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19626 * statement.cs: Shorter form for foreach, eliminates
19627 a local variable. r=Martin.
19629 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19631 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19632 checks if we can use brtrue/brfalse to test for 0.
19633 * expression.cs: use the above in the test for using brtrue/brfalse.
19634 cleanup code a bit.
19636 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19638 * expression.cs: Rewrite string concat stuff. Benefits:
19640 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19641 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19642 rather than a concat chain.
19644 * typemanager.cs: Add lookups for more concat overloads.
19646 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19648 * expression.cs: Emit shorter il code for array init.
19665 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19667 * statement.cs: Before, two switch blocks would be merged if the
19668 total size of the blocks (end_item - begin_item + 1) was less than
19669 two times the combined sizes of the blocks.
19671 Now, it will only merge if after the merge at least half of the
19676 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19678 * class.cs : csc build fix for GetMethods(). See bug #52503.
19680 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19682 * expression.cs: Make sure fp comparisons work with NaN.
19683 This fixes bug #54303. Mig approved this patch a long
19684 time ago, but we were not able to test b/c the runtime
19687 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19689 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19691 2004-03-19 Martin Baulig <martin@ximian.com>
19693 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19694 error here and not in our caller.
19696 2004-03-19 Martin Baulig <martin@ximian.com>
19698 * interface.cs: Completely killed this file.
19699 (Interface): We're now a TypeContainer and live in class.cs.
19701 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19702 argument; we're now also called for interfaces.
19703 (TypeContainer.DefineMembers): Allow this method being called
19705 (TypeContainer.GetMethods): New public method; formerly known as
19706 Interface.GetMethod(). This is used by PendingImplementation.
19707 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19708 it's now private and non-static.
19709 (Interface): Moved this here; it's now implemented similar to
19711 (Method, Property, Event, Indexer): Added `bool is_interface'
19712 argument to their .ctor's.
19713 (MemberBase.IsInterface): New public field.
19715 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19716 instances instead of InterfaceMethod, InterfaceProperty, etc.
19717 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19718 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19720 2004-03-19 Martin Baulig <martin@ximian.com>
19722 * class.cs (MethodCore.IsDuplicateImplementation): New private
19723 method which does the CS0111 checking.
19724 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19725 Use IsDuplicateImplementation().
19727 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19729 * decl.cs (FindMemberToOverride): New method to find the correct
19730 method or property to override in the base class.
19732 - Make Method/Property use the above method to find the
19733 version in the base class.
19734 - Remove the InheritableMemberSignatureCompare as it is now
19737 This patch makes large code bases much faster to compile, as it is
19738 O(n) rather than O(n^2) to do this validation.
19740 Also, it fixes bug 52458 which is that nested classes are not
19741 taken into account when finding the base class member.
19743 Reviewed/Approved by Martin.
19745 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19747 * interface.cs: In all interface classes removed redundant
19748 member initialization.
19750 2004-03-16 Martin Baulig <martin@ximian.com>
19752 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19754 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19756 * decl.cs (DefineTypeAndParents): New helper method to define a
19757 type's containers before the type itself is defined; This is a
19758 bug exposed by the recent changes to Windows.Forms when an
19759 implemented interface was defined inside a class that had not been
19762 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19764 (Check): Loop correctly to report errors modifiers
19765 (UNSAFE was not in the loop, since it was the same as TOP).
19767 * interface.cs: Every interface member now takes a ModFlags,
19768 instead of a "is_new" bool, which we set on the base MemberCore.
19770 Every place where we called "UnsafeOk" in the interface, now we
19771 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19772 the unsafe settings from the member declaration instead of the
19773 container interface.
19775 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19777 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19778 `set_indexer_name' to the pending bits (one per type).
19780 We fixed a bug today that was picking the wrong method to
19781 override, since for properties the existing InterfaceMethod code
19782 basically ignored the method name. Now we make sure that the
19783 method name is one of the valid indexer names.
19785 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19787 * support.cs (SeekableStreamReader): Keep track of stream byte
19788 positions and don't mix them with character offsets to the buffer.
19790 Patch from Gustavo Giráldez
19792 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19794 * interface.cs (InterfaceSetGetBase): Removed double member
19795 initialization, base class does it as well.
19797 2004-03-13 Martin Baulig <martin@ximian.com>
19799 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19800 when compiling corlib.
19802 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19804 * convert.cs (ExplicitConversion): We were reporting an error on
19805 certain conversions (object_type source to a value type, when the
19806 expression was `null') before we had a chance to pass it through
19807 the user defined conversions.
19809 * driver.cs: Replace / and \ in resource specifications to dots.
19812 * class.cs: Add check for duplicate operators. Fixes 52477
19814 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19816 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19817 that are in the middle of the statements, not only at the end.
19820 * class.cs (TypeContainer.AddField): No longer set the
19821 `HaveStaticConstructor' flag, now we call it
19822 `UserDefineStaticConstructor' to diferentiate the slightly
19823 semantic difference.
19825 The situation is that we were not adding BeforeFieldInit (from
19826 Modifiers.TypeAttr) to classes that could have it.
19827 BeforeFieldInit should be set to classes that have no static
19832 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19834 And most importantly Zoltan's comment:
19836 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19838 "I think beforefieldinit means 'it's ok to initialize the type sometime
19839 before its static fields are used', i.e. initialization does not need
19840 to be triggered by the first access to the type. Setting this flag
19841 helps the JIT to compile better code, since it can run the static
19842 constructor at JIT time, and does not need to generate code to call it
19843 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19844 this flag for lots of classes like String.
19846 csc sets this flag if the type does not have an explicit static
19847 constructor. The reasoning seems to be that if there are only static
19848 initalizers for a type, and no static constructor, then the programmer
19849 does not care when this initialization happens, so beforefieldinit
19852 This bug prevents the AOT compiler from being usable, since it
19853 generates so many calls to mono_runtime_class_init that the AOT code
19854 is much slower than the JITted code. The JITted code is faster,
19855 because it does not generate these calls if the vtable is type is
19856 already initialized, which is true in the majority of cases. But the
19857 AOT compiler can't do this."
19859 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19861 * class.cs (MethodData.Emit): Refactor the code so symbolic
19862 information is generated for destructors; For some reasons we
19863 were taking a code path that did not generate symbolic information
19866 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19868 * class.cs: Create a Constructor.CheckBase method that
19869 takes care of all validation type code. The method
19870 contains some code that was moved from Define.
19872 It also includes new code that checks for duplicate ctors.
19873 This fixes bug #55148.
19875 2004-03-09 Joshua Tauberer <tauberer@for.net>
19877 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19878 a { ... }-style array creation invokes EmitStaticInitializers
19879 which is not good for reference-type arrays. String, decimal
19880 and now null constants (NullCast) are not counted toward
19881 static initializers.
19883 2004-03-05 Martin Baulig <martin@ximian.com>
19885 * location.cs (SourceFile.HasLineDirective): New public field;
19886 specifies whether the file contains or is referenced by a "#line"
19888 (Location.DefineSymbolDocuments): Ignore source files which
19889 either contain or are referenced by a "#line" directive.
19891 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19893 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19894 direct access to our parent, so check the method inline there.
19896 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19898 * expression.cs (Invocation.EmitCall): Miguel's last commit
19899 caused a regression. If you had:
19904 In Foo the implict this would be null.
19906 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19908 * expression.cs (Invocation.EmitCall): If the method is not
19909 virtual, do not emit a CallVirt to it, use Call.
19911 * typemanager.cs (GetFullNameSignature): Improve the method to
19912 cope with ".ctor" and replace it with the type name.
19914 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19915 as an argument the ConstructorBuilder where it is being defined,
19916 to catch the recursive constructor invocations.
19918 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19920 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19921 routines to check if a type is an enumerable/enumerator allow
19922 classes that implement the IEnumerable or IEnumerator interfaces.
19924 * class.cs (Property, Operator): Implement IIteratorContainer, and
19925 implement SetYields.
19927 (Property.Define): Do the block swapping for get_methods in the
19928 context of iterators. We need to check if Properties also
19929 include indexers or not.
19931 (Operator): Assign the Block before invoking the
19932 OperatorMethod.Define, so we can trigger the Iterator code
19935 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19936 Property and Operator classes are not created when we parse the
19937 declarator but until we have the block completed, so we use a
19938 singleton SimpleIteratorContainer.Simple to flag whether the
19939 SetYields has been invoked.
19941 We propagate this setting then to the Property or the Operator to
19942 allow the `yield' to function.
19944 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19946 * codegen.cs: Implemented attribute support for modules.
19947 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19948 Assembly/Module functionality.
19950 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19951 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19952 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19954 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19956 * interface.cs (FindMembers): The operation is performed on all base
19957 interfaces and not only on the first. It is required for future CLS Compliance patch.
19959 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19961 * statement.cs, codegen.cs:
19962 This patch deals with patterns such as:
19964 public class List : IEnumerable {
19966 public MyEnumerator GetEnumerator () {
19967 return new MyEnumerator(this);
19970 IEnumerator IEnumerable.GetEnumerator () {
19974 public struct MyEnumerator : IEnumerator {
19979 Before, there were a few things we did wrong:
19980 1) we would emit callvirt on a struct, which is illegal
19981 2) we emited ldarg when we needed to emit ldarga
19982 3) we would mistakenly call the interface methods on an enumerator
19983 type that derived from IEnumerator and was in another assembly. For example:
19985 public class MyEnumerator : IEnumerator
19987 Would have the interface methods called, even if there were public impls of the
19988 method. In a struct, this lead to invalid IL code.
19990 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19992 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19995 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19997 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19999 * cs-parser.jay: Fix small regression: we were not testing V2
20000 compiler features correctly.
20002 * interface.cs: If the emit context is null, then create one
20004 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20006 * decl.cs (GetSignatureForError): New virtual method to get full name
20007 for error messages.
20009 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20010 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20012 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20013 Duplicated members and code in these classes has been removed.
20014 Better encapsulation in these classes.
20016 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20018 * assign.cs (Assign.DoResolve): When dealing with compound
20019 assignments, there is a new rule in ECMA C# 2.4 (might have been
20020 there before, but it is documented here) that states that in:
20024 If b is of type int, and the `op' is a shift-operator, then the
20025 above is evaluated as:
20029 * expression.cs (Binary.ResolveOperator): Instead of testing for
20030 int/uint/long/ulong, try to implicitly convert to any of those
20031 types and use that in pointer arithmetic.
20033 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20034 method to print information for from the type, not from the
20035 null-method we were given.
20037 2004-02-01 Duncan Mak <duncan@ximian.com>
20039 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20040 parsing for cmd, fixes bug #53694.
20042 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20044 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20045 in the member name duplication tests. Property and operator name duplication
20046 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20048 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20050 * interface.cs (PopulateMethod): Fixed crash when interface method
20051 returns not existing type (error test cs0246-3.cs).
20053 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20055 * cs-parser.jay (interface_accessors): Re-write actions to also
20056 store attributes attached to get and set methods. Fix spelling
20059 (inteface_property_declaration): Modify accordingly.
20061 (InterfaceAccessorInfo): New helper class to store information to pass
20062 around between rules that use interface_accessors.
20064 * interface.cs (Emit): Apply attributes on the get and set
20065 accessors of properties and indexers too.
20067 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20068 right MethodBuilder when applying attributes to the get and set accessors.
20070 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20072 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20074 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20076 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20078 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20080 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20081 changes that treat `yield' specially when present before `break'
20082 or `return' tokens.
20084 * cs-tokenizer.cs: yield is no longer a keyword.
20086 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20088 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20089 setting for default constructors.
20090 For default constructors are almost every time set wrong Modifier. The
20091 generated IL code has been alright. But inside mcs this values was
20092 wrong and this was reason why several of my CLS Compliance tests
20095 2004-01-22 Martin Baulig <martin@ximian.com>
20097 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20098 not a QualifiedIdentifier. This is what `type_name_expression'
20099 was previously doing.
20100 (type_name_expression): Removed; the code is now in
20101 `namespace_or_type_name'.
20102 (qualified_identifier): Removed, use `namespace_or_type_name'
20104 (QualifiedIdentifier): Removed this class.
20106 2004-01-22 Martin Baulig <martin@ximian.com>
20108 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20109 not a string as alias name.
20111 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20113 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20114 #52730 bug, and instead compute correctly the need to use a
20115 temporary variable when requesting an address based on the
20116 static/instace modified of the field and the constructor.
20118 2004-01-21 Martin Baulig <martin@ximian.com>
20120 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20121 class and namespace before looking up aliases. Fixes #52517.
20123 2004-01-21 Martin Baulig <martin@ximian.com>
20125 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20126 assinged in a 'try'; fixes exception4.cs.
20128 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20129 * class.cs : Implemented parameter-less constructor for TypeContainer
20131 * decl.cs: Attributes are now stored here. New property OptAttributes
20133 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20135 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20137 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20139 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20140 (CSharpSignature): New method for indexer and property signature.
20142 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20144 * pending.cs (IsVirtualFilter): Faster implementation.
20146 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20148 * typemanager.cs: Avoid inclusion of same assembly more than once.
20150 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20152 * cs-parser.jay: Fixed problem where the last assembly attribute
20153 has been applied also to following declaration (class, struct, etc.)
20155 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20157 * class.cs: Added error CS0538, CS0539 reporting.
20158 Fixed crash on Microsoft runtime when field type is void.
20160 * cs-parser.jay: Added error CS0537 reporting.
20162 * pending.cs: Added error CS0535 reporting.
20163 Improved error report for errors CS0536, CS0534.
20165 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20167 Merge a few bits from the Anonymous Method MCS tree.
20169 * statement.cs (ToplevelBlock): New class for toplevel methods,
20170 will hold anonymous methods, lifted variables.
20172 * cs-parser.jay: Create toplevel blocks for delegates and for
20173 regular blocks of code.
20175 2004-01-20 Martin Baulig <martin@ximian.com>
20177 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20178 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20179 and `NeedExplicitReturn'; added `IsLastStatement'.
20180 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20181 have a `ReturnLabel' or we're not unreachable.
20183 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20184 child's reachability; don't just override ours with it. Fixes
20185 #58058 (lluis's example).
20186 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20187 InFinally(), InLoop(), InSwitch() and
20188 BreakCrossesTryCatchBoundary() methods.
20190 * statement.cs (Return): Do all error checking in Resolve().
20191 Unless we are the last statement in a top-level block, always
20192 create a return label and jump to it.
20193 (Break, Continue): Do all error checking in Resolve(); also make
20194 sure we aren't leaving a `finally'.
20195 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20196 statement in a top-level block.
20197 (Block.Flags): Added `IsDestructor'.
20198 (Block.IsDestructor): New public property.
20200 2004-01-20 Martin Baulig <martin@ximian.com>
20202 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20204 2004-01-20 Martin Baulig <martin@ximian.com>
20206 * statement.cs (Statement.ResolveUnreachable): New public method.
20207 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20208 (Block.Resolve): Resolve unreachable statements.
20210 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20212 * expression.cs: We need to fix the case where we do
20213 not have a temp variable here.
20215 * assign.cs: Only expression compound assignments need
20216 temporary variables.
20218 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20220 * flowanalysis.cs: Reduce memory allocation in a few ways:
20221 - A block with no variables should not allocate a bit
20223 - A method with no out parameters does not need any tracking
20224 for assignment of the parameters, so we need not allocate
20227 public readonly Type[] VariableTypes;
20228 public readonly string[] VariableNames;
20229 Are redundant. The data is already stored in the variable
20230 map, so we need not allocate another array for it.
20231 - We need to add alot of checks for if (params | locals) == null
20232 due to the first two changes.
20234 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20236 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20237 implement IMemoryLocation, we store a copy on a local variable and
20238 take the address of it. Patch from Benjamin Jemlich
20240 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20241 to use a special "type_name_expression" rule which reduces the
20242 number of "QualifiedIdentifier" classes created, and instead
20243 directly creates MemberAccess expressions.
20245 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20247 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20248 that fixes #52853. Null literal assignment to ValueType
20250 * class.cs (MethodData.Emit): Instead of checking the name of the
20251 method to determine if its a destructor, create a new derived
20252 class from Method called Destructor, and test for that.
20254 * cs-parser.jay: Create a Destructor object instead of a Method.
20256 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20260 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20262 * expression.cs (Binary.ResolveOperator): Perform an implicit
20263 conversion from MethodGroups to their delegate types on the
20264 Addition operation.
20266 * delegate.cs: Introduce a new class DelegateCreation that is the
20267 base class for `NewDelegate' and `ImplicitDelegateCreation',
20268 factor some code in here.
20270 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20271 conversion from MethodGroups to compatible delegate types.
20273 * ecore.cs (Expression.Resolve): Do not flag error 654
20274 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20275 we allow conversions from MethodGroups to delegate types now.
20277 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20278 assignments in v2 either.
20280 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20282 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20283 static read-only fields in ctors.
20285 Applied patch from Benjamin Jemlich
20287 * expression.cs (UnaryMutator): Avoid leaking local variables.
20289 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20291 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20292 here to return true, as they can be used like this:
20294 (XXX) int.MEMBER ()
20296 Fixed 49836 and all the other dups
20298 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20300 * driver.cs: Implement /win32res and /win32icon.
20302 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20304 * cs-parser.jay: Add a rule to improve error handling for the
20305 common mistake of placing modifiers after the type.
20307 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20309 * cs-parser.jay (interface_event_declaration): Catch
20310 initialization of events on interfaces, and report cs0068
20312 * cs-parser.jay (interface_event_declaration): Catch
20313 initialization of events.
20315 * ecore.cs: Better report missing constructors.
20317 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20318 the error reporting done in the wrong place. Fix.
20320 * expression.cs (Binary.ResolveOperator): Catch the
20321 operator + (E x, E y) error earlier, and later allow for implicit
20322 conversions in operator +/- (E e, U x) from U to the underlying
20325 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20326 52596, if the container class is abstract, the default constructor
20327 is protected otherwise its public (before, we were always public).
20329 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20332 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20333 Jemlich that fixes bug #52597, MCS was generating invalid code for
20334 idisposable structs. Thanks to Ben for following up with this
20337 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20339 * driver.cs: Allow assemblies without code to be generated, fixes
20342 2004-01-07 Nick Drochak <ndrochak@gol.com>
20344 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20346 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20348 * cs-parser.jay: Add rules to improve error reporting if fields or
20349 methods are declared at the namespace level (error 116)
20351 * Add rules to catch event add/remove
20353 2004-01-04 David Sheldon <dave-mono@earth.li>
20355 * expression.cs: Added matching ")" to error message for
20358 2004-01-03 Todd Berman <tberman@gentoo.org>
20360 * ecore.cs, attribute.cs:
20361 Applying fix from #52429.
20363 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20365 * ecore.cs, expression.cs, statement.cs:
20366 Total rewrite of how we handle branching. We
20367 now handle complex boolean expressions with fewer
20368 jumps. As well if (x == 0) no longer emits a ceq.
20370 if (x is Foo) is much faster now, because we generate
20373 Overall, we get a pretty big improvement on our benchmark
20374 tests. The code we generate is smaller and more readable.
20376 I did a full two-stage bootstrap. The patch was reviewed
20377 by Martin and Miguel.
20379 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20381 * cs-parser.jay: Make primary_expression not take a QI.
20382 we dont need this because the member_access rule covers
20383 us here. So we replace the rule with just IDENTIFIER.
20385 This has two good effects. First, we remove a s/r conflict.
20386 Second, we allocate many fewer QualifiedIdentifier objects.
20388 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20390 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20391 set the correct information via SRE. This prevents
20392 hanging on the MS runtime. Fixes #29374.
20394 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20396 * convert.cs: correctly handle conversions to value types
20397 from Enum and ValueType as unboxing conversions.
20399 Fixes bug #52569. Patch by Benjamin Jemlich.
20401 2004-01-02 Ravi Pratap <ravi@ximian.com>
20403 * expression.cs (BetterConversion): Prefer int -> uint
20404 over int -> ulong (csc's behaviour). This fixed bug #52046.
20406 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20408 * decl.cs (MemberCache.FindMembers): now returns a
20411 * typemanager.cs: In general, go with with ^^.
20412 (CopyNewMethods): take an IList.
20413 (RealMemberLookup): Only allocate an arraylist
20414 if we copy from two sets of methods.
20416 This change basically does two things:
20417 1) Fewer array lists allocated due to CopyNewMethods.
20418 2) the explicit cast in MemberList costed ALOT.
20420 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20422 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20423 a hashtable to avoid needless string allocations when an identifier is
20424 used more than once (the common case).
20426 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20428 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20429 is broken, it will not return anything. So, we
20430 have to use the information we have in mcs to
20433 * typemanager.cs: Add a cache for GetInterfaces,
20434 since this will now be used more often (due to ^^)
20436 (GetExplicitInterfaces) New method that gets the
20437 declared, not effective, interfaces on a type
20438 builder (eg, if you have interface IFoo, interface
20439 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20442 This patch makes MCS able to bootstrap itself on
20445 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20447 * expression.cs: Remove the Nop's that Miguel put
20450 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20452 * report.cs, codegen.cs: Give the real stack trace to
20453 the error when an exception is thrown.
20455 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20457 * decl.cs: only allocate hashtables for ifaces if
20460 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20462 * expression.cs: fix the error from cs0121-2.cs
20463 (a parent interface has two child interfaces that
20464 have a function with the same name and 0 params
20465 and the function is called through the parent).
20467 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20469 * class.cs, rootcontext.cs, typmanager.cs: do not
20472 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20474 * codegen.cs: remove stack for the ec flow branching.
20475 It is already a linked list, so no need.
20477 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20479 * Makefile: Allow custom profiler here.
20481 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20483 * typemanager.cs (LookupType):
20484 - Use a static char [], because split takes
20485 a param array for args, so it was allocating
20487 - Do not store true in a hashtable, it boxes.
20489 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20491 * flowanalysis.cs: bytify common enums.
20493 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20495 * modifiers.cs: Add a new set of flags for the
20496 flags allowed on explicit interface impls.
20497 * cs-parser.jay: catch the use of modifiers in
20498 interfaces correctly.
20499 * class.cs: catch private void IFoo.Blah ().
20501 All related to bug #50572.
20503 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20505 * decl.cs: Rewrite the consistant accessability checking.
20506 Accessability is not linear, it must be implemented in
20507 a tableish way. Fixes #49704.
20509 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20511 * expression.cs: Handle negation in a checked context.
20512 We must use subtraction from zero. Fixes #38674.
20514 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20516 * class.cs: Ignore static void main in DLLs.
20517 * rootcontext.cs: Handle the target type here,
20518 since we are have to access it from class.cs
20519 * driver.cs: account for the above.
20521 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20523 * report.cs: Give line numbers and files if available.
20525 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20527 * driver.cs: Implement /addmodule.
20529 * typemanager.cs: Change 'modules' field so it now contains Modules not
20532 2003-12-20 Martin Baulig <martin@ximian.com>
20534 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20535 (FieldBase.IsAssigned): Removed this field.
20536 (FieldBase.SetAssigned): New public method.
20537 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20539 2003-12-20 Martin Baulig <martin@ximian.com>
20541 * expression.cs (LocalVariableReference.DoResolve): Don't set
20542 `vi.Used' if we're called from DoResolveLValue().
20544 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20545 returns the usage vector it just merged into the current one -
20546 pass this one to UsageWarning().
20547 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20548 of the `EmitContext', don't call this recursively on our children.
20550 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20552 * driver.cs: Implement /target:module.
20554 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20556 * support.cs (CharArrayHashtable): New helper class.
20558 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20559 char arrays, not strings, so we can avoid creating a string in
20560 consume_identifier if the identifier is a keyword.
20562 2003-12-16 Martin Baulig <martin@ximian.com>
20564 * statement.cs (LocalInfo.Assigned): Removed this property.
20565 (LocalInfo.Flags): Removed `Assigned'.
20566 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20567 and uses flow analysis.
20568 (Block.UsageWarning): Made this method private.
20569 (Block.Resolve): Call UsageWarning() if appropriate.
20571 * expression.cs (LocalVariableReference.DoResolve): Always set
20572 LocalInfo.Used here.
20574 2003-12-13 Martin Baulig <martin@ximian.com>
20576 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20577 any value here; we're now using flow analysis to figure out
20578 whether a statement/block returns a value.
20580 2003-12-13 Martin Baulig <martin@ximian.com>
20582 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20584 (FlowBranching.MergeFinally): Don't call
20585 `branching.CheckOutParameters()' here, this is called in
20587 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20588 when adding the `finally' vector.
20590 2003-12-13 Martin Baulig <martin@ximian.com>
20593 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20594 actually work and also fix #48962.
20596 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20598 * decl.cs: Do not check System.Object for nested types,
20599 since we know it does not have any. Big bang for buck:
20602 Run 1: 8.35 seconds
20603 Run 2: 8.32 seconds
20604 corlib: 17.99 seconds
20606 Run 1: 8.17 seconds
20607 Run 2: 8.17 seconds
20608 corlib: 17.39 seconds
20610 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20612 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20613 time we are returning 0 members, so we save alot here.
20615 2003-12-11 Martin Baulig <martin@ximian.com>
20617 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20618 `MergeChild()', also just take the `FlowBranching' as argument;
20619 call Merge() on it and return the result.
20620 (FlowBranching.Merge): We don't need to do anything if we just
20623 2003-12-11 Martin Baulig <martin@ximian.com>
20625 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20626 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20627 Maurer for this idea.
20629 2003-12-11 Martin Baulig <martin@ximian.com>
20631 * flowanalysis.cs (MergeResult): This class is now gone; we now
20632 use the `UsageVector' for this. The reason for this is that if a
20633 branching just has one sibling, we don't need to "merge" them at
20634 all - that's the next step to do.
20635 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20638 2003-12-11 Martin Baulig <martin@ximian.com>
20640 Reworked flow analyis and made it more precise and bug-free. The
20641 most important change is that we're now using a special `Reachability'
20642 class instead of having "magic" meanings of `FlowReturns'. I'll
20643 do some more cleanups and optimizations and also add some more
20644 documentation this week.
20646 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20647 largely reworked this class.
20648 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20649 the new `Reachability' class instead of having "magic" values here.
20650 (FlowBranching): We're now using an instance of `Reachability'
20651 instead of having separate `Returns', `Breaks' etc. fields.
20653 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20654 based on flow analysis; ignore the return value of block.Emit ().
20656 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20658 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20659 if they are private.
20661 2003-12-09 Martin Baulig <martin@ximian.com>
20663 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20664 call them directly on the UsageVector.
20666 2003-12-09 Martin Baulig <martin@ximian.com>
20668 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20669 Changed return type from `FlowReturns' to `Reachability'.
20671 2003-12-09 Martin Baulig <martin@ximian.com>
20673 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20674 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20675 `Reachable' fields with a single `Reachability' one.
20677 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20679 * class.cs (FindMembers): Remove foreach's.
20684 Run 1: 8.74 seconds
20685 Run 2: 8.71 seconds
20688 Run 1: 8.64 seconds
20689 Run 2: 8.58 seconds
20692 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20697 This patch does a few things:
20698 1. EmptyStatement is now a singleton, so it is never reallocated.
20699 2. All blah is EmptyStatement constructs have been changed to
20700 blah == EmptyStatement.Value, which is much faster and valid
20701 now that EmptyStatement is a singleton.
20702 3. When resolving a block, rather than allocating a new array for
20703 the non-empty statements, empty statements are replaced with
20704 EmptyStatement.Value
20705 4. Some recursive functions have been made non-recursive.
20706 Mainly the performance impact is from (3), however (1) and (2) are needed for
20707 this to work. (4) does not make a big difference in normal situations, however
20708 it makes the profile look saner.
20713 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20714 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20715 Total memory allocated: 56397 KB
20718 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20719 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20720 Total memory allocated: 55666 KB
20722 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20724 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20725 than the hashtable in a hashtable version
20727 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20728 we always end up concating a string. This results in a huge perf
20729 loss, because many strings have to be tracked by the GC. In this
20730 patch, we first use a hashtable that works with two keys, so that
20731 the strings do not need to be concat'ed.
20735 Run 1: 8.74 seconds
20736 Run 2: 8.71 seconds
20739 Run 1: 8.65 seconds
20740 Run 2: 8.56 seconds
20742 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20744 * Makefile: Add a new target `do-time' that does a quick and simple
20745 profile, leaving easy to parse output.
20747 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20749 * codegen.cs (Init): Create the dynamic assembly with
20750 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20752 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20754 * support.cs: Make the PtrHashtable use only one
20755 instance of its comparer.
20757 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20759 * typemanager.cs: Fix lookup of GetNamespaces.
20761 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20763 * expression.cs: Removed redundant line.
20765 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20766 ArrayLists, use for loops with bounds.
20768 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20771 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20772 arraylists, use for loop with bounds.
20774 The above three changes give us a 0.071 second performance
20775 improvement out of 3.294 seconds down to 3.223. On my machine
20776 the above changes reduced the memory usage by 1,387 KB during
20777 compiler bootstrap.
20779 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20780 QualifiedIdentifiers. Before we created a new string through
20781 concatenation, and mostly later on, the result would be
20782 manipulated by DecomposeQI through string manipulation.
20784 This reduced the compiler memory usage for bootstrapping from
20785 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20786 compile times in 0.05 seconds.
20788 2003-11-28 Dick Porter <dick@ximian.com>
20790 * support.cs: Do string compares with the Invariant culture.
20798 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20799 the comparison is done with the Invariant culture.
20801 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20803 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20804 GetEnumerator method.
20806 (ProbeCollectionType): Iterate starting at the most specific type
20807 upwards looking for a GetEnumerator
20809 * expression.cs: Shift count can be up to 31 for int/uint and 63
20812 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20814 * statement.cs (Block.LookupLabel): Also look for the label on the
20815 children blocks. Use a hash table to keep track of visited
20818 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20819 we actually did transform the other operand, otherwise fall back
20820 to the common codepath that casts to long.
20822 * cs-tokenizer.cs: Use the same code pattern as the int case.
20823 Maybe I should do the parsing myself, and avoid depending on the
20824 Parse routines to get this done.
20826 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20828 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20829 which fixes bug 51347. This time test it.
20831 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20832 attributes for example can not tell the difference between these.
20833 The difference was only a syntax feature of the language.
20835 * attribute.cs: Apply attributes to delegates.
20837 * delegate.cs: Call the apply attributes method.
20839 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20841 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20842 comparing 0 vs Byte.MinValue, not the value
20844 (ImplicitConversionRequired): When reporting a conversion error,
20845 use error 31 to print out the constant error instead of the
20848 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20849 which fixes bug 51347.
20851 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20853 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20854 which fixes the -warnaserror command line option.
20856 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20858 * cfold.cs (DoNumericPromotions): During constant folding of
20859 additions on UIntConstant, special case intconstants with
20860 IntConstants like we do on the expression binary operator.
20862 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20864 * convert.cs (ImplicitReferenceConversion): We were missing a case
20865 (System.Enum are not value types or class types, so we need to
20866 classify them separatedly).
20868 * driver.cs: We do not support error 2007.
20870 2003-11-12 Jackson Harper <jackson@ximian.com>
20872 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20873 system directory. Also use the full file name so users can
20874 libraries names mscorlib-o-tron.dll in a non system dir.
20876 2003-11-10 Martin Baulig <martin@ximian.com>
20878 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20879 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20880 calling `ResolveType()' on them, directly assign their `Type'.
20882 2003-11-08 Martin Baulig <martin@ximian.com>
20884 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20885 return value and the `out parent' parameter.
20886 (TypeContainer.DefineType): Moved the CS0644 check into
20887 GetClassBases(). Don't pass the interface types to the
20888 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20889 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20891 * ecore.cs (TypeExpr.IsAttribute): New property.
20892 (TypeExpr.GetInterfaces): New method.
20894 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20895 TypeExpr instead of a Type.
20896 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20897 (Interface.DefineType): Don't pass the interface types to the
20898 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20899 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20901 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20902 instead of a `Type[]'.
20903 (TypeManager.RegisterBuilder): Likewise.
20904 (TypeManager.AddUserInterface): Likewise.
20905 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20906 `Type[]' and also return a `TypeExpr[]'.
20907 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20909 2003-11-08 Martin Baulig <martin@ximian.com>
20911 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20914 2003-11-08 Martin Baulig <martin@ximian.com>
20916 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20917 TypeManager.ResolveExpressionTypes().
20919 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20920 instead of an Expression.
20921 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20922 (TypeExpression): New public class; formerly known as `TypeExpr'.
20924 * expression.cs (ComposedCast): Derive from TypeExpr.
20926 * typemanager.cs (TypeManager.system_*_expr): These are now
20927 TypExpr's instead of Expression's.
20928 (TypeManager.ResolveExpressionTypes): New public static function;
20929 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20932 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20934 * expression.cs (New.DoResolve): Do not dereference value that
20935 might be a null return.
20937 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20938 sure that the constant value has the right type. Fixes an
20939 unreported bug, similar to 50425.
20941 * const.cs (Const.LookupConstantValue): Call
20942 ImplicitStandardConversionExists before doing a conversion to
20943 avoid havng the TypeManager.ChangeType do conversions.
20945 Reduced the number of casts used
20947 (Const.ChangeType): New routine to enable reuse of the constant
20948 type changing code from statement.
20950 * typemanager.cs (ChangeType): Move common initialization to
20951 static global variables.
20955 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20956 every value type to go through, even if it was void. Fix that.
20958 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20959 character of the define, and the is_identifier_part_character for
20960 the rest of the string.
20962 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20964 * expression.cs (UnaryMutator.EmitCode): When I updated
20965 LocalVariableReference.DoResolve, I overdid it, and dropped an
20966 optimization done on local variable references.
20968 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20970 * ecore.cs: Convert the return from Ldlen into an int.
20972 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20974 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20975 the accessibility, this is a special case for toplevel non-public
20976 classes (internal for instance).
20978 2003-10-20 Nick Drochak <ndrochak@gol.com>
20980 * ecore.cs: Fix typo and build. Needed another right paren.
20982 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20984 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20985 `internal' case regular and protected, but not allowing protected
20986 to be evaluated later. Bug 49840
20988 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20990 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20991 to kb.Nlast, and not the kb.nFirst to isolate the switch
20994 Extract the underlying type, so enumerations of long/ulong are
20995 treated like long/ulong.
20997 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20999 * expression.cs (New): Overload the meaning of RequestedType to
21000 track the possible creation of the NewDelegate type, since
21001 DoResolve is invoked more than once for new constructors on field
21004 See bugs: #48800 and #37014
21006 * cs-parser.jay (declare_local_constants): Take an arraylist
21007 instead of a single constant.
21009 (local_constant_declaration): It should take a
21010 constant_declarators, not a constant_declarator. Fixes 49487
21012 * convert.cs: Fix error report.
21014 2003-10-13 Jackson Harper <jackson@ximian.com>
21016 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21019 2003-10-09 Martin Baulig <martin@ximian.com>
21021 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21023 (MethodCore.DoDefineParameters): Removed the TypeContainer
21024 argument; use the DeclSpace which was passed to the .ctor instead.
21025 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21026 TypeContainer; we only need a DeclSpace here.
21028 2003-10-09 Martin Baulig <martin@ximian.com>
21030 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21032 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21033 EmitContext's .ctor.
21035 2003-10-09 Martin Baulig <martin@ximian.com>
21037 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21038 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21039 AsAccessible(), moved them as well.
21041 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21043 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21045 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21047 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21049 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21050 generation for >=, as spotted by Paolo, bug 48679.
21051 Patch from David Waite.
21053 * cs-tokenizer.cs: Add handling for #pragma.
21055 * cs-parser.jay: Allow for both yield and yield return in the
21056 syntax. The anti-cobolization of C# fight will go on!
21058 * class.cs (TypeBuilder.DefineType): Catch error condition here
21059 (Parent.DefineType erroring out and returning null).
21061 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21062 coping with enumerations variables, we were mistakenly processing
21063 them as a regular value type instead of built-in types. Fixes the
21066 * typemanager.cs (IsBuiltinOrEnum): New method.
21068 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21070 * cs-parser.jay: Upgrade: yield now needs the return clause.
21072 2003-09-19 Martin Baulig <martin@ximian.com>
21074 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21075 `MemberCache parent' argument. Normally, an interface doesn't
21076 have a parent type except System.Object, but we use this in gmcs
21077 for generic type parameters.
21079 2003-09-18 Martin Baulig <martin@ximian.com>
21081 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21082 on `type.IsInterface'; don't check whether the type has a parent
21083 to determine whether it's an interface.
21085 2003-09-15 Martin Baulig <martin@ximian.com>
21087 * class.cs (TypeContainer.DefineType): Added an error flag to
21088 avoid reporting duplicate CS0146's ("class definition is
21091 * driver.cs (Driver.MainDriver): Abort if
21092 RootContext.ResolveTree() reported any errors.
21094 2003-09-07 Martin Baulig <martin@ximian.com>
21096 * report.cs (Error, Warning): Added overloaded versions which take
21097 a `params object[] args' and call String.Format().
21099 2003-09-07 Martin Baulig <martin@ximian.com>
21101 * decl.cs (DeclSpace..ctor): Don't call
21102 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21103 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21104 (DeclSpace.RecordDecl): New method.
21106 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21108 2003-09-02 Ravi Pratap <ravi@ximian.com>
21110 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21111 value attributes to be applied to ParameterBuilders.
21113 * class.cs (MethodCore.LabelParameters): Make static and more
21114 generic so that it can be used from other places - like interface
21115 methods, for instance.
21117 * interface.cs (Interface.Emit): Call LabelParameters before
21118 emitting attributes on the InterfaceMethod.
21120 2003-08-26 Martin Baulig <martin@ximian.com>
21122 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21123 resolving aliases; fixes #47927.
21125 2003-08-26 Martin Baulig <martin@ximian.com>
21127 * statement.cs (Using.DoResolve): This is internally emitting a
21128 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21129 do not always return. Fixes #47681.
21131 2003-08-26 Martin Baulig <martin@ximian.com>
21133 * decl.cs (MemberCore): Moved WarningNotHiding(),
21134 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21136 (AdditionResult): Make this nested in DeclSpace.
21137 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21138 argument; call NamespaceEntry.Define() unless we're nested in a
21141 * namespace.cs (Namespace.DefineName): New public function. This
21142 is called from DeclSpace's .ctor to add
21143 (Namespace.Lookup): Include DeclSpaces in the lookup.
21145 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21147 * const.cs (Const): Derive from MemberBase, not MemberCore.
21149 2003-08-25 Martin Baulig <martin@ximian.com>
21151 * convert.cs (Convert.ExplicitReferenceConversion): When
21152 converting from an interface type to a class, unbox if the target
21153 type is a struct type. Fixes #47822.
21155 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21157 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21160 2003-08-22 Martin Baulig <martin@ximian.com>
21162 * class.cs (TypeManager.DefineType): When defining a nested type,
21163 call DefineType() on our parent; fixes #47801.
21165 2003-08-22 Martin Baulig <martin@ximian.com>
21167 * class.cs (MethodData.Define): While checking if a method is an
21168 interface implementation, improve the test a bit more to fix #47654.
21170 2003-08-22 Martin Baulig <martin@ximian.com>
21172 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21173 correctly; fixes #47722.
21175 2003-08-22 Martin Baulig <martin@ximian.com>
21177 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21178 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21180 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21182 2003-08-22 Martin Baulig <martin@ximian.com>
21184 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21185 can only be assigned in static constructors. Fixes #47161.
21187 2003-08-22 Martin Baulig <martin@ximian.com>
21189 Rewrote and improved the flow analysis code.
21191 * flowbranching.cs (FlowBranching): Make this class abstract.
21192 (FlowBranching.CreateBranching): New static function to create a
21193 new flow branching.
21194 (FlowBranchingBlock, FlowBranchingException): New classes.
21195 (FlowBranching.UsageVector.Type): New public readonly field.
21196 (FlowBranching.UsageVector.Breaks): Removed the setter.
21197 (FlowBranching.UsageVector.Returns): Removed the setter.
21198 (FlowBranching.UsageVector): Added Break(), Return(),
21199 NeverReachable() and Throw() methods to modify the reachability.
21200 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21201 done by FlowBranching.Merge().
21202 (FlowBranching.UsageVector.MergeChild): New method; merges the
21203 merge result into the current vector.
21204 (FlowBranching.Merge): New abstract method to merge a branching.
21206 2003-08-12 Martin Baulig <martin@ximian.com>
21208 * expression.cs (Indirection.CacheTemporaries): Create the
21209 LocalTemporary with the pointer type, not its element type.
21211 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21213 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21214 token was a keyword or not.
21216 Add `error' options where an IDENTIFIER was expected; Provide
21217 CheckToken and CheckIdentifierToken convenience error reporting
21220 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21222 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21223 NameSpaceEntry NameSpaceEntry.
21225 (LookupInterfaceOrClass): Avoid creating a full qualified name
21226 from namespace and name: avoid doing lookups when we know the
21227 namespace is non-existant. Use new Tree.LookupByNamespace which
21228 looks up DeclSpaces based on their namespace, name pair.
21230 * driver.cs: Provide a new `parser verbose' to display the
21231 exception thrown during parsing. This is turned off by default
21232 now, so the output of a failure from mcs is more graceful.
21234 * namespace.cs: Track all the namespaces defined in a hashtable
21237 (IsNamespace): New method
21239 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21241 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21242 we know that we need to concatenate (full typename can never be
21247 * statement.cs: Use a bitfield; Do not initialize to null things
21248 which are done by the constructor by default.
21250 * cs-parser.jay: bug fix, parameter was 4, not 3.
21252 * expression.cs: Just use the property;
21254 * statement.cs: No need for GetVariableInfo method.
21256 2003-08-08 Martin Baulig <martin@ximian.com>
21258 * flowanalysis.cs (FlowReturns): This is now nested in the
21259 `FlowBranching' class.
21260 (MyBitVector): Moved this here from statement.cs.
21261 (FlowBranching.SiblingType): New enum type.
21262 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21264 2003-08-07 Martin Baulig <martin@ximian.com>
21266 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21267 `FlowBranching' class and called `BranchingType'.
21269 2003-08-07 Martin Baulig <martin@ximian.com>
21271 * flowanalysis.cs: Moved all the control flow analysis code into
21274 2003-08-07 Martin Baulig <martin@ximian.com>
21276 * assign.cs (Assign.DoResolve): `target' must either be an
21277 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21280 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21282 * expression.cs (BinaryMethod): This kind of expression is created by the
21283 Binary class if it determines that the operator has to be handled
21286 (BinaryDelegate): This kind of expression is created if we are
21287 dealing with a + or - operator on delegates.
21289 (Binary): remove method, argumetns, and DelegateOperator: when
21290 dealing with methods,
21292 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21294 * statement.cs (Block): use bitfields for the three extra booleans
21295 we had in use. Remove unused topblock parameter.
21297 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21299 * assign.cs: Drop extra unneeded tests.
21301 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21303 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21305 * statement.cs (Foreach): Use VariableStorage instead of
21308 * codegen.cs (VariableStorage): New class used by clients that
21309 require a variable stored: locals or fields for variables that
21310 need to live across yield.
21312 Maybe provide a convenience api for EmitThis+EmitLoad?
21314 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21317 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21319 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21320 RemapParameterLValue): New methods that are used to turn a
21321 precomputed FieldInfo into an expression like this:
21325 The idea is to use this instead of making LocalVariableReference
21326 have more than one meaning.
21328 * cs-parser.jay: Add error production to BASE.
21330 * ecore.cs: Deal with TypeManager.GetField returning null, which
21331 is now a valid return value.
21333 (FieldExprNoAddress): New expression for Fields whose address can
21336 * expression.cs (LocalVariableReference): During the resolve
21337 phases, create new expressions if we are in a remapping context.
21338 Remove code that dealt with remapping here.
21340 (ParameterReference): same.
21342 (ProxyInstance): New expression, like the `This' expression, but
21343 it is born fully resolved. We know what we are doing, so remove
21344 the errors that are targeted to user-provided uses of `this'.
21346 * statement.cs (Foreach): our variable is now stored as an
21347 Expression; During resolution, follow the protocol, dont just
21348 assume it will return this.
21350 2003-08-06 Martin Baulig <martin@ximian.com>
21352 * support.cs (SeekableStreamReader.cs): New public class.
21354 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21355 SeekableStreamReader instead of the normal StreamReader.
21357 2003-08-04 Martin Baulig <martin@ximian.com>
21359 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21360 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21361 deambiguate casts and delegate invocations.
21362 (parenthesized_expression): Use the new tokens to ensure this is
21363 not a cast of method invocation.
21365 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21366 when reading a `)' and Deambiguate_CloseParens () was previously
21369 * expression.cs (ParenthesizedExpression): New class. This is
21370 just used for the CS0075 test.
21371 (Binary.DoResolve): Check for CS0075.
21373 2003-07-29 Ravi Pratap <ravi@ximian.com>
21375 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21376 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21377 reference comparison.
21379 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21380 examine the ReturnType for equality - this is necessary in the
21381 cases of implicit and explicit operators whose signature also
21382 includes the return type.
21384 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21386 * namespace.cs: Cache the result of the namespace computation,
21387 instead of computing it every time.
21389 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21391 * decl.cs: Use a global arraylist that we reuse over invocations
21392 to avoid excesive memory consumption. Reduces memory usage on an
21393 mcs compile by one meg (45 average).
21395 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21396 private, work around that.
21398 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21400 * literal.cs (IntLiteral): Define Zero and One static literals.
21402 * cs-parser.jay (integer_literal): use static literals to reduce
21403 memory usage for the most used literals (0, 1 and -1). 211kb
21404 reduced in memory usage.
21406 Replace all calls to `new ArrayList' with `new
21407 ArrayList(4)' which is a good average number for most allocations,
21408 and also requires only 16 bytes of memory for its buffer by
21411 This reduced MCS memory usage in seven megabytes for the RSS after
21414 2003-07-28 Ravi Pratap <ravi@ximian.com>
21416 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21417 handle params methods the correct way by forming only one
21418 applicable set with params and normal methods in them. Earlier we
21419 were looking at params methods only if we found no normal methods
21420 which was not the correct thing to do.
21422 (Invocation.BetterFunction): Take separate arguments indicating
21423 when candidate and the best method are params methods in their
21426 This fixes bugs #43367 and #46199.
21428 * attribute.cs: Documentation updates.
21430 (CheckAttribute): Rename to CheckAttributeTarget.
21431 (GetValidPlaces): Rename to GetValidTargets.
21433 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21434 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21438 2003-07-28 Martin Baulig <martin@ximian.com>
21440 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21441 name when looking up the base class of a nested class. Fixes #46977.
21443 2003-07-26 Martin Baulig <martin@ximian.com>
21445 * expression.cs (Indexers.Indexer): New nested struct; contains
21446 getter, setter and the indexer's type.
21447 (Indexers.Properties): This is now an ArrayList of
21448 Indexers.Indexer's.
21449 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21450 indexer doesn't have any getters.
21452 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21453 for embedded property and indexer assignments.
21455 2003-07-26 Martin Baulig <martin@ximian.com>
21457 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21458 preprocessor directive is not the first non-whitespace character
21461 2003-07-26 Martin Baulig <martin@ximian.com>
21463 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21464 namespace parsing, follow the spec more closely.
21466 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21467 NamespaceEntry.Lookup().
21469 2003-07-25 Martin Baulig <martin@ximian.com>
21471 * MethodCore.cs (OverridesSomething): New public field; it's set
21472 from TypeContainer.DefineMembers if this method overrides
21473 something (which doesn't need to be a method). Fix #39462.
21475 2003-07-25 Ravi Pratap <ravi@ximian.com>
21477 * typemanager.cs (GetMembers): Ensure that the list of members is
21478 reversed. This keeps things in sync.
21480 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21481 find an AttributeUsage attribute.
21483 * expression.cs (Invocation.OverloadResolve): Perform the check
21484 which disallows Invoke to be directly called on a Delegate.
21486 (Error_InvokeOnDelegate): Report error cs1533.
21488 2003-07-25 Martin Baulig <martin@ximian.com>
21490 * expression.cs (Indexers.GetIndexersForType): Only look in the
21491 interface hierarchy if the requested type is already an
21492 interface. Fixes #46788 while keeping #46502 fixed.
21494 2003-07-25 Martin Baulig <martin@ximian.com>
21496 * class.cs (TypeContainer.DefineMembers): Check whether all
21497 readonly fields have been assigned and report warning CS0649 if
21500 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21503 2003-07-24 Ravi Pratap <ravi@ximian.com>
21505 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21506 returned from GetMethods to make things consistent with the
21507 assumptions MCS makes about ordering of methods.
21509 This should comprehensively fix bug #45127 and it does :-)
21511 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21512 ordering is actually reverse.
21514 * Clean up some debug messages I left lying around.
21516 * interface.cs (Populate*): Get rid of code which emits attributes
21517 since the stage in which we emit attributes is the 'Emit' stage,
21518 not the define stage.
21520 (Emit): Move attribute emission for interface members here.
21522 2003-07-22 Ravi Pratap <ravi@ximian.com>
21524 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21525 closely: we eliminate methods in base types when we have an
21526 applicable method in a top-level type.
21528 Please see section 14.5.5.1 for an exact description of what goes
21531 This fixes bug #45127 and a host of other related to corlib compilation.
21533 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21534 array is the method corresponding to the top-level type (this is
21535 because of the changes made to icall.c) so we change this
21538 (MethodGroupExpr.Name): This too.
21540 * typemanager.cs (GetElementType): New method which does the right
21541 thing when compiling corlib.
21543 * everywhere: Make use of the above in the relevant places.
21545 2003-07-22 Martin Baulig <martin@ximian.com>
21547 * cs-parser.jay (invocation_expression): Moved
21548 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21549 `cast_expression', but create a InvocationOrCast which later
21550 resolves to either an Invocation or a Cast.
21552 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21553 method; call this before EmitStatement() to make sure that this
21554 expression can be used as a statement.
21556 * expression.cs (InvocationOrCast): New class; resolves to either
21557 an Invocation or a Cast.
21559 * statement.cs (StatementExpression): Call ResolveStatement() on
21560 the ExpressionStatement before emitting it.
21562 2003-07-21 Martin Baulig <martin@ximian.com>
21564 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21565 `ref' and `out' attributes match; fixes #46220.
21566 (MemberAccess.ResolveMemberAccess): You can't reference a type
21567 through an expression; fixes #33180.
21568 (Indexers.GetIndexersForType): Don't return the indexers from
21569 interfaces the class implements; fixes #46502.
21571 2003-07-21 Martin Baulig <martin@ximian.com>
21573 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21574 CS0661 checks; fixes bug #30442.
21576 2003-07-21 Martin Baulig <martin@ximian.com>
21578 * decl.cs (AdditionResult): Added `Error'.
21580 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21582 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21583 makes cs0031.cs actually work.
21585 2003-07-20 Martin Baulig <martin@ximian.com>
21587 * namespace.cs: Fixed that bug which caused a crash when compiling
21588 the debugger's GUI.
21590 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21592 * typemanager.cs (LookupTypeReflection): Never expose types which
21593 are NotPublic, NestedPrivate, NestedAssembly, or
21594 NestedFamANDAssem. We used to return these, and later do a check
21595 that would report a meaningful error, but the problem is that we
21596 would not get the real match, if there was a name override.
21598 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21600 * namespace.cs (Namespace, Name): Do not compute the namespace
21601 name dynamically, compute it in the constructor. This reduced
21602 memory usage by 1697 KB.
21604 * driver.cs: Use --pause to pause at the end.
21606 2003-07-17 Peter Williams <peter@newton.cx>
21608 * Makefile: Change the name of the test target so that it doesn't
21609 conflict with the recursive test target.
21611 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21613 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21614 AddressOf): Do not use EmitThis, that was wrong, use the actual
21617 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21619 * class.cs (MethodData.Define): While checking if a method is an
21620 interface implementation, improve the test: If we are not public
21621 (use new test here: use the computed MethodAttributes directly,
21622 instead of the parsed modifier flags) check if the `implementing'
21623 method comes from an interface or not.
21625 * pending.cs (VerifyPendingMethods): Slightly better error
21628 * makefile: add test target that does the mcs bootstrap.
21630 2003-07-16 Ravi Pratap <ravi@ximian.com>
21632 * interface.cs (Define): Do nothing here since there are no
21633 members to populate etc. Move the attribute emission out of here
21634 since this was just totally the wrong place to put it. Attribute
21635 application happens during the 'Emit' phase, not in the 'Define'
21638 (Emit): Add this method and move the attribute emission here
21640 * rootcontext.cs (EmitCode): Call the Emit method on interface
21643 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21645 * expression.cs (OverloadResolve): Report error only if Location
21646 is not 'Null' which means that there was a probe going on.
21648 2003-07-14 Martin Baulig <martin@ximian.com>
21650 * expression.cs (ConditionalLogicalOperator): New public class to
21651 implement user defined conditional logical operators.
21652 This is section 14.11.2 in the spec and bug #40505.
21654 2003-07-14 Martin Baulig <martin@ximian.com>
21656 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21658 2003-07-14 Martin Baulig <martin@ximian.com>
21660 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21662 * ecore.cs (IVariable.VerifyFixed): New interface method.
21664 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21665 operator, check whether the variable is actually fixed. Fixes bug
21666 #36055. Set a variable definitely assigned when taking its
21667 address as required by the spec.
21669 * statement.cs (LocalInfo.IsFixed): New field.
21670 (LocalInfo.MakePinned): Set `IsFixed' to true.
21672 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21674 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21675 for .ctors, ensure that we only ask for members declared in the
21676 attribute type (BindingFlags.DeclaredOnly).
21680 * expression.cs (Error_WrongNumArguments): Report error 1501
21681 correctly the way CSC does.
21683 2003-07-13 Martin Baulig <martin@ximian.com>
21685 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21686 lookup on the fully qualified name, to make things like "X.X" work
21687 where "X.X" is a fully qualified type name, but we also have a
21688 namespace "X" in the using list. Fixes #41975.
21690 2003-07-13 Martin Baulig <martin@ximian.com>
21692 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21693 function. If we're a CompoundAssign, we need to create an embedded
21694 CompoundAssign, not an embedded Assign.
21695 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21698 2003-07-13 Martin Baulig <martin@ximian.com>
21700 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21701 work to fix bug #46088.
21703 2003-07-13 Ravi Pratap <ravi@ximian.com>
21705 * class.cs (Operator.Emit): Do not emit attributes here - it is
21706 taken care of by the Method class that we delegate too. This takes
21707 care of bug #45876.
21709 2003-07-10 Martin Baulig <martin@ximian.com>
21711 * expression.cs (TypeOfVoid): New class.
21712 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21714 2003-07-10 Martin Baulig <martin@ximian.com>
21716 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21719 2003-07-10 Martin Baulig <martin@ximian.com>
21721 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21722 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21724 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21726 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21728 2003-07-10 Martin Baulig <martin@ximian.com>
21730 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21731 of decimal. Fixes #42850.
21733 NOTE: I also fixed the created byte blob, but this doesn't work on
21734 the MS runtime and csc never produces any byte blobs for decimal
21737 2003-07-10 Martin Baulig <martin@ximian.com>
21739 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21740 structs; fixes #32068.
21741 (Block.AddChildVariableNames): Fixed #44302.
21743 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21745 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21747 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21749 * attribute.cs: And this test is onger needed.
21751 2003-07-08 Martin Baulig <martin@ximian.com>
21753 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21754 inaccessible types. Fixes #36313.
21756 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21758 * namespace.cs (NamespaceEntry): Create implicit entries for all
21759 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21760 implicit entries for N1.N2 and N1.
21762 2003-07-08 Martin Baulig <martin@ximian.com>
21764 Rewrote the handling of namespaces to fix a lot of the issues
21765 wrt. `using' aliases etc.
21767 * namespace.cs (Namespace): Splitted this class into a
21768 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21770 * typemanager.cs (TypeManager.IsNamespace): Removed.
21771 (TypeManager.ComputeNamespaces): Only compute namespaces from
21772 loaded assemblies here, not the namespaces from the assembly we're
21773 currently compiling.
21775 2003-07-08 Martin Baulig <martin@ximian.com>
21777 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21779 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21781 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21784 I thought about the memory savings here, but LookupTypeReflection
21785 is used under already very constrained scenarios. Compiling
21786 corlib or mcs only exposes one hit, so it would not really reduce
21787 any memory consumption.
21789 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21791 * typemanager.cs: fixes bug #45889 by only adding public types from
21792 other assemblies to the list of known types.
21794 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21796 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21797 on the type we resolved.
21799 2003-07-05 Martin Baulig <martin@ximian.com>
21801 * pending.cs (PendingImplementation.ParentImplements): Don't
21802 create the proxy if the parent is abstract.
21804 * class.cs (TypeContainer.DefineIndexers): Process explicit
21805 interface implementations first. Fixes #37714.
21807 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21809 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21810 defined recursively; but since we modify the input parameters
21811 (left is set to `this' temporarily), we reset this value if the
21812 left_is_explicit is false, which gives the original semantics to
21815 * literal.cs (NullPointer): new class used to represent a null
21816 literal in a pointer context.
21818 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21819 type is a pointer, use a NullPointer object instead of a
21820 NullLiteral. Closes 43687
21822 (ExplicitConversion): Convert pointer values using
21823 the conv opcode to the proper type.
21825 * ecore.cs (New): change ValueTypeVariable property into a method,
21826 that returns whether the valuetype is suitable for being used.
21828 * expression.cs (Binary.DoNumericPromotions): Only return if we
21829 the int constant was a valid uint, and we can return both left and
21830 right as uints. If not, we continue processing, to trigger the
21831 type conversion. This fixes 39018.
21833 * statement.cs (Block.EmitMeta): During constant resolution, set
21834 the CurrentBlock property on the emitcontext, so that we resolve
21835 constants propertly.
21837 2003-07-02 Martin Baulig <martin@ximian.com>
21839 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21840 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21842 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21843 than emitting it here.
21845 * statement.cs: Fixed some more flow analysis bugs.
21847 2003-07-02 Martin Baulig <martin@ximian.com>
21849 * class.cs (MethodData.Define): When implementing interface
21850 methods, set Final unless we're Virtual.
21852 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21853 check work for interface methods.
21855 2003-07-01 Martin Baulig <martin@ximian.com>
21857 * ecore.cs (EmitContext.This): Replaced this property with a
21858 GetThis() method which takes a Location argument. This ensures
21859 that we get the correct error location for a CS0188.
21861 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21863 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21864 ImplicitStandardConversion.
21866 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21868 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21870 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21873 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21875 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21878 (MethodData.Define): Turn off initlocals for unsafe methods.
21880 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21882 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21883 complete; Fixes #37521.
21885 * delegate.cs: Use Modifiers.TypeAttr to compute the
21886 TypeAttributes, instead of rolling our own. This makes the flags
21887 correct for the delegates.
21889 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21891 * class.cs (Constructor.Define): Set the private flag for static
21892 constructors as well.
21894 * cs-parser.jay (statement_expression): Set the return value to
21895 null, to avoid a crash when we catch an error.
21897 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21899 * cs-parser.jay: Applied patch from Jackson that adds support for
21900 extern and unsafe modifiers to destructor declarations.
21902 * expression.cs: Report error 21 if the user is trying to index a
21905 * driver.cs: Add an error message, suggested by the bug report.
21907 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21908 if we do not have a ": this ()" constructor initializer. Fixes 45149
21910 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21912 * namespace.cs: Add some information to reduce FAQs.
21914 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21916 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21917 underlying enumeration types. Fixes #43915.
21919 * expression.cs: Treat ushort/short as legal values to be used in
21920 bitwise operations.
21922 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21924 * delegate.cs: transfer custom attributes for paramenters from
21925 the delegate declaration to Invoke and BeginInvoke.
21927 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21929 * attribute.cs: handle custom marshalers and emit marshal info
21932 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21934 * makefile.gnu: Added anonymous.cs to the compiler sources.
21936 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21938 * iterators.cs: Change the name of the proxy class to include two
21941 * cs-parser.jay: Update grammar to include anonymous methods.
21943 * anonymous.cs: new file.
21945 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21947 * class.cs (Field.Define): Add missing test for pointers and
21950 2003-05-27 Ravi Pratap <ravi@ximian.com>
21952 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21953 we use the stobj opcode.
21955 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21956 since it wasn't the correct fix.
21958 It still is puzzling that we are required to use stobj for IntPtr
21959 which seems to be a ValueType.
21961 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21963 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21964 during regular simple name resolution. Now, the trick is that
21965 instead of returning for processing the simplename, we do a
21966 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21967 contextual lookup type). If a match is found, return that, if
21968 not, return for further composition.
21970 This fixes long-standing 30485.
21972 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21973 using the address to initialize an object, do an Stobj instead of
21974 using the regular Stelem.
21976 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21977 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21978 Because if we are a BaseIndexerAccess that value will be true.
21981 * statement.cs (GotoCase.Resolve): Return after reporting an
21982 error, do not attempt to continue.
21984 * expression.cs (PointerArithmetic.Emit): If our operand is a
21985 long, convert our constants to match the operand before
21986 multiplying. Convert to I type before adding. Fixes 43670.
21988 2003-05-14 Ravi Pratap <ravi@ximian.com>
21990 * enum.cs (ImplicitConversionExists) : Rename to
21991 ImplicitEnumConversionExists to remove ambiguity.
21993 * ecore.cs (NullCast): New type of cast expression class which
21994 basically is very similar to EmptyCast with the difference being
21995 it still is a constant since it is used only to cast a null to
21997 (eg. (string) null)
21999 * convert.cs (ImplicitReferenceConversion): When casting a null
22000 literal, we return a NullCast.
22002 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22003 should be around anymore.
22005 The renaming (reported was slightly wrong). Corrections:
22007 ConvertImplicitStandard -> ImplicitConversionStandard
22008 ConvertExplicitStandard -> ExplicitConversionStandard
22010 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22011 before passing them in !
22013 * convert.cs (ImplicitConversionStandard): When comparing for
22014 equal expr and target types, ensure that expr is not a
22017 In general, we must not be checking (expr_type ==
22018 target_type) in the top level conversion methods
22019 (ImplicitConversion, ExplicitConversion etc). This checking is
22020 done in the methods that they delegate to.
22022 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22024 * convert.cs: Move Error_CannotConvertType,
22025 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22026 ImplicitNumericConversion, ImplicitConversionExists,
22027 ImplicitUserConversionExists, StandardConversionExists,
22028 FindMostEncompassedType, FindMostSpecificSource,
22029 FindMostSpecificTarget, ImplicitUserConversion,
22030 ExplicitUserConversion, GetConversionOperators,
22031 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22032 TryImplicitIntConversion, Error_CannotConvertImplicit,
22033 ConvertImplicitRequired, ConvertNumericExplicit,
22034 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22035 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22038 Perform the following renames:
22040 StandardConversionExists -> ImplicitStandardConversionExists
22041 ConvertImplicit -> ImplicitConversion
22042 ConvertImplicitStandard -> ImplicitStandardConversion
22043 TryImplicitIntConversion -> ImplicitIntConversion
22044 ConvertImplicitRequired -> ImplicitConversionRequired
22045 ConvertNumericExplicit -> ExplicitNumericConversion
22046 ConvertReferenceExplicit -> ExplicitReferenceConversion
22047 ConvertExplicit -> ExplicitConversion
22048 ConvertExplicitStandard -> ExplicitStandardConversion
22050 2003-05-19 Martin Baulig <martin@ximian.com>
22052 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22053 (TypeInfo): Added support for structs having structs as fields.
22055 * ecore.cs (FieldExpr): Implement IVariable.
22056 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22057 VariableInfo for the field.
22059 2003-05-18 Martin Baulig <martin@ximian.com>
22061 * expression.cs (This.DoResolve): Report a CS0027 if we're
22062 emitting a field initializer.
22064 2003-05-18 Martin Baulig <martin@ximian.com>
22066 * expression.cs (This.ResolveBase): New public function.
22067 (This.DoResolve): Check for CS0188.
22069 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22072 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22073 `instance_expression' to null if we don't have any non-static
22076 2003-05-18 Martin Baulig <martin@ximian.com>
22078 Reworked the way how local variables and parameters are handled by
22079 the flow analysis code.
22081 * statement.cs (TypeInfo, VariableMap): New public classes.
22082 (VariableInfo): New public class. This is now responsible for
22083 checking whether a variable has been assigned. It is used for
22084 parameters and local variables.
22085 (Block.EmitMeta): Take the InternalParameters as argument; compute
22086 the layout of the flow vectors here.
22087 (Block.LocalMap, Block.ParameterMap): New public properties.
22088 (FlowBranching): The .ctor doesn't get the InternalParameters
22089 anymore since Block.EmitMeta() now computes the layout of the flow
22091 (MyStructInfo): This class is now known as `StructInfo' and nested
22092 in `TypeInfo'; we don't access this directly anymore.
22094 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22095 property and removed IsAssigned(), IsFieldAssigned(),
22096 SetAssigned() and SetFieldAssigned(); we now call them on the
22097 VariableInfo so we don't need to duplicate this code everywhere.
22099 * expression.cs (ParameterReference): Added `Block block' argument
22101 (LocalVariableReference, ParameterReference, This): The new
22102 VariableInfo class is now responsible for all the definite
22105 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22106 IsParameterAssigned, SetParameterAssigned): Removed.
22108 2003-05-18 Martin Baulig <martin@ximian.com>
22110 * typemanager.cs (InitCoreTypes): Try calling
22111 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22112 the 3-args-version. Corlib now also needs our `void_type'.
22113 (GetMethod): Added overloaded version which takes an optional
22114 `bool report_errors' to allow lookups of optional methods.
22116 2003-05-12 Martin Baulig <martin@ximian.com>
22118 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22119 only used for locals and not for parameters.
22121 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22123 * support.cs (InternalParameters.ParameterType): Return the
22124 ExternalType of the parameter.
22126 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22129 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22131 * class.cs (MethodData.Define): Do not set the `newslot' on
22132 interface members, if they are also flagged as "override".
22134 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22135 better code for ++i and i++. This only works for static fields
22136 and local variables.
22138 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22139 want to pull the DeclSpace out of the builder_to_declspace instead
22140 of the TypeBuilder (like in TypeContainer.FindMembers).
22142 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22143 instead of LookupTypeContainer. Fixes the crash on .NET for
22144 looking up interface members.
22146 * const.cs: Create our own emit context during the Definition
22147 stage, so that constants are evaluated in the proper context, when
22148 a recursive definition happens.
22150 2003-05-11 Martin Baulig <martin@ximian.com>
22152 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22153 new block for a switch section.
22154 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22155 the adding/lookup in the switch block. Fixes #39828.
22157 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22159 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22160 functionality: I needed to convert the data after I had performed
22161 the add/sub operation into the operands type size.
22163 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22164 pass the type for the box operation, otherwise the resulting
22165 object would have been of type object.
22167 (BoxedCast): Add constructor to specify the type to box as.
22169 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22171 * iterators.cs: I was reusing the `count' variable inadvertently,
22172 take steps to not allow this to happen.
22174 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22176 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22177 by creating an array at the point where the params starts and
22178 putting all those arguments there, then adjusting the size of the
22181 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22183 * expression.cs (New.AddressOf): Implement interface
22184 IMemoryLocation. This is used when the `new' operator is used in
22185 the context of an invocation to a method on a value type.
22187 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22190 * namespace.cs: Also check the using aliases here.
22192 * driver.cs: Move the test for using validity after the types have
22193 been entered, so we do a single pass that also includes the using
22196 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22197 in the regular case. CreateSiblingForFinally is doing extra
22200 * attribute.cs (GetAttributeArgumentExpression): Store the result
22201 on an out value, and use the return value to indicate failure
22202 instead of using null (which is a valid return for Constant.GetValue).
22204 * statement.cs: Perform the analysis flow for the increment
22205 portion after the statement, because this will be the real flow of
22206 execution. Fixes #42385
22208 * codegen.cs (EmitContext.EmitArgument,
22209 EmitContext.EmitStoreArgument): New helper functions when the
22210 RemapToProxy flag is set.
22212 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22215 Add support for remapping parameters.
22217 * iterators.cs: Propagate parameter values; Store parameter
22218 values in the proxy classes.
22220 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22222 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22223 need a proxy reference; I do not know what I was thinking
22225 * cs-parser.jay (constructor_initializer): catch another error,
22226 and display nice message.
22228 (field_declaration): catch void field declaration
22229 to flag a better error.
22231 * class.cs (MemberBase.CheckBase): Report an error instead of a
22232 warning if a new protected member is declared in a struct.
22233 (Field.Define): catch the error of readonly/volatile.
22235 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22237 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22238 volatile variable is taken
22240 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22242 * statement.cs (Fixed.Resolve): Report an error if we are not in
22245 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22247 * typemanager.cs: reuse the code that handles type clashes for
22248 delegates and enumerations.
22250 * class.cs (Report28): Always report.
22252 * expression.cs (EncodeAsAttribute): Allow nulls here.
22254 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22256 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22257 the functionality for testing whether an expression is valid for
22258 an attribute here. Also handle the case of arrays of elements
22261 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22262 encoding a linear array into an array of objects that are suitable
22263 to be passed to an CustomAttributeBuilder.
22265 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22267 * ecore.cs: (FieldExpr): Handle field remapping here.
22269 * iteratators.cs: Pass the instance variable (if the method is an
22270 instance method) to the constructors, so we can access the field
22271 variables on the class.
22273 TODO: Test this with structs. I think the THIS variable on
22274 structs might have to be a pointer, and not a refenrece
22276 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22278 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22279 local variables to fields in a proxy class.
22281 * iterators.cs (PopulateProxy): Rename our internal fields to
22283 Create a <THIS> field if we are an instance method, so we can
22284 reference our parent container variables.
22285 (MapVariable): Called back from the EmitContext code to enter a
22286 new variable to field mapping into the proxy class (we just create
22290 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22291 for using the remapped locals to fields.
22293 I placed the code here, because that gives the same semantics to
22294 local variables, and only changes the Emit code.
22296 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22297 statements inside iterators.
22298 (VariableInfo): Add a FieldBuilder for the cases when we are
22299 remapping local variables to fields in a proxy class
22301 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22302 current_block != null.
22304 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22305 not cope with strings, as it has been moved to the
22306 TableSwitchEmit. Fixed bug in switch generation.
22308 * expression.cs (New.DoResolve): Provide more context for the user
22309 when reporting an error.
22311 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22314 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22315 check the permissions for it. Note than in a type-resolution
22316 context the check was already present in DeclSpace.ResolveType,
22317 but was missing from the MemberAccess.
22319 (ArrayCreation.CheckIndices): warn if the user has
22320 more nested levels of expressions, but there are no more
22321 dimensions specified. Avoids crash on bug 41906.
22323 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22325 * statement.cs (Block): replace Implicit bool, for a generic
22327 New flag: `Unchecked'. This is used during the EmitMeta phase
22328 (which is out-of-line with the regular Resolve/Emit process for a
22329 statement, as this is done ahead of time, but still gets a chance
22330 to call constant resolve).
22332 (Block.Flags): new enum for adding a new flag.
22334 (Block.EmitMeta): track the state of unchecked.
22336 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22337 to enable constant resolution to work there as well.
22339 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22341 * typemanager.cs (ienumerable_type): Also look up
22342 System.Collections.IEnumerable.
22344 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22346 TODO: Test more than one conditional per method.
22348 * class.cs (Indexer.Define): Report the location where the user is
22349 referencing the unsupported feature.
22351 (MethodData): Overload the use of `conditionals' to
22352 minimize the creation of needless ArrayLists. This saves roughly
22353 212kb on my machine.
22355 (Method): Implement the new IIteratorContainer interface.
22356 (Method.SetYields): Implement the method by setting the ModFlags
22357 to contain METHOD_YIELDS.
22359 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22360 which just got set to null.
22362 * iterators.cs: New file.
22364 (Yield, YieldBreak): New statements.
22366 * statement.cs (Return.Resolve): Flag an error if we are used in
22367 an iterator method.
22369 * codegen.cs (InIterator): New flag set if the code is being
22370 compiled in an iterator method.
22372 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22373 internal modifier, and we just use it to avoid adding extra
22374 fields, as this is seldom used.
22376 * cs-parser.jay: Add yield_statement (yield and yield break).
22378 * driver.cs: New flag -v2 to turn on version 2 features.
22380 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22381 hashtable when v2 is enabled.
22383 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22385 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22386 there is already a namespace defined with this name.
22388 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22389 people upgraded their corlibs.
22391 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22392 always use fully qualified types, no need to use the compiler
22395 (TypeManager.IsNamespace): Use binarysearch.
22397 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22398 AddDelegate): I did not quite use the new IsValid API properly: I
22399 have to pass the short-name and the fullname. I was passing only
22400 the basename instead of the fullname sometimes.
22402 (TypeContainer.DefineType): call NamespaceClash.
22404 * interface.cs (Interface.DefineType): use NamespaceClash before
22407 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22410 * enum.cs: (Enum.DefineType): use NamespaceClash before
22413 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22414 speed increase. First, use the negative_hits cache when we get a
22415 negative. Second, add the type with its full original name
22416 instead of the new . and + encoded name (reflection uses + to
22417 separate type from a nested type). Use LookupTypeReflection
22418 directly which bypasses the type->name hashtable (that we already
22419 know does not contain the type.
22421 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22422 location/container type.
22424 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22426 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22428 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22430 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22431 method is being referenced in the method group from a static
22432 context, and report error 120 if so.
22434 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22437 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22438 is created, we create the A namespace).
22440 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22443 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22445 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22446 invocation to ModuleBuilder.GetType with the same values will
22447 return a new type instance, so we need to cache its return
22450 * expression.cs (Binary.ResolveOperator): Only allow the compare
22451 operators on enums if they are of the same type.
22453 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22454 types of ValueType on their own case. Before we were giving them
22455 the same treatment as objects.
22457 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22458 fullname. Short name is used to compare against container name.
22459 Fullname is used to check against defined namespace names.
22461 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22462 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22464 (Method.CheckBase): Call parent.
22465 (MemberBase.CheckBase): Check for protected members on sealed
22467 (PropertyBase.CheckBase): Call parent.
22468 (Field.Define): Call parent.
22470 * report.cs: Negative error codes are now mapped to 8000 - code,
22471 so that the display is render more nicely.
22473 * typemanager.cs: Do not use try/catch, instead report a regular
22476 (GetPointerType, GetReferenceType): These methods provide
22477 mechanisms to obtain the T* and T& from a T. We had the code
22478 previously scattered around the code base, and it also used
22479 TypeManager.LookupType that would go through plenty of caches.
22480 This one goes directly to the type source.
22482 In some places we did the Type.GetType followed by
22483 ModuleBuilder.GetType, but not in others, so this unifies the
22484 processing as well.
22486 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22487 statements now that we have namespace information.
22489 * typemanager.cs (IsNamespace): New method, returns whether the
22490 string presented is a namespace or not.
22492 (ComputeNamespaces): New public entry point, computes the list of
22493 available namespaces, using the GetNamespaces API call in Mono, or
22494 the slower version in MS.NET.
22496 Now before we start the semantic analysis phase, we have a
22497 complete list of namespaces including everything that the user has
22500 Deleted old code to cache namespaces in .nsc files.
22502 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22504 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22505 class/struct location definition Location for the implicit
22506 constructor location.
22508 (Operator.Define): Use the location of the operator for the
22509 implicit Method definition.
22511 (Constructor.Emit): use the constructor location for the implicit
22512 base initializer constructor.
22514 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22515 and the Expression class now contains two new methods:
22517 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22518 isolate type lookup from the rest of the resolution process.
22520 Since we use Expressions to hold type definitions due to the way
22521 we parse the input we have historically overloaded Resolve to
22522 perform the Type lookups if a special flag is passed. Now this is
22523 eliminated and two methods take their place.
22525 The differences in the two methods between xStep and xTerminal is
22526 that xStep is involved in our current lookup system that uses
22527 SimpleNames to compose a name, while xTerminal is used just to
22528 catch the case where the simplename lookup failed.
22530 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22532 * expression.cs (ResolveMemberAccess): Remove redundant code.
22533 TypeExpr expressions are always born fully resolved.
22535 * interface.cs (PopulateMethod): Do not lookup the types twice.
22536 We were doing it once during SemanticAnalysis and once during
22539 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22540 in local variable type definitions, were being returned as a
22541 SimpleName (we decomposed everything into a string), that is
22542 because primary_expression was being used instead of a type in the
22543 grammar (reduce/reduce conflicts).
22545 The part that was wrong is that we converted the expression into a
22546 string (an oversimplification in one hand, compounded with primary
22547 expressions doing string concatenation).
22553 Would return "A.B.C[]" as a SimpleName. This stopped things like
22554 using clauses from working on this particular context. And a type
22555 was being matched directly against "A.B.C[]".
22557 We now use the correct approach, and allow for ComposedCast to be
22558 part of the unary expression. So the "A.B.C []" become a composed
22559 cast of "A.B.C" (as a nested group of MemberAccess with a
22560 SimpleName at the end) plus the rank composition "[]".
22564 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22566 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22567 for the access level checking.
22569 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22570 `TypeContainer container', because I kept getting confused when I
22571 was debugging this code.
22573 * expression.cs (Indexers): Instead of tracking getters/setters,
22574 we now track them in parallel. We create one arraylist less, but
22575 most importantly it is possible now for the LValue code to find a
22576 matching get for a set.
22578 (IndexerAccess.DoResolveLValue): Update the code.
22579 GetIndexersForType has been modified already to extract all the
22580 indexers from a type. The code assumed it did not.
22582 Also make the code set the correct return type for the indexer.
22583 This was fixed a long time ago for properties, but was missing for
22584 indexers. It used to be void_type.
22586 (Binary.Emit): Test first for doubles instead of
22587 floats, as they are more common.
22589 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22590 when dealing with floats and the <=, >= operators. This fixes bug
22593 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22594 to load the array value by emitting a load on the foreach variable
22595 type. This was incorrect.
22597 We now emit the code to load an element using the the array
22598 variable type, and then we emit the conversion operator.
22602 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22604 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22606 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22608 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22609 test for protection before we test for signatures.
22611 (MethodSignature.ToString): implement.
22613 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22614 to the case where we reduced into a LongConstant.
22616 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22617 depend on whether the information is acurrate, because the
22618 Microsoft runtime will always claim that the array type is public,
22619 regardless of the real state.
22621 If the type is a pointer, another problem happens: the type is
22622 reported as non-public in Microsoft.
22624 In both cases we have to call CheckAccessLevel recursively with
22625 the underlying type as the argument to be tested.
22627 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22629 * assign.cs (Assign.Emit): If we are dealing with a compound
22630 assignment expression, we should use the code path that stores the
22631 intermediate result in a temporary value. This fixes #40903.
22633 *expression.cs (Indirection.ToString): Provide ToString method for
22636 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22638 * class.cs: Null out fields holding references to Block objects so
22639 they can be garbage collected.
22641 * expression.cs (OverloadResolve): Remove unused local.
22643 2003-04-07 Martin Baulig <martin@ximian.com>
22645 * codegen.cs (EmitContext.CurrentFile): New public field.
22646 (EmitContext.Mark): Use the CurrentFile to check whether the
22647 location is in the correct file.
22648 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22650 2003-04-07 Martin Baulig <martin@ximian.com>
22652 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22654 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22655 location. [FIXME: The location argument which gets passed to this
22656 method is sometimes wrong!]
22658 2003-04-07 Nick Drochak <ndrochak@gol.com>
22660 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22662 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22664 * expression.cs (Indirection.EmitAssign): We were using the
22665 temporary, but returning immediately instead of continuing the
22668 2003-04-06 Martin Baulig <martin@ximian.com>
22670 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22671 if it's a nested child, but also deriving from the outer class.
22674 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22675 nested child, but also deriving from the outer class. See
22677 (FilterWithClosure): We may access private members of the outer
22678 class if we're a nested child and deriving from the outer class.
22679 (RealMemberLookup): Only set `closure_private_ok' if the
22680 `original_bf' contained BindingFlags.NonPublic.
22682 2003-04-05 Martin Baulig <martin@ximian.com>
22684 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22686 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22688 * class.cs (Event.Define): Do not allow abstract events to have
22691 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22693 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22694 block in event declarations.
22696 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22697 value type, get its address.
22699 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22700 leaving a class on the stack instead of a boolean value (int
22701 0/1). Change the code so we compare against null, and then the
22702 result against zero.
22704 * class.cs (TypeContainer.GetClassBases): We were checking for the
22705 parent class being sealed too late.
22707 * expression.cs (Binary.Emit): For <= and >= when dealing with
22708 floating point values, use cgt.un and clt.un instead of cgt and
22711 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22713 * statement.cs: Apply the same optimization as MS: skip the
22714 GetEnumerator returning an IEnumerator, and use the one returning a
22715 CharEnumerator instead. This allows us to avoid the try-finally block
22718 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22720 * cs-parser.jay: Attributes cannot be applied to
22721 namespaces. Fixes #40473
22723 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22726 (Add*): check if the name is valid using the full name for constants,
22727 fields, properties and events.
22729 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22731 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22732 char constants to be part of the enumeration.
22734 * expression.cs (Conditional.DoResolve): Add support for operator
22735 true. Implements the missing functionality from 14.12
22737 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22738 operator true/false as required by the spec.
22740 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22741 implicit conversion to boolean.
22743 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22744 also one where the type implements `operator true'.
22746 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22747 get an expression that will invoke operator true based on an
22750 (GetConversionOperators): Removed the hack that called op_True
22753 (Expression.ResolveBoolean): Move this from Statement.
22755 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22757 * ecore.cs (FieldExpr): do not allow initialization of initonly
22758 fields on derived classes
22760 2003-03-13 Martin Baulig <martin@ximian.com>
22762 * statement.cs (Block.Emit): Call ig.BeginScope() and
22763 ig.EndScope() when compiling with debugging info; call
22764 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22766 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22768 * expression.cs (Indexers): Do not construct immediately, allow
22769 for new members to be appended as we go. Fixes 38143
22771 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22773 * expression.cs: save/restore context when resolving an unchecked
22776 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22778 * cfold.cs: Catch division by zero in modulus operator during
22781 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22783 * interface.cs (Interface.DefineMembers): Avoid defining members
22786 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22788 * driver.cs: handle the +/- options for -noconfig
22790 * statement.cs (Unckeched.Resolve): Also track the state of
22791 unchecked in the Resolve phase.
22793 2003-02-27 Martin Baulig <martin@ximian.com>
22795 * ecore.cs (Expression.MemberLookup): Don't create a
22796 MethodGroupExpr for something which is not a method. Fixes #38291.
22798 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22800 * class.cs (MemberBase.CheckParameters): Also check that the type
22801 is unmanaged if it is a pointer.
22803 * expression.cs (SizeOf.Resolve): Add location information.
22805 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22806 a managed type is declared.
22808 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22809 parameter modifiers as well. Fixes bug 38606
22811 * class.cs: Very sad. Am backing out the speed up changes
22812 introduced by the ArrayList -> Array in the TypeContainer, as they
22813 were not actually that much faster, and introduced a bug (no error
22814 reports on duplicated methods).
22816 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22817 source first, this will guarantee that we have a valid expression
22818 before calling in lower levels functions that will require a
22819 resolved object. Then use this original_source in the
22820 target.ResolveLValue instead of the original source that was
22823 Another change. Use target.Resolve instead of LValueResolve.
22824 Although we are resolving for LValues, we will let the Assign code
22825 take care of that (it will be called again from Resolve). This
22826 basically allows code like this:
22828 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22829 class Y { void A (X x) { x [0] += o; }
22831 The problem was that the indexer was trying to resolve for
22832 set_Item (idx, object o) and never finding one. The real set_Item
22833 was set_Item (idx, X). By delaying the process we get the right
22838 2003-02-23 Martin Baulig <martin@ximian.com>
22840 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22841 while calling DoEmit ().
22843 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22844 source files; if you use the #line directive inside a method, the
22845 compiler stops emitting line numbers for the debugger until it
22846 reaches the end of the method or another #line directive which
22847 restores the original file.
22849 2003-02-23 Martin Baulig <martin@ximian.com>
22851 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22853 2003-02-23 Martin Baulig <martin@ximian.com>
22855 * statement.cs (Block.AddChildVariableNames): We need to call this
22856 recursively, not just for our immediate children.
22858 2003-02-23 Martin Baulig <martin@ximian.com>
22860 * class.cs (Event.Define): Always make the field private, like csc does.
22862 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22863 actually work, fixes bug #37521.
22865 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22867 * delegate.cs: When creating the various temporary "Parameters"
22868 classes, make sure that we call the ComputeAndDefineParameterTypes
22869 on those new parameters (just like we do with the formal ones), to
22870 allow them to be resolved in the context of the DeclSpace.
22872 This fixes the bug that Dick observed in Bugzilla #38530.
22874 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22876 * expression.cs (ResolveMemberAccess): When resolving a constant,
22877 do not attempt to pull a constant if the value was not able to
22878 generate a valid constant.
22880 * const.cs (LookupConstantValue): Do not report more errors than required.
22882 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22884 * expression.cs: fixes bug #38328.
22886 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22888 * class.cs: Changed all the various members that can be part of a
22889 class from being an ArrayList to be an Array of the right type.
22890 During the DefineType type_list, interface_list, delegate_list and
22891 enum_list are turned into types, interfaces, delegates and enums
22894 And during the member population, indexer_list, event_list,
22895 constant_list, field_list, instance_constructor_list, method_list,
22896 operator_list and property_list are turned into their real arrays.
22898 Although we could probably perform this operation earlier, for
22899 good error reporting we need to keep the lists and remove the
22900 lists for longer than required.
22902 This optimization was triggered by Paolo profiling the compiler
22903 speed on the output of `gen-sample-program.pl' perl script.
22905 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22906 not crash in methods like MemberLookupFailed that use this field.
22908 This problem arises when the compiler fails to resolve a type
22909 during interface type definition for example.
22911 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22913 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22914 inherit from System.Object, so we have to stop at null, not only
22915 when reaching System.Object.
22917 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22919 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22920 DeclaredOnly because the parent indexer might have had a different
22921 name, but did not loop until the top of the hierarchy was reached.
22923 The problem this one fixes is 35492: when a class implemented an
22924 indexer from an interface, we were getting the interface method
22925 (which was abstract) and we were flagging an error (can not invoke
22928 This also keeps bug 33089 functioning, and test-148 functioning.
22930 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22931 out if a method is special is to see if it is declared in a
22932 property or event, or whether it is one of the predefined operator
22933 names. This should fix correctly #36804.
22935 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22937 The goal here is to remove the dependency on EmptyCast.Peel ().
22938 Killing it completely.
22940 The problem is that currently in a number of places where
22941 constants are expected, we have to "probe" for an EmptyCast, and
22942 Peel, which is not the correct thing to do, as this will be
22943 repetitive and will likely lead to errors.
22945 The idea is to remove any EmptyCasts that are used in casts that
22946 can be reduced to constants, so we only have to cope with
22949 This bug hunt was triggered by Bug 37363 and the desire to remove
22950 the duplicate pattern where we were "peeling" emptycasts to check
22951 whether they were constants. Now constants will always be
22954 * ecore.cs: Use an enumconstant here instead of wrapping with
22957 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22958 throwing me off. By handling this we can get rid of a few hacks.
22960 * statement.cs (Switch): Removed Peel() code.
22962 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22964 * class.cs: Location information for error 508
22966 * expression.cs (New.DoResolve): Add a guard against double
22967 resolution of an expression.
22969 The New DoResolve might be called twice when initializing field
22970 expressions (see EmitFieldInitializers, the call to
22971 GetInitializerExpression will perform a resolve on the expression,
22972 and later the assign will trigger another resolution
22974 This leads to bugs (#37014)
22976 * delegate.cs: The signature for EndInvoke should contain any ref
22977 or out parameters as well. We were not doing this in the past.
22979 * class.cs (Field.Define): Do not overwrite the type definition
22980 inside the `volatile' group. Turns out that volatile enumerations
22981 were changing the type here to perform a validity test, which
22984 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22986 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22987 and structs, we do not want to load the instance variable
22989 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22990 enum_type has to be handled like an object reference (implicit
22991 conversions exists from this to object), but the regular IsClass
22992 and IsValueType tests will never return true for this one.
22994 Also we use TypeManager.IsValueType instead of type.IsValueType,
22995 just for consistency with the rest of the code (this is only
22996 needed if we ever use the construct exposed by test-180.cs inside
22997 corlib, which we dont today).
22999 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23001 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23004 2003-02-09 Martin Baulig <martin@ximian.com>
23006 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23007 (Namespace.DefineNamespaces): New static public method; this is
23008 called when we're compiling with debugging to add all namespaces
23009 to the symbol file.
23011 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23012 pass it to the Namespace's .ctor.
23014 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23015 and MethodBase arguments; pass the namespace ID to the symwriter;
23016 pass the MethodBase instead of the token to the symwriter.
23017 (SymbolWriter.DefineNamespace): New method to add a namespace to
23020 2003-02-09 Martin Baulig <martin@ximian.com>
23022 * symbolwriter.cs: New file. This is a wrapper around
23023 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23024 methods here in near future.
23026 2003-02-09 Martin Baulig <martin@ximian.com>
23028 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23029 ILGenerator.MarkSequencePoint() which are actually used by the
23032 2003-02-09 Martin Baulig <martin@ximian.com>
23034 * location.cs (SourceFile): New public sealed class. This
23035 contains the name and an index which is used in the location's token.
23036 (Location): Reserve an appropriate number of bits in the token for
23037 the source file instead of walking over that list, this gives us a
23038 really huge performance improvement when compiling with debugging.
23040 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23041 `SourceFile' argument instead of a string.
23042 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23043 but don't parse/tokenize here, we need to generate the list of all
23044 source files before we do that.
23045 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23048 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23049 instead of a string.
23051 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23054 2003-02-09 Martin Baulig <martin@ximian.com>
23056 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23057 filename on `#line default'.
23059 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23061 * statement.cs: don't clear the pinned var when the fixed statement
23062 returns from the method (fixes bug#37752).
23064 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23066 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23069 2003-02-07 Martin Baulig <martin@ximian.com>
23071 * driver.cs: Removed the `--debug-args' command line argument.
23073 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23074 automatically by the AsssemblyBuilder.
23075 (CodeGen.InitializeSymbolWriter): We don't need to call any
23076 initialization function on the symbol writer anymore. This method
23077 doesn't take any arguments.
23079 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23081 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23082 from referenced assemblies as well.
23084 2003-02-02 Martin Baulig <martin@ximian.com>
23086 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23088 2003-02-02 Martin Baulig <martin@ximian.com>
23090 * class.cs (Constructor.Emit): Open the symbol writer before
23091 emitting the constructor initializer.
23092 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23093 single-stepping through constructor initializers.
23095 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23097 * class.cs: Handle error 549: do not allow virtual methods in
23100 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23102 * decl.cs: Check access levels when resolving types
23104 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23106 * statement.cs: Add parameters and locals set in catch blocks that might
23107 return to set vector
23109 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23111 * class.cs (Operator): Set the SpecialName flags for operators.
23113 * expression.cs (Invocation.DoResolve): Only block calls to
23114 accessors and operators on SpecialName methods.
23116 (Cast.TryReduce): Handle conversions from char constants.
23119 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23121 * statement.cs: small memory and time optimization in FlowBranching.
23123 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23125 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23126 problem that the last fix but in the other sid (Set).
23128 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23129 access when there is no indexer in the hierarchy.
23131 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23133 * class.cs: Combine some if statements.
23135 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23137 * driver.cs: fixed bug #37187.
23139 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23141 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23142 any indexer, it's needed to build a list with all the indexers in the
23143 hierarchy (AllGetters), else we have problems. Fixes #35653.
23145 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23147 * class.cs (MethodData.Define): It is wrong for an interface
23148 implementation to be static in both cases: explicit and implicit.
23149 We were only handling this in one case.
23151 Improve the if situation there to not have negations.
23153 * class.cs (Field.Define): Turns out that we do not need to check
23154 the unsafe bit on field definition, only on usage. Remove the test.
23156 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23158 * driver.cs: use assembly.Location instead of Codebase (the latest
23159 patch made mcs fail when using MS assemblies).
23161 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23163 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23164 get the path to *corlib.dll.
23166 2003-01-21 Nick Drochak <ndrochak@gol.com>
23170 * typemanager.cs: Remove compiler warnings
23172 2003-01-20 Duncan Mak <duncan@ximian.com>
23174 * AssemblyInfo.cs: Bump the version number to 0.19.
23176 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23178 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23180 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23182 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23184 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23186 * cs-parser.jay: Small fix: we were not comparing the constructor
23187 name correctly. Thanks to Zoltan for the initial pointer.
23189 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23191 * cs-tokenizer.cs: Set file name when specified with #line
23193 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23195 * cs-parser.jay: Only perform the constructor checks here if we
23196 are named like the class; This will help provider a better
23197 error. The constructor path is taken when a type definition is
23198 not found, but most likely the user forgot to add the type, so
23199 report that rather than the constructor error.
23201 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23203 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23206 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23208 * cs-parser.jay: Add cleanup call.
23210 2003-01-13 Duncan Mak <duncan@ximian.com>
23212 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23213 consistent with other methods.
23215 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23217 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23219 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23221 * attribute.cs: only set GuidAttr to true when we have a
23224 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23228 * typemanager.cs: fixes to allow mcs compile corlib with the new
23229 Type.IsSubclassOf fix.
23231 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23233 * expression.cs (LocalVariableReference.DoResolve): Classify a
23234 constant as a value, not as a variable. Also, set the type for
23237 * cs-parser.jay (fixed_statement): take a type instead of a
23238 pointer_type, so we can produce a better error message later.
23240 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23243 (For.DoEmit): Make inifinite loops have a
23244 non-conditional branch back.
23246 (Fixed.DoEmit): First populate the pinned variables, then emit the
23247 statement, then clear the variables. Before I was emitting the
23248 code once for each fixed piece.
23251 2003-01-08 Martin Baulig <martin@ximian.com>
23253 * statement.cs (FlowBranching.MergeChild): A break in a
23254 SWITCH_SECTION does not leave a loop. Fixes #36155.
23256 2003-01-08 Martin Baulig <martin@ximian.com>
23258 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23259 lives in the same number space than `param_map'. Fixes #36154.
23261 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23263 * cs-parser.jay (constructor_declaration): Set the
23264 Constructor.ModFlags before probing for it. This makes the
23265 compiler report 514, 515 and 132 (the code was there, but got
23268 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23269 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23270 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23272 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23274 * enum.cs: create the enum static fields using the enum type.
23276 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23278 * class.cs: don't try to create the ParamBuilder for the return
23279 type if it's not needed (and handle it breaking for the ms runtime
23282 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23284 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23286 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23288 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23289 the command. This showed up while compiling the JANET source
23290 code, which used \r as its only newline separator.
23292 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23294 * class.cs (Method.Define): If we are an operator (because it
23295 reuses our code), then set the SpecialName and HideBySig. #36128
23297 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23299 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23300 exception, report error 120 `object reference required'.
23302 * driver.cs: Add --pause option, used during to measure the size
23303 of the process as it goes with --timestamp.
23305 * expression.cs (Invocation.DoResolve): Do not allow methods with
23306 SpecialName to be invoked.
23308 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23310 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23311 number before adding it.
23313 2002-12-21 Ravi Pratap <ravi@ximian.com>
23315 * ecore.cs (StandardImplicitConversion): When in an unsafe
23316 context, we allow conversion between void * to any other pointer
23317 type. This fixes bug #35973.
23319 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23321 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23322 is not thrown when extensionless outputs are used
23324 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23326 * rootcontext.cs: fixed compilation of corlib.
23328 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23330 * attribute.cs (Attributes.Contains): Add new method.
23332 * class.cs (MethodCore.LabelParameters): if the parameter is an
23333 `out' parameter, check that no attribute `[In]' has been passed.
23335 * enum.cs: Handle the `value__' name in an enumeration.
23337 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23339 * decl.cs: Added special case to allow overrides on "protected
23342 2002-12-18 Ravi Pratap <ravi@ximian.com>
23344 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23345 since it makes much more sense.
23347 (Attributes.ctor): Don't require a Location parameter.
23349 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23351 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23352 since we already have that information per attribute.
23354 * everywhere : make appropriate changes.
23356 * class.cs (LabelParameters): Write the code which actually
23357 applies attributes to the return type. We can't do this on the MS
23358 .NET runtime so we flag a warning in the case an exception is
23361 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23363 * const.cs: Handle implicit null conversions here too.
23365 2002-12-17 Ravi Pratap <ravi@ximian.com>
23367 * class.cs (MethodCore.LabelParameters): Remove the extra
23368 Type [] parameter since it is completely unnecessary. Instead
23369 pass in the method's attributes so that we can extract
23370 the "return" attribute.
23372 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23374 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23375 of ignoring it and letting the compile continue.
23377 * typemanager.cs (ChangeType): use an extra argument to return an
23378 error condition instead of throwing an exception.
23380 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23382 * expression.cs (Unary.TryReduce): mimic the code for the regular
23383 code path. Perform an implicit cast in the cases where we can
23384 implicitly convert to one of the integral types, and then reduce
23385 based on that constant. This fixes bug #35483.
23387 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23389 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23391 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23393 * namespace.cs: fixed bug #35489.
23395 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23397 * class.cs: Remove some dead code.
23399 * cs-parser.jay: Estimate the number of methods needed
23400 (RootContext.MethodCount);
23402 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23403 numbers instead of StringBuilders.
23405 * support.cs (PtrHashtable): Add constructor with initial size;
23406 We can now reduce reallocations of the method table.
23408 2002-12-10 Ravi Pratap <ravi@ximian.com>
23410 * attribute.cs (ApplyAttributes): Keep track of the emitted
23411 attributes on a per-target basis. This fixes bug #35413.
23413 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23415 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23416 default to the Windows 1252 encoding.
23418 (UnixParseOption): Support version, thanks to Alp for the missing
23421 * AssemblyInfo.cs: Add nice assembly information.
23423 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23426 * cs-parser.jay: Allow a trailing comma before the close bracked
23427 in the attribute_section production.
23429 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23430 address of the instance was being taken, I will take this out,
23431 because we take the address of the object immediately here.
23433 2002-12-09 Ravi Pratap <ravi@ximian.com>
23435 * typemanager.cs (AreMultipleAllowed): Take care of the most
23436 obvious case where attribute type is not in the current assembly -
23439 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23441 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23442 definitions, instead of doing that afterwards.
23444 Also we use a nice little hack, depending on the constructor, we
23445 know if we are a "composed" name or a simple name. Hence, we
23446 avoid the IndexOf test, and we avoid
23448 * codegen.cs: Add code to assist in a bug reporter to track down
23449 the source of a compiler crash.
23451 2002-12-07 Ravi Pratap <ravi@ximian.com>
23453 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23454 types have been emitted for a given element and flag an error
23455 if something which does not have AllowMultiple set is used more
23458 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23459 attribute types and their corresponding AllowMultiple properties
23461 (AreMultipleAllowed): Check the property for a given type.
23463 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23464 property in the case we have a TypeContainer.
23466 (Attributes.AddAttribute): Detect duplicates and just skip on
23467 adding them. This trivial fix catches a pretty gross error in our
23468 attribute emission - global attributes were being emitted twice!
23470 Bugzilla bug #33187 is now fixed.
23472 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23474 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23475 instead of pp_and).
23477 * expression.cs (Binary.ResolveOperator): I can only use the
23478 Concat (string, string, string) and Concat (string, string,
23479 string, string) if the child is actually a concatenation of
23482 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23484 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23485 context where we need a 2-character lookahead.
23487 * pending.cs (PendingImplementation): Rework so we can keep track
23488 of interface types all the time, and flag those which were
23489 implemented by parents as optional.
23491 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23493 * expression.cs (Binary.ResolveOperator): Use
23494 String.Concat(string,string,string) or
23495 String.Concat(string,string,string,string) when possible.
23497 * typemanager: More helper methods.
23500 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23502 * pending.cs: remove the bogus return from GetMissingInterfaces()
23503 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23505 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23507 * namespace.cs: avoid duplicated 'using xxx' being added to
23508 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23509 when we get more than one 'using' statement for the same namespace.
23510 Report a CS0105 warning for it.
23512 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23514 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23515 of calling getChar/putback, uses internal knowledge of it.
23517 (xtoken): Reorder tokenizer so most common patterns are checked
23518 first. This reduces the compilation time in another 5% (from 8.11s
23519 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23521 The parsing time is 22% of the compilation in mcs, and from that
23522 64% is spent on the tokenization process.
23524 I tried using a binary search for keywords, but this is slower
23525 than the hashtable. Another option would be to do a couple of
23528 * Not use a StringBuilder, instead use an array of chars,
23529 with a set value. Notice that this way we could catch
23530 the 645 error without having to do it *afterwards*.
23532 * We could write a hand-parser to avoid the hashtable
23533 compares altogether.
23535 The identifier consumption process takes 37% of the tokenization
23536 time. Another 15% is spent on is_number. 56% of the time spent
23537 on is_number is spent on Int64.Parse:
23539 * We could probably choose based on the string length to
23540 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23543 Another 3% is spend on wrapping `xtoken' in the `token' function.
23545 Handle 0xa0 as whitespace (#34752)
23547 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23549 * typemanager.cs (IsCLRType): New routine to tell whether a type
23550 is one of the builtin types.
23552 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23553 typecode in more places instead of doing pointer comparissions.
23554 We could leverage some knowledge about the way the typecodes are
23557 New code to cache namespaces in assemblies, it is currently not
23558 invoked, to be used soon.
23560 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23562 * expression.cs (Binary.ResolveOperator): specially handle
23563 strings, and do not perform user-defined operator overloading for
23566 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23568 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23569 internalcall as it is a pretty simple operation; Avoid whenever
23570 possible to call Char.IsLetter.
23572 (consume_identifier): Cut by half the number of
23573 hashtable calls by merging the is_keyword and GetKeyword behavior.
23575 Do not short-circuit, because if we do, we
23576 report errors (ie, #if false && true would produce an invalid
23580 2002-11-24 Martin Baulig <martin@ximian.com>
23582 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23583 check constant ranges and report a CS0221. Fixes #33186.
23585 2002-11-24 Martin Baulig <martin@ximian.com>
23587 * cs-parser.jay: Make this work for uninitialized variable
23588 declarations in the `for' initializer. Fixes #32416.
23590 2002-11-24 Martin Baulig <martin@ximian.com>
23592 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23593 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23595 2002-11-24 Martin Baulig <martin@ximian.com>
23597 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23598 argument; if true, we also check for user-defined conversions.
23599 This is only needed if both arguments are of a user-defined type.
23600 Fixes #30443, added test-175.cs.
23601 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23603 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23605 2002-11-24 Martin Baulig <martin@ximian.com>
23607 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23608 function to get the store opcode.
23609 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23610 only emit the Ldelema if the store opcode is Stobj. You must run
23611 both test-34 and test-167 to test this. Fixes #34529.
23613 2002-11-23 Martin Baulig <martin@ximian.com>
23615 * ecore.cs (Expression.MemberLookup): Added additional
23616 `qualifier_type' argument which is used when we're being called
23617 from MemberAccess.DoResolve() and null if we're called from a
23619 (Expression.MemberLookupFailed): New method to report errors; this
23620 does the CS1540 check and reports the correct error message.
23622 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23623 argument for the CS1540 check and redone the way how we're dealing
23624 with private members. See the comment in the source code for details.
23625 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23626 `closure_start_type' to `closure_qualifier_type' and check whether
23627 it's not null. It was not this filter being broken, it was just
23628 being called with the wrong arguments.
23630 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23631 and pass it the correct `qualifier_type'; this also does the error
23634 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23636 * expression.cs (Invocation.EmitParams): If the we are dealing
23637 with a non-built-in value type, load its address as well.
23639 (ArrayCreation): Use a a pretty constant instead
23640 of the hardcoded value 2. Use 6 instead of 2 for the number of
23641 static initializers.
23643 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23644 because they are not really value types, just glorified integers.
23646 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23648 * ecore.cs: Remove redundant code for enumerations, make them use
23649 the same code path as everything else, fixes the casting issue
23650 with enumerations in Windows.Forms.
23652 * attribute.cs: Do only cast to string if it is a string, the
23653 validation happens later.
23655 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23656 people upgrade their corlibs.
23658 * ecore.cs: Oops, enumerations were not following the entire code path
23660 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23662 * typemanager.cs (FilterWithClosure): Commented out the test for
23663 1540 in typemanager.cs, as it has problems when accessing
23664 protected methods from a parent class (see test-174.cs).
23666 * attribute.cs (Attribute.ValidateGuid): new method.
23667 (Attribute.Resolve): Use above.
23669 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23671 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23673 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23674 handling for enumerations, as we only needed the TypeContainer
23675 functionality to begin with (this is required for the fix below to
23676 work for enums that reference constants in a container class for
23679 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23681 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23682 a valid TypeBuilder to perform lookups on.o
23684 * class.cs (InheritableMemberSignatureCompare): Use true in the
23685 call to GetGetMethod and GetSetMethod, because we are comparing
23686 the signature, and we need to get the methods *even* if they are
23689 (PropertyBase.CheckBase): ditto.
23691 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23692 GotoCase.Resolve): Use Peel on EmpytCasts.
23694 * ecore.cs (EmptyCast): drop child, add Peel method.
23696 2002-11-17 Martin Baulig <martin@ximian.com>
23698 * ecore.cs (EmptyCast.Child): New public property.
23700 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23701 label resolved to an EmptyCast. Fixes #34162.
23702 (GotoCase.Resolve): Likewise.
23703 (Block.EmitMeta): Likewise.
23705 2002-11-17 Martin Baulig <martin@ximian.com>
23707 * expression.cs (Invocation.BetterConversion): Prefer int over
23708 uint; short over ushort; long over ulong for integer literals.
23709 Use ImplicitConversionExists instead of StandardConversionExists
23710 since we also need to check for user-defined implicit conversions.
23711 Fixes #34165. Added test-173.cs.
23713 2002-11-16 Martin Baulig <martin@ximian.com>
23715 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23716 with the `true' and `false' literals. Fixes #33151.
23718 2002-11-16 Martin Baulig <martin@ximian.com>
23720 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23721 October 22nd; don't do the cs1540 check for static members.
23723 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23724 now using our own filter here and doing the cs1540 check again.
23726 2002-11-16 Martin Baulig <martin@ximian.com>
23728 * support.cs (InternalParameters): Don't crash if we don't have
23729 any fixed parameters. Fixes #33532.
23731 2002-11-16 Martin Baulig <martin@ximian.com>
23733 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23734 when looking up static methods to make this work on Windows.
23737 2002-11-16 Martin Baulig <martin@ximian.com>
23739 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23740 a setter rather than using PropertyInfo.CanWrite.
23742 2002-11-15 Nick Drochak <ndrochak@gol.com>
23744 * class.cs: Allow acces to block member by subclasses. Fixes build
23747 2002-11-14 Martin Baulig <martin@ximian.com>
23749 * class.cs (Constructor.Emit): Added the extern/block check.
23752 2002-11-14 Martin Baulig <martin@ximian.com>
23754 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23755 iteration while looking for indexers, this is needed because the
23756 indexer may have a different name in our base classes. Fixed the
23757 error reporting (no indexers at all, not get accessor, no
23758 overloaded match). Fixes bug #33089.
23759 (IndexerAccess.DoResolveLValue): Likewise.
23761 2002-11-14 Martin Baulig <martin@ximian.com>
23763 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23764 indexers. Fixes the first part of bug #33089.
23765 (MethodSignature.InheritableMemberSignatureCompare): Added support
23768 2002-11-13 Ravi Pratap <ravi@ximian.com>
23770 * attribute.cs (Attribute.Resolve): Catch the
23771 NullReferenceException and report it since it isn't supposed to
23774 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23776 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23777 LogicalOr and LogicalAnd that can benefit from recursively
23778 handling EmitBranchable. The code now should be nice for Paolo.
23780 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23782 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23783 the Type lookups, as we perform quite a number of lookups on
23784 non-Types. This can be removed once we can deterministically tell
23785 whether we have a type or a namespace in advance.
23787 But this might require special hacks from our corlib.
23791 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23792 and double which avoids a conversion from an integer to a double.
23794 * expression.cs: tiny optimization, avoid calling IsConstant,
23795 because it effectively performs the lookup twice.
23797 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23799 But a bogus return here to keep the semantics of the old code
23800 until the Mono runtime is fixed.
23802 * pending.cs (GetMissingInterfaces): New method used to remove all
23803 the interfaces that are already implemented by our parent
23804 classes from the list of pending methods.
23806 * interface.cs: Add checks for calls after ResolveTypeExpr.
23808 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23810 * class.cs (Class.Emit): Report warning 67: event not used if the
23811 warning level is beyond 3.
23813 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23814 being a NullLiteral.
23816 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23819 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23820 path that might fail if a type can not be resolved.
23822 * expression.cs (Binary.Emit): Emit unsigned versions of the
23825 * driver.cs: use error 5.
23827 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23829 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23831 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23833 * cs-parser.jay (switch_section): A beautiful patch from Martin
23834 Baulig that fixed 33094.
23836 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23838 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23839 Check whether the base is abstract and report an error if so.
23841 * expression.cs (IndexerAccess.DoResolveLValue,
23842 IndexerAccess.DoResolve): ditto.
23844 (Invocation.DoResolve): ditto.
23846 (Invocation.FullMethodDesc): Improve the report string.
23848 * statement.cs (Block): Eliminate IsVariableDefined as it is
23849 basically just a wrapper for GetVariableInfo.
23851 * ecore.cs (SimpleName): Use new
23853 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23854 type, as we return the actual parameter ref/unref state on a
23857 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23859 * support.cs: Return proper flags REF/OUT fixing the previous
23862 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23863 not used to mean `ref' but `ref or out' in ParameterReference
23865 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23866 full type signature instead of calling TypeManger.CSharpName
23869 * support.cs (InternalParameters.ParameterDesc): Do not compare
23870 directly to the modflags, because REF/OUT will actually be bitsets
23873 * delegate.cs (VerifyMethod): Check also the modifiers.
23875 * cs-tokenizer.cs: Fix bug where floating point values with an
23876 exponent where a sign was missing was ignored.
23878 * driver.cs: Allow multiple assemblies to be specified in a single
23881 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23883 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23884 because identifiers after a parenthesis would end up in this kind
23885 of production, and we needed to desamiguate it for having casts
23888 (UserDefinedType *) xxx
23890 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23892 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23893 we should set on the Bindingflags.NonPublic, but not turn on
23894 private_ok. private_ok controls whether a Private member is
23895 returned (this is chekced on the filter routine), while the
23896 BindingFlags.NonPublic just controls whether private/protected
23897 will be allowed. This fixes the problem part of the problem of
23898 private properties being allowed to be used in derived classes.
23900 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23901 so we can call the children DoResolveLValue method (this will
23902 properly signal errors on lvalue assignments to base properties)
23904 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23905 getter are null, and we have a property info, we know that this
23906 happened because the lookup failed, so we report an error 122 for
23907 protection level violation.
23909 We also silently return if setter and getter are null in the
23910 resolve functions, this condition only happens if we have flagged
23911 the error before. This is the other half of the problem.
23913 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23914 not have accessibility information, that is why we were returning
23915 true in the filter function in typemanager.cs.
23917 To properly report 122 (property is inaccessible because of its
23918 protection level) correctly, we report this error in ResolveAccess
23919 by failing if both the setter and the getter are lacking (ie, the
23922 DoResolve and DoLResolve have been modified to check for both
23923 setter/getter being null and returning silently, the reason being
23924 that I did not want to put the knowledge about this error in upper
23927 int old = Report.Errors;
23928 x = new PropertyExpr (...);
23929 if (old != Report.Errors)
23934 So the property expr is returned, but it is invalid, so the error
23935 will be flagged during the resolve process.
23937 * class.cs: Remove InheritablePropertySignatureCompare from the
23938 class, as we no longer depend on the property signature to compute
23939 whether it is possible to implement a method or not.
23941 The reason is that calling PropertyInfo.GetGetMethod will return
23942 null (in .NET, in Mono it works, and we should change this), in
23943 cases where the Get Method does not exist in that particular
23948 class X { public virtual int A { get { return 1; } } }
23950 class Z : Y { public override int A { get { return 2; } } }
23952 Would fail in Z because the parent (Y) would not have the property
23953 defined. So we avoid this completely now (because the alternative
23954 fix was ugly and slow), and we now depend exclusively on the
23957 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23958 reference method, instead of using the property.
23960 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23961 routines are gone now.
23963 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23964 names, they were incorrectly named.
23966 * cs-tokenizer.cs: Return are more gentle token on failure.
23968 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23969 had an out-of-sync index variable, which caused it to remove from
23970 the list of pending methods the wrong method sometimes.
23972 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23974 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23975 CanWrite, because those refer to this particular instance of the
23976 property, and do not take into account the fact that we can
23977 override single members of a property.
23979 Constructor requires an EmitContext. The resolution process does
23980 not happen here, but we need to compute the accessors before,
23981 because the resolution does not always happen for properties.
23983 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23984 subclass, before we did not update this flag, but we did update
23987 (GetAccessors): Drop this routine, as it did not work in the
23988 presence of partially overwritten set/get methods.
23990 Notice that this broke the cs1540 detection, but that will require
23993 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23997 * driver.cs: issue a warning instead of an error if we don't support
23998 debugging for the platform. Also ignore a couple of errors that may
23999 arise when trying to write the symbols. Undo my previous patch.
24001 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24003 * driver.cs: ignore /debug switch except for Unix platforms.
24005 2002-10-23 Nick Drochak <ndrochak@gol.com>
24007 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24009 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24011 * driver.cs: Do not make mcs-debug conditional, so we do not break
24012 builds that use it.
24014 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24015 review this patch. But basically after all the children variables
24016 have been merged, the value of "Breaks" was not being set to
24017 new_breaks for Switch blocks. I think that it should be set after
24018 it has executed. Currently I set this to the value of new_breaks,
24019 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24020 conservative, but I do not understand this code very well.
24022 I did not break anything in the build, so that is good ;-)
24024 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24026 2002-10-20 Mark Crichton <crichton@gimp.org>
24028 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24030 2002-10-20 Nick Drochak <ndrochak@gol.com>
24032 * cfold.cs: Fixed compile blocker.
24034 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24036 * driver.cs: I was chekcing the key, not the file.
24038 2002-10-19 Ravi Pratap <ravi@ximian.com>
24040 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24041 message that we were generating - we just need to silently return
24044 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24046 * class.cs (Event.Define): Change my previous commit, as this
24047 breaks the debugger. This is a temporary hack, as it seems like
24048 the compiler is generating events incorrectly to begin with.
24050 * expression.cs (Binary.ResolveOperator): Added support for
24051 "U operator - (E x, E y)"
24053 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24056 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24057 init-only variables, but this path did not take into account that
24058 there might be also instance readonly variables. Correct this
24061 This fixes bug 32253
24063 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24066 * driver.cs: Change the extension for modules to `netmodule'
24068 * cs-parser.jay: Improved slightly the location tracking for
24069 the debugger symbols.
24071 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24072 modifiers that were specified instead of the hardcoded value
24073 (FamAndAssem). This was basically ignoring the static modifier,
24074 and others. Fixes 32429.
24076 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24077 fixed a bug in the process (32476)
24079 * expression.cs (ArrayAccess.EmitAssign): Patch from
24080 hwang_rob@yahoo.ca that fixes bug 31834.3
24082 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24084 * driver.cs: Make the module extension .netmodule.
24086 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24088 * driver.cs: Report an error if the resource file is not found
24089 instead of crashing.
24091 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24092 false, like Emit does.
24094 2002-10-16 Nick Drochak <ndrochak@gol.com>
24096 * typemanager.cs: Remove unused private member. Also reported mcs
24097 bug to report this as a warning like csc.
24099 2002-10-15 Martin Baulig <martin@gnome.org>
24101 * statement.cs (Statement.Emit): Made this a virtual method; emits
24102 the line number info and calls DoEmit().
24103 (Statement.DoEmit): New protected abstract method, formerly knows
24104 as Statement.Emit().
24106 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24108 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24110 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24111 have fixed a remaining problem: not every AddXXXX was adding a
24112 fully qualified name.
24114 Now everyone registers a fully qualified name in the DeclSpace as
24115 being defined instead of the partial name.
24117 Downsides: we are slower than we need to be due to the excess
24118 copies and the names being registered this way.
24120 The reason for this is that we currently depend (on the corlib
24121 bootstrap for instance) that types are fully qualified, because
24122 we dump all the types in the namespace, and we should really have
24123 types inserted into the proper namespace, so we can only store the
24124 basenames in the defined_names array.
24126 2002-10-10 Martin Baulig <martin@gnome.org>
24128 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24129 from bug #31834, see the bug report for a testcase which is
24132 2002-10-10 Martin Baulig <martin@gnome.org>
24134 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24135 flow analysis code for this.
24137 * statement.cs (Do, While, For): Tell the flow analysis code about
24139 (FlowBranching.UsageVector): Added support for infinite loops.
24140 (Block.Resolve): Moved the dead code elimination here and use flow
24143 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24145 * class.cs (Field.Define): Catch cycles on struct type
24148 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24149 fields if the fields are static. We only need to check instance
24152 * expression.cs (As.DoResolve): Test for reference type.
24154 * statement.cs (Using.ResolveExpression): Use
24155 ConvertImplicitRequired, not ConvertImplicit which reports an
24157 (Using.ResolveLocalVariableDecls): ditto.
24159 * expression.cs (Binary.ResolveOperator): Report errors in a few
24160 places where we had to.
24162 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24164 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24166 * expression.cs: Use StoreFromPtr instead of extracting the type
24167 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24169 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24170 an enumeration value to a System.Enum, but System.Enum is not a
24171 value type, but an class type, so we need to box.
24173 (Expression.ConvertExplicit): One codepath could return
24174 errors but not flag them. Fix this. Fixes #31853
24176 * parameter.cs (Resolve): Do not allow void as a parameter type.
24178 2002-10-06 Martin Baulig <martin@gnome.org>
24180 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24181 if it's a class type and not a struct. Fixes #31815.
24183 2002-10-06 Martin Baulig <martin@gnome.org>
24185 * statement.cs: Reworked the flow analysis code a bit to make it
24186 usable for dead code elimination.
24188 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24190 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24192 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24194 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24195 to fix the test 165, will investigate deeper.
24197 2002-10-04 Martin Baulig <martin@gnome.org>
24199 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24200 finally blocks actually work.
24201 (Try.Resolve): We don't need to create a sibling for `finally' if
24202 there is no finally block.
24204 2002-10-04 Martin Baulig <martin@gnome.org>
24206 * class.cs (Constructor.Define): The default accessibility for a
24207 non-default constructor is private, not public.
24209 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24211 * class.cs (Constructor): Make AllowedModifiers public, add
24214 * cs-parser.jay: Perform the modifiers test here, as the
24215 constructor for the Constructor class usually receives a zero
24216 because of the way we create it (first we create, later we
24217 customize, and we were never checking the modifiers).
24219 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24220 is a version of LookupTypeReflection that includes the type-name
24221 cache. This can be used as a fast path for functions that know
24222 the fully qualified name and are only calling into *.GetType() to
24223 obtain a composed type.
24225 This is also used by TypeManager.LookupType during its type
24228 (LookupType): We now also track the real type name, as sometimes
24229 we can get a quey for the real type name from things like
24230 ComposedCast. This fixes bug 31422.
24232 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24233 complete type fullname, it does not have to go through the type
24234 resolution system to obtain the composed version of the type (for
24235 obtaining arrays or pointers).
24237 (Conditional.Emit): Use the EmitBoolExpression to
24238 generate nicer code, as requested by Paolo.
24240 (ArrayCreation.CheckIndices): Use the patch from
24241 hwang_rob@yahoo.ca to validate the array initializers.
24243 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24245 * class.cs (ConstructorInitializer.Emit): simplify code by using
24246 Invocation.EmitCall, and at the same time, fix the bugs in calling
24247 parent constructors that took variable arguments.
24249 * ecore.cs (Expression.ConvertNumericExplicit,
24250 Expression.ImplicitNumericConversion): Remove the code that
24251 manually wrapped decimal (InternalTypeConstructor call is now gone
24254 * expression.cs (Cast.TryReduce): Also handle decimal types when
24255 trying to perform a constant fold on the type.
24257 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24259 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24260 that only turned off an error report, and did nothing else.
24262 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24264 * driver.cs: Handle and ignore /fullpaths
24266 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24268 * expression.cs (Binary.ResolveOperator): Catch the case where
24269 DoNumericPromotions returns true,
24271 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24273 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24275 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24278 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24280 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24281 conversion exists, but it is also required that the conversion be
24282 performed. This manifested in "(Type64Enum) 2".
24284 * class.cs (TypeManager.AddMethod): The fix is not to change
24285 AddEnum, because that one was using a fully qualified name (every
24286 DeclSpace derivative does), but to change the AddMethod routine
24287 that was using an un-namespaced name. This now correctly reports
24288 the duplicated name.
24290 Revert patch until I can properly fix it. The issue
24291 is that we have a shared Type space across all namespaces
24292 currently, which is wrong.
24294 Options include making the Namespace a DeclSpace, and merge
24295 current_namespace/current_container in the parser.
24297 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24299 * cs-parser.jay: Improve error reporting when we get a different
24300 kind of expression in local_variable_type and
24301 local_variable_pointer_type.
24303 Propagate this to avoid missleading errors being reported.
24305 * ecore.cs (ImplicitReferenceConversion): treat
24306 TypeManager.value_type as a target just like object_type. As
24311 Is valid, and needs to result in the int 1 being boxed before it
24312 is assigned to the value type v.
24314 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24315 to validate the enumeration name.
24317 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24318 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24319 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24321 * ecore.cs (TryImplicitIntConversion): When doing an
24322 implicit-enumeration-conversion, check if the type is 64-bits and
24323 perform a conversion before passing to EnumConstant.
24325 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24327 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24328 report ambiguous type references. Unlike the MS version, we
24329 report what the ambiguity is. Innovation at work ;-)
24331 (DeclSpace.FindType): Require a location argument to
24332 display when we display an ambiguous error.
24334 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24336 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24338 * expression.cs (EmitDynamicInitializers): Apply patch from
24339 hwang_rob@yahoo.ca that fixes the order in which we emit our
24342 2002-09-21 Martin Baulig <martin@gnome.org>
24344 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24345 delegate takes no arguments.
24347 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24349 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24352 * expression.cs: Extract the underlying type.
24354 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24356 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24358 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24360 * class.cs (TypeContainer.DefineType): We can not use the nice
24361 PackingSize with the size set to 1 DefineType method, because it
24362 will not allow us to define the interfaces that the struct
24365 This completes the fixing of bug 27287
24367 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24368 means also structs. This fixes part of the problem.
24369 (Expresion.ImplicitReferenceConversionExists): ditto.
24371 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24372 error if there were no errors reported during the type lookup
24373 process, to avoid duplicates or redundant errors. Without this
24374 you would get an ambiguous errors plus a type not found. We have
24375 beaten the user enough with the first error.
24377 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24380 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24381 during the resolution process, stop the lookup, this avoids
24382 repeated error reports (same error twice).
24384 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24386 * typemanager.cs (LookupType): Redo the type lookup code to match
24387 the needs of System.Reflection.
24389 The issue is that System.Reflection requires references to nested
24390 types to begin with a "+" sign instead of a dot. So toplevel
24391 types look like: "NameSpace.TopLevelClass", and nested ones look
24392 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24395 2002-09-19 Martin Baulig <martin@gnome.org>
24397 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24398 says that a method always returns or always throws an exception,
24399 don't report the CS0161.
24401 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24402 set `Returns = new_returns'.
24404 2002-09-19 Martin Baulig <martin@gnome.org>
24406 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24407 to an enum constant, check for a CS0176.
24409 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24411 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24412 for operators that must be in pairs and report errors.
24414 * ecore.cs (SimpleName.DoResolveType): During the initial type
24415 resolution process, when we define types recursively, we must
24416 check first for types in our current scope before we perform
24417 lookups in the enclosing scopes.
24419 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24421 (Invocation.VerifyArgumentsCompat): Call
24422 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24423 I thought we were supposed to always call this, but there are a
24424 few places in the code where we dont do it.
24426 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24428 * driver.cs: Add support in -linkres and -resource to specify the
24429 name of the identifier.
24431 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24433 * ecore.cs (StandardConversionExists): Sync with the conversion
24434 code: allow anything-* to void* conversions.
24436 (FindMostSpecificSource): Use an Expression argument
24437 instead of a Type, because we might be handed over a Literal which
24438 gets a few more implicit conversions that plain types do not. So
24439 this information was being lost.
24441 Also, we drop the temporary type-holder expression when not
24444 2002-09-17 Martin Baulig <martin@gnome.org>
24446 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24447 this is an explicit interface implementation.
24449 2002-09-17 Martin Baulig <martin@gnome.org>
24451 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24452 different `IndexerName' attributes.
24454 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24455 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24456 virtual CommonResolve().
24458 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24460 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24461 and convert that to the UnderlyingType.
24463 * statement.cs (Foreach.Resolve): Indexers are just like variables
24464 or PropertyAccesses.
24466 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24467 inside quoted strings, we were not doing this before.
24469 2002-09-16 Martin Baulig <martin@gnome.org>
24471 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24472 resolve it. This is needed for the definite assignment check of the
24473 instance expression, fixes bug #29846.
24474 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24476 2002-09-16 Nick Drochak <ndrochak@gol.com>
24478 * parameter.cs: Fix compile error. Cannot reference static member
24479 from an instance object. Is this an mcs bug?
24481 2002-09-14 Martin Baulig <martin@gnome.org>
24483 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24484 multiple times. Fixes bug #30295, added test-166.cs.
24486 2002-09-14 Martin Baulig <martin@gnome.org>
24488 * statement.cs (Block.Emit): Don't emit unreachable code.
24489 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24490 `break' statements.
24491 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24493 2002-09-14 Martin Baulig <martin@gnome.org>
24495 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24498 2002-09-14 Martin Baulig <martin@gnome.org>
24500 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24501 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24502 be false on the ms runtime.
24504 2002-09-13 Martin Baulig <martin@gnome.org>
24506 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24507 the CS0038 error message.
24509 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24511 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24512 constant inside, return it.
24514 2002-09-12 Martin Baulig <martin@gnome.org>
24516 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24517 implicit conversion can be done between enum types.
24519 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24520 check whether an implicit conversion to the current enum's UnderlyingType
24521 exists and report an error if not.
24523 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24524 without debugging support.
24526 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24527 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24529 2002-09-12 Martin Baulig <martin@gnome.org>
24531 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24533 * ecore.cs (IMemberExpr.DeclaringType): New property.
24534 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24535 nonstatic member of an outer type (CS0038).
24537 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24539 * driver.cs: Activate the using-error detector at warning level
24540 4 (at least for MS-compatible APIs).
24542 * namespace.cs (VerifyUsing): Small buglett fix.
24544 * pending.cs (PendingImplementation): pass the container pointer.
24546 * interface.cs (GetMethods): Allow for recursive definition. Long
24547 term, I would like to move every type to support recursive
24548 definitions, not the current ordering mechanism that we have right
24551 The situation is this: Attributes are handled before interfaces,
24552 so we can apply attributes to interfaces. But some attributes
24553 implement interfaces, we will now handle the simple cases
24554 (recursive definitions will just get an error).
24556 * parameter.cs: Only invalidate types at the end if we fail to
24559 2002-09-09 Martin Baulig <martin@gnome.org>
24561 * ecore.cs (PropertyExpr.Emit): Also check for
24562 TypeManager.system_int_array_get_length so this'll also work when
24563 compiling corlib. Fixes #30003.
24565 2002-09-09 Martin Baulig <martin@gnome.org>
24567 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24568 and throw an exception if we can't get the type's size. Fixed #30040,
24571 2002-09-09 Martin Baulig <martin@gnome.org>
24573 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24575 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24576 context. Fixes bug #30027.
24578 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24579 virtual functions. Fixes bug #30043, added test-164.cs.
24581 2002-09-08 Ravi Pratap <ravi@ximian.com>
24583 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24585 2002-09-08 Nick Drochak <ndrochak@gol.com>
24587 * driver.cs: Use an object to get the windows codepage since it's not a
24590 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24592 * statement.cs (For.Emit): for infinite loops (test == null)
24593 return whether there is a break inside, not always "true".
24595 * namespace.cs (UsingEntry): New struct to hold the name of the
24596 using definition, the location where it is defined, and whether it
24597 has been used in a successful type lookup.
24599 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24604 2002-09-06 Ravi Pratap <ravi@ximian.com>
24606 * attribute.cs : Fix incorrect code which relied on catching
24607 a NullReferenceException to detect a null being passed in
24608 where an object was expected.
24610 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24612 * statement.cs (Try): flag the catch variable as assigned
24614 * expression.cs (Cast): Simplified by using ResolveType instead of
24615 manually resolving.
24617 * statement.cs (Catch): Fix bug by using ResolveType.
24619 2002-09-06 Ravi Pratap <ravi@ximian.com>
24621 * expression.cs (BetterConversion): Special case for when we have
24622 a NullLiteral as the argument and we have to choose between string
24623 and object types - we choose string the way csc does.
24625 * attribute.cs (Attribute.Resolve): Catch the
24626 NullReferenceException and report error #182 since the Mono
24627 runtime no more has the bug and having this exception raised means
24628 we tried to select a constructor which takes an object and is
24631 2002-09-05 Ravi Pratap <ravi@ximian.com>
24633 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24634 message (1502, 1503) when we can't locate a method after overload
24635 resolution. This is much more informative and closes the bug
24638 * interface.cs (PopulateMethod): Return if there are no argument
24639 types. Fixes a NullReferenceException bug.
24641 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24642 expressions too. Previously we were checking only in one place for
24643 positional arguments leaving out named arguments.
24645 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24646 type to the enum type is not allowed. Remove code corresponding to
24649 (ConvertNumericExplicit): Allow explicit conversions from
24650 the underlying type to enum type. This precisely follows the spec
24651 and closes a bug filed by Gonzalo.
24653 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24656 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24658 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24660 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24661 it was important that we stored the right value after the
24662 reduction in `converted'.
24664 2002-09-04 Martin Baulig <martin@gnome.org>
24666 * location.cs (Location.SymbolDocument): Use full pathnames for the
24669 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24671 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24672 of the expression resolve mechanism, because that will catch the
24673 SimpleName error failures.
24675 (Conditional): If we can not resolve the
24676 expression, return, do not crash.
24678 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24681 (location): display token name instead of its number.
24683 2002-08-28 Martin Baulig <martin@gnome.org>
24685 * expression.cs (Binary.ResolveOperator): Don't silently return
24686 but return an error if an operator cannot be applied between two
24689 2002-08-28 Martin Baulig <martin@gnome.org>
24691 * class.cs (Constructor.Define): Set the permission attributes
24692 correctly instead of making all constructors public.
24694 2002-08-28 Martin Baulig <martin@gnome.org>
24696 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24697 for private members before reporting a CS0103; if we find anything,
24700 2002-08-28 Martin Baulig <martin@gnome.org>
24702 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24703 to check whether `closure_start_type == closure_invocation_type',
24704 we also need to check whether `m.DeclaringType == closure_invocation_type'
24705 before bypassing the permission checks. We might be accessing
24706 protected/private members from the base class.
24707 (TypeManager.RealMemberLookup): Only set private_ok if private
24708 members were requested via BindingFlags.NonPublic.
24710 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24712 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24713 MethodGroupExpr.IsExplicitImpl if appropriate.
24714 (Invocation.DoResolve): Don't report the CS0120 for explicit
24715 interface implementations.
24717 2002-08-27 Martin Baulig <martin@gnome.org>
24719 * expression.cs (Invocation.DoResolve): If this is a static
24720 method and we don't have an InstanceExpression, we must report
24723 2002-08-25 Martin Baulig <martin@gnome.org>
24725 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24726 `==' between a valuetype and an object.
24728 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24730 * ecore.cs (TypeExpr): Provide a ToString method.
24732 2002-08-24 Martin Baulig <martin@gnome.org>
24734 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24735 now called proggie.dbg and it's a binary file.
24737 2002-08-23 Martin Baulig <martin@gnome.org>
24739 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24741 2002-08-23 Martin Baulig <martin@gnome.org>
24743 * struct.cs (MyStructInfo.ctor): Make this work with empty
24744 structs; it's not allowed to use foreach() on null.
24746 2002-08-23 Martin Baulig <martin@gnome.org>
24748 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24749 writer the full pathname of the generated assembly.
24751 2002-08-23 Martin Baulig <martin@gnome.org>
24753 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24754 A `finally' block never returns or breaks; improved handling of
24757 2002-08-23 Martin Baulig <martin@gnome.org>
24759 * statement.cs (Throw.Resolve): Allow `throw null'.
24761 2002-08-23 Martin Baulig <martin@gnome.org>
24763 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24764 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24765 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24766 MemberLookup would return a wrong event if this is an explicit
24767 interface implementation and the class has an event with the same
24770 2002-08-23 Martin Baulig <martin@gnome.org>
24772 * statement.cs (Block.AddChildVariableNames): New public method.
24773 (Block.AddChildVariableName): Likewise.
24774 (Block.IsVariableNameUsedInChildBlock): Likewise.
24775 (Block.AddVariable): Check whether a variable name has already
24776 been used in a child block.
24778 * cs-parser.jay (declare_local_variables): Mark all variable names
24779 from the current block as being used in a child block in the
24782 2002-08-23 Martin Baulig <martin@gnome.org>
24784 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24785 find the symbol writer.
24787 * driver.cs: csc also allows the arguments to /define being
24788 separated by commas, not only by semicolons.
24790 2002-08-23 Martin Baulig <martin@gnome.org>
24792 * interface.cs (Interface.GetMembers): Added static check for events.
24794 2002-08-15 Martin Baulig <martin@gnome.org>
24796 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24797 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24799 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24800 why the MethodData.EmitDestructor() change was necessary.
24802 2002-08-20 Martin Baulig <martin@gnome.org>
24804 * class.cs (TypeContainer.FindMembers): Added static check for events.
24806 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24808 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24809 use Type.GetEvents(), not Type.FindMembers().
24811 2002-08-20 Martin Baulig <martin@gnome.org>
24813 * decl.cs (MemberCache): Added a special method cache which will
24814 be used for method-only searched. This ensures that a method
24815 search will return a MethodInfo with the correct ReflectedType for
24818 2002-08-20 Martin Baulig <martin@gnome.org>
24820 * decl.cs (DeclSpace.FindMembers): Made this public.
24822 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24824 * delegate.cs: fixed build on windows.
24825 [FIXME: Filed as bug #29150: MCS must report these errors.]
24827 2002-08-19 Ravi Pratap <ravi@ximian.com>
24829 * ecore.cs (StandardConversionExists): Return a false
24830 if we are trying to convert the void type to anything else
24831 since that is not allowed.
24833 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24834 we flag error 70 in the event an event is trying to be accessed
24835 directly from outside the declaring type.
24837 2002-08-20 Martin Baulig <martin@gnome.org>
24839 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24840 MemberCache from typemanager.cs to decl.cs.
24842 2002-08-19 Martin Baulig <martin@gnome.org>
24844 * class.cs (TypeContainer): Implement IMemberContainer.
24845 (TypeContainer.DefineMembers): Create the MemberCache.
24846 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24847 return public members if BindingFlags.Public was given, check
24848 whether members are static.
24850 2002-08-16 Martin Baulig <martin@gnome.org>
24852 * decl.cs (DeclSpace.Define): Splitted this in Define and
24853 DefineMembers. DefineMembers is called first and initializes the
24856 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24857 DefineMembers() on all our DeclSpaces.
24859 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24860 but call DefineMembers() on all nested interfaces. We call their
24861 Define() in our new Define() function.
24863 * interface.cs (Interface): Implement IMemberContainer.
24864 (Interface.Define): Moved all code except the attribute stuf to
24866 (Interface.DefineMembers): Initialize the member cache.
24868 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24869 need this anymore since we can use MemberCache.FindMembers directly.
24871 2002-08-19 Martin Baulig <martin@gnome.org>
24873 * typemanager.cs (MemberCache): When creating the cache for an
24874 interface type, add all inherited members.
24875 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24876 to `out bool used_cache' and documented it.
24877 (TypeManager.MemberLookup): If we already used the cache in the first
24878 iteration, we don't need to do the interfaces check.
24880 2002-08-19 Martin Baulig <martin@gnome.org>
24882 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24883 here from IMemberFinder and don't implement this interface anymore.
24884 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24886 * typemanager.cs (IMemberFinder): This interface is now only used by
24887 classes which actually support the member cache.
24888 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24889 since we only put DeclSpaces into this Hashtable.
24890 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24891 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24893 2002-08-16 Martin Baulig <martin@gnome.org>
24895 * typemanager.cs (ICachingMemberFinder): Removed.
24896 (IMemberFinder.MemberCache): New property.
24897 (TypeManager.FindMembers): Merged this with RealFindMembers().
24898 This function will never be called from TypeManager.MemberLookup()
24899 so we can't use the cache here, just the IMemberFinder.
24900 (TypeManager.MemberLookup_FindMembers): Check whether the
24901 IMemberFinder has a MemberCache and call the cache's FindMembers
24903 (MemberCache): Rewrote larger parts of this yet another time and
24904 cleaned it up a bit.
24906 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24908 * driver.cs (LoadArgs): Support quoting.
24910 (Usage): Show the CSC-like command line arguments.
24912 Improved a few error messages.
24914 2002-08-15 Martin Baulig <martin@gnome.org>
24916 * typemanager.cs (IMemberContainer.Type): New property.
24917 (IMemberContainer.IsInterface): New property.
24919 The following changes are conditional to BROKEN_RUNTIME, which is
24920 defined at the top of the file.
24922 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24923 class'es members, but add all members from TypeHandle.ObjectType
24924 if we're an interface.
24925 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24926 is the current type.
24927 (MemberCache.CacheEntry.Container): Removed this field.
24928 (TypeHandle.GetMembers): Include inherited members.
24930 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24932 * typemanager.cs: fixed compilation and added a comment on a field that
24935 2002-08-15 Martin Baulig <martin@gnome.org>
24937 * class.cs (ConstructorInitializer.Resolve): In the
24938 Expression.MemberLookup call, use the queried_type as
24941 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24942 declared' attribute, it's always true.
24943 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24944 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24945 temporary wrapper for FindMembers which tells MemberLookup whether
24946 members from the base classes are included in the return value.
24947 This will go away soon.
24948 (TypeManager.MemberLookup): Use this temporary hack here; once the
24949 new MemberCache is completed, we don't need to do the DeclaredOnly
24950 looping here anymore since the MemberCache will take care of this.
24951 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24952 (MemberCache): When creating the MemberCache for a class, get
24953 members from the current class and all its base classes.
24954 (MemberCache.CacheEntry.Container): New field. This is a
24955 temporary hack until the Mono runtime is fixed to distinguish
24956 between ReflectedType and DeclaringType. It allows us to use MCS
24957 with both the MS runtime and the unfixed Mono runtime without
24958 problems and without accecting performance.
24959 (MemberCache.SearchMembers): The DeclaredOnly looping from
24960 TypeManager.MemberLookup is now done here.
24962 2002-08-14 Martin Baulig <martin@gnome.org>
24964 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24965 Type.GetFields on dynamic types but get the fields from the
24966 corresponding TypeContainer.
24967 (MyStructInfo.GetStructInfo): Added check for enum types.
24969 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24970 (MemberList.SyncRoot): Implemented.
24971 (TypeManager.FilterWithClosure): No need to check permissions if
24972 closure_start_type == closure_invocation_type, don't crash if
24973 closure_invocation_type is null.
24975 2002-08-13 Martin Baulig <martin@gnome.org>
24977 Rewrote TypeContainer.FindMembers to use a member cache. This
24978 gives us a speed increase of about 35% for the self-hosting MCS
24979 build and of about 15-20% for the class libs (both on GNU/Linux).
24981 * report.cs (Timer): New class to get enhanced profiling. This
24982 whole class is "TIMER" conditional since it remarkably slows down
24985 * class.cs (MemberList): New class. This is an IList wrapper
24986 which we're now using instead of passing MemberInfo[]'s around to
24987 avoid copying this array unnecessarily.
24988 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24989 (ICachingMemberFinder, IMemberContainer): New interface.
24990 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24991 has already been checked, otherwise use it for the name comparision.
24992 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24993 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24994 if possible. Returns a MemberList, not a MemberInfo [].
24995 (TypeHandle): New class, implements IMemberContainer. We create
24996 one instance of this class per type, it contains a MemberCache
24997 which is used to do the member lookups.
24998 (MemberCache): New class. Each instance of this class contains
24999 all members of a type and a name-based hash table.
25000 (MemberCache.FindMembers): This is our new member lookup
25001 function. First, it looks up all members of the requested name in
25002 the hash table. Then, it walks this list and sorts out all
25003 applicable members and returns them.
25005 2002-08-13 Martin Baulig <martin@gnome.org>
25007 In addition to a nice code cleanup, this gives us a performance
25008 increase of about 1.4% on GNU/Linux - not much, but it's already
25009 half a second for the self-hosting MCS compilation.
25011 * typemanager.cs (IMemberFinder): New interface. It is used by
25012 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25013 Enum, Delegate or Interface.
25014 (TypeManager.finder_to_member_finder): New PtrHashtable.
25015 (TypeManager.finder_to_container): Removed.
25016 (TypeManager.finder_to_delegate): Removed.
25017 (TypeManager.finder_to_interface): Removed.
25018 (TypeManager.finder_to_enum): Removed.
25020 * interface.cs (Interface): Implement IMemberFinder.
25022 * delegate.cs (Delegate): Implement IMemberFinder.
25024 * enum.cs (Enum): Implement IMemberFinder.
25026 * class.cs (TypeContainer): Implement IMemberFinder.
25028 2002-08-12 Martin Baulig <martin@gnome.org>
25030 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25032 2002-08-12 Martin Baulig <martin@gnome.org>
25034 * ecore.cs (ITypeExpression): New interface for expressions which
25036 (TypeExpression): Renamed to TypeLookupExpression.
25037 (Expression.DoResolve): If we're doing a types-only lookup, the
25038 expression must implement the ITypeExpression interface and we
25039 call DoResolveType() on it.
25040 (SimpleName): Implement the new ITypeExpression interface.
25041 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25042 hack, the situation that we're only looking up types can't happen
25043 anymore when this method is called. Moved the type lookup code to
25044 DoResolveType() and call it.
25045 (SimpleName.DoResolveType): This ITypeExpression interface method
25046 is now doing the types-only lookup.
25047 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25048 (ResolveFlags): Added MaskExprClass.
25050 * expression.cs (MemberAccess): Implement the ITypeExpression
25052 (MemberAccess.DoResolve): Added support for a types-only lookup
25053 when we're called via ITypeExpression.DoResolveType().
25054 (ComposedCast): Implement the ITypeExpression interface.
25056 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25057 Expression.Resolve() with ResolveFlags.Type instead.
25059 2002-08-12 Martin Baulig <martin@gnome.org>
25061 * interface.cs (Interface.Define): Apply attributes.
25063 * attribute.cs (Attribute.ApplyAttributes): Added support for
25064 interface attributes.
25066 2002-08-11 Martin Baulig <martin@gnome.org>
25068 * statement.cs (Block.Emit): Only check the "this" variable if we
25069 do not always throw an exception.
25071 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25072 whether the property has a set accessor.
25074 2002-08-11 Martin Baulig <martin@gnome.org>
25076 Added control flow analysis support for structs.
25078 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25079 with control flow analysis turned off.
25080 (IVariable): New interface.
25081 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25082 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25083 (FieldExpr.DoResolve): Resolve the instance expression with flow
25084 analysis turned off and do the definite assignment check after the
25085 resolving when we know what the expression will resolve to.
25087 * expression.cs (LocalVariableReference, ParameterReference):
25088 Implement the new IVariable interface, only call the flow analysis
25089 code if ec.DoFlowAnalysis is true.
25090 (This): Added constructor which takes a Block argument. Implement
25091 the new IVariable interface.
25092 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25093 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25094 This does the definite assignment checks for struct members.
25096 * class.cs (Constructor.Emit): If this is a non-static `struct'
25097 constructor which doesn't have any initializer, call
25098 Block.AddThisVariable() to tell the flow analysis code that all
25099 struct elements must be initialized before control returns from
25102 * statement.cs (MyStructInfo): New public class.
25103 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25104 argument to this indexer. If non-zero, check an individual struct
25105 member, not the whole struct.
25106 (FlowBranching.CheckOutParameters): Check struct members.
25107 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25108 overloaded versions of these methods which take an additional
25109 `int field_idx' argument to check struct members.
25110 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25111 overloaded versions of these methods which take an additional
25112 `string field_name' argument to check struct member.s
25113 (VariableInfo): Implement the IVariable interface.
25114 (VariableInfo.StructInfo): New public property. Returns the
25115 MyStructInfo instance of the variable if it's a struct or null.
25116 (Block.AddThisVariable): New public method. This is called from
25117 Constructor.Emit() for non-static `struct' constructor which do
25118 not have any initializer. It creates a special variable for the
25119 "this" instance variable which will be checked by the flow
25120 analysis code to ensure that all of the struct's fields are
25121 initialized before control returns from the constructor.
25122 (UsageVector): Added support for struct members. If a
25123 variable/parameter is a struct with N members, we reserve a slot
25124 in the usage vector for each member. A struct is considered fully
25125 initialized if either the struct itself (slot 0) or all its
25126 members are initialized.
25128 2002-08-08 Martin Baulig <martin@gnome.org>
25130 * driver.cs (Driver.MainDriver): Only report an error CS5001
25131 if there were no compilation errors.
25133 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25134 `UnsafeContext' property to determine whether the parent is in
25135 unsafe context rather than checking the parent's ModFlags:
25136 classes nested in an unsafe class are unsafe as well.
25138 2002-08-08 Martin Baulig <martin@gnome.org>
25140 * statement.cs (UsageVector.MergeChildren): Distinguish between
25141 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25142 we return. Added test17() and test18() to test-154.cs.
25144 2002-08-08 Martin Baulig <martin@gnome.org>
25146 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25147 Family access, make sure the invoking type isn't a subclass of the
25148 queried type (that'd be a CS1540).
25150 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25151 this method which takes an additional `Type invocation_type'.
25153 * expression.cs (BaseAccess.DoResolve): Use the base type as
25154 invocation and query type.
25155 (MemberAccess.DoResolve): If the lookup failed and we're about to
25156 report a CS0122, try a lookup with the ec.ContainerType - if this
25157 succeeds, we must report a CS1540.
25159 2002-08-08 Martin Baulig <martin@gnome.org>
25161 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25162 (MethodGroupExpr): Implement the IMemberExpr interface.
25164 * expression (MemberAccess.ResolveMemberAccess): No need to have
25165 any special code for MethodGroupExprs anymore, they're now
25168 2002-08-08 Martin Baulig <martin@gnome.org>
25170 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25171 Family, FamANDAssem and FamORAssem permissions.
25172 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25174 2002-08-08 Martin Baulig <martin@gnome.org>
25176 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25177 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25180 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25182 * driver.cs: implemented /resource option to embed managed resources.
25184 2002-08-07 Martin Baulig <martin@gnome.org>
25186 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25187 (FieldBase.HasFieldInitializer): New public property.
25188 (FieldBase.GetInitializerExpression): New public method. Resolves and
25189 returns the field initializer and makes sure it is only resolved once.
25190 (TypeContainer.EmitFieldInitializers): Call
25191 FieldBase.GetInitializerExpression to get the initializer, this ensures
25192 that it isn't resolved multiple times.
25194 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25195 the resolving process (SimpleName/MemberLookup) that we're currently
25196 emitting a field initializer (which must not access any instance members,
25197 this is an error CS0236).
25199 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25200 argument, if the `IsFieldInitializer' flag is set, we must report and
25201 error CS0236 and not an error CS0120.
25203 2002-08-07 Martin Baulig <martin@gnome.org>
25205 * ecore.cs (IMemberExpr): New public interface.
25206 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25207 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25208 if the expression is an IMemberExpr.
25210 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25211 to be null, implicitly default to `this' if we're non-static in
25212 this case. Simplified the code a lot by using the new IMemberExpr
25213 interface. Also fixed bug #28176 here.
25215 2002-08-06 Martin Baulig <martin@gnome.org>
25217 * cs-parser.jay (SimpleLookup): Removed. We need to create
25218 ParameterReferences during semantic analysis so that we can do a
25219 type-only search when resolving Cast, TypeOf and SizeOf.
25220 (block): Pass the `current_local_parameters' to the Block's
25223 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25224 argument to the constructor.
25225 (ConstructorInitializer.Resolve): Create a temporary implicit
25226 block with the parameters.
25228 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25229 references here if we aren't doing a type-only search.
25231 * statement.cs (Block): Added constructor which takes a
25232 `Parameters parameters' argument.
25233 (Block.Parameters): New public property.
25235 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25236 to `Parameters' and made it public readonly.
25238 2002-08-06 Martin Baulig <martin@gnome.org>
25240 * ecore.cs (Expression.Warning): Made this public as well.
25242 * report.cs (Report.Debug): Print the contents of collections.
25244 2002-08-06 Martin Baulig <martin@gnome.org>
25246 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25247 used to tell Resolve() which kinds of expressions it may return.
25248 (Expression.Resolve): Added overloaded version of this method which
25249 takes a `ResolveFlags flags' argument. This can be used to tell
25250 Resolve() which kinds of expressions it may return. Reports a
25252 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25253 ResolveFlags.SimpleName.
25254 (Expression.Error118): Added overloaded version of this method which
25255 takes a `ResolveFlags flags' argument. It uses the flags to determine
25256 which kinds of expressions are allowed.
25258 * expression.cs (Argument.ResolveMethodGroup): New public method.
25259 Resolves an argument, but allows a MethodGroup to be returned.
25260 This is used when invoking a delegate.
25262 * TODO: Updated a bit.
25264 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25266 Fixed compilation with csc.
25268 * ecore.cs: Expression.Error made public. Is this correct? Should
25269 Warning be made public too?
25271 * expression.cs: use ea.Location instead of ea.loc.
25272 [FIXME: Filed as bug #28607: MCS must report these errors.]
25274 2002-08-06 Martin Baulig <martin@gnome.org>
25276 * ecore.cs (Expression.loc): Moved the location here instead of
25277 duplicating it in all derived classes.
25278 (Expression.Location): New public property.
25279 (Expression.Error, Expression.Warning): Made them non-static and
25280 removed the location argument.
25281 (Expression.Warning): Added overloaded version which takes an
25282 `int level' argument.
25283 (Expression.Error118): Make this non-static and removed the
25284 expression and location arguments.
25285 (TypeExpr): Added location argument to the constructor.
25287 * expression.cs (StaticCallExpr): Added location argument to
25289 (Indirection, PointerArithmetic): Likewise.
25290 (CheckedExpr, UnCheckedExpr): Likewise.
25291 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25292 (StringPtr): Likewise.
25295 2002-08-05 Martin Baulig <martin@gnome.org>
25297 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25299 * assign.cs (Assign.DoResolve): Check whether the source
25300 expression is a value or variable.
25302 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25303 while resolving the corresponding blocks.
25305 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25306 an error, don't silently return null.
25308 * statement.cs (Block.AddVariable): Do the error reporting here
25309 and distinguish between CS0128 and CS0136.
25310 (Block.DoResolve): Report all unused labels (warning CS0164).
25311 (LabeledStatement): Pass the location to the constructor.
25312 (LabeledStatement.HasBeenReferenced): New property.
25313 (LabeledStatement.Resolve): Set it to true here.
25315 * statement.cs (Return.Emit): Return success even after reporting
25316 a type mismatch error (CS0126 or CS0127), this is what csc does and
25317 it avoids confusing the users with any consecutive errors.
25319 2002-08-05 Martin Baulig <martin@gnome.org>
25321 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25323 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25325 * expression.cs (MemberAccess.DoResolve): Silently return if an
25326 error has already been reported.
25328 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25329 error has already been reported.
25331 2002-08-05 Martin Baulig <martin@gnome.org>
25333 * statement.cs (UsageVector): Only initialize the `parameters'
25334 vector if we actually have any "out" parameters.
25336 2002-08-05 Martin Baulig <martin@gnome.org>
25338 * expression.cs (Binary.ResolveOperator): When combining delegates,
25339 they must have the same type.
25341 2002-08-05 Martin Baulig <martin@gnome.org>
25343 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25344 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25345 work with the ms runtime and we also don't need it: if we're a
25346 PropertyBuilder and not in the `indexer_arguments' hash, then we
25347 are a property and not an indexer.
25349 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25350 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25351 since the latter one doesn't work with the ms runtime.
25353 2002-08-03 Martin Baulig <martin@gnome.org>
25355 Fixed bugs #27998 and #22735.
25357 * class.cs (Method.IsOperator): New public field.
25358 (Method.CheckBase): Report CS0111 if there's already a method
25359 with the same parameters in the current class. Report CS0508 when
25360 attempting to change the return type of an inherited method.
25361 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25362 and it's not marked abstract or extern.
25363 (PropertyBase): New abstract base class for Property and Indexer.
25364 (PropertyBase.CheckBase): Moved here from Property and made it work
25366 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25367 the same so we can reuse it there.
25368 (Property, Indexer): Derive from PropertyBase.
25369 (MethodSignature.inheritable_property_signature_filter): New delegate
25370 to find properties and indexers.
25372 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25373 argument and improved error reporting.
25375 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25376 EmptyReadOnlyParameters and made it a property.
25378 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25379 version of this method which takes a `PropertyInfo indexer'.
25380 (TypeManager.RegisterIndexer): New method.
25382 * class.cs: Added myself as author of this file :-)
25384 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25386 * class.cs: fixed compilation on windoze.
25388 2002-08-03 Martin Baulig <martin@gnome.org>
25390 * interface.cs (Interface.GetInterfaceBases): Check whether all
25391 base interfaces are at least as accessible than the current one.
25393 * class.cs (TypeContainer.GetClassBases): Check whether base types
25394 are at least as accessible than the current type.
25395 (TypeContainer.AsAccessible): Implemented and made non-static.
25396 (MemberBase.CheckParameters): Report errors if the accessibility
25399 * delegate.cs (Delegate.Delegate): The default visibility is
25400 internal for top-level types and private for nested types.
25401 (Delegate.Define): Report errors if the accessibility checks fail.
25403 * enum.cs (Enum.Enum): The default visibility is internal for
25404 top-level types and private for nested types.
25405 (Enum.DefineType): Compute the correct visibility.
25407 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25408 function which takes a `bool is_toplevel' instead of a TypeContainer.
25410 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25413 2002-08-02 Martin Baulig <martin@gnome.org>
25415 * expression.cs (LocalVariableReferenc): Added constructor which
25416 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25417 (LocalVariableReference.IsReadOnly): New property.
25418 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25419 variable is readonly, use our own readonly flag to do this; you can
25420 use the new constructor to get a writable reference to a read-only
25423 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25424 reference to the local variable.
25426 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25428 * rootcontext.cs (ResolveCore): Also include System.Exception
25430 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25431 we reach an EmptyStatement.
25433 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25436 * expression.cs (Binary.ResolveOperator): Check error result in
25439 use brtrue/brfalse directly and avoid compares to null.
25441 2002-08-02 Martin Baulig <martin@gnome.org>
25443 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25444 Fixes bug #28407, added test-155.cs.
25446 2002-08-01 Martin Baulig <martin@gnome.org>
25448 * class.cs (Event.EmitDefaultMethod): Make this work with static
25449 events. Fixes #28311, added verify-3.cs.
25451 2002-08-01 Martin Baulig <martin@gnome.org>
25453 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25454 `is_disposable' fields.
25455 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25456 `hm.is_disposable' if we're using the collection pattern.
25457 (Foreach.EmitCollectionForeach): Use the correct type for the
25458 enumerator's local variable, only emit the try/finally block if
25459 necessary (fixes #27713).
25461 2002-08-01 Martin Baulig <martin@gnome.org>
25463 * ecore.cs (Expression.report118): Renamed to Error118 and made
25466 * statement.cs (Throw.Resolve): Check whether the expression is of
25467 the correct type (CS0118) and whether the type derives from
25468 System.Exception (CS0155).
25469 (Catch.Resolve): New method. Do the type lookup here and check
25470 whether it derives from System.Exception (CS0155).
25471 (Catch.CatchType, Catch.IsGeneral): New public properties.
25473 * typemanager.cs (TypeManager.exception_type): Added.
25475 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25477 * driver.cs: Updated About function.
25479 2002-07-31 Martin Baulig <martin@gnome.org>
25481 Implemented Control Flow Analysis.
25483 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25484 (EmitContext.CurrentBranching): Added.
25485 (EmitContext.StartFlowBranching): Added.
25486 (EmitContext.EndFlowBranching): Added.
25487 (EmitContext.KillFlowBranching): Added.
25488 (EmitContext.IsVariableAssigned): Added.
25489 (EmitContext.SetVariableAssigned): Added.
25490 (EmitContext.IsParameterAssigned): Added.
25491 (EmitContext.SetParameterAssigned): Added.
25492 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25493 Added control flow analysis stuff here.
25495 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25496 resolve the expression as lvalue.
25497 (LocalVariableReference.DoResolve): Check whether the variable has
25498 already been assigned.
25499 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25500 the parameter as assigned here.
25501 (ParameterReference.DoResolve): Check whether the parameter has already
25503 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25504 expression as lvalue.
25506 * statement.cs (FlowBranching): New class for the flow analysis code.
25507 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25508 (LabeledStatement.IsDefined): New public property.
25509 (LabeledStatement.AddUsageVector): New public method to tell flow
25510 analyis that the label may be reached via a forward jump.
25511 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25513 (VariableInfo.Number): New public field. This is used by flow analysis
25514 to number all locals of a block.
25515 (Block.CountVariables): New public property. This is the number of
25516 local variables in this block (including the locals from all parent
25518 (Block.EmitMeta): Number all the variables.
25520 * statement.cs: Added flow analysis support to all classes.
25522 2002-07-31 Martin Baulig <martin@gnome.org>
25524 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25525 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25526 then use this argument.
25528 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25530 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25531 use this to specify /define options.
25533 2002-07-29 Martin Baulig <martin@gnome.org>
25535 * statement.cs (Fixed): Moved all code that does variable lookups
25536 and resolvings from Emit to Resolve.
25538 * statement.cs (For): Moved all code that does variable lookups
25539 and resolvings from Emit to Resolve.
25541 * statement.cs (Using): Moved all code that does variable lookups
25542 and resolvings from Emit to Resolve.
25544 2002-07-29 Martin Baulig <martin@gnome.org>
25546 * attribute.cs (Attribute.Resolve): Explicitly catch a
25547 System.NullReferenceException when creating the
25548 CustromAttributeBuilder and report a different warning message.
25550 2002-07-29 Martin Baulig <martin@gnome.org>
25552 * support.cs (ParameterData.ParameterName): Added method to
25553 get the name of a parameter.
25555 * typemanager.cs (TypeManager.IsValueType): New public method.
25557 2002-07-29 Martin Baulig <martin@gnome.org>
25559 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25560 is a flag which specifies that it's either ref or out.
25561 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25562 the out parameter to `out Parameter.Modifier mod', also set the
25563 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25565 * support.cs (InternalParameters.ParameterModifier): Distinguish
25566 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25567 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25569 * expression.cs (Argument.GetParameterModifier): Distinguish
25570 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25571 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25573 2002-07-29 Martin Baulig <martin@gnome.org>
25575 * expression.cs (ParameterReference.ParameterReference): Added
25576 `Location loc' argument to the constructor.
25578 * cs-parser.jay: Pass location to ParameterReference.
25580 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25582 * statement.cs (Try): Initialize the location.
25584 * cs-parser.jay: pass location to Try.
25586 * expression.cs (Unary.Reduce): Change the prototype to return
25587 whether a constant fold could be performed or not. The result is
25588 returned in an out parameters. In the case of Indirection and
25589 AddressOf, we want to perform the full tests.
25591 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25593 * statement.cs (Statement.Emit): Flag dead code.
25595 2002-07-27 Andrew Birkett <andy@nobugs.org>
25597 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25599 2002-07-27 Martin Baulig <martin@gnome.org>
25601 * class.cs (MethodData.Define): Put back call to
25602 TypeManager.AddMethod(), accidentally commented this out.
25604 * report.cs (Debug): New public method to print debugging information,
25605 this is `[Conditional ("DEBUG")]'.
25607 2002-07-26 Martin Baulig <martin@gnome.org>
25609 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25610 (switch_statement): Push the current_block to the switch_stack and
25611 pop it again when we're done with the switch.
25612 (switch_section): The new block is a child of the current_block.
25613 Fixes bug #24007, added test-152.cs.
25615 2002-07-27 Martin Baulig <martin@gnome.org>
25617 * expression.cs (Invocation.EmitArguments): When calling a varargs
25618 function with only its fixed arguments, we need to pass an empty
25621 2002-07-27 Martin Baulig <martin@gnome.org>
25623 Mono 0.13 has been released.
25625 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25627 * driver.cs: Rename --resource to --linkres, because that is what
25628 we do currently, we dont support --resource yet.
25630 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25632 2002-07-25 Martin Baulig <martin@gnome.org>
25634 * class.cs (MethodData): New public class. This is a `method builder'
25635 class for a method or one accessor of a Property/Indexer/Event.
25636 (MethodData.GetMethodFlags): Moved here from MemberBase.
25637 (MethodData.ApplyAttributes): Likewise.
25638 (MethodData.ApplyObsoleteAttribute): Likewise.
25639 (MethodData.ApplyConditionalAttribute): Likewise.
25640 (MethodData.ApplyDllImportAttribute): Likewise.
25641 (MethodData.CheckAbstractAndExternal): Likewise.
25642 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25643 (MethodData.Emit): Formerly known as Method.Emit().
25644 (MemberBase): Moved everything which was specific to a single
25645 accessor/method to MethodData.
25646 (Method): Create a new MethodData and call Define() and Emit() on it.
25647 (Property, Indexer, Event): Create a new MethodData objects for each
25648 accessor and call Define() and Emit() on them.
25650 2002-07-25 Martin Baulig <martin@gnome.org>
25652 Made MethodCore derive from MemberBase to reuse the code from there.
25653 MemberBase now also checks for attributes.
25655 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25656 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25658 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25659 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25660 (MemberBase.ApplyAttributes): New virtual method; applies the
25661 attributes to a method or accessor.
25662 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25663 (MemberBase.ApplyConditionalAttribute): Likewise.
25664 (MemberBase.ApplyDllImportAttribute): Likewise.
25665 (MemberBase.CheckAbstractAndExternal): Likewise.
25666 (MethodCore.ParameterTypes): This is now a property instead of a
25667 method, it's initialized from DoDefineParameters().
25668 (MethodCore.ParameterInfo): Removed the set accessor.
25669 (MethodCore.DoDefineParameters): New protected virtual method to
25670 initialize ParameterTypes and ParameterInfo.
25671 (Method.GetReturnType): We can now simply return the MemberType.
25672 (Method.GetMethodFlags): Override the MemberBase version and add
25673 the conditional flags.
25674 (Method.CheckBase): Moved some code from Define() here, call
25675 DoDefineParameters() here.
25676 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25677 here to avoid some larger code duplication.
25678 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25679 ensure that abstract and external accessors don't declare a body.
25681 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25682 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25683 lookup in the attribute's parent classes, so we need to abort as soon
25684 as we found the first match.
25685 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25686 the attribute has no arguments.
25688 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25691 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25693 * cs-parser.jay: reverted previous patch.
25695 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25697 * cs-parser.jay: fixed bug #22119.
25699 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25701 * attribute.cs: fixed compilation. The error was:
25702 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25703 be assigned to before control leaves the current method."
25704 [FIXME: Filed as bug #28186: MCS must report this error.]
25706 2002-07-25 Martin Baulig <martin@gnome.org>
25708 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25709 method to pull the condition name ouf of a Conditional attribute.
25710 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25711 the obsolete message and error flag out of an Obsolete attribute.
25713 * class.cs (Method.GetMethodFlags): New public method to get the
25714 TypeManager.MethodFlags for this method.
25715 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25717 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25718 if we're overriding a virtual function, set the new private variable
25719 `parent_method'; call the new TypeManager.AddMethod().
25721 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25722 the MethodBuilder and the Method in a PtrHashtable.
25723 (TypeManager.builder_to_method): Added for this purpose.
25724 (TypeManager.MethodFlags): Added IsObsoleteError.
25725 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25726 Obsolete and Conditional arguments in MethodBuilders. If we discover
25727 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25728 the message from the attribute.
25730 2002-07-24 Martin Baulig <martin@gnome.org>
25732 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25733 preprocessor directives, ensure that the argument to #define/#undef is
25734 exactly one identifier and that it's actually an identifier.
25736 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25739 2002-07-24 Martin Baulig <martin@gnome.org>
25741 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25742 initialize it to TypeManager.object_type in the constructor.
25743 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25744 of the `hm.get_current' method if we're using the collection pattern.
25745 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25746 for the explicit conversion to make it work when we're using the collection
25747 pattern and the `Current' property has a different return type than `object'.
25750 2002-07-24 Martin Baulig <martin@gnome.org>
25752 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25753 does not match, but don't report any errors. This method is called in
25754 order for all methods in a MethodGroupExpr until a matching method is
25755 found, so we don't want to bail out if the first method doesn't match.
25756 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25757 matches, report the 123. Fixes #28070.
25759 2002-07-24 Martin Baulig <martin@gnome.org>
25761 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25762 TypeManager.TypeToCoreType() to the top of the method so the
25763 following equality checks will work. Fixes #28107.
25765 2002-07-24 Martin Baulig <martin@gnome.org>
25767 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25768 operand is of type uint, and the other operand is of type sbyte,
25769 short or int, the operands are converted to type long." -
25770 Actually do what this comment already told us. Fixes bug #28106,
25773 2002-07-24 Martin Baulig <martin@gnome.org>
25775 * class.cs (MethodBase): New abstract class. This is now a base
25776 class for Property, Indexer and Event to avoid some code duplication
25777 in their Define() and DefineMethods() methods.
25778 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25779 generic methods for Define() and DefineMethods().
25780 (FieldBase): Derive from MemberBase, not MemberCore.
25781 (Property): Derive from MemberBase, not MemberCore.
25782 (Property.DefineMethod): Moved all the code from this method to the
25783 new MethodBase.DefineAccessor(), just call it with appropriate
25785 (Property.Define): Call the new Property.DoDefine(), this does some
25786 sanity checks and we don't need to duplicate the code everywhere.
25787 (Event): Derive from MemberBase, not MemberCore.
25788 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25789 accessors, this will also make them work with interface events.
25790 (Indexer): Derive from MemberBase, not MemberCore.
25791 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25792 (Indexer.Define): Use the new MethodBase functions.
25794 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25795 argument to the constructor.
25796 (Interface.FindMembers): Added support for interface events.
25797 (Interface.PopluateEvent): Implemented.
25799 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25801 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25803 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25804 but this is required to check for a method name being the same as
25805 the containing class.
25809 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25811 * interface.cs: initialize variable.
25813 2002-07-23 Martin Baulig <martin@gnome.org>
25815 Implemented the IndexerName attribute in interfaces.
25817 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25818 name if this is an explicit interface implementation.
25819 (Indexer.InterfaceIndexerName): New public variable. If we're
25820 implementing an interface indexer, this is the IndexerName in that
25821 interface. Otherwise, it's the IndexerName.
25822 (Indexer.DefineMethod): If we're implementing interface indexer,
25823 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25824 and Pending.ImplementIndexer methods.
25825 (Indexer.Define): Also define the PropertyBuilder if we're
25826 implementing an interface indexer and this is neither an explicit
25827 interface implementation nor do the IndexerName match the one in
25830 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25831 If a method is defined here, then we always need to create a proxy
25832 for it. This is used when implementing interface indexers.
25833 (Pending.IsInterfaceIndexer): New public method.
25834 (Pending.ImplementIndexer): New public method.
25835 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25836 This is used when implementing interface indexers to define a proxy
25838 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25839 define a proxy if necessary.
25841 * interface.cs (Interface.IndexerName): New public variable.
25842 (Interface.PopulateIndexer): Set the IndexerName.
25843 (Interface.DefineIndexers): New private method. Populate all the
25844 indexers and make sure their IndexerNames match.
25846 * typemanager.cs (IndexerPropertyName): Added support for interface
25849 2002-07-22 Martin Baulig <martin@gnome.org>
25851 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25852 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25853 ret if HasReturnLabel.
25854 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25857 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25858 and set the ec.LoopBeginTryCatchLevel.
25859 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25860 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25861 the current ec.TryCatchLevel, the branch goes out of an exception
25862 block. In this case, we need to use Leave and not Br.
25864 2002-07-22 Martin Baulig <martin@gnome.org>
25866 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25867 block unless the block does not always return or it is contained in
25868 another try { ... } catch { ... } block. Fixes bug #26506.
25869 Added verify-1.cs to the test suite.
25871 2002-07-22 Martin Baulig <martin@gnome.org>
25873 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25874 then we do not always return. Fixes bug #24985.
25876 2002-07-22 Martin Baulig <martin@gnome.org>
25878 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25879 lookup on a per-class level; ie. walk up the class hierarchy until we
25880 found at least one applicable method, then choose the best among them.
25881 Fixes bug #24463 and test-29.cs.
25883 2002-07-22 Martin Baulig <martin@gnome.org>
25885 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25886 return types of the methods. The return type is not part of the
25887 signature and we must not check it to make the `new' modifier work.
25888 Fixes bug #27999, also added test-147.cs.
25889 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25891 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25892 on the method's return type.
25894 2002-07-21 Martin Baulig <martin@gnome.org>
25896 * assign.cs: Make this work if the rightmost source is a constant and
25897 we need to do an implicit type conversion. Also adding a few more tests
25898 to test-38.cs which should have caught this.
25900 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25901 target in the makefile for this. The makefile.gnu is primarily intended
25902 for end-users who don't want to debug the compiler.
25904 2002-07-21 Martin Baulig <martin@gnome.org>
25906 * assign.cs: Improved the Assign class so it can now handle embedded
25907 assignments (X = Y = Z = something). As a side-effect this'll now also
25908 consume less local variables. test-38.cs now passes with MCS, added
25909 a few new test cases to that test.
25911 2002-07-20 Martin Baulig <martin@gnome.org>
25913 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25914 instructions. Fixes bug #27977, also added test-146.cs.
25916 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25918 * cs-tokenizer.cs: fixed getHex ().
25920 2002-07-19 Martin Baulig <martin@gnome.org>
25922 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25923 not Type.GetType() to lookup the array type. This is needed when
25924 we're constructing an array of a user-defined type.
25925 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25926 single-dimensional arrays, but also for single-dimensial arrays of
25929 2002-07-19 Martin Baulig <martin@gnome.org>
25931 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25932 this function is called, it's not allowed to share LocalBuilders
25933 among ILGenerators.
25935 2002-07-19 Martin Baulig <martin@gnome.org>
25937 * expression.cs (Argument.Resolve): Report an error 118 when trying
25938 to pass a type as argument.
25940 2002-07-18 Martin Baulig <martin@gnome.org>
25942 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25943 Conv_R_Un for the signed `long' type.
25945 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25947 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25948 `expr' for the temporary result, as that will fail if we do
25949 multiple resolves on the same expression.
25951 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25953 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25954 ec.TypeContainer for looking up aliases.
25956 * class.cs (TypeContainer): Remove LookupAlias from here.
25958 * decl.cs (DeclSpace); Move here.
25960 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25962 * class.cs (FindMembers): Only call filter if the constructor
25963 bulider is not null.
25965 Also handle delegates in `NestedTypes' now. Now we will perform
25966 type lookups using the standard resolution process. This also
25969 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25970 This uses Expressions (the limited kind that can be parsed by the
25971 tree) instead of strings.
25973 * expression.cs (ComposedCast.ToString): Implement, used to flag
25974 errors since now we have to render expressions.
25976 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25979 * ecore.cs (SimpleName.ToString): ditto.
25981 * cs-parser.jay: Instead of using strings to assemble types, use
25982 Expressions to assemble the type (using SimpleName, ComposedCast,
25983 MemberAccess). This should fix the type lookups in declarations,
25984 because we were using a different code path for this.
25986 * statement.cs (Block.Resolve): Continue processing statements
25987 even when there is an error.
25989 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25991 * class.cs (Event.Define): Also remove the `remove' method from
25992 the list of pending items.
25994 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25995 generate more compact code.
25997 2002-07-17 Martin Baulig <martin@gnome.org>
25999 * const.cs (Const.LookupConstantValue): Add support for constant
26000 `unchecked' and `checked' expressions.
26001 Also adding test case test-140.cs for this.
26003 2002-07-17 Martin Baulig <martin@gnome.org>
26005 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26006 check whether mi.ReturnType implements the IEnumerator interface; the
26007 `==' and the IsAssignableFrom() will fail in this situation.
26009 2002-07-16 Ravi Pratap <ravi@ximian.com>
26011 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26014 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26016 * expression.cs: fixed bug #27811.
26018 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26020 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26021 Molaro: when we are a ref, the value already contains a pointer
26022 value, do not take the address of it.
26024 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26025 * removed mb-parser.jay and mb-tokenizer.cs
26027 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26029 * expression.cs: check against the building corlib void type.
26031 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26033 * ecore.cs: fix for valuetype static readonly fields: when
26034 initializing them, we need their address, not the address of a copy.
26036 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26038 * typemanager.cs: register also enum_type in corlib.
26040 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26042 * class.cs: allow calling this (but not base) initializers in structs.
26044 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26046 * ecore.cs: make sure we compare against the building base types
26049 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26051 * typemanager.cs: fix TypeToCoreType() to handle void and object
26052 (corlib gets no more typerefs after this change).
26054 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26056 * expression.cs (ArrayCreation.EmitArrayArguments): use
26057 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26059 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26060 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26061 array indexes, the runtime actually forbids them.
26063 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26064 for array arguments here.
26066 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26067 instead of the default for ValueTypes.
26069 (New.DoEmit): Use IsValueType instead of
26070 IsSubclassOf (value_type)
26071 (New.DoResolve): ditto.
26072 (Invocation.EmitCall): ditto.
26074 * assign.cs (Assign): ditto.
26076 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26077 Statements *are* currently doing part of their resolution during
26080 Expressions do always resolve during resolve, but statements are
26081 only required to propagate resolution to their children.
26083 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26085 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26087 (LoadAssembly): Do not add the dll if it is already specified
26089 (MainDriver): Add the System directory to the link path at the end,
26090 after all the other -L arguments.
26092 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26093 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26094 ldelem.u1) and using the opposite for sbytes.
26096 This fixes Digger, and we can finally run it.
26098 * driver.cs (UnixParseOption): Move the option parsing here.
26099 (CSCParseOption): Implement CSC-like parsing of options.
26101 We now support both modes of operation, the old Unix way, and the
26102 new CSC-like way. This should help those who wanted to make cross
26103 platform makefiles.
26105 The only thing broken is that /r:, /reference: and /lib: are not
26106 implemented, because I want to make those have the same semantics
26107 as the CSC compiler has, and kill once and for all the confussion
26108 around this. Will be doing this tomorrow.
26110 * statement.cs (Unsafe.Resolve): The state is checked during
26111 resolve, not emit, so we have to set the flags for IsUnsfe here.
26113 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26115 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26116 not catch the Error_ObjectRefRequired in SimpleName (as it is
26117 possible to have a class/instance variable name that later gets
26118 deambiguated), we have to check this here.
26120 2002-07-10 Ravi Pratap <ravi@ximian.com>
26122 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26123 make static and put into Expression.
26125 (Event.Define): Register the private field of the event with the
26126 TypeManager so that GetFieldFromEvent can get at it.
26128 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26129 keep track of the private field associated with an event which
26132 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26135 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26137 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26139 * expression.cs (Binary.EmitBranchable): this routine emits the
26140 Binary expression in a branchable context. This basically means:
26141 we need to branch somewhere, not just get the value on the stack.
26143 This works together with Statement.EmitBoolExpression.
26145 * statement.cs (Statement.EmitBoolExpression): Use
26148 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26150 * statement.cs (For): Reduce the number of jumps in loops.
26152 (For): Implement loop inversion for the For statement.
26154 (Break): We can be breaking out of a Try/Catch controlled section
26155 (foreach might have an implicit try/catch clause), so we need to
26156 use Leave instead of Br.
26158 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26159 now). If the instace expression supports IMemoryLocation, we use
26160 the AddressOf method from the IMemoryLocation to extract the
26161 address instead of emitting the instance.
26163 This showed up with `This', as we were emitting the instance
26164 always (Emit) instead of the Address of This. Particularly
26165 interesting when This is a value type, as we dont want the Emit
26166 effect (which was to load the object).
26168 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26170 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26172 * statement.cs (Checked): Set the CheckedState during the resolve
26173 process too, as the ConvCast operations track the checked state on
26174 the resolve process, and not emit.
26176 * cs-parser.jay (namespace_member_declaration): Flag that we have
26177 found a declaration when we do. This is used to flag error 1529
26179 * driver.cs: Report ok when we display the help only.
26181 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26183 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26185 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26187 * cs-tokenizer.cs (define): We also have to track locally the
26188 defines. AllDefines is just used for the Conditional Attribute,
26189 but we also need the local defines for the current source code.
26191 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26193 * statement.cs (While, For, Do): These loops can exit through a
26194 Break statement, use this information to tell whether the
26195 statement is the last piece of code.
26197 (Break): Flag that we break.
26199 * codegen.cs (EmitContexts): New `Breaks' state variable.
26201 2002-07-03 Martin Baulig <martin@gnome.org>
26203 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26204 modifiers in method declarations in structs. Otherwise, you won't
26205 be able to override things like Object.Equals().
26207 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26209 * class.cs (Method, Property, Indexer): Do not allow the public
26210 modifier to be used in explicit interface implementations.
26212 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26213 override modifiers in method declarations in structs
26215 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26217 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26218 integer or real overflow, report an error
26220 2002-07-02 Martin Baulig <martin@gnome.org>
26222 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26223 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26224 to tell the runtime about our newly created System.Object and
26225 System.ValueType types.
26227 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26229 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26230 struct instead of Ldarg/Starg.
26232 2002-07-02 Martin Baulig <martin@gnome.org>
26234 * expression.cs (Indirection.Indirection): Call
26235 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26237 2002-07-02 Martin Baulig <martin@gnome.org>
26239 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26240 ValueType, call TypeManager.TypeToCoreType() on it.
26241 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26242 the OpCodes.Newarr argument.
26244 2002-07-02 Martin Baulig <martin@gnome.org>
26246 * expression.cs (Invocation.EmitCall): When compiling corlib,
26247 replace all calls to the system's System.Array type to calls to
26248 the newly created one.
26250 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26251 System.Array methods.
26252 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26253 from the system's System.Array type which must be replaced.
26255 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26257 * typemanager.cs: load unverifiable_code_ctor so we can build
26258 corlib using the correct type. Avoid using GetTypeCode() with
26260 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26261 TypeManager.object_type to allow building corlib.
26263 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26265 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26267 2002-07-01 Martin Baulig <martin@gnome.org>
26269 * class.cs: Make the last change actually work, we need to check
26270 whether `ifaces != null' to avoid a crash.
26272 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26274 * class.cs: when we build structs without fields that implement
26275 interfaces, we need to add the interfaces separately, since there is
26276 no API to both set the size and add the interfaces at type creation
26279 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26281 * expression.cs: the dimension arguments to the array constructors
26282 need to be converted if they are a long.
26284 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26286 * class.cs: don't emit ldarg.0 if there is no parent constructor
26287 (fixes showstopper for corlib).
26289 2002-06-29 Martin Baulig <martin@gnome.org>
26291 MCS now compiles corlib on GNU/Linux :-)
26293 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26294 ie. check for MethodImplOptions.InternalCall.
26296 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26297 and TypeManager.attribute_type are null, so we must explicitly check
26298 whether parent is not null to find out whether it's an attribute type.
26299 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26300 and SetBuilder, not only if the property is neither abstract nor external.
26301 This is necessary to set the MethodImplOptions on the accessor methods.
26302 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26303 SetBuilder, see Property.Emit().
26305 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26306 populate "System.Object", "System.ValueType" and "System.Attribute" since
26307 they've already been populated from BootCorlib_PopulateCoreTypes().
26309 2002-06-29 Martin Baulig <martin@gnome.org>
26311 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26312 is the NullLiteral, we also need to make sure that target_type is not
26315 2002-06-29 Martin Baulig <martin@gnome.org>
26317 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26318 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26319 before calling BootstrapCorlib_ResolveDelegate ().
26321 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26323 * statement.cs: fixed build-breaker. All tests passed ok.
26325 2002-06-27 Martin Baulig <martin@gnome.org>
26327 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26328 for System.Decimal when compiling corlib.
26330 2002-06-27 Martin Baulig <martin@gnome.org>
26332 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26333 switch blocks which contain nothing but a default clause.
26335 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26337 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26339 2002-06-27 Martin Baulig <martin@gnome.org>
26341 * ecore.cs (PropertyExpr.PropertyExpr): Call
26342 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26344 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26345 is already a TypeBuilder.
26347 2002-06-27 Martin Baulig <martin@gnome.org>
26349 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26350 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26351 the "from an array-type to System.Array" case. This makes it work
26352 when compiling corlib.
26354 2002-06-27 Martin Baulig <martin@gnome.org>
26356 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26357 non-static PropertyExpr, set its InstanceExpression. This makes
26358 the `ICollection.Count' property work in System/Array.cs.
26360 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26362 * driver.cs: Made error handling more consistent. Errors now
26363 tracked by Report class, so many methods which used to return int
26364 now return void. Main() now prints success/failure and
26365 errors/warnings message.
26367 Renamed '--probe' compiler argument to '--expect-error'. Removed
26368 the magic number return values (123 and 124). Now, if the
26369 expected error occurs, the compiler exits with success (exit value
26370 0). If the compilation completes without seeing that particular
26371 error, the compiler exits with failure (exit value 1). The
26372 makefile in mcs/errors has been changed to handle the new behaviour.
26374 * report.cs: Made 'expected error' number a property and renamed
26375 it from 'Probe' to 'ExpectedError'.
26377 * genericparser.cs: Removed error handling support, since it is
26378 now all done by Report class.
26380 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26381 class, so parse() no longer returns an int.
26383 * namespace.cs: Use Report.Error instead of GenericParser.error
26385 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26387 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26388 TypeContainer.AddOperator): At the front of the list put the
26389 explicit implementations, so they get resolved/defined first.
26391 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26393 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26394 interface type is implemented by this TypeContainer. Used during
26395 explicit interface implementation.
26397 (Property.Define, Indexer.Define, Method.Define): Validate that
26398 the given interface in the explicit implementation is one of the
26399 base classes for the containing type.
26401 Also if we are explicitly implementing an interface, but there is
26402 no match in the pending implementation table, report an error.
26404 (Property.Define): Only define the property if we are
26405 not explicitly implementing a property from an interface. Use the
26406 correct name also for those properties (the same CSC uses,
26407 although that is really not needed).
26409 (Property.Emit): Do not emit attributes for explicitly implemented
26410 properties, as there is no TypeBuilder.
26412 (Indexer.Emit): ditto.
26414 Hiding then means that we do not really *implement* a pending
26415 implementation, which makes code fail.
26417 2002-06-22 Martin Baulig <martin@gnome.org>
26419 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26420 the return value of Object.GetType(). [FIXME: we need to do this whenever
26421 we get a type back from the reflection library].
26423 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26425 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26427 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26429 * attribute.cs: Return null if we can not look up the type.
26431 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26432 the interface types found.
26434 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26435 interface types found.
26437 * typemanager.cs (GetInterfaces): Make this routine returns alll
26438 the interfaces and work around the lame differences between
26439 System.Type and System.Reflection.Emit.TypeBuilder in the results
26440 result for GetInterfaces.
26442 (ExpandInterfaces): Given an array of interface types, expand and
26443 eliminate repeated ocurrences of an interface. This expands in
26444 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26447 2002-06-21 Martin Baulig <martin@gnome.org>
26449 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26452 2002-06-21 Martin Baulig <martin@gnome.org>
26454 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26455 and called with one of the core types, return the corresponding typebuilder for
26458 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26461 2002-06-21 Martin Baulig <martin@gnome.org>
26463 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26464 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26465 (Expression.ConvertReferenceExplicit): Likewise.
26467 * expression.cs (ElementAccess.DoResolve): Likewise.
26468 (ElementAccess.DoResolveLValue): Likewise.
26470 2002-06-10 Martin Baulig <martin@gnome.org>
26472 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26473 add the "value" parameter to the parameter list.
26475 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26478 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26480 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26481 the argument to an int, uint, long or ulong, per the spec. Also
26482 catch negative constants in array creation.
26484 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26486 * class.cs: do not allow the same interface to appear twice in
26487 the definition list.
26489 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26491 * ecore.cs: don't use ldlen with System.Array.
26493 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26495 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26497 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26499 * modifiers.cs: produce correct field attributes for protected
26500 internal. Easy fix so miguel can work on ther harder stuff:-)
26502 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26504 * pending.cs: New file. Move the code from class.cs here.
26505 Support clearning the pending flag for all methods (when not doing
26506 explicit interface implementation).
26508 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26510 * rootcontext.cs: added a couple more types needed to bootstrap.
26512 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26514 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26515 constructor in the type, instead of any constructor in the type
26516 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26517 a bug in the Mono runtime when applying the params attribute).
26519 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26520 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26522 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26524 * expression.cs (Unary.ResolveOperator): Use TypeManager
26525 to resolve the type.
26527 2002-06-13 Ravi Pratap <ravi@ximian.com>
26529 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26532 * enum.cs (AddEnumMember): Add support to store the attributes associated
26533 with each member too.
26535 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26536 field builders too - this takes care of the enum member case.
26538 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26540 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26541 address-of operator on both value types and pointers.
26543 2002-06-10 Martin Baulig <martin@gnome.org>
26545 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26546 PropertyBuilder to the `property_builders' list.
26548 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26549 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26550 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26551 find any indexers which are inherited from an interface.
26553 2002-06-09 Martin Baulig <martin@gnome.org>
26555 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26556 the same type as the constant if necessary. There's also a test-130.cs
26559 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26561 * typemanager.cs (TypeManager.ChangeType): Previously known as
26562 Enum.ChangeEnumType().
26564 2002-06-09 Martin Baulig <martin@gnome.org>
26566 * expression.cs (Cast.TryReduce): Added support for consts.
26568 2002-06-08 Ravi Pratap <ravi@ximian.com>
26570 * class.cs (Accessor): Hold attributes information so we can pass
26573 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26574 Modify to pass in attributes attached to the methods.
26576 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26578 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26579 to handle the Accessor kind :-)
26581 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26583 2002-06-08 Martin Baulig <martin@gnome.org>
26585 * expression.cs (Unary.TryReduceNegative): Added support for
26588 2002-06-08 Martin Baulig <martin@gnome.org>
26590 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26591 name can't be found in the `defined_names' - the caller will do a
26592 MemberLookup in this case and thus find methods in System.Enum
26593 such as Enum.IsDefined().
26595 2002-06-08 Martin Baulig <martin@gnome.org>
26597 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26598 Convert.ChangeType() which works with TypeBuilder created types.
26599 (Enum.LookupEnumValue, Enum.Define): Use it here.
26601 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26602 `TypeBuilder.BaseType != null' check.
26603 (TypeContainer.FindMembers): Only lookup parent members if we
26604 actually have a parent.
26605 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26606 (ConstructorInitializer.Resolve): Likewise.
26608 * interface.cs (Interface.FindMembers): Added
26609 `TypeBuilder.BaseType != null' check.
26611 * rootcontext.cs (RootContext.ResolveCore): Added
26612 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26613 classes_second_stage.
26615 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26616 debug_type and trace_type when compiling with --nostdlib.
26618 2002-06-07 Martin Baulig <martin@gnome.org>
26620 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26621 (AddField): Set it to true when adding a non-static field.
26622 (DefineType): Use `have_nonstatic_fields' to find out whether we
26623 have non-static fields, not `Fields != null'.
26625 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26627 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26628 dereferencing a null on the static-field code path)
26630 2002-05-30 Martin Baulig <martin@gnome.org>
26632 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26633 to take command line arguments. Use reflection to call the new
26634 custom `Initialize' function on the symbol writer and pass it the
26635 command line arguments.
26637 * driver.cs (--debug-args): New command line argument to pass command
26638 line arguments to the symbol writer.
26640 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26642 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26643 the target type for indexers and properties. Thanks to Joe for
26646 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26648 * typemanager.cs (MethodFlags): returns the method flags
26649 (Obsolete/ShouldIgnore) that control warning emission and whether
26650 the invocation should be made, or ignored.
26652 * expression.cs (Invocation.Emit): Remove previous hack, we should
26653 not do this on matching a base type, we should do this based on an attribute
26655 Only emit calls to System.Diagnostics.Debug and
26656 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26657 on the command line.
26659 * rootcontext.cs: Global settings for tracing and debugging.
26661 * cs-tokenizer.cs (define): New utility function to track
26662 defines. Set the global settings for TRACE and DEBUG if found.
26664 2002-05-25 Ravi Pratap <ravi@ximian.com>
26666 * interface.cs (Populate*): Pass in the TypeContainer as well as
26667 the DeclSpace as parameters so that we can create EmitContexts and
26668 then use that to apply attributes etc.
26670 (PopulateMethod, PopulateEvent, PopulateProperty)
26671 (PopulateIndexer): Apply attributes everywhere.
26673 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26676 (ApplyAttributes): Update accordingly.
26678 We now apply interface attributes for all members too.
26680 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26682 * class.cs (Indexer.Define); Correctly check if we are explicit
26683 implementation (instead of checking the Name for a ".", we
26684 directly look up if the InterfaceType was specified).
26686 Delay the creation of the PropertyBuilder.
26688 Only create the PropertyBuilder if we are not an explicit
26689 interface implementation. This means that explicit interface
26690 implementation members do not participate in regular function
26691 lookups, and hence fixes another major ambiguity problem in
26692 overload resolution (that was the visible effect).
26694 (DefineMethod): Return whether we are doing an interface
26697 * typemanager.cs: Temporary hack until we get attributes in
26698 interfaces (Ravi is working on that) and we get IndexerName
26699 support in interfaces.
26701 * interface.cs: Register the indexers as properties.
26703 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26704 warning, I have verified that this is a bug in the .NET runtime
26705 (JavaScript suffers of the same problem).
26707 * typemanager.cs (MemberLookup): When looking up members for
26708 interfaces, the parent of an interface is the implicit
26709 System.Object (so we succeed in searches of Object methods in an
26710 interface method invocation. Example: IEnumerable x; x.ToString
26713 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26715 * class.cs (Event): Events should also register if they do
26716 implement the methods that an interface requires.
26718 * typemanager.cs (MemberLookup); use the new GetInterfaces
26721 (GetInterfaces): The code used to lookup interfaces for a type is
26722 used in more than one place, factor it here.
26724 * driver.cs: Track the errors at the bottom of the file, we kept
26727 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26728 instance if the method we are calling is static!
26730 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26732 * attribute.cs (ApplyAttributes): Make this function filter out
26733 the IndexerName attribute (as that attribute in reality is never
26734 applied) and return the string constant for the IndexerName
26737 * class.cs (TypeContainer.Emit): Validate that all the indexers
26738 have the same IndexerName attribute, and if so, set the
26739 DefaultName attribute on the class.
26741 * typemanager.cs: The return value might contain other stuff (not
26742 only methods). For instance, consider a method with an "Item"
26743 property and an Item method.
26745 * class.cs: If there is a problem with the parameter types,
26748 2002-05-24 Ravi Pratap <ravi@ximian.com>
26750 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26751 looks at user defined conversion after making a call to
26752 StandardConversionExists - we need this for overload resolution.
26754 * expression.cs : Update accordingly the various method calls.
26756 This fixes 2 bugs filed against implicit user defined conversions
26758 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26760 * statement.cs: Track the result of the assignment.
26762 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26764 * expression.cs (MemberAccess): Improved error reporting for
26765 inaccessible members.
26767 2002-05-22 Martin Baulig <martin@gnome.org>
26769 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26770 itself with debugging support.
26772 2002-05-22 Martin Baulig <martin@gnome.org>
26774 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26775 Removed, this isn't needed anymore.
26777 2002-05-20 Martin Baulig <martin@gnome.org>
26779 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26780 be underlying type for an enum.
26782 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26784 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26785 that splits out the loading of just the core types.
26787 * rootcontext.cs (ResolveCore): Split the struct resolution in
26788 two, so we can load the enumeration underlying types before any
26791 * expression.cs (Is): Bandaid until we fix properly Switch (see
26792 bug #24985 for details).
26794 * typemanager.cs (ImplementsInterface): The hashtable will contain
26795 a null if there are no interfaces implemented.
26797 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26799 * cs-parser.jay (indexer_declarator): It is fine to have array
26802 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26804 * typemanager.cs: (RegisterBuilder): New function used to register
26805 TypeBuilders that implement interfaces. Since
26806 TypeBuilder.GetInterfaces (as usual) does not work with lame
26808 (AddUserType): register interfaces.
26810 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26811 dealing with TypeBuilder. Also, arrays are showing up as
26812 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26813 methods can not be invoked on them!
26815 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26816 (ImplicitReferenceConversionExists): Split out from
26817 StandardConversionExists.
26819 * expression.cs (As): We were only implementing one of the three
26820 cases for the as operator. We now implement them all.
26821 (Is): Implement the various other cases for Is as well.
26823 * typemanager.cs (CACHE): New define used to control if we want or
26824 not the FindMembers cache. Seems to have a negative impact on
26825 performance currently
26827 (MemberLookup): Nested types have full acess to
26828 enclosing type members
26830 Remove code that coped with instance/static returns for events, we
26831 now catch this in RealFindMembers.
26833 (RealFindMembers): only perform static lookup if the instance
26834 lookup did not return a type or an event.
26836 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26838 * assign.cs (CompoundAssign): We pass more semantic information
26839 now to Compound Assignments than we did before: now we have all
26840 the information at hand, and now we resolve the target *before* we
26841 do the expression expansion, which allows the "CacheValue" method
26842 to have the effect we intended (before, a [x] += 1 would generate
26843 two differen ArrayAccess expressions from the ElementAccess,
26844 during the resolution process).
26846 (CompoundAssign.DoResolve): Resolve target and original_source here.
26848 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26850 * expression.cs (ArrayAccess): dropped debugging information.
26852 * typemanager.cs: Small bug fix: I was always returning i_members,
26853 instead of one of i_members or s_members (depending on which had
26856 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26857 method is invoked before any code generation takes place, and it
26858 is a mechanism to inform that the expression will be invoked more
26859 than once, and that the method should use temporary values to
26860 avoid having side effects
26862 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26864 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26867 * expression.cs (Indirection, ArrayAccess): Add support for
26868 CacheTemporaries in these two bad boys.
26870 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26871 ldobj or ldind_ref.
26872 (StoreFromPtr): Handle stobj as well.
26874 * expression.cs (UnaryMutator): Share more code.
26876 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26877 down: I was not tracking the Filter function as well, which
26878 was affecting the results of the cache.
26880 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26882 * attribute.cs: Remove the hack to handle the CharSet property on
26885 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26887 * attribute.cs (DoResolve): More uglyness, we now only try to
26888 resolve the attribute partially, to extract the CharSet
26889 information (only if we are a StructLayout attribute). Otherwise
26891 (GetExtraTypeInfo): Add some code to conditionally kill in the
26892 future this. I am more and more convinced that the .NET
26893 framework has special code to handle the attribute setting on
26896 * expression.cs (IsParamsMethodApplicable): Revert my previous
26897 foreach change here, it was wrong.
26899 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26901 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26902 (pp_expr): do not abort on unknown input, just return.
26903 (eval): abort if there are pending chars.
26905 * attribute.cs (Attribute.Resolve): Positional parameters are
26906 optional. Deal with that case.
26908 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26909 the Ansi/Unicode/Auto information for the type.
26911 (TypeContainer.DefineType): instantiate the EmitContext here, as
26912 we will be using it during the type definition (to resolve
26913 attributes) and during the emit phase.
26915 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26916 to pull type information out of the attributes
26918 (Attribute.Resolve): track the constructor builder, and allow for
26919 multiple invocations (structs and classes will use this).
26921 * ecore.cs (MemberLookupFinal): new version with all the
26922 parameters customizable.
26924 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26925 constructors. Return if the result value is null (as the error
26926 would have been flagged already by MemberLookupFinal)
26928 Do not allow instances of abstract classes or interfaces to be
26931 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26932 We have to compare the assembly property here when dealing with
26933 FamANDAssem and Assembly access modifiers, because we might be
26934 creating an assembly from *modules* (that means that we are not
26935 getting TypeBuilders for types defined in other modules that are
26936 part of this assembly).
26938 (Method.Emit): If the method is marked abstract and has a body,
26941 (TypeContainer.DefineMembers): If both the defined member and the
26942 parent name match are methods, then do not emit any warnings: let
26943 the Method.Define routine take care of flagging warnings. But if
26944 there is a mismatch (method overrides something else, or method is
26945 overriwritten by something, then emit warning).
26947 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26948 set to null, this means `do not check for the return type on the
26951 (Method.Define): set the return type for the method signature to
26952 null, so that we get methods with the same name and parameters and
26953 different return types. This is used to flag warning 114 (you are
26954 hiding a method, and you probably want to use the new/override
26957 * typemanager.cs (MemberLookup): Implemented proper access
26958 control, closing a long standing set of bug reports. The problem
26959 was that the Framework only has two bits: Public and NonPublic,
26960 and NonPublic includes private and protected methods, but we need
26961 to enforce the FamANDAssem, FamOrAssem and Family.
26963 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26965 * statement.cs (GotoCase): Return true: Ammounts to giving up
26966 knowledge on whether we return or not, and letting the other case
26967 be responsible for it.
26969 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26971 * driver.cs: Do not load directories for each file processed, only
26972 do it if there is a pattern.
26974 * ecore.cs: Report readonly assigns here as well, as we might have
26975 been resolved only by MemberAccess.
26977 (SimpleName.SimpleNameResolve): Also be useful for LValue
26978 resolution. We need this to propagate assign to local readonly variables
26980 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26981 do not want to reuse potential criteria memory.
26983 * class.cs (MyEventBuilder): Set reflected_type;
26985 * ecore.cs (Constantify): Added support for constifying bools.
26987 (RootContext.LookupType): Added a cache for values looked up in
26988 the declaration space.
26990 * typemanager.cs (FindMembers): Now is a front-end to
26991 RealFindMembers, and provides a two-level hashtable-based cache to
26994 15% performance improvement: from 22.5 to 19.2 seconds.
26996 * expression.cs (IsParamsMethodApplicable): use foreach.
26997 (Invocation.DoResolve): ditto.
26998 (New.DoResolve): ditto.
26999 (ArrayCreation.DoResolve): ditto.
27001 * ecore.cs (FindMostEncompassingType): use foreach.
27003 * delegate.cs (NewDelegate.DoResolve): Use foreach
27005 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27006 (RemoveMethods): use foreach.
27008 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27009 nested foreach statements instead of for, and also break out of
27010 the inner loop once a match is found.
27012 (Invocation.OverloadResolve): Use foreach, simplify the code.
27014 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27016 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27017 we actually unwrap the expression to allow for extra information
27020 * expression.cs: Use Shr_Un on unsigned operations.
27022 2002-05-08 Ravi Pratap <ravi@ximian.com>
27024 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27025 applicable operators was not being considered correctly. This closes
27026 the bug Miguel reported.
27028 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27030 * attribute.cs: check that the type derives from System.Attribute
27031 and report the correct error in that case (moved the duplicate code to
27032 its own method, too).
27034 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27036 * attribute.cs: lookup attribute type name as the spec says: first the
27037 bare attribute name and then name + "Attribute" (nant compiles with
27038 mcs after this fix).
27040 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27042 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27043 Because of the way we parse things, we should try to see if a
27044 UIntConstant can fit in an integer.
27046 2002-05-07 Ravi Pratap <ravi@ximian.com>
27048 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27049 when we are in an explicit context.
27051 (ConvertReferenceExplicit): When converting from Iface type S to Class
27052 T make sure the rules are implemented as an OR.
27054 * parameter.cs (ParameterType): Make it a property for now although the
27055 purpose really isn't anything immediate.
27057 * expression.cs (Is*Applicable): Do better checking on the parameter type
27058 of a ref/out parameter. The ones from the system assemblies are already
27059 marked with the correct type so we don't need to do any correction.
27061 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27062 the object type is standard too so include that.
27064 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27066 * ecore.cs (StandardConversionExists): Augment with missing code:
27067 deal with IntConstant, LongConstants and Enumerations.
27069 * assign.cs: Report the error, instead of failing silently
27071 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27072 typecontainer that they are declared, because the
27073 typecontainer/namespace will have the list of using clauses that
27074 need to be applied.
27076 Assembly Attributes were escaping the normal registration
27079 (EmitCode): Apply attributes within an EmitContext that represents
27080 the container they were declared on.
27082 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27084 2002-05-06 Ravi Pratap <ravi@ximian.com>
27086 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27087 Revamp completely - make much cleaner as we now operate only
27090 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27091 to implement the logic detailed in the spec more correctly.
27093 (UserDefinedConversion): Update accordingly.
27095 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27097 * statement.cs: Return flow analysis information up.
27099 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27102 (token): Do not consume an extra character before calling
27105 2002-05-06 Piers Haken <piersh@friskit.com>
27107 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27109 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27111 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27112 EmitContext during the instance constructor initializer
27113 resolution, to stop access to instance variables.
27115 This is mandated by the spec, last paragraph of the `constructor
27116 initializers' section.
27118 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27120 * cs-parser.jay, class.cs (Accessor): new class used to represent
27121 an accessor (get or set). In the past we used `null' to represent
27122 a missing accessor. But this is ambiguous because there was no
27123 way to tell in abstract indexers/properties if one of them was
27126 Now there is a way of addressing that.
27128 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27129 instead of FindMembers.
27131 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27132 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27134 * attribute.cs: Treat indexers and properties as the same in terms
27135 of applying attributes
27137 * ecore.cs (FindMostEncompassedType): Use statically initialized
27138 EmptyExpressions()s like we do elsewhere to avoid creating useless
27139 objects (and we take this out of the tight loop).
27141 (GetConversionOperators): Move the code to extract the actual
27142 operators to a separate routine to clean things up.
27144 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27146 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27147 events are always registered FieldBuilders.
27149 * class.cs (FieldBase): New class shared by Fields
27151 * delegate.cs: If we are a toplevel delegate, use our full name.
27152 If we are a nested delegate, then only use our tail name.
27154 2002-05-02 Ravi Pratap <ravi@ximian.com>
27156 * expression.cs (IsApplicable): Ensure that we add the "&" to
27157 ref/out types before comparing it with the type of the argument.
27159 (IsParamsMethodApplicable): Ditto.
27161 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27164 * delegate.cs : Handle the case when we have more than one applicable
27165 method. Flag an error only when we finish checking all.
27167 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27169 * expression.cs: Add support for boolean static initializers.
27171 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27173 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27175 * parameter.cs (ComputeParameterTypes,
27176 ComputeAndDefineParameterTypes): Better error handling: now we
27177 clear the `types' cache if we fail during any of the type lookups.
27178 We also return the status code correctly to our caller
27180 * delegate.cs: If we fail to define a delegate, abort the extra
27183 * expression.cs (Binary.ResolveOperator): for
27184 operator==(object,object) and operator !=(object, object) we also
27185 have to verify that there is an implicit conversion from one to
27188 (ArrayAccess.DoResolve): Array Access can operate on
27191 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27193 * assign.cs (CompoundAssign): A new class used as a "flag" that
27194 the assignment actually is happening as part of a compound
27195 assignment operator.
27197 During compound assignment, a few new rules exist to enable things
27204 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27205 to the type of x) if y is implicitly convertible to the type of x,
27206 and the operator is a builtin operator and the return type of the
27207 operator is explicitly convertible to the type of x.
27209 * rootcontext.cs: Reset warning level to 2. 4 catches various
27210 "interesting" features in mcs, we must clean this up at some
27211 point, but currently am trying to kill other bugs ;-)
27213 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27214 in container classes as well.
27216 * expression.cs (Binary.ResolveOperator): Handle string case
27217 before anything else (as operator overloading does emit an error
27218 before doing anything else).
27220 This code could go away when we move to a table driven model, but
27221 i could not come up with a good plan last night.
27223 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27225 * typemanager.cs (CSharpName): reimplementation using regex.
27226 * class.cs: added null check for fields in Emit
27227 * rootcontext.cs: set warninglevel to 4
27229 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27231 * typemanager.cs (CSharpName): reimplemented with Lupus
27234 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27236 * statement.cs (If): correclty implement Resolve, because we were
27237 not catching sem errors in there. The same process is needed
27239 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27242 (Statement.Warning_DeadCodeFound): Factorize code.
27243 (While): Report dead code here too.
27245 (Statement): Added Resolve virtual method to allow
27246 for resolution split from the emit code.
27248 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27250 * statement.cs (EmitBoolExpression): No longer try to resolve the
27252 (MakeBoolean): New utility function that resolve, implicitly
27253 converts to boolean and tags the expression.
27256 (If, Do): Implement dead code elimination.
27257 (While): Implement loop inversion
27259 (Do, While, For, If): Resolve the expression prior to calling our
27262 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27265 - added method Report28 (warning: program has more than one entry point)
27266 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27267 - modified method Method.Define, the part at the end of the method
27269 * rootcontext.cs: added static public Location EntryPointLocation;
27271 * ../errors/cs0028.cs : Add test case for the above warning.
27274 - modified method CSharpName to allow arrays of primitive type to
27275 be printed nicely (e.g. instead of System.Int32[][] it now prints
27277 - added method CSharpSignature: returns the signature of a method
27278 in string format to be used in reporting errors, warnings, etc.
27280 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27283 2002-04-26 Ravi Pratap <ravi@ximian.com>
27285 * delegate.cs (Define): Fix extremely silly bug where I was
27286 setting the type of the 'object' parameter of the BeginInvoke
27287 method to System.IAsyncResult instead of System.Object ;-)
27289 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27291 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27294 (Constructor.Emit): return if we fail to initialize the
27295 constructor. Another door closed!
27297 * expression.cs (New.DoResolve): Improve error message (from -6 to
27298 1501). Use DeclaredOnly lookup to find the exact constructor.
27300 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27301 loop. This is useful.
27303 * cs-parser.jay: Adjust the default parameters so that destructors
27304 have the proper signature.
27306 2002-04-26 Martin Baulig <martin@gnome.org>
27308 * driver.cs (LoadAssembly): If `assembly' contains any characters
27309 which are only valid in path names and not in assembly names
27310 (currently slash, backslash and point), use Assembly.LoadFrom ()
27311 instead of Assembly.Load () on the `assembly' (before iteration
27312 over the link_paths).
27314 2002-04-26 Martin Baulig <martin@gnome.org>
27316 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27318 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27320 * class.cs (Property): use the new typemanager.MemberLookup
27322 (TypeContainer.MemberLookup): Implement using the
27323 TypeManager.MemberLookup now.
27325 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27326 and return MemberInfos, so that these can be used without an
27327 EmitContext (what we had before).
27329 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27331 * expression.cs: Fix the case where the argument to params if the
27332 type of the params. I omitted handling this before. Fixed
27334 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27336 * driver.cs: Call BootCorlib_PopulateCoreType
27338 * class.cs (Property.CheckBase): Check for properties only, not
27341 * interface.cs: Temporary hack: try/catch around the
27342 CustomAttributeBuilder, because I am getting an exception that I
27345 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27346 types whose definitions are required to be there (attributes are
27347 defined before standard types).
27349 Compute definitions as we boot the various types, as they are used
27350 immediately (value_type class will need object_type, but if we do
27351 not initialize object_type, we will pass a null, which will let
27352 the runtime pick the System.Object from the existing corlib, which
27353 is not what we want).
27355 2002-04-22 Patrik Torstensson <totte@labs2.com>
27357 * cs-tokenizer.cs: fixed a number of trim() issues.
27359 2002-04-22 Ravi Pratap <ravi@ximian.com>
27361 * expression.cs (Argument.Type): Ensure that we return the correct
27362 type when we have out or ref parameters [in which case we
27365 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27367 * class.cs (Property, Indexer): Allow extern modifier in there.
27369 * typemanager.cs (InitBaseTypes): Initializes object_type and
27370 value_type, since those will be used early on during the bootstrap
27371 process to compile corlib.
27373 (InitCoreTypes): Move code from here to InitBaseTypes.
27375 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27377 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27378 single-dimension arrays as using the ldlen opcode.
27380 Daniel Lewis discovered this optimization.
27382 * typemanager.cs: Add signature for System.Array::get_Length
27384 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27386 * statement.cs: report the error when the foreach does not apply to an
27387 array nor a collection.
27389 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27391 * expression.cs: Add implicit conversions to the operator ~.
27393 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27395 * typemanager.cs: Locate the decimal constructor.
27397 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27399 * attribute.cs: use the new property of TypeOf.
27400 * expression.cs: added 'get' property around typearg.
27402 These changes fix a build breaker reported by NickD. Is this the
27403 correct way to fix? If not, please, revert my changes and make it
27406 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27408 * attribute.cs: Add support for typeof in attribute invocations.
27409 I am not sure that this is right though.
27411 2002-04-14 Duncan Mak <duncan@ximian.com>
27413 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27414 Binary.Operator.Division case.
27416 2002-04-13 Ravi Pratap <ravi@ximian.com>
27418 * class.cs (DefineType): Ensure that we do a proper check on
27419 attribute types and also register it with the TypeManager.
27421 (TypeContainer.Targets): The default for attribute types is
27422 AttributeTargets.All.
27424 * attribute.cs (ApplyAttributes): Registering the attribute type
27425 is done elsewhere, not when we discover we have a Usage attribute.
27427 2002-04-12 Ravi Pratap <ravi@ximian.com>
27429 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27430 and get rid of is_delegate parameter.
27432 * everywhere : update.
27434 2002-04-12 Ravi Pratap <ravi@ximian.com>
27436 * cs-parser.jay (compilation_unit): Revamp completely to use
27437 some new ideas that I got from Rhys' grammar to solve the problems
27438 with assembly level attributes.
27440 (outer_declaration): New grammar production.
27442 (attribute_sections): Add.
27444 (opt_attributes): Base on attribute_sections
27446 (namespace_declaration): Allow opt_attributes to tackle the case
27447 when we have assembly level attributes - we are clever in this
27450 * attribute.cs (ApplyAttributes): Do not worry about assembly
27451 attributes in the non-global context.
27453 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27454 instead of SetGlobalAttributes.
27456 * class.cs, rootcontext.cs : Ensure we define and generate
27457 attribute types before anything else.
27459 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27460 and flag the new error -20 for the case when the attribute type
27461 does not have valid targets specified. csc does not catch this.
27463 * ../errors/errors.txt : update for error # -20
27465 2002-04-11 Ravi Pratap <ravi@ximian.com>
27467 * support.cs (InternalParameters.ParameterModifier): Do some null
27468 checking and return sane values.
27470 * class.cs (Method.Define): If we are a PInvoke method, ensure
27471 that we are static and extern. Report error # 601
27473 * ../errors/cs0601.cs : Add test case for the above error.
27475 2002-04-07 Ravi Pratap <ravi@ximian.com>
27477 * rootcontext.cs (attribute_types): We need to keep type of
27478 all attribute types separately and emit code for them first.
27480 (RegisterAttribute) : Implement.
27482 * class.cs (DefineType): Check if the current Type is a custom
27483 attribute type and register it accordingly.
27485 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27486 adding the first attribute twice and rename to
27488 (SetGlobalAttributes): this.
27490 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27493 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27494 if we are processing global arguments. Hmm, I am unsure of this.
27496 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27498 * expression.cs: added static array of strings to avoid calling
27499 Enum.ToString () for Operator in Binary. Significant recover of
27502 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27504 * class.cs (FindMembers): Allow the Builders of the various
27505 members to be null. If they are skip them. This only happens
27506 during the PInvoke declaration.
27508 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27510 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27511 failure, so we do not keep going afterwards.
27513 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27514 wanted to pass `false' as the `is_delegate' argument. If this is
27515 the case, why not use delegate_type == null to mean `is_delegate =
27516 false' and anything else as is_delegate = true.
27518 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27520 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27521 code for the section, not the beginning of the tests.
27523 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27525 * cfold.cs: Handle operator + (Enum x, Underlying x)
27527 * expression.cs (Binary): same. Warn about errors where we have
27528 Enum/Enum in operator + as well.
27530 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27533 - added support for switch(bool)
27534 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27535 - add TableSwitchEmit() to handle table-based switch statements
27537 2002-04-05 Ravi Pratap <ravi@ximian.com>
27539 * expression.cs (Invocation.OverloadResolve): Factor out code which
27540 does parameter compatibility checking with arguments so that we can
27541 re-use the code even from Delegate.VerifyApplicability
27543 (VerifyArgumentsCompat): Move above code here.
27545 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27546 and instead make a call to the above method.
27548 2002-03-31 Ravi Pratap <ravi@ximian.com>
27550 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27551 We use it to keep track of classes which are attribute types.
27553 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27555 * delegate.cs (Delegate.Define): Correctly define the types in the
27556 presence of fixed and array parameters.
27558 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27561 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27562 include NonPublic after the first iteration.
27564 * class.cs (Indexer.CheckBase): Only check if both parents are
27567 * cs-parser.jay (accessor_body): If empty, set to null.
27569 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27570 same code path here to resolve constants names that we did have in
27571 MemberAccess.DoResolve. There is too much code duplicated here.
27573 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27575 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27577 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27580 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27581 tokens, numbers and strings.
27583 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27586 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27587 asyncronous parameters and the regular parameters.
27589 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27590 specify the target directory.
27592 * expression.cs: (This.DoResolve): Simplify
27593 (As.Emit): Optimize, do not generate IsInst if the expression is
27594 always of the given type.
27596 (Is.DoResolve): Bug fix, we were reporting both always/never for
27599 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27600 creating too many unnecessary arrays.
27602 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27604 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27605 fields instead of rolling our own initializer. Takes care of all
27606 implicit conversions, and drops unnecessary static checks/argument.
27608 2002-03-31 Dick Porter <dick@ximian.com>
27610 * driver.cs: use the GetDirectories() return values properly, and
27611 use "/" as path separator.
27613 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27615 * expression.cs (Unary): Optimize - - expr into expr.
27616 (Binary): Optimize a + (-b) into a -b.
27618 * codegen.cs (CodeGen): Made all methods static.
27620 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27624 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27625 TypeBuilder property.
27627 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27630 * tree.cs: Removed the various RecordXXXX, and replaced with a
27631 single RecordDecl. Removed all the accessor methods, and just
27632 left a single access point Type
27634 * enum.cs: Rename DefineEnum to DefineType.
27636 * decl.cs: New abstract method `DefineType' used to unify the
27637 Defines for Enumerations, Interfaces, TypeContainers and
27640 (FindType): Moved LookupInterfaceOrClass here. Moved the
27641 LookupBaseClasses method that used to live in class.cs and
27642 interface.cs here, and renamed to FindType.
27644 * delegate.cs: Implement DefineType. Take advantage of the
27645 refactored pattern for locating the parent builder without taking
27646 the parent_builder argument (which we know does not work if we are
27647 nested, and triggering a toplevel definition).
27649 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27651 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27652 accessibility of a member has changed during override and report
27655 * class.cs (Method.Define, Property.Define): Only complain on
27656 overrides if the method is private, any other accessibility is
27657 fine (and since we just checked the permission is the same, we are
27660 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27661 and elif are processed always. The other pre-processing
27662 directives are only processed if we are "taking" the path
27664 2002-03-29 Martin Baulig <martin@gnome.org>
27666 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27667 current location is not Null.
27669 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27670 a separate method so we can profile it.
27672 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27673 `span.Seconds' are just seconds, but no minutes or hours.
27674 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27676 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27678 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27679 Remove the gratuitous set of Final:
27681 // If an interface implementation, then we can set Final.
27682 if (((flags & MethodAttributes.Abstract) == 0) &&
27683 implementing.DeclaringType.IsInterface)
27684 flags |= MethodAttributes.Final;
27686 I do not know what I was smoking when I used that.
27689 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27690 step into fixing the name resolution issues for delegates and
27691 unifying the toplevel name resolution.
27693 2002-03-28 Martin Baulig <martin@gnome.org>
27695 * class.cs (Method.Emit): If we have a symbol writer, call its
27696 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27697 tell it about the current method.
27699 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27700 writer that we're going to emit the first byte of IL code for a new
27701 statement (a new source line).
27702 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27703 EmitContext.Mark() before emitting any code.
27705 * location.cs (SymbolDocument): Return null when we're Null.
27707 * statement.cs (Statement): Moved the `Location loc' variable here.
27708 (Statement.EmitBoolExpression): If we have a symbol writer, call
27709 ec.Mark() before emitting any code to tell it that we're at the
27710 beginning of a new statement.
27711 (StatementExpression): Added `Location' argument to the constructor.
27712 (Block): Added public readonly variable `StartLocation' and public
27713 variable `EndLocation'. The latter is to be set using SetEndLocation().
27714 (Block): Added constructor which takes a start and end location.
27715 (Block.SetEndLocation): New method. This sets the end location.
27716 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27717 local variables we create.
27718 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27719 each statement and do also mark the begin and end of the block.
27721 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27722 tell it the current lexer.Location, use Location.Null for the end of the
27724 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27725 current block, set its end location using SetEndLocation().
27726 (statement_expression): StatementExpression constructor now takes the
27727 lexer.Location as additional argument.
27728 (for_statement, declare_local_variables): Likewise.
27729 (declare_local_variables): When creating a new implicit block, use the
27730 new Block constructor and pass it the lexer.Location.
27732 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27734 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27735 members also on the parent interfaces recursively.
27737 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27739 * report.cs: Use new formats, since Gonzalo finished the missing
27742 * expression.cs (Binary.ResolveOperator): added missing operator|
27743 operator& and operator^ for bool/bool.
27745 * cs-parser.jay: CheckDef now takes a Location argument that is
27746 used to report errors more precisly (instead of reporting the end
27747 of a definition, we try to track something which is a lot closer
27748 to the source of the problem).
27750 * cs-tokenizer.cs: Track global token use, so we can properly flag
27751 the use of #define/#undef after the first token has been seen.
27753 Also, rename the reportXXXX to Error_DescriptiveName
27755 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27756 TypeContainer, so that Enum and Interface can use this too.
27758 * class.cs (TypeContainer.LookupInterfaceOrClass,
27759 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27760 `builder' argument. Typically this was used to pass the parent
27761 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27764 The problem is that a nested class could trigger the definition of
27765 a toplevel class, and the builder would be obviously wrong in that
27768 So we drop this argument, and we compute dynamically the
27769 TypeBuilder/ModuleBuilder (the correct information was available
27770 to us anyways from DeclSpace.Parent)
27772 * interface.cs (Interface.DefineInterface): Drop builder
27773 parameter cleanup like class.cs
27775 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27778 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27781 (Try.Emit): Propagate the returns value from the statement.
27783 (Return.Emit): Even if we are leavning
27785 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27787 * modifiers.cs: Fix the computation of MethodAttributes flags.
27789 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27791 * driver.cs: allow compilation of files that start with '/'.
27792 Add a default case when checking the argument of --target.
27794 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27796 * interface.cs: Implement the same search algorithm for types in
27797 the interface code.
27799 * delegate.cs: Do not allow multiple definition.
27801 * Recovered ChangeLog that got accidentally amputated
27803 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27805 * rootcontext.cs: Load manually enum to allow core classes to
27806 contain enumerations.
27808 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27809 Update to new static methods in TypeManager.
27811 * typemanager.cs (GetMethod, GetConstructor): Use our
27812 implementation of FindMembers to find the members, since during
27813 corlib compilation, the types are TypeBuilders and GetMethod and
27814 GetConstructor do not work.
27816 Make all methods in TypeManager static.
27818 (InitCodeHelpers): Split the functionality from
27819 the InitCodeTypes function.
27821 * driver.cs: Call InitCodeHelpers after we have populated the
27824 * cs-parser.jay (delegate_declaration): we did not used to compute
27825 the delegate name correctly for void delegates.
27827 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27829 * rootcontext.cs (RootContext): Init the interface_resolve_order
27830 and type_container_resolve_order always.
27832 (ResolveCore, BootstrapCorlib_ResolveClass,
27833 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27834 compiler when compiling with --nostdlib
27836 * class.cs (TypeContainer.DefineType): Check that our parent is
27837 not null. This test is most important when we are bootstraping
27840 * codegen.cs: Split out the symbol writing code.
27842 2002-03-25 Martin Baulig <martin@gnome.org>
27844 * driver.cs (-g): Made -g an alias for --debug.
27846 2002-03-24 Martin Baulig <martin@gnome.org>
27848 * codegen.cs (SymbolWriter): New public variable. Returns the
27849 current symbol writer.
27850 (CodeGen): Added `bool want_debugging_support' argument to the
27851 constructor. If true, tell the ModuleBuild that we want debugging
27852 support and ask it for the ISymbolWriter.
27853 (Save): If we have a symbol writer, call it's Close() method after
27854 saving the assembly.
27856 * driver.c (--debug): New command line argument to create a
27857 debugger information file.
27859 * location.cs (SymbolDocument): New public property. Returns an
27860 ISymbolDocumentWriter object for the current source file or null
27861 if we don't have a symbol writer.
27863 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27865 * driver.cs (LoadAssembly): Correctly return when all the paths
27866 have been tried and not before.
27868 * statement.cs (Switch.Emit): return the actual coverage for this
27869 statement (returns/not-returns)
27871 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27872 switch of the statement if we are the last switch section. That
27873 kills two problems: try/catch problems (we used to emit an empty
27874 nop at the end) and switch statements where all branches would
27877 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27879 * driver.cs: Add default assemblies (the equivalent to the
27880 Microsoft CSC.RSP file)
27882 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27883 also update tokens_seen and set it to false.
27885 * driver.cs: Implement --recurse for Mike.
27887 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27888 correctly splitting out the paths.
27890 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27892 * interface.cs (Interface.PopulateProperty): Instead of using
27893 `parent' as the declaration space for the set parameters, use
27896 * support.cs (InternalParameters): InternalParameters constructor
27897 takes a DeclSpace instead of a TypeContainer.
27899 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27900 types are being initialized, load the address of it before calling
27903 (New): Provide a mechanism to disable the generation of local
27904 value type temporaries when the caller will be providing us with
27905 an address to store it.
27907 (ArrayCreation.EmitDynamicInitializers): Use it.
27909 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27911 * expression.cs (Invocation.EmitArguments): Only probe for array
27912 property if there is more than one argument. Sorry about that.
27914 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27915 empty param arrays.
27917 * class.cs (Method.LabelParameters): Fix incorrect code path that
27918 prevented the `ParamArrayAttribute' from being applied to the
27921 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27923 * support.cs (ReflectionParameters): Correctly compute whether the
27924 last argument is a params array. Fixes the problem with
27927 * typemanager.cs: Make the assemblies array always be non-null
27928 (empty, but non-null)
27930 * tree.cs (RecordDecl): New function that abstracts the recording
27931 of names. This reports error 101, and provides a pointer to the
27932 previous declaration. Fixes a crash in the compiler.
27934 * cs-parser.jay (constructor_declaration): Update to new grammar,
27935 and provide a constructor_body that can be empty.
27937 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27939 * driver.cs: Add support for --resources.
27941 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27942 Make all types for the various array helper methods be integer.
27944 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27945 CheckState to ConvCast.
27947 (ConvCast): Now it takes a `checked' state argument, to avoid
27948 depending on the emit context for the conversion, and just using
27949 the resolve time setting.
27951 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27952 instead of Invocation.EmitArguments. We do not emit the original
27953 arguments, instead we emit those which have been converted to
27954 unsigned int expressions.
27956 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27958 * codegen.cs: ditto.
27960 * expression.cs (LocalVariableReference): Drop the use of the
27961 Store function that depended on the variable index.
27963 * statement.cs (VariableInfo): Drop the `Idx' property from this
27964 class, as this is not taking into account the indexes for
27965 temporaries tat we generate during the execution, getting the
27968 * class.cs: First emit class initializers, then call the parent
27971 * expression.cs (Binary): Fix opcode emision.
27972 (UnaryMutator.EmitCode): Support checked code generation
27974 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27975 matches for events for both the Static and Instance scans,
27976 pointing to the same element. Fix that.
27978 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27980 * rootcontext.cs (ResolveTree): Always set the
27981 interface_resolve_order, because nested interfaces will be calling
27984 * class.cs (GetInterfaceOrClass): Track the same resolution
27985 process used by TypeManager.LookupType. This fixes the nested
27986 type lookups in class declarations (separate path from
27989 (TypeContainer.DefineType): Also define nested interfaces.
27990 (TypeContainer.RegisterOrder): New public function used to
27991 register the order in which child interfaces need to be closed.
27993 Nested interfaces need to be closed after their parents have been
27996 * interface.cs (InterfaceAttr): Put all the logic for computing
27997 the interface attribute here.
27999 (DefineInterface): Register our interface order with the
28000 RootContext or with the TypeContainer depending on the case.
28002 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28004 * cs-parser.jay: rework foreach statement to work with the new
28005 changes to the policy on SimpleNames.
28007 * report.cs: support Stacktrace on warnings as well.
28009 * makefile: drop --unsafe and /unsafe from the compile.
28011 2002-03-13 Ravi Pratap <ravi@ximian.com>
28013 * ecore.cs (StandardConversionExists): Modify to take an Expression
28014 as the first parameter. Ensure we do null -> reference type conversion
28017 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28018 temporary Expression objects.
28020 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28022 * interface.cs: workaround bug in method overloading resolution
28023 (there is already a bugzilla bug for it).
28025 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28027 We could also solve this problem by having a separate path for
28028 performing type lookups, instead of DoResolve, we could have a
28029 ResolveType entry point, and only participating pieces of the
28030 production (simplename, deref, array) would implement this.
28032 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28033 signal SimpleName to only resolve type names and not attempt to
28034 resolve anything else.
28036 * expression.cs (Cast): Set the flag.
28038 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28040 * class.cs: Only report 108 if there is no `new' modifier.
28042 * cs-parser.jay: rework foreach statement to work with the new
28043 changes to the policy on SimpleNames.
28045 * report.cs: support Stacktrace on warnings as well.
28047 * makefile: drop --unsafe and /unsafe from the compile.
28049 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28051 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28052 lookups here, instead of doing that at parse time. This means
28053 that our grammar will not introduce `LocalVariableReferences' as
28054 expressions at this point. That solves the problem of code like
28058 static void Main ()
28062 This is only half the fix. The full fix requires parameters to
28063 also be handled in this way.
28065 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28066 makes the use more obvious of the DeclSpace. The
28067 ec.TypeContainer.TypeBuilder is now only used to pull the
28068 TypeBuilder for it.
28070 My theory is that I can get rid of the TypeBuilder completely from
28071 the EmitContext, and have typecasts where it is used (from
28072 DeclSpace to where it matters).
28074 The only pending problem is that the code that implements Aliases
28075 is on TypeContainer, and probably should go in DeclSpace.
28077 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28078 lookups here, instead of doing that at parse time. This means
28079 that our grammar will not introduce `LocalVariableReferences' as
28080 expressions at this point. That solves the problem of code like
28084 static void Main ()
28088 This is only half the fix. The full fix requires parameters to
28089 also be handled in this way.
28091 * class.cs (Property.DefineMethod): When implementing an interface
28092 method, set newslot, when implementing an abstract method, do not
28093 set the flag (before we tried never setting it, or always setting
28094 it, which is the difference).
28095 (Indexer.DefineMethod): same.
28096 (Method.DefineMethod): same.
28098 * ecore.cs: Only set the status used flag if we get back a Field.
28100 * attribute.cs: Temporary hack, so Paolo can keep working.
28102 2002-03-08 Ravi Pratap <ravi@ximian.com>
28104 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28105 the unmanaged type in the case we have a MarshalAs attribute.
28107 (Resolve): Handle the case when we are parsing the special MarshalAs
28108 attribute [we need to store the unmanaged type to use later]
28110 * typemanager.cs (marshal_as_attr_type): Built in type for the
28111 MarshalAs Attribute.
28113 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28114 on parameters and accordingly set the marshalling info.
28116 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28118 * class.cs: Optimizing slightly by removing redundant code after
28119 we switched to the `NoTypes' return value.
28120 (Property.DefineMethod): use NoTypes here too.
28122 This fixes the bug I introduced in my last batch of changes.
28124 2002-03-05 Ravi Pratap <ravi@ximian.com>
28126 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28128 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28129 Enums since those are types too.
28131 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28133 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28134 thanks to a call during the lookup process.
28136 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28138 * statement.cs (Foreach): Lots of work to accomodate a particular
28139 kind of foreach statement that I had not kept in mind. It is
28140 possible to have foreachs on classes that provide a GetEnumerator
28141 method that return objects that implement the "pattern" for using
28142 a foreach, there is no need to support GetEnumerator
28145 This is needed to compile nant.
28147 * decl.cs: Only report 114 if the member is not `Finalize' and if
28148 the warning level is at least 2.
28150 * class.cs: Moved the compare function from Method to
28153 (MethodSignature.InheritableMemberSignatureCompare): Add new
28154 filter function that is used to extract inheritable methods from a
28157 (Method.Define): Use the new `inheritable_method_signature_filter'
28160 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28163 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28165 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28167 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28169 * expression.cs: Pass location information to
28170 ConvertImplicitStandard.
28172 * class.cs: Added debugging code to track return values from
28175 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28177 * expression.cs (Is.DoResolve): If either side of the `is' is an
28178 interface, do not flag the warning.
28180 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28183 * report.cs: Allow for --fatal to be used with --probe.
28185 * typemanager.cs (NoTypes): Move the definition for the empty Type
28188 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28190 (TypeContainer.DefineProxy): New function used to proxy to parent
28191 implementations when implementing interfaces.
28192 (TypeContainer.ParentImplements): used to lookup if our parent
28193 implements a public function that is required by an interface.
28194 (TypeContainer.VerifyPendingMethods): Hook this up.
28196 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28197 `modules' and `assemblies' arraylists into arrays. We only grow
28198 these are the very early start up of the program, so this improves
28199 the speedof LookupType (nicely measured).
28201 * expression.cs (MakeByteBlob): Replaced unsafe code with
28202 BitConverter, as suggested by Paolo.
28204 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28205 folding of string concatenation, but if either side is a string,
28206 and the other is not, then return null, and let the runtime use
28207 the concatenation on the string plus the object (using
28208 `Object.ToString').
28210 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28212 Constant Folding has been implemented now.
28214 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28215 the error instead on types that are not supported in one's
28218 * constant.cs (Constant and all children): New set of functions to
28219 perform implict and explicit conversions.
28221 * ecore.cs (EnumConstant): Implement the new functions to perform
28222 conversion by proxying to the child expression.
28224 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28225 own separate setting that can not be turned off from the command
28226 line using --unchecked or --checked and is only controlled using
28227 the checked/unchecked statements and expressions. This setting is
28228 used by the constant folder to flag errors.
28230 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28231 ConstantCheckState as well.
28233 During Resolve, they also have to flag the state, because the
28234 constant folder runs completely in the Resolve phase.
28236 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28239 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28241 * cfold.cs: New file, this file contains the constant folder.
28243 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28244 argument to track whether we are using the resulting address to
28245 load or store a value and provide better error messages.
28247 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28248 new AddressOf arguments.
28250 * statement.cs (Foreach.EmitCollectionForeach): Update
28252 * expression.cs (Argument.Emit): Call AddressOf with proper
28253 arguments to track usage.
28255 (New.DoEmit): Call AddressOf with new arguments.
28257 (Unary.Emit): Adjust AddressOf call.
28259 2002-03-01 Ravi Pratap <ravi@ximian.com>
28261 * cs-parser.jay (member_access): Change the case for pre-defined types
28262 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28265 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28268 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28269 essentially like methods and apply attributes like MethodImplOptions to them too.
28271 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28274 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28275 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28278 * Update code everywhere accordingly.
28280 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28282 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28284 2002-02-28 Ravi Pratap <ravi@ximian.com>
28286 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28287 try performing lookups against those instead of jumping straight into using
28288 the 'using' clauses.
28290 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28292 (LookupType): Perform lookups in implicit parents too.
28294 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28295 sequence as RootContext.LookupType.
28297 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28298 the various cases of namespace lookups into this method.
28300 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28302 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28303 in positional arguments)
28305 * class.cs (Operator): Update the AllowedModifiers to contain
28308 * cs-parser.jay: Update operator declaration to allow for the
28309 operator body to be empty.
28311 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28314 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28316 * class.cs (Method.Emit): Label parameters.
28318 * driver.cs: Return 1 or 0 as the program exit code.
28320 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28322 * expression.cs: Special case the `null' object when trying to
28323 auto-compute the type, as anything can be explicitly converted to
28326 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28327 spotting this Paolo.
28329 (Expression.ImplicitNumericConversion): Perform comparissions of
28330 the type using the underlying type in the case of an enumeration
28331 rather than using the enumeration type for the compare.
28333 Cope with the underlying == type case, which is not possible to
28336 (Expression.ConvertNumericExplicit): Perform comparissions of
28337 the type using the underlying type in the case of an enumeration
28338 rather than using the enumeration type for the compare.
28340 * driver.cs: If the user does not supply an extension, assume .exe
28342 * cs-parser.jay (if_statement): Rewrote so that we can track the
28343 location for the if statement.
28345 * expression.cs (Binary.ConstantFold): Only concat strings when
28346 the operation is "+", not everything ;-)
28348 * statement.cs (Statement.EmitBoolExpression): Take a location
28350 (If, While, Do): Track location.
28352 * expression.cs (Binary.ResolveOperator): In the object + string
28353 case, I was missing a call to ConvertImplicit
28355 2002-02-25 Ravi Pratap <ravi@ximian.com>
28357 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28358 Location arguments. Ensure we use RootContext.LookupType to do our work
28359 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28361 * interface.cs (PopulateMethod): Handle the type of the parameter being
28364 * expression.cs (Invocation.BetterFunction): Handle the case when we
28365 have a params method with no fixed arguments and a call is made with no
28368 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28370 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28371 the verbatim-string-literal
28373 * support.cs (InternalParameters.ParameterModifier): handle null
28375 (InternalParameters.ParameterType): ditto.
28377 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28378 duplicating the name of the variable parameter.
28379 (GetParameterByName): Fix bug where we were not looking up array
28380 paramters if they were the only present (thanks Paolo!).
28381 (GetParameterInfo): We only have an empty set of types if both
28382 fixed and array are set to null.
28383 (GetParameterInfo-idx): Handle FixedParameter == null
28385 * cs-parser.jay: Handle the case where there is no catch
28386 statements (missing null test).
28388 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28390 * driver.cs (MainDriver): Be conservative on our command line
28393 Catch DirectoryNotFoundException when calling GetFiles.
28395 (SplitPathAndPattern): Used to split the input specification into
28396 a path and a pattern that we can feed to Directory.GetFiles.
28398 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28400 * statement.cs (Fixed): Implement the last case of the Fixed
28401 statement (string handling).
28403 * expression.cs (StringPtr): New class used to return a char * to
28404 a string; Used by the Fixed statement.
28406 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28408 * expression.cs (Binary.ResolveOperator): Remove redundant
28409 MemberLookup pn parent type.
28410 Optimize union call, we do not need a union if the types are the same.
28411 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28414 Specialize the use of MemberLookup everywhere, instead of using
28415 the default settings.
28417 (StackAlloc): Implement stackalloc keyword.
28419 * cs-parser.jay: Add rule to parse stackalloc.
28421 * driver.cs: Handle /h, /help, /?
28423 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28424 before we supported unsafe code.
28426 * makefile: add --unsafe to the self compilation of mcs.
28428 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28430 * expression.cs (PointerArithmetic): New class that is used to
28431 perform pointer arithmetic.
28432 (Binary.Resolve): Handle pointer arithmetic
28433 Handle pointer comparission.
28434 (ArrayPtr): Utility expression class that is used to take the
28435 address of an array.
28437 (ElementAccess): Implement array access for pointers
28439 * statement.cs (Fixed): Implement fixed statement for arrays, we
28440 are missing one more case before we are done.
28442 * expression.cs (Indirection): Implement EmitAssign and set the
28443 ExprClass to Variable. This allows pointer dereferences to be
28444 treated as variables, and to have values assigned to them.
28446 * ecore.cs (Expression.StoreFromPtr): New utility function to
28447 store values dereferencing.
28449 2002-02-20 Ravi Pratap <ravi@ximian.com>
28451 * expression.cs (Binary.ResolveOperator): Ensure that we are
28452 not trying to operate on a void type - this fixes the reported
28455 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28456 the parent implementation is sealed.
28458 * ../errors/cs0239.cs : Add.
28460 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28462 * typemanager.cs (unverifiable_code_type): Corresponds to
28463 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28464 which have unsafe code in them.
28466 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28469 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28471 * cs-tokenizer.cs: Add support for @"litreal strings"
28473 Make tokenizer accept pre-processor directives
28474 on any column (remove the old C-like limitation).
28476 * rootcontext.cs (EmitCode): Emit any global attributes.
28477 (AddGlobalAttributes): Used to keep track of assembly attributes.
28479 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28481 * cs-parser.jay: Add support for global attributes.
28483 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28485 * expression.cs (Indirection): New helper class. Unary will
28486 create Indirection classes to be able to implement the
28487 IMemoryLocation interface on it.
28489 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28491 * cs-parser.jay (fixed_statement): reference the right statement.
28493 * statement.cs (Fixed.Emit): Finish implementing the fixed
28494 statement for the &x case.
28496 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28498 * class.cs (Property.Define, Method.Define): Remove newslot when
28501 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28502 wrong. NewSlot should only be used if the `new' keyword is present.
28504 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28505 locating our system dir. Sorry about this.
28507 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28509 * driver.cs (GetSystemDir): Compute correctly the location of our
28510 system assemblies. I was using the compiler directory instead of
28511 the library directory.
28513 2002-02-13 Ravi Pratap <ravi@ximian.com>
28515 * expression.cs (BetterFunction): Put back in what Miguel commented out
28516 since it is the correct fix. The problem is elsewhere ;-)
28518 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28519 parameters of the parms method are themselves compatible or not !
28521 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28522 to check that a class implements an interface before saying that an implicit
28523 conversion was allowed. Use ImplementsInterface to do the checking.
28525 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28527 * class.cs (Method.Define): Track whether we are an explicit
28528 implementation or not. And only call DefineMethodOverride if we
28529 are an explicit implementation.
28531 (Property.DefineMethod): Ditto.
28533 2002-02-11 Ravi Pratap <ravi@ximian.com>
28535 * expression.cs (BetterFunction): Catch hideous bug which was
28536 preventing us from detecting ambiguous calls due to implicit casts i.e
28539 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28541 * support.cs (Pair): Remove un-needed method. I figured why I was
28542 getting the error in cs-parser.jay, the variable in a foreach loop
28543 is readonly, and the compiler does not really treat this as a variable.
28545 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28546 instead of EQUALS in grammar.
28548 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28550 * expression.cs (Unary.DoResolve): Check whether the argument is
28553 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28555 * support.cs: Api for Pair to set a value. Despite the fact that
28556 the variables are public the MS C# compiler refuses to compile
28557 code that accesses the field if the variable is part of a foreach
28560 * statement.cs (Fixed): Begin implementation of the fixed
28563 (Block.AddVariable): Return the VariableInfo on success and null
28564 on failure instead of true/false.
28566 * cs-parser.jay (foreach): Catch errors on variables already
28567 defined (we were ignoring this value before) and properly unwind
28568 the block hierarchy
28570 (fixed_statement): grammar for the fixed statement.
28572 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28574 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28575 pointer types to be incretemented.
28577 (SizeOf): Implement.
28579 * cs-parser.jay (pointer_member_access): Implement
28580 expr->IDENTIFIER production.
28582 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28583 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28586 (Unary): Implement indirection.
28588 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28589 use in non-unsafe context).
28591 (SimpleName.DoResolve): Check for pointers in field access on safe
28594 (Expression.LoadFromPtr): Factor the load-indirect code in this
28595 function. This was duplicated in UnboxCast and ParameterReference
28597 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28599 * expression.cs (ComposedCast): report an error if a pointer cast
28600 is used in a safe region.
28602 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28603 pointer type casts in unsafe context.
28605 * codegen.cs (EmitContext): Set up IsUnsafe.
28607 * cs-parser.jay (non_expression_type): Add productions for pointer
28610 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28611 code. We should not use force into static mode if the method is
28612 not virtual. Fixes bug in MIS
28614 * statement.cs (Do.Emit, While.Emit, For.Emit,
28615 Statement.EmitBoolExpression): Add support to Do and While to
28616 propagate infinite loop as `I do return' semantics.
28618 Improve the For case to also test for boolean constants.
28620 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28621 to the list of attributes we can add.
28623 Remove `EmitContext' argument.
28625 * class.cs (Method.Define): Apply parameter attributes.
28626 (Constructor.Define): Apply parameter attributes.
28627 (MethodCore.LabelParameters): Move here the core of labeling
28630 * support.cs (ReflectionParameters.ParameterModifier,
28631 InternalParameters.ParameterModifier): Use IsByRef on the type and
28632 only return the OUT bit for these parameters instead of in/out/ref
28635 This is because I miss-understood things. The ParameterInfo.IsIn
28636 and IsOut represent whether the parameter has the [In] and [Out]
28639 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28641 * ecore.cs (FieldExpr.Emit): Release temporaries.
28643 * assign.cs (LocalTemporary.Release): new function.
28645 * codegen.cs (EmitContext.GetTemporaryStorage,
28646 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28647 temporary storage. Now we can "put back" localbuilders when we
28650 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28652 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28653 need to make a copy of the variable to generate verifiable code.
28655 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28657 * driver.cs: Compute dynamically the system directory.
28659 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28660 Slower, but more generally useful. Used by the abstract
28661 registering implementation.
28663 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28664 the rules for the special rule on Type/instances. First check if
28665 we have the same name, and if so, try that special static path
28666 rather than the instance path.
28668 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28670 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28673 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28674 Enum, ValueType, Delegate or Array for non-corlib compiles.
28676 * cs-tokenizer.cs: Catch long identifiers (645)
28678 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28681 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28682 fix, we were returning too early, so we were not registering
28683 pending methods from abstract classes.
28685 Do not register pending methods if the class is abstract.
28687 * expression.cs (Conditional.DoResolve): Report circular implicit
28688 conversions when we neecd to compute it for conditional
28691 (Is.DoResolve): If the expression is always of the provided type,
28692 flag warning 183. If the expression can not ever be of the
28693 provided type flag warning 184.
28695 * class.cs: Catch 169 as well.
28697 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28700 2002-01-18 Nick Drochak <ndrochak@gol.com>
28702 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28704 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28706 * interface.cs: (PopulateMethod): Check for pointers being defined
28707 only if the unsafe context is active.
28708 (PopulateProperty): ditto.
28709 (PopulateIndexer): ditto.
28711 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28712 specified. If pointers are present, make sure that they are
28713 present in an unsafe context.
28714 (Constructor, Constructor.Define): ditto.
28715 (Field, Field.Define): ditto.
28716 (Property, Property.Define): ditto.
28717 (Event, Event.Define): ditto.
28719 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28720 hashtable if there are classes or structs defined.
28722 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28723 code, as the constant resolution moved.
28725 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28726 the metadata, so we can flag error 133.
28728 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28729 pointer is being declared in an unsafe context.
28731 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28733 * modifiers.cs (Modifiers.Check): Require a Location argument.
28734 Report error 227 for Unsafe use.
28736 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28738 * statement.cs (For.Emit): If the test is null, then report that
28739 we do `return', as we wont reach anything afterwards.
28741 (Switch.SwitchGoverningType): Track the expression that matched
28744 * driver.cs: Allow negative numbers as an error code to flag.
28746 * cs-parser.jay: Handle 1551.
28748 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28750 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28752 * cs-parser.jay: Report 1518 (type declaration can only contain
28753 class, struct, interface, enum or delegate)
28755 (switch_label): Report 1523 (keywords `case' or `default' must
28758 (opt_switch_sections): Report 1522 (empty switch)
28760 * driver.cs: Report 1515 (response file specified multiple times)
28761 Report 1516 (Source file specified multiple times).
28763 * expression.cs (Argument.Resolve): Signal 1510
28765 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28766 access not allowed in static code)
28768 2002-01-11 Ravi Pratap <ravi@ximian.com>
28770 * typemanager.cs (IsPointerType): Utility method which we are going
28773 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28774 the object type, so we take care of that.
28776 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28778 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28779 added to non-params parameters :-)
28781 * typemanager.cs (CSharpName): Include 'void' type too.
28783 (void_ptr_type): Include in the set of core types.
28785 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28788 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28791 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28792 completely forgotten about it.
28794 2002-01-10 Ravi Pratap <ravi@ximian.com>
28796 * cs-parser.jay (pointer_type): Add. This begins our implementation
28797 of parsing rules for unsafe code.
28799 (unsafe_statement): Implement.
28801 (embedded_statement): Modify to include the above.
28803 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28805 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28806 if the current context is an unsafe one.
28808 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28809 are handled differently, we need separate rules for them.
28811 (local_variable_declaration): Update to use local_variable_pointer_type
28812 to allow variable declarations of unmanaged pointer types.
28814 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28815 in unsafe contexts.
28817 * ../errors/cs0214.cs : Add.
28819 2002-01-16 Nick Drochak <ndrochak@gol.com>
28821 * makefile: remove 'response' file when cleaning.
28823 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28825 * cs-parser.jay: Report 1524.
28827 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28829 * typemanager.cs (RegisterMethod): drop checking if we have
28830 registered this from here
28832 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28834 * class.cs (Method.EmitDestructor): Implement calling our base
28837 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28838 value of InFinally.
28840 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28841 this routine and will wrap the call in a try/catch block. Deal
28844 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28846 * ecore.cs (Expression.MemberLookup): instead of taking a
28847 parameter `same_type' that was used to tell whether we could
28848 access private members we compute our containing type from the
28851 (FieldExpr): Added partial support for volatile fields. This does
28852 not work for volatile fields exposed from assemblies, as I can not
28853 figure out how to extract the modreq from it.
28855 Updated all the source files to use this.
28857 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28858 because it is referenced by MemberLookup very often.
28860 2002-01-09 Ravi Pratap <ravi@ximian.com>
28862 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28863 TypeBuilder.GetCustomAttributes to retrieve what we need.
28865 Get rid of redundant default_member_attr_type as this is the same as
28866 default_member_type which already exists.
28868 * interface.cs, attribute.cs : Update accordingly.
28870 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28872 * typemanager.cs: Enable IndexerPropertyName again. It does not
28873 work for TYpeBuilders though. Ravi, can you please fix this?
28875 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28877 * expression.cs (Argument.Emit): Handle the case of ref objects
28878 being passed to ref functions;
28880 (ParameterReference.EmitLoad): Loads the content of the pointer
28881 without dereferencing.
28883 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28885 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28887 2002-01-08 Ravi Pratap <ravi@ximian.com>
28889 * class.cs (Indexer.DefineMethod): Incorporate the interface
28890 type in the name of the method if we are doing explicit interface
28893 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28895 (BetterConversion): Fix extremely trivial bug where we were referring to
28896 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28899 * ../errors/bug16.cs : Add although we have fixed it.
28901 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28903 * expression.cs (BaseIndexer): Begin implementation.
28905 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28907 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28908 production directly to remove a shift/reduce, and implement
28909 explicit interface implementation.
28911 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28912 after a floating point suffix.
28914 * expression.cs (DoNumericPromotions): Improved the conversion for
28915 uint/uint. If we have a constant, we avoid doing a typecast to a
28918 * class.cs (Indexer): Implement explicit interface implementation
28921 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28923 * class.cs: make the default instance constructor public and hidebysig.
28925 2001-01-03 Ravi Pratap <ravi@ximian.com>
28927 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28928 so we can call it from elsewhere.
28930 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28931 we emit it internally if the class has a defined indexer; otherwise the user
28932 emits it by decorating the class definition with the DefaultMemberAttribute.
28934 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28935 attribute is not used on a type which defines an indexer.
28937 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28938 character when we skip whitespace.
28940 * ../errors/cs0646.cs : Add.
28942 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28944 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28947 * makefile: Add practical target `mcs3.exe' which builds the third
28948 generation compiler.
28950 * expression.cs (New): Fix structures constructor calling.
28952 * class.cs (Property, Method, Indexer): Emit Final flag on the
28953 method if we are an interface implementation and we are not
28956 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28957 whether this property is referencing a `base' method.
28959 * expression.cs (Invocation.EmitCall): take an extra argument:
28960 is_base, this is used to determine whether the `call' or
28961 `callvirt' opcode should be used.
28964 * delegate.cs: update EmitCall.
28966 * class.cs (Method.Define): Set NewSlot for the cases where we are
28967 not implementing an interface method.
28969 (Property.Define): ditto.
28971 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28973 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28974 'r'. Allows mcs to parse itself fully.
28976 2002-01-02 Ravi Pratap <ravi@ximian.com>
28978 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28979 of the number of initializers that require the InitializeArray method.
28981 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28982 update the above field where necessary.
28984 (MakeByteBlob): Update accordingly.
28986 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28989 (EmitDynamicInitializers): Update in accordance with the new optimization.
28991 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28992 same OpCode applies.
28994 * cs-parser.jay : Fix some glaring errors I introduced.
28996 2002-01-01 Ravi Pratap <ravi@ximian.com>
28998 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28999 so that we can check for name clashes there too.
29001 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29002 for interface indexers.
29004 * interfaces.cs (Define): Emit the default member attribute.
29006 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29007 variable was being referred to while setting the value ;-)
29009 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29011 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29012 byte-by-byte information when we know the data is zero.
29014 Make the block always a multiple of 4, because
29015 DefineInitializedData has a bug.
29017 * assign.cs: Fix, we should assign from the temporary, not from
29020 * expression.cs (MakeByteBlob): Fix my incorrect code.
29022 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29024 * typemanager.cs (EnumToUnderlying): This function is used to get
29025 the underlying type from an enumeration, because it does not
29028 * constant.cs: Use the I4_S form for values between -128 and 127.
29030 * statement.cs (Block.LookupLabel): Looks up a label.
29031 (Block): Drop support for labeled blocks.
29033 (LabeledStatement): New kind of statement that represents a label
29036 (Goto): Finally implement this bad boy.
29038 * cs-parser.jay: Update to reflect new mechanism to implement
29041 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29043 * codegen.cs (EmitContext.This): a codegen property that keeps the
29044 a single instance of this instead of creating many different this
29047 * delegate.cs (Delegate.DoResolve): Update to use the property;
29049 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29051 * expression.cs (BaseAccess.DoResolve): Ditto.
29053 2001-12-29 Ravi Pratap <ravi@ximian.com>
29055 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29056 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29058 (InitCoreTypes): Update accordingly.
29060 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29061 so we can quickly store the state.
29063 (ApplyAttributes): Set the correct implementation flags
29064 for InternalCall methods.
29066 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29068 * expression.cs (EmitCall): if a method is not virtual, then do
29069 not use callvirt on it.
29071 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29072 user defined stuff) requires the use of stobj, which takes an
29073 address on the stack instead of an array and an index. So emit
29074 the Ldelema operation for it.
29076 (EmitStoreOpcode): Use stobj for valuetypes.
29078 (UnaryMutator.EmitCode): Use the right 1 value depending on
29079 whether we are dealing with int64/uint64, float or doubles.
29081 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29082 constructors that I implemented last night.
29084 (Constructor.IsDefault): Fix to work properly for static
29087 * cs-parser.jay (CheckDef): report method signature errors.
29088 Update error number 103 to be 132.
29090 * decl.cs: New AdditionResult enumeration value: MethodExists.
29091 Although we do this check for methods later on in the semantic
29092 analysis, catching repeated default constructors is so easy that
29093 we catch these here.
29095 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29098 (ParameterReference.EmitAssign, Emit): handle
29101 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29102 (ArrayAccess.EmitStoreOpcode): ditto.
29104 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29106 * expression.cs (MakeByteBlob): Complete all the missing types
29107 (uint, short, ushort, byte, sbyte)
29109 * class.cs: Only init instance field initializers on instance
29112 Rename `constructors' to instance_constructors.
29114 (TypeContainer.AddConstructor): Only add constructors to the list
29115 if it is not static.
29117 Make sure that we handle default_static_constructor independently
29118 everywhere where we handle instance_constructors
29120 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29122 * class.cs: Do not lookup or create a base initializer for a
29123 static constructor.
29125 (ConstructorInitializer.Resolve): use the proper type to lookup
29128 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29130 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29133 * decl.cs: CloseType is now an virtual method, the default
29134 implementation just closes this type.
29136 2001-12-28 Ravi Pratap <ravi@ximian.com>
29138 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29139 to PreserveSig by default. Also emit HideBySig on such methods.
29141 Basically, set the defaults to standard values.
29143 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29144 argument, if candidate is better, it can't be worse than the best !
29146 (Invocation): Re-write bits to differentiate between methods being
29147 applicable in their expanded form and their normal form - for params
29150 Get rid of use_standard everywhere as only standard conversions are allowed
29151 in overload resolution.
29153 More spec conformance.
29155 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29157 * driver.cs: Add --timestamp, to see where the compiler spends
29160 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29161 `this' in static code.
29163 (SimpleName.DoResolve): Implement in terms of a helper function
29164 that allows static-references to be passed upstream to
29167 (Expression.ResolveWithSimpleName): Resolve specially simple
29168 names when called by MemberAccess to implement the special
29171 (Expression.ImplicitReferenceConversion): Handle conversions from
29172 Null to reference types before others, as Null's type is
29175 * expression.cs (Invocation.EmitCall): Handle the special case of
29176 calling methods declared on a reference type from a ValueType
29177 (Base classes System.Object and System.Enum)
29179 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29180 the left hand side is a TypeExpr, not on every enumeration.
29182 (Binary.Resolve): If types are reference types, then do a cast to
29183 object on operators != and == of both arguments.
29185 * typemanager.cs (FindMembers): Extract instance and static
29186 members if requested.
29188 * interface.cs (PopulateProperty): Use void_type instead of null
29189 as the return type for the setter method.
29191 (PopulateIndexer): ditto.
29193 2001-12-27 Ravi Pratap <ravi@ximian.com>
29195 * support.cs (ReflectionParameters): Fix minor bug where we
29196 were examining the wrong parameter for the ParamArray attribute.
29198 Cope with requests for the type of the parameter at position
29199 greater than the params parameter's. We now return the element
29200 type of the params array as that makes more sense.
29202 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29203 accordingly as we no longer have to extract the element type
29206 (Invocation.OverloadResolve): Update.
29208 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29210 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29211 against IEnumerator, test whether the return value is a descendant
29212 of the IEnumerator interface.
29214 * class.cs (Indexer.Define): Use an auxiliary method to implement
29215 the other bits of the method definition. Begin support for
29216 explicit interface implementation.
29218 (Property.DefineMethod): Use TypeManager.void_type instead of null
29219 for an empty return value.
29221 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29223 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29224 dealing with a FieldExpr which is composed of a FieldBuilder, in
29225 the code path we did extract the constant, but we should have
29226 obtained the underlying value to be able to cast it (otherwise we
29227 end up in an infinite loop, this is what Ravi was running into).
29229 (ArrayCreation.UpdateIndices): Arrays might be empty.
29231 (MemberAccess.ResolveMemberAccess): Add support for section
29232 14.5.4.1 that deals with the special case of E.I when E is a type
29233 and something else, that I can be a reference to a static member.
29235 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29236 handle a particular array type to create byte blobs, it is just
29237 something we dont generate byteblobs for.
29239 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29242 * location.cs (Push): remove the key from the hashtable that we
29243 are about to add. This happens for empty files.
29245 * driver.cs: Dispose files after we have parsed them.
29247 (tokenize): new function that only runs the tokenizer on its
29248 input, for speed testing.
29250 2001-12-26 Ravi Pratap <ravi@ximian.com>
29252 * class.cs (Event.Define): Define the private field only if there
29253 are no accessors defined.
29255 * expression.cs (ResolveMemberAccess): If there is no associated
29256 field with the event, that means we have an event defined with its
29257 own accessors and we should flag error cs0070 since transforming
29258 ourselves into a field is not valid in that case.
29260 * ecore.cs (SimpleName.DoResolve): Same as above.
29262 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29263 and charset to sane values.
29265 2001-12-25 Ravi Pratap <ravi@ximian.com>
29267 * assign.cs (DoResolve): Perform check on events only if they
29268 are being accessed outside the declaring type.
29270 * cs-parser.jay (event_declarations): Update rules to correctly
29271 set the type of the implicit parameter etc.
29273 (add_accessor, remove_accessor): Set current local parameters.
29275 * expression.cs (Binary): For delegate addition and subtraction,
29276 cast the return value from the method into the appropriate delegate
29279 2001-12-24 Ravi Pratap <ravi@ximian.com>
29281 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29282 of these as the workaround is unnecessary.
29284 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29285 delegate data - none of that is needed at all.
29287 Re-write bits to extract the instance expression and the delegate method
29290 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29293 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29294 of attaching attributes instead of duplicating code everywhere.
29296 * everywhere : Update code to do attribute emission using the above method.
29298 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29300 * expression.cs (IsParamsMethodApplicable): if there are not
29301 parameters, return immediately.
29303 * ecore.cs: The 0 literal can be implicity converted to an enum
29306 (SimpleName.DoResolve): First lookup the type, then lookup the
29309 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29310 want to get its address. If the InstanceExpression is not
29311 addressable, store the result in a temporary variable, then get
29314 * codegen.cs: Only display 219 errors on warning level or above.
29316 * expression.cs (ArrayAccess): Make it implement the
29317 IMemoryLocation interface.
29319 (Binary.DoResolve): handle the operator == (object a, object b)
29320 and operator != (object a, object b) without incurring into a
29321 BoxedCast (because 5 != o should never be performed).
29323 Handle binary enumerator operators.
29325 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29326 value type, otherwise use Ldelem_ref.
29328 Use precomputed names;
29330 (AddressOf): Implement address of
29332 * cs-parser.jay (labeled_statement): Fix recursive block
29333 addition by reworking the production.
29335 * expression.cs (New.DoEmit): New has a special case:
29337 If we are dealing with a ValueType, we have a few
29338 situations to deal with:
29340 * The target of New is a ValueType variable, that is
29341 easy, we just pass this as the variable reference
29343 * The target of New is being passed as an argument,
29344 to a boxing operation or a function that takes a
29347 In this case, we need to create a temporary variable
29348 that is the argument of New.
29351 2001-12-23 Ravi Pratap <ravi@ximian.com>
29353 * rootcontext.cs (LookupType): Check that current_type is not null before
29354 going about looking at nested types.
29356 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29357 not implement the IAssignMethod interface any more.
29359 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29360 where we tranform them into FieldExprs if they are being resolved from within
29361 the declaring type.
29363 * ecore.cs (SimpleName.DoResolve): Do the same here.
29365 * assign.cs (DoResolve, Emit): Clean up code considerably.
29367 * ../errors/bug10.cs : Add.
29369 * ../errors/cs0070.cs : Add.
29371 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29373 * assign.cs : Get rid of EventIsLocal everywhere.
29375 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29377 * ecore.cs (ConvertIntLiteral): finished the implementation.
29379 * statement.cs (SwitchLabel): Convert the value we are using as a
29380 key before looking up the table.
29382 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29384 * codegen.cs (EmitTopBlock): Require a Location argument now.
29386 * cs-parser.jay (constructor_declarator): We need to setup
29387 current_local_parameters before we parse the
29388 opt_constructor_initializer, to allow the variables to be bound
29389 to the constructor arguments.
29391 * rootcontext.cs (LookupType): First lookup nested classes in our
29392 class and our parents before we go looking outside our class.
29394 * expression.cs (ConstantFold): Extract/debox the values at the
29397 * rootcontext.cs (EmitCode): Resolve the constants first before we
29398 resolve the types. This is not really needed, but it helps debugging.
29400 * statement.cs: report location.
29402 * cs-parser.jay: pass location to throw statement.
29404 * driver.cs: Small bug fix.
29406 * report.cs: Updated format to be 4-zero filled digits.
29408 2001-12-22 Ravi Pratap <ravi@ximian.com>
29410 * expression.cs (CheckIndices): Fix minor bug where the wrong
29411 variable was being referred to ;-)
29413 (DoEmit): Do not call EmitStaticInitializers when the
29414 underlying type is System.Object.
29416 2001-12-21 Ravi Pratap <ravi@ximian.com>
29418 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29419 and do the usual workaround for SRE.
29421 * class.cs (MyEventBuilder.EventType): New member to get at the type
29422 of the event, quickly.
29424 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29426 * assign.cs (Assign.DoResolve): Handle the case when the target
29427 is an EventExpr and perform the necessary checks.
29429 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29432 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29434 (EventExpr): Set the type in the constructor itself since we
29435 are meant to be born fully resolved.
29437 (EventExpr.Define): Revert code I wrote earlier.
29439 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29440 instance expression is null. The instance expression is a This in that case
29441 or a null, depending on whether it is a static method or not.
29443 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29444 refers to more than one method.
29446 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29447 and accordingly flag errors.
29449 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29451 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29453 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29455 * location.cs (ToString): Provide useful rutine.
29457 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29459 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29460 objects, return the actual integral boxed.
29462 * statement.cs (SwitchLabel): define an ILLabel for each
29465 (Switch.CheckSwitch): If the value is a Literal, extract
29466 the underlying literal.
29468 Also in the unused hashtable we had, add the SwitchLabel so we can
29469 quickly look this value up.
29471 * constant.cs: Implement a bunch of new constants. Rewrite
29472 Literal based on this. Made changes everywhere to adapt to this.
29474 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29475 dereferencing array only once, and also copes with enumrations.
29477 bytes are two bytes wide, not one.
29479 (Cast): Perform constant conversions.
29481 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29482 wrappers to the literals here.
29484 * expression.cs (DoNumericPromotions): long literals can converted
29485 to ulong implicity (this is taken care of elsewhere, but I was
29486 missing this spot).
29488 * ecore.cs (Expression.Literalize): Make the return type Literal,
29489 to improve type checking.
29491 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29493 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29495 * literal.cs: Revert code from ravi that checked the bounds. The
29496 bounds are sane by the definition of the type itself.
29498 * typemanager.cs: Fix implementation of ImplementsInterface. We
29499 need to actually look up in our parent hierarchy for interfaces
29502 * const.cs: Use the underlying type for enumerations
29504 * delegate.cs: Compute the basename for the delegate creation,
29505 that should fix the delegate test case, and restore the correct
29506 Type Lookup semantics in rootcontext
29508 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29509 referencing a nested type with the Reflection API is using the "+"
29512 * cs-parser.jay: Do not require EOF token at the end.
29514 2001-12-20 Ravi Pratap <ravi@ximian.com>
29516 * rootcontext.cs (LookupType): Concatenate type names with
29517 a '.' instead of a '+' The test suite passes again.
29519 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29520 field of the enumeration.
29522 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29523 the case when the member is an EventExpr.
29525 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29526 static has an associated instance expression.
29528 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29530 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29532 * class.cs (Event.Define): Register event and perform appropriate checks
29535 We define the Add and Remove methods even if the use provides none because
29536 in that case, we provide default implementations ourselves.
29538 Define a private field of the type of the event. This is done by the CSC compiler
29539 and we should be doing it too ;-)
29541 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29542 More methods we use in code we generate.
29544 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29547 (InitCoreTypes): Update accordingly for the above.
29549 * class.cs (Event.Emit): Generate code for default accessors that we provide
29551 (EmitDefaultMethod): Do the job in the above.
29553 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29556 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29558 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29559 builders even if we were missing one.
29561 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29562 pass the Basename as our class name instead of the Name. The
29563 basename will be correctly composed for us.
29565 * parameter.cs (Paramters): Now takes a Location argument.
29567 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29568 make all the code call directly LookupType in RootContext and take
29569 this chance to pass the Location information everywhere.
29571 * Everywhere: pass Location information.
29573 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29575 * class.cs (Constructor.Define): Updated way of detecting the
29576 length of the parameters.
29578 (TypeContainer.DefineType): Use basename as the type name for
29581 (TypeContainer.Define): Do not recursively define types here, as
29582 definition is taken care in order by the RootContext.
29584 * tree.cs: Keep track of namespaces in a per-file basis.
29586 * parameter.cs (Parameter.ComputeSignature): Update to use
29589 (Parameters.GetSignature): ditto.
29591 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29592 instead of a TypeContainer.
29594 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29595 resolve names. Because we need to be resolve in our context, not
29598 * driver.cs: Implement response files.
29600 * class.cs (TypeContainer.DefineType): If we are defined, do not
29601 redefine ourselves.
29603 (Event.Emit): Emit the code for add/remove handlers.
29604 (Event.Define): Save the MethodBuilders for add/remove.
29606 * typemanager.cs: Use pair here too.
29608 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29609 DictionaryEntry requires the first argument to be non-null.
29611 (enum_declaration): Compute full name for registering the
29614 (delegate_declaration): Instead of using
29615 formal_parameter_list, use opt_formal_parameter_list as the list
29618 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29619 (EventParsing): New property that controls whether `add' and
29620 `remove' are returned as tokens or identifiers (for events);
29622 2001-12-19 Ravi Pratap <ravi@ximian.com>
29624 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29625 use MyEventBuilder only and let it wrap the real builder for us.
29627 (MyEventBuilder): Revamp constructor etc.
29629 Implement all operations that we perform on EventBuilder in precisely the same
29632 (FindMembers): Update to use the EventBuilder member.
29634 (Event.Emit): Update accordingly.
29636 2001-12-18 Ravi Pratap <ravi@ximian.com>
29638 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29639 by calling the appropriate methods.
29641 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29644 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29646 2001-12-17 Ravi Pratap <ravi@ximian.com>
29648 * delegate.cs (Delegate.Populate): Check that the return type
29649 and various parameters types are indeed accessible.
29651 * class.cs (Constructor.Define): Same here.
29653 (Field.Define): Ditto.
29655 (Event.Define): Ditto.
29657 (Operator.Define): Check that the underlying Method defined itself
29658 correctly - so it's MethodBuilder should not be null.
29660 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29661 expression happens to be null.
29663 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29664 members but as of now we don't seem to be able to do anything really useful with it.
29666 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29667 not the EventBuilder.
29669 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29671 * cs-tokenizer.cs: Add support for defines.
29672 Add support for #if, #elif, #else, #endif
29674 (eval_var): evaluates a variable.
29675 (eval): stubbed for evaluating functions.
29677 * cs-parser.jay: Pass the defines information
29679 * driver.cs: Add --define command line option.
29681 * decl.cs: Move MemberCore here.
29683 Make it the base class for DeclSpace. This allows us to catch and
29684 report 108 and 109 for everything now.
29686 * class.cs (TypeContainer.Define): Extract all the members
29687 before populating and emit the warning 108 (new keyword required
29688 to override) instead of having each member implement this.
29690 (MemberCore.Define): New abstract method, we will be using this in
29691 the warning reporting engine in Populate.
29693 (Operator.Define): Adjust to new MemberCore protocol.
29695 * const.cs (Const): This does not derive from Expression, it is a
29696 temporary object we use to create fields, it is a MemberCore.
29698 * class.cs (Method.Define): Allow the entry point to be in a
29701 * driver.cs: Rewrite the argument handler to clean it up a bit.
29703 * rootcontext.cs: Made it just an auxiliary namespace feature by
29704 making everything static.
29706 * driver.cs: Adapt code to use RootContext type name instead of
29709 * delegate.cs: Remove RootContext argument.
29711 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29714 * class.cs (Event.Define): The lookup can fail.
29716 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29718 * expression.cs: Resolve the this instance before invoking the code.
29720 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29722 * cs-parser.jay: Add a production in element_access that allows
29723 the thing to become a "type" reference. This way we can parse
29724 things like "(string [])" as a type.
29726 Note that this still does not handle the more complex rules of
29730 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29732 * ecore.cs: (CopyNewMethods): new utility function used to
29733 assemble the list of methods from running FindMembers.
29735 (MemberLookup): Rework FindMembers so that
29737 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29739 * class.cs (TypeContainer): Remove Delegates who fail to be
29742 * delegate.cs (Populate): Verify that we dont get null return
29743 values. TODO: Check for AsAccessible.
29745 * cs-parser.jay: Use basename to emit error 574 (destructor should
29746 have the same name as container class), not the full name.
29748 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29749 possible representation.
29751 Also implements integer type suffixes U and L.
29753 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29755 * expression.cs (ArrayCreation.DoResolve): We need to do the
29756 argument resolution *always*.
29758 * decl.cs: Make this hold the namespace. Hold the root context as
29760 (LookupType): Move here.
29762 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29764 * location.cs (Row, Name): Fixed the code, it was always returning
29765 references to the first file.
29767 * interface.cs: Register properties defined through interfaces.
29769 * driver.cs: Add support for globbing on the command line
29771 * class.cs (Field): Make it derive from MemberCore as well.
29774 2001-12-15 Ravi Pratap <ravi@ximian.com>
29776 * class.cs (Event::Define): Check that the type of the event is a delegate
29777 type else flag error #66.
29779 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29782 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29783 values of EntryPoint, CharSet etc etc.
29785 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29787 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29788 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29789 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29790 which needs this to do its work.
29792 * ../errors/cs0066.cs : Add.
29794 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29796 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29799 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29800 clears out the parameters field.
29801 (MemberSignatureCompare): Cleanup
29803 (MemberCore): New base class used to share code between MethodCore
29806 (RegisterRequiredImplementations) BindingFlags.Public requires
29807 either BindingFlags.Instace or Static. Use instance here.
29809 (Property): Refactored code to cope better with the full spec.
29811 * parameter.cs (GetParameterInfo): Return an empty array instead
29814 * class.cs (Property): Abstract or extern properties have no bodies.
29816 * parameter.cs (GetParameterInfo): return a zero-sized array.
29818 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29819 method modifier validation to the typecontainer so we can reuse
29820 this on properties.
29822 (MethodCore.ParameterTypes): return an empty sized array of types.
29824 (Property.Define): Test property modifier validity.
29826 Add tests for sealed/override too.
29828 (Method.Emit): abstract or extern methods have no bodies.
29830 2001-12-14 Ravi Pratap <ravi@ximian.com>
29832 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29835 (Method::Define, ::Emit): Modify accordingly.
29837 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29839 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29841 * makefile: Pass in /unsafe.
29843 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29845 * class.cs (MakeKey): Kill routine.
29847 * class.cs (TypeContainer.Define): Correctly define explicit
29848 method implementations (they require the full interface name plus
29851 * typemanager.cs: Deply the PtrHashtable here and stop using the
29852 lame keys. Things work so much better.
29854 This of course broke everyone who depended on `RegisterMethod' to
29855 do the `test for existance' test. This has to be done elsewhere.
29857 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29858 the object stupid Equals method (because, that like fails all over
29859 the place). We still do not use it.
29861 * class.cs (TypeContainer.SetRequiredInterface,
29862 TypeContainer.RequireMethods): Killed these two routines and moved
29863 all the functionality to RegisterRequiredImplementations.
29865 (TypeContainer.RegisterRequiredImplementations): This routine now
29866 registers all the implementations required in an array for the
29867 interfaces and abstract methods. We use an array of structures
29868 which can be computed ahead of time to reduce memory usage and we
29869 also assume that lookups are cheap as most classes will not
29870 implement too many interfaces.
29872 We also avoid creating too many MethodSignatures.
29874 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29875 clear the "pending" bit if we find that there are problems with
29878 (TypeContainer.VerifyPendingMethods): Update to report errors of
29879 methods that look like implementations but are not.
29881 (TypeContainer.Define): Add support for explicit interface method
29884 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29886 * typemanager.cs: Keep track of the parameters here instead of
29887 being a feature of the TypeContainer.
29889 * class.cs: Drop the registration of parameters here, as
29890 InterfaceMethods are also interface declarations.
29892 * delegate.cs: Register methods with the TypeManager not only with
29893 the TypeContainer. This code was buggy.
29895 * interface.cs: Full registation here.
29897 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29899 * expression.cs: Remove reducer for binary expressions, it can not
29902 * const.cs: Put here the code that used to go into constant.cs
29904 * constant.cs: Put here the code for constants, this is a new base
29905 class for Literals.
29907 * literal.cs: Make Literal derive from Constant.
29909 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29911 * statement.cs (Return.Emit): Report error 157 if the user
29912 attempts to return from a finally block.
29914 (Return.Emit): Instead of emitting a return, jump to the end of
29917 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29918 LocalBuilder to store the result of the function. ReturnLabel is
29919 the target where we jump.
29922 2001-12-09 Radek Doulik <rodo@ximian.com>
29924 * cs-parser.jay: remember alias in current namespace
29926 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29929 * class.cs (LookupAlias): lookup alias in my_namespace
29931 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29933 (LookupAlias): lookup alias in this and if needed in parent
29936 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29940 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29941 making things static. I need this to avoid passing the
29942 TypeContainer when calling ParameterType.
29944 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29945 that did string manipulation to compute the type and then call
29946 GetType. Use Parameter.ParameterType instead.
29948 * cs-tokenizer.cs: Consume the suffix for floating values.
29950 * expression.cs (ParameterReference): figure out whether this is a
29951 reference parameter or not. Kill an extra variable by computing
29952 the arg_idx during emission.
29954 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29955 function that returns whether a parameter is an out/ref value or not.
29957 (Parameter.ParameterType): The type of the parameter (base,
29958 without ref/out applied).
29960 (Parameter.Resolve): Perform resolution here.
29961 (Parameter.ExternalType): The full type (with ref/out applied).
29963 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29964 support for expressions on the using statement.
29966 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29968 * statement.cs (Using.EmitLocalVariableDecls): Split the
29969 localvariable handling of the using statement.
29971 (Block.EmitMeta): Keep track of variable count across blocks. We
29972 were reusing slots on separate branches of blocks.
29974 (Try.Emit): Emit the general code block, we were not emitting it.
29976 Check the type of the declaration to be an IDisposable or
29977 something that can be implicity converted to it.
29979 Emit conversions if required.
29981 * ecore.cs (EmptyExpression): New utility class.
29982 (Expression.ImplicitConversionExists): New utility function.
29984 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29986 * statement.cs (Using): Implement.
29988 * expression.cs (LocalVariableReference): Support read only variables.
29990 * statement.cs: Remove the explicit emit for the Leave opcode.
29991 (VariableInfo): Add a readonly field.
29993 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29995 * ecore.cs (ConvCast): new class used to encapsulate the various
29996 explicit integer conversions that works in both checked and
29997 unchecked contexts.
29999 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30000 properly generate the overflow opcodes.
30002 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30004 * statement.cs: The correct type for the EmptyExpression is the
30005 element_type, not the variable type. Ravi pointed this out.
30007 2001-12-04 Ravi Pratap <ravi@ximian.com>
30009 * class.cs (Method::Define): Handle PInvoke methods specially
30010 by using DefinePInvokeMethod instead of the usual one.
30012 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30013 above to do the task of extracting information and defining the method.
30015 2001-12-04 Ravi Pratap <ravi@ximian.com>
30017 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30018 of the condition for string type.
30020 (Emit): Move that here.
30022 (ArrayCreation::CheckIndices): Keep string literals in their expression
30025 (EmitDynamicInitializers): Handle strings appropriately.
30027 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30029 * codegen.cs (EmitContext): Replace multiple variables with a
30030 single pointer to the current Switch statement.
30032 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30035 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30039 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30042 (Foreach.Emit): Foreach on arrays was not setting
30043 up the loop variables (for break/continue).
30045 (GotoCase): Semi-implented.
30047 2001-12-03 Ravi Pratap <ravi@ximian.com>
30049 * attribute.cs (CheckAttribute): Handle system attributes by using
30050 Attribute.GetAttributes to examine information we need.
30052 (GetValidPlaces): Same here.
30054 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30056 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30058 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30060 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30062 (Method::Emit): Handle the case when we are a PInvoke method.
30064 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30066 * expression.cs: Use ResolveWithSimpleName on compound names.
30068 2001-12-02 Ravi Pratap <ravi@ximian.com>
30070 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30071 before trying to reduce it.
30073 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30075 * constant.cs (LookupConstantValue): Implement.
30077 (EmitConstant): Use the above in emitting the constant.
30079 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30080 that are user-defined by doing a LookupConstantValue on them.
30082 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30085 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30087 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30089 (BaseAccess.DoResolve): Implement.
30091 (MemberAccess.DoResolve): Split this routine into a
30092 ResolveMemberAccess routine that can be used independently
30094 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30096 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30097 As that share bits of the implementation. Is returns a boolean,
30098 while As returns the Type that is being probed.
30100 2001-12-01 Ravi Pratap <ravi@ximian.com>
30102 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30103 instead of a Literal - much easier.
30105 (EnumInTransit): Remove - utterly useless :-)
30107 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30109 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30111 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30112 chain when we have no associated expression.
30114 2001-11-30 Ravi Pratap <ravi@ximian.com>
30116 * constant.cs (Define): Use Location while reporting the errror.
30118 Also emit a warning when 'new' is used and there is no inherited
30121 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30124 (LookupEnumValue): Implement to lookup an enum member's value and define it
30127 (Populate): Re-write accordingly to use the above routine.
30129 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30131 * expression.cs (This): Fix prototype for DoResolveLValue to
30132 override the base class DoResolveLValue.
30134 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30137 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30138 (we need to load the address of the field here). This fixes
30141 (FieldExpr.DoResolveLValue): Call the DoResolve
30142 function to initialize the Instance expression.
30144 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30145 correctly the GetEnumerator operation on a value type.
30147 * cs-parser.jay: Add more simple parsing error catches.
30149 * statement.cs (Switch): Add support for string switches.
30150 Handle null specially.
30152 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30154 2001-11-28 Ravi Pratap <ravi@ximian.com>
30156 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30158 (declare_local_constant): New helper function.
30160 * statement.cs (AddConstant): Keep a separate record of constants
30162 (IsConstant): Implement to determine if a variable is a constant.
30164 (GetConstantExpression): Implement.
30166 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30168 * statement.cs (IsVariableDefined): Re-write.
30170 2001-11-27 Ravi Pratap <ravi@ximian.com>
30172 * class.cs (TypeContainer::FindMembers): Look for constants
30173 in the case when we are looking for MemberTypes.Field
30175 * expression.cs (MemberAccess::DoResolve): Check that in the
30176 case we are a FieldExpr and a Literal, we are not being accessed
30177 by an instance reference.
30179 * cs-parser.jay (local_constant_declaration): Implement.
30181 (declaration_statement): Implement for constant declarations.
30183 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30185 * statement.cs (Switch): Catch double defaults.
30187 (Switch): More work on the switch() statement
30188 implementation. It works for integral values now, need to finish
30192 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30194 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30195 integer literals into other integer literals. To be used by
30198 2001-11-24 Ravi Pratap <ravi@ximian.com>
30200 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30203 (EmitDynamicInitializers): Cope with the above since we extract data
30204 directly from ArrayData now.
30206 (ExpectInitializers): Keep track of whether initializers are mandatory
30209 (Bounds): Make it a hashtable to prevent the same dimension being
30210 recorded for every element in that dimension.
30212 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30215 Also fix bug which was causing the indices to be emitted in the reverse
30218 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30220 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30221 unfinished. They do not work, because the underlying code is
30224 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30226 * cs-parser.jay: Remove bogus fixme.
30228 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30229 on Switch statement.
30231 2001-11-23 Ravi Pratap <ravi@ximian.com>
30233 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30236 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30237 parameter. Apparently, any expression is allowed.
30239 (ValidateInitializers): Update accordingly.
30241 (CheckIndices): Fix some tricky bugs thanks to recursion.
30243 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30244 I was being completely brain-dead.
30246 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30247 and re-write acordingly.
30249 (DelegateInvocation): Re-write accordingly.
30251 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30253 (MakeByteBlob): Handle types more correctly.
30255 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30256 initialization from expressions but it is incomplete because I am a complete
30259 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30261 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30262 on If. Basically, we have to return `true' (ie, we do return to
30263 our caller) only if both branches of the if return.
30265 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30266 short-circuit operators, handle them as short circuit operators.
30268 (Cast.DoResolve): Resolve type.
30269 (Cast.Cast): Take an expression as the target type.
30271 * cs-parser.jay (cast_expression): Remove old hack that only
30272 allowed a limited set of types to be handled. Now we take a
30273 unary_expression and we resolve to a type during semantic
30276 Use the grammar productions from Rhys to handle casts (this is
30277 not complete like Rhys syntax yet, we fail to handle that corner
30278 case that C# has regarding (-x), but we will get there.
30280 2001-11-22 Ravi Pratap <ravi@ximian.com>
30282 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30283 field which is an array type.
30285 * cs-parser.jay (declare_local_variables): Support array initialization too.
30287 * typemanager.cs (MakeKey): Implement.
30289 (everywhere): Use the above appropriately.
30291 * cs-parser.jay (for_statement): Update for array initialization while
30292 declaring variables.
30294 * ecore.cs : The error message was correct, it's the variable's names that
30295 were misleading ;-) Make the code more readable.
30297 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30298 the correct type etc.
30300 (ConvertExplicit): Handle Enum types by examining the underlying type.
30302 2001-11-21 Ravi Pratap <ravi@ximian.com>
30304 * parameter.cs (GetCallingConvention): Always return
30305 CallingConventions.Standard for now.
30307 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30309 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30310 and `r' after calling DoNumericPromotions.
30312 * ecore.cs: Fix error message (the types were in the wrong order).
30314 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30315 BindingFlags.Instance as well
30317 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30318 implicit int literal conversion in an empty cast so that we
30319 propagate the right type upstream.
30321 (UnboxCast): new class used to unbox value types.
30322 (Expression.ConvertExplicit): Add explicit type conversions done
30325 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30326 the target type before applying the implicit LongLiterals to ULong
30329 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30331 * cs-parser.jay (for_statement): Reworked the way For works: now
30332 we declare manually any variables that are introduced in
30333 for_initializer to solve the problem of having out-of-band code
30334 emition (that is what got for broken).
30336 (declaration_statement): Perform the actual variable declaration
30337 that used to be done in local_variable_declaration here.
30339 (local_variable_declaration): Do not declare anything, just pass
30340 the information on a DictionaryEntry
30342 2001-11-20 Ravi Pratap <ravi@ximian.com>
30344 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30345 re-write of the logic to now make it recursive.
30347 (UpdateIndices): Re-write accordingly.
30349 Store element data in a separate ArrayData list in the above methods.
30351 (MakeByteBlob): Implement to dump the array data into a byte array.
30353 2001-11-19 Ravi Pratap <ravi@ximian.com>
30355 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30358 * constant.cs (Define): Implement.
30360 (EmitConstant): Re-write fully.
30362 Pass in location info.
30364 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30367 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30368 DictionaryEntry since we need location info too.
30370 (constant_declaration): Update accordingly.
30372 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30373 code into another method : UpdateIndices.
30375 2001-11-18 Ravi Pratap <ravi@ximian.com>
30377 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30378 some type checking etc.
30380 2001-11-17 Ravi Pratap <ravi@ximian.com>
30382 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30383 bits to provide dimension info if the user skips doing that.
30385 Update second constructor to store the rank correctly.
30387 2001-11-16 Ravi Pratap <ravi@ximian.com>
30389 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30390 and try to implement.
30392 * ../errors/cs0150.cs : Add.
30394 * ../errors/cs0178.cs : Add.
30396 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30398 * statement.cs: Implement foreach on multi-dimensional arrays.
30400 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30401 name of the params argument.
30403 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30404 initializing the array.
30406 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30407 we can use this elsewhere.
30409 * statement.cs: Finish implementation of foreach for single
30412 * cs-parser.jay: Use an out-of-band stack to pass information
30413 around, I wonder why I need this.
30415 foreach_block: Make the new foreach_block the current_block.
30417 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30418 function used to return a static Parameters structure. Used for
30419 empty parameters, as those are created very frequently.
30421 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30423 2001-11-15 Ravi Pratap <ravi@ximian.com>
30425 * interface.cs : Default modifier is private, not public. The
30426 make verify test passes again.
30428 2001-11-15 Ravi Pratap <ravi@ximian.com>
30430 * support.cs (ReflectionParameters): Fix logic to determine
30431 whether the last parameter is a params one. Test 9 passes again.
30433 * delegate.cs (Populate): Register the builders we define with
30434 RegisterParameterForBuilder. Test 19 passes again.
30436 * cs-parser.jay (property_declaration): Reference $6 instead
30437 of $$ to get at the location.
30439 (indexer_declaration): Similar stuff.
30441 (attribute): Ditto.
30443 * class.cs (Property): Register parameters for the Get and Set methods
30444 if they exist. Test 23 passes again.
30446 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30447 call to EmitArguments as we are sure there aren't any params arguments.
30448 Test 32 passes again.
30450 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30451 IndexOutOfRangeException.
30453 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30454 Test 33 now passes again.
30456 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30458 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30459 broke a bunch of things. Will have to come up with a better way
30460 of tracking locations.
30462 * statement.cs: Implemented foreach for single dimension arrays.
30464 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30466 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30467 an error. This removes the lookup from the critical path.
30469 * cs-parser.jay: Removed use of temporary_loc, which is completely
30472 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30474 * support.cs (ReflectionParameters.ParameterModifier): Report
30475 whether the argument is a PARAMS argument or not.
30477 * class.cs: Set the attribute `ParamArrayAttribute' on the
30478 parameter argument.
30480 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30481 and cons_param_array_attribute (ConstructorInfo for
30482 ParamArrayAttribute).,
30484 * codegen.cs: Emit the return using the `Return' statement, that
30485 way we can report the error correctly for missing return values.
30487 * class.cs (Method.Emit): Clean up.
30489 * expression.cs (Argument.Resolve): Take another argument: the
30490 location where this argument is used. Notice that this is not
30491 part of the "Argument" class as to reduce the size of the
30492 structure (we know the approximate location anyways).
30494 Test if the argument is a variable-reference, if not, then
30495 complain with a 206.
30497 (Argument.Emit): Emit addresses of variables.
30499 (Argument.FullDesc): Simplify.
30501 (Invocation.DoResolve): Update for Argument.Resolve.
30503 (ElementAccess.DoResolve): ditto.
30505 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30506 method should be virtual, as this method is always virtual.
30508 (NewDelegate.DoResolve): Update for Argument.Resolve.
30510 * class.cs (ConstructorInitializer.DoResolve): ditto.
30512 * attribute.cs (Attribute.Resolve): ditto.
30514 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30516 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30518 * expression.cs (ParameterReference): Drop IStackStorage and implement
30519 IAssignMethod instead.
30521 (LocalVariableReference): ditto.
30523 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30524 IAssignMethod instead.
30526 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30528 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30529 enumerations that are used in heavily used structures derive from
30530 byte in a laughable and pathetic attempt to reduce memory usage.
30531 This is the kind of pre-optimzations that you should not do at
30532 home without adult supervision.
30534 * expression.cs (UnaryMutator): New class, used to handle ++ and
30535 -- separatedly from the other unary operators. Cleans up the
30536 code, and kills the ExpressionStatement dependency in Unary.
30538 (Unary): Removed `method' and `Arguments' from this class, making
30539 it smaller, and moving it all to SimpleCall, so I can reuse this
30540 code in other locations and avoid creating a lot of transient data
30541 strucutres when not required.
30543 * cs-parser.jay: Adjust for new changes.
30545 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30547 * enum.cs (Enum.Populate): If there is a failure during
30550 * cs-parser.jay (opt_enum_base): we used to catch type errors
30551 here, but this is really incorrect. The type error should be
30552 catched during semantic analysis.
30554 2001-12-11 Ravi Pratap <ravi@ximian.com>
30556 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30557 current_local_parameters as expected since I, in my stupidity, had forgotten
30560 * attribute.cs (GetValidPlaces): Fix stupid bug.
30562 * class.cs (Method::Emit): Perform check on applicability of attributes.
30564 (Constructor::Emit): Ditto.
30566 (Field::Emit): Ditto.
30568 (Field.Location): Store location information.
30570 (Property, Event, Indexer, Operator): Ditto.
30572 * cs-parser.jay (field_declaration): Pass in location for each field.
30574 * ../errors/cs0592.cs : Add.
30576 2001-11-12 Ravi Pratap <ravi@ximian.com>
30578 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30580 (InitCoreTypes): Update accordingly.
30582 (RegisterAttrType, LookupAttr): Implement.
30584 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30585 info about the same.
30587 (Resolve): Update to populate the above as necessary.
30589 (Error592): Helper.
30591 (GetValidPlaces): Helper to the above.
30593 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30595 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30597 2001-11-12 Ravi Pratap <ravi@ximian.com>
30599 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30601 * ../errors/cs0617.cs : Add.
30603 2001-11-11 Ravi Pratap <ravi@ximian.com>
30605 * enum.cs (Emit): Rename to Populate to be more consistent with what
30606 we expect it to do and when exactly it is called.
30608 * class.cs, rootcontext.cs : Update accordingly.
30610 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30611 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30613 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30615 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30616 of a fieldinfo using the above, when dealing with a FieldBuilder.
30618 2001-11-10 Ravi Pratap <ravi@ximian.com>
30620 * ../errors/cs0031.cs : Add.
30622 * ../errors/cs1008.cs : Add.
30624 * ../errrors/cs0543.cs : Add.
30626 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30629 (FindMembers): Implement.
30631 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30632 enums and delegates too.
30634 (enum_types): Rename to builder_to_enum.
30636 (delegate_types): Rename to builder_to_delegate.
30638 * delegate.cs (FindMembers): Implement.
30640 2001-11-09 Ravi Pratap <ravi@ximian.com>
30642 * typemanager.cs (IsEnumType): Implement.
30644 * enum.cs (Emit): Re-write parts to account for the underlying type
30645 better and perform checking etc.
30647 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30648 of the underlying type.
30650 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30653 * enum.cs (error31): Helper to report error #31.
30655 * cs-parser.jay (enum_declaration): Store location of each member too.
30657 * enum.cs (member_to_location): New hashtable.
30659 (AddEnumMember): Update location hashtable.
30661 (Emit): Use the location of each member while reporting errors.
30663 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30665 * cs-parser.jay: A for_initializer if is a
30666 local_variable_declaration really ammount to have an implicit
30667 block with the variable declaration and no initializer for for.
30669 * statement.cs (For.Emit): Cope with null initializers.
30671 This fixes the infinite loop on for initializers.
30673 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30675 * enum.cs: More cleanup.
30677 * ecore.cs: Remove dead code.
30679 * class.cs (Property.Emit): More simplification.
30680 (Event.Emit): ditto.
30682 Reworked to have less levels of indentation.
30684 2001-11-08 Ravi Pratap <ravi@ximian.com>
30686 * class.cs (Property): Emit attributes.
30696 * enum.cs (Emit): Ditto.
30698 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30701 * class.cs (Field, Event, etc.): Move attribute generation into the
30702 Emit method everywhere.
30704 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30705 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30706 as we had no way of defining nested enums !
30708 * rootcontext.cs : Adjust code accordingly.
30710 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30712 2001-11-07 Ravi Pratap <ravi@ximian.com>
30714 * expression.cs (EvalConstantExpression): Move into ecore.cs
30716 * enum.cs (Enum): Rename some members and make them public and readonly
30717 according to our convention.
30719 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30722 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30724 (Enum::Emit): Write a simple version for now which doesn't try to compute
30725 expressions. I shall modify this to be more robust in just a while.
30727 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30729 (TypeContainer::CloseType): Create the Enum types too.
30731 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30733 * expression.cs (EvalConstantExpression): Get rid of completely.
30735 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30736 user-defined values and other cases.
30738 (IsValidEnumLiteral): Helper function.
30740 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30741 out there in the case we had a literal FieldExpr.
30743 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30745 (Literalize): Revamp a bit to take two arguments.
30747 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30749 2001-11-06 Ravi Pratap <ravi@ximian.com>
30751 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30753 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30755 (Resolve): Use the above to ensure we have proper initializers.
30757 2001-11-05 Ravi Pratap <ravi@ximian.com>
30759 * expression.cs (Expression::EvalConstantExpression): New method to
30760 evaluate constant expressions.
30762 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30764 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30766 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30769 (Binary.ResolveOperator): Handle operator != (object a, object b)
30770 and operator == (object a, object b);
30772 (Binary.DoNumericPromotions): Indicate whether the numeric
30773 promotion was possible.
30775 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30778 Made the ArrayAccess implement interface IAssignMethod instead of
30779 IStackStore as the order in which arguments are passed reflects
30782 * assign.cs: Instead of using expr.ExprClass to select the way of
30783 assinging, probe for the IStackStore/IAssignMethod interfaces.
30785 * typemanager.cs: Load InitializeArray definition.
30787 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30788 static data that can be used to initialize arrays.
30790 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30792 * expression.cs: Handle operator== and operator!= for booleans.
30794 (Conditioal.Reduce): Implement reducer for the ?: operator.
30796 (Conditional.Resolve): Implement dead code elimination.
30798 (Binary.Resolve): Catch string literals and return a new
30799 concatenated string.
30801 (Unary.Reduce): Implement reduction of unary expressions.
30803 * ecore.cs: Split out the expression core handling here.
30805 (Expression.Reduce): New method used to perform constant folding
30806 and CSE. This is needed to support constant-expressions.
30808 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30809 targets, and optimize for !x.
30811 2001-11-04 Ravi Pratap <ravi@ximian.com>
30813 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30814 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30815 set custom atttributes.
30817 * literal.cs (Literal::GetValue): New abstract method to return the actual
30818 value of the literal, cast as an object.
30820 (*Literal): Implement GetValue method.
30822 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30823 expressions to the arraylist but objects of type Argument.
30825 * class.cs (TypeContainer::Emit): Emit our attributes too.
30827 (Method::Emit, Constructor::Emit): Ditto.
30829 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30830 to be ignoring earlier.
30832 2001-11-03 Ravi Pratap <ravi@ximian.com>
30834 * attribute.cs (AttributeSection::Define): Implement to do the business
30835 of constructing a CustomAttributeBuilder.
30837 (Attribute): New trivial class. Increases readability of code.
30839 * cs-parser.jay : Update accordingly.
30841 (positional_argument_list, named_argument_list, named_argument): New rules
30843 (attribute_arguments): Use the above so that we are more correct.
30845 2001-11-02 Ravi Pratap <ravi@ximian.com>
30847 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30848 to perform all checks for a method with a params parameter.
30850 (Invocation::OverloadResolve): Update to use the above method and therefore
30851 cope correctly with params method invocations.
30853 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30856 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30857 constructors in our parent too because we can't afford to miss out on
30860 * attribute.cs (AttributeSection): New name for the class Attribute
30862 Other trivial changes to improve readability.
30864 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30865 use the new class names.
30867 2001-11-01 Ravi Pratap <ravi@ximian.com>
30869 * class.cs (Method::Define): Complete definition for params types too
30871 (Indexer::Define): Ditto.
30873 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30874 Cope everywhere with a request for info about the array parameter.
30876 2001-11-01 Ravi Pratap <ravi@ximian.com>
30878 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30880 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30881 local_variable_type to extract the string corresponding to the type.
30883 (local_variable_type): Fixup the action to use the new helper method.
30885 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30888 * expression.cs : Clean out code which uses the above.
30890 2001-10-31 Ravi Pratap <ravi@ximian.com>
30892 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30893 and bale out if necessary by returning a false.
30895 (RegisterProperty): Ditto.
30897 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30898 and print out appropriate error messages.
30900 * interface.cs (everywhere): Ditto.
30902 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30903 location to constructor.
30905 * class.cs (Property, Event, Indexer): Update accordingly.
30907 * ../errors/cs111.cs : Added.
30909 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30910 of a method, as laid down by the spec.
30912 (Invocation::OverloadResolve): Use the above method.
30914 2001-10-31 Ravi Pratap <ravi@ximian.com>
30916 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30917 now take a TypeContainer and a Parameters object.
30919 (ParameterData): Modify return type of ParameterModifier method to be
30920 Parameter.Modifier and not a string.
30922 (ReflectionParameters, InternalParameters): Update accordingly.
30924 * expression.cs (Argument::GetParameterModifier): Same here.
30926 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30927 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30928 symbol in it at all so maybe this is only for now.
30930 2001-10-30 Ravi Pratap <ravi@ximian.com>
30932 * support.cs (InternalParameters): Constructor now takes an extra argument
30933 which is the actual Parameters class.
30935 (ParameterDesc): Update to provide info on ref/out modifiers.
30937 * class.cs (everywhere): Update call to InternalParameters to pass in
30938 the second argument too.
30940 * support.cs (ParameterData): Add ParameterModifier, which is a method
30941 to return the modifier info [ref/out etc]
30943 (InternalParameters, ReflectionParameters): Implement the above.
30945 * expression.cs (Argument::ParameterModifier): Similar function to return
30946 info about the argument's modifiers.
30948 (Invocation::OverloadResolve): Update to take into account matching modifiers
30951 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30952 a new SetFormalParameters object which we pass to InternalParameters.
30954 2001-10-30 Ravi Pratap <ravi@ximian.com>
30956 * expression.cs (NewArray): Merge into the ArrayCreation class.
30958 2001-10-29 Ravi Pratap <ravi@ximian.com>
30960 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30961 NewUserdefinedArray into one as there wasn't much of a use in having
30964 * expression.cs (Argument): Change field's name to ArgType from Type.
30966 (Type): New readonly property which returns the proper type, taking into
30967 account ref/out modifiers.
30969 (everywhere): Adjust code accordingly for the above.
30971 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30972 whether we are emitting for a ref or out parameter.
30974 * expression.cs (Argument::Emit): Use the above field to set the state.
30976 (LocalVariableReference::Emit): Update to honour the flag and emit the
30979 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30981 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30983 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30985 (ReflectionParameters, InternalParameters): Implement the above method.
30987 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30990 (Invocation::FullMethodDesc): Ditto.
30992 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30994 * cs-parser.jay: Add extra production for the second form of array
30997 * expression.cs (ArrayCreation): Update to reflect the above
31000 * Small changes to prepare for Array initialization.
31002 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31004 * typemanager.cs (ImplementsInterface): interface might be null;
31005 Deal with this problem;
31007 Also, we do store negative hits on the cache (null values), so use
31008 this instead of calling t.GetInterfaces on the type everytime.
31010 2001-10-28 Ravi Pratap <ravi@ximian.com>
31012 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31014 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31015 split functionality out into different classes.
31017 (New::FormArrayType): Move into NewBuiltinArray.
31019 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31022 (NewBuiltinArray): New class to handle creation of built-in arrays.
31024 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31025 account creation of one-dimensional arrays.
31027 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31029 (NewUserdefinedArray::DoResolve): Implement.
31031 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31033 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31034 we maintain inside the TypeManager. This is necessary to perform lookups on the
31037 (LookupType): Update to perform GetType on the module builders too.
31039 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31041 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31043 2001-10-23 Ravi Pratap <ravi@ximian.com>
31045 * expression.cs (New::DoResolve): Implement guts of array creation.
31047 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31049 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31051 * expression.cs: Fix bug I introduced lsat night that broke
31054 (Expression.Resolve): Report a 246 error (can not resolve name)
31055 if we find a SimpleName in the stream.
31057 (Expression.ResolveLValue): Ditto.
31059 (Expression.ResolveWithSimpleName): This function is a variant of
31060 ResolveName, this one allows SimpleNames to be returned without a
31061 warning. The only consumer of SimpleNames is MemberAccess
31063 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31065 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31066 might arrive here. I have my doubts that this is correct.
31068 * statement.cs (Lock): Implement lock statement.
31070 * cs-parser.jay: Small fixes to support `lock' and `using'
31072 * cs-tokenizer.cs: Remove extra space
31074 * driver.cs: New flag --checked, allows to turn on integer math
31077 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31078 Threading.Monitor.Exit
31080 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31082 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31083 Expression Class to be IndexerAccess.
31085 Notice that Indexer::DoResolve sets the eclass to Value.
31087 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31089 * class.cs (TypeContainer::Emit): Emit code for indexers.
31091 * assign.cs (IAssignMethod): New interface implemented by Indexers
31092 and Properties for handling assignment.
31094 (Assign::Emit): Simplify and reuse code.
31096 * expression.cs (IndexerAccess, PropertyExpr): Implement
31097 IAssignMethod, clean up old code.
31099 2001-10-22 Ravi Pratap <ravi@ximian.com>
31101 * typemanager.cs (ImplementsInterface): New method to determine if a type
31102 implements a given interface. Provides a nice cache too.
31104 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31107 (ConvertReferenceExplicit): Ditto.
31109 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31110 various methods, with correct names etc.
31112 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31113 Operator.UnaryNegation.
31115 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31116 we have a unary plus or minus operator.
31118 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31121 * everywhere : update accordingly.
31123 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31126 * class.cs (Method::Define): For the case where we are implementing a method
31127 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31128 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31130 2001-10-21 Ravi Pratap <ravi@ximian.com>
31132 * interface.cs (FindMembers): Implement to work around S.R.E
31135 * typemanager.cs (IsInterfaceType): Implement.
31137 (FindMembers): Update to handle interface types too.
31139 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31140 use IsAssignableFrom as that is not correct - it doesn't work.
31142 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31143 and accordingly override EmitStatement.
31145 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31146 using the correct logic :-)
31148 2001-10-19 Ravi Pratap <ravi@ximian.com>
31150 * ../errors/cs-11.cs : Add to demonstrate error -11
31152 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31154 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31155 then pass this as a hint to ResolveLValue.
31157 * expression.cs (FieldExpr): Add Location information
31159 (FieldExpr::LValueResolve): Report assignment to readonly
31162 (Expression::ExprClassFromMemberInfo): Pass location information.
31164 (Expression::ResolveLValue): Add new method that resolves an
31167 (Expression::DoResolveLValue): Default invocation calls
31170 (Indexers): New class used to keep track of indexers in a given
31173 (IStackStore): Renamed from LValue, as it did not really describe
31174 what this did. Also ResolveLValue is gone from this interface and
31175 now is part of Expression.
31177 (ElementAccess): Depending on the element access type
31179 * typemanager.cs: Add `indexer_name_type' as a Core type
31180 (System.Runtime.CompilerServices.IndexerNameAttribute)
31182 * statement.cs (Goto): Take a location.
31184 2001-10-18 Ravi Pratap <ravi@ximian.com>
31186 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31187 if two delegates are compatible.
31189 (NewDelegate::DoResolve): Update to take care of the case when
31190 we instantiate a delegate from another delegate.
31192 * typemanager.cs (FindMembers): Don't even try to look up members
31193 of Delegate types for now.
31195 2001-10-18 Ravi Pratap <ravi@ximian.com>
31197 * delegate.cs (NewDelegate): New class to take care of delegate
31200 * expression.cs (New): Split the delegate related code out into
31201 the NewDelegate class.
31203 * delegate.cs (DelegateInvocation): New class to handle delegate
31206 * expression.cs (Invocation): Split out delegate related code into
31207 the DelegateInvocation class.
31209 2001-10-17 Ravi Pratap <ravi@ximian.com>
31211 * expression.cs (New::DoResolve): Implement delegate creation fully
31212 and according to the spec.
31214 (New::DoEmit): Update to handle delegates differently.
31216 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31217 because of which we were printing out arguments in reverse order !
31219 * delegate.cs (VerifyMethod): Implement to check if the given method
31220 matches the delegate.
31222 (FullDelegateDesc): Implement.
31224 (VerifyApplicability): Implement.
31226 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31227 delegate invocations too.
31229 (Invocation::Emit): Ditto.
31231 * ../errors/cs1593.cs : Added.
31233 * ../errors/cs1594.cs : Added.
31235 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31237 2001-10-16 Ravi Pratap <ravi@ximian.com>
31239 * typemanager.cs (intptr_type): Core type for System.IntPtr
31241 (InitCoreTypes): Update for the same.
31243 (iasyncresult_type, asynccallback_type): Ditto.
31245 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31248 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31251 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31252 the builders for the 4 members of a delegate type :-)
31254 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31257 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31259 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31261 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31263 * statement.cs (Break::Emit): Implement.
31264 (Continue::Emit): Implement.
31266 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31267 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31268 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31269 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31272 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31273 properties that track the label for the current loop (begin of the
31274 loop and end of the loop).
31276 2001-10-15 Ravi Pratap <ravi@ximian.com>
31278 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31279 use of emitting anything at all.
31281 * class.cs, rootcontext.cs : Get rid of calls to the same.
31283 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31285 (Populate): Define the constructor correctly and set the implementation
31288 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31291 (AddDelegateType): Implement.
31293 (IsDelegateType): Implement helper method.
31295 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31297 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31298 and accordingly handle it.
31300 * delegate.cs (Populate): Take TypeContainer argument.
31301 Implement bits to define the Invoke method. However, I still haven't figured out
31302 how to take care of the native int bit :-(
31304 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31305 Qualify the name of the delegate, not its return type !
31307 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31310 (StandardConversionExists): Checking for array types turns out to be recursive.
31312 (ConvertReferenceExplicit): Implement array conversion.
31314 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31316 2001-10-12 Ravi Pratap <ravi@ximian.com>
31318 * cs-parser.jay (delegate_declaration): Store the fully qualified
31319 name as it is a type declaration.
31321 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31324 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31325 as TypeContainer::DefineType.
31327 (Populate): Method in which all the definition of the various methods (Invoke)
31330 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31333 (CloseDelegate): Finally creates the delegate.
31335 * class.cs (TypeContainer::DefineType): Update to define delegates.
31336 (Populate, Emit and CloseType): Do the same thing here too.
31338 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31339 delegates in all these operations.
31341 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31343 * expression.cs: LocalTemporary: a new expression used to
31344 reference a temporary that has been created.
31346 * assign.cs: Handle PropertyAccess back here, so that we can
31347 provide the proper semantic access to properties.
31349 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31350 a few more explicit conversions.
31352 * modifiers.cs: `NEW' modifier maps to HideBySig.
31354 * expression.cs (PropertyExpr): Make this into an
31355 ExpressionStatement, and support the EmitStatement code path.
31357 Perform get/set error checking, clean up the interface.
31359 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31360 them into toplevel access objects.
31362 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31364 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31367 * typemanager.cs: Keep track here of our PropertyBuilders again to
31368 work around lameness in SRE.
31370 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31372 * expression.cs (LValue::LValueResolve): New method in the
31373 interface, used to perform a second resolution pass for LValues.
31375 (This::DoResolve): Catch the use of this in static methods.
31377 (This::LValueResolve): Implement.
31379 (This::Store): Remove warning, assigning to `this' in structures
31382 (Invocation::Emit): Deal with invocation of
31383 methods on value types. We need to pass the address to structure
31384 methods rather than the object itself. (The equivalent code to
31385 emit "this" for structures leaves the entire structure on the
31386 stack instead of a pointer to it).
31388 (ParameterReference::DoResolve): Compute the real index for the
31389 argument based on whether the method takes or not a `this' pointer
31390 (ie, the method is static).
31392 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31393 value types returned from functions when we need to invoke a
31394 method on the sturcture.
31397 2001-10-11 Ravi Pratap <ravi@ximian.com>
31399 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31400 defining the type in the Modulebuilder or Typebuilder. This is to take
31401 care of nested types which need to be defined on the TypeBuilder using
31402 DefineNestedMethod.
31404 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31405 methods in RootContext, only ported to be part of TypeContainer.
31407 (TypeContainer::GetInterfaceOrClass): Ditto.
31409 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31411 * interface.cs (Interface::DefineInterface): New method. Does exactly
31412 what RootContext.CreateInterface did earlier, only it takes care of nested types
31415 (Interface::GetInterfaces): Move from RootContext here and port.
31417 (Interface::GetInterfaceByName): Same here.
31419 * rootcontext.cs (ResolveTree): Re-write.
31421 (PopulateTypes): Re-write.
31423 * class.cs (TypeContainer::Populate): Populate nested types too.
31424 (TypeContainer::Emit): Emit nested members too.
31426 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31427 instead just use the name argument passed in as it is already fully
31430 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31431 to TypeContainer mapping to see if a type is user-defined.
31433 * class.cs (TypeContainer::CloseType): Implement.
31435 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31436 the default constructor.
31438 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31441 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31443 * interface.cs (CloseType): Create the type here.
31445 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31448 Remove all the methods which are now in TypeContainer.
31450 2001-10-10 Ravi Pratap <ravi@ximian.com>
31452 * delegate.cs (Define): Re-write bits to define the delegate
31455 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31457 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31459 * expression.cs (ImplicitReferenceConversion): handle null as well
31460 as a source to convert to any reference type.
31462 * statement.cs (Return): Perform any implicit conversions to
31463 expected return type.
31465 Validate use of return statement.
31467 * codegen.cs (EmitContext): Pass the expected return type here.
31469 * class.cs (Method, Constructor, Property): Pass expected return
31470 type to EmitContext.
31472 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31474 * expression.cs: Make DoResolve take an EmitContext instead of a
31477 Replaced `l' and `location' for `loc', for consistency.
31479 (Error, Warning): Remove unneeded Tc argument.
31481 * assign.cs, literal.cs, constant.cs: Update to new calling
31484 * codegen.cs: EmitContext now contains a flag indicating whether
31485 code is being generated in a static method or not.
31487 * cs-parser.jay: DecomposeQI, new function that replaces the old
31488 QualifiedIdentifier. Now we always decompose the assembled
31489 strings from qualified_identifier productions into a group of
31492 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31494 * rootcontext.cs: Deal with field-less struct types correctly now
31495 by passing the size option to Define Type.
31497 * class.cs: Removed hack that created one static field.
31499 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31501 * statement.cs: Moved most of the code generation here.
31503 2001-10-09 Ravi Pratap <ravi@ximian.com>
31505 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31508 (ElementAccess): Remove useless bits for now - keep checks as the spec
31511 2001-10-08 Ravi Pratap <ravi@ximian.com>
31513 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31514 and start performing checks according to the spec.
31516 2001-10-07 Ravi Pratap <ravi@ximian.com>
31518 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31519 rank_specifiers instead.
31521 (rank_specifiers): Change the order in which the rank specifiers are stored
31523 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31525 * expression.cs (ElementAccess): Implement the LValue interface too.
31527 2001-10-06 Ravi Pratap <ravi@ximian.com>
31529 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31530 except that user defined conversions are not included.
31532 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31533 perform the conversion of the return type, if necessary.
31535 (New::DoResolve): Check whether we are creating an array or an object
31536 and accordingly do the needful.
31538 (New::Emit): Same here.
31540 (New::DoResolve): Implement guts of array creation.
31542 (New::FormLookupType): Helper function.
31544 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31546 * codegen.cs: Removed most of the code generation here, and move the
31547 corresponding code generation bits to the statement classes.
31549 Added support for try/catch/finalize and throw.
31551 * cs-parser.jay: Added support for try/catch/finalize.
31553 * class.cs: Catch static methods having the flags override,
31554 virtual or abstract.
31556 * expression.cs (UserCast): This user cast was not really doing
31557 what it was supposed to do. Which is to be born in fully resolved
31558 state. Parts of the resolution were being performed at Emit time!
31562 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31564 * expression.cs: Implicity convert the result from UserCast.
31566 2001-10-05 Ravi Pratap <ravi@ximian.com>
31568 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31569 prevented it from working correctly.
31571 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31572 merely ConvertImplicit.
31574 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31576 * typemanager.cs: Make the LookupTypeContainer function static,
31577 and not per-instance.
31579 * class.cs: Make static FindMembers (the one that takes a Type
31582 * codegen.cs: Add EmitForeach here.
31584 * cs-parser.jay: Make foreach a toplevel object instead of the
31585 inline expansion, as we need to perform semantic analysis on it.
31587 2001-10-05 Ravi Pratap <ravi@ximian.com>
31589 * expression.cs (Expression::ImplicitUserConversion): Rename to
31590 UserDefinedConversion.
31592 (Expression::UserDefinedConversion): Take an extra argument specifying
31593 whether we look for explicit user conversions too.
31595 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31597 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31599 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31600 with the appropriate arguments.
31602 * cs-parser.jay (cast_expression): Record location too.
31604 * expression.cs (Cast): Record location info.
31606 (Expression::ConvertExplicit): Take location argument.
31608 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31609 to determine if we are doing explicit conversions.
31611 (UserCast::Emit): Update accordingly.
31613 (Expression::ConvertExplicit): Report an error if everything fails.
31615 * ../errors/cs0030.cs : Add.
31617 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31619 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31620 virtual and newslot bits.
31622 * class.cs (TypeContainer::RegisterRequiredImplementations):
31623 Record methods we need.
31625 (TypeContainer::MakeKey): Helper function to make keys for
31626 MethodBases, since the Methodbase key is useless.
31628 (TypeContainer::Populate): Call RegisterRequiredImplementations
31629 before defining the methods.
31631 Create a mapping for method_builders_to_methods ahead of time
31632 instead of inside a tight loop.
31634 (::RequireMethods): Accept an object as the data to set into the
31635 hashtable so we can report interface vs abstract method mismatch.
31637 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31639 * report.cs: Make all of it static.
31641 * rootcontext.cs: Drop object_type and value_type computations, as
31642 we have those in the TypeManager anyways.
31644 Drop report instance variable too, now it is a global.
31646 * driver.cs: Use try/catch on command line handling.
31648 Add --probe option to debug the error reporting system with a test
31651 * report.cs: Add support for exiting program when a probe
31652 condition is reached.
31654 2001-10-03 Ravi Pratap <ravi@ximian.com>
31656 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31657 we do a forcible conversion regardless of type, to check if
31658 ForceConversion returns a null.
31660 (Binary::error19): Use location to report error.
31662 (Unary::error23): Use location here too.
31664 * ../errors/cs0019.cs : Check in.
31666 * ../errors/cs0023.cs : Check in.
31668 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31669 case of a non-null MethodInfo object with a length of 0 !
31671 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31672 an applicable member - according to the spec :-)
31673 Also fix logic to find members in base types.
31675 (Unary::ResolveOperator): Same here.
31677 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31678 as I was getting thoroughly confused between this and error19 :-)
31680 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31681 (::FindMostEncompassedType): Implement.
31682 (::FindMostEncompassingType): Implement.
31683 (::StandardConversionExists): Implement.
31685 (UserImplicitCast): Re-vamp. We now need info about most specific
31686 source and target types so that we can do the necessary conversions.
31688 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31689 mathematical union with no duplicates.
31691 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31693 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31694 in order from base classes to child classes, so that we can in
31695 child classes look up in our parent for method names and
31696 attributes (required for handling abstract, virtual, new, override
31697 constructs: we need to instrospect our base class, and if we dont
31698 populate the classes in order, the introspection might be
31699 incorrect. For example, a method could query its parent before
31700 the parent has any methods and would determine that the parent has
31701 no abstract methods (while it could have had them)).
31703 (RootContext::CreateType): Record the order in which we define the
31706 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31708 * class.cs (TypeContainer::Populate): Also method definitions can
31709 fail now, keep track of this.
31711 (TypeContainer::FindMembers): Implement support for
31712 DeclaredOnly/noDeclaredOnly flag.
31714 (Constructor::Emit) Return the ConstructorBuilder.
31716 (Method::Emit) Return the MethodBuilder.
31717 Check for abstract or virtual methods to be public.
31719 * rootcontext.cs (RootContext::CreateType): Register all the
31720 abstract methods required for the class to be complete and the
31721 interface methods that must be implemented.
31723 * cs-parser.jay: Report error 501 (method requires body if it is
31724 not marked abstract or extern).
31726 * expression.cs (TypeOf::Emit): Implement.
31728 * typemanager.cs: runtime_handle_type, new global type.
31730 * class.cs (Property::Emit): Generate code for properties.
31732 2001-10-02 Ravi Pratap <ravi@ximian.com>
31734 * expression.cs (Unary::ResolveOperator): Find operators on base type
31735 too - we now conform exactly to the spec.
31737 (Binary::ResolveOperator): Same here.
31739 * class.cs (Operator::Define): Fix minor quirk in the tests.
31741 * ../errors/cs0215.cs : Added.
31743 * ../errors/cs0556.cs : Added.
31745 * ../errors/cs0555.cs : Added.
31747 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31749 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31750 single integer which is really efficient
31752 2001-10-01 Ravi Pratap <ravi@ximian.com>
31754 * expression.cs (Expression::ImplicitUserConversion): Use location
31755 even in the case when we are examining True operators.
31757 * class.cs (Operator::Define): Perform extensive checks to conform
31758 with the rules for operator overloading in the spec.
31760 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31761 some of the other conversions mentioned in the spec.
31763 * typemanager.cs (array_type): New static member for the System.Array built-in
31766 (cloneable_interface): For System.ICloneable interface.
31768 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31769 we start resolving the tree and populating types.
31771 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31773 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31775 * expression.cs (Expression::ExprClassFromMemberInfo,
31776 Expression::Literalize): Create literal expressions from
31777 FieldInfos which are literals.
31779 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31780 type casts, because they were wrong. The test suite in tests
31783 (ImplicitNumericConversion): ushort to ulong requires a widening
31786 Int32 constant to long requires widening cast as well.
31788 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31789 for integers because the type on the stack is not i4.
31791 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31793 * expression.cs (report118): require location argument.
31795 * parameter.cs: Do not dereference potential null value.
31797 * class.cs: Catch methods that lack the `new' keyword when
31798 overriding a name. Report warnings when `new' is used without
31799 anything being there to override.
31801 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31803 * class.cs: Only add constructor to hashtable if it is non-null
31804 (as now constructors can fail on define).
31806 (TypeManager, Class, Struct): Take location arguments.
31808 Catch field instance initialization in structs as errors.
31810 accepting_filter: a new filter for FindMembers that is static so
31811 that we dont create an instance per invocation.
31813 (Constructor::Define): Catch errors where a struct constructor is
31816 * cs-parser.jay: Pass location information for various new
31819 * delegate.cs (Delegate): take a location argument.
31821 * driver.cs: Do not call EmitCode if there were problesm in the
31822 Definition of the types, as many Builders wont be there.
31824 * decl.cs (Decl::Decl): Require a location argument.
31826 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31827 into integers, and find the most appropiate integer for it.
31829 * literal.cs: Implement ULongLiteral.
31831 * rootcontext.cs: Provide better information about the location of
31832 failure when CreateType fails.
31834 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31836 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31839 * expression.cs (Binary::CheckShiftArguments): Add missing type
31841 (Binary::ResolveOperator): Add type to the logical and and logical
31842 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31845 (Binary::DoNumericPromotions): In the case where either argument
31846 is ulong (and most signed types combined with ulong cause an
31847 error) perform implicit integer constant conversions as well.
31849 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31851 * expression.cs (UserImplicitCast): Method should always be
31853 (Invocation::BetterConversion): Simplified test for IntLiteral.
31855 (Expression::ImplicitNumericConversion): Split this routine out.
31856 Put the code that performs implicit constant integer conversions
31859 (Expression::Resolve): Become a wrapper around DoResolve so we can
31860 check eclass and type being set after resolve.
31862 (Invocation::Badness): Remove this dead function
31864 (Binary::ResolveOperator): Do not compute the expensive argumnets
31865 unless we have a union for it.
31867 (Probe::Emit): Is needs to do an isinst and then
31868 compare against null.
31870 (::CanConvert): Added Location argument. If the Location argument
31871 is null (Location.Null), then we do not report errors. This is
31872 used by the `probe' mechanism of the Explicit conversion. We do
31873 not want to generate an error for something that the user
31874 explicitly requested to be casted. But the pipeline for an
31875 explicit cast first tests for potential implicit casts.
31877 So for now, if the Location is null, it means `Probe only' to
31878 avoid adding another argument. Might have to revise this
31881 (ClassCast): New class used to type cast objects into arbitrary
31882 classes (used in Explicit Reference Conversions).
31884 Implement `as' as well.
31886 Reverted all the patches from Ravi below: they were broken:
31888 * The use of `level' as a mechanism to stop recursive
31889 invocations is wrong. That was there just to catch the
31890 bug with a strack trace but not as a way of addressing
31893 To fix the problem we have to *understand* what is going
31894 on and the interactions and come up with a plan, not
31895 just get things going.
31897 * The use of the type conversion cache that I proposed
31898 last night had an open topic: How does this work across
31899 protection domains. A user defined conversion might not
31900 be public in the location where we are applying the
31901 conversion, a different conversion might be selected
31902 (ie, private A->B (better) but public B->A (worse),
31903 inside A, A->B applies, but outside it, B->A will
31906 * On top of that (ie, even if the above is solved),
31907 conversions in a cache need to be abstract. Ie, `To
31908 convert from an Int to a Short use an OpcodeCast', not
31909 `To convert from an Int to a Short use the OpcodeCast on
31910 the variable 5' (which is what this patch was doing).
31912 2001-09-28 Ravi Pratap <ravi@ximian.com>
31914 * expression.cs (Invocation::ConversionExists): Re-write to use
31915 the conversion cache
31917 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31918 cache all conversions done, not just user-defined ones.
31920 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31921 to determine if a conversion exists instead of acutually trying to
31922 perform the conversion. It's faster too.
31924 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31925 and only then attempt the implicit conversion.
31927 2001-09-28 Ravi Pratap <ravi@ximian.com>
31929 * expression.cs (ConvertImplicit): Use a cache for conversions
31930 already found. Check level of recursion and bail out if necessary.
31932 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31934 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31935 Export standard methods that we expect for string operations.
31937 * statement.cs (Block::UsageWarning): Track usage of variables and
31938 report the errors for not used variables.
31940 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31943 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31945 * codegen.cs: remove unnneded code
31947 * expression.cs: Removed BuiltinTypeAccess class
31949 Fix the order in which implicit conversions are
31952 The previous fixed dropped support for boxed conversions (adding a
31953 test to the test suite now)
31955 (UserImplicitCast::CanConvert): Remove test for source being null,
31956 that code is broken. We should not feed a null to begin with, if
31957 we do, then we should track the bug where the problem originates
31958 and not try to cover it up here.
31960 Return a resolved expression of type UserImplicitCast on success
31961 rather than true/false. Ravi: this is what I was talking about,
31962 the pattern is to use a static method as a "constructor" for
31965 Also, do not create arguments until the very last minute,
31966 otherwise we always create the arguments even for lookups that
31967 will never be performed.
31969 (UserImplicitCast::Resolve): Eliminate, objects of type
31970 UserImplicitCast are born in a fully resolved state.
31972 * typemanager.cs (InitCoreTypes): Init also value_type
31973 (System.ValueType).
31975 * expression.cs (Cast::Resolve): First resolve the child expression.
31977 (LValue): Add new method AddressOf to be used by
31980 Change the argument of Store to take an EmitContext instead of an
31981 ILGenerator, because things like FieldExpr need to be able to call
31982 their children expression to generate the instance code.
31984 (Expression::Error, Expression::Warning): Sugar functions for
31987 (Expression::MemberLookup): Accept a TypeContainer instead of a
31988 Report as the first argument.
31990 (Expression::ResolvePrimary): Killed. I still want to improve
31991 this as currently the code is just not right.
31993 (Expression::ResolveMemberAccess): Simplify, but it is still
31996 (Unary::Resolve): Catch errors in AddressOf operators.
31998 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31999 index to a byte for the short-version, or the compiler will choose
32000 the wrong Emit call, which generates the wrong data.
32002 (ParameterReference::Emit, ::Store): same.
32004 (FieldExpr::AddressOf): Implement.
32006 * typemanager.cs: TypeManager: made public variable instead of
32009 * driver.cs: document --fatal.
32011 * report.cs (ErrorMessage, WarningMessage): new names for the old
32012 Error and Warning classes.
32014 * cs-parser.jay (member_access): Turn built-in access to types
32015 into a normal simplename
32017 2001-09-27 Ravi Pratap <ravi@ximian.com>
32019 * expression.cs (Invocation::BetterConversion): Fix to cope
32020 with q being null, since this was introducing a bug.
32022 * expression.cs (ConvertImplicit): Do built-in conversions first.
32024 2001-09-27 Ravi Pratap <ravi@ximian.com>
32026 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32028 2001-09-27 Ravi Pratap <ravi@ximian.com>
32030 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32031 I had introduced long ago (what's new ?).
32033 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32034 the work of all the checking.
32035 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32036 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32038 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32039 that is the right way.
32041 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32042 overloading resolution. Use everywhere instead of cutting and pasting code.
32044 (Binary::ResolveOperator): Use MakeUnionSet.
32046 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32047 we have to convert to bool types. Not complete yet.
32049 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32051 * typemanager.cs (TypeManager::CSharpName): support ushort.
32053 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32054 to provide an expression that performsn an implicit constant int
32055 conversion (section 6.1.6).
32056 (Expression::ConvertImplicitRequired): Reworked to include
32057 implicit constant expression conversions.
32059 (Expression::ConvertNumericExplicit): Finished.
32061 (Invocation::Emit): If InstanceExpression is null, then it means
32062 that we perform a call on this.
32064 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32066 * expression.cs (Unary::Emit): Remove some dead code.
32067 (Probe): Implement Resolve and Emit for `is'.
32068 (Expression::ConvertImplicitRequired): Attempt to do constant
32069 expression conversions here. Maybe should be moved to
32070 ConvertImplicit, but I am not sure.
32071 (Expression::ImplicitLongConstantConversionPossible,
32072 Expression::ImplicitIntConstantConversionPossible): New functions
32073 that tell whether is it possible to apply an implicit constant
32074 expression conversion.
32076 (ConvertNumericExplicit): Started work on explicit numeric
32079 * cs-parser.jay: Update operator constants.
32081 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32082 (Parameters::GetSignature): Hook up VerifyArgs here.
32083 (Parameters::VerifyArgs): Verifies that no two arguments have the
32086 * class.cs (Operator): Update the operator names to reflect the
32087 ones that the spec expects (as we are just stringizing the
32090 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32091 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32092 previous usage did only work for our methods.
32093 (Expression::ConvertImplicit): Handle decimal implicit numeric
32094 conversions as well.
32095 (Expression::InternalTypeConstructor): Used to invoke constructors
32096 on internal types for default promotions.
32098 (Unary::Emit): Implement special handling for the pre/post
32099 increment/decrement for overloaded operators, as they need to have
32100 the same semantics as the other operators.
32102 (Binary::ResolveOperator): ditto.
32103 (Invocation::ConversionExists): ditto.
32104 (UserImplicitCast::Resolve): ditto.
32106 2001-09-26 Ravi Pratap <ravi@ximian.com>
32108 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32109 operator, return after emitting body. Regression tests pass again !
32111 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32112 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32113 (Invocation::OverloadResolve): Ditto.
32114 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32116 * everywhere : update calls to the above methods accordingly.
32118 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32120 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32122 * expression.cs (ExpressionStatement): New base class used for
32123 expressions that can appear in statements, so that we can provide
32124 an alternate path to generate expression that do not leave a value
32127 (Expression::Emit, and all the derivatives): We no longer return
32128 whether a value is left on the stack or not. Every expression
32129 after being emitted leaves a single value on the stack.
32131 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32132 facilties of ExpressionStatement if possible.
32134 * cs-parser.jay: Update statement_expression.
32136 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32138 * driver.cs: Change the wording of message
32140 2001-09-25 Ravi Pratap <ravi@ximian.com>
32142 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32143 the type of the expression to the return type of the method if
32144 we have an overloaded operator match ! The regression tests pass again !
32145 (Unary::ResolveOperator): Ditto.
32147 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32148 to find "op_Implicit", not "implicit" ;-)
32149 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32150 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32152 * everywhere : Correct calls to the above accordingly.
32154 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32155 (ConvertImplicit): Do user-defined conversion if it exists.
32157 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32159 * assign.cs: track location.
32160 (Resolve): Use implicit conversions on assignment.
32162 * literal.cs: Oops. Not good, Emit of short access values should
32163 pass (Bytes) or the wrong argument will be selected.
32165 * expression.cs (Unary::Emit): Emit code for -expr.
32167 (Unary::ResolveOperator): Handle `Substract' for non-constants
32168 (substract from zero from the non-constants).
32169 Deal with Doubles as well.
32171 (Expression::ConvertImplicitRequired): New routine that reports an
32172 error if no implicit conversion exists.
32174 (Invocation::OverloadResolve): Store the converted implicit
32175 expressions if we make them
32177 2001-09-24 Ravi Pratap <ravi@ximian.com>
32179 * class.cs (ConstructorInitializer): Take a Location argument.
32180 (ConstructorBaseInitializer): Same here.
32181 (ConstructorThisInitializer): Same here.
32183 * cs-parser.jay : Update all calls accordingly.
32185 * expression.cs (Unary, Binary, New): Take location argument.
32186 Update accordingly everywhere.
32188 * cs-parser.jay : Update all calls to the above to take a location
32191 * class.cs : Ditto.
32193 2001-09-24 Ravi Pratap <ravi@ximian.com>
32195 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32196 (Invocation::BetterConversion): Same here
32197 (Invocation::ConversionExists): Ditto.
32199 (Invocation::ConversionExists): Implement.
32201 2001-09-22 Ravi Pratap <ravi@ximian.com>
32203 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32204 Also take an additional TypeContainer argument.
32206 * All over : Pass in TypeContainer as argument to OverloadResolve.
32208 * typemanager.cs (CSharpName): Update to check for the string type and return
32211 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32214 2001-09-21 Ravi Pratap <ravi@ximian.com>
32216 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32217 (Invocation::BetterFunction): Implement.
32218 (Invocation::BetterConversion): Implement.
32219 (Invocation::ConversionExists): Skeleton, no implementation yet.
32221 Okay, things work fine !
32223 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32225 * typemanager.cs: declare and load enum_type, delegate_type and
32228 * expression.cs (Expression::Emit): Now emit returns a value that
32229 tells whether a value is left on the stack or not. This strategy
32230 might be reveted tomorrow with a mechanism that would address
32231 multiple assignments.
32232 (Expression::report118): Utility routine to report mismatches on
32235 (Unary::Report23): Report impossible type/operator combination
32238 (Unary::IsIncrementableNumber): Whether the type can be
32239 incremented or decremented with add.
32240 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32242 (Unary::ResolveOperator): Implement ++, !, ~,
32244 (Invocation::Emit): Deal with new Emit convetion.
32246 * All Expression derivatives: Updated their Emit method to return
32247 whether they leave values on the stack or not.
32249 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32250 stack for expressions that are statements.
32252 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32254 * expression.cs (LValue): New interface. Must be implemented by
32256 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32259 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32260 interface for generating code, simplifies the code.
32262 2001-09-20 Ravi Pratap <ravi@ximian.com>
32264 * expression.cs (everywhere): Comment out return statements in ::Resolve
32265 methods to avoid the warnings.
32267 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32269 * driver.cs (parse): Report error 2001 if we can not open the
32272 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32275 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32278 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32279 otherwise nested blocks end up with the same index.
32281 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32283 * expression.cs: Instead of having FIXMEs in the Resolve
32284 functions, throw exceptions so it is obvious that we are facing a
32287 * cs-parser.jay (invocation_expression): Pass Location information.
32289 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32290 Use a basename for those routines because .NET does not like paths
32293 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32296 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32298 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32299 are loading the correct data types (throws an exception if not).
32300 (TypeManager::InitCoreTypes): Use CoreLookupType
32302 * expression.cs (Unary::ResolveOperator): return the child
32303 expression for expressions which are just +expr.
32304 (Unary::ResolveOperator): Return negative literals for -LITERAL
32305 expressions (otherwise they are Unary {Literal}).
32306 (Invocation::Badness): Take into account `Implicit constant
32307 expression conversions'.
32309 * literal.cs (LongLiteral): Implement long literal class.
32310 (IntLiteral): export the `Value' of the intliteral.
32312 2001-09-19 Ravi Pratap <ravi@ximian.com>
32314 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32316 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32317 instead of 'Operator'
32319 * expression.cs (Binary::ResolveOperator): Update accordingly.
32320 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32323 * cs-parser.jay (unary_expression): Update to use the new names.
32325 * gen-treedump.cs (GetUnary): Same here.
32327 * expression.cs (Unary::Resolve): Implement.
32328 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32329 operators are found instead of making noise ;-)
32330 (Unary::ResolveOperator): New method to do precisely the same thing which
32331 Binary::ResolveOperator does for Binary expressions.
32332 (Unary.method, .Arguments): Add.
32333 (Unary::OperName): Implement.
32334 (Unary::ForceConversion): Copy and Paste !
32336 * class.cs (Operator::Define): Fix a small bug for the case when we have
32339 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32340 for the inbuilt operators. Only overloading works for now ;-)
32342 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32344 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32345 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32347 * expression.cs (This::Emit): Implement.
32348 (This::Resolve): Implement.
32349 (TypeOf:Resolve): Implement.
32350 (Expression::ResolveSimpleName): Add an implicit this to instance
32352 (MemberAccess::Resolve): Deal with Parameters and Fields.
32353 Bind instance variable to Field expressions.
32354 (FieldExpr::Instance): New field used to track the expression that
32355 represents the object instance.
32356 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32358 (FieldExpr::Emit): Implement.
32360 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32361 the last instruction contains a return opcode to avoid generating
32362 the last `ret' instruction (this generates correct code, and it is
32363 nice to pass the peverify output).
32365 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32366 initializer for static and instance variables.
32367 (Constructor::Emit): Allow initializer to be null in the case of
32368 static constructors. Only emit initializer for instance
32371 (TypeContainer::FindMembers): Return a null array if there are no
32374 Also fix the code for the MemberTypes.Method branch, as it was not
32375 scanning that for operators (or tried to access null variables before).
32377 * assign.cs (Assign::Emit): Handle instance and static fields.
32381 * driver.cs: Stop compilation if there are parse errors.
32383 * cs-parser.jay (constructor_declaration): Provide default base
32384 initializer for non-static constructors.
32385 (constructor_declarator): Do not provide a default base
32386 initializers if none was specified.
32387 Catch the fact that constructors should not have parameters.
32389 * class.cs: Do not emit parent class initializers for static
32390 constructors, that should be flagged as an error.
32392 2001-09-18 Ravi Pratap <ravi@ximian.com>
32394 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32395 Move back code into TypeContainer::Populate.
32397 2001-09-18 Ravi Pratap <ravi@ximian.com>
32399 * class.cs (TypeContainer::AddConstructor): Fix the check to
32400 compare against Name, not Basename.
32401 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32403 * cs-parser.jay : Update accordingly.
32405 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32406 for methods, don't forget to look into the operators too.
32407 (RegisterMethodBuilder): Helper method to take care of this for
32408 methods, constructors and operators.
32409 (Operator::Define): Completely revamp.
32410 (Operator.OperatorMethod, MethodName): New fields.
32411 (TypeContainer::Populate): Move the registering of builders into
32412 RegisterMethodBuilder.
32413 (Operator::Emit): Re-write.
32415 * expression.cs (Binary::Emit): Comment out code path to emit method
32416 invocation stuff for the case when we have a user defined operator. I am
32417 just not able to get it right !
32419 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32421 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32424 (Expression::MemberLookup): Provide a version that allows to
32425 specify the MemberTypes and BindingFlags.
32427 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32428 so it was not fetching variable information from outer blocks.
32430 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32431 Beforefieldinit as it was buggy.
32433 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32434 that Ravi put here.
32436 * class.cs (Constructor::Emit): Only emit if block is not null.
32437 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32438 deal with this by semantically definining it as if the user had
32441 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32442 constructors as we now "emit" them at a higher level.
32444 (TypeContainer::DefineDefaultConstructor): Used to define the
32445 default constructors if none was provided.
32447 (ConstructorInitializer): Add methods Resolve and Emit.
32449 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32451 2001-09-17 Ravi Pratap <ravi@ximian.com>
32453 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32454 the default constructor builder with our hashtable for methodbuilders
32457 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32458 and argument_count is 0 in which case we have a match.
32459 (Binary::ResolveOperator): More null checking and miscellaneous coding
32462 2001-09-17 Ravi Pratap <ravi@ximian.com>
32464 * rootcontext.cs (IsNameSpace): Compare against null.
32466 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32468 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32469 and Unary::Operator.
32471 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32474 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32475 we have overloaded operators.
32476 (Binary::ResolveOperator): Implement the part which does the operator overload
32479 * class.cs (Operator::Emit): Implement.
32480 (TypeContainer::Emit): Emit the operators we have too.
32482 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32483 the case when we have a user-defined operator.
32485 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32487 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32489 2001-09-16 Ravi Pratap <ravi@ximian.com>
32491 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32492 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32493 (Constructor::Emit): Implement.
32494 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32495 if we have no work to do.
32496 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32499 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32500 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32502 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32505 2001-09-15 Ravi Pratap <ravi@ximian.com>
32507 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32509 (Tree::RecordNamespace): Method to do what the name says ;-)
32510 (Tree::Namespaces): Property to get at the namespaces hashtable.
32512 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32515 * rootcontext.cs (IsNamespace): Fixed it :-)
32517 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32519 * class.cs (TypeContainer::FindMembers): Add support for
32521 (MethodCore): New class that encapsulates both the shared aspects
32522 of a Constructor and a Method.
32523 (Method, Constructor): Factored pieces into MethodCore.
32525 * driver.cs: Added --fatal which makes errors throw exceptions.
32526 Load System assembly as well as part of the standard library.
32528 * report.cs: Allow throwing exceptions on errors for debugging.
32530 * modifiers.cs: Do not use `parent', instead use the real type
32531 container to evaluate permission settings.
32533 * class.cs: Put Ravi's patch back in. He is right, and we will
32534 have to cope with the
32536 2001-09-14 Ravi Pratap <ravi@ximian.com>
32538 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32539 FamORAssem, not FamANDAssem.
32541 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32543 * driver.cs: Added --parse option that only parses its input files
32546 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32547 incorrect. IsTopLevel is not used to tell whether an object is
32548 root_types or not (that can be achieved by testing this ==
32549 root_types). But to see if this is a top-level *class* (not
32550 necessarly our "toplevel" container).
32552 2001-09-14 Ravi Pratap <ravi@ximian.com>
32554 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32555 parent instead of a direct call to GetType.
32557 2001-09-14 Ravi Pratap <ravi@ximian.com>
32559 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32560 Modifiers.TypeAttr. This should just be a call to that method.
32562 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32563 object so that we can determine if we are top-level or not.
32565 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32568 * enum.cs (Enum::Define): Ditto.
32570 * modifiers.cs (FieldAttr): Re-write.
32572 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32573 (TypeContainer::HaveStaticConstructor): New property to provide access
32574 to precisely that info.
32576 * modifiers.cs (MethodAttr): Re-write.
32577 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32579 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32580 of top-level types as claimed.
32582 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32584 * expression.cs (MemberLookup): Fruitless attempt to lookup
32585 constructors. Maybe I need to emit default constructors? That
32586 might be it (currently .NET emits this for me automatically).
32587 (Invocation::OverloadResolve): Cope with Arguments == null.
32588 (Invocation::EmitArguments): new function, shared by the new
32589 constructor and us.
32590 (Invocation::Emit): Handle static and instance methods. Emit
32591 proper call instruction for virtual or non-virtual invocations.
32592 (New::Emit): Implement.
32593 (New::Resolve): Implement.
32594 (MemberAccess:Resolve): Implement.
32595 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32596 to track instances.
32597 (FieldExpr::Resolve): Set type.
32599 * support.cs: Handle empty arguments.
32601 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32602 SimpleLookup): Auxiliary routines to help parse a qualifier
32605 Update qualifier_identifier rule.
32607 * codegen.cs: Removed debugging messages.
32609 * class.cs: Make this a global thing, this acts just as a "key" to
32610 objects that we might have around.
32612 (Populate): Only initialize method_builders_to_methods once.
32614 * expression.cs (PropertyExpr): Initialize type from the
32617 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32618 Resolve pattern. Attempt to implicitly convert value to boolean.
32621 * expression.cs: Set the type for the int32/int32 argument case.
32622 (Binary::ResolveOperator): Set the return type to boolean for
32623 comparission operators
32625 * typemanager.cs: Remove debugging print code.
32627 (Invocation::Resolve): resolve type.
32629 * class.cs: Allocate a MemberInfo of the correct size, as the code
32630 elsewhere depends on the test to reflect the correct contents.
32632 (Method::) Keep track of parameters, due to System.Reflection holes
32634 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32637 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32638 of the exact size and return that.
32640 (Class::LookupMethodByBuilder): New function that maps
32641 MethodBuilders to its methods. Required to locate the information
32642 on methods because System.Reflection bit us again.
32644 * support.cs: New file, contains an interface ParameterData and
32645 two implementations: ReflectionParameters and InternalParameters
32646 used to access Parameter information. We will need to grow this
32649 * expression.cs (Invocation::GetParameterData): implement a cache
32650 and a wrapper around the ParameterData creation for methods.
32651 (Invocation::OverloadResolve): Use new code.
32653 2001-09-13 Ravi Pratap <ravi@ximian.com>
32655 * class.cs (TypeContainer::EmitField): Remove and move into
32656 (Field::Define): here and modify accordingly.
32657 (Field.FieldBuilder): New member.
32658 (TypeContainer::Populate): Update accordingly.
32659 (TypeContainer::FindMembers): Implement.
32661 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32663 * statement.cs: (VariableInfo::VariableType): New field to be
32664 initialized with the full type once it is resolved.
32666 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32668 * parameter.cs (GetParameterInfo): Use a type cache to compute
32669 things only once, and to reuse this information
32671 * expression.cs (LocalVariableReference::Emit): Implement.
32672 (OpcodeCast::Emit): fix.
32674 (ParameterReference::Resolve): Implement.
32675 (ParameterReference::Emit): Implement.
32677 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32678 that are expressions need to stay as Expressions.
32680 * typemanager.cs (CSharpName): Returns the C# name of a type if
32683 * expression.cs (Expression::ConvertImplicit): New function that
32684 implements implicit type conversions.
32686 (Expression::ImplicitReferenceConversion): Implements implicit
32687 reference conversions.
32689 (EmptyCast): New type for transparent casts.
32691 (OpcodeCast): New type for casts of types that are performed with
32692 a sequence of bytecodes.
32694 (BoxedCast): New type used for casting value types into reference
32695 types. Emits a box opcode.
32697 (Binary::DoNumericPromotions): Implements numeric promotions of
32698 and computation of the Binary::Type.
32700 (Binary::EmitBranchable): Optimization.
32702 (Binary::Emit): Implement code emission for expressions.
32704 * typemanager.cs (TypeManager): Added two new core types: sbyte
32707 2001-09-12 Ravi Pratap <ravi@ximian.com>
32709 * class.cs (TypeContainer::FindMembers): Method which does exactly
32710 what Type.FindMembers does, only we don't have to use reflection. No
32711 implementation yet.
32713 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32714 typecontainer objects as we need to get at them.
32715 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32717 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32718 typecontainer object.
32720 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32721 of just a Report object.
32723 2001-09-11 Ravi Pratap <ravi@ximian.com>
32725 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32727 (TypeContainer::Populate): Now define the delegates of the type too.
32728 (TypeContainer.Delegates): Property to access the list of delegates defined
32731 * delegates.cs (Delegate::Define): Implement partially.
32733 * modifiers.cs (TypeAttr): Handle more flags.
32735 2001-09-11 Ravi Pratap <ravi@ximian.com>
32737 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32739 (Operator::Define): Re-write logic to get types by using the LookupType method
32740 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32741 (Indexer::Define): Ditto.
32742 (Event::Define): Ditto.
32743 (Property::Define): Ditto.
32745 2001-09-10 Ravi Pratap <ravi@ximian.com>
32747 * class.cs (TypeContainer::Populate): Now define operators too.
32748 (TypeContainer.Operators): New property to access the list of operators
32750 (Operator.OperatorMethodBuilder): New member to hold the method builder
32751 for the operator we are defining.
32752 (Operator::Define): Implement.
32754 2001-09-10 Ravi Pratap <ravi@ximian.com>
32756 * class.cs (Event::Define): Make the prefixes of the accessor methods
32757 addOn_ and removeOn_
32759 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32760 of the location being passed in too. Ideally, this should go later since all
32761 error reporting should be done through the Report object.
32763 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32764 (Populate): Iterate thru the indexers we have and define them too.
32765 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32766 for the get and set accessors.
32767 (Indexer::Define): Implement.
32769 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32771 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32772 my previous implementation, did not work.
32774 * typemanager.cs: Add a couple of missing types (the longs).
32776 * literal.cs: Use TypeManager.bool_type instead of getting it.
32778 * expression.cs (EventExpr): New kind of expressions.
32779 (Expressio::ExprClassFromMemberInfo): finish
32781 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32783 * assign.cs: Emit stores to static fields differently.
32785 2001-09-08 Ravi Pratap <ravi@ximian.com>
32787 * Merge in changes and adjust code to tackle conflicts. Backed out my
32788 code in Assign::Resolve ;-)
32790 2001-09-08 Ravi Pratap <ravi@ximian.com>
32792 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32793 instead Report.Error and also pass in the location.
32794 (CSharpParser::Lexer): New readonly property to return the reference
32795 to the Tokenizer object.
32796 (declare_local_variables): Use Report.Error with location instead of plain
32800 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32801 (Operator.CheckBinaryOperator): Ditto.
32803 * cs-parser.jay (operator_declarator): Update accordingly.
32805 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32806 (CheckBinaryOperator): Same here.
32808 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32809 on the name without any prefixes of namespace names etc. This is because we
32810 already might have something already fully qualified like
32811 'System.Console.WriteLine'
32813 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32815 2001-09-07 Ravi Pratap <ravi@ximian.com>
32817 * cs-tokenizer.cs (location): Return a string which also contains
32820 * expression.cs (ElementAccess): New class for expressions of the
32821 type 'element access.'
32822 (BaseAccess): New class for expressions of the type 'base access.'
32823 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32826 * cs-parser.jay (element_access): Implement action.
32827 (base_access): Implement actions.
32828 (checked_expression, unchecked_expression): Implement.
32830 * cs-parser.jay (local_variable_type): Correct and implement.
32831 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32833 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32835 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32836 name and the specifiers.
32838 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32840 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32841 making them all public ;-)
32843 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32846 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32848 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32850 (FieldExpr, PropertyExprs): New resolved expressions.
32851 (SimpleName::MemberStaticCheck): Perform static checks for access
32852 to non-static fields on static methods. Maybe this should be
32853 generalized for MemberAccesses.
32854 (SimpleName::ResolveSimpleName): More work on simple name
32857 * cs-parser.jay (primary_expression/qualified_identifier): track
32858 the parameter index.
32860 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32861 (EmitContext::EmitBoolExpression): Chain to expression generation
32862 instead of temporary hack.
32863 (::EmitStatementExpression): Put generic expression code generation.
32865 * assign.cs (Assign::Emit): Implement variable assignments to
32866 local variables, parameters and fields.
32868 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32870 * statement.cs (Block::GetVariableInfo): New method, returns the
32871 VariableInfo for a variable name in a block.
32872 (Block::GetVariableType): Implement in terms of GetVariableInfo
32874 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32875 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32877 2001-09-06 Ravi Pratap <ravi@ximian.com>
32879 * cs-parser.jay (operator_declaration): Continue on my quest : update
32880 to take attributes argument.
32881 (event_declaration): Ditto.
32882 (enum_declaration): Ditto.
32883 (indexer_declaration): Ditto.
32885 * class.cs (Operator::Operator): Update constructor accordingly.
32886 (Event::Event): Ditto.
32888 * delegate.cs (Delegate::Delegate): Same here.
32890 * enum.cs (Enum::Enum): Same here.
32892 2001-09-05 Ravi Pratap <ravi@ximian.com>
32894 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32896 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32898 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32899 being passed around as an arraylist.
32900 (Attributes::AddAttribute): Method to add attribute sections.
32902 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32903 (struct_declaration): Update accordingly.
32904 (constant_declaration): Update.
32905 (field_declaration): Update.
32906 (method_header): Update.
32907 (fixed_parameter): Update.
32908 (parameter_array): Ditto.
32909 (property_declaration): Ditto.
32910 (destructor_declaration): Ditto.
32912 * class.cs (Struct::Struct): Update constructors accordingly.
32913 (Class::Class): Ditto.
32914 (Field::Field): Ditto.
32915 (Method::Method): Ditto.
32916 (Property::Property): Ditto.
32917 (TypeContainer::OptAttribute): update property's return type.
32919 * interface.cs (Interface.opt_attributes): New member.
32920 (Interface::Interface): Update to take the extra Attributes argument.
32922 * parameter.cs (Parameter::Parameter): Ditto.
32924 * constant.cs (Constant::Constant): Ditto.
32926 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32927 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32928 the attributes as a parameter.
32929 (InterfaceProperty): Update constructor call.
32930 (InterfaceEvent): Ditto.
32931 (InterfaceMethod): Ditto.
32932 (InterfaceIndexer): Ditto.
32934 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32935 pass the attributes too.
32936 (interface_event_declaration): Ditto.
32937 (interface_property_declaration): Ditto.
32938 (interface_method_declaration): Ditto.
32939 (interface_declaration): Ditto.
32941 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32943 * class.cs (Method::Define): Track the "static Main" definition to
32944 create an entry point.
32946 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32947 EntryPoint if we find it.
32949 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32950 (EmitContext::ig): Make this variable public.
32952 * driver.cs: Make the default output file be the first file name
32953 with the .exe extension.
32955 Detect empty compilations
32957 Handle various kinds of output targets. Handle --target and
32958 rename -t to --dumper.
32960 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32961 methods inherited from Expression return now an Expression. This
32962 will is used during the tree rewriting as we resolve them during
32965 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32966 the spec. Missing entirely is the information about
32967 accessability of elements of it.
32969 (Expression::ExprClassFromMemberInfo): New constructor for
32970 Expressions that creates a fully initialized Expression based on
32971 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32974 (Invocation::Resolve): Begin implementing resolution of invocations.
32976 * literal.cs (StringLiteral): Implement Emit.
32978 2001-09-05 Ravi Pratap <ravi@ximian.com>
32980 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32983 2001-09-04 Ravi Pratap <ravi@ximian.com>
32985 * cs-parser.jay (attribute_arguments): Implement actions.
32986 (attribute): Fix bug in production. Implement action.
32987 (attribute_list): Implement.
32988 (attribute_target): Implement.
32989 (attribute_target_specifier, opt_target_specifier): Implement
32990 (CheckAttributeTarget): New method to check if the attribute target
32992 (attribute_section): Implement.
32993 (opt_attributes): Implement.
32995 * attribute.cs : New file to handle attributes.
32996 (Attribute): Class to hold attribute info.
32998 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32999 (attribute_section): Modify production to use 2 different rules to
33000 achieve the same thing. 1 s/r conflict down !
33001 Clean out commented, useless, non-reducing dimension_separator rules.
33003 * class.cs (TypeContainer.attributes): New member to hold list
33004 of attributes for a type.
33005 (Struct::Struct): Modify to take one more argument, the attribute list.
33006 (Class::Class): Ditto.
33007 (Field::Field): Ditto.
33008 (Method::Method): Ditto.
33009 (Property::Property): Ditto.
33011 * cs-parser.jay (struct_declaration): Update constructor call to
33012 pass in the attributes too.
33013 (class_declaration): Ditto.
33014 (constant_declaration): Ditto.
33015 (field_declaration): Ditto.
33016 (method_header): Ditto.
33017 (fixed_parameter): Ditto.
33018 (parameter_array): Ditto.
33019 (property_declaration): Ditto.
33021 * constant.cs (Constant::Constant): Update constructor similarly.
33022 Use System.Collections.
33024 * parameter.cs (Parameter::Parameter): Update as above.
33026 2001-09-02 Ravi Pratap <ravi@ximian.com>
33028 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33029 (TypeContainer.delegates): New member to hold list of delegates.
33031 * cs-parser.jay (delegate_declaration): Implement the action correctly
33032 this time as I seem to be on crack ;-)
33034 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33036 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33037 tell whether an identifier represents a namespace.
33039 * expression.cs (NamespaceExpr): A namespace expression, used only
33040 temporarly during expression resolution.
33041 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33042 utility functions to resolve names on expressions.
33044 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33046 * codegen.cs: Add hook for StatementExpressions.
33048 * class.cs: Fix inverted test for static flag in methods.
33050 2001-09-02 Ravi Pratap <ravi@ximian.com>
33052 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33053 to make it coincide with MS' number.
33054 (Operator::CheckBinaryOperator): Ditto.
33056 * ../errors/errors.txt : Remove error numbers added earlier.
33058 * ../errors/cs1019.cs : Test case for error # 1019
33060 * ../errros/cs1020.cs : Test case for error # 1020
33062 * cs-parser.jay : Clean out commented cruft.
33063 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33064 used anywhere - non-reducing rule.
33065 (namespace_declarations): Non-reducing rule - comment out.
33067 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33068 with TypeContainer::AddEnum.
33070 * delegate.cs : New file for delegate handling classes.
33071 (Delegate): Class for declaring delegates.
33073 * makefile : Update.
33075 * cs-parser.jay (delegate_declaration): Implement.
33077 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33079 * class.cs (Event::Define): Implement.
33080 (Event.EventBuilder): New member.
33082 * class.cs (TypeContainer::Populate): Update to define all enums and events
33084 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33085 readonly fields for all these cases ?
33087 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33089 * class.cs (Property): Revamp to use the convention of making fields readonly.
33090 Accordingly modify code elsewhere.
33092 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33093 the Define method of the Property class.
33095 * class.cs : Clean up applied patch and update references to variables etc. Fix
33097 (TypeContainer::Populate): Update to define all the properties we have. Also
33098 define all enumerations.
33100 * enum.cs (Define): Implement.
33102 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33104 * cs-parser.jay (overloadable_operator): The semantic value is an
33105 enum of the Operator class.
33106 (operator_declarator): Implement actions.
33107 (operator_declaration): Implement.
33109 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33110 validity of definitions.
33111 (Operator::CheckBinaryOperator): Static method to check for binary operators
33112 (TypeContainer::AddOperator): New method to add an operator to a type.
33114 * cs-parser.jay (indexer_declaration): Added line to actually call the
33115 AddIndexer method so it gets added ;-)
33117 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33118 already taken care of by the MS compiler ?
33120 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33122 * class.cs (Operator): New class for operator declarations.
33123 (Operator::OpType): Enum for the various operators.
33125 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33127 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33128 ostensibly handle this in semantic analysis.
33130 * cs-parser.jay (general_catch_clause): Comment out
33131 (specific_catch_clauses, specific_catch_clause): Ditto.
33132 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33133 (catch_args, opt_catch_args): New productions.
33134 (catch_clause): Rewrite to use the new productions above
33135 (catch_clauses): Modify accordingly.
33136 (opt_catch_clauses): New production to use in try_statement
33137 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33138 and re-write the code in the actions to extract the specific and
33139 general catch clauses by being a little smart ;-)
33141 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33142 Hooray, try and catch statements parse fine !
33144 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33146 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33147 string from the hashtable of variables.
33149 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33150 I end up making that mistake ;-)
33151 (catch_clauses): Fixed gross error which made Key and Value of the
33152 DictionaryEntry the same : $1 !!
33154 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33156 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33158 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33159 when the add and remove accessors are specified.
33161 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33163 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33164 information about indexer_declarator.
33165 (indexer_declarator): Implement actions.
33166 (parsing_indexer): New local boolean used to keep track of whether
33167 we are parsing indexers or properties. This is necessary because
33168 implicit_parameters come into picture even for the get accessor in the
33169 case of an indexer.
33170 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33172 * class.cs (Indexer): New class for indexer declarations.
33173 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33174 (TypeContainer::indexers): New member to hold list of indexers for the
33177 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33179 * cs-parser.jay (add_accessor_declaration): Implement action.
33180 (remove_accessor_declaration): Implement action.
33181 (event_accessors_declaration): Implement
33182 (variable_declarators): swap statements for first rule - trivial.
33184 * class.cs (Event): New class to hold information about event
33186 (TypeContainer::AddEvent): New method to add an event to a type
33187 (TypeContainer::events): New member to hold list of events.
33189 * cs-parser.jay (event_declaration): Implement actions.
33191 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33193 * cs-parser.jay (dim_separators): Implement. Make it a string
33194 concatenating all the commas together, just as they appear.
33195 (opt_dim_separators): Modify accordingly
33196 (rank_specifiers): Update accordingly. Basically do the same
33197 thing - instead, collect the brackets here.
33198 (opt_rank_sepcifiers): Modify accordingly.
33199 (array_type): Modify to actually return the complete type string
33200 instead of ignoring the rank_specifiers.
33201 (expression_list): Implement to collect the expressions
33202 (variable_initializer): Implement. We make it a list of expressions
33203 essentially so that we can handle the array_initializer case neatly too.
33204 (variable_initializer_list): Implement.
33205 (array_initializer): Make it a list of variable_initializers
33206 (opt_array_initializer): Modify accordingly.
33208 * expression.cs (New::NType): Add enumeration to help us
33209 keep track of whether we have an object/delegate creation
33210 or an array creation.
33211 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33212 members to hold data about array creation.
33213 (New:New): Modify to update NewType
33214 (New:New): New Overloaded contructor for the array creation
33217 * cs-parser.jay (array_creation_expression): Implement to call
33218 the overloaded New constructor.
33220 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33222 * class.cs (TypeContainer::Constructors): Return member
33223 constructors instead of returning null.
33225 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33227 * typemanager.cs (InitCoreTypes): Initialize the various core
33228 types after we have populated the type manager with the user
33229 defined types (this distinction will be important later while
33230 compiling corlib.dll)
33232 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33233 on Expression Classification. Now all expressions have a method
33234 `Resolve' and a method `Emit'.
33236 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33237 generation from working. Also add some temporary debugging
33240 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33242 * codegen.cs: Lots of code generation pieces. This is only the
33243 beginning, will continue tomorrow with more touches of polish. We
33244 handle the fundamentals of if, while, do, for, return. Others are
33245 trickier and I need to start working on invocations soon.
33247 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33250 * codegen.cs (EmitContext): New struct, used during code
33251 emission to keep a context. Most of the code generation will be
33254 * cs-parser.jay: Add embedded blocks to the list of statements of
33255 this block. So code generation proceeds in a top down fashion.
33257 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33259 * statement.cs: Add support for multiple child blocks.
33261 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33263 * codegen.cs (EmitCode): New function, will emit the code for a
33264 Block of code given a TypeContainer and its ILGenerator.
33266 * statement.cs (Block): Standard public readonly optimization.
33267 (Block::Block constructors): Link children.
33268 (Block::Child): Child Linker.
33269 (Block::EmitVariables): Emits IL variable declarations.
33271 * class.cs: Drop support for MethodGroups here, delay until
33273 (Method::): Applied the same simplification that I did before, and
33274 move from Properties to public readonly fields.
33275 (Method::ParameterTypes): Returns the parameter types for the
33276 function, and implements a cache that will be useful later when I
33277 do error checking and the semantic analysis on the methods is
33279 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33280 and made a method, optional argument tells whether this is a class
33281 or a structure to apply the `has-this' bit.
33282 (Method::GetCallingConvention): Implement, returns the calling
33284 (Method::Define): Defines the type, a second pass is performed
33285 later to populate the methods.
33287 (Constructor::ParameterTypes): implement a cache similar to the
33288 one on Method::ParameterTypes, useful later when we do semantic
33291 (TypeContainer::EmitMethod): New method. Emits methods.
33293 * expression.cs: Removed MethodGroup class from here.
33295 * parameter.cs (Parameters::GetCallingConvention): new method.
33297 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33299 * class.cs (TypeContainer::Populate): Drop RootContext from the
33302 (Constructor::CallingConvention): Returns the calling convention.
33303 (Constructor::ParameterTypes): Returns the constructor parameter
33306 (TypeContainer::AddConstructor): Keep track of default constructor
33307 and the default static constructor.
33309 (Constructor::) Another class that starts using `public readonly'
33310 instead of properties.
33312 (Constructor::IsDefault): Whether this is a default constructor.
33314 (Field::) use readonly public fields instead of properties also.
33316 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33317 track of static constructors; If none is used, turn on
33318 BeforeFieldInit in the TypeAttributes.
33320 * cs-parser.jay (opt_argument_list): now the return can be null
33321 for the cases where there are no arguments.
33323 (constructor_declarator): If there is no implicit `base' or
33324 `this', then invoke the default parent constructor.
33326 * modifiers.cs (MethodAttr): New static function maps a set of
33327 modifiers flags into a MethodAttributes enum
33328 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33329 MethodAttr, TypeAttr to represent the various mappings where the
33330 modifiers are used.
33331 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33333 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33335 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33338 * interface.cs (PopulateIndexer): Implemented the code generator
33339 for interface indexers.
33341 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33343 * interface.cs (InterfaceMemberBase): Now we track the new status
33346 (PopulateProperty): Implement property population. Woohoo! Got
33347 Methods and Properties going today.
33349 Removed all the properties for interfaces, and replaced them with
33350 `public readonly' fields.
33352 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33354 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33355 initialize their hashtables/arraylists only when they are needed
33356 instead of doing this always.
33358 * parameter.cs: Handle refs and out parameters.
33360 * cs-parser.jay: Use an ArrayList to construct the arguments
33361 instead of the ParameterCollection, and then cast that to a
33364 * parameter.cs: Drop the use of ParameterCollection and use
33365 instead arrays of Parameters.
33367 (GetParameterInfo): Use the Type, not the Name when resolving
33370 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33372 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33373 and instead use public readonly fields.
33375 * class.cs: Put back walking code for type containers.
33377 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33379 * class.cs (MakeConstant): Code to define constants.
33381 * rootcontext.cs (LookupType): New function. Used to locate types
33384 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33386 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33387 this System.Reflection code is. Kudos to Microsoft
33389 * typemanager.cs: Implement a type cache and avoid loading all
33390 types at boot time. Wrap in LookupType the internals. This made
33391 the compiler so much faster. Wow. I rule!
33393 * driver.cs: Make sure we always load mscorlib first (for
33394 debugging purposes, nothing really important).
33396 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33397 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33399 * rootcontext.cs: Lookup types on their namespace; Lookup types
33400 on namespaces that have been imported using the `using' keyword.
33402 * class.cs (TypeContainer::TypeAttr): Virtualize.
33403 (Class::TypeAttr): Return attributes suitable for this bad boy.
33404 (Struct::TypeAttr): ditto.
33405 Handle nested classes.
33406 (TypeContainer::) Remove all the type visiting code, it is now
33407 replaced with the rootcontext.cs code
33409 * rootcontext.cs (GetClassBases): Added support for structs.
33411 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33413 * interface.cs, statement.cs, class.cs, parameter.cs,
33414 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33415 Drop use of TypeRefs, and use strings instead.
33417 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33421 * class.cs (Struct::Struct): set the SEALED flags after
33422 checking the modifiers.
33423 (TypeContainer::TypeAttr): new property, returns the
33424 TypeAttributes for a class.
33426 * cs-parser.jay (type_list): Oops, list production was creating a
33427 new list of base types.
33429 * rootcontext.cs (StdLib): New property.
33430 (GetInterfaceTypeByName): returns an interface by type name, and
33431 encapsulates error handling here.
33432 (GetInterfaces): simplified.
33433 (ResolveTree): Encapsulated all the tree resolution here.
33434 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33437 * driver.cs: Add support for --nostdlib, to avoid loading the
33438 default assemblies.
33439 (Main): Do not put tree resolution here.
33441 * rootcontext.cs: Beginning of the class resolution.
33443 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33445 * rootcontext.cs: Provide better error reporting.
33447 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33449 * rootcontext.cs (CreateInterface): Handle the case where there
33450 are no parent interfaces.
33452 (CloseTypes): Routine to flush types at the end.
33453 (CreateInterface): Track types.
33454 (GetInterfaces): Returns an array of Types from the list of
33455 defined interfaces.
33457 * typemanager.c (AddUserType): Mechanism to track user types (puts
33458 the type on the global type hash, and allows us to close it at the
33461 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33463 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33464 RecordInterface instead.
33466 * cs-parser.jay: Updated to reflect changes above.
33468 * decl.cs (Definition): Keep track of the TypeBuilder type that
33469 represents this type here. Not sure we will use it in the long
33470 run, but wont hurt for now.
33472 * driver.cs: Smaller changes to accomodate the new code.
33474 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33477 * rootcontext.cs (CreateInterface): New method, used to create
33478 the System.TypeBuilder type for interfaces.
33479 (ResolveInterfaces): new entry point to resolve the interface
33481 (CodeGen): Property, used to keep track of the code generator.
33483 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33485 * cs-parser.jay: Add a second production for delegate_declaration
33488 (enum_body): Put an opt_comma here instead of putting it on
33489 enum_body or enum_member_declarations so we can handle trailing
33490 commas on enumeration members. Gets rid of a shift/reduce.
33492 (type_list): Need a COMMA in the middle.
33494 (indexer_declaration): Tell tokenizer to recognize get/set
33496 * Remove old targets.
33498 * Re-add the parser target.
33500 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33502 * cs-parser.jay: Add precendence rules for a number of operators
33503 ot reduce the number of shift/reduce conflicts in the grammar.
33505 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33507 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33510 Get rid of old crufty code.
33512 * rootcontext.cs: Use this to keep track of the parsed
33513 representation and the defined types available to the program.
33515 * gen-treedump.cs: adjust for new convention.
33517 * type.cs: Split out the type manager, and the assembly builder
33520 * typemanager.cs: the type manager will live here now.
33522 * cil-codegen.cs: And the code generator here.
33524 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33526 * makefile: Fixed up for easy making.
33528 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33530 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33533 (unary_expression): Expand pre_increment_expression and
33534 post_decrement_expression to reduce a shift/reduce.
33536 2001-07-11 Simon Cozens
33538 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33540 Improve allow_keyword_as_indent name.
33542 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33544 * Adjustments for Beta2.
33546 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33548 * decl.cs: Added `Define' abstract method.
33549 (InTransit): new property, used to catch recursive definitions.
33551 * interface.cs: Implement `Define'.
33553 * modifiers.cs: Map Modifiers.constants to
33554 System.Reflection.TypeAttribute flags.
33556 * class.cs: Keep track of types and user-defined types.
33557 (BuilderInit): New method for creating an assembly
33558 (ResolveType): New function to launch the resolution process, only
33559 used by interfaces for now.
33561 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33562 that are inserted into the name space.
33564 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33566 * ARGH. I have screwed up my tree so many times due to the use of
33567 rsync rather than using CVS. Going to fix this at once.
33569 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33572 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33574 * Experiment successful: Use System.Type rather that our own
33577 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33579 * cs-parser.jay: Removed nsAliases from here.
33581 Use new namespaces, handle `using XXX;'
33583 * namespace.cs: Reimplemented namespace handling, use a recursive
33584 definition of the class. Now we can keep track of using clauses
33585 and catch invalid using clauses.
33587 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33589 * gen-treedump.cs: Adapted for all the renaming.
33591 * expression.cs (Expression): this class now has a Type property
33592 which returns an expression Type.
33594 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33595 `Type', as this has a different meaning now in the base
33597 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33599 * interface.cs, class.cs: Removed from all the sources the
33600 references to signature computation, as we can not do method
33601 signature computation during the parsing time, as we are not
33602 trying to solve at that point distinguishing:
33606 void a (NS.Blah x) {}
33609 Which depending on the context might be valid or not, as we do not
33610 know if Blah is the same thing as NS.Blah at that point.
33612 * Redid everything so the code uses TypeRefs now instead of
33613 Types. TypeRefs are just temporary type placeholders, that need
33614 to be resolved. They initially have a pointer to a string and the
33615 current scope in which they are used. This is used later by the
33616 compiler to resolve the reference to an actual Type.
33618 * DeclSpace is no longer a CIR.Type, and neither are
33619 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33620 are all DeclSpaces, but no Types.
33622 * type.cs (TypeRefManager): This implements the TypeRef manager,
33623 which keeps track of all the types that need to be resolved after
33624 the parsing has finished.
33626 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33628 * ARGH. We are going to have to store `foreach' as a class rather
33629 than resolving it, as we need to verify error 1579 after name
33630 resolution. *OR* we could keep a flag that says `This request to
33631 IEnumerator comes from a foreach statement' which we can then use
33632 to generate the error.
33634 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33636 * class.cs (TypeContainer.AddMethod): we now add methods to the
33637 MethodGroup instead of the method hashtable.
33639 * expression.cs: Add MethodGroup abstraction, which gets us one
33640 step closer to the specification in the way we handle method
33643 * cs-parser.jay (primary_expression): qualified_identifier now
33644 tried to match up an identifier to a local variable reference or
33645 to a parameter reference.
33647 current_local_parameters is now a parser global variable that
33648 points to the current parameters for the block, used during name
33651 (property_declaration): Now creates an implicit `value' argument to
33654 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33656 * parameter.cs: Do not use `param' arguments as part of the
33657 signature, per the spec.
33659 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33661 * decl.cs: Base class for classes, structs and interfaces. This
33662 is the "Declaration Space"
33664 * cs-parser.jay: Use CheckDef for checking declaration errors
33665 instead of having one on each function.
33667 * class.cs: Factor out some code for handling error handling in
33668 accordance to the "Declarations" section in the "Basic Concepts"
33669 chapter in the ECMA C# spec.
33671 * interface.cs: Make all interface member classes derive from
33672 InterfaceMemberBase.
33674 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33676 * Many things: all interfaces are parsed and generated in
33677 gen-treedump. Support for member variables, constructors,
33678 destructors, properties, constants is there.
33680 Beginning of the IL backend, but very little done, just there for
33683 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33685 * cs-parser.jay: Fix labeled statement.
33687 * cs-tokenizer.cs (escape): Escape " and ' always.
33688 ref_line, ref_name: keep track of the line/filename as instructed
33689 by #line by the compiler.
33692 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33694 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33695 to match the values in System.CodeDOM.
33697 Divid renamed to Divide.
33699 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33701 (Statements.set): remove.
33703 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33706 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33707 falseStatements always have valid values.
33709 * cs-parser.jay: Use System.CodeDOM now.