1 2008-01-25 Marek Safar <marek.safar@gmail.com>
3 * generic.cs: Use full implicit conversion for type inference fixing.
5 2008-01-24 Marek Safar <marek.safar@gmail.com>
7 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
8 Fixed user operator conversions.
10 2008-01-24 Marek Safar <marek.safar@gmail.com>
12 * generic.cs: Do nullable type to null comparison optimization during
15 2008-01-24 Marek Safar <marek.safar@gmail.com>
18 * generic.cs: Enabled l-value resolve on nullable expressions.
20 2008-01-24 Marek Safar <marek.safar@gmail.com>
23 * class.cs: Ingore static ctors with parameters for any further checks.
25 2008-01-24 Marek Safar <marek.safar@gmail.com>
28 * namespace.cs: Removed redundant check.
30 2008-01-24 Marek Safar <marek.safar@gmail.com>
33 * expression.cs: ElementInitializers can be resolved only once.
35 2008-01-24 Marek Safar <marek.safar@gmail.com>
37 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
38 Condition expressions.
40 2008-01-23 Marek Safar <marek.safar@gmail.com>
42 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
44 2008-01-22 Marek Safar <marek.safar@gmail.com>
46 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
49 * generic.cs: Implemented coalesce expression.
51 2008-01-22 Marek Safar <marek.safar@gmail.com>
54 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
55 expression tree type inference.
57 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
60 * expression.cs (Binary.IsUnsignedType): Fix typo.
62 2008-01-22 Marek Safar <marek.safar@gmail.com>
64 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
66 2008-01-22 Marek Safar <marek.safar@gmail.com>
69 * ecore.cs, expression.cs: Wider range of extension method supported
72 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
74 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
75 AssemblyBuilder to operate in compiler context. Fixes mcs part of
78 2008-01-22 Marek Safar <marek.safar@gmail.com>
81 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
83 2008-01-22 Miguel de Icaza <miguel@novell.com>
85 * expression.cs (CreateExpressionTree): Add support for or and
86 logical or, and indent following the coding conventions.
88 * typemanager.cs (LinqExpression): renamed from
89 ExpressionTreeManager, for a shorter name.
91 Use TypeManager.CoreLookupType to lookup types from our core
92 assemblies and turn those into "Type" variables.
94 Consumers that previously used "Namespace" and "Type" from this
95 class should instead use the TypeExpression which is a type that
96 is fully resolved (without involving the regular C# resolution
99 This typically looks like this:
101 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
102 new MemberAccess (texpr, name, type_arguments, loc)
104 This avoids the problem in: #355178
106 2008-01-21 Marek Safar <marek.safar@gmail.com>
108 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
109 feature in parser only as we do in other cases.
111 2008-01-21 Marek Safar <marek.safar@gmail.com>
113 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
114 typemanager.cs: A refactoring of params arguments to reuse existing
115 expressions (params -> array initializer) to emit params argument instead
116 of specialized handling.
117 It was required by expression tree implementation and it has other benefits
118 as well, we now apply same optimization for params arguments as we do for
121 2008-01-18 Marek Safar <marek.safar@gmail.com>
123 A fix for bug #353526
124 * generic.cs: A type inference of params arguments may not required any
125 temporary array creation.
127 2008-01-18 Marek Safar <marek.safar@gmail.com>
129 A fix for bug #353534
130 * generic.cs, ecore.cs, expression.cs: A method group type inference is
131 supported for delegates only.
133 2008-01-18 Marek Safar <marek.safar@gmail.com>
135 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
136 type for more than 1 candidates.
138 2008-01-18 Marek Safar <marek.safar@gmail.com>
140 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
143 2008-01-16 Marek Safar <marek.safar@gmail.com>
145 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
146 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
147 operator) expressions.
149 2008-01-16 Zoltan Varga <vargaz@gmail.com>
151 * statement.cs: Avoid declaring an IL variable for this_variable since it is
152 not accessed from the generated IL.
154 2008-01-14 Marek Safar <marek.safar@gmail.com>
156 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
157 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
158 statement.cs: The first expression tree implementation drop, mostly
161 2008-01-14 Marek Safar <marek.safar@gmail.com>
163 * ecore.cs (IsNestedChild): Refactored.
165 2008-01-11 Marek Safar <marek.safar@gmail.com>
167 * lambda.cs: Don't use a cast on unknown expression statement.
169 2008-01-10 Geoff Norton <gnorton@novell.com>
171 * cs-tokenizer.cs: One more token to distinguish between method and lambda
174 2008-01-09 Marek Safar <marek.safar@gmail.com>
176 * doc.cs: Report better /doc crash details.
178 2008-01-09 Marek Safar <marek.safar@gmail.com>
180 A fix for bug #352536
181 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
183 2008-01-08 Marek Safar <marek.safar@gmail.com>
185 A fix for bug #352287
186 * ecore.cs, expression.cs: Do `this' access checking in all member access
189 2008-01-08 Marek Safar <marek.safar@gmail.com>
191 * rootcontext.cs, driver.cs: Switch to linq mode by default.
193 * report.cs: Reset message stacks.
195 2008-01-08 Marek Safar <marek.safar@gmail.com>
197 * generic.cs (InferInPhases): Correctly calculate params position.
199 2008-01-08 Marek Safar <marek.safar@gmail.com>
201 * cs-tokenizer.cs: No need to parse full string when parsing lambda
204 2008-01-07 Marek Safar <marek.safar@gmail.com>
206 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
208 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
210 * driver.cs: Updated --help option.
212 2008-01-07 Marek Safar <marek.safar@gmail.com>
214 * generic.cs (InferParamsTypeArguments): Removed.
215 (InferInPhases): Add params type inference.
216 (LowerBoundInference): Fixed scoring mechanism.
218 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
220 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
222 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
223 byte array for unsigned "baked" assemblies.
225 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
227 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
228 array for assemblies that are not strongnamed.
230 2008-01-04 Marek Safar <marek.safar@gmail.com>
232 A fix for bug #351481
233 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
234 declaring type for nested generic types.
236 2008-01-04 Marek Safar <marek.safar@gmail.com>
238 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
241 2008-01-03 Marek Safar <marek.safar@gmail.com>
243 A fix for bug #351047
244 * expression.cs (Binary.ResolveOperator): Allow equality operators between
245 null and structs only when equality and inequality operators are defined
246 either as an user-operators or predefined operators.
248 2008-01-03 Marek Safar <marek.safar@gmail.com>
250 A fix for bug #351047
251 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
253 2008-01-03 Marek Safar <marek.safar@gmail.com>
255 A fix for bug #351257
256 * cs-tokenizer.cs: Advance line number for '\r' correctly.
258 2008-01-03 Marek Safar <marek.safar@gmail.com>
260 A fix for bug #351157
261 * class.cs (Using): Fixed yet another broken cloning.
263 (Block): Put back more sensible default value for statements.
265 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
267 * codegen.cs: Allow AssemblyVersion with only major version component.
270 2007-12-29 Marek Safar <marek.safar@gmail.com>
272 A fix for bug #324654
273 * class.cs: Use FullName property as member name.
275 2007-12-28 Marek Safar <marek.safar@gmail.com>
277 A fix for bug #342117
278 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
279 constructor constraint.
281 2007-12-28 Marek Safar <marek.safar@gmail.com>
283 A fix for bug #338273
284 * class.cs (ProbertyBase): Access modifier checks are required for overrides
287 2007-12-28 Marek Safar <marek.safar@gmail.com>
289 A fix for bug #350839
290 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
292 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
294 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
297 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
299 * statement.cs: Changed some Hashtables to use HybridDictionaries
300 instead. It was observed that some HashTables only contained a few
301 items in the vast majority of cases. Since HybridDictionary is
302 more efficient on small sets (<10 elements), "known_variables"
303 from class ExplicitBlock as well as "labels" and "constants " from
304 class Block were changed to HybridDictionaries.
306 Atsai results: (56216kb->54987kb)
308 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
311 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
313 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
316 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
318 * expression.cs: foreach loop to for loop, saved on allocation of
319 enumerator (59333kb->59141kb)
321 * statement.cs. Changed foreach loops to for loops, saved on
322 allocation of enumerator (59141kb->59006kb)
324 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
325 when constructed with no specified capacity. This was causing a
326 few ArrayLists to allocate more memory than they would potentially
327 need in the Block class and MemberCache class. Setting the
328 ArrayLists to construct with a capacity of 1 saves some
329 memory. (56216kb->55585kb)
331 2007-12-27 Marek Safar <marek.safar@gmail.com>
333 A fix for bug #347189 (2nd issue)
334 * expression.cs (MemberAccess): Nested type can be found in base non-generic
337 2007-12-27 Miguel de Icaza <miguel@novell.com>
339 * report.cs: Do not use colors if stdout and stderr are not a
342 2007-12-27 Marek Safar <marek.safar@gmail.com>
344 A fix for bug #346998
345 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
348 2007-12-27 Marek Safar <marek.safar@gmail.com>
350 A fix for bug #343465
351 * class.cs: Explicit method name for nested types uses dots only.
353 2007-12-27 Marek Safar <marek.safar@gmail.com>
355 A fix for bug #343707
356 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
358 2007-12-27 Marek Safar <marek.safar@gmail.com>
360 * ecore.cs: Report type inference errors only when arguments count matches
363 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
365 * expression.cs, report.cs: New warning.
367 * typemanager.cs: Catch anonymous method type too.
369 2007-12-23 Marek Safar <marek.safar@gmail.com>
371 A fix for bug #346379
372 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
374 2007-12-23 Marek Safar <marek.safar@gmail.com>
376 A fix for bug #347359
377 * expression.cs (Invocation): Don't resolve already resolved expression.
379 2007-12-23 Marek Safar <marek.safar@gmail.com>
381 A fix for bug #347189
382 * class.cs (FixedField): Use non-dependent code only in the define phase.
384 2007-12-23 Marek Safar <marek.safar@gmail.com>
386 A fix for bug #348076
387 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
389 2007-12-22 Marek Safar <marek.safar@gmail.com>
391 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
392 discovered extension methods.
394 2007-12-22 Marek Safar <marek.safar@gmail.com>
396 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
399 2007-12-21 Miguel de Icaza <miguel@novell.com>
401 * report.cs (ErrorMessage): Add support for using colors on
402 terminals that support it.
404 2007-12-21 Marek Safar <marek.safar@gmail.com>
406 * ecore.cs: Use information about expanded params for error reporting.
408 2007-12-21 Marek Safar <marek.safar@gmail.com>
410 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
411 and logic for params overloads.
413 2007-12-15 Miguel de Icaza <miguel@novell.com>
415 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
416 as this is also created from the parser. Fixes #349034
418 2007-12-12 Miguel de Icaza <miguel@novell.com>
420 * statement.cs (Throw.CloneTo): it is valid to have empty
421 expressions for throw.
423 2007-12-03 Marek Safar <marek.safar@gmail.com>
425 * cs-parser.jay: Set delegate constraint parsing region correctly.
427 2007-12-03 Marek Safar <marek.safar@gmail.com>
429 A fix for bug #345467
430 * typemanager.cs (IsEqual): Compare generic parameters position only.
432 2007-11-28 Marek Safar <marek.safar@gmail.com>
434 * expression.cs (BaseAccess): Type arguments can be null.
436 2007-11-27 Raja R Harinath <harinath@gmail.com>
438 * statement.cs (Block.Resolve): Ensure flow-branching tree is
439 consistent even when an error has occured.
440 (Switch.Resolve): Likewise.
442 2007-11-22 Marek Safar <marek.safar@gmail.com>
444 A fix for bug #334505
445 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
448 2007-11-22 Marek Safar <marek.safar@gmail.com>
450 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
451 refactorings required to resolve extension methods correctly when mixing
452 generics and non-generics members.
454 2007-11-20 Marek Safar <marek.safar@gmail.com>
456 A fix for bug #342584
457 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
460 2007-11-19 Marek Safar <marek.safar@gmail.com>
462 A fix for bug #342512
463 * delegate.cs: Use delegate argument expression when is available. Don't
464 emit virtual call when class is sealed.
466 2007-11-16 Marek Safar <marek.safar@gmail.com>
468 A fix for bug #325423
469 * assign.cs (FieldInitializer): Use resolved expression for emit.
471 * class.cs: Print less confusing error message.
473 2007-11-16 Marek Safar <marek.safar@gmail.com>
475 * cs-tokenizer.cs: Removed GMCS ifdefs.
477 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
480 * cs-parser.jay: Disabled nullable check.
482 * generic-mcs: Copied more generic stuff.
484 2007-11-16 Marek Safar <marek.safar@gmail.com>
486 * gcs-parser.jay: Merged to cs-parser.jay.
488 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
489 * *.csproj, *.sources: Updated to use only jay parser file.
491 2007-11-16 Marek Safar <marek.safar@gmail.com>
493 * gcs-parser.jay: Added nullable and default expression feature checks.
495 2007-11-16 Marek Safar <marek.safar@gmail.com>
497 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
498 it fixes many TODOs and hidden bugs.
500 * expression: Removed duplicate error check.
502 2007-11-15 Marek Safar <marek.safar@gmail.com>
504 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
505 implicitly type local variable only when it is used in a declaration.
507 2007-11-15 Marek Safar <marek.safar@gmail.com>
509 * attribute.cs: Use CS0612 for empty strings.
511 2007-11-14 Marek Safar <marek.safar@gmail.com>
513 * lambda.cs, statement.cs: Contextual return may act as a statement.
515 2007-11-14 Marek Safar <marek.safar@gmail.com>
517 A fix for a regression cause by #324222
518 * class.cs: Don't report unused even when it implements an interface.
520 2007-11-13 Marek Safar <marek.safar@gmail.com>
522 A fix for bug #341205
523 * ecore.cs, expression.cs: Method group expression cannot do static
524 method access with an instance reference check before overloading takes
527 2007-11-13 Marek Safar <marek.safar@gmail.com>
529 A fix for bug #325359
530 * class.cs: Use predictable name for automatically generated property.
532 2007-11-12 Marek Safar <marek.safar@gmail.com>
534 A fix for bug #324996
535 * expression.cs (Is): Handle case where D is nullable and T is not
538 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
540 2007-11-12 Marek Safar <marek.safar@gmail.com>
542 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
543 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
544 Flush small error reporting changes.
546 2007-11-09 Marek Safar <marek.safar@gmail.com>
548 A fix for bug #324996
549 * expression.cs: Rewrote Is expression implementation to work with
550 generics, nullable types, anonymous method. A const result expression
551 uses existing infrastructure instead of custom not fully-featured one.
553 2007-11-08 Marek Safar <marek.safar@gmail.com>
555 A fix for bug #340202
556 * class.cs: Consider generics for volatile field.
558 2007-11-08 Marek Safar <marek.safar@gmail.com>
560 A fix for bug #335594
561 * expression.cs: Use conversion rules when handling string addition.
563 2007-11-07 Marek Safar <marek.safar@gmail.com>
565 A fix for bug #336651
566 * expression.cs: Fixed a crash when probing is on.
568 2007-11-07 Marek Safar <marek.safar@gmail.com>
570 A fix for bug #324242
571 * covert.cs: Added a conversion from any nullable-type with an
572 underlying enum-type to the type System.Enum.
574 2007-11-07 Marek Safar <marek.safar@gmail.com>
576 A fix for bug #324222
577 * class.cs: Report all non-used event fields.
579 2007-11-07 Marek Safar <marek.safar@gmail.com>
581 A fix for bug #325161
582 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
583 qualifier for generic types.
585 2007-11-07 Marek Safar <marek.safar@gmail.com>
587 A fix for bug #322971
588 * expression.cs, ecore.cs: Added intermediate result value check for
591 2007-11-07 Marek Safar <marek.safar@gmail.com>
593 A fix for bug #324754
594 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
595 when it was requested.
597 2007-11-07 Marek Safar <marek.safar@gmail.com>
599 A fix for bug #325101
600 * expression.cs: Do type not value comparison for `is' expression.
602 2007-11-07 Marek Safar <marek.safar@gmail.com>
604 A fix for bug #320236
605 * convert.cs: Don't apply user conversion on underlying target type.
607 2007-11-06 Marek Safar <marek.safar@gmail.com>
609 * expression.cs: Don't use unresolved expression for error reporting.
611 2007-11-06 Marek Safar <marek.safar@gmail.com>
613 A fix for bugs #337712, #324490
614 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
615 overloading resolution too.
617 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
618 the process consistent and more robust.
620 * expression.cs, linq.cs, report.cs: Update.
622 2007-11-02 Marek Safar <marek.safar@gmail.com>
624 A fix for bug #332909
625 * attribute.cs: Resolve attributes in correct context using error
628 * rootcontext.cs: Define Obsolete attribute members as core members.
630 2007-11-02 Marek Safar <marek.safar@gmail.com>
632 * statement.cs: Removed unused methods.
634 2007-10-31 Wade Berrier <wberrier@novell.com>
636 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
637 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
640 2007-10-31 Marek Safar <marek.safar@gmail.com>
642 A fix for bug #338102
643 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
644 methods registered as non-generics.
646 2007-10-31 Marek Safar <marek.safar@gmail.com>
648 A fix for bugs #337712, #324490
649 * delegate.cs: Delegate covariance and contravariance is not allowed for
652 2007-10-31 Marek Safar <marek.safar@gmail.com>
654 A fix for bug #337719
655 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
658 2007-10-30 Marek Safar <marek.safar@gmail.com>
660 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
662 2007-10-29 Marek Safar <marek.safar@gmail.com>
664 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
667 2007-10-29 Raja R Harinath <rharinath@novell.com>
669 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
671 2007-10-29 Marek Safar <marek.safar@gmail.com>
673 A fix for bug #334652
674 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
675 extension methods when we have not found the best candidate in normal
678 2007-10-27 Marek Safar <marek.safar@gmail.com>
680 * AssemblyInfo.cs: Keep up-to-date.
682 2007-10-27 Marek Safar <marek.safar@gmail.com>
684 * Makefile: Fixed generics compiler name.
686 2007-10-27 Marek Safar <marek.safar@gmail.com>
688 * lambda.test: removed, lambda parsing is done differently.
690 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
692 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
694 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
696 2007-10-27 Marek Safar <marek.safar@gmail.com>
698 * Makefile, *.sources : All C# compilers are in mcs folder.
700 * *.cs: Use existing 2_1 define for smcs.
702 2007-10-26 Marek Safar <marek.safar@gmail.com>
704 A fix for bug #335847
705 * assign.cs, expression.cs: Couple of changes to avoid creating a
706 temporary variable for each object initializer assignment statement. It
707 simplifies struct initialization too, otherwise two temporary variables
709 Implemented optimization of redundant default element initializers.
711 2007-10-25 Marek Safar <marek.safar@gmail.com>
713 A fix for bug #336766
714 * expression.cs (Class.CheckBase): Use generic name when method is
717 2007-10-25 Marek Safar <marek.safar@gmail.com>
719 A fix for bug #334737
720 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
721 variable and not variable argument for prepared copies.
723 2007-10-24 Marek Safar <marek.safar@gmail.com>
725 A fix for bug #325110
726 * class.cs, expression.cs, attribute.cs: Use open generic method when
727 checking conditional attribute.
729 2007-10-24 Marek Safar <marek.safar@gmail.com>
731 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
732 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
733 FeatureIsNotAvailable.
735 2007-10-24 Marek Safar <marek.safar@gmail.com>
737 ** C# 3.0 Partial methods
739 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
740 methods support. Because of member cache issue with generics only
741 non-generics partial methods are fully supported.
743 2007-10-23 Marek Safar <marek.safar@gmail.com>
745 * class.cs, decl.cs: Rewrote member overloads check to cope with
746 generics and to use member cache for member checking. It also improves
747 performance and fixes remaining overloads issues.
749 2007-10-20 Marek Safar <marek.safar@gmail.com>
751 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
752 roottypes.cs, typemanager.cs:
754 A member cache creation logic changed to add members immediately and
755 not rely on fallback. The member cache is now only prefered way
756 how to access and find type declaration members. It saves 5 MB of memory
757 during MWF compilation and makes code ready for more optimizations and
758 clean-ups, it's also a pre-requirement for partial methods.
760 2007-10-18 Raja R Harinath <harinath@gmail.com>
762 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
763 handling for generic parameters.
765 2007-10-15 Marek Safar <marek.safar@gmail.com>
767 * class.cs (FixedField): Removed redundant volatile check.
769 2007-10-15 Marek Safar <marek.safar@gmail.com>
771 * class.cs, decl.cs: Fixed overload members verification to do only one
772 check per possible collision.
774 2007-10-13 Marek Safar <marek.safar@gmail.com>
776 A fix for bug #325478
777 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
778 and create only one disposable flags container.
780 2007-10-12 Marek Safar <marek.safar@gmail.com>
782 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
783 * statement.cs (Fixed): Fixed variables cloning.
785 2007-10-12 Marek Safar <marek.safar@gmail.com>
787 A fix for bug #333342
788 * class.cs (EventField): Don't mark value type event as synchronized.
790 2007-10-12 Marek Safar <marek.safar@gmail.com>
792 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
793 inference to identify best candidate method correctly.
794 (ProperyExpr): A range variable is read only and cannot be modified.
796 2007-10-11 Marek Safar <marek.safar@gmail.com>
798 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
799 logic to identify best candidate method correctly.
801 2007-10-11 Marek Safar <marek.safar@gmail.com>
803 * location.cs (Equals, GetHashCode): Removed.
805 2007-10-11 Marek Safar <marek.safar@gmail.com>
807 * report.cs: Implemented message recorder. It is used mainly for lambda
808 expressions to capture otherwise swallowed error messages.
810 * anonymous.cs, lambda.cs.cs: Do full parameters check.
812 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
814 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
816 * expression.cs (MemberAccess): Always report lookup failure.
818 * location.cs: Implemented Equals, GetHashCode.
820 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
822 2007-10-10 Jb Evain <jbevain@novell.com>
824 * codegen.cs: re-enable assembly version check.
826 2007-10-09 Marek Safar <marek.safar@gmail.com>
828 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
831 * namespace.cs (UsingAlias): Do correct version check.
833 2007-10-08 Marek Safar <marek.safar@gmail.com>
835 * expresison.cs, ecore.cs: Issue extension method error message when
838 * rootcontext.cs: Added ISO_2 compiler mode option.
840 2007-10-08 Marek Safar <marek.safar@gmail.com>
842 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
845 2007-10-08 Marek Safar <marek.safar@gmail.com>
847 * attribute.cs (GetString, GetBoolean): Work with both literal and
850 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
851 Moved method overload specific methods to MethodGroupExpr.
853 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
854 it should be less memory consuming.
856 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
858 * codegen.cs: remove the assembly version check until the buildbot is
861 2007-10-07 Jb Evain <jbevain@novell.com>
863 * attribute.cs (Attribute.GetString): if the value
864 expression is a StringConstant, return its string value.
866 2007-10-07 Jb Evain <jbevain@novell.com>
868 * typemanager.cs: add `assembly_version_attribute_type`.
869 * codegen.cs: on attribute emission, check that the
870 AssemblyVersionAttribute doesn't overflow.
872 2007-10-05 Marek Safar <marek.safar@gmail.com>
874 A fix for bug #324677
875 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
876 parent container of a scope container with currently resolved one.
878 2007-10-05 Marek Safar <marek.safar@gmail.com>
880 A fix for bug #325534
881 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
884 2007-10-05 Marek Safar <marek.safar@gmail.com>
886 A fix for bug #327504
887 * class.cs (Operator.Define): Refactored implicit and explicit user
888 operator conversion rules.
890 2007-10-05 Marek Safar <marek.safar@gmail.com>
892 A fix for bug #327520
893 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
895 2007-10-04 Marek Safar <marek.safar@gmail.com>
897 A fix for bug #328022
898 * class.cs (MethodData.Define): Use correct method to check whether
899 a method implementents an accessor.
901 2007-10-04 Marek Safar <marek.safar@gmail.com>
903 A fix for bug #330069
904 * statement.cs (Fixed.Resolve): Read the first array element only when
905 an array is instantiated.
907 2007-10-04 Marek Safar <marek.safar@gmail.com>
909 * expression.cs, assign.cs, generics.cs: Print correct operator when
910 compound assignment is used.
912 2007-10-04 Marek Safar <marek.safar@gmail.com>
914 A fix for bug #325841
915 * expression.cs (ArrayAccess): Use full argument cloning only for
916 string compound concatenation.
918 2007-10-03 Marek Safar <marek.safar@gmail.com>
920 A fix for bug #328774
921 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
923 (PropertyExpr.EmitAssign): Fixed string concatenation compound
926 2007-10-03 Raja R Harinath <rharinath@novell.com>
929 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
930 Event accessibility checks here. Remove some bogus code that
931 accidently made GenericMethods work.
932 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
934 2007-09-25 Marek Safar <marek.safar@gmail.com>
936 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
938 * statement.cs (Block): Refactored AddVariable to allow error handling
941 * generic.cs: New stub.
943 2007-09-23 Marek Safar <marek.safar@gmail.com>
945 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
948 2007-09-17 Marek Safar <marek.safar@gmail.com>
950 * class.cs: Use partial container to record whether any partial part
951 contains static field initializer and therefore default contructor has
954 2007-09-14 Marek Safar <marek.safar@gmail.com>
956 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
957 mono-list when only one of two partial parts has defined accessibility
960 2007-09-14 Marek Safar <marek.safar@gmail.com>
964 * class.cs (TypeContainer): Set correct resolve context for all field
967 2007-09-13 Marek Safar <marek.safar@gmail.com>
969 * assign.cs: Fixed a crash when field is resolved twice with an error.
971 * codegen.cs: Changed InFieldInitializer to be flag.
973 * anonymous.cs, ecore.cs, expression.cs: Update after
974 IsInFieldInitializer rename.
976 * const.cs: Removed unused parameter.
978 * class.cs: Changed the way how we resolve and emit field initializers.
979 The field initilizers have to have access to contructor block to emit
980 compiler generated code.
982 2007-09-13 Marek Safar <marek.safar@gmail.com>
984 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
985 generics use TypeContainer instead.
987 2007-09-12 Marek Safar <marek.safar@gmail.com>
989 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
991 * lambda.cs (ResolveParameters): Use more powerful
992 InflateGenericArgument.
994 * parameters.cs: Better exception message.
996 2007-09-10 Marek Safar <marek.safar@gmail.com>
998 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
999 correct expression block type.
1001 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
1003 * expression.cs (Invocation): Extracted method group resolve to
1006 2007-09-07 Marek Safar <marek.safar@gmail.com>
1008 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
1009 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
1011 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
1012 generic extension methods.
1014 2007-09-06 Marek Safar <marek.safar@gmail.com>
1016 A fix for bug #82676 (Do I get it right now?)
1017 * convert.cs (Binary.ResolveOperator): An interface is converted to the
1018 object before a standard conversion is applied.
1020 2007-09-06 Marek Safar <marek.safar@gmail.com>
1022 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
1025 2007-09-05 Marek Safar <marek.safar@gmail.com>
1027 A fix for bug #82676
1028 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
1029 non-generic interface types.
1031 2007-09-05 Marek Safar <marek.safar@gmail.com>
1033 A fix for bug #82690
1034 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
1036 2007-09-05 Marek Safar <marek.safar@gmail.com>
1038 A fix for bug #82571
1039 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
1040 modifier for container based methods.
1042 2007-09-05 Marek Safar <marek.safar@gmail.com>
1044 A fix for bug #82676
1045 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
1046 any interface-type T means to any of interface type T.
1048 2007-09-04 Marek Safar <marek.safar@gmail.com>
1050 * namespace.cs: We have 2 versions of System.Core assembly.
1052 2007-09-04 Marek Safar <marek.safar@gmail.com>
1054 A fix for bug #82652
1055 * class.cs (Class.GetClassBases): Compare types and not expressions.
1057 2007-09-04 Marek Safar <marek.safar@gmail.com>
1059 A fix for bug #82620
1060 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
1061 actually never worked before.
1062 (IndexerAccess): Emit prepared arguments before they are modified.
1064 2007-09-04 Marek Safar <marek.safar@gmail.com>
1066 A fix for bug #82563
1067 * assign.cs: Revert wrong fix.
1069 * expression.cs (VariableReference.EmitAssign): Handle ref reference
1071 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
1072 Instead of ldelema/stdind we have to use temporary variables to handle
1073 cases like String.Concat (params string[]).
1075 2007-08-31 Marek Safar <marek.safar@gmail.com>
1077 * class.cs: EmitAttributes to Emit rename.
1079 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
1081 (MemberCore.HasClsCompliantAttribute): Don't depend on
1082 GetClsCompliantAttributeValue execution.
1084 2007-08-31 Marek Safar <marek.safar@gmail.com>
1086 * anonymous.cs: Use shorter type prefix.
1088 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
1091 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
1092 variables when probing is on.
1094 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
1095 unresolved variables.
1096 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
1097 handle transparent identifiers.
1099 2007-08-26 Marek Safar <marek.safar@gmail.com>
1101 * attribute.cs (IsClsCompliant): Add nullable types test.
1103 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
1105 * doc.cs : catch other types of exception than XmlException to
1106 report CS1570. Fixed bug #82565.
1108 2007-08-23 Marek Safar <marek.safar@gmail.com>
1110 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
1111 The number of delegate parameters has to match.
1112 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
1115 2007-08-21 Marek Safar <marek.safar@gmail.com>
1117 * anonymous.cs (AnonymousMethod): Generate private anonymous method
1118 to fix problem with private arguments.
1120 2007-08-20 Marek Safar <marek.safar@gmail.com>
1122 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
1124 * decl.cs (MemberName): Ignore generic type with no generic arguments.
1126 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
1127 empty. Add cloning suport.
1129 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
1131 2007-08-20 Marek Safar <marek.safar@gmail.com>
1133 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
1134 to create EmptyCast. It handles EmptyConstantCast specialization for
1137 2007-08-18 Marek Safar <marek.safar@gmail.com>
1139 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
1140 (EmitArrayArgument): One routine for array arguments.
1141 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
1143 2007-08-17 Marek Safar <marek.safar@gmail.com>
1145 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
1147 2007-08-17 Marek Safar <marek.safar@gmail.com>
1149 * anonymous.cs: MemberLookupFinal update.
1151 * class.cs (ConstructorInitializer): Is expression based.
1153 * delegate.cs: MethodGroupExpr update.
1155 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
1157 (Error_MemberLookupFailed): Customizable error override.
1158 (MethodGroupExpr): Keep queried type for later usage.
1159 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
1162 * expression.cs: Error_MemberLookupFailed refactoring.
1163 (New.DoResolve): Resolve as much as possible.
1164 (ElementInitializer.Error_MemberLookupFailed): Object initializer
1165 customization for invalid member types.
1167 * statement.cs: MethodGroupExpr update.
1169 2007-08-16 Marek Safar <marek.safar@gmail.com>
1171 * modifier.cs (Check): Check all modifiers and not only accessibility
1174 2007-08-16 Marek Safar <marek.safar@gmail.com>
1176 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
1177 type and not an expression.
1179 2007-08-16 Marek Safar <marek.safar@gmail.com>
1181 * statement.cs (Catch.Clone): Type and variable can be null.
1183 2007-08-16 Marek Safar <marek.safar@gmail.com>
1185 A fix for bug #81979
1186 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
1187 I am really not sure whether this is the best fix.
1189 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
1192 2007-08-14 Marek Safar <marek.safar@gmail.com>
1194 ** C# 3.0 Object and collection initializers (major re-write)
1196 * assign.cs (DoResolve): Initializers are not assign related.
1198 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
1199 used during collection or object initialization.
1201 * expression.cs (Error_InvalidArguments): Add initializers specific
1202 messages. More will come later because it requires some general
1204 (New.DoResolve): Better error handling for unsafe types.
1205 (EmptyExpressionStatement): New class.
1206 (ElementInitializer): An object initializer expression.
1207 (CollectionElementInitializer): A collection initializer expression.
1208 (CollectionOrObjectInitializers): A block of object or collection
1210 (NewInitialize): New expression with element/object initializers.
1212 * statement.cs: Reverted object/collection initializer hacks.
1214 * typemanager.cs (CSharpName): Filter __arglist type.
1216 2007-08-09 Marek Safar <marek.safar@gmail.com>
1218 ** C# 3.0 Anonymous Types (update to the latest standard)
1220 * expression.cs (Binary.ResolveOperator): Threat all null based types
1222 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
1223 (AnonymousTypeParameter): Updated.
1225 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
1226 (AnonymousTypeClass): New anonymous type container.
1228 * class.cs (AddField): Return operation result.
1230 * generic.cs: Another empty TypeArguments overload.
1232 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
1233 are stored at top of normal hierarchy.
1235 * typemanager.cs (CSharpName): Filter anonymous types.
1237 2007-08-09 Marek Safar <marek.safar@gmail.com>
1239 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
1240 as single Concat call. How could we miss that :-(
1242 2007-08-08 Marek Safar <marek.safar@gmail.com>
1244 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
1246 2007-08-07 Miguel de Icaza <miguel@novell.com>
1248 * expression.cs: Fix the previous commit, the creation of the
1249 arguments array list needs also to be conditional on the arguments
1252 * class.cs: Add a little bit of help to help narrow down problems.
1254 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
1255 not try to copy in that case.
1257 * driver.cs: When building SMCS, include a new different set of
1258 default assemblies here. Do this here so we can control whether
1259 to include the default assemblies with /noconfig.
1261 2007-08-03 Marek Safar <marek.safar@gmail.com>
1263 A fix for bug #81979
1264 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
1267 2007-08-03 Marek Safar <marek.safar@gmail.com>
1269 A fix for bug #82300
1271 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
1272 we are in probing scope.
1274 2007-08-03 Marek Safar <marek.safar@gmail.com>
1276 A fix for bug #82301
1278 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
1279 (Statement.CloneTo): Clone and not map children blocks.
1281 2007-08-03 Marek Safar <marek.safar@gmail.com>
1283 A fix for bug #82299
1285 * expression.cs (LocalVariableReference.CloneTo): Remap local info
1288 * statement.cs (Statement.CloneTo): Clone variables before statements
1289 to allow remaping of local variables.
1291 2007-08-03 Marek Safar <marek.safar@gmail.com>
1293 A fix for bug #82296
1296 * report.cs: Log crash details for future clone problems.
1298 * statement.cs (Return.Clone): Don't clone non-existent expression.
1300 2007-08-03 Raja R Harinath <harinath@gmail.com>
1302 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
1303 (Class.AddBasesForPart): Move CS0537 check here from ...
1304 * cs-parser.jay (class_declaration): ... here. Move calling of
1305 'AddBasesForPart' to ...
1306 (class_bases): ... here.
1307 (struct_declaration, interface_declaration): Update to changes.
1309 2007-08-02 Marek Safar <marek.safar@gmail.com>
1311 A fix for bug #81923
1313 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
1314 conversion is allowed.
1316 2007-08-02 Marek Safar <marek.safar@gmail.com>
1318 A fix for bug #81564
1320 * ecore.cs (EventExpr): Add IsBase handling.
1322 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
1325 2007-08-02 Raja R Harinath <harinath@gmail.com>
1327 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
1328 * cs-parser.jay: Some whitespace cleanups.
1329 (current_delegate): New.
1331 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
1332 a dummy code block, and use 'type_name' instead of 'member_name'.
1333 (interface_declaration, class_declaration): Likewise.
1334 (delegate_declaration): Likewise. Rearrange slightly and use
1336 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
1337 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
1339 2007-08-02 Marek Safar <marek.safar@gmail.com>
1341 A fix for bug #82039
1343 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
1346 * typemanager.cs (CSharpName): Split to string overload.
1348 2007-08-02 Marek Safar <marek.safar@gmail.com>
1351 * report.cs: Updated warning CS0472.
1353 2007-08-01 Marek Safar <marek.safar@gmail.com>
1355 A fix for bug #82181
1357 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
1359 2007-08-01 Marek Safar <marek.safar@gmail.com>
1361 A fix for bug #82277
1362 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
1364 2007-08-01 Marek Safar <marek.safar@gmail.com>
1366 ** C# 3.0 Type Inference (major bits are working)
1368 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
1369 (.ImplicitStandardConversionExists): Uses compatible.
1370 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
1371 (.InferReturnType): New method.
1372 (.Compatible): Refactored.
1373 (.ResolveParameters): Uses factory to create resolved parameters.
1374 (.CompatibleMethod): Add probing mode support.
1375 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
1376 clearly distinguish between 2 different operations.
1377 (LambdaMethod): Moved to lambda.cs.
1378 (AnonymousMethod): Removed unused fields and methods.
1379 (AnonymousDelegate): Simplified.
1381 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
1383 * convert. cs (ImplicitConversionStandard): Compatible works differently.
1385 * delegate.cs (Delegate): New mehods to reduce code duplication.
1386 (.GetConstructor): New method.
1387 (.GetInvokeMethod): New method.
1388 (DelegateCreation): Updated.
1390 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
1392 (OverloadResolve): Made probing little bit faster.
1394 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
1397 * generic.cs (TypeInferenceContext): Dummy implementation.
1399 * iterators.cs: Updated after Resolve/Define rename.
1401 * lambda.cs (LambdaExpression)
1402 (.ResolveParameters): Handles both type of arguments and type inference too.
1404 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
1405 (InflateTypes): Updated.
1407 * support.cs (InflateTypes): Changed signature and updated.
1409 * typemanager.cs (LookupMemberCache): Better dynamic type check.
1410 (MemberLookup_FindMembers): More MS tricks.
1411 (GetParameterData): Ditto.
1412 (GetDelegateParameters): Uses quick path for dynamic types.
1414 2007-08-01 Marek Safar <marek.safar@gmail.com>
1416 * class.cs (MethodData.Define): EmitContext is required for generic stuff
1419 2007-07-31 Marek Safar <marek.safar@gmail.com>
1421 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
1424 2007-07-26 Jb Evain <jbevain@novell.com>
1426 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
1427 which takes a boolean 'report_errors', similar to the GetMethod.
1428 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
1429 in .net 2.1, do not report errors here.
1431 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
1432 System.Runtime.CompilerServices.RequiredAttributeAttribute and
1433 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
1436 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
1437 of the type InternalsVisibleToAttribute before the first call
1438 to CoreLookupType which is allowed to fail (third boolean parameter
1439 to true). Because, during the resolution for a type that is not
1440 immediately found, we try to check if the type is not defined in
1441 a friend assembly, and to do so, we need the
1442 InternalVisibleToAttribute.
1444 2007-07-23 Miguel de Icaza <miguel@novell.com>
1446 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
1447 feature that allows structs to be compared against null and inline
1448 the result as true or false.
1450 Notice that the same code is not permitted inside a generic block
1451 of code that would do:
1453 class Foo<T> where T : struct {
1460 It is only allowed if the type of T is not bound (no where
1461 clause). In my opinion, this CSC 2 behavior is broken but people
1462 seem to be using it (IronRuby does, a few bug reports on bugzilla
1463 have it and some people have complained about it).
1465 All of the users that depend on this behavior have code that is
1468 * report.cs (Warning, Error): make these take object arguments,
1469 not strings, as that allows us to take advantage of Format.
1471 2007-07-20 William Holmes <billholmes54@gmail.com>
1473 * decl.cs: Changed MemberName.CountTypeArguments to also check the
1474 Left member variable for the Count.
1475 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
1476 MemberName.CountTypeArguments to avoid a NRE.
1478 This code is contributed under the MIT X11 license
1480 2007-07-18 Marek Safar <marek.safar@gmail.com>
1482 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
1484 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1486 * doc.cs : generic method arguments are written as ``x while generic
1487 type arguments are `x. Combined with the previous change, fixed bug
1490 2007-07-18 Raja R Harinath <rharinath@novell.com>
1493 * expression.cs (Binary.ResolveOperator): When converting
1494 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
1496 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1498 * doc.cs : when T: or whatever x: is specified, it does not really
1499 check the doc comment's syntax correctness. Fixed bug #82006.
1501 2007-07-18 Marek Safar <marek.safar@gmail.com>
1503 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
1504 LambdaExpression better.
1506 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
1508 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
1510 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
1511 as it can be generated.
1513 * expression.cs (Invocation.Error_InvalidArguments): Show correct
1516 * lambda.cs (LambdaExpression): Refactored to share same code with
1517 AnonymousMethodExpression.
1519 2007-07-17 Marek Safar <marek.safar@gmail.com>
1521 * anonymous.cs (MakeName): Include host name for easier debugging.
1522 (LambdaMethod): New class for lambda spcecific stuff.
1524 * attribute.cs: Set EmitContext return type.
1526 * class.cs: Set EmitContext return type.
1528 * codegen.cs (EmitContext): Return type cannot be null to stop messing
1529 with null/void meaning.
1531 * iterators.cs (ContainerType): Implemented.
1533 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
1535 * statement.cs (Return): Updated to lambda expressions.
1536 (Block.CloneTo): Parent can be null.
1538 2007-07-13 Marek Safar <marek.safar@gmail.com>
1540 A fix for bug #81917
1541 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
1543 * class.cs (FixedField): Check whether field is in unsafe scope.
1545 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
1546 (FieldExpr.Emit): Fixed buffers cannot be volatile.
1548 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
1551 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
1553 2007-07-13 Marek Safar <marek.safar@gmail.com>
1555 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
1556 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
1559 2007-07-13 Marek Safar <marek.safar@gmail.com>
1561 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
1563 2007-07-13 Marek Safar <marek.safar@gmail.com>
1565 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
1566 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
1568 * codegen.cs(EmitContext): Add ProbingMode flag.
1570 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
1572 * driver.cs: For now set both warning values.
1574 * ecore.cs (SimpleName): Name is readonly.
1575 (MethodGroup.OverloadResolve): One quick path for probing.
1577 * expression.cs (Unary): Set Oper r/o.
1578 (Binary): Set Oper r/o.
1579 (ParameterReference): Set few instance variables as r/o.
1580 (ParameterReference.DoResolveBase): Don't capture aruments when
1582 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
1583 (Arglist): arguments are private.
1584 (SizeOf): type is private and r/o.
1585 (MemberAccess): arguments are private.
1587 * report.cs: Enhanced reporting on/off capabilities.
1589 * lambda.cs: Uses ec.IsInProbingMode.
1590 (ContextualReturn): Derives from return.
1592 * rootcontext.cs: For now set both warning values.
1594 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
1596 (Return.Resolve): Don't die immediately.
1597 (Block.Resolve): Speed-up probing.
1598 (Block.CloneTo): Clone only child blocks.
1600 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
1602 * iterators.cs: reverted Miguel's latest change (r81925) as it
1603 breaks the build in System.
1605 2007-07-13 Miguel de Icaza <miguel@novell.com>
1607 * iterators.cs (Yield.CheckContext): Check for the iterator type
1608 also here as we can call into Yield even in codepaths that are not
1610 (MethodOrOperator is the only path that was checked).
1612 In addition to the standard check, use a more specific check for
1613 constructors to report a more verbose error.
1615 2007-07-12 Miguel de Icaza <miguel@novell.com>
1617 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
1618 report the warning and continue
1620 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
1621 values on the stack on the call to Emit. Use EmitStatement if
1622 possible, or using Emit + Pop if not possible. Fixes #82064
1624 2007-07-12 Raja R Harinath <rharinath@novell.com>
1626 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
1627 avoid try...finally in some cases.
1629 2007-07-10 Marek Safar <marek.safar@gmail.com>
1631 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
1633 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
1634 instead of method. Re-use standard error handling.
1635 (ConstructorInitializer.Emit): Simplified.
1637 * delegate.cs: Updated after Invocation.EmitCall change.
1639 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
1640 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
1641 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
1642 method and don't permanently changing input arguments.
1643 (MethodGroupExpr): Introduced resolved best_candidate, when method group
1644 is resolved it has one of the candidates is the best one which is later
1645 used to emit. Removed a few unused method.
1646 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
1648 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
1649 (Binary.ResolveOperator): Ditto.
1650 (ConditionalLogicalOperator.DoResolve): Ditto.
1651 (Invocation): Uses method group.
1652 (Invocation.DoResolve): Simplified.
1653 (Invocation.EmitCall): Removed useless is_static.
1654 (Invocation.Emit): Delegate to method group.
1655 (Invocation.EmitStatement): Simplified.
1656 (New): Uses method group.
1657 (MemberAccess.DoResolve): Don't destroy original expression.
1659 * statement.cs (ForEach.Resolve): Use null for no method arguments.
1661 2007-07-04 Marek Safar <marek.safar@gmail.com>
1663 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
1666 * lambda.cs: Add custom error message type.
1668 2007-07-03 Marek Safar <marek.safar@gmail.com>
1670 * lambda.cs: Simplified little bit.
1672 * parameter.cs: Introduced ImplicitLambdaParameter.
1673 (Parameters.CreateFullyResolved): New factory instead of ctor.
1677 * delegate.cs: Updated parameter creation.
1679 2007-07-03 Marek Safar <marek.safar@gmail.com>
1681 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
1684 * generic.cs: Synchronized with gmcs.
1686 2007-07-03 Marek Safar <marek.safar@gmail.com>
1688 * class.cs (Indexer): Check return type as soon as possible.
1690 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
1693 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
1695 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
1697 * parameter.cs (Parameter): Use expression type when it is available.
1699 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
1700 method modifier for the first parameter only.
1702 2007-06-24 Marek Safar <marek.safar@gmail.com>
1704 A fix for bug #81938
1705 * typemanager.cs (ChangeType): Fixed couple of char conversions.
1707 * constant.cs: Tide up an exception message.
1709 2007-06-22 Marek Safar <marek.safar@gmail.com>
1711 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
1712 an uninitialized variable is used.
1714 * expression.cs (LocalVariableReference.DoResolve): Ditto.
1716 2007-06-22 Marek Safar <marek.safar@gmail.com>
1718 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
1719 not found error handling.
1721 * expression.cs (ArrayCreation): Removed redundant fields and little bit
1723 (ArrayCreation.ResolveArrayElement): To be ready to customization.
1724 (ArrayCreation.DoResolve): Simplified.
1725 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
1726 its own resolve process.
1727 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
1729 2007-06-20 Marek Safar <marek.safar@gmail.com>
1731 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
1734 2007-06-20 Marek Safar <marek.safar@gmail.com>
1736 * cs-tokenizer.cs: Removed var related stuff.
1738 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
1739 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
1740 a type and a keyword at same time.
1742 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
1745 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
1746 implicitly typed arrays, more changes will follow.
1748 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
1750 2007-06-19 Marek Safar <marek.safar@gmail.com>
1752 * ecore.cs (VarExpr): Removed Handled field.
1754 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
1755 build-in assign functionality.
1756 (ForEach.Resolve): Removed all implicitly typed local variable code and
1758 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
1759 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
1761 2007-06-18 Marek Safar <marek.safar@gmail.com>
1763 * assign.cs: Removed implicitly typed local variable check.
1765 * expression.cs (LocalVariableReference.DoResolve): Add check for self
1766 referencing implicitly typed local variable.
1767 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
1770 * statement.cs (Fixed): Removed unsupported implicitly typed local
1773 2007-06-15 Marek Safar <marek.safar@gmail.com>
1775 * decl.cs (MemberName): Moved all Unbound stuff to parser.
1777 2007-06-14 Marek Safar <marek.safar@gmail.com>
1779 A fix for bugs #81855 and #76274
1780 * attribute.cs (AttachTo): Always set owner for global attributes to
1783 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
1786 * cs-parser.jay: Assembly and module attributes must precede all other
1787 elements except using clauses and extern alias declarations.
1789 2007-06-13 Marek Safar <marek.safar@gmail.com>
1791 A fix for bug #81748
1793 * expression.cs: More checks for non ISO-1 features.
1795 2007-06-12 Marek Safar <marek.safar@gmail.com>
1797 A fix for bug #81807
1798 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
1799 present inside switch statement and it is required by nullable check.
1801 2007-06-12 Marek Safar <marek.safar@gmail.com>
1803 A fix for bug #81840
1804 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
1805 when type matching fails.
1807 * namespace.cs: Tiny error message change.
1809 2007-06-12 Marek Safar <marek.safar@gmail.com>
1811 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
1812 reporting. Added automatic property check.
1814 * class.cs: Updated after CheckAbstractAndExtern relocation.
1815 (AEventPropertyAccessor.GetSignatureForError): Customized.
1817 2007-06-11 Marek Safar <marek.safar@gmail.com>
1819 * class.cs (DefineBaseTypes): Base type can be undefined.
1821 * ecore.cs (TypeLookup): Minor refactoring.
1822 (DoResolveAsTypeStep): Removed redundant check.
1824 * namespace.cs (Lookup): Removed redundant check.
1826 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
1827 ResolveAsTypeTerminal step.
1828 (BootstrapCorlib_*): Simplified.
1829 (PopulateCoreType): Core types can be now external.
1831 2007-06-07 Marek Safar <marek.safar@gmail.com>
1833 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
1835 (InferTypeArguments): Infers anonymous expression type arguments.
1836 (Compatible): Split to Compatible and InferTypeArguments.
1838 * lambda.cs: Updated.
1840 2007-06-08 Marek Safar <marek.safar@gmail.com>
1842 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
1844 2007-06-07 Raja R Harinath <harinath@gmail.com>
1846 Fix #80477, cs0135-2.cs, cs0135-3.cs
1847 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
1848 names to the "known" variables list.
1849 (Block.CheckInvariantMeaningInBlock): Handle the fact the
1850 parameter names are also "known".
1851 (Block.CheckError136): Remove.
1852 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
1855 2007-06-07 Marek Safar <marek.safar@gmail.com>
1857 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
1859 2007-06-06 Marek Safar <marek.safar@gmail.com>
1861 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
1862 internal error not an user error.
1864 * expression.cs (IsApplicable): Refactored to make debugging easier.
1866 * support.cs: More tricks for non-mono runtimes.
1868 * typemanager.cs (CoreLookupType): Made public.
1869 (InitSystemCore): All linq specific stuff moved to linq.cs
1871 2007-06-05 Marek Safar <marek.safar@gmail.com>
1873 * typemanager.cs (CSharpSignature): One more missing build-in types
1875 More tricks for non-mono runtime.
1877 2007-06-05 Raja R Harinath <harinath@gmail.com>
1879 * statement.cs (Block.CheckError136_InParents): Remove.
1880 (Block.AddVariable): Use GetParameterInfo instead.
1881 (ToplevelBlock.ProcessArguments): Likewise.
1883 2007-06-04 Raja R Harinath <rharinath@novell.com>
1885 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
1887 (ToplevelBlock.GetParameterInfo): Split out of ...
1888 (ToplevelBlock.GetParameterRefernce): ... this.
1889 (ToplevelBlock.ParameterMap): Remove.
1890 * expression.cs (ParameterReference): Update to use
1891 ToplevelParameterInfo.
1893 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
1896 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
1897 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
1899 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
1900 (ToplevelBlock.ProcessParameters) ... here.
1901 (ToplevelBlock..ctor): Invoke it.
1903 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
1906 * statement.cs (IKnownVariable): New interface.
1907 (LocalInfo): Implement it.
1908 (ToplevelParameterInfo): New class.
1909 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
1910 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
1911 GetKnownVariableInfo.
1913 2007-06-03 Raja R Harinath <harinath@gmail.com>
1915 Partly speed up CS0136 error checks.
1916 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
1917 'recurse' parameter.
1918 (Block.DoCheckError136): Only check errors in parameters. Move
1919 local variable checks ...
1920 (Block.AddVariable): ... here, and ...
1921 (ToplevelBlock.ResolveMeta): ... here.
1923 2007-06-02 Raja R Harinath <harinath@gmail.com>
1925 * statement.cs (Block.IsChildOf): Remove.
1927 * statement.cs (Statement.Clone): Move special case code ...
1928 (Block.CloneTo): ... here.
1930 2007-05-29 Raja R Harinath <rharinath@novell.com>
1932 * statement.cs (ToplevelBlock.container): Remove field. It's
1933 redundant with 'Parent'.
1934 (ToplevelBlock.ContainerBlock): Remove accessor.
1935 (ToplevelBlock..ctor): Update to changes. Register anonymous
1936 child with parent here, ...
1937 * cs-parser.jay (end_anonymous): ... not here. Don't modify
1939 (start_anonymous): Don't save current_block.
1940 (top_current_block): Remove.
1942 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
1943 (Block.Resolve): Update to changes.
1944 (Block..ctor): Move setting of "correct" 'Toplevel'
1945 and 'Explicit' fields to ...
1946 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
1948 2007-05-27 Raja R Harinath <harinath@gmail.com>
1951 * statement.cs (Block.Implicit): Remove.
1952 (Block): Update to changes.
1953 * flowanalysis.cs: Likewise.
1955 Mildly speed up CheckInvariantMeaningInBlock
1956 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
1957 Recursively call AddKnownVariable to all enclosing blocks.
1958 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
1959 Remove recursive calls.
1960 (Block): Update to changes.
1962 New ExplicitBlock invariants
1963 * statement.cs (Block.Explicit): New field. It points to the
1964 immediately enclosing non-implicit block.
1965 (Block..ctor): Maintain the invariant.
1966 * cs-parser.jay: Take advantage of invariant.
1968 Introduce ExplicitBlock
1969 * statement.cs (ExplicitBlock): New.
1970 (ToplevelBlock): Derive from it.
1971 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
1973 (Block.Implicit): Update to changes.
1974 * cs-parser.jay: Update to changes.
1977 * codegen.cs (EmitContext.IsLastStatement): Remove.
1978 * statement.cs (Block.DoEmit): Update to changes.
1980 2007-05-25 Raja R Harinath <rharinath@novell.com>
1982 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
1983 modifying current_block directly.
1985 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
1987 * class.cs: Implemented automatic properties (C# 3.0)
1988 Thanks to Marek for the help.
1990 2007-05-23 Raja R Harinath <rharinath@novell.com>
1992 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
1993 variable as assigned, note also that all its components are
1995 (MyBitVector.SetRange): New. Function to set multiple bits to true.
1997 2007-05-19 Marek Safar <marek.safar@gmail.com>
1999 * anonymous.cs, class.cs: Emit Compiler generated attribute when
2000 member is marked as compiler generated.
2002 * decl.cs (MemberCore): Refactored ModFlags into property.
2004 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
2005 (Check): Check only accessibility modifiers.
2007 2007-05-18 Raja R Harinath <rharinath@novell.com>
2009 Track all assignable slots in one bit array
2010 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
2011 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
2012 logic from VariableMap constructor here. Use the same 'offset'
2013 variable that's later used for computing offsets of local
2015 * flowanalysis.cs (UsageVector.parameters): Remove.
2016 (UsageVector): Update to changes.
2017 (VariableMap): Remove.
2019 Avoid creating ParameterMap in every block
2020 * statement.cs (Block.ParameterMap): Move ...
2021 (ToplevelBlock.ParameterMap): ... here.
2022 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
2024 * flowanalysis.cs (FlowBranching.param_map): Remove.
2025 (FlowBranching.UsageVector): Update to changes.
2026 (FlowBranchingToplevel.CheckOutParameters): Likewise.
2028 * statement.cs (Block.CloneTo): Clone Toplevel field too.
2030 * expression.cs (ParameterReference): Distinguish between block
2031 where parameter was referenced and declared.
2033 2007-05-18 Marek Safar <marek.safar@gmail.com>
2035 * flowanalysis.cs, statement.cs: Put back improved error handling.
2037 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
2041 Imporved object and collection initialization (C# 3.0).
2043 2007-05-15 Marek Safar <marek.safar@gmail.com>
2045 A fix for bug #81380
2046 * expression.cs (Is.DoResolve): Only value types have constant `is'
2049 2007-05-15 Raja R Harinath <rharinath@novell.com>
2051 * statement.cs (ToplevelBlock.child): Remove.
2053 2007-05-15 Raja R Harinath <harinath@gmail.com>
2055 Rationalize ResolveMeta: refactoring
2056 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2057 out constant handling code into ...
2058 (Block.DoResolveConstants): ... this.
2060 Rationalize ResolveMeta: kill local_map
2061 * statement.cs (Block.local_map, Block.LocalMap): Remove.
2062 (Block.AssignableSlots): New.
2063 (Block.ResolveMeta): Make protected. Don't create a VariableMap
2064 for locals -- move code from VariableMap here. Avoid unnecessary
2066 * flowanalysis.cs (FlowBranching.local_map): Remove.
2067 (FlowBranching..ctor): Use Block.AssignableSlots.
2068 (VariableMap): Remove unused constructors.
2070 2007-05-11 Raja R Harinath <rharinath@novell.com>
2072 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
2074 2007-05-11 Marek Safar <marek.safar@gmail.com>
2076 * typemanager.cs (IsFriendAssembly): Should not be called for building
2079 2007-05-09 Marek Safar <marek.safar@gmail.com>
2081 * literal.cs (NullConstant): Print null in all cases.
2083 * expression.cs (Binary.ResolveOperator): Implemented delegate
2084 comparison based on C# 2.0 changes.
2086 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
2088 This code is contributed under the MIT X11 license
2090 The following enables support for several C# 3.0 language features:
2092 * cs-tokenizer.cs: Added support for the "var" keyword.
2094 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
2095 Added VarExpr class to facilitate type inferencing.
2097 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
2098 to support anonymous types.
2100 * assign.cs: Added support for type inferencing and initialization.
2102 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
2104 * expression.cs: Added implicit array support to ArrayCreation.
2105 Added 5 types and 1 interface:
2107 IInitializable Implementing classes can inject initializing
2108 statements after object instantiation.
2110 Initializer Stores data for object initialization.
2112 AnonymousType An expression for anonymous types.
2114 AnonymousTypeParameter Stores data about an anonymous type's field.
2116 NewInitialize An expression for object initialization.
2118 CollectionInitialize An expression for collection initialization.
2120 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
2123 2007-05-06 Marek Safar <marek.safar@gmail.com>
2125 A fix for bug #81500
2126 * cs-tokenizer.cs: Add special handling for coalescing operator.
2128 2007-05-06 Marek Safar <marek.safar@gmail.com>
2130 A fix for bug #81529
2131 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
2132 its value from base class until it is redefined.
2134 2007-05-02 Raja R Harinath <rharinath@novell.com>
2136 Fix regression in cs0631-3.cs
2137 * cs-parser.jay (operator_declarator): Add opt_attributes to error
2138 fallback. Make error fallback catch more cases.
2140 2007-05-01 Miguel de Icaza <miguel@novell.com>
2142 * cs-parser.jay: Allow parameters in operator declarations to have
2145 2007-04-27 Miguel de Icaza <miguel@novell.com>
2147 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
2150 * lambda.cs (ContextualReturn.Resolve): An expression is valid
2151 inside the ContextualReturn, it does not have to be an
2152 ExpressionStatement.
2154 2007-04-24 Miguel de Icaza <miguel@novell.com>
2156 * lambda.cs (ContextualReturn.Resolve): if the return type is not
2159 2007-04-23 Miguel de Icaza <miguel@novell.com>
2161 * anonymous.cs (AnonymousContainer): split the virtual Resolve
2162 method in two methods: ResolveNoDefine and Resolve.
2164 ResolveNoDefine will stop just after ResolveTopBlock has been
2167 Resolve will then continue by creating a method and issuing the
2168 call to method.Define ().
2170 (AnonymousMethod): Split and implement the new Resolve and
2171 ResolveNoDefine as well.
2173 * lambda.cs (LambdaExpression): Split the anonymous method
2174 resolution code into a separate routine (CoreCompatibilityTest)
2175 from DoCompatibleTest.
2177 (LambdaExpression.TryBuild): New method, this method tries to
2178 build the LambdaExpression with the given set of types to be used
2179 as the types for the various parameters of the lambda expression.
2181 If the compilation succeed with the given types, the infered type
2182 of the Anonymous method is returned, otherwise null is returned.
2184 2007-04-23 Marek Safar <marek.safar@gmail.com>
2186 A fix for bug #81414
2187 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
2189 2007-04-22 Miguel de Icaza <miguel@novell.com>
2191 * cs-tokenizer.cs: Change various identifiers here from the
2192 camelCasing to the recommended Linux-like style for instance
2193 variables from the Coding Guidelines.
2195 2007-04-19 Martin Baulig <martin@ximian.com>
2198 (Convert.ImplicitReferenceConversionCore): Allow conversions from
2199 System.Enum to System.ValueType.
2201 2007-04-13 Martin Baulig <martin@ximian.com>
2203 Rewrote implicit reference conversions. We need to distinguish
2204 between implicit reference conversions (13.1.4) and implicit
2205 boxing conversions (13.1.5).
2207 According to the spec, there's an an implicit conversion
2208 "From a one-dimensional array-type S[] to IList<T> and base
2209 interfaces of this interface, provided there is an implicit
2210 reference conversion from S to T." Note that this does not
2211 include boxing conversions.
2214 (Convert.ImplicitTypeParameterBoxingConversion): New method.
2215 (Convert.ImplicitReferenceConversion): Split into
2216 ImplicitReferenceConversionCore() and
2217 ImplicitBoxingConversionExist().
2218 (Convert.ImplicitReferenceConversionExists): Use the new
2219 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
2221 2007-04-12 Martin Baulig <martin@ximian.com>
2223 * convert.cs (Convert.ImplicitReferenceConversion): Move the
2224 `TypeManager.null_type' checks up to the top of the method.
2226 2007-04-11 Marek Safar <marek.safar@gmail.com>
2228 A fix for bug #81350
2229 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
2232 2007-04-11 Martin Baulig <martin@ximian.com>
2234 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
2235 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
2236 to make this work for generic classes; fixes #79561.
2238 2007-04-11 Martin Baulig <martin@ximian.com>
2240 * expression.cs (As): Add support for nullable types; fixes #79371.
2242 2007-04-11 Martin Baulig <martin@ximian.com>
2244 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
2245 `type.FullName' is null; fixes #80243.
2247 2007-04-11 Martin Baulig <martin@ximian.com>
2249 * expression.cs (Invocation.IsApplicable): Don't modify the method
2250 if type inference succeeded, but the method was not applicable.
2253 2007-04-10 Marek Safar <marek.safar@gmail.com>
2255 A fix for bug #81324
2256 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
2257 internal and external namespaces containers.
2259 2007-04-10 Martin Baulig <martin@ximian.com>
2261 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
2262 TypeManager.DropGenericMethodArguments() so we also call
2263 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
2265 2007-04-10 Martin Baulig <martin@ximian.com>
2267 * iterators.cs (Iterator.CreateIterator): Don't crash if
2268 `method.ReturnType' is null. This happens if something went wrong
2269 while resolving that typ (we already reported an error in this case).
2271 2007-04-10 Martin Baulig <martin@ximian.com>
2273 * expression.cs (New.DoResolve): Don't call CheckComImport() on
2274 generic interfaces; report the CS0144 directly.
2276 2007-04-10 Martin Baulig <martin@ximian.com>
2278 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
2279 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
2281 2007-04-10 Martin Baulig <martin@ximian.com>
2283 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
2285 2007-04-09 Raja R Harinath <rharinath@novell.com>
2288 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
2289 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
2292 * statement.cs (For.Resolve): If resolution fails, use
2295 2007-04-08 Marek Safar <marek.safar@gmail.com>
2297 * anonymous.cs (MakeName): Make faster and zero-based.
2298 (VerifyExplicitParameterCompatibility): Back to mode where generic
2299 parameter is ignored.
2300 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
2302 * class.cs (EmitType): Method can emit another new method.
2304 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
2306 * driver.cs: Updated.
2308 * lambda.cs: Reuse predefined empty parameters.
2310 * parameter.cs: Updated
2312 * support.cs: Implemented InflateTypes.
2314 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
2315 (InitSystemCore): Introduced to isolate 3.0 dependencies.
2317 2007-04-03 Martin Baulig <martin@ximian.com>
2321 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
2322 version of TypeManager.IsOverride() which also works with generic
2325 2007-04-03 Martin Baulig <martin@ximian.com>
2330 (Convert.ExplicitReferenceConversion): We need to cast when
2331 converting from IList<T> to S[].
2333 2007-04-01 Marek Safar <marek.safar@gmail.com>
2335 * decl.cs (FindExtensionMethods): Consider all candidates with same name
2338 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
2340 2007-03-31 Marek Safar <marek.safar@gmail.com>
2342 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
2343 argument and return type inferring.
2345 * codegen.cs (InferReturnType): Flag whether return can be inferred.
2346 (ReturnType): Turned to property.
2348 * statement.cs (Return): Implemented return type inferring.
2350 * support.cs (ReflectionParameters): Use local types if possible.
2352 2007-03-30 Raja R Harinath <rharinath@novell.com>
2354 * flowanalysis.cs (FlowBranching.Reachability): Remove.
2355 (FlowBranching.UsageVector): Update to changes.
2357 Prepare to kill 'Reachability'
2358 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
2359 argument of constructor.
2361 2007-03-29 Raja R Harinath <rharinath@novell.com>
2363 Prepare to kill 'Reachability'
2364 * flowanalysis.cs (UsageVector.is_unreachable): New.
2365 (UsageVector): Update to maintain 'is_unreachable' in parallel to
2366 'reachability', and verify they're consistent.
2369 * expression.cs (New.EmitStatement): Handle type parameters here too.
2371 2007-03-29 Martin Baulig <martin@ximian.com>
2376 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
2377 CompilerGeneratedClass.
2378 (ScopeInfo.EmitScopeInstance): Make this protected.
2379 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
2380 `ec.CurrentAnonymousMethod.Scope == Scope'.
2382 * statement.cs (Block.ScopeInfo): Make this a property.
2384 2007-03-27 Raja R Harinath <harinath@gmail.com>
2386 Prepare to kill 'Reachability'
2387 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
2388 (FlowBranching.UsageVector.Reachability): Remove property.
2389 (FlowBranching.UsageVector.IsUnreachable): New property.
2390 (FlowBranching.UsageVector.ResetBarrier): New.
2391 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
2392 * codegen.cs, statement.cs: Update to changes.
2394 2007-03-27 Martin Baulig <martin@ximian.com>
2399 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
2402 2007-03-26 Raja R Harinath <rharinath@novell.com>
2404 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
2405 instead of TriState. Remove all mention of TriState.
2407 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
2408 replaced by a boolean. Add boolean 'is_unreachable' field, check
2409 and maintain invariants.
2411 2007-03-25 Marek Safar <marek.safar@gmail.com>
2413 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
2415 2007-03-25 Marek Safar <marek.safar@gmail.com>
2417 * expression.cs: Stop using obsolete 2.0 opcodes.
2419 2007-03-25 Marek Safar <marek.safar@gmail.com>
2421 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
2422 one of the latests Martin's fixes.
2424 2007-03-23 Miguel de Icaza <miguel@novell.com>
2426 * expression.cs: On BigEndian systems, swap the bytes, temporary
2427 solution until we get a new bitconverter class.
2429 2007-03-23 Martin Baulig <martin@ximian.com>
2433 * decl.cs (MemberCache.AddMembers): Add generic methods both as
2434 "Method" and "Method`1". Normally, a cache lookup is done on the
2435 "Method" form (ie. without the generic arity), but this one makes
2436 lookups on the full form work as well.
2438 2007-03-22 Raja R Harinath <rharinath@novell.com>
2440 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
2443 2007-03-20 Bill Holmes <billholmes54@gmail.com>
2445 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
2446 ordered_member_list, to TypeBuilder to store members to be defined
2447 in the order they were parsed in.
2448 - ordered_explicit_member_list contains all properties indexers
2449 and methods that are defined as explicit implementation of an
2450 interface or base class.
2451 - ordered_member_list contains all properties indexers and methods
2452 that are not defined as explicit implementation of an interface
2455 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
2456 functionality in these removed classes has been replaced with
2457 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
2458 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
2460 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
2461 to CheckForDuplications inside GetMethod and SetMethod Define Method
2462 to handle method property and indexer name conflicts.
2466 All code is contributed under the MIT/X11 license.
2468 2007-03-20 Martin Baulig <martin@ximian.com>
2470 * class.cs (TypeContainer.Interfaces): Removed; they're now
2471 included in `TypeContainer.Types'.
2473 2007-03-20 Martin Baulig <martin@ximian.com>
2475 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
2477 * class.cs (TypeContainer.CreateType): New public method. This is
2478 now called before DefineType() to create the TypeBuilders.
2479 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
2480 has already been created by CreateType().
2481 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
2482 don't resolve our base classes here; this has been moved into
2483 DefineBaseTypes(). We're now called from CreateType().
2484 (TypeContainer.DefineBaseTypes): New private method; resolve our
2485 base classes here. We're now called from DefineType().
2488 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
2489 our types first to create all the TypeBuilders. After that, call
2490 TypeContainer.DefineType() on all the types which'll resolve their
2491 base classes and setup the resolve order.
2493 2007-03-20 Martin Baulig <martin@ximian.com>
2495 * class.cs (TypeContainer.Enums): Removed; they're now included in
2496 `TypeContainer.Types'.
2498 2007-03-20 Martin Baulig <martin@ximian.com>
2501 (TypeContainer.DefineType): Don't call ResolveMembers() here.
2502 (TypeContainer.DoResolveMembers): Call DefineType() on our
2503 `compiler_generated' classes; moved here from DefineNestedTypes().
2506 (RootContext.ResolveTree): Call ResolveMembers() on all
2507 TypeContainer's in the `type_container_resolve_order'.
2509 2007-03-19 Marek Safar <marek.safar@gmail.com>
2511 * class.cs: Use corlib to handle InternalMethodImplAttribute.
2513 2007-03-17 Marek Safar <marek.safar@gmail.com>
2515 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
2516 implementation flags.
2518 2007-03-17 Marek Safar <marek.safar@gmail.com>
2520 * class.cs: More optimizations for type parameters.
2522 2007-03-15 Marek Safar <marek.safar@gmail.com>
2524 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
2526 * ecore.cs, parameter.cs: More common code for both corlibs.
2528 * typemanager.cs (IsGenericMethod): Simplified.
2530 2007-03-15 Raja R Harinath <rharinath@novell.com>
2532 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2534 * statement.cs, iterators.cs, lambda.cs: Update to changes.
2536 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
2537 unconditionally. Simplify explanation.
2538 (Try.Resolve, Using.Resolve): Likewise.
2540 2007-03-15 Martin Baulig <martin@ximian.com>
2544 * decl.cs (DeclSpace): If we're a partial class, use our
2545 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
2547 2007-03-15 Raja R Harinath <rharinath@novell.com>
2549 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2551 (FlowBranching.UsageVector): Update to changes.
2552 (FlowBranching.MergeSiblings): Likewise.
2553 * statement.cs: Likewise.
2555 2007-03-15 Martin Baulig <martin@ximian.com>
2560 (MemberCache): Added a special .ctor for type parameters.
2563 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
2566 2007-03-09 Martin Baulig <martin@ximian.com>
2568 * enum.cs (Enum): Make this a TypeContainer.
2569 (EnumMember): Derive from `Const'.
2572 (Const.DoResolveValue): New protected virtual method; move most of
2573 the functionality of ResolveValue() here so we can override it in
2575 (Const.CreateConstantReference): Make this virtual.
2577 * class.cs (Kind): Add `Kind.Enum'.
2578 (TypeContainer.Emit): Don't emit the enums here; they're already
2579 in the `RootContext.typecontainer_resolve_order'.
2581 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
2582 here; they're already in the `typecontainer_resolve_order'.
2584 * ecore.cs (EnumConstant.ConvertImplicitly): Add
2585 TypeManager.DropGenericTypeArguments().
2588 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
2589 (TypeManager.IsEnumType): Likewise.
2590 (TypeManager.EnumToUnderlying): Likewise.
2591 (TypeManager.IsEqual): Add support for enums.
2593 2007-03-12 Raja R Harinath <rharinath@novell.com>
2595 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
2596 DefaultParameterValueAttribute to be undefined, say if System.dll
2599 2007-03-11 Marek Safar <marek.safar@gmail.com>
2601 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
2604 2007-03-10 Marek Safar <marek.safar@gmail.com>
2606 * class.cs, parameter.cs: Unified parameters verification.
2608 2007-03-08 Martin Baulig <martin@ximian.com>
2610 * cs-parser.jay (constructor_header): Pass the location to the
2611 newly created TopLevelBlock.
2613 2007-03-07 Martin Baulig <martin@ximian.com>
2615 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
2617 2007-03-06 Miguel de Icaza <miguel@novell.com>
2619 * convert.cs (ExplicitReferenceConversionExists): Sync this method
2620 with the changes from David, fixes the build.
2622 2007-03-05 David Mitchell <dmitchell@logos.com>
2624 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
2625 and its base interfaces to a one-dimensional array type S[],
2626 provided there is an implicit or explicit reference conversion
2629 2007-03-03 Marek Safar <marek.safar@gmail.com>
2631 * cs-tokenizer.cs: Implemented basic linq grammar.
2633 * driver.cs: Set linq lang version on demand.
2635 2007-02-26 Marek Safar <marek.safar@gmail.com>
2637 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
2639 2007-02-25 Marek Safar <marek.safar@gmail.com>
2641 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
2644 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
2646 Check property and event extern attributes.
2648 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
2651 2007-02-24 Marek Safar <marek.safar@gmail.com>
2653 A fix for bug #80407
2654 * ecore.cs: Don't report ambiguity error when methods have same parent.
2656 2007-02-23 Marek Safar <marek.safar@gmail.com>
2658 A fix for bug #80878
2659 * class.cs, cs-parser.jay: Event property can host anonymous methods.
2661 2007-02-22 Marek Safar <marek.safar@gmail.com>
2663 * attribute.cs: Enable ExtensionAttribute presence test.
2665 2007-02-22 Marek Safar <marek.safar@gmail.com>
2667 * class.cs: Warn about missing GetHashCode only when Equals is override.
2669 * decl.cs: Check accessibility of type arguments.
2671 * typemanager.cs: Correctly report nullable array.
2673 2007-02-20 Marek Safar <marek.safar@gmail.com>
2675 * class.cs, report.cs: Capture more details when things go wrong.
2677 2007-02-20 Marek Safar <marek.safar@gmail.com>
2679 A fix for bug #80650
2680 * cs-parser.jay: Anonymous container starts at constructor declaration
2681 and not at block beginning because it has to be usable in constructor
2684 * statement.cs: Use context location and not block one for error reporting.
2686 2007-02-18 Marek Safar <marek.safar@gmail.com>
2688 A fix for bug #78712
2689 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
2692 2007-02-18 Marek Safar <marek.safar@gmail.com>
2694 A fix for bug #80493 by Atsushi Enomoto
2695 * cs-parser.jay: Ignore invalid attribute target.
2697 2007-02-18 Marek Safar <marek.safar@gmail.com>
2699 * cs-tokenizer.cs: Ignore '\0' as white space character.
2701 2007-02-17 Miguel de Icaza <miguel@novell.com>
2703 * cs-parser.jay: Add support for lambda expressions to the mcs
2706 * lambda.cs: Only clone when we are probing, not on the final call
2707 (Compatible is the final call).
2709 * statement.cs (CloneContext): Introduce class to provide block
2710 remapping during clone.
2712 All statements Clone themselves now.
2714 (Clone): special handling for blocks, when we clone a block, we
2715 register the block inside this routine, as children of the block
2716 might trigger a lookup.
2718 * expression.cs: Add support for CloneContext in all expressions.
2720 2007-02-17 Marek Safar <marek.safar@gmail.com>
2722 A fix for bug #80493
2723 * statement.cs: Report ambiguous warning when interfaces are not related.
2725 2007-02-15 Marek Safar <marek.safar@gmail.com>
2727 C# 3.0 extension methods.
2729 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
2730 cannot be used directly.
2732 * class.cs (Class.Emit): Emit extension attribute if any class method
2733 is extension method.
2734 (Method.Define): Add basic extension method validation conditions.
2735 (Method.Emit): Emit extension attribute for method.
2737 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
2738 extension method exists. Currently we follow same approach as Microsoft
2739 does, emit even if a method or a class are private but this can change
2742 * cs-parser.jay: Add handling of `this' keyword in method parameters
2745 * decl.cs (DeclSpace.IsStaticClass): New property.
2746 (MemberCache.FindExtensionMethods): Looks for extension methods with
2747 defined name and extension type.
2749 * doc.cs: Updated after OverloadResolve changes.
2751 * driver.cs: Add new soft reference to System.Core.dll.
2753 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
2754 (ExtensionMethodGroupExpr): Represents group of extension methods.
2756 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
2757 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
2758 to MethodGroupExpr and made non-static for easier customization.
2759 (Invocation.DoResolve): Add extension method lookup when no standard
2761 (MemberAccess.DoResolve): Try extension methods if no member exists.
2763 * modifiers.cs: Add METHOD_EXTENSION modifier.
2765 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
2766 as well as candidate extension type.
2767 (ComputeNamespaces): When assembly constains extension methods registers
2769 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
2770 extension method lookup.
2771 (Namespace.LookupExtensionMethod): Looks for extension method in this
2773 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
2774 find a method which matches name and extensionType.
2776 * parameter.cs (Parameter): Add This modifer.
2777 (HasExtensionMethodModifier): New property.
2778 (Resolve): Add extension parameter check.
2779 (ModFlags): turned to property to exclude this modifier as it is not real
2781 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
2783 * support.cs (ParameterData): Add ExtensionMethodType.
2784 (ReflectionParameters): Implemented ExtensionMethodType interface property.
2786 * typemanager.cs: Add type and ctor extension attribute type.
2788 2007-02-15 Miguel de Icaza <miguel@novell.com>
2790 * report.cs (DisableErrors, EnableErrors): used to prevent error
2791 output when we are "trying" to compile various methods with
2794 * ecore.cs (Expression): Add Clone method that calls the virtual
2795 CloneTo method. The current CloneTo method in Expression throws
2796 an exception so we can track down all the places where this must
2797 be implemented (not using abstract, because that would be a lot of
2798 up-front-work before we can start testing the implementation
2801 Important: we only need Clone capabilities for expressions created
2802 by the parser, as the expressions we will be cloning are
2803 expressions in the pre-resolved state. This vastly simplifies
2806 (SimpleName): Add CloneTo that does nothing.
2807 (EmptyCast): Add CloneTo.
2809 * expression.cs (Binary): Implement CloneTo.
2810 (Invocation.IsApplicable): Store the current ec in
2811 EmitContext.TempEc and restore it on return. This is used so we
2812 do not have to sprinkle hundres of methods with an extra
2813 EmitContext, we know that the only user is the lambda expression
2814 ImplicitConversionExists code.
2816 (Argument): Add Cloning capabilities.
2817 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
2818 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
2819 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
2820 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
2821 IndexerAccess): Add Clone capability.
2823 (LocalVariableReference, This): TODO: needs cloned Block mapping.
2825 (Argument): Add cloning capability.
2827 * assign.cs (Assign): Implement CloneTo.
2829 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
2831 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
2832 version by calling Convert with the EmitContext (that we are
2833 currently storing in ec, this is not great, but will do for now,
2834 to avoid passing EmitContext parameters to hundreds of functions
2835 that do not need them now).
2837 (SetExpression): Remove, it is not needed.
2839 (ContextualReturn): Implement CloneTo.
2841 * statement.cs (Statement): Implement cloning infrastructure,
2842 similar to expressions.
2844 (Block): Partial implementation of Clone for statements.
2846 (Return): Implement clone.
2848 * constant.cs (Constant.CloneTo): New method, does nothing.
2850 * codegen.cs (TempEc): Add a static EmitContext as a temporary
2851 solution, until we decide how to exactly do this.
2853 2007-02-14 Marek Safar <marek.safar@gmail.com>
2855 A fix for bug #80493
2856 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
2857 a property is override we need to use second accessor.
2859 2007-02-13 Marek Safar <marek.safar@gmail.com>
2861 A fix for bug #80418
2862 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
2865 2007-02-13 Marek Safar <marek.safar@gmail.com>
2867 Another fix for bug #80749
2868 * pending.cs: Abstract class has priority over interfaces.
2870 2007-02-13 Marek Safar <marek.safar@gmail.com>
2872 Another fix for bug #80749
2873 * pending.cs: Abstract class has priority over interfaces.
2875 2007-02-13 Marek Safar <marek.safar@gmail.com>
2877 Another fix for bug #80749
2878 * pending.cs: Abstract class has priority over interfaces.
2880 2007-02-13 Marek Safar <marek.safar@gmail.com>
2882 Another fix for bug #80749
2883 * pending.cs: Abstract class has priority over interfaces.
2885 2007-02-13 Marek Safar <marek.safar@gmail.com>
2887 * class.cs Better error message.
2889 * driver.cs: Add shorter versions of -optimize option.
2891 2007-02-13 Martin Baulig <martin@ximian.com>
2893 * class.cs (Constructor.Emit): Check the return value of
2894 ec.ResolveTopBlock() and return on error.
2896 2007-02-13 Raja R Harinath <rharinath@novell.com>
2898 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
2899 message to fix error message regression.
2901 2007-02-12 Marek Safar <marek.safar@gmail.com>
2903 * delegate.cs: Delegate creation expression cannot be of Nullable type.
2905 2007-02-12 Marek Safar <marek.safar@gmail.com>
2907 A fix for bug #80749
2908 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
2909 its parent container.
2911 * class.cs (DefineFieldInitializers): Each initializer can has different
2914 * const.cs: Updated.
2916 2007-02-11 Miguel de Icaza <miguel@novell.com>
2918 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
2919 now all the heavy lifting to check that embedded statements or
2920 expressions have the right form is done in the ContextualReturn.
2922 (ContextualReturn): New class.
2924 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
2925 method that can be invoked to report 201, so we do not replicate
2928 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
2930 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
2931 treating tabs as spaces.
2933 2007-02-09 Marek Safar <marek.safar@gmail.com>
2935 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
2936 * assign.cs: Use full implicit conversion for right side check.
2938 2007-02-09 Marek Safar <marek.safar@gmail.com>
2940 * statement.cs (Switch): Switch over boolean type is not standardized.
2942 2007-02-08 Marek Safar <marek.safar@gmail.com>
2944 A fix for bug #80755
2945 * decl.cs (FindBaseEvent): Don't use method cache for events.
2947 2007-02-07 Marek Safar <marek.safar@gmail.com>
2949 * cs-parser.jay: Better syntax error handling.
2951 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
2952 instead of underlying type value.
2954 2007-02-06 Marek Safar <marek.safar@gmail.com>
2956 * driver.cs: Check define identifier before is registered.
2958 * namespace.cs: Use existing error message.
2960 * report.cs: New warning.
2962 2007-02-06 Marek Safar <marek.safar@gmail.com>
2964 A fix for bug #80742
2965 * expression.cs: Delegate Invoke method can be called directly.
2967 2007-02-06 Marek Safar <marek.safar@gmail.com>
2969 A fix for bug #80676
2970 * class.cs (IsEntryPoint): The Main method can have params modifier.
2972 2007-02-04 Miguel de Icaza <miguel@novell.com>
2974 * parameter.cs (Parameter, Parameters): Add Clone method.
2976 * anonymous.cs (Compatible): Turn method into virtual method, so
2977 LambdaExpression can implement a different behavior.
2979 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
2980 out the basic checking here, so it can be used by
2983 * lambda.cs: Introduce "Compatible" function that will do the
2986 2007-02-02 Marek Safar <marek.safar@gmail.com>
2988 * attribute.cs: Unified one error message.
2990 * class.cs (Class): Use type attributes and not properties to test static
2992 (IsEntryPoint): Don's pass local variable.
2994 * convert.cs: Removed duplicate check.
2996 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
2998 * driver.cs: Don't crash when soft reference does not exist.
3000 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
3001 (UsingEntry): Removed redundant allocation.
3003 * parameter.cs: Add fast path for type parameters.
3005 * support.cs: Don't allocate attribute when it's not used.
3007 2007-01-30 Miguel de Icaza <miguel@novell.com>
3010 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
3011 this into a virtual method, so we can override it in LambdaExpression.
3013 * driver.cs: Improve diagnostics in case of failure.
3015 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
3016 write a function that is slightly more complex and that parses:
3018 type identifier [, type identifier]* )
3020 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
3023 (canEmpty ? i >= 0 : i > 0)
3025 2007-01-30 Raja R Harinath <rharinath@novell.com>
3027 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
3028 exception on possibly valid code.
3030 2007-01-29 Raja R Harinath <rharinath@novell.com>
3032 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
3034 (parse_opt_type_arguments): Remove. It's almost the same as
3036 (parse_namespace_or_typename): Use parse_less_than.
3038 2007-01-28 Miguel de Icaza <miguel@novell.com>
3040 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
3041 this bug took a few hours to find, because the state saved and
3042 restored by PushPosition and PopPosition was ignoring the state of
3043 parse_generic_less_than.
3045 I can also now remove the handling of OP_LT and OP_GT, this solves
3048 * cs-tokenizer.cs: store the location for the ARROW token, we use
3051 (PushPosition, PopPosition): save/restore also `current_token',
3052 restore `parse_generic_less_than' (was missing).
3054 (parse_opt_type_arguments): use parse_type, not
3055 parse_namespace_or_typename to parse types.
3057 * lambda.cs: Empty new file, will eventually have the lambda
3058 expression implementation.
3060 * lambda.test: used to test the internal tokenizer.
3062 * report.cs (FeatureIsNotISO1): Rename from
3063 FeatureIsNotStandardized, because it was about the language level
3064 (1 vs 2) it was not about standarization.
3066 (FeatureRequiresLINQ): New.
3068 * support.cs (SeekableStreamReader): Only require that the reader
3069 is a TextReader, not a StreamReader, so we can plug StringReader.
3071 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
3072 given position in the input stream the following tokens can be
3073 parsed as a type followed by an identifier.
3075 (is_punct): after a '(' if parse_type_and_parameter returns true,
3076 then return a special token OPEN_PARENS_LAMBDA which is used to
3077 avoid reduce/reduce errors in the grammar for the
3078 lambda_expression rules.
3080 (parse_type): implement a type parser inside the
3081 tokenizer, the parser only returns true or false depending on
3082 whether the input at a given position can be parsed as a type.
3084 (peek_token): new method used during type parsing.
3086 2007-01-28 Raja R Harinath <rharinath@novell.com>
3089 * anonymous.cs (ScopeInfo.InflateParameters): New.
3090 (AnonymousContainer.Resolve): Use it to redirect types of
3091 delegate parameters.
3093 2007-01-27 Raja R Harinath <rharinath@novell.com>
3096 * expression.cs (Error_InvalidArguments): Don't use two different
3097 messages for CS1503. Use ExtraInformation and
3098 SymbolRelatedToPreviousError instead.
3101 * decl.cs (DeclSpace.initialize_type_params): Don't access
3102 'type_params' of a partial class directly.
3104 2007-01-26 Miguel de Icaza <miguel@novell.com>
3106 * constant.cs: Removed a handful of out-of-range checks that were
3109 2007-01-25 Marek Safar <marek.safar@gmail.com>
3111 * expression.cs (CheckUselessComparison): Add additional check for char
3114 * namespace.cs: Fixed typo.
3116 2007-01-23 Miguel de Icaza <miguel@novell.com>
3118 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
3119 gone, instead we inline the test, preventing the needless casts to
3120 longs, ulongs and doubles for the parameters, avoiding calls to
3121 methods that overchecked stuff, and instead inlined things
3124 2007-01-20 Marek Safar <marek.safar@gmail.com>
3126 * cs-parser.jay: Better parameter error handling.
3128 2007-01-17 Marek Safar <marek.safar@gmail.com>
3130 A fix for bug #80368, #80522
3131 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
3132 whether array initializer contains constants only.
3133 (ArrayCreation.Emit): Use better formula to decide when
3134 are array initializers for static initialization.
3135 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
3136 have to emit even constants otherwise they are pre-initialized.
3138 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
3139 Raja R Harinath <rharinath@novell.com>
3141 Fix emit order of 'get' vs. 'set'.
3142 * support.cs (Accessors): New.
3143 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
3144 Note the order in which accessors are declared in the source.
3145 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
3146 Refactored from Property.Define and Indexer.Define.
3147 (PropertyBase.DefineAccessors): New helper that calls the above in
3148 appropriate order as noted by the parser.
3149 (Property.Define, Indexer.Define): Update to changes.
3150 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
3152 2007-01-17 Raja R Harinath <rharinath@novell.com>
3154 Fix cs0029-6.cs and gcs0029-2.cs (regression)
3155 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
3156 there's an implicit conversion from the current type to the target
3157 type before converting the underlying constant.
3159 2007-01-16 Marek Safar <marek.safar@gmail.com>
3161 * const.cs (ResolveValue): Updated after constant conversion was made more
3164 * constant.cs (GetAttributableValue): constant to object conversion is
3165 used for attributes only.
3166 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
3167 constant conversions.
3168 (LongConstant.ConvertImplicitly): Ditto.
3170 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
3171 (ImplicitConversionStandard): Handle constant conversion as extra step.
3172 It solves the issue when constant conversion was called indirectly like
3173 inside array initializer and constant folding was skipped.
3175 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
3178 * statement.cs(ImplicitConversionStandard): Updated after constant
3179 conversion was made more generic.
3181 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
3183 * expression.cs (As.DoResolve): Use GenericConstraints instead of
3184 Constraints, solves the problem where the compiler incorrectly
3185 reported that a type parameter was not constrained to a class (Bug
3188 2007-01-14 Marek Habersack <grendello@gmail.com>
3190 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
3192 2007-01-14 Marek Safar <marek.safar@gmail.com>
3194 A fix for bug #80368
3195 * assign.cs (FieldInitializer): New class implements field
3196 initializer statement.
3198 * attribute.cs: Update after FieldMember rename.
3200 * class.cs (PropertyBasedMember): New common class for property based
3202 (InterfaceMemberBase): New base class for all members which can be used as
3203 an interface members.
3204 (MethodCore): Moved really common code to InterfaceMemberBase.
3205 (Method.Define): Equal and GetHasCode detection is relevant for methods
3207 (MethodData.Define): Don't assume that public event implements an
3208 interface automatically.
3209 (MethodData.DefineMethodBuilder): Issue an error even if only extern
3211 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
3212 (FieldMember): Merged with FieldBase.
3213 (EventProperty.AEventPropertyAccessor): New specialization to check whether
3214 event extern modifier can be used.
3215 (EventField.EventFieldAccessor): Moved event field specific code here.
3216 (Event.AllowedModifiers): Even event can be extern.
3217 (Event.FindOutBaseMethod): New override specific to events.
3218 (Indexer.parameters): Reintroduce parameters because base class holds
3219 only properties common data.
3220 (Indexer.CheckForDuplications): Indexers are threated as methods so we
3221 need do extra parameters check.
3223 * const.cs: Update after FieldMember rename.
3225 * decl.cs (MemberCache.FindBaseEvent): New method.
3227 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
3228 to reflect that indexer is now derived from PropertyBased.
3230 * ecore.cs (GetMemberType): Made public.
3231 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
3234 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
3236 * typemanager.cs (CSharpSignature): Correctly print event accessors.
3237 (RegisterEvent): Removed.
3238 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
3239 (GetPrivateFieldOfEvent): Renamed to GetEventField.
3241 2007-01-11 Raja R Harinath <rharinath@novell.com>
3244 * statement.cs (CollectionForeach.TryType): Prefer generic
3245 GetEnumerator over non-generic variant. Fix code to follow comments.
3247 2007-01-09 Raja R Harinath <rharinath@novell.com>
3250 * support.cs (ReflectionParameter): Don't use an invalid index on
3251 the generic parameter data.
3253 2007-01-08 Miguel de Icaza <miguel@novell.com>
3255 * driver.cs: Just add a tiny bit of infrastructure.
3257 2007-01-02 Marek Safar <marek.safar@gmail.com>
3259 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
3260 where field type is struct from current assembly.
3262 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
3265 2007-01-02 Marek Safar <marek.safar@gmail.com>
3267 A fix for bug #80381
3268 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
3271 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
3273 (Namespace.LookupType): Always use core types from corlib when speficied.
3275 * report.cs: A new warning.
3277 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
3278 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
3279 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
3281 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
3282 (InitCoreTypes): Set expression type of object_type and value_type
3283 immediately after lookup.
3285 2007-01-01 Miguel de Icaza <miguel@novell.com>
3287 * cs-tokenizer.cs: Accept Pc class characters (Connector
3288 Punctuation) as valid identifiers. Fixes #78259
3290 * expression.cs (Invocation.DoResolve): Moved the check for the
3291 use of `this' for doing method calls to the Invocation resolution
3292 step, after overload resolution has taken place instead of doing
3293 the check at the low-level `This.DoResolve' level.
3295 The `This.DoResolve'(appens before overload resolution, so it has
3296 no way of knowing if the method that will be called will be
3297 instace or static, triggering an erroneous report for cs0188 (Bug
3300 We now do the check for instance method invocations after we know
3301 what method will be called.
3303 (This.CheckThisUsage): Move the actual use of this structure
3304 checking into its own method and expose it.
3306 * Everywhere that called Error_ValueCannotBeConverted: pass a new
3309 Exceptions: Null.ConvertImplicitly,
3310 Constant.ImplicitConversionRequired as there are too many call
3311 sites for passing the ec.
3313 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
3314 EmitContext, if the value is null, then we do not try to provide
3315 the extra information from the error (If a userdefined conversion
3316 exists, as UserDefinedConversion requires a non null-EmitContext).
3320 2006-12-30 Raja R Harinath <rharinath@novell.com>
3322 * flowanalysis.cs (MyBitVector): Document some invariants.
3323 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
3324 introduced below, and add a couple of others,
3326 2006-12-30 Marek Safar <marek.safar@gmail.com>
3328 * attribute.cs (GetMethodObsoleteAttribute): Uses new
3329 GetPropertyFromAccessor and GetEventFromAccessor.
3331 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
3332 overrides non-obsolete one.
3333 (Indexer.Define): Error message has been moved to the parser.
3335 * cs-parser.jay: Better syntax errors handling.
3337 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
3338 when an invocation has no arguments.
3340 * ecore.cs: Removed not used caching.
3342 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
3345 * report.cs: Add a new warning.
3347 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
3349 * typemanager.cs (enumeration_type): Removed.
3350 (CSharpSignature): Reuses IsSpecialMethod.
3351 (IsEqual): Hack for MS BCL.
3352 (GetPropertyFromAccessor): New method.
3353 (GetEventFromAccessor): New method.
3354 (IsSpecialMethod): Fixed to handle more cases.
3356 2006-12-30 Marek Safar <marek.safar@gmail.com>
3358 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
3359 Made white spaces array static.
3361 * ecore.cs (RemoveGenericArity): Optimized.
3363 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
3365 (MyBitVector.initialize_vector): Simplified.
3367 2006-12-22 Miguel de Icaza <miguel@novell.com>
3369 * ecore.cs: Am not entirely happy with this hack, but it seems to
3370 address the issue in 80257 (a small test case for
3373 I set the MethodGroupExpr.Type to an internal compiler type
3374 (itself in this case) to force the resolution to take place. Why
3375 it does not take place with a null is beyond me.
3377 2006-12-20 Marek Safar <marek.safar@gmail.com>
3379 A fix for bug #80288
3380 * expression.cs (ResolveOperator): Consider user defined conversion for
3381 logical and operator too.
3382 (EmitBranchable): Optimization for logical and when full constant folding
3383 could not be applied but one operand is constant.
3385 2006-12-19 Marek Safar <marek.safar@gmail.com>
3387 * class.cs (GetClassBases): Write 5 times every day, will never use
3388 FullName for error reporting.
3390 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
3392 2006-12-19 Martin Baulig <martin@ximian.com>
3394 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
3395 the symbol file info here.
3397 2006-12-18 Marek Safar <marek.safar@gmail.com>
3399 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
3400 of `elseif' is taking then following sections are not taking.
3401 Fixes an issue reported on mono mailing list.
3403 2006-12-18 Marek Safar <marek.safar@gmail.com>
3405 A fix for bug #80300
3406 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
3407 a caller is not taking.
3409 2006-12-18 Raja R Harinath <rharinath@novell.com>
3411 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
3412 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
3413 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
3414 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
3415 * class.cs: Update to changes.
3417 2006-12-17 Marek Safar <marek.safar@gmail.com>
3419 A fix for bug #79934
3420 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
3423 * class.cs (ResolveMembers): Register an iterator in current container and
3426 2006-12-16 Raja R Harinath <rharinath@novell.com>
3429 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
3430 satisfy a params annotated parameter.
3432 2006-12-16 Marek Safar <marek.safar@gmail.com>
3434 A fix for bug #77014
3435 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
3436 paramters correctly and not rely on hacks in Parameters class.
3437 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
3439 (Invocation.VerifyArgumentsCompat): Ditto.
3440 (Invocation.EmitArguments): Changed to correctly emit params arguments at
3443 * parameter.cs (HasParams): Don't assume that params is the last one.
3445 * support.cs (ReflectionParameters.ctor): Look for params attribute
3447 (ReflectionParameters.ParameterType): Removed hack when we returned last
3448 parameter for out of range parameters.
3449 (ParameterName, ParameterModifier): Ditto.
3451 2006-12-14 Marek Safar <marek.safar@gmail.com>
3453 A fix for bug #79987
3454 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
3455 when assembly is not CLS compliant but type is. I have no idea why is this
3458 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
3460 2006-12-13 Miguel de Icaza <miguel@novell.com>
3462 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
3463 in struct constructors, they are basically no-ops.
3465 2006-12-12 Marek Safar <marek.safar@gmail.com>
3467 * cs-tokenizer.cs (Position): Save preprocessor status too.
3469 2006-12-12 Marek Safar <marek.safar@gmail.com>
3471 A fix for bug #77794
3472 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
3474 2006-12-12 Marek Safar <marek.safar@gmail.com>
3476 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
3478 (pp_expr): Report error for an invalid expression.
3479 (handle_preprocessing_directive): Simplified; add more error checking.
3481 2006-12-11 Marek Safar <marek.safar@gmail.com>
3483 A fix for bug #74939
3484 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
3485 directives handling.
3487 2006-12-10 Marek Safar <marek.safar@gmail.com>
3489 A fix for bugs #80093, and #75984
3490 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
3491 logic, it seems to me as it worked before "by coincidence".
3492 (xtoken): Simplified to use reworked handle_preprocessing_directive.
3493 (cleanup): Enabled endif check.
3495 2006-12-09 Marek Safar <marek.safar@gmail.com>
3497 A fix for bug #80162
3498 * statement.cs (CollectionForeach.TryType): Generics and non-generics
3499 enumerators are never ambiguous.
3501 2006-12-08 Raja R Harinath <rharinath@novell.com>
3504 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
3506 2006-12-06 Marek Safar <marek.safar@gmail.com>
3508 A fix for bug #80144
3509 * class.cs (EventProperty.Define): Explicit implementation means
3510 that an even is used.
3512 2006-12-06 Marek Safar <marek.safar@gmail.com>
3514 Fixes the operators implementation (part II)
3516 * cfold.cs (DoConstantNumericPromotions): Renamed to
3517 DoBinaryNumericPromotions and simplified.
3518 (BinaryFold): Couple of conversion fixes; simplified.
3520 * constant.cs, ecore.cs, literal.cs
3521 (ToType): Renamed to ConvertImplicitly.
3522 (Reduce): Renamed to ConvertExplicitly.
3524 * class.cs, convert.cs: Updated.
3526 * expression.cs: TryReduce doesn't throw an exception.
3528 2006-12-01 Marek Safar <marek.safar@gmail.com>
3530 A fix for bug #80108
3531 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
3534 2006-11-30 Marek Safar <marek.safar@gmail.com>
3536 Fixes unary operators implementation (part I)
3539 * cfold.cs (Error_CompileTimeOverflow): Made internal
3541 * const.cs (IConstant): Changed to use reference to constant and
3542 not constant itself.
3543 Updated IConstant implementations.
3545 * constant.cs (CreateConstant): New factory method.
3546 Updated IConstant implementation.
3548 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
3550 * ecore.cs: Updated to use CreateConstantReference.
3552 * enum.cs: Reflects IConstant changes.
3554 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
3556 * literal.cs (NullConstant): Change to be independently usable.
3558 2006-11-29 Martin Baulig <martin@ximian.com>
3560 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
3561 we need to emit the scope initializer before calling the base .ctor.
3563 * anonymous.cs: Merged back from the new anonymous methods branch.
3564 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
3566 * expression.cs (ParameterReference.DoResolveBase): Create a
3567 "normal" ScopeInfo when capturing parameters rather than using the
3568 root scope; this makes things work with anonymous methods having
3572 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
3574 2006-11-22 Marek Safar <marek.safar@gmail.com>
3576 A fix for bug #79987
3577 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
3578 check to a base class.
3579 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
3580 only when assembly has missing attribute.
3581 * report.cs: Update.
3583 2006-11-21 Marek Safar <marek.safar@gmail.com>
3585 * cs-tokenizer.cs: Merged with gmcs version.
3587 2006-11-20 Marek Safar <marek.safar@gmail.com>
3590 * cs-parser.jay: Better error message when partial keyword is misplaced.
3592 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
3594 A fix for bug #79810
3595 report.cs: CS1058 only applies to 2.0 profile (gmcs).
3596 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
3597 a RuntimeWrappedException by default.
3599 2006-11-18 Marek Safar <marek.safar@gmail.com>
3601 A fix for bug #79843
3602 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
3604 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
3606 2006-11-18 Marek Safar <marek.safar@gmail.com>
3608 * driver.cs, namespace.cs: Uses faster IndexOf version.
3610 2006-11-17 Marek Safar <marek.safar@gmail.com>
3612 A fix for bug #79941
3613 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
3615 (Operator.Define): Implicit/Explicit operator of same type is duplicate
3616 even if internal name is different.
3617 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
3618 (UserDefinedConversion): Simplified as the operators cannot be internal.
3619 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
3621 (MethodLookup): Replaced EmitContext with parentType.
3622 * expression.cs: Updated.
3624 2006-11-09 Raja R Harinath <rharinath@novell.com>
3626 * driver.cs (BadAssembly): Handle all the ugliness of
3627 DefineDynamicAssembly.
3629 2006-11-08 Raja R Harinath <rharinath@novell.com>
3631 Address parts of #58244 -- most of what's left is in the runtime
3632 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
3633 CS1509 error checks, and handle them for all assembly loads, not
3634 just the first invocation.
3635 (LoadModule): Likewise. Move handling of 'adder_method' ...
3636 * codegen.cs (AssemblyClass.AddModule): ... here.
3638 2006-11-02 Marek Safar <marek.safar@gmail.com>
3640 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
3641 IEnumerable<T> is ambiguous.
3643 2006-10-31 Marek Safar <marek.safar@gmail.com>
3645 A fix for bug #67689
3646 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
3647 GetEnumerator is ambiguous.
3649 * report.cs: Add new warning.
3651 2006-10-29 Marek Safar <marek.safar@gmail.com>
3653 A fix for bug #78602
3654 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3655 to protected member can be nested type.
3657 2006-10-28 Marek Safar <marek.safar@gmail.com>
3659 A fix for bug #78965
3660 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3661 to protected member must derive from current type.
3663 2006-10-27 Marek Safar <marek.safar@gmail.com>
3665 assign.cs: Reuses error method.
3667 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
3668 instead of type for constants.
3669 (Expression.Error_ValueAssignment): Common error method.
3671 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
3674 2006-10-27 Marek Safar <marek.safar@gmail.com>
3676 A fix for bug #79081
3677 * expression.cs (MemberAccess.DoResolve): Check nested type
3680 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
3682 * doc.cs : nested delegates were not handled. Fixed bug #79754.
3684 2006-10-26 Marek Safar <marek.safar@gmail.com>
3686 A fix for bug #76591
3687 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
3689 2006-10-26 Marek Safar <marek.safar@gmail.com>
3691 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
3692 type forwarder of the same type multiple times.
3694 2006-10-26 Raja R Harinath <rharinath@novell.com>
3697 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
3698 instance as an rvalue, even when we later resolve as an lvalue.
3700 2006-10-25 Martin Baulig <martin@ximian.com>
3702 * anonymous.cs: Fix #79673.
3704 2006-10-24 Marek Safar <marek.safar@seznam.cz>
3706 A fix for bug #79666
3707 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
3708 ignored when is optimized (= default value) as its value is already set.
3710 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3712 A fix for bug #79724
3713 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
3714 TypeContainer for type lookup.
3716 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3718 A fix for bug #79231
3719 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
3720 * expression.cs (OverloadResolve): Always convert type name for
3722 (ResolveNamespaceOrType): Don't confuse a nested type with any
3725 2006-10-18 Martin Baulig <martin@ximian.com>
3727 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
3729 2006-10-17 Miguel de Icaza <miguel@novell.com>
3731 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
3732 an int32, but requesting an int64 from the conversion
3734 2006-10-12 Martin Baulig <martin@ximian.com>
3737 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
3739 2006-10-12 Martin Baulig <martin@ximian.com>
3742 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
3744 2006-10-11 Miguel de Icaza <miguel@novell.com>
3746 * convert.cs: Remove broken code: I was doing the "Existance"
3747 tests for Implicit conversions.
3749 2006-10-10 Miguel de Icaza <miguel@novell.com>
3751 * convert.cs: Added one missing case in
3752 ImplicitStandardConversionExists uint64 to intptr.
3756 * typemanager.cs (uintptr_type): another core known type.
3758 * ecore.cs (OperatorCast): routine used to do cast operations that
3759 depend on op_Explicit. We could change some of the Decimal
3760 conversions to use this.
3762 This one has a probe mechanism that checks both types for an op_
3763 which it coudl be used to eliminate two classes: CastToDecimal
3764 and CastFromDecimal.
3766 * convert.cs: Implement the conversions documented in #59800
3768 2006-10-10 Martin Baulig <martin@ximian.com>
3770 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
3771 before RootScope.ResolveMembers().
3773 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
3774 `CurrentType' if appropriate.
3776 2006-10-09 Marek Safar <marek.safar@seznam.cz>
3778 A fix for bug #78568
3779 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
3780 when contains binary operators.
3781 * cs-parser.jay: Updated.
3783 2006-10-09 Martin Baulig <martin@ximian.com>
3786 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
3787 moved that into Define() and also do the other type parameter
3788 checks there. Fixes #79094. Added gtest-292.cs.
3791 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
3792 since that doesn't include type parameters; don't use `Ldelema'
3793 for type parameters. Fixes #78980. Added gtest-293.cs.
3795 2006-10-08 Marek Safar <marek.safar@seznam.cz>
3798 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
3799 conversion is allowed.
3801 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3803 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
3804 error reporting when no error occurs.
3806 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3808 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
3811 2006-10-06 Raja R Harinath <rharinath@novell.com>
3814 * class.cs (DefineTypeBuilder): Check circular dependencies before
3815 setting the parent of the TypeBuilder.
3816 (CheckRecursiveDefinition): Don't use 'BaseType', since
3817 it may not be valid until after DefineTypeBuilder. Use
3818 'base_type' instead.
3820 2006-10-04 Martin Baulig <martin@ximian.com>
3822 Merged the Anonymous Methods patch.
3824 * anonymous.cs, iterators.cs: The new anonymous methods code.
3826 * statement.cs (Variable): New public abstract class.
3827 (LocalInfo.Variable): New public property.
3828 (LocalInfo.ResolveVariable): New public method.
3829 (Block.Flags): Add `IsIterator'.
3830 (Block.AddVariable): Improved the CS0136 check.
3831 (Block.AnonymousChildren): New public property.
3832 (Block.AddAnonymousChild): New public method.
3833 (ToplevelBlock): Update to use the new anonymous method framework.
3834 (ToplevelBlock.ctor): `container' is now a `Block' and not a
3835 `ToplevelBlock'; this is required to correctly implement the
3837 (Fixed, Using): Use `TemporaryVariable' instead of directly
3838 creating the `LocalBuilder'.
3840 * parameter.cs (Parameter.ResolveVariable): New public method.
3841 (Parameters.ResolveVariable): Likewise.
3843 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
3845 * class.cs (TypeContainer): Replaced the `iterators' list and
3846 corresponding methods with a list of `CompilerGeneratedClass'es.
3847 (TypeContainer.ResolveMembers): New public method.
3848 (Method): `IIteratorContainer' has been replaced by
3851 * expression.cs (VariableReference): New public abstract base
3852 class for `LocalVariableReference', `ParameterReference' and
3855 * codegen.cs (EmitContext): Removed `capture_context',
3856 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
3857 (EmitContext.EmitThis): Removed.
3859 * cs-parser.jay: Replace `iterator_container' with
3862 2006-10-04 Martin Baulig <martin@ximian.com>
3864 * generic.cs (GenericMethod): Don't make this abstract.
3865 (Constraints.Clone): Added dummy implementation.
3867 2006-10-04 Raja R Harinath <harinath@gmail.com>
3870 * namespace.cs (LookForAnyGenericType): Avoid nullref on
3871 'declspaces'. Avoid allocating arrays willy-nilly.
3874 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
3875 cases out of the switch.
3877 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3879 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
3880 message when non-generic type is used with the type arguments.
3881 * expression.cs: Updated.
3883 2006-09-28 Raja R Harinath <rharinath@novell.com>
3886 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
3887 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
3888 Change semantics slightly. Don't insist on having only one
3889 temporary EmptyExpression -- just throttle the creation of new ones.
3892 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
3893 non-interfaces too. If no methods are found, don't try to create
3896 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3898 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
3901 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
3902 us produce better error message.
3904 2006-09-27 Marek Safar <marek.safar@seznam.cz>
3906 * expression.cs (Binary.ResolveOperator): Warn about a side effect
3907 of the `|' operator.
3909 * report.cs: A new warning added.
3911 2006-09-27 Martin Baulig <martin@ximian.com>
3913 * generic.cs (GenericMethod): Don't make this abstract.
3915 2006-09-27 Martin Baulig <martin@ximian.com>
3918 (InternalErrorException): Added overloaded ctor taking a params array.
3920 2006-09-26 Marek Safar <marek.safar@seznam.cz>
3922 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
3923 Fixed the cases when same error was reported twice.
3925 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
3926 now report symbol information.
3928 2006-09-25 Martin Baulig <martin@ximian.com>
3930 * class.cs: Completely unified with the gmcs version.
3932 2006-09-25 Martin Baulig <martin@ximian.com>
3934 * typemanager.cs (TypeManager.IsNullableType): New public function.
3935 (TypeManager.IsNullableTypeOf): Likewise.
3936 (TypeManager.IsNullableValueType): Likewise.
3938 * class.cs (MethodCore): Added the `GenericMethod' argument from
3939 gmcs and also unified all classes derived from `MethodCore' with gmcs.
3941 2006-09-24 Raja R Harinath <harinath@gmail.com>
3943 * convert.cs: Unify with gmcs version.
3945 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3947 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
3948 verify them as well.
3950 * report.cs: New warning.
3952 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3954 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
3955 for anonymous block with out argument.
3957 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3959 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
3960 not used private events only.
3962 2006-09-23 Marek Safar <marek.safar@seznam.cz>
3964 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
3966 * const.cs (Const.Define): Check for constant type.
3967 (Const.IsConstantTypeValid): Looks for valid constant types.
3969 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
3971 * ecore.cs (EmptyConstantCast): New common class for all constant based
3974 * expression.cs (Is.DoResolve): Handle null constant especially.
3975 (New.DoResolve): Check for new void().
3976 (MemberAccess.DoResolve): Cope with all kind of nulls.
3978 * literal.cs (NullConstant): Uses EmptyConstantCast.
3979 (NullDefault): Based on EmptyConstantCast.
3980 (NullLiteral): Uses EmptyConstantCast.
3982 * statement.cs (Block.ResolveMeta): Check for constant type.
3984 2006-09-22 Martin Baulig <martin@ximian.com>
3986 * delegate.cs, attribute.cs: Merged with the gmcs versions.
3988 2006-09-22 Raja R Harinath <rharinath@novell.com>
3990 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
3994 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
3995 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
3998 2006-09-22 Martin Baulig <martin@ximian.com>
4000 * ecore.cs: Merged with the gmcs version.
4002 * generic.cs (ConstructedType): New dummy class.
4003 (TypeArguments): Don't make this abstract.
4006 (TypeManager.IsGenericTypeDefinition): New method.
4007 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
4009 2006-09-22 Raja R Harinath <rharinath@novell.com>
4011 * expression.cs (ComposedCast): Check for arrays of TypedReference
4012 before creating the type, not after.
4014 2006-09-21 Marek Safar <marek.safar@seznam.cz>
4016 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
4017 after ToType change.
4019 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
4020 when constant must be implicitly convertible.
4022 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
4024 * ecore.cs (NullCast): Derives from NullConstant.
4026 * expression.cs (Is.DoResolve): Removed useless variables.
4027 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
4028 (New.Constantify): Add enum support.
4029 (MemberAccess.DoResolve): Add warning when accessing null constant or
4032 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
4035 * literal.cs (NullConstant): New abstract class with common
4036 functionality for all null specializations.
4037 (NullDefault): Represents default(X) when result can be
4039 (NullLiteral): Updated.
4041 * report.cs: Add new warning.
4043 2006-09-21 Martin Baulig <martin@ximian.com>
4045 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
4047 2006-09-21 Martin Baulig <martin@ximian.com>
4049 * generic.cs (GenericConstraints): New dummy class.
4050 (Constraints): Likewise.
4051 (TypeParameter): Likewise.
4052 (TypeParameterName): Likewise.
4053 (GenericMethod): Likewise.
4055 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4057 * decl.cs: Merged with the gmcs version.
4059 2006-09-21 Raja R Harinath <rharinath@novell.com>
4061 * generic.cs (TypeParameter): Implement IMemberContainer.
4062 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
4064 * rootcontext.cs: Unify with gmcs version.
4066 * report.cs: Unify with gmcs version.
4067 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
4068 from gmcs/generics.cs.
4069 * generics.cs (TypeParameter): New dummy class.
4071 * support.cs: Unify with gmcs version.
4073 2006-09-20 Raja R Harinath <rharinath@novell.com>
4075 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
4076 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
4078 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
4079 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
4080 * mcs.exe.sources: Add generic.cs.
4082 * codegen.cs: Unify with gmcs version.
4084 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
4085 (EmitContext): Add GenericDeclContainer implementation.
4086 * decl.cs (MemberCore, DeclSpace): Likewise.
4087 * namespace.cs: Remove #ifdef GMCS_SOURCE.
4089 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
4090 MCS TypeManager has a corresponding dummy method.
4092 2006-09-19 Martin Baulig <martin@ximian.com>
4094 * expression.cs: Completely merged with the gmcs version.
4096 2006-09-19 Martin Baulig <martin@ximian.com>
4098 * expression.cs (Invocation): Merged with the gmcs version.
4099 (ArrayAccess.GetStoreOpcode): Likewise.
4101 2006-09-19 Martin Baulig <martin@ximian.com>
4104 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
4105 (TypeManager.IsGenericMethodDefinition): Likewise.
4107 2006-09-19 Martin Baulig <martin@ximian.com>
4110 (TypeManager.IsEqual): Moved the gmcs implementation here.
4111 (TypeManager.DropGenericTypeArguments): Likewise.
4112 (TypeManager.DropGenericMethodArguments): Likewise.
4113 (TypeManager.GetTypeArguments): Moved here from gmcs.
4114 (TypeManager.HasGenericArguments): Likewise.
4116 2006-09-19 Martin Baulig <martin@ximian.com>
4118 * expression.cs (Binary): Merged with the gmcs version.
4120 2006-09-19 Martin Baulig <martin@ximian.com>
4122 * expression.cs (Probe, As, Is): Merged with the gmcs version.
4124 2006-09-19 Martin Baulig <martin@ximian.com>
4126 * typemanager.cs: Merged with the gmcs version.
4128 2006-09-16 Raja R Harinath <rharinath@novell.com>
4130 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
4131 * driver.cs: Likewise.
4133 2006-09-16 Marek Safar <marek.safar@seznam.cz>
4136 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
4137 only if parent type is class.
4138 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
4141 2006-09-15 Marek Safar <marek.safar@seznam.cz>
4144 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
4146 * typemanager.cs(CSharpName): Converts NullType to null.
4148 2006-09-15 Martin Baulig <martin@ximian.com>
4151 (TypeManager.GetMethodName): Added mcs implementation.
4152 (TypeManager.IsEqual): Likewise.
4155 (SimpleName.RemoveGenericArity): Added dummy implementation.
4157 * pending.cs: Merged with the gmcs version.
4159 2006-09-15 Martin Baulig <martin@ximian.com>
4161 * statement.cs: Merge with the gmcs version.
4163 2006-09-15 Martin Baulig <martin@ximian.com>
4165 * statement.cs (Switch): Merge with the gmcs implementation
4166 (without nullables), which is newer.
4168 2006-09-15 Martin Baulig <martin@ximian.com>
4170 * statement.cs (Block.Variables): Make this public.
4171 (ToplevelBlock.Parameters): Make this a property.
4172 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
4174 2006-09-15 Martin Baulig <martin@ximian.com>
4176 * namespace.cs: Merge with the gmcs version.
4178 2006-09-15 Martin Baulig <martin@ximian.com>
4180 * decl.cs (MemberName): Minor code cleanups.
4182 2006-09-15 Martin Baulig <martin@ximian.com>
4184 * parameter.cs: Merge with the gmcs version.
4186 2006-09-15 Martin Baulig <martin@ximian.com>
4188 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
4189 and an error in mcs.
4191 2006-09-15 Martin Baulig <martin@ximian.com>
4193 * flowanalysis.cs: Merged from GMCS; added the generics code into
4194 a `GMCS_SOURCE' conditional so we can share this file.
4196 2006-09-08 Martin Baulig <martin@ximian.com>
4198 * typemanager.cs (TypeManager.interlocked_type): New public field.
4199 (TypeManager.int_interlocked_compare-exchange): New public field.
4200 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
4201 enumerator types here and call InitGenericCoreTypes().
4202 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
4203 after calling InitEnumUnderlyingTypes().
4206 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
4207 `classes_second_stage'.
4209 2006-09-14 Marek Safar <marek.safar@seznam.cz>
4211 * assign.cs, ecore.cs, expression.cs: Share error message text.
4212 * class.cs (FieldMember.Define): Check for varible of static type.
4213 * driver.cs (LoadAssembly): Uses error output for errors.
4214 * statement.cs: Updated.
4216 2006-09-08 Marek Safar <marek.safar@seznam.cz>
4218 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
4221 2006-09-07 Martin Baulig <martin@ximian.com>
4224 (MainDriver): Revert r62663 from Marek; see #70506 for details.
4226 2006-08-29 Miguel de Icaza <miguel@novell.com>
4228 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
4230 2006-08-17 Miguel de Icaza <miguel@novell.com>
4232 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
4233 #52019 and #79064, the use of the \uXXXX sequence in source code
4234 to represent unicode characters.
4236 2006-08-15 Marek Safar <marek.safar@seznam.cz>
4238 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
4240 * class.cs, ecore.cs, statement.cs: Merged to one error message.
4242 2006-08-13 Miguel de Icaza <miguel@novell.com>
4244 * assign.cs: Catch attempts to assign to a method groups in += and
4247 2006-08-13 Marek Safar <marek.safar@seznam.cz>
4250 * cs-parser.jay: Don't destroy current array type by typeof of array's.
4252 2006-08-12 Marek Safar <marek.safar@seznam.cz>
4254 * class.cs (Method.Define): Issue a warning when generic method looks like
4256 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
4259 2006-08-09 Marek Safar <marek.safar@seznam.cz>
4261 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
4263 * decl.cs (MemberCache.FindMembers): When container is interface we need to
4264 search all base interfaces as a member can be ambiguous.
4265 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
4266 Constructor member type filter.
4267 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
4268 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
4269 reporting for returned memberinfos.
4270 * report.cs: Updated.
4271 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
4272 version to work on all runtimes.
4273 (TypeManager.RealMemberLookup): Removed members filtering.
4275 2006-08-08 Raja R Harinath <rharinath@novell.com>
4277 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
4278 (PropertyExpr.EmitAssign): Likewise.
4279 * expression.cs (Indirection.EmitAssign): Likewise.
4280 (LocalVariableReference.EmitAssign): Likewise.
4281 (ParameterReference.EmitAssign): Likewise.
4282 (Invocation.EmitArguments): Likewise.
4283 (ArrayAccess.EmitAssign): Likewise.
4284 (IndexerAccess.EmitAssign): Likewise.
4285 (This.EmitAssign): Likewise.
4286 (ConditionalLogicalOperator.Emit): Likewise.
4289 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
4290 instead of ArrayList. If the hashtable has a LocalBuilder, don't
4291 leave it in after returning it.
4292 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
4294 2006-08-06 Marek Safar <marek.safar@seznam.cz>
4296 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
4299 2006-08-03 Raja R Harinath <rharinath@novell.com>
4301 Fix cs0146-3.cs and cs0146-4.cs.
4302 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
4303 enclosing types don't depend on the current type.
4305 2006-08-02 Raja R Harinath <rharinath@novell.com>
4308 * class.cs (TypeContainer.DoDefineMembers): Use
4309 FindBaseMemberWithSameName on Parent, since we're interested in
4310 whether we hide inherited members or not.
4311 (FindBaseMemberWithSameName): Make slightly more robust.
4313 Fix the non-generic testcase from #77396
4314 * decl.cs (DeclSpace.DeclContainer): Remove override.
4316 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
4317 declspaces for doppelgangers too.
4318 (UsingEntry): Implement IResolveContext.
4319 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
4320 'this' as the resolve context.
4321 (LocalAliasEntry): Likewise.
4323 Implement parts of #77403
4324 * roottypes.cs (RootDeclSpace): New. Used to represent the
4325 toplevel declaration space. Each namespace declaration introduces
4326 a "partial" root declaretion space.
4327 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
4328 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
4329 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
4330 from 'current_namespace.SlaveDeclSpace'.
4331 (namespace_declaration): Likewise.
4332 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
4333 check. It can't happen now.
4334 * decl.cs (DeclSpace.LookupType): Likewise.
4335 * driver.cs (MainDriver): Sanity check.
4337 2006-08-01 Raja R Harinath <rharinath@novell.com>
4339 * decl.cs (DeclSpace.FindNestedType): Remove.
4340 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
4341 LookupTypeContainer to get the container of the nested type.
4342 * class.cs (TypeContainer.FindNestedType): Make non-override.
4344 2006-07-31 Raja R Harinath <rharinath@novell.com>
4346 * decl.cs (DeclSpace.PartialContainer): Move field from ...
4347 * class.cs (TypeContainer.PartialContainer): ... here.
4348 (TypeContainer.AddBasesForPart): New helper.
4349 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
4351 * cs-parser.jay (current_class): Convert to DeclSpace.
4352 (struct_declaration, interface_declaration, class_declaration):
4353 Use AddBasesForPart instead of .Bases directly.
4354 * const.cs, iterators.cs: Update to changes.
4356 2006-07-28 Raja R Harinath <rharinath@novell.com>
4358 * class.cs (TypeContainer.AddMemberType): Rename from
4360 (TypeContainer.AddMember): Rename from AddToMemberContainer.
4361 (AddTypeContainer): New. Combine AddClassOrStruct and
4363 (AddPartial): Update. Add 'is_partial' argument.
4364 * roottypes.cs: Update to changes.
4365 * cs-parser.jay (push_current_class): New helper for handling
4366 current_container and current_class.
4367 (struct_declaration, interface_declaration, class_declaration):
4370 2006-07-26 Raja R Harinath <rharinath@novell.com>
4372 * roottypes.cs: Rename from tree.cs.
4374 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
4375 * tree.cs (Tree, ITreeDump): Remove types.
4376 * rootcontext.cs (tree, Tree): Remove fields.
4377 (root, ToplevelTypes): New.
4378 * *.cs: Update to rename.
4380 * tree.cs (Tree.RecordDecl): Remove.
4381 (RootTypes.AddToTypeContainer): Record the toplevel type in its
4383 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
4385 2006-07-23 Raja R Harinath <harinath@gmail.com>
4387 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
4388 DoFlowAnalysis and OmitStructFlowAnalysis here.
4389 (ec.With): Rename from WithUnsafe and generalize.
4390 (ec.WithCheckState): Remove. All users can be handled by 'With'.
4391 (ec.WithFlowAnalyis): New.
4392 * ecore.cs, expression.cs, statement.cs: Update.
4394 2006-07-22 Raja R Harinath <harinath@gmail.com>
4396 * statement.cs (Block.ResolveMeta): Simplify slightly.
4398 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
4399 multiple boolean fields. Convert InUnsafe, constant_check_state,
4400 check_state to flags.
4401 (CheckState, ConstantCheckState): Update.
4402 (InUnsafe): New read-only property.
4403 (FlagsHandle): Rename from CheckStateHandle and convert to handle
4405 (WithUnsafe): New helper similar to WithCheckState.
4406 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
4407 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
4409 2006-07-21 Raja R Harinath <rharinath@novell.com>
4411 Make comparisons use the same IL irrespective of whether they're
4412 in a 'checked' or 'unchecked' context: one of the issues in #78899
4413 * codegen.cs (EmitContext.CheckState): Make read-only property.
4414 (EmitContext.ConstantCheckState): Likewise.
4415 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
4416 helper that implement a save/restore stack for CheckState
4417 values. This is the only way to change check-state.
4418 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
4419 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
4420 (CheckedExpr.EmitBranchable): New forwarding method.
4421 (UnCheckedExpr): Likewise.
4422 * statement.cs (Block.ResolveMeta): Use WithCheckState.
4423 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
4424 (Checked.Resolve, checked.DoEmit): Likewise.
4426 2006-07-20 Miguel de Icaza <miguel@novell.com>
4428 * anonymous.cs: Cache the resolved anonymous delegate, and return
4429 this so that the ResolveTopBlock is only triggered once, not
4432 Currently we trigger ResolvetopBlock twice due to a first pass of
4433 argument check compatibility, and a second pass that does the
4436 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4438 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
4440 * rootcontext.cs (Reset): Add helper_classes.
4442 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4445 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
4448 2006-07-13 Miguel de Icaza <miguel@novell.com>
4450 * statement.cs (Lock): Handle expressions of type
4451 TypeManager.null_type specially. Fixes #78770
4453 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4455 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
4458 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4460 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
4461 for accessors as well.
4462 * ecore.cs (EventExpr): Add AccessorTable.
4464 2006-07-01 Marek Safar <marek.safar@seznam.cz>
4467 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
4468 for CS0122 where appropriate.
4469 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
4471 (Filter): Assembly can be null in the case of top level attributes.
4473 2006-06-25 Marek Safar <marek.safar@seznam.cz>
4477 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
4478 is done at global level.
4480 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4482 A fix for #77002, Implemented TypeForwarder support.
4484 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
4485 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
4486 * typemanager.cs (): Add type_forwarder_attr_type.
4488 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4490 * report.cs: Add CS0469 warning.
4492 2006-06-21 Martin Baulig <martin@ximian.com>
4494 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
4495 the `try'-block, so we also report CS0016 etc. there.
4497 2006-06-21 Martin Baulig <martin@ximian.com>
4500 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
4502 2006-06-21 Martin Baulig <martin@ximian.com>
4504 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
4505 also report CS1686 for parameters.
4507 2006-06-21 Martin Baulig <martin@ximian.com>
4509 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
4510 instead of an error if the value is not implicitly convertible to
4511 the switch types; fixes #77964.
4513 2006-06-21 Raja R Harinath <rharinath@novell.com>
4516 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
4517 FieldBuilder is null.
4520 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
4521 'left' and 'right' before error-checking.
4523 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
4525 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
4527 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
4528 (FieldExpr.DoResolve): likewise.
4529 (PropertyExpr.InstanceResolve): likewise.
4530 (EventExpr.InstanceResolve): likewise.
4532 2006-06-04 Marek Safar <marek.safar@seznam.cz>
4534 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
4535 attribute applicable tests for attribute argument.
4537 2006-06-02 Raja R Harinath <rharinath@novell.com>
4540 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
4541 (Binary.OverloadResolve_PredefinedIntegral): New.
4542 (Binary.OverloadResolve_PredefinedFloating): New.
4543 (Binary.OverloadResolve_PredefinedString): New.
4544 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
4545 Follow the standard more closely, and treat numeric promotions in
4546 terms of overload resolution.
4547 (Binary.CheckShiftArguments): Simplify.
4549 2006-06-01 Raja R Harinath <rharinath@novell.com>
4551 * flowanalysis.cs (MyBitVector): Simplify representation.
4552 (MyBitVector.Clone): Avoid allocating BitArray.
4553 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
4554 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
4555 (*): Update. Change all references to MyBitVector.And and
4556 MyBitVector.Or to &= and |=.
4558 2006-05-29 Raja R Harinath <rharinath@novell.com>
4561 * cs-parser.jay (formal_parameter_list): Extend the pattern below
4562 to param arguments too.
4564 2006-05-26 Miguel de Icaza <miguel@novell.com>
4566 * cs-parser.jay: Catch another parsing form for arglist being
4567 followed by other arguments. Fixes #78313.
4569 2006-05-24 Raja R Harinath <rharinath@novell.com>
4571 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
4572 checking of out parameters to ...
4573 (FlowBranchingToplevel.Merge): ... here.
4574 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
4575 set, propagate the origin upward, and only complain if there was
4577 (FlowBranchingException.AddContinueOrigin): Likewise.
4578 (FlowBranchingException.AddReturnOrigin): Likewise.
4579 (FlowBranchingException.AddGotoOrigin): Likewise.
4581 2006-05-23 Raja R Harinath <rharinath@novell.com>
4583 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
4584 unreachable, skip it.
4585 (FlowBranchingException.Merge): Always propagate jumps, even if
4586 the finally block renders subsequent code unreachable.
4588 2006-05-18 Raja R Harinath <rharinath@novell.com>
4591 * statement.cs (Goto.Resolve): Move responsibility for resolving
4592 'goto' to FlowBranching.AddGotoOrigin.
4593 (Goto.SetResolvedTarget): New. Callback to set the
4594 LabeledStatement that's the target of the goto.
4595 (Goto.DoEmit): Use Leave instead of Br when crossing an
4596 unwind-protect boundary.
4597 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
4598 LookupLabel and adjust to new semantics.
4599 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
4600 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
4601 Goto.SetResolvedTarget to update target.
4602 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
4603 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
4604 AddBreakOrigin & co. Delay propagation until ...
4605 (FlowBranchingException.Merge): ... this.
4607 * statement.cs (Block.Resolve): Always depend on flow-branching to
4608 determine unreachability. Kill workaround that originally emitted
4609 only one statement after an "unreachable" label (see infloop in
4612 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
4613 This is still "wrong", but anything better would probably need a
4614 multi-pass algorithm.
4615 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
4616 usage vector. Force current usage vector to be reachable, to
4617 optimistically signify backward jumps.
4618 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
4620 (FlowBranchingLabeled.Merge): New. If no backward jump was
4621 detected, return the original salted-away usage vector instead,
4622 updated with appropriate changes. Print unreachable warning if
4624 * statement.cs (Block.Resolve): Don't print unreachable warning on
4625 a labeled statement.
4627 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
4629 * driver.cs: Pass filename without path to AssemblyBuilder's
4630 AddResourceFile. Fixes bug #78407.
4632 2006-05-17 Raja R Harinath <rharinath@novell.com>
4634 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
4635 * flowanalysis.cs (FlowBranchingLabeled): ... here.
4636 (FlowBranching.MergeChild): Overwrite
4637 reachability information from Labeled branchings too.
4639 2006-05-16 Raja R Harinath <rharinath@novell.com>
4641 * statement.cs (Goto.Resolve): Merge jump origins here ...
4642 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
4644 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
4645 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
4646 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
4647 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
4649 * statement.cs (Goto.Resolve): ... not here.
4650 (Goto.Emit): Remove CS1632 check.
4652 2006-05-14 Marek Safar <marek.safar@seznam.cz>
4654 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
4657 2006-05-11 Raja R Harinath <rharinath@novell.com>
4659 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
4660 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
4661 (FlowBranchingException.Label): Likewise.
4663 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
4665 (MyBitVector.Or): Use it to avoid losing information (Count).
4666 (FlowBranching.MergeOrigins): Likewise.
4668 * flowanalysis.cs (UsageVector.IsDirty): Remove.
4669 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
4670 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
4671 (UsageVector.ToString): Simplify.
4672 (UsageVector.MergeSiblings): Move here from ...
4673 (FlowBranching.Merge): ... here.
4674 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
4677 2006-05-10 Raja R Harinath <rharinath@novell.com>
4679 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
4680 null bitvector is treated as all-true.
4682 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
4683 (MyBitVector): Rationalize invariants. 'vector != null' implies
4684 that we have our own copy of the bitvector. Otherwise,
4685 'InheritsFrom == null' implies all inherited bits are true.
4687 2006-05-09 Marek Safar <marek.safar@seznam.cz>
4689 * statement.cs (LocalInfo): Add IsConstant.
4690 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
4691 local variable for constants.
4693 2006-05-09 Raja R Harinath <rharinath@novell.com>
4695 * flowanalysis.cs (MyBitVector.Empty): New.
4696 (MyBitVector): Don't allow InheritedFrom to be null.
4697 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
4698 (UsageVector, FlowBranching): Update to changes.
4700 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
4701 recursion. The 'Parent == null' condition isn't sufficient for
4703 (FlowBranching.AddBreakOrigin): Likewise.
4704 (FlowBranching.AddContinueOrigin): Likewise.
4705 (FlowBranching.AddReturnOrigin): Likewise.
4706 (FlowBranching.StealFinallyClauses): Likewise.
4707 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
4708 (FlowBranching.CheckOutParameters): Likewise.
4709 (FlowBranchingToplevel): Terminate all the above recursions here.
4710 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
4711 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
4713 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
4715 (FlowBranchingToplevel): New. Empty for now.
4716 (FlowBranching.MergeTopBlock): Update.
4717 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
4718 branching for the anonymous delegate.
4719 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
4721 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
4722 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
4723 information at the start of the merge. Reorganize.
4725 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4727 * class.cs (MethodData.Define): Method cannot implement interface accessor.
4729 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4731 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
4732 to newly introduced ctor.
4734 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
4735 message to one place.
4736 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
4739 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4741 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
4743 * ecore.cs (Expression.ResolveAsConstant): Updated.
4745 * statement.cs (ResolveMeta): Updated.
4747 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4749 * cs-parser.jay: __arglist cannot be used in initializer.
4751 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4754 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
4757 2006-05-05 Raja R Harinath <rharinath@novell.com>
4759 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
4760 (LabeledStatement): Add 'name' parameter.
4761 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
4762 (Block.AddLabel): Update to changes.
4763 * cs-parser.jay (labeled_statement): Likewise.
4765 * flowanalysis.cs (BranchingType.Labeled): New.
4766 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
4767 (FlowBranchingLabeled): New. Does nothing for now, but will
4768 eventually handle 'goto' flows.
4769 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
4770 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
4771 that's terminated ...
4772 (Block.Resolve): ... here.
4774 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
4775 (UsageVector.MergeFinallyOrigins): Likewise.
4776 (FlowBranching.InTryOrCatch): Likewise.
4777 (FlowBranching.AddFinallyVector): Likewise.
4778 (FlowBranchingException): Update to changes.
4781 * statement.cs (Return.Resolve): Move error checking to ...
4782 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
4783 (FlowBranchingException): Handle return origins like break and
4785 (FlowBranching.UsageVector.CheckOutParameters): Remove.
4787 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4790 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
4793 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4796 * class.cs (MethodData.Define): Do public accessor check only when method
4797 implements an interface.
4799 2006-05-04 Raja R Harinath <rharinath@novell.com>
4801 Remove special handling of 'break'
4802 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
4803 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
4804 (UsageVector.Break): Remove.
4805 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
4807 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
4809 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
4810 UsageVector.Breaks (). Don't set NeedsReturnLabel.
4812 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4815 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
4816 be the interface member.
4818 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4821 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
4822 for emitting small (int) values.
4824 2006-05-03 Raja R Harinath <rharinath@novell.com>
4827 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
4828 control-flow passes through the 'finally' after merging-in all the
4829 control-flows from 'try' and the 'catch' clauses.
4831 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
4832 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
4833 always true at the only non-recursive entry point.
4834 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
4835 FlowBranchingBreakable.
4836 (FlowBranchingLoop): Remove.
4837 * statement.cs (Return.DoResolve): Update to changes.
4840 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
4841 (FlowBranching.CreateBranching): Handle it: create a
4842 FlowBranchingContinuable.
4843 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
4844 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
4845 except that it handles the 'continue' command.
4846 (FlowBranching.UsageVector.MergeOrigins): Rename from
4848 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
4849 except that it overrides AddContinueOrigin.
4850 (FlowBranchingException): Override AddContinueOrigin, similar to
4852 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
4853 Create a new branching around the embedded statement.
4854 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
4855 control flow after the embedded statement.
4856 (Continue.Resolve): Move all error checking to AddContinueOrigin.
4858 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
4859 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
4860 FlowBranchingBreakable.
4861 (FlowBranchingSwitch): Remove.
4864 * statement.cs (Break.Resolve): Simplify. Move responsibility for
4865 error reporting to ...
4866 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
4867 Rename from 'AddBreakVector'. Add new location argument. Return
4868 a bool indicating whether the 'break' crosses an unwind-protect.
4869 (FlowBranchingException.AddBreakOrigin): Add.
4870 (FlowBranchingException.Merge): Propagate 'break's to surrounding
4871 flowbranching after updating with the effects of the 'finally'
4873 (FlowBranchingBreakable): New common base class for
4874 FlowBranchingLoop and FlowBranchingSwitch.
4876 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
4878 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
4880 2006-05-02 Raja R Harinath <rharinath@novell.com>
4882 * statement.cs (Do.Resolve): If the loop is infinite, set the
4884 (While.Resolve, For.Resolve): Set a barrier after the embedded
4885 statement. There's no direct control flow that goes from the end
4886 of the embedded statement to the end of the loop.
4887 * flowanalysis.cs (FlowBranching.Infinite): Remove.
4888 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
4889 above ensure that the reachability is correctly computed.
4891 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
4892 (UsageVector.MergeBreakOrigins): If the current path is
4893 unreachable, treat it as if all parameters/locals are initialized.
4894 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
4895 infinite loops before merging-in break origins.
4897 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
4898 (Reachability.Reachable): Split part into ...
4899 (Reachability.Unreachable): ... this. Simplify.
4900 (Reachability.IsUnreachable): Use 'Unreachable' instead.
4902 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
4903 (Reachability.SetThrowsSometimes): Likewise.
4904 (FlowBranchingBlock.MergeTopBlock): Don't compare against
4905 TriState.Always, use corresponding property.
4906 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
4907 (Block.Resolve): Likewise. Remove some redundant checks.
4909 2006-05-02 Raja R Harinath <harinath@gmail.com>
4911 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
4912 (Reachability.Meet): Don't bother checking AlwaysThrows --
4913 barrier is always set.
4914 (FlowBranchingBlock.Merge): Likewise.
4916 2006-05-01 Raja R Harinath <harinath@gmail.com>
4918 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
4919 checks for unreachable.
4921 2006-05-01 Marek Safar <marek.safar@seznam.cz>
4924 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
4926 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
4927 whether field is really assigned.
4929 2006-04-30 Raja R Harinath <harinath@gmail.com>
4931 * flowanalysis.cs (Reachability): Make 4-argument constructor
4933 (Reachability.Meet): Rename from 'And'. Remove static variant.
4934 (Reachability.Always): Rename from the highly misleading
4935 'Reachability.Never'.
4936 (FlowBranching.Merge): Update to changes. Mark an impossible
4937 situation with a 'throw'.
4938 (*): Update to changes.
4940 2006-04-29 Raja R Harinath <harinath@gmail.com>
4942 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
4944 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
4945 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
4946 (*): Update to changes.
4947 * statement.cs: Update to changes.
4949 2006-04-28 Marek Safar <marek.safar@seznam.cz>
4952 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
4954 2006-04-28 Raja R Harinath <harinath@gmail.com>
4956 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
4959 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
4960 argument to two arguments: an usage-vector and a bool. Move call
4961 to FlowBranching.Merge () ...
4962 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
4964 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
4965 handling of loop and switch reachability to ...
4966 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
4968 2006-04-27 Raja R Harinath <harinath@gmail.com>
4970 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
4971 handling to FlowBranchingLoop.InLoop.
4972 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
4974 2006-04-26 Marek Safar <marek.safar@seznam.cz>
4977 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
4978 anonymous method is allowed from AnonymousContainer here.
4980 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
4982 2006-04-24 Raja R Harinath <rharinath@novell.com>
4985 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
4987 2006-04-23 Marek Safar <marek.safar@seznam.cz>
4990 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
4991 (DoubleConstant.Reduce): Ditto.
4993 2006-04-23 Raja R Harinath <rharinath@novell.com>
4995 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
4996 Remove 'lvalue_right_side' argument. Move parts to ...
4997 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
4998 (LocalVariable.DoResolveLValue): ... these.
5000 2006-04-21 Raja R Harinath <rharinath@novell.com>
5003 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
5004 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
5005 (LocalVariableReference.DoResolveBase): Use it to implement new
5007 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
5008 (Argument.Resolve): Simplify. Move CS1510 check ...
5009 * ecore.cs (Expression.ResolveLValue): ... here.
5010 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
5011 (PropertyExpr.DoResolveLValue): Likewise.
5012 (FieldExpr.Report_AssignToReadonly): Likewise.
5013 (FieldExpr.DoResolve): Add 'out_access' argument. Use
5014 LValueMemberAccess or LValueMemberOutAccess on instance depending
5016 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
5017 DoResolve as appropriate.
5019 2006-04-20 Raja R Harinath <rharinath@novell.com>
5022 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
5023 implicit conversions on 'out' and 'ref' arguments.
5025 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
5026 improve clarity. Remove dead code.
5029 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
5030 (Catch.Resolve): Resolve VarBlock if it exists.
5032 2006-04-19 Miguel de Icaza <miguel@novell.com>
5034 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
5035 twice, this was some residual code, the enumerator was emitted
5036 properly in the two branche of if later.
5038 2006-04-19 Raja R Harinath <rharinath@novell.com>
5040 * expression.cs (Cast.ResolveLValue): Remove. The result of a
5041 cast is never an lvalue.
5042 (Cast.DoResolve, Cast.ResolveRest): Combine.
5043 (Argument.Emit): Simplify slightly. Move 'Expr is
5044 IMemoryLocation' check ...
5045 (Argument.Resolve): ... here.
5046 (Argument.Error_LValueRequired): Remove. Inline into only user.
5048 Simplifications. Fix cs0191-2.cs
5049 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
5050 CS1649 and CS1651 to ...
5051 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
5052 the actual selection of the error code and message to a lookup
5053 table. Add a dummy return value to simplify callsites.
5054 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
5055 readonly fields of other instances of the same type. Move CS0197
5057 * expression.cs (Argument.Resolve): ... here. Simplify code.
5058 Ensure that ec.InRefOutArgumentResolving is only set during LValue
5059 resolution of an out or ref argument. The code simplification
5060 above uses this invariant.
5062 2006-04-18 Raja R Harinath <rharinath@novell.com>
5064 Possibly fix #77752. Fix cs1690-[4-7].cs.
5065 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
5066 CheckMarshallByRefAccess. Drop parameter.
5067 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
5069 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
5071 * report.cs (AllWarnings): Add CS1690.
5072 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
5074 (LocalVariableReference.DoResolveBase): Update.
5076 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5078 * class.cs (MethodOrOperator): Moved common parts from method class.
5079 detect obsolete attributes.
5080 (Method.Define): Simplified as it reuses code from base.
5081 (Constructor.ValidAttributeTargets): Fixed issue found during
5083 (Destructor.ValidAttributeTargets): Fixed issue found during
5085 (Operator): Finished refactoring set off by #78020. Operator class is now
5086 ordinary method class.
5088 * anonymous.cs: Updated.
5090 * decl.cs (DeclSpace): Add IsGeneric
5092 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5094 * class.cs (Constructor.Emit): Don't emit the attributes twice.
5096 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5098 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
5099 detect obsolete attributes.
5100 (Method.CreateEmitContext): Moved to MethodOrOperator.
5102 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5105 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
5106 customized exception to make crash detection easier.
5107 (MethodOrOperator): Started to work on new base class for methods and
5109 (Method): Derives from MethodOrOperator.
5110 (Constructor.Emit): Emits its own attributes.
5111 (AbstractPropertyEventMethod.Emit): Ditto.
5112 (Operator): Derives from MethodOrOperator, will refactor fully in extra
5114 (Operator.Emit): It's temporary more tricky than should be.
5116 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
5118 * report.cs (InternalErrorException): Add ctor with inner exception.
5120 2006-04-08 Marek Safar <marek.safar@seznam.cz>
5123 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
5126 2006-04-07 Marek Safar <marek.safar@seznam.cz>
5129 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
5132 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5134 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
5135 attribute is present and Guid not.
5136 (Interface.ApplyAttributeBuilder): Ditto.
5138 * attribute.cs: Add error message.
5140 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5144 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
5145 sources (it's composite) so hold them in extra array as they are used in
5146 Emit phase only. It worked in the previous versions by mistake.
5147 (Attribute.Emit): Emit attribute for more owners when exist.
5149 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
5150 it has now different behaviour.
5152 2006-04-04 Marek Safar <marek.safar@seznam.cz>
5154 * constant.cs (Constant.IsDefaultInitializer): New method.
5156 * class.cs: Updated.
5158 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
5159 re-initialize default values. It saves KBs almost for every assembly.
5160 Thanks Zoltan for the idea.
5161 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
5162 (ArrayCreation.DoResolve): Resolve only once.
5163 (ArrayCreation.Emit): Emit static initializer only when it is faster.
5164 (ArrayCreation.GetAttributableValue): Cope with optimized values.
5166 2006-04-03 Zoltan Varga <vargaz@gmail.com>
5168 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
5171 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5173 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
5174 in an embedded statement too.
5176 2006-04-01 Raja R Harinath <rharinath@novell.com>
5179 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
5181 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5185 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
5188 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
5190 2006-03-31 Marek Safar <marek.safar@seznam.cz>
5192 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
5195 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
5196 LocalTemporary change.
5198 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
5200 (ClassOrStruct.DefineFieldInitializers): Implemented static field
5201 initializers optimization.
5202 (ClassOrStruct.TypeAttr): Moved from modifiers.
5203 (Constructor.CheckBase): Don't crash when static ctor has parameters.
5204 (FieldBase.ResolveInitializer): Resolves initializer.
5205 (FieldBase.HasDefaultInitializer): New property.
5207 * cs-parser.jay: Removed message.
5209 * expression.cs (CompilerGeneratedThis): New specialization.
5211 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
5213 2006-03-28 Marek Safar <marek.safar@seznam.cz>
5215 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
5217 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5219 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
5220 be now EnumConstants only.
5222 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5224 * attribute.cs, driver.cs: Reset more caches.
5226 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5228 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
5230 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5232 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
5233 for easier reuse. Updated all overrides.
5234 (IntegralConstant): New base class for all integral constants.
5235 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
5236 of the constant range, report custom error.
5237 (UIntConstant.Reduce): Fixed uint conversion.
5239 * ecore.cs, literal.cs: Reduce updates.
5241 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5245 * class.cs (Constructor.Define): Removed extra if for default ctors.
5246 A patch from Atsushi Enomoto.
5248 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5250 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
5251 GetAttributableValue.
5253 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
5256 * convert.cs (ImplicitConversionRequired): Error message moved to
5259 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
5260 automatic implicit conversion of an output value.
5261 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
5263 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
5265 (TypeOf.GetAttributableValue): Add extra handling for object type.
5267 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
5268 special error message.
5270 2006-03-25 Marek Safar <marek.safar@seznam.cz>
5272 * class.cs (Constructor.Emit): Don't crash when struct ctor is
5274 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
5275 compatible with MS runtime.
5277 2006-03-23 Marek Safar <marek.safar@seznam.cz>
5279 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
5280 attribute arguments here.
5282 * class.cs (Indexer.Define): The check was moved to attribute class.
5284 2006-03-22 Marek Safar <marek.safar@seznam.cz>
5286 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
5287 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
5290 2006-03-22 Raja R Harinath <rharinath@novell.com>
5292 Support ParameterDefaultValueAttribute in gmcs. Also applied to
5293 mcs to keep code differences small.
5294 * attribute.cs (Attribute.GetParameterDefaultValue): New.
5295 * typemanager.cs (parameter_default_value_attribute_type): New.
5296 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
5299 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5301 * expression.cs (StringConcat.Append): Reverted back to no warning state.
5303 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5305 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
5307 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
5310 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
5312 * doc-bootstrap.cs : fix build.
5314 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5316 * expression.cs (StringConcat.Append): Issue a warning when empty string
5319 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5321 * assign.cs (CompoundAssign.ResolveSource): Removed.
5323 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
5326 * class.cs (TypeContainer.FindMethods): Removed.
5327 (TypeContainer.CheckMemberUsage): Made static.
5329 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
5331 * constant.cs (CheckRange): Removed unused type argument.
5332 (CheckUnsigned): Removed unused type argument.
5334 * cs-parser.jay: Updated after MemberAccess clean up.
5335 Uses Length for empty string test.
5337 * cs-tokenizer.cs: Uses Length for empty string test.
5338 (IsCastToken): Made static.
5339 (is_hex): Made static.
5340 (real_type_suffix): Made static.
5342 * decl.cs (SetupCache): Made static.
5343 (OnGenerateDocComment): Removed unused ds argument.
5345 * delegate.cs (VerifyDelegate): Removed unused argument.
5347 * doc.cs: Uses Length for empty string test.
5349 * driver.cs: Uses Length for empty string test.
5351 * enum.cs (IsValidEnumType): Made static
5353 * expression.cs (EnumLiftUp): Removed unused argument.
5354 (ResolveMethodGroup): Ditto.
5355 (BetterConversion): Ditto.
5356 (GetVarargsTypes): Ditto.
5357 (UpdateIndices): Ditto.
5358 (ValidateInitializers): Ditto.
5359 (MemberAccess.ctor): Ditto.
5360 (GetIndexersForType): Ditto.
5362 * flowanalysis.cs: (MergeFinally): Removed unused argument.
5364 * iterators.cs: Updated after MemberAccess clean up.
5366 * location.cs: Uses Length for empty string test.
5368 * namespace.cs: Uses Length for empty string test.
5370 * report.cs (CheckWarningCode): Made static.
5372 * statement.cs (LabeledStatement): Removed unused argument.
5374 * typemanager.cs (FilterNone): Removed.
5376 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5378 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
5381 * class.cs: Updated.
5383 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5385 * cs-parser.jay.cs: __arglist is not allowed for delegates.
5387 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5391 * expression.cs (VerifyArgumentsCompat): Reverted to double error
5392 reporting, it's more tricky than I thought.
5394 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5398 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
5400 (AnonymousMethod.ImplicitStandardConversionExists): New method.
5401 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
5402 Add more error reporting; Fixed issue with params.
5404 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
5406 * cs-parser.jay: AnonymousMethod requires host container.
5408 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
5410 2006-03-18 Raja R Harinath <harinath@gmail.com>
5412 * class.cs: Change 'TypeContainer ds' constructor argument to
5413 'DeclSpace parent'. Some classes were missed below due to
5414 different naming convention.
5416 * class.cs (MemberCore.Parent): Delete. This makes the
5417 ParentContainer changes below enforceable by the compiler.
5419 Treat pointers to enclosing declaration space as 'DeclSpace', not
5421 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
5422 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
5424 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
5426 (Block.AddThisVariable): Likewise.
5427 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
5428 (AbstractPropertyEventMethod.Emit): Likewise.
5429 (AbstractPropertyEventMethod.EmitMethod): Likewise.
5430 (GetMethod.Define, SetMethod.Define): Likewise.
5431 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
5432 (DelegateMethod.EmitMethod): Likewise.
5434 Fix regression test-partial-13.cs.
5435 Rationalize use of PartialContainer. Ensure that the partial
5436 class semantics can be tied to type-correctness, i.e., any
5437 violation will cause a compile error.
5438 * class.cs, const.cs: Access all fields that belong to class
5439 TypeContainer via ParentContainer. Arguments of EmitContexts and
5440 Resolve()-like functions still use 'Parent'.
5442 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
5443 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
5444 (PropertyMethod.CheckModifiers): Remove unused argument.
5445 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
5448 2006-03-17 Raja R Harinath <harinath@gmail.com>
5450 Make semantics of PartialContainer simpler.
5451 * decl.cs (DeclSpace.IsPartial): Remove.
5452 * class.cs (TypeContainer.IsPartial): Likewise.
5453 (TypeContainer..ctor): Set PartialContainer to point to self.
5454 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
5455 (TypeContainer.FindNestedType): Likewise.
5456 (MemberCore.ParentContainer): Simplify. Remove deprecation.
5458 2006-03-17 Marek Safar <marek.safar@seznam.cz>
5460 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
5462 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5464 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
5467 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5469 * class.cs (Operator.Define): An error for base conversion was not
5472 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
5474 * iterator.cs : yield break is allowed in try statement which has
5475 catch clauses. Fixed bug #77767.
5477 2006-03-13 Marek Safar <marek.safar@seznam.cz>
5479 A fix for #77593, #77574.
5481 * class.cs (MethodCore.CheckBase): Another if for operator.
5483 2006-03-09 Marek Safar <marek.safar@seznam.cz>
5485 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
5488 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
5489 (DelegateCreation.ImplicitStandardConversionExists): New method for just
5492 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
5495 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
5496 Updated after another emitcontext usage was clean up. It should help us to
5497 synchronize with gmcs easier.
5499 2006-03-04 Marek Safar <marek.safar@seznam.cz>
5503 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
5504 (Event.Define): ditto
5505 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
5507 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
5508 Removed redundant code and set NewSlot for Invoke method too.
5510 * parameter.cs (Parameters.ctor): Add custom, type ctor.
5511 (Parameters.MergeGenerated): New method. Use this method when you merge
5512 compiler generated argument with user arguments.
5514 2006-03-03 Marek Safar <marek.safar@seznam.cz>
5516 * attribute.cs (ResolveAsTypeTerminal): Removed.
5518 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
5519 specialization for predefined types; 30% speed up.
5520 Finally placed obsolete check to right place.
5521 (Expression.ResolveType): Removed.
5523 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
5524 Updated after ResolveType was removed.
5526 * expression.cs (Cast.ctor): Check void cast.
5527 (Binary.ResolveAsTypeTerminal): Is never type.
5528 (Conditional.ResolveAsTypeTerminal): Is never type.
5530 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
5532 2006-03-01 Raja R Harinath <rharinath@novell.com>
5535 * expression.cs (ParameterReference.DoResolveBase): Change return
5537 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
5541 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
5544 * typemanager.cs (GetFullNameSignature): Don't nullref on
5545 protected accessors.
5547 2006-02-27 Marek Safar <marek.safar@seznam.cz>
5549 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
5550 these two separated members to simplify the code.
5551 (Attribute.Resolve): Refactored to use new fields and methods.
5552 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
5553 implemented obsolete attribute checking.
5554 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
5555 implemented obsolete checking again. It look line never ending quest ;-)
5556 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
5558 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
5560 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
5562 *class.cs (Property.Define): Add RegisterProperty call.
5564 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
5565 argument groups (only 2).
5567 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
5568 encoding expression to arguments.
5569 (Expression.ExprClassToResolveFlags): Just turned to property.
5571 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
5572 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
5573 optimized as well as implemented support for zero-length attributes.
5575 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
5576 Add caching of PropertyInfo's.
5578 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5580 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
5581 error multiple times.
5583 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5585 New partial class implementation.
5586 A fix for #77027, #77029, #77403
5588 * attribute.cs (Attributable): Made attributes protected.
5590 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
5591 the replacements of ClassPart and PartialContainer.
5592 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
5593 (TypeContainer.AddInterface): Ditto.
5594 (TypeContainer.AddPartial): The main method for partial classes. It checks
5595 for errors and merges ModFlags and attributes. At the end class is added to
5597 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
5599 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
5600 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
5601 from the rest of partial classes.
5602 (TypeContainer.GetClassBases): Simplified.
5603 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
5605 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
5606 (TypeContainer.HasExplicitLayout): Uses Flags now.
5607 (PartialContainer): Removed.
5608 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
5609 (StaticClass): Was merged with Class.
5610 (Class.GetClassBases): class and static class bases are verified here.
5611 (Class.TypeAttr): Added static attributes when class is static.
5612 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
5613 (MemberBase): In some cases we need to call parent container for partial
5614 class. It should be eliminated but it's not easy now.
5616 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
5618 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
5619 partial classed to accumulate class comments.
5620 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
5622 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
5624 * driver.cs (MainDriver): Tree.GetDecl was removed.
5626 * modifiers.cs (Modifiers): Add partial modifier.
5628 * tree.cs (Tree.decl): Removed.
5629 (RootTypes): Started to use this class more often for root types
5632 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5636 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
5637 external interface does not have an attribute.
5639 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5641 Another prerequisites for new partial classs implementation.
5643 * attribute.cs (Attribute.Equal): Implemented.
5644 (Attribute.Emit): Changed as attributes can be applied more than twice.
5645 (Attributes.Emit): Check for duplicate attributes here.
5647 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
5648 as a parameter, clean-up.
5650 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5654 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
5655 contains obsolete attribute check which can in some cases look for base
5656 type of current class which is not initialized yet.
5657 (TypeContainer.BaseType): Replacement of ptype.
5659 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
5661 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5663 First of prerequisites for new partial classs implemention.
5665 * attribute.cs (Attributable): Extended by ResolveContext;
5666 Attributes finally have correct context for resolving in all cases.
5667 (AttachTo): Attribute owner is assigned here.
5669 * codegen.cs (IResolveContext): Introduce new interface to hold
5670 all information needed in resolving phase.
5671 (EmitContext): Implements IResolveContext; more clean-up needed here.
5673 * decl.cs (MemberCore): Implemented IResolveContext.
5675 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
5676 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
5677 parameter.cs, statement.cs, tree.cs, typemanager.cs:
5678 Refactored to use new IResolveContext instead of EmitContext; cleanup
5680 2006-02-06 Miguel de Icaza <miguel@novell.com>
5682 * codegen.cs (EmitScopeInitFromBlock): check here the
5683 capture_context, there is no need to make two calls to the
5686 * anonymous.cs: Add some debugging messages that might help me
5687 track other instances of this problem in the future (the
5688 regression of test 467).
5690 * cs-parser.jay: track the variable block, as we need to initalize
5691 any captured variables declared in this block for the "catch"
5692 portion of the "Try" statement.
5694 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
5695 scope initialization for captured variables.
5697 Also, move the emit for the variables after the block location has
5700 2006-02-06 Marek Safar <marek.safar@seznam.cz>
5702 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
5704 2006-02-02 Miguel de Icaza <miguel@novell.com>
5706 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
5707 commit yesterday, the initialization for the roots is necessary.
5708 What is not necessary is the scope activation.
5710 2006-02-02 Raja R Harinath <rharinath@novell.com>
5712 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
5713 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
5715 (Argument.Resolve): Remove CS0206 checks.
5717 2006-02-01 Miguel de Icaza <miguel@novell.com>
5719 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
5720 scopes for all the roots, the scopes will now be emitted when the
5721 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
5723 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
5724 code. This reduces a lot of existing cruft.
5726 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
5727 that the ScopeInfo is generated as we enter the scope, not at the
5728 time of use, which is what we used to do before.
5730 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
5731 every time a Block is about to be emitted if we have a
5734 2006-02-01 Raja R Harinath <rharinath@novell.com>
5736 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
5738 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
5740 * typemanager.cs (cons_param_array_attribute): Make private.
5741 (Reset): Set it to null.
5742 (InitCoreHelpers): Don't initialize it.
5743 (ConsParamArrayAttribute): New. Initialize it as needed.
5744 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
5746 2006-01-31 Miguel de Icaza <miguel@novell.com>
5748 * expression.cs: There might be errors reported during the
5749 selection of applicable methods. If there are errors, do not
5750 continue execution as it will lead the compiler to crash.
5752 2006-01-30 Miguel de Icaza <miguel@novell.com>
5754 * expression.cs: Member access is not allowed on anonymous
5755 methods. Fixes #77402.
5757 2006-01-30 Raja R Harinath <rharinath@novell.com>
5760 * cs-parser.jay (VariableDeclaration): Don't set
5761 current_array_type to null.
5762 (field_declaration, event_declaration, declaration_statement):
5763 Set it to null here.
5765 2006-01-28 Raja R Harinath <harinath@gmail.com>
5767 * typemanager.cs (GenericParameterPosition): New.
5770 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
5772 * doc.cs : To process "include" elements, first we should create
5773 another list than XmlNodeList, because it could result in node
5774 removal, which could result in that the XmlNodeList gives up
5777 (Also made code identical to gmcs again.)
5779 2006-01-25 Miguel de Icaza <miguel@novell.com>
5781 * ecore.cs: Introduce an error report that we were not catching
5782 before, if not silent, we must report the error. Gonzalo ran into
5785 2006-01-23 Miguel de Icaza <miguel@novell.com>
5787 A fix for bug: #76957
5789 * iterators.cs (MoveNextMethod.CreateMethodHost): call
5790 ComputeMethodHost before creating the method, this is a new
5793 * anonymous.cs (AnonymousContainer): Now we track all the scopes
5794 that this method references (RegisterScope). The actual scope
5795 where the method is hosted is computed with the ComputeMethodHost
5796 before we create the method.
5798 Moved the Deepest routine here.
5800 (AnonymousContainer.ComputeMethodHost): New routine used to
5801 compute the proper ScopeInfo that will host the anonymous method.
5803 (ScopeInfo): Deal with multiple roots. The problem was that we
5804 did not have a unique root where all ScopeInfos could be hanged
5805 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
5808 Remove AdjustMethodScope which is now computed at the end. Remove
5809 LinkScope which did a partial link, instead link all ScopeInfos
5810 before code generation from the new "LinkScopes" routine.
5812 Simplify all the Add* routines as they no longer need to maintain
5813 the tree, they just need to record that they are using variables
5816 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
5817 routines to produce the forest of ScopeInfo trees.
5819 * class.cs (TypeContainer.AppendMethod): This is just like
5820 AddMethod, but ensures that an interface implementation method
5821 (IEnumerable.XXX) is not inserted at the beginning of the queue of
5822 methods, but at the end.
5824 We use this functionality to ensure that the generated MoveNext
5825 method in the iterator class is resolved/emitted before the
5826 enumerator methods created.
5828 This is required because the MoveNext method computes the right
5829 ScopeInfo for the method. And the other methods will eventually
5830 need to resolve and fetch information computed from the anonymous
5833 2006-01-21 Raja R Harinath <harinath@gmail.com>
5834 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5837 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
5839 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
5840 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
5842 2006-01-18 Raja R Harinath <rharinath@novell.com>
5844 Fix #76656, cs0231-2.cs.
5845 * cs-parser.jay (formal_parameter_list): Make error case catch
5847 (parenthesized_expression_0): Add CS1026 check.
5848 (invocation_expression): Remove unused { $$ = lexer.Location }.
5850 2006-01-17 Raja R Harinath <rharinath@novell.com>
5853 * cs-parser.jay (statement_expression): Don't list out the
5854 individual statement-expressions. Convert syntax error into
5857 2006-01-16 Raja R Harinath <rharinath@novell.com>
5860 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
5861 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
5862 CheckIntermediateModification.
5863 (FieldExpr.DoResolve): Add new two-argument version that
5864 allows us to resolve the InstanceExpression as an lvalue.
5865 The one-argument variant is now just a wrapper.
5866 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
5867 Resolve the lhs as an lvalue if the it has a value type.
5868 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
5869 from Assign.DoResolve.
5870 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
5871 resolved as an lvalue.
5872 (PropertyExpr.DoResolve): Update.
5873 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
5874 has a value type. Move CS1612 check here from
5875 CheckIntermediateModification.
5876 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
5877 * expression.cs (EmptyExpression.OutAccess): New. Used as the
5878 'right_side' of a ResolveLValue on an 'out' argument.
5879 (EmptyExpression.LValueMemberAccess): New. Used as the
5880 'right_side' of a propagated ResolveLValue on a value type.
5881 (LocalVariableReference.DoResolveBase): Recognize
5882 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
5884 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
5885 EmptyExpression.Null.
5887 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
5889 * typemanager.cs : added IsGenericParameter(). In mcs it always
5891 * doc.cs : for generic parameters, use GenericParameterPosition,
5894 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
5896 * expression.cs: Fix Console.WriteLine ((this = x).foo);
5898 2006-01-12 Miguel de Icaza <miguel@novell.com>
5900 This fixes the problem where we used ldfld instead of ldflda to
5901 load the "THIS" pointer on captured parameters, when THIS is a
5902 value type. See bug #77205.
5904 * iterators.cs (CapturedThisReference.Emit): Pass false to
5905 EmitThis (we do not need the address).
5907 * codegen.cs (EmitThis): it needs to know whether we need the
5908 address of `this' or not. This is used by value types.
5910 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
5911 every other call passes false.
5913 2006-01-12 Raja R Harinath <rharinath@novell.com>
5916 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
5918 * expression.cs (Invocation.OverloadResolve): Update.
5919 (Invocation.DoResolve): Avoid double resolution of invocation.
5921 2006-01-11 Raja R Harinath <rharinath@novell.com>
5924 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
5925 unary negation of floating point types as 0-expr; negation cannot
5926 overflow in floating point types.
5929 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
5930 on operands of 'void' type.
5933 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
5934 and ExclusiveOr for boolean constants too.
5936 2006-01-09 Raja R Harinath <rharinath@novell.com>
5939 * expression.cs (Invocation.OverloadResolve): Replace reflected
5940 override methods with their base virtual methods, rather than
5942 * typemanager.cs (TypeManager.GetOverride): New.
5944 2006-01-05 Jb Evain <jbevain@gmail.com>
5946 * class.cs (Property.Define, Indexer.Define): do not tag the
5947 properties as SpecialName | RTSpecialName.
5949 2006-01-04 Miguel de Icaza <miguel@novell.com>
5951 * class.cs (MethodCore.IsDuplicateImplementation): This method was
5952 doing a low-level comparission of parameter types. It was lacking
5953 a check for __argslist.
5955 2005-12-30 Miguel de Icaza <miguel@novell.com>
5957 * expression.cs (ParameterReference.DoResolveBase): Allow
5958 reference parameters if they are local to this block.
5960 This allows the ref and out parameters of a delegate to be used in
5961 an anonymous method, for example:
5963 delegate void set (out int x);
5965 set s = delegate (out int x){
5969 This is used by functionality introduced late in the C# language.
5971 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
5972 method that take ref and out parameters.
5974 Fixes #77119 which was a late change in the spec.
5976 2005-12-23 Miguel de Icaza <miguel@novell.com>
5978 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
5979 parent if its the same scope. Fixes #77060.
5981 2005-12-21 Miguel de Icaza <miguel@novell.com>
5983 * driver.cs: Report the case of no source files and no -out:
5986 2005-12-20 Raja R Harinath <rharinath@novell.com>
5989 * expression.cs (ComposedCast.GetSignatureForError): Define.
5991 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5995 * namespace.cs (NamespaceEntry): Add extern_aliases as a
5996 ListDictionary, to contain the ExternAliasEntry entries (in
5997 addition to the NamespaceEntry.aliases hashtable). This field is
5998 shared between the original entry and its doppelganger (bodyless
6000 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
6001 extern_aliases field.
6002 (NamespaceEntry.Lookup): Move the IsImplicit check after the
6003 lookup in extern_aliases.
6005 2005-12-16 Raja R Harinath <rharinath@novell.com>
6008 * class.cs (TypeContainer.Mark_HasEquals): New.
6009 (TypeContainer.Mark_HasGetHashCode): New.
6010 (ClassPart): Override them.
6011 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
6014 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
6015 'parent' argument to the base constructor.
6017 Remove all mention of TypeContainer from decl.cs.
6018 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
6019 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
6020 (DeclSpace.DeclSpace): Likewise.
6021 (DeclSpace.DefineMembers): Remove unused argument.
6022 * cs-parser.jay (pop_current_class): Update to changes. Simplify
6023 debugging check -- we don't care if the debug code throws an
6024 InvalidCastException instead of an InternalErrorException.
6025 * class.cs (TypeContainer.DefineMembers): Update to changes.
6026 (TypeContainer.DoDefineMembers): Likewise.
6027 (TypeContainer.GetMethods): Likewise.
6028 (PropertyMember.Define): Likewise.
6029 (MemberBase.Parent): New property that forwards to
6030 MemberCore.Parent, but ensures that we get a TypeContainer.
6031 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
6032 (RootContext.PopulateTypes): Likewise. Remove special case code
6033 for !RootContext.StdLib: DefineMembers is idempotent.
6035 2005-12-14 Miguel de Icaza <miguel@novell.com>
6037 * convert.cs (ExplicitConversionCore): Check the return value from
6038 ExplicitConversionCore which can return null on failure. Fixes #76914
6040 2005-12-13 Marek Safar <marek.safar@seznam.cz>
6042 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
6044 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
6046 * doc.cs : The search for referenced namespace was insufficient to
6047 get global one as it used to do. Fixed bug #76965.
6049 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
6051 * doc.cs : check name in cref in the last phase that whether it is
6054 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6056 * cs-tokenizer.cs : reverted the latest change: it somehow broke
6059 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6061 * doc.cs : so it turned out that we cannot skip override check for
6062 interface members. Fixed bug #76954.
6064 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6066 * cs-tokenizer.cs : fixed bug #75984:
6067 - #warning and #error should not be handled when the source line
6069 - #line is not checked strictly when the source line is disabled.
6070 - #define and #undef is on the other hand checked strictly at any
6073 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
6075 * cs-tokenizer.cs : missing Location (actually, filename) in one of
6078 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6080 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
6082 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
6084 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
6085 (FieldBase.Initializer): Initializer is now optional.
6086 (EventField.Define): Only event field can have initializer.
6088 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
6090 * const.cs (Const): Reuse initializer.
6092 * cs-parser.jay: Updated after FieldBase changes.
6093 Added current_array_type to simplify array initializers.
6095 * ecore.cs (NullCast.IsDefaultValue): Implemented.
6097 * expression.cs, iterators.cs: Updated.
6099 * namespace.cs (NamespaceEntry): Made UsingFound private.
6101 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6103 * parameterCollection.cs: Obsolete, removed.
6104 * parser.cs: Obsolete, removed.
6106 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6109 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
6111 * enum.cs (Enum.Define): Set obsolete context here.
6113 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6116 - FindDocumentedMember() now expects 1) paramList as null
6117 when "we don't have to check the number of parameters" and
6118 2) Type.EmptyTypes when "there is no arguments".
6119 - Introduced FoundMember struct to hold the exact type which was
6120 used to find the documented member (the above change broke
6121 test-xml-044; it might be better just to use DeclaringType than
6122 what MS does, like this change does, but it depends on usage.)
6124 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6126 * doc.cs : documented member might be from DeclaringType for nested
6127 types. Fixed bug #76782.
6129 2005-12-03 Ben Maurer <bmaurer@ximian.com>
6131 * anonymous.cs: Have the param code handle leaving copies on the
6132 stack etc. Allows anonymous params to take part in the assignment
6133 code (++, +=, etc). Fixes bug #76550
6135 * expression.cs: Handle the prepare_for_load/leave_copy by passing
6136 it down to the anon code.
6138 * iterators.cs: Use dummy var here
6140 * codegen.cs: Handle new vars
6142 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6145 * class.cs (MethodData.Define): Set proper Obsolete context.
6147 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
6149 (FieldExpr.DoResolve): Ditto.
6151 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6154 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
6155 parent is not obsolete.
6157 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
6159 * doc.cs : (FindDocumentedMember) find parameterless members first
6160 and get CS0419 in the early stage. Fixed first case of bug #76727.
6162 2005-11-30 Marek Safar <marek.safar@seznam.cz>
6165 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
6166 no error was reported.
6168 *expression.cs (Binary.DoResolve): left can be null.
6170 2005-11-22 Marek Safar <marek.safar@seznam.cz>
6173 * class.cs (MethodData.Emit): Parameters should be labeled first.
6175 2005-11-21 Marek Safar <marek.safar@seznam.cz>
6178 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
6180 2005-11-18 Marek Safar <marek.safar@seznam.cz>
6182 * attribute.cs (AreParametersCompliant): Moved to Parameter.
6184 * class.cs (MethodCore): Parameter clean up.
6185 (IMethodData): Added ParameterInfo.
6186 (MethodData): Parameter clean up.
6187 (Indexer.Define): Parameter clean up.
6199 * typemanager.cs: Parameter clean up.
6201 * delegate.cs (Define): Get rid of duplicated code.
6203 * expression.cs (ParameterReference): Removed useless parameters
6205 (Invocation): Ditto.
6207 * parameter.cs (ParamsParameter): New class, params specialization.
6208 (ArglistParameter): Attemp to separate arglist.
6209 (Parameter): Refactored to be reusable and faster.
6210 (Parameter.Modifier): Made understandable.
6211 (Parameters): Changed to be used as a class for `this' assembly
6212 parameters. Refactored to use new specialized classes.
6214 * support.cs (ParameterData): Added Types property.
6215 (InternalParameters): Deleted.
6217 2005-08-20 Martin Baulig <martin@ximian.com>
6219 Merging this patch from GMCS to fix #75867.
6221 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6222 scope if we don't already have it.
6224 2005-11-17 Martin Baulig <martin@ximian.com>
6227 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
6228 inherit the scope from our parent. Fixes #76653.
6230 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6232 * doc.cs : the previous patch does not actually fix the bug.
6233 PropertyInfo override check is now implemented and really fixed it.
6234 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
6236 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6238 * doc.cs : apply "override filter" also to properties.
6241 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6243 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
6244 no need to check overrides. For classes, omit those results from
6245 interfaces since they must exist in the class. Fixed bug #76726.
6247 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6249 * typemanager.cs : (GetFullNameSignature) differentiate indexers
6250 with different parameters. Fixed the second problem in #76685.
6252 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6254 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
6255 get expected 'protected' access in CheckValidFamilyAccess()).
6258 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6260 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
6261 Fixed bug #76705. CS1569 was incorrectly commented out.
6263 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6265 * doc.cs : use Invocation.IsOverride() to do real override check.
6266 * expression.cs : made Invocation.IsOverride() internal.
6268 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6270 * doc.cs : use TypeManager.FindMembers() instead of (possible)
6271 TypeBuilder.FindMembers() and filter overriden base members out.
6274 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6276 * doc.cs : ref/out parameters are represented as '@' (instead of
6277 '&' in type FullName). Fixed bug #76630 (additionally crefs).
6279 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6281 * doc.cs : when there was no '.' in cref to methods in doc comment,
6282 then parameters were missing in the output. Fixed bug #76691.
6284 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6286 * driver.cs : don't output docs when there is an error.
6289 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6292 Now it should detect indexers. Fixed primary concern in bug #76685.
6293 Fixed CS0419 message to not show the identical member signature in
6296 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6298 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
6299 instead of Type.FindMembers() since it does not handle events.
6302 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
6304 * codegen.cs: Fixed typo (speficied -> specified).
6306 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6309 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
6311 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6313 * attribute.cs: Changed error message.
6315 * cs-tokenizer.cs: One more check.
6317 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6319 * statement.cs (Block.Resolve): Ignore empty statement.
6321 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6323 * report.cs: Made error/warning methods more strict to avoid
6326 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
6327 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
6328 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
6329 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
6331 2005-11-08 Marek Safar <marek.safar@seznam.cz>
6333 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
6334 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
6336 * class.cs (TypeContainer.IsComImport): New property.
6337 (Constructor.Define): Create proper ctor for ComImport types.
6339 * expression.cs (New.CheckComImport): Fixed.
6341 2005-11-07 Miguel de Icaza <miguel@novell.com>
6343 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
6344 that a parameter has been captured does not mean that we do not
6345 have to do the rest of the processing. This fixes the second part
6346 of #76592. If there was another anonymous method capturing
6347 values in the past, the Scope would never be set for the second
6348 method that captured the same parameter.
6350 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
6351 properly manipulate the stack. Second part of fix for #76592.
6353 * expression.cs (New): Add support for invoking "new" on
6354 interfaces that have been flagged with the ComImport attribute and
6355 the CoClass. Fixes #76637
6357 * statement.cs (Try.DoEmit): When a variable is captured, do not
6358 try to emit the vi.LocalBuilder variable as it has been captured.
6359 Create a temporary variable and store the results on the
6360 FieldBuilder. Fixes #76642
6362 2005-11-07 Marek Safar <marek.safar@seznam.cz>
6364 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
6366 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
6368 * expression.cs (Binary.DoResolve): Added && optimalization.
6370 * typemanager.cs (AddUserType): Removed useless argument.
6372 2005-11-04 Marek Safar <marek.safar@seznam.cz>
6374 * statement.cs (Block.variables): Uses ListDictionary.
6376 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6379 * class.cs (PartialContainer.EmitType): Customized to emit
6380 security attributes.
6381 (ClassPart.ApplyAttributeBuilder): Transform security attribute
6382 for partial classes.
6384 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6387 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
6388 access has to be fixed.
6390 * typemanager.cs (IsUnmanagedType): Wrong common field type.
6392 2005-11-01 Marek Safar <marek.safar@seznam.cz>
6395 * ecore.cs (NullCast.Reduce): Implemented.
6397 * expression.cs (ArrayCreation.CheckIndices): Correcly check
6400 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
6402 (Foreach.Resolve): Catch null properly.
6404 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6406 * cs-tokenizer.cs: Warning text fix.
6408 * driver.cs: AllWarningNumbers exposed on public interface.
6410 * report.cs (): Reviewed warning numbers.
6411 (IsValidWarning): Use binary search.
6413 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6415 * driver.cs: Implemeted resource visibility.
6416 (Resources): New class for code sharing between /res: and
6419 2005-10-28 Marek Safar <marek.safar@seznam.cz>
6422 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
6425 * convert (Convert.ImplicitReferenceConversion): NullCast holds
6428 * ecore.cs (NullCast): Child is contant only.
6430 * literal.cs (NullLiteral.Reduce): null can be converted to any
6433 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
6435 * driver.cs: Use Encoding.Default as default code page instead
6438 2005-10-27 Raja R Harinath <rharinath@novell.com>
6441 * expression.cs (Invocation.Error_InvalidArguments): Handle
6442 __arglist parameters.
6443 (Invocation.VerifyArgumentsCompat): Likewise.
6444 * support.cs (ReflectionParameters.GetSignatureForError): Print
6445 __arglist parameters.
6446 (InternalParamters.GetSignatureForError): Likewise.
6447 * parameter.cs (Parameters.GetSignatureForError): Likewise.
6449 2005-10-26 Marek Safar <marek.safar@seznam.cz>
6451 * attribute.cs (GetPropertyValue): Made public.
6453 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
6455 Add new property WrapNonExceptionThrows to handle 2.0 assembly
6457 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
6460 * driver.cs: Reflect method name change.
6462 * statement.cs (Try.Resolve): Warn when try has both general
6465 * typemanager.cs: runtime_compatibility_attr_type new predefined
6468 2005-10-26 Raja R Harinath <harinath@gmail.com>
6471 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
6472 treat it as an empty parameter list.
6474 2005-10-26 Raja R Harinath <rharinath@novell.com>
6477 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
6478 ResolveAsTypeStep silent.
6479 * statement.cs (Block.AddConstant): Mark block as used.
6480 (Block.ResolveMeta): Avoid piling on error messages
6481 if a constant initializer resolution fails.
6483 2005-10-25 Raja R Harinath <rharinath@novell.com>
6485 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
6487 (NamespaceEntry.VerifyAllUsing): New.
6488 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
6489 behaviour. Delegates actual resolution of alias to ...
6490 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
6491 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
6493 * driver.cs (Driver.MainDriver): Update.
6495 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
6496 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
6498 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
6500 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
6501 RootNamespace.DefineNamespacesForAll.
6503 2005-10-24 Raja R Harinath <harinath@gmail.com>
6505 * typemanager.cs (assemblies, external_aliases, modules)
6506 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
6507 (ComputeNamespaces, GetRootNamespace): Remove extra staging
6508 overhead. Move resposibility ...
6509 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
6510 * driver.cs, attribute.cs, codegen.cs: Update to changes.
6512 2005-10-23 Raja R Harinath <harinath@gmail.com>
6514 * namespace.cs (RootNamespace.all_namespaces): Renamed from
6515 cached_namespaces. Improve usage.
6516 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
6517 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
6518 Move from GlobalRootNamespace and simplify.
6519 (RootNamespace.Global): Make instance variable.
6520 (RootNamespace.RootNamespace): Add "alias name" parameter.
6521 (GlobalRootNamespace): Simplify drastically.
6522 (Namespace.Lookup): Don't use GetNamespace.
6523 * typemanager.cs (GetRootNamespace): Rename from
6524 ComputeNamespaceForAlias.
6525 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
6527 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6529 * anonymous.cs (AnonymousContainer): Don't crash when container
6532 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6534 * expression.cs (Binary.DoResolve): Warn when comparing same
6537 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6540 * expression.cs (Binary.DoResolve): It looks like there are no
6541 convetsion rules in enum context.
6543 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6545 Add support for extern alias qualifiers.
6546 * typemanager.cs: Move some LookupTypeReflection code
6547 to namespace.cs, to have cleaner code. Added some methods
6548 to help us keep track of the extern aliased references.
6549 * driver.cs: Add suport for extern alias assemblies on command
6550 line and check for their warnings/errors. Also keep track of the
6551 extern aliased assemblies.
6552 * namespace.cs: Move the global functionality of Namespace
6553 to GlobalRootNamespace/RootNamespace. Now the global namespace
6554 is GlobalRootNamespace.Globa. Also the code moved from
6555 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
6556 Finally added LocalAliasEntry (AliasEntry before) and
6557 ExternAliasEntry, to handle alias statements.
6558 * cs-parser.jay: Add support in the grammar for extern alias
6560 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
6561 Update callings to Namespace (now in GlobalRootNamespace).
6563 2005-10-18 Raja R Harinath <rharinath@novell.com>
6566 * class.cs (TypeContainer.DefineType): Move updating of
6567 topological sort earlier in the code.
6568 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
6570 2005-10-18 Marek Safar <marek.safar@seznam.cz>
6573 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
6575 * constant.cs (Constant.TryReduce): Moved from Cast class.
6576 (Reduce): Made little bit more OO and fixed missing conversions.
6578 * ecore.cs (Reduce): Implemented.
6579 (Binary.EnumLiftUp): New method to upgrade values to enum values.
6581 * literal.cs (Reduce): Implemented.
6583 * class.cs: Reverted Miguel's wrong commit.
6585 2005-10-14 Miguel de Icaza <miguel@novell.com>
6587 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
6589 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
6591 * cs-parser.jay, expression.cs : CS0214 was missing error location
6592 for constants. Fixed bug #76404.
6594 2005-10-11 Marek Safar <marek.safar@seznam.cz>
6597 * convert.cs (ExplicitConversionCore): Fixed object->enum
6600 2005-10-10 Raja R Harinath <rharinath@novell.com>
6602 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
6604 (PropertyExpr.EmitCall): Likewise.
6605 * expression.cs (Invocation.EmitArguments): Handle case where
6607 (Invocation.EmitCall): Avoid allocating temporary variable if
6608 there are no arguments.
6610 2005-10-07 Raja R Harinath <rharinath@novell.com>
6613 * convert.cs (ImplicitConversionStandard): Move conversion of
6614 void* to arbitrary pointer types ...
6615 (ExplicitConversionStandard): .. here.
6616 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
6617 error to always print typenames.
6619 2005-10-07 Raja R Harinath <rharinath@novell.com>
6621 * convert.cs (GetConversionOperator): Rename from
6622 GetConversionOperators. Move operator selection code from ...
6623 (UserDefinedConversion): ... here.
6625 2005-10-06 Marek Safar <marek.safar@seznam.cz>
6627 * convert.cs (ExplicitConversionCore): Removed duplicate enum
6630 2005-10-05 Marek Safar <marek.safar@seznam.cz>
6632 * assign.cs (Assign.DoResolve): Error method changed.
6634 * cfold.cs (DoConstantNumericPromotions): Error method changed.
6636 * const.cs (ResolveValue): Reset in_transit immediately.
6638 * constant.cs: Error method changed.
6640 * convert.cs: Removed useless location parameter.
6641 (ExplicitNumericConversion): Don't do double enum check.
6642 (ExplicitConversionCore): Renamed from ExplicitConversion.
6643 (ExplicitUnsafe): Extracted from ExplicitConversion.
6644 (ExplicitConversion): Uses for error reporting.
6646 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
6648 (ResolveBoolean): Uses common error method.
6649 (CastToDecimal): Get rid of ec.
6650 (CastFromDecimal): Optimized.
6651 (ConvCast): Get rid of ec.
6653 * enum.cs (ResolveValue): Reset in_transit immediately.
6654 (Emit): Return after first error.
6656 * expression.cs: Convert changes.
6658 * literal.cs: Error method changed.
6660 * statement.cs: Error method changed.
6662 2005-10-03 Raja R Harinath <rharinath@novell.com>
6664 * support.cs (SeekableStreamReader.Position): Don't error out when
6665 the requested position is just beyond the end of the current
6668 2005-09-28 Raja R Harinath <rharinath@novell.com>
6670 * support.cs (SeekableStreamReader): Simplify drastically. Don't
6671 try to keep in sync with the byte count of the underlying Stream.
6672 However, this limits us to a window size of 2048 characters: i.e.,
6673 the maximum lookahead of our lexer/parser can be 2048 characters.
6675 2005-09-28 Marek Safar <marek.safar@seznam.cz>
6678 * driver.cs: Fix compilation files with full root path.
6680 2005-09-25 Miguel de Icaza <miguel@novell.com>
6682 * report.cs (SymbolRelatedToPreviousError): Format the output so
6683 it does not use an open parenthesis that is never closed.
6685 * driver.cs: Follow coding guidelines
6687 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6690 * const.cs (Const.ResolveValue): Check for assigning non-null
6691 value to reference type.
6693 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6695 * anonymous.cs: Implemented ExprClassName.
6697 * assign.cs (Assign.DoResolve): Don't chrash when type is not
6700 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
6703 * class.cs (StaticClass.DefineContainerMembers): Report protected
6706 * codegen.cs: if(ed) PRODUCTION.
6708 * convert.cs (Error_CannotImplicitConversion): Better error
6711 * cs-parser.jay: More error checks.
6713 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
6715 * driver.cs (CSCParseOption): Enabled wrong option check.
6717 * ecore.cs (Expression.ExprClassName): Turned to property.
6718 (MemberExpr.CheckIntermediateModification): For checking boxed
6719 value types modification.
6721 * statement.cs (Fixed.Resolve): Expression type must be
6722 convertible to fixed type.
6723 (CollectionForeach.GetEnumeratorFilter,TryType):
6724 Small refactoring for easier error checking.
6726 2005-09-26 Marek Safar <marek.safar@seznam.cz>
6728 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
6731 * class.cs (GeneratedBaseInitializer): New class for customization
6732 compiler generated initializers.
6733 (MemberBase.DoDefine): Check Obsolete attribute here.
6734 (FieldMember.DoDefine): Ditto.
6736 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
6739 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
6740 (MemberCore.GetObsoleteAttribute): Removed argument.
6741 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
6742 (MemberCore.CheckObsoleteType): New helper.
6746 * statement.cs: Updates after MemberCore changes.
6748 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
6749 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
6751 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
6752 obsolete attribute for compiler construct.
6753 (As.DoResolve): Cache result.
6755 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
6757 2005-09-26 Raja R Harinath <rharinath@novell.com>
6760 * expression.cs (This.VerifyFixed): In a value type T, the type of
6761 'this' is T&, iow, 'this' is either an out or ref parameter. In a
6762 value type R, 'this' is treated as a value parameter.
6764 2005-09-22 Miguel de Icaza <miguel@novell.com>
6766 * statement.cs (Lock): Use the TemporaryVariable class instead of
6767 manually using local variables as those do not work when variables
6770 * ecore.cs: Moved the TemporaryVariable class from being a nested
6771 class inside Foreach to be a public class that can be employed in
6774 2005-09-19 Marek Safar <marek.safar@seznam.cz>
6776 * cs-parser.jay: interface_accessors replaced by
6777 accessor_declarations.
6779 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
6782 * statement.cs (GotoCase.Resolve): Convert null constant to
6784 (SwitchLabel.ResolveAndReduce): Ditto.
6785 (SwitchLabel.NullStringCase): Custom null stamp.
6786 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
6788 typemanager.cs (CSharpSignature): Don't skip first argument
6791 2005-09-18 Miguel de Icaza <miguel@novell.com>
6793 * driver.cs: Set InEmacs based on the environment variable EMACS.
6795 * location.cs (InEmacs): in this mode, do not report column
6796 location as it confuses Emacs.
6798 2005-09-16 Marek Safar <marek.safar@seznam.cz>
6800 * cfold.cs, constant.cs, convert.cs, ecore.cs,
6801 expression.cs, iterators.cs, literal.cs: Store constants and
6804 * class.cs (MemberBase.ShortName): Pass location.
6806 * cs-parser.jay: Some location fixes.
6808 * ecore.cs (Expression.Location): Made virtual.
6810 2005-09-05 Miguel de Icaza <miguel@novell.com>
6812 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
6813 if the underlying types are the same, otherwise we need to produce
6814 code that will do the proper cast.
6816 This was exposed by Marek's constant rewrite which produced
6817 invalid code for the call site:
6820 void Method (X v) {}
6824 This fixes test-49.cs
6826 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6828 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
6829 Type/Object should be allowed as well. Fixed bug #75968.
6831 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6833 * expression.cs : (Binary.DoResolve): when one is enum constant and
6834 another is constant 0, then return enum one *as enum type*.
6837 2005-09-02 Raja R Harinath <rharinath@novell.com>
6839 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
6843 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
6844 flow-branching for LocalVariableReferences in case we were invoked
6845 from a MemberAccess.
6846 * expression.cs (LocalVariableReference.VerifyAssigned): New.
6848 (LocalVariableReference.DoResolveBase): ... this.
6849 (MemberAccess.Resolve): Do the check that was disabled during
6852 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6855 (PartialContainer.Create): check abstract/sealed/static strictly
6856 but abstract/sealed can exist only at one side. Fixed bug #75883.
6858 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
6861 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
6862 specified, don't default to UnmanagedType.I4.
6864 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6866 * expression.cs : conditional operator should check possibly
6867 incorrect assign expression. Fixed bug #75946.
6869 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6871 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
6872 Reverting the change. gmcs is much complex than mcs on this matter.
6874 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6876 * cs-tokenizer.cs : To read another token ahead of the actual
6877 consumption, use new SavedToken and cache token instead of moving
6878 back the stream with SeekableStreamReader (it seemed problematic).
6880 driver.cs : Thus use StreamReader directly.
6881 * support.cs : Thus removed SeekableStreamReader.
6883 2005-08-30 Raja R Harinath <rharinath@novell.com>
6886 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
6887 (ScopeInfo.EmitScopeType): Use it to construct field names from
6888 names of captured locals.
6891 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
6892 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
6893 Pass 'target_type' to BoxedCast. Don't default to 'object'.
6894 (ExplicitConversion): Remove enum cases already handled by
6895 implicit conversion. Move implicit conversion check to the beginning.
6896 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
6897 * expression.cs (ArrayCreation.EmitDynamicInitializers):
6898 Don't treat System.Enum as a struct.
6900 2005-08-30 Jb Evain <jbevain@gmail.com>
6902 * attribute.cs: handles as expression in parameters.
6904 2005-08-30 Raja R Harinath <rharinath@novell.com>
6907 * class.cs (TypeContainer.VerifyClsName): Don't use a
6908 PartialContainer when verifying CLS compliance.
6909 (AbstractPropertyEventMethod): Set Parent here, ...
6910 (PropertyMethod): ... not here.
6912 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
6914 * attribute.cs : escaped attribute name should not be allowed to be
6915 resolved (e.g. @class as classAttribute). Fixed bug #75930.
6917 2005-08-29 Raja R Harinath <rharinath@novell.com>
6920 * convert.cs (ImplicitStandardConversionExists): Allow zero also
6921 when converting a long constant to unsigned long.
6922 * expression.cs (Invocation.OverloadResolve): Add sanity check to
6923 detect where IsApplicable and VerifyArgumentsCompat disagree.
6925 2005-08-29 Raja R Harinath <rharinath@novell.com>
6926 and Carlos Alberto Cortez <carlos@unixmexico.org>
6929 * class.cs (TypeContainer.CanElideInitializer): New helper.
6930 (TypeContainer.EmitFieldInitializers): Use it to determine if we
6931 can safely emitting the initializer of a field.
6933 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6935 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
6936 allowed inside a switch (without loop). Fixed bug #75433.
6938 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
6940 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
6941 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
6943 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6945 * driver.cs : kinda reverting the default encoding changes (not exact
6946 revert since I noticed that "codepage:reset" might not work fine).
6948 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6950 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
6951 Location. Now getter and setter store location correctly.
6952 (errors/cs0111-12.cs now reports the expected location.)
6954 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6956 * driver.cs : Use default encoding on the environment.
6957 Removed (now that) extra parameter for SeekableStreamReader.
6958 * support.cs : (SeekableStreamReader) third .ctor() argument for
6959 StreamReader is not required (always true). preamble size could
6960 be acquired in simpler and safe way.
6962 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
6964 * cs-parser.jay: report CS0642 at warning level 3
6965 and report CS0642 for an if else statement also
6966 fixes bug #74745. Patch by John Luke (and a bit
6968 Removed extra CS0642 warning check for "while",
6970 * statement.cs: In Block.Resolve(), CS0642 check
6971 is reimplemented to check a sequence of an empty
6972 statement and a block.
6974 Both fix bug #66777.
6976 2005-08-24 Marek Safar <marek.safar@seznam.cz>
6978 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
6979 detection until I fix it.
6981 * cs-tokenizer.cs: Changed error message.
6983 * cs-parser.jay: Fixed 2 error locations.
6985 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
6986 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
6989 * enum.cs (GetSignatureForError): Fixed.
6991 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
6995 * typemanager.cs (RegisterProperty): Removed.
6997 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
6999 2005-08-24 Raja R Harinath <rharinath@novell.com>
7002 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
7003 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
7005 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7007 * expression.cs : tiny fix is required for not warning positive ulong.
7010 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7012 * expression.cs : add CS0652 check for constant and integral
7013 expression. Fixed bug #53974.
7015 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7017 * expression.cs : in DoNumericPromotions(), check if there is implicit
7018 conversion overload for string (to check CS0034). Fixed bug #52492.
7020 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7022 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
7024 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7026 * ecore.cs : report location when it is *not* Null.
7028 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7034 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
7035 correctly. Fixed bug #75721.
7037 2005-08-23 Raja R Harinath <rharinath@novell.com>
7039 * support.cs (SeekableStreamReader.Position): Avoid an expensive
7040 loop that performs 'min (pos, char_count)'.
7043 * expression.cs (Unary.ResolveOperator): Don't discard implicit
7044 converted value in Operator.OnesComplement.
7046 2005-08-22 Ben Maurer <bmaurer@ximian.com>
7048 * anonymous.cs: If the anon method is pulled into a helper class,
7049 it needs to be `internal' not `private'. Fixes runtime behavior on
7052 2005-08-20 Martin Baulig <martin@ximian.com>
7054 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7055 scope if we don't already have it.
7057 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7058 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
7061 2005-08-17 Marek Safar <marek.safar@seznam.cz>
7064 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
7067 2005-08-16 Marek Safar <marek.safar@seznam.cz>
7069 The big constants rewrite
7070 Fix #75746, #75685 and more
7071 As a side effect saved 1MB for MWF ;-)
7073 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
7074 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
7075 enum based for corlib compilation.
7077 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
7080 * class.cs (FixedField.Define): Use ResolveAsConstant.
7082 * const.cs (IConstant): Interface constants and enums.
7083 (Const.ResolveValue): New method for constant resolvning.
7084 (ExternalConstant): Constants from imported assemblies.
7086 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
7087 conversion; like enums.
7088 (Constant.ToType): Converts this constant to different type.
7089 (Constant.Increment): Adds 1.
7091 * convert.cs (ImplicitConversionRequired): Simplified.
7093 * cs-parser.jay: Create EnumMember directly.
7095 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
7097 * doc.cs (GenerateEnumDocComment): Removed.
7099 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
7100 (ConvertIntLiteral): Removed.
7101 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
7103 * enum.cs (EnumMember): Implement IConstant.
7104 (Enum.IsValidEnumConstant): Removed.
7105 (Enum.GetNextDefaultValue): Removed.
7106 (Enum.FindMembers): Updated.
7107 (Enum.GenerateDocComment): Iterate enum members.
7109 * expression.cs (Cast.TryReduce): Handle enums correctly.
7110 (New.Constantify): Made public.
7111 (MemberAccess.DoResolve): Removed contant specific if(s).
7113 * literal.cs (NullLiteral): Implement new abstract methods.
7115 * statement.cs (GotoCase.Resolve): Use new constant methods.
7116 (SwitchLabel.ResolveAndReduce): Use new constant methods.
7118 * typemanager.cs (LookupEnum): Removed.
7119 (IsEnumType): Fixed to work with corlib.
7120 (RegisterConstant): Removed.
7121 (LookupConstant): Removed.
7122 (GetConstant): Changed to work with IConstant.
7124 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
7126 * location.cs : Fixed overflown (>255) column number.
7128 2005-08-03 Raja R Harinath <rharinath@novell.com>
7130 First cut of the qualified-alias-member feature.
7131 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
7133 * cs-parser.jay (DOUBLE_COLON): New token.
7134 (namespace_or_type_name): Add rule for recognizing
7135 qualified-alias-members.
7136 (primary_expression): Likewise.
7137 (element_access): Allow QualifiedAliasMember as a possible
7138 type-bearing expression.
7139 (local_variable_type, local_variable_pointer_type): Likewise.
7140 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
7141 aliases in the current and enclosing namespace declarations.
7142 (NamespaceEntry.UsingAlias): Add CS0440 warning.
7143 * decl.cs (MemberName.is_double_colon): New.
7144 (MemberName.MemberName): Add new constructor for alias-member.
7145 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
7146 * expression.cs (QualifiedAliasMember): New expression type.
7148 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7150 * location.cs : it borked when no argument was specified.
7152 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7154 * location.cs : tiny ToString() format fix.
7156 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7158 * statement.cs : oops, it was missing.
7160 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7162 A set of fixes for precise line/column location.
7165 "token" field now holds a file/line "delta", a line number offset
7166 from the segment, and a column number. See also:
7167 http://lists.ximian.com/pipermail/mono-devel-list/2004-
7168 December/009508.html
7169 Removed static IsNull. Use instance IsNull property instead.
7171 For some tokens it stores Location. For Identifier it stores
7172 LocatedToken which is a pair of string name and location.
7173 Column numbers are adjusted only at getChar().
7175 Use Location.ToString() for reporting (it now contains column).
7177 Largely modified to use LocatedToken instead of
7178 string (IDENTIFIER), and to acquire Location from some tokens.
7179 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
7180 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
7182 Now MemberName holds Location. DeclSpace.ctor() receives Location
7183 as a parameter. Removed extra parameters to all derived classes.
7184 Replaced Location.IsNull() with instance property.
7185 * assign.cs, expression.cs :
7186 Added .ctor() overload that omits Location.
7188 Added "nameEscaped" flag that indicates the identifier was escaped
7189 in the source file. This fixes bug #57047.
7191 2005-08-02 Marek Safar <marek.safar@seznam.cz>
7193 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
7194 New method, looking for lo-case imported cls type.
7196 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
7199 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
7201 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
7203 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
7205 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
7207 Optimized to save 3.5 MB for SWF compilation.
7209 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7211 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
7212 (PartialContainer.Create): Moved logic AddToContainer.
7213 (PartialContainer.MarkForDuplicationCheck): Shares name.
7215 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
7218 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
7220 (Namespace.GetSignatureForError): New method.
7222 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
7223 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
7225 2005-08-01 Raja R Harinath <rharinath@novell.com>
7228 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
7229 member lookup rather than qualifier_type, since qualifier_type can
7232 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7234 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
7237 2005-07-31 Miguel de Icaza <miguel@novell.com>
7239 * statement.cs: Copy the local exception into the exception
7240 captured local. Fixes 75674
7242 2005-07-31 Raja R Harinath <harinath@gmail.com>
7245 * expression.cs (Invocation.OverloadResolve): Don't report error
7246 CS1501 if error CS1502 has been reported.
7247 (New.DoResolve): Delegate CS1501 reporting to
7248 Invocation.OverloadResolve.
7251 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
7252 invariant-meaning-in-block property in an enclosing block if
7255 2005-07-29 Marek Safar <marek.safar@seznam.cz>
7257 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
7258 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
7259 (Switch.CheckSwitch): Just save 50kb for SWF.
7261 2005-07-27 Martin Baulig <martin@ximian.com>
7263 * anonymous.cs (CaptureContext.AddField): Added
7264 `AnonymousContainer am' argument; compute its toplevel scope if
7265 it's not already computed. Fixes #75649.
7267 2005-07-26 Raja R Harinath <rharinath@novell.com>
7270 * class.cs (Constructor.Emit): Reset block to null if the block
7273 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7275 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
7277 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7279 * class.cs (MethodData.Define): Check whether accessor implementing
7280 interface is public.
7282 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
7284 2005-07-22 Marek Safar <marek.safar@seznam.cz>
7287 * namespace.cs (LookupType): Moved same type check to...
7289 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
7292 2005-07-21 Raja R Harinath <rharinath@novell.com>
7294 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
7295 already found a typebuilder.
7296 * class.cs (MethodCore.IsDuplicateImplementation): Compare
7297 MemberNames, not strings.
7299 * const.cs (Error_ExpressionMustBeConst):
7300 Rename from Error_EpressionMustBeConst.
7301 * const.cs, class.cs, statement.cd: Update.
7303 2005-07-21 Marek Safar <marek.safar@seznam.cz>
7307 * const.cs (Const.LookupConstantValue): Report missing contant expression
7309 (Error_EpressionMustBeConstant): Only one error method.
7311 * class.cs, statement.c: Updated.
7313 2005-07-20 Raja R Harinath <rharinath@novell.com>
7315 * statement.cs (Block.Flags): Add back HasVarargs.
7316 (Block.flags): Make protected.
7317 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
7319 * typemanager.cs (types, typecontainers, user_types): Remove.
7320 (UserTypes, TypeContainers): Likewise.
7321 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
7322 (CleanUp, Reset): Update.
7323 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
7324 (GetNestedType): Use Type.GetNestedType.
7325 (CoreLookupType): Take two arguments, the namespace and the
7326 basename of the type. Update to use the Namespace.Lookup
7328 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
7329 (RealMemberLookup): Use IsNestedChildOf instead of playing with
7330 string concatenation and substring matches.
7331 * class.cs, enum.cs, delegate.cs: Update to changes.
7333 2005-07-20 Marek Safar <marek.safar@seznam.cz>
7335 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
7336 Expression and made virtual.
7338 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
7339 (ImplicitStandardConversionExists): Fixed `byte' typo ?
7341 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
7343 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
7346 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
7349 2005-07-18 Marek Safar <marek.safar@seznam.cz>
7352 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
7353 AssemblyCultureAttribute is not used on executable.
7356 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
7358 2005-07-16 Raja R Harinath <rharinath@novell.com>
7361 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
7362 New. Reports CS0252/CS0253.
7363 Mostly taken from preliminary patch by Duncak Mak.
7364 (Binary.DoResolveOperator): Store results of operator lookup.
7365 Use them to detect if we need to warn about unintended reference
7368 2005-07-15 Raja R Harinath <rharinath@novell.com>
7371 * namespace.cs (Namespace.Lookup): Add back location parameter.
7372 (Namespace.LookupType): Add CS0436 report. Add location parameter.
7373 * delegate.cs, ecore.cs, expression.cs: Update to changes.
7375 * codegen.cs (EmitContext.DeclSpace): Make readonly.
7376 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
7377 (Namespace.LookupType): ... this.
7378 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
7380 * typemanager.cs (LookupTypeReflection): Remove buggy code that
7381 purported to handle pointers.
7382 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
7385 2005-07-15 Marek Safar <marek.safar@seznam.cz>
7387 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
7390 2005-07-15 Raja R Harinath <rharinath@novell.com>
7392 * namespace.cs (Namespace.Lookup): Drop location parameter.
7393 (NamespaceEntry.LookupAlias): Remove. Merge into ...
7394 (NamespaceEntry.Lookup): ... this.
7395 (NamespaceEntry.Error_AmbiguousTypeReference):
7396 Move here from DeclSpace.
7397 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
7399 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
7400 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
7401 Move to NamespaceEntry.
7402 * delegate.cs, expression.cs: Update to changes.
7404 2005-07-14 Marek Safar <marek.safar@seznam.cz>
7406 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
7407 CheckAttributeType and refactored.
7408 (Attribute.ResolvePossibleAttributeType): Changed to reuse
7409 ResolveAsTypeTerminal error handling.
7410 (ResolveAsTypeTerminal): Introduced because of global attributes extra
7412 (GetSignatureForError): Print errors in same way.
7415 * codegen.cs: Reflect attribute GetSignatureForError change.
7418 * expression.cs: Add silent parameter to ResolveAsTypeStep.
7420 * namespace.cs (UsingEntry): Refactored to make fields private.
7423 statement.cs: Error_UnexpectedKind has extra parameter.
7425 2005-07-14 Raja R Harinath <rharinath@novell.com>
7427 * ecore.cs (IAlias): Remove.
7428 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
7429 that implement the interface.
7430 * namespace.cs (Namespace): Likewise.
7431 (Namespace.declspaces): Renamed from 'defined_names'.
7432 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
7433 DeclSpace instead of an IAlias.
7434 * tree.cs (Tree.AddDecl): Update.
7436 2005-07-12 Raja R Harinath <rharinath@novell.com>
7438 * statement.cs (Block.Flags); Remove HasVarargs.
7439 (Block.HasVarargs): Move to ToplevelBlock.
7440 (Block.ThisVariable, Block.AddThisVariable): Likewise.
7441 (Block.Variables): Make protected. Initialize variable hashtable
7443 (Block.AddVariable): Update.
7444 (Block.Resolve): Update to changes.
7445 (ToplevelBlock.HasVarargs): New boolean.
7446 (ToplevelBlock.ThisVariable): Move here from Block.
7447 (ToplevelBlock.AddThisVariable): Likewise.
7448 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
7449 * expression.cs (This.ResolveBase): Update to changes.
7450 (ArglistAccess.DoResolve): Likewise.
7452 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7455 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
7457 * class.cs (TypeContainer.VerifyMembers): Distinguish between
7458 not used and not used & assigned.
7459 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
7461 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7464 * expression.cs (Is.DoResolve): null is never provided type.
7466 2005-07-08 Marek Safar <marek.safar@seznam.cz>
7469 * cs-parser.jay: Less strict event error rule to catch more errors.
7471 2005-07-08 Martin Baulig <martin@ximian.com>
7473 Fix test-iter-10.cs - distinguish whether we `yield' in a property
7474 gettter (allowed) or setter (not allowed).
7476 * class.cs (Accessor): Implement IIteratorContainer.
7477 (Accessor.Yields): New public field.
7478 (PropertyBase.PropertyMethod.Define): Handle iterators on a
7482 (get_accessor_declaration, set_accessor_declaration): Set the
7483 `yields' flag on the accessor, not the property.
7484 (property_declaration): Do the iterators check on a per-accessor
7485 basis and not for the whole property.
7487 2005-07-08 Martin Baulig <martin@ximian.com>
7489 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
7490 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
7492 2005-07-07 Marek Safar <marek.safar@seznam.cz>
7495 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
7496 (ExtractSecurityPermissionSet): Cope with self referencing security
7497 attributes properly.
7499 * driver.cs (SetOutputFile): Made public property OutputFile.
7501 2005-07-07 Raja R Harinath <rharinath@novell.com>
7504 * class.cs (TypeContainer.first_nonstatic_field): Rename from
7505 has_nonstatic_fields. Make into a FieldBase pointer.
7506 (TypeContainer.AddField): Add CS0282 check.
7507 (TypeContainer.EmitType): Update.
7509 2005-07-06 Miguel de Icaza <miguel@novell.com>
7511 * cs-tokenizer.cs (consume_identifier): Do not create strings to
7512 compare if they start with __.
7514 2005-07-06 Raja R Harinath <rharinath@novell.com>
7516 * statement.cs (Switch.SwitchGoverningType): Only look at
7517 UserCasts that don't need implicit standard conversions to one of
7518 the allowed switch types (Fixes test-322.cs).
7519 (LocalInfo.Resolve): Re-enable sanity-test.
7521 2005-07-06 Marek Safar <marek.safar@seznam.cz>
7523 * cs-tokenizer.cs (consume_identifier): Detect double undescores
7525 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
7527 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
7529 2005-07-06 Raja R Harinath <rharinath@novell.com>
7532 * ecore.cs (SimpleName.GetSignatureForError): Add.
7533 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
7534 (MemberAccess.GetSignatureForError): Add.
7536 2005-07-05 Marek Safar <marek.safar@seznam.cz>
7538 The big error and warning messages review.
7568 * typemanager.cs: Updated.
7570 * class.cs: (MethodCore.SetYields): Moved here to share.
7571 (PropertyMethod.Define): Moved iterator setup here.
7573 * iterators.cs: Add orig_method to have full access to parent
7576 2005-07-05 Raja R Harinath <rharinath@novell.com>
7578 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
7579 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
7580 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
7581 variable of struct type.
7582 * expression.cs (Unary.ResolveOperator): Update to change.
7583 (Indirection.VerifyFixed): Likewise.
7584 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
7585 (ParameterReference.VerifyFixed): Value parameters are fixed.
7586 (This.VerifyFixed): Treat 'this' as a value parameter.
7587 * statement.cs (LocalInfo.IsFixed): Remove.
7589 2005-07-01 Martin Baulig <martin@ximian.com>
7591 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
7592 `ec.EmitThis ()' to get the correct scope.
7594 2005-07-01 Martin Baulig <martin@ximian.com>
7596 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
7597 instance is a ParameterReference; fixes #75299.
7599 2005-07-01 Martin Baulig <martin@ximian.com>
7601 Reverted Marek's latest patch (r46725):
7602 - it contains structural changes which are neither mentioned in
7603 the ChangeLog nor explained anywhere; for example the additional
7604 argument of EmitContext's and Iterator's .ctor's and the
7605 TypeContainer.DefineMembers() change.
7606 - structural changes like this should go in in seperate patches
7607 and not be hidden in a huge patch which just seems to affect
7608 warnings and errors.
7609 a big and hard to understand patch.
7610 - it breaks iterators and causes regressions, for instance in
7613 2005-06-30 Raja R Harinath <rharinath@novell.com>
7616 * expression.cs (Indexers.map): Remove.
7617 (Indexers.Append): Filter out inaccessible setters and getters.
7618 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
7621 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
7623 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
7624 (FieldExpr.Emit, PropertyExpr.Emit): Update.
7625 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
7626 * expression.cs (Invocation.EmitCall): Add CS0120 check.
7628 2005-06-30 Marek Safar <marek.safar@seznam.cz>
7631 * class.cs (FieldBase.GetInitializerExpression): One more field
7634 2005-06-28 Miguel de Icaza <miguel@novell.com>
7636 * pending.cs: Do not define a proxy if the base method is virtual,
7637 it will be picked up by the runtime (bug 75270).
7639 2005-06-08 Martin Baulig <martin@ximian.com>
7641 The big Iterators rewrite :-)
7643 * iterators.cs: Rewrite this to use the anonymous methods framework.
7645 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
7646 before the TypeContainers; see 2test-21.cs.
7649 (TypeContainer.DefineType): Don't create a new EmitContext if we
7650 already have one (this only happens if we're an Iterator).
7651 (TypeContainer.Define): Also call Define() on all our iterators.
7652 (Method.CreateEmitContext): Added support for iterators.
7655 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
7656 (AnonymousContainer.CreateMethodHost): Moved here from
7657 AnonymousMethod and made abstract.
7658 (AnonymousContainer.CreateScopeType): New abstract method.
7659 (AnonymousContainer.IsIterator): New public property.
7660 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
7661 get the ScopeTypeBuilder rather than manually defining it here.
7662 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
7665 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
7666 before RootContext.DefineTypes().
7668 * codegen.cs (EmitContext.RemapToProxy): Removed.
7669 (EmitContext.CurrentAnonymousMethod): Changed type from
7670 AnonymousMethod -> AnonymousContainer.
7671 (EmitContext.ResolveTopBlock): Protect from being called twice.
7672 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
7673 (EmitContext.EmitThis): Removed the iterators hacks; use the
7674 anonymous methods framework for that.
7677 (ToplevelBlock.Container): Make this a property, not a field.
7678 (ToplevelBlock.ReParent): New public method; move the
7679 ToplevelBlock into a new container.
7680 (Foreach.TemporaryVariable): Simplify.
7682 2005-06-05 Martin Baulig <martin@ximian.com>
7684 * statement.cs (LocalInfo.CompilerGenerated): New flag.
7685 (Block.AddTemporaryVariable): New public method; creates a new
7686 `LocalInfo' for a temporary variable.
7687 (Block.EmitMeta): Create the LocalBuilders for all the temporary
7689 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
7690 non-iterator variables.
7692 2005-06-05 Martin Baulig <martin@ximian.com>
7694 * statement.cs (Foreach.TemporaryVariable): Create the
7695 LocalBuilder in the Emit phase and not in Resolve since in some
7696 situations, we don't have an ILGenerator during Resolve; see
7697 2test-19.cs for an example.
7699 2005-06-04 Martin Baulig <martin@ximian.com>
7701 **** Merged r45395 from GCS ****
7703 The big Foreach rewrite - Part II.
7705 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
7706 with `PropertyInfo ienumerator_getcurrent'.
7708 * codegen.cs (VariableStorage): Removed.
7711 (Foreach): Derive from Statement, not ExceptionStatement.
7712 (Foreach.CollectionForeach): New nested class. Moved all the code
7713 dealing with collection foreach here.
7714 (Foreach.ForeachHelperMethods): Removed.
7715 (Foreach.TemporaryVariable): Implement IMemoryLocation.
7717 2005-05-23 Martin Baulig <martin@ximian.com>
7719 * statement.cs (Try.DoResolve): Don't create a `finally' if we
7720 don't need to. Fix #75014.
7722 2005-05-20 Martin Baulig <martin@ximian.com>
7724 Merged r44808 from GMCS.
7726 * class.cs (TypeContainer.CircularDepException): Removed.
7727 (TypeContainer.DefineType): Removed the `InTransit' stuff.
7728 (TypeContainer.CheckRecursiveDefinition): Check for circular class
7729 (CS0146) and interface (CS0529) dependencies here.
7731 2005-06-21 Raja R Harinath <rharinath@novell.com>
7733 * expression.cs (Invocation.EmitCall): Fix initialization
7734 'this_call' to reflect current behaviour. Fix indentation.
7736 * convert.cs (FindMostEncompassedType): Add two trivial special
7737 cases (number_of_types == 0 || number_of_types == 1).
7738 (FindMostEncompasingType): Likewise.
7740 2005-06-17 Raja R Harinath <rharinath@novell.com>
7742 Some cleanups preparing for the fix of #75283.
7743 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
7745 (EventExpr.InstanceResolve): Likewise.
7746 (EventExpr.DoResolve): Remove redundant checks.
7748 2005-06-10 Duncan Mak <duncan@novell.com>
7750 * cs-tokenizer.cs (process_directives): New flag for controlling
7751 the processing of preprocessor directives.
7752 (x_token): After seeing a '#', return Token.NONE instead of going
7753 to handle_preprocessing_directive() when not processing
7754 directives. This avoids unnecessary processing during the token peek in
7759 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
7760 the existing error reporting methods instead of Report.Error.
7762 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
7763 after Raja's rewrite.
7765 2005-06-08 Miguel de Icaza <miguel@novell.com>
7767 * class.cs: Small fix.
7769 2005-06-08 Raja R Harinath <rharinath@novell.com>
7772 * class.cs (GetPartialBases): Fix return value check of
7775 2005-06-07 Raja R Harinath <rharinath@novell.com>
7777 Ensure that partial classes are registered in their enclosing
7778 namespace. Initial part of fix of #75160.
7779 * tree.cs (Tree.RecordDecl): Add new namespace argument.
7780 Register declspace with namespace here, not in
7781 DeclSpace.RecordDecl.
7782 * cs-parser.jay: Pass namespace to RecordDecl.
7783 * class.cs (PartialContainer.Create): Likewise.
7784 (ClassPart.DefineType): New sanity-check. Throws an exception if
7786 * decl.cs (Declspace.RecordDecl): Remove.
7787 * namespace.cs (NamespaceEntry.DefineName): Remove.
7789 2005-06-06 Marek Safar <marek.safar@seznam.cz>
7791 * rootcontext.cs: Reset TargetExt as well.
7793 2005-06-03 Raja R Harinath <rharinath@novell.com>
7795 * ecore.cs (Expression.Resolve): Emit CS0654 error when
7798 2005-06-02 Raja R Harinath <rharinath@novell.com>
7800 Fix #75080, cs0119.cs.
7801 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
7803 (Expression.Resolve): ... this. Use it. Remove bogus code
7804 allowing ExprClass.Type and ExprClass.Namespace for
7805 ResolveFlags.VariableOrValue.
7806 (Expression.Resolve) [1-argument variant]: Change default resolve
7807 flags based on language version.
7808 (Expression.Error_UnexpectedKind): Use a simple string array
7809 rather than an ArrayList.
7810 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
7812 (TypeOfVoid.DoResolve): Likewise.
7813 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
7814 flags argument -- it always has the same value.
7816 2005-05-31 Raja R Harinath <rharinath@novell.com>
7819 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
7820 Use it in the error message.
7821 * assign.cs, expression.cs, statement.cs: Update.
7823 2005-05-30 Raja R Harinath <rharinath@novell.com>
7826 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
7827 the "almostMatchedMember" case too.
7828 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
7829 that failed the accessibility checks to 'almost_match'.
7831 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
7833 * attribute.cs: Use internal MethodBuilder methods to set
7834 ExactSpelling and SetLastError on PInvoke methods, instead
7835 of passing them via charset. Fixes #75060.
7837 2005-05-27 Raja R Harinath <rharinath@novell.com>
7839 * parameter.cs (Parameter): Remove TODO comment.
7840 (Parameter.DefineParameter): Remove Location parameter.
7841 (Parameters.LabelParameters): Likewise.
7842 * class.cs (Constructor.Emit): Update to change.
7843 (MethodData.Emit): Likewise.
7844 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
7845 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
7847 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
7850 Removed Parameters.Location and added Parameter.Location instead.
7851 Removed Location parameter from Emit() and GetSignature().
7858 Modified all related calls.
7860 2005-05-26 Raja R Harinath <rharinath@novell.com>
7862 Improve user-defined conversion handling.
7863 * convert.cs (GetConversionOperators): Rewrite. Return only the
7864 applicable operators.
7865 (AddConversionOperators): New. Helper for GetConversionOperators.
7866 (FindMostEncompassedType, FindMostEncompassingType): Verify that
7867 there is only one most encompassed/encompassing type.
7868 (FindMostSpecificSource, FindMostSpecificTarget): Remove
7869 "applicable operator" handling.
7870 (UserConversion): Move cache here from GetConversionOperators.
7871 Directly cache the chosen operator, rather than the whole
7873 (ExplicitNumericConversion): Fix buggy implementation of Decimal
7874 case. Allow conversion of decimal to sbyte and byte too.
7875 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
7876 New static methods. Used to avoid allocating EmptyExpressions in
7879 2005-05-24 Duncan Mak <duncan@novell.com>
7881 * ecore.cs (CastFromDecimal): New class for casting a decimal to
7882 another class, used in Convert.ExplicitNumericConversion.
7883 (CastToDecimal): New class, similar to above, but casts to
7884 System.Decimal, used in Convert.ImplicitNumericConversion and also
7885 in explicit convesion from double/float to decimal.
7887 * convert.cs (ImplicitNumericConversion): Handle implicit
7888 conversions to System.Decimal.
7889 (ExplicitNumericConversion): handle explicit conversions to
7894 2005-05-20 Miguel de Icaza <miguel@novell.com>
7896 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
7897 know the type at this stage, just break through. Fixes #75008
7899 2005-05-19 Martin Baulig <martin@ximian.com>
7902 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
7903 to disable error reporting.
7905 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
7906 here since we don't want to report an error; see the new test-336.cs.
7908 2005-05-19 Raja R Harinath <rharinath@novell.com>
7910 * statement.cs (ToplevelBlock.GetParameterReference)
7911 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
7912 Move here from class Block.
7913 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
7914 * expression.cs (ParameterReference.DoResolveBase): Likewise.
7916 2005-05-18 Martin Baulig <martin@ximian.com>
7921 (FlowBranching.Reachability): Add non-static public And() and Or()
7923 (FlowBranchingSwitch): New class; do the `break_origins' thing
7924 like in FlowBranchingLoop.
7925 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
7926 reachability, not just locals and parameters.
7927 (FlowBranching.MergeChild): Remove some of the hacks for loop and
7928 switch; MergeBreakOrigins() now takes care of that.
7930 2005-05-18 Martin Baulig <martin@ximian.com>
7932 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7933 a loop and may leave it, reset the barrier; fixes #74974.
7935 2005-05-17 Marek Safar <marek.safar@seznam.cz>
7937 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
7940 * cs-parser.jay: Catch more lexical errors.
7942 * report.cs: Add one more Error method.
7945 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
7947 2005-05-17 Martin Baulig <martin@ximian.com>
7949 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
7952 2005-05-16 Raja R Harinath <rharinath@novell.com>
7954 Fix test-382.cs. Emit values of decimal constants.
7955 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
7957 (TypeContainer.AddField): ... this.
7958 (TypeContainer.EmitFieldInitializers): Allow the list of fields
7959 with initializers to include 'Const's.
7960 (ClassPart.RegisterFieldForInitialization): Forward to
7962 * const.cs (Const.Const): Pass initializer to base class.
7963 (Const.Define): In case of decimal constants, register them for
7964 initialization in a static constructor.
7966 2005-05-14 Martin Baulig <martin@ximian.com>
7968 * statement.cs (Block.Resolve): Correctly handle unreachable code;
7969 do not call ResolveUnreachable() on unreachable statements in
7970 here, see the comment in the source code.
7972 2005-05-13 Raja R Harinath <rharinath@novell.com>
7975 * expression.cs (BinaryResolveOperator): If one of the operands of
7976 an equality comparison is 'null' and the other is a pointer type,
7977 convert the null to a NullPointer.
7978 * convert.cs (ImplicitReferenceConversion): If the expression is a
7979 NullLiteral and the target type is a pointer type, return a
7980 NullPointer instead.
7981 (ImplicitConversionStandard): Likewise.
7983 2005-05-13 Marek Safar <marek.safar@seznam.cz>
7985 * cs-parser.jay: Set readonly context based on special constructs.
7987 * expression.cs (LocalVariableReference.DoResolveBase): Improved
7988 readonly variable error handling.
7990 * rootcontext.cs (EmitCode): Don't verify members when error
7993 * statement.cs (LocalInfo): Add reaodnly context information.
7994 (SetReadOnlyContext, GetReadOnlyContext): New methods.
7996 2005-05-13 Raja R Harinath <rharinath@novell.com>
7998 * statement.cs (Block.Resolve): Revert change below. Modify fix
7999 for #74041 to initialize 'resolved' to false only for explicit
8000 blocks. Fixes #74873.
8002 2005-05-12 Raja R Harinath <harinath@gmail.com>
8005 * typemanager.cs (unmanaged_enclosing_types): New.
8006 (IsUnmanagedType): Avoid infloops by using
8007 'unmanaged_enclosing_types' to talk with recursive invocations.
8009 2005-05-13 Martin Baulig <martin@ximian.com>
8011 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
8012 instance variable, not a local. Fix #74873.
8013 (Block.ResolveUnreachable): Set it to true here.
8015 2005-05-11 Duncan Mak <duncan@novell.com>
8017 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
8018 continuing to process for 'arg'.
8019 (handle_preprocessing_directive): Check the argument of the #endif
8020 directive and report error CS1025 if there are any trailing
8023 According to the C# spec, having even whitespace after the #endif
8024 directive is illegal; however, because we call arg.TrimEnd ()
8025 beforehand, we have the same behavior as csc, allowing whitespace
8026 after the directive.
8030 2005-05-11 Marek Safar <marek.safar@seznam.cz>
8034 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
8035 (Constructor.GetObsoleteAttribute): Implemented correctly.
8037 2005-05-10 Martin Baulig <martin@ximian.com>
8039 * support.cs (ReflectionParameters.ParameterModifier): Use
8040 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
8041 and `ParameterAttributes.In'. Fixes #74884.
8043 2005-05-10 Marek Safar <marek.safar@seznam.cz>
8045 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
8047 * expression.cs (Argument.GetParameterModifier): Turned to property.
8048 (Invocation.Error_InvalidArguments): Add more descriptive errors.
8050 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
8053 2005-05-09 Raja R Harinath <rharinath@novell.com>
8056 * decl.cs (MemberCache.AddMethods): Register override methods,
8057 rather than non-override methods.
8058 * typemanager.cs (RegisterOverride): New.
8059 (IsOverride): Update.
8061 2005-05-09 Marek Safar <marek.safar@seznam.cz>
8065 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
8066 recursive declaration.
8068 * statement.cs (Block.ResolveMeta): Report any error in resolving.
8070 2005-05-06 Marek Safar <marek.safar@seznam.cz>
8072 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
8074 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
8076 2005-05-05 Raja R Harinath <rharinath@novell.com>
8079 * decl.cs (DeclSpace.FamilyAccessible):
8080 Use TypeManager.IsNestedFamilyAccessible.
8082 Fix reopened #64812.
8083 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
8086 2005-05-04 Raja R Harinath <rharinath@novell.com>
8087 Abin Thomas <projectmonokochi@rediffmail.com>
8088 Anoob V E <projectmonokochi@rediffmail.com>
8089 Harilal P R <projectmonokochi@rediffmail.com>
8092 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
8093 allow access to all static members.
8095 2005-05-04 Martin Baulig <martin@ximian.com>
8097 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
8099 2005-05-04 Martin Baulig <martin@ximian.com>
8103 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
8104 section at the end; make things work if `default' is not the last
8107 2005-05-04 Martin Baulig <martin@ximian.com>
8111 * statement.cs (Switch): Replaced the `got_default' field with a
8112 `default_section' one.
8113 (Switch.CheckSwitch): Set `default_section' here.
8114 (Switch.Resolve): If we're a constant switch and the constant is
8115 not found, use the default section.
8117 2005-05-03 Martin Baulig <martin@ximian.com>
8119 * expression.cs (ArrayAccess.EmitGetLength): New public method.
8121 * statement.cs (Foreach.ArrayForeach): New nested class.
8122 (Foreach.TemporaryVariable): New nested class.
8123 (Foreach.EmitArrayForeach): Removed; this is now in the new
8126 2005-05-03 Raja R Harinath <rharinath@novell.com>
8128 * pending.cs (BaseImplements): Move the #74773 fix here. This is
8130 (VerifyPendingMethods): Revert change below.
8132 * typemanager.cs (IsOverride, RegisterNonOverride): New.
8133 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
8134 that used to trigger warning -28. Remove warning -28.
8135 * expression.cs (Invocation.OverloadResolve): Use
8136 TypeManager.IsOverride to distinguish override methods.
8139 * pending.cs (VerifyPendingMethods): If a base type implements the
8140 requested interface, don't bother checking individual methods of
8141 the base type. As a side-effect, this prevents the creation of
8142 unnecessary proxies.
8144 2005-05-02 Martin Baulig <martin@ximian.com>
8148 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
8149 Also `And' the locals if the old vector is null.
8150 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
8151 null; in this case we basically reset all the variables.
8153 2005-05-02 Martin Baulig <martin@ximian.com>
8157 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
8158 Added `FlowBranching branching' argument; always `and' the
8159 variables instead of `or'ing them unless we're an infinite loop.
8161 * statement.cs (While.Resolve): Create a new sibling unless we're
8164 2005-05-02 Martin Baulig <martin@ximian.com>
8168 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
8169 arguments; use it instead of creating a new TopLevelBlock.
8170 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
8171 our ConstructorInitializer.
8174 (TopLevelBlock.TopLevelBranching): New public property.
8175 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
8176 and create our `TopLevelBranching'.
8178 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
8179 anonymous method host, use `block.TopLevelBranching' rather than
8180 creating a new branching.
8182 2005-04-20 Miguel de Icaza <miguel@novell.com>
8184 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
8185 a ScopeInfo, if any of the current children is a child of the new
8186 entry, move those children there.
8188 2005-04-30 Martin Baulig <martin@ximian.com>
8190 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
8191 at the beginning of a SwitchSection. Fix #73335.
8193 2005-04-27 Marek Safar <marek.safar@seznam.cz>
8196 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
8198 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
8199 (FieldExpr.DoResolve): Obsolete members are ignored for field
8202 2005-04-26 Marek Safar <marek.safar@seznam.cz>
8204 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
8205 of arrays detection.
8207 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
8209 (Field.VerifyClsCompliance): Volatile fields are not compliant.
8211 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
8214 2005-04-25 Ben Maurer <bmaurer@ximian.com>
8216 * cs-parser.jay: Use the prefered version of -unsafe in error
8219 2005-04-22 Marek Safar <marek.safar@seznam.cz>
8221 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
8224 2005-04-20 John Luke <john.luke@gmail.com>
8226 * driver.cs: fix typo in error message, --outout to --output
8228 2005-04-20 Marek Safar <marek.safar@seznam.cz>
8230 * codegen.cs (InRefOutArgumentResolving): New field.
8232 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
8233 fields outside contructor.
8235 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
8237 2005-04-19 Miguel de Icaza <miguel@novell.com>
8239 * anonymous.cs (CaptureContext.EmitParameterInstance): The
8240 parameter code was not completed ever, so it was not as up-to-date
8241 as local variables. Must finish it.
8243 The bug fix was to compare the Toplevel of the block, not the
8244 current block. Thanks for Ben for pointing this out.
8246 2005-04-19 Raja R Harinath <rharinath@novell.com>
8248 * decl.cs (AddMethods): Use the declaring type of the problem
8249 method to determine if we want to squash a warning.
8251 2005-04-19 Marek Safar <marek.safar@seznam.cz>
8253 * attribute.cs: Removed debug output.
8255 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
8257 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
8260 2005-04-18 Raja R Harinath <rharinath@novell.com>
8263 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
8264 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
8265 all null comparisons against reference types.
8267 2005-04-18 Marek Safar <marek.safar@seznam.cz>
8270 * class.cs (TypeContainer.CircularDepException) New nested
8272 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
8273 (TypeContainer.DefineType): Removed error, reset InTransit before
8275 (Class.DefineType): Throw exception when is in Transit.
8276 Catch exception and report error.
8277 (Struct.DefineType): Throw exception when is in Transit.
8278 Catch exception and report error.
8279 (Interface.DefineType): Throw exception when is in Transit.
8280 Catch exception and report error.
8282 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
8283 handle nested exception handlers.
8285 * flowanalysis.cs (InTryWithCatch): New method, search for try with
8288 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
8289 InFinally and InCatch storage.
8291 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
8292 (Catch.Resolve): Set and Restore ec.InCatch.
8293 (Try.Resolve): Set and Restore ec.InFinally.
8294 (Try.HasCatch): True when try has catch.
8296 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
8298 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
8299 for the same event member, so exclude such cases from warning 419.
8302 2005-04-16 Miguel de Icaza <miguel@novell.com>
8304 * expression.cs (Binary.ResolveOperator): Apply patch from John
8305 Luke to fix bug 59864: operators &, | and ^ on enumerations
8306 require that the same enum type on both sides.
8308 * driver.cs: Add warnings to old flag usage, this is to assist
8309 people who produce Makefiles and hope that the Makefiles will be
8312 * class.cs (TypeContainer.EmitType): Moved the definition of the
8313 special $PRIVATE$ field from the resolve phase to the Emit phase.
8314 During resolve we do not know if we are a struct with
8315 HasExplicitLayout, we know this only after the attributes for the
8318 Set the FieldOffset to zero on the dummy field that we create for
8319 the class. Fixes 74590.
8321 2005-04-16 Raja R Harinath <rharinath@novell.com>
8324 * ecore.cs (PropertyExpr.resolved): New.
8325 (DoResolve): Use it to handle a case of double resolution here.
8326 Handle a case of identical-name-and-type-name.
8327 * expression.cs (ArrayCreation.CheckIndices): Avoid double
8328 resolution by storing the results of expression resolution back
8329 into the "probes" array.
8331 2005-04-15 Raja R Harinath <rharinath@novell.com>
8333 Fix cs0208-7.cs and cs0208-8.cs.
8334 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
8335 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
8336 error reporting to point out the reason a struct is not unmanaged.
8338 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8340 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
8341 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
8343 2005-04-13 Raja R Harinath <rharinath@novell.com>
8346 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
8347 IdenticalNameAndTypeName here.
8348 (EventExpr.InstanceResolve): Likewise.
8350 2005-04-13 Marek Safar <marek.safar@seznam.cz>
8352 C# 2.0 DefaultCharSetAttribute implementation
8354 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
8355 which allows us to set GlobalNamespace for every resolve.
8356 (Attribute.ResolveArguments): Cut from Resolve.
8357 (Attribute.GetCharSetValue): Returns CharSet named argument.
8358 (Attribute.DefinePInvokeMethod): Gets default charset from
8360 (GlobalAttribute.ResolveAsTypeStep): Override.
8361 (GlobalAttribute.ResolveArguments): Override.
8363 * class.cs (TypeAttr): Is protected.
8365 * codegen.cs (ModuleClass.DefaultCharSet): New member.
8366 (ModuleClass.DefaultCharSetType): New memeber.
8367 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
8369 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
8370 charset from module.
8372 * delegate.cs (TypeAttr): Override.
8373 (Delegate.DefineType): Use this TypeAttr.
8375 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
8376 at very early stage (before types are defined) to resolve model
8377 module attributes. It will probably not work with corlib but it
8380 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
8381 charset from module.
8383 * typemanager.cs (default_charset_type): New type.
8385 2005-04-13 Raja R Harinath <rharinath@novell.com>
8387 * decl.cs (MemberCache.AddMethods): Don't warn if
8388 System.Object.Finalize has buggy MethodAttributes.
8390 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
8393 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8395 * doc.cs : detect ambiguous reference to overloaded members.
8396 Fixed bug #71603. MS 1.1 csc does not detect it.
8398 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8400 * doc.cs : delegates must not be referenced with parameters.
8403 2005-04-12 Miguel de Icaza <miguel@novell.com>
8405 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
8407 2005-04-10 Miguel de Icaza <miguel@novell.com>
8409 * driver.cs (MainDriver): Stop processing if the CLS stage found
8412 (CompilerCallableEntryPoint.InvokeCompiler): Always
8413 reset after execution; Take a TextWriter argument for the
8416 * report.cs: Use the error stream instead of hardcoding stderr.
8418 2005-04-09 Miguel de Icaza <miguel@novell.com>
8420 * class.cs: Reduce code paths to test, too small of an
8421 optimization to make it worth the extra testing. Always perform
8424 2005-04-08 Raja R Harinath <rharinath@novell.com>
8427 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
8428 operators that had errors reported on them.
8430 2005-04-08 Marek Safar <marek.safar@seznam.cz>
8432 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
8434 (Attribute.Resolve): Add named argument type checking.
8436 * class.cs (FixedField.Define): Use IsPrimitiveType
8438 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
8440 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
8441 unsafe parameter types.
8443 * statement.cs (Using.ResolveExpression): Add better error description.
8445 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
8447 2005-04-08 Raja R Harinath <rharinath@novell.com>
8450 * attribute.cs (Attribute.GetAttributeUsage): Resolve
8451 AttributeUsageAttribute in the emitcontext of the attribute class,
8452 not in the emitcontext of the attributable entity it was attached to.
8453 * cs-parser.jay: Use 'current_class', not 'current_container',
8454 when creating a GlobalAttribute.
8456 2005-04-08 Alp Toker <alp@atoker.com>
8458 * pending.cs: The fix to #58413 failed to compile methods implementing
8459 interfaces with/without params modifiers and vice versa, even though
8460 params modifiers aren't part of the signature. Make the modifier check
8461 less strict as in csc.
8463 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
8464 Anoob V E <projectmonokochi@rediffmail.com>
8465 Harilal P R <projectmonokochi@rediffmail.com>
8468 * pending.cs (TypeAndMethods.mods): New. Store the parameter
8469 modifiers of pending methods.
8470 (PendingImplementation.PendingImplementation): Initialize it.
8471 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
8472 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
8473 with ParameterData. Add check for modifiers.
8474 * class.cs (MethodData.Define): Update to changes.
8476 2005-04-07 Raja R Harinath <rharinath@novell.com>
8478 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
8480 2005-04-07 Marek Safar <marek.safar@seznam.cz>
8482 * class.cs (PropertyMethod.Define): Check private accessor in abstract
8485 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
8488 * typemanager.cs: Registered RequiredAttributeAttribute.
8490 2005-04-06 Marek Safar <marek.safar@seznam.cz>
8492 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
8493 Warning CS0169 is back at level 3.
8494 (IMethodData.SetMemberIsUsed): New method.
8496 * decl.cs (IsUsed): New value; moved from FieldBase.Status
8497 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
8499 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
8501 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
8503 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
8506 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
8509 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
8510 to avoid the problems with nested types.
8512 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
8513 Anoob V.E <projectmonokochi@rediffmail.com>
8514 Harilal P.R <projectmonokochi@rediffmail.com>
8515 Raja R Harinath <rharinath@novell.com>
8518 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
8520 * typemanager (GetConstructor): Make public.
8522 2005-04-05 John Luke <john.luke@gmail.com>
8523 Raja R Harinath <rharinath@novell.com>
8526 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
8527 struct too. Return false quicker in a few cases.
8528 (VerifyUnManaged): Use it.
8530 2005-04-05 Raja R Harinath <rharinath@novell.com>
8533 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
8534 not 'unreachable_seen'.
8536 2005-04-04 Marek Safar <marek.safar@seznam.cz>
8538 * attribute.cs (Attribute.GetValue): Removed unused.
8540 * codegen.cs (CodeGen.TrimExt): Removed unused.
8542 * cs-parser.jay (output): Removed unused.
8544 * cs-tokenizer.cs (hex_digits): Removed unused.
8546 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
8548 * expression.cs (Indirection.LoadExprValue): Removed unused.
8549 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
8551 * iterators.cs (Iterator.param_types): Removed unused.
8553 * statement.cs (Goto.block): Removed unused.
8554 (ToplevelBlock.did): Removed unused.
8555 (Switch.ResolveConstantSwitch): Removed unused.
8557 2005-04-01 Ben Maurer <bmaurer@ximian.com>
8559 * rootcontext.cs: Allow mcs to bootstrap with the compilation
8562 2005-04-01 Raja R Harinath <rharinath@novell.com>
8564 Fix #74232 and cs0208-3.cs.
8565 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
8566 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
8567 unmanaged type. Don't use FieldBuilders when 't' is a
8568 TypeBuilder. Use ModFlags and MemberType fields.
8569 * class.cs (MemberBase.member_type): Rename from MemberType.
8570 (MemberBase.MemberType): New property. Determines member_type on
8572 (MemberBase.DoDefine): Don't initialize MemberType here.
8573 (FieldMember.Define): Likewise.
8575 2005-04-01 Marek Safar <marek.safar@seznam.cz>
8578 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
8579 Attributes are emitted there.
8581 2005-04-01 Raja R Harinath <rharinath@novell.com>
8583 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
8584 keyword in 'partial enum' too.
8585 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
8587 Report from Kamil Skalski <nazgul@omega.pl>.
8590 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
8591 have partial containers too.
8593 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
8594 in block' checks to Block.CheckInvariantMeaningInBlock.
8595 * statement.cs (Block.GetKnownVariableInfo): Make private.
8596 (Block.IsVariableUsedInChildBlock): Remove.
8597 (Block.IsVariableUsedInBlock): Likewise.
8598 (Block.CheckInvariantMeaningInBlock): New. Show location of
8599 conflicting declaration.
8600 (Block.AddVariable): Make error messages less long-winded and more
8601 specific. Show location of conflicting declaration.
8602 * parameter.cs (Parameters.Location): New readonly property.
8604 2005-03-31 Raja R Harinath <rharinath@novell.com>
8606 Clean up semantics of invoking ResolveMemberAccess.
8607 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
8608 can have an instance, ensure that we pass in a non-TypeExpression
8609 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
8610 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
8611 argument. Update to changes and simplify.
8612 (FieldExpr.Emitinstance): Remove CS0120 check.
8613 (PropertyExpr.EmitInstance): Likewise.
8614 * expression.cs (Argument.Resolve): Likewise.
8615 (Invocation.DoResolve): Update to changes in semantics of
8618 2005-03-31 Marek Safar <marek.safar@seznam.cz>
8621 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
8624 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
8626 2005-03-31 Raja R Harinath <rharinath@novell.com>
8628 Fix difference in behaviour with commandline invocation.
8629 * driver.cs (Driver.Reset): New.
8630 (CompilerCallableEntryPoint): Call it.
8632 * statement.cs (If.Resolve): Avoid spurious "uninitialized
8633 variable" warnings if the boolean expression failed to resolve.
8635 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
8637 * attribute.cs: Fix the union of several permissions when some of them
8638 are unrestricted (so the result isn't an unrestricted permission set).
8641 2005-03-30 Raja R Harinath <rharinath@novell.com>
8643 * ecore.cs (MemberExpr): New class. Convert from interface
8645 (MemberExpr.ResolveMemberAccess): Refactor and move here from
8646 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
8648 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
8649 (MethodGroupExpr.IsExplicitImpl): Remove.
8650 (Expression.GetFieldFromEvent): Remove.
8651 (SimpleName.MemberStaticCheck): Remove.
8652 (SimpleName.DoSimpleNameResolve): Update to changes.
8653 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
8654 (MemberAccess.IdenticalNameAndTypeName): Remove.
8655 (MemberAccess.error176): Move to MemberExpr.
8656 (MemberAccess.DoResolve): Update to changes.
8657 (BaseAccess.DoResolve): Likewise.
8659 2005-03-30 Marek Safar <marek.safar@seznam.cz>
8661 C# 2.0 Conditional attribute class implementation
8663 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
8664 Analyzes class whether it has attribute which has ConditionalAttribute
8665 and its condition is not defined.
8667 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
8668 (Class.IsExcluded): New method. Search for at least one defined
8669 condition in ConditionalAttribute of attribute class.
8671 2005-03-30 Raja R Harinath <rharinath@novell.com>
8673 * ecore.cs (PropertyExpr): Derive from Expression, not
8674 ExpressionStatement.
8675 (PropertyExpr.EmitStatement): Remove.
8677 2005-03-29 Raja R Harinath <rharinath@novell.com>
8680 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
8681 internal field "value__" of an enum be private. The examples for
8682 "value__" that I found on MSDN all used FieldAttributes.Private.
8684 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
8685 Don't mention IL method attribute names.
8687 Fix #47991. Remove a TODO.
8688 * statement.cs (Block.Toplevel): Make into a field.
8689 (Block.Parameters): Move into ToplevelBlock.
8690 (Block.known_variables): Rename from child_variable_names.
8691 (Block.Block): Remove variants that take Parameters. Initialize
8692 'Toplevel' with the immediately surrounding toplevel block.
8693 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
8694 LocalInfo parameter.
8695 (Block.GetKnownVariableInfo): New.
8696 (Block.IsVariableNameUsedInChildBlock): Update.
8697 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
8698 the block, even though it may not be in scope.
8699 (Block.AddVariable): Remove Parameters parameter. Use
8700 Toplevel.Parameters instead.
8701 (Block.AddConstant): Remove Parameters parameter.
8702 (Block.GetParameterReference): Update to use Toplevel.Parameters.
8703 (Block.IsParamaterReference): Likewise.
8704 (Block.IsLocalParameter): Likewise. Simplify a lot.
8705 (ToplevelBlock.Parameters): New. Moved from Block.
8706 (ToplevelBlock.ToplevelBlock): Update to changes. Always
8707 initialize Parameters to a non-null value.
8708 * cs-parser.jay: Update to changes.
8709 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
8710 simple names that mean different things in the same block. Use
8711 Block.IsVariableNameUsedInBlock.
8713 2005-03-28 Raja R Harinath <rharinath@novell.com>
8715 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
8716 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
8717 GetTypeHandle. It is possible for a reflected type to derive from
8718 a TypeBuilder (e.g., int[] derives from the TypeBuilder
8719 System.Array during mscorlib compilation).
8720 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
8721 contain a method_hash, don't create one either. Don't create a
8722 deep copy of the base cache's method_hash.
8723 (MemberCache.SetupCache): Rename back from DeepCopy.
8724 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
8725 already initialized. If we see an override function, add its
8726 underlying base virtual function to the member_hash too.
8728 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
8730 2005-03-26 Raja R Harinath <harinath@acm.org>
8733 * assign.cs (Assign.DoResolve): When the RHS of an assignment
8734 fails to resolve, ensure that the LHS is still resolved as an
8737 2005-03-25 Raja R Harinath <harinath@acm.org>
8739 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
8741 (Enum.current_ec): Remove.
8742 (Enum.LookupEnumValue): Remove EmitContext argument.
8743 Just uses the one created during DefineType.
8744 (Enum.FindMembers): Update.
8745 * expression.cs (MemberAccess.DoResolve): Update.
8747 2005-03-22 Marek Safar <marek.safar@seznam.cz>
8749 * assign.cs (Assign.DoResolve): Check for CS1717 when
8750 source and target are same (uses Equals).
8752 * expression.cs (LocalVariableReference, ParameterReference,
8753 This): Implemented Equals, GetHashCode.
8755 * statement.cs (Block.GetParameterReference): Removed useless
8758 2005-03-22 Raja R Harinath <rharinath@novell.com>
8761 * statement.cs (Block.AddVariable): Ensure that we skip implicit
8762 blocks before deciding whether the error is cs0136 or cs0128.
8764 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
8765 (using_alias_directive, using_namespace_directive): Pass
8766 MemberName, not an expression to Namespace.UsingAlias and
8768 (MakeName): Use the MemberName of the namespace.
8769 * namespace.cs (Namespace.MemberName): New.
8770 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
8771 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
8773 * decl.cs (MemberName.Name): Make readonly.
8774 (MemberName.FromDotted): New "constructor".
8775 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
8776 (MemberCore.Name): Compute from MemberName on demand.
8777 (MemberCore.SetMemberName): Provide a way to change the
8779 (MemberCore.AddToContainer): Don't take a fullname parameter.
8780 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
8781 fully qualified name of the container to the member name.
8782 (TypeContainer.AddToTypeContainer): Use a fully qualified name
8783 only if the type is a member of the root container.
8784 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
8785 MemberName.Left rather than searching for an embedded ".".
8786 (PartialContainer.CreatePart): Update to changes in RootContext.
8787 (MemberBase.ShortName): Turn into a property. Use
8788 MemberCore.SetMemberName.
8789 (MemberBase.ExplicitInterfaceName): Remove.
8790 (MemberBase.UpdateMemberName): Remove.
8791 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
8792 (PropertyBase.SetMemberName): New override.
8793 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
8794 (Tree.GetDecl): New.
8795 (Tree.AllDecls): Rename from Decls.
8796 * attribute.cs, enum.cs, report.cs: Update to changes.
8797 * driver.cs (MainDriver): Use MemberName.FromDotted on
8798 RootContext.MainClass.
8800 2005-03-21 Marek Safar <marek.safar@seznam.cz>
8802 * class.cs (FixedField.Define): Check for CS1664 and more sanity
8805 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
8807 2005-03-18 Marek Safar <marek.safar@seznam.cz>
8809 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
8810 property accessor modifiers.
8812 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
8813 fixed buffer attribute (CS1716).
8814 (PropertyMethod.HasCustomAccessModifier): When property accessor
8815 has custom modifier.
8817 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
8819 (PropertyExpr.DoResolveLValue): Add CS0272.
8821 2005-03-17 Miguel de Icaza <miguel@novell.com>
8823 * convert.cs: When converting to a pointer, use the proper Conv.U
8824 or Conv.I depending on the source data type.
8826 * cs-tokenizer.cs: Make the size for large decimal constants,
8829 2005-03-17 Martin Baulig <martin@ximian.com>
8831 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
8832 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
8834 2005-03-17 Martin Baulig <martin@ximian.com>
8836 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
8837 to bool so we can return an error condition.
8838 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
8841 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
8843 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
8846 2005-03-16 Raja R Harinath <rharinath@novell.com>
8848 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
8849 Refactor to avoid traversing the list of assemblies, and to avoid
8850 string concatenation.
8851 * typemanager.cs (guid_attr_type): Remove.
8852 (negative_hits, pointers, references): Remove hashes.
8854 (GetConstructedType): New. Uses type_hash to handle constructed
8855 types (arrays, references, pointers).
8856 (GetReferenceType, GetPointerType): Use it.
8857 (GetNestedType): New. Uses type_hash to handle nested types of
8859 (LookupType, LookupTypeDirect): Remove.
8860 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
8861 'types' hash and LookupTypeReflection directly.
8862 (params_string, params_object): Use GetConstructedType.
8863 * namespace.cs (Namespace.cached_types): New. Cache of reflected
8865 (Namespace.Lookup): Use cached_types.
8866 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
8867 provided by old TypeManager.LookupType.
8868 * rootcontext.cs (MakeFQN): Remove.
8869 * decl.cs (DeclSpace.MakeFQN): Likewise.
8870 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
8871 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
8872 TypeManager.GetConstructedType.
8873 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
8875 2005-03-15 Marek Safar <marek.safar@seznam.cz>
8877 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
8880 * cs-parser.jay: Reports CS1527 for any namespace element.
8882 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
8885 * expression.cs (ParameterReference.IsAssigned): Changed error to
8887 (Error_WrongNumArguments): Moved CS0245 detection here.
8889 * statement.cs (Return.Resolve): Add CS1622 report.
8891 2005-03-11 Marek Safar <marek.safar@seznam.cz>
8893 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
8895 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
8897 * attribute.cs expression.cs: Get rid of some allocations.
8899 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
8901 * doc.cs : just eliminate the latest change.
8903 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8905 * doc.cs : commented out the latest change. It breaks xml-030.cs
8907 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8909 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
8910 fail. So invoke CreateType() in FindDocumentedType().
8912 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8914 * cs-tokenizer.cs : added IsKeyword().
8915 * doc.cs : Detect keyword incorrectly used as identifier.
8916 Allow identifiers prefixed by @.
8918 2005-03-10 Marek Safar <marek.safar@seznam.cz>
8920 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
8921 It caused exception in namespace resolving (again!).
8923 * class.cs (Class.ctor): Removed exit.
8924 (PropertyMethod.ctor): ditto.
8926 * codegen.cs (Codegen.Reset): Reset static data.
8927 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
8929 * cs-tokenizer.cs (Cleanup): Removed.
8931 * driver.cs (GetSystemDir): Rewrote to one line command.
8932 It caused problem with unloaded dynamic modules.
8933 (UnixParseOption): Removed Exit.
8934 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
8935 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
8936 Now can be mcs used as library.
8938 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
8941 * location.cs (Reset): Reset static data.
8943 * namespace.cs (Reset): Reset static data.
8945 * report.cs (Report.Reset): Reset static data.
8947 * rootcontext.cs (RootContext.Reset): Reset static data.
8949 * tree.cs (RootTypes.ctor): Use Location.Null
8951 * typemanager.cs (TypeManager.Reset): Reset static data.
8952 (CoreLookupType): Removed Exit.
8953 (TypeHandle.Reset): Reset static data.
8955 2005-03-10 Raja R Harinath <rharinath@novell.com>
8958 * typemanager.cs (ComputeNamespaces): Import namespaces from
8959 referenced modules too.
8961 2005-03-09 Raja R Harinath <rharinath@novell.com>
8963 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
8966 2005-03-09 Raja R Harinath <rharinath@novell.com>
8968 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
8969 enclosing DeclSpace. This ensures that a name-lookup populates
8970 more caches and there are fewer 'TypeExpression's. Carve out
8971 nested type lookup into ...
8972 (LookupNestedTypeInHierarchy): ... this.
8974 2005-03-09 Raja R Harinath <rharinath@novell.com>
8976 Clean up a few partial-class semantics.
8977 Fixes test-357.cs and cs1618-2.cs.
8978 * cs-parser.jay (struct_declaration): Use 'current_class' as
8979 parent of newly-created struct. Remove call to Register ().
8980 Use 'pop_current_class' to complete handing the current struct.
8981 (interface_declaration): Likewise.
8982 (class_declaration): Likewise.
8983 (enum_declaration): Use 'current_class' as parent of newly created
8985 (delegate_declaration): Likewise.
8986 (pop_current_class): New function. This is used to handle closing
8987 up the 'current_class' and 'current_container', and pointing them
8988 to the enclosing class/container.
8989 (CSharpParser): Initialize 'current_class' too.
8990 * decl.cs (MemberCore): Add check for invariant: a partial
8991 container is not a parsed entity, and thus does not enclose any
8993 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
8994 (DeclSpace.BaseTypeExpr): Use it.
8995 (DeclSpace.LookupType): Add check for invariant.
8996 * class.cs (TypeContainer): Add check for invariant: a nested
8997 class should have the same NamespaceEntry as its enclosing class.
8998 (TypeContainer.EmitFieldInitializers): Make virtual.
8999 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
9001 (TypeContainer.Register): Remove.
9002 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
9003 null. Use TypeResolveEmitContext for resolving base types and
9004 interfaces. Move initialization of Parts.TypeBuilder here from
9006 (TypeContainer.DefineNestedTypes): ... here.
9007 (PartialContainer): Take a Namespace not a NamespaceEntry.
9008 (PartialContainer.Create): Don't use Register. Call the
9009 appropriate Add... function directly.
9010 (ClassPart): Take both the PartialContainer and the enclosing
9011 class as constructor arguments.
9012 (ClassPart.EmitFieldInitializers): Override.
9013 (ClassPart.PartFindNestedTypes): Remove.
9014 (FieldBase.GetInitializerExpression): Resolve the initializer
9015 expression in the emit context of the enclosing class.
9016 * tree.cs (RootTypes): Remove Register ().
9018 2005-03-08 Marek Safar <marek.safar@seznam.cz>
9020 * cs-parser.jay: Removed CS0134.
9022 * driver.cs: Removed CS1901.
9024 * expression.cs (SizeOf.DoResolve): Don't report CS0233
9025 for predefined types.
9027 2005-03-07 Duncan Mak <duncan@novell.com>
9029 * codegen.cs (Save): Catch UnauthorizedAccessException as
9030 well. Fixes bug #73454.
9032 2005-03-07 Marek Safar <marek.safar@seznam.cz>
9034 * cs-tokenizer.cs (xtoken): Add CS1035.
9036 * class.cs (MethodData.Define): Add CS0683.
9037 (FieldMember.ctor): Add CS0681.
9039 2005-03-07 Raja R Harinath <rharinath@novell.com>
9041 * ecore.cs (SimpleName.DoResolve): Rename from
9042 SimpleName.DoResolveAllowStatic.
9043 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
9044 Pass 'intermediate' flag to MemberStaticCheck.
9045 (SimpleName.MemberStaticCheck): Skip "static check" only in case
9046 of "intermediate" lookups via MemberAccess.
9047 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
9048 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
9050 2005-03-07 Raja R Harinath <rharinath@novell.com>
9053 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
9054 slipped in because of variable names that are identical to a
9055 builtin type's BCL equivalent ('string String;', 'int Int32;').
9056 (PropertyExpr.EmitInstance): Likewise.
9058 2005-03-04 Marek Safar <marek.safar@seznam.cz>
9060 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
9062 * report.cs (warning_ignore_table): Made public.
9064 2005-03-04 Raja R Harinath <rharinath@novell.com>
9067 * class.cs (MethodData.Emit): Pass 'container' to
9068 container.GetObsoleteAttribute instead of 'container.Parent'.
9070 2005-03-03 Marek Safar <marek.safar@seznam.cz>
9072 * cs-parser.jay: Add 1534 error test.
9074 * iterators.cs (Yield.CheckContext): Add error 1629.
9075 (Iterator.ctor): Save unsafe modifier.
9076 (MoveNextMethod.DoEmit): Restore unsafe context.
9078 * namespace.cs (UsingAlias): Better error message.
9080 2005-03-03 Dan Winship <danw@novell.com>
9082 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
9083 the warning message [#73219]
9085 2005-03-03 Raja R Harinath <rharinath@novell.com>
9087 Fix compile with MCS 1.0.0.0.
9088 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
9089 w_restore to not depend on string constant folding.
9091 2005-03-03 Raja R Harinath <rharinath@novell.com>
9093 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
9094 CS0246 check to users who passed 'silent = false'.
9095 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
9097 (SimpleName.SimpleNameResolve): Update.
9098 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
9099 (MemberAccess.IdenticalNameAndTypeName): Update.
9100 * doc.cs (FindDocumentedTypeNonArray): Update.
9102 2005-03-03 Raja R Harinath <rharinath@novell.com>
9104 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
9105 * parameters.cs (ComputeAndDefineParameters): Remove.
9106 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
9107 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
9108 Use GetParameterInfo.
9110 2005-03-02 Marek Safar <marek.safar@seznam.cz>
9112 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
9114 2005-03-02 Raja R Harinath <rharinath@novell.com>
9116 Unify DeclSpace.LookupType and DeclSpace.FindType.
9117 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
9118 is in charge of defining nested types on demand.
9119 (DeclSpace.LookupType): Use it when the current_type is a
9120 TypeBuilder. Use LookupTypeDirect for reflected types.
9121 (DeclSpace.FindType): Remove.
9122 (DeclSpace.LookupInterfaceOrClass): Likewise.
9123 (DeclSpace.DefineTypeAndParents): Likewise.
9124 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
9125 DeclSpace.LookupType.
9126 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
9127 * typemanager.cs (LookupType): Simplify.
9128 (AddUserType): Remove type from negative_hits.
9129 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
9130 * class.cs (TypeContainer.FindMembers): Move handling of nested
9132 (TypeContainer.FindMembers_NestedTypes): ... here.
9133 (TypeContainer.FindNestedType): Implement override.
9134 (ClassPart.FindNestedType): Delegate to PartialContainer.
9135 (ClassPart.PartFindNestedType): Looks up the nested types of the
9138 2005-03-02 Martin Baulig <martin@ximian.com>
9140 * class.cs (TypeContainer.DoDefineMembers): We also need a default
9141 static constructor in static classes.
9143 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
9145 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
9146 sizeParamIndex is not specified.
9148 2005-03-01 Marek Safar <marek.safar@seznam.cz>
9151 * report.cs (WarningMessage.IsEnabled): Missing null check.
9153 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9155 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
9156 in the fields and not in the properties.
9158 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
9160 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
9163 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9165 * attribute.cs: Small refactoring (improved robustness).
9166 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
9167 (ValidateGuid): Removed.
9168 (Resolve): Removed referenced to above mentioned.
9169 (GetAttributeUsage): Made private and changed to work without
9171 (GetIndexerAttributeValue): Don't crash.
9172 (GetConditionalAttributeValue): Ditto.
9173 (GetClsCompliantAttributeValue): Ditto.
9174 (ExtractSecurityPermissionSet): All attributes exceptions are
9176 (GetPropertyValue): New helper.
9177 (GetMethodImplOptions): New method.
9178 (DefinePInvokeMethod): Reuse common code. Implemented handling of
9179 some missing properties.
9181 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
9182 (Method.ApplyAttributeBuilder): Updated.
9184 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
9187 2005-02-28 Raja R Harinath <rharinath@novell.com>
9190 * report.cs (Report.SymbolRelatedToPreviousError): Handle
9191 non-simple types (array, pointer, reference).
9193 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9195 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
9197 * class.cs (MethodCore.IsDuplicateImplementation): Special error
9199 (Method.CheckBase): Catch wrong destructor here.
9200 (MethodData.Define): Add errors 550, 668.
9202 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
9204 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
9206 * pending.cs (VerifyPendingMethods): Add error 551.
9208 * typemanager.cs (CSharpName): Next error report helper.
9210 2005-02-25 Marek Safar <marek.safar@seznam.cz>
9212 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
9213 attributes. Removed useless attribute double check.
9214 It saves almost 2MBs for corlib.
9216 2005-02-25 Raja R Harinath <rharinath@novell.com>
9219 * statement.cs (ExpressionStatement.Resolve): Make robust to being
9220 called twice in case of error.
9222 2005-02-23 Chris Toshok <toshok@ximian.com>
9224 Fix compiler portions of #72827.
9225 * statement.cs (Block.Emit): call Begin/EndScope on the
9226 EmitContext instead of the ILGenerator.
9228 * codegen.cs (EmitContext.BeginScope): new method, call
9229 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
9231 (EmitContext.BeginScope): same, but EndScope and CloseScope
9233 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
9234 offset and call the superclass's OpenScope(int) with it.
9235 (SymbolWriter.CloseScope): get the current il
9236 offset and call superclass's CloseScope(int) with it.
9238 2005-02-23 Marek Safar <marek.safar@seznam.cz>
9240 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
9241 CS1677 for out and ref as well.
9243 * class.cs (Method.Define): Add error CS1599 detection.
9245 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
9247 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
9249 * delegate.cs (Delegate.Define): Add error CS1599 detection.
9251 * support.cs.cs (ModifierDesc): New helper method.
9253 2005-02-23 Raja R Harinath <rharinath@novell.com>
9254 Abin Thomas <projectmonokochi@rediffmail.com>
9255 Anoob V E <projectmonokochi@rediffmail.com>
9256 Harilal P R <projectmonokochi@rediffmail.com>
9259 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
9260 MemberLookup (used for error reporting) actually returns a result.
9261 Fix error report number (122, not 112).
9263 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
9264 Anoob V E <projectmonokochi@rediffmail.com>
9265 Harilal P R <projectmonokochi@rediffmail.com>
9268 * pending.cs (PendingImplementation.GetAbstractMethods):
9269 Find NonPublic members too.
9271 2005-02-22 Marek Safar <marek.safar@seznam.cz>
9273 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
9276 * class.cs (MethodCore.CheckMethodAgainstBase):
9277 Add error 239 report.
9279 2005-02-21 Raja R Harinath <rharinath@novell.com>
9282 * expression.cs (Invocation.IsApplicable): Make public.
9283 (Invocation.IsParamsMethodApplicable): Likewise.
9284 * delegate.cs (Delegate.VerifyApplicability): Don't use
9285 Invocation.VerifyArgumentCompat for parameter applicability
9286 testing. Use Invocation.IsApplicable and
9287 Invocation.IsParamsMethodApplicable.
9289 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9291 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
9293 * class.cs (Operator.Define): Add error 217 report.
9295 2005-02-21 Raja R Harinath <rharinath@novell.com>
9297 * namespace.cs (UsingEntry.Resolve): Undo change below.
9299 2005-02-21 Raja R Harinath <rharinath@novell.com>
9302 * ecore.cs (Expression.MemberLookupFailed): Add argument to
9303 disable the error message when the extended MemberLookup also
9305 (Expression.MemberLookupFinal): Update.
9306 (SimpleName.DoSimpleNameResolve): Update.
9307 * expression.cs (MemberAccess.ResolveNamespaceOrType):
9308 Don't use MemberLookupFinal.
9309 (New.DoResolve): Update.
9310 (BaseAccess.CommonResolve): Update.
9312 2005-02-21 Raja R Harinath <rharinath@novell.com>
9315 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
9316 occured previously, don't resolve again.
9318 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9321 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
9322 argument. Call ResolveAttributeUsage for unresolved.
9323 when types doesn't match ctor arguments.
9325 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
9326 for nested attribute classes.
9327 (Class.attribute_usage): Removed.
9328 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
9329 for attribute class.
9331 * ecore.cs (IsAttribute): Removed.
9333 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
9335 * rootcontext.cs (RegisterAttribute): Removed, attributes are
9337 (attribute_types): Removed.
9338 (EmitCode): Global attributes are emited as the latest.
9340 2005-02-18 Marek Safar <marek.safar@seznam.cz>
9342 * class.cs (EmitFieldInitializers): Don't emit field initializer
9343 for default values when optimilization is on.
9345 * constant.cs (Constant.IsDefaultValue): New property.
9347 * driver.cs: Add /optimize handling.
9351 * literal.cs: Implement new IsDefaultValue property.
9353 * rootcontext.cs (Optimize): New field, holds /optimize option.
9355 2005-02-18 Raja R Harinath <rharinath@novell.com>
9357 Fix crasher in re-opened #72347.
9358 * namespace.cs (Namespace.Lookup): Return null if
9359 DeclSpace.DefineType returns null.
9362 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
9364 2005-02-18 Raja R Harinath <rharinath@novell.com>
9366 Fix remainder of #63202. Change semantics of DoResolveLValue: it
9367 now returns null if it cannot resolve to an lvalue.
9368 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
9369 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
9370 returned null. Remove check for SimpleName.
9371 (EventExpr.DoResolveLValue): New.
9372 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
9373 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
9375 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
9377 (Unary.ResolveOperator): Move CS0211 check ...
9378 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
9380 (Unary.DoResolveLValue): Simplify.
9381 (AddressOf.DoResolveLValue): New.
9382 (ArrayAccess.DoResolveLValue): New.
9384 2005-02-16 Marek Safar <marek.safar@seznam.cz>
9386 * attribute.cs (Attribute.Resolve): Add arguments casting for
9387 when types doesn't match ctor arguments.
9389 2005-02-16 Raja R Harinath <rharinath@novell.com>
9391 Fix parts of #63202.
9392 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
9393 lookup of operator in base type. Ensure that all checks happen
9394 when the operator resolves to an "op_..." method.
9396 2005-02-15 Raja R Harinath <rharinath@novell.com>
9399 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
9400 'ignore_cs0104' parameter. Pass it to ...
9401 (NamespaceEntry.Lookup): ... this.
9402 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
9403 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9404 (TypeLookupExpression.DoResolveAsTypeStep): Update.
9405 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
9406 Update. Request that cs0104 errors be ignored.
9407 (ComposedCast.ResolveAsTypeStep): Update.
9409 2005-02-14 Raja R Harinath <rharinath@novell.com>
9412 * expression.cs (Invocation.BetterFunction): Remove support for
9413 comparing virtual functions and their overrides.
9414 (Invocation.IsOverride): New.
9415 (Invocation.OverloadResolve): Don't consider 'override' functions
9416 during candidate selection. Store them in a lookaside list.
9417 If the selected method is a 'virtual' function, use the list to
9418 find any overrides that are closer to the LHS type.
9420 2005-02-14 Marek Safar <marek.safar@seznam.cz>
9422 * expression.cs (New.DoResolve): Add complex core type reduction.
9423 (New.Constantify): Converts complex core type syntax like 'new int ()'
9426 2005-02-14 Raja R Harinath <rharinath@novell.com>
9428 * decl.cs (EntryType.EntryType): New constructor to create an
9429 updated copy of a cache entry.
9430 (MemberCache.AddMethods): Use it.
9431 (MemberCache.ClearDeclaredOnly): Remove.
9432 (MemberCache.MemberCache): Update.
9434 2005-02-11 Miguel de Icaza <miguel@novell.com>
9436 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
9437 variable. This one is represents the actual low-level declaration
9438 of the method, as opposed to the semantic level `IsStatic'.
9440 An anonymous method which is hosted into a static method might be
9441 actually an instance method. IsStatic would reflect the
9442 container, while MethodIsStatic represents the actual code
9445 * expression.cs (ParameterReference): Use the new MethodIsStatic
9446 instead of IsStatic.
9448 * anonymous.cs (AnonymousMethod.Compatible): Pass the
9449 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
9450 set on the current EmitContext.
9452 * expression.cs (Cast): Overload DoResolveLValue so we can pass
9453 resolve our casted expression as an LValue. This triggers the
9454 proper LValue processing that is later required by Assign.
9458 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
9460 2005-02-11 Marek Safar <marek.safar@seznam.cz>
9462 C# 2.0 Fixed buffer implementation
9464 * anonymous.cs: Update after RegisterHelperClass renaming.
9466 * attribute.cs (AttributeTester.fixed_buffer_cache):
9467 Cache of external fixed buffers.
9468 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
9469 implementation if field is fixed buffer else null.
9472 (TypeContainer.AddField): Accept FieldMember instead of Field.
9473 (FieldBase.IsFieldClsCompliant): Extracted code from
9474 VerifyClsCompliance descendant customization.
9475 (FixedField): New class handles fixed buffer fields.
9476 (FixedFieldExternal): Keeps information about imported fixed
9478 (IFixedField): Make access to internal or external fixed buffer
9481 * cs-parser.jay: Add fixed buffer parsing.
9483 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
9486 * expression.cs (Indirection): Extended implementation to accept
9488 (PointerArithmetic.Emit): Get element from fixed buffer as well.
9489 (ElementAccess.MakePointerAccess): Get type as parameter.
9490 (DoResolve): Add fixed buffer field expression conversion.
9491 (DoResolveLValue): Ditto.
9492 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
9493 (ArrayPtr): Derives from FixedBufferPtr.
9494 (ArrayPtr.Emit): Add extra emit for array elements.
9496 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
9498 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
9499 for compiler generated types.
9500 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
9502 * statement.cs (Fixed): Refactored to be easier add fixed buffer
9503 and consume less memory.
9504 (Fixed.Resolve): Add fixed buffer case.
9506 * typemanager.cs (compiler_generated_attr_ctor,
9507 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
9508 (HasElementType): Add our own implementation to work on every
9511 2005-02-11 Miguel de Icaza <miguel@novell.com>
9513 * anonymous.cs (CaptureContext): Track whether `this' has been
9516 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
9517 only captured `this' if it was implicitly done (instance
9518 methods/variables were used).
9520 * codegen.cs (EmitContext.CaptureThis): New method to flag that
9521 `this' must be captured.
9523 2005-01-30 Miguel de Icaza <miguel@novell.com>
9525 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
9526 is null it means that there has been no need to capture anything,
9527 so we just create a sibling.
9529 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9531 Just a partial fix. The other half is fairly elusive.
9533 2005-02-10 Raja R Harinath <rharinath@novell.com>
9535 Fix #52586, cs0121-4.cs.
9536 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
9537 and return a hashtable.
9538 (MemberCache.ClearDeclaredOnly): New.
9539 (MemberCache.MemberCache): Update to change. Make a deep copy of
9540 the method_hash of a base type too.
9541 (MemberCache.AddMethods): Adapt to having a deep copy of the base
9542 type methods. Overwrite entries with the same MethodHandle so
9543 that the ReflectedType is correct. The process leaves in base
9544 virtual functions and their overrides as distinct entries.
9545 (CacheEntry): Now a class instead of a struct. It shouldn't alter
9546 matters since it was boxed in a ArrayList before.
9547 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
9549 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
9550 case of a virtual function and its override (choose the overload
9552 (Invocation.OverloadResolve): Avoid 'override' members during
9553 'applicable_type' calculation.
9555 2005-02-09 Raja R Harinath <rharinath@novell.com>
9557 Combine two near-redundant caches.
9558 * typemanager.cs (method_params): Rename from method_internal_params.
9559 (TypeManager.GetParameterData): New. Replace
9560 Invocation.GetParameterData.
9561 (TypeManager.LookupParametersByBuilder): Remove.
9562 * expression.cs (Invocation.method_parameter_cache): Remove.
9563 (Invocation.GetParameterData): Remove.
9565 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
9568 2005-02-08 Raja R Harinath <rharinath@novell.com>
9571 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
9572 TypeManager.multicast_delegate_type is null, resolve it by looking
9573 up "System.MulticastDelegate".
9574 * rootcontext.cs (RootContext.ResolveCore): Simplify.
9576 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
9577 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
9578 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
9581 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
9582 (LabeledStatement.AddReference): New. Set 'referenced'.
9583 (Goto.Resolve): Use it.
9585 2005-02-05 John Luke <john.luke@gmail.com>
9587 * driver.cs: remove duplicate -doc line in Usage ()
9589 2005-02-04 Raja R Harinath <rharinath@novell.com>
9591 * location.cs (Location.AddFile): Fix CS2002 error report.
9593 2005-02-02 Martin Baulig <martin@ximian.com>
9595 * delegate.cs (Delegate.DefineType): Report an internal error if
9596 TypeManager.multicast_delegate_type is null. See bug #72015 for
9599 2005-02-02 Raja R Harinath <rharinath@novell.com>
9601 Fix a crasher in a variant of #31984.
9602 * const.cs (Constant.CheckBase): New override that defers the
9603 new-or-override check in case the base type hasn't been populated
9605 (Constant.Define): Ensure the new-or-override check is performed.
9607 2005-02-01 Duncan Mak <duncan@ximian.com>
9609 * const.cs (LookupConstantValue): Check that `ce' is not null
9610 before calling GetValue ().
9612 2005-02-01 Raja R Harinath <rharinath@novell.com>
9614 Fix test-334.cs (#69519).
9615 * cs-parser.jay (using_alias_directive): Pass in an expression to
9616 NamespaceEntry.UsingAlias.
9617 (using_namespace_directive): Pass in an expression to
9618 NamespaceEntry.Using.
9619 (namespace_name): Don't flatten to a string.
9620 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
9621 (NamespaceEntry.AliasEntry.Resolve): Lookup using
9623 (NamespaceEntry.UsingEntry): Likewise.
9624 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
9626 (NamespaceEntry.LookupForUsing): Remove.
9627 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
9629 (NamespaceEntry.Lookup): Remove support for dotted names.
9631 2005-02-01 Raja R Harinath <rharinath@novell.com>
9633 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
9635 (NamespaceEntry.ImplicitParent): Compute on demand.
9636 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
9637 parallels the current.
9638 (NamespaceEntry.LookupForUsing): Use it.
9639 (NamespaceEntry.Lookup): If the current namespace-entry is
9640 implicit, don't search aliases and using tables.
9642 2005-02-01 Raja R Harinath <rharinath@novell.com>
9645 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
9647 (TypeContainer.BaseCache): Compute on demand.
9648 (TypeContainer.FindMembers): Define constants and types if they're
9649 not already created.
9650 (FieldMember.Define): Move resetting of ec.InUnsafe before error
9652 * const.cs (Constant.Define): Make idempotent.
9654 2005-01-29 Miguel de Icaza <miguel@novell.com>
9656 * pending.cs: Produce better code (no nops produced by using Ldarg
9659 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
9660 i - 1' it should be arg + 1.
9664 2005-01-28 Raja R Harinath <rharinath@novell.com>
9666 * attribute.cs (Attribute.CheckAttributeType): Make private
9668 (Attribute.ResolveType): Make virtual.
9669 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
9670 handling of RootContext.Tree.Types.
9672 2005-01-27 Raja R Harinath <rharinath@novell.com>
9674 Update attribute-handling to use the SimpleName/MemberAccess
9676 * cs-parser.jay (attribute): Pass in an expression to the
9677 constructors of Attribute and GlobalAttribute.
9678 * attribute.cs (Attribute): Take an expression for the name.
9679 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
9680 passed in attribute name expression.
9681 (Attribute.CheckAttributeType): Use it.
9682 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
9683 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
9684 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
9685 argument to prevent error messages if the lookup fails.
9687 2005-01-27 Marek Safar <marek.safar@seznam.cz>
9689 * expression.cs (Indirection): Implemented IVariable interface
9690 to support indirection in AddressOf operator.
9691 (PointerArithmetic.Emit): Add optimalization for case where
9692 result can be precomputed.
9694 2005-01-26 Martin Baulig <martin@ximian.com>
9696 * class.cs (TypeContainer.AttributeTargets): Return the correct
9697 AttributeTargets depending on our `Kind' instead of throwing an
9698 exception; fixes #71632.
9700 2005-01-26 Marek Safar <marek.safar@seznam.cz>
9703 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
9706 2005-01-25 Raja R Harinath <rharinath@novell.com>
9709 * expression.cs (MemberAccess.DoResolve): Don't complain with
9710 cs0572 when the LHS of a member access has identical name and type
9713 2005-01-25 Marek Safar <marek.safar@seznam.cz>
9716 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
9718 Create custom PermissionSet only for PermissionSetAttribute.
9720 2005-01-24 Marek Safar <marek.safar@seznam.cz>
9723 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
9724 delegates in static class.
9726 2005-01-24 Martin Baulig <martin@ximian.com>
9728 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9729 merging an implicit block, just use its reachability.
9731 * statement.cs (Block.Resolve): Make the unreachable code check
9732 work wrt. implicit blocks; see test-337 from #63842.
9734 2005-01-21 Alp Toker <alp@atoker.com>
9736 * cs-parser.jay: destructor_declaration's container is PartialContainer
9737 not Class when partial types are used, so use Kind prop instead of
9740 2005-01-22 Miguel de Icaza <miguel@ximian.com>
9742 * cs-parser.jay: Improve error reporting when an interface
9745 2005-01-20 Dick Porter <dick@ximian.com>
9747 * support.cs: SeekableStreamReader fix from Sandor Dobos
9748 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
9749 chars are read. Fixes bug 70369.
9751 2005-01-20 Raja R Harinath <rharinath@novell.com>
9753 * cs-parser.jay (catch_clause): Simplify current_block handling
9756 2005-01-17 Miguel de Icaza <miguel@ximian.com>
9758 * convert.cs (ImplicitStandardConversionExists): Synchronize the
9759 code with ImplicitStandardConversion to handle the implicit
9760 conversion of method groups into valid delegate invocations.
9762 The problem is that in parameter handling we were using this code
9763 path. Fixes bug #64698
9765 2005-01-19 Raja R Harinath <rharinath@novell.com>
9767 * cs-parser.jay: Fix several infelicities.
9768 - Avoid assigning to the parser value stack. Code like
9769 '$3 = null' is unclean. Synthesize a value for the code block
9771 - Avoid using oob_stack for storing location information. Use ...
9772 (_mark_): ... this. New (empty) rule. Saves the current location
9774 (foreach_statement): Avoid using oob_stack for current_block
9775 handling. Use technique used in for_statement and
9776 using_statement. Synthesize a value for the code block to store
9777 additional intermediate information.
9779 2005-01-13 Miguel de Icaza <miguel@ximian.com>
9781 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
9782 of a different type is only allowed to private fields of a
9783 containing type, not on fields of a base class.
9785 See test-174.cs and error cs0122-9.cs
9787 2005-01-13 Raja R Harinath <rharinath@novell.com>
9789 Fix test-335.cs (bug #58126).
9790 * cs-parser.jay (argument): Split out non-expression parts of the
9791 rule into 'non_simple_argument'.
9792 (invocation_expression): Support parenthesized invocations with
9793 multiple arguments, and with single non-simple arguments.
9795 2005-01-13 Raja R Harinath <rharinath@novell.com>
9797 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
9800 2005-01-12 Raja R Harinath <rharinath@novell.com>
9802 Fix cs0038-1.cs, cs1640-6.cs.
9803 * ecore.cs (Expression.Resolve): Remove special-case for
9804 SimpleName in error-handling.
9805 (Expression.almostMatchedMembers): Relax access permission to
9807 (Expression.MemberLookupFailed): Handle duplicates in
9808 almostMatchedMembers list.
9809 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
9810 * expression.cs (New.DoResolve): Report CS1540 for more cases.
9811 * typemanager.cs (GetFullNameSignature): Use the MethodBase
9812 overload if the passed in MemberInfo is a MethodBase.
9814 2005-01-12 Marek Safar <marek.safar@seznam.cz>
9817 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
9818 for non-CAS & merge permission sets properly.
9820 2005-01-11 Raja R Harinath <rharinath@novell.com>
9822 Improve standard-compliance of simple name and member access
9823 resolution. Fixes bugs #52697, #57200, #67520, #69519.
9824 * ecore.cs (FullNamedExpression): New abstract base class
9825 for Namespaces and TypeExpressions.
9826 (ResolveFlags.SimpleName): Remove.
9827 (SimpleName): Remove support for dotted names.
9828 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
9829 DeclSpace.FindType and DeclSpace.LookupType.
9830 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
9831 (Expression.ExprClassName): Make member function.
9832 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
9833 a namespace. Remove creation of dotted "SimpleName"s.
9834 (MemberAccess.DoResolve): Likewise.
9835 * decl.cs (DeclSpace.Cache): Make private.
9836 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
9837 (DeclSpace.FindType): Update.
9838 (DeclSpace.LookupType): Move here from RootContext. Return a
9839 FullNamedExpression.
9840 * namespace.cs (Namespace): Derive from FullNamedExpression
9841 so that it can be part of expression resolution.
9842 (Namespace.Lookup): Return an FullNamedExpression.
9843 (NamespaceEntry.LookupAlias): Lookup aliases only in current
9845 * rootcontext.cs (NamespaceLookup): Remove.
9846 (LookupType): Move to DeclSpace.
9847 * attribute.cs (CheckAttributeType): Update.
9848 * doc.cs (FindDocumentedType): Remove allowAlias argument.
9849 (FindDocumentedTypeNonArray): Likewise.
9851 2005-01-11 Raja R Harinath <rharinath@novell.com>
9853 Fix cs0509.cs, cs1632.cs.
9854 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
9855 is the same as IsInterface.
9856 (TypeContainer.GetClassBases): Likewise.
9857 * statement.cs (LabeledStatement.ig): New field.
9858 (LabeledStatement.LabelTarget): Save ILGenerator which created the
9860 (LabeledStatement.DoEmit): Check that the label was created with
9861 the same ILGenerator.
9863 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9866 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
9867 accessors to its properties.
9869 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
9870 from accessors to property.
9872 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9875 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
9878 2005-01-08 Miguel de Icaza <miguel@ximian.com>
9880 * attribute.cs: Check for null and empty strings.
9882 I have lost another battle to Paolo.
9884 2005-01-07 Marek Safar <marek.safar@seznam.cz>
9887 * class.cs (PropertyMethod): Set Parent field in ctors.
9888 (SetMethod.InternalParameters): Add unsafe switch hack.
9889 Override MarkForDuplicationCheck where it is appropriate.
9891 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
9892 It says whether container allows members with the same name.
9894 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
9895 Removed is_method parameter.
9897 2005-01-06 Duncan Mak <duncan@ximian.com>
9899 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
9900 because the previous change led to incorrect reporting of CS1032
9901 ("Cannot define/undefine preprocessor symbols after first token in
9902 file"). Instead of using `tokens_seen' as the only flag that
9903 triggers CS1040, introduce `comments_seen'. This new flag is used
9904 to signify having seen comments on the current line, so it is
9905 unset after a newline.
9907 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9909 * doc.cs : When searching for a type, find nested type too.
9910 This fixes bug #71040.
9912 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9915 - Warn missing member comment on those classes which also does not
9916 have doc comments. Fixed bug #71041.
9917 - Don't warn missing doc comment on default constructor.
9920 2005-01-06 Duncan Mak <duncan@ximian.com>
9922 * cs-tokenizer.cs (xtoken): After handling traditional C-style
9923 comments, set `tokens_seen' to true. This allows us to detect
9924 misplaced preprocessor directives (i.e. not at the beginning of
9925 the a line, nor after whitespaces). In that case, report error
9926 CS1040. This fixes bug #56460.
9928 * cs-parser.jay (interface_member_declaration): Add checks for
9929 IsExplicitImpl, and report CS0541 error if an interface member is
9930 defined as an explicit interface declaration.
9932 2005-01-06 Marek Safar <marek.safar@seznam.cz>
9935 * class.cs (PropertyMethod): Set Parent field in ctors.
9936 (SetMethod.InternalParameters): Add unsafe switch hack.
9938 * decl.cs (MemberCore.Parent): Cannot be readonly.
9940 2005-01-06 Raja R Harinath <rharinath@novell.com>
9942 * decl.cs (DeclSpace.ResolveType): Remove.
9943 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
9944 Merge in code from ...
9945 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
9946 * class.cs, enum.cs: Update to changes.
9948 2005-01-06 Miguel de Icaza <miguel@ximian.com>
9950 * anonymous.cs: Ensure that we init the scope of our parent if it
9951 has not been initialized yet.
9953 2004-12-30 Duncan Mak <duncan@ximian.com>
9955 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
9956 if field.FieldBuilder is null. Fixes #70758.
9958 * convert.cs: Fixed some typos and updated some of the comments.
9959 (ImplicitStandardConversionExists):
9960 (TryImplicitIntConversion): If `target_type' is an interface and
9961 the type of `ic' implements this interface, return true or a new
9962 BoxedCast instead of null. This fixes #70468.
9964 2004-12-29 Duncan Mak <duncan@ximian.com>
9966 * expression.cs (Argument.Emit): Check that Expr is
9967 IMemoryLocation before casting to it, and report CS1510 otherwise.
9971 2004-12-21 Ben Maurer <bmaurer@ximian.com>
9973 * statement.cs (Block.ThisVariable): remove the recursion here, to
9974 make the --profile more sane.
9976 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
9978 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
9979 assembly, by JB Evain.
9981 2004-12-17 Raja R Harinath <rharinath@novell.com>
9983 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
9984 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
9985 "parent" refers to enclosing type/class. "base" refers to superclass.
9987 2004-12-17 Raja R Harinath <rharinath@novell.com>
9989 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
9990 Ensure that we only have GlobalAttributes.
9991 * attribute.cs (Attribute.Emit): Make non-virtual.
9992 (GlobalAttribute.Emit): Remove.
9993 (Attribute.Resolve): Make virtual.
9994 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
9995 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
9996 the argument. Don't create one.
9997 (Attribute.GetObsoleteAttribute): Likewise.
9998 (Attribute.GetClsCompliantAttributeValue): Likewise.
9999 * class.cs, decl.cs: Update to changes.
10001 2004-12-17 Marek Safar <marek.safar@seznam.cz>
10003 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
10005 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
10007 * statement.cs (Foreach.Resolve): Add error 186 report.
10009 2004-12-16 Marek Safar <marek.safar@seznam.cz>
10011 * expression.cs (Conditional.DoResolve): Add warning 429.
10013 * statement.cs (If.Resolve): Add warning 665.
10015 2004-12-16 Raja R Harinath <rharinath@novell.com>
10017 New invariant: RootContext.Tree.Types.NamespaceEntry == null
10018 except when in the parser, and in GlobalAttribute.
10019 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
10020 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
10021 RootContext.Tree.Types.NamespaceEntry once work is done.
10022 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
10023 and resets RootContext.Tree.Types.NamespaceEntry.
10025 2004-12-15 Marek Safar <marek.safar@seznam.cz>
10027 * cs-parser.jay: Don't create a block for every variable.
10029 2004-12-14 Miguel de Icaza <miguel@ximian.com>
10031 * location.cs: Provide extra information.
10033 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
10034 variables from the captured environment, it is the ldarg_0.
10036 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10038 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
10041 * class.cs: Changed warning level for 169 to avoid developer
10042 displeasure from warning flooding. It will be changed back when they
10043 fix most of current BCL warnings.
10045 * RootContext.cs: Pushed default WarningLevel to 3.
10047 * statement.cs: Removed unused variable.
10049 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10051 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
10052 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
10053 Add error 502 report.
10054 (StaticClass.DefineType): Add error 441 report.
10055 (Class.AllowedModifiersProp): New virtual property as temporary
10056 extension to AllowedModifiers.
10057 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10058 to share implementation with StaticClass and don't call virtual
10061 * driver.cs (MainDriver): Add error 1558 test.
10063 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
10064 report. Moved error 36 test here.
10066 * statement.cs (Throw.Resolve): Add error 724 report.
10068 * typemanager.cs: Add out_attribute_type core type.
10070 2004-12-13 Marek Safar <marek.safar@seznam.cz>
10072 * class.cs (TypeContainer.VerifyClsCompliance): Add error
10074 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
10076 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
10079 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
10081 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
10082 Add error 3023 report.
10083 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
10085 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
10088 2004-12-12 John Luke <john.luke@gmail.com>
10090 * driver.cs (AddArgs): take -- into account when
10091 adding arguments, fixes bug 65710
10093 2004-12-12 Martin Baulig <martin@ximian.com>
10095 * expression.cs (Unary.TryReduceNegative): Added support for
10096 SByteConstant and ByteConstant.
10097 (Unary.Reduce): Check error values from TryReduceNegative().
10099 2004-12-10 Marek Safar <marek.safar@seznam.cz>
10101 * attributes.cs (Attribute.Resolve): Avoid multiple error report
10102 and report exception as error 182.
10104 2004-12-10 Raja R Harinath <rharinath@novell.com>
10106 * driver.cs (Main): Fix message when there are warnings.
10108 2004-12-09 Miguel de Icaza <miguel@ximian.com>
10110 * delegate.cs: Fixed my fix from yesterday, sorry about that.
10112 2004-12-09 Marek Safar <marek.safar@seznam.cz>
10114 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
10115 Reduced number of warnings.
10117 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
10119 2004-12-08 Miguel de Icaza <miguel@ximian.com>
10121 * driver.cs: Removed message.
10123 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
10125 2004-12-08 <vargaz@freemail.hu>
10127 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
10129 2004-12-08 Martin Baulig <martin@ximian.com>
10131 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
10132 instead of a CS3002 for properties and indexer.
10134 2004-12-08 Martin Baulig <martin@ximian.com>
10136 * decl.cs (MemberName.ToString): Make this work again.
10138 2004-12-08 Marek Safar <marek.safar@seznam.cz>
10140 * attribute.cs (Resolve): Add error 591 detection.
10142 * class.cs (FieldMember.Define): Add error 1547 detection.
10143 (Indexer.Define): Add error 620 detection.
10144 (Operator.Define): Add error 590 detection.
10146 * ecore.cs: Missing argument for error 79.
10148 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
10151 2004-12-07 Marek Safar <marek.safar@seznam.cz>
10154 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
10157 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
10159 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10160 Some operator comments were suppressed.
10161 * doc.cs : Implicit/explicit operator name in doc comments are like
10162 "op_Explicit(type)~returnType", so added suffix handling.
10164 2004-12-07 Martin Baulig <martin@ximian.com>
10167 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
10168 (MemberCore.GetClsCompliantAttributeValue): Likewise.
10169 (DeclSpace.ec): New protected field; store the EmitContext here.
10170 (DeclSpace.EmitContext): New public property; moved here from
10172 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
10175 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
10176 (Enum.Emit): Don't create a new EmitContext.
10178 * delegate.cs (Delegate.DefineType): Always create the
10181 * iterators.cs (Iterators.DefineIterator): Create a new
10182 EmitContext and store it in `ec'.
10184 2004-08-24 Martin Baulig <martin@ximian.com>
10187 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10188 this for accessibility checks.
10189 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10190 IsNestedFamilyAccessible.
10191 (TypeManager.IsSubclassOf): New method, do what the name actually
10194 2004-12-06 Raja R Harinath <rharinath@novell.com>
10196 Fix crash on cs0657-17.cs.
10197 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10198 Use RootContext.Tree.Types, not 'new RootTypes ()'.
10199 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
10200 the case where the NamespaceEntry gets overwritten.
10202 2004-12-06 Marek Safar <marek.safar@seznam.cz>
10204 Fixed #69195, #56821
10205 * ecore.cs (ResolveBoolean): Tiny refactoring.
10207 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
10208 of right expression resolving when left is false constant and
10209 operator is LogicalAnd OR true constant and operator is LogicalOr.
10211 * statement.cs (ResolveUnreachable): Always reports warning.
10213 2004-12-05 Miguel de Icaza <miguel@ximian.com>
10215 * class.cs: Distinguish between 1721 and 1722 (just a little help
10216 for the programmer).
10218 2004-12-03 Miguel de Icaza <miguel@ximian.com>
10220 * delegate.cs: Only allow this on new versions of the language.
10222 2004-12-02 Duncan Mak <duncan@ximian.com>
10224 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
10226 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
10227 here as a static method. Take an additional bool out parameter
10228 `must_do_cs1540_check' for signaling to InstanceResolve.
10229 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
10230 member field from PropertyExpr class and made it an argument of
10231 the method instead.
10232 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
10233 check for MarshalByRefObject, and report CS0122 instead of CS1540.
10234 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
10235 and `remove_accessor' as well as InstanceResolve: report CS0122
10240 2004-12-03 Raja R Harinath <rharinath@novell.com>
10242 Fix test-327.cs, test-328.cs, and put in early infrastructure
10243 for eventually fixing #52697.
10244 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
10245 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
10246 from other methods.
10247 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
10248 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
10249 (VerifyUsing, error246): Update.
10250 * rootcontext.cs (RootContext.NamespaceLookup): Just use
10251 'NamespaceEntry.LookupNamespaceOrType'.
10253 2004-12-03 Martin Baulig <martin@ximian.com>
10255 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10256 method as our child, call AnonymousMethod.Compatible() on it.
10258 2004-12-03 Raja R Harinath <rharinath@novell.com>
10260 Disable XML documentation support in 'basic' profile.
10261 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
10262 Redirect XmlElement to System.Object.
10263 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
10264 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
10265 * mcs.exe.sources: Add doc-bootstrap.cs.
10266 * doc-bootstrap.cs: New file. Contains empty stub implementation
10269 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
10271 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
10272 comments are allowed.
10274 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10276 * delegate.cs: Add checks for subtypes in paramaters and return values
10277 in VerifyMethod () to add support for Covariance/Contravariance
10280 2004-12-02 Miguel de Icaza <miguel@ximian.com>
10282 * report.cs: Remove extra closing parenthesis.
10284 * convert.cs (Error_CannotImplicitConversion): If the name of the
10285 types are the same, provide some extra information.
10287 * class.cs (FieldBase): Use an unused bit field from the field to
10288 encode the `has_offset' property from the FieldMember. This saves
10289 a couple of Ks on bootstrap compilation.
10291 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10292 method as our child, return the AnonymousMethod resolved
10295 * expression.cs (New.DoResolve): Allow return values from
10296 NewDelegate to also include AnonymousMethods.
10300 2004-12-02 Marek Safar <marek.safar@seznam.cz>
10303 * attribute.cs (Resolve): Improved implementation of params
10304 attribute arguments.
10306 * support.cs (ParameterData): Add HasParams to be faster.
10308 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
10310 all things are for /doc support:
10312 * doc.cs: new file that supports XML documentation generation.
10313 * mcs.exe.sources: added doc.cs.
10315 Handle /doc command line option.
10316 Report error 2006 instead of 5 for missing file name for /doc.
10317 Generate XML documentation when required, after type resolution.
10319 Added support for picking up documentation (/// and /** ... */),
10320 including a new XmlCommentState enumeration.
10322 Added lines to fill Documentation element for field, constant,
10323 property, indexer, method, constructor, destructor, operator, event
10324 and class, struct, interface, delegate, enum.
10325 Added lines to warn incorrect comment.
10327 Added Documentation field (passed only when /doc was specified).
10329 Added DocComment, DocCommentHeader, GenerateDocComment() and
10330 OnGenerateDocComment() and some supporting private members for
10331 /doc feature to MemberCore.
10333 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
10335 Added overriden DocCommentHeader.
10337 Added overriden DocCommentHeader and GenerateDocComment().
10339 2004-12-01 Miguel de Icaza <miguel@ximian.com>
10341 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
10342 unwrapping the enumeration values, chain to
10343 DoConstantNumericPromotions again, so we can promote things to the
10344 fundamental types (takes care of enums that are bytes, sbytes).
10348 2004-12-01 Raja R Harinath <rharinath@novell.com>
10350 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
10351 Fix long-standing bug in type-lookup. Use FindType instead of
10352 LookupType when ec.ResolvingTypeTree.
10353 (Attribute.ResolveType, Attribute.Resolve)
10354 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
10356 (Attributes.Search): Remove internal version. Update.
10357 (Attributes.SearchMulti): Update.
10358 (Attributes.GetClsCompliantAttribute): Remove.
10359 (Attributes.GetIndexerNameAttribute): Remove.
10360 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
10361 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
10362 * class.cs (Indexer.Define): Likewise.
10364 2004-12-01 Marek Safar <marek.safar@seznam.cz>
10367 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
10368 MarshallByReference members access.
10370 * expression.cs: Use CheckMarshallByRefAccess;
10371 Better error CS0197 message.
10373 * report.cs: Print whole related error message.
10375 2004-11-30 Raja R Harinath <rharinath@novell.com>
10377 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
10378 the current directory to help debugging.
10380 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10382 * class (GetClassBases): Better error 60 report.
10383 (EventProperty): Disabled warning 67 detection.
10385 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10388 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
10390 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
10393 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10396 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
10398 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
10400 2004-11-26 Miguel de Icaza <miguel@ximian.com>
10402 * attribute.cs (Attribute.Resolve): Refine error reporting and
10403 report a cs0117 if the identifier does not exist, to distinguish
10404 from 0617 which is a miss-use of the actual identifier.
10406 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
10407 between cs0070 and cs0079.
10409 * class.cs (MemberBase.DoDefine): When reporting a wrong
10410 accessibility level, we use MethodCore to compare instead of
10411 Method (this was a regression in some refactoring effort).
10413 So now we correctly report cs0056 again.
10415 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
10416 testing the target_type (which was known to be object_type) and
10417 not the source type (which is anonymous_method).
10419 Fixed reporting of error cs1660.
10421 * expression.cs (UserCast.Source): Expose the underlying cast.
10423 * statement.cs (Switch.SwitchGoverningType): Sort the list of
10424 allowed types to find a match to int32 first (most common).
10426 In addition, it ignores any ImplicitUserConversions that did an
10427 internal implicit conversion (as the switch statement allows only
10428 one integral conversion to exist).
10430 * class.cs (PartialContainer.Create): rename `name' to
10431 `member_name' for clarity. Then replace the string calls with a
10432 call to MemberName.GetPartialName, as now using
10433 MemberName.ToString is an error (this is due to the side effects
10434 it had, that were fixed in the past).
10436 This will restore the error reporting on a number of partial class
10437 errors that were missusing this (and getting an exception as a
10438 results, which is now just a plain textual warning, because
10439 yyparse debug output would crash otherwise).
10441 2004-11-26 Raja R Harinath <rharinath@novell.com>
10443 * Makefile (PROGRAM_INSTALL_DIR): Remove.
10445 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10447 * rootcontext.cs (LookupType): Make sure to cache lookups that
10448 don't give us a negative result. This saves about 5% of corlib
10451 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10453 * report.cs (AbstractMessage.Print): messages are sent to stderr
10455 * class.cs (TypeContainer.GetClassBases): It is an error to have a
10456 non-interface in the list of interfaces (at this point, either
10457 parent was properly set, or a base class is being listed in the
10458 interfaces section).
10460 This flags error 1722, and resolves the crash from bug 69259.
10462 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10464 * statement.cs (Using.EmitExpressionFinally): make this work right
10465 for valuetypes. Fixes 69926.
10467 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10469 * const.cs (Const.ChangeType): Cope with the "0 literal can be
10470 converted to an enum" here, before we try to change the underlying
10471 type. This code exists, but it is a different code path than the
10472 one used while encoding constants.
10474 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
10475 old bug: when converting from the null literal to a pointer,
10476 return an EmptyCast, not the NullLiteral.
10478 This fixes #69921, the recent null_type changes probably made this
10479 bug more prominent.
10481 (ImplicitReferenceConversionExists): In addition, resynchronized
10482 the code here, so it matches the same code in
10483 ImplicitReferenceConversionExists for the `from any class-type S
10484 to any interface-type T'.
10487 2004-11-25 Marek Safar <marek.safar@seznam.cz>
10489 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
10491 2004-11-24 Miguel de Icaza <miguel@ximian.com>
10493 * cs-parser.jay: Use verbosity accordingly.
10495 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10497 * expression.cs (Unary.ResolveOperator): Do not report warning;
10498 AddressOf reads from variable.
10500 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
10502 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10506 * attribute.cs (Attributable): Removed CheckTargets.
10507 (Attributes.Emit): Explicit attribute targets are tested here.
10509 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
10510 not enabled for interfaces.
10512 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
10513 (GetAssemblyName): Ouch next bug there.
10515 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10517 * expression.cs: Error 275 added.
10519 2004-11-23 Marek Safar <marek.safar@seznam.cz>
10521 Fix bug #69177 (Implemented decimal constant support)
10523 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
10524 (BinaryFold): Add DecimalConstant.
10526 * const.cs (Define): Decimal constant
10528 (ChangeType): Add decimal type handling.
10529 (LookupConstantValue): Don't set value for decimal type but
10530 emit DecimalConstantAttribute. Needed for constant optimization.
10532 * constant.cs (ToDecimal): New method.
10533 (ConvertToDecimal): New method.
10534 (IntConstant): Implemented ConvertToDecimal.
10535 (DecimalConstant.Emit): Emit optimized version for decimals in
10538 * expression.cs (ResolveOperator): Changed order of constant
10539 reduction to work correctly with native types which have
10540 overloaded operators.
10541 (ResolveMemberAccess): Extract constant value from attribute
10544 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
10546 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
10547 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
10548 (ChangeType): Decimal is special.
10549 (TypeToCoreType): Add decimal type.
10551 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10553 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
10556 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10558 * class.cs (EventField.ApplyAttributeBuilder): Fix error
10561 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10563 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
10565 * pending.cs (PendingImplementation): Grab only interfaces.
10567 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10569 * statement.cs (ForeachHelperMethods): Add location member and
10570 error 202 detection.
10572 2004-11-19 Raja R Harinath <rharinath@novell.com>
10574 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
10575 automatically handled by executable.make.
10576 (PROGRAM): Make profile-specific.
10578 2004-11-18 Marek Safar <marek.safar@seznam.cz>
10580 * expression.cs (DoResolveBase): Fixed wrong warning for out
10583 2004-11-18 Martin Baulig <martin@ximian.com>
10585 Merged latest changes into gmcs. Please keep this comment in
10586 here, it makes it easier for me to see what changed in MCS since
10587 the last time I merged.
10589 2004-11-17 Raja R Harinath <rharinath@novell.com>
10591 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
10592 (TypeHandle.GetMemberCache): New.
10593 (TypeHandle.TypeHandle): Update.
10594 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
10595 (TypeManager.LookupParentInterfacesCache):
10596 Rename from LookupInterfaceCache. Optimize slightly.
10597 (TypeManager.MemberLookup_FindMembers): Update.
10598 * decl.cs (MemberCache.MemberCache): Set Container to null in the
10599 multi-type variant.
10600 (AddCacheContents): Rename from AddHashtable.
10601 * class.cs (TypeContainer.parent_container): Remove.
10602 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
10603 (TypeContainer.DoDefineMembers): Don't initialize it.
10604 Update to name changes.
10606 2004-11-17 Miguel de Icaza <miguel@ximian.com>
10608 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
10609 that factors the code to check access modifiers on override.
10611 (PropertyBase): Use the code here.
10613 Patch from Lluis S'anchez, fixes bug #69361.
10615 2004-11-15 Miguel de Icaza <miguel@ximian.com>
10617 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
10618 routine that is used to report the use of a captured variable
10619 whose address has been taken.
10621 There are two checks: one when variables are being captured and
10622 the other check is when the address of a variable is taken.
10624 (because an anonymous methods might be resolved before *or* after
10625 the address has been taken) and
10627 * expression.cs (Conditional.DoResolve): Remove the special
10628 casing that Martin added to trueExpr and falseExpr being both
10629 NullLiteral. We get the right behavior now just by introducing
10630 the null_type into the compiler.
10632 * convert.cs (ExplicitConversion): Change the code to use
10633 null_type instead of testing `expr is NullLiteral'.
10634 (ImplicitConversionStandard): use null_type too.
10635 (ImplicitReferenceConversionExists): use null_type too.
10636 (ImplicitReferenceConversion): use null_type too.
10638 * literal.cs: The type of `NullLiteral' is now null_type instead
10640 (Resolve): Set the type here.
10642 * typemanager.cs: Introduce null_type.
10644 2004-11-17 Martin Baulig <martin@ximian.com>
10646 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
10647 direction, like FindMembers() does. Fixes #69546, testcase is in
10650 2004-11-16 Martin Baulig <martin@ximian.com>
10652 This is based on a patch from Marek Safar, see bug #69082.
10653 Fixes bugs #63705 and #67130.
10655 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
10656 method; create a MemberCache for an interface type and cache the
10659 * decl.cs (IMemberContainer.ParentContainer): Removed.
10660 (IMemberContainer.ParentCache): New property.
10661 (MemberCache.SetupCacheForInterface): Removed.
10662 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
10663 to create a cache for an interface's "parent".
10665 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
10668 2004-11-16 Martin Baulig <martin@ximian.com>
10670 Merged back from gmcs; these changes already went into gmcs a
10671 couple of weeks ago.
10674 (TypeManager.AddUserType): Removed the `ifaces' argument.
10675 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
10677 (TypeManager.AddUserInterface): Removed.
10678 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
10680 (TypeManager.GetInterfaces): Likewise.
10681 (TypeManager.GetExplicitInterfaces): Likewise.
10683 * ecore.cs (TypeExpr.GetInterfaces): Removed.
10685 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
10686 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
10688 2004-11-14 Ben Maurer <bmaurer@ximian.com>
10690 * statement.cs: Avoid adding bools to a hashtable.
10692 2004-11-07 Miguel de Icaza <miguel@ximian.com>
10694 * expression.cs (Invocation.OverloadResolve): Flag error if we are
10695 calling an unsafe method from a safe location.
10697 2004-11-06 Marek Safar <marek.safar@seznam.cz>
10700 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
10702 2004-11-06 Miguel de Icaza <miguel@ximian.com>
10704 * namespace.cs (VerifyUsing): use GetPartialName instead of
10707 2004-11-05 Miguel de Icaza <miguel@ximian.com>
10709 * statement.cs (Return.Resolve): Fix regression in typo: if
10710 `in_exc', we have to request a NeedReturnLabel, this was a typo
10711 introduced in the anonymous method check-in. Fixes #69131.
10713 * Indexers were using the ShortName when defining themselves,
10714 causing a regression in the compiler bootstrap when applying the
10715 patch from 2004-11-02 (first part), now they use their full name
10716 and the bug is gone.
10718 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
10720 * driver.cs: Strip the path from the names of embedded resources. Fixes
10723 2004-11-04 Raja R Harinath <rharinath@novell.com>
10725 Fix error message regression: cs0104-2.cs.
10726 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
10727 (AliasEntry.Resolve): Update.
10728 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
10730 (RootContext.LookupType): Update.
10732 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
10734 * cs-parser.jay: Add support for handling accessor modifiers
10735 * class: Add support port accessor modifiers and error checking,
10736 define PropertyMethod.Define as virtual (not abstract anymore)
10737 * ecore.cs: Add checking for proeprties access with access modifiers
10738 * iterators.cs: Modify Accessor constructor call based in the modified
10740 2004-11-02 Ben Maurer <bmaurer@ximian.com>
10742 * expression.cs (StringConcat): Handle being called twice,
10743 as when we have a concat in a field init with more than two
10746 2004-11-02 Miguel de Icaza <miguel@ximian.com>
10748 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
10749 special case explicit implementations, we should always produce
10750 the .property or .event declaration.
10752 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
10753 since it will not return correct data if people use this
10754 unresolved in the presence of using statements (see test-313).
10756 * class.cs (MethodData.Define): If we are an explicit interface
10757 implementation, set the method name to the full name of the
10758 interface plus the name of the method.
10760 Notice that using the method.MethodName.GetFullName() does not
10761 work, as it will only contain the name as declared on the source
10762 file (it can be a shorthand in the presence of using statements)
10763 and not the fully qualifed type name, for example:
10767 class D : ICloneable {
10768 object ICloneable.Clone () {
10772 Would produce a method called `ICloneable.Clone' instead of
10773 `System.ICloneable.Clone'.
10775 * namespace.cs (Alias.Resolve): Use GetPartialName.
10777 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10779 * cs-parser.jay: Add error 1055 report.
10781 2004-11-01 Miguel de Icaza <miguel@ximian.com>
10783 * assign.cs (Assign.DoResolve): Only do the transform of
10784 assignment into a New if the types are compatible, if not, fall
10785 through and let the implicit code deal with the errors and with
10786 the necessary conversions.
10788 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10790 * cs-parser.jay: Add error 1031 report.
10792 * cs-tokenizer.cs: Add location for error 1038.
10794 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10796 * cs-parser.jay: Add error 1016 report.
10798 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10800 * cs-parser.jay: Add errors 1575,1611 report.
10802 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10804 * cs-parser.jay: Add error 1001 report.
10806 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10809 * attribute.cs (GetMarshal): Add method argument for
10810 caller identification.
10812 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
10813 agument for GetMarshal and RuntimeMissingSupport.
10815 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10817 * attribute.cs (ExtractSecurityPermissionSet): Removed
10818 TypeManager.code_access_permission_type.
10820 * typemanager.cs: Removed TypeManager.code_access_permission_type.
10822 2004-10-27 Miguel de Icaza <miguel@ximian.com>
10824 * expression.cs (LocalVariableReference.DoResolveLValue): Check
10825 for obsolete use of a variable here. Fixes regression on errors
10826 cs0619-25 and cs0619-26.
10828 2004-10-27 Marek Safar <marek.safar@seznam.cz>
10830 Fix #62358, implemented security attribute encoding.
10832 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
10833 Tests permitted SecurityAction for assembly or other types.
10834 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
10835 data from SecurityPermissionAttribute to PermisionSet class.
10837 * class.cs (ApplyAttributeBuilder): Added special handling
10838 for System.Security.Permissions.SecurityAttribute based types.
10840 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
10841 special handling for System.Security.Permissions.SecurityAttribute
10844 * enum.cs (ApplyAttributeBuilder): Added special handling
10845 for System.Security.Permissions.SecurityAttribute based types.
10847 * parameter.cs (ApplyAttributeBuilder): Added special handling
10848 for System.Security.Permissions.SecurityAttribute based types.
10850 * rootcontext.cs: Next 2 core types.
10852 * typemanager.cs (TypeManager.security_permission_attr_type):
10853 Built in type for the SecurityPermission Attribute.
10854 (code_access_permission_type): Build in type.
10856 2004-10-17 Miguel de Icaza <miguel@ximian.com>
10858 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
10859 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
10860 all of this information into
10861 EmitContext.EmitCapturedVariableInstance.
10863 * codegen.cs (EmitCapturedVariableInstance): move here the
10864 funcionality of emitting an ldarg.0 in the presence of a
10865 remapping. This centralizes the instance emit code.
10867 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
10868 then emit a load of this: it means that we have reached the
10869 topmost ScopeInfo: the one that contains the pointer to the
10870 instance of the class hosting the anonymous method.
10872 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
10873 captures to the topmost CaptureContext.
10875 2004-10-12 Miguel de Icaza <miguel@ximian.com>
10877 * expression.cs (LocalVariableReference): Move the knowledge about
10878 the iterators into codegen's EmitCapturedVariableInstance.
10880 2004-10-11 Miguel de Icaza <miguel@ximian.com>
10882 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
10883 all code paths return a value from an anonymous method (it is the
10884 same as the 161 error, but for anonymous methods).
10886 2004-10-08 Miguel de Icaza <miguel@ximian.com>
10888 The introduction of anonymous methods in the compiler changed
10889 various ways of doing things in the compiler. The most
10890 significant one is the hard split between the resolution phase
10891 and the emission phases of the compiler.
10893 For instance, routines that referenced local variables no
10894 longer can safely create temporary variables during the
10895 resolution phase: they must do so from the emission phase,
10896 since the variable might have been "captured", hence access to
10897 it can not be done with the local-variable operations from the runtime.
10901 (Block.Flags): New flag `IsTopLevel' to indicate that this block
10902 is a toplevel block.
10904 (ToplevelBlock): A new kind of Block, these are the blocks that
10905 are created by the parser for all toplevel method bodies. These
10906 include methods, accessors and anonymous methods.
10908 These contain some extra information not found in regular blocks:
10909 A pointer to an optional CaptureContext (for tracking captured
10910 local variables and parameters). A pointer to the parent
10913 (Return.Resolve): Catch missmatches when returning a value from an
10914 anonymous method (error 1662).
10915 Invoke NeedReturnLabel from the Resolve phase instead of the emit
10918 (Break.Resolve): ditto.
10920 (SwitchLabel): instead of defining the labels during the
10921 resolution phase, we now turned the public ILLabel and ILLabelCode
10922 labels into methods called GetILLabelCode() and GetILLabel() that
10923 only define the label during the Emit phase.
10925 (GotoCase): Track the SwitchLabel instead of the computed label
10926 (its contained therein). Emit the code by using
10927 SwitchLabel.GetILLabelCode ().
10929 (LocalInfo.Flags.Captured): A new flag has been introduce to track
10930 whether the Local has been captured or not.
10932 (LocalInfo.IsCaptured): New property, used to tell whether the
10933 local has been captured.
10935 * anonymous.cs: Vastly updated to contain the anonymous method
10938 The main classes here are: CaptureContext which tracks any
10939 captured information for a toplevel block and ScopeInfo used to
10940 track the activation frames for various local variables.
10942 Each toplevel block has an optional capture context associated
10943 with it. When a method contains an anonymous method both the
10944 toplevel method and the anonymous method will create a capture
10945 context. When variables or parameters are captured, they are
10946 recorded on the CaptureContext that owns them, for example:
10950 MyDelegate d = delegate {
10955 Here `a' will be recorded as captured on the toplevel
10956 CapturedContext, the inner captured context will not have anything
10957 (it will only have data if local variables or parameters from it
10958 are captured in a nested anonymous method.
10960 The ScopeInfo is used to track the activation frames for local
10961 variables, for example:
10963 for (int i = 0; i < 10; i++)
10964 for (int j = 0; j < 10; j++){
10965 MyDelegate d = delegate {
10970 At runtime this captures a single captured variable `i', but it
10971 captures 10 different versions of the variable `j'. The variable
10972 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
10973 recorded on a child.
10975 The toplevel ScopeInfo will also track information like the `this'
10976 pointer if instance variables were referenced (this is necessary
10977 as the anonymous method lives inside a nested class in the host
10978 type of the method).
10980 (AnonymousMethod): Expanded to track the Toplevel, implement
10981 `AnonymousMethod.Compatible' to tell whether an anonymous method
10982 can be converted to a target delegate type.
10984 The routine now also produces the anonymous method content
10986 (AnonymousDelegate): A helper class that derives from
10987 DelegateCreation, this is used to generate the code necessary to
10988 produce the delegate for the anonymous method that was created.
10990 * assign.cs: API adjustments for new changes in
10991 Convert.ImplicitStandardConversionExists.
10993 * class.cs: Adjustments to cope with the fact that now toplevel
10994 blocks are of type `ToplevelBlock'.
10996 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
10997 insteda of standard blocks.
10999 Flag errors if params arguments are passed to anonymous methods.
11001 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
11002 `CurrentAnonymousMethod' which points to the current Anonymous
11003 Method. The variable points to the AnonymousMethod class that
11004 holds the code being compiled. It is set in the new EmitContext
11005 created for the anonymous method.
11007 (EmitContext.Phase): Introduce a variable and an enumeration to
11008 assist in enforcing some rules about when and where we are allowed
11009 to invoke certain methods (EmitContext.NeedsReturnLabel is the
11010 only one that enfonces this right now).
11012 (EmitContext.HaveCaptureInfo): new helper method that returns
11013 whether we have a CapturedContext initialized.
11015 (EmitContext.CaptureVariable): New method used to register that a
11016 LocalInfo must be flagged for capturing.
11018 (EmitContext.CapturedParameter): New method used to register that a
11019 parameters must be flagged for capturing.
11021 (EmitContext.CapturedField): New method used to register that a
11022 field must be flagged for capturing.
11024 (EmitContext.HaveCapturedVariables,
11025 EmitContext.HaveCapturedFields): Return whether there are captured
11026 variables or fields.
11028 (EmitContext.EmitMethodHostInstance): This is used to emit the
11029 instance for the anonymous method. The instance might be null
11030 (static methods), this (for anonymous methods that capture nothing
11031 and happen to live side-by-side with the current method body) or a
11032 more complicated expression if the method has a CaptureContext.
11034 (EmitContext.EmitTopBlock): Routine that drives the emission of
11035 code: it will first resolve the top block, then emit any metadata
11036 and then emit the code. The split is done so that we can extract
11037 any anonymous methods and flag any captured variables/parameters.
11039 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
11040 during this phase, the ILGenerator should not be used as labels
11041 and local variables declared here might not be accessible to any
11042 code that is part of an anonymous method.
11044 Exceptions to this include the temporary variables that are
11045 created by some statements internally for holding temporary
11048 (EmitContext.EmitMeta): New routine, in charge of emitting all the
11051 (EmitContext.TemporaryReturn): This method is typically called
11052 from the Emit phase, and its the only place where we allow the
11053 ReturnLabel to be defined other than the EmitMeta. The reason is
11054 that otherwise we would have to duplicate a lot of logic in the
11055 Resolve phases of various methods that today is on the Emit
11058 (EmitContext.NeedReturnLabel): This no longer creates the label,
11059 as the ILGenerator is not valid during the resolve phase.
11061 (EmitContext.EmitThis): Extended the knowledge in this class to
11062 work in anonymous methods in addition to iterators.
11064 (EmitContext.EmitCapturedVariableInstance): This emits whatever
11065 code is necessary on the stack to access the instance to a local
11066 variable (the variable will be accessed as a field).
11068 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
11069 EmitContext.EmitAddressOfParameter): Routines to support
11070 parameters (not completed at this point).
11072 Removals: Removed RemapLocal and RemapLocalLValue. We probably
11073 will also remove the parameters.
11075 * convert.cs (Convert): Define a `ConstantEC' which points to a
11076 null. This is just to prefity some code that uses
11077 ImplicitStandardConversion code and do not have an EmitContext
11080 The idea is to flag explicitly that at that point in time, it is
11081 known that the conversion will not trigger the delegate checking
11082 code in implicit conversions (which requires a valid
11085 Everywhere: pass new EmitContext parameter since
11086 ImplicitStandardConversionExists now requires it to check for
11087 anonymous method conversions.
11089 (Convert.ImplicitStandardConversionExists): If the type of an
11090 expression is the anonymous_method_type, and the type is a
11091 delegate, we invoke the AnonymousMethod.Compatible method to check
11092 whether an implicit conversion is possible.
11094 (Convert.ImplicitConversionStandard): Only do implicit method
11095 group conversions if the language level is not ISO_1.
11097 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
11098 MethodInfo for the Invoke method. used by Delegate and
11101 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
11102 method conversions if the target type is a delegate.
11104 Removed extra debugging nops.
11106 (LocalVariableReference): Turn the `local_info' into a public
11109 Add `prepared' field, the same hack used for FieldExprs to cope
11110 with composed assignments, as Local variables do not necessarily
11111 operate purely on the stack as they used to: they can be captured
11114 Add `temp' for a temporary result, like fields.
11116 Refactor DoResolve and DoResolveLValue into DoResolveBase.
11118 It now copes with Local variables that are captured and emits the
11119 proper instance variable to load it from a field in the captured
11122 (ParameterReference.DoResolveBase): During the resolve phase,
11123 capture parameters if we are in an anonymous method.
11125 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
11126 anonymous method, use the EmitContext helper routines to emit the
11127 parameter reference.
11129 * iterators.cs: Set RemapToProxy to true/false during the
11132 * parameters.cs (GetParameterByName): New helper method.
11134 * typemanager.cs (anonymous_method_type) a new type that
11135 represents an anonyous method. This is always an internal type,
11136 used as a fencepost to test against the anonymous-methodness of an
11139 2004-10-20 Marek Safar <marek.safar@seznam.cz>
11141 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
11143 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
11145 2004-10-18 Martin Baulig <martin@ximian.com>
11147 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
11148 `Type' directly, but call ResolveType() on it.
11149 (Catch.Resolve): Likewise.
11150 (Foreach.Resolve): Likewise.
11152 2004-10-18 Martin Baulig <martin@ximian.com>
11154 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
11155 `Type' directly, but call ResolveType() on it.
11156 (Probe.DoResolve): Likewise.
11157 (ArrayCreation.LookupType): Likewise.
11158 (TypeOf.DoResolve): Likewise.
11159 (SizeOf.DoResolve): Likewise.
11161 2004-10-18 Martin Baulig <martin@ximian.com>
11163 * expression.cs (Invocation.BetterFunction): Put back
11164 TypeManager.TypeToCoreType().
11166 2004-10-18 Raja R Harinath <rharinath@novell.com>
11168 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
11171 2004-10-18 Martin Baulig <martin@ximian.com>
11173 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
11174 `Type' directly, but call ResolveType() on it.
11176 2004-10-18 Martin Baulig <martin@ximian.com>
11178 * class.cs (FieldMember.Define): Don't access the TypeExpr's
11179 `Type' directly, but call ResolveType() on it.
11180 (MemberBase.DoDefine): Likewise.
11182 * expression.cs (New.DoResolve): Don't access the TypeExpr's
11183 `Type' directly, but call ResolveType() on it.
11184 (ComposedCast.DoResolveAsTypeStep): Likewise.
11186 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
11187 `Type' directly, but call ResolveType() on it.
11189 2004-10-17 John Luke <john.luke@gmail.com>
11191 * class.cs (Operator.GetSignatureForError): use CSharpName
11193 * parameter.cs (Parameter.GetSignatureForError): Returns
11194 correct name even if was not defined.
11196 2004-10-13 Raja R Harinath <rharinath@novell.com>
11199 * class.cs (TypeContainer.EmitContext): New property.
11200 (DefineNestedTypes): Create an emitcontext for each part.
11201 (MethodCore.DoDefineParameters): Use container's emitcontext.
11202 Pass type array to InternalParameters.
11203 (MemberBase.DoDefine): Use container's emitcontext.
11204 (FieldMember.Define): Likewise.
11205 (Event.Define): Likewise.
11206 (SetMethod.GetParameterInfo): Change argument to EmitContext.
11207 Pass type array to InternalParameters.
11208 (SetIndexerMethod.GetParameterInfo): Likewise.
11209 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
11210 * delegate.cs (Define): Pass emitcontext to
11211 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
11212 array to InternalParameters.
11213 * expression.cs (ParameterReference.DoResolveBase): Pass
11214 emitcontext to GetParameterInfo.
11215 (ComposedCast.DoResolveAsTypeStep): Remove check on
11216 ec.ResolvingTypeTree.
11217 * parameter.cs (Parameter.Resolve): Change argument to
11218 EmitContext. Use ResolveAsTypeTerminal.
11219 (Parameter.GetSignature): Change argument to EmitContext.
11220 (Parameters.ComputeSignature): Likewise.
11221 (Parameters.ComputeParameterTypes): Likewise.
11222 (Parameters.GetParameterInfo): Likewise.
11223 (Parameters.ComputeAndDefineParameterTypes): Likewise.
11224 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
11225 * support.cs (InternalParameters..ctor): Remove variant that takes
11227 * typemanager.cs (system_intptr_expr): New.
11228 (InitExpressionTypes): Initialize it.
11230 2004-10-12 Chris Toshok <toshok@ximian.com>
11232 * cs-parser.jay: fix location for try_statement and catch_clause.
11234 2004-10-11 Martin Baulig <martin@ximian.com>
11236 * report.cs: Don't make --fatal abort on warnings, we have
11237 -warnaserror for that.
11239 2004-10-07 Raja R Harinath <rharinath@novell.com>
11241 More DeclSpace.ResolveType avoidance.
11242 * decl.cs (MemberCore.InUnsafe): New property.
11243 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
11244 with newly created EmitContext.
11245 (FieldMember.Define): Likewise.
11246 * delegate.cs (Delegate.Define): Likewise.
11247 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
11248 only if normal name-lookup fails.
11249 (TypeExpr.DoResolve): Enable error-checking.
11250 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
11251 (SizeOf.DoResolve): Likewise.
11252 (ComposedCast.DoResolveAsTypeStep): Likewise.
11253 (StackAlloc.DoResolve): Likewise.
11254 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
11255 (Block.Unsafe): New property.
11256 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
11257 (Unsafe): Set 'unsafe' flag of contained block.
11258 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
11259 (Fixed.Resolve): Likewise.
11260 (Catch.Resolve): Likewise.
11261 (Using.ResolveLocalVariableDecls): Likewise.
11262 (Foreach.Resolve): Likewise.
11264 2004-10-05 John Luke <john.luke@gmail.com>
11266 * cs-parser.jay: add location to error CS0175
11268 2004-10-04 Miguel de Icaza <miguel@ximian.com>
11270 * ecore.cs (Expression.Constantity): Add support for turning null
11273 * const.cs (Const.Define): Allow constants to be reference types
11274 as long as the value is Null.
11276 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
11278 * namespace.cs (NamespaceEntry.Using): No matter which warning
11279 level is set, check if this namespace name has already been added.
11281 2004-10-03 Ben Maurer <bmaurer@ximian.com>
11283 * expression.cs: reftype [!=]= null should always use br[true,false].
11286 2004-10-03 Marek Safar <marek.safar@seznam.cz>
11289 * attribute.cs: Enum conversion moved to
11290 GetAttributeArgumentExpression to be applied to the all
11293 2004-10-01 Raja R Harinath <rharinath@novell.com>
11295 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
11296 * class.c (TypeContainer.DefineType): Flag error if
11297 base types aren't accessible due to access permissions.
11298 * decl.cs (DeclSpace.ResolveType): Move logic to
11299 Expression.ResolveAsTypeTerminal.
11300 (DeclSpace.ResolveTypeExpr): Thin layer over
11301 Expression.ResolveAsTypeTerminal.
11302 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
11303 Refactor code into NestedAccess. Use it.
11304 (DeclSpace.NestedAccess): New.
11305 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
11306 argument to silence errors. Check access permissions.
11307 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
11308 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
11309 (Cast.DoResolve): Likewise.
11310 (New.DoResolve): Likewise.
11311 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
11312 (TypeOf.DoResolve): Likewise.
11314 * expression.cs (Invocation.BetterConversion): Return the Type of
11315 the better conversion. Implement section 14.4.2.3 more faithfully.
11316 (Invocation.BetterFunction): Make boolean. Make correspondence to
11317 section 14.4.2.2 explicit.
11318 (Invocation.OverloadResolve): Update.
11319 (Invocation): Remove is_base field.
11320 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
11321 (Invocation.Emit): Likewise.
11323 2004-09-27 Raja R Harinath <rharinath@novell.com>
11325 * README: Update to changes.
11327 2004-09-24 Marek Safar <marek.safar@seznam.cz>
11329 * cs-parser.jay: Reverted 642 warning fix.
11331 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11334 * decl.cs (FindMemberWithSameName): Indexer can have more than
11337 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11339 * expression.cs (LocalVariableReference.DoResolveLValue):
11340 Do not report warning 219 for out values.
11341 (EmptyExpression.Null): New member to avoid extra allocations.
11343 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11345 * cs-parser.jay: Fix wrong warning 642 report.
11347 * cs-tokenizer.cs (CheckNextToken): New helper;
11348 Inspect next character if is same as expected.
11350 2004-09-23 Martin Baulig <martin@ximian.com>
11352 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
11353 (Convert.ImplicitReferenceConversionExists): Likewise.
11355 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11357 * class.cs (Operator.Define): Add error 448 and 559 report.
11359 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11361 * class.cs (MemberBase.IsTypePermitted): New protected
11362 method for checking error CS0610.
11364 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11366 * class.cs (TypeContainer.HasExplicitLayout): New property
11367 Returns whether container has StructLayout attribute set Explicit.
11368 (FieldMember): New abstract class for consts and fields.
11369 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
11370 (Field): Reuse FieldMember.
11372 * const.cs (Const): Reuse FieldMember.
11374 * rootcontext.cs: EmitConstants call moved to class.
11376 2004-09-22 Martin Baulig <martin@ximian.com>
11378 Thanks to Peter Sestoft for this bug report.
11380 * expression.cs (Conditional): If both the `trueExpr' and the
11381 `falseExpr' is a NullLiteral, return a NullLiteral.
11383 2004-09-22 Martin Baulig <martin@ximian.com>
11385 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
11386 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
11387 for the "get_Current" call.
11389 2004-09-22 Martin Baulig <martin@ximian.com>
11391 Marek and me just fixed one of our oldest bugs: #28562 :-)
11393 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
11395 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
11396 we're an EnumConstant, just return that.
11397 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
11398 an EnumConstant. In this case, we need to use GetValueAsEnumType()
11399 to get the value which'll actually be written into the attribute.
11400 However, we have to use GetValue() to access the attribute's value
11403 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11405 * constant.cs (Constant.IsNegative): New abstract property
11408 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
11409 (StackAlloc.DoResolve): Reused IsNegative.
11411 2004-09-21 Martin Baulig <martin@ximian.com>
11413 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
11414 if we're used in an iterator, we may be called from different
11417 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
11418 we actually have an exception block.
11420 2004-09-20 John Luke <jluke@cfl.rr.com>
11422 * class.cs, cs-parser.jay: Improve the error report for 1520:
11423 report the actual line where the error happens, not where the
11424 class was declared.
11426 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
11427 Pass location information that was available elsewhere.
11429 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
11431 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
11432 runtime to delay sign assemblies.
11434 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11436 * cs-parser.jay: Do not report the stack trace, this is barely
11439 2004-08-22 John Luke <john.luke@gmail.com>
11441 * driver.cs : check that a resource id is not already used
11442 before adding it, report CS1508 if it is, bug #63637
11444 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11446 * ecore.cs: Removed dead code.
11448 2004-09-18 Marek Safar <marek.safar@seznam.cz>
11450 * class.cs: Do not report warning CS0067 on the interfaces.
11452 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11454 * cs-parser.jay: Add error 504 report.
11456 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11458 * rootcontext.cs: WarningLevel is 4 by default now.
11460 * statement.cs (Fixed.Resolve): Do not null
11463 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11466 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
11467 deep search when property is not virtual.
11468 (PropertyExpr.ResolveAccessors): Make one call for both
11471 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11474 * statement.cs: Error 152 report constains also location.
11476 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11479 * const.cs: Explicitly set constant as static.
11481 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11484 * cs-parser.jay: Add error 1017 report.
11486 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11488 Fixed bug #59980, #64224
11489 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
11491 * typemanager.cs (IsSpecialMethod): Simplified
11493 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11495 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11496 condition with better params.
11498 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11501 * attribute.cs (Resolve): Property has to have both
11504 2004-09-14 Martin Baulig <martin@ximian.com>
11506 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
11508 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11511 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
11512 called and is obsolete then this member suppress message
11513 when call is inside next [Obsolete] method or type.
11515 * expression.cs: Use TestObsoleteMethodUsage member.
11517 2004-09-14 Martin Baulig <martin@ximian.com>
11519 * cs-parser.jay: Sync a bit with the GMCS version.
11521 2004-09-14 Martin Baulig <martin@ximian.com>
11523 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
11524 (CSharpParser.yacc_verbose_flag): New public field.
11526 * genericparser.cs: Removed.
11528 2004-09-14 Raja R Harinath <rharinath@novell.com>
11530 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
11532 2004-09-13 Marek Safar <marek.safar@seznam.cz>
11534 * class.cs (MethodCore.CheckBase): Fix bug #65757.
11536 2004-09-10 Martin Baulig <martin@ximian.com>
11538 Backported my MemberName changes from GMCS into MCS.
11540 - we are now using a special `MemberName' class instead of using
11541 strings; in GMCS, the `MemberName' also contains the type
11544 - changed the grammar rules a bit:
11545 * the old `member_name' is now a `namespace_or_type_name':
11546 The rule is that we use `namespace_or_type_name' everywhere
11547 where we expect either a "member name" (GetEnumerator) or a
11548 "member name" with an explicit interface name
11549 (IEnumerable.GetEnumerator).
11550 In GMCS, the explicit interface name may include type arguments
11551 (IEnumerable<T>.GetEnumerator).
11552 * we use `member_name' instead of just `IDENTIFIER' for
11554 The rule is that we use `member_name' wherever a member may
11555 have type parameters in GMCS.
11557 * decl.cs (MemberName): New public class.
11558 (MemberCore.MemberName): New public readonly field.
11559 (MemberCore.ctor): Take a `MemberName' argument, not a string.
11560 (DeclSpace): Likewise.
11562 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
11563 * enum.cs (Enum.ctor): Likewise.
11565 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
11567 (AliasEntry.ctor): Take a MemberName, not an Expression.
11568 (AliasEntry.UsingAlias): Likewise.
11570 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
11571 (IMethodData.MemberName): Changed type from string to MemberName.
11572 (MemberBase.ExplicitInterfaceName): Likewise.
11573 (AbstractPropertyEventMethod.SetupName): Make this private.
11574 (AbstractPropertyEventMethod.ctor): Added `string prefix'
11575 argument; compute the member name here.
11576 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
11577 on the `member.MemberName' and the `prefix'.
11579 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
11581 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
11582 thus, we get a `MemberName' instead of a `string'. These
11583 declarations may have type parameters in GMCS.
11584 (interface_method_declaration, delegate_declaration): Likewise.
11585 (class_declaration, interface_declaration): Likewise.
11586 (method_header): Use `namespace_or_type_name' instead of
11587 `member_name'. We may be an explicit interface implementation.
11588 (property_declaration, event_declaration): Likewise.
11589 (member_name): This is now just an `IDENTIFIER', not a
11590 `namespace_or_type_name'.
11591 (type_name, interface_type): Removed.
11592 (namespace_or_type_name): Return a MemberName, not an Expression.
11593 (primary_expression): Use `member_name' instead of `IDENTIFIER';
11594 call GetTypeExpression() on the MemberName to get an expression.
11595 (IndexerDeclaration.interface_type): Changed type from string to
11597 (MakeName): Operate on MemberName's instead of string's.
11599 2004-09-13 Raja R Harinath <rharinath@novell.com>
11602 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
11603 (NamespaceEntry.Lookup): Add new argument to flag if we want the
11604 lookup to avoid symbols introduced by 'using'.
11605 * rootcontext.cs (NamespaceLookup): Update.
11607 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11609 * class.cs (TypeContainer.DoDefineMembers): Do not call
11610 DefineDefaultConstructor for static classes.
11612 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11614 * attribute.cs (Attribute.Resolve): Add error 653 report.
11616 * class.cs (Class.ApplyAttributeBuilder): Add error 641
11618 (Method.ApplyAttributeBuilder): Add error 685 report.
11619 (Operator.Define): Add error 564 report.
11621 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
11623 * expression.cs (Invocation.DoResolve): Add error
11624 245 and 250 report.
11626 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
11629 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11631 * class.cs (ConstructorInitializer.Resolve):
11632 Wrong error number (515->516).
11634 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11636 * class.cs (Indexer.Define): Add error 631 report.
11638 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11640 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
11642 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11644 * expression.cs (Probe.DoResolve): Add error CS0241 report.
11646 2004-09-10 Marek Safar <marek.safar@seznam.cz>
11648 * cs-parser.jay: Added error CS0241 report.
11650 2004-09-10 Raja R Harinath <rharinath@novell.com>
11652 * cs-parser.jay (fixed_statement): Introduce a scope for the
11653 declaration in the 'fixed' statement.
11655 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11657 * cs-parser.jay: Added CS0230 error report.
11659 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11661 * cs-parser.jay: Added errors CS0231 and CS0257 report.
11663 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11665 * expression.cs (Argument.Resolve): Added error CS0192 and
11668 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11670 C# 2.0 #pragma warning feature
11672 * cs-tokenizer.cs (PreProcessPragma): New method;
11673 Handles #pragma directive.
11675 * report.cs (WarningRegions): New class; Support
11676 class for #pragma warning directive. It tests whether
11677 warning is enabled for a given line.
11679 2004-09-08 Miguel de Icaza <miguel@ximian.com>
11681 * const.cs: Add more descriptive error report, tahnks to
11684 2004-09-08 Marek Safar <marek.safar@seznam.cz>
11686 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
11688 2004-09-07 Miguel de Icaza <miguel@ximian.com>
11690 * expression.cs: Apply patch from Ben: Remove dead code from
11691 ArrayCreation, and remove the TurnintoConstant call in const.cs,
11692 as that code just threw an exception anwyays.
11694 * const.cs: Remove the call to the turnintoconstant, for details
11697 * literal.cs: The type of the null-literal is the null type; So
11698 we use a placeholder type (literal.cs:System.Null, defined here)
11701 * expression.cs (Conditional.DoResolve): Remove some old code that
11702 is no longer needed, conversions have been fixed.
11704 (ArrayCreationExpression.DoResolve): Return false if we fail to
11705 resolve the inner expression.
11707 2004-09-07 Raja R Harinath <rharinath@novell.com>
11710 * cs-parser.jay (delegate_declaration): Record a delegate
11711 declaration as a type declaration.
11712 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
11714 2004-09-06 Miguel de Icaza <miguel@ximian.com>
11716 * parameter.cs: Do not crash if the type can not be resolved.
11718 * expression.cs: Report errors with unsafe pointers, fixes #64896
11720 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
11722 * expression.cs: Pointer arith always needs to do a conv.i
11723 if the operand is a long. fix 65320
11725 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11727 Fixed cs0619-37.cs, cs0619-38.cs
11729 * enum.cs (GetObsoleteAttribute): Removed.
11731 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
11732 on Enum member is double staged. The first is tested member
11735 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11737 Fixed #56986, #63631, #65231
11739 * class.cs: (TypeContainer.AddToMemberContainer): New method,
11740 adds member to name container.
11741 (TypeContainer.AddToTypeContainer): New method, adds type to
11743 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
11744 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
11745 AddOperator): Simplified by reusing AddToMemberContainer.
11746 (TypeContainer.UserDefinedStaticConstructor): Changed to property
11748 (Method.CheckForDuplications): Fixed implementation to test all
11750 (MemberBase): Detection whether member is explicit interface
11751 implementation is now in constructor.
11752 (MemberBase.UpdateMemberName): Handles IndexerName.
11753 (Accessor): Changed to keep also location information.
11754 (AbstractPropertyEventMethod): Is derived from MemberCore.
11755 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
11756 will be emited or not.
11757 (PropertyBase.AreAccessorsDuplicateImplementation):
11758 Tests whether accessors are not in collision with some method.
11759 (Operator): Is derived from MethodCore to simplify common
11762 * decl.cs (Flags.TestMethodDuplication): Test for duplication
11764 (DeclSpace.AddToContainer): Adds the member to defined_names
11765 table. It tests for duplications and enclosing name conflicts.
11767 * enum.cs (EnumMember): Clean up to reuse the base structures
11769 2004-09-03 Martin Baulig <martin@ximian.com>
11771 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
11772 into TypeContainer, to make partial classes work again.
11774 2004-09-03 Martin Baulig <martin@ximian.com>
11776 * rootcontext.cs (RootContext.V2): Removed.
11778 2004-03-23 Martin Baulig <martin@ximian.com>
11780 * expression.cs (Invocation.OverloadResolve): Added `bool
11781 may_fail' argument and use it instead of the Location.IsNull() hack.
11783 2004-09-03 Martin Baulig <martin@ximian.com>
11785 Merged latest changes into gmcs. Please keep this comment in
11786 here, it makes it easier for me to see what changed in MCS since
11787 the last time I merged.
11789 2004-09-03 Raja R Harinath <rharinath@novell.com>
11792 * expression.cs (BetterConversion): Don't allow either conversion
11793 to be null. Remove redundant implicit conversion test when 'q ==
11794 null' -- when this function is invoked, we already know that the
11795 implicit conversion exists.
11796 (BetterFunction): Assume that 'best' is non-null. Remove
11797 redundant reimplementation of IsApplicable when 'best' is null.
11798 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
11799 number of arguments.
11800 (IsAncestralType): Extract from OverloadResolve.
11801 (OverloadResolve): Make robust to the MethodGroupExpr being
11802 unsorted. Implement all the logic of Section 14.5.5.1, and
11803 support overloading of methods from multiple applicable types.
11804 Clean up logic somewhat. Don't pass null methods to BetterFunction.
11806 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
11807 (RealError, Warning): Append type of report to related symbol.
11809 2004-09-03 Marek Safar <marek.safar@seznam.cz>
11811 * enum.cs: Fixed CLS-Compliance checks for enum members.
11812 Error tests cs3008-8.cs, cs3014-8.cs
11814 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11816 Fixed bug #62342, #63102
11817 * class.cs: ImplementIndexer uses member.IsExplicitImpl
11818 like ImplementMethod.
11820 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11822 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11825 2004-09-02 Martin Baulig <martin@ximian.com>
11827 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
11828 TypeManager.GetArgumentTypes() rather than calling GetParameters()
11831 2004-09-01 Marek Safar <marek.safar@seznam.cz>
11833 C# 2.0 Static classes implemented
11835 * class.cs (TypeContainer): instance_constructors,
11836 initialized_fields, initialized_static_fields,
11837 default_constructor, base_inteface_types are protected to be
11838 accessible from StaticClass.
11839 (TypeContainer.DefineDefaultConstructor): New virtual method
11840 for custom default constructor generating
11841 (StaticClass): New class to handle "Static classes" feature.
11843 * cs-parser.jay: Handle static keyword on class like instance
11846 * driver.cs: Added "/langversion" command line switch with two
11847 options (iso-1, default).
11849 2004-08-31 Marek Safar <marek.safar@seznam.cz>
11851 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
11853 2004-08-31 Miguel de Icaza <miguel@ximian.com>
11855 * delegate.cs: Style.
11857 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
11859 * delegate.cs: Add seperate instance expr field for miguel.
11861 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11863 * PointerArithmetic (Resolve): make sure we are not doing
11864 pointer arith on void*. Also, make sure we are resolved
11865 by not setting eclass until resolve.
11867 All callers: Make sure that PointerArithmetic gets resolved.
11869 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11871 * ArrayCreation (LookupType): If the type does not resolve
11872 to an array, give an error.
11874 2004-08-27 Marek Safar <marek.safar@seznam.cz>
11876 * statement.cs (Try.Resolve): Fixed bug #64222
11878 2004-08-27 Martin Baulig <martin@ximian.com>
11881 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
11884 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11886 * ecore.cs (Constantify): Get underlying type via
11887 System.Enum.GetUnderlyingType to avoid StackOverflow on the
11888 Windows in special cases.
11890 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11892 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
11893 for obtaining also private methods.
11894 (GetRemoveMethod): Used GetRemoveMethod (true)
11895 for obtaining also private methods.
11897 2004-08-24 Martin Baulig <martin@ximian.com>
11899 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
11900 MethodAttributes.HideBySig for operators.
11902 2004-08-23 Martin Baulig <martin@ximian.com>
11904 Back to the old error reporting system :-)
11906 * report.cs (Message): Removed.
11907 (Report.MessageData, ErrorData, WarningData): Removed.
11908 (Report.Error, Warning): Back to the old system.
11910 2004-08-23 Martin Baulig <martin@ximian.com>
11912 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
11914 * class.cs (TypeContainer.ParentContainer): New public virtual
11915 method; replaces the explicit interface implementation.
11916 (ClassPart.ParentContainer): Override.
11918 2004-08-23 Martin Baulig <martin@ximian.com>
11920 * statement.cs (Switch): Added support for constant switches; see
11921 #59428 or test-285.cs.
11923 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11926 * statement.cs (GetEnumeratorFilter): Removed useless
11927 logic because C# specs is strict. GetEnumerator must be
11930 2004-08-22 Martin Baulig <martin@ximian.com>
11932 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11933 a switch and may break, reset the barrier. Fixes #59867.
11935 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11937 CLS-Compliance speed up (~5% for corlib)
11939 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
11940 New method. Tests container for CLS-Compliant names
11942 * class.cs (TypeContainer.VerifyClsName): New method.
11943 Checks whether container name is CLS Compliant.
11944 (Constructor): Implements IMethodData.
11946 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
11947 low-case table for CLS Compliance test.
11948 (MemberCache.VerifyClsParameterConflict): New method.
11949 Checks method parameters for CS3006 error.
11951 * enum.cs (EnumMember): Is derived from MemberCore.
11952 (Enum.VerifyClsName): Optimized for better performance.
11954 2004-08-06 Marek Safar <marek.safar@seznam.cz>
11956 * report.cs: Renamed Error_T to Error and changed all
11959 2004-08-06 Marek Safar <marek.safar@seznam.cz>
11961 * class.cs (TypeContainer.IndexerArrayList): New inner class
11962 container for indexers.
11963 (TypeContainer.DefaultIndexerName): New constant for default
11964 indexer name. Replaced all "Item" with this constant.
11965 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
11967 * typemanager.cs (TypeManager.default_member_ctor): Cache here
11968 DefaultMemberAttribute constructor.
11970 2004-08-05 Martin Baulig <martin@ximian.com>
11972 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
11975 2004-08-05 Marek Safar <marek.safar@seznam.cz>
11977 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
11978 multi platforms problem.
11980 * compiler.csproj: Included shared files.
11982 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11984 Fix bug 60333, 55971 in the more general way
11985 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11986 Added arg_type argument for constant conversion.
11987 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
11989 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11992 * class.cs (TypeContainer ): New inner classes MethodArrayList,
11993 OperatorArrayList, MethodCoreArrayList for typecontainer
11994 containers. Changed class member types to these new types.
11995 (MethodArrayList.DefineMembers): Added test for CS0659.
11997 2004-08-04 Miguel de Icaza <miguel@ximian.com>
11999 * cfold.cs: Synchronize the folding with the code in expression.cs
12000 Binary.DoNumericPromotions for uint operands.
12002 * attribute.cs: Revert patch from Raja, it introduced a regression
12003 while building Blam-1.2.1 (hard to isolate a test case).
12005 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12009 (TypeContainer.Define): Renamed to DefineContainerMembers because of
12011 (MethodCore.parent_method): New member. The method we're overriding
12012 if this is an override method.
12013 (MethodCore.CheckBase): Moved from Method class and made common.
12014 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
12016 (MethodCore.CheckForDuplications): New abstract method. For custom
12017 member duplication search in a container
12018 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
12019 method and its return type.
12020 (Event.conflict_symbol): New member. Symbol with same name in the
12024 (MemberCache.FindMemberWithSameName): New method. The method
12025 is looking for conflict with inherited symbols.
12027 2004-08-04 Martin Baulig <martin@ximian.com>
12029 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
12031 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
12033 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12035 * report.cs (Message): New enum for better error, warning reference in
12037 (MessageData): New inner abstract class. It generally handles printing of
12038 error and warning messages.
12039 Removed unused Error, Warning, Message methods.
12041 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12043 Fix for cs0592-8.cs test
12045 (Attributable.ValidAttributeTargets): Made public.
12046 (Attribute.ExplicitTarget): New member for explicit target value.
12047 (Attribute.CheckTargets): Now we translate explicit attribute
12048 target to Target here.
12050 2004-08-03 Ben Maurer <bmaurer@ximian.com>
12052 * ecore.cs (MethodGroupExpr): new IsBase property.
12054 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12056 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12057 rather than an instance expr.
12059 (DelegateCreation.Emit): Use the method group rather than
12060 the instance expression. Also, if you have base.Foo as the
12061 method for a delegate, make sure to emit ldftn, not ldftnvirt.
12063 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
12065 (NewDelegate.DoResolve): Only check for the existance of Invoke
12066 if the method is going to be needed. Use MethodGroupExpr.
12068 (NewDelegate.Emit): Remove, DelegateCreation implements this.
12070 * expression.cs: For pointer arith., make sure to use
12071 the size of the type, not the size of the pointer to
12074 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12077 * class.cs (Class): Added error CS0502 test.
12079 2004-08-03 John Luke <jluke@cfl.rr.com>
12080 Raja R Harinath <rharinath@novell.com>
12083 * attribute.cs (Attribute.complained_before): New flag.
12084 (Attribute.ResolveType, Attribute.Resolve),
12085 (Attribute.DefinePInvokeMethod): Set it.
12086 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
12088 2004-08-03 Martin Baulig <martin@ximian.com>
12090 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
12091 use a user-defined operator; we still need to do numeric
12092 promotions in case one argument is a builtin type and the other
12093 one has an implicit conversion to that type. Fixes #62322.
12095 2004-08-02 Martin Baulig <martin@ximian.com>
12097 * statement.cs (LocalInfo.Flags): Added `IsThis'.
12098 (LocalInfo.IsThis): New public property.
12099 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
12101 2004-08-01 Martin Baulig <martin@ximian.com>
12103 * class.cs (TypeContainer.GetClassBases): Don't set the default
12104 here since we may get called from GetPartialBases().
12105 (TypeContainer.DefineType): If GetClassBases() didn't return a
12106 parent, use the default one.
12108 2004-07-30 Duncan Mak <duncan@ximian.com>
12110 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
12112 2004-07-30 Martin Baulig <martin@ximian.com>
12114 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
12116 * class.cs (SourceMethod): New public class, derive from the
12117 symbol writer's ISourceMethod.
12118 (Method): Use the new symbol writer API.
12120 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
12121 as argument and use the new symbol writer.
12124 (SourceFile): Implement the symbol writer's ISourceFile.
12125 (Location.SymbolDocument): Removed.
12126 (Location.SourceFile): New public property.
12128 * symbolwriter.cs: Use the new symbol writer API.
12130 2004-07-30 Raja R Harinath <rharinath@novell.com>
12132 * Makefile (install-local): Remove. Functionality moved to
12135 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
12137 * Makefile: Install mcs.exe.config file together with mcs.exe.
12138 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
12139 correct runtime version.
12141 2004-07-25 Martin Baulig <martin@ximian.com>
12144 (TypeContainer.RegisterOrder): Removed, this was unused.
12145 (TypeContainer, interface_order): Removed.
12146 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
12147 TypeContainer as argument since we can also be called with a
12148 `PartialContainer' for a partial class/struct/interface.
12149 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
12150 of checking whether we're an `Interface' - we could be a
12151 `PartialContainer'.
12152 (PartialContainer.Register): Override; call
12153 AddClass()/AddStruct()/AddInterface() on our parent.
12155 * cs-parser.jay (interface_member_declaration): Add things to the
12156 `current_container', not the `current_class'.
12158 * rootcontext.cs (RegisterOrder): The overloaded version which
12159 takes an `Interface' was unused, removed.
12161 * typemanager.cs (TypeManager.LookupInterface): Return a
12162 `TypeContainer', not an `Interface'.
12163 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
12164 contain a `PartialContainer' for an interface, so check it's
12165 `Kind' to figure out what it is.
12167 2004-07-25 Martin Baulig <martin@ximian.com>
12169 * class.cs (Class.DefaultTypeAttributes): New public constant.
12170 (Struct.DefaultTypeAttributes): Likewise.
12171 (Interface.DefaultTypeAttributes): Likewise.
12172 (PartialContainer.TypeAttr): Override this and add the
12173 DefaultTypeAttributes.
12175 2004-07-25 Martin Baulig <martin@ximian.com>
12177 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
12178 we can just use the `Parent' field instead.
12180 2004-07-25 Martin Baulig <martin@ximian.com>
12182 * class.cs (TypeContainer.Emit): Renamed to EmitType().
12184 2004-07-25 Martin Baulig <martin@ximian.com>
12186 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
12187 our parts before defining any methods.
12188 (TypeContainer.VerifyImplements): Make this virtual.
12189 (ClassPart.VerifyImplements): Override and call VerifyImplements()
12190 on our PartialContainer.
12192 2004-07-25 Martin Baulig <martin@ximian.com>
12194 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
12196 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
12197 argument, we can just use the `Parent' field instead.
12200 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
12201 (MemberBase.DoDefine): Likewise.
12203 2004-07-24 Martin Baulig <martin@ximian.com>
12205 * decl.cs (MemberCore.Parent): New public field.
12206 (DeclSpace.Parent): Moved to MemberCore.
12208 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
12209 (MemberBase.ctor): Added TypeContainer argument, pass it to our
12211 (FieldBase, Field, Operator): Likewise.
12212 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
12213 (EventField, Event): Likewise.
12215 2004-07-23 Martin Baulig <martin@ximian.com>
12217 * class.cs (PartialContainer): New public class.
12218 (ClassPart): New public class.
12219 (TypeContainer): Added support for partial classes.
12220 (TypeContainer.GetClassBases): Splitted some of the functionality
12221 out into GetNormalBases() and GetPartialBases().
12223 * cs-tokenizer.cs (Token.PARTIAL): New token.
12224 (Tokenizer.consume_identifier): Added some hacks to recognize
12225 `partial', but only if it's immediately followed by `class',
12226 `struct' or `interface'.
12228 * cs-parser.jay: Added support for partial clases.
12230 2004-07-23 Martin Baulig <martin@ximian.com>
12232 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
12233 a `DeclSpace' and also made it readonly.
12234 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
12235 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
12236 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
12238 * cs-parser.jay: Pass the `current_class', not the
12239 `current_container' (at the moment, this is still the same thing)
12240 to a new Method, Property, Event, Indexer or Constructor.
12242 2004-07-23 Martin Baulig <martin@ximian.com>
12244 * cs-parser.jay (CSharpParser): Added a new `current_class' field
12245 and removed the `current_interface' one.
12246 (struct_declaration, class_declaration, interface_declaration):
12247 Set `current_class' to the newly created class/struct/interface;
12248 set their `Bases' and call Register() before parsing their body.
12250 2004-07-23 Martin Baulig <martin@ximian.com>
12252 * class.cs (Kind): New public enum.
12253 (TypeContainer): Made this class abstract.
12254 (TypeContainer.Kind): New public readonly field.
12255 (TypeContainer.CheckDef): New public method; moved here from
12257 (TypeContainer.Register): New public abstract method.
12258 (TypeContainer.GetPendingImplementations): New public abstract
12260 (TypeContainer.GetClassBases): Removed the `is_class' and
12261 `is_iface' parameters.
12262 (TypeContainer.DefineNestedTypes): Formerly known as
12264 (ClassOrStruct): Made this class abstract.
12266 * tree.cs (RootTypes): New public type.
12268 2004-07-20 Martin Baulig <martin@ximian.com>
12270 * tree.cs (Tree.RecordNamespace): Removed.
12271 (Tree.Namespaces): Removed.
12273 * rootcontext.cs (RootContext.IsNamespace): Removed.
12275 * cs-parser.jay (namespace_declaration): Just create a new
12276 NamespaceEntry here.
12278 2004-07-20 Martin Baulig <martin@ximian.com>
12280 * statement.cs (ExceptionStatement): New abstract class. This is
12281 now used as a base class for everyone who's using `finally'.
12282 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
12283 our local variables before using them.
12285 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
12286 virtual method. This is used by Yield.Resolve() to "steal" an
12287 outer block's `finally' clauses.
12288 (FlowBranchingException): The .ctor now takes an ExceptionStatement
12291 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
12292 version which takes an ExceptionStatement. This version must be
12293 used to create exception branchings.
12296 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
12297 (Iterator.EmitMoveNext): Added exception support; protect the
12298 block with a `fault' clause, properly handle 'finally' clauses.
12299 (Iterator.EmitDispose): Run all the `finally' clauses here.
12301 2004-07-20 Martin Baulig <martin@ximian.com>
12303 * iterator.cs: This is the first of a set of changes in the
12304 iterator code. Match the spec more closely: if we're an
12305 IEnumerable, then GetEnumerator() must be called. The first time
12306 GetEnumerator() is called, it returns the current instance; all
12307 subsequent invocations (if any) must create a copy.
12309 2004-07-19 Miguel de Icaza <miguel@ximian.com>
12311 * expression.cs: Resolve the constant expression before returning
12314 2004-07-19 Martin Baulig <martin@ximian.com>
12316 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
12317 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
12318 the return type of the new EmitContext.
12320 2004-07-18 Martin Baulig <martin@ximian.com>
12322 * class.cs (Property.Define): Fix iterators.
12324 * iterators.cs (Iterator.Define): Moved the
12325 `container.AddInterator (this)' call here from the .ctor; only do
12326 it if we resolved successfully.
12328 2004-07-17 Miguel de Icaza <miguel@ximian.com>
12330 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
12331 `true' for preprocessing directives that we parse. The return
12332 value indicates whether we should return to regular tokenizing or
12333 not, not whether it was parsed successfully.
12335 In the past if we were in: #if false ... #line #endif, we would
12336 resume parsing after `#line'. See bug 61604.
12338 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
12339 building: IsEnumType should return true only for enums, not for
12340 enums or System.Enum itself. This fixes #61593.
12342 Likely what happened is that corlib was wrong: mcs depended on
12343 this bug in some places. The bug got fixed, we had to add the
12344 hack, which caused bug 61593.
12346 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
12347 that was a workaround for the older conditions.
12349 2004-07-16 Ben Maurer <bmaurer@ximian.com>
12351 * assign.cs: IAssignMethod has a new interface, as documented
12352 inline. All assignment code now uses this new api.
12354 * ecore.cs, expression.cs: All classes which implement
12355 IAssignMethod now use the new interface.
12357 * expression.cs (Invocation): add a hack to EmitCall so that
12358 IndexerAccess can be the target of a compound assignment without
12359 evaluating its arguments twice.
12361 * statement.cs: Handle changes in Invocation api.
12363 2004-07-16 Martin Baulig <martin@ximian.com>
12365 * iterators.cs: Rewrote this. We're now using one single Proxy
12366 class for both the IEnumerable and the IEnumerator interface and
12367 `Iterator' derives from Class so we can use the high-level API.
12369 * class.cs (TypeContainer.AddIterator): New method.
12370 (TypeContainer.DoDefineType): New protected virtual method, which
12371 is called from DefineType().
12372 (TypeContainer.DoDefineMembers): Call DefineType() and
12373 DefineMembers() on all our iterators.
12374 (TypeContainer.Emit): Call Emit() on all our iterators.
12375 (TypeContainer.CloseType): Call CloseType() on all our iterators.
12377 * codegen.cs (EmitContext.CurrentIterator): New public field.
12379 2004-07-15 Martin Baulig <martin@ximian.com>
12382 (TypeManager.not_supported_exception_type): New type.
12384 2004-07-14 Martin Baulig <martin@ximian.com>
12386 * iterators.cs: Use real error numbers.
12388 2004-07-14 Martin Baulig <martin@ximian.com>
12390 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
12391 requires this to be a System.Collection.IEnumerable and not a
12392 class implementing that interface.
12393 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
12395 2004-07-13 Marek Safar <marek.safar@seznam.cz>
12397 * class.cs: Fixed previous fix, it broke some error tests.
12399 2004-07-12 Martin Baulig <martin@ximian.com>
12401 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
12404 2004-07-09 Miguel de Icaza <miguel@ximian.com>
12406 * assign.cs (LocalTemporary): Add new argument: is_address,If
12407 `is_address' is true, then the value that we store is the address
12408 to the real value, and not the value itself.
12410 * ecore.cs (PropertyExpr): use the new local temporary
12411 stuff to allow us to handle X.Y += z (where X is a struct)
12413 2004-07-08 Martin Baulig <martin@ximian.com>
12415 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
12416 not always return, just like we're doing in Using.Resolve().
12418 2004-07-07 Miguel de Icaza <miguel@ximian.com>
12420 * cs-parser.jay (fixed_statement): flag this as Pinned.
12422 2004-07-06 Miguel de Icaza <miguel@ximian.com>
12424 * typemanager.cs (TypeManager): Removed MakePinned method, this
12425 mechanism is replaced with the .NET 2.x compatible mechanism of
12426 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
12428 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
12429 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
12430 `IsFixed' property which has a different meaning.
12432 2004-07-02 Raja R Harinath <rharinath@novell.com>
12434 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
12435 visible from inside a nested class, not just the names of the
12436 immediately enclosing class.
12437 Fix for bug #60730.
12439 2004-06-24 Raja R Harinath <rharinath@novell.com>
12441 * expression.cs (BetterConversion): Remove buggy special-case
12442 handling of "implicit constant expression conversions". At this
12443 point, we already know that the conversion is possible -- we're
12444 only checking to see which is better.
12446 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12448 * cs-parser.jay: Added error CS0210 test.
12450 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12452 * cs-parser.jay: Added error CS0134 test.
12454 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12457 * cs-parser.jay: Added error CS0145 test.
12459 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12461 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
12463 2004-06-23 Ben Maurer <bmaurer@ximian.com>
12465 * expression.cs (StackAlloc.Resolve): The argument may not
12466 be a constant; deal with this case.
12468 2004-06-23 Marek Safar <marek.safar@seznam.cz>
12470 * attribute.cs (IndexerName_GetIndexerName): Renamed to
12471 GetIndexerAttributeValue.
12472 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
12474 * class.cs (Indexer.Define): Added error tests for CS0415,
12477 2004-06-23 Miguel de Icaza <miguel@ximian.com>
12479 * attribute.cs (Attribute.Resolve): Keep field code in sync with
12482 2004-06-23 Martin Baulig <martin@ximian.com>
12484 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
12485 neither return nor throw, reset the barrier as well. Fixes #60457.
12487 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
12489 * class.cs : EventAttributes is now set to None by default.
12490 This fixes bug #60459.
12492 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12495 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12496 Don't throw exception but return null (it's sufficient now).
12498 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12500 * typemanager.cs (GetArgumentTypes): Faster implementation.
12502 2004-06-18 Martin Baulig <martin@ximian.com>
12504 * attribute.cs (Attribute.Resolve): Check whether we're an
12505 EmptyCast which a Constant child. Fixes #60333.
12507 2004-06-17 Ben Maurer <bmaurer@ximian.com>
12509 * statement.cs (EmitCollectionForeach): Account for the fact that
12510 not all valuetypes are in areas which we can take the address of.
12511 For these variables, we store to a temporary variable. Also, make
12512 sure that we dont emit a `callvirt' on a valuetype method.
12514 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12516 * expression.cs (StackAlloc.DoReSolve): Added test for
12517 negative parameter (CS0247).
12519 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12522 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
12524 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12527 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
12530 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12532 Fix bug #58254 & cs1555.cs, cs1556.cs
12533 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
12535 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12537 * cs-parser.jay: Added error CS1669 test for indexers.
12539 2004-06-11 Martin Baulig <martin@ximian.com>
12541 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
12542 call this twice: for params and varargs methods.
12544 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12547 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
12549 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12551 * attribute.cs (Attribute.GetValidTargets): Made public.
12554 (AbstractPropertyEventMethod): New class for better code sharing.
12555 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
12557 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
12559 2004-06-11 Raja R Harinath <rharinath@novell.com>
12562 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
12563 that the call to Resolve is part of a MemberAccess.
12564 (Expression.Resolve): Use it for SimpleName resolution.
12565 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
12566 Add 'intermediate' boolean argument.
12567 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
12568 error message when the SimpleName can be resolved ambiguously
12569 between an expression and a type.
12570 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
12572 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
12573 call on the left-side.
12575 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12578 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
12580 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12582 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
12584 2004-06-11 Martin Baulig <martin@ximian.com>
12586 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
12587 varargs methods if applicable.
12589 2004-06-11 Martin Baulig <martin@ximian.com>
12591 * expression.cs (Invocation.EmitCall): Don't use
12592 `method.CallingConvention == CallingConventions.VarArgs' since the
12593 method could also have `CallingConventions.HasThis'.
12595 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12597 * class.cs (Event.GetSignatureForError): Implemented.
12598 Fixed crash in error test cs3010.cs
12600 2004-06-10 Miguel de Icaza <miguel@ximian.com>
12602 * cs-tokenizer.cs: Change the way we track __arglist to be
12603 consistent with the other keywords.
12605 2004-06-09 Miguel de Icaza <miguel@ximian.com>
12607 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
12610 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
12612 * codegen.cs: Check that all referenced assemblies have a strongname
12613 before strongnaming the compiled assembly. If not report error CS1577.
12614 Fix bug #56563. Patch by Jackson Harper.
12615 * typemanager.cs: Added a method to return all referenced assemblies.
12616 Fix bug #56563. Patch by Jackson Harper.
12618 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12621 (Method.ApplyAttributeBuilder): Moved and added conditional
12622 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
12625 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
12627 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12630 * class.cs: (EventField.attribute_targets): Changed default target.
12632 2004-06-08 Martin Baulig <martin@ximian.com>
12634 * expression.cs (Invocation.EmitCall): Enable varargs methods.
12636 2004-06-08 Martin Baulig <martin@ximian.com>
12638 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
12640 2004-06-07 Martin Baulig <martin@ximian.com>
12642 Added support for varargs methods.
12644 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
12647 * cs-parser.jay: Added support for `__arglist'.
12649 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
12651 * expression.cs (Argument.AType): Added `ArgList'.
12652 (Invocation): Added support for varargs methods.
12653 (ArglistAccess): New public class.
12654 (Arglist): New public class.
12656 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
12658 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
12659 a method's top-level block if the method has varargs.
12661 * support.cs (ReflectionParameters, InternalParameters): Added
12662 support for varargs methods.
12664 2004-06-07 Miguel de Icaza <miguel@ximian.com>
12666 * class.cs: Provide location in indexer error report.
12668 * driver.cs: Use standard names.
12670 * namespace.cs: Catch the use of using after a namespace has been
12671 declared also on using aliases.
12673 2004-06-03 Raja R Harinath <rharinath@novell.com>
12676 * typemanager.cs (closure_private_ok, closure_invocation_type)
12677 (closure_qualifier_type, closure_invocation_assembly)
12678 (FilterWithClosure): Move to ...
12679 (Closure): New internal nested class.
12680 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
12681 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
12682 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
12683 (MemberLookup, MemberLookupFailed): Use it.
12684 * expression.cs (New.DoResolve): Treat the lookup for the
12685 constructor as being qualified by the 'new'ed type.
12686 (Indexers.GetIndexersForTypeOrInterface): Update.
12688 2004-06-03 Marek Safar <marek.safar@seznam.cz>
12691 (GetConditionalAttributeValue): New method. Returns
12692 condition of ConditionalAttribute.
12693 (SearchMulti): New method. Returns all attributes of type 't'.
12694 Use it when attribute is AllowMultiple = true.
12695 (IsConditionalMethodExcluded): New method.
12698 (Method.IsExcluded): Implemented. Returns true if method has conditional
12699 attribute and the conditions is not defined (method is excluded).
12700 (IMethodData): Extended interface for ConditionalAttribute support.
12701 (PropertyMethod.IsExcluded): Implemented.
12704 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
12707 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
12710 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
12712 * expression.cs (ArrayCreationExpression): Make this just an
12713 `expression'. It can't be a statement, so the code here was
12716 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12719 * typemanager.cs (GetFullNameSignature): New method for
12722 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12725 * class.cs (MemberBase.GetSignatureForError): New virtual method.
12726 Use this method when MethodBuilder is null.
12727 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
12728 Added test for error CS0626 (MONO reports error for this situation).
12729 (IMethodData.GetSignatureForError): Extended interface.
12731 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12734 (AttributeTester.GetObsoleteAttribute): Returns instance of
12735 ObsoleteAttribute when type is obsolete.
12738 (TypeContainer.VerifyObsoleteAttribute): Override.
12739 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
12740 (MethodCode.VerifyObsoleteAttribute): Override.
12741 (MemberBase.VerifyObsoleteAttribute): Override.
12744 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
12745 and report proper error.
12748 Delegate.VerifyObsoleteAttribute): Override.
12751 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
12752 and report proper error.
12753 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
12756 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
12760 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
12761 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
12762 Added test for ObsoleteAttribute.
12765 (Catch): Derived from Statement.
12767 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12769 Fixed bug #59071 & cs0160.cs
12771 * statement.cs (Try.Resolve): Check here whether order of catch
12772 clauses matches their dependencies.
12774 2004-05-31 Miguel de Icaza <miguel@ximian.com>
12776 * Reverted patch to namespace.cs (Use lookuptypedirect). This
12777 caused a regression: #59343. Referencing nested classes from an
12778 assembly stopped working.
12780 2004-05-31 Martin Baulig <martin@ximian.com>
12782 MCS is now frozen for beta 2.
12784 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12786 * convert.cs: add a trivial cache for overload operator resolution.
12788 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12790 * decl.cs: If possible, use lookuptypedirect here. We can only do
12791 this if there is no `.' after the namespace. Avoids using
12792 LookupType, which does lots of slow processing.
12793 (FindNestedType) New method, does what it says :-).
12794 * namespace.cs: use LookupTypeDirect.
12795 * rootcontext.cs: use membercache, if possible.
12796 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
12798 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12801 According to the spec,
12803 In a member access of the form E.I, if E is a single identifier,
12804 and if the meaning of E as a simple-name (§7.5.2) is a constant,
12805 field, property, localvariable, or parameter with the same type as
12806 the meaning of E as a type-name (§3.8), then both possible
12807 meanings of E are permitted.
12809 We did not check that E as a simple-name had the same type as E as
12812 This trivial check gives us 5-7% on bootstrap time.
12814 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12816 * expression.cs (Invocation.OverloadResolve): Avoid the
12817 use of hashtables and boxing here by allocating on demand.
12819 2004-05-30 Martin Baulig <martin@ximian.com>
12821 * rootcontext.cs (RootContext.LookupType): Don't cache things if
12822 we're doing a silent lookup. Don't try to lookup nested types in
12823 TypeManager.object_type (thanks to Ben Maurer).
12825 2004-05-30 Martin Baulig <martin@ximian.com>
12827 Committing a patch from Ben Maurer.
12829 * rootcontext.cs (RootContext.LookupType): Cache negative results.
12831 2004-05-29 Martin Baulig <martin@ximian.com>
12833 * class.cs (IMethodData.ShouldIgnore): New method.
12835 * typemanager.cs (TypeManager.MethodFlags): Don't take a
12836 `Location' argument, we don't need it anywhere. Use
12837 `IMethodData.ShouldIgnore ()' instead of
12838 `MethodData.GetMethodFlags ()'.
12839 (TypeManager.AddMethod): Removed.
12840 (TypeManager.AddMethod2): Renamed to AddMethod.
12842 2004-05-29 Martin Baulig <martin@ximian.com>
12844 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
12846 * convert.cs (Convert.ImplicitReferenceConversion): If we're
12847 converting from a class type S to an interface type and we already
12848 have an object on the stack, don't box it again. Fixes #52578.
12850 2004-05-29 Martin Baulig <martin@ximian.com>
12852 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12853 Added support for `params' parameters. Fixes #59267.
12855 2004-05-29 Martin Baulig <martin@ximian.com>
12857 * literal.cs (NullPointer): Provide a private .ctor which sets
12858 `type' to TypeManager.object_type. Fixes #59048.
12860 2004-05-29 Martin Baulig <martin@ximian.com>
12862 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
12863 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
12865 * ecore.cs (EventExpr.instance_expr): Make the field private.
12867 2004-05-26 Marek Safar <marek.safar@seznam.cz>
12869 Fixed bug #50080 & cs0214-2.cs
12870 * expression.cs (Cast.DoResolve): Check unsafe context here.
12872 * statement.cs (Resolve.DoResolve): Likewise.
12874 2004-05-26 Martin Baulig <martin@ximian.com>
12876 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
12878 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
12879 (RootContext.LookupType): Pass down the `silent' flag.
12881 2004-05-25 Martin Baulig <martin@ximian.com>
12884 (MethodGroupExpr.IdenticalTypeName): New public property.
12885 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
12886 expression actually refers to a type.
12888 2004-05-25 Martin Baulig <martin@ximian.com>
12890 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
12891 for #56176 and made it actually work.
12893 2004-05-25 Martin Baulig <martin@ximian.com>
12895 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
12896 (FieldExpr, PropertyExpr): Override and implement
12897 CacheTemporaries. Fixes #52279.
12899 2004-05-25 Miguel de Icaza <miguel@ximian.com>
12901 * location.cs: In the new compiler listing a file twice is a
12902 warning, not an error.
12904 2004-05-24 Martin Baulig <martin@ximian.com>
12906 * enum.cs (Enum.DefineType): For the `BaseType' to be a
12907 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
12909 2004-05-24 Martin Baulig <martin@ximian.com>
12911 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
12912 walking the `using' list. Fixes #53921.
12914 2004-05-24 Martin Baulig <martin@ximian.com>
12916 * const.cs (Const.LookupConstantValue): Added support for
12917 EmptyCast's; fixes #55251.
12919 2004-05-24 Martin Baulig <martin@ximian.com>
12921 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
12922 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
12923 which does the CS0135 check. The reason is that we first need to
12924 check whether the variable actually exists.
12926 2004-05-24 Martin Baulig <martin@ximian.com>
12928 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
12929 than RootContext.LookupType() to find the explicit interface
12930 type. Fixes #58584.
12932 2004-05-24 Raja R Harinath <rharinath@novell.com>
12934 * Makefile: Simplify. Use executable.make.
12935 * mcs.exe.sources: New file. List of sources of mcs.exe.
12937 2004-05-24 Anders Carlsson <andersca@gnome.org>
12941 Use the invariant culture when doing String.Compare for CLS case
12944 2004-05-23 Martin Baulig <martin@ximian.com>
12946 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
12947 don't have any dots. Fixes #52622, added cs0246-8.cs.
12949 * namespace.cs (NamespaceEntry.Lookup): Likewise.
12951 2004-05-23 Marek Safar <marek.safar@seznam.cz>
12953 * class.cs (MemberBase.Define): Reuse MemberType member for
12954 resolved type. Other methods can use it too.
12956 2004-05-23 Martin Baulig <martin@ximian.com>
12958 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
12959 the variable also exists in the current block (otherwise, we need
12960 to report a CS0103). Fixes #58670.
12962 2004-05-23 Martin Baulig <martin@ximian.com>
12964 * flowanalysis.cs (Reachability.Reachable): Compute this
12965 on-the-fly rather than storing it as a field.
12967 2004-05-23 Martin Baulig <martin@ximian.com>
12969 * flowanalysis.cs (Reachability.And): Manually compute the
12970 resulting `barrier' from the reachability.
12972 2004-05-23 Marek Safar <marek.safar@seznam.cz>
12975 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
12976 instance of ObsoleteAttribute when symbol is obsolete.
12979 (IMethodData): Extended interface for ObsoleteAttribute support.
12981 2004-05-22 Marek Safar <marek.safar@seznam.cz>
12983 * attribute.cs: Fix bug #55970
12985 2004-05-22 Marek Safar <marek.safar@seznam.cz>
12989 (GetObsoleteAttribute): New method. Creates the instance of
12991 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
12992 ObsoleteAttribute when member is obsolete.
12993 (AttributeTester.Report_ObsoleteMessage): Common method for
12994 Obsolete error/warning reporting.
12997 (TypeContainer.base_classs_type): New member for storing parent type.
13000 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
13001 for this MemberCore.
13003 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13005 * attribute.cs, const.cs: Fix bug #58590
13007 2004-05-21 Martin Baulig <martin@ximian.com>
13009 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
13010 out parameters if the end of the method is unreachable. Fixes
13013 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13015 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
13016 Hari was right, why extra method.
13018 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13020 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
13022 2004-05-20 Martin Baulig <martin@ximian.com>
13024 Merged this back from gmcs to keep the differences to a minumum.
13026 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
13027 instead of a Declspace.
13028 (Attribute.ResolveType): Likewise.
13029 (Attributes.Search): Likewise.
13030 (Attributes.Contains): Likewise.
13031 (Attributes.GetClsCompliantAttribute): Likewise.
13033 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
13035 (MethodData.ApplyAttributes): Take an EmitContext instead of a
13038 2004-05-19 Marek Safar <marek.safar@seznam.cz>
13040 Fix bug #58688 (MCS does not report error when the same attribute
13043 * attribute.cs (Attribute.Emit): Distinction between null and default.
13045 2004-05-19 Raja R Harinath <rharinath@novell.com>
13047 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
13048 of a top-level attribute without an attribute target.
13049 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
13051 (Attribute.Conditional_GetConditionName),
13052 (Attribute.Obsolete_GetObsoleteMessage): Update.
13053 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
13054 part of ScanForIndexerName.
13055 (Attribute.CanIgnoreInvalidAttribute): New function.
13056 (Attribute.ScanForIndexerName): Move to ...
13057 (Attributes.ScanForIndexerName): ... here.
13058 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
13059 (Attributes.Search): New internal variant that can choose not to
13060 complain if types aren't resolved. The original signature now
13062 (Attributes.GetClsCompliantAttribute): Use internal variant, with
13063 complaints suppressed.
13064 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
13065 only if it not useful.
13066 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
13067 top-level for attributes that are shared between the assembly
13068 and a top-level class.
13069 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
13070 * class.cs: Update to reflect changes.
13071 (DefineIndexers): Fuse loops.
13072 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
13073 a couple more variants of attribute names.
13075 2004-05-18 Marek Safar <marek.safar@seznam.cz>
13077 Fix bug #52585 (Implemented explicit attribute declaration)
13080 (Attributable.ValidAttributeTargets): New abstract method. It gets
13081 list of valid attribute targets for explicit target declaration.
13082 (Attribute.Target): It holds target itself.
13083 (AttributeSection): Removed.
13084 (Attribute.CheckTargets): New method. It checks whether attribute
13085 target is valid for the current element.
13088 (EventProperty): New class. For events that are declared like
13089 property (with add and remove accessors).
13090 (EventField): New class. For events that are declared like field.
13093 * cs-parser.jay: Implemented explicit attribute target declaration.
13095 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
13096 Override ValidAttributeTargets.
13099 (ReturnParameter): Class for applying custom attributes on
13101 (ParameterAtribute): New class. Class for applying custom
13102 attributes on the parameter type.
13104 2004-05-17 Miguel de Icaza <miguel@ximian.com>
13106 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
13109 (Method): Allow UNSAFE here.
13111 * modifiers.cs: Support unsafe reporting.
13113 2004-05-17 Marek Safar <marek.safar@seznam.cz>
13115 * decl.cs: Fix bug #58478.
13117 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13119 * statement.cs: When checking for unreachable code on an EmptyStatement,
13120 set the location. Fixes bug #58488.
13122 2004-05-13 Miguel de Icaza <miguel@ximian.com>
13124 * driver.cs: Add -pkg handling.
13126 From Gonzalo: UseShelLExecute=false
13128 2004-05-12 Marek Safar <marek.safar@seznam.cz>
13131 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
13133 (Attribute.IsClsCompliaceRequired): Moved to base for better
13135 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
13136 when attribute is AttributeUsageAttribute.
13137 (Attribute.GetValidTargets): Simplified.
13138 (Attribute.GetAttributeUsage): New method returns AttributeUsage
13139 attribute for this type.
13140 (Attribute.ApplyAttributes): Method renamed to Emit and make
13142 (GlobalAttributeSection): New class for special handling of global
13143 attributes (assembly, module).
13144 (AttributeSection.Emit): New method.
13146 * class.cs: Implemented Attributable abstract methods.
13147 (MethodCore.LabelParameters): Moved to Parameter class.
13148 (Accessor): Is back simple class.
13149 (PropertyMethod): Implemented Attributable abstract class.
13150 (DelegateMethod): Implemented Attributable abstract class.
13151 (Event): New constructor for disctintion between normal Event
13152 and Event with accessors.
13154 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
13156 * codegen.cs, const.cs, decl.cs, delegate.cs:
13157 (CommonAssemblyModulClass): Implemented Attributable abstract class
13160 * enum.cs: Implement IAttributeSupport interface.
13161 (EnumMember): New class for emum members. Implemented Attributable
13165 (ParameterBase): Is abstract.
13166 (ReturnParameter): New class for easier [return:] attribute handling.
13168 * typemanager.cs: Removed builder_to_attr.
13170 2004-05-11 Raja R Harinath <rharinath@novell.com>
13173 * attribute.cs (Attribute.GetPositionalValue): New function.
13174 * class.cs (TypeContainer.VerifyMembers): New function.
13175 (TypeContainer.Emit): Use it.
13176 (ClassOrStruct): New base class for Class and Struct.
13177 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
13178 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
13180 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
13181 then each non-static field should have a FieldOffset attribute.
13182 Otherwise, none of the fields should have a FieldOffset attribute.
13183 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
13184 and FieldOffset attributes.
13185 * typemanager.cs (TypeManager.struct_layout_attribute_type)
13186 (TypeManager.field_offset_attribute_type): New core types.
13187 (TypeManager.InitCoreTypes): Initialize them.
13189 2004-05-11 Michal Moskal <malekith@pld-linux.org>
13191 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
13192 Return correct type.
13195 2004-05-09 Miguel de Icaza <miguel@ximian.com>
13197 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
13198 be implicitly converted to ulong.
13200 * expression.cs: The logic for allowing operator &, | and ^ worked
13201 was wrong, it worked before because we did not report an error in
13202 an else branch. Fixes 57895.
13204 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
13205 allow volatile fields to be reference types.
13207 2004-05-07 Miguel de Icaza <miguel@ximian.com>
13209 * driver.cs: Add support for /debug-
13211 2004-05-07 Raja R Harinath <rharinath@novell.com>
13213 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
13214 Add a 'complain' parameter to silence errors.
13215 (Attribute.Resolve): Update to changes. Put in sanity check to catch
13216 silently overlooked type-resolutions.
13217 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
13218 to reflect changes.
13219 (Attributes.Search): New function.
13220 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
13221 (Attributes.GetAttributeFullName): Remove hack.
13222 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
13223 Update to reflect changes.
13224 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
13225 Use Attributes.Search instead of nested loops.
13227 2004-05-07 Marek Safar <marek.safar@seznam.cz>
13230 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
13231 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
13232 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
13234 * report.cs: (Report.Warning): Renamed to Warning_T because of
13235 parameter collision.
13237 2004-05-05 Raja R Harinath <rharinath@novell.com>
13239 * expression.cs (MemberAccess.ResolveMemberAccess):
13240 Exit with non-zero status after Report.Error.
13241 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
13243 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
13245 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13247 * support.cs: Don't hang when the file is empty.
13249 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13251 * support.cs: In SeekableStreamReader, compute the preamble size of the
13252 underlying stream. Position changes should take into account that initial
13255 2004-05-03 Todd Berman <tberman@sevenl.net>
13257 * driver.cs: remove unused GetSysVersion function.
13259 2004-05-03 Todd Berman <tberman@sevenl.net>
13261 * driver.cs: Remove the hack from saturday, as well as the hack
13262 from jackson (LoadAssemblyFromGac), also adds the CWD to the
13263 link_paths to get that bit proper.
13265 2004-05-01 Todd Berman <tberman@sevenl.net>
13267 * driver.cs: Try a LoadFrom before a Load, this checks the current
13268 path. This is currently a bug in mono that is be fixed, however, this
13269 provides a workaround for now. This will be removed when the bug
13272 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
13274 * CryptoConvert.cs: Updated to latest version. Fix issue with
13275 incomplete key pairs (#57941).
13277 2004-05-01 Todd Berman <tberman@sevenl.net>
13279 * driver.cs: Remove '.' from path_chars, now System.* loads properly
13282 2004-04-30 Jackson Harper <jackson@ximian.com>
13284 * codegen.cs: Open keys readonly.
13286 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13288 * typemanager.cs: don't report cyclic struct layout when a struct
13289 contains 2 or more fields of the same type. Failed for Pango.AttrShape
13290 which has 2 Pango.Rectangle fields.
13292 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
13294 * expression.cs: Handle IntPtr comparisons with IL code
13295 rather than a method call.
13297 2004-04-29 Martin Baulig <martin@ximian.com>
13299 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
13300 the list of PropertyInfo's in class hierarchy and find the
13301 accessor. Fixes #56013.
13303 2004-04-29 Martin Baulig <martin@ximian.com>
13305 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
13307 2004-04-29 Martin Baulig <martin@ximian.com>
13309 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13311 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
13313 2004-04-29 Martin Baulig <martin@ximian.com>
13315 * class.cs (ConstructorInitializer.Resolve): Check whether the
13316 parent .ctor is accessible. Fixes #52146.
13318 2004-04-29 Martin Baulig <martin@ximian.com>
13320 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13322 * statement.cs (Using.EmitLocalVariableDecls): Use
13323 TypeManager.idisposable_type, not typeof (IDisposable).
13324 (Foreach.EmitCollectionForeach): Added support for valuetypes.
13326 2004-04-29 Martin Baulig <martin@ximian.com>
13328 * class.cs (Event.Define): Don't emit the field and don't set
13329 RTSpecialName and SpecialName for events on interfaces. Fixes
13332 2004-04-29 Raja R Harinath <rharinath@novell.com>
13334 Refactor Attribute.ApplyAttributes.
13335 * attribute.cs (Attributable): New base class for objects that can
13336 have Attributes applied on them.
13337 (Attribute): Make AttributeUsage fields public.
13338 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
13339 (Attribute.IsInternalCall): New property.
13340 (Attribute.UsageAttr): Convert to a public read-only property.
13341 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
13342 (Attribute.ResolveType, Attribute.Resolve)
13343 (Attribute.ScanForIndexerName): Update to reflect changes.
13344 (Attribute.CheckAttributeTarget): Re-format.
13345 (Attribute.ApplyAttributes): Refactor, to various
13346 Attributable.ApplyAttributeBuilder methods.
13347 * decl.cs (MemberCore): Make Attributable.
13348 * class.cs (Accessor): Make Attributable.
13349 (MethodData.ApplyAttributes): Use proper attribute types, not
13351 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
13352 (TypeContainer.ApplyAttributeBuilder)
13353 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
13354 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
13355 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
13356 (Operator.ApplyAttributeBuilder): New factored-out methods.
13357 * const.cs (Const.ApplyAttributeBuilder): Likewise.
13358 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
13359 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
13360 * parameter.cs (ParameterBase): New Attributable base class
13361 that can also represent Return types.
13362 (Parameter): Update to the changes.
13364 2004-04-29 Jackson Harper <jackson@ximian.com>
13366 * driver.cs: Prefer the corlib system version when looking for
13367 assemblies in the GAC. This is still a hack, but its a better hack
13370 2004-04-29 Marek Safar <marek.safar@seznam.cz>
13372 * decl.cs, enum.cs: Improved error 3005 reporting.
13374 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
13375 (related_symbols): New private member for list of symbols
13376 related to reported error/warning.
13378 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
13380 2004-04-29 Martin Baulig <martin@ximian.com>
13382 * ecore.cs (Expression.Constantify): If we're an enum and
13383 TypeManager.TypeToCoreType() doesn't give us another type, use
13384 t.UnderlyingSystemType. Fixes #56178.
13386 2004-04-29 Martin Baulig <martin@ximian.com>
13388 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
13389 interfaces and for each interface, only add members directly
13390 declared in that interface. Fixes #53255.
13392 2004-04-28 Martin Baulig <martin@ximian.com>
13394 * expression.cs (ConditionalLogicalOperator): Use a temporary
13395 variable for `left' to avoid that we evaluate it more than once;
13398 2004-04-28 Martin Baulig <martin@ximian.com>
13400 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
13403 2004-04-28 Martin Baulig <martin@ximian.com>
13405 * statement.cs (LocalInfo.Resolve): Check whether the type is not
13408 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
13409 whether the type is not void (CS1547).
13411 2004-04-28 Martin Baulig <martin@ximian.com>
13413 * expression.cs (Unary.DoResolveLValue): Override this and report
13414 CS0131 for anything but Operator.Indirection.
13416 2004-04-28 Martin Baulig <martin@ximian.com>
13418 Committing a patch from Ben Maurer; see bug #50820.
13420 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13423 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13426 2004-04-28 Martin Baulig <martin@ximian.com>
13428 Committing a patch from Ben Maurer; see bug #50820.
13430 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13433 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13436 2004-04-28 Martin Baulig <martin@ximian.com>
13438 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
13439 (Block.AddLabel): Call DoLookupLabel() to only search in the
13442 2004-04-28 Martin Baulig <martin@ximian.com>
13444 * cfold.cs (ConstantFold.BinaryFold): Added special support for
13445 comparing StringConstants and NullLiterals in Equality and Inequality.
13447 2004-04-28 Jackson Harper <jackson@ximian.com>
13449 * driver.cs: Attempt to load referenced assemblies from the
13450 GAC. This is the quick and dirty version of this method that
13451 doesnt take into account versions and just takes the first
13452 canidate found. Will be good enough for now as we will not have more
13453 then one version installed into the GAC until I update this method.
13455 2004-04-28 Martin Baulig <martin@ximian.com>
13457 * typemanager.cs (TypeManager.CheckStructCycles): New public
13458 static method to check for cycles in the struct layout.
13460 * rootcontext.cs (RootContext.PopulateTypes): Call
13461 TypeManager.CheckStructCycles() for each TypeContainer.
13462 [Note: We only need to visit each type once.]
13464 2004-04-28 Martin Baulig <martin@ximian.com>
13466 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
13468 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
13469 success and added `out object value'. Use a `bool resolved' field
13470 to check whether we've already been called rather than
13471 `ConstantValue != null' since this breaks for NullLiterals.
13473 2004-04-28 Raja R Harinath <rharinath@novell.com>
13475 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
13476 setting of this flag, since the 'set' method may be non-public.
13478 2004-04-28 Raja R Harinath <rharinath@novell.com>
13480 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
13481 check on current_vector.Block.
13483 2004-04-27 Martin Baulig <martin@ximian.com>
13485 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
13486 a field initializer. Fixes #56459.
13488 2004-04-27 Martin Baulig <martin@ximian.com>
13490 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
13491 we're not attempting to use an indexer. Fixes #52154.
13493 2004-04-27 Martin Baulig <martin@ximian.com>
13495 * statement.cs (Return): Don't create a return label if we don't
13496 need it; reverts my change from January 20th. Thanks to Ben
13499 2004-04-27 Martin Baulig <martin@ximian.com>
13501 According to the spec, `goto' can only leave a nested scope, but
13504 * statement.cs (Block.LookupLabel): Only lookup in the current
13505 block, don't recurse into parent or child blocks.
13506 (Block.AddLabel): Check in parent and child blocks, report
13507 CS0140/CS0158 if we find a duplicate.
13508 (Block): Removed this indexer for label lookups.
13509 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
13510 this already does the error reporting for us.
13513 (FlowBranching.UsageVector.Block): New public variable; may be null.
13514 (FlowBranching.CreateSibling): Added `Block' argument.
13515 (FlowBranching.LookupLabel): New public virtual method. Lookup a
13516 label for the target of a `goto' and check whether we're not
13517 leaving a `finally'.
13519 2004-04-27 Martin Baulig <martin@ximian.com>
13521 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13522 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
13525 2004-04-27 Martin Baulig <martin@ximian.com>
13527 * statement.cs (Block.AddLabel): Also check for implicit blocks
13528 and added a CS0158 check.
13530 2004-04-27 Martin Baulig <martin@ximian.com>
13532 * flowanalysis.cs (FlowBranchingLoop): New class.
13533 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
13534 UsageVector's instead of an ArrayList.
13535 (FlowBranching.Label): Likewise.
13536 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
13537 (FlowBranching.AddBreakVector): New method.
13539 2004-04-27 Miguel de Icaza <miguel@ximian.com>
13541 * attribute.cs: Small regression fix: only convert the type if we
13542 the type is different, fixes System.Drawing build.
13544 2004-04-27 Martin Baulig <martin@ximian.com>
13546 * attribute.cs (Attribute.Resolve): If we have a constant value
13547 for a named field or property, implicity convert it to the correct
13550 2004-04-27 Raja R Harinath <rharinath@novell.com>
13552 * statement.cs (Block.Block): Implicit blocks share
13553 'child_variable_names' fields with parent blocks.
13554 (Block.AddChildVariableNames): Remove.
13555 (Block.AddVariable): Mark variable as "used by a child block" in
13556 every surrounding block.
13557 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
13558 been used in a child block, complain about violation of "Invariant
13559 meaning in blocks" rule.
13560 * cs-parser.jay (declare_local_variables): Don't use
13561 AddChildVariableNames.
13562 (foreach_statement): Don't create an implicit block: 'foreach'
13563 introduces a scope.
13565 2004-04-23 Miguel de Icaza <miguel@ximian.com>
13567 * convert.cs (ImplicitNumericConversion): 0 is also positive when
13568 converting from 0L to ulong. Fixes 57522.
13570 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13572 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
13573 derived class hides via 'new' keyword field from base class (test-242.cs).
13574 TODO: Handle this in the more general way.
13576 * class.cs (CheckBase): Ditto.
13578 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13580 * decl.cs (caching_flags): New member for storing cached values
13582 (MemberCore.Flags): New enum where bit flags for caching_flags
13584 (MemberCore.cls_compliance): Moved to caching_flags.
13585 (DeclSpace.Created): Moved to caching_flags.
13587 * class.cs: Use caching_flags instead of DeclSpace.Created
13589 2004-04-21 Miguel de Icaza <miguel@ximian.com>
13591 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
13592 if we are only a derived class, not a nested class.
13594 * typemanager.cs: Same as above, but do this at the MemberLookup
13595 level (used by field and methods, properties are handled in
13596 PropertyExpr). Allow for the qualified access if we are a nested
13599 2004-04-21 Marek Safar <marek.safar@seznam.cz>
13601 * class.cs: Refactoring.
13602 (IMethodData): New inteface; Holds links to parent members
13603 to avoid member duplication (reduced memory allocation).
13604 (Method): Implemented IMethodData interface.
13605 (PropertyBase): New inner classes for get/set methods.
13606 (PropertyBase.PropertyMethod): Implemented IMethodData interface
13607 (Event): New inner classes for add/remove methods.
13608 (Event.DelegateMethod): Implemented IMethodData interface.
13610 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
13611 EmitContext (related to class.cs refactoring).
13613 2004-04-21 Raja R Harinath <rharinath@novell.com>
13615 * delegate.cs (Delegate.VerifyApplicability): If the number of
13616 arguments are the same as the number of parameters, first try to
13617 verify applicability ignoring any 'params' modifier on the last
13621 2004-04-16 Raja R Harinath <rharinath@novell.com>
13623 * class.cs (TypeContainer.AddIndexer): Use
13624 'ExplicitInterfaceName' to determine if interface name was
13625 explicitly specified. 'InterfaceType' is not initialized at this time.
13626 (TypeContainer.DefineIndexers): Remove use of temporary list. The
13627 Indexers array is already in the required order. Initialize
13628 'IndexerName' only if there are normal indexers.
13629 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
13630 (TypeContainer.Emit): Emit DefaultMember attribute only if
13631 IndexerName is initialized.
13634 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
13636 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
13639 2004-04-15 Raja R Harinath <rharinath@novell.com>
13641 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
13645 * attribute.cs (Attribute.Resolve): Check for duplicate named
13649 2004-04-15 Miguel de Icaza <miguel@ximian.com>
13651 * iterators.cs (MarkYield): track whether we are in an exception,
13652 and generate code accordingly. Use a temporary value to store the
13653 result for our state.
13655 I had ignored a bit the interaction of try/catch with iterators
13656 since their behavior was not entirely obvious, but now it is
13657 possible to verify that our behavior is the same as MS .NET 2.0
13661 2004-04-14 Miguel de Icaza <miguel@ximian.com>
13663 * iterators.cs: Avoid creating temporaries if there is no work to
13666 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
13667 Enumerations, use TypeManager.EnumToUnderlying and call
13670 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
13673 (This.Emit): Use EmitContext.EmitThis to emit our
13676 (This.EmitAssign): Ditto.
13678 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
13679 codepaths, we will move all the functionality into
13682 (FieldExpr.EmitAssign): Ditto.
13684 This fixes several hidden bugs that I uncovered while doing a code
13685 review of this today.
13687 * codegen.cs (EmitThis): reworked so the semantics are more clear
13688 and also support value types "this" instances.
13690 * iterators.cs: Changed so that for iterators in value types, we
13691 do not pass the value type as a parameter.
13693 Initialization of the enumerator helpers is now done in the caller
13694 instead of passing the parameters to the constructors and having
13695 the constructor set the fields.
13697 The fields have now `assembly' visibility instead of private.
13699 2004-04-11 Miguel de Icaza <miguel@ximian.com>
13701 * expression.cs (Argument.Resolve): Check if fields passed as ref
13702 or out are contained in a MarshalByRefObject.
13704 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
13705 another compiler type.
13707 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
13709 * class.cs (Indexer.Define): use the new name checking method.
13710 Also, return false on an error.
13711 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
13712 (is_identifier_[start/part]_character): make static.
13714 2004-04-10 Miguel de Icaza <miguel@ximian.com>
13716 * expression.cs (Binary.ResolveOperator): Do no append strings
13717 twice: since we can be invoked more than once (array evaluation)
13718 on the same concatenation, take care of this here. Based on a fix
13719 from Ben (bug #56454)
13721 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
13723 * codegen.cs: Fix another case where CS1548 must be reported (when
13724 delay-sign isn't specified and no private is available #56564). Fix
13725 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
13726 error when MCS is used on the MS runtime and we need to delay-sign
13727 (which seems unsupported by AssemblyBuilder - see #56621).
13729 2004-04-08 Marek Safar <marek.safar@seznam.cz>
13731 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
13732 (TypeManager.ComputeNamespaces): Faster implementation for
13735 * compiler.csproj: Updated AssemblyName to mcs.
13737 2004-04-07 Miguel de Icaza <miguel@ximian.com>
13739 * rootcontext.cs: Add new types to the boot resolution.
13741 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
13742 MulticastDelegate is not allowed.
13744 * typemanager.cs: Add new types to lookup: System.TypedReference
13747 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
13748 check for TypedReference or ArgIterator, they are not allowed.
13750 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
13751 makes us properly catch 1510 in some conditions (see bug 56016 for
13754 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
13756 * CryptoConvert.cs: update from corlib version
13759 2004-04-05 Miguel de Icaza <miguel@ximian.com>
13761 * class.cs (Indexer.Define): Check indexername declaration
13763 2004-04-05 Marek Safar <marek.safar@seznam.cz>
13765 * attribute.cs (IsClsCompliant): Fixed problem with handling
13766 all three states (compliant, not-compliant, undetected).
13768 2004-03-30 Marek Safar <marek.safar@seznam.cz>
13770 * attribute.cs (Attribute): Location is now public.
13771 (Resolve): Store resolved arguments (pos_values) in attribute class.
13772 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
13773 (GetClsCompliantAttributeValue): New method that gets
13774 CLSCompliantAttribute value.
13775 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
13776 if exists else null.
13777 (AttributeTester): New class for CLS-Compliant verification routines.
13779 * class.cs (Emit): Add CLS-Compliant verification.
13780 (Method.GetSignatureForError): Implemented.
13781 (Constructor.GetSignatureForError): Implemented
13782 (Constructor.HasCompliantArgs): Returns if constructor has
13783 CLS-Compliant arguments.
13784 (Constructor.Emit): Override.
13785 (Construcor.IsIdentifierClsCompliant): New method; For constructors
13786 is needed to test only parameters.
13787 (FieldBase.GetSignatureForError): Implemented.
13788 (TypeContainer): New member for storing base interfaces.
13789 (TypeContainer.FindMembers): Search in base interfaces too.
13791 * codegen.cs (GetClsComplianceAttribute): New method that gets
13792 assembly or module CLSCompliantAttribute value.
13793 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
13795 (ModuleClass.Emit): Add error 3012 test.
13797 * const.cs (Emit): Override and call base for CLS-Compliant tests.
13799 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
13800 state for all decl types.
13801 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
13802 if CLS-Compliant tests are required.
13803 (IsClsCompliaceRequired): New method. Analyze whether code
13804 must be CLS-Compliant.
13805 (IsExposedFromAssembly): New method. Returns true when MemberCore
13806 is exposed from assembly.
13807 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
13808 value or gets cached value.
13809 (HasClsCompliantAttribute): New method. Returns true if MemberCore
13810 is explicitly marked with CLSCompliantAttribute.
13811 (IsIdentifierClsCompliant): New abstract method. This method is
13812 used to testing error 3005.
13813 (IsIdentifierAndParamClsCompliant): New method. Common helper method
13814 for identifier and parameters CLS-Compliant testing.
13815 (VerifyClsCompliance): New method. The main virtual method for
13816 CLS-Compliant verifications.
13817 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
13818 null. I don't know why is null (too many public members !).
13819 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
13820 and get value of first CLSCompliantAttribute that found.
13822 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
13823 (VerifyClsCompliance): Override and add extra tests.
13825 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
13826 clscheck- disable CLS-Compliant verification event if assembly is has
13827 CLSCompliantAttribute(true).
13829 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
13830 ApllyAttribute is now called in emit section as in the other cases.
13831 Possible future Emit integration.
13832 (IsIdentifierClsCompliant): New override.
13833 (VerifyClsCompliance): New override.
13834 (GetEnumeratorName): Returns full enum name.
13836 * parameter.cs (GetSignatureForError): Implemented.
13838 * report.cs (WarningData): New struct for Warning message information.
13839 (LocationOfPreviousError): New method.
13840 (Warning): New method. Reports warning based on the warning table.
13841 (Error_T): New method. Reports error based on the error table.
13843 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
13844 verifications are done here.
13846 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
13848 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
13849 CLSCompliantAttribute.
13850 (all_imported_types): New member holds all imported types from other
13852 (LoadAllImportedTypes): New method fills static table with exported types
13853 from all referenced assemblies.
13854 (Modules): New property returns all assembly modules.
13856 2004-03-30 Miguel de Icaza <miguel@ximian.com>
13858 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
13859 throwing a parser error.
13861 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
13862 which removes the hardcoded get_/set_ prefixes for properties, as
13863 IL allows for the properties to be named something else.
13867 * expression.cs: Do not override operand before we know if it is
13868 non-null. Fix 56207
13870 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13872 * typemanager.cs: support for pinned variables.
13874 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13876 * decl.cs, typemanager.cs: Avoid using an arraylist
13877 as a buffer if there is only one result set.
13879 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13881 * expression.cs: Make sure you cant call a static method
13882 with an instance expression, bug #56174.
13884 2004-03-29 Miguel de Icaza <miguel@ximian.com>
13886 * class.cs (IsDuplicateImplementation): Improve error reporting to
13887 flag 663 (method only differs in parameter modifier).
13889 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
13890 in preprocessor directives.
13892 * location.cs (LookupFile): Allow for the empty path.
13894 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
13895 better approach for some of that patch, but its failing with the
13896 CharSet enumeration. For now try/catch will do.
13898 * typemanager.cs: Do not crash if a struct does not have fields.
13901 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13903 * expression.cs: cs0213, cant fix a fixed expression.
13906 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13908 * cs-parser.jay: detect invalid embeded statements gracefully.
13911 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13913 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
13916 the invocation type may not be a subclass of the tye of the item/
13917 The type of the item must be a subclass of the invocation item.
13922 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
13924 * attribute.cs: Added methods to get a string and a bool from an
13925 attribute. Required to information from AssemblyKeyFileAttribute,
13926 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
13927 * codegen.cs: Modified AssemblyName creation to include support for
13928 strongnames. Catch additional exceptions to report them as CS1548.
13929 * compiler.csproj: Updated include CryptoConvert.cs.
13930 * compiler.csproj.user: Removed file - user specific configuration.
13931 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
13932 Mono.Security assembly. The original class is maintained and tested in
13933 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
13934 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
13935 like CSC 8.0 (C# v2) supports.
13936 * Makefile: Added CryptoConvert.cs to mcs sources.
13937 * rootcontext.cs: Added new options for strongnames.
13939 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
13941 * driver.cs: For --expect-error, report error code `2'
13942 if the program compiled with no errors, error code `1' if
13943 it compiled with an error other than the one expected.
13945 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
13947 * compiler.csproj: Updated for Visual Studio .NET 2003.
13948 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
13949 * compiler.sln: Updated for Visual Studio .NET 2003.
13951 2004-03-24 Ravi Pratap M <ravi@ximian.com>
13953 * expression.cs: Fix bug #47234. We basically need to apply the
13954 rule that we prefer the conversion of null to a reference type
13955 when faced with a conversion to 'object' (csc behaviour).
13957 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13959 * statement.cs: Shorter form for foreach, eliminates
13960 a local variable. r=Martin.
13962 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13964 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
13965 checks if we can use brtrue/brfalse to test for 0.
13966 * expression.cs: use the above in the test for using brtrue/brfalse.
13967 cleanup code a bit.
13969 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13971 * expression.cs: Rewrite string concat stuff. Benefits:
13973 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
13974 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
13975 rather than a concat chain.
13977 * typemanager.cs: Add lookups for more concat overloads.
13979 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13981 * expression.cs: Emit shorter il code for array init.
13998 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
14000 * statement.cs: Before, two switch blocks would be merged if the
14001 total size of the blocks (end_item - begin_item + 1) was less than
14002 two times the combined sizes of the blocks.
14004 Now, it will only merge if after the merge at least half of the
14009 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
14011 * class.cs : csc build fix for GetMethods(). See bug #52503.
14013 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
14015 * expression.cs: Make sure fp comparisons work with NaN.
14016 This fixes bug #54303. Mig approved this patch a long
14017 time ago, but we were not able to test b/c the runtime
14020 2004-03-19 Miguel de Icaza <miguel@ximian.com>
14022 * ecore.cs (TypExpr.GetHashCode): implement this overload.
14024 2004-03-19 Martin Baulig <martin@ximian.com>
14026 * class.cs (MemberCore.IsDuplicateImplementation): Report the
14027 error here and not in our caller.
14029 2004-03-19 Martin Baulig <martin@ximian.com>
14031 * interface.cs: Completely killed this file.
14032 (Interface): We're now a TypeContainer and live in class.cs.
14034 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
14035 argument; we're now also called for interfaces.
14036 (TypeContainer.DefineMembers): Allow this method being called
14038 (TypeContainer.GetMethods): New public method; formerly known as
14039 Interface.GetMethod(). This is used by PendingImplementation.
14040 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
14041 it's now private and non-static.
14042 (Interface): Moved this here; it's now implemented similar to
14044 (Method, Property, Event, Indexer): Added `bool is_interface'
14045 argument to their .ctor's.
14046 (MemberBase.IsInterface): New public field.
14048 * cs-parser.jay: Create normal Method, Property, Event, Indexer
14049 instances instead of InterfaceMethod, InterfaceProperty, etc.
14050 (opt_interface_base): Removed; we now use `opt_class_base' instead.
14051 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
14053 2004-03-19 Martin Baulig <martin@ximian.com>
14055 * class.cs (MethodCore.IsDuplicateImplementation): New private
14056 method which does the CS0111 checking.
14057 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14058 Use IsDuplicateImplementation().
14060 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
14062 * decl.cs (FindMemberToOverride): New method to find the correct
14063 method or property to override in the base class.
14065 - Make Method/Property use the above method to find the
14066 version in the base class.
14067 - Remove the InheritableMemberSignatureCompare as it is now
14070 This patch makes large code bases much faster to compile, as it is
14071 O(n) rather than O(n^2) to do this validation.
14073 Also, it fixes bug 52458 which is that nested classes are not
14074 taken into account when finding the base class member.
14076 Reviewed/Approved by Martin.
14078 2004-03-17 Marek Safar <marek.safar@seznam.cz>
14080 * interface.cs: In all interface classes removed redundant
14081 member initialization.
14083 2004-03-16 Martin Baulig <martin@ximian.com>
14085 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
14087 2004-03-15 Miguel de Icaza <miguel@ximian.com>
14089 * decl.cs (DefineTypeAndParents): New helper method to define a
14090 type's containers before the type itself is defined; This is a
14091 bug exposed by the recent changes to Windows.Forms when an
14092 implemented interface was defined inside a class that had not been
14095 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
14097 (Check): Loop correctly to report errors modifiers
14098 (UNSAFE was not in the loop, since it was the same as TOP).
14100 * interface.cs: Every interface member now takes a ModFlags,
14101 instead of a "is_new" bool, which we set on the base MemberCore.
14103 Every place where we called "UnsafeOk" in the interface, now we
14104 call the proper member (InterfaceMethod.UnsafeOK) instead to get
14105 the unsafe settings from the member declaration instead of the
14106 container interface.
14108 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
14110 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
14111 `set_indexer_name' to the pending bits (one per type).
14113 We fixed a bug today that was picking the wrong method to
14114 override, since for properties the existing InterfaceMethod code
14115 basically ignored the method name. Now we make sure that the
14116 method name is one of the valid indexer names.
14118 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
14120 * support.cs (SeekableStreamReader): Keep track of stream byte
14121 positions and don't mix them with character offsets to the buffer.
14123 Patch from Gustavo Giráldez
14125 2004-03-15 Marek Safar <marek.safar@seznam.cz>
14127 * interface.cs (InterfaceSetGetBase): Removed double member
14128 initialization, base class does it as well.
14130 2004-03-13 Martin Baulig <martin@ximian.com>
14132 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
14133 when compiling corlib.
14135 2004-03-13 Miguel de Icaza <miguel@ximian.com>
14137 * convert.cs (ExplicitConversion): We were reporting an error on
14138 certain conversions (object_type source to a value type, when the
14139 expression was `null') before we had a chance to pass it through
14140 the user defined conversions.
14142 * driver.cs: Replace / and \ in resource specifications to dots.
14145 * class.cs: Add check for duplicate operators. Fixes 52477
14147 2004-03-11 Miguel de Icaza <miguel@ximian.com>
14149 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
14150 that are in the middle of the statements, not only at the end.
14153 * class.cs (TypeContainer.AddField): No longer set the
14154 `HaveStaticConstructor' flag, now we call it
14155 `UserDefineStaticConstructor' to diferentiate the slightly
14156 semantic difference.
14158 The situation is that we were not adding BeforeFieldInit (from
14159 Modifiers.TypeAttr) to classes that could have it.
14160 BeforeFieldInit should be set to classes that have no static
14165 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
14167 And most importantly Zoltan's comment:
14169 http://bugzilla.ximian.com/show_bug.cgi?id=44229
14171 "I think beforefieldinit means 'it's ok to initialize the type sometime
14172 before its static fields are used', i.e. initialization does not need
14173 to be triggered by the first access to the type. Setting this flag
14174 helps the JIT to compile better code, since it can run the static
14175 constructor at JIT time, and does not need to generate code to call it
14176 (possibly lots of times) at runtime. Unfortunately, mcs does not set
14177 this flag for lots of classes like String.
14179 csc sets this flag if the type does not have an explicit static
14180 constructor. The reasoning seems to be that if there are only static
14181 initalizers for a type, and no static constructor, then the programmer
14182 does not care when this initialization happens, so beforefieldinit
14185 This bug prevents the AOT compiler from being usable, since it
14186 generates so many calls to mono_runtime_class_init that the AOT code
14187 is much slower than the JITted code. The JITted code is faster,
14188 because it does not generate these calls if the vtable is type is
14189 already initialized, which is true in the majority of cases. But the
14190 AOT compiler can't do this."
14192 2004-03-10 Miguel de Icaza <miguel@ximian.com>
14194 * class.cs (MethodData.Emit): Refactor the code so symbolic
14195 information is generated for destructors; For some reasons we
14196 were taking a code path that did not generate symbolic information
14199 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
14201 * class.cs: Create a Constructor.CheckBase method that
14202 takes care of all validation type code. The method
14203 contains some code that was moved from Define.
14205 It also includes new code that checks for duplicate ctors.
14206 This fixes bug #55148.
14208 2004-03-09 Joshua Tauberer <tauberer@for.net>
14210 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
14211 a { ... }-style array creation invokes EmitStaticInitializers
14212 which is not good for reference-type arrays. String, decimal
14213 and now null constants (NullCast) are not counted toward
14214 static initializers.
14216 2004-03-05 Martin Baulig <martin@ximian.com>
14218 * location.cs (SourceFile.HasLineDirective): New public field;
14219 specifies whether the file contains or is referenced by a "#line"
14221 (Location.DefineSymbolDocuments): Ignore source files which
14222 either contain or are referenced by a "#line" directive.
14224 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
14226 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
14227 direct access to our parent, so check the method inline there.
14229 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
14231 * expression.cs (Invocation.EmitCall): Miguel's last commit
14232 caused a regression. If you had:
14237 In Foo the implict this would be null.
14239 2004-02-27 Miguel de Icaza <miguel@ximian.com>
14241 * expression.cs (Invocation.EmitCall): If the method is not
14242 virtual, do not emit a CallVirt to it, use Call.
14244 * typemanager.cs (GetFullNameSignature): Improve the method to
14245 cope with ".ctor" and replace it with the type name.
14247 * class.cs (ConstructorInitializer.Resolve): Now the method takes
14248 as an argument the ConstructorBuilder where it is being defined,
14249 to catch the recursive constructor invocations.
14251 2004-02-26 Miguel de Icaza <miguel@ximian.com>
14253 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
14254 routines to check if a type is an enumerable/enumerator allow
14255 classes that implement the IEnumerable or IEnumerator interfaces.
14257 * class.cs (Property, Operator): Implement IIteratorContainer, and
14258 implement SetYields.
14260 (Property.Define): Do the block swapping for get_methods in the
14261 context of iterators. We need to check if Properties also
14262 include indexers or not.
14264 (Operator): Assign the Block before invoking the
14265 OperatorMethod.Define, so we can trigger the Iterator code
14268 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
14269 Property and Operator classes are not created when we parse the
14270 declarator but until we have the block completed, so we use a
14271 singleton SimpleIteratorContainer.Simple to flag whether the
14272 SetYields has been invoked.
14274 We propagate this setting then to the Property or the Operator to
14275 allow the `yield' to function.
14277 2004-02-25 Marek Safar <marek.safar@seznam.cz>
14279 * codegen.cs: Implemented attribute support for modules.
14280 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
14281 Assembly/Module functionality.
14283 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
14284 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
14285 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
14287 2004-02-16 Marek Safar <marek.safar@seznam.cz>
14289 * interface.cs (FindMembers): The operation is performed on all base
14290 interfaces and not only on the first. It is required for future CLS Compliance patch.
14292 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
14294 * statement.cs, codegen.cs:
14295 This patch deals with patterns such as:
14297 public class List : IEnumerable {
14299 public MyEnumerator GetEnumerator () {
14300 return new MyEnumerator(this);
14303 IEnumerator IEnumerable.GetEnumerator () {
14307 public struct MyEnumerator : IEnumerator {
14312 Before, there were a few things we did wrong:
14313 1) we would emit callvirt on a struct, which is illegal
14314 2) we emited ldarg when we needed to emit ldarga
14315 3) we would mistakenly call the interface methods on an enumerator
14316 type that derived from IEnumerator and was in another assembly. For example:
14318 public class MyEnumerator : IEnumerator
14320 Would have the interface methods called, even if there were public impls of the
14321 method. In a struct, this lead to invalid IL code.
14323 2004-02-11 Marek Safar <marek.safar@seznam.cz>
14325 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
14328 * delegate.cs (Define): Fixed crash when delegate type is undefined.
14330 2004-02-11 Miguel de Icaza <miguel@ximian.com>
14332 * cs-parser.jay: Fix small regression: we were not testing V2
14333 compiler features correctly.
14335 * interface.cs: If the emit context is null, then create one
14337 2004-02-09 Marek Safar <marek.safar@seznam.cz>
14339 * decl.cs (GetSignatureForError): New virtual method to get full name
14340 for error messages.
14342 * attribute.cs (IAttributeSupport): New interface for attribute setting.
14343 Now it is possible to rewrite ApplyAttributes method to be less if/else.
14345 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
14346 Duplicated members and code in these classes has been removed.
14347 Better encapsulation in these classes.
14349 2004-02-07 Miguel de Icaza <miguel@ximian.com>
14351 * assign.cs (Assign.DoResolve): When dealing with compound
14352 assignments, there is a new rule in ECMA C# 2.4 (might have been
14353 there before, but it is documented here) that states that in:
14357 If b is of type int, and the `op' is a shift-operator, then the
14358 above is evaluated as:
14362 * expression.cs (Binary.ResolveOperator): Instead of testing for
14363 int/uint/long/ulong, try to implicitly convert to any of those
14364 types and use that in pointer arithmetic.
14366 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
14367 method to print information for from the type, not from the
14368 null-method we were given.
14370 2004-02-01 Duncan Mak <duncan@ximian.com>
14372 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
14373 parsing for cmd, fixes bug #53694.
14375 2004-02-04 Marek Safar <marek.safar@seznam.cz>
14377 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
14378 in the member name duplication tests. Property and operator name duplication
14379 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
14381 2004-02-03 Marek Safar <marek.safar@seznam.cz>
14383 * interface.cs (PopulateMethod): Fixed crash when interface method
14384 returns not existing type (error test cs0246-3.cs).
14386 2004-02-02 Ravi Pratap M <ravi@ximian.com>
14388 * cs-parser.jay (interface_accessors): Re-write actions to also
14389 store attributes attached to get and set methods. Fix spelling
14392 (inteface_property_declaration): Modify accordingly.
14394 (InterfaceAccessorInfo): New helper class to store information to pass
14395 around between rules that use interface_accessors.
14397 * interface.cs (Emit): Apply attributes on the get and set
14398 accessors of properties and indexers too.
14400 * attribute.cs (ApplyAttributes): Modify accordingly to use the
14401 right MethodBuilder when applying attributes to the get and set accessors.
14403 2004-01-31 Miguel de Icaza <miguel@ximian.com>
14405 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
14407 2004-01-26 Miguel de Icaza <miguel@ximian.com>
14409 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
14411 2004-01-25 Miguel de Icaza <miguel@ximian.com>
14413 * cs-parser.jay: Remove YIELD token, instead use the new grammar
14414 changes that treat `yield' specially when present before `break'
14415 or `return' tokens.
14417 * cs-tokenizer.cs: yield is no longer a keyword.
14419 2004-01-23 Marek Safar <marek.safar@seznam.cz>
14421 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
14422 setting for default constructors.
14423 For default constructors are almost every time set wrong Modifier. The
14424 generated IL code has been alright. But inside mcs this values was
14425 wrong and this was reason why several of my CLS Compliance tests
14428 2004-01-22 Martin Baulig <martin@ximian.com>
14430 * cs-parser.jay (namespace_or_type_name): Return an Expression,
14431 not a QualifiedIdentifier. This is what `type_name_expression'
14432 was previously doing.
14433 (type_name_expression): Removed; the code is now in
14434 `namespace_or_type_name'.
14435 (qualified_identifier): Removed, use `namespace_or_type_name'
14437 (QualifiedIdentifier): Removed this class.
14439 2004-01-22 Martin Baulig <martin@ximian.com>
14441 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
14442 not a string as alias name.
14444 2004-01-21 Miguel de Icaza <miguel@ximian.com>
14446 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
14447 #52730 bug, and instead compute correctly the need to use a
14448 temporary variable when requesting an address based on the
14449 static/instace modified of the field and the constructor.
14451 2004-01-21 Martin Baulig <martin@ximian.com>
14453 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
14454 class and namespace before looking up aliases. Fixes #52517.
14456 2004-01-21 Martin Baulig <martin@ximian.com>
14458 * flowanalysis.cs (UsageVector.Merge): Allow variables being
14459 assinged in a 'try'; fixes exception4.cs.
14461 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14462 * class.cs : Implemented parameter-less constructor for TypeContainer
14464 * decl.cs: Attributes are now stored here. New property OptAttributes
14466 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
14468 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
14470 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14472 * typemanager.cs (CSharpSignature): Now reports also inner class name.
14473 (CSharpSignature): New method for indexer and property signature.
14475 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14477 * pending.cs (IsVirtualFilter): Faster implementation.
14479 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14481 * typemanager.cs: Avoid inclusion of same assembly more than once.
14483 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14485 * cs-parser.jay: Fixed problem where the last assembly attribute
14486 has been applied also to following declaration (class, struct, etc.)
14488 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14490 * class.cs: Added error CS0538, CS0539 reporting.
14491 Fixed crash on Microsoft runtime when field type is void.
14493 * cs-parser.jay: Added error CS0537 reporting.
14495 * pending.cs: Added error CS0535 reporting.
14496 Improved error report for errors CS0536, CS0534.
14498 2004-01-20 Miguel de Icaza <miguel@ximian.com>
14500 Merge a few bits from the Anonymous Method MCS tree.
14502 * statement.cs (ToplevelBlock): New class for toplevel methods,
14503 will hold anonymous methods, lifted variables.
14505 * cs-parser.jay: Create toplevel blocks for delegates and for
14506 regular blocks of code.
14508 2004-01-20 Martin Baulig <martin@ximian.com>
14510 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
14511 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
14512 and `NeedExplicitReturn'; added `IsLastStatement'.
14513 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
14514 have a `ReturnLabel' or we're not unreachable.
14516 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
14517 child's reachability; don't just override ours with it. Fixes
14518 #58058 (lluis's example).
14519 (FlowBranching): Added public InTryOrCatch(), InCatch(),
14520 InFinally(), InLoop(), InSwitch() and
14521 BreakCrossesTryCatchBoundary() methods.
14523 * statement.cs (Return): Do all error checking in Resolve().
14524 Unless we are the last statement in a top-level block, always
14525 create a return label and jump to it.
14526 (Break, Continue): Do all error checking in Resolve(); also make
14527 sure we aren't leaving a `finally'.
14528 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
14529 statement in a top-level block.
14530 (Block.Flags): Added `IsDestructor'.
14531 (Block.IsDestructor): New public property.
14533 2004-01-20 Martin Baulig <martin@ximian.com>
14535 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
14537 2004-01-20 Martin Baulig <martin@ximian.com>
14539 * statement.cs (Statement.ResolveUnreachable): New public method.
14540 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
14541 (Block.Resolve): Resolve unreachable statements.
14543 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14545 * expression.cs: We need to fix the case where we do
14546 not have a temp variable here.
14548 * assign.cs: Only expression compound assignments need
14549 temporary variables.
14551 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14553 * flowanalysis.cs: Reduce memory allocation in a few ways:
14554 - A block with no variables should not allocate a bit
14556 - A method with no out parameters does not need any tracking
14557 for assignment of the parameters, so we need not allocate
14560 public readonly Type[] VariableTypes;
14561 public readonly string[] VariableNames;
14562 Are redundant. The data is already stored in the variable
14563 map, so we need not allocate another array for it.
14564 - We need to add alot of checks for if (params | locals) == null
14565 due to the first two changes.
14567 2004-01-18 Miguel de Icaza <miguel@ximian.com>
14569 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
14570 implement IMemoryLocation, we store a copy on a local variable and
14571 take the address of it. Patch from Benjamin Jemlich
14573 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
14574 to use a special "type_name_expression" rule which reduces the
14575 number of "QualifiedIdentifier" classes created, and instead
14576 directly creates MemberAccess expressions.
14578 2004-01-17 Miguel de Icaza <miguel@ximian.com>
14580 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
14581 that fixes #52853. Null literal assignment to ValueType
14583 * class.cs (MethodData.Emit): Instead of checking the name of the
14584 method to determine if its a destructor, create a new derived
14585 class from Method called Destructor, and test for that.
14587 * cs-parser.jay: Create a Destructor object instead of a Method.
14589 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
14593 2004-01-16 Miguel de Icaza <miguel@ximian.com>
14595 * expression.cs (Binary.ResolveOperator): Perform an implicit
14596 conversion from MethodGroups to their delegate types on the
14597 Addition operation.
14599 * delegate.cs: Introduce a new class DelegateCreation that is the
14600 base class for `NewDelegate' and `ImplicitDelegateCreation',
14601 factor some code in here.
14603 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
14604 conversion from MethodGroups to compatible delegate types.
14606 * ecore.cs (Expression.Resolve): Do not flag error 654
14607 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
14608 we allow conversions from MethodGroups to delegate types now.
14610 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
14611 assignments in v2 either.
14613 2004-01-10 Miguel de Icaza <miguel@ximian.com>
14615 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
14616 static read-only fields in ctors.
14618 Applied patch from Benjamin Jemlich
14620 * expression.cs (UnaryMutator): Avoid leaking local variables.
14622 2004-01-09 Miguel de Icaza <miguel@ximian.com>
14624 * cs-tokenizer.cs (IsCastToken): Allow the various native types
14625 here to return true, as they can be used like this:
14627 (XXX) int.MEMBER ()
14629 Fixed 49836 and all the other dups
14631 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
14633 * driver.cs: Implement /win32res and /win32icon.
14635 2004-01-08 Miguel de Icaza <miguel@ximian.com>
14637 * cs-parser.jay: Add a rule to improve error handling for the
14638 common mistake of placing modifiers after the type.
14640 2004-01-07 Miguel de Icaza <miguel@ximian.com>
14642 * cs-parser.jay (interface_event_declaration): Catch
14643 initialization of events on interfaces, and report cs0068
14645 * cs-parser.jay (interface_event_declaration): Catch
14646 initialization of events.
14648 * ecore.cs: Better report missing constructors.
14650 * expression.cs (Binary.ResolveOperator): My previous bug fix had
14651 the error reporting done in the wrong place. Fix.
14653 * expression.cs (Binary.ResolveOperator): Catch the
14654 operator + (E x, E y) error earlier, and later allow for implicit
14655 conversions in operator +/- (E e, U x) from U to the underlying
14658 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
14659 52596, if the container class is abstract, the default constructor
14660 is protected otherwise its public (before, we were always public).
14662 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
14665 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
14666 Jemlich that fixes bug #52597, MCS was generating invalid code for
14667 idisposable structs. Thanks to Ben for following up with this
14670 2004-01-06 Miguel de Icaza <miguel@ximian.com>
14672 * driver.cs: Allow assemblies without code to be generated, fixes
14675 2004-01-07 Nick Drochak <ndrochak@gol.com>
14677 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
14679 2004-01-05 Miguel de Icaza <miguel@ximian.com>
14681 * cs-parser.jay: Add rules to improve error reporting if fields or
14682 methods are declared at the namespace level (error 116)
14684 * Add rules to catch event add/remove
14686 2004-01-04 David Sheldon <dave-mono@earth.li>
14688 * expression.cs: Added matching ")" to error message for
14691 2004-01-03 Todd Berman <tberman@gentoo.org>
14693 * ecore.cs, attribute.cs:
14694 Applying fix from #52429.
14696 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14698 * ecore.cs, expression.cs, statement.cs:
14699 Total rewrite of how we handle branching. We
14700 now handle complex boolean expressions with fewer
14701 jumps. As well if (x == 0) no longer emits a ceq.
14703 if (x is Foo) is much faster now, because we generate
14706 Overall, we get a pretty big improvement on our benchmark
14707 tests. The code we generate is smaller and more readable.
14709 I did a full two-stage bootstrap. The patch was reviewed
14710 by Martin and Miguel.
14712 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14714 * cs-parser.jay: Make primary_expression not take a QI.
14715 we dont need this because the member_access rule covers
14716 us here. So we replace the rule with just IDENTIFIER.
14718 This has two good effects. First, we remove a s/r conflict.
14719 Second, we allocate many fewer QualifiedIdentifier objects.
14721 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14723 * attribute.cs: Handle MarshalAs attributes as pseudo, and
14724 set the correct information via SRE. This prevents
14725 hanging on the MS runtime. Fixes #29374.
14727 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14729 * convert.cs: correctly handle conversions to value types
14730 from Enum and ValueType as unboxing conversions.
14732 Fixes bug #52569. Patch by Benjamin Jemlich.
14734 2004-01-02 Ravi Pratap <ravi@ximian.com>
14736 * expression.cs (BetterConversion): Prefer int -> uint
14737 over int -> ulong (csc's behaviour). This fixed bug #52046.
14739 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
14741 * decl.cs (MemberCache.FindMembers): now returns a
14744 * typemanager.cs: In general, go with with ^^.
14745 (CopyNewMethods): take an IList.
14746 (RealMemberLookup): Only allocate an arraylist
14747 if we copy from two sets of methods.
14749 This change basically does two things:
14750 1) Fewer array lists allocated due to CopyNewMethods.
14751 2) the explicit cast in MemberList costed ALOT.
14753 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
14755 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
14756 a hashtable to avoid needless string allocations when an identifier is
14757 used more than once (the common case).
14759 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14761 * pending.cs: MS's TypeBuilder.GetInterfaces ()
14762 is broken, it will not return anything. So, we
14763 have to use the information we have in mcs to
14766 * typemanager.cs: Add a cache for GetInterfaces,
14767 since this will now be used more often (due to ^^)
14769 (GetExplicitInterfaces) New method that gets the
14770 declared, not effective, interfaces on a type
14771 builder (eg, if you have interface IFoo, interface
14772 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
14775 This patch makes MCS able to bootstrap itself on
14778 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14780 * expression.cs: Remove the Nop's that Miguel put
14783 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14785 * report.cs, codegen.cs: Give the real stack trace to
14786 the error when an exception is thrown.
14788 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14790 * decl.cs: only allocate hashtables for ifaces if
14793 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14795 * expression.cs: fix the error from cs0121-2.cs
14796 (a parent interface has two child interfaces that
14797 have a function with the same name and 0 params
14798 and the function is called through the parent).
14800 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
14802 * class.cs, rootcontext.cs, typmanager.cs: do not
14805 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
14807 * codegen.cs: remove stack for the ec flow branching.
14808 It is already a linked list, so no need.
14810 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
14812 * Makefile: Allow custom profiler here.
14814 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14816 * typemanager.cs (LookupType):
14817 - Use a static char [], because split takes
14818 a param array for args, so it was allocating
14820 - Do not store true in a hashtable, it boxes.
14822 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14824 * flowanalysis.cs: bytify common enums.
14826 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14828 * modifiers.cs: Add a new set of flags for the
14829 flags allowed on explicit interface impls.
14830 * cs-parser.jay: catch the use of modifiers in
14831 interfaces correctly.
14832 * class.cs: catch private void IFoo.Blah ().
14834 All related to bug #50572.
14836 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14838 * decl.cs: Rewrite the consistant accessability checking.
14839 Accessability is not linear, it must be implemented in
14840 a tableish way. Fixes #49704.
14842 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14844 * expression.cs: Handle negation in a checked context.
14845 We must use subtraction from zero. Fixes #38674.
14847 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14849 * class.cs: Ignore static void main in DLLs.
14850 * rootcontext.cs: Handle the target type here,
14851 since we are have to access it from class.cs
14852 * driver.cs: account for the above.
14854 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14856 * report.cs: Give line numbers and files if available.
14858 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
14860 * driver.cs: Implement /addmodule.
14862 * typemanager.cs: Change 'modules' field so it now contains Modules not
14865 2003-12-20 Martin Baulig <martin@ximian.com>
14867 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
14868 (FieldBase.IsAssigned): Removed this field.
14869 (FieldBase.SetAssigned): New public method.
14870 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
14872 2003-12-20 Martin Baulig <martin@ximian.com>
14874 * expression.cs (LocalVariableReference.DoResolve): Don't set
14875 `vi.Used' if we're called from DoResolveLValue().
14877 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
14878 returns the usage vector it just merged into the current one -
14879 pass this one to UsageWarning().
14880 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
14881 of the `EmitContext', don't call this recursively on our children.
14883 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
14885 * driver.cs: Implement /target:module.
14887 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
14889 * support.cs (CharArrayHashtable): New helper class.
14891 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
14892 char arrays, not strings, so we can avoid creating a string in
14893 consume_identifier if the identifier is a keyword.
14895 2003-12-16 Martin Baulig <martin@ximian.com>
14897 * statement.cs (LocalInfo.Assigned): Removed this property.
14898 (LocalInfo.Flags): Removed `Assigned'.
14899 (LocalInfo.IsAssigned): New public method; takes the EmitContext
14900 and uses flow analysis.
14901 (Block.UsageWarning): Made this method private.
14902 (Block.Resolve): Call UsageWarning() if appropriate.
14904 * expression.cs (LocalVariableReference.DoResolve): Always set
14905 LocalInfo.Used here.
14907 2003-12-13 Martin Baulig <martin@ximian.com>
14909 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
14910 any value here; we're now using flow analysis to figure out
14911 whether a statement/block returns a value.
14913 2003-12-13 Martin Baulig <martin@ximian.com>
14915 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
14917 (FlowBranching.MergeFinally): Don't call
14918 `branching.CheckOutParameters()' here, this is called in
14920 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
14921 when adding the `finally' vector.
14923 2003-12-13 Martin Baulig <martin@ximian.com>
14926 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
14927 actually work and also fix #48962.
14929 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
14931 * decl.cs: Do not check System.Object for nested types,
14932 since we know it does not have any. Big bang for buck:
14935 Run 1: 8.35 seconds
14936 Run 2: 8.32 seconds
14937 corlib: 17.99 seconds
14939 Run 1: 8.17 seconds
14940 Run 2: 8.17 seconds
14941 corlib: 17.39 seconds
14943 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
14945 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
14946 time we are returning 0 members, so we save alot here.
14948 2003-12-11 Martin Baulig <martin@ximian.com>
14950 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
14951 `MergeChild()', also just take the `FlowBranching' as argument;
14952 call Merge() on it and return the result.
14953 (FlowBranching.Merge): We don't need to do anything if we just
14956 2003-12-11 Martin Baulig <martin@ximian.com>
14958 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
14959 them in an `ArrayList' to reduce memory usage. Thanks to Ben
14960 Maurer for this idea.
14962 2003-12-11 Martin Baulig <martin@ximian.com>
14964 * flowanalysis.cs (MergeResult): This class is now gone; we now
14965 use the `UsageVector' for this. The reason for this is that if a
14966 branching just has one sibling, we don't need to "merge" them at
14967 all - that's the next step to do.
14968 (FlowBranching.Merge): We now return a `UsageVector' instead of a
14971 2003-12-11 Martin Baulig <martin@ximian.com>
14973 Reworked flow analyis and made it more precise and bug-free. The
14974 most important change is that we're now using a special `Reachability'
14975 class instead of having "magic" meanings of `FlowReturns'. I'll
14976 do some more cleanups and optimizations and also add some more
14977 documentation this week.
14979 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
14980 largely reworked this class.
14981 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
14982 the new `Reachability' class instead of having "magic" values here.
14983 (FlowBranching): We're now using an instance of `Reachability'
14984 instead of having separate `Returns', `Breaks' etc. fields.
14986 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
14987 based on flow analysis; ignore the return value of block.Emit ().
14989 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
14991 * driver.cs typemanager.cs: Find the mono extensions to corlib even
14992 if they are private.
14994 2003-12-09 Martin Baulig <martin@ximian.com>
14996 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
14997 call them directly on the UsageVector.
14999 2003-12-09 Martin Baulig <martin@ximian.com>
15001 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
15002 Changed return type from `FlowReturns' to `Reachability'.
15004 2003-12-09 Martin Baulig <martin@ximian.com>
15006 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
15007 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
15008 `Reachable' fields with a single `Reachability' one.
15010 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15012 * class.cs (FindMembers): Remove foreach's.
15017 Run 1: 8.74 seconds
15018 Run 2: 8.71 seconds
15021 Run 1: 8.64 seconds
15022 Run 2: 8.58 seconds
15025 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15030 This patch does a few things:
15031 1. EmptyStatement is now a singleton, so it is never reallocated.
15032 2. All blah is EmptyStatement constructs have been changed to
15033 blah == EmptyStatement.Value, which is much faster and valid
15034 now that EmptyStatement is a singleton.
15035 3. When resolving a block, rather than allocating a new array for
15036 the non-empty statements, empty statements are replaced with
15037 EmptyStatement.Value
15038 4. Some recursive functions have been made non-recursive.
15039 Mainly the performance impact is from (3), however (1) and (2) are needed for
15040 this to work. (4) does not make a big difference in normal situations, however
15041 it makes the profile look saner.
15046 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15047 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15048 Total memory allocated: 56397 KB
15051 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
15052 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
15053 Total memory allocated: 55666 KB
15055 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15057 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15058 than the hashtable in a hashtable version
15060 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
15061 we always end up concating a string. This results in a huge perf
15062 loss, because many strings have to be tracked by the GC. In this
15063 patch, we first use a hashtable that works with two keys, so that
15064 the strings do not need to be concat'ed.
15068 Run 1: 8.74 seconds
15069 Run 2: 8.71 seconds
15072 Run 1: 8.65 seconds
15073 Run 2: 8.56 seconds
15075 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15077 * Makefile: Add a new target `do-time' that does a quick and simple
15078 profile, leaving easy to parse output.
15080 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
15082 * codegen.cs (Init): Create the dynamic assembly with
15083 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
15085 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
15087 * support.cs: Make the PtrHashtable use only one
15088 instance of its comparer.
15090 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
15092 * typemanager.cs: Fix lookup of GetNamespaces.
15094 2003-11-29 Miguel de Icaza <miguel@ximian.com>
15096 * expression.cs: Removed redundant line.
15098 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
15099 ArrayLists, use for loops with bounds.
15101 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
15104 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
15105 arraylists, use for loop with bounds.
15107 The above three changes give us a 0.071 second performance
15108 improvement out of 3.294 seconds down to 3.223. On my machine
15109 the above changes reduced the memory usage by 1,387 KB during
15110 compiler bootstrap.
15112 * cs-parser.jay (QualifiedIdentifier): New class used to represent
15113 QualifiedIdentifiers. Before we created a new string through
15114 concatenation, and mostly later on, the result would be
15115 manipulated by DecomposeQI through string manipulation.
15117 This reduced the compiler memory usage for bootstrapping from
15118 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
15119 compile times in 0.05 seconds.
15121 2003-11-28 Dick Porter <dick@ximian.com>
15123 * support.cs: Do string compares with the Invariant culture.
15131 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
15132 the comparison is done with the Invariant culture.
15134 2003-11-27 Miguel de Icaza <miguel@ximian.com>
15136 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
15137 GetEnumerator method.
15139 (ProbeCollectionType): Iterate starting at the most specific type
15140 upwards looking for a GetEnumerator
15142 * expression.cs: Shift count can be up to 31 for int/uint and 63
15145 2003-11-26 Miguel de Icaza <miguel@ximian.com>
15147 * statement.cs (Block.LookupLabel): Also look for the label on the
15148 children blocks. Use a hash table to keep track of visited
15151 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
15152 we actually did transform the other operand, otherwise fall back
15153 to the common codepath that casts to long.
15155 * cs-tokenizer.cs: Use the same code pattern as the int case.
15156 Maybe I should do the parsing myself, and avoid depending on the
15157 Parse routines to get this done.
15159 2003-11-25 Miguel de Icaza <miguel@ximian.com>
15161 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15162 which fixes bug 51347. This time test it.
15164 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
15165 attributes for example can not tell the difference between these.
15166 The difference was only a syntax feature of the language.
15168 * attribute.cs: Apply attributes to delegates.
15170 * delegate.cs: Call the apply attributes method.
15172 2003-11-24 Miguel de Icaza <miguel@ximian.com>
15174 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
15175 comparing 0 vs Byte.MinValue, not the value
15177 (ImplicitConversionRequired): When reporting a conversion error,
15178 use error 31 to print out the constant error instead of the
15181 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15182 which fixes bug 51347.
15184 2003-11-22 Miguel de Icaza <miguel@ximian.com>
15186 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
15187 which fixes the -warnaserror command line option.
15189 2003-11-21 Miguel de Icaza <miguel@ximian.com>
15191 * cfold.cs (DoNumericPromotions): During constant folding of
15192 additions on UIntConstant, special case intconstants with
15193 IntConstants like we do on the expression binary operator.
15195 2003-11-12 Miguel de Icaza <miguel@ximian.com>
15197 * convert.cs (ImplicitReferenceConversion): We were missing a case
15198 (System.Enum are not value types or class types, so we need to
15199 classify them separatedly).
15201 * driver.cs: We do not support error 2007.
15203 2003-11-12 Jackson Harper <jackson@ximian.com>
15205 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
15206 system directory. Also use the full file name so users can
15207 libraries names mscorlib-o-tron.dll in a non system dir.
15209 2003-11-10 Martin Baulig <martin@ximian.com>
15211 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
15212 (TypeManager.InitCoreTypes): Initialize them here, but instead of
15213 calling `ResolveType()' on them, directly assign their `Type'.
15215 2003-11-08 Martin Baulig <martin@ximian.com>
15217 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
15218 return value and the `out parent' parameter.
15219 (TypeContainer.DefineType): Moved the CS0644 check into
15220 GetClassBases(). Don't pass the interface types to the
15221 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
15222 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
15224 * ecore.cs (TypeExpr.IsAttribute): New property.
15225 (TypeExpr.GetInterfaces): New method.
15227 * interface.cs (Interface.GetInterfaceTypeByName): Return a
15228 TypeExpr instead of a Type.
15229 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
15230 (Interface.DefineType): Don't pass the interface types to the
15231 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
15232 them later and then call `TypeBulider.AddInterfaceImplementation()'.
15234 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
15235 instead of a `Type[]'.
15236 (TypeManager.RegisterBuilder): Likewise.
15237 (TypeManager.AddUserInterface): Likewise.
15238 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
15239 `Type[]' and also return a `TypeExpr[]'.
15240 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
15242 2003-11-08 Martin Baulig <martin@ximian.com>
15244 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
15247 2003-11-08 Martin Baulig <martin@ximian.com>
15249 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
15250 TypeManager.ResolveExpressionTypes().
15252 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
15253 instead of an Expression.
15254 (TypeExpr): This is now an abstract base class for `TypeExpression'.
15255 (TypeExpression): New public class; formerly known as `TypeExpr'.
15257 * expression.cs (ComposedCast): Derive from TypeExpr.
15259 * typemanager.cs (TypeManager.system_*_expr): These are now
15260 TypExpr's instead of Expression's.
15261 (TypeManager.ResolveExpressionTypes): New public static function;
15262 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
15265 2003-11-06 Miguel de Icaza <miguel@ximian.com>
15267 * expression.cs (New.DoResolve): Do not dereference value that
15268 might be a null return.
15270 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
15271 sure that the constant value has the right type. Fixes an
15272 unreported bug, similar to 50425.
15274 * const.cs (Const.LookupConstantValue): Call
15275 ImplicitStandardConversionExists before doing a conversion to
15276 avoid havng the TypeManager.ChangeType do conversions.
15278 Reduced the number of casts used
15280 (Const.ChangeType): New routine to enable reuse of the constant
15281 type changing code from statement.
15283 * typemanager.cs (ChangeType): Move common initialization to
15284 static global variables.
15288 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
15289 every value type to go through, even if it was void. Fix that.
15291 * cs-tokenizer.cs: Use is_identifier_start_character on the start
15292 character of the define, and the is_identifier_part_character for
15293 the rest of the string.
15295 2003-11-05 Miguel de Icaza <miguel@ximian.com>
15297 * expression.cs (UnaryMutator.EmitCode): When I updated
15298 LocalVariableReference.DoResolve, I overdid it, and dropped an
15299 optimization done on local variable references.
15301 2003-11-04 Miguel de Icaza <miguel@ximian.com>
15303 * ecore.cs: Convert the return from Ldlen into an int.
15305 2003-10-20 Miguel de Icaza <miguel@ximian.com>
15307 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
15308 the accessibility, this is a special case for toplevel non-public
15309 classes (internal for instance).
15311 2003-10-20 Nick Drochak <ndrochak@gol.com>
15313 * ecore.cs: Fix typo and build. Needed another right paren.
15315 2003-10-19 Miguel de Icaza <miguel@ximian.com>
15317 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
15318 `internal' case regular and protected, but not allowing protected
15319 to be evaluated later. Bug 49840
15321 2003-10-15 Miguel de Icaza <miguel@ximian.com>
15323 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
15324 to kb.Nlast, and not the kb.nFirst to isolate the switch
15327 Extract the underlying type, so enumerations of long/ulong are
15328 treated like long/ulong.
15330 2003-10-14 Miguel de Icaza <miguel@ximian.com>
15332 * expression.cs (New): Overload the meaning of RequestedType to
15333 track the possible creation of the NewDelegate type, since
15334 DoResolve is invoked more than once for new constructors on field
15337 See bugs: #48800 and #37014
15339 * cs-parser.jay (declare_local_constants): Take an arraylist
15340 instead of a single constant.
15342 (local_constant_declaration): It should take a
15343 constant_declarators, not a constant_declarator. Fixes 49487
15345 * convert.cs: Fix error report.
15347 2003-10-13 Jackson Harper <jackson@ximian.com>
15349 * typemanager.cs (TypeToCoreType): Add float and double this fixes
15352 2003-10-09 Martin Baulig <martin@ximian.com>
15354 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
15356 (MethodCore.DoDefineParameters): Removed the TypeContainer
15357 argument; use the DeclSpace which was passed to the .ctor instead.
15358 (MethodCore.CheckParameter): Take a DeclSpace instead of a
15359 TypeContainer; we only need a DeclSpace here.
15361 2003-10-09 Martin Baulig <martin@ximian.com>
15363 * class.cs (MethodData): Added additional `DeclSpace ds' argument
15365 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
15366 EmitContext's .ctor.
15368 2003-10-09 Martin Baulig <martin@ximian.com>
15370 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
15371 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
15372 AsAccessible(), moved them as well.
15374 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
15376 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
15378 * cs-parser.jay : Renamed yyName to yyNames related to jay.
15380 2003-10-07 Miguel de Icaza <miguel@ximian.com>
15382 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
15383 generation for >=, as spotted by Paolo, bug 48679.
15384 Patch from David Waite.
15386 * cs-tokenizer.cs: Add handling for #pragma.
15388 * cs-parser.jay: Allow for both yield and yield return in the
15389 syntax. The anti-cobolization of C# fight will go on!
15391 * class.cs (TypeBuilder.DefineType): Catch error condition here
15392 (Parent.DefineType erroring out and returning null).
15394 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15395 coping with enumerations variables, we were mistakenly processing
15396 them as a regular value type instead of built-in types. Fixes the
15399 * typemanager.cs (IsBuiltinOrEnum): New method.
15401 2003-09-30 Miguel de Icaza <miguel@ximian.com>
15403 * cs-parser.jay: Upgrade: yield now needs the return clause.
15405 2003-09-19 Martin Baulig <martin@ximian.com>
15407 * decl.cs (MemberCache.SetupCacheForInterface): Take a
15408 `MemberCache parent' argument. Normally, an interface doesn't
15409 have a parent type except System.Object, but we use this in gmcs
15410 for generic type parameters.
15412 2003-09-18 Martin Baulig <martin@ximian.com>
15414 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
15415 on `type.IsInterface'; don't check whether the type has a parent
15416 to determine whether it's an interface.
15418 2003-09-15 Martin Baulig <martin@ximian.com>
15420 * class.cs (TypeContainer.DefineType): Added an error flag to
15421 avoid reporting duplicate CS0146's ("class definition is
15424 * driver.cs (Driver.MainDriver): Abort if
15425 RootContext.ResolveTree() reported any errors.
15427 2003-09-07 Martin Baulig <martin@ximian.com>
15429 * report.cs (Error, Warning): Added overloaded versions which take
15430 a `params object[] args' and call String.Format().
15432 2003-09-07 Martin Baulig <martin@ximian.com>
15434 * decl.cs (DeclSpace..ctor): Don't call
15435 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
15436 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
15437 (DeclSpace.RecordDecl): New method.
15439 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
15441 2003-09-02 Ravi Pratap <ravi@ximian.com>
15443 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
15444 value attributes to be applied to ParameterBuilders.
15446 * class.cs (MethodCore.LabelParameters): Make static and more
15447 generic so that it can be used from other places - like interface
15448 methods, for instance.
15450 * interface.cs (Interface.Emit): Call LabelParameters before
15451 emitting attributes on the InterfaceMethod.
15453 2003-08-26 Martin Baulig <martin@ximian.com>
15455 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
15456 resolving aliases; fixes #47927.
15458 2003-08-26 Martin Baulig <martin@ximian.com>
15460 * statement.cs (Using.DoResolve): This is internally emitting a
15461 try/finally clause, so we need to set ec.NeedExplicitReturn if we
15462 do not always return. Fixes #47681.
15464 2003-08-26 Martin Baulig <martin@ximian.com>
15466 * decl.cs (MemberCore): Moved WarningNotHiding(),
15467 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
15469 (AdditionResult): Make this nested in DeclSpace.
15470 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
15471 argument; call NamespaceEntry.Define() unless we're nested in a
15474 * namespace.cs (Namespace.DefineName): New public function. This
15475 is called from DeclSpace's .ctor to add
15476 (Namespace.Lookup): Include DeclSpaces in the lookup.
15478 * class.cs (Operator): Derive from MemberBase, not MemberCore.
15480 * const.cs (Const): Derive from MemberBase, not MemberCore.
15482 2003-08-25 Martin Baulig <martin@ximian.com>
15484 * convert.cs (Convert.ExplicitReferenceConversion): When
15485 converting from an interface type to a class, unbox if the target
15486 type is a struct type. Fixes #47822.
15488 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15490 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
15493 2003-08-22 Martin Baulig <martin@ximian.com>
15495 * class.cs (TypeManager.DefineType): When defining a nested type,
15496 call DefineType() on our parent; fixes #47801.
15498 2003-08-22 Martin Baulig <martin@ximian.com>
15500 * class.cs (MethodData.Define): While checking if a method is an
15501 interface implementation, improve the test a bit more to fix #47654.
15503 2003-08-22 Martin Baulig <martin@ximian.com>
15505 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
15506 correctly; fixes #47722.
15508 2003-08-22 Martin Baulig <martin@ximian.com>
15510 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
15511 LocalVariableReference, ensure it's not read-only. Fixes #47536.
15513 * statement.cs (Fixed.DoResolve): Make all variables read-only.
15515 2003-08-22 Martin Baulig <martin@ximian.com>
15517 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
15518 can only be assigned in static constructors. Fixes #47161.
15520 2003-08-22 Martin Baulig <martin@ximian.com>
15522 Rewrote and improved the flow analysis code.
15524 * flowbranching.cs (FlowBranching): Make this class abstract.
15525 (FlowBranching.CreateBranching): New static function to create a
15526 new flow branching.
15527 (FlowBranchingBlock, FlowBranchingException): New classes.
15528 (FlowBranching.UsageVector.Type): New public readonly field.
15529 (FlowBranching.UsageVector.Breaks): Removed the setter.
15530 (FlowBranching.UsageVector.Returns): Removed the setter.
15531 (FlowBranching.UsageVector): Added Break(), Return(),
15532 NeverReachable() and Throw() methods to modify the reachability.
15533 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
15534 done by FlowBranching.Merge().
15535 (FlowBranching.UsageVector.MergeChild): New method; merges the
15536 merge result into the current vector.
15537 (FlowBranching.Merge): New abstract method to merge a branching.
15539 2003-08-12 Martin Baulig <martin@ximian.com>
15541 * expression.cs (Indirection.CacheTemporaries): Create the
15542 LocalTemporary with the pointer type, not its element type.
15544 2003-08-10 Miguel de Icaza <miguel@ximian.com>
15546 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
15547 token was a keyword or not.
15549 Add `error' options where an IDENTIFIER was expected; Provide
15550 CheckToken and CheckIdentifierToken convenience error reporting
15553 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
15555 * decl.cs: Rename `NamespaceEntry Namespace' public field into
15556 NameSpaceEntry NameSpaceEntry.
15558 (LookupInterfaceOrClass): Avoid creating a full qualified name
15559 from namespace and name: avoid doing lookups when we know the
15560 namespace is non-existant. Use new Tree.LookupByNamespace which
15561 looks up DeclSpaces based on their namespace, name pair.
15563 * driver.cs: Provide a new `parser verbose' to display the
15564 exception thrown during parsing. This is turned off by default
15565 now, so the output of a failure from mcs is more graceful.
15567 * namespace.cs: Track all the namespaces defined in a hashtable
15570 (IsNamespace): New method
15572 2003-08-09 Miguel de Icaza <miguel@ximian.com>
15574 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
15575 we know that we need to concatenate (full typename can never be
15580 * statement.cs: Use a bitfield; Do not initialize to null things
15581 which are done by the constructor by default.
15583 * cs-parser.jay: bug fix, parameter was 4, not 3.
15585 * expression.cs: Just use the property;
15587 * statement.cs: No need for GetVariableInfo method.
15589 2003-08-08 Martin Baulig <martin@ximian.com>
15591 * flowanalysis.cs (FlowReturns): This is now nested in the
15592 `FlowBranching' class.
15593 (MyBitVector): Moved this here from statement.cs.
15594 (FlowBranching.SiblingType): New enum type.
15595 (FlowBranching.CreateSibling): Added `SiblingType' argument.
15597 2003-08-07 Martin Baulig <martin@ximian.com>
15599 * flowanalysis.cs (FlowBranchingType): This is now nested in the
15600 `FlowBranching' class and called `BranchingType'.
15602 2003-08-07 Martin Baulig <martin@ximian.com>
15604 * flowanalysis.cs: Moved all the control flow analysis code into
15607 2003-08-07 Martin Baulig <martin@ximian.com>
15609 * assign.cs (Assign.DoResolve): `target' must either be an
15610 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
15613 2003-08-07 Miguel de Icaza <miguel@ximian.com>
15615 * expression.cs (BinaryMethod): This kind of expression is created by the
15616 Binary class if it determines that the operator has to be handled
15619 (BinaryDelegate): This kind of expression is created if we are
15620 dealing with a + or - operator on delegates.
15622 (Binary): remove method, argumetns, and DelegateOperator: when
15623 dealing with methods,
15625 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
15627 * statement.cs (Block): use bitfields for the three extra booleans
15628 we had in use. Remove unused topblock parameter.
15630 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
15632 * assign.cs: Drop extra unneeded tests.
15634 2003-08-06 Miguel de Icaza <miguel@ximian.com>
15636 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
15638 * statement.cs (Foreach): Use VariableStorage instead of
15641 * codegen.cs (VariableStorage): New class used by clients that
15642 require a variable stored: locals or fields for variables that
15643 need to live across yield.
15645 Maybe provide a convenience api for EmitThis+EmitLoad?
15647 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
15650 2003-08-05 Miguel de Icaza <miguel@ximian.com>
15652 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
15653 RemapParameterLValue): New methods that are used to turn a
15654 precomputed FieldInfo into an expression like this:
15658 The idea is to use this instead of making LocalVariableReference
15659 have more than one meaning.
15661 * cs-parser.jay: Add error production to BASE.
15663 * ecore.cs: Deal with TypeManager.GetField returning null, which
15664 is now a valid return value.
15666 (FieldExprNoAddress): New expression for Fields whose address can
15669 * expression.cs (LocalVariableReference): During the resolve
15670 phases, create new expressions if we are in a remapping context.
15671 Remove code that dealt with remapping here.
15673 (ParameterReference): same.
15675 (ProxyInstance): New expression, like the `This' expression, but
15676 it is born fully resolved. We know what we are doing, so remove
15677 the errors that are targeted to user-provided uses of `this'.
15679 * statement.cs (Foreach): our variable is now stored as an
15680 Expression; During resolution, follow the protocol, dont just
15681 assume it will return this.
15683 2003-08-06 Martin Baulig <martin@ximian.com>
15685 * support.cs (SeekableStreamReader.cs): New public class.
15687 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
15688 SeekableStreamReader instead of the normal StreamReader.
15690 2003-08-04 Martin Baulig <martin@ximian.com>
15692 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
15693 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
15694 deambiguate casts and delegate invocations.
15695 (parenthesized_expression): Use the new tokens to ensure this is
15696 not a cast of method invocation.
15698 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
15699 when reading a `)' and Deambiguate_CloseParens () was previously
15702 * expression.cs (ParenthesizedExpression): New class. This is
15703 just used for the CS0075 test.
15704 (Binary.DoResolve): Check for CS0075.
15706 2003-07-29 Ravi Pratap <ravi@ximian.com>
15708 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
15709 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
15710 reference comparison.
15712 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
15713 examine the ReturnType for equality - this is necessary in the
15714 cases of implicit and explicit operators whose signature also
15715 includes the return type.
15717 2003-07-26 Miguel de Icaza <miguel@ximian.com>
15719 * namespace.cs: Cache the result of the namespace computation,
15720 instead of computing it every time.
15722 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15724 * decl.cs: Use a global arraylist that we reuse over invocations
15725 to avoid excesive memory consumption. Reduces memory usage on an
15726 mcs compile by one meg (45 average).
15728 * typemanager.cs (LookupTypeReflection): In .NET pointers are
15729 private, work around that.
15731 2003-07-23 Miguel de Icaza <miguel@ximian.com>
15733 * literal.cs (IntLiteral): Define Zero and One static literals.
15735 * cs-parser.jay (integer_literal): use static literals to reduce
15736 memory usage for the most used literals (0, 1 and -1). 211kb
15737 reduced in memory usage.
15739 Replace all calls to `new ArrayList' with `new
15740 ArrayList(4)' which is a good average number for most allocations,
15741 and also requires only 16 bytes of memory for its buffer by
15744 This reduced MCS memory usage in seven megabytes for the RSS after
15747 2003-07-28 Ravi Pratap <ravi@ximian.com>
15749 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
15750 handle params methods the correct way by forming only one
15751 applicable set with params and normal methods in them. Earlier we
15752 were looking at params methods only if we found no normal methods
15753 which was not the correct thing to do.
15755 (Invocation.BetterFunction): Take separate arguments indicating
15756 when candidate and the best method are params methods in their
15759 This fixes bugs #43367 and #46199.
15761 * attribute.cs: Documentation updates.
15763 (CheckAttribute): Rename to CheckAttributeTarget.
15764 (GetValidPlaces): Rename to GetValidTargets.
15766 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
15767 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
15771 2003-07-28 Martin Baulig <martin@ximian.com>
15773 * class.cs (TypeContainer.DefineMembers): Use the base type's full
15774 name when looking up the base class of a nested class. Fixes #46977.
15776 2003-07-26 Martin Baulig <martin@ximian.com>
15778 * expression.cs (Indexers.Indexer): New nested struct; contains
15779 getter, setter and the indexer's type.
15780 (Indexers.Properties): This is now an ArrayList of
15781 Indexers.Indexer's.
15782 (IndexerAccess.DoResolveLValue): Correctly set the type if the
15783 indexer doesn't have any getters.
15785 * assign.cs (Assign.DoResolve): Also do the implicit conversions
15786 for embedded property and indexer assignments.
15788 2003-07-26 Martin Baulig <martin@ximian.com>
15790 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
15791 preprocessor directive is not the first non-whitespace character
15794 2003-07-26 Martin Baulig <martin@ximian.com>
15796 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
15797 namespace parsing, follow the spec more closely.
15799 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
15800 NamespaceEntry.Lookup().
15802 2003-07-25 Martin Baulig <martin@ximian.com>
15804 * MethodCore.cs (OverridesSomething): New public field; it's set
15805 from TypeContainer.DefineMembers if this method overrides
15806 something (which doesn't need to be a method). Fix #39462.
15808 2003-07-25 Ravi Pratap <ravi@ximian.com>
15810 * typemanager.cs (GetMembers): Ensure that the list of members is
15811 reversed. This keeps things in sync.
15813 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
15814 find an AttributeUsage attribute.
15816 * expression.cs (Invocation.OverloadResolve): Perform the check
15817 which disallows Invoke to be directly called on a Delegate.
15819 (Error_InvokeOnDelegate): Report error cs1533.
15821 2003-07-25 Martin Baulig <martin@ximian.com>
15823 * expression.cs (Indexers.GetIndexersForType): Only look in the
15824 interface hierarchy if the requested type is already an
15825 interface. Fixes #46788 while keeping #46502 fixed.
15827 2003-07-25 Martin Baulig <martin@ximian.com>
15829 * class.cs (TypeContainer.DefineMembers): Check whether all
15830 readonly fields have been assigned and report warning CS0649 if
15833 * statement.cs (LocalInfo.IsFixed): Always return true if this is
15836 2003-07-24 Ravi Pratap <ravi@ximian.com>
15838 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
15839 returned from GetMethods to make things consistent with the
15840 assumptions MCS makes about ordering of methods.
15842 This should comprehensively fix bug #45127 and it does :-)
15844 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
15845 ordering is actually reverse.
15847 * Clean up some debug messages I left lying around.
15849 * interface.cs (Populate*): Get rid of code which emits attributes
15850 since the stage in which we emit attributes is the 'Emit' stage,
15851 not the define stage.
15853 (Emit): Move attribute emission for interface members here.
15855 2003-07-22 Ravi Pratap <ravi@ximian.com>
15857 * expression.cs (Invocation.OverloadResolve): Follow the spec more
15858 closely: we eliminate methods in base types when we have an
15859 applicable method in a top-level type.
15861 Please see section 14.5.5.1 for an exact description of what goes
15864 This fixes bug #45127 and a host of other related to corlib compilation.
15866 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
15867 array is the method corresponding to the top-level type (this is
15868 because of the changes made to icall.c) so we change this
15871 (MethodGroupExpr.Name): This too.
15873 * typemanager.cs (GetElementType): New method which does the right
15874 thing when compiling corlib.
15876 * everywhere: Make use of the above in the relevant places.
15878 2003-07-22 Martin Baulig <martin@ximian.com>
15880 * cs-parser.jay (invocation_expression): Moved
15881 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
15882 `cast_expression', but create a InvocationOrCast which later
15883 resolves to either an Invocation or a Cast.
15885 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
15886 method; call this before EmitStatement() to make sure that this
15887 expression can be used as a statement.
15889 * expression.cs (InvocationOrCast): New class; resolves to either
15890 an Invocation or a Cast.
15892 * statement.cs (StatementExpression): Call ResolveStatement() on
15893 the ExpressionStatement before emitting it.
15895 2003-07-21 Martin Baulig <martin@ximian.com>
15897 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
15898 `ref' and `out' attributes match; fixes #46220.
15899 (MemberAccess.ResolveMemberAccess): You can't reference a type
15900 through an expression; fixes #33180.
15901 (Indexers.GetIndexersForType): Don't return the indexers from
15902 interfaces the class implements; fixes #46502.
15904 2003-07-21 Martin Baulig <martin@ximian.com>
15906 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15907 CS0661 checks; fixes bug #30442.
15909 2003-07-21 Martin Baulig <martin@ximian.com>
15911 * decl.cs (AdditionResult): Added `Error'.
15913 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15915 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
15916 makes cs0031.cs actually work.
15918 2003-07-20 Martin Baulig <martin@ximian.com>
15920 * namespace.cs: Fixed that bug which caused a crash when compiling
15921 the debugger's GUI.
15923 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15925 * typemanager.cs (LookupTypeReflection): Never expose types which
15926 are NotPublic, NestedPrivate, NestedAssembly, or
15927 NestedFamANDAssem. We used to return these, and later do a check
15928 that would report a meaningful error, but the problem is that we
15929 would not get the real match, if there was a name override.
15931 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15933 * namespace.cs (Namespace, Name): Do not compute the namespace
15934 name dynamically, compute it in the constructor. This reduced
15935 memory usage by 1697 KB.
15937 * driver.cs: Use --pause to pause at the end.
15939 2003-07-17 Peter Williams <peter@newton.cx>
15941 * Makefile: Change the name of the test target so that it doesn't
15942 conflict with the recursive test target.
15944 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15946 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15947 AddressOf): Do not use EmitThis, that was wrong, use the actual
15950 2003-07-15 Miguel de Icaza <miguel@ximian.com>
15952 * class.cs (MethodData.Define): While checking if a method is an
15953 interface implementation, improve the test: If we are not public
15954 (use new test here: use the computed MethodAttributes directly,
15955 instead of the parsed modifier flags) check if the `implementing'
15956 method comes from an interface or not.
15958 * pending.cs (VerifyPendingMethods): Slightly better error
15961 * makefile: add test target that does the mcs bootstrap.
15963 2003-07-16 Ravi Pratap <ravi@ximian.com>
15965 * interface.cs (Define): Do nothing here since there are no
15966 members to populate etc. Move the attribute emission out of here
15967 since this was just totally the wrong place to put it. Attribute
15968 application happens during the 'Emit' phase, not in the 'Define'
15971 (Emit): Add this method and move the attribute emission here
15973 * rootcontext.cs (EmitCode): Call the Emit method on interface
15976 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15978 * expression.cs (OverloadResolve): Report error only if Location
15979 is not 'Null' which means that there was a probe going on.
15981 2003-07-14 Martin Baulig <martin@ximian.com>
15983 * expression.cs (ConditionalLogicalOperator): New public class to
15984 implement user defined conditional logical operators.
15985 This is section 14.11.2 in the spec and bug #40505.
15987 2003-07-14 Martin Baulig <martin@ximian.com>
15989 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15991 2003-07-14 Martin Baulig <martin@ximian.com>
15993 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15995 * ecore.cs (IVariable.VerifyFixed): New interface method.
15997 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15998 operator, check whether the variable is actually fixed. Fixes bug
15999 #36055. Set a variable definitely assigned when taking its
16000 address as required by the spec.
16002 * statement.cs (LocalInfo.IsFixed): New field.
16003 (LocalInfo.MakePinned): Set `IsFixed' to true.
16005 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16007 * attribute.cs (Attribute.Resolve): While doing a Member lookup
16008 for .ctors, ensure that we only ask for members declared in the
16009 attribute type (BindingFlags.DeclaredOnly).
16013 * expression.cs (Error_WrongNumArguments): Report error 1501
16014 correctly the way CSC does.
16016 2003-07-13 Martin Baulig <martin@ximian.com>
16018 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
16019 lookup on the fully qualified name, to make things like "X.X" work
16020 where "X.X" is a fully qualified type name, but we also have a
16021 namespace "X" in the using list. Fixes #41975.
16023 2003-07-13 Martin Baulig <martin@ximian.com>
16025 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
16026 function. If we're a CompoundAssign, we need to create an embedded
16027 CompoundAssign, not an embedded Assign.
16028 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
16031 2003-07-13 Martin Baulig <martin@ximian.com>
16033 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
16034 work to fix bug #46088.
16036 2003-07-13 Ravi Pratap <ravi@ximian.com>
16038 * class.cs (Operator.Emit): Do not emit attributes here - it is
16039 taken care of by the Method class that we delegate too. This takes
16040 care of bug #45876.
16042 2003-07-10 Martin Baulig <martin@ximian.com>
16044 * expression.cs (TypeOfVoid): New class.
16045 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
16047 2003-07-10 Martin Baulig <martin@ximian.com>
16049 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
16052 2003-07-10 Martin Baulig <martin@ximian.com>
16054 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
16055 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16057 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
16059 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
16061 2003-07-10 Martin Baulig <martin@ximian.com>
16063 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
16064 of decimal. Fixes #42850.
16066 NOTE: I also fixed the created byte blob, but this doesn't work on
16067 the MS runtime and csc never produces any byte blobs for decimal
16070 2003-07-10 Martin Baulig <martin@ximian.com>
16072 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
16073 structs; fixes #32068.
16074 (Block.AddChildVariableNames): Fixed #44302.
16076 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16078 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
16080 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16082 * attribute.cs: And this test is onger needed.
16084 2003-07-08 Martin Baulig <martin@ximian.com>
16086 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
16087 inaccessible types. Fixes #36313.
16089 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
16091 * namespace.cs (NamespaceEntry): Create implicit entries for all
16092 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
16093 implicit entries for N1.N2 and N1.
16095 2003-07-08 Martin Baulig <martin@ximian.com>
16097 Rewrote the handling of namespaces to fix a lot of the issues
16098 wrt. `using' aliases etc.
16100 * namespace.cs (Namespace): Splitted this class into a
16101 per-assembly `Namespace' and a per-file `NamespaceEntry'.
16103 * typemanager.cs (TypeManager.IsNamespace): Removed.
16104 (TypeManager.ComputeNamespaces): Only compute namespaces from
16105 loaded assemblies here, not the namespaces from the assembly we're
16106 currently compiling.
16108 2003-07-08 Martin Baulig <martin@ximian.com>
16110 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
16112 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16114 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
16117 I thought about the memory savings here, but LookupTypeReflection
16118 is used under already very constrained scenarios. Compiling
16119 corlib or mcs only exposes one hit, so it would not really reduce
16120 any memory consumption.
16122 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16124 * typemanager.cs: fixes bug #45889 by only adding public types from
16125 other assemblies to the list of known types.
16127 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16129 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
16130 on the type we resolved.
16132 2003-07-05 Martin Baulig <martin@ximian.com>
16134 * pending.cs (PendingImplementation.ParentImplements): Don't
16135 create the proxy if the parent is abstract.
16137 * class.cs (TypeContainer.DefineIndexers): Process explicit
16138 interface implementations first. Fixes #37714.
16140 2003-07-04 Miguel de Icaza <miguel@ximian.com>
16142 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
16143 defined recursively; but since we modify the input parameters
16144 (left is set to `this' temporarily), we reset this value if the
16145 left_is_explicit is false, which gives the original semantics to
16148 * literal.cs (NullPointer): new class used to represent a null
16149 literal in a pointer context.
16151 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
16152 type is a pointer, use a NullPointer object instead of a
16153 NullLiteral. Closes 43687
16155 (ExplicitConversion): Convert pointer values using
16156 the conv opcode to the proper type.
16158 * ecore.cs (New): change ValueTypeVariable property into a method,
16159 that returns whether the valuetype is suitable for being used.
16161 * expression.cs (Binary.DoNumericPromotions): Only return if we
16162 the int constant was a valid uint, and we can return both left and
16163 right as uints. If not, we continue processing, to trigger the
16164 type conversion. This fixes 39018.
16166 * statement.cs (Block.EmitMeta): During constant resolution, set
16167 the CurrentBlock property on the emitcontext, so that we resolve
16168 constants propertly.
16170 2003-07-02 Martin Baulig <martin@ximian.com>
16172 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
16173 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
16175 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
16176 than emitting it here.
16178 * statement.cs: Fixed some more flow analysis bugs.
16180 2003-07-02 Martin Baulig <martin@ximian.com>
16182 * class.cs (MethodData.Define): When implementing interface
16183 methods, set Final unless we're Virtual.
16185 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
16186 check work for interface methods.
16188 2003-07-01 Martin Baulig <martin@ximian.com>
16190 * ecore.cs (EmitContext.This): Replaced this property with a
16191 GetThis() method which takes a Location argument. This ensures
16192 that we get the correct error location for a CS0188.
16194 2003-07-01 Miguel de Icaza <miguel@ximian.com>
16196 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
16197 ImplicitStandardConversion.
16199 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
16201 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
16203 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
16206 2003-06-30 Miguel de Icaza <miguel@ximian.com>
16208 * class.cs (Constructor.Define): Turn off initlocals for unsafe
16211 (MethodData.Define): Turn off initlocals for unsafe methods.
16213 2003-06-29 Miguel de Icaza <miguel@ximian.com>
16215 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
16216 complete; Fixes #37521.
16218 * delegate.cs: Use Modifiers.TypeAttr to compute the
16219 TypeAttributes, instead of rolling our own. This makes the flags
16220 correct for the delegates.
16222 2003-06-28 Miguel de Icaza <miguel@ximian.com>
16224 * class.cs (Constructor.Define): Set the private flag for static
16225 constructors as well.
16227 * cs-parser.jay (statement_expression): Set the return value to
16228 null, to avoid a crash when we catch an error.
16230 2003-06-24 Miguel de Icaza <miguel@ximian.com>
16232 * cs-parser.jay: Applied patch from Jackson that adds support for
16233 extern and unsafe modifiers to destructor declarations.
16235 * expression.cs: Report error 21 if the user is trying to index a
16238 * driver.cs: Add an error message, suggested by the bug report.
16240 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
16241 if we do not have a ": this ()" constructor initializer. Fixes 45149
16243 2003-06-14 Miguel de Icaza <miguel@ximian.com>
16245 * namespace.cs: Add some information to reduce FAQs.
16247 2003-06-13 Miguel de Icaza <miguel@ximian.com>
16249 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
16250 underlying enumeration types. Fixes #43915.
16252 * expression.cs: Treat ushort/short as legal values to be used in
16253 bitwise operations.
16255 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
16257 * delegate.cs: transfer custom attributes for paramenters from
16258 the delegate declaration to Invoke and BeginInvoke.
16260 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
16262 * attribute.cs: handle custom marshalers and emit marshal info
16265 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
16267 * makefile.gnu: Added anonymous.cs to the compiler sources.
16269 2003-05-28 Miguel de Icaza <miguel@ximian.com>
16271 * iterators.cs: Change the name of the proxy class to include two
16274 * cs-parser.jay: Update grammar to include anonymous methods.
16276 * anonymous.cs: new file.
16278 2003-05-27 Miguel de Icaza <miguel@ximian.com>
16280 * class.cs (Field.Define): Add missing test for pointers and
16283 2003-05-27 Ravi Pratap <ravi@ximian.com>
16285 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
16286 we use the stobj opcode.
16288 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
16289 since it wasn't the correct fix.
16291 It still is puzzling that we are required to use stobj for IntPtr
16292 which seems to be a ValueType.
16294 2003-05-26 Miguel de Icaza <miguel@ximian.com>
16296 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
16297 during regular simple name resolution. Now, the trick is that
16298 instead of returning for processing the simplename, we do a
16299 TypeManager.LookupType (ie, a rooted lookup as opposed to a
16300 contextual lookup type). If a match is found, return that, if
16301 not, return for further composition.
16303 This fixes long-standing 30485.
16305 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16306 using the address to initialize an object, do an Stobj instead of
16307 using the regular Stelem.
16309 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
16310 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
16311 Because if we are a BaseIndexerAccess that value will be true.
16314 * statement.cs (GotoCase.Resolve): Return after reporting an
16315 error, do not attempt to continue.
16317 * expression.cs (PointerArithmetic.Emit): If our operand is a
16318 long, convert our constants to match the operand before
16319 multiplying. Convert to I type before adding. Fixes 43670.
16321 2003-05-14 Ravi Pratap <ravi@ximian.com>
16323 * enum.cs (ImplicitConversionExists) : Rename to
16324 ImplicitEnumConversionExists to remove ambiguity.
16326 * ecore.cs (NullCast): New type of cast expression class which
16327 basically is very similar to EmptyCast with the difference being
16328 it still is a constant since it is used only to cast a null to
16330 (eg. (string) null)
16332 * convert.cs (ImplicitReferenceConversion): When casting a null
16333 literal, we return a NullCast.
16335 * literal.cs (NullLiteralTyped): Remove - I don't see why this
16336 should be around anymore.
16338 The renaming (reported was slightly wrong). Corrections:
16340 ConvertImplicitStandard -> ImplicitConversionStandard
16341 ConvertExplicitStandard -> ExplicitConversionStandard
16343 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
16344 before passing them in !
16346 * convert.cs (ImplicitConversionStandard): When comparing for
16347 equal expr and target types, ensure that expr is not a
16350 In general, we must not be checking (expr_type ==
16351 target_type) in the top level conversion methods
16352 (ImplicitConversion, ExplicitConversion etc). This checking is
16353 done in the methods that they delegate to.
16355 2003-05-20 Miguel de Icaza <miguel@ximian.com>
16357 * convert.cs: Move Error_CannotConvertType,
16358 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
16359 ImplicitNumericConversion, ImplicitConversionExists,
16360 ImplicitUserConversionExists, StandardConversionExists,
16361 FindMostEncompassedType, FindMostSpecificSource,
16362 FindMostSpecificTarget, ImplicitUserConversion,
16363 ExplicitUserConversion, GetConversionOperators,
16364 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
16365 TryImplicitIntConversion, Error_CannotConvertImplicit,
16366 ConvertImplicitRequired, ConvertNumericExplicit,
16367 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
16368 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
16371 Perform the following renames:
16373 StandardConversionExists -> ImplicitStandardConversionExists
16374 ConvertImplicit -> ImplicitConversion
16375 ConvertImplicitStandard -> ImplicitStandardConversion
16376 TryImplicitIntConversion -> ImplicitIntConversion
16377 ConvertImplicitRequired -> ImplicitConversionRequired
16378 ConvertNumericExplicit -> ExplicitNumericConversion
16379 ConvertReferenceExplicit -> ExplicitReferenceConversion
16380 ConvertExplicit -> ExplicitConversion
16381 ConvertExplicitStandard -> ExplicitStandardConversion
16383 2003-05-19 Martin Baulig <martin@ximian.com>
16385 * statement.cs (TypeInfo.StructInfo): Made this type protected.
16386 (TypeInfo): Added support for structs having structs as fields.
16388 * ecore.cs (FieldExpr): Implement IVariable.
16389 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
16390 VariableInfo for the field.
16392 2003-05-18 Martin Baulig <martin@ximian.com>
16394 * expression.cs (This.DoResolve): Report a CS0027 if we're
16395 emitting a field initializer.
16397 2003-05-18 Martin Baulig <martin@ximian.com>
16399 * expression.cs (This.ResolveBase): New public function.
16400 (This.DoResolve): Check for CS0188.
16402 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
16405 * ecore.cs (MethodGroupExpr.DoResolve): Set the
16406 `instance_expression' to null if we don't have any non-static
16409 2003-05-18 Martin Baulig <martin@ximian.com>
16411 Reworked the way how local variables and parameters are handled by
16412 the flow analysis code.
16414 * statement.cs (TypeInfo, VariableMap): New public classes.
16415 (VariableInfo): New public class. This is now responsible for
16416 checking whether a variable has been assigned. It is used for
16417 parameters and local variables.
16418 (Block.EmitMeta): Take the InternalParameters as argument; compute
16419 the layout of the flow vectors here.
16420 (Block.LocalMap, Block.ParameterMap): New public properties.
16421 (FlowBranching): The .ctor doesn't get the InternalParameters
16422 anymore since Block.EmitMeta() now computes the layout of the flow
16424 (MyStructInfo): This class is now known as `StructInfo' and nested
16425 in `TypeInfo'; we don't access this directly anymore.
16427 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
16428 property and removed IsAssigned(), IsFieldAssigned(),
16429 SetAssigned() and SetFieldAssigned(); we now call them on the
16430 VariableInfo so we don't need to duplicate this code everywhere.
16432 * expression.cs (ParameterReference): Added `Block block' argument
16434 (LocalVariableReference, ParameterReference, This): The new
16435 VariableInfo class is now responsible for all the definite
16438 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
16439 IsParameterAssigned, SetParameterAssigned): Removed.
16441 2003-05-18 Martin Baulig <martin@ximian.com>
16443 * typemanager.cs (InitCoreTypes): Try calling
16444 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
16445 the 3-args-version. Corlib now also needs our `void_type'.
16446 (GetMethod): Added overloaded version which takes an optional
16447 `bool report_errors' to allow lookups of optional methods.
16449 2003-05-12 Martin Baulig <martin@ximian.com>
16451 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
16452 only used for locals and not for parameters.
16454 2003-05-12 Miguel de Icaza <miguel@ximian.com>
16456 * support.cs (InternalParameters.ParameterType): Return the
16457 ExternalType of the parameter.
16459 * parameter.cs (Parameter.ExternalType): drop the two arguments,
16462 2003-05-11 Miguel de Icaza <miguel@ximian.com>
16464 * class.cs (MethodData.Define): Do not set the `newslot' on
16465 interface members, if they are also flagged as "override".
16467 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
16468 better code for ++i and i++. This only works for static fields
16469 and local variables.
16471 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
16472 want to pull the DeclSpace out of the builder_to_declspace instead
16473 of the TypeBuilder (like in TypeContainer.FindMembers).
16475 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
16476 instead of LookupTypeContainer. Fixes the crash on .NET for
16477 looking up interface members.
16479 * const.cs: Create our own emit context during the Definition
16480 stage, so that constants are evaluated in the proper context, when
16481 a recursive definition happens.
16483 2003-05-11 Martin Baulig <martin@ximian.com>
16485 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
16486 new block for a switch section.
16487 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
16488 the adding/lookup in the switch block. Fixes #39828.
16490 2003-05-09 Miguel de Icaza <miguel@ximian.com>
16492 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
16493 functionality: I needed to convert the data after I had performed
16494 the add/sub operation into the operands type size.
16496 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
16497 pass the type for the box operation, otherwise the resulting
16498 object would have been of type object.
16500 (BoxedCast): Add constructor to specify the type to box as.
16502 2003-05-07 Miguel de Icaza <miguel@ximian.com>
16504 * iterators.cs: I was reusing the `count' variable inadvertently,
16505 take steps to not allow this to happen.
16507 2003-05-06 Miguel de Icaza <miguel@ximian.com>
16509 * attribute.cs (Attribute.Resolve): Params attributes are encoded
16510 by creating an array at the point where the params starts and
16511 putting all those arguments there, then adjusting the size of the
16514 2003-05-05 Miguel de Icaza <miguel@ximian.com>
16516 * expression.cs (New.AddressOf): Implement interface
16517 IMemoryLocation. This is used when the `new' operator is used in
16518 the context of an invocation to a method on a value type.
16520 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
16523 * namespace.cs: Also check the using aliases here.
16525 * driver.cs: Move the test for using validity after the types have
16526 been entered, so we do a single pass that also includes the using
16529 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
16530 in the regular case. CreateSiblingForFinally is doing extra
16533 * attribute.cs (GetAttributeArgumentExpression): Store the result
16534 on an out value, and use the return value to indicate failure
16535 instead of using null (which is a valid return for Constant.GetValue).
16537 * statement.cs: Perform the analysis flow for the increment
16538 portion after the statement, because this will be the real flow of
16539 execution. Fixes #42385
16541 * codegen.cs (EmitContext.EmitArgument,
16542 EmitContext.EmitStoreArgument): New helper functions when the
16543 RemapToProxy flag is set.
16545 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
16548 Add support for remapping parameters.
16550 * iterators.cs: Propagate parameter values; Store parameter
16551 values in the proxy classes.
16553 2003-05-04 Miguel de Icaza <miguel@ximian.com>
16555 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
16556 need a proxy reference; I do not know what I was thinking
16558 * cs-parser.jay (constructor_initializer): catch another error,
16559 and display nice message.
16561 (field_declaration): catch void field declaration
16562 to flag a better error.
16564 * class.cs (MemberBase.CheckBase): Report an error instead of a
16565 warning if a new protected member is declared in a struct.
16566 (Field.Define): catch the error of readonly/volatile.
16568 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
16570 (FieldExpr.AddressOf): ditto. Catch error where the address of a
16571 volatile variable is taken
16573 2003-05-02 Miguel de Icaza <miguel@ximian.com>
16575 * statement.cs (Fixed.Resolve): Report an error if we are not in
16578 2003-05-01 Miguel de Icaza <miguel@ximian.com>
16580 * typemanager.cs: reuse the code that handles type clashes for
16581 delegates and enumerations.
16583 * class.cs (Report28): Always report.
16585 * expression.cs (EncodeAsAttribute): Allow nulls here.
16587 2003-04-28 Miguel de Icaza <miguel@ximian.com>
16589 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
16590 the functionality for testing whether an expression is valid for
16591 an attribute here. Also handle the case of arrays of elements
16594 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
16595 encoding a linear array into an array of objects that are suitable
16596 to be passed to an CustomAttributeBuilder.
16598 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
16600 * ecore.cs: (FieldExpr): Handle field remapping here.
16602 * iteratators.cs: Pass the instance variable (if the method is an
16603 instance method) to the constructors, so we can access the field
16604 variables on the class.
16606 TODO: Test this with structs. I think the THIS variable on
16607 structs might have to be a pointer, and not a refenrece
16609 2003-04-27 Miguel de Icaza <miguel@ximian.com>
16611 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
16612 local variables to fields in a proxy class.
16614 * iterators.cs (PopulateProxy): Rename our internal fields to
16616 Create a <THIS> field if we are an instance method, so we can
16617 reference our parent container variables.
16618 (MapVariable): Called back from the EmitContext code to enter a
16619 new variable to field mapping into the proxy class (we just create
16623 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
16624 for using the remapped locals to fields.
16626 I placed the code here, because that gives the same semantics to
16627 local variables, and only changes the Emit code.
16629 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
16630 statements inside iterators.
16631 (VariableInfo): Add a FieldBuilder for the cases when we are
16632 remapping local variables to fields in a proxy class
16634 * ecore.cs (SimpleNameResolve): Avoid testing two times for
16635 current_block != null.
16637 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
16638 not cope with strings, as it has been moved to the
16639 TableSwitchEmit. Fixed bug in switch generation.
16641 * expression.cs (New.DoResolve): Provide more context for the user
16642 when reporting an error.
16644 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
16647 * expression.cs (MemberAccess.DoResolve): When we get a type back,
16648 check the permissions for it. Note than in a type-resolution
16649 context the check was already present in DeclSpace.ResolveType,
16650 but was missing from the MemberAccess.
16652 (ArrayCreation.CheckIndices): warn if the user has
16653 more nested levels of expressions, but there are no more
16654 dimensions specified. Avoids crash on bug 41906.
16656 2003-04-26 Miguel de Icaza <miguel@ximian.com>
16658 * statement.cs (Block): replace Implicit bool, for a generic
16660 New flag: `Unchecked'. This is used during the EmitMeta phase
16661 (which is out-of-line with the regular Resolve/Emit process for a
16662 statement, as this is done ahead of time, but still gets a chance
16663 to call constant resolve).
16665 (Block.Flags): new enum for adding a new flag.
16667 (Block.EmitMeta): track the state of unchecked.
16669 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
16670 to enable constant resolution to work there as well.
16672 2003-04-22 Miguel de Icaza <miguel@ximian.com>
16674 * typemanager.cs (ienumerable_type): Also look up
16675 System.Collections.IEnumerable.
16677 2003-04-21 Miguel de Icaza <miguel@ximian.com>
16679 TODO: Test more than one conditional per method.
16681 * class.cs (Indexer.Define): Report the location where the user is
16682 referencing the unsupported feature.
16684 (MethodData): Overload the use of `conditionals' to
16685 minimize the creation of needless ArrayLists. This saves roughly
16686 212kb on my machine.
16688 (Method): Implement the new IIteratorContainer interface.
16689 (Method.SetYields): Implement the method by setting the ModFlags
16690 to contain METHOD_YIELDS.
16692 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
16693 which just got set to null.
16695 * iterators.cs: New file.
16697 (Yield, YieldBreak): New statements.
16699 * statement.cs (Return.Resolve): Flag an error if we are used in
16700 an iterator method.
16702 * codegen.cs (InIterator): New flag set if the code is being
16703 compiled in an iterator method.
16705 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
16706 internal modifier, and we just use it to avoid adding extra
16707 fields, as this is seldom used.
16709 * cs-parser.jay: Add yield_statement (yield and yield break).
16711 * driver.cs: New flag -v2 to turn on version 2 features.
16713 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
16714 hashtable when v2 is enabled.
16716 2003-04-20 Miguel de Icaza <miguel@ximian.com>
16718 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
16719 there is already a namespace defined with this name.
16721 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
16722 people upgraded their corlibs.
16724 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
16725 always use fully qualified types, no need to use the compiler
16728 (TypeManager.IsNamespace): Use binarysearch.
16730 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
16731 AddDelegate): I did not quite use the new IsValid API properly: I
16732 have to pass the short-name and the fullname. I was passing only
16733 the basename instead of the fullname sometimes.
16735 (TypeContainer.DefineType): call NamespaceClash.
16737 * interface.cs (Interface.DefineType): use NamespaceClash before
16740 * delegate.cs (Delegate.DefineType): use NamespaceClash before
16743 * enum.cs: (Enum.DefineType): use NamespaceClash before
16746 * typemanager.cs (: 3-line patch that gives us some tasty 11%
16747 speed increase. First, use the negative_hits cache when we get a
16748 negative. Second, add the type with its full original name
16749 instead of the new . and + encoded name (reflection uses + to
16750 separate type from a nested type). Use LookupTypeReflection
16751 directly which bypasses the type->name hashtable (that we already
16752 know does not contain the type.
16754 * decl.cs (DeclSpace.ResolveTypeExpr): track the
16755 location/container type.
16757 * driver.cs: When passing utf8, use directly the UTF8Encoding.
16759 2003-04-19 Miguel de Icaza <miguel@ximian.com>
16761 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
16763 * delegate.cs (NewDelegate.Resolve): Test whether an instance
16764 method is being referenced in the method group from a static
16765 context, and report error 120 if so.
16767 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
16770 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
16771 is created, we create the A namespace).
16773 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16776 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16778 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16779 invocation to ModuleBuilder.GetType with the same values will
16780 return a new type instance, so we need to cache its return
16783 * expression.cs (Binary.ResolveOperator): Only allow the compare
16784 operators on enums if they are of the same type.
16786 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16787 types of ValueType on their own case. Before we were giving them
16788 the same treatment as objects.
16790 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16791 fullname. Short name is used to compare against container name.
16792 Fullname is used to check against defined namespace names.
16794 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16795 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16797 (Method.CheckBase): Call parent.
16798 (MemberBase.CheckBase): Check for protected members on sealed
16800 (PropertyBase.CheckBase): Call parent.
16801 (Field.Define): Call parent.
16803 * report.cs: Negative error codes are now mapped to 8000 - code,
16804 so that the display is render more nicely.
16806 * typemanager.cs: Do not use try/catch, instead report a regular
16809 (GetPointerType, GetReferenceType): These methods provide
16810 mechanisms to obtain the T* and T& from a T. We had the code
16811 previously scattered around the code base, and it also used
16812 TypeManager.LookupType that would go through plenty of caches.
16813 This one goes directly to the type source.
16815 In some places we did the Type.GetType followed by
16816 ModuleBuilder.GetType, but not in others, so this unifies the
16817 processing as well.
16819 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16820 statements now that we have namespace information.
16822 * typemanager.cs (IsNamespace): New method, returns whether the
16823 string presented is a namespace or not.
16825 (ComputeNamespaces): New public entry point, computes the list of
16826 available namespaces, using the GetNamespaces API call in Mono, or
16827 the slower version in MS.NET.
16829 Now before we start the semantic analysis phase, we have a
16830 complete list of namespaces including everything that the user has
16833 Deleted old code to cache namespaces in .nsc files.
16835 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16837 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16838 class/struct location definition Location for the implicit
16839 constructor location.
16841 (Operator.Define): Use the location of the operator for the
16842 implicit Method definition.
16844 (Constructor.Emit): use the constructor location for the implicit
16845 base initializer constructor.
16847 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16848 and the Expression class now contains two new methods:
16850 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16851 isolate type lookup from the rest of the resolution process.
16853 Since we use Expressions to hold type definitions due to the way
16854 we parse the input we have historically overloaded Resolve to
16855 perform the Type lookups if a special flag is passed. Now this is
16856 eliminated and two methods take their place.
16858 The differences in the two methods between xStep and xTerminal is
16859 that xStep is involved in our current lookup system that uses
16860 SimpleNames to compose a name, while xTerminal is used just to
16861 catch the case where the simplename lookup failed.
16863 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16865 * expression.cs (ResolveMemberAccess): Remove redundant code.
16866 TypeExpr expressions are always born fully resolved.
16868 * interface.cs (PopulateMethod): Do not lookup the types twice.
16869 We were doing it once during SemanticAnalysis and once during
16872 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16873 in local variable type definitions, were being returned as a
16874 SimpleName (we decomposed everything into a string), that is
16875 because primary_expression was being used instead of a type in the
16876 grammar (reduce/reduce conflicts).
16878 The part that was wrong is that we converted the expression into a
16879 string (an oversimplification in one hand, compounded with primary
16880 expressions doing string concatenation).
16886 Would return "A.B.C[]" as a SimpleName. This stopped things like
16887 using clauses from working on this particular context. And a type
16888 was being matched directly against "A.B.C[]".
16890 We now use the correct approach, and allow for ComposedCast to be
16891 part of the unary expression. So the "A.B.C []" become a composed
16892 cast of "A.B.C" (as a nested group of MemberAccess with a
16893 SimpleName at the end) plus the rank composition "[]".
16897 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16899 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16900 for the access level checking.
16902 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16903 `TypeContainer container', because I kept getting confused when I
16904 was debugging this code.
16906 * expression.cs (Indexers): Instead of tracking getters/setters,
16907 we now track them in parallel. We create one arraylist less, but
16908 most importantly it is possible now for the LValue code to find a
16909 matching get for a set.
16911 (IndexerAccess.DoResolveLValue): Update the code.
16912 GetIndexersForType has been modified already to extract all the
16913 indexers from a type. The code assumed it did not.
16915 Also make the code set the correct return type for the indexer.
16916 This was fixed a long time ago for properties, but was missing for
16917 indexers. It used to be void_type.
16919 (Binary.Emit): Test first for doubles instead of
16920 floats, as they are more common.
16922 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16923 when dealing with floats and the <=, >= operators. This fixes bug
16926 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16927 to load the array value by emitting a load on the foreach variable
16928 type. This was incorrect.
16930 We now emit the code to load an element using the the array
16931 variable type, and then we emit the conversion operator.
16935 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16937 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16939 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16941 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16942 test for protection before we test for signatures.
16944 (MethodSignature.ToString): implement.
16946 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16947 to the case where we reduced into a LongConstant.
16949 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16950 depend on whether the information is acurrate, because the
16951 Microsoft runtime will always claim that the array type is public,
16952 regardless of the real state.
16954 If the type is a pointer, another problem happens: the type is
16955 reported as non-public in Microsoft.
16957 In both cases we have to call CheckAccessLevel recursively with
16958 the underlying type as the argument to be tested.
16960 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16962 * assign.cs (Assign.Emit): If we are dealing with a compound
16963 assignment expression, we should use the code path that stores the
16964 intermediate result in a temporary value. This fixes #40903.
16966 *expression.cs (Indirection.ToString): Provide ToString method for
16969 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16971 * class.cs: Null out fields holding references to Block objects so
16972 they can be garbage collected.
16974 * expression.cs (OverloadResolve): Remove unused local.
16976 2003-04-07 Martin Baulig <martin@ximian.com>
16978 * codegen.cs (EmitContext.CurrentFile): New public field.
16979 (EmitContext.Mark): Use the CurrentFile to check whether the
16980 location is in the correct file.
16981 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16983 2003-04-07 Martin Baulig <martin@ximian.com>
16985 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16987 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16988 location. [FIXME: The location argument which gets passed to this
16989 method is sometimes wrong!]
16991 2003-04-07 Nick Drochak <ndrochak@gol.com>
16993 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16995 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16997 * expression.cs (Indirection.EmitAssign): We were using the
16998 temporary, but returning immediately instead of continuing the
17001 2003-04-06 Martin Baulig <martin@ximian.com>
17003 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
17004 if it's a nested child, but also deriving from the outer class.
17007 * typemanager.cs (IsNestedChildOf): Make this work if it's a
17008 nested child, but also deriving from the outer class. See
17010 (FilterWithClosure): We may access private members of the outer
17011 class if we're a nested child and deriving from the outer class.
17012 (RealMemberLookup): Only set `closure_private_ok' if the
17013 `original_bf' contained BindingFlags.NonPublic.
17015 2003-04-05 Martin Baulig <martin@ximian.com>
17017 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
17019 2003-04-02 Miguel de Icaza <miguel@ximian.com>
17021 * class.cs (Event.Define): Do not allow abstract events to have
17024 2003-04-01 Miguel de Icaza <miguel@ximian.com>
17026 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
17027 block in event declarations.
17029 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
17030 value type, get its address.
17032 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
17033 leaving a class on the stack instead of a boolean value (int
17034 0/1). Change the code so we compare against null, and then the
17035 result against zero.
17037 * class.cs (TypeContainer.GetClassBases): We were checking for the
17038 parent class being sealed too late.
17040 * expression.cs (Binary.Emit): For <= and >= when dealing with
17041 floating point values, use cgt.un and clt.un instead of cgt and
17044 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
17046 * statement.cs: Apply the same optimization as MS: skip the
17047 GetEnumerator returning an IEnumerator, and use the one returning a
17048 CharEnumerator instead. This allows us to avoid the try-finally block
17051 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
17053 * cs-parser.jay: Attributes cannot be applied to
17054 namespaces. Fixes #40473
17056 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17059 (Add*): check if the name is valid using the full name for constants,
17060 fields, properties and events.
17062 2003-03-28 Miguel de Icaza <miguel@ximian.com>
17064 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
17065 char constants to be part of the enumeration.
17067 * expression.cs (Conditional.DoResolve): Add support for operator
17068 true. Implements the missing functionality from 14.12
17070 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
17071 operator true/false as required by the spec.
17073 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
17074 implicit conversion to boolean.
17076 * statement.cs (Statement.ResolveBoolean): A boolean expression is
17077 also one where the type implements `operator true'.
17079 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
17080 get an expression that will invoke operator true based on an
17083 (GetConversionOperators): Removed the hack that called op_True
17086 (Expression.ResolveBoolean): Move this from Statement.
17088 2003-03-17 Miguel de Icaza <miguel@ximian.com>
17090 * ecore.cs (FieldExpr): do not allow initialization of initonly
17091 fields on derived classes
17093 2003-03-13 Martin Baulig <martin@ximian.com>
17095 * statement.cs (Block.Emit): Call ig.BeginScope() and
17096 ig.EndScope() when compiling with debugging info; call
17097 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
17099 2003-03-08 Miguel de Icaza <miguel@ximian.com>
17101 * expression.cs (Indexers): Do not construct immediately, allow
17102 for new members to be appended as we go. Fixes 38143
17104 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17106 * expression.cs: save/restore context when resolving an unchecked
17109 2003-03-05 Miguel de Icaza <miguel@ximian.com>
17111 * cfold.cs: Catch division by zero in modulus operator during
17114 2003-03-03 Miguel de Icaza <miguel@ximian.com>
17116 * interface.cs (Interface.DefineMembers): Avoid defining members
17119 2003-02-27 Miguel de Icaza <miguel@ximian.com>
17121 * driver.cs: handle the +/- options for -noconfig
17123 * statement.cs (Unckeched.Resolve): Also track the state of
17124 unchecked in the Resolve phase.
17126 2003-02-27 Martin Baulig <martin@ximian.com>
17128 * ecore.cs (Expression.MemberLookup): Don't create a
17129 MethodGroupExpr for something which is not a method. Fixes #38291.
17131 2003-02-25 Miguel de Icaza <miguel@ximian.com>
17133 * class.cs (MemberBase.CheckParameters): Also check that the type
17134 is unmanaged if it is a pointer.
17136 * expression.cs (SizeOf.Resolve): Add location information.
17138 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
17139 a managed type is declared.
17141 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
17142 parameter modifiers as well. Fixes bug 38606
17144 * class.cs: Very sad. Am backing out the speed up changes
17145 introduced by the ArrayList -> Array in the TypeContainer, as they
17146 were not actually that much faster, and introduced a bug (no error
17147 reports on duplicated methods).
17149 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
17150 source first, this will guarantee that we have a valid expression
17151 before calling in lower levels functions that will require a
17152 resolved object. Then use this original_source in the
17153 target.ResolveLValue instead of the original source that was
17156 Another change. Use target.Resolve instead of LValueResolve.
17157 Although we are resolving for LValues, we will let the Assign code
17158 take care of that (it will be called again from Resolve). This
17159 basically allows code like this:
17161 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
17162 class Y { void A (X x) { x [0] += o; }
17164 The problem was that the indexer was trying to resolve for
17165 set_Item (idx, object o) and never finding one. The real set_Item
17166 was set_Item (idx, X). By delaying the process we get the right
17171 2003-02-23 Martin Baulig <martin@ximian.com>
17173 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
17174 while calling DoEmit ().
17176 * codegen.cs (EmitContext.Mark): Don't mark locations in other
17177 source files; if you use the #line directive inside a method, the
17178 compiler stops emitting line numbers for the debugger until it
17179 reaches the end of the method or another #line directive which
17180 restores the original file.
17182 2003-02-23 Martin Baulig <martin@ximian.com>
17184 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
17186 2003-02-23 Martin Baulig <martin@ximian.com>
17188 * statement.cs (Block.AddChildVariableNames): We need to call this
17189 recursively, not just for our immediate children.
17191 2003-02-23 Martin Baulig <martin@ximian.com>
17193 * class.cs (Event.Define): Always make the field private, like csc does.
17195 * typemanager.cs (TypeManager.RealMemberLookup): Make events
17196 actually work, fixes bug #37521.
17198 2003-02-23 Miguel de Icaza <miguel@ximian.com>
17200 * delegate.cs: When creating the various temporary "Parameters"
17201 classes, make sure that we call the ComputeAndDefineParameterTypes
17202 on those new parameters (just like we do with the formal ones), to
17203 allow them to be resolved in the context of the DeclSpace.
17205 This fixes the bug that Dick observed in Bugzilla #38530.
17207 2003-02-22 Miguel de Icaza <miguel@ximian.com>
17209 * expression.cs (ResolveMemberAccess): When resolving a constant,
17210 do not attempt to pull a constant if the value was not able to
17211 generate a valid constant.
17213 * const.cs (LookupConstantValue): Do not report more errors than required.
17215 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17217 * expression.cs: fixes bug #38328.
17219 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17221 * class.cs: Changed all the various members that can be part of a
17222 class from being an ArrayList to be an Array of the right type.
17223 During the DefineType type_list, interface_list, delegate_list and
17224 enum_list are turned into types, interfaces, delegates and enums
17227 And during the member population, indexer_list, event_list,
17228 constant_list, field_list, instance_constructor_list, method_list,
17229 operator_list and property_list are turned into their real arrays.
17231 Although we could probably perform this operation earlier, for
17232 good error reporting we need to keep the lists and remove the
17233 lists for longer than required.
17235 This optimization was triggered by Paolo profiling the compiler
17236 speed on the output of `gen-sample-program.pl' perl script.
17238 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
17239 not crash in methods like MemberLookupFailed that use this field.
17241 This problem arises when the compiler fails to resolve a type
17242 during interface type definition for example.
17244 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17246 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
17247 inherit from System.Object, so we have to stop at null, not only
17248 when reaching System.Object.
17250 2003-02-17 Miguel de Icaza <miguel@ximian.com>
17252 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
17253 DeclaredOnly because the parent indexer might have had a different
17254 name, but did not loop until the top of the hierarchy was reached.
17256 The problem this one fixes is 35492: when a class implemented an
17257 indexer from an interface, we were getting the interface method
17258 (which was abstract) and we were flagging an error (can not invoke
17261 This also keeps bug 33089 functioning, and test-148 functioning.
17263 * typemanager.cs (IsSpecialMethod): The correct way of figuring
17264 out if a method is special is to see if it is declared in a
17265 property or event, or whether it is one of the predefined operator
17266 names. This should fix correctly #36804.
17268 2003-02-15 Miguel de Icaza <miguel@ximian.com>
17270 The goal here is to remove the dependency on EmptyCast.Peel ().
17271 Killing it completely.
17273 The problem is that currently in a number of places where
17274 constants are expected, we have to "probe" for an EmptyCast, and
17275 Peel, which is not the correct thing to do, as this will be
17276 repetitive and will likely lead to errors.
17278 The idea is to remove any EmptyCasts that are used in casts that
17279 can be reduced to constants, so we only have to cope with
17282 This bug hunt was triggered by Bug 37363 and the desire to remove
17283 the duplicate pattern where we were "peeling" emptycasts to check
17284 whether they were constants. Now constants will always be
17287 * ecore.cs: Use an enumconstant here instead of wrapping with
17290 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
17291 throwing me off. By handling this we can get rid of a few hacks.
17293 * statement.cs (Switch): Removed Peel() code.
17295 2003-02-14 Miguel de Icaza <miguel@ximian.com>
17297 * class.cs: Location information for error 508
17299 * expression.cs (New.DoResolve): Add a guard against double
17300 resolution of an expression.
17302 The New DoResolve might be called twice when initializing field
17303 expressions (see EmitFieldInitializers, the call to
17304 GetInitializerExpression will perform a resolve on the expression,
17305 and later the assign will trigger another resolution
17307 This leads to bugs (#37014)
17309 * delegate.cs: The signature for EndInvoke should contain any ref
17310 or out parameters as well. We were not doing this in the past.
17312 * class.cs (Field.Define): Do not overwrite the type definition
17313 inside the `volatile' group. Turns out that volatile enumerations
17314 were changing the type here to perform a validity test, which
17317 2003-02-12 Miguel de Icaza <miguel@ximian.com>
17319 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
17320 and structs, we do not want to load the instance variable
17322 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
17323 enum_type has to be handled like an object reference (implicit
17324 conversions exists from this to object), but the regular IsClass
17325 and IsValueType tests will never return true for this one.
17327 Also we use TypeManager.IsValueType instead of type.IsValueType,
17328 just for consistency with the rest of the code (this is only
17329 needed if we ever use the construct exposed by test-180.cs inside
17330 corlib, which we dont today).
17332 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
17334 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
17337 2003-02-09 Martin Baulig <martin@ximian.com>
17339 * namespace.cs (Namespace..ctor): Added SourceFile argument.
17340 (Namespace.DefineNamespaces): New static public method; this is
17341 called when we're compiling with debugging to add all namespaces
17342 to the symbol file.
17344 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
17345 pass it to the Namespace's .ctor.
17347 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
17348 and MethodBase arguments; pass the namespace ID to the symwriter;
17349 pass the MethodBase instead of the token to the symwriter.
17350 (SymbolWriter.DefineNamespace): New method to add a namespace to
17353 2003-02-09 Martin Baulig <martin@ximian.com>
17355 * symbolwriter.cs: New file. This is a wrapper around
17356 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
17357 methods here in near future.
17359 2003-02-09 Martin Baulig <martin@ximian.com>
17361 * codegen.cs (EmitContext.Mark): Just pass the arguments to
17362 ILGenerator.MarkSequencePoint() which are actually used by the
17365 2003-02-09 Martin Baulig <martin@ximian.com>
17367 * location.cs (SourceFile): New public sealed class. This
17368 contains the name and an index which is used in the location's token.
17369 (Location): Reserve an appropriate number of bits in the token for
17370 the source file instead of walking over that list, this gives us a
17371 really huge performance improvement when compiling with debugging.
17373 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
17374 `SourceFile' argument instead of a string.
17375 (Driver.ProcessFile): Add all the files via Location.AddFile(),
17376 but don't parse/tokenize here, we need to generate the list of all
17377 source files before we do that.
17378 (Driver.ProcessFiles): New static function. Parses/tokenizes all
17381 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
17382 instead of a string.
17384 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
17387 2003-02-09 Martin Baulig <martin@ximian.com>
17389 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
17390 filename on `#line default'.
17392 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
17394 * statement.cs: don't clear the pinned var when the fixed statement
17395 returns from the method (fixes bug#37752).
17397 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
17399 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
17402 2003-02-07 Martin Baulig <martin@ximian.com>
17404 * driver.cs: Removed the `--debug-args' command line argument.
17406 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
17407 automatically by the AsssemblyBuilder.
17408 (CodeGen.InitializeSymbolWriter): We don't need to call any
17409 initialization function on the symbol writer anymore. This method
17410 doesn't take any arguments.
17412 2003-02-03 Miguel de Icaza <miguel@ximian.com>
17414 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
17415 from referenced assemblies as well.
17417 2003-02-02 Martin Baulig <martin@ximian.com>
17419 * class.cs (MethodData.Emit): Generate debugging info for external methods.
17421 2003-02-02 Martin Baulig <martin@ximian.com>
17423 * class.cs (Constructor.Emit): Open the symbol writer before
17424 emitting the constructor initializer.
17425 (ConstructorInitializer.Emit): Call ec.Mark() to allow
17426 single-stepping through constructor initializers.
17428 2003-01-30 Miguel de Icaza <miguel@ximian.com>
17430 * class.cs: Handle error 549: do not allow virtual methods in
17433 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
17435 * decl.cs: Check access levels when resolving types
17437 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
17439 * statement.cs: Add parameters and locals set in catch blocks that might
17440 return to set vector
17442 2003-01-29 Miguel de Icaza <miguel@ximian.com>
17444 * class.cs (Operator): Set the SpecialName flags for operators.
17446 * expression.cs (Invocation.DoResolve): Only block calls to
17447 accessors and operators on SpecialName methods.
17449 (Cast.TryReduce): Handle conversions from char constants.
17452 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
17454 * statement.cs: small memory and time optimization in FlowBranching.
17456 2003-01-28 Pedro Mart <yoros@wanadoo.es>
17458 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
17459 problem that the last fix but in the other sid (Set).
17461 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
17462 access when there is no indexer in the hierarchy.
17464 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
17466 * class.cs: Combine some if statements.
17468 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17470 * driver.cs: fixed bug #37187.
17472 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
17474 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
17475 any indexer, it's needed to build a list with all the indexers in the
17476 hierarchy (AllGetters), else we have problems. Fixes #35653.
17478 2003-01-23 Miguel de Icaza <miguel@ximian.com>
17480 * class.cs (MethodData.Define): It is wrong for an interface
17481 implementation to be static in both cases: explicit and implicit.
17482 We were only handling this in one case.
17484 Improve the if situation there to not have negations.
17486 * class.cs (Field.Define): Turns out that we do not need to check
17487 the unsafe bit on field definition, only on usage. Remove the test.
17489 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17491 * driver.cs: use assembly.Location instead of Codebase (the latest
17492 patch made mcs fail when using MS assemblies).
17494 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
17496 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
17497 get the path to *corlib.dll.
17499 2003-01-21 Nick Drochak <ndrochak@gol.com>
17503 * typemanager.cs: Remove compiler warnings
17505 2003-01-20 Duncan Mak <duncan@ximian.com>
17507 * AssemblyInfo.cs: Bump the version number to 0.19.
17509 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17511 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
17513 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
17515 * class.cs (Constructor::Emit): Emit debugging info for constructors.
17517 2003-01-17 Miguel de Icaza <miguel@ximian.com>
17519 * cs-parser.jay: Small fix: we were not comparing the constructor
17520 name correctly. Thanks to Zoltan for the initial pointer.
17522 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
17524 * cs-tokenizer.cs: Set file name when specified with #line
17526 2003-01-15 Miguel de Icaza <miguel@ximian.com>
17528 * cs-parser.jay: Only perform the constructor checks here if we
17529 are named like the class; This will help provider a better
17530 error. The constructor path is taken when a type definition is
17531 not found, but most likely the user forgot to add the type, so
17532 report that rather than the constructor error.
17534 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
17536 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
17539 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17541 * cs-parser.jay: Add cleanup call.
17543 2003-01-13 Duncan Mak <duncan@ximian.com>
17545 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
17546 consistent with other methods.
17548 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17550 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
17552 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
17554 * attribute.cs: only set GuidAttr to true when we have a
17557 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17561 * typemanager.cs: fixes to allow mcs compile corlib with the new
17562 Type.IsSubclassOf fix.
17564 2003-01-08 Miguel de Icaza <miguel@ximian.com>
17566 * expression.cs (LocalVariableReference.DoResolve): Classify a
17567 constant as a value, not as a variable. Also, set the type for
17570 * cs-parser.jay (fixed_statement): take a type instead of a
17571 pointer_type, so we can produce a better error message later.
17573 * statement.cs (Fixed.Resolve): Flag types that are not pointers
17576 (For.DoEmit): Make inifinite loops have a
17577 non-conditional branch back.
17579 (Fixed.DoEmit): First populate the pinned variables, then emit the
17580 statement, then clear the variables. Before I was emitting the
17581 code once for each fixed piece.
17584 2003-01-08 Martin Baulig <martin@ximian.com>
17586 * statement.cs (FlowBranching.MergeChild): A break in a
17587 SWITCH_SECTION does not leave a loop. Fixes #36155.
17589 2003-01-08 Martin Baulig <martin@ximian.com>
17591 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
17592 lives in the same number space than `param_map'. Fixes #36154.
17594 2003-01-07 Miguel de Icaza <miguel@ximian.com>
17596 * cs-parser.jay (constructor_declaration): Set the
17597 Constructor.ModFlags before probing for it. This makes the
17598 compiler report 514, 515 and 132 (the code was there, but got
17601 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
17602 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
17603 (GotoCase.Resolve): Set `Returns' to ALWAYS.
17605 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
17607 * enum.cs: create the enum static fields using the enum type.
17609 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
17611 * class.cs: don't try to create the ParamBuilder for the return
17612 type if it's not needed (and handle it breaking for the ms runtime
17615 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
17617 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
17619 2002-12-29 Miguel de Icaza <miguel@ximian.com>
17621 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
17622 the command. This showed up while compiling the JANET source
17623 code, which used \r as its only newline separator.
17625 2002-12-28 Miguel de Icaza <miguel@ximian.com>
17627 * class.cs (Method.Define): If we are an operator (because it
17628 reuses our code), then set the SpecialName and HideBySig. #36128
17630 2002-12-22 Miguel de Icaza <miguel@ximian.com>
17632 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
17633 exception, report error 120 `object reference required'.
17635 * driver.cs: Add --pause option, used during to measure the size
17636 of the process as it goes with --timestamp.
17638 * expression.cs (Invocation.DoResolve): Do not allow methods with
17639 SpecialName to be invoked.
17641 2002-12-21 Miguel de Icaza <miguel@ximian.com>
17643 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
17644 number before adding it.
17646 2002-12-21 Ravi Pratap <ravi@ximian.com>
17648 * ecore.cs (StandardImplicitConversion): When in an unsafe
17649 context, we allow conversion between void * to any other pointer
17650 type. This fixes bug #35973.
17652 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
17654 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
17655 is not thrown when extensionless outputs are used
17657 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17659 * rootcontext.cs: fixed compilation of corlib.
17661 2002-12-19 Miguel de Icaza <miguel@ximian.com>
17663 * attribute.cs (Attributes.Contains): Add new method.
17665 * class.cs (MethodCore.LabelParameters): if the parameter is an
17666 `out' parameter, check that no attribute `[In]' has been passed.
17668 * enum.cs: Handle the `value__' name in an enumeration.
17670 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
17672 * decl.cs: Added special case to allow overrides on "protected
17675 2002-12-18 Ravi Pratap <ravi@ximian.com>
17677 * attribute.cs (Attributes.AddAttributeSection): Rename to this
17678 since it makes much more sense.
17680 (Attributes.ctor): Don't require a Location parameter.
17682 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
17684 * attribute.cs (ApplyAttributes): Remove extra Location parameters
17685 since we already have that information per attribute.
17687 * everywhere : make appropriate changes.
17689 * class.cs (LabelParameters): Write the code which actually
17690 applies attributes to the return type. We can't do this on the MS
17691 .NET runtime so we flag a warning in the case an exception is
17694 2002-12-18 Miguel de Icaza <miguel@ximian.com>
17696 * const.cs: Handle implicit null conversions here too.
17698 2002-12-17 Ravi Pratap <ravi@ximian.com>
17700 * class.cs (MethodCore.LabelParameters): Remove the extra
17701 Type [] parameter since it is completely unnecessary. Instead
17702 pass in the method's attributes so that we can extract
17703 the "return" attribute.
17705 2002-12-17 Miguel de Icaza <miguel@ximian.com>
17707 * cs-parser.jay (parse): Use Report.Error to flag errors instead
17708 of ignoring it and letting the compile continue.
17710 * typemanager.cs (ChangeType): use an extra argument to return an
17711 error condition instead of throwing an exception.
17713 2002-12-15 Miguel de Icaza <miguel@ximian.com>
17715 * expression.cs (Unary.TryReduce): mimic the code for the regular
17716 code path. Perform an implicit cast in the cases where we can
17717 implicitly convert to one of the integral types, and then reduce
17718 based on that constant. This fixes bug #35483.
17720 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17722 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
17724 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17726 * namespace.cs: fixed bug #35489.
17728 2002-12-12 Miguel de Icaza <miguel@ximian.com>
17730 * class.cs: Remove some dead code.
17732 * cs-parser.jay: Estimate the number of methods needed
17733 (RootContext.MethodCount);
17735 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
17736 numbers instead of StringBuilders.
17738 * support.cs (PtrHashtable): Add constructor with initial size;
17739 We can now reduce reallocations of the method table.
17741 2002-12-10 Ravi Pratap <ravi@ximian.com>
17743 * attribute.cs (ApplyAttributes): Keep track of the emitted
17744 attributes on a per-target basis. This fixes bug #35413.
17746 2002-12-10 Miguel de Icaza <miguel@ximian.com>
17748 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
17749 default to the Windows 1252 encoding.
17751 (UnixParseOption): Support version, thanks to Alp for the missing
17754 * AssemblyInfo.cs: Add nice assembly information.
17756 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17759 * cs-parser.jay: Allow a trailing comma before the close bracked
17760 in the attribute_section production.
17762 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17763 address of the instance was being taken, I will take this out,
17764 because we take the address of the object immediately here.
17766 2002-12-09 Ravi Pratap <ravi@ximian.com>
17768 * typemanager.cs (AreMultipleAllowed): Take care of the most
17769 obvious case where attribute type is not in the current assembly -
17772 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17774 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17775 definitions, instead of doing that afterwards.
17777 Also we use a nice little hack, depending on the constructor, we
17778 know if we are a "composed" name or a simple name. Hence, we
17779 avoid the IndexOf test, and we avoid
17781 * codegen.cs: Add code to assist in a bug reporter to track down
17782 the source of a compiler crash.
17784 2002-12-07 Ravi Pratap <ravi@ximian.com>
17786 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17787 types have been emitted for a given element and flag an error
17788 if something which does not have AllowMultiple set is used more
17791 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17792 attribute types and their corresponding AllowMultiple properties
17794 (AreMultipleAllowed): Check the property for a given type.
17796 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17797 property in the case we have a TypeContainer.
17799 (Attributes.AddAttribute): Detect duplicates and just skip on
17800 adding them. This trivial fix catches a pretty gross error in our
17801 attribute emission - global attributes were being emitted twice!
17803 Bugzilla bug #33187 is now fixed.
17805 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17807 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17808 instead of pp_and).
17810 * expression.cs (Binary.ResolveOperator): I can only use the
17811 Concat (string, string, string) and Concat (string, string,
17812 string, string) if the child is actually a concatenation of
17815 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17817 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17818 context where we need a 2-character lookahead.
17820 * pending.cs (PendingImplementation): Rework so we can keep track
17821 of interface types all the time, and flag those which were
17822 implemented by parents as optional.
17824 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17826 * expression.cs (Binary.ResolveOperator): Use
17827 String.Concat(string,string,string) or
17828 String.Concat(string,string,string,string) when possible.
17830 * typemanager: More helper methods.
17833 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17835 * pending.cs: remove the bogus return from GetMissingInterfaces()
17836 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17838 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17840 * namespace.cs: avoid duplicated 'using xxx' being added to
17841 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17842 when we get more than one 'using' statement for the same namespace.
17843 Report a CS0105 warning for it.
17845 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17847 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17848 of calling getChar/putback, uses internal knowledge of it.
17850 (xtoken): Reorder tokenizer so most common patterns are checked
17851 first. This reduces the compilation time in another 5% (from 8.11s
17852 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17854 The parsing time is 22% of the compilation in mcs, and from that
17855 64% is spent on the tokenization process.
17857 I tried using a binary search for keywords, but this is slower
17858 than the hashtable. Another option would be to do a couple of
17861 * Not use a StringBuilder, instead use an array of chars,
17862 with a set value. Notice that this way we could catch
17863 the 645 error without having to do it *afterwards*.
17865 * We could write a hand-parser to avoid the hashtable
17866 compares altogether.
17868 The identifier consumption process takes 37% of the tokenization
17869 time. Another 15% is spent on is_number. 56% of the time spent
17870 on is_number is spent on Int64.Parse:
17872 * We could probably choose based on the string length to
17873 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17876 Another 3% is spend on wrapping `xtoken' in the `token' function.
17878 Handle 0xa0 as whitespace (#34752)
17880 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17882 * typemanager.cs (IsCLRType): New routine to tell whether a type
17883 is one of the builtin types.
17885 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17886 typecode in more places instead of doing pointer comparissions.
17887 We could leverage some knowledge about the way the typecodes are
17890 New code to cache namespaces in assemblies, it is currently not
17891 invoked, to be used soon.
17893 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17895 * expression.cs (Binary.ResolveOperator): specially handle
17896 strings, and do not perform user-defined operator overloading for
17899 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17901 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17902 internalcall as it is a pretty simple operation; Avoid whenever
17903 possible to call Char.IsLetter.
17905 (consume_identifier): Cut by half the number of
17906 hashtable calls by merging the is_keyword and GetKeyword behavior.
17908 Do not short-circuit, because if we do, we
17909 report errors (ie, #if false && true would produce an invalid
17913 2002-11-24 Martin Baulig <martin@ximian.com>
17915 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17916 check constant ranges and report a CS0221. Fixes #33186.
17918 2002-11-24 Martin Baulig <martin@ximian.com>
17920 * cs-parser.jay: Make this work for uninitialized variable
17921 declarations in the `for' initializer. Fixes #32416.
17923 2002-11-24 Martin Baulig <martin@ximian.com>
17925 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17926 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17928 2002-11-24 Martin Baulig <martin@ximian.com>
17930 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17931 argument; if true, we also check for user-defined conversions.
17932 This is only needed if both arguments are of a user-defined type.
17933 Fixes #30443, added test-175.cs.
17934 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17936 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17938 2002-11-24 Martin Baulig <martin@ximian.com>
17940 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17941 function to get the store opcode.
17942 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17943 only emit the Ldelema if the store opcode is Stobj. You must run
17944 both test-34 and test-167 to test this. Fixes #34529.
17946 2002-11-23 Martin Baulig <martin@ximian.com>
17948 * ecore.cs (Expression.MemberLookup): Added additional
17949 `qualifier_type' argument which is used when we're being called
17950 from MemberAccess.DoResolve() and null if we're called from a
17952 (Expression.MemberLookupFailed): New method to report errors; this
17953 does the CS1540 check and reports the correct error message.
17955 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17956 argument for the CS1540 check and redone the way how we're dealing
17957 with private members. See the comment in the source code for details.
17958 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17959 `closure_start_type' to `closure_qualifier_type' and check whether
17960 it's not null. It was not this filter being broken, it was just
17961 being called with the wrong arguments.
17963 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17964 and pass it the correct `qualifier_type'; this also does the error
17967 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17969 * expression.cs (Invocation.EmitParams): If the we are dealing
17970 with a non-built-in value type, load its address as well.
17972 (ArrayCreation): Use a a pretty constant instead
17973 of the hardcoded value 2. Use 6 instead of 2 for the number of
17974 static initializers.
17976 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17977 because they are not really value types, just glorified integers.
17979 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17981 * ecore.cs: Remove redundant code for enumerations, make them use
17982 the same code path as everything else, fixes the casting issue
17983 with enumerations in Windows.Forms.
17985 * attribute.cs: Do only cast to string if it is a string, the
17986 validation happens later.
17988 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17989 people upgrade their corlibs.
17991 * ecore.cs: Oops, enumerations were not following the entire code path
17993 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17995 * typemanager.cs (FilterWithClosure): Commented out the test for
17996 1540 in typemanager.cs, as it has problems when accessing
17997 protected methods from a parent class (see test-174.cs).
17999 * attribute.cs (Attribute.ValidateGuid): new method.
18000 (Attribute.Resolve): Use above.
18002 2002-11-19 Miguel de Icaza <miguel@ximian.com>
18004 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
18006 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
18007 handling for enumerations, as we only needed the TypeContainer
18008 functionality to begin with (this is required for the fix below to
18009 work for enums that reference constants in a container class for
18012 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
18014 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
18015 a valid TypeBuilder to perform lookups on.o
18017 * class.cs (InheritableMemberSignatureCompare): Use true in the
18018 call to GetGetMethod and GetSetMethod, because we are comparing
18019 the signature, and we need to get the methods *even* if they are
18022 (PropertyBase.CheckBase): ditto.
18024 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
18025 GotoCase.Resolve): Use Peel on EmpytCasts.
18027 * ecore.cs (EmptyCast): drop child, add Peel method.
18029 2002-11-17 Martin Baulig <martin@ximian.com>
18031 * ecore.cs (EmptyCast.Child): New public property.
18033 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
18034 label resolved to an EmptyCast. Fixes #34162.
18035 (GotoCase.Resolve): Likewise.
18036 (Block.EmitMeta): Likewise.
18038 2002-11-17 Martin Baulig <martin@ximian.com>
18040 * expression.cs (Invocation.BetterConversion): Prefer int over
18041 uint; short over ushort; long over ulong for integer literals.
18042 Use ImplicitConversionExists instead of StandardConversionExists
18043 since we also need to check for user-defined implicit conversions.
18044 Fixes #34165. Added test-173.cs.
18046 2002-11-16 Martin Baulig <martin@ximian.com>
18048 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
18049 with the `true' and `false' literals. Fixes #33151.
18051 2002-11-16 Martin Baulig <martin@ximian.com>
18053 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
18054 October 22nd; don't do the cs1540 check for static members.
18056 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18057 now using our own filter here and doing the cs1540 check again.
18059 2002-11-16 Martin Baulig <martin@ximian.com>
18061 * support.cs (InternalParameters): Don't crash if we don't have
18062 any fixed parameters. Fixes #33532.
18064 2002-11-16 Martin Baulig <martin@ximian.com>
18066 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
18067 when looking up static methods to make this work on Windows.
18070 2002-11-16 Martin Baulig <martin@ximian.com>
18072 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
18073 a setter rather than using PropertyInfo.CanWrite.
18075 2002-11-15 Nick Drochak <ndrochak@gol.com>
18077 * class.cs: Allow acces to block member by subclasses. Fixes build
18080 2002-11-14 Martin Baulig <martin@ximian.com>
18082 * class.cs (Constructor.Emit): Added the extern/block check.
18085 2002-11-14 Martin Baulig <martin@ximian.com>
18087 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
18088 iteration while looking for indexers, this is needed because the
18089 indexer may have a different name in our base classes. Fixed the
18090 error reporting (no indexers at all, not get accessor, no
18091 overloaded match). Fixes bug #33089.
18092 (IndexerAccess.DoResolveLValue): Likewise.
18094 2002-11-14 Martin Baulig <martin@ximian.com>
18096 * class.cs (PropertyBase.CheckBase): Make this work for multiple
18097 indexers. Fixes the first part of bug #33089.
18098 (MethodSignature.InheritableMemberSignatureCompare): Added support
18101 2002-11-13 Ravi Pratap <ravi@ximian.com>
18103 * attribute.cs (Attribute.Resolve): Catch the
18104 NullReferenceException and report it since it isn't supposed to
18107 2002-11-12 Miguel de Icaza <miguel@ximian.com>
18109 * expression.cs (Binary.EmitBranchable): Also handle the cases for
18110 LogicalOr and LogicalAnd that can benefit from recursively
18111 handling EmitBranchable. The code now should be nice for Paolo.
18113 2002-11-08 Miguel de Icaza <miguel@ximian.com>
18115 * typemanager.cs (LookupType): Added a negative-hit hashtable for
18116 the Type lookups, as we perform quite a number of lookups on
18117 non-Types. This can be removed once we can deterministically tell
18118 whether we have a type or a namespace in advance.
18120 But this might require special hacks from our corlib.
18124 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
18125 and double which avoids a conversion from an integer to a double.
18127 * expression.cs: tiny optimization, avoid calling IsConstant,
18128 because it effectively performs the lookup twice.
18130 2002-11-06 Miguel de Icaza <miguel@ximian.com>
18132 But a bogus return here to keep the semantics of the old code
18133 until the Mono runtime is fixed.
18135 * pending.cs (GetMissingInterfaces): New method used to remove all
18136 the interfaces that are already implemented by our parent
18137 classes from the list of pending methods.
18139 * interface.cs: Add checks for calls after ResolveTypeExpr.
18141 2002-11-05 Miguel de Icaza <miguel@ximian.com>
18143 * class.cs (Class.Emit): Report warning 67: event not used if the
18144 warning level is beyond 3.
18146 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
18147 being a NullLiteral.
18149 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
18152 * class.cs (TypeContainer.GetClassBases): Cover a missing code
18153 path that might fail if a type can not be resolved.
18155 * expression.cs (Binary.Emit): Emit unsigned versions of the
18158 * driver.cs: use error 5.
18160 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
18162 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
18164 2002-11-01 Miguel de Icaza <miguel@ximian.com>
18166 * cs-parser.jay (switch_section): A beautiful patch from Martin
18167 Baulig that fixed 33094.
18169 2002-10-31 Miguel de Icaza <miguel@ximian.com>
18171 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
18172 Check whether the base is abstract and report an error if so.
18174 * expression.cs (IndexerAccess.DoResolveLValue,
18175 IndexerAccess.DoResolve): ditto.
18177 (Invocation.DoResolve): ditto.
18179 (Invocation.FullMethodDesc): Improve the report string.
18181 * statement.cs (Block): Eliminate IsVariableDefined as it is
18182 basically just a wrapper for GetVariableInfo.
18184 * ecore.cs (SimpleName): Use new
18186 * support.cs (ReflectionParamter.ParameterType): We unwrap the
18187 type, as we return the actual parameter ref/unref state on a
18190 2002-10-30 Miguel de Icaza <miguel@ximian.com>
18192 * support.cs: Return proper flags REF/OUT fixing the previous
18195 * expression.cs: Reverted last patch, that was wrong. Is_ref is
18196 not used to mean `ref' but `ref or out' in ParameterReference
18198 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
18199 full type signature instead of calling TypeManger.CSharpName
18202 * support.cs (InternalParameters.ParameterDesc): Do not compare
18203 directly to the modflags, because REF/OUT will actually be bitsets
18206 * delegate.cs (VerifyMethod): Check also the modifiers.
18208 * cs-tokenizer.cs: Fix bug where floating point values with an
18209 exponent where a sign was missing was ignored.
18211 * driver.cs: Allow multiple assemblies to be specified in a single
18214 2002-10-28 Miguel de Icaza <miguel@ximian.com>
18216 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
18217 because identifiers after a parenthesis would end up in this kind
18218 of production, and we needed to desamiguate it for having casts
18221 (UserDefinedType *) xxx
18223 2002-10-24 Miguel de Icaza <miguel@ximian.com>
18225 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
18226 we should set on the Bindingflags.NonPublic, but not turn on
18227 private_ok. private_ok controls whether a Private member is
18228 returned (this is chekced on the filter routine), while the
18229 BindingFlags.NonPublic just controls whether private/protected
18230 will be allowed. This fixes the problem part of the problem of
18231 private properties being allowed to be used in derived classes.
18233 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
18234 so we can call the children DoResolveLValue method (this will
18235 properly signal errors on lvalue assignments to base properties)
18237 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
18238 getter are null, and we have a property info, we know that this
18239 happened because the lookup failed, so we report an error 122 for
18240 protection level violation.
18242 We also silently return if setter and getter are null in the
18243 resolve functions, this condition only happens if we have flagged
18244 the error before. This is the other half of the problem.
18246 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
18247 not have accessibility information, that is why we were returning
18248 true in the filter function in typemanager.cs.
18250 To properly report 122 (property is inaccessible because of its
18251 protection level) correctly, we report this error in ResolveAccess
18252 by failing if both the setter and the getter are lacking (ie, the
18255 DoResolve and DoLResolve have been modified to check for both
18256 setter/getter being null and returning silently, the reason being
18257 that I did not want to put the knowledge about this error in upper
18260 int old = Report.Errors;
18261 x = new PropertyExpr (...);
18262 if (old != Report.Errors)
18267 So the property expr is returned, but it is invalid, so the error
18268 will be flagged during the resolve process.
18270 * class.cs: Remove InheritablePropertySignatureCompare from the
18271 class, as we no longer depend on the property signature to compute
18272 whether it is possible to implement a method or not.
18274 The reason is that calling PropertyInfo.GetGetMethod will return
18275 null (in .NET, in Mono it works, and we should change this), in
18276 cases where the Get Method does not exist in that particular
18281 class X { public virtual int A { get { return 1; } } }
18283 class Z : Y { public override int A { get { return 2; } } }
18285 Would fail in Z because the parent (Y) would not have the property
18286 defined. So we avoid this completely now (because the alternative
18287 fix was ugly and slow), and we now depend exclusively on the
18290 (PropertyBase.CheckBase): Use a method-base mechanism to find our
18291 reference method, instead of using the property.
18293 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
18294 routines are gone now.
18296 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
18297 names, they were incorrectly named.
18299 * cs-tokenizer.cs: Return are more gentle token on failure.
18301 * pending.cs (PendingImplementation.InterfaceMethod): This routine
18302 had an out-of-sync index variable, which caused it to remove from
18303 the list of pending methods the wrong method sometimes.
18305 2002-10-22 Miguel de Icaza <miguel@ximian.com>
18307 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
18308 CanWrite, because those refer to this particular instance of the
18309 property, and do not take into account the fact that we can
18310 override single members of a property.
18312 Constructor requires an EmitContext. The resolution process does
18313 not happen here, but we need to compute the accessors before,
18314 because the resolution does not always happen for properties.
18316 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
18317 subclass, before we did not update this flag, but we did update
18320 (GetAccessors): Drop this routine, as it did not work in the
18321 presence of partially overwritten set/get methods.
18323 Notice that this broke the cs1540 detection, but that will require
18326 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18330 * driver.cs: issue a warning instead of an error if we don't support
18331 debugging for the platform. Also ignore a couple of errors that may
18332 arise when trying to write the symbols. Undo my previous patch.
18334 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18336 * driver.cs: ignore /debug switch except for Unix platforms.
18338 2002-10-23 Nick Drochak <ndrochak@gol.com>
18340 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
18342 2002-10-21 Miguel de Icaza <miguel@ximian.com>
18344 * driver.cs: Do not make mcs-debug conditional, so we do not break
18345 builds that use it.
18347 * statement.cs (UsageVector.MergeChildren): I would like Martin to
18348 review this patch. But basically after all the children variables
18349 have been merged, the value of "Breaks" was not being set to
18350 new_breaks for Switch blocks. I think that it should be set after
18351 it has executed. Currently I set this to the value of new_breaks,
18352 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
18353 conservative, but I do not understand this code very well.
18355 I did not break anything in the build, so that is good ;-)
18357 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
18359 2002-10-20 Mark Crichton <crichton@gimp.org>
18361 * cfold.cs: Fixed compile blocker. Really fixed it this time.
18363 2002-10-20 Nick Drochak <ndrochak@gol.com>
18365 * cfold.cs: Fixed compile blocker.
18367 2002-10-20 Miguel de Icaza <miguel@ximian.com>
18369 * driver.cs: I was chekcing the key, not the file.
18371 2002-10-19 Ravi Pratap <ravi@ximian.com>
18373 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
18374 message that we were generating - we just need to silently return
18377 2002-10-19 Miguel de Icaza <miguel@ximian.com>
18379 * class.cs (Event.Define): Change my previous commit, as this
18380 breaks the debugger. This is a temporary hack, as it seems like
18381 the compiler is generating events incorrectly to begin with.
18383 * expression.cs (Binary.ResolveOperator): Added support for
18384 "U operator - (E x, E y)"
18386 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
18389 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
18390 init-only variables, but this path did not take into account that
18391 there might be also instance readonly variables. Correct this
18394 This fixes bug 32253
18396 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
18399 * driver.cs: Change the extension for modules to `netmodule'
18401 * cs-parser.jay: Improved slightly the location tracking for
18402 the debugger symbols.
18404 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
18405 modifiers that were specified instead of the hardcoded value
18406 (FamAndAssem). This was basically ignoring the static modifier,
18407 and others. Fixes 32429.
18409 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
18410 fixed a bug in the process (32476)
18412 * expression.cs (ArrayAccess.EmitAssign): Patch from
18413 hwang_rob@yahoo.ca that fixes bug 31834.3
18415 2002-10-18 Miguel de Icaza <miguel@ximian.com>
18417 * driver.cs: Make the module extension .netmodule.
18419 2002-10-16 Miguel de Icaza <miguel@ximian.com>
18421 * driver.cs: Report an error if the resource file is not found
18422 instead of crashing.
18424 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
18425 false, like Emit does.
18427 2002-10-16 Nick Drochak <ndrochak@gol.com>
18429 * typemanager.cs: Remove unused private member. Also reported mcs
18430 bug to report this as a warning like csc.
18432 2002-10-15 Martin Baulig <martin@gnome.org>
18434 * statement.cs (Statement.Emit): Made this a virtual method; emits
18435 the line number info and calls DoEmit().
18436 (Statement.DoEmit): New protected abstract method, formerly knows
18437 as Statement.Emit().
18439 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
18441 2002-10-11 Miguel de Icaza <miguel@ximian.com>
18443 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
18444 have fixed a remaining problem: not every AddXXXX was adding a
18445 fully qualified name.
18447 Now everyone registers a fully qualified name in the DeclSpace as
18448 being defined instead of the partial name.
18450 Downsides: we are slower than we need to be due to the excess
18451 copies and the names being registered this way.
18453 The reason for this is that we currently depend (on the corlib
18454 bootstrap for instance) that types are fully qualified, because
18455 we dump all the types in the namespace, and we should really have
18456 types inserted into the proper namespace, so we can only store the
18457 basenames in the defined_names array.
18459 2002-10-10 Martin Baulig <martin@gnome.org>
18461 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
18462 from bug #31834, see the bug report for a testcase which is
18465 2002-10-10 Martin Baulig <martin@gnome.org>
18467 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
18468 flow analysis code for this.
18470 * statement.cs (Do, While, For): Tell the flow analysis code about
18472 (FlowBranching.UsageVector): Added support for infinite loops.
18473 (Block.Resolve): Moved the dead code elimination here and use flow
18476 2002-10-09 Miguel de Icaza <miguel@ximian.com>
18478 * class.cs (Field.Define): Catch cycles on struct type
18481 * typemanager.cs (IsUnmanagedtype): Do not recursively check
18482 fields if the fields are static. We only need to check instance
18485 * expression.cs (As.DoResolve): Test for reference type.
18487 * statement.cs (Using.ResolveExpression): Use
18488 ConvertImplicitRequired, not ConvertImplicit which reports an
18490 (Using.ResolveLocalVariableDecls): ditto.
18492 * expression.cs (Binary.ResolveOperator): Report errors in a few
18493 places where we had to.
18495 * typemanager.cs (IsUnmanagedtype): Finish implementation.
18497 2002-10-08 Miguel de Icaza <miguel@ximian.com>
18499 * expression.cs: Use StoreFromPtr instead of extracting the type
18500 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
18502 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
18503 an enumeration value to a System.Enum, but System.Enum is not a
18504 value type, but an class type, so we need to box.
18506 (Expression.ConvertExplicit): One codepath could return
18507 errors but not flag them. Fix this. Fixes #31853
18509 * parameter.cs (Resolve): Do not allow void as a parameter type.
18511 2002-10-06 Martin Baulig <martin@gnome.org>
18513 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
18514 if it's a class type and not a struct. Fixes #31815.
18516 2002-10-06 Martin Baulig <martin@gnome.org>
18518 * statement.cs: Reworked the flow analysis code a bit to make it
18519 usable for dead code elimination.
18521 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18523 * cs-parser.jay: allow empty source files. Fixes bug #31781.
18525 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18527 * expression.cs (ComposedCast.DoResolveType): A quick workaround
18528 to fix the test 165, will investigate deeper.
18530 2002-10-04 Martin Baulig <martin@gnome.org>
18532 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
18533 finally blocks actually work.
18534 (Try.Resolve): We don't need to create a sibling for `finally' if
18535 there is no finally block.
18537 2002-10-04 Martin Baulig <martin@gnome.org>
18539 * class.cs (Constructor.Define): The default accessibility for a
18540 non-default constructor is private, not public.
18542 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18544 * class.cs (Constructor): Make AllowedModifiers public, add
18547 * cs-parser.jay: Perform the modifiers test here, as the
18548 constructor for the Constructor class usually receives a zero
18549 because of the way we create it (first we create, later we
18550 customize, and we were never checking the modifiers).
18552 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
18553 is a version of LookupTypeReflection that includes the type-name
18554 cache. This can be used as a fast path for functions that know
18555 the fully qualified name and are only calling into *.GetType() to
18556 obtain a composed type.
18558 This is also used by TypeManager.LookupType during its type
18561 (LookupType): We now also track the real type name, as sometimes
18562 we can get a quey for the real type name from things like
18563 ComposedCast. This fixes bug 31422.
18565 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
18566 complete type fullname, it does not have to go through the type
18567 resolution system to obtain the composed version of the type (for
18568 obtaining arrays or pointers).
18570 (Conditional.Emit): Use the EmitBoolExpression to
18571 generate nicer code, as requested by Paolo.
18573 (ArrayCreation.CheckIndices): Use the patch from
18574 hwang_rob@yahoo.ca to validate the array initializers.
18576 2002-10-03 Miguel de Icaza <miguel@ximian.com>
18578 * class.cs (ConstructorInitializer.Emit): simplify code by using
18579 Invocation.EmitCall, and at the same time, fix the bugs in calling
18580 parent constructors that took variable arguments.
18582 * ecore.cs (Expression.ConvertNumericExplicit,
18583 Expression.ImplicitNumericConversion): Remove the code that
18584 manually wrapped decimal (InternalTypeConstructor call is now gone
18587 * expression.cs (Cast.TryReduce): Also handle decimal types when
18588 trying to perform a constant fold on the type.
18590 * typemanager.cs (IsUnmanagedtype): Partially implemented.
18592 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
18593 that only turned off an error report, and did nothing else.
18595 2002-10-02 Miguel de Icaza <miguel@ximian.com>
18597 * driver.cs: Handle and ignore /fullpaths
18599 2002-10-01 Miguel de Icaza <miguel@ximian.com>
18601 * expression.cs (Binary.ResolveOperator): Catch the case where
18602 DoNumericPromotions returns true,
18604 (Binary.DoNumericPromotions): Simplify the code, and the tests.
18606 2002-09-27 Miguel de Icaza <miguel@ximian.com>
18608 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
18611 2002-09-26 Miguel de Icaza <miguel@ximian.com>
18613 * ecore.cs (ConvertNumericExplicit): It is not enough that the
18614 conversion exists, but it is also required that the conversion be
18615 performed. This manifested in "(Type64Enum) 2".
18617 * class.cs (TypeManager.AddMethod): The fix is not to change
18618 AddEnum, because that one was using a fully qualified name (every
18619 DeclSpace derivative does), but to change the AddMethod routine
18620 that was using an un-namespaced name. This now correctly reports
18621 the duplicated name.
18623 Revert patch until I can properly fix it. The issue
18624 is that we have a shared Type space across all namespaces
18625 currently, which is wrong.
18627 Options include making the Namespace a DeclSpace, and merge
18628 current_namespace/current_container in the parser.
18630 2002-09-25 Miguel de Icaza <miguel@ximian.com>
18632 * cs-parser.jay: Improve error reporting when we get a different
18633 kind of expression in local_variable_type and
18634 local_variable_pointer_type.
18636 Propagate this to avoid missleading errors being reported.
18638 * ecore.cs (ImplicitReferenceConversion): treat
18639 TypeManager.value_type as a target just like object_type. As
18644 Is valid, and needs to result in the int 1 being boxed before it
18645 is assigned to the value type v.
18647 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
18648 to validate the enumeration name.
18650 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
18651 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
18652 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
18654 * ecore.cs (TryImplicitIntConversion): When doing an
18655 implicit-enumeration-conversion, check if the type is 64-bits and
18656 perform a conversion before passing to EnumConstant.
18658 2002-09-23 Miguel de Icaza <miguel@ximian.com>
18660 * decl.cs (Error_AmbiguousTypeReference); New routine used to
18661 report ambiguous type references. Unlike the MS version, we
18662 report what the ambiguity is. Innovation at work ;-)
18664 (DeclSpace.FindType): Require a location argument to
18665 display when we display an ambiguous error.
18667 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
18669 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
18671 * expression.cs (EmitDynamicInitializers): Apply patch from
18672 hwang_rob@yahoo.ca that fixes the order in which we emit our
18675 2002-09-21 Martin Baulig <martin@gnome.org>
18677 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
18678 delegate takes no arguments.
18680 2002-09-20 Miguel de Icaza <miguel@ximian.com>
18682 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
18685 * expression.cs: Extract the underlying type.
18687 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
18689 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
18691 2002-09-19 Miguel de Icaza <miguel@ximian.com>
18693 * class.cs (TypeContainer.DefineType): We can not use the nice
18694 PackingSize with the size set to 1 DefineType method, because it
18695 will not allow us to define the interfaces that the struct
18698 This completes the fixing of bug 27287
18700 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
18701 means also structs. This fixes part of the problem.
18702 (Expresion.ImplicitReferenceConversionExists): ditto.
18704 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
18705 error if there were no errors reported during the type lookup
18706 process, to avoid duplicates or redundant errors. Without this
18707 you would get an ambiguous errors plus a type not found. We have
18708 beaten the user enough with the first error.
18710 (DeclSparce.FindType): Emit a warning if we have an ambiguous
18713 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
18714 during the resolution process, stop the lookup, this avoids
18715 repeated error reports (same error twice).
18717 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
18719 * typemanager.cs (LookupType): Redo the type lookup code to match
18720 the needs of System.Reflection.
18722 The issue is that System.Reflection requires references to nested
18723 types to begin with a "+" sign instead of a dot. So toplevel
18724 types look like: "NameSpace.TopLevelClass", and nested ones look
18725 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
18728 2002-09-19 Martin Baulig <martin@gnome.org>
18730 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
18731 says that a method always returns or always throws an exception,
18732 don't report the CS0161.
18734 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
18735 set `Returns = new_returns'.
18737 2002-09-19 Martin Baulig <martin@gnome.org>
18739 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
18740 to an enum constant, check for a CS0176.
18742 2002-09-18 Miguel de Icaza <miguel@ximian.com>
18744 * class.cs (TypeContainer.CheckPairedOperators): Now we check
18745 for operators that must be in pairs and report errors.
18747 * ecore.cs (SimpleName.DoResolveType): During the initial type
18748 resolution process, when we define types recursively, we must
18749 check first for types in our current scope before we perform
18750 lookups in the enclosing scopes.
18752 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18754 (Invocation.VerifyArgumentsCompat): Call
18755 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18756 I thought we were supposed to always call this, but there are a
18757 few places in the code where we dont do it.
18759 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18761 * driver.cs: Add support in -linkres and -resource to specify the
18762 name of the identifier.
18764 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18766 * ecore.cs (StandardConversionExists): Sync with the conversion
18767 code: allow anything-* to void* conversions.
18769 (FindMostSpecificSource): Use an Expression argument
18770 instead of a Type, because we might be handed over a Literal which
18771 gets a few more implicit conversions that plain types do not. So
18772 this information was being lost.
18774 Also, we drop the temporary type-holder expression when not
18777 2002-09-17 Martin Baulig <martin@gnome.org>
18779 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18780 this is an explicit interface implementation.
18782 2002-09-17 Martin Baulig <martin@gnome.org>
18784 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18785 different `IndexerName' attributes.
18787 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18788 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18789 virtual CommonResolve().
18791 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18793 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18794 and convert that to the UnderlyingType.
18796 * statement.cs (Foreach.Resolve): Indexers are just like variables
18797 or PropertyAccesses.
18799 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18800 inside quoted strings, we were not doing this before.
18802 2002-09-16 Martin Baulig <martin@gnome.org>
18804 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18805 resolve it. This is needed for the definite assignment check of the
18806 instance expression, fixes bug #29846.
18807 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18809 2002-09-16 Nick Drochak <ndrochak@gol.com>
18811 * parameter.cs: Fix compile error. Cannot reference static member
18812 from an instance object. Is this an mcs bug?
18814 2002-09-14 Martin Baulig <martin@gnome.org>
18816 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18817 multiple times. Fixes bug #30295, added test-166.cs.
18819 2002-09-14 Martin Baulig <martin@gnome.org>
18821 * statement.cs (Block.Emit): Don't emit unreachable code.
18822 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18823 `break' statements.
18824 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18826 2002-09-14 Martin Baulig <martin@gnome.org>
18828 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18831 2002-09-14 Martin Baulig <martin@gnome.org>
18833 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18834 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18835 be false on the ms runtime.
18837 2002-09-13 Martin Baulig <martin@gnome.org>
18839 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18840 the CS0038 error message.
18842 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18844 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18845 constant inside, return it.
18847 2002-09-12 Martin Baulig <martin@gnome.org>
18849 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18850 implicit conversion can be done between enum types.
18852 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18853 check whether an implicit conversion to the current enum's UnderlyingType
18854 exists and report an error if not.
18856 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18857 without debugging support.
18859 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18860 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18862 2002-09-12 Martin Baulig <martin@gnome.org>
18864 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18866 * ecore.cs (IMemberExpr.DeclaringType): New property.
18867 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18868 nonstatic member of an outer type (CS0038).
18870 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18872 * driver.cs: Activate the using-error detector at warning level
18873 4 (at least for MS-compatible APIs).
18875 * namespace.cs (VerifyUsing): Small buglett fix.
18877 * pending.cs (PendingImplementation): pass the container pointer.
18879 * interface.cs (GetMethods): Allow for recursive definition. Long
18880 term, I would like to move every type to support recursive
18881 definitions, not the current ordering mechanism that we have right
18884 The situation is this: Attributes are handled before interfaces,
18885 so we can apply attributes to interfaces. But some attributes
18886 implement interfaces, we will now handle the simple cases
18887 (recursive definitions will just get an error).
18889 * parameter.cs: Only invalidate types at the end if we fail to
18892 2002-09-09 Martin Baulig <martin@gnome.org>
18894 * ecore.cs (PropertyExpr.Emit): Also check for
18895 TypeManager.system_int_array_get_length so this'll also work when
18896 compiling corlib. Fixes #30003.
18898 2002-09-09 Martin Baulig <martin@gnome.org>
18900 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18901 and throw an exception if we can't get the type's size. Fixed #30040,
18904 2002-09-09 Martin Baulig <martin@gnome.org>
18906 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18908 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18909 context. Fixes bug #30027.
18911 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18912 virtual functions. Fixes bug #30043, added test-164.cs.
18914 2002-09-08 Ravi Pratap <ravi@ximian.com>
18916 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18918 2002-09-08 Nick Drochak <ndrochak@gol.com>
18920 * driver.cs: Use an object to get the windows codepage since it's not a
18923 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18925 * statement.cs (For.Emit): for infinite loops (test == null)
18926 return whether there is a break inside, not always "true".
18928 * namespace.cs (UsingEntry): New struct to hold the name of the
18929 using definition, the location where it is defined, and whether it
18930 has been used in a successful type lookup.
18932 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18937 2002-09-06 Ravi Pratap <ravi@ximian.com>
18939 * attribute.cs : Fix incorrect code which relied on catching
18940 a NullReferenceException to detect a null being passed in
18941 where an object was expected.
18943 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18945 * statement.cs (Try): flag the catch variable as assigned
18947 * expression.cs (Cast): Simplified by using ResolveType instead of
18948 manually resolving.
18950 * statement.cs (Catch): Fix bug by using ResolveType.
18952 2002-09-06 Ravi Pratap <ravi@ximian.com>
18954 * expression.cs (BetterConversion): Special case for when we have
18955 a NullLiteral as the argument and we have to choose between string
18956 and object types - we choose string the way csc does.
18958 * attribute.cs (Attribute.Resolve): Catch the
18959 NullReferenceException and report error #182 since the Mono
18960 runtime no more has the bug and having this exception raised means
18961 we tried to select a constructor which takes an object and is
18964 2002-09-05 Ravi Pratap <ravi@ximian.com>
18966 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18967 message (1502, 1503) when we can't locate a method after overload
18968 resolution. This is much more informative and closes the bug
18971 * interface.cs (PopulateMethod): Return if there are no argument
18972 types. Fixes a NullReferenceException bug.
18974 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18975 expressions too. Previously we were checking only in one place for
18976 positional arguments leaving out named arguments.
18978 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18979 type to the enum type is not allowed. Remove code corresponding to
18982 (ConvertNumericExplicit): Allow explicit conversions from
18983 the underlying type to enum type. This precisely follows the spec
18984 and closes a bug filed by Gonzalo.
18986 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18989 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18991 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18993 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18994 it was important that we stored the right value after the
18995 reduction in `converted'.
18997 2002-09-04 Martin Baulig <martin@gnome.org>
18999 * location.cs (Location.SymbolDocument): Use full pathnames for the
19002 2002-08-30 Miguel de Icaza <miguel@ximian.com>
19004 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
19005 of the expression resolve mechanism, because that will catch the
19006 SimpleName error failures.
19008 (Conditional): If we can not resolve the
19009 expression, return, do not crash.
19011 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19014 (location): display token name instead of its number.
19016 2002-08-28 Martin Baulig <martin@gnome.org>
19018 * expression.cs (Binary.ResolveOperator): Don't silently return
19019 but return an error if an operator cannot be applied between two
19022 2002-08-28 Martin Baulig <martin@gnome.org>
19024 * class.cs (Constructor.Define): Set the permission attributes
19025 correctly instead of making all constructors public.
19027 2002-08-28 Martin Baulig <martin@gnome.org>
19029 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
19030 for private members before reporting a CS0103; if we find anything,
19033 2002-08-28 Martin Baulig <martin@gnome.org>
19035 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
19036 to check whether `closure_start_type == closure_invocation_type',
19037 we also need to check whether `m.DeclaringType == closure_invocation_type'
19038 before bypassing the permission checks. We might be accessing
19039 protected/private members from the base class.
19040 (TypeManager.RealMemberLookup): Only set private_ok if private
19041 members were requested via BindingFlags.NonPublic.
19043 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
19045 * expression.cs (MemberAccess.ResolveMemberAccess): Set
19046 MethodGroupExpr.IsExplicitImpl if appropriate.
19047 (Invocation.DoResolve): Don't report the CS0120 for explicit
19048 interface implementations.
19050 2002-08-27 Martin Baulig <martin@gnome.org>
19052 * expression.cs (Invocation.DoResolve): If this is a static
19053 method and we don't have an InstanceExpression, we must report
19056 2002-08-25 Martin Baulig <martin@gnome.org>
19058 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
19059 `==' between a valuetype and an object.
19061 2002-08-25 Miguel de Icaza <miguel@ximian.com>
19063 * ecore.cs (TypeExpr): Provide a ToString method.
19065 2002-08-24 Martin Baulig <martin@gnome.org>
19067 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
19068 now called proggie.dbg and it's a binary file.
19070 2002-08-23 Martin Baulig <martin@gnome.org>
19072 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
19074 2002-08-23 Martin Baulig <martin@gnome.org>
19076 * struct.cs (MyStructInfo.ctor): Make this work with empty
19077 structs; it's not allowed to use foreach() on null.
19079 2002-08-23 Martin Baulig <martin@gnome.org>
19081 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
19082 writer the full pathname of the generated assembly.
19084 2002-08-23 Martin Baulig <martin@gnome.org>
19086 * statements.cs (FlowBranching.UsageVector.MergeChildren):
19087 A `finally' block never returns or breaks; improved handling of
19090 2002-08-23 Martin Baulig <martin@gnome.org>
19092 * statement.cs (Throw.Resolve): Allow `throw null'.
19094 2002-08-23 Martin Baulig <martin@gnome.org>
19096 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
19097 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
19098 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
19099 MemberLookup would return a wrong event if this is an explicit
19100 interface implementation and the class has an event with the same
19103 2002-08-23 Martin Baulig <martin@gnome.org>
19105 * statement.cs (Block.AddChildVariableNames): New public method.
19106 (Block.AddChildVariableName): Likewise.
19107 (Block.IsVariableNameUsedInChildBlock): Likewise.
19108 (Block.AddVariable): Check whether a variable name has already
19109 been used in a child block.
19111 * cs-parser.jay (declare_local_variables): Mark all variable names
19112 from the current block as being used in a child block in the
19115 2002-08-23 Martin Baulig <martin@gnome.org>
19117 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
19118 find the symbol writer.
19120 * driver.cs: csc also allows the arguments to /define being
19121 separated by commas, not only by semicolons.
19123 2002-08-23 Martin Baulig <martin@gnome.org>
19125 * interface.cs (Interface.GetMembers): Added static check for events.
19127 2002-08-15 Martin Baulig <martin@gnome.org>
19129 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
19130 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
19132 * ecore.cs (Expression.MemberLookup): Added documentation and explained
19133 why the MethodData.EmitDestructor() change was necessary.
19135 2002-08-20 Martin Baulig <martin@gnome.org>
19137 * class.cs (TypeContainer.FindMembers): Added static check for events.
19139 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
19141 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
19142 use Type.GetEvents(), not Type.FindMembers().
19144 2002-08-20 Martin Baulig <martin@gnome.org>
19146 * decl.cs (MemberCache): Added a special method cache which will
19147 be used for method-only searched. This ensures that a method
19148 search will return a MethodInfo with the correct ReflectedType for
19151 2002-08-20 Martin Baulig <martin@gnome.org>
19153 * decl.cs (DeclSpace.FindMembers): Made this public.
19155 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19157 * delegate.cs: fixed build on windows.
19158 [FIXME: Filed as bug #29150: MCS must report these errors.]
19160 2002-08-19 Ravi Pratap <ravi@ximian.com>
19162 * ecore.cs (StandardConversionExists): Return a false
19163 if we are trying to convert the void type to anything else
19164 since that is not allowed.
19166 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
19167 we flag error 70 in the event an event is trying to be accessed
19168 directly from outside the declaring type.
19170 2002-08-20 Martin Baulig <martin@gnome.org>
19172 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
19173 MemberCache from typemanager.cs to decl.cs.
19175 2002-08-19 Martin Baulig <martin@gnome.org>
19177 * class.cs (TypeContainer): Implement IMemberContainer.
19178 (TypeContainer.DefineMembers): Create the MemberCache.
19179 (TypeContainer.FindMembers): Do better BindingFlags checking; only
19180 return public members if BindingFlags.Public was given, check
19181 whether members are static.
19183 2002-08-16 Martin Baulig <martin@gnome.org>
19185 * decl.cs (DeclSpace.Define): Splitted this in Define and
19186 DefineMembers. DefineMembers is called first and initializes the
19189 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
19190 DefineMembers() on all our DeclSpaces.
19192 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
19193 but call DefineMembers() on all nested interfaces. We call their
19194 Define() in our new Define() function.
19196 * interface.cs (Interface): Implement IMemberContainer.
19197 (Interface.Define): Moved all code except the attribute stuf to
19199 (Interface.DefineMembers): Initialize the member cache.
19201 * typemanager.cs (IMemberFinder): Removed this interface, we don't
19202 need this anymore since we can use MemberCache.FindMembers directly.
19204 2002-08-19 Martin Baulig <martin@gnome.org>
19206 * typemanager.cs (MemberCache): When creating the cache for an
19207 interface type, add all inherited members.
19208 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
19209 to `out bool used_cache' and documented it.
19210 (TypeManager.MemberLookup): If we already used the cache in the first
19211 iteration, we don't need to do the interfaces check.
19213 2002-08-19 Martin Baulig <martin@gnome.org>
19215 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
19216 here from IMemberFinder and don't implement this interface anymore.
19217 (DeclSpace.MemberCache): Moved here from IMemberFinder.
19219 * typemanager.cs (IMemberFinder): This interface is now only used by
19220 classes which actually support the member cache.
19221 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
19222 since we only put DeclSpaces into this Hashtable.
19223 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
19224 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
19226 2002-08-16 Martin Baulig <martin@gnome.org>
19228 * typemanager.cs (ICachingMemberFinder): Removed.
19229 (IMemberFinder.MemberCache): New property.
19230 (TypeManager.FindMembers): Merged this with RealFindMembers().
19231 This function will never be called from TypeManager.MemberLookup()
19232 so we can't use the cache here, just the IMemberFinder.
19233 (TypeManager.MemberLookup_FindMembers): Check whether the
19234 IMemberFinder has a MemberCache and call the cache's FindMembers
19236 (MemberCache): Rewrote larger parts of this yet another time and
19237 cleaned it up a bit.
19239 2002-08-15 Miguel de Icaza <miguel@ximian.com>
19241 * driver.cs (LoadArgs): Support quoting.
19243 (Usage): Show the CSC-like command line arguments.
19245 Improved a few error messages.
19247 2002-08-15 Martin Baulig <martin@gnome.org>
19249 * typemanager.cs (IMemberContainer.Type): New property.
19250 (IMemberContainer.IsInterface): New property.
19252 The following changes are conditional to BROKEN_RUNTIME, which is
19253 defined at the top of the file.
19255 * typemanager.cs (MemberCache.MemberCache): Don't add the base
19256 class'es members, but add all members from TypeHandle.ObjectType
19257 if we're an interface.
19258 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
19259 is the current type.
19260 (MemberCache.CacheEntry.Container): Removed this field.
19261 (TypeHandle.GetMembers): Include inherited members.
19263 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19265 * typemanager.cs: fixed compilation and added a comment on a field that
19268 2002-08-15 Martin Baulig <martin@gnome.org>
19270 * class.cs (ConstructorInitializer.Resolve): In the
19271 Expression.MemberLookup call, use the queried_type as
19274 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
19275 declared' attribute, it's always true.
19276 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
19277 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
19278 temporary wrapper for FindMembers which tells MemberLookup whether
19279 members from the base classes are included in the return value.
19280 This will go away soon.
19281 (TypeManager.MemberLookup): Use this temporary hack here; once the
19282 new MemberCache is completed, we don't need to do the DeclaredOnly
19283 looping here anymore since the MemberCache will take care of this.
19284 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
19285 (MemberCache): When creating the MemberCache for a class, get
19286 members from the current class and all its base classes.
19287 (MemberCache.CacheEntry.Container): New field. This is a
19288 temporary hack until the Mono runtime is fixed to distinguish
19289 between ReflectedType and DeclaringType. It allows us to use MCS
19290 with both the MS runtime and the unfixed Mono runtime without
19291 problems and without accecting performance.
19292 (MemberCache.SearchMembers): The DeclaredOnly looping from
19293 TypeManager.MemberLookup is now done here.
19295 2002-08-14 Martin Baulig <martin@gnome.org>
19297 * statement.cs (MyStructInfo.MyStructInfo): Don't call
19298 Type.GetFields on dynamic types but get the fields from the
19299 corresponding TypeContainer.
19300 (MyStructInfo.GetStructInfo): Added check for enum types.
19302 * typemanager.cs (MemberList.IsSynchronized): Implemented.
19303 (MemberList.SyncRoot): Implemented.
19304 (TypeManager.FilterWithClosure): No need to check permissions if
19305 closure_start_type == closure_invocation_type, don't crash if
19306 closure_invocation_type is null.
19308 2002-08-13 Martin Baulig <martin@gnome.org>
19310 Rewrote TypeContainer.FindMembers to use a member cache. This
19311 gives us a speed increase of about 35% for the self-hosting MCS
19312 build and of about 15-20% for the class libs (both on GNU/Linux).
19314 * report.cs (Timer): New class to get enhanced profiling. This
19315 whole class is "TIMER" conditional since it remarkably slows down
19318 * class.cs (MemberList): New class. This is an IList wrapper
19319 which we're now using instead of passing MemberInfo[]'s around to
19320 avoid copying this array unnecessarily.
19321 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
19322 (ICachingMemberFinder, IMemberContainer): New interface.
19323 (TypeManager.FilterWithClosure): If `criteria' is null, the name
19324 has already been checked, otherwise use it for the name comparision.
19325 (TypeManager.FindMembers): Renamed to RealMemberFinder and
19326 provided wrapper which tries to use ICachingMemberFinder.FindMembers
19327 if possible. Returns a MemberList, not a MemberInfo [].
19328 (TypeHandle): New class, implements IMemberContainer. We create
19329 one instance of this class per type, it contains a MemberCache
19330 which is used to do the member lookups.
19331 (MemberCache): New class. Each instance of this class contains
19332 all members of a type and a name-based hash table.
19333 (MemberCache.FindMembers): This is our new member lookup
19334 function. First, it looks up all members of the requested name in
19335 the hash table. Then, it walks this list and sorts out all
19336 applicable members and returns them.
19338 2002-08-13 Martin Baulig <martin@gnome.org>
19340 In addition to a nice code cleanup, this gives us a performance
19341 increase of about 1.4% on GNU/Linux - not much, but it's already
19342 half a second for the self-hosting MCS compilation.
19344 * typemanager.cs (IMemberFinder): New interface. It is used by
19345 TypeManager.FindMembers to call FindMembers on a TypeContainer,
19346 Enum, Delegate or Interface.
19347 (TypeManager.finder_to_member_finder): New PtrHashtable.
19348 (TypeManager.finder_to_container): Removed.
19349 (TypeManager.finder_to_delegate): Removed.
19350 (TypeManager.finder_to_interface): Removed.
19351 (TypeManager.finder_to_enum): Removed.
19353 * interface.cs (Interface): Implement IMemberFinder.
19355 * delegate.cs (Delegate): Implement IMemberFinder.
19357 * enum.cs (Enum): Implement IMemberFinder.
19359 * class.cs (TypeContainer): Implement IMemberFinder.
19361 2002-08-12 Martin Baulig <martin@gnome.org>
19363 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
19365 2002-08-12 Martin Baulig <martin@gnome.org>
19367 * ecore.cs (ITypeExpression): New interface for expressions which
19369 (TypeExpression): Renamed to TypeLookupExpression.
19370 (Expression.DoResolve): If we're doing a types-only lookup, the
19371 expression must implement the ITypeExpression interface and we
19372 call DoResolveType() on it.
19373 (SimpleName): Implement the new ITypeExpression interface.
19374 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
19375 hack, the situation that we're only looking up types can't happen
19376 anymore when this method is called. Moved the type lookup code to
19377 DoResolveType() and call it.
19378 (SimpleName.DoResolveType): This ITypeExpression interface method
19379 is now doing the types-only lookup.
19380 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
19381 (ResolveFlags): Added MaskExprClass.
19383 * expression.cs (MemberAccess): Implement the ITypeExpression
19385 (MemberAccess.DoResolve): Added support for a types-only lookup
19386 when we're called via ITypeExpression.DoResolveType().
19387 (ComposedCast): Implement the ITypeExpression interface.
19389 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
19390 Expression.Resolve() with ResolveFlags.Type instead.
19392 2002-08-12 Martin Baulig <martin@gnome.org>
19394 * interface.cs (Interface.Define): Apply attributes.
19396 * attribute.cs (Attribute.ApplyAttributes): Added support for
19397 interface attributes.
19399 2002-08-11 Martin Baulig <martin@gnome.org>
19401 * statement.cs (Block.Emit): Only check the "this" variable if we
19402 do not always throw an exception.
19404 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
19405 whether the property has a set accessor.
19407 2002-08-11 Martin Baulig <martin@gnome.org>
19409 Added control flow analysis support for structs.
19411 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
19412 with control flow analysis turned off.
19413 (IVariable): New interface.
19414 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
19415 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
19416 (FieldExpr.DoResolve): Resolve the instance expression with flow
19417 analysis turned off and do the definite assignment check after the
19418 resolving when we know what the expression will resolve to.
19420 * expression.cs (LocalVariableReference, ParameterReference):
19421 Implement the new IVariable interface, only call the flow analysis
19422 code if ec.DoFlowAnalysis is true.
19423 (This): Added constructor which takes a Block argument. Implement
19424 the new IVariable interface.
19425 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
19426 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
19427 This does the definite assignment checks for struct members.
19429 * class.cs (Constructor.Emit): If this is a non-static `struct'
19430 constructor which doesn't have any initializer, call
19431 Block.AddThisVariable() to tell the flow analysis code that all
19432 struct elements must be initialized before control returns from
19435 * statement.cs (MyStructInfo): New public class.
19436 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
19437 argument to this indexer. If non-zero, check an individual struct
19438 member, not the whole struct.
19439 (FlowBranching.CheckOutParameters): Check struct members.
19440 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
19441 overloaded versions of these methods which take an additional
19442 `int field_idx' argument to check struct members.
19443 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
19444 overloaded versions of these methods which take an additional
19445 `string field_name' argument to check struct member.s
19446 (VariableInfo): Implement the IVariable interface.
19447 (VariableInfo.StructInfo): New public property. Returns the
19448 MyStructInfo instance of the variable if it's a struct or null.
19449 (Block.AddThisVariable): New public method. This is called from
19450 Constructor.Emit() for non-static `struct' constructor which do
19451 not have any initializer. It creates a special variable for the
19452 "this" instance variable which will be checked by the flow
19453 analysis code to ensure that all of the struct's fields are
19454 initialized before control returns from the constructor.
19455 (UsageVector): Added support for struct members. If a
19456 variable/parameter is a struct with N members, we reserve a slot
19457 in the usage vector for each member. A struct is considered fully
19458 initialized if either the struct itself (slot 0) or all its
19459 members are initialized.
19461 2002-08-08 Martin Baulig <martin@gnome.org>
19463 * driver.cs (Driver.MainDriver): Only report an error CS5001
19464 if there were no compilation errors.
19466 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
19467 `UnsafeContext' property to determine whether the parent is in
19468 unsafe context rather than checking the parent's ModFlags:
19469 classes nested in an unsafe class are unsafe as well.
19471 2002-08-08 Martin Baulig <martin@gnome.org>
19473 * statement.cs (UsageVector.MergeChildren): Distinguish between
19474 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
19475 we return. Added test17() and test18() to test-154.cs.
19477 2002-08-08 Martin Baulig <martin@gnome.org>
19479 * typemanager.cs (TypeManager.FilterWithClosure): If we have
19480 Family access, make sure the invoking type isn't a subclass of the
19481 queried type (that'd be a CS1540).
19483 * ecore.cs (Expression.MemberLookup): Added overloaded version of
19484 this method which takes an additional `Type invocation_type'.
19486 * expression.cs (BaseAccess.DoResolve): Use the base type as
19487 invocation and query type.
19488 (MemberAccess.DoResolve): If the lookup failed and we're about to
19489 report a CS0122, try a lookup with the ec.ContainerType - if this
19490 succeeds, we must report a CS1540.
19492 2002-08-08 Martin Baulig <martin@gnome.org>
19494 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
19495 (MethodGroupExpr): Implement the IMemberExpr interface.
19497 * expression (MemberAccess.ResolveMemberAccess): No need to have
19498 any special code for MethodGroupExprs anymore, they're now
19501 2002-08-08 Martin Baulig <martin@gnome.org>
19503 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
19504 Family, FamANDAssem and FamORAssem permissions.
19505 (TypeManager.IsSubclassOrNestedChildOf): New public method.
19507 2002-08-08 Martin Baulig <martin@gnome.org>
19509 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
19510 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
19513 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
19515 * driver.cs: implemented /resource option to embed managed resources.
19517 2002-08-07 Martin Baulig <martin@gnome.org>
19519 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
19520 (FieldBase.HasFieldInitializer): New public property.
19521 (FieldBase.GetInitializerExpression): New public method. Resolves and
19522 returns the field initializer and makes sure it is only resolved once.
19523 (TypeContainer.EmitFieldInitializers): Call
19524 FieldBase.GetInitializerExpression to get the initializer, this ensures
19525 that it isn't resolved multiple times.
19527 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
19528 the resolving process (SimpleName/MemberLookup) that we're currently
19529 emitting a field initializer (which must not access any instance members,
19530 this is an error CS0236).
19532 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
19533 argument, if the `IsFieldInitializer' flag is set, we must report and
19534 error CS0236 and not an error CS0120.
19536 2002-08-07 Martin Baulig <martin@gnome.org>
19538 * ecore.cs (IMemberExpr): New public interface.
19539 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
19540 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
19541 if the expression is an IMemberExpr.
19543 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
19544 to be null, implicitly default to `this' if we're non-static in
19545 this case. Simplified the code a lot by using the new IMemberExpr
19546 interface. Also fixed bug #28176 here.
19548 2002-08-06 Martin Baulig <martin@gnome.org>
19550 * cs-parser.jay (SimpleLookup): Removed. We need to create
19551 ParameterReferences during semantic analysis so that we can do a
19552 type-only search when resolving Cast, TypeOf and SizeOf.
19553 (block): Pass the `current_local_parameters' to the Block's
19556 * class.cs (ConstructorInitializer): Added `Parameters parameters'
19557 argument to the constructor.
19558 (ConstructorInitializer.Resolve): Create a temporary implicit
19559 block with the parameters.
19561 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
19562 references here if we aren't doing a type-only search.
19564 * statement.cs (Block): Added constructor which takes a
19565 `Parameters parameters' argument.
19566 (Block.Parameters): New public property.
19568 * support.cs (InternalParameters.Parameters): Renamed `parameters'
19569 to `Parameters' and made it public readonly.
19571 2002-08-06 Martin Baulig <martin@gnome.org>
19573 * ecore.cs (Expression.Warning): Made this public as well.
19575 * report.cs (Report.Debug): Print the contents of collections.
19577 2002-08-06 Martin Baulig <martin@gnome.org>
19579 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
19580 used to tell Resolve() which kinds of expressions it may return.
19581 (Expression.Resolve): Added overloaded version of this method which
19582 takes a `ResolveFlags flags' argument. This can be used to tell
19583 Resolve() which kinds of expressions it may return. Reports a
19585 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
19586 ResolveFlags.SimpleName.
19587 (Expression.Error118): Added overloaded version of this method which
19588 takes a `ResolveFlags flags' argument. It uses the flags to determine
19589 which kinds of expressions are allowed.
19591 * expression.cs (Argument.ResolveMethodGroup): New public method.
19592 Resolves an argument, but allows a MethodGroup to be returned.
19593 This is used when invoking a delegate.
19595 * TODO: Updated a bit.
19597 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19599 Fixed compilation with csc.
19601 * ecore.cs: Expression.Error made public. Is this correct? Should
19602 Warning be made public too?
19604 * expression.cs: use ea.Location instead of ea.loc.
19605 [FIXME: Filed as bug #28607: MCS must report these errors.]
19607 2002-08-06 Martin Baulig <martin@gnome.org>
19609 * ecore.cs (Expression.loc): Moved the location here instead of
19610 duplicating it in all derived classes.
19611 (Expression.Location): New public property.
19612 (Expression.Error, Expression.Warning): Made them non-static and
19613 removed the location argument.
19614 (Expression.Warning): Added overloaded version which takes an
19615 `int level' argument.
19616 (Expression.Error118): Make this non-static and removed the
19617 expression and location arguments.
19618 (TypeExpr): Added location argument to the constructor.
19620 * expression.cs (StaticCallExpr): Added location argument to
19622 (Indirection, PointerArithmetic): Likewise.
19623 (CheckedExpr, UnCheckedExpr): Likewise.
19624 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
19625 (StringPtr): Likewise.
19628 2002-08-05 Martin Baulig <martin@gnome.org>
19630 * expression.cs (BaseAccess.DoResolve): Actually report errors.
19632 * assign.cs (Assign.DoResolve): Check whether the source
19633 expression is a value or variable.
19635 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
19636 while resolving the corresponding blocks.
19638 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
19639 an error, don't silently return null.
19641 * statement.cs (Block.AddVariable): Do the error reporting here
19642 and distinguish between CS0128 and CS0136.
19643 (Block.DoResolve): Report all unused labels (warning CS0164).
19644 (LabeledStatement): Pass the location to the constructor.
19645 (LabeledStatement.HasBeenReferenced): New property.
19646 (LabeledStatement.Resolve): Set it to true here.
19648 * statement.cs (Return.Emit): Return success even after reporting
19649 a type mismatch error (CS0126 or CS0127), this is what csc does and
19650 it avoids confusing the users with any consecutive errors.
19652 2002-08-05 Martin Baulig <martin@gnome.org>
19654 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
19656 * const.cs (Const.LookupConstantValue): Catch circular definitions.
19658 * expression.cs (MemberAccess.DoResolve): Silently return if an
19659 error has already been reported.
19661 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
19662 error has already been reported.
19664 2002-08-05 Martin Baulig <martin@gnome.org>
19666 * statement.cs (UsageVector): Only initialize the `parameters'
19667 vector if we actually have any "out" parameters.
19669 2002-08-05 Martin Baulig <martin@gnome.org>
19671 * expression.cs (Binary.ResolveOperator): When combining delegates,
19672 they must have the same type.
19674 2002-08-05 Martin Baulig <martin@gnome.org>
19676 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
19677 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
19678 work with the ms runtime and we also don't need it: if we're a
19679 PropertyBuilder and not in the `indexer_arguments' hash, then we
19680 are a property and not an indexer.
19682 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
19683 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
19684 since the latter one doesn't work with the ms runtime.
19686 2002-08-03 Martin Baulig <martin@gnome.org>
19688 Fixed bugs #27998 and #22735.
19690 * class.cs (Method.IsOperator): New public field.
19691 (Method.CheckBase): Report CS0111 if there's already a method
19692 with the same parameters in the current class. Report CS0508 when
19693 attempting to change the return type of an inherited method.
19694 (MethodData.Emit): Report CS0179 if a method doesn't have a body
19695 and it's not marked abstract or extern.
19696 (PropertyBase): New abstract base class for Property and Indexer.
19697 (PropertyBase.CheckBase): Moved here from Property and made it work
19699 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
19700 the same so we can reuse it there.
19701 (Property, Indexer): Derive from PropertyBase.
19702 (MethodSignature.inheritable_property_signature_filter): New delegate
19703 to find properties and indexers.
19705 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
19706 argument and improved error reporting.
19708 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
19709 EmptyReadOnlyParameters and made it a property.
19711 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
19712 version of this method which takes a `PropertyInfo indexer'.
19713 (TypeManager.RegisterIndexer): New method.
19715 * class.cs: Added myself as author of this file :-)
19717 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19719 * class.cs: fixed compilation on windoze.
19721 2002-08-03 Martin Baulig <martin@gnome.org>
19723 * interface.cs (Interface.GetInterfaceBases): Check whether all
19724 base interfaces are at least as accessible than the current one.
19726 * class.cs (TypeContainer.GetClassBases): Check whether base types
19727 are at least as accessible than the current type.
19728 (TypeContainer.AsAccessible): Implemented and made non-static.
19729 (MemberBase.CheckParameters): Report errors if the accessibility
19732 * delegate.cs (Delegate.Delegate): The default visibility is
19733 internal for top-level types and private for nested types.
19734 (Delegate.Define): Report errors if the accessibility checks fail.
19736 * enum.cs (Enum.Enum): The default visibility is internal for
19737 top-level types and private for nested types.
19738 (Enum.DefineType): Compute the correct visibility.
19740 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
19741 function which takes a `bool is_toplevel' instead of a TypeContainer.
19743 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
19746 2002-08-02 Martin Baulig <martin@gnome.org>
19748 * expression.cs (LocalVariableReferenc): Added constructor which
19749 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
19750 (LocalVariableReference.IsReadOnly): New property.
19751 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19752 variable is readonly, use our own readonly flag to do this; you can
19753 use the new constructor to get a writable reference to a read-only
19756 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19757 reference to the local variable.
19759 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19761 * rootcontext.cs (ResolveCore): Also include System.Exception
19763 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19764 we reach an EmptyStatement.
19766 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19769 * expression.cs (Binary.ResolveOperator): Check error result in
19772 use brtrue/brfalse directly and avoid compares to null.
19774 2002-08-02 Martin Baulig <martin@gnome.org>
19776 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19777 Fixes bug #28407, added test-155.cs.
19779 2002-08-01 Martin Baulig <martin@gnome.org>
19781 * class.cs (Event.EmitDefaultMethod): Make this work with static
19782 events. Fixes #28311, added verify-3.cs.
19784 2002-08-01 Martin Baulig <martin@gnome.org>
19786 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19787 `is_disposable' fields.
19788 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19789 `hm.is_disposable' if we're using the collection pattern.
19790 (Foreach.EmitCollectionForeach): Use the correct type for the
19791 enumerator's local variable, only emit the try/finally block if
19792 necessary (fixes #27713).
19794 2002-08-01 Martin Baulig <martin@gnome.org>
19796 * ecore.cs (Expression.report118): Renamed to Error118 and made
19799 * statement.cs (Throw.Resolve): Check whether the expression is of
19800 the correct type (CS0118) and whether the type derives from
19801 System.Exception (CS0155).
19802 (Catch.Resolve): New method. Do the type lookup here and check
19803 whether it derives from System.Exception (CS0155).
19804 (Catch.CatchType, Catch.IsGeneral): New public properties.
19806 * typemanager.cs (TypeManager.exception_type): Added.
19808 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19810 * driver.cs: Updated About function.
19812 2002-07-31 Martin Baulig <martin@gnome.org>
19814 Implemented Control Flow Analysis.
19816 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19817 (EmitContext.CurrentBranching): Added.
19818 (EmitContext.StartFlowBranching): Added.
19819 (EmitContext.EndFlowBranching): Added.
19820 (EmitContext.KillFlowBranching): Added.
19821 (EmitContext.IsVariableAssigned): Added.
19822 (EmitContext.SetVariableAssigned): Added.
19823 (EmitContext.IsParameterAssigned): Added.
19824 (EmitContext.SetParameterAssigned): Added.
19825 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19826 Added control flow analysis stuff here.
19828 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19829 resolve the expression as lvalue.
19830 (LocalVariableReference.DoResolve): Check whether the variable has
19831 already been assigned.
19832 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19833 the parameter as assigned here.
19834 (ParameterReference.DoResolve): Check whether the parameter has already
19836 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19837 expression as lvalue.
19839 * statement.cs (FlowBranching): New class for the flow analysis code.
19840 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19841 (LabeledStatement.IsDefined): New public property.
19842 (LabeledStatement.AddUsageVector): New public method to tell flow
19843 analyis that the label may be reached via a forward jump.
19844 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19846 (VariableInfo.Number): New public field. This is used by flow analysis
19847 to number all locals of a block.
19848 (Block.CountVariables): New public property. This is the number of
19849 local variables in this block (including the locals from all parent
19851 (Block.EmitMeta): Number all the variables.
19853 * statement.cs: Added flow analysis support to all classes.
19855 2002-07-31 Martin Baulig <martin@gnome.org>
19857 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19858 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19859 then use this argument.
19861 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19863 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19864 use this to specify /define options.
19866 2002-07-29 Martin Baulig <martin@gnome.org>
19868 * statement.cs (Fixed): Moved all code that does variable lookups
19869 and resolvings from Emit to Resolve.
19871 * statement.cs (For): Moved all code that does variable lookups
19872 and resolvings from Emit to Resolve.
19874 * statement.cs (Using): Moved all code that does variable lookups
19875 and resolvings from Emit to Resolve.
19877 2002-07-29 Martin Baulig <martin@gnome.org>
19879 * attribute.cs (Attribute.Resolve): Explicitly catch a
19880 System.NullReferenceException when creating the
19881 CustromAttributeBuilder and report a different warning message.
19883 2002-07-29 Martin Baulig <martin@gnome.org>
19885 * support.cs (ParameterData.ParameterName): Added method to
19886 get the name of a parameter.
19888 * typemanager.cs (TypeManager.IsValueType): New public method.
19890 2002-07-29 Martin Baulig <martin@gnome.org>
19892 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19893 is a flag which specifies that it's either ref or out.
19894 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19895 the out parameter to `out Parameter.Modifier mod', also set the
19896 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19898 * support.cs (InternalParameters.ParameterModifier): Distinguish
19899 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19900 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19902 * expression.cs (Argument.GetParameterModifier): Distinguish
19903 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19904 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19906 2002-07-29 Martin Baulig <martin@gnome.org>
19908 * expression.cs (ParameterReference.ParameterReference): Added
19909 `Location loc' argument to the constructor.
19911 * cs-parser.jay: Pass location to ParameterReference.
19913 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19915 * statement.cs (Try): Initialize the location.
19917 * cs-parser.jay: pass location to Try.
19919 * expression.cs (Unary.Reduce): Change the prototype to return
19920 whether a constant fold could be performed or not. The result is
19921 returned in an out parameters. In the case of Indirection and
19922 AddressOf, we want to perform the full tests.
19924 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19926 * statement.cs (Statement.Emit): Flag dead code.
19928 2002-07-27 Andrew Birkett <andy@nobugs.org>
19930 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19932 2002-07-27 Martin Baulig <martin@gnome.org>
19934 * class.cs (MethodData.Define): Put back call to
19935 TypeManager.AddMethod(), accidentally commented this out.
19937 * report.cs (Debug): New public method to print debugging information,
19938 this is `[Conditional ("DEBUG")]'.
19940 2002-07-26 Martin Baulig <martin@gnome.org>
19942 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19943 (switch_statement): Push the current_block to the switch_stack and
19944 pop it again when we're done with the switch.
19945 (switch_section): The new block is a child of the current_block.
19946 Fixes bug #24007, added test-152.cs.
19948 2002-07-27 Martin Baulig <martin@gnome.org>
19950 * expression.cs (Invocation.EmitArguments): When calling a varargs
19951 function with only its fixed arguments, we need to pass an empty
19954 2002-07-27 Martin Baulig <martin@gnome.org>
19956 Mono 0.13 has been released.
19958 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19960 * driver.cs: Rename --resource to --linkres, because that is what
19961 we do currently, we dont support --resource yet.
19963 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19965 2002-07-25 Martin Baulig <martin@gnome.org>
19967 * class.cs (MethodData): New public class. This is a `method builder'
19968 class for a method or one accessor of a Property/Indexer/Event.
19969 (MethodData.GetMethodFlags): Moved here from MemberBase.
19970 (MethodData.ApplyAttributes): Likewise.
19971 (MethodData.ApplyObsoleteAttribute): Likewise.
19972 (MethodData.ApplyConditionalAttribute): Likewise.
19973 (MethodData.ApplyDllImportAttribute): Likewise.
19974 (MethodData.CheckAbstractAndExternal): Likewise.
19975 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19976 (MethodData.Emit): Formerly known as Method.Emit().
19977 (MemberBase): Moved everything which was specific to a single
19978 accessor/method to MethodData.
19979 (Method): Create a new MethodData and call Define() and Emit() on it.
19980 (Property, Indexer, Event): Create a new MethodData objects for each
19981 accessor and call Define() and Emit() on them.
19983 2002-07-25 Martin Baulig <martin@gnome.org>
19985 Made MethodCore derive from MemberBase to reuse the code from there.
19986 MemberBase now also checks for attributes.
19988 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19989 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19991 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19992 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19993 (MemberBase.ApplyAttributes): New virtual method; applies the
19994 attributes to a method or accessor.
19995 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19996 (MemberBase.ApplyConditionalAttribute): Likewise.
19997 (MemberBase.ApplyDllImportAttribute): Likewise.
19998 (MemberBase.CheckAbstractAndExternal): Likewise.
19999 (MethodCore.ParameterTypes): This is now a property instead of a
20000 method, it's initialized from DoDefineParameters().
20001 (MethodCore.ParameterInfo): Removed the set accessor.
20002 (MethodCore.DoDefineParameters): New protected virtual method to
20003 initialize ParameterTypes and ParameterInfo.
20004 (Method.GetReturnType): We can now simply return the MemberType.
20005 (Method.GetMethodFlags): Override the MemberBase version and add
20006 the conditional flags.
20007 (Method.CheckBase): Moved some code from Define() here, call
20008 DoDefineParameters() here.
20009 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
20010 here to avoid some larger code duplication.
20011 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
20012 ensure that abstract and external accessors don't declare a body.
20014 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
20015 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
20016 lookup in the attribute's parent classes, so we need to abort as soon
20017 as we found the first match.
20018 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
20019 the attribute has no arguments.
20021 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
20024 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20026 * cs-parser.jay: reverted previous patch.
20028 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20030 * cs-parser.jay: fixed bug #22119.
20032 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20034 * attribute.cs: fixed compilation. The error was:
20035 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
20036 be assigned to before control leaves the current method."
20037 [FIXME: Filed as bug #28186: MCS must report this error.]
20039 2002-07-25 Martin Baulig <martin@gnome.org>
20041 * attribute.cs (Attribute.Conditional_GetConditionName): New static
20042 method to pull the condition name ouf of a Conditional attribute.
20043 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
20044 the obsolete message and error flag out of an Obsolete attribute.
20046 * class.cs (Method.GetMethodFlags): New public method to get the
20047 TypeManager.MethodFlags for this method.
20048 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
20050 (Method.Define): Get and apply the Obsolete and Conditional attributes;
20051 if we're overriding a virtual function, set the new private variable
20052 `parent_method'; call the new TypeManager.AddMethod().
20054 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
20055 the MethodBuilder and the Method in a PtrHashtable.
20056 (TypeManager.builder_to_method): Added for this purpose.
20057 (TypeManager.MethodFlags): Added IsObsoleteError.
20058 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
20059 Obsolete and Conditional arguments in MethodBuilders. If we discover
20060 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
20061 the message from the attribute.
20063 2002-07-24 Martin Baulig <martin@gnome.org>
20065 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
20066 preprocessor directives, ensure that the argument to #define/#undef is
20067 exactly one identifier and that it's actually an identifier.
20069 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
20072 2002-07-24 Martin Baulig <martin@gnome.org>
20074 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
20075 initialize it to TypeManager.object_type in the constructor.
20076 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
20077 of the `hm.get_current' method if we're using the collection pattern.
20078 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
20079 for the explicit conversion to make it work when we're using the collection
20080 pattern and the `Current' property has a different return type than `object'.
20083 2002-07-24 Martin Baulig <martin@gnome.org>
20085 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
20086 does not match, but don't report any errors. This method is called in
20087 order for all methods in a MethodGroupExpr until a matching method is
20088 found, so we don't want to bail out if the first method doesn't match.
20089 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
20090 matches, report the 123. Fixes #28070.
20092 2002-07-24 Martin Baulig <martin@gnome.org>
20094 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
20095 TypeManager.TypeToCoreType() to the top of the method so the
20096 following equality checks will work. Fixes #28107.
20098 2002-07-24 Martin Baulig <martin@gnome.org>
20100 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
20101 operand is of type uint, and the other operand is of type sbyte,
20102 short or int, the operands are converted to type long." -
20103 Actually do what this comment already told us. Fixes bug #28106,
20106 2002-07-24 Martin Baulig <martin@gnome.org>
20108 * class.cs (MethodBase): New abstract class. This is now a base
20109 class for Property, Indexer and Event to avoid some code duplication
20110 in their Define() and DefineMethods() methods.
20111 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
20112 generic methods for Define() and DefineMethods().
20113 (FieldBase): Derive from MemberBase, not MemberCore.
20114 (Property): Derive from MemberBase, not MemberCore.
20115 (Property.DefineMethod): Moved all the code from this method to the
20116 new MethodBase.DefineAccessor(), just call it with appropriate
20118 (Property.Define): Call the new Property.DoDefine(), this does some
20119 sanity checks and we don't need to duplicate the code everywhere.
20120 (Event): Derive from MemberBase, not MemberCore.
20121 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
20122 accessors, this will also make them work with interface events.
20123 (Indexer): Derive from MemberBase, not MemberCore.
20124 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
20125 (Indexer.Define): Use the new MethodBase functions.
20127 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
20128 argument to the constructor.
20129 (Interface.FindMembers): Added support for interface events.
20130 (Interface.PopluateEvent): Implemented.
20132 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
20134 2002-07-22 Miguel de Icaza <miguel@ximian.com>
20136 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
20137 but this is required to check for a method name being the same as
20138 the containing class.
20142 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20144 * interface.cs: initialize variable.
20146 2002-07-23 Martin Baulig <martin@gnome.org>
20148 Implemented the IndexerName attribute in interfaces.
20150 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
20151 name if this is an explicit interface implementation.
20152 (Indexer.InterfaceIndexerName): New public variable. If we're
20153 implementing an interface indexer, this is the IndexerName in that
20154 interface. Otherwise, it's the IndexerName.
20155 (Indexer.DefineMethod): If we're implementing interface indexer,
20156 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
20157 and Pending.ImplementIndexer methods.
20158 (Indexer.Define): Also define the PropertyBuilder if we're
20159 implementing an interface indexer and this is neither an explicit
20160 interface implementation nor do the IndexerName match the one in
20163 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
20164 If a method is defined here, then we always need to create a proxy
20165 for it. This is used when implementing interface indexers.
20166 (Pending.IsInterfaceIndexer): New public method.
20167 (Pending.ImplementIndexer): New public method.
20168 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
20169 This is used when implementing interface indexers to define a proxy
20171 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
20172 define a proxy if necessary.
20174 * interface.cs (Interface.IndexerName): New public variable.
20175 (Interface.PopulateIndexer): Set the IndexerName.
20176 (Interface.DefineIndexers): New private method. Populate all the
20177 indexers and make sure their IndexerNames match.
20179 * typemanager.cs (IndexerPropertyName): Added support for interface
20182 2002-07-22 Martin Baulig <martin@gnome.org>
20184 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
20185 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
20186 ret if HasReturnLabel.
20187 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
20190 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
20191 and set the ec.LoopBeginTryCatchLevel.
20192 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
20193 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
20194 the current ec.TryCatchLevel, the branch goes out of an exception
20195 block. In this case, we need to use Leave and not Br.
20197 2002-07-22 Martin Baulig <martin@gnome.org>
20199 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
20200 block unless the block does not always return or it is contained in
20201 another try { ... } catch { ... } block. Fixes bug #26506.
20202 Added verify-1.cs to the test suite.
20204 2002-07-22 Martin Baulig <martin@gnome.org>
20206 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
20207 then we do not always return. Fixes bug #24985.
20209 2002-07-22 Martin Baulig <martin@gnome.org>
20211 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
20212 lookup on a per-class level; ie. walk up the class hierarchy until we
20213 found at least one applicable method, then choose the best among them.
20214 Fixes bug #24463 and test-29.cs.
20216 2002-07-22 Martin Baulig <martin@gnome.org>
20218 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
20219 return types of the methods. The return type is not part of the
20220 signature and we must not check it to make the `new' modifier work.
20221 Fixes bug #27999, also added test-147.cs.
20222 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
20224 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
20225 on the method's return type.
20227 2002-07-21 Martin Baulig <martin@gnome.org>
20229 * assign.cs: Make this work if the rightmost source is a constant and
20230 we need to do an implicit type conversion. Also adding a few more tests
20231 to test-38.cs which should have caught this.
20233 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
20234 target in the makefile for this. The makefile.gnu is primarily intended
20235 for end-users who don't want to debug the compiler.
20237 2002-07-21 Martin Baulig <martin@gnome.org>
20239 * assign.cs: Improved the Assign class so it can now handle embedded
20240 assignments (X = Y = Z = something). As a side-effect this'll now also
20241 consume less local variables. test-38.cs now passes with MCS, added
20242 a few new test cases to that test.
20244 2002-07-20 Martin Baulig <martin@gnome.org>
20246 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
20247 instructions. Fixes bug #27977, also added test-146.cs.
20249 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20251 * cs-tokenizer.cs: fixed getHex ().
20253 2002-07-19 Martin Baulig <martin@gnome.org>
20255 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
20256 not Type.GetType() to lookup the array type. This is needed when
20257 we're constructing an array of a user-defined type.
20258 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
20259 single-dimensional arrays, but also for single-dimensial arrays of
20262 2002-07-19 Martin Baulig <martin@gnome.org>
20264 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
20265 this function is called, it's not allowed to share LocalBuilders
20266 among ILGenerators.
20268 2002-07-19 Martin Baulig <martin@gnome.org>
20270 * expression.cs (Argument.Resolve): Report an error 118 when trying
20271 to pass a type as argument.
20273 2002-07-18 Martin Baulig <martin@gnome.org>
20275 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
20276 Conv_R_Un for the signed `long' type.
20278 2002-07-15 Miguel de Icaza <miguel@ximian.com>
20280 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
20281 `expr' for the temporary result, as that will fail if we do
20282 multiple resolves on the same expression.
20284 2002-07-05 Miguel de Icaza <miguel@ximian.com>
20286 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
20287 ec.TypeContainer for looking up aliases.
20289 * class.cs (TypeContainer): Remove LookupAlias from here.
20291 * decl.cs (DeclSpace); Move here.
20293 2002-07-01 Miguel de Icaza <miguel@ximian.com>
20295 * class.cs (FindMembers): Only call filter if the constructor
20296 bulider is not null.
20298 Also handle delegates in `NestedTypes' now. Now we will perform
20299 type lookups using the standard resolution process. This also
20302 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
20303 This uses Expressions (the limited kind that can be parsed by the
20304 tree) instead of strings.
20306 * expression.cs (ComposedCast.ToString): Implement, used to flag
20307 errors since now we have to render expressions.
20309 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
20312 * ecore.cs (SimpleName.ToString): ditto.
20314 * cs-parser.jay: Instead of using strings to assemble types, use
20315 Expressions to assemble the type (using SimpleName, ComposedCast,
20316 MemberAccess). This should fix the type lookups in declarations,
20317 because we were using a different code path for this.
20319 * statement.cs (Block.Resolve): Continue processing statements
20320 even when there is an error.
20322 2002-07-17 Miguel de Icaza <miguel@ximian.com>
20324 * class.cs (Event.Define): Also remove the `remove' method from
20325 the list of pending items.
20327 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
20328 generate more compact code.
20330 2002-07-17 Martin Baulig <martin@gnome.org>
20332 * const.cs (Const.LookupConstantValue): Add support for constant
20333 `unchecked' and `checked' expressions.
20334 Also adding test case test-140.cs for this.
20336 2002-07-17 Martin Baulig <martin@gnome.org>
20338 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
20339 check whether mi.ReturnType implements the IEnumerator interface; the
20340 `==' and the IsAssignableFrom() will fail in this situation.
20342 2002-07-16 Ravi Pratap <ravi@ximian.com>
20344 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
20347 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20349 * expression.cs: fixed bug #27811.
20351 2002-07-14 Miguel de Icaza <miguel@ximian.com>
20353 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
20354 Molaro: when we are a ref, the value already contains a pointer
20355 value, do not take the address of it.
20357 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20358 * removed mb-parser.jay and mb-tokenizer.cs
20360 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20362 * expression.cs: check against the building corlib void type.
20364 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
20366 * ecore.cs: fix for valuetype static readonly fields: when
20367 initializing them, we need their address, not the address of a copy.
20369 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
20371 * typemanager.cs: register also enum_type in corlib.
20373 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20375 * class.cs: allow calling this (but not base) initializers in structs.
20377 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
20379 * ecore.cs: make sure we compare against the building base types
20382 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
20384 * typemanager.cs: fix TypeToCoreType() to handle void and object
20385 (corlib gets no more typerefs after this change).
20387 2002-07-12 Miguel de Icaza <miguel@ximian.com>
20389 * expression.cs (ArrayCreation.EmitArrayArguments): use
20390 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
20392 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
20393 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
20394 array indexes, the runtime actually forbids them.
20396 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
20397 for array arguments here.
20399 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
20400 instead of the default for ValueTypes.
20402 (New.DoEmit): Use IsValueType instead of
20403 IsSubclassOf (value_type)
20404 (New.DoResolve): ditto.
20405 (Invocation.EmitCall): ditto.
20407 * assign.cs (Assign): ditto.
20409 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
20410 Statements *are* currently doing part of their resolution during
20413 Expressions do always resolve during resolve, but statements are
20414 only required to propagate resolution to their children.
20416 2002-07-11 Miguel de Icaza <miguel@ximian.com>
20418 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
20420 (LoadAssembly): Do not add the dll if it is already specified
20422 (MainDriver): Add the System directory to the link path at the end,
20423 after all the other -L arguments.
20425 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
20426 wrong opcode for loading bytes and bools (ldelem.i1 instead of
20427 ldelem.u1) and using the opposite for sbytes.
20429 This fixes Digger, and we can finally run it.
20431 * driver.cs (UnixParseOption): Move the option parsing here.
20432 (CSCParseOption): Implement CSC-like parsing of options.
20434 We now support both modes of operation, the old Unix way, and the
20435 new CSC-like way. This should help those who wanted to make cross
20436 platform makefiles.
20438 The only thing broken is that /r:, /reference: and /lib: are not
20439 implemented, because I want to make those have the same semantics
20440 as the CSC compiler has, and kill once and for all the confussion
20441 around this. Will be doing this tomorrow.
20443 * statement.cs (Unsafe.Resolve): The state is checked during
20444 resolve, not emit, so we have to set the flags for IsUnsfe here.
20446 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20448 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
20449 not catch the Error_ObjectRefRequired in SimpleName (as it is
20450 possible to have a class/instance variable name that later gets
20451 deambiguated), we have to check this here.
20453 2002-07-10 Ravi Pratap <ravi@ximian.com>
20455 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
20456 make static and put into Expression.
20458 (Event.Define): Register the private field of the event with the
20459 TypeManager so that GetFieldFromEvent can get at it.
20461 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
20462 keep track of the private field associated with an event which
20465 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
20468 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
20470 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20472 * expression.cs (Binary.EmitBranchable): this routine emits the
20473 Binary expression in a branchable context. This basically means:
20474 we need to branch somewhere, not just get the value on the stack.
20476 This works together with Statement.EmitBoolExpression.
20478 * statement.cs (Statement.EmitBoolExpression): Use
20481 2002-07-09 Miguel de Icaza <miguel@ximian.com>
20483 * statement.cs (For): Reduce the number of jumps in loops.
20485 (For): Implement loop inversion for the For statement.
20487 (Break): We can be breaking out of a Try/Catch controlled section
20488 (foreach might have an implicit try/catch clause), so we need to
20489 use Leave instead of Br.
20491 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
20492 now). If the instace expression supports IMemoryLocation, we use
20493 the AddressOf method from the IMemoryLocation to extract the
20494 address instead of emitting the instance.
20496 This showed up with `This', as we were emitting the instance
20497 always (Emit) instead of the Address of This. Particularly
20498 interesting when This is a value type, as we dont want the Emit
20499 effect (which was to load the object).
20501 2002-07-08 Miguel de Icaza <miguel@ximian.com>
20503 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
20505 * statement.cs (Checked): Set the CheckedState during the resolve
20506 process too, as the ConvCast operations track the checked state on
20507 the resolve process, and not emit.
20509 * cs-parser.jay (namespace_member_declaration): Flag that we have
20510 found a declaration when we do. This is used to flag error 1529
20512 * driver.cs: Report ok when we display the help only.
20514 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
20516 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
20518 2002-07-04 Miguel de Icaza <miguel@ximian.com>
20520 * cs-tokenizer.cs (define): We also have to track locally the
20521 defines. AllDefines is just used for the Conditional Attribute,
20522 but we also need the local defines for the current source code.
20524 2002-07-03 Miguel de Icaza <miguel@ximian.com>
20526 * statement.cs (While, For, Do): These loops can exit through a
20527 Break statement, use this information to tell whether the
20528 statement is the last piece of code.
20530 (Break): Flag that we break.
20532 * codegen.cs (EmitContexts): New `Breaks' state variable.
20534 2002-07-03 Martin Baulig <martin@gnome.org>
20536 * class.cs (TypeContainer.MethodModifiersValid): Allow override
20537 modifiers in method declarations in structs. Otherwise, you won't
20538 be able to override things like Object.Equals().
20540 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20542 * class.cs (Method, Property, Indexer): Do not allow the public
20543 modifier to be used in explicit interface implementations.
20545 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
20546 override modifiers in method declarations in structs
20548 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
20550 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
20551 integer or real overflow, report an error
20553 2002-07-02 Martin Baulig <martin@gnome.org>
20555 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
20556 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
20557 to tell the runtime about our newly created System.Object and
20558 System.ValueType types.
20560 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20562 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
20563 struct instead of Ldarg/Starg.
20565 2002-07-02 Martin Baulig <martin@gnome.org>
20567 * expression.cs (Indirection.Indirection): Call
20568 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
20570 2002-07-02 Martin Baulig <martin@gnome.org>
20572 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
20573 ValueType, call TypeManager.TypeToCoreType() on it.
20574 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
20575 the OpCodes.Newarr argument.
20577 2002-07-02 Martin Baulig <martin@gnome.org>
20579 * expression.cs (Invocation.EmitCall): When compiling corlib,
20580 replace all calls to the system's System.Array type to calls to
20581 the newly created one.
20583 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
20584 System.Array methods.
20585 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
20586 from the system's System.Array type which must be replaced.
20588 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
20590 * typemanager.cs: load unverifiable_code_ctor so we can build
20591 corlib using the correct type. Avoid using GetTypeCode() with
20593 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
20594 TypeManager.object_type to allow building corlib.
20596 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
20598 * ecore.cs: handle System.Enum separately in LoadFromPtr().
20600 2002-07-01 Martin Baulig <martin@gnome.org>
20602 * class.cs: Make the last change actually work, we need to check
20603 whether `ifaces != null' to avoid a crash.
20605 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20607 * class.cs: when we build structs without fields that implement
20608 interfaces, we need to add the interfaces separately, since there is
20609 no API to both set the size and add the interfaces at type creation
20612 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20614 * expression.cs: the dimension arguments to the array constructors
20615 need to be converted if they are a long.
20617 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
20619 * class.cs: don't emit ldarg.0 if there is no parent constructor
20620 (fixes showstopper for corlib).
20622 2002-06-29 Martin Baulig <martin@gnome.org>
20624 MCS now compiles corlib on GNU/Linux :-)
20626 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
20627 ie. check for MethodImplOptions.InternalCall.
20629 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
20630 and TypeManager.attribute_type are null, so we must explicitly check
20631 whether parent is not null to find out whether it's an attribute type.
20632 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
20633 and SetBuilder, not only if the property is neither abstract nor external.
20634 This is necessary to set the MethodImplOptions on the accessor methods.
20635 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
20636 SetBuilder, see Property.Emit().
20638 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
20639 populate "System.Object", "System.ValueType" and "System.Attribute" since
20640 they've already been populated from BootCorlib_PopulateCoreTypes().
20642 2002-06-29 Martin Baulig <martin@gnome.org>
20644 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
20645 is the NullLiteral, we also need to make sure that target_type is not
20648 2002-06-29 Martin Baulig <martin@gnome.org>
20650 * rootcontext.cs (RootContext.ResolveCore): We must initialize
20651 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
20652 before calling BootstrapCorlib_ResolveDelegate ().
20654 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20656 * statement.cs: fixed build-breaker. All tests passed ok.
20658 2002-06-27 Martin Baulig <martin@gnome.org>
20660 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
20661 for System.Decimal when compiling corlib.
20663 2002-06-27 Martin Baulig <martin@gnome.org>
20665 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
20666 switch blocks which contain nothing but a default clause.
20668 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
20670 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
20672 2002-06-27 Martin Baulig <martin@gnome.org>
20674 * ecore.cs (PropertyExpr.PropertyExpr): Call
20675 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
20677 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
20678 is already a TypeBuilder.
20680 2002-06-27 Martin Baulig <martin@gnome.org>
20682 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
20683 `target_type == TypeManager.array_type', not IsAssignableFrom() in
20684 the "from an array-type to System.Array" case. This makes it work
20685 when compiling corlib.
20687 2002-06-27 Martin Baulig <martin@gnome.org>
20689 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
20690 non-static PropertyExpr, set its InstanceExpression. This makes
20691 the `ICollection.Count' property work in System/Array.cs.
20693 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
20695 * driver.cs: Made error handling more consistent. Errors now
20696 tracked by Report class, so many methods which used to return int
20697 now return void. Main() now prints success/failure and
20698 errors/warnings message.
20700 Renamed '--probe' compiler argument to '--expect-error'. Removed
20701 the magic number return values (123 and 124). Now, if the
20702 expected error occurs, the compiler exits with success (exit value
20703 0). If the compilation completes without seeing that particular
20704 error, the compiler exits with failure (exit value 1). The
20705 makefile in mcs/errors has been changed to handle the new behaviour.
20707 * report.cs: Made 'expected error' number a property and renamed
20708 it from 'Probe' to 'ExpectedError'.
20710 * genericparser.cs: Removed error handling support, since it is
20711 now all done by Report class.
20713 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
20714 class, so parse() no longer returns an int.
20716 * namespace.cs: Use Report.Error instead of GenericParser.error
20718 2002-06-22 Miguel de Icaza <miguel@ximian.com>
20720 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
20721 TypeContainer.AddOperator): At the front of the list put the
20722 explicit implementations, so they get resolved/defined first.
20724 2002-06-21 Miguel de Icaza <miguel@ximian.com>
20726 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
20727 interface type is implemented by this TypeContainer. Used during
20728 explicit interface implementation.
20730 (Property.Define, Indexer.Define, Method.Define): Validate that
20731 the given interface in the explicit implementation is one of the
20732 base classes for the containing type.
20734 Also if we are explicitly implementing an interface, but there is
20735 no match in the pending implementation table, report an error.
20737 (Property.Define): Only define the property if we are
20738 not explicitly implementing a property from an interface. Use the
20739 correct name also for those properties (the same CSC uses,
20740 although that is really not needed).
20742 (Property.Emit): Do not emit attributes for explicitly implemented
20743 properties, as there is no TypeBuilder.
20745 (Indexer.Emit): ditto.
20747 Hiding then means that we do not really *implement* a pending
20748 implementation, which makes code fail.
20750 2002-06-22 Martin Baulig <martin@gnome.org>
20752 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20753 the return value of Object.GetType(). [FIXME: we need to do this whenever
20754 we get a type back from the reflection library].
20756 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20758 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20760 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20762 * attribute.cs: Return null if we can not look up the type.
20764 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20765 the interface types found.
20767 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20768 interface types found.
20770 * typemanager.cs (GetInterfaces): Make this routine returns alll
20771 the interfaces and work around the lame differences between
20772 System.Type and System.Reflection.Emit.TypeBuilder in the results
20773 result for GetInterfaces.
20775 (ExpandInterfaces): Given an array of interface types, expand and
20776 eliminate repeated ocurrences of an interface. This expands in
20777 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20780 2002-06-21 Martin Baulig <martin@gnome.org>
20782 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20785 2002-06-21 Martin Baulig <martin@gnome.org>
20787 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20788 and called with one of the core types, return the corresponding typebuilder for
20791 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20794 2002-06-21 Martin Baulig <martin@gnome.org>
20796 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20797 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20798 (Expression.ConvertReferenceExplicit): Likewise.
20800 * expression.cs (ElementAccess.DoResolve): Likewise.
20801 (ElementAccess.DoResolveLValue): Likewise.
20803 2002-06-10 Martin Baulig <martin@gnome.org>
20805 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20806 add the "value" parameter to the parameter list.
20808 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20811 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20813 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20814 the argument to an int, uint, long or ulong, per the spec. Also
20815 catch negative constants in array creation.
20817 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20819 * class.cs: do not allow the same interface to appear twice in
20820 the definition list.
20822 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20824 * ecore.cs: don't use ldlen with System.Array.
20826 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20828 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20830 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20832 * modifiers.cs: produce correct field attributes for protected
20833 internal. Easy fix so miguel can work on ther harder stuff:-)
20835 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20837 * pending.cs: New file. Move the code from class.cs here.
20838 Support clearning the pending flag for all methods (when not doing
20839 explicit interface implementation).
20841 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20843 * rootcontext.cs: added a couple more types needed to bootstrap.
20845 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20847 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20848 constructor in the type, instead of any constructor in the type
20849 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20850 a bug in the Mono runtime when applying the params attribute).
20852 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20853 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20855 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20857 * expression.cs (Unary.ResolveOperator): Use TypeManager
20858 to resolve the type.
20860 2002-06-13 Ravi Pratap <ravi@ximian.com>
20862 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20865 * enum.cs (AddEnumMember): Add support to store the attributes associated
20866 with each member too.
20868 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20869 field builders too - this takes care of the enum member case.
20871 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20873 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20874 address-of operator on both value types and pointers.
20876 2002-06-10 Martin Baulig <martin@gnome.org>
20878 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20879 PropertyBuilder to the `property_builders' list.
20881 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20882 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20883 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20884 find any indexers which are inherited from an interface.
20886 2002-06-09 Martin Baulig <martin@gnome.org>
20888 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20889 the same type as the constant if necessary. There's also a test-130.cs
20892 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20894 * typemanager.cs (TypeManager.ChangeType): Previously known as
20895 Enum.ChangeEnumType().
20897 2002-06-09 Martin Baulig <martin@gnome.org>
20899 * expression.cs (Cast.TryReduce): Added support for consts.
20901 2002-06-08 Ravi Pratap <ravi@ximian.com>
20903 * class.cs (Accessor): Hold attributes information so we can pass
20906 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20907 Modify to pass in attributes attached to the methods.
20909 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20911 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20912 to handle the Accessor kind :-)
20914 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20916 2002-06-08 Martin Baulig <martin@gnome.org>
20918 * expression.cs (Unary.TryReduceNegative): Added support for
20921 2002-06-08 Martin Baulig <martin@gnome.org>
20923 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20924 name can't be found in the `defined_names' - the caller will do a
20925 MemberLookup in this case and thus find methods in System.Enum
20926 such as Enum.IsDefined().
20928 2002-06-08 Martin Baulig <martin@gnome.org>
20930 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20931 Convert.ChangeType() which works with TypeBuilder created types.
20932 (Enum.LookupEnumValue, Enum.Define): Use it here.
20934 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20935 `TypeBuilder.BaseType != null' check.
20936 (TypeContainer.FindMembers): Only lookup parent members if we
20937 actually have a parent.
20938 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20939 (ConstructorInitializer.Resolve): Likewise.
20941 * interface.cs (Interface.FindMembers): Added
20942 `TypeBuilder.BaseType != null' check.
20944 * rootcontext.cs (RootContext.ResolveCore): Added
20945 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20946 classes_second_stage.
20948 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20949 debug_type and trace_type when compiling with --nostdlib.
20951 2002-06-07 Martin Baulig <martin@gnome.org>
20953 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20954 (AddField): Set it to true when adding a non-static field.
20955 (DefineType): Use `have_nonstatic_fields' to find out whether we
20956 have non-static fields, not `Fields != null'.
20958 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20960 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20961 dereferencing a null on the static-field code path)
20963 2002-05-30 Martin Baulig <martin@gnome.org>
20965 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20966 to take command line arguments. Use reflection to call the new
20967 custom `Initialize' function on the symbol writer and pass it the
20968 command line arguments.
20970 * driver.cs (--debug-args): New command line argument to pass command
20971 line arguments to the symbol writer.
20973 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20975 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20976 the target type for indexers and properties. Thanks to Joe for
20979 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20981 * typemanager.cs (MethodFlags): returns the method flags
20982 (Obsolete/ShouldIgnore) that control warning emission and whether
20983 the invocation should be made, or ignored.
20985 * expression.cs (Invocation.Emit): Remove previous hack, we should
20986 not do this on matching a base type, we should do this based on an attribute
20988 Only emit calls to System.Diagnostics.Debug and
20989 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20990 on the command line.
20992 * rootcontext.cs: Global settings for tracing and debugging.
20994 * cs-tokenizer.cs (define): New utility function to track
20995 defines. Set the global settings for TRACE and DEBUG if found.
20997 2002-05-25 Ravi Pratap <ravi@ximian.com>
20999 * interface.cs (Populate*): Pass in the TypeContainer as well as
21000 the DeclSpace as parameters so that we can create EmitContexts and
21001 then use that to apply attributes etc.
21003 (PopulateMethod, PopulateEvent, PopulateProperty)
21004 (PopulateIndexer): Apply attributes everywhere.
21006 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
21009 (ApplyAttributes): Update accordingly.
21011 We now apply interface attributes for all members too.
21013 2002-05-26 Miguel de Icaza <miguel@ximian.com>
21015 * class.cs (Indexer.Define); Correctly check if we are explicit
21016 implementation (instead of checking the Name for a ".", we
21017 directly look up if the InterfaceType was specified).
21019 Delay the creation of the PropertyBuilder.
21021 Only create the PropertyBuilder if we are not an explicit
21022 interface implementation. This means that explicit interface
21023 implementation members do not participate in regular function
21024 lookups, and hence fixes another major ambiguity problem in
21025 overload resolution (that was the visible effect).
21027 (DefineMethod): Return whether we are doing an interface
21030 * typemanager.cs: Temporary hack until we get attributes in
21031 interfaces (Ravi is working on that) and we get IndexerName
21032 support in interfaces.
21034 * interface.cs: Register the indexers as properties.
21036 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
21037 warning, I have verified that this is a bug in the .NET runtime
21038 (JavaScript suffers of the same problem).
21040 * typemanager.cs (MemberLookup): When looking up members for
21041 interfaces, the parent of an interface is the implicit
21042 System.Object (so we succeed in searches of Object methods in an
21043 interface method invocation. Example: IEnumerable x; x.ToString
21046 2002-05-25 Miguel de Icaza <miguel@ximian.com>
21048 * class.cs (Event): Events should also register if they do
21049 implement the methods that an interface requires.
21051 * typemanager.cs (MemberLookup); use the new GetInterfaces
21054 (GetInterfaces): The code used to lookup interfaces for a type is
21055 used in more than one place, factor it here.
21057 * driver.cs: Track the errors at the bottom of the file, we kept
21060 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
21061 instance if the method we are calling is static!
21063 2002-05-24 Miguel de Icaza <miguel@ximian.com>
21065 * attribute.cs (ApplyAttributes): Make this function filter out
21066 the IndexerName attribute (as that attribute in reality is never
21067 applied) and return the string constant for the IndexerName
21070 * class.cs (TypeContainer.Emit): Validate that all the indexers
21071 have the same IndexerName attribute, and if so, set the
21072 DefaultName attribute on the class.
21074 * typemanager.cs: The return value might contain other stuff (not
21075 only methods). For instance, consider a method with an "Item"
21076 property and an Item method.
21078 * class.cs: If there is a problem with the parameter types,
21081 2002-05-24 Ravi Pratap <ravi@ximian.com>
21083 * ecore.cs (ImplicitConversionExists): Wrapper function which also
21084 looks at user defined conversion after making a call to
21085 StandardConversionExists - we need this for overload resolution.
21087 * expression.cs : Update accordingly the various method calls.
21089 This fixes 2 bugs filed against implicit user defined conversions
21091 2002-05-22 Miguel de Icaza <miguel@ximian.com>
21093 * statement.cs: Track the result of the assignment.
21095 2002-05-21 Miguel de Icaza <miguel@ximian.com>
21097 * expression.cs (MemberAccess): Improved error reporting for
21098 inaccessible members.
21100 2002-05-22 Martin Baulig <martin@gnome.org>
21102 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
21103 itself with debugging support.
21105 2002-05-22 Martin Baulig <martin@gnome.org>
21107 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
21108 Removed, this isn't needed anymore.
21110 2002-05-20 Martin Baulig <martin@gnome.org>
21112 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
21113 be underlying type for an enum.
21115 2002-05-20 Miguel de Icaza <miguel@ximian.com>
21117 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
21118 that splits out the loading of just the core types.
21120 * rootcontext.cs (ResolveCore): Split the struct resolution in
21121 two, so we can load the enumeration underlying types before any
21124 * expression.cs (Is): Bandaid until we fix properly Switch (see
21125 bug #24985 for details).
21127 * typemanager.cs (ImplementsInterface): The hashtable will contain
21128 a null if there are no interfaces implemented.
21130 2002-05-18 Miguel de Icaza <miguel@ximian.com>
21132 * cs-parser.jay (indexer_declarator): It is fine to have array
21135 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21137 * typemanager.cs: (RegisterBuilder): New function used to register
21138 TypeBuilders that implement interfaces. Since
21139 TypeBuilder.GetInterfaces (as usual) does not work with lame
21141 (AddUserType): register interfaces.
21143 (ImplementsInterface): Use the builder_to_ifaces hash if we are
21144 dealing with TypeBuilder. Also, arrays are showing up as
21145 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
21146 methods can not be invoked on them!
21148 * ecore.cs (ExplicitReferenceConversionExists): Made public.
21149 (ImplicitReferenceConversionExists): Split out from
21150 StandardConversionExists.
21152 * expression.cs (As): We were only implementing one of the three
21153 cases for the as operator. We now implement them all.
21154 (Is): Implement the various other cases for Is as well.
21156 * typemanager.cs (CACHE): New define used to control if we want or
21157 not the FindMembers cache. Seems to have a negative impact on
21158 performance currently
21160 (MemberLookup): Nested types have full acess to
21161 enclosing type members
21163 Remove code that coped with instance/static returns for events, we
21164 now catch this in RealFindMembers.
21166 (RealFindMembers): only perform static lookup if the instance
21167 lookup did not return a type or an event.
21169 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21171 * assign.cs (CompoundAssign): We pass more semantic information
21172 now to Compound Assignments than we did before: now we have all
21173 the information at hand, and now we resolve the target *before* we
21174 do the expression expansion, which allows the "CacheValue" method
21175 to have the effect we intended (before, a [x] += 1 would generate
21176 two differen ArrayAccess expressions from the ElementAccess,
21177 during the resolution process).
21179 (CompoundAssign.DoResolve): Resolve target and original_source here.
21181 2002-05-16 Miguel de Icaza <miguel@ximian.com>
21183 * expression.cs (ArrayAccess): dropped debugging information.
21185 * typemanager.cs: Small bug fix: I was always returning i_members,
21186 instead of one of i_members or s_members (depending on which had
21189 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
21190 method is invoked before any code generation takes place, and it
21191 is a mechanism to inform that the expression will be invoked more
21192 than once, and that the method should use temporary values to
21193 avoid having side effects
21195 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
21197 * ecore.cs (Expression.CacheTemporaries): Provide empty default
21200 * expression.cs (Indirection, ArrayAccess): Add support for
21201 CacheTemporaries in these two bad boys.
21203 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
21204 ldobj or ldind_ref.
21205 (StoreFromPtr): Handle stobj as well.
21207 * expression.cs (UnaryMutator): Share more code.
21209 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
21210 down: I was not tracking the Filter function as well, which
21211 was affecting the results of the cache.
21213 2002-05-15 Miguel de Icaza <miguel@ximian.com>
21215 * attribute.cs: Remove the hack to handle the CharSet property on
21218 2002-05-14 Miguel de Icaza <miguel@ximian.com>
21220 * attribute.cs (DoResolve): More uglyness, we now only try to
21221 resolve the attribute partially, to extract the CharSet
21222 information (only if we are a StructLayout attribute). Otherwise
21224 (GetExtraTypeInfo): Add some code to conditionally kill in the
21225 future this. I am more and more convinced that the .NET
21226 framework has special code to handle the attribute setting on
21229 * expression.cs (IsParamsMethodApplicable): Revert my previous
21230 foreach change here, it was wrong.
21232 2002-05-13 Miguel de Icaza <miguel@ximian.com>
21234 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
21235 (pp_expr): do not abort on unknown input, just return.
21236 (eval): abort if there are pending chars.
21238 * attribute.cs (Attribute.Resolve): Positional parameters are
21239 optional. Deal with that case.
21241 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
21242 the Ansi/Unicode/Auto information for the type.
21244 (TypeContainer.DefineType): instantiate the EmitContext here, as
21245 we will be using it during the type definition (to resolve
21246 attributes) and during the emit phase.
21248 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
21249 to pull type information out of the attributes
21251 (Attribute.Resolve): track the constructor builder, and allow for
21252 multiple invocations (structs and classes will use this).
21254 * ecore.cs (MemberLookupFinal): new version with all the
21255 parameters customizable.
21257 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
21258 constructors. Return if the result value is null (as the error
21259 would have been flagged already by MemberLookupFinal)
21261 Do not allow instances of abstract classes or interfaces to be
21264 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
21265 We have to compare the assembly property here when dealing with
21266 FamANDAssem and Assembly access modifiers, because we might be
21267 creating an assembly from *modules* (that means that we are not
21268 getting TypeBuilders for types defined in other modules that are
21269 part of this assembly).
21271 (Method.Emit): If the method is marked abstract and has a body,
21274 (TypeContainer.DefineMembers): If both the defined member and the
21275 parent name match are methods, then do not emit any warnings: let
21276 the Method.Define routine take care of flagging warnings. But if
21277 there is a mismatch (method overrides something else, or method is
21278 overriwritten by something, then emit warning).
21280 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
21281 set to null, this means `do not check for the return type on the
21284 (Method.Define): set the return type for the method signature to
21285 null, so that we get methods with the same name and parameters and
21286 different return types. This is used to flag warning 114 (you are
21287 hiding a method, and you probably want to use the new/override
21290 * typemanager.cs (MemberLookup): Implemented proper access
21291 control, closing a long standing set of bug reports. The problem
21292 was that the Framework only has two bits: Public and NonPublic,
21293 and NonPublic includes private and protected methods, but we need
21294 to enforce the FamANDAssem, FamOrAssem and Family.
21296 2002-05-11 Miguel de Icaza <miguel@ximian.com>
21298 * statement.cs (GotoCase): Return true: Ammounts to giving up
21299 knowledge on whether we return or not, and letting the other case
21300 be responsible for it.
21302 2002-05-10 Miguel de Icaza <miguel@ximian.com>
21304 * driver.cs: Do not load directories for each file processed, only
21305 do it if there is a pattern.
21307 * ecore.cs: Report readonly assigns here as well, as we might have
21308 been resolved only by MemberAccess.
21310 (SimpleName.SimpleNameResolve): Also be useful for LValue
21311 resolution. We need this to propagate assign to local readonly variables
21313 * typemanager.cs: Use a ptrhashtable for the criteria, because we
21314 do not want to reuse potential criteria memory.
21316 * class.cs (MyEventBuilder): Set reflected_type;
21318 * ecore.cs (Constantify): Added support for constifying bools.
21320 (RootContext.LookupType): Added a cache for values looked up in
21321 the declaration space.
21323 * typemanager.cs (FindMembers): Now is a front-end to
21324 RealFindMembers, and provides a two-level hashtable-based cache to
21327 15% performance improvement: from 22.5 to 19.2 seconds.
21329 * expression.cs (IsParamsMethodApplicable): use foreach.
21330 (Invocation.DoResolve): ditto.
21331 (New.DoResolve): ditto.
21332 (ArrayCreation.DoResolve): ditto.
21334 * ecore.cs (FindMostEncompassingType): use foreach.
21336 * delegate.cs (NewDelegate.DoResolve): Use foreach
21338 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
21339 (RemoveMethods): use foreach.
21341 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
21342 nested foreach statements instead of for, and also break out of
21343 the inner loop once a match is found.
21345 (Invocation.OverloadResolve): Use foreach, simplify the code.
21347 2002-05-08 Miguel de Icaza <miguel@ximian.com>
21349 * cfold.cs (BinaryFold): During an enumeration evaluation context,
21350 we actually unwrap the expression to allow for extra information
21353 * expression.cs: Use Shr_Un on unsigned operations.
21355 2002-05-08 Ravi Pratap <ravi@ximian.com>
21357 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
21358 applicable operators was not being considered correctly. This closes
21359 the bug Miguel reported.
21361 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
21363 * attribute.cs: check that the type derives from System.Attribute
21364 and report the correct error in that case (moved the duplicate code to
21365 its own method, too).
21367 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
21369 * attribute.cs: lookup attribute type name as the spec says: first the
21370 bare attribute name and then name + "Attribute" (nant compiles with
21371 mcs after this fix).
21373 2002-05-07 Miguel de Icaza <miguel@ximian.com>
21375 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
21376 Because of the way we parse things, we should try to see if a
21377 UIntConstant can fit in an integer.
21379 2002-05-07 Ravi Pratap <ravi@ximian.com>
21381 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
21382 when we are in an explicit context.
21384 (ConvertReferenceExplicit): When converting from Iface type S to Class
21385 T make sure the rules are implemented as an OR.
21387 * parameter.cs (ParameterType): Make it a property for now although the
21388 purpose really isn't anything immediate.
21390 * expression.cs (Is*Applicable): Do better checking on the parameter type
21391 of a ref/out parameter. The ones from the system assemblies are already
21392 marked with the correct type so we don't need to do any correction.
21394 * ecore.cs (StandardConversionExists): Conversion from Interface types to
21395 the object type is standard too so include that.
21397 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21399 * ecore.cs (StandardConversionExists): Augment with missing code:
21400 deal with IntConstant, LongConstants and Enumerations.
21402 * assign.cs: Report the error, instead of failing silently
21404 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
21405 typecontainer that they are declared, because the
21406 typecontainer/namespace will have the list of using clauses that
21407 need to be applied.
21409 Assembly Attributes were escaping the normal registration
21412 (EmitCode): Apply attributes within an EmitContext that represents
21413 the container they were declared on.
21415 * cs-parser.jay: Track bases for structs. How did I get this wrong?
21417 2002-05-06 Ravi Pratap <ravi@ximian.com>
21419 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
21420 Revamp completely - make much cleaner as we now operate only
21423 (FindMostSpecificSource, FindMostSpecificTarget): New methods
21424 to implement the logic detailed in the spec more correctly.
21426 (UserDefinedConversion): Update accordingly.
21428 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21430 * statement.cs: Return flow analysis information up.
21432 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
21435 (token): Do not consume an extra character before calling
21438 2002-05-06 Piers Haken <piersh@friskit.com>
21440 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
21442 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21444 * class.cs (Constructor.Emit): Set the IsStatic flag in the
21445 EmitContext during the instance constructor initializer
21446 resolution, to stop access to instance variables.
21448 This is mandated by the spec, last paragraph of the `constructor
21449 initializers' section.
21451 2002-05-05 Miguel de Icaza <miguel@ximian.com>
21453 * cs-parser.jay, class.cs (Accessor): new class used to represent
21454 an accessor (get or set). In the past we used `null' to represent
21455 a missing accessor. But this is ambiguous because there was no
21456 way to tell in abstract indexers/properties if one of them was
21459 Now there is a way of addressing that.
21461 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
21462 instead of FindMembers.
21464 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
21465 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
21467 * attribute.cs: Treat indexers and properties as the same in terms
21468 of applying attributes
21470 * ecore.cs (FindMostEncompassedType): Use statically initialized
21471 EmptyExpressions()s like we do elsewhere to avoid creating useless
21472 objects (and we take this out of the tight loop).
21474 (GetConversionOperators): Move the code to extract the actual
21475 operators to a separate routine to clean things up.
21477 2002-05-04 Miguel de Icaza <miguel@ximian.com>
21479 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
21480 events are always registered FieldBuilders.
21482 * class.cs (FieldBase): New class shared by Fields
21484 * delegate.cs: If we are a toplevel delegate, use our full name.
21485 If we are a nested delegate, then only use our tail name.
21487 2002-05-02 Ravi Pratap <ravi@ximian.com>
21489 * expression.cs (IsApplicable): Ensure that we add the "&" to
21490 ref/out types before comparing it with the type of the argument.
21492 (IsParamsMethodApplicable): Ditto.
21494 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
21497 * delegate.cs : Handle the case when we have more than one applicable
21498 method. Flag an error only when we finish checking all.
21500 2002-05-02 Miguel de Icaza <miguel@ximian.com>
21502 * expression.cs: Add support for boolean static initializers.
21504 2002-05-01 Miguel de Icaza <miguel@ximian.com>
21506 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
21508 * parameter.cs (ComputeParameterTypes,
21509 ComputeAndDefineParameterTypes): Better error handling: now we
21510 clear the `types' cache if we fail during any of the type lookups.
21511 We also return the status code correctly to our caller
21513 * delegate.cs: If we fail to define a delegate, abort the extra
21516 * expression.cs (Binary.ResolveOperator): for
21517 operator==(object,object) and operator !=(object, object) we also
21518 have to verify that there is an implicit conversion from one to
21521 (ArrayAccess.DoResolve): Array Access can operate on
21524 2002-04-30 Miguel de Icaza <miguel@ximian.com>
21526 * assign.cs (CompoundAssign): A new class used as a "flag" that
21527 the assignment actually is happening as part of a compound
21528 assignment operator.
21530 During compound assignment, a few new rules exist to enable things
21537 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
21538 to the type of x) if y is implicitly convertible to the type of x,
21539 and the operator is a builtin operator and the return type of the
21540 operator is explicitly convertible to the type of x.
21542 * rootcontext.cs: Reset warning level to 2. 4 catches various
21543 "interesting" features in mcs, we must clean this up at some
21544 point, but currently am trying to kill other bugs ;-)
21546 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
21547 in container classes as well.
21549 * expression.cs (Binary.ResolveOperator): Handle string case
21550 before anything else (as operator overloading does emit an error
21551 before doing anything else).
21553 This code could go away when we move to a table driven model, but
21554 i could not come up with a good plan last night.
21556 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
21558 * typemanager.cs (CSharpName): reimplementation using regex.
21559 * class.cs: added null check for fields in Emit
21560 * rootcontext.cs: set warninglevel to 4
21562 2002-04-29 Miguel de Icaza <miguel@ximian.com>
21564 * typemanager.cs (CSharpName): reimplemented with Lupus
21567 2002-04-28 Miguel de Icaza <miguel@ximian.com>
21569 * statement.cs (If): correclty implement Resolve, because we were
21570 not catching sem errors in there. The same process is needed
21572 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
21575 (Statement.Warning_DeadCodeFound): Factorize code.
21576 (While): Report dead code here too.
21578 (Statement): Added Resolve virtual method to allow
21579 for resolution split from the emit code.
21581 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21583 * statement.cs (EmitBoolExpression): No longer try to resolve the
21585 (MakeBoolean): New utility function that resolve, implicitly
21586 converts to boolean and tags the expression.
21589 (If, Do): Implement dead code elimination.
21590 (While): Implement loop inversion
21592 (Do, While, For, If): Resolve the expression prior to calling our
21595 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
21598 - added method Report28 (warning: program has more than one entry point)
21599 - added method IsEntryPoint, implements paragraph 10.1 of the spec
21600 - modified method Method.Define, the part at the end of the method
21602 * rootcontext.cs: added static public Location EntryPointLocation;
21604 * ../errors/cs0028.cs : Add test case for the above warning.
21607 - modified method CSharpName to allow arrays of primitive type to
21608 be printed nicely (e.g. instead of System.Int32[][] it now prints
21610 - added method CSharpSignature: returns the signature of a method
21611 in string format to be used in reporting errors, warnings, etc.
21613 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
21616 2002-04-26 Ravi Pratap <ravi@ximian.com>
21618 * delegate.cs (Define): Fix extremely silly bug where I was
21619 setting the type of the 'object' parameter of the BeginInvoke
21620 method to System.IAsyncResult instead of System.Object ;-)
21622 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21624 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
21627 (Constructor.Emit): return if we fail to initialize the
21628 constructor. Another door closed!
21630 * expression.cs (New.DoResolve): Improve error message (from -6 to
21631 1501). Use DeclaredOnly lookup to find the exact constructor.
21633 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
21634 loop. This is useful.
21636 * cs-parser.jay: Adjust the default parameters so that destructors
21637 have the proper signature.
21639 2002-04-26 Martin Baulig <martin@gnome.org>
21641 * driver.cs (LoadAssembly): If `assembly' contains any characters
21642 which are only valid in path names and not in assembly names
21643 (currently slash, backslash and point), use Assembly.LoadFrom ()
21644 instead of Assembly.Load () on the `assembly' (before iteration
21645 over the link_paths).
21647 2002-04-26 Martin Baulig <martin@gnome.org>
21649 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
21651 2002-04-25 Miguel de Icaza <miguel@ximian.com>
21653 * class.cs (Property): use the new typemanager.MemberLookup
21655 (TypeContainer.MemberLookup): Implement using the
21656 TypeManager.MemberLookup now.
21658 * typemanager.cs: Make MemberLookup a function of the TypeManager,
21659 and return MemberInfos, so that these can be used without an
21660 EmitContext (what we had before).
21662 2002-04-24 Miguel de Icaza <miguel@ximian.com>
21664 * expression.cs: Fix the case where the argument to params if the
21665 type of the params. I omitted handling this before. Fixed
21667 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21669 * driver.cs: Call BootCorlib_PopulateCoreType
21671 * class.cs (Property.CheckBase): Check for properties only, not
21674 * interface.cs: Temporary hack: try/catch around the
21675 CustomAttributeBuilder, because I am getting an exception that I
21678 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
21679 types whose definitions are required to be there (attributes are
21680 defined before standard types).
21682 Compute definitions as we boot the various types, as they are used
21683 immediately (value_type class will need object_type, but if we do
21684 not initialize object_type, we will pass a null, which will let
21685 the runtime pick the System.Object from the existing corlib, which
21686 is not what we want).
21688 2002-04-22 Patrik Torstensson <totte@labs2.com>
21690 * cs-tokenizer.cs: fixed a number of trim() issues.
21692 2002-04-22 Ravi Pratap <ravi@ximian.com>
21694 * expression.cs (Argument.Type): Ensure that we return the correct
21695 type when we have out or ref parameters [in which case we
21698 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21700 * class.cs (Property, Indexer): Allow extern modifier in there.
21702 * typemanager.cs (InitBaseTypes): Initializes object_type and
21703 value_type, since those will be used early on during the bootstrap
21704 process to compile corlib.
21706 (InitCoreTypes): Move code from here to InitBaseTypes.
21708 2002-04-21 Miguel de Icaza <miguel@ximian.com>
21710 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
21711 single-dimension arrays as using the ldlen opcode.
21713 Daniel Lewis discovered this optimization.
21715 * typemanager.cs: Add signature for System.Array::get_Length
21717 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21719 * statement.cs: report the error when the foreach does not apply to an
21720 array nor a collection.
21722 2002-04-19 Miguel de Icaza <miguel@ximian.com>
21724 * expression.cs: Add implicit conversions to the operator ~.
21726 * constant.cs (DecimalConstant.Emit): Emit decimal value.
21728 * typemanager.cs: Locate the decimal constructor.
21730 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21732 * attribute.cs: use the new property of TypeOf.
21733 * expression.cs: added 'get' property around typearg.
21735 These changes fix a build breaker reported by NickD. Is this the
21736 correct way to fix? If not, please, revert my changes and make it
21739 2002-04-17 Miguel de Icaza <miguel@ximian.com>
21741 * attribute.cs: Add support for typeof in attribute invocations.
21742 I am not sure that this is right though.
21744 2002-04-14 Duncan Mak <duncan@ximian.com>
21746 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
21747 Binary.Operator.Division case.
21749 2002-04-13 Ravi Pratap <ravi@ximian.com>
21751 * class.cs (DefineType): Ensure that we do a proper check on
21752 attribute types and also register it with the TypeManager.
21754 (TypeContainer.Targets): The default for attribute types is
21755 AttributeTargets.All.
21757 * attribute.cs (ApplyAttributes): Registering the attribute type
21758 is done elsewhere, not when we discover we have a Usage attribute.
21760 2002-04-12 Ravi Pratap <ravi@ximian.com>
21762 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21763 and get rid of is_delegate parameter.
21765 * everywhere : update.
21767 2002-04-12 Ravi Pratap <ravi@ximian.com>
21769 * cs-parser.jay (compilation_unit): Revamp completely to use
21770 some new ideas that I got from Rhys' grammar to solve the problems
21771 with assembly level attributes.
21773 (outer_declaration): New grammar production.
21775 (attribute_sections): Add.
21777 (opt_attributes): Base on attribute_sections
21779 (namespace_declaration): Allow opt_attributes to tackle the case
21780 when we have assembly level attributes - we are clever in this
21783 * attribute.cs (ApplyAttributes): Do not worry about assembly
21784 attributes in the non-global context.
21786 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21787 instead of SetGlobalAttributes.
21789 * class.cs, rootcontext.cs : Ensure we define and generate
21790 attribute types before anything else.
21792 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21793 and flag the new error -20 for the case when the attribute type
21794 does not have valid targets specified. csc does not catch this.
21796 * ../errors/errors.txt : update for error # -20
21798 2002-04-11 Ravi Pratap <ravi@ximian.com>
21800 * support.cs (InternalParameters.ParameterModifier): Do some null
21801 checking and return sane values.
21803 * class.cs (Method.Define): If we are a PInvoke method, ensure
21804 that we are static and extern. Report error # 601
21806 * ../errors/cs0601.cs : Add test case for the above error.
21808 2002-04-07 Ravi Pratap <ravi@ximian.com>
21810 * rootcontext.cs (attribute_types): We need to keep type of
21811 all attribute types separately and emit code for them first.
21813 (RegisterAttribute) : Implement.
21815 * class.cs (DefineType): Check if the current Type is a custom
21816 attribute type and register it accordingly.
21818 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21819 adding the first attribute twice and rename to
21821 (SetGlobalAttributes): this.
21823 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21826 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21827 if we are processing global arguments. Hmm, I am unsure of this.
21829 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21831 * expression.cs: added static array of strings to avoid calling
21832 Enum.ToString () for Operator in Binary. Significant recover of
21835 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21837 * class.cs (FindMembers): Allow the Builders of the various
21838 members to be null. If they are skip them. This only happens
21839 during the PInvoke declaration.
21841 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21843 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21844 failure, so we do not keep going afterwards.
21846 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21847 wanted to pass `false' as the `is_delegate' argument. If this is
21848 the case, why not use delegate_type == null to mean `is_delegate =
21849 false' and anything else as is_delegate = true.
21851 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21853 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21854 code for the section, not the beginning of the tests.
21856 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21858 * cfold.cs: Handle operator + (Enum x, Underlying x)
21860 * expression.cs (Binary): same. Warn about errors where we have
21861 Enum/Enum in operator + as well.
21863 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21866 - added support for switch(bool)
21867 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21868 - add TableSwitchEmit() to handle table-based switch statements
21870 2002-04-05 Ravi Pratap <ravi@ximian.com>
21872 * expression.cs (Invocation.OverloadResolve): Factor out code which
21873 does parameter compatibility checking with arguments so that we can
21874 re-use the code even from Delegate.VerifyApplicability
21876 (VerifyArgumentsCompat): Move above code here.
21878 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21879 and instead make a call to the above method.
21881 2002-03-31 Ravi Pratap <ravi@ximian.com>
21883 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21884 We use it to keep track of classes which are attribute types.
21886 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21888 * delegate.cs (Delegate.Define): Correctly define the types in the
21889 presence of fixed and array parameters.
21891 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21894 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21895 include NonPublic after the first iteration.
21897 * class.cs (Indexer.CheckBase): Only check if both parents are
21900 * cs-parser.jay (accessor_body): If empty, set to null.
21902 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21903 same code path here to resolve constants names that we did have in
21904 MemberAccess.DoResolve. There is too much code duplicated here.
21906 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21908 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21910 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21913 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21914 tokens, numbers and strings.
21916 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21919 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21920 asyncronous parameters and the regular parameters.
21922 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21923 specify the target directory.
21925 * expression.cs: (This.DoResolve): Simplify
21926 (As.Emit): Optimize, do not generate IsInst if the expression is
21927 always of the given type.
21929 (Is.DoResolve): Bug fix, we were reporting both always/never for
21932 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21933 creating too many unnecessary arrays.
21935 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21937 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21938 fields instead of rolling our own initializer. Takes care of all
21939 implicit conversions, and drops unnecessary static checks/argument.
21941 2002-03-31 Dick Porter <dick@ximian.com>
21943 * driver.cs: use the GetDirectories() return values properly, and
21944 use "/" as path separator.
21946 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21948 * expression.cs (Unary): Optimize - - expr into expr.
21949 (Binary): Optimize a + (-b) into a -b.
21951 * codegen.cs (CodeGen): Made all methods static.
21953 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21957 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21958 TypeBuilder property.
21960 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21963 * tree.cs: Removed the various RecordXXXX, and replaced with a
21964 single RecordDecl. Removed all the accessor methods, and just
21965 left a single access point Type
21967 * enum.cs: Rename DefineEnum to DefineType.
21969 * decl.cs: New abstract method `DefineType' used to unify the
21970 Defines for Enumerations, Interfaces, TypeContainers and
21973 (FindType): Moved LookupInterfaceOrClass here. Moved the
21974 LookupBaseClasses method that used to live in class.cs and
21975 interface.cs here, and renamed to FindType.
21977 * delegate.cs: Implement DefineType. Take advantage of the
21978 refactored pattern for locating the parent builder without taking
21979 the parent_builder argument (which we know does not work if we are
21980 nested, and triggering a toplevel definition).
21982 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21984 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21985 accessibility of a member has changed during override and report
21988 * class.cs (Method.Define, Property.Define): Only complain on
21989 overrides if the method is private, any other accessibility is
21990 fine (and since we just checked the permission is the same, we are
21993 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21994 and elif are processed always. The other pre-processing
21995 directives are only processed if we are "taking" the path
21997 2002-03-29 Martin Baulig <martin@gnome.org>
21999 * class.cs (Method.Emit): Only emit symbolic debugging info if the
22000 current location is not Null.
22002 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
22003 a separate method so we can profile it.
22005 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
22006 `span.Seconds' are just seconds, but no minutes or hours.
22007 (MainDriver): Profile the CodeGen.SaveSymbols calls.
22009 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22011 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
22012 Remove the gratuitous set of Final:
22014 // If an interface implementation, then we can set Final.
22015 if (((flags & MethodAttributes.Abstract) == 0) &&
22016 implementing.DeclaringType.IsInterface)
22017 flags |= MethodAttributes.Final;
22019 I do not know what I was smoking when I used that.
22022 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
22023 step into fixing the name resolution issues for delegates and
22024 unifying the toplevel name resolution.
22026 2002-03-28 Martin Baulig <martin@gnome.org>
22028 * class.cs (Method.Emit): If we have a symbol writer, call its
22029 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
22030 tell it about the current method.
22032 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
22033 writer that we're going to emit the first byte of IL code for a new
22034 statement (a new source line).
22035 (EmitContext.EmitTopBlock): If we have a symbol writer, call
22036 EmitContext.Mark() before emitting any code.
22038 * location.cs (SymbolDocument): Return null when we're Null.
22040 * statement.cs (Statement): Moved the `Location loc' variable here.
22041 (Statement.EmitBoolExpression): If we have a symbol writer, call
22042 ec.Mark() before emitting any code to tell it that we're at the
22043 beginning of a new statement.
22044 (StatementExpression): Added `Location' argument to the constructor.
22045 (Block): Added public readonly variable `StartLocation' and public
22046 variable `EndLocation'. The latter is to be set using SetEndLocation().
22047 (Block): Added constructor which takes a start and end location.
22048 (Block.SetEndLocation): New method. This sets the end location.
22049 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
22050 local variables we create.
22051 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
22052 each statement and do also mark the begin and end of the block.
22054 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
22055 tell it the current lexer.Location, use Location.Null for the end of the
22057 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22058 current block, set its end location using SetEndLocation().
22059 (statement_expression): StatementExpression constructor now takes the
22060 lexer.Location as additional argument.
22061 (for_statement, declare_local_variables): Likewise.
22062 (declare_local_variables): When creating a new implicit block, use the
22063 new Block constructor and pass it the lexer.Location.
22065 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22067 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
22068 members also on the parent interfaces recursively.
22070 2002-03-27 Miguel de Icaza <miguel@ximian.com>
22072 * report.cs: Use new formats, since Gonzalo finished the missing
22075 * expression.cs (Binary.ResolveOperator): added missing operator|
22076 operator& and operator^ for bool/bool.
22078 * cs-parser.jay: CheckDef now takes a Location argument that is
22079 used to report errors more precisly (instead of reporting the end
22080 of a definition, we try to track something which is a lot closer
22081 to the source of the problem).
22083 * cs-tokenizer.cs: Track global token use, so we can properly flag
22084 the use of #define/#undef after the first token has been seen.
22086 Also, rename the reportXXXX to Error_DescriptiveName
22088 * decl.cs (DeclSpace.IsTopLevel): Move property here from
22089 TypeContainer, so that Enum and Interface can use this too.
22091 * class.cs (TypeContainer.LookupInterfaceOrClass,
22092 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
22093 `builder' argument. Typically this was used to pass the parent
22094 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
22097 The problem is that a nested class could trigger the definition of
22098 a toplevel class, and the builder would be obviously wrong in that
22101 So we drop this argument, and we compute dynamically the
22102 TypeBuilder/ModuleBuilder (the correct information was available
22103 to us anyways from DeclSpace.Parent)
22105 * interface.cs (Interface.DefineInterface): Drop builder
22106 parameter cleanup like class.cs
22108 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
22111 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
22114 (Try.Emit): Propagate the returns value from the statement.
22116 (Return.Emit): Even if we are leavning
22118 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
22120 * modifiers.cs: Fix the computation of MethodAttributes flags.
22122 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
22124 * driver.cs: allow compilation of files that start with '/'.
22125 Add a default case when checking the argument of --target.
22127 2002-03-25 Miguel de Icaza <miguel@ximian.com>
22129 * interface.cs: Implement the same search algorithm for types in
22130 the interface code.
22132 * delegate.cs: Do not allow multiple definition.
22134 * Recovered ChangeLog that got accidentally amputated
22136 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
22138 * rootcontext.cs: Load manually enum to allow core classes to
22139 contain enumerations.
22141 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
22142 Update to new static methods in TypeManager.
22144 * typemanager.cs (GetMethod, GetConstructor): Use our
22145 implementation of FindMembers to find the members, since during
22146 corlib compilation, the types are TypeBuilders and GetMethod and
22147 GetConstructor do not work.
22149 Make all methods in TypeManager static.
22151 (InitCodeHelpers): Split the functionality from
22152 the InitCodeTypes function.
22154 * driver.cs: Call InitCodeHelpers after we have populated the
22157 * cs-parser.jay (delegate_declaration): we did not used to compute
22158 the delegate name correctly for void delegates.
22160 2002-03-24 Miguel de Icaza <miguel@ximian.com>
22162 * rootcontext.cs (RootContext): Init the interface_resolve_order
22163 and type_container_resolve_order always.
22165 (ResolveCore, BootstrapCorlib_ResolveClass,
22166 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
22167 compiler when compiling with --nostdlib
22169 * class.cs (TypeContainer.DefineType): Check that our parent is
22170 not null. This test is most important when we are bootstraping
22173 * codegen.cs: Split out the symbol writing code.
22175 2002-03-25 Martin Baulig <martin@gnome.org>
22177 * driver.cs (-g): Made -g an alias for --debug.
22179 2002-03-24 Martin Baulig <martin@gnome.org>
22181 * codegen.cs (SymbolWriter): New public variable. Returns the
22182 current symbol writer.
22183 (CodeGen): Added `bool want_debugging_support' argument to the
22184 constructor. If true, tell the ModuleBuild that we want debugging
22185 support and ask it for the ISymbolWriter.
22186 (Save): If we have a symbol writer, call it's Close() method after
22187 saving the assembly.
22189 * driver.c (--debug): New command line argument to create a
22190 debugger information file.
22192 * location.cs (SymbolDocument): New public property. Returns an
22193 ISymbolDocumentWriter object for the current source file or null
22194 if we don't have a symbol writer.
22196 2002-03-21 Miguel de Icaza <miguel@ximian.com>
22198 * driver.cs (LoadAssembly): Correctly return when all the paths
22199 have been tried and not before.
22201 * statement.cs (Switch.Emit): return the actual coverage for this
22202 statement (returns/not-returns)
22204 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
22205 switch of the statement if we are the last switch section. That
22206 kills two problems: try/catch problems (we used to emit an empty
22207 nop at the end) and switch statements where all branches would
22210 2002-03-19 Miguel de Icaza <miguel@ximian.com>
22212 * driver.cs: Add default assemblies (the equivalent to the
22213 Microsoft CSC.RSP file)
22215 * cs-tokenizer.cs: When updating `cols and setting it to zero,
22216 also update tokens_seen and set it to false.
22218 * driver.cs: Implement --recurse for Mike.
22220 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
22221 correctly splitting out the paths.
22223 2002-03-18 Miguel de Icaza <miguel@ximian.com>
22225 * interface.cs (Interface.PopulateProperty): Instead of using
22226 `parent' as the declaration space for the set parameters, use
22229 * support.cs (InternalParameters): InternalParameters constructor
22230 takes a DeclSpace instead of a TypeContainer.
22232 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
22233 types are being initialized, load the address of it before calling
22236 (New): Provide a mechanism to disable the generation of local
22237 value type temporaries when the caller will be providing us with
22238 an address to store it.
22240 (ArrayCreation.EmitDynamicInitializers): Use it.
22242 2002-03-17 Miguel de Icaza <miguel@ximian.com>
22244 * expression.cs (Invocation.EmitArguments): Only probe for array
22245 property if there is more than one argument. Sorry about that.
22247 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
22248 empty param arrays.
22250 * class.cs (Method.LabelParameters): Fix incorrect code path that
22251 prevented the `ParamArrayAttribute' from being applied to the
22254 2002-03-16 Miguel de Icaza <miguel@ximian.com>
22256 * support.cs (ReflectionParameters): Correctly compute whether the
22257 last argument is a params array. Fixes the problem with
22260 * typemanager.cs: Make the assemblies array always be non-null
22261 (empty, but non-null)
22263 * tree.cs (RecordDecl): New function that abstracts the recording
22264 of names. This reports error 101, and provides a pointer to the
22265 previous declaration. Fixes a crash in the compiler.
22267 * cs-parser.jay (constructor_declaration): Update to new grammar,
22268 and provide a constructor_body that can be empty.
22270 2002-03-15 Miguel de Icaza <miguel@ximian.com>
22272 * driver.cs: Add support for --resources.
22274 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
22275 Make all types for the various array helper methods be integer.
22277 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
22278 CheckState to ConvCast.
22280 (ConvCast): Now it takes a `checked' state argument, to avoid
22281 depending on the emit context for the conversion, and just using
22282 the resolve time setting.
22284 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
22285 instead of Invocation.EmitArguments. We do not emit the original
22286 arguments, instead we emit those which have been converted to
22287 unsigned int expressions.
22289 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
22291 * codegen.cs: ditto.
22293 * expression.cs (LocalVariableReference): Drop the use of the
22294 Store function that depended on the variable index.
22296 * statement.cs (VariableInfo): Drop the `Idx' property from this
22297 class, as this is not taking into account the indexes for
22298 temporaries tat we generate during the execution, getting the
22301 * class.cs: First emit class initializers, then call the parent
22304 * expression.cs (Binary): Fix opcode emision.
22305 (UnaryMutator.EmitCode): Support checked code generation
22307 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
22308 matches for events for both the Static and Instance scans,
22309 pointing to the same element. Fix that.
22311 2002-03-14 Miguel de Icaza <miguel@ximian.com>
22313 * rootcontext.cs (ResolveTree): Always set the
22314 interface_resolve_order, because nested interfaces will be calling
22317 * class.cs (GetInterfaceOrClass): Track the same resolution
22318 process used by TypeManager.LookupType. This fixes the nested
22319 type lookups in class declarations (separate path from
22322 (TypeContainer.DefineType): Also define nested interfaces.
22323 (TypeContainer.RegisterOrder): New public function used to
22324 register the order in which child interfaces need to be closed.
22326 Nested interfaces need to be closed after their parents have been
22329 * interface.cs (InterfaceAttr): Put all the logic for computing
22330 the interface attribute here.
22332 (DefineInterface): Register our interface order with the
22333 RootContext or with the TypeContainer depending on the case.
22335 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22337 * cs-parser.jay: rework foreach statement to work with the new
22338 changes to the policy on SimpleNames.
22340 * report.cs: support Stacktrace on warnings as well.
22342 * makefile: drop --unsafe and /unsafe from the compile.
22344 2002-03-13 Ravi Pratap <ravi@ximian.com>
22346 * ecore.cs (StandardConversionExists): Modify to take an Expression
22347 as the first parameter. Ensure we do null -> reference type conversion
22350 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
22351 temporary Expression objects.
22353 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
22355 * interface.cs: workaround bug in method overloading resolution
22356 (there is already a bugzilla bug for it).
22358 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22360 We could also solve this problem by having a separate path for
22361 performing type lookups, instead of DoResolve, we could have a
22362 ResolveType entry point, and only participating pieces of the
22363 production (simplename, deref, array) would implement this.
22365 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
22366 signal SimpleName to only resolve type names and not attempt to
22367 resolve anything else.
22369 * expression.cs (Cast): Set the flag.
22371 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
22373 * class.cs: Only report 108 if there is no `new' modifier.
22375 * cs-parser.jay: rework foreach statement to work with the new
22376 changes to the policy on SimpleNames.
22378 * report.cs: support Stacktrace on warnings as well.
22380 * makefile: drop --unsafe and /unsafe from the compile.
22382 2002-03-11 Miguel de Icaza <miguel@ximian.com>
22384 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22385 lookups here, instead of doing that at parse time. This means
22386 that our grammar will not introduce `LocalVariableReferences' as
22387 expressions at this point. That solves the problem of code like
22391 static void Main ()
22395 This is only half the fix. The full fix requires parameters to
22396 also be handled in this way.
22398 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
22399 makes the use more obvious of the DeclSpace. The
22400 ec.TypeContainer.TypeBuilder is now only used to pull the
22401 TypeBuilder for it.
22403 My theory is that I can get rid of the TypeBuilder completely from
22404 the EmitContext, and have typecasts where it is used (from
22405 DeclSpace to where it matters).
22407 The only pending problem is that the code that implements Aliases
22408 is on TypeContainer, and probably should go in DeclSpace.
22410 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22411 lookups here, instead of doing that at parse time. This means
22412 that our grammar will not introduce `LocalVariableReferences' as
22413 expressions at this point. That solves the problem of code like
22417 static void Main ()
22421 This is only half the fix. The full fix requires parameters to
22422 also be handled in this way.
22424 * class.cs (Property.DefineMethod): When implementing an interface
22425 method, set newslot, when implementing an abstract method, do not
22426 set the flag (before we tried never setting it, or always setting
22427 it, which is the difference).
22428 (Indexer.DefineMethod): same.
22429 (Method.DefineMethod): same.
22431 * ecore.cs: Only set the status used flag if we get back a Field.
22433 * attribute.cs: Temporary hack, so Paolo can keep working.
22435 2002-03-08 Ravi Pratap <ravi@ximian.com>
22437 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
22438 the unmanaged type in the case we have a MarshalAs attribute.
22440 (Resolve): Handle the case when we are parsing the special MarshalAs
22441 attribute [we need to store the unmanaged type to use later]
22443 * typemanager.cs (marshal_as_attr_type): Built in type for the
22444 MarshalAs Attribute.
22446 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
22447 on parameters and accordingly set the marshalling info.
22449 2002-03-09 Miguel de Icaza <miguel@ximian.com>
22451 * class.cs: Optimizing slightly by removing redundant code after
22452 we switched to the `NoTypes' return value.
22453 (Property.DefineMethod): use NoTypes here too.
22455 This fixes the bug I introduced in my last batch of changes.
22457 2002-03-05 Ravi Pratap <ravi@ximian.com>
22459 * tree.cs (RecordEnum): Add. We now keep track of enums too.
22461 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
22462 Enums since those are types too.
22464 * cs-parser.jay (enum_declaration): Record enums as we parse them.
22466 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
22467 thanks to a call during the lookup process.
22469 2002-03-07 Miguel de Icaza <miguel@ximian.com>
22471 * statement.cs (Foreach): Lots of work to accomodate a particular
22472 kind of foreach statement that I had not kept in mind. It is
22473 possible to have foreachs on classes that provide a GetEnumerator
22474 method that return objects that implement the "pattern" for using
22475 a foreach, there is no need to support GetEnumerator
22478 This is needed to compile nant.
22480 * decl.cs: Only report 114 if the member is not `Finalize' and if
22481 the warning level is at least 2.
22483 * class.cs: Moved the compare function from Method to
22486 (MethodSignature.InheritableMemberSignatureCompare): Add new
22487 filter function that is used to extract inheritable methods from a
22490 (Method.Define): Use the new `inheritable_method_signature_filter'
22493 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
22496 2002-03-06 Miguel de Icaza <miguel@ximian.com>
22498 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
22500 * cs-parser.jay: Add opt_semicolon to the interface declaration.
22502 * expression.cs: Pass location information to
22503 ConvertImplicitStandard.
22505 * class.cs: Added debugging code to track return values from
22508 2002-03-05 Miguel de Icaza <miguel@ximian.com>
22510 * expression.cs (Is.DoResolve): If either side of the `is' is an
22511 interface, do not flag the warning.
22513 * ecore.cs (ImplicitReferenceConversion): We need a separate test
22516 * report.cs: Allow for --fatal to be used with --probe.
22518 * typemanager.cs (NoTypes): Move the definition for the empty Type
22521 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
22523 (TypeContainer.DefineProxy): New function used to proxy to parent
22524 implementations when implementing interfaces.
22525 (TypeContainer.ParentImplements): used to lookup if our parent
22526 implements a public function that is required by an interface.
22527 (TypeContainer.VerifyPendingMethods): Hook this up.
22529 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
22530 `modules' and `assemblies' arraylists into arrays. We only grow
22531 these are the very early start up of the program, so this improves
22532 the speedof LookupType (nicely measured).
22534 * expression.cs (MakeByteBlob): Replaced unsafe code with
22535 BitConverter, as suggested by Paolo.
22537 * cfold.cs (ConstantFold.Binary): Special case: perform constant
22538 folding of string concatenation, but if either side is a string,
22539 and the other is not, then return null, and let the runtime use
22540 the concatenation on the string plus the object (using
22541 `Object.ToString').
22543 2002-03-04 Miguel de Icaza <miguel@ximian.com>
22545 Constant Folding has been implemented now.
22547 * expression.cs (Unary.Reduce): Do not throw an exception, catch
22548 the error instead on types that are not supported in one's
22551 * constant.cs (Constant and all children): New set of functions to
22552 perform implict and explicit conversions.
22554 * ecore.cs (EnumConstant): Implement the new functions to perform
22555 conversion by proxying to the child expression.
22557 * codegen.cs: (ConstantCheckState): Constant evaluation has its
22558 own separate setting that can not be turned off from the command
22559 line using --unchecked or --checked and is only controlled using
22560 the checked/unchecked statements and expressions. This setting is
22561 used by the constant folder to flag errors.
22563 * expression.cs (CheckedExpr, UncheckedExpr): Set the
22564 ConstantCheckState as well.
22566 During Resolve, they also have to flag the state, because the
22567 constant folder runs completely in the Resolve phase.
22569 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
22572 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22574 * cfold.cs: New file, this file contains the constant folder.
22576 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
22577 argument to track whether we are using the resulting address to
22578 load or store a value and provide better error messages.
22580 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
22581 new AddressOf arguments.
22583 * statement.cs (Foreach.EmitCollectionForeach): Update
22585 * expression.cs (Argument.Emit): Call AddressOf with proper
22586 arguments to track usage.
22588 (New.DoEmit): Call AddressOf with new arguments.
22590 (Unary.Emit): Adjust AddressOf call.
22592 2002-03-01 Ravi Pratap <ravi@ximian.com>
22594 * cs-parser.jay (member_access): Change the case for pre-defined types
22595 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
22598 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
22601 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
22602 essentially like methods and apply attributes like MethodImplOptions to them too.
22604 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
22607 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
22608 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
22611 * Update code everywhere accordingly.
22613 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
22615 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
22617 2002-02-28 Ravi Pratap <ravi@ximian.com>
22619 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
22620 try performing lookups against those instead of jumping straight into using
22621 the 'using' clauses.
22623 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
22625 (LookupType): Perform lookups in implicit parents too.
22627 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
22628 sequence as RootContext.LookupType.
22630 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
22631 the various cases of namespace lookups into this method.
22633 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22635 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
22636 in positional arguments)
22638 * class.cs (Operator): Update the AllowedModifiers to contain
22641 * cs-parser.jay: Update operator declaration to allow for the
22642 operator body to be empty.
22644 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
22647 2002-02-27 Miguel de Icaza <miguel@ximian.com>
22649 * class.cs (Method.Emit): Label parameters.
22651 * driver.cs: Return 1 or 0 as the program exit code.
22653 2002-02-26 Miguel de Icaza <miguel@ximian.com>
22655 * expression.cs: Special case the `null' object when trying to
22656 auto-compute the type, as anything can be explicitly converted to
22659 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
22660 spotting this Paolo.
22662 (Expression.ImplicitNumericConversion): Perform comparissions of
22663 the type using the underlying type in the case of an enumeration
22664 rather than using the enumeration type for the compare.
22666 Cope with the underlying == type case, which is not possible to
22669 (Expression.ConvertNumericExplicit): Perform comparissions of
22670 the type using the underlying type in the case of an enumeration
22671 rather than using the enumeration type for the compare.
22673 * driver.cs: If the user does not supply an extension, assume .exe
22675 * cs-parser.jay (if_statement): Rewrote so that we can track the
22676 location for the if statement.
22678 * expression.cs (Binary.ConstantFold): Only concat strings when
22679 the operation is "+", not everything ;-)
22681 * statement.cs (Statement.EmitBoolExpression): Take a location
22683 (If, While, Do): Track location.
22685 * expression.cs (Binary.ResolveOperator): In the object + string
22686 case, I was missing a call to ConvertImplicit
22688 2002-02-25 Ravi Pratap <ravi@ximian.com>
22690 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
22691 Location arguments. Ensure we use RootContext.LookupType to do our work
22692 and not try to do a direct Type.GetType and ModuleBuilder.GetType
22694 * interface.cs (PopulateMethod): Handle the type of the parameter being
22697 * expression.cs (Invocation.BetterFunction): Handle the case when we
22698 have a params method with no fixed arguments and a call is made with no
22701 2002-02-25 Miguel de Icaza <miguel@ximian.com>
22703 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
22704 the verbatim-string-literal
22706 * support.cs (InternalParameters.ParameterModifier): handle null
22708 (InternalParameters.ParameterType): ditto.
22710 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
22711 duplicating the name of the variable parameter.
22712 (GetParameterByName): Fix bug where we were not looking up array
22713 paramters if they were the only present (thanks Paolo!).
22714 (GetParameterInfo): We only have an empty set of types if both
22715 fixed and array are set to null.
22716 (GetParameterInfo-idx): Handle FixedParameter == null
22718 * cs-parser.jay: Handle the case where there is no catch
22719 statements (missing null test).
22721 2002-02-22 Miguel de Icaza <miguel@ximian.com>
22723 * driver.cs (MainDriver): Be conservative on our command line
22726 Catch DirectoryNotFoundException when calling GetFiles.
22728 (SplitPathAndPattern): Used to split the input specification into
22729 a path and a pattern that we can feed to Directory.GetFiles.
22731 2002-02-21 Miguel de Icaza <miguel@ximian.com>
22733 * statement.cs (Fixed): Implement the last case of the Fixed
22734 statement (string handling).
22736 * expression.cs (StringPtr): New class used to return a char * to
22737 a string; Used by the Fixed statement.
22739 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
22741 * expression.cs (Binary.ResolveOperator): Remove redundant
22742 MemberLookup pn parent type.
22743 Optimize union call, we do not need a union if the types are the same.
22744 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
22747 Specialize the use of MemberLookup everywhere, instead of using
22748 the default settings.
22750 (StackAlloc): Implement stackalloc keyword.
22752 * cs-parser.jay: Add rule to parse stackalloc.
22754 * driver.cs: Handle /h, /help, /?
22756 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22757 before we supported unsafe code.
22759 * makefile: add --unsafe to the self compilation of mcs.
22761 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22763 * expression.cs (PointerArithmetic): New class that is used to
22764 perform pointer arithmetic.
22765 (Binary.Resolve): Handle pointer arithmetic
22766 Handle pointer comparission.
22767 (ArrayPtr): Utility expression class that is used to take the
22768 address of an array.
22770 (ElementAccess): Implement array access for pointers
22772 * statement.cs (Fixed): Implement fixed statement for arrays, we
22773 are missing one more case before we are done.
22775 * expression.cs (Indirection): Implement EmitAssign and set the
22776 ExprClass to Variable. This allows pointer dereferences to be
22777 treated as variables, and to have values assigned to them.
22779 * ecore.cs (Expression.StoreFromPtr): New utility function to
22780 store values dereferencing.
22782 2002-02-20 Ravi Pratap <ravi@ximian.com>
22784 * expression.cs (Binary.ResolveOperator): Ensure that we are
22785 not trying to operate on a void type - this fixes the reported
22788 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22789 the parent implementation is sealed.
22791 * ../errors/cs0239.cs : Add.
22793 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22795 * typemanager.cs (unverifiable_code_type): Corresponds to
22796 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22797 which have unsafe code in them.
22799 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22802 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22804 * cs-tokenizer.cs: Add support for @"litreal strings"
22806 Make tokenizer accept pre-processor directives
22807 on any column (remove the old C-like limitation).
22809 * rootcontext.cs (EmitCode): Emit any global attributes.
22810 (AddGlobalAttributes): Used to keep track of assembly attributes.
22812 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22814 * cs-parser.jay: Add support for global attributes.
22816 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22818 * expression.cs (Indirection): New helper class. Unary will
22819 create Indirection classes to be able to implement the
22820 IMemoryLocation interface on it.
22822 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22824 * cs-parser.jay (fixed_statement): reference the right statement.
22826 * statement.cs (Fixed.Emit): Finish implementing the fixed
22827 statement for the &x case.
22829 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22831 * class.cs (Property.Define, Method.Define): Remove newslot when
22834 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22835 wrong. NewSlot should only be used if the `new' keyword is present.
22837 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22838 locating our system dir. Sorry about this.
22840 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22842 * driver.cs (GetSystemDir): Compute correctly the location of our
22843 system assemblies. I was using the compiler directory instead of
22844 the library directory.
22846 2002-02-13 Ravi Pratap <ravi@ximian.com>
22848 * expression.cs (BetterFunction): Put back in what Miguel commented out
22849 since it is the correct fix. The problem is elsewhere ;-)
22851 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22852 parameters of the parms method are themselves compatible or not !
22854 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22855 to check that a class implements an interface before saying that an implicit
22856 conversion was allowed. Use ImplementsInterface to do the checking.
22858 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22860 * class.cs (Method.Define): Track whether we are an explicit
22861 implementation or not. And only call DefineMethodOverride if we
22862 are an explicit implementation.
22864 (Property.DefineMethod): Ditto.
22866 2002-02-11 Ravi Pratap <ravi@ximian.com>
22868 * expression.cs (BetterFunction): Catch hideous bug which was
22869 preventing us from detecting ambiguous calls due to implicit casts i.e
22872 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22874 * support.cs (Pair): Remove un-needed method. I figured why I was
22875 getting the error in cs-parser.jay, the variable in a foreach loop
22876 is readonly, and the compiler does not really treat this as a variable.
22878 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22879 instead of EQUALS in grammar.
22881 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22883 * expression.cs (Unary.DoResolve): Check whether the argument is
22886 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22888 * support.cs: Api for Pair to set a value. Despite the fact that
22889 the variables are public the MS C# compiler refuses to compile
22890 code that accesses the field if the variable is part of a foreach
22893 * statement.cs (Fixed): Begin implementation of the fixed
22896 (Block.AddVariable): Return the VariableInfo on success and null
22897 on failure instead of true/false.
22899 * cs-parser.jay (foreach): Catch errors on variables already
22900 defined (we were ignoring this value before) and properly unwind
22901 the block hierarchy
22903 (fixed_statement): grammar for the fixed statement.
22905 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22907 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22908 pointer types to be incretemented.
22910 (SizeOf): Implement.
22912 * cs-parser.jay (pointer_member_access): Implement
22913 expr->IDENTIFIER production.
22915 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22916 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22919 (Unary): Implement indirection.
22921 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22922 use in non-unsafe context).
22924 (SimpleName.DoResolve): Check for pointers in field access on safe
22927 (Expression.LoadFromPtr): Factor the load-indirect code in this
22928 function. This was duplicated in UnboxCast and ParameterReference
22930 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22932 * expression.cs (ComposedCast): report an error if a pointer cast
22933 is used in a safe region.
22935 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22936 pointer type casts in unsafe context.
22938 * codegen.cs (EmitContext): Set up IsUnsafe.
22940 * cs-parser.jay (non_expression_type): Add productions for pointer
22943 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22944 code. We should not use force into static mode if the method is
22945 not virtual. Fixes bug in MIS
22947 * statement.cs (Do.Emit, While.Emit, For.Emit,
22948 Statement.EmitBoolExpression): Add support to Do and While to
22949 propagate infinite loop as `I do return' semantics.
22951 Improve the For case to also test for boolean constants.
22953 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22954 to the list of attributes we can add.
22956 Remove `EmitContext' argument.
22958 * class.cs (Method.Define): Apply parameter attributes.
22959 (Constructor.Define): Apply parameter attributes.
22960 (MethodCore.LabelParameters): Move here the core of labeling
22963 * support.cs (ReflectionParameters.ParameterModifier,
22964 InternalParameters.ParameterModifier): Use IsByRef on the type and
22965 only return the OUT bit for these parameters instead of in/out/ref
22968 This is because I miss-understood things. The ParameterInfo.IsIn
22969 and IsOut represent whether the parameter has the [In] and [Out]
22972 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22974 * ecore.cs (FieldExpr.Emit): Release temporaries.
22976 * assign.cs (LocalTemporary.Release): new function.
22978 * codegen.cs (EmitContext.GetTemporaryStorage,
22979 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22980 temporary storage. Now we can "put back" localbuilders when we
22983 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22985 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22986 need to make a copy of the variable to generate verifiable code.
22988 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22990 * driver.cs: Compute dynamically the system directory.
22992 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22993 Slower, but more generally useful. Used by the abstract
22994 registering implementation.
22996 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22997 the rules for the special rule on Type/instances. First check if
22998 we have the same name, and if so, try that special static path
22999 rather than the instance path.
23001 2002-01-18 Miguel de Icaza <miguel@ximian.com>
23003 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
23006 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
23007 Enum, ValueType, Delegate or Array for non-corlib compiles.
23009 * cs-tokenizer.cs: Catch long identifiers (645)
23011 * typemanager.cs (IndexerPropetyName): Ravi never tested this
23014 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
23015 fix, we were returning too early, so we were not registering
23016 pending methods from abstract classes.
23018 Do not register pending methods if the class is abstract.
23020 * expression.cs (Conditional.DoResolve): Report circular implicit
23021 conversions when we neecd to compute it for conditional
23024 (Is.DoResolve): If the expression is always of the provided type,
23025 flag warning 183. If the expression can not ever be of the
23026 provided type flag warning 184.
23028 * class.cs: Catch 169 as well.
23030 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
23033 2002-01-18 Nick Drochak <ndrochak@gol.com>
23035 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
23037 2002-01-17 Miguel de Icaza <miguel@ximian.com>
23039 * interface.cs: (PopulateMethod): Check for pointers being defined
23040 only if the unsafe context is active.
23041 (PopulateProperty): ditto.
23042 (PopulateIndexer): ditto.
23044 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
23045 specified. If pointers are present, make sure that they are
23046 present in an unsafe context.
23047 (Constructor, Constructor.Define): ditto.
23048 (Field, Field.Define): ditto.
23049 (Property, Property.Define): ditto.
23050 (Event, Event.Define): ditto.
23052 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
23053 hashtable if there are classes or structs defined.
23055 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23056 code, as the constant resolution moved.
23058 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
23059 the metadata, so we can flag error 133.
23061 * decl.cs (MemberCore.UnsafeOK): New function to test that a
23062 pointer is being declared in an unsafe context.
23064 2002-01-16 Miguel de Icaza <miguel@ximian.com>
23066 * modifiers.cs (Modifiers.Check): Require a Location argument.
23067 Report error 227 for Unsafe use.
23069 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
23071 * statement.cs (For.Emit): If the test is null, then report that
23072 we do `return', as we wont reach anything afterwards.
23074 (Switch.SwitchGoverningType): Track the expression that matched
23077 * driver.cs: Allow negative numbers as an error code to flag.
23079 * cs-parser.jay: Handle 1551.
23081 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
23083 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23085 * cs-parser.jay: Report 1518 (type declaration can only contain
23086 class, struct, interface, enum or delegate)
23088 (switch_label): Report 1523 (keywords `case' or `default' must
23091 (opt_switch_sections): Report 1522 (empty switch)
23093 * driver.cs: Report 1515 (response file specified multiple times)
23094 Report 1516 (Source file specified multiple times).
23096 * expression.cs (Argument.Resolve): Signal 1510
23098 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
23099 access not allowed in static code)
23101 2002-01-11 Ravi Pratap <ravi@ximian.com>
23103 * typemanager.cs (IsPointerType): Utility method which we are going
23106 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
23107 the object type, so we take care of that.
23109 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
23111 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
23112 added to non-params parameters :-)
23114 * typemanager.cs (CSharpName): Include 'void' type too.
23116 (void_ptr_type): Include in the set of core types.
23118 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
23121 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
23124 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
23125 completely forgotten about it.
23127 2002-01-10 Ravi Pratap <ravi@ximian.com>
23129 * cs-parser.jay (pointer_type): Add. This begins our implementation
23130 of parsing rules for unsafe code.
23132 (unsafe_statement): Implement.
23134 (embedded_statement): Modify to include the above.
23136 * statement.cs (Unsafe): Implement new class for unsafe blocks.
23138 * codegen.cs (EmitContext.InUnsafe): Add. This determines
23139 if the current context is an unsafe one.
23141 * cs-parser.jay (local_variable_pointer_type): Since local variable types
23142 are handled differently, we need separate rules for them.
23144 (local_variable_declaration): Update to use local_variable_pointer_type
23145 to allow variable declarations of unmanaged pointer types.
23147 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
23148 in unsafe contexts.
23150 * ../errors/cs0214.cs : Add.
23152 2002-01-16 Nick Drochak <ndrochak@gol.com>
23154 * makefile: remove 'response' file when cleaning.
23156 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23158 * cs-parser.jay: Report 1524.
23160 2002-01-14 Miguel de Icaza <miguel@ximian.com>
23162 * typemanager.cs (RegisterMethod): drop checking if we have
23163 registered this from here
23165 2002-01-12 Miguel de Icaza <miguel@ximian.com>
23167 * class.cs (Method.EmitDestructor): Implement calling our base
23170 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
23171 value of InFinally.
23173 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
23174 this routine and will wrap the call in a try/catch block. Deal
23177 2002-01-11 Miguel de Icaza <miguel@ximian.com>
23179 * ecore.cs (Expression.MemberLookup): instead of taking a
23180 parameter `same_type' that was used to tell whether we could
23181 access private members we compute our containing type from the
23184 (FieldExpr): Added partial support for volatile fields. This does
23185 not work for volatile fields exposed from assemblies, as I can not
23186 figure out how to extract the modreq from it.
23188 Updated all the source files to use this.
23190 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
23191 because it is referenced by MemberLookup very often.
23193 2002-01-09 Ravi Pratap <ravi@ximian.com>
23195 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
23196 TypeBuilder.GetCustomAttributes to retrieve what we need.
23198 Get rid of redundant default_member_attr_type as this is the same as
23199 default_member_type which already exists.
23201 * interface.cs, attribute.cs : Update accordingly.
23203 2002-01-08 Miguel de Icaza <miguel@ximian.com>
23205 * typemanager.cs: Enable IndexerPropertyName again. It does not
23206 work for TYpeBuilders though. Ravi, can you please fix this?
23208 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
23210 * expression.cs (Argument.Emit): Handle the case of ref objects
23211 being passed to ref functions;
23213 (ParameterReference.EmitLoad): Loads the content of the pointer
23214 without dereferencing.
23216 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23218 * cs-tokenizer.cs: Implemented the pre-processing expressions.
23220 2002-01-08 Ravi Pratap <ravi@ximian.com>
23222 * class.cs (Indexer.DefineMethod): Incorporate the interface
23223 type in the name of the method if we are doing explicit interface
23226 * expression.cs (ConversionExists): Remove as it is completely obsolete.
23228 (BetterConversion): Fix extremely trivial bug where we were referring to
23229 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
23232 * ../errors/bug16.cs : Add although we have fixed it.
23234 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23236 * expression.cs (BaseIndexer): Begin implementation.
23238 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
23240 * cs-parser.jay (indexer_declarator): Use qualified_identifier
23241 production directly to remove a shift/reduce, and implement
23242 explicit interface implementation.
23244 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
23245 after a floating point suffix.
23247 * expression.cs (DoNumericPromotions): Improved the conversion for
23248 uint/uint. If we have a constant, we avoid doing a typecast to a
23251 * class.cs (Indexer): Implement explicit interface implementation
23254 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
23256 * class.cs: make the default instance constructor public and hidebysig.
23258 2001-01-03 Ravi Pratap <ravi@ximian.com>
23260 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
23261 so we can call it from elsewhere.
23263 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
23264 we emit it internally if the class has a defined indexer; otherwise the user
23265 emits it by decorating the class definition with the DefaultMemberAttribute.
23267 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
23268 attribute is not used on a type which defines an indexer.
23270 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
23271 character when we skip whitespace.
23273 * ../errors/cs0646.cs : Add.
23275 2002-01-03 Miguel de Icaza <miguel@ximian.com>
23277 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
23280 * makefile: Add practical target `mcs3.exe' which builds the third
23281 generation compiler.
23283 * expression.cs (New): Fix structures constructor calling.
23285 * class.cs (Property, Method, Indexer): Emit Final flag on the
23286 method if we are an interface implementation and we are not
23289 * ecore.cs (PropertyExpr): New public field `IsBase', tells
23290 whether this property is referencing a `base' method.
23292 * expression.cs (Invocation.EmitCall): take an extra argument:
23293 is_base, this is used to determine whether the `call' or
23294 `callvirt' opcode should be used.
23297 * delegate.cs: update EmitCall.
23299 * class.cs (Method.Define): Set NewSlot for the cases where we are
23300 not implementing an interface method.
23302 (Property.Define): ditto.
23304 2002-01-02 Miguel de Icaza <miguel@ximian.com>
23306 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
23307 'r'. Allows mcs to parse itself fully.
23309 2002-01-02 Ravi Pratap <ravi@ximian.com>
23311 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
23312 of the number of initializers that require the InitializeArray method.
23314 (CheckIndices): Store the Expression in all cases - not the plain value. Also
23315 update the above field where necessary.
23317 (MakeByteBlob): Update accordingly.
23319 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
23322 (EmitDynamicInitializers): Update in accordance with the new optimization.
23324 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
23325 same OpCode applies.
23327 * cs-parser.jay : Fix some glaring errors I introduced.
23329 2002-01-01 Ravi Pratap <ravi@ximian.com>
23331 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
23332 so that we can check for name clashes there too.
23334 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
23335 for interface indexers.
23337 * interfaces.cs (Define): Emit the default member attribute.
23339 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
23340 variable was being referred to while setting the value ;-)
23342 2002-01-01 Miguel de Icaza <miguel@ximian.com>
23344 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
23345 byte-by-byte information when we know the data is zero.
23347 Make the block always a multiple of 4, because
23348 DefineInitializedData has a bug.
23350 * assign.cs: Fix, we should assign from the temporary, not from
23353 * expression.cs (MakeByteBlob): Fix my incorrect code.
23355 2001-12-31 Miguel de Icaza <miguel@ximian.com>
23357 * typemanager.cs (EnumToUnderlying): This function is used to get
23358 the underlying type from an enumeration, because it does not
23361 * constant.cs: Use the I4_S form for values between -128 and 127.
23363 * statement.cs (Block.LookupLabel): Looks up a label.
23364 (Block): Drop support for labeled blocks.
23366 (LabeledStatement): New kind of statement that represents a label
23369 (Goto): Finally implement this bad boy.
23371 * cs-parser.jay: Update to reflect new mechanism to implement
23374 2001-12-30 Miguel de Icaza <miguel@ximian.com>
23376 * codegen.cs (EmitContext.This): a codegen property that keeps the
23377 a single instance of this instead of creating many different this
23380 * delegate.cs (Delegate.DoResolve): Update to use the property;
23382 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
23384 * expression.cs (BaseAccess.DoResolve): Ditto.
23386 2001-12-29 Ravi Pratap <ravi@ximian.com>
23388 * typemanager.cs (methodimpl_attr_type): Add to hold the type
23389 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
23391 (InitCoreTypes): Update accordingly.
23393 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
23394 so we can quickly store the state.
23396 (ApplyAttributes): Set the correct implementation flags
23397 for InternalCall methods.
23399 2001-12-29 Miguel de Icaza <miguel@ximian.com>
23401 * expression.cs (EmitCall): if a method is not virtual, then do
23402 not use callvirt on it.
23404 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
23405 user defined stuff) requires the use of stobj, which takes an
23406 address on the stack instead of an array and an index. So emit
23407 the Ldelema operation for it.
23409 (EmitStoreOpcode): Use stobj for valuetypes.
23411 (UnaryMutator.EmitCode): Use the right 1 value depending on
23412 whether we are dealing with int64/uint64, float or doubles.
23414 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
23415 constructors that I implemented last night.
23417 (Constructor.IsDefault): Fix to work properly for static
23420 * cs-parser.jay (CheckDef): report method signature errors.
23421 Update error number 103 to be 132.
23423 * decl.cs: New AdditionResult enumeration value: MethodExists.
23424 Although we do this check for methods later on in the semantic
23425 analysis, catching repeated default constructors is so easy that
23426 we catch these here.
23428 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
23431 (ParameterReference.EmitAssign, Emit): handle
23434 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
23435 (ArrayAccess.EmitStoreOpcode): ditto.
23437 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
23439 * expression.cs (MakeByteBlob): Complete all the missing types
23440 (uint, short, ushort, byte, sbyte)
23442 * class.cs: Only init instance field initializers on instance
23445 Rename `constructors' to instance_constructors.
23447 (TypeContainer.AddConstructor): Only add constructors to the list
23448 if it is not static.
23450 Make sure that we handle default_static_constructor independently
23451 everywhere where we handle instance_constructors
23453 2001-12-28 Miguel de Icaza <miguel@ximian.com>
23455 * class.cs: Do not lookup or create a base initializer for a
23456 static constructor.
23458 (ConstructorInitializer.Resolve): use the proper type to lookup
23461 * cs-parser.jay: Report error 1585 (modifiers between type and name).
23463 * enum.cs, interface.cs: Remove CloseType, this is taken care by
23466 * decl.cs: CloseType is now an virtual method, the default
23467 implementation just closes this type.
23469 2001-12-28 Ravi Pratap <ravi@ximian.com>
23471 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
23472 to PreserveSig by default. Also emit HideBySig on such methods.
23474 Basically, set the defaults to standard values.
23476 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
23477 argument, if candidate is better, it can't be worse than the best !
23479 (Invocation): Re-write bits to differentiate between methods being
23480 applicable in their expanded form and their normal form - for params
23483 Get rid of use_standard everywhere as only standard conversions are allowed
23484 in overload resolution.
23486 More spec conformance.
23488 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23490 * driver.cs: Add --timestamp, to see where the compiler spends
23493 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
23494 `this' in static code.
23496 (SimpleName.DoResolve): Implement in terms of a helper function
23497 that allows static-references to be passed upstream to
23500 (Expression.ResolveWithSimpleName): Resolve specially simple
23501 names when called by MemberAccess to implement the special
23504 (Expression.ImplicitReferenceConversion): Handle conversions from
23505 Null to reference types before others, as Null's type is
23508 * expression.cs (Invocation.EmitCall): Handle the special case of
23509 calling methods declared on a reference type from a ValueType
23510 (Base classes System.Object and System.Enum)
23512 (MemberAccess.Resolve): Only perform lookups on Enumerations if
23513 the left hand side is a TypeExpr, not on every enumeration.
23515 (Binary.Resolve): If types are reference types, then do a cast to
23516 object on operators != and == of both arguments.
23518 * typemanager.cs (FindMembers): Extract instance and static
23519 members if requested.
23521 * interface.cs (PopulateProperty): Use void_type instead of null
23522 as the return type for the setter method.
23524 (PopulateIndexer): ditto.
23526 2001-12-27 Ravi Pratap <ravi@ximian.com>
23528 * support.cs (ReflectionParameters): Fix minor bug where we
23529 were examining the wrong parameter for the ParamArray attribute.
23531 Cope with requests for the type of the parameter at position
23532 greater than the params parameter's. We now return the element
23533 type of the params array as that makes more sense.
23535 * expression.cs (Invocation.IsParamsMethodApplicable): Update
23536 accordingly as we no longer have to extract the element type
23539 (Invocation.OverloadResolve): Update.
23541 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23543 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
23544 against IEnumerator, test whether the return value is a descendant
23545 of the IEnumerator interface.
23547 * class.cs (Indexer.Define): Use an auxiliary method to implement
23548 the other bits of the method definition. Begin support for
23549 explicit interface implementation.
23551 (Property.DefineMethod): Use TypeManager.void_type instead of null
23552 for an empty return value.
23554 2001-12-26 Miguel de Icaza <miguel@ximian.com>
23556 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
23557 dealing with a FieldExpr which is composed of a FieldBuilder, in
23558 the code path we did extract the constant, but we should have
23559 obtained the underlying value to be able to cast it (otherwise we
23560 end up in an infinite loop, this is what Ravi was running into).
23562 (ArrayCreation.UpdateIndices): Arrays might be empty.
23564 (MemberAccess.ResolveMemberAccess): Add support for section
23565 14.5.4.1 that deals with the special case of E.I when E is a type
23566 and something else, that I can be a reference to a static member.
23568 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
23569 handle a particular array type to create byte blobs, it is just
23570 something we dont generate byteblobs for.
23572 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
23575 * location.cs (Push): remove the key from the hashtable that we
23576 are about to add. This happens for empty files.
23578 * driver.cs: Dispose files after we have parsed them.
23580 (tokenize): new function that only runs the tokenizer on its
23581 input, for speed testing.
23583 2001-12-26 Ravi Pratap <ravi@ximian.com>
23585 * class.cs (Event.Define): Define the private field only if there
23586 are no accessors defined.
23588 * expression.cs (ResolveMemberAccess): If there is no associated
23589 field with the event, that means we have an event defined with its
23590 own accessors and we should flag error cs0070 since transforming
23591 ourselves into a field is not valid in that case.
23593 * ecore.cs (SimpleName.DoResolve): Same as above.
23595 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
23596 and charset to sane values.
23598 2001-12-25 Ravi Pratap <ravi@ximian.com>
23600 * assign.cs (DoResolve): Perform check on events only if they
23601 are being accessed outside the declaring type.
23603 * cs-parser.jay (event_declarations): Update rules to correctly
23604 set the type of the implicit parameter etc.
23606 (add_accessor, remove_accessor): Set current local parameters.
23608 * expression.cs (Binary): For delegate addition and subtraction,
23609 cast the return value from the method into the appropriate delegate
23612 2001-12-24 Ravi Pratap <ravi@ximian.com>
23614 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
23615 of these as the workaround is unnecessary.
23617 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
23618 delegate data - none of that is needed at all.
23620 Re-write bits to extract the instance expression and the delegate method
23623 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
23626 * attribute.cs (ApplyAttributes): New method to take care of common tasks
23627 of attaching attributes instead of duplicating code everywhere.
23629 * everywhere : Update code to do attribute emission using the above method.
23631 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23633 * expression.cs (IsParamsMethodApplicable): if there are not
23634 parameters, return immediately.
23636 * ecore.cs: The 0 literal can be implicity converted to an enum
23639 (SimpleName.DoResolve): First lookup the type, then lookup the
23642 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
23643 want to get its address. If the InstanceExpression is not
23644 addressable, store the result in a temporary variable, then get
23647 * codegen.cs: Only display 219 errors on warning level or above.
23649 * expression.cs (ArrayAccess): Make it implement the
23650 IMemoryLocation interface.
23652 (Binary.DoResolve): handle the operator == (object a, object b)
23653 and operator != (object a, object b) without incurring into a
23654 BoxedCast (because 5 != o should never be performed).
23656 Handle binary enumerator operators.
23658 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
23659 value type, otherwise use Ldelem_ref.
23661 Use precomputed names;
23663 (AddressOf): Implement address of
23665 * cs-parser.jay (labeled_statement): Fix recursive block
23666 addition by reworking the production.
23668 * expression.cs (New.DoEmit): New has a special case:
23670 If we are dealing with a ValueType, we have a few
23671 situations to deal with:
23673 * The target of New is a ValueType variable, that is
23674 easy, we just pass this as the variable reference
23676 * The target of New is being passed as an argument,
23677 to a boxing operation or a function that takes a
23680 In this case, we need to create a temporary variable
23681 that is the argument of New.
23684 2001-12-23 Ravi Pratap <ravi@ximian.com>
23686 * rootcontext.cs (LookupType): Check that current_type is not null before
23687 going about looking at nested types.
23689 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
23690 not implement the IAssignMethod interface any more.
23692 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
23693 where we tranform them into FieldExprs if they are being resolved from within
23694 the declaring type.
23696 * ecore.cs (SimpleName.DoResolve): Do the same here.
23698 * assign.cs (DoResolve, Emit): Clean up code considerably.
23700 * ../errors/bug10.cs : Add.
23702 * ../errors/cs0070.cs : Add.
23704 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
23706 * assign.cs : Get rid of EventIsLocal everywhere.
23708 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23710 * ecore.cs (ConvertIntLiteral): finished the implementation.
23712 * statement.cs (SwitchLabel): Convert the value we are using as a
23713 key before looking up the table.
23715 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23717 * codegen.cs (EmitTopBlock): Require a Location argument now.
23719 * cs-parser.jay (constructor_declarator): We need to setup
23720 current_local_parameters before we parse the
23721 opt_constructor_initializer, to allow the variables to be bound
23722 to the constructor arguments.
23724 * rootcontext.cs (LookupType): First lookup nested classes in our
23725 class and our parents before we go looking outside our class.
23727 * expression.cs (ConstantFold): Extract/debox the values at the
23730 * rootcontext.cs (EmitCode): Resolve the constants first before we
23731 resolve the types. This is not really needed, but it helps debugging.
23733 * statement.cs: report location.
23735 * cs-parser.jay: pass location to throw statement.
23737 * driver.cs: Small bug fix.
23739 * report.cs: Updated format to be 4-zero filled digits.
23741 2001-12-22 Ravi Pratap <ravi@ximian.com>
23743 * expression.cs (CheckIndices): Fix minor bug where the wrong
23744 variable was being referred to ;-)
23746 (DoEmit): Do not call EmitStaticInitializers when the
23747 underlying type is System.Object.
23749 2001-12-21 Ravi Pratap <ravi@ximian.com>
23751 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23752 and do the usual workaround for SRE.
23754 * class.cs (MyEventBuilder.EventType): New member to get at the type
23755 of the event, quickly.
23757 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23759 * assign.cs (Assign.DoResolve): Handle the case when the target
23760 is an EventExpr and perform the necessary checks.
23762 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23765 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23767 (EventExpr): Set the type in the constructor itself since we
23768 are meant to be born fully resolved.
23770 (EventExpr.Define): Revert code I wrote earlier.
23772 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23773 instance expression is null. The instance expression is a This in that case
23774 or a null, depending on whether it is a static method or not.
23776 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23777 refers to more than one method.
23779 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23780 and accordingly flag errors.
23782 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23784 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23786 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23788 * location.cs (ToString): Provide useful rutine.
23790 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23792 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23793 objects, return the actual integral boxed.
23795 * statement.cs (SwitchLabel): define an ILLabel for each
23798 (Switch.CheckSwitch): If the value is a Literal, extract
23799 the underlying literal.
23801 Also in the unused hashtable we had, add the SwitchLabel so we can
23802 quickly look this value up.
23804 * constant.cs: Implement a bunch of new constants. Rewrite
23805 Literal based on this. Made changes everywhere to adapt to this.
23807 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23808 dereferencing array only once, and also copes with enumrations.
23810 bytes are two bytes wide, not one.
23812 (Cast): Perform constant conversions.
23814 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23815 wrappers to the literals here.
23817 * expression.cs (DoNumericPromotions): long literals can converted
23818 to ulong implicity (this is taken care of elsewhere, but I was
23819 missing this spot).
23821 * ecore.cs (Expression.Literalize): Make the return type Literal,
23822 to improve type checking.
23824 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23826 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23828 * literal.cs: Revert code from ravi that checked the bounds. The
23829 bounds are sane by the definition of the type itself.
23831 * typemanager.cs: Fix implementation of ImplementsInterface. We
23832 need to actually look up in our parent hierarchy for interfaces
23835 * const.cs: Use the underlying type for enumerations
23837 * delegate.cs: Compute the basename for the delegate creation,
23838 that should fix the delegate test case, and restore the correct
23839 Type Lookup semantics in rootcontext
23841 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23842 referencing a nested type with the Reflection API is using the "+"
23845 * cs-parser.jay: Do not require EOF token at the end.
23847 2001-12-20 Ravi Pratap <ravi@ximian.com>
23849 * rootcontext.cs (LookupType): Concatenate type names with
23850 a '.' instead of a '+' The test suite passes again.
23852 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23853 field of the enumeration.
23855 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23856 the case when the member is an EventExpr.
23858 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23859 static has an associated instance expression.
23861 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23863 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23865 * class.cs (Event.Define): Register event and perform appropriate checks
23868 We define the Add and Remove methods even if the use provides none because
23869 in that case, we provide default implementations ourselves.
23871 Define a private field of the type of the event. This is done by the CSC compiler
23872 and we should be doing it too ;-)
23874 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23875 More methods we use in code we generate.
23877 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23880 (InitCoreTypes): Update accordingly for the above.
23882 * class.cs (Event.Emit): Generate code for default accessors that we provide
23884 (EmitDefaultMethod): Do the job in the above.
23886 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23889 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23891 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23892 builders even if we were missing one.
23894 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23895 pass the Basename as our class name instead of the Name. The
23896 basename will be correctly composed for us.
23898 * parameter.cs (Paramters): Now takes a Location argument.
23900 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23901 make all the code call directly LookupType in RootContext and take
23902 this chance to pass the Location information everywhere.
23904 * Everywhere: pass Location information.
23906 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23908 * class.cs (Constructor.Define): Updated way of detecting the
23909 length of the parameters.
23911 (TypeContainer.DefineType): Use basename as the type name for
23914 (TypeContainer.Define): Do not recursively define types here, as
23915 definition is taken care in order by the RootContext.
23917 * tree.cs: Keep track of namespaces in a per-file basis.
23919 * parameter.cs (Parameter.ComputeSignature): Update to use
23922 (Parameters.GetSignature): ditto.
23924 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23925 instead of a TypeContainer.
23927 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23928 resolve names. Because we need to be resolve in our context, not
23931 * driver.cs: Implement response files.
23933 * class.cs (TypeContainer.DefineType): If we are defined, do not
23934 redefine ourselves.
23936 (Event.Emit): Emit the code for add/remove handlers.
23937 (Event.Define): Save the MethodBuilders for add/remove.
23939 * typemanager.cs: Use pair here too.
23941 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23942 DictionaryEntry requires the first argument to be non-null.
23944 (enum_declaration): Compute full name for registering the
23947 (delegate_declaration): Instead of using
23948 formal_parameter_list, use opt_formal_parameter_list as the list
23951 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23952 (EventParsing): New property that controls whether `add' and
23953 `remove' are returned as tokens or identifiers (for events);
23955 2001-12-19 Ravi Pratap <ravi@ximian.com>
23957 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23958 use MyEventBuilder only and let it wrap the real builder for us.
23960 (MyEventBuilder): Revamp constructor etc.
23962 Implement all operations that we perform on EventBuilder in precisely the same
23965 (FindMembers): Update to use the EventBuilder member.
23967 (Event.Emit): Update accordingly.
23969 2001-12-18 Ravi Pratap <ravi@ximian.com>
23971 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23972 by calling the appropriate methods.
23974 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23977 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23979 2001-12-17 Ravi Pratap <ravi@ximian.com>
23981 * delegate.cs (Delegate.Populate): Check that the return type
23982 and various parameters types are indeed accessible.
23984 * class.cs (Constructor.Define): Same here.
23986 (Field.Define): Ditto.
23988 (Event.Define): Ditto.
23990 (Operator.Define): Check that the underlying Method defined itself
23991 correctly - so it's MethodBuilder should not be null.
23993 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23994 expression happens to be null.
23996 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23997 members but as of now we don't seem to be able to do anything really useful with it.
23999 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
24000 not the EventBuilder.
24002 2001-12-18 Miguel de Icaza <miguel@ximian.com>
24004 * cs-tokenizer.cs: Add support for defines.
24005 Add support for #if, #elif, #else, #endif
24007 (eval_var): evaluates a variable.
24008 (eval): stubbed for evaluating functions.
24010 * cs-parser.jay: Pass the defines information
24012 * driver.cs: Add --define command line option.
24014 * decl.cs: Move MemberCore here.
24016 Make it the base class for DeclSpace. This allows us to catch and
24017 report 108 and 109 for everything now.
24019 * class.cs (TypeContainer.Define): Extract all the members
24020 before populating and emit the warning 108 (new keyword required
24021 to override) instead of having each member implement this.
24023 (MemberCore.Define): New abstract method, we will be using this in
24024 the warning reporting engine in Populate.
24026 (Operator.Define): Adjust to new MemberCore protocol.
24028 * const.cs (Const): This does not derive from Expression, it is a
24029 temporary object we use to create fields, it is a MemberCore.
24031 * class.cs (Method.Define): Allow the entry point to be in a
24034 * driver.cs: Rewrite the argument handler to clean it up a bit.
24036 * rootcontext.cs: Made it just an auxiliary namespace feature by
24037 making everything static.
24039 * driver.cs: Adapt code to use RootContext type name instead of
24042 * delegate.cs: Remove RootContext argument.
24044 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
24047 * class.cs (Event.Define): The lookup can fail.
24049 * cs-tokenizer.cs: Begin implementation of pre-procesor.
24051 * expression.cs: Resolve the this instance before invoking the code.
24053 2001-12-17 Miguel de Icaza <miguel@ximian.com>
24055 * cs-parser.jay: Add a production in element_access that allows
24056 the thing to become a "type" reference. This way we can parse
24057 things like "(string [])" as a type.
24059 Note that this still does not handle the more complex rules of
24063 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
24065 * ecore.cs: (CopyNewMethods): new utility function used to
24066 assemble the list of methods from running FindMembers.
24068 (MemberLookup): Rework FindMembers so that
24070 2001-12-16 Miguel de Icaza <miguel@ximian.com>
24072 * class.cs (TypeContainer): Remove Delegates who fail to be
24075 * delegate.cs (Populate): Verify that we dont get null return
24076 values. TODO: Check for AsAccessible.
24078 * cs-parser.jay: Use basename to emit error 574 (destructor should
24079 have the same name as container class), not the full name.
24081 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
24082 possible representation.
24084 Also implements integer type suffixes U and L.
24086 2001-12-15 Miguel de Icaza <miguel@ximian.com>
24088 * expression.cs (ArrayCreation.DoResolve): We need to do the
24089 argument resolution *always*.
24091 * decl.cs: Make this hold the namespace. Hold the root context as
24093 (LookupType): Move here.
24095 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
24097 * location.cs (Row, Name): Fixed the code, it was always returning
24098 references to the first file.
24100 * interface.cs: Register properties defined through interfaces.
24102 * driver.cs: Add support for globbing on the command line
24104 * class.cs (Field): Make it derive from MemberCore as well.
24107 2001-12-15 Ravi Pratap <ravi@ximian.com>
24109 * class.cs (Event::Define): Check that the type of the event is a delegate
24110 type else flag error #66.
24112 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
24115 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
24116 values of EntryPoint, CharSet etc etc.
24118 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
24120 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
24121 be null and we should ignore this. I am not sure if this is really clean. Apparently,
24122 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
24123 which needs this to do its work.
24125 * ../errors/cs0066.cs : Add.
24127 2001-12-14 Miguel de Icaza <miguel@ximian.com>
24129 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
24132 * class.cs: (MethodSignature.MethodSignature): Removed hack that
24133 clears out the parameters field.
24134 (MemberSignatureCompare): Cleanup
24136 (MemberCore): New base class used to share code between MethodCore
24139 (RegisterRequiredImplementations) BindingFlags.Public requires
24140 either BindingFlags.Instace or Static. Use instance here.
24142 (Property): Refactored code to cope better with the full spec.
24144 * parameter.cs (GetParameterInfo): Return an empty array instead
24147 * class.cs (Property): Abstract or extern properties have no bodies.
24149 * parameter.cs (GetParameterInfo): return a zero-sized array.
24151 * class.cs (TypeContainer.MethodModifiersValid): Move all the
24152 method modifier validation to the typecontainer so we can reuse
24153 this on properties.
24155 (MethodCore.ParameterTypes): return an empty sized array of types.
24157 (Property.Define): Test property modifier validity.
24159 Add tests for sealed/override too.
24161 (Method.Emit): abstract or extern methods have no bodies.
24163 2001-12-14 Ravi Pratap <ravi@ximian.com>
24165 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
24168 (Method::Define, ::Emit): Modify accordingly.
24170 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
24172 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
24174 * makefile: Pass in /unsafe.
24176 2001-12-13 Miguel de Icaza <miguel@ximian.com>
24178 * class.cs (MakeKey): Kill routine.
24180 * class.cs (TypeContainer.Define): Correctly define explicit
24181 method implementations (they require the full interface name plus
24184 * typemanager.cs: Deply the PtrHashtable here and stop using the
24185 lame keys. Things work so much better.
24187 This of course broke everyone who depended on `RegisterMethod' to
24188 do the `test for existance' test. This has to be done elsewhere.
24190 * support.cs (PtrHashtable): A hashtable that avoid comparing with
24191 the object stupid Equals method (because, that like fails all over
24192 the place). We still do not use it.
24194 * class.cs (TypeContainer.SetRequiredInterface,
24195 TypeContainer.RequireMethods): Killed these two routines and moved
24196 all the functionality to RegisterRequiredImplementations.
24198 (TypeContainer.RegisterRequiredImplementations): This routine now
24199 registers all the implementations required in an array for the
24200 interfaces and abstract methods. We use an array of structures
24201 which can be computed ahead of time to reduce memory usage and we
24202 also assume that lookups are cheap as most classes will not
24203 implement too many interfaces.
24205 We also avoid creating too many MethodSignatures.
24207 (TypeContainer.IsInterfaceMethod): Update and optionally does not
24208 clear the "pending" bit if we find that there are problems with
24211 (TypeContainer.VerifyPendingMethods): Update to report errors of
24212 methods that look like implementations but are not.
24214 (TypeContainer.Define): Add support for explicit interface method
24217 2001-12-12 Miguel de Icaza <miguel@ximian.com>
24219 * typemanager.cs: Keep track of the parameters here instead of
24220 being a feature of the TypeContainer.
24222 * class.cs: Drop the registration of parameters here, as
24223 InterfaceMethods are also interface declarations.
24225 * delegate.cs: Register methods with the TypeManager not only with
24226 the TypeContainer. This code was buggy.
24228 * interface.cs: Full registation here.
24230 2001-12-11 Miguel de Icaza <miguel@ximian.com>
24232 * expression.cs: Remove reducer for binary expressions, it can not
24235 * const.cs: Put here the code that used to go into constant.cs
24237 * constant.cs: Put here the code for constants, this is a new base
24238 class for Literals.
24240 * literal.cs: Make Literal derive from Constant.
24242 2001-12-09 Miguel de Icaza <miguel@ximian.com>
24244 * statement.cs (Return.Emit): Report error 157 if the user
24245 attempts to return from a finally block.
24247 (Return.Emit): Instead of emitting a return, jump to the end of
24250 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
24251 LocalBuilder to store the result of the function. ReturnLabel is
24252 the target where we jump.
24255 2001-12-09 Radek Doulik <rodo@ximian.com>
24257 * cs-parser.jay: remember alias in current namespace
24259 * ecore.cs (SimpleName::DoResolve): use aliases for types or
24262 * class.cs (LookupAlias): lookup alias in my_namespace
24264 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
24266 (LookupAlias): lookup alias in this and if needed in parent
24269 2001-12-08 Miguel de Icaza <miguel@ximian.com>
24273 * rootcontext.cs: (ModuleBuilder) Made static, first step into
24274 making things static. I need this to avoid passing the
24275 TypeContainer when calling ParameterType.
24277 * support.cs (InternalParameters.ParameterType): Remove ugly hack
24278 that did string manipulation to compute the type and then call
24279 GetType. Use Parameter.ParameterType instead.
24281 * cs-tokenizer.cs: Consume the suffix for floating values.
24283 * expression.cs (ParameterReference): figure out whether this is a
24284 reference parameter or not. Kill an extra variable by computing
24285 the arg_idx during emission.
24287 * parameter.cs (Parameters.GetParameterInfo): New overloaded
24288 function that returns whether a parameter is an out/ref value or not.
24290 (Parameter.ParameterType): The type of the parameter (base,
24291 without ref/out applied).
24293 (Parameter.Resolve): Perform resolution here.
24294 (Parameter.ExternalType): The full type (with ref/out applied).
24296 * statement.cs (Using.Emit, Using.EmitExpression): Implement
24297 support for expressions on the using statement.
24299 2001-12-07 Miguel de Icaza <miguel@ximian.com>
24301 * statement.cs (Using.EmitLocalVariableDecls): Split the
24302 localvariable handling of the using statement.
24304 (Block.EmitMeta): Keep track of variable count across blocks. We
24305 were reusing slots on separate branches of blocks.
24307 (Try.Emit): Emit the general code block, we were not emitting it.
24309 Check the type of the declaration to be an IDisposable or
24310 something that can be implicity converted to it.
24312 Emit conversions if required.
24314 * ecore.cs (EmptyExpression): New utility class.
24315 (Expression.ImplicitConversionExists): New utility function.
24317 2001-12-06 Miguel de Icaza <miguel@ximian.com>
24319 * statement.cs (Using): Implement.
24321 * expression.cs (LocalVariableReference): Support read only variables.
24323 * statement.cs: Remove the explicit emit for the Leave opcode.
24324 (VariableInfo): Add a readonly field.
24326 2001-12-05 Miguel de Icaza <miguel@ximian.com>
24328 * ecore.cs (ConvCast): new class used to encapsulate the various
24329 explicit integer conversions that works in both checked and
24330 unchecked contexts.
24332 (Expression.ConvertNumericExplicit): Use new ConvCast class to
24333 properly generate the overflow opcodes.
24335 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24337 * statement.cs: The correct type for the EmptyExpression is the
24338 element_type, not the variable type. Ravi pointed this out.
24340 2001-12-04 Ravi Pratap <ravi@ximian.com>
24342 * class.cs (Method::Define): Handle PInvoke methods specially
24343 by using DefinePInvokeMethod instead of the usual one.
24345 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
24346 above to do the task of extracting information and defining the method.
24348 2001-12-04 Ravi Pratap <ravi@ximian.com>
24350 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
24351 of the condition for string type.
24353 (Emit): Move that here.
24355 (ArrayCreation::CheckIndices): Keep string literals in their expression
24358 (EmitDynamicInitializers): Handle strings appropriately.
24360 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24362 * codegen.cs (EmitContext): Replace multiple variables with a
24363 single pointer to the current Switch statement.
24365 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
24368 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24372 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
24375 (Foreach.Emit): Foreach on arrays was not setting
24376 up the loop variables (for break/continue).
24378 (GotoCase): Semi-implented.
24380 2001-12-03 Ravi Pratap <ravi@ximian.com>
24382 * attribute.cs (CheckAttribute): Handle system attributes by using
24383 Attribute.GetAttributes to examine information we need.
24385 (GetValidPlaces): Same here.
24387 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
24389 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
24391 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
24393 (Method::Define): Set appropriate flags if we have a DllImport attribute.
24395 (Method::Emit): Handle the case when we are a PInvoke method.
24397 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24399 * expression.cs: Use ResolveWithSimpleName on compound names.
24401 2001-12-02 Ravi Pratap <ravi@ximian.com>
24403 * constant.cs (EmitConstant): Make sure we resolve the associated expression
24404 before trying to reduce it.
24406 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
24408 * constant.cs (LookupConstantValue): Implement.
24410 (EmitConstant): Use the above in emitting the constant.
24412 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
24413 that are user-defined by doing a LookupConstantValue on them.
24415 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
24418 2001-11-29 Miguel de Icaza <miguel@ximian.com>
24420 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
24422 (BaseAccess.DoResolve): Implement.
24424 (MemberAccess.DoResolve): Split this routine into a
24425 ResolveMemberAccess routine that can be used independently
24427 2001-11-28 Miguel de Icaza <miguel@ximian.com>
24429 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
24430 As that share bits of the implementation. Is returns a boolean,
24431 while As returns the Type that is being probed.
24433 2001-12-01 Ravi Pratap <ravi@ximian.com>
24435 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
24436 instead of a Literal - much easier.
24438 (EnumInTransit): Remove - utterly useless :-)
24440 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
24442 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
24444 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
24445 chain when we have no associated expression.
24447 2001-11-30 Ravi Pratap <ravi@ximian.com>
24449 * constant.cs (Define): Use Location while reporting the errror.
24451 Also emit a warning when 'new' is used and there is no inherited
24454 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
24457 (LookupEnumValue): Implement to lookup an enum member's value and define it
24460 (Populate): Re-write accordingly to use the above routine.
24462 2001-11-27 Miguel de Icaza <miguel@ximian.com>
24464 * expression.cs (This): Fix prototype for DoResolveLValue to
24465 override the base class DoResolveLValue.
24467 * cs-parser.cs: Report errors cs574 and cs575 (destructor
24470 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
24471 (we need to load the address of the field here). This fixes
24474 (FieldExpr.DoResolveLValue): Call the DoResolve
24475 function to initialize the Instance expression.
24477 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
24478 correctly the GetEnumerator operation on a value type.
24480 * cs-parser.jay: Add more simple parsing error catches.
24482 * statement.cs (Switch): Add support for string switches.
24483 Handle null specially.
24485 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
24487 2001-11-28 Ravi Pratap <ravi@ximian.com>
24489 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
24491 (declare_local_constant): New helper function.
24493 * statement.cs (AddConstant): Keep a separate record of constants
24495 (IsConstant): Implement to determine if a variable is a constant.
24497 (GetConstantExpression): Implement.
24499 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
24501 * statement.cs (IsVariableDefined): Re-write.
24503 2001-11-27 Ravi Pratap <ravi@ximian.com>
24505 * class.cs (TypeContainer::FindMembers): Look for constants
24506 in the case when we are looking for MemberTypes.Field
24508 * expression.cs (MemberAccess::DoResolve): Check that in the
24509 case we are a FieldExpr and a Literal, we are not being accessed
24510 by an instance reference.
24512 * cs-parser.jay (local_constant_declaration): Implement.
24514 (declaration_statement): Implement for constant declarations.
24516 2001-11-26 Miguel de Icaza <miguel@ximian.com>
24518 * statement.cs (Switch): Catch double defaults.
24520 (Switch): More work on the switch() statement
24521 implementation. It works for integral values now, need to finish
24525 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24527 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
24528 integer literals into other integer literals. To be used by
24531 2001-11-24 Ravi Pratap <ravi@ximian.com>
24533 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
24536 (EmitDynamicInitializers): Cope with the above since we extract data
24537 directly from ArrayData now.
24539 (ExpectInitializers): Keep track of whether initializers are mandatory
24542 (Bounds): Make it a hashtable to prevent the same dimension being
24543 recorded for every element in that dimension.
24545 (EmitDynamicInitializers): Fix bug which prevented the Set array method
24548 Also fix bug which was causing the indices to be emitted in the reverse
24551 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24553 * expression.cs (ArrayCreation): Implement the bits that Ravi left
24554 unfinished. They do not work, because the underlying code is
24557 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24559 * cs-parser.jay: Remove bogus fixme.
24561 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
24562 on Switch statement.
24564 2001-11-23 Ravi Pratap <ravi@ximian.com>
24566 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
24569 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
24570 parameter. Apparently, any expression is allowed.
24572 (ValidateInitializers): Update accordingly.
24574 (CheckIndices): Fix some tricky bugs thanks to recursion.
24576 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
24577 I was being completely brain-dead.
24579 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
24580 and re-write acordingly.
24582 (DelegateInvocation): Re-write accordingly.
24584 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
24586 (MakeByteBlob): Handle types more correctly.
24588 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
24589 initialization from expressions but it is incomplete because I am a complete
24592 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24594 * statement.cs (If.Emit): Fix a bug that generated incorrect code
24595 on If. Basically, we have to return `true' (ie, we do return to
24596 our caller) only if both branches of the if return.
24598 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
24599 short-circuit operators, handle them as short circuit operators.
24601 (Cast.DoResolve): Resolve type.
24602 (Cast.Cast): Take an expression as the target type.
24604 * cs-parser.jay (cast_expression): Remove old hack that only
24605 allowed a limited set of types to be handled. Now we take a
24606 unary_expression and we resolve to a type during semantic
24609 Use the grammar productions from Rhys to handle casts (this is
24610 not complete like Rhys syntax yet, we fail to handle that corner
24611 case that C# has regarding (-x), but we will get there.
24613 2001-11-22 Ravi Pratap <ravi@ximian.com>
24615 * class.cs (EmitFieldInitializer): Take care of the case when we have a
24616 field which is an array type.
24618 * cs-parser.jay (declare_local_variables): Support array initialization too.
24620 * typemanager.cs (MakeKey): Implement.
24622 (everywhere): Use the above appropriately.
24624 * cs-parser.jay (for_statement): Update for array initialization while
24625 declaring variables.
24627 * ecore.cs : The error message was correct, it's the variable's names that
24628 were misleading ;-) Make the code more readable.
24630 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
24631 the correct type etc.
24633 (ConvertExplicit): Handle Enum types by examining the underlying type.
24635 2001-11-21 Ravi Pratap <ravi@ximian.com>
24637 * parameter.cs (GetCallingConvention): Always return
24638 CallingConventions.Standard for now.
24640 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24642 * expression.cs (Binary.ResolveOperator): Update the values of `l'
24643 and `r' after calling DoNumericPromotions.
24645 * ecore.cs: Fix error message (the types were in the wrong order).
24647 * statement.cs (Foreach.ProbeCollectionType): Need to pass
24648 BindingFlags.Instance as well
24650 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
24651 implicit int literal conversion in an empty cast so that we
24652 propagate the right type upstream.
24654 (UnboxCast): new class used to unbox value types.
24655 (Expression.ConvertExplicit): Add explicit type conversions done
24658 (Expression.ImplicitNumericConversion): Oops, forgot to test for
24659 the target type before applying the implicit LongLiterals to ULong
24662 2001-11-21 Miguel de Icaza <miguel@ximian.com>
24664 * cs-parser.jay (for_statement): Reworked the way For works: now
24665 we declare manually any variables that are introduced in
24666 for_initializer to solve the problem of having out-of-band code
24667 emition (that is what got for broken).
24669 (declaration_statement): Perform the actual variable declaration
24670 that used to be done in local_variable_declaration here.
24672 (local_variable_declaration): Do not declare anything, just pass
24673 the information on a DictionaryEntry
24675 2001-11-20 Ravi Pratap <ravi@ximian.com>
24677 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
24678 re-write of the logic to now make it recursive.
24680 (UpdateIndices): Re-write accordingly.
24682 Store element data in a separate ArrayData list in the above methods.
24684 (MakeByteBlob): Implement to dump the array data into a byte array.
24686 2001-11-19 Ravi Pratap <ravi@ximian.com>
24688 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
24691 * constant.cs (Define): Implement.
24693 (EmitConstant): Re-write fully.
24695 Pass in location info.
24697 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
24700 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
24701 DictionaryEntry since we need location info too.
24703 (constant_declaration): Update accordingly.
24705 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
24706 code into another method : UpdateIndices.
24708 2001-11-18 Ravi Pratap <ravi@ximian.com>
24710 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
24711 some type checking etc.
24713 2001-11-17 Ravi Pratap <ravi@ximian.com>
24715 * expression.cs (ArrayCreation::ValidateInitializers): Implement
24716 bits to provide dimension info if the user skips doing that.
24718 Update second constructor to store the rank correctly.
24720 2001-11-16 Ravi Pratap <ravi@ximian.com>
24722 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
24723 and try to implement.
24725 * ../errors/cs0150.cs : Add.
24727 * ../errors/cs0178.cs : Add.
24729 2001-11-16 Miguel de Icaza <miguel@ximian.com>
24731 * statement.cs: Implement foreach on multi-dimensional arrays.
24733 * parameter.cs (Parameters.GetParameterByName): Also lookup the
24734 name of the params argument.
24736 * expression.cs: Use EmitStoreOpcode to get the right opcode while
24737 initializing the array.
24739 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
24740 we can use this elsewhere.
24742 * statement.cs: Finish implementation of foreach for single
24745 * cs-parser.jay: Use an out-of-band stack to pass information
24746 around, I wonder why I need this.
24748 foreach_block: Make the new foreach_block the current_block.
24750 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
24751 function used to return a static Parameters structure. Used for
24752 empty parameters, as those are created very frequently.
24754 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24756 2001-11-15 Ravi Pratap <ravi@ximian.com>
24758 * interface.cs : Default modifier is private, not public. The
24759 make verify test passes again.
24761 2001-11-15 Ravi Pratap <ravi@ximian.com>
24763 * support.cs (ReflectionParameters): Fix logic to determine
24764 whether the last parameter is a params one. Test 9 passes again.
24766 * delegate.cs (Populate): Register the builders we define with
24767 RegisterParameterForBuilder. Test 19 passes again.
24769 * cs-parser.jay (property_declaration): Reference $6 instead
24770 of $$ to get at the location.
24772 (indexer_declaration): Similar stuff.
24774 (attribute): Ditto.
24776 * class.cs (Property): Register parameters for the Get and Set methods
24777 if they exist. Test 23 passes again.
24779 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24780 call to EmitArguments as we are sure there aren't any params arguments.
24781 Test 32 passes again.
24783 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24784 IndexOutOfRangeException.
24786 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24787 Test 33 now passes again.
24789 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24791 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24792 broke a bunch of things. Will have to come up with a better way
24793 of tracking locations.
24795 * statement.cs: Implemented foreach for single dimension arrays.
24797 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24799 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24800 an error. This removes the lookup from the critical path.
24802 * cs-parser.jay: Removed use of temporary_loc, which is completely
24805 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24807 * support.cs (ReflectionParameters.ParameterModifier): Report
24808 whether the argument is a PARAMS argument or not.
24810 * class.cs: Set the attribute `ParamArrayAttribute' on the
24811 parameter argument.
24813 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24814 and cons_param_array_attribute (ConstructorInfo for
24815 ParamArrayAttribute).,
24817 * codegen.cs: Emit the return using the `Return' statement, that
24818 way we can report the error correctly for missing return values.
24820 * class.cs (Method.Emit): Clean up.
24822 * expression.cs (Argument.Resolve): Take another argument: the
24823 location where this argument is used. Notice that this is not
24824 part of the "Argument" class as to reduce the size of the
24825 structure (we know the approximate location anyways).
24827 Test if the argument is a variable-reference, if not, then
24828 complain with a 206.
24830 (Argument.Emit): Emit addresses of variables.
24832 (Argument.FullDesc): Simplify.
24834 (Invocation.DoResolve): Update for Argument.Resolve.
24836 (ElementAccess.DoResolve): ditto.
24838 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24839 method should be virtual, as this method is always virtual.
24841 (NewDelegate.DoResolve): Update for Argument.Resolve.
24843 * class.cs (ConstructorInitializer.DoResolve): ditto.
24845 * attribute.cs (Attribute.Resolve): ditto.
24847 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24849 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24851 * expression.cs (ParameterReference): Drop IStackStorage and implement
24852 IAssignMethod instead.
24854 (LocalVariableReference): ditto.
24856 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24857 IAssignMethod instead.
24859 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24861 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24862 enumerations that are used in heavily used structures derive from
24863 byte in a laughable and pathetic attempt to reduce memory usage.
24864 This is the kind of pre-optimzations that you should not do at
24865 home without adult supervision.
24867 * expression.cs (UnaryMutator): New class, used to handle ++ and
24868 -- separatedly from the other unary operators. Cleans up the
24869 code, and kills the ExpressionStatement dependency in Unary.
24871 (Unary): Removed `method' and `Arguments' from this class, making
24872 it smaller, and moving it all to SimpleCall, so I can reuse this
24873 code in other locations and avoid creating a lot of transient data
24874 strucutres when not required.
24876 * cs-parser.jay: Adjust for new changes.
24878 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24880 * enum.cs (Enum.Populate): If there is a failure during
24883 * cs-parser.jay (opt_enum_base): we used to catch type errors
24884 here, but this is really incorrect. The type error should be
24885 catched during semantic analysis.
24887 2001-12-11 Ravi Pratap <ravi@ximian.com>
24889 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24890 current_local_parameters as expected since I, in my stupidity, had forgotten
24893 * attribute.cs (GetValidPlaces): Fix stupid bug.
24895 * class.cs (Method::Emit): Perform check on applicability of attributes.
24897 (Constructor::Emit): Ditto.
24899 (Field::Emit): Ditto.
24901 (Field.Location): Store location information.
24903 (Property, Event, Indexer, Operator): Ditto.
24905 * cs-parser.jay (field_declaration): Pass in location for each field.
24907 * ../errors/cs0592.cs : Add.
24909 2001-11-12 Ravi Pratap <ravi@ximian.com>
24911 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24913 (InitCoreTypes): Update accordingly.
24915 (RegisterAttrType, LookupAttr): Implement.
24917 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24918 info about the same.
24920 (Resolve): Update to populate the above as necessary.
24922 (Error592): Helper.
24924 (GetValidPlaces): Helper to the above.
24926 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24928 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24930 2001-11-12 Ravi Pratap <ravi@ximian.com>
24932 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24934 * ../errors/cs0617.cs : Add.
24936 2001-11-11 Ravi Pratap <ravi@ximian.com>
24938 * enum.cs (Emit): Rename to Populate to be more consistent with what
24939 we expect it to do and when exactly it is called.
24941 * class.cs, rootcontext.cs : Update accordingly.
24943 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24944 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24946 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24948 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24949 of a fieldinfo using the above, when dealing with a FieldBuilder.
24951 2001-11-10 Ravi Pratap <ravi@ximian.com>
24953 * ../errors/cs0031.cs : Add.
24955 * ../errors/cs1008.cs : Add.
24957 * ../errrors/cs0543.cs : Add.
24959 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24962 (FindMembers): Implement.
24964 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24965 enums and delegates too.
24967 (enum_types): Rename to builder_to_enum.
24969 (delegate_types): Rename to builder_to_delegate.
24971 * delegate.cs (FindMembers): Implement.
24973 2001-11-09 Ravi Pratap <ravi@ximian.com>
24975 * typemanager.cs (IsEnumType): Implement.
24977 * enum.cs (Emit): Re-write parts to account for the underlying type
24978 better and perform checking etc.
24980 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24981 of the underlying type.
24983 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24986 * enum.cs (error31): Helper to report error #31.
24988 * cs-parser.jay (enum_declaration): Store location of each member too.
24990 * enum.cs (member_to_location): New hashtable.
24992 (AddEnumMember): Update location hashtable.
24994 (Emit): Use the location of each member while reporting errors.
24996 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24998 * cs-parser.jay: A for_initializer if is a
24999 local_variable_declaration really ammount to have an implicit
25000 block with the variable declaration and no initializer for for.
25002 * statement.cs (For.Emit): Cope with null initializers.
25004 This fixes the infinite loop on for initializers.
25006 2001-11-08 Miguel de Icaza <miguel@ximian.com>
25008 * enum.cs: More cleanup.
25010 * ecore.cs: Remove dead code.
25012 * class.cs (Property.Emit): More simplification.
25013 (Event.Emit): ditto.
25015 Reworked to have less levels of indentation.
25017 2001-11-08 Ravi Pratap <ravi@ximian.com>
25019 * class.cs (Property): Emit attributes.
25029 * enum.cs (Emit): Ditto.
25031 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
25034 * class.cs (Field, Event, etc.): Move attribute generation into the
25035 Emit method everywhere.
25037 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
25038 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
25039 as we had no way of defining nested enums !
25041 * rootcontext.cs : Adjust code accordingly.
25043 * typemanager.cs (AddEnumType): To keep track of enum types separately.
25045 2001-11-07 Ravi Pratap <ravi@ximian.com>
25047 * expression.cs (EvalConstantExpression): Move into ecore.cs
25049 * enum.cs (Enum): Rename some members and make them public and readonly
25050 according to our convention.
25052 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
25055 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25057 (Enum::Emit): Write a simple version for now which doesn't try to compute
25058 expressions. I shall modify this to be more robust in just a while.
25060 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
25062 (TypeContainer::CloseType): Create the Enum types too.
25064 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
25066 * expression.cs (EvalConstantExpression): Get rid of completely.
25068 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
25069 user-defined values and other cases.
25071 (IsValidEnumLiteral): Helper function.
25073 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
25074 out there in the case we had a literal FieldExpr.
25076 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
25078 (Literalize): Revamp a bit to take two arguments.
25080 (EnumLiteral): New class which derives from Literal to wrap enum literals.
25082 2001-11-06 Ravi Pratap <ravi@ximian.com>
25084 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
25086 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
25088 (Resolve): Use the above to ensure we have proper initializers.
25090 2001-11-05 Ravi Pratap <ravi@ximian.com>
25092 * expression.cs (Expression::EvalConstantExpression): New method to
25093 evaluate constant expressions.
25095 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
25097 2001-11-07 Miguel de Icaza <miguel@ximian.com>
25099 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
25102 (Binary.ResolveOperator): Handle operator != (object a, object b)
25103 and operator == (object a, object b);
25105 (Binary.DoNumericPromotions): Indicate whether the numeric
25106 promotion was possible.
25108 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
25111 Made the ArrayAccess implement interface IAssignMethod instead of
25112 IStackStore as the order in which arguments are passed reflects
25115 * assign.cs: Instead of using expr.ExprClass to select the way of
25116 assinging, probe for the IStackStore/IAssignMethod interfaces.
25118 * typemanager.cs: Load InitializeArray definition.
25120 * rootcontext.cs (RootContext.MakeStaticData): Used to define
25121 static data that can be used to initialize arrays.
25123 2001-11-05 Miguel de Icaza <miguel@ximian.com>
25125 * expression.cs: Handle operator== and operator!= for booleans.
25127 (Conditioal.Reduce): Implement reducer for the ?: operator.
25129 (Conditional.Resolve): Implement dead code elimination.
25131 (Binary.Resolve): Catch string literals and return a new
25132 concatenated string.
25134 (Unary.Reduce): Implement reduction of unary expressions.
25136 * ecore.cs: Split out the expression core handling here.
25138 (Expression.Reduce): New method used to perform constant folding
25139 and CSE. This is needed to support constant-expressions.
25141 * statement.cs (Statement.EmitBoolExpression): Pass true and false
25142 targets, and optimize for !x.
25144 2001-11-04 Ravi Pratap <ravi@ximian.com>
25146 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
25147 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
25148 set custom atttributes.
25150 * literal.cs (Literal::GetValue): New abstract method to return the actual
25151 value of the literal, cast as an object.
25153 (*Literal): Implement GetValue method.
25155 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
25156 expressions to the arraylist but objects of type Argument.
25158 * class.cs (TypeContainer::Emit): Emit our attributes too.
25160 (Method::Emit, Constructor::Emit): Ditto.
25162 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
25163 to be ignoring earlier.
25165 2001-11-03 Ravi Pratap <ravi@ximian.com>
25167 * attribute.cs (AttributeSection::Define): Implement to do the business
25168 of constructing a CustomAttributeBuilder.
25170 (Attribute): New trivial class. Increases readability of code.
25172 * cs-parser.jay : Update accordingly.
25174 (positional_argument_list, named_argument_list, named_argument): New rules
25176 (attribute_arguments): Use the above so that we are more correct.
25178 2001-11-02 Ravi Pratap <ravi@ximian.com>
25180 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
25181 to perform all checks for a method with a params parameter.
25183 (Invocation::OverloadResolve): Update to use the above method and therefore
25184 cope correctly with params method invocations.
25186 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
25189 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
25190 constructors in our parent too because we can't afford to miss out on
25193 * attribute.cs (AttributeSection): New name for the class Attribute
25195 Other trivial changes to improve readability.
25197 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
25198 use the new class names.
25200 2001-11-01 Ravi Pratap <ravi@ximian.com>
25202 * class.cs (Method::Define): Complete definition for params types too
25204 (Indexer::Define): Ditto.
25206 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
25207 Cope everywhere with a request for info about the array parameter.
25209 2001-11-01 Ravi Pratap <ravi@ximian.com>
25211 * tree.cs (RecordNamespace): Fix up to check for the correct key.
25213 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
25214 local_variable_type to extract the string corresponding to the type.
25216 (local_variable_type): Fixup the action to use the new helper method.
25218 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
25221 * expression.cs : Clean out code which uses the above.
25223 2001-10-31 Ravi Pratap <ravi@ximian.com>
25225 * typemanager.cs (RegisterMethod): Check if we already have an existing key
25226 and bale out if necessary by returning a false.
25228 (RegisterProperty): Ditto.
25230 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
25231 and print out appropriate error messages.
25233 * interface.cs (everywhere): Ditto.
25235 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
25236 location to constructor.
25238 * class.cs (Property, Event, Indexer): Update accordingly.
25240 * ../errors/cs111.cs : Added.
25242 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
25243 of a method, as laid down by the spec.
25245 (Invocation::OverloadResolve): Use the above method.
25247 2001-10-31 Ravi Pratap <ravi@ximian.com>
25249 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
25250 now take a TypeContainer and a Parameters object.
25252 (ParameterData): Modify return type of ParameterModifier method to be
25253 Parameter.Modifier and not a string.
25255 (ReflectionParameters, InternalParameters): Update accordingly.
25257 * expression.cs (Argument::GetParameterModifier): Same here.
25259 * support.cs (InternalParameters::ParameterType): Find a better way of determining
25260 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
25261 symbol in it at all so maybe this is only for now.
25263 2001-10-30 Ravi Pratap <ravi@ximian.com>
25265 * support.cs (InternalParameters): Constructor now takes an extra argument
25266 which is the actual Parameters class.
25268 (ParameterDesc): Update to provide info on ref/out modifiers.
25270 * class.cs (everywhere): Update call to InternalParameters to pass in
25271 the second argument too.
25273 * support.cs (ParameterData): Add ParameterModifier, which is a method
25274 to return the modifier info [ref/out etc]
25276 (InternalParameters, ReflectionParameters): Implement the above.
25278 * expression.cs (Argument::ParameterModifier): Similar function to return
25279 info about the argument's modifiers.
25281 (Invocation::OverloadResolve): Update to take into account matching modifiers
25284 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
25285 a new SetFormalParameters object which we pass to InternalParameters.
25287 2001-10-30 Ravi Pratap <ravi@ximian.com>
25289 * expression.cs (NewArray): Merge into the ArrayCreation class.
25291 2001-10-29 Ravi Pratap <ravi@ximian.com>
25293 * expression.cs (NewArray): Merge classes NewBuiltinArray and
25294 NewUserdefinedArray into one as there wasn't much of a use in having
25297 * expression.cs (Argument): Change field's name to ArgType from Type.
25299 (Type): New readonly property which returns the proper type, taking into
25300 account ref/out modifiers.
25302 (everywhere): Adjust code accordingly for the above.
25304 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
25305 whether we are emitting for a ref or out parameter.
25307 * expression.cs (Argument::Emit): Use the above field to set the state.
25309 (LocalVariableReference::Emit): Update to honour the flag and emit the
25312 * parameter.cs (Attributes): Set the correct flags for ref parameters.
25314 * expression.cs (Argument::FullDesc): New function to provide a full desc.
25316 * support.cs (ParameterData): Add method ParameterDesc to the interface.
25318 (ReflectionParameters, InternalParameters): Implement the above method.
25320 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
25323 (Invocation::FullMethodDesc): Ditto.
25325 2001-10-29 Miguel de Icaza <miguel@ximian.com>
25327 * cs-parser.jay: Add extra production for the second form of array
25330 * expression.cs (ArrayCreation): Update to reflect the above
25333 * Small changes to prepare for Array initialization.
25335 2001-10-28 Miguel de Icaza <miguel@ximian.com>
25337 * typemanager.cs (ImplementsInterface): interface might be null;
25338 Deal with this problem;
25340 Also, we do store negative hits on the cache (null values), so use
25341 this instead of calling t.GetInterfaces on the type everytime.
25343 2001-10-28 Ravi Pratap <ravi@ximian.com>
25345 * typemanager.cs (IsBuiltinType): New method to help determine the same.
25347 * expression.cs (New::DoResolve): Get rid of array creation code and instead
25348 split functionality out into different classes.
25350 (New::FormArrayType): Move into NewBuiltinArray.
25352 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
25355 (NewBuiltinArray): New class to handle creation of built-in arrays.
25357 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
25358 account creation of one-dimensional arrays.
25360 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
25362 (NewUserdefinedArray::DoResolve): Implement.
25364 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
25366 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
25367 we maintain inside the TypeManager. This is necessary to perform lookups on the
25370 (LookupType): Update to perform GetType on the module builders too.
25372 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
25374 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
25376 2001-10-23 Ravi Pratap <ravi@ximian.com>
25378 * expression.cs (New::DoResolve): Implement guts of array creation.
25380 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
25382 2001-10-27 Miguel de Icaza <miguel@ximian.com>
25384 * expression.cs: Fix bug I introduced lsat night that broke
25387 (Expression.Resolve): Report a 246 error (can not resolve name)
25388 if we find a SimpleName in the stream.
25390 (Expression.ResolveLValue): Ditto.
25392 (Expression.ResolveWithSimpleName): This function is a variant of
25393 ResolveName, this one allows SimpleNames to be returned without a
25394 warning. The only consumer of SimpleNames is MemberAccess
25396 2001-10-26 Miguel de Icaza <miguel@ximian.com>
25398 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
25399 might arrive here. I have my doubts that this is correct.
25401 * statement.cs (Lock): Implement lock statement.
25403 * cs-parser.jay: Small fixes to support `lock' and `using'
25405 * cs-tokenizer.cs: Remove extra space
25407 * driver.cs: New flag --checked, allows to turn on integer math
25410 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
25411 Threading.Monitor.Exit
25413 2001-10-23 Miguel de Icaza <miguel@ximian.com>
25415 * expression.cs (IndexerAccess::DoResolveLValue): Set the
25416 Expression Class to be IndexerAccess.
25418 Notice that Indexer::DoResolve sets the eclass to Value.
25420 2001-10-22 Miguel de Icaza <miguel@ximian.com>
25422 * class.cs (TypeContainer::Emit): Emit code for indexers.
25424 * assign.cs (IAssignMethod): New interface implemented by Indexers
25425 and Properties for handling assignment.
25427 (Assign::Emit): Simplify and reuse code.
25429 * expression.cs (IndexerAccess, PropertyExpr): Implement
25430 IAssignMethod, clean up old code.
25432 2001-10-22 Ravi Pratap <ravi@ximian.com>
25434 * typemanager.cs (ImplementsInterface): New method to determine if a type
25435 implements a given interface. Provides a nice cache too.
25437 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
25440 (ConvertReferenceExplicit): Ditto.
25442 * delegate.cs (Delegate::Populate): Update to define the parameters on the
25443 various methods, with correct names etc.
25445 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
25446 Operator.UnaryNegation.
25448 * cs-parser.jay (operator_declarator): Be a little clever in the case where
25449 we have a unary plus or minus operator.
25451 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
25454 * everywhere : update accordingly.
25456 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
25459 * class.cs (Method::Define): For the case where we are implementing a method
25460 inherited from an interface, we need to set the MethodAttributes.Final flag too.
25461 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
25463 2001-10-21 Ravi Pratap <ravi@ximian.com>
25465 * interface.cs (FindMembers): Implement to work around S.R.E
25468 * typemanager.cs (IsInterfaceType): Implement.
25470 (FindMembers): Update to handle interface types too.
25472 * expression.cs (ImplicitReferenceConversion): Re-write bits which
25473 use IsAssignableFrom as that is not correct - it doesn't work.
25475 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
25476 and accordingly override EmitStatement.
25478 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
25479 using the correct logic :-)
25481 2001-10-19 Ravi Pratap <ravi@ximian.com>
25483 * ../errors/cs-11.cs : Add to demonstrate error -11
25485 2001-10-17 Miguel de Icaza <miguel@ximian.com>
25487 * assign.cs (Assign::Resolve): Resolve right hand side first, and
25488 then pass this as a hint to ResolveLValue.
25490 * expression.cs (FieldExpr): Add Location information
25492 (FieldExpr::LValueResolve): Report assignment to readonly
25495 (Expression::ExprClassFromMemberInfo): Pass location information.
25497 (Expression::ResolveLValue): Add new method that resolves an
25500 (Expression::DoResolveLValue): Default invocation calls
25503 (Indexers): New class used to keep track of indexers in a given
25506 (IStackStore): Renamed from LValue, as it did not really describe
25507 what this did. Also ResolveLValue is gone from this interface and
25508 now is part of Expression.
25510 (ElementAccess): Depending on the element access type
25512 * typemanager.cs: Add `indexer_name_type' as a Core type
25513 (System.Runtime.CompilerServices.IndexerNameAttribute)
25515 * statement.cs (Goto): Take a location.
25517 2001-10-18 Ravi Pratap <ravi@ximian.com>
25519 * delegate.cs (Delegate::VerifyDelegate): New method to verify
25520 if two delegates are compatible.
25522 (NewDelegate::DoResolve): Update to take care of the case when
25523 we instantiate a delegate from another delegate.
25525 * typemanager.cs (FindMembers): Don't even try to look up members
25526 of Delegate types for now.
25528 2001-10-18 Ravi Pratap <ravi@ximian.com>
25530 * delegate.cs (NewDelegate): New class to take care of delegate
25533 * expression.cs (New): Split the delegate related code out into
25534 the NewDelegate class.
25536 * delegate.cs (DelegateInvocation): New class to handle delegate
25539 * expression.cs (Invocation): Split out delegate related code into
25540 the DelegateInvocation class.
25542 2001-10-17 Ravi Pratap <ravi@ximian.com>
25544 * expression.cs (New::DoResolve): Implement delegate creation fully
25545 and according to the spec.
25547 (New::DoEmit): Update to handle delegates differently.
25549 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
25550 because of which we were printing out arguments in reverse order !
25552 * delegate.cs (VerifyMethod): Implement to check if the given method
25553 matches the delegate.
25555 (FullDelegateDesc): Implement.
25557 (VerifyApplicability): Implement.
25559 * expression.cs (Invocation::DoResolve): Update to accordingly handle
25560 delegate invocations too.
25562 (Invocation::Emit): Ditto.
25564 * ../errors/cs1593.cs : Added.
25566 * ../errors/cs1594.cs : Added.
25568 * delegate.cs (InstanceExpression, TargetMethod): New properties.
25570 2001-10-16 Ravi Pratap <ravi@ximian.com>
25572 * typemanager.cs (intptr_type): Core type for System.IntPtr
25574 (InitCoreTypes): Update for the same.
25576 (iasyncresult_type, asynccallback_type): Ditto.
25578 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
25581 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
25584 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
25585 the builders for the 4 members of a delegate type :-)
25587 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
25590 * expression.cs (New::DoResolve): Implement guts for delegate creation.
25592 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
25594 2001-10-15 Miguel de Icaza <miguel@ximian.com>
25596 * statement.cs (Break::Emit): Implement.
25597 (Continue::Emit): Implement.
25599 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
25600 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
25601 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
25602 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
25605 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
25606 properties that track the label for the current loop (begin of the
25607 loop and end of the loop).
25609 2001-10-15 Ravi Pratap <ravi@ximian.com>
25611 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
25612 use of emitting anything at all.
25614 * class.cs, rootcontext.cs : Get rid of calls to the same.
25616 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
25618 (Populate): Define the constructor correctly and set the implementation
25621 * typemanager.cs (delegate_types): New hashtable to hold delegates that
25624 (AddDelegateType): Implement.
25626 (IsDelegateType): Implement helper method.
25628 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
25630 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
25631 and accordingly handle it.
25633 * delegate.cs (Populate): Take TypeContainer argument.
25634 Implement bits to define the Invoke method. However, I still haven't figured out
25635 how to take care of the native int bit :-(
25637 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
25638 Qualify the name of the delegate, not its return type !
25640 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
25643 (StandardConversionExists): Checking for array types turns out to be recursive.
25645 (ConvertReferenceExplicit): Implement array conversion.
25647 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
25649 2001-10-12 Ravi Pratap <ravi@ximian.com>
25651 * cs-parser.jay (delegate_declaration): Store the fully qualified
25652 name as it is a type declaration.
25654 * delegate.cs (ReturnType, Name): Rename members to these. Make them
25657 (DefineDelegate): Renamed from Define. Does the same thing essentially,
25658 as TypeContainer::DefineType.
25660 (Populate): Method in which all the definition of the various methods (Invoke)
25663 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
25666 (CloseDelegate): Finally creates the delegate.
25668 * class.cs (TypeContainer::DefineType): Update to define delegates.
25669 (Populate, Emit and CloseType): Do the same thing here too.
25671 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
25672 delegates in all these operations.
25674 2001-10-14 Miguel de Icaza <miguel@ximian.com>
25676 * expression.cs: LocalTemporary: a new expression used to
25677 reference a temporary that has been created.
25679 * assign.cs: Handle PropertyAccess back here, so that we can
25680 provide the proper semantic access to properties.
25682 * expression.cs (Expression::ConvertReferenceExplicit): Implement
25683 a few more explicit conversions.
25685 * modifiers.cs: `NEW' modifier maps to HideBySig.
25687 * expression.cs (PropertyExpr): Make this into an
25688 ExpressionStatement, and support the EmitStatement code path.
25690 Perform get/set error checking, clean up the interface.
25692 * assign.cs: recognize PropertyExprs as targets, and if so, turn
25693 them into toplevel access objects.
25695 2001-10-12 Miguel de Icaza <miguel@ximian.com>
25697 * expression.cs: PropertyExpr::PropertyExpr: use work around the
25700 * typemanager.cs: Keep track here of our PropertyBuilders again to
25701 work around lameness in SRE.
25703 2001-10-11 Miguel de Icaza <miguel@ximian.com>
25705 * expression.cs (LValue::LValueResolve): New method in the
25706 interface, used to perform a second resolution pass for LValues.
25708 (This::DoResolve): Catch the use of this in static methods.
25710 (This::LValueResolve): Implement.
25712 (This::Store): Remove warning, assigning to `this' in structures
25715 (Invocation::Emit): Deal with invocation of
25716 methods on value types. We need to pass the address to structure
25717 methods rather than the object itself. (The equivalent code to
25718 emit "this" for structures leaves the entire structure on the
25719 stack instead of a pointer to it).
25721 (ParameterReference::DoResolve): Compute the real index for the
25722 argument based on whether the method takes or not a `this' pointer
25723 (ie, the method is static).
25725 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
25726 value types returned from functions when we need to invoke a
25727 method on the sturcture.
25730 2001-10-11 Ravi Pratap <ravi@ximian.com>
25732 * class.cs (TypeContainer::DefineType): Method to actually do the business of
25733 defining the type in the Modulebuilder or Typebuilder. This is to take
25734 care of nested types which need to be defined on the TypeBuilder using
25735 DefineNestedMethod.
25737 (TypeContainer::GetClassBases): Implement. Essentially the code from the
25738 methods in RootContext, only ported to be part of TypeContainer.
25740 (TypeContainer::GetInterfaceOrClass): Ditto.
25742 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
25744 * interface.cs (Interface::DefineInterface): New method. Does exactly
25745 what RootContext.CreateInterface did earlier, only it takes care of nested types
25748 (Interface::GetInterfaces): Move from RootContext here and port.
25750 (Interface::GetInterfaceByName): Same here.
25752 * rootcontext.cs (ResolveTree): Re-write.
25754 (PopulateTypes): Re-write.
25756 * class.cs (TypeContainer::Populate): Populate nested types too.
25757 (TypeContainer::Emit): Emit nested members too.
25759 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25760 instead just use the name argument passed in as it is already fully
25763 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25764 to TypeContainer mapping to see if a type is user-defined.
25766 * class.cs (TypeContainer::CloseType): Implement.
25768 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25769 the default constructor.
25771 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25774 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25776 * interface.cs (CloseType): Create the type here.
25778 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25781 Remove all the methods which are now in TypeContainer.
25783 2001-10-10 Ravi Pratap <ravi@ximian.com>
25785 * delegate.cs (Define): Re-write bits to define the delegate
25788 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25790 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25792 * expression.cs (ImplicitReferenceConversion): handle null as well
25793 as a source to convert to any reference type.
25795 * statement.cs (Return): Perform any implicit conversions to
25796 expected return type.
25798 Validate use of return statement.
25800 * codegen.cs (EmitContext): Pass the expected return type here.
25802 * class.cs (Method, Constructor, Property): Pass expected return
25803 type to EmitContext.
25805 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25807 * expression.cs: Make DoResolve take an EmitContext instead of a
25810 Replaced `l' and `location' for `loc', for consistency.
25812 (Error, Warning): Remove unneeded Tc argument.
25814 * assign.cs, literal.cs, constant.cs: Update to new calling
25817 * codegen.cs: EmitContext now contains a flag indicating whether
25818 code is being generated in a static method or not.
25820 * cs-parser.jay: DecomposeQI, new function that replaces the old
25821 QualifiedIdentifier. Now we always decompose the assembled
25822 strings from qualified_identifier productions into a group of
25825 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25827 * rootcontext.cs: Deal with field-less struct types correctly now
25828 by passing the size option to Define Type.
25830 * class.cs: Removed hack that created one static field.
25832 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25834 * statement.cs: Moved most of the code generation here.
25836 2001-10-09 Ravi Pratap <ravi@ximian.com>
25838 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25841 (ElementAccess): Remove useless bits for now - keep checks as the spec
25844 2001-10-08 Ravi Pratap <ravi@ximian.com>
25846 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25847 and start performing checks according to the spec.
25849 2001-10-07 Ravi Pratap <ravi@ximian.com>
25851 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25852 rank_specifiers instead.
25854 (rank_specifiers): Change the order in which the rank specifiers are stored
25856 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25858 * expression.cs (ElementAccess): Implement the LValue interface too.
25860 2001-10-06 Ravi Pratap <ravi@ximian.com>
25862 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25863 except that user defined conversions are not included.
25865 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25866 perform the conversion of the return type, if necessary.
25868 (New::DoResolve): Check whether we are creating an array or an object
25869 and accordingly do the needful.
25871 (New::Emit): Same here.
25873 (New::DoResolve): Implement guts of array creation.
25875 (New::FormLookupType): Helper function.
25877 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25879 * codegen.cs: Removed most of the code generation here, and move the
25880 corresponding code generation bits to the statement classes.
25882 Added support for try/catch/finalize and throw.
25884 * cs-parser.jay: Added support for try/catch/finalize.
25886 * class.cs: Catch static methods having the flags override,
25887 virtual or abstract.
25889 * expression.cs (UserCast): This user cast was not really doing
25890 what it was supposed to do. Which is to be born in fully resolved
25891 state. Parts of the resolution were being performed at Emit time!
25895 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25897 * expression.cs: Implicity convert the result from UserCast.
25899 2001-10-05 Ravi Pratap <ravi@ximian.com>
25901 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25902 prevented it from working correctly.
25904 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25905 merely ConvertImplicit.
25907 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25909 * typemanager.cs: Make the LookupTypeContainer function static,
25910 and not per-instance.
25912 * class.cs: Make static FindMembers (the one that takes a Type
25915 * codegen.cs: Add EmitForeach here.
25917 * cs-parser.jay: Make foreach a toplevel object instead of the
25918 inline expansion, as we need to perform semantic analysis on it.
25920 2001-10-05 Ravi Pratap <ravi@ximian.com>
25922 * expression.cs (Expression::ImplicitUserConversion): Rename to
25923 UserDefinedConversion.
25925 (Expression::UserDefinedConversion): Take an extra argument specifying
25926 whether we look for explicit user conversions too.
25928 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25930 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25932 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25933 with the appropriate arguments.
25935 * cs-parser.jay (cast_expression): Record location too.
25937 * expression.cs (Cast): Record location info.
25939 (Expression::ConvertExplicit): Take location argument.
25941 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25942 to determine if we are doing explicit conversions.
25944 (UserCast::Emit): Update accordingly.
25946 (Expression::ConvertExplicit): Report an error if everything fails.
25948 * ../errors/cs0030.cs : Add.
25950 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25952 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25953 virtual and newslot bits.
25955 * class.cs (TypeContainer::RegisterRequiredImplementations):
25956 Record methods we need.
25958 (TypeContainer::MakeKey): Helper function to make keys for
25959 MethodBases, since the Methodbase key is useless.
25961 (TypeContainer::Populate): Call RegisterRequiredImplementations
25962 before defining the methods.
25964 Create a mapping for method_builders_to_methods ahead of time
25965 instead of inside a tight loop.
25967 (::RequireMethods): Accept an object as the data to set into the
25968 hashtable so we can report interface vs abstract method mismatch.
25970 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25972 * report.cs: Make all of it static.
25974 * rootcontext.cs: Drop object_type and value_type computations, as
25975 we have those in the TypeManager anyways.
25977 Drop report instance variable too, now it is a global.
25979 * driver.cs: Use try/catch on command line handling.
25981 Add --probe option to debug the error reporting system with a test
25984 * report.cs: Add support for exiting program when a probe
25985 condition is reached.
25987 2001-10-03 Ravi Pratap <ravi@ximian.com>
25989 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25990 we do a forcible conversion regardless of type, to check if
25991 ForceConversion returns a null.
25993 (Binary::error19): Use location to report error.
25995 (Unary::error23): Use location here too.
25997 * ../errors/cs0019.cs : Check in.
25999 * ../errors/cs0023.cs : Check in.
26001 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
26002 case of a non-null MethodInfo object with a length of 0 !
26004 (Binary::ResolveOperator): Flag error if overload resolution fails to find
26005 an applicable member - according to the spec :-)
26006 Also fix logic to find members in base types.
26008 (Unary::ResolveOperator): Same here.
26010 (Unary::report23): Change name to error23 and make first argument a TypeContainer
26011 as I was getting thoroughly confused between this and error19 :-)
26013 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
26014 (::FindMostEncompassedType): Implement.
26015 (::FindMostEncompassingType): Implement.
26016 (::StandardConversionExists): Implement.
26018 (UserImplicitCast): Re-vamp. We now need info about most specific
26019 source and target types so that we can do the necessary conversions.
26021 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
26022 mathematical union with no duplicates.
26024 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26026 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
26027 in order from base classes to child classes, so that we can in
26028 child classes look up in our parent for method names and
26029 attributes (required for handling abstract, virtual, new, override
26030 constructs: we need to instrospect our base class, and if we dont
26031 populate the classes in order, the introspection might be
26032 incorrect. For example, a method could query its parent before
26033 the parent has any methods and would determine that the parent has
26034 no abstract methods (while it could have had them)).
26036 (RootContext::CreateType): Record the order in which we define the
26039 2001-10-02 Miguel de Icaza <miguel@ximian.com>
26041 * class.cs (TypeContainer::Populate): Also method definitions can
26042 fail now, keep track of this.
26044 (TypeContainer::FindMembers): Implement support for
26045 DeclaredOnly/noDeclaredOnly flag.
26047 (Constructor::Emit) Return the ConstructorBuilder.
26049 (Method::Emit) Return the MethodBuilder.
26050 Check for abstract or virtual methods to be public.
26052 * rootcontext.cs (RootContext::CreateType): Register all the
26053 abstract methods required for the class to be complete and the
26054 interface methods that must be implemented.
26056 * cs-parser.jay: Report error 501 (method requires body if it is
26057 not marked abstract or extern).
26059 * expression.cs (TypeOf::Emit): Implement.
26061 * typemanager.cs: runtime_handle_type, new global type.
26063 * class.cs (Property::Emit): Generate code for properties.
26065 2001-10-02 Ravi Pratap <ravi@ximian.com>
26067 * expression.cs (Unary::ResolveOperator): Find operators on base type
26068 too - we now conform exactly to the spec.
26070 (Binary::ResolveOperator): Same here.
26072 * class.cs (Operator::Define): Fix minor quirk in the tests.
26074 * ../errors/cs0215.cs : Added.
26076 * ../errors/cs0556.cs : Added.
26078 * ../errors/cs0555.cs : Added.
26080 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26082 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
26083 single integer which is really efficient
26085 2001-10-01 Ravi Pratap <ravi@ximian.com>
26087 * expression.cs (Expression::ImplicitUserConversion): Use location
26088 even in the case when we are examining True operators.
26090 * class.cs (Operator::Define): Perform extensive checks to conform
26091 with the rules for operator overloading in the spec.
26093 * expression.cs (Expression::ImplicitReferenceConversion): Implement
26094 some of the other conversions mentioned in the spec.
26096 * typemanager.cs (array_type): New static member for the System.Array built-in
26099 (cloneable_interface): For System.ICloneable interface.
26101 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
26102 we start resolving the tree and populating types.
26104 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
26106 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26108 * expression.cs (Expression::ExprClassFromMemberInfo,
26109 Expression::Literalize): Create literal expressions from
26110 FieldInfos which are literals.
26112 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
26113 type casts, because they were wrong. The test suite in tests
26116 (ImplicitNumericConversion): ushort to ulong requires a widening
26119 Int32 constant to long requires widening cast as well.
26121 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
26122 for integers because the type on the stack is not i4.
26124 2001-09-30 Miguel de Icaza <miguel@ximian.com>
26126 * expression.cs (report118): require location argument.
26128 * parameter.cs: Do not dereference potential null value.
26130 * class.cs: Catch methods that lack the `new' keyword when
26131 overriding a name. Report warnings when `new' is used without
26132 anything being there to override.
26134 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
26136 * class.cs: Only add constructor to hashtable if it is non-null
26137 (as now constructors can fail on define).
26139 (TypeManager, Class, Struct): Take location arguments.
26141 Catch field instance initialization in structs as errors.
26143 accepting_filter: a new filter for FindMembers that is static so
26144 that we dont create an instance per invocation.
26146 (Constructor::Define): Catch errors where a struct constructor is
26149 * cs-parser.jay: Pass location information for various new
26152 * delegate.cs (Delegate): take a location argument.
26154 * driver.cs: Do not call EmitCode if there were problesm in the
26155 Definition of the types, as many Builders wont be there.
26157 * decl.cs (Decl::Decl): Require a location argument.
26159 * cs-tokenizer.cs: Handle properly hex constants that can not fit
26160 into integers, and find the most appropiate integer for it.
26162 * literal.cs: Implement ULongLiteral.
26164 * rootcontext.cs: Provide better information about the location of
26165 failure when CreateType fails.
26167 2001-09-29 Miguel de Icaza <miguel@ximian.com>
26169 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
26172 * expression.cs (Binary::CheckShiftArguments): Add missing type
26174 (Binary::ResolveOperator): Add type to the logical and and logical
26175 or, Bitwise And/Or and Exclusive Or code paths, it was missing
26178 (Binary::DoNumericPromotions): In the case where either argument
26179 is ulong (and most signed types combined with ulong cause an
26180 error) perform implicit integer constant conversions as well.
26182 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26184 * expression.cs (UserImplicitCast): Method should always be
26186 (Invocation::BetterConversion): Simplified test for IntLiteral.
26188 (Expression::ImplicitNumericConversion): Split this routine out.
26189 Put the code that performs implicit constant integer conversions
26192 (Expression::Resolve): Become a wrapper around DoResolve so we can
26193 check eclass and type being set after resolve.
26195 (Invocation::Badness): Remove this dead function
26197 (Binary::ResolveOperator): Do not compute the expensive argumnets
26198 unless we have a union for it.
26200 (Probe::Emit): Is needs to do an isinst and then
26201 compare against null.
26203 (::CanConvert): Added Location argument. If the Location argument
26204 is null (Location.Null), then we do not report errors. This is
26205 used by the `probe' mechanism of the Explicit conversion. We do
26206 not want to generate an error for something that the user
26207 explicitly requested to be casted. But the pipeline for an
26208 explicit cast first tests for potential implicit casts.
26210 So for now, if the Location is null, it means `Probe only' to
26211 avoid adding another argument. Might have to revise this
26214 (ClassCast): New class used to type cast objects into arbitrary
26215 classes (used in Explicit Reference Conversions).
26217 Implement `as' as well.
26219 Reverted all the patches from Ravi below: they were broken:
26221 * The use of `level' as a mechanism to stop recursive
26222 invocations is wrong. That was there just to catch the
26223 bug with a strack trace but not as a way of addressing
26226 To fix the problem we have to *understand* what is going
26227 on and the interactions and come up with a plan, not
26228 just get things going.
26230 * The use of the type conversion cache that I proposed
26231 last night had an open topic: How does this work across
26232 protection domains. A user defined conversion might not
26233 be public in the location where we are applying the
26234 conversion, a different conversion might be selected
26235 (ie, private A->B (better) but public B->A (worse),
26236 inside A, A->B applies, but outside it, B->A will
26239 * On top of that (ie, even if the above is solved),
26240 conversions in a cache need to be abstract. Ie, `To
26241 convert from an Int to a Short use an OpcodeCast', not
26242 `To convert from an Int to a Short use the OpcodeCast on
26243 the variable 5' (which is what this patch was doing).
26245 2001-09-28 Ravi Pratap <ravi@ximian.com>
26247 * expression.cs (Invocation::ConversionExists): Re-write to use
26248 the conversion cache
26250 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
26251 cache all conversions done, not just user-defined ones.
26253 (Invocation::BetterConversion): The real culprit. Use ConversionExists
26254 to determine if a conversion exists instead of acutually trying to
26255 perform the conversion. It's faster too.
26257 (Expression::ConvertExplicit): Modify to use ConversionExists to check
26258 and only then attempt the implicit conversion.
26260 2001-09-28 Ravi Pratap <ravi@ximian.com>
26262 * expression.cs (ConvertImplicit): Use a cache for conversions
26263 already found. Check level of recursion and bail out if necessary.
26265 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26267 * typemanager.cs (string_concat_string_string, string_concat_object_object):
26268 Export standard methods that we expect for string operations.
26270 * statement.cs (Block::UsageWarning): Track usage of variables and
26271 report the errors for not used variables.
26273 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
26276 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26278 * codegen.cs: remove unnneded code
26280 * expression.cs: Removed BuiltinTypeAccess class
26282 Fix the order in which implicit conversions are
26285 The previous fixed dropped support for boxed conversions (adding a
26286 test to the test suite now)
26288 (UserImplicitCast::CanConvert): Remove test for source being null,
26289 that code is broken. We should not feed a null to begin with, if
26290 we do, then we should track the bug where the problem originates
26291 and not try to cover it up here.
26293 Return a resolved expression of type UserImplicitCast on success
26294 rather than true/false. Ravi: this is what I was talking about,
26295 the pattern is to use a static method as a "constructor" for
26298 Also, do not create arguments until the very last minute,
26299 otherwise we always create the arguments even for lookups that
26300 will never be performed.
26302 (UserImplicitCast::Resolve): Eliminate, objects of type
26303 UserImplicitCast are born in a fully resolved state.
26305 * typemanager.cs (InitCoreTypes): Init also value_type
26306 (System.ValueType).
26308 * expression.cs (Cast::Resolve): First resolve the child expression.
26310 (LValue): Add new method AddressOf to be used by
26313 Change the argument of Store to take an EmitContext instead of an
26314 ILGenerator, because things like FieldExpr need to be able to call
26315 their children expression to generate the instance code.
26317 (Expression::Error, Expression::Warning): Sugar functions for
26320 (Expression::MemberLookup): Accept a TypeContainer instead of a
26321 Report as the first argument.
26323 (Expression::ResolvePrimary): Killed. I still want to improve
26324 this as currently the code is just not right.
26326 (Expression::ResolveMemberAccess): Simplify, but it is still
26329 (Unary::Resolve): Catch errors in AddressOf operators.
26331 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
26332 index to a byte for the short-version, or the compiler will choose
26333 the wrong Emit call, which generates the wrong data.
26335 (ParameterReference::Emit, ::Store): same.
26337 (FieldExpr::AddressOf): Implement.
26339 * typemanager.cs: TypeManager: made public variable instead of
26342 * driver.cs: document --fatal.
26344 * report.cs (ErrorMessage, WarningMessage): new names for the old
26345 Error and Warning classes.
26347 * cs-parser.jay (member_access): Turn built-in access to types
26348 into a normal simplename
26350 2001-09-27 Ravi Pratap <ravi@ximian.com>
26352 * expression.cs (Invocation::BetterConversion): Fix to cope
26353 with q being null, since this was introducing a bug.
26355 * expression.cs (ConvertImplicit): Do built-in conversions first.
26357 2001-09-27 Ravi Pratap <ravi@ximian.com>
26359 * expression.cs (UserImplicitCast::Resolve): Fix bug.
26361 2001-09-27 Ravi Pratap <ravi@ximian.com>
26363 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
26364 I had introduced long ago (what's new ?).
26366 * expression.cs (UserImplicitCast::CanConvert): Static method to do
26367 the work of all the checking.
26368 (ConvertImplicit): Call CanConvert and only then create object if necessary.
26369 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
26371 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
26372 that is the right way.
26374 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
26375 overloading resolution. Use everywhere instead of cutting and pasting code.
26377 (Binary::ResolveOperator): Use MakeUnionSet.
26379 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
26380 we have to convert to bool types. Not complete yet.
26382 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26384 * typemanager.cs (TypeManager::CSharpName): support ushort.
26386 * expression.cs (Expression::TryImplicitIntConversion): Attempts
26387 to provide an expression that performsn an implicit constant int
26388 conversion (section 6.1.6).
26389 (Expression::ConvertImplicitRequired): Reworked to include
26390 implicit constant expression conversions.
26392 (Expression::ConvertNumericExplicit): Finished.
26394 (Invocation::Emit): If InstanceExpression is null, then it means
26395 that we perform a call on this.
26397 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26399 * expression.cs (Unary::Emit): Remove some dead code.
26400 (Probe): Implement Resolve and Emit for `is'.
26401 (Expression::ConvertImplicitRequired): Attempt to do constant
26402 expression conversions here. Maybe should be moved to
26403 ConvertImplicit, but I am not sure.
26404 (Expression::ImplicitLongConstantConversionPossible,
26405 Expression::ImplicitIntConstantConversionPossible): New functions
26406 that tell whether is it possible to apply an implicit constant
26407 expression conversion.
26409 (ConvertNumericExplicit): Started work on explicit numeric
26412 * cs-parser.jay: Update operator constants.
26414 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
26415 (Parameters::GetSignature): Hook up VerifyArgs here.
26416 (Parameters::VerifyArgs): Verifies that no two arguments have the
26419 * class.cs (Operator): Update the operator names to reflect the
26420 ones that the spec expects (as we are just stringizing the
26423 * expression.cs (Unary::ResolveOperator): Fix bug: Use
26424 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
26425 previous usage did only work for our methods.
26426 (Expression::ConvertImplicit): Handle decimal implicit numeric
26427 conversions as well.
26428 (Expression::InternalTypeConstructor): Used to invoke constructors
26429 on internal types for default promotions.
26431 (Unary::Emit): Implement special handling for the pre/post
26432 increment/decrement for overloaded operators, as they need to have
26433 the same semantics as the other operators.
26435 (Binary::ResolveOperator): ditto.
26436 (Invocation::ConversionExists): ditto.
26437 (UserImplicitCast::Resolve): ditto.
26439 2001-09-26 Ravi Pratap <ravi@ximian.com>
26441 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
26442 operator, return after emitting body. Regression tests pass again !
26444 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
26445 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
26446 (Invocation::OverloadResolve): Ditto.
26447 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
26449 * everywhere : update calls to the above methods accordingly.
26451 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26453 * assign.cs (Assign): Make it inherit from ExpressionStatement.
26455 * expression.cs (ExpressionStatement): New base class used for
26456 expressions that can appear in statements, so that we can provide
26457 an alternate path to generate expression that do not leave a value
26460 (Expression::Emit, and all the derivatives): We no longer return
26461 whether a value is left on the stack or not. Every expression
26462 after being emitted leaves a single value on the stack.
26464 * codegen.cs (EmitContext::EmitStatementExpression): Use the
26465 facilties of ExpressionStatement if possible.
26467 * cs-parser.jay: Update statement_expression.
26469 2001-09-25 Miguel de Icaza <miguel@ximian.com>
26471 * driver.cs: Change the wording of message
26473 2001-09-25 Ravi Pratap <ravi@ximian.com>
26475 * expression.cs (Binary::ResolveOperator): Had forgottten to set
26476 the type of the expression to the return type of the method if
26477 we have an overloaded operator match ! The regression tests pass again !
26478 (Unary::ResolveOperator): Ditto.
26480 * expression.cs (Invocation::ConversionExists): Correct the member lookup
26481 to find "op_Implicit", not "implicit" ;-)
26482 (UserImplicitCast): New class to take care of user-defined implicit conversions.
26483 (ConvertImplicit, ForceConversion): Take TypeContainer argument
26485 * everywhere : Correct calls to the above accordingly.
26487 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
26488 (ConvertImplicit): Do user-defined conversion if it exists.
26490 2001-09-24 Miguel de Icaza <miguel@ximian.com>
26492 * assign.cs: track location.
26493 (Resolve): Use implicit conversions on assignment.
26495 * literal.cs: Oops. Not good, Emit of short access values should
26496 pass (Bytes) or the wrong argument will be selected.
26498 * expression.cs (Unary::Emit): Emit code for -expr.
26500 (Unary::ResolveOperator): Handle `Substract' for non-constants
26501 (substract from zero from the non-constants).
26502 Deal with Doubles as well.
26504 (Expression::ConvertImplicitRequired): New routine that reports an
26505 error if no implicit conversion exists.
26507 (Invocation::OverloadResolve): Store the converted implicit
26508 expressions if we make them
26510 2001-09-24 Ravi Pratap <ravi@ximian.com>
26512 * class.cs (ConstructorInitializer): Take a Location argument.
26513 (ConstructorBaseInitializer): Same here.
26514 (ConstructorThisInitializer): Same here.
26516 * cs-parser.jay : Update all calls accordingly.
26518 * expression.cs (Unary, Binary, New): Take location argument.
26519 Update accordingly everywhere.
26521 * cs-parser.jay : Update all calls to the above to take a location
26524 * class.cs : Ditto.
26526 2001-09-24 Ravi Pratap <ravi@ximian.com>
26528 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
26529 (Invocation::BetterConversion): Same here
26530 (Invocation::ConversionExists): Ditto.
26532 (Invocation::ConversionExists): Implement.
26534 2001-09-22 Ravi Pratap <ravi@ximian.com>
26536 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
26537 Also take an additional TypeContainer argument.
26539 * All over : Pass in TypeContainer as argument to OverloadResolve.
26541 * typemanager.cs (CSharpName): Update to check for the string type and return
26544 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
26547 2001-09-21 Ravi Pratap <ravi@ximian.com>
26549 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
26550 (Invocation::BetterFunction): Implement.
26551 (Invocation::BetterConversion): Implement.
26552 (Invocation::ConversionExists): Skeleton, no implementation yet.
26554 Okay, things work fine !
26556 2001-09-21 Miguel de Icaza <miguel@ximian.com>
26558 * typemanager.cs: declare and load enum_type, delegate_type and
26561 * expression.cs (Expression::Emit): Now emit returns a value that
26562 tells whether a value is left on the stack or not. This strategy
26563 might be reveted tomorrow with a mechanism that would address
26564 multiple assignments.
26565 (Expression::report118): Utility routine to report mismatches on
26568 (Unary::Report23): Report impossible type/operator combination
26571 (Unary::IsIncrementableNumber): Whether the type can be
26572 incremented or decremented with add.
26573 (Unary::ResolveOperator): Also allow enumerations to be bitwise
26575 (Unary::ResolveOperator): Implement ++, !, ~,
26577 (Invocation::Emit): Deal with new Emit convetion.
26579 * All Expression derivatives: Updated their Emit method to return
26580 whether they leave values on the stack or not.
26582 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
26583 stack for expressions that are statements.
26585 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26587 * expression.cs (LValue): New interface. Must be implemented by
26589 (LocalVariableReference, ParameterReference, FieldExpr): Implement
26592 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
26593 interface for generating code, simplifies the code.
26595 2001-09-20 Ravi Pratap <ravi@ximian.com>
26597 * expression.cs (everywhere): Comment out return statements in ::Resolve
26598 methods to avoid the warnings.
26600 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26602 * driver.cs (parse): Report error 2001 if we can not open the
26605 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
26608 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
26611 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
26612 otherwise nested blocks end up with the same index.
26614 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
26616 * expression.cs: Instead of having FIXMEs in the Resolve
26617 functions, throw exceptions so it is obvious that we are facing a
26620 * cs-parser.jay (invocation_expression): Pass Location information.
26622 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
26623 Use a basename for those routines because .NET does not like paths
26626 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
26629 2001-09-19 Miguel de Icaza <miguel@ximian.com>
26631 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
26632 are loading the correct data types (throws an exception if not).
26633 (TypeManager::InitCoreTypes): Use CoreLookupType
26635 * expression.cs (Unary::ResolveOperator): return the child
26636 expression for expressions which are just +expr.
26637 (Unary::ResolveOperator): Return negative literals for -LITERAL
26638 expressions (otherwise they are Unary {Literal}).
26639 (Invocation::Badness): Take into account `Implicit constant
26640 expression conversions'.
26642 * literal.cs (LongLiteral): Implement long literal class.
26643 (IntLiteral): export the `Value' of the intliteral.
26645 2001-09-19 Ravi Pratap <ravi@ximian.com>
26647 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
26649 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
26650 instead of 'Operator'
26652 * expression.cs (Binary::ResolveOperator): Update accordingly.
26653 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
26656 * cs-parser.jay (unary_expression): Update to use the new names.
26658 * gen-treedump.cs (GetUnary): Same here.
26660 * expression.cs (Unary::Resolve): Implement.
26661 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
26662 operators are found instead of making noise ;-)
26663 (Unary::ResolveOperator): New method to do precisely the same thing which
26664 Binary::ResolveOperator does for Binary expressions.
26665 (Unary.method, .Arguments): Add.
26666 (Unary::OperName): Implement.
26667 (Unary::ForceConversion): Copy and Paste !
26669 * class.cs (Operator::Define): Fix a small bug for the case when we have
26672 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
26673 for the inbuilt operators. Only overloading works for now ;-)
26675 2001-09-18 Miguel de Icaza <miguel@ximian.com>
26677 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
26678 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
26680 * expression.cs (This::Emit): Implement.
26681 (This::Resolve): Implement.
26682 (TypeOf:Resolve): Implement.
26683 (Expression::ResolveSimpleName): Add an implicit this to instance
26685 (MemberAccess::Resolve): Deal with Parameters and Fields.
26686 Bind instance variable to Field expressions.
26687 (FieldExpr::Instance): New field used to track the expression that
26688 represents the object instance.
26689 (FieldExpr::Resolve): Track potential errors from MemberLookup not
26691 (FieldExpr::Emit): Implement.
26693 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
26694 the last instruction contains a return opcode to avoid generating
26695 the last `ret' instruction (this generates correct code, and it is
26696 nice to pass the peverify output).
26698 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
26699 initializer for static and instance variables.
26700 (Constructor::Emit): Allow initializer to be null in the case of
26701 static constructors. Only emit initializer for instance
26704 (TypeContainer::FindMembers): Return a null array if there are no
26707 Also fix the code for the MemberTypes.Method branch, as it was not
26708 scanning that for operators (or tried to access null variables before).
26710 * assign.cs (Assign::Emit): Handle instance and static fields.
26714 * driver.cs: Stop compilation if there are parse errors.
26716 * cs-parser.jay (constructor_declaration): Provide default base
26717 initializer for non-static constructors.
26718 (constructor_declarator): Do not provide a default base
26719 initializers if none was specified.
26720 Catch the fact that constructors should not have parameters.
26722 * class.cs: Do not emit parent class initializers for static
26723 constructors, that should be flagged as an error.
26725 2001-09-18 Ravi Pratap <ravi@ximian.com>
26727 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
26728 Move back code into TypeContainer::Populate.
26730 2001-09-18 Ravi Pratap <ravi@ximian.com>
26732 * class.cs (TypeContainer::AddConstructor): Fix the check to
26733 compare against Name, not Basename.
26734 (Operator::OpType): Change Plus and Minus to Add and Subtract.
26736 * cs-parser.jay : Update accordingly.
26738 * class.cs (TypeContainer::FindMembers): For the case where we are searching
26739 for methods, don't forget to look into the operators too.
26740 (RegisterMethodBuilder): Helper method to take care of this for
26741 methods, constructors and operators.
26742 (Operator::Define): Completely revamp.
26743 (Operator.OperatorMethod, MethodName): New fields.
26744 (TypeContainer::Populate): Move the registering of builders into
26745 RegisterMethodBuilder.
26746 (Operator::Emit): Re-write.
26748 * expression.cs (Binary::Emit): Comment out code path to emit method
26749 invocation stuff for the case when we have a user defined operator. I am
26750 just not able to get it right !
26752 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26754 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26757 (Expression::MemberLookup): Provide a version that allows to
26758 specify the MemberTypes and BindingFlags.
26760 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26761 so it was not fetching variable information from outer blocks.
26763 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26764 Beforefieldinit as it was buggy.
26766 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26767 that Ravi put here.
26769 * class.cs (Constructor::Emit): Only emit if block is not null.
26770 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26771 deal with this by semantically definining it as if the user had
26774 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26775 constructors as we now "emit" them at a higher level.
26777 (TypeContainer::DefineDefaultConstructor): Used to define the
26778 default constructors if none was provided.
26780 (ConstructorInitializer): Add methods Resolve and Emit.
26782 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26784 2001-09-17 Ravi Pratap <ravi@ximian.com>
26786 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26787 the default constructor builder with our hashtable for methodbuilders
26790 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26791 and argument_count is 0 in which case we have a match.
26792 (Binary::ResolveOperator): More null checking and miscellaneous coding
26795 2001-09-17 Ravi Pratap <ravi@ximian.com>
26797 * rootcontext.cs (IsNameSpace): Compare against null.
26799 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26801 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26802 and Unary::Operator.
26804 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26807 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26808 we have overloaded operators.
26809 (Binary::ResolveOperator): Implement the part which does the operator overload
26812 * class.cs (Operator::Emit): Implement.
26813 (TypeContainer::Emit): Emit the operators we have too.
26815 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26816 the case when we have a user-defined operator.
26818 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26820 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26822 2001-09-16 Ravi Pratap <ravi@ximian.com>
26824 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26825 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26826 (Constructor::Emit): Implement.
26827 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26828 if we have no work to do.
26829 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26832 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26833 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26835 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26838 2001-09-15 Ravi Pratap <ravi@ximian.com>
26840 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26842 (Tree::RecordNamespace): Method to do what the name says ;-)
26843 (Tree::Namespaces): Property to get at the namespaces hashtable.
26845 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26848 * rootcontext.cs (IsNamespace): Fixed it :-)
26850 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26852 * class.cs (TypeContainer::FindMembers): Add support for
26854 (MethodCore): New class that encapsulates both the shared aspects
26855 of a Constructor and a Method.
26856 (Method, Constructor): Factored pieces into MethodCore.
26858 * driver.cs: Added --fatal which makes errors throw exceptions.
26859 Load System assembly as well as part of the standard library.
26861 * report.cs: Allow throwing exceptions on errors for debugging.
26863 * modifiers.cs: Do not use `parent', instead use the real type
26864 container to evaluate permission settings.
26866 * class.cs: Put Ravi's patch back in. He is right, and we will
26867 have to cope with the
26869 2001-09-14 Ravi Pratap <ravi@ximian.com>
26871 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26872 FamORAssem, not FamANDAssem.
26874 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26876 * driver.cs: Added --parse option that only parses its input files
26879 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26880 incorrect. IsTopLevel is not used to tell whether an object is
26881 root_types or not (that can be achieved by testing this ==
26882 root_types). But to see if this is a top-level *class* (not
26883 necessarly our "toplevel" container).
26885 2001-09-14 Ravi Pratap <ravi@ximian.com>
26887 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26888 parent instead of a direct call to GetType.
26890 2001-09-14 Ravi Pratap <ravi@ximian.com>
26892 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26893 Modifiers.TypeAttr. This should just be a call to that method.
26895 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26896 object so that we can determine if we are top-level or not.
26898 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26901 * enum.cs (Enum::Define): Ditto.
26903 * modifiers.cs (FieldAttr): Re-write.
26905 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26906 (TypeContainer::HaveStaticConstructor): New property to provide access
26907 to precisely that info.
26909 * modifiers.cs (MethodAttr): Re-write.
26910 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26912 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26913 of top-level types as claimed.
26915 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26917 * expression.cs (MemberLookup): Fruitless attempt to lookup
26918 constructors. Maybe I need to emit default constructors? That
26919 might be it (currently .NET emits this for me automatically).
26920 (Invocation::OverloadResolve): Cope with Arguments == null.
26921 (Invocation::EmitArguments): new function, shared by the new
26922 constructor and us.
26923 (Invocation::Emit): Handle static and instance methods. Emit
26924 proper call instruction for virtual or non-virtual invocations.
26925 (New::Emit): Implement.
26926 (New::Resolve): Implement.
26927 (MemberAccess:Resolve): Implement.
26928 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26929 to track instances.
26930 (FieldExpr::Resolve): Set type.
26932 * support.cs: Handle empty arguments.
26934 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26935 SimpleLookup): Auxiliary routines to help parse a qualifier
26938 Update qualifier_identifier rule.
26940 * codegen.cs: Removed debugging messages.
26942 * class.cs: Make this a global thing, this acts just as a "key" to
26943 objects that we might have around.
26945 (Populate): Only initialize method_builders_to_methods once.
26947 * expression.cs (PropertyExpr): Initialize type from the
26950 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26951 Resolve pattern. Attempt to implicitly convert value to boolean.
26954 * expression.cs: Set the type for the int32/int32 argument case.
26955 (Binary::ResolveOperator): Set the return type to boolean for
26956 comparission operators
26958 * typemanager.cs: Remove debugging print code.
26960 (Invocation::Resolve): resolve type.
26962 * class.cs: Allocate a MemberInfo of the correct size, as the code
26963 elsewhere depends on the test to reflect the correct contents.
26965 (Method::) Keep track of parameters, due to System.Reflection holes
26967 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26970 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26971 of the exact size and return that.
26973 (Class::LookupMethodByBuilder): New function that maps
26974 MethodBuilders to its methods. Required to locate the information
26975 on methods because System.Reflection bit us again.
26977 * support.cs: New file, contains an interface ParameterData and
26978 two implementations: ReflectionParameters and InternalParameters
26979 used to access Parameter information. We will need to grow this
26982 * expression.cs (Invocation::GetParameterData): implement a cache
26983 and a wrapper around the ParameterData creation for methods.
26984 (Invocation::OverloadResolve): Use new code.
26986 2001-09-13 Ravi Pratap <ravi@ximian.com>
26988 * class.cs (TypeContainer::EmitField): Remove and move into
26989 (Field::Define): here and modify accordingly.
26990 (Field.FieldBuilder): New member.
26991 (TypeContainer::Populate): Update accordingly.
26992 (TypeContainer::FindMembers): Implement.
26994 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26996 * statement.cs: (VariableInfo::VariableType): New field to be
26997 initialized with the full type once it is resolved.
26999 2001-09-12 Miguel de Icaza <miguel@ximian.com>
27001 * parameter.cs (GetParameterInfo): Use a type cache to compute
27002 things only once, and to reuse this information
27004 * expression.cs (LocalVariableReference::Emit): Implement.
27005 (OpcodeCast::Emit): fix.
27007 (ParameterReference::Resolve): Implement.
27008 (ParameterReference::Emit): Implement.
27010 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
27011 that are expressions need to stay as Expressions.
27013 * typemanager.cs (CSharpName): Returns the C# name of a type if
27016 * expression.cs (Expression::ConvertImplicit): New function that
27017 implements implicit type conversions.
27019 (Expression::ImplicitReferenceConversion): Implements implicit
27020 reference conversions.
27022 (EmptyCast): New type for transparent casts.
27024 (OpcodeCast): New type for casts of types that are performed with
27025 a sequence of bytecodes.
27027 (BoxedCast): New type used for casting value types into reference
27028 types. Emits a box opcode.
27030 (Binary::DoNumericPromotions): Implements numeric promotions of
27031 and computation of the Binary::Type.
27033 (Binary::EmitBranchable): Optimization.
27035 (Binary::Emit): Implement code emission for expressions.
27037 * typemanager.cs (TypeManager): Added two new core types: sbyte
27040 2001-09-12 Ravi Pratap <ravi@ximian.com>
27042 * class.cs (TypeContainer::FindMembers): Method which does exactly
27043 what Type.FindMembers does, only we don't have to use reflection. No
27044 implementation yet.
27046 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
27047 typecontainer objects as we need to get at them.
27048 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
27050 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
27051 typecontainer object.
27053 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
27054 of just a Report object.
27056 2001-09-11 Ravi Pratap <ravi@ximian.com>
27058 * class.cs (Event::Define): Go back to using the prefixes "add_" and
27060 (TypeContainer::Populate): Now define the delegates of the type too.
27061 (TypeContainer.Delegates): Property to access the list of delegates defined
27064 * delegates.cs (Delegate::Define): Implement partially.
27066 * modifiers.cs (TypeAttr): Handle more flags.
27068 2001-09-11 Ravi Pratap <ravi@ximian.com>
27070 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
27072 (Operator::Define): Re-write logic to get types by using the LookupType method
27073 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
27074 (Indexer::Define): Ditto.
27075 (Event::Define): Ditto.
27076 (Property::Define): Ditto.
27078 2001-09-10 Ravi Pratap <ravi@ximian.com>
27080 * class.cs (TypeContainer::Populate): Now define operators too.
27081 (TypeContainer.Operators): New property to access the list of operators
27083 (Operator.OperatorMethodBuilder): New member to hold the method builder
27084 for the operator we are defining.
27085 (Operator::Define): Implement.
27087 2001-09-10 Ravi Pratap <ravi@ximian.com>
27089 * class.cs (Event::Define): Make the prefixes of the accessor methods
27090 addOn_ and removeOn_
27092 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
27093 of the location being passed in too. Ideally, this should go later since all
27094 error reporting should be done through the Report object.
27096 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
27097 (Populate): Iterate thru the indexers we have and define them too.
27098 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
27099 for the get and set accessors.
27100 (Indexer::Define): Implement.
27102 2001-09-09 Miguel de Icaza <miguel@ximian.com>
27104 * expression.cs (Binary::Resolve): Beginning of it. I scratched
27105 my previous implementation, did not work.
27107 * typemanager.cs: Add a couple of missing types (the longs).
27109 * literal.cs: Use TypeManager.bool_type instead of getting it.
27111 * expression.cs (EventExpr): New kind of expressions.
27112 (Expressio::ExprClassFromMemberInfo): finish
27114 2001-09-08 Miguel de Icaza <miguel@ximian.com>
27116 * assign.cs: Emit stores to static fields differently.
27118 2001-09-08 Ravi Pratap <ravi@ximian.com>
27120 * Merge in changes and adjust code to tackle conflicts. Backed out my
27121 code in Assign::Resolve ;-)
27123 2001-09-08 Ravi Pratap <ravi@ximian.com>
27125 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
27126 instead Report.Error and also pass in the location.
27127 (CSharpParser::Lexer): New readonly property to return the reference
27128 to the Tokenizer object.
27129 (declare_local_variables): Use Report.Error with location instead of plain
27133 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
27134 (Operator.CheckBinaryOperator): Ditto.
27136 * cs-parser.jay (operator_declarator): Update accordingly.
27138 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
27139 (CheckBinaryOperator): Same here.
27141 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
27142 on the name without any prefixes of namespace names etc. This is because we
27143 already might have something already fully qualified like
27144 'System.Console.WriteLine'
27146 * assign.cs (Resolve): Begin implementation. Stuck ;-)
27148 2001-09-07 Ravi Pratap <ravi@ximian.com>
27150 * cs-tokenizer.cs (location): Return a string which also contains
27153 * expression.cs (ElementAccess): New class for expressions of the
27154 type 'element access.'
27155 (BaseAccess): New class for expressions of the type 'base access.'
27156 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
27159 * cs-parser.jay (element_access): Implement action.
27160 (base_access): Implement actions.
27161 (checked_expression, unchecked_expression): Implement.
27163 * cs-parser.jay (local_variable_type): Correct and implement.
27164 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
27166 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
27168 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
27169 name and the specifiers.
27171 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
27173 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
27174 making them all public ;-)
27176 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
27179 2001-09-07 Miguel de Icaza <miguel@ximian.com>
27181 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
27183 (FieldExpr, PropertyExprs): New resolved expressions.
27184 (SimpleName::MemberStaticCheck): Perform static checks for access
27185 to non-static fields on static methods. Maybe this should be
27186 generalized for MemberAccesses.
27187 (SimpleName::ResolveSimpleName): More work on simple name
27190 * cs-parser.jay (primary_expression/qualified_identifier): track
27191 the parameter index.
27193 * codegen.cs (CodeGen::Save): Catch save exception, report error.
27194 (EmitContext::EmitBoolExpression): Chain to expression generation
27195 instead of temporary hack.
27196 (::EmitStatementExpression): Put generic expression code generation.
27198 * assign.cs (Assign::Emit): Implement variable assignments to
27199 local variables, parameters and fields.
27201 2001-09-06 Miguel de Icaza <miguel@ximian.com>
27203 * statement.cs (Block::GetVariableInfo): New method, returns the
27204 VariableInfo for a variable name in a block.
27205 (Block::GetVariableType): Implement in terms of GetVariableInfo
27207 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
27208 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
27210 2001-09-06 Ravi Pratap <ravi@ximian.com>
27212 * cs-parser.jay (operator_declaration): Continue on my quest : update
27213 to take attributes argument.
27214 (event_declaration): Ditto.
27215 (enum_declaration): Ditto.
27216 (indexer_declaration): Ditto.
27218 * class.cs (Operator::Operator): Update constructor accordingly.
27219 (Event::Event): Ditto.
27221 * delegate.cs (Delegate::Delegate): Same here.
27223 * enum.cs (Enum::Enum): Same here.
27225 2001-09-05 Ravi Pratap <ravi@ximian.com>
27227 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
27229 * ../tests/cs0658.cs : New file to demonstrate error 0658.
27231 * attribute.cs (Attributes): New class to encapsulate all attributes which were
27232 being passed around as an arraylist.
27233 (Attributes::AddAttribute): Method to add attribute sections.
27235 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
27236 (struct_declaration): Update accordingly.
27237 (constant_declaration): Update.
27238 (field_declaration): Update.
27239 (method_header): Update.
27240 (fixed_parameter): Update.
27241 (parameter_array): Ditto.
27242 (property_declaration): Ditto.
27243 (destructor_declaration): Ditto.
27245 * class.cs (Struct::Struct): Update constructors accordingly.
27246 (Class::Class): Ditto.
27247 (Field::Field): Ditto.
27248 (Method::Method): Ditto.
27249 (Property::Property): Ditto.
27250 (TypeContainer::OptAttribute): update property's return type.
27252 * interface.cs (Interface.opt_attributes): New member.
27253 (Interface::Interface): Update to take the extra Attributes argument.
27255 * parameter.cs (Parameter::Parameter): Ditto.
27257 * constant.cs (Constant::Constant): Ditto.
27259 * interface.cs (InterfaceMemberBase): New OptAttributes field.
27260 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
27261 the attributes as a parameter.
27262 (InterfaceProperty): Update constructor call.
27263 (InterfaceEvent): Ditto.
27264 (InterfaceMethod): Ditto.
27265 (InterfaceIndexer): Ditto.
27267 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
27268 pass the attributes too.
27269 (interface_event_declaration): Ditto.
27270 (interface_property_declaration): Ditto.
27271 (interface_method_declaration): Ditto.
27272 (interface_declaration): Ditto.
27274 2001-09-05 Miguel de Icaza <miguel@ximian.com>
27276 * class.cs (Method::Define): Track the "static Main" definition to
27277 create an entry point.
27279 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
27280 EntryPoint if we find it.
27282 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
27283 (EmitContext::ig): Make this variable public.
27285 * driver.cs: Make the default output file be the first file name
27286 with the .exe extension.
27288 Detect empty compilations
27290 Handle various kinds of output targets. Handle --target and
27291 rename -t to --dumper.
27293 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
27294 methods inherited from Expression return now an Expression. This
27295 will is used during the tree rewriting as we resolve them during
27298 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
27299 the spec. Missing entirely is the information about
27300 accessability of elements of it.
27302 (Expression::ExprClassFromMemberInfo): New constructor for
27303 Expressions that creates a fully initialized Expression based on
27304 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
27307 (Invocation::Resolve): Begin implementing resolution of invocations.
27309 * literal.cs (StringLiteral): Implement Emit.
27311 2001-09-05 Ravi Pratap <ravi@ximian.com>
27313 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
27316 2001-09-04 Ravi Pratap <ravi@ximian.com>
27318 * cs-parser.jay (attribute_arguments): Implement actions.
27319 (attribute): Fix bug in production. Implement action.
27320 (attribute_list): Implement.
27321 (attribute_target): Implement.
27322 (attribute_target_specifier, opt_target_specifier): Implement
27323 (CheckAttributeTarget): New method to check if the attribute target
27325 (attribute_section): Implement.
27326 (opt_attributes): Implement.
27328 * attribute.cs : New file to handle attributes.
27329 (Attribute): Class to hold attribute info.
27331 * cs-parser.jay (opt_attribute_target_specifier): Remove production
27332 (attribute_section): Modify production to use 2 different rules to
27333 achieve the same thing. 1 s/r conflict down !
27334 Clean out commented, useless, non-reducing dimension_separator rules.
27336 * class.cs (TypeContainer.attributes): New member to hold list
27337 of attributes for a type.
27338 (Struct::Struct): Modify to take one more argument, the attribute list.
27339 (Class::Class): Ditto.
27340 (Field::Field): Ditto.
27341 (Method::Method): Ditto.
27342 (Property::Property): Ditto.
27344 * cs-parser.jay (struct_declaration): Update constructor call to
27345 pass in the attributes too.
27346 (class_declaration): Ditto.
27347 (constant_declaration): Ditto.
27348 (field_declaration): Ditto.
27349 (method_header): Ditto.
27350 (fixed_parameter): Ditto.
27351 (parameter_array): Ditto.
27352 (property_declaration): Ditto.
27354 * constant.cs (Constant::Constant): Update constructor similarly.
27355 Use System.Collections.
27357 * parameter.cs (Parameter::Parameter): Update as above.
27359 2001-09-02 Ravi Pratap <ravi@ximian.com>
27361 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
27362 (TypeContainer.delegates): New member to hold list of delegates.
27364 * cs-parser.jay (delegate_declaration): Implement the action correctly
27365 this time as I seem to be on crack ;-)
27367 2001-09-02 Miguel de Icaza <miguel@ximian.com>
27369 * rootcontext.cs (RootContext::IsNamespace): new function, used to
27370 tell whether an identifier represents a namespace.
27372 * expression.cs (NamespaceExpr): A namespace expression, used only
27373 temporarly during expression resolution.
27374 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
27375 utility functions to resolve names on expressions.
27377 2001-09-01 Miguel de Icaza <miguel@ximian.com>
27379 * codegen.cs: Add hook for StatementExpressions.
27381 * class.cs: Fix inverted test for static flag in methods.
27383 2001-09-02 Ravi Pratap <ravi@ximian.com>
27385 * class.cs (Operator::CheckUnaryOperator): Correct error number used
27386 to make it coincide with MS' number.
27387 (Operator::CheckBinaryOperator): Ditto.
27389 * ../errors/errors.txt : Remove error numbers added earlier.
27391 * ../errors/cs1019.cs : Test case for error # 1019
27393 * ../errros/cs1020.cs : Test case for error # 1020
27395 * cs-parser.jay : Clean out commented cruft.
27396 (dimension_separators, dimension_separator): Comment out. Ostensibly not
27397 used anywhere - non-reducing rule.
27398 (namespace_declarations): Non-reducing rule - comment out.
27400 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
27401 with TypeContainer::AddEnum.
27403 * delegate.cs : New file for delegate handling classes.
27404 (Delegate): Class for declaring delegates.
27406 * makefile : Update.
27408 * cs-parser.jay (delegate_declaration): Implement.
27410 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
27412 * class.cs (Event::Define): Implement.
27413 (Event.EventBuilder): New member.
27415 * class.cs (TypeContainer::Populate): Update to define all enums and events
27417 (Events): New property for the events arraylist we hold. Shouldn't we move to using
27418 readonly fields for all these cases ?
27420 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27422 * class.cs (Property): Revamp to use the convention of making fields readonly.
27423 Accordingly modify code elsewhere.
27425 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
27426 the Define method of the Property class.
27428 * class.cs : Clean up applied patch and update references to variables etc. Fix
27430 (TypeContainer::Populate): Update to define all the properties we have. Also
27431 define all enumerations.
27433 * enum.cs (Define): Implement.
27435 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27437 * cs-parser.jay (overloadable_operator): The semantic value is an
27438 enum of the Operator class.
27439 (operator_declarator): Implement actions.
27440 (operator_declaration): Implement.
27442 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
27443 validity of definitions.
27444 (Operator::CheckBinaryOperator): Static method to check for binary operators
27445 (TypeContainer::AddOperator): New method to add an operator to a type.
27447 * cs-parser.jay (indexer_declaration): Added line to actually call the
27448 AddIndexer method so it gets added ;-)
27450 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
27451 already taken care of by the MS compiler ?
27453 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27455 * class.cs (Operator): New class for operator declarations.
27456 (Operator::OpType): Enum for the various operators.
27458 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27460 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
27461 ostensibly handle this in semantic analysis.
27463 * cs-parser.jay (general_catch_clause): Comment out
27464 (specific_catch_clauses, specific_catch_clause): Ditto.
27465 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
27466 (catch_args, opt_catch_args): New productions.
27467 (catch_clause): Rewrite to use the new productions above
27468 (catch_clauses): Modify accordingly.
27469 (opt_catch_clauses): New production to use in try_statement
27470 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
27471 and re-write the code in the actions to extract the specific and
27472 general catch clauses by being a little smart ;-)
27474 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
27475 Hooray, try and catch statements parse fine !
27477 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27479 * statement.cs (Block::GetVariableType): Fix logic to extract the type
27480 string from the hashtable of variables.
27482 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
27483 I end up making that mistake ;-)
27484 (catch_clauses): Fixed gross error which made Key and Value of the
27485 DictionaryEntry the same : $1 !!
27487 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27489 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
27491 * cs-parser.jay (event_declaration): Correct to remove the semicolon
27492 when the add and remove accessors are specified.
27494 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27496 * cs-parser.jay (IndexerDeclaration): New helper class to hold
27497 information about indexer_declarator.
27498 (indexer_declarator): Implement actions.
27499 (parsing_indexer): New local boolean used to keep track of whether
27500 we are parsing indexers or properties. This is necessary because
27501 implicit_parameters come into picture even for the get accessor in the
27502 case of an indexer.
27503 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
27505 * class.cs (Indexer): New class for indexer declarations.
27506 (TypeContainer::AddIndexer): New method to add an indexer to a type.
27507 (TypeContainer::indexers): New member to hold list of indexers for the
27510 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27512 * cs-parser.jay (add_accessor_declaration): Implement action.
27513 (remove_accessor_declaration): Implement action.
27514 (event_accessors_declaration): Implement
27515 (variable_declarators): swap statements for first rule - trivial.
27517 * class.cs (Event): New class to hold information about event
27519 (TypeContainer::AddEvent): New method to add an event to a type
27520 (TypeContainer::events): New member to hold list of events.
27522 * cs-parser.jay (event_declaration): Implement actions.
27524 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27526 * cs-parser.jay (dim_separators): Implement. Make it a string
27527 concatenating all the commas together, just as they appear.
27528 (opt_dim_separators): Modify accordingly
27529 (rank_specifiers): Update accordingly. Basically do the same
27530 thing - instead, collect the brackets here.
27531 (opt_rank_sepcifiers): Modify accordingly.
27532 (array_type): Modify to actually return the complete type string
27533 instead of ignoring the rank_specifiers.
27534 (expression_list): Implement to collect the expressions
27535 (variable_initializer): Implement. We make it a list of expressions
27536 essentially so that we can handle the array_initializer case neatly too.
27537 (variable_initializer_list): Implement.
27538 (array_initializer): Make it a list of variable_initializers
27539 (opt_array_initializer): Modify accordingly.
27541 * expression.cs (New::NType): Add enumeration to help us
27542 keep track of whether we have an object/delegate creation
27543 or an array creation.
27544 (New:NewType, New::Rank, New::Indices, New::Initializers): New
27545 members to hold data about array creation.
27546 (New:New): Modify to update NewType
27547 (New:New): New Overloaded contructor for the array creation
27550 * cs-parser.jay (array_creation_expression): Implement to call
27551 the overloaded New constructor.
27553 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
27555 * class.cs (TypeContainer::Constructors): Return member
27556 constructors instead of returning null.
27558 2001-08-26 Miguel de Icaza <miguel@ximian.com>
27560 * typemanager.cs (InitCoreTypes): Initialize the various core
27561 types after we have populated the type manager with the user
27562 defined types (this distinction will be important later while
27563 compiling corlib.dll)
27565 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
27566 on Expression Classification. Now all expressions have a method
27567 `Resolve' and a method `Emit'.
27569 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
27570 generation from working. Also add some temporary debugging
27573 2001-08-24 Miguel de Icaza <miguel@ximian.com>
27575 * codegen.cs: Lots of code generation pieces. This is only the
27576 beginning, will continue tomorrow with more touches of polish. We
27577 handle the fundamentals of if, while, do, for, return. Others are
27578 trickier and I need to start working on invocations soon.
27580 * gen-treedump.cs: Bug fix, use s.Increment here instead of
27583 * codegen.cs (EmitContext): New struct, used during code
27584 emission to keep a context. Most of the code generation will be
27587 * cs-parser.jay: Add embedded blocks to the list of statements of
27588 this block. So code generation proceeds in a top down fashion.
27590 2001-08-23 Miguel de Icaza <miguel@ximian.com>
27592 * statement.cs: Add support for multiple child blocks.
27594 2001-08-22 Miguel de Icaza <miguel@ximian.com>
27596 * codegen.cs (EmitCode): New function, will emit the code for a
27597 Block of code given a TypeContainer and its ILGenerator.
27599 * statement.cs (Block): Standard public readonly optimization.
27600 (Block::Block constructors): Link children.
27601 (Block::Child): Child Linker.
27602 (Block::EmitVariables): Emits IL variable declarations.
27604 * class.cs: Drop support for MethodGroups here, delay until
27606 (Method::): Applied the same simplification that I did before, and
27607 move from Properties to public readonly fields.
27608 (Method::ParameterTypes): Returns the parameter types for the
27609 function, and implements a cache that will be useful later when I
27610 do error checking and the semantic analysis on the methods is
27612 (Constructor::GetCallingConvention): Renamed from CallingConvetion
27613 and made a method, optional argument tells whether this is a class
27614 or a structure to apply the `has-this' bit.
27615 (Method::GetCallingConvention): Implement, returns the calling
27617 (Method::Define): Defines the type, a second pass is performed
27618 later to populate the methods.
27620 (Constructor::ParameterTypes): implement a cache similar to the
27621 one on Method::ParameterTypes, useful later when we do semantic
27624 (TypeContainer::EmitMethod): New method. Emits methods.
27626 * expression.cs: Removed MethodGroup class from here.
27628 * parameter.cs (Parameters::GetCallingConvention): new method.
27630 2001-08-21 Miguel de Icaza <miguel@ximian.com>
27632 * class.cs (TypeContainer::Populate): Drop RootContext from the
27635 (Constructor::CallingConvention): Returns the calling convention.
27636 (Constructor::ParameterTypes): Returns the constructor parameter
27639 (TypeContainer::AddConstructor): Keep track of default constructor
27640 and the default static constructor.
27642 (Constructor::) Another class that starts using `public readonly'
27643 instead of properties.
27645 (Constructor::IsDefault): Whether this is a default constructor.
27647 (Field::) use readonly public fields instead of properties also.
27649 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
27650 track of static constructors; If none is used, turn on
27651 BeforeFieldInit in the TypeAttributes.
27653 * cs-parser.jay (opt_argument_list): now the return can be null
27654 for the cases where there are no arguments.
27656 (constructor_declarator): If there is no implicit `base' or
27657 `this', then invoke the default parent constructor.
27659 * modifiers.cs (MethodAttr): New static function maps a set of
27660 modifiers flags into a MethodAttributes enum
27661 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
27662 MethodAttr, TypeAttr to represent the various mappings where the
27663 modifiers are used.
27664 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
27666 2001-08-19 Miguel de Icaza <miguel@ximian.com>
27668 * parameter.cs (GetParameterInfo): Fix bug where there would be no
27671 * interface.cs (PopulateIndexer): Implemented the code generator
27672 for interface indexers.
27674 2001-08-17 Miguel de Icaza <miguel@ximian.com>
27676 * interface.cs (InterfaceMemberBase): Now we track the new status
27679 (PopulateProperty): Implement property population. Woohoo! Got
27680 Methods and Properties going today.
27682 Removed all the properties for interfaces, and replaced them with
27683 `public readonly' fields.
27685 2001-08-16 Miguel de Icaza <miguel@ximian.com>
27687 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
27688 initialize their hashtables/arraylists only when they are needed
27689 instead of doing this always.
27691 * parameter.cs: Handle refs and out parameters.
27693 * cs-parser.jay: Use an ArrayList to construct the arguments
27694 instead of the ParameterCollection, and then cast that to a
27697 * parameter.cs: Drop the use of ParameterCollection and use
27698 instead arrays of Parameters.
27700 (GetParameterInfo): Use the Type, not the Name when resolving
27703 2001-08-13 Miguel de Icaza <miguel@ximian.com>
27705 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
27706 and instead use public readonly fields.
27708 * class.cs: Put back walking code for type containers.
27710 2001-08-11 Miguel de Icaza <miguel@ximian.com>
27712 * class.cs (MakeConstant): Code to define constants.
27714 * rootcontext.cs (LookupType): New function. Used to locate types
27717 2001-08-08 Miguel de Icaza <miguel@ximian.com>
27719 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
27720 this System.Reflection code is. Kudos to Microsoft
27722 * typemanager.cs: Implement a type cache and avoid loading all
27723 types at boot time. Wrap in LookupType the internals. This made
27724 the compiler so much faster. Wow. I rule!
27726 * driver.cs: Make sure we always load mscorlib first (for
27727 debugging purposes, nothing really important).
27729 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
27730 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
27732 * rootcontext.cs: Lookup types on their namespace; Lookup types
27733 on namespaces that have been imported using the `using' keyword.
27735 * class.cs (TypeContainer::TypeAttr): Virtualize.
27736 (Class::TypeAttr): Return attributes suitable for this bad boy.
27737 (Struct::TypeAttr): ditto.
27738 Handle nested classes.
27739 (TypeContainer::) Remove all the type visiting code, it is now
27740 replaced with the rootcontext.cs code
27742 * rootcontext.cs (GetClassBases): Added support for structs.
27744 2001-08-06 Miguel de Icaza <miguel@ximian.com>
27746 * interface.cs, statement.cs, class.cs, parameter.cs,
27747 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
27748 Drop use of TypeRefs, and use strings instead.
27750 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27754 * class.cs (Struct::Struct): set the SEALED flags after
27755 checking the modifiers.
27756 (TypeContainer::TypeAttr): new property, returns the
27757 TypeAttributes for a class.
27759 * cs-parser.jay (type_list): Oops, list production was creating a
27760 new list of base types.
27762 * rootcontext.cs (StdLib): New property.
27763 (GetInterfaceTypeByName): returns an interface by type name, and
27764 encapsulates error handling here.
27765 (GetInterfaces): simplified.
27766 (ResolveTree): Encapsulated all the tree resolution here.
27767 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27770 * driver.cs: Add support for --nostdlib, to avoid loading the
27771 default assemblies.
27772 (Main): Do not put tree resolution here.
27774 * rootcontext.cs: Beginning of the class resolution.
27776 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27778 * rootcontext.cs: Provide better error reporting.
27780 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27782 * rootcontext.cs (CreateInterface): Handle the case where there
27783 are no parent interfaces.
27785 (CloseTypes): Routine to flush types at the end.
27786 (CreateInterface): Track types.
27787 (GetInterfaces): Returns an array of Types from the list of
27788 defined interfaces.
27790 * typemanager.c (AddUserType): Mechanism to track user types (puts
27791 the type on the global type hash, and allows us to close it at the
27794 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27796 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27797 RecordInterface instead.
27799 * cs-parser.jay: Updated to reflect changes above.
27801 * decl.cs (Definition): Keep track of the TypeBuilder type that
27802 represents this type here. Not sure we will use it in the long
27803 run, but wont hurt for now.
27805 * driver.cs: Smaller changes to accomodate the new code.
27807 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27810 * rootcontext.cs (CreateInterface): New method, used to create
27811 the System.TypeBuilder type for interfaces.
27812 (ResolveInterfaces): new entry point to resolve the interface
27814 (CodeGen): Property, used to keep track of the code generator.
27816 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27818 * cs-parser.jay: Add a second production for delegate_declaration
27821 (enum_body): Put an opt_comma here instead of putting it on
27822 enum_body or enum_member_declarations so we can handle trailing
27823 commas on enumeration members. Gets rid of a shift/reduce.
27825 (type_list): Need a COMMA in the middle.
27827 (indexer_declaration): Tell tokenizer to recognize get/set
27829 * Remove old targets.
27831 * Re-add the parser target.
27833 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27835 * cs-parser.jay: Add precendence rules for a number of operators
27836 ot reduce the number of shift/reduce conflicts in the grammar.
27838 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27840 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27843 Get rid of old crufty code.
27845 * rootcontext.cs: Use this to keep track of the parsed
27846 representation and the defined types available to the program.
27848 * gen-treedump.cs: adjust for new convention.
27850 * type.cs: Split out the type manager, and the assembly builder
27853 * typemanager.cs: the type manager will live here now.
27855 * cil-codegen.cs: And the code generator here.
27857 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27859 * makefile: Fixed up for easy making.
27861 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27863 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27866 (unary_expression): Expand pre_increment_expression and
27867 post_decrement_expression to reduce a shift/reduce.
27869 2001-07-11 Simon Cozens
27871 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27873 Improve allow_keyword_as_indent name.
27875 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27877 * Adjustments for Beta2.
27879 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27881 * decl.cs: Added `Define' abstract method.
27882 (InTransit): new property, used to catch recursive definitions.
27884 * interface.cs: Implement `Define'.
27886 * modifiers.cs: Map Modifiers.constants to
27887 System.Reflection.TypeAttribute flags.
27889 * class.cs: Keep track of types and user-defined types.
27890 (BuilderInit): New method for creating an assembly
27891 (ResolveType): New function to launch the resolution process, only
27892 used by interfaces for now.
27894 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27895 that are inserted into the name space.
27897 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27899 * ARGH. I have screwed up my tree so many times due to the use of
27900 rsync rather than using CVS. Going to fix this at once.
27902 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27905 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27907 * Experiment successful: Use System.Type rather that our own
27910 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27912 * cs-parser.jay: Removed nsAliases from here.
27914 Use new namespaces, handle `using XXX;'
27916 * namespace.cs: Reimplemented namespace handling, use a recursive
27917 definition of the class. Now we can keep track of using clauses
27918 and catch invalid using clauses.
27920 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27922 * gen-treedump.cs: Adapted for all the renaming.
27924 * expression.cs (Expression): this class now has a Type property
27925 which returns an expression Type.
27927 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27928 `Type', as this has a different meaning now in the base
27930 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27932 * interface.cs, class.cs: Removed from all the sources the
27933 references to signature computation, as we can not do method
27934 signature computation during the parsing time, as we are not
27935 trying to solve at that point distinguishing:
27939 void a (NS.Blah x) {}
27942 Which depending on the context might be valid or not, as we do not
27943 know if Blah is the same thing as NS.Blah at that point.
27945 * Redid everything so the code uses TypeRefs now instead of
27946 Types. TypeRefs are just temporary type placeholders, that need
27947 to be resolved. They initially have a pointer to a string and the
27948 current scope in which they are used. This is used later by the
27949 compiler to resolve the reference to an actual Type.
27951 * DeclSpace is no longer a CIR.Type, and neither are
27952 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27953 are all DeclSpaces, but no Types.
27955 * type.cs (TypeRefManager): This implements the TypeRef manager,
27956 which keeps track of all the types that need to be resolved after
27957 the parsing has finished.
27959 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27961 * ARGH. We are going to have to store `foreach' as a class rather
27962 than resolving it, as we need to verify error 1579 after name
27963 resolution. *OR* we could keep a flag that says `This request to
27964 IEnumerator comes from a foreach statement' which we can then use
27965 to generate the error.
27967 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27969 * class.cs (TypeContainer.AddMethod): we now add methods to the
27970 MethodGroup instead of the method hashtable.
27972 * expression.cs: Add MethodGroup abstraction, which gets us one
27973 step closer to the specification in the way we handle method
27976 * cs-parser.jay (primary_expression): qualified_identifier now
27977 tried to match up an identifier to a local variable reference or
27978 to a parameter reference.
27980 current_local_parameters is now a parser global variable that
27981 points to the current parameters for the block, used during name
27984 (property_declaration): Now creates an implicit `value' argument to
27987 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27989 * parameter.cs: Do not use `param' arguments as part of the
27990 signature, per the spec.
27992 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27994 * decl.cs: Base class for classes, structs and interfaces. This
27995 is the "Declaration Space"
27997 * cs-parser.jay: Use CheckDef for checking declaration errors
27998 instead of having one on each function.
28000 * class.cs: Factor out some code for handling error handling in
28001 accordance to the "Declarations" section in the "Basic Concepts"
28002 chapter in the ECMA C# spec.
28004 * interface.cs: Make all interface member classes derive from
28005 InterfaceMemberBase.
28007 2001-05-07 Miguel de Icaza <miguel@ximian.com>
28009 * Many things: all interfaces are parsed and generated in
28010 gen-treedump. Support for member variables, constructors,
28011 destructors, properties, constants is there.
28013 Beginning of the IL backend, but very little done, just there for
28016 2001-04-29 Miguel de Icaza <miguel@ximian.com>
28018 * cs-parser.jay: Fix labeled statement.
28020 * cs-tokenizer.cs (escape): Escape " and ' always.
28021 ref_line, ref_name: keep track of the line/filename as instructed
28022 by #line by the compiler.
28025 2001-04-27 Miguel de Icaza <miguel@ximian.com>
28027 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
28028 to match the values in System.CodeDOM.
28030 Divid renamed to Divide.
28032 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
28034 (Statements.set): remove.
28036 * System.CodeDOM/CodeCatchClause.cs: always have a valid
28039 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
28040 falseStatements always have valid values.
28042 * cs-parser.jay: Use System.CodeDOM now.