1 2010-06-17 Marek Safar <marek.safar@gmail.com>
4 * cs-parser.jay: Correctly set expression mode for default parameter
7 2010-06-17 Marek Safar <marek.safar@gmail.com>
10 * ecore.cs: Resolve dynamic namespace and keyword collision in the
11 favour of the keyword.
13 2010-06-17 Marek Safar <marek.safar@gmail.com>
16 * convert.cs: Allow more undocumented 0 like values to enum type
19 2010-06-17 Marek Safar <marek.safar@gmail.com>
21 * generic.cs, method.cs: Inflate copied type parameters from base
22 class or explicit interfaces.
24 * convert.cs: Fixed conversion between two type parameters.
27 2010-06-16 Marek Safar <marek.safar@gmail.com>
29 * membercache.cs, convert.cs: Correctly resize an array used by
32 2010-06-15 Marek Safar <marek.safar@gmail.com>
35 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
36 generated member access left expression.
38 2010-06-16 Marek Safar <marek.safar@gmail.com>
40 * expression.cs: Dispatch dynamic invocation solely on left
43 2010-06-16 Marek Safar <marek.safar@gmail.com>
45 * expression.cs, statement.cs: Always persist explicit cast
46 semantic at expression level.
48 2010-06-15 Marek Safar <marek.safar@gmail.com>
50 * expression.cs, attribute.cs: Enable generic type parameters
53 2010-06-15 Marek Safar <marek.safar@gmail.com>
56 * generic.cs: Don't use fixed array for inflated type parameter
57 interface constraints.
59 2010-06-15 Marek Safar <marek.safar@gmail.com>
61 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
63 * report.cs: Unwrap elements for related symbols reporting.
65 2010-06-15 Marek Safar <marek.safar@gmail.com>
68 * cs-tokenizer.cs: Offset correctly keywords the first character
71 2010-06-15 Marek Safar <marek.safar@gmail.com>
74 * expression.cs: Removed too aggressive object initializers
77 2010-06-15 Marek Safar <marek.safar@gmail.com>
79 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
80 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
81 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
82 any intermediate steps and fake nodes, also saves few MBs of memory.
84 2010-06-11 Marek Safar <marek.safar@gmail.com>
86 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
87 precise modifiers parsing.
89 2010-06-09 Marek Safar <marek.safar@gmail.com>
91 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
92 Fixed few shift/reduce conflicts.
94 2010-06-09 Marek Safar <marek.safar@gmail.com>
96 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
97 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
98 specifiers and stop using string in AST.
100 2010-06-07 Marek Safar <marek.safar@gmail.com>
102 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
103 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
104 enum.cs: Hold location of predefined types.
106 2010-06-07 Marek Safar <marek.safar@gmail.com>
108 A fix for bug #610878
109 * pending.cs: Clone cached list before modifying.
111 2010-06-04 Marek Safar <marek.safar@gmail.com>
113 * convert.cs, typespec.cs, expression.cs: Start using array member
114 kind for better conversion checks.
116 * import.cs, report.cs: Report better error message for runtime
119 2010-06-04 Marek Safar <marek.safar@gmail.com>
121 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
122 user defined conversion probing and simplify user conversion for
123 nullabe types. Fixes #610940.
125 2010-06-03 Marek Safar <marek.safar@gmail.com>
127 A fix for bug #610919
128 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
129 parameters for explicit event accessors. Anonymous method capturing
130 won't otherwise work for event implicit parameter.
132 2010-06-02 Marek Safar <marek.safar@gmail.com>
134 A fix for bug #610088
135 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
136 Ignore overrides for base overload resolution as for non-base
137 expressions and convert the best candidate to closest override
140 2010-06-01 Marek Safar <marek.safar@gmail.com>
142 A fix for bug #610139
143 * generic.cs, convert.cs: Recursively check effective base interface
145 2010-06-01 Marek Safar <marek.safar@gmail.com>
147 * statement.cs: Handle nullable types and type parameters in using
148 statement, avoid boxing value types. Also fixes #571010
150 2010-06-01 Marek Safar <marek.safar@gmail.com>
152 * convert.cs, expression.cs: Emit unbox for underlying nullable
155 2010-05-29 Marek Safar <marek.safar@gmail.com>
157 A fix for bug #610126
158 * expression.cs: Don't use branch optimization for types bigger than
161 2010-05-28 Marek Safar <marek.safar@gmail.com>
163 A fix for bug #609088
164 * import.cs: Check private modifier correctly.
166 2010-05-28 Marek Safar <marek.safar@gmail.com>
168 A fix for bug #609049
169 * ecore.cs: Don't ignore override methods when looking for base
172 2010-05-27 Marek Safar <marek.safar@gmail.com>
174 A fix for bugs #608007, #572540, #566130, #476358
176 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
177 More tricky refactoring of implicit linq blocks.
179 2010-05-25 Marek Safar <marek.safar@gmail.com>
181 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
183 2010-05-25 Marek Safar <marek.safar@gmail.com>
185 * context.cs, expression.cs, cs-parser.jay: Don't store current
186 block in This expression (it's too early for linq blocks).
188 2010-05-21 Marek Safar <marek.safar@gmail.com>
190 * expression.cs: Use constrained prefix more broadly to avoid boxing.
192 2010-05-20 Marek Safar <marek.safar@gmail.com>
194 A fix for bug #591149
195 * nullable.cs: Don't double wrap same expression.
197 2010-05-20 Marek Safar <marek.safar@gmail.com>
199 A fix for bug #569827
200 * anonymous.cs: Any issued error in probing mode means no match.
202 2010-05-20 Marek Safar <marek.safar@gmail.com>
204 * expression.cs: Search for base indexer using the closest match
207 2010-05-20 Marek Safar <marek.safar@gmail.com>
209 A fix for bug #572071
210 * method.cs: Set override constraints using unexpanded interface
213 2010-05-20 Marek Safar <marek.safar@gmail.com>
215 A fix for bug #572071
216 * ecore.cs: Include secondary extension method lookup in probing
219 2010-05-19 Marek Safar <marek.safar@gmail.com>
221 A fix for bug #515801
222 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
225 2010-05-19 Marek Safar <marek.safar@gmail.com>
227 A fix for bug #515801
228 * pending.cs: Advance counter correctly.
230 2010-05-19 Marek Safar <marek.safar@gmail.com>
232 A fix for bug #480139
233 * method.cs, pending.cs: Indexer override uses base name.
235 2010-05-19 Marek Safar <marek.safar@gmail.com>
237 A fix for bug #424064
238 * generic.cs: Replace original with inflated type parameter on
241 2010-05-19 Marek Safar <marek.safar@gmail.com>
243 A fix for bug #359733
244 * parameter.cs: Extension attribute can be defined in each assembly.
246 2010-05-18 Marek Safar <marek.safar@gmail.com>
248 A fix for bug #446507
249 * method.cs: Only one method can implement an interface.
251 2010-05-18 Marek Safar <marek.safar@gmail.com>
253 A fix for bug #594905
254 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
255 Typed null can be used as a source for expression methods.
257 2010-05-18 Marek Safar <marek.safar@gmail.com>
259 A fix for bug #606551
260 * namespace.cs: Using directive imports only types and not nested
263 2010-05-17 Marek Safar <marek.safar@gmail.com>
265 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
266 delegate.cs: Member instance is resolved after member overload
267 definitely resolves static/instance property of member expression.
268 Fixes #545047, #358848, #456605, #460016, #603299
270 2010-05-12 Marek Safar <marek.safar@gmail.com>
272 A fix for bug #604981
273 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
274 details for nested anonymous methods stories.
276 2010-05-11 Marek Safar <marek.safar@gmail.com>
278 A fix for bug #604735
279 * namespace.cs: Don't report namespace collision.
281 2010-05-11 Marek Safar <marek.safar@gmail.com>
283 A fix for bug #604748
284 * class.cs, typespec.cs: Search full imported attribute hierarchy
287 2010-05-11 Marek Safar <marek.safar@gmail.com>
289 * namespace.cs: Ignore missing dependencies failure at
292 2010-05-11 Marek Safar <marek.safar@gmail.com>
294 A fix for bug #604640
295 * namespace.cs: Don't resolve using constraints too early.
297 2010-05-11 Marek Safar <marek.safar@gmail.com>
299 A fix for bug #604239
300 * generic.cs: Copy partial type constraints to partial container.
302 2010-05-10 Marek Safar <marek.safar@gmail.com>
304 A fix for bug #557210
305 * import.cs: Relax underlying enum field rules.
307 2010-05-10 Marek Safar <marek.safar@gmail.com>
309 A fix for bug #603476
310 * property.cs: Implement IParametersMember for indexer accessors.
312 2010-05-07 Marek Safar <marek.safar@gmail.com>
314 A fix for bug #601141
315 * class.cs: Update all partial modifiers.
317 2010-05-06 Marek Safar <marek.safar@gmail.com>
319 A fix for bug #601708
320 * method.cs, membercache.cs: Destructors cannot be hidden.
322 2010-05-06 Marek Safar <marek.safar@gmail.com>
324 A fix for bug #602551
325 * class.cs: Resursive reference of type definition is allowed.
327 2010-05-06 Marek Safar <marek.safar@gmail.com>
329 * anonymous.cs: Mutate cached storey instance types too.
331 2010-05-06 Marek Safar <marek.safar@gmail.com>
333 A fix for bug #602443
334 * convert.cs: Explicit enum conversion cannot involve user operators
336 2010-05-05 Miguel de Icaza <miguel@novell.com>
338 * class.cs (TypeContainer.DefineBaseTypes)
339 (TypeContainer.CheckRecursiveDefinition): check for the iface not
340 being null, as we could have failed resolution and crashed;
343 * cs-parser.jay: Productions to catch common mistakes when other
344 punctuation operators are used instead of comma. Fixes 571702
346 2010-05-05 Marek Safar <marek.safar@gmail.com>
348 * anonymous.cs: Mutate correct set of constraints.
350 2010-05-05 Marek Safar <marek.safar@gmail.com>
352 A fix for bug #602842
353 * expression.cs: Resolve all array bound arguments.
355 2010-05-05 Marek Safar <marek.safar@gmail.com>
357 * import.cs: Don't import private fields.
359 2010-04-30 Marek Safar <marek.safar@gmail.com>
361 Partially based on patch by <sami.lamti@gmail.com>
363 * eval.cs, ecore.cs: Fixed eval show methods.
365 2010-04-30 Marek Safar <marek.safar@gmail.com>
367 * generic.cs, delegate.cs: Implement output type inference of
368 methodgroup now when the specification was cleared at least little
371 2010-04-29 Marek Safar <marek.safar@gmail.com>
373 A fix for bug #575611
374 * class.cs: Fix recursive unmanaged recursice sruct check.
376 2010-04-29 Marek Safar <marek.safar@gmail.com>
378 A fix for bug #479776
379 * expression.cs: Implement typeof unbounded nested generic types.
381 2010-04-29 Marek Safar <marek.safar@gmail.com>
383 A fix for bug #474953
384 * class.cs: Fix valid recursive base type definition.
386 2010-04-29 Marek Safar <marek.safar@gmail.com>
388 A fix for bug #421737
389 * convert.cs, expression.cs: A boxing conversion exists from a
390 nullable-type to a reference type, if a boxing conversion exists
391 from the underlying non-nullable-value-type to the reference type.
393 2010-04-29 Marek Safar <marek.safar@gmail.com>
395 A fix for bug #376875
396 * import.cs: Import volatile modifier.
398 2010-04-29 Marek Safar <marek.safar@gmail.com>
400 A fix for bug #372412
401 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
404 2010-04-29 Marek Safar <marek.safar@gmail.com>
406 A fix for bug #568955
407 * statements.cs: Handle recursive scope initializers.
409 2010-04-28 Marek Safar <marek.safar@gmail.com>
411 A fix for bug #566511
412 * anonymous.cs: Always get inflated version of hoisted variable
413 on generic type definition.
415 2010-04-28 Marek Safar <marek.safar@gmail.com>
417 * import.cs, membercache.cs: Relax rules for valid properties.
419 2010-04-28 Marek Safar <marek.safar@gmail.com>
421 * import.cs: Intern arrays used in generic arguments.
423 2010-04-28 Marek Safar <marek.safar@gmail.com>
425 A fix for bug #600398
426 * convert.cs: Actually use effective base type for the comparison.
428 2010-04-28 Marek Safar <marek.safar@gmail.com>
430 A fix for bug #600326
431 * ecore.cs: Pass arity to base member lookup.
433 2010-04-28 Marek Safar <marek.safar@gmail.com>
435 A fix for bug #573385
436 * expression.cs: MemberAccess is of generic type based on right
439 2010-05-28 Marek Safar <marek.safar@gmail.com>
441 * cs-tokenizer.cs: Made tab size configurable.
443 2010-05-27 Marek Safar <marek.safar@gmail.com>
445 * attribute.cs: Ensure Obsolete members are defined before doing
448 2010-05-27 Marek Safar <marek.safar@gmail.com>
450 * visit.cs: Add DOM visitor skeleton.
454 2010-05-27 Marek Safar <marek.safar@gmail.com>
456 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
458 2010-05-27 Marek Safar <marek.safar@gmail.com>
460 * *.cs: Major rewrite of compiler internals to better work with
461 unmodified System.Reflection.Emit. Some of the key changes are
462 - TypeSpec replaces reflection specific System.Type.
463 - All Type(TypeSpec) operations are now done in compiler therefore
464 no dependency on SRE to inflate generic members and types or to
465 query unclosed types.
466 - MemberCache is now the only and full hierarchical topology.
467 - Generic constraints are implemented properly.
468 - And as a bonus compilation is on average 30% faster.
470 2010-04-15 Jb Evain <jbevain@novell.com>
472 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
474 2010-04-12 Marek Safar <marek.safar@gmail.com>
476 * expression.cs, attribute.cs, parameter.cs: More attribute type
479 2010-04-12 Marek Safar <marek.safar@gmail.com>
481 A fix for bug #593342
483 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
484 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
485 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
486 codegen.cs: Add custom attribute encoder to deal with unfinished
487 types and easier corlib bootstrap from its own types.
489 2010-03-26 Marek Safar <marek.safar@gmail.com>
491 * cs-parser.jay: Report invalid constraint types.
493 2010-03-16 Jb Evain <jbevain@novell.com>
495 * Makefile: rename the net_2_1 profile to moonlight.
497 2010-03-11 Marek Safar <marek.safar@gmail.com>
499 * statement.cs, cs-parser.jay: Use correct location for empty
502 2010-03-11 Marek Safar <marek.safar@gmail.com>
504 * cs-parser.jay: Disable Location from expression.
506 * generic.cs: Check constraints for overrides in the parser.
508 2010-03-09 Marek Safar <marek.safar@gmail.com>
510 * cs-parser.jay (GetLocation): Use an expression when available.
512 2010-03-04 Marek Safar <marek.safar@gmail.com>
514 A fix for bug #582579
515 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
517 2010-03-04 Marek Safar <marek.safar@gmail.com>
519 A patch by kornelpal@gmail.com
521 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
522 compiler generated classes sealed by default. Emit and close top
523 level compiler generated classes as well.
525 * support.cs: Use RuntimeHelpers.GetHashCode.
527 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
529 * Makefile: We need to use the internal bootstrapping gmcs for
530 net_2_1_bootstrap too now.
532 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
534 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
536 2010-03-02 Marek Safar <marek.safar@gmail.com>
538 * cs-tokenizer.cs: Missed few locations in previous fix.
540 2010-03-02 Marek Safar <marek.safar@gmail.com>
542 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
543 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
544 Report correct location for operator errors.
546 2010-03-02 Marek Safar <marek.safar@gmail.com>
548 * typemanager.cs (IsDynamicType): Don't check external types when
549 the attribute is not external.
551 2010-02-24 Marek Safar <marek.safar@gmail.com>
553 A fix for bug #582579
554 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
557 2010-02-24 Marek Safar <marek.safar@gmail.com>
559 A fix for bug #581804
560 * ecore.cs: Fixed type comparison.
562 2010-02-08 Miguel de Icaza <miguel@novell.com>
564 * namespace.cs (CompletionGetTypesStartingWith): Do not include
565 private types in the completion results.
567 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
570 2010-02-17 Marek Safar <marek.safar@gmail.com>
572 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
575 2010-02-14 Miguel de Icaza <miguel@novell.com>
577 * eval.cs: Do not do the report printer dance unless the user has
578 set the DescribeTypes feature.
580 2010-02-10 Marek Safar <marek.safar@gmail.com>
582 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
584 2010-02-08 Marek Safar <marek.safar@gmail.com>
586 A fix for bug #577029
587 * anonymous.cs: Fixed TypeBuilder* check.
589 2010-02-06 Miguel de Icaza <miguel@novell.com>
591 * eval.cs (CompileBlock): Also undo if there are problems during
592 semantic analysis, fixes various cases where invalid C# code would
593 be reported, but the internal changes would not be undone.
595 2010-02-03 Miguel de Icaza <miguel@novell.com>
597 * driver.cs: Change the --fatal flag to allow a number to be
598 passed, this ignores the first N fatal errors. Useful to debug
599 errors that do not happen on the first hit.
601 * cs-parser.jay (invocation_expression): accept both the
602 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
603 inside an invocation.
605 * driver.cs: Expose FatalErrors.
607 * eval.cs: Initialize the printer's Fatal property from the
608 Driver's FatalError flag, this allows csharp --fatal to work
611 Add support for calling Describe (typeof (TYPE)) if the expression
614 2010-02-02 Marek Safar <marek.safar@gmail.com>
616 A fix for bug #574991
617 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
620 2010-02-02 Marek Safar <marek.safar@gmail.com>
622 A fix for bug #575986
623 * expression.cs: Don't mutate typeof type definitions.
625 2010-01-28 Marek Safar <marek.safar@gmail.com>
627 * decl.cs: Use only one set of modifiers.
629 2010-01-26 Marek Safar <marek.safar@gmail.com>
631 A fix for bug #573329
632 * eval.cs: Don't disable error reporting completely on silent mode.
634 2010-01-25 Marek Safar <marek.safar@gmail.com>
636 A fix for bug #573312
637 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
638 pointer index of unknown size types greater than 2.
640 2010-01-15 Marek Safar <marek.safar@gmail.com>
642 * *.cs: Use only 1 member kind enum.
644 2010-01-15 Marek Safar <marek.safar@gmail.com>
646 * *.cs: Add event specification.
648 2010-01-14 Marek Safar <marek.safar@gmail.com>
650 * membercache.cs: Extracted from decl.cs.
652 * *.cs: Put more infrastructure in place.
654 2010-01-13 Marek Safar <marek.safar@gmail.com>
656 * *.cs: Add property specification, unused yet.
658 2010-01-13 Marek Safar <marek.safar@gmail.com>
660 * property.cs: Move all property based declarations into a new file.
662 2010-01-13 Marek Safar <marek.safar at gmail.com>
664 * expression.cs (Conditional): Resolve reduced expression.
666 2010-01-13 Marek Safar <marek.safar at gmail.com>
668 * *.cs: Introduced non-generic method specification.
670 2010-01-07 Marek Safar <marek.safar@gmail.com>
672 * method.cs: Move all method based declarations into a new file.
674 2010-01-07 Marek Safar <marek.safar@gmail.com>
676 * *.cs: Extract field specification.
678 2009-12-17 Marek Safar <marek.safar@gmail.com>
680 * field.cs: Extracted from class.cs
682 2009-12-15 Marek Safar <marek.safar@gmail.com>
684 * attribute.cs (GetFixedBuffer): Work on field definition only.
686 2009-12-15 Marek Safar <marek.safar@gmail.com>
688 * *.cs: Clean up NET_4_0 conditional where possible.
690 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
692 support.cs (DynamicType): Assembly property returns the assembly builder.
693 This is required due to how compiler context works in corlib.
695 2009-12-14 Marek Safar <marek.safar@gmail.com>
697 A fix for bug #564376
698 * assign.cs (LocalTemporary): Removed no longer needed special
701 2009-12-11 Marek Safar <marek.safar@gmail.com>
703 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
704 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
705 enum for easier debugging.
707 2009-12-10 Marek Safar <marek.safar@gmail.com>
709 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
712 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
715 2009-12-10 Marek Safar <marek.safar@gmail.com>
717 * cs-parser.jay, statement.cs: Handle parser error in code
720 2009-12-10 Marek Safar <marek.safar@gmail.com>
722 * ecore.cs: Ignore base imported methods when they are already
725 * eval.cs: Handle non-existent keys.
727 * report.cs, driver.cs: Make fatal work with console printer only.
729 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
731 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
733 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
735 * typemanager.cs: Add MakeGenericMethod that checks if the method
736 is really the generic method definition.
738 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
739 to inflate generic methods.
741 2009-12-08 Marek Safar <marek.safar@gmail.com>
743 A fix for bug #561149
744 * anonymous.cs: Use actual type parameters when checking for generic
747 2009-12-08 Marek Safar <marek.safar@gmail.com>
749 A fix for bug #561369
750 * expression.cs (DoNumericPromotion): Fixed typo.
752 2009-12-08 Marek Safar <marek.safar@gmail.com>
754 *.cs: Moving to generics world.
756 cs-parser.jay: Removed current_array_type.
758 2009-12-07 Marek Safar <marek.safar@gmail.com>
760 *.cs: Moving to generics world.
762 2009-12-04 Marek Safar <marek.safar@gmail.com>
764 *.cs: Moving to generics world (day 2).
766 2009-12-03 Marek Safar <marek.safar@gmail.com>
768 *.cs: Moving to generics world.
770 2009-12-02 Marek Safar <marek.safar@gmail.com>
772 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
773 Encode dynamic type attribute for elements where attributes cannot
776 2009-12-01 Marek Safar <marek.safar@gmail.com>
778 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
781 2009-12-01 Marek Safar <marek.safar@gmail.com>
783 A fix for bug #360455
784 * class.cs: Never report a unused warning for generic events to
785 workaround wrong expression type.
787 2009-11-30 Marek Safar <marek.safar@gmail.com>
789 A fix for bug #558305
790 * decl.cs, class.cs: Check partial method definitions using correct
793 2009-11-30 Marek Safar <marek.safar@gmail.com>
795 * argument.cs: Don't cache rarely used dynamic flag.
797 2009-11-27 Marek Safar <marek.safar@gmail.com>
799 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
801 2009-11-27 Marek Safar <marek.safar@gmail.com>
803 * ecore.cs (SimpleName): Removed no longer needed in_transit as
804 Resolve is now non-reentrant (saves ~0.6MB for corlib).
806 2009-11-26 Marek Safar <marek.safar@gmail.com>
808 A fix for bug #545081
809 * decl.cs: Check private nested types of nested types recursively.
811 2009-11-26 Marek Safar <marek.safar@gmail.com>
813 A fix for bug #558305
814 * location.cs: Ignore self referencing #line directive
816 2009-11-26 Marek Safar <marek.safar@gmail.com>
818 A fix for bug #558292
819 * class.cs: Allow single unsafe fixed buffer fields.
821 2009-11-26 Marek Safar <marek.safar@gmail.com>
823 * expression: Optimize few more zero-based operations.
825 2009-11-26 Marek Safar <marek.safar@gmail.com>
827 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
828 avoids boxing of literal values.
830 2009-11-26 Marek Safar <marek.safar@gmail.com>
832 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
833 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
834 codegen.cs: LocatedToken redesing to avoid excessive allocation and
835 boxing (saves ~7MB for corlib). Also fixes presise token location.
837 2009-11-25 Marek Safar <marek.safar@gmail.com>
839 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
842 2009-11-24 Marek Safar <marek.safar@gmail.com>
844 * expression.cs: Lower static array initializer barrier.
846 * support.cs, driver.cs: Share reader buffer.
848 2009-11-23 Marek Safar <marek.safar@gmail.com>
850 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
852 2009-11-23 Marek Safar <marek.safar@gmail.com>
854 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
855 cleanup some obsolete code.
857 2009-11-20 Marek Safar <marek.safar@gmail.com>
859 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
862 2009-11-20 Marek Safar <marek.safar@gmail.com>
864 * *.cs: Resolved expressions are never resolved again, this helps to
865 uncover some not easy to find bugs and improve the performance.
867 2009-11-19 Marek Safar <marek.safar@gmail.com>
869 * *.cs: Made constant expressions fully compatible with any other
872 2009-11-19 Marek Safar <marek.safar@gmail.com>
874 * *.cs: DoResolve is a worker method and has to be protected.
876 2009-11-18 Marek Safar <marek.safar@gmail.com>
878 * *.cs: More context specific handling.
880 2009-11-17 Marek Safar <marek.safar@gmail.com>
882 * *.cs: More context specific handling.
884 2009-11-16 Marek Safar <marek.safar@gmail.com>
886 * dynamic.cs, class.cs: Removed few fixed user types conversions.
888 * symbolwriter.cs: Uses public ILOffset.
890 2009-11-13 Marek Safar <marek.safar@gmail.com>
892 A fix for bug #553650
893 * generic.cs: Another missing TypeToCoreType, still too many to fix.
895 2009-11-13 Marek Safar <marek.safar@gmail.com>
897 A fix for bug #555170
899 * class.cs, delegate.cs, enum.cs: Constants have to be available
900 for parameters resolve.
902 2009-11-12 Marek Safar <marek.safar@gmail.com>
904 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
907 2009-11-12 Marek Safar <marek.safar@gmail.com>
909 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
910 with a statically known candidate set.
912 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
914 * generic.cs: Made type inflation for generic constraint checks
915 recursive. This fixes BGO #553655.
917 2009-11-11 Marek Safar <marek.safar@gmail.com>
919 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
922 2009-11-10 Marek Safar <marek.safar@gmail.com>
924 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
925 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
926 attribute.cs: Add some dynamic error checking.
928 2009-11-07 Marek Safar <marek.safar@gmail.com>
930 A fix for bug #553465
932 * expression.cs: Fixed mixed version of expression tree anonymous
935 2009-11-06 Marek Safar <marek.safar@gmail.com>
937 A fix for bug #553031
939 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
940 expression tree version of anonymous type with members declaration.
942 2009-11-05 Marek Safar <marek.safar@gmail.com>
944 * parameter.cs: Handle nullable parameter default expression.
946 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
947 class.cs, attribute.cs: Check for wrong dynamic arguments.
949 2009-11-05 Marek Safar <marek.safar@gmail.com>
951 * statement.cs: Dynamic statements.
953 2009-11-04 Marek Safar <marek.safar@gmail.com>
955 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
956 Compound assignments over dynamic type.
958 2009-11-03 Marek Safar <marek.safar@gmail.com>
960 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
961 constructor arguments.
963 2009-10-30 Marek Safar <marek.safar@gmail.com>
965 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
966 codegen.cs: Unary mutator on dynamic member access expression.
968 2009-10-29 Marek Safar <marek.safar@gmail.com>
970 A fix for bug #550580
971 * convert.cs: Don't eliminate explicit precission casts.
973 2009-10-28 Marek Safar <marek.safar@gmail.com>
975 A fix for bug #550404
977 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
978 expression.cs, statement.cs, ecore.cs: Quote any nested expression
981 2009-10-27 Marek Safar <marek.safar@gmail.com>
983 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
986 * class.cs: Allow nullable binary user operators.
988 2009-10-26 Marek Safar <marek.safar@gmail.com>
990 * expression.cs: Move binary expression optimization at the end of
993 2009-10-23 Marek Safar <marek.safar@gmail.com>
995 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
996 Separate NullConstant from NullLiteral.
998 2009-10-23 Marek Safar <marek.safar@gmail.com>
1000 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1001 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1002 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1003 ModuleContainer. Add common unclosed member check routine.
1005 2009-10-22 Marek Safar <marek.safar@gmail.com>
1007 * argument.cs: Use literal flag for real literals only.
1009 * dynamic.cs: Use correct return type for custom delegates.
1011 2009-10-22 Marek Safar <marek.safar@gmail.com>
1013 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1016 2009-10-22 Marek Safar <marek.safar@gmail.com>
1018 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1020 2009-10-21 Marek Safar <marek.safar@gmail.com>
1022 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1025 2009-10-21 Marek Safar <marek.safar@gmail.com>
1027 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1030 2009-10-20 Marek Safar <marek.safar@gmail.com>
1032 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1034 2009-10-19 Marek Safar <marek.safar@gmail.com>
1036 * typemanager.cs, expression.cs: Dynamic array initializer.
1038 2009-10-16 Marek Safar <marek.safar@gmail.com>
1040 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1043 2009-10-16 Marek Safar <marek.safar@gmail.com>
1045 A fix for bug #493523, #507067
1046 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1047 standard nullable conversion using underlying standard conversion
1048 and not full conversion.
1050 2009-10-15 Marek Safar <marek.safar@gmail.com>
1052 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1053 type in VerifyArgumentsCompat.
1055 2009-10-15 Marek Safar <marek.safar@gmail.com>
1057 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1058 Reject variable used with type arguments.
1060 2009-10-14 Marek Safar <marek.safar@gmail.com>
1062 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1063 Implement dynamic expressions assignment.
1065 2009-10-14 Marek Safar <marek.safar@gmail.com>
1067 * expression.cs: Build underlying expression when resolving unary
1070 2009-10-14 Marek Safar <marek.safar@gmail.com>
1072 * expression.cs: Emit enum array initializer using binary blob.
1074 2009-10-08 Marek Safar <marek.safar@gmail.com>
1076 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1079 2009-10-07 Marek Safar <marek.safar@gmail.com>
1081 * typemanager.cs: Reset object_type.
1083 * assign: Made SimpleAssign public.
1085 2009-10-06 Marek Safar <marek.safar@gmail.com>
1087 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1088 invocation assembly to IsThisOrFriendAssembly.
1090 2009-10-05 Marek Safar <marek.safar@gmail.com>
1092 * expression.cs: Equality comparison of generic parameter with
1095 2009-10-05 Marek Safar <marek.safar@gmail.com>
1097 A fix for bug #543570
1098 * generic.cs: Import predefined constraints correctly.
1100 2009-10-02 Marek Safar <marek.safar@gmail.com>
1102 * ecore.cs: Don't crash on overloads with optional paremeters where
1103 arguments count overflows.
1105 * parameter.cs: Import optional parameter constants using optional
1108 2009-10-01 Marek Safar <marek.safar@gmail.com>
1110 * Makefile: Default is gmcs compiler.
1112 2009-10-01 Marek Safar <marek.safar@gmail.com>
1114 * cs-parser.jay: Fixed few NRE.
1116 2009-10-01 Marek Safar <marek.safar@gmail.com>
1118 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1120 2009-09-30 Marek Safar <marek.safar@gmail.com>
1122 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1123 ShimExpression, ImplicitCast.
1125 2009-09-30 Marek Safar <marek.safar@gmail.com>
1127 A fix for bug #542959
1128 * delegate.cs: Emit correct delegate instance variable when there
1129 are static and non-static overloads.
1131 2009-09-29 Marek Safar <marek.safar@gmail.com>
1133 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1134 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1136 2009-09-28 Marek Safar <marek.safar@gmail.com>
1138 A fix for bug #542487
1139 * ecore.cs: Resolve extension methods hidden by properties.
1141 2009-09-25 Marek Safar <marek.safar@gmail.com>
1143 * expression.cs, ecore.cs: More dynamic binary expressions.
1145 2009-09-22 Marek Safar <marek.safar@gmail.com>
1147 * nullable.cs, expression.cs: Fixed null lifted conversion for
1148 bitwise enum operations.
1150 2009-09-22 Marek Safar <marek.safar@gmail.com>
1152 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1153 values in checked context.
1155 2009-09-22 Marek Safar <marek.safar@gmail.com>
1157 * expression.cs, ecore.cs: Fixed array index constant conversion.
1159 2009-09-20 Miguel de Icaza <miguel@novell.com>
1161 * expression.cs: Do not crash when MemberLookup returns something
1162 that is not a MemberExpr here. Report error 582 instead.
1166 2009-09-18 Marek Safar <marek.safar@gmail.com>
1168 * decl.cs, class.cs: Check protected property accessors.
1170 2009-09-18 Marek Safar <marek.safar@gmail.com>
1172 * dynamic.cs, assign.cs: Dynamic compound assignment.
1174 2009-09-17 Marek Safar <marek.safar@gmail.com>
1176 * expression.cs: Fixed compound assignment explicit conversion.
1178 2009-09-17 Marek Safar <marek.safar@gmail.com>
1180 * expression.cs, ecore.cs: Cannot infer variables from method group.
1182 2009-09-16 Marek Safar <marek.safar@gmail.com>
1184 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1185 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1186 codegen.cs: Dynamic binary operations scaffolding.
1188 2009-09-15 Marek Safar <marek.safar@gmail.com>
1190 * expression.cs: Fixes nullable promotion for enum type variables.
1192 2009-09-11 Marek Safar <marek.safar@gmail.com>
1194 * driver.cs, dynamic.cs: Reset more static variables.
1196 2009-09-11 Marek Safar <marek.safar@gmail.com>
1198 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1199 driver.cs: Introduced Expression::MakeExpression.
1201 2009-09-11 Marek Safar <marek.safar@gmail.com>
1203 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1205 2009-09-09 Marek Safar <marek.safar@gmail.com>
1207 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1210 2009-09-09 Marek Safar <marek.safar@gmail.com>
1212 A fix for bug #518707
1213 * expression.cs (Is): Optimize only generic parameter type
1214 expression probing value type generic parameter.
1216 2009-09-09 Marek Safar <marek.safar@gmail.com>
1218 A fix for bug #532571
1219 * ecore.cs: Check for simple name type arguments used with
1222 2009-09-08 Marek Safar <marek.safar@gmail.com>
1224 A fix for bug #497421
1225 * generic.cs (CheckConstraint): Don't use buildin types to check for
1226 parameterless constructor.
1228 2009-09-08 Marek Safar <marek.safar@gmail.com>
1230 A fix for bug #537402
1231 * generic.cs (CheckConstraint): Correctly inflate generic type
1232 arguments when checking generic method.
1234 2009-09-08 Marek Safar <marek.safar@gmail.com>
1236 A fix for bug #536463
1237 * decl.cs (AddToContainer): Don't report collision between explicit
1238 and parameterless non-explicit members.
1240 2009-09-08 Marek Safar <marek.safar@gmail.com>
1242 * eval.cs: Reset more static stuff.
1244 2009-09-07 Marek Safar <marek.safar@gmail.com>
1246 A fix for bug #324625
1247 * expression.cs, ecore.cs: Create nested generic type expression
1248 using declaring and not current type.
1250 2009-09-07 Marek Safar <marek.safar@gmail.com>
1252 * *.cs: Changed Report class to accept various output printers and
1253 be an instance class. An expression resolver can now use different
1254 message reporter for each call and Report.Error can safely throw
1255 an exception. Part of ongoing work to turn mcs into proper library.
1257 2009-09-04 Marek Safar <marek.safar@gmail.com>
1259 * statement.cs, ecore.cs: Removed error reporting from emit code.
1261 2009-09-04 Marek Safar <marek.safar@gmail.com>
1263 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1265 2009-09-03 Marek Safar <marek.safar@gmail.com>
1267 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1268 parser checks out of constructors.
1270 2009-09-02 Marek Safar <marek.safar@gmail.com>
1272 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1274 2009-09-02 Marek Safar <marek.safar@gmail.com>
1276 A fix for bug #535448
1277 * anonymous.cs, class.cs: Copy return label between all contexts.
1279 2009-09-02 Marek Safar <marek.safar@gmail.com>
1281 A fix for bug #535395
1282 * namespace.cs: Resolve context can be null.
1284 2009-08-25 Marek Safar <marek.safar@gmail.com>
1286 A fix for bug #533912
1287 * generic.cs: Use correct context for constraints resolving.
1289 2009-08-25 Marek Safar <marek.safar@gmail.com>
1291 A fix for bug #532630
1292 * driver.cs: Trim conditional symbols.
1294 2009-08-25 Marek Safar <marek.safar@gmail.com>
1296 * context.cs: New file.
1298 * *.exe.sources, *.csproj: Updated.
1300 2009-08-25 Marek Safar <marek.safar@gmail.com>
1302 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1303 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1304 IMembercontext, some small cleanups.
1306 2009-08-24 Marek Safar <marek.safar@gmail.com>
1308 * *.cs: Split ResolveContext and EmitContext.
1310 2009-08-24 Marek Safar <marek.safar@gmail.com>
1312 * *.cs: Only ResolveContext implements IMemberContext.
1314 2009-08-21 Marek Safar <marek.safar@gmail.com>
1316 * *.cs: Renamed IResolveContext to IMemberContext.
1318 2009-08-21 Marek Safar <marek.safar@gmail.com>
1320 * *.cs: Detached ResolveContext from EmitContext.
1322 2009-08-21 Marek Safar <marek.safar@gmail.com>
1324 * codegen.cs: Moved flow-analysis to BlockContext.
1326 2009-08-21 Marek Safar <marek.safar@gmail.com>
1328 * *.cs: Detached BlockContext from EmitContext.
1330 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1332 * statement.cs: avoid nullref when the return value of GetEnumerator()
1333 does not contain any MoveNext() method.
1335 2009-08-19 Marek Safar <marek.safar@gmail.com>
1337 * *.cs: Removed IResolveContext::GenericDeclContainer.
1339 2009-08-19 Marek Safar <marek.safar@gmail.com>
1341 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1343 2009-08-19 Marek Safar <marek.safar@gmail.com>
1345 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1346 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1348 2009-08-18 Marek Safar <marek.safar@gmail.com>
1350 * *.cs: Removed boolean fields from EmitContext.
1352 2009-08-18 Marek Safar <marek.safar@gmail.com>
1354 * *.cs: Add IResolveContext::IsStatic.
1356 2009-08-18 Marek Safar <marek.safar@gmail.com>
1358 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1360 2009-08-17 Marek Safar <marek.safar@gmail.com>
1362 * *.cs: Removed DeclContainer from EmitContext.
1364 2009-08-17 Marek Safar <marek.safar@gmail.com>
1366 * *.cs: Add IResolveContext::CurrentTypeParameters.
1368 2009-08-14 Marek Safar <marek.safar@gmail.com>
1370 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1372 2009-08-14 Marek Safar <marek.safar@gmail.com>
1374 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1375 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1377 2009-08-13 Marek Safar <marek.safar@gmail.com>
1379 * decl.cs: Look in PartialContainer for parent type parameters.
1381 2009-08-13 Marek Safar <marek.safar@gmail.com>
1383 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1384 codegen.cs: Add IResolveContext::LookupTypeParameter.
1386 2009-08-13 Marek Safar <marek.safar@gmail.com>
1388 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1389 Moved resolved logic from Emit to Resolve.
1391 2009-08-13 Marek Safar <marek.safar@gmail.com>
1393 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1394 codegen.cs: Reworked atttributes handling of ResolveContext.
1396 2009-08-12 Marek Safar <marek.safar@gmail.com>
1398 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1399 LookupNamespaceOrType to ResolveContext.
1401 2009-08-12 Marek Safar <marek.safar@gmail.com>
1403 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1404 class.cs: Removed unused parameters and methods.
1406 2009-08-11 Marek Safar <marek.safar@gmail.com>
1408 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1409 codegen.cs: Finding the best common type of a set of expressions for
1412 2009-08-07 Marek Safar <marek.safar@gmail.com>
1414 * dynamic.cs, expression.cs: More dynamic conversions.
1416 2009-08-06 Miguel de Icaza <miguel@novell.com>
1418 * generic.cs: This loop was incorrect, it was increment ii, but
1419 checking for `i'. This was a change introduced to fix #327497,
1422 * class.cs: Catch another case for cs0533 error, fixes #324782.
1424 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1426 * typemanager.cs (GetGenericArguments): SRE returns null for
1427 generic methods on type builder instances if they are not generic
1428 themselves. For example, for Foo<int>::Bar() it returns null, but
1429 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1431 2009-08-05 Marek Safar <marek.safar@gmail.com>
1433 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1434 delegate.cs: Work on dynamic binding.
1436 2009-08-04 Marek Safar <marek.safar@gmail.com>
1438 A second fix for bug #525342
1439 * class.cs: Attach partial method attributes to method
1442 2009-08-03 Marek Safar <marek.safar@gmail.com>
1444 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1447 * rootcontext.cs: Default to langversion v4.
1449 2009-08-03 Marek Safar <marek.safar@gmail.com>
1451 * pending.cs: Check return type before member info is set.
1453 2009-08-03 Marek Safar <marek.safar@gmail.com>
1455 * anonymous.cs: Fully initialize generic hoisted field expression.
1457 2009-08-02 Miguel de Icaza <miguel@novell.com>
1459 * cs-parser.jay: Flag variables declared on the interactive shell
1460 as used to prevent the 168 warning about local variable not being
1463 2009-07-31 Marek Safar <marek.safar@gmail.com>
1465 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1466 attribute.cs: Emit dynamic export attribute.
1468 2009-07-30 Marek Safar <marek.safar@gmail.com>
1470 * expression.cs: More verifier work.
1472 2009-07-29 Marek Safar <marek.safar@gmail.com>
1474 * nullable.cs: Fixed SRE crash during corlib compilation.
1476 2009-07-29 Marek Safar <marek.safar@gmail.com>
1478 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1479 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1480 More TypeManager.TypeToCoreType needed.
1482 2009-07-29 Marek Safar <marek.safar@gmail.com>
1484 * anonymous.cs: Update after recent SRE fixes.
1486 2009-07-28 Marek Safar <marek.safar@gmail.com>
1488 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1489 version of GetFieldHandle for fields of generic types.
1491 2009-07-27 Marek Safar <marek.safar@gmail.com>
1493 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1494 ecore.cs: Add TypeManager.IsDynamicType,
1495 PredefinedAttributes.Dynamic.
1497 2009-07-27 Marek Safar <marek.safar@gmail.com>
1499 A fix for bug #415375
1500 * expression.cs: Fixed object and reference type parameter
1503 2009-07-27 Marek Safar <marek.safar@gmail.com>
1505 A fix for bug #525342
1506 * class.cs: Attach partial method attributes to method
1509 2009-07-24 Marek Safar <marek.safar@gmail.com>
1511 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1514 2009-07-24 Marek Safar <marek.safar@gmail.com>
1516 * anonymous.cs (MutateField): Add imported types handling.
1518 2009-07-23 Marek Safar <marek.safar@gmail.com>
1520 * expression.cs, delegate.cs: Moved arguments resolve into their
1521 counterparts expressions. Removed argument resolve from
1522 CollectionElementInitializer.
1524 2009-07-23 Marek Safar <marek.safar@gmail.com>
1526 A fix for bug #523683
1527 * convert.cs, delegate.cs: Use common overload mechanism for method
1528 group conversion check.
1530 2009-07-22 Marek Safar <marek.safar@gmail.com>
1532 A fix for bug #523899
1533 * generics.cs: Exact type inference with other bound types.
1535 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1537 Don't complain when the same type is implemented by the output
1538 assembly as well as multiple referenced assemblies
1539 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1540 'must_be_unique' flag.
1541 (GlobalRootNamespace): Update to changes.
1542 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1543 already have a type in hand.
1545 2009-07-22 Marek Safar <marek.safar@gmail.com>
1547 * expression.cs: More verifier instrumentation.
1549 * statement.cs: Do proper throw expression conversion.
1551 2009-07-22 Marek Safar <marek.safar@gmail.com>
1553 A fix for bug #522789
1554 * expression.cs: Mutate invocation return type.
1556 2009-07-16 Marek Safar <marek.safar@gmail.com>
1558 * anonymous.cs: Split assignable and readonly generated variable
1561 2009-07-16 Marek Safar <marek.safar@gmail.com>
1563 A fix for bug #521671
1564 * statement.cs: Fixed crash when checking missing type.
1566 2009-07-16 Marek Safar <marek.safar@gmail.com>
1568 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1569 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1570 class.cs, driver.cs: Work on dynamic binding.
1572 * dynamic.cs: New file.
1574 * *.sources, *.proj: Updated.
1576 2009-07-15 Marek Safar <marek.safar@gmail.com>
1578 * expression.cs (Conditional): Avoid double Resolve.
1580 2009-07-13 Marcus Griep <marcus@griep.us>
1582 * ecore.cs: Fix obscure bug with resolving members of interfaces
1583 that hide parent interface members. Fixes bug #444388 and corrects
1586 2009-07-13 Marek Safar <marek.safar@gmail.com>
1588 * expression.cs (LocalVariableReference): Bounce resolve.
1590 2009-07-10 Marek Safar <marek.safar@gmail.com>
1592 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1593 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1596 * support.cs: New dynamic type wrapper.
1598 2009-07-08 Marek Safar <marek.safar@gmail.com>
1600 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1601 typed local variable.
1603 2009-07-06 Marek Safar <marek.safar@gmail.com>
1605 A fix for bug #519005
1606 * anonymous.cs: Use null_type as no return type placeholder.
1608 2009-07-02 Marek Safar <marek.safar@gmail.com>
1610 * generic.cs: Handle type inference of identical type parameters
1611 with different bounds.
1613 2009-07-01 Marek Safar <marek.safar@gmail.com>
1615 * expression.cs, class.cs: Events variance.
1617 * cs-parser.jay: Interface events error messages.
1619 2009-07-01 Marek Safar <marek.safar@gmail.com>
1621 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1623 2009-06-29 Marek Safar <marek.safar@gmail.com>
1625 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1626 parameter expression can be value-type New.
1628 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1630 2009-06-26 Marek Safar <marek.safar@gmail.com>
1632 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1633 Implemented C# 4.0 named arguments.
1635 2009-06-24 Marek Safar <marek.safar@gmail.com>
1637 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1638 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1639 parameter modifier. Also fixes bug #515497.
1641 2009-06-24 Marek Safar <marek.safar@gmail.com>
1643 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1644 arguments expression to be implemented.
1646 *.sources: Add argument.cs
1648 2009-06-23 Marek Safar <marek.safar@gmail.com>
1650 * parameter.cs: Moved GetParameterIndexByName to base class.
1652 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1653 unused AType. Use argument's version of GetExpressionTree.
1655 2009-06-22 Marek Safar <marek.safar@gmail.com>
1657 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1660 2009-06-17 Marek Safar <marek.safar@gmail.com>
1662 A fix for bug #514096
1663 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1665 2009-06-17 Marek Safar <marek.safar@gmail.com>
1667 * expression.cs: The first multi-dimensional array nested array
1668 initializers was not checked.
1670 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1672 2009-06-17 Marek Safar <marek.safar@gmail.com>
1674 A fix for bug #513400
1675 * nullable.cs (EmitEquality): Operands emit could be simplified for
1676 built-in types when we now emit user operators differently.
1678 2009-06-16 Marek Safar <marek.safar@gmail.com>
1680 * ecore.cs: Report inaccessible delegate methods correctly.
1682 2009-06-16 Marek Safar <marek.safar@gmail.com>
1684 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1685 cs-parser.jay: Implemented C# 4.0 optional parameters.
1687 2009-06-16 Marek Safar <marek.safar@gmail.com>
1689 * driver.cs: Removed broken DefineManifestResource.
1691 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1693 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1694 Use $(BOOTSTRAP_PROFILE) instead.
1696 2009-06-12 Jb Evain <jbevain@novell.com>
1698 * rootcontext.cs: add a Platform field.
1699 * driver.cs: handle /platform.
1700 * codegen.cs: pass the proper flags according to
1701 the platform when saving the assembly.
1703 2009-06-11 Marek Safar <marek.safar@gmail.com>
1705 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1706 Add optional parameters grammar.
1708 2009-06-10 Marek Safar <marek.safar@gmail.com>
1710 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1711 driver.cs: Split lang version and metadata version.
1713 2009-06-10 Marek Safar <marek.safar@gmail.com>
1715 * decl.cs: Better overload ctor collision error message.
1717 2009-06-05 Jb Evain <jbevain@novell.com>
1719 * driver.cs (EmbededResource): avoid using an internal method
1720 in gmcs to embed manifest resources.
1722 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1724 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1725 the compiler from older mono versions (like moon's bots)
1727 2009-06-04 Marek Safar <marek.safar@gmail.com>
1729 * namespace.cs (LookupTypeReflection): Ignore collisions between
1732 2009-06-04 Marek Safar <marek.safar@gmail.com>
1734 * codegen.cs: Enabled generic type forwarders.
1736 2009-06-04 Marek Safar <marek.safar@gmail.com>
1738 * dmcs.*: Add another version of SRE compiler.
1740 2009-06-03 Marek Safar <marek.safar@gmail.com>
1742 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1743 generic-mcs.cs: Fixed variant type conversions.
1745 2009-06-02 Marek Safar <marek.safar@gmail.com>
1747 A fix for bug #507863
1748 * codegen.cs: Fixes a crash on invalid string value attribute.
1750 2009-06-01 Marek Safar <marek.safar@gmail.com>
1752 A fix for bug #508334
1753 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1754 cs-parser.jay: Fully import __arglist modifier.
1756 2009-05-29 Marek Safar <marek.safar@gmail.com>
1758 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1759 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1760 actually work with closed generic types.
1762 2009-05-27 Alan McGovern <amcgovern@novell.com>
1764 * class.cs, decl.cs, delegate.cs, parameter.cs:
1765 Fix the build by replacing the use of 'var' with the actual type.
1767 2009-05-27 Marek Safar <marek.safar@gmail.com>
1769 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1770 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1773 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1776 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1777 Marek Safar <marek.safar@gmail.com>
1779 A fix for bug #377509
1780 * parameter.cs: Use predefined and not empty name for implicit
1783 2009-05-21 Marek Safar <marek.safar@gmail.com>
1785 * class.cs: Don't report wrong warnings for event fields.
1787 2009-05-21 Marek Safar <marek.safar@gmail.com>
1789 A fix for bug #504667
1790 * class.cs: Check for static class using parent container instead of
1793 2009-05-08 Marek Safar <marek.safar@gmail.com>
1795 A fix for bug #496922
1796 * expression.cs: Always use temporary variable when using object
1799 2009-04-28 Marek Safar <marek.safar@gmail.com>
1801 A fix for bug #495112
1802 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1805 2009-04-27 Miguel de Icaza <miguel@novell.com>
1807 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1809 2009-04-24 Miguel de Icaza <miguel@novell.com>
1811 * complete.cs: No idea how gonzalo got a null in the list, but
1814 2009-04-24 Miguel de Icaza <miguel@novell.com>
1816 * complete.cs (CompletionElementInitializer): New completion class
1817 to support completing inside a C# 3 element initializer, so this
1818 allows completion for Silverlight situations where it is very
1821 new TextBlock () { Fo<TAB>
1823 (CompletionSimpleName): Expose the prefix that was
1824 passed to the simple name.
1826 * cs-parser.jay (object_or_collection_initializer): Add support
1827 for element_initializers.
1829 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1830 special case completion expressions as this method aggressively
1831 collects data before it operates, and errors were being thrown
1832 earlier than we were able to complete.
1834 2009-04-23 Miguel de Icaza <miguel@novell.com>
1836 * eval.cs: Make getcompletions silent and enable debugging output
1837 if the -v option is passed.
1839 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1840 Consider looking up the namespace that matches the prefix being
1843 This is part of the support for allowing completions like:
1844 `System.Co<TAB>' to complete to System.Console.
1846 * complete.cs (CompletionSimpleName.AppendResults): Make this
1849 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1851 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1852 COMPLETE_COMPLETION as internal.
1854 2009-04-17 Miguel de Icaza <miguel@novell.com>
1856 * complete.cs: Include namespace resolution in simple names as
1857 well as global types and types in the using scope in the
1860 * namespace.cs: Supporting infrastrcture to provide completions
1861 based on the current using scope.
1863 * eval.cs: Introduce an entry point that allows for initialization
1864 to return a list of the files passed on the command line.
1866 2009-04-14 Marek Safar <marek.safar@gmail.com>
1868 A fix for bug #494243
1869 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1871 2009-04-13 Marek Safar <marek.safar@gmail.com>
1873 A fix for bug #493887
1874 * statement.cs: Don't skip string multi-section with default or
1875 null label when populating string hashtable.
1877 2009-04-06 Marek Safar <marek.safar@gmail.com>
1879 A fix for bug #492329
1880 * expression.cs (New): Load variable when assigning type parameter
1883 2009-04-06 Marek Safar <marek.safar@gmail.com>
1885 A fix for bug #488960
1886 * decl.cs: Compare MVAR types using non-null values.
1888 2009-03-27 Marek Safar <marek.safar@gmail.com>
1890 * typemanager.cs, expression.cs: Removed unused nullable checks.
1892 2009-03-27 Marek Safar <marek.safar@gmail.com>
1894 * *.cs: Removed some gmcs conditionals.
1896 2009-03-26 Marek Safar <marek.safar@gmail.com>
1898 * generic.cs, support.cs: Moved generics stuff out of support.cs
1900 2009-03-24 Marek Safar <marek.safar@gmail.com>
1902 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1905 2009-03-23 Marek Safar <marek.safar@gmail.com>
1907 * attribute.cs: Consider all members for error reporting when
1908 checking named arguments.
1910 2009-03-23 Marek Safar <marek.safar@gmail.com>
1912 A fix for bug #487625
1913 * namespace.cs: Use a warning for all predefined type conflicts.
1915 2009-03-23 Marek Safar <marek.safar@gmail.com>
1917 A fix for bug #485706
1918 * statement.cs: Explicitly type catch type argument to pass verifier
1921 2009-03-22 Miguel de Icaza <miguel@novell.com>
1923 Initial support to provide code completion facilities to consumers
1924 of the evaluator API.
1926 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1927 support the completion engine. When we reach the end of the
1928 input stream instead of returning EOF, when this flag is true the
1929 tokenizer instead produces:
1931 One GENERATE_COMPLETION token: this token then must be
1932 handled in the grammar at every point where the user
1933 would likely request a completion.
1935 As many COMPLETE_COMPLETION tokens as necessary. These
1936 tokens are generated to assist the parser in unwinding and
1937 producing a valid parse tree.
1939 The parser rules do not have to be perfect, the parser needs to be
1940 augmented with judicious use of GENERATE_COMPLETION tokens to
1941 improve the areas where we can provide completion and the parser
1942 needs to add support for COMPLETE_COMPLETION tokens in productions
1945 It is common to not have enough support for COMPLETE_COMPLETION
1946 under certain rules and that even if we generated the
1947 GENERATE_COMPLETION token that the resulting tree will be invalid
1948 due to the missing rules that support COMPLETE_COMPLETION.
1950 The final EOF token is produced by having the parser notify the
1951 tokenizer when it reaches the root production that the next token
1954 * support.cs (CompletionResult): New Exception. This exception
1955 is thrown to return the completion results when one of the special
1956 completion expressions is reached.
1958 This exception is thrown by the completing ExpressionStatements
1959 classes that live in complete.cs
1961 * complete.cs (CompletingExpression): a new base class for
1962 completing expressions. This derives from the
1963 ExpressionStatement class and not from Expression as it allows
1964 completion to happen not only where expressions are expected in
1965 the grammar, but also where statements are expected.
1967 (CompletionSimpleName): A new class used to provide completions
1968 for SimpleNames. This currently only resolves to local
1969 variables from the evaluator context (GetVars call).
1971 (CompletionMemberAccess): Implements support for completing member
1974 * cs-parser.jay: Add support for completion in a few places.
1976 * eval.cs (GetCompletions): New public API for the evaluator that
1977 returns a list of possible completions given the input. The
1978 return value is an array of completions
1980 * anonymous.cs (Compatible): If the exception thrown from the
1981 resolved expression is a CompletionResult exception let that one
1982 through instead of printing a diagnostic error in the try/catch.
1984 2009-03-22 Miguel de Icaza <miguel@novell.com>
1988 * driver.cs (Main): Use Environment.Exit to quit quickly and
1989 prevent the compiler from doing the usual wait for helper thread
1992 This is to prevent a slowdown that was reported by Gonzalo on
1995 2009-03-19 Marek Safar <marek.safar@gmail.com>
1997 * ecore.cs: Load build-in types directly instead of accessing
2000 2009-03-18 Marek Safar <marek.safar@gmail.com>
2002 * ecore.cs: Always use unbox.any when available.
2004 2009-03-18 Marek Safar <marek.safar@gmail.com>
2006 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2008 2009-03-17 Marek Safar <marek.safar@gmail.com>
2010 * generic.cs: Removed obsolete version of type inference.
2012 2009-03-16 Marek Safar <marek.safar@gmail.com>
2014 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2015 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2016 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2017 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2019 2009-03-11 Marek Safar <marek.safar@gmail.com>
2021 A fix for bug #482996
2022 * anonymous.cs: Make sure we are not infering return type when
2023 checking type compatibility.
2025 2009-03-11 Marek Safar <marek.safar@gmail.com>
2027 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2028 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2029 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2030 attributes in their own structure. Needed when accessing their
2031 properties before they are resolved.
2033 2009-03-09 Marek Safar <marek.safar@gmail.com>
2035 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2036 hashtable (~10x faster).
2038 * driver.cs: Removed wrong Reset.
2040 2009-03-08 Marek Safar <marek.safar@gmail.com>
2042 * class.cs: Use correct common base type for unmanaged delayed
2045 * rootcontext.cs: Wrap unhandled exception.
2047 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2049 Make SeekableStreamReader self-tuning and arbitrarily seekable
2050 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2052 (SeekableStreamReader.Position.set): Use it. Simplify logic
2053 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2054 buffer size when the stream needs to be re-read from the beginning.
2056 2009-03-05 Marek Safar <marek.safar@gmail.com>
2058 A fix for bug #480100
2059 * parameter.cs: A parameter is not hoisted when used directly as ET.
2061 2009-03-04 Marek Safar <marek.safar@gmail.com>
2063 * statement.cs: Fixed an issue when using variable is of interface
2066 2009-03-03 Marek Safar <marek.safar@gmail.com>
2068 A fix for bug #480319
2069 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2071 2009-03-03 Marek Safar <marek.safar@gmail.com>
2073 A fix for bug #480867
2074 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2075 expression to have no valid type.
2077 2009-03-03 Marek Safar <marek.safar@gmail.com>
2079 A fix for bug #481258
2080 * class.cs: Set extension method flag in partial container.
2082 2009-03-03 Marek Safar <marek.safar@gmail.com>
2084 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2086 * attribute.cs: Add sanity check.
2088 2009-02-27 Marek Safar <marek.safar@gmail.com>
2090 * class.cs: Add external constructor error.
2092 2009-02-26 Marek Safar <marek.safar@gmail.com>
2094 A fix for bug #475354
2095 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2096 correctly user defined nullable equality operators.
2098 2009-02-25 Marek Safar <marek.safar@gmail.com>
2100 A fix for bug #479532
2101 * expression.cs: Implement NewInitialize::AddressOf.
2103 2009-02-25 Marek Safar <marek.safar@gmail.com>
2105 A fix for bug #413633
2106 * expression.cs: Iterate all base class-constraint types.
2108 2009-02-24 Marek Safar <marek.safar@gmail.com>
2110 A fix for bug #479209
2111 * literal.cs: Mutate null underlying type.
2113 2009-02-24 Marek Safar <marek.safar@gmail.com>
2115 A fix for bug #476295
2116 * convert.cs: Avoid wrapping implicitly convertible reference type.
2118 2009-02-23 Marek Safar <marek.safar@gmail.com>
2120 * iterators.cs: Create MemberName correctly.
2122 2009-02-23 Marek Safar <marek.safar@gmail.com>
2124 A fix for bug #478655
2125 * literal.cs: Check also underlying null type conversion.
2127 2009-02-21 Marek Safar <marek.safar@gmail.com>
2129 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2131 2009-02-20 Marek Safar <marek.safar@gmail.com>
2133 A fix for bug #477447
2134 * statement.cs: Add reference to correct parent storey when this
2135 is accessible from deep children storey (more than 1 level).
2137 2009-02-19 Marek Safar <marek.safar@gmail.com>
2139 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2140 * class.cs: Define base type members before setting up member cache.
2142 2009-02-18 Marek Safar <marek.safar@gmail.com>
2144 A fix for bug #477378
2145 * nullable.cs, expression.cs, statement.cs: More precise null type
2148 2009-02-18 Marek Safar <marek.safar@gmail.com>
2150 A fix for bug #472805
2151 * typemanager.cs, namespace.cs: Import only visible extension method
2154 2009-02-18 Marek Safar <marek.safar@gmail.com>
2156 A fix for bug #476895
2157 * attribute.cs: Use correct resolve context for attribute type.
2159 2009-02-18 Marek Safar <marek.safar@gmail.com>
2161 A fix for bug #476266
2162 * anonymous.cs: Mutate multi-dimensional arrays.
2164 2009-02-18 Marek Safar <marek.safar@gmail.com>
2166 A fix for bug #476400
2167 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2169 2009-02-18 Marek Safar <marek.safar@gmail.com>
2171 A fix for bug #476811
2172 * generics.cs: Fixed null-literal check.
2174 2009-02-17 Marek Safar <marek.safar@gmail.com>
2176 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2177 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2178 messing with static variables.
2180 2009-02-16 Marek Safar <marek.safar@gmail.com>
2182 A fix for bug #475965
2183 * generics.cs: Check generic parameter type after extracting from
2186 2009-02-16 Marek Safar <marek.safar@gmail.com>
2188 A fix for bug #475823
2189 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2192 2009-02-14 Marek Safar <marek.safar@gmail.com>
2194 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2195 Simplified event field definition using backing field and not
2196 field builder directly.
2198 * expression.cs (EmitLdArg): Optimize fast paths.
2200 2009-02-13 Marek Safar <marek.safar@gmail.com>
2202 A fix for bug #475327
2203 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2205 2009-02-13 Marek Safar <marek.safar@gmail.com>
2207 A fix for bug #475342
2208 * cs-parser.jay: Using 'super' instead of 'base' to call base
2209 constructor crashes compiler.
2211 2009-02-13 Marek Safar <marek.safar@gmail.com>
2213 A fix for bug #475354
2214 * expression.cs (Constantify): Add nullable types.
2216 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2218 2009-02-12 Marek Safar <marek.safar@gmail.com>
2220 A fix for bug #475246
2221 * expression.cs: More broken flowanalysis hacking needed.
2223 2009-02-12 Marek Safar <marek.safar@gmail.com>
2225 * attribute.cs: Compare only ref/out array modifiers.
2227 2009-02-11 Marek Safar <marek.safar@gmail.com>
2229 * statement.cs: Use member cache when looking for foreach members.
2231 2009-02-11 Marek Safar <marek.safar@gmail.com>
2233 * expression.cs: Don't expose internal initializer types.
2235 * statement.cs: Check also explicit conversions for goto case.
2237 2009-02-11 Marek Safar <marek.safar@gmail.com>
2239 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2241 2009-02-10 Marek Safar <marek.safar@gmail.com>
2243 * *.cs: Replace null-type with NullLiteral where appropriate.
2245 2009-02-09 Marek Safar <marek.safar@gmail.com>
2247 * expression.cs: Initializer of reference argument use temporary
2248 variable to be verifiable.
2250 * parameter.cs: Share EmitLdArg.
2252 2009-02-09 Marek Safar <marek.safar@gmail.com>
2254 A fix for bug #473559
2255 * class.cs: Fixed: Not reporting error about nested class with the
2258 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2260 Contributed under the MIT/X11 license.
2262 * generic.cs: Added VerifyVariantTypeParameters which performs new
2263 variance verification logic. The old logic, based on the spec, was
2264 wrong because the spec is full of LIES!
2266 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2268 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2271 * ecore.cs: Added calls to the new variance verification logic.
2274 * delegate.cs: Removed calls to the old variance verification logic.
2276 2009-02-06 Marek Safar <marek.safar@gmail.com>
2278 * delegate.cs: Use cached Invoke method directly.
2280 2009-02-06 Marek Safar <marek.safar@gmail.com>
2282 * expression.cs: Emit expression tree for hoisted variable access.
2284 2009-02-04 Marek Safar <marek.safar@gmail.com>
2286 * namespace.cs: Add better extension class check.
2288 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2290 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2292 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2294 This patch adds initial generic variance support to the compiler.
2295 It is contributed under the MIT/X11 license.
2297 * typemanager.cs: Modified ImplementsInterface to check variance.
2298 Added VerifyVariantTypeParameters which checks the specified type to see
2299 if it uses a variant type parameter as a type argument (which is not
2300 allowed). Added IsVariantOf which determins if the first type is a
2301 variant of the second. NOTE: This only supports reference types at
2302 the moment to conform with the current level of VM support. When the
2303 VM supports value types, this will follow step.
2305 * generic.cs: Added the Variance enum. Added a Variance property to
2306 TypeParameter and added variance support to definition phase. Added a
2307 Variance property to TypeParameterName. Also check to make sure that
2308 no variant types appear in generic method parameters.
2310 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2311 keywords if the langversion supports it.
2313 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2314 that variant types are only used in legal positions. Also added
2315 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2318 * decl.cs: Construct TypeParameter with the variance information.
2320 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2321 and ImplicitConversionStandard.
2323 * rootcontext.cs: Added new "Future" language version.
2325 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2326 type parameters are not used as type arguments in interface inheritance.
2327 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2328 parameters are not used as method return types. In MemberBase.
2329 ResolveMemberType, ensure that variant type parameters are not used
2330 as type arguments. Also call VerifyNoVariantTypeParameters on every
2331 set of parameters which are resolved.
2333 * delegate.cs: Modified Delegate.Define to ensure that variant
2334 parameters are not used as type arguments and that a contravariant
2335 parameter is not used as the return type. Also call
2336 VerifyNoVariantTypeParameters on the delegate parameters.
2338 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2339 to specify generic variance.
2341 * driver.cs: Added support for LanguageVersion.Future in the form of
2342 "-langversion:future".
2344 * generic-mcs.cs: Stubbed out new members in generic.cs.
2346 2009-02-03 Marek Safar <marek.safar@gmail.com>
2348 * class.cs, generic.cs: Emit type parameter constraints for nested
2351 2009-02-02 Marek Safar <marek.safar@gmail.com>
2353 A fix for bug #471213
2354 * class.cs: Avoid emitting backing field for abstract event fields.
2356 2009-02-01 Marek Safar <marek.safar@gmail.com>
2358 A fix for bug #359731
2359 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2362 2009-01-30 Marek Safar <marek.safar@gmail.com>
2364 A fix for bug #470767
2365 * statement.cs: Introduced BlockScopeExpression, needed when
2366 expression tree conversion has to emit scope variables.
2368 2009-01-29 Marek Safar <marek.safar@gmail.com>
2370 * class.cs: Remove duplicate CallingConvention.
2372 2009-01-29 Marek Safar <marek.safar@gmail.com>
2374 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2375 when I finally found the right naming convention.
2377 2009-01-29 Marek Safar <marek.safar@gmail.com>
2379 * cs-tokenizer.cs: Put back different open parens optimization.
2381 2009-01-28 Marek Safar <marek.safar@gmail.com>
2383 A fix for bug #470227
2384 * cs-tokenizer.cs: Remove too agressive parser optimization.
2386 2009-01-28 Marek Safar <marek.safar@gmail.com>
2388 A fix for bug #324319
2389 * class.cs: Remove too early base type resolve.
2391 2009-01-27 Marek Safar <marek.safar@gmail.com>
2393 A fix for bug #324319
2394 * ecore.cs: Explicitly type null when assigning to type argument to
2395 make pass verifier check.
2397 2009-01-27 Marek Safar <marek.safar@gmail.com>
2399 * anonymous.cs: Fixed recent regression when initializing captured
2402 2009-01-26 Marek Safar <marek.safar@gmail.com>
2404 A fix for bug #469019
2405 * anonymous.cs: Use all parent type parameters when instantiating
2406 nested generic storey.
2408 2009-01-26 Marek Safar <marek.safar@gmail.com>
2410 * expression.cs: Check for null instance methodgroup expression.
2412 2009-01-26 Marek Safar <marek.safar@gmail.com>
2414 A fix for bug #469244
2415 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2416 instance inside a conditional expression.
2418 2009-01-23 Marek Safar <marek.safar@gmail.com>
2420 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2421 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2422 GetElementType and HasElementType. IsValueType clean up.
2424 2009-01-23 Marek Safar <marek.safar@gmail.com>
2426 * nullable.cs: Use common EmitCall.
2428 * expression.cs: Emit constraint. for virtual calls only.
2430 2009-01-23 Marek Safar <marek.safar@gmail.com>
2432 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2433 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2434 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2437 2009-01-22 Jb Evain <jbevain@novell.com>
2439 * anonymous.cs: make anonymous types' ToString implementation
2440 match what csc outputs.
2442 2009-01-21 Marek Safar <marek.safar@gmail.com>
2444 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2447 2009-01-17 Marek Safar <marek.safar@gmail.com>
2449 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2452 2009-01-16 Marek Safar <marek.safar@gmail.com>
2454 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2457 2009-01-15 Marek Safar <marek.safar@gmail.com>
2459 A fix for bug #466634
2460 * statement.cs: Add reference for nested storey when only this
2463 2009-01-15 Marek Safar <marek.safar@gmail.com>
2465 A fix for bug #466474
2466 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2469 2009-01-15 Marek Safar <marek.safar@gmail.com>
2471 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2472 Fixed nested stories parent referencing process. Also fixes #463985.
2474 2009-01-06 Marek Safar <marek.safar@gmail.com>
2476 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2477 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2478 implementation. Also fixes #463108.
2480 2009-01-05 Marek Safar <marek.safar@gmail.com>
2482 A fix for bug #416109
2483 * decl.cs: Issue correct CLSAttribute warning location.
2485 2009-01-05 Marek Safar <marek.safar@gmail.com>
2487 A fix for bug #456775
2488 * attribute.cs: Use attribute owner scope when resolving attribute
2491 2009-01-05 Marek Safar <marek.safar@gmail.com>
2493 A fix for bug #457257
2494 * decl.cs: Fixed incorrect member declaring type comparison.
2496 2009-01-05 Marek Safar <marek.safar@gmail.com>
2498 A fix for bug #460896
2499 * driver.cs: Handle /RES resources as embeddable.
2501 2009-01-05 Marek Safar <marek.safar@gmail.com>
2503 A fix for bug #462515
2504 * ecore.cs: Report inacessible members upwards.
2506 2009-01-05 Marek Safar <marek.safar@gmail.com>
2508 A fix for bug #463190, #463192
2509 * decl.cs, namespace.cs: Also import internal extension classes.
2511 2009-01-04 Marek Safar <marek.safar@gmail.com>
2513 A fix for bug #463415
2514 * generic.cs: Use right index for RemoveDependentTypes.
2516 2009-01-02 Marek Safar <marek.safar@gmail.com>
2518 A fix for bug #463196
2519 * expression.cs: Fixed enum to null comparison.
2521 2009-01-02 Marek Safar <marek.safar@gmail.com>
2523 A fix for bug #463121
2524 * nullable.cs: Fixed nullable user equality operator comparison.
2526 2009-01-02 Marek Safar <marek.safar@gmail.com>
2528 A fix for bug #462950
2529 * class.cs, decl.cs: Use full explicit name when defining automatic
2530 property backing field.
2532 2009-01-02 Marek Safar <marek.safar@gmail.com>
2534 A fix for bug #462592
2535 * pending.cs: Emit type arguments for generic proxy method.
2537 2008-12-30 Marek Safar <marek.safar@gmail.com>
2539 * expression.cs (As): Mutate all type arguments.
2541 2008-12-29 Marek Safar <marek.safar@gmail.com>
2543 A fix for bug #462622
2544 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2547 2008-12-29 Marek Safar <marek.safar@gmail.com>
2549 A fix for bug #450782
2550 * ecore.cs: Consider more variables of form V.I to be fixed.
2552 2008-12-29 Marek Safar <marek.safar@gmail.com>
2554 A fix for bug #460712
2555 * typemanager.cs: Core types could be imported.
2557 2008-12-28 Marek Safar <marek.safar@gmail.com>
2559 A fix for bugs #460847, #460772, #458049, #457339, #447807
2560 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2561 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2562 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2563 user lambdas used inside query clauses.
2565 2008-12-18 Marek Safar <marek.safar@gmail.com>
2567 A fix for bug #460229
2568 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2570 2008-12-18 Marek Safar <marek.safar@gmail.com>
2572 A fix for bug #459952
2573 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2575 2008-12-18 Marek Safar <marek.safar@gmail.com>
2577 A fix for bug #459630
2578 * convert.cs: Enum to valuetype conversion is not allowed.
2580 2008-12-18 Marek Safar <marek.safar@gmail.com>
2582 A fix for bug #457087
2583 * generic.cs: Don't crash when constraint comes from type
2586 2008-12-16 Marek Safar <marek.safar@gmail.com>
2588 A fix for bug #459221
2589 * anonymous.cs, statement.cs: Delay only captured this
2592 2008-12-12 Marek Safar <marek.safar@gmail.com>
2594 A fix for bug #457489
2595 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2596 and initialization to capture scope initializers correctly.
2598 2008-12-11 Marek Safar <marek.safar@gmail.com>
2600 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2601 ParameterReference refactoring.
2603 2008-12-03 Marek Safar <marek.safar@gmail.com>
2605 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2606 to be imported from any assembly.
2608 2008-12-03 Marek Safar <marek.safar@gmail.com>
2610 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2611 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2612 from anonymous method and lambda expression.
2614 2008-12-01 Marek Safar <marek.safar@gmail.com>
2616 A fix for bug #448560
2617 * expression.cs (As): Box any generic type arguments to be
2620 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2622 Add tripwire for implicit conversion bugs
2623 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2625 (MethodGroupExpr.OverloadResolve): Add sanity check between
2626 IsApplicable and VerifyArgumentsCompat.
2627 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2629 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2631 Fix build break in System.Data_test
2632 * convert.cs (ImplicitConversionExists): Move NullLiteral
2634 (ImplicitStandardConversionExists): ... here.
2636 2008-11-28 Marek Safar <marek.safar@gmail.com>
2638 * literal.cs: Emit correctly explicit null to nullable cast.
2640 2008-11-28 Marek Safar <marek.safar@gmail.com>
2642 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2645 2008-11-28 Marek Safar <marek.safar@gmail.com>
2647 A fix for bug #449005
2648 * convert.cs, nullable.cs: Use only one implicit nullable
2651 2008-11-27 Marek Safar <marek.safar@gmail.com>
2653 * convert.cs, literal.cs: More Convert cleanup is needed.
2655 2008-11-27 Marek Safar <marek.safar@gmail.com>
2657 * decl.cs, class.cs: Fixed misleading error message.
2659 2008-11-26 Marek Safar <marek.safar@gmail.com>
2661 A fix for bug #449005
2662 * nullable.cs (EmitEquality): Disable optimization for user operator
2665 2008-11-25 Marek Safar <marek.safar@gmail.com>
2667 A fix for bug #447027
2668 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2669 with context variables stored as expression instances.
2671 2008-11-25 Marek Safar <marek.safar@gmail.com>
2673 A fix for bug #447027
2674 * delegate.cs: Fixed delegate VerifyMethod logic.
2676 2008-11-24 Marek Safar <marek.safar@gmail.com>
2678 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2681 2008-11-21 Marek Safar <marek.safar@gmail.com>
2683 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2684 member type resolve to follow normal flow, instead of random
2687 2008-11-21 Marek Safar <marek.safar@gmail.com>
2689 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2692 2008-11-21 Marek Safar <marek.safar@gmail.com>
2694 * const.cs: Emit decimal array constant as literal.
2696 2008-11-20 Marek Safar <marek.safar@gmail.com>
2698 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2700 2008-11-19 Marek Safar <marek.safar@gmail.com>
2702 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2703 into real property (saves 8 MB for corlib compilation).
2705 2008-11-19 Marek Safar <marek.safar@gmail.com>
2707 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2708 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2709 generic-mcs.cs: Small cleanup of TypeArguments.
2711 2008-11-18 Marek Safar <marek.safar@gmail.com>
2713 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2714 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2715 of ConstructedType expression, renamed to GenericTypeExpr.
2717 2008-11-17 Marek Safar <marek.safar@gmail.com>
2719 A fix for bug #445303
2720 * location.cs (IsConditionalDefined): Handle undefined global
2723 2008-11-17 Marek Safar <marek.safar@gmail.com>
2725 A fix for bug #444678
2726 * expression.cs (TryReduceConstant): Always create new constant
2729 2008-11-17 Marek Safar <marek.safar@gmail.com>
2731 A fix for bug #444673
2732 * ecore.cs: Ignore open generic types when used as generic type
2735 2008-11-17 Marek Safar <marek.safar@gmail.com>
2737 A fix for bug #445458
2738 * expression.cs, cs-parser.jay: Don't crash when an expression
2741 2008-11-17 Marek Safar <marek.safar@gmail.com>
2743 A fix for bug #445464
2744 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2745 inside unbound type.
2747 2008-11-14 Jb Evain <jbevain@novell.com>
2749 * driver.cs: ignore empty -nowarn argument such as
2750 the one in -nowarn:12,13,,.
2752 2008-11-13 Marek Safar <marek.safar@gmail.com>
2754 A fix for bug #444271
2755 * anonymous.cs: Rescan parent storeys when best candidate was
2758 2008-11-13 Marek Safar <marek.safar@gmail.com>
2760 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2761 useless UnboundTypeExpression.
2763 * attribute.cs: Do check obsolete attribute on generic types.
2765 2008-11-12 Marek Safar <marek.safar@gmail.com>
2767 A fix for bugs #425680, #400139
2768 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2771 2008-11-11 Marek Safar <marek.safar@gmail.com>
2773 A fix for bug #435747
2774 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2775 compound value types assignment. Few micro optimizations added.
2777 2008-11-10 Marek Safar <marek.safar@gmail.com>
2779 A fix for bug #442610
2780 * anonymous.cs (MutateConstructor): More SRE hacking.
2782 2008-11-10 Marek Safar <marek.safar@gmail.com>
2784 A fix for bug #442579
2785 * ecore.cs: Also initialize expanded form of a method with 1 params
2788 2008-11-06 Marek Safar <marek.safar@gmail.com>
2790 * expression.cs (UnaryMutator): Do early l-side check.
2792 2008-11-05 Miguel de Icaza <miguel@novell.com>
2794 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2795 Init, otherwise we would crash later on when checking for friend
2798 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2799 Otherwise we never get any meaningful information as to what
2802 2008-11-05 Marek Safar <marek.safar@gmail.com>
2804 A fix for bug #436318
2805 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2807 2008-11-05 Miguel de Icaza <miguel@novell.com>
2809 * namespace.cs: Turns out that it was a really bad idea to hide
2810 the errors for namespaces not found here in eval mode.
2812 * eval.cs: When we process using clauses, only enter those into
2813 the list of valid using clauses after they have been validated.
2815 The above change gives the proper semantics: it does not
2816 senselessly report the same errors with broken using statements by
2817 never storing them in the first place when they are invalid.
2819 2008-11-05 Marek Safar <marek.safar@gmail.com>
2821 A fix for bug #421839
2822 * cs-parser.jay: Remove expression from coalesce rule to force lower
2823 priority than the assignment operator.
2825 2008-11-05 Marek Safar <marek.safar@gmail.com>
2827 A fix for bug #437875
2828 * nullable.cs: Compile correctly method group operand used with null
2829 coalescing operator.
2831 2008-11-04 Marek Safar <marek.safar@gmail.com>
2833 A fix for bug #434589
2834 * expression.cs (Binary): Ignore lifted conversions when at least
2835 one operand is of reference type.
2837 2008-11-04 Marek Safar <marek.safar@gmail.com>
2839 * cs-parser.jay: Better syntax error report.
2841 2008-11-03 Marek Safar <marek.safar@gmail.com>
2843 A fix for bug #436792
2844 * cs-parser.jay: Use GetLocation to access location.
2846 2008-11-03 Marek Safar <marek.safar@gmail.com>
2848 A fix for bug #440774
2849 * cs-parser.jay: Also set current_array_type when parsing local
2852 2008-11-03 Marek Safar <marek.safar@gmail.com>
2854 A fix for bug #440785
2855 * expression.cs (As): Don't resolve self modifing expression
2858 2008-11-03 Marek Safar <marek.safar@gmail.com>
2860 A fix for bug #439447
2861 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2863 2008-11-03 Marek Safar <marek.safar@gmail.com>
2865 A fix for bug #437571
2866 * cs-parser.jay: Fixes internal error for invalid expression
2869 2008-10-17 Marek Safar <marek.safar@gmail.com>
2871 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2873 2008-10-17 Marek Safar <marek.safar@gmail.com>
2875 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2877 2008-10-17 Marek Safar <marek.safar@gmail.com>
2879 * cs-tokenizer.cs: More precise cast parsing.
2881 2008-10-16 Martin Baulig <martin@ximian.com>
2883 * anonymous.cs (AnonymousMethodStorey): Put back the
2884 `hoisted_locals' hashtable and use it in EmitType().
2886 2008-10-15 Marek Safar <marek.safar@gmail.com>
2888 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2889 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2892 2008-10-14 Marek Safar <marek.safar@gmail.com>
2894 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2896 2008-10-14 Marek Safar <marek.safar@gmail.com>
2898 * statement.cs: Mutate scope initializers.
2900 2008-10-14 Marek Safar <marek.safar@gmail.com>
2902 * expression.cs: Use typeless value for This constant.
2904 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2906 2008-10-14 Marek Safar <marek.safar@gmail.com>
2908 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2911 2008-10-13 Marek Safar <marek.safar@gmail.com>
2913 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2916 2008-10-13 Marek Safar <marek.safar@gmail.com>
2918 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2919 parser and tokenizer. Fixes many ambiguities including #433258.
2921 2008-10-10 Marek Safar <marek.safar@gmail.com>
2923 * cs-parser.jay: Fixed missing accessor recovery.
2925 2008-10-10 Marek Safar <marek.safar@gmail.com>
2927 A fix for bug #433701
2928 * expression.cs: Better error message.
2930 2008-10-10 Marek Safar <marek.safar@gmail.com>
2932 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2934 * Makefile: Disabled unused debug symbols.
2936 Also fixes: #320556, #321097, #321656, #321876, #351316
2938 2008-10-09 Miguel de Icaza <miguel@novell.com>
2940 * eval.cs: rename "<interactive>" to "{interactive}", to work
2941 around a requirement in the compiler that this be a valid
2942 filename, and in Windows it is not (433886).
2944 2008-10-09 Marek Safar <marek.safar@gmail.com>
2946 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2948 2008-10-08 Marek Safar <marek.safar@gmail.com>
2950 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2951 cs-parser.jay: Generic type declaration and type arguments cleanup.
2953 2008-10-05 Marek Safar <marek.safar@gmail.com>
2955 * cs-parser.jay: Allow parsing weird array creation construct.
2957 2008-10-05 Marek Safar <marek.safar@gmail.com>
2959 * cs-parser.jay: Conflicts reduction.
2961 2008-10-04 Marek Safar <marek.safar@gmail.com>
2963 * cs-parser.jay: Conflicts reduction.
2965 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2968 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2969 property. Add a 'count' hint about the use of the shared vector.
2970 Ensure that we don't leak out dirty bits.
2971 (UsageVector.MergeChild): Throw away information about variables
2973 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2975 2008-10-03 Marek Safar <marek.safar@gmail.com>
2977 A fix for bug #431746
2978 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2979 parameters when iterator is created.
2981 2008-10-03 Marek Safar <marek.safar@gmail.com>
2983 A fix for bug #431827
2984 * expression.cs: Fixed right based pointer arithmetic operations
2987 2008-10-03 Marek Safar <marek.safar@gmail.com>
2989 A fix for bug #353779
2990 * assign.cs, expression.cs: Fixed compound assignment conversions.
2992 2008-10-02 Marek Safar <marek.safar@gmail.com>
2994 A fix for bug #375262
2995 * statement.cs: Refactor ArrayForeach to be usable with string
2996 indexer. Optimized single dimentional arrays foreach.
2998 2008-10-02 Marek Safar <marek.safar@gmail.com>
3000 A fix for bug #431255
3001 * anonymous.cs, expression.cs: Removed broken optimization.
3003 2008-10-01 Marek Safar <marek.safar@gmail.com>
3005 * anonymous.cs: Use full type parameters of parent generic
3006 containers. Removed unnecessary AddParentStoreyReference call.
3008 2008-10-01 Marek Safar <marek.safar@gmail.com>
3010 A fix for bug #324702
3011 * class.cs: Use better shorter names for explicit interface member
3014 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3016 2008-10-01 Marek Safar <marek.safar@gmail.com>
3018 * expression.cs: Use new interface to check fixed expression.
3020 2008-10-01 Marek Safar <marek.safar@gmail.com>
3022 A fix for bug #421101
3023 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3024 interface to check for fixed fixed-buffers.
3026 2008-10-01 Marek Safar <marek.safar@gmail.com>
3028 A fix for bug #429264
3029 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3031 * delegate.cs: Removed unnecessary casts.
3033 2008-09-30 Marek Safar <marek.safar@gmail.com>
3035 A fix for bug #352151
3036 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3037 class.cs: Fixed already defined explicit interface members check.
3039 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3041 cs-tokenizer.cs: Fix typo.
3043 2008-09-28 Miguel de Icaza <miguel@novell.com>
3045 * eval.cs (InteractiveBase): The quit command now just sets a
3046 flag, instead of calling Environment.Exit(), it is milder on
3049 CompiledMethod is now in Mono.CSharp, not nested inside
3050 the Evaluator, it was inconvenient to use.
3052 2008-09-27 Miguel de Icaza <miguel@novell.com>
3054 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3055 code to be invoked without having to reparse.
3057 2008-09-27 Miguel de Icaza <miguel@novell.com>
3059 * ecore.cs: The recent changes to FieldExpr broke this as well.
3060 Fixes LINQ queries in the interactive shell.
3062 * Multiple files: indentation fixing for the Mono coding
3063 guidelines for the switch statement.
3065 * eval.cs: Make the Evaluator API thread safe.
3067 2008-09-26 Marek Safar <marek.safar@gmail.com>
3069 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3070 constructor parsing.
3072 2008-09-26 Marek Safar <marek.safar@gmail.com>
3074 A fix for bug #325326
3075 * statement.cs: Check possible mistaken empty statement using
3076 explicit blocks only.
3078 2008-09-25 Miguel de Icaza <miguel@novell.com>
3080 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3081 RootNamespace.ComputeNamespaces to update the internal list of
3082 namespaces, this is no longer done for us.
3084 (InteractiveBase): Use the Evaluator APIs instead of calling into
3087 2008-09-25 Marek Safar <marek.safar@gmail.com>
3089 A fix for bug #429264
3090 * expression.cs: Missing mutator for access to multidimensional
3093 2008-09-25 Marek Safar <marek.safar@gmail.com>
3095 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3098 * driver.cs: Missing input argument check.
3100 2008-09-25 Marek Safar <marek.safar@gmail.com>
3102 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3103 expression.cs, statement.cs, rootcontext.cs, class.cs,
3104 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3107 2008-09-24 Miguel de Icaza <miguel@novell.com>
3109 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3110 fully constructed FieldExpr, fixes the regression introduced in
3113 * ecore.cs, expression.cs: Plug back the eclass initialization as
3114 otherwise it regresses `csharp'.
3116 2008-09-24 Marek Safar <marek.safar@gmail.com>
3118 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3119 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3120 phase to resolve phase. It resolves problems with expression trees
3121 and fixes bugs #323796, #325156.
3123 2008-09-23 Marek Safar <marek.safar@gmail.com>
3125 * codegen.cs: Report better error when symbol writer is missing.
3127 2008-09-23 Marek Safar <marek.safar@gmail.com>
3129 * codegen.cs: Set .NET symbol writer.
3131 * decl.cs: Guard against null generic arguments.
3133 * report.cs: Don't report exactly same additional details.
3135 2008-09-22 Marek Safar <marek.safar@gmail.com>
3137 A fix for bug #324917
3138 * cs-parser.jay: Add missing multidimensional non-expression type
3141 2008-09-22 Marek Safar <marek.safar@gmail.com>
3143 A fix for bug #428191
3144 * anonymous.cs: Create an outer generic fields also for non-storey
3147 2008-09-22 Marek Safar <marek.safar@gmail.com>
3149 A fix for bug #378294
3150 * class.cs: Make fixed size buffers gmcs feature only.
3152 2008-09-22 Marek Safar <marek.safar@gmail.com>
3154 A fix for bug #355622, #324993
3155 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3158 2008-09-19 Marek Safar <marek.safar@gmail.com>
3160 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3163 2008-09-19 Marek Safar <marek.safar@gmail.com>
3165 A fix for bug #416110
3166 * generic.cs: Struct constraint results in default ctor and
3167 ValueType base type constraint to be set.
3169 2008-09-19 Marek Safar <marek.safar@gmail.com>
3171 A fix for bug #423791
3172 * generic.cs: Fixed params output type type-inference.
3174 2008-09-19 Marek Safar <marek.safar@gmail.com>
3176 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3178 2008-09-19 Marek Safar <marek.safar@gmail.com>
3180 * cs-tokenizer.cs: Don't break on extra partial modifier.
3182 2008-09-19 Marek Safar <marek.safar@gmail.com>
3184 A fix for bug #427592
3185 * generic.cs: Use common parameter resolve method.
3187 2008-09-18 Marek Safar <marek.safar@gmail.com>
3189 A fix for bug #414758
3190 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3193 2008-09-18 Marek Safar <marek.safar@gmail.com>
3195 * driver.cs, namespace.cs: Read types and namespaces after all
3196 requested assemblies are loaded, fixes issues with System.Core
3197 auto-reference, and #419888.
3199 2008-09-18 Marek Safar <marek.safar@gmail.com>
3201 A fix for bug #417705
3202 * cs-parser.jay: Fixed as/is operator expression split.
3204 2008-09-18 Marek Safar <marek.safar@gmail.com>
3206 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3207 Fixed expression tree representation of empty new expression and
3208 new initializer expression.
3210 2008-09-18 Miguel de Icaza <miguel@novell.com>
3212 * eval.cs: Remove warning, keep reference to driver around.
3214 * Hide fields that do not need to be public.
3216 2008-09-17 Marek Safar <marek.safar@gmail.com>
3218 A fix for bug #426385
3219 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3220 conversion for array elements.
3222 2008-09-17 Marek Safar <marek.safar@gmail.com>
3224 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3225 void parsing conflicts.
3227 2008-09-15 Marek Safar <marek.safar@gmail.com>
3229 A fix for bug #425601
3230 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3231 System.Core only when there is no custom ExtensionAttribute
3234 2008-09-15 Miguel de Icaza <miguel@novell.com>
3236 * namespace.cs: Do not report CS0246 (name
3238 2008-09-12 Marek Safar <marek.safar@gmail.com>
3240 A fix for bug #425669
3241 * generic.cs: Don't cache generic static anonymous method
3244 2008-09-12 Marek Safar <marek.safar@gmail.com>
3246 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3247 conflicting constraints.
3249 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3251 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3254 2008-09-12 Marek Safar <marek.safar@gmail.com>
3256 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3257 to null pointer conversion fixes.
3259 2008-09-11 Marek Safar <marek.safar@gmail.com>
3261 * cs-parser.jay, expression.cs: An implicitly typed local variable
3262 declarator cannot use an array initializer.
3264 2008-09-11 Marek Safar <marek.safar@gmail.com>
3266 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3268 2008-09-11 Marek Safar <marek.safar@gmail.com>
3270 * generic.cs (InflatedConstraints): Don't crash when constraints
3273 * cs-parser.jay: const_declarator is a block.
3275 * constant.cs: Check for not allowed NaN conversions.
3277 2008-09-10 Miguel de Icaza <miguel@novell.com>
3279 * driver.cs: Drop --shell argument, the compiler is no longer a
3282 * eval.cs: Move most of the code that deals with evaluation into
3283 this file and document the public API from repl.cs
3285 * repl.cs: Remove from here.
3287 2008-09-10 Marek Safar <marek.safar@gmail.com>
3289 A fix for bug #424684
3290 * generic.cs: Generic class constraints must come first.
3292 2008-09-09 Miguel de Icaza <miguel@novell.com>
3294 * cs-parser.jay: Improve error reporting for syntax errors in
3295 statements and expressions, we now report the expected tokens
3296 instead of reporting the useless "; expected".
3298 Drop the strings from the token declaration, it turns out that
3299 they did not do what I thought they did. Instead they were adding
3300 two sets of tokens to the tables.
3302 2008-09-09 Marek Safar <marek.safar@gmail.com>
3304 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3305 delegate.cs: Share special type check.
3307 2008-09-09 Marek Safar <marek.safar@gmail.com>
3309 A fix for bug #423981
3310 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3312 2008-09-09 Marek Safar <marek.safar@gmail.com>
3314 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3317 2008-09-09 Marek Safar <marek.safar@gmail.com>
3319 A fix for bugs: #324750, #335946
3320 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3321 lookup rule to determine ?-based tokens.
3323 2008-09-08 Miguel de Icaza <miguel@novell.com>
3325 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3326 expressions (like event adding or removing) end up here, so we
3327 need to treat those as statements.
3329 Add LoadAssembly method.
3331 2008-09-04 Miguel de Icaza <miguel@novell.com>
3333 * repl.cs: Add Time method.
3335 2008-09-05 Marek Safar <marek.safar@gmail.com>
3337 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3339 2008-09-05 Miguel de Icaza <miguel@novell.com>
3341 * repl.cs: Add workaround for old compilers.
3343 2008-09-04 Jb Evain <jbevain@novell.com>
3345 * repl.cs (PrettyPrint): pretty print everything that
3346 implements IDictionary, as well as IEnumerables. Also,
3347 add a quit helper property.
3349 2008-09-04 Marek Safar <marek.safar@gmail.com>
3351 * constant.cs: Better error reporting for decimal literals.
3353 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3356 2008-09-04 Marek Safar <marek.safar@gmail.com>
3357 Miguel de Icaza <miguel@novell.com>
3359 A fix for bug #422951
3360 * assign.cs (Assign.DoResolve): Perform the type conversions
3361 checks before we attempt to initialize `New' initializers.
3363 2008-09-04 Marek Safar <marek.safar@gmail.com>
3365 A fix for bug #422853
3366 * delegate.cs (DelegateCreation): Add special handling for
3367 EmptyExpression.Null instance expression which is just another
3368 hack for undecided member instance exression.
3370 2008-09-04 Marek Safar <marek.safar@gmail.com>
3372 * expression.cs, ecore.cs: Emit full expression tree for reduced
3375 2008-09-04 Marek Safar <marek.safar@gmail.com>
3377 * expression.cs (This): Guard against multi-resolving.
3379 * ecore.cs, statement.cs (Throw): Simplified.
3381 * flowanalysis.cs: Also verify event fields.
3383 2008-09-04 Miguel de Icaza <miguel@novell.com>
3385 * assign.cs (Assign.DoResolve): Perform the type conversions
3386 checks before we attempt to initialize `New' initializers.
3388 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3390 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3393 * repl.cs: Update help.
3395 2008-09-03 Miguel de Icaza <miguel@novell.com>
3397 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3398 handling of the default config handling, including the special
3399 treatment of System.Core assembly.
3401 Fixes the REPL processing for LINQ.
3403 2008-09-03 Marek Safar <marek.safar@gmail.com>
3405 A fix for bug #422507
3406 * expression.cs (UnboxCast): Add missing child expression mutator.
3408 2008-09-03 Marek Safar <marek.safar@gmail.com>
3410 * driver.cs: Don't self reference System.Core assembly.
3412 2008-09-03 Marek Safar <marek.safar@gmail.com>
3414 A fix for bug #422507
3415 * expression.cs (StringConcat): Add missing type mutator.
3417 2008-09-03 Marek Safar <marek.safar@gmail.com>
3419 * generic.cs (TypeInferenceContext): Follow equality rule for
3420 constructed type lower bound type inference.
3422 2008-09-02 Miguel de Icaza <miguel@novell.com>
3424 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3425 <dblank@cs.brynmawr.edu> which updates the cursor position on
3428 2008-09-02 Marek Safar <marek.safar@gmail.com>
3430 A fix for bug #367145
3431 * driver.cs: Fixed import of extension methods when using -noconfig
3434 2008-09-02 Marek Safar <marek.safar@gmail.com>
3436 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3437 version from non-generic implementation instead.
3439 2008-09-01 Marek Safar <marek.safar@gmail.com>
3441 A fix for bug #418908
3442 * class.cs: Use AddScopeStatement for field initializers.
3444 2008-09-01 Marek Safar <marek.safar@gmail.com>
3446 A fix for bug #415385
3447 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3449 2008-09-01 Marek Safar <marek.safar@gmail.com>
3451 A fix for bug #421736
3452 * iterators.cs: Don't crash on unreachable iterators.
3454 2008-09-01 Marek Safar <marek.safar@gmail.com>
3456 A fix for bug #421628
3457 * parameter.cs, attribute.cs: Clone also parameter attributes.
3459 2008-08-30 Miguel de Icaza <miguel@novell.com>
3461 * namespace.cs (LookupType): In EvalMode, try to replace
3462 the TypeBuilder from our cache with a Type as Reflection.Emit does
3463 not like to mix code from older assemblies emitted and new
3466 This sounds like a serious Mono bug that prevents multiple
3467 assemblies to be generated and consumed at the same time.
3469 * cs-parser.jay (push_current_class): Do not make interactive
3470 classes internal or private, make them public as we currently
3471 generate each new class in a new assembly.
3473 2008-08-29 Miguel de Icaza <miguel@novell.com>
3475 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3476 remove types that are entered into the global namespace during
3477 parsing so that we can remove them on failure.
3479 * cs-parser.jay: Parsing: we now keep track of types that are
3480 entered into global variables and queue those in case the parsing
3483 This happens in a few situations: during partial-input, we invoke
3484 the parser repeatedly for example with the string "class X", this
3485 would cause X to be registed, and we need to remove this
3486 registration so that another parse attempt later with say "class X {"
3487 would actually work.
3489 Additionally, if there is an error in the resolution phase, for
3490 example: "class X : NonExistant {}" th
3492 * cs-parser.jay: Be more precise with the errors being raised,
3493 instead of flagging all exceptions during parsing to be attributed
3494 to the parsing process, distinguish those from errors happening in
3495 the actions and hint that using -v would produce the actual
3498 * repl.cs: Do not load all compiler references on each reset,
3499 doing the partial reset takes care of this.
3501 2008-08-28 Miguel de Icaza <miguel@novell.com>
3503 * repl.cs: Add support for loading all the files from
3504 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3507 Introduce a micro-parser that is able to deambiguate on its input
3508 whether we are dealing with a compilation unit (namespace, class,
3509 interface, struct, delegate) declaration or a statement. This
3510 allows both declarations and statements to be entered.
3512 Set history size by default to 300 lines.
3514 Instead of distinguishing based on the parser.InteractiveResult,
3515 have only two cases: statements were parsed, or a compilation unit
3516 was. Always pull the Using statement additions from the
3517 compilation unit parse.
3519 * cs-tokenizer.cs: Rename tokens to better describe their intent
3520 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3522 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3523 EvalMode is used to trigger the lookup of global variables while
3524 StatementMode is used turn variable declarations into static
3527 * getline.cs: Allow history size to be set.
3529 2008-08-29 Marek Safar <marek.safar@gmail.com>
3531 A fix for bug #360755
3532 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3534 2008-08-29 Marek Safar <marek.safar@gmail.com>
3536 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3538 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3539 member name, it is too confusing
3541 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3543 * rootcontext.cs: Finally default to warning level 4.
3545 2008-08-28 Marek Safar <marek.safar@gmail.com>
3547 * class.cs (CheckBase): Ignore overloaded operators.
3549 2008-08-28 Marek Safar <marek.safar@gmail.com>
3551 A fix for bug #420830
3552 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3554 2008-08-28 Marek Safar <marek.safar@gmail.com>
3556 A fix for bug #420832
3557 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3559 2008-08-28 Marek Safar <marek.safar@gmail.com>
3561 A fix for bug #420386
3562 * nullables.cs: Fixed logic of nullable user comparison operators involving
3565 2008-08-28 Marek Safar <marek.safar@gmail.com>
3567 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3569 2008-08-27 Miguel de Icaza <miguel@novell.com>
3571 * repl.cs: Add support for aborting the running code with C-c.
3573 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3575 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3577 2008-08-27 Miguel de Icaza <miguel@novell.com>
3579 * cs-parser.jay (interactive_statement_list): A new set of rules
3580 for hosting statements that uses the "interactive_" prefix.
3582 * repl.cs: Add support for parsing `using' as a statement or as a
3583 directive. Deambiguating before passing this to the parser.
3585 We need to distinguish statement_expressions that occur at the
3586 toplevel vs those that occur embedded into expressions.
3588 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3589 that fixes the cursor key handling, and a history bug.
3591 2008-08-26 Miguel de Icaza <miguel@novell.com>
3593 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3594 limitations in Console, instead the 2.0 bootstrap libraries now
3595 include the Console bits.
3597 Also, remove the use of Nullables from getline.cs
3601 Interactive support for the C# compiler. Use gmcs --shell to
3602 enter a read-eval-print loop shell.
3604 Docs: http://www.mono-project.com/CsharpRepl
3606 * sources: include repl.cs here and getline.cs for gmcs.exe,
3607 everything else is getline.cs impaired.
3609 * Makefile: when bootstrapping pass a special flag
3610 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3611 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3612 This distinguishes those two cases.
3614 * repl.cs: Support for a read-eval-print loop. Will be soon
3615 refactored into eval support and then REPL on top of it.
3617 * ecore.cs: If a simplename lookup fails, before erroring out,
3618 if we are in EvalMode to resolve the name to a declaration in the
3621 This means that variable declarations that happened in previous
3622 classes (as repl puts every statement in a separate class) are
3623 made visible in this way.
3625 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3626 triggered an error due to the end of file being reached. This is
3627 used to do multi-line input, and notify the caller that the user
3628 needs to provide more text before a successful parse.
3630 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3631 to drive the evaluation with a custom wrapper.
3633 * driver.cs: Add support for --shell, and refactor some code to be
3636 * namespace.cs: Add support for serializing the contents of the
3637 namespaces and reloading them.
3639 * getline.cs: A managed implementation of ReadLine under
3640 X11/Apache2 license terms. Easy to embed in other applications as
3643 * namespace.cs: Add some functions to save and restore the
3646 * rootcontext.cs: New public field.
3648 * cs-tokenizer.cs: Add support for one of the possible characters
3649 we introduce into the token stream.
3651 This patch does not affect the regular tokenization process, the
3652 only performance hit would happen if there is an invalid character
3653 on the input string.
3655 * support.cs: Move isatty helper routine here.
3657 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3658 code generator for in-memory assemblies.
3660 2008-08-26 Marek Safar <marek.safar@gmail.com>
3662 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3663 parameter cannot be always used as a type.
3665 2008-08-21 Marek Safar <marek.safar@gmail.com>
3667 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3669 2008-08-21 Marek Safar <marek.safar@gmail.com>
3671 * convert.cs: Implement explicit array to IList<T> conversion.
3673 2008-08-20 Marek Safar <marek.safar@gmail.com>
3675 A fix for bug #362740
3676 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3678 2008-08-20 Marek Safar <marek.safar@gmail.com>
3680 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3681 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3682 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3683 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3684 handling to use just one type of infrastructure and deal with generics
3687 2008-07-23 Martin Baulig <martin@ximian.com>
3689 *** Merged this from trunk revision 108527 ***
3692 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3693 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3696 2008-08-15 Marek Safar <marek.safar@gmail.com>
3698 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3701 2008-08-15 Marek Safar <marek.safar@gmail.com>
3703 * delegate.cs: Fixed compiler crash when creating delegate using partial
3706 * typemanager.cs: MulticastDelegate is not a delegate.
3708 2008-08-14 Marek Safar <marek.safar@gmail.com>
3710 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3713 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3715 * cs-parser.jay (type): Allow 'var' in mcs too.
3716 (local_variable_type): Likewise.
3718 2008-08-14 Marek Safar <marek.safar@gmail.com>
3720 * driver.cs: Removed broken -noconfig variants.
3722 2008-08-14 Marek Safar <marek.safar@gmail.com>
3724 A fix for bug #417078
3725 * expression.cs: Emit correctly left side pointer operators.
3727 2008-08-13 Marek Safar <marek.safar@gmail.com>
3729 * generic.cs, lambda.cs: Inflate method generic arguments only.
3731 2008-08-12 Marek Safar <marek.safar@gmail.com>
3733 * class.cs: Fixed struct layout check regression.
3735 2008-08-12 Marek Safar <marek.safar@gmail.com>
3737 * cs-parser.jay, enum.cs: Simplified enum parsing.
3739 * decl.cs: Check all type parameters conflicts.
3741 * expression.cs, statement.cs, attribute.cs: More expression checks.
3743 2008-08-11 Marek Safar <marek.safar@gmail.com>
3745 * generic.cs: Add type inference types restriction.
3747 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3748 anonymous.cs, expression.cs: Allocate less accessor parameters.
3750 2008-08-08 Marek Safar <marek.safar@gmail.com>
3752 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3755 2008-08-08 Marek Safar <marek.safar@gmail.com>
3757 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3759 2008-08-07 Marek Safar <marek.safar@gmail.com>
3761 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3762 Also fixes #362146 and #381592.
3764 2008-08-07 Marek Safar <marek.safar@gmail.com>
3766 * ecore.cs: Reduced constant cannot be used as an attribute value.
3768 * cs-parser.jay: Base expression has to be a type.
3770 * expression.cs (Conditional): Uses ReducedExpression.
3772 2008-08-06 Marek Safar <marek.safar@gmail.com>
3774 A fix for bug #376826
3775 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3776 address of hoisted local variable or parameter cannot be taken.
3778 2008-08-05 Marek Safar <marek.safar@gmail.com>
3780 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3781 anonymous method inside checked/unchecked expression.
3783 2008-08-05 Marek Safar <marek.safar@gmail.com>
3785 * typemanager.cs (IsEqual): Guard against null.
3787 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3788 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3789 routine. Fixed few misleading conversion errors.
3791 2008-08-04 Marek Safar <marek.safar@gmail.com>
3793 * class.cs: Consider generics when checking cycles in struct layout.
3795 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3797 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3799 2008-08-04 Marek Safar <marek.safar@gmail.com>
3801 A fix for bug #414165
3802 * anonymous.cs: Use same anonymous implementation method for all anonymous
3805 2008-08-04 Marek Safar <marek.safar@gmail.com>
3807 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3810 2008-08-04 Marek Safar <marek.safar@gmail.com>
3812 * cs-parser.jay: Typeof argument has to be a type expression.
3814 * namespace.cs: Check alias and namespace definitions collisions.
3816 * class.cs, pending.cs: Moved explicit interface accessor implementation
3819 * delegate.cs, expression.cs: Verify special name invocations.
3821 2008-08-01 Marek Safar <marek.safar@gmail.com>
3823 * cs-parser.jay: Don't choke on empty generic type arguments.
3825 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3827 * expression.cs, ecore.cs: Minor expressions bugs.
3829 2008-08-01 Marek Safar <marek.safar@gmail.com>
3831 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3832 and added more error handling.
3834 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3836 * modifiers.cs, enum.cs: Fixed.
3838 2008-07-31 Jb Evain <jbevain@novell.com>
3840 * driver.cs: remove -pkg ability of smcs.
3842 2008-07-30 Marek Safar <marek.safar@gmail.com>
3844 * statement.cs (Switch): Correctly set empty default target for single
3847 2008-07-30 Marek Safar <marek.safar@gmail.com>
3849 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3850 string switch statement implementation to use string dictionary which
3851 significantly (2-8x) improves performance of generated code.
3853 2008-07-29 Marek Safar <marek.safar@gmail.com>
3855 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3856 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3858 2008-07-29 Marek Safar <marek.safar@gmail.com>
3860 A fix for bug #412595
3861 * typemanager.cs, convert.cs, expression.cs: Some types are never
3862 convertible to each other.
3864 2008-07-29 Marek Safar <marek.safar@gmail.com>
3866 * nullable.cs (CreateNullConstant): An error messages update.
3868 2008-07-29 Marek Safar <marek.safar@gmail.com>
3870 A fix for bug #412595
3871 * cfold.cs: Don't cast undefined bool constant.
3873 2008-07-29 Martin Baulig <martin@ximian.com>
3876 (SymbolWriter.Reset): New public static method.
3879 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3881 2008-07-28 Marek Safar <marek.safar@gmail.com>
3883 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3885 * expression.cs (ElementAccess): Exact size allocation.
3887 2008-07-26 Marek Safar <marek.safar@gmail.com>
3889 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3891 2008-07-25 Marek Safar <marek.safar@gmail.com>
3893 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3895 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3898 2008-07-25 Marek Safar <marek.safar@gmail.com>
3900 A fix for bug #412217
3901 * assign.cs: Mutate also assignment type.
3903 2008-07-25 Marek Safar <marek.safar@gmail.com>
3905 A fix for bug #323644
3906 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3909 2008-07-25 Marek Safar <marek.safar@gmail.com>
3911 A fix for bug #412134
3912 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3913 non-enumerable operands when overloading equality or bitwise operators.
3915 2008-07-25 Marek Safar <marek.safar@gmail.com>
3917 * anonymous.cs: Cache closed generic anonymous method delegates.
3919 2008-07-24 Marek Safar <marek.safar@gmail.com>
3921 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3922 anonymous.cs, statement.cs: Always emit anonymous method as static method
3923 when is instance free. Use nesting for nested anynomous methods blocks.
3925 2008-07-23 Marek Safar <marek.safar@gmail.com>
3927 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3930 2008-07-23 Marek Safar <marek.safar@gmail.com>
3932 * expression.cs: Removed MakeSimpleCall.
3934 2008-07-23 Marek Safar <marek.safar@gmail.com>
3936 A fix for bug #323012
3937 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3938 Base method implementing interface has to be public.
3940 2008-07-23 Marek Safar <marek.safar@gmail.com>
3942 * cs-parser.jay: Don't break on missing argument.
3944 2008-07-22 Marek Safar <marek.safar@gmail.com>
3946 A fix for bug #320993
3947 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3948 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3950 2008-07-22 Marek Safar <marek.safar@gmail.com>
3952 A fix for bug #320748
3953 * convert.cs: Implicit user operators cannot convert to interfaces
3955 2008-07-22 Marek Safar <marek.safar@gmail.com>
3957 A fix for bug #312686
3958 * driver.cs: Ignore empty assembly references.
3960 2008-07-22 Marek Safar <marek.safar@gmail.com>
3962 A fix for bug #387040
3963 * ecore.cs: Skip constrains check for an explicit implementation.
3965 2008-07-21 Marek Safar <marek.safar@gmail.com>
3967 A fix for bug #409045
3968 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3969 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3970 identifiers are file specific unless passed as input arguments.
3972 2008-07-21 Marek Safar <marek.safar@gmail.com>
3974 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3975 to emit UnmanagedMarshal data under 2.0 profile.
3977 2008-07-21 Marek Safar <marek.safar@gmail.com>
3979 A fix for bug #410369
3980 * parameter.cs: Clone correctly ParamsParameter.
3982 2008-07-21 Marek Safar <marek.safar@gmail.com>
3984 * expression.cs (Argument): Always report type for type based expressions
3987 2008-07-18 Marek Safar <marek.safar@gmail.com>
3989 A fix for bug #410666
3990 * anonymous.cs: Correctly initialize generic storey reference.
3992 2008-07-18 Marek Safar <marek.safar@gmail.com>
3994 * convert.cs: Don't box same type arguments.
3996 2008-07-18 Marek Safar <marek.safar@gmail.com>
3998 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3999 Finished missing generic type mutators.
4001 2008-07-18 Marek Safar <marek.safar@gmail.com>
4003 * iterators.cs, statement.cs: Finished statements CloneTo.
4005 2008-07-18 Marek Safar <marek.safar@gmail.com>
4007 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4009 * expression.cs: Emit optimized default value expressions in expression tree
4012 2008-07-18 Marek Safar <marek.safar@gmail.com>
4014 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4016 2008-07-17 Marek Safar <marek.safar@gmail.com>
4018 A fix for bug #367536
4019 * cs-parser.jay: Check static constructor of generic types for an access
4022 2008-07-17 Marek Safar <marek.safar@gmail.com>
4024 A fix for bug #353800
4025 * lambda.cs: Emit ret for contextual statements.
4027 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4028 up emitting redundant ret for all anonymous methods with return.
4030 2008-07-17 Marek Safar <marek.safar@gmail.com>
4032 A fix for bug #365188
4033 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4034 create anonymous method storey in unreachable block.
4036 2008-07-17 Marek Safar <marek.safar@gmail.com>
4038 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4039 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4040 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4041 statement.cs: Fixed relevant defects found by Gendarme.
4043 2008-07-17 Marek Safar <marek.safar@gmail.com>
4045 A fix for bug #325291
4046 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4047 statement.cs: Replaced IAnonymousHost with top level block flag.
4049 2008-07-17 Marek Safar <marek.safar@gmail.com>
4051 * cs-parser.jay: Clean up unused open_parens.
4053 2008-07-17 Marek Safar <marek.safar@gmail.com>
4055 * ecore.cs: Custom error message for a range variable assignment.
4057 2008-07-16 Marek Safar <marek.safar@gmail.com>
4059 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4062 2008-07-16 Marek Safar <marek.safar@gmail.com>
4064 * literal.cs: Null literal is of object type.
4066 2008-07-16 Marek Safar <marek.safar@gmail.com>
4068 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4069 expression of nullable equality comparison.
4071 2008-07-15 Marek Safar <marek.safar@gmail.com>
4073 * expression.cs(PointerArithmetic): Removed redundant assignment.
4075 2008-07-15 Marek Safar <marek.safar@gmail.com>
4077 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4079 2008-07-14 Marek Safar <marek.safar@gmail.com>
4081 A fix for bug #408361
4082 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4083 they are replaced by GetMethod.
4085 2008-07-14 Marek Safar <marek.safar@gmail.com>
4087 A fix for bug #408721 by jeremie.laval@gmail.com
4088 * expression.cs (Indirection): Implemented CloneTo.
4090 2008-07-14 Marek Safar <marek.safar@gmail.com>
4092 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4095 2008-07-14 Marek Safar <marek.safar@gmail.com>
4097 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4099 2008-07-11 Marek Safar <marek.safar@gmail.com>
4101 * linq.cs: Reset tranparent parameter counter in probing mode.
4103 2008-07-11 Marek Safar <marek.safar@gmail.com>
4105 * anonymous.cs: Mutate anonymous method type.
4107 2008-07-11 Marek Safar <marek.safar@gmail.com>
4109 * ecore.cs, anonymous.cs: Mutate field expressions.
4111 2008-07-10 Marek Safar <marek.safar@gmail.com>
4113 A fix for bug #369670
4114 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4116 2008-07-10 Marek Safar <marek.safar@gmail.com>
4118 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4120 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4123 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4124 only one '>', and finds a '>>', abort the generic lookahead.
4126 2008-07-10 Marek Safar <marek.safar@gmail.com>
4128 A fix for bug #319902
4129 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4131 2008-07-10 Marek Safar <marek.safar@gmail.com>
4133 A fix for bug #406371
4134 * statement.cs: Moved EmitSymbolInfo to Block.
4136 2008-07-09 Marek Safar <marek.safar@gmail.com>
4138 * ecore.cs: Report better error for extension method overload failures.
4140 2008-07-09 Marek Safar <marek.safar@gmail.com>
4142 * expression.cs (Is): No need to box reference values.
4144 2008-07-09 Marek Safar <marek.safar@gmail.com>
4146 * class.cs: Use event resolve context when initializing CreateEmitContext.
4148 2008-07-09 Marek Safar <marek.safar@gmail.com>
4150 A fix for bug #394436
4151 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4152 method used inside expression trees. Added more LINQ to expression tree
4155 2008-07-08 Marek Safar <marek.safar@gmail.com>
4157 A fix for bug #378189, #370577
4158 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4161 2008-07-08 Marek Safar <marek.safar@gmail.com>
4163 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4166 2008-07-08 Marek Safar <marek.safar@gmail.com>
4168 A fix for bug #406702
4169 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4171 2008-07-07 Marek Safar <marek.safar@gmail.com>
4173 A fix for bug #406648
4174 * cs-parser.jay: Report nullable use in mcs for some cases.
4176 2008-07-07 Marek Safar <marek.safar@gmail.com>
4178 * ecore.cs: Improved argument mismatch error messages.
4180 2008-07-07 Marek Safar <marek.safar@gmail.com>
4182 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4184 2008-07-07 Marek Safar <marek.safar@gmail.com>
4186 * expression.cs (TypeOf): Mutate type argument.
4188 2008-07-04 Marek Safar <marek.safar@gmail.com>
4190 * class.cs: Report missing partial modifier for correct type.
4192 2008-07-04 Marek Safar <marek.safar@gmail.com>
4194 * ecore.cs, expression.cs (VariableReference): Variable property is
4197 2008-07-04 Marek Safar <marek.safar@gmail.com>
4199 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4201 2008-07-04 Marek Safar <marek.safar@gmail.com>
4203 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4206 2008-07-04 Marek Safar <marek.safar@gmail.com>
4208 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4209 anonymous method storey to an instance method when only "this" is hoisted.
4211 2008-07-03 Marek Safar <marek.safar@gmail.com>
4213 A fix for bug #321615
4214 * expression.cs: Pointer comparisons use unsigned operator.
4216 2008-07-03 Marek Safar <marek.safar@gmail.com>
4218 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4220 2008-07-02 Marek Safar <marek.safar@gmail.com>
4222 A fix for bug #404905
4223 * class.cs: Always initialize local unsafe variables.
4225 2008-06-30 Marek Safar <marek.safar@gmail.com>
4227 A fix for bug #396987
4228 * expression.cs (NewInitialize): Clear local temporary variable for next run
4230 2008-06-27 Marek Safar <marek.safar@gmail.com>
4232 A fix for bug #401020
4233 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4235 2008-06-27 Marek Safar <marek.safar@gmail.com>
4237 A fix for bug #398319
4238 * cs-parser.jay: Implemented undocumented base access expression inside
4241 2008-06-26 Marek Safar <marek.safar@gmail.com>
4243 A fix for bug #404227
4244 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4246 2008-06-26 Marek Safar <marek.safar@gmail.com>
4248 A fix for bug #404227
4249 * convert.cs: Fixed explicit array to interface cast.
4251 2008-06-26 Marek Safar <marek.safar@gmail.com>
4253 A fix for bug #403894
4254 * delegate.cs: Mutate DelegateInvocation type.
4256 2008-06-26 Marek Safar <marek.safar@gmail.com>
4258 A fix for bug #379348
4259 * delegate.cs: Box a load of generic parameters.
4261 2008-06-26 Marek Safar <marek.safar@gmail.com>
4263 * expression.cs: Add an array creation arguments mutate.
4265 2008-06-26 Marek Safar <marek.safar@gmail.com>
4267 A fix for bug #386068
4268 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4271 2008-06-25 Marek Safar <marek.safar@gmail.com>
4273 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4276 2008-06-25 Marek Safar <marek.safar@gmail.com>
4278 A fix for bug #403518
4279 * delegate.cs: Type correctly anonymous method new invocation.
4281 2008-06-24 Marek Safar <marek.safar@gmail.com>
4283 A fix for bug #394826
4284 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4287 2008-06-24 Marek Safar <marek.safar@gmail.com>
4289 A fix for bug #394826
4290 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4293 2008-06-24 Marek Safar <marek.safar@gmail.com>
4295 * class.cs: Clone indexer parameters for localized capturing.
4297 2008-06-24 Marek Safar <marek.safar@gmail.com>
4299 A fix for bug #402379
4300 * expression.cs: Don't crash when an object initializer resolve fails.
4302 2008-06-24 Marek Safar <marek.safar@gmail.com>
4304 A fix for bug #402888
4305 * expression.cs: Mutate conditional expression.
4307 2008-06-24 Marek Safar <marek.safar@gmail.com>
4309 A fix for bug #401012
4310 * class.cs: Keep StructLayout in shared container.
4312 2008-06-24 Marek Safar <marek.safar@gmail.com>
4314 A fix for bug #400438
4315 * decl.cs, class.cs: Only properties can be automatically implemented.
4317 2008-06-24 Marek Safar <marek.safar@gmail.com>
4319 * statement.cs (ChangeToIterator): Copy also labels.
4321 2008-06-23 Marek Safar <marek.safar@gmail.com>
4323 * ecore.cs: Pass type argument details to parent extension method.
4325 2008-06-23 Marek Safar <marek.safar@gmail.com>
4327 A fix for bug #375966
4328 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4330 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4332 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4334 2008-06-22 Marek Safar <marek.safar@gmail.com>
4336 A fix for bug #394347
4337 * anonymous.cs: Cache compatible delegates as compatibility check produces
4338 a new method every time.
4340 2008-06-20 Marek Safar <marek.safar@gmail.com>
4342 * anonymous.cs: Propagate storey reference for single references.
4344 2008-06-20 Marek Safar <marek.safar@gmail.com>
4346 A fix for bug #387615
4347 * assign.cs, expression.cs: Correctly clone compound assignment.
4349 2008-06-19 Marek Safar <marek.safar@gmail.com>
4351 A fix for bug #359611, #359604
4352 * anonymous.cs: Mutate all types of hoisted parameters.
4354 2008-06-19 Marek Safar <marek.safar@gmail.com>
4356 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4357 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4358 expression.cs, codegen.cs, statement.cs
4360 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4361 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4363 ** Anonymous methods, lambda expressions rewrite **
4365 Anonymous expressions are now resolved when an explicit block is resolved
4366 and they don't require any registration procedure anymore. Further,
4367 anonymous methods are defined when explicit block is emitted which allows
4368 better control of whole process and opens possibilities for more
4369 optimizations as well as alternative to reverse whole process.
4371 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4372 process consistent and to correctly emit hoisted generic methods when they
4373 have at least 1 hoisted variable.
4375 2008-06-17 Martin Baulig <martin@ximian.com>
4377 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4379 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4380 virtual property; check it in Emit().
4381 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4383 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4385 (Indexer.Define): Likewise.
4387 2008-06-17 Marek Safar <marek.safar@gmail.com>
4389 * convert.cs: Don't use IsInterface on type arguments.
4391 * delegate.cs: DelegateInvocation uses MethodInfo.
4393 * parameter.cs: Removed IsTypeParameter.
4395 * generic-mcs.cs: More missing stuff.
4397 2008-06-16 Martin Baulig <martin@ximian.com>
4400 (Modifiers.DEBUGGER_HIDDEN): New public const.
4403 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4406 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4407 (AbstractPropertyEventMethod): Likewise.
4408 (Constructor.Emit): Likewise.
4409 (SourceMethod.SetCompilerGenerated): Removed.
4411 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4415 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4416 if we're an `IteratorHost'.
4417 (AnonymousMethodMethod..ctor): Don't set
4418 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4421 2008-06-16 Marek Safar <marek.safar@gmail.com>
4423 * statement.cs: Clean-up foreach statements.
4425 2008-06-12 Marek Safar <marek.safar@gmail.com>
4427 * class.cs: Stop using public method which should not exist
4428 (MethodBuilder.SetGenericMethodSignature).
4430 2008-06-11 Martin Baulig <martin@ximian.com>
4433 (Location.LookupFile): Add `CompilationUnit' argument; when given
4434 a relative file name, make it relative to the directory the .cs
4435 file is located in instead of using the current directory.
4437 2008-06-11 Martin Baulig <martin@ximian.com>
4440 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4441 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4442 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4443 (SourceMethod.SetCompilerGenerated): Likewise.
4445 2008-06-11 Marek Safar <marek.safar@gmail.com>
4447 * codegen.cs, driver: Only write symbol file when it's asked for.
4449 2008-06-11 Marek Safar <marek.safar@gmail.com>
4451 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4453 2008-06-10 Martin Baulig <martin@ximian.com>
4455 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4457 2008-06-09 Marek Safar <marek.safar@gmail.com>
4459 A fix for bug #316290
4460 * expression.cs: Include decimal operators in predefined table.
4462 * parameters.cs: More readonlyness.
4464 2008-06-09 Marek Safar <marek.safar@gmail.com>
4466 A fix for bug #397213
4467 * cs-parser.jay: One more missing current_local_parameters reset.
4469 2008-06-09 Marek Safar <marek.safar@gmail.com>
4471 A fix for bug #396633
4472 * class.cs: Host backing field in partial container.
4474 2008-06-09 Marek Safar <marek.safar@gmail.com>
4476 A fix for bug #397068
4477 * expression.cs: Check both operand types when predefined operator is used.
4479 2008-06-05 Martin Baulig <martin@ximian.com>
4481 Merged the `debugger-kahalo' branch.
4484 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4485 we're an iterator method.
4486 (SourceMethod): Reflect latest symbol writer changes;
4487 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4488 now `start_row' and `end_row'.
4489 (Constructor.Emit): Fix the logic whether to emit symbol information.
4491 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4495 (CompilationUnit): New public class; derives from `SourceFile'.
4496 (SourceFileEntry.DefineSymbolInfo): New public method.
4497 (SourceFileEntry.SetChecksum): New public method.
4498 (Location): Encode hidden line numbers by using `column == 255';
4499 the .ctor now accepts `column == -1' to mark a hidden line number.
4500 (Location.Hidden): New public property.
4501 (Location.CheckPoint): Add `CompilationUnit'.
4502 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4503 (Location.Push): Add `CompilationUnit compile_unit' argument.
4504 (Location.CompilationUnit): New public property.
4507 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4509 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4511 * driver.cs: `SourceFile' -> `CompilationUnit'.
4513 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4515 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4517 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4521 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4522 new symbol writer API to also pass the file.
4524 2008-06-05 Marek Safar <marek.safar@gmail.com>
4526 * statement.cs: Emit catch variable assignment using variable expression.
4528 2008-06-05 Marek Safar <marek.safar@gmail.com>
4530 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4531 with other variable types.
4533 2008-06-04 Marek Safar <marek.safar@gmail.com>
4535 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4536 GetLength method emit, it breaks resolve rules.
4538 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4539 Marek Safar <marek.safar@gmail.com>
4541 A fix for bug #395542
4542 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4545 2008-06-02 Marek Safar <marek.safar@gmail.com>
4547 A fix for bug #395287
4548 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4550 2008-05-31 Marek Safar <marek.safar@gmail.com>
4552 A fix for bug #395845
4553 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4554 non-nullable parameter type.
4556 2008-05-31 Marek Safar <marek.safar@gmail.com>
4558 * class.cs: Handle contructor initializer as a statement in top-level block.
4560 2008-05-30 Marek Safar <marek.safar@gmail.com>
4562 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4563 security attributes.
4565 2008-05-24 Marek Safar <marek.safar@gmail.com>
4567 * ecore.cs, expression.cs: Small IVariable refactoring.
4569 2008-05-22 Marek Safar <marek.safar@gmail.com>
4571 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4573 2008-05-21 Marek Safar <marek.safar@gmail.com>
4575 * cs-parser.jay: Removed redundant catch type check.
4577 2008-05-21 Marek Safar <marek.safar@gmail.com>
4579 A fix for bug #390372
4580 * nullable.cs: Set correct return type.
4582 2008-05-21 Marek Safar <marek.safar@gmail.com>
4584 A fix for bug #391062
4585 * typemanager.cs: Fixed crash when comparing null types.
4587 2008-05-21 Marek Safar <marek.safar@gmail.com>
4589 A fix for bug #391871
4590 * cs-parser.jay: Better error handling for invalid catch type.
4592 2008-05-20 Marek Safar <marek.safar@gmail.com>
4594 A fix for bug #392155
4595 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4597 2008-05-15 Marek Safar <marek.safar@gmail.com>
4599 A fix for bug #390666
4600 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4603 2008-05-15 Marek Safar <marek.safar@gmail.com>
4605 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4608 2008-05-13 Marek Safar <marek.safar@gmail.com>
4610 A fix for bug #389625
4611 * delegate.cs, generic.cs: Some progress on method group return type
4614 2008-05-13 Marek Safar <marek.safar@gmail.com>
4616 A fix for bug #378419
4617 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4619 2008-05-12 Marek Safar <marek.safar@gmail.com>
4621 * class.cs (Constructor): Added IsCompilerGenerated.
4623 2008-05-12 Marek Safar <marek.safar@gmail.com>
4625 * expression.cs: Enum binary operators can accept non-enum operand only when
4626 is implicitly convertible to underlying type.
4628 2008-05-12 Marek Safar <marek.safar@gmail.com>
4630 A fix for bug #389272
4631 * support.cs: Workaround System.InvalidOperationException for enums.
4633 2008-05-12 Marek Safar <marek.safar@gmail.com>
4635 A fix for bug #389073
4636 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4638 2008-05-10 Marek Safar <marek.safar@gmail.com>
4640 * driver.cs: Split Parse.
4642 * location.cs (LookupFile): Uses string.Empty.
4644 2008-05-07 Marek Safar <marek.safar@gmail.com>
4646 * expression.cs, parameter.cs: Small ParameterReference clean up.
4648 2008-05-07 Marek Safar <marek.safar@gmail.com>
4650 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4651 hack. Fixes #387502.
4653 2008-05-06 Martin Baulig <martin@ximian.com>
4655 * class.cs (Constructor.Emit): Fix the logic whether to emit
4658 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4661 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4662 InvalidOperationException when the iterator is before the start or
4665 2008-05-06 Marek Safar <marek.safar@gmail.com>
4667 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4668 when left is nullable type.
4670 2008-05-06 Marek Safar <marek.safar@gmail.com>
4672 A fix for bug #386628
4673 * expression.cs (LocalVariableReference): Continue in resolving when
4674 variable is not assigned.
4676 2008-05-05 Marek Safar <marek.safar@gmail.com>
4678 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4679 nullable operations.
4681 2008-05-04 Marek Safar <marek.safar@gmail.com>
4683 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4684 it saves many redundant temporary variables for nullable operations.
4686 2008-05-03 Marek Safar <marek.safar@gmail.com>
4688 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4690 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4693 * nullable.cs: Constant coalescing operator optimizations.
4695 2008-05-03 Marek Safar <marek.safar@gmail.com>
4697 * constant.cs: Use unsigned conversion for values which are unsigned only.
4699 2008-05-03 Marek Safar <marek.safar@gmail.com>
4701 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4702 coalescing operator as it should be.
4704 2008-05-02 Marek Safar <marek.safar@gmail.com>
4706 A fix for bug #371016
4707 * expression.cs: All predefined delegate operators require implicit method
4710 2008-05-02 Marek Safar <marek.safar@gmail.com>
4712 * constant.cs: Emit long constant as uint when fits the range.
4714 * convert.cs, expression.cs: Fixed few unsafe conversions.
4716 2008-05-02 Marek Safar <marek.safar@gmail.com>
4718 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4720 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4723 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4725 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4727 2008-05-01 Marek Safar <marek.safar@gmail.com>
4729 * constant.cs, literal.cs: IsLiteral property for error reporting.
4731 * ecore.cs, expression.cs: Implemented Property expression.
4733 2008-05-01 Marek Safar <marek.safar@gmail.com>
4735 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4737 * nullable.cs: Implemented nullable coalescing null operator.
4739 * ecore.cs, expression.cs: Expression trees work.
4741 2008-05-01 Marek Safar <marek.safar@gmail.com>
4743 * ecore.cs: CreateExpressionTree is finally abstract.
4745 * expression.cs, linq.cs: Updated.
4747 2008-05-01 Marek Safar <marek.safar@gmail.com>
4749 * expression.cs, ecore.cs: Block base access expression inside expression
4752 2008-05-01 Marek Safar <marek.safar@gmail.com>
4754 A fix for bug #385058
4755 * expression.cs: User-defined operator implementations always take
4756 precedence over predefined operator implementations.
4758 2008-04-30 Marek Safar <marek.safar@gmail.com>
4760 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4761 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4762 expression tree conversions.
4764 2008-04-30 Marek Safar <marek.safar@gmail.com>
4766 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4767 operators method details to Operator class.
4769 2008-04-30 Marek Safar <marek.safar@gmail.com>
4771 * anonymous.cs: Pass unsafe flags to anonymous container.
4773 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4774 inside expression tree.
4776 2008-04-29 Martin Baulig <martin@ximian.com>
4778 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4779 (Tokenizer.PopPosition): Also restore the `line'.
4781 2008-04-29 Marek Safar <marek.safar@gmail.com>
4783 * delegate.cs: Implemented Invoke expression.
4785 2008-04-29 Marek Safar <marek.safar@gmail.com>
4787 * expression.cs: Fixed equality reference comparison regression.
4789 2008-04-29 Marek Safar <marek.safar@gmail.com>
4791 * ecore.cs: Clean up EmptyCast hack.
4793 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4794 using correct conversion rules. Also fixes #383993.
4796 2008-04-28 Martin Baulig <martin@ximian.com>
4798 * class.cs (Constructor.Emit): Don't emit debugging information
4799 for generated default .ctor's.
4801 2008-04-28 Marek Safar <marek.safar@gmail.com>
4803 * convert.cs: Empty-cast ushort to int conversion.
4805 2008-04-28 Marek Safar <marek.safar@gmail.com>
4807 A fix for bug #384191
4808 * ecore.cs, expression.cs: Fixed expression cloning.
4810 2008-04-28 Marek Safar <marek.safar@gmail.com>
4812 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4814 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4816 Fix #381559, test-638.cs, test-639.cs
4817 * assign.cs (CompoundAssign.Helper): New wrapper.
4818 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4820 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4821 Pass unconverted expressions to the params array creation expression.
4822 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4823 (PropertyExpr.EmitAssign): Likewise.
4824 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4825 element if it is of kind CompoundAssign.Helper.
4826 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4827 first before anything else.
4828 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4829 (ArrayAccess.LoadArrayAndArguments): Simplify.
4831 2008-04-27 Marek Safar <marek.safar@gmail.com>
4833 * expression.cs: Fixed cloning of typeof(void).
4835 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4837 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4838 (Assign.Emit): Likewise. Move it to ...
4839 (CompoundAssign.DoResolve): ... here and ...
4840 (CompoundAssign.Emit): ... here.
4841 (EventAddOrRemove): New helper to handle += and -= on events, and
4842 avoid the use of BinaryDelegates.
4843 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4844 (EventExpr.EmitAddOrRemove): Improve.
4845 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4847 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4848 create VarExprs for 'foo.bar.var'.
4849 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4850 is a highly inappropriate name for its functionality.
4852 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4854 Simplify handling of multiple assignments
4855 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4857 (SimpleAssign): New. Class to be used for normal assignments.
4858 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4859 * expression.cs, parameter.cs, statement.cs: Likewise.
4861 2008-04-25 Marek Safar <marek.safar@gmail.com>
4863 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4864 for incompatible underlying types, more to come, uff.
4866 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4869 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4870 Handle 'leave_copy'.
4872 2008-04-25 Marek Safar <marek.safar@gmail.com>
4874 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4876 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4878 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4879 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4880 * statement.cs (While, Do, For): Allow test to have side effects.
4881 (For.DoEmit): Always emit InitStatement.
4884 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4885 Always create SideEffectConstant.
4886 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4887 of type EnumConstant.
4889 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4890 Handle 'right' being SideEffectConstant of type 'bool'.
4892 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4893 Use left.EmitBranchable instead of open coding it, so as to
4894 improve optimization opportunities.
4896 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4898 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4900 (Expression.EmitSideEffect): Document.
4902 2008-04-23 Marek Safar <marek.safar@gmail.com>
4904 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4906 2008-04-23 Marek Safar <marek.safar@gmail.com>
4908 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4910 2008-04-23 Marek Safar <marek.safar@gmail.com>
4912 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4913 conversion to expression tree.
4915 2008-04-23 Marek Safar <marek.safar@gmail.com>
4917 * ecore.cs: Removed unused expression.
4919 2008-04-22 Marek Safar <marek.safar@gmail.com>
4921 * expression.cs: Implemented NegateChecked and New expressions.
4923 2008-04-22 Marek Safar <marek.safar@gmail.com>
4925 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4927 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4930 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4931 needing final 'ret' instruction.
4933 2008-04-22 Marek Safar <marek.safar@gmail.com>
4935 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4937 2008-04-21 Marek Safar <marek.safar@gmail.com>
4939 * expression.cs: Emit ldnull and not null expression as an instance argument
4940 of static method expression calls.
4942 2008-04-21 Marek Safar <marek.safar@gmail.com>
4944 A fix for bug #378200
4945 * expression.cs: Fixed crash when creating parameterless expression tree
4948 2008-04-21 Marek Safar <marek.safar@gmail.com>
4950 A fix for bug #375297
4951 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4954 2008-04-21 Marek Safar <marek.safar@gmail.com>
4956 A fix for bug #377596
4957 * decl.cs, class.cs: Emit delegate type argument attributes.
4959 2008-04-21 Marek Safar <marek.safar@gmail.com>
4961 A fix for bug #365314
4962 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4964 2008-04-21 Marek Safar <marek.safar@gmail.com>
4966 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4969 2008-04-21 Marek Safar <marek.safar@gmail.com>
4971 * generic.cs (TypeParameter): Removed redundant location.
4973 2008-04-19 Marek Safar <marek.safar@gmail.com>
4975 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4976 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4977 FullNamedExpression in all declaration type expression, statements will come
4980 2008-04-18 Marek Safar <marek.safar@gmail.com>
4982 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4983 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4985 2008-04-18 Marek Safar <marek.safar@gmail.com>
4987 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4990 2008-04-17 Marek Safar <marek.safar@gmail.com>
4992 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4995 2008-04-17 Marek Safar <marek.safar@gmail.com>
4997 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5001 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5003 Hook up 'EmitSideEffect'
5004 * constant.cs (Constant.EmitSideEffect): New.
5005 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5006 (SideEffectConstant.EmitSideEffect): New.
5007 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5008 unconditional branch in EmitBranchable.
5009 (FieldExpr.EmitBranchable): New.
5010 * expression.cs (Unary.EmitSideEffect): New.
5011 (Binary.EmitSideEffect): New.
5012 (VariableReference.EmitSideEffect): New. Do nothing.
5014 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5016 Introduce 'EmitSideEffect'
5017 * ecore.cs (Expression.EmitSideEffect): New.
5018 (TypeCast): Rename from EmptyCast.
5020 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5021 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5022 * convert.cs, nullable.cs: Update to changes.
5024 2008-04-16 Marek Safar <marek.safar@gmail.com>
5026 * class.cs, cs-parser.jay: Early check for base types expression.
5028 2008-04-16 Marek Safar <marek.safar@gmail.com>
5030 * decl.cs (MemberName): Declare PrettyName as obsolete.
5032 2008-04-16 Marek Safar <marek.safar@gmail.com>
5034 * namespace.cs: Use MemberName comparison.
5036 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5039 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5041 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5042 (MemberName.FullyQualifiedName): New. Provides the functionality
5043 that users assume FullName would have.
5044 * ecore.cs, namespace.cs: Update to changes.
5046 * statement.cs (Using.assign): Make into ExpressionStatement.
5047 (Using.EmitPreTryBody): Simplify.
5049 2008-04-16 Marek Safar <marek.safar@gmail.com>
5051 * report.cs: ColorFormat is protected.
5053 * rootcontext.cs: Unused fields clean-up.
5055 * namespace.cs: Made UsingEntry name private.
5057 2008-04-16 Marek Safar <marek.safar@gmail.com>
5059 * cs-tokenizer.cs, location.cs: Removed unused field.
5061 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5062 Raja R Harinath <harinath@hurrynot.org>
5065 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5066 (SideEffectConstant.side_effect): Rename from 'right'.
5067 (SideEffectConstant..ctor): Normalize 'side_effect'.
5068 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5069 value of this constant.
5070 * cfold.cs: Update to changes.
5072 2008-04-15 Marek Safar <marek.safar@gmail.com>
5074 * cs-paser.jay: Removed unused variable.
5076 * driver.cs: Made Compile instance method.
5078 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5080 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5082 2008-04-15 Marek Safar <marek.safar@gmail.com>
5084 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5086 2008-04-13 Jb Evain <jbevain@novell.com>
5088 * namespace.cs: update the System.Core fullname for 2.1
5089 * driver.cs: update the list of required assemblies for 2.1.
5090 Merged from the Moonlight 2 branch.
5092 2008-04-11 Marek Safar <marek.safar@gmail.com>
5094 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5095 types and user defined operators. User operators arguments has to be checked
5096 for null value before invocation, which also means no operator is called
5097 when any argument is not convertible to unwrapped nullable type.
5099 2008-04-09 Marek Safar <marek.safar@gmail.com>
5101 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5102 of Unary expressions to follow operator overloading rules precisely.
5103 Also fixes #321794, #323794
5105 2008-04-08 Marek Safar <marek.safar@gmail.com>
5107 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5110 2008-04-08 Marek Safar <marek.safar@gmail.com>
5112 * expression.cs, ecore.cs: Implemented MemberInit expression.
5114 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5116 Fix mono/tests/exception4.cs
5117 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5118 ec.NeedReturnLabel () rather emitting a 'nop'.
5120 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5122 (TryCatch.SomeCodeFollows): Likewise.
5123 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5124 for 'break', 'continue' and 'return' statements inside a try.
5125 We're fairly sure that the generated IL stream will have more
5126 instructions textually following the try.
5127 (FlowBranchingTryCatch): Likewise.
5129 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5130 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5133 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5134 wrapper -- forward everything to CollectionForeach.
5135 (CollectionForeach.NonDisposableWrapper): New.
5136 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5137 instead of a pop + branch to end.
5139 2008-04-07 Marek Safar <marek.safar@gmail.com>
5141 A fix for bug #377485
5142 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5143 Propagate location for extension method groups. Report conversion failure at
5146 2008-04-07 Marek Safar <marek.safar@gmail.com>
5148 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5149 ListInit and Field expressions.
5151 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5153 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5154 Since $PC is always -1 inside the body of MoveNext, the fault
5156 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5157 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5158 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5160 The denouement! Fix #324708
5161 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5162 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5163 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5164 'finally' inside the finally clause.
5166 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5167 inside an iterator. Don't emit the body of the 'finally' inside
5168 the finally clause yet.
5170 Use the ResumableStatement infrastructure for MoveNext ()
5171 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5172 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5173 'old_resume_points'. Move dispatcher upfront.
5174 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5175 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5176 in an enumerator. This encodes the main fix in this patch series
5177 -- we can only jump into the first instruction of a try from the
5178 outside, but we want to emit try/finally regions in iterators and
5179 resume in the middle of them.
5181 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5183 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5184 of NeedReturnLabel here.
5186 Introduce a common point for emitting try/finally to IL
5187 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5188 features of the various subclasses, which are now driven by ...
5189 (ExceptionStatement.EmitPreTryBody): ... this and ...
5190 (ExceptionStatement.EmitTryBody): ... this and the original
5192 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5193 Remove DoEmit and update to follow above protocol.
5195 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5196 of the dispatcher are the same, skip emitting the 'switch'.
5197 * iterator.cs (Iterator.EmitDispose): Update to changes.
5199 Clean up handling of 'using' statement
5200 * statement.cs (UsingTemporary): New. Carved out of ...
5201 (Using): ... this. Simplify drastically. Handle exactly
5203 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5204 or Using as appropriate. If there are multiple variable declared,
5205 create nested Using statements.
5206 (resource_acquisition): Kill.
5208 * statement.cs (ExceptionStatement.EmitForDispose): Use
5209 EmitFinallyBody, not EmitFinally.
5211 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5212 * iterator.cs: Update to changes.
5214 Start using the ResumableStatement infrastructure
5215 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5216 (ResumableStatement.EmitForDispose): New.
5217 (ExceptionStatement): Override them.
5218 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5219 EmitForDispose to create the body of the Dispose method. Don't
5222 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5223 * statement.cs (Toplevel.AddResumePoint): ... here.
5224 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5225 * flowanalysis.cs (FlowBranchingIterator): New.
5226 * codegen.cs (EmitContext): Update to changes.
5228 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5229 (Iterator.old_resume_points): Rename from 'resume_points'.
5230 (Iterator.MoveNextStatement): Remove unused class.
5232 New infrastructure for try/finally in iterators (still unused)
5233 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5234 (FlowBranchingToplevel.AddResumePoint): Hook into
5235 ToplevelBlock.AddResumePoint.
5236 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5237 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5238 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5239 resume points and assign program-counter values.
5240 (ExceptionBlock.AddResumePoint): Collect resume points for
5241 de-muxer at the top of try block.
5242 * iterators.cs (Yield.CheckContext): Simplify.
5243 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5245 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5247 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5248 argument to an ExitStatement.
5249 (FlowBranchingException): Refactor saved origins code.
5250 * statement.cs (ExitStatement): Update to cahges.
5251 * iterator.cs (YieldBreak): Likewise.
5253 * statement.cs (ResumableStatement): New. Common base class for
5254 YieldReturn and ExceptionStatement.
5255 (ExitStatement): New. Common base class for Return and YieldBreak.
5256 (Return): Update to changes.
5257 * iterator.cs (YieldBreak): Likewise.
5258 * lambda.cs (ContextualReturn): Likewise.
5261 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5262 emit a meaningful error message.
5264 Fix #324765, #319508
5265 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5266 (VariableInfo.SetAssigned): Set it.
5267 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5268 determine if CS0219 or CS0168 is appropriate. Don't use
5269 flow-analysis information.
5270 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5271 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5272 (EmitContext.EndFlowBranching): ... this.
5274 2008-04-03 Marek Safar <marek.safar@gmail.com>
5276 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5278 2008-04-03 Marek Safar <marek.safar@gmail.com>
5280 A fix for bug #376508
5281 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5282 ImplicitConversionExists.
5284 2008-04-03 Marek Safar <marek.safar@gmail.com>
5286 * expression.cs (Binary): Added remaining binary operators to expression
5289 * nullable.cs: Optimize shift with null argument.
5291 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5293 Fix minor IL regression
5294 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5295 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5296 * cs-parser.jay (try_statement): Update to changes.
5298 * statement.cs (TryFinally.need_exc_block): Delete.
5299 (TryFinally): Update to changes.
5301 Now all ExceptionStatements are unconditional
5302 * statement.cs (CollectionForeach.DisposableWrapper): New.
5303 Extract out the try/finally code into a new wrapper.
5304 (CollectionForeach.Resolve): Use it to simplify the code.
5306 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5308 Start at simplifying ExceptionStatement semantics a bit
5309 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5310 * cs-parser.jay (try_statement): Update to changes.
5311 (opt_catch_clauses): Remove.
5312 * flowanalysis.cs: Update to changes.
5313 (FlowBranching.BranchingType.TryCatch): New.
5314 (FlowBranchingTryCatch): New.
5316 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5317 (FlowBranching.CreateBranching): Update to changes.
5318 (FlowBranchingBlock.AddSibling): Add sanity check.
5319 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5322 * iterators.cs (Iterator.MarkFinally): Remove.
5323 * statement.cs (ExceptionStatement): Update to changes.
5325 Add support for skipping over finally blocks at runtime. First
5326 in a series to fix #324708
5327 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5328 (Iterator.EmitMoveNext): Initialize it.
5329 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5330 branch over the body of the 'finally' clause.
5332 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5334 Avoid lopsided use of Foo/DoFoo names
5335 * statement.cs (ExpressionStatement.EmitFinallyBody):
5336 Rename from EmitFinally.
5337 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5338 * iterator.cs: Update to changes.
5340 2008-04-02 Marek Safar <marek.safar@gmail.com>
5342 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5343 based on UserOperatorCall. More binary nullable operators clean up.
5345 2008-04-02 Martin Baulig <martin@ximian.com>
5347 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5349 2008-04-02 Marek Safar <marek.safar@gmail.com>
5351 * nullable.cs: Merge user and empty conversions when lifting expression
5354 * expression.cs (StringConcat): Implemented expression tree representation.
5356 2008-04-01 Marek Safar <marek.safar@gmail.com>
5358 * nullable.cs: When lifting null literal and a user operator exists, no call
5361 2008-04-01 Marek Safar <marek.safar@gmail.com>
5363 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5366 2008-04-01 Marek Safar <marek.safar@gmail.com>
5368 * nullable.cs, expression.cs: Use namespace instead heavily nested
5369 monster abstract class.
5371 2008-04-01 Marek Safar <marek.safar@gmail.com>
5373 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5374 lifting of null literal and user operators. Clean up of some temporary
5377 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5379 Fix #368224, test-629.cs
5380 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5381 if it crossed an unwind-protect boundary.
5382 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5383 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5384 inside an unwind-protected region.
5385 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5386 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5387 'leave' instead of a 'br' if unwind-protected.
5388 (Iterator.EmitYieldBreak): Likewise.
5390 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5392 * driver.cs: Only define versioninfo resources if no win32 resource
5395 2008-03-28 Marek Safar <marek.safar@gmail.com>
5397 A fix for bug #372375
5398 * convert.cs: Fixed boxing of nullable types.
5400 2008-03-28 Marek Safar <marek.safar@gmail.com>
5402 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5405 2008-03-28 Marek Safar <marek.safar@gmail.com>
5407 A fix for bug #374619
5408 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5410 2008-03-27 Marek Safar <marek.safar@gmail.com>
5412 * lambda.cs: Check return type only for invocation.
5414 2008-03-27 Marek Safar <marek.safar@gmail.com>
5416 A fix for bug #374214
5417 * ecore.cs: Correctly report argument type mismatch.
5419 2008-03-27 Marek Safar <marek.safar@gmail.com>
5421 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5422 and not rely on broken IsEnum.
5424 2008-03-27 Marek Safar <marek.safar@gmail.com>
5426 * nullable.cs: New file, extracted from generic.cs.
5428 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5430 2008-03-27 Marek Safar <marek.safar@gmail.com>
5432 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5433 predefined comparison operators and null literals.
5435 * report.cs: New warning ID.
5437 2008-03-25 Marek Safar <marek.safar@gmail.com>
5439 A fix for bug #370577
5440 * lambda.cs: Check return type too.
5442 2008-03-25 Marek Safar <marek.safar@gmail.com>
5444 A fix for bug #372846
5445 * class.cs: Automatic properties can be declared as unsafe.
5447 2008-03-20 Marek Safar <marek.safar@gmail.com>
5449 * location.cs: Use string based concatenation.
5451 * expression.cs: LiftedBinaryOperator is gmcs only.
5453 2008-03-20 Marek Safar <marek.safar@gmail.com>
5455 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5456 conversions rules and expression trees.
5458 2008-03-19 Marek Safar <marek.safar@gmail.com>
5460 * delegate.cs: Use extension method source as delegate target.
5462 2008-03-19 Marek Safar <marek.safar@gmail.com>
5464 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5465 binary operations to be purely based on binary operations and optimized
5466 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5467 and other ET refactoring.
5469 * typemanager.cs: Fixed warning.
5471 2008-03-17 Marek Safar <marek.safar@gmail.com>
5473 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5475 * symbolwriter.cs: Fixed.
5477 2008-03-17 Marek Safar <marek.safar@gmail.com>
5479 * anonymous.cs, driver.cs: Reset anonymous types counters.
5481 2008-03-17 Marek Safar <marek.safar@gmail.com>
5483 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5485 * class.cs: Use fullname for all type member definitions.
5487 2008-02-19 Martin Baulig <martin@ximian.com>
5490 (IMethodData.EmitExtraSymbolInfo): New interface method.
5491 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5492 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5493 interface method here as an empty public virtual method.
5496 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5497 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5498 CodeGen.SymbolWriter.SetRealMethodName().
5500 2008-02-18 Martin Baulig <martin@ximian.com>
5503 (ScopeInfo.EmitType): Override this and emit debugging
5504 information for captured variables.
5505 (RootScopeInfo.EmitType): Override this and emit symbol
5506 information for a captured `this'.
5508 2008-02-15 Martin Baulig <martin@ximian.com>
5510 * iterators.cs: Emit debugging info.
5513 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5514 (EmitContext.OmitDebuggingInfo): New public property.
5517 (While): Override Emit() and don't emit symbol info there; do it
5518 inside DoEmit() instead.
5519 (Block.Emit): Omit symbol information while emitting the scope
5520 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5522 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5523 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5524 .ctor to make `IsIterator' work.
5526 2008-03-14 Martin Baulig <martin@ximian.com>
5528 * symbolwriter.cs: Added the new symbol writer function from the
5529 debugger's `terrania' branch; temporarily enclose them inside
5530 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5533 2008-03-14 Martin Baulig <martin@ximian.com>
5536 (SymbolWriter): Make this a public static class.
5539 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5540 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5542 2008-03-14 Marek Safar <marek.safar@gmail.com>
5544 A fix for bug #370577
5545 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5548 2008-03-14 Marek Safar <marek.safar@gmail.com>
5550 * typemanager.cs (CSharpName): Made 250 times faster.
5552 2008-03-13 Marek Safar <marek.safar@gmail.com>
5554 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5556 2008-03-12 Marek Safar <marek.safar@gmail.com>
5558 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5559 crash when predefined field does not exist.
5561 2008-03-12 Marek Safar <marek.safar@gmail.com>
5563 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5565 2008-03-12 Marek Safar <marek.safar@gmail.com>
5567 * class.cs (FixedField): Don't crash when contructors are missing.
5569 2008-03-11 Marek Safar <marek.safar@gmail.com>
5571 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5572 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5573 check internal types accessibility for internal and external types.
5574 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5576 2008-03-11 Marek Safar <marek.safar@gmail.com>
5578 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5579 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5580 attribute.cs, statement: Use corect instance of predefined types (work
5581 related to #364674).
5583 2008-03-07 Marek Safar <marek.safar@gmail.com>
5585 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5587 2008-03-07 Marek Safar <marek.safar@gmail.com>
5589 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5590 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5591 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5592 predefined types clean up, delayed predefined types members initialization
5593 (work related to #364674).
5595 2008-03-05 Marek Safar <marek.safar@gmail.com>
5597 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5599 2008-03-05 Marek Safar <marek.safar@gmail.com>
5601 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5602 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5603 predefined types clean up (work related to #364674).
5605 2008-03-04 Marek Safar <marek.safar@gmail.com>
5607 * ecore.cs: Print an error message instead of throwing exception.
5609 2008-03-04 Marek Safar <marek.safar@gmail.com>
5611 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5612 expression.cs, statement.cs: Unififed null literal representation.
5614 2008-03-03 Marek Safar <marek.safar@gmail.com>
5616 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5617 expression.cs: Refactored binary operators resolve phase and improved speed.
5618 The nullable code is still missing and won't work correctly, more fixes
5621 It also fixes #323726, #324312, #324248, and many other unreported issues.
5623 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5625 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5628 2008-02-27 Marek Safar <marek.safar@gmail.com>
5630 * ecore.cs: Clean-up and split BetterConversion.
5632 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5635 * enum.cs (EnumMember.Value): Only access 'value' if
5636 ResolveValue says it's ok.
5637 (EnumMember.DoResolveValue): Don't set prev_member.value.
5638 (Enum.GetDefinition): Reverse arguments of Equals --
5639 EnumMember.Value can return 'null'.
5641 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5643 2008-02-22 Marek Safar <marek.safar@gmail.com>
5645 * generic.cs, expression.cs: More ongoing work on expression trees.
5647 2008-02-21 Marek Safar <marek.safar@gmail.com>
5649 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5650 handle missing matches when mutiple operators exist.
5652 2008-02-20 Marek Safar <marek.safar@gmail.com>
5654 A fix for bug #363218
5655 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5658 2008-02-20 Marek Safar <marek.safar@gmail.com>
5660 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5661 update. This time to deal correctly with SideEffectConstant expression used
5662 as an argument for another constant folding.
5664 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5666 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5669 2008-02-19 Marek Safar <marek.safar@gmail.com>
5671 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5673 2008-02-19 Marek Safar <marek.safar@gmail.com>
5675 A fix for bug #328136
5676 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5677 side is a false constant, because we still need to evaluate the right-hand
5680 * statement.cs (If): Emit two types of boolean constants (simple constant,
5681 side-effect constant).
5683 2008-02-19 Marek Safar <marek.safar@gmail.com>
5685 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5687 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5690 2008-02-18 Marek Safar <marek.safar@gmail.com>
5692 A fix for bug #361457
5693 * ecore.cs (IsApplicable): Params methods have lower priority.
5695 * support.cs: Return correct parameter modifier for params types.
5697 2008-02-18 Marek Safar <marek.safar@gmail.com>
5699 * generic.cs (TypeParameter): Cache attribute target name.
5701 * support.cs: Removed unused variable.
5703 * typemanager.cs: Removed debugging leftover.
5705 * ecore.cs: Use local type instead of a property;
5707 * class.cs (VerifyMembers): Consider also parent to test whether type member
5710 * expression.cs (FullMethodDesc): Removed.
5712 * attribute.cs (IsValidArgumentType): Made static.
5714 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5716 Cleanup to be more readable.
5717 * Makefile (GMCS_PROFILE): Remove.
5718 (COMPILER_NAME): New helper.
5720 2008-02-15 Miguel de Icaza <miguel@novell.com>
5722 * cs-tokenizer.cs: if a conditional expression happens inside a
5723 (...) this also means that we do not need to de-ambiguate between
5724 an parenthesized expression and a cast.
5728 * constant.cs (SideEffectConstant): a constant value that happens
5729 to have a side effect.
5731 Fixes the build regressions introduced by the fix for #359789
5733 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5735 * expression.cs (Conditional.Emit): when emitting the ternary
5736 operator, use local variables to generate code verifiable code.
5738 The verifier cannot infer that the type on stack before the
5739 stloc.0 is executed is of type ParentB. This happens because the
5740 stack merge algorithm uses only parent types when deciding which
5741 is the common type. This is described in Part III 1.8.1.3 of ECMA
5744 This code compiled with mcs is not verifiable under MS. The MS
5745 verifier picks the first common interface of Foo and Bar, which is
5746 wrong, but doesn't use a full join type of the 2 interfaces.
5748 CSC uses a clever hack to compile such code in a verifiable
5749 way. It stores the intermediate values in a local variable with
5754 2008-02-14 Miguel de Icaza <miguel@novell.com>
5756 * expression.cs: Do not fold BitwiseAnd operators when the left
5757 side is a false constant, because we still need to evaluate the
5762 * support.cs: Instead of throwing an InternalErrorException when
5763 the position of the stream is outside the boundary of our buffer,
5764 reset the state of the reader, and restart the reading from the
5765 beginning of the file.
5767 2008-02-14 Marek Safar <marek.safar@gmail.com>
5769 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5771 2008-02-14 Marek Safar <marek.safar@gmail.com>
5773 A fix for bug #361686
5774 * decl.cs: A protected types used inside a private class which parents
5775 derives from the protected class are accessible.
5777 2008-02-13 Marek Safar <marek.safar@gmail.com>
5779 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5780 the parameterless constructor.
5782 2008-02-13 Marek Safar <marek.safar@gmail.com>
5784 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5785 lookup methods to use standard member cache when doing member lookup.
5787 2008-02-12 Marek Safar <marek.safar@gmail.com>
5789 * driver.cs: Don't report full path for referenced module as assembly error.
5791 2008-02-12 Marek Safar <marek.safar@gmail.com>
5793 * Makefile: Fixed `qh' target to work on all machines.
5795 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5796 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5797 and HasElementType with TypeManager implementation.
5799 2008-02-08 Marek Safar <marek.safar@gmail.com>
5801 A fix for bugs #325134, #359749
5802 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5803 first binds point to non-method member expression.
5805 2008-02-08 Marek Safar <marek.safar@gmail.com>
5807 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5809 2008-02-08 Marek Safar <marek.safar@gmail.com>
5811 A fix for bugs #321394, #323028
5812 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5813 Reworked naive IsAccessibleAs implementation to handle nested types.
5815 2008-02-05 Jb Evain <jbevain@novell.com>
5817 * class.cs: use generic type comparison for parameters
5820 2008-02-05 Marek Safar <marek.safar@gmail.com>
5822 A fix for bug #325372
5823 * class.cs: Use generic type comparison when testing method signatures.
5825 2008-02-05 Marek Safar <marek.safar@gmail.com>
5827 A fix for bug #357047
5828 * ecore.cs: Applied C# 3.0 changes to better conversion.
5830 2008-02-05 Marek Safar <marek.safar@gmail.com>
5832 A fix for bug #358374
5833 * cs-parser.jay: Correctly set modifiers for all constructor types.
5835 2008-02-04 Marek Safar <marek.safar@gmail.com>
5837 A fix for bug #355251
5838 * generic.cs: Added base class constraint based type inference.
5840 2008-02-01 Marek Safar <marek.safar@gmail.com>
5842 A fix for bug #357255
5843 * decl.cs: One more missing visibility check.
5845 2008-02-01 Marek Safar <marek.safar@gmail.com>
5847 * support.cs: Fixed broken return.
5849 2008-01-25 Marek Safar <marek.safar@gmail.com>
5851 * report.cs: Correctly reset warnings count after probing.
5853 2008-01-25 Martin Baulig <martin@ximian.com>
5856 (NamespaceEntry.SymbolFileID): Make this work again after
5857 MemberName.ToString() is gone.
5859 2008-01-25 Marek Safar <marek.safar@gmail.com>
5861 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5864 2008-01-25 Marek Safar <marek.safar@gmail.com>
5866 * generic.cs: Use full implicit conversion for type inference fixing.
5868 2008-01-24 Marek Safar <marek.safar@gmail.com>
5870 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5871 Fixed user operator conversions.
5873 2008-01-24 Marek Safar <marek.safar@gmail.com>
5875 * generic.cs: Do nullable type to null comparison optimization during
5878 2008-01-24 Marek Safar <marek.safar@gmail.com>
5880 A fix for bug #355163
5881 * generic.cs: Enabled l-value resolve on nullable expressions.
5883 2008-01-24 Marek Safar <marek.safar@gmail.com>
5885 A fix for bug #353986
5886 * class.cs: Ingore static ctors with parameters for any further checks.
5888 2008-01-24 Marek Safar <marek.safar@gmail.com>
5890 A fix for bug #354310
5891 * namespace.cs: Removed redundant check.
5893 2008-01-24 Marek Safar <marek.safar@gmail.com>
5895 A fix for bug #354928
5896 * expression.cs: ElementInitializers can be resolved only once.
5898 2008-01-24 Marek Safar <marek.safar@gmail.com>
5900 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5901 Condition expressions.
5903 2008-01-23 Marek Safar <marek.safar@gmail.com>
5905 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5907 2008-01-22 Marek Safar <marek.safar@gmail.com>
5909 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5912 * generic.cs: Implemented coalesce expression.
5914 2008-01-22 Marek Safar <marek.safar@gmail.com>
5916 A fix for bug #355145
5917 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5918 expression tree type inference.
5920 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5923 * expression.cs (Binary.IsUnsignedType): Fix typo.
5925 2008-01-22 Marek Safar <marek.safar@gmail.com>
5927 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5929 2008-01-22 Marek Safar <marek.safar@gmail.com>
5931 A fix for bug #355161
5932 * ecore.cs, expression.cs: Wider range of extension method supported
5935 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5937 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5938 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5941 2008-01-22 Marek Safar <marek.safar@gmail.com>
5943 A fix for bug #355148
5944 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5946 2008-01-22 Miguel de Icaza <miguel@novell.com>
5948 * expression.cs (CreateExpressionTree): Add support for or and
5949 logical or, and indent following the coding conventions.
5951 * typemanager.cs (LinqExpression): renamed from
5952 ExpressionTreeManager, for a shorter name.
5954 Use TypeManager.CoreLookupType to lookup types from our core
5955 assemblies and turn those into "Type" variables.
5957 Consumers that previously used "Namespace" and "Type" from this
5958 class should instead use the TypeExpression which is a type that
5959 is fully resolved (without involving the regular C# resolution
5962 This typically looks like this:
5964 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5965 new MemberAccess (texpr, name, type_arguments, loc)
5967 This avoids the problem in: #355178
5969 2008-01-21 Marek Safar <marek.safar@gmail.com>
5971 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5972 feature in parser only as we do in other cases.
5974 2008-01-21 Marek Safar <marek.safar@gmail.com>
5976 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5977 typemanager.cs: A refactoring of params arguments to reuse existing
5978 expressions (params -> array initializer) to emit params argument instead
5979 of specialized handling.
5980 It was required by expression tree implementation and it has other benefits
5981 as well, we now apply same optimization for params arguments as we do for
5984 2008-01-18 Marek Safar <marek.safar@gmail.com>
5986 A fix for bug #353526
5987 * generic.cs: A type inference of params arguments may not required any
5988 temporary array creation.
5990 2008-01-18 Marek Safar <marek.safar@gmail.com>
5992 A fix for bug #353534
5993 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5994 supported for delegates only.
5996 2008-01-18 Marek Safar <marek.safar@gmail.com>
5998 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5999 type for more than 1 candidates.
6001 2008-01-18 Marek Safar <marek.safar@gmail.com>
6003 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6006 2008-01-16 Marek Safar <marek.safar@gmail.com>
6008 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6009 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6010 operator) expressions.
6012 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6014 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6015 not accessed from the generated IL.
6017 2008-01-14 Marek Safar <marek.safar@gmail.com>
6019 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6020 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6021 statement.cs: The first expression tree implementation drop, mostly
6022 infrastructure work.
6024 2008-01-14 Marek Safar <marek.safar@gmail.com>
6026 * ecore.cs (IsNestedChild): Refactored.
6028 2008-01-11 Marek Safar <marek.safar@gmail.com>
6030 * lambda.cs: Don't use a cast on unknown expression statement.
6032 2008-01-10 Geoff Norton <gnorton@novell.com>
6034 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6037 2008-01-09 Marek Safar <marek.safar@gmail.com>
6039 * doc.cs: Report better /doc crash details.
6041 2008-01-09 Marek Safar <marek.safar@gmail.com>
6043 A fix for bug #352536
6044 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6046 2008-01-08 Marek Safar <marek.safar@gmail.com>
6048 A fix for bug #352287
6049 * ecore.cs, expression.cs: Do `this' access checking in all member access
6052 2008-01-08 Marek Safar <marek.safar@gmail.com>
6054 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6056 * report.cs: Reset message stacks.
6058 2008-01-08 Marek Safar <marek.safar@gmail.com>
6060 * generic.cs (InferInPhases): Correctly calculate params position.
6062 2008-01-08 Marek Safar <marek.safar@gmail.com>
6064 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6067 2008-01-07 Marek Safar <marek.safar@gmail.com>
6069 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6071 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6073 * driver.cs: Updated --help option.
6075 2008-01-07 Marek Safar <marek.safar@gmail.com>
6077 * generic.cs (InferParamsTypeArguments): Removed.
6078 (InferInPhases): Add params type inference.
6079 (LowerBoundInference): Fixed scoring mechanism.
6081 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6083 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6085 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6086 byte array for unsigned "baked" assemblies.
6088 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6090 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6091 array for assemblies that are not strongnamed.
6093 2008-01-04 Marek Safar <marek.safar@gmail.com>
6095 A fix for bug #351481
6096 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6097 declaring type for nested generic types.
6099 2008-01-04 Marek Safar <marek.safar@gmail.com>
6101 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6102 instead of ToString.
6104 2008-01-03 Marek Safar <marek.safar@gmail.com>
6106 A fix for bug #351047
6107 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6108 null and structs only when equality and inequality operators are defined
6109 either as an user-operators or predefined operators.
6111 2008-01-03 Marek Safar <marek.safar@gmail.com>
6113 A fix for bug #351047
6114 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6116 2008-01-03 Marek Safar <marek.safar@gmail.com>
6118 A fix for bug #351257
6119 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6121 2008-01-03 Marek Safar <marek.safar@gmail.com>
6123 A fix for bug #351157
6124 * class.cs (Using): Fixed yet another broken cloning.
6126 (Block): Put back more sensible default value for statements.
6128 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6130 * codegen.cs: Allow AssemblyVersion with only major version component.
6133 2007-12-29 Marek Safar <marek.safar@gmail.com>
6135 A fix for bug #324654
6136 * class.cs: Use FullName property as member name.
6138 2007-12-28 Marek Safar <marek.safar@gmail.com>
6140 A fix for bug #342117
6141 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6142 constructor constraint.
6144 2007-12-28 Marek Safar <marek.safar@gmail.com>
6146 A fix for bug #338273
6147 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6150 2007-12-28 Marek Safar <marek.safar@gmail.com>
6152 A fix for bug #350839
6153 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6155 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6157 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6160 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6162 * statement.cs: Changed some Hashtables to use HybridDictionaries
6163 instead. It was observed that some HashTables only contained a few
6164 items in the vast majority of cases. Since HybridDictionary is
6165 more efficient on small sets (<10 elements), "known_variables"
6166 from class ExplicitBlock as well as "labels" and "constants " from
6167 class Block were changed to HybridDictionaries.
6169 Atsai results: (56216kb->54987kb)
6171 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6174 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6176 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6179 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6181 * expression.cs: foreach loop to for loop, saved on allocation of
6182 enumerator (59333kb->59141kb)
6184 * statement.cs. Changed foreach loops to for loops, saved on
6185 allocation of enumerator (59141kb->59006kb)
6187 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6188 when constructed with no specified capacity. This was causing a
6189 few ArrayLists to allocate more memory than they would potentially
6190 need in the Block class and MemberCache class. Setting the
6191 ArrayLists to construct with a capacity of 1 saves some
6192 memory. (56216kb->55585kb)
6194 2007-12-27 Marek Safar <marek.safar@gmail.com>
6196 A fix for bug #347189 (2nd issue)
6197 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6200 2007-12-27 Miguel de Icaza <miguel@novell.com>
6202 * report.cs: Do not use colors if stdout and stderr are not a
6205 2007-12-27 Marek Safar <marek.safar@gmail.com>
6207 A fix for bug #346998
6208 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6211 2007-12-27 Marek Safar <marek.safar@gmail.com>
6213 A fix for bug #343465
6214 * class.cs: Explicit method name for nested types uses dots only.
6216 2007-12-27 Marek Safar <marek.safar@gmail.com>
6218 A fix for bug #343707
6219 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6221 2007-12-27 Marek Safar <marek.safar@gmail.com>
6223 * ecore.cs: Report type inference errors only when arguments count matches
6226 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6228 * expression.cs, report.cs: New warning.
6230 * typemanager.cs: Catch anonymous method type too.
6232 2007-12-23 Marek Safar <marek.safar@gmail.com>
6234 A fix for bug #346379
6235 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6237 2007-12-23 Marek Safar <marek.safar@gmail.com>
6239 A fix for bug #347359
6240 * expression.cs (Invocation): Don't resolve already resolved expression.
6242 2007-12-23 Marek Safar <marek.safar@gmail.com>
6244 A fix for bug #347189
6245 * class.cs (FixedField): Use non-dependent code only in the define phase.
6247 2007-12-23 Marek Safar <marek.safar@gmail.com>
6249 A fix for bug #348076
6250 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6252 2007-12-22 Marek Safar <marek.safar@gmail.com>
6254 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6255 discovered extension methods.
6257 2007-12-22 Marek Safar <marek.safar@gmail.com>
6259 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6262 2007-12-21 Miguel de Icaza <miguel@novell.com>
6264 * report.cs (ErrorMessage): Add support for using colors on
6265 terminals that support it.
6267 2007-12-21 Marek Safar <marek.safar@gmail.com>
6269 * ecore.cs: Use information about expanded params for error reporting.
6271 2007-12-21 Marek Safar <marek.safar@gmail.com>
6273 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6274 and logic for params overloads.
6276 2007-12-15 Miguel de Icaza <miguel@novell.com>
6278 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6279 as this is also created from the parser. Fixes #349034
6281 2007-12-12 Miguel de Icaza <miguel@novell.com>
6283 * statement.cs (Throw.CloneTo): it is valid to have empty
6284 expressions for throw.
6286 2007-12-03 Marek Safar <marek.safar@gmail.com>
6288 * cs-parser.jay: Set delegate constraint parsing region correctly.
6290 2007-12-03 Marek Safar <marek.safar@gmail.com>
6292 A fix for bug #345467
6293 * typemanager.cs (IsEqual): Compare generic parameters position only.
6295 2007-11-28 Marek Safar <marek.safar@gmail.com>
6297 * expression.cs (BaseAccess): Type arguments can be null.
6299 2007-11-27 Raja R Harinath <harinath@gmail.com>
6301 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6302 consistent even when an error has occured.
6303 (Switch.Resolve): Likewise.
6305 2007-11-22 Marek Safar <marek.safar@gmail.com>
6307 A fix for bug #334505
6308 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6311 2007-11-22 Marek Safar <marek.safar@gmail.com>
6313 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6314 refactorings required to resolve extension methods correctly when mixing
6315 generics and non-generics members.
6317 2007-11-20 Marek Safar <marek.safar@gmail.com>
6319 A fix for bug #342584
6320 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6323 2007-11-19 Marek Safar <marek.safar@gmail.com>
6325 A fix for bug #342512
6326 * delegate.cs: Use delegate argument expression when is available. Don't
6327 emit virtual call when class is sealed.
6329 2007-11-16 Marek Safar <marek.safar@gmail.com>
6331 A fix for bug #325423
6332 * assign.cs (FieldInitializer): Use resolved expression for emit.
6334 * class.cs: Print less confusing error message.
6336 2007-11-16 Marek Safar <marek.safar@gmail.com>
6338 * cs-tokenizer.cs: Removed GMCS ifdefs.
6340 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6343 * cs-parser.jay: Disabled nullable check.
6345 * generic-mcs: Copied more generic stuff.
6347 2007-11-16 Marek Safar <marek.safar@gmail.com>
6349 * gcs-parser.jay: Merged to cs-parser.jay.
6351 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6352 * *.csproj, *.sources: Updated to use only jay parser file.
6354 2007-11-16 Marek Safar <marek.safar@gmail.com>
6356 * gcs-parser.jay: Added nullable and default expression feature checks.
6358 2007-11-16 Marek Safar <marek.safar@gmail.com>
6360 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6361 it fixes many TODOs and hidden bugs.
6363 * expression: Removed duplicate error check.
6365 2007-11-15 Marek Safar <marek.safar@gmail.com>
6367 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6368 implicitly type local variable only when it is used in a declaration.
6370 2007-11-15 Marek Safar <marek.safar@gmail.com>
6372 * attribute.cs: Use CS0612 for empty strings.
6374 2007-11-14 Marek Safar <marek.safar@gmail.com>
6376 * lambda.cs, statement.cs: Contextual return may act as a statement.
6378 2007-11-14 Marek Safar <marek.safar@gmail.com>
6380 A fix for a regression cause by #324222
6381 * class.cs: Don't report unused even when it implements an interface.
6383 2007-11-13 Marek Safar <marek.safar@gmail.com>
6385 A fix for bug #341205
6386 * ecore.cs, expression.cs: Method group expression cannot do static
6387 method access with an instance reference check before overloading takes
6390 2007-11-13 Marek Safar <marek.safar@gmail.com>
6392 A fix for bug #325359
6393 * class.cs: Use predictable name for automatically generated property.
6395 2007-11-12 Marek Safar <marek.safar@gmail.com>
6397 A fix for bug #324996
6398 * expression.cs (Is): Handle case where D is nullable and T is not
6401 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6403 2007-11-12 Marek Safar <marek.safar@gmail.com>
6405 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6406 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6407 Flush small error reporting changes.
6409 2007-11-09 Marek Safar <marek.safar@gmail.com>
6411 A fix for bug #324996
6412 * expression.cs: Rewrote Is expression implementation to work with
6413 generics, nullable types, anonymous method. A const result expression
6414 uses existing infrastructure instead of custom not fully-featured one.
6416 2007-11-08 Marek Safar <marek.safar@gmail.com>
6418 A fix for bug #340202
6419 * class.cs: Consider generics for volatile field.
6421 2007-11-08 Marek Safar <marek.safar@gmail.com>
6423 A fix for bug #335594
6424 * expression.cs: Use conversion rules when handling string addition.
6426 2007-11-07 Marek Safar <marek.safar@gmail.com>
6428 A fix for bug #336651
6429 * expression.cs: Fixed a crash when probing is on.
6431 2007-11-07 Marek Safar <marek.safar@gmail.com>
6433 A fix for bug #324242
6434 * covert.cs: Added a conversion from any nullable-type with an
6435 underlying enum-type to the type System.Enum.
6437 2007-11-07 Marek Safar <marek.safar@gmail.com>
6439 A fix for bug #324222
6440 * class.cs: Report all non-used event fields.
6442 2007-11-07 Marek Safar <marek.safar@gmail.com>
6444 A fix for bug #325161
6445 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6446 qualifier for generic types.
6448 2007-11-07 Marek Safar <marek.safar@gmail.com>
6450 A fix for bug #322971
6451 * expression.cs, ecore.cs: Added intermediate result value check for
6454 2007-11-07 Marek Safar <marek.safar@gmail.com>
6456 A fix for bug #324754
6457 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6458 when it was requested.
6460 2007-11-07 Marek Safar <marek.safar@gmail.com>
6462 A fix for bug #325101
6463 * expression.cs: Do type not value comparison for `is' expression.
6465 2007-11-07 Marek Safar <marek.safar@gmail.com>
6467 A fix for bug #320236
6468 * convert.cs: Don't apply user conversion on underlying target type.
6470 2007-11-06 Marek Safar <marek.safar@gmail.com>
6472 * expression.cs: Don't use unresolved expression for error reporting.
6474 2007-11-06 Marek Safar <marek.safar@gmail.com>
6476 A fix for bugs #337712, #324490
6477 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6478 overloading resolution too.
6480 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6481 the process consistent and more robust.
6483 * expression.cs, linq.cs, report.cs: Update.
6485 2007-11-02 Marek Safar <marek.safar@gmail.com>
6487 A fix for bug #332909
6488 * attribute.cs: Resolve attributes in correct context using error
6491 * rootcontext.cs: Define Obsolete attribute members as core members.
6493 2007-11-02 Marek Safar <marek.safar@gmail.com>
6495 * statement.cs: Removed unused methods.
6497 2007-10-31 Wade Berrier <wberrier@novell.com>
6499 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6500 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6503 2007-10-31 Marek Safar <marek.safar@gmail.com>
6505 A fix for bug #338102
6506 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6507 methods registered as non-generics.
6509 2007-10-31 Marek Safar <marek.safar@gmail.com>
6511 A fix for bugs #337712, #324490
6512 * delegate.cs: Delegate covariance and contravariance is not allowed for
6515 2007-10-31 Marek Safar <marek.safar@gmail.com>
6517 A fix for bug #337719
6518 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6521 2007-10-30 Marek Safar <marek.safar@gmail.com>
6523 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6525 2007-10-29 Marek Safar <marek.safar@gmail.com>
6527 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6530 2007-10-29 Raja R Harinath <rharinath@novell.com>
6532 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6534 2007-10-29 Marek Safar <marek.safar@gmail.com>
6536 A fix for bug #334652
6537 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6538 extension methods when we have not found the best candidate in normal
6541 2007-10-27 Marek Safar <marek.safar@gmail.com>
6543 * AssemblyInfo.cs: Keep up-to-date.
6545 2007-10-27 Marek Safar <marek.safar@gmail.com>
6547 * Makefile: Fixed generics compiler name.
6549 2007-10-27 Marek Safar <marek.safar@gmail.com>
6551 * lambda.test: removed, lambda parsing is done differently.
6553 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6555 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6557 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6559 2007-10-27 Marek Safar <marek.safar@gmail.com>
6561 * Makefile, *.sources : All C# compilers are in mcs folder.
6563 * *.cs: Use existing 2_1 define for smcs.
6565 2007-10-26 Marek Safar <marek.safar@gmail.com>
6567 A fix for bug #335847
6568 * assign.cs, expression.cs: Couple of changes to avoid creating a
6569 temporary variable for each object initializer assignment statement. It
6570 simplifies struct initialization too, otherwise two temporary variables
6572 Implemented optimization of redundant default element initializers.
6574 2007-10-25 Marek Safar <marek.safar@gmail.com>
6576 A fix for bug #336766
6577 * expression.cs (Class.CheckBase): Use generic name when method is
6580 2007-10-25 Marek Safar <marek.safar@gmail.com>
6582 A fix for bug #334737
6583 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6584 variable and not variable argument for prepared copies.
6586 2007-10-24 Marek Safar <marek.safar@gmail.com>
6588 A fix for bug #325110
6589 * class.cs, expression.cs, attribute.cs: Use open generic method when
6590 checking conditional attribute.
6592 2007-10-24 Marek Safar <marek.safar@gmail.com>
6594 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6595 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6596 FeatureIsNotAvailable.
6598 2007-10-24 Marek Safar <marek.safar@gmail.com>
6600 ** C# 3.0 Partial methods
6602 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6603 methods support. Because of member cache issue with generics only
6604 non-generics partial methods are fully supported.
6606 2007-10-23 Marek Safar <marek.safar@gmail.com>
6608 * class.cs, decl.cs: Rewrote member overloads check to cope with
6609 generics and to use member cache for member checking. It also improves
6610 performance and fixes remaining overloads issues.
6612 2007-10-20 Marek Safar <marek.safar@gmail.com>
6614 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6615 roottypes.cs, typemanager.cs:
6617 A member cache creation logic changed to add members immediately and
6618 not rely on fallback. The member cache is now only prefered way
6619 how to access and find type declaration members. It saves 5 MB of memory
6620 during MWF compilation and makes code ready for more optimizations and
6621 clean-ups, it's also a pre-requirement for partial methods.
6623 2007-10-18 Raja R Harinath <harinath@gmail.com>
6625 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6626 handling for generic parameters.
6628 2007-10-15 Marek Safar <marek.safar@gmail.com>
6630 * class.cs (FixedField): Removed redundant volatile check.
6632 2007-10-15 Marek Safar <marek.safar@gmail.com>
6634 * class.cs, decl.cs: Fixed overload members verification to do only one
6635 check per possible collision.
6637 2007-10-13 Marek Safar <marek.safar@gmail.com>
6639 A fix for bug #325478
6640 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6641 and create only one disposable flags container.
6643 2007-10-12 Marek Safar <marek.safar@gmail.com>
6645 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6646 * statement.cs (Fixed): Fixed variables cloning.
6648 2007-10-12 Marek Safar <marek.safar@gmail.com>
6650 A fix for bug #333342
6651 * class.cs (EventField): Don't mark value type event as synchronized.
6653 2007-10-12 Marek Safar <marek.safar@gmail.com>
6655 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6656 inference to identify best candidate method correctly.
6657 (ProperyExpr): A range variable is read only and cannot be modified.
6659 2007-10-11 Marek Safar <marek.safar@gmail.com>
6661 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6662 logic to identify best candidate method correctly.
6664 2007-10-11 Marek Safar <marek.safar@gmail.com>
6666 * location.cs (Equals, GetHashCode): Removed.
6668 2007-10-11 Marek Safar <marek.safar@gmail.com>
6670 * report.cs: Implemented message recorder. It is used mainly for lambda
6671 expressions to capture otherwise swallowed error messages.
6673 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6675 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6677 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6679 * expression.cs (MemberAccess): Always report lookup failure.
6681 * location.cs: Implemented Equals, GetHashCode.
6683 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6685 2007-10-10 Jb Evain <jbevain@novell.com>
6687 * codegen.cs: re-enable assembly version check.
6689 2007-10-09 Marek Safar <marek.safar@gmail.com>
6691 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6694 * namespace.cs (UsingAlias): Do correct version check.
6696 2007-10-08 Marek Safar <marek.safar@gmail.com>
6698 * expresison.cs, ecore.cs: Issue extension method error message when
6701 * rootcontext.cs: Added ISO_2 compiler mode option.
6703 2007-10-08 Marek Safar <marek.safar@gmail.com>
6705 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6708 2007-10-08 Marek Safar <marek.safar@gmail.com>
6710 * attribute.cs (GetString, GetBoolean): Work with both literal and
6713 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6714 Moved method overload specific methods to MethodGroupExpr.
6716 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6717 it should be less memory consuming.
6719 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6721 * codegen.cs: remove the assembly version check until the buildbot is
6724 2007-10-07 Jb Evain <jbevain@novell.com>
6726 * attribute.cs (Attribute.GetString): if the value
6727 expression is a StringConstant, return its string value.
6729 2007-10-07 Jb Evain <jbevain@novell.com>
6731 * typemanager.cs: add `assembly_version_attribute_type`.
6732 * codegen.cs: on attribute emission, check that the
6733 AssemblyVersionAttribute doesn't overflow.
6735 2007-10-05 Marek Safar <marek.safar@gmail.com>
6737 A fix for bug #324677
6738 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6739 parent container of a scope container with currently resolved one.
6741 2007-10-05 Marek Safar <marek.safar@gmail.com>
6743 A fix for bug #325534
6744 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6747 2007-10-05 Marek Safar <marek.safar@gmail.com>
6749 A fix for bug #327504
6750 * class.cs (Operator.Define): Refactored implicit and explicit user
6751 operator conversion rules.
6753 2007-10-05 Marek Safar <marek.safar@gmail.com>
6755 A fix for bug #327520
6756 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6758 2007-10-04 Marek Safar <marek.safar@gmail.com>
6760 A fix for bug #328022
6761 * class.cs (MethodData.Define): Use correct method to check whether
6762 a method implementents an accessor.
6764 2007-10-04 Marek Safar <marek.safar@gmail.com>
6766 A fix for bug #330069
6767 * statement.cs (Fixed.Resolve): Read the first array element only when
6768 an array is instantiated.
6770 2007-10-04 Marek Safar <marek.safar@gmail.com>
6772 * expression.cs, assign.cs, generics.cs: Print correct operator when
6773 compound assignment is used.
6775 2007-10-04 Marek Safar <marek.safar@gmail.com>
6777 A fix for bug #325841
6778 * expression.cs (ArrayAccess): Use full argument cloning only for
6779 string compound concatenation.
6781 2007-10-03 Marek Safar <marek.safar@gmail.com>
6783 A fix for bug #328774
6784 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6786 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6789 2007-10-03 Raja R Harinath <rharinath@novell.com>
6792 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6793 Event accessibility checks here. Remove some bogus code that
6794 accidently made GenericMethods work.
6795 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6797 2007-09-25 Marek Safar <marek.safar@gmail.com>
6799 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6801 * statement.cs (Block): Refactored AddVariable to allow error handling
6804 * generic.cs: New stub.
6806 2007-09-23 Marek Safar <marek.safar@gmail.com>
6808 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6811 2007-09-17 Marek Safar <marek.safar@gmail.com>
6813 * class.cs: Use partial container to record whether any partial part
6814 contains static field initializer and therefore default contructor has
6817 2007-09-14 Marek Safar <marek.safar@gmail.com>
6819 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6820 mono-list when only one of two partial parts has defined accessibility
6823 2007-09-14 Marek Safar <marek.safar@gmail.com>
6825 A fix for bug #82845
6827 * class.cs (TypeContainer): Set correct resolve context for all field
6830 2007-09-13 Marek Safar <marek.safar@gmail.com>
6832 * assign.cs: Fixed a crash when field is resolved twice with an error.
6834 * codegen.cs: Changed InFieldInitializer to be flag.
6836 * anonymous.cs, ecore.cs, expression.cs: Update after
6837 IsInFieldInitializer rename.
6839 * const.cs: Removed unused parameter.
6841 * class.cs: Changed the way how we resolve and emit field initializers.
6842 The field initilizers have to have access to contructor block to emit
6843 compiler generated code.
6845 2007-09-13 Marek Safar <marek.safar@gmail.com>
6847 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6848 generics use TypeContainer instead.
6850 2007-09-12 Marek Safar <marek.safar@gmail.com>
6852 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6854 * lambda.cs (ResolveParameters): Use more powerful
6855 InflateGenericArgument.
6857 * parameters.cs: Better exception message.
6859 2007-09-10 Marek Safar <marek.safar@gmail.com>
6861 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6862 correct expression block type.
6864 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6866 * expression.cs (Invocation): Extracted method group resolve to
6869 2007-09-07 Marek Safar <marek.safar@gmail.com>
6871 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6872 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6874 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6875 generic extension methods.
6877 2007-09-06 Marek Safar <marek.safar@gmail.com>
6879 A fix for bug #82676 (Do I get it right now?)
6880 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6881 object before a standard conversion is applied.
6883 2007-09-06 Marek Safar <marek.safar@gmail.com>
6885 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6888 2007-09-05 Marek Safar <marek.safar@gmail.com>
6890 A fix for bug #82676
6891 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6892 non-generic interface types.
6894 2007-09-05 Marek Safar <marek.safar@gmail.com>
6896 A fix for bug #82690
6897 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6899 2007-09-05 Marek Safar <marek.safar@gmail.com>
6901 A fix for bug #82571
6902 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6903 modifier for container based methods.
6905 2007-09-05 Marek Safar <marek.safar@gmail.com>
6907 A fix for bug #82676
6908 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6909 any interface-type T means to any of interface type T.
6911 2007-09-04 Marek Safar <marek.safar@gmail.com>
6913 * namespace.cs: We have 2 versions of System.Core assembly.
6915 2007-09-04 Marek Safar <marek.safar@gmail.com>
6917 A fix for bug #82652
6918 * class.cs (Class.GetClassBases): Compare types and not expressions.
6920 2007-09-04 Marek Safar <marek.safar@gmail.com>
6922 A fix for bug #82620
6923 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6924 actually never worked before.
6925 (IndexerAccess): Emit prepared arguments before they are modified.
6927 2007-09-04 Marek Safar <marek.safar@gmail.com>
6929 A fix for bug #82563
6930 * assign.cs: Revert wrong fix.
6932 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6934 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6935 Instead of ldelema/stdind we have to use temporary variables to handle
6936 cases like String.Concat (params string[]).
6938 2007-08-31 Marek Safar <marek.safar@gmail.com>
6940 * class.cs: EmitAttributes to Emit rename.
6942 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6944 (MemberCore.HasClsCompliantAttribute): Don't depend on
6945 GetClsCompliantAttributeValue execution.
6947 2007-08-31 Marek Safar <marek.safar@gmail.com>
6949 * anonymous.cs: Use shorter type prefix.
6951 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6954 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6955 variables when probing is on.
6957 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6958 unresolved variables.
6959 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6960 handle transparent identifiers.
6962 2007-08-26 Marek Safar <marek.safar@gmail.com>
6964 * attribute.cs (IsClsCompliant): Add nullable types test.
6966 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6968 * doc.cs : catch other types of exception than XmlException to
6969 report CS1570. Fixed bug #82565.
6971 2007-08-23 Marek Safar <marek.safar@gmail.com>
6973 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6974 The number of delegate parameters has to match.
6975 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6978 2007-08-21 Marek Safar <marek.safar@gmail.com>
6980 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6981 to fix problem with private arguments.
6983 2007-08-20 Marek Safar <marek.safar@gmail.com>
6985 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6987 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6989 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6990 empty. Add cloning suport.
6992 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6994 2007-08-20 Marek Safar <marek.safar@gmail.com>
6996 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6997 to create EmptyCast. It handles EmptyConstantCast specialization for
7000 2007-08-18 Marek Safar <marek.safar@gmail.com>
7002 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7003 (EmitArrayArgument): One routine for array arguments.
7004 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7006 2007-08-17 Marek Safar <marek.safar@gmail.com>
7008 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7010 2007-08-17 Marek Safar <marek.safar@gmail.com>
7012 * anonymous.cs: MemberLookupFinal update.
7014 * class.cs (ConstructorInitializer): Is expression based.
7016 * delegate.cs: MethodGroupExpr update.
7018 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7020 (Error_MemberLookupFailed): Customizable error override.
7021 (MethodGroupExpr): Keep queried type for later usage.
7022 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7025 * expression.cs: Error_MemberLookupFailed refactoring.
7026 (New.DoResolve): Resolve as much as possible.
7027 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7028 customization for invalid member types.
7030 * statement.cs: MethodGroupExpr update.
7032 2007-08-16 Marek Safar <marek.safar@gmail.com>
7034 * modifier.cs (Check): Check all modifiers and not only accessibility
7037 2007-08-16 Marek Safar <marek.safar@gmail.com>
7039 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7040 type and not an expression.
7042 2007-08-16 Marek Safar <marek.safar@gmail.com>
7044 * statement.cs (Catch.Clone): Type and variable can be null.
7046 2007-08-16 Marek Safar <marek.safar@gmail.com>
7048 A fix for bug #81979
7049 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7050 I am really not sure whether this is the best fix.
7052 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7055 2007-08-14 Marek Safar <marek.safar@gmail.com>
7057 ** C# 3.0 Object and collection initializers (major re-write)
7059 * assign.cs (DoResolve): Initializers are not assign related.
7061 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7062 used during collection or object initialization.
7064 * expression.cs (Error_InvalidArguments): Add initializers specific
7065 messages. More will come later because it requires some general
7067 (New.DoResolve): Better error handling for unsafe types.
7068 (EmptyExpressionStatement): New class.
7069 (ElementInitializer): An object initializer expression.
7070 (CollectionElementInitializer): A collection initializer expression.
7071 (CollectionOrObjectInitializers): A block of object or collection
7073 (NewInitialize): New expression with element/object initializers.
7075 * statement.cs: Reverted object/collection initializer hacks.
7077 * typemanager.cs (CSharpName): Filter __arglist type.
7079 2007-08-09 Marek Safar <marek.safar@gmail.com>
7081 ** C# 3.0 Anonymous Types (update to the latest standard)
7083 * expression.cs (Binary.ResolveOperator): Threat all null based types
7085 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7086 (AnonymousTypeParameter): Updated.
7088 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7089 (AnonymousTypeClass): New anonymous type container.
7091 * class.cs (AddField): Return operation result.
7093 * generic.cs: Another empty TypeArguments overload.
7095 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7096 are stored at top of normal hierarchy.
7098 * typemanager.cs (CSharpName): Filter anonymous types.
7100 2007-08-09 Marek Safar <marek.safar@gmail.com>
7102 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7103 as single Concat call. How could we miss that :-(
7105 2007-08-08 Marek Safar <marek.safar@gmail.com>
7107 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7109 2007-08-07 Miguel de Icaza <miguel@novell.com>
7111 * expression.cs: Fix the previous commit, the creation of the
7112 arguments array list needs also to be conditional on the arguments
7115 * class.cs: Add a little bit of help to help narrow down problems.
7117 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7118 not try to copy in that case.
7120 * driver.cs: When building SMCS, include a new different set of
7121 default assemblies here. Do this here so we can control whether
7122 to include the default assemblies with /noconfig.
7124 2007-08-03 Marek Safar <marek.safar@gmail.com>
7126 A fix for bug #81979
7127 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7130 2007-08-03 Marek Safar <marek.safar@gmail.com>
7132 A fix for bug #82300
7134 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7135 we are in probing scope.
7137 2007-08-03 Marek Safar <marek.safar@gmail.com>
7139 A fix for bug #82301
7141 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7142 (Statement.CloneTo): Clone and not map children blocks.
7144 2007-08-03 Marek Safar <marek.safar@gmail.com>
7146 A fix for bug #82299
7148 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7151 * statement.cs (Statement.CloneTo): Clone variables before statements
7152 to allow remaping of local variables.
7154 2007-08-03 Marek Safar <marek.safar@gmail.com>
7156 A fix for bug #82296
7159 * report.cs: Log crash details for future clone problems.
7161 * statement.cs (Return.Clone): Don't clone non-existent expression.
7163 2007-08-03 Raja R Harinath <harinath@gmail.com>
7165 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7166 (Class.AddBasesForPart): Move CS0537 check here from ...
7167 * cs-parser.jay (class_declaration): ... here. Move calling of
7168 'AddBasesForPart' to ...
7169 (class_bases): ... here.
7170 (struct_declaration, interface_declaration): Update to changes.
7172 2007-08-02 Marek Safar <marek.safar@gmail.com>
7174 A fix for bug #81923
7176 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7177 conversion is allowed.
7179 2007-08-02 Marek Safar <marek.safar@gmail.com>
7181 A fix for bug #81564
7183 * ecore.cs (EventExpr): Add IsBase handling.
7185 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7188 2007-08-02 Raja R Harinath <harinath@gmail.com>
7190 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7191 * cs-parser.jay: Some whitespace cleanups.
7192 (current_delegate): New.
7194 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7195 a dummy code block, and use 'type_name' instead of 'member_name'.
7196 (interface_declaration, class_declaration): Likewise.
7197 (delegate_declaration): Likewise. Rearrange slightly and use
7199 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7200 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7202 2007-08-02 Marek Safar <marek.safar@gmail.com>
7204 A fix for bug #82039
7206 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7209 * typemanager.cs (CSharpName): Split to string overload.
7211 2007-08-02 Marek Safar <marek.safar@gmail.com>
7214 * report.cs: Updated warning CS0472.
7216 2007-08-01 Marek Safar <marek.safar@gmail.com>
7218 A fix for bug #82181
7220 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7222 2007-08-01 Marek Safar <marek.safar@gmail.com>
7224 A fix for bug #82277
7225 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7227 2007-08-01 Marek Safar <marek.safar@gmail.com>
7229 ** C# 3.0 Type Inference (major bits are working)
7231 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7232 (.ImplicitStandardConversionExists): Uses compatible.
7233 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7234 (.InferReturnType): New method.
7235 (.Compatible): Refactored.
7236 (.ResolveParameters): Uses factory to create resolved parameters.
7237 (.CompatibleMethod): Add probing mode support.
7238 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7239 clearly distinguish between 2 different operations.
7240 (LambdaMethod): Moved to lambda.cs.
7241 (AnonymousMethod): Removed unused fields and methods.
7242 (AnonymousDelegate): Simplified.
7244 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7246 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7248 * delegate.cs (Delegate): New mehods to reduce code duplication.
7249 (.GetConstructor): New method.
7250 (.GetInvokeMethod): New method.
7251 (DelegateCreation): Updated.
7253 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7255 (OverloadResolve): Made probing little bit faster.
7257 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7260 * generic.cs (TypeInferenceContext): Dummy implementation.
7262 * iterators.cs: Updated after Resolve/Define rename.
7264 * lambda.cs (LambdaExpression)
7265 (.ResolveParameters): Handles both type of arguments and type inference too.
7267 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7268 (InflateTypes): Updated.
7270 * support.cs (InflateTypes): Changed signature and updated.
7272 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7273 (MemberLookup_FindMembers): More MS tricks.
7274 (GetParameterData): Ditto.
7275 (GetDelegateParameters): Uses quick path for dynamic types.
7277 2007-08-01 Marek Safar <marek.safar@gmail.com>
7279 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7282 2007-07-31 Marek Safar <marek.safar@gmail.com>
7284 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7287 2007-07-26 Jb Evain <jbevain@novell.com>
7289 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7290 which takes a boolean 'report_errors', similar to the GetMethod.
7291 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7292 in .net 2.1, do not report errors here.
7294 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7295 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7296 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7299 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7300 of the type InternalsVisibleToAttribute before the first call
7301 to CoreLookupType which is allowed to fail (third boolean parameter
7302 to true). Because, during the resolution for a type that is not
7303 immediately found, we try to check if the type is not defined in
7304 a friend assembly, and to do so, we need the
7305 InternalVisibleToAttribute.
7307 2007-07-23 Miguel de Icaza <miguel@novell.com>
7309 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7310 feature that allows structs to be compared against null and inline
7311 the result as true or false.
7313 Notice that the same code is not permitted inside a generic block
7314 of code that would do:
7316 class Foo<T> where T : struct {
7323 It is only allowed if the type of T is not bound (no where
7324 clause). In my opinion, this CSC 2 behavior is broken but people
7325 seem to be using it (IronRuby does, a few bug reports on bugzilla
7326 have it and some people have complained about it).
7328 All of the users that depend on this behavior have code that is
7331 * report.cs (Warning, Error): make these take object arguments,
7332 not strings, as that allows us to take advantage of Format.
7334 2007-07-20 William Holmes <billholmes54@gmail.com>
7336 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7337 Left member variable for the Count.
7338 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7339 MemberName.CountTypeArguments to avoid a NRE.
7341 This code is contributed under the MIT X11 license
7343 2007-07-18 Marek Safar <marek.safar@gmail.com>
7345 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7347 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7349 * doc.cs : generic method arguments are written as ``x while generic
7350 type arguments are `x. Combined with the previous change, fixed bug
7353 2007-07-18 Raja R Harinath <rharinath@novell.com>
7356 * expression.cs (Binary.ResolveOperator): When converting
7357 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7359 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7361 * doc.cs : when T: or whatever x: is specified, it does not really
7362 check the doc comment's syntax correctness. Fixed bug #82006.
7364 2007-07-18 Marek Safar <marek.safar@gmail.com>
7366 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7367 LambdaExpression better.
7369 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7371 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7373 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7374 as it can be generated.
7376 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7379 * lambda.cs (LambdaExpression): Refactored to share same code with
7380 AnonymousMethodExpression.
7382 2007-07-17 Marek Safar <marek.safar@gmail.com>
7384 * anonymous.cs (MakeName): Include host name for easier debugging.
7385 (LambdaMethod): New class for lambda spcecific stuff.
7387 * attribute.cs: Set EmitContext return type.
7389 * class.cs: Set EmitContext return type.
7391 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7392 with null/void meaning.
7394 * iterators.cs (ContainerType): Implemented.
7396 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7398 * statement.cs (Return): Updated to lambda expressions.
7399 (Block.CloneTo): Parent can be null.
7401 2007-07-13 Marek Safar <marek.safar@gmail.com>
7403 A fix for bug #81917
7404 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7406 * class.cs (FixedField): Check whether field is in unsafe scope.
7408 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7409 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7411 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7414 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7416 2007-07-13 Marek Safar <marek.safar@gmail.com>
7418 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7419 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7422 2007-07-13 Marek Safar <marek.safar@gmail.com>
7424 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7426 2007-07-13 Marek Safar <marek.safar@gmail.com>
7428 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7429 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7431 * codegen.cs(EmitContext): Add ProbingMode flag.
7433 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7435 * driver.cs: For now set both warning values.
7437 * ecore.cs (SimpleName): Name is readonly.
7438 (MethodGroup.OverloadResolve): One quick path for probing.
7440 * expression.cs (Unary): Set Oper r/o.
7441 (Binary): Set Oper r/o.
7442 (ParameterReference): Set few instance variables as r/o.
7443 (ParameterReference.DoResolveBase): Don't capture aruments when
7445 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7446 (Arglist): arguments are private.
7447 (SizeOf): type is private and r/o.
7448 (MemberAccess): arguments are private.
7450 * report.cs: Enhanced reporting on/off capabilities.
7452 * lambda.cs: Uses ec.IsInProbingMode.
7453 (ContextualReturn): Derives from return.
7455 * rootcontext.cs: For now set both warning values.
7457 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7459 (Return.Resolve): Don't die immediately.
7460 (Block.Resolve): Speed-up probing.
7461 (Block.CloneTo): Clone only child blocks.
7463 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7465 * iterators.cs: reverted Miguel's latest change (r81925) as it
7466 breaks the build in System.
7468 2007-07-13 Miguel de Icaza <miguel@novell.com>
7470 * iterators.cs (Yield.CheckContext): Check for the iterator type
7471 also here as we can call into Yield even in codepaths that are not
7473 (MethodOrOperator is the only path that was checked).
7475 In addition to the standard check, use a more specific check for
7476 constructors to report a more verbose error.
7478 2007-07-12 Miguel de Icaza <miguel@novell.com>
7480 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7481 report the warning and continue
7483 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7484 values on the stack on the call to Emit. Use EmitStatement if
7485 possible, or using Emit + Pop if not possible. Fixes #82064
7487 2007-07-12 Raja R Harinath <rharinath@novell.com>
7489 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7490 avoid try...finally in some cases.
7492 2007-07-10 Marek Safar <marek.safar@gmail.com>
7494 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7496 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7497 instead of method. Re-use standard error handling.
7498 (ConstructorInitializer.Emit): Simplified.
7500 * delegate.cs: Updated after Invocation.EmitCall change.
7502 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7503 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7504 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7505 method and don't permanently changing input arguments.
7506 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7507 is resolved it has one of the candidates is the best one which is later
7508 used to emit. Removed a few unused method.
7509 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7511 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7512 (Binary.ResolveOperator): Ditto.
7513 (ConditionalLogicalOperator.DoResolve): Ditto.
7514 (Invocation): Uses method group.
7515 (Invocation.DoResolve): Simplified.
7516 (Invocation.EmitCall): Removed useless is_static.
7517 (Invocation.Emit): Delegate to method group.
7518 (Invocation.EmitStatement): Simplified.
7519 (New): Uses method group.
7520 (MemberAccess.DoResolve): Don't destroy original expression.
7522 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7524 2007-07-04 Marek Safar <marek.safar@gmail.com>
7526 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7529 * lambda.cs: Add custom error message type.
7531 2007-07-03 Marek Safar <marek.safar@gmail.com>
7533 * lambda.cs: Simplified little bit.
7535 * parameter.cs: Introduced ImplicitLambdaParameter.
7536 (Parameters.CreateFullyResolved): New factory instead of ctor.
7540 * delegate.cs: Updated parameter creation.
7542 2007-07-03 Marek Safar <marek.safar@gmail.com>
7544 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7547 * generic.cs: Synchronized with gmcs.
7549 2007-07-03 Marek Safar <marek.safar@gmail.com>
7551 * class.cs (Indexer): Check return type as soon as possible.
7553 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7556 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7558 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7560 * parameter.cs (Parameter): Use expression type when it is available.
7562 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7563 method modifier for the first parameter only.
7565 2007-06-24 Marek Safar <marek.safar@gmail.com>
7567 A fix for bug #81938
7568 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7570 * constant.cs: Tide up an exception message.
7572 2007-06-22 Marek Safar <marek.safar@gmail.com>
7574 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7575 an uninitialized variable is used.
7577 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7579 2007-06-22 Marek Safar <marek.safar@gmail.com>
7581 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7582 not found error handling.
7584 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7586 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7587 (ArrayCreation.DoResolve): Simplified.
7588 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7589 its own resolve process.
7590 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7592 2007-06-20 Marek Safar <marek.safar@gmail.com>
7594 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7597 2007-06-20 Marek Safar <marek.safar@gmail.com>
7599 * cs-tokenizer.cs: Removed var related stuff.
7601 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7602 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7603 a type and a keyword at same time.
7605 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7608 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7609 implicitly typed arrays, more changes will follow.
7611 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7613 2007-06-19 Marek Safar <marek.safar@gmail.com>
7615 * ecore.cs (VarExpr): Removed Handled field.
7617 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7618 build-in assign functionality.
7619 (ForEach.Resolve): Removed all implicitly typed local variable code and
7621 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7622 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7624 2007-06-18 Marek Safar <marek.safar@gmail.com>
7626 * assign.cs: Removed implicitly typed local variable check.
7628 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7629 referencing implicitly typed local variable.
7630 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7633 * statement.cs (Fixed): Removed unsupported implicitly typed local
7636 2007-06-15 Marek Safar <marek.safar@gmail.com>
7638 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7640 2007-06-14 Marek Safar <marek.safar@gmail.com>
7642 A fix for bugs #81855 and #76274
7643 * attribute.cs (AttachTo): Always set owner for global attributes to
7646 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7649 * cs-parser.jay: Assembly and module attributes must precede all other
7650 elements except using clauses and extern alias declarations.
7652 2007-06-13 Marek Safar <marek.safar@gmail.com>
7654 A fix for bug #81748
7656 * expression.cs: More checks for non ISO-1 features.
7658 2007-06-12 Marek Safar <marek.safar@gmail.com>
7660 A fix for bug #81807
7661 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7662 present inside switch statement and it is required by nullable check.
7664 2007-06-12 Marek Safar <marek.safar@gmail.com>
7666 A fix for bug #81840
7667 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7668 when type matching fails.
7670 * namespace.cs: Tiny error message change.
7672 2007-06-12 Marek Safar <marek.safar@gmail.com>
7674 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7675 reporting. Added automatic property check.
7677 * class.cs: Updated after CheckAbstractAndExtern relocation.
7678 (AEventPropertyAccessor.GetSignatureForError): Customized.
7680 2007-06-11 Marek Safar <marek.safar@gmail.com>
7682 * class.cs (DefineBaseTypes): Base type can be undefined.
7684 * ecore.cs (TypeLookup): Minor refactoring.
7685 (DoResolveAsTypeStep): Removed redundant check.
7687 * namespace.cs (Lookup): Removed redundant check.
7689 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7690 ResolveAsTypeTerminal step.
7691 (BootstrapCorlib_*): Simplified.
7692 (PopulateCoreType): Core types can be now external.
7694 2007-06-07 Marek Safar <marek.safar@gmail.com>
7696 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7698 (InferTypeArguments): Infers anonymous expression type arguments.
7699 (Compatible): Split to Compatible and InferTypeArguments.
7701 * lambda.cs: Updated.
7703 2007-06-08 Marek Safar <marek.safar@gmail.com>
7705 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7707 2007-06-07 Raja R Harinath <harinath@gmail.com>
7709 Fix #80477, cs0135-2.cs, cs0135-3.cs
7710 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7711 names to the "known" variables list.
7712 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7713 parameter names are also "known".
7714 (Block.CheckError136): Remove.
7715 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7718 2007-06-07 Marek Safar <marek.safar@gmail.com>
7720 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7722 2007-06-06 Marek Safar <marek.safar@gmail.com>
7724 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7725 internal error not an user error.
7727 * expression.cs (IsApplicable): Refactored to make debugging easier.
7729 * support.cs: More tricks for non-mono runtimes.
7731 * typemanager.cs (CoreLookupType): Made public.
7732 (InitSystemCore): All linq specific stuff moved to linq.cs
7734 2007-06-05 Marek Safar <marek.safar@gmail.com>
7736 * typemanager.cs (CSharpSignature): One more missing build-in types
7738 More tricks for non-mono runtime.
7740 2007-06-05 Raja R Harinath <harinath@gmail.com>
7742 * statement.cs (Block.CheckError136_InParents): Remove.
7743 (Block.AddVariable): Use GetParameterInfo instead.
7744 (ToplevelBlock.ProcessArguments): Likewise.
7746 2007-06-04 Raja R Harinath <rharinath@novell.com>
7748 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7750 (ToplevelBlock.GetParameterInfo): Split out of ...
7751 (ToplevelBlock.GetParameterRefernce): ... this.
7752 (ToplevelBlock.ParameterMap): Remove.
7753 * expression.cs (ParameterReference): Update to use
7754 ToplevelParameterInfo.
7756 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7759 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7760 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7762 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7763 (ToplevelBlock.ProcessParameters) ... here.
7764 (ToplevelBlock..ctor): Invoke it.
7766 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7769 * statement.cs (IKnownVariable): New interface.
7770 (LocalInfo): Implement it.
7771 (ToplevelParameterInfo): New class.
7772 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7773 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7774 GetKnownVariableInfo.
7776 2007-06-03 Raja R Harinath <harinath@gmail.com>
7778 Partly speed up CS0136 error checks.
7779 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7780 'recurse' parameter.
7781 (Block.DoCheckError136): Only check errors in parameters. Move
7782 local variable checks ...
7783 (Block.AddVariable): ... here, and ...
7784 (ToplevelBlock.ResolveMeta): ... here.
7786 2007-06-02 Raja R Harinath <harinath@gmail.com>
7788 * statement.cs (Block.IsChildOf): Remove.
7790 * statement.cs (Statement.Clone): Move special case code ...
7791 (Block.CloneTo): ... here.
7793 2007-05-29 Raja R Harinath <rharinath@novell.com>
7795 * statement.cs (ToplevelBlock.container): Remove field. It's
7796 redundant with 'Parent'.
7797 (ToplevelBlock.ContainerBlock): Remove accessor.
7798 (ToplevelBlock..ctor): Update to changes. Register anonymous
7799 child with parent here, ...
7800 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7802 (start_anonymous): Don't save current_block.
7803 (top_current_block): Remove.
7805 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7806 (Block.Resolve): Update to changes.
7807 (Block..ctor): Move setting of "correct" 'Toplevel'
7808 and 'Explicit' fields to ...
7809 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7811 2007-05-27 Raja R Harinath <harinath@gmail.com>
7814 * statement.cs (Block.Implicit): Remove.
7815 (Block): Update to changes.
7816 * flowanalysis.cs: Likewise.
7818 Mildly speed up CheckInvariantMeaningInBlock
7819 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7820 Recursively call AddKnownVariable to all enclosing blocks.
7821 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7822 Remove recursive calls.
7823 (Block): Update to changes.
7825 New ExplicitBlock invariants
7826 * statement.cs (Block.Explicit): New field. It points to the
7827 immediately enclosing non-implicit block.
7828 (Block..ctor): Maintain the invariant.
7829 * cs-parser.jay: Take advantage of invariant.
7831 Introduce ExplicitBlock
7832 * statement.cs (ExplicitBlock): New.
7833 (ToplevelBlock): Derive from it.
7834 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7836 (Block.Implicit): Update to changes.
7837 * cs-parser.jay: Update to changes.
7840 * codegen.cs (EmitContext.IsLastStatement): Remove.
7841 * statement.cs (Block.DoEmit): Update to changes.
7843 2007-05-25 Raja R Harinath <rharinath@novell.com>
7845 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7846 modifying current_block directly.
7848 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7850 * class.cs: Implemented automatic properties (C# 3.0)
7851 Thanks to Marek for the help.
7853 2007-05-23 Raja R Harinath <rharinath@novell.com>
7855 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7856 variable as assigned, note also that all its components are
7858 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7860 2007-05-19 Marek Safar <marek.safar@gmail.com>
7862 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7863 member is marked as compiler generated.
7865 * decl.cs (MemberCore): Refactored ModFlags into property.
7867 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7868 (Check): Check only accessibility modifiers.
7870 2007-05-18 Raja R Harinath <rharinath@novell.com>
7872 Track all assignable slots in one bit array
7873 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7874 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7875 logic from VariableMap constructor here. Use the same 'offset'
7876 variable that's later used for computing offsets of local
7878 * flowanalysis.cs (UsageVector.parameters): Remove.
7879 (UsageVector): Update to changes.
7880 (VariableMap): Remove.
7882 Avoid creating ParameterMap in every block
7883 * statement.cs (Block.ParameterMap): Move ...
7884 (ToplevelBlock.ParameterMap): ... here.
7885 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7887 * flowanalysis.cs (FlowBranching.param_map): Remove.
7888 (FlowBranching.UsageVector): Update to changes.
7889 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7891 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7893 * expression.cs (ParameterReference): Distinguish between block
7894 where parameter was referenced and declared.
7896 2007-05-18 Marek Safar <marek.safar@gmail.com>
7898 * flowanalysis.cs, statement.cs: Put back improved error handling.
7900 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7904 Imporved object and collection initialization (C# 3.0).
7906 2007-05-15 Marek Safar <marek.safar@gmail.com>
7908 A fix for bug #81380
7909 * expression.cs (Is.DoResolve): Only value types have constant `is'
7912 2007-05-15 Raja R Harinath <rharinath@novell.com>
7914 * statement.cs (ToplevelBlock.child): Remove.
7916 2007-05-15 Raja R Harinath <harinath@gmail.com>
7918 Rationalize ResolveMeta: refactoring
7919 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7920 out constant handling code into ...
7921 (Block.DoResolveConstants): ... this.
7923 Rationalize ResolveMeta: kill local_map
7924 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7925 (Block.AssignableSlots): New.
7926 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7927 for locals -- move code from VariableMap here. Avoid unnecessary
7929 * flowanalysis.cs (FlowBranching.local_map): Remove.
7930 (FlowBranching..ctor): Use Block.AssignableSlots.
7931 (VariableMap): Remove unused constructors.
7933 2007-05-11 Raja R Harinath <rharinath@novell.com>
7935 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7937 2007-05-11 Marek Safar <marek.safar@gmail.com>
7939 * typemanager.cs (IsFriendAssembly): Should not be called for building
7942 2007-05-09 Marek Safar <marek.safar@gmail.com>
7944 * literal.cs (NullConstant): Print null in all cases.
7946 * expression.cs (Binary.ResolveOperator): Implemented delegate
7947 comparison based on C# 2.0 changes.
7949 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7951 This code is contributed under the MIT X11 license
7953 The following enables support for several C# 3.0 language features:
7955 * cs-tokenizer.cs: Added support for the "var" keyword.
7957 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7958 Added VarExpr class to facilitate type inferencing.
7960 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7961 to support anonymous types.
7963 * assign.cs: Added support for type inferencing and initialization.
7965 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7967 * expression.cs: Added implicit array support to ArrayCreation.
7968 Added 5 types and 1 interface:
7970 IInitializable Implementing classes can inject initializing
7971 statements after object instantiation.
7973 Initializer Stores data for object initialization.
7975 AnonymousType An expression for anonymous types.
7977 AnonymousTypeParameter Stores data about an anonymous type's field.
7979 NewInitialize An expression for object initialization.
7981 CollectionInitialize An expression for collection initialization.
7983 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7986 2007-05-06 Marek Safar <marek.safar@gmail.com>
7988 A fix for bug #81500
7989 * cs-tokenizer.cs: Add special handling for coalescing operator.
7991 2007-05-06 Marek Safar <marek.safar@gmail.com>
7993 A fix for bug #81529
7994 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7995 its value from base class until it is redefined.
7997 2007-05-02 Raja R Harinath <rharinath@novell.com>
7999 Fix regression in cs0631-3.cs
8000 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8001 fallback. Make error fallback catch more cases.
8003 2007-05-01 Miguel de Icaza <miguel@novell.com>
8005 * cs-parser.jay: Allow parameters in operator declarations to have
8008 2007-04-27 Miguel de Icaza <miguel@novell.com>
8010 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8013 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8014 inside the ContextualReturn, it does not have to be an
8015 ExpressionStatement.
8017 2007-04-24 Miguel de Icaza <miguel@novell.com>
8019 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8022 2007-04-23 Miguel de Icaza <miguel@novell.com>
8024 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8025 method in two methods: ResolveNoDefine and Resolve.
8027 ResolveNoDefine will stop just after ResolveTopBlock has been
8030 Resolve will then continue by creating a method and issuing the
8031 call to method.Define ().
8033 (AnonymousMethod): Split and implement the new Resolve and
8034 ResolveNoDefine as well.
8036 * lambda.cs (LambdaExpression): Split the anonymous method
8037 resolution code into a separate routine (CoreCompatibilityTest)
8038 from DoCompatibleTest.
8040 (LambdaExpression.TryBuild): New method, this method tries to
8041 build the LambdaExpression with the given set of types to be used
8042 as the types for the various parameters of the lambda expression.
8044 If the compilation succeed with the given types, the infered type
8045 of the Anonymous method is returned, otherwise null is returned.
8047 2007-04-23 Marek Safar <marek.safar@gmail.com>
8049 A fix for bug #81414
8050 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8052 2007-04-22 Miguel de Icaza <miguel@novell.com>
8054 * cs-tokenizer.cs: Change various identifiers here from the
8055 camelCasing to the recommended Linux-like style for instance
8056 variables from the Coding Guidelines.
8058 2007-04-19 Martin Baulig <martin@ximian.com>
8061 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8062 System.Enum to System.ValueType.
8064 2007-04-13 Martin Baulig <martin@ximian.com>
8066 Rewrote implicit reference conversions. We need to distinguish
8067 between implicit reference conversions (13.1.4) and implicit
8068 boxing conversions (13.1.5).
8070 According to the spec, there's an an implicit conversion
8071 "From a one-dimensional array-type S[] to IList<T> and base
8072 interfaces of this interface, provided there is an implicit
8073 reference conversion from S to T." Note that this does not
8074 include boxing conversions.
8077 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8078 (Convert.ImplicitReferenceConversion): Split into
8079 ImplicitReferenceConversionCore() and
8080 ImplicitBoxingConversionExist().
8081 (Convert.ImplicitReferenceConversionExists): Use the new
8082 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8084 2007-04-12 Martin Baulig <martin@ximian.com>
8086 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8087 `TypeManager.null_type' checks up to the top of the method.
8089 2007-04-11 Marek Safar <marek.safar@gmail.com>
8091 A fix for bug #81350
8092 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8095 2007-04-11 Martin Baulig <martin@ximian.com>
8097 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8098 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8099 to make this work for generic classes; fixes #79561.
8101 2007-04-11 Martin Baulig <martin@ximian.com>
8103 * expression.cs (As): Add support for nullable types; fixes #79371.
8105 2007-04-11 Martin Baulig <martin@ximian.com>
8107 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8108 `type.FullName' is null; fixes #80243.
8110 2007-04-11 Martin Baulig <martin@ximian.com>
8112 * expression.cs (Invocation.IsApplicable): Don't modify the method
8113 if type inference succeeded, but the method was not applicable.
8116 2007-04-10 Marek Safar <marek.safar@gmail.com>
8118 A fix for bug #81324
8119 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8120 internal and external namespaces containers.
8122 2007-04-10 Martin Baulig <martin@ximian.com>
8124 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8125 TypeManager.DropGenericMethodArguments() so we also call
8126 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8128 2007-04-10 Martin Baulig <martin@ximian.com>
8130 * iterators.cs (Iterator.CreateIterator): Don't crash if
8131 `method.ReturnType' is null. This happens if something went wrong
8132 while resolving that typ (we already reported an error in this case).
8134 2007-04-10 Martin Baulig <martin@ximian.com>
8136 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8137 generic interfaces; report the CS0144 directly.
8139 2007-04-10 Martin Baulig <martin@ximian.com>
8141 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8142 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8144 2007-04-10 Martin Baulig <martin@ximian.com>
8146 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8148 2007-04-09 Raja R Harinath <rharinath@novell.com>
8151 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8152 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8155 * statement.cs (For.Resolve): If resolution fails, use
8158 2007-04-08 Marek Safar <marek.safar@gmail.com>
8160 * anonymous.cs (MakeName): Make faster and zero-based.
8161 (VerifyExplicitParameterCompatibility): Back to mode where generic
8162 parameter is ignored.
8163 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8165 * class.cs (EmitType): Method can emit another new method.
8167 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8169 * driver.cs: Updated.
8171 * lambda.cs: Reuse predefined empty parameters.
8173 * parameter.cs: Updated
8175 * support.cs: Implemented InflateTypes.
8177 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8178 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8180 2007-04-03 Martin Baulig <martin@ximian.com>
8184 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8185 version of TypeManager.IsOverride() which also works with generic
8188 2007-04-03 Martin Baulig <martin@ximian.com>
8193 (Convert.ExplicitReferenceConversion): We need to cast when
8194 converting from IList<T> to S[].
8196 2007-04-01 Marek Safar <marek.safar@gmail.com>
8198 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8201 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8203 2007-03-31 Marek Safar <marek.safar@gmail.com>
8205 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8206 argument and return type inferring.
8208 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8209 (ReturnType): Turned to property.
8211 * statement.cs (Return): Implemented return type inferring.
8213 * support.cs (ReflectionParameters): Use local types if possible.
8215 2007-03-30 Raja R Harinath <rharinath@novell.com>
8217 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8218 (FlowBranching.UsageVector): Update to changes.
8220 Prepare to kill 'Reachability'
8221 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8222 argument of constructor.
8224 2007-03-29 Raja R Harinath <rharinath@novell.com>
8226 Prepare to kill 'Reachability'
8227 * flowanalysis.cs (UsageVector.is_unreachable): New.
8228 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8229 'reachability', and verify they're consistent.
8232 * expression.cs (New.EmitStatement): Handle type parameters here too.
8234 2007-03-29 Martin Baulig <martin@ximian.com>
8239 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8240 CompilerGeneratedClass.
8241 (ScopeInfo.EmitScopeInstance): Make this protected.
8242 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8243 `ec.CurrentAnonymousMethod.Scope == Scope'.
8245 * statement.cs (Block.ScopeInfo): Make this a property.
8247 2007-03-27 Raja R Harinath <harinath@gmail.com>
8249 Prepare to kill 'Reachability'
8250 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8251 (FlowBranching.UsageVector.Reachability): Remove property.
8252 (FlowBranching.UsageVector.IsUnreachable): New property.
8253 (FlowBranching.UsageVector.ResetBarrier): New.
8254 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8255 * codegen.cs, statement.cs: Update to changes.
8257 2007-03-27 Martin Baulig <martin@ximian.com>
8262 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8265 2007-03-26 Raja R Harinath <rharinath@novell.com>
8267 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8268 instead of TriState. Remove all mention of TriState.
8270 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8271 replaced by a boolean. Add boolean 'is_unreachable' field, check
8272 and maintain invariants.
8274 2007-03-25 Marek Safar <marek.safar@gmail.com>
8276 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8278 2007-03-25 Marek Safar <marek.safar@gmail.com>
8280 * expression.cs: Stop using obsolete 2.0 opcodes.
8282 2007-03-25 Marek Safar <marek.safar@gmail.com>
8284 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8285 one of the latests Martin's fixes.
8287 2007-03-23 Miguel de Icaza <miguel@novell.com>
8289 * expression.cs: On BigEndian systems, swap the bytes, temporary
8290 solution until we get a new bitconverter class.
8292 2007-03-23 Martin Baulig <martin@ximian.com>
8296 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8297 "Method" and "Method`1". Normally, a cache lookup is done on the
8298 "Method" form (ie. without the generic arity), but this one makes
8299 lookups on the full form work as well.
8301 2007-03-22 Raja R Harinath <rharinath@novell.com>
8303 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8306 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8308 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8309 ordered_member_list, to TypeBuilder to store members to be defined
8310 in the order they were parsed in.
8311 - ordered_explicit_member_list contains all properties indexers
8312 and methods that are defined as explicit implementation of an
8313 interface or base class.
8314 - ordered_member_list contains all properties indexers and methods
8315 that are not defined as explicit implementation of an interface
8318 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8319 functionality in these removed classes has been replaced with
8320 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8321 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8323 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8324 to CheckForDuplications inside GetMethod and SetMethod Define Method
8325 to handle method property and indexer name conflicts.
8329 All code is contributed under the MIT/X11 license.
8331 2007-03-20 Martin Baulig <martin@ximian.com>
8333 * class.cs (TypeContainer.Interfaces): Removed; they're now
8334 included in `TypeContainer.Types'.
8336 2007-03-20 Martin Baulig <martin@ximian.com>
8338 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8340 * class.cs (TypeContainer.CreateType): New public method. This is
8341 now called before DefineType() to create the TypeBuilders.
8342 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8343 has already been created by CreateType().
8344 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8345 don't resolve our base classes here; this has been moved into
8346 DefineBaseTypes(). We're now called from CreateType().
8347 (TypeContainer.DefineBaseTypes): New private method; resolve our
8348 base classes here. We're now called from DefineType().
8351 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8352 our types first to create all the TypeBuilders. After that, call
8353 TypeContainer.DefineType() on all the types which'll resolve their
8354 base classes and setup the resolve order.
8356 2007-03-20 Martin Baulig <martin@ximian.com>
8358 * class.cs (TypeContainer.Enums): Removed; they're now included in
8359 `TypeContainer.Types'.
8361 2007-03-20 Martin Baulig <martin@ximian.com>
8364 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8365 (TypeContainer.DoResolveMembers): Call DefineType() on our
8366 `compiler_generated' classes; moved here from DefineNestedTypes().
8369 (RootContext.ResolveTree): Call ResolveMembers() on all
8370 TypeContainer's in the `type_container_resolve_order'.
8372 2007-03-19 Marek Safar <marek.safar@gmail.com>
8374 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8376 2007-03-17 Marek Safar <marek.safar@gmail.com>
8378 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8379 implementation flags.
8381 2007-03-17 Marek Safar <marek.safar@gmail.com>
8383 * class.cs: More optimizations for type parameters.
8385 2007-03-15 Marek Safar <marek.safar@gmail.com>
8387 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8389 * ecore.cs, parameter.cs: More common code for both corlibs.
8391 * typemanager.cs (IsGenericMethod): Simplified.
8393 2007-03-15 Raja R Harinath <rharinath@novell.com>
8395 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8397 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8399 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8400 unconditionally. Simplify explanation.
8401 (Try.Resolve, Using.Resolve): Likewise.
8403 2007-03-15 Martin Baulig <martin@ximian.com>
8407 * decl.cs (DeclSpace): If we're a partial class, use our
8408 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8410 2007-03-15 Raja R Harinath <rharinath@novell.com>
8412 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8414 (FlowBranching.UsageVector): Update to changes.
8415 (FlowBranching.MergeSiblings): Likewise.
8416 * statement.cs: Likewise.
8418 2007-03-15 Martin Baulig <martin@ximian.com>
8423 (MemberCache): Added a special .ctor for type parameters.
8426 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8429 2007-03-09 Martin Baulig <martin@ximian.com>
8431 * enum.cs (Enum): Make this a TypeContainer.
8432 (EnumMember): Derive from `Const'.
8435 (Const.DoResolveValue): New protected virtual method; move most of
8436 the functionality of ResolveValue() here so we can override it in
8438 (Const.CreateConstantReference): Make this virtual.
8440 * class.cs (Kind): Add `Kind.Enum'.
8441 (TypeContainer.Emit): Don't emit the enums here; they're already
8442 in the `RootContext.typecontainer_resolve_order'.
8444 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8445 here; they're already in the `typecontainer_resolve_order'.
8447 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8448 TypeManager.DropGenericTypeArguments().
8451 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8452 (TypeManager.IsEnumType): Likewise.
8453 (TypeManager.EnumToUnderlying): Likewise.
8454 (TypeManager.IsEqual): Add support for enums.
8456 2007-03-12 Raja R Harinath <rharinath@novell.com>
8458 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8459 DefaultParameterValueAttribute to be undefined, say if System.dll
8462 2007-03-11 Marek Safar <marek.safar@gmail.com>
8464 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8467 2007-03-10 Marek Safar <marek.safar@gmail.com>
8469 * class.cs, parameter.cs: Unified parameters verification.
8471 2007-03-08 Martin Baulig <martin@ximian.com>
8473 * cs-parser.jay (constructor_header): Pass the location to the
8474 newly created TopLevelBlock.
8476 2007-03-07 Martin Baulig <martin@ximian.com>
8478 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8480 2007-03-06 Miguel de Icaza <miguel@novell.com>
8482 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8483 with the changes from David, fixes the build.
8485 2007-03-05 David Mitchell <dmitchell@logos.com>
8487 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8488 and its base interfaces to a one-dimensional array type S[],
8489 provided there is an implicit or explicit reference conversion
8492 2007-03-03 Marek Safar <marek.safar@gmail.com>
8494 * cs-tokenizer.cs: Implemented basic linq grammar.
8496 * driver.cs: Set linq lang version on demand.
8498 2007-02-26 Marek Safar <marek.safar@gmail.com>
8500 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8502 2007-02-25 Marek Safar <marek.safar@gmail.com>
8504 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8507 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8509 Check property and event extern attributes.
8511 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8514 2007-02-24 Marek Safar <marek.safar@gmail.com>
8516 A fix for bug #80407
8517 * ecore.cs: Don't report ambiguity error when methods have same parent.
8519 2007-02-23 Marek Safar <marek.safar@gmail.com>
8521 A fix for bug #80878
8522 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8524 2007-02-22 Marek Safar <marek.safar@gmail.com>
8526 * attribute.cs: Enable ExtensionAttribute presence test.
8528 2007-02-22 Marek Safar <marek.safar@gmail.com>
8530 * class.cs: Warn about missing GetHashCode only when Equals is override.
8532 * decl.cs: Check accessibility of type arguments.
8534 * typemanager.cs: Correctly report nullable array.
8536 2007-02-20 Marek Safar <marek.safar@gmail.com>
8538 * class.cs, report.cs: Capture more details when things go wrong.
8540 2007-02-20 Marek Safar <marek.safar@gmail.com>
8542 A fix for bug #80650
8543 * cs-parser.jay: Anonymous container starts at constructor declaration
8544 and not at block beginning because it has to be usable in constructor
8547 * statement.cs: Use context location and not block one for error reporting.
8549 2007-02-18 Marek Safar <marek.safar@gmail.com>
8551 A fix for bug #78712
8552 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8555 2007-02-18 Marek Safar <marek.safar@gmail.com>
8557 A fix for bug #80493 by Atsushi Enomoto
8558 * cs-parser.jay: Ignore invalid attribute target.
8560 2007-02-18 Marek Safar <marek.safar@gmail.com>
8562 * cs-tokenizer.cs: Ignore '\0' as white space character.
8564 2007-02-17 Miguel de Icaza <miguel@novell.com>
8566 * cs-parser.jay: Add support for lambda expressions to the mcs
8569 * lambda.cs: Only clone when we are probing, not on the final call
8570 (Compatible is the final call).
8572 * statement.cs (CloneContext): Introduce class to provide block
8573 remapping during clone.
8575 All statements Clone themselves now.
8577 (Clone): special handling for blocks, when we clone a block, we
8578 register the block inside this routine, as children of the block
8579 might trigger a lookup.
8581 * expression.cs: Add support for CloneContext in all expressions.
8583 2007-02-17 Marek Safar <marek.safar@gmail.com>
8585 A fix for bug #80493
8586 * statement.cs: Report ambiguous warning when interfaces are not related.
8588 2007-02-15 Marek Safar <marek.safar@gmail.com>
8590 C# 3.0 extension methods.
8592 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8593 cannot be used directly.
8595 * class.cs (Class.Emit): Emit extension attribute if any class method
8596 is extension method.
8597 (Method.Define): Add basic extension method validation conditions.
8598 (Method.Emit): Emit extension attribute for method.
8600 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8601 extension method exists. Currently we follow same approach as Microsoft
8602 does, emit even if a method or a class are private but this can change
8605 * cs-parser.jay: Add handling of `this' keyword in method parameters
8608 * decl.cs (DeclSpace.IsStaticClass): New property.
8609 (MemberCache.FindExtensionMethods): Looks for extension methods with
8610 defined name and extension type.
8612 * doc.cs: Updated after OverloadResolve changes.
8614 * driver.cs: Add new soft reference to System.Core.dll.
8616 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8617 (ExtensionMethodGroupExpr): Represents group of extension methods.
8619 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8620 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8621 to MethodGroupExpr and made non-static for easier customization.
8622 (Invocation.DoResolve): Add extension method lookup when no standard
8624 (MemberAccess.DoResolve): Try extension methods if no member exists.
8626 * modifiers.cs: Add METHOD_EXTENSION modifier.
8628 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8629 as well as candidate extension type.
8630 (ComputeNamespaces): When assembly constains extension methods registers
8632 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8633 extension method lookup.
8634 (Namespace.LookupExtensionMethod): Looks for extension method in this
8636 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8637 find a method which matches name and extensionType.
8639 * parameter.cs (Parameter): Add This modifer.
8640 (HasExtensionMethodModifier): New property.
8641 (Resolve): Add extension parameter check.
8642 (ModFlags): turned to property to exclude this modifier as it is not real
8644 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8646 * support.cs (ParameterData): Add ExtensionMethodType.
8647 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8649 * typemanager.cs: Add type and ctor extension attribute type.
8651 2007-02-15 Miguel de Icaza <miguel@novell.com>
8653 * report.cs (DisableErrors, EnableErrors): used to prevent error
8654 output when we are "trying" to compile various methods with
8657 * ecore.cs (Expression): Add Clone method that calls the virtual
8658 CloneTo method. The current CloneTo method in Expression throws
8659 an exception so we can track down all the places where this must
8660 be implemented (not using abstract, because that would be a lot of
8661 up-front-work before we can start testing the implementation
8664 Important: we only need Clone capabilities for expressions created
8665 by the parser, as the expressions we will be cloning are
8666 expressions in the pre-resolved state. This vastly simplifies
8669 (SimpleName): Add CloneTo that does nothing.
8670 (EmptyCast): Add CloneTo.
8672 * expression.cs (Binary): Implement CloneTo.
8673 (Invocation.IsApplicable): Store the current ec in
8674 EmitContext.TempEc and restore it on return. This is used so we
8675 do not have to sprinkle hundres of methods with an extra
8676 EmitContext, we know that the only user is the lambda expression
8677 ImplicitConversionExists code.
8679 (Argument): Add Cloning capabilities.
8680 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8681 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8682 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8683 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8684 IndexerAccess): Add Clone capability.
8686 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8688 (Argument): Add cloning capability.
8690 * assign.cs (Assign): Implement CloneTo.
8692 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8694 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8695 version by calling Convert with the EmitContext (that we are
8696 currently storing in ec, this is not great, but will do for now,
8697 to avoid passing EmitContext parameters to hundreds of functions
8698 that do not need them now).
8700 (SetExpression): Remove, it is not needed.
8702 (ContextualReturn): Implement CloneTo.
8704 * statement.cs (Statement): Implement cloning infrastructure,
8705 similar to expressions.
8707 (Block): Partial implementation of Clone for statements.
8709 (Return): Implement clone.
8711 * constant.cs (Constant.CloneTo): New method, does nothing.
8713 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8714 solution, until we decide how to exactly do this.
8716 2007-02-14 Marek Safar <marek.safar@gmail.com>
8718 A fix for bug #80493
8719 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8720 a property is override we need to use second accessor.
8722 2007-02-13 Marek Safar <marek.safar@gmail.com>
8724 A fix for bug #80418
8725 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8728 2007-02-13 Marek Safar <marek.safar@gmail.com>
8730 Another fix for bug #80749
8731 * pending.cs: Abstract class has priority over interfaces.
8733 2007-02-13 Marek Safar <marek.safar@gmail.com>
8735 Another fix for bug #80749
8736 * pending.cs: Abstract class has priority over interfaces.
8738 2007-02-13 Marek Safar <marek.safar@gmail.com>
8740 Another fix for bug #80749
8741 * pending.cs: Abstract class has priority over interfaces.
8743 2007-02-13 Marek Safar <marek.safar@gmail.com>
8745 Another fix for bug #80749
8746 * pending.cs: Abstract class has priority over interfaces.
8748 2007-02-13 Marek Safar <marek.safar@gmail.com>
8750 * class.cs Better error message.
8752 * driver.cs: Add shorter versions of -optimize option.
8754 2007-02-13 Martin Baulig <martin@ximian.com>
8756 * class.cs (Constructor.Emit): Check the return value of
8757 ec.ResolveTopBlock() and return on error.
8759 2007-02-13 Raja R Harinath <rharinath@novell.com>
8761 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8762 message to fix error message regression.
8764 2007-02-12 Marek Safar <marek.safar@gmail.com>
8766 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8768 2007-02-12 Marek Safar <marek.safar@gmail.com>
8770 A fix for bug #80749
8771 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8772 its parent container.
8774 * class.cs (DefineFieldInitializers): Each initializer can has different
8777 * const.cs: Updated.
8779 2007-02-11 Miguel de Icaza <miguel@novell.com>
8781 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8782 now all the heavy lifting to check that embedded statements or
8783 expressions have the right form is done in the ContextualReturn.
8785 (ContextualReturn): New class.
8787 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8788 method that can be invoked to report 201, so we do not replicate
8791 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8793 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8794 treating tabs as spaces.
8796 2007-02-09 Marek Safar <marek.safar@gmail.com>
8798 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8799 * assign.cs: Use full implicit conversion for right side check.
8801 2007-02-09 Marek Safar <marek.safar@gmail.com>
8803 * statement.cs (Switch): Switch over boolean type is not standardized.
8805 2007-02-08 Marek Safar <marek.safar@gmail.com>
8807 A fix for bug #80755
8808 * decl.cs (FindBaseEvent): Don't use method cache for events.
8810 2007-02-07 Marek Safar <marek.safar@gmail.com>
8812 * cs-parser.jay: Better syntax error handling.
8814 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8815 instead of underlying type value.
8817 2007-02-06 Marek Safar <marek.safar@gmail.com>
8819 * driver.cs: Check define identifier before is registered.
8821 * namespace.cs: Use existing error message.
8823 * report.cs: New warning.
8825 2007-02-06 Marek Safar <marek.safar@gmail.com>
8827 A fix for bug #80742
8828 * expression.cs: Delegate Invoke method can be called directly.
8830 2007-02-06 Marek Safar <marek.safar@gmail.com>
8832 A fix for bug #80676
8833 * class.cs (IsEntryPoint): The Main method can have params modifier.
8835 2007-02-04 Miguel de Icaza <miguel@novell.com>
8837 * parameter.cs (Parameter, Parameters): Add Clone method.
8839 * anonymous.cs (Compatible): Turn method into virtual method, so
8840 LambdaExpression can implement a different behavior.
8842 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8843 out the basic checking here, so it can be used by
8846 * lambda.cs: Introduce "Compatible" function that will do the
8849 2007-02-02 Marek Safar <marek.safar@gmail.com>
8851 * attribute.cs: Unified one error message.
8853 * class.cs (Class): Use type attributes and not properties to test static
8855 (IsEntryPoint): Don's pass local variable.
8857 * convert.cs: Removed duplicate check.
8859 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8861 * driver.cs: Don't crash when soft reference does not exist.
8863 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8864 (UsingEntry): Removed redundant allocation.
8866 * parameter.cs: Add fast path for type parameters.
8868 * support.cs: Don't allocate attribute when it's not used.
8870 2007-01-30 Miguel de Icaza <miguel@novell.com>
8873 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8874 this into a virtual method, so we can override it in LambdaExpression.
8876 * driver.cs: Improve diagnostics in case of failure.
8878 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8879 write a function that is slightly more complex and that parses:
8881 type identifier [, type identifier]* )
8883 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8886 (canEmpty ? i >= 0 : i > 0)
8888 2007-01-30 Raja R Harinath <rharinath@novell.com>
8890 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8891 exception on possibly valid code.
8893 2007-01-29 Raja R Harinath <rharinath@novell.com>
8895 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8897 (parse_opt_type_arguments): Remove. It's almost the same as
8899 (parse_namespace_or_typename): Use parse_less_than.
8901 2007-01-28 Miguel de Icaza <miguel@novell.com>
8903 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8904 this bug took a few hours to find, because the state saved and
8905 restored by PushPosition and PopPosition was ignoring the state of
8906 parse_generic_less_than.
8908 I can also now remove the handling of OP_LT and OP_GT, this solves
8911 * cs-tokenizer.cs: store the location for the ARROW token, we use
8914 (PushPosition, PopPosition): save/restore also `current_token',
8915 restore `parse_generic_less_than' (was missing).
8917 (parse_opt_type_arguments): use parse_type, not
8918 parse_namespace_or_typename to parse types.
8920 * lambda.cs: Empty new file, will eventually have the lambda
8921 expression implementation.
8923 * lambda.test: used to test the internal tokenizer.
8925 * report.cs (FeatureIsNotISO1): Rename from
8926 FeatureIsNotStandardized, because it was about the language level
8927 (1 vs 2) it was not about standarization.
8929 (FeatureRequiresLINQ): New.
8931 * support.cs (SeekableStreamReader): Only require that the reader
8932 is a TextReader, not a StreamReader, so we can plug StringReader.
8934 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8935 given position in the input stream the following tokens can be
8936 parsed as a type followed by an identifier.
8938 (is_punct): after a '(' if parse_type_and_parameter returns true,
8939 then return a special token OPEN_PARENS_LAMBDA which is used to
8940 avoid reduce/reduce errors in the grammar for the
8941 lambda_expression rules.
8943 (parse_type): implement a type parser inside the
8944 tokenizer, the parser only returns true or false depending on
8945 whether the input at a given position can be parsed as a type.
8947 (peek_token): new method used during type parsing.
8949 2007-01-28 Raja R Harinath <rharinath@novell.com>
8952 * anonymous.cs (ScopeInfo.InflateParameters): New.
8953 (AnonymousContainer.Resolve): Use it to redirect types of
8954 delegate parameters.
8956 2007-01-27 Raja R Harinath <rharinath@novell.com>
8959 * expression.cs (Error_InvalidArguments): Don't use two different
8960 messages for CS1503. Use ExtraInformation and
8961 SymbolRelatedToPreviousError instead.
8964 * decl.cs (DeclSpace.initialize_type_params): Don't access
8965 'type_params' of a partial class directly.
8967 2007-01-26 Miguel de Icaza <miguel@novell.com>
8969 * constant.cs: Removed a handful of out-of-range checks that were
8972 2007-01-25 Marek Safar <marek.safar@gmail.com>
8974 * expression.cs (CheckUselessComparison): Add additional check for char
8977 * namespace.cs: Fixed typo.
8979 2007-01-23 Miguel de Icaza <miguel@novell.com>
8981 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8982 gone, instead we inline the test, preventing the needless casts to
8983 longs, ulongs and doubles for the parameters, avoiding calls to
8984 methods that overchecked stuff, and instead inlined things
8987 2007-01-20 Marek Safar <marek.safar@gmail.com>
8989 * cs-parser.jay: Better parameter error handling.
8991 2007-01-17 Marek Safar <marek.safar@gmail.com>
8993 A fix for bug #80368, #80522
8994 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8995 whether array initializer contains constants only.
8996 (ArrayCreation.Emit): Use better formula to decide when
8997 are array initializers for static initialization.
8998 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8999 have to emit even constants otherwise they are pre-initialized.
9001 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9002 Raja R Harinath <rharinath@novell.com>
9004 Fix emit order of 'get' vs. 'set'.
9005 * support.cs (Accessors): New.
9006 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9007 Note the order in which accessors are declared in the source.
9008 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9009 Refactored from Property.Define and Indexer.Define.
9010 (PropertyBase.DefineAccessors): New helper that calls the above in
9011 appropriate order as noted by the parser.
9012 (Property.Define, Indexer.Define): Update to changes.
9013 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9015 2007-01-17 Raja R Harinath <rharinath@novell.com>
9017 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9018 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9019 there's an implicit conversion from the current type to the target
9020 type before converting the underlying constant.
9022 2007-01-16 Marek Safar <marek.safar@gmail.com>
9024 * const.cs (ResolveValue): Updated after constant conversion was made more
9027 * constant.cs (GetAttributableValue): constant to object conversion is
9028 used for attributes only.
9029 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9030 constant conversions.
9031 (LongConstant.ConvertImplicitly): Ditto.
9033 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9034 (ImplicitConversionStandard): Handle constant conversion as extra step.
9035 It solves the issue when constant conversion was called indirectly like
9036 inside array initializer and constant folding was skipped.
9038 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9041 * statement.cs(ImplicitConversionStandard): Updated after constant
9042 conversion was made more generic.
9044 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9046 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9047 Constraints, solves the problem where the compiler incorrectly
9048 reported that a type parameter was not constrained to a class (Bug
9051 2007-01-14 Marek Habersack <grendello@gmail.com>
9053 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9055 2007-01-14 Marek Safar <marek.safar@gmail.com>
9057 A fix for bug #80368
9058 * assign.cs (FieldInitializer): New class implements field
9059 initializer statement.
9061 * attribute.cs: Update after FieldMember rename.
9063 * class.cs (PropertyBasedMember): New common class for property based
9065 (InterfaceMemberBase): New base class for all members which can be used as
9066 an interface members.
9067 (MethodCore): Moved really common code to InterfaceMemberBase.
9068 (Method.Define): Equal and GetHasCode detection is relevant for methods
9070 (MethodData.Define): Don't assume that public event implements an
9071 interface automatically.
9072 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9074 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9075 (FieldMember): Merged with FieldBase.
9076 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9077 event extern modifier can be used.
9078 (EventField.EventFieldAccessor): Moved event field specific code here.
9079 (Event.AllowedModifiers): Even event can be extern.
9080 (Event.FindOutBaseMethod): New override specific to events.
9081 (Indexer.parameters): Reintroduce parameters because base class holds
9082 only properties common data.
9083 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9084 need do extra parameters check.
9086 * const.cs: Update after FieldMember rename.
9088 * decl.cs (MemberCache.FindBaseEvent): New method.
9090 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9091 to reflect that indexer is now derived from PropertyBased.
9093 * ecore.cs (GetMemberType): Made public.
9094 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9097 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9099 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9100 (RegisterEvent): Removed.
9101 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9102 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9104 2007-01-11 Raja R Harinath <rharinath@novell.com>
9107 * statement.cs (CollectionForeach.TryType): Prefer generic
9108 GetEnumerator over non-generic variant. Fix code to follow comments.
9110 2007-01-09 Raja R Harinath <rharinath@novell.com>
9113 * support.cs (ReflectionParameter): Don't use an invalid index on
9114 the generic parameter data.
9116 2007-01-08 Miguel de Icaza <miguel@novell.com>
9118 * driver.cs: Just add a tiny bit of infrastructure.
9120 2007-01-02 Marek Safar <marek.safar@gmail.com>
9122 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9123 where field type is struct from current assembly.
9125 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9128 2007-01-02 Marek Safar <marek.safar@gmail.com>
9130 A fix for bug #80381
9131 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9134 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9136 (Namespace.LookupType): Always use core types from corlib when speficied.
9138 * report.cs: A new warning.
9140 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9141 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9142 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9144 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9145 (InitCoreTypes): Set expression type of object_type and value_type
9146 immediately after lookup.
9148 2007-01-01 Miguel de Icaza <miguel@novell.com>
9150 * cs-tokenizer.cs: Accept Pc class characters (Connector
9151 Punctuation) as valid identifiers. Fixes #78259
9153 * expression.cs (Invocation.DoResolve): Moved the check for the
9154 use of `this' for doing method calls to the Invocation resolution
9155 step, after overload resolution has taken place instead of doing
9156 the check at the low-level `This.DoResolve' level.
9158 The `This.DoResolve'(appens before overload resolution, so it has
9159 no way of knowing if the method that will be called will be
9160 instace or static, triggering an erroneous report for cs0188 (Bug
9163 We now do the check for instance method invocations after we know
9164 what method will be called.
9166 (This.CheckThisUsage): Move the actual use of this structure
9167 checking into its own method and expose it.
9169 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9172 Exceptions: Null.ConvertImplicitly,
9173 Constant.ImplicitConversionRequired as there are too many call
9174 sites for passing the ec.
9176 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9177 EmitContext, if the value is null, then we do not try to provide
9178 the extra information from the error (If a userdefined conversion
9179 exists, as UserDefinedConversion requires a non null-EmitContext).
9183 2006-12-30 Raja R Harinath <rharinath@novell.com>
9185 * flowanalysis.cs (MyBitVector): Document some invariants.
9186 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9187 introduced below, and add a couple of others,
9189 2006-12-30 Marek Safar <marek.safar@gmail.com>
9191 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9192 GetPropertyFromAccessor and GetEventFromAccessor.
9194 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9195 overrides non-obsolete one.
9196 (Indexer.Define): Error message has been moved to the parser.
9198 * cs-parser.jay: Better syntax errors handling.
9200 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9201 when an invocation has no arguments.
9203 * ecore.cs: Removed not used caching.
9205 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9208 * report.cs: Add a new warning.
9210 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9212 * typemanager.cs (enumeration_type): Removed.
9213 (CSharpSignature): Reuses IsSpecialMethod.
9214 (IsEqual): Hack for MS BCL.
9215 (GetPropertyFromAccessor): New method.
9216 (GetEventFromAccessor): New method.
9217 (IsSpecialMethod): Fixed to handle more cases.
9219 2006-12-30 Marek Safar <marek.safar@gmail.com>
9221 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9222 Made white spaces array static.
9224 * ecore.cs (RemoveGenericArity): Optimized.
9226 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9228 (MyBitVector.initialize_vector): Simplified.
9230 2006-12-22 Miguel de Icaza <miguel@novell.com>
9232 * ecore.cs: Am not entirely happy with this hack, but it seems to
9233 address the issue in 80257 (a small test case for
9236 I set the MethodGroupExpr.Type to an internal compiler type
9237 (itself in this case) to force the resolution to take place. Why
9238 it does not take place with a null is beyond me.
9240 2006-12-20 Marek Safar <marek.safar@gmail.com>
9242 A fix for bug #80288
9243 * expression.cs (ResolveOperator): Consider user defined conversion for
9244 logical and operator too.
9245 (EmitBranchable): Optimization for logical and when full constant folding
9246 could not be applied but one operand is constant.
9248 2006-12-19 Marek Safar <marek.safar@gmail.com>
9250 * class.cs (GetClassBases): Write 5 times every day, will never use
9251 FullName for error reporting.
9253 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9255 2006-12-19 Martin Baulig <martin@ximian.com>
9257 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9258 the symbol file info here.
9260 2006-12-18 Marek Safar <marek.safar@gmail.com>
9262 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9263 of `elseif' is taking then following sections are not taking.
9264 Fixes an issue reported on mono mailing list.
9266 2006-12-18 Marek Safar <marek.safar@gmail.com>
9268 A fix for bug #80300
9269 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9270 a caller is not taking.
9272 2006-12-18 Raja R Harinath <rharinath@novell.com>
9274 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9275 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9276 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9277 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9278 * class.cs: Update to changes.
9280 2006-12-17 Marek Safar <marek.safar@gmail.com>
9282 A fix for bug #79934
9283 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9286 * class.cs (ResolveMembers): Register an iterator in current container and
9289 2006-12-16 Raja R Harinath <rharinath@novell.com>
9292 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9293 satisfy a params annotated parameter.
9295 2006-12-16 Marek Safar <marek.safar@gmail.com>
9297 A fix for bug #77014
9298 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9299 paramters correctly and not rely on hacks in Parameters class.
9300 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9302 (Invocation.VerifyArgumentsCompat): Ditto.
9303 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9306 * parameter.cs (HasParams): Don't assume that params is the last one.
9308 * support.cs (ReflectionParameters.ctor): Look for params attribute
9310 (ReflectionParameters.ParameterType): Removed hack when we returned last
9311 parameter for out of range parameters.
9312 (ParameterName, ParameterModifier): Ditto.
9314 2006-12-14 Marek Safar <marek.safar@gmail.com>
9316 A fix for bug #79987
9317 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9318 when assembly is not CLS compliant but type is. I have no idea why is this
9321 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9323 2006-12-13 Miguel de Icaza <miguel@novell.com>
9325 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9326 in struct constructors, they are basically no-ops.
9328 2006-12-12 Marek Safar <marek.safar@gmail.com>
9330 * cs-tokenizer.cs (Position): Save preprocessor status too.
9332 2006-12-12 Marek Safar <marek.safar@gmail.com>
9334 A fix for bug #77794
9335 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9337 2006-12-12 Marek Safar <marek.safar@gmail.com>
9339 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9341 (pp_expr): Report error for an invalid expression.
9342 (handle_preprocessing_directive): Simplified; add more error checking.
9344 2006-12-11 Marek Safar <marek.safar@gmail.com>
9346 A fix for bug #74939
9347 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9348 directives handling.
9350 2006-12-10 Marek Safar <marek.safar@gmail.com>
9352 A fix for bugs #80093, and #75984
9353 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9354 logic, it seems to me as it worked before "by coincidence".
9355 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9356 (cleanup): Enabled endif check.
9358 2006-12-09 Marek Safar <marek.safar@gmail.com>
9360 A fix for bug #80162
9361 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9362 enumerators are never ambiguous.
9364 2006-12-08 Raja R Harinath <rharinath@novell.com>
9367 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9369 2006-12-06 Marek Safar <marek.safar@gmail.com>
9371 A fix for bug #80144
9372 * class.cs (EventProperty.Define): Explicit implementation means
9373 that an even is used.
9375 2006-12-06 Marek Safar <marek.safar@gmail.com>
9377 Fixes the operators implementation (part II)
9379 * cfold.cs (DoConstantNumericPromotions): Renamed to
9380 DoBinaryNumericPromotions and simplified.
9381 (BinaryFold): Couple of conversion fixes; simplified.
9383 * constant.cs, ecore.cs, literal.cs
9384 (ToType): Renamed to ConvertImplicitly.
9385 (Reduce): Renamed to ConvertExplicitly.
9387 * class.cs, convert.cs: Updated.
9389 * expression.cs: TryReduce doesn't throw an exception.
9391 2006-12-01 Marek Safar <marek.safar@gmail.com>
9393 A fix for bug #80108
9394 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9397 2006-11-30 Marek Safar <marek.safar@gmail.com>
9399 Fixes unary operators implementation (part I)
9402 * cfold.cs (Error_CompileTimeOverflow): Made internal
9404 * const.cs (IConstant): Changed to use reference to constant and
9405 not constant itself.
9406 Updated IConstant implementations.
9408 * constant.cs (CreateConstant): New factory method.
9409 Updated IConstant implementation.
9411 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9413 * ecore.cs: Updated to use CreateConstantReference.
9415 * enum.cs: Reflects IConstant changes.
9417 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9419 * literal.cs (NullConstant): Change to be independently usable.
9421 2006-11-29 Martin Baulig <martin@ximian.com>
9423 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9424 we need to emit the scope initializer before calling the base .ctor.
9426 * anonymous.cs: Merged back from the new anonymous methods branch.
9427 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9429 * expression.cs (ParameterReference.DoResolveBase): Create a
9430 "normal" ScopeInfo when capturing parameters rather than using the
9431 root scope; this makes things work with anonymous methods having
9435 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9437 2006-11-22 Marek Safar <marek.safar@gmail.com>
9439 A fix for bug #79987
9440 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9441 check to a base class.
9442 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9443 only when assembly has missing attribute.
9444 * report.cs: Update.
9446 2006-11-21 Marek Safar <marek.safar@gmail.com>
9448 * cs-tokenizer.cs: Merged with gmcs version.
9450 2006-11-20 Marek Safar <marek.safar@gmail.com>
9453 * cs-parser.jay: Better error message when partial keyword is misplaced.
9455 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9457 A fix for bug #79810
9458 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9459 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9460 a RuntimeWrappedException by default.
9462 2006-11-18 Marek Safar <marek.safar@gmail.com>
9464 A fix for bug #79843
9465 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9467 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9469 2006-11-18 Marek Safar <marek.safar@gmail.com>
9471 * driver.cs, namespace.cs: Uses faster IndexOf version.
9473 2006-11-17 Marek Safar <marek.safar@gmail.com>
9475 A fix for bug #79941
9476 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9478 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9479 even if internal name is different.
9480 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9481 (UserDefinedConversion): Simplified as the operators cannot be internal.
9482 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9484 (MethodLookup): Replaced EmitContext with parentType.
9485 * expression.cs: Updated.
9487 2006-11-09 Raja R Harinath <rharinath@novell.com>
9489 * driver.cs (BadAssembly): Handle all the ugliness of
9490 DefineDynamicAssembly.
9492 2006-11-08 Raja R Harinath <rharinath@novell.com>
9494 Address parts of #58244 -- most of what's left is in the runtime
9495 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9496 CS1509 error checks, and handle them for all assembly loads, not
9497 just the first invocation.
9498 (LoadModule): Likewise. Move handling of 'adder_method' ...
9499 * codegen.cs (AssemblyClass.AddModule): ... here.
9501 2006-11-02 Marek Safar <marek.safar@gmail.com>
9503 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9504 IEnumerable<T> is ambiguous.
9506 2006-10-31 Marek Safar <marek.safar@gmail.com>
9508 A fix for bug #67689
9509 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9510 GetEnumerator is ambiguous.
9512 * report.cs: Add new warning.
9514 2006-10-29 Marek Safar <marek.safar@gmail.com>
9516 A fix for bug #78602
9517 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9518 to protected member can be nested type.
9520 2006-10-28 Marek Safar <marek.safar@gmail.com>
9522 A fix for bug #78965
9523 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9524 to protected member must derive from current type.
9526 2006-10-27 Marek Safar <marek.safar@gmail.com>
9528 assign.cs: Reuses error method.
9530 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9531 instead of type for constants.
9532 (Expression.Error_ValueAssignment): Common error method.
9534 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9537 2006-10-27 Marek Safar <marek.safar@gmail.com>
9539 A fix for bug #79081
9540 * expression.cs (MemberAccess.DoResolve): Check nested type
9543 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9545 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9547 2006-10-26 Marek Safar <marek.safar@gmail.com>
9549 A fix for bug #76591
9550 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9552 2006-10-26 Marek Safar <marek.safar@gmail.com>
9554 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9555 type forwarder of the same type multiple times.
9557 2006-10-26 Raja R Harinath <rharinath@novell.com>
9560 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9561 instance as an rvalue, even when we later resolve as an lvalue.
9563 2006-10-25 Martin Baulig <martin@ximian.com>
9565 * anonymous.cs: Fix #79673.
9567 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9569 A fix for bug #79666
9570 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9571 ignored when is optimized (= default value) as its value is already set.
9573 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9575 A fix for bug #79724
9576 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9577 TypeContainer for type lookup.
9579 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9581 A fix for bug #79231
9582 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9583 * expression.cs (OverloadResolve): Always convert type name for
9585 (ResolveNamespaceOrType): Don't confuse a nested type with any
9588 2006-10-18 Martin Baulig <martin@ximian.com>
9590 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9592 2006-10-17 Miguel de Icaza <miguel@novell.com>
9594 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9595 an int32, but requesting an int64 from the conversion
9597 2006-10-12 Martin Baulig <martin@ximian.com>
9600 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9602 2006-10-12 Martin Baulig <martin@ximian.com>
9605 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9607 2006-10-11 Miguel de Icaza <miguel@novell.com>
9609 * convert.cs: Remove broken code: I was doing the "Existance"
9610 tests for Implicit conversions.
9612 2006-10-10 Miguel de Icaza <miguel@novell.com>
9614 * convert.cs: Added one missing case in
9615 ImplicitStandardConversionExists uint64 to intptr.
9619 * typemanager.cs (uintptr_type): another core known type.
9621 * ecore.cs (OperatorCast): routine used to do cast operations that
9622 depend on op_Explicit. We could change some of the Decimal
9623 conversions to use this.
9625 This one has a probe mechanism that checks both types for an op_
9626 which it coudl be used to eliminate two classes: CastToDecimal
9627 and CastFromDecimal.
9629 * convert.cs: Implement the conversions documented in #59800
9631 2006-10-10 Martin Baulig <martin@ximian.com>
9633 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9634 before RootScope.ResolveMembers().
9636 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9637 `CurrentType' if appropriate.
9639 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9641 A fix for bug #78568
9642 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9643 when contains binary operators.
9644 * cs-parser.jay: Updated.
9646 2006-10-09 Martin Baulig <martin@ximian.com>
9649 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9650 moved that into Define() and also do the other type parameter
9651 checks there. Fixes #79094. Added gtest-292.cs.
9654 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9655 since that doesn't include type parameters; don't use `Ldelema'
9656 for type parameters. Fixes #78980. Added gtest-293.cs.
9658 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9661 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9662 conversion is allowed.
9664 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9666 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9667 error reporting when no error occurs.
9669 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9671 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9674 2006-10-06 Raja R Harinath <rharinath@novell.com>
9677 * class.cs (DefineTypeBuilder): Check circular dependencies before
9678 setting the parent of the TypeBuilder.
9679 (CheckRecursiveDefinition): Don't use 'BaseType', since
9680 it may not be valid until after DefineTypeBuilder. Use
9681 'base_type' instead.
9683 2006-10-04 Martin Baulig <martin@ximian.com>
9685 Merged the Anonymous Methods patch.
9687 * anonymous.cs, iterators.cs: The new anonymous methods code.
9689 * statement.cs (Variable): New public abstract class.
9690 (LocalInfo.Variable): New public property.
9691 (LocalInfo.ResolveVariable): New public method.
9692 (Block.Flags): Add `IsIterator'.
9693 (Block.AddVariable): Improved the CS0136 check.
9694 (Block.AnonymousChildren): New public property.
9695 (Block.AddAnonymousChild): New public method.
9696 (ToplevelBlock): Update to use the new anonymous method framework.
9697 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9698 `ToplevelBlock'; this is required to correctly implement the
9700 (Fixed, Using): Use `TemporaryVariable' instead of directly
9701 creating the `LocalBuilder'.
9703 * parameter.cs (Parameter.ResolveVariable): New public method.
9704 (Parameters.ResolveVariable): Likewise.
9706 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9708 * class.cs (TypeContainer): Replaced the `iterators' list and
9709 corresponding methods with a list of `CompilerGeneratedClass'es.
9710 (TypeContainer.ResolveMembers): New public method.
9711 (Method): `IIteratorContainer' has been replaced by
9714 * expression.cs (VariableReference): New public abstract base
9715 class for `LocalVariableReference', `ParameterReference' and
9718 * codegen.cs (EmitContext): Removed `capture_context',
9719 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9720 (EmitContext.EmitThis): Removed.
9722 * cs-parser.jay: Replace `iterator_container' with
9725 2006-10-04 Martin Baulig <martin@ximian.com>
9727 * generic.cs (GenericMethod): Don't make this abstract.
9728 (Constraints.Clone): Added dummy implementation.
9730 2006-10-04 Raja R Harinath <harinath@gmail.com>
9733 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9734 'declspaces'. Avoid allocating arrays willy-nilly.
9737 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9738 cases out of the switch.
9740 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9742 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9743 message when non-generic type is used with the type arguments.
9744 * expression.cs: Updated.
9746 2006-09-28 Raja R Harinath <rharinath@novell.com>
9749 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9750 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9751 Change semantics slightly. Don't insist on having only one
9752 temporary EmptyExpression -- just throttle the creation of new ones.
9755 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9756 non-interfaces too. If no methods are found, don't try to create
9759 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9761 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9764 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9765 us produce better error message.
9767 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9769 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9770 of the `|' operator.
9772 * report.cs: A new warning added.
9774 2006-09-27 Martin Baulig <martin@ximian.com>
9776 * generic.cs (GenericMethod): Don't make this abstract.
9778 2006-09-27 Martin Baulig <martin@ximian.com>
9781 (InternalErrorException): Added overloaded ctor taking a params array.
9783 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9785 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9786 Fixed the cases when same error was reported twice.
9788 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9789 now report symbol information.
9791 2006-09-25 Martin Baulig <martin@ximian.com>
9793 * class.cs: Completely unified with the gmcs version.
9795 2006-09-25 Martin Baulig <martin@ximian.com>
9797 * typemanager.cs (TypeManager.IsNullableType): New public function.
9798 (TypeManager.IsNullableTypeOf): Likewise.
9799 (TypeManager.IsNullableValueType): Likewise.
9801 * class.cs (MethodCore): Added the `GenericMethod' argument from
9802 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9804 2006-09-24 Raja R Harinath <harinath@gmail.com>
9806 * convert.cs: Unify with gmcs version.
9808 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9810 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9811 verify them as well.
9813 * report.cs: New warning.
9815 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9817 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9818 for anonymous block with out argument.
9820 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9822 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9823 not used private events only.
9825 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9827 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9829 * const.cs (Const.Define): Check for constant type.
9830 (Const.IsConstantTypeValid): Looks for valid constant types.
9832 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9834 * ecore.cs (EmptyConstantCast): New common class for all constant based
9837 * expression.cs (Is.DoResolve): Handle null constant especially.
9838 (New.DoResolve): Check for new void().
9839 (MemberAccess.DoResolve): Cope with all kind of nulls.
9841 * literal.cs (NullConstant): Uses EmptyConstantCast.
9842 (NullDefault): Based on EmptyConstantCast.
9843 (NullLiteral): Uses EmptyConstantCast.
9845 * statement.cs (Block.ResolveMeta): Check for constant type.
9847 2006-09-22 Martin Baulig <martin@ximian.com>
9849 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9851 2006-09-22 Raja R Harinath <rharinath@novell.com>
9853 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9857 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9858 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9861 2006-09-22 Martin Baulig <martin@ximian.com>
9863 * ecore.cs: Merged with the gmcs version.
9865 * generic.cs (ConstructedType): New dummy class.
9866 (TypeArguments): Don't make this abstract.
9869 (TypeManager.IsGenericTypeDefinition): New method.
9870 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9872 2006-09-22 Raja R Harinath <rharinath@novell.com>
9874 * expression.cs (ComposedCast): Check for arrays of TypedReference
9875 before creating the type, not after.
9877 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9879 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9880 after ToType change.
9882 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9883 when constant must be implicitly convertible.
9885 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9887 * ecore.cs (NullCast): Derives from NullConstant.
9889 * expression.cs (Is.DoResolve): Removed useless variables.
9890 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9891 (New.Constantify): Add enum support.
9892 (MemberAccess.DoResolve): Add warning when accessing null constant or
9895 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9898 * literal.cs (NullConstant): New abstract class with common
9899 functionality for all null specializations.
9900 (NullDefault): Represents default(X) when result can be
9902 (NullLiteral): Updated.
9904 * report.cs: Add new warning.
9906 2006-09-21 Martin Baulig <martin@ximian.com>
9908 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9910 2006-09-21 Martin Baulig <martin@ximian.com>
9912 * generic.cs (GenericConstraints): New dummy class.
9913 (Constraints): Likewise.
9914 (TypeParameter): Likewise.
9915 (TypeParameterName): Likewise.
9916 (GenericMethod): Likewise.
9918 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9920 * decl.cs: Merged with the gmcs version.
9922 2006-09-21 Raja R Harinath <rharinath@novell.com>
9924 * generic.cs (TypeParameter): Implement IMemberContainer.
9925 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9927 * rootcontext.cs: Unify with gmcs version.
9929 * report.cs: Unify with gmcs version.
9930 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9931 from gmcs/generics.cs.
9932 * generics.cs (TypeParameter): New dummy class.
9934 * support.cs: Unify with gmcs version.
9936 2006-09-20 Raja R Harinath <rharinath@novell.com>
9938 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9939 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9941 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9942 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9943 * mcs.exe.sources: Add generic.cs.
9945 * codegen.cs: Unify with gmcs version.
9947 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9948 (EmitContext): Add GenericDeclContainer implementation.
9949 * decl.cs (MemberCore, DeclSpace): Likewise.
9950 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9952 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9953 MCS TypeManager has a corresponding dummy method.
9955 2006-09-19 Martin Baulig <martin@ximian.com>
9957 * expression.cs: Completely merged with the gmcs version.
9959 2006-09-19 Martin Baulig <martin@ximian.com>
9961 * expression.cs (Invocation): Merged with the gmcs version.
9962 (ArrayAccess.GetStoreOpcode): Likewise.
9964 2006-09-19 Martin Baulig <martin@ximian.com>
9967 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9968 (TypeManager.IsGenericMethodDefinition): Likewise.
9970 2006-09-19 Martin Baulig <martin@ximian.com>
9973 (TypeManager.IsEqual): Moved the gmcs implementation here.
9974 (TypeManager.DropGenericTypeArguments): Likewise.
9975 (TypeManager.DropGenericMethodArguments): Likewise.
9976 (TypeManager.GetTypeArguments): Moved here from gmcs.
9977 (TypeManager.HasGenericArguments): Likewise.
9979 2006-09-19 Martin Baulig <martin@ximian.com>
9981 * expression.cs (Binary): Merged with the gmcs version.
9983 2006-09-19 Martin Baulig <martin@ximian.com>
9985 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9987 2006-09-19 Martin Baulig <martin@ximian.com>
9989 * typemanager.cs: Merged with the gmcs version.
9991 2006-09-16 Raja R Harinath <rharinath@novell.com>
9993 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9994 * driver.cs: Likewise.
9996 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9999 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10000 only if parent type is class.
10001 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10004 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10007 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10009 * typemanager.cs(CSharpName): Converts NullType to null.
10011 2006-09-15 Martin Baulig <martin@ximian.com>
10014 (TypeManager.GetMethodName): Added mcs implementation.
10015 (TypeManager.IsEqual): Likewise.
10018 (SimpleName.RemoveGenericArity): Added dummy implementation.
10020 * pending.cs: Merged with the gmcs version.
10022 2006-09-15 Martin Baulig <martin@ximian.com>
10024 * statement.cs: Merge with the gmcs version.
10026 2006-09-15 Martin Baulig <martin@ximian.com>
10028 * statement.cs (Switch): Merge with the gmcs implementation
10029 (without nullables), which is newer.
10031 2006-09-15 Martin Baulig <martin@ximian.com>
10033 * statement.cs (Block.Variables): Make this public.
10034 (ToplevelBlock.Parameters): Make this a property.
10035 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10037 2006-09-15 Martin Baulig <martin@ximian.com>
10039 * namespace.cs: Merge with the gmcs version.
10041 2006-09-15 Martin Baulig <martin@ximian.com>
10043 * decl.cs (MemberName): Minor code cleanups.
10045 2006-09-15 Martin Baulig <martin@ximian.com>
10047 * parameter.cs: Merge with the gmcs version.
10049 2006-09-15 Martin Baulig <martin@ximian.com>
10051 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10052 and an error in mcs.
10054 2006-09-15 Martin Baulig <martin@ximian.com>
10056 * flowanalysis.cs: Merged from GMCS; added the generics code into
10057 a `GMCS_SOURCE' conditional so we can share this file.
10059 2006-09-08 Martin Baulig <martin@ximian.com>
10061 * typemanager.cs (TypeManager.interlocked_type): New public field.
10062 (TypeManager.int_interlocked_compare-exchange): New public field.
10063 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10064 enumerator types here and call InitGenericCoreTypes().
10065 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10066 after calling InitEnumUnderlyingTypes().
10069 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10070 `classes_second_stage'.
10072 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10074 * assign.cs, ecore.cs, expression.cs: Share error message text.
10075 * class.cs (FieldMember.Define): Check for varible of static type.
10076 * driver.cs (LoadAssembly): Uses error output for errors.
10077 * statement.cs: Updated.
10079 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10081 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10084 2006-09-07 Martin Baulig <martin@ximian.com>
10087 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10089 2006-08-29 Miguel de Icaza <miguel@novell.com>
10091 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10093 2006-08-17 Miguel de Icaza <miguel@novell.com>
10095 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10096 #52019 and #79064, the use of the \uXXXX sequence in source code
10097 to represent unicode characters.
10099 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10101 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10103 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10105 2006-08-13 Miguel de Icaza <miguel@novell.com>
10107 * assign.cs: Catch attempts to assign to a method groups in += and
10110 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10113 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10115 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10117 * class.cs (Method.Define): Issue a warning when generic method looks like
10119 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10122 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10124 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10126 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10127 search all base interfaces as a member can be ambiguous.
10128 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10129 Constructor member type filter.
10130 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10131 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10132 reporting for returned memberinfos.
10133 * report.cs: Updated.
10134 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10135 version to work on all runtimes.
10136 (TypeManager.RealMemberLookup): Removed members filtering.
10138 2006-08-08 Raja R Harinath <rharinath@novell.com>
10140 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10141 (PropertyExpr.EmitAssign): Likewise.
10142 * expression.cs (Indirection.EmitAssign): Likewise.
10143 (LocalVariableReference.EmitAssign): Likewise.
10144 (ParameterReference.EmitAssign): Likewise.
10145 (Invocation.EmitArguments): Likewise.
10146 (ArrayAccess.EmitAssign): Likewise.
10147 (IndexerAccess.EmitAssign): Likewise.
10148 (This.EmitAssign): Likewise.
10149 (ConditionalLogicalOperator.Emit): Likewise.
10152 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10153 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10154 leave it in after returning it.
10155 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10157 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10159 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10162 2006-08-03 Raja R Harinath <rharinath@novell.com>
10164 Fix cs0146-3.cs and cs0146-4.cs.
10165 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10166 enclosing types don't depend on the current type.
10168 2006-08-02 Raja R Harinath <rharinath@novell.com>
10171 * class.cs (TypeContainer.DoDefineMembers): Use
10172 FindBaseMemberWithSameName on Parent, since we're interested in
10173 whether we hide inherited members or not.
10174 (FindBaseMemberWithSameName): Make slightly more robust.
10176 Fix the non-generic testcase from #77396
10177 * decl.cs (DeclSpace.DeclContainer): Remove override.
10179 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10180 declspaces for doppelgangers too.
10181 (UsingEntry): Implement IResolveContext.
10182 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10183 'this' as the resolve context.
10184 (LocalAliasEntry): Likewise.
10186 Implement parts of #77403
10187 * roottypes.cs (RootDeclSpace): New. Used to represent the
10188 toplevel declaration space. Each namespace declaration introduces
10189 a "partial" root declaretion space.
10190 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10191 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10192 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10193 from 'current_namespace.SlaveDeclSpace'.
10194 (namespace_declaration): Likewise.
10195 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10196 check. It can't happen now.
10197 * decl.cs (DeclSpace.LookupType): Likewise.
10198 * driver.cs (MainDriver): Sanity check.
10200 2006-08-01 Raja R Harinath <rharinath@novell.com>
10202 * decl.cs (DeclSpace.FindNestedType): Remove.
10203 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10204 LookupTypeContainer to get the container of the nested type.
10205 * class.cs (TypeContainer.FindNestedType): Make non-override.
10207 2006-07-31 Raja R Harinath <rharinath@novell.com>
10209 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10210 * class.cs (TypeContainer.PartialContainer): ... here.
10211 (TypeContainer.AddBasesForPart): New helper.
10212 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10214 * cs-parser.jay (current_class): Convert to DeclSpace.
10215 (struct_declaration, interface_declaration, class_declaration):
10216 Use AddBasesForPart instead of .Bases directly.
10217 * const.cs, iterators.cs: Update to changes.
10219 2006-07-28 Raja R Harinath <rharinath@novell.com>
10221 * class.cs (TypeContainer.AddMemberType): Rename from
10222 AddToTypeContainer.
10223 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10224 (AddTypeContainer): New. Combine AddClassOrStruct and
10226 (AddPartial): Update. Add 'is_partial' argument.
10227 * roottypes.cs: Update to changes.
10228 * cs-parser.jay (push_current_class): New helper for handling
10229 current_container and current_class.
10230 (struct_declaration, interface_declaration, class_declaration):
10233 2006-07-26 Raja R Harinath <rharinath@novell.com>
10235 * roottypes.cs: Rename from tree.cs.
10237 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10238 * tree.cs (Tree, ITreeDump): Remove types.
10239 * rootcontext.cs (tree, Tree): Remove fields.
10240 (root, ToplevelTypes): New.
10241 * *.cs: Update to rename.
10243 * tree.cs (Tree.RecordDecl): Remove.
10244 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10246 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10248 2006-07-23 Raja R Harinath <harinath@gmail.com>
10250 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10251 DoFlowAnalysis and OmitStructFlowAnalysis here.
10252 (ec.With): Rename from WithUnsafe and generalize.
10253 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10254 (ec.WithFlowAnalyis): New.
10255 * ecore.cs, expression.cs, statement.cs: Update.
10257 2006-07-22 Raja R Harinath <harinath@gmail.com>
10259 * statement.cs (Block.ResolveMeta): Simplify slightly.
10261 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10262 multiple boolean fields. Convert InUnsafe, constant_check_state,
10263 check_state to flags.
10264 (CheckState, ConstantCheckState): Update.
10265 (InUnsafe): New read-only property.
10266 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10268 (WithUnsafe): New helper similar to WithCheckState.
10269 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10270 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10272 2006-07-21 Raja R Harinath <rharinath@novell.com>
10274 Make comparisons use the same IL irrespective of whether they're
10275 in a 'checked' or 'unchecked' context: one of the issues in #78899
10276 * codegen.cs (EmitContext.CheckState): Make read-only property.
10277 (EmitContext.ConstantCheckState): Likewise.
10278 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10279 helper that implement a save/restore stack for CheckState
10280 values. This is the only way to change check-state.
10281 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10282 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10283 (CheckedExpr.EmitBranchable): New forwarding method.
10284 (UnCheckedExpr): Likewise.
10285 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10286 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10287 (Checked.Resolve, checked.DoEmit): Likewise.
10289 2006-07-20 Miguel de Icaza <miguel@novell.com>
10291 * anonymous.cs: Cache the resolved anonymous delegate, and return
10292 this so that the ResolveTopBlock is only triggered once, not
10295 Currently we trigger ResolvetopBlock twice due to a first pass of
10296 argument check compatibility, and a second pass that does the
10299 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10301 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10303 * rootcontext.cs (Reset): Add helper_classes.
10305 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10308 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10311 2006-07-13 Miguel de Icaza <miguel@novell.com>
10313 * statement.cs (Lock): Handle expressions of type
10314 TypeManager.null_type specially. Fixes #78770
10316 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10318 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10321 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10323 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10324 for accessors as well.
10325 * ecore.cs (EventExpr): Add AccessorTable.
10327 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10330 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10331 for CS0122 where appropriate.
10332 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10334 (Filter): Assembly can be null in the case of top level attributes.
10336 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10340 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10341 is done at global level.
10343 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10345 A fix for #77002, Implemented TypeForwarder support.
10347 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10348 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10349 * typemanager.cs (): Add type_forwarder_attr_type.
10351 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10353 * report.cs: Add CS0469 warning.
10355 2006-06-21 Martin Baulig <martin@ximian.com>
10357 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10358 the `try'-block, so we also report CS0016 etc. there.
10360 2006-06-21 Martin Baulig <martin@ximian.com>
10363 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10365 2006-06-21 Martin Baulig <martin@ximian.com>
10367 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10368 also report CS1686 for parameters.
10370 2006-06-21 Martin Baulig <martin@ximian.com>
10372 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10373 instead of an error if the value is not implicitly convertible to
10374 the switch types; fixes #77964.
10376 2006-06-21 Raja R Harinath <rharinath@novell.com>
10379 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10380 FieldBuilder is null.
10383 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10384 'left' and 'right' before error-checking.
10386 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10388 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10390 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10391 (FieldExpr.DoResolve): likewise.
10392 (PropertyExpr.InstanceResolve): likewise.
10393 (EventExpr.InstanceResolve): likewise.
10395 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10397 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10398 attribute applicable tests for attribute argument.
10400 2006-06-02 Raja R Harinath <rharinath@novell.com>
10403 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10404 (Binary.OverloadResolve_PredefinedIntegral): New.
10405 (Binary.OverloadResolve_PredefinedFloating): New.
10406 (Binary.OverloadResolve_PredefinedString): New.
10407 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10408 Follow the standard more closely, and treat numeric promotions in
10409 terms of overload resolution.
10410 (Binary.CheckShiftArguments): Simplify.
10412 2006-06-01 Raja R Harinath <rharinath@novell.com>
10414 * flowanalysis.cs (MyBitVector): Simplify representation.
10415 (MyBitVector.Clone): Avoid allocating BitArray.
10416 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10417 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10418 (*): Update. Change all references to MyBitVector.And and
10419 MyBitVector.Or to &= and |=.
10421 2006-05-29 Raja R Harinath <rharinath@novell.com>
10423 Fix cs0231-[34].cs.
10424 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10425 to param arguments too.
10427 2006-05-26 Miguel de Icaza <miguel@novell.com>
10429 * cs-parser.jay: Catch another parsing form for arglist being
10430 followed by other arguments. Fixes #78313.
10432 2006-05-24 Raja R Harinath <rharinath@novell.com>
10434 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10435 checking of out parameters to ...
10436 (FlowBranchingToplevel.Merge): ... here.
10437 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10438 set, propagate the origin upward, and only complain if there was
10440 (FlowBranchingException.AddContinueOrigin): Likewise.
10441 (FlowBranchingException.AddReturnOrigin): Likewise.
10442 (FlowBranchingException.AddGotoOrigin): Likewise.
10444 2006-05-23 Raja R Harinath <rharinath@novell.com>
10446 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10447 unreachable, skip it.
10448 (FlowBranchingException.Merge): Always propagate jumps, even if
10449 the finally block renders subsequent code unreachable.
10451 2006-05-18 Raja R Harinath <rharinath@novell.com>
10454 * statement.cs (Goto.Resolve): Move responsibility for resolving
10455 'goto' to FlowBranching.AddGotoOrigin.
10456 (Goto.SetResolvedTarget): New. Callback to set the
10457 LabeledStatement that's the target of the goto.
10458 (Goto.DoEmit): Use Leave instead of Br when crossing an
10459 unwind-protect boundary.
10460 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10461 LookupLabel and adjust to new semantics.
10462 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10463 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10464 Goto.SetResolvedTarget to update target.
10465 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10466 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10467 AddBreakOrigin & co. Delay propagation until ...
10468 (FlowBranchingException.Merge): ... this.
10470 * statement.cs (Block.Resolve): Always depend on flow-branching to
10471 determine unreachability. Kill workaround that originally emitted
10472 only one statement after an "unreachable" label (see infloop in
10475 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10476 This is still "wrong", but anything better would probably need a
10477 multi-pass algorithm.
10478 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10479 usage vector. Force current usage vector to be reachable, to
10480 optimistically signify backward jumps.
10481 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10483 (FlowBranchingLabeled.Merge): New. If no backward jump was
10484 detected, return the original salted-away usage vector instead,
10485 updated with appropriate changes. Print unreachable warning if
10487 * statement.cs (Block.Resolve): Don't print unreachable warning on
10488 a labeled statement.
10490 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10492 * driver.cs: Pass filename without path to AssemblyBuilder's
10493 AddResourceFile. Fixes bug #78407.
10495 2006-05-17 Raja R Harinath <rharinath@novell.com>
10497 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10498 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10499 (FlowBranching.MergeChild): Overwrite
10500 reachability information from Labeled branchings too.
10502 2006-05-16 Raja R Harinath <rharinath@novell.com>
10504 * statement.cs (Goto.Resolve): Merge jump origins here ...
10505 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10507 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10508 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10509 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10510 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10512 * statement.cs (Goto.Resolve): ... not here.
10513 (Goto.Emit): Remove CS1632 check.
10515 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10517 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10520 2006-05-11 Raja R Harinath <rharinath@novell.com>
10522 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10523 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10524 (FlowBranchingException.Label): Likewise.
10526 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10528 (MyBitVector.Or): Use it to avoid losing information (Count).
10529 (FlowBranching.MergeOrigins): Likewise.
10531 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10532 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10533 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10534 (UsageVector.ToString): Simplify.
10535 (UsageVector.MergeSiblings): Move here from ...
10536 (FlowBranching.Merge): ... here.
10537 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10540 2006-05-10 Raja R Harinath <rharinath@novell.com>
10542 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10543 null bitvector is treated as all-true.
10545 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10546 (MyBitVector): Rationalize invariants. 'vector != null' implies
10547 that we have our own copy of the bitvector. Otherwise,
10548 'InheritsFrom == null' implies all inherited bits are true.
10550 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10552 * statement.cs (LocalInfo): Add IsConstant.
10553 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10554 local variable for constants.
10556 2006-05-09 Raja R Harinath <rharinath@novell.com>
10558 * flowanalysis.cs (MyBitVector.Empty): New.
10559 (MyBitVector): Don't allow InheritedFrom to be null.
10560 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10561 (UsageVector, FlowBranching): Update to changes.
10563 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10564 recursion. The 'Parent == null' condition isn't sufficient for
10566 (FlowBranching.AddBreakOrigin): Likewise.
10567 (FlowBranching.AddContinueOrigin): Likewise.
10568 (FlowBranching.AddReturnOrigin): Likewise.
10569 (FlowBranching.StealFinallyClauses): Likewise.
10570 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10571 (FlowBranching.CheckOutParameters): Likewise.
10572 (FlowBranchingToplevel): Terminate all the above recursions here.
10573 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10574 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10576 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10578 (FlowBranchingToplevel): New. Empty for now.
10579 (FlowBranching.MergeTopBlock): Update.
10580 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10581 branching for the anonymous delegate.
10582 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10584 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10585 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10586 information at the start of the merge. Reorganize.
10588 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10590 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10592 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10594 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10595 to newly introduced ctor.
10597 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10598 message to one place.
10599 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10602 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10604 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10606 * ecore.cs (Expression.ResolveAsConstant): Updated.
10608 * statement.cs (ResolveMeta): Updated.
10610 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10612 * cs-parser.jay: __arglist cannot be used in initializer.
10614 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10617 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10620 2006-05-05 Raja R Harinath <rharinath@novell.com>
10622 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10623 (LabeledStatement): Add 'name' parameter.
10624 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10625 (Block.AddLabel): Update to changes.
10626 * cs-parser.jay (labeled_statement): Likewise.
10628 * flowanalysis.cs (BranchingType.Labeled): New.
10629 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10630 (FlowBranchingLabeled): New. Does nothing for now, but will
10631 eventually handle 'goto' flows.
10632 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10633 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10634 that's terminated ...
10635 (Block.Resolve): ... here.
10637 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10638 (UsageVector.MergeFinallyOrigins): Likewise.
10639 (FlowBranching.InTryOrCatch): Likewise.
10640 (FlowBranching.AddFinallyVector): Likewise.
10641 (FlowBranchingException): Update to changes.
10644 * statement.cs (Return.Resolve): Move error checking to ...
10645 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10646 (FlowBranchingException): Handle return origins like break and
10648 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10650 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10653 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10656 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10659 * class.cs (MethodData.Define): Do public accessor check only when method
10660 implements an interface.
10662 2006-05-04 Raja R Harinath <rharinath@novell.com>
10664 Remove special handling of 'break'
10665 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10666 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10667 (UsageVector.Break): Remove.
10668 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10670 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10672 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10673 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10675 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10678 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10679 be the interface member.
10681 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10684 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10685 for emitting small (int) values.
10687 2006-05-03 Raja R Harinath <rharinath@novell.com>
10690 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10691 control-flow passes through the 'finally' after merging-in all the
10692 control-flows from 'try' and the 'catch' clauses.
10694 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10695 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10696 always true at the only non-recursive entry point.
10697 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10698 FlowBranchingBreakable.
10699 (FlowBranchingLoop): Remove.
10700 * statement.cs (Return.DoResolve): Update to changes.
10703 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10704 (FlowBranching.CreateBranching): Handle it: create a
10705 FlowBranchingContinuable.
10706 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10707 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10708 except that it handles the 'continue' command.
10709 (FlowBranching.UsageVector.MergeOrigins): Rename from
10711 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10712 except that it overrides AddContinueOrigin.
10713 (FlowBranchingException): Override AddContinueOrigin, similar to
10715 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10716 Create a new branching around the embedded statement.
10717 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10718 control flow after the embedded statement.
10719 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10721 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10722 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10723 FlowBranchingBreakable.
10724 (FlowBranchingSwitch): Remove.
10727 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10728 error reporting to ...
10729 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10730 Rename from 'AddBreakVector'. Add new location argument. Return
10731 a bool indicating whether the 'break' crosses an unwind-protect.
10732 (FlowBranchingException.AddBreakOrigin): Add.
10733 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10734 flowbranching after updating with the effects of the 'finally'
10736 (FlowBranchingBreakable): New common base class for
10737 FlowBranchingLoop and FlowBranchingSwitch.
10739 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10740 embedded statement.
10741 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10743 2006-05-02 Raja R Harinath <rharinath@novell.com>
10745 * statement.cs (Do.Resolve): If the loop is infinite, set the
10747 (While.Resolve, For.Resolve): Set a barrier after the embedded
10748 statement. There's no direct control flow that goes from the end
10749 of the embedded statement to the end of the loop.
10750 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10751 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10752 above ensure that the reachability is correctly computed.
10754 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10755 (UsageVector.MergeBreakOrigins): If the current path is
10756 unreachable, treat it as if all parameters/locals are initialized.
10757 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10758 infinite loops before merging-in break origins.
10760 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10761 (Reachability.Reachable): Split part into ...
10762 (Reachability.Unreachable): ... this. Simplify.
10763 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10765 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10766 (Reachability.SetThrowsSometimes): Likewise.
10767 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10768 TriState.Always, use corresponding property.
10769 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10770 (Block.Resolve): Likewise. Remove some redundant checks.
10772 2006-05-02 Raja R Harinath <harinath@gmail.com>
10774 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10775 (Reachability.Meet): Don't bother checking AlwaysThrows --
10776 barrier is always set.
10777 (FlowBranchingBlock.Merge): Likewise.
10779 2006-05-01 Raja R Harinath <harinath@gmail.com>
10781 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10782 checks for unreachable.
10784 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10787 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10789 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10790 whether field is really assigned.
10792 2006-04-30 Raja R Harinath <harinath@gmail.com>
10794 * flowanalysis.cs (Reachability): Make 4-argument constructor
10796 (Reachability.Meet): Rename from 'And'. Remove static variant.
10797 (Reachability.Always): Rename from the highly misleading
10798 'Reachability.Never'.
10799 (FlowBranching.Merge): Update to changes. Mark an impossible
10800 situation with a 'throw'.
10801 (*): Update to changes.
10803 2006-04-29 Raja R Harinath <harinath@gmail.com>
10805 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10806 Remove 'Undefined'.
10807 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10808 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10809 (*): Update to changes.
10810 * statement.cs: Update to changes.
10812 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10815 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10817 2006-04-28 Raja R Harinath <harinath@gmail.com>
10819 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10822 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10823 argument to two arguments: an usage-vector and a bool. Move call
10824 to FlowBranching.Merge () ...
10825 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10827 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10828 handling of loop and switch reachability to ...
10829 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10831 2006-04-27 Raja R Harinath <harinath@gmail.com>
10833 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10834 handling to FlowBranchingLoop.InLoop.
10835 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10837 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10840 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10841 anonymous method is allowed from AnonymousContainer here.
10843 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10845 2006-04-24 Raja R Harinath <rharinath@novell.com>
10848 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10850 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10853 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10854 (DoubleConstant.Reduce): Ditto.
10856 2006-04-23 Raja R Harinath <rharinath@novell.com>
10858 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10859 Remove 'lvalue_right_side' argument. Move parts to ...
10860 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10861 (LocalVariable.DoResolveLValue): ... these.
10863 2006-04-21 Raja R Harinath <rharinath@novell.com>
10866 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10867 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10868 (LocalVariableReference.DoResolveBase): Use it to implement new
10870 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10871 (Argument.Resolve): Simplify. Move CS1510 check ...
10872 * ecore.cs (Expression.ResolveLValue): ... here.
10873 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10874 (PropertyExpr.DoResolveLValue): Likewise.
10875 (FieldExpr.Report_AssignToReadonly): Likewise.
10876 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10877 LValueMemberAccess or LValueMemberOutAccess on instance depending
10879 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10880 DoResolve as appropriate.
10882 2006-04-20 Raja R Harinath <rharinath@novell.com>
10885 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10886 implicit conversions on 'out' and 'ref' arguments.
10888 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10889 improve clarity. Remove dead code.
10892 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10893 (Catch.Resolve): Resolve VarBlock if it exists.
10895 2006-04-19 Miguel de Icaza <miguel@novell.com>
10897 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10898 twice, this was some residual code, the enumerator was emitted
10899 properly in the two branche of if later.
10901 2006-04-19 Raja R Harinath <rharinath@novell.com>
10903 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10904 cast is never an lvalue.
10905 (Cast.DoResolve, Cast.ResolveRest): Combine.
10906 (Argument.Emit): Simplify slightly. Move 'Expr is
10907 IMemoryLocation' check ...
10908 (Argument.Resolve): ... here.
10909 (Argument.Error_LValueRequired): Remove. Inline into only user.
10911 Simplifications. Fix cs0191-2.cs
10912 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10913 CS1649 and CS1651 to ...
10914 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10915 the actual selection of the error code and message to a lookup
10916 table. Add a dummy return value to simplify callsites.
10917 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10918 readonly fields of other instances of the same type. Move CS0197
10920 * expression.cs (Argument.Resolve): ... here. Simplify code.
10921 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10922 resolution of an out or ref argument. The code simplification
10923 above uses this invariant.
10925 2006-04-18 Raja R Harinath <rharinath@novell.com>
10927 Possibly fix #77752. Fix cs1690-[4-7].cs.
10928 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10929 CheckMarshallByRefAccess. Drop parameter.
10930 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10932 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10933 InstanceExpression.
10934 * report.cs (AllWarnings): Add CS1690.
10935 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10936 for ref access too.
10937 (LocalVariableReference.DoResolveBase): Update.
10939 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10941 * class.cs (MethodOrOperator): Moved common parts from method class.
10942 detect obsolete attributes.
10943 (Method.Define): Simplified as it reuses code from base.
10944 (Constructor.ValidAttributeTargets): Fixed issue found during
10946 (Destructor.ValidAttributeTargets): Fixed issue found during
10948 (Operator): Finished refactoring set off by #78020. Operator class is now
10949 ordinary method class.
10951 * anonymous.cs: Updated.
10953 * decl.cs (DeclSpace): Add IsGeneric
10955 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10957 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10959 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10961 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10962 detect obsolete attributes.
10963 (Method.CreateEmitContext): Moved to MethodOrOperator.
10965 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10968 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10969 customized exception to make crash detection easier.
10970 (MethodOrOperator): Started to work on new base class for methods and
10972 (Method): Derives from MethodOrOperator.
10973 (Constructor.Emit): Emits its own attributes.
10974 (AbstractPropertyEventMethod.Emit): Ditto.
10975 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10977 (Operator.Emit): It's temporary more tricky than should be.
10979 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10981 * report.cs (InternalErrorException): Add ctor with inner exception.
10983 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10986 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10989 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10992 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10995 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10997 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10998 attribute is present and Guid not.
10999 (Interface.ApplyAttributeBuilder): Ditto.
11001 * attribute.cs: Add error message.
11003 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11007 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11008 sources (it's composite) so hold them in extra array as they are used in
11009 Emit phase only. It worked in the previous versions by mistake.
11010 (Attribute.Emit): Emit attribute for more owners when exist.
11012 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11013 it has now different behaviour.
11015 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11017 * constant.cs (Constant.IsDefaultInitializer): New method.
11019 * class.cs: Updated.
11021 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11022 re-initialize default values. It saves KBs almost for every assembly.
11023 Thanks Zoltan for the idea.
11024 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11025 (ArrayCreation.DoResolve): Resolve only once.
11026 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11027 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11029 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11031 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11034 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11036 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11037 in an embedded statement too.
11039 2006-04-01 Raja R Harinath <rharinath@novell.com>
11042 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11044 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11048 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11051 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11053 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11055 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11058 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11059 LocalTemporary change.
11061 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11063 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11064 initializers optimization.
11065 (ClassOrStruct.TypeAttr): Moved from modifiers.
11066 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11067 (FieldBase.ResolveInitializer): Resolves initializer.
11068 (FieldBase.HasDefaultInitializer): New property.
11070 * cs-parser.jay: Removed message.
11072 * expression.cs (CompilerGeneratedThis): New specialization.
11074 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11076 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11078 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11080 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11082 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11083 be now EnumConstants only.
11085 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11087 * attribute.cs, driver.cs: Reset more caches.
11089 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11091 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11093 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11095 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11096 for easier reuse. Updated all overrides.
11097 (IntegralConstant): New base class for all integral constants.
11098 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11099 of the constant range, report custom error.
11100 (UIntConstant.Reduce): Fixed uint conversion.
11102 * ecore.cs, literal.cs: Reduce updates.
11104 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11108 * class.cs (Constructor.Define): Removed extra if for default ctors.
11109 A patch from Atsushi Enomoto.
11111 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11113 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11114 GetAttributableValue.
11116 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11119 * convert.cs (ImplicitConversionRequired): Error message moved to
11122 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11123 automatic implicit conversion of an output value.
11124 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11126 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11128 (TypeOf.GetAttributableValue): Add extra handling for object type.
11130 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11131 special error message.
11133 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11135 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11137 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11138 compatible with MS runtime.
11140 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11142 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11143 attribute arguments here.
11145 * class.cs (Indexer.Define): The check was moved to attribute class.
11147 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11149 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11150 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11153 2006-03-22 Raja R Harinath <rharinath@novell.com>
11155 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11156 mcs to keep code differences small.
11157 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11158 * typemanager.cs (parameter_default_value_attribute_type): New.
11159 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11162 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11164 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11166 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11168 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11170 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11173 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11175 * doc-bootstrap.cs : fix build.
11177 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11179 * expression.cs (StringConcat.Append): Issue a warning when empty string
11180 is going to append.
11182 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11184 * assign.cs (CompoundAssign.ResolveSource): Removed.
11186 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11189 * class.cs (TypeContainer.FindMethods): Removed.
11190 (TypeContainer.CheckMemberUsage): Made static.
11192 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11194 * constant.cs (CheckRange): Removed unused type argument.
11195 (CheckUnsigned): Removed unused type argument.
11197 * cs-parser.jay: Updated after MemberAccess clean up.
11198 Uses Length for empty string test.
11200 * cs-tokenizer.cs: Uses Length for empty string test.
11201 (IsCastToken): Made static.
11202 (is_hex): Made static.
11203 (real_type_suffix): Made static.
11205 * decl.cs (SetupCache): Made static.
11206 (OnGenerateDocComment): Removed unused ds argument.
11208 * delegate.cs (VerifyDelegate): Removed unused argument.
11210 * doc.cs: Uses Length for empty string test.
11212 * driver.cs: Uses Length for empty string test.
11214 * enum.cs (IsValidEnumType): Made static
11216 * expression.cs (EnumLiftUp): Removed unused argument.
11217 (ResolveMethodGroup): Ditto.
11218 (BetterConversion): Ditto.
11219 (GetVarargsTypes): Ditto.
11220 (UpdateIndices): Ditto.
11221 (ValidateInitializers): Ditto.
11222 (MemberAccess.ctor): Ditto.
11223 (GetIndexersForType): Ditto.
11225 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11227 * iterators.cs: Updated after MemberAccess clean up.
11229 * location.cs: Uses Length for empty string test.
11231 * namespace.cs: Uses Length for empty string test.
11233 * report.cs (CheckWarningCode): Made static.
11235 * statement.cs (LabeledStatement): Removed unused argument.
11237 * typemanager.cs (FilterNone): Removed.
11239 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11241 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11244 * class.cs: Updated.
11246 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11248 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11250 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11254 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11255 reporting, it's more tricky than I thought.
11257 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11261 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11263 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11264 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11265 Add more error reporting; Fixed issue with params.
11267 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11269 * cs-parser.jay: AnonymousMethod requires host container.
11271 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11273 2006-03-18 Raja R Harinath <harinath@gmail.com>
11275 * class.cs: Change 'TypeContainer ds' constructor argument to
11276 'DeclSpace parent'. Some classes were missed below due to
11277 different naming convention.
11279 * class.cs (MemberCore.Parent): Delete. This makes the
11280 ParentContainer changes below enforceable by the compiler.
11282 Treat pointers to enclosing declaration space as 'DeclSpace', not
11284 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11285 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11287 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11289 (Block.AddThisVariable): Likewise.
11290 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11291 (AbstractPropertyEventMethod.Emit): Likewise.
11292 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11293 (GetMethod.Define, SetMethod.Define): Likewise.
11294 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11295 (DelegateMethod.EmitMethod): Likewise.
11297 Fix regression test-partial-13.cs.
11298 Rationalize use of PartialContainer. Ensure that the partial
11299 class semantics can be tied to type-correctness, i.e., any
11300 violation will cause a compile error.
11301 * class.cs, const.cs: Access all fields that belong to class
11302 TypeContainer via ParentContainer. Arguments of EmitContexts and
11303 Resolve()-like functions still use 'Parent'.
11305 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11306 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11307 (PropertyMethod.CheckModifiers): Remove unused argument.
11308 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11311 2006-03-17 Raja R Harinath <harinath@gmail.com>
11313 Make semantics of PartialContainer simpler.
11314 * decl.cs (DeclSpace.IsPartial): Remove.
11315 * class.cs (TypeContainer.IsPartial): Likewise.
11316 (TypeContainer..ctor): Set PartialContainer to point to self.
11317 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11318 (TypeContainer.FindNestedType): Likewise.
11319 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11321 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11323 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11325 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11327 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11330 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11332 * class.cs (Operator.Define): An error for base conversion was not
11333 reported correctly.
11335 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11337 * iterator.cs : yield break is allowed in try statement which has
11338 catch clauses. Fixed bug #77767.
11340 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11342 A fix for #77593, #77574.
11344 * class.cs (MethodCore.CheckBase): Another if for operator.
11346 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11348 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11351 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11352 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11355 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11358 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11359 Updated after another emitcontext usage was clean up. It should help us to
11360 synchronize with gmcs easier.
11362 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11366 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11367 (Event.Define): ditto
11368 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11370 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11371 Removed redundant code and set NewSlot for Invoke method too.
11373 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11374 (Parameters.MergeGenerated): New method. Use this method when you merge
11375 compiler generated argument with user arguments.
11377 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11379 * attribute.cs (ResolveAsTypeTerminal): Removed.
11381 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11382 specialization for predefined types; 30% speed up.
11383 Finally placed obsolete check to right place.
11384 (Expression.ResolveType): Removed.
11386 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11387 Updated after ResolveType was removed.
11389 * expression.cs (Cast.ctor): Check void cast.
11390 (Binary.ResolveAsTypeTerminal): Is never type.
11391 (Conditional.ResolveAsTypeTerminal): Is never type.
11393 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11395 2006-03-01 Raja R Harinath <rharinath@novell.com>
11398 * expression.cs (ParameterReference.DoResolveBase): Change return
11400 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11404 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11407 * typemanager.cs (GetFullNameSignature): Don't nullref on
11408 protected accessors.
11410 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11412 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11413 these two separated members to simplify the code.
11414 (Attribute.Resolve): Refactored to use new fields and methods.
11415 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11416 implemented obsolete attribute checking.
11417 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11418 implemented obsolete checking again. It look line never ending quest ;-)
11419 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11421 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11423 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11425 *class.cs (Property.Define): Add RegisterProperty call.
11427 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11428 argument groups (only 2).
11430 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11431 encoding expression to arguments.
11432 (Expression.ExprClassToResolveFlags): Just turned to property.
11434 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11435 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11436 optimized as well as implemented support for zero-length attributes.
11438 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11439 Add caching of PropertyInfo's.
11441 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11443 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11444 error multiple times.
11446 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11448 New partial class implementation.
11449 A fix for #77027, #77029, #77403
11451 * attribute.cs (Attributable): Made attributes protected.
11453 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11454 the replacements of ClassPart and PartialContainer.
11455 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11456 (TypeContainer.AddInterface): Ditto.
11457 (TypeContainer.AddPartial): The main method for partial classes. It checks
11458 for errors and merges ModFlags and attributes. At the end class is added to
11459 partial_parts list.
11460 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11462 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11463 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11464 from the rest of partial classes.
11465 (TypeContainer.GetClassBases): Simplified.
11466 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11468 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11469 (TypeContainer.HasExplicitLayout): Uses Flags now.
11470 (PartialContainer): Removed.
11471 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11472 (StaticClass): Was merged with Class.
11473 (Class.GetClassBases): class and static class bases are verified here.
11474 (Class.TypeAttr): Added static attributes when class is static.
11475 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11476 (MemberBase): In some cases we need to call parent container for partial
11477 class. It should be eliminated but it's not easy now.
11479 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11481 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11482 partial classed to accumulate class comments.
11483 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11485 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11487 * driver.cs (MainDriver): Tree.GetDecl was removed.
11489 * modifiers.cs (Modifiers): Add partial modifier.
11491 * tree.cs (Tree.decl): Removed.
11492 (RootTypes): Started to use this class more often for root types
11495 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11499 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11500 external interface does not have an attribute.
11502 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11504 Another prerequisites for new partial classs implementation.
11506 * attribute.cs (Attribute.Equal): Implemented.
11507 (Attribute.Emit): Changed as attributes can be applied more than twice.
11508 (Attributes.Emit): Check for duplicate attributes here.
11510 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11511 as a parameter, clean-up.
11513 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11517 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11518 contains obsolete attribute check which can in some cases look for base
11519 type of current class which is not initialized yet.
11520 (TypeContainer.BaseType): Replacement of ptype.
11522 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11524 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11526 First of prerequisites for new partial classs implemention.
11528 * attribute.cs (Attributable): Extended by ResolveContext;
11529 Attributes finally have correct context for resolving in all cases.
11530 (AttachTo): Attribute owner is assigned here.
11532 * codegen.cs (IResolveContext): Introduce new interface to hold
11533 all information needed in resolving phase.
11534 (EmitContext): Implements IResolveContext; more clean-up needed here.
11536 * decl.cs (MemberCore): Implemented IResolveContext.
11538 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11539 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11540 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11541 Refactored to use new IResolveContext instead of EmitContext; cleanup
11543 2006-02-06 Miguel de Icaza <miguel@novell.com>
11545 * codegen.cs (EmitScopeInitFromBlock): check here the
11546 capture_context, there is no need to make two calls to the
11549 * anonymous.cs: Add some debugging messages that might help me
11550 track other instances of this problem in the future (the
11551 regression of test 467).
11553 * cs-parser.jay: track the variable block, as we need to initalize
11554 any captured variables declared in this block for the "catch"
11555 portion of the "Try" statement.
11557 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11558 scope initialization for captured variables.
11560 Also, move the emit for the variables after the block location has
11563 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11565 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11567 2006-02-02 Miguel de Icaza <miguel@novell.com>
11569 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11570 commit yesterday, the initialization for the roots is necessary.
11571 What is not necessary is the scope activation.
11573 2006-02-02 Raja R Harinath <rharinath@novell.com>
11575 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11576 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11578 (Argument.Resolve): Remove CS0206 checks.
11580 2006-02-01 Miguel de Icaza <miguel@novell.com>
11582 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11583 scopes for all the roots, the scopes will now be emitted when the
11584 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11586 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11587 code. This reduces a lot of existing cruft.
11589 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11590 that the ScopeInfo is generated as we enter the scope, not at the
11591 time of use, which is what we used to do before.
11593 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11594 every time a Block is about to be emitted if we have a
11597 2006-02-01 Raja R Harinath <rharinath@novell.com>
11599 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11601 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11603 * typemanager.cs (cons_param_array_attribute): Make private.
11604 (Reset): Set it to null.
11605 (InitCoreHelpers): Don't initialize it.
11606 (ConsParamArrayAttribute): New. Initialize it as needed.
11607 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11609 2006-01-31 Miguel de Icaza <miguel@novell.com>
11611 * expression.cs: There might be errors reported during the
11612 selection of applicable methods. If there are errors, do not
11613 continue execution as it will lead the compiler to crash.
11615 2006-01-30 Miguel de Icaza <miguel@novell.com>
11617 * expression.cs: Member access is not allowed on anonymous
11618 methods. Fixes #77402.
11620 2006-01-30 Raja R Harinath <rharinath@novell.com>
11623 * cs-parser.jay (VariableDeclaration): Don't set
11624 current_array_type to null.
11625 (field_declaration, event_declaration, declaration_statement):
11626 Set it to null here.
11628 2006-01-28 Raja R Harinath <harinath@gmail.com>
11630 * typemanager.cs (GenericParameterPosition): New.
11633 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11635 * doc.cs : To process "include" elements, first we should create
11636 another list than XmlNodeList, because it could result in node
11637 removal, which could result in that the XmlNodeList gives up
11638 yielding next node.
11640 (Also made code identical to gmcs again.)
11642 2006-01-25 Miguel de Icaza <miguel@novell.com>
11644 * ecore.cs: Introduce an error report that we were not catching
11645 before, if not silent, we must report the error. Gonzalo ran into
11648 2006-01-23 Miguel de Icaza <miguel@novell.com>
11650 A fix for bug: #76957
11652 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11653 ComputeMethodHost before creating the method, this is a new
11656 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11657 that this method references (RegisterScope). The actual scope
11658 where the method is hosted is computed with the ComputeMethodHost
11659 before we create the method.
11661 Moved the Deepest routine here.
11663 (AnonymousContainer.ComputeMethodHost): New routine used to
11664 compute the proper ScopeInfo that will host the anonymous method.
11666 (ScopeInfo): Deal with multiple roots. The problem was that we
11667 did not have a unique root where all ScopeInfos could be hanged
11668 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11671 Remove AdjustMethodScope which is now computed at the end. Remove
11672 LinkScope which did a partial link, instead link all ScopeInfos
11673 before code generation from the new "LinkScopes" routine.
11675 Simplify all the Add* routines as they no longer need to maintain
11676 the tree, they just need to record that they are using variables
11679 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11680 routines to produce the forest of ScopeInfo trees.
11682 * class.cs (TypeContainer.AppendMethod): This is just like
11683 AddMethod, but ensures that an interface implementation method
11684 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11685 methods, but at the end.
11687 We use this functionality to ensure that the generated MoveNext
11688 method in the iterator class is resolved/emitted before the
11689 enumerator methods created.
11691 This is required because the MoveNext method computes the right
11692 ScopeInfo for the method. And the other methods will eventually
11693 need to resolve and fetch information computed from the anonymous
11696 2006-01-21 Raja R Harinath <harinath@gmail.com>
11697 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11699 Fix rest of #76995.
11700 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11701 the 'aliases' hash.
11702 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11703 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11705 2006-01-18 Raja R Harinath <rharinath@novell.com>
11707 Fix #76656, cs0231-2.cs.
11708 * cs-parser.jay (formal_parameter_list): Make error case catch
11710 (parenthesized_expression_0): Add CS1026 check.
11711 (invocation_expression): Remove unused { $$ = lexer.Location }.
11713 2006-01-17 Raja R Harinath <rharinath@novell.com>
11716 * cs-parser.jay (statement_expression): Don't list out the
11717 individual statement-expressions. Convert syntax error into
11720 2006-01-16 Raja R Harinath <rharinath@novell.com>
11723 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11724 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11725 CheckIntermediateModification.
11726 (FieldExpr.DoResolve): Add new two-argument version that
11727 allows us to resolve the InstanceExpression as an lvalue.
11728 The one-argument variant is now just a wrapper.
11729 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11730 Resolve the lhs as an lvalue if the it has a value type.
11731 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11732 from Assign.DoResolve.
11733 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11734 resolved as an lvalue.
11735 (PropertyExpr.DoResolve): Update.
11736 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11737 has a value type. Move CS1612 check here from
11738 CheckIntermediateModification.
11739 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11740 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11741 'right_side' of a ResolveLValue on an 'out' argument.
11742 (EmptyExpression.LValueMemberAccess): New. Used as the
11743 'right_side' of a propagated ResolveLValue on a value type.
11744 (LocalVariableReference.DoResolveBase): Recognize
11745 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11747 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11748 EmptyExpression.Null.
11750 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11752 * typemanager.cs : added IsGenericParameter(). In mcs it always
11754 * doc.cs : for generic parameters, use GenericParameterPosition,
11757 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11759 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11761 2006-01-12 Miguel de Icaza <miguel@novell.com>
11763 This fixes the problem where we used ldfld instead of ldflda to
11764 load the "THIS" pointer on captured parameters, when THIS is a
11765 value type. See bug #77205.
11767 * iterators.cs (CapturedThisReference.Emit): Pass false to
11768 EmitThis (we do not need the address).
11770 * codegen.cs (EmitThis): it needs to know whether we need the
11771 address of `this' or not. This is used by value types.
11773 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11774 every other call passes false.
11776 2006-01-12 Raja R Harinath <rharinath@novell.com>
11779 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11781 * expression.cs (Invocation.OverloadResolve): Update.
11782 (Invocation.DoResolve): Avoid double resolution of invocation.
11784 2006-01-11 Raja R Harinath <rharinath@novell.com>
11787 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11788 unary negation of floating point types as 0-expr; negation cannot
11789 overflow in floating point types.
11792 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11793 on operands of 'void' type.
11796 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11797 and ExclusiveOr for boolean constants too.
11799 2006-01-09 Raja R Harinath <rharinath@novell.com>
11802 * expression.cs (Invocation.OverloadResolve): Replace reflected
11803 override methods with their base virtual methods, rather than
11804 skipping over them.
11805 * typemanager.cs (TypeManager.GetOverride): New.
11807 2006-01-05 Jb Evain <jbevain@gmail.com>
11809 * class.cs (Property.Define, Indexer.Define): do not tag the
11810 properties as SpecialName | RTSpecialName.
11812 2006-01-04 Miguel de Icaza <miguel@novell.com>
11814 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11815 doing a low-level comparission of parameter types. It was lacking
11816 a check for __argslist.
11818 2005-12-30 Miguel de Icaza <miguel@novell.com>
11820 * expression.cs (ParameterReference.DoResolveBase): Allow
11821 reference parameters if they are local to this block.
11823 This allows the ref and out parameters of a delegate to be used in
11824 an anonymous method, for example:
11826 delegate void set (out int x);
11828 set s = delegate (out int x){
11832 This is used by functionality introduced late in the C# language.
11834 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11835 method that take ref and out parameters.
11837 Fixes #77119 which was a late change in the spec.
11839 2005-12-23 Miguel de Icaza <miguel@novell.com>
11841 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11842 parent if its the same scope. Fixes #77060.
11844 2005-12-21 Miguel de Icaza <miguel@novell.com>
11846 * driver.cs: Report the case of no source files and no -out:
11849 2005-12-20 Raja R Harinath <rharinath@novell.com>
11852 * expression.cs (ComposedCast.GetSignatureForError): Define.
11854 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11858 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11859 ListDictionary, to contain the ExternAliasEntry entries (in
11860 addition to the NamespaceEntry.aliases hashtable). This field is
11861 shared between the original entry and its doppelganger (bodyless
11863 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11864 extern_aliases field.
11865 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11866 lookup in extern_aliases.
11868 2005-12-16 Raja R Harinath <rharinath@novell.com>
11871 * class.cs (TypeContainer.Mark_HasEquals): New.
11872 (TypeContainer.Mark_HasGetHashCode): New.
11873 (ClassPart): Override them.
11874 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11877 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11878 'parent' argument to the base constructor.
11880 Remove all mention of TypeContainer from decl.cs.
11881 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11882 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11883 (DeclSpace.DeclSpace): Likewise.
11884 (DeclSpace.DefineMembers): Remove unused argument.
11885 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11886 debugging check -- we don't care if the debug code throws an
11887 InvalidCastException instead of an InternalErrorException.
11888 * class.cs (TypeContainer.DefineMembers): Update to changes.
11889 (TypeContainer.DoDefineMembers): Likewise.
11890 (TypeContainer.GetMethods): Likewise.
11891 (PropertyMember.Define): Likewise.
11892 (MemberBase.Parent): New property that forwards to
11893 MemberCore.Parent, but ensures that we get a TypeContainer.
11894 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11895 (RootContext.PopulateTypes): Likewise. Remove special case code
11896 for !RootContext.StdLib: DefineMembers is idempotent.
11898 2005-12-14 Miguel de Icaza <miguel@novell.com>
11900 * convert.cs (ExplicitConversionCore): Check the return value from
11901 ExplicitConversionCore which can return null on failure. Fixes #76914
11903 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11905 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11907 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11909 * doc.cs : The search for referenced namespace was insufficient to
11910 get global one as it used to do. Fixed bug #76965.
11912 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11914 * doc.cs : check name in cref in the last phase that whether it is
11917 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11919 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11922 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11924 * doc.cs : so it turned out that we cannot skip override check for
11925 interface members. Fixed bug #76954.
11927 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11929 * cs-tokenizer.cs : fixed bug #75984:
11930 - #warning and #error should not be handled when the source line
11932 - #line is not checked strictly when the source line is disabled.
11933 - #define and #undef is on the other hand checked strictly at any
11936 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11938 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11941 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11943 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11945 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11946 event initializers.
11947 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11948 (FieldBase.Initializer): Initializer is now optional.
11949 (EventField.Define): Only event field can have initializer.
11951 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11953 * const.cs (Const): Reuse initializer.
11955 * cs-parser.jay: Updated after FieldBase changes.
11956 Added current_array_type to simplify array initializers.
11958 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11960 * expression.cs, iterators.cs: Updated.
11962 * namespace.cs (NamespaceEntry): Made UsingFound private.
11964 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11966 * parameterCollection.cs: Obsolete, removed.
11967 * parser.cs: Obsolete, removed.
11969 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11972 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11974 * enum.cs (Enum.Define): Set obsolete context here.
11976 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11979 - FindDocumentedMember() now expects 1) paramList as null
11980 when "we don't have to check the number of parameters" and
11981 2) Type.EmptyTypes when "there is no arguments".
11982 - Introduced FoundMember struct to hold the exact type which was
11983 used to find the documented member (the above change broke
11984 test-xml-044; it might be better just to use DeclaringType than
11985 what MS does, like this change does, but it depends on usage.)
11987 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11989 * doc.cs : documented member might be from DeclaringType for nested
11990 types. Fixed bug #76782.
11992 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11994 * anonymous.cs: Have the param code handle leaving copies on the
11995 stack etc. Allows anonymous params to take part in the assignment
11996 code (++, +=, etc). Fixes bug #76550
11998 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11999 it down to the anon code.
12001 * iterators.cs: Use dummy var here
12003 * codegen.cs: Handle new vars
12005 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12008 * class.cs (MethodData.Define): Set proper Obsolete context.
12010 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12012 (FieldExpr.DoResolve): Ditto.
12014 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12017 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12018 parent is not obsolete.
12020 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12022 * doc.cs : (FindDocumentedMember) find parameterless members first
12023 and get CS0419 in the early stage. Fixed first case of bug #76727.
12025 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12028 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12029 no error was reported.
12031 *expression.cs (Binary.DoResolve): left can be null.
12033 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12036 * class.cs (MethodData.Emit): Parameters should be labeled first.
12038 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12041 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12043 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12045 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12047 * class.cs (MethodCore): Parameter clean up.
12048 (IMethodData): Added ParameterInfo.
12049 (MethodData): Parameter clean up.
12050 (Indexer.Define): Parameter clean up.
12062 * typemanager.cs: Parameter clean up.
12064 * delegate.cs (Define): Get rid of duplicated code.
12066 * expression.cs (ParameterReference): Removed useless parameters
12068 (Invocation): Ditto.
12070 * parameter.cs (ParamsParameter): New class, params specialization.
12071 (ArglistParameter): Attemp to separate arglist.
12072 (Parameter): Refactored to be reusable and faster.
12073 (Parameter.Modifier): Made understandable.
12074 (Parameters): Changed to be used as a class for `this' assembly
12075 parameters. Refactored to use new specialized classes.
12077 * support.cs (ParameterData): Added Types property.
12078 (InternalParameters): Deleted.
12080 2005-08-20 Martin Baulig <martin@ximian.com>
12082 Merging this patch from GMCS to fix #75867.
12084 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12085 scope if we don't already have it.
12087 2005-11-17 Martin Baulig <martin@ximian.com>
12090 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12091 inherit the scope from our parent. Fixes #76653.
12093 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12095 * doc.cs : the previous patch does not actually fix the bug.
12096 PropertyInfo override check is now implemented and really fixed it.
12097 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12099 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12101 * doc.cs : apply "override filter" also to properties.
12104 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12106 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12107 no need to check overrides. For classes, omit those results from
12108 interfaces since they must exist in the class. Fixed bug #76726.
12110 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12112 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12113 with different parameters. Fixed the second problem in #76685.
12115 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12117 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12118 get expected 'protected' access in CheckValidFamilyAccess()).
12121 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12123 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12124 Fixed bug #76705. CS1569 was incorrectly commented out.
12126 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12128 * doc.cs : use Invocation.IsOverride() to do real override check.
12129 * expression.cs : made Invocation.IsOverride() internal.
12131 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12133 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12134 TypeBuilder.FindMembers() and filter overriden base members out.
12137 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12139 * doc.cs : ref/out parameters are represented as '@' (instead of
12140 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12142 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12144 * doc.cs : when there was no '.' in cref to methods in doc comment,
12145 then parameters were missing in the output. Fixed bug #76691.
12147 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12149 * driver.cs : don't output docs when there is an error.
12152 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12155 Now it should detect indexers. Fixed primary concern in bug #76685.
12156 Fixed CS0419 message to not show the identical member signature in
12159 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12161 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12162 instead of Type.FindMembers() since it does not handle events.
12165 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12167 * codegen.cs: Fixed typo (speficied -> specified).
12169 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12172 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12174 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12176 * attribute.cs: Changed error message.
12178 * cs-tokenizer.cs: One more check.
12180 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12182 * statement.cs (Block.Resolve): Ignore empty statement.
12184 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12186 * report.cs: Made error/warning methods more strict to avoid
12189 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12190 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12191 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12192 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12194 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12196 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12197 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12199 * class.cs (TypeContainer.IsComImport): New property.
12200 (Constructor.Define): Create proper ctor for ComImport types.
12202 * expression.cs (New.CheckComImport): Fixed.
12204 2005-11-07 Miguel de Icaza <miguel@novell.com>
12206 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12207 that a parameter has been captured does not mean that we do not
12208 have to do the rest of the processing. This fixes the second part
12209 of #76592. If there was another anonymous method capturing
12210 values in the past, the Scope would never be set for the second
12211 method that captured the same parameter.
12213 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12214 properly manipulate the stack. Second part of fix for #76592.
12216 * expression.cs (New): Add support for invoking "new" on
12217 interfaces that have been flagged with the ComImport attribute and
12218 the CoClass. Fixes #76637
12220 * statement.cs (Try.DoEmit): When a variable is captured, do not
12221 try to emit the vi.LocalBuilder variable as it has been captured.
12222 Create a temporary variable and store the results on the
12223 FieldBuilder. Fixes #76642
12225 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12227 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12229 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12231 * expression.cs (Binary.DoResolve): Added && optimalization.
12233 * typemanager.cs (AddUserType): Removed useless argument.
12235 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12237 * statement.cs (Block.variables): Uses ListDictionary.
12239 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12242 * class.cs (PartialContainer.EmitType): Customized to emit
12243 security attributes.
12244 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12245 for partial classes.
12247 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12250 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12251 access has to be fixed.
12253 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12255 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12258 * ecore.cs (NullCast.Reduce): Implemented.
12260 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12263 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12265 (Foreach.Resolve): Catch null properly.
12267 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12269 * cs-tokenizer.cs: Warning text fix.
12271 * driver.cs: AllWarningNumbers exposed on public interface.
12273 * report.cs (): Reviewed warning numbers.
12274 (IsValidWarning): Use binary search.
12276 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12278 * driver.cs: Implemeted resource visibility.
12279 (Resources): New class for code sharing between /res: and
12282 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12285 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12288 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12291 * ecore.cs (NullCast): Child is contant only.
12293 * literal.cs (NullLiteral.Reduce): null can be converted to any
12296 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12298 * driver.cs: Use Encoding.Default as default code page instead
12301 2005-10-27 Raja R Harinath <rharinath@novell.com>
12304 * expression.cs (Invocation.Error_InvalidArguments): Handle
12305 __arglist parameters.
12306 (Invocation.VerifyArgumentsCompat): Likewise.
12307 * support.cs (ReflectionParameters.GetSignatureForError): Print
12308 __arglist parameters.
12309 (InternalParamters.GetSignatureForError): Likewise.
12310 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12312 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12314 * attribute.cs (GetPropertyValue): Made public.
12316 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12318 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12320 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12323 * driver.cs: Reflect method name change.
12325 * statement.cs (Try.Resolve): Warn when try has both general
12326 exception handlers.
12328 * typemanager.cs: runtime_compatibility_attr_type new predefined
12331 2005-10-26 Raja R Harinath <harinath@gmail.com>
12334 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12335 treat it as an empty parameter list.
12337 2005-10-26 Raja R Harinath <rharinath@novell.com>
12340 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12341 ResolveAsTypeStep silent.
12342 * statement.cs (Block.AddConstant): Mark block as used.
12343 (Block.ResolveMeta): Avoid piling on error messages
12344 if a constant initializer resolution fails.
12346 2005-10-25 Raja R Harinath <rharinath@novell.com>
12348 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12350 (NamespaceEntry.VerifyAllUsing): New.
12351 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12352 behaviour. Delegates actual resolution of alias to ...
12353 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12354 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12356 * driver.cs (Driver.MainDriver): Update.
12358 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12359 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12361 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12363 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12364 RootNamespace.DefineNamespacesForAll.
12366 2005-10-24 Raja R Harinath <harinath@gmail.com>
12368 * typemanager.cs (assemblies, external_aliases, modules)
12369 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12370 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12371 overhead. Move resposibility ...
12372 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12373 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12375 2005-10-23 Raja R Harinath <harinath@gmail.com>
12377 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12378 cached_namespaces. Improve usage.
12379 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12380 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12381 Move from GlobalRootNamespace and simplify.
12382 (RootNamespace.Global): Make instance variable.
12383 (RootNamespace.RootNamespace): Add "alias name" parameter.
12384 (GlobalRootNamespace): Simplify drastically.
12385 (Namespace.Lookup): Don't use GetNamespace.
12386 * typemanager.cs (GetRootNamespace): Rename from
12387 ComputeNamespaceForAlias.
12388 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12390 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12392 * anonymous.cs (AnonymousContainer): Don't crash when container
12395 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12397 * expression.cs (Binary.DoResolve): Warn when comparing same
12400 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12403 * expression.cs (Binary.DoResolve): It looks like there are no
12404 convetsion rules in enum context.
12406 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12408 Add support for extern alias qualifiers.
12409 * typemanager.cs: Move some LookupTypeReflection code
12410 to namespace.cs, to have cleaner code. Added some methods
12411 to help us keep track of the extern aliased references.
12412 * driver.cs: Add suport for extern alias assemblies on command
12413 line and check for their warnings/errors. Also keep track of the
12414 extern aliased assemblies.
12415 * namespace.cs: Move the global functionality of Namespace
12416 to GlobalRootNamespace/RootNamespace. Now the global namespace
12417 is GlobalRootNamespace.Globa. Also the code moved from
12418 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12419 Finally added LocalAliasEntry (AliasEntry before) and
12420 ExternAliasEntry, to handle alias statements.
12421 * cs-parser.jay: Add support in the grammar for extern alias
12423 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12424 Update callings to Namespace (now in GlobalRootNamespace).
12426 2005-10-18 Raja R Harinath <rharinath@novell.com>
12429 * class.cs (TypeContainer.DefineType): Move updating of
12430 topological sort earlier in the code.
12431 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12433 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12436 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12438 * constant.cs (Constant.TryReduce): Moved from Cast class.
12439 (Reduce): Made little bit more OO and fixed missing conversions.
12441 * ecore.cs (Reduce): Implemented.
12442 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12444 * literal.cs (Reduce): Implemented.
12446 * class.cs: Reverted Miguel's wrong commit.
12448 2005-10-14 Miguel de Icaza <miguel@novell.com>
12450 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12452 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12454 * cs-parser.jay, expression.cs : CS0214 was missing error location
12455 for constants. Fixed bug #76404.
12457 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12460 * convert.cs (ExplicitConversionCore): Fixed object->enum
12463 2005-10-10 Raja R Harinath <rharinath@novell.com>
12465 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12466 InstanceExpression.
12467 (PropertyExpr.EmitCall): Likewise.
12468 * expression.cs (Invocation.EmitArguments): Handle case where
12470 (Invocation.EmitCall): Avoid allocating temporary variable if
12471 there are no arguments.
12473 2005-10-07 Raja R Harinath <rharinath@novell.com>
12476 * convert.cs (ImplicitConversionStandard): Move conversion of
12477 void* to arbitrary pointer types ...
12478 (ExplicitConversionStandard): .. here.
12479 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12480 error to always print typenames.
12482 2005-10-07 Raja R Harinath <rharinath@novell.com>
12484 * convert.cs (GetConversionOperator): Rename from
12485 GetConversionOperators. Move operator selection code from ...
12486 (UserDefinedConversion): ... here.
12488 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12490 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12493 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12495 * assign.cs (Assign.DoResolve): Error method changed.
12497 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12499 * const.cs (ResolveValue): Reset in_transit immediately.
12501 * constant.cs: Error method changed.
12503 * convert.cs: Removed useless location parameter.
12504 (ExplicitNumericConversion): Don't do double enum check.
12505 (ExplicitConversionCore): Renamed from ExplicitConversion.
12506 (ExplicitUnsafe): Extracted from ExplicitConversion.
12507 (ExplicitConversion): Uses for error reporting.
12509 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12511 (ResolveBoolean): Uses common error method.
12512 (CastToDecimal): Get rid of ec.
12513 (CastFromDecimal): Optimized.
12514 (ConvCast): Get rid of ec.
12516 * enum.cs (ResolveValue): Reset in_transit immediately.
12517 (Emit): Return after first error.
12519 * expression.cs: Convert changes.
12521 * literal.cs: Error method changed.
12523 * statement.cs: Error method changed.
12525 2005-10-03 Raja R Harinath <rharinath@novell.com>
12527 * support.cs (SeekableStreamReader.Position): Don't error out when
12528 the requested position is just beyond the end of the current
12531 2005-09-28 Raja R Harinath <rharinath@novell.com>
12533 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12534 try to keep in sync with the byte count of the underlying Stream.
12535 However, this limits us to a window size of 2048 characters: i.e.,
12536 the maximum lookahead of our lexer/parser can be 2048 characters.
12538 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12541 * driver.cs: Fix compilation files with full root path.
12543 2005-09-25 Miguel de Icaza <miguel@novell.com>
12545 * report.cs (SymbolRelatedToPreviousError): Format the output so
12546 it does not use an open parenthesis that is never closed.
12548 * driver.cs: Follow coding guidelines
12550 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12553 * const.cs (Const.ResolveValue): Check for assigning non-null
12554 value to reference type.
12556 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12558 * anonymous.cs: Implemented ExprClassName.
12560 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12563 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12566 * class.cs (StaticClass.DefineContainerMembers): Report protected
12569 * codegen.cs: if(ed) PRODUCTION.
12571 * convert.cs (Error_CannotImplicitConversion): Better error
12574 * cs-parser.jay: More error checks.
12576 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12578 * driver.cs (CSCParseOption): Enabled wrong option check.
12580 * ecore.cs (Expression.ExprClassName): Turned to property.
12581 (MemberExpr.CheckIntermediateModification): For checking boxed
12582 value types modification.
12584 * statement.cs (Fixed.Resolve): Expression type must be
12585 convertible to fixed type.
12586 (CollectionForeach.GetEnumeratorFilter,TryType):
12587 Small refactoring for easier error checking.
12589 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12591 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12594 * class.cs (GeneratedBaseInitializer): New class for customization
12595 compiler generated initializers.
12596 (MemberBase.DoDefine): Check Obsolete attribute here.
12597 (FieldMember.DoDefine): Ditto.
12599 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12602 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12603 (MemberCore.GetObsoleteAttribute): Removed argument.
12604 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12605 (MemberCore.CheckObsoleteType): New helper.
12609 * statement.cs: Updates after MemberCore changes.
12611 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12612 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12614 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12615 obsolete attribute for compiler construct.
12616 (As.DoResolve): Cache result.
12618 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12620 2005-09-26 Raja R Harinath <rharinath@novell.com>
12623 * expression.cs (This.VerifyFixed): In a value type T, the type of
12624 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12625 value type R, 'this' is treated as a value parameter.
12627 2005-09-22 Miguel de Icaza <miguel@novell.com>
12629 * statement.cs (Lock): Use the TemporaryVariable class instead of
12630 manually using local variables as those do not work when variables
12633 * ecore.cs: Moved the TemporaryVariable class from being a nested
12634 class inside Foreach to be a public class that can be employed in
12637 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12639 * cs-parser.jay: interface_accessors replaced by
12640 accessor_declarations.
12642 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12645 * statement.cs (GotoCase.Resolve): Convert null constant to
12647 (SwitchLabel.ResolveAndReduce): Ditto.
12648 (SwitchLabel.NullStringCase): Custom null stamp.
12649 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12651 typemanager.cs (CSharpSignature): Don't skip first argument
12654 2005-09-18 Miguel de Icaza <miguel@novell.com>
12656 * driver.cs: Set InEmacs based on the environment variable EMACS.
12658 * location.cs (InEmacs): in this mode, do not report column
12659 location as it confuses Emacs.
12661 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12663 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12664 expression.cs, iterators.cs, literal.cs: Store constants and
12667 * class.cs (MemberBase.ShortName): Pass location.
12669 * cs-parser.jay: Some location fixes.
12671 * ecore.cs (Expression.Location): Made virtual.
12673 2005-09-05 Miguel de Icaza <miguel@novell.com>
12675 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12676 if the underlying types are the same, otherwise we need to produce
12677 code that will do the proper cast.
12679 This was exposed by Marek's constant rewrite which produced
12680 invalid code for the call site:
12682 enum X : long { a }
12683 void Method (X v) {}
12687 This fixes test-49.cs
12689 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12691 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12692 Type/Object should be allowed as well. Fixed bug #75968.
12694 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12696 * expression.cs : (Binary.DoResolve): when one is enum constant and
12697 another is constant 0, then return enum one *as enum type*.
12700 2005-09-02 Raja R Harinath <rharinath@novell.com>
12702 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12706 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12707 flow-branching for LocalVariableReferences in case we were invoked
12708 from a MemberAccess.
12709 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12711 (LocalVariableReference.DoResolveBase): ... this.
12712 (MemberAccess.Resolve): Do the check that was disabled during
12715 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12718 (PartialContainer.Create): check abstract/sealed/static strictly
12719 but abstract/sealed can exist only at one side. Fixed bug #75883.
12721 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12724 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12725 specified, don't default to UnmanagedType.I4.
12727 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12729 * expression.cs : conditional operator should check possibly
12730 incorrect assign expression. Fixed bug #75946.
12732 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12734 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12735 Reverting the change. gmcs is much complex than mcs on this matter.
12737 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12739 * cs-tokenizer.cs : To read another token ahead of the actual
12740 consumption, use new SavedToken and cache token instead of moving
12741 back the stream with SeekableStreamReader (it seemed problematic).
12743 driver.cs : Thus use StreamReader directly.
12744 * support.cs : Thus removed SeekableStreamReader.
12746 2005-08-30 Raja R Harinath <rharinath@novell.com>
12749 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12750 (ScopeInfo.EmitScopeType): Use it to construct field names from
12751 names of captured locals.
12754 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12755 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12756 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12757 (ExplicitConversion): Remove enum cases already handled by
12758 implicit conversion. Move implicit conversion check to the beginning.
12759 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12760 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12761 Don't treat System.Enum as a struct.
12763 2005-08-30 Jb Evain <jbevain@gmail.com>
12765 * attribute.cs: handles as expression in parameters.
12767 2005-08-30 Raja R Harinath <rharinath@novell.com>
12770 * class.cs (TypeContainer.VerifyClsName): Don't use a
12771 PartialContainer when verifying CLS compliance.
12772 (AbstractPropertyEventMethod): Set Parent here, ...
12773 (PropertyMethod): ... not here.
12775 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12777 * attribute.cs : escaped attribute name should not be allowed to be
12778 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12780 2005-08-29 Raja R Harinath <rharinath@novell.com>
12783 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12784 when converting a long constant to unsigned long.
12785 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12786 detect where IsApplicable and VerifyArgumentsCompat disagree.
12788 2005-08-29 Raja R Harinath <rharinath@novell.com>
12789 and Carlos Alberto Cortez <carlos@unixmexico.org>
12792 * class.cs (TypeContainer.CanElideInitializer): New helper.
12793 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12794 can safely emitting the initializer of a field.
12796 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12798 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12799 allowed inside a switch (without loop). Fixed bug #75433.
12801 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12803 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12804 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12806 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12808 * driver.cs : kinda reverting the default encoding changes (not exact
12809 revert since I noticed that "codepage:reset" might not work fine).
12811 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12813 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12814 Location. Now getter and setter store location correctly.
12815 (errors/cs0111-12.cs now reports the expected location.)
12817 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12819 * driver.cs : Use default encoding on the environment.
12820 Removed (now that) extra parameter for SeekableStreamReader.
12821 * support.cs : (SeekableStreamReader) third .ctor() argument for
12822 StreamReader is not required (always true). preamble size could
12823 be acquired in simpler and safe way.
12825 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12827 * cs-parser.jay: report CS0642 at warning level 3
12828 and report CS0642 for an if else statement also
12829 fixes bug #74745. Patch by John Luke (and a bit
12831 Removed extra CS0642 warning check for "while",
12833 * statement.cs: In Block.Resolve(), CS0642 check
12834 is reimplemented to check a sequence of an empty
12835 statement and a block.
12837 Both fix bug #66777.
12839 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12841 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12842 detection until I fix it.
12844 * cs-tokenizer.cs: Changed error message.
12846 * cs-parser.jay: Fixed 2 error locations.
12848 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12849 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12852 * enum.cs (GetSignatureForError): Fixed.
12854 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12858 * typemanager.cs (RegisterProperty): Removed.
12860 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12862 2005-08-24 Raja R Harinath <rharinath@novell.com>
12865 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12866 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12868 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12870 * expression.cs : tiny fix is required for not warning positive ulong.
12873 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12875 * expression.cs : add CS0652 check for constant and integral
12876 expression. Fixed bug #53974.
12878 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12880 * expression.cs : in DoNumericPromotions(), check if there is implicit
12881 conversion overload for string (to check CS0034). Fixed bug #52492.
12883 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12885 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12887 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12889 * ecore.cs : report location when it is *not* Null.
12891 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12897 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12898 correctly. Fixed bug #75721.
12900 2005-08-23 Raja R Harinath <rharinath@novell.com>
12902 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12903 loop that performs 'min (pos, char_count)'.
12906 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12907 converted value in Operator.OnesComplement.
12909 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12911 * anonymous.cs: If the anon method is pulled into a helper class,
12912 it needs to be `internal' not `private'. Fixes runtime behavior on
12915 2005-08-20 Martin Baulig <martin@ximian.com>
12917 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12918 scope if we don't already have it.
12920 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12921 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12924 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12927 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12928 is a partial class.
12930 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12932 The big constants rewrite
12933 Fix #75746, #75685 and more
12934 As a side effect saved 1MB for MWF ;-)
12936 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12937 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12938 enum based for corlib compilation.
12940 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12943 * class.cs (FixedField.Define): Use ResolveAsConstant.
12945 * const.cs (IConstant): Interface constants and enums.
12946 (Const.ResolveValue): New method for constant resolvning.
12947 (ExternalConstant): Constants from imported assemblies.
12949 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12950 conversion; like enums.
12951 (Constant.ToType): Converts this constant to different type.
12952 (Constant.Increment): Adds 1.
12954 * convert.cs (ImplicitConversionRequired): Simplified.
12956 * cs-parser.jay: Create EnumMember directly.
12958 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12960 * doc.cs (GenerateEnumDocComment): Removed.
12962 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12963 (ConvertIntLiteral): Removed.
12964 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12966 * enum.cs (EnumMember): Implement IConstant.
12967 (Enum.IsValidEnumConstant): Removed.
12968 (Enum.GetNextDefaultValue): Removed.
12969 (Enum.FindMembers): Updated.
12970 (Enum.GenerateDocComment): Iterate enum members.
12972 * expression.cs (Cast.TryReduce): Handle enums correctly.
12973 (New.Constantify): Made public.
12974 (MemberAccess.DoResolve): Removed contant specific if(s).
12976 * literal.cs (NullLiteral): Implement new abstract methods.
12978 * statement.cs (GotoCase.Resolve): Use new constant methods.
12979 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12981 * typemanager.cs (LookupEnum): Removed.
12982 (IsEnumType): Fixed to work with corlib.
12983 (RegisterConstant): Removed.
12984 (LookupConstant): Removed.
12985 (GetConstant): Changed to work with IConstant.
12987 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12989 * location.cs : Fixed overflown (>255) column number.
12991 2005-08-03 Raja R Harinath <rharinath@novell.com>
12993 First cut of the qualified-alias-member feature.
12994 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12996 * cs-parser.jay (DOUBLE_COLON): New token.
12997 (namespace_or_type_name): Add rule for recognizing
12998 qualified-alias-members.
12999 (primary_expression): Likewise.
13000 (element_access): Allow QualifiedAliasMember as a possible
13001 type-bearing expression.
13002 (local_variable_type, local_variable_pointer_type): Likewise.
13003 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13004 aliases in the current and enclosing namespace declarations.
13005 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13006 * decl.cs (MemberName.is_double_colon): New.
13007 (MemberName.MemberName): Add new constructor for alias-member.
13008 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13009 * expression.cs (QualifiedAliasMember): New expression type.
13011 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13013 * location.cs : it borked when no argument was specified.
13015 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13017 * location.cs : tiny ToString() format fix.
13019 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13021 * statement.cs : oops, it was missing.
13023 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13025 A set of fixes for precise line/column location.
13028 "token" field now holds a file/line "delta", a line number offset
13029 from the segment, and a column number. See also:
13030 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13031 December/009508.html
13032 Removed static IsNull. Use instance IsNull property instead.
13033 * cs-tokenizer.cs :
13034 For some tokens it stores Location. For Identifier it stores
13035 LocatedToken which is a pair of string name and location.
13036 Column numbers are adjusted only at getChar().
13038 Use Location.ToString() for reporting (it now contains column).
13040 Largely modified to use LocatedToken instead of
13041 string (IDENTIFIER), and to acquire Location from some tokens.
13042 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13043 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13045 Now MemberName holds Location. DeclSpace.ctor() receives Location
13046 as a parameter. Removed extra parameters to all derived classes.
13047 Replaced Location.IsNull() with instance property.
13048 * assign.cs, expression.cs :
13049 Added .ctor() overload that omits Location.
13051 Added "nameEscaped" flag that indicates the identifier was escaped
13052 in the source file. This fixes bug #57047.
13054 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13056 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13057 New method, looking for lo-case imported cls type.
13059 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13062 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13064 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13066 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13067 all_imported_types.
13068 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13070 Optimized to save 3.5 MB for SWF compilation.
13072 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13074 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13075 (PartialContainer.Create): Moved logic AddToContainer.
13076 (PartialContainer.MarkForDuplicationCheck): Shares name.
13078 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13081 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13083 (Namespace.GetSignatureForError): New method.
13085 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13086 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13088 2005-08-01 Raja R Harinath <rharinath@novell.com>
13091 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13092 member lookup rather than qualifier_type, since qualifier_type can
13095 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13097 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13100 2005-07-31 Miguel de Icaza <miguel@novell.com>
13102 * statement.cs: Copy the local exception into the exception
13103 captured local. Fixes 75674
13105 2005-07-31 Raja R Harinath <harinath@gmail.com>
13108 * expression.cs (Invocation.OverloadResolve): Don't report error
13109 CS1501 if error CS1502 has been reported.
13110 (New.DoResolve): Delegate CS1501 reporting to
13111 Invocation.OverloadResolve.
13114 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13115 invariant-meaning-in-block property in an enclosing block if
13118 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13120 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13121 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13122 (Switch.CheckSwitch): Just save 50kb for SWF.
13124 2005-07-27 Martin Baulig <martin@ximian.com>
13126 * anonymous.cs (CaptureContext.AddField): Added
13127 `AnonymousContainer am' argument; compute its toplevel scope if
13128 it's not already computed. Fixes #75649.
13130 2005-07-26 Raja R Harinath <rharinath@novell.com>
13133 * class.cs (Constructor.Emit): Reset block to null if the block
13136 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13138 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13140 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13142 * class.cs (MethodData.Define): Check whether accessor implementing
13143 interface is public.
13145 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13147 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13150 * namespace.cs (LookupType): Moved same type check to...
13152 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13153 with the same name.
13155 2005-07-21 Raja R Harinath <rharinath@novell.com>
13157 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13158 already found a typebuilder.
13159 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13160 MemberNames, not strings.
13162 * const.cs (Error_ExpressionMustBeConst):
13163 Rename from Error_EpressionMustBeConst.
13164 * const.cs, class.cs, statement.cd: Update.
13166 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13170 * const.cs (Const.LookupConstantValue): Report missing contant expression
13172 (Error_EpressionMustBeConstant): Only one error method.
13174 * class.cs, statement.c: Updated.
13176 2005-07-20 Raja R Harinath <rharinath@novell.com>
13178 * statement.cs (Block.Flags): Add back HasVarargs.
13179 (Block.flags): Make protected.
13180 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13182 * typemanager.cs (types, typecontainers, user_types): Remove.
13183 (UserTypes, TypeContainers): Likewise.
13184 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13185 (CleanUp, Reset): Update.
13186 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13187 (GetNestedType): Use Type.GetNestedType.
13188 (CoreLookupType): Take two arguments, the namespace and the
13189 basename of the type. Update to use the Namespace.Lookup
13191 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13192 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13193 string concatenation and substring matches.
13194 * class.cs, enum.cs, delegate.cs: Update to changes.
13196 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13198 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13199 Expression and made virtual.
13201 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13202 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13204 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13206 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13209 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13212 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13215 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13216 AssemblyCultureAttribute is not used on executable.
13219 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13221 2005-07-16 Raja R Harinath <rharinath@novell.com>
13224 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13225 New. Reports CS0252/CS0253.
13226 Mostly taken from preliminary patch by Duncak Mak.
13227 (Binary.DoResolveOperator): Store results of operator lookup.
13228 Use them to detect if we need to warn about unintended reference
13231 2005-07-15 Raja R Harinath <rharinath@novell.com>
13234 * namespace.cs (Namespace.Lookup): Add back location parameter.
13235 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13236 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13238 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13239 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13240 (Namespace.LookupType): ... this.
13241 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13243 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13244 purported to handle pointers.
13245 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13248 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13250 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13253 2005-07-15 Raja R Harinath <rharinath@novell.com>
13255 * namespace.cs (Namespace.Lookup): Drop location parameter.
13256 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13257 (NamespaceEntry.Lookup): ... this.
13258 (NamespaceEntry.Error_AmbiguousTypeReference):
13259 Move here from DeclSpace.
13260 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13262 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13263 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13264 Move to NamespaceEntry.
13265 * delegate.cs, expression.cs: Update to changes.
13267 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13269 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13270 CheckAttributeType and refactored.
13271 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13272 ResolveAsTypeTerminal error handling.
13273 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13275 (GetSignatureForError): Print errors in same way.
13278 * codegen.cs: Reflect attribute GetSignatureForError change.
13281 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13283 * namespace.cs (UsingEntry): Refactored to make fields private.
13286 statement.cs: Error_UnexpectedKind has extra parameter.
13288 2005-07-14 Raja R Harinath <rharinath@novell.com>
13290 * ecore.cs (IAlias): Remove.
13291 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13292 that implement the interface.
13293 * namespace.cs (Namespace): Likewise.
13294 (Namespace.declspaces): Renamed from 'defined_names'.
13295 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13296 DeclSpace instead of an IAlias.
13297 * tree.cs (Tree.AddDecl): Update.
13299 2005-07-12 Raja R Harinath <rharinath@novell.com>
13301 * statement.cs (Block.Flags); Remove HasVarargs.
13302 (Block.HasVarargs): Move to ToplevelBlock.
13303 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13304 (Block.Variables): Make protected. Initialize variable hashtable
13306 (Block.AddVariable): Update.
13307 (Block.Resolve): Update to changes.
13308 (ToplevelBlock.HasVarargs): New boolean.
13309 (ToplevelBlock.ThisVariable): Move here from Block.
13310 (ToplevelBlock.AddThisVariable): Likewise.
13311 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13312 * expression.cs (This.ResolveBase): Update to changes.
13313 (ArglistAccess.DoResolve): Likewise.
13315 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13318 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13320 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13321 not used and not used & assigned.
13322 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13324 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13327 * expression.cs (Is.DoResolve): null is never provided type.
13329 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13332 * cs-parser.jay: Less strict event error rule to catch more errors.
13334 2005-07-08 Martin Baulig <martin@ximian.com>
13336 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13337 gettter (allowed) or setter (not allowed).
13339 * class.cs (Accessor): Implement IIteratorContainer.
13340 (Accessor.Yields): New public field.
13341 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13342 per-accessor basis.
13345 (get_accessor_declaration, set_accessor_declaration): Set the
13346 `yields' flag on the accessor, not the property.
13347 (property_declaration): Do the iterators check on a per-accessor
13348 basis and not for the whole property.
13350 2005-07-08 Martin Baulig <martin@ximian.com>
13352 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13353 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13355 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13358 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13359 (ExtractSecurityPermissionSet): Cope with self referencing security
13360 attributes properly.
13362 * driver.cs (SetOutputFile): Made public property OutputFile.
13364 2005-07-07 Raja R Harinath <rharinath@novell.com>
13367 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13368 has_nonstatic_fields. Make into a FieldBase pointer.
13369 (TypeContainer.AddField): Add CS0282 check.
13370 (TypeContainer.EmitType): Update.
13372 2005-07-06 Miguel de Icaza <miguel@novell.com>
13374 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13375 compare if they start with __.
13377 2005-07-06 Raja R Harinath <rharinath@novell.com>
13379 * statement.cs (Switch.SwitchGoverningType): Only look at
13380 UserCasts that don't need implicit standard conversions to one of
13381 the allowed switch types (Fixes test-322.cs).
13382 (LocalInfo.Resolve): Re-enable sanity-test.
13384 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13386 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13388 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13390 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13392 2005-07-06 Raja R Harinath <rharinath@novell.com>
13395 * ecore.cs (SimpleName.GetSignatureForError): Add.
13396 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13397 (MemberAccess.GetSignatureForError): Add.
13399 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13401 The big error and warning messages review.
13431 * typemanager.cs: Updated.
13433 * class.cs: (MethodCore.SetYields): Moved here to share.
13434 (PropertyMethod.Define): Moved iterator setup here.
13436 * iterators.cs: Add orig_method to have full access to parent
13439 2005-07-05 Raja R Harinath <rharinath@novell.com>
13441 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13442 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13443 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13444 variable of struct type.
13445 * expression.cs (Unary.ResolveOperator): Update to change.
13446 (Indirection.VerifyFixed): Likewise.
13447 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13448 (ParameterReference.VerifyFixed): Value parameters are fixed.
13449 (This.VerifyFixed): Treat 'this' as a value parameter.
13450 * statement.cs (LocalInfo.IsFixed): Remove.
13452 2005-07-01 Martin Baulig <martin@ximian.com>
13454 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13455 `ec.EmitThis ()' to get the correct scope.
13457 2005-07-01 Martin Baulig <martin@ximian.com>
13459 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13460 instance is a ParameterReference; fixes #75299.
13462 2005-07-01 Martin Baulig <martin@ximian.com>
13464 Reverted Marek's latest patch (r46725):
13465 - it contains structural changes which are neither mentioned in
13466 the ChangeLog nor explained anywhere; for example the additional
13467 argument of EmitContext's and Iterator's .ctor's and the
13468 TypeContainer.DefineMembers() change.
13469 - structural changes like this should go in in seperate patches
13470 and not be hidden in a huge patch which just seems to affect
13471 warnings and errors.
13472 a big and hard to understand patch.
13473 - it breaks iterators and causes regressions, for instance in
13476 2005-06-30 Raja R Harinath <rharinath@novell.com>
13479 * expression.cs (Indexers.map): Remove.
13480 (Indexers.Append): Filter out inaccessible setters and getters.
13481 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13484 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13485 Refactored from ...
13486 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13487 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13488 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13489 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13491 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13494 * class.cs (FieldBase.GetInitializerExpression): One more field
13497 2005-06-28 Miguel de Icaza <miguel@novell.com>
13499 * pending.cs: Do not define a proxy if the base method is virtual,
13500 it will be picked up by the runtime (bug 75270).
13502 2005-06-08 Martin Baulig <martin@ximian.com>
13504 The big Iterators rewrite :-)
13506 * iterators.cs: Rewrite this to use the anonymous methods framework.
13508 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13509 before the TypeContainers; see 2test-21.cs.
13512 (TypeContainer.DefineType): Don't create a new EmitContext if we
13513 already have one (this only happens if we're an Iterator).
13514 (TypeContainer.Define): Also call Define() on all our iterators.
13515 (Method.CreateEmitContext): Added support for iterators.
13518 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13519 (AnonymousContainer.CreateMethodHost): Moved here from
13520 AnonymousMethod and made abstract.
13521 (AnonymousContainer.CreateScopeType): New abstract method.
13522 (AnonymousContainer.IsIterator): New public property.
13523 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13524 get the ScopeTypeBuilder rather than manually defining it here.
13525 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13528 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13529 before RootContext.DefineTypes().
13531 * codegen.cs (EmitContext.RemapToProxy): Removed.
13532 (EmitContext.CurrentAnonymousMethod): Changed type from
13533 AnonymousMethod -> AnonymousContainer.
13534 (EmitContext.ResolveTopBlock): Protect from being called twice.
13535 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13536 (EmitContext.EmitThis): Removed the iterators hacks; use the
13537 anonymous methods framework for that.
13540 (ToplevelBlock.Container): Make this a property, not a field.
13541 (ToplevelBlock.ReParent): New public method; move the
13542 ToplevelBlock into a new container.
13543 (Foreach.TemporaryVariable): Simplify.
13545 2005-06-05 Martin Baulig <martin@ximian.com>
13547 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13548 (Block.AddTemporaryVariable): New public method; creates a new
13549 `LocalInfo' for a temporary variable.
13550 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13552 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13553 non-iterator variables.
13555 2005-06-05 Martin Baulig <martin@ximian.com>
13557 * statement.cs (Foreach.TemporaryVariable): Create the
13558 LocalBuilder in the Emit phase and not in Resolve since in some
13559 situations, we don't have an ILGenerator during Resolve; see
13560 2test-19.cs for an example.
13562 2005-06-04 Martin Baulig <martin@ximian.com>
13564 **** Merged r45395 from GCS ****
13566 The big Foreach rewrite - Part II.
13568 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13569 with `PropertyInfo ienumerator_getcurrent'.
13571 * codegen.cs (VariableStorage): Removed.
13574 (Foreach): Derive from Statement, not ExceptionStatement.
13575 (Foreach.CollectionForeach): New nested class. Moved all the code
13576 dealing with collection foreach here.
13577 (Foreach.ForeachHelperMethods): Removed.
13578 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13580 2005-05-23 Martin Baulig <martin@ximian.com>
13582 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13583 don't need to. Fix #75014.
13585 2005-05-20 Martin Baulig <martin@ximian.com>
13587 Merged r44808 from GMCS.
13589 * class.cs (TypeContainer.CircularDepException): Removed.
13590 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13591 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13592 (CS0146) and interface (CS0529) dependencies here.
13594 2005-06-21 Raja R Harinath <rharinath@novell.com>
13596 * expression.cs (Invocation.EmitCall): Fix initialization
13597 'this_call' to reflect current behaviour. Fix indentation.
13599 * convert.cs (FindMostEncompassedType): Add two trivial special
13600 cases (number_of_types == 0 || number_of_types == 1).
13601 (FindMostEncompasingType): Likewise.
13603 2005-06-17 Raja R Harinath <rharinath@novell.com>
13605 Some cleanups preparing for the fix of #75283.
13606 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13608 (EventExpr.InstanceResolve): Likewise.
13609 (EventExpr.DoResolve): Remove redundant checks.
13611 2005-06-10 Duncan Mak <duncan@novell.com>
13613 * cs-tokenizer.cs (process_directives): New flag for controlling
13614 the processing of preprocessor directives.
13615 (x_token): After seeing a '#', return Token.NONE instead of going
13616 to handle_preprocessing_directive() when not processing
13617 directives. This avoids unnecessary processing during the token peek in
13622 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13623 the existing error reporting methods instead of Report.Error.
13625 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13626 after Raja's rewrite.
13628 2005-06-08 Miguel de Icaza <miguel@novell.com>
13630 * class.cs: Small fix.
13632 2005-06-08 Raja R Harinath <rharinath@novell.com>
13635 * class.cs (GetPartialBases): Fix return value check of
13636 part.GetClassBases.
13638 2005-06-07 Raja R Harinath <rharinath@novell.com>
13640 Ensure that partial classes are registered in their enclosing
13641 namespace. Initial part of fix of #75160.
13642 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13643 Register declspace with namespace here, not in
13644 DeclSpace.RecordDecl.
13645 * cs-parser.jay: Pass namespace to RecordDecl.
13646 * class.cs (PartialContainer.Create): Likewise.
13647 (ClassPart.DefineType): New sanity-check. Throws an exception if
13649 * decl.cs (Declspace.RecordDecl): Remove.
13650 * namespace.cs (NamespaceEntry.DefineName): Remove.
13652 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13654 * rootcontext.cs: Reset TargetExt as well.
13656 2005-06-03 Raja R Harinath <rharinath@novell.com>
13658 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13659 -langversion:ISO-1.
13661 2005-06-02 Raja R Harinath <rharinath@novell.com>
13663 Fix #75080, cs0119.cs.
13664 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13666 (Expression.Resolve): ... this. Use it. Remove bogus code
13667 allowing ExprClass.Type and ExprClass.Namespace for
13668 ResolveFlags.VariableOrValue.
13669 (Expression.Resolve) [1-argument variant]: Change default resolve
13670 flags based on language version.
13671 (Expression.Error_UnexpectedKind): Use a simple string array
13672 rather than an ArrayList.
13673 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13674 not ExprClass.Type.
13675 (TypeOfVoid.DoResolve): Likewise.
13676 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13677 flags argument -- it always has the same value.
13679 2005-05-31 Raja R Harinath <rharinath@novell.com>
13682 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13683 Use it in the error message.
13684 * assign.cs, expression.cs, statement.cs: Update.
13686 2005-05-30 Raja R Harinath <rharinath@novell.com>
13689 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13690 the "almostMatchedMember" case too.
13691 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13692 that failed the accessibility checks to 'almost_match'.
13694 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13696 * attribute.cs: Use internal MethodBuilder methods to set
13697 ExactSpelling and SetLastError on PInvoke methods, instead
13698 of passing them via charset. Fixes #75060.
13700 2005-05-27 Raja R Harinath <rharinath@novell.com>
13702 * parameter.cs (Parameter): Remove TODO comment.
13703 (Parameter.DefineParameter): Remove Location parameter.
13704 (Parameters.LabelParameters): Likewise.
13705 * class.cs (Constructor.Emit): Update to change.
13706 (MethodData.Emit): Likewise.
13707 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13708 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13710 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13713 Removed Parameters.Location and added Parameter.Location instead.
13714 Removed Location parameter from Emit() and GetSignature().
13721 Modified all related calls.
13723 2005-05-26 Raja R Harinath <rharinath@novell.com>
13725 Improve user-defined conversion handling.
13726 * convert.cs (GetConversionOperators): Rewrite. Return only the
13727 applicable operators.
13728 (AddConversionOperators): New. Helper for GetConversionOperators.
13729 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13730 there is only one most encompassed/encompassing type.
13731 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13732 "applicable operator" handling.
13733 (UserConversion): Move cache here from GetConversionOperators.
13734 Directly cache the chosen operator, rather than the whole
13736 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13737 case. Allow conversion of decimal to sbyte and byte too.
13738 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13739 New static methods. Used to avoid allocating EmptyExpressions in
13742 2005-05-24 Duncan Mak <duncan@novell.com>
13744 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13745 another class, used in Convert.ExplicitNumericConversion.
13746 (CastToDecimal): New class, similar to above, but casts to
13747 System.Decimal, used in Convert.ImplicitNumericConversion and also
13748 in explicit convesion from double/float to decimal.
13750 * convert.cs (ImplicitNumericConversion): Handle implicit
13751 conversions to System.Decimal.
13752 (ExplicitNumericConversion): handle explicit conversions to
13757 2005-05-20 Miguel de Icaza <miguel@novell.com>
13759 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13760 know the type at this stage, just break through. Fixes #75008
13762 2005-05-19 Martin Baulig <martin@ximian.com>
13765 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13766 to disable error reporting.
13768 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13769 here since we don't want to report an error; see the new test-336.cs.
13771 2005-05-19 Raja R Harinath <rharinath@novell.com>
13773 * statement.cs (ToplevelBlock.GetParameterReference)
13774 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13775 Move here from class Block.
13776 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13777 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13779 2005-05-18 Martin Baulig <martin@ximian.com>
13784 (FlowBranching.Reachability): Add non-static public And() and Or()
13786 (FlowBranchingSwitch): New class; do the `break_origins' thing
13787 like in FlowBranchingLoop.
13788 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13789 reachability, not just locals and parameters.
13790 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13791 switch; MergeBreakOrigins() now takes care of that.
13793 2005-05-18 Martin Baulig <martin@ximian.com>
13795 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13796 a loop and may leave it, reset the barrier; fixes #74974.
13798 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13800 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13803 * cs-parser.jay: Catch more lexical errors.
13805 * report.cs: Add one more Error method.
13808 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13810 2005-05-17 Martin Baulig <martin@ximian.com>
13812 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13815 2005-05-16 Raja R Harinath <rharinath@novell.com>
13817 Fix test-382.cs. Emit values of decimal constants.
13818 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13820 (TypeContainer.AddField): ... this.
13821 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13822 with initializers to include 'Const's.
13823 (ClassPart.RegisterFieldForInitialization): Forward to
13825 * const.cs (Const.Const): Pass initializer to base class.
13826 (Const.Define): In case of decimal constants, register them for
13827 initialization in a static constructor.
13829 2005-05-14 Martin Baulig <martin@ximian.com>
13831 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13832 do not call ResolveUnreachable() on unreachable statements in
13833 here, see the comment in the source code.
13835 2005-05-13 Raja R Harinath <rharinath@novell.com>
13838 * expression.cs (BinaryResolveOperator): If one of the operands of
13839 an equality comparison is 'null' and the other is a pointer type,
13840 convert the null to a NullPointer.
13841 * convert.cs (ImplicitReferenceConversion): If the expression is a
13842 NullLiteral and the target type is a pointer type, return a
13843 NullPointer instead.
13844 (ImplicitConversionStandard): Likewise.
13846 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13848 * cs-parser.jay: Set readonly context based on special constructs.
13850 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13851 readonly variable error handling.
13853 * rootcontext.cs (EmitCode): Don't verify members when error
13856 * statement.cs (LocalInfo): Add reaodnly context information.
13857 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13859 2005-05-13 Raja R Harinath <rharinath@novell.com>
13861 * statement.cs (Block.Resolve): Revert change below. Modify fix
13862 for #74041 to initialize 'resolved' to false only for explicit
13863 blocks. Fixes #74873.
13865 2005-05-12 Raja R Harinath <harinath@gmail.com>
13868 * typemanager.cs (unmanaged_enclosing_types): New.
13869 (IsUnmanagedType): Avoid infloops by using
13870 'unmanaged_enclosing_types' to talk with recursive invocations.
13872 2005-05-13 Martin Baulig <martin@ximian.com>
13874 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13875 instance variable, not a local. Fix #74873.
13876 (Block.ResolveUnreachable): Set it to true here.
13878 2005-05-11 Duncan Mak <duncan@novell.com>
13880 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13881 continuing to process for 'arg'.
13882 (handle_preprocessing_directive): Check the argument of the #endif
13883 directive and report error CS1025 if there are any trailing
13886 According to the C# spec, having even whitespace after the #endif
13887 directive is illegal; however, because we call arg.TrimEnd ()
13888 beforehand, we have the same behavior as csc, allowing whitespace
13889 after the directive.
13893 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13897 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13898 (Constructor.GetObsoleteAttribute): Implemented correctly.
13900 2005-05-10 Martin Baulig <martin@ximian.com>
13902 * support.cs (ReflectionParameters.ParameterModifier): Use
13903 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13904 and `ParameterAttributes.In'. Fixes #74884.
13906 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13908 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13910 * expression.cs (Argument.GetParameterModifier): Turned to property.
13911 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13913 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13916 2005-05-09 Raja R Harinath <rharinath@novell.com>
13919 * decl.cs (MemberCache.AddMethods): Register override methods,
13920 rather than non-override methods.
13921 * typemanager.cs (RegisterOverride): New.
13922 (IsOverride): Update.
13924 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13928 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13929 recursive declaration.
13931 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13933 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13935 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13937 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13939 2005-05-05 Raja R Harinath <rharinath@novell.com>
13942 * decl.cs (DeclSpace.FamilyAccessible):
13943 Use TypeManager.IsNestedFamilyAccessible.
13945 Fix reopened #64812.
13946 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13949 2005-05-04 Raja R Harinath <rharinath@novell.com>
13950 Abin Thomas <projectmonokochi@rediffmail.com>
13951 Anoob V E <projectmonokochi@rediffmail.com>
13952 Harilal P R <projectmonokochi@rediffmail.com>
13955 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13956 allow access to all static members.
13958 2005-05-04 Martin Baulig <martin@ximian.com>
13960 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13962 2005-05-04 Martin Baulig <martin@ximian.com>
13966 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13967 section at the end; make things work if `default' is not the last
13970 2005-05-04 Martin Baulig <martin@ximian.com>
13974 * statement.cs (Switch): Replaced the `got_default' field with a
13975 `default_section' one.
13976 (Switch.CheckSwitch): Set `default_section' here.
13977 (Switch.Resolve): If we're a constant switch and the constant is
13978 not found, use the default section.
13980 2005-05-03 Martin Baulig <martin@ximian.com>
13982 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13984 * statement.cs (Foreach.ArrayForeach): New nested class.
13985 (Foreach.TemporaryVariable): New nested class.
13986 (Foreach.EmitArrayForeach): Removed; this is now in the new
13987 ArrayForeach class.
13989 2005-05-03 Raja R Harinath <rharinath@novell.com>
13991 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13993 (VerifyPendingMethods): Revert change below.
13995 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13996 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13997 that used to trigger warning -28. Remove warning -28.
13998 * expression.cs (Invocation.OverloadResolve): Use
13999 TypeManager.IsOverride to distinguish override methods.
14002 * pending.cs (VerifyPendingMethods): If a base type implements the
14003 requested interface, don't bother checking individual methods of
14004 the base type. As a side-effect, this prevents the creation of
14005 unnecessary proxies.
14007 2005-05-02 Martin Baulig <martin@ximian.com>
14011 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14012 Also `And' the locals if the old vector is null.
14013 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14014 null; in this case we basically reset all the variables.
14016 2005-05-02 Martin Baulig <martin@ximian.com>
14020 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14021 Added `FlowBranching branching' argument; always `and' the
14022 variables instead of `or'ing them unless we're an infinite loop.
14024 * statement.cs (While.Resolve): Create a new sibling unless we're
14027 2005-05-02 Martin Baulig <martin@ximian.com>
14031 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14032 arguments; use it instead of creating a new TopLevelBlock.
14033 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14034 our ConstructorInitializer.
14037 (TopLevelBlock.TopLevelBranching): New public property.
14038 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14039 and create our `TopLevelBranching'.
14041 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14042 anonymous method host, use `block.TopLevelBranching' rather than
14043 creating a new branching.
14045 2005-04-20 Miguel de Icaza <miguel@novell.com>
14047 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14048 a ScopeInfo, if any of the current children is a child of the new
14049 entry, move those children there.
14051 2005-04-30 Martin Baulig <martin@ximian.com>
14053 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14054 at the beginning of a SwitchSection. Fix #73335.
14056 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14059 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14061 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14062 (FieldExpr.DoResolve): Obsolete members are ignored for field
14065 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14067 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14068 of arrays detection.
14070 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14072 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14074 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14077 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14079 * cs-parser.jay: Use the prefered version of -unsafe in error
14082 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14084 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14087 2005-04-20 John Luke <john.luke@gmail.com>
14089 * driver.cs: fix typo in error message, --outout to --output
14091 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14093 * codegen.cs (InRefOutArgumentResolving): New field.
14095 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14096 fields outside contructor.
14098 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14100 2005-04-19 Miguel de Icaza <miguel@novell.com>
14102 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14103 parameter code was not completed ever, so it was not as up-to-date
14104 as local variables. Must finish it.
14106 The bug fix was to compare the Toplevel of the block, not the
14107 current block. Thanks for Ben for pointing this out.
14109 2005-04-19 Raja R Harinath <rharinath@novell.com>
14111 * decl.cs (AddMethods): Use the declaring type of the problem
14112 method to determine if we want to squash a warning.
14114 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14116 * attribute.cs: Removed debug output.
14118 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14120 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14123 2005-04-18 Raja R Harinath <rharinath@novell.com>
14126 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14127 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14128 all null comparisons against reference types.
14130 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14133 * class.cs (TypeContainer.CircularDepException) New nested
14135 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14136 (TypeContainer.DefineType): Removed error, reset InTransit before
14138 (Class.DefineType): Throw exception when is in Transit.
14139 Catch exception and report error.
14140 (Struct.DefineType): Throw exception when is in Transit.
14141 Catch exception and report error.
14142 (Interface.DefineType): Throw exception when is in Transit.
14143 Catch exception and report error.
14145 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14146 handle nested exception handlers.
14148 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14151 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14152 InFinally and InCatch storage.
14154 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14155 (Catch.Resolve): Set and Restore ec.InCatch.
14156 (Try.Resolve): Set and Restore ec.InFinally.
14157 (Try.HasCatch): True when try has catch.
14159 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14161 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14162 for the same event member, so exclude such cases from warning 419.
14165 2005-04-16 Miguel de Icaza <miguel@novell.com>
14167 * expression.cs (Binary.ResolveOperator): Apply patch from John
14168 Luke to fix bug 59864: operators &, | and ^ on enumerations
14169 require that the same enum type on both sides.
14171 * driver.cs: Add warnings to old flag usage, this is to assist
14172 people who produce Makefiles and hope that the Makefiles will be
14175 * class.cs (TypeContainer.EmitType): Moved the definition of the
14176 special $PRIVATE$ field from the resolve phase to the Emit phase.
14177 During resolve we do not know if we are a struct with
14178 HasExplicitLayout, we know this only after the attributes for the
14181 Set the FieldOffset to zero on the dummy field that we create for
14182 the class. Fixes 74590.
14184 2005-04-16 Raja R Harinath <rharinath@novell.com>
14187 * ecore.cs (PropertyExpr.resolved): New.
14188 (DoResolve): Use it to handle a case of double resolution here.
14189 Handle a case of identical-name-and-type-name.
14190 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14191 resolution by storing the results of expression resolution back
14192 into the "probes" array.
14194 2005-04-15 Raja R Harinath <rharinath@novell.com>
14196 Fix cs0208-7.cs and cs0208-8.cs.
14197 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14198 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14199 error reporting to point out the reason a struct is not unmanaged.
14201 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14203 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14204 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14206 2005-04-13 Raja R Harinath <rharinath@novell.com>
14209 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14210 IdenticalNameAndTypeName here.
14211 (EventExpr.InstanceResolve): Likewise.
14213 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14215 C# 2.0 DefaultCharSetAttribute implementation
14217 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14218 which allows us to set GlobalNamespace for every resolve.
14219 (Attribute.ResolveArguments): Cut from Resolve.
14220 (Attribute.GetCharSetValue): Returns CharSet named argument.
14221 (Attribute.DefinePInvokeMethod): Gets default charset from
14223 (GlobalAttribute.ResolveAsTypeStep): Override.
14224 (GlobalAttribute.ResolveArguments): Override.
14226 * class.cs (TypeAttr): Is protected.
14228 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14229 (ModuleClass.DefaultCharSetType): New memeber.
14230 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14232 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14233 charset from module.
14235 * delegate.cs (TypeAttr): Override.
14236 (Delegate.DefineType): Use this TypeAttr.
14238 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14239 at very early stage (before types are defined) to resolve model
14240 module attributes. It will probably not work with corlib but it
14243 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14244 charset from module.
14246 * typemanager.cs (default_charset_type): New type.
14248 2005-04-13 Raja R Harinath <rharinath@novell.com>
14250 * decl.cs (MemberCache.AddMethods): Don't warn if
14251 System.Object.Finalize has buggy MethodAttributes.
14253 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14256 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14258 * doc.cs : detect ambiguous reference to overloaded members.
14259 Fixed bug #71603. MS 1.1 csc does not detect it.
14261 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14263 * doc.cs : delegates must not be referenced with parameters.
14266 2005-04-12 Miguel de Icaza <miguel@novell.com>
14268 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14270 2005-04-10 Miguel de Icaza <miguel@novell.com>
14272 * driver.cs (MainDriver): Stop processing if the CLS stage found
14275 (CompilerCallableEntryPoint.InvokeCompiler): Always
14276 reset after execution; Take a TextWriter argument for the
14279 * report.cs: Use the error stream instead of hardcoding stderr.
14281 2005-04-09 Miguel de Icaza <miguel@novell.com>
14283 * class.cs: Reduce code paths to test, too small of an
14284 optimization to make it worth the extra testing. Always perform
14287 2005-04-08 Raja R Harinath <rharinath@novell.com>
14290 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14291 operators that had errors reported on them.
14293 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14295 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14297 (Attribute.Resolve): Add named argument type checking.
14299 * class.cs (FixedField.Define): Use IsPrimitiveType
14301 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14303 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14304 unsafe parameter types.
14306 * statement.cs (Using.ResolveExpression): Add better error description.
14308 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14310 2005-04-08 Raja R Harinath <rharinath@novell.com>
14313 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14314 AttributeUsageAttribute in the emitcontext of the attribute class,
14315 not in the emitcontext of the attributable entity it was attached to.
14316 * cs-parser.jay: Use 'current_class', not 'current_container',
14317 when creating a GlobalAttribute.
14319 2005-04-08 Alp Toker <alp@atoker.com>
14321 * pending.cs: The fix to #58413 failed to compile methods implementing
14322 interfaces with/without params modifiers and vice versa, even though
14323 params modifiers aren't part of the signature. Make the modifier check
14324 less strict as in csc.
14326 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14327 Anoob V E <projectmonokochi@rediffmail.com>
14328 Harilal P R <projectmonokochi@rediffmail.com>
14331 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14332 modifiers of pending methods.
14333 (PendingImplementation.PendingImplementation): Initialize it.
14334 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14335 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14336 with ParameterData. Add check for modifiers.
14337 * class.cs (MethodData.Define): Update to changes.
14339 2005-04-07 Raja R Harinath <rharinath@novell.com>
14341 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14343 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14345 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14348 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14351 * typemanager.cs: Registered RequiredAttributeAttribute.
14353 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14355 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14356 Warning CS0169 is back at level 3.
14357 (IMethodData.SetMemberIsUsed): New method.
14359 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14360 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14362 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14364 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14366 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14369 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14372 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14373 to avoid the problems with nested types.
14375 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14376 Anoob V.E <projectmonokochi@rediffmail.com>
14377 Harilal P.R <projectmonokochi@rediffmail.com>
14378 Raja R Harinath <rharinath@novell.com>
14381 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14383 * typemanager (GetConstructor): Make public.
14385 2005-04-05 John Luke <john.luke@gmail.com>
14386 Raja R Harinath <rharinath@novell.com>
14389 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14390 struct too. Return false quicker in a few cases.
14391 (VerifyUnManaged): Use it.
14393 2005-04-05 Raja R Harinath <rharinath@novell.com>
14396 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14397 not 'unreachable_seen'.
14399 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14401 * attribute.cs (Attribute.GetValue): Removed unused.
14403 * codegen.cs (CodeGen.TrimExt): Removed unused.
14405 * cs-parser.jay (output): Removed unused.
14407 * cs-tokenizer.cs (hex_digits): Removed unused.
14409 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14411 * expression.cs (Indirection.LoadExprValue): Removed unused.
14412 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14414 * iterators.cs (Iterator.param_types): Removed unused.
14416 * statement.cs (Goto.block): Removed unused.
14417 (ToplevelBlock.did): Removed unused.
14418 (Switch.ResolveConstantSwitch): Removed unused.
14420 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14422 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14425 2005-04-01 Raja R Harinath <rharinath@novell.com>
14427 Fix #74232 and cs0208-3.cs.
14428 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14429 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14430 unmanaged type. Don't use FieldBuilders when 't' is a
14431 TypeBuilder. Use ModFlags and MemberType fields.
14432 * class.cs (MemberBase.member_type): Rename from MemberType.
14433 (MemberBase.MemberType): New property. Determines member_type on
14435 (MemberBase.DoDefine): Don't initialize MemberType here.
14436 (FieldMember.Define): Likewise.
14438 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14441 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14442 Attributes are emitted there.
14444 2005-04-01 Raja R Harinath <rharinath@novell.com>
14446 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14447 keyword in 'partial enum' too.
14448 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14450 Report from Kamil Skalski <nazgul@omega.pl>.
14453 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14454 have partial containers too.
14456 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14457 in block' checks to Block.CheckInvariantMeaningInBlock.
14458 * statement.cs (Block.GetKnownVariableInfo): Make private.
14459 (Block.IsVariableUsedInChildBlock): Remove.
14460 (Block.IsVariableUsedInBlock): Likewise.
14461 (Block.CheckInvariantMeaningInBlock): New. Show location of
14462 conflicting declaration.
14463 (Block.AddVariable): Make error messages less long-winded and more
14464 specific. Show location of conflicting declaration.
14465 * parameter.cs (Parameters.Location): New readonly property.
14467 2005-03-31 Raja R Harinath <rharinath@novell.com>
14469 Clean up semantics of invoking ResolveMemberAccess.
14470 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14471 can have an instance, ensure that we pass in a non-TypeExpression
14472 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14473 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14474 argument. Update to changes and simplify.
14475 (FieldExpr.Emitinstance): Remove CS0120 check.
14476 (PropertyExpr.EmitInstance): Likewise.
14477 * expression.cs (Argument.Resolve): Likewise.
14478 (Invocation.DoResolve): Update to changes in semantics of
14479 InstanceExpression.
14481 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14484 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14487 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14489 2005-03-31 Raja R Harinath <rharinath@novell.com>
14491 Fix difference in behaviour with commandline invocation.
14492 * driver.cs (Driver.Reset): New.
14493 (CompilerCallableEntryPoint): Call it.
14495 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14496 variable" warnings if the boolean expression failed to resolve.
14498 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14500 * attribute.cs: Fix the union of several permissions when some of them
14501 are unrestricted (so the result isn't an unrestricted permission set).
14504 2005-03-30 Raja R Harinath <rharinath@novell.com>
14506 * ecore.cs (MemberExpr): New class. Convert from interface
14508 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14509 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14511 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14512 (MethodGroupExpr.IsExplicitImpl): Remove.
14513 (Expression.GetFieldFromEvent): Remove.
14514 (SimpleName.MemberStaticCheck): Remove.
14515 (SimpleName.DoSimpleNameResolve): Update to changes.
14516 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14517 (MemberAccess.IdenticalNameAndTypeName): Remove.
14518 (MemberAccess.error176): Move to MemberExpr.
14519 (MemberAccess.DoResolve): Update to changes.
14520 (BaseAccess.DoResolve): Likewise.
14522 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14524 C# 2.0 Conditional attribute class implementation
14526 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14527 Analyzes class whether it has attribute which has ConditionalAttribute
14528 and its condition is not defined.
14530 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14531 (Class.IsExcluded): New method. Search for at least one defined
14532 condition in ConditionalAttribute of attribute class.
14534 2005-03-30 Raja R Harinath <rharinath@novell.com>
14536 * ecore.cs (PropertyExpr): Derive from Expression, not
14537 ExpressionStatement.
14538 (PropertyExpr.EmitStatement): Remove.
14540 2005-03-29 Raja R Harinath <rharinath@novell.com>
14543 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14544 internal field "value__" of an enum be private. The examples for
14545 "value__" that I found on MSDN all used FieldAttributes.Private.
14547 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14548 Don't mention IL method attribute names.
14550 Fix #47991. Remove a TODO.
14551 * statement.cs (Block.Toplevel): Make into a field.
14552 (Block.Parameters): Move into ToplevelBlock.
14553 (Block.known_variables): Rename from child_variable_names.
14554 (Block.Block): Remove variants that take Parameters. Initialize
14555 'Toplevel' with the immediately surrounding toplevel block.
14556 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14557 LocalInfo parameter.
14558 (Block.GetKnownVariableInfo): New.
14559 (Block.IsVariableNameUsedInChildBlock): Update.
14560 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14561 the block, even though it may not be in scope.
14562 (Block.AddVariable): Remove Parameters parameter. Use
14563 Toplevel.Parameters instead.
14564 (Block.AddConstant): Remove Parameters parameter.
14565 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14566 (Block.IsParamaterReference): Likewise.
14567 (Block.IsLocalParameter): Likewise. Simplify a lot.
14568 (ToplevelBlock.Parameters): New. Moved from Block.
14569 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14570 initialize Parameters to a non-null value.
14571 * cs-parser.jay: Update to changes.
14572 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14573 simple names that mean different things in the same block. Use
14574 Block.IsVariableNameUsedInBlock.
14576 2005-03-28 Raja R Harinath <rharinath@novell.com>
14578 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14579 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14580 GetTypeHandle. It is possible for a reflected type to derive from
14581 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14582 System.Array during mscorlib compilation).
14583 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14584 contain a method_hash, don't create one either. Don't create a
14585 deep copy of the base cache's method_hash.
14586 (MemberCache.SetupCache): Rename back from DeepCopy.
14587 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14588 already initialized. If we see an override function, add its
14589 underlying base virtual function to the member_hash too.
14591 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14593 2005-03-26 Raja R Harinath <harinath@acm.org>
14596 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14597 fails to resolve, ensure that the LHS is still resolved as an
14600 2005-03-25 Raja R Harinath <harinath@acm.org>
14602 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14604 (Enum.current_ec): Remove.
14605 (Enum.LookupEnumValue): Remove EmitContext argument.
14606 Just uses the one created during DefineType.
14607 (Enum.FindMembers): Update.
14608 * expression.cs (MemberAccess.DoResolve): Update.
14610 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14612 * assign.cs (Assign.DoResolve): Check for CS1717 when
14613 source and target are same (uses Equals).
14615 * expression.cs (LocalVariableReference, ParameterReference,
14616 This): Implemented Equals, GetHashCode.
14618 * statement.cs (Block.GetParameterReference): Removed useless
14621 2005-03-22 Raja R Harinath <rharinath@novell.com>
14624 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14625 blocks before deciding whether the error is cs0136 or cs0128.
14627 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14628 (using_alias_directive, using_namespace_directive): Pass
14629 MemberName, not an expression to Namespace.UsingAlias and
14631 (MakeName): Use the MemberName of the namespace.
14632 * namespace.cs (Namespace.MemberName): New.
14633 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14634 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14636 * decl.cs (MemberName.Name): Make readonly.
14637 (MemberName.FromDotted): New "constructor".
14638 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14639 (MemberCore.Name): Compute from MemberName on demand.
14640 (MemberCore.SetMemberName): Provide a way to change the
14642 (MemberCore.AddToContainer): Don't take a fullname parameter.
14643 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14644 fully qualified name of the container to the member name.
14645 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14646 only if the type is a member of the root container.
14647 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14648 MemberName.Left rather than searching for an embedded ".".
14649 (PartialContainer.CreatePart): Update to changes in RootContext.
14650 (MemberBase.ShortName): Turn into a property. Use
14651 MemberCore.SetMemberName.
14652 (MemberBase.ExplicitInterfaceName): Remove.
14653 (MemberBase.UpdateMemberName): Remove.
14654 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14655 (PropertyBase.SetMemberName): New override.
14656 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14657 (Tree.GetDecl): New.
14658 (Tree.AllDecls): Rename from Decls.
14659 * attribute.cs, enum.cs, report.cs: Update to changes.
14660 * driver.cs (MainDriver): Use MemberName.FromDotted on
14661 RootContext.MainClass.
14663 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14665 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14668 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14670 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14672 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14673 property accessor modifiers.
14675 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14676 fixed buffer attribute (CS1716).
14677 (PropertyMethod.HasCustomAccessModifier): When property accessor
14678 has custom modifier.
14680 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14682 (PropertyExpr.DoResolveLValue): Add CS0272.
14684 2005-03-17 Miguel de Icaza <miguel@novell.com>
14686 * convert.cs: When converting to a pointer, use the proper Conv.U
14687 or Conv.I depending on the source data type.
14689 * cs-tokenizer.cs: Make the size for large decimal constants,
14692 2005-03-17 Martin Baulig <martin@ximian.com>
14694 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14695 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14697 2005-03-17 Martin Baulig <martin@ximian.com>
14699 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14700 to bool so we can return an error condition.
14701 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14704 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14706 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14709 2005-03-16 Raja R Harinath <rharinath@novell.com>
14711 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14712 Refactor to avoid traversing the list of assemblies, and to avoid
14713 string concatenation.
14714 * typemanager.cs (guid_attr_type): Remove.
14715 (negative_hits, pointers, references): Remove hashes.
14717 (GetConstructedType): New. Uses type_hash to handle constructed
14718 types (arrays, references, pointers).
14719 (GetReferenceType, GetPointerType): Use it.
14720 (GetNestedType): New. Uses type_hash to handle nested types of
14722 (LookupType, LookupTypeDirect): Remove.
14723 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14724 'types' hash and LookupTypeReflection directly.
14725 (params_string, params_object): Use GetConstructedType.
14726 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14728 (Namespace.Lookup): Use cached_types.
14729 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14730 provided by old TypeManager.LookupType.
14731 * rootcontext.cs (MakeFQN): Remove.
14732 * decl.cs (DeclSpace.MakeFQN): Likewise.
14733 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14734 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14735 TypeManager.GetConstructedType.
14736 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14738 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14740 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14743 * cs-parser.jay: Reports CS1527 for any namespace element.
14745 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14748 * expression.cs (ParameterReference.IsAssigned): Changed error to
14750 (Error_WrongNumArguments): Moved CS0245 detection here.
14752 * statement.cs (Return.Resolve): Add CS1622 report.
14754 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14756 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14758 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14760 * attribute.cs expression.cs: Get rid of some allocations.
14762 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14764 * doc.cs : just eliminate the latest change.
14766 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14768 * doc.cs : commented out the latest change. It breaks xml-030.cs
14770 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14772 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14773 fail. So invoke CreateType() in FindDocumentedType().
14775 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14777 * cs-tokenizer.cs : added IsKeyword().
14778 * doc.cs : Detect keyword incorrectly used as identifier.
14779 Allow identifiers prefixed by @.
14781 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14783 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14784 It caused exception in namespace resolving (again!).
14786 * class.cs (Class.ctor): Removed exit.
14787 (PropertyMethod.ctor): ditto.
14789 * codegen.cs (Codegen.Reset): Reset static data.
14790 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14792 * cs-tokenizer.cs (Cleanup): Removed.
14794 * driver.cs (GetSystemDir): Rewrote to one line command.
14795 It caused problem with unloaded dynamic modules.
14796 (UnixParseOption): Removed Exit.
14797 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14798 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14799 Now can be mcs used as library.
14801 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14804 * location.cs (Reset): Reset static data.
14806 * namespace.cs (Reset): Reset static data.
14808 * report.cs (Report.Reset): Reset static data.
14810 * rootcontext.cs (RootContext.Reset): Reset static data.
14812 * tree.cs (RootTypes.ctor): Use Location.Null
14814 * typemanager.cs (TypeManager.Reset): Reset static data.
14815 (CoreLookupType): Removed Exit.
14816 (TypeHandle.Reset): Reset static data.
14818 2005-03-10 Raja R Harinath <rharinath@novell.com>
14821 * typemanager.cs (ComputeNamespaces): Import namespaces from
14822 referenced modules too.
14824 2005-03-09 Raja R Harinath <rharinath@novell.com>
14826 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14829 2005-03-09 Raja R Harinath <rharinath@novell.com>
14831 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14832 enclosing DeclSpace. This ensures that a name-lookup populates
14833 more caches and there are fewer 'TypeExpression's. Carve out
14834 nested type lookup into ...
14835 (LookupNestedTypeInHierarchy): ... this.
14837 2005-03-09 Raja R Harinath <rharinath@novell.com>
14839 Clean up a few partial-class semantics.
14840 Fixes test-357.cs and cs1618-2.cs.
14841 * cs-parser.jay (struct_declaration): Use 'current_class' as
14842 parent of newly-created struct. Remove call to Register ().
14843 Use 'pop_current_class' to complete handing the current struct.
14844 (interface_declaration): Likewise.
14845 (class_declaration): Likewise.
14846 (enum_declaration): Use 'current_class' as parent of newly created
14848 (delegate_declaration): Likewise.
14849 (pop_current_class): New function. This is used to handle closing
14850 up the 'current_class' and 'current_container', and pointing them
14851 to the enclosing class/container.
14852 (CSharpParser): Initialize 'current_class' too.
14853 * decl.cs (MemberCore): Add check for invariant: a partial
14854 container is not a parsed entity, and thus does not enclose any
14856 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14857 (DeclSpace.BaseTypeExpr): Use it.
14858 (DeclSpace.LookupType): Add check for invariant.
14859 * class.cs (TypeContainer): Add check for invariant: a nested
14860 class should have the same NamespaceEntry as its enclosing class.
14861 (TypeContainer.EmitFieldInitializers): Make virtual.
14862 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14864 (TypeContainer.Register): Remove.
14865 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14866 null. Use TypeResolveEmitContext for resolving base types and
14867 interfaces. Move initialization of Parts.TypeBuilder here from
14869 (TypeContainer.DefineNestedTypes): ... here.
14870 (PartialContainer): Take a Namespace not a NamespaceEntry.
14871 (PartialContainer.Create): Don't use Register. Call the
14872 appropriate Add... function directly.
14873 (ClassPart): Take both the PartialContainer and the enclosing
14874 class as constructor arguments.
14875 (ClassPart.EmitFieldInitializers): Override.
14876 (ClassPart.PartFindNestedTypes): Remove.
14877 (FieldBase.GetInitializerExpression): Resolve the initializer
14878 expression in the emit context of the enclosing class.
14879 * tree.cs (RootTypes): Remove Register ().
14881 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14883 * cs-parser.jay: Removed CS0134.
14885 * driver.cs: Removed CS1901.
14887 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14888 for predefined types.
14890 2005-03-07 Duncan Mak <duncan@novell.com>
14892 * codegen.cs (Save): Catch UnauthorizedAccessException as
14893 well. Fixes bug #73454.
14895 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14897 * cs-tokenizer.cs (xtoken): Add CS1035.
14899 * class.cs (MethodData.Define): Add CS0683.
14900 (FieldMember.ctor): Add CS0681.
14902 2005-03-07 Raja R Harinath <rharinath@novell.com>
14904 * ecore.cs (SimpleName.DoResolve): Rename from
14905 SimpleName.DoResolveAllowStatic.
14906 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14907 Pass 'intermediate' flag to MemberStaticCheck.
14908 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14909 of "intermediate" lookups via MemberAccess.
14910 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14911 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14913 2005-03-07 Raja R Harinath <rharinath@novell.com>
14916 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14917 slipped in because of variable names that are identical to a
14918 builtin type's BCL equivalent ('string String;', 'int Int32;').
14919 (PropertyExpr.EmitInstance): Likewise.
14921 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14923 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14925 * report.cs (warning_ignore_table): Made public.
14927 2005-03-04 Raja R Harinath <rharinath@novell.com>
14930 * class.cs (MethodData.Emit): Pass 'container' to
14931 container.GetObsoleteAttribute instead of 'container.Parent'.
14933 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14935 * cs-parser.jay: Add 1534 error test.
14937 * iterators.cs (Yield.CheckContext): Add error 1629.
14938 (Iterator.ctor): Save unsafe modifier.
14939 (MoveNextMethod.DoEmit): Restore unsafe context.
14941 * namespace.cs (UsingAlias): Better error message.
14943 2005-03-03 Dan Winship <danw@novell.com>
14945 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14946 the warning message [#73219]
14948 2005-03-03 Raja R Harinath <rharinath@novell.com>
14950 Fix compile with MCS 1.0.0.0.
14951 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14952 w_restore to not depend on string constant folding.
14954 2005-03-03 Raja R Harinath <rharinath@novell.com>
14956 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14957 CS0246 check to users who passed 'silent = false'.
14958 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14960 (SimpleName.SimpleNameResolve): Update.
14961 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14962 (MemberAccess.IdenticalNameAndTypeName): Update.
14963 * doc.cs (FindDocumentedTypeNonArray): Update.
14965 2005-03-03 Raja R Harinath <rharinath@novell.com>
14967 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14968 * parameters.cs (ComputeAndDefineParameters): Remove.
14969 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14970 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14971 Use GetParameterInfo.
14973 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14975 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14977 2005-03-02 Raja R Harinath <rharinath@novell.com>
14979 Unify DeclSpace.LookupType and DeclSpace.FindType.
14980 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14981 is in charge of defining nested types on demand.
14982 (DeclSpace.LookupType): Use it when the current_type is a
14983 TypeBuilder. Use LookupTypeDirect for reflected types.
14984 (DeclSpace.FindType): Remove.
14985 (DeclSpace.LookupInterfaceOrClass): Likewise.
14986 (DeclSpace.DefineTypeAndParents): Likewise.
14987 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14988 DeclSpace.LookupType.
14989 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14990 * typemanager.cs (LookupType): Simplify.
14991 (AddUserType): Remove type from negative_hits.
14992 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14993 * class.cs (TypeContainer.FindMembers): Move handling of nested
14995 (TypeContainer.FindMembers_NestedTypes): ... here.
14996 (TypeContainer.FindNestedType): Implement override.
14997 (ClassPart.FindNestedType): Delegate to PartialContainer.
14998 (ClassPart.PartFindNestedType): Looks up the nested types of the
15001 2005-03-02 Martin Baulig <martin@ximian.com>
15003 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15004 static constructor in static classes.
15006 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15008 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15009 sizeParamIndex is not specified.
15011 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15014 * report.cs (WarningMessage.IsEnabled): Missing null check.
15016 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15018 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15019 in the fields and not in the properties.
15021 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15023 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15026 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15028 * attribute.cs: Small refactoring (improved robustness).
15029 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15030 (ValidateGuid): Removed.
15031 (Resolve): Removed referenced to above mentioned.
15032 (GetAttributeUsage): Made private and changed to work without
15034 (GetIndexerAttributeValue): Don't crash.
15035 (GetConditionalAttributeValue): Ditto.
15036 (GetClsCompliantAttributeValue): Ditto.
15037 (ExtractSecurityPermissionSet): All attributes exceptions are
15039 (GetPropertyValue): New helper.
15040 (GetMethodImplOptions): New method.
15041 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15042 some missing properties.
15044 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15045 (Method.ApplyAttributeBuilder): Updated.
15047 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15050 2005-02-28 Raja R Harinath <rharinath@novell.com>
15053 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15054 non-simple types (array, pointer, reference).
15056 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15058 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15060 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15062 (Method.CheckBase): Catch wrong destructor here.
15063 (MethodData.Define): Add errors 550, 668.
15065 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15067 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15069 * pending.cs (VerifyPendingMethods): Add error 551.
15071 * typemanager.cs (CSharpName): Next error report helper.
15073 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15075 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15076 attributes. Removed useless attribute double check.
15077 It saves almost 2MBs for corlib.
15079 2005-02-25 Raja R Harinath <rharinath@novell.com>
15082 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15083 called twice in case of error.
15085 2005-02-23 Chris Toshok <toshok@ximian.com>
15087 Fix compiler portions of #72827.
15088 * statement.cs (Block.Emit): call Begin/EndScope on the
15089 EmitContext instead of the ILGenerator.
15091 * codegen.cs (EmitContext.BeginScope): new method, call
15092 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15094 (EmitContext.BeginScope): same, but EndScope and CloseScope
15096 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15097 offset and call the superclass's OpenScope(int) with it.
15098 (SymbolWriter.CloseScope): get the current il
15099 offset and call superclass's CloseScope(int) with it.
15101 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15103 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15104 CS1677 for out and ref as well.
15106 * class.cs (Method.Define): Add error CS1599 detection.
15108 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15110 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15112 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15114 * support.cs.cs (ModifierDesc): New helper method.
15116 2005-02-23 Raja R Harinath <rharinath@novell.com>
15117 Abin Thomas <projectmonokochi@rediffmail.com>
15118 Anoob V E <projectmonokochi@rediffmail.com>
15119 Harilal P R <projectmonokochi@rediffmail.com>
15121 Fix #57851, #72718.
15122 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15123 MemberLookup (used for error reporting) actually returns a result.
15124 Fix error report number (122, not 112).
15126 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15127 Anoob V E <projectmonokochi@rediffmail.com>
15128 Harilal P R <projectmonokochi@rediffmail.com>
15131 * pending.cs (PendingImplementation.GetAbstractMethods):
15132 Find NonPublic members too.
15134 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15136 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15139 * class.cs (MethodCore.CheckMethodAgainstBase):
15140 Add error 239 report.
15142 2005-02-21 Raja R Harinath <rharinath@novell.com>
15145 * expression.cs (Invocation.IsApplicable): Make public.
15146 (Invocation.IsParamsMethodApplicable): Likewise.
15147 * delegate.cs (Delegate.VerifyApplicability): Don't use
15148 Invocation.VerifyArgumentCompat for parameter applicability
15149 testing. Use Invocation.IsApplicable and
15150 Invocation.IsParamsMethodApplicable.
15152 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15154 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15156 * class.cs (Operator.Define): Add error 217 report.
15158 2005-02-21 Raja R Harinath <rharinath@novell.com>
15160 * namespace.cs (UsingEntry.Resolve): Undo change below.
15162 2005-02-21 Raja R Harinath <rharinath@novell.com>
15165 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15166 disable the error message when the extended MemberLookup also
15168 (Expression.MemberLookupFinal): Update.
15169 (SimpleName.DoSimpleNameResolve): Update.
15170 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15171 Don't use MemberLookupFinal.
15172 (New.DoResolve): Update.
15173 (BaseAccess.CommonResolve): Update.
15175 2005-02-21 Raja R Harinath <rharinath@novell.com>
15178 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15179 occured previously, don't resolve again.
15181 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15184 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15185 argument. Call ResolveAttributeUsage for unresolved.
15186 when types doesn't match ctor arguments.
15188 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15189 for nested attribute classes.
15190 (Class.attribute_usage): Removed.
15191 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15192 for attribute class.
15194 * ecore.cs (IsAttribute): Removed.
15196 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15198 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15200 (attribute_types): Removed.
15201 (EmitCode): Global attributes are emited as the latest.
15203 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15205 * class.cs (EmitFieldInitializers): Don't emit field initializer
15206 for default values when optimilization is on.
15208 * constant.cs (Constant.IsDefaultValue): New property.
15210 * driver.cs: Add /optimize handling.
15214 * literal.cs: Implement new IsDefaultValue property.
15216 * rootcontext.cs (Optimize): New field, holds /optimize option.
15218 2005-02-18 Raja R Harinath <rharinath@novell.com>
15220 Fix crasher in re-opened #72347.
15221 * namespace.cs (Namespace.Lookup): Return null if
15222 DeclSpace.DefineType returns null.
15225 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15227 2005-02-18 Raja R Harinath <rharinath@novell.com>
15229 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15230 now returns null if it cannot resolve to an lvalue.
15231 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15232 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15233 returned null. Remove check for SimpleName.
15234 (EventExpr.DoResolveLValue): New.
15235 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15236 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15238 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15239 avoid CS0131 error.
15240 (Unary.ResolveOperator): Move CS0211 check ...
15241 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15243 (Unary.DoResolveLValue): Simplify.
15244 (AddressOf.DoResolveLValue): New.
15245 (ArrayAccess.DoResolveLValue): New.
15247 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15249 * attribute.cs (Attribute.Resolve): Add arguments casting for
15250 when types doesn't match ctor arguments.
15252 2005-02-16 Raja R Harinath <rharinath@novell.com>
15254 Fix parts of #63202.
15255 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15256 lookup of operator in base type. Ensure that all checks happen
15257 when the operator resolves to an "op_..." method.
15259 2005-02-15 Raja R Harinath <rharinath@novell.com>
15262 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15263 'ignore_cs0104' parameter. Pass it to ...
15264 (NamespaceEntry.Lookup): ... this.
15265 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15266 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15267 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15268 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15269 Update. Request that cs0104 errors be ignored.
15270 (ComposedCast.ResolveAsTypeStep): Update.
15272 2005-02-14 Raja R Harinath <rharinath@novell.com>
15275 * expression.cs (Invocation.BetterFunction): Remove support for
15276 comparing virtual functions and their overrides.
15277 (Invocation.IsOverride): New.
15278 (Invocation.OverloadResolve): Don't consider 'override' functions
15279 during candidate selection. Store them in a lookaside list.
15280 If the selected method is a 'virtual' function, use the list to
15281 find any overrides that are closer to the LHS type.
15283 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15285 * expression.cs (New.DoResolve): Add complex core type reduction.
15286 (New.Constantify): Converts complex core type syntax like 'new int ()'
15287 to simple constant.
15289 2005-02-14 Raja R Harinath <rharinath@novell.com>
15291 * decl.cs (EntryType.EntryType): New constructor to create an
15292 updated copy of a cache entry.
15293 (MemberCache.AddMethods): Use it.
15294 (MemberCache.ClearDeclaredOnly): Remove.
15295 (MemberCache.MemberCache): Update.
15297 2005-02-11 Miguel de Icaza <miguel@novell.com>
15299 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15300 variable. This one is represents the actual low-level declaration
15301 of the method, as opposed to the semantic level `IsStatic'.
15303 An anonymous method which is hosted into a static method might be
15304 actually an instance method. IsStatic would reflect the
15305 container, while MethodIsStatic represents the actual code
15308 * expression.cs (ParameterReference): Use the new MethodIsStatic
15309 instead of IsStatic.
15311 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15312 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15313 set on the current EmitContext.
15315 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15316 resolve our casted expression as an LValue. This triggers the
15317 proper LValue processing that is later required by Assign.
15321 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15323 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15325 C# 2.0 Fixed buffer implementation
15327 * anonymous.cs: Update after RegisterHelperClass renaming.
15329 * attribute.cs (AttributeTester.fixed_buffer_cache):
15330 Cache of external fixed buffers.
15331 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15332 implementation if field is fixed buffer else null.
15335 (TypeContainer.AddField): Accept FieldMember instead of Field.
15336 (FieldBase.IsFieldClsCompliant): Extracted code from
15337 VerifyClsCompliance descendant customization.
15338 (FixedField): New class handles fixed buffer fields.
15339 (FixedFieldExternal): Keeps information about imported fixed
15341 (IFixedField): Make access to internal or external fixed buffer
15344 * cs-parser.jay: Add fixed buffer parsing.
15346 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15349 * expression.cs (Indirection): Extended implementation to accept
15350 fixed buffer field.
15351 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15352 (ElementAccess.MakePointerAccess): Get type as parameter.
15353 (DoResolve): Add fixed buffer field expression conversion.
15354 (DoResolveLValue): Ditto.
15355 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15356 (ArrayPtr): Derives from FixedBufferPtr.
15357 (ArrayPtr.Emit): Add extra emit for array elements.
15359 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15361 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15362 for compiler generated types.
15363 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15365 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15366 and consume less memory.
15367 (Fixed.Resolve): Add fixed buffer case.
15369 * typemanager.cs (compiler_generated_attr_ctor,
15370 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15371 (HasElementType): Add our own implementation to work on every
15374 2005-02-11 Miguel de Icaza <miguel@novell.com>
15376 * anonymous.cs (CaptureContext): Track whether `this' has been
15379 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15380 only captured `this' if it was implicitly done (instance
15381 methods/variables were used).
15383 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15384 `this' must be captured.
15386 2005-01-30 Miguel de Icaza <miguel@novell.com>
15388 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15389 is null it means that there has been no need to capture anything,
15390 so we just create a sibling.
15392 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15394 Just a partial fix. The other half is fairly elusive.
15396 2005-02-10 Raja R Harinath <rharinath@novell.com>
15398 Fix #52586, cs0121-4.cs.
15399 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15400 and return a hashtable.
15401 (MemberCache.ClearDeclaredOnly): New.
15402 (MemberCache.MemberCache): Update to change. Make a deep copy of
15403 the method_hash of a base type too.
15404 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15405 type methods. Overwrite entries with the same MethodHandle so
15406 that the ReflectedType is correct. The process leaves in base
15407 virtual functions and their overrides as distinct entries.
15408 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15409 matters since it was boxed in a ArrayList before.
15410 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15412 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15413 case of a virtual function and its override (choose the overload
15415 (Invocation.OverloadResolve): Avoid 'override' members during
15416 'applicable_type' calculation.
15418 2005-02-09 Raja R Harinath <rharinath@novell.com>
15420 Combine two near-redundant caches.
15421 * typemanager.cs (method_params): Rename from method_internal_params.
15422 (TypeManager.GetParameterData): New. Replace
15423 Invocation.GetParameterData.
15424 (TypeManager.LookupParametersByBuilder): Remove.
15425 * expression.cs (Invocation.method_parameter_cache): Remove.
15426 (Invocation.GetParameterData): Remove.
15428 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15431 2005-02-08 Raja R Harinath <rharinath@novell.com>
15434 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15435 TypeManager.multicast_delegate_type is null, resolve it by looking
15436 up "System.MulticastDelegate".
15437 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15439 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15440 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15441 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15444 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15445 (LabeledStatement.AddReference): New. Set 'referenced'.
15446 (Goto.Resolve): Use it.
15448 2005-02-05 John Luke <john.luke@gmail.com>
15450 * driver.cs: remove duplicate -doc line in Usage ()
15452 2005-02-04 Raja R Harinath <rharinath@novell.com>
15454 * location.cs (Location.AddFile): Fix CS2002 error report.
15456 2005-02-02 Martin Baulig <martin@ximian.com>
15458 * delegate.cs (Delegate.DefineType): Report an internal error if
15459 TypeManager.multicast_delegate_type is null. See bug #72015 for
15462 2005-02-02 Raja R Harinath <rharinath@novell.com>
15464 Fix a crasher in a variant of #31984.
15465 * const.cs (Constant.CheckBase): New override that defers the
15466 new-or-override check in case the base type hasn't been populated
15468 (Constant.Define): Ensure the new-or-override check is performed.
15470 2005-02-01 Duncan Mak <duncan@ximian.com>
15472 * const.cs (LookupConstantValue): Check that `ce' is not null
15473 before calling GetValue ().
15475 2005-02-01 Raja R Harinath <rharinath@novell.com>
15477 Fix test-334.cs (#69519).
15478 * cs-parser.jay (using_alias_directive): Pass in an expression to
15479 NamespaceEntry.UsingAlias.
15480 (using_namespace_directive): Pass in an expression to
15481 NamespaceEntry.Using.
15482 (namespace_name): Don't flatten to a string.
15483 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15484 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15486 (NamespaceEntry.UsingEntry): Likewise.
15487 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15489 (NamespaceEntry.LookupForUsing): Remove.
15490 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15492 (NamespaceEntry.Lookup): Remove support for dotted names.
15494 2005-02-01 Raja R Harinath <rharinath@novell.com>
15496 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15498 (NamespaceEntry.ImplicitParent): Compute on demand.
15499 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15500 parallels the current.
15501 (NamespaceEntry.LookupForUsing): Use it.
15502 (NamespaceEntry.Lookup): If the current namespace-entry is
15503 implicit, don't search aliases and using tables.
15505 2005-02-01 Raja R Harinath <rharinath@novell.com>
15508 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15510 (TypeContainer.BaseCache): Compute on demand.
15511 (TypeContainer.FindMembers): Define constants and types if they're
15512 not already created.
15513 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15515 * const.cs (Constant.Define): Make idempotent.
15517 2005-01-29 Miguel de Icaza <miguel@novell.com>
15519 * pending.cs: Produce better code (no nops produced by using Ldarg
15522 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15523 i - 1' it should be arg + 1.
15527 2005-01-28 Raja R Harinath <rharinath@novell.com>
15529 * attribute.cs (Attribute.CheckAttributeType): Make private
15531 (Attribute.ResolveType): Make virtual.
15532 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15533 handling of RootContext.Tree.Types.
15535 2005-01-27 Raja R Harinath <rharinath@novell.com>
15537 Update attribute-handling to use the SimpleName/MemberAccess
15539 * cs-parser.jay (attribute): Pass in an expression to the
15540 constructors of Attribute and GlobalAttribute.
15541 * attribute.cs (Attribute): Take an expression for the name.
15542 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15543 passed in attribute name expression.
15544 (Attribute.CheckAttributeType): Use it.
15545 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15546 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15547 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15548 argument to prevent error messages if the lookup fails.
15550 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15552 * expression.cs (Indirection): Implemented IVariable interface
15553 to support indirection in AddressOf operator.
15554 (PointerArithmetic.Emit): Add optimalization for case where
15555 result can be precomputed.
15557 2005-01-26 Martin Baulig <martin@ximian.com>
15559 * class.cs (TypeContainer.AttributeTargets): Return the correct
15560 AttributeTargets depending on our `Kind' instead of throwing an
15561 exception; fixes #71632.
15563 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15566 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15569 2005-01-25 Raja R Harinath <rharinath@novell.com>
15572 * expression.cs (MemberAccess.DoResolve): Don't complain with
15573 cs0572 when the LHS of a member access has identical name and type
15576 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15579 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15581 Create custom PermissionSet only for PermissionSetAttribute.
15583 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15586 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15587 delegates in static class.
15589 2005-01-24 Martin Baulig <martin@ximian.com>
15591 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15592 merging an implicit block, just use its reachability.
15594 * statement.cs (Block.Resolve): Make the unreachable code check
15595 work wrt. implicit blocks; see test-337 from #63842.
15597 2005-01-21 Alp Toker <alp@atoker.com>
15599 * cs-parser.jay: destructor_declaration's container is PartialContainer
15600 not Class when partial types are used, so use Kind prop instead of
15603 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15605 * cs-parser.jay: Improve error reporting when an interface
15606 declares new types.
15608 2005-01-20 Dick Porter <dick@ximian.com>
15610 * support.cs: SeekableStreamReader fix from Sandor Dobos
15611 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15612 chars are read. Fixes bug 70369.
15614 2005-01-20 Raja R Harinath <rharinath@novell.com>
15616 * cs-parser.jay (catch_clause): Simplify current_block handling
15619 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15621 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15622 code with ImplicitStandardConversion to handle the implicit
15623 conversion of method groups into valid delegate invocations.
15625 The problem is that in parameter handling we were using this code
15626 path. Fixes bug #64698
15628 2005-01-19 Raja R Harinath <rharinath@novell.com>
15630 * cs-parser.jay: Fix several infelicities.
15631 - Avoid assigning to the parser value stack. Code like
15632 '$3 = null' is unclean. Synthesize a value for the code block
15634 - Avoid using oob_stack for storing location information. Use ...
15635 (_mark_): ... this. New (empty) rule. Saves the current location
15637 (foreach_statement): Avoid using oob_stack for current_block
15638 handling. Use technique used in for_statement and
15639 using_statement. Synthesize a value for the code block to store
15640 additional intermediate information.
15642 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15644 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15645 of a different type is only allowed to private fields of a
15646 containing type, not on fields of a base class.
15648 See test-174.cs and error cs0122-9.cs
15650 2005-01-13 Raja R Harinath <rharinath@novell.com>
15652 Fix test-335.cs (bug #58126).
15653 * cs-parser.jay (argument): Split out non-expression parts of the
15654 rule into 'non_simple_argument'.
15655 (invocation_expression): Support parenthesized invocations with
15656 multiple arguments, and with single non-simple arguments.
15658 2005-01-13 Raja R Harinath <rharinath@novell.com>
15660 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15663 2005-01-12 Raja R Harinath <rharinath@novell.com>
15665 Fix cs0038-1.cs, cs1640-6.cs.
15666 * ecore.cs (Expression.Resolve): Remove special-case for
15667 SimpleName in error-handling.
15668 (Expression.almostMatchedMembers): Relax access permission to
15670 (Expression.MemberLookupFailed): Handle duplicates in
15671 almostMatchedMembers list.
15672 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15673 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15674 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15675 overload if the passed in MemberInfo is a MethodBase.
15677 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15680 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15681 for non-CAS & merge permission sets properly.
15683 2005-01-11 Raja R Harinath <rharinath@novell.com>
15685 Improve standard-compliance of simple name and member access
15686 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15687 * ecore.cs (FullNamedExpression): New abstract base class
15688 for Namespaces and TypeExpressions.
15689 (ResolveFlags.SimpleName): Remove.
15690 (SimpleName): Remove support for dotted names.
15691 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15692 DeclSpace.FindType and DeclSpace.LookupType.
15693 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15694 (Expression.ExprClassName): Make member function.
15695 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15696 a namespace. Remove creation of dotted "SimpleName"s.
15697 (MemberAccess.DoResolve): Likewise.
15698 * decl.cs (DeclSpace.Cache): Make private.
15699 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15700 (DeclSpace.FindType): Update.
15701 (DeclSpace.LookupType): Move here from RootContext. Return a
15702 FullNamedExpression.
15703 * namespace.cs (Namespace): Derive from FullNamedExpression
15704 so that it can be part of expression resolution.
15705 (Namespace.Lookup): Return an FullNamedExpression.
15706 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15708 * rootcontext.cs (NamespaceLookup): Remove.
15709 (LookupType): Move to DeclSpace.
15710 * attribute.cs (CheckAttributeType): Update.
15711 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15712 (FindDocumentedTypeNonArray): Likewise.
15714 2005-01-11 Raja R Harinath <rharinath@novell.com>
15716 Fix cs0509.cs, cs1632.cs.
15717 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15718 is the same as IsInterface.
15719 (TypeContainer.GetClassBases): Likewise.
15720 * statement.cs (LabeledStatement.ig): New field.
15721 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15723 (LabeledStatement.DoEmit): Check that the label was created with
15724 the same ILGenerator.
15726 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15729 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15730 accessors to its properties.
15732 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15733 from accessors to property.
15735 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15738 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15739 only for overrides.
15741 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15743 * attribute.cs: Check for null and empty strings.
15745 I have lost another battle to Paolo.
15747 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15750 * class.cs (PropertyMethod): Set Parent field in ctors.
15751 (SetMethod.InternalParameters): Add unsafe switch hack.
15752 Override MarkForDuplicationCheck where it is appropriate.
15754 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15755 It says whether container allows members with the same name.
15756 Base default is no.
15757 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15758 Removed is_method parameter.
15760 2005-01-06 Duncan Mak <duncan@ximian.com>
15762 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15763 because the previous change led to incorrect reporting of CS1032
15764 ("Cannot define/undefine preprocessor symbols after first token in
15765 file"). Instead of using `tokens_seen' as the only flag that
15766 triggers CS1040, introduce `comments_seen'. This new flag is used
15767 to signify having seen comments on the current line, so it is
15768 unset after a newline.
15770 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15772 * doc.cs : When searching for a type, find nested type too.
15773 This fixes bug #71040.
15775 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15778 - Warn missing member comment on those classes which also does not
15779 have doc comments. Fixed bug #71041.
15780 - Don't warn missing doc comment on default constructor.
15783 2005-01-06 Duncan Mak <duncan@ximian.com>
15785 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15786 comments, set `tokens_seen' to true. This allows us to detect
15787 misplaced preprocessor directives (i.e. not at the beginning of
15788 the a line, nor after whitespaces). In that case, report error
15789 CS1040. This fixes bug #56460.
15791 * cs-parser.jay (interface_member_declaration): Add checks for
15792 IsExplicitImpl, and report CS0541 error if an interface member is
15793 defined as an explicit interface declaration.
15795 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15798 * class.cs (PropertyMethod): Set Parent field in ctors.
15799 (SetMethod.InternalParameters): Add unsafe switch hack.
15801 * decl.cs (MemberCore.Parent): Cannot be readonly.
15803 2005-01-06 Raja R Harinath <rharinath@novell.com>
15805 * decl.cs (DeclSpace.ResolveType): Remove.
15806 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15807 Merge in code from ...
15808 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15809 * class.cs, enum.cs: Update to changes.
15811 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15813 * anonymous.cs: Ensure that we init the scope of our parent if it
15814 has not been initialized yet.
15816 2004-12-30 Duncan Mak <duncan@ximian.com>
15818 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15819 if field.FieldBuilder is null. Fixes #70758.
15821 * convert.cs: Fixed some typos and updated some of the comments.
15822 (ImplicitStandardConversionExists):
15823 (TryImplicitIntConversion): If `target_type' is an interface and
15824 the type of `ic' implements this interface, return true or a new
15825 BoxedCast instead of null. This fixes #70468.
15827 2004-12-29 Duncan Mak <duncan@ximian.com>
15829 * expression.cs (Argument.Emit): Check that Expr is
15830 IMemoryLocation before casting to it, and report CS1510 otherwise.
15834 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15836 * statement.cs (Block.ThisVariable): remove the recursion here, to
15837 make the --profile more sane.
15839 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15841 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15842 assembly, by JB Evain.
15844 2004-12-17 Raja R Harinath <rharinath@novell.com>
15846 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15847 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15848 "parent" refers to enclosing type/class. "base" refers to superclass.
15850 2004-12-17 Raja R Harinath <rharinath@novell.com>
15852 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15853 Ensure that we only have GlobalAttributes.
15854 * attribute.cs (Attribute.Emit): Make non-virtual.
15855 (GlobalAttribute.Emit): Remove.
15856 (Attribute.Resolve): Make virtual.
15857 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15858 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15859 the argument. Don't create one.
15860 (Attribute.GetObsoleteAttribute): Likewise.
15861 (Attribute.GetClsCompliantAttributeValue): Likewise.
15862 * class.cs, decl.cs: Update to changes.
15864 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15866 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15868 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15870 * statement.cs (Foreach.Resolve): Add error 186 report.
15872 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15874 * expression.cs (Conditional.DoResolve): Add warning 429.
15876 * statement.cs (If.Resolve): Add warning 665.
15878 2004-12-16 Raja R Harinath <rharinath@novell.com>
15880 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15881 except when in the parser, and in GlobalAttribute.
15882 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15883 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15884 RootContext.Tree.Types.NamespaceEntry once work is done.
15885 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15886 and resets RootContext.Tree.Types.NamespaceEntry.
15888 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15890 * cs-parser.jay: Don't create a block for every variable.
15892 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15894 * location.cs: Provide extra information.
15896 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15897 variables from the captured environment, it is the ldarg_0.
15899 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15901 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15904 * class.cs: Changed warning level for 169 to avoid developer
15905 displeasure from warning flooding. It will be changed back when they
15906 fix most of current BCL warnings.
15908 * RootContext.cs: Pushed default WarningLevel to 3.
15910 * statement.cs: Removed unused variable.
15912 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15914 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15915 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15916 Add error 502 report.
15917 (StaticClass.DefineType): Add error 441 report.
15918 (Class.AllowedModifiersProp): New virtual property as temporary
15919 extension to AllowedModifiers.
15920 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15921 to share implementation with StaticClass and don't call virtual
15924 * driver.cs (MainDriver): Add error 1558 test.
15926 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15927 report. Moved error 36 test here.
15929 * statement.cs (Throw.Resolve): Add error 724 report.
15931 * typemanager.cs: Add out_attribute_type core type.
15933 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15935 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15937 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15939 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15942 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15944 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15945 Add error 3023 report.
15946 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15948 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15951 2004-12-12 John Luke <john.luke@gmail.com>
15953 * driver.cs (AddArgs): take -- into account when
15954 adding arguments, fixes bug 65710
15956 2004-12-12 Martin Baulig <martin@ximian.com>
15958 * expression.cs (Unary.TryReduceNegative): Added support for
15959 SByteConstant and ByteConstant.
15960 (Unary.Reduce): Check error values from TryReduceNegative().
15962 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15964 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15965 and report exception as error 182.
15967 2004-12-10 Raja R Harinath <rharinath@novell.com>
15969 * driver.cs (Main): Fix message when there are warnings.
15971 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15973 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15975 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15977 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15978 Reduced number of warnings.
15980 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15982 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15984 * driver.cs: Removed message.
15986 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15988 2004-12-08 <vargaz@freemail.hu>
15990 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15992 2004-12-08 Martin Baulig <martin@ximian.com>
15994 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15995 instead of a CS3002 for properties and indexer.
15997 2004-12-08 Martin Baulig <martin@ximian.com>
15999 * decl.cs (MemberName.ToString): Make this work again.
16001 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16003 * attribute.cs (Resolve): Add error 591 detection.
16005 * class.cs (FieldMember.Define): Add error 1547 detection.
16006 (Indexer.Define): Add error 620 detection.
16007 (Operator.Define): Add error 590 detection.
16009 * ecore.cs: Missing argument for error 79.
16011 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16014 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16017 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16020 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16022 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16023 Some operator comments were suppressed.
16024 * doc.cs : Implicit/explicit operator name in doc comments are like
16025 "op_Explicit(type)~returnType", so added suffix handling.
16027 2004-12-07 Martin Baulig <martin@ximian.com>
16030 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16031 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16032 (DeclSpace.ec): New protected field; store the EmitContext here.
16033 (DeclSpace.EmitContext): New public property; moved here from
16035 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16038 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16039 (Enum.Emit): Don't create a new EmitContext.
16041 * delegate.cs (Delegate.DefineType): Always create the
16044 * iterators.cs (Iterators.DefineIterator): Create a new
16045 EmitContext and store it in `ec'.
16047 2004-08-24 Martin Baulig <martin@ximian.com>
16050 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16051 this for accessibility checks.
16052 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16053 IsNestedFamilyAccessible.
16054 (TypeManager.IsSubclassOf): New method, do what the name actually
16057 2004-12-06 Raja R Harinath <rharinath@novell.com>
16059 Fix crash on cs0657-17.cs.
16060 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16061 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16062 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16063 the case where the NamespaceEntry gets overwritten.
16065 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16067 Fixed #69195, #56821
16068 * ecore.cs (ResolveBoolean): Tiny refactoring.
16070 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16071 of right expression resolving when left is false constant and
16072 operator is LogicalAnd OR true constant and operator is LogicalOr.
16074 * statement.cs (ResolveUnreachable): Always reports warning.
16076 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16078 * class.cs: Distinguish between 1721 and 1722 (just a little help
16079 for the programmer).
16081 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16083 * delegate.cs: Only allow this on new versions of the language.
16085 2004-12-02 Duncan Mak <duncan@ximian.com>
16087 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16089 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16090 here as a static method. Take an additional bool out parameter
16091 `must_do_cs1540_check' for signaling to InstanceResolve.
16092 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16093 member field from PropertyExpr class and made it an argument of
16094 the method instead.
16095 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16096 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16097 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16098 and `remove_accessor' as well as InstanceResolve: report CS0122
16103 2004-12-03 Raja R Harinath <rharinath@novell.com>
16105 Fix test-327.cs, test-328.cs, and put in early infrastructure
16106 for eventually fixing #52697.
16107 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16108 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16109 from other methods.
16110 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16111 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16112 (VerifyUsing, error246): Update.
16113 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16114 'NamespaceEntry.LookupNamespaceOrType'.
16116 2004-12-03 Martin Baulig <martin@ximian.com>
16118 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16119 method as our child, call AnonymousMethod.Compatible() on it.
16121 2004-12-03 Raja R Harinath <rharinath@novell.com>
16123 Disable XML documentation support in 'basic' profile.
16124 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16125 Redirect XmlElement to System.Object.
16126 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16127 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16128 * mcs.exe.sources: Add doc-bootstrap.cs.
16129 * doc-bootstrap.cs: New file. Contains empty stub implementation
16132 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16134 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16135 comments are allowed.
16137 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16139 * delegate.cs: Add checks for subtypes in paramaters and return values
16140 in VerifyMethod () to add support for Covariance/Contravariance
16143 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16145 * report.cs: Remove extra closing parenthesis.
16147 * convert.cs (Error_CannotImplicitConversion): If the name of the
16148 types are the same, provide some extra information.
16150 * class.cs (FieldBase): Use an unused bit field from the field to
16151 encode the `has_offset' property from the FieldMember. This saves
16152 a couple of Ks on bootstrap compilation.
16154 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16155 method as our child, return the AnonymousMethod resolved
16158 * expression.cs (New.DoResolve): Allow return values from
16159 NewDelegate to also include AnonymousMethods.
16163 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16166 * attribute.cs (Resolve): Improved implementation of params
16167 attribute arguments.
16169 * support.cs (ParameterData): Add HasParams to be faster.
16171 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16173 all things are for /doc support:
16175 * doc.cs: new file that supports XML documentation generation.
16176 * mcs.exe.sources: added doc.cs.
16178 Handle /doc command line option.
16179 Report error 2006 instead of 5 for missing file name for /doc.
16180 Generate XML documentation when required, after type resolution.
16182 Added support for picking up documentation (/// and /** ... */),
16183 including a new XmlCommentState enumeration.
16185 Added lines to fill Documentation element for field, constant,
16186 property, indexer, method, constructor, destructor, operator, event
16187 and class, struct, interface, delegate, enum.
16188 Added lines to warn incorrect comment.
16190 Added Documentation field (passed only when /doc was specified).
16192 Added DocComment, DocCommentHeader, GenerateDocComment() and
16193 OnGenerateDocComment() and some supporting private members for
16194 /doc feature to MemberCore.
16196 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16198 Added overriden DocCommentHeader.
16200 Added overriden DocCommentHeader and GenerateDocComment().
16202 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16204 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16205 unwrapping the enumeration values, chain to
16206 DoConstantNumericPromotions again, so we can promote things to the
16207 fundamental types (takes care of enums that are bytes, sbytes).
16211 2004-12-01 Raja R Harinath <rharinath@novell.com>
16213 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16214 Fix long-standing bug in type-lookup. Use FindType instead of
16215 LookupType when ec.ResolvingTypeTree.
16216 (Attribute.ResolveType, Attribute.Resolve)
16217 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16219 (Attributes.Search): Remove internal version. Update.
16220 (Attributes.SearchMulti): Update.
16221 (Attributes.GetClsCompliantAttribute): Remove.
16222 (Attributes.GetIndexerNameAttribute): Remove.
16223 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16224 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16225 * class.cs (Indexer.Define): Likewise.
16227 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16230 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16231 MarshallByReference members access.
16233 * expression.cs: Use CheckMarshallByRefAccess;
16234 Better error CS0197 message.
16236 * report.cs: Print whole related error message.
16238 2004-11-30 Raja R Harinath <rharinath@novell.com>
16240 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16241 the current directory to help debugging.
16243 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16245 * class (GetClassBases): Better error 60 report.
16246 (EventProperty): Disabled warning 67 detection.
16248 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16251 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16253 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16256 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16259 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16261 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16263 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16265 * attribute.cs (Attribute.Resolve): Refine error reporting and
16266 report a cs0117 if the identifier does not exist, to distinguish
16267 from 0617 which is a miss-use of the actual identifier.
16269 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16270 between cs0070 and cs0079.
16272 * class.cs (MemberBase.DoDefine): When reporting a wrong
16273 accessibility level, we use MethodCore to compare instead of
16274 Method (this was a regression in some refactoring effort).
16276 So now we correctly report cs0056 again.
16278 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16279 testing the target_type (which was known to be object_type) and
16280 not the source type (which is anonymous_method).
16282 Fixed reporting of error cs1660.
16284 * expression.cs (UserCast.Source): Expose the underlying cast.
16286 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16287 allowed types to find a match to int32 first (most common).
16289 In addition, it ignores any ImplicitUserConversions that did an
16290 internal implicit conversion (as the switch statement allows only
16291 one integral conversion to exist).
16293 * class.cs (PartialContainer.Create): rename `name' to
16294 `member_name' for clarity. Then replace the string calls with a
16295 call to MemberName.GetPartialName, as now using
16296 MemberName.ToString is an error (this is due to the side effects
16297 it had, that were fixed in the past).
16299 This will restore the error reporting on a number of partial class
16300 errors that were missusing this (and getting an exception as a
16301 results, which is now just a plain textual warning, because
16302 yyparse debug output would crash otherwise).
16304 2004-11-26 Raja R Harinath <rharinath@novell.com>
16306 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16308 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16310 * rootcontext.cs (LookupType): Make sure to cache lookups that
16311 don't give us a negative result. This saves about 5% of corlib
16314 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16316 * report.cs (AbstractMessage.Print): messages are sent to stderr
16318 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16319 non-interface in the list of interfaces (at this point, either
16320 parent was properly set, or a base class is being listed in the
16321 interfaces section).
16323 This flags error 1722, and resolves the crash from bug 69259.
16325 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16327 * statement.cs (Using.EmitExpressionFinally): make this work right
16328 for valuetypes. Fixes 69926.
16330 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16332 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16333 converted to an enum" here, before we try to change the underlying
16334 type. This code exists, but it is a different code path than the
16335 one used while encoding constants.
16337 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16338 old bug: when converting from the null literal to a pointer,
16339 return an EmptyCast, not the NullLiteral.
16341 This fixes #69921, the recent null_type changes probably made this
16342 bug more prominent.
16344 (ImplicitReferenceConversionExists): In addition, resynchronized
16345 the code here, so it matches the same code in
16346 ImplicitReferenceConversionExists for the `from any class-type S
16347 to any interface-type T'.
16350 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16352 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16354 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16356 * cs-parser.jay: Use verbosity accordingly.
16358 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16360 * expression.cs (Unary.ResolveOperator): Do not report warning;
16361 AddressOf reads from variable.
16363 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16365 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16369 * attribute.cs (Attributable): Removed CheckTargets.
16370 (Attributes.Emit): Explicit attribute targets are tested here.
16372 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16373 not enabled for interfaces.
16375 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16376 (GetAssemblyName): Ouch next bug there.
16378 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16380 * expression.cs: Error 275 added.
16382 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16384 Fix bug #69177 (Implemented decimal constant support)
16386 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16387 (BinaryFold): Add DecimalConstant.
16389 * const.cs (Define): Decimal constant
16391 (ChangeType): Add decimal type handling.
16392 (LookupConstantValue): Don't set value for decimal type but
16393 emit DecimalConstantAttribute. Needed for constant optimization.
16395 * constant.cs (ToDecimal): New method.
16396 (ConvertToDecimal): New method.
16397 (IntConstant): Implemented ConvertToDecimal.
16398 (DecimalConstant.Emit): Emit optimized version for decimals in
16401 * expression.cs (ResolveOperator): Changed order of constant
16402 reduction to work correctly with native types which have
16403 overloaded operators.
16404 (ResolveMemberAccess): Extract constant value from attribute
16407 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16409 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16410 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16411 (ChangeType): Decimal is special.
16412 (TypeToCoreType): Add decimal type.
16414 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16416 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16419 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16421 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16424 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16426 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16428 * pending.cs (PendingImplementation): Grab only interfaces.
16430 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16432 * statement.cs (ForeachHelperMethods): Add location member and
16433 error 202 detection.
16435 2004-11-19 Raja R Harinath <rharinath@novell.com>
16437 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16438 automatically handled by executable.make.
16439 (PROGRAM): Make profile-specific.
16441 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16443 * expression.cs (DoResolveBase): Fixed wrong warning for out
16446 2004-11-18 Martin Baulig <martin@ximian.com>
16448 Merged latest changes into gmcs. Please keep this comment in
16449 here, it makes it easier for me to see what changed in MCS since
16450 the last time I merged.
16452 2004-11-17 Raja R Harinath <rharinath@novell.com>
16454 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16455 (TypeHandle.GetMemberCache): New.
16456 (TypeHandle.TypeHandle): Update.
16457 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16458 (TypeManager.LookupParentInterfacesCache):
16459 Rename from LookupInterfaceCache. Optimize slightly.
16460 (TypeManager.MemberLookup_FindMembers): Update.
16461 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16462 multi-type variant.
16463 (AddCacheContents): Rename from AddHashtable.
16464 * class.cs (TypeContainer.parent_container): Remove.
16465 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16466 (TypeContainer.DoDefineMembers): Don't initialize it.
16467 Update to name changes.
16469 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16471 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16472 that factors the code to check access modifiers on override.
16474 (PropertyBase): Use the code here.
16476 Patch from Lluis S'anchez, fixes bug #69361.
16478 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16480 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16481 routine that is used to report the use of a captured variable
16482 whose address has been taken.
16484 There are two checks: one when variables are being captured and
16485 the other check is when the address of a variable is taken.
16487 (because an anonymous methods might be resolved before *or* after
16488 the address has been taken) and
16490 * expression.cs (Conditional.DoResolve): Remove the special
16491 casing that Martin added to trueExpr and falseExpr being both
16492 NullLiteral. We get the right behavior now just by introducing
16493 the null_type into the compiler.
16495 * convert.cs (ExplicitConversion): Change the code to use
16496 null_type instead of testing `expr is NullLiteral'.
16497 (ImplicitConversionStandard): use null_type too.
16498 (ImplicitReferenceConversionExists): use null_type too.
16499 (ImplicitReferenceConversion): use null_type too.
16501 * literal.cs: The type of `NullLiteral' is now null_type instead
16503 (Resolve): Set the type here.
16505 * typemanager.cs: Introduce null_type.
16507 2004-11-17 Martin Baulig <martin@ximian.com>
16509 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16510 direction, like FindMembers() does. Fixes #69546, testcase is in
16513 2004-11-16 Martin Baulig <martin@ximian.com>
16515 This is based on a patch from Marek Safar, see bug #69082.
16516 Fixes bugs #63705 and #67130.
16518 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16519 method; create a MemberCache for an interface type and cache the
16522 * decl.cs (IMemberContainer.ParentContainer): Removed.
16523 (IMemberContainer.ParentCache): New property.
16524 (MemberCache.SetupCacheForInterface): Removed.
16525 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16526 to create a cache for an interface's "parent".
16528 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16531 2004-11-16 Martin Baulig <martin@ximian.com>
16533 Merged back from gmcs; these changes already went into gmcs a
16534 couple of weeks ago.
16537 (TypeManager.AddUserType): Removed the `ifaces' argument.
16538 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16540 (TypeManager.AddUserInterface): Removed.
16541 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16543 (TypeManager.GetInterfaces): Likewise.
16544 (TypeManager.GetExplicitInterfaces): Likewise.
16546 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16548 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16549 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16551 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16553 * statement.cs: Avoid adding bools to a hashtable.
16555 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16557 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16558 calling an unsafe method from a safe location.
16560 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16563 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16565 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16567 * namespace.cs (VerifyUsing): use GetPartialName instead of
16570 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16572 * statement.cs (Return.Resolve): Fix regression in typo: if
16573 `in_exc', we have to request a NeedReturnLabel, this was a typo
16574 introduced in the anonymous method check-in. Fixes #69131.
16576 * Indexers were using the ShortName when defining themselves,
16577 causing a regression in the compiler bootstrap when applying the
16578 patch from 2004-11-02 (first part), now they use their full name
16579 and the bug is gone.
16581 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16583 * driver.cs: Strip the path from the names of embedded resources. Fixes
16586 2004-11-04 Raja R Harinath <rharinath@novell.com>
16588 Fix error message regression: cs0104-2.cs.
16589 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16590 (AliasEntry.Resolve): Update.
16591 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16593 (RootContext.LookupType): Update.
16595 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16597 * cs-parser.jay: Add support for handling accessor modifiers
16598 * class: Add support port accessor modifiers and error checking,
16599 define PropertyMethod.Define as virtual (not abstract anymore)
16600 * ecore.cs: Add checking for proeprties access with access modifiers
16601 * iterators.cs: Modify Accessor constructor call based in the modified
16603 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16605 * expression.cs (StringConcat): Handle being called twice,
16606 as when we have a concat in a field init with more than two
16609 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16611 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16612 special case explicit implementations, we should always produce
16613 the .property or .event declaration.
16615 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16616 since it will not return correct data if people use this
16617 unresolved in the presence of using statements (see test-313).
16619 * class.cs (MethodData.Define): If we are an explicit interface
16620 implementation, set the method name to the full name of the
16621 interface plus the name of the method.
16623 Notice that using the method.MethodName.GetFullName() does not
16624 work, as it will only contain the name as declared on the source
16625 file (it can be a shorthand in the presence of using statements)
16626 and not the fully qualifed type name, for example:
16630 class D : ICloneable {
16631 object ICloneable.Clone () {
16635 Would produce a method called `ICloneable.Clone' instead of
16636 `System.ICloneable.Clone'.
16638 * namespace.cs (Alias.Resolve): Use GetPartialName.
16640 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16642 * cs-parser.jay: Add error 1055 report.
16644 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16646 * assign.cs (Assign.DoResolve): Only do the transform of
16647 assignment into a New if the types are compatible, if not, fall
16648 through and let the implicit code deal with the errors and with
16649 the necessary conversions.
16651 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16653 * cs-parser.jay: Add error 1031 report.
16655 * cs-tokenizer.cs: Add location for error 1038.
16657 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16659 * cs-parser.jay: Add error 1016 report.
16661 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16663 * cs-parser.jay: Add errors 1575,1611 report.
16665 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16667 * cs-parser.jay: Add error 1001 report.
16669 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16672 * attribute.cs (GetMarshal): Add method argument for
16673 caller identification.
16675 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16676 agument for GetMarshal and RuntimeMissingSupport.
16678 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16680 * attribute.cs (ExtractSecurityPermissionSet): Removed
16681 TypeManager.code_access_permission_type.
16683 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16685 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16687 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16688 for obsolete use of a variable here. Fixes regression on errors
16689 cs0619-25 and cs0619-26.
16691 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16693 Fix #62358, implemented security attribute encoding.
16695 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16696 Tests permitted SecurityAction for assembly or other types.
16697 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16698 data from SecurityPermissionAttribute to PermisionSet class.
16700 * class.cs (ApplyAttributeBuilder): Added special handling
16701 for System.Security.Permissions.SecurityAttribute based types.
16703 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16704 special handling for System.Security.Permissions.SecurityAttribute
16707 * enum.cs (ApplyAttributeBuilder): Added special handling
16708 for System.Security.Permissions.SecurityAttribute based types.
16710 * parameter.cs (ApplyAttributeBuilder): Added special handling
16711 for System.Security.Permissions.SecurityAttribute based types.
16713 * rootcontext.cs: Next 2 core types.
16715 * typemanager.cs (TypeManager.security_permission_attr_type):
16716 Built in type for the SecurityPermission Attribute.
16717 (code_access_permission_type): Build in type.
16719 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16721 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16722 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16723 all of this information into
16724 EmitContext.EmitCapturedVariableInstance.
16726 * codegen.cs (EmitCapturedVariableInstance): move here the
16727 funcionality of emitting an ldarg.0 in the presence of a
16728 remapping. This centralizes the instance emit code.
16730 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16731 then emit a load of this: it means that we have reached the
16732 topmost ScopeInfo: the one that contains the pointer to the
16733 instance of the class hosting the anonymous method.
16735 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16736 captures to the topmost CaptureContext.
16738 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16740 * expression.cs (LocalVariableReference): Move the knowledge about
16741 the iterators into codegen's EmitCapturedVariableInstance.
16743 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16745 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16746 all code paths return a value from an anonymous method (it is the
16747 same as the 161 error, but for anonymous methods).
16749 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16751 The introduction of anonymous methods in the compiler changed
16752 various ways of doing things in the compiler. The most
16753 significant one is the hard split between the resolution phase
16754 and the emission phases of the compiler.
16756 For instance, routines that referenced local variables no
16757 longer can safely create temporary variables during the
16758 resolution phase: they must do so from the emission phase,
16759 since the variable might have been "captured", hence access to
16760 it can not be done with the local-variable operations from the runtime.
16764 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16765 is a toplevel block.
16767 (ToplevelBlock): A new kind of Block, these are the blocks that
16768 are created by the parser for all toplevel method bodies. These
16769 include methods, accessors and anonymous methods.
16771 These contain some extra information not found in regular blocks:
16772 A pointer to an optional CaptureContext (for tracking captured
16773 local variables and parameters). A pointer to the parent
16776 (Return.Resolve): Catch missmatches when returning a value from an
16777 anonymous method (error 1662).
16778 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16781 (Break.Resolve): ditto.
16783 (SwitchLabel): instead of defining the labels during the
16784 resolution phase, we now turned the public ILLabel and ILLabelCode
16785 labels into methods called GetILLabelCode() and GetILLabel() that
16786 only define the label during the Emit phase.
16788 (GotoCase): Track the SwitchLabel instead of the computed label
16789 (its contained therein). Emit the code by using
16790 SwitchLabel.GetILLabelCode ().
16792 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16793 whether the Local has been captured or not.
16795 (LocalInfo.IsCaptured): New property, used to tell whether the
16796 local has been captured.
16798 * anonymous.cs: Vastly updated to contain the anonymous method
16801 The main classes here are: CaptureContext which tracks any
16802 captured information for a toplevel block and ScopeInfo used to
16803 track the activation frames for various local variables.
16805 Each toplevel block has an optional capture context associated
16806 with it. When a method contains an anonymous method both the
16807 toplevel method and the anonymous method will create a capture
16808 context. When variables or parameters are captured, they are
16809 recorded on the CaptureContext that owns them, for example:
16813 MyDelegate d = delegate {
16818 Here `a' will be recorded as captured on the toplevel
16819 CapturedContext, the inner captured context will not have anything
16820 (it will only have data if local variables or parameters from it
16821 are captured in a nested anonymous method.
16823 The ScopeInfo is used to track the activation frames for local
16824 variables, for example:
16826 for (int i = 0; i < 10; i++)
16827 for (int j = 0; j < 10; j++){
16828 MyDelegate d = delegate {
16833 At runtime this captures a single captured variable `i', but it
16834 captures 10 different versions of the variable `j'. The variable
16835 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16836 recorded on a child.
16838 The toplevel ScopeInfo will also track information like the `this'
16839 pointer if instance variables were referenced (this is necessary
16840 as the anonymous method lives inside a nested class in the host
16841 type of the method).
16843 (AnonymousMethod): Expanded to track the Toplevel, implement
16844 `AnonymousMethod.Compatible' to tell whether an anonymous method
16845 can be converted to a target delegate type.
16847 The routine now also produces the anonymous method content
16849 (AnonymousDelegate): A helper class that derives from
16850 DelegateCreation, this is used to generate the code necessary to
16851 produce the delegate for the anonymous method that was created.
16853 * assign.cs: API adjustments for new changes in
16854 Convert.ImplicitStandardConversionExists.
16856 * class.cs: Adjustments to cope with the fact that now toplevel
16857 blocks are of type `ToplevelBlock'.
16859 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16860 insteda of standard blocks.
16862 Flag errors if params arguments are passed to anonymous methods.
16864 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16865 `CurrentAnonymousMethod' which points to the current Anonymous
16866 Method. The variable points to the AnonymousMethod class that
16867 holds the code being compiled. It is set in the new EmitContext
16868 created for the anonymous method.
16870 (EmitContext.Phase): Introduce a variable and an enumeration to
16871 assist in enforcing some rules about when and where we are allowed
16872 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16873 only one that enfonces this right now).
16875 (EmitContext.HaveCaptureInfo): new helper method that returns
16876 whether we have a CapturedContext initialized.
16878 (EmitContext.CaptureVariable): New method used to register that a
16879 LocalInfo must be flagged for capturing.
16881 (EmitContext.CapturedParameter): New method used to register that a
16882 parameters must be flagged for capturing.
16884 (EmitContext.CapturedField): New method used to register that a
16885 field must be flagged for capturing.
16887 (EmitContext.HaveCapturedVariables,
16888 EmitContext.HaveCapturedFields): Return whether there are captured
16889 variables or fields.
16891 (EmitContext.EmitMethodHostInstance): This is used to emit the
16892 instance for the anonymous method. The instance might be null
16893 (static methods), this (for anonymous methods that capture nothing
16894 and happen to live side-by-side with the current method body) or a
16895 more complicated expression if the method has a CaptureContext.
16897 (EmitContext.EmitTopBlock): Routine that drives the emission of
16898 code: it will first resolve the top block, then emit any metadata
16899 and then emit the code. The split is done so that we can extract
16900 any anonymous methods and flag any captured variables/parameters.
16902 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16903 during this phase, the ILGenerator should not be used as labels
16904 and local variables declared here might not be accessible to any
16905 code that is part of an anonymous method.
16907 Exceptions to this include the temporary variables that are
16908 created by some statements internally for holding temporary
16911 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16914 (EmitContext.TemporaryReturn): This method is typically called
16915 from the Emit phase, and its the only place where we allow the
16916 ReturnLabel to be defined other than the EmitMeta. The reason is
16917 that otherwise we would have to duplicate a lot of logic in the
16918 Resolve phases of various methods that today is on the Emit
16921 (EmitContext.NeedReturnLabel): This no longer creates the label,
16922 as the ILGenerator is not valid during the resolve phase.
16924 (EmitContext.EmitThis): Extended the knowledge in this class to
16925 work in anonymous methods in addition to iterators.
16927 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16928 code is necessary on the stack to access the instance to a local
16929 variable (the variable will be accessed as a field).
16931 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16932 EmitContext.EmitAddressOfParameter): Routines to support
16933 parameters (not completed at this point).
16935 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16936 will also remove the parameters.
16938 * convert.cs (Convert): Define a `ConstantEC' which points to a
16939 null. This is just to prefity some code that uses
16940 ImplicitStandardConversion code and do not have an EmitContext
16943 The idea is to flag explicitly that at that point in time, it is
16944 known that the conversion will not trigger the delegate checking
16945 code in implicit conversions (which requires a valid
16948 Everywhere: pass new EmitContext parameter since
16949 ImplicitStandardConversionExists now requires it to check for
16950 anonymous method conversions.
16952 (Convert.ImplicitStandardConversionExists): If the type of an
16953 expression is the anonymous_method_type, and the type is a
16954 delegate, we invoke the AnonymousMethod.Compatible method to check
16955 whether an implicit conversion is possible.
16957 (Convert.ImplicitConversionStandard): Only do implicit method
16958 group conversions if the language level is not ISO_1.
16960 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16961 MethodInfo for the Invoke method. used by Delegate and
16964 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16965 method conversions if the target type is a delegate.
16967 Removed extra debugging nops.
16969 (LocalVariableReference): Turn the `local_info' into a public
16972 Add `prepared' field, the same hack used for FieldExprs to cope
16973 with composed assignments, as Local variables do not necessarily
16974 operate purely on the stack as they used to: they can be captured
16977 Add `temp' for a temporary result, like fields.
16979 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16981 It now copes with Local variables that are captured and emits the
16982 proper instance variable to load it from a field in the captured
16985 (ParameterReference.DoResolveBase): During the resolve phase,
16986 capture parameters if we are in an anonymous method.
16988 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16989 anonymous method, use the EmitContext helper routines to emit the
16990 parameter reference.
16992 * iterators.cs: Set RemapToProxy to true/false during the
16995 * parameters.cs (GetParameterByName): New helper method.
16997 * typemanager.cs (anonymous_method_type) a new type that
16998 represents an anonyous method. This is always an internal type,
16999 used as a fencepost to test against the anonymous-methodness of an
17002 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17004 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17006 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17008 2004-10-18 Martin Baulig <martin@ximian.com>
17010 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17011 `Type' directly, but call ResolveType() on it.
17012 (Catch.Resolve): Likewise.
17013 (Foreach.Resolve): Likewise.
17015 2004-10-18 Martin Baulig <martin@ximian.com>
17017 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17018 `Type' directly, but call ResolveType() on it.
17019 (Probe.DoResolve): Likewise.
17020 (ArrayCreation.LookupType): Likewise.
17021 (TypeOf.DoResolve): Likewise.
17022 (SizeOf.DoResolve): Likewise.
17024 2004-10-18 Martin Baulig <martin@ximian.com>
17026 * expression.cs (Invocation.BetterFunction): Put back
17027 TypeManager.TypeToCoreType().
17029 2004-10-18 Raja R Harinath <rharinath@novell.com>
17031 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17034 2004-10-18 Martin Baulig <martin@ximian.com>
17036 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17037 `Type' directly, but call ResolveType() on it.
17039 2004-10-18 Martin Baulig <martin@ximian.com>
17041 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17042 `Type' directly, but call ResolveType() on it.
17043 (MemberBase.DoDefine): Likewise.
17045 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17046 `Type' directly, but call ResolveType() on it.
17047 (ComposedCast.DoResolveAsTypeStep): Likewise.
17049 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17050 `Type' directly, but call ResolveType() on it.
17052 2004-10-17 John Luke <john.luke@gmail.com>
17054 * class.cs (Operator.GetSignatureForError): use CSharpName
17056 * parameter.cs (Parameter.GetSignatureForError): Returns
17057 correct name even if was not defined.
17059 2004-10-13 Raja R Harinath <rharinath@novell.com>
17062 * class.cs (TypeContainer.EmitContext): New property.
17063 (DefineNestedTypes): Create an emitcontext for each part.
17064 (MethodCore.DoDefineParameters): Use container's emitcontext.
17065 Pass type array to InternalParameters.
17066 (MemberBase.DoDefine): Use container's emitcontext.
17067 (FieldMember.Define): Likewise.
17068 (Event.Define): Likewise.
17069 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17070 Pass type array to InternalParameters.
17071 (SetIndexerMethod.GetParameterInfo): Likewise.
17072 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17073 * delegate.cs (Define): Pass emitcontext to
17074 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17075 array to InternalParameters.
17076 * expression.cs (ParameterReference.DoResolveBase): Pass
17077 emitcontext to GetParameterInfo.
17078 (ComposedCast.DoResolveAsTypeStep): Remove check on
17079 ec.ResolvingTypeTree.
17080 * parameter.cs (Parameter.Resolve): Change argument to
17081 EmitContext. Use ResolveAsTypeTerminal.
17082 (Parameter.GetSignature): Change argument to EmitContext.
17083 (Parameters.ComputeSignature): Likewise.
17084 (Parameters.ComputeParameterTypes): Likewise.
17085 (Parameters.GetParameterInfo): Likewise.
17086 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17087 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17088 * support.cs (InternalParameters..ctor): Remove variant that takes
17090 * typemanager.cs (system_intptr_expr): New.
17091 (InitExpressionTypes): Initialize it.
17093 2004-10-12 Chris Toshok <toshok@ximian.com>
17095 * cs-parser.jay: fix location for try_statement and catch_clause.
17097 2004-10-11 Martin Baulig <martin@ximian.com>
17099 * report.cs: Don't make --fatal abort on warnings, we have
17100 -warnaserror for that.
17102 2004-10-07 Raja R Harinath <rharinath@novell.com>
17104 More DeclSpace.ResolveType avoidance.
17105 * decl.cs (MemberCore.InUnsafe): New property.
17106 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17107 with newly created EmitContext.
17108 (FieldMember.Define): Likewise.
17109 * delegate.cs (Delegate.Define): Likewise.
17110 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17111 only if normal name-lookup fails.
17112 (TypeExpr.DoResolve): Enable error-checking.
17113 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17114 (SizeOf.DoResolve): Likewise.
17115 (ComposedCast.DoResolveAsTypeStep): Likewise.
17116 (StackAlloc.DoResolve): Likewise.
17117 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17118 (Block.Unsafe): New property.
17119 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17120 (Unsafe): Set 'unsafe' flag of contained block.
17121 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17122 (Fixed.Resolve): Likewise.
17123 (Catch.Resolve): Likewise.
17124 (Using.ResolveLocalVariableDecls): Likewise.
17125 (Foreach.Resolve): Likewise.
17127 2004-10-05 John Luke <john.luke@gmail.com>
17129 * cs-parser.jay: add location to error CS0175
17131 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17133 * ecore.cs (Expression.Constantity): Add support for turning null
17136 * const.cs (Const.Define): Allow constants to be reference types
17137 as long as the value is Null.
17139 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17141 * namespace.cs (NamespaceEntry.Using): No matter which warning
17142 level is set, check if this namespace name has already been added.
17144 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17146 * expression.cs: reftype [!=]= null should always use br[true,false].
17149 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17152 * attribute.cs: Enum conversion moved to
17153 GetAttributeArgumentExpression to be applied to the all
17156 2004-10-01 Raja R Harinath <rharinath@novell.com>
17158 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17159 * class.c (TypeContainer.DefineType): Flag error if
17160 base types aren't accessible due to access permissions.
17161 * decl.cs (DeclSpace.ResolveType): Move logic to
17162 Expression.ResolveAsTypeTerminal.
17163 (DeclSpace.ResolveTypeExpr): Thin layer over
17164 Expression.ResolveAsTypeTerminal.
17165 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17166 Refactor code into NestedAccess. Use it.
17167 (DeclSpace.NestedAccess): New.
17168 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17169 argument to silence errors. Check access permissions.
17170 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17171 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17172 (Cast.DoResolve): Likewise.
17173 (New.DoResolve): Likewise.
17174 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17175 (TypeOf.DoResolve): Likewise.
17177 * expression.cs (Invocation.BetterConversion): Return the Type of
17178 the better conversion. Implement section 14.4.2.3 more faithfully.
17179 (Invocation.BetterFunction): Make boolean. Make correspondence to
17180 section 14.4.2.2 explicit.
17181 (Invocation.OverloadResolve): Update.
17182 (Invocation): Remove is_base field.
17183 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17184 (Invocation.Emit): Likewise.
17186 2004-09-27 Raja R Harinath <rharinath@novell.com>
17188 * README: Update to changes.
17190 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17192 * cs-parser.jay: Reverted 642 warning fix.
17194 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17197 * decl.cs (FindMemberWithSameName): Indexer can have more than
17200 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17202 * expression.cs (LocalVariableReference.DoResolveLValue):
17203 Do not report warning 219 for out values.
17204 (EmptyExpression.Null): New member to avoid extra allocations.
17206 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17208 * cs-parser.jay: Fix wrong warning 642 report.
17210 * cs-tokenizer.cs (CheckNextToken): New helper;
17211 Inspect next character if is same as expected.
17213 2004-09-23 Martin Baulig <martin@ximian.com>
17215 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17216 (Convert.ImplicitReferenceConversionExists): Likewise.
17218 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17220 * class.cs (Operator.Define): Add error 448 and 559 report.
17222 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17224 * class.cs (MemberBase.IsTypePermitted): New protected
17225 method for checking error CS0610.
17227 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17229 * class.cs (TypeContainer.HasExplicitLayout): New property
17230 Returns whether container has StructLayout attribute set Explicit.
17231 (FieldMember): New abstract class for consts and fields.
17232 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17233 (Field): Reuse FieldMember.
17235 * const.cs (Const): Reuse FieldMember.
17237 * rootcontext.cs: EmitConstants call moved to class.
17239 2004-09-22 Martin Baulig <martin@ximian.com>
17241 Thanks to Peter Sestoft for this bug report.
17243 * expression.cs (Conditional): If both the `trueExpr' and the
17244 `falseExpr' is a NullLiteral, return a NullLiteral.
17246 2004-09-22 Martin Baulig <martin@ximian.com>
17248 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17249 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17250 for the "get_Current" call.
17252 2004-09-22 Martin Baulig <martin@ximian.com>
17254 Marek and me just fixed one of our oldest bugs: #28562 :-)
17256 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17258 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17259 we're an EnumConstant, just return that.
17260 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17261 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17262 to get the value which'll actually be written into the attribute.
17263 However, we have to use GetValue() to access the attribute's value
17266 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17268 * constant.cs (Constant.IsNegative): New abstract property
17271 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17272 (StackAlloc.DoResolve): Reused IsNegative.
17274 2004-09-21 Martin Baulig <martin@ximian.com>
17276 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17277 if we're used in an iterator, we may be called from different
17280 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17281 we actually have an exception block.
17283 2004-09-20 John Luke <jluke@cfl.rr.com>
17285 * class.cs, cs-parser.jay: Improve the error report for 1520:
17286 report the actual line where the error happens, not where the
17287 class was declared.
17289 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17290 Pass location information that was available elsewhere.
17292 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17294 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17295 runtime to delay sign assemblies.
17297 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17299 * cs-parser.jay: Do not report the stack trace, this is barely
17302 2004-08-22 John Luke <john.luke@gmail.com>
17304 * driver.cs : check that a resource id is not already used
17305 before adding it, report CS1508 if it is, bug #63637
17307 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17309 * ecore.cs: Removed dead code.
17311 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17313 * class.cs: Do not report warning CS0067 on the interfaces.
17315 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17317 * cs-parser.jay: Add error 504 report.
17319 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17321 * rootcontext.cs: WarningLevel is 4 by default now.
17323 * statement.cs (Fixed.Resolve): Do not null
17326 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17329 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17330 deep search when property is not virtual.
17331 (PropertyExpr.ResolveAccessors): Make one call for both
17334 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17337 * statement.cs: Error 152 report constains also location.
17339 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17342 * const.cs: Explicitly set constant as static.
17344 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17347 * cs-parser.jay: Add error 1017 report.
17349 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17351 Fixed bug #59980, #64224
17352 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17354 * typemanager.cs (IsSpecialMethod): Simplified
17356 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17358 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17359 condition with better params.
17361 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17364 * attribute.cs (Resolve): Property has to have both
17367 2004-09-14 Martin Baulig <martin@ximian.com>
17369 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17371 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17374 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17375 called and is obsolete then this member suppress message
17376 when call is inside next [Obsolete] method or type.
17378 * expression.cs: Use TestObsoleteMethodUsage member.
17380 2004-09-14 Martin Baulig <martin@ximian.com>
17382 * cs-parser.jay: Sync a bit with the GMCS version.
17384 2004-09-14 Martin Baulig <martin@ximian.com>
17386 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17387 (CSharpParser.yacc_verbose_flag): New public field.
17389 * genericparser.cs: Removed.
17391 2004-09-14 Raja R Harinath <rharinath@novell.com>
17393 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17395 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17397 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17399 2004-09-10 Martin Baulig <martin@ximian.com>
17401 Backported my MemberName changes from GMCS into MCS.
17403 - we are now using a special `MemberName' class instead of using
17404 strings; in GMCS, the `MemberName' also contains the type
17407 - changed the grammar rules a bit:
17408 * the old `member_name' is now a `namespace_or_type_name':
17409 The rule is that we use `namespace_or_type_name' everywhere
17410 where we expect either a "member name" (GetEnumerator) or a
17411 "member name" with an explicit interface name
17412 (IEnumerable.GetEnumerator).
17413 In GMCS, the explicit interface name may include type arguments
17414 (IEnumerable<T>.GetEnumerator).
17415 * we use `member_name' instead of just `IDENTIFIER' for
17417 The rule is that we use `member_name' wherever a member may
17418 have type parameters in GMCS.
17420 * decl.cs (MemberName): New public class.
17421 (MemberCore.MemberName): New public readonly field.
17422 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17423 (DeclSpace): Likewise.
17425 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17426 * enum.cs (Enum.ctor): Likewise.
17428 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17430 (AliasEntry.ctor): Take a MemberName, not an Expression.
17431 (AliasEntry.UsingAlias): Likewise.
17433 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17434 (IMethodData.MemberName): Changed type from string to MemberName.
17435 (MemberBase.ExplicitInterfaceName): Likewise.
17436 (AbstractPropertyEventMethod.SetupName): Make this private.
17437 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17438 argument; compute the member name here.
17439 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17440 on the `member.MemberName' and the `prefix'.
17442 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17444 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17445 thus, we get a `MemberName' instead of a `string'. These
17446 declarations may have type parameters in GMCS.
17447 (interface_method_declaration, delegate_declaration): Likewise.
17448 (class_declaration, interface_declaration): Likewise.
17449 (method_header): Use `namespace_or_type_name' instead of
17450 `member_name'. We may be an explicit interface implementation.
17451 (property_declaration, event_declaration): Likewise.
17452 (member_name): This is now just an `IDENTIFIER', not a
17453 `namespace_or_type_name'.
17454 (type_name, interface_type): Removed.
17455 (namespace_or_type_name): Return a MemberName, not an Expression.
17456 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17457 call GetTypeExpression() on the MemberName to get an expression.
17458 (IndexerDeclaration.interface_type): Changed type from string to
17460 (MakeName): Operate on MemberName's instead of string's.
17462 2004-09-13 Raja R Harinath <rharinath@novell.com>
17465 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17466 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17467 lookup to avoid symbols introduced by 'using'.
17468 * rootcontext.cs (NamespaceLookup): Update.
17470 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17472 * class.cs (TypeContainer.DoDefineMembers): Do not call
17473 DefineDefaultConstructor for static classes.
17475 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17477 * attribute.cs (Attribute.Resolve): Add error 653 report.
17479 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17481 (Method.ApplyAttributeBuilder): Add error 685 report.
17482 (Operator.Define): Add error 564 report.
17484 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17486 * expression.cs (Invocation.DoResolve): Add error
17487 245 and 250 report.
17489 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17492 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17494 * class.cs (ConstructorInitializer.Resolve):
17495 Wrong error number (515->516).
17497 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17499 * class.cs (Indexer.Define): Add error 631 report.
17501 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17503 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17505 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17507 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17509 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17511 * cs-parser.jay: Added error CS0241 report.
17513 2004-09-10 Raja R Harinath <rharinath@novell.com>
17515 * cs-parser.jay (fixed_statement): Introduce a scope for the
17516 declaration in the 'fixed' statement.
17518 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17520 * cs-parser.jay: Added CS0230 error report.
17522 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17524 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17526 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17528 * expression.cs (Argument.Resolve): Added error CS0192 and
17531 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17533 C# 2.0 #pragma warning feature
17535 * cs-tokenizer.cs (PreProcessPragma): New method;
17536 Handles #pragma directive.
17538 * report.cs (WarningRegions): New class; Support
17539 class for #pragma warning directive. It tests whether
17540 warning is enabled for a given line.
17542 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17544 * const.cs: Add more descriptive error report, tahnks to
17547 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17549 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17551 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17553 * expression.cs: Apply patch from Ben: Remove dead code from
17554 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17555 as that code just threw an exception anwyays.
17557 * const.cs: Remove the call to the turnintoconstant, for details
17560 * literal.cs: The type of the null-literal is the null type; So
17561 we use a placeholder type (literal.cs:System.Null, defined here)
17564 * expression.cs (Conditional.DoResolve): Remove some old code that
17565 is no longer needed, conversions have been fixed.
17567 (ArrayCreationExpression.DoResolve): Return false if we fail to
17568 resolve the inner expression.
17570 2004-09-07 Raja R Harinath <rharinath@novell.com>
17573 * cs-parser.jay (delegate_declaration): Record a delegate
17574 declaration as a type declaration.
17575 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17577 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17579 * parameter.cs: Do not crash if the type can not be resolved.
17581 * expression.cs: Report errors with unsafe pointers, fixes #64896
17583 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17585 * expression.cs: Pointer arith always needs to do a conv.i
17586 if the operand is a long. fix 65320
17588 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17590 Fixed cs0619-37.cs, cs0619-38.cs
17592 * enum.cs (GetObsoleteAttribute): Removed.
17594 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17595 on Enum member is double staged. The first is tested member
17598 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17600 Fixed #56986, #63631, #65231
17602 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17603 adds member to name container.
17604 (TypeContainer.AddToTypeContainer): New method, adds type to
17606 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17607 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17608 AddOperator): Simplified by reusing AddToMemberContainer.
17609 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17611 (Method.CheckForDuplications): Fixed implementation to test all
17613 (MemberBase): Detection whether member is explicit interface
17614 implementation is now in constructor.
17615 (MemberBase.UpdateMemberName): Handles IndexerName.
17616 (Accessor): Changed to keep also location information.
17617 (AbstractPropertyEventMethod): Is derived from MemberCore.
17618 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17619 will be emited or not.
17620 (PropertyBase.AreAccessorsDuplicateImplementation):
17621 Tests whether accessors are not in collision with some method.
17622 (Operator): Is derived from MethodCore to simplify common
17625 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17627 (DeclSpace.AddToContainer): Adds the member to defined_names
17628 table. It tests for duplications and enclosing name conflicts.
17630 * enum.cs (EnumMember): Clean up to reuse the base structures
17632 2004-09-03 Martin Baulig <martin@ximian.com>
17634 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17635 into TypeContainer, to make partial classes work again.
17637 2004-09-03 Martin Baulig <martin@ximian.com>
17639 * rootcontext.cs (RootContext.V2): Removed.
17641 2004-03-23 Martin Baulig <martin@ximian.com>
17643 * expression.cs (Invocation.OverloadResolve): Added `bool
17644 may_fail' argument and use it instead of the Location.IsNull() hack.
17646 2004-09-03 Martin Baulig <martin@ximian.com>
17648 Merged latest changes into gmcs. Please keep this comment in
17649 here, it makes it easier for me to see what changed in MCS since
17650 the last time I merged.
17652 2004-09-03 Raja R Harinath <rharinath@novell.com>
17655 * expression.cs (BetterConversion): Don't allow either conversion
17656 to be null. Remove redundant implicit conversion test when 'q ==
17657 null' -- when this function is invoked, we already know that the
17658 implicit conversion exists.
17659 (BetterFunction): Assume that 'best' is non-null. Remove
17660 redundant reimplementation of IsApplicable when 'best' is null.
17661 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17662 number of arguments.
17663 (IsAncestralType): Extract from OverloadResolve.
17664 (OverloadResolve): Make robust to the MethodGroupExpr being
17665 unsorted. Implement all the logic of Section 14.5.5.1, and
17666 support overloading of methods from multiple applicable types.
17667 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17669 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17670 (RealError, Warning): Append type of report to related symbol.
17672 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17674 * enum.cs: Fixed CLS-Compliance checks for enum members.
17675 Error tests cs3008-8.cs, cs3014-8.cs
17677 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17679 Fixed bug #62342, #63102
17680 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17681 like ImplementMethod.
17683 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17685 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17688 2004-09-02 Martin Baulig <martin@ximian.com>
17690 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17691 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17694 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17696 C# 2.0 Static classes implemented
17698 * class.cs (TypeContainer): instance_constructors,
17699 initialized_fields, initialized_static_fields,
17700 default_constructor, base_inteface_types are protected to be
17701 accessible from StaticClass.
17702 (TypeContainer.DefineDefaultConstructor): New virtual method
17703 for custom default constructor generating
17704 (StaticClass): New class to handle "Static classes" feature.
17706 * cs-parser.jay: Handle static keyword on class like instance
17709 * driver.cs: Added "/langversion" command line switch with two
17710 options (iso-1, default).
17712 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17714 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17716 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17718 * delegate.cs: Style.
17720 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17722 * delegate.cs: Add seperate instance expr field for miguel.
17724 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17726 * PointerArithmetic (Resolve): make sure we are not doing
17727 pointer arith on void*. Also, make sure we are resolved
17728 by not setting eclass until resolve.
17730 All callers: Make sure that PointerArithmetic gets resolved.
17732 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17734 * ArrayCreation (LookupType): If the type does not resolve
17735 to an array, give an error.
17737 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17739 * statement.cs (Try.Resolve): Fixed bug #64222
17741 2004-08-27 Martin Baulig <martin@ximian.com>
17744 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17747 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17749 * ecore.cs (Constantify): Get underlying type via
17750 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17751 Windows in special cases.
17753 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17755 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17756 for obtaining also private methods.
17757 (GetRemoveMethod): Used GetRemoveMethod (true)
17758 for obtaining also private methods.
17760 2004-08-24 Martin Baulig <martin@ximian.com>
17762 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17763 MethodAttributes.HideBySig for operators.
17765 2004-08-23 Martin Baulig <martin@ximian.com>
17767 Back to the old error reporting system :-)
17769 * report.cs (Message): Removed.
17770 (Report.MessageData, ErrorData, WarningData): Removed.
17771 (Report.Error, Warning): Back to the old system.
17773 2004-08-23 Martin Baulig <martin@ximian.com>
17775 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17777 * class.cs (TypeContainer.ParentContainer): New public virtual
17778 method; replaces the explicit interface implementation.
17779 (ClassPart.ParentContainer): Override.
17781 2004-08-23 Martin Baulig <martin@ximian.com>
17783 * statement.cs (Switch): Added support for constant switches; see
17784 #59428 or test-285.cs.
17786 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17789 * statement.cs (GetEnumeratorFilter): Removed useless
17790 logic because C# specs is strict. GetEnumerator must be
17793 2004-08-22 Martin Baulig <martin@ximian.com>
17795 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17796 a switch and may break, reset the barrier. Fixes #59867.
17798 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17800 CLS-Compliance speed up (~5% for corlib)
17802 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17803 New method. Tests container for CLS-Compliant names
17805 * class.cs (TypeContainer.VerifyClsName): New method.
17806 Checks whether container name is CLS Compliant.
17807 (Constructor): Implements IMethodData.
17809 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17810 low-case table for CLS Compliance test.
17811 (MemberCache.VerifyClsParameterConflict): New method.
17812 Checks method parameters for CS3006 error.
17814 * enum.cs (EnumMember): Is derived from MemberCore.
17815 (Enum.VerifyClsName): Optimized for better performance.
17817 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17819 * report.cs: Renamed Error_T to Error and changed all
17822 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17824 * class.cs (TypeContainer.IndexerArrayList): New inner class
17825 container for indexers.
17826 (TypeContainer.DefaultIndexerName): New constant for default
17827 indexer name. Replaced all "Item" with this constant.
17828 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17830 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17831 DefaultMemberAttribute constructor.
17833 2004-08-05 Martin Baulig <martin@ximian.com>
17835 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17838 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17840 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17841 multi platforms problem.
17843 * compiler.csproj: Included shared files.
17845 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17847 Fix bug 60333, 55971 in the more general way
17848 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17849 Added arg_type argument for constant conversion.
17850 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17852 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17855 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17856 OperatorArrayList, MethodCoreArrayList for typecontainer
17857 containers. Changed class member types to these new types.
17858 (MethodArrayList.DefineMembers): Added test for CS0659.
17860 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17862 * cfold.cs: Synchronize the folding with the code in expression.cs
17863 Binary.DoNumericPromotions for uint operands.
17865 * attribute.cs: Revert patch from Raja, it introduced a regression
17866 while building Blam-1.2.1 (hard to isolate a test case).
17868 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17872 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17874 (MethodCore.parent_method): New member. The method we're overriding
17875 if this is an override method.
17876 (MethodCore.CheckBase): Moved from Method class and made common.
17877 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17879 (MethodCore.CheckForDuplications): New abstract method. For custom
17880 member duplication search in a container
17881 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17882 method and its return type.
17883 (Event.conflict_symbol): New member. Symbol with same name in the
17887 (MemberCache.FindMemberWithSameName): New method. The method
17888 is looking for conflict with inherited symbols.
17890 2004-08-04 Martin Baulig <martin@ximian.com>
17892 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17894 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17896 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17898 * report.cs (Message): New enum for better error, warning reference in
17900 (MessageData): New inner abstract class. It generally handles printing of
17901 error and warning messages.
17902 Removed unused Error, Warning, Message methods.
17904 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17906 Fix for cs0592-8.cs test
17908 (Attributable.ValidAttributeTargets): Made public.
17909 (Attribute.ExplicitTarget): New member for explicit target value.
17910 (Attribute.CheckTargets): Now we translate explicit attribute
17911 target to Target here.
17913 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17915 * ecore.cs (MethodGroupExpr): new IsBase property.
17917 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17919 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17920 rather than an instance expr.
17922 (DelegateCreation.Emit): Use the method group rather than
17923 the instance expression. Also, if you have base.Foo as the
17924 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17926 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17928 (NewDelegate.DoResolve): Only check for the existance of Invoke
17929 if the method is going to be needed. Use MethodGroupExpr.
17931 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17933 * expression.cs: For pointer arith., make sure to use
17934 the size of the type, not the size of the pointer to
17937 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17940 * class.cs (Class): Added error CS0502 test.
17942 2004-08-03 John Luke <jluke@cfl.rr.com>
17943 Raja R Harinath <rharinath@novell.com>
17946 * attribute.cs (Attribute.complained_before): New flag.
17947 (Attribute.ResolveType, Attribute.Resolve),
17948 (Attribute.DefinePInvokeMethod): Set it.
17949 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17951 2004-08-03 Martin Baulig <martin@ximian.com>
17953 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17954 use a user-defined operator; we still need to do numeric
17955 promotions in case one argument is a builtin type and the other
17956 one has an implicit conversion to that type. Fixes #62322.
17958 2004-08-02 Martin Baulig <martin@ximian.com>
17960 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17961 (LocalInfo.IsThis): New public property.
17962 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17964 2004-08-01 Martin Baulig <martin@ximian.com>
17966 * class.cs (TypeContainer.GetClassBases): Don't set the default
17967 here since we may get called from GetPartialBases().
17968 (TypeContainer.DefineType): If GetClassBases() didn't return a
17969 parent, use the default one.
17971 2004-07-30 Duncan Mak <duncan@ximian.com>
17973 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17975 2004-07-30 Martin Baulig <martin@ximian.com>
17977 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17979 * class.cs (SourceMethod): New public class, derive from the
17980 symbol writer's ISourceMethod.
17981 (Method): Use the new symbol writer API.
17983 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17984 as argument and use the new symbol writer.
17987 (SourceFile): Implement the symbol writer's ISourceFile.
17988 (Location.SymbolDocument): Removed.
17989 (Location.SourceFile): New public property.
17991 * symbolwriter.cs: Use the new symbol writer API.
17993 2004-07-30 Raja R Harinath <rharinath@novell.com>
17995 * Makefile (install-local): Remove. Functionality moved to
17998 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18000 * Makefile: Install mcs.exe.config file together with mcs.exe.
18001 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18002 correct runtime version.
18004 2004-07-25 Martin Baulig <martin@ximian.com>
18007 (TypeContainer.RegisterOrder): Removed, this was unused.
18008 (TypeContainer, interface_order): Removed.
18009 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18010 TypeContainer as argument since we can also be called with a
18011 `PartialContainer' for a partial class/struct/interface.
18012 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18013 of checking whether we're an `Interface' - we could be a
18014 `PartialContainer'.
18015 (PartialContainer.Register): Override; call
18016 AddClass()/AddStruct()/AddInterface() on our parent.
18018 * cs-parser.jay (interface_member_declaration): Add things to the
18019 `current_container', not the `current_class'.
18021 * rootcontext.cs (RegisterOrder): The overloaded version which
18022 takes an `Interface' was unused, removed.
18024 * typemanager.cs (TypeManager.LookupInterface): Return a
18025 `TypeContainer', not an `Interface'.
18026 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18027 contain a `PartialContainer' for an interface, so check it's
18028 `Kind' to figure out what it is.
18030 2004-07-25 Martin Baulig <martin@ximian.com>
18032 * class.cs (Class.DefaultTypeAttributes): New public constant.
18033 (Struct.DefaultTypeAttributes): Likewise.
18034 (Interface.DefaultTypeAttributes): Likewise.
18035 (PartialContainer.TypeAttr): Override this and add the
18036 DefaultTypeAttributes.
18038 2004-07-25 Martin Baulig <martin@ximian.com>
18040 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18041 we can just use the `Parent' field instead.
18043 2004-07-25 Martin Baulig <martin@ximian.com>
18045 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18047 2004-07-25 Martin Baulig <martin@ximian.com>
18049 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18050 our parts before defining any methods.
18051 (TypeContainer.VerifyImplements): Make this virtual.
18052 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18053 on our PartialContainer.
18055 2004-07-25 Martin Baulig <martin@ximian.com>
18057 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18059 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18060 argument, we can just use the `Parent' field instead.
18063 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18064 (MemberBase.DoDefine): Likewise.
18066 2004-07-24 Martin Baulig <martin@ximian.com>
18068 * decl.cs (MemberCore.Parent): New public field.
18069 (DeclSpace.Parent): Moved to MemberCore.
18071 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18072 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18074 (FieldBase, Field, Operator): Likewise.
18075 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18076 (EventField, Event): Likewise.
18078 2004-07-23 Martin Baulig <martin@ximian.com>
18080 * class.cs (PartialContainer): New public class.
18081 (ClassPart): New public class.
18082 (TypeContainer): Added support for partial classes.
18083 (TypeContainer.GetClassBases): Splitted some of the functionality
18084 out into GetNormalBases() and GetPartialBases().
18086 * cs-tokenizer.cs (Token.PARTIAL): New token.
18087 (Tokenizer.consume_identifier): Added some hacks to recognize
18088 `partial', but only if it's immediately followed by `class',
18089 `struct' or `interface'.
18091 * cs-parser.jay: Added support for partial clases.
18093 2004-07-23 Martin Baulig <martin@ximian.com>
18095 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18096 a `DeclSpace' and also made it readonly.
18097 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18098 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18099 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18101 * cs-parser.jay: Pass the `current_class', not the
18102 `current_container' (at the moment, this is still the same thing)
18103 to a new Method, Property, Event, Indexer or Constructor.
18105 2004-07-23 Martin Baulig <martin@ximian.com>
18107 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18108 and removed the `current_interface' one.
18109 (struct_declaration, class_declaration, interface_declaration):
18110 Set `current_class' to the newly created class/struct/interface;
18111 set their `Bases' and call Register() before parsing their body.
18113 2004-07-23 Martin Baulig <martin@ximian.com>
18115 * class.cs (Kind): New public enum.
18116 (TypeContainer): Made this class abstract.
18117 (TypeContainer.Kind): New public readonly field.
18118 (TypeContainer.CheckDef): New public method; moved here from
18120 (TypeContainer.Register): New public abstract method.
18121 (TypeContainer.GetPendingImplementations): New public abstract
18123 (TypeContainer.GetClassBases): Removed the `is_class' and
18124 `is_iface' parameters.
18125 (TypeContainer.DefineNestedTypes): Formerly known as
18127 (ClassOrStruct): Made this class abstract.
18129 * tree.cs (RootTypes): New public type.
18131 2004-07-20 Martin Baulig <martin@ximian.com>
18133 * tree.cs (Tree.RecordNamespace): Removed.
18134 (Tree.Namespaces): Removed.
18136 * rootcontext.cs (RootContext.IsNamespace): Removed.
18138 * cs-parser.jay (namespace_declaration): Just create a new
18139 NamespaceEntry here.
18141 2004-07-20 Martin Baulig <martin@ximian.com>
18143 * statement.cs (ExceptionStatement): New abstract class. This is
18144 now used as a base class for everyone who's using `finally'.
18145 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18146 our local variables before using them.
18148 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18149 virtual method. This is used by Yield.Resolve() to "steal" an
18150 outer block's `finally' clauses.
18151 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18154 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18155 version which takes an ExceptionStatement. This version must be
18156 used to create exception branchings.
18159 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18160 (Iterator.EmitMoveNext): Added exception support; protect the
18161 block with a `fault' clause, properly handle 'finally' clauses.
18162 (Iterator.EmitDispose): Run all the `finally' clauses here.
18164 2004-07-20 Martin Baulig <martin@ximian.com>
18166 * iterator.cs: This is the first of a set of changes in the
18167 iterator code. Match the spec more closely: if we're an
18168 IEnumerable, then GetEnumerator() must be called. The first time
18169 GetEnumerator() is called, it returns the current instance; all
18170 subsequent invocations (if any) must create a copy.
18172 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18174 * expression.cs: Resolve the constant expression before returning
18177 2004-07-19 Martin Baulig <martin@ximian.com>
18179 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18180 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18181 the return type of the new EmitContext.
18183 2004-07-18 Martin Baulig <martin@ximian.com>
18185 * class.cs (Property.Define): Fix iterators.
18187 * iterators.cs (Iterator.Define): Moved the
18188 `container.AddInterator (this)' call here from the .ctor; only do
18189 it if we resolved successfully.
18191 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18193 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18194 `true' for preprocessing directives that we parse. The return
18195 value indicates whether we should return to regular tokenizing or
18196 not, not whether it was parsed successfully.
18198 In the past if we were in: #if false ... #line #endif, we would
18199 resume parsing after `#line'. See bug 61604.
18201 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18202 building: IsEnumType should return true only for enums, not for
18203 enums or System.Enum itself. This fixes #61593.
18205 Likely what happened is that corlib was wrong: mcs depended on
18206 this bug in some places. The bug got fixed, we had to add the
18207 hack, which caused bug 61593.
18209 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18210 that was a workaround for the older conditions.
18212 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18214 * assign.cs: IAssignMethod has a new interface, as documented
18215 inline. All assignment code now uses this new api.
18217 * ecore.cs, expression.cs: All classes which implement
18218 IAssignMethod now use the new interface.
18220 * expression.cs (Invocation): add a hack to EmitCall so that
18221 IndexerAccess can be the target of a compound assignment without
18222 evaluating its arguments twice.
18224 * statement.cs: Handle changes in Invocation api.
18226 2004-07-16 Martin Baulig <martin@ximian.com>
18228 * iterators.cs: Rewrote this. We're now using one single Proxy
18229 class for both the IEnumerable and the IEnumerator interface and
18230 `Iterator' derives from Class so we can use the high-level API.
18232 * class.cs (TypeContainer.AddIterator): New method.
18233 (TypeContainer.DoDefineType): New protected virtual method, which
18234 is called from DefineType().
18235 (TypeContainer.DoDefineMembers): Call DefineType() and
18236 DefineMembers() on all our iterators.
18237 (TypeContainer.Emit): Call Emit() on all our iterators.
18238 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18240 * codegen.cs (EmitContext.CurrentIterator): New public field.
18242 2004-07-15 Martin Baulig <martin@ximian.com>
18245 (TypeManager.not_supported_exception_type): New type.
18247 2004-07-14 Martin Baulig <martin@ximian.com>
18249 * iterators.cs: Use real error numbers.
18251 2004-07-14 Martin Baulig <martin@ximian.com>
18253 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18254 requires this to be a System.Collection.IEnumerable and not a
18255 class implementing that interface.
18256 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18258 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18260 * class.cs: Fixed previous fix, it broke some error tests.
18262 2004-07-12 Martin Baulig <martin@ximian.com>
18264 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18267 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18269 * assign.cs (LocalTemporary): Add new argument: is_address,If
18270 `is_address' is true, then the value that we store is the address
18271 to the real value, and not the value itself.
18273 * ecore.cs (PropertyExpr): use the new local temporary
18274 stuff to allow us to handle X.Y += z (where X is a struct)
18276 2004-07-08 Martin Baulig <martin@ximian.com>
18278 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18279 not always return, just like we're doing in Using.Resolve().
18281 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18283 * cs-parser.jay (fixed_statement): flag this as Pinned.
18285 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18287 * typemanager.cs (TypeManager): Removed MakePinned method, this
18288 mechanism is replaced with the .NET 2.x compatible mechanism of
18289 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18291 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18292 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18293 `IsFixed' property which has a different meaning.
18295 2004-07-02 Raja R Harinath <rharinath@novell.com>
18297 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18298 visible from inside a nested class, not just the names of the
18299 immediately enclosing class.
18300 Fix for bug #60730.
18302 2004-06-24 Raja R Harinath <rharinath@novell.com>
18304 * expression.cs (BetterConversion): Remove buggy special-case
18305 handling of "implicit constant expression conversions". At this
18306 point, we already know that the conversion is possible -- we're
18307 only checking to see which is better.
18309 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18311 * cs-parser.jay: Added error CS0210 test.
18313 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18315 * cs-parser.jay: Added error CS0134 test.
18317 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18320 * cs-parser.jay: Added error CS0145 test.
18322 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18324 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18326 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18328 * expression.cs (StackAlloc.Resolve): The argument may not
18329 be a constant; deal with this case.
18331 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18333 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18334 GetIndexerAttributeValue.
18335 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18337 * class.cs (Indexer.Define): Added error tests for CS0415,
18340 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18342 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18345 2004-06-23 Martin Baulig <martin@ximian.com>
18347 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18348 neither return nor throw, reset the barrier as well. Fixes #60457.
18350 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18352 * class.cs : EventAttributes is now set to None by default.
18353 This fixes bug #60459.
18355 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18358 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18359 Don't throw exception but return null (it's sufficient now).
18361 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18363 * typemanager.cs (GetArgumentTypes): Faster implementation.
18365 2004-06-18 Martin Baulig <martin@ximian.com>
18367 * attribute.cs (Attribute.Resolve): Check whether we're an
18368 EmptyCast which a Constant child. Fixes #60333.
18370 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18372 * statement.cs (EmitCollectionForeach): Account for the fact that
18373 not all valuetypes are in areas which we can take the address of.
18374 For these variables, we store to a temporary variable. Also, make
18375 sure that we dont emit a `callvirt' on a valuetype method.
18377 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18379 * expression.cs (StackAlloc.DoReSolve): Added test for
18380 negative parameter (CS0247).
18382 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18385 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18387 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18390 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18393 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18395 Fix bug #58254 & cs1555.cs, cs1556.cs
18396 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18398 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18400 * cs-parser.jay: Added error CS1669 test for indexers.
18402 2004-06-11 Martin Baulig <martin@ximian.com>
18404 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18405 call this twice: for params and varargs methods.
18407 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18410 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18412 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18414 * attribute.cs (Attribute.GetValidTargets): Made public.
18417 (AbstractPropertyEventMethod): New class for better code sharing.
18418 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18420 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18422 2004-06-11 Raja R Harinath <rharinath@novell.com>
18425 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18426 that the call to Resolve is part of a MemberAccess.
18427 (Expression.Resolve): Use it for SimpleName resolution.
18428 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18429 Add 'intermediate' boolean argument.
18430 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18431 error message when the SimpleName can be resolved ambiguously
18432 between an expression and a type.
18433 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18435 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18436 call on the left-side.
18438 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18441 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18443 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18445 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18447 2004-06-11 Martin Baulig <martin@ximian.com>
18449 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18450 varargs methods if applicable.
18452 2004-06-11 Martin Baulig <martin@ximian.com>
18454 * expression.cs (Invocation.EmitCall): Don't use
18455 `method.CallingConvention == CallingConventions.VarArgs' since the
18456 method could also have `CallingConventions.HasThis'.
18458 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18460 * class.cs (Event.GetSignatureForError): Implemented.
18461 Fixed crash in error test cs3010.cs
18463 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18465 * cs-tokenizer.cs: Change the way we track __arglist to be
18466 consistent with the other keywords.
18468 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18470 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18473 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18475 * codegen.cs: Check that all referenced assemblies have a strongname
18476 before strongnaming the compiled assembly. If not report error CS1577.
18477 Fix bug #56563. Patch by Jackson Harper.
18478 * typemanager.cs: Added a method to return all referenced assemblies.
18479 Fix bug #56563. Patch by Jackson Harper.
18481 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18484 (Method.ApplyAttributeBuilder): Moved and added conditional
18485 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18488 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18490 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18493 * class.cs: (EventField.attribute_targets): Changed default target.
18495 2004-06-08 Martin Baulig <martin@ximian.com>
18497 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18499 2004-06-08 Martin Baulig <martin@ximian.com>
18501 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18503 2004-06-07 Martin Baulig <martin@ximian.com>
18505 Added support for varargs methods.
18507 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18510 * cs-parser.jay: Added support for `__arglist'.
18512 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18514 * expression.cs (Argument.AType): Added `ArgList'.
18515 (Invocation): Added support for varargs methods.
18516 (ArglistAccess): New public class.
18517 (Arglist): New public class.
18519 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18521 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18522 a method's top-level block if the method has varargs.
18524 * support.cs (ReflectionParameters, InternalParameters): Added
18525 support for varargs methods.
18527 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18529 * class.cs: Provide location in indexer error report.
18531 * driver.cs: Use standard names.
18533 * namespace.cs: Catch the use of using after a namespace has been
18534 declared also on using aliases.
18536 2004-06-03 Raja R Harinath <rharinath@novell.com>
18539 * typemanager.cs (closure_private_ok, closure_invocation_type)
18540 (closure_qualifier_type, closure_invocation_assembly)
18541 (FilterWithClosure): Move to ...
18542 (Closure): New internal nested class.
18543 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18544 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18545 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18546 (MemberLookup, MemberLookupFailed): Use it.
18547 * expression.cs (New.DoResolve): Treat the lookup for the
18548 constructor as being qualified by the 'new'ed type.
18549 (Indexers.GetIndexersForTypeOrInterface): Update.
18551 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18554 (GetConditionalAttributeValue): New method. Returns
18555 condition of ConditionalAttribute.
18556 (SearchMulti): New method. Returns all attributes of type 't'.
18557 Use it when attribute is AllowMultiple = true.
18558 (IsConditionalMethodExcluded): New method.
18561 (Method.IsExcluded): Implemented. Returns true if method has conditional
18562 attribute and the conditions is not defined (method is excluded).
18563 (IMethodData): Extended interface for ConditionalAttribute support.
18564 (PropertyMethod.IsExcluded): Implemented.
18567 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18570 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18573 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18575 * expression.cs (ArrayCreationExpression): Make this just an
18576 `expression'. It can't be a statement, so the code here was
18579 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18582 * typemanager.cs (GetFullNameSignature): New method for
18585 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18588 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18589 Use this method when MethodBuilder is null.
18590 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18591 Added test for error CS0626 (MONO reports error for this situation).
18592 (IMethodData.GetSignatureForError): Extended interface.
18594 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18597 (AttributeTester.GetObsoleteAttribute): Returns instance of
18598 ObsoleteAttribute when type is obsolete.
18601 (TypeContainer.VerifyObsoleteAttribute): Override.
18602 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18603 (MethodCode.VerifyObsoleteAttribute): Override.
18604 (MemberBase.VerifyObsoleteAttribute): Override.
18607 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18608 and report proper error.
18611 Delegate.VerifyObsoleteAttribute): Override.
18614 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18615 and report proper error.
18616 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18619 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18623 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18624 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18625 Added test for ObsoleteAttribute.
18628 (Catch): Derived from Statement.
18630 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18632 Fixed bug #59071 & cs0160.cs
18634 * statement.cs (Try.Resolve): Check here whether order of catch
18635 clauses matches their dependencies.
18637 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18639 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18640 caused a regression: #59343. Referencing nested classes from an
18641 assembly stopped working.
18643 2004-05-31 Martin Baulig <martin@ximian.com>
18645 MCS is now frozen for beta 2.
18647 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18649 * convert.cs: add a trivial cache for overload operator resolution.
18651 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18653 * decl.cs: If possible, use lookuptypedirect here. We can only do
18654 this if there is no `.' after the namespace. Avoids using
18655 LookupType, which does lots of slow processing.
18656 (FindNestedType) New method, does what it says :-).
18657 * namespace.cs: use LookupTypeDirect.
18658 * rootcontext.cs: use membercache, if possible.
18659 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18661 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18664 According to the spec,
18666 In a member access of the form E.I, if E is a single identifier,
18667 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18668 field, property, localvariable, or parameter with the same type as
18669 the meaning of E as a type-name (§3.8), then both possible
18670 meanings of E are permitted.
18672 We did not check that E as a simple-name had the same type as E as
18675 This trivial check gives us 5-7% on bootstrap time.
18677 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18679 * expression.cs (Invocation.OverloadResolve): Avoid the
18680 use of hashtables and boxing here by allocating on demand.
18682 2004-05-30 Martin Baulig <martin@ximian.com>
18684 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18685 we're doing a silent lookup. Don't try to lookup nested types in
18686 TypeManager.object_type (thanks to Ben Maurer).
18688 2004-05-30 Martin Baulig <martin@ximian.com>
18690 Committing a patch from Ben Maurer.
18692 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18694 2004-05-29 Martin Baulig <martin@ximian.com>
18696 * class.cs (IMethodData.ShouldIgnore): New method.
18698 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18699 `Location' argument, we don't need it anywhere. Use
18700 `IMethodData.ShouldIgnore ()' instead of
18701 `MethodData.GetMethodFlags ()'.
18702 (TypeManager.AddMethod): Removed.
18703 (TypeManager.AddMethod2): Renamed to AddMethod.
18705 2004-05-29 Martin Baulig <martin@ximian.com>
18707 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18709 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18710 converting from a class type S to an interface type and we already
18711 have an object on the stack, don't box it again. Fixes #52578.
18713 2004-05-29 Martin Baulig <martin@ximian.com>
18715 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18716 Added support for `params' parameters. Fixes #59267.
18718 2004-05-29 Martin Baulig <martin@ximian.com>
18720 * literal.cs (NullPointer): Provide a private .ctor which sets
18721 `type' to TypeManager.object_type. Fixes #59048.
18723 2004-05-29 Martin Baulig <martin@ximian.com>
18725 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18726 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18728 * ecore.cs (EventExpr.instance_expr): Make the field private.
18730 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18732 Fixed bug #50080 & cs0214-2.cs
18733 * expression.cs (Cast.DoResolve): Check unsafe context here.
18735 * statement.cs (Resolve.DoResolve): Likewise.
18737 2004-05-26 Martin Baulig <martin@ximian.com>
18739 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18741 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18742 (RootContext.LookupType): Pass down the `silent' flag.
18744 2004-05-25 Martin Baulig <martin@ximian.com>
18747 (MethodGroupExpr.IdenticalTypeName): New public property.
18748 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18749 expression actually refers to a type.
18751 2004-05-25 Martin Baulig <martin@ximian.com>
18753 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18754 for #56176 and made it actually work.
18756 2004-05-25 Martin Baulig <martin@ximian.com>
18758 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18759 (FieldExpr, PropertyExpr): Override and implement
18760 CacheTemporaries. Fixes #52279.
18762 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18764 * location.cs: In the new compiler listing a file twice is a
18765 warning, not an error.
18767 2004-05-24 Martin Baulig <martin@ximian.com>
18769 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18770 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18772 2004-05-24 Martin Baulig <martin@ximian.com>
18774 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18775 walking the `using' list. Fixes #53921.
18777 2004-05-24 Martin Baulig <martin@ximian.com>
18779 * const.cs (Const.LookupConstantValue): Added support for
18780 EmptyCast's; fixes #55251.
18782 2004-05-24 Martin Baulig <martin@ximian.com>
18784 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18785 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18786 which does the CS0135 check. The reason is that we first need to
18787 check whether the variable actually exists.
18789 2004-05-24 Martin Baulig <martin@ximian.com>
18791 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18792 than RootContext.LookupType() to find the explicit interface
18793 type. Fixes #58584.
18795 2004-05-24 Raja R Harinath <rharinath@novell.com>
18797 * Makefile: Simplify. Use executable.make.
18798 * mcs.exe.sources: New file. List of sources of mcs.exe.
18800 2004-05-24 Anders Carlsson <andersca@gnome.org>
18804 Use the invariant culture when doing String.Compare for CLS case
18807 2004-05-23 Martin Baulig <martin@ximian.com>
18809 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18810 don't have any dots. Fixes #52622, added cs0246-8.cs.
18812 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18814 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18816 * class.cs (MemberBase.Define): Reuse MemberType member for
18817 resolved type. Other methods can use it too.
18819 2004-05-23 Martin Baulig <martin@ximian.com>
18821 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18822 the variable also exists in the current block (otherwise, we need
18823 to report a CS0103). Fixes #58670.
18825 2004-05-23 Martin Baulig <martin@ximian.com>
18827 * flowanalysis.cs (Reachability.Reachable): Compute this
18828 on-the-fly rather than storing it as a field.
18830 2004-05-23 Martin Baulig <martin@ximian.com>
18832 * flowanalysis.cs (Reachability.And): Manually compute the
18833 resulting `barrier' from the reachability.
18835 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18838 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18839 instance of ObsoleteAttribute when symbol is obsolete.
18842 (IMethodData): Extended interface for ObsoleteAttribute support.
18844 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18846 * attribute.cs: Fix bug #55970
18848 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18852 (GetObsoleteAttribute): New method. Creates the instance of
18854 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18855 ObsoleteAttribute when member is obsolete.
18856 (AttributeTester.Report_ObsoleteMessage): Common method for
18857 Obsolete error/warning reporting.
18860 (TypeContainer.base_classs_type): New member for storing parent type.
18863 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18864 for this MemberCore.
18866 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18868 * attribute.cs, const.cs: Fix bug #58590
18870 2004-05-21 Martin Baulig <martin@ximian.com>
18872 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18873 out parameters if the end of the method is unreachable. Fixes
18876 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18878 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18879 Hari was right, why extra method.
18881 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18883 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18885 2004-05-20 Martin Baulig <martin@ximian.com>
18887 Merged this back from gmcs to keep the differences to a minumum.
18889 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18890 instead of a Declspace.
18891 (Attribute.ResolveType): Likewise.
18892 (Attributes.Search): Likewise.
18893 (Attributes.Contains): Likewise.
18894 (Attributes.GetClsCompliantAttribute): Likewise.
18896 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18898 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18901 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18903 Fix bug #58688 (MCS does not report error when the same attribute
18906 * attribute.cs (Attribute.Emit): Distinction between null and default.
18908 2004-05-19 Raja R Harinath <rharinath@novell.com>
18910 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18911 of a top-level attribute without an attribute target.
18912 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18914 (Attribute.Conditional_GetConditionName),
18915 (Attribute.Obsolete_GetObsoleteMessage): Update.
18916 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18917 part of ScanForIndexerName.
18918 (Attribute.CanIgnoreInvalidAttribute): New function.
18919 (Attribute.ScanForIndexerName): Move to ...
18920 (Attributes.ScanForIndexerName): ... here.
18921 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18922 (Attributes.Search): New internal variant that can choose not to
18923 complain if types aren't resolved. The original signature now
18925 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18926 complaints suppressed.
18927 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18928 only if it not useful.
18929 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18930 top-level for attributes that are shared between the assembly
18931 and a top-level class.
18932 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18933 * class.cs: Update to reflect changes.
18934 (DefineIndexers): Fuse loops.
18935 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18936 a couple more variants of attribute names.
18938 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18940 Fix bug #52585 (Implemented explicit attribute declaration)
18943 (Attributable.ValidAttributeTargets): New abstract method. It gets
18944 list of valid attribute targets for explicit target declaration.
18945 (Attribute.Target): It holds target itself.
18946 (AttributeSection): Removed.
18947 (Attribute.CheckTargets): New method. It checks whether attribute
18948 target is valid for the current element.
18951 (EventProperty): New class. For events that are declared like
18952 property (with add and remove accessors).
18953 (EventField): New class. For events that are declared like field.
18956 * cs-parser.jay: Implemented explicit attribute target declaration.
18958 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18959 Override ValidAttributeTargets.
18962 (ReturnParameter): Class for applying custom attributes on
18964 (ParameterAtribute): New class. Class for applying custom
18965 attributes on the parameter type.
18967 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18969 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18972 (Method): Allow UNSAFE here.
18974 * modifiers.cs: Support unsafe reporting.
18976 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18978 * decl.cs: Fix bug #58478.
18980 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18982 * statement.cs: When checking for unreachable code on an EmptyStatement,
18983 set the location. Fixes bug #58488.
18985 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18987 * driver.cs: Add -pkg handling.
18989 From Gonzalo: UseShelLExecute=false
18991 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18994 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18996 (Attribute.IsClsCompliaceRequired): Moved to base for better
18998 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18999 when attribute is AttributeUsageAttribute.
19000 (Attribute.GetValidTargets): Simplified.
19001 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19002 attribute for this type.
19003 (Attribute.ApplyAttributes): Method renamed to Emit and make
19005 (GlobalAttributeSection): New class for special handling of global
19006 attributes (assembly, module).
19007 (AttributeSection.Emit): New method.
19009 * class.cs: Implemented Attributable abstract methods.
19010 (MethodCore.LabelParameters): Moved to Parameter class.
19011 (Accessor): Is back simple class.
19012 (PropertyMethod): Implemented Attributable abstract class.
19013 (DelegateMethod): Implemented Attributable abstract class.
19014 (Event): New constructor for disctintion between normal Event
19015 and Event with accessors.
19017 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19019 * codegen.cs, const.cs, decl.cs, delegate.cs:
19020 (CommonAssemblyModulClass): Implemented Attributable abstract class
19023 * enum.cs: Implement IAttributeSupport interface.
19024 (EnumMember): New class for emum members. Implemented Attributable
19028 (ParameterBase): Is abstract.
19029 (ReturnParameter): New class for easier [return:] attribute handling.
19031 * typemanager.cs: Removed builder_to_attr.
19033 2004-05-11 Raja R Harinath <rharinath@novell.com>
19036 * attribute.cs (Attribute.GetPositionalValue): New function.
19037 * class.cs (TypeContainer.VerifyMembers): New function.
19038 (TypeContainer.Emit): Use it.
19039 (ClassOrStruct): New base class for Class and Struct.
19040 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19041 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19043 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19044 then each non-static field should have a FieldOffset attribute.
19045 Otherwise, none of the fields should have a FieldOffset attribute.
19046 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19047 and FieldOffset attributes.
19048 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19049 (TypeManager.field_offset_attribute_type): New core types.
19050 (TypeManager.InitCoreTypes): Initialize them.
19052 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19054 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19055 Return correct type.
19058 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19060 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19061 be implicitly converted to ulong.
19063 * expression.cs: The logic for allowing operator &, | and ^ worked
19064 was wrong, it worked before because we did not report an error in
19065 an else branch. Fixes 57895.
19067 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19068 allow volatile fields to be reference types.
19070 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19072 * driver.cs: Add support for /debug-
19074 2004-05-07 Raja R Harinath <rharinath@novell.com>
19076 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19077 Add a 'complain' parameter to silence errors.
19078 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19079 silently overlooked type-resolutions.
19080 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19081 to reflect changes.
19082 (Attributes.Search): New function.
19083 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19084 (Attributes.GetAttributeFullName): Remove hack.
19085 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19086 Update to reflect changes.
19087 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19088 Use Attributes.Search instead of nested loops.
19090 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19093 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19094 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19095 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19097 * report.cs: (Report.Warning): Renamed to Warning_T because of
19098 parameter collision.
19100 2004-05-05 Raja R Harinath <rharinath@novell.com>
19102 * expression.cs (MemberAccess.ResolveMemberAccess):
19103 Exit with non-zero status after Report.Error.
19104 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19106 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19108 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19110 * support.cs: Don't hang when the file is empty.
19112 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19114 * support.cs: In SeekableStreamReader, compute the preamble size of the
19115 underlying stream. Position changes should take into account that initial
19118 2004-05-03 Todd Berman <tberman@sevenl.net>
19120 * driver.cs: remove unused GetSysVersion function.
19122 2004-05-03 Todd Berman <tberman@sevenl.net>
19124 * driver.cs: Remove the hack from saturday, as well as the hack
19125 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19126 link_paths to get that bit proper.
19128 2004-05-01 Todd Berman <tberman@sevenl.net>
19130 * driver.cs: Try a LoadFrom before a Load, this checks the current
19131 path. This is currently a bug in mono that is be fixed, however, this
19132 provides a workaround for now. This will be removed when the bug
19135 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19137 * CryptoConvert.cs: Updated to latest version. Fix issue with
19138 incomplete key pairs (#57941).
19140 2004-05-01 Todd Berman <tberman@sevenl.net>
19142 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19145 2004-04-30 Jackson Harper <jackson@ximian.com>
19147 * codegen.cs: Open keys readonly.
19149 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19151 * typemanager.cs: don't report cyclic struct layout when a struct
19152 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19153 which has 2 Pango.Rectangle fields.
19155 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19157 * expression.cs: Handle IntPtr comparisons with IL code
19158 rather than a method call.
19160 2004-04-29 Martin Baulig <martin@ximian.com>
19162 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19163 the list of PropertyInfo's in class hierarchy and find the
19164 accessor. Fixes #56013.
19166 2004-04-29 Martin Baulig <martin@ximian.com>
19168 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19170 2004-04-29 Martin Baulig <martin@ximian.com>
19172 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19174 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19176 2004-04-29 Martin Baulig <martin@ximian.com>
19178 * class.cs (ConstructorInitializer.Resolve): Check whether the
19179 parent .ctor is accessible. Fixes #52146.
19181 2004-04-29 Martin Baulig <martin@ximian.com>
19183 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19185 * statement.cs (Using.EmitLocalVariableDecls): Use
19186 TypeManager.idisposable_type, not typeof (IDisposable).
19187 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19189 2004-04-29 Martin Baulig <martin@ximian.com>
19191 * class.cs (Event.Define): Don't emit the field and don't set
19192 RTSpecialName and SpecialName for events on interfaces. Fixes
19195 2004-04-29 Raja R Harinath <rharinath@novell.com>
19197 Refactor Attribute.ApplyAttributes.
19198 * attribute.cs (Attributable): New base class for objects that can
19199 have Attributes applied on them.
19200 (Attribute): Make AttributeUsage fields public.
19201 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19202 (Attribute.IsInternalCall): New property.
19203 (Attribute.UsageAttr): Convert to a public read-only property.
19204 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19205 (Attribute.ResolveType, Attribute.Resolve)
19206 (Attribute.ScanForIndexerName): Update to reflect changes.
19207 (Attribute.CheckAttributeTarget): Re-format.
19208 (Attribute.ApplyAttributes): Refactor, to various
19209 Attributable.ApplyAttributeBuilder methods.
19210 * decl.cs (MemberCore): Make Attributable.
19211 * class.cs (Accessor): Make Attributable.
19212 (MethodData.ApplyAttributes): Use proper attribute types, not
19214 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19215 (TypeContainer.ApplyAttributeBuilder)
19216 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19217 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19218 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19219 (Operator.ApplyAttributeBuilder): New factored-out methods.
19220 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19221 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19222 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19223 * parameter.cs (ParameterBase): New Attributable base class
19224 that can also represent Return types.
19225 (Parameter): Update to the changes.
19227 2004-04-29 Jackson Harper <jackson@ximian.com>
19229 * driver.cs: Prefer the corlib system version when looking for
19230 assemblies in the GAC. This is still a hack, but its a better hack
19233 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19235 * decl.cs, enum.cs: Improved error 3005 reporting.
19237 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19238 (related_symbols): New private member for list of symbols
19239 related to reported error/warning.
19241 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19243 2004-04-29 Martin Baulig <martin@ximian.com>
19245 * ecore.cs (Expression.Constantify): If we're an enum and
19246 TypeManager.TypeToCoreType() doesn't give us another type, use
19247 t.UnderlyingSystemType. Fixes #56178.
19249 2004-04-29 Martin Baulig <martin@ximian.com>
19251 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19252 interfaces and for each interface, only add members directly
19253 declared in that interface. Fixes #53255.
19255 2004-04-28 Martin Baulig <martin@ximian.com>
19257 * expression.cs (ConditionalLogicalOperator): Use a temporary
19258 variable for `left' to avoid that we evaluate it more than once;
19261 2004-04-28 Martin Baulig <martin@ximian.com>
19263 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19266 2004-04-28 Martin Baulig <martin@ximian.com>
19268 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19271 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19272 whether the type is not void (CS1547).
19274 2004-04-28 Martin Baulig <martin@ximian.com>
19276 * expression.cs (Unary.DoResolveLValue): Override this and report
19277 CS0131 for anything but Operator.Indirection.
19279 2004-04-28 Martin Baulig <martin@ximian.com>
19281 Committing a patch from Ben Maurer; see bug #50820.
19283 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19286 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19289 2004-04-28 Martin Baulig <martin@ximian.com>
19291 Committing a patch from Ben Maurer; see bug #50820.
19293 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19296 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19299 2004-04-28 Martin Baulig <martin@ximian.com>
19301 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19302 (Block.AddLabel): Call DoLookupLabel() to only search in the
19305 2004-04-28 Martin Baulig <martin@ximian.com>
19307 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19308 comparing StringConstants and NullLiterals in Equality and Inequality.
19310 2004-04-28 Jackson Harper <jackson@ximian.com>
19312 * driver.cs: Attempt to load referenced assemblies from the
19313 GAC. This is the quick and dirty version of this method that
19314 doesnt take into account versions and just takes the first
19315 canidate found. Will be good enough for now as we will not have more
19316 then one version installed into the GAC until I update this method.
19318 2004-04-28 Martin Baulig <martin@ximian.com>
19320 * typemanager.cs (TypeManager.CheckStructCycles): New public
19321 static method to check for cycles in the struct layout.
19323 * rootcontext.cs (RootContext.PopulateTypes): Call
19324 TypeManager.CheckStructCycles() for each TypeContainer.
19325 [Note: We only need to visit each type once.]
19327 2004-04-28 Martin Baulig <martin@ximian.com>
19329 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19331 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19332 success and added `out object value'. Use a `bool resolved' field
19333 to check whether we've already been called rather than
19334 `ConstantValue != null' since this breaks for NullLiterals.
19336 2004-04-28 Raja R Harinath <rharinath@novell.com>
19338 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19339 setting of this flag, since the 'set' method may be non-public.
19341 2004-04-28 Raja R Harinath <rharinath@novell.com>
19343 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19344 check on current_vector.Block.
19346 2004-04-27 Martin Baulig <martin@ximian.com>
19348 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19349 a field initializer. Fixes #56459.
19351 2004-04-27 Martin Baulig <martin@ximian.com>
19353 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19354 we're not attempting to use an indexer. Fixes #52154.
19356 2004-04-27 Martin Baulig <martin@ximian.com>
19358 * statement.cs (Return): Don't create a return label if we don't
19359 need it; reverts my change from January 20th. Thanks to Ben
19362 2004-04-27 Martin Baulig <martin@ximian.com>
19364 According to the spec, `goto' can only leave a nested scope, but
19367 * statement.cs (Block.LookupLabel): Only lookup in the current
19368 block, don't recurse into parent or child blocks.
19369 (Block.AddLabel): Check in parent and child blocks, report
19370 CS0140/CS0158 if we find a duplicate.
19371 (Block): Removed this indexer for label lookups.
19372 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19373 this already does the error reporting for us.
19376 (FlowBranching.UsageVector.Block): New public variable; may be null.
19377 (FlowBranching.CreateSibling): Added `Block' argument.
19378 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19379 label for the target of a `goto' and check whether we're not
19380 leaving a `finally'.
19382 2004-04-27 Martin Baulig <martin@ximian.com>
19384 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19385 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19388 2004-04-27 Martin Baulig <martin@ximian.com>
19390 * statement.cs (Block.AddLabel): Also check for implicit blocks
19391 and added a CS0158 check.
19393 2004-04-27 Martin Baulig <martin@ximian.com>
19395 * flowanalysis.cs (FlowBranchingLoop): New class.
19396 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19397 UsageVector's instead of an ArrayList.
19398 (FlowBranching.Label): Likewise.
19399 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19400 (FlowBranching.AddBreakVector): New method.
19402 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19404 * attribute.cs: Small regression fix: only convert the type if we
19405 the type is different, fixes System.Drawing build.
19407 2004-04-27 Martin Baulig <martin@ximian.com>
19409 * attribute.cs (Attribute.Resolve): If we have a constant value
19410 for a named field or property, implicity convert it to the correct
19413 2004-04-27 Raja R Harinath <rharinath@novell.com>
19415 * statement.cs (Block.Block): Implicit blocks share
19416 'child_variable_names' fields with parent blocks.
19417 (Block.AddChildVariableNames): Remove.
19418 (Block.AddVariable): Mark variable as "used by a child block" in
19419 every surrounding block.
19420 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19421 been used in a child block, complain about violation of "Invariant
19422 meaning in blocks" rule.
19423 * cs-parser.jay (declare_local_variables): Don't use
19424 AddChildVariableNames.
19425 (foreach_statement): Don't create an implicit block: 'foreach'
19426 introduces a scope.
19428 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19430 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19431 converting from 0L to ulong. Fixes 57522.
19433 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19435 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19436 derived class hides via 'new' keyword field from base class (test-242.cs).
19437 TODO: Handle this in the more general way.
19439 * class.cs (CheckBase): Ditto.
19441 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19443 * decl.cs (caching_flags): New member for storing cached values
19445 (MemberCore.Flags): New enum where bit flags for caching_flags
19447 (MemberCore.cls_compliance): Moved to caching_flags.
19448 (DeclSpace.Created): Moved to caching_flags.
19450 * class.cs: Use caching_flags instead of DeclSpace.Created
19452 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19454 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19455 if we are only a derived class, not a nested class.
19457 * typemanager.cs: Same as above, but do this at the MemberLookup
19458 level (used by field and methods, properties are handled in
19459 PropertyExpr). Allow for the qualified access if we are a nested
19462 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19464 * class.cs: Refactoring.
19465 (IMethodData): New inteface; Holds links to parent members
19466 to avoid member duplication (reduced memory allocation).
19467 (Method): Implemented IMethodData interface.
19468 (PropertyBase): New inner classes for get/set methods.
19469 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19470 (Event): New inner classes for add/remove methods.
19471 (Event.DelegateMethod): Implemented IMethodData interface.
19473 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19474 EmitContext (related to class.cs refactoring).
19476 2004-04-21 Raja R Harinath <rharinath@novell.com>
19478 * delegate.cs (Delegate.VerifyApplicability): If the number of
19479 arguments are the same as the number of parameters, first try to
19480 verify applicability ignoring any 'params' modifier on the last
19484 2004-04-16 Raja R Harinath <rharinath@novell.com>
19486 * class.cs (TypeContainer.AddIndexer): Use
19487 'ExplicitInterfaceName' to determine if interface name was
19488 explicitly specified. 'InterfaceType' is not initialized at this time.
19489 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19490 Indexers array is already in the required order. Initialize
19491 'IndexerName' only if there are normal indexers.
19492 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19493 (TypeContainer.Emit): Emit DefaultMember attribute only if
19494 IndexerName is initialized.
19497 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19499 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19502 2004-04-15 Raja R Harinath <rharinath@novell.com>
19504 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19508 * attribute.cs (Attribute.Resolve): Check for duplicate named
19512 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19514 * iterators.cs (MarkYield): track whether we are in an exception,
19515 and generate code accordingly. Use a temporary value to store the
19516 result for our state.
19518 I had ignored a bit the interaction of try/catch with iterators
19519 since their behavior was not entirely obvious, but now it is
19520 possible to verify that our behavior is the same as MS .NET 2.0
19524 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19526 * iterators.cs: Avoid creating temporaries if there is no work to
19529 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19530 Enumerations, use TypeManager.EnumToUnderlying and call
19533 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19536 (This.Emit): Use EmitContext.EmitThis to emit our
19539 (This.EmitAssign): Ditto.
19541 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19542 codepaths, we will move all the functionality into
19545 (FieldExpr.EmitAssign): Ditto.
19547 This fixes several hidden bugs that I uncovered while doing a code
19548 review of this today.
19550 * codegen.cs (EmitThis): reworked so the semantics are more clear
19551 and also support value types "this" instances.
19553 * iterators.cs: Changed so that for iterators in value types, we
19554 do not pass the value type as a parameter.
19556 Initialization of the enumerator helpers is now done in the caller
19557 instead of passing the parameters to the constructors and having
19558 the constructor set the fields.
19560 The fields have now `assembly' visibility instead of private.
19562 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19564 * expression.cs (Argument.Resolve): Check if fields passed as ref
19565 or out are contained in a MarshalByRefObject.
19567 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19568 another compiler type.
19570 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19572 * class.cs (Indexer.Define): use the new name checking method.
19573 Also, return false on an error.
19574 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19575 (is_identifier_[start/part]_character): make static.
19577 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19579 * expression.cs (Binary.ResolveOperator): Do no append strings
19580 twice: since we can be invoked more than once (array evaluation)
19581 on the same concatenation, take care of this here. Based on a fix
19582 from Ben (bug #56454)
19584 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19586 * codegen.cs: Fix another case where CS1548 must be reported (when
19587 delay-sign isn't specified and no private is available #56564). Fix
19588 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19589 error when MCS is used on the MS runtime and we need to delay-sign
19590 (which seems unsupported by AssemblyBuilder - see #56621).
19592 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19594 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19595 (TypeManager.ComputeNamespaces): Faster implementation for
19598 * compiler.csproj: Updated AssemblyName to mcs.
19600 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19602 * rootcontext.cs: Add new types to the boot resolution.
19604 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19605 MulticastDelegate is not allowed.
19607 * typemanager.cs: Add new types to lookup: System.TypedReference
19610 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19611 check for TypedReference or ArgIterator, they are not allowed.
19613 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19614 makes us properly catch 1510 in some conditions (see bug 56016 for
19617 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19619 * CryptoConvert.cs: update from corlib version
19622 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19624 * class.cs (Indexer.Define): Check indexername declaration
19626 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19628 * attribute.cs (IsClsCompliant): Fixed problem with handling
19629 all three states (compliant, not-compliant, undetected).
19631 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19633 * attribute.cs (Attribute): Location is now public.
19634 (Resolve): Store resolved arguments (pos_values) in attribute class.
19635 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19636 (GetClsCompliantAttributeValue): New method that gets
19637 CLSCompliantAttribute value.
19638 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19639 if exists else null.
19640 (AttributeTester): New class for CLS-Compliant verification routines.
19642 * class.cs (Emit): Add CLS-Compliant verification.
19643 (Method.GetSignatureForError): Implemented.
19644 (Constructor.GetSignatureForError): Implemented
19645 (Constructor.HasCompliantArgs): Returns if constructor has
19646 CLS-Compliant arguments.
19647 (Constructor.Emit): Override.
19648 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19649 is needed to test only parameters.
19650 (FieldBase.GetSignatureForError): Implemented.
19651 (TypeContainer): New member for storing base interfaces.
19652 (TypeContainer.FindMembers): Search in base interfaces too.
19654 * codegen.cs (GetClsComplianceAttribute): New method that gets
19655 assembly or module CLSCompliantAttribute value.
19656 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19658 (ModuleClass.Emit): Add error 3012 test.
19660 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19662 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19663 state for all decl types.
19664 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19665 if CLS-Compliant tests are required.
19666 (IsClsCompliaceRequired): New method. Analyze whether code
19667 must be CLS-Compliant.
19668 (IsExposedFromAssembly): New method. Returns true when MemberCore
19669 is exposed from assembly.
19670 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19671 value or gets cached value.
19672 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19673 is explicitly marked with CLSCompliantAttribute.
19674 (IsIdentifierClsCompliant): New abstract method. This method is
19675 used to testing error 3005.
19676 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19677 for identifier and parameters CLS-Compliant testing.
19678 (VerifyClsCompliance): New method. The main virtual method for
19679 CLS-Compliant verifications.
19680 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19681 null. I don't know why is null (too many public members !).
19682 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19683 and get value of first CLSCompliantAttribute that found.
19685 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19686 (VerifyClsCompliance): Override and add extra tests.
19688 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19689 clscheck- disable CLS-Compliant verification event if assembly is has
19690 CLSCompliantAttribute(true).
19692 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19693 ApllyAttribute is now called in emit section as in the other cases.
19694 Possible future Emit integration.
19695 (IsIdentifierClsCompliant): New override.
19696 (VerifyClsCompliance): New override.
19697 (GetEnumeratorName): Returns full enum name.
19699 * parameter.cs (GetSignatureForError): Implemented.
19701 * report.cs (WarningData): New struct for Warning message information.
19702 (LocationOfPreviousError): New method.
19703 (Warning): New method. Reports warning based on the warning table.
19704 (Error_T): New method. Reports error based on the error table.
19706 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19707 verifications are done here.
19709 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19711 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19712 CLSCompliantAttribute.
19713 (all_imported_types): New member holds all imported types from other
19715 (LoadAllImportedTypes): New method fills static table with exported types
19716 from all referenced assemblies.
19717 (Modules): New property returns all assembly modules.
19719 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19721 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19722 throwing a parser error.
19724 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19725 which removes the hardcoded get_/set_ prefixes for properties, as
19726 IL allows for the properties to be named something else.
19730 * expression.cs: Do not override operand before we know if it is
19731 non-null. Fix 56207
19733 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19735 * typemanager.cs: support for pinned variables.
19737 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19739 * decl.cs, typemanager.cs: Avoid using an arraylist
19740 as a buffer if there is only one result set.
19742 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19744 * expression.cs: Make sure you cant call a static method
19745 with an instance expression, bug #56174.
19747 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19749 * class.cs (IsDuplicateImplementation): Improve error reporting to
19750 flag 663 (method only differs in parameter modifier).
19752 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19753 in preprocessor directives.
19755 * location.cs (LookupFile): Allow for the empty path.
19757 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19758 better approach for some of that patch, but its failing with the
19759 CharSet enumeration. For now try/catch will do.
19761 * typemanager.cs: Do not crash if a struct does not have fields.
19764 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19766 * expression.cs: cs0213, cant fix a fixed expression.
19769 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19771 * cs-parser.jay: detect invalid embeded statements gracefully.
19774 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19776 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19779 the invocation type may not be a subclass of the tye of the item/
19780 The type of the item must be a subclass of the invocation item.
19785 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19787 * attribute.cs: Added methods to get a string and a bool from an
19788 attribute. Required to information from AssemblyKeyFileAttribute,
19789 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19790 * codegen.cs: Modified AssemblyName creation to include support for
19791 strongnames. Catch additional exceptions to report them as CS1548.
19792 * compiler.csproj: Updated include CryptoConvert.cs.
19793 * compiler.csproj.user: Removed file - user specific configuration.
19794 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19795 Mono.Security assembly. The original class is maintained and tested in
19796 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19797 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19798 like CSC 8.0 (C# v2) supports.
19799 * Makefile: Added CryptoConvert.cs to mcs sources.
19800 * rootcontext.cs: Added new options for strongnames.
19802 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19804 * driver.cs: For --expect-error, report error code `2'
19805 if the program compiled with no errors, error code `1' if
19806 it compiled with an error other than the one expected.
19808 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19810 * compiler.csproj: Updated for Visual Studio .NET 2003.
19811 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19812 * compiler.sln: Updated for Visual Studio .NET 2003.
19814 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19816 * expression.cs: Fix bug #47234. We basically need to apply the
19817 rule that we prefer the conversion of null to a reference type
19818 when faced with a conversion to 'object' (csc behaviour).
19820 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19822 * statement.cs: Shorter form for foreach, eliminates
19823 a local variable. r=Martin.
19825 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19827 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19828 checks if we can use brtrue/brfalse to test for 0.
19829 * expression.cs: use the above in the test for using brtrue/brfalse.
19830 cleanup code a bit.
19832 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19834 * expression.cs: Rewrite string concat stuff. Benefits:
19836 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19837 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19838 rather than a concat chain.
19840 * typemanager.cs: Add lookups for more concat overloads.
19842 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19844 * expression.cs: Emit shorter il code for array init.
19861 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19863 * statement.cs: Before, two switch blocks would be merged if the
19864 total size of the blocks (end_item - begin_item + 1) was less than
19865 two times the combined sizes of the blocks.
19867 Now, it will only merge if after the merge at least half of the
19872 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19874 * class.cs : csc build fix for GetMethods(). See bug #52503.
19876 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19878 * expression.cs: Make sure fp comparisons work with NaN.
19879 This fixes bug #54303. Mig approved this patch a long
19880 time ago, but we were not able to test b/c the runtime
19883 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19885 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19887 2004-03-19 Martin Baulig <martin@ximian.com>
19889 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19890 error here and not in our caller.
19892 2004-03-19 Martin Baulig <martin@ximian.com>
19894 * interface.cs: Completely killed this file.
19895 (Interface): We're now a TypeContainer and live in class.cs.
19897 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19898 argument; we're now also called for interfaces.
19899 (TypeContainer.DefineMembers): Allow this method being called
19901 (TypeContainer.GetMethods): New public method; formerly known as
19902 Interface.GetMethod(). This is used by PendingImplementation.
19903 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19904 it's now private and non-static.
19905 (Interface): Moved this here; it's now implemented similar to
19907 (Method, Property, Event, Indexer): Added `bool is_interface'
19908 argument to their .ctor's.
19909 (MemberBase.IsInterface): New public field.
19911 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19912 instances instead of InterfaceMethod, InterfaceProperty, etc.
19913 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19914 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19916 2004-03-19 Martin Baulig <martin@ximian.com>
19918 * class.cs (MethodCore.IsDuplicateImplementation): New private
19919 method which does the CS0111 checking.
19920 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19921 Use IsDuplicateImplementation().
19923 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19925 * decl.cs (FindMemberToOverride): New method to find the correct
19926 method or property to override in the base class.
19928 - Make Method/Property use the above method to find the
19929 version in the base class.
19930 - Remove the InheritableMemberSignatureCompare as it is now
19933 This patch makes large code bases much faster to compile, as it is
19934 O(n) rather than O(n^2) to do this validation.
19936 Also, it fixes bug 52458 which is that nested classes are not
19937 taken into account when finding the base class member.
19939 Reviewed/Approved by Martin.
19941 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19943 * interface.cs: In all interface classes removed redundant
19944 member initialization.
19946 2004-03-16 Martin Baulig <martin@ximian.com>
19948 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19950 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19952 * decl.cs (DefineTypeAndParents): New helper method to define a
19953 type's containers before the type itself is defined; This is a
19954 bug exposed by the recent changes to Windows.Forms when an
19955 implemented interface was defined inside a class that had not been
19958 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19960 (Check): Loop correctly to report errors modifiers
19961 (UNSAFE was not in the loop, since it was the same as TOP).
19963 * interface.cs: Every interface member now takes a ModFlags,
19964 instead of a "is_new" bool, which we set on the base MemberCore.
19966 Every place where we called "UnsafeOk" in the interface, now we
19967 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19968 the unsafe settings from the member declaration instead of the
19969 container interface.
19971 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19973 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19974 `set_indexer_name' to the pending bits (one per type).
19976 We fixed a bug today that was picking the wrong method to
19977 override, since for properties the existing InterfaceMethod code
19978 basically ignored the method name. Now we make sure that the
19979 method name is one of the valid indexer names.
19981 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19983 * support.cs (SeekableStreamReader): Keep track of stream byte
19984 positions and don't mix them with character offsets to the buffer.
19986 Patch from Gustavo Giráldez
19988 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19990 * interface.cs (InterfaceSetGetBase): Removed double member
19991 initialization, base class does it as well.
19993 2004-03-13 Martin Baulig <martin@ximian.com>
19995 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19996 when compiling corlib.
19998 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20000 * convert.cs (ExplicitConversion): We were reporting an error on
20001 certain conversions (object_type source to a value type, when the
20002 expression was `null') before we had a chance to pass it through
20003 the user defined conversions.
20005 * driver.cs: Replace / and \ in resource specifications to dots.
20008 * class.cs: Add check for duplicate operators. Fixes 52477
20010 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20012 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20013 that are in the middle of the statements, not only at the end.
20016 * class.cs (TypeContainer.AddField): No longer set the
20017 `HaveStaticConstructor' flag, now we call it
20018 `UserDefineStaticConstructor' to diferentiate the slightly
20019 semantic difference.
20021 The situation is that we were not adding BeforeFieldInit (from
20022 Modifiers.TypeAttr) to classes that could have it.
20023 BeforeFieldInit should be set to classes that have no static
20028 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20030 And most importantly Zoltan's comment:
20032 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20034 "I think beforefieldinit means 'it's ok to initialize the type sometime
20035 before its static fields are used', i.e. initialization does not need
20036 to be triggered by the first access to the type. Setting this flag
20037 helps the JIT to compile better code, since it can run the static
20038 constructor at JIT time, and does not need to generate code to call it
20039 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20040 this flag for lots of classes like String.
20042 csc sets this flag if the type does not have an explicit static
20043 constructor. The reasoning seems to be that if there are only static
20044 initalizers for a type, and no static constructor, then the programmer
20045 does not care when this initialization happens, so beforefieldinit
20048 This bug prevents the AOT compiler from being usable, since it
20049 generates so many calls to mono_runtime_class_init that the AOT code
20050 is much slower than the JITted code. The JITted code is faster,
20051 because it does not generate these calls if the vtable is type is
20052 already initialized, which is true in the majority of cases. But the
20053 AOT compiler can't do this."
20055 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20057 * class.cs (MethodData.Emit): Refactor the code so symbolic
20058 information is generated for destructors; For some reasons we
20059 were taking a code path that did not generate symbolic information
20062 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20064 * class.cs: Create a Constructor.CheckBase method that
20065 takes care of all validation type code. The method
20066 contains some code that was moved from Define.
20068 It also includes new code that checks for duplicate ctors.
20069 This fixes bug #55148.
20071 2004-03-09 Joshua Tauberer <tauberer@for.net>
20073 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20074 a { ... }-style array creation invokes EmitStaticInitializers
20075 which is not good for reference-type arrays. String, decimal
20076 and now null constants (NullCast) are not counted toward
20077 static initializers.
20079 2004-03-05 Martin Baulig <martin@ximian.com>
20081 * location.cs (SourceFile.HasLineDirective): New public field;
20082 specifies whether the file contains or is referenced by a "#line"
20084 (Location.DefineSymbolDocuments): Ignore source files which
20085 either contain or are referenced by a "#line" directive.
20087 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20089 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20090 direct access to our parent, so check the method inline there.
20092 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20094 * expression.cs (Invocation.EmitCall): Miguel's last commit
20095 caused a regression. If you had:
20100 In Foo the implict this would be null.
20102 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20104 * expression.cs (Invocation.EmitCall): If the method is not
20105 virtual, do not emit a CallVirt to it, use Call.
20107 * typemanager.cs (GetFullNameSignature): Improve the method to
20108 cope with ".ctor" and replace it with the type name.
20110 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20111 as an argument the ConstructorBuilder where it is being defined,
20112 to catch the recursive constructor invocations.
20114 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20116 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20117 routines to check if a type is an enumerable/enumerator allow
20118 classes that implement the IEnumerable or IEnumerator interfaces.
20120 * class.cs (Property, Operator): Implement IIteratorContainer, and
20121 implement SetYields.
20123 (Property.Define): Do the block swapping for get_methods in the
20124 context of iterators. We need to check if Properties also
20125 include indexers or not.
20127 (Operator): Assign the Block before invoking the
20128 OperatorMethod.Define, so we can trigger the Iterator code
20131 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20132 Property and Operator classes are not created when we parse the
20133 declarator but until we have the block completed, so we use a
20134 singleton SimpleIteratorContainer.Simple to flag whether the
20135 SetYields has been invoked.
20137 We propagate this setting then to the Property or the Operator to
20138 allow the `yield' to function.
20140 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20142 * codegen.cs: Implemented attribute support for modules.
20143 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20144 Assembly/Module functionality.
20146 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20147 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20148 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20150 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20152 * interface.cs (FindMembers): The operation is performed on all base
20153 interfaces and not only on the first. It is required for future CLS Compliance patch.
20155 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20157 * statement.cs, codegen.cs:
20158 This patch deals with patterns such as:
20160 public class List : IEnumerable {
20162 public MyEnumerator GetEnumerator () {
20163 return new MyEnumerator(this);
20166 IEnumerator IEnumerable.GetEnumerator () {
20170 public struct MyEnumerator : IEnumerator {
20175 Before, there were a few things we did wrong:
20176 1) we would emit callvirt on a struct, which is illegal
20177 2) we emited ldarg when we needed to emit ldarga
20178 3) we would mistakenly call the interface methods on an enumerator
20179 type that derived from IEnumerator and was in another assembly. For example:
20181 public class MyEnumerator : IEnumerator
20183 Would have the interface methods called, even if there were public impls of the
20184 method. In a struct, this lead to invalid IL code.
20186 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20188 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20191 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20193 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20195 * cs-parser.jay: Fix small regression: we were not testing V2
20196 compiler features correctly.
20198 * interface.cs: If the emit context is null, then create one
20200 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20202 * decl.cs (GetSignatureForError): New virtual method to get full name
20203 for error messages.
20205 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20206 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20208 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20209 Duplicated members and code in these classes has been removed.
20210 Better encapsulation in these classes.
20212 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20214 * assign.cs (Assign.DoResolve): When dealing with compound
20215 assignments, there is a new rule in ECMA C# 2.4 (might have been
20216 there before, but it is documented here) that states that in:
20220 If b is of type int, and the `op' is a shift-operator, then the
20221 above is evaluated as:
20225 * expression.cs (Binary.ResolveOperator): Instead of testing for
20226 int/uint/long/ulong, try to implicitly convert to any of those
20227 types and use that in pointer arithmetic.
20229 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20230 method to print information for from the type, not from the
20231 null-method we were given.
20233 2004-02-01 Duncan Mak <duncan@ximian.com>
20235 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20236 parsing for cmd, fixes bug #53694.
20238 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20240 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20241 in the member name duplication tests. Property and operator name duplication
20242 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20244 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20246 * interface.cs (PopulateMethod): Fixed crash when interface method
20247 returns not existing type (error test cs0246-3.cs).
20249 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20251 * cs-parser.jay (interface_accessors): Re-write actions to also
20252 store attributes attached to get and set methods. Fix spelling
20255 (inteface_property_declaration): Modify accordingly.
20257 (InterfaceAccessorInfo): New helper class to store information to pass
20258 around between rules that use interface_accessors.
20260 * interface.cs (Emit): Apply attributes on the get and set
20261 accessors of properties and indexers too.
20263 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20264 right MethodBuilder when applying attributes to the get and set accessors.
20266 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20268 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20270 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20272 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20274 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20276 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20277 changes that treat `yield' specially when present before `break'
20278 or `return' tokens.
20280 * cs-tokenizer.cs: yield is no longer a keyword.
20282 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20284 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20285 setting for default constructors.
20286 For default constructors are almost every time set wrong Modifier. The
20287 generated IL code has been alright. But inside mcs this values was
20288 wrong and this was reason why several of my CLS Compliance tests
20291 2004-01-22 Martin Baulig <martin@ximian.com>
20293 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20294 not a QualifiedIdentifier. This is what `type_name_expression'
20295 was previously doing.
20296 (type_name_expression): Removed; the code is now in
20297 `namespace_or_type_name'.
20298 (qualified_identifier): Removed, use `namespace_or_type_name'
20300 (QualifiedIdentifier): Removed this class.
20302 2004-01-22 Martin Baulig <martin@ximian.com>
20304 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20305 not a string as alias name.
20307 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20309 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20310 #52730 bug, and instead compute correctly the need to use a
20311 temporary variable when requesting an address based on the
20312 static/instace modified of the field and the constructor.
20314 2004-01-21 Martin Baulig <martin@ximian.com>
20316 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20317 class and namespace before looking up aliases. Fixes #52517.
20319 2004-01-21 Martin Baulig <martin@ximian.com>
20321 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20322 assinged in a 'try'; fixes exception4.cs.
20324 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20325 * class.cs : Implemented parameter-less constructor for TypeContainer
20327 * decl.cs: Attributes are now stored here. New property OptAttributes
20329 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20331 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20333 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20335 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20336 (CSharpSignature): New method for indexer and property signature.
20338 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20340 * pending.cs (IsVirtualFilter): Faster implementation.
20342 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20344 * typemanager.cs: Avoid inclusion of same assembly more than once.
20346 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20348 * cs-parser.jay: Fixed problem where the last assembly attribute
20349 has been applied also to following declaration (class, struct, etc.)
20351 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20353 * class.cs: Added error CS0538, CS0539 reporting.
20354 Fixed crash on Microsoft runtime when field type is void.
20356 * cs-parser.jay: Added error CS0537 reporting.
20358 * pending.cs: Added error CS0535 reporting.
20359 Improved error report for errors CS0536, CS0534.
20361 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20363 Merge a few bits from the Anonymous Method MCS tree.
20365 * statement.cs (ToplevelBlock): New class for toplevel methods,
20366 will hold anonymous methods, lifted variables.
20368 * cs-parser.jay: Create toplevel blocks for delegates and for
20369 regular blocks of code.
20371 2004-01-20 Martin Baulig <martin@ximian.com>
20373 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20374 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20375 and `NeedExplicitReturn'; added `IsLastStatement'.
20376 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20377 have a `ReturnLabel' or we're not unreachable.
20379 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20380 child's reachability; don't just override ours with it. Fixes
20381 #58058 (lluis's example).
20382 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20383 InFinally(), InLoop(), InSwitch() and
20384 BreakCrossesTryCatchBoundary() methods.
20386 * statement.cs (Return): Do all error checking in Resolve().
20387 Unless we are the last statement in a top-level block, always
20388 create a return label and jump to it.
20389 (Break, Continue): Do all error checking in Resolve(); also make
20390 sure we aren't leaving a `finally'.
20391 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20392 statement in a top-level block.
20393 (Block.Flags): Added `IsDestructor'.
20394 (Block.IsDestructor): New public property.
20396 2004-01-20 Martin Baulig <martin@ximian.com>
20398 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20400 2004-01-20 Martin Baulig <martin@ximian.com>
20402 * statement.cs (Statement.ResolveUnreachable): New public method.
20403 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20404 (Block.Resolve): Resolve unreachable statements.
20406 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20408 * expression.cs: We need to fix the case where we do
20409 not have a temp variable here.
20411 * assign.cs: Only expression compound assignments need
20412 temporary variables.
20414 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20416 * flowanalysis.cs: Reduce memory allocation in a few ways:
20417 - A block with no variables should not allocate a bit
20419 - A method with no out parameters does not need any tracking
20420 for assignment of the parameters, so we need not allocate
20423 public readonly Type[] VariableTypes;
20424 public readonly string[] VariableNames;
20425 Are redundant. The data is already stored in the variable
20426 map, so we need not allocate another array for it.
20427 - We need to add alot of checks for if (params | locals) == null
20428 due to the first two changes.
20430 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20432 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20433 implement IMemoryLocation, we store a copy on a local variable and
20434 take the address of it. Patch from Benjamin Jemlich
20436 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20437 to use a special "type_name_expression" rule which reduces the
20438 number of "QualifiedIdentifier" classes created, and instead
20439 directly creates MemberAccess expressions.
20441 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20443 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20444 that fixes #52853. Null literal assignment to ValueType
20446 * class.cs (MethodData.Emit): Instead of checking the name of the
20447 method to determine if its a destructor, create a new derived
20448 class from Method called Destructor, and test for that.
20450 * cs-parser.jay: Create a Destructor object instead of a Method.
20452 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20456 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20458 * expression.cs (Binary.ResolveOperator): Perform an implicit
20459 conversion from MethodGroups to their delegate types on the
20460 Addition operation.
20462 * delegate.cs: Introduce a new class DelegateCreation that is the
20463 base class for `NewDelegate' and `ImplicitDelegateCreation',
20464 factor some code in here.
20466 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20467 conversion from MethodGroups to compatible delegate types.
20469 * ecore.cs (Expression.Resolve): Do not flag error 654
20470 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20471 we allow conversions from MethodGroups to delegate types now.
20473 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20474 assignments in v2 either.
20476 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20478 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20479 static read-only fields in ctors.
20481 Applied patch from Benjamin Jemlich
20483 * expression.cs (UnaryMutator): Avoid leaking local variables.
20485 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20487 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20488 here to return true, as they can be used like this:
20490 (XXX) int.MEMBER ()
20492 Fixed 49836 and all the other dups
20494 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20496 * driver.cs: Implement /win32res and /win32icon.
20498 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20500 * cs-parser.jay: Add a rule to improve error handling for the
20501 common mistake of placing modifiers after the type.
20503 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20505 * cs-parser.jay (interface_event_declaration): Catch
20506 initialization of events on interfaces, and report cs0068
20508 * cs-parser.jay (interface_event_declaration): Catch
20509 initialization of events.
20511 * ecore.cs: Better report missing constructors.
20513 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20514 the error reporting done in the wrong place. Fix.
20516 * expression.cs (Binary.ResolveOperator): Catch the
20517 operator + (E x, E y) error earlier, and later allow for implicit
20518 conversions in operator +/- (E e, U x) from U to the underlying
20521 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20522 52596, if the container class is abstract, the default constructor
20523 is protected otherwise its public (before, we were always public).
20525 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20528 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20529 Jemlich that fixes bug #52597, MCS was generating invalid code for
20530 idisposable structs. Thanks to Ben for following up with this
20533 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20535 * driver.cs: Allow assemblies without code to be generated, fixes
20538 2004-01-07 Nick Drochak <ndrochak@gol.com>
20540 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20542 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20544 * cs-parser.jay: Add rules to improve error reporting if fields or
20545 methods are declared at the namespace level (error 116)
20547 * Add rules to catch event add/remove
20549 2004-01-04 David Sheldon <dave-mono@earth.li>
20551 * expression.cs: Added matching ")" to error message for
20554 2004-01-03 Todd Berman <tberman@gentoo.org>
20556 * ecore.cs, attribute.cs:
20557 Applying fix from #52429.
20559 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20561 * ecore.cs, expression.cs, statement.cs:
20562 Total rewrite of how we handle branching. We
20563 now handle complex boolean expressions with fewer
20564 jumps. As well if (x == 0) no longer emits a ceq.
20566 if (x is Foo) is much faster now, because we generate
20569 Overall, we get a pretty big improvement on our benchmark
20570 tests. The code we generate is smaller and more readable.
20572 I did a full two-stage bootstrap. The patch was reviewed
20573 by Martin and Miguel.
20575 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20577 * cs-parser.jay: Make primary_expression not take a QI.
20578 we dont need this because the member_access rule covers
20579 us here. So we replace the rule with just IDENTIFIER.
20581 This has two good effects. First, we remove a s/r conflict.
20582 Second, we allocate many fewer QualifiedIdentifier objects.
20584 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20586 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20587 set the correct information via SRE. This prevents
20588 hanging on the MS runtime. Fixes #29374.
20590 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20592 * convert.cs: correctly handle conversions to value types
20593 from Enum and ValueType as unboxing conversions.
20595 Fixes bug #52569. Patch by Benjamin Jemlich.
20597 2004-01-02 Ravi Pratap <ravi@ximian.com>
20599 * expression.cs (BetterConversion): Prefer int -> uint
20600 over int -> ulong (csc's behaviour). This fixed bug #52046.
20602 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20604 * decl.cs (MemberCache.FindMembers): now returns a
20607 * typemanager.cs: In general, go with with ^^.
20608 (CopyNewMethods): take an IList.
20609 (RealMemberLookup): Only allocate an arraylist
20610 if we copy from two sets of methods.
20612 This change basically does two things:
20613 1) Fewer array lists allocated due to CopyNewMethods.
20614 2) the explicit cast in MemberList costed ALOT.
20616 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20618 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20619 a hashtable to avoid needless string allocations when an identifier is
20620 used more than once (the common case).
20622 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20624 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20625 is broken, it will not return anything. So, we
20626 have to use the information we have in mcs to
20629 * typemanager.cs: Add a cache for GetInterfaces,
20630 since this will now be used more often (due to ^^)
20632 (GetExplicitInterfaces) New method that gets the
20633 declared, not effective, interfaces on a type
20634 builder (eg, if you have interface IFoo, interface
20635 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20638 This patch makes MCS able to bootstrap itself on
20641 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20643 * expression.cs: Remove the Nop's that Miguel put
20646 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20648 * report.cs, codegen.cs: Give the real stack trace to
20649 the error when an exception is thrown.
20651 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20653 * decl.cs: only allocate hashtables for ifaces if
20656 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20658 * expression.cs: fix the error from cs0121-2.cs
20659 (a parent interface has two child interfaces that
20660 have a function with the same name and 0 params
20661 and the function is called through the parent).
20663 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20665 * class.cs, rootcontext.cs, typmanager.cs: do not
20668 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20670 * codegen.cs: remove stack for the ec flow branching.
20671 It is already a linked list, so no need.
20673 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20675 * Makefile: Allow custom profiler here.
20677 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20679 * typemanager.cs (LookupType):
20680 - Use a static char [], because split takes
20681 a param array for args, so it was allocating
20683 - Do not store true in a hashtable, it boxes.
20685 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20687 * flowanalysis.cs: bytify common enums.
20689 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20691 * modifiers.cs: Add a new set of flags for the
20692 flags allowed on explicit interface impls.
20693 * cs-parser.jay: catch the use of modifiers in
20694 interfaces correctly.
20695 * class.cs: catch private void IFoo.Blah ().
20697 All related to bug #50572.
20699 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20701 * decl.cs: Rewrite the consistant accessability checking.
20702 Accessability is not linear, it must be implemented in
20703 a tableish way. Fixes #49704.
20705 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20707 * expression.cs: Handle negation in a checked context.
20708 We must use subtraction from zero. Fixes #38674.
20710 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20712 * class.cs: Ignore static void main in DLLs.
20713 * rootcontext.cs: Handle the target type here,
20714 since we are have to access it from class.cs
20715 * driver.cs: account for the above.
20717 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20719 * report.cs: Give line numbers and files if available.
20721 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20723 * driver.cs: Implement /addmodule.
20725 * typemanager.cs: Change 'modules' field so it now contains Modules not
20728 2003-12-20 Martin Baulig <martin@ximian.com>
20730 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20731 (FieldBase.IsAssigned): Removed this field.
20732 (FieldBase.SetAssigned): New public method.
20733 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20735 2003-12-20 Martin Baulig <martin@ximian.com>
20737 * expression.cs (LocalVariableReference.DoResolve): Don't set
20738 `vi.Used' if we're called from DoResolveLValue().
20740 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20741 returns the usage vector it just merged into the current one -
20742 pass this one to UsageWarning().
20743 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20744 of the `EmitContext', don't call this recursively on our children.
20746 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20748 * driver.cs: Implement /target:module.
20750 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20752 * support.cs (CharArrayHashtable): New helper class.
20754 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20755 char arrays, not strings, so we can avoid creating a string in
20756 consume_identifier if the identifier is a keyword.
20758 2003-12-16 Martin Baulig <martin@ximian.com>
20760 * statement.cs (LocalInfo.Assigned): Removed this property.
20761 (LocalInfo.Flags): Removed `Assigned'.
20762 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20763 and uses flow analysis.
20764 (Block.UsageWarning): Made this method private.
20765 (Block.Resolve): Call UsageWarning() if appropriate.
20767 * expression.cs (LocalVariableReference.DoResolve): Always set
20768 LocalInfo.Used here.
20770 2003-12-13 Martin Baulig <martin@ximian.com>
20772 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20773 any value here; we're now using flow analysis to figure out
20774 whether a statement/block returns a value.
20776 2003-12-13 Martin Baulig <martin@ximian.com>
20778 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20780 (FlowBranching.MergeFinally): Don't call
20781 `branching.CheckOutParameters()' here, this is called in
20783 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20784 when adding the `finally' vector.
20786 2003-12-13 Martin Baulig <martin@ximian.com>
20789 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20790 actually work and also fix #48962.
20792 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20794 * decl.cs: Do not check System.Object for nested types,
20795 since we know it does not have any. Big bang for buck:
20798 Run 1: 8.35 seconds
20799 Run 2: 8.32 seconds
20800 corlib: 17.99 seconds
20802 Run 1: 8.17 seconds
20803 Run 2: 8.17 seconds
20804 corlib: 17.39 seconds
20806 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20808 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20809 time we are returning 0 members, so we save alot here.
20811 2003-12-11 Martin Baulig <martin@ximian.com>
20813 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20814 `MergeChild()', also just take the `FlowBranching' as argument;
20815 call Merge() on it and return the result.
20816 (FlowBranching.Merge): We don't need to do anything if we just
20819 2003-12-11 Martin Baulig <martin@ximian.com>
20821 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20822 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20823 Maurer for this idea.
20825 2003-12-11 Martin Baulig <martin@ximian.com>
20827 * flowanalysis.cs (MergeResult): This class is now gone; we now
20828 use the `UsageVector' for this. The reason for this is that if a
20829 branching just has one sibling, we don't need to "merge" them at
20830 all - that's the next step to do.
20831 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20834 2003-12-11 Martin Baulig <martin@ximian.com>
20836 Reworked flow analyis and made it more precise and bug-free. The
20837 most important change is that we're now using a special `Reachability'
20838 class instead of having "magic" meanings of `FlowReturns'. I'll
20839 do some more cleanups and optimizations and also add some more
20840 documentation this week.
20842 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20843 largely reworked this class.
20844 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20845 the new `Reachability' class instead of having "magic" values here.
20846 (FlowBranching): We're now using an instance of `Reachability'
20847 instead of having separate `Returns', `Breaks' etc. fields.
20849 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20850 based on flow analysis; ignore the return value of block.Emit ().
20852 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20854 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20855 if they are private.
20857 2003-12-09 Martin Baulig <martin@ximian.com>
20859 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20860 call them directly on the UsageVector.
20862 2003-12-09 Martin Baulig <martin@ximian.com>
20864 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20865 Changed return type from `FlowReturns' to `Reachability'.
20867 2003-12-09 Martin Baulig <martin@ximian.com>
20869 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20870 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20871 `Reachable' fields with a single `Reachability' one.
20873 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20875 * class.cs (FindMembers): Remove foreach's.
20880 Run 1: 8.74 seconds
20881 Run 2: 8.71 seconds
20884 Run 1: 8.64 seconds
20885 Run 2: 8.58 seconds
20888 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20893 This patch does a few things:
20894 1. EmptyStatement is now a singleton, so it is never reallocated.
20895 2. All blah is EmptyStatement constructs have been changed to
20896 blah == EmptyStatement.Value, which is much faster and valid
20897 now that EmptyStatement is a singleton.
20898 3. When resolving a block, rather than allocating a new array for
20899 the non-empty statements, empty statements are replaced with
20900 EmptyStatement.Value
20901 4. Some recursive functions have been made non-recursive.
20902 Mainly the performance impact is from (3), however (1) and (2) are needed for
20903 this to work. (4) does not make a big difference in normal situations, however
20904 it makes the profile look saner.
20909 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20910 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20911 Total memory allocated: 56397 KB
20914 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20915 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20916 Total memory allocated: 55666 KB
20918 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20920 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20921 than the hashtable in a hashtable version
20923 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20924 we always end up concating a string. This results in a huge perf
20925 loss, because many strings have to be tracked by the GC. In this
20926 patch, we first use a hashtable that works with two keys, so that
20927 the strings do not need to be concat'ed.
20931 Run 1: 8.74 seconds
20932 Run 2: 8.71 seconds
20935 Run 1: 8.65 seconds
20936 Run 2: 8.56 seconds
20938 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20940 * Makefile: Add a new target `do-time' that does a quick and simple
20941 profile, leaving easy to parse output.
20943 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20945 * codegen.cs (Init): Create the dynamic assembly with
20946 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20948 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20950 * support.cs: Make the PtrHashtable use only one
20951 instance of its comparer.
20953 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20955 * typemanager.cs: Fix lookup of GetNamespaces.
20957 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20959 * expression.cs: Removed redundant line.
20961 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20962 ArrayLists, use for loops with bounds.
20964 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20967 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20968 arraylists, use for loop with bounds.
20970 The above three changes give us a 0.071 second performance
20971 improvement out of 3.294 seconds down to 3.223. On my machine
20972 the above changes reduced the memory usage by 1,387 KB during
20973 compiler bootstrap.
20975 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20976 QualifiedIdentifiers. Before we created a new string through
20977 concatenation, and mostly later on, the result would be
20978 manipulated by DecomposeQI through string manipulation.
20980 This reduced the compiler memory usage for bootstrapping from
20981 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20982 compile times in 0.05 seconds.
20984 2003-11-28 Dick Porter <dick@ximian.com>
20986 * support.cs: Do string compares with the Invariant culture.
20994 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20995 the comparison is done with the Invariant culture.
20997 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20999 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21000 GetEnumerator method.
21002 (ProbeCollectionType): Iterate starting at the most specific type
21003 upwards looking for a GetEnumerator
21005 * expression.cs: Shift count can be up to 31 for int/uint and 63
21008 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21010 * statement.cs (Block.LookupLabel): Also look for the label on the
21011 children blocks. Use a hash table to keep track of visited
21014 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21015 we actually did transform the other operand, otherwise fall back
21016 to the common codepath that casts to long.
21018 * cs-tokenizer.cs: Use the same code pattern as the int case.
21019 Maybe I should do the parsing myself, and avoid depending on the
21020 Parse routines to get this done.
21022 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21024 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21025 which fixes bug 51347. This time test it.
21027 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21028 attributes for example can not tell the difference between these.
21029 The difference was only a syntax feature of the language.
21031 * attribute.cs: Apply attributes to delegates.
21033 * delegate.cs: Call the apply attributes method.
21035 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21037 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21038 comparing 0 vs Byte.MinValue, not the value
21040 (ImplicitConversionRequired): When reporting a conversion error,
21041 use error 31 to print out the constant error instead of the
21044 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21045 which fixes bug 51347.
21047 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21049 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21050 which fixes the -warnaserror command line option.
21052 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21054 * cfold.cs (DoNumericPromotions): During constant folding of
21055 additions on UIntConstant, special case intconstants with
21056 IntConstants like we do on the expression binary operator.
21058 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21060 * convert.cs (ImplicitReferenceConversion): We were missing a case
21061 (System.Enum are not value types or class types, so we need to
21062 classify them separatedly).
21064 * driver.cs: We do not support error 2007.
21066 2003-11-12 Jackson Harper <jackson@ximian.com>
21068 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21069 system directory. Also use the full file name so users can
21070 libraries names mscorlib-o-tron.dll in a non system dir.
21072 2003-11-10 Martin Baulig <martin@ximian.com>
21074 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21075 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21076 calling `ResolveType()' on them, directly assign their `Type'.
21078 2003-11-08 Martin Baulig <martin@ximian.com>
21080 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21081 return value and the `out parent' parameter.
21082 (TypeContainer.DefineType): Moved the CS0644 check into
21083 GetClassBases(). Don't pass the interface types to the
21084 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21085 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21087 * ecore.cs (TypeExpr.IsAttribute): New property.
21088 (TypeExpr.GetInterfaces): New method.
21090 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21091 TypeExpr instead of a Type.
21092 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21093 (Interface.DefineType): Don't pass the interface types to the
21094 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21095 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21097 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21098 instead of a `Type[]'.
21099 (TypeManager.RegisterBuilder): Likewise.
21100 (TypeManager.AddUserInterface): Likewise.
21101 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21102 `Type[]' and also return a `TypeExpr[]'.
21103 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21105 2003-11-08 Martin Baulig <martin@ximian.com>
21107 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21110 2003-11-08 Martin Baulig <martin@ximian.com>
21112 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21113 TypeManager.ResolveExpressionTypes().
21115 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21116 instead of an Expression.
21117 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21118 (TypeExpression): New public class; formerly known as `TypeExpr'.
21120 * expression.cs (ComposedCast): Derive from TypeExpr.
21122 * typemanager.cs (TypeManager.system_*_expr): These are now
21123 TypExpr's instead of Expression's.
21124 (TypeManager.ResolveExpressionTypes): New public static function;
21125 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21128 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21130 * expression.cs (New.DoResolve): Do not dereference value that
21131 might be a null return.
21133 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21134 sure that the constant value has the right type. Fixes an
21135 unreported bug, similar to 50425.
21137 * const.cs (Const.LookupConstantValue): Call
21138 ImplicitStandardConversionExists before doing a conversion to
21139 avoid havng the TypeManager.ChangeType do conversions.
21141 Reduced the number of casts used
21143 (Const.ChangeType): New routine to enable reuse of the constant
21144 type changing code from statement.
21146 * typemanager.cs (ChangeType): Move common initialization to
21147 static global variables.
21151 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21152 every value type to go through, even if it was void. Fix that.
21154 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21155 character of the define, and the is_identifier_part_character for
21156 the rest of the string.
21158 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21160 * expression.cs (UnaryMutator.EmitCode): When I updated
21161 LocalVariableReference.DoResolve, I overdid it, and dropped an
21162 optimization done on local variable references.
21164 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21166 * ecore.cs: Convert the return from Ldlen into an int.
21168 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21170 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21171 the accessibility, this is a special case for toplevel non-public
21172 classes (internal for instance).
21174 2003-10-20 Nick Drochak <ndrochak@gol.com>
21176 * ecore.cs: Fix typo and build. Needed another right paren.
21178 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21180 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21181 `internal' case regular and protected, but not allowing protected
21182 to be evaluated later. Bug 49840
21184 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21186 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21187 to kb.Nlast, and not the kb.nFirst to isolate the switch
21190 Extract the underlying type, so enumerations of long/ulong are
21191 treated like long/ulong.
21193 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21195 * expression.cs (New): Overload the meaning of RequestedType to
21196 track the possible creation of the NewDelegate type, since
21197 DoResolve is invoked more than once for new constructors on field
21200 See bugs: #48800 and #37014
21202 * cs-parser.jay (declare_local_constants): Take an arraylist
21203 instead of a single constant.
21205 (local_constant_declaration): It should take a
21206 constant_declarators, not a constant_declarator. Fixes 49487
21208 * convert.cs: Fix error report.
21210 2003-10-13 Jackson Harper <jackson@ximian.com>
21212 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21215 2003-10-09 Martin Baulig <martin@ximian.com>
21217 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21219 (MethodCore.DoDefineParameters): Removed the TypeContainer
21220 argument; use the DeclSpace which was passed to the .ctor instead.
21221 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21222 TypeContainer; we only need a DeclSpace here.
21224 2003-10-09 Martin Baulig <martin@ximian.com>
21226 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21228 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21229 EmitContext's .ctor.
21231 2003-10-09 Martin Baulig <martin@ximian.com>
21233 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21234 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21235 AsAccessible(), moved them as well.
21237 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21239 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21241 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21243 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21245 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21246 generation for >=, as spotted by Paolo, bug 48679.
21247 Patch from David Waite.
21249 * cs-tokenizer.cs: Add handling for #pragma.
21251 * cs-parser.jay: Allow for both yield and yield return in the
21252 syntax. The anti-cobolization of C# fight will go on!
21254 * class.cs (TypeBuilder.DefineType): Catch error condition here
21255 (Parent.DefineType erroring out and returning null).
21257 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21258 coping with enumerations variables, we were mistakenly processing
21259 them as a regular value type instead of built-in types. Fixes the
21262 * typemanager.cs (IsBuiltinOrEnum): New method.
21264 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21266 * cs-parser.jay: Upgrade: yield now needs the return clause.
21268 2003-09-19 Martin Baulig <martin@ximian.com>
21270 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21271 `MemberCache parent' argument. Normally, an interface doesn't
21272 have a parent type except System.Object, but we use this in gmcs
21273 for generic type parameters.
21275 2003-09-18 Martin Baulig <martin@ximian.com>
21277 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21278 on `type.IsInterface'; don't check whether the type has a parent
21279 to determine whether it's an interface.
21281 2003-09-15 Martin Baulig <martin@ximian.com>
21283 * class.cs (TypeContainer.DefineType): Added an error flag to
21284 avoid reporting duplicate CS0146's ("class definition is
21287 * driver.cs (Driver.MainDriver): Abort if
21288 RootContext.ResolveTree() reported any errors.
21290 2003-09-07 Martin Baulig <martin@ximian.com>
21292 * report.cs (Error, Warning): Added overloaded versions which take
21293 a `params object[] args' and call String.Format().
21295 2003-09-07 Martin Baulig <martin@ximian.com>
21297 * decl.cs (DeclSpace..ctor): Don't call
21298 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21299 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21300 (DeclSpace.RecordDecl): New method.
21302 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21304 2003-09-02 Ravi Pratap <ravi@ximian.com>
21306 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21307 value attributes to be applied to ParameterBuilders.
21309 * class.cs (MethodCore.LabelParameters): Make static and more
21310 generic so that it can be used from other places - like interface
21311 methods, for instance.
21313 * interface.cs (Interface.Emit): Call LabelParameters before
21314 emitting attributes on the InterfaceMethod.
21316 2003-08-26 Martin Baulig <martin@ximian.com>
21318 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21319 resolving aliases; fixes #47927.
21321 2003-08-26 Martin Baulig <martin@ximian.com>
21323 * statement.cs (Using.DoResolve): This is internally emitting a
21324 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21325 do not always return. Fixes #47681.
21327 2003-08-26 Martin Baulig <martin@ximian.com>
21329 * decl.cs (MemberCore): Moved WarningNotHiding(),
21330 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21332 (AdditionResult): Make this nested in DeclSpace.
21333 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21334 argument; call NamespaceEntry.Define() unless we're nested in a
21337 * namespace.cs (Namespace.DefineName): New public function. This
21338 is called from DeclSpace's .ctor to add
21339 (Namespace.Lookup): Include DeclSpaces in the lookup.
21341 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21343 * const.cs (Const): Derive from MemberBase, not MemberCore.
21345 2003-08-25 Martin Baulig <martin@ximian.com>
21347 * convert.cs (Convert.ExplicitReferenceConversion): When
21348 converting from an interface type to a class, unbox if the target
21349 type is a struct type. Fixes #47822.
21351 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21353 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21356 2003-08-22 Martin Baulig <martin@ximian.com>
21358 * class.cs (TypeManager.DefineType): When defining a nested type,
21359 call DefineType() on our parent; fixes #47801.
21361 2003-08-22 Martin Baulig <martin@ximian.com>
21363 * class.cs (MethodData.Define): While checking if a method is an
21364 interface implementation, improve the test a bit more to fix #47654.
21366 2003-08-22 Martin Baulig <martin@ximian.com>
21368 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21369 correctly; fixes #47722.
21371 2003-08-22 Martin Baulig <martin@ximian.com>
21373 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21374 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21376 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21378 2003-08-22 Martin Baulig <martin@ximian.com>
21380 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21381 can only be assigned in static constructors. Fixes #47161.
21383 2003-08-22 Martin Baulig <martin@ximian.com>
21385 Rewrote and improved the flow analysis code.
21387 * flowbranching.cs (FlowBranching): Make this class abstract.
21388 (FlowBranching.CreateBranching): New static function to create a
21389 new flow branching.
21390 (FlowBranchingBlock, FlowBranchingException): New classes.
21391 (FlowBranching.UsageVector.Type): New public readonly field.
21392 (FlowBranching.UsageVector.Breaks): Removed the setter.
21393 (FlowBranching.UsageVector.Returns): Removed the setter.
21394 (FlowBranching.UsageVector): Added Break(), Return(),
21395 NeverReachable() and Throw() methods to modify the reachability.
21396 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21397 done by FlowBranching.Merge().
21398 (FlowBranching.UsageVector.MergeChild): New method; merges the
21399 merge result into the current vector.
21400 (FlowBranching.Merge): New abstract method to merge a branching.
21402 2003-08-12 Martin Baulig <martin@ximian.com>
21404 * expression.cs (Indirection.CacheTemporaries): Create the
21405 LocalTemporary with the pointer type, not its element type.
21407 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21409 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21410 token was a keyword or not.
21412 Add `error' options where an IDENTIFIER was expected; Provide
21413 CheckToken and CheckIdentifierToken convenience error reporting
21416 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21418 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21419 NameSpaceEntry NameSpaceEntry.
21421 (LookupInterfaceOrClass): Avoid creating a full qualified name
21422 from namespace and name: avoid doing lookups when we know the
21423 namespace is non-existant. Use new Tree.LookupByNamespace which
21424 looks up DeclSpaces based on their namespace, name pair.
21426 * driver.cs: Provide a new `parser verbose' to display the
21427 exception thrown during parsing. This is turned off by default
21428 now, so the output of a failure from mcs is more graceful.
21430 * namespace.cs: Track all the namespaces defined in a hashtable
21433 (IsNamespace): New method
21435 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21437 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21438 we know that we need to concatenate (full typename can never be
21443 * statement.cs: Use a bitfield; Do not initialize to null things
21444 which are done by the constructor by default.
21446 * cs-parser.jay: bug fix, parameter was 4, not 3.
21448 * expression.cs: Just use the property;
21450 * statement.cs: No need for GetVariableInfo method.
21452 2003-08-08 Martin Baulig <martin@ximian.com>
21454 * flowanalysis.cs (FlowReturns): This is now nested in the
21455 `FlowBranching' class.
21456 (MyBitVector): Moved this here from statement.cs.
21457 (FlowBranching.SiblingType): New enum type.
21458 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21460 2003-08-07 Martin Baulig <martin@ximian.com>
21462 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21463 `FlowBranching' class and called `BranchingType'.
21465 2003-08-07 Martin Baulig <martin@ximian.com>
21467 * flowanalysis.cs: Moved all the control flow analysis code into
21470 2003-08-07 Martin Baulig <martin@ximian.com>
21472 * assign.cs (Assign.DoResolve): `target' must either be an
21473 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21476 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21478 * expression.cs (BinaryMethod): This kind of expression is created by the
21479 Binary class if it determines that the operator has to be handled
21482 (BinaryDelegate): This kind of expression is created if we are
21483 dealing with a + or - operator on delegates.
21485 (Binary): remove method, argumetns, and DelegateOperator: when
21486 dealing with methods,
21488 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21490 * statement.cs (Block): use bitfields for the three extra booleans
21491 we had in use. Remove unused topblock parameter.
21493 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21495 * assign.cs: Drop extra unneeded tests.
21497 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21499 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21501 * statement.cs (Foreach): Use VariableStorage instead of
21504 * codegen.cs (VariableStorage): New class used by clients that
21505 require a variable stored: locals or fields for variables that
21506 need to live across yield.
21508 Maybe provide a convenience api for EmitThis+EmitLoad?
21510 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21513 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21515 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21516 RemapParameterLValue): New methods that are used to turn a
21517 precomputed FieldInfo into an expression like this:
21521 The idea is to use this instead of making LocalVariableReference
21522 have more than one meaning.
21524 * cs-parser.jay: Add error production to BASE.
21526 * ecore.cs: Deal with TypeManager.GetField returning null, which
21527 is now a valid return value.
21529 (FieldExprNoAddress): New expression for Fields whose address can
21532 * expression.cs (LocalVariableReference): During the resolve
21533 phases, create new expressions if we are in a remapping context.
21534 Remove code that dealt with remapping here.
21536 (ParameterReference): same.
21538 (ProxyInstance): New expression, like the `This' expression, but
21539 it is born fully resolved. We know what we are doing, so remove
21540 the errors that are targeted to user-provided uses of `this'.
21542 * statement.cs (Foreach): our variable is now stored as an
21543 Expression; During resolution, follow the protocol, dont just
21544 assume it will return this.
21546 2003-08-06 Martin Baulig <martin@ximian.com>
21548 * support.cs (SeekableStreamReader.cs): New public class.
21550 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21551 SeekableStreamReader instead of the normal StreamReader.
21553 2003-08-04 Martin Baulig <martin@ximian.com>
21555 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21556 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21557 deambiguate casts and delegate invocations.
21558 (parenthesized_expression): Use the new tokens to ensure this is
21559 not a cast of method invocation.
21561 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21562 when reading a `)' and Deambiguate_CloseParens () was previously
21565 * expression.cs (ParenthesizedExpression): New class. This is
21566 just used for the CS0075 test.
21567 (Binary.DoResolve): Check for CS0075.
21569 2003-07-29 Ravi Pratap <ravi@ximian.com>
21571 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21572 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21573 reference comparison.
21575 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21576 examine the ReturnType for equality - this is necessary in the
21577 cases of implicit and explicit operators whose signature also
21578 includes the return type.
21580 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21582 * namespace.cs: Cache the result of the namespace computation,
21583 instead of computing it every time.
21585 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21587 * decl.cs: Use a global arraylist that we reuse over invocations
21588 to avoid excesive memory consumption. Reduces memory usage on an
21589 mcs compile by one meg (45 average).
21591 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21592 private, work around that.
21594 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21596 * literal.cs (IntLiteral): Define Zero and One static literals.
21598 * cs-parser.jay (integer_literal): use static literals to reduce
21599 memory usage for the most used literals (0, 1 and -1). 211kb
21600 reduced in memory usage.
21602 Replace all calls to `new ArrayList' with `new
21603 ArrayList(4)' which is a good average number for most allocations,
21604 and also requires only 16 bytes of memory for its buffer by
21607 This reduced MCS memory usage in seven megabytes for the RSS after
21610 2003-07-28 Ravi Pratap <ravi@ximian.com>
21612 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21613 handle params methods the correct way by forming only one
21614 applicable set with params and normal methods in them. Earlier we
21615 were looking at params methods only if we found no normal methods
21616 which was not the correct thing to do.
21618 (Invocation.BetterFunction): Take separate arguments indicating
21619 when candidate and the best method are params methods in their
21622 This fixes bugs #43367 and #46199.
21624 * attribute.cs: Documentation updates.
21626 (CheckAttribute): Rename to CheckAttributeTarget.
21627 (GetValidPlaces): Rename to GetValidTargets.
21629 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21630 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21634 2003-07-28 Martin Baulig <martin@ximian.com>
21636 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21637 name when looking up the base class of a nested class. Fixes #46977.
21639 2003-07-26 Martin Baulig <martin@ximian.com>
21641 * expression.cs (Indexers.Indexer): New nested struct; contains
21642 getter, setter and the indexer's type.
21643 (Indexers.Properties): This is now an ArrayList of
21644 Indexers.Indexer's.
21645 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21646 indexer doesn't have any getters.
21648 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21649 for embedded property and indexer assignments.
21651 2003-07-26 Martin Baulig <martin@ximian.com>
21653 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21654 preprocessor directive is not the first non-whitespace character
21657 2003-07-26 Martin Baulig <martin@ximian.com>
21659 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21660 namespace parsing, follow the spec more closely.
21662 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21663 NamespaceEntry.Lookup().
21665 2003-07-25 Martin Baulig <martin@ximian.com>
21667 * MethodCore.cs (OverridesSomething): New public field; it's set
21668 from TypeContainer.DefineMembers if this method overrides
21669 something (which doesn't need to be a method). Fix #39462.
21671 2003-07-25 Ravi Pratap <ravi@ximian.com>
21673 * typemanager.cs (GetMembers): Ensure that the list of members is
21674 reversed. This keeps things in sync.
21676 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21677 find an AttributeUsage attribute.
21679 * expression.cs (Invocation.OverloadResolve): Perform the check
21680 which disallows Invoke to be directly called on a Delegate.
21682 (Error_InvokeOnDelegate): Report error cs1533.
21684 2003-07-25 Martin Baulig <martin@ximian.com>
21686 * expression.cs (Indexers.GetIndexersForType): Only look in the
21687 interface hierarchy if the requested type is already an
21688 interface. Fixes #46788 while keeping #46502 fixed.
21690 2003-07-25 Martin Baulig <martin@ximian.com>
21692 * class.cs (TypeContainer.DefineMembers): Check whether all
21693 readonly fields have been assigned and report warning CS0649 if
21696 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21699 2003-07-24 Ravi Pratap <ravi@ximian.com>
21701 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21702 returned from GetMethods to make things consistent with the
21703 assumptions MCS makes about ordering of methods.
21705 This should comprehensively fix bug #45127 and it does :-)
21707 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21708 ordering is actually reverse.
21710 * Clean up some debug messages I left lying around.
21712 * interface.cs (Populate*): Get rid of code which emits attributes
21713 since the stage in which we emit attributes is the 'Emit' stage,
21714 not the define stage.
21716 (Emit): Move attribute emission for interface members here.
21718 2003-07-22 Ravi Pratap <ravi@ximian.com>
21720 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21721 closely: we eliminate methods in base types when we have an
21722 applicable method in a top-level type.
21724 Please see section 14.5.5.1 for an exact description of what goes
21727 This fixes bug #45127 and a host of other related to corlib compilation.
21729 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21730 array is the method corresponding to the top-level type (this is
21731 because of the changes made to icall.c) so we change this
21734 (MethodGroupExpr.Name): This too.
21736 * typemanager.cs (GetElementType): New method which does the right
21737 thing when compiling corlib.
21739 * everywhere: Make use of the above in the relevant places.
21741 2003-07-22 Martin Baulig <martin@ximian.com>
21743 * cs-parser.jay (invocation_expression): Moved
21744 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21745 `cast_expression', but create a InvocationOrCast which later
21746 resolves to either an Invocation or a Cast.
21748 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21749 method; call this before EmitStatement() to make sure that this
21750 expression can be used as a statement.
21752 * expression.cs (InvocationOrCast): New class; resolves to either
21753 an Invocation or a Cast.
21755 * statement.cs (StatementExpression): Call ResolveStatement() on
21756 the ExpressionStatement before emitting it.
21758 2003-07-21 Martin Baulig <martin@ximian.com>
21760 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21761 `ref' and `out' attributes match; fixes #46220.
21762 (MemberAccess.ResolveMemberAccess): You can't reference a type
21763 through an expression; fixes #33180.
21764 (Indexers.GetIndexersForType): Don't return the indexers from
21765 interfaces the class implements; fixes #46502.
21767 2003-07-21 Martin Baulig <martin@ximian.com>
21769 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21770 CS0661 checks; fixes bug #30442.
21772 2003-07-21 Martin Baulig <martin@ximian.com>
21774 * decl.cs (AdditionResult): Added `Error'.
21776 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21778 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21779 makes cs0031.cs actually work.
21781 2003-07-20 Martin Baulig <martin@ximian.com>
21783 * namespace.cs: Fixed that bug which caused a crash when compiling
21784 the debugger's GUI.
21786 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21788 * typemanager.cs (LookupTypeReflection): Never expose types which
21789 are NotPublic, NestedPrivate, NestedAssembly, or
21790 NestedFamANDAssem. We used to return these, and later do a check
21791 that would report a meaningful error, but the problem is that we
21792 would not get the real match, if there was a name override.
21794 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21796 * namespace.cs (Namespace, Name): Do not compute the namespace
21797 name dynamically, compute it in the constructor. This reduced
21798 memory usage by 1697 KB.
21800 * driver.cs: Use --pause to pause at the end.
21802 2003-07-17 Peter Williams <peter@newton.cx>
21804 * Makefile: Change the name of the test target so that it doesn't
21805 conflict with the recursive test target.
21807 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21809 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21810 AddressOf): Do not use EmitThis, that was wrong, use the actual
21813 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21815 * class.cs (MethodData.Define): While checking if a method is an
21816 interface implementation, improve the test: If we are not public
21817 (use new test here: use the computed MethodAttributes directly,
21818 instead of the parsed modifier flags) check if the `implementing'
21819 method comes from an interface or not.
21821 * pending.cs (VerifyPendingMethods): Slightly better error
21824 * makefile: add test target that does the mcs bootstrap.
21826 2003-07-16 Ravi Pratap <ravi@ximian.com>
21828 * interface.cs (Define): Do nothing here since there are no
21829 members to populate etc. Move the attribute emission out of here
21830 since this was just totally the wrong place to put it. Attribute
21831 application happens during the 'Emit' phase, not in the 'Define'
21834 (Emit): Add this method and move the attribute emission here
21836 * rootcontext.cs (EmitCode): Call the Emit method on interface
21839 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21841 * expression.cs (OverloadResolve): Report error only if Location
21842 is not 'Null' which means that there was a probe going on.
21844 2003-07-14 Martin Baulig <martin@ximian.com>
21846 * expression.cs (ConditionalLogicalOperator): New public class to
21847 implement user defined conditional logical operators.
21848 This is section 14.11.2 in the spec and bug #40505.
21850 2003-07-14 Martin Baulig <martin@ximian.com>
21852 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21854 2003-07-14 Martin Baulig <martin@ximian.com>
21856 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21858 * ecore.cs (IVariable.VerifyFixed): New interface method.
21860 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21861 operator, check whether the variable is actually fixed. Fixes bug
21862 #36055. Set a variable definitely assigned when taking its
21863 address as required by the spec.
21865 * statement.cs (LocalInfo.IsFixed): New field.
21866 (LocalInfo.MakePinned): Set `IsFixed' to true.
21868 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21870 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21871 for .ctors, ensure that we only ask for members declared in the
21872 attribute type (BindingFlags.DeclaredOnly).
21876 * expression.cs (Error_WrongNumArguments): Report error 1501
21877 correctly the way CSC does.
21879 2003-07-13 Martin Baulig <martin@ximian.com>
21881 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21882 lookup on the fully qualified name, to make things like "X.X" work
21883 where "X.X" is a fully qualified type name, but we also have a
21884 namespace "X" in the using list. Fixes #41975.
21886 2003-07-13 Martin Baulig <martin@ximian.com>
21888 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21889 function. If we're a CompoundAssign, we need to create an embedded
21890 CompoundAssign, not an embedded Assign.
21891 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21894 2003-07-13 Martin Baulig <martin@ximian.com>
21896 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21897 work to fix bug #46088.
21899 2003-07-13 Ravi Pratap <ravi@ximian.com>
21901 * class.cs (Operator.Emit): Do not emit attributes here - it is
21902 taken care of by the Method class that we delegate too. This takes
21903 care of bug #45876.
21905 2003-07-10 Martin Baulig <martin@ximian.com>
21907 * expression.cs (TypeOfVoid): New class.
21908 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21910 2003-07-10 Martin Baulig <martin@ximian.com>
21912 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21915 2003-07-10 Martin Baulig <martin@ximian.com>
21917 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21918 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21920 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21922 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21924 2003-07-10 Martin Baulig <martin@ximian.com>
21926 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21927 of decimal. Fixes #42850.
21929 NOTE: I also fixed the created byte blob, but this doesn't work on
21930 the MS runtime and csc never produces any byte blobs for decimal
21933 2003-07-10 Martin Baulig <martin@ximian.com>
21935 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21936 structs; fixes #32068.
21937 (Block.AddChildVariableNames): Fixed #44302.
21939 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21941 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21943 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21945 * attribute.cs: And this test is onger needed.
21947 2003-07-08 Martin Baulig <martin@ximian.com>
21949 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21950 inaccessible types. Fixes #36313.
21952 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21954 * namespace.cs (NamespaceEntry): Create implicit entries for all
21955 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21956 implicit entries for N1.N2 and N1.
21958 2003-07-08 Martin Baulig <martin@ximian.com>
21960 Rewrote the handling of namespaces to fix a lot of the issues
21961 wrt. `using' aliases etc.
21963 * namespace.cs (Namespace): Splitted this class into a
21964 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21966 * typemanager.cs (TypeManager.IsNamespace): Removed.
21967 (TypeManager.ComputeNamespaces): Only compute namespaces from
21968 loaded assemblies here, not the namespaces from the assembly we're
21969 currently compiling.
21971 2003-07-08 Martin Baulig <martin@ximian.com>
21973 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21975 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21977 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21980 I thought about the memory savings here, but LookupTypeReflection
21981 is used under already very constrained scenarios. Compiling
21982 corlib or mcs only exposes one hit, so it would not really reduce
21983 any memory consumption.
21985 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21987 * typemanager.cs: fixes bug #45889 by only adding public types from
21988 other assemblies to the list of known types.
21990 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21992 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21993 on the type we resolved.
21995 2003-07-05 Martin Baulig <martin@ximian.com>
21997 * pending.cs (PendingImplementation.ParentImplements): Don't
21998 create the proxy if the parent is abstract.
22000 * class.cs (TypeContainer.DefineIndexers): Process explicit
22001 interface implementations first. Fixes #37714.
22003 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22005 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22006 defined recursively; but since we modify the input parameters
22007 (left is set to `this' temporarily), we reset this value if the
22008 left_is_explicit is false, which gives the original semantics to
22011 * literal.cs (NullPointer): new class used to represent a null
22012 literal in a pointer context.
22014 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22015 type is a pointer, use a NullPointer object instead of a
22016 NullLiteral. Closes 43687
22018 (ExplicitConversion): Convert pointer values using
22019 the conv opcode to the proper type.
22021 * ecore.cs (New): change ValueTypeVariable property into a method,
22022 that returns whether the valuetype is suitable for being used.
22024 * expression.cs (Binary.DoNumericPromotions): Only return if we
22025 the int constant was a valid uint, and we can return both left and
22026 right as uints. If not, we continue processing, to trigger the
22027 type conversion. This fixes 39018.
22029 * statement.cs (Block.EmitMeta): During constant resolution, set
22030 the CurrentBlock property on the emitcontext, so that we resolve
22031 constants propertly.
22033 2003-07-02 Martin Baulig <martin@ximian.com>
22035 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22036 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22038 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22039 than emitting it here.
22041 * statement.cs: Fixed some more flow analysis bugs.
22043 2003-07-02 Martin Baulig <martin@ximian.com>
22045 * class.cs (MethodData.Define): When implementing interface
22046 methods, set Final unless we're Virtual.
22048 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22049 check work for interface methods.
22051 2003-07-01 Martin Baulig <martin@ximian.com>
22053 * ecore.cs (EmitContext.This): Replaced this property with a
22054 GetThis() method which takes a Location argument. This ensures
22055 that we get the correct error location for a CS0188.
22057 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22059 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22060 ImplicitStandardConversion.
22062 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22064 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22066 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22069 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22071 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22074 (MethodData.Define): Turn off initlocals for unsafe methods.
22076 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22078 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22079 complete; Fixes #37521.
22081 * delegate.cs: Use Modifiers.TypeAttr to compute the
22082 TypeAttributes, instead of rolling our own. This makes the flags
22083 correct for the delegates.
22085 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22087 * class.cs (Constructor.Define): Set the private flag for static
22088 constructors as well.
22090 * cs-parser.jay (statement_expression): Set the return value to
22091 null, to avoid a crash when we catch an error.
22093 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22095 * cs-parser.jay: Applied patch from Jackson that adds support for
22096 extern and unsafe modifiers to destructor declarations.
22098 * expression.cs: Report error 21 if the user is trying to index a
22101 * driver.cs: Add an error message, suggested by the bug report.
22103 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22104 if we do not have a ": this ()" constructor initializer. Fixes 45149
22106 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22108 * namespace.cs: Add some information to reduce FAQs.
22110 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22112 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22113 underlying enumeration types. Fixes #43915.
22115 * expression.cs: Treat ushort/short as legal values to be used in
22116 bitwise operations.
22118 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22120 * delegate.cs: transfer custom attributes for paramenters from
22121 the delegate declaration to Invoke and BeginInvoke.
22123 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22125 * attribute.cs: handle custom marshalers and emit marshal info
22128 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22130 * makefile.gnu: Added anonymous.cs to the compiler sources.
22132 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22134 * iterators.cs: Change the name of the proxy class to include two
22137 * cs-parser.jay: Update grammar to include anonymous methods.
22139 * anonymous.cs: new file.
22141 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22143 * class.cs (Field.Define): Add missing test for pointers and
22146 2003-05-27 Ravi Pratap <ravi@ximian.com>
22148 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22149 we use the stobj opcode.
22151 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22152 since it wasn't the correct fix.
22154 It still is puzzling that we are required to use stobj for IntPtr
22155 which seems to be a ValueType.
22157 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22159 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22160 during regular simple name resolution. Now, the trick is that
22161 instead of returning for processing the simplename, we do a
22162 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22163 contextual lookup type). If a match is found, return that, if
22164 not, return for further composition.
22166 This fixes long-standing 30485.
22168 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22169 using the address to initialize an object, do an Stobj instead of
22170 using the regular Stelem.
22172 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22173 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22174 Because if we are a BaseIndexerAccess that value will be true.
22177 * statement.cs (GotoCase.Resolve): Return after reporting an
22178 error, do not attempt to continue.
22180 * expression.cs (PointerArithmetic.Emit): If our operand is a
22181 long, convert our constants to match the operand before
22182 multiplying. Convert to I type before adding. Fixes 43670.
22184 2003-05-14 Ravi Pratap <ravi@ximian.com>
22186 * enum.cs (ImplicitConversionExists) : Rename to
22187 ImplicitEnumConversionExists to remove ambiguity.
22189 * ecore.cs (NullCast): New type of cast expression class which
22190 basically is very similar to EmptyCast with the difference being
22191 it still is a constant since it is used only to cast a null to
22193 (eg. (string) null)
22195 * convert.cs (ImplicitReferenceConversion): When casting a null
22196 literal, we return a NullCast.
22198 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22199 should be around anymore.
22201 The renaming (reported was slightly wrong). Corrections:
22203 ConvertImplicitStandard -> ImplicitConversionStandard
22204 ConvertExplicitStandard -> ExplicitConversionStandard
22206 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22207 before passing them in !
22209 * convert.cs (ImplicitConversionStandard): When comparing for
22210 equal expr and target types, ensure that expr is not a
22213 In general, we must not be checking (expr_type ==
22214 target_type) in the top level conversion methods
22215 (ImplicitConversion, ExplicitConversion etc). This checking is
22216 done in the methods that they delegate to.
22218 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22220 * convert.cs: Move Error_CannotConvertType,
22221 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22222 ImplicitNumericConversion, ImplicitConversionExists,
22223 ImplicitUserConversionExists, StandardConversionExists,
22224 FindMostEncompassedType, FindMostSpecificSource,
22225 FindMostSpecificTarget, ImplicitUserConversion,
22226 ExplicitUserConversion, GetConversionOperators,
22227 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22228 TryImplicitIntConversion, Error_CannotConvertImplicit,
22229 ConvertImplicitRequired, ConvertNumericExplicit,
22230 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22231 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22234 Perform the following renames:
22236 StandardConversionExists -> ImplicitStandardConversionExists
22237 ConvertImplicit -> ImplicitConversion
22238 ConvertImplicitStandard -> ImplicitStandardConversion
22239 TryImplicitIntConversion -> ImplicitIntConversion
22240 ConvertImplicitRequired -> ImplicitConversionRequired
22241 ConvertNumericExplicit -> ExplicitNumericConversion
22242 ConvertReferenceExplicit -> ExplicitReferenceConversion
22243 ConvertExplicit -> ExplicitConversion
22244 ConvertExplicitStandard -> ExplicitStandardConversion
22246 2003-05-19 Martin Baulig <martin@ximian.com>
22248 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22249 (TypeInfo): Added support for structs having structs as fields.
22251 * ecore.cs (FieldExpr): Implement IVariable.
22252 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22253 VariableInfo for the field.
22255 2003-05-18 Martin Baulig <martin@ximian.com>
22257 * expression.cs (This.DoResolve): Report a CS0027 if we're
22258 emitting a field initializer.
22260 2003-05-18 Martin Baulig <martin@ximian.com>
22262 * expression.cs (This.ResolveBase): New public function.
22263 (This.DoResolve): Check for CS0188.
22265 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22268 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22269 `instance_expression' to null if we don't have any non-static
22272 2003-05-18 Martin Baulig <martin@ximian.com>
22274 Reworked the way how local variables and parameters are handled by
22275 the flow analysis code.
22277 * statement.cs (TypeInfo, VariableMap): New public classes.
22278 (VariableInfo): New public class. This is now responsible for
22279 checking whether a variable has been assigned. It is used for
22280 parameters and local variables.
22281 (Block.EmitMeta): Take the InternalParameters as argument; compute
22282 the layout of the flow vectors here.
22283 (Block.LocalMap, Block.ParameterMap): New public properties.
22284 (FlowBranching): The .ctor doesn't get the InternalParameters
22285 anymore since Block.EmitMeta() now computes the layout of the flow
22287 (MyStructInfo): This class is now known as `StructInfo' and nested
22288 in `TypeInfo'; we don't access this directly anymore.
22290 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22291 property and removed IsAssigned(), IsFieldAssigned(),
22292 SetAssigned() and SetFieldAssigned(); we now call them on the
22293 VariableInfo so we don't need to duplicate this code everywhere.
22295 * expression.cs (ParameterReference): Added `Block block' argument
22297 (LocalVariableReference, ParameterReference, This): The new
22298 VariableInfo class is now responsible for all the definite
22301 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22302 IsParameterAssigned, SetParameterAssigned): Removed.
22304 2003-05-18 Martin Baulig <martin@ximian.com>
22306 * typemanager.cs (InitCoreTypes): Try calling
22307 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22308 the 3-args-version. Corlib now also needs our `void_type'.
22309 (GetMethod): Added overloaded version which takes an optional
22310 `bool report_errors' to allow lookups of optional methods.
22312 2003-05-12 Martin Baulig <martin@ximian.com>
22314 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22315 only used for locals and not for parameters.
22317 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22319 * support.cs (InternalParameters.ParameterType): Return the
22320 ExternalType of the parameter.
22322 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22325 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22327 * class.cs (MethodData.Define): Do not set the `newslot' on
22328 interface members, if they are also flagged as "override".
22330 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22331 better code for ++i and i++. This only works for static fields
22332 and local variables.
22334 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22335 want to pull the DeclSpace out of the builder_to_declspace instead
22336 of the TypeBuilder (like in TypeContainer.FindMembers).
22338 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22339 instead of LookupTypeContainer. Fixes the crash on .NET for
22340 looking up interface members.
22342 * const.cs: Create our own emit context during the Definition
22343 stage, so that constants are evaluated in the proper context, when
22344 a recursive definition happens.
22346 2003-05-11 Martin Baulig <martin@ximian.com>
22348 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22349 new block for a switch section.
22350 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22351 the adding/lookup in the switch block. Fixes #39828.
22353 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22355 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22356 functionality: I needed to convert the data after I had performed
22357 the add/sub operation into the operands type size.
22359 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22360 pass the type for the box operation, otherwise the resulting
22361 object would have been of type object.
22363 (BoxedCast): Add constructor to specify the type to box as.
22365 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22367 * iterators.cs: I was reusing the `count' variable inadvertently,
22368 take steps to not allow this to happen.
22370 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22372 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22373 by creating an array at the point where the params starts and
22374 putting all those arguments there, then adjusting the size of the
22377 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22379 * expression.cs (New.AddressOf): Implement interface
22380 IMemoryLocation. This is used when the `new' operator is used in
22381 the context of an invocation to a method on a value type.
22383 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22386 * namespace.cs: Also check the using aliases here.
22388 * driver.cs: Move the test for using validity after the types have
22389 been entered, so we do a single pass that also includes the using
22392 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22393 in the regular case. CreateSiblingForFinally is doing extra
22396 * attribute.cs (GetAttributeArgumentExpression): Store the result
22397 on an out value, and use the return value to indicate failure
22398 instead of using null (which is a valid return for Constant.GetValue).
22400 * statement.cs: Perform the analysis flow for the increment
22401 portion after the statement, because this will be the real flow of
22402 execution. Fixes #42385
22404 * codegen.cs (EmitContext.EmitArgument,
22405 EmitContext.EmitStoreArgument): New helper functions when the
22406 RemapToProxy flag is set.
22408 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22411 Add support for remapping parameters.
22413 * iterators.cs: Propagate parameter values; Store parameter
22414 values in the proxy classes.
22416 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22418 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22419 need a proxy reference; I do not know what I was thinking
22421 * cs-parser.jay (constructor_initializer): catch another error,
22422 and display nice message.
22424 (field_declaration): catch void field declaration
22425 to flag a better error.
22427 * class.cs (MemberBase.CheckBase): Report an error instead of a
22428 warning if a new protected member is declared in a struct.
22429 (Field.Define): catch the error of readonly/volatile.
22431 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22433 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22434 volatile variable is taken
22436 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22438 * statement.cs (Fixed.Resolve): Report an error if we are not in
22441 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22443 * typemanager.cs: reuse the code that handles type clashes for
22444 delegates and enumerations.
22446 * class.cs (Report28): Always report.
22448 * expression.cs (EncodeAsAttribute): Allow nulls here.
22450 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22452 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22453 the functionality for testing whether an expression is valid for
22454 an attribute here. Also handle the case of arrays of elements
22457 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22458 encoding a linear array into an array of objects that are suitable
22459 to be passed to an CustomAttributeBuilder.
22461 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22463 * ecore.cs: (FieldExpr): Handle field remapping here.
22465 * iteratators.cs: Pass the instance variable (if the method is an
22466 instance method) to the constructors, so we can access the field
22467 variables on the class.
22469 TODO: Test this with structs. I think the THIS variable on
22470 structs might have to be a pointer, and not a refenrece
22472 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22474 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22475 local variables to fields in a proxy class.
22477 * iterators.cs (PopulateProxy): Rename our internal fields to
22479 Create a <THIS> field if we are an instance method, so we can
22480 reference our parent container variables.
22481 (MapVariable): Called back from the EmitContext code to enter a
22482 new variable to field mapping into the proxy class (we just create
22486 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22487 for using the remapped locals to fields.
22489 I placed the code here, because that gives the same semantics to
22490 local variables, and only changes the Emit code.
22492 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22493 statements inside iterators.
22494 (VariableInfo): Add a FieldBuilder for the cases when we are
22495 remapping local variables to fields in a proxy class
22497 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22498 current_block != null.
22500 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22501 not cope with strings, as it has been moved to the
22502 TableSwitchEmit. Fixed bug in switch generation.
22504 * expression.cs (New.DoResolve): Provide more context for the user
22505 when reporting an error.
22507 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22510 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22511 check the permissions for it. Note than in a type-resolution
22512 context the check was already present in DeclSpace.ResolveType,
22513 but was missing from the MemberAccess.
22515 (ArrayCreation.CheckIndices): warn if the user has
22516 more nested levels of expressions, but there are no more
22517 dimensions specified. Avoids crash on bug 41906.
22519 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22521 * statement.cs (Block): replace Implicit bool, for a generic
22523 New flag: `Unchecked'. This is used during the EmitMeta phase
22524 (which is out-of-line with the regular Resolve/Emit process for a
22525 statement, as this is done ahead of time, but still gets a chance
22526 to call constant resolve).
22528 (Block.Flags): new enum for adding a new flag.
22530 (Block.EmitMeta): track the state of unchecked.
22532 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22533 to enable constant resolution to work there as well.
22535 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22537 * typemanager.cs (ienumerable_type): Also look up
22538 System.Collections.IEnumerable.
22540 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22542 TODO: Test more than one conditional per method.
22544 * class.cs (Indexer.Define): Report the location where the user is
22545 referencing the unsupported feature.
22547 (MethodData): Overload the use of `conditionals' to
22548 minimize the creation of needless ArrayLists. This saves roughly
22549 212kb on my machine.
22551 (Method): Implement the new IIteratorContainer interface.
22552 (Method.SetYields): Implement the method by setting the ModFlags
22553 to contain METHOD_YIELDS.
22555 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22556 which just got set to null.
22558 * iterators.cs: New file.
22560 (Yield, YieldBreak): New statements.
22562 * statement.cs (Return.Resolve): Flag an error if we are used in
22563 an iterator method.
22565 * codegen.cs (InIterator): New flag set if the code is being
22566 compiled in an iterator method.
22568 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22569 internal modifier, and we just use it to avoid adding extra
22570 fields, as this is seldom used.
22572 * cs-parser.jay: Add yield_statement (yield and yield break).
22574 * driver.cs: New flag -v2 to turn on version 2 features.
22576 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22577 hashtable when v2 is enabled.
22579 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22581 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22582 there is already a namespace defined with this name.
22584 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22585 people upgraded their corlibs.
22587 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22588 always use fully qualified types, no need to use the compiler
22591 (TypeManager.IsNamespace): Use binarysearch.
22593 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22594 AddDelegate): I did not quite use the new IsValid API properly: I
22595 have to pass the short-name and the fullname. I was passing only
22596 the basename instead of the fullname sometimes.
22598 (TypeContainer.DefineType): call NamespaceClash.
22600 * interface.cs (Interface.DefineType): use NamespaceClash before
22603 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22606 * enum.cs: (Enum.DefineType): use NamespaceClash before
22609 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22610 speed increase. First, use the negative_hits cache when we get a
22611 negative. Second, add the type with its full original name
22612 instead of the new . and + encoded name (reflection uses + to
22613 separate type from a nested type). Use LookupTypeReflection
22614 directly which bypasses the type->name hashtable (that we already
22615 know does not contain the type.
22617 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22618 location/container type.
22620 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22622 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22624 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22626 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22627 method is being referenced in the method group from a static
22628 context, and report error 120 if so.
22630 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22633 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22634 is created, we create the A namespace).
22636 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22639 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22641 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22642 invocation to ModuleBuilder.GetType with the same values will
22643 return a new type instance, so we need to cache its return
22646 * expression.cs (Binary.ResolveOperator): Only allow the compare
22647 operators on enums if they are of the same type.
22649 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22650 types of ValueType on their own case. Before we were giving them
22651 the same treatment as objects.
22653 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22654 fullname. Short name is used to compare against container name.
22655 Fullname is used to check against defined namespace names.
22657 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22658 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22660 (Method.CheckBase): Call parent.
22661 (MemberBase.CheckBase): Check for protected members on sealed
22663 (PropertyBase.CheckBase): Call parent.
22664 (Field.Define): Call parent.
22666 * report.cs: Negative error codes are now mapped to 8000 - code,
22667 so that the display is render more nicely.
22669 * typemanager.cs: Do not use try/catch, instead report a regular
22672 (GetPointerType, GetReferenceType): These methods provide
22673 mechanisms to obtain the T* and T& from a T. We had the code
22674 previously scattered around the code base, and it also used
22675 TypeManager.LookupType that would go through plenty of caches.
22676 This one goes directly to the type source.
22678 In some places we did the Type.GetType followed by
22679 ModuleBuilder.GetType, but not in others, so this unifies the
22680 processing as well.
22682 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22683 statements now that we have namespace information.
22685 * typemanager.cs (IsNamespace): New method, returns whether the
22686 string presented is a namespace or not.
22688 (ComputeNamespaces): New public entry point, computes the list of
22689 available namespaces, using the GetNamespaces API call in Mono, or
22690 the slower version in MS.NET.
22692 Now before we start the semantic analysis phase, we have a
22693 complete list of namespaces including everything that the user has
22696 Deleted old code to cache namespaces in .nsc files.
22698 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22700 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22701 class/struct location definition Location for the implicit
22702 constructor location.
22704 (Operator.Define): Use the location of the operator for the
22705 implicit Method definition.
22707 (Constructor.Emit): use the constructor location for the implicit
22708 base initializer constructor.
22710 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22711 and the Expression class now contains two new methods:
22713 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22714 isolate type lookup from the rest of the resolution process.
22716 Since we use Expressions to hold type definitions due to the way
22717 we parse the input we have historically overloaded Resolve to
22718 perform the Type lookups if a special flag is passed. Now this is
22719 eliminated and two methods take their place.
22721 The differences in the two methods between xStep and xTerminal is
22722 that xStep is involved in our current lookup system that uses
22723 SimpleNames to compose a name, while xTerminal is used just to
22724 catch the case where the simplename lookup failed.
22726 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22728 * expression.cs (ResolveMemberAccess): Remove redundant code.
22729 TypeExpr expressions are always born fully resolved.
22731 * interface.cs (PopulateMethod): Do not lookup the types twice.
22732 We were doing it once during SemanticAnalysis and once during
22735 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22736 in local variable type definitions, were being returned as a
22737 SimpleName (we decomposed everything into a string), that is
22738 because primary_expression was being used instead of a type in the
22739 grammar (reduce/reduce conflicts).
22741 The part that was wrong is that we converted the expression into a
22742 string (an oversimplification in one hand, compounded with primary
22743 expressions doing string concatenation).
22749 Would return "A.B.C[]" as a SimpleName. This stopped things like
22750 using clauses from working on this particular context. And a type
22751 was being matched directly against "A.B.C[]".
22753 We now use the correct approach, and allow for ComposedCast to be
22754 part of the unary expression. So the "A.B.C []" become a composed
22755 cast of "A.B.C" (as a nested group of MemberAccess with a
22756 SimpleName at the end) plus the rank composition "[]".
22760 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22762 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22763 for the access level checking.
22765 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22766 `TypeContainer container', because I kept getting confused when I
22767 was debugging this code.
22769 * expression.cs (Indexers): Instead of tracking getters/setters,
22770 we now track them in parallel. We create one arraylist less, but
22771 most importantly it is possible now for the LValue code to find a
22772 matching get for a set.
22774 (IndexerAccess.DoResolveLValue): Update the code.
22775 GetIndexersForType has been modified already to extract all the
22776 indexers from a type. The code assumed it did not.
22778 Also make the code set the correct return type for the indexer.
22779 This was fixed a long time ago for properties, but was missing for
22780 indexers. It used to be void_type.
22782 (Binary.Emit): Test first for doubles instead of
22783 floats, as they are more common.
22785 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22786 when dealing with floats and the <=, >= operators. This fixes bug
22789 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22790 to load the array value by emitting a load on the foreach variable
22791 type. This was incorrect.
22793 We now emit the code to load an element using the the array
22794 variable type, and then we emit the conversion operator.
22798 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22800 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22802 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22804 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22805 test for protection before we test for signatures.
22807 (MethodSignature.ToString): implement.
22809 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22810 to the case where we reduced into a LongConstant.
22812 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22813 depend on whether the information is acurrate, because the
22814 Microsoft runtime will always claim that the array type is public,
22815 regardless of the real state.
22817 If the type is a pointer, another problem happens: the type is
22818 reported as non-public in Microsoft.
22820 In both cases we have to call CheckAccessLevel recursively with
22821 the underlying type as the argument to be tested.
22823 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22825 * assign.cs (Assign.Emit): If we are dealing with a compound
22826 assignment expression, we should use the code path that stores the
22827 intermediate result in a temporary value. This fixes #40903.
22829 *expression.cs (Indirection.ToString): Provide ToString method for
22832 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22834 * class.cs: Null out fields holding references to Block objects so
22835 they can be garbage collected.
22837 * expression.cs (OverloadResolve): Remove unused local.
22839 2003-04-07 Martin Baulig <martin@ximian.com>
22841 * codegen.cs (EmitContext.CurrentFile): New public field.
22842 (EmitContext.Mark): Use the CurrentFile to check whether the
22843 location is in the correct file.
22844 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22846 2003-04-07 Martin Baulig <martin@ximian.com>
22848 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22850 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22851 location. [FIXME: The location argument which gets passed to this
22852 method is sometimes wrong!]
22854 2003-04-07 Nick Drochak <ndrochak@gol.com>
22856 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22858 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22860 * expression.cs (Indirection.EmitAssign): We were using the
22861 temporary, but returning immediately instead of continuing the
22864 2003-04-06 Martin Baulig <martin@ximian.com>
22866 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22867 if it's a nested child, but also deriving from the outer class.
22870 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22871 nested child, but also deriving from the outer class. See
22873 (FilterWithClosure): We may access private members of the outer
22874 class if we're a nested child and deriving from the outer class.
22875 (RealMemberLookup): Only set `closure_private_ok' if the
22876 `original_bf' contained BindingFlags.NonPublic.
22878 2003-04-05 Martin Baulig <martin@ximian.com>
22880 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22882 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22884 * class.cs (Event.Define): Do not allow abstract events to have
22887 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22889 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22890 block in event declarations.
22892 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22893 value type, get its address.
22895 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22896 leaving a class on the stack instead of a boolean value (int
22897 0/1). Change the code so we compare against null, and then the
22898 result against zero.
22900 * class.cs (TypeContainer.GetClassBases): We were checking for the
22901 parent class being sealed too late.
22903 * expression.cs (Binary.Emit): For <= and >= when dealing with
22904 floating point values, use cgt.un and clt.un instead of cgt and
22907 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22909 * statement.cs: Apply the same optimization as MS: skip the
22910 GetEnumerator returning an IEnumerator, and use the one returning a
22911 CharEnumerator instead. This allows us to avoid the try-finally block
22914 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22916 * cs-parser.jay: Attributes cannot be applied to
22917 namespaces. Fixes #40473
22919 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22922 (Add*): check if the name is valid using the full name for constants,
22923 fields, properties and events.
22925 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22927 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22928 char constants to be part of the enumeration.
22930 * expression.cs (Conditional.DoResolve): Add support for operator
22931 true. Implements the missing functionality from 14.12
22933 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22934 operator true/false as required by the spec.
22936 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22937 implicit conversion to boolean.
22939 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22940 also one where the type implements `operator true'.
22942 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22943 get an expression that will invoke operator true based on an
22946 (GetConversionOperators): Removed the hack that called op_True
22949 (Expression.ResolveBoolean): Move this from Statement.
22951 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22953 * ecore.cs (FieldExpr): do not allow initialization of initonly
22954 fields on derived classes
22956 2003-03-13 Martin Baulig <martin@ximian.com>
22958 * statement.cs (Block.Emit): Call ig.BeginScope() and
22959 ig.EndScope() when compiling with debugging info; call
22960 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22962 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22964 * expression.cs (Indexers): Do not construct immediately, allow
22965 for new members to be appended as we go. Fixes 38143
22967 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22969 * expression.cs: save/restore context when resolving an unchecked
22972 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22974 * cfold.cs: Catch division by zero in modulus operator during
22977 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22979 * interface.cs (Interface.DefineMembers): Avoid defining members
22982 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22984 * driver.cs: handle the +/- options for -noconfig
22986 * statement.cs (Unckeched.Resolve): Also track the state of
22987 unchecked in the Resolve phase.
22989 2003-02-27 Martin Baulig <martin@ximian.com>
22991 * ecore.cs (Expression.MemberLookup): Don't create a
22992 MethodGroupExpr for something which is not a method. Fixes #38291.
22994 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22996 * class.cs (MemberBase.CheckParameters): Also check that the type
22997 is unmanaged if it is a pointer.
22999 * expression.cs (SizeOf.Resolve): Add location information.
23001 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23002 a managed type is declared.
23004 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23005 parameter modifiers as well. Fixes bug 38606
23007 * class.cs: Very sad. Am backing out the speed up changes
23008 introduced by the ArrayList -> Array in the TypeContainer, as they
23009 were not actually that much faster, and introduced a bug (no error
23010 reports on duplicated methods).
23012 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23013 source first, this will guarantee that we have a valid expression
23014 before calling in lower levels functions that will require a
23015 resolved object. Then use this original_source in the
23016 target.ResolveLValue instead of the original source that was
23019 Another change. Use target.Resolve instead of LValueResolve.
23020 Although we are resolving for LValues, we will let the Assign code
23021 take care of that (it will be called again from Resolve). This
23022 basically allows code like this:
23024 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23025 class Y { void A (X x) { x [0] += o; }
23027 The problem was that the indexer was trying to resolve for
23028 set_Item (idx, object o) and never finding one. The real set_Item
23029 was set_Item (idx, X). By delaying the process we get the right
23034 2003-02-23 Martin Baulig <martin@ximian.com>
23036 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23037 while calling DoEmit ().
23039 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23040 source files; if you use the #line directive inside a method, the
23041 compiler stops emitting line numbers for the debugger until it
23042 reaches the end of the method or another #line directive which
23043 restores the original file.
23045 2003-02-23 Martin Baulig <martin@ximian.com>
23047 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23049 2003-02-23 Martin Baulig <martin@ximian.com>
23051 * statement.cs (Block.AddChildVariableNames): We need to call this
23052 recursively, not just for our immediate children.
23054 2003-02-23 Martin Baulig <martin@ximian.com>
23056 * class.cs (Event.Define): Always make the field private, like csc does.
23058 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23059 actually work, fixes bug #37521.
23061 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23063 * delegate.cs: When creating the various temporary "Parameters"
23064 classes, make sure that we call the ComputeAndDefineParameterTypes
23065 on those new parameters (just like we do with the formal ones), to
23066 allow them to be resolved in the context of the DeclSpace.
23068 This fixes the bug that Dick observed in Bugzilla #38530.
23070 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23072 * expression.cs (ResolveMemberAccess): When resolving a constant,
23073 do not attempt to pull a constant if the value was not able to
23074 generate a valid constant.
23076 * const.cs (LookupConstantValue): Do not report more errors than required.
23078 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23080 * expression.cs: fixes bug #38328.
23082 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23084 * class.cs: Changed all the various members that can be part of a
23085 class from being an ArrayList to be an Array of the right type.
23086 During the DefineType type_list, interface_list, delegate_list and
23087 enum_list are turned into types, interfaces, delegates and enums
23090 And during the member population, indexer_list, event_list,
23091 constant_list, field_list, instance_constructor_list, method_list,
23092 operator_list and property_list are turned into their real arrays.
23094 Although we could probably perform this operation earlier, for
23095 good error reporting we need to keep the lists and remove the
23096 lists for longer than required.
23098 This optimization was triggered by Paolo profiling the compiler
23099 speed on the output of `gen-sample-program.pl' perl script.
23101 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23102 not crash in methods like MemberLookupFailed that use this field.
23104 This problem arises when the compiler fails to resolve a type
23105 during interface type definition for example.
23107 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23109 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23110 inherit from System.Object, so we have to stop at null, not only
23111 when reaching System.Object.
23113 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23115 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23116 DeclaredOnly because the parent indexer might have had a different
23117 name, but did not loop until the top of the hierarchy was reached.
23119 The problem this one fixes is 35492: when a class implemented an
23120 indexer from an interface, we were getting the interface method
23121 (which was abstract) and we were flagging an error (can not invoke
23124 This also keeps bug 33089 functioning, and test-148 functioning.
23126 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23127 out if a method is special is to see if it is declared in a
23128 property or event, or whether it is one of the predefined operator
23129 names. This should fix correctly #36804.
23131 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23133 The goal here is to remove the dependency on EmptyCast.Peel ().
23134 Killing it completely.
23136 The problem is that currently in a number of places where
23137 constants are expected, we have to "probe" for an EmptyCast, and
23138 Peel, which is not the correct thing to do, as this will be
23139 repetitive and will likely lead to errors.
23141 The idea is to remove any EmptyCasts that are used in casts that
23142 can be reduced to constants, so we only have to cope with
23145 This bug hunt was triggered by Bug 37363 and the desire to remove
23146 the duplicate pattern where we were "peeling" emptycasts to check
23147 whether they were constants. Now constants will always be
23150 * ecore.cs: Use an enumconstant here instead of wrapping with
23153 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23154 throwing me off. By handling this we can get rid of a few hacks.
23156 * statement.cs (Switch): Removed Peel() code.
23158 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23160 * class.cs: Location information for error 508
23162 * expression.cs (New.DoResolve): Add a guard against double
23163 resolution of an expression.
23165 The New DoResolve might be called twice when initializing field
23166 expressions (see EmitFieldInitializers, the call to
23167 GetInitializerExpression will perform a resolve on the expression,
23168 and later the assign will trigger another resolution
23170 This leads to bugs (#37014)
23172 * delegate.cs: The signature for EndInvoke should contain any ref
23173 or out parameters as well. We were not doing this in the past.
23175 * class.cs (Field.Define): Do not overwrite the type definition
23176 inside the `volatile' group. Turns out that volatile enumerations
23177 were changing the type here to perform a validity test, which
23180 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23182 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23183 and structs, we do not want to load the instance variable
23185 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23186 enum_type has to be handled like an object reference (implicit
23187 conversions exists from this to object), but the regular IsClass
23188 and IsValueType tests will never return true for this one.
23190 Also we use TypeManager.IsValueType instead of type.IsValueType,
23191 just for consistency with the rest of the code (this is only
23192 needed if we ever use the construct exposed by test-180.cs inside
23193 corlib, which we dont today).
23195 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23197 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23200 2003-02-09 Martin Baulig <martin@ximian.com>
23202 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23203 (Namespace.DefineNamespaces): New static public method; this is
23204 called when we're compiling with debugging to add all namespaces
23205 to the symbol file.
23207 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23208 pass it to the Namespace's .ctor.
23210 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23211 and MethodBase arguments; pass the namespace ID to the symwriter;
23212 pass the MethodBase instead of the token to the symwriter.
23213 (SymbolWriter.DefineNamespace): New method to add a namespace to
23216 2003-02-09 Martin Baulig <martin@ximian.com>
23218 * symbolwriter.cs: New file. This is a wrapper around
23219 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23220 methods here in near future.
23222 2003-02-09 Martin Baulig <martin@ximian.com>
23224 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23225 ILGenerator.MarkSequencePoint() which are actually used by the
23228 2003-02-09 Martin Baulig <martin@ximian.com>
23230 * location.cs (SourceFile): New public sealed class. This
23231 contains the name and an index which is used in the location's token.
23232 (Location): Reserve an appropriate number of bits in the token for
23233 the source file instead of walking over that list, this gives us a
23234 really huge performance improvement when compiling with debugging.
23236 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23237 `SourceFile' argument instead of a string.
23238 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23239 but don't parse/tokenize here, we need to generate the list of all
23240 source files before we do that.
23241 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23244 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23245 instead of a string.
23247 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23250 2003-02-09 Martin Baulig <martin@ximian.com>
23252 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23253 filename on `#line default'.
23255 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23257 * statement.cs: don't clear the pinned var when the fixed statement
23258 returns from the method (fixes bug#37752).
23260 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23262 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23265 2003-02-07 Martin Baulig <martin@ximian.com>
23267 * driver.cs: Removed the `--debug-args' command line argument.
23269 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23270 automatically by the AsssemblyBuilder.
23271 (CodeGen.InitializeSymbolWriter): We don't need to call any
23272 initialization function on the symbol writer anymore. This method
23273 doesn't take any arguments.
23275 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23277 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23278 from referenced assemblies as well.
23280 2003-02-02 Martin Baulig <martin@ximian.com>
23282 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23284 2003-02-02 Martin Baulig <martin@ximian.com>
23286 * class.cs (Constructor.Emit): Open the symbol writer before
23287 emitting the constructor initializer.
23288 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23289 single-stepping through constructor initializers.
23291 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23293 * class.cs: Handle error 549: do not allow virtual methods in
23296 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23298 * decl.cs: Check access levels when resolving types
23300 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23302 * statement.cs: Add parameters and locals set in catch blocks that might
23303 return to set vector
23305 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23307 * class.cs (Operator): Set the SpecialName flags for operators.
23309 * expression.cs (Invocation.DoResolve): Only block calls to
23310 accessors and operators on SpecialName methods.
23312 (Cast.TryReduce): Handle conversions from char constants.
23315 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23317 * statement.cs: small memory and time optimization in FlowBranching.
23319 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23321 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23322 problem that the last fix but in the other sid (Set).
23324 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23325 access when there is no indexer in the hierarchy.
23327 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23329 * class.cs: Combine some if statements.
23331 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23333 * driver.cs: fixed bug #37187.
23335 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23337 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23338 any indexer, it's needed to build a list with all the indexers in the
23339 hierarchy (AllGetters), else we have problems. Fixes #35653.
23341 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23343 * class.cs (MethodData.Define): It is wrong for an interface
23344 implementation to be static in both cases: explicit and implicit.
23345 We were only handling this in one case.
23347 Improve the if situation there to not have negations.
23349 * class.cs (Field.Define): Turns out that we do not need to check
23350 the unsafe bit on field definition, only on usage. Remove the test.
23352 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23354 * driver.cs: use assembly.Location instead of Codebase (the latest
23355 patch made mcs fail when using MS assemblies).
23357 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23359 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23360 get the path to *corlib.dll.
23362 2003-01-21 Nick Drochak <ndrochak@gol.com>
23366 * typemanager.cs: Remove compiler warnings
23368 2003-01-20 Duncan Mak <duncan@ximian.com>
23370 * AssemblyInfo.cs: Bump the version number to 0.19.
23372 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23374 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23376 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23378 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23380 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23382 * cs-parser.jay: Small fix: we were not comparing the constructor
23383 name correctly. Thanks to Zoltan for the initial pointer.
23385 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23387 * cs-tokenizer.cs: Set file name when specified with #line
23389 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23391 * cs-parser.jay: Only perform the constructor checks here if we
23392 are named like the class; This will help provider a better
23393 error. The constructor path is taken when a type definition is
23394 not found, but most likely the user forgot to add the type, so
23395 report that rather than the constructor error.
23397 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23399 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23402 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23404 * cs-parser.jay: Add cleanup call.
23406 2003-01-13 Duncan Mak <duncan@ximian.com>
23408 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23409 consistent with other methods.
23411 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23413 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23415 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23417 * attribute.cs: only set GuidAttr to true when we have a
23420 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23424 * typemanager.cs: fixes to allow mcs compile corlib with the new
23425 Type.IsSubclassOf fix.
23427 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23429 * expression.cs (LocalVariableReference.DoResolve): Classify a
23430 constant as a value, not as a variable. Also, set the type for
23433 * cs-parser.jay (fixed_statement): take a type instead of a
23434 pointer_type, so we can produce a better error message later.
23436 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23439 (For.DoEmit): Make inifinite loops have a
23440 non-conditional branch back.
23442 (Fixed.DoEmit): First populate the pinned variables, then emit the
23443 statement, then clear the variables. Before I was emitting the
23444 code once for each fixed piece.
23447 2003-01-08 Martin Baulig <martin@ximian.com>
23449 * statement.cs (FlowBranching.MergeChild): A break in a
23450 SWITCH_SECTION does not leave a loop. Fixes #36155.
23452 2003-01-08 Martin Baulig <martin@ximian.com>
23454 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23455 lives in the same number space than `param_map'. Fixes #36154.
23457 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23459 * cs-parser.jay (constructor_declaration): Set the
23460 Constructor.ModFlags before probing for it. This makes the
23461 compiler report 514, 515 and 132 (the code was there, but got
23464 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23465 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23466 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23468 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23470 * enum.cs: create the enum static fields using the enum type.
23472 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23474 * class.cs: don't try to create the ParamBuilder for the return
23475 type if it's not needed (and handle it breaking for the ms runtime
23478 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23480 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23482 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23484 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23485 the command. This showed up while compiling the JANET source
23486 code, which used \r as its only newline separator.
23488 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23490 * class.cs (Method.Define): If we are an operator (because it
23491 reuses our code), then set the SpecialName and HideBySig. #36128
23493 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23495 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23496 exception, report error 120 `object reference required'.
23498 * driver.cs: Add --pause option, used during to measure the size
23499 of the process as it goes with --timestamp.
23501 * expression.cs (Invocation.DoResolve): Do not allow methods with
23502 SpecialName to be invoked.
23504 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23506 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23507 number before adding it.
23509 2002-12-21 Ravi Pratap <ravi@ximian.com>
23511 * ecore.cs (StandardImplicitConversion): When in an unsafe
23512 context, we allow conversion between void * to any other pointer
23513 type. This fixes bug #35973.
23515 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23517 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23518 is not thrown when extensionless outputs are used
23520 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23522 * rootcontext.cs: fixed compilation of corlib.
23524 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23526 * attribute.cs (Attributes.Contains): Add new method.
23528 * class.cs (MethodCore.LabelParameters): if the parameter is an
23529 `out' parameter, check that no attribute `[In]' has been passed.
23531 * enum.cs: Handle the `value__' name in an enumeration.
23533 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23535 * decl.cs: Added special case to allow overrides on "protected
23538 2002-12-18 Ravi Pratap <ravi@ximian.com>
23540 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23541 since it makes much more sense.
23543 (Attributes.ctor): Don't require a Location parameter.
23545 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23547 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23548 since we already have that information per attribute.
23550 * everywhere : make appropriate changes.
23552 * class.cs (LabelParameters): Write the code which actually
23553 applies attributes to the return type. We can't do this on the MS
23554 .NET runtime so we flag a warning in the case an exception is
23557 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23559 * const.cs: Handle implicit null conversions here too.
23561 2002-12-17 Ravi Pratap <ravi@ximian.com>
23563 * class.cs (MethodCore.LabelParameters): Remove the extra
23564 Type [] parameter since it is completely unnecessary. Instead
23565 pass in the method's attributes so that we can extract
23566 the "return" attribute.
23568 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23570 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23571 of ignoring it and letting the compile continue.
23573 * typemanager.cs (ChangeType): use an extra argument to return an
23574 error condition instead of throwing an exception.
23576 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23578 * expression.cs (Unary.TryReduce): mimic the code for the regular
23579 code path. Perform an implicit cast in the cases where we can
23580 implicitly convert to one of the integral types, and then reduce
23581 based on that constant. This fixes bug #35483.
23583 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23585 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23587 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23589 * namespace.cs: fixed bug #35489.
23591 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23593 * class.cs: Remove some dead code.
23595 * cs-parser.jay: Estimate the number of methods needed
23596 (RootContext.MethodCount);
23598 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23599 numbers instead of StringBuilders.
23601 * support.cs (PtrHashtable): Add constructor with initial size;
23602 We can now reduce reallocations of the method table.
23604 2002-12-10 Ravi Pratap <ravi@ximian.com>
23606 * attribute.cs (ApplyAttributes): Keep track of the emitted
23607 attributes on a per-target basis. This fixes bug #35413.
23609 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23611 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23612 default to the Windows 1252 encoding.
23614 (UnixParseOption): Support version, thanks to Alp for the missing
23617 * AssemblyInfo.cs: Add nice assembly information.
23619 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23622 * cs-parser.jay: Allow a trailing comma before the close bracked
23623 in the attribute_section production.
23625 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23626 address of the instance was being taken, I will take this out,
23627 because we take the address of the object immediately here.
23629 2002-12-09 Ravi Pratap <ravi@ximian.com>
23631 * typemanager.cs (AreMultipleAllowed): Take care of the most
23632 obvious case where attribute type is not in the current assembly -
23635 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23637 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23638 definitions, instead of doing that afterwards.
23640 Also we use a nice little hack, depending on the constructor, we
23641 know if we are a "composed" name or a simple name. Hence, we
23642 avoid the IndexOf test, and we avoid
23644 * codegen.cs: Add code to assist in a bug reporter to track down
23645 the source of a compiler crash.
23647 2002-12-07 Ravi Pratap <ravi@ximian.com>
23649 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23650 types have been emitted for a given element and flag an error
23651 if something which does not have AllowMultiple set is used more
23654 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23655 attribute types and their corresponding AllowMultiple properties
23657 (AreMultipleAllowed): Check the property for a given type.
23659 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23660 property in the case we have a TypeContainer.
23662 (Attributes.AddAttribute): Detect duplicates and just skip on
23663 adding them. This trivial fix catches a pretty gross error in our
23664 attribute emission - global attributes were being emitted twice!
23666 Bugzilla bug #33187 is now fixed.
23668 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23670 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23671 instead of pp_and).
23673 * expression.cs (Binary.ResolveOperator): I can only use the
23674 Concat (string, string, string) and Concat (string, string,
23675 string, string) if the child is actually a concatenation of
23678 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23680 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23681 context where we need a 2-character lookahead.
23683 * pending.cs (PendingImplementation): Rework so we can keep track
23684 of interface types all the time, and flag those which were
23685 implemented by parents as optional.
23687 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23689 * expression.cs (Binary.ResolveOperator): Use
23690 String.Concat(string,string,string) or
23691 String.Concat(string,string,string,string) when possible.
23693 * typemanager: More helper methods.
23696 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23698 * pending.cs: remove the bogus return from GetMissingInterfaces()
23699 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23701 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23703 * namespace.cs: avoid duplicated 'using xxx' being added to
23704 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23705 when we get more than one 'using' statement for the same namespace.
23706 Report a CS0105 warning for it.
23708 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23710 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23711 of calling getChar/putback, uses internal knowledge of it.
23713 (xtoken): Reorder tokenizer so most common patterns are checked
23714 first. This reduces the compilation time in another 5% (from 8.11s
23715 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23717 The parsing time is 22% of the compilation in mcs, and from that
23718 64% is spent on the tokenization process.
23720 I tried using a binary search for keywords, but this is slower
23721 than the hashtable. Another option would be to do a couple of
23724 * Not use a StringBuilder, instead use an array of chars,
23725 with a set value. Notice that this way we could catch
23726 the 645 error without having to do it *afterwards*.
23728 * We could write a hand-parser to avoid the hashtable
23729 compares altogether.
23731 The identifier consumption process takes 37% of the tokenization
23732 time. Another 15% is spent on is_number. 56% of the time spent
23733 on is_number is spent on Int64.Parse:
23735 * We could probably choose based on the string length to
23736 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23739 Another 3% is spend on wrapping `xtoken' in the `token' function.
23741 Handle 0xa0 as whitespace (#34752)
23743 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23745 * typemanager.cs (IsCLRType): New routine to tell whether a type
23746 is one of the builtin types.
23748 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23749 typecode in more places instead of doing pointer comparissions.
23750 We could leverage some knowledge about the way the typecodes are
23753 New code to cache namespaces in assemblies, it is currently not
23754 invoked, to be used soon.
23756 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23758 * expression.cs (Binary.ResolveOperator): specially handle
23759 strings, and do not perform user-defined operator overloading for
23762 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23764 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23765 internalcall as it is a pretty simple operation; Avoid whenever
23766 possible to call Char.IsLetter.
23768 (consume_identifier): Cut by half the number of
23769 hashtable calls by merging the is_keyword and GetKeyword behavior.
23771 Do not short-circuit, because if we do, we
23772 report errors (ie, #if false && true would produce an invalid
23776 2002-11-24 Martin Baulig <martin@ximian.com>
23778 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23779 check constant ranges and report a CS0221. Fixes #33186.
23781 2002-11-24 Martin Baulig <martin@ximian.com>
23783 * cs-parser.jay: Make this work for uninitialized variable
23784 declarations in the `for' initializer. Fixes #32416.
23786 2002-11-24 Martin Baulig <martin@ximian.com>
23788 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23789 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23791 2002-11-24 Martin Baulig <martin@ximian.com>
23793 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23794 argument; if true, we also check for user-defined conversions.
23795 This is only needed if both arguments are of a user-defined type.
23796 Fixes #30443, added test-175.cs.
23797 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23799 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23801 2002-11-24 Martin Baulig <martin@ximian.com>
23803 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23804 function to get the store opcode.
23805 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23806 only emit the Ldelema if the store opcode is Stobj. You must run
23807 both test-34 and test-167 to test this. Fixes #34529.
23809 2002-11-23 Martin Baulig <martin@ximian.com>
23811 * ecore.cs (Expression.MemberLookup): Added additional
23812 `qualifier_type' argument which is used when we're being called
23813 from MemberAccess.DoResolve() and null if we're called from a
23815 (Expression.MemberLookupFailed): New method to report errors; this
23816 does the CS1540 check and reports the correct error message.
23818 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23819 argument for the CS1540 check and redone the way how we're dealing
23820 with private members. See the comment in the source code for details.
23821 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23822 `closure_start_type' to `closure_qualifier_type' and check whether
23823 it's not null. It was not this filter being broken, it was just
23824 being called with the wrong arguments.
23826 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23827 and pass it the correct `qualifier_type'; this also does the error
23830 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23832 * expression.cs (Invocation.EmitParams): If the we are dealing
23833 with a non-built-in value type, load its address as well.
23835 (ArrayCreation): Use a a pretty constant instead
23836 of the hardcoded value 2. Use 6 instead of 2 for the number of
23837 static initializers.
23839 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23840 because they are not really value types, just glorified integers.
23842 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23844 * ecore.cs: Remove redundant code for enumerations, make them use
23845 the same code path as everything else, fixes the casting issue
23846 with enumerations in Windows.Forms.
23848 * attribute.cs: Do only cast to string if it is a string, the
23849 validation happens later.
23851 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23852 people upgrade their corlibs.
23854 * ecore.cs: Oops, enumerations were not following the entire code path
23856 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23858 * typemanager.cs (FilterWithClosure): Commented out the test for
23859 1540 in typemanager.cs, as it has problems when accessing
23860 protected methods from a parent class (see test-174.cs).
23862 * attribute.cs (Attribute.ValidateGuid): new method.
23863 (Attribute.Resolve): Use above.
23865 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23867 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23869 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23870 handling for enumerations, as we only needed the TypeContainer
23871 functionality to begin with (this is required for the fix below to
23872 work for enums that reference constants in a container class for
23875 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23877 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23878 a valid TypeBuilder to perform lookups on.o
23880 * class.cs (InheritableMemberSignatureCompare): Use true in the
23881 call to GetGetMethod and GetSetMethod, because we are comparing
23882 the signature, and we need to get the methods *even* if they are
23885 (PropertyBase.CheckBase): ditto.
23887 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23888 GotoCase.Resolve): Use Peel on EmpytCasts.
23890 * ecore.cs (EmptyCast): drop child, add Peel method.
23892 2002-11-17 Martin Baulig <martin@ximian.com>
23894 * ecore.cs (EmptyCast.Child): New public property.
23896 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23897 label resolved to an EmptyCast. Fixes #34162.
23898 (GotoCase.Resolve): Likewise.
23899 (Block.EmitMeta): Likewise.
23901 2002-11-17 Martin Baulig <martin@ximian.com>
23903 * expression.cs (Invocation.BetterConversion): Prefer int over
23904 uint; short over ushort; long over ulong for integer literals.
23905 Use ImplicitConversionExists instead of StandardConversionExists
23906 since we also need to check for user-defined implicit conversions.
23907 Fixes #34165. Added test-173.cs.
23909 2002-11-16 Martin Baulig <martin@ximian.com>
23911 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23912 with the `true' and `false' literals. Fixes #33151.
23914 2002-11-16 Martin Baulig <martin@ximian.com>
23916 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23917 October 22nd; don't do the cs1540 check for static members.
23919 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23920 now using our own filter here and doing the cs1540 check again.
23922 2002-11-16 Martin Baulig <martin@ximian.com>
23924 * support.cs (InternalParameters): Don't crash if we don't have
23925 any fixed parameters. Fixes #33532.
23927 2002-11-16 Martin Baulig <martin@ximian.com>
23929 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23930 when looking up static methods to make this work on Windows.
23933 2002-11-16 Martin Baulig <martin@ximian.com>
23935 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23936 a setter rather than using PropertyInfo.CanWrite.
23938 2002-11-15 Nick Drochak <ndrochak@gol.com>
23940 * class.cs: Allow acces to block member by subclasses. Fixes build
23943 2002-11-14 Martin Baulig <martin@ximian.com>
23945 * class.cs (Constructor.Emit): Added the extern/block check.
23948 2002-11-14 Martin Baulig <martin@ximian.com>
23950 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23951 iteration while looking for indexers, this is needed because the
23952 indexer may have a different name in our base classes. Fixed the
23953 error reporting (no indexers at all, not get accessor, no
23954 overloaded match). Fixes bug #33089.
23955 (IndexerAccess.DoResolveLValue): Likewise.
23957 2002-11-14 Martin Baulig <martin@ximian.com>
23959 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23960 indexers. Fixes the first part of bug #33089.
23961 (MethodSignature.InheritableMemberSignatureCompare): Added support
23964 2002-11-13 Ravi Pratap <ravi@ximian.com>
23966 * attribute.cs (Attribute.Resolve): Catch the
23967 NullReferenceException and report it since it isn't supposed to
23970 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23972 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23973 LogicalOr and LogicalAnd that can benefit from recursively
23974 handling EmitBranchable. The code now should be nice for Paolo.
23976 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23978 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23979 the Type lookups, as we perform quite a number of lookups on
23980 non-Types. This can be removed once we can deterministically tell
23981 whether we have a type or a namespace in advance.
23983 But this might require special hacks from our corlib.
23987 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23988 and double which avoids a conversion from an integer to a double.
23990 * expression.cs: tiny optimization, avoid calling IsConstant,
23991 because it effectively performs the lookup twice.
23993 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23995 But a bogus return here to keep the semantics of the old code
23996 until the Mono runtime is fixed.
23998 * pending.cs (GetMissingInterfaces): New method used to remove all
23999 the interfaces that are already implemented by our parent
24000 classes from the list of pending methods.
24002 * interface.cs: Add checks for calls after ResolveTypeExpr.
24004 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24006 * class.cs (Class.Emit): Report warning 67: event not used if the
24007 warning level is beyond 3.
24009 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24010 being a NullLiteral.
24012 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24015 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24016 path that might fail if a type can not be resolved.
24018 * expression.cs (Binary.Emit): Emit unsigned versions of the
24021 * driver.cs: use error 5.
24023 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24025 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24027 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24029 * cs-parser.jay (switch_section): A beautiful patch from Martin
24030 Baulig that fixed 33094.
24032 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24034 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24035 Check whether the base is abstract and report an error if so.
24037 * expression.cs (IndexerAccess.DoResolveLValue,
24038 IndexerAccess.DoResolve): ditto.
24040 (Invocation.DoResolve): ditto.
24042 (Invocation.FullMethodDesc): Improve the report string.
24044 * statement.cs (Block): Eliminate IsVariableDefined as it is
24045 basically just a wrapper for GetVariableInfo.
24047 * ecore.cs (SimpleName): Use new
24049 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24050 type, as we return the actual parameter ref/unref state on a
24053 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24055 * support.cs: Return proper flags REF/OUT fixing the previous
24058 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24059 not used to mean `ref' but `ref or out' in ParameterReference
24061 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24062 full type signature instead of calling TypeManger.CSharpName
24065 * support.cs (InternalParameters.ParameterDesc): Do not compare
24066 directly to the modflags, because REF/OUT will actually be bitsets
24069 * delegate.cs (VerifyMethod): Check also the modifiers.
24071 * cs-tokenizer.cs: Fix bug where floating point values with an
24072 exponent where a sign was missing was ignored.
24074 * driver.cs: Allow multiple assemblies to be specified in a single
24077 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24079 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24080 because identifiers after a parenthesis would end up in this kind
24081 of production, and we needed to desamiguate it for having casts
24084 (UserDefinedType *) xxx
24086 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24088 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24089 we should set on the Bindingflags.NonPublic, but not turn on
24090 private_ok. private_ok controls whether a Private member is
24091 returned (this is chekced on the filter routine), while the
24092 BindingFlags.NonPublic just controls whether private/protected
24093 will be allowed. This fixes the problem part of the problem of
24094 private properties being allowed to be used in derived classes.
24096 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24097 so we can call the children DoResolveLValue method (this will
24098 properly signal errors on lvalue assignments to base properties)
24100 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24101 getter are null, and we have a property info, we know that this
24102 happened because the lookup failed, so we report an error 122 for
24103 protection level violation.
24105 We also silently return if setter and getter are null in the
24106 resolve functions, this condition only happens if we have flagged
24107 the error before. This is the other half of the problem.
24109 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24110 not have accessibility information, that is why we were returning
24111 true in the filter function in typemanager.cs.
24113 To properly report 122 (property is inaccessible because of its
24114 protection level) correctly, we report this error in ResolveAccess
24115 by failing if both the setter and the getter are lacking (ie, the
24118 DoResolve and DoLResolve have been modified to check for both
24119 setter/getter being null and returning silently, the reason being
24120 that I did not want to put the knowledge about this error in upper
24123 int old = Report.Errors;
24124 x = new PropertyExpr (...);
24125 if (old != Report.Errors)
24130 So the property expr is returned, but it is invalid, so the error
24131 will be flagged during the resolve process.
24133 * class.cs: Remove InheritablePropertySignatureCompare from the
24134 class, as we no longer depend on the property signature to compute
24135 whether it is possible to implement a method or not.
24137 The reason is that calling PropertyInfo.GetGetMethod will return
24138 null (in .NET, in Mono it works, and we should change this), in
24139 cases where the Get Method does not exist in that particular
24144 class X { public virtual int A { get { return 1; } } }
24146 class Z : Y { public override int A { get { return 2; } } }
24148 Would fail in Z because the parent (Y) would not have the property
24149 defined. So we avoid this completely now (because the alternative
24150 fix was ugly and slow), and we now depend exclusively on the
24153 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24154 reference method, instead of using the property.
24156 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24157 routines are gone now.
24159 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24160 names, they were incorrectly named.
24162 * cs-tokenizer.cs: Return are more gentle token on failure.
24164 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24165 had an out-of-sync index variable, which caused it to remove from
24166 the list of pending methods the wrong method sometimes.
24168 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24170 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24171 CanWrite, because those refer to this particular instance of the
24172 property, and do not take into account the fact that we can
24173 override single members of a property.
24175 Constructor requires an EmitContext. The resolution process does
24176 not happen here, but we need to compute the accessors before,
24177 because the resolution does not always happen for properties.
24179 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24180 subclass, before we did not update this flag, but we did update
24183 (GetAccessors): Drop this routine, as it did not work in the
24184 presence of partially overwritten set/get methods.
24186 Notice that this broke the cs1540 detection, but that will require
24189 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24193 * driver.cs: issue a warning instead of an error if we don't support
24194 debugging for the platform. Also ignore a couple of errors that may
24195 arise when trying to write the symbols. Undo my previous patch.
24197 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24199 * driver.cs: ignore /debug switch except for Unix platforms.
24201 2002-10-23 Nick Drochak <ndrochak@gol.com>
24203 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24205 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24207 * driver.cs: Do not make mcs-debug conditional, so we do not break
24208 builds that use it.
24210 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24211 review this patch. But basically after all the children variables
24212 have been merged, the value of "Breaks" was not being set to
24213 new_breaks for Switch blocks. I think that it should be set after
24214 it has executed. Currently I set this to the value of new_breaks,
24215 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24216 conservative, but I do not understand this code very well.
24218 I did not break anything in the build, so that is good ;-)
24220 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24222 2002-10-20 Mark Crichton <crichton@gimp.org>
24224 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24226 2002-10-20 Nick Drochak <ndrochak@gol.com>
24228 * cfold.cs: Fixed compile blocker.
24230 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24232 * driver.cs: I was chekcing the key, not the file.
24234 2002-10-19 Ravi Pratap <ravi@ximian.com>
24236 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24237 message that we were generating - we just need to silently return
24240 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24242 * class.cs (Event.Define): Change my previous commit, as this
24243 breaks the debugger. This is a temporary hack, as it seems like
24244 the compiler is generating events incorrectly to begin with.
24246 * expression.cs (Binary.ResolveOperator): Added support for
24247 "U operator - (E x, E y)"
24249 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24252 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24253 init-only variables, but this path did not take into account that
24254 there might be also instance readonly variables. Correct this
24257 This fixes bug 32253
24259 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24262 * driver.cs: Change the extension for modules to `netmodule'
24264 * cs-parser.jay: Improved slightly the location tracking for
24265 the debugger symbols.
24267 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24268 modifiers that were specified instead of the hardcoded value
24269 (FamAndAssem). This was basically ignoring the static modifier,
24270 and others. Fixes 32429.
24272 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24273 fixed a bug in the process (32476)
24275 * expression.cs (ArrayAccess.EmitAssign): Patch from
24276 hwang_rob@yahoo.ca that fixes bug 31834.3
24278 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24280 * driver.cs: Make the module extension .netmodule.
24282 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24284 * driver.cs: Report an error if the resource file is not found
24285 instead of crashing.
24287 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24288 false, like Emit does.
24290 2002-10-16 Nick Drochak <ndrochak@gol.com>
24292 * typemanager.cs: Remove unused private member. Also reported mcs
24293 bug to report this as a warning like csc.
24295 2002-10-15 Martin Baulig <martin@gnome.org>
24297 * statement.cs (Statement.Emit): Made this a virtual method; emits
24298 the line number info and calls DoEmit().
24299 (Statement.DoEmit): New protected abstract method, formerly knows
24300 as Statement.Emit().
24302 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24304 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24306 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24307 have fixed a remaining problem: not every AddXXXX was adding a
24308 fully qualified name.
24310 Now everyone registers a fully qualified name in the DeclSpace as
24311 being defined instead of the partial name.
24313 Downsides: we are slower than we need to be due to the excess
24314 copies and the names being registered this way.
24316 The reason for this is that we currently depend (on the corlib
24317 bootstrap for instance) that types are fully qualified, because
24318 we dump all the types in the namespace, and we should really have
24319 types inserted into the proper namespace, so we can only store the
24320 basenames in the defined_names array.
24322 2002-10-10 Martin Baulig <martin@gnome.org>
24324 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24325 from bug #31834, see the bug report for a testcase which is
24328 2002-10-10 Martin Baulig <martin@gnome.org>
24330 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24331 flow analysis code for this.
24333 * statement.cs (Do, While, For): Tell the flow analysis code about
24335 (FlowBranching.UsageVector): Added support for infinite loops.
24336 (Block.Resolve): Moved the dead code elimination here and use flow
24339 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24341 * class.cs (Field.Define): Catch cycles on struct type
24344 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24345 fields if the fields are static. We only need to check instance
24348 * expression.cs (As.DoResolve): Test for reference type.
24350 * statement.cs (Using.ResolveExpression): Use
24351 ConvertImplicitRequired, not ConvertImplicit which reports an
24353 (Using.ResolveLocalVariableDecls): ditto.
24355 * expression.cs (Binary.ResolveOperator): Report errors in a few
24356 places where we had to.
24358 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24360 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24362 * expression.cs: Use StoreFromPtr instead of extracting the type
24363 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24365 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24366 an enumeration value to a System.Enum, but System.Enum is not a
24367 value type, but an class type, so we need to box.
24369 (Expression.ConvertExplicit): One codepath could return
24370 errors but not flag them. Fix this. Fixes #31853
24372 * parameter.cs (Resolve): Do not allow void as a parameter type.
24374 2002-10-06 Martin Baulig <martin@gnome.org>
24376 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24377 if it's a class type and not a struct. Fixes #31815.
24379 2002-10-06 Martin Baulig <martin@gnome.org>
24381 * statement.cs: Reworked the flow analysis code a bit to make it
24382 usable for dead code elimination.
24384 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24386 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24388 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24390 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24391 to fix the test 165, will investigate deeper.
24393 2002-10-04 Martin Baulig <martin@gnome.org>
24395 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24396 finally blocks actually work.
24397 (Try.Resolve): We don't need to create a sibling for `finally' if
24398 there is no finally block.
24400 2002-10-04 Martin Baulig <martin@gnome.org>
24402 * class.cs (Constructor.Define): The default accessibility for a
24403 non-default constructor is private, not public.
24405 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24407 * class.cs (Constructor): Make AllowedModifiers public, add
24410 * cs-parser.jay: Perform the modifiers test here, as the
24411 constructor for the Constructor class usually receives a zero
24412 because of the way we create it (first we create, later we
24413 customize, and we were never checking the modifiers).
24415 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24416 is a version of LookupTypeReflection that includes the type-name
24417 cache. This can be used as a fast path for functions that know
24418 the fully qualified name and are only calling into *.GetType() to
24419 obtain a composed type.
24421 This is also used by TypeManager.LookupType during its type
24424 (LookupType): We now also track the real type name, as sometimes
24425 we can get a quey for the real type name from things like
24426 ComposedCast. This fixes bug 31422.
24428 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24429 complete type fullname, it does not have to go through the type
24430 resolution system to obtain the composed version of the type (for
24431 obtaining arrays or pointers).
24433 (Conditional.Emit): Use the EmitBoolExpression to
24434 generate nicer code, as requested by Paolo.
24436 (ArrayCreation.CheckIndices): Use the patch from
24437 hwang_rob@yahoo.ca to validate the array initializers.
24439 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24441 * class.cs (ConstructorInitializer.Emit): simplify code by using
24442 Invocation.EmitCall, and at the same time, fix the bugs in calling
24443 parent constructors that took variable arguments.
24445 * ecore.cs (Expression.ConvertNumericExplicit,
24446 Expression.ImplicitNumericConversion): Remove the code that
24447 manually wrapped decimal (InternalTypeConstructor call is now gone
24450 * expression.cs (Cast.TryReduce): Also handle decimal types when
24451 trying to perform a constant fold on the type.
24453 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24455 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24456 that only turned off an error report, and did nothing else.
24458 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24460 * driver.cs: Handle and ignore /fullpaths
24462 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24464 * expression.cs (Binary.ResolveOperator): Catch the case where
24465 DoNumericPromotions returns true,
24467 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24469 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24471 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24474 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24476 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24477 conversion exists, but it is also required that the conversion be
24478 performed. This manifested in "(Type64Enum) 2".
24480 * class.cs (TypeManager.AddMethod): The fix is not to change
24481 AddEnum, because that one was using a fully qualified name (every
24482 DeclSpace derivative does), but to change the AddMethod routine
24483 that was using an un-namespaced name. This now correctly reports
24484 the duplicated name.
24486 Revert patch until I can properly fix it. The issue
24487 is that we have a shared Type space across all namespaces
24488 currently, which is wrong.
24490 Options include making the Namespace a DeclSpace, and merge
24491 current_namespace/current_container in the parser.
24493 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24495 * cs-parser.jay: Improve error reporting when we get a different
24496 kind of expression in local_variable_type and
24497 local_variable_pointer_type.
24499 Propagate this to avoid missleading errors being reported.
24501 * ecore.cs (ImplicitReferenceConversion): treat
24502 TypeManager.value_type as a target just like object_type. As
24507 Is valid, and needs to result in the int 1 being boxed before it
24508 is assigned to the value type v.
24510 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24511 to validate the enumeration name.
24513 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24514 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24515 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24517 * ecore.cs (TryImplicitIntConversion): When doing an
24518 implicit-enumeration-conversion, check if the type is 64-bits and
24519 perform a conversion before passing to EnumConstant.
24521 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24523 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24524 report ambiguous type references. Unlike the MS version, we
24525 report what the ambiguity is. Innovation at work ;-)
24527 (DeclSpace.FindType): Require a location argument to
24528 display when we display an ambiguous error.
24530 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24532 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24534 * expression.cs (EmitDynamicInitializers): Apply patch from
24535 hwang_rob@yahoo.ca that fixes the order in which we emit our
24538 2002-09-21 Martin Baulig <martin@gnome.org>
24540 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24541 delegate takes no arguments.
24543 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24545 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24548 * expression.cs: Extract the underlying type.
24550 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24552 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24554 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24556 * class.cs (TypeContainer.DefineType): We can not use the nice
24557 PackingSize with the size set to 1 DefineType method, because it
24558 will not allow us to define the interfaces that the struct
24561 This completes the fixing of bug 27287
24563 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24564 means also structs. This fixes part of the problem.
24565 (Expresion.ImplicitReferenceConversionExists): ditto.
24567 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24568 error if there were no errors reported during the type lookup
24569 process, to avoid duplicates or redundant errors. Without this
24570 you would get an ambiguous errors plus a type not found. We have
24571 beaten the user enough with the first error.
24573 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24576 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24577 during the resolution process, stop the lookup, this avoids
24578 repeated error reports (same error twice).
24580 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24582 * typemanager.cs (LookupType): Redo the type lookup code to match
24583 the needs of System.Reflection.
24585 The issue is that System.Reflection requires references to nested
24586 types to begin with a "+" sign instead of a dot. So toplevel
24587 types look like: "NameSpace.TopLevelClass", and nested ones look
24588 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24591 2002-09-19 Martin Baulig <martin@gnome.org>
24593 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24594 says that a method always returns or always throws an exception,
24595 don't report the CS0161.
24597 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24598 set `Returns = new_returns'.
24600 2002-09-19 Martin Baulig <martin@gnome.org>
24602 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24603 to an enum constant, check for a CS0176.
24605 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24607 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24608 for operators that must be in pairs and report errors.
24610 * ecore.cs (SimpleName.DoResolveType): During the initial type
24611 resolution process, when we define types recursively, we must
24612 check first for types in our current scope before we perform
24613 lookups in the enclosing scopes.
24615 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24617 (Invocation.VerifyArgumentsCompat): Call
24618 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24619 I thought we were supposed to always call this, but there are a
24620 few places in the code where we dont do it.
24622 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24624 * driver.cs: Add support in -linkres and -resource to specify the
24625 name of the identifier.
24627 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24629 * ecore.cs (StandardConversionExists): Sync with the conversion
24630 code: allow anything-* to void* conversions.
24632 (FindMostSpecificSource): Use an Expression argument
24633 instead of a Type, because we might be handed over a Literal which
24634 gets a few more implicit conversions that plain types do not. So
24635 this information was being lost.
24637 Also, we drop the temporary type-holder expression when not
24640 2002-09-17 Martin Baulig <martin@gnome.org>
24642 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24643 this is an explicit interface implementation.
24645 2002-09-17 Martin Baulig <martin@gnome.org>
24647 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24648 different `IndexerName' attributes.
24650 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24651 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24652 virtual CommonResolve().
24654 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24656 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24657 and convert that to the UnderlyingType.
24659 * statement.cs (Foreach.Resolve): Indexers are just like variables
24660 or PropertyAccesses.
24662 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24663 inside quoted strings, we were not doing this before.
24665 2002-09-16 Martin Baulig <martin@gnome.org>
24667 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24668 resolve it. This is needed for the definite assignment check of the
24669 instance expression, fixes bug #29846.
24670 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24672 2002-09-16 Nick Drochak <ndrochak@gol.com>
24674 * parameter.cs: Fix compile error. Cannot reference static member
24675 from an instance object. Is this an mcs bug?
24677 2002-09-14 Martin Baulig <martin@gnome.org>
24679 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24680 multiple times. Fixes bug #30295, added test-166.cs.
24682 2002-09-14 Martin Baulig <martin@gnome.org>
24684 * statement.cs (Block.Emit): Don't emit unreachable code.
24685 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24686 `break' statements.
24687 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24689 2002-09-14 Martin Baulig <martin@gnome.org>
24691 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24694 2002-09-14 Martin Baulig <martin@gnome.org>
24696 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24697 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24698 be false on the ms runtime.
24700 2002-09-13 Martin Baulig <martin@gnome.org>
24702 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24703 the CS0038 error message.
24705 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24707 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24708 constant inside, return it.
24710 2002-09-12 Martin Baulig <martin@gnome.org>
24712 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24713 implicit conversion can be done between enum types.
24715 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24716 check whether an implicit conversion to the current enum's UnderlyingType
24717 exists and report an error if not.
24719 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24720 without debugging support.
24722 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24723 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24725 2002-09-12 Martin Baulig <martin@gnome.org>
24727 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24729 * ecore.cs (IMemberExpr.DeclaringType): New property.
24730 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24731 nonstatic member of an outer type (CS0038).
24733 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24735 * driver.cs: Activate the using-error detector at warning level
24736 4 (at least for MS-compatible APIs).
24738 * namespace.cs (VerifyUsing): Small buglett fix.
24740 * pending.cs (PendingImplementation): pass the container pointer.
24742 * interface.cs (GetMethods): Allow for recursive definition. Long
24743 term, I would like to move every type to support recursive
24744 definitions, not the current ordering mechanism that we have right
24747 The situation is this: Attributes are handled before interfaces,
24748 so we can apply attributes to interfaces. But some attributes
24749 implement interfaces, we will now handle the simple cases
24750 (recursive definitions will just get an error).
24752 * parameter.cs: Only invalidate types at the end if we fail to
24755 2002-09-09 Martin Baulig <martin@gnome.org>
24757 * ecore.cs (PropertyExpr.Emit): Also check for
24758 TypeManager.system_int_array_get_length so this'll also work when
24759 compiling corlib. Fixes #30003.
24761 2002-09-09 Martin Baulig <martin@gnome.org>
24763 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24764 and throw an exception if we can't get the type's size. Fixed #30040,
24767 2002-09-09 Martin Baulig <martin@gnome.org>
24769 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24771 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24772 context. Fixes bug #30027.
24774 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24775 virtual functions. Fixes bug #30043, added test-164.cs.
24777 2002-09-08 Ravi Pratap <ravi@ximian.com>
24779 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24781 2002-09-08 Nick Drochak <ndrochak@gol.com>
24783 * driver.cs: Use an object to get the windows codepage since it's not a
24786 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24788 * statement.cs (For.Emit): for infinite loops (test == null)
24789 return whether there is a break inside, not always "true".
24791 * namespace.cs (UsingEntry): New struct to hold the name of the
24792 using definition, the location where it is defined, and whether it
24793 has been used in a successful type lookup.
24795 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24800 2002-09-06 Ravi Pratap <ravi@ximian.com>
24802 * attribute.cs : Fix incorrect code which relied on catching
24803 a NullReferenceException to detect a null being passed in
24804 where an object was expected.
24806 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24808 * statement.cs (Try): flag the catch variable as assigned
24810 * expression.cs (Cast): Simplified by using ResolveType instead of
24811 manually resolving.
24813 * statement.cs (Catch): Fix bug by using ResolveType.
24815 2002-09-06 Ravi Pratap <ravi@ximian.com>
24817 * expression.cs (BetterConversion): Special case for when we have
24818 a NullLiteral as the argument and we have to choose between string
24819 and object types - we choose string the way csc does.
24821 * attribute.cs (Attribute.Resolve): Catch the
24822 NullReferenceException and report error #182 since the Mono
24823 runtime no more has the bug and having this exception raised means
24824 we tried to select a constructor which takes an object and is
24827 2002-09-05 Ravi Pratap <ravi@ximian.com>
24829 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24830 message (1502, 1503) when we can't locate a method after overload
24831 resolution. This is much more informative and closes the bug
24834 * interface.cs (PopulateMethod): Return if there are no argument
24835 types. Fixes a NullReferenceException bug.
24837 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24838 expressions too. Previously we were checking only in one place for
24839 positional arguments leaving out named arguments.
24841 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24842 type to the enum type is not allowed. Remove code corresponding to
24845 (ConvertNumericExplicit): Allow explicit conversions from
24846 the underlying type to enum type. This precisely follows the spec
24847 and closes a bug filed by Gonzalo.
24849 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24852 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24854 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24856 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24857 it was important that we stored the right value after the
24858 reduction in `converted'.
24860 2002-09-04 Martin Baulig <martin@gnome.org>
24862 * location.cs (Location.SymbolDocument): Use full pathnames for the
24865 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24867 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24868 of the expression resolve mechanism, because that will catch the
24869 SimpleName error failures.
24871 (Conditional): If we can not resolve the
24872 expression, return, do not crash.
24874 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24877 (location): display token name instead of its number.
24879 2002-08-28 Martin Baulig <martin@gnome.org>
24881 * expression.cs (Binary.ResolveOperator): Don't silently return
24882 but return an error if an operator cannot be applied between two
24885 2002-08-28 Martin Baulig <martin@gnome.org>
24887 * class.cs (Constructor.Define): Set the permission attributes
24888 correctly instead of making all constructors public.
24890 2002-08-28 Martin Baulig <martin@gnome.org>
24892 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24893 for private members before reporting a CS0103; if we find anything,
24896 2002-08-28 Martin Baulig <martin@gnome.org>
24898 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24899 to check whether `closure_start_type == closure_invocation_type',
24900 we also need to check whether `m.DeclaringType == closure_invocation_type'
24901 before bypassing the permission checks. We might be accessing
24902 protected/private members from the base class.
24903 (TypeManager.RealMemberLookup): Only set private_ok if private
24904 members were requested via BindingFlags.NonPublic.
24906 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24908 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24909 MethodGroupExpr.IsExplicitImpl if appropriate.
24910 (Invocation.DoResolve): Don't report the CS0120 for explicit
24911 interface implementations.
24913 2002-08-27 Martin Baulig <martin@gnome.org>
24915 * expression.cs (Invocation.DoResolve): If this is a static
24916 method and we don't have an InstanceExpression, we must report
24919 2002-08-25 Martin Baulig <martin@gnome.org>
24921 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24922 `==' between a valuetype and an object.
24924 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24926 * ecore.cs (TypeExpr): Provide a ToString method.
24928 2002-08-24 Martin Baulig <martin@gnome.org>
24930 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24931 now called proggie.dbg and it's a binary file.
24933 2002-08-23 Martin Baulig <martin@gnome.org>
24935 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24937 2002-08-23 Martin Baulig <martin@gnome.org>
24939 * struct.cs (MyStructInfo.ctor): Make this work with empty
24940 structs; it's not allowed to use foreach() on null.
24942 2002-08-23 Martin Baulig <martin@gnome.org>
24944 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24945 writer the full pathname of the generated assembly.
24947 2002-08-23 Martin Baulig <martin@gnome.org>
24949 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24950 A `finally' block never returns or breaks; improved handling of
24953 2002-08-23 Martin Baulig <martin@gnome.org>
24955 * statement.cs (Throw.Resolve): Allow `throw null'.
24957 2002-08-23 Martin Baulig <martin@gnome.org>
24959 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24960 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24961 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24962 MemberLookup would return a wrong event if this is an explicit
24963 interface implementation and the class has an event with the same
24966 2002-08-23 Martin Baulig <martin@gnome.org>
24968 * statement.cs (Block.AddChildVariableNames): New public method.
24969 (Block.AddChildVariableName): Likewise.
24970 (Block.IsVariableNameUsedInChildBlock): Likewise.
24971 (Block.AddVariable): Check whether a variable name has already
24972 been used in a child block.
24974 * cs-parser.jay (declare_local_variables): Mark all variable names
24975 from the current block as being used in a child block in the
24978 2002-08-23 Martin Baulig <martin@gnome.org>
24980 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24981 find the symbol writer.
24983 * driver.cs: csc also allows the arguments to /define being
24984 separated by commas, not only by semicolons.
24986 2002-08-23 Martin Baulig <martin@gnome.org>
24988 * interface.cs (Interface.GetMembers): Added static check for events.
24990 2002-08-15 Martin Baulig <martin@gnome.org>
24992 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24993 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24995 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24996 why the MethodData.EmitDestructor() change was necessary.
24998 2002-08-20 Martin Baulig <martin@gnome.org>
25000 * class.cs (TypeContainer.FindMembers): Added static check for events.
25002 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25004 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25005 use Type.GetEvents(), not Type.FindMembers().
25007 2002-08-20 Martin Baulig <martin@gnome.org>
25009 * decl.cs (MemberCache): Added a special method cache which will
25010 be used for method-only searched. This ensures that a method
25011 search will return a MethodInfo with the correct ReflectedType for
25014 2002-08-20 Martin Baulig <martin@gnome.org>
25016 * decl.cs (DeclSpace.FindMembers): Made this public.
25018 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25020 * delegate.cs: fixed build on windows.
25021 [FIXME: Filed as bug #29150: MCS must report these errors.]
25023 2002-08-19 Ravi Pratap <ravi@ximian.com>
25025 * ecore.cs (StandardConversionExists): Return a false
25026 if we are trying to convert the void type to anything else
25027 since that is not allowed.
25029 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25030 we flag error 70 in the event an event is trying to be accessed
25031 directly from outside the declaring type.
25033 2002-08-20 Martin Baulig <martin@gnome.org>
25035 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25036 MemberCache from typemanager.cs to decl.cs.
25038 2002-08-19 Martin Baulig <martin@gnome.org>
25040 * class.cs (TypeContainer): Implement IMemberContainer.
25041 (TypeContainer.DefineMembers): Create the MemberCache.
25042 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25043 return public members if BindingFlags.Public was given, check
25044 whether members are static.
25046 2002-08-16 Martin Baulig <martin@gnome.org>
25048 * decl.cs (DeclSpace.Define): Splitted this in Define and
25049 DefineMembers. DefineMembers is called first and initializes the
25052 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25053 DefineMembers() on all our DeclSpaces.
25055 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25056 but call DefineMembers() on all nested interfaces. We call their
25057 Define() in our new Define() function.
25059 * interface.cs (Interface): Implement IMemberContainer.
25060 (Interface.Define): Moved all code except the attribute stuf to
25062 (Interface.DefineMembers): Initialize the member cache.
25064 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25065 need this anymore since we can use MemberCache.FindMembers directly.
25067 2002-08-19 Martin Baulig <martin@gnome.org>
25069 * typemanager.cs (MemberCache): When creating the cache for an
25070 interface type, add all inherited members.
25071 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25072 to `out bool used_cache' and documented it.
25073 (TypeManager.MemberLookup): If we already used the cache in the first
25074 iteration, we don't need to do the interfaces check.
25076 2002-08-19 Martin Baulig <martin@gnome.org>
25078 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25079 here from IMemberFinder and don't implement this interface anymore.
25080 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25082 * typemanager.cs (IMemberFinder): This interface is now only used by
25083 classes which actually support the member cache.
25084 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25085 since we only put DeclSpaces into this Hashtable.
25086 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25087 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25089 2002-08-16 Martin Baulig <martin@gnome.org>
25091 * typemanager.cs (ICachingMemberFinder): Removed.
25092 (IMemberFinder.MemberCache): New property.
25093 (TypeManager.FindMembers): Merged this with RealFindMembers().
25094 This function will never be called from TypeManager.MemberLookup()
25095 so we can't use the cache here, just the IMemberFinder.
25096 (TypeManager.MemberLookup_FindMembers): Check whether the
25097 IMemberFinder has a MemberCache and call the cache's FindMembers
25099 (MemberCache): Rewrote larger parts of this yet another time and
25100 cleaned it up a bit.
25102 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25104 * driver.cs (LoadArgs): Support quoting.
25106 (Usage): Show the CSC-like command line arguments.
25108 Improved a few error messages.
25110 2002-08-15 Martin Baulig <martin@gnome.org>
25112 * typemanager.cs (IMemberContainer.Type): New property.
25113 (IMemberContainer.IsInterface): New property.
25115 The following changes are conditional to BROKEN_RUNTIME, which is
25116 defined at the top of the file.
25118 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25119 class'es members, but add all members from TypeHandle.ObjectType
25120 if we're an interface.
25121 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25122 is the current type.
25123 (MemberCache.CacheEntry.Container): Removed this field.
25124 (TypeHandle.GetMembers): Include inherited members.
25126 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25128 * typemanager.cs: fixed compilation and added a comment on a field that
25131 2002-08-15 Martin Baulig <martin@gnome.org>
25133 * class.cs (ConstructorInitializer.Resolve): In the
25134 Expression.MemberLookup call, use the queried_type as
25137 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25138 declared' attribute, it's always true.
25139 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25140 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25141 temporary wrapper for FindMembers which tells MemberLookup whether
25142 members from the base classes are included in the return value.
25143 This will go away soon.
25144 (TypeManager.MemberLookup): Use this temporary hack here; once the
25145 new MemberCache is completed, we don't need to do the DeclaredOnly
25146 looping here anymore since the MemberCache will take care of this.
25147 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25148 (MemberCache): When creating the MemberCache for a class, get
25149 members from the current class and all its base classes.
25150 (MemberCache.CacheEntry.Container): New field. This is a
25151 temporary hack until the Mono runtime is fixed to distinguish
25152 between ReflectedType and DeclaringType. It allows us to use MCS
25153 with both the MS runtime and the unfixed Mono runtime without
25154 problems and without accecting performance.
25155 (MemberCache.SearchMembers): The DeclaredOnly looping from
25156 TypeManager.MemberLookup is now done here.
25158 2002-08-14 Martin Baulig <martin@gnome.org>
25160 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25161 Type.GetFields on dynamic types but get the fields from the
25162 corresponding TypeContainer.
25163 (MyStructInfo.GetStructInfo): Added check for enum types.
25165 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25166 (MemberList.SyncRoot): Implemented.
25167 (TypeManager.FilterWithClosure): No need to check permissions if
25168 closure_start_type == closure_invocation_type, don't crash if
25169 closure_invocation_type is null.
25171 2002-08-13 Martin Baulig <martin@gnome.org>
25173 Rewrote TypeContainer.FindMembers to use a member cache. This
25174 gives us a speed increase of about 35% for the self-hosting MCS
25175 build and of about 15-20% for the class libs (both on GNU/Linux).
25177 * report.cs (Timer): New class to get enhanced profiling. This
25178 whole class is "TIMER" conditional since it remarkably slows down
25181 * class.cs (MemberList): New class. This is an IList wrapper
25182 which we're now using instead of passing MemberInfo[]'s around to
25183 avoid copying this array unnecessarily.
25184 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25185 (ICachingMemberFinder, IMemberContainer): New interface.
25186 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25187 has already been checked, otherwise use it for the name comparision.
25188 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25189 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25190 if possible. Returns a MemberList, not a MemberInfo [].
25191 (TypeHandle): New class, implements IMemberContainer. We create
25192 one instance of this class per type, it contains a MemberCache
25193 which is used to do the member lookups.
25194 (MemberCache): New class. Each instance of this class contains
25195 all members of a type and a name-based hash table.
25196 (MemberCache.FindMembers): This is our new member lookup
25197 function. First, it looks up all members of the requested name in
25198 the hash table. Then, it walks this list and sorts out all
25199 applicable members and returns them.
25201 2002-08-13 Martin Baulig <martin@gnome.org>
25203 In addition to a nice code cleanup, this gives us a performance
25204 increase of about 1.4% on GNU/Linux - not much, but it's already
25205 half a second for the self-hosting MCS compilation.
25207 * typemanager.cs (IMemberFinder): New interface. It is used by
25208 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25209 Enum, Delegate or Interface.
25210 (TypeManager.finder_to_member_finder): New PtrHashtable.
25211 (TypeManager.finder_to_container): Removed.
25212 (TypeManager.finder_to_delegate): Removed.
25213 (TypeManager.finder_to_interface): Removed.
25214 (TypeManager.finder_to_enum): Removed.
25216 * interface.cs (Interface): Implement IMemberFinder.
25218 * delegate.cs (Delegate): Implement IMemberFinder.
25220 * enum.cs (Enum): Implement IMemberFinder.
25222 * class.cs (TypeContainer): Implement IMemberFinder.
25224 2002-08-12 Martin Baulig <martin@gnome.org>
25226 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25228 2002-08-12 Martin Baulig <martin@gnome.org>
25230 * ecore.cs (ITypeExpression): New interface for expressions which
25232 (TypeExpression): Renamed to TypeLookupExpression.
25233 (Expression.DoResolve): If we're doing a types-only lookup, the
25234 expression must implement the ITypeExpression interface and we
25235 call DoResolveType() on it.
25236 (SimpleName): Implement the new ITypeExpression interface.
25237 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25238 hack, the situation that we're only looking up types can't happen
25239 anymore when this method is called. Moved the type lookup code to
25240 DoResolveType() and call it.
25241 (SimpleName.DoResolveType): This ITypeExpression interface method
25242 is now doing the types-only lookup.
25243 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25244 (ResolveFlags): Added MaskExprClass.
25246 * expression.cs (MemberAccess): Implement the ITypeExpression
25248 (MemberAccess.DoResolve): Added support for a types-only lookup
25249 when we're called via ITypeExpression.DoResolveType().
25250 (ComposedCast): Implement the ITypeExpression interface.
25252 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25253 Expression.Resolve() with ResolveFlags.Type instead.
25255 2002-08-12 Martin Baulig <martin@gnome.org>
25257 * interface.cs (Interface.Define): Apply attributes.
25259 * attribute.cs (Attribute.ApplyAttributes): Added support for
25260 interface attributes.
25262 2002-08-11 Martin Baulig <martin@gnome.org>
25264 * statement.cs (Block.Emit): Only check the "this" variable if we
25265 do not always throw an exception.
25267 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25268 whether the property has a set accessor.
25270 2002-08-11 Martin Baulig <martin@gnome.org>
25272 Added control flow analysis support for structs.
25274 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25275 with control flow analysis turned off.
25276 (IVariable): New interface.
25277 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25278 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25279 (FieldExpr.DoResolve): Resolve the instance expression with flow
25280 analysis turned off and do the definite assignment check after the
25281 resolving when we know what the expression will resolve to.
25283 * expression.cs (LocalVariableReference, ParameterReference):
25284 Implement the new IVariable interface, only call the flow analysis
25285 code if ec.DoFlowAnalysis is true.
25286 (This): Added constructor which takes a Block argument. Implement
25287 the new IVariable interface.
25288 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25289 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25290 This does the definite assignment checks for struct members.
25292 * class.cs (Constructor.Emit): If this is a non-static `struct'
25293 constructor which doesn't have any initializer, call
25294 Block.AddThisVariable() to tell the flow analysis code that all
25295 struct elements must be initialized before control returns from
25298 * statement.cs (MyStructInfo): New public class.
25299 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25300 argument to this indexer. If non-zero, check an individual struct
25301 member, not the whole struct.
25302 (FlowBranching.CheckOutParameters): Check struct members.
25303 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25304 overloaded versions of these methods which take an additional
25305 `int field_idx' argument to check struct members.
25306 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25307 overloaded versions of these methods which take an additional
25308 `string field_name' argument to check struct member.s
25309 (VariableInfo): Implement the IVariable interface.
25310 (VariableInfo.StructInfo): New public property. Returns the
25311 MyStructInfo instance of the variable if it's a struct or null.
25312 (Block.AddThisVariable): New public method. This is called from
25313 Constructor.Emit() for non-static `struct' constructor which do
25314 not have any initializer. It creates a special variable for the
25315 "this" instance variable which will be checked by the flow
25316 analysis code to ensure that all of the struct's fields are
25317 initialized before control returns from the constructor.
25318 (UsageVector): Added support for struct members. If a
25319 variable/parameter is a struct with N members, we reserve a slot
25320 in the usage vector for each member. A struct is considered fully
25321 initialized if either the struct itself (slot 0) or all its
25322 members are initialized.
25324 2002-08-08 Martin Baulig <martin@gnome.org>
25326 * driver.cs (Driver.MainDriver): Only report an error CS5001
25327 if there were no compilation errors.
25329 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25330 `UnsafeContext' property to determine whether the parent is in
25331 unsafe context rather than checking the parent's ModFlags:
25332 classes nested in an unsafe class are unsafe as well.
25334 2002-08-08 Martin Baulig <martin@gnome.org>
25336 * statement.cs (UsageVector.MergeChildren): Distinguish between
25337 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25338 we return. Added test17() and test18() to test-154.cs.
25340 2002-08-08 Martin Baulig <martin@gnome.org>
25342 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25343 Family access, make sure the invoking type isn't a subclass of the
25344 queried type (that'd be a CS1540).
25346 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25347 this method which takes an additional `Type invocation_type'.
25349 * expression.cs (BaseAccess.DoResolve): Use the base type as
25350 invocation and query type.
25351 (MemberAccess.DoResolve): If the lookup failed and we're about to
25352 report a CS0122, try a lookup with the ec.ContainerType - if this
25353 succeeds, we must report a CS1540.
25355 2002-08-08 Martin Baulig <martin@gnome.org>
25357 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25358 (MethodGroupExpr): Implement the IMemberExpr interface.
25360 * expression (MemberAccess.ResolveMemberAccess): No need to have
25361 any special code for MethodGroupExprs anymore, they're now
25364 2002-08-08 Martin Baulig <martin@gnome.org>
25366 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25367 Family, FamANDAssem and FamORAssem permissions.
25368 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25370 2002-08-08 Martin Baulig <martin@gnome.org>
25372 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25373 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25376 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25378 * driver.cs: implemented /resource option to embed managed resources.
25380 2002-08-07 Martin Baulig <martin@gnome.org>
25382 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25383 (FieldBase.HasFieldInitializer): New public property.
25384 (FieldBase.GetInitializerExpression): New public method. Resolves and
25385 returns the field initializer and makes sure it is only resolved once.
25386 (TypeContainer.EmitFieldInitializers): Call
25387 FieldBase.GetInitializerExpression to get the initializer, this ensures
25388 that it isn't resolved multiple times.
25390 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25391 the resolving process (SimpleName/MemberLookup) that we're currently
25392 emitting a field initializer (which must not access any instance members,
25393 this is an error CS0236).
25395 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25396 argument, if the `IsFieldInitializer' flag is set, we must report and
25397 error CS0236 and not an error CS0120.
25399 2002-08-07 Martin Baulig <martin@gnome.org>
25401 * ecore.cs (IMemberExpr): New public interface.
25402 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25403 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25404 if the expression is an IMemberExpr.
25406 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25407 to be null, implicitly default to `this' if we're non-static in
25408 this case. Simplified the code a lot by using the new IMemberExpr
25409 interface. Also fixed bug #28176 here.
25411 2002-08-06 Martin Baulig <martin@gnome.org>
25413 * cs-parser.jay (SimpleLookup): Removed. We need to create
25414 ParameterReferences during semantic analysis so that we can do a
25415 type-only search when resolving Cast, TypeOf and SizeOf.
25416 (block): Pass the `current_local_parameters' to the Block's
25419 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25420 argument to the constructor.
25421 (ConstructorInitializer.Resolve): Create a temporary implicit
25422 block with the parameters.
25424 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25425 references here if we aren't doing a type-only search.
25427 * statement.cs (Block): Added constructor which takes a
25428 `Parameters parameters' argument.
25429 (Block.Parameters): New public property.
25431 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25432 to `Parameters' and made it public readonly.
25434 2002-08-06 Martin Baulig <martin@gnome.org>
25436 * ecore.cs (Expression.Warning): Made this public as well.
25438 * report.cs (Report.Debug): Print the contents of collections.
25440 2002-08-06 Martin Baulig <martin@gnome.org>
25442 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25443 used to tell Resolve() which kinds of expressions it may return.
25444 (Expression.Resolve): Added overloaded version of this method which
25445 takes a `ResolveFlags flags' argument. This can be used to tell
25446 Resolve() which kinds of expressions it may return. Reports a
25448 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25449 ResolveFlags.SimpleName.
25450 (Expression.Error118): Added overloaded version of this method which
25451 takes a `ResolveFlags flags' argument. It uses the flags to determine
25452 which kinds of expressions are allowed.
25454 * expression.cs (Argument.ResolveMethodGroup): New public method.
25455 Resolves an argument, but allows a MethodGroup to be returned.
25456 This is used when invoking a delegate.
25458 * TODO: Updated a bit.
25460 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25462 Fixed compilation with csc.
25464 * ecore.cs: Expression.Error made public. Is this correct? Should
25465 Warning be made public too?
25467 * expression.cs: use ea.Location instead of ea.loc.
25468 [FIXME: Filed as bug #28607: MCS must report these errors.]
25470 2002-08-06 Martin Baulig <martin@gnome.org>
25472 * ecore.cs (Expression.loc): Moved the location here instead of
25473 duplicating it in all derived classes.
25474 (Expression.Location): New public property.
25475 (Expression.Error, Expression.Warning): Made them non-static and
25476 removed the location argument.
25477 (Expression.Warning): Added overloaded version which takes an
25478 `int level' argument.
25479 (Expression.Error118): Make this non-static and removed the
25480 expression and location arguments.
25481 (TypeExpr): Added location argument to the constructor.
25483 * expression.cs (StaticCallExpr): Added location argument to
25485 (Indirection, PointerArithmetic): Likewise.
25486 (CheckedExpr, UnCheckedExpr): Likewise.
25487 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25488 (StringPtr): Likewise.
25491 2002-08-05 Martin Baulig <martin@gnome.org>
25493 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25495 * assign.cs (Assign.DoResolve): Check whether the source
25496 expression is a value or variable.
25498 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25499 while resolving the corresponding blocks.
25501 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25502 an error, don't silently return null.
25504 * statement.cs (Block.AddVariable): Do the error reporting here
25505 and distinguish between CS0128 and CS0136.
25506 (Block.DoResolve): Report all unused labels (warning CS0164).
25507 (LabeledStatement): Pass the location to the constructor.
25508 (LabeledStatement.HasBeenReferenced): New property.
25509 (LabeledStatement.Resolve): Set it to true here.
25511 * statement.cs (Return.Emit): Return success even after reporting
25512 a type mismatch error (CS0126 or CS0127), this is what csc does and
25513 it avoids confusing the users with any consecutive errors.
25515 2002-08-05 Martin Baulig <martin@gnome.org>
25517 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25519 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25521 * expression.cs (MemberAccess.DoResolve): Silently return if an
25522 error has already been reported.
25524 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25525 error has already been reported.
25527 2002-08-05 Martin Baulig <martin@gnome.org>
25529 * statement.cs (UsageVector): Only initialize the `parameters'
25530 vector if we actually have any "out" parameters.
25532 2002-08-05 Martin Baulig <martin@gnome.org>
25534 * expression.cs (Binary.ResolveOperator): When combining delegates,
25535 they must have the same type.
25537 2002-08-05 Martin Baulig <martin@gnome.org>
25539 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25540 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25541 work with the ms runtime and we also don't need it: if we're a
25542 PropertyBuilder and not in the `indexer_arguments' hash, then we
25543 are a property and not an indexer.
25545 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25546 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25547 since the latter one doesn't work with the ms runtime.
25549 2002-08-03 Martin Baulig <martin@gnome.org>
25551 Fixed bugs #27998 and #22735.
25553 * class.cs (Method.IsOperator): New public field.
25554 (Method.CheckBase): Report CS0111 if there's already a method
25555 with the same parameters in the current class. Report CS0508 when
25556 attempting to change the return type of an inherited method.
25557 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25558 and it's not marked abstract or extern.
25559 (PropertyBase): New abstract base class for Property and Indexer.
25560 (PropertyBase.CheckBase): Moved here from Property and made it work
25562 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25563 the same so we can reuse it there.
25564 (Property, Indexer): Derive from PropertyBase.
25565 (MethodSignature.inheritable_property_signature_filter): New delegate
25566 to find properties and indexers.
25568 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25569 argument and improved error reporting.
25571 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25572 EmptyReadOnlyParameters and made it a property.
25574 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25575 version of this method which takes a `PropertyInfo indexer'.
25576 (TypeManager.RegisterIndexer): New method.
25578 * class.cs: Added myself as author of this file :-)
25580 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25582 * class.cs: fixed compilation on windoze.
25584 2002-08-03 Martin Baulig <martin@gnome.org>
25586 * interface.cs (Interface.GetInterfaceBases): Check whether all
25587 base interfaces are at least as accessible than the current one.
25589 * class.cs (TypeContainer.GetClassBases): Check whether base types
25590 are at least as accessible than the current type.
25591 (TypeContainer.AsAccessible): Implemented and made non-static.
25592 (MemberBase.CheckParameters): Report errors if the accessibility
25595 * delegate.cs (Delegate.Delegate): The default visibility is
25596 internal for top-level types and private for nested types.
25597 (Delegate.Define): Report errors if the accessibility checks fail.
25599 * enum.cs (Enum.Enum): The default visibility is internal for
25600 top-level types and private for nested types.
25601 (Enum.DefineType): Compute the correct visibility.
25603 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25604 function which takes a `bool is_toplevel' instead of a TypeContainer.
25606 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25609 2002-08-02 Martin Baulig <martin@gnome.org>
25611 * expression.cs (LocalVariableReferenc): Added constructor which
25612 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25613 (LocalVariableReference.IsReadOnly): New property.
25614 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25615 variable is readonly, use our own readonly flag to do this; you can
25616 use the new constructor to get a writable reference to a read-only
25619 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25620 reference to the local variable.
25622 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25624 * rootcontext.cs (ResolveCore): Also include System.Exception
25626 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25627 we reach an EmptyStatement.
25629 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25632 * expression.cs (Binary.ResolveOperator): Check error result in
25635 use brtrue/brfalse directly and avoid compares to null.
25637 2002-08-02 Martin Baulig <martin@gnome.org>
25639 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25640 Fixes bug #28407, added test-155.cs.
25642 2002-08-01 Martin Baulig <martin@gnome.org>
25644 * class.cs (Event.EmitDefaultMethod): Make this work with static
25645 events. Fixes #28311, added verify-3.cs.
25647 2002-08-01 Martin Baulig <martin@gnome.org>
25649 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25650 `is_disposable' fields.
25651 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25652 `hm.is_disposable' if we're using the collection pattern.
25653 (Foreach.EmitCollectionForeach): Use the correct type for the
25654 enumerator's local variable, only emit the try/finally block if
25655 necessary (fixes #27713).
25657 2002-08-01 Martin Baulig <martin@gnome.org>
25659 * ecore.cs (Expression.report118): Renamed to Error118 and made
25662 * statement.cs (Throw.Resolve): Check whether the expression is of
25663 the correct type (CS0118) and whether the type derives from
25664 System.Exception (CS0155).
25665 (Catch.Resolve): New method. Do the type lookup here and check
25666 whether it derives from System.Exception (CS0155).
25667 (Catch.CatchType, Catch.IsGeneral): New public properties.
25669 * typemanager.cs (TypeManager.exception_type): Added.
25671 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25673 * driver.cs: Updated About function.
25675 2002-07-31 Martin Baulig <martin@gnome.org>
25677 Implemented Control Flow Analysis.
25679 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25680 (EmitContext.CurrentBranching): Added.
25681 (EmitContext.StartFlowBranching): Added.
25682 (EmitContext.EndFlowBranching): Added.
25683 (EmitContext.KillFlowBranching): Added.
25684 (EmitContext.IsVariableAssigned): Added.
25685 (EmitContext.SetVariableAssigned): Added.
25686 (EmitContext.IsParameterAssigned): Added.
25687 (EmitContext.SetParameterAssigned): Added.
25688 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25689 Added control flow analysis stuff here.
25691 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25692 resolve the expression as lvalue.
25693 (LocalVariableReference.DoResolve): Check whether the variable has
25694 already been assigned.
25695 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25696 the parameter as assigned here.
25697 (ParameterReference.DoResolve): Check whether the parameter has already
25699 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25700 expression as lvalue.
25702 * statement.cs (FlowBranching): New class for the flow analysis code.
25703 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25704 (LabeledStatement.IsDefined): New public property.
25705 (LabeledStatement.AddUsageVector): New public method to tell flow
25706 analyis that the label may be reached via a forward jump.
25707 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25709 (VariableInfo.Number): New public field. This is used by flow analysis
25710 to number all locals of a block.
25711 (Block.CountVariables): New public property. This is the number of
25712 local variables in this block (including the locals from all parent
25714 (Block.EmitMeta): Number all the variables.
25716 * statement.cs: Added flow analysis support to all classes.
25718 2002-07-31 Martin Baulig <martin@gnome.org>
25720 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25721 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25722 then use this argument.
25724 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25726 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25727 use this to specify /define options.
25729 2002-07-29 Martin Baulig <martin@gnome.org>
25731 * statement.cs (Fixed): Moved all code that does variable lookups
25732 and resolvings from Emit to Resolve.
25734 * statement.cs (For): Moved all code that does variable lookups
25735 and resolvings from Emit to Resolve.
25737 * statement.cs (Using): Moved all code that does variable lookups
25738 and resolvings from Emit to Resolve.
25740 2002-07-29 Martin Baulig <martin@gnome.org>
25742 * attribute.cs (Attribute.Resolve): Explicitly catch a
25743 System.NullReferenceException when creating the
25744 CustromAttributeBuilder and report a different warning message.
25746 2002-07-29 Martin Baulig <martin@gnome.org>
25748 * support.cs (ParameterData.ParameterName): Added method to
25749 get the name of a parameter.
25751 * typemanager.cs (TypeManager.IsValueType): New public method.
25753 2002-07-29 Martin Baulig <martin@gnome.org>
25755 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25756 is a flag which specifies that it's either ref or out.
25757 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25758 the out parameter to `out Parameter.Modifier mod', also set the
25759 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25761 * support.cs (InternalParameters.ParameterModifier): Distinguish
25762 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25763 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25765 * expression.cs (Argument.GetParameterModifier): Distinguish
25766 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25767 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25769 2002-07-29 Martin Baulig <martin@gnome.org>
25771 * expression.cs (ParameterReference.ParameterReference): Added
25772 `Location loc' argument to the constructor.
25774 * cs-parser.jay: Pass location to ParameterReference.
25776 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25778 * statement.cs (Try): Initialize the location.
25780 * cs-parser.jay: pass location to Try.
25782 * expression.cs (Unary.Reduce): Change the prototype to return
25783 whether a constant fold could be performed or not. The result is
25784 returned in an out parameters. In the case of Indirection and
25785 AddressOf, we want to perform the full tests.
25787 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25789 * statement.cs (Statement.Emit): Flag dead code.
25791 2002-07-27 Andrew Birkett <andy@nobugs.org>
25793 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25795 2002-07-27 Martin Baulig <martin@gnome.org>
25797 * class.cs (MethodData.Define): Put back call to
25798 TypeManager.AddMethod(), accidentally commented this out.
25800 * report.cs (Debug): New public method to print debugging information,
25801 this is `[Conditional ("DEBUG")]'.
25803 2002-07-26 Martin Baulig <martin@gnome.org>
25805 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25806 (switch_statement): Push the current_block to the switch_stack and
25807 pop it again when we're done with the switch.
25808 (switch_section): The new block is a child of the current_block.
25809 Fixes bug #24007, added test-152.cs.
25811 2002-07-27 Martin Baulig <martin@gnome.org>
25813 * expression.cs (Invocation.EmitArguments): When calling a varargs
25814 function with only its fixed arguments, we need to pass an empty
25817 2002-07-27 Martin Baulig <martin@gnome.org>
25819 Mono 0.13 has been released.
25821 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25823 * driver.cs: Rename --resource to --linkres, because that is what
25824 we do currently, we dont support --resource yet.
25826 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25828 2002-07-25 Martin Baulig <martin@gnome.org>
25830 * class.cs (MethodData): New public class. This is a `method builder'
25831 class for a method or one accessor of a Property/Indexer/Event.
25832 (MethodData.GetMethodFlags): Moved here from MemberBase.
25833 (MethodData.ApplyAttributes): Likewise.
25834 (MethodData.ApplyObsoleteAttribute): Likewise.
25835 (MethodData.ApplyConditionalAttribute): Likewise.
25836 (MethodData.ApplyDllImportAttribute): Likewise.
25837 (MethodData.CheckAbstractAndExternal): Likewise.
25838 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25839 (MethodData.Emit): Formerly known as Method.Emit().
25840 (MemberBase): Moved everything which was specific to a single
25841 accessor/method to MethodData.
25842 (Method): Create a new MethodData and call Define() and Emit() on it.
25843 (Property, Indexer, Event): Create a new MethodData objects for each
25844 accessor and call Define() and Emit() on them.
25846 2002-07-25 Martin Baulig <martin@gnome.org>
25848 Made MethodCore derive from MemberBase to reuse the code from there.
25849 MemberBase now also checks for attributes.
25851 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25852 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25854 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25855 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25856 (MemberBase.ApplyAttributes): New virtual method; applies the
25857 attributes to a method or accessor.
25858 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25859 (MemberBase.ApplyConditionalAttribute): Likewise.
25860 (MemberBase.ApplyDllImportAttribute): Likewise.
25861 (MemberBase.CheckAbstractAndExternal): Likewise.
25862 (MethodCore.ParameterTypes): This is now a property instead of a
25863 method, it's initialized from DoDefineParameters().
25864 (MethodCore.ParameterInfo): Removed the set accessor.
25865 (MethodCore.DoDefineParameters): New protected virtual method to
25866 initialize ParameterTypes and ParameterInfo.
25867 (Method.GetReturnType): We can now simply return the MemberType.
25868 (Method.GetMethodFlags): Override the MemberBase version and add
25869 the conditional flags.
25870 (Method.CheckBase): Moved some code from Define() here, call
25871 DoDefineParameters() here.
25872 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25873 here to avoid some larger code duplication.
25874 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25875 ensure that abstract and external accessors don't declare a body.
25877 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25878 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25879 lookup in the attribute's parent classes, so we need to abort as soon
25880 as we found the first match.
25881 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25882 the attribute has no arguments.
25884 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25887 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25889 * cs-parser.jay: reverted previous patch.
25891 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25893 * cs-parser.jay: fixed bug #22119.
25895 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25897 * attribute.cs: fixed compilation. The error was:
25898 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25899 be assigned to before control leaves the current method."
25900 [FIXME: Filed as bug #28186: MCS must report this error.]
25902 2002-07-25 Martin Baulig <martin@gnome.org>
25904 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25905 method to pull the condition name ouf of a Conditional attribute.
25906 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25907 the obsolete message and error flag out of an Obsolete attribute.
25909 * class.cs (Method.GetMethodFlags): New public method to get the
25910 TypeManager.MethodFlags for this method.
25911 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25913 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25914 if we're overriding a virtual function, set the new private variable
25915 `parent_method'; call the new TypeManager.AddMethod().
25917 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25918 the MethodBuilder and the Method in a PtrHashtable.
25919 (TypeManager.builder_to_method): Added for this purpose.
25920 (TypeManager.MethodFlags): Added IsObsoleteError.
25921 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25922 Obsolete and Conditional arguments in MethodBuilders. If we discover
25923 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25924 the message from the attribute.
25926 2002-07-24 Martin Baulig <martin@gnome.org>
25928 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25929 preprocessor directives, ensure that the argument to #define/#undef is
25930 exactly one identifier and that it's actually an identifier.
25932 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25935 2002-07-24 Martin Baulig <martin@gnome.org>
25937 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25938 initialize it to TypeManager.object_type in the constructor.
25939 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25940 of the `hm.get_current' method if we're using the collection pattern.
25941 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25942 for the explicit conversion to make it work when we're using the collection
25943 pattern and the `Current' property has a different return type than `object'.
25946 2002-07-24 Martin Baulig <martin@gnome.org>
25948 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25949 does not match, but don't report any errors. This method is called in
25950 order for all methods in a MethodGroupExpr until a matching method is
25951 found, so we don't want to bail out if the first method doesn't match.
25952 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25953 matches, report the 123. Fixes #28070.
25955 2002-07-24 Martin Baulig <martin@gnome.org>
25957 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25958 TypeManager.TypeToCoreType() to the top of the method so the
25959 following equality checks will work. Fixes #28107.
25961 2002-07-24 Martin Baulig <martin@gnome.org>
25963 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25964 operand is of type uint, and the other operand is of type sbyte,
25965 short or int, the operands are converted to type long." -
25966 Actually do what this comment already told us. Fixes bug #28106,
25969 2002-07-24 Martin Baulig <martin@gnome.org>
25971 * class.cs (MethodBase): New abstract class. This is now a base
25972 class for Property, Indexer and Event to avoid some code duplication
25973 in their Define() and DefineMethods() methods.
25974 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25975 generic methods for Define() and DefineMethods().
25976 (FieldBase): Derive from MemberBase, not MemberCore.
25977 (Property): Derive from MemberBase, not MemberCore.
25978 (Property.DefineMethod): Moved all the code from this method to the
25979 new MethodBase.DefineAccessor(), just call it with appropriate
25981 (Property.Define): Call the new Property.DoDefine(), this does some
25982 sanity checks and we don't need to duplicate the code everywhere.
25983 (Event): Derive from MemberBase, not MemberCore.
25984 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25985 accessors, this will also make them work with interface events.
25986 (Indexer): Derive from MemberBase, not MemberCore.
25987 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25988 (Indexer.Define): Use the new MethodBase functions.
25990 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25991 argument to the constructor.
25992 (Interface.FindMembers): Added support for interface events.
25993 (Interface.PopluateEvent): Implemented.
25995 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25997 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25999 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26000 but this is required to check for a method name being the same as
26001 the containing class.
26005 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26007 * interface.cs: initialize variable.
26009 2002-07-23 Martin Baulig <martin@gnome.org>
26011 Implemented the IndexerName attribute in interfaces.
26013 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26014 name if this is an explicit interface implementation.
26015 (Indexer.InterfaceIndexerName): New public variable. If we're
26016 implementing an interface indexer, this is the IndexerName in that
26017 interface. Otherwise, it's the IndexerName.
26018 (Indexer.DefineMethod): If we're implementing interface indexer,
26019 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26020 and Pending.ImplementIndexer methods.
26021 (Indexer.Define): Also define the PropertyBuilder if we're
26022 implementing an interface indexer and this is neither an explicit
26023 interface implementation nor do the IndexerName match the one in
26026 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26027 If a method is defined here, then we always need to create a proxy
26028 for it. This is used when implementing interface indexers.
26029 (Pending.IsInterfaceIndexer): New public method.
26030 (Pending.ImplementIndexer): New public method.
26031 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26032 This is used when implementing interface indexers to define a proxy
26034 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26035 define a proxy if necessary.
26037 * interface.cs (Interface.IndexerName): New public variable.
26038 (Interface.PopulateIndexer): Set the IndexerName.
26039 (Interface.DefineIndexers): New private method. Populate all the
26040 indexers and make sure their IndexerNames match.
26042 * typemanager.cs (IndexerPropertyName): Added support for interface
26045 2002-07-22 Martin Baulig <martin@gnome.org>
26047 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26048 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26049 ret if HasReturnLabel.
26050 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26053 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26054 and set the ec.LoopBeginTryCatchLevel.
26055 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26056 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26057 the current ec.TryCatchLevel, the branch goes out of an exception
26058 block. In this case, we need to use Leave and not Br.
26060 2002-07-22 Martin Baulig <martin@gnome.org>
26062 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26063 block unless the block does not always return or it is contained in
26064 another try { ... } catch { ... } block. Fixes bug #26506.
26065 Added verify-1.cs to the test suite.
26067 2002-07-22 Martin Baulig <martin@gnome.org>
26069 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26070 then we do not always return. Fixes bug #24985.
26072 2002-07-22 Martin Baulig <martin@gnome.org>
26074 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26075 lookup on a per-class level; ie. walk up the class hierarchy until we
26076 found at least one applicable method, then choose the best among them.
26077 Fixes bug #24463 and test-29.cs.
26079 2002-07-22 Martin Baulig <martin@gnome.org>
26081 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26082 return types of the methods. The return type is not part of the
26083 signature and we must not check it to make the `new' modifier work.
26084 Fixes bug #27999, also added test-147.cs.
26085 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26087 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26088 on the method's return type.
26090 2002-07-21 Martin Baulig <martin@gnome.org>
26092 * assign.cs: Make this work if the rightmost source is a constant and
26093 we need to do an implicit type conversion. Also adding a few more tests
26094 to test-38.cs which should have caught this.
26096 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26097 target in the makefile for this. The makefile.gnu is primarily intended
26098 for end-users who don't want to debug the compiler.
26100 2002-07-21 Martin Baulig <martin@gnome.org>
26102 * assign.cs: Improved the Assign class so it can now handle embedded
26103 assignments (X = Y = Z = something). As a side-effect this'll now also
26104 consume less local variables. test-38.cs now passes with MCS, added
26105 a few new test cases to that test.
26107 2002-07-20 Martin Baulig <martin@gnome.org>
26109 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26110 instructions. Fixes bug #27977, also added test-146.cs.
26112 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26114 * cs-tokenizer.cs: fixed getHex ().
26116 2002-07-19 Martin Baulig <martin@gnome.org>
26118 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26119 not Type.GetType() to lookup the array type. This is needed when
26120 we're constructing an array of a user-defined type.
26121 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26122 single-dimensional arrays, but also for single-dimensial arrays of
26125 2002-07-19 Martin Baulig <martin@gnome.org>
26127 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26128 this function is called, it's not allowed to share LocalBuilders
26129 among ILGenerators.
26131 2002-07-19 Martin Baulig <martin@gnome.org>
26133 * expression.cs (Argument.Resolve): Report an error 118 when trying
26134 to pass a type as argument.
26136 2002-07-18 Martin Baulig <martin@gnome.org>
26138 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26139 Conv_R_Un for the signed `long' type.
26141 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26143 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26144 `expr' for the temporary result, as that will fail if we do
26145 multiple resolves on the same expression.
26147 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26149 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26150 ec.TypeContainer for looking up aliases.
26152 * class.cs (TypeContainer): Remove LookupAlias from here.
26154 * decl.cs (DeclSpace); Move here.
26156 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26158 * class.cs (FindMembers): Only call filter if the constructor
26159 bulider is not null.
26161 Also handle delegates in `NestedTypes' now. Now we will perform
26162 type lookups using the standard resolution process. This also
26165 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26166 This uses Expressions (the limited kind that can be parsed by the
26167 tree) instead of strings.
26169 * expression.cs (ComposedCast.ToString): Implement, used to flag
26170 errors since now we have to render expressions.
26172 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26175 * ecore.cs (SimpleName.ToString): ditto.
26177 * cs-parser.jay: Instead of using strings to assemble types, use
26178 Expressions to assemble the type (using SimpleName, ComposedCast,
26179 MemberAccess). This should fix the type lookups in declarations,
26180 because we were using a different code path for this.
26182 * statement.cs (Block.Resolve): Continue processing statements
26183 even when there is an error.
26185 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26187 * class.cs (Event.Define): Also remove the `remove' method from
26188 the list of pending items.
26190 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26191 generate more compact code.
26193 2002-07-17 Martin Baulig <martin@gnome.org>
26195 * const.cs (Const.LookupConstantValue): Add support for constant
26196 `unchecked' and `checked' expressions.
26197 Also adding test case test-140.cs for this.
26199 2002-07-17 Martin Baulig <martin@gnome.org>
26201 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26202 check whether mi.ReturnType implements the IEnumerator interface; the
26203 `==' and the IsAssignableFrom() will fail in this situation.
26205 2002-07-16 Ravi Pratap <ravi@ximian.com>
26207 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26210 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26212 * expression.cs: fixed bug #27811.
26214 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26216 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26217 Molaro: when we are a ref, the value already contains a pointer
26218 value, do not take the address of it.
26220 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26221 * removed mb-parser.jay and mb-tokenizer.cs
26223 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26225 * expression.cs: check against the building corlib void type.
26227 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26229 * ecore.cs: fix for valuetype static readonly fields: when
26230 initializing them, we need their address, not the address of a copy.
26232 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26234 * typemanager.cs: register also enum_type in corlib.
26236 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26238 * class.cs: allow calling this (but not base) initializers in structs.
26240 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26242 * ecore.cs: make sure we compare against the building base types
26245 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26247 * typemanager.cs: fix TypeToCoreType() to handle void and object
26248 (corlib gets no more typerefs after this change).
26250 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26252 * expression.cs (ArrayCreation.EmitArrayArguments): use
26253 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26255 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26256 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26257 array indexes, the runtime actually forbids them.
26259 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26260 for array arguments here.
26262 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26263 instead of the default for ValueTypes.
26265 (New.DoEmit): Use IsValueType instead of
26266 IsSubclassOf (value_type)
26267 (New.DoResolve): ditto.
26268 (Invocation.EmitCall): ditto.
26270 * assign.cs (Assign): ditto.
26272 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26273 Statements *are* currently doing part of their resolution during
26276 Expressions do always resolve during resolve, but statements are
26277 only required to propagate resolution to their children.
26279 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26281 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26283 (LoadAssembly): Do not add the dll if it is already specified
26285 (MainDriver): Add the System directory to the link path at the end,
26286 after all the other -L arguments.
26288 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26289 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26290 ldelem.u1) and using the opposite for sbytes.
26292 This fixes Digger, and we can finally run it.
26294 * driver.cs (UnixParseOption): Move the option parsing here.
26295 (CSCParseOption): Implement CSC-like parsing of options.
26297 We now support both modes of operation, the old Unix way, and the
26298 new CSC-like way. This should help those who wanted to make cross
26299 platform makefiles.
26301 The only thing broken is that /r:, /reference: and /lib: are not
26302 implemented, because I want to make those have the same semantics
26303 as the CSC compiler has, and kill once and for all the confussion
26304 around this. Will be doing this tomorrow.
26306 * statement.cs (Unsafe.Resolve): The state is checked during
26307 resolve, not emit, so we have to set the flags for IsUnsfe here.
26309 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26311 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26312 not catch the Error_ObjectRefRequired in SimpleName (as it is
26313 possible to have a class/instance variable name that later gets
26314 deambiguated), we have to check this here.
26316 2002-07-10 Ravi Pratap <ravi@ximian.com>
26318 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26319 make static and put into Expression.
26321 (Event.Define): Register the private field of the event with the
26322 TypeManager so that GetFieldFromEvent can get at it.
26324 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26325 keep track of the private field associated with an event which
26328 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26331 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26333 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26335 * expression.cs (Binary.EmitBranchable): this routine emits the
26336 Binary expression in a branchable context. This basically means:
26337 we need to branch somewhere, not just get the value on the stack.
26339 This works together with Statement.EmitBoolExpression.
26341 * statement.cs (Statement.EmitBoolExpression): Use
26344 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26346 * statement.cs (For): Reduce the number of jumps in loops.
26348 (For): Implement loop inversion for the For statement.
26350 (Break): We can be breaking out of a Try/Catch controlled section
26351 (foreach might have an implicit try/catch clause), so we need to
26352 use Leave instead of Br.
26354 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26355 now). If the instace expression supports IMemoryLocation, we use
26356 the AddressOf method from the IMemoryLocation to extract the
26357 address instead of emitting the instance.
26359 This showed up with `This', as we were emitting the instance
26360 always (Emit) instead of the Address of This. Particularly
26361 interesting when This is a value type, as we dont want the Emit
26362 effect (which was to load the object).
26364 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26366 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26368 * statement.cs (Checked): Set the CheckedState during the resolve
26369 process too, as the ConvCast operations track the checked state on
26370 the resolve process, and not emit.
26372 * cs-parser.jay (namespace_member_declaration): Flag that we have
26373 found a declaration when we do. This is used to flag error 1529
26375 * driver.cs: Report ok when we display the help only.
26377 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26379 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26381 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26383 * cs-tokenizer.cs (define): We also have to track locally the
26384 defines. AllDefines is just used for the Conditional Attribute,
26385 but we also need the local defines for the current source code.
26387 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26389 * statement.cs (While, For, Do): These loops can exit through a
26390 Break statement, use this information to tell whether the
26391 statement is the last piece of code.
26393 (Break): Flag that we break.
26395 * codegen.cs (EmitContexts): New `Breaks' state variable.
26397 2002-07-03 Martin Baulig <martin@gnome.org>
26399 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26400 modifiers in method declarations in structs. Otherwise, you won't
26401 be able to override things like Object.Equals().
26403 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26405 * class.cs (Method, Property, Indexer): Do not allow the public
26406 modifier to be used in explicit interface implementations.
26408 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26409 override modifiers in method declarations in structs
26411 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26413 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26414 integer or real overflow, report an error
26416 2002-07-02 Martin Baulig <martin@gnome.org>
26418 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26419 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26420 to tell the runtime about our newly created System.Object and
26421 System.ValueType types.
26423 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26425 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26426 struct instead of Ldarg/Starg.
26428 2002-07-02 Martin Baulig <martin@gnome.org>
26430 * expression.cs (Indirection.Indirection): Call
26431 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26433 2002-07-02 Martin Baulig <martin@gnome.org>
26435 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26436 ValueType, call TypeManager.TypeToCoreType() on it.
26437 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26438 the OpCodes.Newarr argument.
26440 2002-07-02 Martin Baulig <martin@gnome.org>
26442 * expression.cs (Invocation.EmitCall): When compiling corlib,
26443 replace all calls to the system's System.Array type to calls to
26444 the newly created one.
26446 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26447 System.Array methods.
26448 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26449 from the system's System.Array type which must be replaced.
26451 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26453 * typemanager.cs: load unverifiable_code_ctor so we can build
26454 corlib using the correct type. Avoid using GetTypeCode() with
26456 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26457 TypeManager.object_type to allow building corlib.
26459 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26461 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26463 2002-07-01 Martin Baulig <martin@gnome.org>
26465 * class.cs: Make the last change actually work, we need to check
26466 whether `ifaces != null' to avoid a crash.
26468 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26470 * class.cs: when we build structs without fields that implement
26471 interfaces, we need to add the interfaces separately, since there is
26472 no API to both set the size and add the interfaces at type creation
26475 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26477 * expression.cs: the dimension arguments to the array constructors
26478 need to be converted if they are a long.
26480 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26482 * class.cs: don't emit ldarg.0 if there is no parent constructor
26483 (fixes showstopper for corlib).
26485 2002-06-29 Martin Baulig <martin@gnome.org>
26487 MCS now compiles corlib on GNU/Linux :-)
26489 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26490 ie. check for MethodImplOptions.InternalCall.
26492 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26493 and TypeManager.attribute_type are null, so we must explicitly check
26494 whether parent is not null to find out whether it's an attribute type.
26495 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26496 and SetBuilder, not only if the property is neither abstract nor external.
26497 This is necessary to set the MethodImplOptions on the accessor methods.
26498 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26499 SetBuilder, see Property.Emit().
26501 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26502 populate "System.Object", "System.ValueType" and "System.Attribute" since
26503 they've already been populated from BootCorlib_PopulateCoreTypes().
26505 2002-06-29 Martin Baulig <martin@gnome.org>
26507 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26508 is the NullLiteral, we also need to make sure that target_type is not
26511 2002-06-29 Martin Baulig <martin@gnome.org>
26513 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26514 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26515 before calling BootstrapCorlib_ResolveDelegate ().
26517 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26519 * statement.cs: fixed build-breaker. All tests passed ok.
26521 2002-06-27 Martin Baulig <martin@gnome.org>
26523 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26524 for System.Decimal when compiling corlib.
26526 2002-06-27 Martin Baulig <martin@gnome.org>
26528 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26529 switch blocks which contain nothing but a default clause.
26531 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26533 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26535 2002-06-27 Martin Baulig <martin@gnome.org>
26537 * ecore.cs (PropertyExpr.PropertyExpr): Call
26538 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26540 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26541 is already a TypeBuilder.
26543 2002-06-27 Martin Baulig <martin@gnome.org>
26545 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26546 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26547 the "from an array-type to System.Array" case. This makes it work
26548 when compiling corlib.
26550 2002-06-27 Martin Baulig <martin@gnome.org>
26552 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26553 non-static PropertyExpr, set its InstanceExpression. This makes
26554 the `ICollection.Count' property work in System/Array.cs.
26556 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26558 * driver.cs: Made error handling more consistent. Errors now
26559 tracked by Report class, so many methods which used to return int
26560 now return void. Main() now prints success/failure and
26561 errors/warnings message.
26563 Renamed '--probe' compiler argument to '--expect-error'. Removed
26564 the magic number return values (123 and 124). Now, if the
26565 expected error occurs, the compiler exits with success (exit value
26566 0). If the compilation completes without seeing that particular
26567 error, the compiler exits with failure (exit value 1). The
26568 makefile in mcs/errors has been changed to handle the new behaviour.
26570 * report.cs: Made 'expected error' number a property and renamed
26571 it from 'Probe' to 'ExpectedError'.
26573 * genericparser.cs: Removed error handling support, since it is
26574 now all done by Report class.
26576 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26577 class, so parse() no longer returns an int.
26579 * namespace.cs: Use Report.Error instead of GenericParser.error
26581 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26583 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26584 TypeContainer.AddOperator): At the front of the list put the
26585 explicit implementations, so they get resolved/defined first.
26587 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26589 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26590 interface type is implemented by this TypeContainer. Used during
26591 explicit interface implementation.
26593 (Property.Define, Indexer.Define, Method.Define): Validate that
26594 the given interface in the explicit implementation is one of the
26595 base classes for the containing type.
26597 Also if we are explicitly implementing an interface, but there is
26598 no match in the pending implementation table, report an error.
26600 (Property.Define): Only define the property if we are
26601 not explicitly implementing a property from an interface. Use the
26602 correct name also for those properties (the same CSC uses,
26603 although that is really not needed).
26605 (Property.Emit): Do not emit attributes for explicitly implemented
26606 properties, as there is no TypeBuilder.
26608 (Indexer.Emit): ditto.
26610 Hiding then means that we do not really *implement* a pending
26611 implementation, which makes code fail.
26613 2002-06-22 Martin Baulig <martin@gnome.org>
26615 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26616 the return value of Object.GetType(). [FIXME: we need to do this whenever
26617 we get a type back from the reflection library].
26619 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26621 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26623 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26625 * attribute.cs: Return null if we can not look up the type.
26627 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26628 the interface types found.
26630 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26631 interface types found.
26633 * typemanager.cs (GetInterfaces): Make this routine returns alll
26634 the interfaces and work around the lame differences between
26635 System.Type and System.Reflection.Emit.TypeBuilder in the results
26636 result for GetInterfaces.
26638 (ExpandInterfaces): Given an array of interface types, expand and
26639 eliminate repeated ocurrences of an interface. This expands in
26640 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26643 2002-06-21 Martin Baulig <martin@gnome.org>
26645 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26648 2002-06-21 Martin Baulig <martin@gnome.org>
26650 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26651 and called with one of the core types, return the corresponding typebuilder for
26654 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26657 2002-06-21 Martin Baulig <martin@gnome.org>
26659 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26660 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26661 (Expression.ConvertReferenceExplicit): Likewise.
26663 * expression.cs (ElementAccess.DoResolve): Likewise.
26664 (ElementAccess.DoResolveLValue): Likewise.
26666 2002-06-10 Martin Baulig <martin@gnome.org>
26668 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26669 add the "value" parameter to the parameter list.
26671 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26674 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26676 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26677 the argument to an int, uint, long or ulong, per the spec. Also
26678 catch negative constants in array creation.
26680 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26682 * class.cs: do not allow the same interface to appear twice in
26683 the definition list.
26685 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26687 * ecore.cs: don't use ldlen with System.Array.
26689 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26691 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26693 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26695 * modifiers.cs: produce correct field attributes for protected
26696 internal. Easy fix so miguel can work on ther harder stuff:-)
26698 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26700 * pending.cs: New file. Move the code from class.cs here.
26701 Support clearning the pending flag for all methods (when not doing
26702 explicit interface implementation).
26704 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26706 * rootcontext.cs: added a couple more types needed to bootstrap.
26708 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26710 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26711 constructor in the type, instead of any constructor in the type
26712 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26713 a bug in the Mono runtime when applying the params attribute).
26715 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26716 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26718 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26720 * expression.cs (Unary.ResolveOperator): Use TypeManager
26721 to resolve the type.
26723 2002-06-13 Ravi Pratap <ravi@ximian.com>
26725 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26728 * enum.cs (AddEnumMember): Add support to store the attributes associated
26729 with each member too.
26731 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26732 field builders too - this takes care of the enum member case.
26734 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26736 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26737 address-of operator on both value types and pointers.
26739 2002-06-10 Martin Baulig <martin@gnome.org>
26741 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26742 PropertyBuilder to the `property_builders' list.
26744 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26745 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26746 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26747 find any indexers which are inherited from an interface.
26749 2002-06-09 Martin Baulig <martin@gnome.org>
26751 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26752 the same type as the constant if necessary. There's also a test-130.cs
26755 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26757 * typemanager.cs (TypeManager.ChangeType): Previously known as
26758 Enum.ChangeEnumType().
26760 2002-06-09 Martin Baulig <martin@gnome.org>
26762 * expression.cs (Cast.TryReduce): Added support for consts.
26764 2002-06-08 Ravi Pratap <ravi@ximian.com>
26766 * class.cs (Accessor): Hold attributes information so we can pass
26769 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26770 Modify to pass in attributes attached to the methods.
26772 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26774 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26775 to handle the Accessor kind :-)
26777 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26779 2002-06-08 Martin Baulig <martin@gnome.org>
26781 * expression.cs (Unary.TryReduceNegative): Added support for
26784 2002-06-08 Martin Baulig <martin@gnome.org>
26786 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26787 name can't be found in the `defined_names' - the caller will do a
26788 MemberLookup in this case and thus find methods in System.Enum
26789 such as Enum.IsDefined().
26791 2002-06-08 Martin Baulig <martin@gnome.org>
26793 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26794 Convert.ChangeType() which works with TypeBuilder created types.
26795 (Enum.LookupEnumValue, Enum.Define): Use it here.
26797 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26798 `TypeBuilder.BaseType != null' check.
26799 (TypeContainer.FindMembers): Only lookup parent members if we
26800 actually have a parent.
26801 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26802 (ConstructorInitializer.Resolve): Likewise.
26804 * interface.cs (Interface.FindMembers): Added
26805 `TypeBuilder.BaseType != null' check.
26807 * rootcontext.cs (RootContext.ResolveCore): Added
26808 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26809 classes_second_stage.
26811 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26812 debug_type and trace_type when compiling with --nostdlib.
26814 2002-06-07 Martin Baulig <martin@gnome.org>
26816 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26817 (AddField): Set it to true when adding a non-static field.
26818 (DefineType): Use `have_nonstatic_fields' to find out whether we
26819 have non-static fields, not `Fields != null'.
26821 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26823 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26824 dereferencing a null on the static-field code path)
26826 2002-05-30 Martin Baulig <martin@gnome.org>
26828 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26829 to take command line arguments. Use reflection to call the new
26830 custom `Initialize' function on the symbol writer and pass it the
26831 command line arguments.
26833 * driver.cs (--debug-args): New command line argument to pass command
26834 line arguments to the symbol writer.
26836 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26838 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26839 the target type for indexers and properties. Thanks to Joe for
26842 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26844 * typemanager.cs (MethodFlags): returns the method flags
26845 (Obsolete/ShouldIgnore) that control warning emission and whether
26846 the invocation should be made, or ignored.
26848 * expression.cs (Invocation.Emit): Remove previous hack, we should
26849 not do this on matching a base type, we should do this based on an attribute
26851 Only emit calls to System.Diagnostics.Debug and
26852 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26853 on the command line.
26855 * rootcontext.cs: Global settings for tracing and debugging.
26857 * cs-tokenizer.cs (define): New utility function to track
26858 defines. Set the global settings for TRACE and DEBUG if found.
26860 2002-05-25 Ravi Pratap <ravi@ximian.com>
26862 * interface.cs (Populate*): Pass in the TypeContainer as well as
26863 the DeclSpace as parameters so that we can create EmitContexts and
26864 then use that to apply attributes etc.
26866 (PopulateMethod, PopulateEvent, PopulateProperty)
26867 (PopulateIndexer): Apply attributes everywhere.
26869 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26872 (ApplyAttributes): Update accordingly.
26874 We now apply interface attributes for all members too.
26876 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26878 * class.cs (Indexer.Define); Correctly check if we are explicit
26879 implementation (instead of checking the Name for a ".", we
26880 directly look up if the InterfaceType was specified).
26882 Delay the creation of the PropertyBuilder.
26884 Only create the PropertyBuilder if we are not an explicit
26885 interface implementation. This means that explicit interface
26886 implementation members do not participate in regular function
26887 lookups, and hence fixes another major ambiguity problem in
26888 overload resolution (that was the visible effect).
26890 (DefineMethod): Return whether we are doing an interface
26893 * typemanager.cs: Temporary hack until we get attributes in
26894 interfaces (Ravi is working on that) and we get IndexerName
26895 support in interfaces.
26897 * interface.cs: Register the indexers as properties.
26899 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26900 warning, I have verified that this is a bug in the .NET runtime
26901 (JavaScript suffers of the same problem).
26903 * typemanager.cs (MemberLookup): When looking up members for
26904 interfaces, the parent of an interface is the implicit
26905 System.Object (so we succeed in searches of Object methods in an
26906 interface method invocation. Example: IEnumerable x; x.ToString
26909 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26911 * class.cs (Event): Events should also register if they do
26912 implement the methods that an interface requires.
26914 * typemanager.cs (MemberLookup); use the new GetInterfaces
26917 (GetInterfaces): The code used to lookup interfaces for a type is
26918 used in more than one place, factor it here.
26920 * driver.cs: Track the errors at the bottom of the file, we kept
26923 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26924 instance if the method we are calling is static!
26926 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26928 * attribute.cs (ApplyAttributes): Make this function filter out
26929 the IndexerName attribute (as that attribute in reality is never
26930 applied) and return the string constant for the IndexerName
26933 * class.cs (TypeContainer.Emit): Validate that all the indexers
26934 have the same IndexerName attribute, and if so, set the
26935 DefaultName attribute on the class.
26937 * typemanager.cs: The return value might contain other stuff (not
26938 only methods). For instance, consider a method with an "Item"
26939 property and an Item method.
26941 * class.cs: If there is a problem with the parameter types,
26944 2002-05-24 Ravi Pratap <ravi@ximian.com>
26946 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26947 looks at user defined conversion after making a call to
26948 StandardConversionExists - we need this for overload resolution.
26950 * expression.cs : Update accordingly the various method calls.
26952 This fixes 2 bugs filed against implicit user defined conversions
26954 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26956 * statement.cs: Track the result of the assignment.
26958 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26960 * expression.cs (MemberAccess): Improved error reporting for
26961 inaccessible members.
26963 2002-05-22 Martin Baulig <martin@gnome.org>
26965 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26966 itself with debugging support.
26968 2002-05-22 Martin Baulig <martin@gnome.org>
26970 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26971 Removed, this isn't needed anymore.
26973 2002-05-20 Martin Baulig <martin@gnome.org>
26975 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26976 be underlying type for an enum.
26978 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26980 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26981 that splits out the loading of just the core types.
26983 * rootcontext.cs (ResolveCore): Split the struct resolution in
26984 two, so we can load the enumeration underlying types before any
26987 * expression.cs (Is): Bandaid until we fix properly Switch (see
26988 bug #24985 for details).
26990 * typemanager.cs (ImplementsInterface): The hashtable will contain
26991 a null if there are no interfaces implemented.
26993 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26995 * cs-parser.jay (indexer_declarator): It is fine to have array
26998 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27000 * typemanager.cs: (RegisterBuilder): New function used to register
27001 TypeBuilders that implement interfaces. Since
27002 TypeBuilder.GetInterfaces (as usual) does not work with lame
27004 (AddUserType): register interfaces.
27006 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27007 dealing with TypeBuilder. Also, arrays are showing up as
27008 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27009 methods can not be invoked on them!
27011 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27012 (ImplicitReferenceConversionExists): Split out from
27013 StandardConversionExists.
27015 * expression.cs (As): We were only implementing one of the three
27016 cases for the as operator. We now implement them all.
27017 (Is): Implement the various other cases for Is as well.
27019 * typemanager.cs (CACHE): New define used to control if we want or
27020 not the FindMembers cache. Seems to have a negative impact on
27021 performance currently
27023 (MemberLookup): Nested types have full acess to
27024 enclosing type members
27026 Remove code that coped with instance/static returns for events, we
27027 now catch this in RealFindMembers.
27029 (RealFindMembers): only perform static lookup if the instance
27030 lookup did not return a type or an event.
27032 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27034 * assign.cs (CompoundAssign): We pass more semantic information
27035 now to Compound Assignments than we did before: now we have all
27036 the information at hand, and now we resolve the target *before* we
27037 do the expression expansion, which allows the "CacheValue" method
27038 to have the effect we intended (before, a [x] += 1 would generate
27039 two differen ArrayAccess expressions from the ElementAccess,
27040 during the resolution process).
27042 (CompoundAssign.DoResolve): Resolve target and original_source here.
27044 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27046 * expression.cs (ArrayAccess): dropped debugging information.
27048 * typemanager.cs: Small bug fix: I was always returning i_members,
27049 instead of one of i_members or s_members (depending on which had
27052 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27053 method is invoked before any code generation takes place, and it
27054 is a mechanism to inform that the expression will be invoked more
27055 than once, and that the method should use temporary values to
27056 avoid having side effects
27058 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27060 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27063 * expression.cs (Indirection, ArrayAccess): Add support for
27064 CacheTemporaries in these two bad boys.
27066 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27067 ldobj or ldind_ref.
27068 (StoreFromPtr): Handle stobj as well.
27070 * expression.cs (UnaryMutator): Share more code.
27072 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27073 down: I was not tracking the Filter function as well, which
27074 was affecting the results of the cache.
27076 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27078 * attribute.cs: Remove the hack to handle the CharSet property on
27081 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27083 * attribute.cs (DoResolve): More uglyness, we now only try to
27084 resolve the attribute partially, to extract the CharSet
27085 information (only if we are a StructLayout attribute). Otherwise
27087 (GetExtraTypeInfo): Add some code to conditionally kill in the
27088 future this. I am more and more convinced that the .NET
27089 framework has special code to handle the attribute setting on
27092 * expression.cs (IsParamsMethodApplicable): Revert my previous
27093 foreach change here, it was wrong.
27095 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27097 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27098 (pp_expr): do not abort on unknown input, just return.
27099 (eval): abort if there are pending chars.
27101 * attribute.cs (Attribute.Resolve): Positional parameters are
27102 optional. Deal with that case.
27104 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27105 the Ansi/Unicode/Auto information for the type.
27107 (TypeContainer.DefineType): instantiate the EmitContext here, as
27108 we will be using it during the type definition (to resolve
27109 attributes) and during the emit phase.
27111 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27112 to pull type information out of the attributes
27114 (Attribute.Resolve): track the constructor builder, and allow for
27115 multiple invocations (structs and classes will use this).
27117 * ecore.cs (MemberLookupFinal): new version with all the
27118 parameters customizable.
27120 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27121 constructors. Return if the result value is null (as the error
27122 would have been flagged already by MemberLookupFinal)
27124 Do not allow instances of abstract classes or interfaces to be
27127 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27128 We have to compare the assembly property here when dealing with
27129 FamANDAssem and Assembly access modifiers, because we might be
27130 creating an assembly from *modules* (that means that we are not
27131 getting TypeBuilders for types defined in other modules that are
27132 part of this assembly).
27134 (Method.Emit): If the method is marked abstract and has a body,
27137 (TypeContainer.DefineMembers): If both the defined member and the
27138 parent name match are methods, then do not emit any warnings: let
27139 the Method.Define routine take care of flagging warnings. But if
27140 there is a mismatch (method overrides something else, or method is
27141 overriwritten by something, then emit warning).
27143 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27144 set to null, this means `do not check for the return type on the
27147 (Method.Define): set the return type for the method signature to
27148 null, so that we get methods with the same name and parameters and
27149 different return types. This is used to flag warning 114 (you are
27150 hiding a method, and you probably want to use the new/override
27153 * typemanager.cs (MemberLookup): Implemented proper access
27154 control, closing a long standing set of bug reports. The problem
27155 was that the Framework only has two bits: Public and NonPublic,
27156 and NonPublic includes private and protected methods, but we need
27157 to enforce the FamANDAssem, FamOrAssem and Family.
27159 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27161 * statement.cs (GotoCase): Return true: Ammounts to giving up
27162 knowledge on whether we return or not, and letting the other case
27163 be responsible for it.
27165 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27167 * driver.cs: Do not load directories for each file processed, only
27168 do it if there is a pattern.
27170 * ecore.cs: Report readonly assigns here as well, as we might have
27171 been resolved only by MemberAccess.
27173 (SimpleName.SimpleNameResolve): Also be useful for LValue
27174 resolution. We need this to propagate assign to local readonly variables
27176 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27177 do not want to reuse potential criteria memory.
27179 * class.cs (MyEventBuilder): Set reflected_type;
27181 * ecore.cs (Constantify): Added support for constifying bools.
27183 (RootContext.LookupType): Added a cache for values looked up in
27184 the declaration space.
27186 * typemanager.cs (FindMembers): Now is a front-end to
27187 RealFindMembers, and provides a two-level hashtable-based cache to
27190 15% performance improvement: from 22.5 to 19.2 seconds.
27192 * expression.cs (IsParamsMethodApplicable): use foreach.
27193 (Invocation.DoResolve): ditto.
27194 (New.DoResolve): ditto.
27195 (ArrayCreation.DoResolve): ditto.
27197 * ecore.cs (FindMostEncompassingType): use foreach.
27199 * delegate.cs (NewDelegate.DoResolve): Use foreach
27201 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27202 (RemoveMethods): use foreach.
27204 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27205 nested foreach statements instead of for, and also break out of
27206 the inner loop once a match is found.
27208 (Invocation.OverloadResolve): Use foreach, simplify the code.
27210 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27212 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27213 we actually unwrap the expression to allow for extra information
27216 * expression.cs: Use Shr_Un on unsigned operations.
27218 2002-05-08 Ravi Pratap <ravi@ximian.com>
27220 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27221 applicable operators was not being considered correctly. This closes
27222 the bug Miguel reported.
27224 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27226 * attribute.cs: check that the type derives from System.Attribute
27227 and report the correct error in that case (moved the duplicate code to
27228 its own method, too).
27230 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27232 * attribute.cs: lookup attribute type name as the spec says: first the
27233 bare attribute name and then name + "Attribute" (nant compiles with
27234 mcs after this fix).
27236 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27238 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27239 Because of the way we parse things, we should try to see if a
27240 UIntConstant can fit in an integer.
27242 2002-05-07 Ravi Pratap <ravi@ximian.com>
27244 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27245 when we are in an explicit context.
27247 (ConvertReferenceExplicit): When converting from Iface type S to Class
27248 T make sure the rules are implemented as an OR.
27250 * parameter.cs (ParameterType): Make it a property for now although the
27251 purpose really isn't anything immediate.
27253 * expression.cs (Is*Applicable): Do better checking on the parameter type
27254 of a ref/out parameter. The ones from the system assemblies are already
27255 marked with the correct type so we don't need to do any correction.
27257 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27258 the object type is standard too so include that.
27260 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27262 * ecore.cs (StandardConversionExists): Augment with missing code:
27263 deal with IntConstant, LongConstants and Enumerations.
27265 * assign.cs: Report the error, instead of failing silently
27267 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27268 typecontainer that they are declared, because the
27269 typecontainer/namespace will have the list of using clauses that
27270 need to be applied.
27272 Assembly Attributes were escaping the normal registration
27275 (EmitCode): Apply attributes within an EmitContext that represents
27276 the container they were declared on.
27278 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27280 2002-05-06 Ravi Pratap <ravi@ximian.com>
27282 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27283 Revamp completely - make much cleaner as we now operate only
27286 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27287 to implement the logic detailed in the spec more correctly.
27289 (UserDefinedConversion): Update accordingly.
27291 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27293 * statement.cs: Return flow analysis information up.
27295 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27298 (token): Do not consume an extra character before calling
27301 2002-05-06 Piers Haken <piersh@friskit.com>
27303 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27305 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27307 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27308 EmitContext during the instance constructor initializer
27309 resolution, to stop access to instance variables.
27311 This is mandated by the spec, last paragraph of the `constructor
27312 initializers' section.
27314 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27316 * cs-parser.jay, class.cs (Accessor): new class used to represent
27317 an accessor (get or set). In the past we used `null' to represent
27318 a missing accessor. But this is ambiguous because there was no
27319 way to tell in abstract indexers/properties if one of them was
27322 Now there is a way of addressing that.
27324 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27325 instead of FindMembers.
27327 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27328 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27330 * attribute.cs: Treat indexers and properties as the same in terms
27331 of applying attributes
27333 * ecore.cs (FindMostEncompassedType): Use statically initialized
27334 EmptyExpressions()s like we do elsewhere to avoid creating useless
27335 objects (and we take this out of the tight loop).
27337 (GetConversionOperators): Move the code to extract the actual
27338 operators to a separate routine to clean things up.
27340 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27342 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27343 events are always registered FieldBuilders.
27345 * class.cs (FieldBase): New class shared by Fields
27347 * delegate.cs: If we are a toplevel delegate, use our full name.
27348 If we are a nested delegate, then only use our tail name.
27350 2002-05-02 Ravi Pratap <ravi@ximian.com>
27352 * expression.cs (IsApplicable): Ensure that we add the "&" to
27353 ref/out types before comparing it with the type of the argument.
27355 (IsParamsMethodApplicable): Ditto.
27357 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27360 * delegate.cs : Handle the case when we have more than one applicable
27361 method. Flag an error only when we finish checking all.
27363 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27365 * expression.cs: Add support for boolean static initializers.
27367 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27369 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27371 * parameter.cs (ComputeParameterTypes,
27372 ComputeAndDefineParameterTypes): Better error handling: now we
27373 clear the `types' cache if we fail during any of the type lookups.
27374 We also return the status code correctly to our caller
27376 * delegate.cs: If we fail to define a delegate, abort the extra
27379 * expression.cs (Binary.ResolveOperator): for
27380 operator==(object,object) and operator !=(object, object) we also
27381 have to verify that there is an implicit conversion from one to
27384 (ArrayAccess.DoResolve): Array Access can operate on
27387 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27389 * assign.cs (CompoundAssign): A new class used as a "flag" that
27390 the assignment actually is happening as part of a compound
27391 assignment operator.
27393 During compound assignment, a few new rules exist to enable things
27400 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27401 to the type of x) if y is implicitly convertible to the type of x,
27402 and the operator is a builtin operator and the return type of the
27403 operator is explicitly convertible to the type of x.
27405 * rootcontext.cs: Reset warning level to 2. 4 catches various
27406 "interesting" features in mcs, we must clean this up at some
27407 point, but currently am trying to kill other bugs ;-)
27409 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27410 in container classes as well.
27412 * expression.cs (Binary.ResolveOperator): Handle string case
27413 before anything else (as operator overloading does emit an error
27414 before doing anything else).
27416 This code could go away when we move to a table driven model, but
27417 i could not come up with a good plan last night.
27419 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27421 * typemanager.cs (CSharpName): reimplementation using regex.
27422 * class.cs: added null check for fields in Emit
27423 * rootcontext.cs: set warninglevel to 4
27425 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27427 * typemanager.cs (CSharpName): reimplemented with Lupus
27430 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27432 * statement.cs (If): correclty implement Resolve, because we were
27433 not catching sem errors in there. The same process is needed
27435 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27438 (Statement.Warning_DeadCodeFound): Factorize code.
27439 (While): Report dead code here too.
27441 (Statement): Added Resolve virtual method to allow
27442 for resolution split from the emit code.
27444 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27446 * statement.cs (EmitBoolExpression): No longer try to resolve the
27448 (MakeBoolean): New utility function that resolve, implicitly
27449 converts to boolean and tags the expression.
27452 (If, Do): Implement dead code elimination.
27453 (While): Implement loop inversion
27455 (Do, While, For, If): Resolve the expression prior to calling our
27458 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27461 - added method Report28 (warning: program has more than one entry point)
27462 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27463 - modified method Method.Define, the part at the end of the method
27465 * rootcontext.cs: added static public Location EntryPointLocation;
27467 * ../errors/cs0028.cs : Add test case for the above warning.
27470 - modified method CSharpName to allow arrays of primitive type to
27471 be printed nicely (e.g. instead of System.Int32[][] it now prints
27473 - added method CSharpSignature: returns the signature of a method
27474 in string format to be used in reporting errors, warnings, etc.
27476 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27479 2002-04-26 Ravi Pratap <ravi@ximian.com>
27481 * delegate.cs (Define): Fix extremely silly bug where I was
27482 setting the type of the 'object' parameter of the BeginInvoke
27483 method to System.IAsyncResult instead of System.Object ;-)
27485 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27487 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27490 (Constructor.Emit): return if we fail to initialize the
27491 constructor. Another door closed!
27493 * expression.cs (New.DoResolve): Improve error message (from -6 to
27494 1501). Use DeclaredOnly lookup to find the exact constructor.
27496 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27497 loop. This is useful.
27499 * cs-parser.jay: Adjust the default parameters so that destructors
27500 have the proper signature.
27502 2002-04-26 Martin Baulig <martin@gnome.org>
27504 * driver.cs (LoadAssembly): If `assembly' contains any characters
27505 which are only valid in path names and not in assembly names
27506 (currently slash, backslash and point), use Assembly.LoadFrom ()
27507 instead of Assembly.Load () on the `assembly' (before iteration
27508 over the link_paths).
27510 2002-04-26 Martin Baulig <martin@gnome.org>
27512 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27514 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27516 * class.cs (Property): use the new typemanager.MemberLookup
27518 (TypeContainer.MemberLookup): Implement using the
27519 TypeManager.MemberLookup now.
27521 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27522 and return MemberInfos, so that these can be used without an
27523 EmitContext (what we had before).
27525 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27527 * expression.cs: Fix the case where the argument to params if the
27528 type of the params. I omitted handling this before. Fixed
27530 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27532 * driver.cs: Call BootCorlib_PopulateCoreType
27534 * class.cs (Property.CheckBase): Check for properties only, not
27537 * interface.cs: Temporary hack: try/catch around the
27538 CustomAttributeBuilder, because I am getting an exception that I
27541 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27542 types whose definitions are required to be there (attributes are
27543 defined before standard types).
27545 Compute definitions as we boot the various types, as they are used
27546 immediately (value_type class will need object_type, but if we do
27547 not initialize object_type, we will pass a null, which will let
27548 the runtime pick the System.Object from the existing corlib, which
27549 is not what we want).
27551 2002-04-22 Patrik Torstensson <totte@labs2.com>
27553 * cs-tokenizer.cs: fixed a number of trim() issues.
27555 2002-04-22 Ravi Pratap <ravi@ximian.com>
27557 * expression.cs (Argument.Type): Ensure that we return the correct
27558 type when we have out or ref parameters [in which case we
27561 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27563 * class.cs (Property, Indexer): Allow extern modifier in there.
27565 * typemanager.cs (InitBaseTypes): Initializes object_type and
27566 value_type, since those will be used early on during the bootstrap
27567 process to compile corlib.
27569 (InitCoreTypes): Move code from here to InitBaseTypes.
27571 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27573 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27574 single-dimension arrays as using the ldlen opcode.
27576 Daniel Lewis discovered this optimization.
27578 * typemanager.cs: Add signature for System.Array::get_Length
27580 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27582 * statement.cs: report the error when the foreach does not apply to an
27583 array nor a collection.
27585 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27587 * expression.cs: Add implicit conversions to the operator ~.
27589 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27591 * typemanager.cs: Locate the decimal constructor.
27593 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27595 * attribute.cs: use the new property of TypeOf.
27596 * expression.cs: added 'get' property around typearg.
27598 These changes fix a build breaker reported by NickD. Is this the
27599 correct way to fix? If not, please, revert my changes and make it
27602 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27604 * attribute.cs: Add support for typeof in attribute invocations.
27605 I am not sure that this is right though.
27607 2002-04-14 Duncan Mak <duncan@ximian.com>
27609 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27610 Binary.Operator.Division case.
27612 2002-04-13 Ravi Pratap <ravi@ximian.com>
27614 * class.cs (DefineType): Ensure that we do a proper check on
27615 attribute types and also register it with the TypeManager.
27617 (TypeContainer.Targets): The default for attribute types is
27618 AttributeTargets.All.
27620 * attribute.cs (ApplyAttributes): Registering the attribute type
27621 is done elsewhere, not when we discover we have a Usage attribute.
27623 2002-04-12 Ravi Pratap <ravi@ximian.com>
27625 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27626 and get rid of is_delegate parameter.
27628 * everywhere : update.
27630 2002-04-12 Ravi Pratap <ravi@ximian.com>
27632 * cs-parser.jay (compilation_unit): Revamp completely to use
27633 some new ideas that I got from Rhys' grammar to solve the problems
27634 with assembly level attributes.
27636 (outer_declaration): New grammar production.
27638 (attribute_sections): Add.
27640 (opt_attributes): Base on attribute_sections
27642 (namespace_declaration): Allow opt_attributes to tackle the case
27643 when we have assembly level attributes - we are clever in this
27646 * attribute.cs (ApplyAttributes): Do not worry about assembly
27647 attributes in the non-global context.
27649 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27650 instead of SetGlobalAttributes.
27652 * class.cs, rootcontext.cs : Ensure we define and generate
27653 attribute types before anything else.
27655 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27656 and flag the new error -20 for the case when the attribute type
27657 does not have valid targets specified. csc does not catch this.
27659 * ../errors/errors.txt : update for error # -20
27661 2002-04-11 Ravi Pratap <ravi@ximian.com>
27663 * support.cs (InternalParameters.ParameterModifier): Do some null
27664 checking and return sane values.
27666 * class.cs (Method.Define): If we are a PInvoke method, ensure
27667 that we are static and extern. Report error # 601
27669 * ../errors/cs0601.cs : Add test case for the above error.
27671 2002-04-07 Ravi Pratap <ravi@ximian.com>
27673 * rootcontext.cs (attribute_types): We need to keep type of
27674 all attribute types separately and emit code for them first.
27676 (RegisterAttribute) : Implement.
27678 * class.cs (DefineType): Check if the current Type is a custom
27679 attribute type and register it accordingly.
27681 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27682 adding the first attribute twice and rename to
27684 (SetGlobalAttributes): this.
27686 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27689 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27690 if we are processing global arguments. Hmm, I am unsure of this.
27692 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27694 * expression.cs: added static array of strings to avoid calling
27695 Enum.ToString () for Operator in Binary. Significant recover of
27698 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27700 * class.cs (FindMembers): Allow the Builders of the various
27701 members to be null. If they are skip them. This only happens
27702 during the PInvoke declaration.
27704 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27706 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27707 failure, so we do not keep going afterwards.
27709 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27710 wanted to pass `false' as the `is_delegate' argument. If this is
27711 the case, why not use delegate_type == null to mean `is_delegate =
27712 false' and anything else as is_delegate = true.
27714 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27716 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27717 code for the section, not the beginning of the tests.
27719 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27721 * cfold.cs: Handle operator + (Enum x, Underlying x)
27723 * expression.cs (Binary): same. Warn about errors where we have
27724 Enum/Enum in operator + as well.
27726 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27729 - added support for switch(bool)
27730 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27731 - add TableSwitchEmit() to handle table-based switch statements
27733 2002-04-05 Ravi Pratap <ravi@ximian.com>
27735 * expression.cs (Invocation.OverloadResolve): Factor out code which
27736 does parameter compatibility checking with arguments so that we can
27737 re-use the code even from Delegate.VerifyApplicability
27739 (VerifyArgumentsCompat): Move above code here.
27741 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27742 and instead make a call to the above method.
27744 2002-03-31 Ravi Pratap <ravi@ximian.com>
27746 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27747 We use it to keep track of classes which are attribute types.
27749 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27751 * delegate.cs (Delegate.Define): Correctly define the types in the
27752 presence of fixed and array parameters.
27754 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27757 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27758 include NonPublic after the first iteration.
27760 * class.cs (Indexer.CheckBase): Only check if both parents are
27763 * cs-parser.jay (accessor_body): If empty, set to null.
27765 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27766 same code path here to resolve constants names that we did have in
27767 MemberAccess.DoResolve. There is too much code duplicated here.
27769 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27771 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27773 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27776 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27777 tokens, numbers and strings.
27779 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27782 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27783 asyncronous parameters and the regular parameters.
27785 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27786 specify the target directory.
27788 * expression.cs: (This.DoResolve): Simplify
27789 (As.Emit): Optimize, do not generate IsInst if the expression is
27790 always of the given type.
27792 (Is.DoResolve): Bug fix, we were reporting both always/never for
27795 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27796 creating too many unnecessary arrays.
27798 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27800 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27801 fields instead of rolling our own initializer. Takes care of all
27802 implicit conversions, and drops unnecessary static checks/argument.
27804 2002-03-31 Dick Porter <dick@ximian.com>
27806 * driver.cs: use the GetDirectories() return values properly, and
27807 use "/" as path separator.
27809 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27811 * expression.cs (Unary): Optimize - - expr into expr.
27812 (Binary): Optimize a + (-b) into a -b.
27814 * codegen.cs (CodeGen): Made all methods static.
27816 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27820 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27821 TypeBuilder property.
27823 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27826 * tree.cs: Removed the various RecordXXXX, and replaced with a
27827 single RecordDecl. Removed all the accessor methods, and just
27828 left a single access point Type
27830 * enum.cs: Rename DefineEnum to DefineType.
27832 * decl.cs: New abstract method `DefineType' used to unify the
27833 Defines for Enumerations, Interfaces, TypeContainers and
27836 (FindType): Moved LookupInterfaceOrClass here. Moved the
27837 LookupBaseClasses method that used to live in class.cs and
27838 interface.cs here, and renamed to FindType.
27840 * delegate.cs: Implement DefineType. Take advantage of the
27841 refactored pattern for locating the parent builder without taking
27842 the parent_builder argument (which we know does not work if we are
27843 nested, and triggering a toplevel definition).
27845 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27847 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27848 accessibility of a member has changed during override and report
27851 * class.cs (Method.Define, Property.Define): Only complain on
27852 overrides if the method is private, any other accessibility is
27853 fine (and since we just checked the permission is the same, we are
27856 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27857 and elif are processed always. The other pre-processing
27858 directives are only processed if we are "taking" the path
27860 2002-03-29 Martin Baulig <martin@gnome.org>
27862 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27863 current location is not Null.
27865 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27866 a separate method so we can profile it.
27868 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27869 `span.Seconds' are just seconds, but no minutes or hours.
27870 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27872 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27874 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27875 Remove the gratuitous set of Final:
27877 // If an interface implementation, then we can set Final.
27878 if (((flags & MethodAttributes.Abstract) == 0) &&
27879 implementing.DeclaringType.IsInterface)
27880 flags |= MethodAttributes.Final;
27882 I do not know what I was smoking when I used that.
27885 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27886 step into fixing the name resolution issues for delegates and
27887 unifying the toplevel name resolution.
27889 2002-03-28 Martin Baulig <martin@gnome.org>
27891 * class.cs (Method.Emit): If we have a symbol writer, call its
27892 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27893 tell it about the current method.
27895 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27896 writer that we're going to emit the first byte of IL code for a new
27897 statement (a new source line).
27898 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27899 EmitContext.Mark() before emitting any code.
27901 * location.cs (SymbolDocument): Return null when we're Null.
27903 * statement.cs (Statement): Moved the `Location loc' variable here.
27904 (Statement.EmitBoolExpression): If we have a symbol writer, call
27905 ec.Mark() before emitting any code to tell it that we're at the
27906 beginning of a new statement.
27907 (StatementExpression): Added `Location' argument to the constructor.
27908 (Block): Added public readonly variable `StartLocation' and public
27909 variable `EndLocation'. The latter is to be set using SetEndLocation().
27910 (Block): Added constructor which takes a start and end location.
27911 (Block.SetEndLocation): New method. This sets the end location.
27912 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27913 local variables we create.
27914 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27915 each statement and do also mark the begin and end of the block.
27917 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27918 tell it the current lexer.Location, use Location.Null for the end of the
27920 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27921 current block, set its end location using SetEndLocation().
27922 (statement_expression): StatementExpression constructor now takes the
27923 lexer.Location as additional argument.
27924 (for_statement, declare_local_variables): Likewise.
27925 (declare_local_variables): When creating a new implicit block, use the
27926 new Block constructor and pass it the lexer.Location.
27928 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27930 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27931 members also on the parent interfaces recursively.
27933 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27935 * report.cs: Use new formats, since Gonzalo finished the missing
27938 * expression.cs (Binary.ResolveOperator): added missing operator|
27939 operator& and operator^ for bool/bool.
27941 * cs-parser.jay: CheckDef now takes a Location argument that is
27942 used to report errors more precisly (instead of reporting the end
27943 of a definition, we try to track something which is a lot closer
27944 to the source of the problem).
27946 * cs-tokenizer.cs: Track global token use, so we can properly flag
27947 the use of #define/#undef after the first token has been seen.
27949 Also, rename the reportXXXX to Error_DescriptiveName
27951 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27952 TypeContainer, so that Enum and Interface can use this too.
27954 * class.cs (TypeContainer.LookupInterfaceOrClass,
27955 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27956 `builder' argument. Typically this was used to pass the parent
27957 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27960 The problem is that a nested class could trigger the definition of
27961 a toplevel class, and the builder would be obviously wrong in that
27964 So we drop this argument, and we compute dynamically the
27965 TypeBuilder/ModuleBuilder (the correct information was available
27966 to us anyways from DeclSpace.Parent)
27968 * interface.cs (Interface.DefineInterface): Drop builder
27969 parameter cleanup like class.cs
27971 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27974 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27977 (Try.Emit): Propagate the returns value from the statement.
27979 (Return.Emit): Even if we are leavning
27981 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27983 * modifiers.cs: Fix the computation of MethodAttributes flags.
27985 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27987 * driver.cs: allow compilation of files that start with '/'.
27988 Add a default case when checking the argument of --target.
27990 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27992 * interface.cs: Implement the same search algorithm for types in
27993 the interface code.
27995 * delegate.cs: Do not allow multiple definition.
27997 * Recovered ChangeLog that got accidentally amputated
27999 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28001 * rootcontext.cs: Load manually enum to allow core classes to
28002 contain enumerations.
28004 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28005 Update to new static methods in TypeManager.
28007 * typemanager.cs (GetMethod, GetConstructor): Use our
28008 implementation of FindMembers to find the members, since during
28009 corlib compilation, the types are TypeBuilders and GetMethod and
28010 GetConstructor do not work.
28012 Make all methods in TypeManager static.
28014 (InitCodeHelpers): Split the functionality from
28015 the InitCodeTypes function.
28017 * driver.cs: Call InitCodeHelpers after we have populated the
28020 * cs-parser.jay (delegate_declaration): we did not used to compute
28021 the delegate name correctly for void delegates.
28023 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28025 * rootcontext.cs (RootContext): Init the interface_resolve_order
28026 and type_container_resolve_order always.
28028 (ResolveCore, BootstrapCorlib_ResolveClass,
28029 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28030 compiler when compiling with --nostdlib
28032 * class.cs (TypeContainer.DefineType): Check that our parent is
28033 not null. This test is most important when we are bootstraping
28036 * codegen.cs: Split out the symbol writing code.
28038 2002-03-25 Martin Baulig <martin@gnome.org>
28040 * driver.cs (-g): Made -g an alias for --debug.
28042 2002-03-24 Martin Baulig <martin@gnome.org>
28044 * codegen.cs (SymbolWriter): New public variable. Returns the
28045 current symbol writer.
28046 (CodeGen): Added `bool want_debugging_support' argument to the
28047 constructor. If true, tell the ModuleBuild that we want debugging
28048 support and ask it for the ISymbolWriter.
28049 (Save): If we have a symbol writer, call it's Close() method after
28050 saving the assembly.
28052 * driver.c (--debug): New command line argument to create a
28053 debugger information file.
28055 * location.cs (SymbolDocument): New public property. Returns an
28056 ISymbolDocumentWriter object for the current source file or null
28057 if we don't have a symbol writer.
28059 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28061 * driver.cs (LoadAssembly): Correctly return when all the paths
28062 have been tried and not before.
28064 * statement.cs (Switch.Emit): return the actual coverage for this
28065 statement (returns/not-returns)
28067 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28068 switch of the statement if we are the last switch section. That
28069 kills two problems: try/catch problems (we used to emit an empty
28070 nop at the end) and switch statements where all branches would
28073 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28075 * driver.cs: Add default assemblies (the equivalent to the
28076 Microsoft CSC.RSP file)
28078 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28079 also update tokens_seen and set it to false.
28081 * driver.cs: Implement --recurse for Mike.
28083 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28084 correctly splitting out the paths.
28086 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28088 * interface.cs (Interface.PopulateProperty): Instead of using
28089 `parent' as the declaration space for the set parameters, use
28092 * support.cs (InternalParameters): InternalParameters constructor
28093 takes a DeclSpace instead of a TypeContainer.
28095 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28096 types are being initialized, load the address of it before calling
28099 (New): Provide a mechanism to disable the generation of local
28100 value type temporaries when the caller will be providing us with
28101 an address to store it.
28103 (ArrayCreation.EmitDynamicInitializers): Use it.
28105 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28107 * expression.cs (Invocation.EmitArguments): Only probe for array
28108 property if there is more than one argument. Sorry about that.
28110 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28111 empty param arrays.
28113 * class.cs (Method.LabelParameters): Fix incorrect code path that
28114 prevented the `ParamArrayAttribute' from being applied to the
28117 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28119 * support.cs (ReflectionParameters): Correctly compute whether the
28120 last argument is a params array. Fixes the problem with
28123 * typemanager.cs: Make the assemblies array always be non-null
28124 (empty, but non-null)
28126 * tree.cs (RecordDecl): New function that abstracts the recording
28127 of names. This reports error 101, and provides a pointer to the
28128 previous declaration. Fixes a crash in the compiler.
28130 * cs-parser.jay (constructor_declaration): Update to new grammar,
28131 and provide a constructor_body that can be empty.
28133 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28135 * driver.cs: Add support for --resources.
28137 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28138 Make all types for the various array helper methods be integer.
28140 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28141 CheckState to ConvCast.
28143 (ConvCast): Now it takes a `checked' state argument, to avoid
28144 depending on the emit context for the conversion, and just using
28145 the resolve time setting.
28147 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28148 instead of Invocation.EmitArguments. We do not emit the original
28149 arguments, instead we emit those which have been converted to
28150 unsigned int expressions.
28152 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28154 * codegen.cs: ditto.
28156 * expression.cs (LocalVariableReference): Drop the use of the
28157 Store function that depended on the variable index.
28159 * statement.cs (VariableInfo): Drop the `Idx' property from this
28160 class, as this is not taking into account the indexes for
28161 temporaries tat we generate during the execution, getting the
28164 * class.cs: First emit class initializers, then call the parent
28167 * expression.cs (Binary): Fix opcode emision.
28168 (UnaryMutator.EmitCode): Support checked code generation
28170 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28171 matches for events for both the Static and Instance scans,
28172 pointing to the same element. Fix that.
28174 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28176 * rootcontext.cs (ResolveTree): Always set the
28177 interface_resolve_order, because nested interfaces will be calling
28180 * class.cs (GetInterfaceOrClass): Track the same resolution
28181 process used by TypeManager.LookupType. This fixes the nested
28182 type lookups in class declarations (separate path from
28185 (TypeContainer.DefineType): Also define nested interfaces.
28186 (TypeContainer.RegisterOrder): New public function used to
28187 register the order in which child interfaces need to be closed.
28189 Nested interfaces need to be closed after their parents have been
28192 * interface.cs (InterfaceAttr): Put all the logic for computing
28193 the interface attribute here.
28195 (DefineInterface): Register our interface order with the
28196 RootContext or with the TypeContainer depending on the case.
28198 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28200 * cs-parser.jay: rework foreach statement to work with the new
28201 changes to the policy on SimpleNames.
28203 * report.cs: support Stacktrace on warnings as well.
28205 * makefile: drop --unsafe and /unsafe from the compile.
28207 2002-03-13 Ravi Pratap <ravi@ximian.com>
28209 * ecore.cs (StandardConversionExists): Modify to take an Expression
28210 as the first parameter. Ensure we do null -> reference type conversion
28213 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28214 temporary Expression objects.
28216 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28218 * interface.cs: workaround bug in method overloading resolution
28219 (there is already a bugzilla bug for it).
28221 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28223 We could also solve this problem by having a separate path for
28224 performing type lookups, instead of DoResolve, we could have a
28225 ResolveType entry point, and only participating pieces of the
28226 production (simplename, deref, array) would implement this.
28228 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28229 signal SimpleName to only resolve type names and not attempt to
28230 resolve anything else.
28232 * expression.cs (Cast): Set the flag.
28234 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28236 * class.cs: Only report 108 if there is no `new' modifier.
28238 * cs-parser.jay: rework foreach statement to work with the new
28239 changes to the policy on SimpleNames.
28241 * report.cs: support Stacktrace on warnings as well.
28243 * makefile: drop --unsafe and /unsafe from the compile.
28245 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28247 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28248 lookups here, instead of doing that at parse time. This means
28249 that our grammar will not introduce `LocalVariableReferences' as
28250 expressions at this point. That solves the problem of code like
28254 static void Main ()
28258 This is only half the fix. The full fix requires parameters to
28259 also be handled in this way.
28261 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28262 makes the use more obvious of the DeclSpace. The
28263 ec.TypeContainer.TypeBuilder is now only used to pull the
28264 TypeBuilder for it.
28266 My theory is that I can get rid of the TypeBuilder completely from
28267 the EmitContext, and have typecasts where it is used (from
28268 DeclSpace to where it matters).
28270 The only pending problem is that the code that implements Aliases
28271 is on TypeContainer, and probably should go in DeclSpace.
28273 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28274 lookups here, instead of doing that at parse time. This means
28275 that our grammar will not introduce `LocalVariableReferences' as
28276 expressions at this point. That solves the problem of code like
28280 static void Main ()
28284 This is only half the fix. The full fix requires parameters to
28285 also be handled in this way.
28287 * class.cs (Property.DefineMethod): When implementing an interface
28288 method, set newslot, when implementing an abstract method, do not
28289 set the flag (before we tried never setting it, or always setting
28290 it, which is the difference).
28291 (Indexer.DefineMethod): same.
28292 (Method.DefineMethod): same.
28294 * ecore.cs: Only set the status used flag if we get back a Field.
28296 * attribute.cs: Temporary hack, so Paolo can keep working.
28298 2002-03-08 Ravi Pratap <ravi@ximian.com>
28300 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28301 the unmanaged type in the case we have a MarshalAs attribute.
28303 (Resolve): Handle the case when we are parsing the special MarshalAs
28304 attribute [we need to store the unmanaged type to use later]
28306 * typemanager.cs (marshal_as_attr_type): Built in type for the
28307 MarshalAs Attribute.
28309 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28310 on parameters and accordingly set the marshalling info.
28312 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28314 * class.cs: Optimizing slightly by removing redundant code after
28315 we switched to the `NoTypes' return value.
28316 (Property.DefineMethod): use NoTypes here too.
28318 This fixes the bug I introduced in my last batch of changes.
28320 2002-03-05 Ravi Pratap <ravi@ximian.com>
28322 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28324 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28325 Enums since those are types too.
28327 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28329 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28330 thanks to a call during the lookup process.
28332 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28334 * statement.cs (Foreach): Lots of work to accomodate a particular
28335 kind of foreach statement that I had not kept in mind. It is
28336 possible to have foreachs on classes that provide a GetEnumerator
28337 method that return objects that implement the "pattern" for using
28338 a foreach, there is no need to support GetEnumerator
28341 This is needed to compile nant.
28343 * decl.cs: Only report 114 if the member is not `Finalize' and if
28344 the warning level is at least 2.
28346 * class.cs: Moved the compare function from Method to
28349 (MethodSignature.InheritableMemberSignatureCompare): Add new
28350 filter function that is used to extract inheritable methods from a
28353 (Method.Define): Use the new `inheritable_method_signature_filter'
28356 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28359 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28361 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28363 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28365 * expression.cs: Pass location information to
28366 ConvertImplicitStandard.
28368 * class.cs: Added debugging code to track return values from
28371 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28373 * expression.cs (Is.DoResolve): If either side of the `is' is an
28374 interface, do not flag the warning.
28376 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28379 * report.cs: Allow for --fatal to be used with --probe.
28381 * typemanager.cs (NoTypes): Move the definition for the empty Type
28384 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28386 (TypeContainer.DefineProxy): New function used to proxy to parent
28387 implementations when implementing interfaces.
28388 (TypeContainer.ParentImplements): used to lookup if our parent
28389 implements a public function that is required by an interface.
28390 (TypeContainer.VerifyPendingMethods): Hook this up.
28392 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28393 `modules' and `assemblies' arraylists into arrays. We only grow
28394 these are the very early start up of the program, so this improves
28395 the speedof LookupType (nicely measured).
28397 * expression.cs (MakeByteBlob): Replaced unsafe code with
28398 BitConverter, as suggested by Paolo.
28400 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28401 folding of string concatenation, but if either side is a string,
28402 and the other is not, then return null, and let the runtime use
28403 the concatenation on the string plus the object (using
28404 `Object.ToString').
28406 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28408 Constant Folding has been implemented now.
28410 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28411 the error instead on types that are not supported in one's
28414 * constant.cs (Constant and all children): New set of functions to
28415 perform implict and explicit conversions.
28417 * ecore.cs (EnumConstant): Implement the new functions to perform
28418 conversion by proxying to the child expression.
28420 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28421 own separate setting that can not be turned off from the command
28422 line using --unchecked or --checked and is only controlled using
28423 the checked/unchecked statements and expressions. This setting is
28424 used by the constant folder to flag errors.
28426 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28427 ConstantCheckState as well.
28429 During Resolve, they also have to flag the state, because the
28430 constant folder runs completely in the Resolve phase.
28432 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28435 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28437 * cfold.cs: New file, this file contains the constant folder.
28439 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28440 argument to track whether we are using the resulting address to
28441 load or store a value and provide better error messages.
28443 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28444 new AddressOf arguments.
28446 * statement.cs (Foreach.EmitCollectionForeach): Update
28448 * expression.cs (Argument.Emit): Call AddressOf with proper
28449 arguments to track usage.
28451 (New.DoEmit): Call AddressOf with new arguments.
28453 (Unary.Emit): Adjust AddressOf call.
28455 2002-03-01 Ravi Pratap <ravi@ximian.com>
28457 * cs-parser.jay (member_access): Change the case for pre-defined types
28458 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28461 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28464 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28465 essentially like methods and apply attributes like MethodImplOptions to them too.
28467 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28470 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28471 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28474 * Update code everywhere accordingly.
28476 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28478 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28480 2002-02-28 Ravi Pratap <ravi@ximian.com>
28482 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28483 try performing lookups against those instead of jumping straight into using
28484 the 'using' clauses.
28486 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28488 (LookupType): Perform lookups in implicit parents too.
28490 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28491 sequence as RootContext.LookupType.
28493 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28494 the various cases of namespace lookups into this method.
28496 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28498 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28499 in positional arguments)
28501 * class.cs (Operator): Update the AllowedModifiers to contain
28504 * cs-parser.jay: Update operator declaration to allow for the
28505 operator body to be empty.
28507 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28510 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28512 * class.cs (Method.Emit): Label parameters.
28514 * driver.cs: Return 1 or 0 as the program exit code.
28516 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28518 * expression.cs: Special case the `null' object when trying to
28519 auto-compute the type, as anything can be explicitly converted to
28522 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28523 spotting this Paolo.
28525 (Expression.ImplicitNumericConversion): Perform comparissions of
28526 the type using the underlying type in the case of an enumeration
28527 rather than using the enumeration type for the compare.
28529 Cope with the underlying == type case, which is not possible to
28532 (Expression.ConvertNumericExplicit): Perform comparissions of
28533 the type using the underlying type in the case of an enumeration
28534 rather than using the enumeration type for the compare.
28536 * driver.cs: If the user does not supply an extension, assume .exe
28538 * cs-parser.jay (if_statement): Rewrote so that we can track the
28539 location for the if statement.
28541 * expression.cs (Binary.ConstantFold): Only concat strings when
28542 the operation is "+", not everything ;-)
28544 * statement.cs (Statement.EmitBoolExpression): Take a location
28546 (If, While, Do): Track location.
28548 * expression.cs (Binary.ResolveOperator): In the object + string
28549 case, I was missing a call to ConvertImplicit
28551 2002-02-25 Ravi Pratap <ravi@ximian.com>
28553 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28554 Location arguments. Ensure we use RootContext.LookupType to do our work
28555 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28557 * interface.cs (PopulateMethod): Handle the type of the parameter being
28560 * expression.cs (Invocation.BetterFunction): Handle the case when we
28561 have a params method with no fixed arguments and a call is made with no
28564 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28566 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28567 the verbatim-string-literal
28569 * support.cs (InternalParameters.ParameterModifier): handle null
28571 (InternalParameters.ParameterType): ditto.
28573 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28574 duplicating the name of the variable parameter.
28575 (GetParameterByName): Fix bug where we were not looking up array
28576 paramters if they were the only present (thanks Paolo!).
28577 (GetParameterInfo): We only have an empty set of types if both
28578 fixed and array are set to null.
28579 (GetParameterInfo-idx): Handle FixedParameter == null
28581 * cs-parser.jay: Handle the case where there is no catch
28582 statements (missing null test).
28584 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28586 * driver.cs (MainDriver): Be conservative on our command line
28589 Catch DirectoryNotFoundException when calling GetFiles.
28591 (SplitPathAndPattern): Used to split the input specification into
28592 a path and a pattern that we can feed to Directory.GetFiles.
28594 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28596 * statement.cs (Fixed): Implement the last case of the Fixed
28597 statement (string handling).
28599 * expression.cs (StringPtr): New class used to return a char * to
28600 a string; Used by the Fixed statement.
28602 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28604 * expression.cs (Binary.ResolveOperator): Remove redundant
28605 MemberLookup pn parent type.
28606 Optimize union call, we do not need a union if the types are the same.
28607 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28610 Specialize the use of MemberLookup everywhere, instead of using
28611 the default settings.
28613 (StackAlloc): Implement stackalloc keyword.
28615 * cs-parser.jay: Add rule to parse stackalloc.
28617 * driver.cs: Handle /h, /help, /?
28619 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28620 before we supported unsafe code.
28622 * makefile: add --unsafe to the self compilation of mcs.
28624 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28626 * expression.cs (PointerArithmetic): New class that is used to
28627 perform pointer arithmetic.
28628 (Binary.Resolve): Handle pointer arithmetic
28629 Handle pointer comparission.
28630 (ArrayPtr): Utility expression class that is used to take the
28631 address of an array.
28633 (ElementAccess): Implement array access for pointers
28635 * statement.cs (Fixed): Implement fixed statement for arrays, we
28636 are missing one more case before we are done.
28638 * expression.cs (Indirection): Implement EmitAssign and set the
28639 ExprClass to Variable. This allows pointer dereferences to be
28640 treated as variables, and to have values assigned to them.
28642 * ecore.cs (Expression.StoreFromPtr): New utility function to
28643 store values dereferencing.
28645 2002-02-20 Ravi Pratap <ravi@ximian.com>
28647 * expression.cs (Binary.ResolveOperator): Ensure that we are
28648 not trying to operate on a void type - this fixes the reported
28651 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28652 the parent implementation is sealed.
28654 * ../errors/cs0239.cs : Add.
28656 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28658 * typemanager.cs (unverifiable_code_type): Corresponds to
28659 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28660 which have unsafe code in them.
28662 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28665 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28667 * cs-tokenizer.cs: Add support for @"litreal strings"
28669 Make tokenizer accept pre-processor directives
28670 on any column (remove the old C-like limitation).
28672 * rootcontext.cs (EmitCode): Emit any global attributes.
28673 (AddGlobalAttributes): Used to keep track of assembly attributes.
28675 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28677 * cs-parser.jay: Add support for global attributes.
28679 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28681 * expression.cs (Indirection): New helper class. Unary will
28682 create Indirection classes to be able to implement the
28683 IMemoryLocation interface on it.
28685 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28687 * cs-parser.jay (fixed_statement): reference the right statement.
28689 * statement.cs (Fixed.Emit): Finish implementing the fixed
28690 statement for the &x case.
28692 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28694 * class.cs (Property.Define, Method.Define): Remove newslot when
28697 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28698 wrong. NewSlot should only be used if the `new' keyword is present.
28700 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28701 locating our system dir. Sorry about this.
28703 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28705 * driver.cs (GetSystemDir): Compute correctly the location of our
28706 system assemblies. I was using the compiler directory instead of
28707 the library directory.
28709 2002-02-13 Ravi Pratap <ravi@ximian.com>
28711 * expression.cs (BetterFunction): Put back in what Miguel commented out
28712 since it is the correct fix. The problem is elsewhere ;-)
28714 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28715 parameters of the parms method are themselves compatible or not !
28717 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28718 to check that a class implements an interface before saying that an implicit
28719 conversion was allowed. Use ImplementsInterface to do the checking.
28721 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28723 * class.cs (Method.Define): Track whether we are an explicit
28724 implementation or not. And only call DefineMethodOverride if we
28725 are an explicit implementation.
28727 (Property.DefineMethod): Ditto.
28729 2002-02-11 Ravi Pratap <ravi@ximian.com>
28731 * expression.cs (BetterFunction): Catch hideous bug which was
28732 preventing us from detecting ambiguous calls due to implicit casts i.e
28735 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28737 * support.cs (Pair): Remove un-needed method. I figured why I was
28738 getting the error in cs-parser.jay, the variable in a foreach loop
28739 is readonly, and the compiler does not really treat this as a variable.
28741 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28742 instead of EQUALS in grammar.
28744 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28746 * expression.cs (Unary.DoResolve): Check whether the argument is
28749 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28751 * support.cs: Api for Pair to set a value. Despite the fact that
28752 the variables are public the MS C# compiler refuses to compile
28753 code that accesses the field if the variable is part of a foreach
28756 * statement.cs (Fixed): Begin implementation of the fixed
28759 (Block.AddVariable): Return the VariableInfo on success and null
28760 on failure instead of true/false.
28762 * cs-parser.jay (foreach): Catch errors on variables already
28763 defined (we were ignoring this value before) and properly unwind
28764 the block hierarchy
28766 (fixed_statement): grammar for the fixed statement.
28768 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28770 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28771 pointer types to be incretemented.
28773 (SizeOf): Implement.
28775 * cs-parser.jay (pointer_member_access): Implement
28776 expr->IDENTIFIER production.
28778 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28779 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28782 (Unary): Implement indirection.
28784 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28785 use in non-unsafe context).
28787 (SimpleName.DoResolve): Check for pointers in field access on safe
28790 (Expression.LoadFromPtr): Factor the load-indirect code in this
28791 function. This was duplicated in UnboxCast and ParameterReference
28793 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28795 * expression.cs (ComposedCast): report an error if a pointer cast
28796 is used in a safe region.
28798 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28799 pointer type casts in unsafe context.
28801 * codegen.cs (EmitContext): Set up IsUnsafe.
28803 * cs-parser.jay (non_expression_type): Add productions for pointer
28806 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28807 code. We should not use force into static mode if the method is
28808 not virtual. Fixes bug in MIS
28810 * statement.cs (Do.Emit, While.Emit, For.Emit,
28811 Statement.EmitBoolExpression): Add support to Do and While to
28812 propagate infinite loop as `I do return' semantics.
28814 Improve the For case to also test for boolean constants.
28816 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28817 to the list of attributes we can add.
28819 Remove `EmitContext' argument.
28821 * class.cs (Method.Define): Apply parameter attributes.
28822 (Constructor.Define): Apply parameter attributes.
28823 (MethodCore.LabelParameters): Move here the core of labeling
28826 * support.cs (ReflectionParameters.ParameterModifier,
28827 InternalParameters.ParameterModifier): Use IsByRef on the type and
28828 only return the OUT bit for these parameters instead of in/out/ref
28831 This is because I miss-understood things. The ParameterInfo.IsIn
28832 and IsOut represent whether the parameter has the [In] and [Out]
28835 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28837 * ecore.cs (FieldExpr.Emit): Release temporaries.
28839 * assign.cs (LocalTemporary.Release): new function.
28841 * codegen.cs (EmitContext.GetTemporaryStorage,
28842 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28843 temporary storage. Now we can "put back" localbuilders when we
28846 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28848 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28849 need to make a copy of the variable to generate verifiable code.
28851 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28853 * driver.cs: Compute dynamically the system directory.
28855 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28856 Slower, but more generally useful. Used by the abstract
28857 registering implementation.
28859 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28860 the rules for the special rule on Type/instances. First check if
28861 we have the same name, and if so, try that special static path
28862 rather than the instance path.
28864 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28866 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28869 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28870 Enum, ValueType, Delegate or Array for non-corlib compiles.
28872 * cs-tokenizer.cs: Catch long identifiers (645)
28874 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28877 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28878 fix, we were returning too early, so we were not registering
28879 pending methods from abstract classes.
28881 Do not register pending methods if the class is abstract.
28883 * expression.cs (Conditional.DoResolve): Report circular implicit
28884 conversions when we neecd to compute it for conditional
28887 (Is.DoResolve): If the expression is always of the provided type,
28888 flag warning 183. If the expression can not ever be of the
28889 provided type flag warning 184.
28891 * class.cs: Catch 169 as well.
28893 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28896 2002-01-18 Nick Drochak <ndrochak@gol.com>
28898 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28900 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28902 * interface.cs: (PopulateMethod): Check for pointers being defined
28903 only if the unsafe context is active.
28904 (PopulateProperty): ditto.
28905 (PopulateIndexer): ditto.
28907 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28908 specified. If pointers are present, make sure that they are
28909 present in an unsafe context.
28910 (Constructor, Constructor.Define): ditto.
28911 (Field, Field.Define): ditto.
28912 (Property, Property.Define): ditto.
28913 (Event, Event.Define): ditto.
28915 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28916 hashtable if there are classes or structs defined.
28918 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28919 code, as the constant resolution moved.
28921 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28922 the metadata, so we can flag error 133.
28924 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28925 pointer is being declared in an unsafe context.
28927 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28929 * modifiers.cs (Modifiers.Check): Require a Location argument.
28930 Report error 227 for Unsafe use.
28932 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28934 * statement.cs (For.Emit): If the test is null, then report that
28935 we do `return', as we wont reach anything afterwards.
28937 (Switch.SwitchGoverningType): Track the expression that matched
28940 * driver.cs: Allow negative numbers as an error code to flag.
28942 * cs-parser.jay: Handle 1551.
28944 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28946 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28948 * cs-parser.jay: Report 1518 (type declaration can only contain
28949 class, struct, interface, enum or delegate)
28951 (switch_label): Report 1523 (keywords `case' or `default' must
28954 (opt_switch_sections): Report 1522 (empty switch)
28956 * driver.cs: Report 1515 (response file specified multiple times)
28957 Report 1516 (Source file specified multiple times).
28959 * expression.cs (Argument.Resolve): Signal 1510
28961 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28962 access not allowed in static code)
28964 2002-01-11 Ravi Pratap <ravi@ximian.com>
28966 * typemanager.cs (IsPointerType): Utility method which we are going
28969 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28970 the object type, so we take care of that.
28972 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28974 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28975 added to non-params parameters :-)
28977 * typemanager.cs (CSharpName): Include 'void' type too.
28979 (void_ptr_type): Include in the set of core types.
28981 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28984 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28987 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28988 completely forgotten about it.
28990 2002-01-10 Ravi Pratap <ravi@ximian.com>
28992 * cs-parser.jay (pointer_type): Add. This begins our implementation
28993 of parsing rules for unsafe code.
28995 (unsafe_statement): Implement.
28997 (embedded_statement): Modify to include the above.
28999 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29001 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29002 if the current context is an unsafe one.
29004 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29005 are handled differently, we need separate rules for them.
29007 (local_variable_declaration): Update to use local_variable_pointer_type
29008 to allow variable declarations of unmanaged pointer types.
29010 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29011 in unsafe contexts.
29013 * ../errors/cs0214.cs : Add.
29015 2002-01-16 Nick Drochak <ndrochak@gol.com>
29017 * makefile: remove 'response' file when cleaning.
29019 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29021 * cs-parser.jay: Report 1524.
29023 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29025 * typemanager.cs (RegisterMethod): drop checking if we have
29026 registered this from here
29028 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29030 * class.cs (Method.EmitDestructor): Implement calling our base
29033 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29034 value of InFinally.
29036 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29037 this routine and will wrap the call in a try/catch block. Deal
29040 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29042 * ecore.cs (Expression.MemberLookup): instead of taking a
29043 parameter `same_type' that was used to tell whether we could
29044 access private members we compute our containing type from the
29047 (FieldExpr): Added partial support for volatile fields. This does
29048 not work for volatile fields exposed from assemblies, as I can not
29049 figure out how to extract the modreq from it.
29051 Updated all the source files to use this.
29053 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29054 because it is referenced by MemberLookup very often.
29056 2002-01-09 Ravi Pratap <ravi@ximian.com>
29058 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29059 TypeBuilder.GetCustomAttributes to retrieve what we need.
29061 Get rid of redundant default_member_attr_type as this is the same as
29062 default_member_type which already exists.
29064 * interface.cs, attribute.cs : Update accordingly.
29066 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29068 * typemanager.cs: Enable IndexerPropertyName again. It does not
29069 work for TYpeBuilders though. Ravi, can you please fix this?
29071 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29073 * expression.cs (Argument.Emit): Handle the case of ref objects
29074 being passed to ref functions;
29076 (ParameterReference.EmitLoad): Loads the content of the pointer
29077 without dereferencing.
29079 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29081 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29083 2002-01-08 Ravi Pratap <ravi@ximian.com>
29085 * class.cs (Indexer.DefineMethod): Incorporate the interface
29086 type in the name of the method if we are doing explicit interface
29089 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29091 (BetterConversion): Fix extremely trivial bug where we were referring to
29092 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29095 * ../errors/bug16.cs : Add although we have fixed it.
29097 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29099 * expression.cs (BaseIndexer): Begin implementation.
29101 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29103 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29104 production directly to remove a shift/reduce, and implement
29105 explicit interface implementation.
29107 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29108 after a floating point suffix.
29110 * expression.cs (DoNumericPromotions): Improved the conversion for
29111 uint/uint. If we have a constant, we avoid doing a typecast to a
29114 * class.cs (Indexer): Implement explicit interface implementation
29117 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29119 * class.cs: make the default instance constructor public and hidebysig.
29121 2001-01-03 Ravi Pratap <ravi@ximian.com>
29123 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29124 so we can call it from elsewhere.
29126 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29127 we emit it internally if the class has a defined indexer; otherwise the user
29128 emits it by decorating the class definition with the DefaultMemberAttribute.
29130 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29131 attribute is not used on a type which defines an indexer.
29133 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29134 character when we skip whitespace.
29136 * ../errors/cs0646.cs : Add.
29138 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29140 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29143 * makefile: Add practical target `mcs3.exe' which builds the third
29144 generation compiler.
29146 * expression.cs (New): Fix structures constructor calling.
29148 * class.cs (Property, Method, Indexer): Emit Final flag on the
29149 method if we are an interface implementation and we are not
29152 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29153 whether this property is referencing a `base' method.
29155 * expression.cs (Invocation.EmitCall): take an extra argument:
29156 is_base, this is used to determine whether the `call' or
29157 `callvirt' opcode should be used.
29160 * delegate.cs: update EmitCall.
29162 * class.cs (Method.Define): Set NewSlot for the cases where we are
29163 not implementing an interface method.
29165 (Property.Define): ditto.
29167 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29169 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29170 'r'. Allows mcs to parse itself fully.
29172 2002-01-02 Ravi Pratap <ravi@ximian.com>
29174 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29175 of the number of initializers that require the InitializeArray method.
29177 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29178 update the above field where necessary.
29180 (MakeByteBlob): Update accordingly.
29182 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29185 (EmitDynamicInitializers): Update in accordance with the new optimization.
29187 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29188 same OpCode applies.
29190 * cs-parser.jay : Fix some glaring errors I introduced.
29192 2002-01-01 Ravi Pratap <ravi@ximian.com>
29194 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29195 so that we can check for name clashes there too.
29197 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29198 for interface indexers.
29200 * interfaces.cs (Define): Emit the default member attribute.
29202 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29203 variable was being referred to while setting the value ;-)
29205 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29207 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29208 byte-by-byte information when we know the data is zero.
29210 Make the block always a multiple of 4, because
29211 DefineInitializedData has a bug.
29213 * assign.cs: Fix, we should assign from the temporary, not from
29216 * expression.cs (MakeByteBlob): Fix my incorrect code.
29218 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29220 * typemanager.cs (EnumToUnderlying): This function is used to get
29221 the underlying type from an enumeration, because it does not
29224 * constant.cs: Use the I4_S form for values between -128 and 127.
29226 * statement.cs (Block.LookupLabel): Looks up a label.
29227 (Block): Drop support for labeled blocks.
29229 (LabeledStatement): New kind of statement that represents a label
29232 (Goto): Finally implement this bad boy.
29234 * cs-parser.jay: Update to reflect new mechanism to implement
29237 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29239 * codegen.cs (EmitContext.This): a codegen property that keeps the
29240 a single instance of this instead of creating many different this
29243 * delegate.cs (Delegate.DoResolve): Update to use the property;
29245 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29247 * expression.cs (BaseAccess.DoResolve): Ditto.
29249 2001-12-29 Ravi Pratap <ravi@ximian.com>
29251 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29252 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29254 (InitCoreTypes): Update accordingly.
29256 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29257 so we can quickly store the state.
29259 (ApplyAttributes): Set the correct implementation flags
29260 for InternalCall methods.
29262 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29264 * expression.cs (EmitCall): if a method is not virtual, then do
29265 not use callvirt on it.
29267 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29268 user defined stuff) requires the use of stobj, which takes an
29269 address on the stack instead of an array and an index. So emit
29270 the Ldelema operation for it.
29272 (EmitStoreOpcode): Use stobj for valuetypes.
29274 (UnaryMutator.EmitCode): Use the right 1 value depending on
29275 whether we are dealing with int64/uint64, float or doubles.
29277 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29278 constructors that I implemented last night.
29280 (Constructor.IsDefault): Fix to work properly for static
29283 * cs-parser.jay (CheckDef): report method signature errors.
29284 Update error number 103 to be 132.
29286 * decl.cs: New AdditionResult enumeration value: MethodExists.
29287 Although we do this check for methods later on in the semantic
29288 analysis, catching repeated default constructors is so easy that
29289 we catch these here.
29291 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29294 (ParameterReference.EmitAssign, Emit): handle
29297 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29298 (ArrayAccess.EmitStoreOpcode): ditto.
29300 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29302 * expression.cs (MakeByteBlob): Complete all the missing types
29303 (uint, short, ushort, byte, sbyte)
29305 * class.cs: Only init instance field initializers on instance
29308 Rename `constructors' to instance_constructors.
29310 (TypeContainer.AddConstructor): Only add constructors to the list
29311 if it is not static.
29313 Make sure that we handle default_static_constructor independently
29314 everywhere where we handle instance_constructors
29316 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29318 * class.cs: Do not lookup or create a base initializer for a
29319 static constructor.
29321 (ConstructorInitializer.Resolve): use the proper type to lookup
29324 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29326 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29329 * decl.cs: CloseType is now an virtual method, the default
29330 implementation just closes this type.
29332 2001-12-28 Ravi Pratap <ravi@ximian.com>
29334 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29335 to PreserveSig by default. Also emit HideBySig on such methods.
29337 Basically, set the defaults to standard values.
29339 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29340 argument, if candidate is better, it can't be worse than the best !
29342 (Invocation): Re-write bits to differentiate between methods being
29343 applicable in their expanded form and their normal form - for params
29346 Get rid of use_standard everywhere as only standard conversions are allowed
29347 in overload resolution.
29349 More spec conformance.
29351 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29353 * driver.cs: Add --timestamp, to see where the compiler spends
29356 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29357 `this' in static code.
29359 (SimpleName.DoResolve): Implement in terms of a helper function
29360 that allows static-references to be passed upstream to
29363 (Expression.ResolveWithSimpleName): Resolve specially simple
29364 names when called by MemberAccess to implement the special
29367 (Expression.ImplicitReferenceConversion): Handle conversions from
29368 Null to reference types before others, as Null's type is
29371 * expression.cs (Invocation.EmitCall): Handle the special case of
29372 calling methods declared on a reference type from a ValueType
29373 (Base classes System.Object and System.Enum)
29375 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29376 the left hand side is a TypeExpr, not on every enumeration.
29378 (Binary.Resolve): If types are reference types, then do a cast to
29379 object on operators != and == of both arguments.
29381 * typemanager.cs (FindMembers): Extract instance and static
29382 members if requested.
29384 * interface.cs (PopulateProperty): Use void_type instead of null
29385 as the return type for the setter method.
29387 (PopulateIndexer): ditto.
29389 2001-12-27 Ravi Pratap <ravi@ximian.com>
29391 * support.cs (ReflectionParameters): Fix minor bug where we
29392 were examining the wrong parameter for the ParamArray attribute.
29394 Cope with requests for the type of the parameter at position
29395 greater than the params parameter's. We now return the element
29396 type of the params array as that makes more sense.
29398 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29399 accordingly as we no longer have to extract the element type
29402 (Invocation.OverloadResolve): Update.
29404 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29406 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29407 against IEnumerator, test whether the return value is a descendant
29408 of the IEnumerator interface.
29410 * class.cs (Indexer.Define): Use an auxiliary method to implement
29411 the other bits of the method definition. Begin support for
29412 explicit interface implementation.
29414 (Property.DefineMethod): Use TypeManager.void_type instead of null
29415 for an empty return value.
29417 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29419 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29420 dealing with a FieldExpr which is composed of a FieldBuilder, in
29421 the code path we did extract the constant, but we should have
29422 obtained the underlying value to be able to cast it (otherwise we
29423 end up in an infinite loop, this is what Ravi was running into).
29425 (ArrayCreation.UpdateIndices): Arrays might be empty.
29427 (MemberAccess.ResolveMemberAccess): Add support for section
29428 14.5.4.1 that deals with the special case of E.I when E is a type
29429 and something else, that I can be a reference to a static member.
29431 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29432 handle a particular array type to create byte blobs, it is just
29433 something we dont generate byteblobs for.
29435 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29438 * location.cs (Push): remove the key from the hashtable that we
29439 are about to add. This happens for empty files.
29441 * driver.cs: Dispose files after we have parsed them.
29443 (tokenize): new function that only runs the tokenizer on its
29444 input, for speed testing.
29446 2001-12-26 Ravi Pratap <ravi@ximian.com>
29448 * class.cs (Event.Define): Define the private field only if there
29449 are no accessors defined.
29451 * expression.cs (ResolveMemberAccess): If there is no associated
29452 field with the event, that means we have an event defined with its
29453 own accessors and we should flag error cs0070 since transforming
29454 ourselves into a field is not valid in that case.
29456 * ecore.cs (SimpleName.DoResolve): Same as above.
29458 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29459 and charset to sane values.
29461 2001-12-25 Ravi Pratap <ravi@ximian.com>
29463 * assign.cs (DoResolve): Perform check on events only if they
29464 are being accessed outside the declaring type.
29466 * cs-parser.jay (event_declarations): Update rules to correctly
29467 set the type of the implicit parameter etc.
29469 (add_accessor, remove_accessor): Set current local parameters.
29471 * expression.cs (Binary): For delegate addition and subtraction,
29472 cast the return value from the method into the appropriate delegate
29475 2001-12-24 Ravi Pratap <ravi@ximian.com>
29477 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29478 of these as the workaround is unnecessary.
29480 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29481 delegate data - none of that is needed at all.
29483 Re-write bits to extract the instance expression and the delegate method
29486 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29489 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29490 of attaching attributes instead of duplicating code everywhere.
29492 * everywhere : Update code to do attribute emission using the above method.
29494 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29496 * expression.cs (IsParamsMethodApplicable): if there are not
29497 parameters, return immediately.
29499 * ecore.cs: The 0 literal can be implicity converted to an enum
29502 (SimpleName.DoResolve): First lookup the type, then lookup the
29505 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29506 want to get its address. If the InstanceExpression is not
29507 addressable, store the result in a temporary variable, then get
29510 * codegen.cs: Only display 219 errors on warning level or above.
29512 * expression.cs (ArrayAccess): Make it implement the
29513 IMemoryLocation interface.
29515 (Binary.DoResolve): handle the operator == (object a, object b)
29516 and operator != (object a, object b) without incurring into a
29517 BoxedCast (because 5 != o should never be performed).
29519 Handle binary enumerator operators.
29521 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29522 value type, otherwise use Ldelem_ref.
29524 Use precomputed names;
29526 (AddressOf): Implement address of
29528 * cs-parser.jay (labeled_statement): Fix recursive block
29529 addition by reworking the production.
29531 * expression.cs (New.DoEmit): New has a special case:
29533 If we are dealing with a ValueType, we have a few
29534 situations to deal with:
29536 * The target of New is a ValueType variable, that is
29537 easy, we just pass this as the variable reference
29539 * The target of New is being passed as an argument,
29540 to a boxing operation or a function that takes a
29543 In this case, we need to create a temporary variable
29544 that is the argument of New.
29547 2001-12-23 Ravi Pratap <ravi@ximian.com>
29549 * rootcontext.cs (LookupType): Check that current_type is not null before
29550 going about looking at nested types.
29552 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29553 not implement the IAssignMethod interface any more.
29555 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29556 where we tranform them into FieldExprs if they are being resolved from within
29557 the declaring type.
29559 * ecore.cs (SimpleName.DoResolve): Do the same here.
29561 * assign.cs (DoResolve, Emit): Clean up code considerably.
29563 * ../errors/bug10.cs : Add.
29565 * ../errors/cs0070.cs : Add.
29567 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29569 * assign.cs : Get rid of EventIsLocal everywhere.
29571 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29573 * ecore.cs (ConvertIntLiteral): finished the implementation.
29575 * statement.cs (SwitchLabel): Convert the value we are using as a
29576 key before looking up the table.
29578 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29580 * codegen.cs (EmitTopBlock): Require a Location argument now.
29582 * cs-parser.jay (constructor_declarator): We need to setup
29583 current_local_parameters before we parse the
29584 opt_constructor_initializer, to allow the variables to be bound
29585 to the constructor arguments.
29587 * rootcontext.cs (LookupType): First lookup nested classes in our
29588 class and our parents before we go looking outside our class.
29590 * expression.cs (ConstantFold): Extract/debox the values at the
29593 * rootcontext.cs (EmitCode): Resolve the constants first before we
29594 resolve the types. This is not really needed, but it helps debugging.
29596 * statement.cs: report location.
29598 * cs-parser.jay: pass location to throw statement.
29600 * driver.cs: Small bug fix.
29602 * report.cs: Updated format to be 4-zero filled digits.
29604 2001-12-22 Ravi Pratap <ravi@ximian.com>
29606 * expression.cs (CheckIndices): Fix minor bug where the wrong
29607 variable was being referred to ;-)
29609 (DoEmit): Do not call EmitStaticInitializers when the
29610 underlying type is System.Object.
29612 2001-12-21 Ravi Pratap <ravi@ximian.com>
29614 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29615 and do the usual workaround for SRE.
29617 * class.cs (MyEventBuilder.EventType): New member to get at the type
29618 of the event, quickly.
29620 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29622 * assign.cs (Assign.DoResolve): Handle the case when the target
29623 is an EventExpr and perform the necessary checks.
29625 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29628 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29630 (EventExpr): Set the type in the constructor itself since we
29631 are meant to be born fully resolved.
29633 (EventExpr.Define): Revert code I wrote earlier.
29635 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29636 instance expression is null. The instance expression is a This in that case
29637 or a null, depending on whether it is a static method or not.
29639 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29640 refers to more than one method.
29642 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29643 and accordingly flag errors.
29645 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29647 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29649 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29651 * location.cs (ToString): Provide useful rutine.
29653 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29655 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29656 objects, return the actual integral boxed.
29658 * statement.cs (SwitchLabel): define an ILLabel for each
29661 (Switch.CheckSwitch): If the value is a Literal, extract
29662 the underlying literal.
29664 Also in the unused hashtable we had, add the SwitchLabel so we can
29665 quickly look this value up.
29667 * constant.cs: Implement a bunch of new constants. Rewrite
29668 Literal based on this. Made changes everywhere to adapt to this.
29670 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29671 dereferencing array only once, and also copes with enumrations.
29673 bytes are two bytes wide, not one.
29675 (Cast): Perform constant conversions.
29677 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29678 wrappers to the literals here.
29680 * expression.cs (DoNumericPromotions): long literals can converted
29681 to ulong implicity (this is taken care of elsewhere, but I was
29682 missing this spot).
29684 * ecore.cs (Expression.Literalize): Make the return type Literal,
29685 to improve type checking.
29687 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29689 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29691 * literal.cs: Revert code from ravi that checked the bounds. The
29692 bounds are sane by the definition of the type itself.
29694 * typemanager.cs: Fix implementation of ImplementsInterface. We
29695 need to actually look up in our parent hierarchy for interfaces
29698 * const.cs: Use the underlying type for enumerations
29700 * delegate.cs: Compute the basename for the delegate creation,
29701 that should fix the delegate test case, and restore the correct
29702 Type Lookup semantics in rootcontext
29704 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29705 referencing a nested type with the Reflection API is using the "+"
29708 * cs-parser.jay: Do not require EOF token at the end.
29710 2001-12-20 Ravi Pratap <ravi@ximian.com>
29712 * rootcontext.cs (LookupType): Concatenate type names with
29713 a '.' instead of a '+' The test suite passes again.
29715 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29716 field of the enumeration.
29718 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29719 the case when the member is an EventExpr.
29721 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29722 static has an associated instance expression.
29724 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29726 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29728 * class.cs (Event.Define): Register event and perform appropriate checks
29731 We define the Add and Remove methods even if the use provides none because
29732 in that case, we provide default implementations ourselves.
29734 Define a private field of the type of the event. This is done by the CSC compiler
29735 and we should be doing it too ;-)
29737 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29738 More methods we use in code we generate.
29740 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29743 (InitCoreTypes): Update accordingly for the above.
29745 * class.cs (Event.Emit): Generate code for default accessors that we provide
29747 (EmitDefaultMethod): Do the job in the above.
29749 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29752 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29754 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29755 builders even if we were missing one.
29757 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29758 pass the Basename as our class name instead of the Name. The
29759 basename will be correctly composed for us.
29761 * parameter.cs (Paramters): Now takes a Location argument.
29763 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29764 make all the code call directly LookupType in RootContext and take
29765 this chance to pass the Location information everywhere.
29767 * Everywhere: pass Location information.
29769 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29771 * class.cs (Constructor.Define): Updated way of detecting the
29772 length of the parameters.
29774 (TypeContainer.DefineType): Use basename as the type name for
29777 (TypeContainer.Define): Do not recursively define types here, as
29778 definition is taken care in order by the RootContext.
29780 * tree.cs: Keep track of namespaces in a per-file basis.
29782 * parameter.cs (Parameter.ComputeSignature): Update to use
29785 (Parameters.GetSignature): ditto.
29787 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29788 instead of a TypeContainer.
29790 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29791 resolve names. Because we need to be resolve in our context, not
29794 * driver.cs: Implement response files.
29796 * class.cs (TypeContainer.DefineType): If we are defined, do not
29797 redefine ourselves.
29799 (Event.Emit): Emit the code for add/remove handlers.
29800 (Event.Define): Save the MethodBuilders for add/remove.
29802 * typemanager.cs: Use pair here too.
29804 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29805 DictionaryEntry requires the first argument to be non-null.
29807 (enum_declaration): Compute full name for registering the
29810 (delegate_declaration): Instead of using
29811 formal_parameter_list, use opt_formal_parameter_list as the list
29814 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29815 (EventParsing): New property that controls whether `add' and
29816 `remove' are returned as tokens or identifiers (for events);
29818 2001-12-19 Ravi Pratap <ravi@ximian.com>
29820 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29821 use MyEventBuilder only and let it wrap the real builder for us.
29823 (MyEventBuilder): Revamp constructor etc.
29825 Implement all operations that we perform on EventBuilder in precisely the same
29828 (FindMembers): Update to use the EventBuilder member.
29830 (Event.Emit): Update accordingly.
29832 2001-12-18 Ravi Pratap <ravi@ximian.com>
29834 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29835 by calling the appropriate methods.
29837 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29840 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29842 2001-12-17 Ravi Pratap <ravi@ximian.com>
29844 * delegate.cs (Delegate.Populate): Check that the return type
29845 and various parameters types are indeed accessible.
29847 * class.cs (Constructor.Define): Same here.
29849 (Field.Define): Ditto.
29851 (Event.Define): Ditto.
29853 (Operator.Define): Check that the underlying Method defined itself
29854 correctly - so it's MethodBuilder should not be null.
29856 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29857 expression happens to be null.
29859 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29860 members but as of now we don't seem to be able to do anything really useful with it.
29862 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29863 not the EventBuilder.
29865 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29867 * cs-tokenizer.cs: Add support for defines.
29868 Add support for #if, #elif, #else, #endif
29870 (eval_var): evaluates a variable.
29871 (eval): stubbed for evaluating functions.
29873 * cs-parser.jay: Pass the defines information
29875 * driver.cs: Add --define command line option.
29877 * decl.cs: Move MemberCore here.
29879 Make it the base class for DeclSpace. This allows us to catch and
29880 report 108 and 109 for everything now.
29882 * class.cs (TypeContainer.Define): Extract all the members
29883 before populating and emit the warning 108 (new keyword required
29884 to override) instead of having each member implement this.
29886 (MemberCore.Define): New abstract method, we will be using this in
29887 the warning reporting engine in Populate.
29889 (Operator.Define): Adjust to new MemberCore protocol.
29891 * const.cs (Const): This does not derive from Expression, it is a
29892 temporary object we use to create fields, it is a MemberCore.
29894 * class.cs (Method.Define): Allow the entry point to be in a
29897 * driver.cs: Rewrite the argument handler to clean it up a bit.
29899 * rootcontext.cs: Made it just an auxiliary namespace feature by
29900 making everything static.
29902 * driver.cs: Adapt code to use RootContext type name instead of
29905 * delegate.cs: Remove RootContext argument.
29907 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29910 * class.cs (Event.Define): The lookup can fail.
29912 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29914 * expression.cs: Resolve the this instance before invoking the code.
29916 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29918 * cs-parser.jay: Add a production in element_access that allows
29919 the thing to become a "type" reference. This way we can parse
29920 things like "(string [])" as a type.
29922 Note that this still does not handle the more complex rules of
29926 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29928 * ecore.cs: (CopyNewMethods): new utility function used to
29929 assemble the list of methods from running FindMembers.
29931 (MemberLookup): Rework FindMembers so that
29933 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29935 * class.cs (TypeContainer): Remove Delegates who fail to be
29938 * delegate.cs (Populate): Verify that we dont get null return
29939 values. TODO: Check for AsAccessible.
29941 * cs-parser.jay: Use basename to emit error 574 (destructor should
29942 have the same name as container class), not the full name.
29944 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29945 possible representation.
29947 Also implements integer type suffixes U and L.
29949 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29951 * expression.cs (ArrayCreation.DoResolve): We need to do the
29952 argument resolution *always*.
29954 * decl.cs: Make this hold the namespace. Hold the root context as
29956 (LookupType): Move here.
29958 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29960 * location.cs (Row, Name): Fixed the code, it was always returning
29961 references to the first file.
29963 * interface.cs: Register properties defined through interfaces.
29965 * driver.cs: Add support for globbing on the command line
29967 * class.cs (Field): Make it derive from MemberCore as well.
29970 2001-12-15 Ravi Pratap <ravi@ximian.com>
29972 * class.cs (Event::Define): Check that the type of the event is a delegate
29973 type else flag error #66.
29975 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29978 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29979 values of EntryPoint, CharSet etc etc.
29981 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29983 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29984 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29985 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29986 which needs this to do its work.
29988 * ../errors/cs0066.cs : Add.
29990 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29992 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29995 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29996 clears out the parameters field.
29997 (MemberSignatureCompare): Cleanup
29999 (MemberCore): New base class used to share code between MethodCore
30002 (RegisterRequiredImplementations) BindingFlags.Public requires
30003 either BindingFlags.Instace or Static. Use instance here.
30005 (Property): Refactored code to cope better with the full spec.
30007 * parameter.cs (GetParameterInfo): Return an empty array instead
30010 * class.cs (Property): Abstract or extern properties have no bodies.
30012 * parameter.cs (GetParameterInfo): return a zero-sized array.
30014 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30015 method modifier validation to the typecontainer so we can reuse
30016 this on properties.
30018 (MethodCore.ParameterTypes): return an empty sized array of types.
30020 (Property.Define): Test property modifier validity.
30022 Add tests for sealed/override too.
30024 (Method.Emit): abstract or extern methods have no bodies.
30026 2001-12-14 Ravi Pratap <ravi@ximian.com>
30028 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30031 (Method::Define, ::Emit): Modify accordingly.
30033 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30035 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30037 * makefile: Pass in /unsafe.
30039 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30041 * class.cs (MakeKey): Kill routine.
30043 * class.cs (TypeContainer.Define): Correctly define explicit
30044 method implementations (they require the full interface name plus
30047 * typemanager.cs: Deply the PtrHashtable here and stop using the
30048 lame keys. Things work so much better.
30050 This of course broke everyone who depended on `RegisterMethod' to
30051 do the `test for existance' test. This has to be done elsewhere.
30053 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30054 the object stupid Equals method (because, that like fails all over
30055 the place). We still do not use it.
30057 * class.cs (TypeContainer.SetRequiredInterface,
30058 TypeContainer.RequireMethods): Killed these two routines and moved
30059 all the functionality to RegisterRequiredImplementations.
30061 (TypeContainer.RegisterRequiredImplementations): This routine now
30062 registers all the implementations required in an array for the
30063 interfaces and abstract methods. We use an array of structures
30064 which can be computed ahead of time to reduce memory usage and we
30065 also assume that lookups are cheap as most classes will not
30066 implement too many interfaces.
30068 We also avoid creating too many MethodSignatures.
30070 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30071 clear the "pending" bit if we find that there are problems with
30074 (TypeContainer.VerifyPendingMethods): Update to report errors of
30075 methods that look like implementations but are not.
30077 (TypeContainer.Define): Add support for explicit interface method
30080 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30082 * typemanager.cs: Keep track of the parameters here instead of
30083 being a feature of the TypeContainer.
30085 * class.cs: Drop the registration of parameters here, as
30086 InterfaceMethods are also interface declarations.
30088 * delegate.cs: Register methods with the TypeManager not only with
30089 the TypeContainer. This code was buggy.
30091 * interface.cs: Full registation here.
30093 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30095 * expression.cs: Remove reducer for binary expressions, it can not
30098 * const.cs: Put here the code that used to go into constant.cs
30100 * constant.cs: Put here the code for constants, this is a new base
30101 class for Literals.
30103 * literal.cs: Make Literal derive from Constant.
30105 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30107 * statement.cs (Return.Emit): Report error 157 if the user
30108 attempts to return from a finally block.
30110 (Return.Emit): Instead of emitting a return, jump to the end of
30113 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30114 LocalBuilder to store the result of the function. ReturnLabel is
30115 the target where we jump.
30118 2001-12-09 Radek Doulik <rodo@ximian.com>
30120 * cs-parser.jay: remember alias in current namespace
30122 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30125 * class.cs (LookupAlias): lookup alias in my_namespace
30127 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30129 (LookupAlias): lookup alias in this and if needed in parent
30132 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30136 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30137 making things static. I need this to avoid passing the
30138 TypeContainer when calling ParameterType.
30140 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30141 that did string manipulation to compute the type and then call
30142 GetType. Use Parameter.ParameterType instead.
30144 * cs-tokenizer.cs: Consume the suffix for floating values.
30146 * expression.cs (ParameterReference): figure out whether this is a
30147 reference parameter or not. Kill an extra variable by computing
30148 the arg_idx during emission.
30150 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30151 function that returns whether a parameter is an out/ref value or not.
30153 (Parameter.ParameterType): The type of the parameter (base,
30154 without ref/out applied).
30156 (Parameter.Resolve): Perform resolution here.
30157 (Parameter.ExternalType): The full type (with ref/out applied).
30159 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30160 support for expressions on the using statement.
30162 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30164 * statement.cs (Using.EmitLocalVariableDecls): Split the
30165 localvariable handling of the using statement.
30167 (Block.EmitMeta): Keep track of variable count across blocks. We
30168 were reusing slots on separate branches of blocks.
30170 (Try.Emit): Emit the general code block, we were not emitting it.
30172 Check the type of the declaration to be an IDisposable or
30173 something that can be implicity converted to it.
30175 Emit conversions if required.
30177 * ecore.cs (EmptyExpression): New utility class.
30178 (Expression.ImplicitConversionExists): New utility function.
30180 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30182 * statement.cs (Using): Implement.
30184 * expression.cs (LocalVariableReference): Support read only variables.
30186 * statement.cs: Remove the explicit emit for the Leave opcode.
30187 (VariableInfo): Add a readonly field.
30189 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30191 * ecore.cs (ConvCast): new class used to encapsulate the various
30192 explicit integer conversions that works in both checked and
30193 unchecked contexts.
30195 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30196 properly generate the overflow opcodes.
30198 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30200 * statement.cs: The correct type for the EmptyExpression is the
30201 element_type, not the variable type. Ravi pointed this out.
30203 2001-12-04 Ravi Pratap <ravi@ximian.com>
30205 * class.cs (Method::Define): Handle PInvoke methods specially
30206 by using DefinePInvokeMethod instead of the usual one.
30208 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30209 above to do the task of extracting information and defining the method.
30211 2001-12-04 Ravi Pratap <ravi@ximian.com>
30213 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30214 of the condition for string type.
30216 (Emit): Move that here.
30218 (ArrayCreation::CheckIndices): Keep string literals in their expression
30221 (EmitDynamicInitializers): Handle strings appropriately.
30223 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30225 * codegen.cs (EmitContext): Replace multiple variables with a
30226 single pointer to the current Switch statement.
30228 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30231 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30235 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30238 (Foreach.Emit): Foreach on arrays was not setting
30239 up the loop variables (for break/continue).
30241 (GotoCase): Semi-implented.
30243 2001-12-03 Ravi Pratap <ravi@ximian.com>
30245 * attribute.cs (CheckAttribute): Handle system attributes by using
30246 Attribute.GetAttributes to examine information we need.
30248 (GetValidPlaces): Same here.
30250 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30252 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30254 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30256 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30258 (Method::Emit): Handle the case when we are a PInvoke method.
30260 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30262 * expression.cs: Use ResolveWithSimpleName on compound names.
30264 2001-12-02 Ravi Pratap <ravi@ximian.com>
30266 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30267 before trying to reduce it.
30269 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30271 * constant.cs (LookupConstantValue): Implement.
30273 (EmitConstant): Use the above in emitting the constant.
30275 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30276 that are user-defined by doing a LookupConstantValue on them.
30278 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30281 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30283 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30285 (BaseAccess.DoResolve): Implement.
30287 (MemberAccess.DoResolve): Split this routine into a
30288 ResolveMemberAccess routine that can be used independently
30290 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30292 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30293 As that share bits of the implementation. Is returns a boolean,
30294 while As returns the Type that is being probed.
30296 2001-12-01 Ravi Pratap <ravi@ximian.com>
30298 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30299 instead of a Literal - much easier.
30301 (EnumInTransit): Remove - utterly useless :-)
30303 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30305 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30307 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30308 chain when we have no associated expression.
30310 2001-11-30 Ravi Pratap <ravi@ximian.com>
30312 * constant.cs (Define): Use Location while reporting the errror.
30314 Also emit a warning when 'new' is used and there is no inherited
30317 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30320 (LookupEnumValue): Implement to lookup an enum member's value and define it
30323 (Populate): Re-write accordingly to use the above routine.
30325 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30327 * expression.cs (This): Fix prototype for DoResolveLValue to
30328 override the base class DoResolveLValue.
30330 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30333 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30334 (we need to load the address of the field here). This fixes
30337 (FieldExpr.DoResolveLValue): Call the DoResolve
30338 function to initialize the Instance expression.
30340 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30341 correctly the GetEnumerator operation on a value type.
30343 * cs-parser.jay: Add more simple parsing error catches.
30345 * statement.cs (Switch): Add support for string switches.
30346 Handle null specially.
30348 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30350 2001-11-28 Ravi Pratap <ravi@ximian.com>
30352 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30354 (declare_local_constant): New helper function.
30356 * statement.cs (AddConstant): Keep a separate record of constants
30358 (IsConstant): Implement to determine if a variable is a constant.
30360 (GetConstantExpression): Implement.
30362 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30364 * statement.cs (IsVariableDefined): Re-write.
30366 2001-11-27 Ravi Pratap <ravi@ximian.com>
30368 * class.cs (TypeContainer::FindMembers): Look for constants
30369 in the case when we are looking for MemberTypes.Field
30371 * expression.cs (MemberAccess::DoResolve): Check that in the
30372 case we are a FieldExpr and a Literal, we are not being accessed
30373 by an instance reference.
30375 * cs-parser.jay (local_constant_declaration): Implement.
30377 (declaration_statement): Implement for constant declarations.
30379 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30381 * statement.cs (Switch): Catch double defaults.
30383 (Switch): More work on the switch() statement
30384 implementation. It works for integral values now, need to finish
30388 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30390 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30391 integer literals into other integer literals. To be used by
30394 2001-11-24 Ravi Pratap <ravi@ximian.com>
30396 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30399 (EmitDynamicInitializers): Cope with the above since we extract data
30400 directly from ArrayData now.
30402 (ExpectInitializers): Keep track of whether initializers are mandatory
30405 (Bounds): Make it a hashtable to prevent the same dimension being
30406 recorded for every element in that dimension.
30408 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30411 Also fix bug which was causing the indices to be emitted in the reverse
30414 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30416 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30417 unfinished. They do not work, because the underlying code is
30420 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30422 * cs-parser.jay: Remove bogus fixme.
30424 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30425 on Switch statement.
30427 2001-11-23 Ravi Pratap <ravi@ximian.com>
30429 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30432 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30433 parameter. Apparently, any expression is allowed.
30435 (ValidateInitializers): Update accordingly.
30437 (CheckIndices): Fix some tricky bugs thanks to recursion.
30439 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30440 I was being completely brain-dead.
30442 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30443 and re-write acordingly.
30445 (DelegateInvocation): Re-write accordingly.
30447 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30449 (MakeByteBlob): Handle types more correctly.
30451 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30452 initialization from expressions but it is incomplete because I am a complete
30455 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30457 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30458 on If. Basically, we have to return `true' (ie, we do return to
30459 our caller) only if both branches of the if return.
30461 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30462 short-circuit operators, handle them as short circuit operators.
30464 (Cast.DoResolve): Resolve type.
30465 (Cast.Cast): Take an expression as the target type.
30467 * cs-parser.jay (cast_expression): Remove old hack that only
30468 allowed a limited set of types to be handled. Now we take a
30469 unary_expression and we resolve to a type during semantic
30472 Use the grammar productions from Rhys to handle casts (this is
30473 not complete like Rhys syntax yet, we fail to handle that corner
30474 case that C# has regarding (-x), but we will get there.
30476 2001-11-22 Ravi Pratap <ravi@ximian.com>
30478 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30479 field which is an array type.
30481 * cs-parser.jay (declare_local_variables): Support array initialization too.
30483 * typemanager.cs (MakeKey): Implement.
30485 (everywhere): Use the above appropriately.
30487 * cs-parser.jay (for_statement): Update for array initialization while
30488 declaring variables.
30490 * ecore.cs : The error message was correct, it's the variable's names that
30491 were misleading ;-) Make the code more readable.
30493 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30494 the correct type etc.
30496 (ConvertExplicit): Handle Enum types by examining the underlying type.
30498 2001-11-21 Ravi Pratap <ravi@ximian.com>
30500 * parameter.cs (GetCallingConvention): Always return
30501 CallingConventions.Standard for now.
30503 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30505 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30506 and `r' after calling DoNumericPromotions.
30508 * ecore.cs: Fix error message (the types were in the wrong order).
30510 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30511 BindingFlags.Instance as well
30513 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30514 implicit int literal conversion in an empty cast so that we
30515 propagate the right type upstream.
30517 (UnboxCast): new class used to unbox value types.
30518 (Expression.ConvertExplicit): Add explicit type conversions done
30521 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30522 the target type before applying the implicit LongLiterals to ULong
30525 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30527 * cs-parser.jay (for_statement): Reworked the way For works: now
30528 we declare manually any variables that are introduced in
30529 for_initializer to solve the problem of having out-of-band code
30530 emition (that is what got for broken).
30532 (declaration_statement): Perform the actual variable declaration
30533 that used to be done in local_variable_declaration here.
30535 (local_variable_declaration): Do not declare anything, just pass
30536 the information on a DictionaryEntry
30538 2001-11-20 Ravi Pratap <ravi@ximian.com>
30540 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30541 re-write of the logic to now make it recursive.
30543 (UpdateIndices): Re-write accordingly.
30545 Store element data in a separate ArrayData list in the above methods.
30547 (MakeByteBlob): Implement to dump the array data into a byte array.
30549 2001-11-19 Ravi Pratap <ravi@ximian.com>
30551 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30554 * constant.cs (Define): Implement.
30556 (EmitConstant): Re-write fully.
30558 Pass in location info.
30560 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30563 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30564 DictionaryEntry since we need location info too.
30566 (constant_declaration): Update accordingly.
30568 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30569 code into another method : UpdateIndices.
30571 2001-11-18 Ravi Pratap <ravi@ximian.com>
30573 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30574 some type checking etc.
30576 2001-11-17 Ravi Pratap <ravi@ximian.com>
30578 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30579 bits to provide dimension info if the user skips doing that.
30581 Update second constructor to store the rank correctly.
30583 2001-11-16 Ravi Pratap <ravi@ximian.com>
30585 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30586 and try to implement.
30588 * ../errors/cs0150.cs : Add.
30590 * ../errors/cs0178.cs : Add.
30592 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30594 * statement.cs: Implement foreach on multi-dimensional arrays.
30596 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30597 name of the params argument.
30599 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30600 initializing the array.
30602 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30603 we can use this elsewhere.
30605 * statement.cs: Finish implementation of foreach for single
30608 * cs-parser.jay: Use an out-of-band stack to pass information
30609 around, I wonder why I need this.
30611 foreach_block: Make the new foreach_block the current_block.
30613 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30614 function used to return a static Parameters structure. Used for
30615 empty parameters, as those are created very frequently.
30617 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30619 2001-11-15 Ravi Pratap <ravi@ximian.com>
30621 * interface.cs : Default modifier is private, not public. The
30622 make verify test passes again.
30624 2001-11-15 Ravi Pratap <ravi@ximian.com>
30626 * support.cs (ReflectionParameters): Fix logic to determine
30627 whether the last parameter is a params one. Test 9 passes again.
30629 * delegate.cs (Populate): Register the builders we define with
30630 RegisterParameterForBuilder. Test 19 passes again.
30632 * cs-parser.jay (property_declaration): Reference $6 instead
30633 of $$ to get at the location.
30635 (indexer_declaration): Similar stuff.
30637 (attribute): Ditto.
30639 * class.cs (Property): Register parameters for the Get and Set methods
30640 if they exist. Test 23 passes again.
30642 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30643 call to EmitArguments as we are sure there aren't any params arguments.
30644 Test 32 passes again.
30646 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30647 IndexOutOfRangeException.
30649 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30650 Test 33 now passes again.
30652 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30654 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30655 broke a bunch of things. Will have to come up with a better way
30656 of tracking locations.
30658 * statement.cs: Implemented foreach for single dimension arrays.
30660 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30662 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30663 an error. This removes the lookup from the critical path.
30665 * cs-parser.jay: Removed use of temporary_loc, which is completely
30668 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30670 * support.cs (ReflectionParameters.ParameterModifier): Report
30671 whether the argument is a PARAMS argument or not.
30673 * class.cs: Set the attribute `ParamArrayAttribute' on the
30674 parameter argument.
30676 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30677 and cons_param_array_attribute (ConstructorInfo for
30678 ParamArrayAttribute).,
30680 * codegen.cs: Emit the return using the `Return' statement, that
30681 way we can report the error correctly for missing return values.
30683 * class.cs (Method.Emit): Clean up.
30685 * expression.cs (Argument.Resolve): Take another argument: the
30686 location where this argument is used. Notice that this is not
30687 part of the "Argument" class as to reduce the size of the
30688 structure (we know the approximate location anyways).
30690 Test if the argument is a variable-reference, if not, then
30691 complain with a 206.
30693 (Argument.Emit): Emit addresses of variables.
30695 (Argument.FullDesc): Simplify.
30697 (Invocation.DoResolve): Update for Argument.Resolve.
30699 (ElementAccess.DoResolve): ditto.
30701 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30702 method should be virtual, as this method is always virtual.
30704 (NewDelegate.DoResolve): Update for Argument.Resolve.
30706 * class.cs (ConstructorInitializer.DoResolve): ditto.
30708 * attribute.cs (Attribute.Resolve): ditto.
30710 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30712 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30714 * expression.cs (ParameterReference): Drop IStackStorage and implement
30715 IAssignMethod instead.
30717 (LocalVariableReference): ditto.
30719 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30720 IAssignMethod instead.
30722 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30724 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30725 enumerations that are used in heavily used structures derive from
30726 byte in a laughable and pathetic attempt to reduce memory usage.
30727 This is the kind of pre-optimzations that you should not do at
30728 home without adult supervision.
30730 * expression.cs (UnaryMutator): New class, used to handle ++ and
30731 -- separatedly from the other unary operators. Cleans up the
30732 code, and kills the ExpressionStatement dependency in Unary.
30734 (Unary): Removed `method' and `Arguments' from this class, making
30735 it smaller, and moving it all to SimpleCall, so I can reuse this
30736 code in other locations and avoid creating a lot of transient data
30737 strucutres when not required.
30739 * cs-parser.jay: Adjust for new changes.
30741 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30743 * enum.cs (Enum.Populate): If there is a failure during
30746 * cs-parser.jay (opt_enum_base): we used to catch type errors
30747 here, but this is really incorrect. The type error should be
30748 catched during semantic analysis.
30750 2001-12-11 Ravi Pratap <ravi@ximian.com>
30752 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30753 current_local_parameters as expected since I, in my stupidity, had forgotten
30756 * attribute.cs (GetValidPlaces): Fix stupid bug.
30758 * class.cs (Method::Emit): Perform check on applicability of attributes.
30760 (Constructor::Emit): Ditto.
30762 (Field::Emit): Ditto.
30764 (Field.Location): Store location information.
30766 (Property, Event, Indexer, Operator): Ditto.
30768 * cs-parser.jay (field_declaration): Pass in location for each field.
30770 * ../errors/cs0592.cs : Add.
30772 2001-11-12 Ravi Pratap <ravi@ximian.com>
30774 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30776 (InitCoreTypes): Update accordingly.
30778 (RegisterAttrType, LookupAttr): Implement.
30780 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30781 info about the same.
30783 (Resolve): Update to populate the above as necessary.
30785 (Error592): Helper.
30787 (GetValidPlaces): Helper to the above.
30789 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30791 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30793 2001-11-12 Ravi Pratap <ravi@ximian.com>
30795 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30797 * ../errors/cs0617.cs : Add.
30799 2001-11-11 Ravi Pratap <ravi@ximian.com>
30801 * enum.cs (Emit): Rename to Populate to be more consistent with what
30802 we expect it to do and when exactly it is called.
30804 * class.cs, rootcontext.cs : Update accordingly.
30806 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30807 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30809 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30811 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30812 of a fieldinfo using the above, when dealing with a FieldBuilder.
30814 2001-11-10 Ravi Pratap <ravi@ximian.com>
30816 * ../errors/cs0031.cs : Add.
30818 * ../errors/cs1008.cs : Add.
30820 * ../errrors/cs0543.cs : Add.
30822 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30825 (FindMembers): Implement.
30827 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30828 enums and delegates too.
30830 (enum_types): Rename to builder_to_enum.
30832 (delegate_types): Rename to builder_to_delegate.
30834 * delegate.cs (FindMembers): Implement.
30836 2001-11-09 Ravi Pratap <ravi@ximian.com>
30838 * typemanager.cs (IsEnumType): Implement.
30840 * enum.cs (Emit): Re-write parts to account for the underlying type
30841 better and perform checking etc.
30843 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30844 of the underlying type.
30846 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30849 * enum.cs (error31): Helper to report error #31.
30851 * cs-parser.jay (enum_declaration): Store location of each member too.
30853 * enum.cs (member_to_location): New hashtable.
30855 (AddEnumMember): Update location hashtable.
30857 (Emit): Use the location of each member while reporting errors.
30859 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30861 * cs-parser.jay: A for_initializer if is a
30862 local_variable_declaration really ammount to have an implicit
30863 block with the variable declaration and no initializer for for.
30865 * statement.cs (For.Emit): Cope with null initializers.
30867 This fixes the infinite loop on for initializers.
30869 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30871 * enum.cs: More cleanup.
30873 * ecore.cs: Remove dead code.
30875 * class.cs (Property.Emit): More simplification.
30876 (Event.Emit): ditto.
30878 Reworked to have less levels of indentation.
30880 2001-11-08 Ravi Pratap <ravi@ximian.com>
30882 * class.cs (Property): Emit attributes.
30892 * enum.cs (Emit): Ditto.
30894 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30897 * class.cs (Field, Event, etc.): Move attribute generation into the
30898 Emit method everywhere.
30900 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30901 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30902 as we had no way of defining nested enums !
30904 * rootcontext.cs : Adjust code accordingly.
30906 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30908 2001-11-07 Ravi Pratap <ravi@ximian.com>
30910 * expression.cs (EvalConstantExpression): Move into ecore.cs
30912 * enum.cs (Enum): Rename some members and make them public and readonly
30913 according to our convention.
30915 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30918 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30920 (Enum::Emit): Write a simple version for now which doesn't try to compute
30921 expressions. I shall modify this to be more robust in just a while.
30923 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30925 (TypeContainer::CloseType): Create the Enum types too.
30927 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30929 * expression.cs (EvalConstantExpression): Get rid of completely.
30931 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30932 user-defined values and other cases.
30934 (IsValidEnumLiteral): Helper function.
30936 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30937 out there in the case we had a literal FieldExpr.
30939 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30941 (Literalize): Revamp a bit to take two arguments.
30943 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30945 2001-11-06 Ravi Pratap <ravi@ximian.com>
30947 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30949 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30951 (Resolve): Use the above to ensure we have proper initializers.
30953 2001-11-05 Ravi Pratap <ravi@ximian.com>
30955 * expression.cs (Expression::EvalConstantExpression): New method to
30956 evaluate constant expressions.
30958 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30960 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30962 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30965 (Binary.ResolveOperator): Handle operator != (object a, object b)
30966 and operator == (object a, object b);
30968 (Binary.DoNumericPromotions): Indicate whether the numeric
30969 promotion was possible.
30971 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30974 Made the ArrayAccess implement interface IAssignMethod instead of
30975 IStackStore as the order in which arguments are passed reflects
30978 * assign.cs: Instead of using expr.ExprClass to select the way of
30979 assinging, probe for the IStackStore/IAssignMethod interfaces.
30981 * typemanager.cs: Load InitializeArray definition.
30983 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30984 static data that can be used to initialize arrays.
30986 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30988 * expression.cs: Handle operator== and operator!= for booleans.
30990 (Conditioal.Reduce): Implement reducer for the ?: operator.
30992 (Conditional.Resolve): Implement dead code elimination.
30994 (Binary.Resolve): Catch string literals and return a new
30995 concatenated string.
30997 (Unary.Reduce): Implement reduction of unary expressions.
30999 * ecore.cs: Split out the expression core handling here.
31001 (Expression.Reduce): New method used to perform constant folding
31002 and CSE. This is needed to support constant-expressions.
31004 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31005 targets, and optimize for !x.
31007 2001-11-04 Ravi Pratap <ravi@ximian.com>
31009 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31010 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31011 set custom atttributes.
31013 * literal.cs (Literal::GetValue): New abstract method to return the actual
31014 value of the literal, cast as an object.
31016 (*Literal): Implement GetValue method.
31018 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31019 expressions to the arraylist but objects of type Argument.
31021 * class.cs (TypeContainer::Emit): Emit our attributes too.
31023 (Method::Emit, Constructor::Emit): Ditto.
31025 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31026 to be ignoring earlier.
31028 2001-11-03 Ravi Pratap <ravi@ximian.com>
31030 * attribute.cs (AttributeSection::Define): Implement to do the business
31031 of constructing a CustomAttributeBuilder.
31033 (Attribute): New trivial class. Increases readability of code.
31035 * cs-parser.jay : Update accordingly.
31037 (positional_argument_list, named_argument_list, named_argument): New rules
31039 (attribute_arguments): Use the above so that we are more correct.
31041 2001-11-02 Ravi Pratap <ravi@ximian.com>
31043 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31044 to perform all checks for a method with a params parameter.
31046 (Invocation::OverloadResolve): Update to use the above method and therefore
31047 cope correctly with params method invocations.
31049 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31052 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31053 constructors in our parent too because we can't afford to miss out on
31056 * attribute.cs (AttributeSection): New name for the class Attribute
31058 Other trivial changes to improve readability.
31060 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31061 use the new class names.
31063 2001-11-01 Ravi Pratap <ravi@ximian.com>
31065 * class.cs (Method::Define): Complete definition for params types too
31067 (Indexer::Define): Ditto.
31069 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31070 Cope everywhere with a request for info about the array parameter.
31072 2001-11-01 Ravi Pratap <ravi@ximian.com>
31074 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31076 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31077 local_variable_type to extract the string corresponding to the type.
31079 (local_variable_type): Fixup the action to use the new helper method.
31081 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31084 * expression.cs : Clean out code which uses the above.
31086 2001-10-31 Ravi Pratap <ravi@ximian.com>
31088 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31089 and bale out if necessary by returning a false.
31091 (RegisterProperty): Ditto.
31093 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31094 and print out appropriate error messages.
31096 * interface.cs (everywhere): Ditto.
31098 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31099 location to constructor.
31101 * class.cs (Property, Event, Indexer): Update accordingly.
31103 * ../errors/cs111.cs : Added.
31105 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31106 of a method, as laid down by the spec.
31108 (Invocation::OverloadResolve): Use the above method.
31110 2001-10-31 Ravi Pratap <ravi@ximian.com>
31112 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31113 now take a TypeContainer and a Parameters object.
31115 (ParameterData): Modify return type of ParameterModifier method to be
31116 Parameter.Modifier and not a string.
31118 (ReflectionParameters, InternalParameters): Update accordingly.
31120 * expression.cs (Argument::GetParameterModifier): Same here.
31122 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31123 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31124 symbol in it at all so maybe this is only for now.
31126 2001-10-30 Ravi Pratap <ravi@ximian.com>
31128 * support.cs (InternalParameters): Constructor now takes an extra argument
31129 which is the actual Parameters class.
31131 (ParameterDesc): Update to provide info on ref/out modifiers.
31133 * class.cs (everywhere): Update call to InternalParameters to pass in
31134 the second argument too.
31136 * support.cs (ParameterData): Add ParameterModifier, which is a method
31137 to return the modifier info [ref/out etc]
31139 (InternalParameters, ReflectionParameters): Implement the above.
31141 * expression.cs (Argument::ParameterModifier): Similar function to return
31142 info about the argument's modifiers.
31144 (Invocation::OverloadResolve): Update to take into account matching modifiers
31147 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31148 a new SetFormalParameters object which we pass to InternalParameters.
31150 2001-10-30 Ravi Pratap <ravi@ximian.com>
31152 * expression.cs (NewArray): Merge into the ArrayCreation class.
31154 2001-10-29 Ravi Pratap <ravi@ximian.com>
31156 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31157 NewUserdefinedArray into one as there wasn't much of a use in having
31160 * expression.cs (Argument): Change field's name to ArgType from Type.
31162 (Type): New readonly property which returns the proper type, taking into
31163 account ref/out modifiers.
31165 (everywhere): Adjust code accordingly for the above.
31167 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31168 whether we are emitting for a ref or out parameter.
31170 * expression.cs (Argument::Emit): Use the above field to set the state.
31172 (LocalVariableReference::Emit): Update to honour the flag and emit the
31175 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31177 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31179 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31181 (ReflectionParameters, InternalParameters): Implement the above method.
31183 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31186 (Invocation::FullMethodDesc): Ditto.
31188 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31190 * cs-parser.jay: Add extra production for the second form of array
31193 * expression.cs (ArrayCreation): Update to reflect the above
31196 * Small changes to prepare for Array initialization.
31198 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31200 * typemanager.cs (ImplementsInterface): interface might be null;
31201 Deal with this problem;
31203 Also, we do store negative hits on the cache (null values), so use
31204 this instead of calling t.GetInterfaces on the type everytime.
31206 2001-10-28 Ravi Pratap <ravi@ximian.com>
31208 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31210 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31211 split functionality out into different classes.
31213 (New::FormArrayType): Move into NewBuiltinArray.
31215 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31218 (NewBuiltinArray): New class to handle creation of built-in arrays.
31220 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31221 account creation of one-dimensional arrays.
31223 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31225 (NewUserdefinedArray::DoResolve): Implement.
31227 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31229 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31230 we maintain inside the TypeManager. This is necessary to perform lookups on the
31233 (LookupType): Update to perform GetType on the module builders too.
31235 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31237 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31239 2001-10-23 Ravi Pratap <ravi@ximian.com>
31241 * expression.cs (New::DoResolve): Implement guts of array creation.
31243 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31245 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31247 * expression.cs: Fix bug I introduced lsat night that broke
31250 (Expression.Resolve): Report a 246 error (can not resolve name)
31251 if we find a SimpleName in the stream.
31253 (Expression.ResolveLValue): Ditto.
31255 (Expression.ResolveWithSimpleName): This function is a variant of
31256 ResolveName, this one allows SimpleNames to be returned without a
31257 warning. The only consumer of SimpleNames is MemberAccess
31259 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31261 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31262 might arrive here. I have my doubts that this is correct.
31264 * statement.cs (Lock): Implement lock statement.
31266 * cs-parser.jay: Small fixes to support `lock' and `using'
31268 * cs-tokenizer.cs: Remove extra space
31270 * driver.cs: New flag --checked, allows to turn on integer math
31273 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31274 Threading.Monitor.Exit
31276 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31278 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31279 Expression Class to be IndexerAccess.
31281 Notice that Indexer::DoResolve sets the eclass to Value.
31283 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31285 * class.cs (TypeContainer::Emit): Emit code for indexers.
31287 * assign.cs (IAssignMethod): New interface implemented by Indexers
31288 and Properties for handling assignment.
31290 (Assign::Emit): Simplify and reuse code.
31292 * expression.cs (IndexerAccess, PropertyExpr): Implement
31293 IAssignMethod, clean up old code.
31295 2001-10-22 Ravi Pratap <ravi@ximian.com>
31297 * typemanager.cs (ImplementsInterface): New method to determine if a type
31298 implements a given interface. Provides a nice cache too.
31300 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31303 (ConvertReferenceExplicit): Ditto.
31305 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31306 various methods, with correct names etc.
31308 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31309 Operator.UnaryNegation.
31311 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31312 we have a unary plus or minus operator.
31314 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31317 * everywhere : update accordingly.
31319 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31322 * class.cs (Method::Define): For the case where we are implementing a method
31323 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31324 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31326 2001-10-21 Ravi Pratap <ravi@ximian.com>
31328 * interface.cs (FindMembers): Implement to work around S.R.E
31331 * typemanager.cs (IsInterfaceType): Implement.
31333 (FindMembers): Update to handle interface types too.
31335 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31336 use IsAssignableFrom as that is not correct - it doesn't work.
31338 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31339 and accordingly override EmitStatement.
31341 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31342 using the correct logic :-)
31344 2001-10-19 Ravi Pratap <ravi@ximian.com>
31346 * ../errors/cs-11.cs : Add to demonstrate error -11
31348 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31350 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31351 then pass this as a hint to ResolveLValue.
31353 * expression.cs (FieldExpr): Add Location information
31355 (FieldExpr::LValueResolve): Report assignment to readonly
31358 (Expression::ExprClassFromMemberInfo): Pass location information.
31360 (Expression::ResolveLValue): Add new method that resolves an
31363 (Expression::DoResolveLValue): Default invocation calls
31366 (Indexers): New class used to keep track of indexers in a given
31369 (IStackStore): Renamed from LValue, as it did not really describe
31370 what this did. Also ResolveLValue is gone from this interface and
31371 now is part of Expression.
31373 (ElementAccess): Depending on the element access type
31375 * typemanager.cs: Add `indexer_name_type' as a Core type
31376 (System.Runtime.CompilerServices.IndexerNameAttribute)
31378 * statement.cs (Goto): Take a location.
31380 2001-10-18 Ravi Pratap <ravi@ximian.com>
31382 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31383 if two delegates are compatible.
31385 (NewDelegate::DoResolve): Update to take care of the case when
31386 we instantiate a delegate from another delegate.
31388 * typemanager.cs (FindMembers): Don't even try to look up members
31389 of Delegate types for now.
31391 2001-10-18 Ravi Pratap <ravi@ximian.com>
31393 * delegate.cs (NewDelegate): New class to take care of delegate
31396 * expression.cs (New): Split the delegate related code out into
31397 the NewDelegate class.
31399 * delegate.cs (DelegateInvocation): New class to handle delegate
31402 * expression.cs (Invocation): Split out delegate related code into
31403 the DelegateInvocation class.
31405 2001-10-17 Ravi Pratap <ravi@ximian.com>
31407 * expression.cs (New::DoResolve): Implement delegate creation fully
31408 and according to the spec.
31410 (New::DoEmit): Update to handle delegates differently.
31412 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31413 because of which we were printing out arguments in reverse order !
31415 * delegate.cs (VerifyMethod): Implement to check if the given method
31416 matches the delegate.
31418 (FullDelegateDesc): Implement.
31420 (VerifyApplicability): Implement.
31422 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31423 delegate invocations too.
31425 (Invocation::Emit): Ditto.
31427 * ../errors/cs1593.cs : Added.
31429 * ../errors/cs1594.cs : Added.
31431 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31433 2001-10-16 Ravi Pratap <ravi@ximian.com>
31435 * typemanager.cs (intptr_type): Core type for System.IntPtr
31437 (InitCoreTypes): Update for the same.
31439 (iasyncresult_type, asynccallback_type): Ditto.
31441 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31444 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31447 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31448 the builders for the 4 members of a delegate type :-)
31450 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31453 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31455 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31457 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31459 * statement.cs (Break::Emit): Implement.
31460 (Continue::Emit): Implement.
31462 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31463 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31464 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31465 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31468 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31469 properties that track the label for the current loop (begin of the
31470 loop and end of the loop).
31472 2001-10-15 Ravi Pratap <ravi@ximian.com>
31474 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31475 use of emitting anything at all.
31477 * class.cs, rootcontext.cs : Get rid of calls to the same.
31479 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31481 (Populate): Define the constructor correctly and set the implementation
31484 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31487 (AddDelegateType): Implement.
31489 (IsDelegateType): Implement helper method.
31491 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31493 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31494 and accordingly handle it.
31496 * delegate.cs (Populate): Take TypeContainer argument.
31497 Implement bits to define the Invoke method. However, I still haven't figured out
31498 how to take care of the native int bit :-(
31500 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31501 Qualify the name of the delegate, not its return type !
31503 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31506 (StandardConversionExists): Checking for array types turns out to be recursive.
31508 (ConvertReferenceExplicit): Implement array conversion.
31510 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31512 2001-10-12 Ravi Pratap <ravi@ximian.com>
31514 * cs-parser.jay (delegate_declaration): Store the fully qualified
31515 name as it is a type declaration.
31517 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31520 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31521 as TypeContainer::DefineType.
31523 (Populate): Method in which all the definition of the various methods (Invoke)
31526 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31529 (CloseDelegate): Finally creates the delegate.
31531 * class.cs (TypeContainer::DefineType): Update to define delegates.
31532 (Populate, Emit and CloseType): Do the same thing here too.
31534 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31535 delegates in all these operations.
31537 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31539 * expression.cs: LocalTemporary: a new expression used to
31540 reference a temporary that has been created.
31542 * assign.cs: Handle PropertyAccess back here, so that we can
31543 provide the proper semantic access to properties.
31545 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31546 a few more explicit conversions.
31548 * modifiers.cs: `NEW' modifier maps to HideBySig.
31550 * expression.cs (PropertyExpr): Make this into an
31551 ExpressionStatement, and support the EmitStatement code path.
31553 Perform get/set error checking, clean up the interface.
31555 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31556 them into toplevel access objects.
31558 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31560 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31563 * typemanager.cs: Keep track here of our PropertyBuilders again to
31564 work around lameness in SRE.
31566 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31568 * expression.cs (LValue::LValueResolve): New method in the
31569 interface, used to perform a second resolution pass for LValues.
31571 (This::DoResolve): Catch the use of this in static methods.
31573 (This::LValueResolve): Implement.
31575 (This::Store): Remove warning, assigning to `this' in structures
31578 (Invocation::Emit): Deal with invocation of
31579 methods on value types. We need to pass the address to structure
31580 methods rather than the object itself. (The equivalent code to
31581 emit "this" for structures leaves the entire structure on the
31582 stack instead of a pointer to it).
31584 (ParameterReference::DoResolve): Compute the real index for the
31585 argument based on whether the method takes or not a `this' pointer
31586 (ie, the method is static).
31588 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31589 value types returned from functions when we need to invoke a
31590 method on the sturcture.
31593 2001-10-11 Ravi Pratap <ravi@ximian.com>
31595 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31596 defining the type in the Modulebuilder or Typebuilder. This is to take
31597 care of nested types which need to be defined on the TypeBuilder using
31598 DefineNestedMethod.
31600 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31601 methods in RootContext, only ported to be part of TypeContainer.
31603 (TypeContainer::GetInterfaceOrClass): Ditto.
31605 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31607 * interface.cs (Interface::DefineInterface): New method. Does exactly
31608 what RootContext.CreateInterface did earlier, only it takes care of nested types
31611 (Interface::GetInterfaces): Move from RootContext here and port.
31613 (Interface::GetInterfaceByName): Same here.
31615 * rootcontext.cs (ResolveTree): Re-write.
31617 (PopulateTypes): Re-write.
31619 * class.cs (TypeContainer::Populate): Populate nested types too.
31620 (TypeContainer::Emit): Emit nested members too.
31622 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31623 instead just use the name argument passed in as it is already fully
31626 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31627 to TypeContainer mapping to see if a type is user-defined.
31629 * class.cs (TypeContainer::CloseType): Implement.
31631 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31632 the default constructor.
31634 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31637 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31639 * interface.cs (CloseType): Create the type here.
31641 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31644 Remove all the methods which are now in TypeContainer.
31646 2001-10-10 Ravi Pratap <ravi@ximian.com>
31648 * delegate.cs (Define): Re-write bits to define the delegate
31651 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31653 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31655 * expression.cs (ImplicitReferenceConversion): handle null as well
31656 as a source to convert to any reference type.
31658 * statement.cs (Return): Perform any implicit conversions to
31659 expected return type.
31661 Validate use of return statement.
31663 * codegen.cs (EmitContext): Pass the expected return type here.
31665 * class.cs (Method, Constructor, Property): Pass expected return
31666 type to EmitContext.
31668 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31670 * expression.cs: Make DoResolve take an EmitContext instead of a
31673 Replaced `l' and `location' for `loc', for consistency.
31675 (Error, Warning): Remove unneeded Tc argument.
31677 * assign.cs, literal.cs, constant.cs: Update to new calling
31680 * codegen.cs: EmitContext now contains a flag indicating whether
31681 code is being generated in a static method or not.
31683 * cs-parser.jay: DecomposeQI, new function that replaces the old
31684 QualifiedIdentifier. Now we always decompose the assembled
31685 strings from qualified_identifier productions into a group of
31688 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31690 * rootcontext.cs: Deal with field-less struct types correctly now
31691 by passing the size option to Define Type.
31693 * class.cs: Removed hack that created one static field.
31695 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31697 * statement.cs: Moved most of the code generation here.
31699 2001-10-09 Ravi Pratap <ravi@ximian.com>
31701 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31704 (ElementAccess): Remove useless bits for now - keep checks as the spec
31707 2001-10-08 Ravi Pratap <ravi@ximian.com>
31709 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31710 and start performing checks according to the spec.
31712 2001-10-07 Ravi Pratap <ravi@ximian.com>
31714 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31715 rank_specifiers instead.
31717 (rank_specifiers): Change the order in which the rank specifiers are stored
31719 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31721 * expression.cs (ElementAccess): Implement the LValue interface too.
31723 2001-10-06 Ravi Pratap <ravi@ximian.com>
31725 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31726 except that user defined conversions are not included.
31728 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31729 perform the conversion of the return type, if necessary.
31731 (New::DoResolve): Check whether we are creating an array or an object
31732 and accordingly do the needful.
31734 (New::Emit): Same here.
31736 (New::DoResolve): Implement guts of array creation.
31738 (New::FormLookupType): Helper function.
31740 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31742 * codegen.cs: Removed most of the code generation here, and move the
31743 corresponding code generation bits to the statement classes.
31745 Added support for try/catch/finalize and throw.
31747 * cs-parser.jay: Added support for try/catch/finalize.
31749 * class.cs: Catch static methods having the flags override,
31750 virtual or abstract.
31752 * expression.cs (UserCast): This user cast was not really doing
31753 what it was supposed to do. Which is to be born in fully resolved
31754 state. Parts of the resolution were being performed at Emit time!
31758 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31760 * expression.cs: Implicity convert the result from UserCast.
31762 2001-10-05 Ravi Pratap <ravi@ximian.com>
31764 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31765 prevented it from working correctly.
31767 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31768 merely ConvertImplicit.
31770 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31772 * typemanager.cs: Make the LookupTypeContainer function static,
31773 and not per-instance.
31775 * class.cs: Make static FindMembers (the one that takes a Type
31778 * codegen.cs: Add EmitForeach here.
31780 * cs-parser.jay: Make foreach a toplevel object instead of the
31781 inline expansion, as we need to perform semantic analysis on it.
31783 2001-10-05 Ravi Pratap <ravi@ximian.com>
31785 * expression.cs (Expression::ImplicitUserConversion): Rename to
31786 UserDefinedConversion.
31788 (Expression::UserDefinedConversion): Take an extra argument specifying
31789 whether we look for explicit user conversions too.
31791 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31793 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31795 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31796 with the appropriate arguments.
31798 * cs-parser.jay (cast_expression): Record location too.
31800 * expression.cs (Cast): Record location info.
31802 (Expression::ConvertExplicit): Take location argument.
31804 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31805 to determine if we are doing explicit conversions.
31807 (UserCast::Emit): Update accordingly.
31809 (Expression::ConvertExplicit): Report an error if everything fails.
31811 * ../errors/cs0030.cs : Add.
31813 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31815 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31816 virtual and newslot bits.
31818 * class.cs (TypeContainer::RegisterRequiredImplementations):
31819 Record methods we need.
31821 (TypeContainer::MakeKey): Helper function to make keys for
31822 MethodBases, since the Methodbase key is useless.
31824 (TypeContainer::Populate): Call RegisterRequiredImplementations
31825 before defining the methods.
31827 Create a mapping for method_builders_to_methods ahead of time
31828 instead of inside a tight loop.
31830 (::RequireMethods): Accept an object as the data to set into the
31831 hashtable so we can report interface vs abstract method mismatch.
31833 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31835 * report.cs: Make all of it static.
31837 * rootcontext.cs: Drop object_type and value_type computations, as
31838 we have those in the TypeManager anyways.
31840 Drop report instance variable too, now it is a global.
31842 * driver.cs: Use try/catch on command line handling.
31844 Add --probe option to debug the error reporting system with a test
31847 * report.cs: Add support for exiting program when a probe
31848 condition is reached.
31850 2001-10-03 Ravi Pratap <ravi@ximian.com>
31852 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31853 we do a forcible conversion regardless of type, to check if
31854 ForceConversion returns a null.
31856 (Binary::error19): Use location to report error.
31858 (Unary::error23): Use location here too.
31860 * ../errors/cs0019.cs : Check in.
31862 * ../errors/cs0023.cs : Check in.
31864 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31865 case of a non-null MethodInfo object with a length of 0 !
31867 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31868 an applicable member - according to the spec :-)
31869 Also fix logic to find members in base types.
31871 (Unary::ResolveOperator): Same here.
31873 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31874 as I was getting thoroughly confused between this and error19 :-)
31876 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31877 (::FindMostEncompassedType): Implement.
31878 (::FindMostEncompassingType): Implement.
31879 (::StandardConversionExists): Implement.
31881 (UserImplicitCast): Re-vamp. We now need info about most specific
31882 source and target types so that we can do the necessary conversions.
31884 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31885 mathematical union with no duplicates.
31887 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31889 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31890 in order from base classes to child classes, so that we can in
31891 child classes look up in our parent for method names and
31892 attributes (required for handling abstract, virtual, new, override
31893 constructs: we need to instrospect our base class, and if we dont
31894 populate the classes in order, the introspection might be
31895 incorrect. For example, a method could query its parent before
31896 the parent has any methods and would determine that the parent has
31897 no abstract methods (while it could have had them)).
31899 (RootContext::CreateType): Record the order in which we define the
31902 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31904 * class.cs (TypeContainer::Populate): Also method definitions can
31905 fail now, keep track of this.
31907 (TypeContainer::FindMembers): Implement support for
31908 DeclaredOnly/noDeclaredOnly flag.
31910 (Constructor::Emit) Return the ConstructorBuilder.
31912 (Method::Emit) Return the MethodBuilder.
31913 Check for abstract or virtual methods to be public.
31915 * rootcontext.cs (RootContext::CreateType): Register all the
31916 abstract methods required for the class to be complete and the
31917 interface methods that must be implemented.
31919 * cs-parser.jay: Report error 501 (method requires body if it is
31920 not marked abstract or extern).
31922 * expression.cs (TypeOf::Emit): Implement.
31924 * typemanager.cs: runtime_handle_type, new global type.
31926 * class.cs (Property::Emit): Generate code for properties.
31928 2001-10-02 Ravi Pratap <ravi@ximian.com>
31930 * expression.cs (Unary::ResolveOperator): Find operators on base type
31931 too - we now conform exactly to the spec.
31933 (Binary::ResolveOperator): Same here.
31935 * class.cs (Operator::Define): Fix minor quirk in the tests.
31937 * ../errors/cs0215.cs : Added.
31939 * ../errors/cs0556.cs : Added.
31941 * ../errors/cs0555.cs : Added.
31943 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31945 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31946 single integer which is really efficient
31948 2001-10-01 Ravi Pratap <ravi@ximian.com>
31950 * expression.cs (Expression::ImplicitUserConversion): Use location
31951 even in the case when we are examining True operators.
31953 * class.cs (Operator::Define): Perform extensive checks to conform
31954 with the rules for operator overloading in the spec.
31956 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31957 some of the other conversions mentioned in the spec.
31959 * typemanager.cs (array_type): New static member for the System.Array built-in
31962 (cloneable_interface): For System.ICloneable interface.
31964 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31965 we start resolving the tree and populating types.
31967 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31969 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31971 * expression.cs (Expression::ExprClassFromMemberInfo,
31972 Expression::Literalize): Create literal expressions from
31973 FieldInfos which are literals.
31975 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31976 type casts, because they were wrong. The test suite in tests
31979 (ImplicitNumericConversion): ushort to ulong requires a widening
31982 Int32 constant to long requires widening cast as well.
31984 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31985 for integers because the type on the stack is not i4.
31987 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31989 * expression.cs (report118): require location argument.
31991 * parameter.cs: Do not dereference potential null value.
31993 * class.cs: Catch methods that lack the `new' keyword when
31994 overriding a name. Report warnings when `new' is used without
31995 anything being there to override.
31997 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31999 * class.cs: Only add constructor to hashtable if it is non-null
32000 (as now constructors can fail on define).
32002 (TypeManager, Class, Struct): Take location arguments.
32004 Catch field instance initialization in structs as errors.
32006 accepting_filter: a new filter for FindMembers that is static so
32007 that we dont create an instance per invocation.
32009 (Constructor::Define): Catch errors where a struct constructor is
32012 * cs-parser.jay: Pass location information for various new
32015 * delegate.cs (Delegate): take a location argument.
32017 * driver.cs: Do not call EmitCode if there were problesm in the
32018 Definition of the types, as many Builders wont be there.
32020 * decl.cs (Decl::Decl): Require a location argument.
32022 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32023 into integers, and find the most appropiate integer for it.
32025 * literal.cs: Implement ULongLiteral.
32027 * rootcontext.cs: Provide better information about the location of
32028 failure when CreateType fails.
32030 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32032 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32035 * expression.cs (Binary::CheckShiftArguments): Add missing type
32037 (Binary::ResolveOperator): Add type to the logical and and logical
32038 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32041 (Binary::DoNumericPromotions): In the case where either argument
32042 is ulong (and most signed types combined with ulong cause an
32043 error) perform implicit integer constant conversions as well.
32045 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32047 * expression.cs (UserImplicitCast): Method should always be
32049 (Invocation::BetterConversion): Simplified test for IntLiteral.
32051 (Expression::ImplicitNumericConversion): Split this routine out.
32052 Put the code that performs implicit constant integer conversions
32055 (Expression::Resolve): Become a wrapper around DoResolve so we can
32056 check eclass and type being set after resolve.
32058 (Invocation::Badness): Remove this dead function
32060 (Binary::ResolveOperator): Do not compute the expensive argumnets
32061 unless we have a union for it.
32063 (Probe::Emit): Is needs to do an isinst and then
32064 compare against null.
32066 (::CanConvert): Added Location argument. If the Location argument
32067 is null (Location.Null), then we do not report errors. This is
32068 used by the `probe' mechanism of the Explicit conversion. We do
32069 not want to generate an error for something that the user
32070 explicitly requested to be casted. But the pipeline for an
32071 explicit cast first tests for potential implicit casts.
32073 So for now, if the Location is null, it means `Probe only' to
32074 avoid adding another argument. Might have to revise this
32077 (ClassCast): New class used to type cast objects into arbitrary
32078 classes (used in Explicit Reference Conversions).
32080 Implement `as' as well.
32082 Reverted all the patches from Ravi below: they were broken:
32084 * The use of `level' as a mechanism to stop recursive
32085 invocations is wrong. That was there just to catch the
32086 bug with a strack trace but not as a way of addressing
32089 To fix the problem we have to *understand* what is going
32090 on and the interactions and come up with a plan, not
32091 just get things going.
32093 * The use of the type conversion cache that I proposed
32094 last night had an open topic: How does this work across
32095 protection domains. A user defined conversion might not
32096 be public in the location where we are applying the
32097 conversion, a different conversion might be selected
32098 (ie, private A->B (better) but public B->A (worse),
32099 inside A, A->B applies, but outside it, B->A will
32102 * On top of that (ie, even if the above is solved),
32103 conversions in a cache need to be abstract. Ie, `To
32104 convert from an Int to a Short use an OpcodeCast', not
32105 `To convert from an Int to a Short use the OpcodeCast on
32106 the variable 5' (which is what this patch was doing).
32108 2001-09-28 Ravi Pratap <ravi@ximian.com>
32110 * expression.cs (Invocation::ConversionExists): Re-write to use
32111 the conversion cache
32113 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32114 cache all conversions done, not just user-defined ones.
32116 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32117 to determine if a conversion exists instead of acutually trying to
32118 perform the conversion. It's faster too.
32120 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32121 and only then attempt the implicit conversion.
32123 2001-09-28 Ravi Pratap <ravi@ximian.com>
32125 * expression.cs (ConvertImplicit): Use a cache for conversions
32126 already found. Check level of recursion and bail out if necessary.
32128 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32130 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32131 Export standard methods that we expect for string operations.
32133 * statement.cs (Block::UsageWarning): Track usage of variables and
32134 report the errors for not used variables.
32136 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32139 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32141 * codegen.cs: remove unnneded code
32143 * expression.cs: Removed BuiltinTypeAccess class
32145 Fix the order in which implicit conversions are
32148 The previous fixed dropped support for boxed conversions (adding a
32149 test to the test suite now)
32151 (UserImplicitCast::CanConvert): Remove test for source being null,
32152 that code is broken. We should not feed a null to begin with, if
32153 we do, then we should track the bug where the problem originates
32154 and not try to cover it up here.
32156 Return a resolved expression of type UserImplicitCast on success
32157 rather than true/false. Ravi: this is what I was talking about,
32158 the pattern is to use a static method as a "constructor" for
32161 Also, do not create arguments until the very last minute,
32162 otherwise we always create the arguments even for lookups that
32163 will never be performed.
32165 (UserImplicitCast::Resolve): Eliminate, objects of type
32166 UserImplicitCast are born in a fully resolved state.
32168 * typemanager.cs (InitCoreTypes): Init also value_type
32169 (System.ValueType).
32171 * expression.cs (Cast::Resolve): First resolve the child expression.
32173 (LValue): Add new method AddressOf to be used by
32176 Change the argument of Store to take an EmitContext instead of an
32177 ILGenerator, because things like FieldExpr need to be able to call
32178 their children expression to generate the instance code.
32180 (Expression::Error, Expression::Warning): Sugar functions for
32183 (Expression::MemberLookup): Accept a TypeContainer instead of a
32184 Report as the first argument.
32186 (Expression::ResolvePrimary): Killed. I still want to improve
32187 this as currently the code is just not right.
32189 (Expression::ResolveMemberAccess): Simplify, but it is still
32192 (Unary::Resolve): Catch errors in AddressOf operators.
32194 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32195 index to a byte for the short-version, or the compiler will choose
32196 the wrong Emit call, which generates the wrong data.
32198 (ParameterReference::Emit, ::Store): same.
32200 (FieldExpr::AddressOf): Implement.
32202 * typemanager.cs: TypeManager: made public variable instead of
32205 * driver.cs: document --fatal.
32207 * report.cs (ErrorMessage, WarningMessage): new names for the old
32208 Error and Warning classes.
32210 * cs-parser.jay (member_access): Turn built-in access to types
32211 into a normal simplename
32213 2001-09-27 Ravi Pratap <ravi@ximian.com>
32215 * expression.cs (Invocation::BetterConversion): Fix to cope
32216 with q being null, since this was introducing a bug.
32218 * expression.cs (ConvertImplicit): Do built-in conversions first.
32220 2001-09-27 Ravi Pratap <ravi@ximian.com>
32222 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32224 2001-09-27 Ravi Pratap <ravi@ximian.com>
32226 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32227 I had introduced long ago (what's new ?).
32229 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32230 the work of all the checking.
32231 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32232 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32234 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32235 that is the right way.
32237 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32238 overloading resolution. Use everywhere instead of cutting and pasting code.
32240 (Binary::ResolveOperator): Use MakeUnionSet.
32242 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32243 we have to convert to bool types. Not complete yet.
32245 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32247 * typemanager.cs (TypeManager::CSharpName): support ushort.
32249 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32250 to provide an expression that performsn an implicit constant int
32251 conversion (section 6.1.6).
32252 (Expression::ConvertImplicitRequired): Reworked to include
32253 implicit constant expression conversions.
32255 (Expression::ConvertNumericExplicit): Finished.
32257 (Invocation::Emit): If InstanceExpression is null, then it means
32258 that we perform a call on this.
32260 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32262 * expression.cs (Unary::Emit): Remove some dead code.
32263 (Probe): Implement Resolve and Emit for `is'.
32264 (Expression::ConvertImplicitRequired): Attempt to do constant
32265 expression conversions here. Maybe should be moved to
32266 ConvertImplicit, but I am not sure.
32267 (Expression::ImplicitLongConstantConversionPossible,
32268 Expression::ImplicitIntConstantConversionPossible): New functions
32269 that tell whether is it possible to apply an implicit constant
32270 expression conversion.
32272 (ConvertNumericExplicit): Started work on explicit numeric
32275 * cs-parser.jay: Update operator constants.
32277 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32278 (Parameters::GetSignature): Hook up VerifyArgs here.
32279 (Parameters::VerifyArgs): Verifies that no two arguments have the
32282 * class.cs (Operator): Update the operator names to reflect the
32283 ones that the spec expects (as we are just stringizing the
32286 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32287 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32288 previous usage did only work for our methods.
32289 (Expression::ConvertImplicit): Handle decimal implicit numeric
32290 conversions as well.
32291 (Expression::InternalTypeConstructor): Used to invoke constructors
32292 on internal types for default promotions.
32294 (Unary::Emit): Implement special handling for the pre/post
32295 increment/decrement for overloaded operators, as they need to have
32296 the same semantics as the other operators.
32298 (Binary::ResolveOperator): ditto.
32299 (Invocation::ConversionExists): ditto.
32300 (UserImplicitCast::Resolve): ditto.
32302 2001-09-26 Ravi Pratap <ravi@ximian.com>
32304 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32305 operator, return after emitting body. Regression tests pass again !
32307 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32308 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32309 (Invocation::OverloadResolve): Ditto.
32310 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32312 * everywhere : update calls to the above methods accordingly.
32314 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32316 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32318 * expression.cs (ExpressionStatement): New base class used for
32319 expressions that can appear in statements, so that we can provide
32320 an alternate path to generate expression that do not leave a value
32323 (Expression::Emit, and all the derivatives): We no longer return
32324 whether a value is left on the stack or not. Every expression
32325 after being emitted leaves a single value on the stack.
32327 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32328 facilties of ExpressionStatement if possible.
32330 * cs-parser.jay: Update statement_expression.
32332 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32334 * driver.cs: Change the wording of message
32336 2001-09-25 Ravi Pratap <ravi@ximian.com>
32338 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32339 the type of the expression to the return type of the method if
32340 we have an overloaded operator match ! The regression tests pass again !
32341 (Unary::ResolveOperator): Ditto.
32343 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32344 to find "op_Implicit", not "implicit" ;-)
32345 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32346 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32348 * everywhere : Correct calls to the above accordingly.
32350 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32351 (ConvertImplicit): Do user-defined conversion if it exists.
32353 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32355 * assign.cs: track location.
32356 (Resolve): Use implicit conversions on assignment.
32358 * literal.cs: Oops. Not good, Emit of short access values should
32359 pass (Bytes) or the wrong argument will be selected.
32361 * expression.cs (Unary::Emit): Emit code for -expr.
32363 (Unary::ResolveOperator): Handle `Substract' for non-constants
32364 (substract from zero from the non-constants).
32365 Deal with Doubles as well.
32367 (Expression::ConvertImplicitRequired): New routine that reports an
32368 error if no implicit conversion exists.
32370 (Invocation::OverloadResolve): Store the converted implicit
32371 expressions if we make them
32373 2001-09-24 Ravi Pratap <ravi@ximian.com>
32375 * class.cs (ConstructorInitializer): Take a Location argument.
32376 (ConstructorBaseInitializer): Same here.
32377 (ConstructorThisInitializer): Same here.
32379 * cs-parser.jay : Update all calls accordingly.
32381 * expression.cs (Unary, Binary, New): Take location argument.
32382 Update accordingly everywhere.
32384 * cs-parser.jay : Update all calls to the above to take a location
32387 * class.cs : Ditto.
32389 2001-09-24 Ravi Pratap <ravi@ximian.com>
32391 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32392 (Invocation::BetterConversion): Same here
32393 (Invocation::ConversionExists): Ditto.
32395 (Invocation::ConversionExists): Implement.
32397 2001-09-22 Ravi Pratap <ravi@ximian.com>
32399 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32400 Also take an additional TypeContainer argument.
32402 * All over : Pass in TypeContainer as argument to OverloadResolve.
32404 * typemanager.cs (CSharpName): Update to check for the string type and return
32407 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32410 2001-09-21 Ravi Pratap <ravi@ximian.com>
32412 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32413 (Invocation::BetterFunction): Implement.
32414 (Invocation::BetterConversion): Implement.
32415 (Invocation::ConversionExists): Skeleton, no implementation yet.
32417 Okay, things work fine !
32419 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32421 * typemanager.cs: declare and load enum_type, delegate_type and
32424 * expression.cs (Expression::Emit): Now emit returns a value that
32425 tells whether a value is left on the stack or not. This strategy
32426 might be reveted tomorrow with a mechanism that would address
32427 multiple assignments.
32428 (Expression::report118): Utility routine to report mismatches on
32431 (Unary::Report23): Report impossible type/operator combination
32434 (Unary::IsIncrementableNumber): Whether the type can be
32435 incremented or decremented with add.
32436 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32438 (Unary::ResolveOperator): Implement ++, !, ~,
32440 (Invocation::Emit): Deal with new Emit convetion.
32442 * All Expression derivatives: Updated their Emit method to return
32443 whether they leave values on the stack or not.
32445 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32446 stack for expressions that are statements.
32448 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32450 * expression.cs (LValue): New interface. Must be implemented by
32452 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32455 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32456 interface for generating code, simplifies the code.
32458 2001-09-20 Ravi Pratap <ravi@ximian.com>
32460 * expression.cs (everywhere): Comment out return statements in ::Resolve
32461 methods to avoid the warnings.
32463 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32465 * driver.cs (parse): Report error 2001 if we can not open the
32468 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32471 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32474 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32475 otherwise nested blocks end up with the same index.
32477 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32479 * expression.cs: Instead of having FIXMEs in the Resolve
32480 functions, throw exceptions so it is obvious that we are facing a
32483 * cs-parser.jay (invocation_expression): Pass Location information.
32485 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32486 Use a basename for those routines because .NET does not like paths
32489 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32492 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32494 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32495 are loading the correct data types (throws an exception if not).
32496 (TypeManager::InitCoreTypes): Use CoreLookupType
32498 * expression.cs (Unary::ResolveOperator): return the child
32499 expression for expressions which are just +expr.
32500 (Unary::ResolveOperator): Return negative literals for -LITERAL
32501 expressions (otherwise they are Unary {Literal}).
32502 (Invocation::Badness): Take into account `Implicit constant
32503 expression conversions'.
32505 * literal.cs (LongLiteral): Implement long literal class.
32506 (IntLiteral): export the `Value' of the intliteral.
32508 2001-09-19 Ravi Pratap <ravi@ximian.com>
32510 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32512 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32513 instead of 'Operator'
32515 * expression.cs (Binary::ResolveOperator): Update accordingly.
32516 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32519 * cs-parser.jay (unary_expression): Update to use the new names.
32521 * gen-treedump.cs (GetUnary): Same here.
32523 * expression.cs (Unary::Resolve): Implement.
32524 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32525 operators are found instead of making noise ;-)
32526 (Unary::ResolveOperator): New method to do precisely the same thing which
32527 Binary::ResolveOperator does for Binary expressions.
32528 (Unary.method, .Arguments): Add.
32529 (Unary::OperName): Implement.
32530 (Unary::ForceConversion): Copy and Paste !
32532 * class.cs (Operator::Define): Fix a small bug for the case when we have
32535 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32536 for the inbuilt operators. Only overloading works for now ;-)
32538 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32540 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32541 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32543 * expression.cs (This::Emit): Implement.
32544 (This::Resolve): Implement.
32545 (TypeOf:Resolve): Implement.
32546 (Expression::ResolveSimpleName): Add an implicit this to instance
32548 (MemberAccess::Resolve): Deal with Parameters and Fields.
32549 Bind instance variable to Field expressions.
32550 (FieldExpr::Instance): New field used to track the expression that
32551 represents the object instance.
32552 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32554 (FieldExpr::Emit): Implement.
32556 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32557 the last instruction contains a return opcode to avoid generating
32558 the last `ret' instruction (this generates correct code, and it is
32559 nice to pass the peverify output).
32561 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32562 initializer for static and instance variables.
32563 (Constructor::Emit): Allow initializer to be null in the case of
32564 static constructors. Only emit initializer for instance
32567 (TypeContainer::FindMembers): Return a null array if there are no
32570 Also fix the code for the MemberTypes.Method branch, as it was not
32571 scanning that for operators (or tried to access null variables before).
32573 * assign.cs (Assign::Emit): Handle instance and static fields.
32577 * driver.cs: Stop compilation if there are parse errors.
32579 * cs-parser.jay (constructor_declaration): Provide default base
32580 initializer for non-static constructors.
32581 (constructor_declarator): Do not provide a default base
32582 initializers if none was specified.
32583 Catch the fact that constructors should not have parameters.
32585 * class.cs: Do not emit parent class initializers for static
32586 constructors, that should be flagged as an error.
32588 2001-09-18 Ravi Pratap <ravi@ximian.com>
32590 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32591 Move back code into TypeContainer::Populate.
32593 2001-09-18 Ravi Pratap <ravi@ximian.com>
32595 * class.cs (TypeContainer::AddConstructor): Fix the check to
32596 compare against Name, not Basename.
32597 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32599 * cs-parser.jay : Update accordingly.
32601 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32602 for methods, don't forget to look into the operators too.
32603 (RegisterMethodBuilder): Helper method to take care of this for
32604 methods, constructors and operators.
32605 (Operator::Define): Completely revamp.
32606 (Operator.OperatorMethod, MethodName): New fields.
32607 (TypeContainer::Populate): Move the registering of builders into
32608 RegisterMethodBuilder.
32609 (Operator::Emit): Re-write.
32611 * expression.cs (Binary::Emit): Comment out code path to emit method
32612 invocation stuff for the case when we have a user defined operator. I am
32613 just not able to get it right !
32615 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32617 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32620 (Expression::MemberLookup): Provide a version that allows to
32621 specify the MemberTypes and BindingFlags.
32623 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32624 so it was not fetching variable information from outer blocks.
32626 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32627 Beforefieldinit as it was buggy.
32629 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32630 that Ravi put here.
32632 * class.cs (Constructor::Emit): Only emit if block is not null.
32633 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32634 deal with this by semantically definining it as if the user had
32637 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32638 constructors as we now "emit" them at a higher level.
32640 (TypeContainer::DefineDefaultConstructor): Used to define the
32641 default constructors if none was provided.
32643 (ConstructorInitializer): Add methods Resolve and Emit.
32645 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32647 2001-09-17 Ravi Pratap <ravi@ximian.com>
32649 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32650 the default constructor builder with our hashtable for methodbuilders
32653 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32654 and argument_count is 0 in which case we have a match.
32655 (Binary::ResolveOperator): More null checking and miscellaneous coding
32658 2001-09-17 Ravi Pratap <ravi@ximian.com>
32660 * rootcontext.cs (IsNameSpace): Compare against null.
32662 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32664 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32665 and Unary::Operator.
32667 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32670 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32671 we have overloaded operators.
32672 (Binary::ResolveOperator): Implement the part which does the operator overload
32675 * class.cs (Operator::Emit): Implement.
32676 (TypeContainer::Emit): Emit the operators we have too.
32678 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32679 the case when we have a user-defined operator.
32681 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32683 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32685 2001-09-16 Ravi Pratap <ravi@ximian.com>
32687 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32688 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32689 (Constructor::Emit): Implement.
32690 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32691 if we have no work to do.
32692 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32695 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32696 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32698 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32701 2001-09-15 Ravi Pratap <ravi@ximian.com>
32703 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32705 (Tree::RecordNamespace): Method to do what the name says ;-)
32706 (Tree::Namespaces): Property to get at the namespaces hashtable.
32708 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32711 * rootcontext.cs (IsNamespace): Fixed it :-)
32713 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32715 * class.cs (TypeContainer::FindMembers): Add support for
32717 (MethodCore): New class that encapsulates both the shared aspects
32718 of a Constructor and a Method.
32719 (Method, Constructor): Factored pieces into MethodCore.
32721 * driver.cs: Added --fatal which makes errors throw exceptions.
32722 Load System assembly as well as part of the standard library.
32724 * report.cs: Allow throwing exceptions on errors for debugging.
32726 * modifiers.cs: Do not use `parent', instead use the real type
32727 container to evaluate permission settings.
32729 * class.cs: Put Ravi's patch back in. He is right, and we will
32730 have to cope with the
32732 2001-09-14 Ravi Pratap <ravi@ximian.com>
32734 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32735 FamORAssem, not FamANDAssem.
32737 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32739 * driver.cs: Added --parse option that only parses its input files
32742 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32743 incorrect. IsTopLevel is not used to tell whether an object is
32744 root_types or not (that can be achieved by testing this ==
32745 root_types). But to see if this is a top-level *class* (not
32746 necessarly our "toplevel" container).
32748 2001-09-14 Ravi Pratap <ravi@ximian.com>
32750 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32751 parent instead of a direct call to GetType.
32753 2001-09-14 Ravi Pratap <ravi@ximian.com>
32755 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32756 Modifiers.TypeAttr. This should just be a call to that method.
32758 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32759 object so that we can determine if we are top-level or not.
32761 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32764 * enum.cs (Enum::Define): Ditto.
32766 * modifiers.cs (FieldAttr): Re-write.
32768 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32769 (TypeContainer::HaveStaticConstructor): New property to provide access
32770 to precisely that info.
32772 * modifiers.cs (MethodAttr): Re-write.
32773 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32775 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32776 of top-level types as claimed.
32778 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32780 * expression.cs (MemberLookup): Fruitless attempt to lookup
32781 constructors. Maybe I need to emit default constructors? That
32782 might be it (currently .NET emits this for me automatically).
32783 (Invocation::OverloadResolve): Cope with Arguments == null.
32784 (Invocation::EmitArguments): new function, shared by the new
32785 constructor and us.
32786 (Invocation::Emit): Handle static and instance methods. Emit
32787 proper call instruction for virtual or non-virtual invocations.
32788 (New::Emit): Implement.
32789 (New::Resolve): Implement.
32790 (MemberAccess:Resolve): Implement.
32791 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32792 to track instances.
32793 (FieldExpr::Resolve): Set type.
32795 * support.cs: Handle empty arguments.
32797 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32798 SimpleLookup): Auxiliary routines to help parse a qualifier
32801 Update qualifier_identifier rule.
32803 * codegen.cs: Removed debugging messages.
32805 * class.cs: Make this a global thing, this acts just as a "key" to
32806 objects that we might have around.
32808 (Populate): Only initialize method_builders_to_methods once.
32810 * expression.cs (PropertyExpr): Initialize type from the
32813 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32814 Resolve pattern. Attempt to implicitly convert value to boolean.
32817 * expression.cs: Set the type for the int32/int32 argument case.
32818 (Binary::ResolveOperator): Set the return type to boolean for
32819 comparission operators
32821 * typemanager.cs: Remove debugging print code.
32823 (Invocation::Resolve): resolve type.
32825 * class.cs: Allocate a MemberInfo of the correct size, as the code
32826 elsewhere depends on the test to reflect the correct contents.
32828 (Method::) Keep track of parameters, due to System.Reflection holes
32830 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32833 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32834 of the exact size and return that.
32836 (Class::LookupMethodByBuilder): New function that maps
32837 MethodBuilders to its methods. Required to locate the information
32838 on methods because System.Reflection bit us again.
32840 * support.cs: New file, contains an interface ParameterData and
32841 two implementations: ReflectionParameters and InternalParameters
32842 used to access Parameter information. We will need to grow this
32845 * expression.cs (Invocation::GetParameterData): implement a cache
32846 and a wrapper around the ParameterData creation for methods.
32847 (Invocation::OverloadResolve): Use new code.
32849 2001-09-13 Ravi Pratap <ravi@ximian.com>
32851 * class.cs (TypeContainer::EmitField): Remove and move into
32852 (Field::Define): here and modify accordingly.
32853 (Field.FieldBuilder): New member.
32854 (TypeContainer::Populate): Update accordingly.
32855 (TypeContainer::FindMembers): Implement.
32857 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32859 * statement.cs: (VariableInfo::VariableType): New field to be
32860 initialized with the full type once it is resolved.
32862 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32864 * parameter.cs (GetParameterInfo): Use a type cache to compute
32865 things only once, and to reuse this information
32867 * expression.cs (LocalVariableReference::Emit): Implement.
32868 (OpcodeCast::Emit): fix.
32870 (ParameterReference::Resolve): Implement.
32871 (ParameterReference::Emit): Implement.
32873 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32874 that are expressions need to stay as Expressions.
32876 * typemanager.cs (CSharpName): Returns the C# name of a type if
32879 * expression.cs (Expression::ConvertImplicit): New function that
32880 implements implicit type conversions.
32882 (Expression::ImplicitReferenceConversion): Implements implicit
32883 reference conversions.
32885 (EmptyCast): New type for transparent casts.
32887 (OpcodeCast): New type for casts of types that are performed with
32888 a sequence of bytecodes.
32890 (BoxedCast): New type used for casting value types into reference
32891 types. Emits a box opcode.
32893 (Binary::DoNumericPromotions): Implements numeric promotions of
32894 and computation of the Binary::Type.
32896 (Binary::EmitBranchable): Optimization.
32898 (Binary::Emit): Implement code emission for expressions.
32900 * typemanager.cs (TypeManager): Added two new core types: sbyte
32903 2001-09-12 Ravi Pratap <ravi@ximian.com>
32905 * class.cs (TypeContainer::FindMembers): Method which does exactly
32906 what Type.FindMembers does, only we don't have to use reflection. No
32907 implementation yet.
32909 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32910 typecontainer objects as we need to get at them.
32911 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32913 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32914 typecontainer object.
32916 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32917 of just a Report object.
32919 2001-09-11 Ravi Pratap <ravi@ximian.com>
32921 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32923 (TypeContainer::Populate): Now define the delegates of the type too.
32924 (TypeContainer.Delegates): Property to access the list of delegates defined
32927 * delegates.cs (Delegate::Define): Implement partially.
32929 * modifiers.cs (TypeAttr): Handle more flags.
32931 2001-09-11 Ravi Pratap <ravi@ximian.com>
32933 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32935 (Operator::Define): Re-write logic to get types by using the LookupType method
32936 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32937 (Indexer::Define): Ditto.
32938 (Event::Define): Ditto.
32939 (Property::Define): Ditto.
32941 2001-09-10 Ravi Pratap <ravi@ximian.com>
32943 * class.cs (TypeContainer::Populate): Now define operators too.
32944 (TypeContainer.Operators): New property to access the list of operators
32946 (Operator.OperatorMethodBuilder): New member to hold the method builder
32947 for the operator we are defining.
32948 (Operator::Define): Implement.
32950 2001-09-10 Ravi Pratap <ravi@ximian.com>
32952 * class.cs (Event::Define): Make the prefixes of the accessor methods
32953 addOn_ and removeOn_
32955 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32956 of the location being passed in too. Ideally, this should go later since all
32957 error reporting should be done through the Report object.
32959 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32960 (Populate): Iterate thru the indexers we have and define them too.
32961 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32962 for the get and set accessors.
32963 (Indexer::Define): Implement.
32965 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32967 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32968 my previous implementation, did not work.
32970 * typemanager.cs: Add a couple of missing types (the longs).
32972 * literal.cs: Use TypeManager.bool_type instead of getting it.
32974 * expression.cs (EventExpr): New kind of expressions.
32975 (Expressio::ExprClassFromMemberInfo): finish
32977 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32979 * assign.cs: Emit stores to static fields differently.
32981 2001-09-08 Ravi Pratap <ravi@ximian.com>
32983 * Merge in changes and adjust code to tackle conflicts. Backed out my
32984 code in Assign::Resolve ;-)
32986 2001-09-08 Ravi Pratap <ravi@ximian.com>
32988 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32989 instead Report.Error and also pass in the location.
32990 (CSharpParser::Lexer): New readonly property to return the reference
32991 to the Tokenizer object.
32992 (declare_local_variables): Use Report.Error with location instead of plain
32996 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32997 (Operator.CheckBinaryOperator): Ditto.
32999 * cs-parser.jay (operator_declarator): Update accordingly.
33001 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33002 (CheckBinaryOperator): Same here.
33004 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33005 on the name without any prefixes of namespace names etc. This is because we
33006 already might have something already fully qualified like
33007 'System.Console.WriteLine'
33009 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33011 2001-09-07 Ravi Pratap <ravi@ximian.com>
33013 * cs-tokenizer.cs (location): Return a string which also contains
33016 * expression.cs (ElementAccess): New class for expressions of the
33017 type 'element access.'
33018 (BaseAccess): New class for expressions of the type 'base access.'
33019 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33022 * cs-parser.jay (element_access): Implement action.
33023 (base_access): Implement actions.
33024 (checked_expression, unchecked_expression): Implement.
33026 * cs-parser.jay (local_variable_type): Correct and implement.
33027 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33029 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33031 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33032 name and the specifiers.
33034 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33036 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33037 making them all public ;-)
33039 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33042 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33044 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33046 (FieldExpr, PropertyExprs): New resolved expressions.
33047 (SimpleName::MemberStaticCheck): Perform static checks for access
33048 to non-static fields on static methods. Maybe this should be
33049 generalized for MemberAccesses.
33050 (SimpleName::ResolveSimpleName): More work on simple name
33053 * cs-parser.jay (primary_expression/qualified_identifier): track
33054 the parameter index.
33056 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33057 (EmitContext::EmitBoolExpression): Chain to expression generation
33058 instead of temporary hack.
33059 (::EmitStatementExpression): Put generic expression code generation.
33061 * assign.cs (Assign::Emit): Implement variable assignments to
33062 local variables, parameters and fields.
33064 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33066 * statement.cs (Block::GetVariableInfo): New method, returns the
33067 VariableInfo for a variable name in a block.
33068 (Block::GetVariableType): Implement in terms of GetVariableInfo
33070 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33071 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33073 2001-09-06 Ravi Pratap <ravi@ximian.com>
33075 * cs-parser.jay (operator_declaration): Continue on my quest : update
33076 to take attributes argument.
33077 (event_declaration): Ditto.
33078 (enum_declaration): Ditto.
33079 (indexer_declaration): Ditto.
33081 * class.cs (Operator::Operator): Update constructor accordingly.
33082 (Event::Event): Ditto.
33084 * delegate.cs (Delegate::Delegate): Same here.
33086 * enum.cs (Enum::Enum): Same here.
33088 2001-09-05 Ravi Pratap <ravi@ximian.com>
33090 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33092 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33094 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33095 being passed around as an arraylist.
33096 (Attributes::AddAttribute): Method to add attribute sections.
33098 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33099 (struct_declaration): Update accordingly.
33100 (constant_declaration): Update.
33101 (field_declaration): Update.
33102 (method_header): Update.
33103 (fixed_parameter): Update.
33104 (parameter_array): Ditto.
33105 (property_declaration): Ditto.
33106 (destructor_declaration): Ditto.
33108 * class.cs (Struct::Struct): Update constructors accordingly.
33109 (Class::Class): Ditto.
33110 (Field::Field): Ditto.
33111 (Method::Method): Ditto.
33112 (Property::Property): Ditto.
33113 (TypeContainer::OptAttribute): update property's return type.
33115 * interface.cs (Interface.opt_attributes): New member.
33116 (Interface::Interface): Update to take the extra Attributes argument.
33118 * parameter.cs (Parameter::Parameter): Ditto.
33120 * constant.cs (Constant::Constant): Ditto.
33122 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33123 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33124 the attributes as a parameter.
33125 (InterfaceProperty): Update constructor call.
33126 (InterfaceEvent): Ditto.
33127 (InterfaceMethod): Ditto.
33128 (InterfaceIndexer): Ditto.
33130 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33131 pass the attributes too.
33132 (interface_event_declaration): Ditto.
33133 (interface_property_declaration): Ditto.
33134 (interface_method_declaration): Ditto.
33135 (interface_declaration): Ditto.
33137 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33139 * class.cs (Method::Define): Track the "static Main" definition to
33140 create an entry point.
33142 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33143 EntryPoint if we find it.
33145 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33146 (EmitContext::ig): Make this variable public.
33148 * driver.cs: Make the default output file be the first file name
33149 with the .exe extension.
33151 Detect empty compilations
33153 Handle various kinds of output targets. Handle --target and
33154 rename -t to --dumper.
33156 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33157 methods inherited from Expression return now an Expression. This
33158 will is used during the tree rewriting as we resolve them during
33161 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33162 the spec. Missing entirely is the information about
33163 accessability of elements of it.
33165 (Expression::ExprClassFromMemberInfo): New constructor for
33166 Expressions that creates a fully initialized Expression based on
33167 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33170 (Invocation::Resolve): Begin implementing resolution of invocations.
33172 * literal.cs (StringLiteral): Implement Emit.
33174 2001-09-05 Ravi Pratap <ravi@ximian.com>
33176 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33179 2001-09-04 Ravi Pratap <ravi@ximian.com>
33181 * cs-parser.jay (attribute_arguments): Implement actions.
33182 (attribute): Fix bug in production. Implement action.
33183 (attribute_list): Implement.
33184 (attribute_target): Implement.
33185 (attribute_target_specifier, opt_target_specifier): Implement
33186 (CheckAttributeTarget): New method to check if the attribute target
33188 (attribute_section): Implement.
33189 (opt_attributes): Implement.
33191 * attribute.cs : New file to handle attributes.
33192 (Attribute): Class to hold attribute info.
33194 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33195 (attribute_section): Modify production to use 2 different rules to
33196 achieve the same thing. 1 s/r conflict down !
33197 Clean out commented, useless, non-reducing dimension_separator rules.
33199 * class.cs (TypeContainer.attributes): New member to hold list
33200 of attributes for a type.
33201 (Struct::Struct): Modify to take one more argument, the attribute list.
33202 (Class::Class): Ditto.
33203 (Field::Field): Ditto.
33204 (Method::Method): Ditto.
33205 (Property::Property): Ditto.
33207 * cs-parser.jay (struct_declaration): Update constructor call to
33208 pass in the attributes too.
33209 (class_declaration): Ditto.
33210 (constant_declaration): Ditto.
33211 (field_declaration): Ditto.
33212 (method_header): Ditto.
33213 (fixed_parameter): Ditto.
33214 (parameter_array): Ditto.
33215 (property_declaration): Ditto.
33217 * constant.cs (Constant::Constant): Update constructor similarly.
33218 Use System.Collections.
33220 * parameter.cs (Parameter::Parameter): Update as above.
33222 2001-09-02 Ravi Pratap <ravi@ximian.com>
33224 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33225 (TypeContainer.delegates): New member to hold list of delegates.
33227 * cs-parser.jay (delegate_declaration): Implement the action correctly
33228 this time as I seem to be on crack ;-)
33230 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33232 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33233 tell whether an identifier represents a namespace.
33235 * expression.cs (NamespaceExpr): A namespace expression, used only
33236 temporarly during expression resolution.
33237 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33238 utility functions to resolve names on expressions.
33240 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33242 * codegen.cs: Add hook for StatementExpressions.
33244 * class.cs: Fix inverted test for static flag in methods.
33246 2001-09-02 Ravi Pratap <ravi@ximian.com>
33248 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33249 to make it coincide with MS' number.
33250 (Operator::CheckBinaryOperator): Ditto.
33252 * ../errors/errors.txt : Remove error numbers added earlier.
33254 * ../errors/cs1019.cs : Test case for error # 1019
33256 * ../errros/cs1020.cs : Test case for error # 1020
33258 * cs-parser.jay : Clean out commented cruft.
33259 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33260 used anywhere - non-reducing rule.
33261 (namespace_declarations): Non-reducing rule - comment out.
33263 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33264 with TypeContainer::AddEnum.
33266 * delegate.cs : New file for delegate handling classes.
33267 (Delegate): Class for declaring delegates.
33269 * makefile : Update.
33271 * cs-parser.jay (delegate_declaration): Implement.
33273 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33275 * class.cs (Event::Define): Implement.
33276 (Event.EventBuilder): New member.
33278 * class.cs (TypeContainer::Populate): Update to define all enums and events
33280 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33281 readonly fields for all these cases ?
33283 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33285 * class.cs (Property): Revamp to use the convention of making fields readonly.
33286 Accordingly modify code elsewhere.
33288 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33289 the Define method of the Property class.
33291 * class.cs : Clean up applied patch and update references to variables etc. Fix
33293 (TypeContainer::Populate): Update to define all the properties we have. Also
33294 define all enumerations.
33296 * enum.cs (Define): Implement.
33298 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33300 * cs-parser.jay (overloadable_operator): The semantic value is an
33301 enum of the Operator class.
33302 (operator_declarator): Implement actions.
33303 (operator_declaration): Implement.
33305 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33306 validity of definitions.
33307 (Operator::CheckBinaryOperator): Static method to check for binary operators
33308 (TypeContainer::AddOperator): New method to add an operator to a type.
33310 * cs-parser.jay (indexer_declaration): Added line to actually call the
33311 AddIndexer method so it gets added ;-)
33313 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33314 already taken care of by the MS compiler ?
33316 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33318 * class.cs (Operator): New class for operator declarations.
33319 (Operator::OpType): Enum for the various operators.
33321 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33323 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33324 ostensibly handle this in semantic analysis.
33326 * cs-parser.jay (general_catch_clause): Comment out
33327 (specific_catch_clauses, specific_catch_clause): Ditto.
33328 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33329 (catch_args, opt_catch_args): New productions.
33330 (catch_clause): Rewrite to use the new productions above
33331 (catch_clauses): Modify accordingly.
33332 (opt_catch_clauses): New production to use in try_statement
33333 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33334 and re-write the code in the actions to extract the specific and
33335 general catch clauses by being a little smart ;-)
33337 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33338 Hooray, try and catch statements parse fine !
33340 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33342 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33343 string from the hashtable of variables.
33345 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33346 I end up making that mistake ;-)
33347 (catch_clauses): Fixed gross error which made Key and Value of the
33348 DictionaryEntry the same : $1 !!
33350 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33352 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33354 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33355 when the add and remove accessors are specified.
33357 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33359 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33360 information about indexer_declarator.
33361 (indexer_declarator): Implement actions.
33362 (parsing_indexer): New local boolean used to keep track of whether
33363 we are parsing indexers or properties. This is necessary because
33364 implicit_parameters come into picture even for the get accessor in the
33365 case of an indexer.
33366 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33368 * class.cs (Indexer): New class for indexer declarations.
33369 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33370 (TypeContainer::indexers): New member to hold list of indexers for the
33373 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33375 * cs-parser.jay (add_accessor_declaration): Implement action.
33376 (remove_accessor_declaration): Implement action.
33377 (event_accessors_declaration): Implement
33378 (variable_declarators): swap statements for first rule - trivial.
33380 * class.cs (Event): New class to hold information about event
33382 (TypeContainer::AddEvent): New method to add an event to a type
33383 (TypeContainer::events): New member to hold list of events.
33385 * cs-parser.jay (event_declaration): Implement actions.
33387 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33389 * cs-parser.jay (dim_separators): Implement. Make it a string
33390 concatenating all the commas together, just as they appear.
33391 (opt_dim_separators): Modify accordingly
33392 (rank_specifiers): Update accordingly. Basically do the same
33393 thing - instead, collect the brackets here.
33394 (opt_rank_sepcifiers): Modify accordingly.
33395 (array_type): Modify to actually return the complete type string
33396 instead of ignoring the rank_specifiers.
33397 (expression_list): Implement to collect the expressions
33398 (variable_initializer): Implement. We make it a list of expressions
33399 essentially so that we can handle the array_initializer case neatly too.
33400 (variable_initializer_list): Implement.
33401 (array_initializer): Make it a list of variable_initializers
33402 (opt_array_initializer): Modify accordingly.
33404 * expression.cs (New::NType): Add enumeration to help us
33405 keep track of whether we have an object/delegate creation
33406 or an array creation.
33407 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33408 members to hold data about array creation.
33409 (New:New): Modify to update NewType
33410 (New:New): New Overloaded contructor for the array creation
33413 * cs-parser.jay (array_creation_expression): Implement to call
33414 the overloaded New constructor.
33416 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33418 * class.cs (TypeContainer::Constructors): Return member
33419 constructors instead of returning null.
33421 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33423 * typemanager.cs (InitCoreTypes): Initialize the various core
33424 types after we have populated the type manager with the user
33425 defined types (this distinction will be important later while
33426 compiling corlib.dll)
33428 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33429 on Expression Classification. Now all expressions have a method
33430 `Resolve' and a method `Emit'.
33432 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33433 generation from working. Also add some temporary debugging
33436 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33438 * codegen.cs: Lots of code generation pieces. This is only the
33439 beginning, will continue tomorrow with more touches of polish. We
33440 handle the fundamentals of if, while, do, for, return. Others are
33441 trickier and I need to start working on invocations soon.
33443 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33446 * codegen.cs (EmitContext): New struct, used during code
33447 emission to keep a context. Most of the code generation will be
33450 * cs-parser.jay: Add embedded blocks to the list of statements of
33451 this block. So code generation proceeds in a top down fashion.
33453 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33455 * statement.cs: Add support for multiple child blocks.
33457 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33459 * codegen.cs (EmitCode): New function, will emit the code for a
33460 Block of code given a TypeContainer and its ILGenerator.
33462 * statement.cs (Block): Standard public readonly optimization.
33463 (Block::Block constructors): Link children.
33464 (Block::Child): Child Linker.
33465 (Block::EmitVariables): Emits IL variable declarations.
33467 * class.cs: Drop support for MethodGroups here, delay until
33469 (Method::): Applied the same simplification that I did before, and
33470 move from Properties to public readonly fields.
33471 (Method::ParameterTypes): Returns the parameter types for the
33472 function, and implements a cache that will be useful later when I
33473 do error checking and the semantic analysis on the methods is
33475 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33476 and made a method, optional argument tells whether this is a class
33477 or a structure to apply the `has-this' bit.
33478 (Method::GetCallingConvention): Implement, returns the calling
33480 (Method::Define): Defines the type, a second pass is performed
33481 later to populate the methods.
33483 (Constructor::ParameterTypes): implement a cache similar to the
33484 one on Method::ParameterTypes, useful later when we do semantic
33487 (TypeContainer::EmitMethod): New method. Emits methods.
33489 * expression.cs: Removed MethodGroup class from here.
33491 * parameter.cs (Parameters::GetCallingConvention): new method.
33493 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33495 * class.cs (TypeContainer::Populate): Drop RootContext from the
33498 (Constructor::CallingConvention): Returns the calling convention.
33499 (Constructor::ParameterTypes): Returns the constructor parameter
33502 (TypeContainer::AddConstructor): Keep track of default constructor
33503 and the default static constructor.
33505 (Constructor::) Another class that starts using `public readonly'
33506 instead of properties.
33508 (Constructor::IsDefault): Whether this is a default constructor.
33510 (Field::) use readonly public fields instead of properties also.
33512 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33513 track of static constructors; If none is used, turn on
33514 BeforeFieldInit in the TypeAttributes.
33516 * cs-parser.jay (opt_argument_list): now the return can be null
33517 for the cases where there are no arguments.
33519 (constructor_declarator): If there is no implicit `base' or
33520 `this', then invoke the default parent constructor.
33522 * modifiers.cs (MethodAttr): New static function maps a set of
33523 modifiers flags into a MethodAttributes enum
33524 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33525 MethodAttr, TypeAttr to represent the various mappings where the
33526 modifiers are used.
33527 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33529 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33531 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33534 * interface.cs (PopulateIndexer): Implemented the code generator
33535 for interface indexers.
33537 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33539 * interface.cs (InterfaceMemberBase): Now we track the new status
33542 (PopulateProperty): Implement property population. Woohoo! Got
33543 Methods and Properties going today.
33545 Removed all the properties for interfaces, and replaced them with
33546 `public readonly' fields.
33548 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33550 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33551 initialize their hashtables/arraylists only when they are needed
33552 instead of doing this always.
33554 * parameter.cs: Handle refs and out parameters.
33556 * cs-parser.jay: Use an ArrayList to construct the arguments
33557 instead of the ParameterCollection, and then cast that to a
33560 * parameter.cs: Drop the use of ParameterCollection and use
33561 instead arrays of Parameters.
33563 (GetParameterInfo): Use the Type, not the Name when resolving
33566 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33568 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33569 and instead use public readonly fields.
33571 * class.cs: Put back walking code for type containers.
33573 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33575 * class.cs (MakeConstant): Code to define constants.
33577 * rootcontext.cs (LookupType): New function. Used to locate types
33580 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33582 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33583 this System.Reflection code is. Kudos to Microsoft
33585 * typemanager.cs: Implement a type cache and avoid loading all
33586 types at boot time. Wrap in LookupType the internals. This made
33587 the compiler so much faster. Wow. I rule!
33589 * driver.cs: Make sure we always load mscorlib first (for
33590 debugging purposes, nothing really important).
33592 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33593 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33595 * rootcontext.cs: Lookup types on their namespace; Lookup types
33596 on namespaces that have been imported using the `using' keyword.
33598 * class.cs (TypeContainer::TypeAttr): Virtualize.
33599 (Class::TypeAttr): Return attributes suitable for this bad boy.
33600 (Struct::TypeAttr): ditto.
33601 Handle nested classes.
33602 (TypeContainer::) Remove all the type visiting code, it is now
33603 replaced with the rootcontext.cs code
33605 * rootcontext.cs (GetClassBases): Added support for structs.
33607 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33609 * interface.cs, statement.cs, class.cs, parameter.cs,
33610 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33611 Drop use of TypeRefs, and use strings instead.
33613 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33617 * class.cs (Struct::Struct): set the SEALED flags after
33618 checking the modifiers.
33619 (TypeContainer::TypeAttr): new property, returns the
33620 TypeAttributes for a class.
33622 * cs-parser.jay (type_list): Oops, list production was creating a
33623 new list of base types.
33625 * rootcontext.cs (StdLib): New property.
33626 (GetInterfaceTypeByName): returns an interface by type name, and
33627 encapsulates error handling here.
33628 (GetInterfaces): simplified.
33629 (ResolveTree): Encapsulated all the tree resolution here.
33630 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33633 * driver.cs: Add support for --nostdlib, to avoid loading the
33634 default assemblies.
33635 (Main): Do not put tree resolution here.
33637 * rootcontext.cs: Beginning of the class resolution.
33639 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33641 * rootcontext.cs: Provide better error reporting.
33643 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33645 * rootcontext.cs (CreateInterface): Handle the case where there
33646 are no parent interfaces.
33648 (CloseTypes): Routine to flush types at the end.
33649 (CreateInterface): Track types.
33650 (GetInterfaces): Returns an array of Types from the list of
33651 defined interfaces.
33653 * typemanager.c (AddUserType): Mechanism to track user types (puts
33654 the type on the global type hash, and allows us to close it at the
33657 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33659 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33660 RecordInterface instead.
33662 * cs-parser.jay: Updated to reflect changes above.
33664 * decl.cs (Definition): Keep track of the TypeBuilder type that
33665 represents this type here. Not sure we will use it in the long
33666 run, but wont hurt for now.
33668 * driver.cs: Smaller changes to accomodate the new code.
33670 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33673 * rootcontext.cs (CreateInterface): New method, used to create
33674 the System.TypeBuilder type for interfaces.
33675 (ResolveInterfaces): new entry point to resolve the interface
33677 (CodeGen): Property, used to keep track of the code generator.
33679 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33681 * cs-parser.jay: Add a second production for delegate_declaration
33684 (enum_body): Put an opt_comma here instead of putting it on
33685 enum_body or enum_member_declarations so we can handle trailing
33686 commas on enumeration members. Gets rid of a shift/reduce.
33688 (type_list): Need a COMMA in the middle.
33690 (indexer_declaration): Tell tokenizer to recognize get/set
33692 * Remove old targets.
33694 * Re-add the parser target.
33696 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33698 * cs-parser.jay: Add precendence rules for a number of operators
33699 ot reduce the number of shift/reduce conflicts in the grammar.
33701 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33703 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33706 Get rid of old crufty code.
33708 * rootcontext.cs: Use this to keep track of the parsed
33709 representation and the defined types available to the program.
33711 * gen-treedump.cs: adjust for new convention.
33713 * type.cs: Split out the type manager, and the assembly builder
33716 * typemanager.cs: the type manager will live here now.
33718 * cil-codegen.cs: And the code generator here.
33720 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33722 * makefile: Fixed up for easy making.
33724 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33726 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33729 (unary_expression): Expand pre_increment_expression and
33730 post_decrement_expression to reduce a shift/reduce.
33732 2001-07-11 Simon Cozens
33734 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33736 Improve allow_keyword_as_indent name.
33738 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33740 * Adjustments for Beta2.
33742 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33744 * decl.cs: Added `Define' abstract method.
33745 (InTransit): new property, used to catch recursive definitions.
33747 * interface.cs: Implement `Define'.
33749 * modifiers.cs: Map Modifiers.constants to
33750 System.Reflection.TypeAttribute flags.
33752 * class.cs: Keep track of types and user-defined types.
33753 (BuilderInit): New method for creating an assembly
33754 (ResolveType): New function to launch the resolution process, only
33755 used by interfaces for now.
33757 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33758 that are inserted into the name space.
33760 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33762 * ARGH. I have screwed up my tree so many times due to the use of
33763 rsync rather than using CVS. Going to fix this at once.
33765 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33768 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33770 * Experiment successful: Use System.Type rather that our own
33773 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33775 * cs-parser.jay: Removed nsAliases from here.
33777 Use new namespaces, handle `using XXX;'
33779 * namespace.cs: Reimplemented namespace handling, use a recursive
33780 definition of the class. Now we can keep track of using clauses
33781 and catch invalid using clauses.
33783 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33785 * gen-treedump.cs: Adapted for all the renaming.
33787 * expression.cs (Expression): this class now has a Type property
33788 which returns an expression Type.
33790 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33791 `Type', as this has a different meaning now in the base
33793 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33795 * interface.cs, class.cs: Removed from all the sources the
33796 references to signature computation, as we can not do method
33797 signature computation during the parsing time, as we are not
33798 trying to solve at that point distinguishing:
33802 void a (NS.Blah x) {}
33805 Which depending on the context might be valid or not, as we do not
33806 know if Blah is the same thing as NS.Blah at that point.
33808 * Redid everything so the code uses TypeRefs now instead of
33809 Types. TypeRefs are just temporary type placeholders, that need
33810 to be resolved. They initially have a pointer to a string and the
33811 current scope in which they are used. This is used later by the
33812 compiler to resolve the reference to an actual Type.
33814 * DeclSpace is no longer a CIR.Type, and neither are
33815 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33816 are all DeclSpaces, but no Types.
33818 * type.cs (TypeRefManager): This implements the TypeRef manager,
33819 which keeps track of all the types that need to be resolved after
33820 the parsing has finished.
33822 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33824 * ARGH. We are going to have to store `foreach' as a class rather
33825 than resolving it, as we need to verify error 1579 after name
33826 resolution. *OR* we could keep a flag that says `This request to
33827 IEnumerator comes from a foreach statement' which we can then use
33828 to generate the error.
33830 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33832 * class.cs (TypeContainer.AddMethod): we now add methods to the
33833 MethodGroup instead of the method hashtable.
33835 * expression.cs: Add MethodGroup abstraction, which gets us one
33836 step closer to the specification in the way we handle method
33839 * cs-parser.jay (primary_expression): qualified_identifier now
33840 tried to match up an identifier to a local variable reference or
33841 to a parameter reference.
33843 current_local_parameters is now a parser global variable that
33844 points to the current parameters for the block, used during name
33847 (property_declaration): Now creates an implicit `value' argument to
33850 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33852 * parameter.cs: Do not use `param' arguments as part of the
33853 signature, per the spec.
33855 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33857 * decl.cs: Base class for classes, structs and interfaces. This
33858 is the "Declaration Space"
33860 * cs-parser.jay: Use CheckDef for checking declaration errors
33861 instead of having one on each function.
33863 * class.cs: Factor out some code for handling error handling in
33864 accordance to the "Declarations" section in the "Basic Concepts"
33865 chapter in the ECMA C# spec.
33867 * interface.cs: Make all interface member classes derive from
33868 InterfaceMemberBase.
33870 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33872 * Many things: all interfaces are parsed and generated in
33873 gen-treedump. Support for member variables, constructors,
33874 destructors, properties, constants is there.
33876 Beginning of the IL backend, but very little done, just there for
33879 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33881 * cs-parser.jay: Fix labeled statement.
33883 * cs-tokenizer.cs (escape): Escape " and ' always.
33884 ref_line, ref_name: keep track of the line/filename as instructed
33885 by #line by the compiler.
33888 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33890 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33891 to match the values in System.CodeDOM.
33893 Divid renamed to Divide.
33895 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33897 (Statements.set): remove.
33899 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33902 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33903 falseStatements always have valid values.
33905 * cs-parser.jay: Use System.CodeDOM now.