1 2008-04-17 Marek Safar <marek.safar@gmail.com>
3 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
7 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
9 Hook up 'EmitSideEffect'
10 * constant.cs (Constant.EmitSideEffect): New.
11 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
12 (SideEffectConstant.EmitSideEffect): New.
13 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
14 unconditional branch in EmitBranchable.
15 (FieldExpr.EmitBranchable): New.
16 * expression.cs (Unary.EmitSideEffect): New.
17 (Binary.EmitSideEffect): New.
18 (VariableReference.EmitSideEffect): New. Do nothing.
20 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
22 Introduce 'EmitSideEffect'
23 * ecore.cs (Expression.EmitSideEffect): New.
24 (TypeCast): Rename from EmptyCast.
26 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
27 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
28 * convert.cs, nullable.cs: Update to changes.
30 2008-04-16 Marek Safar <marek.safar@gmail.com>
32 * class.cs, cs-parser.jay: Early check for base types expression.
34 2008-04-16 Marek Safar <marek.safar@gmail.com>
36 * decl.cs (MemberName): Declare PrettyName as obsolete.
38 2008-04-16 Marek Safar <marek.safar@gmail.com>
40 * namespace.cs: Use MemberName comparison.
42 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
45 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
47 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
48 (MemberName.FullyQualifiedName): New. Provides the functionality
49 that users assume FullName would have.
50 * ecore.cs, namespace.cs: Update to changes.
52 * statement.cs (Using.assign): Make into ExpressionStatement.
53 (Using.EmitPreTryBody): Simplify.
55 2008-04-16 Marek Safar <marek.safar@gmail.com>
57 * report.cs: ColorFormat is protected.
59 * rootcontext.cs: Unused fields clean-up.
61 * namespace.cs: Made UsingEntry name private.
63 2008-04-16 Marek Safar <marek.safar@gmail.com>
65 * cs-tokenizer.cs, location.cs: Removed unused field.
67 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
68 Raja R Harinath <harinath@hurrynot.org>
71 * constant.cs (SideEffectConstant.value): Rename from 'left'.
72 (SideEffectConstant.side_effect): Rename from 'right'.
73 (SideEffectConstant..ctor): Normalize 'side_effect'.
74 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
75 value of this constant.
76 * cfold.cs: Update to changes.
78 2008-04-15 Marek Safar <marek.safar@gmail.com>
80 * cs-paser.jay: Removed unused variable.
82 * driver.cs: Made Compile instance method.
84 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
86 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
88 2008-04-15 Marek Safar <marek.safar@gmail.com>
90 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
92 2008-04-13 Jb Evain <jbevain@novell.com>
94 * namespace.cs: update the System.Core fullname for 2.1
95 * driver.cs: update the list of required assemblies for 2.1.
96 Merged from the Moonlight 2 branch.
98 2008-04-11 Marek Safar <marek.safar@gmail.com>
100 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
101 types and user defined operators. User operators arguments has to be checked
102 for null value before invocation, which also means no operator is called
103 when any argument is not convertible to unwrapped nullable type.
105 2008-04-09 Marek Safar <marek.safar@gmail.com>
107 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
108 of Unary expressions to follow operator overloading rules precisely.
109 Also fixes #321794, #323794
111 2008-04-08 Marek Safar <marek.safar@gmail.com>
113 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
116 2008-04-08 Marek Safar <marek.safar@gmail.com>
118 * expression.cs, ecore.cs: Implemented MemberInit expression.
120 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
122 Fix mono/tests/exception4.cs
123 * statement.cs (ExceptionStatement, TryCatch): Revert to using
124 ec.NeedReturnLabel () rather emitting a 'nop'.
126 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
128 (TryCatch.SomeCodeFollows): Likewise.
129 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
130 for 'break', 'continue' and 'return' statements inside a try.
131 We're fairly sure that the generated IL stream will have more
132 instructions textually following the try.
133 (FlowBranchingTryCatch): Likewise.
135 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
136 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
139 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
140 wrapper -- forward everything to CollectionForeach.
141 (CollectionForeach.NonDisposableWrapper): New.
142 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
143 instead of a pop + branch to end.
145 2008-04-07 Marek Safar <marek.safar@gmail.com>
147 A fix for bug #377485
148 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
149 Propagate location for extension method groups. Report conversion failure at
152 2008-04-07 Marek Safar <marek.safar@gmail.com>
154 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
155 ListInit and Field expressions.
157 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
159 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
160 Since $PC is always -1 inside the body of MoveNext, the fault
162 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
163 * statement.cs (ExceptionStatement.emit_finally): Likewise.
164 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
166 The denouement! Fix #324708
167 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
168 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
169 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
170 'finally' inside the finally clause.
172 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
173 inside an iterator. Don't emit the body of the 'finally' inside
174 the finally clause yet.
176 Use the ResumableStatement infrastructure for MoveNext ()
177 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
178 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
179 'old_resume_points'. Move dispatcher upfront.
180 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
181 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
182 in an enumerator. This encodes the main fix in this patch series
183 -- we can only jump into the first instruction of a try from the
184 outside, but we want to emit try/finally regions in iterators and
185 resume in the middle of them.
187 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
189 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
190 of NeedReturnLabel here.
192 Introduce a common point for emitting try/finally to IL
193 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
194 features of the various subclasses, which are now driven by ...
195 (ExceptionStatement.EmitPreTryBody): ... this and ...
196 (ExceptionStatement.EmitTryBody): ... this and the original
198 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
199 Remove DoEmit and update to follow above protocol.
201 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
202 of the dispatcher are the same, skip emitting the 'switch'.
203 * iterator.cs (Iterator.EmitDispose): Update to changes.
205 Clean up handling of 'using' statement
206 * statement.cs (UsingTemporary): New. Carved out of ...
207 (Using): ... this. Simplify drastically. Handle exactly
209 * cs-parser.jay (using_statement): Split. Create UsingTemporary
210 or Using as appropriate. If there are multiple variable declared,
211 create nested Using statements.
212 (resource_acquisition): Kill.
214 * statement.cs (ExceptionStatement.EmitForDispose): Use
215 EmitFinallyBody, not EmitFinally.
217 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
218 * iterator.cs: Update to changes.
220 Start using the ResumableStatement infrastructure
221 * statement.cs (ResumeableStatement.PrepareForDispose): New.
222 (ResumableStatement.EmitForDispose): New.
223 (ExceptionStatement): Override them.
224 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
225 EmitForDispose to create the body of the Dispose method. Don't
228 * iterator.cs (Iterator.AddResumePoint): Move here from ...
229 * statement.cs (Toplevel.AddResumePoint): ... here.
230 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
231 * flowanalysis.cs (FlowBranchingIterator): New.
232 * codegen.cs (EmitContext): Update to changes.
234 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
235 (Iterator.old_resume_points): Rename from 'resume_points'.
236 (Iterator.MoveNextStatement): Remove unused class.
238 New infrastructure for try/finally in iterators (still unused)
239 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
240 (FlowBranchingToplevel.AddResumePoint): Hook into
241 ToplevelBlock.AddResumePoint.
242 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
243 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
244 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
245 resume points and assign program-counter values.
246 (ExceptionBlock.AddResumePoint): Collect resume points for
247 de-muxer at the top of try block.
248 * iterators.cs (Yield.CheckContext): Simplify.
249 (Yield.Resolve): Use FlowBranching.AddResumePoint.
251 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
253 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
254 argument to an ExitStatement.
255 (FlowBranchingException): Refactor saved origins code.
256 * statement.cs (ExitStatement): Update to cahges.
257 * iterator.cs (YieldBreak): Likewise.
259 * statement.cs (ResumableStatement): New. Common base class for
260 YieldReturn and ExceptionStatement.
261 (ExitStatement): New. Common base class for Return and YieldBreak.
262 (Return): Update to changes.
263 * iterator.cs (YieldBreak): Likewise.
264 * lambda.cs (ContextualReturn): Likewise.
267 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
268 emit a meaningful error message.
271 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
272 (VariableInfo.SetAssigned): Set it.
273 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
274 determine if CS0219 or CS0168 is appropriate. Don't use
275 flow-analysis information.
276 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
277 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
278 (EmitContext.EndFlowBranching): ... this.
280 2008-04-03 Marek Safar <marek.safar@gmail.com>
282 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
284 2008-04-03 Marek Safar <marek.safar@gmail.com>
286 A fix for bug #376508
287 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
288 ImplicitConversionExists.
290 2008-04-03 Marek Safar <marek.safar@gmail.com>
292 * expression.cs (Binary): Added remaining binary operators to expression
295 * nullable.cs: Optimize shift with null argument.
297 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
299 Fix minor IL regression
300 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
301 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
302 * cs-parser.jay (try_statement): Update to changes.
304 * statement.cs (TryFinally.need_exc_block): Delete.
305 (TryFinally): Update to changes.
307 Now all ExceptionStatements are unconditional
308 * statement.cs (CollectionForeach.DisposableWrapper): New.
309 Extract out the try/finally code into a new wrapper.
310 (CollectionForeach.Resolve): Use it to simplify the code.
312 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
314 Start at simplifying ExceptionStatement semantics a bit
315 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
316 * cs-parser.jay (try_statement): Update to changes.
317 (opt_catch_clauses): Remove.
318 * flowanalysis.cs: Update to changes.
319 (FlowBranching.BranchingType.TryCatch): New.
320 (FlowBranchingTryCatch): New.
322 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
323 (FlowBranching.CreateBranching): Update to changes.
324 (FlowBranchingBlock.AddSibling): Add sanity check.
325 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
328 * iterators.cs (Iterator.MarkFinally): Remove.
329 * statement.cs (ExceptionStatement): Update to changes.
331 Add support for skipping over finally blocks at runtime. First
332 in a series to fix #324708
333 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
334 (Iterator.EmitMoveNext): Initialize it.
335 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
336 branch over the body of the 'finally' clause.
338 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
340 Avoid lopsided use of Foo/DoFoo names
341 * statement.cs (ExpressionStatement.EmitFinallyBody):
342 Rename from EmitFinally.
343 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
344 * iterator.cs: Update to changes.
346 2008-04-02 Marek Safar <marek.safar@gmail.com>
348 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
349 based on UserOperatorCall. More binary nullable operators clean up.
351 2008-04-02 Martin Baulig <martin@ximian.com>
353 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
355 2008-04-02 Marek Safar <marek.safar@gmail.com>
357 * nullable.cs: Merge user and empty conversions when lifting expression
360 * expression.cs (StringConcat): Implemented expression tree representation.
362 2008-04-01 Marek Safar <marek.safar@gmail.com>
364 * nullable.cs: When lifting null literal and a user operator exists, no call
367 2008-04-01 Marek Safar <marek.safar@gmail.com>
369 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
372 2008-04-01 Marek Safar <marek.safar@gmail.com>
374 * nullable.cs, expression.cs: Use namespace instead heavily nested
375 monster abstract class.
377 2008-04-01 Marek Safar <marek.safar@gmail.com>
379 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
380 lifting of null literal and user operators. Clean up of some temporary
383 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
385 Fix #368224, test-629.cs
386 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
387 if it crossed an unwind-protect boundary.
388 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
389 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
390 inside an unwind-protected region.
391 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
392 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
393 'leave' instead of a 'br' if unwind-protected.
394 (Iterator.EmitYieldBreak): Likewise.
396 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
398 * driver.cs: Only define versioninfo resources if no win32 resource
401 2008-03-28 Marek Safar <marek.safar@gmail.com>
403 A fix for bug #372375
404 * convert.cs: Fixed boxing of nullable types.
406 2008-03-28 Marek Safar <marek.safar@gmail.com>
408 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
411 2008-03-28 Marek Safar <marek.safar@gmail.com>
413 A fix for bug #374619
414 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
416 2008-03-27 Marek Safar <marek.safar@gmail.com>
418 * lambda.cs: Check return type only for invocation.
420 2008-03-27 Marek Safar <marek.safar@gmail.com>
422 A fix for bug #374214
423 * ecore.cs: Correctly report argument type mismatch.
425 2008-03-27 Marek Safar <marek.safar@gmail.com>
427 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
428 and not rely on broken IsEnum.
430 2008-03-27 Marek Safar <marek.safar@gmail.com>
432 * nullable.cs: New file, extracted from generic.cs.
434 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
436 2008-03-27 Marek Safar <marek.safar@gmail.com>
438 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
439 predefined comparison operators and null literals.
441 * report.cs: New warning ID.
443 2008-03-25 Marek Safar <marek.safar@gmail.com>
445 A fix for bug #370577
446 * lambda.cs: Check return type too.
448 2008-03-25 Marek Safar <marek.safar@gmail.com>
450 A fix for bug #372846
451 * class.cs: Automatic properties can be declared as unsafe.
453 2008-03-20 Marek Safar <marek.safar@gmail.com>
455 * location.cs: Use string based concatenation.
457 * expression.cs: LiftedBinaryOperator is gmcs only.
459 2008-03-20 Marek Safar <marek.safar@gmail.com>
461 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
462 conversions rules and expression trees.
464 2008-03-19 Marek Safar <marek.safar@gmail.com>
466 * delegate.cs: Use extension method source as delegate target.
468 2008-03-19 Marek Safar <marek.safar@gmail.com>
470 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
471 binary operations to be purely based on binary operations and optimized
472 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
473 and other ET refactoring.
475 * typemanager.cs: Fixed warning.
477 2008-03-17 Marek Safar <marek.safar@gmail.com>
479 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
481 * symbolwriter.cs: Fixed.
483 2008-03-17 Marek Safar <marek.safar@gmail.com>
485 * anonymous.cs, driver.cs: Reset anonymous types counters.
487 2008-03-17 Marek Safar <marek.safar@gmail.com>
489 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
491 * class.cs: Use fullname for all type member definitions.
493 2008-02-19 Martin Baulig <martin@ximian.com>
496 (IMethodData.EmitExtraSymbolInfo): New interface method.
497 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
498 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
499 interface method here as an empty public virtual method.
502 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
503 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
504 CodeGen.SymbolWriter.SetRealMethodName().
506 2008-02-18 Martin Baulig <martin@ximian.com>
509 (ScopeInfo.EmitType): Override this and emit debugging
510 information for captured variables.
511 (RootScopeInfo.EmitType): Override this and emit symbol
512 information for a captured `this'.
514 2008-02-15 Martin Baulig <martin@ximian.com>
516 * iterators.cs: Emit debugging info.
519 (EmitContext.Flags): Add `OmitDebuggingInfo'.
520 (EmitContext.OmitDebuggingInfo): New public property.
523 (While): Override Emit() and don't emit symbol info there; do it
524 inside DoEmit() instead.
525 (Block.Emit): Omit symbol information while emitting the scope
526 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
528 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
529 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
530 .ctor to make `IsIterator' work.
532 2008-03-14 Martin Baulig <martin@ximian.com>
534 * symbolwriter.cs: Added the new symbol writer function from the
535 debugger's `terrania' branch; temporarily enclose them inside
536 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
539 2008-03-14 Martin Baulig <martin@ximian.com>
542 (SymbolWriter): Make this a public static class.
545 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
546 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
548 2008-03-14 Marek Safar <marek.safar@gmail.com>
550 A fix for bug #370577
551 * statement.cs, lambda.cs: Added extra limitations when dealing with void
554 2008-03-14 Marek Safar <marek.safar@gmail.com>
556 * typemanager.cs (CSharpName): Made 250 times faster.
558 2008-03-13 Marek Safar <marek.safar@gmail.com>
560 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
562 2008-03-12 Marek Safar <marek.safar@gmail.com>
564 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
565 crash when predefined field does not exist.
567 2008-03-12 Marek Safar <marek.safar@gmail.com>
569 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
571 2008-03-12 Marek Safar <marek.safar@gmail.com>
573 * class.cs (FixedField): Don't crash when contructors are missing.
575 2008-03-11 Marek Safar <marek.safar@gmail.com>
577 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
578 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
579 check internal types accessibility for internal and external types.
580 Replaced EnumToUnderlying by GetEnumUnderlyingType.
582 2008-03-11 Marek Safar <marek.safar@gmail.com>
584 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
585 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
586 attribute.cs, statement: Use corect instance of predefined types (work
589 2008-03-07 Marek Safar <marek.safar@gmail.com>
591 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
593 2008-03-07 Marek Safar <marek.safar@gmail.com>
595 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
596 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
597 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
598 predefined types clean up, delayed predefined types members initialization
599 (work related to #364674).
601 2008-03-05 Marek Safar <marek.safar@gmail.com>
603 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
605 2008-03-05 Marek Safar <marek.safar@gmail.com>
607 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
608 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
609 predefined types clean up (work related to #364674).
611 2008-03-04 Marek Safar <marek.safar@gmail.com>
613 * ecore.cs: Print an error message instead of throwing exception.
615 2008-03-04 Marek Safar <marek.safar@gmail.com>
617 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
618 expression.cs, statement.cs: Unififed null literal representation.
620 2008-03-03 Marek Safar <marek.safar@gmail.com>
622 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
623 expression.cs: Refactored binary operators resolve phase and improved speed.
624 The nullable code is still missing and won't work correctly, more fixes
627 It also fixes #323726, #324312, #324248, and many other unreported issues.
629 2008-02-29 Zoltan Varga <vargaz@gmail.com>
631 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
634 2008-02-27 Marek Safar <marek.safar@gmail.com>
636 * ecore.cs: Clean-up and split BetterConversion.
638 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
641 * enum.cs (EnumMember.Value): Only access 'value' if
642 ResolveValue says it's ok.
643 (EnumMember.DoResolveValue): Don't set prev_member.value.
644 (Enum.GetDefinition): Reverse arguments of Equals --
645 EnumMember.Value can return 'null'.
647 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
649 2008-02-22 Marek Safar <marek.safar@gmail.com>
651 * generic.cs, expression.cs: More ongoing work on expression trees.
653 2008-02-21 Marek Safar <marek.safar@gmail.com>
655 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
656 handle missing matches when mutiple operators exist.
658 2008-02-20 Marek Safar <marek.safar@gmail.com>
660 A fix for bug #363218
661 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
664 2008-02-20 Marek Safar <marek.safar@gmail.com>
666 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
667 update. This time to deal correctly with SideEffectConstant expression used
668 as an argument for another constant folding.
670 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
672 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
675 2008-02-19 Marek Safar <marek.safar@gmail.com>
677 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
679 2008-02-19 Marek Safar <marek.safar@gmail.com>
681 A fix for bug #328136
682 * expression.cs: Do not fold immediately LogicalAnd operators when the left
683 side is a false constant, because we still need to evaluate the right-hand
686 * statement.cs (If): Emit two types of boolean constants (simple constant,
687 side-effect constant).
689 2008-02-19 Marek Safar <marek.safar@gmail.com>
691 * constant.cs (SideEffectConstant): Don't emit boolean constant.
693 * expression.cs: Fold immediately LogicalAnd operators when both sides are
696 2008-02-18 Marek Safar <marek.safar@gmail.com>
698 A fix for bug #361457
699 * ecore.cs (IsApplicable): Params methods have lower priority.
701 * support.cs: Return correct parameter modifier for params types.
703 2008-02-18 Marek Safar <marek.safar@gmail.com>
705 * generic.cs (TypeParameter): Cache attribute target name.
707 * support.cs: Removed unused variable.
709 * typemanager.cs: Removed debugging leftover.
711 * ecore.cs: Use local type instead of a property;
713 * class.cs (VerifyMembers): Consider also parent to test whether type member
716 * expression.cs (FullMethodDesc): Removed.
718 * attribute.cs (IsValidArgumentType): Made static.
720 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
722 Cleanup to be more readable.
723 * Makefile (GMCS_PROFILE): Remove.
724 (COMPILER_NAME): New helper.
726 2008-02-15 Miguel de Icaza <miguel@novell.com>
728 * cs-tokenizer.cs: if a conditional expression happens inside a
729 (...) this also means that we do not need to de-ambiguate between
730 an parenthesized expression and a cast.
734 * constant.cs (SideEffectConstant): a constant value that happens
735 to have a side effect.
737 Fixes the build regressions introduced by the fix for #359789
739 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
741 * expression.cs (Conditional.Emit): when emitting the ternary
742 operator, use local variables to generate code verifiable code.
744 The verifier cannot infer that the type on stack before the
745 stloc.0 is executed is of type ParentB. This happens because the
746 stack merge algorithm uses only parent types when deciding which
747 is the common type. This is described in Part III 1.8.1.3 of ECMA
750 This code compiled with mcs is not verifiable under MS. The MS
751 verifier picks the first common interface of Foo and Bar, which is
752 wrong, but doesn't use a full join type of the 2 interfaces.
754 CSC uses a clever hack to compile such code in a verifiable
755 way. It stores the intermediate values in a local variable with
760 2008-02-14 Miguel de Icaza <miguel@novell.com>
762 * expression.cs: Do not fold BitwiseAnd operators when the left
763 side is a false constant, because we still need to evaluate the
768 * support.cs: Instead of throwing an InternalErrorException when
769 the position of the stream is outside the boundary of our buffer,
770 reset the state of the reader, and restart the reading from the
771 beginning of the file.
773 2008-02-14 Marek Safar <marek.safar@gmail.com>
775 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
777 2008-02-14 Marek Safar <marek.safar@gmail.com>
779 A fix for bug #361686
780 * decl.cs: A protected types used inside a private class which parents
781 derives from the protected class are accessible.
783 2008-02-13 Marek Safar <marek.safar@gmail.com>
785 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
786 the parameterless constructor.
788 2008-02-13 Marek Safar <marek.safar@gmail.com>
790 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
791 lookup methods to use standard member cache when doing member lookup.
793 2008-02-12 Marek Safar <marek.safar@gmail.com>
795 * driver.cs: Don't report full path for referenced module as assembly error.
797 2008-02-12 Marek Safar <marek.safar@gmail.com>
799 * Makefile: Fixed `qh' target to work on all machines.
801 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
802 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
803 and HasElementType with TypeManager implementation.
805 2008-02-08 Marek Safar <marek.safar@gmail.com>
807 A fix for bugs #325134, #359749
808 * expression.cs, ecore.cs: Try to resolve an extension method even if the
809 first binds point to non-method member expression.
811 2008-02-08 Marek Safar <marek.safar@gmail.com>
813 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
815 2008-02-08 Marek Safar <marek.safar@gmail.com>
817 A fix for bugs #321394, #323028
818 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
819 Reworked naive IsAccessibleAs implementation to handle nested types.
821 2008-02-05 Jb Evain <jbevain@novell.com>
823 * class.cs: use generic type comparison for parameters
826 2008-02-05 Marek Safar <marek.safar@gmail.com>
828 A fix for bug #325372
829 * class.cs: Use generic type comparison when testing method signatures.
831 2008-02-05 Marek Safar <marek.safar@gmail.com>
833 A fix for bug #357047
834 * ecore.cs: Applied C# 3.0 changes to better conversion.
836 2008-02-05 Marek Safar <marek.safar@gmail.com>
838 A fix for bug #358374
839 * cs-parser.jay: Correctly set modifiers for all constructor types.
841 2008-02-04 Marek Safar <marek.safar@gmail.com>
843 A fix for bug #355251
844 * generic.cs: Added base class constraint based type inference.
846 2008-02-01 Marek Safar <marek.safar@gmail.com>
848 A fix for bug #357255
849 * decl.cs: One more missing visibility check.
851 2008-02-01 Marek Safar <marek.safar@gmail.com>
853 * support.cs: Fixed broken return.
855 2008-01-25 Marek Safar <marek.safar@gmail.com>
857 * report.cs: Correctly reset warnings count after probing.
859 2008-01-25 Martin Baulig <martin@ximian.com>
862 (NamespaceEntry.SymbolFileID): Make this work again after
863 MemberName.ToString() is gone.
865 2008-01-25 Marek Safar <marek.safar@gmail.com>
867 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
870 2008-01-25 Marek Safar <marek.safar@gmail.com>
872 * generic.cs: Use full implicit conversion for type inference fixing.
874 2008-01-24 Marek Safar <marek.safar@gmail.com>
876 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
877 Fixed user operator conversions.
879 2008-01-24 Marek Safar <marek.safar@gmail.com>
881 * generic.cs: Do nullable type to null comparison optimization during
884 2008-01-24 Marek Safar <marek.safar@gmail.com>
886 A fix for bug #355163
887 * generic.cs: Enabled l-value resolve on nullable expressions.
889 2008-01-24 Marek Safar <marek.safar@gmail.com>
891 A fix for bug #353986
892 * class.cs: Ingore static ctors with parameters for any further checks.
894 2008-01-24 Marek Safar <marek.safar@gmail.com>
896 A fix for bug #354310
897 * namespace.cs: Removed redundant check.
899 2008-01-24 Marek Safar <marek.safar@gmail.com>
901 A fix for bug #354928
902 * expression.cs: ElementInitializers can be resolved only once.
904 2008-01-24 Marek Safar <marek.safar@gmail.com>
906 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
907 Condition expressions.
909 2008-01-23 Marek Safar <marek.safar@gmail.com>
911 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
913 2008-01-22 Marek Safar <marek.safar@gmail.com>
915 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
918 * generic.cs: Implemented coalesce expression.
920 2008-01-22 Marek Safar <marek.safar@gmail.com>
922 A fix for bug #355145
923 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
924 expression tree type inference.
926 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
929 * expression.cs (Binary.IsUnsignedType): Fix typo.
931 2008-01-22 Marek Safar <marek.safar@gmail.com>
933 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
935 2008-01-22 Marek Safar <marek.safar@gmail.com>
937 A fix for bug #355161
938 * ecore.cs, expression.cs: Wider range of extension method supported
941 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
943 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
944 AssemblyBuilder to operate in compiler context. Fixes mcs part of
947 2008-01-22 Marek Safar <marek.safar@gmail.com>
949 A fix for bug #355148
950 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
952 2008-01-22 Miguel de Icaza <miguel@novell.com>
954 * expression.cs (CreateExpressionTree): Add support for or and
955 logical or, and indent following the coding conventions.
957 * typemanager.cs (LinqExpression): renamed from
958 ExpressionTreeManager, for a shorter name.
960 Use TypeManager.CoreLookupType to lookup types from our core
961 assemblies and turn those into "Type" variables.
963 Consumers that previously used "Namespace" and "Type" from this
964 class should instead use the TypeExpression which is a type that
965 is fully resolved (without involving the regular C# resolution
968 This typically looks like this:
970 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
971 new MemberAccess (texpr, name, type_arguments, loc)
973 This avoids the problem in: #355178
975 2008-01-21 Marek Safar <marek.safar@gmail.com>
977 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
978 feature in parser only as we do in other cases.
980 2008-01-21 Marek Safar <marek.safar@gmail.com>
982 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
983 typemanager.cs: A refactoring of params arguments to reuse existing
984 expressions (params -> array initializer) to emit params argument instead
985 of specialized handling.
986 It was required by expression tree implementation and it has other benefits
987 as well, we now apply same optimization for params arguments as we do for
990 2008-01-18 Marek Safar <marek.safar@gmail.com>
992 A fix for bug #353526
993 * generic.cs: A type inference of params arguments may not required any
994 temporary array creation.
996 2008-01-18 Marek Safar <marek.safar@gmail.com>
998 A fix for bug #353534
999 * generic.cs, ecore.cs, expression.cs: A method group type inference is
1000 supported for delegates only.
1002 2008-01-18 Marek Safar <marek.safar@gmail.com>
1004 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
1005 type for more than 1 candidates.
1007 2008-01-18 Marek Safar <marek.safar@gmail.com>
1009 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
1012 2008-01-16 Marek Safar <marek.safar@gmail.com>
1014 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
1015 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
1016 operator) expressions.
1018 2008-01-16 Zoltan Varga <vargaz@gmail.com>
1020 * statement.cs: Avoid declaring an IL variable for this_variable since it is
1021 not accessed from the generated IL.
1023 2008-01-14 Marek Safar <marek.safar@gmail.com>
1025 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
1026 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
1027 statement.cs: The first expression tree implementation drop, mostly
1028 infrastructure work.
1030 2008-01-14 Marek Safar <marek.safar@gmail.com>
1032 * ecore.cs (IsNestedChild): Refactored.
1034 2008-01-11 Marek Safar <marek.safar@gmail.com>
1036 * lambda.cs: Don't use a cast on unknown expression statement.
1038 2008-01-10 Geoff Norton <gnorton@novell.com>
1040 * cs-tokenizer.cs: One more token to distinguish between method and lambda
1043 2008-01-09 Marek Safar <marek.safar@gmail.com>
1045 * doc.cs: Report better /doc crash details.
1047 2008-01-09 Marek Safar <marek.safar@gmail.com>
1049 A fix for bug #352536
1050 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
1052 2008-01-08 Marek Safar <marek.safar@gmail.com>
1054 A fix for bug #352287
1055 * ecore.cs, expression.cs: Do `this' access checking in all member access
1058 2008-01-08 Marek Safar <marek.safar@gmail.com>
1060 * rootcontext.cs, driver.cs: Switch to linq mode by default.
1062 * report.cs: Reset message stacks.
1064 2008-01-08 Marek Safar <marek.safar@gmail.com>
1066 * generic.cs (InferInPhases): Correctly calculate params position.
1068 2008-01-08 Marek Safar <marek.safar@gmail.com>
1070 * cs-tokenizer.cs: No need to parse full string when parsing lambda
1073 2008-01-07 Marek Safar <marek.safar@gmail.com>
1075 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
1077 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
1079 * driver.cs: Updated --help option.
1081 2008-01-07 Marek Safar <marek.safar@gmail.com>
1083 * generic.cs (InferParamsTypeArguments): Removed.
1084 (InferInPhases): Add params type inference.
1085 (LowerBoundInference): Fixed scoring mechanism.
1087 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
1089 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
1091 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
1092 byte array for unsigned "baked" assemblies.
1094 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
1096 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
1097 array for assemblies that are not strongnamed.
1099 2008-01-04 Marek Safar <marek.safar@gmail.com>
1101 A fix for bug #351481
1102 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
1103 declaring type for nested generic types.
1105 2008-01-04 Marek Safar <marek.safar@gmail.com>
1107 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
1108 instead of ToString.
1110 2008-01-03 Marek Safar <marek.safar@gmail.com>
1112 A fix for bug #351047
1113 * expression.cs (Binary.ResolveOperator): Allow equality operators between
1114 null and structs only when equality and inequality operators are defined
1115 either as an user-operators or predefined operators.
1117 2008-01-03 Marek Safar <marek.safar@gmail.com>
1119 A fix for bug #351047
1120 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
1122 2008-01-03 Marek Safar <marek.safar@gmail.com>
1124 A fix for bug #351257
1125 * cs-tokenizer.cs: Advance line number for '\r' correctly.
1127 2008-01-03 Marek Safar <marek.safar@gmail.com>
1129 A fix for bug #351157
1130 * class.cs (Using): Fixed yet another broken cloning.
1132 (Block): Put back more sensible default value for statements.
1134 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
1136 * codegen.cs: Allow AssemblyVersion with only major version component.
1139 2007-12-29 Marek Safar <marek.safar@gmail.com>
1141 A fix for bug #324654
1142 * class.cs: Use FullName property as member name.
1144 2007-12-28 Marek Safar <marek.safar@gmail.com>
1146 A fix for bug #342117
1147 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
1148 constructor constraint.
1150 2007-12-28 Marek Safar <marek.safar@gmail.com>
1152 A fix for bug #338273
1153 * class.cs (ProbertyBase): Access modifier checks are required for overrides
1156 2007-12-28 Marek Safar <marek.safar@gmail.com>
1158 A fix for bug #350839
1159 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
1161 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1163 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1166 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1168 * statement.cs: Changed some Hashtables to use HybridDictionaries
1169 instead. It was observed that some HashTables only contained a few
1170 items in the vast majority of cases. Since HybridDictionary is
1171 more efficient on small sets (<10 elements), "known_variables"
1172 from class ExplicitBlock as well as "labels" and "constants " from
1173 class Block were changed to HybridDictionaries.
1175 Atsai results: (56216kb->54987kb)
1177 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
1180 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1182 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1185 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1187 * expression.cs: foreach loop to for loop, saved on allocation of
1188 enumerator (59333kb->59141kb)
1190 * statement.cs. Changed foreach loops to for loops, saved on
1191 allocation of enumerator (59141kb->59006kb)
1193 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
1194 when constructed with no specified capacity. This was causing a
1195 few ArrayLists to allocate more memory than they would potentially
1196 need in the Block class and MemberCache class. Setting the
1197 ArrayLists to construct with a capacity of 1 saves some
1198 memory. (56216kb->55585kb)
1200 2007-12-27 Marek Safar <marek.safar@gmail.com>
1202 A fix for bug #347189 (2nd issue)
1203 * expression.cs (MemberAccess): Nested type can be found in base non-generic
1206 2007-12-27 Miguel de Icaza <miguel@novell.com>
1208 * report.cs: Do not use colors if stdout and stderr are not a
1211 2007-12-27 Marek Safar <marek.safar@gmail.com>
1213 A fix for bug #346998
1214 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
1217 2007-12-27 Marek Safar <marek.safar@gmail.com>
1219 A fix for bug #343465
1220 * class.cs: Explicit method name for nested types uses dots only.
1222 2007-12-27 Marek Safar <marek.safar@gmail.com>
1224 A fix for bug #343707
1225 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
1227 2007-12-27 Marek Safar <marek.safar@gmail.com>
1229 * ecore.cs: Report type inference errors only when arguments count matches
1232 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
1234 * expression.cs, report.cs: New warning.
1236 * typemanager.cs: Catch anonymous method type too.
1238 2007-12-23 Marek Safar <marek.safar@gmail.com>
1240 A fix for bug #346379
1241 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
1243 2007-12-23 Marek Safar <marek.safar@gmail.com>
1245 A fix for bug #347359
1246 * expression.cs (Invocation): Don't resolve already resolved expression.
1248 2007-12-23 Marek Safar <marek.safar@gmail.com>
1250 A fix for bug #347189
1251 * class.cs (FixedField): Use non-dependent code only in the define phase.
1253 2007-12-23 Marek Safar <marek.safar@gmail.com>
1255 A fix for bug #348076
1256 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
1258 2007-12-22 Marek Safar <marek.safar@gmail.com>
1260 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
1261 discovered extension methods.
1263 2007-12-22 Marek Safar <marek.safar@gmail.com>
1265 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
1268 2007-12-21 Miguel de Icaza <miguel@novell.com>
1270 * report.cs (ErrorMessage): Add support for using colors on
1271 terminals that support it.
1273 2007-12-21 Marek Safar <marek.safar@gmail.com>
1275 * ecore.cs: Use information about expanded params for error reporting.
1277 2007-12-21 Marek Safar <marek.safar@gmail.com>
1279 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
1280 and logic for params overloads.
1282 2007-12-15 Miguel de Icaza <miguel@novell.com>
1284 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
1285 as this is also created from the parser. Fixes #349034
1287 2007-12-12 Miguel de Icaza <miguel@novell.com>
1289 * statement.cs (Throw.CloneTo): it is valid to have empty
1290 expressions for throw.
1292 2007-12-03 Marek Safar <marek.safar@gmail.com>
1294 * cs-parser.jay: Set delegate constraint parsing region correctly.
1296 2007-12-03 Marek Safar <marek.safar@gmail.com>
1298 A fix for bug #345467
1299 * typemanager.cs (IsEqual): Compare generic parameters position only.
1301 2007-11-28 Marek Safar <marek.safar@gmail.com>
1303 * expression.cs (BaseAccess): Type arguments can be null.
1305 2007-11-27 Raja R Harinath <harinath@gmail.com>
1307 * statement.cs (Block.Resolve): Ensure flow-branching tree is
1308 consistent even when an error has occured.
1309 (Switch.Resolve): Likewise.
1311 2007-11-22 Marek Safar <marek.safar@gmail.com>
1313 A fix for bug #334505
1314 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
1317 2007-11-22 Marek Safar <marek.safar@gmail.com>
1319 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
1320 refactorings required to resolve extension methods correctly when mixing
1321 generics and non-generics members.
1323 2007-11-20 Marek Safar <marek.safar@gmail.com>
1325 A fix for bug #342584
1326 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
1329 2007-11-19 Marek Safar <marek.safar@gmail.com>
1331 A fix for bug #342512
1332 * delegate.cs: Use delegate argument expression when is available. Don't
1333 emit virtual call when class is sealed.
1335 2007-11-16 Marek Safar <marek.safar@gmail.com>
1337 A fix for bug #325423
1338 * assign.cs (FieldInitializer): Use resolved expression for emit.
1340 * class.cs: Print less confusing error message.
1342 2007-11-16 Marek Safar <marek.safar@gmail.com>
1344 * cs-tokenizer.cs: Removed GMCS ifdefs.
1346 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
1349 * cs-parser.jay: Disabled nullable check.
1351 * generic-mcs: Copied more generic stuff.
1353 2007-11-16 Marek Safar <marek.safar@gmail.com>
1355 * gcs-parser.jay: Merged to cs-parser.jay.
1357 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
1358 * *.csproj, *.sources: Updated to use only jay parser file.
1360 2007-11-16 Marek Safar <marek.safar@gmail.com>
1362 * gcs-parser.jay: Added nullable and default expression feature checks.
1364 2007-11-16 Marek Safar <marek.safar@gmail.com>
1366 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
1367 it fixes many TODOs and hidden bugs.
1369 * expression: Removed duplicate error check.
1371 2007-11-15 Marek Safar <marek.safar@gmail.com>
1373 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
1374 implicitly type local variable only when it is used in a declaration.
1376 2007-11-15 Marek Safar <marek.safar@gmail.com>
1378 * attribute.cs: Use CS0612 for empty strings.
1380 2007-11-14 Marek Safar <marek.safar@gmail.com>
1382 * lambda.cs, statement.cs: Contextual return may act as a statement.
1384 2007-11-14 Marek Safar <marek.safar@gmail.com>
1386 A fix for a regression cause by #324222
1387 * class.cs: Don't report unused even when it implements an interface.
1389 2007-11-13 Marek Safar <marek.safar@gmail.com>
1391 A fix for bug #341205
1392 * ecore.cs, expression.cs: Method group expression cannot do static
1393 method access with an instance reference check before overloading takes
1396 2007-11-13 Marek Safar <marek.safar@gmail.com>
1398 A fix for bug #325359
1399 * class.cs: Use predictable name for automatically generated property.
1401 2007-11-12 Marek Safar <marek.safar@gmail.com>
1403 A fix for bug #324996
1404 * expression.cs (Is): Handle case where D is nullable and T is not
1407 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
1409 2007-11-12 Marek Safar <marek.safar@gmail.com>
1411 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
1412 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
1413 Flush small error reporting changes.
1415 2007-11-09 Marek Safar <marek.safar@gmail.com>
1417 A fix for bug #324996
1418 * expression.cs: Rewrote Is expression implementation to work with
1419 generics, nullable types, anonymous method. A const result expression
1420 uses existing infrastructure instead of custom not fully-featured one.
1422 2007-11-08 Marek Safar <marek.safar@gmail.com>
1424 A fix for bug #340202
1425 * class.cs: Consider generics for volatile field.
1427 2007-11-08 Marek Safar <marek.safar@gmail.com>
1429 A fix for bug #335594
1430 * expression.cs: Use conversion rules when handling string addition.
1432 2007-11-07 Marek Safar <marek.safar@gmail.com>
1434 A fix for bug #336651
1435 * expression.cs: Fixed a crash when probing is on.
1437 2007-11-07 Marek Safar <marek.safar@gmail.com>
1439 A fix for bug #324242
1440 * covert.cs: Added a conversion from any nullable-type with an
1441 underlying enum-type to the type System.Enum.
1443 2007-11-07 Marek Safar <marek.safar@gmail.com>
1445 A fix for bug #324222
1446 * class.cs: Report all non-used event fields.
1448 2007-11-07 Marek Safar <marek.safar@gmail.com>
1450 A fix for bug #325161
1451 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1452 qualifier for generic types.
1454 2007-11-07 Marek Safar <marek.safar@gmail.com>
1456 A fix for bug #322971
1457 * expression.cs, ecore.cs: Added intermediate result value check for
1460 2007-11-07 Marek Safar <marek.safar@gmail.com>
1462 A fix for bug #324754
1463 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1464 when it was requested.
1466 2007-11-07 Marek Safar <marek.safar@gmail.com>
1468 A fix for bug #325101
1469 * expression.cs: Do type not value comparison for `is' expression.
1471 2007-11-07 Marek Safar <marek.safar@gmail.com>
1473 A fix for bug #320236
1474 * convert.cs: Don't apply user conversion on underlying target type.
1476 2007-11-06 Marek Safar <marek.safar@gmail.com>
1478 * expression.cs: Don't use unresolved expression for error reporting.
1480 2007-11-06 Marek Safar <marek.safar@gmail.com>
1482 A fix for bugs #337712, #324490
1483 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1484 overloading resolution too.
1486 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1487 the process consistent and more robust.
1489 * expression.cs, linq.cs, report.cs: Update.
1491 2007-11-02 Marek Safar <marek.safar@gmail.com>
1493 A fix for bug #332909
1494 * attribute.cs: Resolve attributes in correct context using error
1497 * rootcontext.cs: Define Obsolete attribute members as core members.
1499 2007-11-02 Marek Safar <marek.safar@gmail.com>
1501 * statement.cs: Removed unused methods.
1503 2007-10-31 Wade Berrier <wberrier@novell.com>
1505 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1506 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1509 2007-10-31 Marek Safar <marek.safar@gmail.com>
1511 A fix for bug #338102
1512 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1513 methods registered as non-generics.
1515 2007-10-31 Marek Safar <marek.safar@gmail.com>
1517 A fix for bugs #337712, #324490
1518 * delegate.cs: Delegate covariance and contravariance is not allowed for
1521 2007-10-31 Marek Safar <marek.safar@gmail.com>
1523 A fix for bug #337719
1524 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1527 2007-10-30 Marek Safar <marek.safar@gmail.com>
1529 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1531 2007-10-29 Marek Safar <marek.safar@gmail.com>
1533 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1536 2007-10-29 Raja R Harinath <rharinath@novell.com>
1538 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1540 2007-10-29 Marek Safar <marek.safar@gmail.com>
1542 A fix for bug #334652
1543 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1544 extension methods when we have not found the best candidate in normal
1547 2007-10-27 Marek Safar <marek.safar@gmail.com>
1549 * AssemblyInfo.cs: Keep up-to-date.
1551 2007-10-27 Marek Safar <marek.safar@gmail.com>
1553 * Makefile: Fixed generics compiler name.
1555 2007-10-27 Marek Safar <marek.safar@gmail.com>
1557 * lambda.test: removed, lambda parsing is done differently.
1559 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1561 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1563 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1565 2007-10-27 Marek Safar <marek.safar@gmail.com>
1567 * Makefile, *.sources : All C# compilers are in mcs folder.
1569 * *.cs: Use existing 2_1 define for smcs.
1571 2007-10-26 Marek Safar <marek.safar@gmail.com>
1573 A fix for bug #335847
1574 * assign.cs, expression.cs: Couple of changes to avoid creating a
1575 temporary variable for each object initializer assignment statement. It
1576 simplifies struct initialization too, otherwise two temporary variables
1578 Implemented optimization of redundant default element initializers.
1580 2007-10-25 Marek Safar <marek.safar@gmail.com>
1582 A fix for bug #336766
1583 * expression.cs (Class.CheckBase): Use generic name when method is
1586 2007-10-25 Marek Safar <marek.safar@gmail.com>
1588 A fix for bug #334737
1589 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
1590 variable and not variable argument for prepared copies.
1592 2007-10-24 Marek Safar <marek.safar@gmail.com>
1594 A fix for bug #325110
1595 * class.cs, expression.cs, attribute.cs: Use open generic method when
1596 checking conditional attribute.
1598 2007-10-24 Marek Safar <marek.safar@gmail.com>
1600 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
1601 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
1602 FeatureIsNotAvailable.
1604 2007-10-24 Marek Safar <marek.safar@gmail.com>
1606 ** C# 3.0 Partial methods
1608 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
1609 methods support. Because of member cache issue with generics only
1610 non-generics partial methods are fully supported.
1612 2007-10-23 Marek Safar <marek.safar@gmail.com>
1614 * class.cs, decl.cs: Rewrote member overloads check to cope with
1615 generics and to use member cache for member checking. It also improves
1616 performance and fixes remaining overloads issues.
1618 2007-10-20 Marek Safar <marek.safar@gmail.com>
1620 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
1621 roottypes.cs, typemanager.cs:
1623 A member cache creation logic changed to add members immediately and
1624 not rely on fallback. The member cache is now only prefered way
1625 how to access and find type declaration members. It saves 5 MB of memory
1626 during MWF compilation and makes code ready for more optimizations and
1627 clean-ups, it's also a pre-requirement for partial methods.
1629 2007-10-18 Raja R Harinath <harinath@gmail.com>
1631 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
1632 handling for generic parameters.
1634 2007-10-15 Marek Safar <marek.safar@gmail.com>
1636 * class.cs (FixedField): Removed redundant volatile check.
1638 2007-10-15 Marek Safar <marek.safar@gmail.com>
1640 * class.cs, decl.cs: Fixed overload members verification to do only one
1641 check per possible collision.
1643 2007-10-13 Marek Safar <marek.safar@gmail.com>
1645 A fix for bug #325478
1646 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
1647 and create only one disposable flags container.
1649 2007-10-12 Marek Safar <marek.safar@gmail.com>
1651 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
1652 * statement.cs (Fixed): Fixed variables cloning.
1654 2007-10-12 Marek Safar <marek.safar@gmail.com>
1656 A fix for bug #333342
1657 * class.cs (EventField): Don't mark value type event as synchronized.
1659 2007-10-12 Marek Safar <marek.safar@gmail.com>
1661 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
1662 inference to identify best candidate method correctly.
1663 (ProperyExpr): A range variable is read only and cannot be modified.
1665 2007-10-11 Marek Safar <marek.safar@gmail.com>
1667 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
1668 logic to identify best candidate method correctly.
1670 2007-10-11 Marek Safar <marek.safar@gmail.com>
1672 * location.cs (Equals, GetHashCode): Removed.
1674 2007-10-11 Marek Safar <marek.safar@gmail.com>
1676 * report.cs: Implemented message recorder. It is used mainly for lambda
1677 expressions to capture otherwise swallowed error messages.
1679 * anonymous.cs, lambda.cs.cs: Do full parameters check.
1681 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
1683 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
1685 * expression.cs (MemberAccess): Always report lookup failure.
1687 * location.cs: Implemented Equals, GetHashCode.
1689 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
1691 2007-10-10 Jb Evain <jbevain@novell.com>
1693 * codegen.cs: re-enable assembly version check.
1695 2007-10-09 Marek Safar <marek.safar@gmail.com>
1697 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
1700 * namespace.cs (UsingAlias): Do correct version check.
1702 2007-10-08 Marek Safar <marek.safar@gmail.com>
1704 * expresison.cs, ecore.cs: Issue extension method error message when
1707 * rootcontext.cs: Added ISO_2 compiler mode option.
1709 2007-10-08 Marek Safar <marek.safar@gmail.com>
1711 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
1714 2007-10-08 Marek Safar <marek.safar@gmail.com>
1716 * attribute.cs (GetString, GetBoolean): Work with both literal and
1719 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
1720 Moved method overload specific methods to MethodGroupExpr.
1722 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
1723 it should be less memory consuming.
1725 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
1727 * codegen.cs: remove the assembly version check until the buildbot is
1730 2007-10-07 Jb Evain <jbevain@novell.com>
1732 * attribute.cs (Attribute.GetString): if the value
1733 expression is a StringConstant, return its string value.
1735 2007-10-07 Jb Evain <jbevain@novell.com>
1737 * typemanager.cs: add `assembly_version_attribute_type`.
1738 * codegen.cs: on attribute emission, check that the
1739 AssemblyVersionAttribute doesn't overflow.
1741 2007-10-05 Marek Safar <marek.safar@gmail.com>
1743 A fix for bug #324677
1744 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
1745 parent container of a scope container with currently resolved one.
1747 2007-10-05 Marek Safar <marek.safar@gmail.com>
1749 A fix for bug #325534
1750 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
1753 2007-10-05 Marek Safar <marek.safar@gmail.com>
1755 A fix for bug #327504
1756 * class.cs (Operator.Define): Refactored implicit and explicit user
1757 operator conversion rules.
1759 2007-10-05 Marek Safar <marek.safar@gmail.com>
1761 A fix for bug #327520
1762 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
1764 2007-10-04 Marek Safar <marek.safar@gmail.com>
1766 A fix for bug #328022
1767 * class.cs (MethodData.Define): Use correct method to check whether
1768 a method implementents an accessor.
1770 2007-10-04 Marek Safar <marek.safar@gmail.com>
1772 A fix for bug #330069
1773 * statement.cs (Fixed.Resolve): Read the first array element only when
1774 an array is instantiated.
1776 2007-10-04 Marek Safar <marek.safar@gmail.com>
1778 * expression.cs, assign.cs, generics.cs: Print correct operator when
1779 compound assignment is used.
1781 2007-10-04 Marek Safar <marek.safar@gmail.com>
1783 A fix for bug #325841
1784 * expression.cs (ArrayAccess): Use full argument cloning only for
1785 string compound concatenation.
1787 2007-10-03 Marek Safar <marek.safar@gmail.com>
1789 A fix for bug #328774
1790 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
1792 (PropertyExpr.EmitAssign): Fixed string concatenation compound
1795 2007-10-03 Raja R Harinath <rharinath@novell.com>
1798 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
1799 Event accessibility checks here. Remove some bogus code that
1800 accidently made GenericMethods work.
1801 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
1803 2007-09-25 Marek Safar <marek.safar@gmail.com>
1805 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
1807 * statement.cs (Block): Refactored AddVariable to allow error handling
1810 * generic.cs: New stub.
1812 2007-09-23 Marek Safar <marek.safar@gmail.com>
1814 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
1817 2007-09-17 Marek Safar <marek.safar@gmail.com>
1819 * class.cs: Use partial container to record whether any partial part
1820 contains static field initializer and therefore default contructor has
1823 2007-09-14 Marek Safar <marek.safar@gmail.com>
1825 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
1826 mono-list when only one of two partial parts has defined accessibility
1829 2007-09-14 Marek Safar <marek.safar@gmail.com>
1831 A fix for bug #82845
1833 * class.cs (TypeContainer): Set correct resolve context for all field
1836 2007-09-13 Marek Safar <marek.safar@gmail.com>
1838 * assign.cs: Fixed a crash when field is resolved twice with an error.
1840 * codegen.cs: Changed InFieldInitializer to be flag.
1842 * anonymous.cs, ecore.cs, expression.cs: Update after
1843 IsInFieldInitializer rename.
1845 * const.cs: Removed unused parameter.
1847 * class.cs: Changed the way how we resolve and emit field initializers.
1848 The field initilizers have to have access to contructor block to emit
1849 compiler generated code.
1851 2007-09-13 Marek Safar <marek.safar@gmail.com>
1853 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
1854 generics use TypeContainer instead.
1856 2007-09-12 Marek Safar <marek.safar@gmail.com>
1858 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
1860 * lambda.cs (ResolveParameters): Use more powerful
1861 InflateGenericArgument.
1863 * parameters.cs: Better exception message.
1865 2007-09-10 Marek Safar <marek.safar@gmail.com>
1867 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
1868 correct expression block type.
1870 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
1872 * expression.cs (Invocation): Extracted method group resolve to
1875 2007-09-07 Marek Safar <marek.safar@gmail.com>
1877 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
1878 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
1880 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
1881 generic extension methods.
1883 2007-09-06 Marek Safar <marek.safar@gmail.com>
1885 A fix for bug #82676 (Do I get it right now?)
1886 * convert.cs (Binary.ResolveOperator): An interface is converted to the
1887 object before a standard conversion is applied.
1889 2007-09-06 Marek Safar <marek.safar@gmail.com>
1891 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
1894 2007-09-05 Marek Safar <marek.safar@gmail.com>
1896 A fix for bug #82676
1897 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
1898 non-generic interface types.
1900 2007-09-05 Marek Safar <marek.safar@gmail.com>
1902 A fix for bug #82690
1903 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
1905 2007-09-05 Marek Safar <marek.safar@gmail.com>
1907 A fix for bug #82571
1908 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
1909 modifier for container based methods.
1911 2007-09-05 Marek Safar <marek.safar@gmail.com>
1913 A fix for bug #82676
1914 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
1915 any interface-type T means to any of interface type T.
1917 2007-09-04 Marek Safar <marek.safar@gmail.com>
1919 * namespace.cs: We have 2 versions of System.Core assembly.
1921 2007-09-04 Marek Safar <marek.safar@gmail.com>
1923 A fix for bug #82652
1924 * class.cs (Class.GetClassBases): Compare types and not expressions.
1926 2007-09-04 Marek Safar <marek.safar@gmail.com>
1928 A fix for bug #82620
1929 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
1930 actually never worked before.
1931 (IndexerAccess): Emit prepared arguments before they are modified.
1933 2007-09-04 Marek Safar <marek.safar@gmail.com>
1935 A fix for bug #82563
1936 * assign.cs: Revert wrong fix.
1938 * expression.cs (VariableReference.EmitAssign): Handle ref reference
1940 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
1941 Instead of ldelema/stdind we have to use temporary variables to handle
1942 cases like String.Concat (params string[]).
1944 2007-08-31 Marek Safar <marek.safar@gmail.com>
1946 * class.cs: EmitAttributes to Emit rename.
1948 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
1950 (MemberCore.HasClsCompliantAttribute): Don't depend on
1951 GetClsCompliantAttributeValue execution.
1953 2007-08-31 Marek Safar <marek.safar@gmail.com>
1955 * anonymous.cs: Use shorter type prefix.
1957 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
1960 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
1961 variables when probing is on.
1963 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
1964 unresolved variables.
1965 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
1966 handle transparent identifiers.
1968 2007-08-26 Marek Safar <marek.safar@gmail.com>
1970 * attribute.cs (IsClsCompliant): Add nullable types test.
1972 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
1974 * doc.cs : catch other types of exception than XmlException to
1975 report CS1570. Fixed bug #82565.
1977 2007-08-23 Marek Safar <marek.safar@gmail.com>
1979 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
1980 The number of delegate parameters has to match.
1981 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
1984 2007-08-21 Marek Safar <marek.safar@gmail.com>
1986 * anonymous.cs (AnonymousMethod): Generate private anonymous method
1987 to fix problem with private arguments.
1989 2007-08-20 Marek Safar <marek.safar@gmail.com>
1991 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
1993 * decl.cs (MemberName): Ignore generic type with no generic arguments.
1995 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
1996 empty. Add cloning suport.
1998 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
2000 2007-08-20 Marek Safar <marek.safar@gmail.com>
2002 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
2003 to create EmptyCast. It handles EmptyConstantCast specialization for
2006 2007-08-18 Marek Safar <marek.safar@gmail.com>
2008 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
2009 (EmitArrayArgument): One routine for array arguments.
2010 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
2012 2007-08-17 Marek Safar <marek.safar@gmail.com>
2014 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
2016 2007-08-17 Marek Safar <marek.safar@gmail.com>
2018 * anonymous.cs: MemberLookupFinal update.
2020 * class.cs (ConstructorInitializer): Is expression based.
2022 * delegate.cs: MethodGroupExpr update.
2024 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
2026 (Error_MemberLookupFailed): Customizable error override.
2027 (MethodGroupExpr): Keep queried type for later usage.
2028 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
2031 * expression.cs: Error_MemberLookupFailed refactoring.
2032 (New.DoResolve): Resolve as much as possible.
2033 (ElementInitializer.Error_MemberLookupFailed): Object initializer
2034 customization for invalid member types.
2036 * statement.cs: MethodGroupExpr update.
2038 2007-08-16 Marek Safar <marek.safar@gmail.com>
2040 * modifier.cs (Check): Check all modifiers and not only accessibility
2043 2007-08-16 Marek Safar <marek.safar@gmail.com>
2045 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
2046 type and not an expression.
2048 2007-08-16 Marek Safar <marek.safar@gmail.com>
2050 * statement.cs (Catch.Clone): Type and variable can be null.
2052 2007-08-16 Marek Safar <marek.safar@gmail.com>
2054 A fix for bug #81979
2055 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
2056 I am really not sure whether this is the best fix.
2058 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
2061 2007-08-14 Marek Safar <marek.safar@gmail.com>
2063 ** C# 3.0 Object and collection initializers (major re-write)
2065 * assign.cs (DoResolve): Initializers are not assign related.
2067 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
2068 used during collection or object initialization.
2070 * expression.cs (Error_InvalidArguments): Add initializers specific
2071 messages. More will come later because it requires some general
2073 (New.DoResolve): Better error handling for unsafe types.
2074 (EmptyExpressionStatement): New class.
2075 (ElementInitializer): An object initializer expression.
2076 (CollectionElementInitializer): A collection initializer expression.
2077 (CollectionOrObjectInitializers): A block of object or collection
2079 (NewInitialize): New expression with element/object initializers.
2081 * statement.cs: Reverted object/collection initializer hacks.
2083 * typemanager.cs (CSharpName): Filter __arglist type.
2085 2007-08-09 Marek Safar <marek.safar@gmail.com>
2087 ** C# 3.0 Anonymous Types (update to the latest standard)
2089 * expression.cs (Binary.ResolveOperator): Threat all null based types
2091 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
2092 (AnonymousTypeParameter): Updated.
2094 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
2095 (AnonymousTypeClass): New anonymous type container.
2097 * class.cs (AddField): Return operation result.
2099 * generic.cs: Another empty TypeArguments overload.
2101 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
2102 are stored at top of normal hierarchy.
2104 * typemanager.cs (CSharpName): Filter anonymous types.
2106 2007-08-09 Marek Safar <marek.safar@gmail.com>
2108 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
2109 as single Concat call. How could we miss that :-(
2111 2007-08-08 Marek Safar <marek.safar@gmail.com>
2113 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
2115 2007-08-07 Miguel de Icaza <miguel@novell.com>
2117 * expression.cs: Fix the previous commit, the creation of the
2118 arguments array list needs also to be conditional on the arguments
2121 * class.cs: Add a little bit of help to help narrow down problems.
2123 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
2124 not try to copy in that case.
2126 * driver.cs: When building SMCS, include a new different set of
2127 default assemblies here. Do this here so we can control whether
2128 to include the default assemblies with /noconfig.
2130 2007-08-03 Marek Safar <marek.safar@gmail.com>
2132 A fix for bug #81979
2133 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
2136 2007-08-03 Marek Safar <marek.safar@gmail.com>
2138 A fix for bug #82300
2140 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
2141 we are in probing scope.
2143 2007-08-03 Marek Safar <marek.safar@gmail.com>
2145 A fix for bug #82301
2147 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
2148 (Statement.CloneTo): Clone and not map children blocks.
2150 2007-08-03 Marek Safar <marek.safar@gmail.com>
2152 A fix for bug #82299
2154 * expression.cs (LocalVariableReference.CloneTo): Remap local info
2157 * statement.cs (Statement.CloneTo): Clone variables before statements
2158 to allow remaping of local variables.
2160 2007-08-03 Marek Safar <marek.safar@gmail.com>
2162 A fix for bug #82296
2165 * report.cs: Log crash details for future clone problems.
2167 * statement.cs (Return.Clone): Don't clone non-existent expression.
2169 2007-08-03 Raja R Harinath <harinath@gmail.com>
2171 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
2172 (Class.AddBasesForPart): Move CS0537 check here from ...
2173 * cs-parser.jay (class_declaration): ... here. Move calling of
2174 'AddBasesForPart' to ...
2175 (class_bases): ... here.
2176 (struct_declaration, interface_declaration): Update to changes.
2178 2007-08-02 Marek Safar <marek.safar@gmail.com>
2180 A fix for bug #81923
2182 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
2183 conversion is allowed.
2185 2007-08-02 Marek Safar <marek.safar@gmail.com>
2187 A fix for bug #81564
2189 * ecore.cs (EventExpr): Add IsBase handling.
2191 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
2194 2007-08-02 Raja R Harinath <harinath@gmail.com>
2196 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
2197 * cs-parser.jay: Some whitespace cleanups.
2198 (current_delegate): New.
2200 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
2201 a dummy code block, and use 'type_name' instead of 'member_name'.
2202 (interface_declaration, class_declaration): Likewise.
2203 (delegate_declaration): Likewise. Rearrange slightly and use
2205 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
2206 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
2208 2007-08-02 Marek Safar <marek.safar@gmail.com>
2210 A fix for bug #82039
2212 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
2215 * typemanager.cs (CSharpName): Split to string overload.
2217 2007-08-02 Marek Safar <marek.safar@gmail.com>
2220 * report.cs: Updated warning CS0472.
2222 2007-08-01 Marek Safar <marek.safar@gmail.com>
2224 A fix for bug #82181
2226 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
2228 2007-08-01 Marek Safar <marek.safar@gmail.com>
2230 A fix for bug #82277
2231 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
2233 2007-08-01 Marek Safar <marek.safar@gmail.com>
2235 ** C# 3.0 Type Inference (major bits are working)
2237 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
2238 (.ImplicitStandardConversionExists): Uses compatible.
2239 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
2240 (.InferReturnType): New method.
2241 (.Compatible): Refactored.
2242 (.ResolveParameters): Uses factory to create resolved parameters.
2243 (.CompatibleMethod): Add probing mode support.
2244 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
2245 clearly distinguish between 2 different operations.
2246 (LambdaMethod): Moved to lambda.cs.
2247 (AnonymousMethod): Removed unused fields and methods.
2248 (AnonymousDelegate): Simplified.
2250 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
2252 * convert. cs (ImplicitConversionStandard): Compatible works differently.
2254 * delegate.cs (Delegate): New mehods to reduce code duplication.
2255 (.GetConstructor): New method.
2256 (.GetInvokeMethod): New method.
2257 (DelegateCreation): Updated.
2259 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
2261 (OverloadResolve): Made probing little bit faster.
2263 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
2266 * generic.cs (TypeInferenceContext): Dummy implementation.
2268 * iterators.cs: Updated after Resolve/Define rename.
2270 * lambda.cs (LambdaExpression)
2271 (.ResolveParameters): Handles both type of arguments and type inference too.
2273 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
2274 (InflateTypes): Updated.
2276 * support.cs (InflateTypes): Changed signature and updated.
2278 * typemanager.cs (LookupMemberCache): Better dynamic type check.
2279 (MemberLookup_FindMembers): More MS tricks.
2280 (GetParameterData): Ditto.
2281 (GetDelegateParameters): Uses quick path for dynamic types.
2283 2007-08-01 Marek Safar <marek.safar@gmail.com>
2285 * class.cs (MethodData.Define): EmitContext is required for generic stuff
2288 2007-07-31 Marek Safar <marek.safar@gmail.com>
2290 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
2293 2007-07-26 Jb Evain <jbevain@novell.com>
2295 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
2296 which takes a boolean 'report_errors', similar to the GetMethod.
2297 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
2298 in .net 2.1, do not report errors here.
2300 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
2301 System.Runtime.CompilerServices.RequiredAttributeAttribute and
2302 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
2305 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
2306 of the type InternalsVisibleToAttribute before the first call
2307 to CoreLookupType which is allowed to fail (third boolean parameter
2308 to true). Because, during the resolution for a type that is not
2309 immediately found, we try to check if the type is not defined in
2310 a friend assembly, and to do so, we need the
2311 InternalVisibleToAttribute.
2313 2007-07-23 Miguel de Icaza <miguel@novell.com>
2315 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
2316 feature that allows structs to be compared against null and inline
2317 the result as true or false.
2319 Notice that the same code is not permitted inside a generic block
2320 of code that would do:
2322 class Foo<T> where T : struct {
2329 It is only allowed if the type of T is not bound (no where
2330 clause). In my opinion, this CSC 2 behavior is broken but people
2331 seem to be using it (IronRuby does, a few bug reports on bugzilla
2332 have it and some people have complained about it).
2334 All of the users that depend on this behavior have code that is
2337 * report.cs (Warning, Error): make these take object arguments,
2338 not strings, as that allows us to take advantage of Format.
2340 2007-07-20 William Holmes <billholmes54@gmail.com>
2342 * decl.cs: Changed MemberName.CountTypeArguments to also check the
2343 Left member variable for the Count.
2344 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
2345 MemberName.CountTypeArguments to avoid a NRE.
2347 This code is contributed under the MIT X11 license
2349 2007-07-18 Marek Safar <marek.safar@gmail.com>
2351 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
2353 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2355 * doc.cs : generic method arguments are written as ``x while generic
2356 type arguments are `x. Combined with the previous change, fixed bug
2359 2007-07-18 Raja R Harinath <rharinath@novell.com>
2362 * expression.cs (Binary.ResolveOperator): When converting
2363 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
2365 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2367 * doc.cs : when T: or whatever x: is specified, it does not really
2368 check the doc comment's syntax correctness. Fixed bug #82006.
2370 2007-07-18 Marek Safar <marek.safar@gmail.com>
2372 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
2373 LambdaExpression better.
2375 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
2377 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
2379 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
2380 as it can be generated.
2382 * expression.cs (Invocation.Error_InvalidArguments): Show correct
2385 * lambda.cs (LambdaExpression): Refactored to share same code with
2386 AnonymousMethodExpression.
2388 2007-07-17 Marek Safar <marek.safar@gmail.com>
2390 * anonymous.cs (MakeName): Include host name for easier debugging.
2391 (LambdaMethod): New class for lambda spcecific stuff.
2393 * attribute.cs: Set EmitContext return type.
2395 * class.cs: Set EmitContext return type.
2397 * codegen.cs (EmitContext): Return type cannot be null to stop messing
2398 with null/void meaning.
2400 * iterators.cs (ContainerType): Implemented.
2402 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
2404 * statement.cs (Return): Updated to lambda expressions.
2405 (Block.CloneTo): Parent can be null.
2407 2007-07-13 Marek Safar <marek.safar@gmail.com>
2409 A fix for bug #81917
2410 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
2412 * class.cs (FixedField): Check whether field is in unsafe scope.
2414 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
2415 (FieldExpr.Emit): Fixed buffers cannot be volatile.
2417 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
2420 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
2422 2007-07-13 Marek Safar <marek.safar@gmail.com>
2424 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
2425 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
2428 2007-07-13 Marek Safar <marek.safar@gmail.com>
2430 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
2432 2007-07-13 Marek Safar <marek.safar@gmail.com>
2434 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
2435 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
2437 * codegen.cs(EmitContext): Add ProbingMode flag.
2439 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
2441 * driver.cs: For now set both warning values.
2443 * ecore.cs (SimpleName): Name is readonly.
2444 (MethodGroup.OverloadResolve): One quick path for probing.
2446 * expression.cs (Unary): Set Oper r/o.
2447 (Binary): Set Oper r/o.
2448 (ParameterReference): Set few instance variables as r/o.
2449 (ParameterReference.DoResolveBase): Don't capture aruments when
2451 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2452 (Arglist): arguments are private.
2453 (SizeOf): type is private and r/o.
2454 (MemberAccess): arguments are private.
2456 * report.cs: Enhanced reporting on/off capabilities.
2458 * lambda.cs: Uses ec.IsInProbingMode.
2459 (ContextualReturn): Derives from return.
2461 * rootcontext.cs: For now set both warning values.
2463 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2465 (Return.Resolve): Don't die immediately.
2466 (Block.Resolve): Speed-up probing.
2467 (Block.CloneTo): Clone only child blocks.
2469 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2471 * iterators.cs: reverted Miguel's latest change (r81925) as it
2472 breaks the build in System.
2474 2007-07-13 Miguel de Icaza <miguel@novell.com>
2476 * iterators.cs (Yield.CheckContext): Check for the iterator type
2477 also here as we can call into Yield even in codepaths that are not
2479 (MethodOrOperator is the only path that was checked).
2481 In addition to the standard check, use a more specific check for
2482 constructors to report a more verbose error.
2484 2007-07-12 Miguel de Icaza <miguel@novell.com>
2486 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2487 report the warning and continue
2489 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2490 values on the stack on the call to Emit. Use EmitStatement if
2491 possible, or using Emit + Pop if not possible. Fixes #82064
2493 2007-07-12 Raja R Harinath <rharinath@novell.com>
2495 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2496 avoid try...finally in some cases.
2498 2007-07-10 Marek Safar <marek.safar@gmail.com>
2500 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2502 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2503 instead of method. Re-use standard error handling.
2504 (ConstructorInitializer.Emit): Simplified.
2506 * delegate.cs: Updated after Invocation.EmitCall change.
2508 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2509 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2510 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2511 method and don't permanently changing input arguments.
2512 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2513 is resolved it has one of the candidates is the best one which is later
2514 used to emit. Removed a few unused method.
2515 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2517 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2518 (Binary.ResolveOperator): Ditto.
2519 (ConditionalLogicalOperator.DoResolve): Ditto.
2520 (Invocation): Uses method group.
2521 (Invocation.DoResolve): Simplified.
2522 (Invocation.EmitCall): Removed useless is_static.
2523 (Invocation.Emit): Delegate to method group.
2524 (Invocation.EmitStatement): Simplified.
2525 (New): Uses method group.
2526 (MemberAccess.DoResolve): Don't destroy original expression.
2528 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2530 2007-07-04 Marek Safar <marek.safar@gmail.com>
2532 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2535 * lambda.cs: Add custom error message type.
2537 2007-07-03 Marek Safar <marek.safar@gmail.com>
2539 * lambda.cs: Simplified little bit.
2541 * parameter.cs: Introduced ImplicitLambdaParameter.
2542 (Parameters.CreateFullyResolved): New factory instead of ctor.
2546 * delegate.cs: Updated parameter creation.
2548 2007-07-03 Marek Safar <marek.safar@gmail.com>
2550 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2553 * generic.cs: Synchronized with gmcs.
2555 2007-07-03 Marek Safar <marek.safar@gmail.com>
2557 * class.cs (Indexer): Check return type as soon as possible.
2559 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2562 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2564 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2566 * parameter.cs (Parameter): Use expression type when it is available.
2568 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2569 method modifier for the first parameter only.
2571 2007-06-24 Marek Safar <marek.safar@gmail.com>
2573 A fix for bug #81938
2574 * typemanager.cs (ChangeType): Fixed couple of char conversions.
2576 * constant.cs: Tide up an exception message.
2578 2007-06-22 Marek Safar <marek.safar@gmail.com>
2580 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
2581 an uninitialized variable is used.
2583 * expression.cs (LocalVariableReference.DoResolve): Ditto.
2585 2007-06-22 Marek Safar <marek.safar@gmail.com>
2587 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
2588 not found error handling.
2590 * expression.cs (ArrayCreation): Removed redundant fields and little bit
2592 (ArrayCreation.ResolveArrayElement): To be ready to customization.
2593 (ArrayCreation.DoResolve): Simplified.
2594 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
2595 its own resolve process.
2596 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
2598 2007-06-20 Marek Safar <marek.safar@gmail.com>
2600 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
2603 2007-06-20 Marek Safar <marek.safar@gmail.com>
2605 * cs-tokenizer.cs: Removed var related stuff.
2607 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
2608 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
2609 a type and a keyword at same time.
2611 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
2614 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
2615 implicitly typed arrays, more changes will follow.
2617 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
2619 2007-06-19 Marek Safar <marek.safar@gmail.com>
2621 * ecore.cs (VarExpr): Removed Handled field.
2623 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
2624 build-in assign functionality.
2625 (ForEach.Resolve): Removed all implicitly typed local variable code and
2627 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
2628 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
2630 2007-06-18 Marek Safar <marek.safar@gmail.com>
2632 * assign.cs: Removed implicitly typed local variable check.
2634 * expression.cs (LocalVariableReference.DoResolve): Add check for self
2635 referencing implicitly typed local variable.
2636 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
2639 * statement.cs (Fixed): Removed unsupported implicitly typed local
2642 2007-06-15 Marek Safar <marek.safar@gmail.com>
2644 * decl.cs (MemberName): Moved all Unbound stuff to parser.
2646 2007-06-14 Marek Safar <marek.safar@gmail.com>
2648 A fix for bugs #81855 and #76274
2649 * attribute.cs (AttachTo): Always set owner for global attributes to
2652 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
2655 * cs-parser.jay: Assembly and module attributes must precede all other
2656 elements except using clauses and extern alias declarations.
2658 2007-06-13 Marek Safar <marek.safar@gmail.com>
2660 A fix for bug #81748
2662 * expression.cs: More checks for non ISO-1 features.
2664 2007-06-12 Marek Safar <marek.safar@gmail.com>
2666 A fix for bug #81807
2667 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
2668 present inside switch statement and it is required by nullable check.
2670 2007-06-12 Marek Safar <marek.safar@gmail.com>
2672 A fix for bug #81840
2673 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
2674 when type matching fails.
2676 * namespace.cs: Tiny error message change.
2678 2007-06-12 Marek Safar <marek.safar@gmail.com>
2680 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
2681 reporting. Added automatic property check.
2683 * class.cs: Updated after CheckAbstractAndExtern relocation.
2684 (AEventPropertyAccessor.GetSignatureForError): Customized.
2686 2007-06-11 Marek Safar <marek.safar@gmail.com>
2688 * class.cs (DefineBaseTypes): Base type can be undefined.
2690 * ecore.cs (TypeLookup): Minor refactoring.
2691 (DoResolveAsTypeStep): Removed redundant check.
2693 * namespace.cs (Lookup): Removed redundant check.
2695 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
2696 ResolveAsTypeTerminal step.
2697 (BootstrapCorlib_*): Simplified.
2698 (PopulateCoreType): Core types can be now external.
2700 2007-06-07 Marek Safar <marek.safar@gmail.com>
2702 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
2704 (InferTypeArguments): Infers anonymous expression type arguments.
2705 (Compatible): Split to Compatible and InferTypeArguments.
2707 * lambda.cs: Updated.
2709 2007-06-08 Marek Safar <marek.safar@gmail.com>
2711 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
2713 2007-06-07 Raja R Harinath <harinath@gmail.com>
2715 Fix #80477, cs0135-2.cs, cs0135-3.cs
2716 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
2717 names to the "known" variables list.
2718 (Block.CheckInvariantMeaningInBlock): Handle the fact the
2719 parameter names are also "known".
2720 (Block.CheckError136): Remove.
2721 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
2724 2007-06-07 Marek Safar <marek.safar@gmail.com>
2726 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
2728 2007-06-06 Marek Safar <marek.safar@gmail.com>
2730 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
2731 internal error not an user error.
2733 * expression.cs (IsApplicable): Refactored to make debugging easier.
2735 * support.cs: More tricks for non-mono runtimes.
2737 * typemanager.cs (CoreLookupType): Made public.
2738 (InitSystemCore): All linq specific stuff moved to linq.cs
2740 2007-06-05 Marek Safar <marek.safar@gmail.com>
2742 * typemanager.cs (CSharpSignature): One more missing build-in types
2744 More tricks for non-mono runtime.
2746 2007-06-05 Raja R Harinath <harinath@gmail.com>
2748 * statement.cs (Block.CheckError136_InParents): Remove.
2749 (Block.AddVariable): Use GetParameterInfo instead.
2750 (ToplevelBlock.ProcessArguments): Likewise.
2752 2007-06-04 Raja R Harinath <rharinath@novell.com>
2754 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
2756 (ToplevelBlock.GetParameterInfo): Split out of ...
2757 (ToplevelBlock.GetParameterRefernce): ... this.
2758 (ToplevelBlock.ParameterMap): Remove.
2759 * expression.cs (ParameterReference): Update to use
2760 ToplevelParameterInfo.
2762 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
2765 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
2766 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
2768 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
2769 (ToplevelBlock.ProcessParameters) ... here.
2770 (ToplevelBlock..ctor): Invoke it.
2772 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
2775 * statement.cs (IKnownVariable): New interface.
2776 (LocalInfo): Implement it.
2777 (ToplevelParameterInfo): New class.
2778 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
2779 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
2780 GetKnownVariableInfo.
2782 2007-06-03 Raja R Harinath <harinath@gmail.com>
2784 Partly speed up CS0136 error checks.
2785 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
2786 'recurse' parameter.
2787 (Block.DoCheckError136): Only check errors in parameters. Move
2788 local variable checks ...
2789 (Block.AddVariable): ... here, and ...
2790 (ToplevelBlock.ResolveMeta): ... here.
2792 2007-06-02 Raja R Harinath <harinath@gmail.com>
2794 * statement.cs (Block.IsChildOf): Remove.
2796 * statement.cs (Statement.Clone): Move special case code ...
2797 (Block.CloneTo): ... here.
2799 2007-05-29 Raja R Harinath <rharinath@novell.com>
2801 * statement.cs (ToplevelBlock.container): Remove field. It's
2802 redundant with 'Parent'.
2803 (ToplevelBlock.ContainerBlock): Remove accessor.
2804 (ToplevelBlock..ctor): Update to changes. Register anonymous
2805 child with parent here, ...
2806 * cs-parser.jay (end_anonymous): ... not here. Don't modify
2808 (start_anonymous): Don't save current_block.
2809 (top_current_block): Remove.
2811 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
2812 (Block.Resolve): Update to changes.
2813 (Block..ctor): Move setting of "correct" 'Toplevel'
2814 and 'Explicit' fields to ...
2815 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
2817 2007-05-27 Raja R Harinath <harinath@gmail.com>
2820 * statement.cs (Block.Implicit): Remove.
2821 (Block): Update to changes.
2822 * flowanalysis.cs: Likewise.
2824 Mildly speed up CheckInvariantMeaningInBlock
2825 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
2826 Recursively call AddKnownVariable to all enclosing blocks.
2827 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
2828 Remove recursive calls.
2829 (Block): Update to changes.
2831 New ExplicitBlock invariants
2832 * statement.cs (Block.Explicit): New field. It points to the
2833 immediately enclosing non-implicit block.
2834 (Block..ctor): Maintain the invariant.
2835 * cs-parser.jay: Take advantage of invariant.
2837 Introduce ExplicitBlock
2838 * statement.cs (ExplicitBlock): New.
2839 (ToplevelBlock): Derive from it.
2840 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
2842 (Block.Implicit): Update to changes.
2843 * cs-parser.jay: Update to changes.
2846 * codegen.cs (EmitContext.IsLastStatement): Remove.
2847 * statement.cs (Block.DoEmit): Update to changes.
2849 2007-05-25 Raja R Harinath <rharinath@novell.com>
2851 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
2852 modifying current_block directly.
2854 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
2856 * class.cs: Implemented automatic properties (C# 3.0)
2857 Thanks to Marek for the help.
2859 2007-05-23 Raja R Harinath <rharinath@novell.com>
2861 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
2862 variable as assigned, note also that all its components are
2864 (MyBitVector.SetRange): New. Function to set multiple bits to true.
2866 2007-05-19 Marek Safar <marek.safar@gmail.com>
2868 * anonymous.cs, class.cs: Emit Compiler generated attribute when
2869 member is marked as compiler generated.
2871 * decl.cs (MemberCore): Refactored ModFlags into property.
2873 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
2874 (Check): Check only accessibility modifiers.
2876 2007-05-18 Raja R Harinath <rharinath@novell.com>
2878 Track all assignable slots in one bit array
2879 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
2880 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
2881 logic from VariableMap constructor here. Use the same 'offset'
2882 variable that's later used for computing offsets of local
2884 * flowanalysis.cs (UsageVector.parameters): Remove.
2885 (UsageVector): Update to changes.
2886 (VariableMap): Remove.
2888 Avoid creating ParameterMap in every block
2889 * statement.cs (Block.ParameterMap): Move ...
2890 (ToplevelBlock.ParameterMap): ... here.
2891 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
2893 * flowanalysis.cs (FlowBranching.param_map): Remove.
2894 (FlowBranching.UsageVector): Update to changes.
2895 (FlowBranchingToplevel.CheckOutParameters): Likewise.
2897 * statement.cs (Block.CloneTo): Clone Toplevel field too.
2899 * expression.cs (ParameterReference): Distinguish between block
2900 where parameter was referenced and declared.
2902 2007-05-18 Marek Safar <marek.safar@gmail.com>
2904 * flowanalysis.cs, statement.cs: Put back improved error handling.
2906 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
2910 Imporved object and collection initialization (C# 3.0).
2912 2007-05-15 Marek Safar <marek.safar@gmail.com>
2914 A fix for bug #81380
2915 * expression.cs (Is.DoResolve): Only value types have constant `is'
2918 2007-05-15 Raja R Harinath <rharinath@novell.com>
2920 * statement.cs (ToplevelBlock.child): Remove.
2922 2007-05-15 Raja R Harinath <harinath@gmail.com>
2924 Rationalize ResolveMeta: refactoring
2925 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2926 out constant handling code into ...
2927 (Block.DoResolveConstants): ... this.
2929 Rationalize ResolveMeta: kill local_map
2930 * statement.cs (Block.local_map, Block.LocalMap): Remove.
2931 (Block.AssignableSlots): New.
2932 (Block.ResolveMeta): Make protected. Don't create a VariableMap
2933 for locals -- move code from VariableMap here. Avoid unnecessary
2935 * flowanalysis.cs (FlowBranching.local_map): Remove.
2936 (FlowBranching..ctor): Use Block.AssignableSlots.
2937 (VariableMap): Remove unused constructors.
2939 2007-05-11 Raja R Harinath <rharinath@novell.com>
2941 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
2943 2007-05-11 Marek Safar <marek.safar@gmail.com>
2945 * typemanager.cs (IsFriendAssembly): Should not be called for building
2948 2007-05-09 Marek Safar <marek.safar@gmail.com>
2950 * literal.cs (NullConstant): Print null in all cases.
2952 * expression.cs (Binary.ResolveOperator): Implemented delegate
2953 comparison based on C# 2.0 changes.
2955 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
2957 This code is contributed under the MIT X11 license
2959 The following enables support for several C# 3.0 language features:
2961 * cs-tokenizer.cs: Added support for the "var" keyword.
2963 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
2964 Added VarExpr class to facilitate type inferencing.
2966 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
2967 to support anonymous types.
2969 * assign.cs: Added support for type inferencing and initialization.
2971 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
2973 * expression.cs: Added implicit array support to ArrayCreation.
2974 Added 5 types and 1 interface:
2976 IInitializable Implementing classes can inject initializing
2977 statements after object instantiation.
2979 Initializer Stores data for object initialization.
2981 AnonymousType An expression for anonymous types.
2983 AnonymousTypeParameter Stores data about an anonymous type's field.
2985 NewInitialize An expression for object initialization.
2987 CollectionInitialize An expression for collection initialization.
2989 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
2992 2007-05-06 Marek Safar <marek.safar@gmail.com>
2994 A fix for bug #81500
2995 * cs-tokenizer.cs: Add special handling for coalescing operator.
2997 2007-05-06 Marek Safar <marek.safar@gmail.com>
2999 A fix for bug #81529
3000 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
3001 its value from base class until it is redefined.
3003 2007-05-02 Raja R Harinath <rharinath@novell.com>
3005 Fix regression in cs0631-3.cs
3006 * cs-parser.jay (operator_declarator): Add opt_attributes to error
3007 fallback. Make error fallback catch more cases.
3009 2007-05-01 Miguel de Icaza <miguel@novell.com>
3011 * cs-parser.jay: Allow parameters in operator declarations to have
3014 2007-04-27 Miguel de Icaza <miguel@novell.com>
3016 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
3019 * lambda.cs (ContextualReturn.Resolve): An expression is valid
3020 inside the ContextualReturn, it does not have to be an
3021 ExpressionStatement.
3023 2007-04-24 Miguel de Icaza <miguel@novell.com>
3025 * lambda.cs (ContextualReturn.Resolve): if the return type is not
3028 2007-04-23 Miguel de Icaza <miguel@novell.com>
3030 * anonymous.cs (AnonymousContainer): split the virtual Resolve
3031 method in two methods: ResolveNoDefine and Resolve.
3033 ResolveNoDefine will stop just after ResolveTopBlock has been
3036 Resolve will then continue by creating a method and issuing the
3037 call to method.Define ().
3039 (AnonymousMethod): Split and implement the new Resolve and
3040 ResolveNoDefine as well.
3042 * lambda.cs (LambdaExpression): Split the anonymous method
3043 resolution code into a separate routine (CoreCompatibilityTest)
3044 from DoCompatibleTest.
3046 (LambdaExpression.TryBuild): New method, this method tries to
3047 build the LambdaExpression with the given set of types to be used
3048 as the types for the various parameters of the lambda expression.
3050 If the compilation succeed with the given types, the infered type
3051 of the Anonymous method is returned, otherwise null is returned.
3053 2007-04-23 Marek Safar <marek.safar@gmail.com>
3055 A fix for bug #81414
3056 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
3058 2007-04-22 Miguel de Icaza <miguel@novell.com>
3060 * cs-tokenizer.cs: Change various identifiers here from the
3061 camelCasing to the recommended Linux-like style for instance
3062 variables from the Coding Guidelines.
3064 2007-04-19 Martin Baulig <martin@ximian.com>
3067 (Convert.ImplicitReferenceConversionCore): Allow conversions from
3068 System.Enum to System.ValueType.
3070 2007-04-13 Martin Baulig <martin@ximian.com>
3072 Rewrote implicit reference conversions. We need to distinguish
3073 between implicit reference conversions (13.1.4) and implicit
3074 boxing conversions (13.1.5).
3076 According to the spec, there's an an implicit conversion
3077 "From a one-dimensional array-type S[] to IList<T> and base
3078 interfaces of this interface, provided there is an implicit
3079 reference conversion from S to T." Note that this does not
3080 include boxing conversions.
3083 (Convert.ImplicitTypeParameterBoxingConversion): New method.
3084 (Convert.ImplicitReferenceConversion): Split into
3085 ImplicitReferenceConversionCore() and
3086 ImplicitBoxingConversionExist().
3087 (Convert.ImplicitReferenceConversionExists): Use the new
3088 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
3090 2007-04-12 Martin Baulig <martin@ximian.com>
3092 * convert.cs (Convert.ImplicitReferenceConversion): Move the
3093 `TypeManager.null_type' checks up to the top of the method.
3095 2007-04-11 Marek Safar <marek.safar@gmail.com>
3097 A fix for bug #81350
3098 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
3101 2007-04-11 Martin Baulig <martin@ximian.com>
3103 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
3104 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
3105 to make this work for generic classes; fixes #79561.
3107 2007-04-11 Martin Baulig <martin@ximian.com>
3109 * expression.cs (As): Add support for nullable types; fixes #79371.
3111 2007-04-11 Martin Baulig <martin@ximian.com>
3113 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
3114 `type.FullName' is null; fixes #80243.
3116 2007-04-11 Martin Baulig <martin@ximian.com>
3118 * expression.cs (Invocation.IsApplicable): Don't modify the method
3119 if type inference succeeded, but the method was not applicable.
3122 2007-04-10 Marek Safar <marek.safar@gmail.com>
3124 A fix for bug #81324
3125 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
3126 internal and external namespaces containers.
3128 2007-04-10 Martin Baulig <martin@ximian.com>
3130 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
3131 TypeManager.DropGenericMethodArguments() so we also call
3132 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
3134 2007-04-10 Martin Baulig <martin@ximian.com>
3136 * iterators.cs (Iterator.CreateIterator): Don't crash if
3137 `method.ReturnType' is null. This happens if something went wrong
3138 while resolving that typ (we already reported an error in this case).
3140 2007-04-10 Martin Baulig <martin@ximian.com>
3142 * expression.cs (New.DoResolve): Don't call CheckComImport() on
3143 generic interfaces; report the CS0144 directly.
3145 2007-04-10 Martin Baulig <martin@ximian.com>
3147 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
3148 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
3150 2007-04-10 Martin Baulig <martin@ximian.com>
3152 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
3154 2007-04-09 Raja R Harinath <rharinath@novell.com>
3157 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
3158 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
3161 * statement.cs (For.Resolve): If resolution fails, use
3164 2007-04-08 Marek Safar <marek.safar@gmail.com>
3166 * anonymous.cs (MakeName): Make faster and zero-based.
3167 (VerifyExplicitParameterCompatibility): Back to mode where generic
3168 parameter is ignored.
3169 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
3171 * class.cs (EmitType): Method can emit another new method.
3173 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
3175 * driver.cs: Updated.
3177 * lambda.cs: Reuse predefined empty parameters.
3179 * parameter.cs: Updated
3181 * support.cs: Implemented InflateTypes.
3183 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
3184 (InitSystemCore): Introduced to isolate 3.0 dependencies.
3186 2007-04-03 Martin Baulig <martin@ximian.com>
3190 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
3191 version of TypeManager.IsOverride() which also works with generic
3194 2007-04-03 Martin Baulig <martin@ximian.com>
3199 (Convert.ExplicitReferenceConversion): We need to cast when
3200 converting from IList<T> to S[].
3202 2007-04-01 Marek Safar <marek.safar@gmail.com>
3204 * decl.cs (FindExtensionMethods): Consider all candidates with same name
3207 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
3209 2007-03-31 Marek Safar <marek.safar@gmail.com>
3211 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
3212 argument and return type inferring.
3214 * codegen.cs (InferReturnType): Flag whether return can be inferred.
3215 (ReturnType): Turned to property.
3217 * statement.cs (Return): Implemented return type inferring.
3219 * support.cs (ReflectionParameters): Use local types if possible.
3221 2007-03-30 Raja R Harinath <rharinath@novell.com>
3223 * flowanalysis.cs (FlowBranching.Reachability): Remove.
3224 (FlowBranching.UsageVector): Update to changes.
3226 Prepare to kill 'Reachability'
3227 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
3228 argument of constructor.
3230 2007-03-29 Raja R Harinath <rharinath@novell.com>
3232 Prepare to kill 'Reachability'
3233 * flowanalysis.cs (UsageVector.is_unreachable): New.
3234 (UsageVector): Update to maintain 'is_unreachable' in parallel to
3235 'reachability', and verify they're consistent.
3238 * expression.cs (New.EmitStatement): Handle type parameters here too.
3240 2007-03-29 Martin Baulig <martin@ximian.com>
3245 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
3246 CompilerGeneratedClass.
3247 (ScopeInfo.EmitScopeInstance): Make this protected.
3248 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
3249 `ec.CurrentAnonymousMethod.Scope == Scope'.
3251 * statement.cs (Block.ScopeInfo): Make this a property.
3253 2007-03-27 Raja R Harinath <harinath@gmail.com>
3255 Prepare to kill 'Reachability'
3256 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
3257 (FlowBranching.UsageVector.Reachability): Remove property.
3258 (FlowBranching.UsageVector.IsUnreachable): New property.
3259 (FlowBranching.UsageVector.ResetBarrier): New.
3260 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
3261 * codegen.cs, statement.cs: Update to changes.
3263 2007-03-27 Martin Baulig <martin@ximian.com>
3268 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
3271 2007-03-26 Raja R Harinath <rharinath@novell.com>
3273 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
3274 instead of TriState. Remove all mention of TriState.
3276 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
3277 replaced by a boolean. Add boolean 'is_unreachable' field, check
3278 and maintain invariants.
3280 2007-03-25 Marek Safar <marek.safar@gmail.com>
3282 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
3284 2007-03-25 Marek Safar <marek.safar@gmail.com>
3286 * expression.cs: Stop using obsolete 2.0 opcodes.
3288 2007-03-25 Marek Safar <marek.safar@gmail.com>
3290 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
3291 one of the latests Martin's fixes.
3293 2007-03-23 Miguel de Icaza <miguel@novell.com>
3295 * expression.cs: On BigEndian systems, swap the bytes, temporary
3296 solution until we get a new bitconverter class.
3298 2007-03-23 Martin Baulig <martin@ximian.com>
3302 * decl.cs (MemberCache.AddMembers): Add generic methods both as
3303 "Method" and "Method`1". Normally, a cache lookup is done on the
3304 "Method" form (ie. without the generic arity), but this one makes
3305 lookups on the full form work as well.
3307 2007-03-22 Raja R Harinath <rharinath@novell.com>
3309 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
3312 2007-03-20 Bill Holmes <billholmes54@gmail.com>
3314 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
3315 ordered_member_list, to TypeBuilder to store members to be defined
3316 in the order they were parsed in.
3317 - ordered_explicit_member_list contains all properties indexers
3318 and methods that are defined as explicit implementation of an
3319 interface or base class.
3320 - ordered_member_list contains all properties indexers and methods
3321 that are not defined as explicit implementation of an interface
3324 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
3325 functionality in these removed classes has been replaced with
3326 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
3327 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
3329 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
3330 to CheckForDuplications inside GetMethod and SetMethod Define Method
3331 to handle method property and indexer name conflicts.
3335 All code is contributed under the MIT/X11 license.
3337 2007-03-20 Martin Baulig <martin@ximian.com>
3339 * class.cs (TypeContainer.Interfaces): Removed; they're now
3340 included in `TypeContainer.Types'.
3342 2007-03-20 Martin Baulig <martin@ximian.com>
3344 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
3346 * class.cs (TypeContainer.CreateType): New public method. This is
3347 now called before DefineType() to create the TypeBuilders.
3348 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
3349 has already been created by CreateType().
3350 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
3351 don't resolve our base classes here; this has been moved into
3352 DefineBaseTypes(). We're now called from CreateType().
3353 (TypeContainer.DefineBaseTypes): New private method; resolve our
3354 base classes here. We're now called from DefineType().
3357 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
3358 our types first to create all the TypeBuilders. After that, call
3359 TypeContainer.DefineType() on all the types which'll resolve their
3360 base classes and setup the resolve order.
3362 2007-03-20 Martin Baulig <martin@ximian.com>
3364 * class.cs (TypeContainer.Enums): Removed; they're now included in
3365 `TypeContainer.Types'.
3367 2007-03-20 Martin Baulig <martin@ximian.com>
3370 (TypeContainer.DefineType): Don't call ResolveMembers() here.
3371 (TypeContainer.DoResolveMembers): Call DefineType() on our
3372 `compiler_generated' classes; moved here from DefineNestedTypes().
3375 (RootContext.ResolveTree): Call ResolveMembers() on all
3376 TypeContainer's in the `type_container_resolve_order'.
3378 2007-03-19 Marek Safar <marek.safar@gmail.com>
3380 * class.cs: Use corlib to handle InternalMethodImplAttribute.
3382 2007-03-17 Marek Safar <marek.safar@gmail.com>
3384 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
3385 implementation flags.
3387 2007-03-17 Marek Safar <marek.safar@gmail.com>
3389 * class.cs: More optimizations for type parameters.
3391 2007-03-15 Marek Safar <marek.safar@gmail.com>
3393 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
3395 * ecore.cs, parameter.cs: More common code for both corlibs.
3397 * typemanager.cs (IsGenericMethod): Simplified.
3399 2007-03-15 Raja R Harinath <rharinath@novell.com>
3401 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3403 * statement.cs, iterators.cs, lambda.cs: Update to changes.
3405 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
3406 unconditionally. Simplify explanation.
3407 (Try.Resolve, Using.Resolve): Likewise.
3409 2007-03-15 Martin Baulig <martin@ximian.com>
3413 * decl.cs (DeclSpace): If we're a partial class, use our
3414 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
3416 2007-03-15 Raja R Harinath <rharinath@novell.com>
3418 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3420 (FlowBranching.UsageVector): Update to changes.
3421 (FlowBranching.MergeSiblings): Likewise.
3422 * statement.cs: Likewise.
3424 2007-03-15 Martin Baulig <martin@ximian.com>
3429 (MemberCache): Added a special .ctor for type parameters.
3432 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
3435 2007-03-09 Martin Baulig <martin@ximian.com>
3437 * enum.cs (Enum): Make this a TypeContainer.
3438 (EnumMember): Derive from `Const'.
3441 (Const.DoResolveValue): New protected virtual method; move most of
3442 the functionality of ResolveValue() here so we can override it in
3444 (Const.CreateConstantReference): Make this virtual.
3446 * class.cs (Kind): Add `Kind.Enum'.
3447 (TypeContainer.Emit): Don't emit the enums here; they're already
3448 in the `RootContext.typecontainer_resolve_order'.
3450 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
3451 here; they're already in the `typecontainer_resolve_order'.
3453 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3454 TypeManager.DropGenericTypeArguments().
3457 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3458 (TypeManager.IsEnumType): Likewise.
3459 (TypeManager.EnumToUnderlying): Likewise.
3460 (TypeManager.IsEqual): Add support for enums.
3462 2007-03-12 Raja R Harinath <rharinath@novell.com>
3464 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3465 DefaultParameterValueAttribute to be undefined, say if System.dll
3468 2007-03-11 Marek Safar <marek.safar@gmail.com>
3470 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3473 2007-03-10 Marek Safar <marek.safar@gmail.com>
3475 * class.cs, parameter.cs: Unified parameters verification.
3477 2007-03-08 Martin Baulig <martin@ximian.com>
3479 * cs-parser.jay (constructor_header): Pass the location to the
3480 newly created TopLevelBlock.
3482 2007-03-07 Martin Baulig <martin@ximian.com>
3484 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3486 2007-03-06 Miguel de Icaza <miguel@novell.com>
3488 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3489 with the changes from David, fixes the build.
3491 2007-03-05 David Mitchell <dmitchell@logos.com>
3493 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3494 and its base interfaces to a one-dimensional array type S[],
3495 provided there is an implicit or explicit reference conversion
3498 2007-03-03 Marek Safar <marek.safar@gmail.com>
3500 * cs-tokenizer.cs: Implemented basic linq grammar.
3502 * driver.cs: Set linq lang version on demand.
3504 2007-02-26 Marek Safar <marek.safar@gmail.com>
3506 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3508 2007-02-25 Marek Safar <marek.safar@gmail.com>
3510 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3513 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3515 Check property and event extern attributes.
3517 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3520 2007-02-24 Marek Safar <marek.safar@gmail.com>
3522 A fix for bug #80407
3523 * ecore.cs: Don't report ambiguity error when methods have same parent.
3525 2007-02-23 Marek Safar <marek.safar@gmail.com>
3527 A fix for bug #80878
3528 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3530 2007-02-22 Marek Safar <marek.safar@gmail.com>
3532 * attribute.cs: Enable ExtensionAttribute presence test.
3534 2007-02-22 Marek Safar <marek.safar@gmail.com>
3536 * class.cs: Warn about missing GetHashCode only when Equals is override.
3538 * decl.cs: Check accessibility of type arguments.
3540 * typemanager.cs: Correctly report nullable array.
3542 2007-02-20 Marek Safar <marek.safar@gmail.com>
3544 * class.cs, report.cs: Capture more details when things go wrong.
3546 2007-02-20 Marek Safar <marek.safar@gmail.com>
3548 A fix for bug #80650
3549 * cs-parser.jay: Anonymous container starts at constructor declaration
3550 and not at block beginning because it has to be usable in constructor
3553 * statement.cs: Use context location and not block one for error reporting.
3555 2007-02-18 Marek Safar <marek.safar@gmail.com>
3557 A fix for bug #78712
3558 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3561 2007-02-18 Marek Safar <marek.safar@gmail.com>
3563 A fix for bug #80493 by Atsushi Enomoto
3564 * cs-parser.jay: Ignore invalid attribute target.
3566 2007-02-18 Marek Safar <marek.safar@gmail.com>
3568 * cs-tokenizer.cs: Ignore '\0' as white space character.
3570 2007-02-17 Miguel de Icaza <miguel@novell.com>
3572 * cs-parser.jay: Add support for lambda expressions to the mcs
3575 * lambda.cs: Only clone when we are probing, not on the final call
3576 (Compatible is the final call).
3578 * statement.cs (CloneContext): Introduce class to provide block
3579 remapping during clone.
3581 All statements Clone themselves now.
3583 (Clone): special handling for blocks, when we clone a block, we
3584 register the block inside this routine, as children of the block
3585 might trigger a lookup.
3587 * expression.cs: Add support for CloneContext in all expressions.
3589 2007-02-17 Marek Safar <marek.safar@gmail.com>
3591 A fix for bug #80493
3592 * statement.cs: Report ambiguous warning when interfaces are not related.
3594 2007-02-15 Marek Safar <marek.safar@gmail.com>
3596 C# 3.0 extension methods.
3598 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
3599 cannot be used directly.
3601 * class.cs (Class.Emit): Emit extension attribute if any class method
3602 is extension method.
3603 (Method.Define): Add basic extension method validation conditions.
3604 (Method.Emit): Emit extension attribute for method.
3606 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
3607 extension method exists. Currently we follow same approach as Microsoft
3608 does, emit even if a method or a class are private but this can change
3611 * cs-parser.jay: Add handling of `this' keyword in method parameters
3614 * decl.cs (DeclSpace.IsStaticClass): New property.
3615 (MemberCache.FindExtensionMethods): Looks for extension methods with
3616 defined name and extension type.
3618 * doc.cs: Updated after OverloadResolve changes.
3620 * driver.cs: Add new soft reference to System.Core.dll.
3622 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
3623 (ExtensionMethodGroupExpr): Represents group of extension methods.
3625 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
3626 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
3627 to MethodGroupExpr and made non-static for easier customization.
3628 (Invocation.DoResolve): Add extension method lookup when no standard
3630 (MemberAccess.DoResolve): Try extension methods if no member exists.
3632 * modifiers.cs: Add METHOD_EXTENSION modifier.
3634 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
3635 as well as candidate extension type.
3636 (ComputeNamespaces): When assembly constains extension methods registers
3638 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
3639 extension method lookup.
3640 (Namespace.LookupExtensionMethod): Looks for extension method in this
3642 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
3643 find a method which matches name and extensionType.
3645 * parameter.cs (Parameter): Add This modifer.
3646 (HasExtensionMethodModifier): New property.
3647 (Resolve): Add extension parameter check.
3648 (ModFlags): turned to property to exclude this modifier as it is not real
3650 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
3652 * support.cs (ParameterData): Add ExtensionMethodType.
3653 (ReflectionParameters): Implemented ExtensionMethodType interface property.
3655 * typemanager.cs: Add type and ctor extension attribute type.
3657 2007-02-15 Miguel de Icaza <miguel@novell.com>
3659 * report.cs (DisableErrors, EnableErrors): used to prevent error
3660 output when we are "trying" to compile various methods with
3663 * ecore.cs (Expression): Add Clone method that calls the virtual
3664 CloneTo method. The current CloneTo method in Expression throws
3665 an exception so we can track down all the places where this must
3666 be implemented (not using abstract, because that would be a lot of
3667 up-front-work before we can start testing the implementation
3670 Important: we only need Clone capabilities for expressions created
3671 by the parser, as the expressions we will be cloning are
3672 expressions in the pre-resolved state. This vastly simplifies
3675 (SimpleName): Add CloneTo that does nothing.
3676 (EmptyCast): Add CloneTo.
3678 * expression.cs (Binary): Implement CloneTo.
3679 (Invocation.IsApplicable): Store the current ec in
3680 EmitContext.TempEc and restore it on return. This is used so we
3681 do not have to sprinkle hundres of methods with an extra
3682 EmitContext, we know that the only user is the lambda expression
3683 ImplicitConversionExists code.
3685 (Argument): Add Cloning capabilities.
3686 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
3687 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
3688 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
3689 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
3690 IndexerAccess): Add Clone capability.
3692 (LocalVariableReference, This): TODO: needs cloned Block mapping.
3694 (Argument): Add cloning capability.
3696 * assign.cs (Assign): Implement CloneTo.
3698 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
3700 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
3701 version by calling Convert with the EmitContext (that we are
3702 currently storing in ec, this is not great, but will do for now,
3703 to avoid passing EmitContext parameters to hundreds of functions
3704 that do not need them now).
3706 (SetExpression): Remove, it is not needed.
3708 (ContextualReturn): Implement CloneTo.
3710 * statement.cs (Statement): Implement cloning infrastructure,
3711 similar to expressions.
3713 (Block): Partial implementation of Clone for statements.
3715 (Return): Implement clone.
3717 * constant.cs (Constant.CloneTo): New method, does nothing.
3719 * codegen.cs (TempEc): Add a static EmitContext as a temporary
3720 solution, until we decide how to exactly do this.
3722 2007-02-14 Marek Safar <marek.safar@gmail.com>
3724 A fix for bug #80493
3725 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
3726 a property is override we need to use second accessor.
3728 2007-02-13 Marek Safar <marek.safar@gmail.com>
3730 A fix for bug #80418
3731 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
3734 2007-02-13 Marek Safar <marek.safar@gmail.com>
3736 Another fix for bug #80749
3737 * pending.cs: Abstract class has priority over interfaces.
3739 2007-02-13 Marek Safar <marek.safar@gmail.com>
3741 Another fix for bug #80749
3742 * pending.cs: Abstract class has priority over interfaces.
3744 2007-02-13 Marek Safar <marek.safar@gmail.com>
3746 Another fix for bug #80749
3747 * pending.cs: Abstract class has priority over interfaces.
3749 2007-02-13 Marek Safar <marek.safar@gmail.com>
3751 Another fix for bug #80749
3752 * pending.cs: Abstract class has priority over interfaces.
3754 2007-02-13 Marek Safar <marek.safar@gmail.com>
3756 * class.cs Better error message.
3758 * driver.cs: Add shorter versions of -optimize option.
3760 2007-02-13 Martin Baulig <martin@ximian.com>
3762 * class.cs (Constructor.Emit): Check the return value of
3763 ec.ResolveTopBlock() and return on error.
3765 2007-02-13 Raja R Harinath <rharinath@novell.com>
3767 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
3768 message to fix error message regression.
3770 2007-02-12 Marek Safar <marek.safar@gmail.com>
3772 * delegate.cs: Delegate creation expression cannot be of Nullable type.
3774 2007-02-12 Marek Safar <marek.safar@gmail.com>
3776 A fix for bug #80749
3777 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
3778 its parent container.
3780 * class.cs (DefineFieldInitializers): Each initializer can has different
3783 * const.cs: Updated.
3785 2007-02-11 Miguel de Icaza <miguel@novell.com>
3787 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
3788 now all the heavy lifting to check that embedded statements or
3789 expressions have the right form is done in the ContextualReturn.
3791 (ContextualReturn): New class.
3793 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
3794 method that can be invoked to report 201, so we do not replicate
3797 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
3799 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
3800 treating tabs as spaces.
3802 2007-02-09 Marek Safar <marek.safar@gmail.com>
3804 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
3805 * assign.cs: Use full implicit conversion for right side check.
3807 2007-02-09 Marek Safar <marek.safar@gmail.com>
3809 * statement.cs (Switch): Switch over boolean type is not standardized.
3811 2007-02-08 Marek Safar <marek.safar@gmail.com>
3813 A fix for bug #80755
3814 * decl.cs (FindBaseEvent): Don't use method cache for events.
3816 2007-02-07 Marek Safar <marek.safar@gmail.com>
3818 * cs-parser.jay: Better syntax error handling.
3820 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
3821 instead of underlying type value.
3823 2007-02-06 Marek Safar <marek.safar@gmail.com>
3825 * driver.cs: Check define identifier before is registered.
3827 * namespace.cs: Use existing error message.
3829 * report.cs: New warning.
3831 2007-02-06 Marek Safar <marek.safar@gmail.com>
3833 A fix for bug #80742
3834 * expression.cs: Delegate Invoke method can be called directly.
3836 2007-02-06 Marek Safar <marek.safar@gmail.com>
3838 A fix for bug #80676
3839 * class.cs (IsEntryPoint): The Main method can have params modifier.
3841 2007-02-04 Miguel de Icaza <miguel@novell.com>
3843 * parameter.cs (Parameter, Parameters): Add Clone method.
3845 * anonymous.cs (Compatible): Turn method into virtual method, so
3846 LambdaExpression can implement a different behavior.
3848 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
3849 out the basic checking here, so it can be used by
3852 * lambda.cs: Introduce "Compatible" function that will do the
3855 2007-02-02 Marek Safar <marek.safar@gmail.com>
3857 * attribute.cs: Unified one error message.
3859 * class.cs (Class): Use type attributes and not properties to test static
3861 (IsEntryPoint): Don's pass local variable.
3863 * convert.cs: Removed duplicate check.
3865 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
3867 * driver.cs: Don't crash when soft reference does not exist.
3869 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
3870 (UsingEntry): Removed redundant allocation.
3872 * parameter.cs: Add fast path for type parameters.
3874 * support.cs: Don't allocate attribute when it's not used.
3876 2007-01-30 Miguel de Icaza <miguel@novell.com>
3879 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
3880 this into a virtual method, so we can override it in LambdaExpression.
3882 * driver.cs: Improve diagnostics in case of failure.
3884 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
3885 write a function that is slightly more complex and that parses:
3887 type identifier [, type identifier]* )
3889 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
3892 (canEmpty ? i >= 0 : i > 0)
3894 2007-01-30 Raja R Harinath <rharinath@novell.com>
3896 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
3897 exception on possibly valid code.
3899 2007-01-29 Raja R Harinath <rharinath@novell.com>
3901 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
3903 (parse_opt_type_arguments): Remove. It's almost the same as
3905 (parse_namespace_or_typename): Use parse_less_than.
3907 2007-01-28 Miguel de Icaza <miguel@novell.com>
3909 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
3910 this bug took a few hours to find, because the state saved and
3911 restored by PushPosition and PopPosition was ignoring the state of
3912 parse_generic_less_than.
3914 I can also now remove the handling of OP_LT and OP_GT, this solves
3917 * cs-tokenizer.cs: store the location for the ARROW token, we use
3920 (PushPosition, PopPosition): save/restore also `current_token',
3921 restore `parse_generic_less_than' (was missing).
3923 (parse_opt_type_arguments): use parse_type, not
3924 parse_namespace_or_typename to parse types.
3926 * lambda.cs: Empty new file, will eventually have the lambda
3927 expression implementation.
3929 * lambda.test: used to test the internal tokenizer.
3931 * report.cs (FeatureIsNotISO1): Rename from
3932 FeatureIsNotStandardized, because it was about the language level
3933 (1 vs 2) it was not about standarization.
3935 (FeatureRequiresLINQ): New.
3937 * support.cs (SeekableStreamReader): Only require that the reader
3938 is a TextReader, not a StreamReader, so we can plug StringReader.
3940 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
3941 given position in the input stream the following tokens can be
3942 parsed as a type followed by an identifier.
3944 (is_punct): after a '(' if parse_type_and_parameter returns true,
3945 then return a special token OPEN_PARENS_LAMBDA which is used to
3946 avoid reduce/reduce errors in the grammar for the
3947 lambda_expression rules.
3949 (parse_type): implement a type parser inside the
3950 tokenizer, the parser only returns true or false depending on
3951 whether the input at a given position can be parsed as a type.
3953 (peek_token): new method used during type parsing.
3955 2007-01-28 Raja R Harinath <rharinath@novell.com>
3958 * anonymous.cs (ScopeInfo.InflateParameters): New.
3959 (AnonymousContainer.Resolve): Use it to redirect types of
3960 delegate parameters.
3962 2007-01-27 Raja R Harinath <rharinath@novell.com>
3965 * expression.cs (Error_InvalidArguments): Don't use two different
3966 messages for CS1503. Use ExtraInformation and
3967 SymbolRelatedToPreviousError instead.
3970 * decl.cs (DeclSpace.initialize_type_params): Don't access
3971 'type_params' of a partial class directly.
3973 2007-01-26 Miguel de Icaza <miguel@novell.com>
3975 * constant.cs: Removed a handful of out-of-range checks that were
3978 2007-01-25 Marek Safar <marek.safar@gmail.com>
3980 * expression.cs (CheckUselessComparison): Add additional check for char
3983 * namespace.cs: Fixed typo.
3985 2007-01-23 Miguel de Icaza <miguel@novell.com>
3987 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
3988 gone, instead we inline the test, preventing the needless casts to
3989 longs, ulongs and doubles for the parameters, avoiding calls to
3990 methods that overchecked stuff, and instead inlined things
3993 2007-01-20 Marek Safar <marek.safar@gmail.com>
3995 * cs-parser.jay: Better parameter error handling.
3997 2007-01-17 Marek Safar <marek.safar@gmail.com>
3999 A fix for bug #80368, #80522
4000 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
4001 whether array initializer contains constants only.
4002 (ArrayCreation.Emit): Use better formula to decide when
4003 are array initializers for static initialization.
4004 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
4005 have to emit even constants otherwise they are pre-initialized.
4007 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
4008 Raja R Harinath <rharinath@novell.com>
4010 Fix emit order of 'get' vs. 'set'.
4011 * support.cs (Accessors): New.
4012 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
4013 Note the order in which accessors are declared in the source.
4014 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
4015 Refactored from Property.Define and Indexer.Define.
4016 (PropertyBase.DefineAccessors): New helper that calls the above in
4017 appropriate order as noted by the parser.
4018 (Property.Define, Indexer.Define): Update to changes.
4019 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
4021 2007-01-17 Raja R Harinath <rharinath@novell.com>
4023 Fix cs0029-6.cs and gcs0029-2.cs (regression)
4024 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
4025 there's an implicit conversion from the current type to the target
4026 type before converting the underlying constant.
4028 2007-01-16 Marek Safar <marek.safar@gmail.com>
4030 * const.cs (ResolveValue): Updated after constant conversion was made more
4033 * constant.cs (GetAttributableValue): constant to object conversion is
4034 used for attributes only.
4035 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
4036 constant conversions.
4037 (LongConstant.ConvertImplicitly): Ditto.
4039 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
4040 (ImplicitConversionStandard): Handle constant conversion as extra step.
4041 It solves the issue when constant conversion was called indirectly like
4042 inside array initializer and constant folding was skipped.
4044 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
4047 * statement.cs(ImplicitConversionStandard): Updated after constant
4048 conversion was made more generic.
4050 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
4052 * expression.cs (As.DoResolve): Use GenericConstraints instead of
4053 Constraints, solves the problem where the compiler incorrectly
4054 reported that a type parameter was not constrained to a class (Bug
4057 2007-01-14 Marek Habersack <grendello@gmail.com>
4059 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
4061 2007-01-14 Marek Safar <marek.safar@gmail.com>
4063 A fix for bug #80368
4064 * assign.cs (FieldInitializer): New class implements field
4065 initializer statement.
4067 * attribute.cs: Update after FieldMember rename.
4069 * class.cs (PropertyBasedMember): New common class for property based
4071 (InterfaceMemberBase): New base class for all members which can be used as
4072 an interface members.
4073 (MethodCore): Moved really common code to InterfaceMemberBase.
4074 (Method.Define): Equal and GetHasCode detection is relevant for methods
4076 (MethodData.Define): Don't assume that public event implements an
4077 interface automatically.
4078 (MethodData.DefineMethodBuilder): Issue an error even if only extern
4080 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
4081 (FieldMember): Merged with FieldBase.
4082 (EventProperty.AEventPropertyAccessor): New specialization to check whether
4083 event extern modifier can be used.
4084 (EventField.EventFieldAccessor): Moved event field specific code here.
4085 (Event.AllowedModifiers): Even event can be extern.
4086 (Event.FindOutBaseMethod): New override specific to events.
4087 (Indexer.parameters): Reintroduce parameters because base class holds
4088 only properties common data.
4089 (Indexer.CheckForDuplications): Indexers are threated as methods so we
4090 need do extra parameters check.
4092 * const.cs: Update after FieldMember rename.
4094 * decl.cs (MemberCache.FindBaseEvent): New method.
4096 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
4097 to reflect that indexer is now derived from PropertyBased.
4099 * ecore.cs (GetMemberType): Made public.
4100 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
4103 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
4105 * typemanager.cs (CSharpSignature): Correctly print event accessors.
4106 (RegisterEvent): Removed.
4107 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
4108 (GetPrivateFieldOfEvent): Renamed to GetEventField.
4110 2007-01-11 Raja R Harinath <rharinath@novell.com>
4113 * statement.cs (CollectionForeach.TryType): Prefer generic
4114 GetEnumerator over non-generic variant. Fix code to follow comments.
4116 2007-01-09 Raja R Harinath <rharinath@novell.com>
4119 * support.cs (ReflectionParameter): Don't use an invalid index on
4120 the generic parameter data.
4122 2007-01-08 Miguel de Icaza <miguel@novell.com>
4124 * driver.cs: Just add a tiny bit of infrastructure.
4126 2007-01-02 Marek Safar <marek.safar@gmail.com>
4128 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
4129 where field type is struct from current assembly.
4131 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
4134 2007-01-02 Marek Safar <marek.safar@gmail.com>
4136 A fix for bug #80381
4137 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
4140 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
4142 (Namespace.LookupType): Always use core types from corlib when speficied.
4144 * report.cs: A new warning.
4146 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
4147 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
4148 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
4150 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
4151 (InitCoreTypes): Set expression type of object_type and value_type
4152 immediately after lookup.
4154 2007-01-01 Miguel de Icaza <miguel@novell.com>
4156 * cs-tokenizer.cs: Accept Pc class characters (Connector
4157 Punctuation) as valid identifiers. Fixes #78259
4159 * expression.cs (Invocation.DoResolve): Moved the check for the
4160 use of `this' for doing method calls to the Invocation resolution
4161 step, after overload resolution has taken place instead of doing
4162 the check at the low-level `This.DoResolve' level.
4164 The `This.DoResolve'(appens before overload resolution, so it has
4165 no way of knowing if the method that will be called will be
4166 instace or static, triggering an erroneous report for cs0188 (Bug
4169 We now do the check for instance method invocations after we know
4170 what method will be called.
4172 (This.CheckThisUsage): Move the actual use of this structure
4173 checking into its own method and expose it.
4175 * Everywhere that called Error_ValueCannotBeConverted: pass a new
4178 Exceptions: Null.ConvertImplicitly,
4179 Constant.ImplicitConversionRequired as there are too many call
4180 sites for passing the ec.
4182 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
4183 EmitContext, if the value is null, then we do not try to provide
4184 the extra information from the error (If a userdefined conversion
4185 exists, as UserDefinedConversion requires a non null-EmitContext).
4189 2006-12-30 Raja R Harinath <rharinath@novell.com>
4191 * flowanalysis.cs (MyBitVector): Document some invariants.
4192 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
4193 introduced below, and add a couple of others,
4195 2006-12-30 Marek Safar <marek.safar@gmail.com>
4197 * attribute.cs (GetMethodObsoleteAttribute): Uses new
4198 GetPropertyFromAccessor and GetEventFromAccessor.
4200 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
4201 overrides non-obsolete one.
4202 (Indexer.Define): Error message has been moved to the parser.
4204 * cs-parser.jay: Better syntax errors handling.
4206 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
4207 when an invocation has no arguments.
4209 * ecore.cs: Removed not used caching.
4211 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
4214 * report.cs: Add a new warning.
4216 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
4218 * typemanager.cs (enumeration_type): Removed.
4219 (CSharpSignature): Reuses IsSpecialMethod.
4220 (IsEqual): Hack for MS BCL.
4221 (GetPropertyFromAccessor): New method.
4222 (GetEventFromAccessor): New method.
4223 (IsSpecialMethod): Fixed to handle more cases.
4225 2006-12-30 Marek Safar <marek.safar@gmail.com>
4227 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
4228 Made white spaces array static.
4230 * ecore.cs (RemoveGenericArity): Optimized.
4232 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
4234 (MyBitVector.initialize_vector): Simplified.
4236 2006-12-22 Miguel de Icaza <miguel@novell.com>
4238 * ecore.cs: Am not entirely happy with this hack, but it seems to
4239 address the issue in 80257 (a small test case for
4242 I set the MethodGroupExpr.Type to an internal compiler type
4243 (itself in this case) to force the resolution to take place. Why
4244 it does not take place with a null is beyond me.
4246 2006-12-20 Marek Safar <marek.safar@gmail.com>
4248 A fix for bug #80288
4249 * expression.cs (ResolveOperator): Consider user defined conversion for
4250 logical and operator too.
4251 (EmitBranchable): Optimization for logical and when full constant folding
4252 could not be applied but one operand is constant.
4254 2006-12-19 Marek Safar <marek.safar@gmail.com>
4256 * class.cs (GetClassBases): Write 5 times every day, will never use
4257 FullName for error reporting.
4259 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
4261 2006-12-19 Martin Baulig <martin@ximian.com>
4263 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
4264 the symbol file info here.
4266 2006-12-18 Marek Safar <marek.safar@gmail.com>
4268 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
4269 of `elseif' is taking then following sections are not taking.
4270 Fixes an issue reported on mono mailing list.
4272 2006-12-18 Marek Safar <marek.safar@gmail.com>
4274 A fix for bug #80300
4275 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
4276 a caller is not taking.
4278 2006-12-18 Raja R Harinath <rharinath@novell.com>
4280 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
4281 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
4282 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
4283 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
4284 * class.cs: Update to changes.
4286 2006-12-17 Marek Safar <marek.safar@gmail.com>
4288 A fix for bug #79934
4289 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
4292 * class.cs (ResolveMembers): Register an iterator in current container and
4295 2006-12-16 Raja R Harinath <rharinath@novell.com>
4298 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
4299 satisfy a params annotated parameter.
4301 2006-12-16 Marek Safar <marek.safar@gmail.com>
4303 A fix for bug #77014
4304 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
4305 paramters correctly and not rely on hacks in Parameters class.
4306 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
4308 (Invocation.VerifyArgumentsCompat): Ditto.
4309 (Invocation.EmitArguments): Changed to correctly emit params arguments at
4312 * parameter.cs (HasParams): Don't assume that params is the last one.
4314 * support.cs (ReflectionParameters.ctor): Look for params attribute
4316 (ReflectionParameters.ParameterType): Removed hack when we returned last
4317 parameter for out of range parameters.
4318 (ParameterName, ParameterModifier): Ditto.
4320 2006-12-14 Marek Safar <marek.safar@gmail.com>
4322 A fix for bug #79987
4323 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
4324 when assembly is not CLS compliant but type is. I have no idea why is this
4327 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
4329 2006-12-13 Miguel de Icaza <miguel@novell.com>
4331 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
4332 in struct constructors, they are basically no-ops.
4334 2006-12-12 Marek Safar <marek.safar@gmail.com>
4336 * cs-tokenizer.cs (Position): Save preprocessor status too.
4338 2006-12-12 Marek Safar <marek.safar@gmail.com>
4340 A fix for bug #77794
4341 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
4343 2006-12-12 Marek Safar <marek.safar@gmail.com>
4345 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
4347 (pp_expr): Report error for an invalid expression.
4348 (handle_preprocessing_directive): Simplified; add more error checking.
4350 2006-12-11 Marek Safar <marek.safar@gmail.com>
4352 A fix for bug #74939
4353 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
4354 directives handling.
4356 2006-12-10 Marek Safar <marek.safar@gmail.com>
4358 A fix for bugs #80093, and #75984
4359 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
4360 logic, it seems to me as it worked before "by coincidence".
4361 (xtoken): Simplified to use reworked handle_preprocessing_directive.
4362 (cleanup): Enabled endif check.
4364 2006-12-09 Marek Safar <marek.safar@gmail.com>
4366 A fix for bug #80162
4367 * statement.cs (CollectionForeach.TryType): Generics and non-generics
4368 enumerators are never ambiguous.
4370 2006-12-08 Raja R Harinath <rharinath@novell.com>
4373 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
4375 2006-12-06 Marek Safar <marek.safar@gmail.com>
4377 A fix for bug #80144
4378 * class.cs (EventProperty.Define): Explicit implementation means
4379 that an even is used.
4381 2006-12-06 Marek Safar <marek.safar@gmail.com>
4383 Fixes the operators implementation (part II)
4385 * cfold.cs (DoConstantNumericPromotions): Renamed to
4386 DoBinaryNumericPromotions and simplified.
4387 (BinaryFold): Couple of conversion fixes; simplified.
4389 * constant.cs, ecore.cs, literal.cs
4390 (ToType): Renamed to ConvertImplicitly.
4391 (Reduce): Renamed to ConvertExplicitly.
4393 * class.cs, convert.cs: Updated.
4395 * expression.cs: TryReduce doesn't throw an exception.
4397 2006-12-01 Marek Safar <marek.safar@gmail.com>
4399 A fix for bug #80108
4400 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
4403 2006-11-30 Marek Safar <marek.safar@gmail.com>
4405 Fixes unary operators implementation (part I)
4408 * cfold.cs (Error_CompileTimeOverflow): Made internal
4410 * const.cs (IConstant): Changed to use reference to constant and
4411 not constant itself.
4412 Updated IConstant implementations.
4414 * constant.cs (CreateConstant): New factory method.
4415 Updated IConstant implementation.
4417 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
4419 * ecore.cs: Updated to use CreateConstantReference.
4421 * enum.cs: Reflects IConstant changes.
4423 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
4425 * literal.cs (NullConstant): Change to be independently usable.
4427 2006-11-29 Martin Baulig <martin@ximian.com>
4429 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
4430 we need to emit the scope initializer before calling the base .ctor.
4432 * anonymous.cs: Merged back from the new anonymous methods branch.
4433 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
4435 * expression.cs (ParameterReference.DoResolveBase): Create a
4436 "normal" ScopeInfo when capturing parameters rather than using the
4437 root scope; this makes things work with anonymous methods having
4441 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
4443 2006-11-22 Marek Safar <marek.safar@gmail.com>
4445 A fix for bug #79987
4446 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
4447 check to a base class.
4448 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
4449 only when assembly has missing attribute.
4450 * report.cs: Update.
4452 2006-11-21 Marek Safar <marek.safar@gmail.com>
4454 * cs-tokenizer.cs: Merged with gmcs version.
4456 2006-11-20 Marek Safar <marek.safar@gmail.com>
4459 * cs-parser.jay: Better error message when partial keyword is misplaced.
4461 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4463 A fix for bug #79810
4464 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4465 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4466 a RuntimeWrappedException by default.
4468 2006-11-18 Marek Safar <marek.safar@gmail.com>
4470 A fix for bug #79843
4471 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4473 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4475 2006-11-18 Marek Safar <marek.safar@gmail.com>
4477 * driver.cs, namespace.cs: Uses faster IndexOf version.
4479 2006-11-17 Marek Safar <marek.safar@gmail.com>
4481 A fix for bug #79941
4482 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4484 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4485 even if internal name is different.
4486 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4487 (UserDefinedConversion): Simplified as the operators cannot be internal.
4488 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4490 (MethodLookup): Replaced EmitContext with parentType.
4491 * expression.cs: Updated.
4493 2006-11-09 Raja R Harinath <rharinath@novell.com>
4495 * driver.cs (BadAssembly): Handle all the ugliness of
4496 DefineDynamicAssembly.
4498 2006-11-08 Raja R Harinath <rharinath@novell.com>
4500 Address parts of #58244 -- most of what's left is in the runtime
4501 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4502 CS1509 error checks, and handle them for all assembly loads, not
4503 just the first invocation.
4504 (LoadModule): Likewise. Move handling of 'adder_method' ...
4505 * codegen.cs (AssemblyClass.AddModule): ... here.
4507 2006-11-02 Marek Safar <marek.safar@gmail.com>
4509 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4510 IEnumerable<T> is ambiguous.
4512 2006-10-31 Marek Safar <marek.safar@gmail.com>
4514 A fix for bug #67689
4515 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4516 GetEnumerator is ambiguous.
4518 * report.cs: Add new warning.
4520 2006-10-29 Marek Safar <marek.safar@gmail.com>
4522 A fix for bug #78602
4523 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4524 to protected member can be nested type.
4526 2006-10-28 Marek Safar <marek.safar@gmail.com>
4528 A fix for bug #78965
4529 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4530 to protected member must derive from current type.
4532 2006-10-27 Marek Safar <marek.safar@gmail.com>
4534 assign.cs: Reuses error method.
4536 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4537 instead of type for constants.
4538 (Expression.Error_ValueAssignment): Common error method.
4540 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4543 2006-10-27 Marek Safar <marek.safar@gmail.com>
4545 A fix for bug #79081
4546 * expression.cs (MemberAccess.DoResolve): Check nested type
4549 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4551 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4553 2006-10-26 Marek Safar <marek.safar@gmail.com>
4555 A fix for bug #76591
4556 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4558 2006-10-26 Marek Safar <marek.safar@gmail.com>
4560 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4561 type forwarder of the same type multiple times.
4563 2006-10-26 Raja R Harinath <rharinath@novell.com>
4566 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4567 instance as an rvalue, even when we later resolve as an lvalue.
4569 2006-10-25 Martin Baulig <martin@ximian.com>
4571 * anonymous.cs: Fix #79673.
4573 2006-10-24 Marek Safar <marek.safar@seznam.cz>
4575 A fix for bug #79666
4576 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
4577 ignored when is optimized (= default value) as its value is already set.
4579 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4581 A fix for bug #79724
4582 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
4583 TypeContainer for type lookup.
4585 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4587 A fix for bug #79231
4588 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
4589 * expression.cs (OverloadResolve): Always convert type name for
4591 (ResolveNamespaceOrType): Don't confuse a nested type with any
4594 2006-10-18 Martin Baulig <martin@ximian.com>
4596 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
4598 2006-10-17 Miguel de Icaza <miguel@novell.com>
4600 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
4601 an int32, but requesting an int64 from the conversion
4603 2006-10-12 Martin Baulig <martin@ximian.com>
4606 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
4608 2006-10-12 Martin Baulig <martin@ximian.com>
4611 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
4613 2006-10-11 Miguel de Icaza <miguel@novell.com>
4615 * convert.cs: Remove broken code: I was doing the "Existance"
4616 tests for Implicit conversions.
4618 2006-10-10 Miguel de Icaza <miguel@novell.com>
4620 * convert.cs: Added one missing case in
4621 ImplicitStandardConversionExists uint64 to intptr.
4625 * typemanager.cs (uintptr_type): another core known type.
4627 * ecore.cs (OperatorCast): routine used to do cast operations that
4628 depend on op_Explicit. We could change some of the Decimal
4629 conversions to use this.
4631 This one has a probe mechanism that checks both types for an op_
4632 which it coudl be used to eliminate two classes: CastToDecimal
4633 and CastFromDecimal.
4635 * convert.cs: Implement the conversions documented in #59800
4637 2006-10-10 Martin Baulig <martin@ximian.com>
4639 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
4640 before RootScope.ResolveMembers().
4642 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
4643 `CurrentType' if appropriate.
4645 2006-10-09 Marek Safar <marek.safar@seznam.cz>
4647 A fix for bug #78568
4648 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
4649 when contains binary operators.
4650 * cs-parser.jay: Updated.
4652 2006-10-09 Martin Baulig <martin@ximian.com>
4655 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
4656 moved that into Define() and also do the other type parameter
4657 checks there. Fixes #79094. Added gtest-292.cs.
4660 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
4661 since that doesn't include type parameters; don't use `Ldelema'
4662 for type parameters. Fixes #78980. Added gtest-293.cs.
4664 2006-10-08 Marek Safar <marek.safar@seznam.cz>
4667 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
4668 conversion is allowed.
4670 2006-10-06 Marek Safar <marek.safar@seznam.cz>
4672 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
4673 error reporting when no error occurs.
4675 2006-10-06 Marek Safar <marek.safar@seznam.cz>
4677 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
4680 2006-10-06 Raja R Harinath <rharinath@novell.com>
4683 * class.cs (DefineTypeBuilder): Check circular dependencies before
4684 setting the parent of the TypeBuilder.
4685 (CheckRecursiveDefinition): Don't use 'BaseType', since
4686 it may not be valid until after DefineTypeBuilder. Use
4687 'base_type' instead.
4689 2006-10-04 Martin Baulig <martin@ximian.com>
4691 Merged the Anonymous Methods patch.
4693 * anonymous.cs, iterators.cs: The new anonymous methods code.
4695 * statement.cs (Variable): New public abstract class.
4696 (LocalInfo.Variable): New public property.
4697 (LocalInfo.ResolveVariable): New public method.
4698 (Block.Flags): Add `IsIterator'.
4699 (Block.AddVariable): Improved the CS0136 check.
4700 (Block.AnonymousChildren): New public property.
4701 (Block.AddAnonymousChild): New public method.
4702 (ToplevelBlock): Update to use the new anonymous method framework.
4703 (ToplevelBlock.ctor): `container' is now a `Block' and not a
4704 `ToplevelBlock'; this is required to correctly implement the
4706 (Fixed, Using): Use `TemporaryVariable' instead of directly
4707 creating the `LocalBuilder'.
4709 * parameter.cs (Parameter.ResolveVariable): New public method.
4710 (Parameters.ResolveVariable): Likewise.
4712 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
4714 * class.cs (TypeContainer): Replaced the `iterators' list and
4715 corresponding methods with a list of `CompilerGeneratedClass'es.
4716 (TypeContainer.ResolveMembers): New public method.
4717 (Method): `IIteratorContainer' has been replaced by
4720 * expression.cs (VariableReference): New public abstract base
4721 class for `LocalVariableReference', `ParameterReference' and
4724 * codegen.cs (EmitContext): Removed `capture_context',
4725 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
4726 (EmitContext.EmitThis): Removed.
4728 * cs-parser.jay: Replace `iterator_container' with
4731 2006-10-04 Martin Baulig <martin@ximian.com>
4733 * generic.cs (GenericMethod): Don't make this abstract.
4734 (Constraints.Clone): Added dummy implementation.
4736 2006-10-04 Raja R Harinath <harinath@gmail.com>
4739 * namespace.cs (LookForAnyGenericType): Avoid nullref on
4740 'declspaces'. Avoid allocating arrays willy-nilly.
4743 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
4744 cases out of the switch.
4746 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4748 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
4749 message when non-generic type is used with the type arguments.
4750 * expression.cs: Updated.
4752 2006-09-28 Raja R Harinath <rharinath@novell.com>
4755 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
4756 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4757 Change semantics slightly. Don't insist on having only one
4758 temporary EmptyExpression -- just throttle the creation of new ones.
4761 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
4762 non-interfaces too. If no methods are found, don't try to create
4765 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4767 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
4770 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
4771 us produce better error message.
4773 2006-09-27 Marek Safar <marek.safar@seznam.cz>
4775 * expression.cs (Binary.ResolveOperator): Warn about a side effect
4776 of the `|' operator.
4778 * report.cs: A new warning added.
4780 2006-09-27 Martin Baulig <martin@ximian.com>
4782 * generic.cs (GenericMethod): Don't make this abstract.
4784 2006-09-27 Martin Baulig <martin@ximian.com>
4787 (InternalErrorException): Added overloaded ctor taking a params array.
4789 2006-09-26 Marek Safar <marek.safar@seznam.cz>
4791 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
4792 Fixed the cases when same error was reported twice.
4794 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
4795 now report symbol information.
4797 2006-09-25 Martin Baulig <martin@ximian.com>
4799 * class.cs: Completely unified with the gmcs version.
4801 2006-09-25 Martin Baulig <martin@ximian.com>
4803 * typemanager.cs (TypeManager.IsNullableType): New public function.
4804 (TypeManager.IsNullableTypeOf): Likewise.
4805 (TypeManager.IsNullableValueType): Likewise.
4807 * class.cs (MethodCore): Added the `GenericMethod' argument from
4808 gmcs and also unified all classes derived from `MethodCore' with gmcs.
4810 2006-09-24 Raja R Harinath <harinath@gmail.com>
4812 * convert.cs: Unify with gmcs version.
4814 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4816 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
4817 verify them as well.
4819 * report.cs: New warning.
4821 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4823 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
4824 for anonymous block with out argument.
4826 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4828 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
4829 not used private events only.
4831 2006-09-23 Marek Safar <marek.safar@seznam.cz>
4833 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
4835 * const.cs (Const.Define): Check for constant type.
4836 (Const.IsConstantTypeValid): Looks for valid constant types.
4838 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
4840 * ecore.cs (EmptyConstantCast): New common class for all constant based
4843 * expression.cs (Is.DoResolve): Handle null constant especially.
4844 (New.DoResolve): Check for new void().
4845 (MemberAccess.DoResolve): Cope with all kind of nulls.
4847 * literal.cs (NullConstant): Uses EmptyConstantCast.
4848 (NullDefault): Based on EmptyConstantCast.
4849 (NullLiteral): Uses EmptyConstantCast.
4851 * statement.cs (Block.ResolveMeta): Check for constant type.
4853 2006-09-22 Martin Baulig <martin@ximian.com>
4855 * delegate.cs, attribute.cs: Merged with the gmcs versions.
4857 2006-09-22 Raja R Harinath <rharinath@novell.com>
4859 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
4863 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
4864 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
4867 2006-09-22 Martin Baulig <martin@ximian.com>
4869 * ecore.cs: Merged with the gmcs version.
4871 * generic.cs (ConstructedType): New dummy class.
4872 (TypeArguments): Don't make this abstract.
4875 (TypeManager.IsGenericTypeDefinition): New method.
4876 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
4878 2006-09-22 Raja R Harinath <rharinath@novell.com>
4880 * expression.cs (ComposedCast): Check for arrays of TypedReference
4881 before creating the type, not after.
4883 2006-09-21 Marek Safar <marek.safar@seznam.cz>
4885 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
4886 after ToType change.
4888 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
4889 when constant must be implicitly convertible.
4891 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
4893 * ecore.cs (NullCast): Derives from NullConstant.
4895 * expression.cs (Is.DoResolve): Removed useless variables.
4896 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
4897 (New.Constantify): Add enum support.
4898 (MemberAccess.DoResolve): Add warning when accessing null constant or
4901 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
4904 * literal.cs (NullConstant): New abstract class with common
4905 functionality for all null specializations.
4906 (NullDefault): Represents default(X) when result can be
4908 (NullLiteral): Updated.
4910 * report.cs: Add new warning.
4912 2006-09-21 Martin Baulig <martin@ximian.com>
4914 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
4916 2006-09-21 Martin Baulig <martin@ximian.com>
4918 * generic.cs (GenericConstraints): New dummy class.
4919 (Constraints): Likewise.
4920 (TypeParameter): Likewise.
4921 (TypeParameterName): Likewise.
4922 (GenericMethod): Likewise.
4924 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4926 * decl.cs: Merged with the gmcs version.
4928 2006-09-21 Raja R Harinath <rharinath@novell.com>
4930 * generic.cs (TypeParameter): Implement IMemberContainer.
4931 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
4933 * rootcontext.cs: Unify with gmcs version.
4935 * report.cs: Unify with gmcs version.
4936 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
4937 from gmcs/generics.cs.
4938 * generics.cs (TypeParameter): New dummy class.
4940 * support.cs: Unify with gmcs version.
4942 2006-09-20 Raja R Harinath <rharinath@novell.com>
4944 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
4945 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
4947 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
4948 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
4949 * mcs.exe.sources: Add generic.cs.
4951 * codegen.cs: Unify with gmcs version.
4953 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
4954 (EmitContext): Add GenericDeclContainer implementation.
4955 * decl.cs (MemberCore, DeclSpace): Likewise.
4956 * namespace.cs: Remove #ifdef GMCS_SOURCE.
4958 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
4959 MCS TypeManager has a corresponding dummy method.
4961 2006-09-19 Martin Baulig <martin@ximian.com>
4963 * expression.cs: Completely merged with the gmcs version.
4965 2006-09-19 Martin Baulig <martin@ximian.com>
4967 * expression.cs (Invocation): Merged with the gmcs version.
4968 (ArrayAccess.GetStoreOpcode): Likewise.
4970 2006-09-19 Martin Baulig <martin@ximian.com>
4973 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
4974 (TypeManager.IsGenericMethodDefinition): Likewise.
4976 2006-09-19 Martin Baulig <martin@ximian.com>
4979 (TypeManager.IsEqual): Moved the gmcs implementation here.
4980 (TypeManager.DropGenericTypeArguments): Likewise.
4981 (TypeManager.DropGenericMethodArguments): Likewise.
4982 (TypeManager.GetTypeArguments): Moved here from gmcs.
4983 (TypeManager.HasGenericArguments): Likewise.
4985 2006-09-19 Martin Baulig <martin@ximian.com>
4987 * expression.cs (Binary): Merged with the gmcs version.
4989 2006-09-19 Martin Baulig <martin@ximian.com>
4991 * expression.cs (Probe, As, Is): Merged with the gmcs version.
4993 2006-09-19 Martin Baulig <martin@ximian.com>
4995 * typemanager.cs: Merged with the gmcs version.
4997 2006-09-16 Raja R Harinath <rharinath@novell.com>
4999 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
5000 * driver.cs: Likewise.
5002 2006-09-16 Marek Safar <marek.safar@seznam.cz>
5005 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
5006 only if parent type is class.
5007 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
5010 2006-09-15 Marek Safar <marek.safar@seznam.cz>
5013 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
5015 * typemanager.cs(CSharpName): Converts NullType to null.
5017 2006-09-15 Martin Baulig <martin@ximian.com>
5020 (TypeManager.GetMethodName): Added mcs implementation.
5021 (TypeManager.IsEqual): Likewise.
5024 (SimpleName.RemoveGenericArity): Added dummy implementation.
5026 * pending.cs: Merged with the gmcs version.
5028 2006-09-15 Martin Baulig <martin@ximian.com>
5030 * statement.cs: Merge with the gmcs version.
5032 2006-09-15 Martin Baulig <martin@ximian.com>
5034 * statement.cs (Switch): Merge with the gmcs implementation
5035 (without nullables), which is newer.
5037 2006-09-15 Martin Baulig <martin@ximian.com>
5039 * statement.cs (Block.Variables): Make this public.
5040 (ToplevelBlock.Parameters): Make this a property.
5041 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
5043 2006-09-15 Martin Baulig <martin@ximian.com>
5045 * namespace.cs: Merge with the gmcs version.
5047 2006-09-15 Martin Baulig <martin@ximian.com>
5049 * decl.cs (MemberName): Minor code cleanups.
5051 2006-09-15 Martin Baulig <martin@ximian.com>
5053 * parameter.cs: Merge with the gmcs version.
5055 2006-09-15 Martin Baulig <martin@ximian.com>
5057 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
5058 and an error in mcs.
5060 2006-09-15 Martin Baulig <martin@ximian.com>
5062 * flowanalysis.cs: Merged from GMCS; added the generics code into
5063 a `GMCS_SOURCE' conditional so we can share this file.
5065 2006-09-08 Martin Baulig <martin@ximian.com>
5067 * typemanager.cs (TypeManager.interlocked_type): New public field.
5068 (TypeManager.int_interlocked_compare-exchange): New public field.
5069 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
5070 enumerator types here and call InitGenericCoreTypes().
5071 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
5072 after calling InitEnumUnderlyingTypes().
5075 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
5076 `classes_second_stage'.
5078 2006-09-14 Marek Safar <marek.safar@seznam.cz>
5080 * assign.cs, ecore.cs, expression.cs: Share error message text.
5081 * class.cs (FieldMember.Define): Check for varible of static type.
5082 * driver.cs (LoadAssembly): Uses error output for errors.
5083 * statement.cs: Updated.
5085 2006-09-08 Marek Safar <marek.safar@seznam.cz>
5087 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
5090 2006-09-07 Martin Baulig <martin@ximian.com>
5093 (MainDriver): Revert r62663 from Marek; see #70506 for details.
5095 2006-08-29 Miguel de Icaza <miguel@novell.com>
5097 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
5099 2006-08-17 Miguel de Icaza <miguel@novell.com>
5101 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
5102 #52019 and #79064, the use of the \uXXXX sequence in source code
5103 to represent unicode characters.
5105 2006-08-15 Marek Safar <marek.safar@seznam.cz>
5107 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
5109 * class.cs, ecore.cs, statement.cs: Merged to one error message.
5111 2006-08-13 Miguel de Icaza <miguel@novell.com>
5113 * assign.cs: Catch attempts to assign to a method groups in += and
5116 2006-08-13 Marek Safar <marek.safar@seznam.cz>
5119 * cs-parser.jay: Don't destroy current array type by typeof of array's.
5121 2006-08-12 Marek Safar <marek.safar@seznam.cz>
5123 * class.cs (Method.Define): Issue a warning when generic method looks like
5125 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
5128 2006-08-09 Marek Safar <marek.safar@seznam.cz>
5130 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
5132 * decl.cs (MemberCache.FindMembers): When container is interface we need to
5133 search all base interfaces as a member can be ambiguous.
5134 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
5135 Constructor member type filter.
5136 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
5137 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
5138 reporting for returned memberinfos.
5139 * report.cs: Updated.
5140 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
5141 version to work on all runtimes.
5142 (TypeManager.RealMemberLookup): Removed members filtering.
5144 2006-08-08 Raja R Harinath <rharinath@novell.com>
5146 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
5147 (PropertyExpr.EmitAssign): Likewise.
5148 * expression.cs (Indirection.EmitAssign): Likewise.
5149 (LocalVariableReference.EmitAssign): Likewise.
5150 (ParameterReference.EmitAssign): Likewise.
5151 (Invocation.EmitArguments): Likewise.
5152 (ArrayAccess.EmitAssign): Likewise.
5153 (IndexerAccess.EmitAssign): Likewise.
5154 (This.EmitAssign): Likewise.
5155 (ConditionalLogicalOperator.Emit): Likewise.
5158 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
5159 instead of ArrayList. If the hashtable has a LocalBuilder, don't
5160 leave it in after returning it.
5161 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
5163 2006-08-06 Marek Safar <marek.safar@seznam.cz>
5165 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
5168 2006-08-03 Raja R Harinath <rharinath@novell.com>
5170 Fix cs0146-3.cs and cs0146-4.cs.
5171 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
5172 enclosing types don't depend on the current type.
5174 2006-08-02 Raja R Harinath <rharinath@novell.com>
5177 * class.cs (TypeContainer.DoDefineMembers): Use
5178 FindBaseMemberWithSameName on Parent, since we're interested in
5179 whether we hide inherited members or not.
5180 (FindBaseMemberWithSameName): Make slightly more robust.
5182 Fix the non-generic testcase from #77396
5183 * decl.cs (DeclSpace.DeclContainer): Remove override.
5185 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
5186 declspaces for doppelgangers too.
5187 (UsingEntry): Implement IResolveContext.
5188 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
5189 'this' as the resolve context.
5190 (LocalAliasEntry): Likewise.
5192 Implement parts of #77403
5193 * roottypes.cs (RootDeclSpace): New. Used to represent the
5194 toplevel declaration space. Each namespace declaration introduces
5195 a "partial" root declaretion space.
5196 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
5197 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
5198 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
5199 from 'current_namespace.SlaveDeclSpace'.
5200 (namespace_declaration): Likewise.
5201 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
5202 check. It can't happen now.
5203 * decl.cs (DeclSpace.LookupType): Likewise.
5204 * driver.cs (MainDriver): Sanity check.
5206 2006-08-01 Raja R Harinath <rharinath@novell.com>
5208 * decl.cs (DeclSpace.FindNestedType): Remove.
5209 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
5210 LookupTypeContainer to get the container of the nested type.
5211 * class.cs (TypeContainer.FindNestedType): Make non-override.
5213 2006-07-31 Raja R Harinath <rharinath@novell.com>
5215 * decl.cs (DeclSpace.PartialContainer): Move field from ...
5216 * class.cs (TypeContainer.PartialContainer): ... here.
5217 (TypeContainer.AddBasesForPart): New helper.
5218 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
5220 * cs-parser.jay (current_class): Convert to DeclSpace.
5221 (struct_declaration, interface_declaration, class_declaration):
5222 Use AddBasesForPart instead of .Bases directly.
5223 * const.cs, iterators.cs: Update to changes.
5225 2006-07-28 Raja R Harinath <rharinath@novell.com>
5227 * class.cs (TypeContainer.AddMemberType): Rename from
5229 (TypeContainer.AddMember): Rename from AddToMemberContainer.
5230 (AddTypeContainer): New. Combine AddClassOrStruct and
5232 (AddPartial): Update. Add 'is_partial' argument.
5233 * roottypes.cs: Update to changes.
5234 * cs-parser.jay (push_current_class): New helper for handling
5235 current_container and current_class.
5236 (struct_declaration, interface_declaration, class_declaration):
5239 2006-07-26 Raja R Harinath <rharinath@novell.com>
5241 * roottypes.cs: Rename from tree.cs.
5243 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
5244 * tree.cs (Tree, ITreeDump): Remove types.
5245 * rootcontext.cs (tree, Tree): Remove fields.
5246 (root, ToplevelTypes): New.
5247 * *.cs: Update to rename.
5249 * tree.cs (Tree.RecordDecl): Remove.
5250 (RootTypes.AddToTypeContainer): Record the toplevel type in its
5252 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
5254 2006-07-23 Raja R Harinath <harinath@gmail.com>
5256 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
5257 DoFlowAnalysis and OmitStructFlowAnalysis here.
5258 (ec.With): Rename from WithUnsafe and generalize.
5259 (ec.WithCheckState): Remove. All users can be handled by 'With'.
5260 (ec.WithFlowAnalyis): New.
5261 * ecore.cs, expression.cs, statement.cs: Update.
5263 2006-07-22 Raja R Harinath <harinath@gmail.com>
5265 * statement.cs (Block.ResolveMeta): Simplify slightly.
5267 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
5268 multiple boolean fields. Convert InUnsafe, constant_check_state,
5269 check_state to flags.
5270 (CheckState, ConstantCheckState): Update.
5271 (InUnsafe): New read-only property.
5272 (FlagsHandle): Rename from CheckStateHandle and convert to handle
5274 (WithUnsafe): New helper similar to WithCheckState.
5275 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
5276 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
5278 2006-07-21 Raja R Harinath <rharinath@novell.com>
5280 Make comparisons use the same IL irrespective of whether they're
5281 in a 'checked' or 'unchecked' context: one of the issues in #78899
5282 * codegen.cs (EmitContext.CheckState): Make read-only property.
5283 (EmitContext.ConstantCheckState): Likewise.
5284 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
5285 helper that implement a save/restore stack for CheckState
5286 values. This is the only way to change check-state.
5287 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
5288 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
5289 (CheckedExpr.EmitBranchable): New forwarding method.
5290 (UnCheckedExpr): Likewise.
5291 * statement.cs (Block.ResolveMeta): Use WithCheckState.
5292 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
5293 (Checked.Resolve, checked.DoEmit): Likewise.
5295 2006-07-20 Miguel de Icaza <miguel@novell.com>
5297 * anonymous.cs: Cache the resolved anonymous delegate, and return
5298 this so that the ResolveTopBlock is only triggered once, not
5301 Currently we trigger ResolvetopBlock twice due to a first pass of
5302 argument check compatibility, and a second pass that does the
5305 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5307 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
5309 * rootcontext.cs (Reset): Add helper_classes.
5311 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5314 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
5317 2006-07-13 Miguel de Icaza <miguel@novell.com>
5319 * statement.cs (Lock): Handle expressions of type
5320 TypeManager.null_type specially. Fixes #78770
5322 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5324 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
5327 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5329 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
5330 for accessors as well.
5331 * ecore.cs (EventExpr): Add AccessorTable.
5333 2006-07-01 Marek Safar <marek.safar@seznam.cz>
5336 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
5337 for CS0122 where appropriate.
5338 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
5340 (Filter): Assembly can be null in the case of top level attributes.
5342 2006-06-25 Marek Safar <marek.safar@seznam.cz>
5346 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
5347 is done at global level.
5349 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5351 A fix for #77002, Implemented TypeForwarder support.
5353 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
5354 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
5355 * typemanager.cs (): Add type_forwarder_attr_type.
5357 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5359 * report.cs: Add CS0469 warning.
5361 2006-06-21 Martin Baulig <martin@ximian.com>
5363 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
5364 the `try'-block, so we also report CS0016 etc. there.
5366 2006-06-21 Martin Baulig <martin@ximian.com>
5369 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
5371 2006-06-21 Martin Baulig <martin@ximian.com>
5373 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
5374 also report CS1686 for parameters.
5376 2006-06-21 Martin Baulig <martin@ximian.com>
5378 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
5379 instead of an error if the value is not implicitly convertible to
5380 the switch types; fixes #77964.
5382 2006-06-21 Raja R Harinath <rharinath@novell.com>
5385 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
5386 FieldBuilder is null.
5389 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
5390 'left' and 'right' before error-checking.
5392 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
5394 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
5396 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
5397 (FieldExpr.DoResolve): likewise.
5398 (PropertyExpr.InstanceResolve): likewise.
5399 (EventExpr.InstanceResolve): likewise.
5401 2006-06-04 Marek Safar <marek.safar@seznam.cz>
5403 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
5404 attribute applicable tests for attribute argument.
5406 2006-06-02 Raja R Harinath <rharinath@novell.com>
5409 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
5410 (Binary.OverloadResolve_PredefinedIntegral): New.
5411 (Binary.OverloadResolve_PredefinedFloating): New.
5412 (Binary.OverloadResolve_PredefinedString): New.
5413 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
5414 Follow the standard more closely, and treat numeric promotions in
5415 terms of overload resolution.
5416 (Binary.CheckShiftArguments): Simplify.
5418 2006-06-01 Raja R Harinath <rharinath@novell.com>
5420 * flowanalysis.cs (MyBitVector): Simplify representation.
5421 (MyBitVector.Clone): Avoid allocating BitArray.
5422 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
5423 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
5424 (*): Update. Change all references to MyBitVector.And and
5425 MyBitVector.Or to &= and |=.
5427 2006-05-29 Raja R Harinath <rharinath@novell.com>
5430 * cs-parser.jay (formal_parameter_list): Extend the pattern below
5431 to param arguments too.
5433 2006-05-26 Miguel de Icaza <miguel@novell.com>
5435 * cs-parser.jay: Catch another parsing form for arglist being
5436 followed by other arguments. Fixes #78313.
5438 2006-05-24 Raja R Harinath <rharinath@novell.com>
5440 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
5441 checking of out parameters to ...
5442 (FlowBranchingToplevel.Merge): ... here.
5443 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
5444 set, propagate the origin upward, and only complain if there was
5446 (FlowBranchingException.AddContinueOrigin): Likewise.
5447 (FlowBranchingException.AddReturnOrigin): Likewise.
5448 (FlowBranchingException.AddGotoOrigin): Likewise.
5450 2006-05-23 Raja R Harinath <rharinath@novell.com>
5452 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5453 unreachable, skip it.
5454 (FlowBranchingException.Merge): Always propagate jumps, even if
5455 the finally block renders subsequent code unreachable.
5457 2006-05-18 Raja R Harinath <rharinath@novell.com>
5460 * statement.cs (Goto.Resolve): Move responsibility for resolving
5461 'goto' to FlowBranching.AddGotoOrigin.
5462 (Goto.SetResolvedTarget): New. Callback to set the
5463 LabeledStatement that's the target of the goto.
5464 (Goto.DoEmit): Use Leave instead of Br when crossing an
5465 unwind-protect boundary.
5466 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5467 LookupLabel and adjust to new semantics.
5468 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5469 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5470 Goto.SetResolvedTarget to update target.
5471 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5472 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5473 AddBreakOrigin & co. Delay propagation until ...
5474 (FlowBranchingException.Merge): ... this.
5476 * statement.cs (Block.Resolve): Always depend on flow-branching to
5477 determine unreachability. Kill workaround that originally emitted
5478 only one statement after an "unreachable" label (see infloop in
5481 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5482 This is still "wrong", but anything better would probably need a
5483 multi-pass algorithm.
5484 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5485 usage vector. Force current usage vector to be reachable, to
5486 optimistically signify backward jumps.
5487 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5489 (FlowBranchingLabeled.Merge): New. If no backward jump was
5490 detected, return the original salted-away usage vector instead,
5491 updated with appropriate changes. Print unreachable warning if
5493 * statement.cs (Block.Resolve): Don't print unreachable warning on
5494 a labeled statement.
5496 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5498 * driver.cs: Pass filename without path to AssemblyBuilder's
5499 AddResourceFile. Fixes bug #78407.
5501 2006-05-17 Raja R Harinath <rharinath@novell.com>
5503 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5504 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5505 (FlowBranching.MergeChild): Overwrite
5506 reachability information from Labeled branchings too.
5508 2006-05-16 Raja R Harinath <rharinath@novell.com>
5510 * statement.cs (Goto.Resolve): Merge jump origins here ...
5511 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5513 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5514 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5515 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5516 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5518 * statement.cs (Goto.Resolve): ... not here.
5519 (Goto.Emit): Remove CS1632 check.
5521 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5523 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5526 2006-05-11 Raja R Harinath <rharinath@novell.com>
5528 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5529 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5530 (FlowBranchingException.Label): Likewise.
5532 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5534 (MyBitVector.Or): Use it to avoid losing information (Count).
5535 (FlowBranching.MergeOrigins): Likewise.
5537 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5538 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5539 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5540 (UsageVector.ToString): Simplify.
5541 (UsageVector.MergeSiblings): Move here from ...
5542 (FlowBranching.Merge): ... here.
5543 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5546 2006-05-10 Raja R Harinath <rharinath@novell.com>
5548 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5549 null bitvector is treated as all-true.
5551 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5552 (MyBitVector): Rationalize invariants. 'vector != null' implies
5553 that we have our own copy of the bitvector. Otherwise,
5554 'InheritsFrom == null' implies all inherited bits are true.
5556 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5558 * statement.cs (LocalInfo): Add IsConstant.
5559 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5560 local variable for constants.
5562 2006-05-09 Raja R Harinath <rharinath@novell.com>
5564 * flowanalysis.cs (MyBitVector.Empty): New.
5565 (MyBitVector): Don't allow InheritedFrom to be null.
5566 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5567 (UsageVector, FlowBranching): Update to changes.
5569 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5570 recursion. The 'Parent == null' condition isn't sufficient for
5572 (FlowBranching.AddBreakOrigin): Likewise.
5573 (FlowBranching.AddContinueOrigin): Likewise.
5574 (FlowBranching.AddReturnOrigin): Likewise.
5575 (FlowBranching.StealFinallyClauses): Likewise.
5576 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
5577 (FlowBranching.CheckOutParameters): Likewise.
5578 (FlowBranchingToplevel): Terminate all the above recursions here.
5579 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
5580 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
5582 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
5584 (FlowBranchingToplevel): New. Empty for now.
5585 (FlowBranching.MergeTopBlock): Update.
5586 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
5587 branching for the anonymous delegate.
5588 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
5590 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
5591 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
5592 information at the start of the merge. Reorganize.
5594 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5596 * class.cs (MethodData.Define): Method cannot implement interface accessor.
5598 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5600 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
5601 to newly introduced ctor.
5603 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
5604 message to one place.
5605 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
5608 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5610 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
5612 * ecore.cs (Expression.ResolveAsConstant): Updated.
5614 * statement.cs (ResolveMeta): Updated.
5616 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5618 * cs-parser.jay: __arglist cannot be used in initializer.
5620 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5623 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
5626 2006-05-05 Raja R Harinath <rharinath@novell.com>
5628 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
5629 (LabeledStatement): Add 'name' parameter.
5630 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
5631 (Block.AddLabel): Update to changes.
5632 * cs-parser.jay (labeled_statement): Likewise.
5634 * flowanalysis.cs (BranchingType.Labeled): New.
5635 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
5636 (FlowBranchingLabeled): New. Does nothing for now, but will
5637 eventually handle 'goto' flows.
5638 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
5639 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
5640 that's terminated ...
5641 (Block.Resolve): ... here.
5643 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
5644 (UsageVector.MergeFinallyOrigins): Likewise.
5645 (FlowBranching.InTryOrCatch): Likewise.
5646 (FlowBranching.AddFinallyVector): Likewise.
5647 (FlowBranchingException): Update to changes.
5650 * statement.cs (Return.Resolve): Move error checking to ...
5651 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
5652 (FlowBranchingException): Handle return origins like break and
5654 (FlowBranching.UsageVector.CheckOutParameters): Remove.
5656 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5659 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
5662 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5665 * class.cs (MethodData.Define): Do public accessor check only when method
5666 implements an interface.
5668 2006-05-04 Raja R Harinath <rharinath@novell.com>
5670 Remove special handling of 'break'
5671 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
5672 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
5673 (UsageVector.Break): Remove.
5674 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
5676 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
5678 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
5679 UsageVector.Breaks (). Don't set NeedsReturnLabel.
5681 2006-05-03 Marek Safar <marek.safar@seznam.cz>
5684 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
5685 be the interface member.
5687 2006-05-03 Marek Safar <marek.safar@seznam.cz>
5690 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
5691 for emitting small (int) values.
5693 2006-05-03 Raja R Harinath <rharinath@novell.com>
5696 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
5697 control-flow passes through the 'finally' after merging-in all the
5698 control-flows from 'try' and the 'catch' clauses.
5700 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
5701 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
5702 always true at the only non-recursive entry point.
5703 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
5704 FlowBranchingBreakable.
5705 (FlowBranchingLoop): Remove.
5706 * statement.cs (Return.DoResolve): Update to changes.
5709 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
5710 (FlowBranching.CreateBranching): Handle it: create a
5711 FlowBranchingContinuable.
5712 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
5713 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
5714 except that it handles the 'continue' command.
5715 (FlowBranching.UsageVector.MergeOrigins): Rename from
5717 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
5718 except that it overrides AddContinueOrigin.
5719 (FlowBranchingException): Override AddContinueOrigin, similar to
5721 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
5722 Create a new branching around the embedded statement.
5723 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
5724 control flow after the embedded statement.
5725 (Continue.Resolve): Move all error checking to AddContinueOrigin.
5727 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
5728 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
5729 FlowBranchingBreakable.
5730 (FlowBranchingSwitch): Remove.
5733 * statement.cs (Break.Resolve): Simplify. Move responsibility for
5734 error reporting to ...
5735 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
5736 Rename from 'AddBreakVector'. Add new location argument. Return
5737 a bool indicating whether the 'break' crosses an unwind-protect.
5738 (FlowBranchingException.AddBreakOrigin): Add.
5739 (FlowBranchingException.Merge): Propagate 'break's to surrounding
5740 flowbranching after updating with the effects of the 'finally'
5742 (FlowBranchingBreakable): New common base class for
5743 FlowBranchingLoop and FlowBranchingSwitch.
5745 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
5747 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
5749 2006-05-02 Raja R Harinath <rharinath@novell.com>
5751 * statement.cs (Do.Resolve): If the loop is infinite, set the
5753 (While.Resolve, For.Resolve): Set a barrier after the embedded
5754 statement. There's no direct control flow that goes from the end
5755 of the embedded statement to the end of the loop.
5756 * flowanalysis.cs (FlowBranching.Infinite): Remove.
5757 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
5758 above ensure that the reachability is correctly computed.
5760 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
5761 (UsageVector.MergeBreakOrigins): If the current path is
5762 unreachable, treat it as if all parameters/locals are initialized.
5763 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
5764 infinite loops before merging-in break origins.
5766 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
5767 (Reachability.Reachable): Split part into ...
5768 (Reachability.Unreachable): ... this. Simplify.
5769 (Reachability.IsUnreachable): Use 'Unreachable' instead.
5771 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
5772 (Reachability.SetThrowsSometimes): Likewise.
5773 (FlowBranchingBlock.MergeTopBlock): Don't compare against
5774 TriState.Always, use corresponding property.
5775 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
5776 (Block.Resolve): Likewise. Remove some redundant checks.
5778 2006-05-02 Raja R Harinath <harinath@gmail.com>
5780 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
5781 (Reachability.Meet): Don't bother checking AlwaysThrows --
5782 barrier is always set.
5783 (FlowBranchingBlock.Merge): Likewise.
5785 2006-05-01 Raja R Harinath <harinath@gmail.com>
5787 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
5788 checks for unreachable.
5790 2006-05-01 Marek Safar <marek.safar@seznam.cz>
5793 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
5795 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
5796 whether field is really assigned.
5798 2006-04-30 Raja R Harinath <harinath@gmail.com>
5800 * flowanalysis.cs (Reachability): Make 4-argument constructor
5802 (Reachability.Meet): Rename from 'And'. Remove static variant.
5803 (Reachability.Always): Rename from the highly misleading
5804 'Reachability.Never'.
5805 (FlowBranching.Merge): Update to changes. Mark an impossible
5806 situation with a 'throw'.
5807 (*): Update to changes.
5809 2006-04-29 Raja R Harinath <harinath@gmail.com>
5811 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
5813 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
5814 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
5815 (*): Update to changes.
5816 * statement.cs: Update to changes.
5818 2006-04-28 Marek Safar <marek.safar@seznam.cz>
5821 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
5823 2006-04-28 Raja R Harinath <harinath@gmail.com>
5825 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
5828 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
5829 argument to two arguments: an usage-vector and a bool. Move call
5830 to FlowBranching.Merge () ...
5831 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
5833 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
5834 handling of loop and switch reachability to ...
5835 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
5837 2006-04-27 Raja R Harinath <harinath@gmail.com>
5839 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
5840 handling to FlowBranchingLoop.InLoop.
5841 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
5843 2006-04-26 Marek Safar <marek.safar@seznam.cz>
5846 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
5847 anonymous method is allowed from AnonymousContainer here.
5849 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
5851 2006-04-24 Raja R Harinath <rharinath@novell.com>
5854 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
5856 2006-04-23 Marek Safar <marek.safar@seznam.cz>
5859 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
5860 (DoubleConstant.Reduce): Ditto.
5862 2006-04-23 Raja R Harinath <rharinath@novell.com>
5864 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
5865 Remove 'lvalue_right_side' argument. Move parts to ...
5866 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
5867 (LocalVariable.DoResolveLValue): ... these.
5869 2006-04-21 Raja R Harinath <rharinath@novell.com>
5872 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
5873 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
5874 (LocalVariableReference.DoResolveBase): Use it to implement new
5876 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
5877 (Argument.Resolve): Simplify. Move CS1510 check ...
5878 * ecore.cs (Expression.ResolveLValue): ... here.
5879 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
5880 (PropertyExpr.DoResolveLValue): Likewise.
5881 (FieldExpr.Report_AssignToReadonly): Likewise.
5882 (FieldExpr.DoResolve): Add 'out_access' argument. Use
5883 LValueMemberAccess or LValueMemberOutAccess on instance depending
5885 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
5886 DoResolve as appropriate.
5888 2006-04-20 Raja R Harinath <rharinath@novell.com>
5891 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
5892 implicit conversions on 'out' and 'ref' arguments.
5894 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
5895 improve clarity. Remove dead code.
5898 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
5899 (Catch.Resolve): Resolve VarBlock if it exists.
5901 2006-04-19 Miguel de Icaza <miguel@novell.com>
5903 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
5904 twice, this was some residual code, the enumerator was emitted
5905 properly in the two branche of if later.
5907 2006-04-19 Raja R Harinath <rharinath@novell.com>
5909 * expression.cs (Cast.ResolveLValue): Remove. The result of a
5910 cast is never an lvalue.
5911 (Cast.DoResolve, Cast.ResolveRest): Combine.
5912 (Argument.Emit): Simplify slightly. Move 'Expr is
5913 IMemoryLocation' check ...
5914 (Argument.Resolve): ... here.
5915 (Argument.Error_LValueRequired): Remove. Inline into only user.
5917 Simplifications. Fix cs0191-2.cs
5918 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
5919 CS1649 and CS1651 to ...
5920 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
5921 the actual selection of the error code and message to a lookup
5922 table. Add a dummy return value to simplify callsites.
5923 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
5924 readonly fields of other instances of the same type. Move CS0197
5926 * expression.cs (Argument.Resolve): ... here. Simplify code.
5927 Ensure that ec.InRefOutArgumentResolving is only set during LValue
5928 resolution of an out or ref argument. The code simplification
5929 above uses this invariant.
5931 2006-04-18 Raja R Harinath <rharinath@novell.com>
5933 Possibly fix #77752. Fix cs1690-[4-7].cs.
5934 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
5935 CheckMarshallByRefAccess. Drop parameter.
5936 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
5938 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
5940 * report.cs (AllWarnings): Add CS1690.
5941 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
5943 (LocalVariableReference.DoResolveBase): Update.
5945 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5947 * class.cs (MethodOrOperator): Moved common parts from method class.
5948 detect obsolete attributes.
5949 (Method.Define): Simplified as it reuses code from base.
5950 (Constructor.ValidAttributeTargets): Fixed issue found during
5952 (Destructor.ValidAttributeTargets): Fixed issue found during
5954 (Operator): Finished refactoring set off by #78020. Operator class is now
5955 ordinary method class.
5957 * anonymous.cs: Updated.
5959 * decl.cs (DeclSpace): Add IsGeneric
5961 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5963 * class.cs (Constructor.Emit): Don't emit the attributes twice.
5965 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5967 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
5968 detect obsolete attributes.
5969 (Method.CreateEmitContext): Moved to MethodOrOperator.
5971 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5974 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
5975 customized exception to make crash detection easier.
5976 (MethodOrOperator): Started to work on new base class for methods and
5978 (Method): Derives from MethodOrOperator.
5979 (Constructor.Emit): Emits its own attributes.
5980 (AbstractPropertyEventMethod.Emit): Ditto.
5981 (Operator): Derives from MethodOrOperator, will refactor fully in extra
5983 (Operator.Emit): It's temporary more tricky than should be.
5985 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
5987 * report.cs (InternalErrorException): Add ctor with inner exception.
5989 2006-04-08 Marek Safar <marek.safar@seznam.cz>
5992 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
5995 2006-04-07 Marek Safar <marek.safar@seznam.cz>
5998 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
6001 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6003 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
6004 attribute is present and Guid not.
6005 (Interface.ApplyAttributeBuilder): Ditto.
6007 * attribute.cs: Add error message.
6009 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6013 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
6014 sources (it's composite) so hold them in extra array as they are used in
6015 Emit phase only. It worked in the previous versions by mistake.
6016 (Attribute.Emit): Emit attribute for more owners when exist.
6018 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
6019 it has now different behaviour.
6021 2006-04-04 Marek Safar <marek.safar@seznam.cz>
6023 * constant.cs (Constant.IsDefaultInitializer): New method.
6025 * class.cs: Updated.
6027 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
6028 re-initialize default values. It saves KBs almost for every assembly.
6029 Thanks Zoltan for the idea.
6030 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
6031 (ArrayCreation.DoResolve): Resolve only once.
6032 (ArrayCreation.Emit): Emit static initializer only when it is faster.
6033 (ArrayCreation.GetAttributableValue): Cope with optimized values.
6035 2006-04-03 Zoltan Varga <vargaz@gmail.com>
6037 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
6040 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6042 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
6043 in an embedded statement too.
6045 2006-04-01 Raja R Harinath <rharinath@novell.com>
6048 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
6050 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6054 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
6057 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
6059 2006-03-31 Marek Safar <marek.safar@seznam.cz>
6061 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
6064 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
6065 LocalTemporary change.
6067 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
6069 (ClassOrStruct.DefineFieldInitializers): Implemented static field
6070 initializers optimization.
6071 (ClassOrStruct.TypeAttr): Moved from modifiers.
6072 (Constructor.CheckBase): Don't crash when static ctor has parameters.
6073 (FieldBase.ResolveInitializer): Resolves initializer.
6074 (FieldBase.HasDefaultInitializer): New property.
6076 * cs-parser.jay: Removed message.
6078 * expression.cs (CompilerGeneratedThis): New specialization.
6080 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
6082 2006-03-28 Marek Safar <marek.safar@seznam.cz>
6084 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
6086 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6088 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
6089 be now EnumConstants only.
6091 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6093 * attribute.cs, driver.cs: Reset more caches.
6095 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6097 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
6099 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6101 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
6102 for easier reuse. Updated all overrides.
6103 (IntegralConstant): New base class for all integral constants.
6104 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
6105 of the constant range, report custom error.
6106 (UIntConstant.Reduce): Fixed uint conversion.
6108 * ecore.cs, literal.cs: Reduce updates.
6110 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6114 * class.cs (Constructor.Define): Removed extra if for default ctors.
6115 A patch from Atsushi Enomoto.
6117 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6119 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
6120 GetAttributableValue.
6122 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
6125 * convert.cs (ImplicitConversionRequired): Error message moved to
6128 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
6129 automatic implicit conversion of an output value.
6130 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
6132 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
6134 (TypeOf.GetAttributableValue): Add extra handling for object type.
6136 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
6137 special error message.
6139 2006-03-25 Marek Safar <marek.safar@seznam.cz>
6141 * class.cs (Constructor.Emit): Don't crash when struct ctor is
6143 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
6144 compatible with MS runtime.
6146 2006-03-23 Marek Safar <marek.safar@seznam.cz>
6148 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
6149 attribute arguments here.
6151 * class.cs (Indexer.Define): The check was moved to attribute class.
6153 2006-03-22 Marek Safar <marek.safar@seznam.cz>
6155 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
6156 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
6159 2006-03-22 Raja R Harinath <rharinath@novell.com>
6161 Support ParameterDefaultValueAttribute in gmcs. Also applied to
6162 mcs to keep code differences small.
6163 * attribute.cs (Attribute.GetParameterDefaultValue): New.
6164 * typemanager.cs (parameter_default_value_attribute_type): New.
6165 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
6168 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6170 * expression.cs (StringConcat.Append): Reverted back to no warning state.
6172 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6174 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
6176 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
6179 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
6181 * doc-bootstrap.cs : fix build.
6183 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6185 * expression.cs (StringConcat.Append): Issue a warning when empty string
6188 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6190 * assign.cs (CompoundAssign.ResolveSource): Removed.
6192 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
6195 * class.cs (TypeContainer.FindMethods): Removed.
6196 (TypeContainer.CheckMemberUsage): Made static.
6198 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
6200 * constant.cs (CheckRange): Removed unused type argument.
6201 (CheckUnsigned): Removed unused type argument.
6203 * cs-parser.jay: Updated after MemberAccess clean up.
6204 Uses Length for empty string test.
6206 * cs-tokenizer.cs: Uses Length for empty string test.
6207 (IsCastToken): Made static.
6208 (is_hex): Made static.
6209 (real_type_suffix): Made static.
6211 * decl.cs (SetupCache): Made static.
6212 (OnGenerateDocComment): Removed unused ds argument.
6214 * delegate.cs (VerifyDelegate): Removed unused argument.
6216 * doc.cs: Uses Length for empty string test.
6218 * driver.cs: Uses Length for empty string test.
6220 * enum.cs (IsValidEnumType): Made static
6222 * expression.cs (EnumLiftUp): Removed unused argument.
6223 (ResolveMethodGroup): Ditto.
6224 (BetterConversion): Ditto.
6225 (GetVarargsTypes): Ditto.
6226 (UpdateIndices): Ditto.
6227 (ValidateInitializers): Ditto.
6228 (MemberAccess.ctor): Ditto.
6229 (GetIndexersForType): Ditto.
6231 * flowanalysis.cs: (MergeFinally): Removed unused argument.
6233 * iterators.cs: Updated after MemberAccess clean up.
6235 * location.cs: Uses Length for empty string test.
6237 * namespace.cs: Uses Length for empty string test.
6239 * report.cs (CheckWarningCode): Made static.
6241 * statement.cs (LabeledStatement): Removed unused argument.
6243 * typemanager.cs (FilterNone): Removed.
6245 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6247 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
6250 * class.cs: Updated.
6252 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6254 * cs-parser.jay.cs: __arglist is not allowed for delegates.
6256 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6260 * expression.cs (VerifyArgumentsCompat): Reverted to double error
6261 reporting, it's more tricky than I thought.
6263 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6267 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
6269 (AnonymousMethod.ImplicitStandardConversionExists): New method.
6270 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
6271 Add more error reporting; Fixed issue with params.
6273 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
6275 * cs-parser.jay: AnonymousMethod requires host container.
6277 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
6279 2006-03-18 Raja R Harinath <harinath@gmail.com>
6281 * class.cs: Change 'TypeContainer ds' constructor argument to
6282 'DeclSpace parent'. Some classes were missed below due to
6283 different naming convention.
6285 * class.cs (MemberCore.Parent): Delete. This makes the
6286 ParentContainer changes below enforceable by the compiler.
6288 Treat pointers to enclosing declaration space as 'DeclSpace', not
6290 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
6291 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
6293 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
6295 (Block.AddThisVariable): Likewise.
6296 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
6297 (AbstractPropertyEventMethod.Emit): Likewise.
6298 (AbstractPropertyEventMethod.EmitMethod): Likewise.
6299 (GetMethod.Define, SetMethod.Define): Likewise.
6300 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
6301 (DelegateMethod.EmitMethod): Likewise.
6303 Fix regression test-partial-13.cs.
6304 Rationalize use of PartialContainer. Ensure that the partial
6305 class semantics can be tied to type-correctness, i.e., any
6306 violation will cause a compile error.
6307 * class.cs, const.cs: Access all fields that belong to class
6308 TypeContainer via ParentContainer. Arguments of EmitContexts and
6309 Resolve()-like functions still use 'Parent'.
6311 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
6312 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
6313 (PropertyMethod.CheckModifiers): Remove unused argument.
6314 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
6317 2006-03-17 Raja R Harinath <harinath@gmail.com>
6319 Make semantics of PartialContainer simpler.
6320 * decl.cs (DeclSpace.IsPartial): Remove.
6321 * class.cs (TypeContainer.IsPartial): Likewise.
6322 (TypeContainer..ctor): Set PartialContainer to point to self.
6323 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
6324 (TypeContainer.FindNestedType): Likewise.
6325 (MemberCore.ParentContainer): Simplify. Remove deprecation.
6327 2006-03-17 Marek Safar <marek.safar@seznam.cz>
6329 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
6331 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6333 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
6336 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6338 * class.cs (Operator.Define): An error for base conversion was not
6341 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
6343 * iterator.cs : yield break is allowed in try statement which has
6344 catch clauses. Fixed bug #77767.
6346 2006-03-13 Marek Safar <marek.safar@seznam.cz>
6348 A fix for #77593, #77574.
6350 * class.cs (MethodCore.CheckBase): Another if for operator.
6352 2006-03-09 Marek Safar <marek.safar@seznam.cz>
6354 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
6357 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
6358 (DelegateCreation.ImplicitStandardConversionExists): New method for just
6361 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
6364 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
6365 Updated after another emitcontext usage was clean up. It should help us to
6366 synchronize with gmcs easier.
6368 2006-03-04 Marek Safar <marek.safar@seznam.cz>
6372 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
6373 (Event.Define): ditto
6374 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
6376 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
6377 Removed redundant code and set NewSlot for Invoke method too.
6379 * parameter.cs (Parameters.ctor): Add custom, type ctor.
6380 (Parameters.MergeGenerated): New method. Use this method when you merge
6381 compiler generated argument with user arguments.
6383 2006-03-03 Marek Safar <marek.safar@seznam.cz>
6385 * attribute.cs (ResolveAsTypeTerminal): Removed.
6387 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
6388 specialization for predefined types; 30% speed up.
6389 Finally placed obsolete check to right place.
6390 (Expression.ResolveType): Removed.
6392 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
6393 Updated after ResolveType was removed.
6395 * expression.cs (Cast.ctor): Check void cast.
6396 (Binary.ResolveAsTypeTerminal): Is never type.
6397 (Conditional.ResolveAsTypeTerminal): Is never type.
6399 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
6401 2006-03-01 Raja R Harinath <rharinath@novell.com>
6404 * expression.cs (ParameterReference.DoResolveBase): Change return
6406 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
6410 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
6413 * typemanager.cs (GetFullNameSignature): Don't nullref on
6414 protected accessors.
6416 2006-02-27 Marek Safar <marek.safar@seznam.cz>
6418 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
6419 these two separated members to simplify the code.
6420 (Attribute.Resolve): Refactored to use new fields and methods.
6421 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
6422 implemented obsolete attribute checking.
6423 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
6424 implemented obsolete checking again. It look line never ending quest ;-)
6425 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
6427 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
6429 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
6431 *class.cs (Property.Define): Add RegisterProperty call.
6433 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
6434 argument groups (only 2).
6436 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
6437 encoding expression to arguments.
6438 (Expression.ExprClassToResolveFlags): Just turned to property.
6440 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
6441 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
6442 optimized as well as implemented support for zero-length attributes.
6444 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
6445 Add caching of PropertyInfo's.
6447 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6449 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
6450 error multiple times.
6452 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6454 New partial class implementation.
6455 A fix for #77027, #77029, #77403
6457 * attribute.cs (Attributable): Made attributes protected.
6459 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6460 the replacements of ClassPart and PartialContainer.
6461 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6462 (TypeContainer.AddInterface): Ditto.
6463 (TypeContainer.AddPartial): The main method for partial classes. It checks
6464 for errors and merges ModFlags and attributes. At the end class is added to
6466 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6468 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6469 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6470 from the rest of partial classes.
6471 (TypeContainer.GetClassBases): Simplified.
6472 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6474 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6475 (TypeContainer.HasExplicitLayout): Uses Flags now.
6476 (PartialContainer): Removed.
6477 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6478 (StaticClass): Was merged with Class.
6479 (Class.GetClassBases): class and static class bases are verified here.
6480 (Class.TypeAttr): Added static attributes when class is static.
6481 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6482 (MemberBase): In some cases we need to call parent container for partial
6483 class. It should be eliminated but it's not easy now.
6485 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6487 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6488 partial classed to accumulate class comments.
6489 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6491 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6493 * driver.cs (MainDriver): Tree.GetDecl was removed.
6495 * modifiers.cs (Modifiers): Add partial modifier.
6497 * tree.cs (Tree.decl): Removed.
6498 (RootTypes): Started to use this class more often for root types
6501 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6505 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6506 external interface does not have an attribute.
6508 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6510 Another prerequisites for new partial classs implementation.
6512 * attribute.cs (Attribute.Equal): Implemented.
6513 (Attribute.Emit): Changed as attributes can be applied more than twice.
6514 (Attributes.Emit): Check for duplicate attributes here.
6516 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6517 as a parameter, clean-up.
6519 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6523 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6524 contains obsolete attribute check which can in some cases look for base
6525 type of current class which is not initialized yet.
6526 (TypeContainer.BaseType): Replacement of ptype.
6528 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6530 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6532 First of prerequisites for new partial classs implemention.
6534 * attribute.cs (Attributable): Extended by ResolveContext;
6535 Attributes finally have correct context for resolving in all cases.
6536 (AttachTo): Attribute owner is assigned here.
6538 * codegen.cs (IResolveContext): Introduce new interface to hold
6539 all information needed in resolving phase.
6540 (EmitContext): Implements IResolveContext; more clean-up needed here.
6542 * decl.cs (MemberCore): Implemented IResolveContext.
6544 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6545 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6546 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6547 Refactored to use new IResolveContext instead of EmitContext; cleanup
6549 2006-02-06 Miguel de Icaza <miguel@novell.com>
6551 * codegen.cs (EmitScopeInitFromBlock): check here the
6552 capture_context, there is no need to make two calls to the
6555 * anonymous.cs: Add some debugging messages that might help me
6556 track other instances of this problem in the future (the
6557 regression of test 467).
6559 * cs-parser.jay: track the variable block, as we need to initalize
6560 any captured variables declared in this block for the "catch"
6561 portion of the "Try" statement.
6563 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6564 scope initialization for captured variables.
6566 Also, move the emit for the variables after the block location has
6569 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6571 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6573 2006-02-02 Miguel de Icaza <miguel@novell.com>
6575 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
6576 commit yesterday, the initialization for the roots is necessary.
6577 What is not necessary is the scope activation.
6579 2006-02-02 Raja R Harinath <rharinath@novell.com>
6581 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
6582 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
6584 (Argument.Resolve): Remove CS0206 checks.
6586 2006-02-01 Miguel de Icaza <miguel@novell.com>
6588 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
6589 scopes for all the roots, the scopes will now be emitted when the
6590 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
6592 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
6593 code. This reduces a lot of existing cruft.
6595 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
6596 that the ScopeInfo is generated as we enter the scope, not at the
6597 time of use, which is what we used to do before.
6599 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
6600 every time a Block is about to be emitted if we have a
6603 2006-02-01 Raja R Harinath <rharinath@novell.com>
6605 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
6607 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
6609 * typemanager.cs (cons_param_array_attribute): Make private.
6610 (Reset): Set it to null.
6611 (InitCoreHelpers): Don't initialize it.
6612 (ConsParamArrayAttribute): New. Initialize it as needed.
6613 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
6615 2006-01-31 Miguel de Icaza <miguel@novell.com>
6617 * expression.cs: There might be errors reported during the
6618 selection of applicable methods. If there are errors, do not
6619 continue execution as it will lead the compiler to crash.
6621 2006-01-30 Miguel de Icaza <miguel@novell.com>
6623 * expression.cs: Member access is not allowed on anonymous
6624 methods. Fixes #77402.
6626 2006-01-30 Raja R Harinath <rharinath@novell.com>
6629 * cs-parser.jay (VariableDeclaration): Don't set
6630 current_array_type to null.
6631 (field_declaration, event_declaration, declaration_statement):
6632 Set it to null here.
6634 2006-01-28 Raja R Harinath <harinath@gmail.com>
6636 * typemanager.cs (GenericParameterPosition): New.
6639 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
6641 * doc.cs : To process "include" elements, first we should create
6642 another list than XmlNodeList, because it could result in node
6643 removal, which could result in that the XmlNodeList gives up
6646 (Also made code identical to gmcs again.)
6648 2006-01-25 Miguel de Icaza <miguel@novell.com>
6650 * ecore.cs: Introduce an error report that we were not catching
6651 before, if not silent, we must report the error. Gonzalo ran into
6654 2006-01-23 Miguel de Icaza <miguel@novell.com>
6656 A fix for bug: #76957
6658 * iterators.cs (MoveNextMethod.CreateMethodHost): call
6659 ComputeMethodHost before creating the method, this is a new
6662 * anonymous.cs (AnonymousContainer): Now we track all the scopes
6663 that this method references (RegisterScope). The actual scope
6664 where the method is hosted is computed with the ComputeMethodHost
6665 before we create the method.
6667 Moved the Deepest routine here.
6669 (AnonymousContainer.ComputeMethodHost): New routine used to
6670 compute the proper ScopeInfo that will host the anonymous method.
6672 (ScopeInfo): Deal with multiple roots. The problem was that we
6673 did not have a unique root where all ScopeInfos could be hanged
6674 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
6677 Remove AdjustMethodScope which is now computed at the end. Remove
6678 LinkScope which did a partial link, instead link all ScopeInfos
6679 before code generation from the new "LinkScopes" routine.
6681 Simplify all the Add* routines as they no longer need to maintain
6682 the tree, they just need to record that they are using variables
6685 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
6686 routines to produce the forest of ScopeInfo trees.
6688 * class.cs (TypeContainer.AppendMethod): This is just like
6689 AddMethod, but ensures that an interface implementation method
6690 (IEnumerable.XXX) is not inserted at the beginning of the queue of
6691 methods, but at the end.
6693 We use this functionality to ensure that the generated MoveNext
6694 method in the iterator class is resolved/emitted before the
6695 enumerator methods created.
6697 This is required because the MoveNext method computes the right
6698 ScopeInfo for the method. And the other methods will eventually
6699 need to resolve and fetch information computed from the anonymous
6702 2006-01-21 Raja R Harinath <harinath@gmail.com>
6703 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6706 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
6708 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
6709 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
6711 2006-01-18 Raja R Harinath <rharinath@novell.com>
6713 Fix #76656, cs0231-2.cs.
6714 * cs-parser.jay (formal_parameter_list): Make error case catch
6716 (parenthesized_expression_0): Add CS1026 check.
6717 (invocation_expression): Remove unused { $$ = lexer.Location }.
6719 2006-01-17 Raja R Harinath <rharinath@novell.com>
6722 * cs-parser.jay (statement_expression): Don't list out the
6723 individual statement-expressions. Convert syntax error into
6726 2006-01-16 Raja R Harinath <rharinath@novell.com>
6729 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
6730 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
6731 CheckIntermediateModification.
6732 (FieldExpr.DoResolve): Add new two-argument version that
6733 allows us to resolve the InstanceExpression as an lvalue.
6734 The one-argument variant is now just a wrapper.
6735 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
6736 Resolve the lhs as an lvalue if the it has a value type.
6737 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
6738 from Assign.DoResolve.
6739 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
6740 resolved as an lvalue.
6741 (PropertyExpr.DoResolve): Update.
6742 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
6743 has a value type. Move CS1612 check here from
6744 CheckIntermediateModification.
6745 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
6746 * expression.cs (EmptyExpression.OutAccess): New. Used as the
6747 'right_side' of a ResolveLValue on an 'out' argument.
6748 (EmptyExpression.LValueMemberAccess): New. Used as the
6749 'right_side' of a propagated ResolveLValue on a value type.
6750 (LocalVariableReference.DoResolveBase): Recognize
6751 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
6753 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
6754 EmptyExpression.Null.
6756 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
6758 * typemanager.cs : added IsGenericParameter(). In mcs it always
6760 * doc.cs : for generic parameters, use GenericParameterPosition,
6763 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
6765 * expression.cs: Fix Console.WriteLine ((this = x).foo);
6767 2006-01-12 Miguel de Icaza <miguel@novell.com>
6769 This fixes the problem where we used ldfld instead of ldflda to
6770 load the "THIS" pointer on captured parameters, when THIS is a
6771 value type. See bug #77205.
6773 * iterators.cs (CapturedThisReference.Emit): Pass false to
6774 EmitThis (we do not need the address).
6776 * codegen.cs (EmitThis): it needs to know whether we need the
6777 address of `this' or not. This is used by value types.
6779 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
6780 every other call passes false.
6782 2006-01-12 Raja R Harinath <rharinath@novell.com>
6785 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
6787 * expression.cs (Invocation.OverloadResolve): Update.
6788 (Invocation.DoResolve): Avoid double resolution of invocation.
6790 2006-01-11 Raja R Harinath <rharinath@novell.com>
6793 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
6794 unary negation of floating point types as 0-expr; negation cannot
6795 overflow in floating point types.
6798 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
6799 on operands of 'void' type.
6802 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
6803 and ExclusiveOr for boolean constants too.
6805 2006-01-09 Raja R Harinath <rharinath@novell.com>
6808 * expression.cs (Invocation.OverloadResolve): Replace reflected
6809 override methods with their base virtual methods, rather than
6811 * typemanager.cs (TypeManager.GetOverride): New.
6813 2006-01-05 Jb Evain <jbevain@gmail.com>
6815 * class.cs (Property.Define, Indexer.Define): do not tag the
6816 properties as SpecialName | RTSpecialName.
6818 2006-01-04 Miguel de Icaza <miguel@novell.com>
6820 * class.cs (MethodCore.IsDuplicateImplementation): This method was
6821 doing a low-level comparission of parameter types. It was lacking
6822 a check for __argslist.
6824 2005-12-30 Miguel de Icaza <miguel@novell.com>
6826 * expression.cs (ParameterReference.DoResolveBase): Allow
6827 reference parameters if they are local to this block.
6829 This allows the ref and out parameters of a delegate to be used in
6830 an anonymous method, for example:
6832 delegate void set (out int x);
6834 set s = delegate (out int x){
6838 This is used by functionality introduced late in the C# language.
6840 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
6841 method that take ref and out parameters.
6843 Fixes #77119 which was a late change in the spec.
6845 2005-12-23 Miguel de Icaza <miguel@novell.com>
6847 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
6848 parent if its the same scope. Fixes #77060.
6850 2005-12-21 Miguel de Icaza <miguel@novell.com>
6852 * driver.cs: Report the case of no source files and no -out:
6855 2005-12-20 Raja R Harinath <rharinath@novell.com>
6858 * expression.cs (ComposedCast.GetSignatureForError): Define.
6860 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6864 * namespace.cs (NamespaceEntry): Add extern_aliases as a
6865 ListDictionary, to contain the ExternAliasEntry entries (in
6866 addition to the NamespaceEntry.aliases hashtable). This field is
6867 shared between the original entry and its doppelganger (bodyless
6869 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
6870 extern_aliases field.
6871 (NamespaceEntry.Lookup): Move the IsImplicit check after the
6872 lookup in extern_aliases.
6874 2005-12-16 Raja R Harinath <rharinath@novell.com>
6877 * class.cs (TypeContainer.Mark_HasEquals): New.
6878 (TypeContainer.Mark_HasGetHashCode): New.
6879 (ClassPart): Override them.
6880 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
6883 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
6884 'parent' argument to the base constructor.
6886 Remove all mention of TypeContainer from decl.cs.
6887 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
6888 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
6889 (DeclSpace.DeclSpace): Likewise.
6890 (DeclSpace.DefineMembers): Remove unused argument.
6891 * cs-parser.jay (pop_current_class): Update to changes. Simplify
6892 debugging check -- we don't care if the debug code throws an
6893 InvalidCastException instead of an InternalErrorException.
6894 * class.cs (TypeContainer.DefineMembers): Update to changes.
6895 (TypeContainer.DoDefineMembers): Likewise.
6896 (TypeContainer.GetMethods): Likewise.
6897 (PropertyMember.Define): Likewise.
6898 (MemberBase.Parent): New property that forwards to
6899 MemberCore.Parent, but ensures that we get a TypeContainer.
6900 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
6901 (RootContext.PopulateTypes): Likewise. Remove special case code
6902 for !RootContext.StdLib: DefineMembers is idempotent.
6904 2005-12-14 Miguel de Icaza <miguel@novell.com>
6906 * convert.cs (ExplicitConversionCore): Check the return value from
6907 ExplicitConversionCore which can return null on failure. Fixes #76914
6909 2005-12-13 Marek Safar <marek.safar@seznam.cz>
6911 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
6913 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
6915 * doc.cs : The search for referenced namespace was insufficient to
6916 get global one as it used to do. Fixed bug #76965.
6918 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
6920 * doc.cs : check name in cref in the last phase that whether it is
6923 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6925 * cs-tokenizer.cs : reverted the latest change: it somehow broke
6928 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6930 * doc.cs : so it turned out that we cannot skip override check for
6931 interface members. Fixed bug #76954.
6933 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6935 * cs-tokenizer.cs : fixed bug #75984:
6936 - #warning and #error should not be handled when the source line
6938 - #line is not checked strictly when the source line is disabled.
6939 - #define and #undef is on the other hand checked strictly at any
6942 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
6944 * cs-tokenizer.cs : missing Location (actually, filename) in one of
6947 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6949 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
6951 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
6953 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
6954 (FieldBase.Initializer): Initializer is now optional.
6955 (EventField.Define): Only event field can have initializer.
6957 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
6959 * const.cs (Const): Reuse initializer.
6961 * cs-parser.jay: Updated after FieldBase changes.
6962 Added current_array_type to simplify array initializers.
6964 * ecore.cs (NullCast.IsDefaultValue): Implemented.
6966 * expression.cs, iterators.cs: Updated.
6968 * namespace.cs (NamespaceEntry): Made UsingFound private.
6970 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6972 * parameterCollection.cs: Obsolete, removed.
6973 * parser.cs: Obsolete, removed.
6975 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6978 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
6980 * enum.cs (Enum.Define): Set obsolete context here.
6982 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6985 - FindDocumentedMember() now expects 1) paramList as null
6986 when "we don't have to check the number of parameters" and
6987 2) Type.EmptyTypes when "there is no arguments".
6988 - Introduced FoundMember struct to hold the exact type which was
6989 used to find the documented member (the above change broke
6990 test-xml-044; it might be better just to use DeclaringType than
6991 what MS does, like this change does, but it depends on usage.)
6993 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6995 * doc.cs : documented member might be from DeclaringType for nested
6996 types. Fixed bug #76782.
6998 2005-12-03 Ben Maurer <bmaurer@ximian.com>
7000 * anonymous.cs: Have the param code handle leaving copies on the
7001 stack etc. Allows anonymous params to take part in the assignment
7002 code (++, +=, etc). Fixes bug #76550
7004 * expression.cs: Handle the prepare_for_load/leave_copy by passing
7005 it down to the anon code.
7007 * iterators.cs: Use dummy var here
7009 * codegen.cs: Handle new vars
7011 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7014 * class.cs (MethodData.Define): Set proper Obsolete context.
7016 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
7018 (FieldExpr.DoResolve): Ditto.
7020 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7023 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
7024 parent is not obsolete.
7026 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
7028 * doc.cs : (FindDocumentedMember) find parameterless members first
7029 and get CS0419 in the early stage. Fixed first case of bug #76727.
7031 2005-11-30 Marek Safar <marek.safar@seznam.cz>
7034 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
7035 no error was reported.
7037 *expression.cs (Binary.DoResolve): left can be null.
7039 2005-11-22 Marek Safar <marek.safar@seznam.cz>
7042 * class.cs (MethodData.Emit): Parameters should be labeled first.
7044 2005-11-21 Marek Safar <marek.safar@seznam.cz>
7047 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
7049 2005-11-18 Marek Safar <marek.safar@seznam.cz>
7051 * attribute.cs (AreParametersCompliant): Moved to Parameter.
7053 * class.cs (MethodCore): Parameter clean up.
7054 (IMethodData): Added ParameterInfo.
7055 (MethodData): Parameter clean up.
7056 (Indexer.Define): Parameter clean up.
7068 * typemanager.cs: Parameter clean up.
7070 * delegate.cs (Define): Get rid of duplicated code.
7072 * expression.cs (ParameterReference): Removed useless parameters
7074 (Invocation): Ditto.
7076 * parameter.cs (ParamsParameter): New class, params specialization.
7077 (ArglistParameter): Attemp to separate arglist.
7078 (Parameter): Refactored to be reusable and faster.
7079 (Parameter.Modifier): Made understandable.
7080 (Parameters): Changed to be used as a class for `this' assembly
7081 parameters. Refactored to use new specialized classes.
7083 * support.cs (ParameterData): Added Types property.
7084 (InternalParameters): Deleted.
7086 2005-08-20 Martin Baulig <martin@ximian.com>
7088 Merging this patch from GMCS to fix #75867.
7090 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7091 scope if we don't already have it.
7093 2005-11-17 Martin Baulig <martin@ximian.com>
7096 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
7097 inherit the scope from our parent. Fixes #76653.
7099 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7101 * doc.cs : the previous patch does not actually fix the bug.
7102 PropertyInfo override check is now implemented and really fixed it.
7103 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
7105 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7107 * doc.cs : apply "override filter" also to properties.
7110 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7112 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
7113 no need to check overrides. For classes, omit those results from
7114 interfaces since they must exist in the class. Fixed bug #76726.
7116 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7118 * typemanager.cs : (GetFullNameSignature) differentiate indexers
7119 with different parameters. Fixed the second problem in #76685.
7121 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7123 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
7124 get expected 'protected' access in CheckValidFamilyAccess()).
7127 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7129 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
7130 Fixed bug #76705. CS1569 was incorrectly commented out.
7132 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7134 * doc.cs : use Invocation.IsOverride() to do real override check.
7135 * expression.cs : made Invocation.IsOverride() internal.
7137 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7139 * doc.cs : use TypeManager.FindMembers() instead of (possible)
7140 TypeBuilder.FindMembers() and filter overriden base members out.
7143 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7145 * doc.cs : ref/out parameters are represented as '@' (instead of
7146 '&' in type FullName). Fixed bug #76630 (additionally crefs).
7148 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7150 * doc.cs : when there was no '.' in cref to methods in doc comment,
7151 then parameters were missing in the output. Fixed bug #76691.
7153 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7155 * driver.cs : don't output docs when there is an error.
7158 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7161 Now it should detect indexers. Fixed primary concern in bug #76685.
7162 Fixed CS0419 message to not show the identical member signature in
7165 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7167 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
7168 instead of Type.FindMembers() since it does not handle events.
7171 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
7173 * codegen.cs: Fixed typo (speficied -> specified).
7175 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7178 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
7180 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7182 * attribute.cs: Changed error message.
7184 * cs-tokenizer.cs: One more check.
7186 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7188 * statement.cs (Block.Resolve): Ignore empty statement.
7190 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7192 * report.cs: Made error/warning methods more strict to avoid
7195 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
7196 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
7197 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
7198 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
7200 2005-11-08 Marek Safar <marek.safar@seznam.cz>
7202 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
7203 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
7205 * class.cs (TypeContainer.IsComImport): New property.
7206 (Constructor.Define): Create proper ctor for ComImport types.
7208 * expression.cs (New.CheckComImport): Fixed.
7210 2005-11-07 Miguel de Icaza <miguel@novell.com>
7212 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
7213 that a parameter has been captured does not mean that we do not
7214 have to do the rest of the processing. This fixes the second part
7215 of #76592. If there was another anonymous method capturing
7216 values in the past, the Scope would never be set for the second
7217 method that captured the same parameter.
7219 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
7220 properly manipulate the stack. Second part of fix for #76592.
7222 * expression.cs (New): Add support for invoking "new" on
7223 interfaces that have been flagged with the ComImport attribute and
7224 the CoClass. Fixes #76637
7226 * statement.cs (Try.DoEmit): When a variable is captured, do not
7227 try to emit the vi.LocalBuilder variable as it has been captured.
7228 Create a temporary variable and store the results on the
7229 FieldBuilder. Fixes #76642
7231 2005-11-07 Marek Safar <marek.safar@seznam.cz>
7233 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
7235 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
7237 * expression.cs (Binary.DoResolve): Added && optimalization.
7239 * typemanager.cs (AddUserType): Removed useless argument.
7241 2005-11-04 Marek Safar <marek.safar@seznam.cz>
7243 * statement.cs (Block.variables): Uses ListDictionary.
7245 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7248 * class.cs (PartialContainer.EmitType): Customized to emit
7249 security attributes.
7250 (ClassPart.ApplyAttributeBuilder): Transform security attribute
7251 for partial classes.
7253 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7256 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
7257 access has to be fixed.
7259 * typemanager.cs (IsUnmanagedType): Wrong common field type.
7261 2005-11-01 Marek Safar <marek.safar@seznam.cz>
7264 * ecore.cs (NullCast.Reduce): Implemented.
7266 * expression.cs (ArrayCreation.CheckIndices): Correcly check
7269 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
7271 (Foreach.Resolve): Catch null properly.
7273 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7275 * cs-tokenizer.cs: Warning text fix.
7277 * driver.cs: AllWarningNumbers exposed on public interface.
7279 * report.cs (): Reviewed warning numbers.
7280 (IsValidWarning): Use binary search.
7282 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7284 * driver.cs: Implemeted resource visibility.
7285 (Resources): New class for code sharing between /res: and
7288 2005-10-28 Marek Safar <marek.safar@seznam.cz>
7291 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
7294 * convert (Convert.ImplicitReferenceConversion): NullCast holds
7297 * ecore.cs (NullCast): Child is contant only.
7299 * literal.cs (NullLiteral.Reduce): null can be converted to any
7302 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
7304 * driver.cs: Use Encoding.Default as default code page instead
7307 2005-10-27 Raja R Harinath <rharinath@novell.com>
7310 * expression.cs (Invocation.Error_InvalidArguments): Handle
7311 __arglist parameters.
7312 (Invocation.VerifyArgumentsCompat): Likewise.
7313 * support.cs (ReflectionParameters.GetSignatureForError): Print
7314 __arglist parameters.
7315 (InternalParamters.GetSignatureForError): Likewise.
7316 * parameter.cs (Parameters.GetSignatureForError): Likewise.
7318 2005-10-26 Marek Safar <marek.safar@seznam.cz>
7320 * attribute.cs (GetPropertyValue): Made public.
7322 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
7324 Add new property WrapNonExceptionThrows to handle 2.0 assembly
7326 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
7329 * driver.cs: Reflect method name change.
7331 * statement.cs (Try.Resolve): Warn when try has both general
7334 * typemanager.cs: runtime_compatibility_attr_type new predefined
7337 2005-10-26 Raja R Harinath <harinath@gmail.com>
7340 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
7341 treat it as an empty parameter list.
7343 2005-10-26 Raja R Harinath <rharinath@novell.com>
7346 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
7347 ResolveAsTypeStep silent.
7348 * statement.cs (Block.AddConstant): Mark block as used.
7349 (Block.ResolveMeta): Avoid piling on error messages
7350 if a constant initializer resolution fails.
7352 2005-10-25 Raja R Harinath <rharinath@novell.com>
7354 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
7356 (NamespaceEntry.VerifyAllUsing): New.
7357 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
7358 behaviour. Delegates actual resolution of alias to ...
7359 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
7360 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
7362 * driver.cs (Driver.MainDriver): Update.
7364 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
7365 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
7367 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
7369 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
7370 RootNamespace.DefineNamespacesForAll.
7372 2005-10-24 Raja R Harinath <harinath@gmail.com>
7374 * typemanager.cs (assemblies, external_aliases, modules)
7375 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
7376 (ComputeNamespaces, GetRootNamespace): Remove extra staging
7377 overhead. Move resposibility ...
7378 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
7379 * driver.cs, attribute.cs, codegen.cs: Update to changes.
7381 2005-10-23 Raja R Harinath <harinath@gmail.com>
7383 * namespace.cs (RootNamespace.all_namespaces): Renamed from
7384 cached_namespaces. Improve usage.
7385 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
7386 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
7387 Move from GlobalRootNamespace and simplify.
7388 (RootNamespace.Global): Make instance variable.
7389 (RootNamespace.RootNamespace): Add "alias name" parameter.
7390 (GlobalRootNamespace): Simplify drastically.
7391 (Namespace.Lookup): Don't use GetNamespace.
7392 * typemanager.cs (GetRootNamespace): Rename from
7393 ComputeNamespaceForAlias.
7394 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
7396 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7398 * anonymous.cs (AnonymousContainer): Don't crash when container
7401 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7403 * expression.cs (Binary.DoResolve): Warn when comparing same
7406 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7409 * expression.cs (Binary.DoResolve): It looks like there are no
7410 convetsion rules in enum context.
7412 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7414 Add support for extern alias qualifiers.
7415 * typemanager.cs: Move some LookupTypeReflection code
7416 to namespace.cs, to have cleaner code. Added some methods
7417 to help us keep track of the extern aliased references.
7418 * driver.cs: Add suport for extern alias assemblies on command
7419 line and check for their warnings/errors. Also keep track of the
7420 extern aliased assemblies.
7421 * namespace.cs: Move the global functionality of Namespace
7422 to GlobalRootNamespace/RootNamespace. Now the global namespace
7423 is GlobalRootNamespace.Globa. Also the code moved from
7424 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
7425 Finally added LocalAliasEntry (AliasEntry before) and
7426 ExternAliasEntry, to handle alias statements.
7427 * cs-parser.jay: Add support in the grammar for extern alias
7429 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
7430 Update callings to Namespace (now in GlobalRootNamespace).
7432 2005-10-18 Raja R Harinath <rharinath@novell.com>
7435 * class.cs (TypeContainer.DefineType): Move updating of
7436 topological sort earlier in the code.
7437 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
7439 2005-10-18 Marek Safar <marek.safar@seznam.cz>
7442 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
7444 * constant.cs (Constant.TryReduce): Moved from Cast class.
7445 (Reduce): Made little bit more OO and fixed missing conversions.
7447 * ecore.cs (Reduce): Implemented.
7448 (Binary.EnumLiftUp): New method to upgrade values to enum values.
7450 * literal.cs (Reduce): Implemented.
7452 * class.cs: Reverted Miguel's wrong commit.
7454 2005-10-14 Miguel de Icaza <miguel@novell.com>
7456 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7458 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7460 * cs-parser.jay, expression.cs : CS0214 was missing error location
7461 for constants. Fixed bug #76404.
7463 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7466 * convert.cs (ExplicitConversionCore): Fixed object->enum
7469 2005-10-10 Raja R Harinath <rharinath@novell.com>
7471 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7473 (PropertyExpr.EmitCall): Likewise.
7474 * expression.cs (Invocation.EmitArguments): Handle case where
7476 (Invocation.EmitCall): Avoid allocating temporary variable if
7477 there are no arguments.
7479 2005-10-07 Raja R Harinath <rharinath@novell.com>
7482 * convert.cs (ImplicitConversionStandard): Move conversion of
7483 void* to arbitrary pointer types ...
7484 (ExplicitConversionStandard): .. here.
7485 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7486 error to always print typenames.
7488 2005-10-07 Raja R Harinath <rharinath@novell.com>
7490 * convert.cs (GetConversionOperator): Rename from
7491 GetConversionOperators. Move operator selection code from ...
7492 (UserDefinedConversion): ... here.
7494 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7496 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7499 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7501 * assign.cs (Assign.DoResolve): Error method changed.
7503 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7505 * const.cs (ResolveValue): Reset in_transit immediately.
7507 * constant.cs: Error method changed.
7509 * convert.cs: Removed useless location parameter.
7510 (ExplicitNumericConversion): Don't do double enum check.
7511 (ExplicitConversionCore): Renamed from ExplicitConversion.
7512 (ExplicitUnsafe): Extracted from ExplicitConversion.
7513 (ExplicitConversion): Uses for error reporting.
7515 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7517 (ResolveBoolean): Uses common error method.
7518 (CastToDecimal): Get rid of ec.
7519 (CastFromDecimal): Optimized.
7520 (ConvCast): Get rid of ec.
7522 * enum.cs (ResolveValue): Reset in_transit immediately.
7523 (Emit): Return after first error.
7525 * expression.cs: Convert changes.
7527 * literal.cs: Error method changed.
7529 * statement.cs: Error method changed.
7531 2005-10-03 Raja R Harinath <rharinath@novell.com>
7533 * support.cs (SeekableStreamReader.Position): Don't error out when
7534 the requested position is just beyond the end of the current
7537 2005-09-28 Raja R Harinath <rharinath@novell.com>
7539 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7540 try to keep in sync with the byte count of the underlying Stream.
7541 However, this limits us to a window size of 2048 characters: i.e.,
7542 the maximum lookahead of our lexer/parser can be 2048 characters.
7544 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7547 * driver.cs: Fix compilation files with full root path.
7549 2005-09-25 Miguel de Icaza <miguel@novell.com>
7551 * report.cs (SymbolRelatedToPreviousError): Format the output so
7552 it does not use an open parenthesis that is never closed.
7554 * driver.cs: Follow coding guidelines
7556 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7559 * const.cs (Const.ResolveValue): Check for assigning non-null
7560 value to reference type.
7562 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7564 * anonymous.cs: Implemented ExprClassName.
7566 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7569 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7572 * class.cs (StaticClass.DefineContainerMembers): Report protected
7575 * codegen.cs: if(ed) PRODUCTION.
7577 * convert.cs (Error_CannotImplicitConversion): Better error
7580 * cs-parser.jay: More error checks.
7582 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
7584 * driver.cs (CSCParseOption): Enabled wrong option check.
7586 * ecore.cs (Expression.ExprClassName): Turned to property.
7587 (MemberExpr.CheckIntermediateModification): For checking boxed
7588 value types modification.
7590 * statement.cs (Fixed.Resolve): Expression type must be
7591 convertible to fixed type.
7592 (CollectionForeach.GetEnumeratorFilter,TryType):
7593 Small refactoring for easier error checking.
7595 2005-09-26 Marek Safar <marek.safar@seznam.cz>
7597 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
7600 * class.cs (GeneratedBaseInitializer): New class for customization
7601 compiler generated initializers.
7602 (MemberBase.DoDefine): Check Obsolete attribute here.
7603 (FieldMember.DoDefine): Ditto.
7605 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
7608 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
7609 (MemberCore.GetObsoleteAttribute): Removed argument.
7610 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
7611 (MemberCore.CheckObsoleteType): New helper.
7615 * statement.cs: Updates after MemberCore changes.
7617 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
7618 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
7620 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
7621 obsolete attribute for compiler construct.
7622 (As.DoResolve): Cache result.
7624 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
7626 2005-09-26 Raja R Harinath <rharinath@novell.com>
7629 * expression.cs (This.VerifyFixed): In a value type T, the type of
7630 'this' is T&, iow, 'this' is either an out or ref parameter. In a
7631 value type R, 'this' is treated as a value parameter.
7633 2005-09-22 Miguel de Icaza <miguel@novell.com>
7635 * statement.cs (Lock): Use the TemporaryVariable class instead of
7636 manually using local variables as those do not work when variables
7639 * ecore.cs: Moved the TemporaryVariable class from being a nested
7640 class inside Foreach to be a public class that can be employed in
7643 2005-09-19 Marek Safar <marek.safar@seznam.cz>
7645 * cs-parser.jay: interface_accessors replaced by
7646 accessor_declarations.
7648 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
7651 * statement.cs (GotoCase.Resolve): Convert null constant to
7653 (SwitchLabel.ResolveAndReduce): Ditto.
7654 (SwitchLabel.NullStringCase): Custom null stamp.
7655 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
7657 typemanager.cs (CSharpSignature): Don't skip first argument
7660 2005-09-18 Miguel de Icaza <miguel@novell.com>
7662 * driver.cs: Set InEmacs based on the environment variable EMACS.
7664 * location.cs (InEmacs): in this mode, do not report column
7665 location as it confuses Emacs.
7667 2005-09-16 Marek Safar <marek.safar@seznam.cz>
7669 * cfold.cs, constant.cs, convert.cs, ecore.cs,
7670 expression.cs, iterators.cs, literal.cs: Store constants and
7673 * class.cs (MemberBase.ShortName): Pass location.
7675 * cs-parser.jay: Some location fixes.
7677 * ecore.cs (Expression.Location): Made virtual.
7679 2005-09-05 Miguel de Icaza <miguel@novell.com>
7681 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
7682 if the underlying types are the same, otherwise we need to produce
7683 code that will do the proper cast.
7685 This was exposed by Marek's constant rewrite which produced
7686 invalid code for the call site:
7689 void Method (X v) {}
7693 This fixes test-49.cs
7695 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
7697 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
7698 Type/Object should be allowed as well. Fixed bug #75968.
7700 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
7702 * expression.cs : (Binary.DoResolve): when one is enum constant and
7703 another is constant 0, then return enum one *as enum type*.
7706 2005-09-02 Raja R Harinath <rharinath@novell.com>
7708 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
7712 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
7713 flow-branching for LocalVariableReferences in case we were invoked
7714 from a MemberAccess.
7715 * expression.cs (LocalVariableReference.VerifyAssigned): New.
7717 (LocalVariableReference.DoResolveBase): ... this.
7718 (MemberAccess.Resolve): Do the check that was disabled during
7721 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
7724 (PartialContainer.Create): check abstract/sealed/static strictly
7725 but abstract/sealed can exist only at one side. Fixed bug #75883.
7727 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
7730 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
7731 specified, don't default to UnmanagedType.I4.
7733 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
7735 * expression.cs : conditional operator should check possibly
7736 incorrect assign expression. Fixed bug #75946.
7738 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
7740 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
7741 Reverting the change. gmcs is much complex than mcs on this matter.
7743 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
7745 * cs-tokenizer.cs : To read another token ahead of the actual
7746 consumption, use new SavedToken and cache token instead of moving
7747 back the stream with SeekableStreamReader (it seemed problematic).
7749 driver.cs : Thus use StreamReader directly.
7750 * support.cs : Thus removed SeekableStreamReader.
7752 2005-08-30 Raja R Harinath <rharinath@novell.com>
7755 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
7756 (ScopeInfo.EmitScopeType): Use it to construct field names from
7757 names of captured locals.
7760 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
7761 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
7762 Pass 'target_type' to BoxedCast. Don't default to 'object'.
7763 (ExplicitConversion): Remove enum cases already handled by
7764 implicit conversion. Move implicit conversion check to the beginning.
7765 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
7766 * expression.cs (ArrayCreation.EmitDynamicInitializers):
7767 Don't treat System.Enum as a struct.
7769 2005-08-30 Jb Evain <jbevain@gmail.com>
7771 * attribute.cs: handles as expression in parameters.
7773 2005-08-30 Raja R Harinath <rharinath@novell.com>
7776 * class.cs (TypeContainer.VerifyClsName): Don't use a
7777 PartialContainer when verifying CLS compliance.
7778 (AbstractPropertyEventMethod): Set Parent here, ...
7779 (PropertyMethod): ... not here.
7781 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
7783 * attribute.cs : escaped attribute name should not be allowed to be
7784 resolved (e.g. @class as classAttribute). Fixed bug #75930.
7786 2005-08-29 Raja R Harinath <rharinath@novell.com>
7789 * convert.cs (ImplicitStandardConversionExists): Allow zero also
7790 when converting a long constant to unsigned long.
7791 * expression.cs (Invocation.OverloadResolve): Add sanity check to
7792 detect where IsApplicable and VerifyArgumentsCompat disagree.
7794 2005-08-29 Raja R Harinath <rharinath@novell.com>
7795 and Carlos Alberto Cortez <carlos@unixmexico.org>
7798 * class.cs (TypeContainer.CanElideInitializer): New helper.
7799 (TypeContainer.EmitFieldInitializers): Use it to determine if we
7800 can safely emitting the initializer of a field.
7802 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7804 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
7805 allowed inside a switch (without loop). Fixed bug #75433.
7807 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
7809 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
7810 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
7812 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7814 * driver.cs : kinda reverting the default encoding changes (not exact
7815 revert since I noticed that "codepage:reset" might not work fine).
7817 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7819 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
7820 Location. Now getter and setter store location correctly.
7821 (errors/cs0111-12.cs now reports the expected location.)
7823 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7825 * driver.cs : Use default encoding on the environment.
7826 Removed (now that) extra parameter for SeekableStreamReader.
7827 * support.cs : (SeekableStreamReader) third .ctor() argument for
7828 StreamReader is not required (always true). preamble size could
7829 be acquired in simpler and safe way.
7831 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
7833 * cs-parser.jay: report CS0642 at warning level 3
7834 and report CS0642 for an if else statement also
7835 fixes bug #74745. Patch by John Luke (and a bit
7837 Removed extra CS0642 warning check for "while",
7839 * statement.cs: In Block.Resolve(), CS0642 check
7840 is reimplemented to check a sequence of an empty
7841 statement and a block.
7843 Both fix bug #66777.
7845 2005-08-24 Marek Safar <marek.safar@seznam.cz>
7847 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
7848 detection until I fix it.
7850 * cs-tokenizer.cs: Changed error message.
7852 * cs-parser.jay: Fixed 2 error locations.
7854 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
7855 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
7858 * enum.cs (GetSignatureForError): Fixed.
7860 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
7864 * typemanager.cs (RegisterProperty): Removed.
7866 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
7868 2005-08-24 Raja R Harinath <rharinath@novell.com>
7871 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
7872 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
7874 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7876 * expression.cs : tiny fix is required for not warning positive ulong.
7879 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7881 * expression.cs : add CS0652 check for constant and integral
7882 expression. Fixed bug #53974.
7884 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7886 * expression.cs : in DoNumericPromotions(), check if there is implicit
7887 conversion overload for string (to check CS0034). Fixed bug #52492.
7889 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7891 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
7893 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7895 * ecore.cs : report location when it is *not* Null.
7897 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7903 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
7904 correctly. Fixed bug #75721.
7906 2005-08-23 Raja R Harinath <rharinath@novell.com>
7908 * support.cs (SeekableStreamReader.Position): Avoid an expensive
7909 loop that performs 'min (pos, char_count)'.
7912 * expression.cs (Unary.ResolveOperator): Don't discard implicit
7913 converted value in Operator.OnesComplement.
7915 2005-08-22 Ben Maurer <bmaurer@ximian.com>
7917 * anonymous.cs: If the anon method is pulled into a helper class,
7918 it needs to be `internal' not `private'. Fixes runtime behavior on
7921 2005-08-20 Martin Baulig <martin@ximian.com>
7923 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7924 scope if we don't already have it.
7926 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7927 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
7930 2005-08-17 Marek Safar <marek.safar@seznam.cz>
7933 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
7936 2005-08-16 Marek Safar <marek.safar@seznam.cz>
7938 The big constants rewrite
7939 Fix #75746, #75685 and more
7940 As a side effect saved 1MB for MWF ;-)
7942 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
7943 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
7944 enum based for corlib compilation.
7946 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
7949 * class.cs (FixedField.Define): Use ResolveAsConstant.
7951 * const.cs (IConstant): Interface constants and enums.
7952 (Const.ResolveValue): New method for constant resolvning.
7953 (ExternalConstant): Constants from imported assemblies.
7955 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
7956 conversion; like enums.
7957 (Constant.ToType): Converts this constant to different type.
7958 (Constant.Increment): Adds 1.
7960 * convert.cs (ImplicitConversionRequired): Simplified.
7962 * cs-parser.jay: Create EnumMember directly.
7964 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
7966 * doc.cs (GenerateEnumDocComment): Removed.
7968 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
7969 (ConvertIntLiteral): Removed.
7970 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
7972 * enum.cs (EnumMember): Implement IConstant.
7973 (Enum.IsValidEnumConstant): Removed.
7974 (Enum.GetNextDefaultValue): Removed.
7975 (Enum.FindMembers): Updated.
7976 (Enum.GenerateDocComment): Iterate enum members.
7978 * expression.cs (Cast.TryReduce): Handle enums correctly.
7979 (New.Constantify): Made public.
7980 (MemberAccess.DoResolve): Removed contant specific if(s).
7982 * literal.cs (NullLiteral): Implement new abstract methods.
7984 * statement.cs (GotoCase.Resolve): Use new constant methods.
7985 (SwitchLabel.ResolveAndReduce): Use new constant methods.
7987 * typemanager.cs (LookupEnum): Removed.
7988 (IsEnumType): Fixed to work with corlib.
7989 (RegisterConstant): Removed.
7990 (LookupConstant): Removed.
7991 (GetConstant): Changed to work with IConstant.
7993 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
7995 * location.cs : Fixed overflown (>255) column number.
7997 2005-08-03 Raja R Harinath <rharinath@novell.com>
7999 First cut of the qualified-alias-member feature.
8000 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
8002 * cs-parser.jay (DOUBLE_COLON): New token.
8003 (namespace_or_type_name): Add rule for recognizing
8004 qualified-alias-members.
8005 (primary_expression): Likewise.
8006 (element_access): Allow QualifiedAliasMember as a possible
8007 type-bearing expression.
8008 (local_variable_type, local_variable_pointer_type): Likewise.
8009 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
8010 aliases in the current and enclosing namespace declarations.
8011 (NamespaceEntry.UsingAlias): Add CS0440 warning.
8012 * decl.cs (MemberName.is_double_colon): New.
8013 (MemberName.MemberName): Add new constructor for alias-member.
8014 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
8015 * expression.cs (QualifiedAliasMember): New expression type.
8017 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8019 * location.cs : it borked when no argument was specified.
8021 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8023 * location.cs : tiny ToString() format fix.
8025 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8027 * statement.cs : oops, it was missing.
8029 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8031 A set of fixes for precise line/column location.
8034 "token" field now holds a file/line "delta", a line number offset
8035 from the segment, and a column number. See also:
8036 http://lists.ximian.com/pipermail/mono-devel-list/2004-
8037 December/009508.html
8038 Removed static IsNull. Use instance IsNull property instead.
8040 For some tokens it stores Location. For Identifier it stores
8041 LocatedToken which is a pair of string name and location.
8042 Column numbers are adjusted only at getChar().
8044 Use Location.ToString() for reporting (it now contains column).
8046 Largely modified to use LocatedToken instead of
8047 string (IDENTIFIER), and to acquire Location from some tokens.
8048 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
8049 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
8051 Now MemberName holds Location. DeclSpace.ctor() receives Location
8052 as a parameter. Removed extra parameters to all derived classes.
8053 Replaced Location.IsNull() with instance property.
8054 * assign.cs, expression.cs :
8055 Added .ctor() overload that omits Location.
8057 Added "nameEscaped" flag that indicates the identifier was escaped
8058 in the source file. This fixes bug #57047.
8060 2005-08-02 Marek Safar <marek.safar@seznam.cz>
8062 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
8063 New method, looking for lo-case imported cls type.
8065 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
8068 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
8070 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
8072 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
8074 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
8076 Optimized to save 3.5 MB for SWF compilation.
8078 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8080 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
8081 (PartialContainer.Create): Moved logic AddToContainer.
8082 (PartialContainer.MarkForDuplicationCheck): Shares name.
8084 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
8087 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
8089 (Namespace.GetSignatureForError): New method.
8091 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
8092 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
8094 2005-08-01 Raja R Harinath <rharinath@novell.com>
8097 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
8098 member lookup rather than qualifier_type, since qualifier_type can
8101 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8103 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
8106 2005-07-31 Miguel de Icaza <miguel@novell.com>
8108 * statement.cs: Copy the local exception into the exception
8109 captured local. Fixes 75674
8111 2005-07-31 Raja R Harinath <harinath@gmail.com>
8114 * expression.cs (Invocation.OverloadResolve): Don't report error
8115 CS1501 if error CS1502 has been reported.
8116 (New.DoResolve): Delegate CS1501 reporting to
8117 Invocation.OverloadResolve.
8120 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
8121 invariant-meaning-in-block property in an enclosing block if
8124 2005-07-29 Marek Safar <marek.safar@seznam.cz>
8126 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
8127 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
8128 (Switch.CheckSwitch): Just save 50kb for SWF.
8130 2005-07-27 Martin Baulig <martin@ximian.com>
8132 * anonymous.cs (CaptureContext.AddField): Added
8133 `AnonymousContainer am' argument; compute its toplevel scope if
8134 it's not already computed. Fixes #75649.
8136 2005-07-26 Raja R Harinath <rharinath@novell.com>
8139 * class.cs (Constructor.Emit): Reset block to null if the block
8142 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8144 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
8146 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8148 * class.cs (MethodData.Define): Check whether accessor implementing
8149 interface is public.
8151 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
8153 2005-07-22 Marek Safar <marek.safar@seznam.cz>
8156 * namespace.cs (LookupType): Moved same type check to...
8158 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
8161 2005-07-21 Raja R Harinath <rharinath@novell.com>
8163 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
8164 already found a typebuilder.
8165 * class.cs (MethodCore.IsDuplicateImplementation): Compare
8166 MemberNames, not strings.
8168 * const.cs (Error_ExpressionMustBeConst):
8169 Rename from Error_EpressionMustBeConst.
8170 * const.cs, class.cs, statement.cd: Update.
8172 2005-07-21 Marek Safar <marek.safar@seznam.cz>
8176 * const.cs (Const.LookupConstantValue): Report missing contant expression
8178 (Error_EpressionMustBeConstant): Only one error method.
8180 * class.cs, statement.c: Updated.
8182 2005-07-20 Raja R Harinath <rharinath@novell.com>
8184 * statement.cs (Block.Flags): Add back HasVarargs.
8185 (Block.flags): Make protected.
8186 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
8188 * typemanager.cs (types, typecontainers, user_types): Remove.
8189 (UserTypes, TypeContainers): Likewise.
8190 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
8191 (CleanUp, Reset): Update.
8192 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
8193 (GetNestedType): Use Type.GetNestedType.
8194 (CoreLookupType): Take two arguments, the namespace and the
8195 basename of the type. Update to use the Namespace.Lookup
8197 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
8198 (RealMemberLookup): Use IsNestedChildOf instead of playing with
8199 string concatenation and substring matches.
8200 * class.cs, enum.cs, delegate.cs: Update to changes.
8202 2005-07-20 Marek Safar <marek.safar@seznam.cz>
8204 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
8205 Expression and made virtual.
8207 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
8208 (ImplicitStandardConversionExists): Fixed `byte' typo ?
8210 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
8212 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
8215 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
8218 2005-07-18 Marek Safar <marek.safar@seznam.cz>
8221 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
8222 AssemblyCultureAttribute is not used on executable.
8225 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
8227 2005-07-16 Raja R Harinath <rharinath@novell.com>
8230 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
8231 New. Reports CS0252/CS0253.
8232 Mostly taken from preliminary patch by Duncak Mak.
8233 (Binary.DoResolveOperator): Store results of operator lookup.
8234 Use them to detect if we need to warn about unintended reference
8237 2005-07-15 Raja R Harinath <rharinath@novell.com>
8240 * namespace.cs (Namespace.Lookup): Add back location parameter.
8241 (Namespace.LookupType): Add CS0436 report. Add location parameter.
8242 * delegate.cs, ecore.cs, expression.cs: Update to changes.
8244 * codegen.cs (EmitContext.DeclSpace): Make readonly.
8245 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
8246 (Namespace.LookupType): ... this.
8247 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
8249 * typemanager.cs (LookupTypeReflection): Remove buggy code that
8250 purported to handle pointers.
8251 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
8254 2005-07-15 Marek Safar <marek.safar@seznam.cz>
8256 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
8259 2005-07-15 Raja R Harinath <rharinath@novell.com>
8261 * namespace.cs (Namespace.Lookup): Drop location parameter.
8262 (NamespaceEntry.LookupAlias): Remove. Merge into ...
8263 (NamespaceEntry.Lookup): ... this.
8264 (NamespaceEntry.Error_AmbiguousTypeReference):
8265 Move here from DeclSpace.
8266 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
8268 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
8269 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
8270 Move to NamespaceEntry.
8271 * delegate.cs, expression.cs: Update to changes.
8273 2005-07-14 Marek Safar <marek.safar@seznam.cz>
8275 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
8276 CheckAttributeType and refactored.
8277 (Attribute.ResolvePossibleAttributeType): Changed to reuse
8278 ResolveAsTypeTerminal error handling.
8279 (ResolveAsTypeTerminal): Introduced because of global attributes extra
8281 (GetSignatureForError): Print errors in same way.
8284 * codegen.cs: Reflect attribute GetSignatureForError change.
8287 * expression.cs: Add silent parameter to ResolveAsTypeStep.
8289 * namespace.cs (UsingEntry): Refactored to make fields private.
8292 statement.cs: Error_UnexpectedKind has extra parameter.
8294 2005-07-14 Raja R Harinath <rharinath@novell.com>
8296 * ecore.cs (IAlias): Remove.
8297 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
8298 that implement the interface.
8299 * namespace.cs (Namespace): Likewise.
8300 (Namespace.declspaces): Renamed from 'defined_names'.
8301 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
8302 DeclSpace instead of an IAlias.
8303 * tree.cs (Tree.AddDecl): Update.
8305 2005-07-12 Raja R Harinath <rharinath@novell.com>
8307 * statement.cs (Block.Flags); Remove HasVarargs.
8308 (Block.HasVarargs): Move to ToplevelBlock.
8309 (Block.ThisVariable, Block.AddThisVariable): Likewise.
8310 (Block.Variables): Make protected. Initialize variable hashtable
8312 (Block.AddVariable): Update.
8313 (Block.Resolve): Update to changes.
8314 (ToplevelBlock.HasVarargs): New boolean.
8315 (ToplevelBlock.ThisVariable): Move here from Block.
8316 (ToplevelBlock.AddThisVariable): Likewise.
8317 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
8318 * expression.cs (This.ResolveBase): Update to changes.
8319 (ArglistAccess.DoResolve): Likewise.
8321 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8324 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
8326 * class.cs (TypeContainer.VerifyMembers): Distinguish between
8327 not used and not used & assigned.
8328 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
8330 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8333 * expression.cs (Is.DoResolve): null is never provided type.
8335 2005-07-08 Marek Safar <marek.safar@seznam.cz>
8338 * cs-parser.jay: Less strict event error rule to catch more errors.
8340 2005-07-08 Martin Baulig <martin@ximian.com>
8342 Fix test-iter-10.cs - distinguish whether we `yield' in a property
8343 gettter (allowed) or setter (not allowed).
8345 * class.cs (Accessor): Implement IIteratorContainer.
8346 (Accessor.Yields): New public field.
8347 (PropertyBase.PropertyMethod.Define): Handle iterators on a
8351 (get_accessor_declaration, set_accessor_declaration): Set the
8352 `yields' flag on the accessor, not the property.
8353 (property_declaration): Do the iterators check on a per-accessor
8354 basis and not for the whole property.
8356 2005-07-08 Martin Baulig <martin@ximian.com>
8358 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
8359 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
8361 2005-07-07 Marek Safar <marek.safar@seznam.cz>
8364 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
8365 (ExtractSecurityPermissionSet): Cope with self referencing security
8366 attributes properly.
8368 * driver.cs (SetOutputFile): Made public property OutputFile.
8370 2005-07-07 Raja R Harinath <rharinath@novell.com>
8373 * class.cs (TypeContainer.first_nonstatic_field): Rename from
8374 has_nonstatic_fields. Make into a FieldBase pointer.
8375 (TypeContainer.AddField): Add CS0282 check.
8376 (TypeContainer.EmitType): Update.
8378 2005-07-06 Miguel de Icaza <miguel@novell.com>
8380 * cs-tokenizer.cs (consume_identifier): Do not create strings to
8381 compare if they start with __.
8383 2005-07-06 Raja R Harinath <rharinath@novell.com>
8385 * statement.cs (Switch.SwitchGoverningType): Only look at
8386 UserCasts that don't need implicit standard conversions to one of
8387 the allowed switch types (Fixes test-322.cs).
8388 (LocalInfo.Resolve): Re-enable sanity-test.
8390 2005-07-06 Marek Safar <marek.safar@seznam.cz>
8392 * cs-tokenizer.cs (consume_identifier): Detect double undescores
8394 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
8396 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
8398 2005-07-06 Raja R Harinath <rharinath@novell.com>
8401 * ecore.cs (SimpleName.GetSignatureForError): Add.
8402 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
8403 (MemberAccess.GetSignatureForError): Add.
8405 2005-07-05 Marek Safar <marek.safar@seznam.cz>
8407 The big error and warning messages review.
8437 * typemanager.cs: Updated.
8439 * class.cs: (MethodCore.SetYields): Moved here to share.
8440 (PropertyMethod.Define): Moved iterator setup here.
8442 * iterators.cs: Add orig_method to have full access to parent
8445 2005-07-05 Raja R Harinath <rharinath@novell.com>
8447 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
8448 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
8449 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
8450 variable of struct type.
8451 * expression.cs (Unary.ResolveOperator): Update to change.
8452 (Indirection.VerifyFixed): Likewise.
8453 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8454 (ParameterReference.VerifyFixed): Value parameters are fixed.
8455 (This.VerifyFixed): Treat 'this' as a value parameter.
8456 * statement.cs (LocalInfo.IsFixed): Remove.
8458 2005-07-01 Martin Baulig <martin@ximian.com>
8460 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8461 `ec.EmitThis ()' to get the correct scope.
8463 2005-07-01 Martin Baulig <martin@ximian.com>
8465 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8466 instance is a ParameterReference; fixes #75299.
8468 2005-07-01 Martin Baulig <martin@ximian.com>
8470 Reverted Marek's latest patch (r46725):
8471 - it contains structural changes which are neither mentioned in
8472 the ChangeLog nor explained anywhere; for example the additional
8473 argument of EmitContext's and Iterator's .ctor's and the
8474 TypeContainer.DefineMembers() change.
8475 - structural changes like this should go in in seperate patches
8476 and not be hidden in a huge patch which just seems to affect
8477 warnings and errors.
8478 a big and hard to understand patch.
8479 - it breaks iterators and causes regressions, for instance in
8482 2005-06-30 Raja R Harinath <rharinath@novell.com>
8485 * expression.cs (Indexers.map): Remove.
8486 (Indexers.Append): Filter out inaccessible setters and getters.
8487 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8490 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8492 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8493 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8494 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8495 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8497 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8500 * class.cs (FieldBase.GetInitializerExpression): One more field
8503 2005-06-28 Miguel de Icaza <miguel@novell.com>
8505 * pending.cs: Do not define a proxy if the base method is virtual,
8506 it will be picked up by the runtime (bug 75270).
8508 2005-06-08 Martin Baulig <martin@ximian.com>
8510 The big Iterators rewrite :-)
8512 * iterators.cs: Rewrite this to use the anonymous methods framework.
8514 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8515 before the TypeContainers; see 2test-21.cs.
8518 (TypeContainer.DefineType): Don't create a new EmitContext if we
8519 already have one (this only happens if we're an Iterator).
8520 (TypeContainer.Define): Also call Define() on all our iterators.
8521 (Method.CreateEmitContext): Added support for iterators.
8524 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8525 (AnonymousContainer.CreateMethodHost): Moved here from
8526 AnonymousMethod and made abstract.
8527 (AnonymousContainer.CreateScopeType): New abstract method.
8528 (AnonymousContainer.IsIterator): New public property.
8529 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8530 get the ScopeTypeBuilder rather than manually defining it here.
8531 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8534 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8535 before RootContext.DefineTypes().
8537 * codegen.cs (EmitContext.RemapToProxy): Removed.
8538 (EmitContext.CurrentAnonymousMethod): Changed type from
8539 AnonymousMethod -> AnonymousContainer.
8540 (EmitContext.ResolveTopBlock): Protect from being called twice.
8541 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8542 (EmitContext.EmitThis): Removed the iterators hacks; use the
8543 anonymous methods framework for that.
8546 (ToplevelBlock.Container): Make this a property, not a field.
8547 (ToplevelBlock.ReParent): New public method; move the
8548 ToplevelBlock into a new container.
8549 (Foreach.TemporaryVariable): Simplify.
8551 2005-06-05 Martin Baulig <martin@ximian.com>
8553 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8554 (Block.AddTemporaryVariable): New public method; creates a new
8555 `LocalInfo' for a temporary variable.
8556 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8558 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8559 non-iterator variables.
8561 2005-06-05 Martin Baulig <martin@ximian.com>
8563 * statement.cs (Foreach.TemporaryVariable): Create the
8564 LocalBuilder in the Emit phase and not in Resolve since in some
8565 situations, we don't have an ILGenerator during Resolve; see
8566 2test-19.cs for an example.
8568 2005-06-04 Martin Baulig <martin@ximian.com>
8570 **** Merged r45395 from GCS ****
8572 The big Foreach rewrite - Part II.
8574 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
8575 with `PropertyInfo ienumerator_getcurrent'.
8577 * codegen.cs (VariableStorage): Removed.
8580 (Foreach): Derive from Statement, not ExceptionStatement.
8581 (Foreach.CollectionForeach): New nested class. Moved all the code
8582 dealing with collection foreach here.
8583 (Foreach.ForeachHelperMethods): Removed.
8584 (Foreach.TemporaryVariable): Implement IMemoryLocation.
8586 2005-05-23 Martin Baulig <martin@ximian.com>
8588 * statement.cs (Try.DoResolve): Don't create a `finally' if we
8589 don't need to. Fix #75014.
8591 2005-05-20 Martin Baulig <martin@ximian.com>
8593 Merged r44808 from GMCS.
8595 * class.cs (TypeContainer.CircularDepException): Removed.
8596 (TypeContainer.DefineType): Removed the `InTransit' stuff.
8597 (TypeContainer.CheckRecursiveDefinition): Check for circular class
8598 (CS0146) and interface (CS0529) dependencies here.
8600 2005-06-21 Raja R Harinath <rharinath@novell.com>
8602 * expression.cs (Invocation.EmitCall): Fix initialization
8603 'this_call' to reflect current behaviour. Fix indentation.
8605 * convert.cs (FindMostEncompassedType): Add two trivial special
8606 cases (number_of_types == 0 || number_of_types == 1).
8607 (FindMostEncompasingType): Likewise.
8609 2005-06-17 Raja R Harinath <rharinath@novell.com>
8611 Some cleanups preparing for the fix of #75283.
8612 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
8614 (EventExpr.InstanceResolve): Likewise.
8615 (EventExpr.DoResolve): Remove redundant checks.
8617 2005-06-10 Duncan Mak <duncan@novell.com>
8619 * cs-tokenizer.cs (process_directives): New flag for controlling
8620 the processing of preprocessor directives.
8621 (x_token): After seeing a '#', return Token.NONE instead of going
8622 to handle_preprocessing_directive() when not processing
8623 directives. This avoids unnecessary processing during the token peek in
8628 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
8629 the existing error reporting methods instead of Report.Error.
8631 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
8632 after Raja's rewrite.
8634 2005-06-08 Miguel de Icaza <miguel@novell.com>
8636 * class.cs: Small fix.
8638 2005-06-08 Raja R Harinath <rharinath@novell.com>
8641 * class.cs (GetPartialBases): Fix return value check of
8644 2005-06-07 Raja R Harinath <rharinath@novell.com>
8646 Ensure that partial classes are registered in their enclosing
8647 namespace. Initial part of fix of #75160.
8648 * tree.cs (Tree.RecordDecl): Add new namespace argument.
8649 Register declspace with namespace here, not in
8650 DeclSpace.RecordDecl.
8651 * cs-parser.jay: Pass namespace to RecordDecl.
8652 * class.cs (PartialContainer.Create): Likewise.
8653 (ClassPart.DefineType): New sanity-check. Throws an exception if
8655 * decl.cs (Declspace.RecordDecl): Remove.
8656 * namespace.cs (NamespaceEntry.DefineName): Remove.
8658 2005-06-06 Marek Safar <marek.safar@seznam.cz>
8660 * rootcontext.cs: Reset TargetExt as well.
8662 2005-06-03 Raja R Harinath <rharinath@novell.com>
8664 * ecore.cs (Expression.Resolve): Emit CS0654 error when
8667 2005-06-02 Raja R Harinath <rharinath@novell.com>
8669 Fix #75080, cs0119.cs.
8670 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
8672 (Expression.Resolve): ... this. Use it. Remove bogus code
8673 allowing ExprClass.Type and ExprClass.Namespace for
8674 ResolveFlags.VariableOrValue.
8675 (Expression.Resolve) [1-argument variant]: Change default resolve
8676 flags based on language version.
8677 (Expression.Error_UnexpectedKind): Use a simple string array
8678 rather than an ArrayList.
8679 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
8681 (TypeOfVoid.DoResolve): Likewise.
8682 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
8683 flags argument -- it always has the same value.
8685 2005-05-31 Raja R Harinath <rharinath@novell.com>
8688 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
8689 Use it in the error message.
8690 * assign.cs, expression.cs, statement.cs: Update.
8692 2005-05-30 Raja R Harinath <rharinath@novell.com>
8695 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
8696 the "almostMatchedMember" case too.
8697 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
8698 that failed the accessibility checks to 'almost_match'.
8700 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
8702 * attribute.cs: Use internal MethodBuilder methods to set
8703 ExactSpelling and SetLastError on PInvoke methods, instead
8704 of passing them via charset. Fixes #75060.
8706 2005-05-27 Raja R Harinath <rharinath@novell.com>
8708 * parameter.cs (Parameter): Remove TODO comment.
8709 (Parameter.DefineParameter): Remove Location parameter.
8710 (Parameters.LabelParameters): Likewise.
8711 * class.cs (Constructor.Emit): Update to change.
8712 (MethodData.Emit): Likewise.
8713 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
8714 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
8716 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
8719 Removed Parameters.Location and added Parameter.Location instead.
8720 Removed Location parameter from Emit() and GetSignature().
8727 Modified all related calls.
8729 2005-05-26 Raja R Harinath <rharinath@novell.com>
8731 Improve user-defined conversion handling.
8732 * convert.cs (GetConversionOperators): Rewrite. Return only the
8733 applicable operators.
8734 (AddConversionOperators): New. Helper for GetConversionOperators.
8735 (FindMostEncompassedType, FindMostEncompassingType): Verify that
8736 there is only one most encompassed/encompassing type.
8737 (FindMostSpecificSource, FindMostSpecificTarget): Remove
8738 "applicable operator" handling.
8739 (UserConversion): Move cache here from GetConversionOperators.
8740 Directly cache the chosen operator, rather than the whole
8742 (ExplicitNumericConversion): Fix buggy implementation of Decimal
8743 case. Allow conversion of decimal to sbyte and byte too.
8744 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8745 New static methods. Used to avoid allocating EmptyExpressions in
8748 2005-05-24 Duncan Mak <duncan@novell.com>
8750 * ecore.cs (CastFromDecimal): New class for casting a decimal to
8751 another class, used in Convert.ExplicitNumericConversion.
8752 (CastToDecimal): New class, similar to above, but casts to
8753 System.Decimal, used in Convert.ImplicitNumericConversion and also
8754 in explicit convesion from double/float to decimal.
8756 * convert.cs (ImplicitNumericConversion): Handle implicit
8757 conversions to System.Decimal.
8758 (ExplicitNumericConversion): handle explicit conversions to
8763 2005-05-20 Miguel de Icaza <miguel@novell.com>
8765 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
8766 know the type at this stage, just break through. Fixes #75008
8768 2005-05-19 Martin Baulig <martin@ximian.com>
8771 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
8772 to disable error reporting.
8774 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
8775 here since we don't want to report an error; see the new test-336.cs.
8777 2005-05-19 Raja R Harinath <rharinath@novell.com>
8779 * statement.cs (ToplevelBlock.GetParameterReference)
8780 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
8781 Move here from class Block.
8782 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
8783 * expression.cs (ParameterReference.DoResolveBase): Likewise.
8785 2005-05-18 Martin Baulig <martin@ximian.com>
8790 (FlowBranching.Reachability): Add non-static public And() and Or()
8792 (FlowBranchingSwitch): New class; do the `break_origins' thing
8793 like in FlowBranchingLoop.
8794 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
8795 reachability, not just locals and parameters.
8796 (FlowBranching.MergeChild): Remove some of the hacks for loop and
8797 switch; MergeBreakOrigins() now takes care of that.
8799 2005-05-18 Martin Baulig <martin@ximian.com>
8801 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
8802 a loop and may leave it, reset the barrier; fixes #74974.
8804 2005-05-17 Marek Safar <marek.safar@seznam.cz>
8806 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
8809 * cs-parser.jay: Catch more lexical errors.
8811 * report.cs: Add one more Error method.
8814 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
8816 2005-05-17 Martin Baulig <martin@ximian.com>
8818 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
8821 2005-05-16 Raja R Harinath <rharinath@novell.com>
8823 Fix test-382.cs. Emit values of decimal constants.
8824 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
8826 (TypeContainer.AddField): ... this.
8827 (TypeContainer.EmitFieldInitializers): Allow the list of fields
8828 with initializers to include 'Const's.
8829 (ClassPart.RegisterFieldForInitialization): Forward to
8831 * const.cs (Const.Const): Pass initializer to base class.
8832 (Const.Define): In case of decimal constants, register them for
8833 initialization in a static constructor.
8835 2005-05-14 Martin Baulig <martin@ximian.com>
8837 * statement.cs (Block.Resolve): Correctly handle unreachable code;
8838 do not call ResolveUnreachable() on unreachable statements in
8839 here, see the comment in the source code.
8841 2005-05-13 Raja R Harinath <rharinath@novell.com>
8844 * expression.cs (BinaryResolveOperator): If one of the operands of
8845 an equality comparison is 'null' and the other is a pointer type,
8846 convert the null to a NullPointer.
8847 * convert.cs (ImplicitReferenceConversion): If the expression is a
8848 NullLiteral and the target type is a pointer type, return a
8849 NullPointer instead.
8850 (ImplicitConversionStandard): Likewise.
8852 2005-05-13 Marek Safar <marek.safar@seznam.cz>
8854 * cs-parser.jay: Set readonly context based on special constructs.
8856 * expression.cs (LocalVariableReference.DoResolveBase): Improved
8857 readonly variable error handling.
8859 * rootcontext.cs (EmitCode): Don't verify members when error
8862 * statement.cs (LocalInfo): Add reaodnly context information.
8863 (SetReadOnlyContext, GetReadOnlyContext): New methods.
8865 2005-05-13 Raja R Harinath <rharinath@novell.com>
8867 * statement.cs (Block.Resolve): Revert change below. Modify fix
8868 for #74041 to initialize 'resolved' to false only for explicit
8869 blocks. Fixes #74873.
8871 2005-05-12 Raja R Harinath <harinath@gmail.com>
8874 * typemanager.cs (unmanaged_enclosing_types): New.
8875 (IsUnmanagedType): Avoid infloops by using
8876 'unmanaged_enclosing_types' to talk with recursive invocations.
8878 2005-05-13 Martin Baulig <martin@ximian.com>
8880 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
8881 instance variable, not a local. Fix #74873.
8882 (Block.ResolveUnreachable): Set it to true here.
8884 2005-05-11 Duncan Mak <duncan@novell.com>
8886 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
8887 continuing to process for 'arg'.
8888 (handle_preprocessing_directive): Check the argument of the #endif
8889 directive and report error CS1025 if there are any trailing
8892 According to the C# spec, having even whitespace after the #endif
8893 directive is illegal; however, because we call arg.TrimEnd ()
8894 beforehand, we have the same behavior as csc, allowing whitespace
8895 after the directive.
8899 2005-05-11 Marek Safar <marek.safar@seznam.cz>
8903 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
8904 (Constructor.GetObsoleteAttribute): Implemented correctly.
8906 2005-05-10 Martin Baulig <martin@ximian.com>
8908 * support.cs (ReflectionParameters.ParameterModifier): Use
8909 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
8910 and `ParameterAttributes.In'. Fixes #74884.
8912 2005-05-10 Marek Safar <marek.safar@seznam.cz>
8914 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
8916 * expression.cs (Argument.GetParameterModifier): Turned to property.
8917 (Invocation.Error_InvalidArguments): Add more descriptive errors.
8919 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
8922 2005-05-09 Raja R Harinath <rharinath@novell.com>
8925 * decl.cs (MemberCache.AddMethods): Register override methods,
8926 rather than non-override methods.
8927 * typemanager.cs (RegisterOverride): New.
8928 (IsOverride): Update.
8930 2005-05-09 Marek Safar <marek.safar@seznam.cz>
8934 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
8935 recursive declaration.
8937 * statement.cs (Block.ResolveMeta): Report any error in resolving.
8939 2005-05-06 Marek Safar <marek.safar@seznam.cz>
8941 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
8943 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
8945 2005-05-05 Raja R Harinath <rharinath@novell.com>
8948 * decl.cs (DeclSpace.FamilyAccessible):
8949 Use TypeManager.IsNestedFamilyAccessible.
8951 Fix reopened #64812.
8952 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
8955 2005-05-04 Raja R Harinath <rharinath@novell.com>
8956 Abin Thomas <projectmonokochi@rediffmail.com>
8957 Anoob V E <projectmonokochi@rediffmail.com>
8958 Harilal P R <projectmonokochi@rediffmail.com>
8961 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
8962 allow access to all static members.
8964 2005-05-04 Martin Baulig <martin@ximian.com>
8966 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
8968 2005-05-04 Martin Baulig <martin@ximian.com>
8972 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
8973 section at the end; make things work if `default' is not the last
8976 2005-05-04 Martin Baulig <martin@ximian.com>
8980 * statement.cs (Switch): Replaced the `got_default' field with a
8981 `default_section' one.
8982 (Switch.CheckSwitch): Set `default_section' here.
8983 (Switch.Resolve): If we're a constant switch and the constant is
8984 not found, use the default section.
8986 2005-05-03 Martin Baulig <martin@ximian.com>
8988 * expression.cs (ArrayAccess.EmitGetLength): New public method.
8990 * statement.cs (Foreach.ArrayForeach): New nested class.
8991 (Foreach.TemporaryVariable): New nested class.
8992 (Foreach.EmitArrayForeach): Removed; this is now in the new
8995 2005-05-03 Raja R Harinath <rharinath@novell.com>
8997 * pending.cs (BaseImplements): Move the #74773 fix here. This is
8999 (VerifyPendingMethods): Revert change below.
9001 * typemanager.cs (IsOverride, RegisterNonOverride): New.
9002 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
9003 that used to trigger warning -28. Remove warning -28.
9004 * expression.cs (Invocation.OverloadResolve): Use
9005 TypeManager.IsOverride to distinguish override methods.
9008 * pending.cs (VerifyPendingMethods): If a base type implements the
9009 requested interface, don't bother checking individual methods of
9010 the base type. As a side-effect, this prevents the creation of
9011 unnecessary proxies.
9013 2005-05-02 Martin Baulig <martin@ximian.com>
9017 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9018 Also `And' the locals if the old vector is null.
9019 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
9020 null; in this case we basically reset all the variables.
9022 2005-05-02 Martin Baulig <martin@ximian.com>
9026 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
9027 Added `FlowBranching branching' argument; always `and' the
9028 variables instead of `or'ing them unless we're an infinite loop.
9030 * statement.cs (While.Resolve): Create a new sibling unless we're
9033 2005-05-02 Martin Baulig <martin@ximian.com>
9037 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
9038 arguments; use it instead of creating a new TopLevelBlock.
9039 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
9040 our ConstructorInitializer.
9043 (TopLevelBlock.TopLevelBranching): New public property.
9044 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
9045 and create our `TopLevelBranching'.
9047 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
9048 anonymous method host, use `block.TopLevelBranching' rather than
9049 creating a new branching.
9051 2005-04-20 Miguel de Icaza <miguel@novell.com>
9053 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
9054 a ScopeInfo, if any of the current children is a child of the new
9055 entry, move those children there.
9057 2005-04-30 Martin Baulig <martin@ximian.com>
9059 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
9060 at the beginning of a SwitchSection. Fix #73335.
9062 2005-04-27 Marek Safar <marek.safar@seznam.cz>
9065 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
9067 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
9068 (FieldExpr.DoResolve): Obsolete members are ignored for field
9071 2005-04-26 Marek Safar <marek.safar@seznam.cz>
9073 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
9074 of arrays detection.
9076 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
9078 (Field.VerifyClsCompliance): Volatile fields are not compliant.
9080 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
9083 2005-04-25 Ben Maurer <bmaurer@ximian.com>
9085 * cs-parser.jay: Use the prefered version of -unsafe in error
9088 2005-04-22 Marek Safar <marek.safar@seznam.cz>
9090 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
9093 2005-04-20 John Luke <john.luke@gmail.com>
9095 * driver.cs: fix typo in error message, --outout to --output
9097 2005-04-20 Marek Safar <marek.safar@seznam.cz>
9099 * codegen.cs (InRefOutArgumentResolving): New field.
9101 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
9102 fields outside contructor.
9104 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
9106 2005-04-19 Miguel de Icaza <miguel@novell.com>
9108 * anonymous.cs (CaptureContext.EmitParameterInstance): The
9109 parameter code was not completed ever, so it was not as up-to-date
9110 as local variables. Must finish it.
9112 The bug fix was to compare the Toplevel of the block, not the
9113 current block. Thanks for Ben for pointing this out.
9115 2005-04-19 Raja R Harinath <rharinath@novell.com>
9117 * decl.cs (AddMethods): Use the declaring type of the problem
9118 method to determine if we want to squash a warning.
9120 2005-04-19 Marek Safar <marek.safar@seznam.cz>
9122 * attribute.cs: Removed debug output.
9124 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
9126 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
9129 2005-04-18 Raja R Harinath <rharinath@novell.com>
9132 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
9133 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
9134 all null comparisons against reference types.
9136 2005-04-18 Marek Safar <marek.safar@seznam.cz>
9139 * class.cs (TypeContainer.CircularDepException) New nested
9141 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
9142 (TypeContainer.DefineType): Removed error, reset InTransit before
9144 (Class.DefineType): Throw exception when is in Transit.
9145 Catch exception and report error.
9146 (Struct.DefineType): Throw exception when is in Transit.
9147 Catch exception and report error.
9148 (Interface.DefineType): Throw exception when is in Transit.
9149 Catch exception and report error.
9151 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
9152 handle nested exception handlers.
9154 * flowanalysis.cs (InTryWithCatch): New method, search for try with
9157 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
9158 InFinally and InCatch storage.
9160 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
9161 (Catch.Resolve): Set and Restore ec.InCatch.
9162 (Try.Resolve): Set and Restore ec.InFinally.
9163 (Try.HasCatch): True when try has catch.
9165 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
9167 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
9168 for the same event member, so exclude such cases from warning 419.
9171 2005-04-16 Miguel de Icaza <miguel@novell.com>
9173 * expression.cs (Binary.ResolveOperator): Apply patch from John
9174 Luke to fix bug 59864: operators &, | and ^ on enumerations
9175 require that the same enum type on both sides.
9177 * driver.cs: Add warnings to old flag usage, this is to assist
9178 people who produce Makefiles and hope that the Makefiles will be
9181 * class.cs (TypeContainer.EmitType): Moved the definition of the
9182 special $PRIVATE$ field from the resolve phase to the Emit phase.
9183 During resolve we do not know if we are a struct with
9184 HasExplicitLayout, we know this only after the attributes for the
9187 Set the FieldOffset to zero on the dummy field that we create for
9188 the class. Fixes 74590.
9190 2005-04-16 Raja R Harinath <rharinath@novell.com>
9193 * ecore.cs (PropertyExpr.resolved): New.
9194 (DoResolve): Use it to handle a case of double resolution here.
9195 Handle a case of identical-name-and-type-name.
9196 * expression.cs (ArrayCreation.CheckIndices): Avoid double
9197 resolution by storing the results of expression resolution back
9198 into the "probes" array.
9200 2005-04-15 Raja R Harinath <rharinath@novell.com>
9202 Fix cs0208-7.cs and cs0208-8.cs.
9203 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
9204 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
9205 error reporting to point out the reason a struct is not unmanaged.
9207 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9209 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
9210 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
9212 2005-04-13 Raja R Harinath <rharinath@novell.com>
9215 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
9216 IdenticalNameAndTypeName here.
9217 (EventExpr.InstanceResolve): Likewise.
9219 2005-04-13 Marek Safar <marek.safar@seznam.cz>
9221 C# 2.0 DefaultCharSetAttribute implementation
9223 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
9224 which allows us to set GlobalNamespace for every resolve.
9225 (Attribute.ResolveArguments): Cut from Resolve.
9226 (Attribute.GetCharSetValue): Returns CharSet named argument.
9227 (Attribute.DefinePInvokeMethod): Gets default charset from
9229 (GlobalAttribute.ResolveAsTypeStep): Override.
9230 (GlobalAttribute.ResolveArguments): Override.
9232 * class.cs (TypeAttr): Is protected.
9234 * codegen.cs (ModuleClass.DefaultCharSet): New member.
9235 (ModuleClass.DefaultCharSetType): New memeber.
9236 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
9238 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
9239 charset from module.
9241 * delegate.cs (TypeAttr): Override.
9242 (Delegate.DefineType): Use this TypeAttr.
9244 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
9245 at very early stage (before types are defined) to resolve model
9246 module attributes. It will probably not work with corlib but it
9249 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
9250 charset from module.
9252 * typemanager.cs (default_charset_type): New type.
9254 2005-04-13 Raja R Harinath <rharinath@novell.com>
9256 * decl.cs (MemberCache.AddMethods): Don't warn if
9257 System.Object.Finalize has buggy MethodAttributes.
9259 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
9262 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9264 * doc.cs : detect ambiguous reference to overloaded members.
9265 Fixed bug #71603. MS 1.1 csc does not detect it.
9267 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9269 * doc.cs : delegates must not be referenced with parameters.
9272 2005-04-12 Miguel de Icaza <miguel@novell.com>
9274 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
9276 2005-04-10 Miguel de Icaza <miguel@novell.com>
9278 * driver.cs (MainDriver): Stop processing if the CLS stage found
9281 (CompilerCallableEntryPoint.InvokeCompiler): Always
9282 reset after execution; Take a TextWriter argument for the
9285 * report.cs: Use the error stream instead of hardcoding stderr.
9287 2005-04-09 Miguel de Icaza <miguel@novell.com>
9289 * class.cs: Reduce code paths to test, too small of an
9290 optimization to make it worth the extra testing. Always perform
9293 2005-04-08 Raja R Harinath <rharinath@novell.com>
9296 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
9297 operators that had errors reported on them.
9299 2005-04-08 Marek Safar <marek.safar@seznam.cz>
9301 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
9303 (Attribute.Resolve): Add named argument type checking.
9305 * class.cs (FixedField.Define): Use IsPrimitiveType
9307 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
9309 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
9310 unsafe parameter types.
9312 * statement.cs (Using.ResolveExpression): Add better error description.
9314 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
9316 2005-04-08 Raja R Harinath <rharinath@novell.com>
9319 * attribute.cs (Attribute.GetAttributeUsage): Resolve
9320 AttributeUsageAttribute in the emitcontext of the attribute class,
9321 not in the emitcontext of the attributable entity it was attached to.
9322 * cs-parser.jay: Use 'current_class', not 'current_container',
9323 when creating a GlobalAttribute.
9325 2005-04-08 Alp Toker <alp@atoker.com>
9327 * pending.cs: The fix to #58413 failed to compile methods implementing
9328 interfaces with/without params modifiers and vice versa, even though
9329 params modifiers aren't part of the signature. Make the modifier check
9330 less strict as in csc.
9332 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
9333 Anoob V E <projectmonokochi@rediffmail.com>
9334 Harilal P R <projectmonokochi@rediffmail.com>
9337 * pending.cs (TypeAndMethods.mods): New. Store the parameter
9338 modifiers of pending methods.
9339 (PendingImplementation.PendingImplementation): Initialize it.
9340 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
9341 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
9342 with ParameterData. Add check for modifiers.
9343 * class.cs (MethodData.Define): Update to changes.
9345 2005-04-07 Raja R Harinath <rharinath@novell.com>
9347 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
9349 2005-04-07 Marek Safar <marek.safar@seznam.cz>
9351 * class.cs (PropertyMethod.Define): Check private accessor in abstract
9354 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
9357 * typemanager.cs: Registered RequiredAttributeAttribute.
9359 2005-04-06 Marek Safar <marek.safar@seznam.cz>
9361 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
9362 Warning CS0169 is back at level 3.
9363 (IMethodData.SetMemberIsUsed): New method.
9365 * decl.cs (IsUsed): New value; moved from FieldBase.Status
9366 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
9368 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
9370 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
9372 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
9375 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
9378 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
9379 to avoid the problems with nested types.
9381 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
9382 Anoob V.E <projectmonokochi@rediffmail.com>
9383 Harilal P.R <projectmonokochi@rediffmail.com>
9384 Raja R Harinath <rharinath@novell.com>
9387 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
9389 * typemanager (GetConstructor): Make public.
9391 2005-04-05 John Luke <john.luke@gmail.com>
9392 Raja R Harinath <rharinath@novell.com>
9395 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
9396 struct too. Return false quicker in a few cases.
9397 (VerifyUnManaged): Use it.
9399 2005-04-05 Raja R Harinath <rharinath@novell.com>
9402 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
9403 not 'unreachable_seen'.
9405 2005-04-04 Marek Safar <marek.safar@seznam.cz>
9407 * attribute.cs (Attribute.GetValue): Removed unused.
9409 * codegen.cs (CodeGen.TrimExt): Removed unused.
9411 * cs-parser.jay (output): Removed unused.
9413 * cs-tokenizer.cs (hex_digits): Removed unused.
9415 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
9417 * expression.cs (Indirection.LoadExprValue): Removed unused.
9418 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
9420 * iterators.cs (Iterator.param_types): Removed unused.
9422 * statement.cs (Goto.block): Removed unused.
9423 (ToplevelBlock.did): Removed unused.
9424 (Switch.ResolveConstantSwitch): Removed unused.
9426 2005-04-01 Ben Maurer <bmaurer@ximian.com>
9428 * rootcontext.cs: Allow mcs to bootstrap with the compilation
9431 2005-04-01 Raja R Harinath <rharinath@novell.com>
9433 Fix #74232 and cs0208-3.cs.
9434 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
9435 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
9436 unmanaged type. Don't use FieldBuilders when 't' is a
9437 TypeBuilder. Use ModFlags and MemberType fields.
9438 * class.cs (MemberBase.member_type): Rename from MemberType.
9439 (MemberBase.MemberType): New property. Determines member_type on
9441 (MemberBase.DoDefine): Don't initialize MemberType here.
9442 (FieldMember.Define): Likewise.
9444 2005-04-01 Marek Safar <marek.safar@seznam.cz>
9447 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
9448 Attributes are emitted there.
9450 2005-04-01 Raja R Harinath <rharinath@novell.com>
9452 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9453 keyword in 'partial enum' too.
9454 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9456 Report from Kamil Skalski <nazgul@omega.pl>.
9459 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9460 have partial containers too.
9462 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9463 in block' checks to Block.CheckInvariantMeaningInBlock.
9464 * statement.cs (Block.GetKnownVariableInfo): Make private.
9465 (Block.IsVariableUsedInChildBlock): Remove.
9466 (Block.IsVariableUsedInBlock): Likewise.
9467 (Block.CheckInvariantMeaningInBlock): New. Show location of
9468 conflicting declaration.
9469 (Block.AddVariable): Make error messages less long-winded and more
9470 specific. Show location of conflicting declaration.
9471 * parameter.cs (Parameters.Location): New readonly property.
9473 2005-03-31 Raja R Harinath <rharinath@novell.com>
9475 Clean up semantics of invoking ResolveMemberAccess.
9476 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9477 can have an instance, ensure that we pass in a non-TypeExpression
9478 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9479 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9480 argument. Update to changes and simplify.
9481 (FieldExpr.Emitinstance): Remove CS0120 check.
9482 (PropertyExpr.EmitInstance): Likewise.
9483 * expression.cs (Argument.Resolve): Likewise.
9484 (Invocation.DoResolve): Update to changes in semantics of
9487 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9490 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9493 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9495 2005-03-31 Raja R Harinath <rharinath@novell.com>
9497 Fix difference in behaviour with commandline invocation.
9498 * driver.cs (Driver.Reset): New.
9499 (CompilerCallableEntryPoint): Call it.
9501 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9502 variable" warnings if the boolean expression failed to resolve.
9504 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9506 * attribute.cs: Fix the union of several permissions when some of them
9507 are unrestricted (so the result isn't an unrestricted permission set).
9510 2005-03-30 Raja R Harinath <rharinath@novell.com>
9512 * ecore.cs (MemberExpr): New class. Convert from interface
9514 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9515 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9517 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9518 (MethodGroupExpr.IsExplicitImpl): Remove.
9519 (Expression.GetFieldFromEvent): Remove.
9520 (SimpleName.MemberStaticCheck): Remove.
9521 (SimpleName.DoSimpleNameResolve): Update to changes.
9522 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9523 (MemberAccess.IdenticalNameAndTypeName): Remove.
9524 (MemberAccess.error176): Move to MemberExpr.
9525 (MemberAccess.DoResolve): Update to changes.
9526 (BaseAccess.DoResolve): Likewise.
9528 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9530 C# 2.0 Conditional attribute class implementation
9532 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9533 Analyzes class whether it has attribute which has ConditionalAttribute
9534 and its condition is not defined.
9536 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9537 (Class.IsExcluded): New method. Search for at least one defined
9538 condition in ConditionalAttribute of attribute class.
9540 2005-03-30 Raja R Harinath <rharinath@novell.com>
9542 * ecore.cs (PropertyExpr): Derive from Expression, not
9543 ExpressionStatement.
9544 (PropertyExpr.EmitStatement): Remove.
9546 2005-03-29 Raja R Harinath <rharinath@novell.com>
9549 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9550 internal field "value__" of an enum be private. The examples for
9551 "value__" that I found on MSDN all used FieldAttributes.Private.
9553 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9554 Don't mention IL method attribute names.
9556 Fix #47991. Remove a TODO.
9557 * statement.cs (Block.Toplevel): Make into a field.
9558 (Block.Parameters): Move into ToplevelBlock.
9559 (Block.known_variables): Rename from child_variable_names.
9560 (Block.Block): Remove variants that take Parameters. Initialize
9561 'Toplevel' with the immediately surrounding toplevel block.
9562 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9563 LocalInfo parameter.
9564 (Block.GetKnownVariableInfo): New.
9565 (Block.IsVariableNameUsedInChildBlock): Update.
9566 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9567 the block, even though it may not be in scope.
9568 (Block.AddVariable): Remove Parameters parameter. Use
9569 Toplevel.Parameters instead.
9570 (Block.AddConstant): Remove Parameters parameter.
9571 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9572 (Block.IsParamaterReference): Likewise.
9573 (Block.IsLocalParameter): Likewise. Simplify a lot.
9574 (ToplevelBlock.Parameters): New. Moved from Block.
9575 (ToplevelBlock.ToplevelBlock): Update to changes. Always
9576 initialize Parameters to a non-null value.
9577 * cs-parser.jay: Update to changes.
9578 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
9579 simple names that mean different things in the same block. Use
9580 Block.IsVariableNameUsedInBlock.
9582 2005-03-28 Raja R Harinath <rharinath@novell.com>
9584 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
9585 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
9586 GetTypeHandle. It is possible for a reflected type to derive from
9587 a TypeBuilder (e.g., int[] derives from the TypeBuilder
9588 System.Array during mscorlib compilation).
9589 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
9590 contain a method_hash, don't create one either. Don't create a
9591 deep copy of the base cache's method_hash.
9592 (MemberCache.SetupCache): Rename back from DeepCopy.
9593 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
9594 already initialized. If we see an override function, add its
9595 underlying base virtual function to the member_hash too.
9597 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
9599 2005-03-26 Raja R Harinath <harinath@acm.org>
9602 * assign.cs (Assign.DoResolve): When the RHS of an assignment
9603 fails to resolve, ensure that the LHS is still resolved as an
9606 2005-03-25 Raja R Harinath <harinath@acm.org>
9608 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
9610 (Enum.current_ec): Remove.
9611 (Enum.LookupEnumValue): Remove EmitContext argument.
9612 Just uses the one created during DefineType.
9613 (Enum.FindMembers): Update.
9614 * expression.cs (MemberAccess.DoResolve): Update.
9616 2005-03-22 Marek Safar <marek.safar@seznam.cz>
9618 * assign.cs (Assign.DoResolve): Check for CS1717 when
9619 source and target are same (uses Equals).
9621 * expression.cs (LocalVariableReference, ParameterReference,
9622 This): Implemented Equals, GetHashCode.
9624 * statement.cs (Block.GetParameterReference): Removed useless
9627 2005-03-22 Raja R Harinath <rharinath@novell.com>
9630 * statement.cs (Block.AddVariable): Ensure that we skip implicit
9631 blocks before deciding whether the error is cs0136 or cs0128.
9633 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
9634 (using_alias_directive, using_namespace_directive): Pass
9635 MemberName, not an expression to Namespace.UsingAlias and
9637 (MakeName): Use the MemberName of the namespace.
9638 * namespace.cs (Namespace.MemberName): New.
9639 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
9640 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
9642 * decl.cs (MemberName.Name): Make readonly.
9643 (MemberName.FromDotted): New "constructor".
9644 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
9645 (MemberCore.Name): Compute from MemberName on demand.
9646 (MemberCore.SetMemberName): Provide a way to change the
9648 (MemberCore.AddToContainer): Don't take a fullname parameter.
9649 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
9650 fully qualified name of the container to the member name.
9651 (TypeContainer.AddToTypeContainer): Use a fully qualified name
9652 only if the type is a member of the root container.
9653 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
9654 MemberName.Left rather than searching for an embedded ".".
9655 (PartialContainer.CreatePart): Update to changes in RootContext.
9656 (MemberBase.ShortName): Turn into a property. Use
9657 MemberCore.SetMemberName.
9658 (MemberBase.ExplicitInterfaceName): Remove.
9659 (MemberBase.UpdateMemberName): Remove.
9660 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
9661 (PropertyBase.SetMemberName): New override.
9662 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
9663 (Tree.GetDecl): New.
9664 (Tree.AllDecls): Rename from Decls.
9665 * attribute.cs, enum.cs, report.cs: Update to changes.
9666 * driver.cs (MainDriver): Use MemberName.FromDotted on
9667 RootContext.MainClass.
9669 2005-03-21 Marek Safar <marek.safar@seznam.cz>
9671 * class.cs (FixedField.Define): Check for CS1664 and more sanity
9674 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
9676 2005-03-18 Marek Safar <marek.safar@seznam.cz>
9678 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
9679 property accessor modifiers.
9681 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
9682 fixed buffer attribute (CS1716).
9683 (PropertyMethod.HasCustomAccessModifier): When property accessor
9684 has custom modifier.
9686 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
9688 (PropertyExpr.DoResolveLValue): Add CS0272.
9690 2005-03-17 Miguel de Icaza <miguel@novell.com>
9692 * convert.cs: When converting to a pointer, use the proper Conv.U
9693 or Conv.I depending on the source data type.
9695 * cs-tokenizer.cs: Make the size for large decimal constants,
9698 2005-03-17 Martin Baulig <martin@ximian.com>
9700 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
9701 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
9703 2005-03-17 Martin Baulig <martin@ximian.com>
9705 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
9706 to bool so we can return an error condition.
9707 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
9710 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
9712 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
9715 2005-03-16 Raja R Harinath <rharinath@novell.com>
9717 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
9718 Refactor to avoid traversing the list of assemblies, and to avoid
9719 string concatenation.
9720 * typemanager.cs (guid_attr_type): Remove.
9721 (negative_hits, pointers, references): Remove hashes.
9723 (GetConstructedType): New. Uses type_hash to handle constructed
9724 types (arrays, references, pointers).
9725 (GetReferenceType, GetPointerType): Use it.
9726 (GetNestedType): New. Uses type_hash to handle nested types of
9728 (LookupType, LookupTypeDirect): Remove.
9729 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
9730 'types' hash and LookupTypeReflection directly.
9731 (params_string, params_object): Use GetConstructedType.
9732 * namespace.cs (Namespace.cached_types): New. Cache of reflected
9734 (Namespace.Lookup): Use cached_types.
9735 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
9736 provided by old TypeManager.LookupType.
9737 * rootcontext.cs (MakeFQN): Remove.
9738 * decl.cs (DeclSpace.MakeFQN): Likewise.
9739 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
9740 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
9741 TypeManager.GetConstructedType.
9742 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
9744 2005-03-15 Marek Safar <marek.safar@seznam.cz>
9746 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
9749 * cs-parser.jay: Reports CS1527 for any namespace element.
9751 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
9754 * expression.cs (ParameterReference.IsAssigned): Changed error to
9756 (Error_WrongNumArguments): Moved CS0245 detection here.
9758 * statement.cs (Return.Resolve): Add CS1622 report.
9760 2005-03-11 Marek Safar <marek.safar@seznam.cz>
9762 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
9764 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
9766 * attribute.cs expression.cs: Get rid of some allocations.
9768 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
9770 * doc.cs : just eliminate the latest change.
9772 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9774 * doc.cs : commented out the latest change. It breaks xml-030.cs
9776 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9778 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
9779 fail. So invoke CreateType() in FindDocumentedType().
9781 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9783 * cs-tokenizer.cs : added IsKeyword().
9784 * doc.cs : Detect keyword incorrectly used as identifier.
9785 Allow identifiers prefixed by @.
9787 2005-03-10 Marek Safar <marek.safar@seznam.cz>
9789 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
9790 It caused exception in namespace resolving (again!).
9792 * class.cs (Class.ctor): Removed exit.
9793 (PropertyMethod.ctor): ditto.
9795 * codegen.cs (Codegen.Reset): Reset static data.
9796 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
9798 * cs-tokenizer.cs (Cleanup): Removed.
9800 * driver.cs (GetSystemDir): Rewrote to one line command.
9801 It caused problem with unloaded dynamic modules.
9802 (UnixParseOption): Removed Exit.
9803 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
9804 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
9805 Now can be mcs used as library.
9807 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
9810 * location.cs (Reset): Reset static data.
9812 * namespace.cs (Reset): Reset static data.
9814 * report.cs (Report.Reset): Reset static data.
9816 * rootcontext.cs (RootContext.Reset): Reset static data.
9818 * tree.cs (RootTypes.ctor): Use Location.Null
9820 * typemanager.cs (TypeManager.Reset): Reset static data.
9821 (CoreLookupType): Removed Exit.
9822 (TypeHandle.Reset): Reset static data.
9824 2005-03-10 Raja R Harinath <rharinath@novell.com>
9827 * typemanager.cs (ComputeNamespaces): Import namespaces from
9828 referenced modules too.
9830 2005-03-09 Raja R Harinath <rharinath@novell.com>
9832 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
9835 2005-03-09 Raja R Harinath <rharinath@novell.com>
9837 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
9838 enclosing DeclSpace. This ensures that a name-lookup populates
9839 more caches and there are fewer 'TypeExpression's. Carve out
9840 nested type lookup into ...
9841 (LookupNestedTypeInHierarchy): ... this.
9843 2005-03-09 Raja R Harinath <rharinath@novell.com>
9845 Clean up a few partial-class semantics.
9846 Fixes test-357.cs and cs1618-2.cs.
9847 * cs-parser.jay (struct_declaration): Use 'current_class' as
9848 parent of newly-created struct. Remove call to Register ().
9849 Use 'pop_current_class' to complete handing the current struct.
9850 (interface_declaration): Likewise.
9851 (class_declaration): Likewise.
9852 (enum_declaration): Use 'current_class' as parent of newly created
9854 (delegate_declaration): Likewise.
9855 (pop_current_class): New function. This is used to handle closing
9856 up the 'current_class' and 'current_container', and pointing them
9857 to the enclosing class/container.
9858 (CSharpParser): Initialize 'current_class' too.
9859 * decl.cs (MemberCore): Add check for invariant: a partial
9860 container is not a parsed entity, and thus does not enclose any
9862 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
9863 (DeclSpace.BaseTypeExpr): Use it.
9864 (DeclSpace.LookupType): Add check for invariant.
9865 * class.cs (TypeContainer): Add check for invariant: a nested
9866 class should have the same NamespaceEntry as its enclosing class.
9867 (TypeContainer.EmitFieldInitializers): Make virtual.
9868 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
9870 (TypeContainer.Register): Remove.
9871 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
9872 null. Use TypeResolveEmitContext for resolving base types and
9873 interfaces. Move initialization of Parts.TypeBuilder here from
9875 (TypeContainer.DefineNestedTypes): ... here.
9876 (PartialContainer): Take a Namespace not a NamespaceEntry.
9877 (PartialContainer.Create): Don't use Register. Call the
9878 appropriate Add... function directly.
9879 (ClassPart): Take both the PartialContainer and the enclosing
9880 class as constructor arguments.
9881 (ClassPart.EmitFieldInitializers): Override.
9882 (ClassPart.PartFindNestedTypes): Remove.
9883 (FieldBase.GetInitializerExpression): Resolve the initializer
9884 expression in the emit context of the enclosing class.
9885 * tree.cs (RootTypes): Remove Register ().
9887 2005-03-08 Marek Safar <marek.safar@seznam.cz>
9889 * cs-parser.jay: Removed CS0134.
9891 * driver.cs: Removed CS1901.
9893 * expression.cs (SizeOf.DoResolve): Don't report CS0233
9894 for predefined types.
9896 2005-03-07 Duncan Mak <duncan@novell.com>
9898 * codegen.cs (Save): Catch UnauthorizedAccessException as
9899 well. Fixes bug #73454.
9901 2005-03-07 Marek Safar <marek.safar@seznam.cz>
9903 * cs-tokenizer.cs (xtoken): Add CS1035.
9905 * class.cs (MethodData.Define): Add CS0683.
9906 (FieldMember.ctor): Add CS0681.
9908 2005-03-07 Raja R Harinath <rharinath@novell.com>
9910 * ecore.cs (SimpleName.DoResolve): Rename from
9911 SimpleName.DoResolveAllowStatic.
9912 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
9913 Pass 'intermediate' flag to MemberStaticCheck.
9914 (SimpleName.MemberStaticCheck): Skip "static check" only in case
9915 of "intermediate" lookups via MemberAccess.
9916 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
9917 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
9919 2005-03-07 Raja R Harinath <rharinath@novell.com>
9922 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
9923 slipped in because of variable names that are identical to a
9924 builtin type's BCL equivalent ('string String;', 'int Int32;').
9925 (PropertyExpr.EmitInstance): Likewise.
9927 2005-03-04 Marek Safar <marek.safar@seznam.cz>
9929 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
9931 * report.cs (warning_ignore_table): Made public.
9933 2005-03-04 Raja R Harinath <rharinath@novell.com>
9936 * class.cs (MethodData.Emit): Pass 'container' to
9937 container.GetObsoleteAttribute instead of 'container.Parent'.
9939 2005-03-03 Marek Safar <marek.safar@seznam.cz>
9941 * cs-parser.jay: Add 1534 error test.
9943 * iterators.cs (Yield.CheckContext): Add error 1629.
9944 (Iterator.ctor): Save unsafe modifier.
9945 (MoveNextMethod.DoEmit): Restore unsafe context.
9947 * namespace.cs (UsingAlias): Better error message.
9949 2005-03-03 Dan Winship <danw@novell.com>
9951 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
9952 the warning message [#73219]
9954 2005-03-03 Raja R Harinath <rharinath@novell.com>
9956 Fix compile with MCS 1.0.0.0.
9957 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
9958 w_restore to not depend on string constant folding.
9960 2005-03-03 Raja R Harinath <rharinath@novell.com>
9962 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
9963 CS0246 check to users who passed 'silent = false'.
9964 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
9966 (SimpleName.SimpleNameResolve): Update.
9967 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
9968 (MemberAccess.IdenticalNameAndTypeName): Update.
9969 * doc.cs (FindDocumentedTypeNonArray): Update.
9971 2005-03-03 Raja R Harinath <rharinath@novell.com>
9973 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
9974 * parameters.cs (ComputeAndDefineParameters): Remove.
9975 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
9976 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
9977 Use GetParameterInfo.
9979 2005-03-02 Marek Safar <marek.safar@seznam.cz>
9981 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
9983 2005-03-02 Raja R Harinath <rharinath@novell.com>
9985 Unify DeclSpace.LookupType and DeclSpace.FindType.
9986 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
9987 is in charge of defining nested types on demand.
9988 (DeclSpace.LookupType): Use it when the current_type is a
9989 TypeBuilder. Use LookupTypeDirect for reflected types.
9990 (DeclSpace.FindType): Remove.
9991 (DeclSpace.LookupInterfaceOrClass): Likewise.
9992 (DeclSpace.DefineTypeAndParents): Likewise.
9993 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
9994 DeclSpace.LookupType.
9995 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
9996 * typemanager.cs (LookupType): Simplify.
9997 (AddUserType): Remove type from negative_hits.
9998 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
9999 * class.cs (TypeContainer.FindMembers): Move handling of nested
10001 (TypeContainer.FindMembers_NestedTypes): ... here.
10002 (TypeContainer.FindNestedType): Implement override.
10003 (ClassPart.FindNestedType): Delegate to PartialContainer.
10004 (ClassPart.PartFindNestedType): Looks up the nested types of the
10007 2005-03-02 Martin Baulig <martin@ximian.com>
10009 * class.cs (TypeContainer.DoDefineMembers): We also need a default
10010 static constructor in static classes.
10012 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
10014 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
10015 sizeParamIndex is not specified.
10017 2005-03-01 Marek Safar <marek.safar@seznam.cz>
10020 * report.cs (WarningMessage.IsEnabled): Missing null check.
10022 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10024 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
10025 in the fields and not in the properties.
10027 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
10029 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
10032 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10034 * attribute.cs: Small refactoring (improved robustness).
10035 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
10036 (ValidateGuid): Removed.
10037 (Resolve): Removed referenced to above mentioned.
10038 (GetAttributeUsage): Made private and changed to work without
10040 (GetIndexerAttributeValue): Don't crash.
10041 (GetConditionalAttributeValue): Ditto.
10042 (GetClsCompliantAttributeValue): Ditto.
10043 (ExtractSecurityPermissionSet): All attributes exceptions are
10045 (GetPropertyValue): New helper.
10046 (GetMethodImplOptions): New method.
10047 (DefinePInvokeMethod): Reuse common code. Implemented handling of
10048 some missing properties.
10050 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
10051 (Method.ApplyAttributeBuilder): Updated.
10053 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
10056 2005-02-28 Raja R Harinath <rharinath@novell.com>
10059 * report.cs (Report.SymbolRelatedToPreviousError): Handle
10060 non-simple types (array, pointer, reference).
10062 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10064 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
10066 * class.cs (MethodCore.IsDuplicateImplementation): Special error
10068 (Method.CheckBase): Catch wrong destructor here.
10069 (MethodData.Define): Add errors 550, 668.
10071 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
10073 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
10075 * pending.cs (VerifyPendingMethods): Add error 551.
10077 * typemanager.cs (CSharpName): Next error report helper.
10079 2005-02-25 Marek Safar <marek.safar@seznam.cz>
10081 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
10082 attributes. Removed useless attribute double check.
10083 It saves almost 2MBs for corlib.
10085 2005-02-25 Raja R Harinath <rharinath@novell.com>
10088 * statement.cs (ExpressionStatement.Resolve): Make robust to being
10089 called twice in case of error.
10091 2005-02-23 Chris Toshok <toshok@ximian.com>
10093 Fix compiler portions of #72827.
10094 * statement.cs (Block.Emit): call Begin/EndScope on the
10095 EmitContext instead of the ILGenerator.
10097 * codegen.cs (EmitContext.BeginScope): new method, call
10098 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
10100 (EmitContext.BeginScope): same, but EndScope and CloseScope
10102 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
10103 offset and call the superclass's OpenScope(int) with it.
10104 (SymbolWriter.CloseScope): get the current il
10105 offset and call superclass's CloseScope(int) with it.
10107 2005-02-23 Marek Safar <marek.safar@seznam.cz>
10109 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
10110 CS1677 for out and ref as well.
10112 * class.cs (Method.Define): Add error CS1599 detection.
10114 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
10116 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
10118 * delegate.cs (Delegate.Define): Add error CS1599 detection.
10120 * support.cs.cs (ModifierDesc): New helper method.
10122 2005-02-23 Raja R Harinath <rharinath@novell.com>
10123 Abin Thomas <projectmonokochi@rediffmail.com>
10124 Anoob V E <projectmonokochi@rediffmail.com>
10125 Harilal P R <projectmonokochi@rediffmail.com>
10127 Fix #57851, #72718.
10128 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
10129 MemberLookup (used for error reporting) actually returns a result.
10130 Fix error report number (122, not 112).
10132 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
10133 Anoob V E <projectmonokochi@rediffmail.com>
10134 Harilal P R <projectmonokochi@rediffmail.com>
10137 * pending.cs (PendingImplementation.GetAbstractMethods):
10138 Find NonPublic members too.
10140 2005-02-22 Marek Safar <marek.safar@seznam.cz>
10142 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
10145 * class.cs (MethodCore.CheckMethodAgainstBase):
10146 Add error 239 report.
10148 2005-02-21 Raja R Harinath <rharinath@novell.com>
10151 * expression.cs (Invocation.IsApplicable): Make public.
10152 (Invocation.IsParamsMethodApplicable): Likewise.
10153 * delegate.cs (Delegate.VerifyApplicability): Don't use
10154 Invocation.VerifyArgumentCompat for parameter applicability
10155 testing. Use Invocation.IsApplicable and
10156 Invocation.IsParamsMethodApplicable.
10158 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10160 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
10162 * class.cs (Operator.Define): Add error 217 report.
10164 2005-02-21 Raja R Harinath <rharinath@novell.com>
10166 * namespace.cs (UsingEntry.Resolve): Undo change below.
10168 2005-02-21 Raja R Harinath <rharinath@novell.com>
10171 * ecore.cs (Expression.MemberLookupFailed): Add argument to
10172 disable the error message when the extended MemberLookup also
10174 (Expression.MemberLookupFinal): Update.
10175 (SimpleName.DoSimpleNameResolve): Update.
10176 * expression.cs (MemberAccess.ResolveNamespaceOrType):
10177 Don't use MemberLookupFinal.
10178 (New.DoResolve): Update.
10179 (BaseAccess.CommonResolve): Update.
10181 2005-02-21 Raja R Harinath <rharinath@novell.com>
10184 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
10185 occured previously, don't resolve again.
10187 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10190 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
10191 argument. Call ResolveAttributeUsage for unresolved.
10192 when types doesn't match ctor arguments.
10194 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
10195 for nested attribute classes.
10196 (Class.attribute_usage): Removed.
10197 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
10198 for attribute class.
10200 * ecore.cs (IsAttribute): Removed.
10202 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
10204 * rootcontext.cs (RegisterAttribute): Removed, attributes are
10206 (attribute_types): Removed.
10207 (EmitCode): Global attributes are emited as the latest.
10209 2005-02-18 Marek Safar <marek.safar@seznam.cz>
10211 * class.cs (EmitFieldInitializers): Don't emit field initializer
10212 for default values when optimilization is on.
10214 * constant.cs (Constant.IsDefaultValue): New property.
10216 * driver.cs: Add /optimize handling.
10220 * literal.cs: Implement new IsDefaultValue property.
10222 * rootcontext.cs (Optimize): New field, holds /optimize option.
10224 2005-02-18 Raja R Harinath <rharinath@novell.com>
10226 Fix crasher in re-opened #72347.
10227 * namespace.cs (Namespace.Lookup): Return null if
10228 DeclSpace.DefineType returns null.
10231 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
10233 2005-02-18 Raja R Harinath <rharinath@novell.com>
10235 Fix remainder of #63202. Change semantics of DoResolveLValue: it
10236 now returns null if it cannot resolve to an lvalue.
10237 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
10238 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
10239 returned null. Remove check for SimpleName.
10240 (EventExpr.DoResolveLValue): New.
10241 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
10242 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
10244 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
10245 avoid CS0131 error.
10246 (Unary.ResolveOperator): Move CS0211 check ...
10247 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
10249 (Unary.DoResolveLValue): Simplify.
10250 (AddressOf.DoResolveLValue): New.
10251 (ArrayAccess.DoResolveLValue): New.
10253 2005-02-16 Marek Safar <marek.safar@seznam.cz>
10255 * attribute.cs (Attribute.Resolve): Add arguments casting for
10256 when types doesn't match ctor arguments.
10258 2005-02-16 Raja R Harinath <rharinath@novell.com>
10260 Fix parts of #63202.
10261 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
10262 lookup of operator in base type. Ensure that all checks happen
10263 when the operator resolves to an "op_..." method.
10265 2005-02-15 Raja R Harinath <rharinath@novell.com>
10268 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
10269 'ignore_cs0104' parameter. Pass it to ...
10270 (NamespaceEntry.Lookup): ... this.
10271 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
10272 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
10273 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10274 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
10275 Update. Request that cs0104 errors be ignored.
10276 (ComposedCast.ResolveAsTypeStep): Update.
10278 2005-02-14 Raja R Harinath <rharinath@novell.com>
10281 * expression.cs (Invocation.BetterFunction): Remove support for
10282 comparing virtual functions and their overrides.
10283 (Invocation.IsOverride): New.
10284 (Invocation.OverloadResolve): Don't consider 'override' functions
10285 during candidate selection. Store them in a lookaside list.
10286 If the selected method is a 'virtual' function, use the list to
10287 find any overrides that are closer to the LHS type.
10289 2005-02-14 Marek Safar <marek.safar@seznam.cz>
10291 * expression.cs (New.DoResolve): Add complex core type reduction.
10292 (New.Constantify): Converts complex core type syntax like 'new int ()'
10293 to simple constant.
10295 2005-02-14 Raja R Harinath <rharinath@novell.com>
10297 * decl.cs (EntryType.EntryType): New constructor to create an
10298 updated copy of a cache entry.
10299 (MemberCache.AddMethods): Use it.
10300 (MemberCache.ClearDeclaredOnly): Remove.
10301 (MemberCache.MemberCache): Update.
10303 2005-02-11 Miguel de Icaza <miguel@novell.com>
10305 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
10306 variable. This one is represents the actual low-level declaration
10307 of the method, as opposed to the semantic level `IsStatic'.
10309 An anonymous method which is hosted into a static method might be
10310 actually an instance method. IsStatic would reflect the
10311 container, while MethodIsStatic represents the actual code
10314 * expression.cs (ParameterReference): Use the new MethodIsStatic
10315 instead of IsStatic.
10317 * anonymous.cs (AnonymousMethod.Compatible): Pass the
10318 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
10319 set on the current EmitContext.
10321 * expression.cs (Cast): Overload DoResolveLValue so we can pass
10322 resolve our casted expression as an LValue. This triggers the
10323 proper LValue processing that is later required by Assign.
10327 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
10329 2005-02-11 Marek Safar <marek.safar@seznam.cz>
10331 C# 2.0 Fixed buffer implementation
10333 * anonymous.cs: Update after RegisterHelperClass renaming.
10335 * attribute.cs (AttributeTester.fixed_buffer_cache):
10336 Cache of external fixed buffers.
10337 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10338 implementation if field is fixed buffer else null.
10341 (TypeContainer.AddField): Accept FieldMember instead of Field.
10342 (FieldBase.IsFieldClsCompliant): Extracted code from
10343 VerifyClsCompliance descendant customization.
10344 (FixedField): New class handles fixed buffer fields.
10345 (FixedFieldExternal): Keeps information about imported fixed
10347 (IFixedField): Make access to internal or external fixed buffer
10350 * cs-parser.jay: Add fixed buffer parsing.
10352 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
10355 * expression.cs (Indirection): Extended implementation to accept
10356 fixed buffer field.
10357 (PointerArithmetic.Emit): Get element from fixed buffer as well.
10358 (ElementAccess.MakePointerAccess): Get type as parameter.
10359 (DoResolve): Add fixed buffer field expression conversion.
10360 (DoResolveLValue): Ditto.
10361 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
10362 (ArrayPtr): Derives from FixedBufferPtr.
10363 (ArrayPtr.Emit): Add extra emit for array elements.
10365 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
10367 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
10368 for compiler generated types.
10369 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
10371 * statement.cs (Fixed): Refactored to be easier add fixed buffer
10372 and consume less memory.
10373 (Fixed.Resolve): Add fixed buffer case.
10375 * typemanager.cs (compiler_generated_attr_ctor,
10376 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
10377 (HasElementType): Add our own implementation to work on every
10380 2005-02-11 Miguel de Icaza <miguel@novell.com>
10382 * anonymous.cs (CaptureContext): Track whether `this' has been
10385 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
10386 only captured `this' if it was implicitly done (instance
10387 methods/variables were used).
10389 * codegen.cs (EmitContext.CaptureThis): New method to flag that
10390 `this' must be captured.
10392 2005-01-30 Miguel de Icaza <miguel@novell.com>
10394 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
10395 is null it means that there has been no need to capture anything,
10396 so we just create a sibling.
10398 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
10400 Just a partial fix. The other half is fairly elusive.
10402 2005-02-10 Raja R Harinath <rharinath@novell.com>
10404 Fix #52586, cs0121-4.cs.
10405 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
10406 and return a hashtable.
10407 (MemberCache.ClearDeclaredOnly): New.
10408 (MemberCache.MemberCache): Update to change. Make a deep copy of
10409 the method_hash of a base type too.
10410 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10411 type methods. Overwrite entries with the same MethodHandle so
10412 that the ReflectedType is correct. The process leaves in base
10413 virtual functions and their overrides as distinct entries.
10414 (CacheEntry): Now a class instead of a struct. It shouldn't alter
10415 matters since it was boxed in a ArrayList before.
10416 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
10418 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
10419 case of a virtual function and its override (choose the overload
10421 (Invocation.OverloadResolve): Avoid 'override' members during
10422 'applicable_type' calculation.
10424 2005-02-09 Raja R Harinath <rharinath@novell.com>
10426 Combine two near-redundant caches.
10427 * typemanager.cs (method_params): Rename from method_internal_params.
10428 (TypeManager.GetParameterData): New. Replace
10429 Invocation.GetParameterData.
10430 (TypeManager.LookupParametersByBuilder): Remove.
10431 * expression.cs (Invocation.method_parameter_cache): Remove.
10432 (Invocation.GetParameterData): Remove.
10434 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
10437 2005-02-08 Raja R Harinath <rharinath@novell.com>
10440 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
10441 TypeManager.multicast_delegate_type is null, resolve it by looking
10442 up "System.MulticastDelegate".
10443 * rootcontext.cs (RootContext.ResolveCore): Simplify.
10445 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
10446 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
10447 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
10450 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
10451 (LabeledStatement.AddReference): New. Set 'referenced'.
10452 (Goto.Resolve): Use it.
10454 2005-02-05 John Luke <john.luke@gmail.com>
10456 * driver.cs: remove duplicate -doc line in Usage ()
10458 2005-02-04 Raja R Harinath <rharinath@novell.com>
10460 * location.cs (Location.AddFile): Fix CS2002 error report.
10462 2005-02-02 Martin Baulig <martin@ximian.com>
10464 * delegate.cs (Delegate.DefineType): Report an internal error if
10465 TypeManager.multicast_delegate_type is null. See bug #72015 for
10468 2005-02-02 Raja R Harinath <rharinath@novell.com>
10470 Fix a crasher in a variant of #31984.
10471 * const.cs (Constant.CheckBase): New override that defers the
10472 new-or-override check in case the base type hasn't been populated
10474 (Constant.Define): Ensure the new-or-override check is performed.
10476 2005-02-01 Duncan Mak <duncan@ximian.com>
10478 * const.cs (LookupConstantValue): Check that `ce' is not null
10479 before calling GetValue ().
10481 2005-02-01 Raja R Harinath <rharinath@novell.com>
10483 Fix test-334.cs (#69519).
10484 * cs-parser.jay (using_alias_directive): Pass in an expression to
10485 NamespaceEntry.UsingAlias.
10486 (using_namespace_directive): Pass in an expression to
10487 NamespaceEntry.Using.
10488 (namespace_name): Don't flatten to a string.
10489 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10490 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10492 (NamespaceEntry.UsingEntry): Likewise.
10493 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10495 (NamespaceEntry.LookupForUsing): Remove.
10496 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10498 (NamespaceEntry.Lookup): Remove support for dotted names.
10500 2005-02-01 Raja R Harinath <rharinath@novell.com>
10502 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10504 (NamespaceEntry.ImplicitParent): Compute on demand.
10505 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10506 parallels the current.
10507 (NamespaceEntry.LookupForUsing): Use it.
10508 (NamespaceEntry.Lookup): If the current namespace-entry is
10509 implicit, don't search aliases and using tables.
10511 2005-02-01 Raja R Harinath <rharinath@novell.com>
10514 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10516 (TypeContainer.BaseCache): Compute on demand.
10517 (TypeContainer.FindMembers): Define constants and types if they're
10518 not already created.
10519 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10521 * const.cs (Constant.Define): Make idempotent.
10523 2005-01-29 Miguel de Icaza <miguel@novell.com>
10525 * pending.cs: Produce better code (no nops produced by using Ldarg
10528 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10529 i - 1' it should be arg + 1.
10533 2005-01-28 Raja R Harinath <rharinath@novell.com>
10535 * attribute.cs (Attribute.CheckAttributeType): Make private
10537 (Attribute.ResolveType): Make virtual.
10538 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10539 handling of RootContext.Tree.Types.
10541 2005-01-27 Raja R Harinath <rharinath@novell.com>
10543 Update attribute-handling to use the SimpleName/MemberAccess
10545 * cs-parser.jay (attribute): Pass in an expression to the
10546 constructors of Attribute and GlobalAttribute.
10547 * attribute.cs (Attribute): Take an expression for the name.
10548 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10549 passed in attribute name expression.
10550 (Attribute.CheckAttributeType): Use it.
10551 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10552 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10553 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10554 argument to prevent error messages if the lookup fails.
10556 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10558 * expression.cs (Indirection): Implemented IVariable interface
10559 to support indirection in AddressOf operator.
10560 (PointerArithmetic.Emit): Add optimalization for case where
10561 result can be precomputed.
10563 2005-01-26 Martin Baulig <martin@ximian.com>
10565 * class.cs (TypeContainer.AttributeTargets): Return the correct
10566 AttributeTargets depending on our `Kind' instead of throwing an
10567 exception; fixes #71632.
10569 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10572 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
10575 2005-01-25 Raja R Harinath <rharinath@novell.com>
10578 * expression.cs (MemberAccess.DoResolve): Don't complain with
10579 cs0572 when the LHS of a member access has identical name and type
10582 2005-01-25 Marek Safar <marek.safar@seznam.cz>
10585 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
10587 Create custom PermissionSet only for PermissionSetAttribute.
10589 2005-01-24 Marek Safar <marek.safar@seznam.cz>
10592 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
10593 delegates in static class.
10595 2005-01-24 Martin Baulig <martin@ximian.com>
10597 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10598 merging an implicit block, just use its reachability.
10600 * statement.cs (Block.Resolve): Make the unreachable code check
10601 work wrt. implicit blocks; see test-337 from #63842.
10603 2005-01-21 Alp Toker <alp@atoker.com>
10605 * cs-parser.jay: destructor_declaration's container is PartialContainer
10606 not Class when partial types are used, so use Kind prop instead of
10609 2005-01-22 Miguel de Icaza <miguel@ximian.com>
10611 * cs-parser.jay: Improve error reporting when an interface
10612 declares new types.
10614 2005-01-20 Dick Porter <dick@ximian.com>
10616 * support.cs: SeekableStreamReader fix from Sandor Dobos
10617 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
10618 chars are read. Fixes bug 70369.
10620 2005-01-20 Raja R Harinath <rharinath@novell.com>
10622 * cs-parser.jay (catch_clause): Simplify current_block handling
10625 2005-01-17 Miguel de Icaza <miguel@ximian.com>
10627 * convert.cs (ImplicitStandardConversionExists): Synchronize the
10628 code with ImplicitStandardConversion to handle the implicit
10629 conversion of method groups into valid delegate invocations.
10631 The problem is that in parameter handling we were using this code
10632 path. Fixes bug #64698
10634 2005-01-19 Raja R Harinath <rharinath@novell.com>
10636 * cs-parser.jay: Fix several infelicities.
10637 - Avoid assigning to the parser value stack. Code like
10638 '$3 = null' is unclean. Synthesize a value for the code block
10640 - Avoid using oob_stack for storing location information. Use ...
10641 (_mark_): ... this. New (empty) rule. Saves the current location
10643 (foreach_statement): Avoid using oob_stack for current_block
10644 handling. Use technique used in for_statement and
10645 using_statement. Synthesize a value for the code block to store
10646 additional intermediate information.
10648 2005-01-13 Miguel de Icaza <miguel@ximian.com>
10650 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
10651 of a different type is only allowed to private fields of a
10652 containing type, not on fields of a base class.
10654 See test-174.cs and error cs0122-9.cs
10656 2005-01-13 Raja R Harinath <rharinath@novell.com>
10658 Fix test-335.cs (bug #58126).
10659 * cs-parser.jay (argument): Split out non-expression parts of the
10660 rule into 'non_simple_argument'.
10661 (invocation_expression): Support parenthesized invocations with
10662 multiple arguments, and with single non-simple arguments.
10664 2005-01-13 Raja R Harinath <rharinath@novell.com>
10666 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
10669 2005-01-12 Raja R Harinath <rharinath@novell.com>
10671 Fix cs0038-1.cs, cs1640-6.cs.
10672 * ecore.cs (Expression.Resolve): Remove special-case for
10673 SimpleName in error-handling.
10674 (Expression.almostMatchedMembers): Relax access permission to
10676 (Expression.MemberLookupFailed): Handle duplicates in
10677 almostMatchedMembers list.
10678 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
10679 * expression.cs (New.DoResolve): Report CS1540 for more cases.
10680 * typemanager.cs (GetFullNameSignature): Use the MethodBase
10681 overload if the passed in MemberInfo is a MethodBase.
10683 2005-01-12 Marek Safar <marek.safar@seznam.cz>
10686 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
10687 for non-CAS & merge permission sets properly.
10689 2005-01-11 Raja R Harinath <rharinath@novell.com>
10691 Improve standard-compliance of simple name and member access
10692 resolution. Fixes bugs #52697, #57200, #67520, #69519.
10693 * ecore.cs (FullNamedExpression): New abstract base class
10694 for Namespaces and TypeExpressions.
10695 (ResolveFlags.SimpleName): Remove.
10696 (SimpleName): Remove support for dotted names.
10697 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
10698 DeclSpace.FindType and DeclSpace.LookupType.
10699 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
10700 (Expression.ExprClassName): Make member function.
10701 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
10702 a namespace. Remove creation of dotted "SimpleName"s.
10703 (MemberAccess.DoResolve): Likewise.
10704 * decl.cs (DeclSpace.Cache): Make private.
10705 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
10706 (DeclSpace.FindType): Update.
10707 (DeclSpace.LookupType): Move here from RootContext. Return a
10708 FullNamedExpression.
10709 * namespace.cs (Namespace): Derive from FullNamedExpression
10710 so that it can be part of expression resolution.
10711 (Namespace.Lookup): Return an FullNamedExpression.
10712 (NamespaceEntry.LookupAlias): Lookup aliases only in current
10714 * rootcontext.cs (NamespaceLookup): Remove.
10715 (LookupType): Move to DeclSpace.
10716 * attribute.cs (CheckAttributeType): Update.
10717 * doc.cs (FindDocumentedType): Remove allowAlias argument.
10718 (FindDocumentedTypeNonArray): Likewise.
10720 2005-01-11 Raja R Harinath <rharinath@novell.com>
10722 Fix cs0509.cs, cs1632.cs.
10723 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
10724 is the same as IsInterface.
10725 (TypeContainer.GetClassBases): Likewise.
10726 * statement.cs (LabeledStatement.ig): New field.
10727 (LabeledStatement.LabelTarget): Save ILGenerator which created the
10729 (LabeledStatement.DoEmit): Check that the label was created with
10730 the same ILGenerator.
10732 2005-01-10 Marek Safar <marek.safar@seznam.cz>
10735 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
10736 accessors to its properties.
10738 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
10739 from accessors to property.
10741 2005-01-10 Marek Safar <marek.safar@seznam.cz>
10744 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
10745 only for overrides.
10747 2005-01-08 Miguel de Icaza <miguel@ximian.com>
10749 * attribute.cs: Check for null and empty strings.
10751 I have lost another battle to Paolo.
10753 2005-01-07 Marek Safar <marek.safar@seznam.cz>
10756 * class.cs (PropertyMethod): Set Parent field in ctors.
10757 (SetMethod.InternalParameters): Add unsafe switch hack.
10758 Override MarkForDuplicationCheck where it is appropriate.
10760 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
10761 It says whether container allows members with the same name.
10762 Base default is no.
10763 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
10764 Removed is_method parameter.
10766 2005-01-06 Duncan Mak <duncan@ximian.com>
10768 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
10769 because the previous change led to incorrect reporting of CS1032
10770 ("Cannot define/undefine preprocessor symbols after first token in
10771 file"). Instead of using `tokens_seen' as the only flag that
10772 triggers CS1040, introduce `comments_seen'. This new flag is used
10773 to signify having seen comments on the current line, so it is
10774 unset after a newline.
10776 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10778 * doc.cs : When searching for a type, find nested type too.
10779 This fixes bug #71040.
10781 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10784 - Warn missing member comment on those classes which also does not
10785 have doc comments. Fixed bug #71041.
10786 - Don't warn missing doc comment on default constructor.
10789 2005-01-06 Duncan Mak <duncan@ximian.com>
10791 * cs-tokenizer.cs (xtoken): After handling traditional C-style
10792 comments, set `tokens_seen' to true. This allows us to detect
10793 misplaced preprocessor directives (i.e. not at the beginning of
10794 the a line, nor after whitespaces). In that case, report error
10795 CS1040. This fixes bug #56460.
10797 * cs-parser.jay (interface_member_declaration): Add checks for
10798 IsExplicitImpl, and report CS0541 error if an interface member is
10799 defined as an explicit interface declaration.
10801 2005-01-06 Marek Safar <marek.safar@seznam.cz>
10804 * class.cs (PropertyMethod): Set Parent field in ctors.
10805 (SetMethod.InternalParameters): Add unsafe switch hack.
10807 * decl.cs (MemberCore.Parent): Cannot be readonly.
10809 2005-01-06 Raja R Harinath <rharinath@novell.com>
10811 * decl.cs (DeclSpace.ResolveType): Remove.
10812 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
10813 Merge in code from ...
10814 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
10815 * class.cs, enum.cs: Update to changes.
10817 2005-01-06 Miguel de Icaza <miguel@ximian.com>
10819 * anonymous.cs: Ensure that we init the scope of our parent if it
10820 has not been initialized yet.
10822 2004-12-30 Duncan Mak <duncan@ximian.com>
10824 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
10825 if field.FieldBuilder is null. Fixes #70758.
10827 * convert.cs: Fixed some typos and updated some of the comments.
10828 (ImplicitStandardConversionExists):
10829 (TryImplicitIntConversion): If `target_type' is an interface and
10830 the type of `ic' implements this interface, return true or a new
10831 BoxedCast instead of null. This fixes #70468.
10833 2004-12-29 Duncan Mak <duncan@ximian.com>
10835 * expression.cs (Argument.Emit): Check that Expr is
10836 IMemoryLocation before casting to it, and report CS1510 otherwise.
10840 2004-12-21 Ben Maurer <bmaurer@ximian.com>
10842 * statement.cs (Block.ThisVariable): remove the recursion here, to
10843 make the --profile more sane.
10845 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
10847 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
10848 assembly, by JB Evain.
10850 2004-12-17 Raja R Harinath <rharinath@novell.com>
10852 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
10853 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
10854 "parent" refers to enclosing type/class. "base" refers to superclass.
10856 2004-12-17 Raja R Harinath <rharinath@novell.com>
10858 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10859 Ensure that we only have GlobalAttributes.
10860 * attribute.cs (Attribute.Emit): Make non-virtual.
10861 (GlobalAttribute.Emit): Remove.
10862 (Attribute.Resolve): Make virtual.
10863 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
10864 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
10865 the argument. Don't create one.
10866 (Attribute.GetObsoleteAttribute): Likewise.
10867 (Attribute.GetClsCompliantAttributeValue): Likewise.
10868 * class.cs, decl.cs: Update to changes.
10870 2004-12-17 Marek Safar <marek.safar@seznam.cz>
10872 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
10874 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
10876 * statement.cs (Foreach.Resolve): Add error 186 report.
10878 2004-12-16 Marek Safar <marek.safar@seznam.cz>
10880 * expression.cs (Conditional.DoResolve): Add warning 429.
10882 * statement.cs (If.Resolve): Add warning 665.
10884 2004-12-16 Raja R Harinath <rharinath@novell.com>
10886 New invariant: RootContext.Tree.Types.NamespaceEntry == null
10887 except when in the parser, and in GlobalAttribute.
10888 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
10889 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
10890 RootContext.Tree.Types.NamespaceEntry once work is done.
10891 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
10892 and resets RootContext.Tree.Types.NamespaceEntry.
10894 2004-12-15 Marek Safar <marek.safar@seznam.cz>
10896 * cs-parser.jay: Don't create a block for every variable.
10898 2004-12-14 Miguel de Icaza <miguel@ximian.com>
10900 * location.cs: Provide extra information.
10902 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
10903 variables from the captured environment, it is the ldarg_0.
10905 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10907 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
10910 * class.cs: Changed warning level for 169 to avoid developer
10911 displeasure from warning flooding. It will be changed back when they
10912 fix most of current BCL warnings.
10914 * RootContext.cs: Pushed default WarningLevel to 3.
10916 * statement.cs: Removed unused variable.
10918 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10920 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
10921 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
10922 Add error 502 report.
10923 (StaticClass.DefineType): Add error 441 report.
10924 (Class.AllowedModifiersProp): New virtual property as temporary
10925 extension to AllowedModifiers.
10926 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10927 to share implementation with StaticClass and don't call virtual
10930 * driver.cs (MainDriver): Add error 1558 test.
10932 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
10933 report. Moved error 36 test here.
10935 * statement.cs (Throw.Resolve): Add error 724 report.
10937 * typemanager.cs: Add out_attribute_type core type.
10939 2004-12-13 Marek Safar <marek.safar@seznam.cz>
10941 * class.cs (TypeContainer.VerifyClsCompliance): Add error
10943 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
10945 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
10948 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
10950 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
10951 Add error 3023 report.
10952 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
10954 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
10957 2004-12-12 John Luke <john.luke@gmail.com>
10959 * driver.cs (AddArgs): take -- into account when
10960 adding arguments, fixes bug 65710
10962 2004-12-12 Martin Baulig <martin@ximian.com>
10964 * expression.cs (Unary.TryReduceNegative): Added support for
10965 SByteConstant and ByteConstant.
10966 (Unary.Reduce): Check error values from TryReduceNegative().
10968 2004-12-10 Marek Safar <marek.safar@seznam.cz>
10970 * attributes.cs (Attribute.Resolve): Avoid multiple error report
10971 and report exception as error 182.
10973 2004-12-10 Raja R Harinath <rharinath@novell.com>
10975 * driver.cs (Main): Fix message when there are warnings.
10977 2004-12-09 Miguel de Icaza <miguel@ximian.com>
10979 * delegate.cs: Fixed my fix from yesterday, sorry about that.
10981 2004-12-09 Marek Safar <marek.safar@seznam.cz>
10983 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
10984 Reduced number of warnings.
10986 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
10988 2004-12-08 Miguel de Icaza <miguel@ximian.com>
10990 * driver.cs: Removed message.
10992 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
10994 2004-12-08 <vargaz@freemail.hu>
10996 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
10998 2004-12-08 Martin Baulig <martin@ximian.com>
11000 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
11001 instead of a CS3002 for properties and indexer.
11003 2004-12-08 Martin Baulig <martin@ximian.com>
11005 * decl.cs (MemberName.ToString): Make this work again.
11007 2004-12-08 Marek Safar <marek.safar@seznam.cz>
11009 * attribute.cs (Resolve): Add error 591 detection.
11011 * class.cs (FieldMember.Define): Add error 1547 detection.
11012 (Indexer.Define): Add error 620 detection.
11013 (Operator.Define): Add error 590 detection.
11015 * ecore.cs: Missing argument for error 79.
11017 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
11020 2004-12-07 Marek Safar <marek.safar@seznam.cz>
11023 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
11026 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
11028 * cs-parser.jay : handle doc comments on implicit/explicit operators.
11029 Some operator comments were suppressed.
11030 * doc.cs : Implicit/explicit operator name in doc comments are like
11031 "op_Explicit(type)~returnType", so added suffix handling.
11033 2004-12-07 Martin Baulig <martin@ximian.com>
11036 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
11037 (MemberCore.GetClsCompliantAttributeValue): Likewise.
11038 (DeclSpace.ec): New protected field; store the EmitContext here.
11039 (DeclSpace.EmitContext): New public property; moved here from
11041 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
11044 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
11045 (Enum.Emit): Don't create a new EmitContext.
11047 * delegate.cs (Delegate.DefineType): Always create the
11050 * iterators.cs (Iterators.DefineIterator): Create a new
11051 EmitContext and store it in `ec'.
11053 2004-08-24 Martin Baulig <martin@ximian.com>
11056 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
11057 this for accessibility checks.
11058 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
11059 IsNestedFamilyAccessible.
11060 (TypeManager.IsSubclassOf): New method, do what the name actually
11063 2004-12-06 Raja R Harinath <rharinath@novell.com>
11065 Fix crash on cs0657-17.cs.
11066 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11067 Use RootContext.Tree.Types, not 'new RootTypes ()'.
11068 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
11069 the case where the NamespaceEntry gets overwritten.
11071 2004-12-06 Marek Safar <marek.safar@seznam.cz>
11073 Fixed #69195, #56821
11074 * ecore.cs (ResolveBoolean): Tiny refactoring.
11076 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
11077 of right expression resolving when left is false constant and
11078 operator is LogicalAnd OR true constant and operator is LogicalOr.
11080 * statement.cs (ResolveUnreachable): Always reports warning.
11082 2004-12-05 Miguel de Icaza <miguel@ximian.com>
11084 * class.cs: Distinguish between 1721 and 1722 (just a little help
11085 for the programmer).
11087 2004-12-03 Miguel de Icaza <miguel@ximian.com>
11089 * delegate.cs: Only allow this on new versions of the language.
11091 2004-12-02 Duncan Mak <duncan@ximian.com>
11093 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
11095 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
11096 here as a static method. Take an additional bool out parameter
11097 `must_do_cs1540_check' for signaling to InstanceResolve.
11098 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
11099 member field from PropertyExpr class and made it an argument of
11100 the method instead.
11101 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
11102 check for MarshalByRefObject, and report CS0122 instead of CS1540.
11103 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
11104 and `remove_accessor' as well as InstanceResolve: report CS0122
11109 2004-12-03 Raja R Harinath <rharinath@novell.com>
11111 Fix test-327.cs, test-328.cs, and put in early infrastructure
11112 for eventually fixing #52697.
11113 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
11114 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
11115 from other methods.
11116 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
11117 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
11118 (VerifyUsing, error246): Update.
11119 * rootcontext.cs (RootContext.NamespaceLookup): Just use
11120 'NamespaceEntry.LookupNamespaceOrType'.
11122 2004-12-03 Martin Baulig <martin@ximian.com>
11124 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11125 method as our child, call AnonymousMethod.Compatible() on it.
11127 2004-12-03 Raja R Harinath <rharinath@novell.com>
11129 Disable XML documentation support in 'basic' profile.
11130 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
11131 Redirect XmlElement to System.Object.
11132 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
11133 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
11134 * mcs.exe.sources: Add doc-bootstrap.cs.
11135 * doc-bootstrap.cs: New file. Contains empty stub implementation
11138 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
11140 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
11141 comments are allowed.
11143 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11145 * delegate.cs: Add checks for subtypes in paramaters and return values
11146 in VerifyMethod () to add support for Covariance/Contravariance
11149 2004-12-02 Miguel de Icaza <miguel@ximian.com>
11151 * report.cs: Remove extra closing parenthesis.
11153 * convert.cs (Error_CannotImplicitConversion): If the name of the
11154 types are the same, provide some extra information.
11156 * class.cs (FieldBase): Use an unused bit field from the field to
11157 encode the `has_offset' property from the FieldMember. This saves
11158 a couple of Ks on bootstrap compilation.
11160 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11161 method as our child, return the AnonymousMethod resolved
11164 * expression.cs (New.DoResolve): Allow return values from
11165 NewDelegate to also include AnonymousMethods.
11169 2004-12-02 Marek Safar <marek.safar@seznam.cz>
11172 * attribute.cs (Resolve): Improved implementation of params
11173 attribute arguments.
11175 * support.cs (ParameterData): Add HasParams to be faster.
11177 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
11179 all things are for /doc support:
11181 * doc.cs: new file that supports XML documentation generation.
11182 * mcs.exe.sources: added doc.cs.
11184 Handle /doc command line option.
11185 Report error 2006 instead of 5 for missing file name for /doc.
11186 Generate XML documentation when required, after type resolution.
11188 Added support for picking up documentation (/// and /** ... */),
11189 including a new XmlCommentState enumeration.
11191 Added lines to fill Documentation element for field, constant,
11192 property, indexer, method, constructor, destructor, operator, event
11193 and class, struct, interface, delegate, enum.
11194 Added lines to warn incorrect comment.
11196 Added Documentation field (passed only when /doc was specified).
11198 Added DocComment, DocCommentHeader, GenerateDocComment() and
11199 OnGenerateDocComment() and some supporting private members for
11200 /doc feature to MemberCore.
11202 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
11204 Added overriden DocCommentHeader.
11206 Added overriden DocCommentHeader and GenerateDocComment().
11208 2004-12-01 Miguel de Icaza <miguel@ximian.com>
11210 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
11211 unwrapping the enumeration values, chain to
11212 DoConstantNumericPromotions again, so we can promote things to the
11213 fundamental types (takes care of enums that are bytes, sbytes).
11217 2004-12-01 Raja R Harinath <rharinath@novell.com>
11219 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
11220 Fix long-standing bug in type-lookup. Use FindType instead of
11221 LookupType when ec.ResolvingTypeTree.
11222 (Attribute.ResolveType, Attribute.Resolve)
11223 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
11225 (Attributes.Search): Remove internal version. Update.
11226 (Attributes.SearchMulti): Update.
11227 (Attributes.GetClsCompliantAttribute): Remove.
11228 (Attributes.GetIndexerNameAttribute): Remove.
11229 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
11230 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
11231 * class.cs (Indexer.Define): Likewise.
11233 2004-12-01 Marek Safar <marek.safar@seznam.cz>
11236 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
11237 MarshallByReference members access.
11239 * expression.cs: Use CheckMarshallByRefAccess;
11240 Better error CS0197 message.
11242 * report.cs: Print whole related error message.
11244 2004-11-30 Raja R Harinath <rharinath@novell.com>
11246 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
11247 the current directory to help debugging.
11249 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11251 * class (GetClassBases): Better error 60 report.
11252 (EventProperty): Disabled warning 67 detection.
11254 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11257 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
11259 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
11262 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11265 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
11267 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
11269 2004-11-26 Miguel de Icaza <miguel@ximian.com>
11271 * attribute.cs (Attribute.Resolve): Refine error reporting and
11272 report a cs0117 if the identifier does not exist, to distinguish
11273 from 0617 which is a miss-use of the actual identifier.
11275 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
11276 between cs0070 and cs0079.
11278 * class.cs (MemberBase.DoDefine): When reporting a wrong
11279 accessibility level, we use MethodCore to compare instead of
11280 Method (this was a regression in some refactoring effort).
11282 So now we correctly report cs0056 again.
11284 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
11285 testing the target_type (which was known to be object_type) and
11286 not the source type (which is anonymous_method).
11288 Fixed reporting of error cs1660.
11290 * expression.cs (UserCast.Source): Expose the underlying cast.
11292 * statement.cs (Switch.SwitchGoverningType): Sort the list of
11293 allowed types to find a match to int32 first (most common).
11295 In addition, it ignores any ImplicitUserConversions that did an
11296 internal implicit conversion (as the switch statement allows only
11297 one integral conversion to exist).
11299 * class.cs (PartialContainer.Create): rename `name' to
11300 `member_name' for clarity. Then replace the string calls with a
11301 call to MemberName.GetPartialName, as now using
11302 MemberName.ToString is an error (this is due to the side effects
11303 it had, that were fixed in the past).
11305 This will restore the error reporting on a number of partial class
11306 errors that were missusing this (and getting an exception as a
11307 results, which is now just a plain textual warning, because
11308 yyparse debug output would crash otherwise).
11310 2004-11-26 Raja R Harinath <rharinath@novell.com>
11312 * Makefile (PROGRAM_INSTALL_DIR): Remove.
11314 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11316 * rootcontext.cs (LookupType): Make sure to cache lookups that
11317 don't give us a negative result. This saves about 5% of corlib
11320 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11322 * report.cs (AbstractMessage.Print): messages are sent to stderr
11324 * class.cs (TypeContainer.GetClassBases): It is an error to have a
11325 non-interface in the list of interfaces (at this point, either
11326 parent was properly set, or a base class is being listed in the
11327 interfaces section).
11329 This flags error 1722, and resolves the crash from bug 69259.
11331 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11333 * statement.cs (Using.EmitExpressionFinally): make this work right
11334 for valuetypes. Fixes 69926.
11336 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11338 * const.cs (Const.ChangeType): Cope with the "0 literal can be
11339 converted to an enum" here, before we try to change the underlying
11340 type. This code exists, but it is a different code path than the
11341 one used while encoding constants.
11343 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
11344 old bug: when converting from the null literal to a pointer,
11345 return an EmptyCast, not the NullLiteral.
11347 This fixes #69921, the recent null_type changes probably made this
11348 bug more prominent.
11350 (ImplicitReferenceConversionExists): In addition, resynchronized
11351 the code here, so it matches the same code in
11352 ImplicitReferenceConversionExists for the `from any class-type S
11353 to any interface-type T'.
11356 2004-11-25 Marek Safar <marek.safar@seznam.cz>
11358 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
11360 2004-11-24 Miguel de Icaza <miguel@ximian.com>
11362 * cs-parser.jay: Use verbosity accordingly.
11364 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11366 * expression.cs (Unary.ResolveOperator): Do not report warning;
11367 AddressOf reads from variable.
11369 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
11371 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11375 * attribute.cs (Attributable): Removed CheckTargets.
11376 (Attributes.Emit): Explicit attribute targets are tested here.
11378 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
11379 not enabled for interfaces.
11381 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
11382 (GetAssemblyName): Ouch next bug there.
11384 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11386 * expression.cs: Error 275 added.
11388 2004-11-23 Marek Safar <marek.safar@seznam.cz>
11390 Fix bug #69177 (Implemented decimal constant support)
11392 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
11393 (BinaryFold): Add DecimalConstant.
11395 * const.cs (Define): Decimal constant
11397 (ChangeType): Add decimal type handling.
11398 (LookupConstantValue): Don't set value for decimal type but
11399 emit DecimalConstantAttribute. Needed for constant optimization.
11401 * constant.cs (ToDecimal): New method.
11402 (ConvertToDecimal): New method.
11403 (IntConstant): Implemented ConvertToDecimal.
11404 (DecimalConstant.Emit): Emit optimized version for decimals in
11407 * expression.cs (ResolveOperator): Changed order of constant
11408 reduction to work correctly with native types which have
11409 overloaded operators.
11410 (ResolveMemberAccess): Extract constant value from attribute
11413 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
11415 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
11416 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
11417 (ChangeType): Decimal is special.
11418 (TypeToCoreType): Add decimal type.
11420 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11422 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
11425 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11427 * class.cs (EventField.ApplyAttributeBuilder): Fix error
11430 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11432 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
11434 * pending.cs (PendingImplementation): Grab only interfaces.
11436 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11438 * statement.cs (ForeachHelperMethods): Add location member and
11439 error 202 detection.
11441 2004-11-19 Raja R Harinath <rharinath@novell.com>
11443 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
11444 automatically handled by executable.make.
11445 (PROGRAM): Make profile-specific.
11447 2004-11-18 Marek Safar <marek.safar@seznam.cz>
11449 * expression.cs (DoResolveBase): Fixed wrong warning for out
11452 2004-11-18 Martin Baulig <martin@ximian.com>
11454 Merged latest changes into gmcs. Please keep this comment in
11455 here, it makes it easier for me to see what changed in MCS since
11456 the last time I merged.
11458 2004-11-17 Raja R Harinath <rharinath@novell.com>
11460 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11461 (TypeHandle.GetMemberCache): New.
11462 (TypeHandle.TypeHandle): Update.
11463 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11464 (TypeManager.LookupParentInterfacesCache):
11465 Rename from LookupInterfaceCache. Optimize slightly.
11466 (TypeManager.MemberLookup_FindMembers): Update.
11467 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11468 multi-type variant.
11469 (AddCacheContents): Rename from AddHashtable.
11470 * class.cs (TypeContainer.parent_container): Remove.
11471 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11472 (TypeContainer.DoDefineMembers): Don't initialize it.
11473 Update to name changes.
11475 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11477 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11478 that factors the code to check access modifiers on override.
11480 (PropertyBase): Use the code here.
11482 Patch from Lluis S'anchez, fixes bug #69361.
11484 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11486 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11487 routine that is used to report the use of a captured variable
11488 whose address has been taken.
11490 There are two checks: one when variables are being captured and
11491 the other check is when the address of a variable is taken.
11493 (because an anonymous methods might be resolved before *or* after
11494 the address has been taken) and
11496 * expression.cs (Conditional.DoResolve): Remove the special
11497 casing that Martin added to trueExpr and falseExpr being both
11498 NullLiteral. We get the right behavior now just by introducing
11499 the null_type into the compiler.
11501 * convert.cs (ExplicitConversion): Change the code to use
11502 null_type instead of testing `expr is NullLiteral'.
11503 (ImplicitConversionStandard): use null_type too.
11504 (ImplicitReferenceConversionExists): use null_type too.
11505 (ImplicitReferenceConversion): use null_type too.
11507 * literal.cs: The type of `NullLiteral' is now null_type instead
11509 (Resolve): Set the type here.
11511 * typemanager.cs: Introduce null_type.
11513 2004-11-17 Martin Baulig <martin@ximian.com>
11515 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11516 direction, like FindMembers() does. Fixes #69546, testcase is in
11519 2004-11-16 Martin Baulig <martin@ximian.com>
11521 This is based on a patch from Marek Safar, see bug #69082.
11522 Fixes bugs #63705 and #67130.
11524 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11525 method; create a MemberCache for an interface type and cache the
11528 * decl.cs (IMemberContainer.ParentContainer): Removed.
11529 (IMemberContainer.ParentCache): New property.
11530 (MemberCache.SetupCacheForInterface): Removed.
11531 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11532 to create a cache for an interface's "parent".
11534 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11537 2004-11-16 Martin Baulig <martin@ximian.com>
11539 Merged back from gmcs; these changes already went into gmcs a
11540 couple of weeks ago.
11543 (TypeManager.AddUserType): Removed the `ifaces' argument.
11544 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11546 (TypeManager.AddUserInterface): Removed.
11547 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11549 (TypeManager.GetInterfaces): Likewise.
11550 (TypeManager.GetExplicitInterfaces): Likewise.
11552 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11554 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11555 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11557 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11559 * statement.cs: Avoid adding bools to a hashtable.
11561 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11563 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11564 calling an unsafe method from a safe location.
11566 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11569 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11571 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11573 * namespace.cs (VerifyUsing): use GetPartialName instead of
11576 2004-11-05 Miguel de Icaza <miguel@ximian.com>
11578 * statement.cs (Return.Resolve): Fix regression in typo: if
11579 `in_exc', we have to request a NeedReturnLabel, this was a typo
11580 introduced in the anonymous method check-in. Fixes #69131.
11582 * Indexers were using the ShortName when defining themselves,
11583 causing a regression in the compiler bootstrap when applying the
11584 patch from 2004-11-02 (first part), now they use their full name
11585 and the bug is gone.
11587 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
11589 * driver.cs: Strip the path from the names of embedded resources. Fixes
11592 2004-11-04 Raja R Harinath <rharinath@novell.com>
11594 Fix error message regression: cs0104-2.cs.
11595 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
11596 (AliasEntry.Resolve): Update.
11597 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
11599 (RootContext.LookupType): Update.
11601 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
11603 * cs-parser.jay: Add support for handling accessor modifiers
11604 * class: Add support port accessor modifiers and error checking,
11605 define PropertyMethod.Define as virtual (not abstract anymore)
11606 * ecore.cs: Add checking for proeprties access with access modifiers
11607 * iterators.cs: Modify Accessor constructor call based in the modified
11609 2004-11-02 Ben Maurer <bmaurer@ximian.com>
11611 * expression.cs (StringConcat): Handle being called twice,
11612 as when we have a concat in a field init with more than two
11615 2004-11-02 Miguel de Icaza <miguel@ximian.com>
11617 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
11618 special case explicit implementations, we should always produce
11619 the .property or .event declaration.
11621 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
11622 since it will not return correct data if people use this
11623 unresolved in the presence of using statements (see test-313).
11625 * class.cs (MethodData.Define): If we are an explicit interface
11626 implementation, set the method name to the full name of the
11627 interface plus the name of the method.
11629 Notice that using the method.MethodName.GetFullName() does not
11630 work, as it will only contain the name as declared on the source
11631 file (it can be a shorthand in the presence of using statements)
11632 and not the fully qualifed type name, for example:
11636 class D : ICloneable {
11637 object ICloneable.Clone () {
11641 Would produce a method called `ICloneable.Clone' instead of
11642 `System.ICloneable.Clone'.
11644 * namespace.cs (Alias.Resolve): Use GetPartialName.
11646 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11648 * cs-parser.jay: Add error 1055 report.
11650 2004-11-01 Miguel de Icaza <miguel@ximian.com>
11652 * assign.cs (Assign.DoResolve): Only do the transform of
11653 assignment into a New if the types are compatible, if not, fall
11654 through and let the implicit code deal with the errors and with
11655 the necessary conversions.
11657 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11659 * cs-parser.jay: Add error 1031 report.
11661 * cs-tokenizer.cs: Add location for error 1038.
11663 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11665 * cs-parser.jay: Add error 1016 report.
11667 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11669 * cs-parser.jay: Add errors 1575,1611 report.
11671 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11673 * cs-parser.jay: Add error 1001 report.
11675 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11678 * attribute.cs (GetMarshal): Add method argument for
11679 caller identification.
11681 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
11682 agument for GetMarshal and RuntimeMissingSupport.
11684 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11686 * attribute.cs (ExtractSecurityPermissionSet): Removed
11687 TypeManager.code_access_permission_type.
11689 * typemanager.cs: Removed TypeManager.code_access_permission_type.
11691 2004-10-27 Miguel de Icaza <miguel@ximian.com>
11693 * expression.cs (LocalVariableReference.DoResolveLValue): Check
11694 for obsolete use of a variable here. Fixes regression on errors
11695 cs0619-25 and cs0619-26.
11697 2004-10-27 Marek Safar <marek.safar@seznam.cz>
11699 Fix #62358, implemented security attribute encoding.
11701 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
11702 Tests permitted SecurityAction for assembly or other types.
11703 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
11704 data from SecurityPermissionAttribute to PermisionSet class.
11706 * class.cs (ApplyAttributeBuilder): Added special handling
11707 for System.Security.Permissions.SecurityAttribute based types.
11709 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
11710 special handling for System.Security.Permissions.SecurityAttribute
11713 * enum.cs (ApplyAttributeBuilder): Added special handling
11714 for System.Security.Permissions.SecurityAttribute based types.
11716 * parameter.cs (ApplyAttributeBuilder): Added special handling
11717 for System.Security.Permissions.SecurityAttribute based types.
11719 * rootcontext.cs: Next 2 core types.
11721 * typemanager.cs (TypeManager.security_permission_attr_type):
11722 Built in type for the SecurityPermission Attribute.
11723 (code_access_permission_type): Build in type.
11725 2004-10-17 Miguel de Icaza <miguel@ximian.com>
11727 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
11728 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
11729 all of this information into
11730 EmitContext.EmitCapturedVariableInstance.
11732 * codegen.cs (EmitCapturedVariableInstance): move here the
11733 funcionality of emitting an ldarg.0 in the presence of a
11734 remapping. This centralizes the instance emit code.
11736 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
11737 then emit a load of this: it means that we have reached the
11738 topmost ScopeInfo: the one that contains the pointer to the
11739 instance of the class hosting the anonymous method.
11741 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
11742 captures to the topmost CaptureContext.
11744 2004-10-12 Miguel de Icaza <miguel@ximian.com>
11746 * expression.cs (LocalVariableReference): Move the knowledge about
11747 the iterators into codegen's EmitCapturedVariableInstance.
11749 2004-10-11 Miguel de Icaza <miguel@ximian.com>
11751 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
11752 all code paths return a value from an anonymous method (it is the
11753 same as the 161 error, but for anonymous methods).
11755 2004-10-08 Miguel de Icaza <miguel@ximian.com>
11757 The introduction of anonymous methods in the compiler changed
11758 various ways of doing things in the compiler. The most
11759 significant one is the hard split between the resolution phase
11760 and the emission phases of the compiler.
11762 For instance, routines that referenced local variables no
11763 longer can safely create temporary variables during the
11764 resolution phase: they must do so from the emission phase,
11765 since the variable might have been "captured", hence access to
11766 it can not be done with the local-variable operations from the runtime.
11770 (Block.Flags): New flag `IsTopLevel' to indicate that this block
11771 is a toplevel block.
11773 (ToplevelBlock): A new kind of Block, these are the blocks that
11774 are created by the parser for all toplevel method bodies. These
11775 include methods, accessors and anonymous methods.
11777 These contain some extra information not found in regular blocks:
11778 A pointer to an optional CaptureContext (for tracking captured
11779 local variables and parameters). A pointer to the parent
11782 (Return.Resolve): Catch missmatches when returning a value from an
11783 anonymous method (error 1662).
11784 Invoke NeedReturnLabel from the Resolve phase instead of the emit
11787 (Break.Resolve): ditto.
11789 (SwitchLabel): instead of defining the labels during the
11790 resolution phase, we now turned the public ILLabel and ILLabelCode
11791 labels into methods called GetILLabelCode() and GetILLabel() that
11792 only define the label during the Emit phase.
11794 (GotoCase): Track the SwitchLabel instead of the computed label
11795 (its contained therein). Emit the code by using
11796 SwitchLabel.GetILLabelCode ().
11798 (LocalInfo.Flags.Captured): A new flag has been introduce to track
11799 whether the Local has been captured or not.
11801 (LocalInfo.IsCaptured): New property, used to tell whether the
11802 local has been captured.
11804 * anonymous.cs: Vastly updated to contain the anonymous method
11807 The main classes here are: CaptureContext which tracks any
11808 captured information for a toplevel block and ScopeInfo used to
11809 track the activation frames for various local variables.
11811 Each toplevel block has an optional capture context associated
11812 with it. When a method contains an anonymous method both the
11813 toplevel method and the anonymous method will create a capture
11814 context. When variables or parameters are captured, they are
11815 recorded on the CaptureContext that owns them, for example:
11819 MyDelegate d = delegate {
11824 Here `a' will be recorded as captured on the toplevel
11825 CapturedContext, the inner captured context will not have anything
11826 (it will only have data if local variables or parameters from it
11827 are captured in a nested anonymous method.
11829 The ScopeInfo is used to track the activation frames for local
11830 variables, for example:
11832 for (int i = 0; i < 10; i++)
11833 for (int j = 0; j < 10; j++){
11834 MyDelegate d = delegate {
11839 At runtime this captures a single captured variable `i', but it
11840 captures 10 different versions of the variable `j'. The variable
11841 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
11842 recorded on a child.
11844 The toplevel ScopeInfo will also track information like the `this'
11845 pointer if instance variables were referenced (this is necessary
11846 as the anonymous method lives inside a nested class in the host
11847 type of the method).
11849 (AnonymousMethod): Expanded to track the Toplevel, implement
11850 `AnonymousMethod.Compatible' to tell whether an anonymous method
11851 can be converted to a target delegate type.
11853 The routine now also produces the anonymous method content
11855 (AnonymousDelegate): A helper class that derives from
11856 DelegateCreation, this is used to generate the code necessary to
11857 produce the delegate for the anonymous method that was created.
11859 * assign.cs: API adjustments for new changes in
11860 Convert.ImplicitStandardConversionExists.
11862 * class.cs: Adjustments to cope with the fact that now toplevel
11863 blocks are of type `ToplevelBlock'.
11865 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
11866 insteda of standard blocks.
11868 Flag errors if params arguments are passed to anonymous methods.
11870 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
11871 `CurrentAnonymousMethod' which points to the current Anonymous
11872 Method. The variable points to the AnonymousMethod class that
11873 holds the code being compiled. It is set in the new EmitContext
11874 created for the anonymous method.
11876 (EmitContext.Phase): Introduce a variable and an enumeration to
11877 assist in enforcing some rules about when and where we are allowed
11878 to invoke certain methods (EmitContext.NeedsReturnLabel is the
11879 only one that enfonces this right now).
11881 (EmitContext.HaveCaptureInfo): new helper method that returns
11882 whether we have a CapturedContext initialized.
11884 (EmitContext.CaptureVariable): New method used to register that a
11885 LocalInfo must be flagged for capturing.
11887 (EmitContext.CapturedParameter): New method used to register that a
11888 parameters must be flagged for capturing.
11890 (EmitContext.CapturedField): New method used to register that a
11891 field must be flagged for capturing.
11893 (EmitContext.HaveCapturedVariables,
11894 EmitContext.HaveCapturedFields): Return whether there are captured
11895 variables or fields.
11897 (EmitContext.EmitMethodHostInstance): This is used to emit the
11898 instance for the anonymous method. The instance might be null
11899 (static methods), this (for anonymous methods that capture nothing
11900 and happen to live side-by-side with the current method body) or a
11901 more complicated expression if the method has a CaptureContext.
11903 (EmitContext.EmitTopBlock): Routine that drives the emission of
11904 code: it will first resolve the top block, then emit any metadata
11905 and then emit the code. The split is done so that we can extract
11906 any anonymous methods and flag any captured variables/parameters.
11908 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
11909 during this phase, the ILGenerator should not be used as labels
11910 and local variables declared here might not be accessible to any
11911 code that is part of an anonymous method.
11913 Exceptions to this include the temporary variables that are
11914 created by some statements internally for holding temporary
11917 (EmitContext.EmitMeta): New routine, in charge of emitting all the
11920 (EmitContext.TemporaryReturn): This method is typically called
11921 from the Emit phase, and its the only place where we allow the
11922 ReturnLabel to be defined other than the EmitMeta. The reason is
11923 that otherwise we would have to duplicate a lot of logic in the
11924 Resolve phases of various methods that today is on the Emit
11927 (EmitContext.NeedReturnLabel): This no longer creates the label,
11928 as the ILGenerator is not valid during the resolve phase.
11930 (EmitContext.EmitThis): Extended the knowledge in this class to
11931 work in anonymous methods in addition to iterators.
11933 (EmitContext.EmitCapturedVariableInstance): This emits whatever
11934 code is necessary on the stack to access the instance to a local
11935 variable (the variable will be accessed as a field).
11937 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
11938 EmitContext.EmitAddressOfParameter): Routines to support
11939 parameters (not completed at this point).
11941 Removals: Removed RemapLocal and RemapLocalLValue. We probably
11942 will also remove the parameters.
11944 * convert.cs (Convert): Define a `ConstantEC' which points to a
11945 null. This is just to prefity some code that uses
11946 ImplicitStandardConversion code and do not have an EmitContext
11949 The idea is to flag explicitly that at that point in time, it is
11950 known that the conversion will not trigger the delegate checking
11951 code in implicit conversions (which requires a valid
11954 Everywhere: pass new EmitContext parameter since
11955 ImplicitStandardConversionExists now requires it to check for
11956 anonymous method conversions.
11958 (Convert.ImplicitStandardConversionExists): If the type of an
11959 expression is the anonymous_method_type, and the type is a
11960 delegate, we invoke the AnonymousMethod.Compatible method to check
11961 whether an implicit conversion is possible.
11963 (Convert.ImplicitConversionStandard): Only do implicit method
11964 group conversions if the language level is not ISO_1.
11966 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
11967 MethodInfo for the Invoke method. used by Delegate and
11970 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
11971 method conversions if the target type is a delegate.
11973 Removed extra debugging nops.
11975 (LocalVariableReference): Turn the `local_info' into a public
11978 Add `prepared' field, the same hack used for FieldExprs to cope
11979 with composed assignments, as Local variables do not necessarily
11980 operate purely on the stack as they used to: they can be captured
11983 Add `temp' for a temporary result, like fields.
11985 Refactor DoResolve and DoResolveLValue into DoResolveBase.
11987 It now copes with Local variables that are captured and emits the
11988 proper instance variable to load it from a field in the captured
11991 (ParameterReference.DoResolveBase): During the resolve phase,
11992 capture parameters if we are in an anonymous method.
11994 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
11995 anonymous method, use the EmitContext helper routines to emit the
11996 parameter reference.
11998 * iterators.cs: Set RemapToProxy to true/false during the
12001 * parameters.cs (GetParameterByName): New helper method.
12003 * typemanager.cs (anonymous_method_type) a new type that
12004 represents an anonyous method. This is always an internal type,
12005 used as a fencepost to test against the anonymous-methodness of an
12008 2004-10-20 Marek Safar <marek.safar@seznam.cz>
12010 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
12012 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
12014 2004-10-18 Martin Baulig <martin@ximian.com>
12016 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
12017 `Type' directly, but call ResolveType() on it.
12018 (Catch.Resolve): Likewise.
12019 (Foreach.Resolve): Likewise.
12021 2004-10-18 Martin Baulig <martin@ximian.com>
12023 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
12024 `Type' directly, but call ResolveType() on it.
12025 (Probe.DoResolve): Likewise.
12026 (ArrayCreation.LookupType): Likewise.
12027 (TypeOf.DoResolve): Likewise.
12028 (SizeOf.DoResolve): Likewise.
12030 2004-10-18 Martin Baulig <martin@ximian.com>
12032 * expression.cs (Invocation.BetterFunction): Put back
12033 TypeManager.TypeToCoreType().
12035 2004-10-18 Raja R Harinath <rharinath@novell.com>
12037 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
12040 2004-10-18 Martin Baulig <martin@ximian.com>
12042 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
12043 `Type' directly, but call ResolveType() on it.
12045 2004-10-18 Martin Baulig <martin@ximian.com>
12047 * class.cs (FieldMember.Define): Don't access the TypeExpr's
12048 `Type' directly, but call ResolveType() on it.
12049 (MemberBase.DoDefine): Likewise.
12051 * expression.cs (New.DoResolve): Don't access the TypeExpr's
12052 `Type' directly, but call ResolveType() on it.
12053 (ComposedCast.DoResolveAsTypeStep): Likewise.
12055 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
12056 `Type' directly, but call ResolveType() on it.
12058 2004-10-17 John Luke <john.luke@gmail.com>
12060 * class.cs (Operator.GetSignatureForError): use CSharpName
12062 * parameter.cs (Parameter.GetSignatureForError): Returns
12063 correct name even if was not defined.
12065 2004-10-13 Raja R Harinath <rharinath@novell.com>
12068 * class.cs (TypeContainer.EmitContext): New property.
12069 (DefineNestedTypes): Create an emitcontext for each part.
12070 (MethodCore.DoDefineParameters): Use container's emitcontext.
12071 Pass type array to InternalParameters.
12072 (MemberBase.DoDefine): Use container's emitcontext.
12073 (FieldMember.Define): Likewise.
12074 (Event.Define): Likewise.
12075 (SetMethod.GetParameterInfo): Change argument to EmitContext.
12076 Pass type array to InternalParameters.
12077 (SetIndexerMethod.GetParameterInfo): Likewise.
12078 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
12079 * delegate.cs (Define): Pass emitcontext to
12080 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
12081 array to InternalParameters.
12082 * expression.cs (ParameterReference.DoResolveBase): Pass
12083 emitcontext to GetParameterInfo.
12084 (ComposedCast.DoResolveAsTypeStep): Remove check on
12085 ec.ResolvingTypeTree.
12086 * parameter.cs (Parameter.Resolve): Change argument to
12087 EmitContext. Use ResolveAsTypeTerminal.
12088 (Parameter.GetSignature): Change argument to EmitContext.
12089 (Parameters.ComputeSignature): Likewise.
12090 (Parameters.ComputeParameterTypes): Likewise.
12091 (Parameters.GetParameterInfo): Likewise.
12092 (Parameters.ComputeAndDefineParameterTypes): Likewise.
12093 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
12094 * support.cs (InternalParameters..ctor): Remove variant that takes
12096 * typemanager.cs (system_intptr_expr): New.
12097 (InitExpressionTypes): Initialize it.
12099 2004-10-12 Chris Toshok <toshok@ximian.com>
12101 * cs-parser.jay: fix location for try_statement and catch_clause.
12103 2004-10-11 Martin Baulig <martin@ximian.com>
12105 * report.cs: Don't make --fatal abort on warnings, we have
12106 -warnaserror for that.
12108 2004-10-07 Raja R Harinath <rharinath@novell.com>
12110 More DeclSpace.ResolveType avoidance.
12111 * decl.cs (MemberCore.InUnsafe): New property.
12112 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
12113 with newly created EmitContext.
12114 (FieldMember.Define): Likewise.
12115 * delegate.cs (Delegate.Define): Likewise.
12116 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
12117 only if normal name-lookup fails.
12118 (TypeExpr.DoResolve): Enable error-checking.
12119 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
12120 (SizeOf.DoResolve): Likewise.
12121 (ComposedCast.DoResolveAsTypeStep): Likewise.
12122 (StackAlloc.DoResolve): Likewise.
12123 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
12124 (Block.Unsafe): New property.
12125 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
12126 (Unsafe): Set 'unsafe' flag of contained block.
12127 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
12128 (Fixed.Resolve): Likewise.
12129 (Catch.Resolve): Likewise.
12130 (Using.ResolveLocalVariableDecls): Likewise.
12131 (Foreach.Resolve): Likewise.
12133 2004-10-05 John Luke <john.luke@gmail.com>
12135 * cs-parser.jay: add location to error CS0175
12137 2004-10-04 Miguel de Icaza <miguel@ximian.com>
12139 * ecore.cs (Expression.Constantity): Add support for turning null
12142 * const.cs (Const.Define): Allow constants to be reference types
12143 as long as the value is Null.
12145 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
12147 * namespace.cs (NamespaceEntry.Using): No matter which warning
12148 level is set, check if this namespace name has already been added.
12150 2004-10-03 Ben Maurer <bmaurer@ximian.com>
12152 * expression.cs: reftype [!=]= null should always use br[true,false].
12155 2004-10-03 Marek Safar <marek.safar@seznam.cz>
12158 * attribute.cs: Enum conversion moved to
12159 GetAttributeArgumentExpression to be applied to the all
12162 2004-10-01 Raja R Harinath <rharinath@novell.com>
12164 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
12165 * class.c (TypeContainer.DefineType): Flag error if
12166 base types aren't accessible due to access permissions.
12167 * decl.cs (DeclSpace.ResolveType): Move logic to
12168 Expression.ResolveAsTypeTerminal.
12169 (DeclSpace.ResolveTypeExpr): Thin layer over
12170 Expression.ResolveAsTypeTerminal.
12171 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
12172 Refactor code into NestedAccess. Use it.
12173 (DeclSpace.NestedAccess): New.
12174 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
12175 argument to silence errors. Check access permissions.
12176 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
12177 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
12178 (Cast.DoResolve): Likewise.
12179 (New.DoResolve): Likewise.
12180 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
12181 (TypeOf.DoResolve): Likewise.
12183 * expression.cs (Invocation.BetterConversion): Return the Type of
12184 the better conversion. Implement section 14.4.2.3 more faithfully.
12185 (Invocation.BetterFunction): Make boolean. Make correspondence to
12186 section 14.4.2.2 explicit.
12187 (Invocation.OverloadResolve): Update.
12188 (Invocation): Remove is_base field.
12189 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
12190 (Invocation.Emit): Likewise.
12192 2004-09-27 Raja R Harinath <rharinath@novell.com>
12194 * README: Update to changes.
12196 2004-09-24 Marek Safar <marek.safar@seznam.cz>
12198 * cs-parser.jay: Reverted 642 warning fix.
12200 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12203 * decl.cs (FindMemberWithSameName): Indexer can have more than
12206 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12208 * expression.cs (LocalVariableReference.DoResolveLValue):
12209 Do not report warning 219 for out values.
12210 (EmptyExpression.Null): New member to avoid extra allocations.
12212 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12214 * cs-parser.jay: Fix wrong warning 642 report.
12216 * cs-tokenizer.cs (CheckNextToken): New helper;
12217 Inspect next character if is same as expected.
12219 2004-09-23 Martin Baulig <martin@ximian.com>
12221 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
12222 (Convert.ImplicitReferenceConversionExists): Likewise.
12224 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12226 * class.cs (Operator.Define): Add error 448 and 559 report.
12228 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12230 * class.cs (MemberBase.IsTypePermitted): New protected
12231 method for checking error CS0610.
12233 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12235 * class.cs (TypeContainer.HasExplicitLayout): New property
12236 Returns whether container has StructLayout attribute set Explicit.
12237 (FieldMember): New abstract class for consts and fields.
12238 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
12239 (Field): Reuse FieldMember.
12241 * const.cs (Const): Reuse FieldMember.
12243 * rootcontext.cs: EmitConstants call moved to class.
12245 2004-09-22 Martin Baulig <martin@ximian.com>
12247 Thanks to Peter Sestoft for this bug report.
12249 * expression.cs (Conditional): If both the `trueExpr' and the
12250 `falseExpr' is a NullLiteral, return a NullLiteral.
12252 2004-09-22 Martin Baulig <martin@ximian.com>
12254 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
12255 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
12256 for the "get_Current" call.
12258 2004-09-22 Martin Baulig <martin@ximian.com>
12260 Marek and me just fixed one of our oldest bugs: #28562 :-)
12262 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
12264 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
12265 we're an EnumConstant, just return that.
12266 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
12267 an EnumConstant. In this case, we need to use GetValueAsEnumType()
12268 to get the value which'll actually be written into the attribute.
12269 However, we have to use GetValue() to access the attribute's value
12272 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12274 * constant.cs (Constant.IsNegative): New abstract property
12277 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
12278 (StackAlloc.DoResolve): Reused IsNegative.
12280 2004-09-21 Martin Baulig <martin@ximian.com>
12282 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
12283 if we're used in an iterator, we may be called from different
12286 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
12287 we actually have an exception block.
12289 2004-09-20 John Luke <jluke@cfl.rr.com>
12291 * class.cs, cs-parser.jay: Improve the error report for 1520:
12292 report the actual line where the error happens, not where the
12293 class was declared.
12295 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
12296 Pass location information that was available elsewhere.
12298 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
12300 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
12301 runtime to delay sign assemblies.
12303 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12305 * cs-parser.jay: Do not report the stack trace, this is barely
12308 2004-08-22 John Luke <john.luke@gmail.com>
12310 * driver.cs : check that a resource id is not already used
12311 before adding it, report CS1508 if it is, bug #63637
12313 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12315 * ecore.cs: Removed dead code.
12317 2004-09-18 Marek Safar <marek.safar@seznam.cz>
12319 * class.cs: Do not report warning CS0067 on the interfaces.
12321 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12323 * cs-parser.jay: Add error 504 report.
12325 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12327 * rootcontext.cs: WarningLevel is 4 by default now.
12329 * statement.cs (Fixed.Resolve): Do not null
12332 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12335 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
12336 deep search when property is not virtual.
12337 (PropertyExpr.ResolveAccessors): Make one call for both
12340 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12343 * statement.cs: Error 152 report constains also location.
12345 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12348 * const.cs: Explicitly set constant as static.
12350 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12353 * cs-parser.jay: Add error 1017 report.
12355 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12357 Fixed bug #59980, #64224
12358 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
12360 * typemanager.cs (IsSpecialMethod): Simplified
12362 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12364 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
12365 condition with better params.
12367 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12370 * attribute.cs (Resolve): Property has to have both
12373 2004-09-14 Martin Baulig <martin@ximian.com>
12375 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
12377 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12380 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
12381 called and is obsolete then this member suppress message
12382 when call is inside next [Obsolete] method or type.
12384 * expression.cs: Use TestObsoleteMethodUsage member.
12386 2004-09-14 Martin Baulig <martin@ximian.com>
12388 * cs-parser.jay: Sync a bit with the GMCS version.
12390 2004-09-14 Martin Baulig <martin@ximian.com>
12392 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
12393 (CSharpParser.yacc_verbose_flag): New public field.
12395 * genericparser.cs: Removed.
12397 2004-09-14 Raja R Harinath <rharinath@novell.com>
12399 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
12401 2004-09-13 Marek Safar <marek.safar@seznam.cz>
12403 * class.cs (MethodCore.CheckBase): Fix bug #65757.
12405 2004-09-10 Martin Baulig <martin@ximian.com>
12407 Backported my MemberName changes from GMCS into MCS.
12409 - we are now using a special `MemberName' class instead of using
12410 strings; in GMCS, the `MemberName' also contains the type
12413 - changed the grammar rules a bit:
12414 * the old `member_name' is now a `namespace_or_type_name':
12415 The rule is that we use `namespace_or_type_name' everywhere
12416 where we expect either a "member name" (GetEnumerator) or a
12417 "member name" with an explicit interface name
12418 (IEnumerable.GetEnumerator).
12419 In GMCS, the explicit interface name may include type arguments
12420 (IEnumerable<T>.GetEnumerator).
12421 * we use `member_name' instead of just `IDENTIFIER' for
12423 The rule is that we use `member_name' wherever a member may
12424 have type parameters in GMCS.
12426 * decl.cs (MemberName): New public class.
12427 (MemberCore.MemberName): New public readonly field.
12428 (MemberCore.ctor): Take a `MemberName' argument, not a string.
12429 (DeclSpace): Likewise.
12431 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
12432 * enum.cs (Enum.ctor): Likewise.
12434 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
12436 (AliasEntry.ctor): Take a MemberName, not an Expression.
12437 (AliasEntry.UsingAlias): Likewise.
12439 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
12440 (IMethodData.MemberName): Changed type from string to MemberName.
12441 (MemberBase.ExplicitInterfaceName): Likewise.
12442 (AbstractPropertyEventMethod.SetupName): Make this private.
12443 (AbstractPropertyEventMethod.ctor): Added `string prefix'
12444 argument; compute the member name here.
12445 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
12446 on the `member.MemberName' and the `prefix'.
12448 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
12450 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
12451 thus, we get a `MemberName' instead of a `string'. These
12452 declarations may have type parameters in GMCS.
12453 (interface_method_declaration, delegate_declaration): Likewise.
12454 (class_declaration, interface_declaration): Likewise.
12455 (method_header): Use `namespace_or_type_name' instead of
12456 `member_name'. We may be an explicit interface implementation.
12457 (property_declaration, event_declaration): Likewise.
12458 (member_name): This is now just an `IDENTIFIER', not a
12459 `namespace_or_type_name'.
12460 (type_name, interface_type): Removed.
12461 (namespace_or_type_name): Return a MemberName, not an Expression.
12462 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12463 call GetTypeExpression() on the MemberName to get an expression.
12464 (IndexerDeclaration.interface_type): Changed type from string to
12466 (MakeName): Operate on MemberName's instead of string's.
12468 2004-09-13 Raja R Harinath <rharinath@novell.com>
12471 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12472 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12473 lookup to avoid symbols introduced by 'using'.
12474 * rootcontext.cs (NamespaceLookup): Update.
12476 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12478 * class.cs (TypeContainer.DoDefineMembers): Do not call
12479 DefineDefaultConstructor for static classes.
12481 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12483 * attribute.cs (Attribute.Resolve): Add error 653 report.
12485 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12487 (Method.ApplyAttributeBuilder): Add error 685 report.
12488 (Operator.Define): Add error 564 report.
12490 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12492 * expression.cs (Invocation.DoResolve): Add error
12493 245 and 250 report.
12495 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12498 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12500 * class.cs (ConstructorInitializer.Resolve):
12501 Wrong error number (515->516).
12503 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12505 * class.cs (Indexer.Define): Add error 631 report.
12507 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12509 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12511 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12513 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12515 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12517 * cs-parser.jay: Added error CS0241 report.
12519 2004-09-10 Raja R Harinath <rharinath@novell.com>
12521 * cs-parser.jay (fixed_statement): Introduce a scope for the
12522 declaration in the 'fixed' statement.
12524 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12526 * cs-parser.jay: Added CS0230 error report.
12528 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12530 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12532 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12534 * expression.cs (Argument.Resolve): Added error CS0192 and
12537 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12539 C# 2.0 #pragma warning feature
12541 * cs-tokenizer.cs (PreProcessPragma): New method;
12542 Handles #pragma directive.
12544 * report.cs (WarningRegions): New class; Support
12545 class for #pragma warning directive. It tests whether
12546 warning is enabled for a given line.
12548 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12550 * const.cs: Add more descriptive error report, tahnks to
12553 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12555 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12557 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12559 * expression.cs: Apply patch from Ben: Remove dead code from
12560 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12561 as that code just threw an exception anwyays.
12563 * const.cs: Remove the call to the turnintoconstant, for details
12566 * literal.cs: The type of the null-literal is the null type; So
12567 we use a placeholder type (literal.cs:System.Null, defined here)
12570 * expression.cs (Conditional.DoResolve): Remove some old code that
12571 is no longer needed, conversions have been fixed.
12573 (ArrayCreationExpression.DoResolve): Return false if we fail to
12574 resolve the inner expression.
12576 2004-09-07 Raja R Harinath <rharinath@novell.com>
12579 * cs-parser.jay (delegate_declaration): Record a delegate
12580 declaration as a type declaration.
12581 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
12583 2004-09-06 Miguel de Icaza <miguel@ximian.com>
12585 * parameter.cs: Do not crash if the type can not be resolved.
12587 * expression.cs: Report errors with unsafe pointers, fixes #64896
12589 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
12591 * expression.cs: Pointer arith always needs to do a conv.i
12592 if the operand is a long. fix 65320
12594 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12596 Fixed cs0619-37.cs, cs0619-38.cs
12598 * enum.cs (GetObsoleteAttribute): Removed.
12600 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
12601 on Enum member is double staged. The first is tested member
12604 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12606 Fixed #56986, #63631, #65231
12608 * class.cs: (TypeContainer.AddToMemberContainer): New method,
12609 adds member to name container.
12610 (TypeContainer.AddToTypeContainer): New method, adds type to
12612 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
12613 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
12614 AddOperator): Simplified by reusing AddToMemberContainer.
12615 (TypeContainer.UserDefinedStaticConstructor): Changed to property
12617 (Method.CheckForDuplications): Fixed implementation to test all
12619 (MemberBase): Detection whether member is explicit interface
12620 implementation is now in constructor.
12621 (MemberBase.UpdateMemberName): Handles IndexerName.
12622 (Accessor): Changed to keep also location information.
12623 (AbstractPropertyEventMethod): Is derived from MemberCore.
12624 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
12625 will be emited or not.
12626 (PropertyBase.AreAccessorsDuplicateImplementation):
12627 Tests whether accessors are not in collision with some method.
12628 (Operator): Is derived from MethodCore to simplify common
12631 * decl.cs (Flags.TestMethodDuplication): Test for duplication
12633 (DeclSpace.AddToContainer): Adds the member to defined_names
12634 table. It tests for duplications and enclosing name conflicts.
12636 * enum.cs (EnumMember): Clean up to reuse the base structures
12638 2004-09-03 Martin Baulig <martin@ximian.com>
12640 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
12641 into TypeContainer, to make partial classes work again.
12643 2004-09-03 Martin Baulig <martin@ximian.com>
12645 * rootcontext.cs (RootContext.V2): Removed.
12647 2004-03-23 Martin Baulig <martin@ximian.com>
12649 * expression.cs (Invocation.OverloadResolve): Added `bool
12650 may_fail' argument and use it instead of the Location.IsNull() hack.
12652 2004-09-03 Martin Baulig <martin@ximian.com>
12654 Merged latest changes into gmcs. Please keep this comment in
12655 here, it makes it easier for me to see what changed in MCS since
12656 the last time I merged.
12658 2004-09-03 Raja R Harinath <rharinath@novell.com>
12661 * expression.cs (BetterConversion): Don't allow either conversion
12662 to be null. Remove redundant implicit conversion test when 'q ==
12663 null' -- when this function is invoked, we already know that the
12664 implicit conversion exists.
12665 (BetterFunction): Assume that 'best' is non-null. Remove
12666 redundant reimplementation of IsApplicable when 'best' is null.
12667 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
12668 number of arguments.
12669 (IsAncestralType): Extract from OverloadResolve.
12670 (OverloadResolve): Make robust to the MethodGroupExpr being
12671 unsorted. Implement all the logic of Section 14.5.5.1, and
12672 support overloading of methods from multiple applicable types.
12673 Clean up logic somewhat. Don't pass null methods to BetterFunction.
12675 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
12676 (RealError, Warning): Append type of report to related symbol.
12678 2004-09-03 Marek Safar <marek.safar@seznam.cz>
12680 * enum.cs: Fixed CLS-Compliance checks for enum members.
12681 Error tests cs3008-8.cs, cs3014-8.cs
12683 2004-09-02 Marek Safar <marek.safar@seznam.cz>
12685 Fixed bug #62342, #63102
12686 * class.cs: ImplementIndexer uses member.IsExplicitImpl
12687 like ImplementMethod.
12689 2004-09-02 Marek Safar <marek.safar@seznam.cz>
12691 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12694 2004-09-02 Martin Baulig <martin@ximian.com>
12696 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
12697 TypeManager.GetArgumentTypes() rather than calling GetParameters()
12700 2004-09-01 Marek Safar <marek.safar@seznam.cz>
12702 C# 2.0 Static classes implemented
12704 * class.cs (TypeContainer): instance_constructors,
12705 initialized_fields, initialized_static_fields,
12706 default_constructor, base_inteface_types are protected to be
12707 accessible from StaticClass.
12708 (TypeContainer.DefineDefaultConstructor): New virtual method
12709 for custom default constructor generating
12710 (StaticClass): New class to handle "Static classes" feature.
12712 * cs-parser.jay: Handle static keyword on class like instance
12715 * driver.cs: Added "/langversion" command line switch with two
12716 options (iso-1, default).
12718 2004-08-31 Marek Safar <marek.safar@seznam.cz>
12720 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
12722 2004-08-31 Miguel de Icaza <miguel@ximian.com>
12724 * delegate.cs: Style.
12726 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
12728 * delegate.cs: Add seperate instance expr field for miguel.
12730 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
12732 * PointerArithmetic (Resolve): make sure we are not doing
12733 pointer arith on void*. Also, make sure we are resolved
12734 by not setting eclass until resolve.
12736 All callers: Make sure that PointerArithmetic gets resolved.
12738 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
12740 * ArrayCreation (LookupType): If the type does not resolve
12741 to an array, give an error.
12743 2004-08-27 Marek Safar <marek.safar@seznam.cz>
12745 * statement.cs (Try.Resolve): Fixed bug #64222
12747 2004-08-27 Martin Baulig <martin@ximian.com>
12750 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
12753 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12755 * ecore.cs (Constantify): Get underlying type via
12756 System.Enum.GetUnderlyingType to avoid StackOverflow on the
12757 Windows in special cases.
12759 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12761 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
12762 for obtaining also private methods.
12763 (GetRemoveMethod): Used GetRemoveMethod (true)
12764 for obtaining also private methods.
12766 2004-08-24 Martin Baulig <martin@ximian.com>
12768 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
12769 MethodAttributes.HideBySig for operators.
12771 2004-08-23 Martin Baulig <martin@ximian.com>
12773 Back to the old error reporting system :-)
12775 * report.cs (Message): Removed.
12776 (Report.MessageData, ErrorData, WarningData): Removed.
12777 (Report.Error, Warning): Back to the old system.
12779 2004-08-23 Martin Baulig <martin@ximian.com>
12781 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
12783 * class.cs (TypeContainer.ParentContainer): New public virtual
12784 method; replaces the explicit interface implementation.
12785 (ClassPart.ParentContainer): Override.
12787 2004-08-23 Martin Baulig <martin@ximian.com>
12789 * statement.cs (Switch): Added support for constant switches; see
12790 #59428 or test-285.cs.
12792 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12795 * statement.cs (GetEnumeratorFilter): Removed useless
12796 logic because C# specs is strict. GetEnumerator must be
12799 2004-08-22 Martin Baulig <martin@ximian.com>
12801 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12802 a switch and may break, reset the barrier. Fixes #59867.
12804 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12806 CLS-Compliance speed up (~5% for corlib)
12808 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
12809 New method. Tests container for CLS-Compliant names
12811 * class.cs (TypeContainer.VerifyClsName): New method.
12812 Checks whether container name is CLS Compliant.
12813 (Constructor): Implements IMethodData.
12815 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
12816 low-case table for CLS Compliance test.
12817 (MemberCache.VerifyClsParameterConflict): New method.
12818 Checks method parameters for CS3006 error.
12820 * enum.cs (EnumMember): Is derived from MemberCore.
12821 (Enum.VerifyClsName): Optimized for better performance.
12823 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12825 * report.cs: Renamed Error_T to Error and changed all
12828 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12830 * class.cs (TypeContainer.IndexerArrayList): New inner class
12831 container for indexers.
12832 (TypeContainer.DefaultIndexerName): New constant for default
12833 indexer name. Replaced all "Item" with this constant.
12834 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
12836 * typemanager.cs (TypeManager.default_member_ctor): Cache here
12837 DefaultMemberAttribute constructor.
12839 2004-08-05 Martin Baulig <martin@ximian.com>
12841 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12844 2004-08-05 Marek Safar <marek.safar@seznam.cz>
12846 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
12847 multi platforms problem.
12849 * compiler.csproj: Included shared files.
12851 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12853 Fix bug 60333, 55971 in the more general way
12854 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12855 Added arg_type argument for constant conversion.
12856 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
12858 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12861 * class.cs (TypeContainer ): New inner classes MethodArrayList,
12862 OperatorArrayList, MethodCoreArrayList for typecontainer
12863 containers. Changed class member types to these new types.
12864 (MethodArrayList.DefineMembers): Added test for CS0659.
12866 2004-08-04 Miguel de Icaza <miguel@ximian.com>
12868 * cfold.cs: Synchronize the folding with the code in expression.cs
12869 Binary.DoNumericPromotions for uint operands.
12871 * attribute.cs: Revert patch from Raja, it introduced a regression
12872 while building Blam-1.2.1 (hard to isolate a test case).
12874 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12878 (TypeContainer.Define): Renamed to DefineContainerMembers because of
12880 (MethodCore.parent_method): New member. The method we're overriding
12881 if this is an override method.
12882 (MethodCore.CheckBase): Moved from Method class and made common.
12883 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
12885 (MethodCore.CheckForDuplications): New abstract method. For custom
12886 member duplication search in a container
12887 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
12888 method and its return type.
12889 (Event.conflict_symbol): New member. Symbol with same name in the
12893 (MemberCache.FindMemberWithSameName): New method. The method
12894 is looking for conflict with inherited symbols.
12896 2004-08-04 Martin Baulig <martin@ximian.com>
12898 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
12900 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
12902 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12904 * report.cs (Message): New enum for better error, warning reference in
12906 (MessageData): New inner abstract class. It generally handles printing of
12907 error and warning messages.
12908 Removed unused Error, Warning, Message methods.
12910 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12912 Fix for cs0592-8.cs test
12914 (Attributable.ValidAttributeTargets): Made public.
12915 (Attribute.ExplicitTarget): New member for explicit target value.
12916 (Attribute.CheckTargets): Now we translate explicit attribute
12917 target to Target here.
12919 2004-08-03 Ben Maurer <bmaurer@ximian.com>
12921 * ecore.cs (MethodGroupExpr): new IsBase property.
12923 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12925 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12926 rather than an instance expr.
12928 (DelegateCreation.Emit): Use the method group rather than
12929 the instance expression. Also, if you have base.Foo as the
12930 method for a delegate, make sure to emit ldftn, not ldftnvirt.
12932 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
12934 (NewDelegate.DoResolve): Only check for the existance of Invoke
12935 if the method is going to be needed. Use MethodGroupExpr.
12937 (NewDelegate.Emit): Remove, DelegateCreation implements this.
12939 * expression.cs: For pointer arith., make sure to use
12940 the size of the type, not the size of the pointer to
12943 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12946 * class.cs (Class): Added error CS0502 test.
12948 2004-08-03 John Luke <jluke@cfl.rr.com>
12949 Raja R Harinath <rharinath@novell.com>
12952 * attribute.cs (Attribute.complained_before): New flag.
12953 (Attribute.ResolveType, Attribute.Resolve),
12954 (Attribute.DefinePInvokeMethod): Set it.
12955 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
12957 2004-08-03 Martin Baulig <martin@ximian.com>
12959 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
12960 use a user-defined operator; we still need to do numeric
12961 promotions in case one argument is a builtin type and the other
12962 one has an implicit conversion to that type. Fixes #62322.
12964 2004-08-02 Martin Baulig <martin@ximian.com>
12966 * statement.cs (LocalInfo.Flags): Added `IsThis'.
12967 (LocalInfo.IsThis): New public property.
12968 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
12970 2004-08-01 Martin Baulig <martin@ximian.com>
12972 * class.cs (TypeContainer.GetClassBases): Don't set the default
12973 here since we may get called from GetPartialBases().
12974 (TypeContainer.DefineType): If GetClassBases() didn't return a
12975 parent, use the default one.
12977 2004-07-30 Duncan Mak <duncan@ximian.com>
12979 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
12981 2004-07-30 Martin Baulig <martin@ximian.com>
12983 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
12985 * class.cs (SourceMethod): New public class, derive from the
12986 symbol writer's ISourceMethod.
12987 (Method): Use the new symbol writer API.
12989 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
12990 as argument and use the new symbol writer.
12993 (SourceFile): Implement the symbol writer's ISourceFile.
12994 (Location.SymbolDocument): Removed.
12995 (Location.SourceFile): New public property.
12997 * symbolwriter.cs: Use the new symbol writer API.
12999 2004-07-30 Raja R Harinath <rharinath@novell.com>
13001 * Makefile (install-local): Remove. Functionality moved to
13004 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
13006 * Makefile: Install mcs.exe.config file together with mcs.exe.
13007 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
13008 correct runtime version.
13010 2004-07-25 Martin Baulig <martin@ximian.com>
13013 (TypeContainer.RegisterOrder): Removed, this was unused.
13014 (TypeContainer, interface_order): Removed.
13015 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
13016 TypeContainer as argument since we can also be called with a
13017 `PartialContainer' for a partial class/struct/interface.
13018 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
13019 of checking whether we're an `Interface' - we could be a
13020 `PartialContainer'.
13021 (PartialContainer.Register): Override; call
13022 AddClass()/AddStruct()/AddInterface() on our parent.
13024 * cs-parser.jay (interface_member_declaration): Add things to the
13025 `current_container', not the `current_class'.
13027 * rootcontext.cs (RegisterOrder): The overloaded version which
13028 takes an `Interface' was unused, removed.
13030 * typemanager.cs (TypeManager.LookupInterface): Return a
13031 `TypeContainer', not an `Interface'.
13032 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
13033 contain a `PartialContainer' for an interface, so check it's
13034 `Kind' to figure out what it is.
13036 2004-07-25 Martin Baulig <martin@ximian.com>
13038 * class.cs (Class.DefaultTypeAttributes): New public constant.
13039 (Struct.DefaultTypeAttributes): Likewise.
13040 (Interface.DefaultTypeAttributes): Likewise.
13041 (PartialContainer.TypeAttr): Override this and add the
13042 DefaultTypeAttributes.
13044 2004-07-25 Martin Baulig <martin@ximian.com>
13046 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
13047 we can just use the `Parent' field instead.
13049 2004-07-25 Martin Baulig <martin@ximian.com>
13051 * class.cs (TypeContainer.Emit): Renamed to EmitType().
13053 2004-07-25 Martin Baulig <martin@ximian.com>
13055 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
13056 our parts before defining any methods.
13057 (TypeContainer.VerifyImplements): Make this virtual.
13058 (ClassPart.VerifyImplements): Override and call VerifyImplements()
13059 on our PartialContainer.
13061 2004-07-25 Martin Baulig <martin@ximian.com>
13063 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
13065 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
13066 argument, we can just use the `Parent' field instead.
13069 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
13070 (MemberBase.DoDefine): Likewise.
13072 2004-07-24 Martin Baulig <martin@ximian.com>
13074 * decl.cs (MemberCore.Parent): New public field.
13075 (DeclSpace.Parent): Moved to MemberCore.
13077 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
13078 (MemberBase.ctor): Added TypeContainer argument, pass it to our
13080 (FieldBase, Field, Operator): Likewise.
13081 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
13082 (EventField, Event): Likewise.
13084 2004-07-23 Martin Baulig <martin@ximian.com>
13086 * class.cs (PartialContainer): New public class.
13087 (ClassPart): New public class.
13088 (TypeContainer): Added support for partial classes.
13089 (TypeContainer.GetClassBases): Splitted some of the functionality
13090 out into GetNormalBases() and GetPartialBases().
13092 * cs-tokenizer.cs (Token.PARTIAL): New token.
13093 (Tokenizer.consume_identifier): Added some hacks to recognize
13094 `partial', but only if it's immediately followed by `class',
13095 `struct' or `interface'.
13097 * cs-parser.jay: Added support for partial clases.
13099 2004-07-23 Martin Baulig <martin@ximian.com>
13101 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
13102 a `DeclSpace' and also made it readonly.
13103 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
13104 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
13105 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
13107 * cs-parser.jay: Pass the `current_class', not the
13108 `current_container' (at the moment, this is still the same thing)
13109 to a new Method, Property, Event, Indexer or Constructor.
13111 2004-07-23 Martin Baulig <martin@ximian.com>
13113 * cs-parser.jay (CSharpParser): Added a new `current_class' field
13114 and removed the `current_interface' one.
13115 (struct_declaration, class_declaration, interface_declaration):
13116 Set `current_class' to the newly created class/struct/interface;
13117 set their `Bases' and call Register() before parsing their body.
13119 2004-07-23 Martin Baulig <martin@ximian.com>
13121 * class.cs (Kind): New public enum.
13122 (TypeContainer): Made this class abstract.
13123 (TypeContainer.Kind): New public readonly field.
13124 (TypeContainer.CheckDef): New public method; moved here from
13126 (TypeContainer.Register): New public abstract method.
13127 (TypeContainer.GetPendingImplementations): New public abstract
13129 (TypeContainer.GetClassBases): Removed the `is_class' and
13130 `is_iface' parameters.
13131 (TypeContainer.DefineNestedTypes): Formerly known as
13133 (ClassOrStruct): Made this class abstract.
13135 * tree.cs (RootTypes): New public type.
13137 2004-07-20 Martin Baulig <martin@ximian.com>
13139 * tree.cs (Tree.RecordNamespace): Removed.
13140 (Tree.Namespaces): Removed.
13142 * rootcontext.cs (RootContext.IsNamespace): Removed.
13144 * cs-parser.jay (namespace_declaration): Just create a new
13145 NamespaceEntry here.
13147 2004-07-20 Martin Baulig <martin@ximian.com>
13149 * statement.cs (ExceptionStatement): New abstract class. This is
13150 now used as a base class for everyone who's using `finally'.
13151 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
13152 our local variables before using them.
13154 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
13155 virtual method. This is used by Yield.Resolve() to "steal" an
13156 outer block's `finally' clauses.
13157 (FlowBranchingException): The .ctor now takes an ExceptionStatement
13160 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
13161 version which takes an ExceptionStatement. This version must be
13162 used to create exception branchings.
13165 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
13166 (Iterator.EmitMoveNext): Added exception support; protect the
13167 block with a `fault' clause, properly handle 'finally' clauses.
13168 (Iterator.EmitDispose): Run all the `finally' clauses here.
13170 2004-07-20 Martin Baulig <martin@ximian.com>
13172 * iterator.cs: This is the first of a set of changes in the
13173 iterator code. Match the spec more closely: if we're an
13174 IEnumerable, then GetEnumerator() must be called. The first time
13175 GetEnumerator() is called, it returns the current instance; all
13176 subsequent invocations (if any) must create a copy.
13178 2004-07-19 Miguel de Icaza <miguel@ximian.com>
13180 * expression.cs: Resolve the constant expression before returning
13183 2004-07-19 Martin Baulig <martin@ximian.com>
13185 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
13186 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
13187 the return type of the new EmitContext.
13189 2004-07-18 Martin Baulig <martin@ximian.com>
13191 * class.cs (Property.Define): Fix iterators.
13193 * iterators.cs (Iterator.Define): Moved the
13194 `container.AddInterator (this)' call here from the .ctor; only do
13195 it if we resolved successfully.
13197 2004-07-17 Miguel de Icaza <miguel@ximian.com>
13199 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
13200 `true' for preprocessing directives that we parse. The return
13201 value indicates whether we should return to regular tokenizing or
13202 not, not whether it was parsed successfully.
13204 In the past if we were in: #if false ... #line #endif, we would
13205 resume parsing after `#line'. See bug 61604.
13207 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
13208 building: IsEnumType should return true only for enums, not for
13209 enums or System.Enum itself. This fixes #61593.
13211 Likely what happened is that corlib was wrong: mcs depended on
13212 this bug in some places. The bug got fixed, we had to add the
13213 hack, which caused bug 61593.
13215 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
13216 that was a workaround for the older conditions.
13218 2004-07-16 Ben Maurer <bmaurer@ximian.com>
13220 * assign.cs: IAssignMethod has a new interface, as documented
13221 inline. All assignment code now uses this new api.
13223 * ecore.cs, expression.cs: All classes which implement
13224 IAssignMethod now use the new interface.
13226 * expression.cs (Invocation): add a hack to EmitCall so that
13227 IndexerAccess can be the target of a compound assignment without
13228 evaluating its arguments twice.
13230 * statement.cs: Handle changes in Invocation api.
13232 2004-07-16 Martin Baulig <martin@ximian.com>
13234 * iterators.cs: Rewrote this. We're now using one single Proxy
13235 class for both the IEnumerable and the IEnumerator interface and
13236 `Iterator' derives from Class so we can use the high-level API.
13238 * class.cs (TypeContainer.AddIterator): New method.
13239 (TypeContainer.DoDefineType): New protected virtual method, which
13240 is called from DefineType().
13241 (TypeContainer.DoDefineMembers): Call DefineType() and
13242 DefineMembers() on all our iterators.
13243 (TypeContainer.Emit): Call Emit() on all our iterators.
13244 (TypeContainer.CloseType): Call CloseType() on all our iterators.
13246 * codegen.cs (EmitContext.CurrentIterator): New public field.
13248 2004-07-15 Martin Baulig <martin@ximian.com>
13251 (TypeManager.not_supported_exception_type): New type.
13253 2004-07-14 Martin Baulig <martin@ximian.com>
13255 * iterators.cs: Use real error numbers.
13257 2004-07-14 Martin Baulig <martin@ximian.com>
13259 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
13260 requires this to be a System.Collection.IEnumerable and not a
13261 class implementing that interface.
13262 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
13264 2004-07-13 Marek Safar <marek.safar@seznam.cz>
13266 * class.cs: Fixed previous fix, it broke some error tests.
13268 2004-07-12 Martin Baulig <martin@ximian.com>
13270 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
13273 2004-07-09 Miguel de Icaza <miguel@ximian.com>
13275 * assign.cs (LocalTemporary): Add new argument: is_address,If
13276 `is_address' is true, then the value that we store is the address
13277 to the real value, and not the value itself.
13279 * ecore.cs (PropertyExpr): use the new local temporary
13280 stuff to allow us to handle X.Y += z (where X is a struct)
13282 2004-07-08 Martin Baulig <martin@ximian.com>
13284 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
13285 not always return, just like we're doing in Using.Resolve().
13287 2004-07-07 Miguel de Icaza <miguel@ximian.com>
13289 * cs-parser.jay (fixed_statement): flag this as Pinned.
13291 2004-07-06 Miguel de Icaza <miguel@ximian.com>
13293 * typemanager.cs (TypeManager): Removed MakePinned method, this
13294 mechanism is replaced with the .NET 2.x compatible mechanism of
13295 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
13297 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
13298 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
13299 `IsFixed' property which has a different meaning.
13301 2004-07-02 Raja R Harinath <rharinath@novell.com>
13303 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
13304 visible from inside a nested class, not just the names of the
13305 immediately enclosing class.
13306 Fix for bug #60730.
13308 2004-06-24 Raja R Harinath <rharinath@novell.com>
13310 * expression.cs (BetterConversion): Remove buggy special-case
13311 handling of "implicit constant expression conversions". At this
13312 point, we already know that the conversion is possible -- we're
13313 only checking to see which is better.
13315 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13317 * cs-parser.jay: Added error CS0210 test.
13319 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13321 * cs-parser.jay: Added error CS0134 test.
13323 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13326 * cs-parser.jay: Added error CS0145 test.
13328 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13330 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
13332 2004-06-23 Ben Maurer <bmaurer@ximian.com>
13334 * expression.cs (StackAlloc.Resolve): The argument may not
13335 be a constant; deal with this case.
13337 2004-06-23 Marek Safar <marek.safar@seznam.cz>
13339 * attribute.cs (IndexerName_GetIndexerName): Renamed to
13340 GetIndexerAttributeValue.
13341 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
13343 * class.cs (Indexer.Define): Added error tests for CS0415,
13346 2004-06-23 Miguel de Icaza <miguel@ximian.com>
13348 * attribute.cs (Attribute.Resolve): Keep field code in sync with
13351 2004-06-23 Martin Baulig <martin@ximian.com>
13353 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
13354 neither return nor throw, reset the barrier as well. Fixes #60457.
13356 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
13358 * class.cs : EventAttributes is now set to None by default.
13359 This fixes bug #60459.
13361 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13364 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13365 Don't throw exception but return null (it's sufficient now).
13367 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13369 * typemanager.cs (GetArgumentTypes): Faster implementation.
13371 2004-06-18 Martin Baulig <martin@ximian.com>
13373 * attribute.cs (Attribute.Resolve): Check whether we're an
13374 EmptyCast which a Constant child. Fixes #60333.
13376 2004-06-17 Ben Maurer <bmaurer@ximian.com>
13378 * statement.cs (EmitCollectionForeach): Account for the fact that
13379 not all valuetypes are in areas which we can take the address of.
13380 For these variables, we store to a temporary variable. Also, make
13381 sure that we dont emit a `callvirt' on a valuetype method.
13383 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13385 * expression.cs (StackAlloc.DoReSolve): Added test for
13386 negative parameter (CS0247).
13388 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13391 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
13393 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13396 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
13399 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13401 Fix bug #58254 & cs1555.cs, cs1556.cs
13402 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
13404 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13406 * cs-parser.jay: Added error CS1669 test for indexers.
13408 2004-06-11 Martin Baulig <martin@ximian.com>
13410 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
13411 call this twice: for params and varargs methods.
13413 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13416 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
13418 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13420 * attribute.cs (Attribute.GetValidTargets): Made public.
13423 (AbstractPropertyEventMethod): New class for better code sharing.
13424 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
13426 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
13428 2004-06-11 Raja R Harinath <rharinath@novell.com>
13431 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
13432 that the call to Resolve is part of a MemberAccess.
13433 (Expression.Resolve): Use it for SimpleName resolution.
13434 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
13435 Add 'intermediate' boolean argument.
13436 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
13437 error message when the SimpleName can be resolved ambiguously
13438 between an expression and a type.
13439 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
13441 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
13442 call on the left-side.
13444 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13447 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
13449 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13451 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13453 2004-06-11 Martin Baulig <martin@ximian.com>
13455 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13456 varargs methods if applicable.
13458 2004-06-11 Martin Baulig <martin@ximian.com>
13460 * expression.cs (Invocation.EmitCall): Don't use
13461 `method.CallingConvention == CallingConventions.VarArgs' since the
13462 method could also have `CallingConventions.HasThis'.
13464 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13466 * class.cs (Event.GetSignatureForError): Implemented.
13467 Fixed crash in error test cs3010.cs
13469 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13471 * cs-tokenizer.cs: Change the way we track __arglist to be
13472 consistent with the other keywords.
13474 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13476 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13479 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13481 * codegen.cs: Check that all referenced assemblies have a strongname
13482 before strongnaming the compiled assembly. If not report error CS1577.
13483 Fix bug #56563. Patch by Jackson Harper.
13484 * typemanager.cs: Added a method to return all referenced assemblies.
13485 Fix bug #56563. Patch by Jackson Harper.
13487 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13490 (Method.ApplyAttributeBuilder): Moved and added conditional
13491 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13494 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13496 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13499 * class.cs: (EventField.attribute_targets): Changed default target.
13501 2004-06-08 Martin Baulig <martin@ximian.com>
13503 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13505 2004-06-08 Martin Baulig <martin@ximian.com>
13507 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13509 2004-06-07 Martin Baulig <martin@ximian.com>
13511 Added support for varargs methods.
13513 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13516 * cs-parser.jay: Added support for `__arglist'.
13518 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13520 * expression.cs (Argument.AType): Added `ArgList'.
13521 (Invocation): Added support for varargs methods.
13522 (ArglistAccess): New public class.
13523 (Arglist): New public class.
13525 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13527 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13528 a method's top-level block if the method has varargs.
13530 * support.cs (ReflectionParameters, InternalParameters): Added
13531 support for varargs methods.
13533 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13535 * class.cs: Provide location in indexer error report.
13537 * driver.cs: Use standard names.
13539 * namespace.cs: Catch the use of using after a namespace has been
13540 declared also on using aliases.
13542 2004-06-03 Raja R Harinath <rharinath@novell.com>
13545 * typemanager.cs (closure_private_ok, closure_invocation_type)
13546 (closure_qualifier_type, closure_invocation_assembly)
13547 (FilterWithClosure): Move to ...
13548 (Closure): New internal nested class.
13549 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13550 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13551 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13552 (MemberLookup, MemberLookupFailed): Use it.
13553 * expression.cs (New.DoResolve): Treat the lookup for the
13554 constructor as being qualified by the 'new'ed type.
13555 (Indexers.GetIndexersForTypeOrInterface): Update.
13557 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13560 (GetConditionalAttributeValue): New method. Returns
13561 condition of ConditionalAttribute.
13562 (SearchMulti): New method. Returns all attributes of type 't'.
13563 Use it when attribute is AllowMultiple = true.
13564 (IsConditionalMethodExcluded): New method.
13567 (Method.IsExcluded): Implemented. Returns true if method has conditional
13568 attribute and the conditions is not defined (method is excluded).
13569 (IMethodData): Extended interface for ConditionalAttribute support.
13570 (PropertyMethod.IsExcluded): Implemented.
13573 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
13576 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
13579 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
13581 * expression.cs (ArrayCreationExpression): Make this just an
13582 `expression'. It can't be a statement, so the code here was
13585 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13588 * typemanager.cs (GetFullNameSignature): New method for
13591 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13594 * class.cs (MemberBase.GetSignatureForError): New virtual method.
13595 Use this method when MethodBuilder is null.
13596 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
13597 Added test for error CS0626 (MONO reports error for this situation).
13598 (IMethodData.GetSignatureForError): Extended interface.
13600 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13603 (AttributeTester.GetObsoleteAttribute): Returns instance of
13604 ObsoleteAttribute when type is obsolete.
13607 (TypeContainer.VerifyObsoleteAttribute): Override.
13608 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
13609 (MethodCode.VerifyObsoleteAttribute): Override.
13610 (MemberBase.VerifyObsoleteAttribute): Override.
13613 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
13614 and report proper error.
13617 Delegate.VerifyObsoleteAttribute): Override.
13620 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
13621 and report proper error.
13622 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
13625 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
13629 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
13630 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
13631 Added test for ObsoleteAttribute.
13634 (Catch): Derived from Statement.
13636 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13638 Fixed bug #59071 & cs0160.cs
13640 * statement.cs (Try.Resolve): Check here whether order of catch
13641 clauses matches their dependencies.
13643 2004-05-31 Miguel de Icaza <miguel@ximian.com>
13645 * Reverted patch to namespace.cs (Use lookuptypedirect). This
13646 caused a regression: #59343. Referencing nested classes from an
13647 assembly stopped working.
13649 2004-05-31 Martin Baulig <martin@ximian.com>
13651 MCS is now frozen for beta 2.
13653 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13655 * convert.cs: add a trivial cache for overload operator resolution.
13657 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13659 * decl.cs: If possible, use lookuptypedirect here. We can only do
13660 this if there is no `.' after the namespace. Avoids using
13661 LookupType, which does lots of slow processing.
13662 (FindNestedType) New method, does what it says :-).
13663 * namespace.cs: use LookupTypeDirect.
13664 * rootcontext.cs: use membercache, if possible.
13665 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
13667 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13670 According to the spec,
13672 In a member access of the form E.I, if E is a single identifier,
13673 and if the meaning of E as a simple-name (§7.5.2) is a constant,
13674 field, property, localvariable, or parameter with the same type as
13675 the meaning of E as a type-name (§3.8), then both possible
13676 meanings of E are permitted.
13678 We did not check that E as a simple-name had the same type as E as
13681 This trivial check gives us 5-7% on bootstrap time.
13683 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13685 * expression.cs (Invocation.OverloadResolve): Avoid the
13686 use of hashtables and boxing here by allocating on demand.
13688 2004-05-30 Martin Baulig <martin@ximian.com>
13690 * rootcontext.cs (RootContext.LookupType): Don't cache things if
13691 we're doing a silent lookup. Don't try to lookup nested types in
13692 TypeManager.object_type (thanks to Ben Maurer).
13694 2004-05-30 Martin Baulig <martin@ximian.com>
13696 Committing a patch from Ben Maurer.
13698 * rootcontext.cs (RootContext.LookupType): Cache negative results.
13700 2004-05-29 Martin Baulig <martin@ximian.com>
13702 * class.cs (IMethodData.ShouldIgnore): New method.
13704 * typemanager.cs (TypeManager.MethodFlags): Don't take a
13705 `Location' argument, we don't need it anywhere. Use
13706 `IMethodData.ShouldIgnore ()' instead of
13707 `MethodData.GetMethodFlags ()'.
13708 (TypeManager.AddMethod): Removed.
13709 (TypeManager.AddMethod2): Renamed to AddMethod.
13711 2004-05-29 Martin Baulig <martin@ximian.com>
13713 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
13715 * convert.cs (Convert.ImplicitReferenceConversion): If we're
13716 converting from a class type S to an interface type and we already
13717 have an object on the stack, don't box it again. Fixes #52578.
13719 2004-05-29 Martin Baulig <martin@ximian.com>
13721 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13722 Added support for `params' parameters. Fixes #59267.
13724 2004-05-29 Martin Baulig <martin@ximian.com>
13726 * literal.cs (NullPointer): Provide a private .ctor which sets
13727 `type' to TypeManager.object_type. Fixes #59048.
13729 2004-05-29 Martin Baulig <martin@ximian.com>
13731 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
13732 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
13734 * ecore.cs (EventExpr.instance_expr): Make the field private.
13736 2004-05-26 Marek Safar <marek.safar@seznam.cz>
13738 Fixed bug #50080 & cs0214-2.cs
13739 * expression.cs (Cast.DoResolve): Check unsafe context here.
13741 * statement.cs (Resolve.DoResolve): Likewise.
13743 2004-05-26 Martin Baulig <martin@ximian.com>
13745 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
13747 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
13748 (RootContext.LookupType): Pass down the `silent' flag.
13750 2004-05-25 Martin Baulig <martin@ximian.com>
13753 (MethodGroupExpr.IdenticalTypeName): New public property.
13754 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
13755 expression actually refers to a type.
13757 2004-05-25 Martin Baulig <martin@ximian.com>
13759 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
13760 for #56176 and made it actually work.
13762 2004-05-25 Martin Baulig <martin@ximian.com>
13764 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
13765 (FieldExpr, PropertyExpr): Override and implement
13766 CacheTemporaries. Fixes #52279.
13768 2004-05-25 Miguel de Icaza <miguel@ximian.com>
13770 * location.cs: In the new compiler listing a file twice is a
13771 warning, not an error.
13773 2004-05-24 Martin Baulig <martin@ximian.com>
13775 * enum.cs (Enum.DefineType): For the `BaseType' to be a
13776 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
13778 2004-05-24 Martin Baulig <martin@ximian.com>
13780 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
13781 walking the `using' list. Fixes #53921.
13783 2004-05-24 Martin Baulig <martin@ximian.com>
13785 * const.cs (Const.LookupConstantValue): Added support for
13786 EmptyCast's; fixes #55251.
13788 2004-05-24 Martin Baulig <martin@ximian.com>
13790 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
13791 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
13792 which does the CS0135 check. The reason is that we first need to
13793 check whether the variable actually exists.
13795 2004-05-24 Martin Baulig <martin@ximian.com>
13797 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
13798 than RootContext.LookupType() to find the explicit interface
13799 type. Fixes #58584.
13801 2004-05-24 Raja R Harinath <rharinath@novell.com>
13803 * Makefile: Simplify. Use executable.make.
13804 * mcs.exe.sources: New file. List of sources of mcs.exe.
13806 2004-05-24 Anders Carlsson <andersca@gnome.org>
13810 Use the invariant culture when doing String.Compare for CLS case
13813 2004-05-23 Martin Baulig <martin@ximian.com>
13815 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
13816 don't have any dots. Fixes #52622, added cs0246-8.cs.
13818 * namespace.cs (NamespaceEntry.Lookup): Likewise.
13820 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13822 * class.cs (MemberBase.Define): Reuse MemberType member for
13823 resolved type. Other methods can use it too.
13825 2004-05-23 Martin Baulig <martin@ximian.com>
13827 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
13828 the variable also exists in the current block (otherwise, we need
13829 to report a CS0103). Fixes #58670.
13831 2004-05-23 Martin Baulig <martin@ximian.com>
13833 * flowanalysis.cs (Reachability.Reachable): Compute this
13834 on-the-fly rather than storing it as a field.
13836 2004-05-23 Martin Baulig <martin@ximian.com>
13838 * flowanalysis.cs (Reachability.And): Manually compute the
13839 resulting `barrier' from the reachability.
13841 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13844 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
13845 instance of ObsoleteAttribute when symbol is obsolete.
13848 (IMethodData): Extended interface for ObsoleteAttribute support.
13850 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13852 * attribute.cs: Fix bug #55970
13854 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13858 (GetObsoleteAttribute): New method. Creates the instance of
13860 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
13861 ObsoleteAttribute when member is obsolete.
13862 (AttributeTester.Report_ObsoleteMessage): Common method for
13863 Obsolete error/warning reporting.
13866 (TypeContainer.base_classs_type): New member for storing parent type.
13869 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
13870 for this MemberCore.
13872 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13874 * attribute.cs, const.cs: Fix bug #58590
13876 2004-05-21 Martin Baulig <martin@ximian.com>
13878 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
13879 out parameters if the end of the method is unreachable. Fixes
13882 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13884 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
13885 Hari was right, why extra method.
13887 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13889 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
13891 2004-05-20 Martin Baulig <martin@ximian.com>
13893 Merged this back from gmcs to keep the differences to a minumum.
13895 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
13896 instead of a Declspace.
13897 (Attribute.ResolveType): Likewise.
13898 (Attributes.Search): Likewise.
13899 (Attributes.Contains): Likewise.
13900 (Attributes.GetClsCompliantAttribute): Likewise.
13902 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
13904 (MethodData.ApplyAttributes): Take an EmitContext instead of a
13907 2004-05-19 Marek Safar <marek.safar@seznam.cz>
13909 Fix bug #58688 (MCS does not report error when the same attribute
13912 * attribute.cs (Attribute.Emit): Distinction between null and default.
13914 2004-05-19 Raja R Harinath <rharinath@novell.com>
13916 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
13917 of a top-level attribute without an attribute target.
13918 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
13920 (Attribute.Conditional_GetConditionName),
13921 (Attribute.Obsolete_GetObsoleteMessage): Update.
13922 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
13923 part of ScanForIndexerName.
13924 (Attribute.CanIgnoreInvalidAttribute): New function.
13925 (Attribute.ScanForIndexerName): Move to ...
13926 (Attributes.ScanForIndexerName): ... here.
13927 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
13928 (Attributes.Search): New internal variant that can choose not to
13929 complain if types aren't resolved. The original signature now
13931 (Attributes.GetClsCompliantAttribute): Use internal variant, with
13932 complaints suppressed.
13933 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
13934 only if it not useful.
13935 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
13936 top-level for attributes that are shared between the assembly
13937 and a top-level class.
13938 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
13939 * class.cs: Update to reflect changes.
13940 (DefineIndexers): Fuse loops.
13941 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
13942 a couple more variants of attribute names.
13944 2004-05-18 Marek Safar <marek.safar@seznam.cz>
13946 Fix bug #52585 (Implemented explicit attribute declaration)
13949 (Attributable.ValidAttributeTargets): New abstract method. It gets
13950 list of valid attribute targets for explicit target declaration.
13951 (Attribute.Target): It holds target itself.
13952 (AttributeSection): Removed.
13953 (Attribute.CheckTargets): New method. It checks whether attribute
13954 target is valid for the current element.
13957 (EventProperty): New class. For events that are declared like
13958 property (with add and remove accessors).
13959 (EventField): New class. For events that are declared like field.
13962 * cs-parser.jay: Implemented explicit attribute target declaration.
13964 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
13965 Override ValidAttributeTargets.
13968 (ReturnParameter): Class for applying custom attributes on
13970 (ParameterAtribute): New class. Class for applying custom
13971 attributes on the parameter type.
13973 2004-05-17 Miguel de Icaza <miguel@ximian.com>
13975 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
13978 (Method): Allow UNSAFE here.
13980 * modifiers.cs: Support unsafe reporting.
13982 2004-05-17 Marek Safar <marek.safar@seznam.cz>
13984 * decl.cs: Fix bug #58478.
13986 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13988 * statement.cs: When checking for unreachable code on an EmptyStatement,
13989 set the location. Fixes bug #58488.
13991 2004-05-13 Miguel de Icaza <miguel@ximian.com>
13993 * driver.cs: Add -pkg handling.
13995 From Gonzalo: UseShelLExecute=false
13997 2004-05-12 Marek Safar <marek.safar@seznam.cz>
14000 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
14002 (Attribute.IsClsCompliaceRequired): Moved to base for better
14004 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
14005 when attribute is AttributeUsageAttribute.
14006 (Attribute.GetValidTargets): Simplified.
14007 (Attribute.GetAttributeUsage): New method returns AttributeUsage
14008 attribute for this type.
14009 (Attribute.ApplyAttributes): Method renamed to Emit and make
14011 (GlobalAttributeSection): New class for special handling of global
14012 attributes (assembly, module).
14013 (AttributeSection.Emit): New method.
14015 * class.cs: Implemented Attributable abstract methods.
14016 (MethodCore.LabelParameters): Moved to Parameter class.
14017 (Accessor): Is back simple class.
14018 (PropertyMethod): Implemented Attributable abstract class.
14019 (DelegateMethod): Implemented Attributable abstract class.
14020 (Event): New constructor for disctintion between normal Event
14021 and Event with accessors.
14023 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
14025 * codegen.cs, const.cs, decl.cs, delegate.cs:
14026 (CommonAssemblyModulClass): Implemented Attributable abstract class
14029 * enum.cs: Implement IAttributeSupport interface.
14030 (EnumMember): New class for emum members. Implemented Attributable
14034 (ParameterBase): Is abstract.
14035 (ReturnParameter): New class for easier [return:] attribute handling.
14037 * typemanager.cs: Removed builder_to_attr.
14039 2004-05-11 Raja R Harinath <rharinath@novell.com>
14042 * attribute.cs (Attribute.GetPositionalValue): New function.
14043 * class.cs (TypeContainer.VerifyMembers): New function.
14044 (TypeContainer.Emit): Use it.
14045 (ClassOrStruct): New base class for Class and Struct.
14046 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
14047 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
14049 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
14050 then each non-static field should have a FieldOffset attribute.
14051 Otherwise, none of the fields should have a FieldOffset attribute.
14052 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
14053 and FieldOffset attributes.
14054 * typemanager.cs (TypeManager.struct_layout_attribute_type)
14055 (TypeManager.field_offset_attribute_type): New core types.
14056 (TypeManager.InitCoreTypes): Initialize them.
14058 2004-05-11 Michal Moskal <malekith@pld-linux.org>
14060 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
14061 Return correct type.
14064 2004-05-09 Miguel de Icaza <miguel@ximian.com>
14066 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
14067 be implicitly converted to ulong.
14069 * expression.cs: The logic for allowing operator &, | and ^ worked
14070 was wrong, it worked before because we did not report an error in
14071 an else branch. Fixes 57895.
14073 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
14074 allow volatile fields to be reference types.
14076 2004-05-07 Miguel de Icaza <miguel@ximian.com>
14078 * driver.cs: Add support for /debug-
14080 2004-05-07 Raja R Harinath <rharinath@novell.com>
14082 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
14083 Add a 'complain' parameter to silence errors.
14084 (Attribute.Resolve): Update to changes. Put in sanity check to catch
14085 silently overlooked type-resolutions.
14086 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
14087 to reflect changes.
14088 (Attributes.Search): New function.
14089 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
14090 (Attributes.GetAttributeFullName): Remove hack.
14091 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
14092 Update to reflect changes.
14093 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14094 Use Attributes.Search instead of nested loops.
14096 2004-05-07 Marek Safar <marek.safar@seznam.cz>
14099 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
14100 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
14101 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
14103 * report.cs: (Report.Warning): Renamed to Warning_T because of
14104 parameter collision.
14106 2004-05-05 Raja R Harinath <rharinath@novell.com>
14108 * expression.cs (MemberAccess.ResolveMemberAccess):
14109 Exit with non-zero status after Report.Error.
14110 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
14112 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
14114 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14116 * support.cs: Don't hang when the file is empty.
14118 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14120 * support.cs: In SeekableStreamReader, compute the preamble size of the
14121 underlying stream. Position changes should take into account that initial
14124 2004-05-03 Todd Berman <tberman@sevenl.net>
14126 * driver.cs: remove unused GetSysVersion function.
14128 2004-05-03 Todd Berman <tberman@sevenl.net>
14130 * driver.cs: Remove the hack from saturday, as well as the hack
14131 from jackson (LoadAssemblyFromGac), also adds the CWD to the
14132 link_paths to get that bit proper.
14134 2004-05-01 Todd Berman <tberman@sevenl.net>
14136 * driver.cs: Try a LoadFrom before a Load, this checks the current
14137 path. This is currently a bug in mono that is be fixed, however, this
14138 provides a workaround for now. This will be removed when the bug
14141 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
14143 * CryptoConvert.cs: Updated to latest version. Fix issue with
14144 incomplete key pairs (#57941).
14146 2004-05-01 Todd Berman <tberman@sevenl.net>
14148 * driver.cs: Remove '.' from path_chars, now System.* loads properly
14151 2004-04-30 Jackson Harper <jackson@ximian.com>
14153 * codegen.cs: Open keys readonly.
14155 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14157 * typemanager.cs: don't report cyclic struct layout when a struct
14158 contains 2 or more fields of the same type. Failed for Pango.AttrShape
14159 which has 2 Pango.Rectangle fields.
14161 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
14163 * expression.cs: Handle IntPtr comparisons with IL code
14164 rather than a method call.
14166 2004-04-29 Martin Baulig <martin@ximian.com>
14168 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
14169 the list of PropertyInfo's in class hierarchy and find the
14170 accessor. Fixes #56013.
14172 2004-04-29 Martin Baulig <martin@ximian.com>
14174 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
14176 2004-04-29 Martin Baulig <martin@ximian.com>
14178 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14180 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
14182 2004-04-29 Martin Baulig <martin@ximian.com>
14184 * class.cs (ConstructorInitializer.Resolve): Check whether the
14185 parent .ctor is accessible. Fixes #52146.
14187 2004-04-29 Martin Baulig <martin@ximian.com>
14189 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14191 * statement.cs (Using.EmitLocalVariableDecls): Use
14192 TypeManager.idisposable_type, not typeof (IDisposable).
14193 (Foreach.EmitCollectionForeach): Added support for valuetypes.
14195 2004-04-29 Martin Baulig <martin@ximian.com>
14197 * class.cs (Event.Define): Don't emit the field and don't set
14198 RTSpecialName and SpecialName for events on interfaces. Fixes
14201 2004-04-29 Raja R Harinath <rharinath@novell.com>
14203 Refactor Attribute.ApplyAttributes.
14204 * attribute.cs (Attributable): New base class for objects that can
14205 have Attributes applied on them.
14206 (Attribute): Make AttributeUsage fields public.
14207 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
14208 (Attribute.IsInternalCall): New property.
14209 (Attribute.UsageAttr): Convert to a public read-only property.
14210 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
14211 (Attribute.ResolveType, Attribute.Resolve)
14212 (Attribute.ScanForIndexerName): Update to reflect changes.
14213 (Attribute.CheckAttributeTarget): Re-format.
14214 (Attribute.ApplyAttributes): Refactor, to various
14215 Attributable.ApplyAttributeBuilder methods.
14216 * decl.cs (MemberCore): Make Attributable.
14217 * class.cs (Accessor): Make Attributable.
14218 (MethodData.ApplyAttributes): Use proper attribute types, not
14220 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
14221 (TypeContainer.ApplyAttributeBuilder)
14222 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
14223 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
14224 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
14225 (Operator.ApplyAttributeBuilder): New factored-out methods.
14226 * const.cs (Const.ApplyAttributeBuilder): Likewise.
14227 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
14228 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
14229 * parameter.cs (ParameterBase): New Attributable base class
14230 that can also represent Return types.
14231 (Parameter): Update to the changes.
14233 2004-04-29 Jackson Harper <jackson@ximian.com>
14235 * driver.cs: Prefer the corlib system version when looking for
14236 assemblies in the GAC. This is still a hack, but its a better hack
14239 2004-04-29 Marek Safar <marek.safar@seznam.cz>
14241 * decl.cs, enum.cs: Improved error 3005 reporting.
14243 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
14244 (related_symbols): New private member for list of symbols
14245 related to reported error/warning.
14247 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
14249 2004-04-29 Martin Baulig <martin@ximian.com>
14251 * ecore.cs (Expression.Constantify): If we're an enum and
14252 TypeManager.TypeToCoreType() doesn't give us another type, use
14253 t.UnderlyingSystemType. Fixes #56178.
14255 2004-04-29 Martin Baulig <martin@ximian.com>
14257 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
14258 interfaces and for each interface, only add members directly
14259 declared in that interface. Fixes #53255.
14261 2004-04-28 Martin Baulig <martin@ximian.com>
14263 * expression.cs (ConditionalLogicalOperator): Use a temporary
14264 variable for `left' to avoid that we evaluate it more than once;
14267 2004-04-28 Martin Baulig <martin@ximian.com>
14269 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
14272 2004-04-28 Martin Baulig <martin@ximian.com>
14274 * statement.cs (LocalInfo.Resolve): Check whether the type is not
14277 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
14278 whether the type is not void (CS1547).
14280 2004-04-28 Martin Baulig <martin@ximian.com>
14282 * expression.cs (Unary.DoResolveLValue): Override this and report
14283 CS0131 for anything but Operator.Indirection.
14285 2004-04-28 Martin Baulig <martin@ximian.com>
14287 Committing a patch from Ben Maurer; see bug #50820.
14289 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14292 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14295 2004-04-28 Martin Baulig <martin@ximian.com>
14297 Committing a patch from Ben Maurer; see bug #50820.
14299 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14302 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14305 2004-04-28 Martin Baulig <martin@ximian.com>
14307 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
14308 (Block.AddLabel): Call DoLookupLabel() to only search in the
14311 2004-04-28 Martin Baulig <martin@ximian.com>
14313 * cfold.cs (ConstantFold.BinaryFold): Added special support for
14314 comparing StringConstants and NullLiterals in Equality and Inequality.
14316 2004-04-28 Jackson Harper <jackson@ximian.com>
14318 * driver.cs: Attempt to load referenced assemblies from the
14319 GAC. This is the quick and dirty version of this method that
14320 doesnt take into account versions and just takes the first
14321 canidate found. Will be good enough for now as we will not have more
14322 then one version installed into the GAC until I update this method.
14324 2004-04-28 Martin Baulig <martin@ximian.com>
14326 * typemanager.cs (TypeManager.CheckStructCycles): New public
14327 static method to check for cycles in the struct layout.
14329 * rootcontext.cs (RootContext.PopulateTypes): Call
14330 TypeManager.CheckStructCycles() for each TypeContainer.
14331 [Note: We only need to visit each type once.]
14333 2004-04-28 Martin Baulig <martin@ximian.com>
14335 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
14337 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
14338 success and added `out object value'. Use a `bool resolved' field
14339 to check whether we've already been called rather than
14340 `ConstantValue != null' since this breaks for NullLiterals.
14342 2004-04-28 Raja R Harinath <rharinath@novell.com>
14344 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
14345 setting of this flag, since the 'set' method may be non-public.
14347 2004-04-28 Raja R Harinath <rharinath@novell.com>
14349 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
14350 check on current_vector.Block.
14352 2004-04-27 Martin Baulig <martin@ximian.com>
14354 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
14355 a field initializer. Fixes #56459.
14357 2004-04-27 Martin Baulig <martin@ximian.com>
14359 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
14360 we're not attempting to use an indexer. Fixes #52154.
14362 2004-04-27 Martin Baulig <martin@ximian.com>
14364 * statement.cs (Return): Don't create a return label if we don't
14365 need it; reverts my change from January 20th. Thanks to Ben
14368 2004-04-27 Martin Baulig <martin@ximian.com>
14370 According to the spec, `goto' can only leave a nested scope, but
14373 * statement.cs (Block.LookupLabel): Only lookup in the current
14374 block, don't recurse into parent or child blocks.
14375 (Block.AddLabel): Check in parent and child blocks, report
14376 CS0140/CS0158 if we find a duplicate.
14377 (Block): Removed this indexer for label lookups.
14378 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
14379 this already does the error reporting for us.
14382 (FlowBranching.UsageVector.Block): New public variable; may be null.
14383 (FlowBranching.CreateSibling): Added `Block' argument.
14384 (FlowBranching.LookupLabel): New public virtual method. Lookup a
14385 label for the target of a `goto' and check whether we're not
14386 leaving a `finally'.
14388 2004-04-27 Martin Baulig <martin@ximian.com>
14390 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14391 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
14394 2004-04-27 Martin Baulig <martin@ximian.com>
14396 * statement.cs (Block.AddLabel): Also check for implicit blocks
14397 and added a CS0158 check.
14399 2004-04-27 Martin Baulig <martin@ximian.com>
14401 * flowanalysis.cs (FlowBranchingLoop): New class.
14402 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
14403 UsageVector's instead of an ArrayList.
14404 (FlowBranching.Label): Likewise.
14405 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
14406 (FlowBranching.AddBreakVector): New method.
14408 2004-04-27 Miguel de Icaza <miguel@ximian.com>
14410 * attribute.cs: Small regression fix: only convert the type if we
14411 the type is different, fixes System.Drawing build.
14413 2004-04-27 Martin Baulig <martin@ximian.com>
14415 * attribute.cs (Attribute.Resolve): If we have a constant value
14416 for a named field or property, implicity convert it to the correct
14419 2004-04-27 Raja R Harinath <rharinath@novell.com>
14421 * statement.cs (Block.Block): Implicit blocks share
14422 'child_variable_names' fields with parent blocks.
14423 (Block.AddChildVariableNames): Remove.
14424 (Block.AddVariable): Mark variable as "used by a child block" in
14425 every surrounding block.
14426 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
14427 been used in a child block, complain about violation of "Invariant
14428 meaning in blocks" rule.
14429 * cs-parser.jay (declare_local_variables): Don't use
14430 AddChildVariableNames.
14431 (foreach_statement): Don't create an implicit block: 'foreach'
14432 introduces a scope.
14434 2004-04-23 Miguel de Icaza <miguel@ximian.com>
14436 * convert.cs (ImplicitNumericConversion): 0 is also positive when
14437 converting from 0L to ulong. Fixes 57522.
14439 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14441 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
14442 derived class hides via 'new' keyword field from base class (test-242.cs).
14443 TODO: Handle this in the more general way.
14445 * class.cs (CheckBase): Ditto.
14447 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14449 * decl.cs (caching_flags): New member for storing cached values
14451 (MemberCore.Flags): New enum where bit flags for caching_flags
14453 (MemberCore.cls_compliance): Moved to caching_flags.
14454 (DeclSpace.Created): Moved to caching_flags.
14456 * class.cs: Use caching_flags instead of DeclSpace.Created
14458 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14460 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14461 if we are only a derived class, not a nested class.
14463 * typemanager.cs: Same as above, but do this at the MemberLookup
14464 level (used by field and methods, properties are handled in
14465 PropertyExpr). Allow for the qualified access if we are a nested
14468 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14470 * class.cs: Refactoring.
14471 (IMethodData): New inteface; Holds links to parent members
14472 to avoid member duplication (reduced memory allocation).
14473 (Method): Implemented IMethodData interface.
14474 (PropertyBase): New inner classes for get/set methods.
14475 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14476 (Event): New inner classes for add/remove methods.
14477 (Event.DelegateMethod): Implemented IMethodData interface.
14479 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14480 EmitContext (related to class.cs refactoring).
14482 2004-04-21 Raja R Harinath <rharinath@novell.com>
14484 * delegate.cs (Delegate.VerifyApplicability): If the number of
14485 arguments are the same as the number of parameters, first try to
14486 verify applicability ignoring any 'params' modifier on the last
14490 2004-04-16 Raja R Harinath <rharinath@novell.com>
14492 * class.cs (TypeContainer.AddIndexer): Use
14493 'ExplicitInterfaceName' to determine if interface name was
14494 explicitly specified. 'InterfaceType' is not initialized at this time.
14495 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14496 Indexers array is already in the required order. Initialize
14497 'IndexerName' only if there are normal indexers.
14498 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14499 (TypeContainer.Emit): Emit DefaultMember attribute only if
14500 IndexerName is initialized.
14503 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14505 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14508 2004-04-15 Raja R Harinath <rharinath@novell.com>
14510 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14514 * attribute.cs (Attribute.Resolve): Check for duplicate named
14518 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14520 * iterators.cs (MarkYield): track whether we are in an exception,
14521 and generate code accordingly. Use a temporary value to store the
14522 result for our state.
14524 I had ignored a bit the interaction of try/catch with iterators
14525 since their behavior was not entirely obvious, but now it is
14526 possible to verify that our behavior is the same as MS .NET 2.0
14530 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14532 * iterators.cs: Avoid creating temporaries if there is no work to
14535 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14536 Enumerations, use TypeManager.EnumToUnderlying and call
14539 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14542 (This.Emit): Use EmitContext.EmitThis to emit our
14545 (This.EmitAssign): Ditto.
14547 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14548 codepaths, we will move all the functionality into
14551 (FieldExpr.EmitAssign): Ditto.
14553 This fixes several hidden bugs that I uncovered while doing a code
14554 review of this today.
14556 * codegen.cs (EmitThis): reworked so the semantics are more clear
14557 and also support value types "this" instances.
14559 * iterators.cs: Changed so that for iterators in value types, we
14560 do not pass the value type as a parameter.
14562 Initialization of the enumerator helpers is now done in the caller
14563 instead of passing the parameters to the constructors and having
14564 the constructor set the fields.
14566 The fields have now `assembly' visibility instead of private.
14568 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14570 * expression.cs (Argument.Resolve): Check if fields passed as ref
14571 or out are contained in a MarshalByRefObject.
14573 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
14574 another compiler type.
14576 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
14578 * class.cs (Indexer.Define): use the new name checking method.
14579 Also, return false on an error.
14580 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
14581 (is_identifier_[start/part]_character): make static.
14583 2004-04-10 Miguel de Icaza <miguel@ximian.com>
14585 * expression.cs (Binary.ResolveOperator): Do no append strings
14586 twice: since we can be invoked more than once (array evaluation)
14587 on the same concatenation, take care of this here. Based on a fix
14588 from Ben (bug #56454)
14590 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
14592 * codegen.cs: Fix another case where CS1548 must be reported (when
14593 delay-sign isn't specified and no private is available #56564). Fix
14594 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
14595 error when MCS is used on the MS runtime and we need to delay-sign
14596 (which seems unsupported by AssemblyBuilder - see #56621).
14598 2004-04-08 Marek Safar <marek.safar@seznam.cz>
14600 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
14601 (TypeManager.ComputeNamespaces): Faster implementation for
14604 * compiler.csproj: Updated AssemblyName to mcs.
14606 2004-04-07 Miguel de Icaza <miguel@ximian.com>
14608 * rootcontext.cs: Add new types to the boot resolution.
14610 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
14611 MulticastDelegate is not allowed.
14613 * typemanager.cs: Add new types to lookup: System.TypedReference
14616 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
14617 check for TypedReference or ArgIterator, they are not allowed.
14619 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
14620 makes us properly catch 1510 in some conditions (see bug 56016 for
14623 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
14625 * CryptoConvert.cs: update from corlib version
14628 2004-04-05 Miguel de Icaza <miguel@ximian.com>
14630 * class.cs (Indexer.Define): Check indexername declaration
14632 2004-04-05 Marek Safar <marek.safar@seznam.cz>
14634 * attribute.cs (IsClsCompliant): Fixed problem with handling
14635 all three states (compliant, not-compliant, undetected).
14637 2004-03-30 Marek Safar <marek.safar@seznam.cz>
14639 * attribute.cs (Attribute): Location is now public.
14640 (Resolve): Store resolved arguments (pos_values) in attribute class.
14641 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
14642 (GetClsCompliantAttributeValue): New method that gets
14643 CLSCompliantAttribute value.
14644 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
14645 if exists else null.
14646 (AttributeTester): New class for CLS-Compliant verification routines.
14648 * class.cs (Emit): Add CLS-Compliant verification.
14649 (Method.GetSignatureForError): Implemented.
14650 (Constructor.GetSignatureForError): Implemented
14651 (Constructor.HasCompliantArgs): Returns if constructor has
14652 CLS-Compliant arguments.
14653 (Constructor.Emit): Override.
14654 (Construcor.IsIdentifierClsCompliant): New method; For constructors
14655 is needed to test only parameters.
14656 (FieldBase.GetSignatureForError): Implemented.
14657 (TypeContainer): New member for storing base interfaces.
14658 (TypeContainer.FindMembers): Search in base interfaces too.
14660 * codegen.cs (GetClsComplianceAttribute): New method that gets
14661 assembly or module CLSCompliantAttribute value.
14662 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
14664 (ModuleClass.Emit): Add error 3012 test.
14666 * const.cs (Emit): Override and call base for CLS-Compliant tests.
14668 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
14669 state for all decl types.
14670 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
14671 if CLS-Compliant tests are required.
14672 (IsClsCompliaceRequired): New method. Analyze whether code
14673 must be CLS-Compliant.
14674 (IsExposedFromAssembly): New method. Returns true when MemberCore
14675 is exposed from assembly.
14676 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
14677 value or gets cached value.
14678 (HasClsCompliantAttribute): New method. Returns true if MemberCore
14679 is explicitly marked with CLSCompliantAttribute.
14680 (IsIdentifierClsCompliant): New abstract method. This method is
14681 used to testing error 3005.
14682 (IsIdentifierAndParamClsCompliant): New method. Common helper method
14683 for identifier and parameters CLS-Compliant testing.
14684 (VerifyClsCompliance): New method. The main virtual method for
14685 CLS-Compliant verifications.
14686 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
14687 null. I don't know why is null (too many public members !).
14688 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
14689 and get value of first CLSCompliantAttribute that found.
14691 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
14692 (VerifyClsCompliance): Override and add extra tests.
14694 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
14695 clscheck- disable CLS-Compliant verification event if assembly is has
14696 CLSCompliantAttribute(true).
14698 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
14699 ApllyAttribute is now called in emit section as in the other cases.
14700 Possible future Emit integration.
14701 (IsIdentifierClsCompliant): New override.
14702 (VerifyClsCompliance): New override.
14703 (GetEnumeratorName): Returns full enum name.
14705 * parameter.cs (GetSignatureForError): Implemented.
14707 * report.cs (WarningData): New struct for Warning message information.
14708 (LocationOfPreviousError): New method.
14709 (Warning): New method. Reports warning based on the warning table.
14710 (Error_T): New method. Reports error based on the error table.
14712 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
14713 verifications are done here.
14715 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
14717 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
14718 CLSCompliantAttribute.
14719 (all_imported_types): New member holds all imported types from other
14721 (LoadAllImportedTypes): New method fills static table with exported types
14722 from all referenced assemblies.
14723 (Modules): New property returns all assembly modules.
14725 2004-03-30 Miguel de Icaza <miguel@ximian.com>
14727 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
14728 throwing a parser error.
14730 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
14731 which removes the hardcoded get_/set_ prefixes for properties, as
14732 IL allows for the properties to be named something else.
14736 * expression.cs: Do not override operand before we know if it is
14737 non-null. Fix 56207
14739 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14741 * typemanager.cs: support for pinned variables.
14743 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14745 * decl.cs, typemanager.cs: Avoid using an arraylist
14746 as a buffer if there is only one result set.
14748 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14750 * expression.cs: Make sure you cant call a static method
14751 with an instance expression, bug #56174.
14753 2004-03-29 Miguel de Icaza <miguel@ximian.com>
14755 * class.cs (IsDuplicateImplementation): Improve error reporting to
14756 flag 663 (method only differs in parameter modifier).
14758 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
14759 in preprocessor directives.
14761 * location.cs (LookupFile): Allow for the empty path.
14763 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
14764 better approach for some of that patch, but its failing with the
14765 CharSet enumeration. For now try/catch will do.
14767 * typemanager.cs: Do not crash if a struct does not have fields.
14770 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14772 * expression.cs: cs0213, cant fix a fixed expression.
14775 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14777 * cs-parser.jay: detect invalid embeded statements gracefully.
14780 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14782 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
14785 the invocation type may not be a subclass of the tye of the item/
14786 The type of the item must be a subclass of the invocation item.
14791 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
14793 * attribute.cs: Added methods to get a string and a bool from an
14794 attribute. Required to information from AssemblyKeyFileAttribute,
14795 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
14796 * codegen.cs: Modified AssemblyName creation to include support for
14797 strongnames. Catch additional exceptions to report them as CS1548.
14798 * compiler.csproj: Updated include CryptoConvert.cs.
14799 * compiler.csproj.user: Removed file - user specific configuration.
14800 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
14801 Mono.Security assembly. The original class is maintained and tested in
14802 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
14803 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
14804 like CSC 8.0 (C# v2) supports.
14805 * Makefile: Added CryptoConvert.cs to mcs sources.
14806 * rootcontext.cs: Added new options for strongnames.
14808 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
14810 * driver.cs: For --expect-error, report error code `2'
14811 if the program compiled with no errors, error code `1' if
14812 it compiled with an error other than the one expected.
14814 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
14816 * compiler.csproj: Updated for Visual Studio .NET 2003.
14817 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
14818 * compiler.sln: Updated for Visual Studio .NET 2003.
14820 2004-03-24 Ravi Pratap M <ravi@ximian.com>
14822 * expression.cs: Fix bug #47234. We basically need to apply the
14823 rule that we prefer the conversion of null to a reference type
14824 when faced with a conversion to 'object' (csc behaviour).
14826 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14828 * statement.cs: Shorter form for foreach, eliminates
14829 a local variable. r=Martin.
14831 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14833 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
14834 checks if we can use brtrue/brfalse to test for 0.
14835 * expression.cs: use the above in the test for using brtrue/brfalse.
14836 cleanup code a bit.
14838 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14840 * expression.cs: Rewrite string concat stuff. Benefits:
14842 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
14843 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
14844 rather than a concat chain.
14846 * typemanager.cs: Add lookups for more concat overloads.
14848 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14850 * expression.cs: Emit shorter il code for array init.
14867 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
14869 * statement.cs: Before, two switch blocks would be merged if the
14870 total size of the blocks (end_item - begin_item + 1) was less than
14871 two times the combined sizes of the blocks.
14873 Now, it will only merge if after the merge at least half of the
14878 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
14880 * class.cs : csc build fix for GetMethods(). See bug #52503.
14882 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
14884 * expression.cs: Make sure fp comparisons work with NaN.
14885 This fixes bug #54303. Mig approved this patch a long
14886 time ago, but we were not able to test b/c the runtime
14889 2004-03-19 Miguel de Icaza <miguel@ximian.com>
14891 * ecore.cs (TypExpr.GetHashCode): implement this overload.
14893 2004-03-19 Martin Baulig <martin@ximian.com>
14895 * class.cs (MemberCore.IsDuplicateImplementation): Report the
14896 error here and not in our caller.
14898 2004-03-19 Martin Baulig <martin@ximian.com>
14900 * interface.cs: Completely killed this file.
14901 (Interface): We're now a TypeContainer and live in class.cs.
14903 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
14904 argument; we're now also called for interfaces.
14905 (TypeContainer.DefineMembers): Allow this method being called
14907 (TypeContainer.GetMethods): New public method; formerly known as
14908 Interface.GetMethod(). This is used by PendingImplementation.
14909 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
14910 it's now private and non-static.
14911 (Interface): Moved this here; it's now implemented similar to
14913 (Method, Property, Event, Indexer): Added `bool is_interface'
14914 argument to their .ctor's.
14915 (MemberBase.IsInterface): New public field.
14917 * cs-parser.jay: Create normal Method, Property, Event, Indexer
14918 instances instead of InterfaceMethod, InterfaceProperty, etc.
14919 (opt_interface_base): Removed; we now use `opt_class_base' instead.
14920 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
14922 2004-03-19 Martin Baulig <martin@ximian.com>
14924 * class.cs (MethodCore.IsDuplicateImplementation): New private
14925 method which does the CS0111 checking.
14926 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14927 Use IsDuplicateImplementation().
14929 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
14931 * decl.cs (FindMemberToOverride): New method to find the correct
14932 method or property to override in the base class.
14934 - Make Method/Property use the above method to find the
14935 version in the base class.
14936 - Remove the InheritableMemberSignatureCompare as it is now
14939 This patch makes large code bases much faster to compile, as it is
14940 O(n) rather than O(n^2) to do this validation.
14942 Also, it fixes bug 52458 which is that nested classes are not
14943 taken into account when finding the base class member.
14945 Reviewed/Approved by Martin.
14947 2004-03-17 Marek Safar <marek.safar@seznam.cz>
14949 * interface.cs: In all interface classes removed redundant
14950 member initialization.
14952 2004-03-16 Martin Baulig <martin@ximian.com>
14954 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
14956 2004-03-15 Miguel de Icaza <miguel@ximian.com>
14958 * decl.cs (DefineTypeAndParents): New helper method to define a
14959 type's containers before the type itself is defined; This is a
14960 bug exposed by the recent changes to Windows.Forms when an
14961 implemented interface was defined inside a class that had not been
14964 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
14966 (Check): Loop correctly to report errors modifiers
14967 (UNSAFE was not in the loop, since it was the same as TOP).
14969 * interface.cs: Every interface member now takes a ModFlags,
14970 instead of a "is_new" bool, which we set on the base MemberCore.
14972 Every place where we called "UnsafeOk" in the interface, now we
14973 call the proper member (InterfaceMethod.UnsafeOK) instead to get
14974 the unsafe settings from the member declaration instead of the
14975 container interface.
14977 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
14979 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
14980 `set_indexer_name' to the pending bits (one per type).
14982 We fixed a bug today that was picking the wrong method to
14983 override, since for properties the existing InterfaceMethod code
14984 basically ignored the method name. Now we make sure that the
14985 method name is one of the valid indexer names.
14987 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
14989 * support.cs (SeekableStreamReader): Keep track of stream byte
14990 positions and don't mix them with character offsets to the buffer.
14992 Patch from Gustavo Giráldez
14994 2004-03-15 Marek Safar <marek.safar@seznam.cz>
14996 * interface.cs (InterfaceSetGetBase): Removed double member
14997 initialization, base class does it as well.
14999 2004-03-13 Martin Baulig <martin@ximian.com>
15001 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
15002 when compiling corlib.
15004 2004-03-13 Miguel de Icaza <miguel@ximian.com>
15006 * convert.cs (ExplicitConversion): We were reporting an error on
15007 certain conversions (object_type source to a value type, when the
15008 expression was `null') before we had a chance to pass it through
15009 the user defined conversions.
15011 * driver.cs: Replace / and \ in resource specifications to dots.
15014 * class.cs: Add check for duplicate operators. Fixes 52477
15016 2004-03-11 Miguel de Icaza <miguel@ximian.com>
15018 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
15019 that are in the middle of the statements, not only at the end.
15022 * class.cs (TypeContainer.AddField): No longer set the
15023 `HaveStaticConstructor' flag, now we call it
15024 `UserDefineStaticConstructor' to diferentiate the slightly
15025 semantic difference.
15027 The situation is that we were not adding BeforeFieldInit (from
15028 Modifiers.TypeAttr) to classes that could have it.
15029 BeforeFieldInit should be set to classes that have no static
15034 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
15036 And most importantly Zoltan's comment:
15038 http://bugzilla.ximian.com/show_bug.cgi?id=44229
15040 "I think beforefieldinit means 'it's ok to initialize the type sometime
15041 before its static fields are used', i.e. initialization does not need
15042 to be triggered by the first access to the type. Setting this flag
15043 helps the JIT to compile better code, since it can run the static
15044 constructor at JIT time, and does not need to generate code to call it
15045 (possibly lots of times) at runtime. Unfortunately, mcs does not set
15046 this flag for lots of classes like String.
15048 csc sets this flag if the type does not have an explicit static
15049 constructor. The reasoning seems to be that if there are only static
15050 initalizers for a type, and no static constructor, then the programmer
15051 does not care when this initialization happens, so beforefieldinit
15054 This bug prevents the AOT compiler from being usable, since it
15055 generates so many calls to mono_runtime_class_init that the AOT code
15056 is much slower than the JITted code. The JITted code is faster,
15057 because it does not generate these calls if the vtable is type is
15058 already initialized, which is true in the majority of cases. But the
15059 AOT compiler can't do this."
15061 2004-03-10 Miguel de Icaza <miguel@ximian.com>
15063 * class.cs (MethodData.Emit): Refactor the code so symbolic
15064 information is generated for destructors; For some reasons we
15065 were taking a code path that did not generate symbolic information
15068 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
15070 * class.cs: Create a Constructor.CheckBase method that
15071 takes care of all validation type code. The method
15072 contains some code that was moved from Define.
15074 It also includes new code that checks for duplicate ctors.
15075 This fixes bug #55148.
15077 2004-03-09 Joshua Tauberer <tauberer@for.net>
15079 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
15080 a { ... }-style array creation invokes EmitStaticInitializers
15081 which is not good for reference-type arrays. String, decimal
15082 and now null constants (NullCast) are not counted toward
15083 static initializers.
15085 2004-03-05 Martin Baulig <martin@ximian.com>
15087 * location.cs (SourceFile.HasLineDirective): New public field;
15088 specifies whether the file contains or is referenced by a "#line"
15090 (Location.DefineSymbolDocuments): Ignore source files which
15091 either contain or are referenced by a "#line" directive.
15093 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
15095 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
15096 direct access to our parent, so check the method inline there.
15098 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
15100 * expression.cs (Invocation.EmitCall): Miguel's last commit
15101 caused a regression. If you had:
15106 In Foo the implict this would be null.
15108 2004-02-27 Miguel de Icaza <miguel@ximian.com>
15110 * expression.cs (Invocation.EmitCall): If the method is not
15111 virtual, do not emit a CallVirt to it, use Call.
15113 * typemanager.cs (GetFullNameSignature): Improve the method to
15114 cope with ".ctor" and replace it with the type name.
15116 * class.cs (ConstructorInitializer.Resolve): Now the method takes
15117 as an argument the ConstructorBuilder where it is being defined,
15118 to catch the recursive constructor invocations.
15120 2004-02-26 Miguel de Icaza <miguel@ximian.com>
15122 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
15123 routines to check if a type is an enumerable/enumerator allow
15124 classes that implement the IEnumerable or IEnumerator interfaces.
15126 * class.cs (Property, Operator): Implement IIteratorContainer, and
15127 implement SetYields.
15129 (Property.Define): Do the block swapping for get_methods in the
15130 context of iterators. We need to check if Properties also
15131 include indexers or not.
15133 (Operator): Assign the Block before invoking the
15134 OperatorMethod.Define, so we can trigger the Iterator code
15137 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
15138 Property and Operator classes are not created when we parse the
15139 declarator but until we have the block completed, so we use a
15140 singleton SimpleIteratorContainer.Simple to flag whether the
15141 SetYields has been invoked.
15143 We propagate this setting then to the Property or the Operator to
15144 allow the `yield' to function.
15146 2004-02-25 Marek Safar <marek.safar@seznam.cz>
15148 * codegen.cs: Implemented attribute support for modules.
15149 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
15150 Assembly/Module functionality.
15152 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
15153 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
15154 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
15156 2004-02-16 Marek Safar <marek.safar@seznam.cz>
15158 * interface.cs (FindMembers): The operation is performed on all base
15159 interfaces and not only on the first. It is required for future CLS Compliance patch.
15161 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
15163 * statement.cs, codegen.cs:
15164 This patch deals with patterns such as:
15166 public class List : IEnumerable {
15168 public MyEnumerator GetEnumerator () {
15169 return new MyEnumerator(this);
15172 IEnumerator IEnumerable.GetEnumerator () {
15176 public struct MyEnumerator : IEnumerator {
15181 Before, there were a few things we did wrong:
15182 1) we would emit callvirt on a struct, which is illegal
15183 2) we emited ldarg when we needed to emit ldarga
15184 3) we would mistakenly call the interface methods on an enumerator
15185 type that derived from IEnumerator and was in another assembly. For example:
15187 public class MyEnumerator : IEnumerator
15189 Would have the interface methods called, even if there were public impls of the
15190 method. In a struct, this lead to invalid IL code.
15192 2004-02-11 Marek Safar <marek.safar@seznam.cz>
15194 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
15197 * delegate.cs (Define): Fixed crash when delegate type is undefined.
15199 2004-02-11 Miguel de Icaza <miguel@ximian.com>
15201 * cs-parser.jay: Fix small regression: we were not testing V2
15202 compiler features correctly.
15204 * interface.cs: If the emit context is null, then create one
15206 2004-02-09 Marek Safar <marek.safar@seznam.cz>
15208 * decl.cs (GetSignatureForError): New virtual method to get full name
15209 for error messages.
15211 * attribute.cs (IAttributeSupport): New interface for attribute setting.
15212 Now it is possible to rewrite ApplyAttributes method to be less if/else.
15214 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
15215 Duplicated members and code in these classes has been removed.
15216 Better encapsulation in these classes.
15218 2004-02-07 Miguel de Icaza <miguel@ximian.com>
15220 * assign.cs (Assign.DoResolve): When dealing with compound
15221 assignments, there is a new rule in ECMA C# 2.4 (might have been
15222 there before, but it is documented here) that states that in:
15226 If b is of type int, and the `op' is a shift-operator, then the
15227 above is evaluated as:
15231 * expression.cs (Binary.ResolveOperator): Instead of testing for
15232 int/uint/long/ulong, try to implicitly convert to any of those
15233 types and use that in pointer arithmetic.
15235 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
15236 method to print information for from the type, not from the
15237 null-method we were given.
15239 2004-02-01 Duncan Mak <duncan@ximian.com>
15241 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
15242 parsing for cmd, fixes bug #53694.
15244 2004-02-04 Marek Safar <marek.safar@seznam.cz>
15246 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
15247 in the member name duplication tests. Property and operator name duplication
15248 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
15250 2004-02-03 Marek Safar <marek.safar@seznam.cz>
15252 * interface.cs (PopulateMethod): Fixed crash when interface method
15253 returns not existing type (error test cs0246-3.cs).
15255 2004-02-02 Ravi Pratap M <ravi@ximian.com>
15257 * cs-parser.jay (interface_accessors): Re-write actions to also
15258 store attributes attached to get and set methods. Fix spelling
15261 (inteface_property_declaration): Modify accordingly.
15263 (InterfaceAccessorInfo): New helper class to store information to pass
15264 around between rules that use interface_accessors.
15266 * interface.cs (Emit): Apply attributes on the get and set
15267 accessors of properties and indexers too.
15269 * attribute.cs (ApplyAttributes): Modify accordingly to use the
15270 right MethodBuilder when applying attributes to the get and set accessors.
15272 2004-01-31 Miguel de Icaza <miguel@ximian.com>
15274 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
15276 2004-01-26 Miguel de Icaza <miguel@ximian.com>
15278 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
15280 2004-01-25 Miguel de Icaza <miguel@ximian.com>
15282 * cs-parser.jay: Remove YIELD token, instead use the new grammar
15283 changes that treat `yield' specially when present before `break'
15284 or `return' tokens.
15286 * cs-tokenizer.cs: yield is no longer a keyword.
15288 2004-01-23 Marek Safar <marek.safar@seznam.cz>
15290 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
15291 setting for default constructors.
15292 For default constructors are almost every time set wrong Modifier. The
15293 generated IL code has been alright. But inside mcs this values was
15294 wrong and this was reason why several of my CLS Compliance tests
15297 2004-01-22 Martin Baulig <martin@ximian.com>
15299 * cs-parser.jay (namespace_or_type_name): Return an Expression,
15300 not a QualifiedIdentifier. This is what `type_name_expression'
15301 was previously doing.
15302 (type_name_expression): Removed; the code is now in
15303 `namespace_or_type_name'.
15304 (qualified_identifier): Removed, use `namespace_or_type_name'
15306 (QualifiedIdentifier): Removed this class.
15308 2004-01-22 Martin Baulig <martin@ximian.com>
15310 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
15311 not a string as alias name.
15313 2004-01-21 Miguel de Icaza <miguel@ximian.com>
15315 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
15316 #52730 bug, and instead compute correctly the need to use a
15317 temporary variable when requesting an address based on the
15318 static/instace modified of the field and the constructor.
15320 2004-01-21 Martin Baulig <martin@ximian.com>
15322 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
15323 class and namespace before looking up aliases. Fixes #52517.
15325 2004-01-21 Martin Baulig <martin@ximian.com>
15327 * flowanalysis.cs (UsageVector.Merge): Allow variables being
15328 assinged in a 'try'; fixes exception4.cs.
15330 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15331 * class.cs : Implemented parameter-less constructor for TypeContainer
15333 * decl.cs: Attributes are now stored here. New property OptAttributes
15335 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
15337 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
15339 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15341 * typemanager.cs (CSharpSignature): Now reports also inner class name.
15342 (CSharpSignature): New method for indexer and property signature.
15344 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15346 * pending.cs (IsVirtualFilter): Faster implementation.
15348 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15350 * typemanager.cs: Avoid inclusion of same assembly more than once.
15352 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15354 * cs-parser.jay: Fixed problem where the last assembly attribute
15355 has been applied also to following declaration (class, struct, etc.)
15357 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15359 * class.cs: Added error CS0538, CS0539 reporting.
15360 Fixed crash on Microsoft runtime when field type is void.
15362 * cs-parser.jay: Added error CS0537 reporting.
15364 * pending.cs: Added error CS0535 reporting.
15365 Improved error report for errors CS0536, CS0534.
15367 2004-01-20 Miguel de Icaza <miguel@ximian.com>
15369 Merge a few bits from the Anonymous Method MCS tree.
15371 * statement.cs (ToplevelBlock): New class for toplevel methods,
15372 will hold anonymous methods, lifted variables.
15374 * cs-parser.jay: Create toplevel blocks for delegates and for
15375 regular blocks of code.
15377 2004-01-20 Martin Baulig <martin@ximian.com>
15379 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
15380 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
15381 and `NeedExplicitReturn'; added `IsLastStatement'.
15382 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
15383 have a `ReturnLabel' or we're not unreachable.
15385 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
15386 child's reachability; don't just override ours with it. Fixes
15387 #58058 (lluis's example).
15388 (FlowBranching): Added public InTryOrCatch(), InCatch(),
15389 InFinally(), InLoop(), InSwitch() and
15390 BreakCrossesTryCatchBoundary() methods.
15392 * statement.cs (Return): Do all error checking in Resolve().
15393 Unless we are the last statement in a top-level block, always
15394 create a return label and jump to it.
15395 (Break, Continue): Do all error checking in Resolve(); also make
15396 sure we aren't leaving a `finally'.
15397 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
15398 statement in a top-level block.
15399 (Block.Flags): Added `IsDestructor'.
15400 (Block.IsDestructor): New public property.
15402 2004-01-20 Martin Baulig <martin@ximian.com>
15404 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
15406 2004-01-20 Martin Baulig <martin@ximian.com>
15408 * statement.cs (Statement.ResolveUnreachable): New public method.
15409 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
15410 (Block.Resolve): Resolve unreachable statements.
15412 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15414 * expression.cs: We need to fix the case where we do
15415 not have a temp variable here.
15417 * assign.cs: Only expression compound assignments need
15418 temporary variables.
15420 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15422 * flowanalysis.cs: Reduce memory allocation in a few ways:
15423 - A block with no variables should not allocate a bit
15425 - A method with no out parameters does not need any tracking
15426 for assignment of the parameters, so we need not allocate
15429 public readonly Type[] VariableTypes;
15430 public readonly string[] VariableNames;
15431 Are redundant. The data is already stored in the variable
15432 map, so we need not allocate another array for it.
15433 - We need to add alot of checks for if (params | locals) == null
15434 due to the first two changes.
15436 2004-01-18 Miguel de Icaza <miguel@ximian.com>
15438 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
15439 implement IMemoryLocation, we store a copy on a local variable and
15440 take the address of it. Patch from Benjamin Jemlich
15442 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
15443 to use a special "type_name_expression" rule which reduces the
15444 number of "QualifiedIdentifier" classes created, and instead
15445 directly creates MemberAccess expressions.
15447 2004-01-17 Miguel de Icaza <miguel@ximian.com>
15449 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
15450 that fixes #52853. Null literal assignment to ValueType
15452 * class.cs (MethodData.Emit): Instead of checking the name of the
15453 method to determine if its a destructor, create a new derived
15454 class from Method called Destructor, and test for that.
15456 * cs-parser.jay: Create a Destructor object instead of a Method.
15458 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15462 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15464 * expression.cs (Binary.ResolveOperator): Perform an implicit
15465 conversion from MethodGroups to their delegate types on the
15466 Addition operation.
15468 * delegate.cs: Introduce a new class DelegateCreation that is the
15469 base class for `NewDelegate' and `ImplicitDelegateCreation',
15470 factor some code in here.
15472 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15473 conversion from MethodGroups to compatible delegate types.
15475 * ecore.cs (Expression.Resolve): Do not flag error 654
15476 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15477 we allow conversions from MethodGroups to delegate types now.
15479 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15480 assignments in v2 either.
15482 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15484 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15485 static read-only fields in ctors.
15487 Applied patch from Benjamin Jemlich
15489 * expression.cs (UnaryMutator): Avoid leaking local variables.
15491 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15493 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15494 here to return true, as they can be used like this:
15496 (XXX) int.MEMBER ()
15498 Fixed 49836 and all the other dups
15500 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15502 * driver.cs: Implement /win32res and /win32icon.
15504 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15506 * cs-parser.jay: Add a rule to improve error handling for the
15507 common mistake of placing modifiers after the type.
15509 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15511 * cs-parser.jay (interface_event_declaration): Catch
15512 initialization of events on interfaces, and report cs0068
15514 * cs-parser.jay (interface_event_declaration): Catch
15515 initialization of events.
15517 * ecore.cs: Better report missing constructors.
15519 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15520 the error reporting done in the wrong place. Fix.
15522 * expression.cs (Binary.ResolveOperator): Catch the
15523 operator + (E x, E y) error earlier, and later allow for implicit
15524 conversions in operator +/- (E e, U x) from U to the underlying
15527 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15528 52596, if the container class is abstract, the default constructor
15529 is protected otherwise its public (before, we were always public).
15531 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15534 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15535 Jemlich that fixes bug #52597, MCS was generating invalid code for
15536 idisposable structs. Thanks to Ben for following up with this
15539 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15541 * driver.cs: Allow assemblies without code to be generated, fixes
15544 2004-01-07 Nick Drochak <ndrochak@gol.com>
15546 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15548 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15550 * cs-parser.jay: Add rules to improve error reporting if fields or
15551 methods are declared at the namespace level (error 116)
15553 * Add rules to catch event add/remove
15555 2004-01-04 David Sheldon <dave-mono@earth.li>
15557 * expression.cs: Added matching ")" to error message for
15560 2004-01-03 Todd Berman <tberman@gentoo.org>
15562 * ecore.cs, attribute.cs:
15563 Applying fix from #52429.
15565 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15567 * ecore.cs, expression.cs, statement.cs:
15568 Total rewrite of how we handle branching. We
15569 now handle complex boolean expressions with fewer
15570 jumps. As well if (x == 0) no longer emits a ceq.
15572 if (x is Foo) is much faster now, because we generate
15575 Overall, we get a pretty big improvement on our benchmark
15576 tests. The code we generate is smaller and more readable.
15578 I did a full two-stage bootstrap. The patch was reviewed
15579 by Martin and Miguel.
15581 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15583 * cs-parser.jay: Make primary_expression not take a QI.
15584 we dont need this because the member_access rule covers
15585 us here. So we replace the rule with just IDENTIFIER.
15587 This has two good effects. First, we remove a s/r conflict.
15588 Second, we allocate many fewer QualifiedIdentifier objects.
15590 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15592 * attribute.cs: Handle MarshalAs attributes as pseudo, and
15593 set the correct information via SRE. This prevents
15594 hanging on the MS runtime. Fixes #29374.
15596 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15598 * convert.cs: correctly handle conversions to value types
15599 from Enum and ValueType as unboxing conversions.
15601 Fixes bug #52569. Patch by Benjamin Jemlich.
15603 2004-01-02 Ravi Pratap <ravi@ximian.com>
15605 * expression.cs (BetterConversion): Prefer int -> uint
15606 over int -> ulong (csc's behaviour). This fixed bug #52046.
15608 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
15610 * decl.cs (MemberCache.FindMembers): now returns a
15613 * typemanager.cs: In general, go with with ^^.
15614 (CopyNewMethods): take an IList.
15615 (RealMemberLookup): Only allocate an arraylist
15616 if we copy from two sets of methods.
15618 This change basically does two things:
15619 1) Fewer array lists allocated due to CopyNewMethods.
15620 2) the explicit cast in MemberList costed ALOT.
15622 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
15624 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
15625 a hashtable to avoid needless string allocations when an identifier is
15626 used more than once (the common case).
15628 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15630 * pending.cs: MS's TypeBuilder.GetInterfaces ()
15631 is broken, it will not return anything. So, we
15632 have to use the information we have in mcs to
15635 * typemanager.cs: Add a cache for GetInterfaces,
15636 since this will now be used more often (due to ^^)
15638 (GetExplicitInterfaces) New method that gets the
15639 declared, not effective, interfaces on a type
15640 builder (eg, if you have interface IFoo, interface
15641 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
15644 This patch makes MCS able to bootstrap itself on
15647 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15649 * expression.cs: Remove the Nop's that Miguel put
15652 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15654 * report.cs, codegen.cs: Give the real stack trace to
15655 the error when an exception is thrown.
15657 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15659 * decl.cs: only allocate hashtables for ifaces if
15662 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15664 * expression.cs: fix the error from cs0121-2.cs
15665 (a parent interface has two child interfaces that
15666 have a function with the same name and 0 params
15667 and the function is called through the parent).
15669 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
15671 * class.cs, rootcontext.cs, typmanager.cs: do not
15674 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
15676 * codegen.cs: remove stack for the ec flow branching.
15677 It is already a linked list, so no need.
15679 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
15681 * Makefile: Allow custom profiler here.
15683 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
15685 * typemanager.cs (LookupType):
15686 - Use a static char [], because split takes
15687 a param array for args, so it was allocating
15689 - Do not store true in a hashtable, it boxes.
15691 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
15693 * flowanalysis.cs: bytify common enums.
15695 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15697 * modifiers.cs: Add a new set of flags for the
15698 flags allowed on explicit interface impls.
15699 * cs-parser.jay: catch the use of modifiers in
15700 interfaces correctly.
15701 * class.cs: catch private void IFoo.Blah ().
15703 All related to bug #50572.
15705 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15707 * decl.cs: Rewrite the consistant accessability checking.
15708 Accessability is not linear, it must be implemented in
15709 a tableish way. Fixes #49704.
15711 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15713 * expression.cs: Handle negation in a checked context.
15714 We must use subtraction from zero. Fixes #38674.
15716 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15718 * class.cs: Ignore static void main in DLLs.
15719 * rootcontext.cs: Handle the target type here,
15720 since we are have to access it from class.cs
15721 * driver.cs: account for the above.
15723 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15725 * report.cs: Give line numbers and files if available.
15727 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
15729 * driver.cs: Implement /addmodule.
15731 * typemanager.cs: Change 'modules' field so it now contains Modules not
15734 2003-12-20 Martin Baulig <martin@ximian.com>
15736 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
15737 (FieldBase.IsAssigned): Removed this field.
15738 (FieldBase.SetAssigned): New public method.
15739 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
15741 2003-12-20 Martin Baulig <martin@ximian.com>
15743 * expression.cs (LocalVariableReference.DoResolve): Don't set
15744 `vi.Used' if we're called from DoResolveLValue().
15746 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
15747 returns the usage vector it just merged into the current one -
15748 pass this one to UsageWarning().
15749 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
15750 of the `EmitContext', don't call this recursively on our children.
15752 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
15754 * driver.cs: Implement /target:module.
15756 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
15758 * support.cs (CharArrayHashtable): New helper class.
15760 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
15761 char arrays, not strings, so we can avoid creating a string in
15762 consume_identifier if the identifier is a keyword.
15764 2003-12-16 Martin Baulig <martin@ximian.com>
15766 * statement.cs (LocalInfo.Assigned): Removed this property.
15767 (LocalInfo.Flags): Removed `Assigned'.
15768 (LocalInfo.IsAssigned): New public method; takes the EmitContext
15769 and uses flow analysis.
15770 (Block.UsageWarning): Made this method private.
15771 (Block.Resolve): Call UsageWarning() if appropriate.
15773 * expression.cs (LocalVariableReference.DoResolve): Always set
15774 LocalInfo.Used here.
15776 2003-12-13 Martin Baulig <martin@ximian.com>
15778 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
15779 any value here; we're now using flow analysis to figure out
15780 whether a statement/block returns a value.
15782 2003-12-13 Martin Baulig <martin@ximian.com>
15784 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
15786 (FlowBranching.MergeFinally): Don't call
15787 `branching.CheckOutParameters()' here, this is called in
15789 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
15790 when adding the `finally' vector.
15792 2003-12-13 Martin Baulig <martin@ximian.com>
15795 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
15796 actually work and also fix #48962.
15798 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
15800 * decl.cs: Do not check System.Object for nested types,
15801 since we know it does not have any. Big bang for buck:
15804 Run 1: 8.35 seconds
15805 Run 2: 8.32 seconds
15806 corlib: 17.99 seconds
15808 Run 1: 8.17 seconds
15809 Run 2: 8.17 seconds
15810 corlib: 17.39 seconds
15812 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
15814 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
15815 time we are returning 0 members, so we save alot here.
15817 2003-12-11 Martin Baulig <martin@ximian.com>
15819 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
15820 `MergeChild()', also just take the `FlowBranching' as argument;
15821 call Merge() on it and return the result.
15822 (FlowBranching.Merge): We don't need to do anything if we just
15825 2003-12-11 Martin Baulig <martin@ximian.com>
15827 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
15828 them in an `ArrayList' to reduce memory usage. Thanks to Ben
15829 Maurer for this idea.
15831 2003-12-11 Martin Baulig <martin@ximian.com>
15833 * flowanalysis.cs (MergeResult): This class is now gone; we now
15834 use the `UsageVector' for this. The reason for this is that if a
15835 branching just has one sibling, we don't need to "merge" them at
15836 all - that's the next step to do.
15837 (FlowBranching.Merge): We now return a `UsageVector' instead of a
15840 2003-12-11 Martin Baulig <martin@ximian.com>
15842 Reworked flow analyis and made it more precise and bug-free. The
15843 most important change is that we're now using a special `Reachability'
15844 class instead of having "magic" meanings of `FlowReturns'. I'll
15845 do some more cleanups and optimizations and also add some more
15846 documentation this week.
15848 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
15849 largely reworked this class.
15850 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
15851 the new `Reachability' class instead of having "magic" values here.
15852 (FlowBranching): We're now using an instance of `Reachability'
15853 instead of having separate `Returns', `Breaks' etc. fields.
15855 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
15856 based on flow analysis; ignore the return value of block.Emit ().
15858 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
15860 * driver.cs typemanager.cs: Find the mono extensions to corlib even
15861 if they are private.
15863 2003-12-09 Martin Baulig <martin@ximian.com>
15865 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
15866 call them directly on the UsageVector.
15868 2003-12-09 Martin Baulig <martin@ximian.com>
15870 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
15871 Changed return type from `FlowReturns' to `Reachability'.
15873 2003-12-09 Martin Baulig <martin@ximian.com>
15875 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
15876 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
15877 `Reachable' fields with a single `Reachability' one.
15879 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15881 * class.cs (FindMembers): Remove foreach's.
15886 Run 1: 8.74 seconds
15887 Run 2: 8.71 seconds
15890 Run 1: 8.64 seconds
15891 Run 2: 8.58 seconds
15894 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15899 This patch does a few things:
15900 1. EmptyStatement is now a singleton, so it is never reallocated.
15901 2. All blah is EmptyStatement constructs have been changed to
15902 blah == EmptyStatement.Value, which is much faster and valid
15903 now that EmptyStatement is a singleton.
15904 3. When resolving a block, rather than allocating a new array for
15905 the non-empty statements, empty statements are replaced with
15906 EmptyStatement.Value
15907 4. Some recursive functions have been made non-recursive.
15908 Mainly the performance impact is from (3), however (1) and (2) are needed for
15909 this to work. (4) does not make a big difference in normal situations, however
15910 it makes the profile look saner.
15915 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15916 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15917 Total memory allocated: 56397 KB
15920 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
15921 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
15922 Total memory allocated: 55666 KB
15924 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15926 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15927 than the hashtable in a hashtable version
15929 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
15930 we always end up concating a string. This results in a huge perf
15931 loss, because many strings have to be tracked by the GC. In this
15932 patch, we first use a hashtable that works with two keys, so that
15933 the strings do not need to be concat'ed.
15937 Run 1: 8.74 seconds
15938 Run 2: 8.71 seconds
15941 Run 1: 8.65 seconds
15942 Run 2: 8.56 seconds
15944 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15946 * Makefile: Add a new target `do-time' that does a quick and simple
15947 profile, leaving easy to parse output.
15949 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
15951 * codegen.cs (Init): Create the dynamic assembly with
15952 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
15954 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
15956 * support.cs: Make the PtrHashtable use only one
15957 instance of its comparer.
15959 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
15961 * typemanager.cs: Fix lookup of GetNamespaces.
15963 2003-11-29 Miguel de Icaza <miguel@ximian.com>
15965 * expression.cs: Removed redundant line.
15967 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
15968 ArrayLists, use for loops with bounds.
15970 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
15973 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
15974 arraylists, use for loop with bounds.
15976 The above three changes give us a 0.071 second performance
15977 improvement out of 3.294 seconds down to 3.223. On my machine
15978 the above changes reduced the memory usage by 1,387 KB during
15979 compiler bootstrap.
15981 * cs-parser.jay (QualifiedIdentifier): New class used to represent
15982 QualifiedIdentifiers. Before we created a new string through
15983 concatenation, and mostly later on, the result would be
15984 manipulated by DecomposeQI through string manipulation.
15986 This reduced the compiler memory usage for bootstrapping from
15987 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
15988 compile times in 0.05 seconds.
15990 2003-11-28 Dick Porter <dick@ximian.com>
15992 * support.cs: Do string compares with the Invariant culture.
16000 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
16001 the comparison is done with the Invariant culture.
16003 2003-11-27 Miguel de Icaza <miguel@ximian.com>
16005 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
16006 GetEnumerator method.
16008 (ProbeCollectionType): Iterate starting at the most specific type
16009 upwards looking for a GetEnumerator
16011 * expression.cs: Shift count can be up to 31 for int/uint and 63
16014 2003-11-26 Miguel de Icaza <miguel@ximian.com>
16016 * statement.cs (Block.LookupLabel): Also look for the label on the
16017 children blocks. Use a hash table to keep track of visited
16020 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
16021 we actually did transform the other operand, otherwise fall back
16022 to the common codepath that casts to long.
16024 * cs-tokenizer.cs: Use the same code pattern as the int case.
16025 Maybe I should do the parsing myself, and avoid depending on the
16026 Parse routines to get this done.
16028 2003-11-25 Miguel de Icaza <miguel@ximian.com>
16030 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16031 which fixes bug 51347. This time test it.
16033 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
16034 attributes for example can not tell the difference between these.
16035 The difference was only a syntax feature of the language.
16037 * attribute.cs: Apply attributes to delegates.
16039 * delegate.cs: Call the apply attributes method.
16041 2003-11-24 Miguel de Icaza <miguel@ximian.com>
16043 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
16044 comparing 0 vs Byte.MinValue, not the value
16046 (ImplicitConversionRequired): When reporting a conversion error,
16047 use error 31 to print out the constant error instead of the
16050 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16051 which fixes bug 51347.
16053 2003-11-22 Miguel de Icaza <miguel@ximian.com>
16055 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
16056 which fixes the -warnaserror command line option.
16058 2003-11-21 Miguel de Icaza <miguel@ximian.com>
16060 * cfold.cs (DoNumericPromotions): During constant folding of
16061 additions on UIntConstant, special case intconstants with
16062 IntConstants like we do on the expression binary operator.
16064 2003-11-12 Miguel de Icaza <miguel@ximian.com>
16066 * convert.cs (ImplicitReferenceConversion): We were missing a case
16067 (System.Enum are not value types or class types, so we need to
16068 classify them separatedly).
16070 * driver.cs: We do not support error 2007.
16072 2003-11-12 Jackson Harper <jackson@ximian.com>
16074 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
16075 system directory. Also use the full file name so users can
16076 libraries names mscorlib-o-tron.dll in a non system dir.
16078 2003-11-10 Martin Baulig <martin@ximian.com>
16080 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
16081 (TypeManager.InitCoreTypes): Initialize them here, but instead of
16082 calling `ResolveType()' on them, directly assign their `Type'.
16084 2003-11-08 Martin Baulig <martin@ximian.com>
16086 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
16087 return value and the `out parent' parameter.
16088 (TypeContainer.DefineType): Moved the CS0644 check into
16089 GetClassBases(). Don't pass the interface types to the
16090 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
16091 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
16093 * ecore.cs (TypeExpr.IsAttribute): New property.
16094 (TypeExpr.GetInterfaces): New method.
16096 * interface.cs (Interface.GetInterfaceTypeByName): Return a
16097 TypeExpr instead of a Type.
16098 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
16099 (Interface.DefineType): Don't pass the interface types to the
16100 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
16101 them later and then call `TypeBulider.AddInterfaceImplementation()'.
16103 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
16104 instead of a `Type[]'.
16105 (TypeManager.RegisterBuilder): Likewise.
16106 (TypeManager.AddUserInterface): Likewise.
16107 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
16108 `Type[]' and also return a `TypeExpr[]'.
16109 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
16111 2003-11-08 Martin Baulig <martin@ximian.com>
16113 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
16116 2003-11-08 Martin Baulig <martin@ximian.com>
16118 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
16119 TypeManager.ResolveExpressionTypes().
16121 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
16122 instead of an Expression.
16123 (TypeExpr): This is now an abstract base class for `TypeExpression'.
16124 (TypeExpression): New public class; formerly known as `TypeExpr'.
16126 * expression.cs (ComposedCast): Derive from TypeExpr.
16128 * typemanager.cs (TypeManager.system_*_expr): These are now
16129 TypExpr's instead of Expression's.
16130 (TypeManager.ResolveExpressionTypes): New public static function;
16131 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
16134 2003-11-06 Miguel de Icaza <miguel@ximian.com>
16136 * expression.cs (New.DoResolve): Do not dereference value that
16137 might be a null return.
16139 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
16140 sure that the constant value has the right type. Fixes an
16141 unreported bug, similar to 50425.
16143 * const.cs (Const.LookupConstantValue): Call
16144 ImplicitStandardConversionExists before doing a conversion to
16145 avoid havng the TypeManager.ChangeType do conversions.
16147 Reduced the number of casts used
16149 (Const.ChangeType): New routine to enable reuse of the constant
16150 type changing code from statement.
16152 * typemanager.cs (ChangeType): Move common initialization to
16153 static global variables.
16157 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
16158 every value type to go through, even if it was void. Fix that.
16160 * cs-tokenizer.cs: Use is_identifier_start_character on the start
16161 character of the define, and the is_identifier_part_character for
16162 the rest of the string.
16164 2003-11-05 Miguel de Icaza <miguel@ximian.com>
16166 * expression.cs (UnaryMutator.EmitCode): When I updated
16167 LocalVariableReference.DoResolve, I overdid it, and dropped an
16168 optimization done on local variable references.
16170 2003-11-04 Miguel de Icaza <miguel@ximian.com>
16172 * ecore.cs: Convert the return from Ldlen into an int.
16174 2003-10-20 Miguel de Icaza <miguel@ximian.com>
16176 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
16177 the accessibility, this is a special case for toplevel non-public
16178 classes (internal for instance).
16180 2003-10-20 Nick Drochak <ndrochak@gol.com>
16182 * ecore.cs: Fix typo and build. Needed another right paren.
16184 2003-10-19 Miguel de Icaza <miguel@ximian.com>
16186 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
16187 `internal' case regular and protected, but not allowing protected
16188 to be evaluated later. Bug 49840
16190 2003-10-15 Miguel de Icaza <miguel@ximian.com>
16192 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
16193 to kb.Nlast, and not the kb.nFirst to isolate the switch
16196 Extract the underlying type, so enumerations of long/ulong are
16197 treated like long/ulong.
16199 2003-10-14 Miguel de Icaza <miguel@ximian.com>
16201 * expression.cs (New): Overload the meaning of RequestedType to
16202 track the possible creation of the NewDelegate type, since
16203 DoResolve is invoked more than once for new constructors on field
16206 See bugs: #48800 and #37014
16208 * cs-parser.jay (declare_local_constants): Take an arraylist
16209 instead of a single constant.
16211 (local_constant_declaration): It should take a
16212 constant_declarators, not a constant_declarator. Fixes 49487
16214 * convert.cs: Fix error report.
16216 2003-10-13 Jackson Harper <jackson@ximian.com>
16218 * typemanager.cs (TypeToCoreType): Add float and double this fixes
16221 2003-10-09 Martin Baulig <martin@ximian.com>
16223 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
16225 (MethodCore.DoDefineParameters): Removed the TypeContainer
16226 argument; use the DeclSpace which was passed to the .ctor instead.
16227 (MethodCore.CheckParameter): Take a DeclSpace instead of a
16228 TypeContainer; we only need a DeclSpace here.
16230 2003-10-09 Martin Baulig <martin@ximian.com>
16232 * class.cs (MethodData): Added additional `DeclSpace ds' argument
16234 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
16235 EmitContext's .ctor.
16237 2003-10-09 Martin Baulig <martin@ximian.com>
16239 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
16240 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
16241 AsAccessible(), moved them as well.
16243 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
16245 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
16247 * cs-parser.jay : Renamed yyName to yyNames related to jay.
16249 2003-10-07 Miguel de Icaza <miguel@ximian.com>
16251 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
16252 generation for >=, as spotted by Paolo, bug 48679.
16253 Patch from David Waite.
16255 * cs-tokenizer.cs: Add handling for #pragma.
16257 * cs-parser.jay: Allow for both yield and yield return in the
16258 syntax. The anti-cobolization of C# fight will go on!
16260 * class.cs (TypeBuilder.DefineType): Catch error condition here
16261 (Parent.DefineType erroring out and returning null).
16263 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16264 coping with enumerations variables, we were mistakenly processing
16265 them as a regular value type instead of built-in types. Fixes the
16268 * typemanager.cs (IsBuiltinOrEnum): New method.
16270 2003-09-30 Miguel de Icaza <miguel@ximian.com>
16272 * cs-parser.jay: Upgrade: yield now needs the return clause.
16274 2003-09-19 Martin Baulig <martin@ximian.com>
16276 * decl.cs (MemberCache.SetupCacheForInterface): Take a
16277 `MemberCache parent' argument. Normally, an interface doesn't
16278 have a parent type except System.Object, but we use this in gmcs
16279 for generic type parameters.
16281 2003-09-18 Martin Baulig <martin@ximian.com>
16283 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
16284 on `type.IsInterface'; don't check whether the type has a parent
16285 to determine whether it's an interface.
16287 2003-09-15 Martin Baulig <martin@ximian.com>
16289 * class.cs (TypeContainer.DefineType): Added an error flag to
16290 avoid reporting duplicate CS0146's ("class definition is
16293 * driver.cs (Driver.MainDriver): Abort if
16294 RootContext.ResolveTree() reported any errors.
16296 2003-09-07 Martin Baulig <martin@ximian.com>
16298 * report.cs (Error, Warning): Added overloaded versions which take
16299 a `params object[] args' and call String.Format().
16301 2003-09-07 Martin Baulig <martin@ximian.com>
16303 * decl.cs (DeclSpace..ctor): Don't call
16304 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
16305 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
16306 (DeclSpace.RecordDecl): New method.
16308 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
16310 2003-09-02 Ravi Pratap <ravi@ximian.com>
16312 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
16313 value attributes to be applied to ParameterBuilders.
16315 * class.cs (MethodCore.LabelParameters): Make static and more
16316 generic so that it can be used from other places - like interface
16317 methods, for instance.
16319 * interface.cs (Interface.Emit): Call LabelParameters before
16320 emitting attributes on the InterfaceMethod.
16322 2003-08-26 Martin Baulig <martin@ximian.com>
16324 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
16325 resolving aliases; fixes #47927.
16327 2003-08-26 Martin Baulig <martin@ximian.com>
16329 * statement.cs (Using.DoResolve): This is internally emitting a
16330 try/finally clause, so we need to set ec.NeedExplicitReturn if we
16331 do not always return. Fixes #47681.
16333 2003-08-26 Martin Baulig <martin@ximian.com>
16335 * decl.cs (MemberCore): Moved WarningNotHiding(),
16336 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
16338 (AdditionResult): Make this nested in DeclSpace.
16339 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
16340 argument; call NamespaceEntry.Define() unless we're nested in a
16343 * namespace.cs (Namespace.DefineName): New public function. This
16344 is called from DeclSpace's .ctor to add
16345 (Namespace.Lookup): Include DeclSpaces in the lookup.
16347 * class.cs (Operator): Derive from MemberBase, not MemberCore.
16349 * const.cs (Const): Derive from MemberBase, not MemberCore.
16351 2003-08-25 Martin Baulig <martin@ximian.com>
16353 * convert.cs (Convert.ExplicitReferenceConversion): When
16354 converting from an interface type to a class, unbox if the target
16355 type is a struct type. Fixes #47822.
16357 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16359 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
16362 2003-08-22 Martin Baulig <martin@ximian.com>
16364 * class.cs (TypeManager.DefineType): When defining a nested type,
16365 call DefineType() on our parent; fixes #47801.
16367 2003-08-22 Martin Baulig <martin@ximian.com>
16369 * class.cs (MethodData.Define): While checking if a method is an
16370 interface implementation, improve the test a bit more to fix #47654.
16372 2003-08-22 Martin Baulig <martin@ximian.com>
16374 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
16375 correctly; fixes #47722.
16377 2003-08-22 Martin Baulig <martin@ximian.com>
16379 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
16380 LocalVariableReference, ensure it's not read-only. Fixes #47536.
16382 * statement.cs (Fixed.DoResolve): Make all variables read-only.
16384 2003-08-22 Martin Baulig <martin@ximian.com>
16386 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
16387 can only be assigned in static constructors. Fixes #47161.
16389 2003-08-22 Martin Baulig <martin@ximian.com>
16391 Rewrote and improved the flow analysis code.
16393 * flowbranching.cs (FlowBranching): Make this class abstract.
16394 (FlowBranching.CreateBranching): New static function to create a
16395 new flow branching.
16396 (FlowBranchingBlock, FlowBranchingException): New classes.
16397 (FlowBranching.UsageVector.Type): New public readonly field.
16398 (FlowBranching.UsageVector.Breaks): Removed the setter.
16399 (FlowBranching.UsageVector.Returns): Removed the setter.
16400 (FlowBranching.UsageVector): Added Break(), Return(),
16401 NeverReachable() and Throw() methods to modify the reachability.
16402 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
16403 done by FlowBranching.Merge().
16404 (FlowBranching.UsageVector.MergeChild): New method; merges the
16405 merge result into the current vector.
16406 (FlowBranching.Merge): New abstract method to merge a branching.
16408 2003-08-12 Martin Baulig <martin@ximian.com>
16410 * expression.cs (Indirection.CacheTemporaries): Create the
16411 LocalTemporary with the pointer type, not its element type.
16413 2003-08-10 Miguel de Icaza <miguel@ximian.com>
16415 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
16416 token was a keyword or not.
16418 Add `error' options where an IDENTIFIER was expected; Provide
16419 CheckToken and CheckIdentifierToken convenience error reporting
16422 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
16424 * decl.cs: Rename `NamespaceEntry Namespace' public field into
16425 NameSpaceEntry NameSpaceEntry.
16427 (LookupInterfaceOrClass): Avoid creating a full qualified name
16428 from namespace and name: avoid doing lookups when we know the
16429 namespace is non-existant. Use new Tree.LookupByNamespace which
16430 looks up DeclSpaces based on their namespace, name pair.
16432 * driver.cs: Provide a new `parser verbose' to display the
16433 exception thrown during parsing. This is turned off by default
16434 now, so the output of a failure from mcs is more graceful.
16436 * namespace.cs: Track all the namespaces defined in a hashtable
16439 (IsNamespace): New method
16441 2003-08-09 Miguel de Icaza <miguel@ximian.com>
16443 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
16444 we know that we need to concatenate (full typename can never be
16449 * statement.cs: Use a bitfield; Do not initialize to null things
16450 which are done by the constructor by default.
16452 * cs-parser.jay: bug fix, parameter was 4, not 3.
16454 * expression.cs: Just use the property;
16456 * statement.cs: No need for GetVariableInfo method.
16458 2003-08-08 Martin Baulig <martin@ximian.com>
16460 * flowanalysis.cs (FlowReturns): This is now nested in the
16461 `FlowBranching' class.
16462 (MyBitVector): Moved this here from statement.cs.
16463 (FlowBranching.SiblingType): New enum type.
16464 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16466 2003-08-07 Martin Baulig <martin@ximian.com>
16468 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16469 `FlowBranching' class and called `BranchingType'.
16471 2003-08-07 Martin Baulig <martin@ximian.com>
16473 * flowanalysis.cs: Moved all the control flow analysis code into
16476 2003-08-07 Martin Baulig <martin@ximian.com>
16478 * assign.cs (Assign.DoResolve): `target' must either be an
16479 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16482 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16484 * expression.cs (BinaryMethod): This kind of expression is created by the
16485 Binary class if it determines that the operator has to be handled
16488 (BinaryDelegate): This kind of expression is created if we are
16489 dealing with a + or - operator on delegates.
16491 (Binary): remove method, argumetns, and DelegateOperator: when
16492 dealing with methods,
16494 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16496 * statement.cs (Block): use bitfields for the three extra booleans
16497 we had in use. Remove unused topblock parameter.
16499 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16501 * assign.cs: Drop extra unneeded tests.
16503 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16505 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16507 * statement.cs (Foreach): Use VariableStorage instead of
16510 * codegen.cs (VariableStorage): New class used by clients that
16511 require a variable stored: locals or fields for variables that
16512 need to live across yield.
16514 Maybe provide a convenience api for EmitThis+EmitLoad?
16516 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16519 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16521 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16522 RemapParameterLValue): New methods that are used to turn a
16523 precomputed FieldInfo into an expression like this:
16527 The idea is to use this instead of making LocalVariableReference
16528 have more than one meaning.
16530 * cs-parser.jay: Add error production to BASE.
16532 * ecore.cs: Deal with TypeManager.GetField returning null, which
16533 is now a valid return value.
16535 (FieldExprNoAddress): New expression for Fields whose address can
16538 * expression.cs (LocalVariableReference): During the resolve
16539 phases, create new expressions if we are in a remapping context.
16540 Remove code that dealt with remapping here.
16542 (ParameterReference): same.
16544 (ProxyInstance): New expression, like the `This' expression, but
16545 it is born fully resolved. We know what we are doing, so remove
16546 the errors that are targeted to user-provided uses of `this'.
16548 * statement.cs (Foreach): our variable is now stored as an
16549 Expression; During resolution, follow the protocol, dont just
16550 assume it will return this.
16552 2003-08-06 Martin Baulig <martin@ximian.com>
16554 * support.cs (SeekableStreamReader.cs): New public class.
16556 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16557 SeekableStreamReader instead of the normal StreamReader.
16559 2003-08-04 Martin Baulig <martin@ximian.com>
16561 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16562 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16563 deambiguate casts and delegate invocations.
16564 (parenthesized_expression): Use the new tokens to ensure this is
16565 not a cast of method invocation.
16567 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16568 when reading a `)' and Deambiguate_CloseParens () was previously
16571 * expression.cs (ParenthesizedExpression): New class. This is
16572 just used for the CS0075 test.
16573 (Binary.DoResolve): Check for CS0075.
16575 2003-07-29 Ravi Pratap <ravi@ximian.com>
16577 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
16578 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
16579 reference comparison.
16581 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
16582 examine the ReturnType for equality - this is necessary in the
16583 cases of implicit and explicit operators whose signature also
16584 includes the return type.
16586 2003-07-26 Miguel de Icaza <miguel@ximian.com>
16588 * namespace.cs: Cache the result of the namespace computation,
16589 instead of computing it every time.
16591 2003-07-24 Miguel de Icaza <miguel@ximian.com>
16593 * decl.cs: Use a global arraylist that we reuse over invocations
16594 to avoid excesive memory consumption. Reduces memory usage on an
16595 mcs compile by one meg (45 average).
16597 * typemanager.cs (LookupTypeReflection): In .NET pointers are
16598 private, work around that.
16600 2003-07-23 Miguel de Icaza <miguel@ximian.com>
16602 * literal.cs (IntLiteral): Define Zero and One static literals.
16604 * cs-parser.jay (integer_literal): use static literals to reduce
16605 memory usage for the most used literals (0, 1 and -1). 211kb
16606 reduced in memory usage.
16608 Replace all calls to `new ArrayList' with `new
16609 ArrayList(4)' which is a good average number for most allocations,
16610 and also requires only 16 bytes of memory for its buffer by
16613 This reduced MCS memory usage in seven megabytes for the RSS after
16616 2003-07-28 Ravi Pratap <ravi@ximian.com>
16618 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
16619 handle params methods the correct way by forming only one
16620 applicable set with params and normal methods in them. Earlier we
16621 were looking at params methods only if we found no normal methods
16622 which was not the correct thing to do.
16624 (Invocation.BetterFunction): Take separate arguments indicating
16625 when candidate and the best method are params methods in their
16628 This fixes bugs #43367 and #46199.
16630 * attribute.cs: Documentation updates.
16632 (CheckAttribute): Rename to CheckAttributeTarget.
16633 (GetValidPlaces): Rename to GetValidTargets.
16635 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
16636 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
16640 2003-07-28 Martin Baulig <martin@ximian.com>
16642 * class.cs (TypeContainer.DefineMembers): Use the base type's full
16643 name when looking up the base class of a nested class. Fixes #46977.
16645 2003-07-26 Martin Baulig <martin@ximian.com>
16647 * expression.cs (Indexers.Indexer): New nested struct; contains
16648 getter, setter and the indexer's type.
16649 (Indexers.Properties): This is now an ArrayList of
16650 Indexers.Indexer's.
16651 (IndexerAccess.DoResolveLValue): Correctly set the type if the
16652 indexer doesn't have any getters.
16654 * assign.cs (Assign.DoResolve): Also do the implicit conversions
16655 for embedded property and indexer assignments.
16657 2003-07-26 Martin Baulig <martin@ximian.com>
16659 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
16660 preprocessor directive is not the first non-whitespace character
16663 2003-07-26 Martin Baulig <martin@ximian.com>
16665 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
16666 namespace parsing, follow the spec more closely.
16668 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
16669 NamespaceEntry.Lookup().
16671 2003-07-25 Martin Baulig <martin@ximian.com>
16673 * MethodCore.cs (OverridesSomething): New public field; it's set
16674 from TypeContainer.DefineMembers if this method overrides
16675 something (which doesn't need to be a method). Fix #39462.
16677 2003-07-25 Ravi Pratap <ravi@ximian.com>
16679 * typemanager.cs (GetMembers): Ensure that the list of members is
16680 reversed. This keeps things in sync.
16682 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
16683 find an AttributeUsage attribute.
16685 * expression.cs (Invocation.OverloadResolve): Perform the check
16686 which disallows Invoke to be directly called on a Delegate.
16688 (Error_InvokeOnDelegate): Report error cs1533.
16690 2003-07-25 Martin Baulig <martin@ximian.com>
16692 * expression.cs (Indexers.GetIndexersForType): Only look in the
16693 interface hierarchy if the requested type is already an
16694 interface. Fixes #46788 while keeping #46502 fixed.
16696 2003-07-25 Martin Baulig <martin@ximian.com>
16698 * class.cs (TypeContainer.DefineMembers): Check whether all
16699 readonly fields have been assigned and report warning CS0649 if
16702 * statement.cs (LocalInfo.IsFixed): Always return true if this is
16705 2003-07-24 Ravi Pratap <ravi@ximian.com>
16707 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
16708 returned from GetMethods to make things consistent with the
16709 assumptions MCS makes about ordering of methods.
16711 This should comprehensively fix bug #45127 and it does :-)
16713 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
16714 ordering is actually reverse.
16716 * Clean up some debug messages I left lying around.
16718 * interface.cs (Populate*): Get rid of code which emits attributes
16719 since the stage in which we emit attributes is the 'Emit' stage,
16720 not the define stage.
16722 (Emit): Move attribute emission for interface members here.
16724 2003-07-22 Ravi Pratap <ravi@ximian.com>
16726 * expression.cs (Invocation.OverloadResolve): Follow the spec more
16727 closely: we eliminate methods in base types when we have an
16728 applicable method in a top-level type.
16730 Please see section 14.5.5.1 for an exact description of what goes
16733 This fixes bug #45127 and a host of other related to corlib compilation.
16735 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
16736 array is the method corresponding to the top-level type (this is
16737 because of the changes made to icall.c) so we change this
16740 (MethodGroupExpr.Name): This too.
16742 * typemanager.cs (GetElementType): New method which does the right
16743 thing when compiling corlib.
16745 * everywhere: Make use of the above in the relevant places.
16747 2003-07-22 Martin Baulig <martin@ximian.com>
16749 * cs-parser.jay (invocation_expression): Moved
16750 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
16751 `cast_expression', but create a InvocationOrCast which later
16752 resolves to either an Invocation or a Cast.
16754 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
16755 method; call this before EmitStatement() to make sure that this
16756 expression can be used as a statement.
16758 * expression.cs (InvocationOrCast): New class; resolves to either
16759 an Invocation or a Cast.
16761 * statement.cs (StatementExpression): Call ResolveStatement() on
16762 the ExpressionStatement before emitting it.
16764 2003-07-21 Martin Baulig <martin@ximian.com>
16766 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
16767 `ref' and `out' attributes match; fixes #46220.
16768 (MemberAccess.ResolveMemberAccess): You can't reference a type
16769 through an expression; fixes #33180.
16770 (Indexers.GetIndexersForType): Don't return the indexers from
16771 interfaces the class implements; fixes #46502.
16773 2003-07-21 Martin Baulig <martin@ximian.com>
16775 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
16776 CS0661 checks; fixes bug #30442.
16778 2003-07-21 Martin Baulig <martin@ximian.com>
16780 * decl.cs (AdditionResult): Added `Error'.
16782 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
16784 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
16785 makes cs0031.cs actually work.
16787 2003-07-20 Martin Baulig <martin@ximian.com>
16789 * namespace.cs: Fixed that bug which caused a crash when compiling
16790 the debugger's GUI.
16792 2003-07-20 Miguel de Icaza <miguel@ximian.com>
16794 * typemanager.cs (LookupTypeReflection): Never expose types which
16795 are NotPublic, NestedPrivate, NestedAssembly, or
16796 NestedFamANDAssem. We used to return these, and later do a check
16797 that would report a meaningful error, but the problem is that we
16798 would not get the real match, if there was a name override.
16800 2003-07-18 Miguel de Icaza <miguel@ximian.com>
16802 * namespace.cs (Namespace, Name): Do not compute the namespace
16803 name dynamically, compute it in the constructor. This reduced
16804 memory usage by 1697 KB.
16806 * driver.cs: Use --pause to pause at the end.
16808 2003-07-17 Peter Williams <peter@newton.cx>
16810 * Makefile: Change the name of the test target so that it doesn't
16811 conflict with the recursive test target.
16813 2003-07-17 Miguel de Icaza <miguel@ximian.com>
16815 * expression.cs (LocalVariableReference.Emit, EmitAssign,
16816 AddressOf): Do not use EmitThis, that was wrong, use the actual
16819 2003-07-15 Miguel de Icaza <miguel@ximian.com>
16821 * class.cs (MethodData.Define): While checking if a method is an
16822 interface implementation, improve the test: If we are not public
16823 (use new test here: use the computed MethodAttributes directly,
16824 instead of the parsed modifier flags) check if the `implementing'
16825 method comes from an interface or not.
16827 * pending.cs (VerifyPendingMethods): Slightly better error
16830 * makefile: add test target that does the mcs bootstrap.
16832 2003-07-16 Ravi Pratap <ravi@ximian.com>
16834 * interface.cs (Define): Do nothing here since there are no
16835 members to populate etc. Move the attribute emission out of here
16836 since this was just totally the wrong place to put it. Attribute
16837 application happens during the 'Emit' phase, not in the 'Define'
16840 (Emit): Add this method and move the attribute emission here
16842 * rootcontext.cs (EmitCode): Call the Emit method on interface
16845 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16847 * expression.cs (OverloadResolve): Report error only if Location
16848 is not 'Null' which means that there was a probe going on.
16850 2003-07-14 Martin Baulig <martin@ximian.com>
16852 * expression.cs (ConditionalLogicalOperator): New public class to
16853 implement user defined conditional logical operators.
16854 This is section 14.11.2 in the spec and bug #40505.
16856 2003-07-14 Martin Baulig <martin@ximian.com>
16858 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
16860 2003-07-14 Martin Baulig <martin@ximian.com>
16862 * codegen.cs (EmitContext.InFixedInitializer): New public field.
16864 * ecore.cs (IVariable.VerifyFixed): New interface method.
16866 * expression.cs (Unary.ResolveOperator): When resolving the `&'
16867 operator, check whether the variable is actually fixed. Fixes bug
16868 #36055. Set a variable definitely assigned when taking its
16869 address as required by the spec.
16871 * statement.cs (LocalInfo.IsFixed): New field.
16872 (LocalInfo.MakePinned): Set `IsFixed' to true.
16874 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16876 * attribute.cs (Attribute.Resolve): While doing a Member lookup
16877 for .ctors, ensure that we only ask for members declared in the
16878 attribute type (BindingFlags.DeclaredOnly).
16882 * expression.cs (Error_WrongNumArguments): Report error 1501
16883 correctly the way CSC does.
16885 2003-07-13 Martin Baulig <martin@ximian.com>
16887 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
16888 lookup on the fully qualified name, to make things like "X.X" work
16889 where "X.X" is a fully qualified type name, but we also have a
16890 namespace "X" in the using list. Fixes #41975.
16892 2003-07-13 Martin Baulig <martin@ximian.com>
16894 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
16895 function. If we're a CompoundAssign, we need to create an embedded
16896 CompoundAssign, not an embedded Assign.
16897 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
16900 2003-07-13 Martin Baulig <martin@ximian.com>
16902 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
16903 work to fix bug #46088.
16905 2003-07-13 Ravi Pratap <ravi@ximian.com>
16907 * class.cs (Operator.Emit): Do not emit attributes here - it is
16908 taken care of by the Method class that we delegate too. This takes
16909 care of bug #45876.
16911 2003-07-10 Martin Baulig <martin@ximian.com>
16913 * expression.cs (TypeOfVoid): New class.
16914 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
16916 2003-07-10 Martin Baulig <martin@ximian.com>
16918 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
16921 2003-07-10 Martin Baulig <martin@ximian.com>
16923 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
16924 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16926 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
16928 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
16930 2003-07-10 Martin Baulig <martin@ximian.com>
16932 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
16933 of decimal. Fixes #42850.
16935 NOTE: I also fixed the created byte blob, but this doesn't work on
16936 the MS runtime and csc never produces any byte blobs for decimal
16939 2003-07-10 Martin Baulig <martin@ximian.com>
16941 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
16942 structs; fixes #32068.
16943 (Block.AddChildVariableNames): Fixed #44302.
16945 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16947 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
16949 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16951 * attribute.cs: And this test is onger needed.
16953 2003-07-08 Martin Baulig <martin@ximian.com>
16955 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
16956 inaccessible types. Fixes #36313.
16958 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
16960 * namespace.cs (NamespaceEntry): Create implicit entries for all
16961 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
16962 implicit entries for N1.N2 and N1.
16964 2003-07-08 Martin Baulig <martin@ximian.com>
16966 Rewrote the handling of namespaces to fix a lot of the issues
16967 wrt. `using' aliases etc.
16969 * namespace.cs (Namespace): Splitted this class into a
16970 per-assembly `Namespace' and a per-file `NamespaceEntry'.
16972 * typemanager.cs (TypeManager.IsNamespace): Removed.
16973 (TypeManager.ComputeNamespaces): Only compute namespaces from
16974 loaded assemblies here, not the namespaces from the assembly we're
16975 currently compiling.
16977 2003-07-08 Martin Baulig <martin@ximian.com>
16979 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
16981 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16983 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
16986 I thought about the memory savings here, but LookupTypeReflection
16987 is used under already very constrained scenarios. Compiling
16988 corlib or mcs only exposes one hit, so it would not really reduce
16989 any memory consumption.
16991 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16993 * typemanager.cs: fixes bug #45889 by only adding public types from
16994 other assemblies to the list of known types.
16996 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16998 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
16999 on the type we resolved.
17001 2003-07-05 Martin Baulig <martin@ximian.com>
17003 * pending.cs (PendingImplementation.ParentImplements): Don't
17004 create the proxy if the parent is abstract.
17006 * class.cs (TypeContainer.DefineIndexers): Process explicit
17007 interface implementations first. Fixes #37714.
17009 2003-07-04 Miguel de Icaza <miguel@ximian.com>
17011 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
17012 defined recursively; but since we modify the input parameters
17013 (left is set to `this' temporarily), we reset this value if the
17014 left_is_explicit is false, which gives the original semantics to
17017 * literal.cs (NullPointer): new class used to represent a null
17018 literal in a pointer context.
17020 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
17021 type is a pointer, use a NullPointer object instead of a
17022 NullLiteral. Closes 43687
17024 (ExplicitConversion): Convert pointer values using
17025 the conv opcode to the proper type.
17027 * ecore.cs (New): change ValueTypeVariable property into a method,
17028 that returns whether the valuetype is suitable for being used.
17030 * expression.cs (Binary.DoNumericPromotions): Only return if we
17031 the int constant was a valid uint, and we can return both left and
17032 right as uints. If not, we continue processing, to trigger the
17033 type conversion. This fixes 39018.
17035 * statement.cs (Block.EmitMeta): During constant resolution, set
17036 the CurrentBlock property on the emitcontext, so that we resolve
17037 constants propertly.
17039 2003-07-02 Martin Baulig <martin@ximian.com>
17041 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
17042 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
17044 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
17045 than emitting it here.
17047 * statement.cs: Fixed some more flow analysis bugs.
17049 2003-07-02 Martin Baulig <martin@ximian.com>
17051 * class.cs (MethodData.Define): When implementing interface
17052 methods, set Final unless we're Virtual.
17054 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
17055 check work for interface methods.
17057 2003-07-01 Martin Baulig <martin@ximian.com>
17059 * ecore.cs (EmitContext.This): Replaced this property with a
17060 GetThis() method which takes a Location argument. This ensures
17061 that we get the correct error location for a CS0188.
17063 2003-07-01 Miguel de Icaza <miguel@ximian.com>
17065 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
17066 ImplicitStandardConversion.
17068 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
17070 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
17072 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
17075 2003-06-30 Miguel de Icaza <miguel@ximian.com>
17077 * class.cs (Constructor.Define): Turn off initlocals for unsafe
17080 (MethodData.Define): Turn off initlocals for unsafe methods.
17082 2003-06-29 Miguel de Icaza <miguel@ximian.com>
17084 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
17085 complete; Fixes #37521.
17087 * delegate.cs: Use Modifiers.TypeAttr to compute the
17088 TypeAttributes, instead of rolling our own. This makes the flags
17089 correct for the delegates.
17091 2003-06-28 Miguel de Icaza <miguel@ximian.com>
17093 * class.cs (Constructor.Define): Set the private flag for static
17094 constructors as well.
17096 * cs-parser.jay (statement_expression): Set the return value to
17097 null, to avoid a crash when we catch an error.
17099 2003-06-24 Miguel de Icaza <miguel@ximian.com>
17101 * cs-parser.jay: Applied patch from Jackson that adds support for
17102 extern and unsafe modifiers to destructor declarations.
17104 * expression.cs: Report error 21 if the user is trying to index a
17107 * driver.cs: Add an error message, suggested by the bug report.
17109 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
17110 if we do not have a ": this ()" constructor initializer. Fixes 45149
17112 2003-06-14 Miguel de Icaza <miguel@ximian.com>
17114 * namespace.cs: Add some information to reduce FAQs.
17116 2003-06-13 Miguel de Icaza <miguel@ximian.com>
17118 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
17119 underlying enumeration types. Fixes #43915.
17121 * expression.cs: Treat ushort/short as legal values to be used in
17122 bitwise operations.
17124 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
17126 * delegate.cs: transfer custom attributes for paramenters from
17127 the delegate declaration to Invoke and BeginInvoke.
17129 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
17131 * attribute.cs: handle custom marshalers and emit marshal info
17134 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
17136 * makefile.gnu: Added anonymous.cs to the compiler sources.
17138 2003-05-28 Miguel de Icaza <miguel@ximian.com>
17140 * iterators.cs: Change the name of the proxy class to include two
17143 * cs-parser.jay: Update grammar to include anonymous methods.
17145 * anonymous.cs: new file.
17147 2003-05-27 Miguel de Icaza <miguel@ximian.com>
17149 * class.cs (Field.Define): Add missing test for pointers and
17152 2003-05-27 Ravi Pratap <ravi@ximian.com>
17154 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
17155 we use the stobj opcode.
17157 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
17158 since it wasn't the correct fix.
17160 It still is puzzling that we are required to use stobj for IntPtr
17161 which seems to be a ValueType.
17163 2003-05-26 Miguel de Icaza <miguel@ximian.com>
17165 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
17166 during regular simple name resolution. Now, the trick is that
17167 instead of returning for processing the simplename, we do a
17168 TypeManager.LookupType (ie, a rooted lookup as opposed to a
17169 contextual lookup type). If a match is found, return that, if
17170 not, return for further composition.
17172 This fixes long-standing 30485.
17174 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
17175 using the address to initialize an object, do an Stobj instead of
17176 using the regular Stelem.
17178 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
17179 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
17180 Because if we are a BaseIndexerAccess that value will be true.
17183 * statement.cs (GotoCase.Resolve): Return after reporting an
17184 error, do not attempt to continue.
17186 * expression.cs (PointerArithmetic.Emit): If our operand is a
17187 long, convert our constants to match the operand before
17188 multiplying. Convert to I type before adding. Fixes 43670.
17190 2003-05-14 Ravi Pratap <ravi@ximian.com>
17192 * enum.cs (ImplicitConversionExists) : Rename to
17193 ImplicitEnumConversionExists to remove ambiguity.
17195 * ecore.cs (NullCast): New type of cast expression class which
17196 basically is very similar to EmptyCast with the difference being
17197 it still is a constant since it is used only to cast a null to
17199 (eg. (string) null)
17201 * convert.cs (ImplicitReferenceConversion): When casting a null
17202 literal, we return a NullCast.
17204 * literal.cs (NullLiteralTyped): Remove - I don't see why this
17205 should be around anymore.
17207 The renaming (reported was slightly wrong). Corrections:
17209 ConvertImplicitStandard -> ImplicitConversionStandard
17210 ConvertExplicitStandard -> ExplicitConversionStandard
17212 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
17213 before passing them in !
17215 * convert.cs (ImplicitConversionStandard): When comparing for
17216 equal expr and target types, ensure that expr is not a
17219 In general, we must not be checking (expr_type ==
17220 target_type) in the top level conversion methods
17221 (ImplicitConversion, ExplicitConversion etc). This checking is
17222 done in the methods that they delegate to.
17224 2003-05-20 Miguel de Icaza <miguel@ximian.com>
17226 * convert.cs: Move Error_CannotConvertType,
17227 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
17228 ImplicitNumericConversion, ImplicitConversionExists,
17229 ImplicitUserConversionExists, StandardConversionExists,
17230 FindMostEncompassedType, FindMostSpecificSource,
17231 FindMostSpecificTarget, ImplicitUserConversion,
17232 ExplicitUserConversion, GetConversionOperators,
17233 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
17234 TryImplicitIntConversion, Error_CannotConvertImplicit,
17235 ConvertImplicitRequired, ConvertNumericExplicit,
17236 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
17237 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
17240 Perform the following renames:
17242 StandardConversionExists -> ImplicitStandardConversionExists
17243 ConvertImplicit -> ImplicitConversion
17244 ConvertImplicitStandard -> ImplicitStandardConversion
17245 TryImplicitIntConversion -> ImplicitIntConversion
17246 ConvertImplicitRequired -> ImplicitConversionRequired
17247 ConvertNumericExplicit -> ExplicitNumericConversion
17248 ConvertReferenceExplicit -> ExplicitReferenceConversion
17249 ConvertExplicit -> ExplicitConversion
17250 ConvertExplicitStandard -> ExplicitStandardConversion
17252 2003-05-19 Martin Baulig <martin@ximian.com>
17254 * statement.cs (TypeInfo.StructInfo): Made this type protected.
17255 (TypeInfo): Added support for structs having structs as fields.
17257 * ecore.cs (FieldExpr): Implement IVariable.
17258 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
17259 VariableInfo for the field.
17261 2003-05-18 Martin Baulig <martin@ximian.com>
17263 * expression.cs (This.DoResolve): Report a CS0027 if we're
17264 emitting a field initializer.
17266 2003-05-18 Martin Baulig <martin@ximian.com>
17268 * expression.cs (This.ResolveBase): New public function.
17269 (This.DoResolve): Check for CS0188.
17271 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
17274 * ecore.cs (MethodGroupExpr.DoResolve): Set the
17275 `instance_expression' to null if we don't have any non-static
17278 2003-05-18 Martin Baulig <martin@ximian.com>
17280 Reworked the way how local variables and parameters are handled by
17281 the flow analysis code.
17283 * statement.cs (TypeInfo, VariableMap): New public classes.
17284 (VariableInfo): New public class. This is now responsible for
17285 checking whether a variable has been assigned. It is used for
17286 parameters and local variables.
17287 (Block.EmitMeta): Take the InternalParameters as argument; compute
17288 the layout of the flow vectors here.
17289 (Block.LocalMap, Block.ParameterMap): New public properties.
17290 (FlowBranching): The .ctor doesn't get the InternalParameters
17291 anymore since Block.EmitMeta() now computes the layout of the flow
17293 (MyStructInfo): This class is now known as `StructInfo' and nested
17294 in `TypeInfo'; we don't access this directly anymore.
17296 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
17297 property and removed IsAssigned(), IsFieldAssigned(),
17298 SetAssigned() and SetFieldAssigned(); we now call them on the
17299 VariableInfo so we don't need to duplicate this code everywhere.
17301 * expression.cs (ParameterReference): Added `Block block' argument
17303 (LocalVariableReference, ParameterReference, This): The new
17304 VariableInfo class is now responsible for all the definite
17307 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
17308 IsParameterAssigned, SetParameterAssigned): Removed.
17310 2003-05-18 Martin Baulig <martin@ximian.com>
17312 * typemanager.cs (InitCoreTypes): Try calling
17313 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
17314 the 3-args-version. Corlib now also needs our `void_type'.
17315 (GetMethod): Added overloaded version which takes an optional
17316 `bool report_errors' to allow lookups of optional methods.
17318 2003-05-12 Martin Baulig <martin@ximian.com>
17320 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
17321 only used for locals and not for parameters.
17323 2003-05-12 Miguel de Icaza <miguel@ximian.com>
17325 * support.cs (InternalParameters.ParameterType): Return the
17326 ExternalType of the parameter.
17328 * parameter.cs (Parameter.ExternalType): drop the two arguments,
17331 2003-05-11 Miguel de Icaza <miguel@ximian.com>
17333 * class.cs (MethodData.Define): Do not set the `newslot' on
17334 interface members, if they are also flagged as "override".
17336 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
17337 better code for ++i and i++. This only works for static fields
17338 and local variables.
17340 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
17341 want to pull the DeclSpace out of the builder_to_declspace instead
17342 of the TypeBuilder (like in TypeContainer.FindMembers).
17344 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
17345 instead of LookupTypeContainer. Fixes the crash on .NET for
17346 looking up interface members.
17348 * const.cs: Create our own emit context during the Definition
17349 stage, so that constants are evaluated in the proper context, when
17350 a recursive definition happens.
17352 2003-05-11 Martin Baulig <martin@ximian.com>
17354 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
17355 new block for a switch section.
17356 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
17357 the adding/lookup in the switch block. Fixes #39828.
17359 2003-05-09 Miguel de Icaza <miguel@ximian.com>
17361 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
17362 functionality: I needed to convert the data after I had performed
17363 the add/sub operation into the operands type size.
17365 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
17366 pass the type for the box operation, otherwise the resulting
17367 object would have been of type object.
17369 (BoxedCast): Add constructor to specify the type to box as.
17371 2003-05-07 Miguel de Icaza <miguel@ximian.com>
17373 * iterators.cs: I was reusing the `count' variable inadvertently,
17374 take steps to not allow this to happen.
17376 2003-05-06 Miguel de Icaza <miguel@ximian.com>
17378 * attribute.cs (Attribute.Resolve): Params attributes are encoded
17379 by creating an array at the point where the params starts and
17380 putting all those arguments there, then adjusting the size of the
17383 2003-05-05 Miguel de Icaza <miguel@ximian.com>
17385 * expression.cs (New.AddressOf): Implement interface
17386 IMemoryLocation. This is used when the `new' operator is used in
17387 the context of an invocation to a method on a value type.
17389 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
17392 * namespace.cs: Also check the using aliases here.
17394 * driver.cs: Move the test for using validity after the types have
17395 been entered, so we do a single pass that also includes the using
17398 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
17399 in the regular case. CreateSiblingForFinally is doing extra
17402 * attribute.cs (GetAttributeArgumentExpression): Store the result
17403 on an out value, and use the return value to indicate failure
17404 instead of using null (which is a valid return for Constant.GetValue).
17406 * statement.cs: Perform the analysis flow for the increment
17407 portion after the statement, because this will be the real flow of
17408 execution. Fixes #42385
17410 * codegen.cs (EmitContext.EmitArgument,
17411 EmitContext.EmitStoreArgument): New helper functions when the
17412 RemapToProxy flag is set.
17414 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
17417 Add support for remapping parameters.
17419 * iterators.cs: Propagate parameter values; Store parameter
17420 values in the proxy classes.
17422 2003-05-04 Miguel de Icaza <miguel@ximian.com>
17424 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
17425 need a proxy reference; I do not know what I was thinking
17427 * cs-parser.jay (constructor_initializer): catch another error,
17428 and display nice message.
17430 (field_declaration): catch void field declaration
17431 to flag a better error.
17433 * class.cs (MemberBase.CheckBase): Report an error instead of a
17434 warning if a new protected member is declared in a struct.
17435 (Field.Define): catch the error of readonly/volatile.
17437 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
17439 (FieldExpr.AddressOf): ditto. Catch error where the address of a
17440 volatile variable is taken
17442 2003-05-02 Miguel de Icaza <miguel@ximian.com>
17444 * statement.cs (Fixed.Resolve): Report an error if we are not in
17447 2003-05-01 Miguel de Icaza <miguel@ximian.com>
17449 * typemanager.cs: reuse the code that handles type clashes for
17450 delegates and enumerations.
17452 * class.cs (Report28): Always report.
17454 * expression.cs (EncodeAsAttribute): Allow nulls here.
17456 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17458 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17459 the functionality for testing whether an expression is valid for
17460 an attribute here. Also handle the case of arrays of elements
17463 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17464 encoding a linear array into an array of objects that are suitable
17465 to be passed to an CustomAttributeBuilder.
17467 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17469 * ecore.cs: (FieldExpr): Handle field remapping here.
17471 * iteratators.cs: Pass the instance variable (if the method is an
17472 instance method) to the constructors, so we can access the field
17473 variables on the class.
17475 TODO: Test this with structs. I think the THIS variable on
17476 structs might have to be a pointer, and not a refenrece
17478 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17480 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17481 local variables to fields in a proxy class.
17483 * iterators.cs (PopulateProxy): Rename our internal fields to
17485 Create a <THIS> field if we are an instance method, so we can
17486 reference our parent container variables.
17487 (MapVariable): Called back from the EmitContext code to enter a
17488 new variable to field mapping into the proxy class (we just create
17492 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17493 for using the remapped locals to fields.
17495 I placed the code here, because that gives the same semantics to
17496 local variables, and only changes the Emit code.
17498 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17499 statements inside iterators.
17500 (VariableInfo): Add a FieldBuilder for the cases when we are
17501 remapping local variables to fields in a proxy class
17503 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17504 current_block != null.
17506 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17507 not cope with strings, as it has been moved to the
17508 TableSwitchEmit. Fixed bug in switch generation.
17510 * expression.cs (New.DoResolve): Provide more context for the user
17511 when reporting an error.
17513 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17516 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17517 check the permissions for it. Note than in a type-resolution
17518 context the check was already present in DeclSpace.ResolveType,
17519 but was missing from the MemberAccess.
17521 (ArrayCreation.CheckIndices): warn if the user has
17522 more nested levels of expressions, but there are no more
17523 dimensions specified. Avoids crash on bug 41906.
17525 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17527 * statement.cs (Block): replace Implicit bool, for a generic
17529 New flag: `Unchecked'. This is used during the EmitMeta phase
17530 (which is out-of-line with the regular Resolve/Emit process for a
17531 statement, as this is done ahead of time, but still gets a chance
17532 to call constant resolve).
17534 (Block.Flags): new enum for adding a new flag.
17536 (Block.EmitMeta): track the state of unchecked.
17538 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17539 to enable constant resolution to work there as well.
17541 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17543 * typemanager.cs (ienumerable_type): Also look up
17544 System.Collections.IEnumerable.
17546 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17548 TODO: Test more than one conditional per method.
17550 * class.cs (Indexer.Define): Report the location where the user is
17551 referencing the unsupported feature.
17553 (MethodData): Overload the use of `conditionals' to
17554 minimize the creation of needless ArrayLists. This saves roughly
17555 212kb on my machine.
17557 (Method): Implement the new IIteratorContainer interface.
17558 (Method.SetYields): Implement the method by setting the ModFlags
17559 to contain METHOD_YIELDS.
17561 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17562 which just got set to null.
17564 * iterators.cs: New file.
17566 (Yield, YieldBreak): New statements.
17568 * statement.cs (Return.Resolve): Flag an error if we are used in
17569 an iterator method.
17571 * codegen.cs (InIterator): New flag set if the code is being
17572 compiled in an iterator method.
17574 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
17575 internal modifier, and we just use it to avoid adding extra
17576 fields, as this is seldom used.
17578 * cs-parser.jay: Add yield_statement (yield and yield break).
17580 * driver.cs: New flag -v2 to turn on version 2 features.
17582 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
17583 hashtable when v2 is enabled.
17585 2003-04-20 Miguel de Icaza <miguel@ximian.com>
17587 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
17588 there is already a namespace defined with this name.
17590 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
17591 people upgraded their corlibs.
17593 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
17594 always use fully qualified types, no need to use the compiler
17597 (TypeManager.IsNamespace): Use binarysearch.
17599 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
17600 AddDelegate): I did not quite use the new IsValid API properly: I
17601 have to pass the short-name and the fullname. I was passing only
17602 the basename instead of the fullname sometimes.
17604 (TypeContainer.DefineType): call NamespaceClash.
17606 * interface.cs (Interface.DefineType): use NamespaceClash before
17609 * delegate.cs (Delegate.DefineType): use NamespaceClash before
17612 * enum.cs: (Enum.DefineType): use NamespaceClash before
17615 * typemanager.cs (: 3-line patch that gives us some tasty 11%
17616 speed increase. First, use the negative_hits cache when we get a
17617 negative. Second, add the type with its full original name
17618 instead of the new . and + encoded name (reflection uses + to
17619 separate type from a nested type). Use LookupTypeReflection
17620 directly which bypasses the type->name hashtable (that we already
17621 know does not contain the type.
17623 * decl.cs (DeclSpace.ResolveTypeExpr): track the
17624 location/container type.
17626 * driver.cs: When passing utf8, use directly the UTF8Encoding.
17628 2003-04-19 Miguel de Icaza <miguel@ximian.com>
17630 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
17632 * delegate.cs (NewDelegate.Resolve): Test whether an instance
17633 method is being referenced in the method group from a static
17634 context, and report error 120 if so.
17636 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
17639 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
17640 is created, we create the A namespace).
17642 * cs-parser.jay: A namespace also introduces a DeclarationFound.
17645 2003-04-18 Miguel de Icaza <miguel@ximian.com>
17647 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
17648 invocation to ModuleBuilder.GetType with the same values will
17649 return a new type instance, so we need to cache its return
17652 * expression.cs (Binary.ResolveOperator): Only allow the compare
17653 operators on enums if they are of the same type.
17655 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
17656 types of ValueType on their own case. Before we were giving them
17657 the same treatment as objects.
17659 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
17660 fullname. Short name is used to compare against container name.
17661 Fullname is used to check against defined namespace names.
17663 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
17664 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
17666 (Method.CheckBase): Call parent.
17667 (MemberBase.CheckBase): Check for protected members on sealed
17669 (PropertyBase.CheckBase): Call parent.
17670 (Field.Define): Call parent.
17672 * report.cs: Negative error codes are now mapped to 8000 - code,
17673 so that the display is render more nicely.
17675 * typemanager.cs: Do not use try/catch, instead report a regular
17678 (GetPointerType, GetReferenceType): These methods provide
17679 mechanisms to obtain the T* and T& from a T. We had the code
17680 previously scattered around the code base, and it also used
17681 TypeManager.LookupType that would go through plenty of caches.
17682 This one goes directly to the type source.
17684 In some places we did the Type.GetType followed by
17685 ModuleBuilder.GetType, but not in others, so this unifies the
17686 processing as well.
17688 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
17689 statements now that we have namespace information.
17691 * typemanager.cs (IsNamespace): New method, returns whether the
17692 string presented is a namespace or not.
17694 (ComputeNamespaces): New public entry point, computes the list of
17695 available namespaces, using the GetNamespaces API call in Mono, or
17696 the slower version in MS.NET.
17698 Now before we start the semantic analysis phase, we have a
17699 complete list of namespaces including everything that the user has
17702 Deleted old code to cache namespaces in .nsc files.
17704 2003-04-17 Miguel de Icaza <miguel@ximian.com>
17706 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
17707 class/struct location definition Location for the implicit
17708 constructor location.
17710 (Operator.Define): Use the location of the operator for the
17711 implicit Method definition.
17713 (Constructor.Emit): use the constructor location for the implicit
17714 base initializer constructor.
17716 * ecore.cs: Remove ITypeExpression. This interface is now gone,
17717 and the Expression class now contains two new methods:
17719 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
17720 isolate type lookup from the rest of the resolution process.
17722 Since we use Expressions to hold type definitions due to the way
17723 we parse the input we have historically overloaded Resolve to
17724 perform the Type lookups if a special flag is passed. Now this is
17725 eliminated and two methods take their place.
17727 The differences in the two methods between xStep and xTerminal is
17728 that xStep is involved in our current lookup system that uses
17729 SimpleNames to compose a name, while xTerminal is used just to
17730 catch the case where the simplename lookup failed.
17732 2003-04-16 Miguel de Icaza <miguel@ximian.com>
17734 * expression.cs (ResolveMemberAccess): Remove redundant code.
17735 TypeExpr expressions are always born fully resolved.
17737 * interface.cs (PopulateMethod): Do not lookup the types twice.
17738 We were doing it once during SemanticAnalysis and once during
17741 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
17742 in local variable type definitions, were being returned as a
17743 SimpleName (we decomposed everything into a string), that is
17744 because primary_expression was being used instead of a type in the
17745 grammar (reduce/reduce conflicts).
17747 The part that was wrong is that we converted the expression into a
17748 string (an oversimplification in one hand, compounded with primary
17749 expressions doing string concatenation).
17755 Would return "A.B.C[]" as a SimpleName. This stopped things like
17756 using clauses from working on this particular context. And a type
17757 was being matched directly against "A.B.C[]".
17759 We now use the correct approach, and allow for ComposedCast to be
17760 part of the unary expression. So the "A.B.C []" become a composed
17761 cast of "A.B.C" (as a nested group of MemberAccess with a
17762 SimpleName at the end) plus the rank composition "[]".
17766 2003-04-10 Miguel de Icaza <miguel@ximian.com>
17768 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
17769 for the access level checking.
17771 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
17772 `TypeContainer container', because I kept getting confused when I
17773 was debugging this code.
17775 * expression.cs (Indexers): Instead of tracking getters/setters,
17776 we now track them in parallel. We create one arraylist less, but
17777 most importantly it is possible now for the LValue code to find a
17778 matching get for a set.
17780 (IndexerAccess.DoResolveLValue): Update the code.
17781 GetIndexersForType has been modified already to extract all the
17782 indexers from a type. The code assumed it did not.
17784 Also make the code set the correct return type for the indexer.
17785 This was fixed a long time ago for properties, but was missing for
17786 indexers. It used to be void_type.
17788 (Binary.Emit): Test first for doubles instead of
17789 floats, as they are more common.
17791 (Binary.EmitBranchable): Use the .un version of the branch opcodes
17792 when dealing with floats and the <=, >= operators. This fixes bug
17795 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
17796 to load the array value by emitting a load on the foreach variable
17797 type. This was incorrect.
17799 We now emit the code to load an element using the the array
17800 variable type, and then we emit the conversion operator.
17804 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
17806 * attribute.cs: Avoid allocation of ArrayLists in the common case.
17808 2003-04-09 Miguel de Icaza <miguel@ximian.com>
17810 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
17811 test for protection before we test for signatures.
17813 (MethodSignature.ToString): implement.
17815 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
17816 to the case where we reduced into a LongConstant.
17818 * decl.cs (CheckAccessLevel): If the type is an array, we can not
17819 depend on whether the information is acurrate, because the
17820 Microsoft runtime will always claim that the array type is public,
17821 regardless of the real state.
17823 If the type is a pointer, another problem happens: the type is
17824 reported as non-public in Microsoft.
17826 In both cases we have to call CheckAccessLevel recursively with
17827 the underlying type as the argument to be tested.
17829 2003-04-08 Miguel de Icaza <miguel@ximian.com>
17831 * assign.cs (Assign.Emit): If we are dealing with a compound
17832 assignment expression, we should use the code path that stores the
17833 intermediate result in a temporary value. This fixes #40903.
17835 *expression.cs (Indirection.ToString): Provide ToString method for
17838 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
17840 * class.cs: Null out fields holding references to Block objects so
17841 they can be garbage collected.
17843 * expression.cs (OverloadResolve): Remove unused local.
17845 2003-04-07 Martin Baulig <martin@ximian.com>
17847 * codegen.cs (EmitContext.CurrentFile): New public field.
17848 (EmitContext.Mark): Use the CurrentFile to check whether the
17849 location is in the correct file.
17850 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
17852 2003-04-07 Martin Baulig <martin@ximian.com>
17854 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
17856 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
17857 location. [FIXME: The location argument which gets passed to this
17858 method is sometimes wrong!]
17860 2003-04-07 Nick Drochak <ndrochak@gol.com>
17862 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
17864 2003-04-07 Miguel de Icaza <miguel@ximian.com>
17866 * expression.cs (Indirection.EmitAssign): We were using the
17867 temporary, but returning immediately instead of continuing the
17870 2003-04-06 Martin Baulig <martin@ximian.com>
17872 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
17873 if it's a nested child, but also deriving from the outer class.
17876 * typemanager.cs (IsNestedChildOf): Make this work if it's a
17877 nested child, but also deriving from the outer class. See
17879 (FilterWithClosure): We may access private members of the outer
17880 class if we're a nested child and deriving from the outer class.
17881 (RealMemberLookup): Only set `closure_private_ok' if the
17882 `original_bf' contained BindingFlags.NonPublic.
17884 2003-04-05 Martin Baulig <martin@ximian.com>
17886 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
17888 2003-04-02 Miguel de Icaza <miguel@ximian.com>
17890 * class.cs (Event.Define): Do not allow abstract events to have
17893 2003-04-01 Miguel de Icaza <miguel@ximian.com>
17895 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
17896 block in event declarations.
17898 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
17899 value type, get its address.
17901 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
17902 leaving a class on the stack instead of a boolean value (int
17903 0/1). Change the code so we compare against null, and then the
17904 result against zero.
17906 * class.cs (TypeContainer.GetClassBases): We were checking for the
17907 parent class being sealed too late.
17909 * expression.cs (Binary.Emit): For <= and >= when dealing with
17910 floating point values, use cgt.un and clt.un instead of cgt and
17913 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
17915 * statement.cs: Apply the same optimization as MS: skip the
17916 GetEnumerator returning an IEnumerator, and use the one returning a
17917 CharEnumerator instead. This allows us to avoid the try-finally block
17920 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
17922 * cs-parser.jay: Attributes cannot be applied to
17923 namespaces. Fixes #40473
17925 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17928 (Add*): check if the name is valid using the full name for constants,
17929 fields, properties and events.
17931 2003-03-28 Miguel de Icaza <miguel@ximian.com>
17933 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
17934 char constants to be part of the enumeration.
17936 * expression.cs (Conditional.DoResolve): Add support for operator
17937 true. Implements the missing functionality from 14.12
17939 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
17940 operator true/false as required by the spec.
17942 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
17943 implicit conversion to boolean.
17945 * statement.cs (Statement.ResolveBoolean): A boolean expression is
17946 also one where the type implements `operator true'.
17948 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
17949 get an expression that will invoke operator true based on an
17952 (GetConversionOperators): Removed the hack that called op_True
17955 (Expression.ResolveBoolean): Move this from Statement.
17957 2003-03-17 Miguel de Icaza <miguel@ximian.com>
17959 * ecore.cs (FieldExpr): do not allow initialization of initonly
17960 fields on derived classes
17962 2003-03-13 Martin Baulig <martin@ximian.com>
17964 * statement.cs (Block.Emit): Call ig.BeginScope() and
17965 ig.EndScope() when compiling with debugging info; call
17966 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
17968 2003-03-08 Miguel de Icaza <miguel@ximian.com>
17970 * expression.cs (Indexers): Do not construct immediately, allow
17971 for new members to be appended as we go. Fixes 38143
17973 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17975 * expression.cs: save/restore context when resolving an unchecked
17978 2003-03-05 Miguel de Icaza <miguel@ximian.com>
17980 * cfold.cs: Catch division by zero in modulus operator during
17983 2003-03-03 Miguel de Icaza <miguel@ximian.com>
17985 * interface.cs (Interface.DefineMembers): Avoid defining members
17988 2003-02-27 Miguel de Icaza <miguel@ximian.com>
17990 * driver.cs: handle the +/- options for -noconfig
17992 * statement.cs (Unckeched.Resolve): Also track the state of
17993 unchecked in the Resolve phase.
17995 2003-02-27 Martin Baulig <martin@ximian.com>
17997 * ecore.cs (Expression.MemberLookup): Don't create a
17998 MethodGroupExpr for something which is not a method. Fixes #38291.
18000 2003-02-25 Miguel de Icaza <miguel@ximian.com>
18002 * class.cs (MemberBase.CheckParameters): Also check that the type
18003 is unmanaged if it is a pointer.
18005 * expression.cs (SizeOf.Resolve): Add location information.
18007 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
18008 a managed type is declared.
18010 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
18011 parameter modifiers as well. Fixes bug 38606
18013 * class.cs: Very sad. Am backing out the speed up changes
18014 introduced by the ArrayList -> Array in the TypeContainer, as they
18015 were not actually that much faster, and introduced a bug (no error
18016 reports on duplicated methods).
18018 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
18019 source first, this will guarantee that we have a valid expression
18020 before calling in lower levels functions that will require a
18021 resolved object. Then use this original_source in the
18022 target.ResolveLValue instead of the original source that was
18025 Another change. Use target.Resolve instead of LValueResolve.
18026 Although we are resolving for LValues, we will let the Assign code
18027 take care of that (it will be called again from Resolve). This
18028 basically allows code like this:
18030 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
18031 class Y { void A (X x) { x [0] += o; }
18033 The problem was that the indexer was trying to resolve for
18034 set_Item (idx, object o) and never finding one. The real set_Item
18035 was set_Item (idx, X). By delaying the process we get the right
18040 2003-02-23 Martin Baulig <martin@ximian.com>
18042 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
18043 while calling DoEmit ().
18045 * codegen.cs (EmitContext.Mark): Don't mark locations in other
18046 source files; if you use the #line directive inside a method, the
18047 compiler stops emitting line numbers for the debugger until it
18048 reaches the end of the method or another #line directive which
18049 restores the original file.
18051 2003-02-23 Martin Baulig <martin@ximian.com>
18053 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
18055 2003-02-23 Martin Baulig <martin@ximian.com>
18057 * statement.cs (Block.AddChildVariableNames): We need to call this
18058 recursively, not just for our immediate children.
18060 2003-02-23 Martin Baulig <martin@ximian.com>
18062 * class.cs (Event.Define): Always make the field private, like csc does.
18064 * typemanager.cs (TypeManager.RealMemberLookup): Make events
18065 actually work, fixes bug #37521.
18067 2003-02-23 Miguel de Icaza <miguel@ximian.com>
18069 * delegate.cs: When creating the various temporary "Parameters"
18070 classes, make sure that we call the ComputeAndDefineParameterTypes
18071 on those new parameters (just like we do with the formal ones), to
18072 allow them to be resolved in the context of the DeclSpace.
18074 This fixes the bug that Dick observed in Bugzilla #38530.
18076 2003-02-22 Miguel de Icaza <miguel@ximian.com>
18078 * expression.cs (ResolveMemberAccess): When resolving a constant,
18079 do not attempt to pull a constant if the value was not able to
18080 generate a valid constant.
18082 * const.cs (LookupConstantValue): Do not report more errors than required.
18084 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18086 * expression.cs: fixes bug #38328.
18088 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18090 * class.cs: Changed all the various members that can be part of a
18091 class from being an ArrayList to be an Array of the right type.
18092 During the DefineType type_list, interface_list, delegate_list and
18093 enum_list are turned into types, interfaces, delegates and enums
18096 And during the member population, indexer_list, event_list,
18097 constant_list, field_list, instance_constructor_list, method_list,
18098 operator_list and property_list are turned into their real arrays.
18100 Although we could probably perform this operation earlier, for
18101 good error reporting we need to keep the lists and remove the
18102 lists for longer than required.
18104 This optimization was triggered by Paolo profiling the compiler
18105 speed on the output of `gen-sample-program.pl' perl script.
18107 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
18108 not crash in methods like MemberLookupFailed that use this field.
18110 This problem arises when the compiler fails to resolve a type
18111 during interface type definition for example.
18113 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18115 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
18116 inherit from System.Object, so we have to stop at null, not only
18117 when reaching System.Object.
18119 2003-02-17 Miguel de Icaza <miguel@ximian.com>
18121 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
18122 DeclaredOnly because the parent indexer might have had a different
18123 name, but did not loop until the top of the hierarchy was reached.
18125 The problem this one fixes is 35492: when a class implemented an
18126 indexer from an interface, we were getting the interface method
18127 (which was abstract) and we were flagging an error (can not invoke
18130 This also keeps bug 33089 functioning, and test-148 functioning.
18132 * typemanager.cs (IsSpecialMethod): The correct way of figuring
18133 out if a method is special is to see if it is declared in a
18134 property or event, or whether it is one of the predefined operator
18135 names. This should fix correctly #36804.
18137 2003-02-15 Miguel de Icaza <miguel@ximian.com>
18139 The goal here is to remove the dependency on EmptyCast.Peel ().
18140 Killing it completely.
18142 The problem is that currently in a number of places where
18143 constants are expected, we have to "probe" for an EmptyCast, and
18144 Peel, which is not the correct thing to do, as this will be
18145 repetitive and will likely lead to errors.
18147 The idea is to remove any EmptyCasts that are used in casts that
18148 can be reduced to constants, so we only have to cope with
18151 This bug hunt was triggered by Bug 37363 and the desire to remove
18152 the duplicate pattern where we were "peeling" emptycasts to check
18153 whether they were constants. Now constants will always be
18156 * ecore.cs: Use an enumconstant here instead of wrapping with
18159 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
18160 throwing me off. By handling this we can get rid of a few hacks.
18162 * statement.cs (Switch): Removed Peel() code.
18164 2003-02-14 Miguel de Icaza <miguel@ximian.com>
18166 * class.cs: Location information for error 508
18168 * expression.cs (New.DoResolve): Add a guard against double
18169 resolution of an expression.
18171 The New DoResolve might be called twice when initializing field
18172 expressions (see EmitFieldInitializers, the call to
18173 GetInitializerExpression will perform a resolve on the expression,
18174 and later the assign will trigger another resolution
18176 This leads to bugs (#37014)
18178 * delegate.cs: The signature for EndInvoke should contain any ref
18179 or out parameters as well. We were not doing this in the past.
18181 * class.cs (Field.Define): Do not overwrite the type definition
18182 inside the `volatile' group. Turns out that volatile enumerations
18183 were changing the type here to perform a validity test, which
18186 2003-02-12 Miguel de Icaza <miguel@ximian.com>
18188 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
18189 and structs, we do not want to load the instance variable
18191 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
18192 enum_type has to be handled like an object reference (implicit
18193 conversions exists from this to object), but the regular IsClass
18194 and IsValueType tests will never return true for this one.
18196 Also we use TypeManager.IsValueType instead of type.IsValueType,
18197 just for consistency with the rest of the code (this is only
18198 needed if we ever use the construct exposed by test-180.cs inside
18199 corlib, which we dont today).
18201 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
18203 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
18206 2003-02-09 Martin Baulig <martin@ximian.com>
18208 * namespace.cs (Namespace..ctor): Added SourceFile argument.
18209 (Namespace.DefineNamespaces): New static public method; this is
18210 called when we're compiling with debugging to add all namespaces
18211 to the symbol file.
18213 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
18214 pass it to the Namespace's .ctor.
18216 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
18217 and MethodBase arguments; pass the namespace ID to the symwriter;
18218 pass the MethodBase instead of the token to the symwriter.
18219 (SymbolWriter.DefineNamespace): New method to add a namespace to
18222 2003-02-09 Martin Baulig <martin@ximian.com>
18224 * symbolwriter.cs: New file. This is a wrapper around
18225 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
18226 methods here in near future.
18228 2003-02-09 Martin Baulig <martin@ximian.com>
18230 * codegen.cs (EmitContext.Mark): Just pass the arguments to
18231 ILGenerator.MarkSequencePoint() which are actually used by the
18234 2003-02-09 Martin Baulig <martin@ximian.com>
18236 * location.cs (SourceFile): New public sealed class. This
18237 contains the name and an index which is used in the location's token.
18238 (Location): Reserve an appropriate number of bits in the token for
18239 the source file instead of walking over that list, this gives us a
18240 really huge performance improvement when compiling with debugging.
18242 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
18243 `SourceFile' argument instead of a string.
18244 (Driver.ProcessFile): Add all the files via Location.AddFile(),
18245 but don't parse/tokenize here, we need to generate the list of all
18246 source files before we do that.
18247 (Driver.ProcessFiles): New static function. Parses/tokenizes all
18250 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
18251 instead of a string.
18253 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
18256 2003-02-09 Martin Baulig <martin@ximian.com>
18258 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
18259 filename on `#line default'.
18261 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
18263 * statement.cs: don't clear the pinned var when the fixed statement
18264 returns from the method (fixes bug#37752).
18266 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
18268 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
18271 2003-02-07 Martin Baulig <martin@ximian.com>
18273 * driver.cs: Removed the `--debug-args' command line argument.
18275 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
18276 automatically by the AsssemblyBuilder.
18277 (CodeGen.InitializeSymbolWriter): We don't need to call any
18278 initialization function on the symbol writer anymore. This method
18279 doesn't take any arguments.
18281 2003-02-03 Miguel de Icaza <miguel@ximian.com>
18283 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
18284 from referenced assemblies as well.
18286 2003-02-02 Martin Baulig <martin@ximian.com>
18288 * class.cs (MethodData.Emit): Generate debugging info for external methods.
18290 2003-02-02 Martin Baulig <martin@ximian.com>
18292 * class.cs (Constructor.Emit): Open the symbol writer before
18293 emitting the constructor initializer.
18294 (ConstructorInitializer.Emit): Call ec.Mark() to allow
18295 single-stepping through constructor initializers.
18297 2003-01-30 Miguel de Icaza <miguel@ximian.com>
18299 * class.cs: Handle error 549: do not allow virtual methods in
18302 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
18304 * decl.cs: Check access levels when resolving types
18306 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
18308 * statement.cs: Add parameters and locals set in catch blocks that might
18309 return to set vector
18311 2003-01-29 Miguel de Icaza <miguel@ximian.com>
18313 * class.cs (Operator): Set the SpecialName flags for operators.
18315 * expression.cs (Invocation.DoResolve): Only block calls to
18316 accessors and operators on SpecialName methods.
18318 (Cast.TryReduce): Handle conversions from char constants.
18321 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
18323 * statement.cs: small memory and time optimization in FlowBranching.
18325 2003-01-28 Pedro Mart <yoros@wanadoo.es>
18327 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
18328 problem that the last fix but in the other sid (Set).
18330 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
18331 access when there is no indexer in the hierarchy.
18333 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
18335 * class.cs: Combine some if statements.
18337 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18339 * driver.cs: fixed bug #37187.
18341 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
18343 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
18344 any indexer, it's needed to build a list with all the indexers in the
18345 hierarchy (AllGetters), else we have problems. Fixes #35653.
18347 2003-01-23 Miguel de Icaza <miguel@ximian.com>
18349 * class.cs (MethodData.Define): It is wrong for an interface
18350 implementation to be static in both cases: explicit and implicit.
18351 We were only handling this in one case.
18353 Improve the if situation there to not have negations.
18355 * class.cs (Field.Define): Turns out that we do not need to check
18356 the unsafe bit on field definition, only on usage. Remove the test.
18358 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18360 * driver.cs: use assembly.Location instead of Codebase (the latest
18361 patch made mcs fail when using MS assemblies).
18363 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
18365 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
18366 get the path to *corlib.dll.
18368 2003-01-21 Nick Drochak <ndrochak@gol.com>
18372 * typemanager.cs: Remove compiler warnings
18374 2003-01-20 Duncan Mak <duncan@ximian.com>
18376 * AssemblyInfo.cs: Bump the version number to 0.19.
18378 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18380 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
18382 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
18384 * class.cs (Constructor::Emit): Emit debugging info for constructors.
18386 2003-01-17 Miguel de Icaza <miguel@ximian.com>
18388 * cs-parser.jay: Small fix: we were not comparing the constructor
18389 name correctly. Thanks to Zoltan for the initial pointer.
18391 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
18393 * cs-tokenizer.cs: Set file name when specified with #line
18395 2003-01-15 Miguel de Icaza <miguel@ximian.com>
18397 * cs-parser.jay: Only perform the constructor checks here if we
18398 are named like the class; This will help provider a better
18399 error. The constructor path is taken when a type definition is
18400 not found, but most likely the user forgot to add the type, so
18401 report that rather than the constructor error.
18403 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
18405 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
18408 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18410 * cs-parser.jay: Add cleanup call.
18412 2003-01-13 Duncan Mak <duncan@ximian.com>
18414 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
18415 consistent with other methods.
18417 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18419 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
18421 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
18423 * attribute.cs: only set GuidAttr to true when we have a
18426 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18430 * typemanager.cs: fixes to allow mcs compile corlib with the new
18431 Type.IsSubclassOf fix.
18433 2003-01-08 Miguel de Icaza <miguel@ximian.com>
18435 * expression.cs (LocalVariableReference.DoResolve): Classify a
18436 constant as a value, not as a variable. Also, set the type for
18439 * cs-parser.jay (fixed_statement): take a type instead of a
18440 pointer_type, so we can produce a better error message later.
18442 * statement.cs (Fixed.Resolve): Flag types that are not pointers
18445 (For.DoEmit): Make inifinite loops have a
18446 non-conditional branch back.
18448 (Fixed.DoEmit): First populate the pinned variables, then emit the
18449 statement, then clear the variables. Before I was emitting the
18450 code once for each fixed piece.
18453 2003-01-08 Martin Baulig <martin@ximian.com>
18455 * statement.cs (FlowBranching.MergeChild): A break in a
18456 SWITCH_SECTION does not leave a loop. Fixes #36155.
18458 2003-01-08 Martin Baulig <martin@ximian.com>
18460 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18461 lives in the same number space than `param_map'. Fixes #36154.
18463 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18465 * cs-parser.jay (constructor_declaration): Set the
18466 Constructor.ModFlags before probing for it. This makes the
18467 compiler report 514, 515 and 132 (the code was there, but got
18470 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18471 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18472 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18474 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18476 * enum.cs: create the enum static fields using the enum type.
18478 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18480 * class.cs: don't try to create the ParamBuilder for the return
18481 type if it's not needed (and handle it breaking for the ms runtime
18484 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18486 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18488 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18490 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18491 the command. This showed up while compiling the JANET source
18492 code, which used \r as its only newline separator.
18494 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18496 * class.cs (Method.Define): If we are an operator (because it
18497 reuses our code), then set the SpecialName and HideBySig. #36128
18499 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18501 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18502 exception, report error 120 `object reference required'.
18504 * driver.cs: Add --pause option, used during to measure the size
18505 of the process as it goes with --timestamp.
18507 * expression.cs (Invocation.DoResolve): Do not allow methods with
18508 SpecialName to be invoked.
18510 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18512 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18513 number before adding it.
18515 2002-12-21 Ravi Pratap <ravi@ximian.com>
18517 * ecore.cs (StandardImplicitConversion): When in an unsafe
18518 context, we allow conversion between void * to any other pointer
18519 type. This fixes bug #35973.
18521 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18523 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18524 is not thrown when extensionless outputs are used
18526 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18528 * rootcontext.cs: fixed compilation of corlib.
18530 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18532 * attribute.cs (Attributes.Contains): Add new method.
18534 * class.cs (MethodCore.LabelParameters): if the parameter is an
18535 `out' parameter, check that no attribute `[In]' has been passed.
18537 * enum.cs: Handle the `value__' name in an enumeration.
18539 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18541 * decl.cs: Added special case to allow overrides on "protected
18544 2002-12-18 Ravi Pratap <ravi@ximian.com>
18546 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18547 since it makes much more sense.
18549 (Attributes.ctor): Don't require a Location parameter.
18551 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18553 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18554 since we already have that information per attribute.
18556 * everywhere : make appropriate changes.
18558 * class.cs (LabelParameters): Write the code which actually
18559 applies attributes to the return type. We can't do this on the MS
18560 .NET runtime so we flag a warning in the case an exception is
18563 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18565 * const.cs: Handle implicit null conversions here too.
18567 2002-12-17 Ravi Pratap <ravi@ximian.com>
18569 * class.cs (MethodCore.LabelParameters): Remove the extra
18570 Type [] parameter since it is completely unnecessary. Instead
18571 pass in the method's attributes so that we can extract
18572 the "return" attribute.
18574 2002-12-17 Miguel de Icaza <miguel@ximian.com>
18576 * cs-parser.jay (parse): Use Report.Error to flag errors instead
18577 of ignoring it and letting the compile continue.
18579 * typemanager.cs (ChangeType): use an extra argument to return an
18580 error condition instead of throwing an exception.
18582 2002-12-15 Miguel de Icaza <miguel@ximian.com>
18584 * expression.cs (Unary.TryReduce): mimic the code for the regular
18585 code path. Perform an implicit cast in the cases where we can
18586 implicitly convert to one of the integral types, and then reduce
18587 based on that constant. This fixes bug #35483.
18589 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18591 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
18593 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18595 * namespace.cs: fixed bug #35489.
18597 2002-12-12 Miguel de Icaza <miguel@ximian.com>
18599 * class.cs: Remove some dead code.
18601 * cs-parser.jay: Estimate the number of methods needed
18602 (RootContext.MethodCount);
18604 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
18605 numbers instead of StringBuilders.
18607 * support.cs (PtrHashtable): Add constructor with initial size;
18608 We can now reduce reallocations of the method table.
18610 2002-12-10 Ravi Pratap <ravi@ximian.com>
18612 * attribute.cs (ApplyAttributes): Keep track of the emitted
18613 attributes on a per-target basis. This fixes bug #35413.
18615 2002-12-10 Miguel de Icaza <miguel@ximian.com>
18617 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
18618 default to the Windows 1252 encoding.
18620 (UnixParseOption): Support version, thanks to Alp for the missing
18623 * AssemblyInfo.cs: Add nice assembly information.
18625 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
18628 * cs-parser.jay: Allow a trailing comma before the close bracked
18629 in the attribute_section production.
18631 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
18632 address of the instance was being taken, I will take this out,
18633 because we take the address of the object immediately here.
18635 2002-12-09 Ravi Pratap <ravi@ximian.com>
18637 * typemanager.cs (AreMultipleAllowed): Take care of the most
18638 obvious case where attribute type is not in the current assembly -
18641 2002-12-08 Miguel de Icaza <miguel@ximian.com>
18643 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
18644 definitions, instead of doing that afterwards.
18646 Also we use a nice little hack, depending on the constructor, we
18647 know if we are a "composed" name or a simple name. Hence, we
18648 avoid the IndexOf test, and we avoid
18650 * codegen.cs: Add code to assist in a bug reporter to track down
18651 the source of a compiler crash.
18653 2002-12-07 Ravi Pratap <ravi@ximian.com>
18655 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
18656 types have been emitted for a given element and flag an error
18657 if something which does not have AllowMultiple set is used more
18660 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
18661 attribute types and their corresponding AllowMultiple properties
18663 (AreMultipleAllowed): Check the property for a given type.
18665 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
18666 property in the case we have a TypeContainer.
18668 (Attributes.AddAttribute): Detect duplicates and just skip on
18669 adding them. This trivial fix catches a pretty gross error in our
18670 attribute emission - global attributes were being emitted twice!
18672 Bugzilla bug #33187 is now fixed.
18674 2002-12-06 Miguel de Icaza <miguel@ximian.com>
18676 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
18677 instead of pp_and).
18679 * expression.cs (Binary.ResolveOperator): I can only use the
18680 Concat (string, string, string) and Concat (string, string,
18681 string, string) if the child is actually a concatenation of
18684 2002-12-04 Miguel de Icaza <miguel@ximian.com>
18686 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
18687 context where we need a 2-character lookahead.
18689 * pending.cs (PendingImplementation): Rework so we can keep track
18690 of interface types all the time, and flag those which were
18691 implemented by parents as optional.
18693 2002-12-03 Miguel de Icaza <miguel@ximian.com>
18695 * expression.cs (Binary.ResolveOperator): Use
18696 String.Concat(string,string,string) or
18697 String.Concat(string,string,string,string) when possible.
18699 * typemanager: More helper methods.
18702 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
18704 * pending.cs: remove the bogus return from GetMissingInterfaces()
18705 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
18707 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18709 * namespace.cs: avoid duplicated 'using xxx' being added to
18710 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
18711 when we get more than one 'using' statement for the same namespace.
18712 Report a CS0105 warning for it.
18714 2002-11-30 Miguel de Icaza <miguel@ximian.com>
18716 * cs-tokenizer.cs (consume_identifier): use read directly, instead
18717 of calling getChar/putback, uses internal knowledge of it.
18719 (xtoken): Reorder tokenizer so most common patterns are checked
18720 first. This reduces the compilation time in another 5% (from 8.11s
18721 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
18723 The parsing time is 22% of the compilation in mcs, and from that
18724 64% is spent on the tokenization process.
18726 I tried using a binary search for keywords, but this is slower
18727 than the hashtable. Another option would be to do a couple of
18730 * Not use a StringBuilder, instead use an array of chars,
18731 with a set value. Notice that this way we could catch
18732 the 645 error without having to do it *afterwards*.
18734 * We could write a hand-parser to avoid the hashtable
18735 compares altogether.
18737 The identifier consumption process takes 37% of the tokenization
18738 time. Another 15% is spent on is_number. 56% of the time spent
18739 on is_number is spent on Int64.Parse:
18741 * We could probably choose based on the string length to
18742 use Int32.Parse or Int64.Parse and avoid all the 64-bit
18745 Another 3% is spend on wrapping `xtoken' in the `token' function.
18747 Handle 0xa0 as whitespace (#34752)
18749 2002-11-26 Miguel de Icaza <miguel@ximian.com>
18751 * typemanager.cs (IsCLRType): New routine to tell whether a type
18752 is one of the builtin types.
18754 Maybe it needs to use TypeCodes to be faster. Maybe we could use
18755 typecode in more places instead of doing pointer comparissions.
18756 We could leverage some knowledge about the way the typecodes are
18759 New code to cache namespaces in assemblies, it is currently not
18760 invoked, to be used soon.
18762 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
18764 * expression.cs (Binary.ResolveOperator): specially handle
18765 strings, and do not perform user-defined operator overloading for
18768 2002-11-24 Miguel de Icaza <miguel@ximian.com>
18770 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
18771 internalcall as it is a pretty simple operation; Avoid whenever
18772 possible to call Char.IsLetter.
18774 (consume_identifier): Cut by half the number of
18775 hashtable calls by merging the is_keyword and GetKeyword behavior.
18777 Do not short-circuit, because if we do, we
18778 report errors (ie, #if false && true would produce an invalid
18782 2002-11-24 Martin Baulig <martin@ximian.com>
18784 * expression.cs (Cast.TryReduce): If we're in checked syntax,
18785 check constant ranges and report a CS0221. Fixes #33186.
18787 2002-11-24 Martin Baulig <martin@ximian.com>
18789 * cs-parser.jay: Make this work for uninitialized variable
18790 declarations in the `for' initializer. Fixes #32416.
18792 2002-11-24 Martin Baulig <martin@ximian.com>
18794 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
18795 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
18797 2002-11-24 Martin Baulig <martin@ximian.com>
18799 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
18800 argument; if true, we also check for user-defined conversions.
18801 This is only needed if both arguments are of a user-defined type.
18802 Fixes #30443, added test-175.cs.
18803 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
18805 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
18807 2002-11-24 Martin Baulig <martin@ximian.com>
18809 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
18810 function to get the store opcode.
18811 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
18812 only emit the Ldelema if the store opcode is Stobj. You must run
18813 both test-34 and test-167 to test this. Fixes #34529.
18815 2002-11-23 Martin Baulig <martin@ximian.com>
18817 * ecore.cs (Expression.MemberLookup): Added additional
18818 `qualifier_type' argument which is used when we're being called
18819 from MemberAccess.DoResolve() and null if we're called from a
18821 (Expression.MemberLookupFailed): New method to report errors; this
18822 does the CS1540 check and reports the correct error message.
18824 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
18825 argument for the CS1540 check and redone the way how we're dealing
18826 with private members. See the comment in the source code for details.
18827 (FilterWithClosure): Reverted this back to revision 1.197; renamed
18828 `closure_start_type' to `closure_qualifier_type' and check whether
18829 it's not null. It was not this filter being broken, it was just
18830 being called with the wrong arguments.
18832 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
18833 and pass it the correct `qualifier_type'; this also does the error
18836 2002-11-22 Miguel de Icaza <miguel@ximian.com>
18838 * expression.cs (Invocation.EmitParams): If the we are dealing
18839 with a non-built-in value type, load its address as well.
18841 (ArrayCreation): Use a a pretty constant instead
18842 of the hardcoded value 2. Use 6 instead of 2 for the number of
18843 static initializers.
18845 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
18846 because they are not really value types, just glorified integers.
18848 * driver.cs: Do not append .exe, the CSC compiler does not do it.
18850 * ecore.cs: Remove redundant code for enumerations, make them use
18851 the same code path as everything else, fixes the casting issue
18852 with enumerations in Windows.Forms.
18854 * attribute.cs: Do only cast to string if it is a string, the
18855 validation happens later.
18857 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
18858 people upgrade their corlibs.
18860 * ecore.cs: Oops, enumerations were not following the entire code path
18862 2002-11-21 Miguel de Icaza <miguel@ximian.com>
18864 * typemanager.cs (FilterWithClosure): Commented out the test for
18865 1540 in typemanager.cs, as it has problems when accessing
18866 protected methods from a parent class (see test-174.cs).
18868 * attribute.cs (Attribute.ValidateGuid): new method.
18869 (Attribute.Resolve): Use above.
18871 2002-11-19 Miguel de Icaza <miguel@ximian.com>
18873 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
18875 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
18876 handling for enumerations, as we only needed the TypeContainer
18877 functionality to begin with (this is required for the fix below to
18878 work for enums that reference constants in a container class for
18881 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
18883 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
18884 a valid TypeBuilder to perform lookups on.o
18886 * class.cs (InheritableMemberSignatureCompare): Use true in the
18887 call to GetGetMethod and GetSetMethod, because we are comparing
18888 the signature, and we need to get the methods *even* if they are
18891 (PropertyBase.CheckBase): ditto.
18893 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
18894 GotoCase.Resolve): Use Peel on EmpytCasts.
18896 * ecore.cs (EmptyCast): drop child, add Peel method.
18898 2002-11-17 Martin Baulig <martin@ximian.com>
18900 * ecore.cs (EmptyCast.Child): New public property.
18902 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
18903 label resolved to an EmptyCast. Fixes #34162.
18904 (GotoCase.Resolve): Likewise.
18905 (Block.EmitMeta): Likewise.
18907 2002-11-17 Martin Baulig <martin@ximian.com>
18909 * expression.cs (Invocation.BetterConversion): Prefer int over
18910 uint; short over ushort; long over ulong for integer literals.
18911 Use ImplicitConversionExists instead of StandardConversionExists
18912 since we also need to check for user-defined implicit conversions.
18913 Fixes #34165. Added test-173.cs.
18915 2002-11-16 Martin Baulig <martin@ximian.com>
18917 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
18918 with the `true' and `false' literals. Fixes #33151.
18920 2002-11-16 Martin Baulig <martin@ximian.com>
18922 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
18923 October 22nd; don't do the cs1540 check for static members.
18925 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18926 now using our own filter here and doing the cs1540 check again.
18928 2002-11-16 Martin Baulig <martin@ximian.com>
18930 * support.cs (InternalParameters): Don't crash if we don't have
18931 any fixed parameters. Fixes #33532.
18933 2002-11-16 Martin Baulig <martin@ximian.com>
18935 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
18936 when looking up static methods to make this work on Windows.
18939 2002-11-16 Martin Baulig <martin@ximian.com>
18941 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
18942 a setter rather than using PropertyInfo.CanWrite.
18944 2002-11-15 Nick Drochak <ndrochak@gol.com>
18946 * class.cs: Allow acces to block member by subclasses. Fixes build
18949 2002-11-14 Martin Baulig <martin@ximian.com>
18951 * class.cs (Constructor.Emit): Added the extern/block check.
18954 2002-11-14 Martin Baulig <martin@ximian.com>
18956 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
18957 iteration while looking for indexers, this is needed because the
18958 indexer may have a different name in our base classes. Fixed the
18959 error reporting (no indexers at all, not get accessor, no
18960 overloaded match). Fixes bug #33089.
18961 (IndexerAccess.DoResolveLValue): Likewise.
18963 2002-11-14 Martin Baulig <martin@ximian.com>
18965 * class.cs (PropertyBase.CheckBase): Make this work for multiple
18966 indexers. Fixes the first part of bug #33089.
18967 (MethodSignature.InheritableMemberSignatureCompare): Added support
18970 2002-11-13 Ravi Pratap <ravi@ximian.com>
18972 * attribute.cs (Attribute.Resolve): Catch the
18973 NullReferenceException and report it since it isn't supposed to
18976 2002-11-12 Miguel de Icaza <miguel@ximian.com>
18978 * expression.cs (Binary.EmitBranchable): Also handle the cases for
18979 LogicalOr and LogicalAnd that can benefit from recursively
18980 handling EmitBranchable. The code now should be nice for Paolo.
18982 2002-11-08 Miguel de Icaza <miguel@ximian.com>
18984 * typemanager.cs (LookupType): Added a negative-hit hashtable for
18985 the Type lookups, as we perform quite a number of lookups on
18986 non-Types. This can be removed once we can deterministically tell
18987 whether we have a type or a namespace in advance.
18989 But this might require special hacks from our corlib.
18993 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
18994 and double which avoids a conversion from an integer to a double.
18996 * expression.cs: tiny optimization, avoid calling IsConstant,
18997 because it effectively performs the lookup twice.
18999 2002-11-06 Miguel de Icaza <miguel@ximian.com>
19001 But a bogus return here to keep the semantics of the old code
19002 until the Mono runtime is fixed.
19004 * pending.cs (GetMissingInterfaces): New method used to remove all
19005 the interfaces that are already implemented by our parent
19006 classes from the list of pending methods.
19008 * interface.cs: Add checks for calls after ResolveTypeExpr.
19010 2002-11-05 Miguel de Icaza <miguel@ximian.com>
19012 * class.cs (Class.Emit): Report warning 67: event not used if the
19013 warning level is beyond 3.
19015 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
19016 being a NullLiteral.
19018 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
19021 * class.cs (TypeContainer.GetClassBases): Cover a missing code
19022 path that might fail if a type can not be resolved.
19024 * expression.cs (Binary.Emit): Emit unsigned versions of the
19027 * driver.cs: use error 5.
19029 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
19031 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
19033 2002-11-01 Miguel de Icaza <miguel@ximian.com>
19035 * cs-parser.jay (switch_section): A beautiful patch from Martin
19036 Baulig that fixed 33094.
19038 2002-10-31 Miguel de Icaza <miguel@ximian.com>
19040 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
19041 Check whether the base is abstract and report an error if so.
19043 * expression.cs (IndexerAccess.DoResolveLValue,
19044 IndexerAccess.DoResolve): ditto.
19046 (Invocation.DoResolve): ditto.
19048 (Invocation.FullMethodDesc): Improve the report string.
19050 * statement.cs (Block): Eliminate IsVariableDefined as it is
19051 basically just a wrapper for GetVariableInfo.
19053 * ecore.cs (SimpleName): Use new
19055 * support.cs (ReflectionParamter.ParameterType): We unwrap the
19056 type, as we return the actual parameter ref/unref state on a
19059 2002-10-30 Miguel de Icaza <miguel@ximian.com>
19061 * support.cs: Return proper flags REF/OUT fixing the previous
19064 * expression.cs: Reverted last patch, that was wrong. Is_ref is
19065 not used to mean `ref' but `ref or out' in ParameterReference
19067 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
19068 full type signature instead of calling TypeManger.CSharpName
19071 * support.cs (InternalParameters.ParameterDesc): Do not compare
19072 directly to the modflags, because REF/OUT will actually be bitsets
19075 * delegate.cs (VerifyMethod): Check also the modifiers.
19077 * cs-tokenizer.cs: Fix bug where floating point values with an
19078 exponent where a sign was missing was ignored.
19080 * driver.cs: Allow multiple assemblies to be specified in a single
19083 2002-10-28 Miguel de Icaza <miguel@ximian.com>
19085 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
19086 because identifiers after a parenthesis would end up in this kind
19087 of production, and we needed to desamiguate it for having casts
19090 (UserDefinedType *) xxx
19092 2002-10-24 Miguel de Icaza <miguel@ximian.com>
19094 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
19095 we should set on the Bindingflags.NonPublic, but not turn on
19096 private_ok. private_ok controls whether a Private member is
19097 returned (this is chekced on the filter routine), while the
19098 BindingFlags.NonPublic just controls whether private/protected
19099 will be allowed. This fixes the problem part of the problem of
19100 private properties being allowed to be used in derived classes.
19102 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
19103 so we can call the children DoResolveLValue method (this will
19104 properly signal errors on lvalue assignments to base properties)
19106 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
19107 getter are null, and we have a property info, we know that this
19108 happened because the lookup failed, so we report an error 122 for
19109 protection level violation.
19111 We also silently return if setter and getter are null in the
19112 resolve functions, this condition only happens if we have flagged
19113 the error before. This is the other half of the problem.
19115 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
19116 not have accessibility information, that is why we were returning
19117 true in the filter function in typemanager.cs.
19119 To properly report 122 (property is inaccessible because of its
19120 protection level) correctly, we report this error in ResolveAccess
19121 by failing if both the setter and the getter are lacking (ie, the
19124 DoResolve and DoLResolve have been modified to check for both
19125 setter/getter being null and returning silently, the reason being
19126 that I did not want to put the knowledge about this error in upper
19129 int old = Report.Errors;
19130 x = new PropertyExpr (...);
19131 if (old != Report.Errors)
19136 So the property expr is returned, but it is invalid, so the error
19137 will be flagged during the resolve process.
19139 * class.cs: Remove InheritablePropertySignatureCompare from the
19140 class, as we no longer depend on the property signature to compute
19141 whether it is possible to implement a method or not.
19143 The reason is that calling PropertyInfo.GetGetMethod will return
19144 null (in .NET, in Mono it works, and we should change this), in
19145 cases where the Get Method does not exist in that particular
19150 class X { public virtual int A { get { return 1; } } }
19152 class Z : Y { public override int A { get { return 2; } } }
19154 Would fail in Z because the parent (Y) would not have the property
19155 defined. So we avoid this completely now (because the alternative
19156 fix was ugly and slow), and we now depend exclusively on the
19159 (PropertyBase.CheckBase): Use a method-base mechanism to find our
19160 reference method, instead of using the property.
19162 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
19163 routines are gone now.
19165 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
19166 names, they were incorrectly named.
19168 * cs-tokenizer.cs: Return are more gentle token on failure.
19170 * pending.cs (PendingImplementation.InterfaceMethod): This routine
19171 had an out-of-sync index variable, which caused it to remove from
19172 the list of pending methods the wrong method sometimes.
19174 2002-10-22 Miguel de Icaza <miguel@ximian.com>
19176 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
19177 CanWrite, because those refer to this particular instance of the
19178 property, and do not take into account the fact that we can
19179 override single members of a property.
19181 Constructor requires an EmitContext. The resolution process does
19182 not happen here, but we need to compute the accessors before,
19183 because the resolution does not always happen for properties.
19185 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
19186 subclass, before we did not update this flag, but we did update
19189 (GetAccessors): Drop this routine, as it did not work in the
19190 presence of partially overwritten set/get methods.
19192 Notice that this broke the cs1540 detection, but that will require
19195 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19199 * driver.cs: issue a warning instead of an error if we don't support
19200 debugging for the platform. Also ignore a couple of errors that may
19201 arise when trying to write the symbols. Undo my previous patch.
19203 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19205 * driver.cs: ignore /debug switch except for Unix platforms.
19207 2002-10-23 Nick Drochak <ndrochak@gol.com>
19209 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
19211 2002-10-21 Miguel de Icaza <miguel@ximian.com>
19213 * driver.cs: Do not make mcs-debug conditional, so we do not break
19214 builds that use it.
19216 * statement.cs (UsageVector.MergeChildren): I would like Martin to
19217 review this patch. But basically after all the children variables
19218 have been merged, the value of "Breaks" was not being set to
19219 new_breaks for Switch blocks. I think that it should be set after
19220 it has executed. Currently I set this to the value of new_breaks,
19221 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
19222 conservative, but I do not understand this code very well.
19224 I did not break anything in the build, so that is good ;-)
19226 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
19228 2002-10-20 Mark Crichton <crichton@gimp.org>
19230 * cfold.cs: Fixed compile blocker. Really fixed it this time.
19232 2002-10-20 Nick Drochak <ndrochak@gol.com>
19234 * cfold.cs: Fixed compile blocker.
19236 2002-10-20 Miguel de Icaza <miguel@ximian.com>
19238 * driver.cs: I was chekcing the key, not the file.
19240 2002-10-19 Ravi Pratap <ravi@ximian.com>
19242 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
19243 message that we were generating - we just need to silently return
19246 2002-10-19 Miguel de Icaza <miguel@ximian.com>
19248 * class.cs (Event.Define): Change my previous commit, as this
19249 breaks the debugger. This is a temporary hack, as it seems like
19250 the compiler is generating events incorrectly to begin with.
19252 * expression.cs (Binary.ResolveOperator): Added support for
19253 "U operator - (E x, E y)"
19255 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
19258 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
19259 init-only variables, but this path did not take into account that
19260 there might be also instance readonly variables. Correct this
19263 This fixes bug 32253
19265 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
19268 * driver.cs: Change the extension for modules to `netmodule'
19270 * cs-parser.jay: Improved slightly the location tracking for
19271 the debugger symbols.
19273 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
19274 modifiers that were specified instead of the hardcoded value
19275 (FamAndAssem). This was basically ignoring the static modifier,
19276 and others. Fixes 32429.
19278 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
19279 fixed a bug in the process (32476)
19281 * expression.cs (ArrayAccess.EmitAssign): Patch from
19282 hwang_rob@yahoo.ca that fixes bug 31834.3
19284 2002-10-18 Miguel de Icaza <miguel@ximian.com>
19286 * driver.cs: Make the module extension .netmodule.
19288 2002-10-16 Miguel de Icaza <miguel@ximian.com>
19290 * driver.cs: Report an error if the resource file is not found
19291 instead of crashing.
19293 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
19294 false, like Emit does.
19296 2002-10-16 Nick Drochak <ndrochak@gol.com>
19298 * typemanager.cs: Remove unused private member. Also reported mcs
19299 bug to report this as a warning like csc.
19301 2002-10-15 Martin Baulig <martin@gnome.org>
19303 * statement.cs (Statement.Emit): Made this a virtual method; emits
19304 the line number info and calls DoEmit().
19305 (Statement.DoEmit): New protected abstract method, formerly knows
19306 as Statement.Emit().
19308 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
19310 2002-10-11 Miguel de Icaza <miguel@ximian.com>
19312 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
19313 have fixed a remaining problem: not every AddXXXX was adding a
19314 fully qualified name.
19316 Now everyone registers a fully qualified name in the DeclSpace as
19317 being defined instead of the partial name.
19319 Downsides: we are slower than we need to be due to the excess
19320 copies and the names being registered this way.
19322 The reason for this is that we currently depend (on the corlib
19323 bootstrap for instance) that types are fully qualified, because
19324 we dump all the types in the namespace, and we should really have
19325 types inserted into the proper namespace, so we can only store the
19326 basenames in the defined_names array.
19328 2002-10-10 Martin Baulig <martin@gnome.org>
19330 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
19331 from bug #31834, see the bug report for a testcase which is
19334 2002-10-10 Martin Baulig <martin@gnome.org>
19336 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
19337 flow analysis code for this.
19339 * statement.cs (Do, While, For): Tell the flow analysis code about
19341 (FlowBranching.UsageVector): Added support for infinite loops.
19342 (Block.Resolve): Moved the dead code elimination here and use flow
19345 2002-10-09 Miguel de Icaza <miguel@ximian.com>
19347 * class.cs (Field.Define): Catch cycles on struct type
19350 * typemanager.cs (IsUnmanagedtype): Do not recursively check
19351 fields if the fields are static. We only need to check instance
19354 * expression.cs (As.DoResolve): Test for reference type.
19356 * statement.cs (Using.ResolveExpression): Use
19357 ConvertImplicitRequired, not ConvertImplicit which reports an
19359 (Using.ResolveLocalVariableDecls): ditto.
19361 * expression.cs (Binary.ResolveOperator): Report errors in a few
19362 places where we had to.
19364 * typemanager.cs (IsUnmanagedtype): Finish implementation.
19366 2002-10-08 Miguel de Icaza <miguel@ximian.com>
19368 * expression.cs: Use StoreFromPtr instead of extracting the type
19369 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
19371 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
19372 an enumeration value to a System.Enum, but System.Enum is not a
19373 value type, but an class type, so we need to box.
19375 (Expression.ConvertExplicit): One codepath could return
19376 errors but not flag them. Fix this. Fixes #31853
19378 * parameter.cs (Resolve): Do not allow void as a parameter type.
19380 2002-10-06 Martin Baulig <martin@gnome.org>
19382 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
19383 if it's a class type and not a struct. Fixes #31815.
19385 2002-10-06 Martin Baulig <martin@gnome.org>
19387 * statement.cs: Reworked the flow analysis code a bit to make it
19388 usable for dead code elimination.
19390 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19392 * cs-parser.jay: allow empty source files. Fixes bug #31781.
19394 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19396 * expression.cs (ComposedCast.DoResolveType): A quick workaround
19397 to fix the test 165, will investigate deeper.
19399 2002-10-04 Martin Baulig <martin@gnome.org>
19401 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
19402 finally blocks actually work.
19403 (Try.Resolve): We don't need to create a sibling for `finally' if
19404 there is no finally block.
19406 2002-10-04 Martin Baulig <martin@gnome.org>
19408 * class.cs (Constructor.Define): The default accessibility for a
19409 non-default constructor is private, not public.
19411 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19413 * class.cs (Constructor): Make AllowedModifiers public, add
19416 * cs-parser.jay: Perform the modifiers test here, as the
19417 constructor for the Constructor class usually receives a zero
19418 because of the way we create it (first we create, later we
19419 customize, and we were never checking the modifiers).
19421 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
19422 is a version of LookupTypeReflection that includes the type-name
19423 cache. This can be used as a fast path for functions that know
19424 the fully qualified name and are only calling into *.GetType() to
19425 obtain a composed type.
19427 This is also used by TypeManager.LookupType during its type
19430 (LookupType): We now also track the real type name, as sometimes
19431 we can get a quey for the real type name from things like
19432 ComposedCast. This fixes bug 31422.
19434 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
19435 complete type fullname, it does not have to go through the type
19436 resolution system to obtain the composed version of the type (for
19437 obtaining arrays or pointers).
19439 (Conditional.Emit): Use the EmitBoolExpression to
19440 generate nicer code, as requested by Paolo.
19442 (ArrayCreation.CheckIndices): Use the patch from
19443 hwang_rob@yahoo.ca to validate the array initializers.
19445 2002-10-03 Miguel de Icaza <miguel@ximian.com>
19447 * class.cs (ConstructorInitializer.Emit): simplify code by using
19448 Invocation.EmitCall, and at the same time, fix the bugs in calling
19449 parent constructors that took variable arguments.
19451 * ecore.cs (Expression.ConvertNumericExplicit,
19452 Expression.ImplicitNumericConversion): Remove the code that
19453 manually wrapped decimal (InternalTypeConstructor call is now gone
19456 * expression.cs (Cast.TryReduce): Also handle decimal types when
19457 trying to perform a constant fold on the type.
19459 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19461 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19462 that only turned off an error report, and did nothing else.
19464 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19466 * driver.cs: Handle and ignore /fullpaths
19468 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19470 * expression.cs (Binary.ResolveOperator): Catch the case where
19471 DoNumericPromotions returns true,
19473 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19475 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19477 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19480 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19482 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19483 conversion exists, but it is also required that the conversion be
19484 performed. This manifested in "(Type64Enum) 2".
19486 * class.cs (TypeManager.AddMethod): The fix is not to change
19487 AddEnum, because that one was using a fully qualified name (every
19488 DeclSpace derivative does), but to change the AddMethod routine
19489 that was using an un-namespaced name. This now correctly reports
19490 the duplicated name.
19492 Revert patch until I can properly fix it. The issue
19493 is that we have a shared Type space across all namespaces
19494 currently, which is wrong.
19496 Options include making the Namespace a DeclSpace, and merge
19497 current_namespace/current_container in the parser.
19499 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19501 * cs-parser.jay: Improve error reporting when we get a different
19502 kind of expression in local_variable_type and
19503 local_variable_pointer_type.
19505 Propagate this to avoid missleading errors being reported.
19507 * ecore.cs (ImplicitReferenceConversion): treat
19508 TypeManager.value_type as a target just like object_type. As
19513 Is valid, and needs to result in the int 1 being boxed before it
19514 is assigned to the value type v.
19516 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19517 to validate the enumeration name.
19519 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19520 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19521 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19523 * ecore.cs (TryImplicitIntConversion): When doing an
19524 implicit-enumeration-conversion, check if the type is 64-bits and
19525 perform a conversion before passing to EnumConstant.
19527 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19529 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19530 report ambiguous type references. Unlike the MS version, we
19531 report what the ambiguity is. Innovation at work ;-)
19533 (DeclSpace.FindType): Require a location argument to
19534 display when we display an ambiguous error.
19536 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19538 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19540 * expression.cs (EmitDynamicInitializers): Apply patch from
19541 hwang_rob@yahoo.ca that fixes the order in which we emit our
19544 2002-09-21 Martin Baulig <martin@gnome.org>
19546 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19547 delegate takes no arguments.
19549 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19551 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19554 * expression.cs: Extract the underlying type.
19556 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19558 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19560 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19562 * class.cs (TypeContainer.DefineType): We can not use the nice
19563 PackingSize with the size set to 1 DefineType method, because it
19564 will not allow us to define the interfaces that the struct
19567 This completes the fixing of bug 27287
19569 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19570 means also structs. This fixes part of the problem.
19571 (Expresion.ImplicitReferenceConversionExists): ditto.
19573 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
19574 error if there were no errors reported during the type lookup
19575 process, to avoid duplicates or redundant errors. Without this
19576 you would get an ambiguous errors plus a type not found. We have
19577 beaten the user enough with the first error.
19579 (DeclSparce.FindType): Emit a warning if we have an ambiguous
19582 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
19583 during the resolution process, stop the lookup, this avoids
19584 repeated error reports (same error twice).
19586 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
19588 * typemanager.cs (LookupType): Redo the type lookup code to match
19589 the needs of System.Reflection.
19591 The issue is that System.Reflection requires references to nested
19592 types to begin with a "+" sign instead of a dot. So toplevel
19593 types look like: "NameSpace.TopLevelClass", and nested ones look
19594 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
19597 2002-09-19 Martin Baulig <martin@gnome.org>
19599 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
19600 says that a method always returns or always throws an exception,
19601 don't report the CS0161.
19603 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
19604 set `Returns = new_returns'.
19606 2002-09-19 Martin Baulig <martin@gnome.org>
19608 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
19609 to an enum constant, check for a CS0176.
19611 2002-09-18 Miguel de Icaza <miguel@ximian.com>
19613 * class.cs (TypeContainer.CheckPairedOperators): Now we check
19614 for operators that must be in pairs and report errors.
19616 * ecore.cs (SimpleName.DoResolveType): During the initial type
19617 resolution process, when we define types recursively, we must
19618 check first for types in our current scope before we perform
19619 lookups in the enclosing scopes.
19621 * expression.cs (MakeByteBlob): Handle Decimal blobs.
19623 (Invocation.VerifyArgumentsCompat): Call
19624 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
19625 I thought we were supposed to always call this, but there are a
19626 few places in the code where we dont do it.
19628 2002-09-17 Miguel de Icaza <miguel@ximian.com>
19630 * driver.cs: Add support in -linkres and -resource to specify the
19631 name of the identifier.
19633 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19635 * ecore.cs (StandardConversionExists): Sync with the conversion
19636 code: allow anything-* to void* conversions.
19638 (FindMostSpecificSource): Use an Expression argument
19639 instead of a Type, because we might be handed over a Literal which
19640 gets a few more implicit conversions that plain types do not. So
19641 this information was being lost.
19643 Also, we drop the temporary type-holder expression when not
19646 2002-09-17 Martin Baulig <martin@gnome.org>
19648 * class.cs (PropertyBase.CheckBase): Don't check the base class if
19649 this is an explicit interface implementation.
19651 2002-09-17 Martin Baulig <martin@gnome.org>
19653 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
19654 different `IndexerName' attributes.
19656 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
19657 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
19658 virtual CommonResolve().
19660 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19662 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
19663 and convert that to the UnderlyingType.
19665 * statement.cs (Foreach.Resolve): Indexers are just like variables
19666 or PropertyAccesses.
19668 * cs-tokenizer.cs (consume_string): Track line numbers and columns
19669 inside quoted strings, we were not doing this before.
19671 2002-09-16 Martin Baulig <martin@gnome.org>
19673 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
19674 resolve it. This is needed for the definite assignment check of the
19675 instance expression, fixes bug #29846.
19676 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
19678 2002-09-16 Nick Drochak <ndrochak@gol.com>
19680 * parameter.cs: Fix compile error. Cannot reference static member
19681 from an instance object. Is this an mcs bug?
19683 2002-09-14 Martin Baulig <martin@gnome.org>
19685 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
19686 multiple times. Fixes bug #30295, added test-166.cs.
19688 2002-09-14 Martin Baulig <martin@gnome.org>
19690 * statement.cs (Block.Emit): Don't emit unreachable code.
19691 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
19692 `break' statements.
19693 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
19695 2002-09-14 Martin Baulig <martin@gnome.org>
19697 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
19700 2002-09-14 Martin Baulig <martin@gnome.org>
19702 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
19703 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
19704 be false on the ms runtime.
19706 2002-09-13 Martin Baulig <martin@gnome.org>
19708 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
19709 the CS0038 error message.
19711 2002-09-12 Miguel de Icaza <miguel@ximian.com>
19713 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
19714 constant inside, return it.
19716 2002-09-12 Martin Baulig <martin@gnome.org>
19718 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
19719 implicit conversion can be done between enum types.
19721 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
19722 check whether an implicit conversion to the current enum's UnderlyingType
19723 exists and report an error if not.
19725 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
19726 without debugging support.
19728 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
19729 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
19731 2002-09-12 Martin Baulig <martin@gnome.org>
19733 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
19735 * ecore.cs (IMemberExpr.DeclaringType): New property.
19736 (SimpleName.SimpleNameResolve): Check whether we're accessing a
19737 nonstatic member of an outer type (CS0038).
19739 2002-09-11 Miguel de Icaza <miguel@ximian.com>
19741 * driver.cs: Activate the using-error detector at warning level
19742 4 (at least for MS-compatible APIs).
19744 * namespace.cs (VerifyUsing): Small buglett fix.
19746 * pending.cs (PendingImplementation): pass the container pointer.
19748 * interface.cs (GetMethods): Allow for recursive definition. Long
19749 term, I would like to move every type to support recursive
19750 definitions, not the current ordering mechanism that we have right
19753 The situation is this: Attributes are handled before interfaces,
19754 so we can apply attributes to interfaces. But some attributes
19755 implement interfaces, we will now handle the simple cases
19756 (recursive definitions will just get an error).
19758 * parameter.cs: Only invalidate types at the end if we fail to
19761 2002-09-09 Martin Baulig <martin@gnome.org>
19763 * ecore.cs (PropertyExpr.Emit): Also check for
19764 TypeManager.system_int_array_get_length so this'll also work when
19765 compiling corlib. Fixes #30003.
19767 2002-09-09 Martin Baulig <martin@gnome.org>
19769 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
19770 and throw an exception if we can't get the type's size. Fixed #30040,
19773 2002-09-09 Martin Baulig <martin@gnome.org>
19775 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
19777 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
19778 context. Fixes bug #30027.
19780 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
19781 virtual functions. Fixes bug #30043, added test-164.cs.
19783 2002-09-08 Ravi Pratap <ravi@ximian.com>
19785 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
19787 2002-09-08 Nick Drochak <ndrochak@gol.com>
19789 * driver.cs: Use an object to get the windows codepage since it's not a
19792 2002-09-08 Miguel de Icaza <miguel@ximian.com>
19794 * statement.cs (For.Emit): for infinite loops (test == null)
19795 return whether there is a break inside, not always "true".
19797 * namespace.cs (UsingEntry): New struct to hold the name of the
19798 using definition, the location where it is defined, and whether it
19799 has been used in a successful type lookup.
19801 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
19806 2002-09-06 Ravi Pratap <ravi@ximian.com>
19808 * attribute.cs : Fix incorrect code which relied on catching
19809 a NullReferenceException to detect a null being passed in
19810 where an object was expected.
19812 2002-09-06 Miguel de Icaza <miguel@ximian.com>
19814 * statement.cs (Try): flag the catch variable as assigned
19816 * expression.cs (Cast): Simplified by using ResolveType instead of
19817 manually resolving.
19819 * statement.cs (Catch): Fix bug by using ResolveType.
19821 2002-09-06 Ravi Pratap <ravi@ximian.com>
19823 * expression.cs (BetterConversion): Special case for when we have
19824 a NullLiteral as the argument and we have to choose between string
19825 and object types - we choose string the way csc does.
19827 * attribute.cs (Attribute.Resolve): Catch the
19828 NullReferenceException and report error #182 since the Mono
19829 runtime no more has the bug and having this exception raised means
19830 we tried to select a constructor which takes an object and is
19833 2002-09-05 Ravi Pratap <ravi@ximian.com>
19835 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
19836 message (1502, 1503) when we can't locate a method after overload
19837 resolution. This is much more informative and closes the bug
19840 * interface.cs (PopulateMethod): Return if there are no argument
19841 types. Fixes a NullReferenceException bug.
19843 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
19844 expressions too. Previously we were checking only in one place for
19845 positional arguments leaving out named arguments.
19847 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
19848 type to the enum type is not allowed. Remove code corresponding to
19851 (ConvertNumericExplicit): Allow explicit conversions from
19852 the underlying type to enum type. This precisely follows the spec
19853 and closes a bug filed by Gonzalo.
19855 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19858 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
19860 2002-09-03 Miguel de Icaza <miguel@ximian.com>
19862 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
19863 it was important that we stored the right value after the
19864 reduction in `converted'.
19866 2002-09-04 Martin Baulig <martin@gnome.org>
19868 * location.cs (Location.SymbolDocument): Use full pathnames for the
19871 2002-08-30 Miguel de Icaza <miguel@ximian.com>
19873 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
19874 of the expression resolve mechanism, because that will catch the
19875 SimpleName error failures.
19877 (Conditional): If we can not resolve the
19878 expression, return, do not crash.
19880 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19883 (location): display token name instead of its number.
19885 2002-08-28 Martin Baulig <martin@gnome.org>
19887 * expression.cs (Binary.ResolveOperator): Don't silently return
19888 but return an error if an operator cannot be applied between two
19891 2002-08-28 Martin Baulig <martin@gnome.org>
19893 * class.cs (Constructor.Define): Set the permission attributes
19894 correctly instead of making all constructors public.
19896 2002-08-28 Martin Baulig <martin@gnome.org>
19898 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
19899 for private members before reporting a CS0103; if we find anything,
19902 2002-08-28 Martin Baulig <martin@gnome.org>
19904 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
19905 to check whether `closure_start_type == closure_invocation_type',
19906 we also need to check whether `m.DeclaringType == closure_invocation_type'
19907 before bypassing the permission checks. We might be accessing
19908 protected/private members from the base class.
19909 (TypeManager.RealMemberLookup): Only set private_ok if private
19910 members were requested via BindingFlags.NonPublic.
19912 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
19914 * expression.cs (MemberAccess.ResolveMemberAccess): Set
19915 MethodGroupExpr.IsExplicitImpl if appropriate.
19916 (Invocation.DoResolve): Don't report the CS0120 for explicit
19917 interface implementations.
19919 2002-08-27 Martin Baulig <martin@gnome.org>
19921 * expression.cs (Invocation.DoResolve): If this is a static
19922 method and we don't have an InstanceExpression, we must report
19925 2002-08-25 Martin Baulig <martin@gnome.org>
19927 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
19928 `==' between a valuetype and an object.
19930 2002-08-25 Miguel de Icaza <miguel@ximian.com>
19932 * ecore.cs (TypeExpr): Provide a ToString method.
19934 2002-08-24 Martin Baulig <martin@gnome.org>
19936 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
19937 now called proggie.dbg and it's a binary file.
19939 2002-08-23 Martin Baulig <martin@gnome.org>
19941 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
19943 2002-08-23 Martin Baulig <martin@gnome.org>
19945 * struct.cs (MyStructInfo.ctor): Make this work with empty
19946 structs; it's not allowed to use foreach() on null.
19948 2002-08-23 Martin Baulig <martin@gnome.org>
19950 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
19951 writer the full pathname of the generated assembly.
19953 2002-08-23 Martin Baulig <martin@gnome.org>
19955 * statements.cs (FlowBranching.UsageVector.MergeChildren):
19956 A `finally' block never returns or breaks; improved handling of
19959 2002-08-23 Martin Baulig <martin@gnome.org>
19961 * statement.cs (Throw.Resolve): Allow `throw null'.
19963 2002-08-23 Martin Baulig <martin@gnome.org>
19965 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
19966 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
19967 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
19968 MemberLookup would return a wrong event if this is an explicit
19969 interface implementation and the class has an event with the same
19972 2002-08-23 Martin Baulig <martin@gnome.org>
19974 * statement.cs (Block.AddChildVariableNames): New public method.
19975 (Block.AddChildVariableName): Likewise.
19976 (Block.IsVariableNameUsedInChildBlock): Likewise.
19977 (Block.AddVariable): Check whether a variable name has already
19978 been used in a child block.
19980 * cs-parser.jay (declare_local_variables): Mark all variable names
19981 from the current block as being used in a child block in the
19984 2002-08-23 Martin Baulig <martin@gnome.org>
19986 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
19987 find the symbol writer.
19989 * driver.cs: csc also allows the arguments to /define being
19990 separated by commas, not only by semicolons.
19992 2002-08-23 Martin Baulig <martin@gnome.org>
19994 * interface.cs (Interface.GetMembers): Added static check for events.
19996 2002-08-15 Martin Baulig <martin@gnome.org>
19998 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
19999 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
20001 * ecore.cs (Expression.MemberLookup): Added documentation and explained
20002 why the MethodData.EmitDestructor() change was necessary.
20004 2002-08-20 Martin Baulig <martin@gnome.org>
20006 * class.cs (TypeContainer.FindMembers): Added static check for events.
20008 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
20010 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
20011 use Type.GetEvents(), not Type.FindMembers().
20013 2002-08-20 Martin Baulig <martin@gnome.org>
20015 * decl.cs (MemberCache): Added a special method cache which will
20016 be used for method-only searched. This ensures that a method
20017 search will return a MethodInfo with the correct ReflectedType for
20020 2002-08-20 Martin Baulig <martin@gnome.org>
20022 * decl.cs (DeclSpace.FindMembers): Made this public.
20024 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20026 * delegate.cs: fixed build on windows.
20027 [FIXME: Filed as bug #29150: MCS must report these errors.]
20029 2002-08-19 Ravi Pratap <ravi@ximian.com>
20031 * ecore.cs (StandardConversionExists): Return a false
20032 if we are trying to convert the void type to anything else
20033 since that is not allowed.
20035 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
20036 we flag error 70 in the event an event is trying to be accessed
20037 directly from outside the declaring type.
20039 2002-08-20 Martin Baulig <martin@gnome.org>
20041 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
20042 MemberCache from typemanager.cs to decl.cs.
20044 2002-08-19 Martin Baulig <martin@gnome.org>
20046 * class.cs (TypeContainer): Implement IMemberContainer.
20047 (TypeContainer.DefineMembers): Create the MemberCache.
20048 (TypeContainer.FindMembers): Do better BindingFlags checking; only
20049 return public members if BindingFlags.Public was given, check
20050 whether members are static.
20052 2002-08-16 Martin Baulig <martin@gnome.org>
20054 * decl.cs (DeclSpace.Define): Splitted this in Define and
20055 DefineMembers. DefineMembers is called first and initializes the
20058 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
20059 DefineMembers() on all our DeclSpaces.
20061 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
20062 but call DefineMembers() on all nested interfaces. We call their
20063 Define() in our new Define() function.
20065 * interface.cs (Interface): Implement IMemberContainer.
20066 (Interface.Define): Moved all code except the attribute stuf to
20068 (Interface.DefineMembers): Initialize the member cache.
20070 * typemanager.cs (IMemberFinder): Removed this interface, we don't
20071 need this anymore since we can use MemberCache.FindMembers directly.
20073 2002-08-19 Martin Baulig <martin@gnome.org>
20075 * typemanager.cs (MemberCache): When creating the cache for an
20076 interface type, add all inherited members.
20077 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
20078 to `out bool used_cache' and documented it.
20079 (TypeManager.MemberLookup): If we already used the cache in the first
20080 iteration, we don't need to do the interfaces check.
20082 2002-08-19 Martin Baulig <martin@gnome.org>
20084 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
20085 here from IMemberFinder and don't implement this interface anymore.
20086 (DeclSpace.MemberCache): Moved here from IMemberFinder.
20088 * typemanager.cs (IMemberFinder): This interface is now only used by
20089 classes which actually support the member cache.
20090 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
20091 since we only put DeclSpaces into this Hashtable.
20092 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
20093 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
20095 2002-08-16 Martin Baulig <martin@gnome.org>
20097 * typemanager.cs (ICachingMemberFinder): Removed.
20098 (IMemberFinder.MemberCache): New property.
20099 (TypeManager.FindMembers): Merged this with RealFindMembers().
20100 This function will never be called from TypeManager.MemberLookup()
20101 so we can't use the cache here, just the IMemberFinder.
20102 (TypeManager.MemberLookup_FindMembers): Check whether the
20103 IMemberFinder has a MemberCache and call the cache's FindMembers
20105 (MemberCache): Rewrote larger parts of this yet another time and
20106 cleaned it up a bit.
20108 2002-08-15 Miguel de Icaza <miguel@ximian.com>
20110 * driver.cs (LoadArgs): Support quoting.
20112 (Usage): Show the CSC-like command line arguments.
20114 Improved a few error messages.
20116 2002-08-15 Martin Baulig <martin@gnome.org>
20118 * typemanager.cs (IMemberContainer.Type): New property.
20119 (IMemberContainer.IsInterface): New property.
20121 The following changes are conditional to BROKEN_RUNTIME, which is
20122 defined at the top of the file.
20124 * typemanager.cs (MemberCache.MemberCache): Don't add the base
20125 class'es members, but add all members from TypeHandle.ObjectType
20126 if we're an interface.
20127 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
20128 is the current type.
20129 (MemberCache.CacheEntry.Container): Removed this field.
20130 (TypeHandle.GetMembers): Include inherited members.
20132 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20134 * typemanager.cs: fixed compilation and added a comment on a field that
20137 2002-08-15 Martin Baulig <martin@gnome.org>
20139 * class.cs (ConstructorInitializer.Resolve): In the
20140 Expression.MemberLookup call, use the queried_type as
20143 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
20144 declared' attribute, it's always true.
20145 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
20146 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
20147 temporary wrapper for FindMembers which tells MemberLookup whether
20148 members from the base classes are included in the return value.
20149 This will go away soon.
20150 (TypeManager.MemberLookup): Use this temporary hack here; once the
20151 new MemberCache is completed, we don't need to do the DeclaredOnly
20152 looping here anymore since the MemberCache will take care of this.
20153 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
20154 (MemberCache): When creating the MemberCache for a class, get
20155 members from the current class and all its base classes.
20156 (MemberCache.CacheEntry.Container): New field. This is a
20157 temporary hack until the Mono runtime is fixed to distinguish
20158 between ReflectedType and DeclaringType. It allows us to use MCS
20159 with both the MS runtime and the unfixed Mono runtime without
20160 problems and without accecting performance.
20161 (MemberCache.SearchMembers): The DeclaredOnly looping from
20162 TypeManager.MemberLookup is now done here.
20164 2002-08-14 Martin Baulig <martin@gnome.org>
20166 * statement.cs (MyStructInfo.MyStructInfo): Don't call
20167 Type.GetFields on dynamic types but get the fields from the
20168 corresponding TypeContainer.
20169 (MyStructInfo.GetStructInfo): Added check for enum types.
20171 * typemanager.cs (MemberList.IsSynchronized): Implemented.
20172 (MemberList.SyncRoot): Implemented.
20173 (TypeManager.FilterWithClosure): No need to check permissions if
20174 closure_start_type == closure_invocation_type, don't crash if
20175 closure_invocation_type is null.
20177 2002-08-13 Martin Baulig <martin@gnome.org>
20179 Rewrote TypeContainer.FindMembers to use a member cache. This
20180 gives us a speed increase of about 35% for the self-hosting MCS
20181 build and of about 15-20% for the class libs (both on GNU/Linux).
20183 * report.cs (Timer): New class to get enhanced profiling. This
20184 whole class is "TIMER" conditional since it remarkably slows down
20187 * class.cs (MemberList): New class. This is an IList wrapper
20188 which we're now using instead of passing MemberInfo[]'s around to
20189 avoid copying this array unnecessarily.
20190 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
20191 (ICachingMemberFinder, IMemberContainer): New interface.
20192 (TypeManager.FilterWithClosure): If `criteria' is null, the name
20193 has already been checked, otherwise use it for the name comparision.
20194 (TypeManager.FindMembers): Renamed to RealMemberFinder and
20195 provided wrapper which tries to use ICachingMemberFinder.FindMembers
20196 if possible. Returns a MemberList, not a MemberInfo [].
20197 (TypeHandle): New class, implements IMemberContainer. We create
20198 one instance of this class per type, it contains a MemberCache
20199 which is used to do the member lookups.
20200 (MemberCache): New class. Each instance of this class contains
20201 all members of a type and a name-based hash table.
20202 (MemberCache.FindMembers): This is our new member lookup
20203 function. First, it looks up all members of the requested name in
20204 the hash table. Then, it walks this list and sorts out all
20205 applicable members and returns them.
20207 2002-08-13 Martin Baulig <martin@gnome.org>
20209 In addition to a nice code cleanup, this gives us a performance
20210 increase of about 1.4% on GNU/Linux - not much, but it's already
20211 half a second for the self-hosting MCS compilation.
20213 * typemanager.cs (IMemberFinder): New interface. It is used by
20214 TypeManager.FindMembers to call FindMembers on a TypeContainer,
20215 Enum, Delegate or Interface.
20216 (TypeManager.finder_to_member_finder): New PtrHashtable.
20217 (TypeManager.finder_to_container): Removed.
20218 (TypeManager.finder_to_delegate): Removed.
20219 (TypeManager.finder_to_interface): Removed.
20220 (TypeManager.finder_to_enum): Removed.
20222 * interface.cs (Interface): Implement IMemberFinder.
20224 * delegate.cs (Delegate): Implement IMemberFinder.
20226 * enum.cs (Enum): Implement IMemberFinder.
20228 * class.cs (TypeContainer): Implement IMemberFinder.
20230 2002-08-12 Martin Baulig <martin@gnome.org>
20232 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
20234 2002-08-12 Martin Baulig <martin@gnome.org>
20236 * ecore.cs (ITypeExpression): New interface for expressions which
20238 (TypeExpression): Renamed to TypeLookupExpression.
20239 (Expression.DoResolve): If we're doing a types-only lookup, the
20240 expression must implement the ITypeExpression interface and we
20241 call DoResolveType() on it.
20242 (SimpleName): Implement the new ITypeExpression interface.
20243 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
20244 hack, the situation that we're only looking up types can't happen
20245 anymore when this method is called. Moved the type lookup code to
20246 DoResolveType() and call it.
20247 (SimpleName.DoResolveType): This ITypeExpression interface method
20248 is now doing the types-only lookup.
20249 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
20250 (ResolveFlags): Added MaskExprClass.
20252 * expression.cs (MemberAccess): Implement the ITypeExpression
20254 (MemberAccess.DoResolve): Added support for a types-only lookup
20255 when we're called via ITypeExpression.DoResolveType().
20256 (ComposedCast): Implement the ITypeExpression interface.
20258 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
20259 Expression.Resolve() with ResolveFlags.Type instead.
20261 2002-08-12 Martin Baulig <martin@gnome.org>
20263 * interface.cs (Interface.Define): Apply attributes.
20265 * attribute.cs (Attribute.ApplyAttributes): Added support for
20266 interface attributes.
20268 2002-08-11 Martin Baulig <martin@gnome.org>
20270 * statement.cs (Block.Emit): Only check the "this" variable if we
20271 do not always throw an exception.
20273 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
20274 whether the property has a set accessor.
20276 2002-08-11 Martin Baulig <martin@gnome.org>
20278 Added control flow analysis support for structs.
20280 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
20281 with control flow analysis turned off.
20282 (IVariable): New interface.
20283 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
20284 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
20285 (FieldExpr.DoResolve): Resolve the instance expression with flow
20286 analysis turned off and do the definite assignment check after the
20287 resolving when we know what the expression will resolve to.
20289 * expression.cs (LocalVariableReference, ParameterReference):
20290 Implement the new IVariable interface, only call the flow analysis
20291 code if ec.DoFlowAnalysis is true.
20292 (This): Added constructor which takes a Block argument. Implement
20293 the new IVariable interface.
20294 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
20295 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
20296 This does the definite assignment checks for struct members.
20298 * class.cs (Constructor.Emit): If this is a non-static `struct'
20299 constructor which doesn't have any initializer, call
20300 Block.AddThisVariable() to tell the flow analysis code that all
20301 struct elements must be initialized before control returns from
20304 * statement.cs (MyStructInfo): New public class.
20305 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
20306 argument to this indexer. If non-zero, check an individual struct
20307 member, not the whole struct.
20308 (FlowBranching.CheckOutParameters): Check struct members.
20309 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
20310 overloaded versions of these methods which take an additional
20311 `int field_idx' argument to check struct members.
20312 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
20313 overloaded versions of these methods which take an additional
20314 `string field_name' argument to check struct member.s
20315 (VariableInfo): Implement the IVariable interface.
20316 (VariableInfo.StructInfo): New public property. Returns the
20317 MyStructInfo instance of the variable if it's a struct or null.
20318 (Block.AddThisVariable): New public method. This is called from
20319 Constructor.Emit() for non-static `struct' constructor which do
20320 not have any initializer. It creates a special variable for the
20321 "this" instance variable which will be checked by the flow
20322 analysis code to ensure that all of the struct's fields are
20323 initialized before control returns from the constructor.
20324 (UsageVector): Added support for struct members. If a
20325 variable/parameter is a struct with N members, we reserve a slot
20326 in the usage vector for each member. A struct is considered fully
20327 initialized if either the struct itself (slot 0) or all its
20328 members are initialized.
20330 2002-08-08 Martin Baulig <martin@gnome.org>
20332 * driver.cs (Driver.MainDriver): Only report an error CS5001
20333 if there were no compilation errors.
20335 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
20336 `UnsafeContext' property to determine whether the parent is in
20337 unsafe context rather than checking the parent's ModFlags:
20338 classes nested in an unsafe class are unsafe as well.
20340 2002-08-08 Martin Baulig <martin@gnome.org>
20342 * statement.cs (UsageVector.MergeChildren): Distinguish between
20343 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
20344 we return. Added test17() and test18() to test-154.cs.
20346 2002-08-08 Martin Baulig <martin@gnome.org>
20348 * typemanager.cs (TypeManager.FilterWithClosure): If we have
20349 Family access, make sure the invoking type isn't a subclass of the
20350 queried type (that'd be a CS1540).
20352 * ecore.cs (Expression.MemberLookup): Added overloaded version of
20353 this method which takes an additional `Type invocation_type'.
20355 * expression.cs (BaseAccess.DoResolve): Use the base type as
20356 invocation and query type.
20357 (MemberAccess.DoResolve): If the lookup failed and we're about to
20358 report a CS0122, try a lookup with the ec.ContainerType - if this
20359 succeeds, we must report a CS1540.
20361 2002-08-08 Martin Baulig <martin@gnome.org>
20363 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
20364 (MethodGroupExpr): Implement the IMemberExpr interface.
20366 * expression (MemberAccess.ResolveMemberAccess): No need to have
20367 any special code for MethodGroupExprs anymore, they're now
20370 2002-08-08 Martin Baulig <martin@gnome.org>
20372 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
20373 Family, FamANDAssem and FamORAssem permissions.
20374 (TypeManager.IsSubclassOrNestedChildOf): New public method.
20376 2002-08-08 Martin Baulig <martin@gnome.org>
20378 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
20379 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
20382 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
20384 * driver.cs: implemented /resource option to embed managed resources.
20386 2002-08-07 Martin Baulig <martin@gnome.org>
20388 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
20389 (FieldBase.HasFieldInitializer): New public property.
20390 (FieldBase.GetInitializerExpression): New public method. Resolves and
20391 returns the field initializer and makes sure it is only resolved once.
20392 (TypeContainer.EmitFieldInitializers): Call
20393 FieldBase.GetInitializerExpression to get the initializer, this ensures
20394 that it isn't resolved multiple times.
20396 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
20397 the resolving process (SimpleName/MemberLookup) that we're currently
20398 emitting a field initializer (which must not access any instance members,
20399 this is an error CS0236).
20401 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
20402 argument, if the `IsFieldInitializer' flag is set, we must report and
20403 error CS0236 and not an error CS0120.
20405 2002-08-07 Martin Baulig <martin@gnome.org>
20407 * ecore.cs (IMemberExpr): New public interface.
20408 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
20409 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
20410 if the expression is an IMemberExpr.
20412 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
20413 to be null, implicitly default to `this' if we're non-static in
20414 this case. Simplified the code a lot by using the new IMemberExpr
20415 interface. Also fixed bug #28176 here.
20417 2002-08-06 Martin Baulig <martin@gnome.org>
20419 * cs-parser.jay (SimpleLookup): Removed. We need to create
20420 ParameterReferences during semantic analysis so that we can do a
20421 type-only search when resolving Cast, TypeOf and SizeOf.
20422 (block): Pass the `current_local_parameters' to the Block's
20425 * class.cs (ConstructorInitializer): Added `Parameters parameters'
20426 argument to the constructor.
20427 (ConstructorInitializer.Resolve): Create a temporary implicit
20428 block with the parameters.
20430 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
20431 references here if we aren't doing a type-only search.
20433 * statement.cs (Block): Added constructor which takes a
20434 `Parameters parameters' argument.
20435 (Block.Parameters): New public property.
20437 * support.cs (InternalParameters.Parameters): Renamed `parameters'
20438 to `Parameters' and made it public readonly.
20440 2002-08-06 Martin Baulig <martin@gnome.org>
20442 * ecore.cs (Expression.Warning): Made this public as well.
20444 * report.cs (Report.Debug): Print the contents of collections.
20446 2002-08-06 Martin Baulig <martin@gnome.org>
20448 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
20449 used to tell Resolve() which kinds of expressions it may return.
20450 (Expression.Resolve): Added overloaded version of this method which
20451 takes a `ResolveFlags flags' argument. This can be used to tell
20452 Resolve() which kinds of expressions it may return. Reports a
20454 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20455 ResolveFlags.SimpleName.
20456 (Expression.Error118): Added overloaded version of this method which
20457 takes a `ResolveFlags flags' argument. It uses the flags to determine
20458 which kinds of expressions are allowed.
20460 * expression.cs (Argument.ResolveMethodGroup): New public method.
20461 Resolves an argument, but allows a MethodGroup to be returned.
20462 This is used when invoking a delegate.
20464 * TODO: Updated a bit.
20466 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20468 Fixed compilation with csc.
20470 * ecore.cs: Expression.Error made public. Is this correct? Should
20471 Warning be made public too?
20473 * expression.cs: use ea.Location instead of ea.loc.
20474 [FIXME: Filed as bug #28607: MCS must report these errors.]
20476 2002-08-06 Martin Baulig <martin@gnome.org>
20478 * ecore.cs (Expression.loc): Moved the location here instead of
20479 duplicating it in all derived classes.
20480 (Expression.Location): New public property.
20481 (Expression.Error, Expression.Warning): Made them non-static and
20482 removed the location argument.
20483 (Expression.Warning): Added overloaded version which takes an
20484 `int level' argument.
20485 (Expression.Error118): Make this non-static and removed the
20486 expression and location arguments.
20487 (TypeExpr): Added location argument to the constructor.
20489 * expression.cs (StaticCallExpr): Added location argument to
20491 (Indirection, PointerArithmetic): Likewise.
20492 (CheckedExpr, UnCheckedExpr): Likewise.
20493 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20494 (StringPtr): Likewise.
20497 2002-08-05 Martin Baulig <martin@gnome.org>
20499 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20501 * assign.cs (Assign.DoResolve): Check whether the source
20502 expression is a value or variable.
20504 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20505 while resolving the corresponding blocks.
20507 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20508 an error, don't silently return null.
20510 * statement.cs (Block.AddVariable): Do the error reporting here
20511 and distinguish between CS0128 and CS0136.
20512 (Block.DoResolve): Report all unused labels (warning CS0164).
20513 (LabeledStatement): Pass the location to the constructor.
20514 (LabeledStatement.HasBeenReferenced): New property.
20515 (LabeledStatement.Resolve): Set it to true here.
20517 * statement.cs (Return.Emit): Return success even after reporting
20518 a type mismatch error (CS0126 or CS0127), this is what csc does and
20519 it avoids confusing the users with any consecutive errors.
20521 2002-08-05 Martin Baulig <martin@gnome.org>
20523 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20525 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20527 * expression.cs (MemberAccess.DoResolve): Silently return if an
20528 error has already been reported.
20530 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20531 error has already been reported.
20533 2002-08-05 Martin Baulig <martin@gnome.org>
20535 * statement.cs (UsageVector): Only initialize the `parameters'
20536 vector if we actually have any "out" parameters.
20538 2002-08-05 Martin Baulig <martin@gnome.org>
20540 * expression.cs (Binary.ResolveOperator): When combining delegates,
20541 they must have the same type.
20543 2002-08-05 Martin Baulig <martin@gnome.org>
20545 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20546 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20547 work with the ms runtime and we also don't need it: if we're a
20548 PropertyBuilder and not in the `indexer_arguments' hash, then we
20549 are a property and not an indexer.
20551 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20552 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20553 since the latter one doesn't work with the ms runtime.
20555 2002-08-03 Martin Baulig <martin@gnome.org>
20557 Fixed bugs #27998 and #22735.
20559 * class.cs (Method.IsOperator): New public field.
20560 (Method.CheckBase): Report CS0111 if there's already a method
20561 with the same parameters in the current class. Report CS0508 when
20562 attempting to change the return type of an inherited method.
20563 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20564 and it's not marked abstract or extern.
20565 (PropertyBase): New abstract base class for Property and Indexer.
20566 (PropertyBase.CheckBase): Moved here from Property and made it work
20568 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20569 the same so we can reuse it there.
20570 (Property, Indexer): Derive from PropertyBase.
20571 (MethodSignature.inheritable_property_signature_filter): New delegate
20572 to find properties and indexers.
20574 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
20575 argument and improved error reporting.
20577 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
20578 EmptyReadOnlyParameters and made it a property.
20580 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
20581 version of this method which takes a `PropertyInfo indexer'.
20582 (TypeManager.RegisterIndexer): New method.
20584 * class.cs: Added myself as author of this file :-)
20586 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20588 * class.cs: fixed compilation on windoze.
20590 2002-08-03 Martin Baulig <martin@gnome.org>
20592 * interface.cs (Interface.GetInterfaceBases): Check whether all
20593 base interfaces are at least as accessible than the current one.
20595 * class.cs (TypeContainer.GetClassBases): Check whether base types
20596 are at least as accessible than the current type.
20597 (TypeContainer.AsAccessible): Implemented and made non-static.
20598 (MemberBase.CheckParameters): Report errors if the accessibility
20601 * delegate.cs (Delegate.Delegate): The default visibility is
20602 internal for top-level types and private for nested types.
20603 (Delegate.Define): Report errors if the accessibility checks fail.
20605 * enum.cs (Enum.Enum): The default visibility is internal for
20606 top-level types and private for nested types.
20607 (Enum.DefineType): Compute the correct visibility.
20609 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
20610 function which takes a `bool is_toplevel' instead of a TypeContainer.
20612 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
20615 2002-08-02 Martin Baulig <martin@gnome.org>
20617 * expression.cs (LocalVariableReferenc): Added constructor which
20618 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
20619 (LocalVariableReference.IsReadOnly): New property.
20620 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
20621 variable is readonly, use our own readonly flag to do this; you can
20622 use the new constructor to get a writable reference to a read-only
20625 * cs-parser.jay (foreach_statement, using_statement): Get a writable
20626 reference to the local variable.
20628 2002-08-01 Miguel de Icaza <miguel@ximian.com>
20630 * rootcontext.cs (ResolveCore): Also include System.Exception
20632 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
20633 we reach an EmptyStatement.
20635 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
20638 * expression.cs (Binary.ResolveOperator): Check error result in
20641 use brtrue/brfalse directly and avoid compares to null.
20643 2002-08-02 Martin Baulig <martin@gnome.org>
20645 * class.cs (TypeContainer.Define): Define all nested interfaces here.
20646 Fixes bug #28407, added test-155.cs.
20648 2002-08-01 Martin Baulig <martin@gnome.org>
20650 * class.cs (Event.EmitDefaultMethod): Make this work with static
20651 events. Fixes #28311, added verify-3.cs.
20653 2002-08-01 Martin Baulig <martin@gnome.org>
20655 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
20656 `is_disposable' fields.
20657 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
20658 `hm.is_disposable' if we're using the collection pattern.
20659 (Foreach.EmitCollectionForeach): Use the correct type for the
20660 enumerator's local variable, only emit the try/finally block if
20661 necessary (fixes #27713).
20663 2002-08-01 Martin Baulig <martin@gnome.org>
20665 * ecore.cs (Expression.report118): Renamed to Error118 and made
20668 * statement.cs (Throw.Resolve): Check whether the expression is of
20669 the correct type (CS0118) and whether the type derives from
20670 System.Exception (CS0155).
20671 (Catch.Resolve): New method. Do the type lookup here and check
20672 whether it derives from System.Exception (CS0155).
20673 (Catch.CatchType, Catch.IsGeneral): New public properties.
20675 * typemanager.cs (TypeManager.exception_type): Added.
20677 2002-07-31 Miguel de Icaza <miguel@ximian.com>
20679 * driver.cs: Updated About function.
20681 2002-07-31 Martin Baulig <martin@gnome.org>
20683 Implemented Control Flow Analysis.
20685 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
20686 (EmitContext.CurrentBranching): Added.
20687 (EmitContext.StartFlowBranching): Added.
20688 (EmitContext.EndFlowBranching): Added.
20689 (EmitContext.KillFlowBranching): Added.
20690 (EmitContext.IsVariableAssigned): Added.
20691 (EmitContext.SetVariableAssigned): Added.
20692 (EmitContext.IsParameterAssigned): Added.
20693 (EmitContext.SetParameterAssigned): Added.
20694 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
20695 Added control flow analysis stuff here.
20697 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
20698 resolve the expression as lvalue.
20699 (LocalVariableReference.DoResolve): Check whether the variable has
20700 already been assigned.
20701 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
20702 the parameter as assigned here.
20703 (ParameterReference.DoResolve): Check whether the parameter has already
20705 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
20706 expression as lvalue.
20708 * statement.cs (FlowBranching): New class for the flow analysis code.
20709 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
20710 (LabeledStatement.IsDefined): New public property.
20711 (LabeledStatement.AddUsageVector): New public method to tell flow
20712 analyis that the label may be reached via a forward jump.
20713 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
20715 (VariableInfo.Number): New public field. This is used by flow analysis
20716 to number all locals of a block.
20717 (Block.CountVariables): New public property. This is the number of
20718 local variables in this block (including the locals from all parent
20720 (Block.EmitMeta): Number all the variables.
20722 * statement.cs: Added flow analysis support to all classes.
20724 2002-07-31 Martin Baulig <martin@gnome.org>
20726 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
20727 To get debugging messages, compile mcs with /define:MCS_DEBUG and
20728 then use this argument.
20730 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
20732 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
20733 use this to specify /define options.
20735 2002-07-29 Martin Baulig <martin@gnome.org>
20737 * statement.cs (Fixed): Moved all code that does variable lookups
20738 and resolvings from Emit to Resolve.
20740 * statement.cs (For): Moved all code that does variable lookups
20741 and resolvings from Emit to Resolve.
20743 * statement.cs (Using): Moved all code that does variable lookups
20744 and resolvings from Emit to Resolve.
20746 2002-07-29 Martin Baulig <martin@gnome.org>
20748 * attribute.cs (Attribute.Resolve): Explicitly catch a
20749 System.NullReferenceException when creating the
20750 CustromAttributeBuilder and report a different warning message.
20752 2002-07-29 Martin Baulig <martin@gnome.org>
20754 * support.cs (ParameterData.ParameterName): Added method to
20755 get the name of a parameter.
20757 * typemanager.cs (TypeManager.IsValueType): New public method.
20759 2002-07-29 Martin Baulig <martin@gnome.org>
20761 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
20762 is a flag which specifies that it's either ref or out.
20763 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
20764 the out parameter to `out Parameter.Modifier mod', also set the
20765 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
20767 * support.cs (InternalParameters.ParameterModifier): Distinguish
20768 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20769 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20771 * expression.cs (Argument.GetParameterModifier): Distinguish
20772 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20773 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20775 2002-07-29 Martin Baulig <martin@gnome.org>
20777 * expression.cs (ParameterReference.ParameterReference): Added
20778 `Location loc' argument to the constructor.
20780 * cs-parser.jay: Pass location to ParameterReference.
20782 2002-07-28 Miguel de Icaza <miguel@ximian.com>
20784 * statement.cs (Try): Initialize the location.
20786 * cs-parser.jay: pass location to Try.
20788 * expression.cs (Unary.Reduce): Change the prototype to return
20789 whether a constant fold could be performed or not. The result is
20790 returned in an out parameters. In the case of Indirection and
20791 AddressOf, we want to perform the full tests.
20793 2002-07-26 Miguel de Icaza <miguel@ximian.com>
20795 * statement.cs (Statement.Emit): Flag dead code.
20797 2002-07-27 Andrew Birkett <andy@nobugs.org>
20799 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
20801 2002-07-27 Martin Baulig <martin@gnome.org>
20803 * class.cs (MethodData.Define): Put back call to
20804 TypeManager.AddMethod(), accidentally commented this out.
20806 * report.cs (Debug): New public method to print debugging information,
20807 this is `[Conditional ("DEBUG")]'.
20809 2002-07-26 Martin Baulig <martin@gnome.org>
20811 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
20812 (switch_statement): Push the current_block to the switch_stack and
20813 pop it again when we're done with the switch.
20814 (switch_section): The new block is a child of the current_block.
20815 Fixes bug #24007, added test-152.cs.
20817 2002-07-27 Martin Baulig <martin@gnome.org>
20819 * expression.cs (Invocation.EmitArguments): When calling a varargs
20820 function with only its fixed arguments, we need to pass an empty
20823 2002-07-27 Martin Baulig <martin@gnome.org>
20825 Mono 0.13 has been released.
20827 2002-07-25 Miguel de Icaza <miguel@ximian.com>
20829 * driver.cs: Rename --resource to --linkres, because that is what
20830 we do currently, we dont support --resource yet.
20832 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
20834 2002-07-25 Martin Baulig <martin@gnome.org>
20836 * class.cs (MethodData): New public class. This is a `method builder'
20837 class for a method or one accessor of a Property/Indexer/Event.
20838 (MethodData.GetMethodFlags): Moved here from MemberBase.
20839 (MethodData.ApplyAttributes): Likewise.
20840 (MethodData.ApplyObsoleteAttribute): Likewise.
20841 (MethodData.ApplyConditionalAttribute): Likewise.
20842 (MethodData.ApplyDllImportAttribute): Likewise.
20843 (MethodData.CheckAbstractAndExternal): Likewise.
20844 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
20845 (MethodData.Emit): Formerly known as Method.Emit().
20846 (MemberBase): Moved everything which was specific to a single
20847 accessor/method to MethodData.
20848 (Method): Create a new MethodData and call Define() and Emit() on it.
20849 (Property, Indexer, Event): Create a new MethodData objects for each
20850 accessor and call Define() and Emit() on them.
20852 2002-07-25 Martin Baulig <martin@gnome.org>
20854 Made MethodCore derive from MemberBase to reuse the code from there.
20855 MemberBase now also checks for attributes.
20857 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
20858 (MemberBase.GetMethodFlags): Moved here from class Method and marked
20860 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
20861 `CallingConventions cc' and `Attributes opt_attrs' arguments.
20862 (MemberBase.ApplyAttributes): New virtual method; applies the
20863 attributes to a method or accessor.
20864 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
20865 (MemberBase.ApplyConditionalAttribute): Likewise.
20866 (MemberBase.ApplyDllImportAttribute): Likewise.
20867 (MemberBase.CheckAbstractAndExternal): Likewise.
20868 (MethodCore.ParameterTypes): This is now a property instead of a
20869 method, it's initialized from DoDefineParameters().
20870 (MethodCore.ParameterInfo): Removed the set accessor.
20871 (MethodCore.DoDefineParameters): New protected virtual method to
20872 initialize ParameterTypes and ParameterInfo.
20873 (Method.GetReturnType): We can now simply return the MemberType.
20874 (Method.GetMethodFlags): Override the MemberBase version and add
20875 the conditional flags.
20876 (Method.CheckBase): Moved some code from Define() here, call
20877 DoDefineParameters() here.
20878 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
20879 here to avoid some larger code duplication.
20880 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
20881 ensure that abstract and external accessors don't declare a body.
20883 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
20884 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
20885 lookup in the attribute's parent classes, so we need to abort as soon
20886 as we found the first match.
20887 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
20888 the attribute has no arguments.
20890 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
20893 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20895 * cs-parser.jay: reverted previous patch.
20897 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20899 * cs-parser.jay: fixed bug #22119.
20901 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20903 * attribute.cs: fixed compilation. The error was:
20904 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
20905 be assigned to before control leaves the current method."
20906 [FIXME: Filed as bug #28186: MCS must report this error.]
20908 2002-07-25 Martin Baulig <martin@gnome.org>
20910 * attribute.cs (Attribute.Conditional_GetConditionName): New static
20911 method to pull the condition name ouf of a Conditional attribute.
20912 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
20913 the obsolete message and error flag out of an Obsolete attribute.
20915 * class.cs (Method.GetMethodFlags): New public method to get the
20916 TypeManager.MethodFlags for this method.
20917 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
20919 (Method.Define): Get and apply the Obsolete and Conditional attributes;
20920 if we're overriding a virtual function, set the new private variable
20921 `parent_method'; call the new TypeManager.AddMethod().
20923 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
20924 the MethodBuilder and the Method in a PtrHashtable.
20925 (TypeManager.builder_to_method): Added for this purpose.
20926 (TypeManager.MethodFlags): Added IsObsoleteError.
20927 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
20928 Obsolete and Conditional arguments in MethodBuilders. If we discover
20929 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
20930 the message from the attribute.
20932 2002-07-24 Martin Baulig <martin@gnome.org>
20934 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
20935 preprocessor directives, ensure that the argument to #define/#undef is
20936 exactly one identifier and that it's actually an identifier.
20938 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
20941 2002-07-24 Martin Baulig <martin@gnome.org>
20943 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
20944 initialize it to TypeManager.object_type in the constructor.
20945 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
20946 of the `hm.get_current' method if we're using the collection pattern.
20947 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
20948 for the explicit conversion to make it work when we're using the collection
20949 pattern and the `Current' property has a different return type than `object'.
20952 2002-07-24 Martin Baulig <martin@gnome.org>
20954 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
20955 does not match, but don't report any errors. This method is called in
20956 order for all methods in a MethodGroupExpr until a matching method is
20957 found, so we don't want to bail out if the first method doesn't match.
20958 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
20959 matches, report the 123. Fixes #28070.
20961 2002-07-24 Martin Baulig <martin@gnome.org>
20963 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
20964 TypeManager.TypeToCoreType() to the top of the method so the
20965 following equality checks will work. Fixes #28107.
20967 2002-07-24 Martin Baulig <martin@gnome.org>
20969 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
20970 operand is of type uint, and the other operand is of type sbyte,
20971 short or int, the operands are converted to type long." -
20972 Actually do what this comment already told us. Fixes bug #28106,
20975 2002-07-24 Martin Baulig <martin@gnome.org>
20977 * class.cs (MethodBase): New abstract class. This is now a base
20978 class for Property, Indexer and Event to avoid some code duplication
20979 in their Define() and DefineMethods() methods.
20980 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
20981 generic methods for Define() and DefineMethods().
20982 (FieldBase): Derive from MemberBase, not MemberCore.
20983 (Property): Derive from MemberBase, not MemberCore.
20984 (Property.DefineMethod): Moved all the code from this method to the
20985 new MethodBase.DefineAccessor(), just call it with appropriate
20987 (Property.Define): Call the new Property.DoDefine(), this does some
20988 sanity checks and we don't need to duplicate the code everywhere.
20989 (Event): Derive from MemberBase, not MemberCore.
20990 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
20991 accessors, this will also make them work with interface events.
20992 (Indexer): Derive from MemberBase, not MemberCore.
20993 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
20994 (Indexer.Define): Use the new MethodBase functions.
20996 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
20997 argument to the constructor.
20998 (Interface.FindMembers): Added support for interface events.
20999 (Interface.PopluateEvent): Implemented.
21001 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
21003 2002-07-22 Miguel de Icaza <miguel@ximian.com>
21005 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
21006 but this is required to check for a method name being the same as
21007 the containing class.
21011 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21013 * interface.cs: initialize variable.
21015 2002-07-23 Martin Baulig <martin@gnome.org>
21017 Implemented the IndexerName attribute in interfaces.
21019 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
21020 name if this is an explicit interface implementation.
21021 (Indexer.InterfaceIndexerName): New public variable. If we're
21022 implementing an interface indexer, this is the IndexerName in that
21023 interface. Otherwise, it's the IndexerName.
21024 (Indexer.DefineMethod): If we're implementing interface indexer,
21025 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
21026 and Pending.ImplementIndexer methods.
21027 (Indexer.Define): Also define the PropertyBuilder if we're
21028 implementing an interface indexer and this is neither an explicit
21029 interface implementation nor do the IndexerName match the one in
21032 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
21033 If a method is defined here, then we always need to create a proxy
21034 for it. This is used when implementing interface indexers.
21035 (Pending.IsInterfaceIndexer): New public method.
21036 (Pending.ImplementIndexer): New public method.
21037 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
21038 This is used when implementing interface indexers to define a proxy
21040 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
21041 define a proxy if necessary.
21043 * interface.cs (Interface.IndexerName): New public variable.
21044 (Interface.PopulateIndexer): Set the IndexerName.
21045 (Interface.DefineIndexers): New private method. Populate all the
21046 indexers and make sure their IndexerNames match.
21048 * typemanager.cs (IndexerPropertyName): Added support for interface
21051 2002-07-22 Martin Baulig <martin@gnome.org>
21053 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
21054 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
21055 ret if HasReturnLabel.
21056 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
21059 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
21060 and set the ec.LoopBeginTryCatchLevel.
21061 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
21062 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
21063 the current ec.TryCatchLevel, the branch goes out of an exception
21064 block. In this case, we need to use Leave and not Br.
21066 2002-07-22 Martin Baulig <martin@gnome.org>
21068 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
21069 block unless the block does not always return or it is contained in
21070 another try { ... } catch { ... } block. Fixes bug #26506.
21071 Added verify-1.cs to the test suite.
21073 2002-07-22 Martin Baulig <martin@gnome.org>
21075 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
21076 then we do not always return. Fixes bug #24985.
21078 2002-07-22 Martin Baulig <martin@gnome.org>
21080 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
21081 lookup on a per-class level; ie. walk up the class hierarchy until we
21082 found at least one applicable method, then choose the best among them.
21083 Fixes bug #24463 and test-29.cs.
21085 2002-07-22 Martin Baulig <martin@gnome.org>
21087 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
21088 return types of the methods. The return type is not part of the
21089 signature and we must not check it to make the `new' modifier work.
21090 Fixes bug #27999, also added test-147.cs.
21091 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
21093 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
21094 on the method's return type.
21096 2002-07-21 Martin Baulig <martin@gnome.org>
21098 * assign.cs: Make this work if the rightmost source is a constant and
21099 we need to do an implicit type conversion. Also adding a few more tests
21100 to test-38.cs which should have caught this.
21102 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
21103 target in the makefile for this. The makefile.gnu is primarily intended
21104 for end-users who don't want to debug the compiler.
21106 2002-07-21 Martin Baulig <martin@gnome.org>
21108 * assign.cs: Improved the Assign class so it can now handle embedded
21109 assignments (X = Y = Z = something). As a side-effect this'll now also
21110 consume less local variables. test-38.cs now passes with MCS, added
21111 a few new test cases to that test.
21113 2002-07-20 Martin Baulig <martin@gnome.org>
21115 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
21116 instructions. Fixes bug #27977, also added test-146.cs.
21118 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21120 * cs-tokenizer.cs: fixed getHex ().
21122 2002-07-19 Martin Baulig <martin@gnome.org>
21124 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
21125 not Type.GetType() to lookup the array type. This is needed when
21126 we're constructing an array of a user-defined type.
21127 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
21128 single-dimensional arrays, but also for single-dimensial arrays of
21131 2002-07-19 Martin Baulig <martin@gnome.org>
21133 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
21134 this function is called, it's not allowed to share LocalBuilders
21135 among ILGenerators.
21137 2002-07-19 Martin Baulig <martin@gnome.org>
21139 * expression.cs (Argument.Resolve): Report an error 118 when trying
21140 to pass a type as argument.
21142 2002-07-18 Martin Baulig <martin@gnome.org>
21144 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
21145 Conv_R_Un for the signed `long' type.
21147 2002-07-15 Miguel de Icaza <miguel@ximian.com>
21149 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
21150 `expr' for the temporary result, as that will fail if we do
21151 multiple resolves on the same expression.
21153 2002-07-05 Miguel de Icaza <miguel@ximian.com>
21155 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
21156 ec.TypeContainer for looking up aliases.
21158 * class.cs (TypeContainer): Remove LookupAlias from here.
21160 * decl.cs (DeclSpace); Move here.
21162 2002-07-01 Miguel de Icaza <miguel@ximian.com>
21164 * class.cs (FindMembers): Only call filter if the constructor
21165 bulider is not null.
21167 Also handle delegates in `NestedTypes' now. Now we will perform
21168 type lookups using the standard resolution process. This also
21171 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
21172 This uses Expressions (the limited kind that can be parsed by the
21173 tree) instead of strings.
21175 * expression.cs (ComposedCast.ToString): Implement, used to flag
21176 errors since now we have to render expressions.
21178 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
21181 * ecore.cs (SimpleName.ToString): ditto.
21183 * cs-parser.jay: Instead of using strings to assemble types, use
21184 Expressions to assemble the type (using SimpleName, ComposedCast,
21185 MemberAccess). This should fix the type lookups in declarations,
21186 because we were using a different code path for this.
21188 * statement.cs (Block.Resolve): Continue processing statements
21189 even when there is an error.
21191 2002-07-17 Miguel de Icaza <miguel@ximian.com>
21193 * class.cs (Event.Define): Also remove the `remove' method from
21194 the list of pending items.
21196 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
21197 generate more compact code.
21199 2002-07-17 Martin Baulig <martin@gnome.org>
21201 * const.cs (Const.LookupConstantValue): Add support for constant
21202 `unchecked' and `checked' expressions.
21203 Also adding test case test-140.cs for this.
21205 2002-07-17 Martin Baulig <martin@gnome.org>
21207 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
21208 check whether mi.ReturnType implements the IEnumerator interface; the
21209 `==' and the IsAssignableFrom() will fail in this situation.
21211 2002-07-16 Ravi Pratap <ravi@ximian.com>
21213 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
21216 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21218 * expression.cs: fixed bug #27811.
21220 2002-07-14 Miguel de Icaza <miguel@ximian.com>
21222 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
21223 Molaro: when we are a ref, the value already contains a pointer
21224 value, do not take the address of it.
21226 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21227 * removed mb-parser.jay and mb-tokenizer.cs
21229 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21231 * expression.cs: check against the building corlib void type.
21233 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
21235 * ecore.cs: fix for valuetype static readonly fields: when
21236 initializing them, we need their address, not the address of a copy.
21238 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
21240 * typemanager.cs: register also enum_type in corlib.
21242 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21244 * class.cs: allow calling this (but not base) initializers in structs.
21246 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
21248 * ecore.cs: make sure we compare against the building base types
21251 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
21253 * typemanager.cs: fix TypeToCoreType() to handle void and object
21254 (corlib gets no more typerefs after this change).
21256 2002-07-12 Miguel de Icaza <miguel@ximian.com>
21258 * expression.cs (ArrayCreation.EmitArrayArguments): use
21259 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
21261 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
21262 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
21263 array indexes, the runtime actually forbids them.
21265 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
21266 for array arguments here.
21268 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
21269 instead of the default for ValueTypes.
21271 (New.DoEmit): Use IsValueType instead of
21272 IsSubclassOf (value_type)
21273 (New.DoResolve): ditto.
21274 (Invocation.EmitCall): ditto.
21276 * assign.cs (Assign): ditto.
21278 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
21279 Statements *are* currently doing part of their resolution during
21282 Expressions do always resolve during resolve, but statements are
21283 only required to propagate resolution to their children.
21285 2002-07-11 Miguel de Icaza <miguel@ximian.com>
21287 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
21289 (LoadAssembly): Do not add the dll if it is already specified
21291 (MainDriver): Add the System directory to the link path at the end,
21292 after all the other -L arguments.
21294 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
21295 wrong opcode for loading bytes and bools (ldelem.i1 instead of
21296 ldelem.u1) and using the opposite for sbytes.
21298 This fixes Digger, and we can finally run it.
21300 * driver.cs (UnixParseOption): Move the option parsing here.
21301 (CSCParseOption): Implement CSC-like parsing of options.
21303 We now support both modes of operation, the old Unix way, and the
21304 new CSC-like way. This should help those who wanted to make cross
21305 platform makefiles.
21307 The only thing broken is that /r:, /reference: and /lib: are not
21308 implemented, because I want to make those have the same semantics
21309 as the CSC compiler has, and kill once and for all the confussion
21310 around this. Will be doing this tomorrow.
21312 * statement.cs (Unsafe.Resolve): The state is checked during
21313 resolve, not emit, so we have to set the flags for IsUnsfe here.
21315 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21317 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
21318 not catch the Error_ObjectRefRequired in SimpleName (as it is
21319 possible to have a class/instance variable name that later gets
21320 deambiguated), we have to check this here.
21322 2002-07-10 Ravi Pratap <ravi@ximian.com>
21324 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
21325 make static and put into Expression.
21327 (Event.Define): Register the private field of the event with the
21328 TypeManager so that GetFieldFromEvent can get at it.
21330 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
21331 keep track of the private field associated with an event which
21334 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
21337 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
21339 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21341 * expression.cs (Binary.EmitBranchable): this routine emits the
21342 Binary expression in a branchable context. This basically means:
21343 we need to branch somewhere, not just get the value on the stack.
21345 This works together with Statement.EmitBoolExpression.
21347 * statement.cs (Statement.EmitBoolExpression): Use
21350 2002-07-09 Miguel de Icaza <miguel@ximian.com>
21352 * statement.cs (For): Reduce the number of jumps in loops.
21354 (For): Implement loop inversion for the For statement.
21356 (Break): We can be breaking out of a Try/Catch controlled section
21357 (foreach might have an implicit try/catch clause), so we need to
21358 use Leave instead of Br.
21360 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
21361 now). If the instace expression supports IMemoryLocation, we use
21362 the AddressOf method from the IMemoryLocation to extract the
21363 address instead of emitting the instance.
21365 This showed up with `This', as we were emitting the instance
21366 always (Emit) instead of the Address of This. Particularly
21367 interesting when This is a value type, as we dont want the Emit
21368 effect (which was to load the object).
21370 2002-07-08 Miguel de Icaza <miguel@ximian.com>
21372 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
21374 * statement.cs (Checked): Set the CheckedState during the resolve
21375 process too, as the ConvCast operations track the checked state on
21376 the resolve process, and not emit.
21378 * cs-parser.jay (namespace_member_declaration): Flag that we have
21379 found a declaration when we do. This is used to flag error 1529
21381 * driver.cs: Report ok when we display the help only.
21383 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
21385 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
21387 2002-07-04 Miguel de Icaza <miguel@ximian.com>
21389 * cs-tokenizer.cs (define): We also have to track locally the
21390 defines. AllDefines is just used for the Conditional Attribute,
21391 but we also need the local defines for the current source code.
21393 2002-07-03 Miguel de Icaza <miguel@ximian.com>
21395 * statement.cs (While, For, Do): These loops can exit through a
21396 Break statement, use this information to tell whether the
21397 statement is the last piece of code.
21399 (Break): Flag that we break.
21401 * codegen.cs (EmitContexts): New `Breaks' state variable.
21403 2002-07-03 Martin Baulig <martin@gnome.org>
21405 * class.cs (TypeContainer.MethodModifiersValid): Allow override
21406 modifiers in method declarations in structs. Otherwise, you won't
21407 be able to override things like Object.Equals().
21409 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21411 * class.cs (Method, Property, Indexer): Do not allow the public
21412 modifier to be used in explicit interface implementations.
21414 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
21415 override modifiers in method declarations in structs
21417 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
21419 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
21420 integer or real overflow, report an error
21422 2002-07-02 Martin Baulig <martin@gnome.org>
21424 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
21425 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
21426 to tell the runtime about our newly created System.Object and
21427 System.ValueType types.
21429 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21431 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
21432 struct instead of Ldarg/Starg.
21434 2002-07-02 Martin Baulig <martin@gnome.org>
21436 * expression.cs (Indirection.Indirection): Call
21437 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
21439 2002-07-02 Martin Baulig <martin@gnome.org>
21441 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
21442 ValueType, call TypeManager.TypeToCoreType() on it.
21443 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
21444 the OpCodes.Newarr argument.
21446 2002-07-02 Martin Baulig <martin@gnome.org>
21448 * expression.cs (Invocation.EmitCall): When compiling corlib,
21449 replace all calls to the system's System.Array type to calls to
21450 the newly created one.
21452 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21453 System.Array methods.
21454 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21455 from the system's System.Array type which must be replaced.
21457 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21459 * typemanager.cs: load unverifiable_code_ctor so we can build
21460 corlib using the correct type. Avoid using GetTypeCode() with
21462 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21463 TypeManager.object_type to allow building corlib.
21465 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21467 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21469 2002-07-01 Martin Baulig <martin@gnome.org>
21471 * class.cs: Make the last change actually work, we need to check
21472 whether `ifaces != null' to avoid a crash.
21474 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21476 * class.cs: when we build structs without fields that implement
21477 interfaces, we need to add the interfaces separately, since there is
21478 no API to both set the size and add the interfaces at type creation
21481 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21483 * expression.cs: the dimension arguments to the array constructors
21484 need to be converted if they are a long.
21486 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21488 * class.cs: don't emit ldarg.0 if there is no parent constructor
21489 (fixes showstopper for corlib).
21491 2002-06-29 Martin Baulig <martin@gnome.org>
21493 MCS now compiles corlib on GNU/Linux :-)
21495 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21496 ie. check for MethodImplOptions.InternalCall.
21498 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21499 and TypeManager.attribute_type are null, so we must explicitly check
21500 whether parent is not null to find out whether it's an attribute type.
21501 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21502 and SetBuilder, not only if the property is neither abstract nor external.
21503 This is necessary to set the MethodImplOptions on the accessor methods.
21504 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21505 SetBuilder, see Property.Emit().
21507 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21508 populate "System.Object", "System.ValueType" and "System.Attribute" since
21509 they've already been populated from BootCorlib_PopulateCoreTypes().
21511 2002-06-29 Martin Baulig <martin@gnome.org>
21513 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21514 is the NullLiteral, we also need to make sure that target_type is not
21517 2002-06-29 Martin Baulig <martin@gnome.org>
21519 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21520 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21521 before calling BootstrapCorlib_ResolveDelegate ().
21523 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21525 * statement.cs: fixed build-breaker. All tests passed ok.
21527 2002-06-27 Martin Baulig <martin@gnome.org>
21529 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21530 for System.Decimal when compiling corlib.
21532 2002-06-27 Martin Baulig <martin@gnome.org>
21534 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21535 switch blocks which contain nothing but a default clause.
21537 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21539 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21541 2002-06-27 Martin Baulig <martin@gnome.org>
21543 * ecore.cs (PropertyExpr.PropertyExpr): Call
21544 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21546 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21547 is already a TypeBuilder.
21549 2002-06-27 Martin Baulig <martin@gnome.org>
21551 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21552 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21553 the "from an array-type to System.Array" case. This makes it work
21554 when compiling corlib.
21556 2002-06-27 Martin Baulig <martin@gnome.org>
21558 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21559 non-static PropertyExpr, set its InstanceExpression. This makes
21560 the `ICollection.Count' property work in System/Array.cs.
21562 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21564 * driver.cs: Made error handling more consistent. Errors now
21565 tracked by Report class, so many methods which used to return int
21566 now return void. Main() now prints success/failure and
21567 errors/warnings message.
21569 Renamed '--probe' compiler argument to '--expect-error'. Removed
21570 the magic number return values (123 and 124). Now, if the
21571 expected error occurs, the compiler exits with success (exit value
21572 0). If the compilation completes without seeing that particular
21573 error, the compiler exits with failure (exit value 1). The
21574 makefile in mcs/errors has been changed to handle the new behaviour.
21576 * report.cs: Made 'expected error' number a property and renamed
21577 it from 'Probe' to 'ExpectedError'.
21579 * genericparser.cs: Removed error handling support, since it is
21580 now all done by Report class.
21582 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
21583 class, so parse() no longer returns an int.
21585 * namespace.cs: Use Report.Error instead of GenericParser.error
21587 2002-06-22 Miguel de Icaza <miguel@ximian.com>
21589 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
21590 TypeContainer.AddOperator): At the front of the list put the
21591 explicit implementations, so they get resolved/defined first.
21593 2002-06-21 Miguel de Icaza <miguel@ximian.com>
21595 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
21596 interface type is implemented by this TypeContainer. Used during
21597 explicit interface implementation.
21599 (Property.Define, Indexer.Define, Method.Define): Validate that
21600 the given interface in the explicit implementation is one of the
21601 base classes for the containing type.
21603 Also if we are explicitly implementing an interface, but there is
21604 no match in the pending implementation table, report an error.
21606 (Property.Define): Only define the property if we are
21607 not explicitly implementing a property from an interface. Use the
21608 correct name also for those properties (the same CSC uses,
21609 although that is really not needed).
21611 (Property.Emit): Do not emit attributes for explicitly implemented
21612 properties, as there is no TypeBuilder.
21614 (Indexer.Emit): ditto.
21616 Hiding then means that we do not really *implement* a pending
21617 implementation, which makes code fail.
21619 2002-06-22 Martin Baulig <martin@gnome.org>
21621 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
21622 the return value of Object.GetType(). [FIXME: we need to do this whenever
21623 we get a type back from the reflection library].
21625 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
21627 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
21629 2002-06-20 Miguel de Icaza <miguel@ximian.com>
21631 * attribute.cs: Return null if we can not look up the type.
21633 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
21634 the interface types found.
21636 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
21637 interface types found.
21639 * typemanager.cs (GetInterfaces): Make this routine returns alll
21640 the interfaces and work around the lame differences between
21641 System.Type and System.Reflection.Emit.TypeBuilder in the results
21642 result for GetInterfaces.
21644 (ExpandInterfaces): Given an array of interface types, expand and
21645 eliminate repeated ocurrences of an interface. This expands in
21646 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
21649 2002-06-21 Martin Baulig <martin@gnome.org>
21651 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
21654 2002-06-21 Martin Baulig <martin@gnome.org>
21656 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
21657 and called with one of the core types, return the corresponding typebuilder for
21660 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
21663 2002-06-21 Martin Baulig <martin@gnome.org>
21665 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
21666 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
21667 (Expression.ConvertReferenceExplicit): Likewise.
21669 * expression.cs (ElementAccess.DoResolve): Likewise.
21670 (ElementAccess.DoResolveLValue): Likewise.
21672 2002-06-10 Martin Baulig <martin@gnome.org>
21674 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
21675 add the "value" parameter to the parameter list.
21677 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
21680 2002-06-19 Miguel de Icaza <miguel@ximian.com>
21682 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
21683 the argument to an int, uint, long or ulong, per the spec. Also
21684 catch negative constants in array creation.
21686 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
21688 * class.cs: do not allow the same interface to appear twice in
21689 the definition list.
21691 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
21693 * ecore.cs: don't use ldlen with System.Array.
21695 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
21697 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
21699 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
21701 * modifiers.cs: produce correct field attributes for protected
21702 internal. Easy fix so miguel can work on ther harder stuff:-)
21704 2002-06-18 Miguel de Icaza <miguel@ximian.com>
21706 * pending.cs: New file. Move the code from class.cs here.
21707 Support clearning the pending flag for all methods (when not doing
21708 explicit interface implementation).
21710 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
21712 * rootcontext.cs: added a couple more types needed to bootstrap.
21714 2002-06-17 Miguel de Icaza <miguel@ximian.com>
21716 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
21717 constructor in the type, instead of any constructor in the type
21718 hierarchy. Thanks to Paolo for finding this bug (it showed up as
21719 a bug in the Mono runtime when applying the params attribute).
21721 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21722 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
21724 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
21726 * expression.cs (Unary.ResolveOperator): Use TypeManager
21727 to resolve the type.
21729 2002-06-13 Ravi Pratap <ravi@ximian.com>
21731 * cs-parser.jay (enum_member_declaration): Pass in the attributes
21734 * enum.cs (AddEnumMember): Add support to store the attributes associated
21735 with each member too.
21737 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
21738 field builders too - this takes care of the enum member case.
21740 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
21742 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
21743 address-of operator on both value types and pointers.
21745 2002-06-10 Martin Baulig <martin@gnome.org>
21747 * interface.cs (Interface.PopulateIndexer): Add the indexer's
21748 PropertyBuilder to the `property_builders' list.
21750 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
21751 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
21752 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
21753 find any indexers which are inherited from an interface.
21755 2002-06-09 Martin Baulig <martin@gnome.org>
21757 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
21758 the same type as the constant if necessary. There's also a test-130.cs
21761 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
21763 * typemanager.cs (TypeManager.ChangeType): Previously known as
21764 Enum.ChangeEnumType().
21766 2002-06-09 Martin Baulig <martin@gnome.org>
21768 * expression.cs (Cast.TryReduce): Added support for consts.
21770 2002-06-08 Ravi Pratap <ravi@ximian.com>
21772 * class.cs (Accessor): Hold attributes information so we can pass
21775 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
21776 Modify to pass in attributes attached to the methods.
21778 (add_accessor_declaration, remove_accessor_declaration): Ditto.
21780 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
21781 to handle the Accessor kind :-)
21783 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
21785 2002-06-08 Martin Baulig <martin@gnome.org>
21787 * expression.cs (Unary.TryReduceNegative): Added support for
21790 2002-06-08 Martin Baulig <martin@gnome.org>
21792 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
21793 name can't be found in the `defined_names' - the caller will do a
21794 MemberLookup in this case and thus find methods in System.Enum
21795 such as Enum.IsDefined().
21797 2002-06-08 Martin Baulig <martin@gnome.org>
21799 * enum.cs (Enum.ChangeEnumType): This is a custom version of
21800 Convert.ChangeType() which works with TypeBuilder created types.
21801 (Enum.LookupEnumValue, Enum.Define): Use it here.
21803 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
21804 `TypeBuilder.BaseType != null' check.
21805 (TypeContainer.FindMembers): Only lookup parent members if we
21806 actually have a parent.
21807 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
21808 (ConstructorInitializer.Resolve): Likewise.
21810 * interface.cs (Interface.FindMembers): Added
21811 `TypeBuilder.BaseType != null' check.
21813 * rootcontext.cs (RootContext.ResolveCore): Added
21814 "System.Runtime.CompilerServices.IndexerNameAttribute" to
21815 classes_second_stage.
21817 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
21818 debug_type and trace_type when compiling with --nostdlib.
21820 2002-06-07 Martin Baulig <martin@gnome.org>
21822 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
21823 (AddField): Set it to true when adding a non-static field.
21824 (DefineType): Use `have_nonstatic_fields' to find out whether we
21825 have non-static fields, not `Fields != null'.
21827 2002-06-02 Miguel de Icaza <miguel@ximian.com>
21829 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
21830 dereferencing a null on the static-field code path)
21832 2002-05-30 Martin Baulig <martin@gnome.org>
21834 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
21835 to take command line arguments. Use reflection to call the new
21836 custom `Initialize' function on the symbol writer and pass it the
21837 command line arguments.
21839 * driver.cs (--debug-args): New command line argument to pass command
21840 line arguments to the symbol writer.
21842 2002-05-28 Miguel de Icaza <miguel@ximian.com>
21844 * assign.cs (DoResolve): Forgot to do the implicit conversion to
21845 the target type for indexers and properties. Thanks to Joe for
21848 2002-05-27 Miguel de Icaza <miguel@ximian.com>
21850 * typemanager.cs (MethodFlags): returns the method flags
21851 (Obsolete/ShouldIgnore) that control warning emission and whether
21852 the invocation should be made, or ignored.
21854 * expression.cs (Invocation.Emit): Remove previous hack, we should
21855 not do this on matching a base type, we should do this based on an attribute
21857 Only emit calls to System.Diagnostics.Debug and
21858 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
21859 on the command line.
21861 * rootcontext.cs: Global settings for tracing and debugging.
21863 * cs-tokenizer.cs (define): New utility function to track
21864 defines. Set the global settings for TRACE and DEBUG if found.
21866 2002-05-25 Ravi Pratap <ravi@ximian.com>
21868 * interface.cs (Populate*): Pass in the TypeContainer as well as
21869 the DeclSpace as parameters so that we can create EmitContexts and
21870 then use that to apply attributes etc.
21872 (PopulateMethod, PopulateEvent, PopulateProperty)
21873 (PopulateIndexer): Apply attributes everywhere.
21875 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
21878 (ApplyAttributes): Update accordingly.
21880 We now apply interface attributes for all members too.
21882 2002-05-26 Miguel de Icaza <miguel@ximian.com>
21884 * class.cs (Indexer.Define); Correctly check if we are explicit
21885 implementation (instead of checking the Name for a ".", we
21886 directly look up if the InterfaceType was specified).
21888 Delay the creation of the PropertyBuilder.
21890 Only create the PropertyBuilder if we are not an explicit
21891 interface implementation. This means that explicit interface
21892 implementation members do not participate in regular function
21893 lookups, and hence fixes another major ambiguity problem in
21894 overload resolution (that was the visible effect).
21896 (DefineMethod): Return whether we are doing an interface
21899 * typemanager.cs: Temporary hack until we get attributes in
21900 interfaces (Ravi is working on that) and we get IndexerName
21901 support in interfaces.
21903 * interface.cs: Register the indexers as properties.
21905 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
21906 warning, I have verified that this is a bug in the .NET runtime
21907 (JavaScript suffers of the same problem).
21909 * typemanager.cs (MemberLookup): When looking up members for
21910 interfaces, the parent of an interface is the implicit
21911 System.Object (so we succeed in searches of Object methods in an
21912 interface method invocation. Example: IEnumerable x; x.ToString
21915 2002-05-25 Miguel de Icaza <miguel@ximian.com>
21917 * class.cs (Event): Events should also register if they do
21918 implement the methods that an interface requires.
21920 * typemanager.cs (MemberLookup); use the new GetInterfaces
21923 (GetInterfaces): The code used to lookup interfaces for a type is
21924 used in more than one place, factor it here.
21926 * driver.cs: Track the errors at the bottom of the file, we kept
21929 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
21930 instance if the method we are calling is static!
21932 2002-05-24 Miguel de Icaza <miguel@ximian.com>
21934 * attribute.cs (ApplyAttributes): Make this function filter out
21935 the IndexerName attribute (as that attribute in reality is never
21936 applied) and return the string constant for the IndexerName
21939 * class.cs (TypeContainer.Emit): Validate that all the indexers
21940 have the same IndexerName attribute, and if so, set the
21941 DefaultName attribute on the class.
21943 * typemanager.cs: The return value might contain other stuff (not
21944 only methods). For instance, consider a method with an "Item"
21945 property and an Item method.
21947 * class.cs: If there is a problem with the parameter types,
21950 2002-05-24 Ravi Pratap <ravi@ximian.com>
21952 * ecore.cs (ImplicitConversionExists): Wrapper function which also
21953 looks at user defined conversion after making a call to
21954 StandardConversionExists - we need this for overload resolution.
21956 * expression.cs : Update accordingly the various method calls.
21958 This fixes 2 bugs filed against implicit user defined conversions
21960 2002-05-22 Miguel de Icaza <miguel@ximian.com>
21962 * statement.cs: Track the result of the assignment.
21964 2002-05-21 Miguel de Icaza <miguel@ximian.com>
21966 * expression.cs (MemberAccess): Improved error reporting for
21967 inaccessible members.
21969 2002-05-22 Martin Baulig <martin@gnome.org>
21971 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
21972 itself with debugging support.
21974 2002-05-22 Martin Baulig <martin@gnome.org>
21976 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
21977 Removed, this isn't needed anymore.
21979 2002-05-20 Martin Baulig <martin@gnome.org>
21981 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
21982 be underlying type for an enum.
21984 2002-05-20 Miguel de Icaza <miguel@ximian.com>
21986 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
21987 that splits out the loading of just the core types.
21989 * rootcontext.cs (ResolveCore): Split the struct resolution in
21990 two, so we can load the enumeration underlying types before any
21993 * expression.cs (Is): Bandaid until we fix properly Switch (see
21994 bug #24985 for details).
21996 * typemanager.cs (ImplementsInterface): The hashtable will contain
21997 a null if there are no interfaces implemented.
21999 2002-05-18 Miguel de Icaza <miguel@ximian.com>
22001 * cs-parser.jay (indexer_declarator): It is fine to have array
22004 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22006 * typemanager.cs: (RegisterBuilder): New function used to register
22007 TypeBuilders that implement interfaces. Since
22008 TypeBuilder.GetInterfaces (as usual) does not work with lame
22010 (AddUserType): register interfaces.
22012 (ImplementsInterface): Use the builder_to_ifaces hash if we are
22013 dealing with TypeBuilder. Also, arrays are showing up as
22014 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
22015 methods can not be invoked on them!
22017 * ecore.cs (ExplicitReferenceConversionExists): Made public.
22018 (ImplicitReferenceConversionExists): Split out from
22019 StandardConversionExists.
22021 * expression.cs (As): We were only implementing one of the three
22022 cases for the as operator. We now implement them all.
22023 (Is): Implement the various other cases for Is as well.
22025 * typemanager.cs (CACHE): New define used to control if we want or
22026 not the FindMembers cache. Seems to have a negative impact on
22027 performance currently
22029 (MemberLookup): Nested types have full acess to
22030 enclosing type members
22032 Remove code that coped with instance/static returns for events, we
22033 now catch this in RealFindMembers.
22035 (RealFindMembers): only perform static lookup if the instance
22036 lookup did not return a type or an event.
22038 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22040 * assign.cs (CompoundAssign): We pass more semantic information
22041 now to Compound Assignments than we did before: now we have all
22042 the information at hand, and now we resolve the target *before* we
22043 do the expression expansion, which allows the "CacheValue" method
22044 to have the effect we intended (before, a [x] += 1 would generate
22045 two differen ArrayAccess expressions from the ElementAccess,
22046 during the resolution process).
22048 (CompoundAssign.DoResolve): Resolve target and original_source here.
22050 2002-05-16 Miguel de Icaza <miguel@ximian.com>
22052 * expression.cs (ArrayAccess): dropped debugging information.
22054 * typemanager.cs: Small bug fix: I was always returning i_members,
22055 instead of one of i_members or s_members (depending on which had
22058 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
22059 method is invoked before any code generation takes place, and it
22060 is a mechanism to inform that the expression will be invoked more
22061 than once, and that the method should use temporary values to
22062 avoid having side effects
22064 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
22066 * ecore.cs (Expression.CacheTemporaries): Provide empty default
22069 * expression.cs (Indirection, ArrayAccess): Add support for
22070 CacheTemporaries in these two bad boys.
22072 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
22073 ldobj or ldind_ref.
22074 (StoreFromPtr): Handle stobj as well.
22076 * expression.cs (UnaryMutator): Share more code.
22078 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
22079 down: I was not tracking the Filter function as well, which
22080 was affecting the results of the cache.
22082 2002-05-15 Miguel de Icaza <miguel@ximian.com>
22084 * attribute.cs: Remove the hack to handle the CharSet property on
22087 2002-05-14 Miguel de Icaza <miguel@ximian.com>
22089 * attribute.cs (DoResolve): More uglyness, we now only try to
22090 resolve the attribute partially, to extract the CharSet
22091 information (only if we are a StructLayout attribute). Otherwise
22093 (GetExtraTypeInfo): Add some code to conditionally kill in the
22094 future this. I am more and more convinced that the .NET
22095 framework has special code to handle the attribute setting on
22098 * expression.cs (IsParamsMethodApplicable): Revert my previous
22099 foreach change here, it was wrong.
22101 2002-05-13 Miguel de Icaza <miguel@ximian.com>
22103 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
22104 (pp_expr): do not abort on unknown input, just return.
22105 (eval): abort if there are pending chars.
22107 * attribute.cs (Attribute.Resolve): Positional parameters are
22108 optional. Deal with that case.
22110 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
22111 the Ansi/Unicode/Auto information for the type.
22113 (TypeContainer.DefineType): instantiate the EmitContext here, as
22114 we will be using it during the type definition (to resolve
22115 attributes) and during the emit phase.
22117 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
22118 to pull type information out of the attributes
22120 (Attribute.Resolve): track the constructor builder, and allow for
22121 multiple invocations (structs and classes will use this).
22123 * ecore.cs (MemberLookupFinal): new version with all the
22124 parameters customizable.
22126 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
22127 constructors. Return if the result value is null (as the error
22128 would have been flagged already by MemberLookupFinal)
22130 Do not allow instances of abstract classes or interfaces to be
22133 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
22134 We have to compare the assembly property here when dealing with
22135 FamANDAssem and Assembly access modifiers, because we might be
22136 creating an assembly from *modules* (that means that we are not
22137 getting TypeBuilders for types defined in other modules that are
22138 part of this assembly).
22140 (Method.Emit): If the method is marked abstract and has a body,
22143 (TypeContainer.DefineMembers): If both the defined member and the
22144 parent name match are methods, then do not emit any warnings: let
22145 the Method.Define routine take care of flagging warnings. But if
22146 there is a mismatch (method overrides something else, or method is
22147 overriwritten by something, then emit warning).
22149 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
22150 set to null, this means `do not check for the return type on the
22153 (Method.Define): set the return type for the method signature to
22154 null, so that we get methods with the same name and parameters and
22155 different return types. This is used to flag warning 114 (you are
22156 hiding a method, and you probably want to use the new/override
22159 * typemanager.cs (MemberLookup): Implemented proper access
22160 control, closing a long standing set of bug reports. The problem
22161 was that the Framework only has two bits: Public and NonPublic,
22162 and NonPublic includes private and protected methods, but we need
22163 to enforce the FamANDAssem, FamOrAssem and Family.
22165 2002-05-11 Miguel de Icaza <miguel@ximian.com>
22167 * statement.cs (GotoCase): Return true: Ammounts to giving up
22168 knowledge on whether we return or not, and letting the other case
22169 be responsible for it.
22171 2002-05-10 Miguel de Icaza <miguel@ximian.com>
22173 * driver.cs: Do not load directories for each file processed, only
22174 do it if there is a pattern.
22176 * ecore.cs: Report readonly assigns here as well, as we might have
22177 been resolved only by MemberAccess.
22179 (SimpleName.SimpleNameResolve): Also be useful for LValue
22180 resolution. We need this to propagate assign to local readonly variables
22182 * typemanager.cs: Use a ptrhashtable for the criteria, because we
22183 do not want to reuse potential criteria memory.
22185 * class.cs (MyEventBuilder): Set reflected_type;
22187 * ecore.cs (Constantify): Added support for constifying bools.
22189 (RootContext.LookupType): Added a cache for values looked up in
22190 the declaration space.
22192 * typemanager.cs (FindMembers): Now is a front-end to
22193 RealFindMembers, and provides a two-level hashtable-based cache to
22196 15% performance improvement: from 22.5 to 19.2 seconds.
22198 * expression.cs (IsParamsMethodApplicable): use foreach.
22199 (Invocation.DoResolve): ditto.
22200 (New.DoResolve): ditto.
22201 (ArrayCreation.DoResolve): ditto.
22203 * ecore.cs (FindMostEncompassingType): use foreach.
22205 * delegate.cs (NewDelegate.DoResolve): Use foreach
22207 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
22208 (RemoveMethods): use foreach.
22210 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
22211 nested foreach statements instead of for, and also break out of
22212 the inner loop once a match is found.
22214 (Invocation.OverloadResolve): Use foreach, simplify the code.
22216 2002-05-08 Miguel de Icaza <miguel@ximian.com>
22218 * cfold.cs (BinaryFold): During an enumeration evaluation context,
22219 we actually unwrap the expression to allow for extra information
22222 * expression.cs: Use Shr_Un on unsigned operations.
22224 2002-05-08 Ravi Pratap <ravi@ximian.com>
22226 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
22227 applicable operators was not being considered correctly. This closes
22228 the bug Miguel reported.
22230 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
22232 * attribute.cs: check that the type derives from System.Attribute
22233 and report the correct error in that case (moved the duplicate code to
22234 its own method, too).
22236 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
22238 * attribute.cs: lookup attribute type name as the spec says: first the
22239 bare attribute name and then name + "Attribute" (nant compiles with
22240 mcs after this fix).
22242 2002-05-07 Miguel de Icaza <miguel@ximian.com>
22244 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
22245 Because of the way we parse things, we should try to see if a
22246 UIntConstant can fit in an integer.
22248 2002-05-07 Ravi Pratap <ravi@ximian.com>
22250 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
22251 when we are in an explicit context.
22253 (ConvertReferenceExplicit): When converting from Iface type S to Class
22254 T make sure the rules are implemented as an OR.
22256 * parameter.cs (ParameterType): Make it a property for now although the
22257 purpose really isn't anything immediate.
22259 * expression.cs (Is*Applicable): Do better checking on the parameter type
22260 of a ref/out parameter. The ones from the system assemblies are already
22261 marked with the correct type so we don't need to do any correction.
22263 * ecore.cs (StandardConversionExists): Conversion from Interface types to
22264 the object type is standard too so include that.
22266 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22268 * ecore.cs (StandardConversionExists): Augment with missing code:
22269 deal with IntConstant, LongConstants and Enumerations.
22271 * assign.cs: Report the error, instead of failing silently
22273 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
22274 typecontainer that they are declared, because the
22275 typecontainer/namespace will have the list of using clauses that
22276 need to be applied.
22278 Assembly Attributes were escaping the normal registration
22281 (EmitCode): Apply attributes within an EmitContext that represents
22282 the container they were declared on.
22284 * cs-parser.jay: Track bases for structs. How did I get this wrong?
22286 2002-05-06 Ravi Pratap <ravi@ximian.com>
22288 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
22289 Revamp completely - make much cleaner as we now operate only
22292 (FindMostSpecificSource, FindMostSpecificTarget): New methods
22293 to implement the logic detailed in the spec more correctly.
22295 (UserDefinedConversion): Update accordingly.
22297 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22299 * statement.cs: Return flow analysis information up.
22301 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
22304 (token): Do not consume an extra character before calling
22307 2002-05-06 Piers Haken <piersh@friskit.com>
22309 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
22311 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22313 * class.cs (Constructor.Emit): Set the IsStatic flag in the
22314 EmitContext during the instance constructor initializer
22315 resolution, to stop access to instance variables.
22317 This is mandated by the spec, last paragraph of the `constructor
22318 initializers' section.
22320 2002-05-05 Miguel de Icaza <miguel@ximian.com>
22322 * cs-parser.jay, class.cs (Accessor): new class used to represent
22323 an accessor (get or set). In the past we used `null' to represent
22324 a missing accessor. But this is ambiguous because there was no
22325 way to tell in abstract indexers/properties if one of them was
22328 Now there is a way of addressing that.
22330 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
22331 instead of FindMembers.
22333 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
22334 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
22336 * attribute.cs: Treat indexers and properties as the same in terms
22337 of applying attributes
22339 * ecore.cs (FindMostEncompassedType): Use statically initialized
22340 EmptyExpressions()s like we do elsewhere to avoid creating useless
22341 objects (and we take this out of the tight loop).
22343 (GetConversionOperators): Move the code to extract the actual
22344 operators to a separate routine to clean things up.
22346 2002-05-04 Miguel de Icaza <miguel@ximian.com>
22348 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
22349 events are always registered FieldBuilders.
22351 * class.cs (FieldBase): New class shared by Fields
22353 * delegate.cs: If we are a toplevel delegate, use our full name.
22354 If we are a nested delegate, then only use our tail name.
22356 2002-05-02 Ravi Pratap <ravi@ximian.com>
22358 * expression.cs (IsApplicable): Ensure that we add the "&" to
22359 ref/out types before comparing it with the type of the argument.
22361 (IsParamsMethodApplicable): Ditto.
22363 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
22366 * delegate.cs : Handle the case when we have more than one applicable
22367 method. Flag an error only when we finish checking all.
22369 2002-05-02 Miguel de Icaza <miguel@ximian.com>
22371 * expression.cs: Add support for boolean static initializers.
22373 2002-05-01 Miguel de Icaza <miguel@ximian.com>
22375 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
22377 * parameter.cs (ComputeParameterTypes,
22378 ComputeAndDefineParameterTypes): Better error handling: now we
22379 clear the `types' cache if we fail during any of the type lookups.
22380 We also return the status code correctly to our caller
22382 * delegate.cs: If we fail to define a delegate, abort the extra
22385 * expression.cs (Binary.ResolveOperator): for
22386 operator==(object,object) and operator !=(object, object) we also
22387 have to verify that there is an implicit conversion from one to
22390 (ArrayAccess.DoResolve): Array Access can operate on
22393 2002-04-30 Miguel de Icaza <miguel@ximian.com>
22395 * assign.cs (CompoundAssign): A new class used as a "flag" that
22396 the assignment actually is happening as part of a compound
22397 assignment operator.
22399 During compound assignment, a few new rules exist to enable things
22406 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
22407 to the type of x) if y is implicitly convertible to the type of x,
22408 and the operator is a builtin operator and the return type of the
22409 operator is explicitly convertible to the type of x.
22411 * rootcontext.cs: Reset warning level to 2. 4 catches various
22412 "interesting" features in mcs, we must clean this up at some
22413 point, but currently am trying to kill other bugs ;-)
22415 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
22416 in container classes as well.
22418 * expression.cs (Binary.ResolveOperator): Handle string case
22419 before anything else (as operator overloading does emit an error
22420 before doing anything else).
22422 This code could go away when we move to a table driven model, but
22423 i could not come up with a good plan last night.
22425 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
22427 * typemanager.cs (CSharpName): reimplementation using regex.
22428 * class.cs: added null check for fields in Emit
22429 * rootcontext.cs: set warninglevel to 4
22431 2002-04-29 Miguel de Icaza <miguel@ximian.com>
22433 * typemanager.cs (CSharpName): reimplemented with Lupus
22436 2002-04-28 Miguel de Icaza <miguel@ximian.com>
22438 * statement.cs (If): correclty implement Resolve, because we were
22439 not catching sem errors in there. The same process is needed
22441 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
22444 (Statement.Warning_DeadCodeFound): Factorize code.
22445 (While): Report dead code here too.
22447 (Statement): Added Resolve virtual method to allow
22448 for resolution split from the emit code.
22450 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22452 * statement.cs (EmitBoolExpression): No longer try to resolve the
22454 (MakeBoolean): New utility function that resolve, implicitly
22455 converts to boolean and tags the expression.
22458 (If, Do): Implement dead code elimination.
22459 (While): Implement loop inversion
22461 (Do, While, For, If): Resolve the expression prior to calling our
22464 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22467 - added method Report28 (warning: program has more than one entry point)
22468 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22469 - modified method Method.Define, the part at the end of the method
22471 * rootcontext.cs: added static public Location EntryPointLocation;
22473 * ../errors/cs0028.cs : Add test case for the above warning.
22476 - modified method CSharpName to allow arrays of primitive type to
22477 be printed nicely (e.g. instead of System.Int32[][] it now prints
22479 - added method CSharpSignature: returns the signature of a method
22480 in string format to be used in reporting errors, warnings, etc.
22482 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22485 2002-04-26 Ravi Pratap <ravi@ximian.com>
22487 * delegate.cs (Define): Fix extremely silly bug where I was
22488 setting the type of the 'object' parameter of the BeginInvoke
22489 method to System.IAsyncResult instead of System.Object ;-)
22491 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22493 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22496 (Constructor.Emit): return if we fail to initialize the
22497 constructor. Another door closed!
22499 * expression.cs (New.DoResolve): Improve error message (from -6 to
22500 1501). Use DeclaredOnly lookup to find the exact constructor.
22502 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22503 loop. This is useful.
22505 * cs-parser.jay: Adjust the default parameters so that destructors
22506 have the proper signature.
22508 2002-04-26 Martin Baulig <martin@gnome.org>
22510 * driver.cs (LoadAssembly): If `assembly' contains any characters
22511 which are only valid in path names and not in assembly names
22512 (currently slash, backslash and point), use Assembly.LoadFrom ()
22513 instead of Assembly.Load () on the `assembly' (before iteration
22514 over the link_paths).
22516 2002-04-26 Martin Baulig <martin@gnome.org>
22518 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22520 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22522 * class.cs (Property): use the new typemanager.MemberLookup
22524 (TypeContainer.MemberLookup): Implement using the
22525 TypeManager.MemberLookup now.
22527 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22528 and return MemberInfos, so that these can be used without an
22529 EmitContext (what we had before).
22531 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22533 * expression.cs: Fix the case where the argument to params if the
22534 type of the params. I omitted handling this before. Fixed
22536 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22538 * driver.cs: Call BootCorlib_PopulateCoreType
22540 * class.cs (Property.CheckBase): Check for properties only, not
22543 * interface.cs: Temporary hack: try/catch around the
22544 CustomAttributeBuilder, because I am getting an exception that I
22547 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22548 types whose definitions are required to be there (attributes are
22549 defined before standard types).
22551 Compute definitions as we boot the various types, as they are used
22552 immediately (value_type class will need object_type, but if we do
22553 not initialize object_type, we will pass a null, which will let
22554 the runtime pick the System.Object from the existing corlib, which
22555 is not what we want).
22557 2002-04-22 Patrik Torstensson <totte@labs2.com>
22559 * cs-tokenizer.cs: fixed a number of trim() issues.
22561 2002-04-22 Ravi Pratap <ravi@ximian.com>
22563 * expression.cs (Argument.Type): Ensure that we return the correct
22564 type when we have out or ref parameters [in which case we
22567 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22569 * class.cs (Property, Indexer): Allow extern modifier in there.
22571 * typemanager.cs (InitBaseTypes): Initializes object_type and
22572 value_type, since those will be used early on during the bootstrap
22573 process to compile corlib.
22575 (InitCoreTypes): Move code from here to InitBaseTypes.
22577 2002-04-21 Miguel de Icaza <miguel@ximian.com>
22579 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
22580 single-dimension arrays as using the ldlen opcode.
22582 Daniel Lewis discovered this optimization.
22584 * typemanager.cs: Add signature for System.Array::get_Length
22586 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22588 * statement.cs: report the error when the foreach does not apply to an
22589 array nor a collection.
22591 2002-04-19 Miguel de Icaza <miguel@ximian.com>
22593 * expression.cs: Add implicit conversions to the operator ~.
22595 * constant.cs (DecimalConstant.Emit): Emit decimal value.
22597 * typemanager.cs: Locate the decimal constructor.
22599 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22601 * attribute.cs: use the new property of TypeOf.
22602 * expression.cs: added 'get' property around typearg.
22604 These changes fix a build breaker reported by NickD. Is this the
22605 correct way to fix? If not, please, revert my changes and make it
22608 2002-04-17 Miguel de Icaza <miguel@ximian.com>
22610 * attribute.cs: Add support for typeof in attribute invocations.
22611 I am not sure that this is right though.
22613 2002-04-14 Duncan Mak <duncan@ximian.com>
22615 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
22616 Binary.Operator.Division case.
22618 2002-04-13 Ravi Pratap <ravi@ximian.com>
22620 * class.cs (DefineType): Ensure that we do a proper check on
22621 attribute types and also register it with the TypeManager.
22623 (TypeContainer.Targets): The default for attribute types is
22624 AttributeTargets.All.
22626 * attribute.cs (ApplyAttributes): Registering the attribute type
22627 is done elsewhere, not when we discover we have a Usage attribute.
22629 2002-04-12 Ravi Pratap <ravi@ximian.com>
22631 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
22632 and get rid of is_delegate parameter.
22634 * everywhere : update.
22636 2002-04-12 Ravi Pratap <ravi@ximian.com>
22638 * cs-parser.jay (compilation_unit): Revamp completely to use
22639 some new ideas that I got from Rhys' grammar to solve the problems
22640 with assembly level attributes.
22642 (outer_declaration): New grammar production.
22644 (attribute_sections): Add.
22646 (opt_attributes): Base on attribute_sections
22648 (namespace_declaration): Allow opt_attributes to tackle the case
22649 when we have assembly level attributes - we are clever in this
22652 * attribute.cs (ApplyAttributes): Do not worry about assembly
22653 attributes in the non-global context.
22655 * rootcontext.cs (AddGlobalAttributes): Go back to using this
22656 instead of SetGlobalAttributes.
22658 * class.cs, rootcontext.cs : Ensure we define and generate
22659 attribute types before anything else.
22661 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
22662 and flag the new error -20 for the case when the attribute type
22663 does not have valid targets specified. csc does not catch this.
22665 * ../errors/errors.txt : update for error # -20
22667 2002-04-11 Ravi Pratap <ravi@ximian.com>
22669 * support.cs (InternalParameters.ParameterModifier): Do some null
22670 checking and return sane values.
22672 * class.cs (Method.Define): If we are a PInvoke method, ensure
22673 that we are static and extern. Report error # 601
22675 * ../errors/cs0601.cs : Add test case for the above error.
22677 2002-04-07 Ravi Pratap <ravi@ximian.com>
22679 * rootcontext.cs (attribute_types): We need to keep type of
22680 all attribute types separately and emit code for them first.
22682 (RegisterAttribute) : Implement.
22684 * class.cs (DefineType): Check if the current Type is a custom
22685 attribute type and register it accordingly.
22687 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
22688 adding the first attribute twice and rename to
22690 (SetGlobalAttributes): this.
22692 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
22695 * attribute.cs (ApplyAttributes): Take an additional argument telling us
22696 if we are processing global arguments. Hmm, I am unsure of this.
22698 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22700 * expression.cs: added static array of strings to avoid calling
22701 Enum.ToString () for Operator in Binary. Significant recover of
22704 2002-04-10 Miguel de Icaza <miguel@ximian.com>
22706 * class.cs (FindMembers): Allow the Builders of the various
22707 members to be null. If they are skip them. This only happens
22708 during the PInvoke declaration.
22710 2002-04-09 Miguel de Icaza <miguel@ximian.com>
22712 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
22713 failure, so we do not keep going afterwards.
22715 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
22716 wanted to pass `false' as the `is_delegate' argument. If this is
22717 the case, why not use delegate_type == null to mean `is_delegate =
22718 false' and anything else as is_delegate = true.
22720 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
22722 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
22723 code for the section, not the beginning of the tests.
22725 2002-04-08 Miguel de Icaza <miguel@ximian.com>
22727 * cfold.cs: Handle operator + (Enum x, Underlying x)
22729 * expression.cs (Binary): same. Warn about errors where we have
22730 Enum/Enum in operator + as well.
22732 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
22735 - added support for switch(bool)
22736 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
22737 - add TableSwitchEmit() to handle table-based switch statements
22739 2002-04-05 Ravi Pratap <ravi@ximian.com>
22741 * expression.cs (Invocation.OverloadResolve): Factor out code which
22742 does parameter compatibility checking with arguments so that we can
22743 re-use the code even from Delegate.VerifyApplicability
22745 (VerifyArgumentsCompat): Move above code here.
22747 * delegate.cs (VerifyApplicability): Get rid of duplicate code
22748 and instead make a call to the above method.
22750 2002-03-31 Ravi Pratap <ravi@ximian.com>
22752 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
22753 We use it to keep track of classes which are attribute types.
22755 2002-04-02 Miguel de Icaza <miguel@ximian.com>
22757 * delegate.cs (Delegate.Define): Correctly define the types in the
22758 presence of fixed and array parameters.
22760 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
22763 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
22764 include NonPublic after the first iteration.
22766 * class.cs (Indexer.CheckBase): Only check if both parents are
22769 * cs-parser.jay (accessor_body): If empty, set to null.
22771 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
22772 same code path here to resolve constants names that we did have in
22773 MemberAccess.DoResolve. There is too much code duplicated here.
22775 2002-04-01 Miguel de Icaza <miguel@ximian.com>
22777 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
22779 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
22782 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
22783 tokens, numbers and strings.
22785 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
22788 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
22789 asyncronous parameters and the regular parameters.
22791 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
22792 specify the target directory.
22794 * expression.cs: (This.DoResolve): Simplify
22795 (As.Emit): Optimize, do not generate IsInst if the expression is
22796 always of the given type.
22798 (Is.DoResolve): Bug fix, we were reporting both always/never for
22801 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
22802 creating too many unnecessary arrays.
22804 2002-03-31 Miguel de Icaza <miguel@ximian.com>
22806 * class.cs (EmitFieldInitializer): Use Assign expression to assign
22807 fields instead of rolling our own initializer. Takes care of all
22808 implicit conversions, and drops unnecessary static checks/argument.
22810 2002-03-31 Dick Porter <dick@ximian.com>
22812 * driver.cs: use the GetDirectories() return values properly, and
22813 use "/" as path separator.
22815 2002-03-30 Miguel de Icaza <miguel@ximian.com>
22817 * expression.cs (Unary): Optimize - - expr into expr.
22818 (Binary): Optimize a + (-b) into a -b.
22820 * codegen.cs (CodeGen): Made all methods static.
22822 2002-03-29 Miguel de Icaza <miguel@ximian.com>
22826 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
22827 TypeBuilder property.
22829 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
22832 * tree.cs: Removed the various RecordXXXX, and replaced with a
22833 single RecordDecl. Removed all the accessor methods, and just
22834 left a single access point Type
22836 * enum.cs: Rename DefineEnum to DefineType.
22838 * decl.cs: New abstract method `DefineType' used to unify the
22839 Defines for Enumerations, Interfaces, TypeContainers and
22842 (FindType): Moved LookupInterfaceOrClass here. Moved the
22843 LookupBaseClasses method that used to live in class.cs and
22844 interface.cs here, and renamed to FindType.
22846 * delegate.cs: Implement DefineType. Take advantage of the
22847 refactored pattern for locating the parent builder without taking
22848 the parent_builder argument (which we know does not work if we are
22849 nested, and triggering a toplevel definition).
22851 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22853 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
22854 accessibility of a member has changed during override and report
22857 * class.cs (Method.Define, Property.Define): Only complain on
22858 overrides if the method is private, any other accessibility is
22859 fine (and since we just checked the permission is the same, we are
22862 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
22863 and elif are processed always. The other pre-processing
22864 directives are only processed if we are "taking" the path
22866 2002-03-29 Martin Baulig <martin@gnome.org>
22868 * class.cs (Method.Emit): Only emit symbolic debugging info if the
22869 current location is not Null.
22871 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
22872 a separate method so we can profile it.
22874 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
22875 `span.Seconds' are just seconds, but no minutes or hours.
22876 (MainDriver): Profile the CodeGen.SaveSymbols calls.
22878 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22880 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
22881 Remove the gratuitous set of Final:
22883 // If an interface implementation, then we can set Final.
22884 if (((flags & MethodAttributes.Abstract) == 0) &&
22885 implementing.DeclaringType.IsInterface)
22886 flags |= MethodAttributes.Final;
22888 I do not know what I was smoking when I used that.
22891 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
22892 step into fixing the name resolution issues for delegates and
22893 unifying the toplevel name resolution.
22895 2002-03-28 Martin Baulig <martin@gnome.org>
22897 * class.cs (Method.Emit): If we have a symbol writer, call its
22898 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
22899 tell it about the current method.
22901 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
22902 writer that we're going to emit the first byte of IL code for a new
22903 statement (a new source line).
22904 (EmitContext.EmitTopBlock): If we have a symbol writer, call
22905 EmitContext.Mark() before emitting any code.
22907 * location.cs (SymbolDocument): Return null when we're Null.
22909 * statement.cs (Statement): Moved the `Location loc' variable here.
22910 (Statement.EmitBoolExpression): If we have a symbol writer, call
22911 ec.Mark() before emitting any code to tell it that we're at the
22912 beginning of a new statement.
22913 (StatementExpression): Added `Location' argument to the constructor.
22914 (Block): Added public readonly variable `StartLocation' and public
22915 variable `EndLocation'. The latter is to be set using SetEndLocation().
22916 (Block): Added constructor which takes a start and end location.
22917 (Block.SetEndLocation): New method. This sets the end location.
22918 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
22919 local variables we create.
22920 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
22921 each statement and do also mark the begin and end of the block.
22923 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
22924 tell it the current lexer.Location, use Location.Null for the end of the
22926 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22927 current block, set its end location using SetEndLocation().
22928 (statement_expression): StatementExpression constructor now takes the
22929 lexer.Location as additional argument.
22930 (for_statement, declare_local_variables): Likewise.
22931 (declare_local_variables): When creating a new implicit block, use the
22932 new Block constructor and pass it the lexer.Location.
22934 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22936 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
22937 members also on the parent interfaces recursively.
22939 2002-03-27 Miguel de Icaza <miguel@ximian.com>
22941 * report.cs: Use new formats, since Gonzalo finished the missing
22944 * expression.cs (Binary.ResolveOperator): added missing operator|
22945 operator& and operator^ for bool/bool.
22947 * cs-parser.jay: CheckDef now takes a Location argument that is
22948 used to report errors more precisly (instead of reporting the end
22949 of a definition, we try to track something which is a lot closer
22950 to the source of the problem).
22952 * cs-tokenizer.cs: Track global token use, so we can properly flag
22953 the use of #define/#undef after the first token has been seen.
22955 Also, rename the reportXXXX to Error_DescriptiveName
22957 * decl.cs (DeclSpace.IsTopLevel): Move property here from
22958 TypeContainer, so that Enum and Interface can use this too.
22960 * class.cs (TypeContainer.LookupInterfaceOrClass,
22961 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
22962 `builder' argument. Typically this was used to pass the parent
22963 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
22966 The problem is that a nested class could trigger the definition of
22967 a toplevel class, and the builder would be obviously wrong in that
22970 So we drop this argument, and we compute dynamically the
22971 TypeBuilder/ModuleBuilder (the correct information was available
22972 to us anyways from DeclSpace.Parent)
22974 * interface.cs (Interface.DefineInterface): Drop builder
22975 parameter cleanup like class.cs
22977 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
22980 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
22983 (Try.Emit): Propagate the returns value from the statement.
22985 (Return.Emit): Even if we are leavning
22987 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
22989 * modifiers.cs: Fix the computation of MethodAttributes flags.
22991 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
22993 * driver.cs: allow compilation of files that start with '/'.
22994 Add a default case when checking the argument of --target.
22996 2002-03-25 Miguel de Icaza <miguel@ximian.com>
22998 * interface.cs: Implement the same search algorithm for types in
22999 the interface code.
23001 * delegate.cs: Do not allow multiple definition.
23003 * Recovered ChangeLog that got accidentally amputated
23005 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
23007 * rootcontext.cs: Load manually enum to allow core classes to
23008 contain enumerations.
23010 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
23011 Update to new static methods in TypeManager.
23013 * typemanager.cs (GetMethod, GetConstructor): Use our
23014 implementation of FindMembers to find the members, since during
23015 corlib compilation, the types are TypeBuilders and GetMethod and
23016 GetConstructor do not work.
23018 Make all methods in TypeManager static.
23020 (InitCodeHelpers): Split the functionality from
23021 the InitCodeTypes function.
23023 * driver.cs: Call InitCodeHelpers after we have populated the
23026 * cs-parser.jay (delegate_declaration): we did not used to compute
23027 the delegate name correctly for void delegates.
23029 2002-03-24 Miguel de Icaza <miguel@ximian.com>
23031 * rootcontext.cs (RootContext): Init the interface_resolve_order
23032 and type_container_resolve_order always.
23034 (ResolveCore, BootstrapCorlib_ResolveClass,
23035 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
23036 compiler when compiling with --nostdlib
23038 * class.cs (TypeContainer.DefineType): Check that our parent is
23039 not null. This test is most important when we are bootstraping
23042 * codegen.cs: Split out the symbol writing code.
23044 2002-03-25 Martin Baulig <martin@gnome.org>
23046 * driver.cs (-g): Made -g an alias for --debug.
23048 2002-03-24 Martin Baulig <martin@gnome.org>
23050 * codegen.cs (SymbolWriter): New public variable. Returns the
23051 current symbol writer.
23052 (CodeGen): Added `bool want_debugging_support' argument to the
23053 constructor. If true, tell the ModuleBuild that we want debugging
23054 support and ask it for the ISymbolWriter.
23055 (Save): If we have a symbol writer, call it's Close() method after
23056 saving the assembly.
23058 * driver.c (--debug): New command line argument to create a
23059 debugger information file.
23061 * location.cs (SymbolDocument): New public property. Returns an
23062 ISymbolDocumentWriter object for the current source file or null
23063 if we don't have a symbol writer.
23065 2002-03-21 Miguel de Icaza <miguel@ximian.com>
23067 * driver.cs (LoadAssembly): Correctly return when all the paths
23068 have been tried and not before.
23070 * statement.cs (Switch.Emit): return the actual coverage for this
23071 statement (returns/not-returns)
23073 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
23074 switch of the statement if we are the last switch section. That
23075 kills two problems: try/catch problems (we used to emit an empty
23076 nop at the end) and switch statements where all branches would
23079 2002-03-19 Miguel de Icaza <miguel@ximian.com>
23081 * driver.cs: Add default assemblies (the equivalent to the
23082 Microsoft CSC.RSP file)
23084 * cs-tokenizer.cs: When updating `cols and setting it to zero,
23085 also update tokens_seen and set it to false.
23087 * driver.cs: Implement --recurse for Mike.
23089 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
23090 correctly splitting out the paths.
23092 2002-03-18 Miguel de Icaza <miguel@ximian.com>
23094 * interface.cs (Interface.PopulateProperty): Instead of using
23095 `parent' as the declaration space for the set parameters, use
23098 * support.cs (InternalParameters): InternalParameters constructor
23099 takes a DeclSpace instead of a TypeContainer.
23101 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
23102 types are being initialized, load the address of it before calling
23105 (New): Provide a mechanism to disable the generation of local
23106 value type temporaries when the caller will be providing us with
23107 an address to store it.
23109 (ArrayCreation.EmitDynamicInitializers): Use it.
23111 2002-03-17 Miguel de Icaza <miguel@ximian.com>
23113 * expression.cs (Invocation.EmitArguments): Only probe for array
23114 property if there is more than one argument. Sorry about that.
23116 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
23117 empty param arrays.
23119 * class.cs (Method.LabelParameters): Fix incorrect code path that
23120 prevented the `ParamArrayAttribute' from being applied to the
23123 2002-03-16 Miguel de Icaza <miguel@ximian.com>
23125 * support.cs (ReflectionParameters): Correctly compute whether the
23126 last argument is a params array. Fixes the problem with
23129 * typemanager.cs: Make the assemblies array always be non-null
23130 (empty, but non-null)
23132 * tree.cs (RecordDecl): New function that abstracts the recording
23133 of names. This reports error 101, and provides a pointer to the
23134 previous declaration. Fixes a crash in the compiler.
23136 * cs-parser.jay (constructor_declaration): Update to new grammar,
23137 and provide a constructor_body that can be empty.
23139 2002-03-15 Miguel de Icaza <miguel@ximian.com>
23141 * driver.cs: Add support for --resources.
23143 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
23144 Make all types for the various array helper methods be integer.
23146 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
23147 CheckState to ConvCast.
23149 (ConvCast): Now it takes a `checked' state argument, to avoid
23150 depending on the emit context for the conversion, and just using
23151 the resolve time setting.
23153 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
23154 instead of Invocation.EmitArguments. We do not emit the original
23155 arguments, instead we emit those which have been converted to
23156 unsigned int expressions.
23158 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
23160 * codegen.cs: ditto.
23162 * expression.cs (LocalVariableReference): Drop the use of the
23163 Store function that depended on the variable index.
23165 * statement.cs (VariableInfo): Drop the `Idx' property from this
23166 class, as this is not taking into account the indexes for
23167 temporaries tat we generate during the execution, getting the
23170 * class.cs: First emit class initializers, then call the parent
23173 * expression.cs (Binary): Fix opcode emision.
23174 (UnaryMutator.EmitCode): Support checked code generation
23176 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
23177 matches for events for both the Static and Instance scans,
23178 pointing to the same element. Fix that.
23180 2002-03-14 Miguel de Icaza <miguel@ximian.com>
23182 * rootcontext.cs (ResolveTree): Always set the
23183 interface_resolve_order, because nested interfaces will be calling
23186 * class.cs (GetInterfaceOrClass): Track the same resolution
23187 process used by TypeManager.LookupType. This fixes the nested
23188 type lookups in class declarations (separate path from
23191 (TypeContainer.DefineType): Also define nested interfaces.
23192 (TypeContainer.RegisterOrder): New public function used to
23193 register the order in which child interfaces need to be closed.
23195 Nested interfaces need to be closed after their parents have been
23198 * interface.cs (InterfaceAttr): Put all the logic for computing
23199 the interface attribute here.
23201 (DefineInterface): Register our interface order with the
23202 RootContext or with the TypeContainer depending on the case.
23204 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23206 * cs-parser.jay: rework foreach statement to work with the new
23207 changes to the policy on SimpleNames.
23209 * report.cs: support Stacktrace on warnings as well.
23211 * makefile: drop --unsafe and /unsafe from the compile.
23213 2002-03-13 Ravi Pratap <ravi@ximian.com>
23215 * ecore.cs (StandardConversionExists): Modify to take an Expression
23216 as the first parameter. Ensure we do null -> reference type conversion
23219 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
23220 temporary Expression objects.
23222 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
23224 * interface.cs: workaround bug in method overloading resolution
23225 (there is already a bugzilla bug for it).
23227 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23229 We could also solve this problem by having a separate path for
23230 performing type lookups, instead of DoResolve, we could have a
23231 ResolveType entry point, and only participating pieces of the
23232 production (simplename, deref, array) would implement this.
23234 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
23235 signal SimpleName to only resolve type names and not attempt to
23236 resolve anything else.
23238 * expression.cs (Cast): Set the flag.
23240 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
23242 * class.cs: Only report 108 if there is no `new' modifier.
23244 * cs-parser.jay: rework foreach statement to work with the new
23245 changes to the policy on SimpleNames.
23247 * report.cs: support Stacktrace on warnings as well.
23249 * makefile: drop --unsafe and /unsafe from the compile.
23251 2002-03-11 Miguel de Icaza <miguel@ximian.com>
23253 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23254 lookups here, instead of doing that at parse time. This means
23255 that our grammar will not introduce `LocalVariableReferences' as
23256 expressions at this point. That solves the problem of code like
23260 static void Main ()
23264 This is only half the fix. The full fix requires parameters to
23265 also be handled in this way.
23267 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
23268 makes the use more obvious of the DeclSpace. The
23269 ec.TypeContainer.TypeBuilder is now only used to pull the
23270 TypeBuilder for it.
23272 My theory is that I can get rid of the TypeBuilder completely from
23273 the EmitContext, and have typecasts where it is used (from
23274 DeclSpace to where it matters).
23276 The only pending problem is that the code that implements Aliases
23277 is on TypeContainer, and probably should go in DeclSpace.
23279 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23280 lookups here, instead of doing that at parse time. This means
23281 that our grammar will not introduce `LocalVariableReferences' as
23282 expressions at this point. That solves the problem of code like
23286 static void Main ()
23290 This is only half the fix. The full fix requires parameters to
23291 also be handled in this way.
23293 * class.cs (Property.DefineMethod): When implementing an interface
23294 method, set newslot, when implementing an abstract method, do not
23295 set the flag (before we tried never setting it, or always setting
23296 it, which is the difference).
23297 (Indexer.DefineMethod): same.
23298 (Method.DefineMethod): same.
23300 * ecore.cs: Only set the status used flag if we get back a Field.
23302 * attribute.cs: Temporary hack, so Paolo can keep working.
23304 2002-03-08 Ravi Pratap <ravi@ximian.com>
23306 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
23307 the unmanaged type in the case we have a MarshalAs attribute.
23309 (Resolve): Handle the case when we are parsing the special MarshalAs
23310 attribute [we need to store the unmanaged type to use later]
23312 * typemanager.cs (marshal_as_attr_type): Built in type for the
23313 MarshalAs Attribute.
23315 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
23316 on parameters and accordingly set the marshalling info.
23318 2002-03-09 Miguel de Icaza <miguel@ximian.com>
23320 * class.cs: Optimizing slightly by removing redundant code after
23321 we switched to the `NoTypes' return value.
23322 (Property.DefineMethod): use NoTypes here too.
23324 This fixes the bug I introduced in my last batch of changes.
23326 2002-03-05 Ravi Pratap <ravi@ximian.com>
23328 * tree.cs (RecordEnum): Add. We now keep track of enums too.
23330 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
23331 Enums since those are types too.
23333 * cs-parser.jay (enum_declaration): Record enums as we parse them.
23335 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
23336 thanks to a call during the lookup process.
23338 2002-03-07 Miguel de Icaza <miguel@ximian.com>
23340 * statement.cs (Foreach): Lots of work to accomodate a particular
23341 kind of foreach statement that I had not kept in mind. It is
23342 possible to have foreachs on classes that provide a GetEnumerator
23343 method that return objects that implement the "pattern" for using
23344 a foreach, there is no need to support GetEnumerator
23347 This is needed to compile nant.
23349 * decl.cs: Only report 114 if the member is not `Finalize' and if
23350 the warning level is at least 2.
23352 * class.cs: Moved the compare function from Method to
23355 (MethodSignature.InheritableMemberSignatureCompare): Add new
23356 filter function that is used to extract inheritable methods from a
23359 (Method.Define): Use the new `inheritable_method_signature_filter'
23362 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
23365 2002-03-06 Miguel de Icaza <miguel@ximian.com>
23367 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
23369 * cs-parser.jay: Add opt_semicolon to the interface declaration.
23371 * expression.cs: Pass location information to
23372 ConvertImplicitStandard.
23374 * class.cs: Added debugging code to track return values from
23377 2002-03-05 Miguel de Icaza <miguel@ximian.com>
23379 * expression.cs (Is.DoResolve): If either side of the `is' is an
23380 interface, do not flag the warning.
23382 * ecore.cs (ImplicitReferenceConversion): We need a separate test
23385 * report.cs: Allow for --fatal to be used with --probe.
23387 * typemanager.cs (NoTypes): Move the definition for the empty Type
23390 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
23392 (TypeContainer.DefineProxy): New function used to proxy to parent
23393 implementations when implementing interfaces.
23394 (TypeContainer.ParentImplements): used to lookup if our parent
23395 implements a public function that is required by an interface.
23396 (TypeContainer.VerifyPendingMethods): Hook this up.
23398 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
23399 `modules' and `assemblies' arraylists into arrays. We only grow
23400 these are the very early start up of the program, so this improves
23401 the speedof LookupType (nicely measured).
23403 * expression.cs (MakeByteBlob): Replaced unsafe code with
23404 BitConverter, as suggested by Paolo.
23406 * cfold.cs (ConstantFold.Binary): Special case: perform constant
23407 folding of string concatenation, but if either side is a string,
23408 and the other is not, then return null, and let the runtime use
23409 the concatenation on the string plus the object (using
23410 `Object.ToString').
23412 2002-03-04 Miguel de Icaza <miguel@ximian.com>
23414 Constant Folding has been implemented now.
23416 * expression.cs (Unary.Reduce): Do not throw an exception, catch
23417 the error instead on types that are not supported in one's
23420 * constant.cs (Constant and all children): New set of functions to
23421 perform implict and explicit conversions.
23423 * ecore.cs (EnumConstant): Implement the new functions to perform
23424 conversion by proxying to the child expression.
23426 * codegen.cs: (ConstantCheckState): Constant evaluation has its
23427 own separate setting that can not be turned off from the command
23428 line using --unchecked or --checked and is only controlled using
23429 the checked/unchecked statements and expressions. This setting is
23430 used by the constant folder to flag errors.
23432 * expression.cs (CheckedExpr, UncheckedExpr): Set the
23433 ConstantCheckState as well.
23435 During Resolve, they also have to flag the state, because the
23436 constant folder runs completely in the Resolve phase.
23438 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
23441 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23443 * cfold.cs: New file, this file contains the constant folder.
23445 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
23446 argument to track whether we are using the resulting address to
23447 load or store a value and provide better error messages.
23449 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
23450 new AddressOf arguments.
23452 * statement.cs (Foreach.EmitCollectionForeach): Update
23454 * expression.cs (Argument.Emit): Call AddressOf with proper
23455 arguments to track usage.
23457 (New.DoEmit): Call AddressOf with new arguments.
23459 (Unary.Emit): Adjust AddressOf call.
23461 2002-03-01 Ravi Pratap <ravi@ximian.com>
23463 * cs-parser.jay (member_access): Change the case for pre-defined types
23464 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23467 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23470 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23471 essentially like methods and apply attributes like MethodImplOptions to them too.
23473 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23476 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23477 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23480 * Update code everywhere accordingly.
23482 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23484 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23486 2002-02-28 Ravi Pratap <ravi@ximian.com>
23488 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23489 try performing lookups against those instead of jumping straight into using
23490 the 'using' clauses.
23492 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23494 (LookupType): Perform lookups in implicit parents too.
23496 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23497 sequence as RootContext.LookupType.
23499 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23500 the various cases of namespace lookups into this method.
23502 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23504 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23505 in positional arguments)
23507 * class.cs (Operator): Update the AllowedModifiers to contain
23510 * cs-parser.jay: Update operator declaration to allow for the
23511 operator body to be empty.
23513 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23516 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23518 * class.cs (Method.Emit): Label parameters.
23520 * driver.cs: Return 1 or 0 as the program exit code.
23522 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23524 * expression.cs: Special case the `null' object when trying to
23525 auto-compute the type, as anything can be explicitly converted to
23528 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23529 spotting this Paolo.
23531 (Expression.ImplicitNumericConversion): Perform comparissions of
23532 the type using the underlying type in the case of an enumeration
23533 rather than using the enumeration type for the compare.
23535 Cope with the underlying == type case, which is not possible to
23538 (Expression.ConvertNumericExplicit): Perform comparissions of
23539 the type using the underlying type in the case of an enumeration
23540 rather than using the enumeration type for the compare.
23542 * driver.cs: If the user does not supply an extension, assume .exe
23544 * cs-parser.jay (if_statement): Rewrote so that we can track the
23545 location for the if statement.
23547 * expression.cs (Binary.ConstantFold): Only concat strings when
23548 the operation is "+", not everything ;-)
23550 * statement.cs (Statement.EmitBoolExpression): Take a location
23552 (If, While, Do): Track location.
23554 * expression.cs (Binary.ResolveOperator): In the object + string
23555 case, I was missing a call to ConvertImplicit
23557 2002-02-25 Ravi Pratap <ravi@ximian.com>
23559 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23560 Location arguments. Ensure we use RootContext.LookupType to do our work
23561 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23563 * interface.cs (PopulateMethod): Handle the type of the parameter being
23566 * expression.cs (Invocation.BetterFunction): Handle the case when we
23567 have a params method with no fixed arguments and a call is made with no
23570 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23572 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23573 the verbatim-string-literal
23575 * support.cs (InternalParameters.ParameterModifier): handle null
23577 (InternalParameters.ParameterType): ditto.
23579 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
23580 duplicating the name of the variable parameter.
23581 (GetParameterByName): Fix bug where we were not looking up array
23582 paramters if they were the only present (thanks Paolo!).
23583 (GetParameterInfo): We only have an empty set of types if both
23584 fixed and array are set to null.
23585 (GetParameterInfo-idx): Handle FixedParameter == null
23587 * cs-parser.jay: Handle the case where there is no catch
23588 statements (missing null test).
23590 2002-02-22 Miguel de Icaza <miguel@ximian.com>
23592 * driver.cs (MainDriver): Be conservative on our command line
23595 Catch DirectoryNotFoundException when calling GetFiles.
23597 (SplitPathAndPattern): Used to split the input specification into
23598 a path and a pattern that we can feed to Directory.GetFiles.
23600 2002-02-21 Miguel de Icaza <miguel@ximian.com>
23602 * statement.cs (Fixed): Implement the last case of the Fixed
23603 statement (string handling).
23605 * expression.cs (StringPtr): New class used to return a char * to
23606 a string; Used by the Fixed statement.
23608 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
23610 * expression.cs (Binary.ResolveOperator): Remove redundant
23611 MemberLookup pn parent type.
23612 Optimize union call, we do not need a union if the types are the same.
23613 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
23616 Specialize the use of MemberLookup everywhere, instead of using
23617 the default settings.
23619 (StackAlloc): Implement stackalloc keyword.
23621 * cs-parser.jay: Add rule to parse stackalloc.
23623 * driver.cs: Handle /h, /help, /?
23625 * expression.cs (MakeByteBlob): Removed the hacks we had in place
23626 before we supported unsafe code.
23628 * makefile: add --unsafe to the self compilation of mcs.
23630 2002-02-20 Miguel de Icaza <miguel@ximian.com>
23632 * expression.cs (PointerArithmetic): New class that is used to
23633 perform pointer arithmetic.
23634 (Binary.Resolve): Handle pointer arithmetic
23635 Handle pointer comparission.
23636 (ArrayPtr): Utility expression class that is used to take the
23637 address of an array.
23639 (ElementAccess): Implement array access for pointers
23641 * statement.cs (Fixed): Implement fixed statement for arrays, we
23642 are missing one more case before we are done.
23644 * expression.cs (Indirection): Implement EmitAssign and set the
23645 ExprClass to Variable. This allows pointer dereferences to be
23646 treated as variables, and to have values assigned to them.
23648 * ecore.cs (Expression.StoreFromPtr): New utility function to
23649 store values dereferencing.
23651 2002-02-20 Ravi Pratap <ravi@ximian.com>
23653 * expression.cs (Binary.ResolveOperator): Ensure that we are
23654 not trying to operate on a void type - this fixes the reported
23657 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
23658 the parent implementation is sealed.
23660 * ../errors/cs0239.cs : Add.
23662 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
23664 * typemanager.cs (unverifiable_code_type): Corresponds to
23665 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
23666 which have unsafe code in them.
23668 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
23671 2002-02-19 Miguel de Icaza <miguel@ximian.com>
23673 * cs-tokenizer.cs: Add support for @"litreal strings"
23675 Make tokenizer accept pre-processor directives
23676 on any column (remove the old C-like limitation).
23678 * rootcontext.cs (EmitCode): Emit any global attributes.
23679 (AddGlobalAttributes): Used to keep track of assembly attributes.
23681 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
23683 * cs-parser.jay: Add support for global attributes.
23685 2002-02-17 Miguel de Icaza <miguel@ximian.com>
23687 * expression.cs (Indirection): New helper class. Unary will
23688 create Indirection classes to be able to implement the
23689 IMemoryLocation interface on it.
23691 2002-02-16 Miguel de Icaza <miguel@ximian.com>
23693 * cs-parser.jay (fixed_statement): reference the right statement.
23695 * statement.cs (Fixed.Emit): Finish implementing the fixed
23696 statement for the &x case.
23698 2002-02-14 Miguel de Icaza <miguel@ximian.com>
23700 * class.cs (Property.Define, Method.Define): Remove newslot when
23703 * modifiers.cs: My use of NewSlot when `Abstract' was set was
23704 wrong. NewSlot should only be used if the `new' keyword is present.
23706 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
23707 locating our system dir. Sorry about this.
23709 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23711 * driver.cs (GetSystemDir): Compute correctly the location of our
23712 system assemblies. I was using the compiler directory instead of
23713 the library directory.
23715 2002-02-13 Ravi Pratap <ravi@ximian.com>
23717 * expression.cs (BetterFunction): Put back in what Miguel commented out
23718 since it is the correct fix. The problem is elsewhere ;-)
23720 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
23721 parameters of the parms method are themselves compatible or not !
23723 (StandardConversionExists): Fix very dangerous bug where we were forgetting
23724 to check that a class implements an interface before saying that an implicit
23725 conversion was allowed. Use ImplementsInterface to do the checking.
23727 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23729 * class.cs (Method.Define): Track whether we are an explicit
23730 implementation or not. And only call DefineMethodOverride if we
23731 are an explicit implementation.
23733 (Property.DefineMethod): Ditto.
23735 2002-02-11 Ravi Pratap <ravi@ximian.com>
23737 * expression.cs (BetterFunction): Catch hideous bug which was
23738 preventing us from detecting ambiguous calls due to implicit casts i.e
23741 2002-01-29 Miguel de Icaza <miguel@ximian.com>
23743 * support.cs (Pair): Remove un-needed method. I figured why I was
23744 getting the error in cs-parser.jay, the variable in a foreach loop
23745 is readonly, and the compiler does not really treat this as a variable.
23747 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
23748 instead of EQUALS in grammar.
23750 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
23752 * expression.cs (Unary.DoResolve): Check whether the argument is
23755 2002-01-28 Miguel de Icaza <miguel@ximian.com>
23757 * support.cs: Api for Pair to set a value. Despite the fact that
23758 the variables are public the MS C# compiler refuses to compile
23759 code that accesses the field if the variable is part of a foreach
23762 * statement.cs (Fixed): Begin implementation of the fixed
23765 (Block.AddVariable): Return the VariableInfo on success and null
23766 on failure instead of true/false.
23768 * cs-parser.jay (foreach): Catch errors on variables already
23769 defined (we were ignoring this value before) and properly unwind
23770 the block hierarchy
23772 (fixed_statement): grammar for the fixed statement.
23774 2002-01-25 Miguel de Icaza <miguel@ximian.com>
23776 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
23777 pointer types to be incretemented.
23779 (SizeOf): Implement.
23781 * cs-parser.jay (pointer_member_access): Implement
23782 expr->IDENTIFIER production.
23784 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
23785 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
23788 (Unary): Implement indirection.
23790 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
23791 use in non-unsafe context).
23793 (SimpleName.DoResolve): Check for pointers in field access on safe
23796 (Expression.LoadFromPtr): Factor the load-indirect code in this
23797 function. This was duplicated in UnboxCast and ParameterReference
23799 2002-01-24 Miguel de Icaza <miguel@ximian.com>
23801 * expression.cs (ComposedCast): report an error if a pointer cast
23802 is used in a safe region.
23804 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
23805 pointer type casts in unsafe context.
23807 * codegen.cs (EmitContext): Set up IsUnsafe.
23809 * cs-parser.jay (non_expression_type): Add productions for pointer
23812 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
23813 code. We should not use force into static mode if the method is
23814 not virtual. Fixes bug in MIS
23816 * statement.cs (Do.Emit, While.Emit, For.Emit,
23817 Statement.EmitBoolExpression): Add support to Do and While to
23818 propagate infinite loop as `I do return' semantics.
23820 Improve the For case to also test for boolean constants.
23822 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
23823 to the list of attributes we can add.
23825 Remove `EmitContext' argument.
23827 * class.cs (Method.Define): Apply parameter attributes.
23828 (Constructor.Define): Apply parameter attributes.
23829 (MethodCore.LabelParameters): Move here the core of labeling
23832 * support.cs (ReflectionParameters.ParameterModifier,
23833 InternalParameters.ParameterModifier): Use IsByRef on the type and
23834 only return the OUT bit for these parameters instead of in/out/ref
23837 This is because I miss-understood things. The ParameterInfo.IsIn
23838 and IsOut represent whether the parameter has the [In] and [Out]
23841 2002-01-22 Miguel de Icaza <miguel@ximian.com>
23843 * ecore.cs (FieldExpr.Emit): Release temporaries.
23845 * assign.cs (LocalTemporary.Release): new function.
23847 * codegen.cs (EmitContext.GetTemporaryStorage,
23848 EmitContext.FreeTemporaryStorage): Rework the way we deal with
23849 temporary storage. Now we can "put back" localbuilders when we
23852 2002-01-21 Miguel de Icaza <miguel@ximian.com>
23854 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
23855 need to make a copy of the variable to generate verifiable code.
23857 2002-01-19 Miguel de Icaza <miguel@ximian.com>
23859 * driver.cs: Compute dynamically the system directory.
23861 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
23862 Slower, but more generally useful. Used by the abstract
23863 registering implementation.
23865 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
23866 the rules for the special rule on Type/instances. First check if
23867 we have the same name, and if so, try that special static path
23868 rather than the instance path.
23870 2002-01-18 Miguel de Icaza <miguel@ximian.com>
23872 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
23875 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
23876 Enum, ValueType, Delegate or Array for non-corlib compiles.
23878 * cs-tokenizer.cs: Catch long identifiers (645)
23880 * typemanager.cs (IndexerPropetyName): Ravi never tested this
23883 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
23884 fix, we were returning too early, so we were not registering
23885 pending methods from abstract classes.
23887 Do not register pending methods if the class is abstract.
23889 * expression.cs (Conditional.DoResolve): Report circular implicit
23890 conversions when we neecd to compute it for conditional
23893 (Is.DoResolve): If the expression is always of the provided type,
23894 flag warning 183. If the expression can not ever be of the
23895 provided type flag warning 184.
23897 * class.cs: Catch 169 as well.
23899 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
23902 2002-01-18 Nick Drochak <ndrochak@gol.com>
23904 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
23906 2002-01-17 Miguel de Icaza <miguel@ximian.com>
23908 * interface.cs: (PopulateMethod): Check for pointers being defined
23909 only if the unsafe context is active.
23910 (PopulateProperty): ditto.
23911 (PopulateIndexer): ditto.
23913 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
23914 specified. If pointers are present, make sure that they are
23915 present in an unsafe context.
23916 (Constructor, Constructor.Define): ditto.
23917 (Field, Field.Define): ditto.
23918 (Property, Property.Define): ditto.
23919 (Event, Event.Define): ditto.
23921 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
23922 hashtable if there are classes or structs defined.
23924 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23925 code, as the constant resolution moved.
23927 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
23928 the metadata, so we can flag error 133.
23930 * decl.cs (MemberCore.UnsafeOK): New function to test that a
23931 pointer is being declared in an unsafe context.
23933 2002-01-16 Miguel de Icaza <miguel@ximian.com>
23935 * modifiers.cs (Modifiers.Check): Require a Location argument.
23936 Report error 227 for Unsafe use.
23938 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
23940 * statement.cs (For.Emit): If the test is null, then report that
23941 we do `return', as we wont reach anything afterwards.
23943 (Switch.SwitchGoverningType): Track the expression that matched
23946 * driver.cs: Allow negative numbers as an error code to flag.
23948 * cs-parser.jay: Handle 1551.
23950 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
23952 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23954 * cs-parser.jay: Report 1518 (type declaration can only contain
23955 class, struct, interface, enum or delegate)
23957 (switch_label): Report 1523 (keywords `case' or `default' must
23960 (opt_switch_sections): Report 1522 (empty switch)
23962 * driver.cs: Report 1515 (response file specified multiple times)
23963 Report 1516 (Source file specified multiple times).
23965 * expression.cs (Argument.Resolve): Signal 1510
23967 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
23968 access not allowed in static code)
23970 2002-01-11 Ravi Pratap <ravi@ximian.com>
23972 * typemanager.cs (IsPointerType): Utility method which we are going
23975 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
23976 the object type, so we take care of that.
23978 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
23980 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
23981 added to non-params parameters :-)
23983 * typemanager.cs (CSharpName): Include 'void' type too.
23985 (void_ptr_type): Include in the set of core types.
23987 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
23990 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
23993 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
23994 completely forgotten about it.
23996 2002-01-10 Ravi Pratap <ravi@ximian.com>
23998 * cs-parser.jay (pointer_type): Add. This begins our implementation
23999 of parsing rules for unsafe code.
24001 (unsafe_statement): Implement.
24003 (embedded_statement): Modify to include the above.
24005 * statement.cs (Unsafe): Implement new class for unsafe blocks.
24007 * codegen.cs (EmitContext.InUnsafe): Add. This determines
24008 if the current context is an unsafe one.
24010 * cs-parser.jay (local_variable_pointer_type): Since local variable types
24011 are handled differently, we need separate rules for them.
24013 (local_variable_declaration): Update to use local_variable_pointer_type
24014 to allow variable declarations of unmanaged pointer types.
24016 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
24017 in unsafe contexts.
24019 * ../errors/cs0214.cs : Add.
24021 2002-01-16 Nick Drochak <ndrochak@gol.com>
24023 * makefile: remove 'response' file when cleaning.
24025 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24027 * cs-parser.jay: Report 1524.
24029 2002-01-14 Miguel de Icaza <miguel@ximian.com>
24031 * typemanager.cs (RegisterMethod): drop checking if we have
24032 registered this from here
24034 2002-01-12 Miguel de Icaza <miguel@ximian.com>
24036 * class.cs (Method.EmitDestructor): Implement calling our base
24039 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
24040 value of InFinally.
24042 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
24043 this routine and will wrap the call in a try/catch block. Deal
24046 2002-01-11 Miguel de Icaza <miguel@ximian.com>
24048 * ecore.cs (Expression.MemberLookup): instead of taking a
24049 parameter `same_type' that was used to tell whether we could
24050 access private members we compute our containing type from the
24053 (FieldExpr): Added partial support for volatile fields. This does
24054 not work for volatile fields exposed from assemblies, as I can not
24055 figure out how to extract the modreq from it.
24057 Updated all the source files to use this.
24059 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
24060 because it is referenced by MemberLookup very often.
24062 2002-01-09 Ravi Pratap <ravi@ximian.com>
24064 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
24065 TypeBuilder.GetCustomAttributes to retrieve what we need.
24067 Get rid of redundant default_member_attr_type as this is the same as
24068 default_member_type which already exists.
24070 * interface.cs, attribute.cs : Update accordingly.
24072 2002-01-08 Miguel de Icaza <miguel@ximian.com>
24074 * typemanager.cs: Enable IndexerPropertyName again. It does not
24075 work for TYpeBuilders though. Ravi, can you please fix this?
24077 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
24079 * expression.cs (Argument.Emit): Handle the case of ref objects
24080 being passed to ref functions;
24082 (ParameterReference.EmitLoad): Loads the content of the pointer
24083 without dereferencing.
24085 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24087 * cs-tokenizer.cs: Implemented the pre-processing expressions.
24089 2002-01-08 Ravi Pratap <ravi@ximian.com>
24091 * class.cs (Indexer.DefineMethod): Incorporate the interface
24092 type in the name of the method if we are doing explicit interface
24095 * expression.cs (ConversionExists): Remove as it is completely obsolete.
24097 (BetterConversion): Fix extremely trivial bug where we were referring to
24098 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
24101 * ../errors/bug16.cs : Add although we have fixed it.
24103 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24105 * expression.cs (BaseIndexer): Begin implementation.
24107 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
24109 * cs-parser.jay (indexer_declarator): Use qualified_identifier
24110 production directly to remove a shift/reduce, and implement
24111 explicit interface implementation.
24113 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
24114 after a floating point suffix.
24116 * expression.cs (DoNumericPromotions): Improved the conversion for
24117 uint/uint. If we have a constant, we avoid doing a typecast to a
24120 * class.cs (Indexer): Implement explicit interface implementation
24123 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
24125 * class.cs: make the default instance constructor public and hidebysig.
24127 2001-01-03 Ravi Pratap <ravi@ximian.com>
24129 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
24130 so we can call it from elsewhere.
24132 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
24133 we emit it internally if the class has a defined indexer; otherwise the user
24134 emits it by decorating the class definition with the DefaultMemberAttribute.
24136 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
24137 attribute is not used on a type which defines an indexer.
24139 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
24140 character when we skip whitespace.
24142 * ../errors/cs0646.cs : Add.
24144 2002-01-03 Miguel de Icaza <miguel@ximian.com>
24146 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
24149 * makefile: Add practical target `mcs3.exe' which builds the third
24150 generation compiler.
24152 * expression.cs (New): Fix structures constructor calling.
24154 * class.cs (Property, Method, Indexer): Emit Final flag on the
24155 method if we are an interface implementation and we are not
24158 * ecore.cs (PropertyExpr): New public field `IsBase', tells
24159 whether this property is referencing a `base' method.
24161 * expression.cs (Invocation.EmitCall): take an extra argument:
24162 is_base, this is used to determine whether the `call' or
24163 `callvirt' opcode should be used.
24166 * delegate.cs: update EmitCall.
24168 * class.cs (Method.Define): Set NewSlot for the cases where we are
24169 not implementing an interface method.
24171 (Property.Define): ditto.
24173 2002-01-02 Miguel de Icaza <miguel@ximian.com>
24175 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
24176 'r'. Allows mcs to parse itself fully.
24178 2002-01-02 Ravi Pratap <ravi@ximian.com>
24180 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
24181 of the number of initializers that require the InitializeArray method.
24183 (CheckIndices): Store the Expression in all cases - not the plain value. Also
24184 update the above field where necessary.
24186 (MakeByteBlob): Update accordingly.
24188 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
24191 (EmitDynamicInitializers): Update in accordance with the new optimization.
24193 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
24194 same OpCode applies.
24196 * cs-parser.jay : Fix some glaring errors I introduced.
24198 2002-01-01 Ravi Pratap <ravi@ximian.com>
24200 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
24201 so that we can check for name clashes there too.
24203 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
24204 for interface indexers.
24206 * interfaces.cs (Define): Emit the default member attribute.
24208 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
24209 variable was being referred to while setting the value ;-)
24211 2002-01-01 Miguel de Icaza <miguel@ximian.com>
24213 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
24214 byte-by-byte information when we know the data is zero.
24216 Make the block always a multiple of 4, because
24217 DefineInitializedData has a bug.
24219 * assign.cs: Fix, we should assign from the temporary, not from
24222 * expression.cs (MakeByteBlob): Fix my incorrect code.
24224 2001-12-31 Miguel de Icaza <miguel@ximian.com>
24226 * typemanager.cs (EnumToUnderlying): This function is used to get
24227 the underlying type from an enumeration, because it does not
24230 * constant.cs: Use the I4_S form for values between -128 and 127.
24232 * statement.cs (Block.LookupLabel): Looks up a label.
24233 (Block): Drop support for labeled blocks.
24235 (LabeledStatement): New kind of statement that represents a label
24238 (Goto): Finally implement this bad boy.
24240 * cs-parser.jay: Update to reflect new mechanism to implement
24243 2001-12-30 Miguel de Icaza <miguel@ximian.com>
24245 * codegen.cs (EmitContext.This): a codegen property that keeps the
24246 a single instance of this instead of creating many different this
24249 * delegate.cs (Delegate.DoResolve): Update to use the property;
24251 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
24253 * expression.cs (BaseAccess.DoResolve): Ditto.
24255 2001-12-29 Ravi Pratap <ravi@ximian.com>
24257 * typemanager.cs (methodimpl_attr_type): Add to hold the type
24258 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
24260 (InitCoreTypes): Update accordingly.
24262 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
24263 so we can quickly store the state.
24265 (ApplyAttributes): Set the correct implementation flags
24266 for InternalCall methods.
24268 2001-12-29 Miguel de Icaza <miguel@ximian.com>
24270 * expression.cs (EmitCall): if a method is not virtual, then do
24271 not use callvirt on it.
24273 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
24274 user defined stuff) requires the use of stobj, which takes an
24275 address on the stack instead of an array and an index. So emit
24276 the Ldelema operation for it.
24278 (EmitStoreOpcode): Use stobj for valuetypes.
24280 (UnaryMutator.EmitCode): Use the right 1 value depending on
24281 whether we are dealing with int64/uint64, float or doubles.
24283 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
24284 constructors that I implemented last night.
24286 (Constructor.IsDefault): Fix to work properly for static
24289 * cs-parser.jay (CheckDef): report method signature errors.
24290 Update error number 103 to be 132.
24292 * decl.cs: New AdditionResult enumeration value: MethodExists.
24293 Although we do this check for methods later on in the semantic
24294 analysis, catching repeated default constructors is so easy that
24295 we catch these here.
24297 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
24300 (ParameterReference.EmitAssign, Emit): handle
24303 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
24304 (ArrayAccess.EmitStoreOpcode): ditto.
24306 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
24308 * expression.cs (MakeByteBlob): Complete all the missing types
24309 (uint, short, ushort, byte, sbyte)
24311 * class.cs: Only init instance field initializers on instance
24314 Rename `constructors' to instance_constructors.
24316 (TypeContainer.AddConstructor): Only add constructors to the list
24317 if it is not static.
24319 Make sure that we handle default_static_constructor independently
24320 everywhere where we handle instance_constructors
24322 2001-12-28 Miguel de Icaza <miguel@ximian.com>
24324 * class.cs: Do not lookup or create a base initializer for a
24325 static constructor.
24327 (ConstructorInitializer.Resolve): use the proper type to lookup
24330 * cs-parser.jay: Report error 1585 (modifiers between type and name).
24332 * enum.cs, interface.cs: Remove CloseType, this is taken care by
24335 * decl.cs: CloseType is now an virtual method, the default
24336 implementation just closes this type.
24338 2001-12-28 Ravi Pratap <ravi@ximian.com>
24340 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
24341 to PreserveSig by default. Also emit HideBySig on such methods.
24343 Basically, set the defaults to standard values.
24345 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
24346 argument, if candidate is better, it can't be worse than the best !
24348 (Invocation): Re-write bits to differentiate between methods being
24349 applicable in their expanded form and their normal form - for params
24352 Get rid of use_standard everywhere as only standard conversions are allowed
24353 in overload resolution.
24355 More spec conformance.
24357 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24359 * driver.cs: Add --timestamp, to see where the compiler spends
24362 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
24363 `this' in static code.
24365 (SimpleName.DoResolve): Implement in terms of a helper function
24366 that allows static-references to be passed upstream to
24369 (Expression.ResolveWithSimpleName): Resolve specially simple
24370 names when called by MemberAccess to implement the special
24373 (Expression.ImplicitReferenceConversion): Handle conversions from
24374 Null to reference types before others, as Null's type is
24377 * expression.cs (Invocation.EmitCall): Handle the special case of
24378 calling methods declared on a reference type from a ValueType
24379 (Base classes System.Object and System.Enum)
24381 (MemberAccess.Resolve): Only perform lookups on Enumerations if
24382 the left hand side is a TypeExpr, not on every enumeration.
24384 (Binary.Resolve): If types are reference types, then do a cast to
24385 object on operators != and == of both arguments.
24387 * typemanager.cs (FindMembers): Extract instance and static
24388 members if requested.
24390 * interface.cs (PopulateProperty): Use void_type instead of null
24391 as the return type for the setter method.
24393 (PopulateIndexer): ditto.
24395 2001-12-27 Ravi Pratap <ravi@ximian.com>
24397 * support.cs (ReflectionParameters): Fix minor bug where we
24398 were examining the wrong parameter for the ParamArray attribute.
24400 Cope with requests for the type of the parameter at position
24401 greater than the params parameter's. We now return the element
24402 type of the params array as that makes more sense.
24404 * expression.cs (Invocation.IsParamsMethodApplicable): Update
24405 accordingly as we no longer have to extract the element type
24408 (Invocation.OverloadResolve): Update.
24410 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24412 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
24413 against IEnumerator, test whether the return value is a descendant
24414 of the IEnumerator interface.
24416 * class.cs (Indexer.Define): Use an auxiliary method to implement
24417 the other bits of the method definition. Begin support for
24418 explicit interface implementation.
24420 (Property.DefineMethod): Use TypeManager.void_type instead of null
24421 for an empty return value.
24423 2001-12-26 Miguel de Icaza <miguel@ximian.com>
24425 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
24426 dealing with a FieldExpr which is composed of a FieldBuilder, in
24427 the code path we did extract the constant, but we should have
24428 obtained the underlying value to be able to cast it (otherwise we
24429 end up in an infinite loop, this is what Ravi was running into).
24431 (ArrayCreation.UpdateIndices): Arrays might be empty.
24433 (MemberAccess.ResolveMemberAccess): Add support for section
24434 14.5.4.1 that deals with the special case of E.I when E is a type
24435 and something else, that I can be a reference to a static member.
24437 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
24438 handle a particular array type to create byte blobs, it is just
24439 something we dont generate byteblobs for.
24441 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
24444 * location.cs (Push): remove the key from the hashtable that we
24445 are about to add. This happens for empty files.
24447 * driver.cs: Dispose files after we have parsed them.
24449 (tokenize): new function that only runs the tokenizer on its
24450 input, for speed testing.
24452 2001-12-26 Ravi Pratap <ravi@ximian.com>
24454 * class.cs (Event.Define): Define the private field only if there
24455 are no accessors defined.
24457 * expression.cs (ResolveMemberAccess): If there is no associated
24458 field with the event, that means we have an event defined with its
24459 own accessors and we should flag error cs0070 since transforming
24460 ourselves into a field is not valid in that case.
24462 * ecore.cs (SimpleName.DoResolve): Same as above.
24464 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24465 and charset to sane values.
24467 2001-12-25 Ravi Pratap <ravi@ximian.com>
24469 * assign.cs (DoResolve): Perform check on events only if they
24470 are being accessed outside the declaring type.
24472 * cs-parser.jay (event_declarations): Update rules to correctly
24473 set the type of the implicit parameter etc.
24475 (add_accessor, remove_accessor): Set current local parameters.
24477 * expression.cs (Binary): For delegate addition and subtraction,
24478 cast the return value from the method into the appropriate delegate
24481 2001-12-24 Ravi Pratap <ravi@ximian.com>
24483 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24484 of these as the workaround is unnecessary.
24486 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24487 delegate data - none of that is needed at all.
24489 Re-write bits to extract the instance expression and the delegate method
24492 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24495 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24496 of attaching attributes instead of duplicating code everywhere.
24498 * everywhere : Update code to do attribute emission using the above method.
24500 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24502 * expression.cs (IsParamsMethodApplicable): if there are not
24503 parameters, return immediately.
24505 * ecore.cs: The 0 literal can be implicity converted to an enum
24508 (SimpleName.DoResolve): First lookup the type, then lookup the
24511 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24512 want to get its address. If the InstanceExpression is not
24513 addressable, store the result in a temporary variable, then get
24516 * codegen.cs: Only display 219 errors on warning level or above.
24518 * expression.cs (ArrayAccess): Make it implement the
24519 IMemoryLocation interface.
24521 (Binary.DoResolve): handle the operator == (object a, object b)
24522 and operator != (object a, object b) without incurring into a
24523 BoxedCast (because 5 != o should never be performed).
24525 Handle binary enumerator operators.
24527 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24528 value type, otherwise use Ldelem_ref.
24530 Use precomputed names;
24532 (AddressOf): Implement address of
24534 * cs-parser.jay (labeled_statement): Fix recursive block
24535 addition by reworking the production.
24537 * expression.cs (New.DoEmit): New has a special case:
24539 If we are dealing with a ValueType, we have a few
24540 situations to deal with:
24542 * The target of New is a ValueType variable, that is
24543 easy, we just pass this as the variable reference
24545 * The target of New is being passed as an argument,
24546 to a boxing operation or a function that takes a
24549 In this case, we need to create a temporary variable
24550 that is the argument of New.
24553 2001-12-23 Ravi Pratap <ravi@ximian.com>
24555 * rootcontext.cs (LookupType): Check that current_type is not null before
24556 going about looking at nested types.
24558 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24559 not implement the IAssignMethod interface any more.
24561 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24562 where we tranform them into FieldExprs if they are being resolved from within
24563 the declaring type.
24565 * ecore.cs (SimpleName.DoResolve): Do the same here.
24567 * assign.cs (DoResolve, Emit): Clean up code considerably.
24569 * ../errors/bug10.cs : Add.
24571 * ../errors/cs0070.cs : Add.
24573 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
24575 * assign.cs : Get rid of EventIsLocal everywhere.
24577 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24579 * ecore.cs (ConvertIntLiteral): finished the implementation.
24581 * statement.cs (SwitchLabel): Convert the value we are using as a
24582 key before looking up the table.
24584 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24586 * codegen.cs (EmitTopBlock): Require a Location argument now.
24588 * cs-parser.jay (constructor_declarator): We need to setup
24589 current_local_parameters before we parse the
24590 opt_constructor_initializer, to allow the variables to be bound
24591 to the constructor arguments.
24593 * rootcontext.cs (LookupType): First lookup nested classes in our
24594 class and our parents before we go looking outside our class.
24596 * expression.cs (ConstantFold): Extract/debox the values at the
24599 * rootcontext.cs (EmitCode): Resolve the constants first before we
24600 resolve the types. This is not really needed, but it helps debugging.
24602 * statement.cs: report location.
24604 * cs-parser.jay: pass location to throw statement.
24606 * driver.cs: Small bug fix.
24608 * report.cs: Updated format to be 4-zero filled digits.
24610 2001-12-22 Ravi Pratap <ravi@ximian.com>
24612 * expression.cs (CheckIndices): Fix minor bug where the wrong
24613 variable was being referred to ;-)
24615 (DoEmit): Do not call EmitStaticInitializers when the
24616 underlying type is System.Object.
24618 2001-12-21 Ravi Pratap <ravi@ximian.com>
24620 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
24621 and do the usual workaround for SRE.
24623 * class.cs (MyEventBuilder.EventType): New member to get at the type
24624 of the event, quickly.
24626 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
24628 * assign.cs (Assign.DoResolve): Handle the case when the target
24629 is an EventExpr and perform the necessary checks.
24631 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
24634 (SimpleName.MemberStaticCheck): Include check for EventExpr.
24636 (EventExpr): Set the type in the constructor itself since we
24637 are meant to be born fully resolved.
24639 (EventExpr.Define): Revert code I wrote earlier.
24641 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
24642 instance expression is null. The instance expression is a This in that case
24643 or a null, depending on whether it is a static method or not.
24645 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
24646 refers to more than one method.
24648 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
24649 and accordingly flag errors.
24651 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24653 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
24655 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24657 * location.cs (ToString): Provide useful rutine.
24659 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24661 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
24662 objects, return the actual integral boxed.
24664 * statement.cs (SwitchLabel): define an ILLabel for each
24667 (Switch.CheckSwitch): If the value is a Literal, extract
24668 the underlying literal.
24670 Also in the unused hashtable we had, add the SwitchLabel so we can
24671 quickly look this value up.
24673 * constant.cs: Implement a bunch of new constants. Rewrite
24674 Literal based on this. Made changes everywhere to adapt to this.
24676 * expression.cs (Expression.MakeByteBlob): Optimize routine by
24677 dereferencing array only once, and also copes with enumrations.
24679 bytes are two bytes wide, not one.
24681 (Cast): Perform constant conversions.
24683 * ecore.cs (TryImplicitIntConversion): Return literals instead of
24684 wrappers to the literals here.
24686 * expression.cs (DoNumericPromotions): long literals can converted
24687 to ulong implicity (this is taken care of elsewhere, but I was
24688 missing this spot).
24690 * ecore.cs (Expression.Literalize): Make the return type Literal,
24691 to improve type checking.
24693 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
24695 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24697 * literal.cs: Revert code from ravi that checked the bounds. The
24698 bounds are sane by the definition of the type itself.
24700 * typemanager.cs: Fix implementation of ImplementsInterface. We
24701 need to actually look up in our parent hierarchy for interfaces
24704 * const.cs: Use the underlying type for enumerations
24706 * delegate.cs: Compute the basename for the delegate creation,
24707 that should fix the delegate test case, and restore the correct
24708 Type Lookup semantics in rootcontext
24710 * rootcontext.cs: Revert Ravi's last patch. The correct way of
24711 referencing a nested type with the Reflection API is using the "+"
24714 * cs-parser.jay: Do not require EOF token at the end.
24716 2001-12-20 Ravi Pratap <ravi@ximian.com>
24718 * rootcontext.cs (LookupType): Concatenate type names with
24719 a '.' instead of a '+' The test suite passes again.
24721 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
24722 field of the enumeration.
24724 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
24725 the case when the member is an EventExpr.
24727 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
24728 static has an associated instance expression.
24730 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
24732 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
24734 * class.cs (Event.Define): Register event and perform appropriate checks
24737 We define the Add and Remove methods even if the use provides none because
24738 in that case, we provide default implementations ourselves.
24740 Define a private field of the type of the event. This is done by the CSC compiler
24741 and we should be doing it too ;-)
24743 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
24744 More methods we use in code we generate.
24746 (multicast_delegate_type, delegate_type): Two separate types since the distinction
24749 (InitCoreTypes): Update accordingly for the above.
24751 * class.cs (Event.Emit): Generate code for default accessors that we provide
24753 (EmitDefaultMethod): Do the job in the above.
24755 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
24758 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24760 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
24761 builders even if we were missing one.
24763 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
24764 pass the Basename as our class name instead of the Name. The
24765 basename will be correctly composed for us.
24767 * parameter.cs (Paramters): Now takes a Location argument.
24769 * decl.cs (DeclSpace.LookupType): Removed convenience function and
24770 make all the code call directly LookupType in RootContext and take
24771 this chance to pass the Location information everywhere.
24773 * Everywhere: pass Location information.
24775 2001-12-19 Miguel de Icaza <miguel@ximian.com>
24777 * class.cs (Constructor.Define): Updated way of detecting the
24778 length of the parameters.
24780 (TypeContainer.DefineType): Use basename as the type name for
24783 (TypeContainer.Define): Do not recursively define types here, as
24784 definition is taken care in order by the RootContext.
24786 * tree.cs: Keep track of namespaces in a per-file basis.
24788 * parameter.cs (Parameter.ComputeSignature): Update to use
24791 (Parameters.GetSignature): ditto.
24793 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
24794 instead of a TypeContainer.
24796 (Interface.SemanticAnalysis): Use `this' instead of our parent to
24797 resolve names. Because we need to be resolve in our context, not
24800 * driver.cs: Implement response files.
24802 * class.cs (TypeContainer.DefineType): If we are defined, do not
24803 redefine ourselves.
24805 (Event.Emit): Emit the code for add/remove handlers.
24806 (Event.Define): Save the MethodBuilders for add/remove.
24808 * typemanager.cs: Use pair here too.
24810 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
24811 DictionaryEntry requires the first argument to be non-null.
24813 (enum_declaration): Compute full name for registering the
24816 (delegate_declaration): Instead of using
24817 formal_parameter_list, use opt_formal_parameter_list as the list
24820 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
24821 (EventParsing): New property that controls whether `add' and
24822 `remove' are returned as tokens or identifiers (for events);
24824 2001-12-19 Ravi Pratap <ravi@ximian.com>
24826 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
24827 use MyEventBuilder only and let it wrap the real builder for us.
24829 (MyEventBuilder): Revamp constructor etc.
24831 Implement all operations that we perform on EventBuilder in precisely the same
24834 (FindMembers): Update to use the EventBuilder member.
24836 (Event.Emit): Update accordingly.
24838 2001-12-18 Ravi Pratap <ravi@ximian.com>
24840 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
24841 by calling the appropriate methods.
24843 (GetCustomAttributes): Make stubs as they cannot possibly do anything
24846 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
24848 2001-12-17 Ravi Pratap <ravi@ximian.com>
24850 * delegate.cs (Delegate.Populate): Check that the return type
24851 and various parameters types are indeed accessible.
24853 * class.cs (Constructor.Define): Same here.
24855 (Field.Define): Ditto.
24857 (Event.Define): Ditto.
24859 (Operator.Define): Check that the underlying Method defined itself
24860 correctly - so it's MethodBuilder should not be null.
24862 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
24863 expression happens to be null.
24865 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
24866 members but as of now we don't seem to be able to do anything really useful with it.
24868 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
24869 not the EventBuilder.
24871 2001-12-18 Miguel de Icaza <miguel@ximian.com>
24873 * cs-tokenizer.cs: Add support for defines.
24874 Add support for #if, #elif, #else, #endif
24876 (eval_var): evaluates a variable.
24877 (eval): stubbed for evaluating functions.
24879 * cs-parser.jay: Pass the defines information
24881 * driver.cs: Add --define command line option.
24883 * decl.cs: Move MemberCore here.
24885 Make it the base class for DeclSpace. This allows us to catch and
24886 report 108 and 109 for everything now.
24888 * class.cs (TypeContainer.Define): Extract all the members
24889 before populating and emit the warning 108 (new keyword required
24890 to override) instead of having each member implement this.
24892 (MemberCore.Define): New abstract method, we will be using this in
24893 the warning reporting engine in Populate.
24895 (Operator.Define): Adjust to new MemberCore protocol.
24897 * const.cs (Const): This does not derive from Expression, it is a
24898 temporary object we use to create fields, it is a MemberCore.
24900 * class.cs (Method.Define): Allow the entry point to be in a
24903 * driver.cs: Rewrite the argument handler to clean it up a bit.
24905 * rootcontext.cs: Made it just an auxiliary namespace feature by
24906 making everything static.
24908 * driver.cs: Adapt code to use RootContext type name instead of
24911 * delegate.cs: Remove RootContext argument.
24913 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
24916 * class.cs (Event.Define): The lookup can fail.
24918 * cs-tokenizer.cs: Begin implementation of pre-procesor.
24920 * expression.cs: Resolve the this instance before invoking the code.
24922 2001-12-17 Miguel de Icaza <miguel@ximian.com>
24924 * cs-parser.jay: Add a production in element_access that allows
24925 the thing to become a "type" reference. This way we can parse
24926 things like "(string [])" as a type.
24928 Note that this still does not handle the more complex rules of
24932 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
24934 * ecore.cs: (CopyNewMethods): new utility function used to
24935 assemble the list of methods from running FindMembers.
24937 (MemberLookup): Rework FindMembers so that
24939 2001-12-16 Miguel de Icaza <miguel@ximian.com>
24941 * class.cs (TypeContainer): Remove Delegates who fail to be
24944 * delegate.cs (Populate): Verify that we dont get null return
24945 values. TODO: Check for AsAccessible.
24947 * cs-parser.jay: Use basename to emit error 574 (destructor should
24948 have the same name as container class), not the full name.
24950 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
24951 possible representation.
24953 Also implements integer type suffixes U and L.
24955 2001-12-15 Miguel de Icaza <miguel@ximian.com>
24957 * expression.cs (ArrayCreation.DoResolve): We need to do the
24958 argument resolution *always*.
24960 * decl.cs: Make this hold the namespace. Hold the root context as
24962 (LookupType): Move here.
24964 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
24966 * location.cs (Row, Name): Fixed the code, it was always returning
24967 references to the first file.
24969 * interface.cs: Register properties defined through interfaces.
24971 * driver.cs: Add support for globbing on the command line
24973 * class.cs (Field): Make it derive from MemberCore as well.
24976 2001-12-15 Ravi Pratap <ravi@ximian.com>
24978 * class.cs (Event::Define): Check that the type of the event is a delegate
24979 type else flag error #66.
24981 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
24984 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
24985 values of EntryPoint, CharSet etc etc.
24987 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
24989 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
24990 be null and we should ignore this. I am not sure if this is really clean. Apparently,
24991 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
24992 which needs this to do its work.
24994 * ../errors/cs0066.cs : Add.
24996 2001-12-14 Miguel de Icaza <miguel@ximian.com>
24998 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
25001 * class.cs: (MethodSignature.MethodSignature): Removed hack that
25002 clears out the parameters field.
25003 (MemberSignatureCompare): Cleanup
25005 (MemberCore): New base class used to share code between MethodCore
25008 (RegisterRequiredImplementations) BindingFlags.Public requires
25009 either BindingFlags.Instace or Static. Use instance here.
25011 (Property): Refactored code to cope better with the full spec.
25013 * parameter.cs (GetParameterInfo): Return an empty array instead
25016 * class.cs (Property): Abstract or extern properties have no bodies.
25018 * parameter.cs (GetParameterInfo): return a zero-sized array.
25020 * class.cs (TypeContainer.MethodModifiersValid): Move all the
25021 method modifier validation to the typecontainer so we can reuse
25022 this on properties.
25024 (MethodCore.ParameterTypes): return an empty sized array of types.
25026 (Property.Define): Test property modifier validity.
25028 Add tests for sealed/override too.
25030 (Method.Emit): abstract or extern methods have no bodies.
25032 2001-12-14 Ravi Pratap <ravi@ximian.com>
25034 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
25037 (Method::Define, ::Emit): Modify accordingly.
25039 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
25041 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
25043 * makefile: Pass in /unsafe.
25045 2001-12-13 Miguel de Icaza <miguel@ximian.com>
25047 * class.cs (MakeKey): Kill routine.
25049 * class.cs (TypeContainer.Define): Correctly define explicit
25050 method implementations (they require the full interface name plus
25053 * typemanager.cs: Deply the PtrHashtable here and stop using the
25054 lame keys. Things work so much better.
25056 This of course broke everyone who depended on `RegisterMethod' to
25057 do the `test for existance' test. This has to be done elsewhere.
25059 * support.cs (PtrHashtable): A hashtable that avoid comparing with
25060 the object stupid Equals method (because, that like fails all over
25061 the place). We still do not use it.
25063 * class.cs (TypeContainer.SetRequiredInterface,
25064 TypeContainer.RequireMethods): Killed these two routines and moved
25065 all the functionality to RegisterRequiredImplementations.
25067 (TypeContainer.RegisterRequiredImplementations): This routine now
25068 registers all the implementations required in an array for the
25069 interfaces and abstract methods. We use an array of structures
25070 which can be computed ahead of time to reduce memory usage and we
25071 also assume that lookups are cheap as most classes will not
25072 implement too many interfaces.
25074 We also avoid creating too many MethodSignatures.
25076 (TypeContainer.IsInterfaceMethod): Update and optionally does not
25077 clear the "pending" bit if we find that there are problems with
25080 (TypeContainer.VerifyPendingMethods): Update to report errors of
25081 methods that look like implementations but are not.
25083 (TypeContainer.Define): Add support for explicit interface method
25086 2001-12-12 Miguel de Icaza <miguel@ximian.com>
25088 * typemanager.cs: Keep track of the parameters here instead of
25089 being a feature of the TypeContainer.
25091 * class.cs: Drop the registration of parameters here, as
25092 InterfaceMethods are also interface declarations.
25094 * delegate.cs: Register methods with the TypeManager not only with
25095 the TypeContainer. This code was buggy.
25097 * interface.cs: Full registation here.
25099 2001-12-11 Miguel de Icaza <miguel@ximian.com>
25101 * expression.cs: Remove reducer for binary expressions, it can not
25104 * const.cs: Put here the code that used to go into constant.cs
25106 * constant.cs: Put here the code for constants, this is a new base
25107 class for Literals.
25109 * literal.cs: Make Literal derive from Constant.
25111 2001-12-09 Miguel de Icaza <miguel@ximian.com>
25113 * statement.cs (Return.Emit): Report error 157 if the user
25114 attempts to return from a finally block.
25116 (Return.Emit): Instead of emitting a return, jump to the end of
25119 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
25120 LocalBuilder to store the result of the function. ReturnLabel is
25121 the target where we jump.
25124 2001-12-09 Radek Doulik <rodo@ximian.com>
25126 * cs-parser.jay: remember alias in current namespace
25128 * ecore.cs (SimpleName::DoResolve): use aliases for types or
25131 * class.cs (LookupAlias): lookup alias in my_namespace
25133 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
25135 (LookupAlias): lookup alias in this and if needed in parent
25138 2001-12-08 Miguel de Icaza <miguel@ximian.com>
25142 * rootcontext.cs: (ModuleBuilder) Made static, first step into
25143 making things static. I need this to avoid passing the
25144 TypeContainer when calling ParameterType.
25146 * support.cs (InternalParameters.ParameterType): Remove ugly hack
25147 that did string manipulation to compute the type and then call
25148 GetType. Use Parameter.ParameterType instead.
25150 * cs-tokenizer.cs: Consume the suffix for floating values.
25152 * expression.cs (ParameterReference): figure out whether this is a
25153 reference parameter or not. Kill an extra variable by computing
25154 the arg_idx during emission.
25156 * parameter.cs (Parameters.GetParameterInfo): New overloaded
25157 function that returns whether a parameter is an out/ref value or not.
25159 (Parameter.ParameterType): The type of the parameter (base,
25160 without ref/out applied).
25162 (Parameter.Resolve): Perform resolution here.
25163 (Parameter.ExternalType): The full type (with ref/out applied).
25165 * statement.cs (Using.Emit, Using.EmitExpression): Implement
25166 support for expressions on the using statement.
25168 2001-12-07 Miguel de Icaza <miguel@ximian.com>
25170 * statement.cs (Using.EmitLocalVariableDecls): Split the
25171 localvariable handling of the using statement.
25173 (Block.EmitMeta): Keep track of variable count across blocks. We
25174 were reusing slots on separate branches of blocks.
25176 (Try.Emit): Emit the general code block, we were not emitting it.
25178 Check the type of the declaration to be an IDisposable or
25179 something that can be implicity converted to it.
25181 Emit conversions if required.
25183 * ecore.cs (EmptyExpression): New utility class.
25184 (Expression.ImplicitConversionExists): New utility function.
25186 2001-12-06 Miguel de Icaza <miguel@ximian.com>
25188 * statement.cs (Using): Implement.
25190 * expression.cs (LocalVariableReference): Support read only variables.
25192 * statement.cs: Remove the explicit emit for the Leave opcode.
25193 (VariableInfo): Add a readonly field.
25195 2001-12-05 Miguel de Icaza <miguel@ximian.com>
25197 * ecore.cs (ConvCast): new class used to encapsulate the various
25198 explicit integer conversions that works in both checked and
25199 unchecked contexts.
25201 (Expression.ConvertNumericExplicit): Use new ConvCast class to
25202 properly generate the overflow opcodes.
25204 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25206 * statement.cs: The correct type for the EmptyExpression is the
25207 element_type, not the variable type. Ravi pointed this out.
25209 2001-12-04 Ravi Pratap <ravi@ximian.com>
25211 * class.cs (Method::Define): Handle PInvoke methods specially
25212 by using DefinePInvokeMethod instead of the usual one.
25214 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
25215 above to do the task of extracting information and defining the method.
25217 2001-12-04 Ravi Pratap <ravi@ximian.com>
25219 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
25220 of the condition for string type.
25222 (Emit): Move that here.
25224 (ArrayCreation::CheckIndices): Keep string literals in their expression
25227 (EmitDynamicInitializers): Handle strings appropriately.
25229 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25231 * codegen.cs (EmitContext): Replace multiple variables with a
25232 single pointer to the current Switch statement.
25234 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
25237 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25241 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
25244 (Foreach.Emit): Foreach on arrays was not setting
25245 up the loop variables (for break/continue).
25247 (GotoCase): Semi-implented.
25249 2001-12-03 Ravi Pratap <ravi@ximian.com>
25251 * attribute.cs (CheckAttribute): Handle system attributes by using
25252 Attribute.GetAttributes to examine information we need.
25254 (GetValidPlaces): Same here.
25256 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
25258 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
25260 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
25262 (Method::Define): Set appropriate flags if we have a DllImport attribute.
25264 (Method::Emit): Handle the case when we are a PInvoke method.
25266 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25268 * expression.cs: Use ResolveWithSimpleName on compound names.
25270 2001-12-02 Ravi Pratap <ravi@ximian.com>
25272 * constant.cs (EmitConstant): Make sure we resolve the associated expression
25273 before trying to reduce it.
25275 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
25277 * constant.cs (LookupConstantValue): Implement.
25279 (EmitConstant): Use the above in emitting the constant.
25281 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
25282 that are user-defined by doing a LookupConstantValue on them.
25284 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
25287 2001-11-29 Miguel de Icaza <miguel@ximian.com>
25289 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
25291 (BaseAccess.DoResolve): Implement.
25293 (MemberAccess.DoResolve): Split this routine into a
25294 ResolveMemberAccess routine that can be used independently
25296 2001-11-28 Miguel de Icaza <miguel@ximian.com>
25298 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
25299 As that share bits of the implementation. Is returns a boolean,
25300 while As returns the Type that is being probed.
25302 2001-12-01 Ravi Pratap <ravi@ximian.com>
25304 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
25305 instead of a Literal - much easier.
25307 (EnumInTransit): Remove - utterly useless :-)
25309 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
25311 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
25313 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
25314 chain when we have no associated expression.
25316 2001-11-30 Ravi Pratap <ravi@ximian.com>
25318 * constant.cs (Define): Use Location while reporting the errror.
25320 Also emit a warning when 'new' is used and there is no inherited
25323 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
25326 (LookupEnumValue): Implement to lookup an enum member's value and define it
25329 (Populate): Re-write accordingly to use the above routine.
25331 2001-11-27 Miguel de Icaza <miguel@ximian.com>
25333 * expression.cs (This): Fix prototype for DoResolveLValue to
25334 override the base class DoResolveLValue.
25336 * cs-parser.cs: Report errors cs574 and cs575 (destructor
25339 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
25340 (we need to load the address of the field here). This fixes
25343 (FieldExpr.DoResolveLValue): Call the DoResolve
25344 function to initialize the Instance expression.
25346 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
25347 correctly the GetEnumerator operation on a value type.
25349 * cs-parser.jay: Add more simple parsing error catches.
25351 * statement.cs (Switch): Add support for string switches.
25352 Handle null specially.
25354 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
25356 2001-11-28 Ravi Pratap <ravi@ximian.com>
25358 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
25360 (declare_local_constant): New helper function.
25362 * statement.cs (AddConstant): Keep a separate record of constants
25364 (IsConstant): Implement to determine if a variable is a constant.
25366 (GetConstantExpression): Implement.
25368 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
25370 * statement.cs (IsVariableDefined): Re-write.
25372 2001-11-27 Ravi Pratap <ravi@ximian.com>
25374 * class.cs (TypeContainer::FindMembers): Look for constants
25375 in the case when we are looking for MemberTypes.Field
25377 * expression.cs (MemberAccess::DoResolve): Check that in the
25378 case we are a FieldExpr and a Literal, we are not being accessed
25379 by an instance reference.
25381 * cs-parser.jay (local_constant_declaration): Implement.
25383 (declaration_statement): Implement for constant declarations.
25385 2001-11-26 Miguel de Icaza <miguel@ximian.com>
25387 * statement.cs (Switch): Catch double defaults.
25389 (Switch): More work on the switch() statement
25390 implementation. It works for integral values now, need to finish
25394 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25396 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
25397 integer literals into other integer literals. To be used by
25400 2001-11-24 Ravi Pratap <ravi@ximian.com>
25402 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
25405 (EmitDynamicInitializers): Cope with the above since we extract data
25406 directly from ArrayData now.
25408 (ExpectInitializers): Keep track of whether initializers are mandatory
25411 (Bounds): Make it a hashtable to prevent the same dimension being
25412 recorded for every element in that dimension.
25414 (EmitDynamicInitializers): Fix bug which prevented the Set array method
25417 Also fix bug which was causing the indices to be emitted in the reverse
25420 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25422 * expression.cs (ArrayCreation): Implement the bits that Ravi left
25423 unfinished. They do not work, because the underlying code is
25426 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25428 * cs-parser.jay: Remove bogus fixme.
25430 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
25431 on Switch statement.
25433 2001-11-23 Ravi Pratap <ravi@ximian.com>
25435 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
25438 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
25439 parameter. Apparently, any expression is allowed.
25441 (ValidateInitializers): Update accordingly.
25443 (CheckIndices): Fix some tricky bugs thanks to recursion.
25445 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
25446 I was being completely brain-dead.
25448 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
25449 and re-write acordingly.
25451 (DelegateInvocation): Re-write accordingly.
25453 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25455 (MakeByteBlob): Handle types more correctly.
25457 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25458 initialization from expressions but it is incomplete because I am a complete
25461 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25463 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25464 on If. Basically, we have to return `true' (ie, we do return to
25465 our caller) only if both branches of the if return.
25467 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25468 short-circuit operators, handle them as short circuit operators.
25470 (Cast.DoResolve): Resolve type.
25471 (Cast.Cast): Take an expression as the target type.
25473 * cs-parser.jay (cast_expression): Remove old hack that only
25474 allowed a limited set of types to be handled. Now we take a
25475 unary_expression and we resolve to a type during semantic
25478 Use the grammar productions from Rhys to handle casts (this is
25479 not complete like Rhys syntax yet, we fail to handle that corner
25480 case that C# has regarding (-x), but we will get there.
25482 2001-11-22 Ravi Pratap <ravi@ximian.com>
25484 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25485 field which is an array type.
25487 * cs-parser.jay (declare_local_variables): Support array initialization too.
25489 * typemanager.cs (MakeKey): Implement.
25491 (everywhere): Use the above appropriately.
25493 * cs-parser.jay (for_statement): Update for array initialization while
25494 declaring variables.
25496 * ecore.cs : The error message was correct, it's the variable's names that
25497 were misleading ;-) Make the code more readable.
25499 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25500 the correct type etc.
25502 (ConvertExplicit): Handle Enum types by examining the underlying type.
25504 2001-11-21 Ravi Pratap <ravi@ximian.com>
25506 * parameter.cs (GetCallingConvention): Always return
25507 CallingConventions.Standard for now.
25509 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25511 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25512 and `r' after calling DoNumericPromotions.
25514 * ecore.cs: Fix error message (the types were in the wrong order).
25516 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25517 BindingFlags.Instance as well
25519 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25520 implicit int literal conversion in an empty cast so that we
25521 propagate the right type upstream.
25523 (UnboxCast): new class used to unbox value types.
25524 (Expression.ConvertExplicit): Add explicit type conversions done
25527 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25528 the target type before applying the implicit LongLiterals to ULong
25531 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25533 * cs-parser.jay (for_statement): Reworked the way For works: now
25534 we declare manually any variables that are introduced in
25535 for_initializer to solve the problem of having out-of-band code
25536 emition (that is what got for broken).
25538 (declaration_statement): Perform the actual variable declaration
25539 that used to be done in local_variable_declaration here.
25541 (local_variable_declaration): Do not declare anything, just pass
25542 the information on a DictionaryEntry
25544 2001-11-20 Ravi Pratap <ravi@ximian.com>
25546 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25547 re-write of the logic to now make it recursive.
25549 (UpdateIndices): Re-write accordingly.
25551 Store element data in a separate ArrayData list in the above methods.
25553 (MakeByteBlob): Implement to dump the array data into a byte array.
25555 2001-11-19 Ravi Pratap <ravi@ximian.com>
25557 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25560 * constant.cs (Define): Implement.
25562 (EmitConstant): Re-write fully.
25564 Pass in location info.
25566 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25569 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25570 DictionaryEntry since we need location info too.
25572 (constant_declaration): Update accordingly.
25574 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
25575 code into another method : UpdateIndices.
25577 2001-11-18 Ravi Pratap <ravi@ximian.com>
25579 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
25580 some type checking etc.
25582 2001-11-17 Ravi Pratap <ravi@ximian.com>
25584 * expression.cs (ArrayCreation::ValidateInitializers): Implement
25585 bits to provide dimension info if the user skips doing that.
25587 Update second constructor to store the rank correctly.
25589 2001-11-16 Ravi Pratap <ravi@ximian.com>
25591 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
25592 and try to implement.
25594 * ../errors/cs0150.cs : Add.
25596 * ../errors/cs0178.cs : Add.
25598 2001-11-16 Miguel de Icaza <miguel@ximian.com>
25600 * statement.cs: Implement foreach on multi-dimensional arrays.
25602 * parameter.cs (Parameters.GetParameterByName): Also lookup the
25603 name of the params argument.
25605 * expression.cs: Use EmitStoreOpcode to get the right opcode while
25606 initializing the array.
25608 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
25609 we can use this elsewhere.
25611 * statement.cs: Finish implementation of foreach for single
25614 * cs-parser.jay: Use an out-of-band stack to pass information
25615 around, I wonder why I need this.
25617 foreach_block: Make the new foreach_block the current_block.
25619 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
25620 function used to return a static Parameters structure. Used for
25621 empty parameters, as those are created very frequently.
25623 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
25625 2001-11-15 Ravi Pratap <ravi@ximian.com>
25627 * interface.cs : Default modifier is private, not public. The
25628 make verify test passes again.
25630 2001-11-15 Ravi Pratap <ravi@ximian.com>
25632 * support.cs (ReflectionParameters): Fix logic to determine
25633 whether the last parameter is a params one. Test 9 passes again.
25635 * delegate.cs (Populate): Register the builders we define with
25636 RegisterParameterForBuilder. Test 19 passes again.
25638 * cs-parser.jay (property_declaration): Reference $6 instead
25639 of $$ to get at the location.
25641 (indexer_declaration): Similar stuff.
25643 (attribute): Ditto.
25645 * class.cs (Property): Register parameters for the Get and Set methods
25646 if they exist. Test 23 passes again.
25648 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
25649 call to EmitArguments as we are sure there aren't any params arguments.
25650 Test 32 passes again.
25652 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
25653 IndexOutOfRangeException.
25655 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
25656 Test 33 now passes again.
25658 2001-11-15 Miguel de Icaza <miguel@ximian.com>
25660 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
25661 broke a bunch of things. Will have to come up with a better way
25662 of tracking locations.
25664 * statement.cs: Implemented foreach for single dimension arrays.
25666 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25668 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
25669 an error. This removes the lookup from the critical path.
25671 * cs-parser.jay: Removed use of temporary_loc, which is completely
25674 2001-11-14 Miguel de Icaza <miguel@ximian.com>
25676 * support.cs (ReflectionParameters.ParameterModifier): Report
25677 whether the argument is a PARAMS argument or not.
25679 * class.cs: Set the attribute `ParamArrayAttribute' on the
25680 parameter argument.
25682 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
25683 and cons_param_array_attribute (ConstructorInfo for
25684 ParamArrayAttribute).,
25686 * codegen.cs: Emit the return using the `Return' statement, that
25687 way we can report the error correctly for missing return values.
25689 * class.cs (Method.Emit): Clean up.
25691 * expression.cs (Argument.Resolve): Take another argument: the
25692 location where this argument is used. Notice that this is not
25693 part of the "Argument" class as to reduce the size of the
25694 structure (we know the approximate location anyways).
25696 Test if the argument is a variable-reference, if not, then
25697 complain with a 206.
25699 (Argument.Emit): Emit addresses of variables.
25701 (Argument.FullDesc): Simplify.
25703 (Invocation.DoResolve): Update for Argument.Resolve.
25705 (ElementAccess.DoResolve): ditto.
25707 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
25708 method should be virtual, as this method is always virtual.
25710 (NewDelegate.DoResolve): Update for Argument.Resolve.
25712 * class.cs (ConstructorInitializer.DoResolve): ditto.
25714 * attribute.cs (Attribute.Resolve): ditto.
25716 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25718 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
25720 * expression.cs (ParameterReference): Drop IStackStorage and implement
25721 IAssignMethod instead.
25723 (LocalVariableReference): ditto.
25725 * ecore.cs (FieldExpr): Drop IStackStorage and implement
25726 IAssignMethod instead.
25728 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25730 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
25731 enumerations that are used in heavily used structures derive from
25732 byte in a laughable and pathetic attempt to reduce memory usage.
25733 This is the kind of pre-optimzations that you should not do at
25734 home without adult supervision.
25736 * expression.cs (UnaryMutator): New class, used to handle ++ and
25737 -- separatedly from the other unary operators. Cleans up the
25738 code, and kills the ExpressionStatement dependency in Unary.
25740 (Unary): Removed `method' and `Arguments' from this class, making
25741 it smaller, and moving it all to SimpleCall, so I can reuse this
25742 code in other locations and avoid creating a lot of transient data
25743 strucutres when not required.
25745 * cs-parser.jay: Adjust for new changes.
25747 2001-11-11 Miguel de Icaza <miguel@ximian.com>
25749 * enum.cs (Enum.Populate): If there is a failure during
25752 * cs-parser.jay (opt_enum_base): we used to catch type errors
25753 here, but this is really incorrect. The type error should be
25754 catched during semantic analysis.
25756 2001-12-11 Ravi Pratap <ravi@ximian.com>
25758 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
25759 current_local_parameters as expected since I, in my stupidity, had forgotten
25762 * attribute.cs (GetValidPlaces): Fix stupid bug.
25764 * class.cs (Method::Emit): Perform check on applicability of attributes.
25766 (Constructor::Emit): Ditto.
25768 (Field::Emit): Ditto.
25770 (Field.Location): Store location information.
25772 (Property, Event, Indexer, Operator): Ditto.
25774 * cs-parser.jay (field_declaration): Pass in location for each field.
25776 * ../errors/cs0592.cs : Add.
25778 2001-11-12 Ravi Pratap <ravi@ximian.com>
25780 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
25782 (InitCoreTypes): Update accordingly.
25784 (RegisterAttrType, LookupAttr): Implement.
25786 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
25787 info about the same.
25789 (Resolve): Update to populate the above as necessary.
25791 (Error592): Helper.
25793 (GetValidPlaces): Helper to the above.
25795 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
25797 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
25799 2001-11-12 Ravi Pratap <ravi@ximian.com>
25801 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
25803 * ../errors/cs0617.cs : Add.
25805 2001-11-11 Ravi Pratap <ravi@ximian.com>
25807 * enum.cs (Emit): Rename to Populate to be more consistent with what
25808 we expect it to do and when exactly it is called.
25810 * class.cs, rootcontext.cs : Update accordingly.
25812 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
25813 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
25815 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
25817 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
25818 of a fieldinfo using the above, when dealing with a FieldBuilder.
25820 2001-11-10 Ravi Pratap <ravi@ximian.com>
25822 * ../errors/cs0031.cs : Add.
25824 * ../errors/cs1008.cs : Add.
25826 * ../errrors/cs0543.cs : Add.
25828 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
25831 (FindMembers): Implement.
25833 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
25834 enums and delegates too.
25836 (enum_types): Rename to builder_to_enum.
25838 (delegate_types): Rename to builder_to_delegate.
25840 * delegate.cs (FindMembers): Implement.
25842 2001-11-09 Ravi Pratap <ravi@ximian.com>
25844 * typemanager.cs (IsEnumType): Implement.
25846 * enum.cs (Emit): Re-write parts to account for the underlying type
25847 better and perform checking etc.
25849 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
25850 of the underlying type.
25852 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
25855 * enum.cs (error31): Helper to report error #31.
25857 * cs-parser.jay (enum_declaration): Store location of each member too.
25859 * enum.cs (member_to_location): New hashtable.
25861 (AddEnumMember): Update location hashtable.
25863 (Emit): Use the location of each member while reporting errors.
25865 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25867 * cs-parser.jay: A for_initializer if is a
25868 local_variable_declaration really ammount to have an implicit
25869 block with the variable declaration and no initializer for for.
25871 * statement.cs (For.Emit): Cope with null initializers.
25873 This fixes the infinite loop on for initializers.
25875 2001-11-08 Miguel de Icaza <miguel@ximian.com>
25877 * enum.cs: More cleanup.
25879 * ecore.cs: Remove dead code.
25881 * class.cs (Property.Emit): More simplification.
25882 (Event.Emit): ditto.
25884 Reworked to have less levels of indentation.
25886 2001-11-08 Ravi Pratap <ravi@ximian.com>
25888 * class.cs (Property): Emit attributes.
25898 * enum.cs (Emit): Ditto.
25900 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
25903 * class.cs (Field, Event, etc.): Move attribute generation into the
25904 Emit method everywhere.
25906 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
25907 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
25908 as we had no way of defining nested enums !
25910 * rootcontext.cs : Adjust code accordingly.
25912 * typemanager.cs (AddEnumType): To keep track of enum types separately.
25914 2001-11-07 Ravi Pratap <ravi@ximian.com>
25916 * expression.cs (EvalConstantExpression): Move into ecore.cs
25918 * enum.cs (Enum): Rename some members and make them public and readonly
25919 according to our convention.
25921 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
25924 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25926 (Enum::Emit): Write a simple version for now which doesn't try to compute
25927 expressions. I shall modify this to be more robust in just a while.
25929 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
25931 (TypeContainer::CloseType): Create the Enum types too.
25933 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
25935 * expression.cs (EvalConstantExpression): Get rid of completely.
25937 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
25938 user-defined values and other cases.
25940 (IsValidEnumLiteral): Helper function.
25942 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
25943 out there in the case we had a literal FieldExpr.
25945 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
25947 (Literalize): Revamp a bit to take two arguments.
25949 (EnumLiteral): New class which derives from Literal to wrap enum literals.
25951 2001-11-06 Ravi Pratap <ravi@ximian.com>
25953 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
25955 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
25957 (Resolve): Use the above to ensure we have proper initializers.
25959 2001-11-05 Ravi Pratap <ravi@ximian.com>
25961 * expression.cs (Expression::EvalConstantExpression): New method to
25962 evaluate constant expressions.
25964 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
25966 2001-11-07 Miguel de Icaza <miguel@ximian.com>
25968 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
25971 (Binary.ResolveOperator): Handle operator != (object a, object b)
25972 and operator == (object a, object b);
25974 (Binary.DoNumericPromotions): Indicate whether the numeric
25975 promotion was possible.
25977 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
25980 Made the ArrayAccess implement interface IAssignMethod instead of
25981 IStackStore as the order in which arguments are passed reflects
25984 * assign.cs: Instead of using expr.ExprClass to select the way of
25985 assinging, probe for the IStackStore/IAssignMethod interfaces.
25987 * typemanager.cs: Load InitializeArray definition.
25989 * rootcontext.cs (RootContext.MakeStaticData): Used to define
25990 static data that can be used to initialize arrays.
25992 2001-11-05 Miguel de Icaza <miguel@ximian.com>
25994 * expression.cs: Handle operator== and operator!= for booleans.
25996 (Conditioal.Reduce): Implement reducer for the ?: operator.
25998 (Conditional.Resolve): Implement dead code elimination.
26000 (Binary.Resolve): Catch string literals and return a new
26001 concatenated string.
26003 (Unary.Reduce): Implement reduction of unary expressions.
26005 * ecore.cs: Split out the expression core handling here.
26007 (Expression.Reduce): New method used to perform constant folding
26008 and CSE. This is needed to support constant-expressions.
26010 * statement.cs (Statement.EmitBoolExpression): Pass true and false
26011 targets, and optimize for !x.
26013 2001-11-04 Ravi Pratap <ravi@ximian.com>
26015 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
26016 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
26017 set custom atttributes.
26019 * literal.cs (Literal::GetValue): New abstract method to return the actual
26020 value of the literal, cast as an object.
26022 (*Literal): Implement GetValue method.
26024 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
26025 expressions to the arraylist but objects of type Argument.
26027 * class.cs (TypeContainer::Emit): Emit our attributes too.
26029 (Method::Emit, Constructor::Emit): Ditto.
26031 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
26032 to be ignoring earlier.
26034 2001-11-03 Ravi Pratap <ravi@ximian.com>
26036 * attribute.cs (AttributeSection::Define): Implement to do the business
26037 of constructing a CustomAttributeBuilder.
26039 (Attribute): New trivial class. Increases readability of code.
26041 * cs-parser.jay : Update accordingly.
26043 (positional_argument_list, named_argument_list, named_argument): New rules
26045 (attribute_arguments): Use the above so that we are more correct.
26047 2001-11-02 Ravi Pratap <ravi@ximian.com>
26049 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
26050 to perform all checks for a method with a params parameter.
26052 (Invocation::OverloadResolve): Update to use the above method and therefore
26053 cope correctly with params method invocations.
26055 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
26058 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
26059 constructors in our parent too because we can't afford to miss out on
26062 * attribute.cs (AttributeSection): New name for the class Attribute
26064 Other trivial changes to improve readability.
26066 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
26067 use the new class names.
26069 2001-11-01 Ravi Pratap <ravi@ximian.com>
26071 * class.cs (Method::Define): Complete definition for params types too
26073 (Indexer::Define): Ditto.
26075 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
26076 Cope everywhere with a request for info about the array parameter.
26078 2001-11-01 Ravi Pratap <ravi@ximian.com>
26080 * tree.cs (RecordNamespace): Fix up to check for the correct key.
26082 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
26083 local_variable_type to extract the string corresponding to the type.
26085 (local_variable_type): Fixup the action to use the new helper method.
26087 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
26090 * expression.cs : Clean out code which uses the above.
26092 2001-10-31 Ravi Pratap <ravi@ximian.com>
26094 * typemanager.cs (RegisterMethod): Check if we already have an existing key
26095 and bale out if necessary by returning a false.
26097 (RegisterProperty): Ditto.
26099 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
26100 and print out appropriate error messages.
26102 * interface.cs (everywhere): Ditto.
26104 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
26105 location to constructor.
26107 * class.cs (Property, Event, Indexer): Update accordingly.
26109 * ../errors/cs111.cs : Added.
26111 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
26112 of a method, as laid down by the spec.
26114 (Invocation::OverloadResolve): Use the above method.
26116 2001-10-31 Ravi Pratap <ravi@ximian.com>
26118 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
26119 now take a TypeContainer and a Parameters object.
26121 (ParameterData): Modify return type of ParameterModifier method to be
26122 Parameter.Modifier and not a string.
26124 (ReflectionParameters, InternalParameters): Update accordingly.
26126 * expression.cs (Argument::GetParameterModifier): Same here.
26128 * support.cs (InternalParameters::ParameterType): Find a better way of determining
26129 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
26130 symbol in it at all so maybe this is only for now.
26132 2001-10-30 Ravi Pratap <ravi@ximian.com>
26134 * support.cs (InternalParameters): Constructor now takes an extra argument
26135 which is the actual Parameters class.
26137 (ParameterDesc): Update to provide info on ref/out modifiers.
26139 * class.cs (everywhere): Update call to InternalParameters to pass in
26140 the second argument too.
26142 * support.cs (ParameterData): Add ParameterModifier, which is a method
26143 to return the modifier info [ref/out etc]
26145 (InternalParameters, ReflectionParameters): Implement the above.
26147 * expression.cs (Argument::ParameterModifier): Similar function to return
26148 info about the argument's modifiers.
26150 (Invocation::OverloadResolve): Update to take into account matching modifiers
26153 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
26154 a new SetFormalParameters object which we pass to InternalParameters.
26156 2001-10-30 Ravi Pratap <ravi@ximian.com>
26158 * expression.cs (NewArray): Merge into the ArrayCreation class.
26160 2001-10-29 Ravi Pratap <ravi@ximian.com>
26162 * expression.cs (NewArray): Merge classes NewBuiltinArray and
26163 NewUserdefinedArray into one as there wasn't much of a use in having
26166 * expression.cs (Argument): Change field's name to ArgType from Type.
26168 (Type): New readonly property which returns the proper type, taking into
26169 account ref/out modifiers.
26171 (everywhere): Adjust code accordingly for the above.
26173 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
26174 whether we are emitting for a ref or out parameter.
26176 * expression.cs (Argument::Emit): Use the above field to set the state.
26178 (LocalVariableReference::Emit): Update to honour the flag and emit the
26181 * parameter.cs (Attributes): Set the correct flags for ref parameters.
26183 * expression.cs (Argument::FullDesc): New function to provide a full desc.
26185 * support.cs (ParameterData): Add method ParameterDesc to the interface.
26187 (ReflectionParameters, InternalParameters): Implement the above method.
26189 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
26192 (Invocation::FullMethodDesc): Ditto.
26194 2001-10-29 Miguel de Icaza <miguel@ximian.com>
26196 * cs-parser.jay: Add extra production for the second form of array
26199 * expression.cs (ArrayCreation): Update to reflect the above
26202 * Small changes to prepare for Array initialization.
26204 2001-10-28 Miguel de Icaza <miguel@ximian.com>
26206 * typemanager.cs (ImplementsInterface): interface might be null;
26207 Deal with this problem;
26209 Also, we do store negative hits on the cache (null values), so use
26210 this instead of calling t.GetInterfaces on the type everytime.
26212 2001-10-28 Ravi Pratap <ravi@ximian.com>
26214 * typemanager.cs (IsBuiltinType): New method to help determine the same.
26216 * expression.cs (New::DoResolve): Get rid of array creation code and instead
26217 split functionality out into different classes.
26219 (New::FormArrayType): Move into NewBuiltinArray.
26221 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
26224 (NewBuiltinArray): New class to handle creation of built-in arrays.
26226 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
26227 account creation of one-dimensional arrays.
26229 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
26231 (NewUserdefinedArray::DoResolve): Implement.
26233 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
26235 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
26236 we maintain inside the TypeManager. This is necessary to perform lookups on the
26239 (LookupType): Update to perform GetType on the module builders too.
26241 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
26243 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
26245 2001-10-23 Ravi Pratap <ravi@ximian.com>
26247 * expression.cs (New::DoResolve): Implement guts of array creation.
26249 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
26251 2001-10-27 Miguel de Icaza <miguel@ximian.com>
26253 * expression.cs: Fix bug I introduced lsat night that broke
26256 (Expression.Resolve): Report a 246 error (can not resolve name)
26257 if we find a SimpleName in the stream.
26259 (Expression.ResolveLValue): Ditto.
26261 (Expression.ResolveWithSimpleName): This function is a variant of
26262 ResolveName, this one allows SimpleNames to be returned without a
26263 warning. The only consumer of SimpleNames is MemberAccess
26265 2001-10-26 Miguel de Icaza <miguel@ximian.com>
26267 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
26268 might arrive here. I have my doubts that this is correct.
26270 * statement.cs (Lock): Implement lock statement.
26272 * cs-parser.jay: Small fixes to support `lock' and `using'
26274 * cs-tokenizer.cs: Remove extra space
26276 * driver.cs: New flag --checked, allows to turn on integer math
26279 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
26280 Threading.Monitor.Exit
26282 2001-10-23 Miguel de Icaza <miguel@ximian.com>
26284 * expression.cs (IndexerAccess::DoResolveLValue): Set the
26285 Expression Class to be IndexerAccess.
26287 Notice that Indexer::DoResolve sets the eclass to Value.
26289 2001-10-22 Miguel de Icaza <miguel@ximian.com>
26291 * class.cs (TypeContainer::Emit): Emit code for indexers.
26293 * assign.cs (IAssignMethod): New interface implemented by Indexers
26294 and Properties for handling assignment.
26296 (Assign::Emit): Simplify and reuse code.
26298 * expression.cs (IndexerAccess, PropertyExpr): Implement
26299 IAssignMethod, clean up old code.
26301 2001-10-22 Ravi Pratap <ravi@ximian.com>
26303 * typemanager.cs (ImplementsInterface): New method to determine if a type
26304 implements a given interface. Provides a nice cache too.
26306 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
26309 (ConvertReferenceExplicit): Ditto.
26311 * delegate.cs (Delegate::Populate): Update to define the parameters on the
26312 various methods, with correct names etc.
26314 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
26315 Operator.UnaryNegation.
26317 * cs-parser.jay (operator_declarator): Be a little clever in the case where
26318 we have a unary plus or minus operator.
26320 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
26323 * everywhere : update accordingly.
26325 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
26328 * class.cs (Method::Define): For the case where we are implementing a method
26329 inherited from an interface, we need to set the MethodAttributes.Final flag too.
26330 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
26332 2001-10-21 Ravi Pratap <ravi@ximian.com>
26334 * interface.cs (FindMembers): Implement to work around S.R.E
26337 * typemanager.cs (IsInterfaceType): Implement.
26339 (FindMembers): Update to handle interface types too.
26341 * expression.cs (ImplicitReferenceConversion): Re-write bits which
26342 use IsAssignableFrom as that is not correct - it doesn't work.
26344 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
26345 and accordingly override EmitStatement.
26347 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
26348 using the correct logic :-)
26350 2001-10-19 Ravi Pratap <ravi@ximian.com>
26352 * ../errors/cs-11.cs : Add to demonstrate error -11
26354 2001-10-17 Miguel de Icaza <miguel@ximian.com>
26356 * assign.cs (Assign::Resolve): Resolve right hand side first, and
26357 then pass this as a hint to ResolveLValue.
26359 * expression.cs (FieldExpr): Add Location information
26361 (FieldExpr::LValueResolve): Report assignment to readonly
26364 (Expression::ExprClassFromMemberInfo): Pass location information.
26366 (Expression::ResolveLValue): Add new method that resolves an
26369 (Expression::DoResolveLValue): Default invocation calls
26372 (Indexers): New class used to keep track of indexers in a given
26375 (IStackStore): Renamed from LValue, as it did not really describe
26376 what this did. Also ResolveLValue is gone from this interface and
26377 now is part of Expression.
26379 (ElementAccess): Depending on the element access type
26381 * typemanager.cs: Add `indexer_name_type' as a Core type
26382 (System.Runtime.CompilerServices.IndexerNameAttribute)
26384 * statement.cs (Goto): Take a location.
26386 2001-10-18 Ravi Pratap <ravi@ximian.com>
26388 * delegate.cs (Delegate::VerifyDelegate): New method to verify
26389 if two delegates are compatible.
26391 (NewDelegate::DoResolve): Update to take care of the case when
26392 we instantiate a delegate from another delegate.
26394 * typemanager.cs (FindMembers): Don't even try to look up members
26395 of Delegate types for now.
26397 2001-10-18 Ravi Pratap <ravi@ximian.com>
26399 * delegate.cs (NewDelegate): New class to take care of delegate
26402 * expression.cs (New): Split the delegate related code out into
26403 the NewDelegate class.
26405 * delegate.cs (DelegateInvocation): New class to handle delegate
26408 * expression.cs (Invocation): Split out delegate related code into
26409 the DelegateInvocation class.
26411 2001-10-17 Ravi Pratap <ravi@ximian.com>
26413 * expression.cs (New::DoResolve): Implement delegate creation fully
26414 and according to the spec.
26416 (New::DoEmit): Update to handle delegates differently.
26418 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
26419 because of which we were printing out arguments in reverse order !
26421 * delegate.cs (VerifyMethod): Implement to check if the given method
26422 matches the delegate.
26424 (FullDelegateDesc): Implement.
26426 (VerifyApplicability): Implement.
26428 * expression.cs (Invocation::DoResolve): Update to accordingly handle
26429 delegate invocations too.
26431 (Invocation::Emit): Ditto.
26433 * ../errors/cs1593.cs : Added.
26435 * ../errors/cs1594.cs : Added.
26437 * delegate.cs (InstanceExpression, TargetMethod): New properties.
26439 2001-10-16 Ravi Pratap <ravi@ximian.com>
26441 * typemanager.cs (intptr_type): Core type for System.IntPtr
26443 (InitCoreTypes): Update for the same.
26445 (iasyncresult_type, asynccallback_type): Ditto.
26447 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
26450 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26453 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26454 the builders for the 4 members of a delegate type :-)
26456 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26459 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26461 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26463 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26465 * statement.cs (Break::Emit): Implement.
26466 (Continue::Emit): Implement.
26468 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26469 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26470 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26471 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26474 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26475 properties that track the label for the current loop (begin of the
26476 loop and end of the loop).
26478 2001-10-15 Ravi Pratap <ravi@ximian.com>
26480 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26481 use of emitting anything at all.
26483 * class.cs, rootcontext.cs : Get rid of calls to the same.
26485 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26487 (Populate): Define the constructor correctly and set the implementation
26490 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26493 (AddDelegateType): Implement.
26495 (IsDelegateType): Implement helper method.
26497 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26499 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26500 and accordingly handle it.
26502 * delegate.cs (Populate): Take TypeContainer argument.
26503 Implement bits to define the Invoke method. However, I still haven't figured out
26504 how to take care of the native int bit :-(
26506 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26507 Qualify the name of the delegate, not its return type !
26509 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26512 (StandardConversionExists): Checking for array types turns out to be recursive.
26514 (ConvertReferenceExplicit): Implement array conversion.
26516 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26518 2001-10-12 Ravi Pratap <ravi@ximian.com>
26520 * cs-parser.jay (delegate_declaration): Store the fully qualified
26521 name as it is a type declaration.
26523 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26526 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26527 as TypeContainer::DefineType.
26529 (Populate): Method in which all the definition of the various methods (Invoke)
26532 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26535 (CloseDelegate): Finally creates the delegate.
26537 * class.cs (TypeContainer::DefineType): Update to define delegates.
26538 (Populate, Emit and CloseType): Do the same thing here too.
26540 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26541 delegates in all these operations.
26543 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26545 * expression.cs: LocalTemporary: a new expression used to
26546 reference a temporary that has been created.
26548 * assign.cs: Handle PropertyAccess back here, so that we can
26549 provide the proper semantic access to properties.
26551 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26552 a few more explicit conversions.
26554 * modifiers.cs: `NEW' modifier maps to HideBySig.
26556 * expression.cs (PropertyExpr): Make this into an
26557 ExpressionStatement, and support the EmitStatement code path.
26559 Perform get/set error checking, clean up the interface.
26561 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26562 them into toplevel access objects.
26564 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26566 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26569 * typemanager.cs: Keep track here of our PropertyBuilders again to
26570 work around lameness in SRE.
26572 2001-10-11 Miguel de Icaza <miguel@ximian.com>
26574 * expression.cs (LValue::LValueResolve): New method in the
26575 interface, used to perform a second resolution pass for LValues.
26577 (This::DoResolve): Catch the use of this in static methods.
26579 (This::LValueResolve): Implement.
26581 (This::Store): Remove warning, assigning to `this' in structures
26584 (Invocation::Emit): Deal with invocation of
26585 methods on value types. We need to pass the address to structure
26586 methods rather than the object itself. (The equivalent code to
26587 emit "this" for structures leaves the entire structure on the
26588 stack instead of a pointer to it).
26590 (ParameterReference::DoResolve): Compute the real index for the
26591 argument based on whether the method takes or not a `this' pointer
26592 (ie, the method is static).
26594 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
26595 value types returned from functions when we need to invoke a
26596 method on the sturcture.
26599 2001-10-11 Ravi Pratap <ravi@ximian.com>
26601 * class.cs (TypeContainer::DefineType): Method to actually do the business of
26602 defining the type in the Modulebuilder or Typebuilder. This is to take
26603 care of nested types which need to be defined on the TypeBuilder using
26604 DefineNestedMethod.
26606 (TypeContainer::GetClassBases): Implement. Essentially the code from the
26607 methods in RootContext, only ported to be part of TypeContainer.
26609 (TypeContainer::GetInterfaceOrClass): Ditto.
26611 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
26613 * interface.cs (Interface::DefineInterface): New method. Does exactly
26614 what RootContext.CreateInterface did earlier, only it takes care of nested types
26617 (Interface::GetInterfaces): Move from RootContext here and port.
26619 (Interface::GetInterfaceByName): Same here.
26621 * rootcontext.cs (ResolveTree): Re-write.
26623 (PopulateTypes): Re-write.
26625 * class.cs (TypeContainer::Populate): Populate nested types too.
26626 (TypeContainer::Emit): Emit nested members too.
26628 * typemanager.cs (AddUserType): Do not make use of the FullName property,
26629 instead just use the name argument passed in as it is already fully
26632 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
26633 to TypeContainer mapping to see if a type is user-defined.
26635 * class.cs (TypeContainer::CloseType): Implement.
26637 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
26638 the default constructor.
26640 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
26643 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
26645 * interface.cs (CloseType): Create the type here.
26647 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
26650 Remove all the methods which are now in TypeContainer.
26652 2001-10-10 Ravi Pratap <ravi@ximian.com>
26654 * delegate.cs (Define): Re-write bits to define the delegate
26657 2001-10-10 Miguel de Icaza <miguel@ximian.com>
26659 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
26661 * expression.cs (ImplicitReferenceConversion): handle null as well
26662 as a source to convert to any reference type.
26664 * statement.cs (Return): Perform any implicit conversions to
26665 expected return type.
26667 Validate use of return statement.
26669 * codegen.cs (EmitContext): Pass the expected return type here.
26671 * class.cs (Method, Constructor, Property): Pass expected return
26672 type to EmitContext.
26674 2001-10-09 Miguel de Icaza <miguel@ximian.com>
26676 * expression.cs: Make DoResolve take an EmitContext instead of a
26679 Replaced `l' and `location' for `loc', for consistency.
26681 (Error, Warning): Remove unneeded Tc argument.
26683 * assign.cs, literal.cs, constant.cs: Update to new calling
26686 * codegen.cs: EmitContext now contains a flag indicating whether
26687 code is being generated in a static method or not.
26689 * cs-parser.jay: DecomposeQI, new function that replaces the old
26690 QualifiedIdentifier. Now we always decompose the assembled
26691 strings from qualified_identifier productions into a group of
26694 2001-10-08 Miguel de Icaza <miguel@ximian.com>
26696 * rootcontext.cs: Deal with field-less struct types correctly now
26697 by passing the size option to Define Type.
26699 * class.cs: Removed hack that created one static field.
26701 2001-10-07 Miguel de Icaza <miguel@ximian.com>
26703 * statement.cs: Moved most of the code generation here.
26705 2001-10-09 Ravi Pratap <ravi@ximian.com>
26707 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
26710 (ElementAccess): Remove useless bits for now - keep checks as the spec
26713 2001-10-08 Ravi Pratap <ravi@ximian.com>
26715 * expression.cs (ElementAccess::DoResolve): Remove my crap code
26716 and start performing checks according to the spec.
26718 2001-10-07 Ravi Pratap <ravi@ximian.com>
26720 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
26721 rank_specifiers instead.
26723 (rank_specifiers): Change the order in which the rank specifiers are stored
26725 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
26727 * expression.cs (ElementAccess): Implement the LValue interface too.
26729 2001-10-06 Ravi Pratap <ravi@ximian.com>
26731 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
26732 except that user defined conversions are not included.
26734 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
26735 perform the conversion of the return type, if necessary.
26737 (New::DoResolve): Check whether we are creating an array or an object
26738 and accordingly do the needful.
26740 (New::Emit): Same here.
26742 (New::DoResolve): Implement guts of array creation.
26744 (New::FormLookupType): Helper function.
26746 2001-10-07 Miguel de Icaza <miguel@ximian.com>
26748 * codegen.cs: Removed most of the code generation here, and move the
26749 corresponding code generation bits to the statement classes.
26751 Added support for try/catch/finalize and throw.
26753 * cs-parser.jay: Added support for try/catch/finalize.
26755 * class.cs: Catch static methods having the flags override,
26756 virtual or abstract.
26758 * expression.cs (UserCast): This user cast was not really doing
26759 what it was supposed to do. Which is to be born in fully resolved
26760 state. Parts of the resolution were being performed at Emit time!
26764 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26766 * expression.cs: Implicity convert the result from UserCast.
26768 2001-10-05 Ravi Pratap <ravi@ximian.com>
26770 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
26771 prevented it from working correctly.
26773 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
26774 merely ConvertImplicit.
26776 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26778 * typemanager.cs: Make the LookupTypeContainer function static,
26779 and not per-instance.
26781 * class.cs: Make static FindMembers (the one that takes a Type
26784 * codegen.cs: Add EmitForeach here.
26786 * cs-parser.jay: Make foreach a toplevel object instead of the
26787 inline expansion, as we need to perform semantic analysis on it.
26789 2001-10-05 Ravi Pratap <ravi@ximian.com>
26791 * expression.cs (Expression::ImplicitUserConversion): Rename to
26792 UserDefinedConversion.
26794 (Expression::UserDefinedConversion): Take an extra argument specifying
26795 whether we look for explicit user conversions too.
26797 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
26799 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
26801 (ExplicitUserConversion): Make it a call to UserDefinedConversion
26802 with the appropriate arguments.
26804 * cs-parser.jay (cast_expression): Record location too.
26806 * expression.cs (Cast): Record location info.
26808 (Expression::ConvertExplicit): Take location argument.
26810 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
26811 to determine if we are doing explicit conversions.
26813 (UserCast::Emit): Update accordingly.
26815 (Expression::ConvertExplicit): Report an error if everything fails.
26817 * ../errors/cs0030.cs : Add.
26819 2001-10-04 Miguel de Icaza <miguel@ximian.com>
26821 * modifiers.cs: If the ABSTRACT keyword is present, also set the
26822 virtual and newslot bits.
26824 * class.cs (TypeContainer::RegisterRequiredImplementations):
26825 Record methods we need.
26827 (TypeContainer::MakeKey): Helper function to make keys for
26828 MethodBases, since the Methodbase key is useless.
26830 (TypeContainer::Populate): Call RegisterRequiredImplementations
26831 before defining the methods.
26833 Create a mapping for method_builders_to_methods ahead of time
26834 instead of inside a tight loop.
26836 (::RequireMethods): Accept an object as the data to set into the
26837 hashtable so we can report interface vs abstract method mismatch.
26839 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26841 * report.cs: Make all of it static.
26843 * rootcontext.cs: Drop object_type and value_type computations, as
26844 we have those in the TypeManager anyways.
26846 Drop report instance variable too, now it is a global.
26848 * driver.cs: Use try/catch on command line handling.
26850 Add --probe option to debug the error reporting system with a test
26853 * report.cs: Add support for exiting program when a probe
26854 condition is reached.
26856 2001-10-03 Ravi Pratap <ravi@ximian.com>
26858 * expression.cs (Binary::DoNumericPromotions): Fix the case when
26859 we do a forcible conversion regardless of type, to check if
26860 ForceConversion returns a null.
26862 (Binary::error19): Use location to report error.
26864 (Unary::error23): Use location here too.
26866 * ../errors/cs0019.cs : Check in.
26868 * ../errors/cs0023.cs : Check in.
26870 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
26871 case of a non-null MethodInfo object with a length of 0 !
26873 (Binary::ResolveOperator): Flag error if overload resolution fails to find
26874 an applicable member - according to the spec :-)
26875 Also fix logic to find members in base types.
26877 (Unary::ResolveOperator): Same here.
26879 (Unary::report23): Change name to error23 and make first argument a TypeContainer
26880 as I was getting thoroughly confused between this and error19 :-)
26882 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
26883 (::FindMostEncompassedType): Implement.
26884 (::FindMostEncompassingType): Implement.
26885 (::StandardConversionExists): Implement.
26887 (UserImplicitCast): Re-vamp. We now need info about most specific
26888 source and target types so that we can do the necessary conversions.
26890 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
26891 mathematical union with no duplicates.
26893 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26895 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
26896 in order from base classes to child classes, so that we can in
26897 child classes look up in our parent for method names and
26898 attributes (required for handling abstract, virtual, new, override
26899 constructs: we need to instrospect our base class, and if we dont
26900 populate the classes in order, the introspection might be
26901 incorrect. For example, a method could query its parent before
26902 the parent has any methods and would determine that the parent has
26903 no abstract methods (while it could have had them)).
26905 (RootContext::CreateType): Record the order in which we define the
26908 2001-10-02 Miguel de Icaza <miguel@ximian.com>
26910 * class.cs (TypeContainer::Populate): Also method definitions can
26911 fail now, keep track of this.
26913 (TypeContainer::FindMembers): Implement support for
26914 DeclaredOnly/noDeclaredOnly flag.
26916 (Constructor::Emit) Return the ConstructorBuilder.
26918 (Method::Emit) Return the MethodBuilder.
26919 Check for abstract or virtual methods to be public.
26921 * rootcontext.cs (RootContext::CreateType): Register all the
26922 abstract methods required for the class to be complete and the
26923 interface methods that must be implemented.
26925 * cs-parser.jay: Report error 501 (method requires body if it is
26926 not marked abstract or extern).
26928 * expression.cs (TypeOf::Emit): Implement.
26930 * typemanager.cs: runtime_handle_type, new global type.
26932 * class.cs (Property::Emit): Generate code for properties.
26934 2001-10-02 Ravi Pratap <ravi@ximian.com>
26936 * expression.cs (Unary::ResolveOperator): Find operators on base type
26937 too - we now conform exactly to the spec.
26939 (Binary::ResolveOperator): Same here.
26941 * class.cs (Operator::Define): Fix minor quirk in the tests.
26943 * ../errors/cs0215.cs : Added.
26945 * ../errors/cs0556.cs : Added.
26947 * ../errors/cs0555.cs : Added.
26949 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26951 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
26952 single integer which is really efficient
26954 2001-10-01 Ravi Pratap <ravi@ximian.com>
26956 * expression.cs (Expression::ImplicitUserConversion): Use location
26957 even in the case when we are examining True operators.
26959 * class.cs (Operator::Define): Perform extensive checks to conform
26960 with the rules for operator overloading in the spec.
26962 * expression.cs (Expression::ImplicitReferenceConversion): Implement
26963 some of the other conversions mentioned in the spec.
26965 * typemanager.cs (array_type): New static member for the System.Array built-in
26968 (cloneable_interface): For System.ICloneable interface.
26970 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
26971 we start resolving the tree and populating types.
26973 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
26975 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26977 * expression.cs (Expression::ExprClassFromMemberInfo,
26978 Expression::Literalize): Create literal expressions from
26979 FieldInfos which are literals.
26981 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
26982 type casts, because they were wrong. The test suite in tests
26985 (ImplicitNumericConversion): ushort to ulong requires a widening
26988 Int32 constant to long requires widening cast as well.
26990 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
26991 for integers because the type on the stack is not i4.
26993 2001-09-30 Miguel de Icaza <miguel@ximian.com>
26995 * expression.cs (report118): require location argument.
26997 * parameter.cs: Do not dereference potential null value.
26999 * class.cs: Catch methods that lack the `new' keyword when
27000 overriding a name. Report warnings when `new' is used without
27001 anything being there to override.
27003 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
27005 * class.cs: Only add constructor to hashtable if it is non-null
27006 (as now constructors can fail on define).
27008 (TypeManager, Class, Struct): Take location arguments.
27010 Catch field instance initialization in structs as errors.
27012 accepting_filter: a new filter for FindMembers that is static so
27013 that we dont create an instance per invocation.
27015 (Constructor::Define): Catch errors where a struct constructor is
27018 * cs-parser.jay: Pass location information for various new
27021 * delegate.cs (Delegate): take a location argument.
27023 * driver.cs: Do not call EmitCode if there were problesm in the
27024 Definition of the types, as many Builders wont be there.
27026 * decl.cs (Decl::Decl): Require a location argument.
27028 * cs-tokenizer.cs: Handle properly hex constants that can not fit
27029 into integers, and find the most appropiate integer for it.
27031 * literal.cs: Implement ULongLiteral.
27033 * rootcontext.cs: Provide better information about the location of
27034 failure when CreateType fails.
27036 2001-09-29 Miguel de Icaza <miguel@ximian.com>
27038 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
27041 * expression.cs (Binary::CheckShiftArguments): Add missing type
27043 (Binary::ResolveOperator): Add type to the logical and and logical
27044 or, Bitwise And/Or and Exclusive Or code paths, it was missing
27047 (Binary::DoNumericPromotions): In the case where either argument
27048 is ulong (and most signed types combined with ulong cause an
27049 error) perform implicit integer constant conversions as well.
27051 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27053 * expression.cs (UserImplicitCast): Method should always be
27055 (Invocation::BetterConversion): Simplified test for IntLiteral.
27057 (Expression::ImplicitNumericConversion): Split this routine out.
27058 Put the code that performs implicit constant integer conversions
27061 (Expression::Resolve): Become a wrapper around DoResolve so we can
27062 check eclass and type being set after resolve.
27064 (Invocation::Badness): Remove this dead function
27066 (Binary::ResolveOperator): Do not compute the expensive argumnets
27067 unless we have a union for it.
27069 (Probe::Emit): Is needs to do an isinst and then
27070 compare against null.
27072 (::CanConvert): Added Location argument. If the Location argument
27073 is null (Location.Null), then we do not report errors. This is
27074 used by the `probe' mechanism of the Explicit conversion. We do
27075 not want to generate an error for something that the user
27076 explicitly requested to be casted. But the pipeline for an
27077 explicit cast first tests for potential implicit casts.
27079 So for now, if the Location is null, it means `Probe only' to
27080 avoid adding another argument. Might have to revise this
27083 (ClassCast): New class used to type cast objects into arbitrary
27084 classes (used in Explicit Reference Conversions).
27086 Implement `as' as well.
27088 Reverted all the patches from Ravi below: they were broken:
27090 * The use of `level' as a mechanism to stop recursive
27091 invocations is wrong. That was there just to catch the
27092 bug with a strack trace but not as a way of addressing
27095 To fix the problem we have to *understand* what is going
27096 on and the interactions and come up with a plan, not
27097 just get things going.
27099 * The use of the type conversion cache that I proposed
27100 last night had an open topic: How does this work across
27101 protection domains. A user defined conversion might not
27102 be public in the location where we are applying the
27103 conversion, a different conversion might be selected
27104 (ie, private A->B (better) but public B->A (worse),
27105 inside A, A->B applies, but outside it, B->A will
27108 * On top of that (ie, even if the above is solved),
27109 conversions in a cache need to be abstract. Ie, `To
27110 convert from an Int to a Short use an OpcodeCast', not
27111 `To convert from an Int to a Short use the OpcodeCast on
27112 the variable 5' (which is what this patch was doing).
27114 2001-09-28 Ravi Pratap <ravi@ximian.com>
27116 * expression.cs (Invocation::ConversionExists): Re-write to use
27117 the conversion cache
27119 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
27120 cache all conversions done, not just user-defined ones.
27122 (Invocation::BetterConversion): The real culprit. Use ConversionExists
27123 to determine if a conversion exists instead of acutually trying to
27124 perform the conversion. It's faster too.
27126 (Expression::ConvertExplicit): Modify to use ConversionExists to check
27127 and only then attempt the implicit conversion.
27129 2001-09-28 Ravi Pratap <ravi@ximian.com>
27131 * expression.cs (ConvertImplicit): Use a cache for conversions
27132 already found. Check level of recursion and bail out if necessary.
27134 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27136 * typemanager.cs (string_concat_string_string, string_concat_object_object):
27137 Export standard methods that we expect for string operations.
27139 * statement.cs (Block::UsageWarning): Track usage of variables and
27140 report the errors for not used variables.
27142 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
27145 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27147 * codegen.cs: remove unnneded code
27149 * expression.cs: Removed BuiltinTypeAccess class
27151 Fix the order in which implicit conversions are
27154 The previous fixed dropped support for boxed conversions (adding a
27155 test to the test suite now)
27157 (UserImplicitCast::CanConvert): Remove test for source being null,
27158 that code is broken. We should not feed a null to begin with, if
27159 we do, then we should track the bug where the problem originates
27160 and not try to cover it up here.
27162 Return a resolved expression of type UserImplicitCast on success
27163 rather than true/false. Ravi: this is what I was talking about,
27164 the pattern is to use a static method as a "constructor" for
27167 Also, do not create arguments until the very last minute,
27168 otherwise we always create the arguments even for lookups that
27169 will never be performed.
27171 (UserImplicitCast::Resolve): Eliminate, objects of type
27172 UserImplicitCast are born in a fully resolved state.
27174 * typemanager.cs (InitCoreTypes): Init also value_type
27175 (System.ValueType).
27177 * expression.cs (Cast::Resolve): First resolve the child expression.
27179 (LValue): Add new method AddressOf to be used by
27182 Change the argument of Store to take an EmitContext instead of an
27183 ILGenerator, because things like FieldExpr need to be able to call
27184 their children expression to generate the instance code.
27186 (Expression::Error, Expression::Warning): Sugar functions for
27189 (Expression::MemberLookup): Accept a TypeContainer instead of a
27190 Report as the first argument.
27192 (Expression::ResolvePrimary): Killed. I still want to improve
27193 this as currently the code is just not right.
27195 (Expression::ResolveMemberAccess): Simplify, but it is still
27198 (Unary::Resolve): Catch errors in AddressOf operators.
27200 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
27201 index to a byte for the short-version, or the compiler will choose
27202 the wrong Emit call, which generates the wrong data.
27204 (ParameterReference::Emit, ::Store): same.
27206 (FieldExpr::AddressOf): Implement.
27208 * typemanager.cs: TypeManager: made public variable instead of
27211 * driver.cs: document --fatal.
27213 * report.cs (ErrorMessage, WarningMessage): new names for the old
27214 Error and Warning classes.
27216 * cs-parser.jay (member_access): Turn built-in access to types
27217 into a normal simplename
27219 2001-09-27 Ravi Pratap <ravi@ximian.com>
27221 * expression.cs (Invocation::BetterConversion): Fix to cope
27222 with q being null, since this was introducing a bug.
27224 * expression.cs (ConvertImplicit): Do built-in conversions first.
27226 2001-09-27 Ravi Pratap <ravi@ximian.com>
27228 * expression.cs (UserImplicitCast::Resolve): Fix bug.
27230 2001-09-27 Ravi Pratap <ravi@ximian.com>
27232 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
27233 I had introduced long ago (what's new ?).
27235 * expression.cs (UserImplicitCast::CanConvert): Static method to do
27236 the work of all the checking.
27237 (ConvertImplicit): Call CanConvert and only then create object if necessary.
27238 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
27240 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
27241 that is the right way.
27243 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
27244 overloading resolution. Use everywhere instead of cutting and pasting code.
27246 (Binary::ResolveOperator): Use MakeUnionSet.
27248 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
27249 we have to convert to bool types. Not complete yet.
27251 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27253 * typemanager.cs (TypeManager::CSharpName): support ushort.
27255 * expression.cs (Expression::TryImplicitIntConversion): Attempts
27256 to provide an expression that performsn an implicit constant int
27257 conversion (section 6.1.6).
27258 (Expression::ConvertImplicitRequired): Reworked to include
27259 implicit constant expression conversions.
27261 (Expression::ConvertNumericExplicit): Finished.
27263 (Invocation::Emit): If InstanceExpression is null, then it means
27264 that we perform a call on this.
27266 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27268 * expression.cs (Unary::Emit): Remove some dead code.
27269 (Probe): Implement Resolve and Emit for `is'.
27270 (Expression::ConvertImplicitRequired): Attempt to do constant
27271 expression conversions here. Maybe should be moved to
27272 ConvertImplicit, but I am not sure.
27273 (Expression::ImplicitLongConstantConversionPossible,
27274 Expression::ImplicitIntConstantConversionPossible): New functions
27275 that tell whether is it possible to apply an implicit constant
27276 expression conversion.
27278 (ConvertNumericExplicit): Started work on explicit numeric
27281 * cs-parser.jay: Update operator constants.
27283 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
27284 (Parameters::GetSignature): Hook up VerifyArgs here.
27285 (Parameters::VerifyArgs): Verifies that no two arguments have the
27288 * class.cs (Operator): Update the operator names to reflect the
27289 ones that the spec expects (as we are just stringizing the
27292 * expression.cs (Unary::ResolveOperator): Fix bug: Use
27293 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
27294 previous usage did only work for our methods.
27295 (Expression::ConvertImplicit): Handle decimal implicit numeric
27296 conversions as well.
27297 (Expression::InternalTypeConstructor): Used to invoke constructors
27298 on internal types for default promotions.
27300 (Unary::Emit): Implement special handling for the pre/post
27301 increment/decrement for overloaded operators, as they need to have
27302 the same semantics as the other operators.
27304 (Binary::ResolveOperator): ditto.
27305 (Invocation::ConversionExists): ditto.
27306 (UserImplicitCast::Resolve): ditto.
27308 2001-09-26 Ravi Pratap <ravi@ximian.com>
27310 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
27311 operator, return after emitting body. Regression tests pass again !
27313 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
27314 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
27315 (Invocation::OverloadResolve): Ditto.
27316 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
27318 * everywhere : update calls to the above methods accordingly.
27320 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27322 * assign.cs (Assign): Make it inherit from ExpressionStatement.
27324 * expression.cs (ExpressionStatement): New base class used for
27325 expressions that can appear in statements, so that we can provide
27326 an alternate path to generate expression that do not leave a value
27329 (Expression::Emit, and all the derivatives): We no longer return
27330 whether a value is left on the stack or not. Every expression
27331 after being emitted leaves a single value on the stack.
27333 * codegen.cs (EmitContext::EmitStatementExpression): Use the
27334 facilties of ExpressionStatement if possible.
27336 * cs-parser.jay: Update statement_expression.
27338 2001-09-25 Miguel de Icaza <miguel@ximian.com>
27340 * driver.cs: Change the wording of message
27342 2001-09-25 Ravi Pratap <ravi@ximian.com>
27344 * expression.cs (Binary::ResolveOperator): Had forgottten to set
27345 the type of the expression to the return type of the method if
27346 we have an overloaded operator match ! The regression tests pass again !
27347 (Unary::ResolveOperator): Ditto.
27349 * expression.cs (Invocation::ConversionExists): Correct the member lookup
27350 to find "op_Implicit", not "implicit" ;-)
27351 (UserImplicitCast): New class to take care of user-defined implicit conversions.
27352 (ConvertImplicit, ForceConversion): Take TypeContainer argument
27354 * everywhere : Correct calls to the above accordingly.
27356 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
27357 (ConvertImplicit): Do user-defined conversion if it exists.
27359 2001-09-24 Miguel de Icaza <miguel@ximian.com>
27361 * assign.cs: track location.
27362 (Resolve): Use implicit conversions on assignment.
27364 * literal.cs: Oops. Not good, Emit of short access values should
27365 pass (Bytes) or the wrong argument will be selected.
27367 * expression.cs (Unary::Emit): Emit code for -expr.
27369 (Unary::ResolveOperator): Handle `Substract' for non-constants
27370 (substract from zero from the non-constants).
27371 Deal with Doubles as well.
27373 (Expression::ConvertImplicitRequired): New routine that reports an
27374 error if no implicit conversion exists.
27376 (Invocation::OverloadResolve): Store the converted implicit
27377 expressions if we make them
27379 2001-09-24 Ravi Pratap <ravi@ximian.com>
27381 * class.cs (ConstructorInitializer): Take a Location argument.
27382 (ConstructorBaseInitializer): Same here.
27383 (ConstructorThisInitializer): Same here.
27385 * cs-parser.jay : Update all calls accordingly.
27387 * expression.cs (Unary, Binary, New): Take location argument.
27388 Update accordingly everywhere.
27390 * cs-parser.jay : Update all calls to the above to take a location
27393 * class.cs : Ditto.
27395 2001-09-24 Ravi Pratap <ravi@ximian.com>
27397 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
27398 (Invocation::BetterConversion): Same here
27399 (Invocation::ConversionExists): Ditto.
27401 (Invocation::ConversionExists): Implement.
27403 2001-09-22 Ravi Pratap <ravi@ximian.com>
27405 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
27406 Also take an additional TypeContainer argument.
27408 * All over : Pass in TypeContainer as argument to OverloadResolve.
27410 * typemanager.cs (CSharpName): Update to check for the string type and return
27413 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
27416 2001-09-21 Ravi Pratap <ravi@ximian.com>
27418 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
27419 (Invocation::BetterFunction): Implement.
27420 (Invocation::BetterConversion): Implement.
27421 (Invocation::ConversionExists): Skeleton, no implementation yet.
27423 Okay, things work fine !
27425 2001-09-21 Miguel de Icaza <miguel@ximian.com>
27427 * typemanager.cs: declare and load enum_type, delegate_type and
27430 * expression.cs (Expression::Emit): Now emit returns a value that
27431 tells whether a value is left on the stack or not. This strategy
27432 might be reveted tomorrow with a mechanism that would address
27433 multiple assignments.
27434 (Expression::report118): Utility routine to report mismatches on
27437 (Unary::Report23): Report impossible type/operator combination
27440 (Unary::IsIncrementableNumber): Whether the type can be
27441 incremented or decremented with add.
27442 (Unary::ResolveOperator): Also allow enumerations to be bitwise
27444 (Unary::ResolveOperator): Implement ++, !, ~,
27446 (Invocation::Emit): Deal with new Emit convetion.
27448 * All Expression derivatives: Updated their Emit method to return
27449 whether they leave values on the stack or not.
27451 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27452 stack for expressions that are statements.
27454 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27456 * expression.cs (LValue): New interface. Must be implemented by
27458 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27461 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27462 interface for generating code, simplifies the code.
27464 2001-09-20 Ravi Pratap <ravi@ximian.com>
27466 * expression.cs (everywhere): Comment out return statements in ::Resolve
27467 methods to avoid the warnings.
27469 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27471 * driver.cs (parse): Report error 2001 if we can not open the
27474 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27477 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27480 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27481 otherwise nested blocks end up with the same index.
27483 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27485 * expression.cs: Instead of having FIXMEs in the Resolve
27486 functions, throw exceptions so it is obvious that we are facing a
27489 * cs-parser.jay (invocation_expression): Pass Location information.
27491 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27492 Use a basename for those routines because .NET does not like paths
27495 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27498 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27500 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27501 are loading the correct data types (throws an exception if not).
27502 (TypeManager::InitCoreTypes): Use CoreLookupType
27504 * expression.cs (Unary::ResolveOperator): return the child
27505 expression for expressions which are just +expr.
27506 (Unary::ResolveOperator): Return negative literals for -LITERAL
27507 expressions (otherwise they are Unary {Literal}).
27508 (Invocation::Badness): Take into account `Implicit constant
27509 expression conversions'.
27511 * literal.cs (LongLiteral): Implement long literal class.
27512 (IntLiteral): export the `Value' of the intliteral.
27514 2001-09-19 Ravi Pratap <ravi@ximian.com>
27516 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27518 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27519 instead of 'Operator'
27521 * expression.cs (Binary::ResolveOperator): Update accordingly.
27522 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27525 * cs-parser.jay (unary_expression): Update to use the new names.
27527 * gen-treedump.cs (GetUnary): Same here.
27529 * expression.cs (Unary::Resolve): Implement.
27530 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27531 operators are found instead of making noise ;-)
27532 (Unary::ResolveOperator): New method to do precisely the same thing which
27533 Binary::ResolveOperator does for Binary expressions.
27534 (Unary.method, .Arguments): Add.
27535 (Unary::OperName): Implement.
27536 (Unary::ForceConversion): Copy and Paste !
27538 * class.cs (Operator::Define): Fix a small bug for the case when we have
27541 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27542 for the inbuilt operators. Only overloading works for now ;-)
27544 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27546 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27547 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27549 * expression.cs (This::Emit): Implement.
27550 (This::Resolve): Implement.
27551 (TypeOf:Resolve): Implement.
27552 (Expression::ResolveSimpleName): Add an implicit this to instance
27554 (MemberAccess::Resolve): Deal with Parameters and Fields.
27555 Bind instance variable to Field expressions.
27556 (FieldExpr::Instance): New field used to track the expression that
27557 represents the object instance.
27558 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27560 (FieldExpr::Emit): Implement.
27562 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27563 the last instruction contains a return opcode to avoid generating
27564 the last `ret' instruction (this generates correct code, and it is
27565 nice to pass the peverify output).
27567 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27568 initializer for static and instance variables.
27569 (Constructor::Emit): Allow initializer to be null in the case of
27570 static constructors. Only emit initializer for instance
27573 (TypeContainer::FindMembers): Return a null array if there are no
27576 Also fix the code for the MemberTypes.Method branch, as it was not
27577 scanning that for operators (or tried to access null variables before).
27579 * assign.cs (Assign::Emit): Handle instance and static fields.
27583 * driver.cs: Stop compilation if there are parse errors.
27585 * cs-parser.jay (constructor_declaration): Provide default base
27586 initializer for non-static constructors.
27587 (constructor_declarator): Do not provide a default base
27588 initializers if none was specified.
27589 Catch the fact that constructors should not have parameters.
27591 * class.cs: Do not emit parent class initializers for static
27592 constructors, that should be flagged as an error.
27594 2001-09-18 Ravi Pratap <ravi@ximian.com>
27596 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
27597 Move back code into TypeContainer::Populate.
27599 2001-09-18 Ravi Pratap <ravi@ximian.com>
27601 * class.cs (TypeContainer::AddConstructor): Fix the check to
27602 compare against Name, not Basename.
27603 (Operator::OpType): Change Plus and Minus to Add and Subtract.
27605 * cs-parser.jay : Update accordingly.
27607 * class.cs (TypeContainer::FindMembers): For the case where we are searching
27608 for methods, don't forget to look into the operators too.
27609 (RegisterMethodBuilder): Helper method to take care of this for
27610 methods, constructors and operators.
27611 (Operator::Define): Completely revamp.
27612 (Operator.OperatorMethod, MethodName): New fields.
27613 (TypeContainer::Populate): Move the registering of builders into
27614 RegisterMethodBuilder.
27615 (Operator::Emit): Re-write.
27617 * expression.cs (Binary::Emit): Comment out code path to emit method
27618 invocation stuff for the case when we have a user defined operator. I am
27619 just not able to get it right !
27621 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27623 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
27626 (Expression::MemberLookup): Provide a version that allows to
27627 specify the MemberTypes and BindingFlags.
27629 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
27630 so it was not fetching variable information from outer blocks.
27632 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
27633 Beforefieldinit as it was buggy.
27635 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
27636 that Ravi put here.
27638 * class.cs (Constructor::Emit): Only emit if block is not null.
27639 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
27640 deal with this by semantically definining it as if the user had
27643 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
27644 constructors as we now "emit" them at a higher level.
27646 (TypeContainer::DefineDefaultConstructor): Used to define the
27647 default constructors if none was provided.
27649 (ConstructorInitializer): Add methods Resolve and Emit.
27651 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
27653 2001-09-17 Ravi Pratap <ravi@ximian.com>
27655 * class.cs (TypeContainer::EmitDefaultConstructor): Register
27656 the default constructor builder with our hashtable for methodbuilders
27659 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
27660 and argument_count is 0 in which case we have a match.
27661 (Binary::ResolveOperator): More null checking and miscellaneous coding
27664 2001-09-17 Ravi Pratap <ravi@ximian.com>
27666 * rootcontext.cs (IsNameSpace): Compare against null.
27668 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
27670 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
27671 and Unary::Operator.
27673 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
27676 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
27677 we have overloaded operators.
27678 (Binary::ResolveOperator): Implement the part which does the operator overload
27681 * class.cs (Operator::Emit): Implement.
27682 (TypeContainer::Emit): Emit the operators we have too.
27684 * expression.cs (Binary::Emit): Update to emit the appropriate code for
27685 the case when we have a user-defined operator.
27687 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27689 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
27691 2001-09-16 Ravi Pratap <ravi@ximian.com>
27693 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
27694 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
27695 (Constructor::Emit): Implement.
27696 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
27697 if we have no work to do.
27698 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
27701 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
27702 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
27704 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
27707 2001-09-15 Ravi Pratap <ravi@ximian.com>
27709 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
27711 (Tree::RecordNamespace): Method to do what the name says ;-)
27712 (Tree::Namespaces): Property to get at the namespaces hashtable.
27714 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
27717 * rootcontext.cs (IsNamespace): Fixed it :-)
27719 2001-09-14 Miguel de Icaza <miguel@ximian.com>
27721 * class.cs (TypeContainer::FindMembers): Add support for
27723 (MethodCore): New class that encapsulates both the shared aspects
27724 of a Constructor and a Method.
27725 (Method, Constructor): Factored pieces into MethodCore.
27727 * driver.cs: Added --fatal which makes errors throw exceptions.
27728 Load System assembly as well as part of the standard library.
27730 * report.cs: Allow throwing exceptions on errors for debugging.
27732 * modifiers.cs: Do not use `parent', instead use the real type
27733 container to evaluate permission settings.
27735 * class.cs: Put Ravi's patch back in. He is right, and we will
27736 have to cope with the
27738 2001-09-14 Ravi Pratap <ravi@ximian.com>
27740 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
27741 FamORAssem, not FamANDAssem.
27743 2001-09-14 Miguel de Icaza <miguel@ximian.com>
27745 * driver.cs: Added --parse option that only parses its input files
27748 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
27749 incorrect. IsTopLevel is not used to tell whether an object is
27750 root_types or not (that can be achieved by testing this ==
27751 root_types). But to see if this is a top-level *class* (not
27752 necessarly our "toplevel" container).
27754 2001-09-14 Ravi Pratap <ravi@ximian.com>
27756 * enum.cs (Enum::Define): Modify to call the Lookup method on the
27757 parent instead of a direct call to GetType.
27759 2001-09-14 Ravi Pratap <ravi@ximian.com>
27761 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
27762 Modifiers.TypeAttr. This should just be a call to that method.
27764 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
27765 object so that we can determine if we are top-level or not.
27767 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
27770 * enum.cs (Enum::Define): Ditto.
27772 * modifiers.cs (FieldAttr): Re-write.
27774 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
27775 (TypeContainer::HaveStaticConstructor): New property to provide access
27776 to precisely that info.
27778 * modifiers.cs (MethodAttr): Re-write.
27779 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
27781 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
27782 of top-level types as claimed.
27784 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27786 * expression.cs (MemberLookup): Fruitless attempt to lookup
27787 constructors. Maybe I need to emit default constructors? That
27788 might be it (currently .NET emits this for me automatically).
27789 (Invocation::OverloadResolve): Cope with Arguments == null.
27790 (Invocation::EmitArguments): new function, shared by the new
27791 constructor and us.
27792 (Invocation::Emit): Handle static and instance methods. Emit
27793 proper call instruction for virtual or non-virtual invocations.
27794 (New::Emit): Implement.
27795 (New::Resolve): Implement.
27796 (MemberAccess:Resolve): Implement.
27797 (MethodGroupExpr::InstanceExpression): used conforming to the spec
27798 to track instances.
27799 (FieldExpr::Resolve): Set type.
27801 * support.cs: Handle empty arguments.
27803 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
27804 SimpleLookup): Auxiliary routines to help parse a qualifier
27807 Update qualifier_identifier rule.
27809 * codegen.cs: Removed debugging messages.
27811 * class.cs: Make this a global thing, this acts just as a "key" to
27812 objects that we might have around.
27814 (Populate): Only initialize method_builders_to_methods once.
27816 * expression.cs (PropertyExpr): Initialize type from the
27819 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
27820 Resolve pattern. Attempt to implicitly convert value to boolean.
27823 * expression.cs: Set the type for the int32/int32 argument case.
27824 (Binary::ResolveOperator): Set the return type to boolean for
27825 comparission operators
27827 * typemanager.cs: Remove debugging print code.
27829 (Invocation::Resolve): resolve type.
27831 * class.cs: Allocate a MemberInfo of the correct size, as the code
27832 elsewhere depends on the test to reflect the correct contents.
27834 (Method::) Keep track of parameters, due to System.Reflection holes
27836 (TypeContainer::Populate): Keep track of MethodBuilders to Method
27839 (TypeContainer::FindMembers): Use ArrayList and then copy an array
27840 of the exact size and return that.
27842 (Class::LookupMethodByBuilder): New function that maps
27843 MethodBuilders to its methods. Required to locate the information
27844 on methods because System.Reflection bit us again.
27846 * support.cs: New file, contains an interface ParameterData and
27847 two implementations: ReflectionParameters and InternalParameters
27848 used to access Parameter information. We will need to grow this
27851 * expression.cs (Invocation::GetParameterData): implement a cache
27852 and a wrapper around the ParameterData creation for methods.
27853 (Invocation::OverloadResolve): Use new code.
27855 2001-09-13 Ravi Pratap <ravi@ximian.com>
27857 * class.cs (TypeContainer::EmitField): Remove and move into
27858 (Field::Define): here and modify accordingly.
27859 (Field.FieldBuilder): New member.
27860 (TypeContainer::Populate): Update accordingly.
27861 (TypeContainer::FindMembers): Implement.
27863 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27865 * statement.cs: (VariableInfo::VariableType): New field to be
27866 initialized with the full type once it is resolved.
27868 2001-09-12 Miguel de Icaza <miguel@ximian.com>
27870 * parameter.cs (GetParameterInfo): Use a type cache to compute
27871 things only once, and to reuse this information
27873 * expression.cs (LocalVariableReference::Emit): Implement.
27874 (OpcodeCast::Emit): fix.
27876 (ParameterReference::Resolve): Implement.
27877 (ParameterReference::Emit): Implement.
27879 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
27880 that are expressions need to stay as Expressions.
27882 * typemanager.cs (CSharpName): Returns the C# name of a type if
27885 * expression.cs (Expression::ConvertImplicit): New function that
27886 implements implicit type conversions.
27888 (Expression::ImplicitReferenceConversion): Implements implicit
27889 reference conversions.
27891 (EmptyCast): New type for transparent casts.
27893 (OpcodeCast): New type for casts of types that are performed with
27894 a sequence of bytecodes.
27896 (BoxedCast): New type used for casting value types into reference
27897 types. Emits a box opcode.
27899 (Binary::DoNumericPromotions): Implements numeric promotions of
27900 and computation of the Binary::Type.
27902 (Binary::EmitBranchable): Optimization.
27904 (Binary::Emit): Implement code emission for expressions.
27906 * typemanager.cs (TypeManager): Added two new core types: sbyte
27909 2001-09-12 Ravi Pratap <ravi@ximian.com>
27911 * class.cs (TypeContainer::FindMembers): Method which does exactly
27912 what Type.FindMembers does, only we don't have to use reflection. No
27913 implementation yet.
27915 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
27916 typecontainer objects as we need to get at them.
27917 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
27919 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
27920 typecontainer object.
27922 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
27923 of just a Report object.
27925 2001-09-11 Ravi Pratap <ravi@ximian.com>
27927 * class.cs (Event::Define): Go back to using the prefixes "add_" and
27929 (TypeContainer::Populate): Now define the delegates of the type too.
27930 (TypeContainer.Delegates): Property to access the list of delegates defined
27933 * delegates.cs (Delegate::Define): Implement partially.
27935 * modifiers.cs (TypeAttr): Handle more flags.
27937 2001-09-11 Ravi Pratap <ravi@ximian.com>
27939 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
27941 (Operator::Define): Re-write logic to get types by using the LookupType method
27942 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
27943 (Indexer::Define): Ditto.
27944 (Event::Define): Ditto.
27945 (Property::Define): Ditto.
27947 2001-09-10 Ravi Pratap <ravi@ximian.com>
27949 * class.cs (TypeContainer::Populate): Now define operators too.
27950 (TypeContainer.Operators): New property to access the list of operators
27952 (Operator.OperatorMethodBuilder): New member to hold the method builder
27953 for the operator we are defining.
27954 (Operator::Define): Implement.
27956 2001-09-10 Ravi Pratap <ravi@ximian.com>
27958 * class.cs (Event::Define): Make the prefixes of the accessor methods
27959 addOn_ and removeOn_
27961 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
27962 of the location being passed in too. Ideally, this should go later since all
27963 error reporting should be done through the Report object.
27965 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
27966 (Populate): Iterate thru the indexers we have and define them too.
27967 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
27968 for the get and set accessors.
27969 (Indexer::Define): Implement.
27971 2001-09-09 Miguel de Icaza <miguel@ximian.com>
27973 * expression.cs (Binary::Resolve): Beginning of it. I scratched
27974 my previous implementation, did not work.
27976 * typemanager.cs: Add a couple of missing types (the longs).
27978 * literal.cs: Use TypeManager.bool_type instead of getting it.
27980 * expression.cs (EventExpr): New kind of expressions.
27981 (Expressio::ExprClassFromMemberInfo): finish
27983 2001-09-08 Miguel de Icaza <miguel@ximian.com>
27985 * assign.cs: Emit stores to static fields differently.
27987 2001-09-08 Ravi Pratap <ravi@ximian.com>
27989 * Merge in changes and adjust code to tackle conflicts. Backed out my
27990 code in Assign::Resolve ;-)
27992 2001-09-08 Ravi Pratap <ravi@ximian.com>
27994 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
27995 instead Report.Error and also pass in the location.
27996 (CSharpParser::Lexer): New readonly property to return the reference
27997 to the Tokenizer object.
27998 (declare_local_variables): Use Report.Error with location instead of plain
28002 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
28003 (Operator.CheckBinaryOperator): Ditto.
28005 * cs-parser.jay (operator_declarator): Update accordingly.
28007 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
28008 (CheckBinaryOperator): Same here.
28010 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
28011 on the name without any prefixes of namespace names etc. This is because we
28012 already might have something already fully qualified like
28013 'System.Console.WriteLine'
28015 * assign.cs (Resolve): Begin implementation. Stuck ;-)
28017 2001-09-07 Ravi Pratap <ravi@ximian.com>
28019 * cs-tokenizer.cs (location): Return a string which also contains
28022 * expression.cs (ElementAccess): New class for expressions of the
28023 type 'element access.'
28024 (BaseAccess): New class for expressions of the type 'base access.'
28025 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
28028 * cs-parser.jay (element_access): Implement action.
28029 (base_access): Implement actions.
28030 (checked_expression, unchecked_expression): Implement.
28032 * cs-parser.jay (local_variable_type): Correct and implement.
28033 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
28035 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
28037 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
28038 name and the specifiers.
28040 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
28042 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
28043 making them all public ;-)
28045 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
28048 2001-09-07 Miguel de Icaza <miguel@ximian.com>
28050 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
28052 (FieldExpr, PropertyExprs): New resolved expressions.
28053 (SimpleName::MemberStaticCheck): Perform static checks for access
28054 to non-static fields on static methods. Maybe this should be
28055 generalized for MemberAccesses.
28056 (SimpleName::ResolveSimpleName): More work on simple name
28059 * cs-parser.jay (primary_expression/qualified_identifier): track
28060 the parameter index.
28062 * codegen.cs (CodeGen::Save): Catch save exception, report error.
28063 (EmitContext::EmitBoolExpression): Chain to expression generation
28064 instead of temporary hack.
28065 (::EmitStatementExpression): Put generic expression code generation.
28067 * assign.cs (Assign::Emit): Implement variable assignments to
28068 local variables, parameters and fields.
28070 2001-09-06 Miguel de Icaza <miguel@ximian.com>
28072 * statement.cs (Block::GetVariableInfo): New method, returns the
28073 VariableInfo for a variable name in a block.
28074 (Block::GetVariableType): Implement in terms of GetVariableInfo
28076 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
28077 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
28079 2001-09-06 Ravi Pratap <ravi@ximian.com>
28081 * cs-parser.jay (operator_declaration): Continue on my quest : update
28082 to take attributes argument.
28083 (event_declaration): Ditto.
28084 (enum_declaration): Ditto.
28085 (indexer_declaration): Ditto.
28087 * class.cs (Operator::Operator): Update constructor accordingly.
28088 (Event::Event): Ditto.
28090 * delegate.cs (Delegate::Delegate): Same here.
28092 * enum.cs (Enum::Enum): Same here.
28094 2001-09-05 Ravi Pratap <ravi@ximian.com>
28096 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
28098 * ../tests/cs0658.cs : New file to demonstrate error 0658.
28100 * attribute.cs (Attributes): New class to encapsulate all attributes which were
28101 being passed around as an arraylist.
28102 (Attributes::AddAttribute): Method to add attribute sections.
28104 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
28105 (struct_declaration): Update accordingly.
28106 (constant_declaration): Update.
28107 (field_declaration): Update.
28108 (method_header): Update.
28109 (fixed_parameter): Update.
28110 (parameter_array): Ditto.
28111 (property_declaration): Ditto.
28112 (destructor_declaration): Ditto.
28114 * class.cs (Struct::Struct): Update constructors accordingly.
28115 (Class::Class): Ditto.
28116 (Field::Field): Ditto.
28117 (Method::Method): Ditto.
28118 (Property::Property): Ditto.
28119 (TypeContainer::OptAttribute): update property's return type.
28121 * interface.cs (Interface.opt_attributes): New member.
28122 (Interface::Interface): Update to take the extra Attributes argument.
28124 * parameter.cs (Parameter::Parameter): Ditto.
28126 * constant.cs (Constant::Constant): Ditto.
28128 * interface.cs (InterfaceMemberBase): New OptAttributes field.
28129 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
28130 the attributes as a parameter.
28131 (InterfaceProperty): Update constructor call.
28132 (InterfaceEvent): Ditto.
28133 (InterfaceMethod): Ditto.
28134 (InterfaceIndexer): Ditto.
28136 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
28137 pass the attributes too.
28138 (interface_event_declaration): Ditto.
28139 (interface_property_declaration): Ditto.
28140 (interface_method_declaration): Ditto.
28141 (interface_declaration): Ditto.
28143 2001-09-05 Miguel de Icaza <miguel@ximian.com>
28145 * class.cs (Method::Define): Track the "static Main" definition to
28146 create an entry point.
28148 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
28149 EntryPoint if we find it.
28151 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
28152 (EmitContext::ig): Make this variable public.
28154 * driver.cs: Make the default output file be the first file name
28155 with the .exe extension.
28157 Detect empty compilations
28159 Handle various kinds of output targets. Handle --target and
28160 rename -t to --dumper.
28162 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
28163 methods inherited from Expression return now an Expression. This
28164 will is used during the tree rewriting as we resolve them during
28167 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
28168 the spec. Missing entirely is the information about
28169 accessability of elements of it.
28171 (Expression::ExprClassFromMemberInfo): New constructor for
28172 Expressions that creates a fully initialized Expression based on
28173 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
28176 (Invocation::Resolve): Begin implementing resolution of invocations.
28178 * literal.cs (StringLiteral): Implement Emit.
28180 2001-09-05 Ravi Pratap <ravi@ximian.com>
28182 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
28185 2001-09-04 Ravi Pratap <ravi@ximian.com>
28187 * cs-parser.jay (attribute_arguments): Implement actions.
28188 (attribute): Fix bug in production. Implement action.
28189 (attribute_list): Implement.
28190 (attribute_target): Implement.
28191 (attribute_target_specifier, opt_target_specifier): Implement
28192 (CheckAttributeTarget): New method to check if the attribute target
28194 (attribute_section): Implement.
28195 (opt_attributes): Implement.
28197 * attribute.cs : New file to handle attributes.
28198 (Attribute): Class to hold attribute info.
28200 * cs-parser.jay (opt_attribute_target_specifier): Remove production
28201 (attribute_section): Modify production to use 2 different rules to
28202 achieve the same thing. 1 s/r conflict down !
28203 Clean out commented, useless, non-reducing dimension_separator rules.
28205 * class.cs (TypeContainer.attributes): New member to hold list
28206 of attributes for a type.
28207 (Struct::Struct): Modify to take one more argument, the attribute list.
28208 (Class::Class): Ditto.
28209 (Field::Field): Ditto.
28210 (Method::Method): Ditto.
28211 (Property::Property): Ditto.
28213 * cs-parser.jay (struct_declaration): Update constructor call to
28214 pass in the attributes too.
28215 (class_declaration): Ditto.
28216 (constant_declaration): Ditto.
28217 (field_declaration): Ditto.
28218 (method_header): Ditto.
28219 (fixed_parameter): Ditto.
28220 (parameter_array): Ditto.
28221 (property_declaration): Ditto.
28223 * constant.cs (Constant::Constant): Update constructor similarly.
28224 Use System.Collections.
28226 * parameter.cs (Parameter::Parameter): Update as above.
28228 2001-09-02 Ravi Pratap <ravi@ximian.com>
28230 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
28231 (TypeContainer.delegates): New member to hold list of delegates.
28233 * cs-parser.jay (delegate_declaration): Implement the action correctly
28234 this time as I seem to be on crack ;-)
28236 2001-09-02 Miguel de Icaza <miguel@ximian.com>
28238 * rootcontext.cs (RootContext::IsNamespace): new function, used to
28239 tell whether an identifier represents a namespace.
28241 * expression.cs (NamespaceExpr): A namespace expression, used only
28242 temporarly during expression resolution.
28243 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
28244 utility functions to resolve names on expressions.
28246 2001-09-01 Miguel de Icaza <miguel@ximian.com>
28248 * codegen.cs: Add hook for StatementExpressions.
28250 * class.cs: Fix inverted test for static flag in methods.
28252 2001-09-02 Ravi Pratap <ravi@ximian.com>
28254 * class.cs (Operator::CheckUnaryOperator): Correct error number used
28255 to make it coincide with MS' number.
28256 (Operator::CheckBinaryOperator): Ditto.
28258 * ../errors/errors.txt : Remove error numbers added earlier.
28260 * ../errors/cs1019.cs : Test case for error # 1019
28262 * ../errros/cs1020.cs : Test case for error # 1020
28264 * cs-parser.jay : Clean out commented cruft.
28265 (dimension_separators, dimension_separator): Comment out. Ostensibly not
28266 used anywhere - non-reducing rule.
28267 (namespace_declarations): Non-reducing rule - comment out.
28269 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
28270 with TypeContainer::AddEnum.
28272 * delegate.cs : New file for delegate handling classes.
28273 (Delegate): Class for declaring delegates.
28275 * makefile : Update.
28277 * cs-parser.jay (delegate_declaration): Implement.
28279 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
28281 * class.cs (Event::Define): Implement.
28282 (Event.EventBuilder): New member.
28284 * class.cs (TypeContainer::Populate): Update to define all enums and events
28286 (Events): New property for the events arraylist we hold. Shouldn't we move to using
28287 readonly fields for all these cases ?
28289 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28291 * class.cs (Property): Revamp to use the convention of making fields readonly.
28292 Accordingly modify code elsewhere.
28294 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
28295 the Define method of the Property class.
28297 * class.cs : Clean up applied patch and update references to variables etc. Fix
28299 (TypeContainer::Populate): Update to define all the properties we have. Also
28300 define all enumerations.
28302 * enum.cs (Define): Implement.
28304 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28306 * cs-parser.jay (overloadable_operator): The semantic value is an
28307 enum of the Operator class.
28308 (operator_declarator): Implement actions.
28309 (operator_declaration): Implement.
28311 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
28312 validity of definitions.
28313 (Operator::CheckBinaryOperator): Static method to check for binary operators
28314 (TypeContainer::AddOperator): New method to add an operator to a type.
28316 * cs-parser.jay (indexer_declaration): Added line to actually call the
28317 AddIndexer method so it gets added ;-)
28319 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
28320 already taken care of by the MS compiler ?
28322 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28324 * class.cs (Operator): New class for operator declarations.
28325 (Operator::OpType): Enum for the various operators.
28327 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28329 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
28330 ostensibly handle this in semantic analysis.
28332 * cs-parser.jay (general_catch_clause): Comment out
28333 (specific_catch_clauses, specific_catch_clause): Ditto.
28334 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
28335 (catch_args, opt_catch_args): New productions.
28336 (catch_clause): Rewrite to use the new productions above
28337 (catch_clauses): Modify accordingly.
28338 (opt_catch_clauses): New production to use in try_statement
28339 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
28340 and re-write the code in the actions to extract the specific and
28341 general catch clauses by being a little smart ;-)
28343 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
28344 Hooray, try and catch statements parse fine !
28346 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28348 * statement.cs (Block::GetVariableType): Fix logic to extract the type
28349 string from the hashtable of variables.
28351 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
28352 I end up making that mistake ;-)
28353 (catch_clauses): Fixed gross error which made Key and Value of the
28354 DictionaryEntry the same : $1 !!
28356 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28358 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
28360 * cs-parser.jay (event_declaration): Correct to remove the semicolon
28361 when the add and remove accessors are specified.
28363 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28365 * cs-parser.jay (IndexerDeclaration): New helper class to hold
28366 information about indexer_declarator.
28367 (indexer_declarator): Implement actions.
28368 (parsing_indexer): New local boolean used to keep track of whether
28369 we are parsing indexers or properties. This is necessary because
28370 implicit_parameters come into picture even for the get accessor in the
28371 case of an indexer.
28372 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
28374 * class.cs (Indexer): New class for indexer declarations.
28375 (TypeContainer::AddIndexer): New method to add an indexer to a type.
28376 (TypeContainer::indexers): New member to hold list of indexers for the
28379 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28381 * cs-parser.jay (add_accessor_declaration): Implement action.
28382 (remove_accessor_declaration): Implement action.
28383 (event_accessors_declaration): Implement
28384 (variable_declarators): swap statements for first rule - trivial.
28386 * class.cs (Event): New class to hold information about event
28388 (TypeContainer::AddEvent): New method to add an event to a type
28389 (TypeContainer::events): New member to hold list of events.
28391 * cs-parser.jay (event_declaration): Implement actions.
28393 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28395 * cs-parser.jay (dim_separators): Implement. Make it a string
28396 concatenating all the commas together, just as they appear.
28397 (opt_dim_separators): Modify accordingly
28398 (rank_specifiers): Update accordingly. Basically do the same
28399 thing - instead, collect the brackets here.
28400 (opt_rank_sepcifiers): Modify accordingly.
28401 (array_type): Modify to actually return the complete type string
28402 instead of ignoring the rank_specifiers.
28403 (expression_list): Implement to collect the expressions
28404 (variable_initializer): Implement. We make it a list of expressions
28405 essentially so that we can handle the array_initializer case neatly too.
28406 (variable_initializer_list): Implement.
28407 (array_initializer): Make it a list of variable_initializers
28408 (opt_array_initializer): Modify accordingly.
28410 * expression.cs (New::NType): Add enumeration to help us
28411 keep track of whether we have an object/delegate creation
28412 or an array creation.
28413 (New:NewType, New::Rank, New::Indices, New::Initializers): New
28414 members to hold data about array creation.
28415 (New:New): Modify to update NewType
28416 (New:New): New Overloaded contructor for the array creation
28419 * cs-parser.jay (array_creation_expression): Implement to call
28420 the overloaded New constructor.
28422 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
28424 * class.cs (TypeContainer::Constructors): Return member
28425 constructors instead of returning null.
28427 2001-08-26 Miguel de Icaza <miguel@ximian.com>
28429 * typemanager.cs (InitCoreTypes): Initialize the various core
28430 types after we have populated the type manager with the user
28431 defined types (this distinction will be important later while
28432 compiling corlib.dll)
28434 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
28435 on Expression Classification. Now all expressions have a method
28436 `Resolve' and a method `Emit'.
28438 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
28439 generation from working. Also add some temporary debugging
28442 2001-08-24 Miguel de Icaza <miguel@ximian.com>
28444 * codegen.cs: Lots of code generation pieces. This is only the
28445 beginning, will continue tomorrow with more touches of polish. We
28446 handle the fundamentals of if, while, do, for, return. Others are
28447 trickier and I need to start working on invocations soon.
28449 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28452 * codegen.cs (EmitContext): New struct, used during code
28453 emission to keep a context. Most of the code generation will be
28456 * cs-parser.jay: Add embedded blocks to the list of statements of
28457 this block. So code generation proceeds in a top down fashion.
28459 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28461 * statement.cs: Add support for multiple child blocks.
28463 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28465 * codegen.cs (EmitCode): New function, will emit the code for a
28466 Block of code given a TypeContainer and its ILGenerator.
28468 * statement.cs (Block): Standard public readonly optimization.
28469 (Block::Block constructors): Link children.
28470 (Block::Child): Child Linker.
28471 (Block::EmitVariables): Emits IL variable declarations.
28473 * class.cs: Drop support for MethodGroups here, delay until
28475 (Method::): Applied the same simplification that I did before, and
28476 move from Properties to public readonly fields.
28477 (Method::ParameterTypes): Returns the parameter types for the
28478 function, and implements a cache that will be useful later when I
28479 do error checking and the semantic analysis on the methods is
28481 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28482 and made a method, optional argument tells whether this is a class
28483 or a structure to apply the `has-this' bit.
28484 (Method::GetCallingConvention): Implement, returns the calling
28486 (Method::Define): Defines the type, a second pass is performed
28487 later to populate the methods.
28489 (Constructor::ParameterTypes): implement a cache similar to the
28490 one on Method::ParameterTypes, useful later when we do semantic
28493 (TypeContainer::EmitMethod): New method. Emits methods.
28495 * expression.cs: Removed MethodGroup class from here.
28497 * parameter.cs (Parameters::GetCallingConvention): new method.
28499 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28501 * class.cs (TypeContainer::Populate): Drop RootContext from the
28504 (Constructor::CallingConvention): Returns the calling convention.
28505 (Constructor::ParameterTypes): Returns the constructor parameter
28508 (TypeContainer::AddConstructor): Keep track of default constructor
28509 and the default static constructor.
28511 (Constructor::) Another class that starts using `public readonly'
28512 instead of properties.
28514 (Constructor::IsDefault): Whether this is a default constructor.
28516 (Field::) use readonly public fields instead of properties also.
28518 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28519 track of static constructors; If none is used, turn on
28520 BeforeFieldInit in the TypeAttributes.
28522 * cs-parser.jay (opt_argument_list): now the return can be null
28523 for the cases where there are no arguments.
28525 (constructor_declarator): If there is no implicit `base' or
28526 `this', then invoke the default parent constructor.
28528 * modifiers.cs (MethodAttr): New static function maps a set of
28529 modifiers flags into a MethodAttributes enum
28530 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28531 MethodAttr, TypeAttr to represent the various mappings where the
28532 modifiers are used.
28533 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28535 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28537 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28540 * interface.cs (PopulateIndexer): Implemented the code generator
28541 for interface indexers.
28543 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28545 * interface.cs (InterfaceMemberBase): Now we track the new status
28548 (PopulateProperty): Implement property population. Woohoo! Got
28549 Methods and Properties going today.
28551 Removed all the properties for interfaces, and replaced them with
28552 `public readonly' fields.
28554 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28556 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28557 initialize their hashtables/arraylists only when they are needed
28558 instead of doing this always.
28560 * parameter.cs: Handle refs and out parameters.
28562 * cs-parser.jay: Use an ArrayList to construct the arguments
28563 instead of the ParameterCollection, and then cast that to a
28566 * parameter.cs: Drop the use of ParameterCollection and use
28567 instead arrays of Parameters.
28569 (GetParameterInfo): Use the Type, not the Name when resolving
28572 2001-08-13 Miguel de Icaza <miguel@ximian.com>
28574 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
28575 and instead use public readonly fields.
28577 * class.cs: Put back walking code for type containers.
28579 2001-08-11 Miguel de Icaza <miguel@ximian.com>
28581 * class.cs (MakeConstant): Code to define constants.
28583 * rootcontext.cs (LookupType): New function. Used to locate types
28586 2001-08-08 Miguel de Icaza <miguel@ximian.com>
28588 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
28589 this System.Reflection code is. Kudos to Microsoft
28591 * typemanager.cs: Implement a type cache and avoid loading all
28592 types at boot time. Wrap in LookupType the internals. This made
28593 the compiler so much faster. Wow. I rule!
28595 * driver.cs: Make sure we always load mscorlib first (for
28596 debugging purposes, nothing really important).
28598 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
28599 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
28601 * rootcontext.cs: Lookup types on their namespace; Lookup types
28602 on namespaces that have been imported using the `using' keyword.
28604 * class.cs (TypeContainer::TypeAttr): Virtualize.
28605 (Class::TypeAttr): Return attributes suitable for this bad boy.
28606 (Struct::TypeAttr): ditto.
28607 Handle nested classes.
28608 (TypeContainer::) Remove all the type visiting code, it is now
28609 replaced with the rootcontext.cs code
28611 * rootcontext.cs (GetClassBases): Added support for structs.
28613 2001-08-06 Miguel de Icaza <miguel@ximian.com>
28615 * interface.cs, statement.cs, class.cs, parameter.cs,
28616 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
28617 Drop use of TypeRefs, and use strings instead.
28619 2001-08-04 Miguel de Icaza <miguel@ximian.com>
28623 * class.cs (Struct::Struct): set the SEALED flags after
28624 checking the modifiers.
28625 (TypeContainer::TypeAttr): new property, returns the
28626 TypeAttributes for a class.
28628 * cs-parser.jay (type_list): Oops, list production was creating a
28629 new list of base types.
28631 * rootcontext.cs (StdLib): New property.
28632 (GetInterfaceTypeByName): returns an interface by type name, and
28633 encapsulates error handling here.
28634 (GetInterfaces): simplified.
28635 (ResolveTree): Encapsulated all the tree resolution here.
28636 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
28639 * driver.cs: Add support for --nostdlib, to avoid loading the
28640 default assemblies.
28641 (Main): Do not put tree resolution here.
28643 * rootcontext.cs: Beginning of the class resolution.
28645 2001-08-03 Miguel de Icaza <miguel@ximian.com>
28647 * rootcontext.cs: Provide better error reporting.
28649 * cs-parser.jay (interface_base): set our $$ to be interfaces.
28651 * rootcontext.cs (CreateInterface): Handle the case where there
28652 are no parent interfaces.
28654 (CloseTypes): Routine to flush types at the end.
28655 (CreateInterface): Track types.
28656 (GetInterfaces): Returns an array of Types from the list of
28657 defined interfaces.
28659 * typemanager.c (AddUserType): Mechanism to track user types (puts
28660 the type on the global type hash, and allows us to close it at the
28663 2001-08-02 Miguel de Icaza <miguel@ximian.com>
28665 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
28666 RecordInterface instead.
28668 * cs-parser.jay: Updated to reflect changes above.
28670 * decl.cs (Definition): Keep track of the TypeBuilder type that
28671 represents this type here. Not sure we will use it in the long
28672 run, but wont hurt for now.
28674 * driver.cs: Smaller changes to accomodate the new code.
28676 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
28679 * rootcontext.cs (CreateInterface): New method, used to create
28680 the System.TypeBuilder type for interfaces.
28681 (ResolveInterfaces): new entry point to resolve the interface
28683 (CodeGen): Property, used to keep track of the code generator.
28685 2001-07-26 Miguel de Icaza <miguel@ximian.com>
28687 * cs-parser.jay: Add a second production for delegate_declaration
28690 (enum_body): Put an opt_comma here instead of putting it on
28691 enum_body or enum_member_declarations so we can handle trailing
28692 commas on enumeration members. Gets rid of a shift/reduce.
28694 (type_list): Need a COMMA in the middle.
28696 (indexer_declaration): Tell tokenizer to recognize get/set
28698 * Remove old targets.
28700 * Re-add the parser target.
28702 2001-07-13 Simon Cozens <simon@simon-cozens.org>
28704 * cs-parser.jay: Add precendence rules for a number of operators
28705 ot reduce the number of shift/reduce conflicts in the grammar.
28707 2001-07-17 Miguel de Icaza <miguel@ximian.com>
28709 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
28712 Get rid of old crufty code.
28714 * rootcontext.cs: Use this to keep track of the parsed
28715 representation and the defined types available to the program.
28717 * gen-treedump.cs: adjust for new convention.
28719 * type.cs: Split out the type manager, and the assembly builder
28722 * typemanager.cs: the type manager will live here now.
28724 * cil-codegen.cs: And the code generator here.
28726 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
28728 * makefile: Fixed up for easy making.
28730 2001-07-13 Simon Cozens <simon@simon-cozens.org>
28732 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
28735 (unary_expression): Expand pre_increment_expression and
28736 post_decrement_expression to reduce a shift/reduce.
28738 2001-07-11 Simon Cozens
28740 * cs-tokenizer.cs: Hex numbers should begin with a 0.
28742 Improve allow_keyword_as_indent name.
28744 2001-06-19 Miguel de Icaza <miguel@ximian.com>
28746 * Adjustments for Beta2.
28748 2001-06-13 Miguel de Icaza <miguel@ximian.com>
28750 * decl.cs: Added `Define' abstract method.
28751 (InTransit): new property, used to catch recursive definitions.
28753 * interface.cs: Implement `Define'.
28755 * modifiers.cs: Map Modifiers.constants to
28756 System.Reflection.TypeAttribute flags.
28758 * class.cs: Keep track of types and user-defined types.
28759 (BuilderInit): New method for creating an assembly
28760 (ResolveType): New function to launch the resolution process, only
28761 used by interfaces for now.
28763 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
28764 that are inserted into the name space.
28766 2001-06-08 Miguel de Icaza <miguel@ximian.com>
28768 * ARGH. I have screwed up my tree so many times due to the use of
28769 rsync rather than using CVS. Going to fix this at once.
28771 * driver.cs: Objetify driver. Load assemblies, use assemblies to
28774 2001-06-07 Miguel de Icaza <miguel@ximian.com>
28776 * Experiment successful: Use System.Type rather that our own
28779 2001-05-25 Miguel de Icaza <miguel@ximian.com>
28781 * cs-parser.jay: Removed nsAliases from here.
28783 Use new namespaces, handle `using XXX;'
28785 * namespace.cs: Reimplemented namespace handling, use a recursive
28786 definition of the class. Now we can keep track of using clauses
28787 and catch invalid using clauses.
28789 2001-05-24 Miguel de Icaza <miguel@ximian.com>
28791 * gen-treedump.cs: Adapted for all the renaming.
28793 * expression.cs (Expression): this class now has a Type property
28794 which returns an expression Type.
28796 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
28797 `Type', as this has a different meaning now in the base
28799 2001-05-22 Miguel de Icaza <miguel@ximian.com>
28801 * interface.cs, class.cs: Removed from all the sources the
28802 references to signature computation, as we can not do method
28803 signature computation during the parsing time, as we are not
28804 trying to solve at that point distinguishing:
28808 void a (NS.Blah x) {}
28811 Which depending on the context might be valid or not, as we do not
28812 know if Blah is the same thing as NS.Blah at that point.
28814 * Redid everything so the code uses TypeRefs now instead of
28815 Types. TypeRefs are just temporary type placeholders, that need
28816 to be resolved. They initially have a pointer to a string and the
28817 current scope in which they are used. This is used later by the
28818 compiler to resolve the reference to an actual Type.
28820 * DeclSpace is no longer a CIR.Type, and neither are
28821 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
28822 are all DeclSpaces, but no Types.
28824 * type.cs (TypeRefManager): This implements the TypeRef manager,
28825 which keeps track of all the types that need to be resolved after
28826 the parsing has finished.
28828 2001-05-13 Miguel de Icaza <miguel@ximian.com>
28830 * ARGH. We are going to have to store `foreach' as a class rather
28831 than resolving it, as we need to verify error 1579 after name
28832 resolution. *OR* we could keep a flag that says `This request to
28833 IEnumerator comes from a foreach statement' which we can then use
28834 to generate the error.
28836 2001-05-10 Miguel de Icaza <miguel@ximian.com>
28838 * class.cs (TypeContainer.AddMethod): we now add methods to the
28839 MethodGroup instead of the method hashtable.
28841 * expression.cs: Add MethodGroup abstraction, which gets us one
28842 step closer to the specification in the way we handle method
28845 * cs-parser.jay (primary_expression): qualified_identifier now
28846 tried to match up an identifier to a local variable reference or
28847 to a parameter reference.
28849 current_local_parameters is now a parser global variable that
28850 points to the current parameters for the block, used during name
28853 (property_declaration): Now creates an implicit `value' argument to
28856 2001-05-09 Miguel de Icaza <miguel@ximian.com>
28858 * parameter.cs: Do not use `param' arguments as part of the
28859 signature, per the spec.
28861 2001-05-08 Miguel de Icaza <miguel@ximian.com>
28863 * decl.cs: Base class for classes, structs and interfaces. This
28864 is the "Declaration Space"
28866 * cs-parser.jay: Use CheckDef for checking declaration errors
28867 instead of having one on each function.
28869 * class.cs: Factor out some code for handling error handling in
28870 accordance to the "Declarations" section in the "Basic Concepts"
28871 chapter in the ECMA C# spec.
28873 * interface.cs: Make all interface member classes derive from
28874 InterfaceMemberBase.
28876 2001-05-07 Miguel de Icaza <miguel@ximian.com>
28878 * Many things: all interfaces are parsed and generated in
28879 gen-treedump. Support for member variables, constructors,
28880 destructors, properties, constants is there.
28882 Beginning of the IL backend, but very little done, just there for
28885 2001-04-29 Miguel de Icaza <miguel@ximian.com>
28887 * cs-parser.jay: Fix labeled statement.
28889 * cs-tokenizer.cs (escape): Escape " and ' always.
28890 ref_line, ref_name: keep track of the line/filename as instructed
28891 by #line by the compiler.
28894 2001-04-27 Miguel de Icaza <miguel@ximian.com>
28896 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
28897 to match the values in System.CodeDOM.
28899 Divid renamed to Divide.
28901 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
28903 (Statements.set): remove.
28905 * System.CodeDOM/CodeCatchClause.cs: always have a valid
28908 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
28909 falseStatements always have valid values.
28911 * cs-parser.jay: Use System.CodeDOM now.