1 2008-05-20 Marek Safar <marek.safar@gmail.com>
4 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
6 2008-05-15 Marek Safar <marek.safar@gmail.com>
9 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
12 2008-05-15 Marek Safar <marek.safar@gmail.com>
14 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
17 2008-05-13 Marek Safar <marek.safar@gmail.com>
20 * delegate.cs, generic.cs: Some progress on method group return type
23 2008-05-13 Marek Safar <marek.safar@gmail.com>
26 * namespace.cs: Inspect also parent namespaces not only namespace entries.
28 2008-05-12 Marek Safar <marek.safar@gmail.com>
30 * class.cs (Constructor): Added IsCompilerGenerated.
32 2008-05-12 Marek Safar <marek.safar@gmail.com>
34 * expression.cs: Enum binary operators can accept non-enum operand only when
35 is implicitly convertible to underlying type.
37 2008-05-12 Marek Safar <marek.safar@gmail.com>
40 * support.cs: Workaround System.InvalidOperationException for enums.
42 2008-05-12 Marek Safar <marek.safar@gmail.com>
45 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
47 2008-05-10 Marek Safar <marek.safar@gmail.com>
49 * driver.cs: Split Parse.
51 * location.cs (LookupFile): Uses string.Empty.
53 2008-05-07 Marek Safar <marek.safar@gmail.com>
55 * expression.cs, parameter.cs: Small ParameterReference clean up.
57 2008-05-07 Marek Safar <marek.safar@gmail.com>
59 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
62 2008-05-06 Martin Baulig <martin@ximian.com>
64 * class.cs (Constructor.Emit): Fix the logic whether to emit
67 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
70 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
71 InvalidOperationException when the iterator is before the start or
74 2008-05-06 Marek Safar <marek.safar@gmail.com>
76 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
77 when left is nullable type.
79 2008-05-06 Marek Safar <marek.safar@gmail.com>
82 * expression.cs (LocalVariableReference): Continue in resolving when
83 variable is not assigned.
85 2008-05-05 Marek Safar <marek.safar@gmail.com>
87 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
90 2008-05-04 Marek Safar <marek.safar@gmail.com>
92 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
93 it saves many redundant temporary variables for nullable operations.
95 2008-05-03 Marek Safar <marek.safar@gmail.com>
97 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
99 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
102 * nullable.cs: Constant coalescing operator optimizations.
104 2008-05-03 Marek Safar <marek.safar@gmail.com>
106 * constant.cs: Use unsigned conversion for values which are unsigned only.
108 2008-05-03 Marek Safar <marek.safar@gmail.com>
110 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
111 coalescing operator as it should be.
113 2008-05-02 Marek Safar <marek.safar@gmail.com>
115 A fix for bug #371016
116 * expression.cs: All predefined delegate operators require implicit method
119 2008-05-02 Marek Safar <marek.safar@gmail.com>
121 * constant.cs: Emit long constant as uint when fits the range.
123 * convert.cs, expression.cs: Fixed few unsafe conversions.
125 2008-05-02 Marek Safar <marek.safar@gmail.com>
127 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
129 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
132 * convert.cs (ImplicitNumericConversion): Don't modify the type of
134 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
136 2008-05-01 Marek Safar <marek.safar@gmail.com>
138 * constant.cs, literal.cs: IsLiteral property for error reporting.
140 * ecore.cs, expression.cs: Implemented Property expression.
142 2008-05-01 Marek Safar <marek.safar@gmail.com>
144 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
146 * nullable.cs: Implemented nullable coalescing null operator.
148 * ecore.cs, expression.cs: Expression trees work.
150 2008-05-01 Marek Safar <marek.safar@gmail.com>
152 * ecore.cs: CreateExpressionTree is finally abstract.
154 * expression.cs, linq.cs: Updated.
156 2008-05-01 Marek Safar <marek.safar@gmail.com>
158 * expression.cs, ecore.cs: Block base access expression inside expression
161 2008-05-01 Marek Safar <marek.safar@gmail.com>
163 A fix for bug #385058
164 * expression.cs: User-defined operator implementations always take
165 precedence over predefined operator implementations.
167 2008-04-30 Marek Safar <marek.safar@gmail.com>
169 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
170 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
171 expression tree conversions.
173 2008-04-30 Marek Safar <marek.safar@gmail.com>
175 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
176 operators method details to Operator class.
178 2008-04-30 Marek Safar <marek.safar@gmail.com>
180 * anonymous.cs: Pass unsafe flags to anonymous container.
182 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
183 inside expression tree.
185 2008-04-29 Martin Baulig <martin@ximian.com>
187 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
188 (Tokenizer.PopPosition): Also restore the `line'.
190 2008-04-29 Marek Safar <marek.safar@gmail.com>
192 * delegate.cs: Implemented Invoke expression.
194 2008-04-29 Marek Safar <marek.safar@gmail.com>
196 * expression.cs: Fixed equality reference comparison regression.
198 2008-04-29 Marek Safar <marek.safar@gmail.com>
200 * ecore.cs: Clean up EmptyCast hack.
202 * expression.cs, nullable.cs: Implemented enum binary and unary operations
203 using correct conversion rules. Also fixes #383993.
205 2008-04-28 Martin Baulig <martin@ximian.com>
207 * class.cs (Constructor.Emit): Don't emit debugging information
208 for generated default .ctor's.
210 2008-04-28 Marek Safar <marek.safar@gmail.com>
212 * convert.cs: Empty-cast ushort to int conversion.
214 2008-04-28 Marek Safar <marek.safar@gmail.com>
216 A fix for bug #384191
217 * ecore.cs, expression.cs: Fixed expression cloning.
219 2008-04-28 Marek Safar <marek.safar@gmail.com>
221 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
223 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
225 Fix #381559, test-638.cs, test-639.cs
226 * assign.cs (CompoundAssign.Helper): New wrapper.
227 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
229 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
230 Pass unconverted expressions to the params array creation expression.
231 (FieldExpr.EmitAssign): Don't special-case StringConcat.
232 (PropertyExpr.EmitAssign): Likewise.
233 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
234 element if it is of kind CompoundAssign.Helper.
235 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
236 first before anything else.
237 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
238 (ArrayAccess.LoadArrayAndArguments): Simplify.
240 2008-04-27 Marek Safar <marek.safar@gmail.com>
242 * expression.cs: Fixed cloning of typeof(void).
244 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
246 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
247 (Assign.Emit): Likewise. Move it to ...
248 (CompoundAssign.DoResolve): ... here and ...
249 (CompoundAssign.Emit): ... here.
250 (EventAddOrRemove): New helper to handle += and -= on events, and
251 avoid the use of BinaryDelegates.
252 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
253 (EventExpr.EmitAddOrRemove): Improve.
254 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
256 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
257 create VarExprs for 'foo.bar.var'.
258 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
259 is a highly inappropriate name for its functionality.
261 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
263 Simplify handling of multiple assignments
264 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
266 (SimpleAssign): New. Class to be used for normal assignments.
267 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
268 * expression.cs, parameter.cs, statement.cs: Likewise.
270 2008-04-25 Marek Safar <marek.safar@gmail.com>
272 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
273 for incompatible underlying types, more to come, uff.
275 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
278 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
281 2008-04-25 Marek Safar <marek.safar@gmail.com>
283 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
285 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
287 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
288 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
289 * statement.cs (While, Do, For): Allow test to have side effects.
290 (For.DoEmit): Always emit InitStatement.
293 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
294 Always create SideEffectConstant.
295 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
296 of type EnumConstant.
298 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
299 Handle 'right' being SideEffectConstant of type 'bool'.
301 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
302 Use left.EmitBranchable instead of open coding it, so as to
303 improve optimization opportunities.
305 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
307 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
309 (Expression.EmitSideEffect): Document.
311 2008-04-23 Marek Safar <marek.safar@gmail.com>
313 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
315 2008-04-23 Marek Safar <marek.safar@gmail.com>
317 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
319 2008-04-23 Marek Safar <marek.safar@gmail.com>
321 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
322 conversion to expression tree.
324 2008-04-23 Marek Safar <marek.safar@gmail.com>
326 * ecore.cs: Removed unused expression.
328 2008-04-22 Marek Safar <marek.safar@gmail.com>
330 * expression.cs: Implemented NegateChecked and New expressions.
332 2008-04-22 Marek Safar <marek.safar@gmail.com>
334 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
336 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
339 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
340 needing final 'ret' instruction.
342 2008-04-22 Marek Safar <marek.safar@gmail.com>
344 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
346 2008-04-21 Marek Safar <marek.safar@gmail.com>
348 * expression.cs: Emit ldnull and not null expression as an instance argument
349 of static method expression calls.
351 2008-04-21 Marek Safar <marek.safar@gmail.com>
353 A fix for bug #378200
354 * expression.cs: Fixed crash when creating parameterless expression tree
357 2008-04-21 Marek Safar <marek.safar@gmail.com>
359 A fix for bug #375297
360 * anonymous.cs: Fixed crash when inferring from null argument anonymous
363 2008-04-21 Marek Safar <marek.safar@gmail.com>
365 A fix for bug #377596
366 * decl.cs, class.cs: Emit delegate type argument attributes.
368 2008-04-21 Marek Safar <marek.safar@gmail.com>
370 A fix for bug #365314
371 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
373 2008-04-21 Marek Safar <marek.safar@gmail.com>
375 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
378 2008-04-21 Marek Safar <marek.safar@gmail.com>
380 * generic.cs (TypeParameter): Removed redundant location.
382 2008-04-19 Marek Safar <marek.safar@gmail.com>
384 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
385 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
386 FullNamedExpression in all declaration type expression, statements will come
389 2008-04-18 Marek Safar <marek.safar@gmail.com>
391 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
392 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
394 2008-04-18 Marek Safar <marek.safar@gmail.com>
396 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
399 2008-04-17 Marek Safar <marek.safar@gmail.com>
401 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
404 2008-04-17 Marek Safar <marek.safar@gmail.com>
406 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
410 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
412 Hook up 'EmitSideEffect'
413 * constant.cs (Constant.EmitSideEffect): New.
414 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
415 (SideEffectConstant.EmitSideEffect): New.
416 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
417 unconditional branch in EmitBranchable.
418 (FieldExpr.EmitBranchable): New.
419 * expression.cs (Unary.EmitSideEffect): New.
420 (Binary.EmitSideEffect): New.
421 (VariableReference.EmitSideEffect): New. Do nothing.
423 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
425 Introduce 'EmitSideEffect'
426 * ecore.cs (Expression.EmitSideEffect): New.
427 (TypeCast): Rename from EmptyCast.
429 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
430 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
431 * convert.cs, nullable.cs: Update to changes.
433 2008-04-16 Marek Safar <marek.safar@gmail.com>
435 * class.cs, cs-parser.jay: Early check for base types expression.
437 2008-04-16 Marek Safar <marek.safar@gmail.com>
439 * decl.cs (MemberName): Declare PrettyName as obsolete.
441 2008-04-16 Marek Safar <marek.safar@gmail.com>
443 * namespace.cs: Use MemberName comparison.
445 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
448 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
450 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
451 (MemberName.FullyQualifiedName): New. Provides the functionality
452 that users assume FullName would have.
453 * ecore.cs, namespace.cs: Update to changes.
455 * statement.cs (Using.assign): Make into ExpressionStatement.
456 (Using.EmitPreTryBody): Simplify.
458 2008-04-16 Marek Safar <marek.safar@gmail.com>
460 * report.cs: ColorFormat is protected.
462 * rootcontext.cs: Unused fields clean-up.
464 * namespace.cs: Made UsingEntry name private.
466 2008-04-16 Marek Safar <marek.safar@gmail.com>
468 * cs-tokenizer.cs, location.cs: Removed unused field.
470 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
471 Raja R Harinath <harinath@hurrynot.org>
474 * constant.cs (SideEffectConstant.value): Rename from 'left'.
475 (SideEffectConstant.side_effect): Rename from 'right'.
476 (SideEffectConstant..ctor): Normalize 'side_effect'.
477 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
478 value of this constant.
479 * cfold.cs: Update to changes.
481 2008-04-15 Marek Safar <marek.safar@gmail.com>
483 * cs-paser.jay: Removed unused variable.
485 * driver.cs: Made Compile instance method.
487 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
489 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
491 2008-04-15 Marek Safar <marek.safar@gmail.com>
493 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
495 2008-04-13 Jb Evain <jbevain@novell.com>
497 * namespace.cs: update the System.Core fullname for 2.1
498 * driver.cs: update the list of required assemblies for 2.1.
499 Merged from the Moonlight 2 branch.
501 2008-04-11 Marek Safar <marek.safar@gmail.com>
503 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
504 types and user defined operators. User operators arguments has to be checked
505 for null value before invocation, which also means no operator is called
506 when any argument is not convertible to unwrapped nullable type.
508 2008-04-09 Marek Safar <marek.safar@gmail.com>
510 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
511 of Unary expressions to follow operator overloading rules precisely.
512 Also fixes #321794, #323794
514 2008-04-08 Marek Safar <marek.safar@gmail.com>
516 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
519 2008-04-08 Marek Safar <marek.safar@gmail.com>
521 * expression.cs, ecore.cs: Implemented MemberInit expression.
523 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
525 Fix mono/tests/exception4.cs
526 * statement.cs (ExceptionStatement, TryCatch): Revert to using
527 ec.NeedReturnLabel () rather emitting a 'nop'.
529 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
531 (TryCatch.SomeCodeFollows): Likewise.
532 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
533 for 'break', 'continue' and 'return' statements inside a try.
534 We're fairly sure that the generated IL stream will have more
535 instructions textually following the try.
536 (FlowBranchingTryCatch): Likewise.
538 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
539 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
542 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
543 wrapper -- forward everything to CollectionForeach.
544 (CollectionForeach.NonDisposableWrapper): New.
545 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
546 instead of a pop + branch to end.
548 2008-04-07 Marek Safar <marek.safar@gmail.com>
550 A fix for bug #377485
551 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
552 Propagate location for extension method groups. Report conversion failure at
555 2008-04-07 Marek Safar <marek.safar@gmail.com>
557 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
558 ListInit and Field expressions.
560 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
562 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
563 Since $PC is always -1 inside the body of MoveNext, the fault
565 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
566 * statement.cs (ExceptionStatement.emit_finally): Likewise.
567 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
569 The denouement! Fix #324708
570 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
571 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
572 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
573 'finally' inside the finally clause.
575 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
576 inside an iterator. Don't emit the body of the 'finally' inside
577 the finally clause yet.
579 Use the ResumableStatement infrastructure for MoveNext ()
580 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
581 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
582 'old_resume_points'. Move dispatcher upfront.
583 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
584 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
585 in an enumerator. This encodes the main fix in this patch series
586 -- we can only jump into the first instruction of a try from the
587 outside, but we want to emit try/finally regions in iterators and
588 resume in the middle of them.
590 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
592 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
593 of NeedReturnLabel here.
595 Introduce a common point for emitting try/finally to IL
596 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
597 features of the various subclasses, which are now driven by ...
598 (ExceptionStatement.EmitPreTryBody): ... this and ...
599 (ExceptionStatement.EmitTryBody): ... this and the original
601 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
602 Remove DoEmit and update to follow above protocol.
604 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
605 of the dispatcher are the same, skip emitting the 'switch'.
606 * iterator.cs (Iterator.EmitDispose): Update to changes.
608 Clean up handling of 'using' statement
609 * statement.cs (UsingTemporary): New. Carved out of ...
610 (Using): ... this. Simplify drastically. Handle exactly
612 * cs-parser.jay (using_statement): Split. Create UsingTemporary
613 or Using as appropriate. If there are multiple variable declared,
614 create nested Using statements.
615 (resource_acquisition): Kill.
617 * statement.cs (ExceptionStatement.EmitForDispose): Use
618 EmitFinallyBody, not EmitFinally.
620 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
621 * iterator.cs: Update to changes.
623 Start using the ResumableStatement infrastructure
624 * statement.cs (ResumeableStatement.PrepareForDispose): New.
625 (ResumableStatement.EmitForDispose): New.
626 (ExceptionStatement): Override them.
627 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
628 EmitForDispose to create the body of the Dispose method. Don't
631 * iterator.cs (Iterator.AddResumePoint): Move here from ...
632 * statement.cs (Toplevel.AddResumePoint): ... here.
633 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
634 * flowanalysis.cs (FlowBranchingIterator): New.
635 * codegen.cs (EmitContext): Update to changes.
637 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
638 (Iterator.old_resume_points): Rename from 'resume_points'.
639 (Iterator.MoveNextStatement): Remove unused class.
641 New infrastructure for try/finally in iterators (still unused)
642 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
643 (FlowBranchingToplevel.AddResumePoint): Hook into
644 ToplevelBlock.AddResumePoint.
645 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
646 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
647 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
648 resume points and assign program-counter values.
649 (ExceptionBlock.AddResumePoint): Collect resume points for
650 de-muxer at the top of try block.
651 * iterators.cs (Yield.CheckContext): Simplify.
652 (Yield.Resolve): Use FlowBranching.AddResumePoint.
654 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
656 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
657 argument to an ExitStatement.
658 (FlowBranchingException): Refactor saved origins code.
659 * statement.cs (ExitStatement): Update to cahges.
660 * iterator.cs (YieldBreak): Likewise.
662 * statement.cs (ResumableStatement): New. Common base class for
663 YieldReturn and ExceptionStatement.
664 (ExitStatement): New. Common base class for Return and YieldBreak.
665 (Return): Update to changes.
666 * iterator.cs (YieldBreak): Likewise.
667 * lambda.cs (ContextualReturn): Likewise.
670 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
671 emit a meaningful error message.
674 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
675 (VariableInfo.SetAssigned): Set it.
676 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
677 determine if CS0219 or CS0168 is appropriate. Don't use
678 flow-analysis information.
679 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
680 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
681 (EmitContext.EndFlowBranching): ... this.
683 2008-04-03 Marek Safar <marek.safar@gmail.com>
685 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
687 2008-04-03 Marek Safar <marek.safar@gmail.com>
689 A fix for bug #376508
690 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
691 ImplicitConversionExists.
693 2008-04-03 Marek Safar <marek.safar@gmail.com>
695 * expression.cs (Binary): Added remaining binary operators to expression
698 * nullable.cs: Optimize shift with null argument.
700 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
702 Fix minor IL regression
703 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
704 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
705 * cs-parser.jay (try_statement): Update to changes.
707 * statement.cs (TryFinally.need_exc_block): Delete.
708 (TryFinally): Update to changes.
710 Now all ExceptionStatements are unconditional
711 * statement.cs (CollectionForeach.DisposableWrapper): New.
712 Extract out the try/finally code into a new wrapper.
713 (CollectionForeach.Resolve): Use it to simplify the code.
715 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
717 Start at simplifying ExceptionStatement semantics a bit
718 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
719 * cs-parser.jay (try_statement): Update to changes.
720 (opt_catch_clauses): Remove.
721 * flowanalysis.cs: Update to changes.
722 (FlowBranching.BranchingType.TryCatch): New.
723 (FlowBranchingTryCatch): New.
725 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
726 (FlowBranching.CreateBranching): Update to changes.
727 (FlowBranchingBlock.AddSibling): Add sanity check.
728 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
731 * iterators.cs (Iterator.MarkFinally): Remove.
732 * statement.cs (ExceptionStatement): Update to changes.
734 Add support for skipping over finally blocks at runtime. First
735 in a series to fix #324708
736 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
737 (Iterator.EmitMoveNext): Initialize it.
738 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
739 branch over the body of the 'finally' clause.
741 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
743 Avoid lopsided use of Foo/DoFoo names
744 * statement.cs (ExpressionStatement.EmitFinallyBody):
745 Rename from EmitFinally.
746 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
747 * iterator.cs: Update to changes.
749 2008-04-02 Marek Safar <marek.safar@gmail.com>
751 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
752 based on UserOperatorCall. More binary nullable operators clean up.
754 2008-04-02 Martin Baulig <martin@ximian.com>
756 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
758 2008-04-02 Marek Safar <marek.safar@gmail.com>
760 * nullable.cs: Merge user and empty conversions when lifting expression
763 * expression.cs (StringConcat): Implemented expression tree representation.
765 2008-04-01 Marek Safar <marek.safar@gmail.com>
767 * nullable.cs: When lifting null literal and a user operator exists, no call
770 2008-04-01 Marek Safar <marek.safar@gmail.com>
772 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
775 2008-04-01 Marek Safar <marek.safar@gmail.com>
777 * nullable.cs, expression.cs: Use namespace instead heavily nested
778 monster abstract class.
780 2008-04-01 Marek Safar <marek.safar@gmail.com>
782 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
783 lifting of null literal and user operators. Clean up of some temporary
786 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
788 Fix #368224, test-629.cs
789 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
790 if it crossed an unwind-protect boundary.
791 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
792 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
793 inside an unwind-protected region.
794 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
795 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
796 'leave' instead of a 'br' if unwind-protected.
797 (Iterator.EmitYieldBreak): Likewise.
799 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
801 * driver.cs: Only define versioninfo resources if no win32 resource
804 2008-03-28 Marek Safar <marek.safar@gmail.com>
806 A fix for bug #372375
807 * convert.cs: Fixed boxing of nullable types.
809 2008-03-28 Marek Safar <marek.safar@gmail.com>
811 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
814 2008-03-28 Marek Safar <marek.safar@gmail.com>
816 A fix for bug #374619
817 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
819 2008-03-27 Marek Safar <marek.safar@gmail.com>
821 * lambda.cs: Check return type only for invocation.
823 2008-03-27 Marek Safar <marek.safar@gmail.com>
825 A fix for bug #374214
826 * ecore.cs: Correctly report argument type mismatch.
828 2008-03-27 Marek Safar <marek.safar@gmail.com>
830 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
831 and not rely on broken IsEnum.
833 2008-03-27 Marek Safar <marek.safar@gmail.com>
835 * nullable.cs: New file, extracted from generic.cs.
837 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
839 2008-03-27 Marek Safar <marek.safar@gmail.com>
841 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
842 predefined comparison operators and null literals.
844 * report.cs: New warning ID.
846 2008-03-25 Marek Safar <marek.safar@gmail.com>
848 A fix for bug #370577
849 * lambda.cs: Check return type too.
851 2008-03-25 Marek Safar <marek.safar@gmail.com>
853 A fix for bug #372846
854 * class.cs: Automatic properties can be declared as unsafe.
856 2008-03-20 Marek Safar <marek.safar@gmail.com>
858 * location.cs: Use string based concatenation.
860 * expression.cs: LiftedBinaryOperator is gmcs only.
862 2008-03-20 Marek Safar <marek.safar@gmail.com>
864 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
865 conversions rules and expression trees.
867 2008-03-19 Marek Safar <marek.safar@gmail.com>
869 * delegate.cs: Use extension method source as delegate target.
871 2008-03-19 Marek Safar <marek.safar@gmail.com>
873 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
874 binary operations to be purely based on binary operations and optimized
875 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
876 and other ET refactoring.
878 * typemanager.cs: Fixed warning.
880 2008-03-17 Marek Safar <marek.safar@gmail.com>
882 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
884 * symbolwriter.cs: Fixed.
886 2008-03-17 Marek Safar <marek.safar@gmail.com>
888 * anonymous.cs, driver.cs: Reset anonymous types counters.
890 2008-03-17 Marek Safar <marek.safar@gmail.com>
892 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
894 * class.cs: Use fullname for all type member definitions.
896 2008-02-19 Martin Baulig <martin@ximian.com>
899 (IMethodData.EmitExtraSymbolInfo): New interface method.
900 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
901 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
902 interface method here as an empty public virtual method.
905 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
906 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
907 CodeGen.SymbolWriter.SetRealMethodName().
909 2008-02-18 Martin Baulig <martin@ximian.com>
912 (ScopeInfo.EmitType): Override this and emit debugging
913 information for captured variables.
914 (RootScopeInfo.EmitType): Override this and emit symbol
915 information for a captured `this'.
917 2008-02-15 Martin Baulig <martin@ximian.com>
919 * iterators.cs: Emit debugging info.
922 (EmitContext.Flags): Add `OmitDebuggingInfo'.
923 (EmitContext.OmitDebuggingInfo): New public property.
926 (While): Override Emit() and don't emit symbol info there; do it
927 inside DoEmit() instead.
928 (Block.Emit): Omit symbol information while emitting the scope
929 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
931 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
932 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
933 .ctor to make `IsIterator' work.
935 2008-03-14 Martin Baulig <martin@ximian.com>
937 * symbolwriter.cs: Added the new symbol writer function from the
938 debugger's `terrania' branch; temporarily enclose them inside
939 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
942 2008-03-14 Martin Baulig <martin@ximian.com>
945 (SymbolWriter): Make this a public static class.
948 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
949 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
951 2008-03-14 Marek Safar <marek.safar@gmail.com>
953 A fix for bug #370577
954 * statement.cs, lambda.cs: Added extra limitations when dealing with void
957 2008-03-14 Marek Safar <marek.safar@gmail.com>
959 * typemanager.cs (CSharpName): Made 250 times faster.
961 2008-03-13 Marek Safar <marek.safar@gmail.com>
963 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
965 2008-03-12 Marek Safar <marek.safar@gmail.com>
967 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
968 crash when predefined field does not exist.
970 2008-03-12 Marek Safar <marek.safar@gmail.com>
972 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
974 2008-03-12 Marek Safar <marek.safar@gmail.com>
976 * class.cs (FixedField): Don't crash when contructors are missing.
978 2008-03-11 Marek Safar <marek.safar@gmail.com>
980 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
981 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
982 check internal types accessibility for internal and external types.
983 Replaced EnumToUnderlying by GetEnumUnderlyingType.
985 2008-03-11 Marek Safar <marek.safar@gmail.com>
987 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
988 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
989 attribute.cs, statement: Use corect instance of predefined types (work
992 2008-03-07 Marek Safar <marek.safar@gmail.com>
994 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
996 2008-03-07 Marek Safar <marek.safar@gmail.com>
998 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
999 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
1000 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
1001 predefined types clean up, delayed predefined types members initialization
1002 (work related to #364674).
1004 2008-03-05 Marek Safar <marek.safar@gmail.com>
1006 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
1008 2008-03-05 Marek Safar <marek.safar@gmail.com>
1010 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
1011 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
1012 predefined types clean up (work related to #364674).
1014 2008-03-04 Marek Safar <marek.safar@gmail.com>
1016 * ecore.cs: Print an error message instead of throwing exception.
1018 2008-03-04 Marek Safar <marek.safar@gmail.com>
1020 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
1021 expression.cs, statement.cs: Unififed null literal representation.
1023 2008-03-03 Marek Safar <marek.safar@gmail.com>
1025 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
1026 expression.cs: Refactored binary operators resolve phase and improved speed.
1027 The nullable code is still missing and won't work correctly, more fixes
1030 It also fixes #323726, #324312, #324248, and many other unreported issues.
1032 2008-02-29 Zoltan Varga <vargaz@gmail.com>
1034 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
1037 2008-02-27 Marek Safar <marek.safar@gmail.com>
1039 * ecore.cs: Clean-up and split BetterConversion.
1041 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
1044 * enum.cs (EnumMember.Value): Only access 'value' if
1045 ResolveValue says it's ok.
1046 (EnumMember.DoResolveValue): Don't set prev_member.value.
1047 (Enum.GetDefinition): Reverse arguments of Equals --
1048 EnumMember.Value can return 'null'.
1050 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
1052 2008-02-22 Marek Safar <marek.safar@gmail.com>
1054 * generic.cs, expression.cs: More ongoing work on expression trees.
1056 2008-02-21 Marek Safar <marek.safar@gmail.com>
1058 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
1059 handle missing matches when mutiple operators exist.
1061 2008-02-20 Marek Safar <marek.safar@gmail.com>
1063 A fix for bug #363218
1064 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
1067 2008-02-20 Marek Safar <marek.safar@gmail.com>
1069 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
1070 update. This time to deal correctly with SideEffectConstant expression used
1071 as an argument for another constant folding.
1073 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
1075 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
1078 2008-02-19 Marek Safar <marek.safar@gmail.com>
1080 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
1082 2008-02-19 Marek Safar <marek.safar@gmail.com>
1084 A fix for bug #328136
1085 * expression.cs: Do not fold immediately LogicalAnd operators when the left
1086 side is a false constant, because we still need to evaluate the right-hand
1089 * statement.cs (If): Emit two types of boolean constants (simple constant,
1090 side-effect constant).
1092 2008-02-19 Marek Safar <marek.safar@gmail.com>
1094 * constant.cs (SideEffectConstant): Don't emit boolean constant.
1096 * expression.cs: Fold immediately LogicalAnd operators when both sides are
1099 2008-02-18 Marek Safar <marek.safar@gmail.com>
1101 A fix for bug #361457
1102 * ecore.cs (IsApplicable): Params methods have lower priority.
1104 * support.cs: Return correct parameter modifier for params types.
1106 2008-02-18 Marek Safar <marek.safar@gmail.com>
1108 * generic.cs (TypeParameter): Cache attribute target name.
1110 * support.cs: Removed unused variable.
1112 * typemanager.cs: Removed debugging leftover.
1114 * ecore.cs: Use local type instead of a property;
1116 * class.cs (VerifyMembers): Consider also parent to test whether type member
1119 * expression.cs (FullMethodDesc): Removed.
1121 * attribute.cs (IsValidArgumentType): Made static.
1123 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
1125 Cleanup to be more readable.
1126 * Makefile (GMCS_PROFILE): Remove.
1127 (COMPILER_NAME): New helper.
1129 2008-02-15 Miguel de Icaza <miguel@novell.com>
1131 * cs-tokenizer.cs: if a conditional expression happens inside a
1132 (...) this also means that we do not need to de-ambiguate between
1133 an parenthesized expression and a cast.
1137 * constant.cs (SideEffectConstant): a constant value that happens
1138 to have a side effect.
1140 Fixes the build regressions introduced by the fix for #359789
1142 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
1144 * expression.cs (Conditional.Emit): when emitting the ternary
1145 operator, use local variables to generate code verifiable code.
1147 The verifier cannot infer that the type on stack before the
1148 stloc.0 is executed is of type ParentB. This happens because the
1149 stack merge algorithm uses only parent types when deciding which
1150 is the common type. This is described in Part III 1.8.1.3 of ECMA
1153 This code compiled with mcs is not verifiable under MS. The MS
1154 verifier picks the first common interface of Foo and Bar, which is
1155 wrong, but doesn't use a full join type of the 2 interfaces.
1157 CSC uses a clever hack to compile such code in a verifiable
1158 way. It stores the intermediate values in a local variable with
1163 2008-02-14 Miguel de Icaza <miguel@novell.com>
1165 * expression.cs: Do not fold BitwiseAnd operators when the left
1166 side is a false constant, because we still need to evaluate the
1171 * support.cs: Instead of throwing an InternalErrorException when
1172 the position of the stream is outside the boundary of our buffer,
1173 reset the state of the reader, and restart the reading from the
1174 beginning of the file.
1176 2008-02-14 Marek Safar <marek.safar@gmail.com>
1178 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
1180 2008-02-14 Marek Safar <marek.safar@gmail.com>
1182 A fix for bug #361686
1183 * decl.cs: A protected types used inside a private class which parents
1184 derives from the protected class are accessible.
1186 2008-02-13 Marek Safar <marek.safar@gmail.com>
1188 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
1189 the parameterless constructor.
1191 2008-02-13 Marek Safar <marek.safar@gmail.com>
1193 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
1194 lookup methods to use standard member cache when doing member lookup.
1196 2008-02-12 Marek Safar <marek.safar@gmail.com>
1198 * driver.cs: Don't report full path for referenced module as assembly error.
1200 2008-02-12 Marek Safar <marek.safar@gmail.com>
1202 * Makefile: Fixed `qh' target to work on all machines.
1204 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
1205 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
1206 and HasElementType with TypeManager implementation.
1208 2008-02-08 Marek Safar <marek.safar@gmail.com>
1210 A fix for bugs #325134, #359749
1211 * expression.cs, ecore.cs: Try to resolve an extension method even if the
1212 first binds point to non-method member expression.
1214 2008-02-08 Marek Safar <marek.safar@gmail.com>
1216 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
1218 2008-02-08 Marek Safar <marek.safar@gmail.com>
1220 A fix for bugs #321394, #323028
1221 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
1222 Reworked naive IsAccessibleAs implementation to handle nested types.
1224 2008-02-05 Jb Evain <jbevain@novell.com>
1226 * class.cs: use generic type comparison for parameters
1229 2008-02-05 Marek Safar <marek.safar@gmail.com>
1231 A fix for bug #325372
1232 * class.cs: Use generic type comparison when testing method signatures.
1234 2008-02-05 Marek Safar <marek.safar@gmail.com>
1236 A fix for bug #357047
1237 * ecore.cs: Applied C# 3.0 changes to better conversion.
1239 2008-02-05 Marek Safar <marek.safar@gmail.com>
1241 A fix for bug #358374
1242 * cs-parser.jay: Correctly set modifiers for all constructor types.
1244 2008-02-04 Marek Safar <marek.safar@gmail.com>
1246 A fix for bug #355251
1247 * generic.cs: Added base class constraint based type inference.
1249 2008-02-01 Marek Safar <marek.safar@gmail.com>
1251 A fix for bug #357255
1252 * decl.cs: One more missing visibility check.
1254 2008-02-01 Marek Safar <marek.safar@gmail.com>
1256 * support.cs: Fixed broken return.
1258 2008-01-25 Marek Safar <marek.safar@gmail.com>
1260 * report.cs: Correctly reset warnings count after probing.
1262 2008-01-25 Martin Baulig <martin@ximian.com>
1265 (NamespaceEntry.SymbolFileID): Make this work again after
1266 MemberName.ToString() is gone.
1268 2008-01-25 Marek Safar <marek.safar@gmail.com>
1270 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
1273 2008-01-25 Marek Safar <marek.safar@gmail.com>
1275 * generic.cs: Use full implicit conversion for type inference fixing.
1277 2008-01-24 Marek Safar <marek.safar@gmail.com>
1279 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
1280 Fixed user operator conversions.
1282 2008-01-24 Marek Safar <marek.safar@gmail.com>
1284 * generic.cs: Do nullable type to null comparison optimization during
1287 2008-01-24 Marek Safar <marek.safar@gmail.com>
1289 A fix for bug #355163
1290 * generic.cs: Enabled l-value resolve on nullable expressions.
1292 2008-01-24 Marek Safar <marek.safar@gmail.com>
1294 A fix for bug #353986
1295 * class.cs: Ingore static ctors with parameters for any further checks.
1297 2008-01-24 Marek Safar <marek.safar@gmail.com>
1299 A fix for bug #354310
1300 * namespace.cs: Removed redundant check.
1302 2008-01-24 Marek Safar <marek.safar@gmail.com>
1304 A fix for bug #354928
1305 * expression.cs: ElementInitializers can be resolved only once.
1307 2008-01-24 Marek Safar <marek.safar@gmail.com>
1309 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
1310 Condition expressions.
1312 2008-01-23 Marek Safar <marek.safar@gmail.com>
1314 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
1316 2008-01-22 Marek Safar <marek.safar@gmail.com>
1318 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
1321 * generic.cs: Implemented coalesce expression.
1323 2008-01-22 Marek Safar <marek.safar@gmail.com>
1325 A fix for bug #355145
1326 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
1327 expression tree type inference.
1329 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
1332 * expression.cs (Binary.IsUnsignedType): Fix typo.
1334 2008-01-22 Marek Safar <marek.safar@gmail.com>
1336 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
1338 2008-01-22 Marek Safar <marek.safar@gmail.com>
1340 A fix for bug #355161
1341 * ecore.cs, expression.cs: Wider range of extension method supported
1344 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
1346 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
1347 AssemblyBuilder to operate in compiler context. Fixes mcs part of
1350 2008-01-22 Marek Safar <marek.safar@gmail.com>
1352 A fix for bug #355148
1353 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
1355 2008-01-22 Miguel de Icaza <miguel@novell.com>
1357 * expression.cs (CreateExpressionTree): Add support for or and
1358 logical or, and indent following the coding conventions.
1360 * typemanager.cs (LinqExpression): renamed from
1361 ExpressionTreeManager, for a shorter name.
1363 Use TypeManager.CoreLookupType to lookup types from our core
1364 assemblies and turn those into "Type" variables.
1366 Consumers that previously used "Namespace" and "Type" from this
1367 class should instead use the TypeExpression which is a type that
1368 is fully resolved (without involving the regular C# resolution
1371 This typically looks like this:
1373 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
1374 new MemberAccess (texpr, name, type_arguments, loc)
1376 This avoids the problem in: #355178
1378 2008-01-21 Marek Safar <marek.safar@gmail.com>
1380 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
1381 feature in parser only as we do in other cases.
1383 2008-01-21 Marek Safar <marek.safar@gmail.com>
1385 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
1386 typemanager.cs: A refactoring of params arguments to reuse existing
1387 expressions (params -> array initializer) to emit params argument instead
1388 of specialized handling.
1389 It was required by expression tree implementation and it has other benefits
1390 as well, we now apply same optimization for params arguments as we do for
1393 2008-01-18 Marek Safar <marek.safar@gmail.com>
1395 A fix for bug #353526
1396 * generic.cs: A type inference of params arguments may not required any
1397 temporary array creation.
1399 2008-01-18 Marek Safar <marek.safar@gmail.com>
1401 A fix for bug #353534
1402 * generic.cs, ecore.cs, expression.cs: A method group type inference is
1403 supported for delegates only.
1405 2008-01-18 Marek Safar <marek.safar@gmail.com>
1407 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
1408 type for more than 1 candidates.
1410 2008-01-18 Marek Safar <marek.safar@gmail.com>
1412 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
1415 2008-01-16 Marek Safar <marek.safar@gmail.com>
1417 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
1418 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
1419 operator) expressions.
1421 2008-01-16 Zoltan Varga <vargaz@gmail.com>
1423 * statement.cs: Avoid declaring an IL variable for this_variable since it is
1424 not accessed from the generated IL.
1426 2008-01-14 Marek Safar <marek.safar@gmail.com>
1428 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
1429 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
1430 statement.cs: The first expression tree implementation drop, mostly
1431 infrastructure work.
1433 2008-01-14 Marek Safar <marek.safar@gmail.com>
1435 * ecore.cs (IsNestedChild): Refactored.
1437 2008-01-11 Marek Safar <marek.safar@gmail.com>
1439 * lambda.cs: Don't use a cast on unknown expression statement.
1441 2008-01-10 Geoff Norton <gnorton@novell.com>
1443 * cs-tokenizer.cs: One more token to distinguish between method and lambda
1446 2008-01-09 Marek Safar <marek.safar@gmail.com>
1448 * doc.cs: Report better /doc crash details.
1450 2008-01-09 Marek Safar <marek.safar@gmail.com>
1452 A fix for bug #352536
1453 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
1455 2008-01-08 Marek Safar <marek.safar@gmail.com>
1457 A fix for bug #352287
1458 * ecore.cs, expression.cs: Do `this' access checking in all member access
1461 2008-01-08 Marek Safar <marek.safar@gmail.com>
1463 * rootcontext.cs, driver.cs: Switch to linq mode by default.
1465 * report.cs: Reset message stacks.
1467 2008-01-08 Marek Safar <marek.safar@gmail.com>
1469 * generic.cs (InferInPhases): Correctly calculate params position.
1471 2008-01-08 Marek Safar <marek.safar@gmail.com>
1473 * cs-tokenizer.cs: No need to parse full string when parsing lambda
1476 2008-01-07 Marek Safar <marek.safar@gmail.com>
1478 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
1480 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
1482 * driver.cs: Updated --help option.
1484 2008-01-07 Marek Safar <marek.safar@gmail.com>
1486 * generic.cs (InferParamsTypeArguments): Removed.
1487 (InferInPhases): Add params type inference.
1488 (LowerBoundInference): Fixed scoring mechanism.
1490 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
1492 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
1494 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
1495 byte array for unsigned "baked" assemblies.
1497 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
1499 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
1500 array for assemblies that are not strongnamed.
1502 2008-01-04 Marek Safar <marek.safar@gmail.com>
1504 A fix for bug #351481
1505 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
1506 declaring type for nested generic types.
1508 2008-01-04 Marek Safar <marek.safar@gmail.com>
1510 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
1511 instead of ToString.
1513 2008-01-03 Marek Safar <marek.safar@gmail.com>
1515 A fix for bug #351047
1516 * expression.cs (Binary.ResolveOperator): Allow equality operators between
1517 null and structs only when equality and inequality operators are defined
1518 either as an user-operators or predefined operators.
1520 2008-01-03 Marek Safar <marek.safar@gmail.com>
1522 A fix for bug #351047
1523 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
1525 2008-01-03 Marek Safar <marek.safar@gmail.com>
1527 A fix for bug #351257
1528 * cs-tokenizer.cs: Advance line number for '\r' correctly.
1530 2008-01-03 Marek Safar <marek.safar@gmail.com>
1532 A fix for bug #351157
1533 * class.cs (Using): Fixed yet another broken cloning.
1535 (Block): Put back more sensible default value for statements.
1537 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
1539 * codegen.cs: Allow AssemblyVersion with only major version component.
1542 2007-12-29 Marek Safar <marek.safar@gmail.com>
1544 A fix for bug #324654
1545 * class.cs: Use FullName property as member name.
1547 2007-12-28 Marek Safar <marek.safar@gmail.com>
1549 A fix for bug #342117
1550 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
1551 constructor constraint.
1553 2007-12-28 Marek Safar <marek.safar@gmail.com>
1555 A fix for bug #338273
1556 * class.cs (ProbertyBase): Access modifier checks are required for overrides
1559 2007-12-28 Marek Safar <marek.safar@gmail.com>
1561 A fix for bug #350839
1562 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
1564 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1566 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1569 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1571 * statement.cs: Changed some Hashtables to use HybridDictionaries
1572 instead. It was observed that some HashTables only contained a few
1573 items in the vast majority of cases. Since HybridDictionary is
1574 more efficient on small sets (<10 elements), "known_variables"
1575 from class ExplicitBlock as well as "labels" and "constants " from
1576 class Block were changed to HybridDictionaries.
1578 Atsai results: (56216kb->54987kb)
1580 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
1583 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1585 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1588 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1590 * expression.cs: foreach loop to for loop, saved on allocation of
1591 enumerator (59333kb->59141kb)
1593 * statement.cs. Changed foreach loops to for loops, saved on
1594 allocation of enumerator (59141kb->59006kb)
1596 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
1597 when constructed with no specified capacity. This was causing a
1598 few ArrayLists to allocate more memory than they would potentially
1599 need in the Block class and MemberCache class. Setting the
1600 ArrayLists to construct with a capacity of 1 saves some
1601 memory. (56216kb->55585kb)
1603 2007-12-27 Marek Safar <marek.safar@gmail.com>
1605 A fix for bug #347189 (2nd issue)
1606 * expression.cs (MemberAccess): Nested type can be found in base non-generic
1609 2007-12-27 Miguel de Icaza <miguel@novell.com>
1611 * report.cs: Do not use colors if stdout and stderr are not a
1614 2007-12-27 Marek Safar <marek.safar@gmail.com>
1616 A fix for bug #346998
1617 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
1620 2007-12-27 Marek Safar <marek.safar@gmail.com>
1622 A fix for bug #343465
1623 * class.cs: Explicit method name for nested types uses dots only.
1625 2007-12-27 Marek Safar <marek.safar@gmail.com>
1627 A fix for bug #343707
1628 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
1630 2007-12-27 Marek Safar <marek.safar@gmail.com>
1632 * ecore.cs: Report type inference errors only when arguments count matches
1635 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
1637 * expression.cs, report.cs: New warning.
1639 * typemanager.cs: Catch anonymous method type too.
1641 2007-12-23 Marek Safar <marek.safar@gmail.com>
1643 A fix for bug #346379
1644 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
1646 2007-12-23 Marek Safar <marek.safar@gmail.com>
1648 A fix for bug #347359
1649 * expression.cs (Invocation): Don't resolve already resolved expression.
1651 2007-12-23 Marek Safar <marek.safar@gmail.com>
1653 A fix for bug #347189
1654 * class.cs (FixedField): Use non-dependent code only in the define phase.
1656 2007-12-23 Marek Safar <marek.safar@gmail.com>
1658 A fix for bug #348076
1659 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
1661 2007-12-22 Marek Safar <marek.safar@gmail.com>
1663 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
1664 discovered extension methods.
1666 2007-12-22 Marek Safar <marek.safar@gmail.com>
1668 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
1671 2007-12-21 Miguel de Icaza <miguel@novell.com>
1673 * report.cs (ErrorMessage): Add support for using colors on
1674 terminals that support it.
1676 2007-12-21 Marek Safar <marek.safar@gmail.com>
1678 * ecore.cs: Use information about expanded params for error reporting.
1680 2007-12-21 Marek Safar <marek.safar@gmail.com>
1682 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
1683 and logic for params overloads.
1685 2007-12-15 Miguel de Icaza <miguel@novell.com>
1687 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
1688 as this is also created from the parser. Fixes #349034
1690 2007-12-12 Miguel de Icaza <miguel@novell.com>
1692 * statement.cs (Throw.CloneTo): it is valid to have empty
1693 expressions for throw.
1695 2007-12-03 Marek Safar <marek.safar@gmail.com>
1697 * cs-parser.jay: Set delegate constraint parsing region correctly.
1699 2007-12-03 Marek Safar <marek.safar@gmail.com>
1701 A fix for bug #345467
1702 * typemanager.cs (IsEqual): Compare generic parameters position only.
1704 2007-11-28 Marek Safar <marek.safar@gmail.com>
1706 * expression.cs (BaseAccess): Type arguments can be null.
1708 2007-11-27 Raja R Harinath <harinath@gmail.com>
1710 * statement.cs (Block.Resolve): Ensure flow-branching tree is
1711 consistent even when an error has occured.
1712 (Switch.Resolve): Likewise.
1714 2007-11-22 Marek Safar <marek.safar@gmail.com>
1716 A fix for bug #334505
1717 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
1720 2007-11-22 Marek Safar <marek.safar@gmail.com>
1722 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
1723 refactorings required to resolve extension methods correctly when mixing
1724 generics and non-generics members.
1726 2007-11-20 Marek Safar <marek.safar@gmail.com>
1728 A fix for bug #342584
1729 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
1732 2007-11-19 Marek Safar <marek.safar@gmail.com>
1734 A fix for bug #342512
1735 * delegate.cs: Use delegate argument expression when is available. Don't
1736 emit virtual call when class is sealed.
1738 2007-11-16 Marek Safar <marek.safar@gmail.com>
1740 A fix for bug #325423
1741 * assign.cs (FieldInitializer): Use resolved expression for emit.
1743 * class.cs: Print less confusing error message.
1745 2007-11-16 Marek Safar <marek.safar@gmail.com>
1747 * cs-tokenizer.cs: Removed GMCS ifdefs.
1749 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
1752 * cs-parser.jay: Disabled nullable check.
1754 * generic-mcs: Copied more generic stuff.
1756 2007-11-16 Marek Safar <marek.safar@gmail.com>
1758 * gcs-parser.jay: Merged to cs-parser.jay.
1760 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
1761 * *.csproj, *.sources: Updated to use only jay parser file.
1763 2007-11-16 Marek Safar <marek.safar@gmail.com>
1765 * gcs-parser.jay: Added nullable and default expression feature checks.
1767 2007-11-16 Marek Safar <marek.safar@gmail.com>
1769 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
1770 it fixes many TODOs and hidden bugs.
1772 * expression: Removed duplicate error check.
1774 2007-11-15 Marek Safar <marek.safar@gmail.com>
1776 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
1777 implicitly type local variable only when it is used in a declaration.
1779 2007-11-15 Marek Safar <marek.safar@gmail.com>
1781 * attribute.cs: Use CS0612 for empty strings.
1783 2007-11-14 Marek Safar <marek.safar@gmail.com>
1785 * lambda.cs, statement.cs: Contextual return may act as a statement.
1787 2007-11-14 Marek Safar <marek.safar@gmail.com>
1789 A fix for a regression cause by #324222
1790 * class.cs: Don't report unused even when it implements an interface.
1792 2007-11-13 Marek Safar <marek.safar@gmail.com>
1794 A fix for bug #341205
1795 * ecore.cs, expression.cs: Method group expression cannot do static
1796 method access with an instance reference check before overloading takes
1799 2007-11-13 Marek Safar <marek.safar@gmail.com>
1801 A fix for bug #325359
1802 * class.cs: Use predictable name for automatically generated property.
1804 2007-11-12 Marek Safar <marek.safar@gmail.com>
1806 A fix for bug #324996
1807 * expression.cs (Is): Handle case where D is nullable and T is not
1810 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
1812 2007-11-12 Marek Safar <marek.safar@gmail.com>
1814 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
1815 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
1816 Flush small error reporting changes.
1818 2007-11-09 Marek Safar <marek.safar@gmail.com>
1820 A fix for bug #324996
1821 * expression.cs: Rewrote Is expression implementation to work with
1822 generics, nullable types, anonymous method. A const result expression
1823 uses existing infrastructure instead of custom not fully-featured one.
1825 2007-11-08 Marek Safar <marek.safar@gmail.com>
1827 A fix for bug #340202
1828 * class.cs: Consider generics for volatile field.
1830 2007-11-08 Marek Safar <marek.safar@gmail.com>
1832 A fix for bug #335594
1833 * expression.cs: Use conversion rules when handling string addition.
1835 2007-11-07 Marek Safar <marek.safar@gmail.com>
1837 A fix for bug #336651
1838 * expression.cs: Fixed a crash when probing is on.
1840 2007-11-07 Marek Safar <marek.safar@gmail.com>
1842 A fix for bug #324242
1843 * covert.cs: Added a conversion from any nullable-type with an
1844 underlying enum-type to the type System.Enum.
1846 2007-11-07 Marek Safar <marek.safar@gmail.com>
1848 A fix for bug #324222
1849 * class.cs: Report all non-used event fields.
1851 2007-11-07 Marek Safar <marek.safar@gmail.com>
1853 A fix for bug #325161
1854 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1855 qualifier for generic types.
1857 2007-11-07 Marek Safar <marek.safar@gmail.com>
1859 A fix for bug #322971
1860 * expression.cs, ecore.cs: Added intermediate result value check for
1863 2007-11-07 Marek Safar <marek.safar@gmail.com>
1865 A fix for bug #324754
1866 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1867 when it was requested.
1869 2007-11-07 Marek Safar <marek.safar@gmail.com>
1871 A fix for bug #325101
1872 * expression.cs: Do type not value comparison for `is' expression.
1874 2007-11-07 Marek Safar <marek.safar@gmail.com>
1876 A fix for bug #320236
1877 * convert.cs: Don't apply user conversion on underlying target type.
1879 2007-11-06 Marek Safar <marek.safar@gmail.com>
1881 * expression.cs: Don't use unresolved expression for error reporting.
1883 2007-11-06 Marek Safar <marek.safar@gmail.com>
1885 A fix for bugs #337712, #324490
1886 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1887 overloading resolution too.
1889 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1890 the process consistent and more robust.
1892 * expression.cs, linq.cs, report.cs: Update.
1894 2007-11-02 Marek Safar <marek.safar@gmail.com>
1896 A fix for bug #332909
1897 * attribute.cs: Resolve attributes in correct context using error
1900 * rootcontext.cs: Define Obsolete attribute members as core members.
1902 2007-11-02 Marek Safar <marek.safar@gmail.com>
1904 * statement.cs: Removed unused methods.
1906 2007-10-31 Wade Berrier <wberrier@novell.com>
1908 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1909 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1912 2007-10-31 Marek Safar <marek.safar@gmail.com>
1914 A fix for bug #338102
1915 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1916 methods registered as non-generics.
1918 2007-10-31 Marek Safar <marek.safar@gmail.com>
1920 A fix for bugs #337712, #324490
1921 * delegate.cs: Delegate covariance and contravariance is not allowed for
1924 2007-10-31 Marek Safar <marek.safar@gmail.com>
1926 A fix for bug #337719
1927 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1930 2007-10-30 Marek Safar <marek.safar@gmail.com>
1932 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1934 2007-10-29 Marek Safar <marek.safar@gmail.com>
1936 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1939 2007-10-29 Raja R Harinath <rharinath@novell.com>
1941 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1943 2007-10-29 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #334652
1946 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1947 extension methods when we have not found the best candidate in normal
1950 2007-10-27 Marek Safar <marek.safar@gmail.com>
1952 * AssemblyInfo.cs: Keep up-to-date.
1954 2007-10-27 Marek Safar <marek.safar@gmail.com>
1956 * Makefile: Fixed generics compiler name.
1958 2007-10-27 Marek Safar <marek.safar@gmail.com>
1960 * lambda.test: removed, lambda parsing is done differently.
1962 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1964 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1966 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1968 2007-10-27 Marek Safar <marek.safar@gmail.com>
1970 * Makefile, *.sources : All C# compilers are in mcs folder.
1972 * *.cs: Use existing 2_1 define for smcs.
1974 2007-10-26 Marek Safar <marek.safar@gmail.com>
1976 A fix for bug #335847
1977 * assign.cs, expression.cs: Couple of changes to avoid creating a
1978 temporary variable for each object initializer assignment statement. It
1979 simplifies struct initialization too, otherwise two temporary variables
1981 Implemented optimization of redundant default element initializers.
1983 2007-10-25 Marek Safar <marek.safar@gmail.com>
1985 A fix for bug #336766
1986 * expression.cs (Class.CheckBase): Use generic name when method is
1989 2007-10-25 Marek Safar <marek.safar@gmail.com>
1991 A fix for bug #334737
1992 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
1993 variable and not variable argument for prepared copies.
1995 2007-10-24 Marek Safar <marek.safar@gmail.com>
1997 A fix for bug #325110
1998 * class.cs, expression.cs, attribute.cs: Use open generic method when
1999 checking conditional attribute.
2001 2007-10-24 Marek Safar <marek.safar@gmail.com>
2003 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
2004 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
2005 FeatureIsNotAvailable.
2007 2007-10-24 Marek Safar <marek.safar@gmail.com>
2009 ** C# 3.0 Partial methods
2011 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
2012 methods support. Because of member cache issue with generics only
2013 non-generics partial methods are fully supported.
2015 2007-10-23 Marek Safar <marek.safar@gmail.com>
2017 * class.cs, decl.cs: Rewrote member overloads check to cope with
2018 generics and to use member cache for member checking. It also improves
2019 performance and fixes remaining overloads issues.
2021 2007-10-20 Marek Safar <marek.safar@gmail.com>
2023 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
2024 roottypes.cs, typemanager.cs:
2026 A member cache creation logic changed to add members immediately and
2027 not rely on fallback. The member cache is now only prefered way
2028 how to access and find type declaration members. It saves 5 MB of memory
2029 during MWF compilation and makes code ready for more optimizations and
2030 clean-ups, it's also a pre-requirement for partial methods.
2032 2007-10-18 Raja R Harinath <harinath@gmail.com>
2034 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
2035 handling for generic parameters.
2037 2007-10-15 Marek Safar <marek.safar@gmail.com>
2039 * class.cs (FixedField): Removed redundant volatile check.
2041 2007-10-15 Marek Safar <marek.safar@gmail.com>
2043 * class.cs, decl.cs: Fixed overload members verification to do only one
2044 check per possible collision.
2046 2007-10-13 Marek Safar <marek.safar@gmail.com>
2048 A fix for bug #325478
2049 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
2050 and create only one disposable flags container.
2052 2007-10-12 Marek Safar <marek.safar@gmail.com>
2054 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
2055 * statement.cs (Fixed): Fixed variables cloning.
2057 2007-10-12 Marek Safar <marek.safar@gmail.com>
2059 A fix for bug #333342
2060 * class.cs (EventField): Don't mark value type event as synchronized.
2062 2007-10-12 Marek Safar <marek.safar@gmail.com>
2064 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
2065 inference to identify best candidate method correctly.
2066 (ProperyExpr): A range variable is read only and cannot be modified.
2068 2007-10-11 Marek Safar <marek.safar@gmail.com>
2070 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
2071 logic to identify best candidate method correctly.
2073 2007-10-11 Marek Safar <marek.safar@gmail.com>
2075 * location.cs (Equals, GetHashCode): Removed.
2077 2007-10-11 Marek Safar <marek.safar@gmail.com>
2079 * report.cs: Implemented message recorder. It is used mainly for lambda
2080 expressions to capture otherwise swallowed error messages.
2082 * anonymous.cs, lambda.cs.cs: Do full parameters check.
2084 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
2086 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
2088 * expression.cs (MemberAccess): Always report lookup failure.
2090 * location.cs: Implemented Equals, GetHashCode.
2092 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
2094 2007-10-10 Jb Evain <jbevain@novell.com>
2096 * codegen.cs: re-enable assembly version check.
2098 2007-10-09 Marek Safar <marek.safar@gmail.com>
2100 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
2103 * namespace.cs (UsingAlias): Do correct version check.
2105 2007-10-08 Marek Safar <marek.safar@gmail.com>
2107 * expresison.cs, ecore.cs: Issue extension method error message when
2110 * rootcontext.cs: Added ISO_2 compiler mode option.
2112 2007-10-08 Marek Safar <marek.safar@gmail.com>
2114 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
2117 2007-10-08 Marek Safar <marek.safar@gmail.com>
2119 * attribute.cs (GetString, GetBoolean): Work with both literal and
2122 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
2123 Moved method overload specific methods to MethodGroupExpr.
2125 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
2126 it should be less memory consuming.
2128 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
2130 * codegen.cs: remove the assembly version check until the buildbot is
2133 2007-10-07 Jb Evain <jbevain@novell.com>
2135 * attribute.cs (Attribute.GetString): if the value
2136 expression is a StringConstant, return its string value.
2138 2007-10-07 Jb Evain <jbevain@novell.com>
2140 * typemanager.cs: add `assembly_version_attribute_type`.
2141 * codegen.cs: on attribute emission, check that the
2142 AssemblyVersionAttribute doesn't overflow.
2144 2007-10-05 Marek Safar <marek.safar@gmail.com>
2146 A fix for bug #324677
2147 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
2148 parent container of a scope container with currently resolved one.
2150 2007-10-05 Marek Safar <marek.safar@gmail.com>
2152 A fix for bug #325534
2153 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
2156 2007-10-05 Marek Safar <marek.safar@gmail.com>
2158 A fix for bug #327504
2159 * class.cs (Operator.Define): Refactored implicit and explicit user
2160 operator conversion rules.
2162 2007-10-05 Marek Safar <marek.safar@gmail.com>
2164 A fix for bug #327520
2165 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
2167 2007-10-04 Marek Safar <marek.safar@gmail.com>
2169 A fix for bug #328022
2170 * class.cs (MethodData.Define): Use correct method to check whether
2171 a method implementents an accessor.
2173 2007-10-04 Marek Safar <marek.safar@gmail.com>
2175 A fix for bug #330069
2176 * statement.cs (Fixed.Resolve): Read the first array element only when
2177 an array is instantiated.
2179 2007-10-04 Marek Safar <marek.safar@gmail.com>
2181 * expression.cs, assign.cs, generics.cs: Print correct operator when
2182 compound assignment is used.
2184 2007-10-04 Marek Safar <marek.safar@gmail.com>
2186 A fix for bug #325841
2187 * expression.cs (ArrayAccess): Use full argument cloning only for
2188 string compound concatenation.
2190 2007-10-03 Marek Safar <marek.safar@gmail.com>
2192 A fix for bug #328774
2193 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
2195 (PropertyExpr.EmitAssign): Fixed string concatenation compound
2198 2007-10-03 Raja R Harinath <rharinath@novell.com>
2201 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
2202 Event accessibility checks here. Remove some bogus code that
2203 accidently made GenericMethods work.
2204 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
2206 2007-09-25 Marek Safar <marek.safar@gmail.com>
2208 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
2210 * statement.cs (Block): Refactored AddVariable to allow error handling
2213 * generic.cs: New stub.
2215 2007-09-23 Marek Safar <marek.safar@gmail.com>
2217 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
2220 2007-09-17 Marek Safar <marek.safar@gmail.com>
2222 * class.cs: Use partial container to record whether any partial part
2223 contains static field initializer and therefore default contructor has
2226 2007-09-14 Marek Safar <marek.safar@gmail.com>
2228 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
2229 mono-list when only one of two partial parts has defined accessibility
2232 2007-09-14 Marek Safar <marek.safar@gmail.com>
2234 A fix for bug #82845
2236 * class.cs (TypeContainer): Set correct resolve context for all field
2239 2007-09-13 Marek Safar <marek.safar@gmail.com>
2241 * assign.cs: Fixed a crash when field is resolved twice with an error.
2243 * codegen.cs: Changed InFieldInitializer to be flag.
2245 * anonymous.cs, ecore.cs, expression.cs: Update after
2246 IsInFieldInitializer rename.
2248 * const.cs: Removed unused parameter.
2250 * class.cs: Changed the way how we resolve and emit field initializers.
2251 The field initilizers have to have access to contructor block to emit
2252 compiler generated code.
2254 2007-09-13 Marek Safar <marek.safar@gmail.com>
2256 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
2257 generics use TypeContainer instead.
2259 2007-09-12 Marek Safar <marek.safar@gmail.com>
2261 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
2263 * lambda.cs (ResolveParameters): Use more powerful
2264 InflateGenericArgument.
2266 * parameters.cs: Better exception message.
2268 2007-09-10 Marek Safar <marek.safar@gmail.com>
2270 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
2271 correct expression block type.
2273 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
2275 * expression.cs (Invocation): Extracted method group resolve to
2278 2007-09-07 Marek Safar <marek.safar@gmail.com>
2280 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
2281 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
2283 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
2284 generic extension methods.
2286 2007-09-06 Marek Safar <marek.safar@gmail.com>
2288 A fix for bug #82676 (Do I get it right now?)
2289 * convert.cs (Binary.ResolveOperator): An interface is converted to the
2290 object before a standard conversion is applied.
2292 2007-09-06 Marek Safar <marek.safar@gmail.com>
2294 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
2297 2007-09-05 Marek Safar <marek.safar@gmail.com>
2299 A fix for bug #82676
2300 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
2301 non-generic interface types.
2303 2007-09-05 Marek Safar <marek.safar@gmail.com>
2305 A fix for bug #82690
2306 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
2308 2007-09-05 Marek Safar <marek.safar@gmail.com>
2310 A fix for bug #82571
2311 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
2312 modifier for container based methods.
2314 2007-09-05 Marek Safar <marek.safar@gmail.com>
2316 A fix for bug #82676
2317 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
2318 any interface-type T means to any of interface type T.
2320 2007-09-04 Marek Safar <marek.safar@gmail.com>
2322 * namespace.cs: We have 2 versions of System.Core assembly.
2324 2007-09-04 Marek Safar <marek.safar@gmail.com>
2326 A fix for bug #82652
2327 * class.cs (Class.GetClassBases): Compare types and not expressions.
2329 2007-09-04 Marek Safar <marek.safar@gmail.com>
2331 A fix for bug #82620
2332 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
2333 actually never worked before.
2334 (IndexerAccess): Emit prepared arguments before they are modified.
2336 2007-09-04 Marek Safar <marek.safar@gmail.com>
2338 A fix for bug #82563
2339 * assign.cs: Revert wrong fix.
2341 * expression.cs (VariableReference.EmitAssign): Handle ref reference
2343 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
2344 Instead of ldelema/stdind we have to use temporary variables to handle
2345 cases like String.Concat (params string[]).
2347 2007-08-31 Marek Safar <marek.safar@gmail.com>
2349 * class.cs: EmitAttributes to Emit rename.
2351 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
2353 (MemberCore.HasClsCompliantAttribute): Don't depend on
2354 GetClsCompliantAttributeValue execution.
2356 2007-08-31 Marek Safar <marek.safar@gmail.com>
2358 * anonymous.cs: Use shorter type prefix.
2360 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
2363 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
2364 variables when probing is on.
2366 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
2367 unresolved variables.
2368 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
2369 handle transparent identifiers.
2371 2007-08-26 Marek Safar <marek.safar@gmail.com>
2373 * attribute.cs (IsClsCompliant): Add nullable types test.
2375 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
2377 * doc.cs : catch other types of exception than XmlException to
2378 report CS1570. Fixed bug #82565.
2380 2007-08-23 Marek Safar <marek.safar@gmail.com>
2382 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
2383 The number of delegate parameters has to match.
2384 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
2387 2007-08-21 Marek Safar <marek.safar@gmail.com>
2389 * anonymous.cs (AnonymousMethod): Generate private anonymous method
2390 to fix problem with private arguments.
2392 2007-08-20 Marek Safar <marek.safar@gmail.com>
2394 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
2396 * decl.cs (MemberName): Ignore generic type with no generic arguments.
2398 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
2399 empty. Add cloning suport.
2401 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
2403 2007-08-20 Marek Safar <marek.safar@gmail.com>
2405 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
2406 to create EmptyCast. It handles EmptyConstantCast specialization for
2409 2007-08-18 Marek Safar <marek.safar@gmail.com>
2411 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
2412 (EmitArrayArgument): One routine for array arguments.
2413 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
2415 2007-08-17 Marek Safar <marek.safar@gmail.com>
2417 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
2419 2007-08-17 Marek Safar <marek.safar@gmail.com>
2421 * anonymous.cs: MemberLookupFinal update.
2423 * class.cs (ConstructorInitializer): Is expression based.
2425 * delegate.cs: MethodGroupExpr update.
2427 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
2429 (Error_MemberLookupFailed): Customizable error override.
2430 (MethodGroupExpr): Keep queried type for later usage.
2431 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
2434 * expression.cs: Error_MemberLookupFailed refactoring.
2435 (New.DoResolve): Resolve as much as possible.
2436 (ElementInitializer.Error_MemberLookupFailed): Object initializer
2437 customization for invalid member types.
2439 * statement.cs: MethodGroupExpr update.
2441 2007-08-16 Marek Safar <marek.safar@gmail.com>
2443 * modifier.cs (Check): Check all modifiers and not only accessibility
2446 2007-08-16 Marek Safar <marek.safar@gmail.com>
2448 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
2449 type and not an expression.
2451 2007-08-16 Marek Safar <marek.safar@gmail.com>
2453 * statement.cs (Catch.Clone): Type and variable can be null.
2455 2007-08-16 Marek Safar <marek.safar@gmail.com>
2457 A fix for bug #81979
2458 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
2459 I am really not sure whether this is the best fix.
2461 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
2464 2007-08-14 Marek Safar <marek.safar@gmail.com>
2466 ** C# 3.0 Object and collection initializers (major re-write)
2468 * assign.cs (DoResolve): Initializers are not assign related.
2470 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
2471 used during collection or object initialization.
2473 * expression.cs (Error_InvalidArguments): Add initializers specific
2474 messages. More will come later because it requires some general
2476 (New.DoResolve): Better error handling for unsafe types.
2477 (EmptyExpressionStatement): New class.
2478 (ElementInitializer): An object initializer expression.
2479 (CollectionElementInitializer): A collection initializer expression.
2480 (CollectionOrObjectInitializers): A block of object or collection
2482 (NewInitialize): New expression with element/object initializers.
2484 * statement.cs: Reverted object/collection initializer hacks.
2486 * typemanager.cs (CSharpName): Filter __arglist type.
2488 2007-08-09 Marek Safar <marek.safar@gmail.com>
2490 ** C# 3.0 Anonymous Types (update to the latest standard)
2492 * expression.cs (Binary.ResolveOperator): Threat all null based types
2494 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
2495 (AnonymousTypeParameter): Updated.
2497 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
2498 (AnonymousTypeClass): New anonymous type container.
2500 * class.cs (AddField): Return operation result.
2502 * generic.cs: Another empty TypeArguments overload.
2504 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
2505 are stored at top of normal hierarchy.
2507 * typemanager.cs (CSharpName): Filter anonymous types.
2509 2007-08-09 Marek Safar <marek.safar@gmail.com>
2511 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
2512 as single Concat call. How could we miss that :-(
2514 2007-08-08 Marek Safar <marek.safar@gmail.com>
2516 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
2518 2007-08-07 Miguel de Icaza <miguel@novell.com>
2520 * expression.cs: Fix the previous commit, the creation of the
2521 arguments array list needs also to be conditional on the arguments
2524 * class.cs: Add a little bit of help to help narrow down problems.
2526 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
2527 not try to copy in that case.
2529 * driver.cs: When building SMCS, include a new different set of
2530 default assemblies here. Do this here so we can control whether
2531 to include the default assemblies with /noconfig.
2533 2007-08-03 Marek Safar <marek.safar@gmail.com>
2535 A fix for bug #81979
2536 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
2539 2007-08-03 Marek Safar <marek.safar@gmail.com>
2541 A fix for bug #82300
2543 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
2544 we are in probing scope.
2546 2007-08-03 Marek Safar <marek.safar@gmail.com>
2548 A fix for bug #82301
2550 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
2551 (Statement.CloneTo): Clone and not map children blocks.
2553 2007-08-03 Marek Safar <marek.safar@gmail.com>
2555 A fix for bug #82299
2557 * expression.cs (LocalVariableReference.CloneTo): Remap local info
2560 * statement.cs (Statement.CloneTo): Clone variables before statements
2561 to allow remaping of local variables.
2563 2007-08-03 Marek Safar <marek.safar@gmail.com>
2565 A fix for bug #82296
2568 * report.cs: Log crash details for future clone problems.
2570 * statement.cs (Return.Clone): Don't clone non-existent expression.
2572 2007-08-03 Raja R Harinath <harinath@gmail.com>
2574 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
2575 (Class.AddBasesForPart): Move CS0537 check here from ...
2576 * cs-parser.jay (class_declaration): ... here. Move calling of
2577 'AddBasesForPart' to ...
2578 (class_bases): ... here.
2579 (struct_declaration, interface_declaration): Update to changes.
2581 2007-08-02 Marek Safar <marek.safar@gmail.com>
2583 A fix for bug #81923
2585 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
2586 conversion is allowed.
2588 2007-08-02 Marek Safar <marek.safar@gmail.com>
2590 A fix for bug #81564
2592 * ecore.cs (EventExpr): Add IsBase handling.
2594 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
2597 2007-08-02 Raja R Harinath <harinath@gmail.com>
2599 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
2600 * cs-parser.jay: Some whitespace cleanups.
2601 (current_delegate): New.
2603 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
2604 a dummy code block, and use 'type_name' instead of 'member_name'.
2605 (interface_declaration, class_declaration): Likewise.
2606 (delegate_declaration): Likewise. Rearrange slightly and use
2608 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
2609 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
2611 2007-08-02 Marek Safar <marek.safar@gmail.com>
2613 A fix for bug #82039
2615 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
2618 * typemanager.cs (CSharpName): Split to string overload.
2620 2007-08-02 Marek Safar <marek.safar@gmail.com>
2623 * report.cs: Updated warning CS0472.
2625 2007-08-01 Marek Safar <marek.safar@gmail.com>
2627 A fix for bug #82181
2629 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
2631 2007-08-01 Marek Safar <marek.safar@gmail.com>
2633 A fix for bug #82277
2634 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
2636 2007-08-01 Marek Safar <marek.safar@gmail.com>
2638 ** C# 3.0 Type Inference (major bits are working)
2640 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
2641 (.ImplicitStandardConversionExists): Uses compatible.
2642 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
2643 (.InferReturnType): New method.
2644 (.Compatible): Refactored.
2645 (.ResolveParameters): Uses factory to create resolved parameters.
2646 (.CompatibleMethod): Add probing mode support.
2647 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
2648 clearly distinguish between 2 different operations.
2649 (LambdaMethod): Moved to lambda.cs.
2650 (AnonymousMethod): Removed unused fields and methods.
2651 (AnonymousDelegate): Simplified.
2653 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
2655 * convert. cs (ImplicitConversionStandard): Compatible works differently.
2657 * delegate.cs (Delegate): New mehods to reduce code duplication.
2658 (.GetConstructor): New method.
2659 (.GetInvokeMethod): New method.
2660 (DelegateCreation): Updated.
2662 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
2664 (OverloadResolve): Made probing little bit faster.
2666 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
2669 * generic.cs (TypeInferenceContext): Dummy implementation.
2671 * iterators.cs: Updated after Resolve/Define rename.
2673 * lambda.cs (LambdaExpression)
2674 (.ResolveParameters): Handles both type of arguments and type inference too.
2676 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
2677 (InflateTypes): Updated.
2679 * support.cs (InflateTypes): Changed signature and updated.
2681 * typemanager.cs (LookupMemberCache): Better dynamic type check.
2682 (MemberLookup_FindMembers): More MS tricks.
2683 (GetParameterData): Ditto.
2684 (GetDelegateParameters): Uses quick path for dynamic types.
2686 2007-08-01 Marek Safar <marek.safar@gmail.com>
2688 * class.cs (MethodData.Define): EmitContext is required for generic stuff
2691 2007-07-31 Marek Safar <marek.safar@gmail.com>
2693 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
2696 2007-07-26 Jb Evain <jbevain@novell.com>
2698 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
2699 which takes a boolean 'report_errors', similar to the GetMethod.
2700 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
2701 in .net 2.1, do not report errors here.
2703 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
2704 System.Runtime.CompilerServices.RequiredAttributeAttribute and
2705 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
2708 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
2709 of the type InternalsVisibleToAttribute before the first call
2710 to CoreLookupType which is allowed to fail (third boolean parameter
2711 to true). Because, during the resolution for a type that is not
2712 immediately found, we try to check if the type is not defined in
2713 a friend assembly, and to do so, we need the
2714 InternalVisibleToAttribute.
2716 2007-07-23 Miguel de Icaza <miguel@novell.com>
2718 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
2719 feature that allows structs to be compared against null and inline
2720 the result as true or false.
2722 Notice that the same code is not permitted inside a generic block
2723 of code that would do:
2725 class Foo<T> where T : struct {
2732 It is only allowed if the type of T is not bound (no where
2733 clause). In my opinion, this CSC 2 behavior is broken but people
2734 seem to be using it (IronRuby does, a few bug reports on bugzilla
2735 have it and some people have complained about it).
2737 All of the users that depend on this behavior have code that is
2740 * report.cs (Warning, Error): make these take object arguments,
2741 not strings, as that allows us to take advantage of Format.
2743 2007-07-20 William Holmes <billholmes54@gmail.com>
2745 * decl.cs: Changed MemberName.CountTypeArguments to also check the
2746 Left member variable for the Count.
2747 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
2748 MemberName.CountTypeArguments to avoid a NRE.
2750 This code is contributed under the MIT X11 license
2752 2007-07-18 Marek Safar <marek.safar@gmail.com>
2754 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
2756 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2758 * doc.cs : generic method arguments are written as ``x while generic
2759 type arguments are `x. Combined with the previous change, fixed bug
2762 2007-07-18 Raja R Harinath <rharinath@novell.com>
2765 * expression.cs (Binary.ResolveOperator): When converting
2766 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
2768 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2770 * doc.cs : when T: or whatever x: is specified, it does not really
2771 check the doc comment's syntax correctness. Fixed bug #82006.
2773 2007-07-18 Marek Safar <marek.safar@gmail.com>
2775 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
2776 LambdaExpression better.
2778 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
2780 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
2782 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
2783 as it can be generated.
2785 * expression.cs (Invocation.Error_InvalidArguments): Show correct
2788 * lambda.cs (LambdaExpression): Refactored to share same code with
2789 AnonymousMethodExpression.
2791 2007-07-17 Marek Safar <marek.safar@gmail.com>
2793 * anonymous.cs (MakeName): Include host name for easier debugging.
2794 (LambdaMethod): New class for lambda spcecific stuff.
2796 * attribute.cs: Set EmitContext return type.
2798 * class.cs: Set EmitContext return type.
2800 * codegen.cs (EmitContext): Return type cannot be null to stop messing
2801 with null/void meaning.
2803 * iterators.cs (ContainerType): Implemented.
2805 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
2807 * statement.cs (Return): Updated to lambda expressions.
2808 (Block.CloneTo): Parent can be null.
2810 2007-07-13 Marek Safar <marek.safar@gmail.com>
2812 A fix for bug #81917
2813 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
2815 * class.cs (FixedField): Check whether field is in unsafe scope.
2817 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
2818 (FieldExpr.Emit): Fixed buffers cannot be volatile.
2820 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
2823 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
2825 2007-07-13 Marek Safar <marek.safar@gmail.com>
2827 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
2828 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
2831 2007-07-13 Marek Safar <marek.safar@gmail.com>
2833 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
2835 2007-07-13 Marek Safar <marek.safar@gmail.com>
2837 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
2838 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
2840 * codegen.cs(EmitContext): Add ProbingMode flag.
2842 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
2844 * driver.cs: For now set both warning values.
2846 * ecore.cs (SimpleName): Name is readonly.
2847 (MethodGroup.OverloadResolve): One quick path for probing.
2849 * expression.cs (Unary): Set Oper r/o.
2850 (Binary): Set Oper r/o.
2851 (ParameterReference): Set few instance variables as r/o.
2852 (ParameterReference.DoResolveBase): Don't capture aruments when
2854 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2855 (Arglist): arguments are private.
2856 (SizeOf): type is private and r/o.
2857 (MemberAccess): arguments are private.
2859 * report.cs: Enhanced reporting on/off capabilities.
2861 * lambda.cs: Uses ec.IsInProbingMode.
2862 (ContextualReturn): Derives from return.
2864 * rootcontext.cs: For now set both warning values.
2866 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2868 (Return.Resolve): Don't die immediately.
2869 (Block.Resolve): Speed-up probing.
2870 (Block.CloneTo): Clone only child blocks.
2872 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2874 * iterators.cs: reverted Miguel's latest change (r81925) as it
2875 breaks the build in System.
2877 2007-07-13 Miguel de Icaza <miguel@novell.com>
2879 * iterators.cs (Yield.CheckContext): Check for the iterator type
2880 also here as we can call into Yield even in codepaths that are not
2882 (MethodOrOperator is the only path that was checked).
2884 In addition to the standard check, use a more specific check for
2885 constructors to report a more verbose error.
2887 2007-07-12 Miguel de Icaza <miguel@novell.com>
2889 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2890 report the warning and continue
2892 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2893 values on the stack on the call to Emit. Use EmitStatement if
2894 possible, or using Emit + Pop if not possible. Fixes #82064
2896 2007-07-12 Raja R Harinath <rharinath@novell.com>
2898 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2899 avoid try...finally in some cases.
2901 2007-07-10 Marek Safar <marek.safar@gmail.com>
2903 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2905 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2906 instead of method. Re-use standard error handling.
2907 (ConstructorInitializer.Emit): Simplified.
2909 * delegate.cs: Updated after Invocation.EmitCall change.
2911 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2912 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2913 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2914 method and don't permanently changing input arguments.
2915 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2916 is resolved it has one of the candidates is the best one which is later
2917 used to emit. Removed a few unused method.
2918 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2920 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2921 (Binary.ResolveOperator): Ditto.
2922 (ConditionalLogicalOperator.DoResolve): Ditto.
2923 (Invocation): Uses method group.
2924 (Invocation.DoResolve): Simplified.
2925 (Invocation.EmitCall): Removed useless is_static.
2926 (Invocation.Emit): Delegate to method group.
2927 (Invocation.EmitStatement): Simplified.
2928 (New): Uses method group.
2929 (MemberAccess.DoResolve): Don't destroy original expression.
2931 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2933 2007-07-04 Marek Safar <marek.safar@gmail.com>
2935 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2938 * lambda.cs: Add custom error message type.
2940 2007-07-03 Marek Safar <marek.safar@gmail.com>
2942 * lambda.cs: Simplified little bit.
2944 * parameter.cs: Introduced ImplicitLambdaParameter.
2945 (Parameters.CreateFullyResolved): New factory instead of ctor.
2949 * delegate.cs: Updated parameter creation.
2951 2007-07-03 Marek Safar <marek.safar@gmail.com>
2953 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2956 * generic.cs: Synchronized with gmcs.
2958 2007-07-03 Marek Safar <marek.safar@gmail.com>
2960 * class.cs (Indexer): Check return type as soon as possible.
2962 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2965 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2967 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2969 * parameter.cs (Parameter): Use expression type when it is available.
2971 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2972 method modifier for the first parameter only.
2974 2007-06-24 Marek Safar <marek.safar@gmail.com>
2976 A fix for bug #81938
2977 * typemanager.cs (ChangeType): Fixed couple of char conversions.
2979 * constant.cs: Tide up an exception message.
2981 2007-06-22 Marek Safar <marek.safar@gmail.com>
2983 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
2984 an uninitialized variable is used.
2986 * expression.cs (LocalVariableReference.DoResolve): Ditto.
2988 2007-06-22 Marek Safar <marek.safar@gmail.com>
2990 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
2991 not found error handling.
2993 * expression.cs (ArrayCreation): Removed redundant fields and little bit
2995 (ArrayCreation.ResolveArrayElement): To be ready to customization.
2996 (ArrayCreation.DoResolve): Simplified.
2997 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
2998 its own resolve process.
2999 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
3001 2007-06-20 Marek Safar <marek.safar@gmail.com>
3003 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
3006 2007-06-20 Marek Safar <marek.safar@gmail.com>
3008 * cs-tokenizer.cs: Removed var related stuff.
3010 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
3011 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
3012 a type and a keyword at same time.
3014 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
3017 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
3018 implicitly typed arrays, more changes will follow.
3020 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
3022 2007-06-19 Marek Safar <marek.safar@gmail.com>
3024 * ecore.cs (VarExpr): Removed Handled field.
3026 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
3027 build-in assign functionality.
3028 (ForEach.Resolve): Removed all implicitly typed local variable code and
3030 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
3031 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
3033 2007-06-18 Marek Safar <marek.safar@gmail.com>
3035 * assign.cs: Removed implicitly typed local variable check.
3037 * expression.cs (LocalVariableReference.DoResolve): Add check for self
3038 referencing implicitly typed local variable.
3039 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
3042 * statement.cs (Fixed): Removed unsupported implicitly typed local
3045 2007-06-15 Marek Safar <marek.safar@gmail.com>
3047 * decl.cs (MemberName): Moved all Unbound stuff to parser.
3049 2007-06-14 Marek Safar <marek.safar@gmail.com>
3051 A fix for bugs #81855 and #76274
3052 * attribute.cs (AttachTo): Always set owner for global attributes to
3055 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
3058 * cs-parser.jay: Assembly and module attributes must precede all other
3059 elements except using clauses and extern alias declarations.
3061 2007-06-13 Marek Safar <marek.safar@gmail.com>
3063 A fix for bug #81748
3065 * expression.cs: More checks for non ISO-1 features.
3067 2007-06-12 Marek Safar <marek.safar@gmail.com>
3069 A fix for bug #81807
3070 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
3071 present inside switch statement and it is required by nullable check.
3073 2007-06-12 Marek Safar <marek.safar@gmail.com>
3075 A fix for bug #81840
3076 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
3077 when type matching fails.
3079 * namespace.cs: Tiny error message change.
3081 2007-06-12 Marek Safar <marek.safar@gmail.com>
3083 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
3084 reporting. Added automatic property check.
3086 * class.cs: Updated after CheckAbstractAndExtern relocation.
3087 (AEventPropertyAccessor.GetSignatureForError): Customized.
3089 2007-06-11 Marek Safar <marek.safar@gmail.com>
3091 * class.cs (DefineBaseTypes): Base type can be undefined.
3093 * ecore.cs (TypeLookup): Minor refactoring.
3094 (DoResolveAsTypeStep): Removed redundant check.
3096 * namespace.cs (Lookup): Removed redundant check.
3098 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
3099 ResolveAsTypeTerminal step.
3100 (BootstrapCorlib_*): Simplified.
3101 (PopulateCoreType): Core types can be now external.
3103 2007-06-07 Marek Safar <marek.safar@gmail.com>
3105 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
3107 (InferTypeArguments): Infers anonymous expression type arguments.
3108 (Compatible): Split to Compatible and InferTypeArguments.
3110 * lambda.cs: Updated.
3112 2007-06-08 Marek Safar <marek.safar@gmail.com>
3114 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
3116 2007-06-07 Raja R Harinath <harinath@gmail.com>
3118 Fix #80477, cs0135-2.cs, cs0135-3.cs
3119 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
3120 names to the "known" variables list.
3121 (Block.CheckInvariantMeaningInBlock): Handle the fact the
3122 parameter names are also "known".
3123 (Block.CheckError136): Remove.
3124 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
3127 2007-06-07 Marek Safar <marek.safar@gmail.com>
3129 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
3131 2007-06-06 Marek Safar <marek.safar@gmail.com>
3133 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
3134 internal error not an user error.
3136 * expression.cs (IsApplicable): Refactored to make debugging easier.
3138 * support.cs: More tricks for non-mono runtimes.
3140 * typemanager.cs (CoreLookupType): Made public.
3141 (InitSystemCore): All linq specific stuff moved to linq.cs
3143 2007-06-05 Marek Safar <marek.safar@gmail.com>
3145 * typemanager.cs (CSharpSignature): One more missing build-in types
3147 More tricks for non-mono runtime.
3149 2007-06-05 Raja R Harinath <harinath@gmail.com>
3151 * statement.cs (Block.CheckError136_InParents): Remove.
3152 (Block.AddVariable): Use GetParameterInfo instead.
3153 (ToplevelBlock.ProcessArguments): Likewise.
3155 2007-06-04 Raja R Harinath <rharinath@novell.com>
3157 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
3159 (ToplevelBlock.GetParameterInfo): Split out of ...
3160 (ToplevelBlock.GetParameterRefernce): ... this.
3161 (ToplevelBlock.ParameterMap): Remove.
3162 * expression.cs (ParameterReference): Update to use
3163 ToplevelParameterInfo.
3165 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
3168 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
3169 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
3171 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
3172 (ToplevelBlock.ProcessParameters) ... here.
3173 (ToplevelBlock..ctor): Invoke it.
3175 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
3178 * statement.cs (IKnownVariable): New interface.
3179 (LocalInfo): Implement it.
3180 (ToplevelParameterInfo): New class.
3181 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
3182 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
3183 GetKnownVariableInfo.
3185 2007-06-03 Raja R Harinath <harinath@gmail.com>
3187 Partly speed up CS0136 error checks.
3188 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
3189 'recurse' parameter.
3190 (Block.DoCheckError136): Only check errors in parameters. Move
3191 local variable checks ...
3192 (Block.AddVariable): ... here, and ...
3193 (ToplevelBlock.ResolveMeta): ... here.
3195 2007-06-02 Raja R Harinath <harinath@gmail.com>
3197 * statement.cs (Block.IsChildOf): Remove.
3199 * statement.cs (Statement.Clone): Move special case code ...
3200 (Block.CloneTo): ... here.
3202 2007-05-29 Raja R Harinath <rharinath@novell.com>
3204 * statement.cs (ToplevelBlock.container): Remove field. It's
3205 redundant with 'Parent'.
3206 (ToplevelBlock.ContainerBlock): Remove accessor.
3207 (ToplevelBlock..ctor): Update to changes. Register anonymous
3208 child with parent here, ...
3209 * cs-parser.jay (end_anonymous): ... not here. Don't modify
3211 (start_anonymous): Don't save current_block.
3212 (top_current_block): Remove.
3214 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
3215 (Block.Resolve): Update to changes.
3216 (Block..ctor): Move setting of "correct" 'Toplevel'
3217 and 'Explicit' fields to ...
3218 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
3220 2007-05-27 Raja R Harinath <harinath@gmail.com>
3223 * statement.cs (Block.Implicit): Remove.
3224 (Block): Update to changes.
3225 * flowanalysis.cs: Likewise.
3227 Mildly speed up CheckInvariantMeaningInBlock
3228 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
3229 Recursively call AddKnownVariable to all enclosing blocks.
3230 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
3231 Remove recursive calls.
3232 (Block): Update to changes.
3234 New ExplicitBlock invariants
3235 * statement.cs (Block.Explicit): New field. It points to the
3236 immediately enclosing non-implicit block.
3237 (Block..ctor): Maintain the invariant.
3238 * cs-parser.jay: Take advantage of invariant.
3240 Introduce ExplicitBlock
3241 * statement.cs (ExplicitBlock): New.
3242 (ToplevelBlock): Derive from it.
3243 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
3245 (Block.Implicit): Update to changes.
3246 * cs-parser.jay: Update to changes.
3249 * codegen.cs (EmitContext.IsLastStatement): Remove.
3250 * statement.cs (Block.DoEmit): Update to changes.
3252 2007-05-25 Raja R Harinath <rharinath@novell.com>
3254 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
3255 modifying current_block directly.
3257 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
3259 * class.cs: Implemented automatic properties (C# 3.0)
3260 Thanks to Marek for the help.
3262 2007-05-23 Raja R Harinath <rharinath@novell.com>
3264 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
3265 variable as assigned, note also that all its components are
3267 (MyBitVector.SetRange): New. Function to set multiple bits to true.
3269 2007-05-19 Marek Safar <marek.safar@gmail.com>
3271 * anonymous.cs, class.cs: Emit Compiler generated attribute when
3272 member is marked as compiler generated.
3274 * decl.cs (MemberCore): Refactored ModFlags into property.
3276 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
3277 (Check): Check only accessibility modifiers.
3279 2007-05-18 Raja R Harinath <rharinath@novell.com>
3281 Track all assignable slots in one bit array
3282 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
3283 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
3284 logic from VariableMap constructor here. Use the same 'offset'
3285 variable that's later used for computing offsets of local
3287 * flowanalysis.cs (UsageVector.parameters): Remove.
3288 (UsageVector): Update to changes.
3289 (VariableMap): Remove.
3291 Avoid creating ParameterMap in every block
3292 * statement.cs (Block.ParameterMap): Move ...
3293 (ToplevelBlock.ParameterMap): ... here.
3294 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
3296 * flowanalysis.cs (FlowBranching.param_map): Remove.
3297 (FlowBranching.UsageVector): Update to changes.
3298 (FlowBranchingToplevel.CheckOutParameters): Likewise.
3300 * statement.cs (Block.CloneTo): Clone Toplevel field too.
3302 * expression.cs (ParameterReference): Distinguish between block
3303 where parameter was referenced and declared.
3305 2007-05-18 Marek Safar <marek.safar@gmail.com>
3307 * flowanalysis.cs, statement.cs: Put back improved error handling.
3309 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
3313 Imporved object and collection initialization (C# 3.0).
3315 2007-05-15 Marek Safar <marek.safar@gmail.com>
3317 A fix for bug #81380
3318 * expression.cs (Is.DoResolve): Only value types have constant `is'
3321 2007-05-15 Raja R Harinath <rharinath@novell.com>
3323 * statement.cs (ToplevelBlock.child): Remove.
3325 2007-05-15 Raja R Harinath <harinath@gmail.com>
3327 Rationalize ResolveMeta: refactoring
3328 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
3329 out constant handling code into ...
3330 (Block.DoResolveConstants): ... this.
3332 Rationalize ResolveMeta: kill local_map
3333 * statement.cs (Block.local_map, Block.LocalMap): Remove.
3334 (Block.AssignableSlots): New.
3335 (Block.ResolveMeta): Make protected. Don't create a VariableMap
3336 for locals -- move code from VariableMap here. Avoid unnecessary
3338 * flowanalysis.cs (FlowBranching.local_map): Remove.
3339 (FlowBranching..ctor): Use Block.AssignableSlots.
3340 (VariableMap): Remove unused constructors.
3342 2007-05-11 Raja R Harinath <rharinath@novell.com>
3344 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
3346 2007-05-11 Marek Safar <marek.safar@gmail.com>
3348 * typemanager.cs (IsFriendAssembly): Should not be called for building
3351 2007-05-09 Marek Safar <marek.safar@gmail.com>
3353 * literal.cs (NullConstant): Print null in all cases.
3355 * expression.cs (Binary.ResolveOperator): Implemented delegate
3356 comparison based on C# 2.0 changes.
3358 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
3360 This code is contributed under the MIT X11 license
3362 The following enables support for several C# 3.0 language features:
3364 * cs-tokenizer.cs: Added support for the "var" keyword.
3366 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
3367 Added VarExpr class to facilitate type inferencing.
3369 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
3370 to support anonymous types.
3372 * assign.cs: Added support for type inferencing and initialization.
3374 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
3376 * expression.cs: Added implicit array support to ArrayCreation.
3377 Added 5 types and 1 interface:
3379 IInitializable Implementing classes can inject initializing
3380 statements after object instantiation.
3382 Initializer Stores data for object initialization.
3384 AnonymousType An expression for anonymous types.
3386 AnonymousTypeParameter Stores data about an anonymous type's field.
3388 NewInitialize An expression for object initialization.
3390 CollectionInitialize An expression for collection initialization.
3392 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
3395 2007-05-06 Marek Safar <marek.safar@gmail.com>
3397 A fix for bug #81500
3398 * cs-tokenizer.cs: Add special handling for coalescing operator.
3400 2007-05-06 Marek Safar <marek.safar@gmail.com>
3402 A fix for bug #81529
3403 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
3404 its value from base class until it is redefined.
3406 2007-05-02 Raja R Harinath <rharinath@novell.com>
3408 Fix regression in cs0631-3.cs
3409 * cs-parser.jay (operator_declarator): Add opt_attributes to error
3410 fallback. Make error fallback catch more cases.
3412 2007-05-01 Miguel de Icaza <miguel@novell.com>
3414 * cs-parser.jay: Allow parameters in operator declarations to have
3417 2007-04-27 Miguel de Icaza <miguel@novell.com>
3419 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
3422 * lambda.cs (ContextualReturn.Resolve): An expression is valid
3423 inside the ContextualReturn, it does not have to be an
3424 ExpressionStatement.
3426 2007-04-24 Miguel de Icaza <miguel@novell.com>
3428 * lambda.cs (ContextualReturn.Resolve): if the return type is not
3431 2007-04-23 Miguel de Icaza <miguel@novell.com>
3433 * anonymous.cs (AnonymousContainer): split the virtual Resolve
3434 method in two methods: ResolveNoDefine and Resolve.
3436 ResolveNoDefine will stop just after ResolveTopBlock has been
3439 Resolve will then continue by creating a method and issuing the
3440 call to method.Define ().
3442 (AnonymousMethod): Split and implement the new Resolve and
3443 ResolveNoDefine as well.
3445 * lambda.cs (LambdaExpression): Split the anonymous method
3446 resolution code into a separate routine (CoreCompatibilityTest)
3447 from DoCompatibleTest.
3449 (LambdaExpression.TryBuild): New method, this method tries to
3450 build the LambdaExpression with the given set of types to be used
3451 as the types for the various parameters of the lambda expression.
3453 If the compilation succeed with the given types, the infered type
3454 of the Anonymous method is returned, otherwise null is returned.
3456 2007-04-23 Marek Safar <marek.safar@gmail.com>
3458 A fix for bug #81414
3459 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
3461 2007-04-22 Miguel de Icaza <miguel@novell.com>
3463 * cs-tokenizer.cs: Change various identifiers here from the
3464 camelCasing to the recommended Linux-like style for instance
3465 variables from the Coding Guidelines.
3467 2007-04-19 Martin Baulig <martin@ximian.com>
3470 (Convert.ImplicitReferenceConversionCore): Allow conversions from
3471 System.Enum to System.ValueType.
3473 2007-04-13 Martin Baulig <martin@ximian.com>
3475 Rewrote implicit reference conversions. We need to distinguish
3476 between implicit reference conversions (13.1.4) and implicit
3477 boxing conversions (13.1.5).
3479 According to the spec, there's an an implicit conversion
3480 "From a one-dimensional array-type S[] to IList<T> and base
3481 interfaces of this interface, provided there is an implicit
3482 reference conversion from S to T." Note that this does not
3483 include boxing conversions.
3486 (Convert.ImplicitTypeParameterBoxingConversion): New method.
3487 (Convert.ImplicitReferenceConversion): Split into
3488 ImplicitReferenceConversionCore() and
3489 ImplicitBoxingConversionExist().
3490 (Convert.ImplicitReferenceConversionExists): Use the new
3491 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
3493 2007-04-12 Martin Baulig <martin@ximian.com>
3495 * convert.cs (Convert.ImplicitReferenceConversion): Move the
3496 `TypeManager.null_type' checks up to the top of the method.
3498 2007-04-11 Marek Safar <marek.safar@gmail.com>
3500 A fix for bug #81350
3501 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
3504 2007-04-11 Martin Baulig <martin@ximian.com>
3506 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
3507 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
3508 to make this work for generic classes; fixes #79561.
3510 2007-04-11 Martin Baulig <martin@ximian.com>
3512 * expression.cs (As): Add support for nullable types; fixes #79371.
3514 2007-04-11 Martin Baulig <martin@ximian.com>
3516 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
3517 `type.FullName' is null; fixes #80243.
3519 2007-04-11 Martin Baulig <martin@ximian.com>
3521 * expression.cs (Invocation.IsApplicable): Don't modify the method
3522 if type inference succeeded, but the method was not applicable.
3525 2007-04-10 Marek Safar <marek.safar@gmail.com>
3527 A fix for bug #81324
3528 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
3529 internal and external namespaces containers.
3531 2007-04-10 Martin Baulig <martin@ximian.com>
3533 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
3534 TypeManager.DropGenericMethodArguments() so we also call
3535 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
3537 2007-04-10 Martin Baulig <martin@ximian.com>
3539 * iterators.cs (Iterator.CreateIterator): Don't crash if
3540 `method.ReturnType' is null. This happens if something went wrong
3541 while resolving that typ (we already reported an error in this case).
3543 2007-04-10 Martin Baulig <martin@ximian.com>
3545 * expression.cs (New.DoResolve): Don't call CheckComImport() on
3546 generic interfaces; report the CS0144 directly.
3548 2007-04-10 Martin Baulig <martin@ximian.com>
3550 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
3551 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
3553 2007-04-10 Martin Baulig <martin@ximian.com>
3555 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
3557 2007-04-09 Raja R Harinath <rharinath@novell.com>
3560 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
3561 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
3564 * statement.cs (For.Resolve): If resolution fails, use
3567 2007-04-08 Marek Safar <marek.safar@gmail.com>
3569 * anonymous.cs (MakeName): Make faster and zero-based.
3570 (VerifyExplicitParameterCompatibility): Back to mode where generic
3571 parameter is ignored.
3572 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
3574 * class.cs (EmitType): Method can emit another new method.
3576 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
3578 * driver.cs: Updated.
3580 * lambda.cs: Reuse predefined empty parameters.
3582 * parameter.cs: Updated
3584 * support.cs: Implemented InflateTypes.
3586 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
3587 (InitSystemCore): Introduced to isolate 3.0 dependencies.
3589 2007-04-03 Martin Baulig <martin@ximian.com>
3593 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
3594 version of TypeManager.IsOverride() which also works with generic
3597 2007-04-03 Martin Baulig <martin@ximian.com>
3602 (Convert.ExplicitReferenceConversion): We need to cast when
3603 converting from IList<T> to S[].
3605 2007-04-01 Marek Safar <marek.safar@gmail.com>
3607 * decl.cs (FindExtensionMethods): Consider all candidates with same name
3610 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
3612 2007-03-31 Marek Safar <marek.safar@gmail.com>
3614 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
3615 argument and return type inferring.
3617 * codegen.cs (InferReturnType): Flag whether return can be inferred.
3618 (ReturnType): Turned to property.
3620 * statement.cs (Return): Implemented return type inferring.
3622 * support.cs (ReflectionParameters): Use local types if possible.
3624 2007-03-30 Raja R Harinath <rharinath@novell.com>
3626 * flowanalysis.cs (FlowBranching.Reachability): Remove.
3627 (FlowBranching.UsageVector): Update to changes.
3629 Prepare to kill 'Reachability'
3630 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
3631 argument of constructor.
3633 2007-03-29 Raja R Harinath <rharinath@novell.com>
3635 Prepare to kill 'Reachability'
3636 * flowanalysis.cs (UsageVector.is_unreachable): New.
3637 (UsageVector): Update to maintain 'is_unreachable' in parallel to
3638 'reachability', and verify they're consistent.
3641 * expression.cs (New.EmitStatement): Handle type parameters here too.
3643 2007-03-29 Martin Baulig <martin@ximian.com>
3648 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
3649 CompilerGeneratedClass.
3650 (ScopeInfo.EmitScopeInstance): Make this protected.
3651 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
3652 `ec.CurrentAnonymousMethod.Scope == Scope'.
3654 * statement.cs (Block.ScopeInfo): Make this a property.
3656 2007-03-27 Raja R Harinath <harinath@gmail.com>
3658 Prepare to kill 'Reachability'
3659 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
3660 (FlowBranching.UsageVector.Reachability): Remove property.
3661 (FlowBranching.UsageVector.IsUnreachable): New property.
3662 (FlowBranching.UsageVector.ResetBarrier): New.
3663 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
3664 * codegen.cs, statement.cs: Update to changes.
3666 2007-03-27 Martin Baulig <martin@ximian.com>
3671 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
3674 2007-03-26 Raja R Harinath <rharinath@novell.com>
3676 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
3677 instead of TriState. Remove all mention of TriState.
3679 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
3680 replaced by a boolean. Add boolean 'is_unreachable' field, check
3681 and maintain invariants.
3683 2007-03-25 Marek Safar <marek.safar@gmail.com>
3685 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
3687 2007-03-25 Marek Safar <marek.safar@gmail.com>
3689 * expression.cs: Stop using obsolete 2.0 opcodes.
3691 2007-03-25 Marek Safar <marek.safar@gmail.com>
3693 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
3694 one of the latests Martin's fixes.
3696 2007-03-23 Miguel de Icaza <miguel@novell.com>
3698 * expression.cs: On BigEndian systems, swap the bytes, temporary
3699 solution until we get a new bitconverter class.
3701 2007-03-23 Martin Baulig <martin@ximian.com>
3705 * decl.cs (MemberCache.AddMembers): Add generic methods both as
3706 "Method" and "Method`1". Normally, a cache lookup is done on the
3707 "Method" form (ie. without the generic arity), but this one makes
3708 lookups on the full form work as well.
3710 2007-03-22 Raja R Harinath <rharinath@novell.com>
3712 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
3715 2007-03-20 Bill Holmes <billholmes54@gmail.com>
3717 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
3718 ordered_member_list, to TypeBuilder to store members to be defined
3719 in the order they were parsed in.
3720 - ordered_explicit_member_list contains all properties indexers
3721 and methods that are defined as explicit implementation of an
3722 interface or base class.
3723 - ordered_member_list contains all properties indexers and methods
3724 that are not defined as explicit implementation of an interface
3727 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
3728 functionality in these removed classes has been replaced with
3729 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
3730 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
3732 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
3733 to CheckForDuplications inside GetMethod and SetMethod Define Method
3734 to handle method property and indexer name conflicts.
3738 All code is contributed under the MIT/X11 license.
3740 2007-03-20 Martin Baulig <martin@ximian.com>
3742 * class.cs (TypeContainer.Interfaces): Removed; they're now
3743 included in `TypeContainer.Types'.
3745 2007-03-20 Martin Baulig <martin@ximian.com>
3747 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
3749 * class.cs (TypeContainer.CreateType): New public method. This is
3750 now called before DefineType() to create the TypeBuilders.
3751 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
3752 has already been created by CreateType().
3753 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
3754 don't resolve our base classes here; this has been moved into
3755 DefineBaseTypes(). We're now called from CreateType().
3756 (TypeContainer.DefineBaseTypes): New private method; resolve our
3757 base classes here. We're now called from DefineType().
3760 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
3761 our types first to create all the TypeBuilders. After that, call
3762 TypeContainer.DefineType() on all the types which'll resolve their
3763 base classes and setup the resolve order.
3765 2007-03-20 Martin Baulig <martin@ximian.com>
3767 * class.cs (TypeContainer.Enums): Removed; they're now included in
3768 `TypeContainer.Types'.
3770 2007-03-20 Martin Baulig <martin@ximian.com>
3773 (TypeContainer.DefineType): Don't call ResolveMembers() here.
3774 (TypeContainer.DoResolveMembers): Call DefineType() on our
3775 `compiler_generated' classes; moved here from DefineNestedTypes().
3778 (RootContext.ResolveTree): Call ResolveMembers() on all
3779 TypeContainer's in the `type_container_resolve_order'.
3781 2007-03-19 Marek Safar <marek.safar@gmail.com>
3783 * class.cs: Use corlib to handle InternalMethodImplAttribute.
3785 2007-03-17 Marek Safar <marek.safar@gmail.com>
3787 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
3788 implementation flags.
3790 2007-03-17 Marek Safar <marek.safar@gmail.com>
3792 * class.cs: More optimizations for type parameters.
3794 2007-03-15 Marek Safar <marek.safar@gmail.com>
3796 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
3798 * ecore.cs, parameter.cs: More common code for both corlibs.
3800 * typemanager.cs (IsGenericMethod): Simplified.
3802 2007-03-15 Raja R Harinath <rharinath@novell.com>
3804 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3806 * statement.cs, iterators.cs, lambda.cs: Update to changes.
3808 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
3809 unconditionally. Simplify explanation.
3810 (Try.Resolve, Using.Resolve): Likewise.
3812 2007-03-15 Martin Baulig <martin@ximian.com>
3816 * decl.cs (DeclSpace): If we're a partial class, use our
3817 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
3819 2007-03-15 Raja R Harinath <rharinath@novell.com>
3821 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3823 (FlowBranching.UsageVector): Update to changes.
3824 (FlowBranching.MergeSiblings): Likewise.
3825 * statement.cs: Likewise.
3827 2007-03-15 Martin Baulig <martin@ximian.com>
3832 (MemberCache): Added a special .ctor for type parameters.
3835 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
3838 2007-03-09 Martin Baulig <martin@ximian.com>
3840 * enum.cs (Enum): Make this a TypeContainer.
3841 (EnumMember): Derive from `Const'.
3844 (Const.DoResolveValue): New protected virtual method; move most of
3845 the functionality of ResolveValue() here so we can override it in
3847 (Const.CreateConstantReference): Make this virtual.
3849 * class.cs (Kind): Add `Kind.Enum'.
3850 (TypeContainer.Emit): Don't emit the enums here; they're already
3851 in the `RootContext.typecontainer_resolve_order'.
3853 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
3854 here; they're already in the `typecontainer_resolve_order'.
3856 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3857 TypeManager.DropGenericTypeArguments().
3860 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3861 (TypeManager.IsEnumType): Likewise.
3862 (TypeManager.EnumToUnderlying): Likewise.
3863 (TypeManager.IsEqual): Add support for enums.
3865 2007-03-12 Raja R Harinath <rharinath@novell.com>
3867 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3868 DefaultParameterValueAttribute to be undefined, say if System.dll
3871 2007-03-11 Marek Safar <marek.safar@gmail.com>
3873 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3876 2007-03-10 Marek Safar <marek.safar@gmail.com>
3878 * class.cs, parameter.cs: Unified parameters verification.
3880 2007-03-08 Martin Baulig <martin@ximian.com>
3882 * cs-parser.jay (constructor_header): Pass the location to the
3883 newly created TopLevelBlock.
3885 2007-03-07 Martin Baulig <martin@ximian.com>
3887 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3889 2007-03-06 Miguel de Icaza <miguel@novell.com>
3891 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3892 with the changes from David, fixes the build.
3894 2007-03-05 David Mitchell <dmitchell@logos.com>
3896 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3897 and its base interfaces to a one-dimensional array type S[],
3898 provided there is an implicit or explicit reference conversion
3901 2007-03-03 Marek Safar <marek.safar@gmail.com>
3903 * cs-tokenizer.cs: Implemented basic linq grammar.
3905 * driver.cs: Set linq lang version on demand.
3907 2007-02-26 Marek Safar <marek.safar@gmail.com>
3909 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3911 2007-02-25 Marek Safar <marek.safar@gmail.com>
3913 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3916 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3918 Check property and event extern attributes.
3920 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3923 2007-02-24 Marek Safar <marek.safar@gmail.com>
3925 A fix for bug #80407
3926 * ecore.cs: Don't report ambiguity error when methods have same parent.
3928 2007-02-23 Marek Safar <marek.safar@gmail.com>
3930 A fix for bug #80878
3931 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3933 2007-02-22 Marek Safar <marek.safar@gmail.com>
3935 * attribute.cs: Enable ExtensionAttribute presence test.
3937 2007-02-22 Marek Safar <marek.safar@gmail.com>
3939 * class.cs: Warn about missing GetHashCode only when Equals is override.
3941 * decl.cs: Check accessibility of type arguments.
3943 * typemanager.cs: Correctly report nullable array.
3945 2007-02-20 Marek Safar <marek.safar@gmail.com>
3947 * class.cs, report.cs: Capture more details when things go wrong.
3949 2007-02-20 Marek Safar <marek.safar@gmail.com>
3951 A fix for bug #80650
3952 * cs-parser.jay: Anonymous container starts at constructor declaration
3953 and not at block beginning because it has to be usable in constructor
3956 * statement.cs: Use context location and not block one for error reporting.
3958 2007-02-18 Marek Safar <marek.safar@gmail.com>
3960 A fix for bug #78712
3961 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3964 2007-02-18 Marek Safar <marek.safar@gmail.com>
3966 A fix for bug #80493 by Atsushi Enomoto
3967 * cs-parser.jay: Ignore invalid attribute target.
3969 2007-02-18 Marek Safar <marek.safar@gmail.com>
3971 * cs-tokenizer.cs: Ignore '\0' as white space character.
3973 2007-02-17 Miguel de Icaza <miguel@novell.com>
3975 * cs-parser.jay: Add support for lambda expressions to the mcs
3978 * lambda.cs: Only clone when we are probing, not on the final call
3979 (Compatible is the final call).
3981 * statement.cs (CloneContext): Introduce class to provide block
3982 remapping during clone.
3984 All statements Clone themselves now.
3986 (Clone): special handling for blocks, when we clone a block, we
3987 register the block inside this routine, as children of the block
3988 might trigger a lookup.
3990 * expression.cs: Add support for CloneContext in all expressions.
3992 2007-02-17 Marek Safar <marek.safar@gmail.com>
3994 A fix for bug #80493
3995 * statement.cs: Report ambiguous warning when interfaces are not related.
3997 2007-02-15 Marek Safar <marek.safar@gmail.com>
3999 C# 3.0 extension methods.
4001 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
4002 cannot be used directly.
4004 * class.cs (Class.Emit): Emit extension attribute if any class method
4005 is extension method.
4006 (Method.Define): Add basic extension method validation conditions.
4007 (Method.Emit): Emit extension attribute for method.
4009 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
4010 extension method exists. Currently we follow same approach as Microsoft
4011 does, emit even if a method or a class are private but this can change
4014 * cs-parser.jay: Add handling of `this' keyword in method parameters
4017 * decl.cs (DeclSpace.IsStaticClass): New property.
4018 (MemberCache.FindExtensionMethods): Looks for extension methods with
4019 defined name and extension type.
4021 * doc.cs: Updated after OverloadResolve changes.
4023 * driver.cs: Add new soft reference to System.Core.dll.
4025 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
4026 (ExtensionMethodGroupExpr): Represents group of extension methods.
4028 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
4029 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
4030 to MethodGroupExpr and made non-static for easier customization.
4031 (Invocation.DoResolve): Add extension method lookup when no standard
4033 (MemberAccess.DoResolve): Try extension methods if no member exists.
4035 * modifiers.cs: Add METHOD_EXTENSION modifier.
4037 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
4038 as well as candidate extension type.
4039 (ComputeNamespaces): When assembly constains extension methods registers
4041 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
4042 extension method lookup.
4043 (Namespace.LookupExtensionMethod): Looks for extension method in this
4045 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
4046 find a method which matches name and extensionType.
4048 * parameter.cs (Parameter): Add This modifer.
4049 (HasExtensionMethodModifier): New property.
4050 (Resolve): Add extension parameter check.
4051 (ModFlags): turned to property to exclude this modifier as it is not real
4053 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
4055 * support.cs (ParameterData): Add ExtensionMethodType.
4056 (ReflectionParameters): Implemented ExtensionMethodType interface property.
4058 * typemanager.cs: Add type and ctor extension attribute type.
4060 2007-02-15 Miguel de Icaza <miguel@novell.com>
4062 * report.cs (DisableErrors, EnableErrors): used to prevent error
4063 output when we are "trying" to compile various methods with
4066 * ecore.cs (Expression): Add Clone method that calls the virtual
4067 CloneTo method. The current CloneTo method in Expression throws
4068 an exception so we can track down all the places where this must
4069 be implemented (not using abstract, because that would be a lot of
4070 up-front-work before we can start testing the implementation
4073 Important: we only need Clone capabilities for expressions created
4074 by the parser, as the expressions we will be cloning are
4075 expressions in the pre-resolved state. This vastly simplifies
4078 (SimpleName): Add CloneTo that does nothing.
4079 (EmptyCast): Add CloneTo.
4081 * expression.cs (Binary): Implement CloneTo.
4082 (Invocation.IsApplicable): Store the current ec in
4083 EmitContext.TempEc and restore it on return. This is used so we
4084 do not have to sprinkle hundres of methods with an extra
4085 EmitContext, we know that the only user is the lambda expression
4086 ImplicitConversionExists code.
4088 (Argument): Add Cloning capabilities.
4089 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
4090 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
4091 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
4092 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
4093 IndexerAccess): Add Clone capability.
4095 (LocalVariableReference, This): TODO: needs cloned Block mapping.
4097 (Argument): Add cloning capability.
4099 * assign.cs (Assign): Implement CloneTo.
4101 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
4103 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
4104 version by calling Convert with the EmitContext (that we are
4105 currently storing in ec, this is not great, but will do for now,
4106 to avoid passing EmitContext parameters to hundreds of functions
4107 that do not need them now).
4109 (SetExpression): Remove, it is not needed.
4111 (ContextualReturn): Implement CloneTo.
4113 * statement.cs (Statement): Implement cloning infrastructure,
4114 similar to expressions.
4116 (Block): Partial implementation of Clone for statements.
4118 (Return): Implement clone.
4120 * constant.cs (Constant.CloneTo): New method, does nothing.
4122 * codegen.cs (TempEc): Add a static EmitContext as a temporary
4123 solution, until we decide how to exactly do this.
4125 2007-02-14 Marek Safar <marek.safar@gmail.com>
4127 A fix for bug #80493
4128 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
4129 a property is override we need to use second accessor.
4131 2007-02-13 Marek Safar <marek.safar@gmail.com>
4133 A fix for bug #80418
4134 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
4137 2007-02-13 Marek Safar <marek.safar@gmail.com>
4139 Another fix for bug #80749
4140 * pending.cs: Abstract class has priority over interfaces.
4142 2007-02-13 Marek Safar <marek.safar@gmail.com>
4144 Another fix for bug #80749
4145 * pending.cs: Abstract class has priority over interfaces.
4147 2007-02-13 Marek Safar <marek.safar@gmail.com>
4149 Another fix for bug #80749
4150 * pending.cs: Abstract class has priority over interfaces.
4152 2007-02-13 Marek Safar <marek.safar@gmail.com>
4154 Another fix for bug #80749
4155 * pending.cs: Abstract class has priority over interfaces.
4157 2007-02-13 Marek Safar <marek.safar@gmail.com>
4159 * class.cs Better error message.
4161 * driver.cs: Add shorter versions of -optimize option.
4163 2007-02-13 Martin Baulig <martin@ximian.com>
4165 * class.cs (Constructor.Emit): Check the return value of
4166 ec.ResolveTopBlock() and return on error.
4168 2007-02-13 Raja R Harinath <rharinath@novell.com>
4170 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
4171 message to fix error message regression.
4173 2007-02-12 Marek Safar <marek.safar@gmail.com>
4175 * delegate.cs: Delegate creation expression cannot be of Nullable type.
4177 2007-02-12 Marek Safar <marek.safar@gmail.com>
4179 A fix for bug #80749
4180 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
4181 its parent container.
4183 * class.cs (DefineFieldInitializers): Each initializer can has different
4186 * const.cs: Updated.
4188 2007-02-11 Miguel de Icaza <miguel@novell.com>
4190 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
4191 now all the heavy lifting to check that embedded statements or
4192 expressions have the right form is done in the ContextualReturn.
4194 (ContextualReturn): New class.
4196 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
4197 method that can be invoked to report 201, so we do not replicate
4200 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
4202 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
4203 treating tabs as spaces.
4205 2007-02-09 Marek Safar <marek.safar@gmail.com>
4207 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
4208 * assign.cs: Use full implicit conversion for right side check.
4210 2007-02-09 Marek Safar <marek.safar@gmail.com>
4212 * statement.cs (Switch): Switch over boolean type is not standardized.
4214 2007-02-08 Marek Safar <marek.safar@gmail.com>
4216 A fix for bug #80755
4217 * decl.cs (FindBaseEvent): Don't use method cache for events.
4219 2007-02-07 Marek Safar <marek.safar@gmail.com>
4221 * cs-parser.jay: Better syntax error handling.
4223 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
4224 instead of underlying type value.
4226 2007-02-06 Marek Safar <marek.safar@gmail.com>
4228 * driver.cs: Check define identifier before is registered.
4230 * namespace.cs: Use existing error message.
4232 * report.cs: New warning.
4234 2007-02-06 Marek Safar <marek.safar@gmail.com>
4236 A fix for bug #80742
4237 * expression.cs: Delegate Invoke method can be called directly.
4239 2007-02-06 Marek Safar <marek.safar@gmail.com>
4241 A fix for bug #80676
4242 * class.cs (IsEntryPoint): The Main method can have params modifier.
4244 2007-02-04 Miguel de Icaza <miguel@novell.com>
4246 * parameter.cs (Parameter, Parameters): Add Clone method.
4248 * anonymous.cs (Compatible): Turn method into virtual method, so
4249 LambdaExpression can implement a different behavior.
4251 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
4252 out the basic checking here, so it can be used by
4255 * lambda.cs: Introduce "Compatible" function that will do the
4258 2007-02-02 Marek Safar <marek.safar@gmail.com>
4260 * attribute.cs: Unified one error message.
4262 * class.cs (Class): Use type attributes and not properties to test static
4264 (IsEntryPoint): Don's pass local variable.
4266 * convert.cs: Removed duplicate check.
4268 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
4270 * driver.cs: Don't crash when soft reference does not exist.
4272 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
4273 (UsingEntry): Removed redundant allocation.
4275 * parameter.cs: Add fast path for type parameters.
4277 * support.cs: Don't allocate attribute when it's not used.
4279 2007-01-30 Miguel de Icaza <miguel@novell.com>
4282 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
4283 this into a virtual method, so we can override it in LambdaExpression.
4285 * driver.cs: Improve diagnostics in case of failure.
4287 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
4288 write a function that is slightly more complex and that parses:
4290 type identifier [, type identifier]* )
4292 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
4295 (canEmpty ? i >= 0 : i > 0)
4297 2007-01-30 Raja R Harinath <rharinath@novell.com>
4299 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
4300 exception on possibly valid code.
4302 2007-01-29 Raja R Harinath <rharinath@novell.com>
4304 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
4306 (parse_opt_type_arguments): Remove. It's almost the same as
4308 (parse_namespace_or_typename): Use parse_less_than.
4310 2007-01-28 Miguel de Icaza <miguel@novell.com>
4312 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
4313 this bug took a few hours to find, because the state saved and
4314 restored by PushPosition and PopPosition was ignoring the state of
4315 parse_generic_less_than.
4317 I can also now remove the handling of OP_LT and OP_GT, this solves
4320 * cs-tokenizer.cs: store the location for the ARROW token, we use
4323 (PushPosition, PopPosition): save/restore also `current_token',
4324 restore `parse_generic_less_than' (was missing).
4326 (parse_opt_type_arguments): use parse_type, not
4327 parse_namespace_or_typename to parse types.
4329 * lambda.cs: Empty new file, will eventually have the lambda
4330 expression implementation.
4332 * lambda.test: used to test the internal tokenizer.
4334 * report.cs (FeatureIsNotISO1): Rename from
4335 FeatureIsNotStandardized, because it was about the language level
4336 (1 vs 2) it was not about standarization.
4338 (FeatureRequiresLINQ): New.
4340 * support.cs (SeekableStreamReader): Only require that the reader
4341 is a TextReader, not a StreamReader, so we can plug StringReader.
4343 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
4344 given position in the input stream the following tokens can be
4345 parsed as a type followed by an identifier.
4347 (is_punct): after a '(' if parse_type_and_parameter returns true,
4348 then return a special token OPEN_PARENS_LAMBDA which is used to
4349 avoid reduce/reduce errors in the grammar for the
4350 lambda_expression rules.
4352 (parse_type): implement a type parser inside the
4353 tokenizer, the parser only returns true or false depending on
4354 whether the input at a given position can be parsed as a type.
4356 (peek_token): new method used during type parsing.
4358 2007-01-28 Raja R Harinath <rharinath@novell.com>
4361 * anonymous.cs (ScopeInfo.InflateParameters): New.
4362 (AnonymousContainer.Resolve): Use it to redirect types of
4363 delegate parameters.
4365 2007-01-27 Raja R Harinath <rharinath@novell.com>
4368 * expression.cs (Error_InvalidArguments): Don't use two different
4369 messages for CS1503. Use ExtraInformation and
4370 SymbolRelatedToPreviousError instead.
4373 * decl.cs (DeclSpace.initialize_type_params): Don't access
4374 'type_params' of a partial class directly.
4376 2007-01-26 Miguel de Icaza <miguel@novell.com>
4378 * constant.cs: Removed a handful of out-of-range checks that were
4381 2007-01-25 Marek Safar <marek.safar@gmail.com>
4383 * expression.cs (CheckUselessComparison): Add additional check for char
4386 * namespace.cs: Fixed typo.
4388 2007-01-23 Miguel de Icaza <miguel@novell.com>
4390 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
4391 gone, instead we inline the test, preventing the needless casts to
4392 longs, ulongs and doubles for the parameters, avoiding calls to
4393 methods that overchecked stuff, and instead inlined things
4396 2007-01-20 Marek Safar <marek.safar@gmail.com>
4398 * cs-parser.jay: Better parameter error handling.
4400 2007-01-17 Marek Safar <marek.safar@gmail.com>
4402 A fix for bug #80368, #80522
4403 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
4404 whether array initializer contains constants only.
4405 (ArrayCreation.Emit): Use better formula to decide when
4406 are array initializers for static initialization.
4407 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
4408 have to emit even constants otherwise they are pre-initialized.
4410 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
4411 Raja R Harinath <rharinath@novell.com>
4413 Fix emit order of 'get' vs. 'set'.
4414 * support.cs (Accessors): New.
4415 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
4416 Note the order in which accessors are declared in the source.
4417 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
4418 Refactored from Property.Define and Indexer.Define.
4419 (PropertyBase.DefineAccessors): New helper that calls the above in
4420 appropriate order as noted by the parser.
4421 (Property.Define, Indexer.Define): Update to changes.
4422 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
4424 2007-01-17 Raja R Harinath <rharinath@novell.com>
4426 Fix cs0029-6.cs and gcs0029-2.cs (regression)
4427 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
4428 there's an implicit conversion from the current type to the target
4429 type before converting the underlying constant.
4431 2007-01-16 Marek Safar <marek.safar@gmail.com>
4433 * const.cs (ResolveValue): Updated after constant conversion was made more
4436 * constant.cs (GetAttributableValue): constant to object conversion is
4437 used for attributes only.
4438 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
4439 constant conversions.
4440 (LongConstant.ConvertImplicitly): Ditto.
4442 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
4443 (ImplicitConversionStandard): Handle constant conversion as extra step.
4444 It solves the issue when constant conversion was called indirectly like
4445 inside array initializer and constant folding was skipped.
4447 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
4450 * statement.cs(ImplicitConversionStandard): Updated after constant
4451 conversion was made more generic.
4453 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
4455 * expression.cs (As.DoResolve): Use GenericConstraints instead of
4456 Constraints, solves the problem where the compiler incorrectly
4457 reported that a type parameter was not constrained to a class (Bug
4460 2007-01-14 Marek Habersack <grendello@gmail.com>
4462 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
4464 2007-01-14 Marek Safar <marek.safar@gmail.com>
4466 A fix for bug #80368
4467 * assign.cs (FieldInitializer): New class implements field
4468 initializer statement.
4470 * attribute.cs: Update after FieldMember rename.
4472 * class.cs (PropertyBasedMember): New common class for property based
4474 (InterfaceMemberBase): New base class for all members which can be used as
4475 an interface members.
4476 (MethodCore): Moved really common code to InterfaceMemberBase.
4477 (Method.Define): Equal and GetHasCode detection is relevant for methods
4479 (MethodData.Define): Don't assume that public event implements an
4480 interface automatically.
4481 (MethodData.DefineMethodBuilder): Issue an error even if only extern
4483 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
4484 (FieldMember): Merged with FieldBase.
4485 (EventProperty.AEventPropertyAccessor): New specialization to check whether
4486 event extern modifier can be used.
4487 (EventField.EventFieldAccessor): Moved event field specific code here.
4488 (Event.AllowedModifiers): Even event can be extern.
4489 (Event.FindOutBaseMethod): New override specific to events.
4490 (Indexer.parameters): Reintroduce parameters because base class holds
4491 only properties common data.
4492 (Indexer.CheckForDuplications): Indexers are threated as methods so we
4493 need do extra parameters check.
4495 * const.cs: Update after FieldMember rename.
4497 * decl.cs (MemberCache.FindBaseEvent): New method.
4499 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
4500 to reflect that indexer is now derived from PropertyBased.
4502 * ecore.cs (GetMemberType): Made public.
4503 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
4506 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
4508 * typemanager.cs (CSharpSignature): Correctly print event accessors.
4509 (RegisterEvent): Removed.
4510 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
4511 (GetPrivateFieldOfEvent): Renamed to GetEventField.
4513 2007-01-11 Raja R Harinath <rharinath@novell.com>
4516 * statement.cs (CollectionForeach.TryType): Prefer generic
4517 GetEnumerator over non-generic variant. Fix code to follow comments.
4519 2007-01-09 Raja R Harinath <rharinath@novell.com>
4522 * support.cs (ReflectionParameter): Don't use an invalid index on
4523 the generic parameter data.
4525 2007-01-08 Miguel de Icaza <miguel@novell.com>
4527 * driver.cs: Just add a tiny bit of infrastructure.
4529 2007-01-02 Marek Safar <marek.safar@gmail.com>
4531 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
4532 where field type is struct from current assembly.
4534 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
4537 2007-01-02 Marek Safar <marek.safar@gmail.com>
4539 A fix for bug #80381
4540 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
4543 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
4545 (Namespace.LookupType): Always use core types from corlib when speficied.
4547 * report.cs: A new warning.
4549 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
4550 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
4551 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
4553 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
4554 (InitCoreTypes): Set expression type of object_type and value_type
4555 immediately after lookup.
4557 2007-01-01 Miguel de Icaza <miguel@novell.com>
4559 * cs-tokenizer.cs: Accept Pc class characters (Connector
4560 Punctuation) as valid identifiers. Fixes #78259
4562 * expression.cs (Invocation.DoResolve): Moved the check for the
4563 use of `this' for doing method calls to the Invocation resolution
4564 step, after overload resolution has taken place instead of doing
4565 the check at the low-level `This.DoResolve' level.
4567 The `This.DoResolve'(appens before overload resolution, so it has
4568 no way of knowing if the method that will be called will be
4569 instace or static, triggering an erroneous report for cs0188 (Bug
4572 We now do the check for instance method invocations after we know
4573 what method will be called.
4575 (This.CheckThisUsage): Move the actual use of this structure
4576 checking into its own method and expose it.
4578 * Everywhere that called Error_ValueCannotBeConverted: pass a new
4581 Exceptions: Null.ConvertImplicitly,
4582 Constant.ImplicitConversionRequired as there are too many call
4583 sites for passing the ec.
4585 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
4586 EmitContext, if the value is null, then we do not try to provide
4587 the extra information from the error (If a userdefined conversion
4588 exists, as UserDefinedConversion requires a non null-EmitContext).
4592 2006-12-30 Raja R Harinath <rharinath@novell.com>
4594 * flowanalysis.cs (MyBitVector): Document some invariants.
4595 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
4596 introduced below, and add a couple of others,
4598 2006-12-30 Marek Safar <marek.safar@gmail.com>
4600 * attribute.cs (GetMethodObsoleteAttribute): Uses new
4601 GetPropertyFromAccessor and GetEventFromAccessor.
4603 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
4604 overrides non-obsolete one.
4605 (Indexer.Define): Error message has been moved to the parser.
4607 * cs-parser.jay: Better syntax errors handling.
4609 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
4610 when an invocation has no arguments.
4612 * ecore.cs: Removed not used caching.
4614 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
4617 * report.cs: Add a new warning.
4619 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
4621 * typemanager.cs (enumeration_type): Removed.
4622 (CSharpSignature): Reuses IsSpecialMethod.
4623 (IsEqual): Hack for MS BCL.
4624 (GetPropertyFromAccessor): New method.
4625 (GetEventFromAccessor): New method.
4626 (IsSpecialMethod): Fixed to handle more cases.
4628 2006-12-30 Marek Safar <marek.safar@gmail.com>
4630 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
4631 Made white spaces array static.
4633 * ecore.cs (RemoveGenericArity): Optimized.
4635 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
4637 (MyBitVector.initialize_vector): Simplified.
4639 2006-12-22 Miguel de Icaza <miguel@novell.com>
4641 * ecore.cs: Am not entirely happy with this hack, but it seems to
4642 address the issue in 80257 (a small test case for
4645 I set the MethodGroupExpr.Type to an internal compiler type
4646 (itself in this case) to force the resolution to take place. Why
4647 it does not take place with a null is beyond me.
4649 2006-12-20 Marek Safar <marek.safar@gmail.com>
4651 A fix for bug #80288
4652 * expression.cs (ResolveOperator): Consider user defined conversion for
4653 logical and operator too.
4654 (EmitBranchable): Optimization for logical and when full constant folding
4655 could not be applied but one operand is constant.
4657 2006-12-19 Marek Safar <marek.safar@gmail.com>
4659 * class.cs (GetClassBases): Write 5 times every day, will never use
4660 FullName for error reporting.
4662 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
4664 2006-12-19 Martin Baulig <martin@ximian.com>
4666 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
4667 the symbol file info here.
4669 2006-12-18 Marek Safar <marek.safar@gmail.com>
4671 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
4672 of `elseif' is taking then following sections are not taking.
4673 Fixes an issue reported on mono mailing list.
4675 2006-12-18 Marek Safar <marek.safar@gmail.com>
4677 A fix for bug #80300
4678 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
4679 a caller is not taking.
4681 2006-12-18 Raja R Harinath <rharinath@novell.com>
4683 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
4684 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
4685 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
4686 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
4687 * class.cs: Update to changes.
4689 2006-12-17 Marek Safar <marek.safar@gmail.com>
4691 A fix for bug #79934
4692 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
4695 * class.cs (ResolveMembers): Register an iterator in current container and
4698 2006-12-16 Raja R Harinath <rharinath@novell.com>
4701 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
4702 satisfy a params annotated parameter.
4704 2006-12-16 Marek Safar <marek.safar@gmail.com>
4706 A fix for bug #77014
4707 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
4708 paramters correctly and not rely on hacks in Parameters class.
4709 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
4711 (Invocation.VerifyArgumentsCompat): Ditto.
4712 (Invocation.EmitArguments): Changed to correctly emit params arguments at
4715 * parameter.cs (HasParams): Don't assume that params is the last one.
4717 * support.cs (ReflectionParameters.ctor): Look for params attribute
4719 (ReflectionParameters.ParameterType): Removed hack when we returned last
4720 parameter for out of range parameters.
4721 (ParameterName, ParameterModifier): Ditto.
4723 2006-12-14 Marek Safar <marek.safar@gmail.com>
4725 A fix for bug #79987
4726 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
4727 when assembly is not CLS compliant but type is. I have no idea why is this
4730 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
4732 2006-12-13 Miguel de Icaza <miguel@novell.com>
4734 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
4735 in struct constructors, they are basically no-ops.
4737 2006-12-12 Marek Safar <marek.safar@gmail.com>
4739 * cs-tokenizer.cs (Position): Save preprocessor status too.
4741 2006-12-12 Marek Safar <marek.safar@gmail.com>
4743 A fix for bug #77794
4744 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
4746 2006-12-12 Marek Safar <marek.safar@gmail.com>
4748 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
4750 (pp_expr): Report error for an invalid expression.
4751 (handle_preprocessing_directive): Simplified; add more error checking.
4753 2006-12-11 Marek Safar <marek.safar@gmail.com>
4755 A fix for bug #74939
4756 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
4757 directives handling.
4759 2006-12-10 Marek Safar <marek.safar@gmail.com>
4761 A fix for bugs #80093, and #75984
4762 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
4763 logic, it seems to me as it worked before "by coincidence".
4764 (xtoken): Simplified to use reworked handle_preprocessing_directive.
4765 (cleanup): Enabled endif check.
4767 2006-12-09 Marek Safar <marek.safar@gmail.com>
4769 A fix for bug #80162
4770 * statement.cs (CollectionForeach.TryType): Generics and non-generics
4771 enumerators are never ambiguous.
4773 2006-12-08 Raja R Harinath <rharinath@novell.com>
4776 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
4778 2006-12-06 Marek Safar <marek.safar@gmail.com>
4780 A fix for bug #80144
4781 * class.cs (EventProperty.Define): Explicit implementation means
4782 that an even is used.
4784 2006-12-06 Marek Safar <marek.safar@gmail.com>
4786 Fixes the operators implementation (part II)
4788 * cfold.cs (DoConstantNumericPromotions): Renamed to
4789 DoBinaryNumericPromotions and simplified.
4790 (BinaryFold): Couple of conversion fixes; simplified.
4792 * constant.cs, ecore.cs, literal.cs
4793 (ToType): Renamed to ConvertImplicitly.
4794 (Reduce): Renamed to ConvertExplicitly.
4796 * class.cs, convert.cs: Updated.
4798 * expression.cs: TryReduce doesn't throw an exception.
4800 2006-12-01 Marek Safar <marek.safar@gmail.com>
4802 A fix for bug #80108
4803 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
4806 2006-11-30 Marek Safar <marek.safar@gmail.com>
4808 Fixes unary operators implementation (part I)
4811 * cfold.cs (Error_CompileTimeOverflow): Made internal
4813 * const.cs (IConstant): Changed to use reference to constant and
4814 not constant itself.
4815 Updated IConstant implementations.
4817 * constant.cs (CreateConstant): New factory method.
4818 Updated IConstant implementation.
4820 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
4822 * ecore.cs: Updated to use CreateConstantReference.
4824 * enum.cs: Reflects IConstant changes.
4826 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
4828 * literal.cs (NullConstant): Change to be independently usable.
4830 2006-11-29 Martin Baulig <martin@ximian.com>
4832 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
4833 we need to emit the scope initializer before calling the base .ctor.
4835 * anonymous.cs: Merged back from the new anonymous methods branch.
4836 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
4838 * expression.cs (ParameterReference.DoResolveBase): Create a
4839 "normal" ScopeInfo when capturing parameters rather than using the
4840 root scope; this makes things work with anonymous methods having
4844 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
4846 2006-11-22 Marek Safar <marek.safar@gmail.com>
4848 A fix for bug #79987
4849 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
4850 check to a base class.
4851 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
4852 only when assembly has missing attribute.
4853 * report.cs: Update.
4855 2006-11-21 Marek Safar <marek.safar@gmail.com>
4857 * cs-tokenizer.cs: Merged with gmcs version.
4859 2006-11-20 Marek Safar <marek.safar@gmail.com>
4862 * cs-parser.jay: Better error message when partial keyword is misplaced.
4864 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4866 A fix for bug #79810
4867 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4868 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4869 a RuntimeWrappedException by default.
4871 2006-11-18 Marek Safar <marek.safar@gmail.com>
4873 A fix for bug #79843
4874 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4876 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4878 2006-11-18 Marek Safar <marek.safar@gmail.com>
4880 * driver.cs, namespace.cs: Uses faster IndexOf version.
4882 2006-11-17 Marek Safar <marek.safar@gmail.com>
4884 A fix for bug #79941
4885 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4887 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4888 even if internal name is different.
4889 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4890 (UserDefinedConversion): Simplified as the operators cannot be internal.
4891 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4893 (MethodLookup): Replaced EmitContext with parentType.
4894 * expression.cs: Updated.
4896 2006-11-09 Raja R Harinath <rharinath@novell.com>
4898 * driver.cs (BadAssembly): Handle all the ugliness of
4899 DefineDynamicAssembly.
4901 2006-11-08 Raja R Harinath <rharinath@novell.com>
4903 Address parts of #58244 -- most of what's left is in the runtime
4904 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4905 CS1509 error checks, and handle them for all assembly loads, not
4906 just the first invocation.
4907 (LoadModule): Likewise. Move handling of 'adder_method' ...
4908 * codegen.cs (AssemblyClass.AddModule): ... here.
4910 2006-11-02 Marek Safar <marek.safar@gmail.com>
4912 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4913 IEnumerable<T> is ambiguous.
4915 2006-10-31 Marek Safar <marek.safar@gmail.com>
4917 A fix for bug #67689
4918 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4919 GetEnumerator is ambiguous.
4921 * report.cs: Add new warning.
4923 2006-10-29 Marek Safar <marek.safar@gmail.com>
4925 A fix for bug #78602
4926 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4927 to protected member can be nested type.
4929 2006-10-28 Marek Safar <marek.safar@gmail.com>
4931 A fix for bug #78965
4932 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4933 to protected member must derive from current type.
4935 2006-10-27 Marek Safar <marek.safar@gmail.com>
4937 assign.cs: Reuses error method.
4939 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4940 instead of type for constants.
4941 (Expression.Error_ValueAssignment): Common error method.
4943 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4946 2006-10-27 Marek Safar <marek.safar@gmail.com>
4948 A fix for bug #79081
4949 * expression.cs (MemberAccess.DoResolve): Check nested type
4952 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4954 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4956 2006-10-26 Marek Safar <marek.safar@gmail.com>
4958 A fix for bug #76591
4959 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4961 2006-10-26 Marek Safar <marek.safar@gmail.com>
4963 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4964 type forwarder of the same type multiple times.
4966 2006-10-26 Raja R Harinath <rharinath@novell.com>
4969 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4970 instance as an rvalue, even when we later resolve as an lvalue.
4972 2006-10-25 Martin Baulig <martin@ximian.com>
4974 * anonymous.cs: Fix #79673.
4976 2006-10-24 Marek Safar <marek.safar@seznam.cz>
4978 A fix for bug #79666
4979 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
4980 ignored when is optimized (= default value) as its value is already set.
4982 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4984 A fix for bug #79724
4985 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
4986 TypeContainer for type lookup.
4988 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4990 A fix for bug #79231
4991 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
4992 * expression.cs (OverloadResolve): Always convert type name for
4994 (ResolveNamespaceOrType): Don't confuse a nested type with any
4997 2006-10-18 Martin Baulig <martin@ximian.com>
4999 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
5001 2006-10-17 Miguel de Icaza <miguel@novell.com>
5003 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
5004 an int32, but requesting an int64 from the conversion
5006 2006-10-12 Martin Baulig <martin@ximian.com>
5009 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
5011 2006-10-12 Martin Baulig <martin@ximian.com>
5014 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
5016 2006-10-11 Miguel de Icaza <miguel@novell.com>
5018 * convert.cs: Remove broken code: I was doing the "Existance"
5019 tests for Implicit conversions.
5021 2006-10-10 Miguel de Icaza <miguel@novell.com>
5023 * convert.cs: Added one missing case in
5024 ImplicitStandardConversionExists uint64 to intptr.
5028 * typemanager.cs (uintptr_type): another core known type.
5030 * ecore.cs (OperatorCast): routine used to do cast operations that
5031 depend on op_Explicit. We could change some of the Decimal
5032 conversions to use this.
5034 This one has a probe mechanism that checks both types for an op_
5035 which it coudl be used to eliminate two classes: CastToDecimal
5036 and CastFromDecimal.
5038 * convert.cs: Implement the conversions documented in #59800
5040 2006-10-10 Martin Baulig <martin@ximian.com>
5042 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
5043 before RootScope.ResolveMembers().
5045 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
5046 `CurrentType' if appropriate.
5048 2006-10-09 Marek Safar <marek.safar@seznam.cz>
5050 A fix for bug #78568
5051 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
5052 when contains binary operators.
5053 * cs-parser.jay: Updated.
5055 2006-10-09 Martin Baulig <martin@ximian.com>
5058 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
5059 moved that into Define() and also do the other type parameter
5060 checks there. Fixes #79094. Added gtest-292.cs.
5063 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
5064 since that doesn't include type parameters; don't use `Ldelema'
5065 for type parameters. Fixes #78980. Added gtest-293.cs.
5067 2006-10-08 Marek Safar <marek.safar@seznam.cz>
5070 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
5071 conversion is allowed.
5073 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5075 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
5076 error reporting when no error occurs.
5078 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5080 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
5083 2006-10-06 Raja R Harinath <rharinath@novell.com>
5086 * class.cs (DefineTypeBuilder): Check circular dependencies before
5087 setting the parent of the TypeBuilder.
5088 (CheckRecursiveDefinition): Don't use 'BaseType', since
5089 it may not be valid until after DefineTypeBuilder. Use
5090 'base_type' instead.
5092 2006-10-04 Martin Baulig <martin@ximian.com>
5094 Merged the Anonymous Methods patch.
5096 * anonymous.cs, iterators.cs: The new anonymous methods code.
5098 * statement.cs (Variable): New public abstract class.
5099 (LocalInfo.Variable): New public property.
5100 (LocalInfo.ResolveVariable): New public method.
5101 (Block.Flags): Add `IsIterator'.
5102 (Block.AddVariable): Improved the CS0136 check.
5103 (Block.AnonymousChildren): New public property.
5104 (Block.AddAnonymousChild): New public method.
5105 (ToplevelBlock): Update to use the new anonymous method framework.
5106 (ToplevelBlock.ctor): `container' is now a `Block' and not a
5107 `ToplevelBlock'; this is required to correctly implement the
5109 (Fixed, Using): Use `TemporaryVariable' instead of directly
5110 creating the `LocalBuilder'.
5112 * parameter.cs (Parameter.ResolveVariable): New public method.
5113 (Parameters.ResolveVariable): Likewise.
5115 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
5117 * class.cs (TypeContainer): Replaced the `iterators' list and
5118 corresponding methods with a list of `CompilerGeneratedClass'es.
5119 (TypeContainer.ResolveMembers): New public method.
5120 (Method): `IIteratorContainer' has been replaced by
5123 * expression.cs (VariableReference): New public abstract base
5124 class for `LocalVariableReference', `ParameterReference' and
5127 * codegen.cs (EmitContext): Removed `capture_context',
5128 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
5129 (EmitContext.EmitThis): Removed.
5131 * cs-parser.jay: Replace `iterator_container' with
5134 2006-10-04 Martin Baulig <martin@ximian.com>
5136 * generic.cs (GenericMethod): Don't make this abstract.
5137 (Constraints.Clone): Added dummy implementation.
5139 2006-10-04 Raja R Harinath <harinath@gmail.com>
5142 * namespace.cs (LookForAnyGenericType): Avoid nullref on
5143 'declspaces'. Avoid allocating arrays willy-nilly.
5146 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
5147 cases out of the switch.
5149 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5151 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
5152 message when non-generic type is used with the type arguments.
5153 * expression.cs: Updated.
5155 2006-09-28 Raja R Harinath <rharinath@novell.com>
5158 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
5159 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5160 Change semantics slightly. Don't insist on having only one
5161 temporary EmptyExpression -- just throttle the creation of new ones.
5164 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
5165 non-interfaces too. If no methods are found, don't try to create
5168 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5170 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
5173 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
5174 us produce better error message.
5176 2006-09-27 Marek Safar <marek.safar@seznam.cz>
5178 * expression.cs (Binary.ResolveOperator): Warn about a side effect
5179 of the `|' operator.
5181 * report.cs: A new warning added.
5183 2006-09-27 Martin Baulig <martin@ximian.com>
5185 * generic.cs (GenericMethod): Don't make this abstract.
5187 2006-09-27 Martin Baulig <martin@ximian.com>
5190 (InternalErrorException): Added overloaded ctor taking a params array.
5192 2006-09-26 Marek Safar <marek.safar@seznam.cz>
5194 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
5195 Fixed the cases when same error was reported twice.
5197 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
5198 now report symbol information.
5200 2006-09-25 Martin Baulig <martin@ximian.com>
5202 * class.cs: Completely unified with the gmcs version.
5204 2006-09-25 Martin Baulig <martin@ximian.com>
5206 * typemanager.cs (TypeManager.IsNullableType): New public function.
5207 (TypeManager.IsNullableTypeOf): Likewise.
5208 (TypeManager.IsNullableValueType): Likewise.
5210 * class.cs (MethodCore): Added the `GenericMethod' argument from
5211 gmcs and also unified all classes derived from `MethodCore' with gmcs.
5213 2006-09-24 Raja R Harinath <harinath@gmail.com>
5215 * convert.cs: Unify with gmcs version.
5217 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5219 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
5220 verify them as well.
5222 * report.cs: New warning.
5224 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5226 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
5227 for anonymous block with out argument.
5229 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5231 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
5232 not used private events only.
5234 2006-09-23 Marek Safar <marek.safar@seznam.cz>
5236 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
5238 * const.cs (Const.Define): Check for constant type.
5239 (Const.IsConstantTypeValid): Looks for valid constant types.
5241 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
5243 * ecore.cs (EmptyConstantCast): New common class for all constant based
5246 * expression.cs (Is.DoResolve): Handle null constant especially.
5247 (New.DoResolve): Check for new void().
5248 (MemberAccess.DoResolve): Cope with all kind of nulls.
5250 * literal.cs (NullConstant): Uses EmptyConstantCast.
5251 (NullDefault): Based on EmptyConstantCast.
5252 (NullLiteral): Uses EmptyConstantCast.
5254 * statement.cs (Block.ResolveMeta): Check for constant type.
5256 2006-09-22 Martin Baulig <martin@ximian.com>
5258 * delegate.cs, attribute.cs: Merged with the gmcs versions.
5260 2006-09-22 Raja R Harinath <rharinath@novell.com>
5262 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
5266 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
5267 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
5270 2006-09-22 Martin Baulig <martin@ximian.com>
5272 * ecore.cs: Merged with the gmcs version.
5274 * generic.cs (ConstructedType): New dummy class.
5275 (TypeArguments): Don't make this abstract.
5278 (TypeManager.IsGenericTypeDefinition): New method.
5279 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
5281 2006-09-22 Raja R Harinath <rharinath@novell.com>
5283 * expression.cs (ComposedCast): Check for arrays of TypedReference
5284 before creating the type, not after.
5286 2006-09-21 Marek Safar <marek.safar@seznam.cz>
5288 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
5289 after ToType change.
5291 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
5292 when constant must be implicitly convertible.
5294 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
5296 * ecore.cs (NullCast): Derives from NullConstant.
5298 * expression.cs (Is.DoResolve): Removed useless variables.
5299 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
5300 (New.Constantify): Add enum support.
5301 (MemberAccess.DoResolve): Add warning when accessing null constant or
5304 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
5307 * literal.cs (NullConstant): New abstract class with common
5308 functionality for all null specializations.
5309 (NullDefault): Represents default(X) when result can be
5311 (NullLiteral): Updated.
5313 * report.cs: Add new warning.
5315 2006-09-21 Martin Baulig <martin@ximian.com>
5317 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
5319 2006-09-21 Martin Baulig <martin@ximian.com>
5321 * generic.cs (GenericConstraints): New dummy class.
5322 (Constraints): Likewise.
5323 (TypeParameter): Likewise.
5324 (TypeParameterName): Likewise.
5325 (GenericMethod): Likewise.
5327 * typemanager.cs (TypeManager.GetGenericArguments): New method.
5329 * decl.cs: Merged with the gmcs version.
5331 2006-09-21 Raja R Harinath <rharinath@novell.com>
5333 * generic.cs (TypeParameter): Implement IMemberContainer.
5334 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
5336 * rootcontext.cs: Unify with gmcs version.
5338 * report.cs: Unify with gmcs version.
5339 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
5340 from gmcs/generics.cs.
5341 * generics.cs (TypeParameter): New dummy class.
5343 * support.cs: Unify with gmcs version.
5345 2006-09-20 Raja R Harinath <rharinath@novell.com>
5347 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
5348 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
5350 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
5351 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
5352 * mcs.exe.sources: Add generic.cs.
5354 * codegen.cs: Unify with gmcs version.
5356 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
5357 (EmitContext): Add GenericDeclContainer implementation.
5358 * decl.cs (MemberCore, DeclSpace): Likewise.
5359 * namespace.cs: Remove #ifdef GMCS_SOURCE.
5361 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
5362 MCS TypeManager has a corresponding dummy method.
5364 2006-09-19 Martin Baulig <martin@ximian.com>
5366 * expression.cs: Completely merged with the gmcs version.
5368 2006-09-19 Martin Baulig <martin@ximian.com>
5370 * expression.cs (Invocation): Merged with the gmcs version.
5371 (ArrayAccess.GetStoreOpcode): Likewise.
5373 2006-09-19 Martin Baulig <martin@ximian.com>
5376 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
5377 (TypeManager.IsGenericMethodDefinition): Likewise.
5379 2006-09-19 Martin Baulig <martin@ximian.com>
5382 (TypeManager.IsEqual): Moved the gmcs implementation here.
5383 (TypeManager.DropGenericTypeArguments): Likewise.
5384 (TypeManager.DropGenericMethodArguments): Likewise.
5385 (TypeManager.GetTypeArguments): Moved here from gmcs.
5386 (TypeManager.HasGenericArguments): Likewise.
5388 2006-09-19 Martin Baulig <martin@ximian.com>
5390 * expression.cs (Binary): Merged with the gmcs version.
5392 2006-09-19 Martin Baulig <martin@ximian.com>
5394 * expression.cs (Probe, As, Is): Merged with the gmcs version.
5396 2006-09-19 Martin Baulig <martin@ximian.com>
5398 * typemanager.cs: Merged with the gmcs version.
5400 2006-09-16 Raja R Harinath <rharinath@novell.com>
5402 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
5403 * driver.cs: Likewise.
5405 2006-09-16 Marek Safar <marek.safar@seznam.cz>
5408 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
5409 only if parent type is class.
5410 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
5413 2006-09-15 Marek Safar <marek.safar@seznam.cz>
5416 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
5418 * typemanager.cs(CSharpName): Converts NullType to null.
5420 2006-09-15 Martin Baulig <martin@ximian.com>
5423 (TypeManager.GetMethodName): Added mcs implementation.
5424 (TypeManager.IsEqual): Likewise.
5427 (SimpleName.RemoveGenericArity): Added dummy implementation.
5429 * pending.cs: Merged with the gmcs version.
5431 2006-09-15 Martin Baulig <martin@ximian.com>
5433 * statement.cs: Merge with the gmcs version.
5435 2006-09-15 Martin Baulig <martin@ximian.com>
5437 * statement.cs (Switch): Merge with the gmcs implementation
5438 (without nullables), which is newer.
5440 2006-09-15 Martin Baulig <martin@ximian.com>
5442 * statement.cs (Block.Variables): Make this public.
5443 (ToplevelBlock.Parameters): Make this a property.
5444 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
5446 2006-09-15 Martin Baulig <martin@ximian.com>
5448 * namespace.cs: Merge with the gmcs version.
5450 2006-09-15 Martin Baulig <martin@ximian.com>
5452 * decl.cs (MemberName): Minor code cleanups.
5454 2006-09-15 Martin Baulig <martin@ximian.com>
5456 * parameter.cs: Merge with the gmcs version.
5458 2006-09-15 Martin Baulig <martin@ximian.com>
5460 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
5461 and an error in mcs.
5463 2006-09-15 Martin Baulig <martin@ximian.com>
5465 * flowanalysis.cs: Merged from GMCS; added the generics code into
5466 a `GMCS_SOURCE' conditional so we can share this file.
5468 2006-09-08 Martin Baulig <martin@ximian.com>
5470 * typemanager.cs (TypeManager.interlocked_type): New public field.
5471 (TypeManager.int_interlocked_compare-exchange): New public field.
5472 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
5473 enumerator types here and call InitGenericCoreTypes().
5474 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
5475 after calling InitEnumUnderlyingTypes().
5478 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
5479 `classes_second_stage'.
5481 2006-09-14 Marek Safar <marek.safar@seznam.cz>
5483 * assign.cs, ecore.cs, expression.cs: Share error message text.
5484 * class.cs (FieldMember.Define): Check for varible of static type.
5485 * driver.cs (LoadAssembly): Uses error output for errors.
5486 * statement.cs: Updated.
5488 2006-09-08 Marek Safar <marek.safar@seznam.cz>
5490 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
5493 2006-09-07 Martin Baulig <martin@ximian.com>
5496 (MainDriver): Revert r62663 from Marek; see #70506 for details.
5498 2006-08-29 Miguel de Icaza <miguel@novell.com>
5500 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
5502 2006-08-17 Miguel de Icaza <miguel@novell.com>
5504 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
5505 #52019 and #79064, the use of the \uXXXX sequence in source code
5506 to represent unicode characters.
5508 2006-08-15 Marek Safar <marek.safar@seznam.cz>
5510 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
5512 * class.cs, ecore.cs, statement.cs: Merged to one error message.
5514 2006-08-13 Miguel de Icaza <miguel@novell.com>
5516 * assign.cs: Catch attempts to assign to a method groups in += and
5519 2006-08-13 Marek Safar <marek.safar@seznam.cz>
5522 * cs-parser.jay: Don't destroy current array type by typeof of array's.
5524 2006-08-12 Marek Safar <marek.safar@seznam.cz>
5526 * class.cs (Method.Define): Issue a warning when generic method looks like
5528 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
5531 2006-08-09 Marek Safar <marek.safar@seznam.cz>
5533 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
5535 * decl.cs (MemberCache.FindMembers): When container is interface we need to
5536 search all base interfaces as a member can be ambiguous.
5537 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
5538 Constructor member type filter.
5539 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
5540 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
5541 reporting for returned memberinfos.
5542 * report.cs: Updated.
5543 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
5544 version to work on all runtimes.
5545 (TypeManager.RealMemberLookup): Removed members filtering.
5547 2006-08-08 Raja R Harinath <rharinath@novell.com>
5549 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
5550 (PropertyExpr.EmitAssign): Likewise.
5551 * expression.cs (Indirection.EmitAssign): Likewise.
5552 (LocalVariableReference.EmitAssign): Likewise.
5553 (ParameterReference.EmitAssign): Likewise.
5554 (Invocation.EmitArguments): Likewise.
5555 (ArrayAccess.EmitAssign): Likewise.
5556 (IndexerAccess.EmitAssign): Likewise.
5557 (This.EmitAssign): Likewise.
5558 (ConditionalLogicalOperator.Emit): Likewise.
5561 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
5562 instead of ArrayList. If the hashtable has a LocalBuilder, don't
5563 leave it in after returning it.
5564 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
5566 2006-08-06 Marek Safar <marek.safar@seznam.cz>
5568 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
5571 2006-08-03 Raja R Harinath <rharinath@novell.com>
5573 Fix cs0146-3.cs and cs0146-4.cs.
5574 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
5575 enclosing types don't depend on the current type.
5577 2006-08-02 Raja R Harinath <rharinath@novell.com>
5580 * class.cs (TypeContainer.DoDefineMembers): Use
5581 FindBaseMemberWithSameName on Parent, since we're interested in
5582 whether we hide inherited members or not.
5583 (FindBaseMemberWithSameName): Make slightly more robust.
5585 Fix the non-generic testcase from #77396
5586 * decl.cs (DeclSpace.DeclContainer): Remove override.
5588 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
5589 declspaces for doppelgangers too.
5590 (UsingEntry): Implement IResolveContext.
5591 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
5592 'this' as the resolve context.
5593 (LocalAliasEntry): Likewise.
5595 Implement parts of #77403
5596 * roottypes.cs (RootDeclSpace): New. Used to represent the
5597 toplevel declaration space. Each namespace declaration introduces
5598 a "partial" root declaretion space.
5599 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
5600 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
5601 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
5602 from 'current_namespace.SlaveDeclSpace'.
5603 (namespace_declaration): Likewise.
5604 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
5605 check. It can't happen now.
5606 * decl.cs (DeclSpace.LookupType): Likewise.
5607 * driver.cs (MainDriver): Sanity check.
5609 2006-08-01 Raja R Harinath <rharinath@novell.com>
5611 * decl.cs (DeclSpace.FindNestedType): Remove.
5612 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
5613 LookupTypeContainer to get the container of the nested type.
5614 * class.cs (TypeContainer.FindNestedType): Make non-override.
5616 2006-07-31 Raja R Harinath <rharinath@novell.com>
5618 * decl.cs (DeclSpace.PartialContainer): Move field from ...
5619 * class.cs (TypeContainer.PartialContainer): ... here.
5620 (TypeContainer.AddBasesForPart): New helper.
5621 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
5623 * cs-parser.jay (current_class): Convert to DeclSpace.
5624 (struct_declaration, interface_declaration, class_declaration):
5625 Use AddBasesForPart instead of .Bases directly.
5626 * const.cs, iterators.cs: Update to changes.
5628 2006-07-28 Raja R Harinath <rharinath@novell.com>
5630 * class.cs (TypeContainer.AddMemberType): Rename from
5632 (TypeContainer.AddMember): Rename from AddToMemberContainer.
5633 (AddTypeContainer): New. Combine AddClassOrStruct and
5635 (AddPartial): Update. Add 'is_partial' argument.
5636 * roottypes.cs: Update to changes.
5637 * cs-parser.jay (push_current_class): New helper for handling
5638 current_container and current_class.
5639 (struct_declaration, interface_declaration, class_declaration):
5642 2006-07-26 Raja R Harinath <rharinath@novell.com>
5644 * roottypes.cs: Rename from tree.cs.
5646 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
5647 * tree.cs (Tree, ITreeDump): Remove types.
5648 * rootcontext.cs (tree, Tree): Remove fields.
5649 (root, ToplevelTypes): New.
5650 * *.cs: Update to rename.
5652 * tree.cs (Tree.RecordDecl): Remove.
5653 (RootTypes.AddToTypeContainer): Record the toplevel type in its
5655 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
5657 2006-07-23 Raja R Harinath <harinath@gmail.com>
5659 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
5660 DoFlowAnalysis and OmitStructFlowAnalysis here.
5661 (ec.With): Rename from WithUnsafe and generalize.
5662 (ec.WithCheckState): Remove. All users can be handled by 'With'.
5663 (ec.WithFlowAnalyis): New.
5664 * ecore.cs, expression.cs, statement.cs: Update.
5666 2006-07-22 Raja R Harinath <harinath@gmail.com>
5668 * statement.cs (Block.ResolveMeta): Simplify slightly.
5670 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
5671 multiple boolean fields. Convert InUnsafe, constant_check_state,
5672 check_state to flags.
5673 (CheckState, ConstantCheckState): Update.
5674 (InUnsafe): New read-only property.
5675 (FlagsHandle): Rename from CheckStateHandle and convert to handle
5677 (WithUnsafe): New helper similar to WithCheckState.
5678 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
5679 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
5681 2006-07-21 Raja R Harinath <rharinath@novell.com>
5683 Make comparisons use the same IL irrespective of whether they're
5684 in a 'checked' or 'unchecked' context: one of the issues in #78899
5685 * codegen.cs (EmitContext.CheckState): Make read-only property.
5686 (EmitContext.ConstantCheckState): Likewise.
5687 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
5688 helper that implement a save/restore stack for CheckState
5689 values. This is the only way to change check-state.
5690 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
5691 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
5692 (CheckedExpr.EmitBranchable): New forwarding method.
5693 (UnCheckedExpr): Likewise.
5694 * statement.cs (Block.ResolveMeta): Use WithCheckState.
5695 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
5696 (Checked.Resolve, checked.DoEmit): Likewise.
5698 2006-07-20 Miguel de Icaza <miguel@novell.com>
5700 * anonymous.cs: Cache the resolved anonymous delegate, and return
5701 this so that the ResolveTopBlock is only triggered once, not
5704 Currently we trigger ResolvetopBlock twice due to a first pass of
5705 argument check compatibility, and a second pass that does the
5708 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5710 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
5712 * rootcontext.cs (Reset): Add helper_classes.
5714 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5717 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
5720 2006-07-13 Miguel de Icaza <miguel@novell.com>
5722 * statement.cs (Lock): Handle expressions of type
5723 TypeManager.null_type specially. Fixes #78770
5725 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5727 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
5730 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5732 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
5733 for accessors as well.
5734 * ecore.cs (EventExpr): Add AccessorTable.
5736 2006-07-01 Marek Safar <marek.safar@seznam.cz>
5739 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
5740 for CS0122 where appropriate.
5741 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
5743 (Filter): Assembly can be null in the case of top level attributes.
5745 2006-06-25 Marek Safar <marek.safar@seznam.cz>
5749 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
5750 is done at global level.
5752 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5754 A fix for #77002, Implemented TypeForwarder support.
5756 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
5757 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
5758 * typemanager.cs (): Add type_forwarder_attr_type.
5760 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5762 * report.cs: Add CS0469 warning.
5764 2006-06-21 Martin Baulig <martin@ximian.com>
5766 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
5767 the `try'-block, so we also report CS0016 etc. there.
5769 2006-06-21 Martin Baulig <martin@ximian.com>
5772 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
5774 2006-06-21 Martin Baulig <martin@ximian.com>
5776 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
5777 also report CS1686 for parameters.
5779 2006-06-21 Martin Baulig <martin@ximian.com>
5781 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
5782 instead of an error if the value is not implicitly convertible to
5783 the switch types; fixes #77964.
5785 2006-06-21 Raja R Harinath <rharinath@novell.com>
5788 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
5789 FieldBuilder is null.
5792 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
5793 'left' and 'right' before error-checking.
5795 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
5797 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
5799 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
5800 (FieldExpr.DoResolve): likewise.
5801 (PropertyExpr.InstanceResolve): likewise.
5802 (EventExpr.InstanceResolve): likewise.
5804 2006-06-04 Marek Safar <marek.safar@seznam.cz>
5806 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
5807 attribute applicable tests for attribute argument.
5809 2006-06-02 Raja R Harinath <rharinath@novell.com>
5812 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
5813 (Binary.OverloadResolve_PredefinedIntegral): New.
5814 (Binary.OverloadResolve_PredefinedFloating): New.
5815 (Binary.OverloadResolve_PredefinedString): New.
5816 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
5817 Follow the standard more closely, and treat numeric promotions in
5818 terms of overload resolution.
5819 (Binary.CheckShiftArguments): Simplify.
5821 2006-06-01 Raja R Harinath <rharinath@novell.com>
5823 * flowanalysis.cs (MyBitVector): Simplify representation.
5824 (MyBitVector.Clone): Avoid allocating BitArray.
5825 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
5826 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
5827 (*): Update. Change all references to MyBitVector.And and
5828 MyBitVector.Or to &= and |=.
5830 2006-05-29 Raja R Harinath <rharinath@novell.com>
5833 * cs-parser.jay (formal_parameter_list): Extend the pattern below
5834 to param arguments too.
5836 2006-05-26 Miguel de Icaza <miguel@novell.com>
5838 * cs-parser.jay: Catch another parsing form for arglist being
5839 followed by other arguments. Fixes #78313.
5841 2006-05-24 Raja R Harinath <rharinath@novell.com>
5843 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
5844 checking of out parameters to ...
5845 (FlowBranchingToplevel.Merge): ... here.
5846 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
5847 set, propagate the origin upward, and only complain if there was
5849 (FlowBranchingException.AddContinueOrigin): Likewise.
5850 (FlowBranchingException.AddReturnOrigin): Likewise.
5851 (FlowBranchingException.AddGotoOrigin): Likewise.
5853 2006-05-23 Raja R Harinath <rharinath@novell.com>
5855 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5856 unreachable, skip it.
5857 (FlowBranchingException.Merge): Always propagate jumps, even if
5858 the finally block renders subsequent code unreachable.
5860 2006-05-18 Raja R Harinath <rharinath@novell.com>
5863 * statement.cs (Goto.Resolve): Move responsibility for resolving
5864 'goto' to FlowBranching.AddGotoOrigin.
5865 (Goto.SetResolvedTarget): New. Callback to set the
5866 LabeledStatement that's the target of the goto.
5867 (Goto.DoEmit): Use Leave instead of Br when crossing an
5868 unwind-protect boundary.
5869 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5870 LookupLabel and adjust to new semantics.
5871 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5872 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5873 Goto.SetResolvedTarget to update target.
5874 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5875 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5876 AddBreakOrigin & co. Delay propagation until ...
5877 (FlowBranchingException.Merge): ... this.
5879 * statement.cs (Block.Resolve): Always depend on flow-branching to
5880 determine unreachability. Kill workaround that originally emitted
5881 only one statement after an "unreachable" label (see infloop in
5884 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5885 This is still "wrong", but anything better would probably need a
5886 multi-pass algorithm.
5887 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5888 usage vector. Force current usage vector to be reachable, to
5889 optimistically signify backward jumps.
5890 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5892 (FlowBranchingLabeled.Merge): New. If no backward jump was
5893 detected, return the original salted-away usage vector instead,
5894 updated with appropriate changes. Print unreachable warning if
5896 * statement.cs (Block.Resolve): Don't print unreachable warning on
5897 a labeled statement.
5899 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5901 * driver.cs: Pass filename without path to AssemblyBuilder's
5902 AddResourceFile. Fixes bug #78407.
5904 2006-05-17 Raja R Harinath <rharinath@novell.com>
5906 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5907 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5908 (FlowBranching.MergeChild): Overwrite
5909 reachability information from Labeled branchings too.
5911 2006-05-16 Raja R Harinath <rharinath@novell.com>
5913 * statement.cs (Goto.Resolve): Merge jump origins here ...
5914 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5916 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5917 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5918 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5919 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5921 * statement.cs (Goto.Resolve): ... not here.
5922 (Goto.Emit): Remove CS1632 check.
5924 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5926 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5929 2006-05-11 Raja R Harinath <rharinath@novell.com>
5931 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5932 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5933 (FlowBranchingException.Label): Likewise.
5935 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5937 (MyBitVector.Or): Use it to avoid losing information (Count).
5938 (FlowBranching.MergeOrigins): Likewise.
5940 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5941 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5942 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5943 (UsageVector.ToString): Simplify.
5944 (UsageVector.MergeSiblings): Move here from ...
5945 (FlowBranching.Merge): ... here.
5946 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5949 2006-05-10 Raja R Harinath <rharinath@novell.com>
5951 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5952 null bitvector is treated as all-true.
5954 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5955 (MyBitVector): Rationalize invariants. 'vector != null' implies
5956 that we have our own copy of the bitvector. Otherwise,
5957 'InheritsFrom == null' implies all inherited bits are true.
5959 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5961 * statement.cs (LocalInfo): Add IsConstant.
5962 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5963 local variable for constants.
5965 2006-05-09 Raja R Harinath <rharinath@novell.com>
5967 * flowanalysis.cs (MyBitVector.Empty): New.
5968 (MyBitVector): Don't allow InheritedFrom to be null.
5969 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5970 (UsageVector, FlowBranching): Update to changes.
5972 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5973 recursion. The 'Parent == null' condition isn't sufficient for
5975 (FlowBranching.AddBreakOrigin): Likewise.
5976 (FlowBranching.AddContinueOrigin): Likewise.
5977 (FlowBranching.AddReturnOrigin): Likewise.
5978 (FlowBranching.StealFinallyClauses): Likewise.
5979 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
5980 (FlowBranching.CheckOutParameters): Likewise.
5981 (FlowBranchingToplevel): Terminate all the above recursions here.
5982 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
5983 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
5985 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
5987 (FlowBranchingToplevel): New. Empty for now.
5988 (FlowBranching.MergeTopBlock): Update.
5989 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
5990 branching for the anonymous delegate.
5991 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
5993 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
5994 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
5995 information at the start of the merge. Reorganize.
5997 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5999 * class.cs (MethodData.Define): Method cannot implement interface accessor.
6001 2006-05-07 Marek Safar <marek.safar@seznam.cz>
6003 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
6004 to newly introduced ctor.
6006 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
6007 message to one place.
6008 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
6011 2006-05-07 Marek Safar <marek.safar@seznam.cz>
6013 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
6015 * ecore.cs (Expression.ResolveAsConstant): Updated.
6017 * statement.cs (ResolveMeta): Updated.
6019 2006-05-06 Marek Safar <marek.safar@seznam.cz>
6021 * cs-parser.jay: __arglist cannot be used in initializer.
6023 2006-05-06 Marek Safar <marek.safar@seznam.cz>
6026 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
6029 2006-05-05 Raja R Harinath <rharinath@novell.com>
6031 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
6032 (LabeledStatement): Add 'name' parameter.
6033 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
6034 (Block.AddLabel): Update to changes.
6035 * cs-parser.jay (labeled_statement): Likewise.
6037 * flowanalysis.cs (BranchingType.Labeled): New.
6038 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
6039 (FlowBranchingLabeled): New. Does nothing for now, but will
6040 eventually handle 'goto' flows.
6041 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
6042 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
6043 that's terminated ...
6044 (Block.Resolve): ... here.
6046 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
6047 (UsageVector.MergeFinallyOrigins): Likewise.
6048 (FlowBranching.InTryOrCatch): Likewise.
6049 (FlowBranching.AddFinallyVector): Likewise.
6050 (FlowBranchingException): Update to changes.
6053 * statement.cs (Return.Resolve): Move error checking to ...
6054 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
6055 (FlowBranchingException): Handle return origins like break and
6057 (FlowBranching.UsageVector.CheckOutParameters): Remove.
6059 2006-05-04 Marek Safar <marek.safar@seznam.cz>
6062 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
6065 2006-05-04 Marek Safar <marek.safar@seznam.cz>
6068 * class.cs (MethodData.Define): Do public accessor check only when method
6069 implements an interface.
6071 2006-05-04 Raja R Harinath <rharinath@novell.com>
6073 Remove special handling of 'break'
6074 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
6075 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
6076 (UsageVector.Break): Remove.
6077 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
6079 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
6081 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
6082 UsageVector.Breaks (). Don't set NeedsReturnLabel.
6084 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6087 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
6088 be the interface member.
6090 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6093 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
6094 for emitting small (int) values.
6096 2006-05-03 Raja R Harinath <rharinath@novell.com>
6099 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
6100 control-flow passes through the 'finally' after merging-in all the
6101 control-flows from 'try' and the 'catch' clauses.
6103 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
6104 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
6105 always true at the only non-recursive entry point.
6106 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
6107 FlowBranchingBreakable.
6108 (FlowBranchingLoop): Remove.
6109 * statement.cs (Return.DoResolve): Update to changes.
6112 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
6113 (FlowBranching.CreateBranching): Handle it: create a
6114 FlowBranchingContinuable.
6115 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
6116 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
6117 except that it handles the 'continue' command.
6118 (FlowBranching.UsageVector.MergeOrigins): Rename from
6120 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
6121 except that it overrides AddContinueOrigin.
6122 (FlowBranchingException): Override AddContinueOrigin, similar to
6124 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
6125 Create a new branching around the embedded statement.
6126 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
6127 control flow after the embedded statement.
6128 (Continue.Resolve): Move all error checking to AddContinueOrigin.
6130 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
6131 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
6132 FlowBranchingBreakable.
6133 (FlowBranchingSwitch): Remove.
6136 * statement.cs (Break.Resolve): Simplify. Move responsibility for
6137 error reporting to ...
6138 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
6139 Rename from 'AddBreakVector'. Add new location argument. Return
6140 a bool indicating whether the 'break' crosses an unwind-protect.
6141 (FlowBranchingException.AddBreakOrigin): Add.
6142 (FlowBranchingException.Merge): Propagate 'break's to surrounding
6143 flowbranching after updating with the effects of the 'finally'
6145 (FlowBranchingBreakable): New common base class for
6146 FlowBranchingLoop and FlowBranchingSwitch.
6148 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
6150 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
6152 2006-05-02 Raja R Harinath <rharinath@novell.com>
6154 * statement.cs (Do.Resolve): If the loop is infinite, set the
6156 (While.Resolve, For.Resolve): Set a barrier after the embedded
6157 statement. There's no direct control flow that goes from the end
6158 of the embedded statement to the end of the loop.
6159 * flowanalysis.cs (FlowBranching.Infinite): Remove.
6160 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
6161 above ensure that the reachability is correctly computed.
6163 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
6164 (UsageVector.MergeBreakOrigins): If the current path is
6165 unreachable, treat it as if all parameters/locals are initialized.
6166 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
6167 infinite loops before merging-in break origins.
6169 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
6170 (Reachability.Reachable): Split part into ...
6171 (Reachability.Unreachable): ... this. Simplify.
6172 (Reachability.IsUnreachable): Use 'Unreachable' instead.
6174 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
6175 (Reachability.SetThrowsSometimes): Likewise.
6176 (FlowBranchingBlock.MergeTopBlock): Don't compare against
6177 TriState.Always, use corresponding property.
6178 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
6179 (Block.Resolve): Likewise. Remove some redundant checks.
6181 2006-05-02 Raja R Harinath <harinath@gmail.com>
6183 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
6184 (Reachability.Meet): Don't bother checking AlwaysThrows --
6185 barrier is always set.
6186 (FlowBranchingBlock.Merge): Likewise.
6188 2006-05-01 Raja R Harinath <harinath@gmail.com>
6190 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
6191 checks for unreachable.
6193 2006-05-01 Marek Safar <marek.safar@seznam.cz>
6196 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
6198 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
6199 whether field is really assigned.
6201 2006-04-30 Raja R Harinath <harinath@gmail.com>
6203 * flowanalysis.cs (Reachability): Make 4-argument constructor
6205 (Reachability.Meet): Rename from 'And'. Remove static variant.
6206 (Reachability.Always): Rename from the highly misleading
6207 'Reachability.Never'.
6208 (FlowBranching.Merge): Update to changes. Mark an impossible
6209 situation with a 'throw'.
6210 (*): Update to changes.
6212 2006-04-29 Raja R Harinath <harinath@gmail.com>
6214 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
6216 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
6217 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
6218 (*): Update to changes.
6219 * statement.cs: Update to changes.
6221 2006-04-28 Marek Safar <marek.safar@seznam.cz>
6224 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
6226 2006-04-28 Raja R Harinath <harinath@gmail.com>
6228 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
6231 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
6232 argument to two arguments: an usage-vector and a bool. Move call
6233 to FlowBranching.Merge () ...
6234 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
6236 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
6237 handling of loop and switch reachability to ...
6238 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
6240 2006-04-27 Raja R Harinath <harinath@gmail.com>
6242 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
6243 handling to FlowBranchingLoop.InLoop.
6244 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
6246 2006-04-26 Marek Safar <marek.safar@seznam.cz>
6249 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
6250 anonymous method is allowed from AnonymousContainer here.
6252 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
6254 2006-04-24 Raja R Harinath <rharinath@novell.com>
6257 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
6259 2006-04-23 Marek Safar <marek.safar@seznam.cz>
6262 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
6263 (DoubleConstant.Reduce): Ditto.
6265 2006-04-23 Raja R Harinath <rharinath@novell.com>
6267 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
6268 Remove 'lvalue_right_side' argument. Move parts to ...
6269 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
6270 (LocalVariable.DoResolveLValue): ... these.
6272 2006-04-21 Raja R Harinath <rharinath@novell.com>
6275 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
6276 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
6277 (LocalVariableReference.DoResolveBase): Use it to implement new
6279 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
6280 (Argument.Resolve): Simplify. Move CS1510 check ...
6281 * ecore.cs (Expression.ResolveLValue): ... here.
6282 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
6283 (PropertyExpr.DoResolveLValue): Likewise.
6284 (FieldExpr.Report_AssignToReadonly): Likewise.
6285 (FieldExpr.DoResolve): Add 'out_access' argument. Use
6286 LValueMemberAccess or LValueMemberOutAccess on instance depending
6288 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
6289 DoResolve as appropriate.
6291 2006-04-20 Raja R Harinath <rharinath@novell.com>
6294 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
6295 implicit conversions on 'out' and 'ref' arguments.
6297 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
6298 improve clarity. Remove dead code.
6301 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
6302 (Catch.Resolve): Resolve VarBlock if it exists.
6304 2006-04-19 Miguel de Icaza <miguel@novell.com>
6306 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
6307 twice, this was some residual code, the enumerator was emitted
6308 properly in the two branche of if later.
6310 2006-04-19 Raja R Harinath <rharinath@novell.com>
6312 * expression.cs (Cast.ResolveLValue): Remove. The result of a
6313 cast is never an lvalue.
6314 (Cast.DoResolve, Cast.ResolveRest): Combine.
6315 (Argument.Emit): Simplify slightly. Move 'Expr is
6316 IMemoryLocation' check ...
6317 (Argument.Resolve): ... here.
6318 (Argument.Error_LValueRequired): Remove. Inline into only user.
6320 Simplifications. Fix cs0191-2.cs
6321 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
6322 CS1649 and CS1651 to ...
6323 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
6324 the actual selection of the error code and message to a lookup
6325 table. Add a dummy return value to simplify callsites.
6326 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
6327 readonly fields of other instances of the same type. Move CS0197
6329 * expression.cs (Argument.Resolve): ... here. Simplify code.
6330 Ensure that ec.InRefOutArgumentResolving is only set during LValue
6331 resolution of an out or ref argument. The code simplification
6332 above uses this invariant.
6334 2006-04-18 Raja R Harinath <rharinath@novell.com>
6336 Possibly fix #77752. Fix cs1690-[4-7].cs.
6337 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
6338 CheckMarshallByRefAccess. Drop parameter.
6339 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
6341 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
6343 * report.cs (AllWarnings): Add CS1690.
6344 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
6346 (LocalVariableReference.DoResolveBase): Update.
6348 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6350 * class.cs (MethodOrOperator): Moved common parts from method class.
6351 detect obsolete attributes.
6352 (Method.Define): Simplified as it reuses code from base.
6353 (Constructor.ValidAttributeTargets): Fixed issue found during
6355 (Destructor.ValidAttributeTargets): Fixed issue found during
6357 (Operator): Finished refactoring set off by #78020. Operator class is now
6358 ordinary method class.
6360 * anonymous.cs: Updated.
6362 * decl.cs (DeclSpace): Add IsGeneric
6364 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6366 * class.cs (Constructor.Emit): Don't emit the attributes twice.
6368 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6370 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
6371 detect obsolete attributes.
6372 (Method.CreateEmitContext): Moved to MethodOrOperator.
6374 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6377 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
6378 customized exception to make crash detection easier.
6379 (MethodOrOperator): Started to work on new base class for methods and
6381 (Method): Derives from MethodOrOperator.
6382 (Constructor.Emit): Emits its own attributes.
6383 (AbstractPropertyEventMethod.Emit): Ditto.
6384 (Operator): Derives from MethodOrOperator, will refactor fully in extra
6386 (Operator.Emit): It's temporary more tricky than should be.
6388 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
6390 * report.cs (InternalErrorException): Add ctor with inner exception.
6392 2006-04-08 Marek Safar <marek.safar@seznam.cz>
6395 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
6398 2006-04-07 Marek Safar <marek.safar@seznam.cz>
6401 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
6404 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6406 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
6407 attribute is present and Guid not.
6408 (Interface.ApplyAttributeBuilder): Ditto.
6410 * attribute.cs: Add error message.
6412 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6416 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
6417 sources (it's composite) so hold them in extra array as they are used in
6418 Emit phase only. It worked in the previous versions by mistake.
6419 (Attribute.Emit): Emit attribute for more owners when exist.
6421 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
6422 it has now different behaviour.
6424 2006-04-04 Marek Safar <marek.safar@seznam.cz>
6426 * constant.cs (Constant.IsDefaultInitializer): New method.
6428 * class.cs: Updated.
6430 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
6431 re-initialize default values. It saves KBs almost for every assembly.
6432 Thanks Zoltan for the idea.
6433 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
6434 (ArrayCreation.DoResolve): Resolve only once.
6435 (ArrayCreation.Emit): Emit static initializer only when it is faster.
6436 (ArrayCreation.GetAttributableValue): Cope with optimized values.
6438 2006-04-03 Zoltan Varga <vargaz@gmail.com>
6440 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
6443 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6445 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
6446 in an embedded statement too.
6448 2006-04-01 Raja R Harinath <rharinath@novell.com>
6451 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
6453 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6457 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
6460 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
6462 2006-03-31 Marek Safar <marek.safar@seznam.cz>
6464 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
6467 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
6468 LocalTemporary change.
6470 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
6472 (ClassOrStruct.DefineFieldInitializers): Implemented static field
6473 initializers optimization.
6474 (ClassOrStruct.TypeAttr): Moved from modifiers.
6475 (Constructor.CheckBase): Don't crash when static ctor has parameters.
6476 (FieldBase.ResolveInitializer): Resolves initializer.
6477 (FieldBase.HasDefaultInitializer): New property.
6479 * cs-parser.jay: Removed message.
6481 * expression.cs (CompilerGeneratedThis): New specialization.
6483 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
6485 2006-03-28 Marek Safar <marek.safar@seznam.cz>
6487 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
6489 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6491 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
6492 be now EnumConstants only.
6494 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6496 * attribute.cs, driver.cs: Reset more caches.
6498 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6500 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
6502 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6504 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
6505 for easier reuse. Updated all overrides.
6506 (IntegralConstant): New base class for all integral constants.
6507 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
6508 of the constant range, report custom error.
6509 (UIntConstant.Reduce): Fixed uint conversion.
6511 * ecore.cs, literal.cs: Reduce updates.
6513 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6517 * class.cs (Constructor.Define): Removed extra if for default ctors.
6518 A patch from Atsushi Enomoto.
6520 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6522 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
6523 GetAttributableValue.
6525 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
6528 * convert.cs (ImplicitConversionRequired): Error message moved to
6531 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
6532 automatic implicit conversion of an output value.
6533 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
6535 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
6537 (TypeOf.GetAttributableValue): Add extra handling for object type.
6539 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
6540 special error message.
6542 2006-03-25 Marek Safar <marek.safar@seznam.cz>
6544 * class.cs (Constructor.Emit): Don't crash when struct ctor is
6546 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
6547 compatible with MS runtime.
6549 2006-03-23 Marek Safar <marek.safar@seznam.cz>
6551 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
6552 attribute arguments here.
6554 * class.cs (Indexer.Define): The check was moved to attribute class.
6556 2006-03-22 Marek Safar <marek.safar@seznam.cz>
6558 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
6559 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
6562 2006-03-22 Raja R Harinath <rharinath@novell.com>
6564 Support ParameterDefaultValueAttribute in gmcs. Also applied to
6565 mcs to keep code differences small.
6566 * attribute.cs (Attribute.GetParameterDefaultValue): New.
6567 * typemanager.cs (parameter_default_value_attribute_type): New.
6568 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
6571 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6573 * expression.cs (StringConcat.Append): Reverted back to no warning state.
6575 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6577 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
6579 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
6582 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
6584 * doc-bootstrap.cs : fix build.
6586 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6588 * expression.cs (StringConcat.Append): Issue a warning when empty string
6591 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6593 * assign.cs (CompoundAssign.ResolveSource): Removed.
6595 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
6598 * class.cs (TypeContainer.FindMethods): Removed.
6599 (TypeContainer.CheckMemberUsage): Made static.
6601 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
6603 * constant.cs (CheckRange): Removed unused type argument.
6604 (CheckUnsigned): Removed unused type argument.
6606 * cs-parser.jay: Updated after MemberAccess clean up.
6607 Uses Length for empty string test.
6609 * cs-tokenizer.cs: Uses Length for empty string test.
6610 (IsCastToken): Made static.
6611 (is_hex): Made static.
6612 (real_type_suffix): Made static.
6614 * decl.cs (SetupCache): Made static.
6615 (OnGenerateDocComment): Removed unused ds argument.
6617 * delegate.cs (VerifyDelegate): Removed unused argument.
6619 * doc.cs: Uses Length for empty string test.
6621 * driver.cs: Uses Length for empty string test.
6623 * enum.cs (IsValidEnumType): Made static
6625 * expression.cs (EnumLiftUp): Removed unused argument.
6626 (ResolveMethodGroup): Ditto.
6627 (BetterConversion): Ditto.
6628 (GetVarargsTypes): Ditto.
6629 (UpdateIndices): Ditto.
6630 (ValidateInitializers): Ditto.
6631 (MemberAccess.ctor): Ditto.
6632 (GetIndexersForType): Ditto.
6634 * flowanalysis.cs: (MergeFinally): Removed unused argument.
6636 * iterators.cs: Updated after MemberAccess clean up.
6638 * location.cs: Uses Length for empty string test.
6640 * namespace.cs: Uses Length for empty string test.
6642 * report.cs (CheckWarningCode): Made static.
6644 * statement.cs (LabeledStatement): Removed unused argument.
6646 * typemanager.cs (FilterNone): Removed.
6648 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6650 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
6653 * class.cs: Updated.
6655 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6657 * cs-parser.jay.cs: __arglist is not allowed for delegates.
6659 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6663 * expression.cs (VerifyArgumentsCompat): Reverted to double error
6664 reporting, it's more tricky than I thought.
6666 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6670 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
6672 (AnonymousMethod.ImplicitStandardConversionExists): New method.
6673 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
6674 Add more error reporting; Fixed issue with params.
6676 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
6678 * cs-parser.jay: AnonymousMethod requires host container.
6680 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
6682 2006-03-18 Raja R Harinath <harinath@gmail.com>
6684 * class.cs: Change 'TypeContainer ds' constructor argument to
6685 'DeclSpace parent'. Some classes were missed below due to
6686 different naming convention.
6688 * class.cs (MemberCore.Parent): Delete. This makes the
6689 ParentContainer changes below enforceable by the compiler.
6691 Treat pointers to enclosing declaration space as 'DeclSpace', not
6693 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
6694 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
6696 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
6698 (Block.AddThisVariable): Likewise.
6699 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
6700 (AbstractPropertyEventMethod.Emit): Likewise.
6701 (AbstractPropertyEventMethod.EmitMethod): Likewise.
6702 (GetMethod.Define, SetMethod.Define): Likewise.
6703 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
6704 (DelegateMethod.EmitMethod): Likewise.
6706 Fix regression test-partial-13.cs.
6707 Rationalize use of PartialContainer. Ensure that the partial
6708 class semantics can be tied to type-correctness, i.e., any
6709 violation will cause a compile error.
6710 * class.cs, const.cs: Access all fields that belong to class
6711 TypeContainer via ParentContainer. Arguments of EmitContexts and
6712 Resolve()-like functions still use 'Parent'.
6714 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
6715 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
6716 (PropertyMethod.CheckModifiers): Remove unused argument.
6717 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
6720 2006-03-17 Raja R Harinath <harinath@gmail.com>
6722 Make semantics of PartialContainer simpler.
6723 * decl.cs (DeclSpace.IsPartial): Remove.
6724 * class.cs (TypeContainer.IsPartial): Likewise.
6725 (TypeContainer..ctor): Set PartialContainer to point to self.
6726 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
6727 (TypeContainer.FindNestedType): Likewise.
6728 (MemberCore.ParentContainer): Simplify. Remove deprecation.
6730 2006-03-17 Marek Safar <marek.safar@seznam.cz>
6732 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
6734 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6736 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
6739 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6741 * class.cs (Operator.Define): An error for base conversion was not
6744 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
6746 * iterator.cs : yield break is allowed in try statement which has
6747 catch clauses. Fixed bug #77767.
6749 2006-03-13 Marek Safar <marek.safar@seznam.cz>
6751 A fix for #77593, #77574.
6753 * class.cs (MethodCore.CheckBase): Another if for operator.
6755 2006-03-09 Marek Safar <marek.safar@seznam.cz>
6757 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
6760 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
6761 (DelegateCreation.ImplicitStandardConversionExists): New method for just
6764 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
6767 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
6768 Updated after another emitcontext usage was clean up. It should help us to
6769 synchronize with gmcs easier.
6771 2006-03-04 Marek Safar <marek.safar@seznam.cz>
6775 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
6776 (Event.Define): ditto
6777 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
6779 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
6780 Removed redundant code and set NewSlot for Invoke method too.
6782 * parameter.cs (Parameters.ctor): Add custom, type ctor.
6783 (Parameters.MergeGenerated): New method. Use this method when you merge
6784 compiler generated argument with user arguments.
6786 2006-03-03 Marek Safar <marek.safar@seznam.cz>
6788 * attribute.cs (ResolveAsTypeTerminal): Removed.
6790 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
6791 specialization for predefined types; 30% speed up.
6792 Finally placed obsolete check to right place.
6793 (Expression.ResolveType): Removed.
6795 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
6796 Updated after ResolveType was removed.
6798 * expression.cs (Cast.ctor): Check void cast.
6799 (Binary.ResolveAsTypeTerminal): Is never type.
6800 (Conditional.ResolveAsTypeTerminal): Is never type.
6802 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
6804 2006-03-01 Raja R Harinath <rharinath@novell.com>
6807 * expression.cs (ParameterReference.DoResolveBase): Change return
6809 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
6813 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
6816 * typemanager.cs (GetFullNameSignature): Don't nullref on
6817 protected accessors.
6819 2006-02-27 Marek Safar <marek.safar@seznam.cz>
6821 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
6822 these two separated members to simplify the code.
6823 (Attribute.Resolve): Refactored to use new fields and methods.
6824 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
6825 implemented obsolete attribute checking.
6826 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
6827 implemented obsolete checking again. It look line never ending quest ;-)
6828 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
6830 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
6832 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
6834 *class.cs (Property.Define): Add RegisterProperty call.
6836 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
6837 argument groups (only 2).
6839 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
6840 encoding expression to arguments.
6841 (Expression.ExprClassToResolveFlags): Just turned to property.
6843 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
6844 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
6845 optimized as well as implemented support for zero-length attributes.
6847 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
6848 Add caching of PropertyInfo's.
6850 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6852 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
6853 error multiple times.
6855 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6857 New partial class implementation.
6858 A fix for #77027, #77029, #77403
6860 * attribute.cs (Attributable): Made attributes protected.
6862 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6863 the replacements of ClassPart and PartialContainer.
6864 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6865 (TypeContainer.AddInterface): Ditto.
6866 (TypeContainer.AddPartial): The main method for partial classes. It checks
6867 for errors and merges ModFlags and attributes. At the end class is added to
6869 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6871 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6872 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6873 from the rest of partial classes.
6874 (TypeContainer.GetClassBases): Simplified.
6875 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6877 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6878 (TypeContainer.HasExplicitLayout): Uses Flags now.
6879 (PartialContainer): Removed.
6880 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6881 (StaticClass): Was merged with Class.
6882 (Class.GetClassBases): class and static class bases are verified here.
6883 (Class.TypeAttr): Added static attributes when class is static.
6884 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6885 (MemberBase): In some cases we need to call parent container for partial
6886 class. It should be eliminated but it's not easy now.
6888 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6890 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6891 partial classed to accumulate class comments.
6892 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6894 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6896 * driver.cs (MainDriver): Tree.GetDecl was removed.
6898 * modifiers.cs (Modifiers): Add partial modifier.
6900 * tree.cs (Tree.decl): Removed.
6901 (RootTypes): Started to use this class more often for root types
6904 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6908 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6909 external interface does not have an attribute.
6911 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6913 Another prerequisites for new partial classs implementation.
6915 * attribute.cs (Attribute.Equal): Implemented.
6916 (Attribute.Emit): Changed as attributes can be applied more than twice.
6917 (Attributes.Emit): Check for duplicate attributes here.
6919 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6920 as a parameter, clean-up.
6922 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6926 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6927 contains obsolete attribute check which can in some cases look for base
6928 type of current class which is not initialized yet.
6929 (TypeContainer.BaseType): Replacement of ptype.
6931 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6933 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6935 First of prerequisites for new partial classs implemention.
6937 * attribute.cs (Attributable): Extended by ResolveContext;
6938 Attributes finally have correct context for resolving in all cases.
6939 (AttachTo): Attribute owner is assigned here.
6941 * codegen.cs (IResolveContext): Introduce new interface to hold
6942 all information needed in resolving phase.
6943 (EmitContext): Implements IResolveContext; more clean-up needed here.
6945 * decl.cs (MemberCore): Implemented IResolveContext.
6947 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6948 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6949 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6950 Refactored to use new IResolveContext instead of EmitContext; cleanup
6952 2006-02-06 Miguel de Icaza <miguel@novell.com>
6954 * codegen.cs (EmitScopeInitFromBlock): check here the
6955 capture_context, there is no need to make two calls to the
6958 * anonymous.cs: Add some debugging messages that might help me
6959 track other instances of this problem in the future (the
6960 regression of test 467).
6962 * cs-parser.jay: track the variable block, as we need to initalize
6963 any captured variables declared in this block for the "catch"
6964 portion of the "Try" statement.
6966 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6967 scope initialization for captured variables.
6969 Also, move the emit for the variables after the block location has
6972 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6974 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6976 2006-02-02 Miguel de Icaza <miguel@novell.com>
6978 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
6979 commit yesterday, the initialization for the roots is necessary.
6980 What is not necessary is the scope activation.
6982 2006-02-02 Raja R Harinath <rharinath@novell.com>
6984 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
6985 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
6987 (Argument.Resolve): Remove CS0206 checks.
6989 2006-02-01 Miguel de Icaza <miguel@novell.com>
6991 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
6992 scopes for all the roots, the scopes will now be emitted when the
6993 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
6995 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
6996 code. This reduces a lot of existing cruft.
6998 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
6999 that the ScopeInfo is generated as we enter the scope, not at the
7000 time of use, which is what we used to do before.
7002 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
7003 every time a Block is about to be emitted if we have a
7006 2006-02-01 Raja R Harinath <rharinath@novell.com>
7008 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
7010 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
7012 * typemanager.cs (cons_param_array_attribute): Make private.
7013 (Reset): Set it to null.
7014 (InitCoreHelpers): Don't initialize it.
7015 (ConsParamArrayAttribute): New. Initialize it as needed.
7016 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
7018 2006-01-31 Miguel de Icaza <miguel@novell.com>
7020 * expression.cs: There might be errors reported during the
7021 selection of applicable methods. If there are errors, do not
7022 continue execution as it will lead the compiler to crash.
7024 2006-01-30 Miguel de Icaza <miguel@novell.com>
7026 * expression.cs: Member access is not allowed on anonymous
7027 methods. Fixes #77402.
7029 2006-01-30 Raja R Harinath <rharinath@novell.com>
7032 * cs-parser.jay (VariableDeclaration): Don't set
7033 current_array_type to null.
7034 (field_declaration, event_declaration, declaration_statement):
7035 Set it to null here.
7037 2006-01-28 Raja R Harinath <harinath@gmail.com>
7039 * typemanager.cs (GenericParameterPosition): New.
7042 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
7044 * doc.cs : To process "include" elements, first we should create
7045 another list than XmlNodeList, because it could result in node
7046 removal, which could result in that the XmlNodeList gives up
7049 (Also made code identical to gmcs again.)
7051 2006-01-25 Miguel de Icaza <miguel@novell.com>
7053 * ecore.cs: Introduce an error report that we were not catching
7054 before, if not silent, we must report the error. Gonzalo ran into
7057 2006-01-23 Miguel de Icaza <miguel@novell.com>
7059 A fix for bug: #76957
7061 * iterators.cs (MoveNextMethod.CreateMethodHost): call
7062 ComputeMethodHost before creating the method, this is a new
7065 * anonymous.cs (AnonymousContainer): Now we track all the scopes
7066 that this method references (RegisterScope). The actual scope
7067 where the method is hosted is computed with the ComputeMethodHost
7068 before we create the method.
7070 Moved the Deepest routine here.
7072 (AnonymousContainer.ComputeMethodHost): New routine used to
7073 compute the proper ScopeInfo that will host the anonymous method.
7075 (ScopeInfo): Deal with multiple roots. The problem was that we
7076 did not have a unique root where all ScopeInfos could be hanged
7077 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
7080 Remove AdjustMethodScope which is now computed at the end. Remove
7081 LinkScope which did a partial link, instead link all ScopeInfos
7082 before code generation from the new "LinkScopes" routine.
7084 Simplify all the Add* routines as they no longer need to maintain
7085 the tree, they just need to record that they are using variables
7088 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
7089 routines to produce the forest of ScopeInfo trees.
7091 * class.cs (TypeContainer.AppendMethod): This is just like
7092 AddMethod, but ensures that an interface implementation method
7093 (IEnumerable.XXX) is not inserted at the beginning of the queue of
7094 methods, but at the end.
7096 We use this functionality to ensure that the generated MoveNext
7097 method in the iterator class is resolved/emitted before the
7098 enumerator methods created.
7100 This is required because the MoveNext method computes the right
7101 ScopeInfo for the method. And the other methods will eventually
7102 need to resolve and fetch information computed from the anonymous
7105 2006-01-21 Raja R Harinath <harinath@gmail.com>
7106 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7109 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
7111 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
7112 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
7114 2006-01-18 Raja R Harinath <rharinath@novell.com>
7116 Fix #76656, cs0231-2.cs.
7117 * cs-parser.jay (formal_parameter_list): Make error case catch
7119 (parenthesized_expression_0): Add CS1026 check.
7120 (invocation_expression): Remove unused { $$ = lexer.Location }.
7122 2006-01-17 Raja R Harinath <rharinath@novell.com>
7125 * cs-parser.jay (statement_expression): Don't list out the
7126 individual statement-expressions. Convert syntax error into
7129 2006-01-16 Raja R Harinath <rharinath@novell.com>
7132 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
7133 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
7134 CheckIntermediateModification.
7135 (FieldExpr.DoResolve): Add new two-argument version that
7136 allows us to resolve the InstanceExpression as an lvalue.
7137 The one-argument variant is now just a wrapper.
7138 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
7139 Resolve the lhs as an lvalue if the it has a value type.
7140 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
7141 from Assign.DoResolve.
7142 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
7143 resolved as an lvalue.
7144 (PropertyExpr.DoResolve): Update.
7145 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
7146 has a value type. Move CS1612 check here from
7147 CheckIntermediateModification.
7148 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
7149 * expression.cs (EmptyExpression.OutAccess): New. Used as the
7150 'right_side' of a ResolveLValue on an 'out' argument.
7151 (EmptyExpression.LValueMemberAccess): New. Used as the
7152 'right_side' of a propagated ResolveLValue on a value type.
7153 (LocalVariableReference.DoResolveBase): Recognize
7154 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
7156 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
7157 EmptyExpression.Null.
7159 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
7161 * typemanager.cs : added IsGenericParameter(). In mcs it always
7163 * doc.cs : for generic parameters, use GenericParameterPosition,
7166 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
7168 * expression.cs: Fix Console.WriteLine ((this = x).foo);
7170 2006-01-12 Miguel de Icaza <miguel@novell.com>
7172 This fixes the problem where we used ldfld instead of ldflda to
7173 load the "THIS" pointer on captured parameters, when THIS is a
7174 value type. See bug #77205.
7176 * iterators.cs (CapturedThisReference.Emit): Pass false to
7177 EmitThis (we do not need the address).
7179 * codegen.cs (EmitThis): it needs to know whether we need the
7180 address of `this' or not. This is used by value types.
7182 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
7183 every other call passes false.
7185 2006-01-12 Raja R Harinath <rharinath@novell.com>
7188 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
7190 * expression.cs (Invocation.OverloadResolve): Update.
7191 (Invocation.DoResolve): Avoid double resolution of invocation.
7193 2006-01-11 Raja R Harinath <rharinath@novell.com>
7196 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
7197 unary negation of floating point types as 0-expr; negation cannot
7198 overflow in floating point types.
7201 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
7202 on operands of 'void' type.
7205 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
7206 and ExclusiveOr for boolean constants too.
7208 2006-01-09 Raja R Harinath <rharinath@novell.com>
7211 * expression.cs (Invocation.OverloadResolve): Replace reflected
7212 override methods with their base virtual methods, rather than
7214 * typemanager.cs (TypeManager.GetOverride): New.
7216 2006-01-05 Jb Evain <jbevain@gmail.com>
7218 * class.cs (Property.Define, Indexer.Define): do not tag the
7219 properties as SpecialName | RTSpecialName.
7221 2006-01-04 Miguel de Icaza <miguel@novell.com>
7223 * class.cs (MethodCore.IsDuplicateImplementation): This method was
7224 doing a low-level comparission of parameter types. It was lacking
7225 a check for __argslist.
7227 2005-12-30 Miguel de Icaza <miguel@novell.com>
7229 * expression.cs (ParameterReference.DoResolveBase): Allow
7230 reference parameters if they are local to this block.
7232 This allows the ref and out parameters of a delegate to be used in
7233 an anonymous method, for example:
7235 delegate void set (out int x);
7237 set s = delegate (out int x){
7241 This is used by functionality introduced late in the C# language.
7243 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
7244 method that take ref and out parameters.
7246 Fixes #77119 which was a late change in the spec.
7248 2005-12-23 Miguel de Icaza <miguel@novell.com>
7250 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
7251 parent if its the same scope. Fixes #77060.
7253 2005-12-21 Miguel de Icaza <miguel@novell.com>
7255 * driver.cs: Report the case of no source files and no -out:
7258 2005-12-20 Raja R Harinath <rharinath@novell.com>
7261 * expression.cs (ComposedCast.GetSignatureForError): Define.
7263 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7267 * namespace.cs (NamespaceEntry): Add extern_aliases as a
7268 ListDictionary, to contain the ExternAliasEntry entries (in
7269 addition to the NamespaceEntry.aliases hashtable). This field is
7270 shared between the original entry and its doppelganger (bodyless
7272 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
7273 extern_aliases field.
7274 (NamespaceEntry.Lookup): Move the IsImplicit check after the
7275 lookup in extern_aliases.
7277 2005-12-16 Raja R Harinath <rharinath@novell.com>
7280 * class.cs (TypeContainer.Mark_HasEquals): New.
7281 (TypeContainer.Mark_HasGetHashCode): New.
7282 (ClassPart): Override them.
7283 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
7286 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
7287 'parent' argument to the base constructor.
7289 Remove all mention of TypeContainer from decl.cs.
7290 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
7291 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
7292 (DeclSpace.DeclSpace): Likewise.
7293 (DeclSpace.DefineMembers): Remove unused argument.
7294 * cs-parser.jay (pop_current_class): Update to changes. Simplify
7295 debugging check -- we don't care if the debug code throws an
7296 InvalidCastException instead of an InternalErrorException.
7297 * class.cs (TypeContainer.DefineMembers): Update to changes.
7298 (TypeContainer.DoDefineMembers): Likewise.
7299 (TypeContainer.GetMethods): Likewise.
7300 (PropertyMember.Define): Likewise.
7301 (MemberBase.Parent): New property that forwards to
7302 MemberCore.Parent, but ensures that we get a TypeContainer.
7303 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
7304 (RootContext.PopulateTypes): Likewise. Remove special case code
7305 for !RootContext.StdLib: DefineMembers is idempotent.
7307 2005-12-14 Miguel de Icaza <miguel@novell.com>
7309 * convert.cs (ExplicitConversionCore): Check the return value from
7310 ExplicitConversionCore which can return null on failure. Fixes #76914
7312 2005-12-13 Marek Safar <marek.safar@seznam.cz>
7314 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
7316 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
7318 * doc.cs : The search for referenced namespace was insufficient to
7319 get global one as it used to do. Fixed bug #76965.
7321 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
7323 * doc.cs : check name in cref in the last phase that whether it is
7326 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7328 * cs-tokenizer.cs : reverted the latest change: it somehow broke
7331 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7333 * doc.cs : so it turned out that we cannot skip override check for
7334 interface members. Fixed bug #76954.
7336 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7338 * cs-tokenizer.cs : fixed bug #75984:
7339 - #warning and #error should not be handled when the source line
7341 - #line is not checked strictly when the source line is disabled.
7342 - #define and #undef is on the other hand checked strictly at any
7345 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
7347 * cs-tokenizer.cs : missing Location (actually, filename) in one of
7350 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7352 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
7354 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
7356 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
7357 (FieldBase.Initializer): Initializer is now optional.
7358 (EventField.Define): Only event field can have initializer.
7360 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
7362 * const.cs (Const): Reuse initializer.
7364 * cs-parser.jay: Updated after FieldBase changes.
7365 Added current_array_type to simplify array initializers.
7367 * ecore.cs (NullCast.IsDefaultValue): Implemented.
7369 * expression.cs, iterators.cs: Updated.
7371 * namespace.cs (NamespaceEntry): Made UsingFound private.
7373 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7375 * parameterCollection.cs: Obsolete, removed.
7376 * parser.cs: Obsolete, removed.
7378 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7381 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
7383 * enum.cs (Enum.Define): Set obsolete context here.
7385 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7388 - FindDocumentedMember() now expects 1) paramList as null
7389 when "we don't have to check the number of parameters" and
7390 2) Type.EmptyTypes when "there is no arguments".
7391 - Introduced FoundMember struct to hold the exact type which was
7392 used to find the documented member (the above change broke
7393 test-xml-044; it might be better just to use DeclaringType than
7394 what MS does, like this change does, but it depends on usage.)
7396 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7398 * doc.cs : documented member might be from DeclaringType for nested
7399 types. Fixed bug #76782.
7401 2005-12-03 Ben Maurer <bmaurer@ximian.com>
7403 * anonymous.cs: Have the param code handle leaving copies on the
7404 stack etc. Allows anonymous params to take part in the assignment
7405 code (++, +=, etc). Fixes bug #76550
7407 * expression.cs: Handle the prepare_for_load/leave_copy by passing
7408 it down to the anon code.
7410 * iterators.cs: Use dummy var here
7412 * codegen.cs: Handle new vars
7414 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7417 * class.cs (MethodData.Define): Set proper Obsolete context.
7419 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
7421 (FieldExpr.DoResolve): Ditto.
7423 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7426 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
7427 parent is not obsolete.
7429 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
7431 * doc.cs : (FindDocumentedMember) find parameterless members first
7432 and get CS0419 in the early stage. Fixed first case of bug #76727.
7434 2005-11-30 Marek Safar <marek.safar@seznam.cz>
7437 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
7438 no error was reported.
7440 *expression.cs (Binary.DoResolve): left can be null.
7442 2005-11-22 Marek Safar <marek.safar@seznam.cz>
7445 * class.cs (MethodData.Emit): Parameters should be labeled first.
7447 2005-11-21 Marek Safar <marek.safar@seznam.cz>
7450 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
7452 2005-11-18 Marek Safar <marek.safar@seznam.cz>
7454 * attribute.cs (AreParametersCompliant): Moved to Parameter.
7456 * class.cs (MethodCore): Parameter clean up.
7457 (IMethodData): Added ParameterInfo.
7458 (MethodData): Parameter clean up.
7459 (Indexer.Define): Parameter clean up.
7471 * typemanager.cs: Parameter clean up.
7473 * delegate.cs (Define): Get rid of duplicated code.
7475 * expression.cs (ParameterReference): Removed useless parameters
7477 (Invocation): Ditto.
7479 * parameter.cs (ParamsParameter): New class, params specialization.
7480 (ArglistParameter): Attemp to separate arglist.
7481 (Parameter): Refactored to be reusable and faster.
7482 (Parameter.Modifier): Made understandable.
7483 (Parameters): Changed to be used as a class for `this' assembly
7484 parameters. Refactored to use new specialized classes.
7486 * support.cs (ParameterData): Added Types property.
7487 (InternalParameters): Deleted.
7489 2005-08-20 Martin Baulig <martin@ximian.com>
7491 Merging this patch from GMCS to fix #75867.
7493 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7494 scope if we don't already have it.
7496 2005-11-17 Martin Baulig <martin@ximian.com>
7499 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
7500 inherit the scope from our parent. Fixes #76653.
7502 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7504 * doc.cs : the previous patch does not actually fix the bug.
7505 PropertyInfo override check is now implemented and really fixed it.
7506 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
7508 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7510 * doc.cs : apply "override filter" also to properties.
7513 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7515 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
7516 no need to check overrides. For classes, omit those results from
7517 interfaces since they must exist in the class. Fixed bug #76726.
7519 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7521 * typemanager.cs : (GetFullNameSignature) differentiate indexers
7522 with different parameters. Fixed the second problem in #76685.
7524 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7526 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
7527 get expected 'protected' access in CheckValidFamilyAccess()).
7530 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7532 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
7533 Fixed bug #76705. CS1569 was incorrectly commented out.
7535 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7537 * doc.cs : use Invocation.IsOverride() to do real override check.
7538 * expression.cs : made Invocation.IsOverride() internal.
7540 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7542 * doc.cs : use TypeManager.FindMembers() instead of (possible)
7543 TypeBuilder.FindMembers() and filter overriden base members out.
7546 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7548 * doc.cs : ref/out parameters are represented as '@' (instead of
7549 '&' in type FullName). Fixed bug #76630 (additionally crefs).
7551 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7553 * doc.cs : when there was no '.' in cref to methods in doc comment,
7554 then parameters were missing in the output. Fixed bug #76691.
7556 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7558 * driver.cs : don't output docs when there is an error.
7561 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7564 Now it should detect indexers. Fixed primary concern in bug #76685.
7565 Fixed CS0419 message to not show the identical member signature in
7568 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7570 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
7571 instead of Type.FindMembers() since it does not handle events.
7574 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
7576 * codegen.cs: Fixed typo (speficied -> specified).
7578 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7581 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
7583 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7585 * attribute.cs: Changed error message.
7587 * cs-tokenizer.cs: One more check.
7589 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7591 * statement.cs (Block.Resolve): Ignore empty statement.
7593 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7595 * report.cs: Made error/warning methods more strict to avoid
7598 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
7599 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
7600 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
7601 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
7603 2005-11-08 Marek Safar <marek.safar@seznam.cz>
7605 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
7606 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
7608 * class.cs (TypeContainer.IsComImport): New property.
7609 (Constructor.Define): Create proper ctor for ComImport types.
7611 * expression.cs (New.CheckComImport): Fixed.
7613 2005-11-07 Miguel de Icaza <miguel@novell.com>
7615 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
7616 that a parameter has been captured does not mean that we do not
7617 have to do the rest of the processing. This fixes the second part
7618 of #76592. If there was another anonymous method capturing
7619 values in the past, the Scope would never be set for the second
7620 method that captured the same parameter.
7622 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
7623 properly manipulate the stack. Second part of fix for #76592.
7625 * expression.cs (New): Add support for invoking "new" on
7626 interfaces that have been flagged with the ComImport attribute and
7627 the CoClass. Fixes #76637
7629 * statement.cs (Try.DoEmit): When a variable is captured, do not
7630 try to emit the vi.LocalBuilder variable as it has been captured.
7631 Create a temporary variable and store the results on the
7632 FieldBuilder. Fixes #76642
7634 2005-11-07 Marek Safar <marek.safar@seznam.cz>
7636 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
7638 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
7640 * expression.cs (Binary.DoResolve): Added && optimalization.
7642 * typemanager.cs (AddUserType): Removed useless argument.
7644 2005-11-04 Marek Safar <marek.safar@seznam.cz>
7646 * statement.cs (Block.variables): Uses ListDictionary.
7648 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7651 * class.cs (PartialContainer.EmitType): Customized to emit
7652 security attributes.
7653 (ClassPart.ApplyAttributeBuilder): Transform security attribute
7654 for partial classes.
7656 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7659 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
7660 access has to be fixed.
7662 * typemanager.cs (IsUnmanagedType): Wrong common field type.
7664 2005-11-01 Marek Safar <marek.safar@seznam.cz>
7667 * ecore.cs (NullCast.Reduce): Implemented.
7669 * expression.cs (ArrayCreation.CheckIndices): Correcly check
7672 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
7674 (Foreach.Resolve): Catch null properly.
7676 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7678 * cs-tokenizer.cs: Warning text fix.
7680 * driver.cs: AllWarningNumbers exposed on public interface.
7682 * report.cs (): Reviewed warning numbers.
7683 (IsValidWarning): Use binary search.
7685 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7687 * driver.cs: Implemeted resource visibility.
7688 (Resources): New class for code sharing between /res: and
7691 2005-10-28 Marek Safar <marek.safar@seznam.cz>
7694 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
7697 * convert (Convert.ImplicitReferenceConversion): NullCast holds
7700 * ecore.cs (NullCast): Child is contant only.
7702 * literal.cs (NullLiteral.Reduce): null can be converted to any
7705 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
7707 * driver.cs: Use Encoding.Default as default code page instead
7710 2005-10-27 Raja R Harinath <rharinath@novell.com>
7713 * expression.cs (Invocation.Error_InvalidArguments): Handle
7714 __arglist parameters.
7715 (Invocation.VerifyArgumentsCompat): Likewise.
7716 * support.cs (ReflectionParameters.GetSignatureForError): Print
7717 __arglist parameters.
7718 (InternalParamters.GetSignatureForError): Likewise.
7719 * parameter.cs (Parameters.GetSignatureForError): Likewise.
7721 2005-10-26 Marek Safar <marek.safar@seznam.cz>
7723 * attribute.cs (GetPropertyValue): Made public.
7725 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
7727 Add new property WrapNonExceptionThrows to handle 2.0 assembly
7729 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
7732 * driver.cs: Reflect method name change.
7734 * statement.cs (Try.Resolve): Warn when try has both general
7737 * typemanager.cs: runtime_compatibility_attr_type new predefined
7740 2005-10-26 Raja R Harinath <harinath@gmail.com>
7743 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
7744 treat it as an empty parameter list.
7746 2005-10-26 Raja R Harinath <rharinath@novell.com>
7749 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
7750 ResolveAsTypeStep silent.
7751 * statement.cs (Block.AddConstant): Mark block as used.
7752 (Block.ResolveMeta): Avoid piling on error messages
7753 if a constant initializer resolution fails.
7755 2005-10-25 Raja R Harinath <rharinath@novell.com>
7757 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
7759 (NamespaceEntry.VerifyAllUsing): New.
7760 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
7761 behaviour. Delegates actual resolution of alias to ...
7762 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
7763 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
7765 * driver.cs (Driver.MainDriver): Update.
7767 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
7768 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
7770 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
7772 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
7773 RootNamespace.DefineNamespacesForAll.
7775 2005-10-24 Raja R Harinath <harinath@gmail.com>
7777 * typemanager.cs (assemblies, external_aliases, modules)
7778 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
7779 (ComputeNamespaces, GetRootNamespace): Remove extra staging
7780 overhead. Move resposibility ...
7781 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
7782 * driver.cs, attribute.cs, codegen.cs: Update to changes.
7784 2005-10-23 Raja R Harinath <harinath@gmail.com>
7786 * namespace.cs (RootNamespace.all_namespaces): Renamed from
7787 cached_namespaces. Improve usage.
7788 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
7789 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
7790 Move from GlobalRootNamespace and simplify.
7791 (RootNamespace.Global): Make instance variable.
7792 (RootNamespace.RootNamespace): Add "alias name" parameter.
7793 (GlobalRootNamespace): Simplify drastically.
7794 (Namespace.Lookup): Don't use GetNamespace.
7795 * typemanager.cs (GetRootNamespace): Rename from
7796 ComputeNamespaceForAlias.
7797 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
7799 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7801 * anonymous.cs (AnonymousContainer): Don't crash when container
7804 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7806 * expression.cs (Binary.DoResolve): Warn when comparing same
7809 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7812 * expression.cs (Binary.DoResolve): It looks like there are no
7813 convetsion rules in enum context.
7815 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7817 Add support for extern alias qualifiers.
7818 * typemanager.cs: Move some LookupTypeReflection code
7819 to namespace.cs, to have cleaner code. Added some methods
7820 to help us keep track of the extern aliased references.
7821 * driver.cs: Add suport for extern alias assemblies on command
7822 line and check for their warnings/errors. Also keep track of the
7823 extern aliased assemblies.
7824 * namespace.cs: Move the global functionality of Namespace
7825 to GlobalRootNamespace/RootNamespace. Now the global namespace
7826 is GlobalRootNamespace.Globa. Also the code moved from
7827 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
7828 Finally added LocalAliasEntry (AliasEntry before) and
7829 ExternAliasEntry, to handle alias statements.
7830 * cs-parser.jay: Add support in the grammar for extern alias
7832 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
7833 Update callings to Namespace (now in GlobalRootNamespace).
7835 2005-10-18 Raja R Harinath <rharinath@novell.com>
7838 * class.cs (TypeContainer.DefineType): Move updating of
7839 topological sort earlier in the code.
7840 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
7842 2005-10-18 Marek Safar <marek.safar@seznam.cz>
7845 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
7847 * constant.cs (Constant.TryReduce): Moved from Cast class.
7848 (Reduce): Made little bit more OO and fixed missing conversions.
7850 * ecore.cs (Reduce): Implemented.
7851 (Binary.EnumLiftUp): New method to upgrade values to enum values.
7853 * literal.cs (Reduce): Implemented.
7855 * class.cs: Reverted Miguel's wrong commit.
7857 2005-10-14 Miguel de Icaza <miguel@novell.com>
7859 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7861 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7863 * cs-parser.jay, expression.cs : CS0214 was missing error location
7864 for constants. Fixed bug #76404.
7866 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7869 * convert.cs (ExplicitConversionCore): Fixed object->enum
7872 2005-10-10 Raja R Harinath <rharinath@novell.com>
7874 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7876 (PropertyExpr.EmitCall): Likewise.
7877 * expression.cs (Invocation.EmitArguments): Handle case where
7879 (Invocation.EmitCall): Avoid allocating temporary variable if
7880 there are no arguments.
7882 2005-10-07 Raja R Harinath <rharinath@novell.com>
7885 * convert.cs (ImplicitConversionStandard): Move conversion of
7886 void* to arbitrary pointer types ...
7887 (ExplicitConversionStandard): .. here.
7888 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7889 error to always print typenames.
7891 2005-10-07 Raja R Harinath <rharinath@novell.com>
7893 * convert.cs (GetConversionOperator): Rename from
7894 GetConversionOperators. Move operator selection code from ...
7895 (UserDefinedConversion): ... here.
7897 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7899 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7902 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7904 * assign.cs (Assign.DoResolve): Error method changed.
7906 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7908 * const.cs (ResolveValue): Reset in_transit immediately.
7910 * constant.cs: Error method changed.
7912 * convert.cs: Removed useless location parameter.
7913 (ExplicitNumericConversion): Don't do double enum check.
7914 (ExplicitConversionCore): Renamed from ExplicitConversion.
7915 (ExplicitUnsafe): Extracted from ExplicitConversion.
7916 (ExplicitConversion): Uses for error reporting.
7918 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7920 (ResolveBoolean): Uses common error method.
7921 (CastToDecimal): Get rid of ec.
7922 (CastFromDecimal): Optimized.
7923 (ConvCast): Get rid of ec.
7925 * enum.cs (ResolveValue): Reset in_transit immediately.
7926 (Emit): Return after first error.
7928 * expression.cs: Convert changes.
7930 * literal.cs: Error method changed.
7932 * statement.cs: Error method changed.
7934 2005-10-03 Raja R Harinath <rharinath@novell.com>
7936 * support.cs (SeekableStreamReader.Position): Don't error out when
7937 the requested position is just beyond the end of the current
7940 2005-09-28 Raja R Harinath <rharinath@novell.com>
7942 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7943 try to keep in sync with the byte count of the underlying Stream.
7944 However, this limits us to a window size of 2048 characters: i.e.,
7945 the maximum lookahead of our lexer/parser can be 2048 characters.
7947 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7950 * driver.cs: Fix compilation files with full root path.
7952 2005-09-25 Miguel de Icaza <miguel@novell.com>
7954 * report.cs (SymbolRelatedToPreviousError): Format the output so
7955 it does not use an open parenthesis that is never closed.
7957 * driver.cs: Follow coding guidelines
7959 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7962 * const.cs (Const.ResolveValue): Check for assigning non-null
7963 value to reference type.
7965 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7967 * anonymous.cs: Implemented ExprClassName.
7969 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7972 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7975 * class.cs (StaticClass.DefineContainerMembers): Report protected
7978 * codegen.cs: if(ed) PRODUCTION.
7980 * convert.cs (Error_CannotImplicitConversion): Better error
7983 * cs-parser.jay: More error checks.
7985 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
7987 * driver.cs (CSCParseOption): Enabled wrong option check.
7989 * ecore.cs (Expression.ExprClassName): Turned to property.
7990 (MemberExpr.CheckIntermediateModification): For checking boxed
7991 value types modification.
7993 * statement.cs (Fixed.Resolve): Expression type must be
7994 convertible to fixed type.
7995 (CollectionForeach.GetEnumeratorFilter,TryType):
7996 Small refactoring for easier error checking.
7998 2005-09-26 Marek Safar <marek.safar@seznam.cz>
8000 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
8003 * class.cs (GeneratedBaseInitializer): New class for customization
8004 compiler generated initializers.
8005 (MemberBase.DoDefine): Check Obsolete attribute here.
8006 (FieldMember.DoDefine): Ditto.
8008 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
8011 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
8012 (MemberCore.GetObsoleteAttribute): Removed argument.
8013 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
8014 (MemberCore.CheckObsoleteType): New helper.
8018 * statement.cs: Updates after MemberCore changes.
8020 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
8021 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
8023 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
8024 obsolete attribute for compiler construct.
8025 (As.DoResolve): Cache result.
8027 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
8029 2005-09-26 Raja R Harinath <rharinath@novell.com>
8032 * expression.cs (This.VerifyFixed): In a value type T, the type of
8033 'this' is T&, iow, 'this' is either an out or ref parameter. In a
8034 value type R, 'this' is treated as a value parameter.
8036 2005-09-22 Miguel de Icaza <miguel@novell.com>
8038 * statement.cs (Lock): Use the TemporaryVariable class instead of
8039 manually using local variables as those do not work when variables
8042 * ecore.cs: Moved the TemporaryVariable class from being a nested
8043 class inside Foreach to be a public class that can be employed in
8046 2005-09-19 Marek Safar <marek.safar@seznam.cz>
8048 * cs-parser.jay: interface_accessors replaced by
8049 accessor_declarations.
8051 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
8054 * statement.cs (GotoCase.Resolve): Convert null constant to
8056 (SwitchLabel.ResolveAndReduce): Ditto.
8057 (SwitchLabel.NullStringCase): Custom null stamp.
8058 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
8060 typemanager.cs (CSharpSignature): Don't skip first argument
8063 2005-09-18 Miguel de Icaza <miguel@novell.com>
8065 * driver.cs: Set InEmacs based on the environment variable EMACS.
8067 * location.cs (InEmacs): in this mode, do not report column
8068 location as it confuses Emacs.
8070 2005-09-16 Marek Safar <marek.safar@seznam.cz>
8072 * cfold.cs, constant.cs, convert.cs, ecore.cs,
8073 expression.cs, iterators.cs, literal.cs: Store constants and
8076 * class.cs (MemberBase.ShortName): Pass location.
8078 * cs-parser.jay: Some location fixes.
8080 * ecore.cs (Expression.Location): Made virtual.
8082 2005-09-05 Miguel de Icaza <miguel@novell.com>
8084 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
8085 if the underlying types are the same, otherwise we need to produce
8086 code that will do the proper cast.
8088 This was exposed by Marek's constant rewrite which produced
8089 invalid code for the call site:
8092 void Method (X v) {}
8096 This fixes test-49.cs
8098 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8100 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
8101 Type/Object should be allowed as well. Fixed bug #75968.
8103 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8105 * expression.cs : (Binary.DoResolve): when one is enum constant and
8106 another is constant 0, then return enum one *as enum type*.
8109 2005-09-02 Raja R Harinath <rharinath@novell.com>
8111 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
8115 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
8116 flow-branching for LocalVariableReferences in case we were invoked
8117 from a MemberAccess.
8118 * expression.cs (LocalVariableReference.VerifyAssigned): New.
8120 (LocalVariableReference.DoResolveBase): ... this.
8121 (MemberAccess.Resolve): Do the check that was disabled during
8124 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8127 (PartialContainer.Create): check abstract/sealed/static strictly
8128 but abstract/sealed can exist only at one side. Fixed bug #75883.
8130 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
8133 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
8134 specified, don't default to UnmanagedType.I4.
8136 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8138 * expression.cs : conditional operator should check possibly
8139 incorrect assign expression. Fixed bug #75946.
8141 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8143 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
8144 Reverting the change. gmcs is much complex than mcs on this matter.
8146 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8148 * cs-tokenizer.cs : To read another token ahead of the actual
8149 consumption, use new SavedToken and cache token instead of moving
8150 back the stream with SeekableStreamReader (it seemed problematic).
8152 driver.cs : Thus use StreamReader directly.
8153 * support.cs : Thus removed SeekableStreamReader.
8155 2005-08-30 Raja R Harinath <rharinath@novell.com>
8158 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
8159 (ScopeInfo.EmitScopeType): Use it to construct field names from
8160 names of captured locals.
8163 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
8164 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
8165 Pass 'target_type' to BoxedCast. Don't default to 'object'.
8166 (ExplicitConversion): Remove enum cases already handled by
8167 implicit conversion. Move implicit conversion check to the beginning.
8168 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
8169 * expression.cs (ArrayCreation.EmitDynamicInitializers):
8170 Don't treat System.Enum as a struct.
8172 2005-08-30 Jb Evain <jbevain@gmail.com>
8174 * attribute.cs: handles as expression in parameters.
8176 2005-08-30 Raja R Harinath <rharinath@novell.com>
8179 * class.cs (TypeContainer.VerifyClsName): Don't use a
8180 PartialContainer when verifying CLS compliance.
8181 (AbstractPropertyEventMethod): Set Parent here, ...
8182 (PropertyMethod): ... not here.
8184 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
8186 * attribute.cs : escaped attribute name should not be allowed to be
8187 resolved (e.g. @class as classAttribute). Fixed bug #75930.
8189 2005-08-29 Raja R Harinath <rharinath@novell.com>
8192 * convert.cs (ImplicitStandardConversionExists): Allow zero also
8193 when converting a long constant to unsigned long.
8194 * expression.cs (Invocation.OverloadResolve): Add sanity check to
8195 detect where IsApplicable and VerifyArgumentsCompat disagree.
8197 2005-08-29 Raja R Harinath <rharinath@novell.com>
8198 and Carlos Alberto Cortez <carlos@unixmexico.org>
8201 * class.cs (TypeContainer.CanElideInitializer): New helper.
8202 (TypeContainer.EmitFieldInitializers): Use it to determine if we
8203 can safely emitting the initializer of a field.
8205 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8207 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
8208 allowed inside a switch (without loop). Fixed bug #75433.
8210 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
8212 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
8213 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
8215 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8217 * driver.cs : kinda reverting the default encoding changes (not exact
8218 revert since I noticed that "codepage:reset" might not work fine).
8220 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8222 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
8223 Location. Now getter and setter store location correctly.
8224 (errors/cs0111-12.cs now reports the expected location.)
8226 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8228 * driver.cs : Use default encoding on the environment.
8229 Removed (now that) extra parameter for SeekableStreamReader.
8230 * support.cs : (SeekableStreamReader) third .ctor() argument for
8231 StreamReader is not required (always true). preamble size could
8232 be acquired in simpler and safe way.
8234 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
8236 * cs-parser.jay: report CS0642 at warning level 3
8237 and report CS0642 for an if else statement also
8238 fixes bug #74745. Patch by John Luke (and a bit
8240 Removed extra CS0642 warning check for "while",
8242 * statement.cs: In Block.Resolve(), CS0642 check
8243 is reimplemented to check a sequence of an empty
8244 statement and a block.
8246 Both fix bug #66777.
8248 2005-08-24 Marek Safar <marek.safar@seznam.cz>
8250 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
8251 detection until I fix it.
8253 * cs-tokenizer.cs: Changed error message.
8255 * cs-parser.jay: Fixed 2 error locations.
8257 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
8258 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
8261 * enum.cs (GetSignatureForError): Fixed.
8263 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
8267 * typemanager.cs (RegisterProperty): Removed.
8269 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
8271 2005-08-24 Raja R Harinath <rharinath@novell.com>
8274 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
8275 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
8277 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8279 * expression.cs : tiny fix is required for not warning positive ulong.
8282 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8284 * expression.cs : add CS0652 check for constant and integral
8285 expression. Fixed bug #53974.
8287 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8289 * expression.cs : in DoNumericPromotions(), check if there is implicit
8290 conversion overload for string (to check CS0034). Fixed bug #52492.
8292 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8294 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
8296 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8298 * ecore.cs : report location when it is *not* Null.
8300 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8306 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
8307 correctly. Fixed bug #75721.
8309 2005-08-23 Raja R Harinath <rharinath@novell.com>
8311 * support.cs (SeekableStreamReader.Position): Avoid an expensive
8312 loop that performs 'min (pos, char_count)'.
8315 * expression.cs (Unary.ResolveOperator): Don't discard implicit
8316 converted value in Operator.OnesComplement.
8318 2005-08-22 Ben Maurer <bmaurer@ximian.com>
8320 * anonymous.cs: If the anon method is pulled into a helper class,
8321 it needs to be `internal' not `private'. Fixes runtime behavior on
8324 2005-08-20 Martin Baulig <martin@ximian.com>
8326 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
8327 scope if we don't already have it.
8329 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
8330 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
8333 2005-08-17 Marek Safar <marek.safar@seznam.cz>
8336 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
8339 2005-08-16 Marek Safar <marek.safar@seznam.cz>
8341 The big constants rewrite
8342 Fix #75746, #75685 and more
8343 As a side effect saved 1MB for MWF ;-)
8345 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
8346 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
8347 enum based for corlib compilation.
8349 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
8352 * class.cs (FixedField.Define): Use ResolveAsConstant.
8354 * const.cs (IConstant): Interface constants and enums.
8355 (Const.ResolveValue): New method for constant resolvning.
8356 (ExternalConstant): Constants from imported assemblies.
8358 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
8359 conversion; like enums.
8360 (Constant.ToType): Converts this constant to different type.
8361 (Constant.Increment): Adds 1.
8363 * convert.cs (ImplicitConversionRequired): Simplified.
8365 * cs-parser.jay: Create EnumMember directly.
8367 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
8369 * doc.cs (GenerateEnumDocComment): Removed.
8371 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
8372 (ConvertIntLiteral): Removed.
8373 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
8375 * enum.cs (EnumMember): Implement IConstant.
8376 (Enum.IsValidEnumConstant): Removed.
8377 (Enum.GetNextDefaultValue): Removed.
8378 (Enum.FindMembers): Updated.
8379 (Enum.GenerateDocComment): Iterate enum members.
8381 * expression.cs (Cast.TryReduce): Handle enums correctly.
8382 (New.Constantify): Made public.
8383 (MemberAccess.DoResolve): Removed contant specific if(s).
8385 * literal.cs (NullLiteral): Implement new abstract methods.
8387 * statement.cs (GotoCase.Resolve): Use new constant methods.
8388 (SwitchLabel.ResolveAndReduce): Use new constant methods.
8390 * typemanager.cs (LookupEnum): Removed.
8391 (IsEnumType): Fixed to work with corlib.
8392 (RegisterConstant): Removed.
8393 (LookupConstant): Removed.
8394 (GetConstant): Changed to work with IConstant.
8396 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
8398 * location.cs : Fixed overflown (>255) column number.
8400 2005-08-03 Raja R Harinath <rharinath@novell.com>
8402 First cut of the qualified-alias-member feature.
8403 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
8405 * cs-parser.jay (DOUBLE_COLON): New token.
8406 (namespace_or_type_name): Add rule for recognizing
8407 qualified-alias-members.
8408 (primary_expression): Likewise.
8409 (element_access): Allow QualifiedAliasMember as a possible
8410 type-bearing expression.
8411 (local_variable_type, local_variable_pointer_type): Likewise.
8412 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
8413 aliases in the current and enclosing namespace declarations.
8414 (NamespaceEntry.UsingAlias): Add CS0440 warning.
8415 * decl.cs (MemberName.is_double_colon): New.
8416 (MemberName.MemberName): Add new constructor for alias-member.
8417 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
8418 * expression.cs (QualifiedAliasMember): New expression type.
8420 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8422 * location.cs : it borked when no argument was specified.
8424 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8426 * location.cs : tiny ToString() format fix.
8428 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8430 * statement.cs : oops, it was missing.
8432 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8434 A set of fixes for precise line/column location.
8437 "token" field now holds a file/line "delta", a line number offset
8438 from the segment, and a column number. See also:
8439 http://lists.ximian.com/pipermail/mono-devel-list/2004-
8440 December/009508.html
8441 Removed static IsNull. Use instance IsNull property instead.
8443 For some tokens it stores Location. For Identifier it stores
8444 LocatedToken which is a pair of string name and location.
8445 Column numbers are adjusted only at getChar().
8447 Use Location.ToString() for reporting (it now contains column).
8449 Largely modified to use LocatedToken instead of
8450 string (IDENTIFIER), and to acquire Location from some tokens.
8451 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
8452 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
8454 Now MemberName holds Location. DeclSpace.ctor() receives Location
8455 as a parameter. Removed extra parameters to all derived classes.
8456 Replaced Location.IsNull() with instance property.
8457 * assign.cs, expression.cs :
8458 Added .ctor() overload that omits Location.
8460 Added "nameEscaped" flag that indicates the identifier was escaped
8461 in the source file. This fixes bug #57047.
8463 2005-08-02 Marek Safar <marek.safar@seznam.cz>
8465 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
8466 New method, looking for lo-case imported cls type.
8468 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
8471 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
8473 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
8475 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
8477 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
8479 Optimized to save 3.5 MB for SWF compilation.
8481 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8483 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
8484 (PartialContainer.Create): Moved logic AddToContainer.
8485 (PartialContainer.MarkForDuplicationCheck): Shares name.
8487 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
8490 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
8492 (Namespace.GetSignatureForError): New method.
8494 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
8495 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
8497 2005-08-01 Raja R Harinath <rharinath@novell.com>
8500 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
8501 member lookup rather than qualifier_type, since qualifier_type can
8504 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8506 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
8509 2005-07-31 Miguel de Icaza <miguel@novell.com>
8511 * statement.cs: Copy the local exception into the exception
8512 captured local. Fixes 75674
8514 2005-07-31 Raja R Harinath <harinath@gmail.com>
8517 * expression.cs (Invocation.OverloadResolve): Don't report error
8518 CS1501 if error CS1502 has been reported.
8519 (New.DoResolve): Delegate CS1501 reporting to
8520 Invocation.OverloadResolve.
8523 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
8524 invariant-meaning-in-block property in an enclosing block if
8527 2005-07-29 Marek Safar <marek.safar@seznam.cz>
8529 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
8530 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
8531 (Switch.CheckSwitch): Just save 50kb for SWF.
8533 2005-07-27 Martin Baulig <martin@ximian.com>
8535 * anonymous.cs (CaptureContext.AddField): Added
8536 `AnonymousContainer am' argument; compute its toplevel scope if
8537 it's not already computed. Fixes #75649.
8539 2005-07-26 Raja R Harinath <rharinath@novell.com>
8542 * class.cs (Constructor.Emit): Reset block to null if the block
8545 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8547 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
8549 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8551 * class.cs (MethodData.Define): Check whether accessor implementing
8552 interface is public.
8554 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
8556 2005-07-22 Marek Safar <marek.safar@seznam.cz>
8559 * namespace.cs (LookupType): Moved same type check to...
8561 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
8564 2005-07-21 Raja R Harinath <rharinath@novell.com>
8566 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
8567 already found a typebuilder.
8568 * class.cs (MethodCore.IsDuplicateImplementation): Compare
8569 MemberNames, not strings.
8571 * const.cs (Error_ExpressionMustBeConst):
8572 Rename from Error_EpressionMustBeConst.
8573 * const.cs, class.cs, statement.cd: Update.
8575 2005-07-21 Marek Safar <marek.safar@seznam.cz>
8579 * const.cs (Const.LookupConstantValue): Report missing contant expression
8581 (Error_EpressionMustBeConstant): Only one error method.
8583 * class.cs, statement.c: Updated.
8585 2005-07-20 Raja R Harinath <rharinath@novell.com>
8587 * statement.cs (Block.Flags): Add back HasVarargs.
8588 (Block.flags): Make protected.
8589 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
8591 * typemanager.cs (types, typecontainers, user_types): Remove.
8592 (UserTypes, TypeContainers): Likewise.
8593 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
8594 (CleanUp, Reset): Update.
8595 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
8596 (GetNestedType): Use Type.GetNestedType.
8597 (CoreLookupType): Take two arguments, the namespace and the
8598 basename of the type. Update to use the Namespace.Lookup
8600 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
8601 (RealMemberLookup): Use IsNestedChildOf instead of playing with
8602 string concatenation and substring matches.
8603 * class.cs, enum.cs, delegate.cs: Update to changes.
8605 2005-07-20 Marek Safar <marek.safar@seznam.cz>
8607 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
8608 Expression and made virtual.
8610 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
8611 (ImplicitStandardConversionExists): Fixed `byte' typo ?
8613 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
8615 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
8618 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
8621 2005-07-18 Marek Safar <marek.safar@seznam.cz>
8624 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
8625 AssemblyCultureAttribute is not used on executable.
8628 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
8630 2005-07-16 Raja R Harinath <rharinath@novell.com>
8633 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
8634 New. Reports CS0252/CS0253.
8635 Mostly taken from preliminary patch by Duncak Mak.
8636 (Binary.DoResolveOperator): Store results of operator lookup.
8637 Use them to detect if we need to warn about unintended reference
8640 2005-07-15 Raja R Harinath <rharinath@novell.com>
8643 * namespace.cs (Namespace.Lookup): Add back location parameter.
8644 (Namespace.LookupType): Add CS0436 report. Add location parameter.
8645 * delegate.cs, ecore.cs, expression.cs: Update to changes.
8647 * codegen.cs (EmitContext.DeclSpace): Make readonly.
8648 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
8649 (Namespace.LookupType): ... this.
8650 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
8652 * typemanager.cs (LookupTypeReflection): Remove buggy code that
8653 purported to handle pointers.
8654 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
8657 2005-07-15 Marek Safar <marek.safar@seznam.cz>
8659 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
8662 2005-07-15 Raja R Harinath <rharinath@novell.com>
8664 * namespace.cs (Namespace.Lookup): Drop location parameter.
8665 (NamespaceEntry.LookupAlias): Remove. Merge into ...
8666 (NamespaceEntry.Lookup): ... this.
8667 (NamespaceEntry.Error_AmbiguousTypeReference):
8668 Move here from DeclSpace.
8669 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
8671 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
8672 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
8673 Move to NamespaceEntry.
8674 * delegate.cs, expression.cs: Update to changes.
8676 2005-07-14 Marek Safar <marek.safar@seznam.cz>
8678 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
8679 CheckAttributeType and refactored.
8680 (Attribute.ResolvePossibleAttributeType): Changed to reuse
8681 ResolveAsTypeTerminal error handling.
8682 (ResolveAsTypeTerminal): Introduced because of global attributes extra
8684 (GetSignatureForError): Print errors in same way.
8687 * codegen.cs: Reflect attribute GetSignatureForError change.
8690 * expression.cs: Add silent parameter to ResolveAsTypeStep.
8692 * namespace.cs (UsingEntry): Refactored to make fields private.
8695 statement.cs: Error_UnexpectedKind has extra parameter.
8697 2005-07-14 Raja R Harinath <rharinath@novell.com>
8699 * ecore.cs (IAlias): Remove.
8700 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
8701 that implement the interface.
8702 * namespace.cs (Namespace): Likewise.
8703 (Namespace.declspaces): Renamed from 'defined_names'.
8704 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
8705 DeclSpace instead of an IAlias.
8706 * tree.cs (Tree.AddDecl): Update.
8708 2005-07-12 Raja R Harinath <rharinath@novell.com>
8710 * statement.cs (Block.Flags); Remove HasVarargs.
8711 (Block.HasVarargs): Move to ToplevelBlock.
8712 (Block.ThisVariable, Block.AddThisVariable): Likewise.
8713 (Block.Variables): Make protected. Initialize variable hashtable
8715 (Block.AddVariable): Update.
8716 (Block.Resolve): Update to changes.
8717 (ToplevelBlock.HasVarargs): New boolean.
8718 (ToplevelBlock.ThisVariable): Move here from Block.
8719 (ToplevelBlock.AddThisVariable): Likewise.
8720 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
8721 * expression.cs (This.ResolveBase): Update to changes.
8722 (ArglistAccess.DoResolve): Likewise.
8724 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8727 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
8729 * class.cs (TypeContainer.VerifyMembers): Distinguish between
8730 not used and not used & assigned.
8731 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
8733 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8736 * expression.cs (Is.DoResolve): null is never provided type.
8738 2005-07-08 Marek Safar <marek.safar@seznam.cz>
8741 * cs-parser.jay: Less strict event error rule to catch more errors.
8743 2005-07-08 Martin Baulig <martin@ximian.com>
8745 Fix test-iter-10.cs - distinguish whether we `yield' in a property
8746 gettter (allowed) or setter (not allowed).
8748 * class.cs (Accessor): Implement IIteratorContainer.
8749 (Accessor.Yields): New public field.
8750 (PropertyBase.PropertyMethod.Define): Handle iterators on a
8754 (get_accessor_declaration, set_accessor_declaration): Set the
8755 `yields' flag on the accessor, not the property.
8756 (property_declaration): Do the iterators check on a per-accessor
8757 basis and not for the whole property.
8759 2005-07-08 Martin Baulig <martin@ximian.com>
8761 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
8762 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
8764 2005-07-07 Marek Safar <marek.safar@seznam.cz>
8767 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
8768 (ExtractSecurityPermissionSet): Cope with self referencing security
8769 attributes properly.
8771 * driver.cs (SetOutputFile): Made public property OutputFile.
8773 2005-07-07 Raja R Harinath <rharinath@novell.com>
8776 * class.cs (TypeContainer.first_nonstatic_field): Rename from
8777 has_nonstatic_fields. Make into a FieldBase pointer.
8778 (TypeContainer.AddField): Add CS0282 check.
8779 (TypeContainer.EmitType): Update.
8781 2005-07-06 Miguel de Icaza <miguel@novell.com>
8783 * cs-tokenizer.cs (consume_identifier): Do not create strings to
8784 compare if they start with __.
8786 2005-07-06 Raja R Harinath <rharinath@novell.com>
8788 * statement.cs (Switch.SwitchGoverningType): Only look at
8789 UserCasts that don't need implicit standard conversions to one of
8790 the allowed switch types (Fixes test-322.cs).
8791 (LocalInfo.Resolve): Re-enable sanity-test.
8793 2005-07-06 Marek Safar <marek.safar@seznam.cz>
8795 * cs-tokenizer.cs (consume_identifier): Detect double undescores
8797 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
8799 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
8801 2005-07-06 Raja R Harinath <rharinath@novell.com>
8804 * ecore.cs (SimpleName.GetSignatureForError): Add.
8805 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
8806 (MemberAccess.GetSignatureForError): Add.
8808 2005-07-05 Marek Safar <marek.safar@seznam.cz>
8810 The big error and warning messages review.
8840 * typemanager.cs: Updated.
8842 * class.cs: (MethodCore.SetYields): Moved here to share.
8843 (PropertyMethod.Define): Moved iterator setup here.
8845 * iterators.cs: Add orig_method to have full access to parent
8848 2005-07-05 Raja R Harinath <rharinath@novell.com>
8850 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
8851 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
8852 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
8853 variable of struct type.
8854 * expression.cs (Unary.ResolveOperator): Update to change.
8855 (Indirection.VerifyFixed): Likewise.
8856 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8857 (ParameterReference.VerifyFixed): Value parameters are fixed.
8858 (This.VerifyFixed): Treat 'this' as a value parameter.
8859 * statement.cs (LocalInfo.IsFixed): Remove.
8861 2005-07-01 Martin Baulig <martin@ximian.com>
8863 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8864 `ec.EmitThis ()' to get the correct scope.
8866 2005-07-01 Martin Baulig <martin@ximian.com>
8868 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8869 instance is a ParameterReference; fixes #75299.
8871 2005-07-01 Martin Baulig <martin@ximian.com>
8873 Reverted Marek's latest patch (r46725):
8874 - it contains structural changes which are neither mentioned in
8875 the ChangeLog nor explained anywhere; for example the additional
8876 argument of EmitContext's and Iterator's .ctor's and the
8877 TypeContainer.DefineMembers() change.
8878 - structural changes like this should go in in seperate patches
8879 and not be hidden in a huge patch which just seems to affect
8880 warnings and errors.
8881 a big and hard to understand patch.
8882 - it breaks iterators and causes regressions, for instance in
8885 2005-06-30 Raja R Harinath <rharinath@novell.com>
8888 * expression.cs (Indexers.map): Remove.
8889 (Indexers.Append): Filter out inaccessible setters and getters.
8890 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8893 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8895 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8896 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8897 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8898 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8900 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8903 * class.cs (FieldBase.GetInitializerExpression): One more field
8906 2005-06-28 Miguel de Icaza <miguel@novell.com>
8908 * pending.cs: Do not define a proxy if the base method is virtual,
8909 it will be picked up by the runtime (bug 75270).
8911 2005-06-08 Martin Baulig <martin@ximian.com>
8913 The big Iterators rewrite :-)
8915 * iterators.cs: Rewrite this to use the anonymous methods framework.
8917 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8918 before the TypeContainers; see 2test-21.cs.
8921 (TypeContainer.DefineType): Don't create a new EmitContext if we
8922 already have one (this only happens if we're an Iterator).
8923 (TypeContainer.Define): Also call Define() on all our iterators.
8924 (Method.CreateEmitContext): Added support for iterators.
8927 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8928 (AnonymousContainer.CreateMethodHost): Moved here from
8929 AnonymousMethod and made abstract.
8930 (AnonymousContainer.CreateScopeType): New abstract method.
8931 (AnonymousContainer.IsIterator): New public property.
8932 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8933 get the ScopeTypeBuilder rather than manually defining it here.
8934 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8937 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8938 before RootContext.DefineTypes().
8940 * codegen.cs (EmitContext.RemapToProxy): Removed.
8941 (EmitContext.CurrentAnonymousMethod): Changed type from
8942 AnonymousMethod -> AnonymousContainer.
8943 (EmitContext.ResolveTopBlock): Protect from being called twice.
8944 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8945 (EmitContext.EmitThis): Removed the iterators hacks; use the
8946 anonymous methods framework for that.
8949 (ToplevelBlock.Container): Make this a property, not a field.
8950 (ToplevelBlock.ReParent): New public method; move the
8951 ToplevelBlock into a new container.
8952 (Foreach.TemporaryVariable): Simplify.
8954 2005-06-05 Martin Baulig <martin@ximian.com>
8956 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8957 (Block.AddTemporaryVariable): New public method; creates a new
8958 `LocalInfo' for a temporary variable.
8959 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8961 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8962 non-iterator variables.
8964 2005-06-05 Martin Baulig <martin@ximian.com>
8966 * statement.cs (Foreach.TemporaryVariable): Create the
8967 LocalBuilder in the Emit phase and not in Resolve since in some
8968 situations, we don't have an ILGenerator during Resolve; see
8969 2test-19.cs for an example.
8971 2005-06-04 Martin Baulig <martin@ximian.com>
8973 **** Merged r45395 from GCS ****
8975 The big Foreach rewrite - Part II.
8977 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
8978 with `PropertyInfo ienumerator_getcurrent'.
8980 * codegen.cs (VariableStorage): Removed.
8983 (Foreach): Derive from Statement, not ExceptionStatement.
8984 (Foreach.CollectionForeach): New nested class. Moved all the code
8985 dealing with collection foreach here.
8986 (Foreach.ForeachHelperMethods): Removed.
8987 (Foreach.TemporaryVariable): Implement IMemoryLocation.
8989 2005-05-23 Martin Baulig <martin@ximian.com>
8991 * statement.cs (Try.DoResolve): Don't create a `finally' if we
8992 don't need to. Fix #75014.
8994 2005-05-20 Martin Baulig <martin@ximian.com>
8996 Merged r44808 from GMCS.
8998 * class.cs (TypeContainer.CircularDepException): Removed.
8999 (TypeContainer.DefineType): Removed the `InTransit' stuff.
9000 (TypeContainer.CheckRecursiveDefinition): Check for circular class
9001 (CS0146) and interface (CS0529) dependencies here.
9003 2005-06-21 Raja R Harinath <rharinath@novell.com>
9005 * expression.cs (Invocation.EmitCall): Fix initialization
9006 'this_call' to reflect current behaviour. Fix indentation.
9008 * convert.cs (FindMostEncompassedType): Add two trivial special
9009 cases (number_of_types == 0 || number_of_types == 1).
9010 (FindMostEncompasingType): Likewise.
9012 2005-06-17 Raja R Harinath <rharinath@novell.com>
9014 Some cleanups preparing for the fix of #75283.
9015 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
9017 (EventExpr.InstanceResolve): Likewise.
9018 (EventExpr.DoResolve): Remove redundant checks.
9020 2005-06-10 Duncan Mak <duncan@novell.com>
9022 * cs-tokenizer.cs (process_directives): New flag for controlling
9023 the processing of preprocessor directives.
9024 (x_token): After seeing a '#', return Token.NONE instead of going
9025 to handle_preprocessing_directive() when not processing
9026 directives. This avoids unnecessary processing during the token peek in
9031 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
9032 the existing error reporting methods instead of Report.Error.
9034 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
9035 after Raja's rewrite.
9037 2005-06-08 Miguel de Icaza <miguel@novell.com>
9039 * class.cs: Small fix.
9041 2005-06-08 Raja R Harinath <rharinath@novell.com>
9044 * class.cs (GetPartialBases): Fix return value check of
9047 2005-06-07 Raja R Harinath <rharinath@novell.com>
9049 Ensure that partial classes are registered in their enclosing
9050 namespace. Initial part of fix of #75160.
9051 * tree.cs (Tree.RecordDecl): Add new namespace argument.
9052 Register declspace with namespace here, not in
9053 DeclSpace.RecordDecl.
9054 * cs-parser.jay: Pass namespace to RecordDecl.
9055 * class.cs (PartialContainer.Create): Likewise.
9056 (ClassPart.DefineType): New sanity-check. Throws an exception if
9058 * decl.cs (Declspace.RecordDecl): Remove.
9059 * namespace.cs (NamespaceEntry.DefineName): Remove.
9061 2005-06-06 Marek Safar <marek.safar@seznam.cz>
9063 * rootcontext.cs: Reset TargetExt as well.
9065 2005-06-03 Raja R Harinath <rharinath@novell.com>
9067 * ecore.cs (Expression.Resolve): Emit CS0654 error when
9070 2005-06-02 Raja R Harinath <rharinath@novell.com>
9072 Fix #75080, cs0119.cs.
9073 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
9075 (Expression.Resolve): ... this. Use it. Remove bogus code
9076 allowing ExprClass.Type and ExprClass.Namespace for
9077 ResolveFlags.VariableOrValue.
9078 (Expression.Resolve) [1-argument variant]: Change default resolve
9079 flags based on language version.
9080 (Expression.Error_UnexpectedKind): Use a simple string array
9081 rather than an ArrayList.
9082 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
9084 (TypeOfVoid.DoResolve): Likewise.
9085 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
9086 flags argument -- it always has the same value.
9088 2005-05-31 Raja R Harinath <rharinath@novell.com>
9091 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
9092 Use it in the error message.
9093 * assign.cs, expression.cs, statement.cs: Update.
9095 2005-05-30 Raja R Harinath <rharinath@novell.com>
9098 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
9099 the "almostMatchedMember" case too.
9100 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
9101 that failed the accessibility checks to 'almost_match'.
9103 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
9105 * attribute.cs: Use internal MethodBuilder methods to set
9106 ExactSpelling and SetLastError on PInvoke methods, instead
9107 of passing them via charset. Fixes #75060.
9109 2005-05-27 Raja R Harinath <rharinath@novell.com>
9111 * parameter.cs (Parameter): Remove TODO comment.
9112 (Parameter.DefineParameter): Remove Location parameter.
9113 (Parameters.LabelParameters): Likewise.
9114 * class.cs (Constructor.Emit): Update to change.
9115 (MethodData.Emit): Likewise.
9116 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
9117 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
9119 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
9122 Removed Parameters.Location and added Parameter.Location instead.
9123 Removed Location parameter from Emit() and GetSignature().
9130 Modified all related calls.
9132 2005-05-26 Raja R Harinath <rharinath@novell.com>
9134 Improve user-defined conversion handling.
9135 * convert.cs (GetConversionOperators): Rewrite. Return only the
9136 applicable operators.
9137 (AddConversionOperators): New. Helper for GetConversionOperators.
9138 (FindMostEncompassedType, FindMostEncompassingType): Verify that
9139 there is only one most encompassed/encompassing type.
9140 (FindMostSpecificSource, FindMostSpecificTarget): Remove
9141 "applicable operator" handling.
9142 (UserConversion): Move cache here from GetConversionOperators.
9143 Directly cache the chosen operator, rather than the whole
9145 (ExplicitNumericConversion): Fix buggy implementation of Decimal
9146 case. Allow conversion of decimal to sbyte and byte too.
9147 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9148 New static methods. Used to avoid allocating EmptyExpressions in
9151 2005-05-24 Duncan Mak <duncan@novell.com>
9153 * ecore.cs (CastFromDecimal): New class for casting a decimal to
9154 another class, used in Convert.ExplicitNumericConversion.
9155 (CastToDecimal): New class, similar to above, but casts to
9156 System.Decimal, used in Convert.ImplicitNumericConversion and also
9157 in explicit convesion from double/float to decimal.
9159 * convert.cs (ImplicitNumericConversion): Handle implicit
9160 conversions to System.Decimal.
9161 (ExplicitNumericConversion): handle explicit conversions to
9166 2005-05-20 Miguel de Icaza <miguel@novell.com>
9168 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
9169 know the type at this stage, just break through. Fixes #75008
9171 2005-05-19 Martin Baulig <martin@ximian.com>
9174 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
9175 to disable error reporting.
9177 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
9178 here since we don't want to report an error; see the new test-336.cs.
9180 2005-05-19 Raja R Harinath <rharinath@novell.com>
9182 * statement.cs (ToplevelBlock.GetParameterReference)
9183 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
9184 Move here from class Block.
9185 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
9186 * expression.cs (ParameterReference.DoResolveBase): Likewise.
9188 2005-05-18 Martin Baulig <martin@ximian.com>
9193 (FlowBranching.Reachability): Add non-static public And() and Or()
9195 (FlowBranchingSwitch): New class; do the `break_origins' thing
9196 like in FlowBranchingLoop.
9197 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
9198 reachability, not just locals and parameters.
9199 (FlowBranching.MergeChild): Remove some of the hacks for loop and
9200 switch; MergeBreakOrigins() now takes care of that.
9202 2005-05-18 Martin Baulig <martin@ximian.com>
9204 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9205 a loop and may leave it, reset the barrier; fixes #74974.
9207 2005-05-17 Marek Safar <marek.safar@seznam.cz>
9209 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
9212 * cs-parser.jay: Catch more lexical errors.
9214 * report.cs: Add one more Error method.
9217 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
9219 2005-05-17 Martin Baulig <martin@ximian.com>
9221 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
9224 2005-05-16 Raja R Harinath <rharinath@novell.com>
9226 Fix test-382.cs. Emit values of decimal constants.
9227 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
9229 (TypeContainer.AddField): ... this.
9230 (TypeContainer.EmitFieldInitializers): Allow the list of fields
9231 with initializers to include 'Const's.
9232 (ClassPart.RegisterFieldForInitialization): Forward to
9234 * const.cs (Const.Const): Pass initializer to base class.
9235 (Const.Define): In case of decimal constants, register them for
9236 initialization in a static constructor.
9238 2005-05-14 Martin Baulig <martin@ximian.com>
9240 * statement.cs (Block.Resolve): Correctly handle unreachable code;
9241 do not call ResolveUnreachable() on unreachable statements in
9242 here, see the comment in the source code.
9244 2005-05-13 Raja R Harinath <rharinath@novell.com>
9247 * expression.cs (BinaryResolveOperator): If one of the operands of
9248 an equality comparison is 'null' and the other is a pointer type,
9249 convert the null to a NullPointer.
9250 * convert.cs (ImplicitReferenceConversion): If the expression is a
9251 NullLiteral and the target type is a pointer type, return a
9252 NullPointer instead.
9253 (ImplicitConversionStandard): Likewise.
9255 2005-05-13 Marek Safar <marek.safar@seznam.cz>
9257 * cs-parser.jay: Set readonly context based on special constructs.
9259 * expression.cs (LocalVariableReference.DoResolveBase): Improved
9260 readonly variable error handling.
9262 * rootcontext.cs (EmitCode): Don't verify members when error
9265 * statement.cs (LocalInfo): Add reaodnly context information.
9266 (SetReadOnlyContext, GetReadOnlyContext): New methods.
9268 2005-05-13 Raja R Harinath <rharinath@novell.com>
9270 * statement.cs (Block.Resolve): Revert change below. Modify fix
9271 for #74041 to initialize 'resolved' to false only for explicit
9272 blocks. Fixes #74873.
9274 2005-05-12 Raja R Harinath <harinath@gmail.com>
9277 * typemanager.cs (unmanaged_enclosing_types): New.
9278 (IsUnmanagedType): Avoid infloops by using
9279 'unmanaged_enclosing_types' to talk with recursive invocations.
9281 2005-05-13 Martin Baulig <martin@ximian.com>
9283 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
9284 instance variable, not a local. Fix #74873.
9285 (Block.ResolveUnreachable): Set it to true here.
9287 2005-05-11 Duncan Mak <duncan@novell.com>
9289 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
9290 continuing to process for 'arg'.
9291 (handle_preprocessing_directive): Check the argument of the #endif
9292 directive and report error CS1025 if there are any trailing
9295 According to the C# spec, having even whitespace after the #endif
9296 directive is illegal; however, because we call arg.TrimEnd ()
9297 beforehand, we have the same behavior as csc, allowing whitespace
9298 after the directive.
9302 2005-05-11 Marek Safar <marek.safar@seznam.cz>
9306 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
9307 (Constructor.GetObsoleteAttribute): Implemented correctly.
9309 2005-05-10 Martin Baulig <martin@ximian.com>
9311 * support.cs (ReflectionParameters.ParameterModifier): Use
9312 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
9313 and `ParameterAttributes.In'. Fixes #74884.
9315 2005-05-10 Marek Safar <marek.safar@seznam.cz>
9317 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
9319 * expression.cs (Argument.GetParameterModifier): Turned to property.
9320 (Invocation.Error_InvalidArguments): Add more descriptive errors.
9322 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
9325 2005-05-09 Raja R Harinath <rharinath@novell.com>
9328 * decl.cs (MemberCache.AddMethods): Register override methods,
9329 rather than non-override methods.
9330 * typemanager.cs (RegisterOverride): New.
9331 (IsOverride): Update.
9333 2005-05-09 Marek Safar <marek.safar@seznam.cz>
9337 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
9338 recursive declaration.
9340 * statement.cs (Block.ResolveMeta): Report any error in resolving.
9342 2005-05-06 Marek Safar <marek.safar@seznam.cz>
9344 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
9346 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
9348 2005-05-05 Raja R Harinath <rharinath@novell.com>
9351 * decl.cs (DeclSpace.FamilyAccessible):
9352 Use TypeManager.IsNestedFamilyAccessible.
9354 Fix reopened #64812.
9355 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
9358 2005-05-04 Raja R Harinath <rharinath@novell.com>
9359 Abin Thomas <projectmonokochi@rediffmail.com>
9360 Anoob V E <projectmonokochi@rediffmail.com>
9361 Harilal P R <projectmonokochi@rediffmail.com>
9364 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
9365 allow access to all static members.
9367 2005-05-04 Martin Baulig <martin@ximian.com>
9369 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
9371 2005-05-04 Martin Baulig <martin@ximian.com>
9375 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
9376 section at the end; make things work if `default' is not the last
9379 2005-05-04 Martin Baulig <martin@ximian.com>
9383 * statement.cs (Switch): Replaced the `got_default' field with a
9384 `default_section' one.
9385 (Switch.CheckSwitch): Set `default_section' here.
9386 (Switch.Resolve): If we're a constant switch and the constant is
9387 not found, use the default section.
9389 2005-05-03 Martin Baulig <martin@ximian.com>
9391 * expression.cs (ArrayAccess.EmitGetLength): New public method.
9393 * statement.cs (Foreach.ArrayForeach): New nested class.
9394 (Foreach.TemporaryVariable): New nested class.
9395 (Foreach.EmitArrayForeach): Removed; this is now in the new
9398 2005-05-03 Raja R Harinath <rharinath@novell.com>
9400 * pending.cs (BaseImplements): Move the #74773 fix here. This is
9402 (VerifyPendingMethods): Revert change below.
9404 * typemanager.cs (IsOverride, RegisterNonOverride): New.
9405 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
9406 that used to trigger warning -28. Remove warning -28.
9407 * expression.cs (Invocation.OverloadResolve): Use
9408 TypeManager.IsOverride to distinguish override methods.
9411 * pending.cs (VerifyPendingMethods): If a base type implements the
9412 requested interface, don't bother checking individual methods of
9413 the base type. As a side-effect, this prevents the creation of
9414 unnecessary proxies.
9416 2005-05-02 Martin Baulig <martin@ximian.com>
9420 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9421 Also `And' the locals if the old vector is null.
9422 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
9423 null; in this case we basically reset all the variables.
9425 2005-05-02 Martin Baulig <martin@ximian.com>
9429 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
9430 Added `FlowBranching branching' argument; always `and' the
9431 variables instead of `or'ing them unless we're an infinite loop.
9433 * statement.cs (While.Resolve): Create a new sibling unless we're
9436 2005-05-02 Martin Baulig <martin@ximian.com>
9440 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
9441 arguments; use it instead of creating a new TopLevelBlock.
9442 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
9443 our ConstructorInitializer.
9446 (TopLevelBlock.TopLevelBranching): New public property.
9447 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
9448 and create our `TopLevelBranching'.
9450 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
9451 anonymous method host, use `block.TopLevelBranching' rather than
9452 creating a new branching.
9454 2005-04-20 Miguel de Icaza <miguel@novell.com>
9456 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
9457 a ScopeInfo, if any of the current children is a child of the new
9458 entry, move those children there.
9460 2005-04-30 Martin Baulig <martin@ximian.com>
9462 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
9463 at the beginning of a SwitchSection. Fix #73335.
9465 2005-04-27 Marek Safar <marek.safar@seznam.cz>
9468 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
9470 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
9471 (FieldExpr.DoResolve): Obsolete members are ignored for field
9474 2005-04-26 Marek Safar <marek.safar@seznam.cz>
9476 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
9477 of arrays detection.
9479 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
9481 (Field.VerifyClsCompliance): Volatile fields are not compliant.
9483 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
9486 2005-04-25 Ben Maurer <bmaurer@ximian.com>
9488 * cs-parser.jay: Use the prefered version of -unsafe in error
9491 2005-04-22 Marek Safar <marek.safar@seznam.cz>
9493 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
9496 2005-04-20 John Luke <john.luke@gmail.com>
9498 * driver.cs: fix typo in error message, --outout to --output
9500 2005-04-20 Marek Safar <marek.safar@seznam.cz>
9502 * codegen.cs (InRefOutArgumentResolving): New field.
9504 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
9505 fields outside contructor.
9507 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
9509 2005-04-19 Miguel de Icaza <miguel@novell.com>
9511 * anonymous.cs (CaptureContext.EmitParameterInstance): The
9512 parameter code was not completed ever, so it was not as up-to-date
9513 as local variables. Must finish it.
9515 The bug fix was to compare the Toplevel of the block, not the
9516 current block. Thanks for Ben for pointing this out.
9518 2005-04-19 Raja R Harinath <rharinath@novell.com>
9520 * decl.cs (AddMethods): Use the declaring type of the problem
9521 method to determine if we want to squash a warning.
9523 2005-04-19 Marek Safar <marek.safar@seznam.cz>
9525 * attribute.cs: Removed debug output.
9527 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
9529 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
9532 2005-04-18 Raja R Harinath <rharinath@novell.com>
9535 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
9536 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
9537 all null comparisons against reference types.
9539 2005-04-18 Marek Safar <marek.safar@seznam.cz>
9542 * class.cs (TypeContainer.CircularDepException) New nested
9544 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
9545 (TypeContainer.DefineType): Removed error, reset InTransit before
9547 (Class.DefineType): Throw exception when is in Transit.
9548 Catch exception and report error.
9549 (Struct.DefineType): Throw exception when is in Transit.
9550 Catch exception and report error.
9551 (Interface.DefineType): Throw exception when is in Transit.
9552 Catch exception and report error.
9554 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
9555 handle nested exception handlers.
9557 * flowanalysis.cs (InTryWithCatch): New method, search for try with
9560 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
9561 InFinally and InCatch storage.
9563 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
9564 (Catch.Resolve): Set and Restore ec.InCatch.
9565 (Try.Resolve): Set and Restore ec.InFinally.
9566 (Try.HasCatch): True when try has catch.
9568 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
9570 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
9571 for the same event member, so exclude such cases from warning 419.
9574 2005-04-16 Miguel de Icaza <miguel@novell.com>
9576 * expression.cs (Binary.ResolveOperator): Apply patch from John
9577 Luke to fix bug 59864: operators &, | and ^ on enumerations
9578 require that the same enum type on both sides.
9580 * driver.cs: Add warnings to old flag usage, this is to assist
9581 people who produce Makefiles and hope that the Makefiles will be
9584 * class.cs (TypeContainer.EmitType): Moved the definition of the
9585 special $PRIVATE$ field from the resolve phase to the Emit phase.
9586 During resolve we do not know if we are a struct with
9587 HasExplicitLayout, we know this only after the attributes for the
9590 Set the FieldOffset to zero on the dummy field that we create for
9591 the class. Fixes 74590.
9593 2005-04-16 Raja R Harinath <rharinath@novell.com>
9596 * ecore.cs (PropertyExpr.resolved): New.
9597 (DoResolve): Use it to handle a case of double resolution here.
9598 Handle a case of identical-name-and-type-name.
9599 * expression.cs (ArrayCreation.CheckIndices): Avoid double
9600 resolution by storing the results of expression resolution back
9601 into the "probes" array.
9603 2005-04-15 Raja R Harinath <rharinath@novell.com>
9605 Fix cs0208-7.cs and cs0208-8.cs.
9606 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
9607 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
9608 error reporting to point out the reason a struct is not unmanaged.
9610 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9612 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
9613 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
9615 2005-04-13 Raja R Harinath <rharinath@novell.com>
9618 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
9619 IdenticalNameAndTypeName here.
9620 (EventExpr.InstanceResolve): Likewise.
9622 2005-04-13 Marek Safar <marek.safar@seznam.cz>
9624 C# 2.0 DefaultCharSetAttribute implementation
9626 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
9627 which allows us to set GlobalNamespace for every resolve.
9628 (Attribute.ResolveArguments): Cut from Resolve.
9629 (Attribute.GetCharSetValue): Returns CharSet named argument.
9630 (Attribute.DefinePInvokeMethod): Gets default charset from
9632 (GlobalAttribute.ResolveAsTypeStep): Override.
9633 (GlobalAttribute.ResolveArguments): Override.
9635 * class.cs (TypeAttr): Is protected.
9637 * codegen.cs (ModuleClass.DefaultCharSet): New member.
9638 (ModuleClass.DefaultCharSetType): New memeber.
9639 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
9641 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
9642 charset from module.
9644 * delegate.cs (TypeAttr): Override.
9645 (Delegate.DefineType): Use this TypeAttr.
9647 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
9648 at very early stage (before types are defined) to resolve model
9649 module attributes. It will probably not work with corlib but it
9652 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
9653 charset from module.
9655 * typemanager.cs (default_charset_type): New type.
9657 2005-04-13 Raja R Harinath <rharinath@novell.com>
9659 * decl.cs (MemberCache.AddMethods): Don't warn if
9660 System.Object.Finalize has buggy MethodAttributes.
9662 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
9665 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9667 * doc.cs : detect ambiguous reference to overloaded members.
9668 Fixed bug #71603. MS 1.1 csc does not detect it.
9670 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9672 * doc.cs : delegates must not be referenced with parameters.
9675 2005-04-12 Miguel de Icaza <miguel@novell.com>
9677 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
9679 2005-04-10 Miguel de Icaza <miguel@novell.com>
9681 * driver.cs (MainDriver): Stop processing if the CLS stage found
9684 (CompilerCallableEntryPoint.InvokeCompiler): Always
9685 reset after execution; Take a TextWriter argument for the
9688 * report.cs: Use the error stream instead of hardcoding stderr.
9690 2005-04-09 Miguel de Icaza <miguel@novell.com>
9692 * class.cs: Reduce code paths to test, too small of an
9693 optimization to make it worth the extra testing. Always perform
9696 2005-04-08 Raja R Harinath <rharinath@novell.com>
9699 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
9700 operators that had errors reported on them.
9702 2005-04-08 Marek Safar <marek.safar@seznam.cz>
9704 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
9706 (Attribute.Resolve): Add named argument type checking.
9708 * class.cs (FixedField.Define): Use IsPrimitiveType
9710 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
9712 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
9713 unsafe parameter types.
9715 * statement.cs (Using.ResolveExpression): Add better error description.
9717 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
9719 2005-04-08 Raja R Harinath <rharinath@novell.com>
9722 * attribute.cs (Attribute.GetAttributeUsage): Resolve
9723 AttributeUsageAttribute in the emitcontext of the attribute class,
9724 not in the emitcontext of the attributable entity it was attached to.
9725 * cs-parser.jay: Use 'current_class', not 'current_container',
9726 when creating a GlobalAttribute.
9728 2005-04-08 Alp Toker <alp@atoker.com>
9730 * pending.cs: The fix to #58413 failed to compile methods implementing
9731 interfaces with/without params modifiers and vice versa, even though
9732 params modifiers aren't part of the signature. Make the modifier check
9733 less strict as in csc.
9735 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
9736 Anoob V E <projectmonokochi@rediffmail.com>
9737 Harilal P R <projectmonokochi@rediffmail.com>
9740 * pending.cs (TypeAndMethods.mods): New. Store the parameter
9741 modifiers of pending methods.
9742 (PendingImplementation.PendingImplementation): Initialize it.
9743 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
9744 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
9745 with ParameterData. Add check for modifiers.
9746 * class.cs (MethodData.Define): Update to changes.
9748 2005-04-07 Raja R Harinath <rharinath@novell.com>
9750 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
9752 2005-04-07 Marek Safar <marek.safar@seznam.cz>
9754 * class.cs (PropertyMethod.Define): Check private accessor in abstract
9757 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
9760 * typemanager.cs: Registered RequiredAttributeAttribute.
9762 2005-04-06 Marek Safar <marek.safar@seznam.cz>
9764 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
9765 Warning CS0169 is back at level 3.
9766 (IMethodData.SetMemberIsUsed): New method.
9768 * decl.cs (IsUsed): New value; moved from FieldBase.Status
9769 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
9771 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
9773 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
9775 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
9778 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
9781 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
9782 to avoid the problems with nested types.
9784 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
9785 Anoob V.E <projectmonokochi@rediffmail.com>
9786 Harilal P.R <projectmonokochi@rediffmail.com>
9787 Raja R Harinath <rharinath@novell.com>
9790 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
9792 * typemanager (GetConstructor): Make public.
9794 2005-04-05 John Luke <john.luke@gmail.com>
9795 Raja R Harinath <rharinath@novell.com>
9798 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
9799 struct too. Return false quicker in a few cases.
9800 (VerifyUnManaged): Use it.
9802 2005-04-05 Raja R Harinath <rharinath@novell.com>
9805 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
9806 not 'unreachable_seen'.
9808 2005-04-04 Marek Safar <marek.safar@seznam.cz>
9810 * attribute.cs (Attribute.GetValue): Removed unused.
9812 * codegen.cs (CodeGen.TrimExt): Removed unused.
9814 * cs-parser.jay (output): Removed unused.
9816 * cs-tokenizer.cs (hex_digits): Removed unused.
9818 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
9820 * expression.cs (Indirection.LoadExprValue): Removed unused.
9821 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
9823 * iterators.cs (Iterator.param_types): Removed unused.
9825 * statement.cs (Goto.block): Removed unused.
9826 (ToplevelBlock.did): Removed unused.
9827 (Switch.ResolveConstantSwitch): Removed unused.
9829 2005-04-01 Ben Maurer <bmaurer@ximian.com>
9831 * rootcontext.cs: Allow mcs to bootstrap with the compilation
9834 2005-04-01 Raja R Harinath <rharinath@novell.com>
9836 Fix #74232 and cs0208-3.cs.
9837 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
9838 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
9839 unmanaged type. Don't use FieldBuilders when 't' is a
9840 TypeBuilder. Use ModFlags and MemberType fields.
9841 * class.cs (MemberBase.member_type): Rename from MemberType.
9842 (MemberBase.MemberType): New property. Determines member_type on
9844 (MemberBase.DoDefine): Don't initialize MemberType here.
9845 (FieldMember.Define): Likewise.
9847 2005-04-01 Marek Safar <marek.safar@seznam.cz>
9850 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
9851 Attributes are emitted there.
9853 2005-04-01 Raja R Harinath <rharinath@novell.com>
9855 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9856 keyword in 'partial enum' too.
9857 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9859 Report from Kamil Skalski <nazgul@omega.pl>.
9862 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9863 have partial containers too.
9865 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9866 in block' checks to Block.CheckInvariantMeaningInBlock.
9867 * statement.cs (Block.GetKnownVariableInfo): Make private.
9868 (Block.IsVariableUsedInChildBlock): Remove.
9869 (Block.IsVariableUsedInBlock): Likewise.
9870 (Block.CheckInvariantMeaningInBlock): New. Show location of
9871 conflicting declaration.
9872 (Block.AddVariable): Make error messages less long-winded and more
9873 specific. Show location of conflicting declaration.
9874 * parameter.cs (Parameters.Location): New readonly property.
9876 2005-03-31 Raja R Harinath <rharinath@novell.com>
9878 Clean up semantics of invoking ResolveMemberAccess.
9879 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9880 can have an instance, ensure that we pass in a non-TypeExpression
9881 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9882 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9883 argument. Update to changes and simplify.
9884 (FieldExpr.Emitinstance): Remove CS0120 check.
9885 (PropertyExpr.EmitInstance): Likewise.
9886 * expression.cs (Argument.Resolve): Likewise.
9887 (Invocation.DoResolve): Update to changes in semantics of
9890 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9893 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9896 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9898 2005-03-31 Raja R Harinath <rharinath@novell.com>
9900 Fix difference in behaviour with commandline invocation.
9901 * driver.cs (Driver.Reset): New.
9902 (CompilerCallableEntryPoint): Call it.
9904 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9905 variable" warnings if the boolean expression failed to resolve.
9907 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9909 * attribute.cs: Fix the union of several permissions when some of them
9910 are unrestricted (so the result isn't an unrestricted permission set).
9913 2005-03-30 Raja R Harinath <rharinath@novell.com>
9915 * ecore.cs (MemberExpr): New class. Convert from interface
9917 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9918 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9920 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9921 (MethodGroupExpr.IsExplicitImpl): Remove.
9922 (Expression.GetFieldFromEvent): Remove.
9923 (SimpleName.MemberStaticCheck): Remove.
9924 (SimpleName.DoSimpleNameResolve): Update to changes.
9925 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9926 (MemberAccess.IdenticalNameAndTypeName): Remove.
9927 (MemberAccess.error176): Move to MemberExpr.
9928 (MemberAccess.DoResolve): Update to changes.
9929 (BaseAccess.DoResolve): Likewise.
9931 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9933 C# 2.0 Conditional attribute class implementation
9935 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9936 Analyzes class whether it has attribute which has ConditionalAttribute
9937 and its condition is not defined.
9939 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9940 (Class.IsExcluded): New method. Search for at least one defined
9941 condition in ConditionalAttribute of attribute class.
9943 2005-03-30 Raja R Harinath <rharinath@novell.com>
9945 * ecore.cs (PropertyExpr): Derive from Expression, not
9946 ExpressionStatement.
9947 (PropertyExpr.EmitStatement): Remove.
9949 2005-03-29 Raja R Harinath <rharinath@novell.com>
9952 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9953 internal field "value__" of an enum be private. The examples for
9954 "value__" that I found on MSDN all used FieldAttributes.Private.
9956 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9957 Don't mention IL method attribute names.
9959 Fix #47991. Remove a TODO.
9960 * statement.cs (Block.Toplevel): Make into a field.
9961 (Block.Parameters): Move into ToplevelBlock.
9962 (Block.known_variables): Rename from child_variable_names.
9963 (Block.Block): Remove variants that take Parameters. Initialize
9964 'Toplevel' with the immediately surrounding toplevel block.
9965 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9966 LocalInfo parameter.
9967 (Block.GetKnownVariableInfo): New.
9968 (Block.IsVariableNameUsedInChildBlock): Update.
9969 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9970 the block, even though it may not be in scope.
9971 (Block.AddVariable): Remove Parameters parameter. Use
9972 Toplevel.Parameters instead.
9973 (Block.AddConstant): Remove Parameters parameter.
9974 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9975 (Block.IsParamaterReference): Likewise.
9976 (Block.IsLocalParameter): Likewise. Simplify a lot.
9977 (ToplevelBlock.Parameters): New. Moved from Block.
9978 (ToplevelBlock.ToplevelBlock): Update to changes. Always
9979 initialize Parameters to a non-null value.
9980 * cs-parser.jay: Update to changes.
9981 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
9982 simple names that mean different things in the same block. Use
9983 Block.IsVariableNameUsedInBlock.
9985 2005-03-28 Raja R Harinath <rharinath@novell.com>
9987 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
9988 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
9989 GetTypeHandle. It is possible for a reflected type to derive from
9990 a TypeBuilder (e.g., int[] derives from the TypeBuilder
9991 System.Array during mscorlib compilation).
9992 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
9993 contain a method_hash, don't create one either. Don't create a
9994 deep copy of the base cache's method_hash.
9995 (MemberCache.SetupCache): Rename back from DeepCopy.
9996 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
9997 already initialized. If we see an override function, add its
9998 underlying base virtual function to the member_hash too.
10000 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
10002 2005-03-26 Raja R Harinath <harinath@acm.org>
10005 * assign.cs (Assign.DoResolve): When the RHS of an assignment
10006 fails to resolve, ensure that the LHS is still resolved as an
10009 2005-03-25 Raja R Harinath <harinath@acm.org>
10011 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
10013 (Enum.current_ec): Remove.
10014 (Enum.LookupEnumValue): Remove EmitContext argument.
10015 Just uses the one created during DefineType.
10016 (Enum.FindMembers): Update.
10017 * expression.cs (MemberAccess.DoResolve): Update.
10019 2005-03-22 Marek Safar <marek.safar@seznam.cz>
10021 * assign.cs (Assign.DoResolve): Check for CS1717 when
10022 source and target are same (uses Equals).
10024 * expression.cs (LocalVariableReference, ParameterReference,
10025 This): Implemented Equals, GetHashCode.
10027 * statement.cs (Block.GetParameterReference): Removed useless
10030 2005-03-22 Raja R Harinath <rharinath@novell.com>
10033 * statement.cs (Block.AddVariable): Ensure that we skip implicit
10034 blocks before deciding whether the error is cs0136 or cs0128.
10036 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
10037 (using_alias_directive, using_namespace_directive): Pass
10038 MemberName, not an expression to Namespace.UsingAlias and
10040 (MakeName): Use the MemberName of the namespace.
10041 * namespace.cs (Namespace.MemberName): New.
10042 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
10043 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
10045 * decl.cs (MemberName.Name): Make readonly.
10046 (MemberName.FromDotted): New "constructor".
10047 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
10048 (MemberCore.Name): Compute from MemberName on demand.
10049 (MemberCore.SetMemberName): Provide a way to change the
10051 (MemberCore.AddToContainer): Don't take a fullname parameter.
10052 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
10053 fully qualified name of the container to the member name.
10054 (TypeContainer.AddToTypeContainer): Use a fully qualified name
10055 only if the type is a member of the root container.
10056 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
10057 MemberName.Left rather than searching for an embedded ".".
10058 (PartialContainer.CreatePart): Update to changes in RootContext.
10059 (MemberBase.ShortName): Turn into a property. Use
10060 MemberCore.SetMemberName.
10061 (MemberBase.ExplicitInterfaceName): Remove.
10062 (MemberBase.UpdateMemberName): Remove.
10063 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
10064 (PropertyBase.SetMemberName): New override.
10065 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
10066 (Tree.GetDecl): New.
10067 (Tree.AllDecls): Rename from Decls.
10068 * attribute.cs, enum.cs, report.cs: Update to changes.
10069 * driver.cs (MainDriver): Use MemberName.FromDotted on
10070 RootContext.MainClass.
10072 2005-03-21 Marek Safar <marek.safar@seznam.cz>
10074 * class.cs (FixedField.Define): Check for CS1664 and more sanity
10077 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
10079 2005-03-18 Marek Safar <marek.safar@seznam.cz>
10081 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
10082 property accessor modifiers.
10084 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
10085 fixed buffer attribute (CS1716).
10086 (PropertyMethod.HasCustomAccessModifier): When property accessor
10087 has custom modifier.
10089 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
10091 (PropertyExpr.DoResolveLValue): Add CS0272.
10093 2005-03-17 Miguel de Icaza <miguel@novell.com>
10095 * convert.cs: When converting to a pointer, use the proper Conv.U
10096 or Conv.I depending on the source data type.
10098 * cs-tokenizer.cs: Make the size for large decimal constants,
10101 2005-03-17 Martin Baulig <martin@ximian.com>
10103 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
10104 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
10106 2005-03-17 Martin Baulig <martin@ximian.com>
10108 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
10109 to bool so we can return an error condition.
10110 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
10113 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
10115 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
10118 2005-03-16 Raja R Harinath <rharinath@novell.com>
10120 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
10121 Refactor to avoid traversing the list of assemblies, and to avoid
10122 string concatenation.
10123 * typemanager.cs (guid_attr_type): Remove.
10124 (negative_hits, pointers, references): Remove hashes.
10126 (GetConstructedType): New. Uses type_hash to handle constructed
10127 types (arrays, references, pointers).
10128 (GetReferenceType, GetPointerType): Use it.
10129 (GetNestedType): New. Uses type_hash to handle nested types of
10131 (LookupType, LookupTypeDirect): Remove.
10132 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
10133 'types' hash and LookupTypeReflection directly.
10134 (params_string, params_object): Use GetConstructedType.
10135 * namespace.cs (Namespace.cached_types): New. Cache of reflected
10137 (Namespace.Lookup): Use cached_types.
10138 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
10139 provided by old TypeManager.LookupType.
10140 * rootcontext.cs (MakeFQN): Remove.
10141 * decl.cs (DeclSpace.MakeFQN): Likewise.
10142 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
10143 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
10144 TypeManager.GetConstructedType.
10145 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
10147 2005-03-15 Marek Safar <marek.safar@seznam.cz>
10149 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
10152 * cs-parser.jay: Reports CS1527 for any namespace element.
10154 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
10157 * expression.cs (ParameterReference.IsAssigned): Changed error to
10159 (Error_WrongNumArguments): Moved CS0245 detection here.
10161 * statement.cs (Return.Resolve): Add CS1622 report.
10163 2005-03-11 Marek Safar <marek.safar@seznam.cz>
10165 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
10167 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
10169 * attribute.cs expression.cs: Get rid of some allocations.
10171 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
10173 * doc.cs : just eliminate the latest change.
10175 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10177 * doc.cs : commented out the latest change. It breaks xml-030.cs
10179 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10181 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
10182 fail. So invoke CreateType() in FindDocumentedType().
10184 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10186 * cs-tokenizer.cs : added IsKeyword().
10187 * doc.cs : Detect keyword incorrectly used as identifier.
10188 Allow identifiers prefixed by @.
10190 2005-03-10 Marek Safar <marek.safar@seznam.cz>
10192 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
10193 It caused exception in namespace resolving (again!).
10195 * class.cs (Class.ctor): Removed exit.
10196 (PropertyMethod.ctor): ditto.
10198 * codegen.cs (Codegen.Reset): Reset static data.
10199 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
10201 * cs-tokenizer.cs (Cleanup): Removed.
10203 * driver.cs (GetSystemDir): Rewrote to one line command.
10204 It caused problem with unloaded dynamic modules.
10205 (UnixParseOption): Removed Exit.
10206 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
10207 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
10208 Now can be mcs used as library.
10210 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
10213 * location.cs (Reset): Reset static data.
10215 * namespace.cs (Reset): Reset static data.
10217 * report.cs (Report.Reset): Reset static data.
10219 * rootcontext.cs (RootContext.Reset): Reset static data.
10221 * tree.cs (RootTypes.ctor): Use Location.Null
10223 * typemanager.cs (TypeManager.Reset): Reset static data.
10224 (CoreLookupType): Removed Exit.
10225 (TypeHandle.Reset): Reset static data.
10227 2005-03-10 Raja R Harinath <rharinath@novell.com>
10230 * typemanager.cs (ComputeNamespaces): Import namespaces from
10231 referenced modules too.
10233 2005-03-09 Raja R Harinath <rharinath@novell.com>
10235 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
10238 2005-03-09 Raja R Harinath <rharinath@novell.com>
10240 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
10241 enclosing DeclSpace. This ensures that a name-lookup populates
10242 more caches and there are fewer 'TypeExpression's. Carve out
10243 nested type lookup into ...
10244 (LookupNestedTypeInHierarchy): ... this.
10246 2005-03-09 Raja R Harinath <rharinath@novell.com>
10248 Clean up a few partial-class semantics.
10249 Fixes test-357.cs and cs1618-2.cs.
10250 * cs-parser.jay (struct_declaration): Use 'current_class' as
10251 parent of newly-created struct. Remove call to Register ().
10252 Use 'pop_current_class' to complete handing the current struct.
10253 (interface_declaration): Likewise.
10254 (class_declaration): Likewise.
10255 (enum_declaration): Use 'current_class' as parent of newly created
10257 (delegate_declaration): Likewise.
10258 (pop_current_class): New function. This is used to handle closing
10259 up the 'current_class' and 'current_container', and pointing them
10260 to the enclosing class/container.
10261 (CSharpParser): Initialize 'current_class' too.
10262 * decl.cs (MemberCore): Add check for invariant: a partial
10263 container is not a parsed entity, and thus does not enclose any
10265 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
10266 (DeclSpace.BaseTypeExpr): Use it.
10267 (DeclSpace.LookupType): Add check for invariant.
10268 * class.cs (TypeContainer): Add check for invariant: a nested
10269 class should have the same NamespaceEntry as its enclosing class.
10270 (TypeContainer.EmitFieldInitializers): Make virtual.
10271 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
10273 (TypeContainer.Register): Remove.
10274 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
10275 null. Use TypeResolveEmitContext for resolving base types and
10276 interfaces. Move initialization of Parts.TypeBuilder here from
10278 (TypeContainer.DefineNestedTypes): ... here.
10279 (PartialContainer): Take a Namespace not a NamespaceEntry.
10280 (PartialContainer.Create): Don't use Register. Call the
10281 appropriate Add... function directly.
10282 (ClassPart): Take both the PartialContainer and the enclosing
10283 class as constructor arguments.
10284 (ClassPart.EmitFieldInitializers): Override.
10285 (ClassPart.PartFindNestedTypes): Remove.
10286 (FieldBase.GetInitializerExpression): Resolve the initializer
10287 expression in the emit context of the enclosing class.
10288 * tree.cs (RootTypes): Remove Register ().
10290 2005-03-08 Marek Safar <marek.safar@seznam.cz>
10292 * cs-parser.jay: Removed CS0134.
10294 * driver.cs: Removed CS1901.
10296 * expression.cs (SizeOf.DoResolve): Don't report CS0233
10297 for predefined types.
10299 2005-03-07 Duncan Mak <duncan@novell.com>
10301 * codegen.cs (Save): Catch UnauthorizedAccessException as
10302 well. Fixes bug #73454.
10304 2005-03-07 Marek Safar <marek.safar@seznam.cz>
10306 * cs-tokenizer.cs (xtoken): Add CS1035.
10308 * class.cs (MethodData.Define): Add CS0683.
10309 (FieldMember.ctor): Add CS0681.
10311 2005-03-07 Raja R Harinath <rharinath@novell.com>
10313 * ecore.cs (SimpleName.DoResolve): Rename from
10314 SimpleName.DoResolveAllowStatic.
10315 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
10316 Pass 'intermediate' flag to MemberStaticCheck.
10317 (SimpleName.MemberStaticCheck): Skip "static check" only in case
10318 of "intermediate" lookups via MemberAccess.
10319 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
10320 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
10322 2005-03-07 Raja R Harinath <rharinath@novell.com>
10325 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
10326 slipped in because of variable names that are identical to a
10327 builtin type's BCL equivalent ('string String;', 'int Int32;').
10328 (PropertyExpr.EmitInstance): Likewise.
10330 2005-03-04 Marek Safar <marek.safar@seznam.cz>
10332 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
10334 * report.cs (warning_ignore_table): Made public.
10336 2005-03-04 Raja R Harinath <rharinath@novell.com>
10339 * class.cs (MethodData.Emit): Pass 'container' to
10340 container.GetObsoleteAttribute instead of 'container.Parent'.
10342 2005-03-03 Marek Safar <marek.safar@seznam.cz>
10344 * cs-parser.jay: Add 1534 error test.
10346 * iterators.cs (Yield.CheckContext): Add error 1629.
10347 (Iterator.ctor): Save unsafe modifier.
10348 (MoveNextMethod.DoEmit): Restore unsafe context.
10350 * namespace.cs (UsingAlias): Better error message.
10352 2005-03-03 Dan Winship <danw@novell.com>
10354 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
10355 the warning message [#73219]
10357 2005-03-03 Raja R Harinath <rharinath@novell.com>
10359 Fix compile with MCS 1.0.0.0.
10360 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
10361 w_restore to not depend on string constant folding.
10363 2005-03-03 Raja R Harinath <rharinath@novell.com>
10365 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
10366 CS0246 check to users who passed 'silent = false'.
10367 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
10369 (SimpleName.SimpleNameResolve): Update.
10370 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
10371 (MemberAccess.IdenticalNameAndTypeName): Update.
10372 * doc.cs (FindDocumentedTypeNonArray): Update.
10374 2005-03-03 Raja R Harinath <rharinath@novell.com>
10376 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
10377 * parameters.cs (ComputeAndDefineParameters): Remove.
10378 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
10379 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
10380 Use GetParameterInfo.
10382 2005-03-02 Marek Safar <marek.safar@seznam.cz>
10384 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
10386 2005-03-02 Raja R Harinath <rharinath@novell.com>
10388 Unify DeclSpace.LookupType and DeclSpace.FindType.
10389 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
10390 is in charge of defining nested types on demand.
10391 (DeclSpace.LookupType): Use it when the current_type is a
10392 TypeBuilder. Use LookupTypeDirect for reflected types.
10393 (DeclSpace.FindType): Remove.
10394 (DeclSpace.LookupInterfaceOrClass): Likewise.
10395 (DeclSpace.DefineTypeAndParents): Likewise.
10396 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
10397 DeclSpace.LookupType.
10398 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
10399 * typemanager.cs (LookupType): Simplify.
10400 (AddUserType): Remove type from negative_hits.
10401 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
10402 * class.cs (TypeContainer.FindMembers): Move handling of nested
10404 (TypeContainer.FindMembers_NestedTypes): ... here.
10405 (TypeContainer.FindNestedType): Implement override.
10406 (ClassPart.FindNestedType): Delegate to PartialContainer.
10407 (ClassPart.PartFindNestedType): Looks up the nested types of the
10410 2005-03-02 Martin Baulig <martin@ximian.com>
10412 * class.cs (TypeContainer.DoDefineMembers): We also need a default
10413 static constructor in static classes.
10415 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
10417 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
10418 sizeParamIndex is not specified.
10420 2005-03-01 Marek Safar <marek.safar@seznam.cz>
10423 * report.cs (WarningMessage.IsEnabled): Missing null check.
10425 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10427 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
10428 in the fields and not in the properties.
10430 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
10432 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
10435 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10437 * attribute.cs: Small refactoring (improved robustness).
10438 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
10439 (ValidateGuid): Removed.
10440 (Resolve): Removed referenced to above mentioned.
10441 (GetAttributeUsage): Made private and changed to work without
10443 (GetIndexerAttributeValue): Don't crash.
10444 (GetConditionalAttributeValue): Ditto.
10445 (GetClsCompliantAttributeValue): Ditto.
10446 (ExtractSecurityPermissionSet): All attributes exceptions are
10448 (GetPropertyValue): New helper.
10449 (GetMethodImplOptions): New method.
10450 (DefinePInvokeMethod): Reuse common code. Implemented handling of
10451 some missing properties.
10453 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
10454 (Method.ApplyAttributeBuilder): Updated.
10456 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
10459 2005-02-28 Raja R Harinath <rharinath@novell.com>
10462 * report.cs (Report.SymbolRelatedToPreviousError): Handle
10463 non-simple types (array, pointer, reference).
10465 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10467 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
10469 * class.cs (MethodCore.IsDuplicateImplementation): Special error
10471 (Method.CheckBase): Catch wrong destructor here.
10472 (MethodData.Define): Add errors 550, 668.
10474 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
10476 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
10478 * pending.cs (VerifyPendingMethods): Add error 551.
10480 * typemanager.cs (CSharpName): Next error report helper.
10482 2005-02-25 Marek Safar <marek.safar@seznam.cz>
10484 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
10485 attributes. Removed useless attribute double check.
10486 It saves almost 2MBs for corlib.
10488 2005-02-25 Raja R Harinath <rharinath@novell.com>
10491 * statement.cs (ExpressionStatement.Resolve): Make robust to being
10492 called twice in case of error.
10494 2005-02-23 Chris Toshok <toshok@ximian.com>
10496 Fix compiler portions of #72827.
10497 * statement.cs (Block.Emit): call Begin/EndScope on the
10498 EmitContext instead of the ILGenerator.
10500 * codegen.cs (EmitContext.BeginScope): new method, call
10501 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
10503 (EmitContext.BeginScope): same, but EndScope and CloseScope
10505 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
10506 offset and call the superclass's OpenScope(int) with it.
10507 (SymbolWriter.CloseScope): get the current il
10508 offset and call superclass's CloseScope(int) with it.
10510 2005-02-23 Marek Safar <marek.safar@seznam.cz>
10512 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
10513 CS1677 for out and ref as well.
10515 * class.cs (Method.Define): Add error CS1599 detection.
10517 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
10519 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
10521 * delegate.cs (Delegate.Define): Add error CS1599 detection.
10523 * support.cs.cs (ModifierDesc): New helper method.
10525 2005-02-23 Raja R Harinath <rharinath@novell.com>
10526 Abin Thomas <projectmonokochi@rediffmail.com>
10527 Anoob V E <projectmonokochi@rediffmail.com>
10528 Harilal P R <projectmonokochi@rediffmail.com>
10530 Fix #57851, #72718.
10531 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
10532 MemberLookup (used for error reporting) actually returns a result.
10533 Fix error report number (122, not 112).
10535 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
10536 Anoob V E <projectmonokochi@rediffmail.com>
10537 Harilal P R <projectmonokochi@rediffmail.com>
10540 * pending.cs (PendingImplementation.GetAbstractMethods):
10541 Find NonPublic members too.
10543 2005-02-22 Marek Safar <marek.safar@seznam.cz>
10545 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
10548 * class.cs (MethodCore.CheckMethodAgainstBase):
10549 Add error 239 report.
10551 2005-02-21 Raja R Harinath <rharinath@novell.com>
10554 * expression.cs (Invocation.IsApplicable): Make public.
10555 (Invocation.IsParamsMethodApplicable): Likewise.
10556 * delegate.cs (Delegate.VerifyApplicability): Don't use
10557 Invocation.VerifyArgumentCompat for parameter applicability
10558 testing. Use Invocation.IsApplicable and
10559 Invocation.IsParamsMethodApplicable.
10561 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10563 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
10565 * class.cs (Operator.Define): Add error 217 report.
10567 2005-02-21 Raja R Harinath <rharinath@novell.com>
10569 * namespace.cs (UsingEntry.Resolve): Undo change below.
10571 2005-02-21 Raja R Harinath <rharinath@novell.com>
10574 * ecore.cs (Expression.MemberLookupFailed): Add argument to
10575 disable the error message when the extended MemberLookup also
10577 (Expression.MemberLookupFinal): Update.
10578 (SimpleName.DoSimpleNameResolve): Update.
10579 * expression.cs (MemberAccess.ResolveNamespaceOrType):
10580 Don't use MemberLookupFinal.
10581 (New.DoResolve): Update.
10582 (BaseAccess.CommonResolve): Update.
10584 2005-02-21 Raja R Harinath <rharinath@novell.com>
10587 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
10588 occured previously, don't resolve again.
10590 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10593 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
10594 argument. Call ResolveAttributeUsage for unresolved.
10595 when types doesn't match ctor arguments.
10597 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
10598 for nested attribute classes.
10599 (Class.attribute_usage): Removed.
10600 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
10601 for attribute class.
10603 * ecore.cs (IsAttribute): Removed.
10605 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
10607 * rootcontext.cs (RegisterAttribute): Removed, attributes are
10609 (attribute_types): Removed.
10610 (EmitCode): Global attributes are emited as the latest.
10612 2005-02-18 Marek Safar <marek.safar@seznam.cz>
10614 * class.cs (EmitFieldInitializers): Don't emit field initializer
10615 for default values when optimilization is on.
10617 * constant.cs (Constant.IsDefaultValue): New property.
10619 * driver.cs: Add /optimize handling.
10623 * literal.cs: Implement new IsDefaultValue property.
10625 * rootcontext.cs (Optimize): New field, holds /optimize option.
10627 2005-02-18 Raja R Harinath <rharinath@novell.com>
10629 Fix crasher in re-opened #72347.
10630 * namespace.cs (Namespace.Lookup): Return null if
10631 DeclSpace.DefineType returns null.
10634 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
10636 2005-02-18 Raja R Harinath <rharinath@novell.com>
10638 Fix remainder of #63202. Change semantics of DoResolveLValue: it
10639 now returns null if it cannot resolve to an lvalue.
10640 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
10641 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
10642 returned null. Remove check for SimpleName.
10643 (EventExpr.DoResolveLValue): New.
10644 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
10645 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
10647 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
10648 avoid CS0131 error.
10649 (Unary.ResolveOperator): Move CS0211 check ...
10650 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
10652 (Unary.DoResolveLValue): Simplify.
10653 (AddressOf.DoResolveLValue): New.
10654 (ArrayAccess.DoResolveLValue): New.
10656 2005-02-16 Marek Safar <marek.safar@seznam.cz>
10658 * attribute.cs (Attribute.Resolve): Add arguments casting for
10659 when types doesn't match ctor arguments.
10661 2005-02-16 Raja R Harinath <rharinath@novell.com>
10663 Fix parts of #63202.
10664 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
10665 lookup of operator in base type. Ensure that all checks happen
10666 when the operator resolves to an "op_..." method.
10668 2005-02-15 Raja R Harinath <rharinath@novell.com>
10671 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
10672 'ignore_cs0104' parameter. Pass it to ...
10673 (NamespaceEntry.Lookup): ... this.
10674 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
10675 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
10676 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10677 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
10678 Update. Request that cs0104 errors be ignored.
10679 (ComposedCast.ResolveAsTypeStep): Update.
10681 2005-02-14 Raja R Harinath <rharinath@novell.com>
10684 * expression.cs (Invocation.BetterFunction): Remove support for
10685 comparing virtual functions and their overrides.
10686 (Invocation.IsOverride): New.
10687 (Invocation.OverloadResolve): Don't consider 'override' functions
10688 during candidate selection. Store them in a lookaside list.
10689 If the selected method is a 'virtual' function, use the list to
10690 find any overrides that are closer to the LHS type.
10692 2005-02-14 Marek Safar <marek.safar@seznam.cz>
10694 * expression.cs (New.DoResolve): Add complex core type reduction.
10695 (New.Constantify): Converts complex core type syntax like 'new int ()'
10696 to simple constant.
10698 2005-02-14 Raja R Harinath <rharinath@novell.com>
10700 * decl.cs (EntryType.EntryType): New constructor to create an
10701 updated copy of a cache entry.
10702 (MemberCache.AddMethods): Use it.
10703 (MemberCache.ClearDeclaredOnly): Remove.
10704 (MemberCache.MemberCache): Update.
10706 2005-02-11 Miguel de Icaza <miguel@novell.com>
10708 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
10709 variable. This one is represents the actual low-level declaration
10710 of the method, as opposed to the semantic level `IsStatic'.
10712 An anonymous method which is hosted into a static method might be
10713 actually an instance method. IsStatic would reflect the
10714 container, while MethodIsStatic represents the actual code
10717 * expression.cs (ParameterReference): Use the new MethodIsStatic
10718 instead of IsStatic.
10720 * anonymous.cs (AnonymousMethod.Compatible): Pass the
10721 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
10722 set on the current EmitContext.
10724 * expression.cs (Cast): Overload DoResolveLValue so we can pass
10725 resolve our casted expression as an LValue. This triggers the
10726 proper LValue processing that is later required by Assign.
10730 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
10732 2005-02-11 Marek Safar <marek.safar@seznam.cz>
10734 C# 2.0 Fixed buffer implementation
10736 * anonymous.cs: Update after RegisterHelperClass renaming.
10738 * attribute.cs (AttributeTester.fixed_buffer_cache):
10739 Cache of external fixed buffers.
10740 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10741 implementation if field is fixed buffer else null.
10744 (TypeContainer.AddField): Accept FieldMember instead of Field.
10745 (FieldBase.IsFieldClsCompliant): Extracted code from
10746 VerifyClsCompliance descendant customization.
10747 (FixedField): New class handles fixed buffer fields.
10748 (FixedFieldExternal): Keeps information about imported fixed
10750 (IFixedField): Make access to internal or external fixed buffer
10753 * cs-parser.jay: Add fixed buffer parsing.
10755 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
10758 * expression.cs (Indirection): Extended implementation to accept
10759 fixed buffer field.
10760 (PointerArithmetic.Emit): Get element from fixed buffer as well.
10761 (ElementAccess.MakePointerAccess): Get type as parameter.
10762 (DoResolve): Add fixed buffer field expression conversion.
10763 (DoResolveLValue): Ditto.
10764 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
10765 (ArrayPtr): Derives from FixedBufferPtr.
10766 (ArrayPtr.Emit): Add extra emit for array elements.
10768 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
10770 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
10771 for compiler generated types.
10772 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
10774 * statement.cs (Fixed): Refactored to be easier add fixed buffer
10775 and consume less memory.
10776 (Fixed.Resolve): Add fixed buffer case.
10778 * typemanager.cs (compiler_generated_attr_ctor,
10779 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
10780 (HasElementType): Add our own implementation to work on every
10783 2005-02-11 Miguel de Icaza <miguel@novell.com>
10785 * anonymous.cs (CaptureContext): Track whether `this' has been
10788 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
10789 only captured `this' if it was implicitly done (instance
10790 methods/variables were used).
10792 * codegen.cs (EmitContext.CaptureThis): New method to flag that
10793 `this' must be captured.
10795 2005-01-30 Miguel de Icaza <miguel@novell.com>
10797 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
10798 is null it means that there has been no need to capture anything,
10799 so we just create a sibling.
10801 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
10803 Just a partial fix. The other half is fairly elusive.
10805 2005-02-10 Raja R Harinath <rharinath@novell.com>
10807 Fix #52586, cs0121-4.cs.
10808 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
10809 and return a hashtable.
10810 (MemberCache.ClearDeclaredOnly): New.
10811 (MemberCache.MemberCache): Update to change. Make a deep copy of
10812 the method_hash of a base type too.
10813 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10814 type methods. Overwrite entries with the same MethodHandle so
10815 that the ReflectedType is correct. The process leaves in base
10816 virtual functions and their overrides as distinct entries.
10817 (CacheEntry): Now a class instead of a struct. It shouldn't alter
10818 matters since it was boxed in a ArrayList before.
10819 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
10821 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
10822 case of a virtual function and its override (choose the overload
10824 (Invocation.OverloadResolve): Avoid 'override' members during
10825 'applicable_type' calculation.
10827 2005-02-09 Raja R Harinath <rharinath@novell.com>
10829 Combine two near-redundant caches.
10830 * typemanager.cs (method_params): Rename from method_internal_params.
10831 (TypeManager.GetParameterData): New. Replace
10832 Invocation.GetParameterData.
10833 (TypeManager.LookupParametersByBuilder): Remove.
10834 * expression.cs (Invocation.method_parameter_cache): Remove.
10835 (Invocation.GetParameterData): Remove.
10837 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
10840 2005-02-08 Raja R Harinath <rharinath@novell.com>
10843 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
10844 TypeManager.multicast_delegate_type is null, resolve it by looking
10845 up "System.MulticastDelegate".
10846 * rootcontext.cs (RootContext.ResolveCore): Simplify.
10848 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
10849 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
10850 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
10853 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
10854 (LabeledStatement.AddReference): New. Set 'referenced'.
10855 (Goto.Resolve): Use it.
10857 2005-02-05 John Luke <john.luke@gmail.com>
10859 * driver.cs: remove duplicate -doc line in Usage ()
10861 2005-02-04 Raja R Harinath <rharinath@novell.com>
10863 * location.cs (Location.AddFile): Fix CS2002 error report.
10865 2005-02-02 Martin Baulig <martin@ximian.com>
10867 * delegate.cs (Delegate.DefineType): Report an internal error if
10868 TypeManager.multicast_delegate_type is null. See bug #72015 for
10871 2005-02-02 Raja R Harinath <rharinath@novell.com>
10873 Fix a crasher in a variant of #31984.
10874 * const.cs (Constant.CheckBase): New override that defers the
10875 new-or-override check in case the base type hasn't been populated
10877 (Constant.Define): Ensure the new-or-override check is performed.
10879 2005-02-01 Duncan Mak <duncan@ximian.com>
10881 * const.cs (LookupConstantValue): Check that `ce' is not null
10882 before calling GetValue ().
10884 2005-02-01 Raja R Harinath <rharinath@novell.com>
10886 Fix test-334.cs (#69519).
10887 * cs-parser.jay (using_alias_directive): Pass in an expression to
10888 NamespaceEntry.UsingAlias.
10889 (using_namespace_directive): Pass in an expression to
10890 NamespaceEntry.Using.
10891 (namespace_name): Don't flatten to a string.
10892 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10893 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10895 (NamespaceEntry.UsingEntry): Likewise.
10896 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10898 (NamespaceEntry.LookupForUsing): Remove.
10899 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10901 (NamespaceEntry.Lookup): Remove support for dotted names.
10903 2005-02-01 Raja R Harinath <rharinath@novell.com>
10905 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10907 (NamespaceEntry.ImplicitParent): Compute on demand.
10908 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10909 parallels the current.
10910 (NamespaceEntry.LookupForUsing): Use it.
10911 (NamespaceEntry.Lookup): If the current namespace-entry is
10912 implicit, don't search aliases and using tables.
10914 2005-02-01 Raja R Harinath <rharinath@novell.com>
10917 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10919 (TypeContainer.BaseCache): Compute on demand.
10920 (TypeContainer.FindMembers): Define constants and types if they're
10921 not already created.
10922 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10924 * const.cs (Constant.Define): Make idempotent.
10926 2005-01-29 Miguel de Icaza <miguel@novell.com>
10928 * pending.cs: Produce better code (no nops produced by using Ldarg
10931 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10932 i - 1' it should be arg + 1.
10936 2005-01-28 Raja R Harinath <rharinath@novell.com>
10938 * attribute.cs (Attribute.CheckAttributeType): Make private
10940 (Attribute.ResolveType): Make virtual.
10941 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10942 handling of RootContext.Tree.Types.
10944 2005-01-27 Raja R Harinath <rharinath@novell.com>
10946 Update attribute-handling to use the SimpleName/MemberAccess
10948 * cs-parser.jay (attribute): Pass in an expression to the
10949 constructors of Attribute and GlobalAttribute.
10950 * attribute.cs (Attribute): Take an expression for the name.
10951 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10952 passed in attribute name expression.
10953 (Attribute.CheckAttributeType): Use it.
10954 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10955 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10956 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10957 argument to prevent error messages if the lookup fails.
10959 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10961 * expression.cs (Indirection): Implemented IVariable interface
10962 to support indirection in AddressOf operator.
10963 (PointerArithmetic.Emit): Add optimalization for case where
10964 result can be precomputed.
10966 2005-01-26 Martin Baulig <martin@ximian.com>
10968 * class.cs (TypeContainer.AttributeTargets): Return the correct
10969 AttributeTargets depending on our `Kind' instead of throwing an
10970 exception; fixes #71632.
10972 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10975 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
10978 2005-01-25 Raja R Harinath <rharinath@novell.com>
10981 * expression.cs (MemberAccess.DoResolve): Don't complain with
10982 cs0572 when the LHS of a member access has identical name and type
10985 2005-01-25 Marek Safar <marek.safar@seznam.cz>
10988 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
10990 Create custom PermissionSet only for PermissionSetAttribute.
10992 2005-01-24 Marek Safar <marek.safar@seznam.cz>
10995 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
10996 delegates in static class.
10998 2005-01-24 Martin Baulig <martin@ximian.com>
11000 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11001 merging an implicit block, just use its reachability.
11003 * statement.cs (Block.Resolve): Make the unreachable code check
11004 work wrt. implicit blocks; see test-337 from #63842.
11006 2005-01-21 Alp Toker <alp@atoker.com>
11008 * cs-parser.jay: destructor_declaration's container is PartialContainer
11009 not Class when partial types are used, so use Kind prop instead of
11012 2005-01-22 Miguel de Icaza <miguel@ximian.com>
11014 * cs-parser.jay: Improve error reporting when an interface
11015 declares new types.
11017 2005-01-20 Dick Porter <dick@ximian.com>
11019 * support.cs: SeekableStreamReader fix from Sandor Dobos
11020 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
11021 chars are read. Fixes bug 70369.
11023 2005-01-20 Raja R Harinath <rharinath@novell.com>
11025 * cs-parser.jay (catch_clause): Simplify current_block handling
11028 2005-01-17 Miguel de Icaza <miguel@ximian.com>
11030 * convert.cs (ImplicitStandardConversionExists): Synchronize the
11031 code with ImplicitStandardConversion to handle the implicit
11032 conversion of method groups into valid delegate invocations.
11034 The problem is that in parameter handling we were using this code
11035 path. Fixes bug #64698
11037 2005-01-19 Raja R Harinath <rharinath@novell.com>
11039 * cs-parser.jay: Fix several infelicities.
11040 - Avoid assigning to the parser value stack. Code like
11041 '$3 = null' is unclean. Synthesize a value for the code block
11043 - Avoid using oob_stack for storing location information. Use ...
11044 (_mark_): ... this. New (empty) rule. Saves the current location
11046 (foreach_statement): Avoid using oob_stack for current_block
11047 handling. Use technique used in for_statement and
11048 using_statement. Synthesize a value for the code block to store
11049 additional intermediate information.
11051 2005-01-13 Miguel de Icaza <miguel@ximian.com>
11053 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
11054 of a different type is only allowed to private fields of a
11055 containing type, not on fields of a base class.
11057 See test-174.cs and error cs0122-9.cs
11059 2005-01-13 Raja R Harinath <rharinath@novell.com>
11061 Fix test-335.cs (bug #58126).
11062 * cs-parser.jay (argument): Split out non-expression parts of the
11063 rule into 'non_simple_argument'.
11064 (invocation_expression): Support parenthesized invocations with
11065 multiple arguments, and with single non-simple arguments.
11067 2005-01-13 Raja R Harinath <rharinath@novell.com>
11069 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
11072 2005-01-12 Raja R Harinath <rharinath@novell.com>
11074 Fix cs0038-1.cs, cs1640-6.cs.
11075 * ecore.cs (Expression.Resolve): Remove special-case for
11076 SimpleName in error-handling.
11077 (Expression.almostMatchedMembers): Relax access permission to
11079 (Expression.MemberLookupFailed): Handle duplicates in
11080 almostMatchedMembers list.
11081 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
11082 * expression.cs (New.DoResolve): Report CS1540 for more cases.
11083 * typemanager.cs (GetFullNameSignature): Use the MethodBase
11084 overload if the passed in MemberInfo is a MethodBase.
11086 2005-01-12 Marek Safar <marek.safar@seznam.cz>
11089 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
11090 for non-CAS & merge permission sets properly.
11092 2005-01-11 Raja R Harinath <rharinath@novell.com>
11094 Improve standard-compliance of simple name and member access
11095 resolution. Fixes bugs #52697, #57200, #67520, #69519.
11096 * ecore.cs (FullNamedExpression): New abstract base class
11097 for Namespaces and TypeExpressions.
11098 (ResolveFlags.SimpleName): Remove.
11099 (SimpleName): Remove support for dotted names.
11100 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
11101 DeclSpace.FindType and DeclSpace.LookupType.
11102 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
11103 (Expression.ExprClassName): Make member function.
11104 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
11105 a namespace. Remove creation of dotted "SimpleName"s.
11106 (MemberAccess.DoResolve): Likewise.
11107 * decl.cs (DeclSpace.Cache): Make private.
11108 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
11109 (DeclSpace.FindType): Update.
11110 (DeclSpace.LookupType): Move here from RootContext. Return a
11111 FullNamedExpression.
11112 * namespace.cs (Namespace): Derive from FullNamedExpression
11113 so that it can be part of expression resolution.
11114 (Namespace.Lookup): Return an FullNamedExpression.
11115 (NamespaceEntry.LookupAlias): Lookup aliases only in current
11117 * rootcontext.cs (NamespaceLookup): Remove.
11118 (LookupType): Move to DeclSpace.
11119 * attribute.cs (CheckAttributeType): Update.
11120 * doc.cs (FindDocumentedType): Remove allowAlias argument.
11121 (FindDocumentedTypeNonArray): Likewise.
11123 2005-01-11 Raja R Harinath <rharinath@novell.com>
11125 Fix cs0509.cs, cs1632.cs.
11126 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
11127 is the same as IsInterface.
11128 (TypeContainer.GetClassBases): Likewise.
11129 * statement.cs (LabeledStatement.ig): New field.
11130 (LabeledStatement.LabelTarget): Save ILGenerator which created the
11132 (LabeledStatement.DoEmit): Check that the label was created with
11133 the same ILGenerator.
11135 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11138 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
11139 accessors to its properties.
11141 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
11142 from accessors to property.
11144 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11147 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
11148 only for overrides.
11150 2005-01-08 Miguel de Icaza <miguel@ximian.com>
11152 * attribute.cs: Check for null and empty strings.
11154 I have lost another battle to Paolo.
11156 2005-01-07 Marek Safar <marek.safar@seznam.cz>
11159 * class.cs (PropertyMethod): Set Parent field in ctors.
11160 (SetMethod.InternalParameters): Add unsafe switch hack.
11161 Override MarkForDuplicationCheck where it is appropriate.
11163 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
11164 It says whether container allows members with the same name.
11165 Base default is no.
11166 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
11167 Removed is_method parameter.
11169 2005-01-06 Duncan Mak <duncan@ximian.com>
11171 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
11172 because the previous change led to incorrect reporting of CS1032
11173 ("Cannot define/undefine preprocessor symbols after first token in
11174 file"). Instead of using `tokens_seen' as the only flag that
11175 triggers CS1040, introduce `comments_seen'. This new flag is used
11176 to signify having seen comments on the current line, so it is
11177 unset after a newline.
11179 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11181 * doc.cs : When searching for a type, find nested type too.
11182 This fixes bug #71040.
11184 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11187 - Warn missing member comment on those classes which also does not
11188 have doc comments. Fixed bug #71041.
11189 - Don't warn missing doc comment on default constructor.
11192 2005-01-06 Duncan Mak <duncan@ximian.com>
11194 * cs-tokenizer.cs (xtoken): After handling traditional C-style
11195 comments, set `tokens_seen' to true. This allows us to detect
11196 misplaced preprocessor directives (i.e. not at the beginning of
11197 the a line, nor after whitespaces). In that case, report error
11198 CS1040. This fixes bug #56460.
11200 * cs-parser.jay (interface_member_declaration): Add checks for
11201 IsExplicitImpl, and report CS0541 error if an interface member is
11202 defined as an explicit interface declaration.
11204 2005-01-06 Marek Safar <marek.safar@seznam.cz>
11207 * class.cs (PropertyMethod): Set Parent field in ctors.
11208 (SetMethod.InternalParameters): Add unsafe switch hack.
11210 * decl.cs (MemberCore.Parent): Cannot be readonly.
11212 2005-01-06 Raja R Harinath <rharinath@novell.com>
11214 * decl.cs (DeclSpace.ResolveType): Remove.
11215 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
11216 Merge in code from ...
11217 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
11218 * class.cs, enum.cs: Update to changes.
11220 2005-01-06 Miguel de Icaza <miguel@ximian.com>
11222 * anonymous.cs: Ensure that we init the scope of our parent if it
11223 has not been initialized yet.
11225 2004-12-30 Duncan Mak <duncan@ximian.com>
11227 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
11228 if field.FieldBuilder is null. Fixes #70758.
11230 * convert.cs: Fixed some typos and updated some of the comments.
11231 (ImplicitStandardConversionExists):
11232 (TryImplicitIntConversion): If `target_type' is an interface and
11233 the type of `ic' implements this interface, return true or a new
11234 BoxedCast instead of null. This fixes #70468.
11236 2004-12-29 Duncan Mak <duncan@ximian.com>
11238 * expression.cs (Argument.Emit): Check that Expr is
11239 IMemoryLocation before casting to it, and report CS1510 otherwise.
11243 2004-12-21 Ben Maurer <bmaurer@ximian.com>
11245 * statement.cs (Block.ThisVariable): remove the recursion here, to
11246 make the --profile more sane.
11248 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
11250 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
11251 assembly, by JB Evain.
11253 2004-12-17 Raja R Harinath <rharinath@novell.com>
11255 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
11256 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
11257 "parent" refers to enclosing type/class. "base" refers to superclass.
11259 2004-12-17 Raja R Harinath <rharinath@novell.com>
11261 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11262 Ensure that we only have GlobalAttributes.
11263 * attribute.cs (Attribute.Emit): Make non-virtual.
11264 (GlobalAttribute.Emit): Remove.
11265 (Attribute.Resolve): Make virtual.
11266 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
11267 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
11268 the argument. Don't create one.
11269 (Attribute.GetObsoleteAttribute): Likewise.
11270 (Attribute.GetClsCompliantAttributeValue): Likewise.
11271 * class.cs, decl.cs: Update to changes.
11273 2004-12-17 Marek Safar <marek.safar@seznam.cz>
11275 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
11277 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
11279 * statement.cs (Foreach.Resolve): Add error 186 report.
11281 2004-12-16 Marek Safar <marek.safar@seznam.cz>
11283 * expression.cs (Conditional.DoResolve): Add warning 429.
11285 * statement.cs (If.Resolve): Add warning 665.
11287 2004-12-16 Raja R Harinath <rharinath@novell.com>
11289 New invariant: RootContext.Tree.Types.NamespaceEntry == null
11290 except when in the parser, and in GlobalAttribute.
11291 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
11292 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
11293 RootContext.Tree.Types.NamespaceEntry once work is done.
11294 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
11295 and resets RootContext.Tree.Types.NamespaceEntry.
11297 2004-12-15 Marek Safar <marek.safar@seznam.cz>
11299 * cs-parser.jay: Don't create a block for every variable.
11301 2004-12-14 Miguel de Icaza <miguel@ximian.com>
11303 * location.cs: Provide extra information.
11305 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
11306 variables from the captured environment, it is the ldarg_0.
11308 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11310 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
11313 * class.cs: Changed warning level for 169 to avoid developer
11314 displeasure from warning flooding. It will be changed back when they
11315 fix most of current BCL warnings.
11317 * RootContext.cs: Pushed default WarningLevel to 3.
11319 * statement.cs: Removed unused variable.
11321 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11323 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
11324 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
11325 Add error 502 report.
11326 (StaticClass.DefineType): Add error 441 report.
11327 (Class.AllowedModifiersProp): New virtual property as temporary
11328 extension to AllowedModifiers.
11329 (Class.DefineType): Add error 418 report. Moved ModFlags check here
11330 to share implementation with StaticClass and don't call virtual
11333 * driver.cs (MainDriver): Add error 1558 test.
11335 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
11336 report. Moved error 36 test here.
11338 * statement.cs (Throw.Resolve): Add error 724 report.
11340 * typemanager.cs: Add out_attribute_type core type.
11342 2004-12-13 Marek Safar <marek.safar@seznam.cz>
11344 * class.cs (TypeContainer.VerifyClsCompliance): Add error
11346 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
11348 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
11351 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
11353 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
11354 Add error 3023 report.
11355 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
11357 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
11360 2004-12-12 John Luke <john.luke@gmail.com>
11362 * driver.cs (AddArgs): take -- into account when
11363 adding arguments, fixes bug 65710
11365 2004-12-12 Martin Baulig <martin@ximian.com>
11367 * expression.cs (Unary.TryReduceNegative): Added support for
11368 SByteConstant and ByteConstant.
11369 (Unary.Reduce): Check error values from TryReduceNegative().
11371 2004-12-10 Marek Safar <marek.safar@seznam.cz>
11373 * attributes.cs (Attribute.Resolve): Avoid multiple error report
11374 and report exception as error 182.
11376 2004-12-10 Raja R Harinath <rharinath@novell.com>
11378 * driver.cs (Main): Fix message when there are warnings.
11380 2004-12-09 Miguel de Icaza <miguel@ximian.com>
11382 * delegate.cs: Fixed my fix from yesterday, sorry about that.
11384 2004-12-09 Marek Safar <marek.safar@seznam.cz>
11386 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
11387 Reduced number of warnings.
11389 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
11391 2004-12-08 Miguel de Icaza <miguel@ximian.com>
11393 * driver.cs: Removed message.
11395 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
11397 2004-12-08 <vargaz@freemail.hu>
11399 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
11401 2004-12-08 Martin Baulig <martin@ximian.com>
11403 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
11404 instead of a CS3002 for properties and indexer.
11406 2004-12-08 Martin Baulig <martin@ximian.com>
11408 * decl.cs (MemberName.ToString): Make this work again.
11410 2004-12-08 Marek Safar <marek.safar@seznam.cz>
11412 * attribute.cs (Resolve): Add error 591 detection.
11414 * class.cs (FieldMember.Define): Add error 1547 detection.
11415 (Indexer.Define): Add error 620 detection.
11416 (Operator.Define): Add error 590 detection.
11418 * ecore.cs: Missing argument for error 79.
11420 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
11423 2004-12-07 Marek Safar <marek.safar@seznam.cz>
11426 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
11429 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
11431 * cs-parser.jay : handle doc comments on implicit/explicit operators.
11432 Some operator comments were suppressed.
11433 * doc.cs : Implicit/explicit operator name in doc comments are like
11434 "op_Explicit(type)~returnType", so added suffix handling.
11436 2004-12-07 Martin Baulig <martin@ximian.com>
11439 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
11440 (MemberCore.GetClsCompliantAttributeValue): Likewise.
11441 (DeclSpace.ec): New protected field; store the EmitContext here.
11442 (DeclSpace.EmitContext): New public property; moved here from
11444 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
11447 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
11448 (Enum.Emit): Don't create a new EmitContext.
11450 * delegate.cs (Delegate.DefineType): Always create the
11453 * iterators.cs (Iterators.DefineIterator): Create a new
11454 EmitContext and store it in `ec'.
11456 2004-08-24 Martin Baulig <martin@ximian.com>
11459 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
11460 this for accessibility checks.
11461 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
11462 IsNestedFamilyAccessible.
11463 (TypeManager.IsSubclassOf): New method, do what the name actually
11466 2004-12-06 Raja R Harinath <rharinath@novell.com>
11468 Fix crash on cs0657-17.cs.
11469 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11470 Use RootContext.Tree.Types, not 'new RootTypes ()'.
11471 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
11472 the case where the NamespaceEntry gets overwritten.
11474 2004-12-06 Marek Safar <marek.safar@seznam.cz>
11476 Fixed #69195, #56821
11477 * ecore.cs (ResolveBoolean): Tiny refactoring.
11479 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
11480 of right expression resolving when left is false constant and
11481 operator is LogicalAnd OR true constant and operator is LogicalOr.
11483 * statement.cs (ResolveUnreachable): Always reports warning.
11485 2004-12-05 Miguel de Icaza <miguel@ximian.com>
11487 * class.cs: Distinguish between 1721 and 1722 (just a little help
11488 for the programmer).
11490 2004-12-03 Miguel de Icaza <miguel@ximian.com>
11492 * delegate.cs: Only allow this on new versions of the language.
11494 2004-12-02 Duncan Mak <duncan@ximian.com>
11496 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
11498 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
11499 here as a static method. Take an additional bool out parameter
11500 `must_do_cs1540_check' for signaling to InstanceResolve.
11501 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
11502 member field from PropertyExpr class and made it an argument of
11503 the method instead.
11504 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
11505 check for MarshalByRefObject, and report CS0122 instead of CS1540.
11506 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
11507 and `remove_accessor' as well as InstanceResolve: report CS0122
11512 2004-12-03 Raja R Harinath <rharinath@novell.com>
11514 Fix test-327.cs, test-328.cs, and put in early infrastructure
11515 for eventually fixing #52697.
11516 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
11517 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
11518 from other methods.
11519 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
11520 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
11521 (VerifyUsing, error246): Update.
11522 * rootcontext.cs (RootContext.NamespaceLookup): Just use
11523 'NamespaceEntry.LookupNamespaceOrType'.
11525 2004-12-03 Martin Baulig <martin@ximian.com>
11527 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11528 method as our child, call AnonymousMethod.Compatible() on it.
11530 2004-12-03 Raja R Harinath <rharinath@novell.com>
11532 Disable XML documentation support in 'basic' profile.
11533 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
11534 Redirect XmlElement to System.Object.
11535 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
11536 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
11537 * mcs.exe.sources: Add doc-bootstrap.cs.
11538 * doc-bootstrap.cs: New file. Contains empty stub implementation
11541 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
11543 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
11544 comments are allowed.
11546 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11548 * delegate.cs: Add checks for subtypes in paramaters and return values
11549 in VerifyMethod () to add support for Covariance/Contravariance
11552 2004-12-02 Miguel de Icaza <miguel@ximian.com>
11554 * report.cs: Remove extra closing parenthesis.
11556 * convert.cs (Error_CannotImplicitConversion): If the name of the
11557 types are the same, provide some extra information.
11559 * class.cs (FieldBase): Use an unused bit field from the field to
11560 encode the `has_offset' property from the FieldMember. This saves
11561 a couple of Ks on bootstrap compilation.
11563 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11564 method as our child, return the AnonymousMethod resolved
11567 * expression.cs (New.DoResolve): Allow return values from
11568 NewDelegate to also include AnonymousMethods.
11572 2004-12-02 Marek Safar <marek.safar@seznam.cz>
11575 * attribute.cs (Resolve): Improved implementation of params
11576 attribute arguments.
11578 * support.cs (ParameterData): Add HasParams to be faster.
11580 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
11582 all things are for /doc support:
11584 * doc.cs: new file that supports XML documentation generation.
11585 * mcs.exe.sources: added doc.cs.
11587 Handle /doc command line option.
11588 Report error 2006 instead of 5 for missing file name for /doc.
11589 Generate XML documentation when required, after type resolution.
11591 Added support for picking up documentation (/// and /** ... */),
11592 including a new XmlCommentState enumeration.
11594 Added lines to fill Documentation element for field, constant,
11595 property, indexer, method, constructor, destructor, operator, event
11596 and class, struct, interface, delegate, enum.
11597 Added lines to warn incorrect comment.
11599 Added Documentation field (passed only when /doc was specified).
11601 Added DocComment, DocCommentHeader, GenerateDocComment() and
11602 OnGenerateDocComment() and some supporting private members for
11603 /doc feature to MemberCore.
11605 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
11607 Added overriden DocCommentHeader.
11609 Added overriden DocCommentHeader and GenerateDocComment().
11611 2004-12-01 Miguel de Icaza <miguel@ximian.com>
11613 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
11614 unwrapping the enumeration values, chain to
11615 DoConstantNumericPromotions again, so we can promote things to the
11616 fundamental types (takes care of enums that are bytes, sbytes).
11620 2004-12-01 Raja R Harinath <rharinath@novell.com>
11622 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
11623 Fix long-standing bug in type-lookup. Use FindType instead of
11624 LookupType when ec.ResolvingTypeTree.
11625 (Attribute.ResolveType, Attribute.Resolve)
11626 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
11628 (Attributes.Search): Remove internal version. Update.
11629 (Attributes.SearchMulti): Update.
11630 (Attributes.GetClsCompliantAttribute): Remove.
11631 (Attributes.GetIndexerNameAttribute): Remove.
11632 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
11633 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
11634 * class.cs (Indexer.Define): Likewise.
11636 2004-12-01 Marek Safar <marek.safar@seznam.cz>
11639 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
11640 MarshallByReference members access.
11642 * expression.cs: Use CheckMarshallByRefAccess;
11643 Better error CS0197 message.
11645 * report.cs: Print whole related error message.
11647 2004-11-30 Raja R Harinath <rharinath@novell.com>
11649 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
11650 the current directory to help debugging.
11652 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11654 * class (GetClassBases): Better error 60 report.
11655 (EventProperty): Disabled warning 67 detection.
11657 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11660 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
11662 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
11665 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11668 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
11670 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
11672 2004-11-26 Miguel de Icaza <miguel@ximian.com>
11674 * attribute.cs (Attribute.Resolve): Refine error reporting and
11675 report a cs0117 if the identifier does not exist, to distinguish
11676 from 0617 which is a miss-use of the actual identifier.
11678 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
11679 between cs0070 and cs0079.
11681 * class.cs (MemberBase.DoDefine): When reporting a wrong
11682 accessibility level, we use MethodCore to compare instead of
11683 Method (this was a regression in some refactoring effort).
11685 So now we correctly report cs0056 again.
11687 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
11688 testing the target_type (which was known to be object_type) and
11689 not the source type (which is anonymous_method).
11691 Fixed reporting of error cs1660.
11693 * expression.cs (UserCast.Source): Expose the underlying cast.
11695 * statement.cs (Switch.SwitchGoverningType): Sort the list of
11696 allowed types to find a match to int32 first (most common).
11698 In addition, it ignores any ImplicitUserConversions that did an
11699 internal implicit conversion (as the switch statement allows only
11700 one integral conversion to exist).
11702 * class.cs (PartialContainer.Create): rename `name' to
11703 `member_name' for clarity. Then replace the string calls with a
11704 call to MemberName.GetPartialName, as now using
11705 MemberName.ToString is an error (this is due to the side effects
11706 it had, that were fixed in the past).
11708 This will restore the error reporting on a number of partial class
11709 errors that were missusing this (and getting an exception as a
11710 results, which is now just a plain textual warning, because
11711 yyparse debug output would crash otherwise).
11713 2004-11-26 Raja R Harinath <rharinath@novell.com>
11715 * Makefile (PROGRAM_INSTALL_DIR): Remove.
11717 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11719 * rootcontext.cs (LookupType): Make sure to cache lookups that
11720 don't give us a negative result. This saves about 5% of corlib
11723 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11725 * report.cs (AbstractMessage.Print): messages are sent to stderr
11727 * class.cs (TypeContainer.GetClassBases): It is an error to have a
11728 non-interface in the list of interfaces (at this point, either
11729 parent was properly set, or a base class is being listed in the
11730 interfaces section).
11732 This flags error 1722, and resolves the crash from bug 69259.
11734 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11736 * statement.cs (Using.EmitExpressionFinally): make this work right
11737 for valuetypes. Fixes 69926.
11739 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11741 * const.cs (Const.ChangeType): Cope with the "0 literal can be
11742 converted to an enum" here, before we try to change the underlying
11743 type. This code exists, but it is a different code path than the
11744 one used while encoding constants.
11746 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
11747 old bug: when converting from the null literal to a pointer,
11748 return an EmptyCast, not the NullLiteral.
11750 This fixes #69921, the recent null_type changes probably made this
11751 bug more prominent.
11753 (ImplicitReferenceConversionExists): In addition, resynchronized
11754 the code here, so it matches the same code in
11755 ImplicitReferenceConversionExists for the `from any class-type S
11756 to any interface-type T'.
11759 2004-11-25 Marek Safar <marek.safar@seznam.cz>
11761 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
11763 2004-11-24 Miguel de Icaza <miguel@ximian.com>
11765 * cs-parser.jay: Use verbosity accordingly.
11767 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11769 * expression.cs (Unary.ResolveOperator): Do not report warning;
11770 AddressOf reads from variable.
11772 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
11774 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11778 * attribute.cs (Attributable): Removed CheckTargets.
11779 (Attributes.Emit): Explicit attribute targets are tested here.
11781 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
11782 not enabled for interfaces.
11784 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
11785 (GetAssemblyName): Ouch next bug there.
11787 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11789 * expression.cs: Error 275 added.
11791 2004-11-23 Marek Safar <marek.safar@seznam.cz>
11793 Fix bug #69177 (Implemented decimal constant support)
11795 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
11796 (BinaryFold): Add DecimalConstant.
11798 * const.cs (Define): Decimal constant
11800 (ChangeType): Add decimal type handling.
11801 (LookupConstantValue): Don't set value for decimal type but
11802 emit DecimalConstantAttribute. Needed for constant optimization.
11804 * constant.cs (ToDecimal): New method.
11805 (ConvertToDecimal): New method.
11806 (IntConstant): Implemented ConvertToDecimal.
11807 (DecimalConstant.Emit): Emit optimized version for decimals in
11810 * expression.cs (ResolveOperator): Changed order of constant
11811 reduction to work correctly with native types which have
11812 overloaded operators.
11813 (ResolveMemberAccess): Extract constant value from attribute
11816 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
11818 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
11819 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
11820 (ChangeType): Decimal is special.
11821 (TypeToCoreType): Add decimal type.
11823 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11825 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
11828 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11830 * class.cs (EventField.ApplyAttributeBuilder): Fix error
11833 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11835 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
11837 * pending.cs (PendingImplementation): Grab only interfaces.
11839 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11841 * statement.cs (ForeachHelperMethods): Add location member and
11842 error 202 detection.
11844 2004-11-19 Raja R Harinath <rharinath@novell.com>
11846 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
11847 automatically handled by executable.make.
11848 (PROGRAM): Make profile-specific.
11850 2004-11-18 Marek Safar <marek.safar@seznam.cz>
11852 * expression.cs (DoResolveBase): Fixed wrong warning for out
11855 2004-11-18 Martin Baulig <martin@ximian.com>
11857 Merged latest changes into gmcs. Please keep this comment in
11858 here, it makes it easier for me to see what changed in MCS since
11859 the last time I merged.
11861 2004-11-17 Raja R Harinath <rharinath@novell.com>
11863 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11864 (TypeHandle.GetMemberCache): New.
11865 (TypeHandle.TypeHandle): Update.
11866 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11867 (TypeManager.LookupParentInterfacesCache):
11868 Rename from LookupInterfaceCache. Optimize slightly.
11869 (TypeManager.MemberLookup_FindMembers): Update.
11870 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11871 multi-type variant.
11872 (AddCacheContents): Rename from AddHashtable.
11873 * class.cs (TypeContainer.parent_container): Remove.
11874 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11875 (TypeContainer.DoDefineMembers): Don't initialize it.
11876 Update to name changes.
11878 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11880 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11881 that factors the code to check access modifiers on override.
11883 (PropertyBase): Use the code here.
11885 Patch from Lluis S'anchez, fixes bug #69361.
11887 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11889 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11890 routine that is used to report the use of a captured variable
11891 whose address has been taken.
11893 There are two checks: one when variables are being captured and
11894 the other check is when the address of a variable is taken.
11896 (because an anonymous methods might be resolved before *or* after
11897 the address has been taken) and
11899 * expression.cs (Conditional.DoResolve): Remove the special
11900 casing that Martin added to trueExpr and falseExpr being both
11901 NullLiteral. We get the right behavior now just by introducing
11902 the null_type into the compiler.
11904 * convert.cs (ExplicitConversion): Change the code to use
11905 null_type instead of testing `expr is NullLiteral'.
11906 (ImplicitConversionStandard): use null_type too.
11907 (ImplicitReferenceConversionExists): use null_type too.
11908 (ImplicitReferenceConversion): use null_type too.
11910 * literal.cs: The type of `NullLiteral' is now null_type instead
11912 (Resolve): Set the type here.
11914 * typemanager.cs: Introduce null_type.
11916 2004-11-17 Martin Baulig <martin@ximian.com>
11918 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11919 direction, like FindMembers() does. Fixes #69546, testcase is in
11922 2004-11-16 Martin Baulig <martin@ximian.com>
11924 This is based on a patch from Marek Safar, see bug #69082.
11925 Fixes bugs #63705 and #67130.
11927 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11928 method; create a MemberCache for an interface type and cache the
11931 * decl.cs (IMemberContainer.ParentContainer): Removed.
11932 (IMemberContainer.ParentCache): New property.
11933 (MemberCache.SetupCacheForInterface): Removed.
11934 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11935 to create a cache for an interface's "parent".
11937 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11940 2004-11-16 Martin Baulig <martin@ximian.com>
11942 Merged back from gmcs; these changes already went into gmcs a
11943 couple of weeks ago.
11946 (TypeManager.AddUserType): Removed the `ifaces' argument.
11947 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11949 (TypeManager.AddUserInterface): Removed.
11950 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11952 (TypeManager.GetInterfaces): Likewise.
11953 (TypeManager.GetExplicitInterfaces): Likewise.
11955 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11957 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11958 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11960 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11962 * statement.cs: Avoid adding bools to a hashtable.
11964 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11966 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11967 calling an unsafe method from a safe location.
11969 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11972 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11974 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11976 * namespace.cs (VerifyUsing): use GetPartialName instead of
11979 2004-11-05 Miguel de Icaza <miguel@ximian.com>
11981 * statement.cs (Return.Resolve): Fix regression in typo: if
11982 `in_exc', we have to request a NeedReturnLabel, this was a typo
11983 introduced in the anonymous method check-in. Fixes #69131.
11985 * Indexers were using the ShortName when defining themselves,
11986 causing a regression in the compiler bootstrap when applying the
11987 patch from 2004-11-02 (first part), now they use their full name
11988 and the bug is gone.
11990 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
11992 * driver.cs: Strip the path from the names of embedded resources. Fixes
11995 2004-11-04 Raja R Harinath <rharinath@novell.com>
11997 Fix error message regression: cs0104-2.cs.
11998 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
11999 (AliasEntry.Resolve): Update.
12000 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
12002 (RootContext.LookupType): Update.
12004 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
12006 * cs-parser.jay: Add support for handling accessor modifiers
12007 * class: Add support port accessor modifiers and error checking,
12008 define PropertyMethod.Define as virtual (not abstract anymore)
12009 * ecore.cs: Add checking for proeprties access with access modifiers
12010 * iterators.cs: Modify Accessor constructor call based in the modified
12012 2004-11-02 Ben Maurer <bmaurer@ximian.com>
12014 * expression.cs (StringConcat): Handle being called twice,
12015 as when we have a concat in a field init with more than two
12018 2004-11-02 Miguel de Icaza <miguel@ximian.com>
12020 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
12021 special case explicit implementations, we should always produce
12022 the .property or .event declaration.
12024 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
12025 since it will not return correct data if people use this
12026 unresolved in the presence of using statements (see test-313).
12028 * class.cs (MethodData.Define): If we are an explicit interface
12029 implementation, set the method name to the full name of the
12030 interface plus the name of the method.
12032 Notice that using the method.MethodName.GetFullName() does not
12033 work, as it will only contain the name as declared on the source
12034 file (it can be a shorthand in the presence of using statements)
12035 and not the fully qualifed type name, for example:
12039 class D : ICloneable {
12040 object ICloneable.Clone () {
12044 Would produce a method called `ICloneable.Clone' instead of
12045 `System.ICloneable.Clone'.
12047 * namespace.cs (Alias.Resolve): Use GetPartialName.
12049 2004-11-01 Marek Safar <marek.safar@seznam.cz>
12051 * cs-parser.jay: Add error 1055 report.
12053 2004-11-01 Miguel de Icaza <miguel@ximian.com>
12055 * assign.cs (Assign.DoResolve): Only do the transform of
12056 assignment into a New if the types are compatible, if not, fall
12057 through and let the implicit code deal with the errors and with
12058 the necessary conversions.
12060 2004-11-01 Marek Safar <marek.safar@seznam.cz>
12062 * cs-parser.jay: Add error 1031 report.
12064 * cs-tokenizer.cs: Add location for error 1038.
12066 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12068 * cs-parser.jay: Add error 1016 report.
12070 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12072 * cs-parser.jay: Add errors 1575,1611 report.
12074 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12076 * cs-parser.jay: Add error 1001 report.
12078 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12081 * attribute.cs (GetMarshal): Add method argument for
12082 caller identification.
12084 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
12085 agument for GetMarshal and RuntimeMissingSupport.
12087 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12089 * attribute.cs (ExtractSecurityPermissionSet): Removed
12090 TypeManager.code_access_permission_type.
12092 * typemanager.cs: Removed TypeManager.code_access_permission_type.
12094 2004-10-27 Miguel de Icaza <miguel@ximian.com>
12096 * expression.cs (LocalVariableReference.DoResolveLValue): Check
12097 for obsolete use of a variable here. Fixes regression on errors
12098 cs0619-25 and cs0619-26.
12100 2004-10-27 Marek Safar <marek.safar@seznam.cz>
12102 Fix #62358, implemented security attribute encoding.
12104 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
12105 Tests permitted SecurityAction for assembly or other types.
12106 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
12107 data from SecurityPermissionAttribute to PermisionSet class.
12109 * class.cs (ApplyAttributeBuilder): Added special handling
12110 for System.Security.Permissions.SecurityAttribute based types.
12112 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
12113 special handling for System.Security.Permissions.SecurityAttribute
12116 * enum.cs (ApplyAttributeBuilder): Added special handling
12117 for System.Security.Permissions.SecurityAttribute based types.
12119 * parameter.cs (ApplyAttributeBuilder): Added special handling
12120 for System.Security.Permissions.SecurityAttribute based types.
12122 * rootcontext.cs: Next 2 core types.
12124 * typemanager.cs (TypeManager.security_permission_attr_type):
12125 Built in type for the SecurityPermission Attribute.
12126 (code_access_permission_type): Build in type.
12128 2004-10-17 Miguel de Icaza <miguel@ximian.com>
12130 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
12131 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
12132 all of this information into
12133 EmitContext.EmitCapturedVariableInstance.
12135 * codegen.cs (EmitCapturedVariableInstance): move here the
12136 funcionality of emitting an ldarg.0 in the presence of a
12137 remapping. This centralizes the instance emit code.
12139 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
12140 then emit a load of this: it means that we have reached the
12141 topmost ScopeInfo: the one that contains the pointer to the
12142 instance of the class hosting the anonymous method.
12144 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
12145 captures to the topmost CaptureContext.
12147 2004-10-12 Miguel de Icaza <miguel@ximian.com>
12149 * expression.cs (LocalVariableReference): Move the knowledge about
12150 the iterators into codegen's EmitCapturedVariableInstance.
12152 2004-10-11 Miguel de Icaza <miguel@ximian.com>
12154 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
12155 all code paths return a value from an anonymous method (it is the
12156 same as the 161 error, but for anonymous methods).
12158 2004-10-08 Miguel de Icaza <miguel@ximian.com>
12160 The introduction of anonymous methods in the compiler changed
12161 various ways of doing things in the compiler. The most
12162 significant one is the hard split between the resolution phase
12163 and the emission phases of the compiler.
12165 For instance, routines that referenced local variables no
12166 longer can safely create temporary variables during the
12167 resolution phase: they must do so from the emission phase,
12168 since the variable might have been "captured", hence access to
12169 it can not be done with the local-variable operations from the runtime.
12173 (Block.Flags): New flag `IsTopLevel' to indicate that this block
12174 is a toplevel block.
12176 (ToplevelBlock): A new kind of Block, these are the blocks that
12177 are created by the parser for all toplevel method bodies. These
12178 include methods, accessors and anonymous methods.
12180 These contain some extra information not found in regular blocks:
12181 A pointer to an optional CaptureContext (for tracking captured
12182 local variables and parameters). A pointer to the parent
12185 (Return.Resolve): Catch missmatches when returning a value from an
12186 anonymous method (error 1662).
12187 Invoke NeedReturnLabel from the Resolve phase instead of the emit
12190 (Break.Resolve): ditto.
12192 (SwitchLabel): instead of defining the labels during the
12193 resolution phase, we now turned the public ILLabel and ILLabelCode
12194 labels into methods called GetILLabelCode() and GetILLabel() that
12195 only define the label during the Emit phase.
12197 (GotoCase): Track the SwitchLabel instead of the computed label
12198 (its contained therein). Emit the code by using
12199 SwitchLabel.GetILLabelCode ().
12201 (LocalInfo.Flags.Captured): A new flag has been introduce to track
12202 whether the Local has been captured or not.
12204 (LocalInfo.IsCaptured): New property, used to tell whether the
12205 local has been captured.
12207 * anonymous.cs: Vastly updated to contain the anonymous method
12210 The main classes here are: CaptureContext which tracks any
12211 captured information for a toplevel block and ScopeInfo used to
12212 track the activation frames for various local variables.
12214 Each toplevel block has an optional capture context associated
12215 with it. When a method contains an anonymous method both the
12216 toplevel method and the anonymous method will create a capture
12217 context. When variables or parameters are captured, they are
12218 recorded on the CaptureContext that owns them, for example:
12222 MyDelegate d = delegate {
12227 Here `a' will be recorded as captured on the toplevel
12228 CapturedContext, the inner captured context will not have anything
12229 (it will only have data if local variables or parameters from it
12230 are captured in a nested anonymous method.
12232 The ScopeInfo is used to track the activation frames for local
12233 variables, for example:
12235 for (int i = 0; i < 10; i++)
12236 for (int j = 0; j < 10; j++){
12237 MyDelegate d = delegate {
12242 At runtime this captures a single captured variable `i', but it
12243 captures 10 different versions of the variable `j'. The variable
12244 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
12245 recorded on a child.
12247 The toplevel ScopeInfo will also track information like the `this'
12248 pointer if instance variables were referenced (this is necessary
12249 as the anonymous method lives inside a nested class in the host
12250 type of the method).
12252 (AnonymousMethod): Expanded to track the Toplevel, implement
12253 `AnonymousMethod.Compatible' to tell whether an anonymous method
12254 can be converted to a target delegate type.
12256 The routine now also produces the anonymous method content
12258 (AnonymousDelegate): A helper class that derives from
12259 DelegateCreation, this is used to generate the code necessary to
12260 produce the delegate for the anonymous method that was created.
12262 * assign.cs: API adjustments for new changes in
12263 Convert.ImplicitStandardConversionExists.
12265 * class.cs: Adjustments to cope with the fact that now toplevel
12266 blocks are of type `ToplevelBlock'.
12268 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
12269 insteda of standard blocks.
12271 Flag errors if params arguments are passed to anonymous methods.
12273 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
12274 `CurrentAnonymousMethod' which points to the current Anonymous
12275 Method. The variable points to the AnonymousMethod class that
12276 holds the code being compiled. It is set in the new EmitContext
12277 created for the anonymous method.
12279 (EmitContext.Phase): Introduce a variable and an enumeration to
12280 assist in enforcing some rules about when and where we are allowed
12281 to invoke certain methods (EmitContext.NeedsReturnLabel is the
12282 only one that enfonces this right now).
12284 (EmitContext.HaveCaptureInfo): new helper method that returns
12285 whether we have a CapturedContext initialized.
12287 (EmitContext.CaptureVariable): New method used to register that a
12288 LocalInfo must be flagged for capturing.
12290 (EmitContext.CapturedParameter): New method used to register that a
12291 parameters must be flagged for capturing.
12293 (EmitContext.CapturedField): New method used to register that a
12294 field must be flagged for capturing.
12296 (EmitContext.HaveCapturedVariables,
12297 EmitContext.HaveCapturedFields): Return whether there are captured
12298 variables or fields.
12300 (EmitContext.EmitMethodHostInstance): This is used to emit the
12301 instance for the anonymous method. The instance might be null
12302 (static methods), this (for anonymous methods that capture nothing
12303 and happen to live side-by-side with the current method body) or a
12304 more complicated expression if the method has a CaptureContext.
12306 (EmitContext.EmitTopBlock): Routine that drives the emission of
12307 code: it will first resolve the top block, then emit any metadata
12308 and then emit the code. The split is done so that we can extract
12309 any anonymous methods and flag any captured variables/parameters.
12311 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
12312 during this phase, the ILGenerator should not be used as labels
12313 and local variables declared here might not be accessible to any
12314 code that is part of an anonymous method.
12316 Exceptions to this include the temporary variables that are
12317 created by some statements internally for holding temporary
12320 (EmitContext.EmitMeta): New routine, in charge of emitting all the
12323 (EmitContext.TemporaryReturn): This method is typically called
12324 from the Emit phase, and its the only place where we allow the
12325 ReturnLabel to be defined other than the EmitMeta. The reason is
12326 that otherwise we would have to duplicate a lot of logic in the
12327 Resolve phases of various methods that today is on the Emit
12330 (EmitContext.NeedReturnLabel): This no longer creates the label,
12331 as the ILGenerator is not valid during the resolve phase.
12333 (EmitContext.EmitThis): Extended the knowledge in this class to
12334 work in anonymous methods in addition to iterators.
12336 (EmitContext.EmitCapturedVariableInstance): This emits whatever
12337 code is necessary on the stack to access the instance to a local
12338 variable (the variable will be accessed as a field).
12340 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
12341 EmitContext.EmitAddressOfParameter): Routines to support
12342 parameters (not completed at this point).
12344 Removals: Removed RemapLocal and RemapLocalLValue. We probably
12345 will also remove the parameters.
12347 * convert.cs (Convert): Define a `ConstantEC' which points to a
12348 null. This is just to prefity some code that uses
12349 ImplicitStandardConversion code and do not have an EmitContext
12352 The idea is to flag explicitly that at that point in time, it is
12353 known that the conversion will not trigger the delegate checking
12354 code in implicit conversions (which requires a valid
12357 Everywhere: pass new EmitContext parameter since
12358 ImplicitStandardConversionExists now requires it to check for
12359 anonymous method conversions.
12361 (Convert.ImplicitStandardConversionExists): If the type of an
12362 expression is the anonymous_method_type, and the type is a
12363 delegate, we invoke the AnonymousMethod.Compatible method to check
12364 whether an implicit conversion is possible.
12366 (Convert.ImplicitConversionStandard): Only do implicit method
12367 group conversions if the language level is not ISO_1.
12369 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
12370 MethodInfo for the Invoke method. used by Delegate and
12373 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
12374 method conversions if the target type is a delegate.
12376 Removed extra debugging nops.
12378 (LocalVariableReference): Turn the `local_info' into a public
12381 Add `prepared' field, the same hack used for FieldExprs to cope
12382 with composed assignments, as Local variables do not necessarily
12383 operate purely on the stack as they used to: they can be captured
12386 Add `temp' for a temporary result, like fields.
12388 Refactor DoResolve and DoResolveLValue into DoResolveBase.
12390 It now copes with Local variables that are captured and emits the
12391 proper instance variable to load it from a field in the captured
12394 (ParameterReference.DoResolveBase): During the resolve phase,
12395 capture parameters if we are in an anonymous method.
12397 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
12398 anonymous method, use the EmitContext helper routines to emit the
12399 parameter reference.
12401 * iterators.cs: Set RemapToProxy to true/false during the
12404 * parameters.cs (GetParameterByName): New helper method.
12406 * typemanager.cs (anonymous_method_type) a new type that
12407 represents an anonyous method. This is always an internal type,
12408 used as a fencepost to test against the anonymous-methodness of an
12411 2004-10-20 Marek Safar <marek.safar@seznam.cz>
12413 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
12415 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
12417 2004-10-18 Martin Baulig <martin@ximian.com>
12419 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
12420 `Type' directly, but call ResolveType() on it.
12421 (Catch.Resolve): Likewise.
12422 (Foreach.Resolve): Likewise.
12424 2004-10-18 Martin Baulig <martin@ximian.com>
12426 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
12427 `Type' directly, but call ResolveType() on it.
12428 (Probe.DoResolve): Likewise.
12429 (ArrayCreation.LookupType): Likewise.
12430 (TypeOf.DoResolve): Likewise.
12431 (SizeOf.DoResolve): Likewise.
12433 2004-10-18 Martin Baulig <martin@ximian.com>
12435 * expression.cs (Invocation.BetterFunction): Put back
12436 TypeManager.TypeToCoreType().
12438 2004-10-18 Raja R Harinath <rharinath@novell.com>
12440 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
12443 2004-10-18 Martin Baulig <martin@ximian.com>
12445 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
12446 `Type' directly, but call ResolveType() on it.
12448 2004-10-18 Martin Baulig <martin@ximian.com>
12450 * class.cs (FieldMember.Define): Don't access the TypeExpr's
12451 `Type' directly, but call ResolveType() on it.
12452 (MemberBase.DoDefine): Likewise.
12454 * expression.cs (New.DoResolve): Don't access the TypeExpr's
12455 `Type' directly, but call ResolveType() on it.
12456 (ComposedCast.DoResolveAsTypeStep): Likewise.
12458 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
12459 `Type' directly, but call ResolveType() on it.
12461 2004-10-17 John Luke <john.luke@gmail.com>
12463 * class.cs (Operator.GetSignatureForError): use CSharpName
12465 * parameter.cs (Parameter.GetSignatureForError): Returns
12466 correct name even if was not defined.
12468 2004-10-13 Raja R Harinath <rharinath@novell.com>
12471 * class.cs (TypeContainer.EmitContext): New property.
12472 (DefineNestedTypes): Create an emitcontext for each part.
12473 (MethodCore.DoDefineParameters): Use container's emitcontext.
12474 Pass type array to InternalParameters.
12475 (MemberBase.DoDefine): Use container's emitcontext.
12476 (FieldMember.Define): Likewise.
12477 (Event.Define): Likewise.
12478 (SetMethod.GetParameterInfo): Change argument to EmitContext.
12479 Pass type array to InternalParameters.
12480 (SetIndexerMethod.GetParameterInfo): Likewise.
12481 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
12482 * delegate.cs (Define): Pass emitcontext to
12483 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
12484 array to InternalParameters.
12485 * expression.cs (ParameterReference.DoResolveBase): Pass
12486 emitcontext to GetParameterInfo.
12487 (ComposedCast.DoResolveAsTypeStep): Remove check on
12488 ec.ResolvingTypeTree.
12489 * parameter.cs (Parameter.Resolve): Change argument to
12490 EmitContext. Use ResolveAsTypeTerminal.
12491 (Parameter.GetSignature): Change argument to EmitContext.
12492 (Parameters.ComputeSignature): Likewise.
12493 (Parameters.ComputeParameterTypes): Likewise.
12494 (Parameters.GetParameterInfo): Likewise.
12495 (Parameters.ComputeAndDefineParameterTypes): Likewise.
12496 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
12497 * support.cs (InternalParameters..ctor): Remove variant that takes
12499 * typemanager.cs (system_intptr_expr): New.
12500 (InitExpressionTypes): Initialize it.
12502 2004-10-12 Chris Toshok <toshok@ximian.com>
12504 * cs-parser.jay: fix location for try_statement and catch_clause.
12506 2004-10-11 Martin Baulig <martin@ximian.com>
12508 * report.cs: Don't make --fatal abort on warnings, we have
12509 -warnaserror for that.
12511 2004-10-07 Raja R Harinath <rharinath@novell.com>
12513 More DeclSpace.ResolveType avoidance.
12514 * decl.cs (MemberCore.InUnsafe): New property.
12515 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
12516 with newly created EmitContext.
12517 (FieldMember.Define): Likewise.
12518 * delegate.cs (Delegate.Define): Likewise.
12519 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
12520 only if normal name-lookup fails.
12521 (TypeExpr.DoResolve): Enable error-checking.
12522 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
12523 (SizeOf.DoResolve): Likewise.
12524 (ComposedCast.DoResolveAsTypeStep): Likewise.
12525 (StackAlloc.DoResolve): Likewise.
12526 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
12527 (Block.Unsafe): New property.
12528 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
12529 (Unsafe): Set 'unsafe' flag of contained block.
12530 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
12531 (Fixed.Resolve): Likewise.
12532 (Catch.Resolve): Likewise.
12533 (Using.ResolveLocalVariableDecls): Likewise.
12534 (Foreach.Resolve): Likewise.
12536 2004-10-05 John Luke <john.luke@gmail.com>
12538 * cs-parser.jay: add location to error CS0175
12540 2004-10-04 Miguel de Icaza <miguel@ximian.com>
12542 * ecore.cs (Expression.Constantity): Add support for turning null
12545 * const.cs (Const.Define): Allow constants to be reference types
12546 as long as the value is Null.
12548 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
12550 * namespace.cs (NamespaceEntry.Using): No matter which warning
12551 level is set, check if this namespace name has already been added.
12553 2004-10-03 Ben Maurer <bmaurer@ximian.com>
12555 * expression.cs: reftype [!=]= null should always use br[true,false].
12558 2004-10-03 Marek Safar <marek.safar@seznam.cz>
12561 * attribute.cs: Enum conversion moved to
12562 GetAttributeArgumentExpression to be applied to the all
12565 2004-10-01 Raja R Harinath <rharinath@novell.com>
12567 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
12568 * class.c (TypeContainer.DefineType): Flag error if
12569 base types aren't accessible due to access permissions.
12570 * decl.cs (DeclSpace.ResolveType): Move logic to
12571 Expression.ResolveAsTypeTerminal.
12572 (DeclSpace.ResolveTypeExpr): Thin layer over
12573 Expression.ResolveAsTypeTerminal.
12574 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
12575 Refactor code into NestedAccess. Use it.
12576 (DeclSpace.NestedAccess): New.
12577 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
12578 argument to silence errors. Check access permissions.
12579 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
12580 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
12581 (Cast.DoResolve): Likewise.
12582 (New.DoResolve): Likewise.
12583 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
12584 (TypeOf.DoResolve): Likewise.
12586 * expression.cs (Invocation.BetterConversion): Return the Type of
12587 the better conversion. Implement section 14.4.2.3 more faithfully.
12588 (Invocation.BetterFunction): Make boolean. Make correspondence to
12589 section 14.4.2.2 explicit.
12590 (Invocation.OverloadResolve): Update.
12591 (Invocation): Remove is_base field.
12592 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
12593 (Invocation.Emit): Likewise.
12595 2004-09-27 Raja R Harinath <rharinath@novell.com>
12597 * README: Update to changes.
12599 2004-09-24 Marek Safar <marek.safar@seznam.cz>
12601 * cs-parser.jay: Reverted 642 warning fix.
12603 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12606 * decl.cs (FindMemberWithSameName): Indexer can have more than
12609 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12611 * expression.cs (LocalVariableReference.DoResolveLValue):
12612 Do not report warning 219 for out values.
12613 (EmptyExpression.Null): New member to avoid extra allocations.
12615 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12617 * cs-parser.jay: Fix wrong warning 642 report.
12619 * cs-tokenizer.cs (CheckNextToken): New helper;
12620 Inspect next character if is same as expected.
12622 2004-09-23 Martin Baulig <martin@ximian.com>
12624 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
12625 (Convert.ImplicitReferenceConversionExists): Likewise.
12627 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12629 * class.cs (Operator.Define): Add error 448 and 559 report.
12631 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12633 * class.cs (MemberBase.IsTypePermitted): New protected
12634 method for checking error CS0610.
12636 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12638 * class.cs (TypeContainer.HasExplicitLayout): New property
12639 Returns whether container has StructLayout attribute set Explicit.
12640 (FieldMember): New abstract class for consts and fields.
12641 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
12642 (Field): Reuse FieldMember.
12644 * const.cs (Const): Reuse FieldMember.
12646 * rootcontext.cs: EmitConstants call moved to class.
12648 2004-09-22 Martin Baulig <martin@ximian.com>
12650 Thanks to Peter Sestoft for this bug report.
12652 * expression.cs (Conditional): If both the `trueExpr' and the
12653 `falseExpr' is a NullLiteral, return a NullLiteral.
12655 2004-09-22 Martin Baulig <martin@ximian.com>
12657 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
12658 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
12659 for the "get_Current" call.
12661 2004-09-22 Martin Baulig <martin@ximian.com>
12663 Marek and me just fixed one of our oldest bugs: #28562 :-)
12665 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
12667 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
12668 we're an EnumConstant, just return that.
12669 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
12670 an EnumConstant. In this case, we need to use GetValueAsEnumType()
12671 to get the value which'll actually be written into the attribute.
12672 However, we have to use GetValue() to access the attribute's value
12675 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12677 * constant.cs (Constant.IsNegative): New abstract property
12680 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
12681 (StackAlloc.DoResolve): Reused IsNegative.
12683 2004-09-21 Martin Baulig <martin@ximian.com>
12685 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
12686 if we're used in an iterator, we may be called from different
12689 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
12690 we actually have an exception block.
12692 2004-09-20 John Luke <jluke@cfl.rr.com>
12694 * class.cs, cs-parser.jay: Improve the error report for 1520:
12695 report the actual line where the error happens, not where the
12696 class was declared.
12698 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
12699 Pass location information that was available elsewhere.
12701 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
12703 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
12704 runtime to delay sign assemblies.
12706 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12708 * cs-parser.jay: Do not report the stack trace, this is barely
12711 2004-08-22 John Luke <john.luke@gmail.com>
12713 * driver.cs : check that a resource id is not already used
12714 before adding it, report CS1508 if it is, bug #63637
12716 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12718 * ecore.cs: Removed dead code.
12720 2004-09-18 Marek Safar <marek.safar@seznam.cz>
12722 * class.cs: Do not report warning CS0067 on the interfaces.
12724 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12726 * cs-parser.jay: Add error 504 report.
12728 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12730 * rootcontext.cs: WarningLevel is 4 by default now.
12732 * statement.cs (Fixed.Resolve): Do not null
12735 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12738 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
12739 deep search when property is not virtual.
12740 (PropertyExpr.ResolveAccessors): Make one call for both
12743 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12746 * statement.cs: Error 152 report constains also location.
12748 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12751 * const.cs: Explicitly set constant as static.
12753 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12756 * cs-parser.jay: Add error 1017 report.
12758 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12760 Fixed bug #59980, #64224
12761 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
12763 * typemanager.cs (IsSpecialMethod): Simplified
12765 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12767 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
12768 condition with better params.
12770 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12773 * attribute.cs (Resolve): Property has to have both
12776 2004-09-14 Martin Baulig <martin@ximian.com>
12778 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
12780 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12783 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
12784 called and is obsolete then this member suppress message
12785 when call is inside next [Obsolete] method or type.
12787 * expression.cs: Use TestObsoleteMethodUsage member.
12789 2004-09-14 Martin Baulig <martin@ximian.com>
12791 * cs-parser.jay: Sync a bit with the GMCS version.
12793 2004-09-14 Martin Baulig <martin@ximian.com>
12795 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
12796 (CSharpParser.yacc_verbose_flag): New public field.
12798 * genericparser.cs: Removed.
12800 2004-09-14 Raja R Harinath <rharinath@novell.com>
12802 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
12804 2004-09-13 Marek Safar <marek.safar@seznam.cz>
12806 * class.cs (MethodCore.CheckBase): Fix bug #65757.
12808 2004-09-10 Martin Baulig <martin@ximian.com>
12810 Backported my MemberName changes from GMCS into MCS.
12812 - we are now using a special `MemberName' class instead of using
12813 strings; in GMCS, the `MemberName' also contains the type
12816 - changed the grammar rules a bit:
12817 * the old `member_name' is now a `namespace_or_type_name':
12818 The rule is that we use `namespace_or_type_name' everywhere
12819 where we expect either a "member name" (GetEnumerator) or a
12820 "member name" with an explicit interface name
12821 (IEnumerable.GetEnumerator).
12822 In GMCS, the explicit interface name may include type arguments
12823 (IEnumerable<T>.GetEnumerator).
12824 * we use `member_name' instead of just `IDENTIFIER' for
12826 The rule is that we use `member_name' wherever a member may
12827 have type parameters in GMCS.
12829 * decl.cs (MemberName): New public class.
12830 (MemberCore.MemberName): New public readonly field.
12831 (MemberCore.ctor): Take a `MemberName' argument, not a string.
12832 (DeclSpace): Likewise.
12834 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
12835 * enum.cs (Enum.ctor): Likewise.
12837 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
12839 (AliasEntry.ctor): Take a MemberName, not an Expression.
12840 (AliasEntry.UsingAlias): Likewise.
12842 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
12843 (IMethodData.MemberName): Changed type from string to MemberName.
12844 (MemberBase.ExplicitInterfaceName): Likewise.
12845 (AbstractPropertyEventMethod.SetupName): Make this private.
12846 (AbstractPropertyEventMethod.ctor): Added `string prefix'
12847 argument; compute the member name here.
12848 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
12849 on the `member.MemberName' and the `prefix'.
12851 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
12853 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
12854 thus, we get a `MemberName' instead of a `string'. These
12855 declarations may have type parameters in GMCS.
12856 (interface_method_declaration, delegate_declaration): Likewise.
12857 (class_declaration, interface_declaration): Likewise.
12858 (method_header): Use `namespace_or_type_name' instead of
12859 `member_name'. We may be an explicit interface implementation.
12860 (property_declaration, event_declaration): Likewise.
12861 (member_name): This is now just an `IDENTIFIER', not a
12862 `namespace_or_type_name'.
12863 (type_name, interface_type): Removed.
12864 (namespace_or_type_name): Return a MemberName, not an Expression.
12865 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12866 call GetTypeExpression() on the MemberName to get an expression.
12867 (IndexerDeclaration.interface_type): Changed type from string to
12869 (MakeName): Operate on MemberName's instead of string's.
12871 2004-09-13 Raja R Harinath <rharinath@novell.com>
12874 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12875 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12876 lookup to avoid symbols introduced by 'using'.
12877 * rootcontext.cs (NamespaceLookup): Update.
12879 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12881 * class.cs (TypeContainer.DoDefineMembers): Do not call
12882 DefineDefaultConstructor for static classes.
12884 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12886 * attribute.cs (Attribute.Resolve): Add error 653 report.
12888 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12890 (Method.ApplyAttributeBuilder): Add error 685 report.
12891 (Operator.Define): Add error 564 report.
12893 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12895 * expression.cs (Invocation.DoResolve): Add error
12896 245 and 250 report.
12898 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12901 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12903 * class.cs (ConstructorInitializer.Resolve):
12904 Wrong error number (515->516).
12906 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12908 * class.cs (Indexer.Define): Add error 631 report.
12910 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12912 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12914 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12916 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12918 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12920 * cs-parser.jay: Added error CS0241 report.
12922 2004-09-10 Raja R Harinath <rharinath@novell.com>
12924 * cs-parser.jay (fixed_statement): Introduce a scope for the
12925 declaration in the 'fixed' statement.
12927 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12929 * cs-parser.jay: Added CS0230 error report.
12931 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12933 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12935 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12937 * expression.cs (Argument.Resolve): Added error CS0192 and
12940 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12942 C# 2.0 #pragma warning feature
12944 * cs-tokenizer.cs (PreProcessPragma): New method;
12945 Handles #pragma directive.
12947 * report.cs (WarningRegions): New class; Support
12948 class for #pragma warning directive. It tests whether
12949 warning is enabled for a given line.
12951 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12953 * const.cs: Add more descriptive error report, tahnks to
12956 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12958 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12960 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12962 * expression.cs: Apply patch from Ben: Remove dead code from
12963 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12964 as that code just threw an exception anwyays.
12966 * const.cs: Remove the call to the turnintoconstant, for details
12969 * literal.cs: The type of the null-literal is the null type; So
12970 we use a placeholder type (literal.cs:System.Null, defined here)
12973 * expression.cs (Conditional.DoResolve): Remove some old code that
12974 is no longer needed, conversions have been fixed.
12976 (ArrayCreationExpression.DoResolve): Return false if we fail to
12977 resolve the inner expression.
12979 2004-09-07 Raja R Harinath <rharinath@novell.com>
12982 * cs-parser.jay (delegate_declaration): Record a delegate
12983 declaration as a type declaration.
12984 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
12986 2004-09-06 Miguel de Icaza <miguel@ximian.com>
12988 * parameter.cs: Do not crash if the type can not be resolved.
12990 * expression.cs: Report errors with unsafe pointers, fixes #64896
12992 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
12994 * expression.cs: Pointer arith always needs to do a conv.i
12995 if the operand is a long. fix 65320
12997 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12999 Fixed cs0619-37.cs, cs0619-38.cs
13001 * enum.cs (GetObsoleteAttribute): Removed.
13003 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
13004 on Enum member is double staged. The first is tested member
13007 2004-09-04 Marek Safar <marek.safar@seznam.cz>
13009 Fixed #56986, #63631, #65231
13011 * class.cs: (TypeContainer.AddToMemberContainer): New method,
13012 adds member to name container.
13013 (TypeContainer.AddToTypeContainer): New method, adds type to
13015 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
13016 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
13017 AddOperator): Simplified by reusing AddToMemberContainer.
13018 (TypeContainer.UserDefinedStaticConstructor): Changed to property
13020 (Method.CheckForDuplications): Fixed implementation to test all
13022 (MemberBase): Detection whether member is explicit interface
13023 implementation is now in constructor.
13024 (MemberBase.UpdateMemberName): Handles IndexerName.
13025 (Accessor): Changed to keep also location information.
13026 (AbstractPropertyEventMethod): Is derived from MemberCore.
13027 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
13028 will be emited or not.
13029 (PropertyBase.AreAccessorsDuplicateImplementation):
13030 Tests whether accessors are not in collision with some method.
13031 (Operator): Is derived from MethodCore to simplify common
13034 * decl.cs (Flags.TestMethodDuplication): Test for duplication
13036 (DeclSpace.AddToContainer): Adds the member to defined_names
13037 table. It tests for duplications and enclosing name conflicts.
13039 * enum.cs (EnumMember): Clean up to reuse the base structures
13041 2004-09-03 Martin Baulig <martin@ximian.com>
13043 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
13044 into TypeContainer, to make partial classes work again.
13046 2004-09-03 Martin Baulig <martin@ximian.com>
13048 * rootcontext.cs (RootContext.V2): Removed.
13050 2004-03-23 Martin Baulig <martin@ximian.com>
13052 * expression.cs (Invocation.OverloadResolve): Added `bool
13053 may_fail' argument and use it instead of the Location.IsNull() hack.
13055 2004-09-03 Martin Baulig <martin@ximian.com>
13057 Merged latest changes into gmcs. Please keep this comment in
13058 here, it makes it easier for me to see what changed in MCS since
13059 the last time I merged.
13061 2004-09-03 Raja R Harinath <rharinath@novell.com>
13064 * expression.cs (BetterConversion): Don't allow either conversion
13065 to be null. Remove redundant implicit conversion test when 'q ==
13066 null' -- when this function is invoked, we already know that the
13067 implicit conversion exists.
13068 (BetterFunction): Assume that 'best' is non-null. Remove
13069 redundant reimplementation of IsApplicable when 'best' is null.
13070 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
13071 number of arguments.
13072 (IsAncestralType): Extract from OverloadResolve.
13073 (OverloadResolve): Make robust to the MethodGroupExpr being
13074 unsorted. Implement all the logic of Section 14.5.5.1, and
13075 support overloading of methods from multiple applicable types.
13076 Clean up logic somewhat. Don't pass null methods to BetterFunction.
13078 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
13079 (RealError, Warning): Append type of report to related symbol.
13081 2004-09-03 Marek Safar <marek.safar@seznam.cz>
13083 * enum.cs: Fixed CLS-Compliance checks for enum members.
13084 Error tests cs3008-8.cs, cs3014-8.cs
13086 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13088 Fixed bug #62342, #63102
13089 * class.cs: ImplementIndexer uses member.IsExplicitImpl
13090 like ImplementMethod.
13092 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13094 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13097 2004-09-02 Martin Baulig <martin@ximian.com>
13099 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
13100 TypeManager.GetArgumentTypes() rather than calling GetParameters()
13103 2004-09-01 Marek Safar <marek.safar@seznam.cz>
13105 C# 2.0 Static classes implemented
13107 * class.cs (TypeContainer): instance_constructors,
13108 initialized_fields, initialized_static_fields,
13109 default_constructor, base_inteface_types are protected to be
13110 accessible from StaticClass.
13111 (TypeContainer.DefineDefaultConstructor): New virtual method
13112 for custom default constructor generating
13113 (StaticClass): New class to handle "Static classes" feature.
13115 * cs-parser.jay: Handle static keyword on class like instance
13118 * driver.cs: Added "/langversion" command line switch with two
13119 options (iso-1, default).
13121 2004-08-31 Marek Safar <marek.safar@seznam.cz>
13123 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
13125 2004-08-31 Miguel de Icaza <miguel@ximian.com>
13127 * delegate.cs: Style.
13129 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
13131 * delegate.cs: Add seperate instance expr field for miguel.
13133 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13135 * PointerArithmetic (Resolve): make sure we are not doing
13136 pointer arith on void*. Also, make sure we are resolved
13137 by not setting eclass until resolve.
13139 All callers: Make sure that PointerArithmetic gets resolved.
13141 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13143 * ArrayCreation (LookupType): If the type does not resolve
13144 to an array, give an error.
13146 2004-08-27 Marek Safar <marek.safar@seznam.cz>
13148 * statement.cs (Try.Resolve): Fixed bug #64222
13150 2004-08-27 Martin Baulig <martin@ximian.com>
13153 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
13156 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13158 * ecore.cs (Constantify): Get underlying type via
13159 System.Enum.GetUnderlyingType to avoid StackOverflow on the
13160 Windows in special cases.
13162 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13164 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
13165 for obtaining also private methods.
13166 (GetRemoveMethod): Used GetRemoveMethod (true)
13167 for obtaining also private methods.
13169 2004-08-24 Martin Baulig <martin@ximian.com>
13171 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
13172 MethodAttributes.HideBySig for operators.
13174 2004-08-23 Martin Baulig <martin@ximian.com>
13176 Back to the old error reporting system :-)
13178 * report.cs (Message): Removed.
13179 (Report.MessageData, ErrorData, WarningData): Removed.
13180 (Report.Error, Warning): Back to the old system.
13182 2004-08-23 Martin Baulig <martin@ximian.com>
13184 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
13186 * class.cs (TypeContainer.ParentContainer): New public virtual
13187 method; replaces the explicit interface implementation.
13188 (ClassPart.ParentContainer): Override.
13190 2004-08-23 Martin Baulig <martin@ximian.com>
13192 * statement.cs (Switch): Added support for constant switches; see
13193 #59428 or test-285.cs.
13195 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13198 * statement.cs (GetEnumeratorFilter): Removed useless
13199 logic because C# specs is strict. GetEnumerator must be
13202 2004-08-22 Martin Baulig <martin@ximian.com>
13204 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13205 a switch and may break, reset the barrier. Fixes #59867.
13207 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13209 CLS-Compliance speed up (~5% for corlib)
13211 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
13212 New method. Tests container for CLS-Compliant names
13214 * class.cs (TypeContainer.VerifyClsName): New method.
13215 Checks whether container name is CLS Compliant.
13216 (Constructor): Implements IMethodData.
13218 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
13219 low-case table for CLS Compliance test.
13220 (MemberCache.VerifyClsParameterConflict): New method.
13221 Checks method parameters for CS3006 error.
13223 * enum.cs (EnumMember): Is derived from MemberCore.
13224 (Enum.VerifyClsName): Optimized for better performance.
13226 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13228 * report.cs: Renamed Error_T to Error and changed all
13231 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13233 * class.cs (TypeContainer.IndexerArrayList): New inner class
13234 container for indexers.
13235 (TypeContainer.DefaultIndexerName): New constant for default
13236 indexer name. Replaced all "Item" with this constant.
13237 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
13239 * typemanager.cs (TypeManager.default_member_ctor): Cache here
13240 DefaultMemberAttribute constructor.
13242 2004-08-05 Martin Baulig <martin@ximian.com>
13244 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13247 2004-08-05 Marek Safar <marek.safar@seznam.cz>
13249 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
13250 multi platforms problem.
13252 * compiler.csproj: Included shared files.
13254 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13256 Fix bug 60333, 55971 in the more general way
13257 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13258 Added arg_type argument for constant conversion.
13259 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
13261 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13264 * class.cs (TypeContainer ): New inner classes MethodArrayList,
13265 OperatorArrayList, MethodCoreArrayList for typecontainer
13266 containers. Changed class member types to these new types.
13267 (MethodArrayList.DefineMembers): Added test for CS0659.
13269 2004-08-04 Miguel de Icaza <miguel@ximian.com>
13271 * cfold.cs: Synchronize the folding with the code in expression.cs
13272 Binary.DoNumericPromotions for uint operands.
13274 * attribute.cs: Revert patch from Raja, it introduced a regression
13275 while building Blam-1.2.1 (hard to isolate a test case).
13277 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13281 (TypeContainer.Define): Renamed to DefineContainerMembers because of
13283 (MethodCore.parent_method): New member. The method we're overriding
13284 if this is an override method.
13285 (MethodCore.CheckBase): Moved from Method class and made common.
13286 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
13288 (MethodCore.CheckForDuplications): New abstract method. For custom
13289 member duplication search in a container
13290 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
13291 method and its return type.
13292 (Event.conflict_symbol): New member. Symbol with same name in the
13296 (MemberCache.FindMemberWithSameName): New method. The method
13297 is looking for conflict with inherited symbols.
13299 2004-08-04 Martin Baulig <martin@ximian.com>
13301 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
13303 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
13305 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13307 * report.cs (Message): New enum for better error, warning reference in
13309 (MessageData): New inner abstract class. It generally handles printing of
13310 error and warning messages.
13311 Removed unused Error, Warning, Message methods.
13313 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13315 Fix for cs0592-8.cs test
13317 (Attributable.ValidAttributeTargets): Made public.
13318 (Attribute.ExplicitTarget): New member for explicit target value.
13319 (Attribute.CheckTargets): Now we translate explicit attribute
13320 target to Target here.
13322 2004-08-03 Ben Maurer <bmaurer@ximian.com>
13324 * ecore.cs (MethodGroupExpr): new IsBase property.
13326 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
13328 * delegate.cs (DelegateCreation): store a MethodGroupExpr
13329 rather than an instance expr.
13331 (DelegateCreation.Emit): Use the method group rather than
13332 the instance expression. Also, if you have base.Foo as the
13333 method for a delegate, make sure to emit ldftn, not ldftnvirt.
13335 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
13337 (NewDelegate.DoResolve): Only check for the existance of Invoke
13338 if the method is going to be needed. Use MethodGroupExpr.
13340 (NewDelegate.Emit): Remove, DelegateCreation implements this.
13342 * expression.cs: For pointer arith., make sure to use
13343 the size of the type, not the size of the pointer to
13346 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13349 * class.cs (Class): Added error CS0502 test.
13351 2004-08-03 John Luke <jluke@cfl.rr.com>
13352 Raja R Harinath <rharinath@novell.com>
13355 * attribute.cs (Attribute.complained_before): New flag.
13356 (Attribute.ResolveType, Attribute.Resolve),
13357 (Attribute.DefinePInvokeMethod): Set it.
13358 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
13360 2004-08-03 Martin Baulig <martin@ximian.com>
13362 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
13363 use a user-defined operator; we still need to do numeric
13364 promotions in case one argument is a builtin type and the other
13365 one has an implicit conversion to that type. Fixes #62322.
13367 2004-08-02 Martin Baulig <martin@ximian.com>
13369 * statement.cs (LocalInfo.Flags): Added `IsThis'.
13370 (LocalInfo.IsThis): New public property.
13371 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
13373 2004-08-01 Martin Baulig <martin@ximian.com>
13375 * class.cs (TypeContainer.GetClassBases): Don't set the default
13376 here since we may get called from GetPartialBases().
13377 (TypeContainer.DefineType): If GetClassBases() didn't return a
13378 parent, use the default one.
13380 2004-07-30 Duncan Mak <duncan@ximian.com>
13382 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
13384 2004-07-30 Martin Baulig <martin@ximian.com>
13386 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
13388 * class.cs (SourceMethod): New public class, derive from the
13389 symbol writer's ISourceMethod.
13390 (Method): Use the new symbol writer API.
13392 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
13393 as argument and use the new symbol writer.
13396 (SourceFile): Implement the symbol writer's ISourceFile.
13397 (Location.SymbolDocument): Removed.
13398 (Location.SourceFile): New public property.
13400 * symbolwriter.cs: Use the new symbol writer API.
13402 2004-07-30 Raja R Harinath <rharinath@novell.com>
13404 * Makefile (install-local): Remove. Functionality moved to
13407 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
13409 * Makefile: Install mcs.exe.config file together with mcs.exe.
13410 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
13411 correct runtime version.
13413 2004-07-25 Martin Baulig <martin@ximian.com>
13416 (TypeContainer.RegisterOrder): Removed, this was unused.
13417 (TypeContainer, interface_order): Removed.
13418 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
13419 TypeContainer as argument since we can also be called with a
13420 `PartialContainer' for a partial class/struct/interface.
13421 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
13422 of checking whether we're an `Interface' - we could be a
13423 `PartialContainer'.
13424 (PartialContainer.Register): Override; call
13425 AddClass()/AddStruct()/AddInterface() on our parent.
13427 * cs-parser.jay (interface_member_declaration): Add things to the
13428 `current_container', not the `current_class'.
13430 * rootcontext.cs (RegisterOrder): The overloaded version which
13431 takes an `Interface' was unused, removed.
13433 * typemanager.cs (TypeManager.LookupInterface): Return a
13434 `TypeContainer', not an `Interface'.
13435 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
13436 contain a `PartialContainer' for an interface, so check it's
13437 `Kind' to figure out what it is.
13439 2004-07-25 Martin Baulig <martin@ximian.com>
13441 * class.cs (Class.DefaultTypeAttributes): New public constant.
13442 (Struct.DefaultTypeAttributes): Likewise.
13443 (Interface.DefaultTypeAttributes): Likewise.
13444 (PartialContainer.TypeAttr): Override this and add the
13445 DefaultTypeAttributes.
13447 2004-07-25 Martin Baulig <martin@ximian.com>
13449 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
13450 we can just use the `Parent' field instead.
13452 2004-07-25 Martin Baulig <martin@ximian.com>
13454 * class.cs (TypeContainer.Emit): Renamed to EmitType().
13456 2004-07-25 Martin Baulig <martin@ximian.com>
13458 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
13459 our parts before defining any methods.
13460 (TypeContainer.VerifyImplements): Make this virtual.
13461 (ClassPart.VerifyImplements): Override and call VerifyImplements()
13462 on our PartialContainer.
13464 2004-07-25 Martin Baulig <martin@ximian.com>
13466 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
13468 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
13469 argument, we can just use the `Parent' field instead.
13472 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
13473 (MemberBase.DoDefine): Likewise.
13475 2004-07-24 Martin Baulig <martin@ximian.com>
13477 * decl.cs (MemberCore.Parent): New public field.
13478 (DeclSpace.Parent): Moved to MemberCore.
13480 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
13481 (MemberBase.ctor): Added TypeContainer argument, pass it to our
13483 (FieldBase, Field, Operator): Likewise.
13484 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
13485 (EventField, Event): Likewise.
13487 2004-07-23 Martin Baulig <martin@ximian.com>
13489 * class.cs (PartialContainer): New public class.
13490 (ClassPart): New public class.
13491 (TypeContainer): Added support for partial classes.
13492 (TypeContainer.GetClassBases): Splitted some of the functionality
13493 out into GetNormalBases() and GetPartialBases().
13495 * cs-tokenizer.cs (Token.PARTIAL): New token.
13496 (Tokenizer.consume_identifier): Added some hacks to recognize
13497 `partial', but only if it's immediately followed by `class',
13498 `struct' or `interface'.
13500 * cs-parser.jay: Added support for partial clases.
13502 2004-07-23 Martin Baulig <martin@ximian.com>
13504 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
13505 a `DeclSpace' and also made it readonly.
13506 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
13507 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
13508 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
13510 * cs-parser.jay: Pass the `current_class', not the
13511 `current_container' (at the moment, this is still the same thing)
13512 to a new Method, Property, Event, Indexer or Constructor.
13514 2004-07-23 Martin Baulig <martin@ximian.com>
13516 * cs-parser.jay (CSharpParser): Added a new `current_class' field
13517 and removed the `current_interface' one.
13518 (struct_declaration, class_declaration, interface_declaration):
13519 Set `current_class' to the newly created class/struct/interface;
13520 set their `Bases' and call Register() before parsing their body.
13522 2004-07-23 Martin Baulig <martin@ximian.com>
13524 * class.cs (Kind): New public enum.
13525 (TypeContainer): Made this class abstract.
13526 (TypeContainer.Kind): New public readonly field.
13527 (TypeContainer.CheckDef): New public method; moved here from
13529 (TypeContainer.Register): New public abstract method.
13530 (TypeContainer.GetPendingImplementations): New public abstract
13532 (TypeContainer.GetClassBases): Removed the `is_class' and
13533 `is_iface' parameters.
13534 (TypeContainer.DefineNestedTypes): Formerly known as
13536 (ClassOrStruct): Made this class abstract.
13538 * tree.cs (RootTypes): New public type.
13540 2004-07-20 Martin Baulig <martin@ximian.com>
13542 * tree.cs (Tree.RecordNamespace): Removed.
13543 (Tree.Namespaces): Removed.
13545 * rootcontext.cs (RootContext.IsNamespace): Removed.
13547 * cs-parser.jay (namespace_declaration): Just create a new
13548 NamespaceEntry here.
13550 2004-07-20 Martin Baulig <martin@ximian.com>
13552 * statement.cs (ExceptionStatement): New abstract class. This is
13553 now used as a base class for everyone who's using `finally'.
13554 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
13555 our local variables before using them.
13557 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
13558 virtual method. This is used by Yield.Resolve() to "steal" an
13559 outer block's `finally' clauses.
13560 (FlowBranchingException): The .ctor now takes an ExceptionStatement
13563 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
13564 version which takes an ExceptionStatement. This version must be
13565 used to create exception branchings.
13568 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
13569 (Iterator.EmitMoveNext): Added exception support; protect the
13570 block with a `fault' clause, properly handle 'finally' clauses.
13571 (Iterator.EmitDispose): Run all the `finally' clauses here.
13573 2004-07-20 Martin Baulig <martin@ximian.com>
13575 * iterator.cs: This is the first of a set of changes in the
13576 iterator code. Match the spec more closely: if we're an
13577 IEnumerable, then GetEnumerator() must be called. The first time
13578 GetEnumerator() is called, it returns the current instance; all
13579 subsequent invocations (if any) must create a copy.
13581 2004-07-19 Miguel de Icaza <miguel@ximian.com>
13583 * expression.cs: Resolve the constant expression before returning
13586 2004-07-19 Martin Baulig <martin@ximian.com>
13588 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
13589 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
13590 the return type of the new EmitContext.
13592 2004-07-18 Martin Baulig <martin@ximian.com>
13594 * class.cs (Property.Define): Fix iterators.
13596 * iterators.cs (Iterator.Define): Moved the
13597 `container.AddInterator (this)' call here from the .ctor; only do
13598 it if we resolved successfully.
13600 2004-07-17 Miguel de Icaza <miguel@ximian.com>
13602 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
13603 `true' for preprocessing directives that we parse. The return
13604 value indicates whether we should return to regular tokenizing or
13605 not, not whether it was parsed successfully.
13607 In the past if we were in: #if false ... #line #endif, we would
13608 resume parsing after `#line'. See bug 61604.
13610 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
13611 building: IsEnumType should return true only for enums, not for
13612 enums or System.Enum itself. This fixes #61593.
13614 Likely what happened is that corlib was wrong: mcs depended on
13615 this bug in some places. The bug got fixed, we had to add the
13616 hack, which caused bug 61593.
13618 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
13619 that was a workaround for the older conditions.
13621 2004-07-16 Ben Maurer <bmaurer@ximian.com>
13623 * assign.cs: IAssignMethod has a new interface, as documented
13624 inline. All assignment code now uses this new api.
13626 * ecore.cs, expression.cs: All classes which implement
13627 IAssignMethod now use the new interface.
13629 * expression.cs (Invocation): add a hack to EmitCall so that
13630 IndexerAccess can be the target of a compound assignment without
13631 evaluating its arguments twice.
13633 * statement.cs: Handle changes in Invocation api.
13635 2004-07-16 Martin Baulig <martin@ximian.com>
13637 * iterators.cs: Rewrote this. We're now using one single Proxy
13638 class for both the IEnumerable and the IEnumerator interface and
13639 `Iterator' derives from Class so we can use the high-level API.
13641 * class.cs (TypeContainer.AddIterator): New method.
13642 (TypeContainer.DoDefineType): New protected virtual method, which
13643 is called from DefineType().
13644 (TypeContainer.DoDefineMembers): Call DefineType() and
13645 DefineMembers() on all our iterators.
13646 (TypeContainer.Emit): Call Emit() on all our iterators.
13647 (TypeContainer.CloseType): Call CloseType() on all our iterators.
13649 * codegen.cs (EmitContext.CurrentIterator): New public field.
13651 2004-07-15 Martin Baulig <martin@ximian.com>
13654 (TypeManager.not_supported_exception_type): New type.
13656 2004-07-14 Martin Baulig <martin@ximian.com>
13658 * iterators.cs: Use real error numbers.
13660 2004-07-14 Martin Baulig <martin@ximian.com>
13662 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
13663 requires this to be a System.Collection.IEnumerable and not a
13664 class implementing that interface.
13665 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
13667 2004-07-13 Marek Safar <marek.safar@seznam.cz>
13669 * class.cs: Fixed previous fix, it broke some error tests.
13671 2004-07-12 Martin Baulig <martin@ximian.com>
13673 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
13676 2004-07-09 Miguel de Icaza <miguel@ximian.com>
13678 * assign.cs (LocalTemporary): Add new argument: is_address,If
13679 `is_address' is true, then the value that we store is the address
13680 to the real value, and not the value itself.
13682 * ecore.cs (PropertyExpr): use the new local temporary
13683 stuff to allow us to handle X.Y += z (where X is a struct)
13685 2004-07-08 Martin Baulig <martin@ximian.com>
13687 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
13688 not always return, just like we're doing in Using.Resolve().
13690 2004-07-07 Miguel de Icaza <miguel@ximian.com>
13692 * cs-parser.jay (fixed_statement): flag this as Pinned.
13694 2004-07-06 Miguel de Icaza <miguel@ximian.com>
13696 * typemanager.cs (TypeManager): Removed MakePinned method, this
13697 mechanism is replaced with the .NET 2.x compatible mechanism of
13698 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
13700 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
13701 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
13702 `IsFixed' property which has a different meaning.
13704 2004-07-02 Raja R Harinath <rharinath@novell.com>
13706 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
13707 visible from inside a nested class, not just the names of the
13708 immediately enclosing class.
13709 Fix for bug #60730.
13711 2004-06-24 Raja R Harinath <rharinath@novell.com>
13713 * expression.cs (BetterConversion): Remove buggy special-case
13714 handling of "implicit constant expression conversions". At this
13715 point, we already know that the conversion is possible -- we're
13716 only checking to see which is better.
13718 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13720 * cs-parser.jay: Added error CS0210 test.
13722 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13724 * cs-parser.jay: Added error CS0134 test.
13726 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13729 * cs-parser.jay: Added error CS0145 test.
13731 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13733 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
13735 2004-06-23 Ben Maurer <bmaurer@ximian.com>
13737 * expression.cs (StackAlloc.Resolve): The argument may not
13738 be a constant; deal with this case.
13740 2004-06-23 Marek Safar <marek.safar@seznam.cz>
13742 * attribute.cs (IndexerName_GetIndexerName): Renamed to
13743 GetIndexerAttributeValue.
13744 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
13746 * class.cs (Indexer.Define): Added error tests for CS0415,
13749 2004-06-23 Miguel de Icaza <miguel@ximian.com>
13751 * attribute.cs (Attribute.Resolve): Keep field code in sync with
13754 2004-06-23 Martin Baulig <martin@ximian.com>
13756 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
13757 neither return nor throw, reset the barrier as well. Fixes #60457.
13759 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
13761 * class.cs : EventAttributes is now set to None by default.
13762 This fixes bug #60459.
13764 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13767 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13768 Don't throw exception but return null (it's sufficient now).
13770 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13772 * typemanager.cs (GetArgumentTypes): Faster implementation.
13774 2004-06-18 Martin Baulig <martin@ximian.com>
13776 * attribute.cs (Attribute.Resolve): Check whether we're an
13777 EmptyCast which a Constant child. Fixes #60333.
13779 2004-06-17 Ben Maurer <bmaurer@ximian.com>
13781 * statement.cs (EmitCollectionForeach): Account for the fact that
13782 not all valuetypes are in areas which we can take the address of.
13783 For these variables, we store to a temporary variable. Also, make
13784 sure that we dont emit a `callvirt' on a valuetype method.
13786 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13788 * expression.cs (StackAlloc.DoReSolve): Added test for
13789 negative parameter (CS0247).
13791 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13794 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
13796 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13799 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
13802 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13804 Fix bug #58254 & cs1555.cs, cs1556.cs
13805 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
13807 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13809 * cs-parser.jay: Added error CS1669 test for indexers.
13811 2004-06-11 Martin Baulig <martin@ximian.com>
13813 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
13814 call this twice: for params and varargs methods.
13816 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13819 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
13821 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13823 * attribute.cs (Attribute.GetValidTargets): Made public.
13826 (AbstractPropertyEventMethod): New class for better code sharing.
13827 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
13829 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
13831 2004-06-11 Raja R Harinath <rharinath@novell.com>
13834 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
13835 that the call to Resolve is part of a MemberAccess.
13836 (Expression.Resolve): Use it for SimpleName resolution.
13837 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
13838 Add 'intermediate' boolean argument.
13839 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
13840 error message when the SimpleName can be resolved ambiguously
13841 between an expression and a type.
13842 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
13844 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
13845 call on the left-side.
13847 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13850 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
13852 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13854 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13856 2004-06-11 Martin Baulig <martin@ximian.com>
13858 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13859 varargs methods if applicable.
13861 2004-06-11 Martin Baulig <martin@ximian.com>
13863 * expression.cs (Invocation.EmitCall): Don't use
13864 `method.CallingConvention == CallingConventions.VarArgs' since the
13865 method could also have `CallingConventions.HasThis'.
13867 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13869 * class.cs (Event.GetSignatureForError): Implemented.
13870 Fixed crash in error test cs3010.cs
13872 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13874 * cs-tokenizer.cs: Change the way we track __arglist to be
13875 consistent with the other keywords.
13877 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13879 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13882 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13884 * codegen.cs: Check that all referenced assemblies have a strongname
13885 before strongnaming the compiled assembly. If not report error CS1577.
13886 Fix bug #56563. Patch by Jackson Harper.
13887 * typemanager.cs: Added a method to return all referenced assemblies.
13888 Fix bug #56563. Patch by Jackson Harper.
13890 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13893 (Method.ApplyAttributeBuilder): Moved and added conditional
13894 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13897 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13899 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13902 * class.cs: (EventField.attribute_targets): Changed default target.
13904 2004-06-08 Martin Baulig <martin@ximian.com>
13906 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13908 2004-06-08 Martin Baulig <martin@ximian.com>
13910 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13912 2004-06-07 Martin Baulig <martin@ximian.com>
13914 Added support for varargs methods.
13916 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13919 * cs-parser.jay: Added support for `__arglist'.
13921 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13923 * expression.cs (Argument.AType): Added `ArgList'.
13924 (Invocation): Added support for varargs methods.
13925 (ArglistAccess): New public class.
13926 (Arglist): New public class.
13928 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13930 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13931 a method's top-level block if the method has varargs.
13933 * support.cs (ReflectionParameters, InternalParameters): Added
13934 support for varargs methods.
13936 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13938 * class.cs: Provide location in indexer error report.
13940 * driver.cs: Use standard names.
13942 * namespace.cs: Catch the use of using after a namespace has been
13943 declared also on using aliases.
13945 2004-06-03 Raja R Harinath <rharinath@novell.com>
13948 * typemanager.cs (closure_private_ok, closure_invocation_type)
13949 (closure_qualifier_type, closure_invocation_assembly)
13950 (FilterWithClosure): Move to ...
13951 (Closure): New internal nested class.
13952 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13953 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13954 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13955 (MemberLookup, MemberLookupFailed): Use it.
13956 * expression.cs (New.DoResolve): Treat the lookup for the
13957 constructor as being qualified by the 'new'ed type.
13958 (Indexers.GetIndexersForTypeOrInterface): Update.
13960 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13963 (GetConditionalAttributeValue): New method. Returns
13964 condition of ConditionalAttribute.
13965 (SearchMulti): New method. Returns all attributes of type 't'.
13966 Use it when attribute is AllowMultiple = true.
13967 (IsConditionalMethodExcluded): New method.
13970 (Method.IsExcluded): Implemented. Returns true if method has conditional
13971 attribute and the conditions is not defined (method is excluded).
13972 (IMethodData): Extended interface for ConditionalAttribute support.
13973 (PropertyMethod.IsExcluded): Implemented.
13976 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
13979 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
13982 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
13984 * expression.cs (ArrayCreationExpression): Make this just an
13985 `expression'. It can't be a statement, so the code here was
13988 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13991 * typemanager.cs (GetFullNameSignature): New method for
13994 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13997 * class.cs (MemberBase.GetSignatureForError): New virtual method.
13998 Use this method when MethodBuilder is null.
13999 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
14000 Added test for error CS0626 (MONO reports error for this situation).
14001 (IMethodData.GetSignatureForError): Extended interface.
14003 2004-06-01 Marek Safar <marek.safar@seznam.cz>
14006 (AttributeTester.GetObsoleteAttribute): Returns instance of
14007 ObsoleteAttribute when type is obsolete.
14010 (TypeContainer.VerifyObsoleteAttribute): Override.
14011 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
14012 (MethodCode.VerifyObsoleteAttribute): Override.
14013 (MemberBase.VerifyObsoleteAttribute): Override.
14016 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
14017 and report proper error.
14020 Delegate.VerifyObsoleteAttribute): Override.
14023 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
14024 and report proper error.
14025 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
14028 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
14032 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
14033 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
14034 Added test for ObsoleteAttribute.
14037 (Catch): Derived from Statement.
14039 2004-06-01 Marek Safar <marek.safar@seznam.cz>
14041 Fixed bug #59071 & cs0160.cs
14043 * statement.cs (Try.Resolve): Check here whether order of catch
14044 clauses matches their dependencies.
14046 2004-05-31 Miguel de Icaza <miguel@ximian.com>
14048 * Reverted patch to namespace.cs (Use lookuptypedirect). This
14049 caused a regression: #59343. Referencing nested classes from an
14050 assembly stopped working.
14052 2004-05-31 Martin Baulig <martin@ximian.com>
14054 MCS is now frozen for beta 2.
14056 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14058 * convert.cs: add a trivial cache for overload operator resolution.
14060 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14062 * decl.cs: If possible, use lookuptypedirect here. We can only do
14063 this if there is no `.' after the namespace. Avoids using
14064 LookupType, which does lots of slow processing.
14065 (FindNestedType) New method, does what it says :-).
14066 * namespace.cs: use LookupTypeDirect.
14067 * rootcontext.cs: use membercache, if possible.
14068 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
14070 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14073 According to the spec,
14075 In a member access of the form E.I, if E is a single identifier,
14076 and if the meaning of E as a simple-name (§7.5.2) is a constant,
14077 field, property, localvariable, or parameter with the same type as
14078 the meaning of E as a type-name (§3.8), then both possible
14079 meanings of E are permitted.
14081 We did not check that E as a simple-name had the same type as E as
14084 This trivial check gives us 5-7% on bootstrap time.
14086 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14088 * expression.cs (Invocation.OverloadResolve): Avoid the
14089 use of hashtables and boxing here by allocating on demand.
14091 2004-05-30 Martin Baulig <martin@ximian.com>
14093 * rootcontext.cs (RootContext.LookupType): Don't cache things if
14094 we're doing a silent lookup. Don't try to lookup nested types in
14095 TypeManager.object_type (thanks to Ben Maurer).
14097 2004-05-30 Martin Baulig <martin@ximian.com>
14099 Committing a patch from Ben Maurer.
14101 * rootcontext.cs (RootContext.LookupType): Cache negative results.
14103 2004-05-29 Martin Baulig <martin@ximian.com>
14105 * class.cs (IMethodData.ShouldIgnore): New method.
14107 * typemanager.cs (TypeManager.MethodFlags): Don't take a
14108 `Location' argument, we don't need it anywhere. Use
14109 `IMethodData.ShouldIgnore ()' instead of
14110 `MethodData.GetMethodFlags ()'.
14111 (TypeManager.AddMethod): Removed.
14112 (TypeManager.AddMethod2): Renamed to AddMethod.
14114 2004-05-29 Martin Baulig <martin@ximian.com>
14116 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
14118 * convert.cs (Convert.ImplicitReferenceConversion): If we're
14119 converting from a class type S to an interface type and we already
14120 have an object on the stack, don't box it again. Fixes #52578.
14122 2004-05-29 Martin Baulig <martin@ximian.com>
14124 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
14125 Added support for `params' parameters. Fixes #59267.
14127 2004-05-29 Martin Baulig <martin@ximian.com>
14129 * literal.cs (NullPointer): Provide a private .ctor which sets
14130 `type' to TypeManager.object_type. Fixes #59048.
14132 2004-05-29 Martin Baulig <martin@ximian.com>
14134 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
14135 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
14137 * ecore.cs (EventExpr.instance_expr): Make the field private.
14139 2004-05-26 Marek Safar <marek.safar@seznam.cz>
14141 Fixed bug #50080 & cs0214-2.cs
14142 * expression.cs (Cast.DoResolve): Check unsafe context here.
14144 * statement.cs (Resolve.DoResolve): Likewise.
14146 2004-05-26 Martin Baulig <martin@ximian.com>
14148 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
14150 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
14151 (RootContext.LookupType): Pass down the `silent' flag.
14153 2004-05-25 Martin Baulig <martin@ximian.com>
14156 (MethodGroupExpr.IdenticalTypeName): New public property.
14157 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
14158 expression actually refers to a type.
14160 2004-05-25 Martin Baulig <martin@ximian.com>
14162 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
14163 for #56176 and made it actually work.
14165 2004-05-25 Martin Baulig <martin@ximian.com>
14167 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
14168 (FieldExpr, PropertyExpr): Override and implement
14169 CacheTemporaries. Fixes #52279.
14171 2004-05-25 Miguel de Icaza <miguel@ximian.com>
14173 * location.cs: In the new compiler listing a file twice is a
14174 warning, not an error.
14176 2004-05-24 Martin Baulig <martin@ximian.com>
14178 * enum.cs (Enum.DefineType): For the `BaseType' to be a
14179 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
14181 2004-05-24 Martin Baulig <martin@ximian.com>
14183 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
14184 walking the `using' list. Fixes #53921.
14186 2004-05-24 Martin Baulig <martin@ximian.com>
14188 * const.cs (Const.LookupConstantValue): Added support for
14189 EmptyCast's; fixes #55251.
14191 2004-05-24 Martin Baulig <martin@ximian.com>
14193 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
14194 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
14195 which does the CS0135 check. The reason is that we first need to
14196 check whether the variable actually exists.
14198 2004-05-24 Martin Baulig <martin@ximian.com>
14200 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
14201 than RootContext.LookupType() to find the explicit interface
14202 type. Fixes #58584.
14204 2004-05-24 Raja R Harinath <rharinath@novell.com>
14206 * Makefile: Simplify. Use executable.make.
14207 * mcs.exe.sources: New file. List of sources of mcs.exe.
14209 2004-05-24 Anders Carlsson <andersca@gnome.org>
14213 Use the invariant culture when doing String.Compare for CLS case
14216 2004-05-23 Martin Baulig <martin@ximian.com>
14218 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
14219 don't have any dots. Fixes #52622, added cs0246-8.cs.
14221 * namespace.cs (NamespaceEntry.Lookup): Likewise.
14223 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14225 * class.cs (MemberBase.Define): Reuse MemberType member for
14226 resolved type. Other methods can use it too.
14228 2004-05-23 Martin Baulig <martin@ximian.com>
14230 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
14231 the variable also exists in the current block (otherwise, we need
14232 to report a CS0103). Fixes #58670.
14234 2004-05-23 Martin Baulig <martin@ximian.com>
14236 * flowanalysis.cs (Reachability.Reachable): Compute this
14237 on-the-fly rather than storing it as a field.
14239 2004-05-23 Martin Baulig <martin@ximian.com>
14241 * flowanalysis.cs (Reachability.And): Manually compute the
14242 resulting `barrier' from the reachability.
14244 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14247 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
14248 instance of ObsoleteAttribute when symbol is obsolete.
14251 (IMethodData): Extended interface for ObsoleteAttribute support.
14253 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14255 * attribute.cs: Fix bug #55970
14257 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14261 (GetObsoleteAttribute): New method. Creates the instance of
14263 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
14264 ObsoleteAttribute when member is obsolete.
14265 (AttributeTester.Report_ObsoleteMessage): Common method for
14266 Obsolete error/warning reporting.
14269 (TypeContainer.base_classs_type): New member for storing parent type.
14272 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
14273 for this MemberCore.
14275 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14277 * attribute.cs, const.cs: Fix bug #58590
14279 2004-05-21 Martin Baulig <martin@ximian.com>
14281 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
14282 out parameters if the end of the method is unreachable. Fixes
14285 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14287 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
14288 Hari was right, why extra method.
14290 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14292 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
14294 2004-05-20 Martin Baulig <martin@ximian.com>
14296 Merged this back from gmcs to keep the differences to a minumum.
14298 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
14299 instead of a Declspace.
14300 (Attribute.ResolveType): Likewise.
14301 (Attributes.Search): Likewise.
14302 (Attributes.Contains): Likewise.
14303 (Attributes.GetClsCompliantAttribute): Likewise.
14305 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
14307 (MethodData.ApplyAttributes): Take an EmitContext instead of a
14310 2004-05-19 Marek Safar <marek.safar@seznam.cz>
14312 Fix bug #58688 (MCS does not report error when the same attribute
14315 * attribute.cs (Attribute.Emit): Distinction between null and default.
14317 2004-05-19 Raja R Harinath <rharinath@novell.com>
14319 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
14320 of a top-level attribute without an attribute target.
14321 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
14323 (Attribute.Conditional_GetConditionName),
14324 (Attribute.Obsolete_GetObsoleteMessage): Update.
14325 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
14326 part of ScanForIndexerName.
14327 (Attribute.CanIgnoreInvalidAttribute): New function.
14328 (Attribute.ScanForIndexerName): Move to ...
14329 (Attributes.ScanForIndexerName): ... here.
14330 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
14331 (Attributes.Search): New internal variant that can choose not to
14332 complain if types aren't resolved. The original signature now
14334 (Attributes.GetClsCompliantAttribute): Use internal variant, with
14335 complaints suppressed.
14336 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
14337 only if it not useful.
14338 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
14339 top-level for attributes that are shared between the assembly
14340 and a top-level class.
14341 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
14342 * class.cs: Update to reflect changes.
14343 (DefineIndexers): Fuse loops.
14344 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
14345 a couple more variants of attribute names.
14347 2004-05-18 Marek Safar <marek.safar@seznam.cz>
14349 Fix bug #52585 (Implemented explicit attribute declaration)
14352 (Attributable.ValidAttributeTargets): New abstract method. It gets
14353 list of valid attribute targets for explicit target declaration.
14354 (Attribute.Target): It holds target itself.
14355 (AttributeSection): Removed.
14356 (Attribute.CheckTargets): New method. It checks whether attribute
14357 target is valid for the current element.
14360 (EventProperty): New class. For events that are declared like
14361 property (with add and remove accessors).
14362 (EventField): New class. For events that are declared like field.
14365 * cs-parser.jay: Implemented explicit attribute target declaration.
14367 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
14368 Override ValidAttributeTargets.
14371 (ReturnParameter): Class for applying custom attributes on
14373 (ParameterAtribute): New class. Class for applying custom
14374 attributes on the parameter type.
14376 2004-05-17 Miguel de Icaza <miguel@ximian.com>
14378 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
14381 (Method): Allow UNSAFE here.
14383 * modifiers.cs: Support unsafe reporting.
14385 2004-05-17 Marek Safar <marek.safar@seznam.cz>
14387 * decl.cs: Fix bug #58478.
14389 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14391 * statement.cs: When checking for unreachable code on an EmptyStatement,
14392 set the location. Fixes bug #58488.
14394 2004-05-13 Miguel de Icaza <miguel@ximian.com>
14396 * driver.cs: Add -pkg handling.
14398 From Gonzalo: UseShelLExecute=false
14400 2004-05-12 Marek Safar <marek.safar@seznam.cz>
14403 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
14405 (Attribute.IsClsCompliaceRequired): Moved to base for better
14407 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
14408 when attribute is AttributeUsageAttribute.
14409 (Attribute.GetValidTargets): Simplified.
14410 (Attribute.GetAttributeUsage): New method returns AttributeUsage
14411 attribute for this type.
14412 (Attribute.ApplyAttributes): Method renamed to Emit and make
14414 (GlobalAttributeSection): New class for special handling of global
14415 attributes (assembly, module).
14416 (AttributeSection.Emit): New method.
14418 * class.cs: Implemented Attributable abstract methods.
14419 (MethodCore.LabelParameters): Moved to Parameter class.
14420 (Accessor): Is back simple class.
14421 (PropertyMethod): Implemented Attributable abstract class.
14422 (DelegateMethod): Implemented Attributable abstract class.
14423 (Event): New constructor for disctintion between normal Event
14424 and Event with accessors.
14426 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
14428 * codegen.cs, const.cs, decl.cs, delegate.cs:
14429 (CommonAssemblyModulClass): Implemented Attributable abstract class
14432 * enum.cs: Implement IAttributeSupport interface.
14433 (EnumMember): New class for emum members. Implemented Attributable
14437 (ParameterBase): Is abstract.
14438 (ReturnParameter): New class for easier [return:] attribute handling.
14440 * typemanager.cs: Removed builder_to_attr.
14442 2004-05-11 Raja R Harinath <rharinath@novell.com>
14445 * attribute.cs (Attribute.GetPositionalValue): New function.
14446 * class.cs (TypeContainer.VerifyMembers): New function.
14447 (TypeContainer.Emit): Use it.
14448 (ClassOrStruct): New base class for Class and Struct.
14449 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
14450 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
14452 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
14453 then each non-static field should have a FieldOffset attribute.
14454 Otherwise, none of the fields should have a FieldOffset attribute.
14455 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
14456 and FieldOffset attributes.
14457 * typemanager.cs (TypeManager.struct_layout_attribute_type)
14458 (TypeManager.field_offset_attribute_type): New core types.
14459 (TypeManager.InitCoreTypes): Initialize them.
14461 2004-05-11 Michal Moskal <malekith@pld-linux.org>
14463 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
14464 Return correct type.
14467 2004-05-09 Miguel de Icaza <miguel@ximian.com>
14469 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
14470 be implicitly converted to ulong.
14472 * expression.cs: The logic for allowing operator &, | and ^ worked
14473 was wrong, it worked before because we did not report an error in
14474 an else branch. Fixes 57895.
14476 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
14477 allow volatile fields to be reference types.
14479 2004-05-07 Miguel de Icaza <miguel@ximian.com>
14481 * driver.cs: Add support for /debug-
14483 2004-05-07 Raja R Harinath <rharinath@novell.com>
14485 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
14486 Add a 'complain' parameter to silence errors.
14487 (Attribute.Resolve): Update to changes. Put in sanity check to catch
14488 silently overlooked type-resolutions.
14489 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
14490 to reflect changes.
14491 (Attributes.Search): New function.
14492 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
14493 (Attributes.GetAttributeFullName): Remove hack.
14494 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
14495 Update to reflect changes.
14496 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14497 Use Attributes.Search instead of nested loops.
14499 2004-05-07 Marek Safar <marek.safar@seznam.cz>
14502 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
14503 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
14504 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
14506 * report.cs: (Report.Warning): Renamed to Warning_T because of
14507 parameter collision.
14509 2004-05-05 Raja R Harinath <rharinath@novell.com>
14511 * expression.cs (MemberAccess.ResolveMemberAccess):
14512 Exit with non-zero status after Report.Error.
14513 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
14515 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
14517 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14519 * support.cs: Don't hang when the file is empty.
14521 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14523 * support.cs: In SeekableStreamReader, compute the preamble size of the
14524 underlying stream. Position changes should take into account that initial
14527 2004-05-03 Todd Berman <tberman@sevenl.net>
14529 * driver.cs: remove unused GetSysVersion function.
14531 2004-05-03 Todd Berman <tberman@sevenl.net>
14533 * driver.cs: Remove the hack from saturday, as well as the hack
14534 from jackson (LoadAssemblyFromGac), also adds the CWD to the
14535 link_paths to get that bit proper.
14537 2004-05-01 Todd Berman <tberman@sevenl.net>
14539 * driver.cs: Try a LoadFrom before a Load, this checks the current
14540 path. This is currently a bug in mono that is be fixed, however, this
14541 provides a workaround for now. This will be removed when the bug
14544 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
14546 * CryptoConvert.cs: Updated to latest version. Fix issue with
14547 incomplete key pairs (#57941).
14549 2004-05-01 Todd Berman <tberman@sevenl.net>
14551 * driver.cs: Remove '.' from path_chars, now System.* loads properly
14554 2004-04-30 Jackson Harper <jackson@ximian.com>
14556 * codegen.cs: Open keys readonly.
14558 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14560 * typemanager.cs: don't report cyclic struct layout when a struct
14561 contains 2 or more fields of the same type. Failed for Pango.AttrShape
14562 which has 2 Pango.Rectangle fields.
14564 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
14566 * expression.cs: Handle IntPtr comparisons with IL code
14567 rather than a method call.
14569 2004-04-29 Martin Baulig <martin@ximian.com>
14571 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
14572 the list of PropertyInfo's in class hierarchy and find the
14573 accessor. Fixes #56013.
14575 2004-04-29 Martin Baulig <martin@ximian.com>
14577 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
14579 2004-04-29 Martin Baulig <martin@ximian.com>
14581 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14583 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
14585 2004-04-29 Martin Baulig <martin@ximian.com>
14587 * class.cs (ConstructorInitializer.Resolve): Check whether the
14588 parent .ctor is accessible. Fixes #52146.
14590 2004-04-29 Martin Baulig <martin@ximian.com>
14592 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14594 * statement.cs (Using.EmitLocalVariableDecls): Use
14595 TypeManager.idisposable_type, not typeof (IDisposable).
14596 (Foreach.EmitCollectionForeach): Added support for valuetypes.
14598 2004-04-29 Martin Baulig <martin@ximian.com>
14600 * class.cs (Event.Define): Don't emit the field and don't set
14601 RTSpecialName and SpecialName for events on interfaces. Fixes
14604 2004-04-29 Raja R Harinath <rharinath@novell.com>
14606 Refactor Attribute.ApplyAttributes.
14607 * attribute.cs (Attributable): New base class for objects that can
14608 have Attributes applied on them.
14609 (Attribute): Make AttributeUsage fields public.
14610 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
14611 (Attribute.IsInternalCall): New property.
14612 (Attribute.UsageAttr): Convert to a public read-only property.
14613 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
14614 (Attribute.ResolveType, Attribute.Resolve)
14615 (Attribute.ScanForIndexerName): Update to reflect changes.
14616 (Attribute.CheckAttributeTarget): Re-format.
14617 (Attribute.ApplyAttributes): Refactor, to various
14618 Attributable.ApplyAttributeBuilder methods.
14619 * decl.cs (MemberCore): Make Attributable.
14620 * class.cs (Accessor): Make Attributable.
14621 (MethodData.ApplyAttributes): Use proper attribute types, not
14623 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
14624 (TypeContainer.ApplyAttributeBuilder)
14625 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
14626 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
14627 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
14628 (Operator.ApplyAttributeBuilder): New factored-out methods.
14629 * const.cs (Const.ApplyAttributeBuilder): Likewise.
14630 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
14631 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
14632 * parameter.cs (ParameterBase): New Attributable base class
14633 that can also represent Return types.
14634 (Parameter): Update to the changes.
14636 2004-04-29 Jackson Harper <jackson@ximian.com>
14638 * driver.cs: Prefer the corlib system version when looking for
14639 assemblies in the GAC. This is still a hack, but its a better hack
14642 2004-04-29 Marek Safar <marek.safar@seznam.cz>
14644 * decl.cs, enum.cs: Improved error 3005 reporting.
14646 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
14647 (related_symbols): New private member for list of symbols
14648 related to reported error/warning.
14650 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
14652 2004-04-29 Martin Baulig <martin@ximian.com>
14654 * ecore.cs (Expression.Constantify): If we're an enum and
14655 TypeManager.TypeToCoreType() doesn't give us another type, use
14656 t.UnderlyingSystemType. Fixes #56178.
14658 2004-04-29 Martin Baulig <martin@ximian.com>
14660 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
14661 interfaces and for each interface, only add members directly
14662 declared in that interface. Fixes #53255.
14664 2004-04-28 Martin Baulig <martin@ximian.com>
14666 * expression.cs (ConditionalLogicalOperator): Use a temporary
14667 variable for `left' to avoid that we evaluate it more than once;
14670 2004-04-28 Martin Baulig <martin@ximian.com>
14672 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
14675 2004-04-28 Martin Baulig <martin@ximian.com>
14677 * statement.cs (LocalInfo.Resolve): Check whether the type is not
14680 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
14681 whether the type is not void (CS1547).
14683 2004-04-28 Martin Baulig <martin@ximian.com>
14685 * expression.cs (Unary.DoResolveLValue): Override this and report
14686 CS0131 for anything but Operator.Indirection.
14688 2004-04-28 Martin Baulig <martin@ximian.com>
14690 Committing a patch from Ben Maurer; see bug #50820.
14692 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14695 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14698 2004-04-28 Martin Baulig <martin@ximian.com>
14700 Committing a patch from Ben Maurer; see bug #50820.
14702 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14705 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14708 2004-04-28 Martin Baulig <martin@ximian.com>
14710 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
14711 (Block.AddLabel): Call DoLookupLabel() to only search in the
14714 2004-04-28 Martin Baulig <martin@ximian.com>
14716 * cfold.cs (ConstantFold.BinaryFold): Added special support for
14717 comparing StringConstants and NullLiterals in Equality and Inequality.
14719 2004-04-28 Jackson Harper <jackson@ximian.com>
14721 * driver.cs: Attempt to load referenced assemblies from the
14722 GAC. This is the quick and dirty version of this method that
14723 doesnt take into account versions and just takes the first
14724 canidate found. Will be good enough for now as we will not have more
14725 then one version installed into the GAC until I update this method.
14727 2004-04-28 Martin Baulig <martin@ximian.com>
14729 * typemanager.cs (TypeManager.CheckStructCycles): New public
14730 static method to check for cycles in the struct layout.
14732 * rootcontext.cs (RootContext.PopulateTypes): Call
14733 TypeManager.CheckStructCycles() for each TypeContainer.
14734 [Note: We only need to visit each type once.]
14736 2004-04-28 Martin Baulig <martin@ximian.com>
14738 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
14740 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
14741 success and added `out object value'. Use a `bool resolved' field
14742 to check whether we've already been called rather than
14743 `ConstantValue != null' since this breaks for NullLiterals.
14745 2004-04-28 Raja R Harinath <rharinath@novell.com>
14747 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
14748 setting of this flag, since the 'set' method may be non-public.
14750 2004-04-28 Raja R Harinath <rharinath@novell.com>
14752 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
14753 check on current_vector.Block.
14755 2004-04-27 Martin Baulig <martin@ximian.com>
14757 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
14758 a field initializer. Fixes #56459.
14760 2004-04-27 Martin Baulig <martin@ximian.com>
14762 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
14763 we're not attempting to use an indexer. Fixes #52154.
14765 2004-04-27 Martin Baulig <martin@ximian.com>
14767 * statement.cs (Return): Don't create a return label if we don't
14768 need it; reverts my change from January 20th. Thanks to Ben
14771 2004-04-27 Martin Baulig <martin@ximian.com>
14773 According to the spec, `goto' can only leave a nested scope, but
14776 * statement.cs (Block.LookupLabel): Only lookup in the current
14777 block, don't recurse into parent or child blocks.
14778 (Block.AddLabel): Check in parent and child blocks, report
14779 CS0140/CS0158 if we find a duplicate.
14780 (Block): Removed this indexer for label lookups.
14781 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
14782 this already does the error reporting for us.
14785 (FlowBranching.UsageVector.Block): New public variable; may be null.
14786 (FlowBranching.CreateSibling): Added `Block' argument.
14787 (FlowBranching.LookupLabel): New public virtual method. Lookup a
14788 label for the target of a `goto' and check whether we're not
14789 leaving a `finally'.
14791 2004-04-27 Martin Baulig <martin@ximian.com>
14793 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14794 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
14797 2004-04-27 Martin Baulig <martin@ximian.com>
14799 * statement.cs (Block.AddLabel): Also check for implicit blocks
14800 and added a CS0158 check.
14802 2004-04-27 Martin Baulig <martin@ximian.com>
14804 * flowanalysis.cs (FlowBranchingLoop): New class.
14805 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
14806 UsageVector's instead of an ArrayList.
14807 (FlowBranching.Label): Likewise.
14808 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
14809 (FlowBranching.AddBreakVector): New method.
14811 2004-04-27 Miguel de Icaza <miguel@ximian.com>
14813 * attribute.cs: Small regression fix: only convert the type if we
14814 the type is different, fixes System.Drawing build.
14816 2004-04-27 Martin Baulig <martin@ximian.com>
14818 * attribute.cs (Attribute.Resolve): If we have a constant value
14819 for a named field or property, implicity convert it to the correct
14822 2004-04-27 Raja R Harinath <rharinath@novell.com>
14824 * statement.cs (Block.Block): Implicit blocks share
14825 'child_variable_names' fields with parent blocks.
14826 (Block.AddChildVariableNames): Remove.
14827 (Block.AddVariable): Mark variable as "used by a child block" in
14828 every surrounding block.
14829 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
14830 been used in a child block, complain about violation of "Invariant
14831 meaning in blocks" rule.
14832 * cs-parser.jay (declare_local_variables): Don't use
14833 AddChildVariableNames.
14834 (foreach_statement): Don't create an implicit block: 'foreach'
14835 introduces a scope.
14837 2004-04-23 Miguel de Icaza <miguel@ximian.com>
14839 * convert.cs (ImplicitNumericConversion): 0 is also positive when
14840 converting from 0L to ulong. Fixes 57522.
14842 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14844 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
14845 derived class hides via 'new' keyword field from base class (test-242.cs).
14846 TODO: Handle this in the more general way.
14848 * class.cs (CheckBase): Ditto.
14850 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14852 * decl.cs (caching_flags): New member for storing cached values
14854 (MemberCore.Flags): New enum where bit flags for caching_flags
14856 (MemberCore.cls_compliance): Moved to caching_flags.
14857 (DeclSpace.Created): Moved to caching_flags.
14859 * class.cs: Use caching_flags instead of DeclSpace.Created
14861 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14863 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14864 if we are only a derived class, not a nested class.
14866 * typemanager.cs: Same as above, but do this at the MemberLookup
14867 level (used by field and methods, properties are handled in
14868 PropertyExpr). Allow for the qualified access if we are a nested
14871 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14873 * class.cs: Refactoring.
14874 (IMethodData): New inteface; Holds links to parent members
14875 to avoid member duplication (reduced memory allocation).
14876 (Method): Implemented IMethodData interface.
14877 (PropertyBase): New inner classes for get/set methods.
14878 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14879 (Event): New inner classes for add/remove methods.
14880 (Event.DelegateMethod): Implemented IMethodData interface.
14882 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14883 EmitContext (related to class.cs refactoring).
14885 2004-04-21 Raja R Harinath <rharinath@novell.com>
14887 * delegate.cs (Delegate.VerifyApplicability): If the number of
14888 arguments are the same as the number of parameters, first try to
14889 verify applicability ignoring any 'params' modifier on the last
14893 2004-04-16 Raja R Harinath <rharinath@novell.com>
14895 * class.cs (TypeContainer.AddIndexer): Use
14896 'ExplicitInterfaceName' to determine if interface name was
14897 explicitly specified. 'InterfaceType' is not initialized at this time.
14898 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14899 Indexers array is already in the required order. Initialize
14900 'IndexerName' only if there are normal indexers.
14901 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14902 (TypeContainer.Emit): Emit DefaultMember attribute only if
14903 IndexerName is initialized.
14906 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14908 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14911 2004-04-15 Raja R Harinath <rharinath@novell.com>
14913 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14917 * attribute.cs (Attribute.Resolve): Check for duplicate named
14921 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14923 * iterators.cs (MarkYield): track whether we are in an exception,
14924 and generate code accordingly. Use a temporary value to store the
14925 result for our state.
14927 I had ignored a bit the interaction of try/catch with iterators
14928 since their behavior was not entirely obvious, but now it is
14929 possible to verify that our behavior is the same as MS .NET 2.0
14933 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14935 * iterators.cs: Avoid creating temporaries if there is no work to
14938 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14939 Enumerations, use TypeManager.EnumToUnderlying and call
14942 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14945 (This.Emit): Use EmitContext.EmitThis to emit our
14948 (This.EmitAssign): Ditto.
14950 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14951 codepaths, we will move all the functionality into
14954 (FieldExpr.EmitAssign): Ditto.
14956 This fixes several hidden bugs that I uncovered while doing a code
14957 review of this today.
14959 * codegen.cs (EmitThis): reworked so the semantics are more clear
14960 and also support value types "this" instances.
14962 * iterators.cs: Changed so that for iterators in value types, we
14963 do not pass the value type as a parameter.
14965 Initialization of the enumerator helpers is now done in the caller
14966 instead of passing the parameters to the constructors and having
14967 the constructor set the fields.
14969 The fields have now `assembly' visibility instead of private.
14971 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14973 * expression.cs (Argument.Resolve): Check if fields passed as ref
14974 or out are contained in a MarshalByRefObject.
14976 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
14977 another compiler type.
14979 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
14981 * class.cs (Indexer.Define): use the new name checking method.
14982 Also, return false on an error.
14983 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
14984 (is_identifier_[start/part]_character): make static.
14986 2004-04-10 Miguel de Icaza <miguel@ximian.com>
14988 * expression.cs (Binary.ResolveOperator): Do no append strings
14989 twice: since we can be invoked more than once (array evaluation)
14990 on the same concatenation, take care of this here. Based on a fix
14991 from Ben (bug #56454)
14993 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
14995 * codegen.cs: Fix another case where CS1548 must be reported (when
14996 delay-sign isn't specified and no private is available #56564). Fix
14997 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
14998 error when MCS is used on the MS runtime and we need to delay-sign
14999 (which seems unsupported by AssemblyBuilder - see #56621).
15001 2004-04-08 Marek Safar <marek.safar@seznam.cz>
15003 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
15004 (TypeManager.ComputeNamespaces): Faster implementation for
15007 * compiler.csproj: Updated AssemblyName to mcs.
15009 2004-04-07 Miguel de Icaza <miguel@ximian.com>
15011 * rootcontext.cs: Add new types to the boot resolution.
15013 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
15014 MulticastDelegate is not allowed.
15016 * typemanager.cs: Add new types to lookup: System.TypedReference
15019 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
15020 check for TypedReference or ArgIterator, they are not allowed.
15022 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
15023 makes us properly catch 1510 in some conditions (see bug 56016 for
15026 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
15028 * CryptoConvert.cs: update from corlib version
15031 2004-04-05 Miguel de Icaza <miguel@ximian.com>
15033 * class.cs (Indexer.Define): Check indexername declaration
15035 2004-04-05 Marek Safar <marek.safar@seznam.cz>
15037 * attribute.cs (IsClsCompliant): Fixed problem with handling
15038 all three states (compliant, not-compliant, undetected).
15040 2004-03-30 Marek Safar <marek.safar@seznam.cz>
15042 * attribute.cs (Attribute): Location is now public.
15043 (Resolve): Store resolved arguments (pos_values) in attribute class.
15044 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
15045 (GetClsCompliantAttributeValue): New method that gets
15046 CLSCompliantAttribute value.
15047 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
15048 if exists else null.
15049 (AttributeTester): New class for CLS-Compliant verification routines.
15051 * class.cs (Emit): Add CLS-Compliant verification.
15052 (Method.GetSignatureForError): Implemented.
15053 (Constructor.GetSignatureForError): Implemented
15054 (Constructor.HasCompliantArgs): Returns if constructor has
15055 CLS-Compliant arguments.
15056 (Constructor.Emit): Override.
15057 (Construcor.IsIdentifierClsCompliant): New method; For constructors
15058 is needed to test only parameters.
15059 (FieldBase.GetSignatureForError): Implemented.
15060 (TypeContainer): New member for storing base interfaces.
15061 (TypeContainer.FindMembers): Search in base interfaces too.
15063 * codegen.cs (GetClsComplianceAttribute): New method that gets
15064 assembly or module CLSCompliantAttribute value.
15065 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
15067 (ModuleClass.Emit): Add error 3012 test.
15069 * const.cs (Emit): Override and call base for CLS-Compliant tests.
15071 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
15072 state for all decl types.
15073 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
15074 if CLS-Compliant tests are required.
15075 (IsClsCompliaceRequired): New method. Analyze whether code
15076 must be CLS-Compliant.
15077 (IsExposedFromAssembly): New method. Returns true when MemberCore
15078 is exposed from assembly.
15079 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
15080 value or gets cached value.
15081 (HasClsCompliantAttribute): New method. Returns true if MemberCore
15082 is explicitly marked with CLSCompliantAttribute.
15083 (IsIdentifierClsCompliant): New abstract method. This method is
15084 used to testing error 3005.
15085 (IsIdentifierAndParamClsCompliant): New method. Common helper method
15086 for identifier and parameters CLS-Compliant testing.
15087 (VerifyClsCompliance): New method. The main virtual method for
15088 CLS-Compliant verifications.
15089 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
15090 null. I don't know why is null (too many public members !).
15091 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
15092 and get value of first CLSCompliantAttribute that found.
15094 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
15095 (VerifyClsCompliance): Override and add extra tests.
15097 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
15098 clscheck- disable CLS-Compliant verification event if assembly is has
15099 CLSCompliantAttribute(true).
15101 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
15102 ApllyAttribute is now called in emit section as in the other cases.
15103 Possible future Emit integration.
15104 (IsIdentifierClsCompliant): New override.
15105 (VerifyClsCompliance): New override.
15106 (GetEnumeratorName): Returns full enum name.
15108 * parameter.cs (GetSignatureForError): Implemented.
15110 * report.cs (WarningData): New struct for Warning message information.
15111 (LocationOfPreviousError): New method.
15112 (Warning): New method. Reports warning based on the warning table.
15113 (Error_T): New method. Reports error based on the error table.
15115 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
15116 verifications are done here.
15118 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
15120 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
15121 CLSCompliantAttribute.
15122 (all_imported_types): New member holds all imported types from other
15124 (LoadAllImportedTypes): New method fills static table with exported types
15125 from all referenced assemblies.
15126 (Modules): New property returns all assembly modules.
15128 2004-03-30 Miguel de Icaza <miguel@ximian.com>
15130 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
15131 throwing a parser error.
15133 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
15134 which removes the hardcoded get_/set_ prefixes for properties, as
15135 IL allows for the properties to be named something else.
15139 * expression.cs: Do not override operand before we know if it is
15140 non-null. Fix 56207
15142 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15144 * typemanager.cs: support for pinned variables.
15146 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15148 * decl.cs, typemanager.cs: Avoid using an arraylist
15149 as a buffer if there is only one result set.
15151 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15153 * expression.cs: Make sure you cant call a static method
15154 with an instance expression, bug #56174.
15156 2004-03-29 Miguel de Icaza <miguel@ximian.com>
15158 * class.cs (IsDuplicateImplementation): Improve error reporting to
15159 flag 663 (method only differs in parameter modifier).
15161 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
15162 in preprocessor directives.
15164 * location.cs (LookupFile): Allow for the empty path.
15166 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
15167 better approach for some of that patch, but its failing with the
15168 CharSet enumeration. For now try/catch will do.
15170 * typemanager.cs: Do not crash if a struct does not have fields.
15173 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15175 * expression.cs: cs0213, cant fix a fixed expression.
15178 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15180 * cs-parser.jay: detect invalid embeded statements gracefully.
15183 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15185 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
15188 the invocation type may not be a subclass of the tye of the item/
15189 The type of the item must be a subclass of the invocation item.
15194 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
15196 * attribute.cs: Added methods to get a string and a bool from an
15197 attribute. Required to information from AssemblyKeyFileAttribute,
15198 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
15199 * codegen.cs: Modified AssemblyName creation to include support for
15200 strongnames. Catch additional exceptions to report them as CS1548.
15201 * compiler.csproj: Updated include CryptoConvert.cs.
15202 * compiler.csproj.user: Removed file - user specific configuration.
15203 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
15204 Mono.Security assembly. The original class is maintained and tested in
15205 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
15206 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
15207 like CSC 8.0 (C# v2) supports.
15208 * Makefile: Added CryptoConvert.cs to mcs sources.
15209 * rootcontext.cs: Added new options for strongnames.
15211 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
15213 * driver.cs: For --expect-error, report error code `2'
15214 if the program compiled with no errors, error code `1' if
15215 it compiled with an error other than the one expected.
15217 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
15219 * compiler.csproj: Updated for Visual Studio .NET 2003.
15220 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
15221 * compiler.sln: Updated for Visual Studio .NET 2003.
15223 2004-03-24 Ravi Pratap M <ravi@ximian.com>
15225 * expression.cs: Fix bug #47234. We basically need to apply the
15226 rule that we prefer the conversion of null to a reference type
15227 when faced with a conversion to 'object' (csc behaviour).
15229 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15231 * statement.cs: Shorter form for foreach, eliminates
15232 a local variable. r=Martin.
15234 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15236 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
15237 checks if we can use brtrue/brfalse to test for 0.
15238 * expression.cs: use the above in the test for using brtrue/brfalse.
15239 cleanup code a bit.
15241 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15243 * expression.cs: Rewrite string concat stuff. Benefits:
15245 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
15246 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
15247 rather than a concat chain.
15249 * typemanager.cs: Add lookups for more concat overloads.
15251 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15253 * expression.cs: Emit shorter il code for array init.
15270 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
15272 * statement.cs: Before, two switch blocks would be merged if the
15273 total size of the blocks (end_item - begin_item + 1) was less than
15274 two times the combined sizes of the blocks.
15276 Now, it will only merge if after the merge at least half of the
15281 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
15283 * class.cs : csc build fix for GetMethods(). See bug #52503.
15285 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
15287 * expression.cs: Make sure fp comparisons work with NaN.
15288 This fixes bug #54303. Mig approved this patch a long
15289 time ago, but we were not able to test b/c the runtime
15292 2004-03-19 Miguel de Icaza <miguel@ximian.com>
15294 * ecore.cs (TypExpr.GetHashCode): implement this overload.
15296 2004-03-19 Martin Baulig <martin@ximian.com>
15298 * class.cs (MemberCore.IsDuplicateImplementation): Report the
15299 error here and not in our caller.
15301 2004-03-19 Martin Baulig <martin@ximian.com>
15303 * interface.cs: Completely killed this file.
15304 (Interface): We're now a TypeContainer and live in class.cs.
15306 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
15307 argument; we're now also called for interfaces.
15308 (TypeContainer.DefineMembers): Allow this method being called
15310 (TypeContainer.GetMethods): New public method; formerly known as
15311 Interface.GetMethod(). This is used by PendingImplementation.
15312 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
15313 it's now private and non-static.
15314 (Interface): Moved this here; it's now implemented similar to
15316 (Method, Property, Event, Indexer): Added `bool is_interface'
15317 argument to their .ctor's.
15318 (MemberBase.IsInterface): New public field.
15320 * cs-parser.jay: Create normal Method, Property, Event, Indexer
15321 instances instead of InterfaceMethod, InterfaceProperty, etc.
15322 (opt_interface_base): Removed; we now use `opt_class_base' instead.
15323 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
15325 2004-03-19 Martin Baulig <martin@ximian.com>
15327 * class.cs (MethodCore.IsDuplicateImplementation): New private
15328 method which does the CS0111 checking.
15329 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
15330 Use IsDuplicateImplementation().
15332 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
15334 * decl.cs (FindMemberToOverride): New method to find the correct
15335 method or property to override in the base class.
15337 - Make Method/Property use the above method to find the
15338 version in the base class.
15339 - Remove the InheritableMemberSignatureCompare as it is now
15342 This patch makes large code bases much faster to compile, as it is
15343 O(n) rather than O(n^2) to do this validation.
15345 Also, it fixes bug 52458 which is that nested classes are not
15346 taken into account when finding the base class member.
15348 Reviewed/Approved by Martin.
15350 2004-03-17 Marek Safar <marek.safar@seznam.cz>
15352 * interface.cs: In all interface classes removed redundant
15353 member initialization.
15355 2004-03-16 Martin Baulig <martin@ximian.com>
15357 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
15359 2004-03-15 Miguel de Icaza <miguel@ximian.com>
15361 * decl.cs (DefineTypeAndParents): New helper method to define a
15362 type's containers before the type itself is defined; This is a
15363 bug exposed by the recent changes to Windows.Forms when an
15364 implemented interface was defined inside a class that had not been
15367 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
15369 (Check): Loop correctly to report errors modifiers
15370 (UNSAFE was not in the loop, since it was the same as TOP).
15372 * interface.cs: Every interface member now takes a ModFlags,
15373 instead of a "is_new" bool, which we set on the base MemberCore.
15375 Every place where we called "UnsafeOk" in the interface, now we
15376 call the proper member (InterfaceMethod.UnsafeOK) instead to get
15377 the unsafe settings from the member declaration instead of the
15378 container interface.
15380 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
15382 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
15383 `set_indexer_name' to the pending bits (one per type).
15385 We fixed a bug today that was picking the wrong method to
15386 override, since for properties the existing InterfaceMethod code
15387 basically ignored the method name. Now we make sure that the
15388 method name is one of the valid indexer names.
15390 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
15392 * support.cs (SeekableStreamReader): Keep track of stream byte
15393 positions and don't mix them with character offsets to the buffer.
15395 Patch from Gustavo Giráldez
15397 2004-03-15 Marek Safar <marek.safar@seznam.cz>
15399 * interface.cs (InterfaceSetGetBase): Removed double member
15400 initialization, base class does it as well.
15402 2004-03-13 Martin Baulig <martin@ximian.com>
15404 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
15405 when compiling corlib.
15407 2004-03-13 Miguel de Icaza <miguel@ximian.com>
15409 * convert.cs (ExplicitConversion): We were reporting an error on
15410 certain conversions (object_type source to a value type, when the
15411 expression was `null') before we had a chance to pass it through
15412 the user defined conversions.
15414 * driver.cs: Replace / and \ in resource specifications to dots.
15417 * class.cs: Add check for duplicate operators. Fixes 52477
15419 2004-03-11 Miguel de Icaza <miguel@ximian.com>
15421 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
15422 that are in the middle of the statements, not only at the end.
15425 * class.cs (TypeContainer.AddField): No longer set the
15426 `HaveStaticConstructor' flag, now we call it
15427 `UserDefineStaticConstructor' to diferentiate the slightly
15428 semantic difference.
15430 The situation is that we were not adding BeforeFieldInit (from
15431 Modifiers.TypeAttr) to classes that could have it.
15432 BeforeFieldInit should be set to classes that have no static
15437 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
15439 And most importantly Zoltan's comment:
15441 http://bugzilla.ximian.com/show_bug.cgi?id=44229
15443 "I think beforefieldinit means 'it's ok to initialize the type sometime
15444 before its static fields are used', i.e. initialization does not need
15445 to be triggered by the first access to the type. Setting this flag
15446 helps the JIT to compile better code, since it can run the static
15447 constructor at JIT time, and does not need to generate code to call it
15448 (possibly lots of times) at runtime. Unfortunately, mcs does not set
15449 this flag for lots of classes like String.
15451 csc sets this flag if the type does not have an explicit static
15452 constructor. The reasoning seems to be that if there are only static
15453 initalizers for a type, and no static constructor, then the programmer
15454 does not care when this initialization happens, so beforefieldinit
15457 This bug prevents the AOT compiler from being usable, since it
15458 generates so many calls to mono_runtime_class_init that the AOT code
15459 is much slower than the JITted code. The JITted code is faster,
15460 because it does not generate these calls if the vtable is type is
15461 already initialized, which is true in the majority of cases. But the
15462 AOT compiler can't do this."
15464 2004-03-10 Miguel de Icaza <miguel@ximian.com>
15466 * class.cs (MethodData.Emit): Refactor the code so symbolic
15467 information is generated for destructors; For some reasons we
15468 were taking a code path that did not generate symbolic information
15471 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
15473 * class.cs: Create a Constructor.CheckBase method that
15474 takes care of all validation type code. The method
15475 contains some code that was moved from Define.
15477 It also includes new code that checks for duplicate ctors.
15478 This fixes bug #55148.
15480 2004-03-09 Joshua Tauberer <tauberer@for.net>
15482 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
15483 a { ... }-style array creation invokes EmitStaticInitializers
15484 which is not good for reference-type arrays. String, decimal
15485 and now null constants (NullCast) are not counted toward
15486 static initializers.
15488 2004-03-05 Martin Baulig <martin@ximian.com>
15490 * location.cs (SourceFile.HasLineDirective): New public field;
15491 specifies whether the file contains or is referenced by a "#line"
15493 (Location.DefineSymbolDocuments): Ignore source files which
15494 either contain or are referenced by a "#line" directive.
15496 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
15498 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
15499 direct access to our parent, so check the method inline there.
15501 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
15503 * expression.cs (Invocation.EmitCall): Miguel's last commit
15504 caused a regression. If you had:
15509 In Foo the implict this would be null.
15511 2004-02-27 Miguel de Icaza <miguel@ximian.com>
15513 * expression.cs (Invocation.EmitCall): If the method is not
15514 virtual, do not emit a CallVirt to it, use Call.
15516 * typemanager.cs (GetFullNameSignature): Improve the method to
15517 cope with ".ctor" and replace it with the type name.
15519 * class.cs (ConstructorInitializer.Resolve): Now the method takes
15520 as an argument the ConstructorBuilder where it is being defined,
15521 to catch the recursive constructor invocations.
15523 2004-02-26 Miguel de Icaza <miguel@ximian.com>
15525 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
15526 routines to check if a type is an enumerable/enumerator allow
15527 classes that implement the IEnumerable or IEnumerator interfaces.
15529 * class.cs (Property, Operator): Implement IIteratorContainer, and
15530 implement SetYields.
15532 (Property.Define): Do the block swapping for get_methods in the
15533 context of iterators. We need to check if Properties also
15534 include indexers or not.
15536 (Operator): Assign the Block before invoking the
15537 OperatorMethod.Define, so we can trigger the Iterator code
15540 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
15541 Property and Operator classes are not created when we parse the
15542 declarator but until we have the block completed, so we use a
15543 singleton SimpleIteratorContainer.Simple to flag whether the
15544 SetYields has been invoked.
15546 We propagate this setting then to the Property or the Operator to
15547 allow the `yield' to function.
15549 2004-02-25 Marek Safar <marek.safar@seznam.cz>
15551 * codegen.cs: Implemented attribute support for modules.
15552 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
15553 Assembly/Module functionality.
15555 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
15556 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
15557 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
15559 2004-02-16 Marek Safar <marek.safar@seznam.cz>
15561 * interface.cs (FindMembers): The operation is performed on all base
15562 interfaces and not only on the first. It is required for future CLS Compliance patch.
15564 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
15566 * statement.cs, codegen.cs:
15567 This patch deals with patterns such as:
15569 public class List : IEnumerable {
15571 public MyEnumerator GetEnumerator () {
15572 return new MyEnumerator(this);
15575 IEnumerator IEnumerable.GetEnumerator () {
15579 public struct MyEnumerator : IEnumerator {
15584 Before, there were a few things we did wrong:
15585 1) we would emit callvirt on a struct, which is illegal
15586 2) we emited ldarg when we needed to emit ldarga
15587 3) we would mistakenly call the interface methods on an enumerator
15588 type that derived from IEnumerator and was in another assembly. For example:
15590 public class MyEnumerator : IEnumerator
15592 Would have the interface methods called, even if there were public impls of the
15593 method. In a struct, this lead to invalid IL code.
15595 2004-02-11 Marek Safar <marek.safar@seznam.cz>
15597 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
15600 * delegate.cs (Define): Fixed crash when delegate type is undefined.
15602 2004-02-11 Miguel de Icaza <miguel@ximian.com>
15604 * cs-parser.jay: Fix small regression: we were not testing V2
15605 compiler features correctly.
15607 * interface.cs: If the emit context is null, then create one
15609 2004-02-09 Marek Safar <marek.safar@seznam.cz>
15611 * decl.cs (GetSignatureForError): New virtual method to get full name
15612 for error messages.
15614 * attribute.cs (IAttributeSupport): New interface for attribute setting.
15615 Now it is possible to rewrite ApplyAttributes method to be less if/else.
15617 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
15618 Duplicated members and code in these classes has been removed.
15619 Better encapsulation in these classes.
15621 2004-02-07 Miguel de Icaza <miguel@ximian.com>
15623 * assign.cs (Assign.DoResolve): When dealing with compound
15624 assignments, there is a new rule in ECMA C# 2.4 (might have been
15625 there before, but it is documented here) that states that in:
15629 If b is of type int, and the `op' is a shift-operator, then the
15630 above is evaluated as:
15634 * expression.cs (Binary.ResolveOperator): Instead of testing for
15635 int/uint/long/ulong, try to implicitly convert to any of those
15636 types and use that in pointer arithmetic.
15638 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
15639 method to print information for from the type, not from the
15640 null-method we were given.
15642 2004-02-01 Duncan Mak <duncan@ximian.com>
15644 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
15645 parsing for cmd, fixes bug #53694.
15647 2004-02-04 Marek Safar <marek.safar@seznam.cz>
15649 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
15650 in the member name duplication tests. Property and operator name duplication
15651 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
15653 2004-02-03 Marek Safar <marek.safar@seznam.cz>
15655 * interface.cs (PopulateMethod): Fixed crash when interface method
15656 returns not existing type (error test cs0246-3.cs).
15658 2004-02-02 Ravi Pratap M <ravi@ximian.com>
15660 * cs-parser.jay (interface_accessors): Re-write actions to also
15661 store attributes attached to get and set methods. Fix spelling
15664 (inteface_property_declaration): Modify accordingly.
15666 (InterfaceAccessorInfo): New helper class to store information to pass
15667 around between rules that use interface_accessors.
15669 * interface.cs (Emit): Apply attributes on the get and set
15670 accessors of properties and indexers too.
15672 * attribute.cs (ApplyAttributes): Modify accordingly to use the
15673 right MethodBuilder when applying attributes to the get and set accessors.
15675 2004-01-31 Miguel de Icaza <miguel@ximian.com>
15677 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
15679 2004-01-26 Miguel de Icaza <miguel@ximian.com>
15681 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
15683 2004-01-25 Miguel de Icaza <miguel@ximian.com>
15685 * cs-parser.jay: Remove YIELD token, instead use the new grammar
15686 changes that treat `yield' specially when present before `break'
15687 or `return' tokens.
15689 * cs-tokenizer.cs: yield is no longer a keyword.
15691 2004-01-23 Marek Safar <marek.safar@seznam.cz>
15693 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
15694 setting for default constructors.
15695 For default constructors are almost every time set wrong Modifier. The
15696 generated IL code has been alright. But inside mcs this values was
15697 wrong and this was reason why several of my CLS Compliance tests
15700 2004-01-22 Martin Baulig <martin@ximian.com>
15702 * cs-parser.jay (namespace_or_type_name): Return an Expression,
15703 not a QualifiedIdentifier. This is what `type_name_expression'
15704 was previously doing.
15705 (type_name_expression): Removed; the code is now in
15706 `namespace_or_type_name'.
15707 (qualified_identifier): Removed, use `namespace_or_type_name'
15709 (QualifiedIdentifier): Removed this class.
15711 2004-01-22 Martin Baulig <martin@ximian.com>
15713 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
15714 not a string as alias name.
15716 2004-01-21 Miguel de Icaza <miguel@ximian.com>
15718 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
15719 #52730 bug, and instead compute correctly the need to use a
15720 temporary variable when requesting an address based on the
15721 static/instace modified of the field and the constructor.
15723 2004-01-21 Martin Baulig <martin@ximian.com>
15725 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
15726 class and namespace before looking up aliases. Fixes #52517.
15728 2004-01-21 Martin Baulig <martin@ximian.com>
15730 * flowanalysis.cs (UsageVector.Merge): Allow variables being
15731 assinged in a 'try'; fixes exception4.cs.
15733 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15734 * class.cs : Implemented parameter-less constructor for TypeContainer
15736 * decl.cs: Attributes are now stored here. New property OptAttributes
15738 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
15740 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
15742 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15744 * typemanager.cs (CSharpSignature): Now reports also inner class name.
15745 (CSharpSignature): New method for indexer and property signature.
15747 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15749 * pending.cs (IsVirtualFilter): Faster implementation.
15751 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15753 * typemanager.cs: Avoid inclusion of same assembly more than once.
15755 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15757 * cs-parser.jay: Fixed problem where the last assembly attribute
15758 has been applied also to following declaration (class, struct, etc.)
15760 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15762 * class.cs: Added error CS0538, CS0539 reporting.
15763 Fixed crash on Microsoft runtime when field type is void.
15765 * cs-parser.jay: Added error CS0537 reporting.
15767 * pending.cs: Added error CS0535 reporting.
15768 Improved error report for errors CS0536, CS0534.
15770 2004-01-20 Miguel de Icaza <miguel@ximian.com>
15772 Merge a few bits from the Anonymous Method MCS tree.
15774 * statement.cs (ToplevelBlock): New class for toplevel methods,
15775 will hold anonymous methods, lifted variables.
15777 * cs-parser.jay: Create toplevel blocks for delegates and for
15778 regular blocks of code.
15780 2004-01-20 Martin Baulig <martin@ximian.com>
15782 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
15783 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
15784 and `NeedExplicitReturn'; added `IsLastStatement'.
15785 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
15786 have a `ReturnLabel' or we're not unreachable.
15788 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
15789 child's reachability; don't just override ours with it. Fixes
15790 #58058 (lluis's example).
15791 (FlowBranching): Added public InTryOrCatch(), InCatch(),
15792 InFinally(), InLoop(), InSwitch() and
15793 BreakCrossesTryCatchBoundary() methods.
15795 * statement.cs (Return): Do all error checking in Resolve().
15796 Unless we are the last statement in a top-level block, always
15797 create a return label and jump to it.
15798 (Break, Continue): Do all error checking in Resolve(); also make
15799 sure we aren't leaving a `finally'.
15800 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
15801 statement in a top-level block.
15802 (Block.Flags): Added `IsDestructor'.
15803 (Block.IsDestructor): New public property.
15805 2004-01-20 Martin Baulig <martin@ximian.com>
15807 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
15809 2004-01-20 Martin Baulig <martin@ximian.com>
15811 * statement.cs (Statement.ResolveUnreachable): New public method.
15812 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
15813 (Block.Resolve): Resolve unreachable statements.
15815 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15817 * expression.cs: We need to fix the case where we do
15818 not have a temp variable here.
15820 * assign.cs: Only expression compound assignments need
15821 temporary variables.
15823 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15825 * flowanalysis.cs: Reduce memory allocation in a few ways:
15826 - A block with no variables should not allocate a bit
15828 - A method with no out parameters does not need any tracking
15829 for assignment of the parameters, so we need not allocate
15832 public readonly Type[] VariableTypes;
15833 public readonly string[] VariableNames;
15834 Are redundant. The data is already stored in the variable
15835 map, so we need not allocate another array for it.
15836 - We need to add alot of checks for if (params | locals) == null
15837 due to the first two changes.
15839 2004-01-18 Miguel de Icaza <miguel@ximian.com>
15841 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
15842 implement IMemoryLocation, we store a copy on a local variable and
15843 take the address of it. Patch from Benjamin Jemlich
15845 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
15846 to use a special "type_name_expression" rule which reduces the
15847 number of "QualifiedIdentifier" classes created, and instead
15848 directly creates MemberAccess expressions.
15850 2004-01-17 Miguel de Icaza <miguel@ximian.com>
15852 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
15853 that fixes #52853. Null literal assignment to ValueType
15855 * class.cs (MethodData.Emit): Instead of checking the name of the
15856 method to determine if its a destructor, create a new derived
15857 class from Method called Destructor, and test for that.
15859 * cs-parser.jay: Create a Destructor object instead of a Method.
15861 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15865 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15867 * expression.cs (Binary.ResolveOperator): Perform an implicit
15868 conversion from MethodGroups to their delegate types on the
15869 Addition operation.
15871 * delegate.cs: Introduce a new class DelegateCreation that is the
15872 base class for `NewDelegate' and `ImplicitDelegateCreation',
15873 factor some code in here.
15875 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15876 conversion from MethodGroups to compatible delegate types.
15878 * ecore.cs (Expression.Resolve): Do not flag error 654
15879 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15880 we allow conversions from MethodGroups to delegate types now.
15882 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15883 assignments in v2 either.
15885 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15887 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15888 static read-only fields in ctors.
15890 Applied patch from Benjamin Jemlich
15892 * expression.cs (UnaryMutator): Avoid leaking local variables.
15894 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15896 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15897 here to return true, as they can be used like this:
15899 (XXX) int.MEMBER ()
15901 Fixed 49836 and all the other dups
15903 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15905 * driver.cs: Implement /win32res and /win32icon.
15907 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15909 * cs-parser.jay: Add a rule to improve error handling for the
15910 common mistake of placing modifiers after the type.
15912 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15914 * cs-parser.jay (interface_event_declaration): Catch
15915 initialization of events on interfaces, and report cs0068
15917 * cs-parser.jay (interface_event_declaration): Catch
15918 initialization of events.
15920 * ecore.cs: Better report missing constructors.
15922 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15923 the error reporting done in the wrong place. Fix.
15925 * expression.cs (Binary.ResolveOperator): Catch the
15926 operator + (E x, E y) error earlier, and later allow for implicit
15927 conversions in operator +/- (E e, U x) from U to the underlying
15930 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15931 52596, if the container class is abstract, the default constructor
15932 is protected otherwise its public (before, we were always public).
15934 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15937 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15938 Jemlich that fixes bug #52597, MCS was generating invalid code for
15939 idisposable structs. Thanks to Ben for following up with this
15942 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15944 * driver.cs: Allow assemblies without code to be generated, fixes
15947 2004-01-07 Nick Drochak <ndrochak@gol.com>
15949 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15951 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15953 * cs-parser.jay: Add rules to improve error reporting if fields or
15954 methods are declared at the namespace level (error 116)
15956 * Add rules to catch event add/remove
15958 2004-01-04 David Sheldon <dave-mono@earth.li>
15960 * expression.cs: Added matching ")" to error message for
15963 2004-01-03 Todd Berman <tberman@gentoo.org>
15965 * ecore.cs, attribute.cs:
15966 Applying fix from #52429.
15968 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15970 * ecore.cs, expression.cs, statement.cs:
15971 Total rewrite of how we handle branching. We
15972 now handle complex boolean expressions with fewer
15973 jumps. As well if (x == 0) no longer emits a ceq.
15975 if (x is Foo) is much faster now, because we generate
15978 Overall, we get a pretty big improvement on our benchmark
15979 tests. The code we generate is smaller and more readable.
15981 I did a full two-stage bootstrap. The patch was reviewed
15982 by Martin and Miguel.
15984 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15986 * cs-parser.jay: Make primary_expression not take a QI.
15987 we dont need this because the member_access rule covers
15988 us here. So we replace the rule with just IDENTIFIER.
15990 This has two good effects. First, we remove a s/r conflict.
15991 Second, we allocate many fewer QualifiedIdentifier objects.
15993 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15995 * attribute.cs: Handle MarshalAs attributes as pseudo, and
15996 set the correct information via SRE. This prevents
15997 hanging on the MS runtime. Fixes #29374.
15999 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
16001 * convert.cs: correctly handle conversions to value types
16002 from Enum and ValueType as unboxing conversions.
16004 Fixes bug #52569. Patch by Benjamin Jemlich.
16006 2004-01-02 Ravi Pratap <ravi@ximian.com>
16008 * expression.cs (BetterConversion): Prefer int -> uint
16009 over int -> ulong (csc's behaviour). This fixed bug #52046.
16011 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
16013 * decl.cs (MemberCache.FindMembers): now returns a
16016 * typemanager.cs: In general, go with with ^^.
16017 (CopyNewMethods): take an IList.
16018 (RealMemberLookup): Only allocate an arraylist
16019 if we copy from two sets of methods.
16021 This change basically does two things:
16022 1) Fewer array lists allocated due to CopyNewMethods.
16023 2) the explicit cast in MemberList costed ALOT.
16025 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
16027 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
16028 a hashtable to avoid needless string allocations when an identifier is
16029 used more than once (the common case).
16031 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
16033 * pending.cs: MS's TypeBuilder.GetInterfaces ()
16034 is broken, it will not return anything. So, we
16035 have to use the information we have in mcs to
16038 * typemanager.cs: Add a cache for GetInterfaces,
16039 since this will now be used more often (due to ^^)
16041 (GetExplicitInterfaces) New method that gets the
16042 declared, not effective, interfaces on a type
16043 builder (eg, if you have interface IFoo, interface
16044 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
16047 This patch makes MCS able to bootstrap itself on
16050 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
16052 * expression.cs: Remove the Nop's that Miguel put
16055 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16057 * report.cs, codegen.cs: Give the real stack trace to
16058 the error when an exception is thrown.
16060 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16062 * decl.cs: only allocate hashtables for ifaces if
16065 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16067 * expression.cs: fix the error from cs0121-2.cs
16068 (a parent interface has two child interfaces that
16069 have a function with the same name and 0 params
16070 and the function is called through the parent).
16072 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
16074 * class.cs, rootcontext.cs, typmanager.cs: do not
16077 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
16079 * codegen.cs: remove stack for the ec flow branching.
16080 It is already a linked list, so no need.
16082 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
16084 * Makefile: Allow custom profiler here.
16086 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16088 * typemanager.cs (LookupType):
16089 - Use a static char [], because split takes
16090 a param array for args, so it was allocating
16092 - Do not store true in a hashtable, it boxes.
16094 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16096 * flowanalysis.cs: bytify common enums.
16098 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16100 * modifiers.cs: Add a new set of flags for the
16101 flags allowed on explicit interface impls.
16102 * cs-parser.jay: catch the use of modifiers in
16103 interfaces correctly.
16104 * class.cs: catch private void IFoo.Blah ().
16106 All related to bug #50572.
16108 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16110 * decl.cs: Rewrite the consistant accessability checking.
16111 Accessability is not linear, it must be implemented in
16112 a tableish way. Fixes #49704.
16114 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16116 * expression.cs: Handle negation in a checked context.
16117 We must use subtraction from zero. Fixes #38674.
16119 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16121 * class.cs: Ignore static void main in DLLs.
16122 * rootcontext.cs: Handle the target type here,
16123 since we are have to access it from class.cs
16124 * driver.cs: account for the above.
16126 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16128 * report.cs: Give line numbers and files if available.
16130 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
16132 * driver.cs: Implement /addmodule.
16134 * typemanager.cs: Change 'modules' field so it now contains Modules not
16137 2003-12-20 Martin Baulig <martin@ximian.com>
16139 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
16140 (FieldBase.IsAssigned): Removed this field.
16141 (FieldBase.SetAssigned): New public method.
16142 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
16144 2003-12-20 Martin Baulig <martin@ximian.com>
16146 * expression.cs (LocalVariableReference.DoResolve): Don't set
16147 `vi.Used' if we're called from DoResolveLValue().
16149 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
16150 returns the usage vector it just merged into the current one -
16151 pass this one to UsageWarning().
16152 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
16153 of the `EmitContext', don't call this recursively on our children.
16155 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
16157 * driver.cs: Implement /target:module.
16159 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
16161 * support.cs (CharArrayHashtable): New helper class.
16163 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
16164 char arrays, not strings, so we can avoid creating a string in
16165 consume_identifier if the identifier is a keyword.
16167 2003-12-16 Martin Baulig <martin@ximian.com>
16169 * statement.cs (LocalInfo.Assigned): Removed this property.
16170 (LocalInfo.Flags): Removed `Assigned'.
16171 (LocalInfo.IsAssigned): New public method; takes the EmitContext
16172 and uses flow analysis.
16173 (Block.UsageWarning): Made this method private.
16174 (Block.Resolve): Call UsageWarning() if appropriate.
16176 * expression.cs (LocalVariableReference.DoResolve): Always set
16177 LocalInfo.Used here.
16179 2003-12-13 Martin Baulig <martin@ximian.com>
16181 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
16182 any value here; we're now using flow analysis to figure out
16183 whether a statement/block returns a value.
16185 2003-12-13 Martin Baulig <martin@ximian.com>
16187 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
16189 (FlowBranching.MergeFinally): Don't call
16190 `branching.CheckOutParameters()' here, this is called in
16192 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
16193 when adding the `finally' vector.
16195 2003-12-13 Martin Baulig <martin@ximian.com>
16198 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
16199 actually work and also fix #48962.
16201 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
16203 * decl.cs: Do not check System.Object for nested types,
16204 since we know it does not have any. Big bang for buck:
16207 Run 1: 8.35 seconds
16208 Run 2: 8.32 seconds
16209 corlib: 17.99 seconds
16211 Run 1: 8.17 seconds
16212 Run 2: 8.17 seconds
16213 corlib: 17.39 seconds
16215 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
16217 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
16218 time we are returning 0 members, so we save alot here.
16220 2003-12-11 Martin Baulig <martin@ximian.com>
16222 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
16223 `MergeChild()', also just take the `FlowBranching' as argument;
16224 call Merge() on it and return the result.
16225 (FlowBranching.Merge): We don't need to do anything if we just
16228 2003-12-11 Martin Baulig <martin@ximian.com>
16230 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
16231 them in an `ArrayList' to reduce memory usage. Thanks to Ben
16232 Maurer for this idea.
16234 2003-12-11 Martin Baulig <martin@ximian.com>
16236 * flowanalysis.cs (MergeResult): This class is now gone; we now
16237 use the `UsageVector' for this. The reason for this is that if a
16238 branching just has one sibling, we don't need to "merge" them at
16239 all - that's the next step to do.
16240 (FlowBranching.Merge): We now return a `UsageVector' instead of a
16243 2003-12-11 Martin Baulig <martin@ximian.com>
16245 Reworked flow analyis and made it more precise and bug-free. The
16246 most important change is that we're now using a special `Reachability'
16247 class instead of having "magic" meanings of `FlowReturns'. I'll
16248 do some more cleanups and optimizations and also add some more
16249 documentation this week.
16251 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
16252 largely reworked this class.
16253 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
16254 the new `Reachability' class instead of having "magic" values here.
16255 (FlowBranching): We're now using an instance of `Reachability'
16256 instead of having separate `Returns', `Breaks' etc. fields.
16258 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
16259 based on flow analysis; ignore the return value of block.Emit ().
16261 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
16263 * driver.cs typemanager.cs: Find the mono extensions to corlib even
16264 if they are private.
16266 2003-12-09 Martin Baulig <martin@ximian.com>
16268 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
16269 call them directly on the UsageVector.
16271 2003-12-09 Martin Baulig <martin@ximian.com>
16273 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
16274 Changed return type from `FlowReturns' to `Reachability'.
16276 2003-12-09 Martin Baulig <martin@ximian.com>
16278 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
16279 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
16280 `Reachable' fields with a single `Reachability' one.
16282 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16284 * class.cs (FindMembers): Remove foreach's.
16289 Run 1: 8.74 seconds
16290 Run 2: 8.71 seconds
16293 Run 1: 8.64 seconds
16294 Run 2: 8.58 seconds
16297 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16302 This patch does a few things:
16303 1. EmptyStatement is now a singleton, so it is never reallocated.
16304 2. All blah is EmptyStatement constructs have been changed to
16305 blah == EmptyStatement.Value, which is much faster and valid
16306 now that EmptyStatement is a singleton.
16307 3. When resolving a block, rather than allocating a new array for
16308 the non-empty statements, empty statements are replaced with
16309 EmptyStatement.Value
16310 4. Some recursive functions have been made non-recursive.
16311 Mainly the performance impact is from (3), however (1) and (2) are needed for
16312 this to work. (4) does not make a big difference in normal situations, however
16313 it makes the profile look saner.
16318 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16319 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16320 Total memory allocated: 56397 KB
16323 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
16324 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
16325 Total memory allocated: 55666 KB
16327 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16329 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
16330 than the hashtable in a hashtable version
16332 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
16333 we always end up concating a string. This results in a huge perf
16334 loss, because many strings have to be tracked by the GC. In this
16335 patch, we first use a hashtable that works with two keys, so that
16336 the strings do not need to be concat'ed.
16340 Run 1: 8.74 seconds
16341 Run 2: 8.71 seconds
16344 Run 1: 8.65 seconds
16345 Run 2: 8.56 seconds
16347 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16349 * Makefile: Add a new target `do-time' that does a quick and simple
16350 profile, leaving easy to parse output.
16352 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
16354 * codegen.cs (Init): Create the dynamic assembly with
16355 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
16357 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
16359 * support.cs: Make the PtrHashtable use only one
16360 instance of its comparer.
16362 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
16364 * typemanager.cs: Fix lookup of GetNamespaces.
16366 2003-11-29 Miguel de Icaza <miguel@ximian.com>
16368 * expression.cs: Removed redundant line.
16370 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
16371 ArrayLists, use for loops with bounds.
16373 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
16376 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
16377 arraylists, use for loop with bounds.
16379 The above three changes give us a 0.071 second performance
16380 improvement out of 3.294 seconds down to 3.223. On my machine
16381 the above changes reduced the memory usage by 1,387 KB during
16382 compiler bootstrap.
16384 * cs-parser.jay (QualifiedIdentifier): New class used to represent
16385 QualifiedIdentifiers. Before we created a new string through
16386 concatenation, and mostly later on, the result would be
16387 manipulated by DecomposeQI through string manipulation.
16389 This reduced the compiler memory usage for bootstrapping from
16390 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
16391 compile times in 0.05 seconds.
16393 2003-11-28 Dick Porter <dick@ximian.com>
16395 * support.cs: Do string compares with the Invariant culture.
16403 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
16404 the comparison is done with the Invariant culture.
16406 2003-11-27 Miguel de Icaza <miguel@ximian.com>
16408 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
16409 GetEnumerator method.
16411 (ProbeCollectionType): Iterate starting at the most specific type
16412 upwards looking for a GetEnumerator
16414 * expression.cs: Shift count can be up to 31 for int/uint and 63
16417 2003-11-26 Miguel de Icaza <miguel@ximian.com>
16419 * statement.cs (Block.LookupLabel): Also look for the label on the
16420 children blocks. Use a hash table to keep track of visited
16423 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
16424 we actually did transform the other operand, otherwise fall back
16425 to the common codepath that casts to long.
16427 * cs-tokenizer.cs: Use the same code pattern as the int case.
16428 Maybe I should do the parsing myself, and avoid depending on the
16429 Parse routines to get this done.
16431 2003-11-25 Miguel de Icaza <miguel@ximian.com>
16433 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16434 which fixes bug 51347. This time test it.
16436 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
16437 attributes for example can not tell the difference between these.
16438 The difference was only a syntax feature of the language.
16440 * attribute.cs: Apply attributes to delegates.
16442 * delegate.cs: Call the apply attributes method.
16444 2003-11-24 Miguel de Icaza <miguel@ximian.com>
16446 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
16447 comparing 0 vs Byte.MinValue, not the value
16449 (ImplicitConversionRequired): When reporting a conversion error,
16450 use error 31 to print out the constant error instead of the
16453 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16454 which fixes bug 51347.
16456 2003-11-22 Miguel de Icaza <miguel@ximian.com>
16458 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
16459 which fixes the -warnaserror command line option.
16461 2003-11-21 Miguel de Icaza <miguel@ximian.com>
16463 * cfold.cs (DoNumericPromotions): During constant folding of
16464 additions on UIntConstant, special case intconstants with
16465 IntConstants like we do on the expression binary operator.
16467 2003-11-12 Miguel de Icaza <miguel@ximian.com>
16469 * convert.cs (ImplicitReferenceConversion): We were missing a case
16470 (System.Enum are not value types or class types, so we need to
16471 classify them separatedly).
16473 * driver.cs: We do not support error 2007.
16475 2003-11-12 Jackson Harper <jackson@ximian.com>
16477 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
16478 system directory. Also use the full file name so users can
16479 libraries names mscorlib-o-tron.dll in a non system dir.
16481 2003-11-10 Martin Baulig <martin@ximian.com>
16483 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
16484 (TypeManager.InitCoreTypes): Initialize them here, but instead of
16485 calling `ResolveType()' on them, directly assign their `Type'.
16487 2003-11-08 Martin Baulig <martin@ximian.com>
16489 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
16490 return value and the `out parent' parameter.
16491 (TypeContainer.DefineType): Moved the CS0644 check into
16492 GetClassBases(). Don't pass the interface types to the
16493 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
16494 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
16496 * ecore.cs (TypeExpr.IsAttribute): New property.
16497 (TypeExpr.GetInterfaces): New method.
16499 * interface.cs (Interface.GetInterfaceTypeByName): Return a
16500 TypeExpr instead of a Type.
16501 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
16502 (Interface.DefineType): Don't pass the interface types to the
16503 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
16504 them later and then call `TypeBulider.AddInterfaceImplementation()'.
16506 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
16507 instead of a `Type[]'.
16508 (TypeManager.RegisterBuilder): Likewise.
16509 (TypeManager.AddUserInterface): Likewise.
16510 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
16511 `Type[]' and also return a `TypeExpr[]'.
16512 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
16514 2003-11-08 Martin Baulig <martin@ximian.com>
16516 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
16519 2003-11-08 Martin Baulig <martin@ximian.com>
16521 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
16522 TypeManager.ResolveExpressionTypes().
16524 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
16525 instead of an Expression.
16526 (TypeExpr): This is now an abstract base class for `TypeExpression'.
16527 (TypeExpression): New public class; formerly known as `TypeExpr'.
16529 * expression.cs (ComposedCast): Derive from TypeExpr.
16531 * typemanager.cs (TypeManager.system_*_expr): These are now
16532 TypExpr's instead of Expression's.
16533 (TypeManager.ResolveExpressionTypes): New public static function;
16534 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
16537 2003-11-06 Miguel de Icaza <miguel@ximian.com>
16539 * expression.cs (New.DoResolve): Do not dereference value that
16540 might be a null return.
16542 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
16543 sure that the constant value has the right type. Fixes an
16544 unreported bug, similar to 50425.
16546 * const.cs (Const.LookupConstantValue): Call
16547 ImplicitStandardConversionExists before doing a conversion to
16548 avoid havng the TypeManager.ChangeType do conversions.
16550 Reduced the number of casts used
16552 (Const.ChangeType): New routine to enable reuse of the constant
16553 type changing code from statement.
16555 * typemanager.cs (ChangeType): Move common initialization to
16556 static global variables.
16560 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
16561 every value type to go through, even if it was void. Fix that.
16563 * cs-tokenizer.cs: Use is_identifier_start_character on the start
16564 character of the define, and the is_identifier_part_character for
16565 the rest of the string.
16567 2003-11-05 Miguel de Icaza <miguel@ximian.com>
16569 * expression.cs (UnaryMutator.EmitCode): When I updated
16570 LocalVariableReference.DoResolve, I overdid it, and dropped an
16571 optimization done on local variable references.
16573 2003-11-04 Miguel de Icaza <miguel@ximian.com>
16575 * ecore.cs: Convert the return from Ldlen into an int.
16577 2003-10-20 Miguel de Icaza <miguel@ximian.com>
16579 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
16580 the accessibility, this is a special case for toplevel non-public
16581 classes (internal for instance).
16583 2003-10-20 Nick Drochak <ndrochak@gol.com>
16585 * ecore.cs: Fix typo and build. Needed another right paren.
16587 2003-10-19 Miguel de Icaza <miguel@ximian.com>
16589 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
16590 `internal' case regular and protected, but not allowing protected
16591 to be evaluated later. Bug 49840
16593 2003-10-15 Miguel de Icaza <miguel@ximian.com>
16595 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
16596 to kb.Nlast, and not the kb.nFirst to isolate the switch
16599 Extract the underlying type, so enumerations of long/ulong are
16600 treated like long/ulong.
16602 2003-10-14 Miguel de Icaza <miguel@ximian.com>
16604 * expression.cs (New): Overload the meaning of RequestedType to
16605 track the possible creation of the NewDelegate type, since
16606 DoResolve is invoked more than once for new constructors on field
16609 See bugs: #48800 and #37014
16611 * cs-parser.jay (declare_local_constants): Take an arraylist
16612 instead of a single constant.
16614 (local_constant_declaration): It should take a
16615 constant_declarators, not a constant_declarator. Fixes 49487
16617 * convert.cs: Fix error report.
16619 2003-10-13 Jackson Harper <jackson@ximian.com>
16621 * typemanager.cs (TypeToCoreType): Add float and double this fixes
16624 2003-10-09 Martin Baulig <martin@ximian.com>
16626 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
16628 (MethodCore.DoDefineParameters): Removed the TypeContainer
16629 argument; use the DeclSpace which was passed to the .ctor instead.
16630 (MethodCore.CheckParameter): Take a DeclSpace instead of a
16631 TypeContainer; we only need a DeclSpace here.
16633 2003-10-09 Martin Baulig <martin@ximian.com>
16635 * class.cs (MethodData): Added additional `DeclSpace ds' argument
16637 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
16638 EmitContext's .ctor.
16640 2003-10-09 Martin Baulig <martin@ximian.com>
16642 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
16643 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
16644 AsAccessible(), moved them as well.
16646 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
16648 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
16650 * cs-parser.jay : Renamed yyName to yyNames related to jay.
16652 2003-10-07 Miguel de Icaza <miguel@ximian.com>
16654 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
16655 generation for >=, as spotted by Paolo, bug 48679.
16656 Patch from David Waite.
16658 * cs-tokenizer.cs: Add handling for #pragma.
16660 * cs-parser.jay: Allow for both yield and yield return in the
16661 syntax. The anti-cobolization of C# fight will go on!
16663 * class.cs (TypeBuilder.DefineType): Catch error condition here
16664 (Parent.DefineType erroring out and returning null).
16666 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16667 coping with enumerations variables, we were mistakenly processing
16668 them as a regular value type instead of built-in types. Fixes the
16671 * typemanager.cs (IsBuiltinOrEnum): New method.
16673 2003-09-30 Miguel de Icaza <miguel@ximian.com>
16675 * cs-parser.jay: Upgrade: yield now needs the return clause.
16677 2003-09-19 Martin Baulig <martin@ximian.com>
16679 * decl.cs (MemberCache.SetupCacheForInterface): Take a
16680 `MemberCache parent' argument. Normally, an interface doesn't
16681 have a parent type except System.Object, but we use this in gmcs
16682 for generic type parameters.
16684 2003-09-18 Martin Baulig <martin@ximian.com>
16686 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
16687 on `type.IsInterface'; don't check whether the type has a parent
16688 to determine whether it's an interface.
16690 2003-09-15 Martin Baulig <martin@ximian.com>
16692 * class.cs (TypeContainer.DefineType): Added an error flag to
16693 avoid reporting duplicate CS0146's ("class definition is
16696 * driver.cs (Driver.MainDriver): Abort if
16697 RootContext.ResolveTree() reported any errors.
16699 2003-09-07 Martin Baulig <martin@ximian.com>
16701 * report.cs (Error, Warning): Added overloaded versions which take
16702 a `params object[] args' and call String.Format().
16704 2003-09-07 Martin Baulig <martin@ximian.com>
16706 * decl.cs (DeclSpace..ctor): Don't call
16707 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
16708 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
16709 (DeclSpace.RecordDecl): New method.
16711 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
16713 2003-09-02 Ravi Pratap <ravi@ximian.com>
16715 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
16716 value attributes to be applied to ParameterBuilders.
16718 * class.cs (MethodCore.LabelParameters): Make static and more
16719 generic so that it can be used from other places - like interface
16720 methods, for instance.
16722 * interface.cs (Interface.Emit): Call LabelParameters before
16723 emitting attributes on the InterfaceMethod.
16725 2003-08-26 Martin Baulig <martin@ximian.com>
16727 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
16728 resolving aliases; fixes #47927.
16730 2003-08-26 Martin Baulig <martin@ximian.com>
16732 * statement.cs (Using.DoResolve): This is internally emitting a
16733 try/finally clause, so we need to set ec.NeedExplicitReturn if we
16734 do not always return. Fixes #47681.
16736 2003-08-26 Martin Baulig <martin@ximian.com>
16738 * decl.cs (MemberCore): Moved WarningNotHiding(),
16739 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
16741 (AdditionResult): Make this nested in DeclSpace.
16742 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
16743 argument; call NamespaceEntry.Define() unless we're nested in a
16746 * namespace.cs (Namespace.DefineName): New public function. This
16747 is called from DeclSpace's .ctor to add
16748 (Namespace.Lookup): Include DeclSpaces in the lookup.
16750 * class.cs (Operator): Derive from MemberBase, not MemberCore.
16752 * const.cs (Const): Derive from MemberBase, not MemberCore.
16754 2003-08-25 Martin Baulig <martin@ximian.com>
16756 * convert.cs (Convert.ExplicitReferenceConversion): When
16757 converting from an interface type to a class, unbox if the target
16758 type is a struct type. Fixes #47822.
16760 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16762 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
16765 2003-08-22 Martin Baulig <martin@ximian.com>
16767 * class.cs (TypeManager.DefineType): When defining a nested type,
16768 call DefineType() on our parent; fixes #47801.
16770 2003-08-22 Martin Baulig <martin@ximian.com>
16772 * class.cs (MethodData.Define): While checking if a method is an
16773 interface implementation, improve the test a bit more to fix #47654.
16775 2003-08-22 Martin Baulig <martin@ximian.com>
16777 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
16778 correctly; fixes #47722.
16780 2003-08-22 Martin Baulig <martin@ximian.com>
16782 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
16783 LocalVariableReference, ensure it's not read-only. Fixes #47536.
16785 * statement.cs (Fixed.DoResolve): Make all variables read-only.
16787 2003-08-22 Martin Baulig <martin@ximian.com>
16789 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
16790 can only be assigned in static constructors. Fixes #47161.
16792 2003-08-22 Martin Baulig <martin@ximian.com>
16794 Rewrote and improved the flow analysis code.
16796 * flowbranching.cs (FlowBranching): Make this class abstract.
16797 (FlowBranching.CreateBranching): New static function to create a
16798 new flow branching.
16799 (FlowBranchingBlock, FlowBranchingException): New classes.
16800 (FlowBranching.UsageVector.Type): New public readonly field.
16801 (FlowBranching.UsageVector.Breaks): Removed the setter.
16802 (FlowBranching.UsageVector.Returns): Removed the setter.
16803 (FlowBranching.UsageVector): Added Break(), Return(),
16804 NeverReachable() and Throw() methods to modify the reachability.
16805 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
16806 done by FlowBranching.Merge().
16807 (FlowBranching.UsageVector.MergeChild): New method; merges the
16808 merge result into the current vector.
16809 (FlowBranching.Merge): New abstract method to merge a branching.
16811 2003-08-12 Martin Baulig <martin@ximian.com>
16813 * expression.cs (Indirection.CacheTemporaries): Create the
16814 LocalTemporary with the pointer type, not its element type.
16816 2003-08-10 Miguel de Icaza <miguel@ximian.com>
16818 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
16819 token was a keyword or not.
16821 Add `error' options where an IDENTIFIER was expected; Provide
16822 CheckToken and CheckIdentifierToken convenience error reporting
16825 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
16827 * decl.cs: Rename `NamespaceEntry Namespace' public field into
16828 NameSpaceEntry NameSpaceEntry.
16830 (LookupInterfaceOrClass): Avoid creating a full qualified name
16831 from namespace and name: avoid doing lookups when we know the
16832 namespace is non-existant. Use new Tree.LookupByNamespace which
16833 looks up DeclSpaces based on their namespace, name pair.
16835 * driver.cs: Provide a new `parser verbose' to display the
16836 exception thrown during parsing. This is turned off by default
16837 now, so the output of a failure from mcs is more graceful.
16839 * namespace.cs: Track all the namespaces defined in a hashtable
16842 (IsNamespace): New method
16844 2003-08-09 Miguel de Icaza <miguel@ximian.com>
16846 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
16847 we know that we need to concatenate (full typename can never be
16852 * statement.cs: Use a bitfield; Do not initialize to null things
16853 which are done by the constructor by default.
16855 * cs-parser.jay: bug fix, parameter was 4, not 3.
16857 * expression.cs: Just use the property;
16859 * statement.cs: No need for GetVariableInfo method.
16861 2003-08-08 Martin Baulig <martin@ximian.com>
16863 * flowanalysis.cs (FlowReturns): This is now nested in the
16864 `FlowBranching' class.
16865 (MyBitVector): Moved this here from statement.cs.
16866 (FlowBranching.SiblingType): New enum type.
16867 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16869 2003-08-07 Martin Baulig <martin@ximian.com>
16871 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16872 `FlowBranching' class and called `BranchingType'.
16874 2003-08-07 Martin Baulig <martin@ximian.com>
16876 * flowanalysis.cs: Moved all the control flow analysis code into
16879 2003-08-07 Martin Baulig <martin@ximian.com>
16881 * assign.cs (Assign.DoResolve): `target' must either be an
16882 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16885 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16887 * expression.cs (BinaryMethod): This kind of expression is created by the
16888 Binary class if it determines that the operator has to be handled
16891 (BinaryDelegate): This kind of expression is created if we are
16892 dealing with a + or - operator on delegates.
16894 (Binary): remove method, argumetns, and DelegateOperator: when
16895 dealing with methods,
16897 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16899 * statement.cs (Block): use bitfields for the three extra booleans
16900 we had in use. Remove unused topblock parameter.
16902 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16904 * assign.cs: Drop extra unneeded tests.
16906 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16908 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16910 * statement.cs (Foreach): Use VariableStorage instead of
16913 * codegen.cs (VariableStorage): New class used by clients that
16914 require a variable stored: locals or fields for variables that
16915 need to live across yield.
16917 Maybe provide a convenience api for EmitThis+EmitLoad?
16919 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16922 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16924 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16925 RemapParameterLValue): New methods that are used to turn a
16926 precomputed FieldInfo into an expression like this:
16930 The idea is to use this instead of making LocalVariableReference
16931 have more than one meaning.
16933 * cs-parser.jay: Add error production to BASE.
16935 * ecore.cs: Deal with TypeManager.GetField returning null, which
16936 is now a valid return value.
16938 (FieldExprNoAddress): New expression for Fields whose address can
16941 * expression.cs (LocalVariableReference): During the resolve
16942 phases, create new expressions if we are in a remapping context.
16943 Remove code that dealt with remapping here.
16945 (ParameterReference): same.
16947 (ProxyInstance): New expression, like the `This' expression, but
16948 it is born fully resolved. We know what we are doing, so remove
16949 the errors that are targeted to user-provided uses of `this'.
16951 * statement.cs (Foreach): our variable is now stored as an
16952 Expression; During resolution, follow the protocol, dont just
16953 assume it will return this.
16955 2003-08-06 Martin Baulig <martin@ximian.com>
16957 * support.cs (SeekableStreamReader.cs): New public class.
16959 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16960 SeekableStreamReader instead of the normal StreamReader.
16962 2003-08-04 Martin Baulig <martin@ximian.com>
16964 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16965 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16966 deambiguate casts and delegate invocations.
16967 (parenthesized_expression): Use the new tokens to ensure this is
16968 not a cast of method invocation.
16970 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16971 when reading a `)' and Deambiguate_CloseParens () was previously
16974 * expression.cs (ParenthesizedExpression): New class. This is
16975 just used for the CS0075 test.
16976 (Binary.DoResolve): Check for CS0075.
16978 2003-07-29 Ravi Pratap <ravi@ximian.com>
16980 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
16981 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
16982 reference comparison.
16984 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
16985 examine the ReturnType for equality - this is necessary in the
16986 cases of implicit and explicit operators whose signature also
16987 includes the return type.
16989 2003-07-26 Miguel de Icaza <miguel@ximian.com>
16991 * namespace.cs: Cache the result of the namespace computation,
16992 instead of computing it every time.
16994 2003-07-24 Miguel de Icaza <miguel@ximian.com>
16996 * decl.cs: Use a global arraylist that we reuse over invocations
16997 to avoid excesive memory consumption. Reduces memory usage on an
16998 mcs compile by one meg (45 average).
17000 * typemanager.cs (LookupTypeReflection): In .NET pointers are
17001 private, work around that.
17003 2003-07-23 Miguel de Icaza <miguel@ximian.com>
17005 * literal.cs (IntLiteral): Define Zero and One static literals.
17007 * cs-parser.jay (integer_literal): use static literals to reduce
17008 memory usage for the most used literals (0, 1 and -1). 211kb
17009 reduced in memory usage.
17011 Replace all calls to `new ArrayList' with `new
17012 ArrayList(4)' which is a good average number for most allocations,
17013 and also requires only 16 bytes of memory for its buffer by
17016 This reduced MCS memory usage in seven megabytes for the RSS after
17019 2003-07-28 Ravi Pratap <ravi@ximian.com>
17021 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
17022 handle params methods the correct way by forming only one
17023 applicable set with params and normal methods in them. Earlier we
17024 were looking at params methods only if we found no normal methods
17025 which was not the correct thing to do.
17027 (Invocation.BetterFunction): Take separate arguments indicating
17028 when candidate and the best method are params methods in their
17031 This fixes bugs #43367 and #46199.
17033 * attribute.cs: Documentation updates.
17035 (CheckAttribute): Rename to CheckAttributeTarget.
17036 (GetValidPlaces): Rename to GetValidTargets.
17038 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
17039 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
17043 2003-07-28 Martin Baulig <martin@ximian.com>
17045 * class.cs (TypeContainer.DefineMembers): Use the base type's full
17046 name when looking up the base class of a nested class. Fixes #46977.
17048 2003-07-26 Martin Baulig <martin@ximian.com>
17050 * expression.cs (Indexers.Indexer): New nested struct; contains
17051 getter, setter and the indexer's type.
17052 (Indexers.Properties): This is now an ArrayList of
17053 Indexers.Indexer's.
17054 (IndexerAccess.DoResolveLValue): Correctly set the type if the
17055 indexer doesn't have any getters.
17057 * assign.cs (Assign.DoResolve): Also do the implicit conversions
17058 for embedded property and indexer assignments.
17060 2003-07-26 Martin Baulig <martin@ximian.com>
17062 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
17063 preprocessor directive is not the first non-whitespace character
17066 2003-07-26 Martin Baulig <martin@ximian.com>
17068 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
17069 namespace parsing, follow the spec more closely.
17071 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
17072 NamespaceEntry.Lookup().
17074 2003-07-25 Martin Baulig <martin@ximian.com>
17076 * MethodCore.cs (OverridesSomething): New public field; it's set
17077 from TypeContainer.DefineMembers if this method overrides
17078 something (which doesn't need to be a method). Fix #39462.
17080 2003-07-25 Ravi Pratap <ravi@ximian.com>
17082 * typemanager.cs (GetMembers): Ensure that the list of members is
17083 reversed. This keeps things in sync.
17085 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
17086 find an AttributeUsage attribute.
17088 * expression.cs (Invocation.OverloadResolve): Perform the check
17089 which disallows Invoke to be directly called on a Delegate.
17091 (Error_InvokeOnDelegate): Report error cs1533.
17093 2003-07-25 Martin Baulig <martin@ximian.com>
17095 * expression.cs (Indexers.GetIndexersForType): Only look in the
17096 interface hierarchy if the requested type is already an
17097 interface. Fixes #46788 while keeping #46502 fixed.
17099 2003-07-25 Martin Baulig <martin@ximian.com>
17101 * class.cs (TypeContainer.DefineMembers): Check whether all
17102 readonly fields have been assigned and report warning CS0649 if
17105 * statement.cs (LocalInfo.IsFixed): Always return true if this is
17108 2003-07-24 Ravi Pratap <ravi@ximian.com>
17110 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
17111 returned from GetMethods to make things consistent with the
17112 assumptions MCS makes about ordering of methods.
17114 This should comprehensively fix bug #45127 and it does :-)
17116 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
17117 ordering is actually reverse.
17119 * Clean up some debug messages I left lying around.
17121 * interface.cs (Populate*): Get rid of code which emits attributes
17122 since the stage in which we emit attributes is the 'Emit' stage,
17123 not the define stage.
17125 (Emit): Move attribute emission for interface members here.
17127 2003-07-22 Ravi Pratap <ravi@ximian.com>
17129 * expression.cs (Invocation.OverloadResolve): Follow the spec more
17130 closely: we eliminate methods in base types when we have an
17131 applicable method in a top-level type.
17133 Please see section 14.5.5.1 for an exact description of what goes
17136 This fixes bug #45127 and a host of other related to corlib compilation.
17138 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
17139 array is the method corresponding to the top-level type (this is
17140 because of the changes made to icall.c) so we change this
17143 (MethodGroupExpr.Name): This too.
17145 * typemanager.cs (GetElementType): New method which does the right
17146 thing when compiling corlib.
17148 * everywhere: Make use of the above in the relevant places.
17150 2003-07-22 Martin Baulig <martin@ximian.com>
17152 * cs-parser.jay (invocation_expression): Moved
17153 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
17154 `cast_expression', but create a InvocationOrCast which later
17155 resolves to either an Invocation or a Cast.
17157 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
17158 method; call this before EmitStatement() to make sure that this
17159 expression can be used as a statement.
17161 * expression.cs (InvocationOrCast): New class; resolves to either
17162 an Invocation or a Cast.
17164 * statement.cs (StatementExpression): Call ResolveStatement() on
17165 the ExpressionStatement before emitting it.
17167 2003-07-21 Martin Baulig <martin@ximian.com>
17169 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
17170 `ref' and `out' attributes match; fixes #46220.
17171 (MemberAccess.ResolveMemberAccess): You can't reference a type
17172 through an expression; fixes #33180.
17173 (Indexers.GetIndexersForType): Don't return the indexers from
17174 interfaces the class implements; fixes #46502.
17176 2003-07-21 Martin Baulig <martin@ximian.com>
17178 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
17179 CS0661 checks; fixes bug #30442.
17181 2003-07-21 Martin Baulig <martin@ximian.com>
17183 * decl.cs (AdditionResult): Added `Error'.
17185 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
17187 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
17188 makes cs0031.cs actually work.
17190 2003-07-20 Martin Baulig <martin@ximian.com>
17192 * namespace.cs: Fixed that bug which caused a crash when compiling
17193 the debugger's GUI.
17195 2003-07-20 Miguel de Icaza <miguel@ximian.com>
17197 * typemanager.cs (LookupTypeReflection): Never expose types which
17198 are NotPublic, NestedPrivate, NestedAssembly, or
17199 NestedFamANDAssem. We used to return these, and later do a check
17200 that would report a meaningful error, but the problem is that we
17201 would not get the real match, if there was a name override.
17203 2003-07-18 Miguel de Icaza <miguel@ximian.com>
17205 * namespace.cs (Namespace, Name): Do not compute the namespace
17206 name dynamically, compute it in the constructor. This reduced
17207 memory usage by 1697 KB.
17209 * driver.cs: Use --pause to pause at the end.
17211 2003-07-17 Peter Williams <peter@newton.cx>
17213 * Makefile: Change the name of the test target so that it doesn't
17214 conflict with the recursive test target.
17216 2003-07-17 Miguel de Icaza <miguel@ximian.com>
17218 * expression.cs (LocalVariableReference.Emit, EmitAssign,
17219 AddressOf): Do not use EmitThis, that was wrong, use the actual
17222 2003-07-15 Miguel de Icaza <miguel@ximian.com>
17224 * class.cs (MethodData.Define): While checking if a method is an
17225 interface implementation, improve the test: If we are not public
17226 (use new test here: use the computed MethodAttributes directly,
17227 instead of the parsed modifier flags) check if the `implementing'
17228 method comes from an interface or not.
17230 * pending.cs (VerifyPendingMethods): Slightly better error
17233 * makefile: add test target that does the mcs bootstrap.
17235 2003-07-16 Ravi Pratap <ravi@ximian.com>
17237 * interface.cs (Define): Do nothing here since there are no
17238 members to populate etc. Move the attribute emission out of here
17239 since this was just totally the wrong place to put it. Attribute
17240 application happens during the 'Emit' phase, not in the 'Define'
17243 (Emit): Add this method and move the attribute emission here
17245 * rootcontext.cs (EmitCode): Call the Emit method on interface
17248 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17250 * expression.cs (OverloadResolve): Report error only if Location
17251 is not 'Null' which means that there was a probe going on.
17253 2003-07-14 Martin Baulig <martin@ximian.com>
17255 * expression.cs (ConditionalLogicalOperator): New public class to
17256 implement user defined conditional logical operators.
17257 This is section 14.11.2 in the spec and bug #40505.
17259 2003-07-14 Martin Baulig <martin@ximian.com>
17261 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
17263 2003-07-14 Martin Baulig <martin@ximian.com>
17265 * codegen.cs (EmitContext.InFixedInitializer): New public field.
17267 * ecore.cs (IVariable.VerifyFixed): New interface method.
17269 * expression.cs (Unary.ResolveOperator): When resolving the `&'
17270 operator, check whether the variable is actually fixed. Fixes bug
17271 #36055. Set a variable definitely assigned when taking its
17272 address as required by the spec.
17274 * statement.cs (LocalInfo.IsFixed): New field.
17275 (LocalInfo.MakePinned): Set `IsFixed' to true.
17277 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17279 * attribute.cs (Attribute.Resolve): While doing a Member lookup
17280 for .ctors, ensure that we only ask for members declared in the
17281 attribute type (BindingFlags.DeclaredOnly).
17285 * expression.cs (Error_WrongNumArguments): Report error 1501
17286 correctly the way CSC does.
17288 2003-07-13 Martin Baulig <martin@ximian.com>
17290 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
17291 lookup on the fully qualified name, to make things like "X.X" work
17292 where "X.X" is a fully qualified type name, but we also have a
17293 namespace "X" in the using list. Fixes #41975.
17295 2003-07-13 Martin Baulig <martin@ximian.com>
17297 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
17298 function. If we're a CompoundAssign, we need to create an embedded
17299 CompoundAssign, not an embedded Assign.
17300 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
17303 2003-07-13 Martin Baulig <martin@ximian.com>
17305 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
17306 work to fix bug #46088.
17308 2003-07-13 Ravi Pratap <ravi@ximian.com>
17310 * class.cs (Operator.Emit): Do not emit attributes here - it is
17311 taken care of by the Method class that we delegate too. This takes
17312 care of bug #45876.
17314 2003-07-10 Martin Baulig <martin@ximian.com>
17316 * expression.cs (TypeOfVoid): New class.
17317 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
17319 2003-07-10 Martin Baulig <martin@ximian.com>
17321 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
17324 2003-07-10 Martin Baulig <martin@ximian.com>
17326 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
17327 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
17329 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
17331 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
17333 2003-07-10 Martin Baulig <martin@ximian.com>
17335 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
17336 of decimal. Fixes #42850.
17338 NOTE: I also fixed the created byte blob, but this doesn't work on
17339 the MS runtime and csc never produces any byte blobs for decimal
17342 2003-07-10 Martin Baulig <martin@ximian.com>
17344 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
17345 structs; fixes #32068.
17346 (Block.AddChildVariableNames): Fixed #44302.
17348 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17350 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
17352 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17354 * attribute.cs: And this test is onger needed.
17356 2003-07-08 Martin Baulig <martin@ximian.com>
17358 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
17359 inaccessible types. Fixes #36313.
17361 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
17363 * namespace.cs (NamespaceEntry): Create implicit entries for all
17364 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
17365 implicit entries for N1.N2 and N1.
17367 2003-07-08 Martin Baulig <martin@ximian.com>
17369 Rewrote the handling of namespaces to fix a lot of the issues
17370 wrt. `using' aliases etc.
17372 * namespace.cs (Namespace): Splitted this class into a
17373 per-assembly `Namespace' and a per-file `NamespaceEntry'.
17375 * typemanager.cs (TypeManager.IsNamespace): Removed.
17376 (TypeManager.ComputeNamespaces): Only compute namespaces from
17377 loaded assemblies here, not the namespaces from the assembly we're
17378 currently compiling.
17380 2003-07-08 Martin Baulig <martin@ximian.com>
17382 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
17384 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17386 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
17389 I thought about the memory savings here, but LookupTypeReflection
17390 is used under already very constrained scenarios. Compiling
17391 corlib or mcs only exposes one hit, so it would not really reduce
17392 any memory consumption.
17394 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17396 * typemanager.cs: fixes bug #45889 by only adding public types from
17397 other assemblies to the list of known types.
17399 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17401 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
17402 on the type we resolved.
17404 2003-07-05 Martin Baulig <martin@ximian.com>
17406 * pending.cs (PendingImplementation.ParentImplements): Don't
17407 create the proxy if the parent is abstract.
17409 * class.cs (TypeContainer.DefineIndexers): Process explicit
17410 interface implementations first. Fixes #37714.
17412 2003-07-04 Miguel de Icaza <miguel@ximian.com>
17414 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
17415 defined recursively; but since we modify the input parameters
17416 (left is set to `this' temporarily), we reset this value if the
17417 left_is_explicit is false, which gives the original semantics to
17420 * literal.cs (NullPointer): new class used to represent a null
17421 literal in a pointer context.
17423 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
17424 type is a pointer, use a NullPointer object instead of a
17425 NullLiteral. Closes 43687
17427 (ExplicitConversion): Convert pointer values using
17428 the conv opcode to the proper type.
17430 * ecore.cs (New): change ValueTypeVariable property into a method,
17431 that returns whether the valuetype is suitable for being used.
17433 * expression.cs (Binary.DoNumericPromotions): Only return if we
17434 the int constant was a valid uint, and we can return both left and
17435 right as uints. If not, we continue processing, to trigger the
17436 type conversion. This fixes 39018.
17438 * statement.cs (Block.EmitMeta): During constant resolution, set
17439 the CurrentBlock property on the emitcontext, so that we resolve
17440 constants propertly.
17442 2003-07-02 Martin Baulig <martin@ximian.com>
17444 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
17445 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
17447 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
17448 than emitting it here.
17450 * statement.cs: Fixed some more flow analysis bugs.
17452 2003-07-02 Martin Baulig <martin@ximian.com>
17454 * class.cs (MethodData.Define): When implementing interface
17455 methods, set Final unless we're Virtual.
17457 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
17458 check work for interface methods.
17460 2003-07-01 Martin Baulig <martin@ximian.com>
17462 * ecore.cs (EmitContext.This): Replaced this property with a
17463 GetThis() method which takes a Location argument. This ensures
17464 that we get the correct error location for a CS0188.
17466 2003-07-01 Miguel de Icaza <miguel@ximian.com>
17468 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
17469 ImplicitStandardConversion.
17471 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
17473 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
17475 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
17478 2003-06-30 Miguel de Icaza <miguel@ximian.com>
17480 * class.cs (Constructor.Define): Turn off initlocals for unsafe
17483 (MethodData.Define): Turn off initlocals for unsafe methods.
17485 2003-06-29 Miguel de Icaza <miguel@ximian.com>
17487 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
17488 complete; Fixes #37521.
17490 * delegate.cs: Use Modifiers.TypeAttr to compute the
17491 TypeAttributes, instead of rolling our own. This makes the flags
17492 correct for the delegates.
17494 2003-06-28 Miguel de Icaza <miguel@ximian.com>
17496 * class.cs (Constructor.Define): Set the private flag for static
17497 constructors as well.
17499 * cs-parser.jay (statement_expression): Set the return value to
17500 null, to avoid a crash when we catch an error.
17502 2003-06-24 Miguel de Icaza <miguel@ximian.com>
17504 * cs-parser.jay: Applied patch from Jackson that adds support for
17505 extern and unsafe modifiers to destructor declarations.
17507 * expression.cs: Report error 21 if the user is trying to index a
17510 * driver.cs: Add an error message, suggested by the bug report.
17512 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
17513 if we do not have a ": this ()" constructor initializer. Fixes 45149
17515 2003-06-14 Miguel de Icaza <miguel@ximian.com>
17517 * namespace.cs: Add some information to reduce FAQs.
17519 2003-06-13 Miguel de Icaza <miguel@ximian.com>
17521 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
17522 underlying enumeration types. Fixes #43915.
17524 * expression.cs: Treat ushort/short as legal values to be used in
17525 bitwise operations.
17527 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
17529 * delegate.cs: transfer custom attributes for paramenters from
17530 the delegate declaration to Invoke and BeginInvoke.
17532 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
17534 * attribute.cs: handle custom marshalers and emit marshal info
17537 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
17539 * makefile.gnu: Added anonymous.cs to the compiler sources.
17541 2003-05-28 Miguel de Icaza <miguel@ximian.com>
17543 * iterators.cs: Change the name of the proxy class to include two
17546 * cs-parser.jay: Update grammar to include anonymous methods.
17548 * anonymous.cs: new file.
17550 2003-05-27 Miguel de Icaza <miguel@ximian.com>
17552 * class.cs (Field.Define): Add missing test for pointers and
17555 2003-05-27 Ravi Pratap <ravi@ximian.com>
17557 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
17558 we use the stobj opcode.
17560 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
17561 since it wasn't the correct fix.
17563 It still is puzzling that we are required to use stobj for IntPtr
17564 which seems to be a ValueType.
17566 2003-05-26 Miguel de Icaza <miguel@ximian.com>
17568 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
17569 during regular simple name resolution. Now, the trick is that
17570 instead of returning for processing the simplename, we do a
17571 TypeManager.LookupType (ie, a rooted lookup as opposed to a
17572 contextual lookup type). If a match is found, return that, if
17573 not, return for further composition.
17575 This fixes long-standing 30485.
17577 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
17578 using the address to initialize an object, do an Stobj instead of
17579 using the regular Stelem.
17581 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
17582 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
17583 Because if we are a BaseIndexerAccess that value will be true.
17586 * statement.cs (GotoCase.Resolve): Return after reporting an
17587 error, do not attempt to continue.
17589 * expression.cs (PointerArithmetic.Emit): If our operand is a
17590 long, convert our constants to match the operand before
17591 multiplying. Convert to I type before adding. Fixes 43670.
17593 2003-05-14 Ravi Pratap <ravi@ximian.com>
17595 * enum.cs (ImplicitConversionExists) : Rename to
17596 ImplicitEnumConversionExists to remove ambiguity.
17598 * ecore.cs (NullCast): New type of cast expression class which
17599 basically is very similar to EmptyCast with the difference being
17600 it still is a constant since it is used only to cast a null to
17602 (eg. (string) null)
17604 * convert.cs (ImplicitReferenceConversion): When casting a null
17605 literal, we return a NullCast.
17607 * literal.cs (NullLiteralTyped): Remove - I don't see why this
17608 should be around anymore.
17610 The renaming (reported was slightly wrong). Corrections:
17612 ConvertImplicitStandard -> ImplicitConversionStandard
17613 ConvertExplicitStandard -> ExplicitConversionStandard
17615 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
17616 before passing them in !
17618 * convert.cs (ImplicitConversionStandard): When comparing for
17619 equal expr and target types, ensure that expr is not a
17622 In general, we must not be checking (expr_type ==
17623 target_type) in the top level conversion methods
17624 (ImplicitConversion, ExplicitConversion etc). This checking is
17625 done in the methods that they delegate to.
17627 2003-05-20 Miguel de Icaza <miguel@ximian.com>
17629 * convert.cs: Move Error_CannotConvertType,
17630 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
17631 ImplicitNumericConversion, ImplicitConversionExists,
17632 ImplicitUserConversionExists, StandardConversionExists,
17633 FindMostEncompassedType, FindMostSpecificSource,
17634 FindMostSpecificTarget, ImplicitUserConversion,
17635 ExplicitUserConversion, GetConversionOperators,
17636 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
17637 TryImplicitIntConversion, Error_CannotConvertImplicit,
17638 ConvertImplicitRequired, ConvertNumericExplicit,
17639 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
17640 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
17643 Perform the following renames:
17645 StandardConversionExists -> ImplicitStandardConversionExists
17646 ConvertImplicit -> ImplicitConversion
17647 ConvertImplicitStandard -> ImplicitStandardConversion
17648 TryImplicitIntConversion -> ImplicitIntConversion
17649 ConvertImplicitRequired -> ImplicitConversionRequired
17650 ConvertNumericExplicit -> ExplicitNumericConversion
17651 ConvertReferenceExplicit -> ExplicitReferenceConversion
17652 ConvertExplicit -> ExplicitConversion
17653 ConvertExplicitStandard -> ExplicitStandardConversion
17655 2003-05-19 Martin Baulig <martin@ximian.com>
17657 * statement.cs (TypeInfo.StructInfo): Made this type protected.
17658 (TypeInfo): Added support for structs having structs as fields.
17660 * ecore.cs (FieldExpr): Implement IVariable.
17661 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
17662 VariableInfo for the field.
17664 2003-05-18 Martin Baulig <martin@ximian.com>
17666 * expression.cs (This.DoResolve): Report a CS0027 if we're
17667 emitting a field initializer.
17669 2003-05-18 Martin Baulig <martin@ximian.com>
17671 * expression.cs (This.ResolveBase): New public function.
17672 (This.DoResolve): Check for CS0188.
17674 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
17677 * ecore.cs (MethodGroupExpr.DoResolve): Set the
17678 `instance_expression' to null if we don't have any non-static
17681 2003-05-18 Martin Baulig <martin@ximian.com>
17683 Reworked the way how local variables and parameters are handled by
17684 the flow analysis code.
17686 * statement.cs (TypeInfo, VariableMap): New public classes.
17687 (VariableInfo): New public class. This is now responsible for
17688 checking whether a variable has been assigned. It is used for
17689 parameters and local variables.
17690 (Block.EmitMeta): Take the InternalParameters as argument; compute
17691 the layout of the flow vectors here.
17692 (Block.LocalMap, Block.ParameterMap): New public properties.
17693 (FlowBranching): The .ctor doesn't get the InternalParameters
17694 anymore since Block.EmitMeta() now computes the layout of the flow
17696 (MyStructInfo): This class is now known as `StructInfo' and nested
17697 in `TypeInfo'; we don't access this directly anymore.
17699 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
17700 property and removed IsAssigned(), IsFieldAssigned(),
17701 SetAssigned() and SetFieldAssigned(); we now call them on the
17702 VariableInfo so we don't need to duplicate this code everywhere.
17704 * expression.cs (ParameterReference): Added `Block block' argument
17706 (LocalVariableReference, ParameterReference, This): The new
17707 VariableInfo class is now responsible for all the definite
17710 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
17711 IsParameterAssigned, SetParameterAssigned): Removed.
17713 2003-05-18 Martin Baulig <martin@ximian.com>
17715 * typemanager.cs (InitCoreTypes): Try calling
17716 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
17717 the 3-args-version. Corlib now also needs our `void_type'.
17718 (GetMethod): Added overloaded version which takes an optional
17719 `bool report_errors' to allow lookups of optional methods.
17721 2003-05-12 Martin Baulig <martin@ximian.com>
17723 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
17724 only used for locals and not for parameters.
17726 2003-05-12 Miguel de Icaza <miguel@ximian.com>
17728 * support.cs (InternalParameters.ParameterType): Return the
17729 ExternalType of the parameter.
17731 * parameter.cs (Parameter.ExternalType): drop the two arguments,
17734 2003-05-11 Miguel de Icaza <miguel@ximian.com>
17736 * class.cs (MethodData.Define): Do not set the `newslot' on
17737 interface members, if they are also flagged as "override".
17739 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
17740 better code for ++i and i++. This only works for static fields
17741 and local variables.
17743 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
17744 want to pull the DeclSpace out of the builder_to_declspace instead
17745 of the TypeBuilder (like in TypeContainer.FindMembers).
17747 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
17748 instead of LookupTypeContainer. Fixes the crash on .NET for
17749 looking up interface members.
17751 * const.cs: Create our own emit context during the Definition
17752 stage, so that constants are evaluated in the proper context, when
17753 a recursive definition happens.
17755 2003-05-11 Martin Baulig <martin@ximian.com>
17757 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
17758 new block for a switch section.
17759 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
17760 the adding/lookup in the switch block. Fixes #39828.
17762 2003-05-09 Miguel de Icaza <miguel@ximian.com>
17764 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
17765 functionality: I needed to convert the data after I had performed
17766 the add/sub operation into the operands type size.
17768 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
17769 pass the type for the box operation, otherwise the resulting
17770 object would have been of type object.
17772 (BoxedCast): Add constructor to specify the type to box as.
17774 2003-05-07 Miguel de Icaza <miguel@ximian.com>
17776 * iterators.cs: I was reusing the `count' variable inadvertently,
17777 take steps to not allow this to happen.
17779 2003-05-06 Miguel de Icaza <miguel@ximian.com>
17781 * attribute.cs (Attribute.Resolve): Params attributes are encoded
17782 by creating an array at the point where the params starts and
17783 putting all those arguments there, then adjusting the size of the
17786 2003-05-05 Miguel de Icaza <miguel@ximian.com>
17788 * expression.cs (New.AddressOf): Implement interface
17789 IMemoryLocation. This is used when the `new' operator is used in
17790 the context of an invocation to a method on a value type.
17792 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
17795 * namespace.cs: Also check the using aliases here.
17797 * driver.cs: Move the test for using validity after the types have
17798 been entered, so we do a single pass that also includes the using
17801 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
17802 in the regular case. CreateSiblingForFinally is doing extra
17805 * attribute.cs (GetAttributeArgumentExpression): Store the result
17806 on an out value, and use the return value to indicate failure
17807 instead of using null (which is a valid return for Constant.GetValue).
17809 * statement.cs: Perform the analysis flow for the increment
17810 portion after the statement, because this will be the real flow of
17811 execution. Fixes #42385
17813 * codegen.cs (EmitContext.EmitArgument,
17814 EmitContext.EmitStoreArgument): New helper functions when the
17815 RemapToProxy flag is set.
17817 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
17820 Add support for remapping parameters.
17822 * iterators.cs: Propagate parameter values; Store parameter
17823 values in the proxy classes.
17825 2003-05-04 Miguel de Icaza <miguel@ximian.com>
17827 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
17828 need a proxy reference; I do not know what I was thinking
17830 * cs-parser.jay (constructor_initializer): catch another error,
17831 and display nice message.
17833 (field_declaration): catch void field declaration
17834 to flag a better error.
17836 * class.cs (MemberBase.CheckBase): Report an error instead of a
17837 warning if a new protected member is declared in a struct.
17838 (Field.Define): catch the error of readonly/volatile.
17840 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
17842 (FieldExpr.AddressOf): ditto. Catch error where the address of a
17843 volatile variable is taken
17845 2003-05-02 Miguel de Icaza <miguel@ximian.com>
17847 * statement.cs (Fixed.Resolve): Report an error if we are not in
17850 2003-05-01 Miguel de Icaza <miguel@ximian.com>
17852 * typemanager.cs: reuse the code that handles type clashes for
17853 delegates and enumerations.
17855 * class.cs (Report28): Always report.
17857 * expression.cs (EncodeAsAttribute): Allow nulls here.
17859 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17861 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17862 the functionality for testing whether an expression is valid for
17863 an attribute here. Also handle the case of arrays of elements
17866 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17867 encoding a linear array into an array of objects that are suitable
17868 to be passed to an CustomAttributeBuilder.
17870 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17872 * ecore.cs: (FieldExpr): Handle field remapping here.
17874 * iteratators.cs: Pass the instance variable (if the method is an
17875 instance method) to the constructors, so we can access the field
17876 variables on the class.
17878 TODO: Test this with structs. I think the THIS variable on
17879 structs might have to be a pointer, and not a refenrece
17881 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17883 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17884 local variables to fields in a proxy class.
17886 * iterators.cs (PopulateProxy): Rename our internal fields to
17888 Create a <THIS> field if we are an instance method, so we can
17889 reference our parent container variables.
17890 (MapVariable): Called back from the EmitContext code to enter a
17891 new variable to field mapping into the proxy class (we just create
17895 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17896 for using the remapped locals to fields.
17898 I placed the code here, because that gives the same semantics to
17899 local variables, and only changes the Emit code.
17901 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17902 statements inside iterators.
17903 (VariableInfo): Add a FieldBuilder for the cases when we are
17904 remapping local variables to fields in a proxy class
17906 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17907 current_block != null.
17909 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17910 not cope with strings, as it has been moved to the
17911 TableSwitchEmit. Fixed bug in switch generation.
17913 * expression.cs (New.DoResolve): Provide more context for the user
17914 when reporting an error.
17916 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17919 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17920 check the permissions for it. Note than in a type-resolution
17921 context the check was already present in DeclSpace.ResolveType,
17922 but was missing from the MemberAccess.
17924 (ArrayCreation.CheckIndices): warn if the user has
17925 more nested levels of expressions, but there are no more
17926 dimensions specified. Avoids crash on bug 41906.
17928 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17930 * statement.cs (Block): replace Implicit bool, for a generic
17932 New flag: `Unchecked'. This is used during the EmitMeta phase
17933 (which is out-of-line with the regular Resolve/Emit process for a
17934 statement, as this is done ahead of time, but still gets a chance
17935 to call constant resolve).
17937 (Block.Flags): new enum for adding a new flag.
17939 (Block.EmitMeta): track the state of unchecked.
17941 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17942 to enable constant resolution to work there as well.
17944 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17946 * typemanager.cs (ienumerable_type): Also look up
17947 System.Collections.IEnumerable.
17949 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17951 TODO: Test more than one conditional per method.
17953 * class.cs (Indexer.Define): Report the location where the user is
17954 referencing the unsupported feature.
17956 (MethodData): Overload the use of `conditionals' to
17957 minimize the creation of needless ArrayLists. This saves roughly
17958 212kb on my machine.
17960 (Method): Implement the new IIteratorContainer interface.
17961 (Method.SetYields): Implement the method by setting the ModFlags
17962 to contain METHOD_YIELDS.
17964 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17965 which just got set to null.
17967 * iterators.cs: New file.
17969 (Yield, YieldBreak): New statements.
17971 * statement.cs (Return.Resolve): Flag an error if we are used in
17972 an iterator method.
17974 * codegen.cs (InIterator): New flag set if the code is being
17975 compiled in an iterator method.
17977 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
17978 internal modifier, and we just use it to avoid adding extra
17979 fields, as this is seldom used.
17981 * cs-parser.jay: Add yield_statement (yield and yield break).
17983 * driver.cs: New flag -v2 to turn on version 2 features.
17985 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
17986 hashtable when v2 is enabled.
17988 2003-04-20 Miguel de Icaza <miguel@ximian.com>
17990 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
17991 there is already a namespace defined with this name.
17993 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
17994 people upgraded their corlibs.
17996 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
17997 always use fully qualified types, no need to use the compiler
18000 (TypeManager.IsNamespace): Use binarysearch.
18002 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
18003 AddDelegate): I did not quite use the new IsValid API properly: I
18004 have to pass the short-name and the fullname. I was passing only
18005 the basename instead of the fullname sometimes.
18007 (TypeContainer.DefineType): call NamespaceClash.
18009 * interface.cs (Interface.DefineType): use NamespaceClash before
18012 * delegate.cs (Delegate.DefineType): use NamespaceClash before
18015 * enum.cs: (Enum.DefineType): use NamespaceClash before
18018 * typemanager.cs (: 3-line patch that gives us some tasty 11%
18019 speed increase. First, use the negative_hits cache when we get a
18020 negative. Second, add the type with its full original name
18021 instead of the new . and + encoded name (reflection uses + to
18022 separate type from a nested type). Use LookupTypeReflection
18023 directly which bypasses the type->name hashtable (that we already
18024 know does not contain the type.
18026 * decl.cs (DeclSpace.ResolveTypeExpr): track the
18027 location/container type.
18029 * driver.cs: When passing utf8, use directly the UTF8Encoding.
18031 2003-04-19 Miguel de Icaza <miguel@ximian.com>
18033 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
18035 * delegate.cs (NewDelegate.Resolve): Test whether an instance
18036 method is being referenced in the method group from a static
18037 context, and report error 120 if so.
18039 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
18042 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
18043 is created, we create the A namespace).
18045 * cs-parser.jay: A namespace also introduces a DeclarationFound.
18048 2003-04-18 Miguel de Icaza <miguel@ximian.com>
18050 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
18051 invocation to ModuleBuilder.GetType with the same values will
18052 return a new type instance, so we need to cache its return
18055 * expression.cs (Binary.ResolveOperator): Only allow the compare
18056 operators on enums if they are of the same type.
18058 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
18059 types of ValueType on their own case. Before we were giving them
18060 the same treatment as objects.
18062 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
18063 fullname. Short name is used to compare against container name.
18064 Fullname is used to check against defined namespace names.
18066 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
18067 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
18069 (Method.CheckBase): Call parent.
18070 (MemberBase.CheckBase): Check for protected members on sealed
18072 (PropertyBase.CheckBase): Call parent.
18073 (Field.Define): Call parent.
18075 * report.cs: Negative error codes are now mapped to 8000 - code,
18076 so that the display is render more nicely.
18078 * typemanager.cs: Do not use try/catch, instead report a regular
18081 (GetPointerType, GetReferenceType): These methods provide
18082 mechanisms to obtain the T* and T& from a T. We had the code
18083 previously scattered around the code base, and it also used
18084 TypeManager.LookupType that would go through plenty of caches.
18085 This one goes directly to the type source.
18087 In some places we did the Type.GetType followed by
18088 ModuleBuilder.GetType, but not in others, so this unifies the
18089 processing as well.
18091 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
18092 statements now that we have namespace information.
18094 * typemanager.cs (IsNamespace): New method, returns whether the
18095 string presented is a namespace or not.
18097 (ComputeNamespaces): New public entry point, computes the list of
18098 available namespaces, using the GetNamespaces API call in Mono, or
18099 the slower version in MS.NET.
18101 Now before we start the semantic analysis phase, we have a
18102 complete list of namespaces including everything that the user has
18105 Deleted old code to cache namespaces in .nsc files.
18107 2003-04-17 Miguel de Icaza <miguel@ximian.com>
18109 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
18110 class/struct location definition Location for the implicit
18111 constructor location.
18113 (Operator.Define): Use the location of the operator for the
18114 implicit Method definition.
18116 (Constructor.Emit): use the constructor location for the implicit
18117 base initializer constructor.
18119 * ecore.cs: Remove ITypeExpression. This interface is now gone,
18120 and the Expression class now contains two new methods:
18122 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
18123 isolate type lookup from the rest of the resolution process.
18125 Since we use Expressions to hold type definitions due to the way
18126 we parse the input we have historically overloaded Resolve to
18127 perform the Type lookups if a special flag is passed. Now this is
18128 eliminated and two methods take their place.
18130 The differences in the two methods between xStep and xTerminal is
18131 that xStep is involved in our current lookup system that uses
18132 SimpleNames to compose a name, while xTerminal is used just to
18133 catch the case where the simplename lookup failed.
18135 2003-04-16 Miguel de Icaza <miguel@ximian.com>
18137 * expression.cs (ResolveMemberAccess): Remove redundant code.
18138 TypeExpr expressions are always born fully resolved.
18140 * interface.cs (PopulateMethod): Do not lookup the types twice.
18141 We were doing it once during SemanticAnalysis and once during
18144 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
18145 in local variable type definitions, were being returned as a
18146 SimpleName (we decomposed everything into a string), that is
18147 because primary_expression was being used instead of a type in the
18148 grammar (reduce/reduce conflicts).
18150 The part that was wrong is that we converted the expression into a
18151 string (an oversimplification in one hand, compounded with primary
18152 expressions doing string concatenation).
18158 Would return "A.B.C[]" as a SimpleName. This stopped things like
18159 using clauses from working on this particular context. And a type
18160 was being matched directly against "A.B.C[]".
18162 We now use the correct approach, and allow for ComposedCast to be
18163 part of the unary expression. So the "A.B.C []" become a composed
18164 cast of "A.B.C" (as a nested group of MemberAccess with a
18165 SimpleName at the end) plus the rank composition "[]".
18169 2003-04-10 Miguel de Icaza <miguel@ximian.com>
18171 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
18172 for the access level checking.
18174 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
18175 `TypeContainer container', because I kept getting confused when I
18176 was debugging this code.
18178 * expression.cs (Indexers): Instead of tracking getters/setters,
18179 we now track them in parallel. We create one arraylist less, but
18180 most importantly it is possible now for the LValue code to find a
18181 matching get for a set.
18183 (IndexerAccess.DoResolveLValue): Update the code.
18184 GetIndexersForType has been modified already to extract all the
18185 indexers from a type. The code assumed it did not.
18187 Also make the code set the correct return type for the indexer.
18188 This was fixed a long time ago for properties, but was missing for
18189 indexers. It used to be void_type.
18191 (Binary.Emit): Test first for doubles instead of
18192 floats, as they are more common.
18194 (Binary.EmitBranchable): Use the .un version of the branch opcodes
18195 when dealing with floats and the <=, >= operators. This fixes bug
18198 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
18199 to load the array value by emitting a load on the foreach variable
18200 type. This was incorrect.
18202 We now emit the code to load an element using the the array
18203 variable type, and then we emit the conversion operator.
18207 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
18209 * attribute.cs: Avoid allocation of ArrayLists in the common case.
18211 2003-04-09 Miguel de Icaza <miguel@ximian.com>
18213 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
18214 test for protection before we test for signatures.
18216 (MethodSignature.ToString): implement.
18218 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
18219 to the case where we reduced into a LongConstant.
18221 * decl.cs (CheckAccessLevel): If the type is an array, we can not
18222 depend on whether the information is acurrate, because the
18223 Microsoft runtime will always claim that the array type is public,
18224 regardless of the real state.
18226 If the type is a pointer, another problem happens: the type is
18227 reported as non-public in Microsoft.
18229 In both cases we have to call CheckAccessLevel recursively with
18230 the underlying type as the argument to be tested.
18232 2003-04-08 Miguel de Icaza <miguel@ximian.com>
18234 * assign.cs (Assign.Emit): If we are dealing with a compound
18235 assignment expression, we should use the code path that stores the
18236 intermediate result in a temporary value. This fixes #40903.
18238 *expression.cs (Indirection.ToString): Provide ToString method for
18241 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
18243 * class.cs: Null out fields holding references to Block objects so
18244 they can be garbage collected.
18246 * expression.cs (OverloadResolve): Remove unused local.
18248 2003-04-07 Martin Baulig <martin@ximian.com>
18250 * codegen.cs (EmitContext.CurrentFile): New public field.
18251 (EmitContext.Mark): Use the CurrentFile to check whether the
18252 location is in the correct file.
18253 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
18255 2003-04-07 Martin Baulig <martin@ximian.com>
18257 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
18259 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
18260 location. [FIXME: The location argument which gets passed to this
18261 method is sometimes wrong!]
18263 2003-04-07 Nick Drochak <ndrochak@gol.com>
18265 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
18267 2003-04-07 Miguel de Icaza <miguel@ximian.com>
18269 * expression.cs (Indirection.EmitAssign): We were using the
18270 temporary, but returning immediately instead of continuing the
18273 2003-04-06 Martin Baulig <martin@ximian.com>
18275 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
18276 if it's a nested child, but also deriving from the outer class.
18279 * typemanager.cs (IsNestedChildOf): Make this work if it's a
18280 nested child, but also deriving from the outer class. See
18282 (FilterWithClosure): We may access private members of the outer
18283 class if we're a nested child and deriving from the outer class.
18284 (RealMemberLookup): Only set `closure_private_ok' if the
18285 `original_bf' contained BindingFlags.NonPublic.
18287 2003-04-05 Martin Baulig <martin@ximian.com>
18289 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
18291 2003-04-02 Miguel de Icaza <miguel@ximian.com>
18293 * class.cs (Event.Define): Do not allow abstract events to have
18296 2003-04-01 Miguel de Icaza <miguel@ximian.com>
18298 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
18299 block in event declarations.
18301 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
18302 value type, get its address.
18304 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
18305 leaving a class on the stack instead of a boolean value (int
18306 0/1). Change the code so we compare against null, and then the
18307 result against zero.
18309 * class.cs (TypeContainer.GetClassBases): We were checking for the
18310 parent class being sealed too late.
18312 * expression.cs (Binary.Emit): For <= and >= when dealing with
18313 floating point values, use cgt.un and clt.un instead of cgt and
18316 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
18318 * statement.cs: Apply the same optimization as MS: skip the
18319 GetEnumerator returning an IEnumerator, and use the one returning a
18320 CharEnumerator instead. This allows us to avoid the try-finally block
18323 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
18325 * cs-parser.jay: Attributes cannot be applied to
18326 namespaces. Fixes #40473
18328 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18331 (Add*): check if the name is valid using the full name for constants,
18332 fields, properties and events.
18334 2003-03-28 Miguel de Icaza <miguel@ximian.com>
18336 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
18337 char constants to be part of the enumeration.
18339 * expression.cs (Conditional.DoResolve): Add support for operator
18340 true. Implements the missing functionality from 14.12
18342 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
18343 operator true/false as required by the spec.
18345 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
18346 implicit conversion to boolean.
18348 * statement.cs (Statement.ResolveBoolean): A boolean expression is
18349 also one where the type implements `operator true'.
18351 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
18352 get an expression that will invoke operator true based on an
18355 (GetConversionOperators): Removed the hack that called op_True
18358 (Expression.ResolveBoolean): Move this from Statement.
18360 2003-03-17 Miguel de Icaza <miguel@ximian.com>
18362 * ecore.cs (FieldExpr): do not allow initialization of initonly
18363 fields on derived classes
18365 2003-03-13 Martin Baulig <martin@ximian.com>
18367 * statement.cs (Block.Emit): Call ig.BeginScope() and
18368 ig.EndScope() when compiling with debugging info; call
18369 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
18371 2003-03-08 Miguel de Icaza <miguel@ximian.com>
18373 * expression.cs (Indexers): Do not construct immediately, allow
18374 for new members to be appended as we go. Fixes 38143
18376 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18378 * expression.cs: save/restore context when resolving an unchecked
18381 2003-03-05 Miguel de Icaza <miguel@ximian.com>
18383 * cfold.cs: Catch division by zero in modulus operator during
18386 2003-03-03 Miguel de Icaza <miguel@ximian.com>
18388 * interface.cs (Interface.DefineMembers): Avoid defining members
18391 2003-02-27 Miguel de Icaza <miguel@ximian.com>
18393 * driver.cs: handle the +/- options for -noconfig
18395 * statement.cs (Unckeched.Resolve): Also track the state of
18396 unchecked in the Resolve phase.
18398 2003-02-27 Martin Baulig <martin@ximian.com>
18400 * ecore.cs (Expression.MemberLookup): Don't create a
18401 MethodGroupExpr for something which is not a method. Fixes #38291.
18403 2003-02-25 Miguel de Icaza <miguel@ximian.com>
18405 * class.cs (MemberBase.CheckParameters): Also check that the type
18406 is unmanaged if it is a pointer.
18408 * expression.cs (SizeOf.Resolve): Add location information.
18410 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
18411 a managed type is declared.
18413 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
18414 parameter modifiers as well. Fixes bug 38606
18416 * class.cs: Very sad. Am backing out the speed up changes
18417 introduced by the ArrayList -> Array in the TypeContainer, as they
18418 were not actually that much faster, and introduced a bug (no error
18419 reports on duplicated methods).
18421 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
18422 source first, this will guarantee that we have a valid expression
18423 before calling in lower levels functions that will require a
18424 resolved object. Then use this original_source in the
18425 target.ResolveLValue instead of the original source that was
18428 Another change. Use target.Resolve instead of LValueResolve.
18429 Although we are resolving for LValues, we will let the Assign code
18430 take care of that (it will be called again from Resolve). This
18431 basically allows code like this:
18433 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
18434 class Y { void A (X x) { x [0] += o; }
18436 The problem was that the indexer was trying to resolve for
18437 set_Item (idx, object o) and never finding one. The real set_Item
18438 was set_Item (idx, X). By delaying the process we get the right
18443 2003-02-23 Martin Baulig <martin@ximian.com>
18445 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
18446 while calling DoEmit ().
18448 * codegen.cs (EmitContext.Mark): Don't mark locations in other
18449 source files; if you use the #line directive inside a method, the
18450 compiler stops emitting line numbers for the debugger until it
18451 reaches the end of the method or another #line directive which
18452 restores the original file.
18454 2003-02-23 Martin Baulig <martin@ximian.com>
18456 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
18458 2003-02-23 Martin Baulig <martin@ximian.com>
18460 * statement.cs (Block.AddChildVariableNames): We need to call this
18461 recursively, not just for our immediate children.
18463 2003-02-23 Martin Baulig <martin@ximian.com>
18465 * class.cs (Event.Define): Always make the field private, like csc does.
18467 * typemanager.cs (TypeManager.RealMemberLookup): Make events
18468 actually work, fixes bug #37521.
18470 2003-02-23 Miguel de Icaza <miguel@ximian.com>
18472 * delegate.cs: When creating the various temporary "Parameters"
18473 classes, make sure that we call the ComputeAndDefineParameterTypes
18474 on those new parameters (just like we do with the formal ones), to
18475 allow them to be resolved in the context of the DeclSpace.
18477 This fixes the bug that Dick observed in Bugzilla #38530.
18479 2003-02-22 Miguel de Icaza <miguel@ximian.com>
18481 * expression.cs (ResolveMemberAccess): When resolving a constant,
18482 do not attempt to pull a constant if the value was not able to
18483 generate a valid constant.
18485 * const.cs (LookupConstantValue): Do not report more errors than required.
18487 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18489 * expression.cs: fixes bug #38328.
18491 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18493 * class.cs: Changed all the various members that can be part of a
18494 class from being an ArrayList to be an Array of the right type.
18495 During the DefineType type_list, interface_list, delegate_list and
18496 enum_list are turned into types, interfaces, delegates and enums
18499 And during the member population, indexer_list, event_list,
18500 constant_list, field_list, instance_constructor_list, method_list,
18501 operator_list and property_list are turned into their real arrays.
18503 Although we could probably perform this operation earlier, for
18504 good error reporting we need to keep the lists and remove the
18505 lists for longer than required.
18507 This optimization was triggered by Paolo profiling the compiler
18508 speed on the output of `gen-sample-program.pl' perl script.
18510 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
18511 not crash in methods like MemberLookupFailed that use this field.
18513 This problem arises when the compiler fails to resolve a type
18514 during interface type definition for example.
18516 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18518 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
18519 inherit from System.Object, so we have to stop at null, not only
18520 when reaching System.Object.
18522 2003-02-17 Miguel de Icaza <miguel@ximian.com>
18524 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
18525 DeclaredOnly because the parent indexer might have had a different
18526 name, but did not loop until the top of the hierarchy was reached.
18528 The problem this one fixes is 35492: when a class implemented an
18529 indexer from an interface, we were getting the interface method
18530 (which was abstract) and we were flagging an error (can not invoke
18533 This also keeps bug 33089 functioning, and test-148 functioning.
18535 * typemanager.cs (IsSpecialMethod): The correct way of figuring
18536 out if a method is special is to see if it is declared in a
18537 property or event, or whether it is one of the predefined operator
18538 names. This should fix correctly #36804.
18540 2003-02-15 Miguel de Icaza <miguel@ximian.com>
18542 The goal here is to remove the dependency on EmptyCast.Peel ().
18543 Killing it completely.
18545 The problem is that currently in a number of places where
18546 constants are expected, we have to "probe" for an EmptyCast, and
18547 Peel, which is not the correct thing to do, as this will be
18548 repetitive and will likely lead to errors.
18550 The idea is to remove any EmptyCasts that are used in casts that
18551 can be reduced to constants, so we only have to cope with
18554 This bug hunt was triggered by Bug 37363 and the desire to remove
18555 the duplicate pattern where we were "peeling" emptycasts to check
18556 whether they were constants. Now constants will always be
18559 * ecore.cs: Use an enumconstant here instead of wrapping with
18562 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
18563 throwing me off. By handling this we can get rid of a few hacks.
18565 * statement.cs (Switch): Removed Peel() code.
18567 2003-02-14 Miguel de Icaza <miguel@ximian.com>
18569 * class.cs: Location information for error 508
18571 * expression.cs (New.DoResolve): Add a guard against double
18572 resolution of an expression.
18574 The New DoResolve might be called twice when initializing field
18575 expressions (see EmitFieldInitializers, the call to
18576 GetInitializerExpression will perform a resolve on the expression,
18577 and later the assign will trigger another resolution
18579 This leads to bugs (#37014)
18581 * delegate.cs: The signature for EndInvoke should contain any ref
18582 or out parameters as well. We were not doing this in the past.
18584 * class.cs (Field.Define): Do not overwrite the type definition
18585 inside the `volatile' group. Turns out that volatile enumerations
18586 were changing the type here to perform a validity test, which
18589 2003-02-12 Miguel de Icaza <miguel@ximian.com>
18591 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
18592 and structs, we do not want to load the instance variable
18594 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
18595 enum_type has to be handled like an object reference (implicit
18596 conversions exists from this to object), but the regular IsClass
18597 and IsValueType tests will never return true for this one.
18599 Also we use TypeManager.IsValueType instead of type.IsValueType,
18600 just for consistency with the rest of the code (this is only
18601 needed if we ever use the construct exposed by test-180.cs inside
18602 corlib, which we dont today).
18604 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
18606 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
18609 2003-02-09 Martin Baulig <martin@ximian.com>
18611 * namespace.cs (Namespace..ctor): Added SourceFile argument.
18612 (Namespace.DefineNamespaces): New static public method; this is
18613 called when we're compiling with debugging to add all namespaces
18614 to the symbol file.
18616 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
18617 pass it to the Namespace's .ctor.
18619 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
18620 and MethodBase arguments; pass the namespace ID to the symwriter;
18621 pass the MethodBase instead of the token to the symwriter.
18622 (SymbolWriter.DefineNamespace): New method to add a namespace to
18625 2003-02-09 Martin Baulig <martin@ximian.com>
18627 * symbolwriter.cs: New file. This is a wrapper around
18628 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
18629 methods here in near future.
18631 2003-02-09 Martin Baulig <martin@ximian.com>
18633 * codegen.cs (EmitContext.Mark): Just pass the arguments to
18634 ILGenerator.MarkSequencePoint() which are actually used by the
18637 2003-02-09 Martin Baulig <martin@ximian.com>
18639 * location.cs (SourceFile): New public sealed class. This
18640 contains the name and an index which is used in the location's token.
18641 (Location): Reserve an appropriate number of bits in the token for
18642 the source file instead of walking over that list, this gives us a
18643 really huge performance improvement when compiling with debugging.
18645 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
18646 `SourceFile' argument instead of a string.
18647 (Driver.ProcessFile): Add all the files via Location.AddFile(),
18648 but don't parse/tokenize here, we need to generate the list of all
18649 source files before we do that.
18650 (Driver.ProcessFiles): New static function. Parses/tokenizes all
18653 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
18654 instead of a string.
18656 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
18659 2003-02-09 Martin Baulig <martin@ximian.com>
18661 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
18662 filename on `#line default'.
18664 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
18666 * statement.cs: don't clear the pinned var when the fixed statement
18667 returns from the method (fixes bug#37752).
18669 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
18671 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
18674 2003-02-07 Martin Baulig <martin@ximian.com>
18676 * driver.cs: Removed the `--debug-args' command line argument.
18678 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
18679 automatically by the AsssemblyBuilder.
18680 (CodeGen.InitializeSymbolWriter): We don't need to call any
18681 initialization function on the symbol writer anymore. This method
18682 doesn't take any arguments.
18684 2003-02-03 Miguel de Icaza <miguel@ximian.com>
18686 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
18687 from referenced assemblies as well.
18689 2003-02-02 Martin Baulig <martin@ximian.com>
18691 * class.cs (MethodData.Emit): Generate debugging info for external methods.
18693 2003-02-02 Martin Baulig <martin@ximian.com>
18695 * class.cs (Constructor.Emit): Open the symbol writer before
18696 emitting the constructor initializer.
18697 (ConstructorInitializer.Emit): Call ec.Mark() to allow
18698 single-stepping through constructor initializers.
18700 2003-01-30 Miguel de Icaza <miguel@ximian.com>
18702 * class.cs: Handle error 549: do not allow virtual methods in
18705 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
18707 * decl.cs: Check access levels when resolving types
18709 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
18711 * statement.cs: Add parameters and locals set in catch blocks that might
18712 return to set vector
18714 2003-01-29 Miguel de Icaza <miguel@ximian.com>
18716 * class.cs (Operator): Set the SpecialName flags for operators.
18718 * expression.cs (Invocation.DoResolve): Only block calls to
18719 accessors and operators on SpecialName methods.
18721 (Cast.TryReduce): Handle conversions from char constants.
18724 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
18726 * statement.cs: small memory and time optimization in FlowBranching.
18728 2003-01-28 Pedro Mart <yoros@wanadoo.es>
18730 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
18731 problem that the last fix but in the other sid (Set).
18733 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
18734 access when there is no indexer in the hierarchy.
18736 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
18738 * class.cs: Combine some if statements.
18740 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18742 * driver.cs: fixed bug #37187.
18744 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
18746 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
18747 any indexer, it's needed to build a list with all the indexers in the
18748 hierarchy (AllGetters), else we have problems. Fixes #35653.
18750 2003-01-23 Miguel de Icaza <miguel@ximian.com>
18752 * class.cs (MethodData.Define): It is wrong for an interface
18753 implementation to be static in both cases: explicit and implicit.
18754 We were only handling this in one case.
18756 Improve the if situation there to not have negations.
18758 * class.cs (Field.Define): Turns out that we do not need to check
18759 the unsafe bit on field definition, only on usage. Remove the test.
18761 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18763 * driver.cs: use assembly.Location instead of Codebase (the latest
18764 patch made mcs fail when using MS assemblies).
18766 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
18768 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
18769 get the path to *corlib.dll.
18771 2003-01-21 Nick Drochak <ndrochak@gol.com>
18775 * typemanager.cs: Remove compiler warnings
18777 2003-01-20 Duncan Mak <duncan@ximian.com>
18779 * AssemblyInfo.cs: Bump the version number to 0.19.
18781 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18783 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
18785 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
18787 * class.cs (Constructor::Emit): Emit debugging info for constructors.
18789 2003-01-17 Miguel de Icaza <miguel@ximian.com>
18791 * cs-parser.jay: Small fix: we were not comparing the constructor
18792 name correctly. Thanks to Zoltan for the initial pointer.
18794 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
18796 * cs-tokenizer.cs: Set file name when specified with #line
18798 2003-01-15 Miguel de Icaza <miguel@ximian.com>
18800 * cs-parser.jay: Only perform the constructor checks here if we
18801 are named like the class; This will help provider a better
18802 error. The constructor path is taken when a type definition is
18803 not found, but most likely the user forgot to add the type, so
18804 report that rather than the constructor error.
18806 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
18808 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
18811 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18813 * cs-parser.jay: Add cleanup call.
18815 2003-01-13 Duncan Mak <duncan@ximian.com>
18817 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
18818 consistent with other methods.
18820 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18822 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
18824 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
18826 * attribute.cs: only set GuidAttr to true when we have a
18829 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18833 * typemanager.cs: fixes to allow mcs compile corlib with the new
18834 Type.IsSubclassOf fix.
18836 2003-01-08 Miguel de Icaza <miguel@ximian.com>
18838 * expression.cs (LocalVariableReference.DoResolve): Classify a
18839 constant as a value, not as a variable. Also, set the type for
18842 * cs-parser.jay (fixed_statement): take a type instead of a
18843 pointer_type, so we can produce a better error message later.
18845 * statement.cs (Fixed.Resolve): Flag types that are not pointers
18848 (For.DoEmit): Make inifinite loops have a
18849 non-conditional branch back.
18851 (Fixed.DoEmit): First populate the pinned variables, then emit the
18852 statement, then clear the variables. Before I was emitting the
18853 code once for each fixed piece.
18856 2003-01-08 Martin Baulig <martin@ximian.com>
18858 * statement.cs (FlowBranching.MergeChild): A break in a
18859 SWITCH_SECTION does not leave a loop. Fixes #36155.
18861 2003-01-08 Martin Baulig <martin@ximian.com>
18863 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18864 lives in the same number space than `param_map'. Fixes #36154.
18866 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18868 * cs-parser.jay (constructor_declaration): Set the
18869 Constructor.ModFlags before probing for it. This makes the
18870 compiler report 514, 515 and 132 (the code was there, but got
18873 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18874 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18875 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18877 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18879 * enum.cs: create the enum static fields using the enum type.
18881 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18883 * class.cs: don't try to create the ParamBuilder for the return
18884 type if it's not needed (and handle it breaking for the ms runtime
18887 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18889 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18891 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18893 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18894 the command. This showed up while compiling the JANET source
18895 code, which used \r as its only newline separator.
18897 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18899 * class.cs (Method.Define): If we are an operator (because it
18900 reuses our code), then set the SpecialName and HideBySig. #36128
18902 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18904 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18905 exception, report error 120 `object reference required'.
18907 * driver.cs: Add --pause option, used during to measure the size
18908 of the process as it goes with --timestamp.
18910 * expression.cs (Invocation.DoResolve): Do not allow methods with
18911 SpecialName to be invoked.
18913 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18915 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18916 number before adding it.
18918 2002-12-21 Ravi Pratap <ravi@ximian.com>
18920 * ecore.cs (StandardImplicitConversion): When in an unsafe
18921 context, we allow conversion between void * to any other pointer
18922 type. This fixes bug #35973.
18924 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18926 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18927 is not thrown when extensionless outputs are used
18929 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18931 * rootcontext.cs: fixed compilation of corlib.
18933 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18935 * attribute.cs (Attributes.Contains): Add new method.
18937 * class.cs (MethodCore.LabelParameters): if the parameter is an
18938 `out' parameter, check that no attribute `[In]' has been passed.
18940 * enum.cs: Handle the `value__' name in an enumeration.
18942 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18944 * decl.cs: Added special case to allow overrides on "protected
18947 2002-12-18 Ravi Pratap <ravi@ximian.com>
18949 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18950 since it makes much more sense.
18952 (Attributes.ctor): Don't require a Location parameter.
18954 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18956 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18957 since we already have that information per attribute.
18959 * everywhere : make appropriate changes.
18961 * class.cs (LabelParameters): Write the code which actually
18962 applies attributes to the return type. We can't do this on the MS
18963 .NET runtime so we flag a warning in the case an exception is
18966 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18968 * const.cs: Handle implicit null conversions here too.
18970 2002-12-17 Ravi Pratap <ravi@ximian.com>
18972 * class.cs (MethodCore.LabelParameters): Remove the extra
18973 Type [] parameter since it is completely unnecessary. Instead
18974 pass in the method's attributes so that we can extract
18975 the "return" attribute.
18977 2002-12-17 Miguel de Icaza <miguel@ximian.com>
18979 * cs-parser.jay (parse): Use Report.Error to flag errors instead
18980 of ignoring it and letting the compile continue.
18982 * typemanager.cs (ChangeType): use an extra argument to return an
18983 error condition instead of throwing an exception.
18985 2002-12-15 Miguel de Icaza <miguel@ximian.com>
18987 * expression.cs (Unary.TryReduce): mimic the code for the regular
18988 code path. Perform an implicit cast in the cases where we can
18989 implicitly convert to one of the integral types, and then reduce
18990 based on that constant. This fixes bug #35483.
18992 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18994 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
18996 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18998 * namespace.cs: fixed bug #35489.
19000 2002-12-12 Miguel de Icaza <miguel@ximian.com>
19002 * class.cs: Remove some dead code.
19004 * cs-parser.jay: Estimate the number of methods needed
19005 (RootContext.MethodCount);
19007 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
19008 numbers instead of StringBuilders.
19010 * support.cs (PtrHashtable): Add constructor with initial size;
19011 We can now reduce reallocations of the method table.
19013 2002-12-10 Ravi Pratap <ravi@ximian.com>
19015 * attribute.cs (ApplyAttributes): Keep track of the emitted
19016 attributes on a per-target basis. This fixes bug #35413.
19018 2002-12-10 Miguel de Icaza <miguel@ximian.com>
19020 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
19021 default to the Windows 1252 encoding.
19023 (UnixParseOption): Support version, thanks to Alp for the missing
19026 * AssemblyInfo.cs: Add nice assembly information.
19028 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
19031 * cs-parser.jay: Allow a trailing comma before the close bracked
19032 in the attribute_section production.
19034 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
19035 address of the instance was being taken, I will take this out,
19036 because we take the address of the object immediately here.
19038 2002-12-09 Ravi Pratap <ravi@ximian.com>
19040 * typemanager.cs (AreMultipleAllowed): Take care of the most
19041 obvious case where attribute type is not in the current assembly -
19044 2002-12-08 Miguel de Icaza <miguel@ximian.com>
19046 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
19047 definitions, instead of doing that afterwards.
19049 Also we use a nice little hack, depending on the constructor, we
19050 know if we are a "composed" name or a simple name. Hence, we
19051 avoid the IndexOf test, and we avoid
19053 * codegen.cs: Add code to assist in a bug reporter to track down
19054 the source of a compiler crash.
19056 2002-12-07 Ravi Pratap <ravi@ximian.com>
19058 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
19059 types have been emitted for a given element and flag an error
19060 if something which does not have AllowMultiple set is used more
19063 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
19064 attribute types and their corresponding AllowMultiple properties
19066 (AreMultipleAllowed): Check the property for a given type.
19068 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
19069 property in the case we have a TypeContainer.
19071 (Attributes.AddAttribute): Detect duplicates and just skip on
19072 adding them. This trivial fix catches a pretty gross error in our
19073 attribute emission - global attributes were being emitted twice!
19075 Bugzilla bug #33187 is now fixed.
19077 2002-12-06 Miguel de Icaza <miguel@ximian.com>
19079 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
19080 instead of pp_and).
19082 * expression.cs (Binary.ResolveOperator): I can only use the
19083 Concat (string, string, string) and Concat (string, string,
19084 string, string) if the child is actually a concatenation of
19087 2002-12-04 Miguel de Icaza <miguel@ximian.com>
19089 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
19090 context where we need a 2-character lookahead.
19092 * pending.cs (PendingImplementation): Rework so we can keep track
19093 of interface types all the time, and flag those which were
19094 implemented by parents as optional.
19096 2002-12-03 Miguel de Icaza <miguel@ximian.com>
19098 * expression.cs (Binary.ResolveOperator): Use
19099 String.Concat(string,string,string) or
19100 String.Concat(string,string,string,string) when possible.
19102 * typemanager: More helper methods.
19105 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
19107 * pending.cs: remove the bogus return from GetMissingInterfaces()
19108 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
19110 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19112 * namespace.cs: avoid duplicated 'using xxx' being added to
19113 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
19114 when we get more than one 'using' statement for the same namespace.
19115 Report a CS0105 warning for it.
19117 2002-11-30 Miguel de Icaza <miguel@ximian.com>
19119 * cs-tokenizer.cs (consume_identifier): use read directly, instead
19120 of calling getChar/putback, uses internal knowledge of it.
19122 (xtoken): Reorder tokenizer so most common patterns are checked
19123 first. This reduces the compilation time in another 5% (from 8.11s
19124 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
19126 The parsing time is 22% of the compilation in mcs, and from that
19127 64% is spent on the tokenization process.
19129 I tried using a binary search for keywords, but this is slower
19130 than the hashtable. Another option would be to do a couple of
19133 * Not use a StringBuilder, instead use an array of chars,
19134 with a set value. Notice that this way we could catch
19135 the 645 error without having to do it *afterwards*.
19137 * We could write a hand-parser to avoid the hashtable
19138 compares altogether.
19140 The identifier consumption process takes 37% of the tokenization
19141 time. Another 15% is spent on is_number. 56% of the time spent
19142 on is_number is spent on Int64.Parse:
19144 * We could probably choose based on the string length to
19145 use Int32.Parse or Int64.Parse and avoid all the 64-bit
19148 Another 3% is spend on wrapping `xtoken' in the `token' function.
19150 Handle 0xa0 as whitespace (#34752)
19152 2002-11-26 Miguel de Icaza <miguel@ximian.com>
19154 * typemanager.cs (IsCLRType): New routine to tell whether a type
19155 is one of the builtin types.
19157 Maybe it needs to use TypeCodes to be faster. Maybe we could use
19158 typecode in more places instead of doing pointer comparissions.
19159 We could leverage some knowledge about the way the typecodes are
19162 New code to cache namespaces in assemblies, it is currently not
19163 invoked, to be used soon.
19165 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
19167 * expression.cs (Binary.ResolveOperator): specially handle
19168 strings, and do not perform user-defined operator overloading for
19171 2002-11-24 Miguel de Icaza <miguel@ximian.com>
19173 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
19174 internalcall as it is a pretty simple operation; Avoid whenever
19175 possible to call Char.IsLetter.
19177 (consume_identifier): Cut by half the number of
19178 hashtable calls by merging the is_keyword and GetKeyword behavior.
19180 Do not short-circuit, because if we do, we
19181 report errors (ie, #if false && true would produce an invalid
19185 2002-11-24 Martin Baulig <martin@ximian.com>
19187 * expression.cs (Cast.TryReduce): If we're in checked syntax,
19188 check constant ranges and report a CS0221. Fixes #33186.
19190 2002-11-24 Martin Baulig <martin@ximian.com>
19192 * cs-parser.jay: Make this work for uninitialized variable
19193 declarations in the `for' initializer. Fixes #32416.
19195 2002-11-24 Martin Baulig <martin@ximian.com>
19197 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
19198 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
19200 2002-11-24 Martin Baulig <martin@ximian.com>
19202 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
19203 argument; if true, we also check for user-defined conversions.
19204 This is only needed if both arguments are of a user-defined type.
19205 Fixes #30443, added test-175.cs.
19206 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
19208 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
19210 2002-11-24 Martin Baulig <martin@ximian.com>
19212 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
19213 function to get the store opcode.
19214 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
19215 only emit the Ldelema if the store opcode is Stobj. You must run
19216 both test-34 and test-167 to test this. Fixes #34529.
19218 2002-11-23 Martin Baulig <martin@ximian.com>
19220 * ecore.cs (Expression.MemberLookup): Added additional
19221 `qualifier_type' argument which is used when we're being called
19222 from MemberAccess.DoResolve() and null if we're called from a
19224 (Expression.MemberLookupFailed): New method to report errors; this
19225 does the CS1540 check and reports the correct error message.
19227 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
19228 argument for the CS1540 check and redone the way how we're dealing
19229 with private members. See the comment in the source code for details.
19230 (FilterWithClosure): Reverted this back to revision 1.197; renamed
19231 `closure_start_type' to `closure_qualifier_type' and check whether
19232 it's not null. It was not this filter being broken, it was just
19233 being called with the wrong arguments.
19235 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
19236 and pass it the correct `qualifier_type'; this also does the error
19239 2002-11-22 Miguel de Icaza <miguel@ximian.com>
19241 * expression.cs (Invocation.EmitParams): If the we are dealing
19242 with a non-built-in value type, load its address as well.
19244 (ArrayCreation): Use a a pretty constant instead
19245 of the hardcoded value 2. Use 6 instead of 2 for the number of
19246 static initializers.
19248 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
19249 because they are not really value types, just glorified integers.
19251 * driver.cs: Do not append .exe, the CSC compiler does not do it.
19253 * ecore.cs: Remove redundant code for enumerations, make them use
19254 the same code path as everything else, fixes the casting issue
19255 with enumerations in Windows.Forms.
19257 * attribute.cs: Do only cast to string if it is a string, the
19258 validation happens later.
19260 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
19261 people upgrade their corlibs.
19263 * ecore.cs: Oops, enumerations were not following the entire code path
19265 2002-11-21 Miguel de Icaza <miguel@ximian.com>
19267 * typemanager.cs (FilterWithClosure): Commented out the test for
19268 1540 in typemanager.cs, as it has problems when accessing
19269 protected methods from a parent class (see test-174.cs).
19271 * attribute.cs (Attribute.ValidateGuid): new method.
19272 (Attribute.Resolve): Use above.
19274 2002-11-19 Miguel de Icaza <miguel@ximian.com>
19276 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
19278 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
19279 handling for enumerations, as we only needed the TypeContainer
19280 functionality to begin with (this is required for the fix below to
19281 work for enums that reference constants in a container class for
19284 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
19286 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
19287 a valid TypeBuilder to perform lookups on.o
19289 * class.cs (InheritableMemberSignatureCompare): Use true in the
19290 call to GetGetMethod and GetSetMethod, because we are comparing
19291 the signature, and we need to get the methods *even* if they are
19294 (PropertyBase.CheckBase): ditto.
19296 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
19297 GotoCase.Resolve): Use Peel on EmpytCasts.
19299 * ecore.cs (EmptyCast): drop child, add Peel method.
19301 2002-11-17 Martin Baulig <martin@ximian.com>
19303 * ecore.cs (EmptyCast.Child): New public property.
19305 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
19306 label resolved to an EmptyCast. Fixes #34162.
19307 (GotoCase.Resolve): Likewise.
19308 (Block.EmitMeta): Likewise.
19310 2002-11-17 Martin Baulig <martin@ximian.com>
19312 * expression.cs (Invocation.BetterConversion): Prefer int over
19313 uint; short over ushort; long over ulong for integer literals.
19314 Use ImplicitConversionExists instead of StandardConversionExists
19315 since we also need to check for user-defined implicit conversions.
19316 Fixes #34165. Added test-173.cs.
19318 2002-11-16 Martin Baulig <martin@ximian.com>
19320 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
19321 with the `true' and `false' literals. Fixes #33151.
19323 2002-11-16 Martin Baulig <martin@ximian.com>
19325 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
19326 October 22nd; don't do the cs1540 check for static members.
19328 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
19329 now using our own filter here and doing the cs1540 check again.
19331 2002-11-16 Martin Baulig <martin@ximian.com>
19333 * support.cs (InternalParameters): Don't crash if we don't have
19334 any fixed parameters. Fixes #33532.
19336 2002-11-16 Martin Baulig <martin@ximian.com>
19338 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
19339 when looking up static methods to make this work on Windows.
19342 2002-11-16 Martin Baulig <martin@ximian.com>
19344 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
19345 a setter rather than using PropertyInfo.CanWrite.
19347 2002-11-15 Nick Drochak <ndrochak@gol.com>
19349 * class.cs: Allow acces to block member by subclasses. Fixes build
19352 2002-11-14 Martin Baulig <martin@ximian.com>
19354 * class.cs (Constructor.Emit): Added the extern/block check.
19357 2002-11-14 Martin Baulig <martin@ximian.com>
19359 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
19360 iteration while looking for indexers, this is needed because the
19361 indexer may have a different name in our base classes. Fixed the
19362 error reporting (no indexers at all, not get accessor, no
19363 overloaded match). Fixes bug #33089.
19364 (IndexerAccess.DoResolveLValue): Likewise.
19366 2002-11-14 Martin Baulig <martin@ximian.com>
19368 * class.cs (PropertyBase.CheckBase): Make this work for multiple
19369 indexers. Fixes the first part of bug #33089.
19370 (MethodSignature.InheritableMemberSignatureCompare): Added support
19373 2002-11-13 Ravi Pratap <ravi@ximian.com>
19375 * attribute.cs (Attribute.Resolve): Catch the
19376 NullReferenceException and report it since it isn't supposed to
19379 2002-11-12 Miguel de Icaza <miguel@ximian.com>
19381 * expression.cs (Binary.EmitBranchable): Also handle the cases for
19382 LogicalOr and LogicalAnd that can benefit from recursively
19383 handling EmitBranchable. The code now should be nice for Paolo.
19385 2002-11-08 Miguel de Icaza <miguel@ximian.com>
19387 * typemanager.cs (LookupType): Added a negative-hit hashtable for
19388 the Type lookups, as we perform quite a number of lookups on
19389 non-Types. This can be removed once we can deterministically tell
19390 whether we have a type or a namespace in advance.
19392 But this might require special hacks from our corlib.
19396 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
19397 and double which avoids a conversion from an integer to a double.
19399 * expression.cs: tiny optimization, avoid calling IsConstant,
19400 because it effectively performs the lookup twice.
19402 2002-11-06 Miguel de Icaza <miguel@ximian.com>
19404 But a bogus return here to keep the semantics of the old code
19405 until the Mono runtime is fixed.
19407 * pending.cs (GetMissingInterfaces): New method used to remove all
19408 the interfaces that are already implemented by our parent
19409 classes from the list of pending methods.
19411 * interface.cs: Add checks for calls after ResolveTypeExpr.
19413 2002-11-05 Miguel de Icaza <miguel@ximian.com>
19415 * class.cs (Class.Emit): Report warning 67: event not used if the
19416 warning level is beyond 3.
19418 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
19419 being a NullLiteral.
19421 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
19424 * class.cs (TypeContainer.GetClassBases): Cover a missing code
19425 path that might fail if a type can not be resolved.
19427 * expression.cs (Binary.Emit): Emit unsigned versions of the
19430 * driver.cs: use error 5.
19432 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
19434 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
19436 2002-11-01 Miguel de Icaza <miguel@ximian.com>
19438 * cs-parser.jay (switch_section): A beautiful patch from Martin
19439 Baulig that fixed 33094.
19441 2002-10-31 Miguel de Icaza <miguel@ximian.com>
19443 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
19444 Check whether the base is abstract and report an error if so.
19446 * expression.cs (IndexerAccess.DoResolveLValue,
19447 IndexerAccess.DoResolve): ditto.
19449 (Invocation.DoResolve): ditto.
19451 (Invocation.FullMethodDesc): Improve the report string.
19453 * statement.cs (Block): Eliminate IsVariableDefined as it is
19454 basically just a wrapper for GetVariableInfo.
19456 * ecore.cs (SimpleName): Use new
19458 * support.cs (ReflectionParamter.ParameterType): We unwrap the
19459 type, as we return the actual parameter ref/unref state on a
19462 2002-10-30 Miguel de Icaza <miguel@ximian.com>
19464 * support.cs: Return proper flags REF/OUT fixing the previous
19467 * expression.cs: Reverted last patch, that was wrong. Is_ref is
19468 not used to mean `ref' but `ref or out' in ParameterReference
19470 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
19471 full type signature instead of calling TypeManger.CSharpName
19474 * support.cs (InternalParameters.ParameterDesc): Do not compare
19475 directly to the modflags, because REF/OUT will actually be bitsets
19478 * delegate.cs (VerifyMethod): Check also the modifiers.
19480 * cs-tokenizer.cs: Fix bug where floating point values with an
19481 exponent where a sign was missing was ignored.
19483 * driver.cs: Allow multiple assemblies to be specified in a single
19486 2002-10-28 Miguel de Icaza <miguel@ximian.com>
19488 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
19489 because identifiers after a parenthesis would end up in this kind
19490 of production, and we needed to desamiguate it for having casts
19493 (UserDefinedType *) xxx
19495 2002-10-24 Miguel de Icaza <miguel@ximian.com>
19497 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
19498 we should set on the Bindingflags.NonPublic, but not turn on
19499 private_ok. private_ok controls whether a Private member is
19500 returned (this is chekced on the filter routine), while the
19501 BindingFlags.NonPublic just controls whether private/protected
19502 will be allowed. This fixes the problem part of the problem of
19503 private properties being allowed to be used in derived classes.
19505 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
19506 so we can call the children DoResolveLValue method (this will
19507 properly signal errors on lvalue assignments to base properties)
19509 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
19510 getter are null, and we have a property info, we know that this
19511 happened because the lookup failed, so we report an error 122 for
19512 protection level violation.
19514 We also silently return if setter and getter are null in the
19515 resolve functions, this condition only happens if we have flagged
19516 the error before. This is the other half of the problem.
19518 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
19519 not have accessibility information, that is why we were returning
19520 true in the filter function in typemanager.cs.
19522 To properly report 122 (property is inaccessible because of its
19523 protection level) correctly, we report this error in ResolveAccess
19524 by failing if both the setter and the getter are lacking (ie, the
19527 DoResolve and DoLResolve have been modified to check for both
19528 setter/getter being null and returning silently, the reason being
19529 that I did not want to put the knowledge about this error in upper
19532 int old = Report.Errors;
19533 x = new PropertyExpr (...);
19534 if (old != Report.Errors)
19539 So the property expr is returned, but it is invalid, so the error
19540 will be flagged during the resolve process.
19542 * class.cs: Remove InheritablePropertySignatureCompare from the
19543 class, as we no longer depend on the property signature to compute
19544 whether it is possible to implement a method or not.
19546 The reason is that calling PropertyInfo.GetGetMethod will return
19547 null (in .NET, in Mono it works, and we should change this), in
19548 cases where the Get Method does not exist in that particular
19553 class X { public virtual int A { get { return 1; } } }
19555 class Z : Y { public override int A { get { return 2; } } }
19557 Would fail in Z because the parent (Y) would not have the property
19558 defined. So we avoid this completely now (because the alternative
19559 fix was ugly and slow), and we now depend exclusively on the
19562 (PropertyBase.CheckBase): Use a method-base mechanism to find our
19563 reference method, instead of using the property.
19565 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
19566 routines are gone now.
19568 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
19569 names, they were incorrectly named.
19571 * cs-tokenizer.cs: Return are more gentle token on failure.
19573 * pending.cs (PendingImplementation.InterfaceMethod): This routine
19574 had an out-of-sync index variable, which caused it to remove from
19575 the list of pending methods the wrong method sometimes.
19577 2002-10-22 Miguel de Icaza <miguel@ximian.com>
19579 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
19580 CanWrite, because those refer to this particular instance of the
19581 property, and do not take into account the fact that we can
19582 override single members of a property.
19584 Constructor requires an EmitContext. The resolution process does
19585 not happen here, but we need to compute the accessors before,
19586 because the resolution does not always happen for properties.
19588 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
19589 subclass, before we did not update this flag, but we did update
19592 (GetAccessors): Drop this routine, as it did not work in the
19593 presence of partially overwritten set/get methods.
19595 Notice that this broke the cs1540 detection, but that will require
19598 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19602 * driver.cs: issue a warning instead of an error if we don't support
19603 debugging for the platform. Also ignore a couple of errors that may
19604 arise when trying to write the symbols. Undo my previous patch.
19606 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19608 * driver.cs: ignore /debug switch except for Unix platforms.
19610 2002-10-23 Nick Drochak <ndrochak@gol.com>
19612 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
19614 2002-10-21 Miguel de Icaza <miguel@ximian.com>
19616 * driver.cs: Do not make mcs-debug conditional, so we do not break
19617 builds that use it.
19619 * statement.cs (UsageVector.MergeChildren): I would like Martin to
19620 review this patch. But basically after all the children variables
19621 have been merged, the value of "Breaks" was not being set to
19622 new_breaks for Switch blocks. I think that it should be set after
19623 it has executed. Currently I set this to the value of new_breaks,
19624 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
19625 conservative, but I do not understand this code very well.
19627 I did not break anything in the build, so that is good ;-)
19629 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
19631 2002-10-20 Mark Crichton <crichton@gimp.org>
19633 * cfold.cs: Fixed compile blocker. Really fixed it this time.
19635 2002-10-20 Nick Drochak <ndrochak@gol.com>
19637 * cfold.cs: Fixed compile blocker.
19639 2002-10-20 Miguel de Icaza <miguel@ximian.com>
19641 * driver.cs: I was chekcing the key, not the file.
19643 2002-10-19 Ravi Pratap <ravi@ximian.com>
19645 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
19646 message that we were generating - we just need to silently return
19649 2002-10-19 Miguel de Icaza <miguel@ximian.com>
19651 * class.cs (Event.Define): Change my previous commit, as this
19652 breaks the debugger. This is a temporary hack, as it seems like
19653 the compiler is generating events incorrectly to begin with.
19655 * expression.cs (Binary.ResolveOperator): Added support for
19656 "U operator - (E x, E y)"
19658 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
19661 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
19662 init-only variables, but this path did not take into account that
19663 there might be also instance readonly variables. Correct this
19666 This fixes bug 32253
19668 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
19671 * driver.cs: Change the extension for modules to `netmodule'
19673 * cs-parser.jay: Improved slightly the location tracking for
19674 the debugger symbols.
19676 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
19677 modifiers that were specified instead of the hardcoded value
19678 (FamAndAssem). This was basically ignoring the static modifier,
19679 and others. Fixes 32429.
19681 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
19682 fixed a bug in the process (32476)
19684 * expression.cs (ArrayAccess.EmitAssign): Patch from
19685 hwang_rob@yahoo.ca that fixes bug 31834.3
19687 2002-10-18 Miguel de Icaza <miguel@ximian.com>
19689 * driver.cs: Make the module extension .netmodule.
19691 2002-10-16 Miguel de Icaza <miguel@ximian.com>
19693 * driver.cs: Report an error if the resource file is not found
19694 instead of crashing.
19696 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
19697 false, like Emit does.
19699 2002-10-16 Nick Drochak <ndrochak@gol.com>
19701 * typemanager.cs: Remove unused private member. Also reported mcs
19702 bug to report this as a warning like csc.
19704 2002-10-15 Martin Baulig <martin@gnome.org>
19706 * statement.cs (Statement.Emit): Made this a virtual method; emits
19707 the line number info and calls DoEmit().
19708 (Statement.DoEmit): New protected abstract method, formerly knows
19709 as Statement.Emit().
19711 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
19713 2002-10-11 Miguel de Icaza <miguel@ximian.com>
19715 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
19716 have fixed a remaining problem: not every AddXXXX was adding a
19717 fully qualified name.
19719 Now everyone registers a fully qualified name in the DeclSpace as
19720 being defined instead of the partial name.
19722 Downsides: we are slower than we need to be due to the excess
19723 copies and the names being registered this way.
19725 The reason for this is that we currently depend (on the corlib
19726 bootstrap for instance) that types are fully qualified, because
19727 we dump all the types in the namespace, and we should really have
19728 types inserted into the proper namespace, so we can only store the
19729 basenames in the defined_names array.
19731 2002-10-10 Martin Baulig <martin@gnome.org>
19733 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
19734 from bug #31834, see the bug report for a testcase which is
19737 2002-10-10 Martin Baulig <martin@gnome.org>
19739 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
19740 flow analysis code for this.
19742 * statement.cs (Do, While, For): Tell the flow analysis code about
19744 (FlowBranching.UsageVector): Added support for infinite loops.
19745 (Block.Resolve): Moved the dead code elimination here and use flow
19748 2002-10-09 Miguel de Icaza <miguel@ximian.com>
19750 * class.cs (Field.Define): Catch cycles on struct type
19753 * typemanager.cs (IsUnmanagedtype): Do not recursively check
19754 fields if the fields are static. We only need to check instance
19757 * expression.cs (As.DoResolve): Test for reference type.
19759 * statement.cs (Using.ResolveExpression): Use
19760 ConvertImplicitRequired, not ConvertImplicit which reports an
19762 (Using.ResolveLocalVariableDecls): ditto.
19764 * expression.cs (Binary.ResolveOperator): Report errors in a few
19765 places where we had to.
19767 * typemanager.cs (IsUnmanagedtype): Finish implementation.
19769 2002-10-08 Miguel de Icaza <miguel@ximian.com>
19771 * expression.cs: Use StoreFromPtr instead of extracting the type
19772 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
19774 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
19775 an enumeration value to a System.Enum, but System.Enum is not a
19776 value type, but an class type, so we need to box.
19778 (Expression.ConvertExplicit): One codepath could return
19779 errors but not flag them. Fix this. Fixes #31853
19781 * parameter.cs (Resolve): Do not allow void as a parameter type.
19783 2002-10-06 Martin Baulig <martin@gnome.org>
19785 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
19786 if it's a class type and not a struct. Fixes #31815.
19788 2002-10-06 Martin Baulig <martin@gnome.org>
19790 * statement.cs: Reworked the flow analysis code a bit to make it
19791 usable for dead code elimination.
19793 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19795 * cs-parser.jay: allow empty source files. Fixes bug #31781.
19797 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19799 * expression.cs (ComposedCast.DoResolveType): A quick workaround
19800 to fix the test 165, will investigate deeper.
19802 2002-10-04 Martin Baulig <martin@gnome.org>
19804 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
19805 finally blocks actually work.
19806 (Try.Resolve): We don't need to create a sibling for `finally' if
19807 there is no finally block.
19809 2002-10-04 Martin Baulig <martin@gnome.org>
19811 * class.cs (Constructor.Define): The default accessibility for a
19812 non-default constructor is private, not public.
19814 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19816 * class.cs (Constructor): Make AllowedModifiers public, add
19819 * cs-parser.jay: Perform the modifiers test here, as the
19820 constructor for the Constructor class usually receives a zero
19821 because of the way we create it (first we create, later we
19822 customize, and we were never checking the modifiers).
19824 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
19825 is a version of LookupTypeReflection that includes the type-name
19826 cache. This can be used as a fast path for functions that know
19827 the fully qualified name and are only calling into *.GetType() to
19828 obtain a composed type.
19830 This is also used by TypeManager.LookupType during its type
19833 (LookupType): We now also track the real type name, as sometimes
19834 we can get a quey for the real type name from things like
19835 ComposedCast. This fixes bug 31422.
19837 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
19838 complete type fullname, it does not have to go through the type
19839 resolution system to obtain the composed version of the type (for
19840 obtaining arrays or pointers).
19842 (Conditional.Emit): Use the EmitBoolExpression to
19843 generate nicer code, as requested by Paolo.
19845 (ArrayCreation.CheckIndices): Use the patch from
19846 hwang_rob@yahoo.ca to validate the array initializers.
19848 2002-10-03 Miguel de Icaza <miguel@ximian.com>
19850 * class.cs (ConstructorInitializer.Emit): simplify code by using
19851 Invocation.EmitCall, and at the same time, fix the bugs in calling
19852 parent constructors that took variable arguments.
19854 * ecore.cs (Expression.ConvertNumericExplicit,
19855 Expression.ImplicitNumericConversion): Remove the code that
19856 manually wrapped decimal (InternalTypeConstructor call is now gone
19859 * expression.cs (Cast.TryReduce): Also handle decimal types when
19860 trying to perform a constant fold on the type.
19862 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19864 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19865 that only turned off an error report, and did nothing else.
19867 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19869 * driver.cs: Handle and ignore /fullpaths
19871 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19873 * expression.cs (Binary.ResolveOperator): Catch the case where
19874 DoNumericPromotions returns true,
19876 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19878 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19880 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19883 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19885 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19886 conversion exists, but it is also required that the conversion be
19887 performed. This manifested in "(Type64Enum) 2".
19889 * class.cs (TypeManager.AddMethod): The fix is not to change
19890 AddEnum, because that one was using a fully qualified name (every
19891 DeclSpace derivative does), but to change the AddMethod routine
19892 that was using an un-namespaced name. This now correctly reports
19893 the duplicated name.
19895 Revert patch until I can properly fix it. The issue
19896 is that we have a shared Type space across all namespaces
19897 currently, which is wrong.
19899 Options include making the Namespace a DeclSpace, and merge
19900 current_namespace/current_container in the parser.
19902 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19904 * cs-parser.jay: Improve error reporting when we get a different
19905 kind of expression in local_variable_type and
19906 local_variable_pointer_type.
19908 Propagate this to avoid missleading errors being reported.
19910 * ecore.cs (ImplicitReferenceConversion): treat
19911 TypeManager.value_type as a target just like object_type. As
19916 Is valid, and needs to result in the int 1 being boxed before it
19917 is assigned to the value type v.
19919 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19920 to validate the enumeration name.
19922 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19923 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19924 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19926 * ecore.cs (TryImplicitIntConversion): When doing an
19927 implicit-enumeration-conversion, check if the type is 64-bits and
19928 perform a conversion before passing to EnumConstant.
19930 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19932 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19933 report ambiguous type references. Unlike the MS version, we
19934 report what the ambiguity is. Innovation at work ;-)
19936 (DeclSpace.FindType): Require a location argument to
19937 display when we display an ambiguous error.
19939 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19941 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19943 * expression.cs (EmitDynamicInitializers): Apply patch from
19944 hwang_rob@yahoo.ca that fixes the order in which we emit our
19947 2002-09-21 Martin Baulig <martin@gnome.org>
19949 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19950 delegate takes no arguments.
19952 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19954 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19957 * expression.cs: Extract the underlying type.
19959 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19961 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19963 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19965 * class.cs (TypeContainer.DefineType): We can not use the nice
19966 PackingSize with the size set to 1 DefineType method, because it
19967 will not allow us to define the interfaces that the struct
19970 This completes the fixing of bug 27287
19972 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19973 means also structs. This fixes part of the problem.
19974 (Expresion.ImplicitReferenceConversionExists): ditto.
19976 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
19977 error if there were no errors reported during the type lookup
19978 process, to avoid duplicates or redundant errors. Without this
19979 you would get an ambiguous errors plus a type not found. We have
19980 beaten the user enough with the first error.
19982 (DeclSparce.FindType): Emit a warning if we have an ambiguous
19985 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
19986 during the resolution process, stop the lookup, this avoids
19987 repeated error reports (same error twice).
19989 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
19991 * typemanager.cs (LookupType): Redo the type lookup code to match
19992 the needs of System.Reflection.
19994 The issue is that System.Reflection requires references to nested
19995 types to begin with a "+" sign instead of a dot. So toplevel
19996 types look like: "NameSpace.TopLevelClass", and nested ones look
19997 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
20000 2002-09-19 Martin Baulig <martin@gnome.org>
20002 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
20003 says that a method always returns or always throws an exception,
20004 don't report the CS0161.
20006 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
20007 set `Returns = new_returns'.
20009 2002-09-19 Martin Baulig <martin@gnome.org>
20011 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
20012 to an enum constant, check for a CS0176.
20014 2002-09-18 Miguel de Icaza <miguel@ximian.com>
20016 * class.cs (TypeContainer.CheckPairedOperators): Now we check
20017 for operators that must be in pairs and report errors.
20019 * ecore.cs (SimpleName.DoResolveType): During the initial type
20020 resolution process, when we define types recursively, we must
20021 check first for types in our current scope before we perform
20022 lookups in the enclosing scopes.
20024 * expression.cs (MakeByteBlob): Handle Decimal blobs.
20026 (Invocation.VerifyArgumentsCompat): Call
20027 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
20028 I thought we were supposed to always call this, but there are a
20029 few places in the code where we dont do it.
20031 2002-09-17 Miguel de Icaza <miguel@ximian.com>
20033 * driver.cs: Add support in -linkres and -resource to specify the
20034 name of the identifier.
20036 2002-09-16 Miguel de Icaza <miguel@ximian.com>
20038 * ecore.cs (StandardConversionExists): Sync with the conversion
20039 code: allow anything-* to void* conversions.
20041 (FindMostSpecificSource): Use an Expression argument
20042 instead of a Type, because we might be handed over a Literal which
20043 gets a few more implicit conversions that plain types do not. So
20044 this information was being lost.
20046 Also, we drop the temporary type-holder expression when not
20049 2002-09-17 Martin Baulig <martin@gnome.org>
20051 * class.cs (PropertyBase.CheckBase): Don't check the base class if
20052 this is an explicit interface implementation.
20054 2002-09-17 Martin Baulig <martin@gnome.org>
20056 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
20057 different `IndexerName' attributes.
20059 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
20060 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
20061 virtual CommonResolve().
20063 2002-09-16 Miguel de Icaza <miguel@ximian.com>
20065 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
20066 and convert that to the UnderlyingType.
20068 * statement.cs (Foreach.Resolve): Indexers are just like variables
20069 or PropertyAccesses.
20071 * cs-tokenizer.cs (consume_string): Track line numbers and columns
20072 inside quoted strings, we were not doing this before.
20074 2002-09-16 Martin Baulig <martin@gnome.org>
20076 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
20077 resolve it. This is needed for the definite assignment check of the
20078 instance expression, fixes bug #29846.
20079 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
20081 2002-09-16 Nick Drochak <ndrochak@gol.com>
20083 * parameter.cs: Fix compile error. Cannot reference static member
20084 from an instance object. Is this an mcs bug?
20086 2002-09-14 Martin Baulig <martin@gnome.org>
20088 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
20089 multiple times. Fixes bug #30295, added test-166.cs.
20091 2002-09-14 Martin Baulig <martin@gnome.org>
20093 * statement.cs (Block.Emit): Don't emit unreachable code.
20094 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
20095 `break' statements.
20096 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
20098 2002-09-14 Martin Baulig <martin@gnome.org>
20100 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
20103 2002-09-14 Martin Baulig <martin@gnome.org>
20105 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
20106 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
20107 be false on the ms runtime.
20109 2002-09-13 Martin Baulig <martin@gnome.org>
20111 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
20112 the CS0038 error message.
20114 2002-09-12 Miguel de Icaza <miguel@ximian.com>
20116 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
20117 constant inside, return it.
20119 2002-09-12 Martin Baulig <martin@gnome.org>
20121 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
20122 implicit conversion can be done between enum types.
20124 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
20125 check whether an implicit conversion to the current enum's UnderlyingType
20126 exists and report an error if not.
20128 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
20129 without debugging support.
20131 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
20132 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
20134 2002-09-12 Martin Baulig <martin@gnome.org>
20136 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
20138 * ecore.cs (IMemberExpr.DeclaringType): New property.
20139 (SimpleName.SimpleNameResolve): Check whether we're accessing a
20140 nonstatic member of an outer type (CS0038).
20142 2002-09-11 Miguel de Icaza <miguel@ximian.com>
20144 * driver.cs: Activate the using-error detector at warning level
20145 4 (at least for MS-compatible APIs).
20147 * namespace.cs (VerifyUsing): Small buglett fix.
20149 * pending.cs (PendingImplementation): pass the container pointer.
20151 * interface.cs (GetMethods): Allow for recursive definition. Long
20152 term, I would like to move every type to support recursive
20153 definitions, not the current ordering mechanism that we have right
20156 The situation is this: Attributes are handled before interfaces,
20157 so we can apply attributes to interfaces. But some attributes
20158 implement interfaces, we will now handle the simple cases
20159 (recursive definitions will just get an error).
20161 * parameter.cs: Only invalidate types at the end if we fail to
20164 2002-09-09 Martin Baulig <martin@gnome.org>
20166 * ecore.cs (PropertyExpr.Emit): Also check for
20167 TypeManager.system_int_array_get_length so this'll also work when
20168 compiling corlib. Fixes #30003.
20170 2002-09-09 Martin Baulig <martin@gnome.org>
20172 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
20173 and throw an exception if we can't get the type's size. Fixed #30040,
20176 2002-09-09 Martin Baulig <martin@gnome.org>
20178 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
20180 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
20181 context. Fixes bug #30027.
20183 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
20184 virtual functions. Fixes bug #30043, added test-164.cs.
20186 2002-09-08 Ravi Pratap <ravi@ximian.com>
20188 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
20190 2002-09-08 Nick Drochak <ndrochak@gol.com>
20192 * driver.cs: Use an object to get the windows codepage since it's not a
20195 2002-09-08 Miguel de Icaza <miguel@ximian.com>
20197 * statement.cs (For.Emit): for infinite loops (test == null)
20198 return whether there is a break inside, not always "true".
20200 * namespace.cs (UsingEntry): New struct to hold the name of the
20201 using definition, the location where it is defined, and whether it
20202 has been used in a successful type lookup.
20204 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
20209 2002-09-06 Ravi Pratap <ravi@ximian.com>
20211 * attribute.cs : Fix incorrect code which relied on catching
20212 a NullReferenceException to detect a null being passed in
20213 where an object was expected.
20215 2002-09-06 Miguel de Icaza <miguel@ximian.com>
20217 * statement.cs (Try): flag the catch variable as assigned
20219 * expression.cs (Cast): Simplified by using ResolveType instead of
20220 manually resolving.
20222 * statement.cs (Catch): Fix bug by using ResolveType.
20224 2002-09-06 Ravi Pratap <ravi@ximian.com>
20226 * expression.cs (BetterConversion): Special case for when we have
20227 a NullLiteral as the argument and we have to choose between string
20228 and object types - we choose string the way csc does.
20230 * attribute.cs (Attribute.Resolve): Catch the
20231 NullReferenceException and report error #182 since the Mono
20232 runtime no more has the bug and having this exception raised means
20233 we tried to select a constructor which takes an object and is
20236 2002-09-05 Ravi Pratap <ravi@ximian.com>
20238 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
20239 message (1502, 1503) when we can't locate a method after overload
20240 resolution. This is much more informative and closes the bug
20243 * interface.cs (PopulateMethod): Return if there are no argument
20244 types. Fixes a NullReferenceException bug.
20246 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
20247 expressions too. Previously we were checking only in one place for
20248 positional arguments leaving out named arguments.
20250 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
20251 type to the enum type is not allowed. Remove code corresponding to
20254 (ConvertNumericExplicit): Allow explicit conversions from
20255 the underlying type to enum type. This precisely follows the spec
20256 and closes a bug filed by Gonzalo.
20258 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20261 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
20263 2002-09-03 Miguel de Icaza <miguel@ximian.com>
20265 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
20266 it was important that we stored the right value after the
20267 reduction in `converted'.
20269 2002-09-04 Martin Baulig <martin@gnome.org>
20271 * location.cs (Location.SymbolDocument): Use full pathnames for the
20274 2002-08-30 Miguel de Icaza <miguel@ximian.com>
20276 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
20277 of the expression resolve mechanism, because that will catch the
20278 SimpleName error failures.
20280 (Conditional): If we can not resolve the
20281 expression, return, do not crash.
20283 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20286 (location): display token name instead of its number.
20288 2002-08-28 Martin Baulig <martin@gnome.org>
20290 * expression.cs (Binary.ResolveOperator): Don't silently return
20291 but return an error if an operator cannot be applied between two
20294 2002-08-28 Martin Baulig <martin@gnome.org>
20296 * class.cs (Constructor.Define): Set the permission attributes
20297 correctly instead of making all constructors public.
20299 2002-08-28 Martin Baulig <martin@gnome.org>
20301 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
20302 for private members before reporting a CS0103; if we find anything,
20305 2002-08-28 Martin Baulig <martin@gnome.org>
20307 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
20308 to check whether `closure_start_type == closure_invocation_type',
20309 we also need to check whether `m.DeclaringType == closure_invocation_type'
20310 before bypassing the permission checks. We might be accessing
20311 protected/private members from the base class.
20312 (TypeManager.RealMemberLookup): Only set private_ok if private
20313 members were requested via BindingFlags.NonPublic.
20315 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
20317 * expression.cs (MemberAccess.ResolveMemberAccess): Set
20318 MethodGroupExpr.IsExplicitImpl if appropriate.
20319 (Invocation.DoResolve): Don't report the CS0120 for explicit
20320 interface implementations.
20322 2002-08-27 Martin Baulig <martin@gnome.org>
20324 * expression.cs (Invocation.DoResolve): If this is a static
20325 method and we don't have an InstanceExpression, we must report
20328 2002-08-25 Martin Baulig <martin@gnome.org>
20330 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
20331 `==' between a valuetype and an object.
20333 2002-08-25 Miguel de Icaza <miguel@ximian.com>
20335 * ecore.cs (TypeExpr): Provide a ToString method.
20337 2002-08-24 Martin Baulig <martin@gnome.org>
20339 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
20340 now called proggie.dbg and it's a binary file.
20342 2002-08-23 Martin Baulig <martin@gnome.org>
20344 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
20346 2002-08-23 Martin Baulig <martin@gnome.org>
20348 * struct.cs (MyStructInfo.ctor): Make this work with empty
20349 structs; it's not allowed to use foreach() on null.
20351 2002-08-23 Martin Baulig <martin@gnome.org>
20353 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
20354 writer the full pathname of the generated assembly.
20356 2002-08-23 Martin Baulig <martin@gnome.org>
20358 * statements.cs (FlowBranching.UsageVector.MergeChildren):
20359 A `finally' block never returns or breaks; improved handling of
20362 2002-08-23 Martin Baulig <martin@gnome.org>
20364 * statement.cs (Throw.Resolve): Allow `throw null'.
20366 2002-08-23 Martin Baulig <martin@gnome.org>
20368 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
20369 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
20370 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
20371 MemberLookup would return a wrong event if this is an explicit
20372 interface implementation and the class has an event with the same
20375 2002-08-23 Martin Baulig <martin@gnome.org>
20377 * statement.cs (Block.AddChildVariableNames): New public method.
20378 (Block.AddChildVariableName): Likewise.
20379 (Block.IsVariableNameUsedInChildBlock): Likewise.
20380 (Block.AddVariable): Check whether a variable name has already
20381 been used in a child block.
20383 * cs-parser.jay (declare_local_variables): Mark all variable names
20384 from the current block as being used in a child block in the
20387 2002-08-23 Martin Baulig <martin@gnome.org>
20389 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
20390 find the symbol writer.
20392 * driver.cs: csc also allows the arguments to /define being
20393 separated by commas, not only by semicolons.
20395 2002-08-23 Martin Baulig <martin@gnome.org>
20397 * interface.cs (Interface.GetMembers): Added static check for events.
20399 2002-08-15 Martin Baulig <martin@gnome.org>
20401 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
20402 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
20404 * ecore.cs (Expression.MemberLookup): Added documentation and explained
20405 why the MethodData.EmitDestructor() change was necessary.
20407 2002-08-20 Martin Baulig <martin@gnome.org>
20409 * class.cs (TypeContainer.FindMembers): Added static check for events.
20411 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
20413 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
20414 use Type.GetEvents(), not Type.FindMembers().
20416 2002-08-20 Martin Baulig <martin@gnome.org>
20418 * decl.cs (MemberCache): Added a special method cache which will
20419 be used for method-only searched. This ensures that a method
20420 search will return a MethodInfo with the correct ReflectedType for
20423 2002-08-20 Martin Baulig <martin@gnome.org>
20425 * decl.cs (DeclSpace.FindMembers): Made this public.
20427 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20429 * delegate.cs: fixed build on windows.
20430 [FIXME: Filed as bug #29150: MCS must report these errors.]
20432 2002-08-19 Ravi Pratap <ravi@ximian.com>
20434 * ecore.cs (StandardConversionExists): Return a false
20435 if we are trying to convert the void type to anything else
20436 since that is not allowed.
20438 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
20439 we flag error 70 in the event an event is trying to be accessed
20440 directly from outside the declaring type.
20442 2002-08-20 Martin Baulig <martin@gnome.org>
20444 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
20445 MemberCache from typemanager.cs to decl.cs.
20447 2002-08-19 Martin Baulig <martin@gnome.org>
20449 * class.cs (TypeContainer): Implement IMemberContainer.
20450 (TypeContainer.DefineMembers): Create the MemberCache.
20451 (TypeContainer.FindMembers): Do better BindingFlags checking; only
20452 return public members if BindingFlags.Public was given, check
20453 whether members are static.
20455 2002-08-16 Martin Baulig <martin@gnome.org>
20457 * decl.cs (DeclSpace.Define): Splitted this in Define and
20458 DefineMembers. DefineMembers is called first and initializes the
20461 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
20462 DefineMembers() on all our DeclSpaces.
20464 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
20465 but call DefineMembers() on all nested interfaces. We call their
20466 Define() in our new Define() function.
20468 * interface.cs (Interface): Implement IMemberContainer.
20469 (Interface.Define): Moved all code except the attribute stuf to
20471 (Interface.DefineMembers): Initialize the member cache.
20473 * typemanager.cs (IMemberFinder): Removed this interface, we don't
20474 need this anymore since we can use MemberCache.FindMembers directly.
20476 2002-08-19 Martin Baulig <martin@gnome.org>
20478 * typemanager.cs (MemberCache): When creating the cache for an
20479 interface type, add all inherited members.
20480 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
20481 to `out bool used_cache' and documented it.
20482 (TypeManager.MemberLookup): If we already used the cache in the first
20483 iteration, we don't need to do the interfaces check.
20485 2002-08-19 Martin Baulig <martin@gnome.org>
20487 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
20488 here from IMemberFinder and don't implement this interface anymore.
20489 (DeclSpace.MemberCache): Moved here from IMemberFinder.
20491 * typemanager.cs (IMemberFinder): This interface is now only used by
20492 classes which actually support the member cache.
20493 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
20494 since we only put DeclSpaces into this Hashtable.
20495 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
20496 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
20498 2002-08-16 Martin Baulig <martin@gnome.org>
20500 * typemanager.cs (ICachingMemberFinder): Removed.
20501 (IMemberFinder.MemberCache): New property.
20502 (TypeManager.FindMembers): Merged this with RealFindMembers().
20503 This function will never be called from TypeManager.MemberLookup()
20504 so we can't use the cache here, just the IMemberFinder.
20505 (TypeManager.MemberLookup_FindMembers): Check whether the
20506 IMemberFinder has a MemberCache and call the cache's FindMembers
20508 (MemberCache): Rewrote larger parts of this yet another time and
20509 cleaned it up a bit.
20511 2002-08-15 Miguel de Icaza <miguel@ximian.com>
20513 * driver.cs (LoadArgs): Support quoting.
20515 (Usage): Show the CSC-like command line arguments.
20517 Improved a few error messages.
20519 2002-08-15 Martin Baulig <martin@gnome.org>
20521 * typemanager.cs (IMemberContainer.Type): New property.
20522 (IMemberContainer.IsInterface): New property.
20524 The following changes are conditional to BROKEN_RUNTIME, which is
20525 defined at the top of the file.
20527 * typemanager.cs (MemberCache.MemberCache): Don't add the base
20528 class'es members, but add all members from TypeHandle.ObjectType
20529 if we're an interface.
20530 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
20531 is the current type.
20532 (MemberCache.CacheEntry.Container): Removed this field.
20533 (TypeHandle.GetMembers): Include inherited members.
20535 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20537 * typemanager.cs: fixed compilation and added a comment on a field that
20540 2002-08-15 Martin Baulig <martin@gnome.org>
20542 * class.cs (ConstructorInitializer.Resolve): In the
20543 Expression.MemberLookup call, use the queried_type as
20546 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
20547 declared' attribute, it's always true.
20548 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
20549 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
20550 temporary wrapper for FindMembers which tells MemberLookup whether
20551 members from the base classes are included in the return value.
20552 This will go away soon.
20553 (TypeManager.MemberLookup): Use this temporary hack here; once the
20554 new MemberCache is completed, we don't need to do the DeclaredOnly
20555 looping here anymore since the MemberCache will take care of this.
20556 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
20557 (MemberCache): When creating the MemberCache for a class, get
20558 members from the current class and all its base classes.
20559 (MemberCache.CacheEntry.Container): New field. This is a
20560 temporary hack until the Mono runtime is fixed to distinguish
20561 between ReflectedType and DeclaringType. It allows us to use MCS
20562 with both the MS runtime and the unfixed Mono runtime without
20563 problems and without accecting performance.
20564 (MemberCache.SearchMembers): The DeclaredOnly looping from
20565 TypeManager.MemberLookup is now done here.
20567 2002-08-14 Martin Baulig <martin@gnome.org>
20569 * statement.cs (MyStructInfo.MyStructInfo): Don't call
20570 Type.GetFields on dynamic types but get the fields from the
20571 corresponding TypeContainer.
20572 (MyStructInfo.GetStructInfo): Added check for enum types.
20574 * typemanager.cs (MemberList.IsSynchronized): Implemented.
20575 (MemberList.SyncRoot): Implemented.
20576 (TypeManager.FilterWithClosure): No need to check permissions if
20577 closure_start_type == closure_invocation_type, don't crash if
20578 closure_invocation_type is null.
20580 2002-08-13 Martin Baulig <martin@gnome.org>
20582 Rewrote TypeContainer.FindMembers to use a member cache. This
20583 gives us a speed increase of about 35% for the self-hosting MCS
20584 build and of about 15-20% for the class libs (both on GNU/Linux).
20586 * report.cs (Timer): New class to get enhanced profiling. This
20587 whole class is "TIMER" conditional since it remarkably slows down
20590 * class.cs (MemberList): New class. This is an IList wrapper
20591 which we're now using instead of passing MemberInfo[]'s around to
20592 avoid copying this array unnecessarily.
20593 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
20594 (ICachingMemberFinder, IMemberContainer): New interface.
20595 (TypeManager.FilterWithClosure): If `criteria' is null, the name
20596 has already been checked, otherwise use it for the name comparision.
20597 (TypeManager.FindMembers): Renamed to RealMemberFinder and
20598 provided wrapper which tries to use ICachingMemberFinder.FindMembers
20599 if possible. Returns a MemberList, not a MemberInfo [].
20600 (TypeHandle): New class, implements IMemberContainer. We create
20601 one instance of this class per type, it contains a MemberCache
20602 which is used to do the member lookups.
20603 (MemberCache): New class. Each instance of this class contains
20604 all members of a type and a name-based hash table.
20605 (MemberCache.FindMembers): This is our new member lookup
20606 function. First, it looks up all members of the requested name in
20607 the hash table. Then, it walks this list and sorts out all
20608 applicable members and returns them.
20610 2002-08-13 Martin Baulig <martin@gnome.org>
20612 In addition to a nice code cleanup, this gives us a performance
20613 increase of about 1.4% on GNU/Linux - not much, but it's already
20614 half a second for the self-hosting MCS compilation.
20616 * typemanager.cs (IMemberFinder): New interface. It is used by
20617 TypeManager.FindMembers to call FindMembers on a TypeContainer,
20618 Enum, Delegate or Interface.
20619 (TypeManager.finder_to_member_finder): New PtrHashtable.
20620 (TypeManager.finder_to_container): Removed.
20621 (TypeManager.finder_to_delegate): Removed.
20622 (TypeManager.finder_to_interface): Removed.
20623 (TypeManager.finder_to_enum): Removed.
20625 * interface.cs (Interface): Implement IMemberFinder.
20627 * delegate.cs (Delegate): Implement IMemberFinder.
20629 * enum.cs (Enum): Implement IMemberFinder.
20631 * class.cs (TypeContainer): Implement IMemberFinder.
20633 2002-08-12 Martin Baulig <martin@gnome.org>
20635 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
20637 2002-08-12 Martin Baulig <martin@gnome.org>
20639 * ecore.cs (ITypeExpression): New interface for expressions which
20641 (TypeExpression): Renamed to TypeLookupExpression.
20642 (Expression.DoResolve): If we're doing a types-only lookup, the
20643 expression must implement the ITypeExpression interface and we
20644 call DoResolveType() on it.
20645 (SimpleName): Implement the new ITypeExpression interface.
20646 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
20647 hack, the situation that we're only looking up types can't happen
20648 anymore when this method is called. Moved the type lookup code to
20649 DoResolveType() and call it.
20650 (SimpleName.DoResolveType): This ITypeExpression interface method
20651 is now doing the types-only lookup.
20652 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
20653 (ResolveFlags): Added MaskExprClass.
20655 * expression.cs (MemberAccess): Implement the ITypeExpression
20657 (MemberAccess.DoResolve): Added support for a types-only lookup
20658 when we're called via ITypeExpression.DoResolveType().
20659 (ComposedCast): Implement the ITypeExpression interface.
20661 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
20662 Expression.Resolve() with ResolveFlags.Type instead.
20664 2002-08-12 Martin Baulig <martin@gnome.org>
20666 * interface.cs (Interface.Define): Apply attributes.
20668 * attribute.cs (Attribute.ApplyAttributes): Added support for
20669 interface attributes.
20671 2002-08-11 Martin Baulig <martin@gnome.org>
20673 * statement.cs (Block.Emit): Only check the "this" variable if we
20674 do not always throw an exception.
20676 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
20677 whether the property has a set accessor.
20679 2002-08-11 Martin Baulig <martin@gnome.org>
20681 Added control flow analysis support for structs.
20683 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
20684 with control flow analysis turned off.
20685 (IVariable): New interface.
20686 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
20687 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
20688 (FieldExpr.DoResolve): Resolve the instance expression with flow
20689 analysis turned off and do the definite assignment check after the
20690 resolving when we know what the expression will resolve to.
20692 * expression.cs (LocalVariableReference, ParameterReference):
20693 Implement the new IVariable interface, only call the flow analysis
20694 code if ec.DoFlowAnalysis is true.
20695 (This): Added constructor which takes a Block argument. Implement
20696 the new IVariable interface.
20697 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
20698 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
20699 This does the definite assignment checks for struct members.
20701 * class.cs (Constructor.Emit): If this is a non-static `struct'
20702 constructor which doesn't have any initializer, call
20703 Block.AddThisVariable() to tell the flow analysis code that all
20704 struct elements must be initialized before control returns from
20707 * statement.cs (MyStructInfo): New public class.
20708 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
20709 argument to this indexer. If non-zero, check an individual struct
20710 member, not the whole struct.
20711 (FlowBranching.CheckOutParameters): Check struct members.
20712 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
20713 overloaded versions of these methods which take an additional
20714 `int field_idx' argument to check struct members.
20715 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
20716 overloaded versions of these methods which take an additional
20717 `string field_name' argument to check struct member.s
20718 (VariableInfo): Implement the IVariable interface.
20719 (VariableInfo.StructInfo): New public property. Returns the
20720 MyStructInfo instance of the variable if it's a struct or null.
20721 (Block.AddThisVariable): New public method. This is called from
20722 Constructor.Emit() for non-static `struct' constructor which do
20723 not have any initializer. It creates a special variable for the
20724 "this" instance variable which will be checked by the flow
20725 analysis code to ensure that all of the struct's fields are
20726 initialized before control returns from the constructor.
20727 (UsageVector): Added support for struct members. If a
20728 variable/parameter is a struct with N members, we reserve a slot
20729 in the usage vector for each member. A struct is considered fully
20730 initialized if either the struct itself (slot 0) or all its
20731 members are initialized.
20733 2002-08-08 Martin Baulig <martin@gnome.org>
20735 * driver.cs (Driver.MainDriver): Only report an error CS5001
20736 if there were no compilation errors.
20738 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
20739 `UnsafeContext' property to determine whether the parent is in
20740 unsafe context rather than checking the parent's ModFlags:
20741 classes nested in an unsafe class are unsafe as well.
20743 2002-08-08 Martin Baulig <martin@gnome.org>
20745 * statement.cs (UsageVector.MergeChildren): Distinguish between
20746 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
20747 we return. Added test17() and test18() to test-154.cs.
20749 2002-08-08 Martin Baulig <martin@gnome.org>
20751 * typemanager.cs (TypeManager.FilterWithClosure): If we have
20752 Family access, make sure the invoking type isn't a subclass of the
20753 queried type (that'd be a CS1540).
20755 * ecore.cs (Expression.MemberLookup): Added overloaded version of
20756 this method which takes an additional `Type invocation_type'.
20758 * expression.cs (BaseAccess.DoResolve): Use the base type as
20759 invocation and query type.
20760 (MemberAccess.DoResolve): If the lookup failed and we're about to
20761 report a CS0122, try a lookup with the ec.ContainerType - if this
20762 succeeds, we must report a CS1540.
20764 2002-08-08 Martin Baulig <martin@gnome.org>
20766 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
20767 (MethodGroupExpr): Implement the IMemberExpr interface.
20769 * expression (MemberAccess.ResolveMemberAccess): No need to have
20770 any special code for MethodGroupExprs anymore, they're now
20773 2002-08-08 Martin Baulig <martin@gnome.org>
20775 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
20776 Family, FamANDAssem and FamORAssem permissions.
20777 (TypeManager.IsSubclassOrNestedChildOf): New public method.
20779 2002-08-08 Martin Baulig <martin@gnome.org>
20781 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
20782 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
20785 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
20787 * driver.cs: implemented /resource option to embed managed resources.
20789 2002-08-07 Martin Baulig <martin@gnome.org>
20791 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
20792 (FieldBase.HasFieldInitializer): New public property.
20793 (FieldBase.GetInitializerExpression): New public method. Resolves and
20794 returns the field initializer and makes sure it is only resolved once.
20795 (TypeContainer.EmitFieldInitializers): Call
20796 FieldBase.GetInitializerExpression to get the initializer, this ensures
20797 that it isn't resolved multiple times.
20799 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
20800 the resolving process (SimpleName/MemberLookup) that we're currently
20801 emitting a field initializer (which must not access any instance members,
20802 this is an error CS0236).
20804 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
20805 argument, if the `IsFieldInitializer' flag is set, we must report and
20806 error CS0236 and not an error CS0120.
20808 2002-08-07 Martin Baulig <martin@gnome.org>
20810 * ecore.cs (IMemberExpr): New public interface.
20811 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
20812 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
20813 if the expression is an IMemberExpr.
20815 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
20816 to be null, implicitly default to `this' if we're non-static in
20817 this case. Simplified the code a lot by using the new IMemberExpr
20818 interface. Also fixed bug #28176 here.
20820 2002-08-06 Martin Baulig <martin@gnome.org>
20822 * cs-parser.jay (SimpleLookup): Removed. We need to create
20823 ParameterReferences during semantic analysis so that we can do a
20824 type-only search when resolving Cast, TypeOf and SizeOf.
20825 (block): Pass the `current_local_parameters' to the Block's
20828 * class.cs (ConstructorInitializer): Added `Parameters parameters'
20829 argument to the constructor.
20830 (ConstructorInitializer.Resolve): Create a temporary implicit
20831 block with the parameters.
20833 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
20834 references here if we aren't doing a type-only search.
20836 * statement.cs (Block): Added constructor which takes a
20837 `Parameters parameters' argument.
20838 (Block.Parameters): New public property.
20840 * support.cs (InternalParameters.Parameters): Renamed `parameters'
20841 to `Parameters' and made it public readonly.
20843 2002-08-06 Martin Baulig <martin@gnome.org>
20845 * ecore.cs (Expression.Warning): Made this public as well.
20847 * report.cs (Report.Debug): Print the contents of collections.
20849 2002-08-06 Martin Baulig <martin@gnome.org>
20851 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
20852 used to tell Resolve() which kinds of expressions it may return.
20853 (Expression.Resolve): Added overloaded version of this method which
20854 takes a `ResolveFlags flags' argument. This can be used to tell
20855 Resolve() which kinds of expressions it may return. Reports a
20857 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20858 ResolveFlags.SimpleName.
20859 (Expression.Error118): Added overloaded version of this method which
20860 takes a `ResolveFlags flags' argument. It uses the flags to determine
20861 which kinds of expressions are allowed.
20863 * expression.cs (Argument.ResolveMethodGroup): New public method.
20864 Resolves an argument, but allows a MethodGroup to be returned.
20865 This is used when invoking a delegate.
20867 * TODO: Updated a bit.
20869 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20871 Fixed compilation with csc.
20873 * ecore.cs: Expression.Error made public. Is this correct? Should
20874 Warning be made public too?
20876 * expression.cs: use ea.Location instead of ea.loc.
20877 [FIXME: Filed as bug #28607: MCS must report these errors.]
20879 2002-08-06 Martin Baulig <martin@gnome.org>
20881 * ecore.cs (Expression.loc): Moved the location here instead of
20882 duplicating it in all derived classes.
20883 (Expression.Location): New public property.
20884 (Expression.Error, Expression.Warning): Made them non-static and
20885 removed the location argument.
20886 (Expression.Warning): Added overloaded version which takes an
20887 `int level' argument.
20888 (Expression.Error118): Make this non-static and removed the
20889 expression and location arguments.
20890 (TypeExpr): Added location argument to the constructor.
20892 * expression.cs (StaticCallExpr): Added location argument to
20894 (Indirection, PointerArithmetic): Likewise.
20895 (CheckedExpr, UnCheckedExpr): Likewise.
20896 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20897 (StringPtr): Likewise.
20900 2002-08-05 Martin Baulig <martin@gnome.org>
20902 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20904 * assign.cs (Assign.DoResolve): Check whether the source
20905 expression is a value or variable.
20907 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20908 while resolving the corresponding blocks.
20910 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20911 an error, don't silently return null.
20913 * statement.cs (Block.AddVariable): Do the error reporting here
20914 and distinguish between CS0128 and CS0136.
20915 (Block.DoResolve): Report all unused labels (warning CS0164).
20916 (LabeledStatement): Pass the location to the constructor.
20917 (LabeledStatement.HasBeenReferenced): New property.
20918 (LabeledStatement.Resolve): Set it to true here.
20920 * statement.cs (Return.Emit): Return success even after reporting
20921 a type mismatch error (CS0126 or CS0127), this is what csc does and
20922 it avoids confusing the users with any consecutive errors.
20924 2002-08-05 Martin Baulig <martin@gnome.org>
20926 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20928 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20930 * expression.cs (MemberAccess.DoResolve): Silently return if an
20931 error has already been reported.
20933 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20934 error has already been reported.
20936 2002-08-05 Martin Baulig <martin@gnome.org>
20938 * statement.cs (UsageVector): Only initialize the `parameters'
20939 vector if we actually have any "out" parameters.
20941 2002-08-05 Martin Baulig <martin@gnome.org>
20943 * expression.cs (Binary.ResolveOperator): When combining delegates,
20944 they must have the same type.
20946 2002-08-05 Martin Baulig <martin@gnome.org>
20948 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20949 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20950 work with the ms runtime and we also don't need it: if we're a
20951 PropertyBuilder and not in the `indexer_arguments' hash, then we
20952 are a property and not an indexer.
20954 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20955 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20956 since the latter one doesn't work with the ms runtime.
20958 2002-08-03 Martin Baulig <martin@gnome.org>
20960 Fixed bugs #27998 and #22735.
20962 * class.cs (Method.IsOperator): New public field.
20963 (Method.CheckBase): Report CS0111 if there's already a method
20964 with the same parameters in the current class. Report CS0508 when
20965 attempting to change the return type of an inherited method.
20966 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20967 and it's not marked abstract or extern.
20968 (PropertyBase): New abstract base class for Property and Indexer.
20969 (PropertyBase.CheckBase): Moved here from Property and made it work
20971 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20972 the same so we can reuse it there.
20973 (Property, Indexer): Derive from PropertyBase.
20974 (MethodSignature.inheritable_property_signature_filter): New delegate
20975 to find properties and indexers.
20977 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
20978 argument and improved error reporting.
20980 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
20981 EmptyReadOnlyParameters and made it a property.
20983 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
20984 version of this method which takes a `PropertyInfo indexer'.
20985 (TypeManager.RegisterIndexer): New method.
20987 * class.cs: Added myself as author of this file :-)
20989 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20991 * class.cs: fixed compilation on windoze.
20993 2002-08-03 Martin Baulig <martin@gnome.org>
20995 * interface.cs (Interface.GetInterfaceBases): Check whether all
20996 base interfaces are at least as accessible than the current one.
20998 * class.cs (TypeContainer.GetClassBases): Check whether base types
20999 are at least as accessible than the current type.
21000 (TypeContainer.AsAccessible): Implemented and made non-static.
21001 (MemberBase.CheckParameters): Report errors if the accessibility
21004 * delegate.cs (Delegate.Delegate): The default visibility is
21005 internal for top-level types and private for nested types.
21006 (Delegate.Define): Report errors if the accessibility checks fail.
21008 * enum.cs (Enum.Enum): The default visibility is internal for
21009 top-level types and private for nested types.
21010 (Enum.DefineType): Compute the correct visibility.
21012 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
21013 function which takes a `bool is_toplevel' instead of a TypeContainer.
21015 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
21018 2002-08-02 Martin Baulig <martin@gnome.org>
21020 * expression.cs (LocalVariableReferenc): Added constructor which
21021 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
21022 (LocalVariableReference.IsReadOnly): New property.
21023 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
21024 variable is readonly, use our own readonly flag to do this; you can
21025 use the new constructor to get a writable reference to a read-only
21028 * cs-parser.jay (foreach_statement, using_statement): Get a writable
21029 reference to the local variable.
21031 2002-08-01 Miguel de Icaza <miguel@ximian.com>
21033 * rootcontext.cs (ResolveCore): Also include System.Exception
21035 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
21036 we reach an EmptyStatement.
21038 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
21041 * expression.cs (Binary.ResolveOperator): Check error result in
21044 use brtrue/brfalse directly and avoid compares to null.
21046 2002-08-02 Martin Baulig <martin@gnome.org>
21048 * class.cs (TypeContainer.Define): Define all nested interfaces here.
21049 Fixes bug #28407, added test-155.cs.
21051 2002-08-01 Martin Baulig <martin@gnome.org>
21053 * class.cs (Event.EmitDefaultMethod): Make this work with static
21054 events. Fixes #28311, added verify-3.cs.
21056 2002-08-01 Martin Baulig <martin@gnome.org>
21058 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
21059 `is_disposable' fields.
21060 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
21061 `hm.is_disposable' if we're using the collection pattern.
21062 (Foreach.EmitCollectionForeach): Use the correct type for the
21063 enumerator's local variable, only emit the try/finally block if
21064 necessary (fixes #27713).
21066 2002-08-01 Martin Baulig <martin@gnome.org>
21068 * ecore.cs (Expression.report118): Renamed to Error118 and made
21071 * statement.cs (Throw.Resolve): Check whether the expression is of
21072 the correct type (CS0118) and whether the type derives from
21073 System.Exception (CS0155).
21074 (Catch.Resolve): New method. Do the type lookup here and check
21075 whether it derives from System.Exception (CS0155).
21076 (Catch.CatchType, Catch.IsGeneral): New public properties.
21078 * typemanager.cs (TypeManager.exception_type): Added.
21080 2002-07-31 Miguel de Icaza <miguel@ximian.com>
21082 * driver.cs: Updated About function.
21084 2002-07-31 Martin Baulig <martin@gnome.org>
21086 Implemented Control Flow Analysis.
21088 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
21089 (EmitContext.CurrentBranching): Added.
21090 (EmitContext.StartFlowBranching): Added.
21091 (EmitContext.EndFlowBranching): Added.
21092 (EmitContext.KillFlowBranching): Added.
21093 (EmitContext.IsVariableAssigned): Added.
21094 (EmitContext.SetVariableAssigned): Added.
21095 (EmitContext.IsParameterAssigned): Added.
21096 (EmitContext.SetParameterAssigned): Added.
21097 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
21098 Added control flow analysis stuff here.
21100 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
21101 resolve the expression as lvalue.
21102 (LocalVariableReference.DoResolve): Check whether the variable has
21103 already been assigned.
21104 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
21105 the parameter as assigned here.
21106 (ParameterReference.DoResolve): Check whether the parameter has already
21108 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
21109 expression as lvalue.
21111 * statement.cs (FlowBranching): New class for the flow analysis code.
21112 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
21113 (LabeledStatement.IsDefined): New public property.
21114 (LabeledStatement.AddUsageVector): New public method to tell flow
21115 analyis that the label may be reached via a forward jump.
21116 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
21118 (VariableInfo.Number): New public field. This is used by flow analysis
21119 to number all locals of a block.
21120 (Block.CountVariables): New public property. This is the number of
21121 local variables in this block (including the locals from all parent
21123 (Block.EmitMeta): Number all the variables.
21125 * statement.cs: Added flow analysis support to all classes.
21127 2002-07-31 Martin Baulig <martin@gnome.org>
21129 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
21130 To get debugging messages, compile mcs with /define:MCS_DEBUG and
21131 then use this argument.
21133 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
21135 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
21136 use this to specify /define options.
21138 2002-07-29 Martin Baulig <martin@gnome.org>
21140 * statement.cs (Fixed): Moved all code that does variable lookups
21141 and resolvings from Emit to Resolve.
21143 * statement.cs (For): Moved all code that does variable lookups
21144 and resolvings from Emit to Resolve.
21146 * statement.cs (Using): Moved all code that does variable lookups
21147 and resolvings from Emit to Resolve.
21149 2002-07-29 Martin Baulig <martin@gnome.org>
21151 * attribute.cs (Attribute.Resolve): Explicitly catch a
21152 System.NullReferenceException when creating the
21153 CustromAttributeBuilder and report a different warning message.
21155 2002-07-29 Martin Baulig <martin@gnome.org>
21157 * support.cs (ParameterData.ParameterName): Added method to
21158 get the name of a parameter.
21160 * typemanager.cs (TypeManager.IsValueType): New public method.
21162 2002-07-29 Martin Baulig <martin@gnome.org>
21164 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
21165 is a flag which specifies that it's either ref or out.
21166 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
21167 the out parameter to `out Parameter.Modifier mod', also set the
21168 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
21170 * support.cs (InternalParameters.ParameterModifier): Distinguish
21171 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21172 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21174 * expression.cs (Argument.GetParameterModifier): Distinguish
21175 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21176 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21178 2002-07-29 Martin Baulig <martin@gnome.org>
21180 * expression.cs (ParameterReference.ParameterReference): Added
21181 `Location loc' argument to the constructor.
21183 * cs-parser.jay: Pass location to ParameterReference.
21185 2002-07-28 Miguel de Icaza <miguel@ximian.com>
21187 * statement.cs (Try): Initialize the location.
21189 * cs-parser.jay: pass location to Try.
21191 * expression.cs (Unary.Reduce): Change the prototype to return
21192 whether a constant fold could be performed or not. The result is
21193 returned in an out parameters. In the case of Indirection and
21194 AddressOf, we want to perform the full tests.
21196 2002-07-26 Miguel de Icaza <miguel@ximian.com>
21198 * statement.cs (Statement.Emit): Flag dead code.
21200 2002-07-27 Andrew Birkett <andy@nobugs.org>
21202 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
21204 2002-07-27 Martin Baulig <martin@gnome.org>
21206 * class.cs (MethodData.Define): Put back call to
21207 TypeManager.AddMethod(), accidentally commented this out.
21209 * report.cs (Debug): New public method to print debugging information,
21210 this is `[Conditional ("DEBUG")]'.
21212 2002-07-26 Martin Baulig <martin@gnome.org>
21214 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
21215 (switch_statement): Push the current_block to the switch_stack and
21216 pop it again when we're done with the switch.
21217 (switch_section): The new block is a child of the current_block.
21218 Fixes bug #24007, added test-152.cs.
21220 2002-07-27 Martin Baulig <martin@gnome.org>
21222 * expression.cs (Invocation.EmitArguments): When calling a varargs
21223 function with only its fixed arguments, we need to pass an empty
21226 2002-07-27 Martin Baulig <martin@gnome.org>
21228 Mono 0.13 has been released.
21230 2002-07-25 Miguel de Icaza <miguel@ximian.com>
21232 * driver.cs: Rename --resource to --linkres, because that is what
21233 we do currently, we dont support --resource yet.
21235 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
21237 2002-07-25 Martin Baulig <martin@gnome.org>
21239 * class.cs (MethodData): New public class. This is a `method builder'
21240 class for a method or one accessor of a Property/Indexer/Event.
21241 (MethodData.GetMethodFlags): Moved here from MemberBase.
21242 (MethodData.ApplyAttributes): Likewise.
21243 (MethodData.ApplyObsoleteAttribute): Likewise.
21244 (MethodData.ApplyConditionalAttribute): Likewise.
21245 (MethodData.ApplyDllImportAttribute): Likewise.
21246 (MethodData.CheckAbstractAndExternal): Likewise.
21247 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
21248 (MethodData.Emit): Formerly known as Method.Emit().
21249 (MemberBase): Moved everything which was specific to a single
21250 accessor/method to MethodData.
21251 (Method): Create a new MethodData and call Define() and Emit() on it.
21252 (Property, Indexer, Event): Create a new MethodData objects for each
21253 accessor and call Define() and Emit() on them.
21255 2002-07-25 Martin Baulig <martin@gnome.org>
21257 Made MethodCore derive from MemberBase to reuse the code from there.
21258 MemberBase now also checks for attributes.
21260 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
21261 (MemberBase.GetMethodFlags): Moved here from class Method and marked
21263 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
21264 `CallingConventions cc' and `Attributes opt_attrs' arguments.
21265 (MemberBase.ApplyAttributes): New virtual method; applies the
21266 attributes to a method or accessor.
21267 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
21268 (MemberBase.ApplyConditionalAttribute): Likewise.
21269 (MemberBase.ApplyDllImportAttribute): Likewise.
21270 (MemberBase.CheckAbstractAndExternal): Likewise.
21271 (MethodCore.ParameterTypes): This is now a property instead of a
21272 method, it's initialized from DoDefineParameters().
21273 (MethodCore.ParameterInfo): Removed the set accessor.
21274 (MethodCore.DoDefineParameters): New protected virtual method to
21275 initialize ParameterTypes and ParameterInfo.
21276 (Method.GetReturnType): We can now simply return the MemberType.
21277 (Method.GetMethodFlags): Override the MemberBase version and add
21278 the conditional flags.
21279 (Method.CheckBase): Moved some code from Define() here, call
21280 DoDefineParameters() here.
21281 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
21282 here to avoid some larger code duplication.
21283 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
21284 ensure that abstract and external accessors don't declare a body.
21286 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
21287 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
21288 lookup in the attribute's parent classes, so we need to abort as soon
21289 as we found the first match.
21290 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
21291 the attribute has no arguments.
21293 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
21296 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21298 * cs-parser.jay: reverted previous patch.
21300 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21302 * cs-parser.jay: fixed bug #22119.
21304 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21306 * attribute.cs: fixed compilation. The error was:
21307 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
21308 be assigned to before control leaves the current method."
21309 [FIXME: Filed as bug #28186: MCS must report this error.]
21311 2002-07-25 Martin Baulig <martin@gnome.org>
21313 * attribute.cs (Attribute.Conditional_GetConditionName): New static
21314 method to pull the condition name ouf of a Conditional attribute.
21315 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
21316 the obsolete message and error flag out of an Obsolete attribute.
21318 * class.cs (Method.GetMethodFlags): New public method to get the
21319 TypeManager.MethodFlags for this method.
21320 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
21322 (Method.Define): Get and apply the Obsolete and Conditional attributes;
21323 if we're overriding a virtual function, set the new private variable
21324 `parent_method'; call the new TypeManager.AddMethod().
21326 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
21327 the MethodBuilder and the Method in a PtrHashtable.
21328 (TypeManager.builder_to_method): Added for this purpose.
21329 (TypeManager.MethodFlags): Added IsObsoleteError.
21330 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
21331 Obsolete and Conditional arguments in MethodBuilders. If we discover
21332 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
21333 the message from the attribute.
21335 2002-07-24 Martin Baulig <martin@gnome.org>
21337 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
21338 preprocessor directives, ensure that the argument to #define/#undef is
21339 exactly one identifier and that it's actually an identifier.
21341 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
21344 2002-07-24 Martin Baulig <martin@gnome.org>
21346 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
21347 initialize it to TypeManager.object_type in the constructor.
21348 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
21349 of the `hm.get_current' method if we're using the collection pattern.
21350 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
21351 for the explicit conversion to make it work when we're using the collection
21352 pattern and the `Current' property has a different return type than `object'.
21355 2002-07-24 Martin Baulig <martin@gnome.org>
21357 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
21358 does not match, but don't report any errors. This method is called in
21359 order for all methods in a MethodGroupExpr until a matching method is
21360 found, so we don't want to bail out if the first method doesn't match.
21361 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
21362 matches, report the 123. Fixes #28070.
21364 2002-07-24 Martin Baulig <martin@gnome.org>
21366 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
21367 TypeManager.TypeToCoreType() to the top of the method so the
21368 following equality checks will work. Fixes #28107.
21370 2002-07-24 Martin Baulig <martin@gnome.org>
21372 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
21373 operand is of type uint, and the other operand is of type sbyte,
21374 short or int, the operands are converted to type long." -
21375 Actually do what this comment already told us. Fixes bug #28106,
21378 2002-07-24 Martin Baulig <martin@gnome.org>
21380 * class.cs (MethodBase): New abstract class. This is now a base
21381 class for Property, Indexer and Event to avoid some code duplication
21382 in their Define() and DefineMethods() methods.
21383 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
21384 generic methods for Define() and DefineMethods().
21385 (FieldBase): Derive from MemberBase, not MemberCore.
21386 (Property): Derive from MemberBase, not MemberCore.
21387 (Property.DefineMethod): Moved all the code from this method to the
21388 new MethodBase.DefineAccessor(), just call it with appropriate
21390 (Property.Define): Call the new Property.DoDefine(), this does some
21391 sanity checks and we don't need to duplicate the code everywhere.
21392 (Event): Derive from MemberBase, not MemberCore.
21393 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
21394 accessors, this will also make them work with interface events.
21395 (Indexer): Derive from MemberBase, not MemberCore.
21396 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
21397 (Indexer.Define): Use the new MethodBase functions.
21399 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
21400 argument to the constructor.
21401 (Interface.FindMembers): Added support for interface events.
21402 (Interface.PopluateEvent): Implemented.
21404 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
21406 2002-07-22 Miguel de Icaza <miguel@ximian.com>
21408 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
21409 but this is required to check for a method name being the same as
21410 the containing class.
21414 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21416 * interface.cs: initialize variable.
21418 2002-07-23 Martin Baulig <martin@gnome.org>
21420 Implemented the IndexerName attribute in interfaces.
21422 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
21423 name if this is an explicit interface implementation.
21424 (Indexer.InterfaceIndexerName): New public variable. If we're
21425 implementing an interface indexer, this is the IndexerName in that
21426 interface. Otherwise, it's the IndexerName.
21427 (Indexer.DefineMethod): If we're implementing interface indexer,
21428 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
21429 and Pending.ImplementIndexer methods.
21430 (Indexer.Define): Also define the PropertyBuilder if we're
21431 implementing an interface indexer and this is neither an explicit
21432 interface implementation nor do the IndexerName match the one in
21435 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
21436 If a method is defined here, then we always need to create a proxy
21437 for it. This is used when implementing interface indexers.
21438 (Pending.IsInterfaceIndexer): New public method.
21439 (Pending.ImplementIndexer): New public method.
21440 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
21441 This is used when implementing interface indexers to define a proxy
21443 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
21444 define a proxy if necessary.
21446 * interface.cs (Interface.IndexerName): New public variable.
21447 (Interface.PopulateIndexer): Set the IndexerName.
21448 (Interface.DefineIndexers): New private method. Populate all the
21449 indexers and make sure their IndexerNames match.
21451 * typemanager.cs (IndexerPropertyName): Added support for interface
21454 2002-07-22 Martin Baulig <martin@gnome.org>
21456 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
21457 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
21458 ret if HasReturnLabel.
21459 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
21462 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
21463 and set the ec.LoopBeginTryCatchLevel.
21464 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
21465 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
21466 the current ec.TryCatchLevel, the branch goes out of an exception
21467 block. In this case, we need to use Leave and not Br.
21469 2002-07-22 Martin Baulig <martin@gnome.org>
21471 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
21472 block unless the block does not always return or it is contained in
21473 another try { ... } catch { ... } block. Fixes bug #26506.
21474 Added verify-1.cs to the test suite.
21476 2002-07-22 Martin Baulig <martin@gnome.org>
21478 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
21479 then we do not always return. Fixes bug #24985.
21481 2002-07-22 Martin Baulig <martin@gnome.org>
21483 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
21484 lookup on a per-class level; ie. walk up the class hierarchy until we
21485 found at least one applicable method, then choose the best among them.
21486 Fixes bug #24463 and test-29.cs.
21488 2002-07-22 Martin Baulig <martin@gnome.org>
21490 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
21491 return types of the methods. The return type is not part of the
21492 signature and we must not check it to make the `new' modifier work.
21493 Fixes bug #27999, also added test-147.cs.
21494 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
21496 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
21497 on the method's return type.
21499 2002-07-21 Martin Baulig <martin@gnome.org>
21501 * assign.cs: Make this work if the rightmost source is a constant and
21502 we need to do an implicit type conversion. Also adding a few more tests
21503 to test-38.cs which should have caught this.
21505 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
21506 target in the makefile for this. The makefile.gnu is primarily intended
21507 for end-users who don't want to debug the compiler.
21509 2002-07-21 Martin Baulig <martin@gnome.org>
21511 * assign.cs: Improved the Assign class so it can now handle embedded
21512 assignments (X = Y = Z = something). As a side-effect this'll now also
21513 consume less local variables. test-38.cs now passes with MCS, added
21514 a few new test cases to that test.
21516 2002-07-20 Martin Baulig <martin@gnome.org>
21518 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
21519 instructions. Fixes bug #27977, also added test-146.cs.
21521 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21523 * cs-tokenizer.cs: fixed getHex ().
21525 2002-07-19 Martin Baulig <martin@gnome.org>
21527 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
21528 not Type.GetType() to lookup the array type. This is needed when
21529 we're constructing an array of a user-defined type.
21530 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
21531 single-dimensional arrays, but also for single-dimensial arrays of
21534 2002-07-19 Martin Baulig <martin@gnome.org>
21536 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
21537 this function is called, it's not allowed to share LocalBuilders
21538 among ILGenerators.
21540 2002-07-19 Martin Baulig <martin@gnome.org>
21542 * expression.cs (Argument.Resolve): Report an error 118 when trying
21543 to pass a type as argument.
21545 2002-07-18 Martin Baulig <martin@gnome.org>
21547 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
21548 Conv_R_Un for the signed `long' type.
21550 2002-07-15 Miguel de Icaza <miguel@ximian.com>
21552 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
21553 `expr' for the temporary result, as that will fail if we do
21554 multiple resolves on the same expression.
21556 2002-07-05 Miguel de Icaza <miguel@ximian.com>
21558 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
21559 ec.TypeContainer for looking up aliases.
21561 * class.cs (TypeContainer): Remove LookupAlias from here.
21563 * decl.cs (DeclSpace); Move here.
21565 2002-07-01 Miguel de Icaza <miguel@ximian.com>
21567 * class.cs (FindMembers): Only call filter if the constructor
21568 bulider is not null.
21570 Also handle delegates in `NestedTypes' now. Now we will perform
21571 type lookups using the standard resolution process. This also
21574 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
21575 This uses Expressions (the limited kind that can be parsed by the
21576 tree) instead of strings.
21578 * expression.cs (ComposedCast.ToString): Implement, used to flag
21579 errors since now we have to render expressions.
21581 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
21584 * ecore.cs (SimpleName.ToString): ditto.
21586 * cs-parser.jay: Instead of using strings to assemble types, use
21587 Expressions to assemble the type (using SimpleName, ComposedCast,
21588 MemberAccess). This should fix the type lookups in declarations,
21589 because we were using a different code path for this.
21591 * statement.cs (Block.Resolve): Continue processing statements
21592 even when there is an error.
21594 2002-07-17 Miguel de Icaza <miguel@ximian.com>
21596 * class.cs (Event.Define): Also remove the `remove' method from
21597 the list of pending items.
21599 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
21600 generate more compact code.
21602 2002-07-17 Martin Baulig <martin@gnome.org>
21604 * const.cs (Const.LookupConstantValue): Add support for constant
21605 `unchecked' and `checked' expressions.
21606 Also adding test case test-140.cs for this.
21608 2002-07-17 Martin Baulig <martin@gnome.org>
21610 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
21611 check whether mi.ReturnType implements the IEnumerator interface; the
21612 `==' and the IsAssignableFrom() will fail in this situation.
21614 2002-07-16 Ravi Pratap <ravi@ximian.com>
21616 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
21619 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21621 * expression.cs: fixed bug #27811.
21623 2002-07-14 Miguel de Icaza <miguel@ximian.com>
21625 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
21626 Molaro: when we are a ref, the value already contains a pointer
21627 value, do not take the address of it.
21629 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21630 * removed mb-parser.jay and mb-tokenizer.cs
21632 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21634 * expression.cs: check against the building corlib void type.
21636 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
21638 * ecore.cs: fix for valuetype static readonly fields: when
21639 initializing them, we need their address, not the address of a copy.
21641 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
21643 * typemanager.cs: register also enum_type in corlib.
21645 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21647 * class.cs: allow calling this (but not base) initializers in structs.
21649 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
21651 * ecore.cs: make sure we compare against the building base types
21654 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
21656 * typemanager.cs: fix TypeToCoreType() to handle void and object
21657 (corlib gets no more typerefs after this change).
21659 2002-07-12 Miguel de Icaza <miguel@ximian.com>
21661 * expression.cs (ArrayCreation.EmitArrayArguments): use
21662 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
21664 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
21665 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
21666 array indexes, the runtime actually forbids them.
21668 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
21669 for array arguments here.
21671 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
21672 instead of the default for ValueTypes.
21674 (New.DoEmit): Use IsValueType instead of
21675 IsSubclassOf (value_type)
21676 (New.DoResolve): ditto.
21677 (Invocation.EmitCall): ditto.
21679 * assign.cs (Assign): ditto.
21681 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
21682 Statements *are* currently doing part of their resolution during
21685 Expressions do always resolve during resolve, but statements are
21686 only required to propagate resolution to their children.
21688 2002-07-11 Miguel de Icaza <miguel@ximian.com>
21690 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
21692 (LoadAssembly): Do not add the dll if it is already specified
21694 (MainDriver): Add the System directory to the link path at the end,
21695 after all the other -L arguments.
21697 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
21698 wrong opcode for loading bytes and bools (ldelem.i1 instead of
21699 ldelem.u1) and using the opposite for sbytes.
21701 This fixes Digger, and we can finally run it.
21703 * driver.cs (UnixParseOption): Move the option parsing here.
21704 (CSCParseOption): Implement CSC-like parsing of options.
21706 We now support both modes of operation, the old Unix way, and the
21707 new CSC-like way. This should help those who wanted to make cross
21708 platform makefiles.
21710 The only thing broken is that /r:, /reference: and /lib: are not
21711 implemented, because I want to make those have the same semantics
21712 as the CSC compiler has, and kill once and for all the confussion
21713 around this. Will be doing this tomorrow.
21715 * statement.cs (Unsafe.Resolve): The state is checked during
21716 resolve, not emit, so we have to set the flags for IsUnsfe here.
21718 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21720 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
21721 not catch the Error_ObjectRefRequired in SimpleName (as it is
21722 possible to have a class/instance variable name that later gets
21723 deambiguated), we have to check this here.
21725 2002-07-10 Ravi Pratap <ravi@ximian.com>
21727 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
21728 make static and put into Expression.
21730 (Event.Define): Register the private field of the event with the
21731 TypeManager so that GetFieldFromEvent can get at it.
21733 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
21734 keep track of the private field associated with an event which
21737 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
21740 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
21742 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21744 * expression.cs (Binary.EmitBranchable): this routine emits the
21745 Binary expression in a branchable context. This basically means:
21746 we need to branch somewhere, not just get the value on the stack.
21748 This works together with Statement.EmitBoolExpression.
21750 * statement.cs (Statement.EmitBoolExpression): Use
21753 2002-07-09 Miguel de Icaza <miguel@ximian.com>
21755 * statement.cs (For): Reduce the number of jumps in loops.
21757 (For): Implement loop inversion for the For statement.
21759 (Break): We can be breaking out of a Try/Catch controlled section
21760 (foreach might have an implicit try/catch clause), so we need to
21761 use Leave instead of Br.
21763 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
21764 now). If the instace expression supports IMemoryLocation, we use
21765 the AddressOf method from the IMemoryLocation to extract the
21766 address instead of emitting the instance.
21768 This showed up with `This', as we were emitting the instance
21769 always (Emit) instead of the Address of This. Particularly
21770 interesting when This is a value type, as we dont want the Emit
21771 effect (which was to load the object).
21773 2002-07-08 Miguel de Icaza <miguel@ximian.com>
21775 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
21777 * statement.cs (Checked): Set the CheckedState during the resolve
21778 process too, as the ConvCast operations track the checked state on
21779 the resolve process, and not emit.
21781 * cs-parser.jay (namespace_member_declaration): Flag that we have
21782 found a declaration when we do. This is used to flag error 1529
21784 * driver.cs: Report ok when we display the help only.
21786 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
21788 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
21790 2002-07-04 Miguel de Icaza <miguel@ximian.com>
21792 * cs-tokenizer.cs (define): We also have to track locally the
21793 defines. AllDefines is just used for the Conditional Attribute,
21794 but we also need the local defines for the current source code.
21796 2002-07-03 Miguel de Icaza <miguel@ximian.com>
21798 * statement.cs (While, For, Do): These loops can exit through a
21799 Break statement, use this information to tell whether the
21800 statement is the last piece of code.
21802 (Break): Flag that we break.
21804 * codegen.cs (EmitContexts): New `Breaks' state variable.
21806 2002-07-03 Martin Baulig <martin@gnome.org>
21808 * class.cs (TypeContainer.MethodModifiersValid): Allow override
21809 modifiers in method declarations in structs. Otherwise, you won't
21810 be able to override things like Object.Equals().
21812 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21814 * class.cs (Method, Property, Indexer): Do not allow the public
21815 modifier to be used in explicit interface implementations.
21817 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
21818 override modifiers in method declarations in structs
21820 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
21822 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
21823 integer or real overflow, report an error
21825 2002-07-02 Martin Baulig <martin@gnome.org>
21827 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
21828 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
21829 to tell the runtime about our newly created System.Object and
21830 System.ValueType types.
21832 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21834 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
21835 struct instead of Ldarg/Starg.
21837 2002-07-02 Martin Baulig <martin@gnome.org>
21839 * expression.cs (Indirection.Indirection): Call
21840 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
21842 2002-07-02 Martin Baulig <martin@gnome.org>
21844 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
21845 ValueType, call TypeManager.TypeToCoreType() on it.
21846 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
21847 the OpCodes.Newarr argument.
21849 2002-07-02 Martin Baulig <martin@gnome.org>
21851 * expression.cs (Invocation.EmitCall): When compiling corlib,
21852 replace all calls to the system's System.Array type to calls to
21853 the newly created one.
21855 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21856 System.Array methods.
21857 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21858 from the system's System.Array type which must be replaced.
21860 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21862 * typemanager.cs: load unverifiable_code_ctor so we can build
21863 corlib using the correct type. Avoid using GetTypeCode() with
21865 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21866 TypeManager.object_type to allow building corlib.
21868 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21870 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21872 2002-07-01 Martin Baulig <martin@gnome.org>
21874 * class.cs: Make the last change actually work, we need to check
21875 whether `ifaces != null' to avoid a crash.
21877 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21879 * class.cs: when we build structs without fields that implement
21880 interfaces, we need to add the interfaces separately, since there is
21881 no API to both set the size and add the interfaces at type creation
21884 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21886 * expression.cs: the dimension arguments to the array constructors
21887 need to be converted if they are a long.
21889 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21891 * class.cs: don't emit ldarg.0 if there is no parent constructor
21892 (fixes showstopper for corlib).
21894 2002-06-29 Martin Baulig <martin@gnome.org>
21896 MCS now compiles corlib on GNU/Linux :-)
21898 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21899 ie. check for MethodImplOptions.InternalCall.
21901 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21902 and TypeManager.attribute_type are null, so we must explicitly check
21903 whether parent is not null to find out whether it's an attribute type.
21904 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21905 and SetBuilder, not only if the property is neither abstract nor external.
21906 This is necessary to set the MethodImplOptions on the accessor methods.
21907 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21908 SetBuilder, see Property.Emit().
21910 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21911 populate "System.Object", "System.ValueType" and "System.Attribute" since
21912 they've already been populated from BootCorlib_PopulateCoreTypes().
21914 2002-06-29 Martin Baulig <martin@gnome.org>
21916 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21917 is the NullLiteral, we also need to make sure that target_type is not
21920 2002-06-29 Martin Baulig <martin@gnome.org>
21922 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21923 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21924 before calling BootstrapCorlib_ResolveDelegate ().
21926 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21928 * statement.cs: fixed build-breaker. All tests passed ok.
21930 2002-06-27 Martin Baulig <martin@gnome.org>
21932 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21933 for System.Decimal when compiling corlib.
21935 2002-06-27 Martin Baulig <martin@gnome.org>
21937 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21938 switch blocks which contain nothing but a default clause.
21940 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21942 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21944 2002-06-27 Martin Baulig <martin@gnome.org>
21946 * ecore.cs (PropertyExpr.PropertyExpr): Call
21947 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21949 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21950 is already a TypeBuilder.
21952 2002-06-27 Martin Baulig <martin@gnome.org>
21954 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21955 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21956 the "from an array-type to System.Array" case. This makes it work
21957 when compiling corlib.
21959 2002-06-27 Martin Baulig <martin@gnome.org>
21961 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21962 non-static PropertyExpr, set its InstanceExpression. This makes
21963 the `ICollection.Count' property work in System/Array.cs.
21965 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21967 * driver.cs: Made error handling more consistent. Errors now
21968 tracked by Report class, so many methods which used to return int
21969 now return void. Main() now prints success/failure and
21970 errors/warnings message.
21972 Renamed '--probe' compiler argument to '--expect-error'. Removed
21973 the magic number return values (123 and 124). Now, if the
21974 expected error occurs, the compiler exits with success (exit value
21975 0). If the compilation completes without seeing that particular
21976 error, the compiler exits with failure (exit value 1). The
21977 makefile in mcs/errors has been changed to handle the new behaviour.
21979 * report.cs: Made 'expected error' number a property and renamed
21980 it from 'Probe' to 'ExpectedError'.
21982 * genericparser.cs: Removed error handling support, since it is
21983 now all done by Report class.
21985 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
21986 class, so parse() no longer returns an int.
21988 * namespace.cs: Use Report.Error instead of GenericParser.error
21990 2002-06-22 Miguel de Icaza <miguel@ximian.com>
21992 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
21993 TypeContainer.AddOperator): At the front of the list put the
21994 explicit implementations, so they get resolved/defined first.
21996 2002-06-21 Miguel de Icaza <miguel@ximian.com>
21998 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
21999 interface type is implemented by this TypeContainer. Used during
22000 explicit interface implementation.
22002 (Property.Define, Indexer.Define, Method.Define): Validate that
22003 the given interface in the explicit implementation is one of the
22004 base classes for the containing type.
22006 Also if we are explicitly implementing an interface, but there is
22007 no match in the pending implementation table, report an error.
22009 (Property.Define): Only define the property if we are
22010 not explicitly implementing a property from an interface. Use the
22011 correct name also for those properties (the same CSC uses,
22012 although that is really not needed).
22014 (Property.Emit): Do not emit attributes for explicitly implemented
22015 properties, as there is no TypeBuilder.
22017 (Indexer.Emit): ditto.
22019 Hiding then means that we do not really *implement* a pending
22020 implementation, which makes code fail.
22022 2002-06-22 Martin Baulig <martin@gnome.org>
22024 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
22025 the return value of Object.GetType(). [FIXME: we need to do this whenever
22026 we get a type back from the reflection library].
22028 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
22030 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
22032 2002-06-20 Miguel de Icaza <miguel@ximian.com>
22034 * attribute.cs: Return null if we can not look up the type.
22036 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
22037 the interface types found.
22039 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
22040 interface types found.
22042 * typemanager.cs (GetInterfaces): Make this routine returns alll
22043 the interfaces and work around the lame differences between
22044 System.Type and System.Reflection.Emit.TypeBuilder in the results
22045 result for GetInterfaces.
22047 (ExpandInterfaces): Given an array of interface types, expand and
22048 eliminate repeated ocurrences of an interface. This expands in
22049 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
22052 2002-06-21 Martin Baulig <martin@gnome.org>
22054 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
22057 2002-06-21 Martin Baulig <martin@gnome.org>
22059 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
22060 and called with one of the core types, return the corresponding typebuilder for
22063 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
22066 2002-06-21 Martin Baulig <martin@gnome.org>
22068 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
22069 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
22070 (Expression.ConvertReferenceExplicit): Likewise.
22072 * expression.cs (ElementAccess.DoResolve): Likewise.
22073 (ElementAccess.DoResolveLValue): Likewise.
22075 2002-06-10 Martin Baulig <martin@gnome.org>
22077 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
22078 add the "value" parameter to the parameter list.
22080 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
22083 2002-06-19 Miguel de Icaza <miguel@ximian.com>
22085 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
22086 the argument to an int, uint, long or ulong, per the spec. Also
22087 catch negative constants in array creation.
22089 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
22091 * class.cs: do not allow the same interface to appear twice in
22092 the definition list.
22094 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
22096 * ecore.cs: don't use ldlen with System.Array.
22098 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
22100 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
22102 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
22104 * modifiers.cs: produce correct field attributes for protected
22105 internal. Easy fix so miguel can work on ther harder stuff:-)
22107 2002-06-18 Miguel de Icaza <miguel@ximian.com>
22109 * pending.cs: New file. Move the code from class.cs here.
22110 Support clearning the pending flag for all methods (when not doing
22111 explicit interface implementation).
22113 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
22115 * rootcontext.cs: added a couple more types needed to bootstrap.
22117 2002-06-17 Miguel de Icaza <miguel@ximian.com>
22119 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
22120 constructor in the type, instead of any constructor in the type
22121 hierarchy. Thanks to Paolo for finding this bug (it showed up as
22122 a bug in the Mono runtime when applying the params attribute).
22124 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
22125 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
22127 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
22129 * expression.cs (Unary.ResolveOperator): Use TypeManager
22130 to resolve the type.
22132 2002-06-13 Ravi Pratap <ravi@ximian.com>
22134 * cs-parser.jay (enum_member_declaration): Pass in the attributes
22137 * enum.cs (AddEnumMember): Add support to store the attributes associated
22138 with each member too.
22140 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
22141 field builders too - this takes care of the enum member case.
22143 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
22145 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
22146 address-of operator on both value types and pointers.
22148 2002-06-10 Martin Baulig <martin@gnome.org>
22150 * interface.cs (Interface.PopulateIndexer): Add the indexer's
22151 PropertyBuilder to the `property_builders' list.
22153 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
22154 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
22155 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
22156 find any indexers which are inherited from an interface.
22158 2002-06-09 Martin Baulig <martin@gnome.org>
22160 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
22161 the same type as the constant if necessary. There's also a test-130.cs
22164 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
22166 * typemanager.cs (TypeManager.ChangeType): Previously known as
22167 Enum.ChangeEnumType().
22169 2002-06-09 Martin Baulig <martin@gnome.org>
22171 * expression.cs (Cast.TryReduce): Added support for consts.
22173 2002-06-08 Ravi Pratap <ravi@ximian.com>
22175 * class.cs (Accessor): Hold attributes information so we can pass
22178 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
22179 Modify to pass in attributes attached to the methods.
22181 (add_accessor_declaration, remove_accessor_declaration): Ditto.
22183 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
22184 to handle the Accessor kind :-)
22186 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
22188 2002-06-08 Martin Baulig <martin@gnome.org>
22190 * expression.cs (Unary.TryReduceNegative): Added support for
22193 2002-06-08 Martin Baulig <martin@gnome.org>
22195 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
22196 name can't be found in the `defined_names' - the caller will do a
22197 MemberLookup in this case and thus find methods in System.Enum
22198 such as Enum.IsDefined().
22200 2002-06-08 Martin Baulig <martin@gnome.org>
22202 * enum.cs (Enum.ChangeEnumType): This is a custom version of
22203 Convert.ChangeType() which works with TypeBuilder created types.
22204 (Enum.LookupEnumValue, Enum.Define): Use it here.
22206 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
22207 `TypeBuilder.BaseType != null' check.
22208 (TypeContainer.FindMembers): Only lookup parent members if we
22209 actually have a parent.
22210 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
22211 (ConstructorInitializer.Resolve): Likewise.
22213 * interface.cs (Interface.FindMembers): Added
22214 `TypeBuilder.BaseType != null' check.
22216 * rootcontext.cs (RootContext.ResolveCore): Added
22217 "System.Runtime.CompilerServices.IndexerNameAttribute" to
22218 classes_second_stage.
22220 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
22221 debug_type and trace_type when compiling with --nostdlib.
22223 2002-06-07 Martin Baulig <martin@gnome.org>
22225 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
22226 (AddField): Set it to true when adding a non-static field.
22227 (DefineType): Use `have_nonstatic_fields' to find out whether we
22228 have non-static fields, not `Fields != null'.
22230 2002-06-02 Miguel de Icaza <miguel@ximian.com>
22232 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
22233 dereferencing a null on the static-field code path)
22235 2002-05-30 Martin Baulig <martin@gnome.org>
22237 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
22238 to take command line arguments. Use reflection to call the new
22239 custom `Initialize' function on the symbol writer and pass it the
22240 command line arguments.
22242 * driver.cs (--debug-args): New command line argument to pass command
22243 line arguments to the symbol writer.
22245 2002-05-28 Miguel de Icaza <miguel@ximian.com>
22247 * assign.cs (DoResolve): Forgot to do the implicit conversion to
22248 the target type for indexers and properties. Thanks to Joe for
22251 2002-05-27 Miguel de Icaza <miguel@ximian.com>
22253 * typemanager.cs (MethodFlags): returns the method flags
22254 (Obsolete/ShouldIgnore) that control warning emission and whether
22255 the invocation should be made, or ignored.
22257 * expression.cs (Invocation.Emit): Remove previous hack, we should
22258 not do this on matching a base type, we should do this based on an attribute
22260 Only emit calls to System.Diagnostics.Debug and
22261 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
22262 on the command line.
22264 * rootcontext.cs: Global settings for tracing and debugging.
22266 * cs-tokenizer.cs (define): New utility function to track
22267 defines. Set the global settings for TRACE and DEBUG if found.
22269 2002-05-25 Ravi Pratap <ravi@ximian.com>
22271 * interface.cs (Populate*): Pass in the TypeContainer as well as
22272 the DeclSpace as parameters so that we can create EmitContexts and
22273 then use that to apply attributes etc.
22275 (PopulateMethod, PopulateEvent, PopulateProperty)
22276 (PopulateIndexer): Apply attributes everywhere.
22278 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
22281 (ApplyAttributes): Update accordingly.
22283 We now apply interface attributes for all members too.
22285 2002-05-26 Miguel de Icaza <miguel@ximian.com>
22287 * class.cs (Indexer.Define); Correctly check if we are explicit
22288 implementation (instead of checking the Name for a ".", we
22289 directly look up if the InterfaceType was specified).
22291 Delay the creation of the PropertyBuilder.
22293 Only create the PropertyBuilder if we are not an explicit
22294 interface implementation. This means that explicit interface
22295 implementation members do not participate in regular function
22296 lookups, and hence fixes another major ambiguity problem in
22297 overload resolution (that was the visible effect).
22299 (DefineMethod): Return whether we are doing an interface
22302 * typemanager.cs: Temporary hack until we get attributes in
22303 interfaces (Ravi is working on that) and we get IndexerName
22304 support in interfaces.
22306 * interface.cs: Register the indexers as properties.
22308 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
22309 warning, I have verified that this is a bug in the .NET runtime
22310 (JavaScript suffers of the same problem).
22312 * typemanager.cs (MemberLookup): When looking up members for
22313 interfaces, the parent of an interface is the implicit
22314 System.Object (so we succeed in searches of Object methods in an
22315 interface method invocation. Example: IEnumerable x; x.ToString
22318 2002-05-25 Miguel de Icaza <miguel@ximian.com>
22320 * class.cs (Event): Events should also register if they do
22321 implement the methods that an interface requires.
22323 * typemanager.cs (MemberLookup); use the new GetInterfaces
22326 (GetInterfaces): The code used to lookup interfaces for a type is
22327 used in more than one place, factor it here.
22329 * driver.cs: Track the errors at the bottom of the file, we kept
22332 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
22333 instance if the method we are calling is static!
22335 2002-05-24 Miguel de Icaza <miguel@ximian.com>
22337 * attribute.cs (ApplyAttributes): Make this function filter out
22338 the IndexerName attribute (as that attribute in reality is never
22339 applied) and return the string constant for the IndexerName
22342 * class.cs (TypeContainer.Emit): Validate that all the indexers
22343 have the same IndexerName attribute, and if so, set the
22344 DefaultName attribute on the class.
22346 * typemanager.cs: The return value might contain other stuff (not
22347 only methods). For instance, consider a method with an "Item"
22348 property and an Item method.
22350 * class.cs: If there is a problem with the parameter types,
22353 2002-05-24 Ravi Pratap <ravi@ximian.com>
22355 * ecore.cs (ImplicitConversionExists): Wrapper function which also
22356 looks at user defined conversion after making a call to
22357 StandardConversionExists - we need this for overload resolution.
22359 * expression.cs : Update accordingly the various method calls.
22361 This fixes 2 bugs filed against implicit user defined conversions
22363 2002-05-22 Miguel de Icaza <miguel@ximian.com>
22365 * statement.cs: Track the result of the assignment.
22367 2002-05-21 Miguel de Icaza <miguel@ximian.com>
22369 * expression.cs (MemberAccess): Improved error reporting for
22370 inaccessible members.
22372 2002-05-22 Martin Baulig <martin@gnome.org>
22374 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
22375 itself with debugging support.
22377 2002-05-22 Martin Baulig <martin@gnome.org>
22379 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
22380 Removed, this isn't needed anymore.
22382 2002-05-20 Martin Baulig <martin@gnome.org>
22384 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
22385 be underlying type for an enum.
22387 2002-05-20 Miguel de Icaza <miguel@ximian.com>
22389 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
22390 that splits out the loading of just the core types.
22392 * rootcontext.cs (ResolveCore): Split the struct resolution in
22393 two, so we can load the enumeration underlying types before any
22396 * expression.cs (Is): Bandaid until we fix properly Switch (see
22397 bug #24985 for details).
22399 * typemanager.cs (ImplementsInterface): The hashtable will contain
22400 a null if there are no interfaces implemented.
22402 2002-05-18 Miguel de Icaza <miguel@ximian.com>
22404 * cs-parser.jay (indexer_declarator): It is fine to have array
22407 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22409 * typemanager.cs: (RegisterBuilder): New function used to register
22410 TypeBuilders that implement interfaces. Since
22411 TypeBuilder.GetInterfaces (as usual) does not work with lame
22413 (AddUserType): register interfaces.
22415 (ImplementsInterface): Use the builder_to_ifaces hash if we are
22416 dealing with TypeBuilder. Also, arrays are showing up as
22417 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
22418 methods can not be invoked on them!
22420 * ecore.cs (ExplicitReferenceConversionExists): Made public.
22421 (ImplicitReferenceConversionExists): Split out from
22422 StandardConversionExists.
22424 * expression.cs (As): We were only implementing one of the three
22425 cases for the as operator. We now implement them all.
22426 (Is): Implement the various other cases for Is as well.
22428 * typemanager.cs (CACHE): New define used to control if we want or
22429 not the FindMembers cache. Seems to have a negative impact on
22430 performance currently
22432 (MemberLookup): Nested types have full acess to
22433 enclosing type members
22435 Remove code that coped with instance/static returns for events, we
22436 now catch this in RealFindMembers.
22438 (RealFindMembers): only perform static lookup if the instance
22439 lookup did not return a type or an event.
22441 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22443 * assign.cs (CompoundAssign): We pass more semantic information
22444 now to Compound Assignments than we did before: now we have all
22445 the information at hand, and now we resolve the target *before* we
22446 do the expression expansion, which allows the "CacheValue" method
22447 to have the effect we intended (before, a [x] += 1 would generate
22448 two differen ArrayAccess expressions from the ElementAccess,
22449 during the resolution process).
22451 (CompoundAssign.DoResolve): Resolve target and original_source here.
22453 2002-05-16 Miguel de Icaza <miguel@ximian.com>
22455 * expression.cs (ArrayAccess): dropped debugging information.
22457 * typemanager.cs: Small bug fix: I was always returning i_members,
22458 instead of one of i_members or s_members (depending on which had
22461 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
22462 method is invoked before any code generation takes place, and it
22463 is a mechanism to inform that the expression will be invoked more
22464 than once, and that the method should use temporary values to
22465 avoid having side effects
22467 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
22469 * ecore.cs (Expression.CacheTemporaries): Provide empty default
22472 * expression.cs (Indirection, ArrayAccess): Add support for
22473 CacheTemporaries in these two bad boys.
22475 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
22476 ldobj or ldind_ref.
22477 (StoreFromPtr): Handle stobj as well.
22479 * expression.cs (UnaryMutator): Share more code.
22481 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
22482 down: I was not tracking the Filter function as well, which
22483 was affecting the results of the cache.
22485 2002-05-15 Miguel de Icaza <miguel@ximian.com>
22487 * attribute.cs: Remove the hack to handle the CharSet property on
22490 2002-05-14 Miguel de Icaza <miguel@ximian.com>
22492 * attribute.cs (DoResolve): More uglyness, we now only try to
22493 resolve the attribute partially, to extract the CharSet
22494 information (only if we are a StructLayout attribute). Otherwise
22496 (GetExtraTypeInfo): Add some code to conditionally kill in the
22497 future this. I am more and more convinced that the .NET
22498 framework has special code to handle the attribute setting on
22501 * expression.cs (IsParamsMethodApplicable): Revert my previous
22502 foreach change here, it was wrong.
22504 2002-05-13 Miguel de Icaza <miguel@ximian.com>
22506 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
22507 (pp_expr): do not abort on unknown input, just return.
22508 (eval): abort if there are pending chars.
22510 * attribute.cs (Attribute.Resolve): Positional parameters are
22511 optional. Deal with that case.
22513 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
22514 the Ansi/Unicode/Auto information for the type.
22516 (TypeContainer.DefineType): instantiate the EmitContext here, as
22517 we will be using it during the type definition (to resolve
22518 attributes) and during the emit phase.
22520 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
22521 to pull type information out of the attributes
22523 (Attribute.Resolve): track the constructor builder, and allow for
22524 multiple invocations (structs and classes will use this).
22526 * ecore.cs (MemberLookupFinal): new version with all the
22527 parameters customizable.
22529 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
22530 constructors. Return if the result value is null (as the error
22531 would have been flagged already by MemberLookupFinal)
22533 Do not allow instances of abstract classes or interfaces to be
22536 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
22537 We have to compare the assembly property here when dealing with
22538 FamANDAssem and Assembly access modifiers, because we might be
22539 creating an assembly from *modules* (that means that we are not
22540 getting TypeBuilders for types defined in other modules that are
22541 part of this assembly).
22543 (Method.Emit): If the method is marked abstract and has a body,
22546 (TypeContainer.DefineMembers): If both the defined member and the
22547 parent name match are methods, then do not emit any warnings: let
22548 the Method.Define routine take care of flagging warnings. But if
22549 there is a mismatch (method overrides something else, or method is
22550 overriwritten by something, then emit warning).
22552 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
22553 set to null, this means `do not check for the return type on the
22556 (Method.Define): set the return type for the method signature to
22557 null, so that we get methods with the same name and parameters and
22558 different return types. This is used to flag warning 114 (you are
22559 hiding a method, and you probably want to use the new/override
22562 * typemanager.cs (MemberLookup): Implemented proper access
22563 control, closing a long standing set of bug reports. The problem
22564 was that the Framework only has two bits: Public and NonPublic,
22565 and NonPublic includes private and protected methods, but we need
22566 to enforce the FamANDAssem, FamOrAssem and Family.
22568 2002-05-11 Miguel de Icaza <miguel@ximian.com>
22570 * statement.cs (GotoCase): Return true: Ammounts to giving up
22571 knowledge on whether we return or not, and letting the other case
22572 be responsible for it.
22574 2002-05-10 Miguel de Icaza <miguel@ximian.com>
22576 * driver.cs: Do not load directories for each file processed, only
22577 do it if there is a pattern.
22579 * ecore.cs: Report readonly assigns here as well, as we might have
22580 been resolved only by MemberAccess.
22582 (SimpleName.SimpleNameResolve): Also be useful for LValue
22583 resolution. We need this to propagate assign to local readonly variables
22585 * typemanager.cs: Use a ptrhashtable for the criteria, because we
22586 do not want to reuse potential criteria memory.
22588 * class.cs (MyEventBuilder): Set reflected_type;
22590 * ecore.cs (Constantify): Added support for constifying bools.
22592 (RootContext.LookupType): Added a cache for values looked up in
22593 the declaration space.
22595 * typemanager.cs (FindMembers): Now is a front-end to
22596 RealFindMembers, and provides a two-level hashtable-based cache to
22599 15% performance improvement: from 22.5 to 19.2 seconds.
22601 * expression.cs (IsParamsMethodApplicable): use foreach.
22602 (Invocation.DoResolve): ditto.
22603 (New.DoResolve): ditto.
22604 (ArrayCreation.DoResolve): ditto.
22606 * ecore.cs (FindMostEncompassingType): use foreach.
22608 * delegate.cs (NewDelegate.DoResolve): Use foreach
22610 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
22611 (RemoveMethods): use foreach.
22613 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
22614 nested foreach statements instead of for, and also break out of
22615 the inner loop once a match is found.
22617 (Invocation.OverloadResolve): Use foreach, simplify the code.
22619 2002-05-08 Miguel de Icaza <miguel@ximian.com>
22621 * cfold.cs (BinaryFold): During an enumeration evaluation context,
22622 we actually unwrap the expression to allow for extra information
22625 * expression.cs: Use Shr_Un on unsigned operations.
22627 2002-05-08 Ravi Pratap <ravi@ximian.com>
22629 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
22630 applicable operators was not being considered correctly. This closes
22631 the bug Miguel reported.
22633 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
22635 * attribute.cs: check that the type derives from System.Attribute
22636 and report the correct error in that case (moved the duplicate code to
22637 its own method, too).
22639 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
22641 * attribute.cs: lookup attribute type name as the spec says: first the
22642 bare attribute name and then name + "Attribute" (nant compiles with
22643 mcs after this fix).
22645 2002-05-07 Miguel de Icaza <miguel@ximian.com>
22647 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
22648 Because of the way we parse things, we should try to see if a
22649 UIntConstant can fit in an integer.
22651 2002-05-07 Ravi Pratap <ravi@ximian.com>
22653 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
22654 when we are in an explicit context.
22656 (ConvertReferenceExplicit): When converting from Iface type S to Class
22657 T make sure the rules are implemented as an OR.
22659 * parameter.cs (ParameterType): Make it a property for now although the
22660 purpose really isn't anything immediate.
22662 * expression.cs (Is*Applicable): Do better checking on the parameter type
22663 of a ref/out parameter. The ones from the system assemblies are already
22664 marked with the correct type so we don't need to do any correction.
22666 * ecore.cs (StandardConversionExists): Conversion from Interface types to
22667 the object type is standard too so include that.
22669 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22671 * ecore.cs (StandardConversionExists): Augment with missing code:
22672 deal with IntConstant, LongConstants and Enumerations.
22674 * assign.cs: Report the error, instead of failing silently
22676 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
22677 typecontainer that they are declared, because the
22678 typecontainer/namespace will have the list of using clauses that
22679 need to be applied.
22681 Assembly Attributes were escaping the normal registration
22684 (EmitCode): Apply attributes within an EmitContext that represents
22685 the container they were declared on.
22687 * cs-parser.jay: Track bases for structs. How did I get this wrong?
22689 2002-05-06 Ravi Pratap <ravi@ximian.com>
22691 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
22692 Revamp completely - make much cleaner as we now operate only
22695 (FindMostSpecificSource, FindMostSpecificTarget): New methods
22696 to implement the logic detailed in the spec more correctly.
22698 (UserDefinedConversion): Update accordingly.
22700 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22702 * statement.cs: Return flow analysis information up.
22704 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
22707 (token): Do not consume an extra character before calling
22710 2002-05-06 Piers Haken <piersh@friskit.com>
22712 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
22714 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22716 * class.cs (Constructor.Emit): Set the IsStatic flag in the
22717 EmitContext during the instance constructor initializer
22718 resolution, to stop access to instance variables.
22720 This is mandated by the spec, last paragraph of the `constructor
22721 initializers' section.
22723 2002-05-05 Miguel de Icaza <miguel@ximian.com>
22725 * cs-parser.jay, class.cs (Accessor): new class used to represent
22726 an accessor (get or set). In the past we used `null' to represent
22727 a missing accessor. But this is ambiguous because there was no
22728 way to tell in abstract indexers/properties if one of them was
22731 Now there is a way of addressing that.
22733 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
22734 instead of FindMembers.
22736 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
22737 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
22739 * attribute.cs: Treat indexers and properties as the same in terms
22740 of applying attributes
22742 * ecore.cs (FindMostEncompassedType): Use statically initialized
22743 EmptyExpressions()s like we do elsewhere to avoid creating useless
22744 objects (and we take this out of the tight loop).
22746 (GetConversionOperators): Move the code to extract the actual
22747 operators to a separate routine to clean things up.
22749 2002-05-04 Miguel de Icaza <miguel@ximian.com>
22751 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
22752 events are always registered FieldBuilders.
22754 * class.cs (FieldBase): New class shared by Fields
22756 * delegate.cs: If we are a toplevel delegate, use our full name.
22757 If we are a nested delegate, then only use our tail name.
22759 2002-05-02 Ravi Pratap <ravi@ximian.com>
22761 * expression.cs (IsApplicable): Ensure that we add the "&" to
22762 ref/out types before comparing it with the type of the argument.
22764 (IsParamsMethodApplicable): Ditto.
22766 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
22769 * delegate.cs : Handle the case when we have more than one applicable
22770 method. Flag an error only when we finish checking all.
22772 2002-05-02 Miguel de Icaza <miguel@ximian.com>
22774 * expression.cs: Add support for boolean static initializers.
22776 2002-05-01 Miguel de Icaza <miguel@ximian.com>
22778 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
22780 * parameter.cs (ComputeParameterTypes,
22781 ComputeAndDefineParameterTypes): Better error handling: now we
22782 clear the `types' cache if we fail during any of the type lookups.
22783 We also return the status code correctly to our caller
22785 * delegate.cs: If we fail to define a delegate, abort the extra
22788 * expression.cs (Binary.ResolveOperator): for
22789 operator==(object,object) and operator !=(object, object) we also
22790 have to verify that there is an implicit conversion from one to
22793 (ArrayAccess.DoResolve): Array Access can operate on
22796 2002-04-30 Miguel de Icaza <miguel@ximian.com>
22798 * assign.cs (CompoundAssign): A new class used as a "flag" that
22799 the assignment actually is happening as part of a compound
22800 assignment operator.
22802 During compound assignment, a few new rules exist to enable things
22809 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
22810 to the type of x) if y is implicitly convertible to the type of x,
22811 and the operator is a builtin operator and the return type of the
22812 operator is explicitly convertible to the type of x.
22814 * rootcontext.cs: Reset warning level to 2. 4 catches various
22815 "interesting" features in mcs, we must clean this up at some
22816 point, but currently am trying to kill other bugs ;-)
22818 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
22819 in container classes as well.
22821 * expression.cs (Binary.ResolveOperator): Handle string case
22822 before anything else (as operator overloading does emit an error
22823 before doing anything else).
22825 This code could go away when we move to a table driven model, but
22826 i could not come up with a good plan last night.
22828 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
22830 * typemanager.cs (CSharpName): reimplementation using regex.
22831 * class.cs: added null check for fields in Emit
22832 * rootcontext.cs: set warninglevel to 4
22834 2002-04-29 Miguel de Icaza <miguel@ximian.com>
22836 * typemanager.cs (CSharpName): reimplemented with Lupus
22839 2002-04-28 Miguel de Icaza <miguel@ximian.com>
22841 * statement.cs (If): correclty implement Resolve, because we were
22842 not catching sem errors in there. The same process is needed
22844 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
22847 (Statement.Warning_DeadCodeFound): Factorize code.
22848 (While): Report dead code here too.
22850 (Statement): Added Resolve virtual method to allow
22851 for resolution split from the emit code.
22853 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22855 * statement.cs (EmitBoolExpression): No longer try to resolve the
22857 (MakeBoolean): New utility function that resolve, implicitly
22858 converts to boolean and tags the expression.
22861 (If, Do): Implement dead code elimination.
22862 (While): Implement loop inversion
22864 (Do, While, For, If): Resolve the expression prior to calling our
22867 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22870 - added method Report28 (warning: program has more than one entry point)
22871 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22872 - modified method Method.Define, the part at the end of the method
22874 * rootcontext.cs: added static public Location EntryPointLocation;
22876 * ../errors/cs0028.cs : Add test case for the above warning.
22879 - modified method CSharpName to allow arrays of primitive type to
22880 be printed nicely (e.g. instead of System.Int32[][] it now prints
22882 - added method CSharpSignature: returns the signature of a method
22883 in string format to be used in reporting errors, warnings, etc.
22885 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22888 2002-04-26 Ravi Pratap <ravi@ximian.com>
22890 * delegate.cs (Define): Fix extremely silly bug where I was
22891 setting the type of the 'object' parameter of the BeginInvoke
22892 method to System.IAsyncResult instead of System.Object ;-)
22894 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22896 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22899 (Constructor.Emit): return if we fail to initialize the
22900 constructor. Another door closed!
22902 * expression.cs (New.DoResolve): Improve error message (from -6 to
22903 1501). Use DeclaredOnly lookup to find the exact constructor.
22905 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22906 loop. This is useful.
22908 * cs-parser.jay: Adjust the default parameters so that destructors
22909 have the proper signature.
22911 2002-04-26 Martin Baulig <martin@gnome.org>
22913 * driver.cs (LoadAssembly): If `assembly' contains any characters
22914 which are only valid in path names and not in assembly names
22915 (currently slash, backslash and point), use Assembly.LoadFrom ()
22916 instead of Assembly.Load () on the `assembly' (before iteration
22917 over the link_paths).
22919 2002-04-26 Martin Baulig <martin@gnome.org>
22921 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22923 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22925 * class.cs (Property): use the new typemanager.MemberLookup
22927 (TypeContainer.MemberLookup): Implement using the
22928 TypeManager.MemberLookup now.
22930 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22931 and return MemberInfos, so that these can be used without an
22932 EmitContext (what we had before).
22934 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22936 * expression.cs: Fix the case where the argument to params if the
22937 type of the params. I omitted handling this before. Fixed
22939 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22941 * driver.cs: Call BootCorlib_PopulateCoreType
22943 * class.cs (Property.CheckBase): Check for properties only, not
22946 * interface.cs: Temporary hack: try/catch around the
22947 CustomAttributeBuilder, because I am getting an exception that I
22950 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22951 types whose definitions are required to be there (attributes are
22952 defined before standard types).
22954 Compute definitions as we boot the various types, as they are used
22955 immediately (value_type class will need object_type, but if we do
22956 not initialize object_type, we will pass a null, which will let
22957 the runtime pick the System.Object from the existing corlib, which
22958 is not what we want).
22960 2002-04-22 Patrik Torstensson <totte@labs2.com>
22962 * cs-tokenizer.cs: fixed a number of trim() issues.
22964 2002-04-22 Ravi Pratap <ravi@ximian.com>
22966 * expression.cs (Argument.Type): Ensure that we return the correct
22967 type when we have out or ref parameters [in which case we
22970 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22972 * class.cs (Property, Indexer): Allow extern modifier in there.
22974 * typemanager.cs (InitBaseTypes): Initializes object_type and
22975 value_type, since those will be used early on during the bootstrap
22976 process to compile corlib.
22978 (InitCoreTypes): Move code from here to InitBaseTypes.
22980 2002-04-21 Miguel de Icaza <miguel@ximian.com>
22982 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
22983 single-dimension arrays as using the ldlen opcode.
22985 Daniel Lewis discovered this optimization.
22987 * typemanager.cs: Add signature for System.Array::get_Length
22989 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22991 * statement.cs: report the error when the foreach does not apply to an
22992 array nor a collection.
22994 2002-04-19 Miguel de Icaza <miguel@ximian.com>
22996 * expression.cs: Add implicit conversions to the operator ~.
22998 * constant.cs (DecimalConstant.Emit): Emit decimal value.
23000 * typemanager.cs: Locate the decimal constructor.
23002 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23004 * attribute.cs: use the new property of TypeOf.
23005 * expression.cs: added 'get' property around typearg.
23007 These changes fix a build breaker reported by NickD. Is this the
23008 correct way to fix? If not, please, revert my changes and make it
23011 2002-04-17 Miguel de Icaza <miguel@ximian.com>
23013 * attribute.cs: Add support for typeof in attribute invocations.
23014 I am not sure that this is right though.
23016 2002-04-14 Duncan Mak <duncan@ximian.com>
23018 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
23019 Binary.Operator.Division case.
23021 2002-04-13 Ravi Pratap <ravi@ximian.com>
23023 * class.cs (DefineType): Ensure that we do a proper check on
23024 attribute types and also register it with the TypeManager.
23026 (TypeContainer.Targets): The default for attribute types is
23027 AttributeTargets.All.
23029 * attribute.cs (ApplyAttributes): Registering the attribute type
23030 is done elsewhere, not when we discover we have a Usage attribute.
23032 2002-04-12 Ravi Pratap <ravi@ximian.com>
23034 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
23035 and get rid of is_delegate parameter.
23037 * everywhere : update.
23039 2002-04-12 Ravi Pratap <ravi@ximian.com>
23041 * cs-parser.jay (compilation_unit): Revamp completely to use
23042 some new ideas that I got from Rhys' grammar to solve the problems
23043 with assembly level attributes.
23045 (outer_declaration): New grammar production.
23047 (attribute_sections): Add.
23049 (opt_attributes): Base on attribute_sections
23051 (namespace_declaration): Allow opt_attributes to tackle the case
23052 when we have assembly level attributes - we are clever in this
23055 * attribute.cs (ApplyAttributes): Do not worry about assembly
23056 attributes in the non-global context.
23058 * rootcontext.cs (AddGlobalAttributes): Go back to using this
23059 instead of SetGlobalAttributes.
23061 * class.cs, rootcontext.cs : Ensure we define and generate
23062 attribute types before anything else.
23064 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
23065 and flag the new error -20 for the case when the attribute type
23066 does not have valid targets specified. csc does not catch this.
23068 * ../errors/errors.txt : update for error # -20
23070 2002-04-11 Ravi Pratap <ravi@ximian.com>
23072 * support.cs (InternalParameters.ParameterModifier): Do some null
23073 checking and return sane values.
23075 * class.cs (Method.Define): If we are a PInvoke method, ensure
23076 that we are static and extern. Report error # 601
23078 * ../errors/cs0601.cs : Add test case for the above error.
23080 2002-04-07 Ravi Pratap <ravi@ximian.com>
23082 * rootcontext.cs (attribute_types): We need to keep type of
23083 all attribute types separately and emit code for them first.
23085 (RegisterAttribute) : Implement.
23087 * class.cs (DefineType): Check if the current Type is a custom
23088 attribute type and register it accordingly.
23090 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
23091 adding the first attribute twice and rename to
23093 (SetGlobalAttributes): this.
23095 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
23098 * attribute.cs (ApplyAttributes): Take an additional argument telling us
23099 if we are processing global arguments. Hmm, I am unsure of this.
23101 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23103 * expression.cs: added static array of strings to avoid calling
23104 Enum.ToString () for Operator in Binary. Significant recover of
23107 2002-04-10 Miguel de Icaza <miguel@ximian.com>
23109 * class.cs (FindMembers): Allow the Builders of the various
23110 members to be null. If they are skip them. This only happens
23111 during the PInvoke declaration.
23113 2002-04-09 Miguel de Icaza <miguel@ximian.com>
23115 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
23116 failure, so we do not keep going afterwards.
23118 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
23119 wanted to pass `false' as the `is_delegate' argument. If this is
23120 the case, why not use delegate_type == null to mean `is_delegate =
23121 false' and anything else as is_delegate = true.
23123 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
23125 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
23126 code for the section, not the beginning of the tests.
23128 2002-04-08 Miguel de Icaza <miguel@ximian.com>
23130 * cfold.cs: Handle operator + (Enum x, Underlying x)
23132 * expression.cs (Binary): same. Warn about errors where we have
23133 Enum/Enum in operator + as well.
23135 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
23138 - added support for switch(bool)
23139 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
23140 - add TableSwitchEmit() to handle table-based switch statements
23142 2002-04-05 Ravi Pratap <ravi@ximian.com>
23144 * expression.cs (Invocation.OverloadResolve): Factor out code which
23145 does parameter compatibility checking with arguments so that we can
23146 re-use the code even from Delegate.VerifyApplicability
23148 (VerifyArgumentsCompat): Move above code here.
23150 * delegate.cs (VerifyApplicability): Get rid of duplicate code
23151 and instead make a call to the above method.
23153 2002-03-31 Ravi Pratap <ravi@ximian.com>
23155 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
23156 We use it to keep track of classes which are attribute types.
23158 2002-04-02 Miguel de Icaza <miguel@ximian.com>
23160 * delegate.cs (Delegate.Define): Correctly define the types in the
23161 presence of fixed and array parameters.
23163 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
23166 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
23167 include NonPublic after the first iteration.
23169 * class.cs (Indexer.CheckBase): Only check if both parents are
23172 * cs-parser.jay (accessor_body): If empty, set to null.
23174 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
23175 same code path here to resolve constants names that we did have in
23176 MemberAccess.DoResolve. There is too much code duplicated here.
23178 2002-04-01 Miguel de Icaza <miguel@ximian.com>
23180 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
23182 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
23185 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
23186 tokens, numbers and strings.
23188 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
23191 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
23192 asyncronous parameters and the regular parameters.
23194 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
23195 specify the target directory.
23197 * expression.cs: (This.DoResolve): Simplify
23198 (As.Emit): Optimize, do not generate IsInst if the expression is
23199 always of the given type.
23201 (Is.DoResolve): Bug fix, we were reporting both always/never for
23204 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
23205 creating too many unnecessary arrays.
23207 2002-03-31 Miguel de Icaza <miguel@ximian.com>
23209 * class.cs (EmitFieldInitializer): Use Assign expression to assign
23210 fields instead of rolling our own initializer. Takes care of all
23211 implicit conversions, and drops unnecessary static checks/argument.
23213 2002-03-31 Dick Porter <dick@ximian.com>
23215 * driver.cs: use the GetDirectories() return values properly, and
23216 use "/" as path separator.
23218 2002-03-30 Miguel de Icaza <miguel@ximian.com>
23220 * expression.cs (Unary): Optimize - - expr into expr.
23221 (Binary): Optimize a + (-b) into a -b.
23223 * codegen.cs (CodeGen): Made all methods static.
23225 2002-03-29 Miguel de Icaza <miguel@ximian.com>
23229 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
23230 TypeBuilder property.
23232 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
23235 * tree.cs: Removed the various RecordXXXX, and replaced with a
23236 single RecordDecl. Removed all the accessor methods, and just
23237 left a single access point Type
23239 * enum.cs: Rename DefineEnum to DefineType.
23241 * decl.cs: New abstract method `DefineType' used to unify the
23242 Defines for Enumerations, Interfaces, TypeContainers and
23245 (FindType): Moved LookupInterfaceOrClass here. Moved the
23246 LookupBaseClasses method that used to live in class.cs and
23247 interface.cs here, and renamed to FindType.
23249 * delegate.cs: Implement DefineType. Take advantage of the
23250 refactored pattern for locating the parent builder without taking
23251 the parent_builder argument (which we know does not work if we are
23252 nested, and triggering a toplevel definition).
23254 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23256 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
23257 accessibility of a member has changed during override and report
23260 * class.cs (Method.Define, Property.Define): Only complain on
23261 overrides if the method is private, any other accessibility is
23262 fine (and since we just checked the permission is the same, we are
23265 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
23266 and elif are processed always. The other pre-processing
23267 directives are only processed if we are "taking" the path
23269 2002-03-29 Martin Baulig <martin@gnome.org>
23271 * class.cs (Method.Emit): Only emit symbolic debugging info if the
23272 current location is not Null.
23274 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
23275 a separate method so we can profile it.
23277 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
23278 `span.Seconds' are just seconds, but no minutes or hours.
23279 (MainDriver): Profile the CodeGen.SaveSymbols calls.
23281 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23283 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
23284 Remove the gratuitous set of Final:
23286 // If an interface implementation, then we can set Final.
23287 if (((flags & MethodAttributes.Abstract) == 0) &&
23288 implementing.DeclaringType.IsInterface)
23289 flags |= MethodAttributes.Final;
23291 I do not know what I was smoking when I used that.
23294 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
23295 step into fixing the name resolution issues for delegates and
23296 unifying the toplevel name resolution.
23298 2002-03-28 Martin Baulig <martin@gnome.org>
23300 * class.cs (Method.Emit): If we have a symbol writer, call its
23301 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
23302 tell it about the current method.
23304 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
23305 writer that we're going to emit the first byte of IL code for a new
23306 statement (a new source line).
23307 (EmitContext.EmitTopBlock): If we have a symbol writer, call
23308 EmitContext.Mark() before emitting any code.
23310 * location.cs (SymbolDocument): Return null when we're Null.
23312 * statement.cs (Statement): Moved the `Location loc' variable here.
23313 (Statement.EmitBoolExpression): If we have a symbol writer, call
23314 ec.Mark() before emitting any code to tell it that we're at the
23315 beginning of a new statement.
23316 (StatementExpression): Added `Location' argument to the constructor.
23317 (Block): Added public readonly variable `StartLocation' and public
23318 variable `EndLocation'. The latter is to be set using SetEndLocation().
23319 (Block): Added constructor which takes a start and end location.
23320 (Block.SetEndLocation): New method. This sets the end location.
23321 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
23322 local variables we create.
23323 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
23324 each statement and do also mark the begin and end of the block.
23326 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
23327 tell it the current lexer.Location, use Location.Null for the end of the
23329 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
23330 current block, set its end location using SetEndLocation().
23331 (statement_expression): StatementExpression constructor now takes the
23332 lexer.Location as additional argument.
23333 (for_statement, declare_local_variables): Likewise.
23334 (declare_local_variables): When creating a new implicit block, use the
23335 new Block constructor and pass it the lexer.Location.
23337 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23339 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
23340 members also on the parent interfaces recursively.
23342 2002-03-27 Miguel de Icaza <miguel@ximian.com>
23344 * report.cs: Use new formats, since Gonzalo finished the missing
23347 * expression.cs (Binary.ResolveOperator): added missing operator|
23348 operator& and operator^ for bool/bool.
23350 * cs-parser.jay: CheckDef now takes a Location argument that is
23351 used to report errors more precisly (instead of reporting the end
23352 of a definition, we try to track something which is a lot closer
23353 to the source of the problem).
23355 * cs-tokenizer.cs: Track global token use, so we can properly flag
23356 the use of #define/#undef after the first token has been seen.
23358 Also, rename the reportXXXX to Error_DescriptiveName
23360 * decl.cs (DeclSpace.IsTopLevel): Move property here from
23361 TypeContainer, so that Enum and Interface can use this too.
23363 * class.cs (TypeContainer.LookupInterfaceOrClass,
23364 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
23365 `builder' argument. Typically this was used to pass the parent
23366 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
23369 The problem is that a nested class could trigger the definition of
23370 a toplevel class, and the builder would be obviously wrong in that
23373 So we drop this argument, and we compute dynamically the
23374 TypeBuilder/ModuleBuilder (the correct information was available
23375 to us anyways from DeclSpace.Parent)
23377 * interface.cs (Interface.DefineInterface): Drop builder
23378 parameter cleanup like class.cs
23380 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
23383 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
23386 (Try.Emit): Propagate the returns value from the statement.
23388 (Return.Emit): Even if we are leavning
23390 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
23392 * modifiers.cs: Fix the computation of MethodAttributes flags.
23394 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
23396 * driver.cs: allow compilation of files that start with '/'.
23397 Add a default case when checking the argument of --target.
23399 2002-03-25 Miguel de Icaza <miguel@ximian.com>
23401 * interface.cs: Implement the same search algorithm for types in
23402 the interface code.
23404 * delegate.cs: Do not allow multiple definition.
23406 * Recovered ChangeLog that got accidentally amputated
23408 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
23410 * rootcontext.cs: Load manually enum to allow core classes to
23411 contain enumerations.
23413 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
23414 Update to new static methods in TypeManager.
23416 * typemanager.cs (GetMethod, GetConstructor): Use our
23417 implementation of FindMembers to find the members, since during
23418 corlib compilation, the types are TypeBuilders and GetMethod and
23419 GetConstructor do not work.
23421 Make all methods in TypeManager static.
23423 (InitCodeHelpers): Split the functionality from
23424 the InitCodeTypes function.
23426 * driver.cs: Call InitCodeHelpers after we have populated the
23429 * cs-parser.jay (delegate_declaration): we did not used to compute
23430 the delegate name correctly for void delegates.
23432 2002-03-24 Miguel de Icaza <miguel@ximian.com>
23434 * rootcontext.cs (RootContext): Init the interface_resolve_order
23435 and type_container_resolve_order always.
23437 (ResolveCore, BootstrapCorlib_ResolveClass,
23438 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
23439 compiler when compiling with --nostdlib
23441 * class.cs (TypeContainer.DefineType): Check that our parent is
23442 not null. This test is most important when we are bootstraping
23445 * codegen.cs: Split out the symbol writing code.
23447 2002-03-25 Martin Baulig <martin@gnome.org>
23449 * driver.cs (-g): Made -g an alias for --debug.
23451 2002-03-24 Martin Baulig <martin@gnome.org>
23453 * codegen.cs (SymbolWriter): New public variable. Returns the
23454 current symbol writer.
23455 (CodeGen): Added `bool want_debugging_support' argument to the
23456 constructor. If true, tell the ModuleBuild that we want debugging
23457 support and ask it for the ISymbolWriter.
23458 (Save): If we have a symbol writer, call it's Close() method after
23459 saving the assembly.
23461 * driver.c (--debug): New command line argument to create a
23462 debugger information file.
23464 * location.cs (SymbolDocument): New public property. Returns an
23465 ISymbolDocumentWriter object for the current source file or null
23466 if we don't have a symbol writer.
23468 2002-03-21 Miguel de Icaza <miguel@ximian.com>
23470 * driver.cs (LoadAssembly): Correctly return when all the paths
23471 have been tried and not before.
23473 * statement.cs (Switch.Emit): return the actual coverage for this
23474 statement (returns/not-returns)
23476 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
23477 switch of the statement if we are the last switch section. That
23478 kills two problems: try/catch problems (we used to emit an empty
23479 nop at the end) and switch statements where all branches would
23482 2002-03-19 Miguel de Icaza <miguel@ximian.com>
23484 * driver.cs: Add default assemblies (the equivalent to the
23485 Microsoft CSC.RSP file)
23487 * cs-tokenizer.cs: When updating `cols and setting it to zero,
23488 also update tokens_seen and set it to false.
23490 * driver.cs: Implement --recurse for Mike.
23492 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
23493 correctly splitting out the paths.
23495 2002-03-18 Miguel de Icaza <miguel@ximian.com>
23497 * interface.cs (Interface.PopulateProperty): Instead of using
23498 `parent' as the declaration space for the set parameters, use
23501 * support.cs (InternalParameters): InternalParameters constructor
23502 takes a DeclSpace instead of a TypeContainer.
23504 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
23505 types are being initialized, load the address of it before calling
23508 (New): Provide a mechanism to disable the generation of local
23509 value type temporaries when the caller will be providing us with
23510 an address to store it.
23512 (ArrayCreation.EmitDynamicInitializers): Use it.
23514 2002-03-17 Miguel de Icaza <miguel@ximian.com>
23516 * expression.cs (Invocation.EmitArguments): Only probe for array
23517 property if there is more than one argument. Sorry about that.
23519 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
23520 empty param arrays.
23522 * class.cs (Method.LabelParameters): Fix incorrect code path that
23523 prevented the `ParamArrayAttribute' from being applied to the
23526 2002-03-16 Miguel de Icaza <miguel@ximian.com>
23528 * support.cs (ReflectionParameters): Correctly compute whether the
23529 last argument is a params array. Fixes the problem with
23532 * typemanager.cs: Make the assemblies array always be non-null
23533 (empty, but non-null)
23535 * tree.cs (RecordDecl): New function that abstracts the recording
23536 of names. This reports error 101, and provides a pointer to the
23537 previous declaration. Fixes a crash in the compiler.
23539 * cs-parser.jay (constructor_declaration): Update to new grammar,
23540 and provide a constructor_body that can be empty.
23542 2002-03-15 Miguel de Icaza <miguel@ximian.com>
23544 * driver.cs: Add support for --resources.
23546 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
23547 Make all types for the various array helper methods be integer.
23549 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
23550 CheckState to ConvCast.
23552 (ConvCast): Now it takes a `checked' state argument, to avoid
23553 depending on the emit context for the conversion, and just using
23554 the resolve time setting.
23556 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
23557 instead of Invocation.EmitArguments. We do not emit the original
23558 arguments, instead we emit those which have been converted to
23559 unsigned int expressions.
23561 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
23563 * codegen.cs: ditto.
23565 * expression.cs (LocalVariableReference): Drop the use of the
23566 Store function that depended on the variable index.
23568 * statement.cs (VariableInfo): Drop the `Idx' property from this
23569 class, as this is not taking into account the indexes for
23570 temporaries tat we generate during the execution, getting the
23573 * class.cs: First emit class initializers, then call the parent
23576 * expression.cs (Binary): Fix opcode emision.
23577 (UnaryMutator.EmitCode): Support checked code generation
23579 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
23580 matches for events for both the Static and Instance scans,
23581 pointing to the same element. Fix that.
23583 2002-03-14 Miguel de Icaza <miguel@ximian.com>
23585 * rootcontext.cs (ResolveTree): Always set the
23586 interface_resolve_order, because nested interfaces will be calling
23589 * class.cs (GetInterfaceOrClass): Track the same resolution
23590 process used by TypeManager.LookupType. This fixes the nested
23591 type lookups in class declarations (separate path from
23594 (TypeContainer.DefineType): Also define nested interfaces.
23595 (TypeContainer.RegisterOrder): New public function used to
23596 register the order in which child interfaces need to be closed.
23598 Nested interfaces need to be closed after their parents have been
23601 * interface.cs (InterfaceAttr): Put all the logic for computing
23602 the interface attribute here.
23604 (DefineInterface): Register our interface order with the
23605 RootContext or with the TypeContainer depending on the case.
23607 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23609 * cs-parser.jay: rework foreach statement to work with the new
23610 changes to the policy on SimpleNames.
23612 * report.cs: support Stacktrace on warnings as well.
23614 * makefile: drop --unsafe and /unsafe from the compile.
23616 2002-03-13 Ravi Pratap <ravi@ximian.com>
23618 * ecore.cs (StandardConversionExists): Modify to take an Expression
23619 as the first parameter. Ensure we do null -> reference type conversion
23622 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
23623 temporary Expression objects.
23625 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
23627 * interface.cs: workaround bug in method overloading resolution
23628 (there is already a bugzilla bug for it).
23630 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23632 We could also solve this problem by having a separate path for
23633 performing type lookups, instead of DoResolve, we could have a
23634 ResolveType entry point, and only participating pieces of the
23635 production (simplename, deref, array) would implement this.
23637 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
23638 signal SimpleName to only resolve type names and not attempt to
23639 resolve anything else.
23641 * expression.cs (Cast): Set the flag.
23643 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
23645 * class.cs: Only report 108 if there is no `new' modifier.
23647 * cs-parser.jay: rework foreach statement to work with the new
23648 changes to the policy on SimpleNames.
23650 * report.cs: support Stacktrace on warnings as well.
23652 * makefile: drop --unsafe and /unsafe from the compile.
23654 2002-03-11 Miguel de Icaza <miguel@ximian.com>
23656 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23657 lookups here, instead of doing that at parse time. This means
23658 that our grammar will not introduce `LocalVariableReferences' as
23659 expressions at this point. That solves the problem of code like
23663 static void Main ()
23667 This is only half the fix. The full fix requires parameters to
23668 also be handled in this way.
23670 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
23671 makes the use more obvious of the DeclSpace. The
23672 ec.TypeContainer.TypeBuilder is now only used to pull the
23673 TypeBuilder for it.
23675 My theory is that I can get rid of the TypeBuilder completely from
23676 the EmitContext, and have typecasts where it is used (from
23677 DeclSpace to where it matters).
23679 The only pending problem is that the code that implements Aliases
23680 is on TypeContainer, and probably should go in DeclSpace.
23682 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23683 lookups here, instead of doing that at parse time. This means
23684 that our grammar will not introduce `LocalVariableReferences' as
23685 expressions at this point. That solves the problem of code like
23689 static void Main ()
23693 This is only half the fix. The full fix requires parameters to
23694 also be handled in this way.
23696 * class.cs (Property.DefineMethod): When implementing an interface
23697 method, set newslot, when implementing an abstract method, do not
23698 set the flag (before we tried never setting it, or always setting
23699 it, which is the difference).
23700 (Indexer.DefineMethod): same.
23701 (Method.DefineMethod): same.
23703 * ecore.cs: Only set the status used flag if we get back a Field.
23705 * attribute.cs: Temporary hack, so Paolo can keep working.
23707 2002-03-08 Ravi Pratap <ravi@ximian.com>
23709 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
23710 the unmanaged type in the case we have a MarshalAs attribute.
23712 (Resolve): Handle the case when we are parsing the special MarshalAs
23713 attribute [we need to store the unmanaged type to use later]
23715 * typemanager.cs (marshal_as_attr_type): Built in type for the
23716 MarshalAs Attribute.
23718 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
23719 on parameters and accordingly set the marshalling info.
23721 2002-03-09 Miguel de Icaza <miguel@ximian.com>
23723 * class.cs: Optimizing slightly by removing redundant code after
23724 we switched to the `NoTypes' return value.
23725 (Property.DefineMethod): use NoTypes here too.
23727 This fixes the bug I introduced in my last batch of changes.
23729 2002-03-05 Ravi Pratap <ravi@ximian.com>
23731 * tree.cs (RecordEnum): Add. We now keep track of enums too.
23733 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
23734 Enums since those are types too.
23736 * cs-parser.jay (enum_declaration): Record enums as we parse them.
23738 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
23739 thanks to a call during the lookup process.
23741 2002-03-07 Miguel de Icaza <miguel@ximian.com>
23743 * statement.cs (Foreach): Lots of work to accomodate a particular
23744 kind of foreach statement that I had not kept in mind. It is
23745 possible to have foreachs on classes that provide a GetEnumerator
23746 method that return objects that implement the "pattern" for using
23747 a foreach, there is no need to support GetEnumerator
23750 This is needed to compile nant.
23752 * decl.cs: Only report 114 if the member is not `Finalize' and if
23753 the warning level is at least 2.
23755 * class.cs: Moved the compare function from Method to
23758 (MethodSignature.InheritableMemberSignatureCompare): Add new
23759 filter function that is used to extract inheritable methods from a
23762 (Method.Define): Use the new `inheritable_method_signature_filter'
23765 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
23768 2002-03-06 Miguel de Icaza <miguel@ximian.com>
23770 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
23772 * cs-parser.jay: Add opt_semicolon to the interface declaration.
23774 * expression.cs: Pass location information to
23775 ConvertImplicitStandard.
23777 * class.cs: Added debugging code to track return values from
23780 2002-03-05 Miguel de Icaza <miguel@ximian.com>
23782 * expression.cs (Is.DoResolve): If either side of the `is' is an
23783 interface, do not flag the warning.
23785 * ecore.cs (ImplicitReferenceConversion): We need a separate test
23788 * report.cs: Allow for --fatal to be used with --probe.
23790 * typemanager.cs (NoTypes): Move the definition for the empty Type
23793 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
23795 (TypeContainer.DefineProxy): New function used to proxy to parent
23796 implementations when implementing interfaces.
23797 (TypeContainer.ParentImplements): used to lookup if our parent
23798 implements a public function that is required by an interface.
23799 (TypeContainer.VerifyPendingMethods): Hook this up.
23801 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
23802 `modules' and `assemblies' arraylists into arrays. We only grow
23803 these are the very early start up of the program, so this improves
23804 the speedof LookupType (nicely measured).
23806 * expression.cs (MakeByteBlob): Replaced unsafe code with
23807 BitConverter, as suggested by Paolo.
23809 * cfold.cs (ConstantFold.Binary): Special case: perform constant
23810 folding of string concatenation, but if either side is a string,
23811 and the other is not, then return null, and let the runtime use
23812 the concatenation on the string plus the object (using
23813 `Object.ToString').
23815 2002-03-04 Miguel de Icaza <miguel@ximian.com>
23817 Constant Folding has been implemented now.
23819 * expression.cs (Unary.Reduce): Do not throw an exception, catch
23820 the error instead on types that are not supported in one's
23823 * constant.cs (Constant and all children): New set of functions to
23824 perform implict and explicit conversions.
23826 * ecore.cs (EnumConstant): Implement the new functions to perform
23827 conversion by proxying to the child expression.
23829 * codegen.cs: (ConstantCheckState): Constant evaluation has its
23830 own separate setting that can not be turned off from the command
23831 line using --unchecked or --checked and is only controlled using
23832 the checked/unchecked statements and expressions. This setting is
23833 used by the constant folder to flag errors.
23835 * expression.cs (CheckedExpr, UncheckedExpr): Set the
23836 ConstantCheckState as well.
23838 During Resolve, they also have to flag the state, because the
23839 constant folder runs completely in the Resolve phase.
23841 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
23844 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23846 * cfold.cs: New file, this file contains the constant folder.
23848 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
23849 argument to track whether we are using the resulting address to
23850 load or store a value and provide better error messages.
23852 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
23853 new AddressOf arguments.
23855 * statement.cs (Foreach.EmitCollectionForeach): Update
23857 * expression.cs (Argument.Emit): Call AddressOf with proper
23858 arguments to track usage.
23860 (New.DoEmit): Call AddressOf with new arguments.
23862 (Unary.Emit): Adjust AddressOf call.
23864 2002-03-01 Ravi Pratap <ravi@ximian.com>
23866 * cs-parser.jay (member_access): Change the case for pre-defined types
23867 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23870 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23873 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23874 essentially like methods and apply attributes like MethodImplOptions to them too.
23876 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23879 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23880 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23883 * Update code everywhere accordingly.
23885 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23887 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23889 2002-02-28 Ravi Pratap <ravi@ximian.com>
23891 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23892 try performing lookups against those instead of jumping straight into using
23893 the 'using' clauses.
23895 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23897 (LookupType): Perform lookups in implicit parents too.
23899 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23900 sequence as RootContext.LookupType.
23902 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23903 the various cases of namespace lookups into this method.
23905 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23907 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23908 in positional arguments)
23910 * class.cs (Operator): Update the AllowedModifiers to contain
23913 * cs-parser.jay: Update operator declaration to allow for the
23914 operator body to be empty.
23916 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23919 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23921 * class.cs (Method.Emit): Label parameters.
23923 * driver.cs: Return 1 or 0 as the program exit code.
23925 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23927 * expression.cs: Special case the `null' object when trying to
23928 auto-compute the type, as anything can be explicitly converted to
23931 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23932 spotting this Paolo.
23934 (Expression.ImplicitNumericConversion): Perform comparissions of
23935 the type using the underlying type in the case of an enumeration
23936 rather than using the enumeration type for the compare.
23938 Cope with the underlying == type case, which is not possible to
23941 (Expression.ConvertNumericExplicit): Perform comparissions of
23942 the type using the underlying type in the case of an enumeration
23943 rather than using the enumeration type for the compare.
23945 * driver.cs: If the user does not supply an extension, assume .exe
23947 * cs-parser.jay (if_statement): Rewrote so that we can track the
23948 location for the if statement.
23950 * expression.cs (Binary.ConstantFold): Only concat strings when
23951 the operation is "+", not everything ;-)
23953 * statement.cs (Statement.EmitBoolExpression): Take a location
23955 (If, While, Do): Track location.
23957 * expression.cs (Binary.ResolveOperator): In the object + string
23958 case, I was missing a call to ConvertImplicit
23960 2002-02-25 Ravi Pratap <ravi@ximian.com>
23962 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23963 Location arguments. Ensure we use RootContext.LookupType to do our work
23964 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23966 * interface.cs (PopulateMethod): Handle the type of the parameter being
23969 * expression.cs (Invocation.BetterFunction): Handle the case when we
23970 have a params method with no fixed arguments and a call is made with no
23973 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23975 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23976 the verbatim-string-literal
23978 * support.cs (InternalParameters.ParameterModifier): handle null
23980 (InternalParameters.ParameterType): ditto.
23982 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
23983 duplicating the name of the variable parameter.
23984 (GetParameterByName): Fix bug where we were not looking up array
23985 paramters if they were the only present (thanks Paolo!).
23986 (GetParameterInfo): We only have an empty set of types if both
23987 fixed and array are set to null.
23988 (GetParameterInfo-idx): Handle FixedParameter == null
23990 * cs-parser.jay: Handle the case where there is no catch
23991 statements (missing null test).
23993 2002-02-22 Miguel de Icaza <miguel@ximian.com>
23995 * driver.cs (MainDriver): Be conservative on our command line
23998 Catch DirectoryNotFoundException when calling GetFiles.
24000 (SplitPathAndPattern): Used to split the input specification into
24001 a path and a pattern that we can feed to Directory.GetFiles.
24003 2002-02-21 Miguel de Icaza <miguel@ximian.com>
24005 * statement.cs (Fixed): Implement the last case of the Fixed
24006 statement (string handling).
24008 * expression.cs (StringPtr): New class used to return a char * to
24009 a string; Used by the Fixed statement.
24011 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
24013 * expression.cs (Binary.ResolveOperator): Remove redundant
24014 MemberLookup pn parent type.
24015 Optimize union call, we do not need a union if the types are the same.
24016 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
24019 Specialize the use of MemberLookup everywhere, instead of using
24020 the default settings.
24022 (StackAlloc): Implement stackalloc keyword.
24024 * cs-parser.jay: Add rule to parse stackalloc.
24026 * driver.cs: Handle /h, /help, /?
24028 * expression.cs (MakeByteBlob): Removed the hacks we had in place
24029 before we supported unsafe code.
24031 * makefile: add --unsafe to the self compilation of mcs.
24033 2002-02-20 Miguel de Icaza <miguel@ximian.com>
24035 * expression.cs (PointerArithmetic): New class that is used to
24036 perform pointer arithmetic.
24037 (Binary.Resolve): Handle pointer arithmetic
24038 Handle pointer comparission.
24039 (ArrayPtr): Utility expression class that is used to take the
24040 address of an array.
24042 (ElementAccess): Implement array access for pointers
24044 * statement.cs (Fixed): Implement fixed statement for arrays, we
24045 are missing one more case before we are done.
24047 * expression.cs (Indirection): Implement EmitAssign and set the
24048 ExprClass to Variable. This allows pointer dereferences to be
24049 treated as variables, and to have values assigned to them.
24051 * ecore.cs (Expression.StoreFromPtr): New utility function to
24052 store values dereferencing.
24054 2002-02-20 Ravi Pratap <ravi@ximian.com>
24056 * expression.cs (Binary.ResolveOperator): Ensure that we are
24057 not trying to operate on a void type - this fixes the reported
24060 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
24061 the parent implementation is sealed.
24063 * ../errors/cs0239.cs : Add.
24065 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
24067 * typemanager.cs (unverifiable_code_type): Corresponds to
24068 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
24069 which have unsafe code in them.
24071 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
24074 2002-02-19 Miguel de Icaza <miguel@ximian.com>
24076 * cs-tokenizer.cs: Add support for @"litreal strings"
24078 Make tokenizer accept pre-processor directives
24079 on any column (remove the old C-like limitation).
24081 * rootcontext.cs (EmitCode): Emit any global attributes.
24082 (AddGlobalAttributes): Used to keep track of assembly attributes.
24084 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
24086 * cs-parser.jay: Add support for global attributes.
24088 2002-02-17 Miguel de Icaza <miguel@ximian.com>
24090 * expression.cs (Indirection): New helper class. Unary will
24091 create Indirection classes to be able to implement the
24092 IMemoryLocation interface on it.
24094 2002-02-16 Miguel de Icaza <miguel@ximian.com>
24096 * cs-parser.jay (fixed_statement): reference the right statement.
24098 * statement.cs (Fixed.Emit): Finish implementing the fixed
24099 statement for the &x case.
24101 2002-02-14 Miguel de Icaza <miguel@ximian.com>
24103 * class.cs (Property.Define, Method.Define): Remove newslot when
24106 * modifiers.cs: My use of NewSlot when `Abstract' was set was
24107 wrong. NewSlot should only be used if the `new' keyword is present.
24109 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
24110 locating our system dir. Sorry about this.
24112 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24114 * driver.cs (GetSystemDir): Compute correctly the location of our
24115 system assemblies. I was using the compiler directory instead of
24116 the library directory.
24118 2002-02-13 Ravi Pratap <ravi@ximian.com>
24120 * expression.cs (BetterFunction): Put back in what Miguel commented out
24121 since it is the correct fix. The problem is elsewhere ;-)
24123 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
24124 parameters of the parms method are themselves compatible or not !
24126 (StandardConversionExists): Fix very dangerous bug where we were forgetting
24127 to check that a class implements an interface before saying that an implicit
24128 conversion was allowed. Use ImplementsInterface to do the checking.
24130 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24132 * class.cs (Method.Define): Track whether we are an explicit
24133 implementation or not. And only call DefineMethodOverride if we
24134 are an explicit implementation.
24136 (Property.DefineMethod): Ditto.
24138 2002-02-11 Ravi Pratap <ravi@ximian.com>
24140 * expression.cs (BetterFunction): Catch hideous bug which was
24141 preventing us from detecting ambiguous calls due to implicit casts i.e
24144 2002-01-29 Miguel de Icaza <miguel@ximian.com>
24146 * support.cs (Pair): Remove un-needed method. I figured why I was
24147 getting the error in cs-parser.jay, the variable in a foreach loop
24148 is readonly, and the compiler does not really treat this as a variable.
24150 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
24151 instead of EQUALS in grammar.
24153 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
24155 * expression.cs (Unary.DoResolve): Check whether the argument is
24158 2002-01-28 Miguel de Icaza <miguel@ximian.com>
24160 * support.cs: Api for Pair to set a value. Despite the fact that
24161 the variables are public the MS C# compiler refuses to compile
24162 code that accesses the field if the variable is part of a foreach
24165 * statement.cs (Fixed): Begin implementation of the fixed
24168 (Block.AddVariable): Return the VariableInfo on success and null
24169 on failure instead of true/false.
24171 * cs-parser.jay (foreach): Catch errors on variables already
24172 defined (we were ignoring this value before) and properly unwind
24173 the block hierarchy
24175 (fixed_statement): grammar for the fixed statement.
24177 2002-01-25 Miguel de Icaza <miguel@ximian.com>
24179 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
24180 pointer types to be incretemented.
24182 (SizeOf): Implement.
24184 * cs-parser.jay (pointer_member_access): Implement
24185 expr->IDENTIFIER production.
24187 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
24188 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
24191 (Unary): Implement indirection.
24193 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
24194 use in non-unsafe context).
24196 (SimpleName.DoResolve): Check for pointers in field access on safe
24199 (Expression.LoadFromPtr): Factor the load-indirect code in this
24200 function. This was duplicated in UnboxCast and ParameterReference
24202 2002-01-24 Miguel de Icaza <miguel@ximian.com>
24204 * expression.cs (ComposedCast): report an error if a pointer cast
24205 is used in a safe region.
24207 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
24208 pointer type casts in unsafe context.
24210 * codegen.cs (EmitContext): Set up IsUnsafe.
24212 * cs-parser.jay (non_expression_type): Add productions for pointer
24215 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
24216 code. We should not use force into static mode if the method is
24217 not virtual. Fixes bug in MIS
24219 * statement.cs (Do.Emit, While.Emit, For.Emit,
24220 Statement.EmitBoolExpression): Add support to Do and While to
24221 propagate infinite loop as `I do return' semantics.
24223 Improve the For case to also test for boolean constants.
24225 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
24226 to the list of attributes we can add.
24228 Remove `EmitContext' argument.
24230 * class.cs (Method.Define): Apply parameter attributes.
24231 (Constructor.Define): Apply parameter attributes.
24232 (MethodCore.LabelParameters): Move here the core of labeling
24235 * support.cs (ReflectionParameters.ParameterModifier,
24236 InternalParameters.ParameterModifier): Use IsByRef on the type and
24237 only return the OUT bit for these parameters instead of in/out/ref
24240 This is because I miss-understood things. The ParameterInfo.IsIn
24241 and IsOut represent whether the parameter has the [In] and [Out]
24244 2002-01-22 Miguel de Icaza <miguel@ximian.com>
24246 * ecore.cs (FieldExpr.Emit): Release temporaries.
24248 * assign.cs (LocalTemporary.Release): new function.
24250 * codegen.cs (EmitContext.GetTemporaryStorage,
24251 EmitContext.FreeTemporaryStorage): Rework the way we deal with
24252 temporary storage. Now we can "put back" localbuilders when we
24255 2002-01-21 Miguel de Icaza <miguel@ximian.com>
24257 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
24258 need to make a copy of the variable to generate verifiable code.
24260 2002-01-19 Miguel de Icaza <miguel@ximian.com>
24262 * driver.cs: Compute dynamically the system directory.
24264 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
24265 Slower, but more generally useful. Used by the abstract
24266 registering implementation.
24268 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
24269 the rules for the special rule on Type/instances. First check if
24270 we have the same name, and if so, try that special static path
24271 rather than the instance path.
24273 2002-01-18 Miguel de Icaza <miguel@ximian.com>
24275 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
24278 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
24279 Enum, ValueType, Delegate or Array for non-corlib compiles.
24281 * cs-tokenizer.cs: Catch long identifiers (645)
24283 * typemanager.cs (IndexerPropetyName): Ravi never tested this
24286 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
24287 fix, we were returning too early, so we were not registering
24288 pending methods from abstract classes.
24290 Do not register pending methods if the class is abstract.
24292 * expression.cs (Conditional.DoResolve): Report circular implicit
24293 conversions when we neecd to compute it for conditional
24296 (Is.DoResolve): If the expression is always of the provided type,
24297 flag warning 183. If the expression can not ever be of the
24298 provided type flag warning 184.
24300 * class.cs: Catch 169 as well.
24302 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
24305 2002-01-18 Nick Drochak <ndrochak@gol.com>
24307 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
24309 2002-01-17 Miguel de Icaza <miguel@ximian.com>
24311 * interface.cs: (PopulateMethod): Check for pointers being defined
24312 only if the unsafe context is active.
24313 (PopulateProperty): ditto.
24314 (PopulateIndexer): ditto.
24316 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
24317 specified. If pointers are present, make sure that they are
24318 present in an unsafe context.
24319 (Constructor, Constructor.Define): ditto.
24320 (Field, Field.Define): ditto.
24321 (Property, Property.Define): ditto.
24322 (Event, Event.Define): ditto.
24324 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
24325 hashtable if there are classes or structs defined.
24327 * expression.cs (LocalVariableReference.DoResolve): Simplify this
24328 code, as the constant resolution moved.
24330 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
24331 the metadata, so we can flag error 133.
24333 * decl.cs (MemberCore.UnsafeOK): New function to test that a
24334 pointer is being declared in an unsafe context.
24336 2002-01-16 Miguel de Icaza <miguel@ximian.com>
24338 * modifiers.cs (Modifiers.Check): Require a Location argument.
24339 Report error 227 for Unsafe use.
24341 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
24343 * statement.cs (For.Emit): If the test is null, then report that
24344 we do `return', as we wont reach anything afterwards.
24346 (Switch.SwitchGoverningType): Track the expression that matched
24349 * driver.cs: Allow negative numbers as an error code to flag.
24351 * cs-parser.jay: Handle 1551.
24353 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
24355 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24357 * cs-parser.jay: Report 1518 (type declaration can only contain
24358 class, struct, interface, enum or delegate)
24360 (switch_label): Report 1523 (keywords `case' or `default' must
24363 (opt_switch_sections): Report 1522 (empty switch)
24365 * driver.cs: Report 1515 (response file specified multiple times)
24366 Report 1516 (Source file specified multiple times).
24368 * expression.cs (Argument.Resolve): Signal 1510
24370 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
24371 access not allowed in static code)
24373 2002-01-11 Ravi Pratap <ravi@ximian.com>
24375 * typemanager.cs (IsPointerType): Utility method which we are going
24378 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
24379 the object type, so we take care of that.
24381 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
24383 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
24384 added to non-params parameters :-)
24386 * typemanager.cs (CSharpName): Include 'void' type too.
24388 (void_ptr_type): Include in the set of core types.
24390 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
24393 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
24396 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
24397 completely forgotten about it.
24399 2002-01-10 Ravi Pratap <ravi@ximian.com>
24401 * cs-parser.jay (pointer_type): Add. This begins our implementation
24402 of parsing rules for unsafe code.
24404 (unsafe_statement): Implement.
24406 (embedded_statement): Modify to include the above.
24408 * statement.cs (Unsafe): Implement new class for unsafe blocks.
24410 * codegen.cs (EmitContext.InUnsafe): Add. This determines
24411 if the current context is an unsafe one.
24413 * cs-parser.jay (local_variable_pointer_type): Since local variable types
24414 are handled differently, we need separate rules for them.
24416 (local_variable_declaration): Update to use local_variable_pointer_type
24417 to allow variable declarations of unmanaged pointer types.
24419 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
24420 in unsafe contexts.
24422 * ../errors/cs0214.cs : Add.
24424 2002-01-16 Nick Drochak <ndrochak@gol.com>
24426 * makefile: remove 'response' file when cleaning.
24428 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24430 * cs-parser.jay: Report 1524.
24432 2002-01-14 Miguel de Icaza <miguel@ximian.com>
24434 * typemanager.cs (RegisterMethod): drop checking if we have
24435 registered this from here
24437 2002-01-12 Miguel de Icaza <miguel@ximian.com>
24439 * class.cs (Method.EmitDestructor): Implement calling our base
24442 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
24443 value of InFinally.
24445 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
24446 this routine and will wrap the call in a try/catch block. Deal
24449 2002-01-11 Miguel de Icaza <miguel@ximian.com>
24451 * ecore.cs (Expression.MemberLookup): instead of taking a
24452 parameter `same_type' that was used to tell whether we could
24453 access private members we compute our containing type from the
24456 (FieldExpr): Added partial support for volatile fields. This does
24457 not work for volatile fields exposed from assemblies, as I can not
24458 figure out how to extract the modreq from it.
24460 Updated all the source files to use this.
24462 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
24463 because it is referenced by MemberLookup very often.
24465 2002-01-09 Ravi Pratap <ravi@ximian.com>
24467 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
24468 TypeBuilder.GetCustomAttributes to retrieve what we need.
24470 Get rid of redundant default_member_attr_type as this is the same as
24471 default_member_type which already exists.
24473 * interface.cs, attribute.cs : Update accordingly.
24475 2002-01-08 Miguel de Icaza <miguel@ximian.com>
24477 * typemanager.cs: Enable IndexerPropertyName again. It does not
24478 work for TYpeBuilders though. Ravi, can you please fix this?
24480 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
24482 * expression.cs (Argument.Emit): Handle the case of ref objects
24483 being passed to ref functions;
24485 (ParameterReference.EmitLoad): Loads the content of the pointer
24486 without dereferencing.
24488 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24490 * cs-tokenizer.cs: Implemented the pre-processing expressions.
24492 2002-01-08 Ravi Pratap <ravi@ximian.com>
24494 * class.cs (Indexer.DefineMethod): Incorporate the interface
24495 type in the name of the method if we are doing explicit interface
24498 * expression.cs (ConversionExists): Remove as it is completely obsolete.
24500 (BetterConversion): Fix extremely trivial bug where we were referring to
24501 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
24504 * ../errors/bug16.cs : Add although we have fixed it.
24506 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24508 * expression.cs (BaseIndexer): Begin implementation.
24510 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
24512 * cs-parser.jay (indexer_declarator): Use qualified_identifier
24513 production directly to remove a shift/reduce, and implement
24514 explicit interface implementation.
24516 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
24517 after a floating point suffix.
24519 * expression.cs (DoNumericPromotions): Improved the conversion for
24520 uint/uint. If we have a constant, we avoid doing a typecast to a
24523 * class.cs (Indexer): Implement explicit interface implementation
24526 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
24528 * class.cs: make the default instance constructor public and hidebysig.
24530 2001-01-03 Ravi Pratap <ravi@ximian.com>
24532 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
24533 so we can call it from elsewhere.
24535 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
24536 we emit it internally if the class has a defined indexer; otherwise the user
24537 emits it by decorating the class definition with the DefaultMemberAttribute.
24539 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
24540 attribute is not used on a type which defines an indexer.
24542 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
24543 character when we skip whitespace.
24545 * ../errors/cs0646.cs : Add.
24547 2002-01-03 Miguel de Icaza <miguel@ximian.com>
24549 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
24552 * makefile: Add practical target `mcs3.exe' which builds the third
24553 generation compiler.
24555 * expression.cs (New): Fix structures constructor calling.
24557 * class.cs (Property, Method, Indexer): Emit Final flag on the
24558 method if we are an interface implementation and we are not
24561 * ecore.cs (PropertyExpr): New public field `IsBase', tells
24562 whether this property is referencing a `base' method.
24564 * expression.cs (Invocation.EmitCall): take an extra argument:
24565 is_base, this is used to determine whether the `call' or
24566 `callvirt' opcode should be used.
24569 * delegate.cs: update EmitCall.
24571 * class.cs (Method.Define): Set NewSlot for the cases where we are
24572 not implementing an interface method.
24574 (Property.Define): ditto.
24576 2002-01-02 Miguel de Icaza <miguel@ximian.com>
24578 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
24579 'r'. Allows mcs to parse itself fully.
24581 2002-01-02 Ravi Pratap <ravi@ximian.com>
24583 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
24584 of the number of initializers that require the InitializeArray method.
24586 (CheckIndices): Store the Expression in all cases - not the plain value. Also
24587 update the above field where necessary.
24589 (MakeByteBlob): Update accordingly.
24591 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
24594 (EmitDynamicInitializers): Update in accordance with the new optimization.
24596 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
24597 same OpCode applies.
24599 * cs-parser.jay : Fix some glaring errors I introduced.
24601 2002-01-01 Ravi Pratap <ravi@ximian.com>
24603 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
24604 so that we can check for name clashes there too.
24606 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
24607 for interface indexers.
24609 * interfaces.cs (Define): Emit the default member attribute.
24611 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
24612 variable was being referred to while setting the value ;-)
24614 2002-01-01 Miguel de Icaza <miguel@ximian.com>
24616 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
24617 byte-by-byte information when we know the data is zero.
24619 Make the block always a multiple of 4, because
24620 DefineInitializedData has a bug.
24622 * assign.cs: Fix, we should assign from the temporary, not from
24625 * expression.cs (MakeByteBlob): Fix my incorrect code.
24627 2001-12-31 Miguel de Icaza <miguel@ximian.com>
24629 * typemanager.cs (EnumToUnderlying): This function is used to get
24630 the underlying type from an enumeration, because it does not
24633 * constant.cs: Use the I4_S form for values between -128 and 127.
24635 * statement.cs (Block.LookupLabel): Looks up a label.
24636 (Block): Drop support for labeled blocks.
24638 (LabeledStatement): New kind of statement that represents a label
24641 (Goto): Finally implement this bad boy.
24643 * cs-parser.jay: Update to reflect new mechanism to implement
24646 2001-12-30 Miguel de Icaza <miguel@ximian.com>
24648 * codegen.cs (EmitContext.This): a codegen property that keeps the
24649 a single instance of this instead of creating many different this
24652 * delegate.cs (Delegate.DoResolve): Update to use the property;
24654 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
24656 * expression.cs (BaseAccess.DoResolve): Ditto.
24658 2001-12-29 Ravi Pratap <ravi@ximian.com>
24660 * typemanager.cs (methodimpl_attr_type): Add to hold the type
24661 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
24663 (InitCoreTypes): Update accordingly.
24665 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
24666 so we can quickly store the state.
24668 (ApplyAttributes): Set the correct implementation flags
24669 for InternalCall methods.
24671 2001-12-29 Miguel de Icaza <miguel@ximian.com>
24673 * expression.cs (EmitCall): if a method is not virtual, then do
24674 not use callvirt on it.
24676 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
24677 user defined stuff) requires the use of stobj, which takes an
24678 address on the stack instead of an array and an index. So emit
24679 the Ldelema operation for it.
24681 (EmitStoreOpcode): Use stobj for valuetypes.
24683 (UnaryMutator.EmitCode): Use the right 1 value depending on
24684 whether we are dealing with int64/uint64, float or doubles.
24686 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
24687 constructors that I implemented last night.
24689 (Constructor.IsDefault): Fix to work properly for static
24692 * cs-parser.jay (CheckDef): report method signature errors.
24693 Update error number 103 to be 132.
24695 * decl.cs: New AdditionResult enumeration value: MethodExists.
24696 Although we do this check for methods later on in the semantic
24697 analysis, catching repeated default constructors is so easy that
24698 we catch these here.
24700 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
24703 (ParameterReference.EmitAssign, Emit): handle
24706 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
24707 (ArrayAccess.EmitStoreOpcode): ditto.
24709 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
24711 * expression.cs (MakeByteBlob): Complete all the missing types
24712 (uint, short, ushort, byte, sbyte)
24714 * class.cs: Only init instance field initializers on instance
24717 Rename `constructors' to instance_constructors.
24719 (TypeContainer.AddConstructor): Only add constructors to the list
24720 if it is not static.
24722 Make sure that we handle default_static_constructor independently
24723 everywhere where we handle instance_constructors
24725 2001-12-28 Miguel de Icaza <miguel@ximian.com>
24727 * class.cs: Do not lookup or create a base initializer for a
24728 static constructor.
24730 (ConstructorInitializer.Resolve): use the proper type to lookup
24733 * cs-parser.jay: Report error 1585 (modifiers between type and name).
24735 * enum.cs, interface.cs: Remove CloseType, this is taken care by
24738 * decl.cs: CloseType is now an virtual method, the default
24739 implementation just closes this type.
24741 2001-12-28 Ravi Pratap <ravi@ximian.com>
24743 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
24744 to PreserveSig by default. Also emit HideBySig on such methods.
24746 Basically, set the defaults to standard values.
24748 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
24749 argument, if candidate is better, it can't be worse than the best !
24751 (Invocation): Re-write bits to differentiate between methods being
24752 applicable in their expanded form and their normal form - for params
24755 Get rid of use_standard everywhere as only standard conversions are allowed
24756 in overload resolution.
24758 More spec conformance.
24760 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24762 * driver.cs: Add --timestamp, to see where the compiler spends
24765 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
24766 `this' in static code.
24768 (SimpleName.DoResolve): Implement in terms of a helper function
24769 that allows static-references to be passed upstream to
24772 (Expression.ResolveWithSimpleName): Resolve specially simple
24773 names when called by MemberAccess to implement the special
24776 (Expression.ImplicitReferenceConversion): Handle conversions from
24777 Null to reference types before others, as Null's type is
24780 * expression.cs (Invocation.EmitCall): Handle the special case of
24781 calling methods declared on a reference type from a ValueType
24782 (Base classes System.Object and System.Enum)
24784 (MemberAccess.Resolve): Only perform lookups on Enumerations if
24785 the left hand side is a TypeExpr, not on every enumeration.
24787 (Binary.Resolve): If types are reference types, then do a cast to
24788 object on operators != and == of both arguments.
24790 * typemanager.cs (FindMembers): Extract instance and static
24791 members if requested.
24793 * interface.cs (PopulateProperty): Use void_type instead of null
24794 as the return type for the setter method.
24796 (PopulateIndexer): ditto.
24798 2001-12-27 Ravi Pratap <ravi@ximian.com>
24800 * support.cs (ReflectionParameters): Fix minor bug where we
24801 were examining the wrong parameter for the ParamArray attribute.
24803 Cope with requests for the type of the parameter at position
24804 greater than the params parameter's. We now return the element
24805 type of the params array as that makes more sense.
24807 * expression.cs (Invocation.IsParamsMethodApplicable): Update
24808 accordingly as we no longer have to extract the element type
24811 (Invocation.OverloadResolve): Update.
24813 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24815 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
24816 against IEnumerator, test whether the return value is a descendant
24817 of the IEnumerator interface.
24819 * class.cs (Indexer.Define): Use an auxiliary method to implement
24820 the other bits of the method definition. Begin support for
24821 explicit interface implementation.
24823 (Property.DefineMethod): Use TypeManager.void_type instead of null
24824 for an empty return value.
24826 2001-12-26 Miguel de Icaza <miguel@ximian.com>
24828 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
24829 dealing with a FieldExpr which is composed of a FieldBuilder, in
24830 the code path we did extract the constant, but we should have
24831 obtained the underlying value to be able to cast it (otherwise we
24832 end up in an infinite loop, this is what Ravi was running into).
24834 (ArrayCreation.UpdateIndices): Arrays might be empty.
24836 (MemberAccess.ResolveMemberAccess): Add support for section
24837 14.5.4.1 that deals with the special case of E.I when E is a type
24838 and something else, that I can be a reference to a static member.
24840 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
24841 handle a particular array type to create byte blobs, it is just
24842 something we dont generate byteblobs for.
24844 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
24847 * location.cs (Push): remove the key from the hashtable that we
24848 are about to add. This happens for empty files.
24850 * driver.cs: Dispose files after we have parsed them.
24852 (tokenize): new function that only runs the tokenizer on its
24853 input, for speed testing.
24855 2001-12-26 Ravi Pratap <ravi@ximian.com>
24857 * class.cs (Event.Define): Define the private field only if there
24858 are no accessors defined.
24860 * expression.cs (ResolveMemberAccess): If there is no associated
24861 field with the event, that means we have an event defined with its
24862 own accessors and we should flag error cs0070 since transforming
24863 ourselves into a field is not valid in that case.
24865 * ecore.cs (SimpleName.DoResolve): Same as above.
24867 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24868 and charset to sane values.
24870 2001-12-25 Ravi Pratap <ravi@ximian.com>
24872 * assign.cs (DoResolve): Perform check on events only if they
24873 are being accessed outside the declaring type.
24875 * cs-parser.jay (event_declarations): Update rules to correctly
24876 set the type of the implicit parameter etc.
24878 (add_accessor, remove_accessor): Set current local parameters.
24880 * expression.cs (Binary): For delegate addition and subtraction,
24881 cast the return value from the method into the appropriate delegate
24884 2001-12-24 Ravi Pratap <ravi@ximian.com>
24886 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24887 of these as the workaround is unnecessary.
24889 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24890 delegate data - none of that is needed at all.
24892 Re-write bits to extract the instance expression and the delegate method
24895 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24898 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24899 of attaching attributes instead of duplicating code everywhere.
24901 * everywhere : Update code to do attribute emission using the above method.
24903 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24905 * expression.cs (IsParamsMethodApplicable): if there are not
24906 parameters, return immediately.
24908 * ecore.cs: The 0 literal can be implicity converted to an enum
24911 (SimpleName.DoResolve): First lookup the type, then lookup the
24914 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24915 want to get its address. If the InstanceExpression is not
24916 addressable, store the result in a temporary variable, then get
24919 * codegen.cs: Only display 219 errors on warning level or above.
24921 * expression.cs (ArrayAccess): Make it implement the
24922 IMemoryLocation interface.
24924 (Binary.DoResolve): handle the operator == (object a, object b)
24925 and operator != (object a, object b) without incurring into a
24926 BoxedCast (because 5 != o should never be performed).
24928 Handle binary enumerator operators.
24930 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24931 value type, otherwise use Ldelem_ref.
24933 Use precomputed names;
24935 (AddressOf): Implement address of
24937 * cs-parser.jay (labeled_statement): Fix recursive block
24938 addition by reworking the production.
24940 * expression.cs (New.DoEmit): New has a special case:
24942 If we are dealing with a ValueType, we have a few
24943 situations to deal with:
24945 * The target of New is a ValueType variable, that is
24946 easy, we just pass this as the variable reference
24948 * The target of New is being passed as an argument,
24949 to a boxing operation or a function that takes a
24952 In this case, we need to create a temporary variable
24953 that is the argument of New.
24956 2001-12-23 Ravi Pratap <ravi@ximian.com>
24958 * rootcontext.cs (LookupType): Check that current_type is not null before
24959 going about looking at nested types.
24961 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24962 not implement the IAssignMethod interface any more.
24964 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24965 where we tranform them into FieldExprs if they are being resolved from within
24966 the declaring type.
24968 * ecore.cs (SimpleName.DoResolve): Do the same here.
24970 * assign.cs (DoResolve, Emit): Clean up code considerably.
24972 * ../errors/bug10.cs : Add.
24974 * ../errors/cs0070.cs : Add.
24976 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
24978 * assign.cs : Get rid of EventIsLocal everywhere.
24980 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24982 * ecore.cs (ConvertIntLiteral): finished the implementation.
24984 * statement.cs (SwitchLabel): Convert the value we are using as a
24985 key before looking up the table.
24987 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24989 * codegen.cs (EmitTopBlock): Require a Location argument now.
24991 * cs-parser.jay (constructor_declarator): We need to setup
24992 current_local_parameters before we parse the
24993 opt_constructor_initializer, to allow the variables to be bound
24994 to the constructor arguments.
24996 * rootcontext.cs (LookupType): First lookup nested classes in our
24997 class and our parents before we go looking outside our class.
24999 * expression.cs (ConstantFold): Extract/debox the values at the
25002 * rootcontext.cs (EmitCode): Resolve the constants first before we
25003 resolve the types. This is not really needed, but it helps debugging.
25005 * statement.cs: report location.
25007 * cs-parser.jay: pass location to throw statement.
25009 * driver.cs: Small bug fix.
25011 * report.cs: Updated format to be 4-zero filled digits.
25013 2001-12-22 Ravi Pratap <ravi@ximian.com>
25015 * expression.cs (CheckIndices): Fix minor bug where the wrong
25016 variable was being referred to ;-)
25018 (DoEmit): Do not call EmitStaticInitializers when the
25019 underlying type is System.Object.
25021 2001-12-21 Ravi Pratap <ravi@ximian.com>
25023 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
25024 and do the usual workaround for SRE.
25026 * class.cs (MyEventBuilder.EventType): New member to get at the type
25027 of the event, quickly.
25029 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
25031 * assign.cs (Assign.DoResolve): Handle the case when the target
25032 is an EventExpr and perform the necessary checks.
25034 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
25037 (SimpleName.MemberStaticCheck): Include check for EventExpr.
25039 (EventExpr): Set the type in the constructor itself since we
25040 are meant to be born fully resolved.
25042 (EventExpr.Define): Revert code I wrote earlier.
25044 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
25045 instance expression is null. The instance expression is a This in that case
25046 or a null, depending on whether it is a static method or not.
25048 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
25049 refers to more than one method.
25051 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
25052 and accordingly flag errors.
25054 2001-12-21 Miguel de Icaza <miguel@ximian.com>
25056 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
25058 2001-12-22 Miguel de Icaza <miguel@ximian.com>
25060 * location.cs (ToString): Provide useful rutine.
25062 2001-12-21 Miguel de Icaza <miguel@ximian.com>
25064 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
25065 objects, return the actual integral boxed.
25067 * statement.cs (SwitchLabel): define an ILLabel for each
25070 (Switch.CheckSwitch): If the value is a Literal, extract
25071 the underlying literal.
25073 Also in the unused hashtable we had, add the SwitchLabel so we can
25074 quickly look this value up.
25076 * constant.cs: Implement a bunch of new constants. Rewrite
25077 Literal based on this. Made changes everywhere to adapt to this.
25079 * expression.cs (Expression.MakeByteBlob): Optimize routine by
25080 dereferencing array only once, and also copes with enumrations.
25082 bytes are two bytes wide, not one.
25084 (Cast): Perform constant conversions.
25086 * ecore.cs (TryImplicitIntConversion): Return literals instead of
25087 wrappers to the literals here.
25089 * expression.cs (DoNumericPromotions): long literals can converted
25090 to ulong implicity (this is taken care of elsewhere, but I was
25091 missing this spot).
25093 * ecore.cs (Expression.Literalize): Make the return type Literal,
25094 to improve type checking.
25096 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
25098 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25100 * literal.cs: Revert code from ravi that checked the bounds. The
25101 bounds are sane by the definition of the type itself.
25103 * typemanager.cs: Fix implementation of ImplementsInterface. We
25104 need to actually look up in our parent hierarchy for interfaces
25107 * const.cs: Use the underlying type for enumerations
25109 * delegate.cs: Compute the basename for the delegate creation,
25110 that should fix the delegate test case, and restore the correct
25111 Type Lookup semantics in rootcontext
25113 * rootcontext.cs: Revert Ravi's last patch. The correct way of
25114 referencing a nested type with the Reflection API is using the "+"
25117 * cs-parser.jay: Do not require EOF token at the end.
25119 2001-12-20 Ravi Pratap <ravi@ximian.com>
25121 * rootcontext.cs (LookupType): Concatenate type names with
25122 a '.' instead of a '+' The test suite passes again.
25124 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
25125 field of the enumeration.
25127 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
25128 the case when the member is an EventExpr.
25130 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
25131 static has an associated instance expression.
25133 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
25135 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
25137 * class.cs (Event.Define): Register event and perform appropriate checks
25140 We define the Add and Remove methods even if the use provides none because
25141 in that case, we provide default implementations ourselves.
25143 Define a private field of the type of the event. This is done by the CSC compiler
25144 and we should be doing it too ;-)
25146 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
25147 More methods we use in code we generate.
25149 (multicast_delegate_type, delegate_type): Two separate types since the distinction
25152 (InitCoreTypes): Update accordingly for the above.
25154 * class.cs (Event.Emit): Generate code for default accessors that we provide
25156 (EmitDefaultMethod): Do the job in the above.
25158 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
25161 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25163 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
25164 builders even if we were missing one.
25166 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
25167 pass the Basename as our class name instead of the Name. The
25168 basename will be correctly composed for us.
25170 * parameter.cs (Paramters): Now takes a Location argument.
25172 * decl.cs (DeclSpace.LookupType): Removed convenience function and
25173 make all the code call directly LookupType in RootContext and take
25174 this chance to pass the Location information everywhere.
25176 * Everywhere: pass Location information.
25178 2001-12-19 Miguel de Icaza <miguel@ximian.com>
25180 * class.cs (Constructor.Define): Updated way of detecting the
25181 length of the parameters.
25183 (TypeContainer.DefineType): Use basename as the type name for
25186 (TypeContainer.Define): Do not recursively define types here, as
25187 definition is taken care in order by the RootContext.
25189 * tree.cs: Keep track of namespaces in a per-file basis.
25191 * parameter.cs (Parameter.ComputeSignature): Update to use
25194 (Parameters.GetSignature): ditto.
25196 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
25197 instead of a TypeContainer.
25199 (Interface.SemanticAnalysis): Use `this' instead of our parent to
25200 resolve names. Because we need to be resolve in our context, not
25203 * driver.cs: Implement response files.
25205 * class.cs (TypeContainer.DefineType): If we are defined, do not
25206 redefine ourselves.
25208 (Event.Emit): Emit the code for add/remove handlers.
25209 (Event.Define): Save the MethodBuilders for add/remove.
25211 * typemanager.cs: Use pair here too.
25213 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
25214 DictionaryEntry requires the first argument to be non-null.
25216 (enum_declaration): Compute full name for registering the
25219 (delegate_declaration): Instead of using
25220 formal_parameter_list, use opt_formal_parameter_list as the list
25223 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
25224 (EventParsing): New property that controls whether `add' and
25225 `remove' are returned as tokens or identifiers (for events);
25227 2001-12-19 Ravi Pratap <ravi@ximian.com>
25229 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
25230 use MyEventBuilder only and let it wrap the real builder for us.
25232 (MyEventBuilder): Revamp constructor etc.
25234 Implement all operations that we perform on EventBuilder in precisely the same
25237 (FindMembers): Update to use the EventBuilder member.
25239 (Event.Emit): Update accordingly.
25241 2001-12-18 Ravi Pratap <ravi@ximian.com>
25243 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
25244 by calling the appropriate methods.
25246 (GetCustomAttributes): Make stubs as they cannot possibly do anything
25249 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
25251 2001-12-17 Ravi Pratap <ravi@ximian.com>
25253 * delegate.cs (Delegate.Populate): Check that the return type
25254 and various parameters types are indeed accessible.
25256 * class.cs (Constructor.Define): Same here.
25258 (Field.Define): Ditto.
25260 (Event.Define): Ditto.
25262 (Operator.Define): Check that the underlying Method defined itself
25263 correctly - so it's MethodBuilder should not be null.
25265 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
25266 expression happens to be null.
25268 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
25269 members but as of now we don't seem to be able to do anything really useful with it.
25271 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
25272 not the EventBuilder.
25274 2001-12-18 Miguel de Icaza <miguel@ximian.com>
25276 * cs-tokenizer.cs: Add support for defines.
25277 Add support for #if, #elif, #else, #endif
25279 (eval_var): evaluates a variable.
25280 (eval): stubbed for evaluating functions.
25282 * cs-parser.jay: Pass the defines information
25284 * driver.cs: Add --define command line option.
25286 * decl.cs: Move MemberCore here.
25288 Make it the base class for DeclSpace. This allows us to catch and
25289 report 108 and 109 for everything now.
25291 * class.cs (TypeContainer.Define): Extract all the members
25292 before populating and emit the warning 108 (new keyword required
25293 to override) instead of having each member implement this.
25295 (MemberCore.Define): New abstract method, we will be using this in
25296 the warning reporting engine in Populate.
25298 (Operator.Define): Adjust to new MemberCore protocol.
25300 * const.cs (Const): This does not derive from Expression, it is a
25301 temporary object we use to create fields, it is a MemberCore.
25303 * class.cs (Method.Define): Allow the entry point to be in a
25306 * driver.cs: Rewrite the argument handler to clean it up a bit.
25308 * rootcontext.cs: Made it just an auxiliary namespace feature by
25309 making everything static.
25311 * driver.cs: Adapt code to use RootContext type name instead of
25314 * delegate.cs: Remove RootContext argument.
25316 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
25319 * class.cs (Event.Define): The lookup can fail.
25321 * cs-tokenizer.cs: Begin implementation of pre-procesor.
25323 * expression.cs: Resolve the this instance before invoking the code.
25325 2001-12-17 Miguel de Icaza <miguel@ximian.com>
25327 * cs-parser.jay: Add a production in element_access that allows
25328 the thing to become a "type" reference. This way we can parse
25329 things like "(string [])" as a type.
25331 Note that this still does not handle the more complex rules of
25335 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
25337 * ecore.cs: (CopyNewMethods): new utility function used to
25338 assemble the list of methods from running FindMembers.
25340 (MemberLookup): Rework FindMembers so that
25342 2001-12-16 Miguel de Icaza <miguel@ximian.com>
25344 * class.cs (TypeContainer): Remove Delegates who fail to be
25347 * delegate.cs (Populate): Verify that we dont get null return
25348 values. TODO: Check for AsAccessible.
25350 * cs-parser.jay: Use basename to emit error 574 (destructor should
25351 have the same name as container class), not the full name.
25353 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
25354 possible representation.
25356 Also implements integer type suffixes U and L.
25358 2001-12-15 Miguel de Icaza <miguel@ximian.com>
25360 * expression.cs (ArrayCreation.DoResolve): We need to do the
25361 argument resolution *always*.
25363 * decl.cs: Make this hold the namespace. Hold the root context as
25365 (LookupType): Move here.
25367 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
25369 * location.cs (Row, Name): Fixed the code, it was always returning
25370 references to the first file.
25372 * interface.cs: Register properties defined through interfaces.
25374 * driver.cs: Add support for globbing on the command line
25376 * class.cs (Field): Make it derive from MemberCore as well.
25379 2001-12-15 Ravi Pratap <ravi@ximian.com>
25381 * class.cs (Event::Define): Check that the type of the event is a delegate
25382 type else flag error #66.
25384 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
25387 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
25388 values of EntryPoint, CharSet etc etc.
25390 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
25392 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
25393 be null and we should ignore this. I am not sure if this is really clean. Apparently,
25394 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
25395 which needs this to do its work.
25397 * ../errors/cs0066.cs : Add.
25399 2001-12-14 Miguel de Icaza <miguel@ximian.com>
25401 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
25404 * class.cs: (MethodSignature.MethodSignature): Removed hack that
25405 clears out the parameters field.
25406 (MemberSignatureCompare): Cleanup
25408 (MemberCore): New base class used to share code between MethodCore
25411 (RegisterRequiredImplementations) BindingFlags.Public requires
25412 either BindingFlags.Instace or Static. Use instance here.
25414 (Property): Refactored code to cope better with the full spec.
25416 * parameter.cs (GetParameterInfo): Return an empty array instead
25419 * class.cs (Property): Abstract or extern properties have no bodies.
25421 * parameter.cs (GetParameterInfo): return a zero-sized array.
25423 * class.cs (TypeContainer.MethodModifiersValid): Move all the
25424 method modifier validation to the typecontainer so we can reuse
25425 this on properties.
25427 (MethodCore.ParameterTypes): return an empty sized array of types.
25429 (Property.Define): Test property modifier validity.
25431 Add tests for sealed/override too.
25433 (Method.Emit): abstract or extern methods have no bodies.
25435 2001-12-14 Ravi Pratap <ravi@ximian.com>
25437 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
25440 (Method::Define, ::Emit): Modify accordingly.
25442 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
25444 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
25446 * makefile: Pass in /unsafe.
25448 2001-12-13 Miguel de Icaza <miguel@ximian.com>
25450 * class.cs (MakeKey): Kill routine.
25452 * class.cs (TypeContainer.Define): Correctly define explicit
25453 method implementations (they require the full interface name plus
25456 * typemanager.cs: Deply the PtrHashtable here and stop using the
25457 lame keys. Things work so much better.
25459 This of course broke everyone who depended on `RegisterMethod' to
25460 do the `test for existance' test. This has to be done elsewhere.
25462 * support.cs (PtrHashtable): A hashtable that avoid comparing with
25463 the object stupid Equals method (because, that like fails all over
25464 the place). We still do not use it.
25466 * class.cs (TypeContainer.SetRequiredInterface,
25467 TypeContainer.RequireMethods): Killed these two routines and moved
25468 all the functionality to RegisterRequiredImplementations.
25470 (TypeContainer.RegisterRequiredImplementations): This routine now
25471 registers all the implementations required in an array for the
25472 interfaces and abstract methods. We use an array of structures
25473 which can be computed ahead of time to reduce memory usage and we
25474 also assume that lookups are cheap as most classes will not
25475 implement too many interfaces.
25477 We also avoid creating too many MethodSignatures.
25479 (TypeContainer.IsInterfaceMethod): Update and optionally does not
25480 clear the "pending" bit if we find that there are problems with
25483 (TypeContainer.VerifyPendingMethods): Update to report errors of
25484 methods that look like implementations but are not.
25486 (TypeContainer.Define): Add support for explicit interface method
25489 2001-12-12 Miguel de Icaza <miguel@ximian.com>
25491 * typemanager.cs: Keep track of the parameters here instead of
25492 being a feature of the TypeContainer.
25494 * class.cs: Drop the registration of parameters here, as
25495 InterfaceMethods are also interface declarations.
25497 * delegate.cs: Register methods with the TypeManager not only with
25498 the TypeContainer. This code was buggy.
25500 * interface.cs: Full registation here.
25502 2001-12-11 Miguel de Icaza <miguel@ximian.com>
25504 * expression.cs: Remove reducer for binary expressions, it can not
25507 * const.cs: Put here the code that used to go into constant.cs
25509 * constant.cs: Put here the code for constants, this is a new base
25510 class for Literals.
25512 * literal.cs: Make Literal derive from Constant.
25514 2001-12-09 Miguel de Icaza <miguel@ximian.com>
25516 * statement.cs (Return.Emit): Report error 157 if the user
25517 attempts to return from a finally block.
25519 (Return.Emit): Instead of emitting a return, jump to the end of
25522 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
25523 LocalBuilder to store the result of the function. ReturnLabel is
25524 the target where we jump.
25527 2001-12-09 Radek Doulik <rodo@ximian.com>
25529 * cs-parser.jay: remember alias in current namespace
25531 * ecore.cs (SimpleName::DoResolve): use aliases for types or
25534 * class.cs (LookupAlias): lookup alias in my_namespace
25536 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
25538 (LookupAlias): lookup alias in this and if needed in parent
25541 2001-12-08 Miguel de Icaza <miguel@ximian.com>
25545 * rootcontext.cs: (ModuleBuilder) Made static, first step into
25546 making things static. I need this to avoid passing the
25547 TypeContainer when calling ParameterType.
25549 * support.cs (InternalParameters.ParameterType): Remove ugly hack
25550 that did string manipulation to compute the type and then call
25551 GetType. Use Parameter.ParameterType instead.
25553 * cs-tokenizer.cs: Consume the suffix for floating values.
25555 * expression.cs (ParameterReference): figure out whether this is a
25556 reference parameter or not. Kill an extra variable by computing
25557 the arg_idx during emission.
25559 * parameter.cs (Parameters.GetParameterInfo): New overloaded
25560 function that returns whether a parameter is an out/ref value or not.
25562 (Parameter.ParameterType): The type of the parameter (base,
25563 without ref/out applied).
25565 (Parameter.Resolve): Perform resolution here.
25566 (Parameter.ExternalType): The full type (with ref/out applied).
25568 * statement.cs (Using.Emit, Using.EmitExpression): Implement
25569 support for expressions on the using statement.
25571 2001-12-07 Miguel de Icaza <miguel@ximian.com>
25573 * statement.cs (Using.EmitLocalVariableDecls): Split the
25574 localvariable handling of the using statement.
25576 (Block.EmitMeta): Keep track of variable count across blocks. We
25577 were reusing slots on separate branches of blocks.
25579 (Try.Emit): Emit the general code block, we were not emitting it.
25581 Check the type of the declaration to be an IDisposable or
25582 something that can be implicity converted to it.
25584 Emit conversions if required.
25586 * ecore.cs (EmptyExpression): New utility class.
25587 (Expression.ImplicitConversionExists): New utility function.
25589 2001-12-06 Miguel de Icaza <miguel@ximian.com>
25591 * statement.cs (Using): Implement.
25593 * expression.cs (LocalVariableReference): Support read only variables.
25595 * statement.cs: Remove the explicit emit for the Leave opcode.
25596 (VariableInfo): Add a readonly field.
25598 2001-12-05 Miguel de Icaza <miguel@ximian.com>
25600 * ecore.cs (ConvCast): new class used to encapsulate the various
25601 explicit integer conversions that works in both checked and
25602 unchecked contexts.
25604 (Expression.ConvertNumericExplicit): Use new ConvCast class to
25605 properly generate the overflow opcodes.
25607 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25609 * statement.cs: The correct type for the EmptyExpression is the
25610 element_type, not the variable type. Ravi pointed this out.
25612 2001-12-04 Ravi Pratap <ravi@ximian.com>
25614 * class.cs (Method::Define): Handle PInvoke methods specially
25615 by using DefinePInvokeMethod instead of the usual one.
25617 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
25618 above to do the task of extracting information and defining the method.
25620 2001-12-04 Ravi Pratap <ravi@ximian.com>
25622 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
25623 of the condition for string type.
25625 (Emit): Move that here.
25627 (ArrayCreation::CheckIndices): Keep string literals in their expression
25630 (EmitDynamicInitializers): Handle strings appropriately.
25632 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25634 * codegen.cs (EmitContext): Replace multiple variables with a
25635 single pointer to the current Switch statement.
25637 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
25640 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25644 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
25647 (Foreach.Emit): Foreach on arrays was not setting
25648 up the loop variables (for break/continue).
25650 (GotoCase): Semi-implented.
25652 2001-12-03 Ravi Pratap <ravi@ximian.com>
25654 * attribute.cs (CheckAttribute): Handle system attributes by using
25655 Attribute.GetAttributes to examine information we need.
25657 (GetValidPlaces): Same here.
25659 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
25661 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
25663 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
25665 (Method::Define): Set appropriate flags if we have a DllImport attribute.
25667 (Method::Emit): Handle the case when we are a PInvoke method.
25669 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25671 * expression.cs: Use ResolveWithSimpleName on compound names.
25673 2001-12-02 Ravi Pratap <ravi@ximian.com>
25675 * constant.cs (EmitConstant): Make sure we resolve the associated expression
25676 before trying to reduce it.
25678 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
25680 * constant.cs (LookupConstantValue): Implement.
25682 (EmitConstant): Use the above in emitting the constant.
25684 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
25685 that are user-defined by doing a LookupConstantValue on them.
25687 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
25690 2001-11-29 Miguel de Icaza <miguel@ximian.com>
25692 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
25694 (BaseAccess.DoResolve): Implement.
25696 (MemberAccess.DoResolve): Split this routine into a
25697 ResolveMemberAccess routine that can be used independently
25699 2001-11-28 Miguel de Icaza <miguel@ximian.com>
25701 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
25702 As that share bits of the implementation. Is returns a boolean,
25703 while As returns the Type that is being probed.
25705 2001-12-01 Ravi Pratap <ravi@ximian.com>
25707 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
25708 instead of a Literal - much easier.
25710 (EnumInTransit): Remove - utterly useless :-)
25712 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
25714 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
25716 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
25717 chain when we have no associated expression.
25719 2001-11-30 Ravi Pratap <ravi@ximian.com>
25721 * constant.cs (Define): Use Location while reporting the errror.
25723 Also emit a warning when 'new' is used and there is no inherited
25726 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
25729 (LookupEnumValue): Implement to lookup an enum member's value and define it
25732 (Populate): Re-write accordingly to use the above routine.
25734 2001-11-27 Miguel de Icaza <miguel@ximian.com>
25736 * expression.cs (This): Fix prototype for DoResolveLValue to
25737 override the base class DoResolveLValue.
25739 * cs-parser.cs: Report errors cs574 and cs575 (destructor
25742 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
25743 (we need to load the address of the field here). This fixes
25746 (FieldExpr.DoResolveLValue): Call the DoResolve
25747 function to initialize the Instance expression.
25749 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
25750 correctly the GetEnumerator operation on a value type.
25752 * cs-parser.jay: Add more simple parsing error catches.
25754 * statement.cs (Switch): Add support for string switches.
25755 Handle null specially.
25757 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
25759 2001-11-28 Ravi Pratap <ravi@ximian.com>
25761 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
25763 (declare_local_constant): New helper function.
25765 * statement.cs (AddConstant): Keep a separate record of constants
25767 (IsConstant): Implement to determine if a variable is a constant.
25769 (GetConstantExpression): Implement.
25771 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
25773 * statement.cs (IsVariableDefined): Re-write.
25775 2001-11-27 Ravi Pratap <ravi@ximian.com>
25777 * class.cs (TypeContainer::FindMembers): Look for constants
25778 in the case when we are looking for MemberTypes.Field
25780 * expression.cs (MemberAccess::DoResolve): Check that in the
25781 case we are a FieldExpr and a Literal, we are not being accessed
25782 by an instance reference.
25784 * cs-parser.jay (local_constant_declaration): Implement.
25786 (declaration_statement): Implement for constant declarations.
25788 2001-11-26 Miguel de Icaza <miguel@ximian.com>
25790 * statement.cs (Switch): Catch double defaults.
25792 (Switch): More work on the switch() statement
25793 implementation. It works for integral values now, need to finish
25797 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25799 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
25800 integer literals into other integer literals. To be used by
25803 2001-11-24 Ravi Pratap <ravi@ximian.com>
25805 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
25808 (EmitDynamicInitializers): Cope with the above since we extract data
25809 directly from ArrayData now.
25811 (ExpectInitializers): Keep track of whether initializers are mandatory
25814 (Bounds): Make it a hashtable to prevent the same dimension being
25815 recorded for every element in that dimension.
25817 (EmitDynamicInitializers): Fix bug which prevented the Set array method
25820 Also fix bug which was causing the indices to be emitted in the reverse
25823 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25825 * expression.cs (ArrayCreation): Implement the bits that Ravi left
25826 unfinished. They do not work, because the underlying code is
25829 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25831 * cs-parser.jay: Remove bogus fixme.
25833 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
25834 on Switch statement.
25836 2001-11-23 Ravi Pratap <ravi@ximian.com>
25838 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
25841 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
25842 parameter. Apparently, any expression is allowed.
25844 (ValidateInitializers): Update accordingly.
25846 (CheckIndices): Fix some tricky bugs thanks to recursion.
25848 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
25849 I was being completely brain-dead.
25851 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
25852 and re-write acordingly.
25854 (DelegateInvocation): Re-write accordingly.
25856 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25858 (MakeByteBlob): Handle types more correctly.
25860 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25861 initialization from expressions but it is incomplete because I am a complete
25864 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25866 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25867 on If. Basically, we have to return `true' (ie, we do return to
25868 our caller) only if both branches of the if return.
25870 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25871 short-circuit operators, handle them as short circuit operators.
25873 (Cast.DoResolve): Resolve type.
25874 (Cast.Cast): Take an expression as the target type.
25876 * cs-parser.jay (cast_expression): Remove old hack that only
25877 allowed a limited set of types to be handled. Now we take a
25878 unary_expression and we resolve to a type during semantic
25881 Use the grammar productions from Rhys to handle casts (this is
25882 not complete like Rhys syntax yet, we fail to handle that corner
25883 case that C# has regarding (-x), but we will get there.
25885 2001-11-22 Ravi Pratap <ravi@ximian.com>
25887 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25888 field which is an array type.
25890 * cs-parser.jay (declare_local_variables): Support array initialization too.
25892 * typemanager.cs (MakeKey): Implement.
25894 (everywhere): Use the above appropriately.
25896 * cs-parser.jay (for_statement): Update for array initialization while
25897 declaring variables.
25899 * ecore.cs : The error message was correct, it's the variable's names that
25900 were misleading ;-) Make the code more readable.
25902 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25903 the correct type etc.
25905 (ConvertExplicit): Handle Enum types by examining the underlying type.
25907 2001-11-21 Ravi Pratap <ravi@ximian.com>
25909 * parameter.cs (GetCallingConvention): Always return
25910 CallingConventions.Standard for now.
25912 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25914 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25915 and `r' after calling DoNumericPromotions.
25917 * ecore.cs: Fix error message (the types were in the wrong order).
25919 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25920 BindingFlags.Instance as well
25922 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25923 implicit int literal conversion in an empty cast so that we
25924 propagate the right type upstream.
25926 (UnboxCast): new class used to unbox value types.
25927 (Expression.ConvertExplicit): Add explicit type conversions done
25930 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25931 the target type before applying the implicit LongLiterals to ULong
25934 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25936 * cs-parser.jay (for_statement): Reworked the way For works: now
25937 we declare manually any variables that are introduced in
25938 for_initializer to solve the problem of having out-of-band code
25939 emition (that is what got for broken).
25941 (declaration_statement): Perform the actual variable declaration
25942 that used to be done in local_variable_declaration here.
25944 (local_variable_declaration): Do not declare anything, just pass
25945 the information on a DictionaryEntry
25947 2001-11-20 Ravi Pratap <ravi@ximian.com>
25949 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25950 re-write of the logic to now make it recursive.
25952 (UpdateIndices): Re-write accordingly.
25954 Store element data in a separate ArrayData list in the above methods.
25956 (MakeByteBlob): Implement to dump the array data into a byte array.
25958 2001-11-19 Ravi Pratap <ravi@ximian.com>
25960 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25963 * constant.cs (Define): Implement.
25965 (EmitConstant): Re-write fully.
25967 Pass in location info.
25969 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25972 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25973 DictionaryEntry since we need location info too.
25975 (constant_declaration): Update accordingly.
25977 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
25978 code into another method : UpdateIndices.
25980 2001-11-18 Ravi Pratap <ravi@ximian.com>
25982 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
25983 some type checking etc.
25985 2001-11-17 Ravi Pratap <ravi@ximian.com>
25987 * expression.cs (ArrayCreation::ValidateInitializers): Implement
25988 bits to provide dimension info if the user skips doing that.
25990 Update second constructor to store the rank correctly.
25992 2001-11-16 Ravi Pratap <ravi@ximian.com>
25994 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
25995 and try to implement.
25997 * ../errors/cs0150.cs : Add.
25999 * ../errors/cs0178.cs : Add.
26001 2001-11-16 Miguel de Icaza <miguel@ximian.com>
26003 * statement.cs: Implement foreach on multi-dimensional arrays.
26005 * parameter.cs (Parameters.GetParameterByName): Also lookup the
26006 name of the params argument.
26008 * expression.cs: Use EmitStoreOpcode to get the right opcode while
26009 initializing the array.
26011 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
26012 we can use this elsewhere.
26014 * statement.cs: Finish implementation of foreach for single
26017 * cs-parser.jay: Use an out-of-band stack to pass information
26018 around, I wonder why I need this.
26020 foreach_block: Make the new foreach_block the current_block.
26022 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
26023 function used to return a static Parameters structure. Used for
26024 empty parameters, as those are created very frequently.
26026 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
26028 2001-11-15 Ravi Pratap <ravi@ximian.com>
26030 * interface.cs : Default modifier is private, not public. The
26031 make verify test passes again.
26033 2001-11-15 Ravi Pratap <ravi@ximian.com>
26035 * support.cs (ReflectionParameters): Fix logic to determine
26036 whether the last parameter is a params one. Test 9 passes again.
26038 * delegate.cs (Populate): Register the builders we define with
26039 RegisterParameterForBuilder. Test 19 passes again.
26041 * cs-parser.jay (property_declaration): Reference $6 instead
26042 of $$ to get at the location.
26044 (indexer_declaration): Similar stuff.
26046 (attribute): Ditto.
26048 * class.cs (Property): Register parameters for the Get and Set methods
26049 if they exist. Test 23 passes again.
26051 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
26052 call to EmitArguments as we are sure there aren't any params arguments.
26053 Test 32 passes again.
26055 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
26056 IndexOutOfRangeException.
26058 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
26059 Test 33 now passes again.
26061 2001-11-15 Miguel de Icaza <miguel@ximian.com>
26063 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
26064 broke a bunch of things. Will have to come up with a better way
26065 of tracking locations.
26067 * statement.cs: Implemented foreach for single dimension arrays.
26069 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26071 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
26072 an error. This removes the lookup from the critical path.
26074 * cs-parser.jay: Removed use of temporary_loc, which is completely
26077 2001-11-14 Miguel de Icaza <miguel@ximian.com>
26079 * support.cs (ReflectionParameters.ParameterModifier): Report
26080 whether the argument is a PARAMS argument or not.
26082 * class.cs: Set the attribute `ParamArrayAttribute' on the
26083 parameter argument.
26085 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
26086 and cons_param_array_attribute (ConstructorInfo for
26087 ParamArrayAttribute).,
26089 * codegen.cs: Emit the return using the `Return' statement, that
26090 way we can report the error correctly for missing return values.
26092 * class.cs (Method.Emit): Clean up.
26094 * expression.cs (Argument.Resolve): Take another argument: the
26095 location where this argument is used. Notice that this is not
26096 part of the "Argument" class as to reduce the size of the
26097 structure (we know the approximate location anyways).
26099 Test if the argument is a variable-reference, if not, then
26100 complain with a 206.
26102 (Argument.Emit): Emit addresses of variables.
26104 (Argument.FullDesc): Simplify.
26106 (Invocation.DoResolve): Update for Argument.Resolve.
26108 (ElementAccess.DoResolve): ditto.
26110 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
26111 method should be virtual, as this method is always virtual.
26113 (NewDelegate.DoResolve): Update for Argument.Resolve.
26115 * class.cs (ConstructorInitializer.DoResolve): ditto.
26117 * attribute.cs (Attribute.Resolve): ditto.
26119 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26121 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
26123 * expression.cs (ParameterReference): Drop IStackStorage and implement
26124 IAssignMethod instead.
26126 (LocalVariableReference): ditto.
26128 * ecore.cs (FieldExpr): Drop IStackStorage and implement
26129 IAssignMethod instead.
26131 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26133 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
26134 enumerations that are used in heavily used structures derive from
26135 byte in a laughable and pathetic attempt to reduce memory usage.
26136 This is the kind of pre-optimzations that you should not do at
26137 home without adult supervision.
26139 * expression.cs (UnaryMutator): New class, used to handle ++ and
26140 -- separatedly from the other unary operators. Cleans up the
26141 code, and kills the ExpressionStatement dependency in Unary.
26143 (Unary): Removed `method' and `Arguments' from this class, making
26144 it smaller, and moving it all to SimpleCall, so I can reuse this
26145 code in other locations and avoid creating a lot of transient data
26146 strucutres when not required.
26148 * cs-parser.jay: Adjust for new changes.
26150 2001-11-11 Miguel de Icaza <miguel@ximian.com>
26152 * enum.cs (Enum.Populate): If there is a failure during
26155 * cs-parser.jay (opt_enum_base): we used to catch type errors
26156 here, but this is really incorrect. The type error should be
26157 catched during semantic analysis.
26159 2001-12-11 Ravi Pratap <ravi@ximian.com>
26161 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
26162 current_local_parameters as expected since I, in my stupidity, had forgotten
26165 * attribute.cs (GetValidPlaces): Fix stupid bug.
26167 * class.cs (Method::Emit): Perform check on applicability of attributes.
26169 (Constructor::Emit): Ditto.
26171 (Field::Emit): Ditto.
26173 (Field.Location): Store location information.
26175 (Property, Event, Indexer, Operator): Ditto.
26177 * cs-parser.jay (field_declaration): Pass in location for each field.
26179 * ../errors/cs0592.cs : Add.
26181 2001-11-12 Ravi Pratap <ravi@ximian.com>
26183 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
26185 (InitCoreTypes): Update accordingly.
26187 (RegisterAttrType, LookupAttr): Implement.
26189 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
26190 info about the same.
26192 (Resolve): Update to populate the above as necessary.
26194 (Error592): Helper.
26196 (GetValidPlaces): Helper to the above.
26198 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
26200 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
26202 2001-11-12 Ravi Pratap <ravi@ximian.com>
26204 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
26206 * ../errors/cs0617.cs : Add.
26208 2001-11-11 Ravi Pratap <ravi@ximian.com>
26210 * enum.cs (Emit): Rename to Populate to be more consistent with what
26211 we expect it to do and when exactly it is called.
26213 * class.cs, rootcontext.cs : Update accordingly.
26215 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
26216 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
26218 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
26220 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
26221 of a fieldinfo using the above, when dealing with a FieldBuilder.
26223 2001-11-10 Ravi Pratap <ravi@ximian.com>
26225 * ../errors/cs0031.cs : Add.
26227 * ../errors/cs1008.cs : Add.
26229 * ../errrors/cs0543.cs : Add.
26231 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
26234 (FindMembers): Implement.
26236 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
26237 enums and delegates too.
26239 (enum_types): Rename to builder_to_enum.
26241 (delegate_types): Rename to builder_to_delegate.
26243 * delegate.cs (FindMembers): Implement.
26245 2001-11-09 Ravi Pratap <ravi@ximian.com>
26247 * typemanager.cs (IsEnumType): Implement.
26249 * enum.cs (Emit): Re-write parts to account for the underlying type
26250 better and perform checking etc.
26252 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
26253 of the underlying type.
26255 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
26258 * enum.cs (error31): Helper to report error #31.
26260 * cs-parser.jay (enum_declaration): Store location of each member too.
26262 * enum.cs (member_to_location): New hashtable.
26264 (AddEnumMember): Update location hashtable.
26266 (Emit): Use the location of each member while reporting errors.
26268 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26270 * cs-parser.jay: A for_initializer if is a
26271 local_variable_declaration really ammount to have an implicit
26272 block with the variable declaration and no initializer for for.
26274 * statement.cs (For.Emit): Cope with null initializers.
26276 This fixes the infinite loop on for initializers.
26278 2001-11-08 Miguel de Icaza <miguel@ximian.com>
26280 * enum.cs: More cleanup.
26282 * ecore.cs: Remove dead code.
26284 * class.cs (Property.Emit): More simplification.
26285 (Event.Emit): ditto.
26287 Reworked to have less levels of indentation.
26289 2001-11-08 Ravi Pratap <ravi@ximian.com>
26291 * class.cs (Property): Emit attributes.
26301 * enum.cs (Emit): Ditto.
26303 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
26306 * class.cs (Field, Event, etc.): Move attribute generation into the
26307 Emit method everywhere.
26309 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
26310 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
26311 as we had no way of defining nested enums !
26313 * rootcontext.cs : Adjust code accordingly.
26315 * typemanager.cs (AddEnumType): To keep track of enum types separately.
26317 2001-11-07 Ravi Pratap <ravi@ximian.com>
26319 * expression.cs (EvalConstantExpression): Move into ecore.cs
26321 * enum.cs (Enum): Rename some members and make them public and readonly
26322 according to our convention.
26324 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
26327 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
26329 (Enum::Emit): Write a simple version for now which doesn't try to compute
26330 expressions. I shall modify this to be more robust in just a while.
26332 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
26334 (TypeContainer::CloseType): Create the Enum types too.
26336 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
26338 * expression.cs (EvalConstantExpression): Get rid of completely.
26340 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
26341 user-defined values and other cases.
26343 (IsValidEnumLiteral): Helper function.
26345 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
26346 out there in the case we had a literal FieldExpr.
26348 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
26350 (Literalize): Revamp a bit to take two arguments.
26352 (EnumLiteral): New class which derives from Literal to wrap enum literals.
26354 2001-11-06 Ravi Pratap <ravi@ximian.com>
26356 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
26358 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
26360 (Resolve): Use the above to ensure we have proper initializers.
26362 2001-11-05 Ravi Pratap <ravi@ximian.com>
26364 * expression.cs (Expression::EvalConstantExpression): New method to
26365 evaluate constant expressions.
26367 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
26369 2001-11-07 Miguel de Icaza <miguel@ximian.com>
26371 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
26374 (Binary.ResolveOperator): Handle operator != (object a, object b)
26375 and operator == (object a, object b);
26377 (Binary.DoNumericPromotions): Indicate whether the numeric
26378 promotion was possible.
26380 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
26383 Made the ArrayAccess implement interface IAssignMethod instead of
26384 IStackStore as the order in which arguments are passed reflects
26387 * assign.cs: Instead of using expr.ExprClass to select the way of
26388 assinging, probe for the IStackStore/IAssignMethod interfaces.
26390 * typemanager.cs: Load InitializeArray definition.
26392 * rootcontext.cs (RootContext.MakeStaticData): Used to define
26393 static data that can be used to initialize arrays.
26395 2001-11-05 Miguel de Icaza <miguel@ximian.com>
26397 * expression.cs: Handle operator== and operator!= for booleans.
26399 (Conditioal.Reduce): Implement reducer for the ?: operator.
26401 (Conditional.Resolve): Implement dead code elimination.
26403 (Binary.Resolve): Catch string literals and return a new
26404 concatenated string.
26406 (Unary.Reduce): Implement reduction of unary expressions.
26408 * ecore.cs: Split out the expression core handling here.
26410 (Expression.Reduce): New method used to perform constant folding
26411 and CSE. This is needed to support constant-expressions.
26413 * statement.cs (Statement.EmitBoolExpression): Pass true and false
26414 targets, and optimize for !x.
26416 2001-11-04 Ravi Pratap <ravi@ximian.com>
26418 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
26419 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
26420 set custom atttributes.
26422 * literal.cs (Literal::GetValue): New abstract method to return the actual
26423 value of the literal, cast as an object.
26425 (*Literal): Implement GetValue method.
26427 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
26428 expressions to the arraylist but objects of type Argument.
26430 * class.cs (TypeContainer::Emit): Emit our attributes too.
26432 (Method::Emit, Constructor::Emit): Ditto.
26434 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
26435 to be ignoring earlier.
26437 2001-11-03 Ravi Pratap <ravi@ximian.com>
26439 * attribute.cs (AttributeSection::Define): Implement to do the business
26440 of constructing a CustomAttributeBuilder.
26442 (Attribute): New trivial class. Increases readability of code.
26444 * cs-parser.jay : Update accordingly.
26446 (positional_argument_list, named_argument_list, named_argument): New rules
26448 (attribute_arguments): Use the above so that we are more correct.
26450 2001-11-02 Ravi Pratap <ravi@ximian.com>
26452 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
26453 to perform all checks for a method with a params parameter.
26455 (Invocation::OverloadResolve): Update to use the above method and therefore
26456 cope correctly with params method invocations.
26458 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
26461 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
26462 constructors in our parent too because we can't afford to miss out on
26465 * attribute.cs (AttributeSection): New name for the class Attribute
26467 Other trivial changes to improve readability.
26469 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
26470 use the new class names.
26472 2001-11-01 Ravi Pratap <ravi@ximian.com>
26474 * class.cs (Method::Define): Complete definition for params types too
26476 (Indexer::Define): Ditto.
26478 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
26479 Cope everywhere with a request for info about the array parameter.
26481 2001-11-01 Ravi Pratap <ravi@ximian.com>
26483 * tree.cs (RecordNamespace): Fix up to check for the correct key.
26485 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
26486 local_variable_type to extract the string corresponding to the type.
26488 (local_variable_type): Fixup the action to use the new helper method.
26490 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
26493 * expression.cs : Clean out code which uses the above.
26495 2001-10-31 Ravi Pratap <ravi@ximian.com>
26497 * typemanager.cs (RegisterMethod): Check if we already have an existing key
26498 and bale out if necessary by returning a false.
26500 (RegisterProperty): Ditto.
26502 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
26503 and print out appropriate error messages.
26505 * interface.cs (everywhere): Ditto.
26507 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
26508 location to constructor.
26510 * class.cs (Property, Event, Indexer): Update accordingly.
26512 * ../errors/cs111.cs : Added.
26514 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
26515 of a method, as laid down by the spec.
26517 (Invocation::OverloadResolve): Use the above method.
26519 2001-10-31 Ravi Pratap <ravi@ximian.com>
26521 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
26522 now take a TypeContainer and a Parameters object.
26524 (ParameterData): Modify return type of ParameterModifier method to be
26525 Parameter.Modifier and not a string.
26527 (ReflectionParameters, InternalParameters): Update accordingly.
26529 * expression.cs (Argument::GetParameterModifier): Same here.
26531 * support.cs (InternalParameters::ParameterType): Find a better way of determining
26532 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
26533 symbol in it at all so maybe this is only for now.
26535 2001-10-30 Ravi Pratap <ravi@ximian.com>
26537 * support.cs (InternalParameters): Constructor now takes an extra argument
26538 which is the actual Parameters class.
26540 (ParameterDesc): Update to provide info on ref/out modifiers.
26542 * class.cs (everywhere): Update call to InternalParameters to pass in
26543 the second argument too.
26545 * support.cs (ParameterData): Add ParameterModifier, which is a method
26546 to return the modifier info [ref/out etc]
26548 (InternalParameters, ReflectionParameters): Implement the above.
26550 * expression.cs (Argument::ParameterModifier): Similar function to return
26551 info about the argument's modifiers.
26553 (Invocation::OverloadResolve): Update to take into account matching modifiers
26556 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
26557 a new SetFormalParameters object which we pass to InternalParameters.
26559 2001-10-30 Ravi Pratap <ravi@ximian.com>
26561 * expression.cs (NewArray): Merge into the ArrayCreation class.
26563 2001-10-29 Ravi Pratap <ravi@ximian.com>
26565 * expression.cs (NewArray): Merge classes NewBuiltinArray and
26566 NewUserdefinedArray into one as there wasn't much of a use in having
26569 * expression.cs (Argument): Change field's name to ArgType from Type.
26571 (Type): New readonly property which returns the proper type, taking into
26572 account ref/out modifiers.
26574 (everywhere): Adjust code accordingly for the above.
26576 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
26577 whether we are emitting for a ref or out parameter.
26579 * expression.cs (Argument::Emit): Use the above field to set the state.
26581 (LocalVariableReference::Emit): Update to honour the flag and emit the
26584 * parameter.cs (Attributes): Set the correct flags for ref parameters.
26586 * expression.cs (Argument::FullDesc): New function to provide a full desc.
26588 * support.cs (ParameterData): Add method ParameterDesc to the interface.
26590 (ReflectionParameters, InternalParameters): Implement the above method.
26592 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
26595 (Invocation::FullMethodDesc): Ditto.
26597 2001-10-29 Miguel de Icaza <miguel@ximian.com>
26599 * cs-parser.jay: Add extra production for the second form of array
26602 * expression.cs (ArrayCreation): Update to reflect the above
26605 * Small changes to prepare for Array initialization.
26607 2001-10-28 Miguel de Icaza <miguel@ximian.com>
26609 * typemanager.cs (ImplementsInterface): interface might be null;
26610 Deal with this problem;
26612 Also, we do store negative hits on the cache (null values), so use
26613 this instead of calling t.GetInterfaces on the type everytime.
26615 2001-10-28 Ravi Pratap <ravi@ximian.com>
26617 * typemanager.cs (IsBuiltinType): New method to help determine the same.
26619 * expression.cs (New::DoResolve): Get rid of array creation code and instead
26620 split functionality out into different classes.
26622 (New::FormArrayType): Move into NewBuiltinArray.
26624 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
26627 (NewBuiltinArray): New class to handle creation of built-in arrays.
26629 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
26630 account creation of one-dimensional arrays.
26632 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
26634 (NewUserdefinedArray::DoResolve): Implement.
26636 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
26638 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
26639 we maintain inside the TypeManager. This is necessary to perform lookups on the
26642 (LookupType): Update to perform GetType on the module builders too.
26644 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
26646 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
26648 2001-10-23 Ravi Pratap <ravi@ximian.com>
26650 * expression.cs (New::DoResolve): Implement guts of array creation.
26652 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
26654 2001-10-27 Miguel de Icaza <miguel@ximian.com>
26656 * expression.cs: Fix bug I introduced lsat night that broke
26659 (Expression.Resolve): Report a 246 error (can not resolve name)
26660 if we find a SimpleName in the stream.
26662 (Expression.ResolveLValue): Ditto.
26664 (Expression.ResolveWithSimpleName): This function is a variant of
26665 ResolveName, this one allows SimpleNames to be returned without a
26666 warning. The only consumer of SimpleNames is MemberAccess
26668 2001-10-26 Miguel de Icaza <miguel@ximian.com>
26670 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
26671 might arrive here. I have my doubts that this is correct.
26673 * statement.cs (Lock): Implement lock statement.
26675 * cs-parser.jay: Small fixes to support `lock' and `using'
26677 * cs-tokenizer.cs: Remove extra space
26679 * driver.cs: New flag --checked, allows to turn on integer math
26682 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
26683 Threading.Monitor.Exit
26685 2001-10-23 Miguel de Icaza <miguel@ximian.com>
26687 * expression.cs (IndexerAccess::DoResolveLValue): Set the
26688 Expression Class to be IndexerAccess.
26690 Notice that Indexer::DoResolve sets the eclass to Value.
26692 2001-10-22 Miguel de Icaza <miguel@ximian.com>
26694 * class.cs (TypeContainer::Emit): Emit code for indexers.
26696 * assign.cs (IAssignMethod): New interface implemented by Indexers
26697 and Properties for handling assignment.
26699 (Assign::Emit): Simplify and reuse code.
26701 * expression.cs (IndexerAccess, PropertyExpr): Implement
26702 IAssignMethod, clean up old code.
26704 2001-10-22 Ravi Pratap <ravi@ximian.com>
26706 * typemanager.cs (ImplementsInterface): New method to determine if a type
26707 implements a given interface. Provides a nice cache too.
26709 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
26712 (ConvertReferenceExplicit): Ditto.
26714 * delegate.cs (Delegate::Populate): Update to define the parameters on the
26715 various methods, with correct names etc.
26717 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
26718 Operator.UnaryNegation.
26720 * cs-parser.jay (operator_declarator): Be a little clever in the case where
26721 we have a unary plus or minus operator.
26723 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
26726 * everywhere : update accordingly.
26728 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
26731 * class.cs (Method::Define): For the case where we are implementing a method
26732 inherited from an interface, we need to set the MethodAttributes.Final flag too.
26733 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
26735 2001-10-21 Ravi Pratap <ravi@ximian.com>
26737 * interface.cs (FindMembers): Implement to work around S.R.E
26740 * typemanager.cs (IsInterfaceType): Implement.
26742 (FindMembers): Update to handle interface types too.
26744 * expression.cs (ImplicitReferenceConversion): Re-write bits which
26745 use IsAssignableFrom as that is not correct - it doesn't work.
26747 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
26748 and accordingly override EmitStatement.
26750 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
26751 using the correct logic :-)
26753 2001-10-19 Ravi Pratap <ravi@ximian.com>
26755 * ../errors/cs-11.cs : Add to demonstrate error -11
26757 2001-10-17 Miguel de Icaza <miguel@ximian.com>
26759 * assign.cs (Assign::Resolve): Resolve right hand side first, and
26760 then pass this as a hint to ResolveLValue.
26762 * expression.cs (FieldExpr): Add Location information
26764 (FieldExpr::LValueResolve): Report assignment to readonly
26767 (Expression::ExprClassFromMemberInfo): Pass location information.
26769 (Expression::ResolveLValue): Add new method that resolves an
26772 (Expression::DoResolveLValue): Default invocation calls
26775 (Indexers): New class used to keep track of indexers in a given
26778 (IStackStore): Renamed from LValue, as it did not really describe
26779 what this did. Also ResolveLValue is gone from this interface and
26780 now is part of Expression.
26782 (ElementAccess): Depending on the element access type
26784 * typemanager.cs: Add `indexer_name_type' as a Core type
26785 (System.Runtime.CompilerServices.IndexerNameAttribute)
26787 * statement.cs (Goto): Take a location.
26789 2001-10-18 Ravi Pratap <ravi@ximian.com>
26791 * delegate.cs (Delegate::VerifyDelegate): New method to verify
26792 if two delegates are compatible.
26794 (NewDelegate::DoResolve): Update to take care of the case when
26795 we instantiate a delegate from another delegate.
26797 * typemanager.cs (FindMembers): Don't even try to look up members
26798 of Delegate types for now.
26800 2001-10-18 Ravi Pratap <ravi@ximian.com>
26802 * delegate.cs (NewDelegate): New class to take care of delegate
26805 * expression.cs (New): Split the delegate related code out into
26806 the NewDelegate class.
26808 * delegate.cs (DelegateInvocation): New class to handle delegate
26811 * expression.cs (Invocation): Split out delegate related code into
26812 the DelegateInvocation class.
26814 2001-10-17 Ravi Pratap <ravi@ximian.com>
26816 * expression.cs (New::DoResolve): Implement delegate creation fully
26817 and according to the spec.
26819 (New::DoEmit): Update to handle delegates differently.
26821 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
26822 because of which we were printing out arguments in reverse order !
26824 * delegate.cs (VerifyMethod): Implement to check if the given method
26825 matches the delegate.
26827 (FullDelegateDesc): Implement.
26829 (VerifyApplicability): Implement.
26831 * expression.cs (Invocation::DoResolve): Update to accordingly handle
26832 delegate invocations too.
26834 (Invocation::Emit): Ditto.
26836 * ../errors/cs1593.cs : Added.
26838 * ../errors/cs1594.cs : Added.
26840 * delegate.cs (InstanceExpression, TargetMethod): New properties.
26842 2001-10-16 Ravi Pratap <ravi@ximian.com>
26844 * typemanager.cs (intptr_type): Core type for System.IntPtr
26846 (InitCoreTypes): Update for the same.
26848 (iasyncresult_type, asynccallback_type): Ditto.
26850 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
26853 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26856 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26857 the builders for the 4 members of a delegate type :-)
26859 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26862 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26864 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26866 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26868 * statement.cs (Break::Emit): Implement.
26869 (Continue::Emit): Implement.
26871 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26872 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26873 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26874 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26877 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26878 properties that track the label for the current loop (begin of the
26879 loop and end of the loop).
26881 2001-10-15 Ravi Pratap <ravi@ximian.com>
26883 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26884 use of emitting anything at all.
26886 * class.cs, rootcontext.cs : Get rid of calls to the same.
26888 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26890 (Populate): Define the constructor correctly and set the implementation
26893 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26896 (AddDelegateType): Implement.
26898 (IsDelegateType): Implement helper method.
26900 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26902 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26903 and accordingly handle it.
26905 * delegate.cs (Populate): Take TypeContainer argument.
26906 Implement bits to define the Invoke method. However, I still haven't figured out
26907 how to take care of the native int bit :-(
26909 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26910 Qualify the name of the delegate, not its return type !
26912 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26915 (StandardConversionExists): Checking for array types turns out to be recursive.
26917 (ConvertReferenceExplicit): Implement array conversion.
26919 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26921 2001-10-12 Ravi Pratap <ravi@ximian.com>
26923 * cs-parser.jay (delegate_declaration): Store the fully qualified
26924 name as it is a type declaration.
26926 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26929 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26930 as TypeContainer::DefineType.
26932 (Populate): Method in which all the definition of the various methods (Invoke)
26935 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26938 (CloseDelegate): Finally creates the delegate.
26940 * class.cs (TypeContainer::DefineType): Update to define delegates.
26941 (Populate, Emit and CloseType): Do the same thing here too.
26943 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26944 delegates in all these operations.
26946 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26948 * expression.cs: LocalTemporary: a new expression used to
26949 reference a temporary that has been created.
26951 * assign.cs: Handle PropertyAccess back here, so that we can
26952 provide the proper semantic access to properties.
26954 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26955 a few more explicit conversions.
26957 * modifiers.cs: `NEW' modifier maps to HideBySig.
26959 * expression.cs (PropertyExpr): Make this into an
26960 ExpressionStatement, and support the EmitStatement code path.
26962 Perform get/set error checking, clean up the interface.
26964 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26965 them into toplevel access objects.
26967 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26969 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26972 * typemanager.cs: Keep track here of our PropertyBuilders again to
26973 work around lameness in SRE.
26975 2001-10-11 Miguel de Icaza <miguel@ximian.com>
26977 * expression.cs (LValue::LValueResolve): New method in the
26978 interface, used to perform a second resolution pass for LValues.
26980 (This::DoResolve): Catch the use of this in static methods.
26982 (This::LValueResolve): Implement.
26984 (This::Store): Remove warning, assigning to `this' in structures
26987 (Invocation::Emit): Deal with invocation of
26988 methods on value types. We need to pass the address to structure
26989 methods rather than the object itself. (The equivalent code to
26990 emit "this" for structures leaves the entire structure on the
26991 stack instead of a pointer to it).
26993 (ParameterReference::DoResolve): Compute the real index for the
26994 argument based on whether the method takes or not a `this' pointer
26995 (ie, the method is static).
26997 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
26998 value types returned from functions when we need to invoke a
26999 method on the sturcture.
27002 2001-10-11 Ravi Pratap <ravi@ximian.com>
27004 * class.cs (TypeContainer::DefineType): Method to actually do the business of
27005 defining the type in the Modulebuilder or Typebuilder. This is to take
27006 care of nested types which need to be defined on the TypeBuilder using
27007 DefineNestedMethod.
27009 (TypeContainer::GetClassBases): Implement. Essentially the code from the
27010 methods in RootContext, only ported to be part of TypeContainer.
27012 (TypeContainer::GetInterfaceOrClass): Ditto.
27014 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
27016 * interface.cs (Interface::DefineInterface): New method. Does exactly
27017 what RootContext.CreateInterface did earlier, only it takes care of nested types
27020 (Interface::GetInterfaces): Move from RootContext here and port.
27022 (Interface::GetInterfaceByName): Same here.
27024 * rootcontext.cs (ResolveTree): Re-write.
27026 (PopulateTypes): Re-write.
27028 * class.cs (TypeContainer::Populate): Populate nested types too.
27029 (TypeContainer::Emit): Emit nested members too.
27031 * typemanager.cs (AddUserType): Do not make use of the FullName property,
27032 instead just use the name argument passed in as it is already fully
27035 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
27036 to TypeContainer mapping to see if a type is user-defined.
27038 * class.cs (TypeContainer::CloseType): Implement.
27040 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
27041 the default constructor.
27043 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
27046 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
27048 * interface.cs (CloseType): Create the type here.
27050 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
27053 Remove all the methods which are now in TypeContainer.
27055 2001-10-10 Ravi Pratap <ravi@ximian.com>
27057 * delegate.cs (Define): Re-write bits to define the delegate
27060 2001-10-10 Miguel de Icaza <miguel@ximian.com>
27062 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
27064 * expression.cs (ImplicitReferenceConversion): handle null as well
27065 as a source to convert to any reference type.
27067 * statement.cs (Return): Perform any implicit conversions to
27068 expected return type.
27070 Validate use of return statement.
27072 * codegen.cs (EmitContext): Pass the expected return type here.
27074 * class.cs (Method, Constructor, Property): Pass expected return
27075 type to EmitContext.
27077 2001-10-09 Miguel de Icaza <miguel@ximian.com>
27079 * expression.cs: Make DoResolve take an EmitContext instead of a
27082 Replaced `l' and `location' for `loc', for consistency.
27084 (Error, Warning): Remove unneeded Tc argument.
27086 * assign.cs, literal.cs, constant.cs: Update to new calling
27089 * codegen.cs: EmitContext now contains a flag indicating whether
27090 code is being generated in a static method or not.
27092 * cs-parser.jay: DecomposeQI, new function that replaces the old
27093 QualifiedIdentifier. Now we always decompose the assembled
27094 strings from qualified_identifier productions into a group of
27097 2001-10-08 Miguel de Icaza <miguel@ximian.com>
27099 * rootcontext.cs: Deal with field-less struct types correctly now
27100 by passing the size option to Define Type.
27102 * class.cs: Removed hack that created one static field.
27104 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27106 * statement.cs: Moved most of the code generation here.
27108 2001-10-09 Ravi Pratap <ravi@ximian.com>
27110 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
27113 (ElementAccess): Remove useless bits for now - keep checks as the spec
27116 2001-10-08 Ravi Pratap <ravi@ximian.com>
27118 * expression.cs (ElementAccess::DoResolve): Remove my crap code
27119 and start performing checks according to the spec.
27121 2001-10-07 Ravi Pratap <ravi@ximian.com>
27123 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
27124 rank_specifiers instead.
27126 (rank_specifiers): Change the order in which the rank specifiers are stored
27128 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
27130 * expression.cs (ElementAccess): Implement the LValue interface too.
27132 2001-10-06 Ravi Pratap <ravi@ximian.com>
27134 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
27135 except that user defined conversions are not included.
27137 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
27138 perform the conversion of the return type, if necessary.
27140 (New::DoResolve): Check whether we are creating an array or an object
27141 and accordingly do the needful.
27143 (New::Emit): Same here.
27145 (New::DoResolve): Implement guts of array creation.
27147 (New::FormLookupType): Helper function.
27149 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27151 * codegen.cs: Removed most of the code generation here, and move the
27152 corresponding code generation bits to the statement classes.
27154 Added support for try/catch/finalize and throw.
27156 * cs-parser.jay: Added support for try/catch/finalize.
27158 * class.cs: Catch static methods having the flags override,
27159 virtual or abstract.
27161 * expression.cs (UserCast): This user cast was not really doing
27162 what it was supposed to do. Which is to be born in fully resolved
27163 state. Parts of the resolution were being performed at Emit time!
27167 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27169 * expression.cs: Implicity convert the result from UserCast.
27171 2001-10-05 Ravi Pratap <ravi@ximian.com>
27173 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
27174 prevented it from working correctly.
27176 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
27177 merely ConvertImplicit.
27179 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27181 * typemanager.cs: Make the LookupTypeContainer function static,
27182 and not per-instance.
27184 * class.cs: Make static FindMembers (the one that takes a Type
27187 * codegen.cs: Add EmitForeach here.
27189 * cs-parser.jay: Make foreach a toplevel object instead of the
27190 inline expansion, as we need to perform semantic analysis on it.
27192 2001-10-05 Ravi Pratap <ravi@ximian.com>
27194 * expression.cs (Expression::ImplicitUserConversion): Rename to
27195 UserDefinedConversion.
27197 (Expression::UserDefinedConversion): Take an extra argument specifying
27198 whether we look for explicit user conversions too.
27200 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
27202 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
27204 (ExplicitUserConversion): Make it a call to UserDefinedConversion
27205 with the appropriate arguments.
27207 * cs-parser.jay (cast_expression): Record location too.
27209 * expression.cs (Cast): Record location info.
27211 (Expression::ConvertExplicit): Take location argument.
27213 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
27214 to determine if we are doing explicit conversions.
27216 (UserCast::Emit): Update accordingly.
27218 (Expression::ConvertExplicit): Report an error if everything fails.
27220 * ../errors/cs0030.cs : Add.
27222 2001-10-04 Miguel de Icaza <miguel@ximian.com>
27224 * modifiers.cs: If the ABSTRACT keyword is present, also set the
27225 virtual and newslot bits.
27227 * class.cs (TypeContainer::RegisterRequiredImplementations):
27228 Record methods we need.
27230 (TypeContainer::MakeKey): Helper function to make keys for
27231 MethodBases, since the Methodbase key is useless.
27233 (TypeContainer::Populate): Call RegisterRequiredImplementations
27234 before defining the methods.
27236 Create a mapping for method_builders_to_methods ahead of time
27237 instead of inside a tight loop.
27239 (::RequireMethods): Accept an object as the data to set into the
27240 hashtable so we can report interface vs abstract method mismatch.
27242 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27244 * report.cs: Make all of it static.
27246 * rootcontext.cs: Drop object_type and value_type computations, as
27247 we have those in the TypeManager anyways.
27249 Drop report instance variable too, now it is a global.
27251 * driver.cs: Use try/catch on command line handling.
27253 Add --probe option to debug the error reporting system with a test
27256 * report.cs: Add support for exiting program when a probe
27257 condition is reached.
27259 2001-10-03 Ravi Pratap <ravi@ximian.com>
27261 * expression.cs (Binary::DoNumericPromotions): Fix the case when
27262 we do a forcible conversion regardless of type, to check if
27263 ForceConversion returns a null.
27265 (Binary::error19): Use location to report error.
27267 (Unary::error23): Use location here too.
27269 * ../errors/cs0019.cs : Check in.
27271 * ../errors/cs0023.cs : Check in.
27273 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
27274 case of a non-null MethodInfo object with a length of 0 !
27276 (Binary::ResolveOperator): Flag error if overload resolution fails to find
27277 an applicable member - according to the spec :-)
27278 Also fix logic to find members in base types.
27280 (Unary::ResolveOperator): Same here.
27282 (Unary::report23): Change name to error23 and make first argument a TypeContainer
27283 as I was getting thoroughly confused between this and error19 :-)
27285 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
27286 (::FindMostEncompassedType): Implement.
27287 (::FindMostEncompassingType): Implement.
27288 (::StandardConversionExists): Implement.
27290 (UserImplicitCast): Re-vamp. We now need info about most specific
27291 source and target types so that we can do the necessary conversions.
27293 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
27294 mathematical union with no duplicates.
27296 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27298 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
27299 in order from base classes to child classes, so that we can in
27300 child classes look up in our parent for method names and
27301 attributes (required for handling abstract, virtual, new, override
27302 constructs: we need to instrospect our base class, and if we dont
27303 populate the classes in order, the introspection might be
27304 incorrect. For example, a method could query its parent before
27305 the parent has any methods and would determine that the parent has
27306 no abstract methods (while it could have had them)).
27308 (RootContext::CreateType): Record the order in which we define the
27311 2001-10-02 Miguel de Icaza <miguel@ximian.com>
27313 * class.cs (TypeContainer::Populate): Also method definitions can
27314 fail now, keep track of this.
27316 (TypeContainer::FindMembers): Implement support for
27317 DeclaredOnly/noDeclaredOnly flag.
27319 (Constructor::Emit) Return the ConstructorBuilder.
27321 (Method::Emit) Return the MethodBuilder.
27322 Check for abstract or virtual methods to be public.
27324 * rootcontext.cs (RootContext::CreateType): Register all the
27325 abstract methods required for the class to be complete and the
27326 interface methods that must be implemented.
27328 * cs-parser.jay: Report error 501 (method requires body if it is
27329 not marked abstract or extern).
27331 * expression.cs (TypeOf::Emit): Implement.
27333 * typemanager.cs: runtime_handle_type, new global type.
27335 * class.cs (Property::Emit): Generate code for properties.
27337 2001-10-02 Ravi Pratap <ravi@ximian.com>
27339 * expression.cs (Unary::ResolveOperator): Find operators on base type
27340 too - we now conform exactly to the spec.
27342 (Binary::ResolveOperator): Same here.
27344 * class.cs (Operator::Define): Fix minor quirk in the tests.
27346 * ../errors/cs0215.cs : Added.
27348 * ../errors/cs0556.cs : Added.
27350 * ../errors/cs0555.cs : Added.
27352 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27354 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
27355 single integer which is really efficient
27357 2001-10-01 Ravi Pratap <ravi@ximian.com>
27359 * expression.cs (Expression::ImplicitUserConversion): Use location
27360 even in the case when we are examining True operators.
27362 * class.cs (Operator::Define): Perform extensive checks to conform
27363 with the rules for operator overloading in the spec.
27365 * expression.cs (Expression::ImplicitReferenceConversion): Implement
27366 some of the other conversions mentioned in the spec.
27368 * typemanager.cs (array_type): New static member for the System.Array built-in
27371 (cloneable_interface): For System.ICloneable interface.
27373 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
27374 we start resolving the tree and populating types.
27376 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
27378 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27380 * expression.cs (Expression::ExprClassFromMemberInfo,
27381 Expression::Literalize): Create literal expressions from
27382 FieldInfos which are literals.
27384 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
27385 type casts, because they were wrong. The test suite in tests
27388 (ImplicitNumericConversion): ushort to ulong requires a widening
27391 Int32 constant to long requires widening cast as well.
27393 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
27394 for integers because the type on the stack is not i4.
27396 2001-09-30 Miguel de Icaza <miguel@ximian.com>
27398 * expression.cs (report118): require location argument.
27400 * parameter.cs: Do not dereference potential null value.
27402 * class.cs: Catch methods that lack the `new' keyword when
27403 overriding a name. Report warnings when `new' is used without
27404 anything being there to override.
27406 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
27408 * class.cs: Only add constructor to hashtable if it is non-null
27409 (as now constructors can fail on define).
27411 (TypeManager, Class, Struct): Take location arguments.
27413 Catch field instance initialization in structs as errors.
27415 accepting_filter: a new filter for FindMembers that is static so
27416 that we dont create an instance per invocation.
27418 (Constructor::Define): Catch errors where a struct constructor is
27421 * cs-parser.jay: Pass location information for various new
27424 * delegate.cs (Delegate): take a location argument.
27426 * driver.cs: Do not call EmitCode if there were problesm in the
27427 Definition of the types, as many Builders wont be there.
27429 * decl.cs (Decl::Decl): Require a location argument.
27431 * cs-tokenizer.cs: Handle properly hex constants that can not fit
27432 into integers, and find the most appropiate integer for it.
27434 * literal.cs: Implement ULongLiteral.
27436 * rootcontext.cs: Provide better information about the location of
27437 failure when CreateType fails.
27439 2001-09-29 Miguel de Icaza <miguel@ximian.com>
27441 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
27444 * expression.cs (Binary::CheckShiftArguments): Add missing type
27446 (Binary::ResolveOperator): Add type to the logical and and logical
27447 or, Bitwise And/Or and Exclusive Or code paths, it was missing
27450 (Binary::DoNumericPromotions): In the case where either argument
27451 is ulong (and most signed types combined with ulong cause an
27452 error) perform implicit integer constant conversions as well.
27454 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27456 * expression.cs (UserImplicitCast): Method should always be
27458 (Invocation::BetterConversion): Simplified test for IntLiteral.
27460 (Expression::ImplicitNumericConversion): Split this routine out.
27461 Put the code that performs implicit constant integer conversions
27464 (Expression::Resolve): Become a wrapper around DoResolve so we can
27465 check eclass and type being set after resolve.
27467 (Invocation::Badness): Remove this dead function
27469 (Binary::ResolveOperator): Do not compute the expensive argumnets
27470 unless we have a union for it.
27472 (Probe::Emit): Is needs to do an isinst and then
27473 compare against null.
27475 (::CanConvert): Added Location argument. If the Location argument
27476 is null (Location.Null), then we do not report errors. This is
27477 used by the `probe' mechanism of the Explicit conversion. We do
27478 not want to generate an error for something that the user
27479 explicitly requested to be casted. But the pipeline for an
27480 explicit cast first tests for potential implicit casts.
27482 So for now, if the Location is null, it means `Probe only' to
27483 avoid adding another argument. Might have to revise this
27486 (ClassCast): New class used to type cast objects into arbitrary
27487 classes (used in Explicit Reference Conversions).
27489 Implement `as' as well.
27491 Reverted all the patches from Ravi below: they were broken:
27493 * The use of `level' as a mechanism to stop recursive
27494 invocations is wrong. That was there just to catch the
27495 bug with a strack trace but not as a way of addressing
27498 To fix the problem we have to *understand* what is going
27499 on and the interactions and come up with a plan, not
27500 just get things going.
27502 * The use of the type conversion cache that I proposed
27503 last night had an open topic: How does this work across
27504 protection domains. A user defined conversion might not
27505 be public in the location where we are applying the
27506 conversion, a different conversion might be selected
27507 (ie, private A->B (better) but public B->A (worse),
27508 inside A, A->B applies, but outside it, B->A will
27511 * On top of that (ie, even if the above is solved),
27512 conversions in a cache need to be abstract. Ie, `To
27513 convert from an Int to a Short use an OpcodeCast', not
27514 `To convert from an Int to a Short use the OpcodeCast on
27515 the variable 5' (which is what this patch was doing).
27517 2001-09-28 Ravi Pratap <ravi@ximian.com>
27519 * expression.cs (Invocation::ConversionExists): Re-write to use
27520 the conversion cache
27522 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
27523 cache all conversions done, not just user-defined ones.
27525 (Invocation::BetterConversion): The real culprit. Use ConversionExists
27526 to determine if a conversion exists instead of acutually trying to
27527 perform the conversion. It's faster too.
27529 (Expression::ConvertExplicit): Modify to use ConversionExists to check
27530 and only then attempt the implicit conversion.
27532 2001-09-28 Ravi Pratap <ravi@ximian.com>
27534 * expression.cs (ConvertImplicit): Use a cache for conversions
27535 already found. Check level of recursion and bail out if necessary.
27537 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27539 * typemanager.cs (string_concat_string_string, string_concat_object_object):
27540 Export standard methods that we expect for string operations.
27542 * statement.cs (Block::UsageWarning): Track usage of variables and
27543 report the errors for not used variables.
27545 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
27548 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27550 * codegen.cs: remove unnneded code
27552 * expression.cs: Removed BuiltinTypeAccess class
27554 Fix the order in which implicit conversions are
27557 The previous fixed dropped support for boxed conversions (adding a
27558 test to the test suite now)
27560 (UserImplicitCast::CanConvert): Remove test for source being null,
27561 that code is broken. We should not feed a null to begin with, if
27562 we do, then we should track the bug where the problem originates
27563 and not try to cover it up here.
27565 Return a resolved expression of type UserImplicitCast on success
27566 rather than true/false. Ravi: this is what I was talking about,
27567 the pattern is to use a static method as a "constructor" for
27570 Also, do not create arguments until the very last minute,
27571 otherwise we always create the arguments even for lookups that
27572 will never be performed.
27574 (UserImplicitCast::Resolve): Eliminate, objects of type
27575 UserImplicitCast are born in a fully resolved state.
27577 * typemanager.cs (InitCoreTypes): Init also value_type
27578 (System.ValueType).
27580 * expression.cs (Cast::Resolve): First resolve the child expression.
27582 (LValue): Add new method AddressOf to be used by
27585 Change the argument of Store to take an EmitContext instead of an
27586 ILGenerator, because things like FieldExpr need to be able to call
27587 their children expression to generate the instance code.
27589 (Expression::Error, Expression::Warning): Sugar functions for
27592 (Expression::MemberLookup): Accept a TypeContainer instead of a
27593 Report as the first argument.
27595 (Expression::ResolvePrimary): Killed. I still want to improve
27596 this as currently the code is just not right.
27598 (Expression::ResolveMemberAccess): Simplify, but it is still
27601 (Unary::Resolve): Catch errors in AddressOf operators.
27603 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
27604 index to a byte for the short-version, or the compiler will choose
27605 the wrong Emit call, which generates the wrong data.
27607 (ParameterReference::Emit, ::Store): same.
27609 (FieldExpr::AddressOf): Implement.
27611 * typemanager.cs: TypeManager: made public variable instead of
27614 * driver.cs: document --fatal.
27616 * report.cs (ErrorMessage, WarningMessage): new names for the old
27617 Error and Warning classes.
27619 * cs-parser.jay (member_access): Turn built-in access to types
27620 into a normal simplename
27622 2001-09-27 Ravi Pratap <ravi@ximian.com>
27624 * expression.cs (Invocation::BetterConversion): Fix to cope
27625 with q being null, since this was introducing a bug.
27627 * expression.cs (ConvertImplicit): Do built-in conversions first.
27629 2001-09-27 Ravi Pratap <ravi@ximian.com>
27631 * expression.cs (UserImplicitCast::Resolve): Fix bug.
27633 2001-09-27 Ravi Pratap <ravi@ximian.com>
27635 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
27636 I had introduced long ago (what's new ?).
27638 * expression.cs (UserImplicitCast::CanConvert): Static method to do
27639 the work of all the checking.
27640 (ConvertImplicit): Call CanConvert and only then create object if necessary.
27641 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
27643 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
27644 that is the right way.
27646 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
27647 overloading resolution. Use everywhere instead of cutting and pasting code.
27649 (Binary::ResolveOperator): Use MakeUnionSet.
27651 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
27652 we have to convert to bool types. Not complete yet.
27654 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27656 * typemanager.cs (TypeManager::CSharpName): support ushort.
27658 * expression.cs (Expression::TryImplicitIntConversion): Attempts
27659 to provide an expression that performsn an implicit constant int
27660 conversion (section 6.1.6).
27661 (Expression::ConvertImplicitRequired): Reworked to include
27662 implicit constant expression conversions.
27664 (Expression::ConvertNumericExplicit): Finished.
27666 (Invocation::Emit): If InstanceExpression is null, then it means
27667 that we perform a call on this.
27669 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27671 * expression.cs (Unary::Emit): Remove some dead code.
27672 (Probe): Implement Resolve and Emit for `is'.
27673 (Expression::ConvertImplicitRequired): Attempt to do constant
27674 expression conversions here. Maybe should be moved to
27675 ConvertImplicit, but I am not sure.
27676 (Expression::ImplicitLongConstantConversionPossible,
27677 Expression::ImplicitIntConstantConversionPossible): New functions
27678 that tell whether is it possible to apply an implicit constant
27679 expression conversion.
27681 (ConvertNumericExplicit): Started work on explicit numeric
27684 * cs-parser.jay: Update operator constants.
27686 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
27687 (Parameters::GetSignature): Hook up VerifyArgs here.
27688 (Parameters::VerifyArgs): Verifies that no two arguments have the
27691 * class.cs (Operator): Update the operator names to reflect the
27692 ones that the spec expects (as we are just stringizing the
27695 * expression.cs (Unary::ResolveOperator): Fix bug: Use
27696 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
27697 previous usage did only work for our methods.
27698 (Expression::ConvertImplicit): Handle decimal implicit numeric
27699 conversions as well.
27700 (Expression::InternalTypeConstructor): Used to invoke constructors
27701 on internal types for default promotions.
27703 (Unary::Emit): Implement special handling for the pre/post
27704 increment/decrement for overloaded operators, as they need to have
27705 the same semantics as the other operators.
27707 (Binary::ResolveOperator): ditto.
27708 (Invocation::ConversionExists): ditto.
27709 (UserImplicitCast::Resolve): ditto.
27711 2001-09-26 Ravi Pratap <ravi@ximian.com>
27713 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
27714 operator, return after emitting body. Regression tests pass again !
27716 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
27717 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
27718 (Invocation::OverloadResolve): Ditto.
27719 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
27721 * everywhere : update calls to the above methods accordingly.
27723 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27725 * assign.cs (Assign): Make it inherit from ExpressionStatement.
27727 * expression.cs (ExpressionStatement): New base class used for
27728 expressions that can appear in statements, so that we can provide
27729 an alternate path to generate expression that do not leave a value
27732 (Expression::Emit, and all the derivatives): We no longer return
27733 whether a value is left on the stack or not. Every expression
27734 after being emitted leaves a single value on the stack.
27736 * codegen.cs (EmitContext::EmitStatementExpression): Use the
27737 facilties of ExpressionStatement if possible.
27739 * cs-parser.jay: Update statement_expression.
27741 2001-09-25 Miguel de Icaza <miguel@ximian.com>
27743 * driver.cs: Change the wording of message
27745 2001-09-25 Ravi Pratap <ravi@ximian.com>
27747 * expression.cs (Binary::ResolveOperator): Had forgottten to set
27748 the type of the expression to the return type of the method if
27749 we have an overloaded operator match ! The regression tests pass again !
27750 (Unary::ResolveOperator): Ditto.
27752 * expression.cs (Invocation::ConversionExists): Correct the member lookup
27753 to find "op_Implicit", not "implicit" ;-)
27754 (UserImplicitCast): New class to take care of user-defined implicit conversions.
27755 (ConvertImplicit, ForceConversion): Take TypeContainer argument
27757 * everywhere : Correct calls to the above accordingly.
27759 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
27760 (ConvertImplicit): Do user-defined conversion if it exists.
27762 2001-09-24 Miguel de Icaza <miguel@ximian.com>
27764 * assign.cs: track location.
27765 (Resolve): Use implicit conversions on assignment.
27767 * literal.cs: Oops. Not good, Emit of short access values should
27768 pass (Bytes) or the wrong argument will be selected.
27770 * expression.cs (Unary::Emit): Emit code for -expr.
27772 (Unary::ResolveOperator): Handle `Substract' for non-constants
27773 (substract from zero from the non-constants).
27774 Deal with Doubles as well.
27776 (Expression::ConvertImplicitRequired): New routine that reports an
27777 error if no implicit conversion exists.
27779 (Invocation::OverloadResolve): Store the converted implicit
27780 expressions if we make them
27782 2001-09-24 Ravi Pratap <ravi@ximian.com>
27784 * class.cs (ConstructorInitializer): Take a Location argument.
27785 (ConstructorBaseInitializer): Same here.
27786 (ConstructorThisInitializer): Same here.
27788 * cs-parser.jay : Update all calls accordingly.
27790 * expression.cs (Unary, Binary, New): Take location argument.
27791 Update accordingly everywhere.
27793 * cs-parser.jay : Update all calls to the above to take a location
27796 * class.cs : Ditto.
27798 2001-09-24 Ravi Pratap <ravi@ximian.com>
27800 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
27801 (Invocation::BetterConversion): Same here
27802 (Invocation::ConversionExists): Ditto.
27804 (Invocation::ConversionExists): Implement.
27806 2001-09-22 Ravi Pratap <ravi@ximian.com>
27808 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
27809 Also take an additional TypeContainer argument.
27811 * All over : Pass in TypeContainer as argument to OverloadResolve.
27813 * typemanager.cs (CSharpName): Update to check for the string type and return
27816 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
27819 2001-09-21 Ravi Pratap <ravi@ximian.com>
27821 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
27822 (Invocation::BetterFunction): Implement.
27823 (Invocation::BetterConversion): Implement.
27824 (Invocation::ConversionExists): Skeleton, no implementation yet.
27826 Okay, things work fine !
27828 2001-09-21 Miguel de Icaza <miguel@ximian.com>
27830 * typemanager.cs: declare and load enum_type, delegate_type and
27833 * expression.cs (Expression::Emit): Now emit returns a value that
27834 tells whether a value is left on the stack or not. This strategy
27835 might be reveted tomorrow with a mechanism that would address
27836 multiple assignments.
27837 (Expression::report118): Utility routine to report mismatches on
27840 (Unary::Report23): Report impossible type/operator combination
27843 (Unary::IsIncrementableNumber): Whether the type can be
27844 incremented or decremented with add.
27845 (Unary::ResolveOperator): Also allow enumerations to be bitwise
27847 (Unary::ResolveOperator): Implement ++, !, ~,
27849 (Invocation::Emit): Deal with new Emit convetion.
27851 * All Expression derivatives: Updated their Emit method to return
27852 whether they leave values on the stack or not.
27854 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27855 stack for expressions that are statements.
27857 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27859 * expression.cs (LValue): New interface. Must be implemented by
27861 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27864 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27865 interface for generating code, simplifies the code.
27867 2001-09-20 Ravi Pratap <ravi@ximian.com>
27869 * expression.cs (everywhere): Comment out return statements in ::Resolve
27870 methods to avoid the warnings.
27872 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27874 * driver.cs (parse): Report error 2001 if we can not open the
27877 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27880 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27883 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27884 otherwise nested blocks end up with the same index.
27886 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27888 * expression.cs: Instead of having FIXMEs in the Resolve
27889 functions, throw exceptions so it is obvious that we are facing a
27892 * cs-parser.jay (invocation_expression): Pass Location information.
27894 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27895 Use a basename for those routines because .NET does not like paths
27898 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27901 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27903 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27904 are loading the correct data types (throws an exception if not).
27905 (TypeManager::InitCoreTypes): Use CoreLookupType
27907 * expression.cs (Unary::ResolveOperator): return the child
27908 expression for expressions which are just +expr.
27909 (Unary::ResolveOperator): Return negative literals for -LITERAL
27910 expressions (otherwise they are Unary {Literal}).
27911 (Invocation::Badness): Take into account `Implicit constant
27912 expression conversions'.
27914 * literal.cs (LongLiteral): Implement long literal class.
27915 (IntLiteral): export the `Value' of the intliteral.
27917 2001-09-19 Ravi Pratap <ravi@ximian.com>
27919 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27921 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27922 instead of 'Operator'
27924 * expression.cs (Binary::ResolveOperator): Update accordingly.
27925 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27928 * cs-parser.jay (unary_expression): Update to use the new names.
27930 * gen-treedump.cs (GetUnary): Same here.
27932 * expression.cs (Unary::Resolve): Implement.
27933 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27934 operators are found instead of making noise ;-)
27935 (Unary::ResolveOperator): New method to do precisely the same thing which
27936 Binary::ResolveOperator does for Binary expressions.
27937 (Unary.method, .Arguments): Add.
27938 (Unary::OperName): Implement.
27939 (Unary::ForceConversion): Copy and Paste !
27941 * class.cs (Operator::Define): Fix a small bug for the case when we have
27944 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27945 for the inbuilt operators. Only overloading works for now ;-)
27947 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27949 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27950 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27952 * expression.cs (This::Emit): Implement.
27953 (This::Resolve): Implement.
27954 (TypeOf:Resolve): Implement.
27955 (Expression::ResolveSimpleName): Add an implicit this to instance
27957 (MemberAccess::Resolve): Deal with Parameters and Fields.
27958 Bind instance variable to Field expressions.
27959 (FieldExpr::Instance): New field used to track the expression that
27960 represents the object instance.
27961 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27963 (FieldExpr::Emit): Implement.
27965 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27966 the last instruction contains a return opcode to avoid generating
27967 the last `ret' instruction (this generates correct code, and it is
27968 nice to pass the peverify output).
27970 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27971 initializer for static and instance variables.
27972 (Constructor::Emit): Allow initializer to be null in the case of
27973 static constructors. Only emit initializer for instance
27976 (TypeContainer::FindMembers): Return a null array if there are no
27979 Also fix the code for the MemberTypes.Method branch, as it was not
27980 scanning that for operators (or tried to access null variables before).
27982 * assign.cs (Assign::Emit): Handle instance and static fields.
27986 * driver.cs: Stop compilation if there are parse errors.
27988 * cs-parser.jay (constructor_declaration): Provide default base
27989 initializer for non-static constructors.
27990 (constructor_declarator): Do not provide a default base
27991 initializers if none was specified.
27992 Catch the fact that constructors should not have parameters.
27994 * class.cs: Do not emit parent class initializers for static
27995 constructors, that should be flagged as an error.
27997 2001-09-18 Ravi Pratap <ravi@ximian.com>
27999 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
28000 Move back code into TypeContainer::Populate.
28002 2001-09-18 Ravi Pratap <ravi@ximian.com>
28004 * class.cs (TypeContainer::AddConstructor): Fix the check to
28005 compare against Name, not Basename.
28006 (Operator::OpType): Change Plus and Minus to Add and Subtract.
28008 * cs-parser.jay : Update accordingly.
28010 * class.cs (TypeContainer::FindMembers): For the case where we are searching
28011 for methods, don't forget to look into the operators too.
28012 (RegisterMethodBuilder): Helper method to take care of this for
28013 methods, constructors and operators.
28014 (Operator::Define): Completely revamp.
28015 (Operator.OperatorMethod, MethodName): New fields.
28016 (TypeContainer::Populate): Move the registering of builders into
28017 RegisterMethodBuilder.
28018 (Operator::Emit): Re-write.
28020 * expression.cs (Binary::Emit): Comment out code path to emit method
28021 invocation stuff for the case when we have a user defined operator. I am
28022 just not able to get it right !
28024 2001-09-17 Miguel de Icaza <miguel@ximian.com>
28026 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
28029 (Expression::MemberLookup): Provide a version that allows to
28030 specify the MemberTypes and BindingFlags.
28032 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
28033 so it was not fetching variable information from outer blocks.
28035 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
28036 Beforefieldinit as it was buggy.
28038 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
28039 that Ravi put here.
28041 * class.cs (Constructor::Emit): Only emit if block is not null.
28042 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
28043 deal with this by semantically definining it as if the user had
28046 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
28047 constructors as we now "emit" them at a higher level.
28049 (TypeContainer::DefineDefaultConstructor): Used to define the
28050 default constructors if none was provided.
28052 (ConstructorInitializer): Add methods Resolve and Emit.
28054 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
28056 2001-09-17 Ravi Pratap <ravi@ximian.com>
28058 * class.cs (TypeContainer::EmitDefaultConstructor): Register
28059 the default constructor builder with our hashtable for methodbuilders
28062 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
28063 and argument_count is 0 in which case we have a match.
28064 (Binary::ResolveOperator): More null checking and miscellaneous coding
28067 2001-09-17 Ravi Pratap <ravi@ximian.com>
28069 * rootcontext.cs (IsNameSpace): Compare against null.
28071 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
28073 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
28074 and Unary::Operator.
28076 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
28079 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
28080 we have overloaded operators.
28081 (Binary::ResolveOperator): Implement the part which does the operator overload
28084 * class.cs (Operator::Emit): Implement.
28085 (TypeContainer::Emit): Emit the operators we have too.
28087 * expression.cs (Binary::Emit): Update to emit the appropriate code for
28088 the case when we have a user-defined operator.
28090 2001-09-17 Miguel de Icaza <miguel@ximian.com>
28092 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
28094 2001-09-16 Ravi Pratap <ravi@ximian.com>
28096 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
28097 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
28098 (Constructor::Emit): Implement.
28099 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
28100 if we have no work to do.
28101 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
28104 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
28105 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
28107 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
28110 2001-09-15 Ravi Pratap <ravi@ximian.com>
28112 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
28114 (Tree::RecordNamespace): Method to do what the name says ;-)
28115 (Tree::Namespaces): Property to get at the namespaces hashtable.
28117 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
28120 * rootcontext.cs (IsNamespace): Fixed it :-)
28122 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28124 * class.cs (TypeContainer::FindMembers): Add support for
28126 (MethodCore): New class that encapsulates both the shared aspects
28127 of a Constructor and a Method.
28128 (Method, Constructor): Factored pieces into MethodCore.
28130 * driver.cs: Added --fatal which makes errors throw exceptions.
28131 Load System assembly as well as part of the standard library.
28133 * report.cs: Allow throwing exceptions on errors for debugging.
28135 * modifiers.cs: Do not use `parent', instead use the real type
28136 container to evaluate permission settings.
28138 * class.cs: Put Ravi's patch back in. He is right, and we will
28139 have to cope with the
28141 2001-09-14 Ravi Pratap <ravi@ximian.com>
28143 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
28144 FamORAssem, not FamANDAssem.
28146 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28148 * driver.cs: Added --parse option that only parses its input files
28151 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
28152 incorrect. IsTopLevel is not used to tell whether an object is
28153 root_types or not (that can be achieved by testing this ==
28154 root_types). But to see if this is a top-level *class* (not
28155 necessarly our "toplevel" container).
28157 2001-09-14 Ravi Pratap <ravi@ximian.com>
28159 * enum.cs (Enum::Define): Modify to call the Lookup method on the
28160 parent instead of a direct call to GetType.
28162 2001-09-14 Ravi Pratap <ravi@ximian.com>
28164 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
28165 Modifiers.TypeAttr. This should just be a call to that method.
28167 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
28168 object so that we can determine if we are top-level or not.
28170 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
28173 * enum.cs (Enum::Define): Ditto.
28175 * modifiers.cs (FieldAttr): Re-write.
28177 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
28178 (TypeContainer::HaveStaticConstructor): New property to provide access
28179 to precisely that info.
28181 * modifiers.cs (MethodAttr): Re-write.
28182 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
28184 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
28185 of top-level types as claimed.
28187 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28189 * expression.cs (MemberLookup): Fruitless attempt to lookup
28190 constructors. Maybe I need to emit default constructors? That
28191 might be it (currently .NET emits this for me automatically).
28192 (Invocation::OverloadResolve): Cope with Arguments == null.
28193 (Invocation::EmitArguments): new function, shared by the new
28194 constructor and us.
28195 (Invocation::Emit): Handle static and instance methods. Emit
28196 proper call instruction for virtual or non-virtual invocations.
28197 (New::Emit): Implement.
28198 (New::Resolve): Implement.
28199 (MemberAccess:Resolve): Implement.
28200 (MethodGroupExpr::InstanceExpression): used conforming to the spec
28201 to track instances.
28202 (FieldExpr::Resolve): Set type.
28204 * support.cs: Handle empty arguments.
28206 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
28207 SimpleLookup): Auxiliary routines to help parse a qualifier
28210 Update qualifier_identifier rule.
28212 * codegen.cs: Removed debugging messages.
28214 * class.cs: Make this a global thing, this acts just as a "key" to
28215 objects that we might have around.
28217 (Populate): Only initialize method_builders_to_methods once.
28219 * expression.cs (PropertyExpr): Initialize type from the
28222 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
28223 Resolve pattern. Attempt to implicitly convert value to boolean.
28226 * expression.cs: Set the type for the int32/int32 argument case.
28227 (Binary::ResolveOperator): Set the return type to boolean for
28228 comparission operators
28230 * typemanager.cs: Remove debugging print code.
28232 (Invocation::Resolve): resolve type.
28234 * class.cs: Allocate a MemberInfo of the correct size, as the code
28235 elsewhere depends on the test to reflect the correct contents.
28237 (Method::) Keep track of parameters, due to System.Reflection holes
28239 (TypeContainer::Populate): Keep track of MethodBuilders to Method
28242 (TypeContainer::FindMembers): Use ArrayList and then copy an array
28243 of the exact size and return that.
28245 (Class::LookupMethodByBuilder): New function that maps
28246 MethodBuilders to its methods. Required to locate the information
28247 on methods because System.Reflection bit us again.
28249 * support.cs: New file, contains an interface ParameterData and
28250 two implementations: ReflectionParameters and InternalParameters
28251 used to access Parameter information. We will need to grow this
28254 * expression.cs (Invocation::GetParameterData): implement a cache
28255 and a wrapper around the ParameterData creation for methods.
28256 (Invocation::OverloadResolve): Use new code.
28258 2001-09-13 Ravi Pratap <ravi@ximian.com>
28260 * class.cs (TypeContainer::EmitField): Remove and move into
28261 (Field::Define): here and modify accordingly.
28262 (Field.FieldBuilder): New member.
28263 (TypeContainer::Populate): Update accordingly.
28264 (TypeContainer::FindMembers): Implement.
28266 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28268 * statement.cs: (VariableInfo::VariableType): New field to be
28269 initialized with the full type once it is resolved.
28271 2001-09-12 Miguel de Icaza <miguel@ximian.com>
28273 * parameter.cs (GetParameterInfo): Use a type cache to compute
28274 things only once, and to reuse this information
28276 * expression.cs (LocalVariableReference::Emit): Implement.
28277 (OpcodeCast::Emit): fix.
28279 (ParameterReference::Resolve): Implement.
28280 (ParameterReference::Emit): Implement.
28282 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
28283 that are expressions need to stay as Expressions.
28285 * typemanager.cs (CSharpName): Returns the C# name of a type if
28288 * expression.cs (Expression::ConvertImplicit): New function that
28289 implements implicit type conversions.
28291 (Expression::ImplicitReferenceConversion): Implements implicit
28292 reference conversions.
28294 (EmptyCast): New type for transparent casts.
28296 (OpcodeCast): New type for casts of types that are performed with
28297 a sequence of bytecodes.
28299 (BoxedCast): New type used for casting value types into reference
28300 types. Emits a box opcode.
28302 (Binary::DoNumericPromotions): Implements numeric promotions of
28303 and computation of the Binary::Type.
28305 (Binary::EmitBranchable): Optimization.
28307 (Binary::Emit): Implement code emission for expressions.
28309 * typemanager.cs (TypeManager): Added two new core types: sbyte
28312 2001-09-12 Ravi Pratap <ravi@ximian.com>
28314 * class.cs (TypeContainer::FindMembers): Method which does exactly
28315 what Type.FindMembers does, only we don't have to use reflection. No
28316 implementation yet.
28318 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
28319 typecontainer objects as we need to get at them.
28320 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
28322 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
28323 typecontainer object.
28325 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
28326 of just a Report object.
28328 2001-09-11 Ravi Pratap <ravi@ximian.com>
28330 * class.cs (Event::Define): Go back to using the prefixes "add_" and
28332 (TypeContainer::Populate): Now define the delegates of the type too.
28333 (TypeContainer.Delegates): Property to access the list of delegates defined
28336 * delegates.cs (Delegate::Define): Implement partially.
28338 * modifiers.cs (TypeAttr): Handle more flags.
28340 2001-09-11 Ravi Pratap <ravi@ximian.com>
28342 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
28344 (Operator::Define): Re-write logic to get types by using the LookupType method
28345 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
28346 (Indexer::Define): Ditto.
28347 (Event::Define): Ditto.
28348 (Property::Define): Ditto.
28350 2001-09-10 Ravi Pratap <ravi@ximian.com>
28352 * class.cs (TypeContainer::Populate): Now define operators too.
28353 (TypeContainer.Operators): New property to access the list of operators
28355 (Operator.OperatorMethodBuilder): New member to hold the method builder
28356 for the operator we are defining.
28357 (Operator::Define): Implement.
28359 2001-09-10 Ravi Pratap <ravi@ximian.com>
28361 * class.cs (Event::Define): Make the prefixes of the accessor methods
28362 addOn_ and removeOn_
28364 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
28365 of the location being passed in too. Ideally, this should go later since all
28366 error reporting should be done through the Report object.
28368 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
28369 (Populate): Iterate thru the indexers we have and define them too.
28370 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
28371 for the get and set accessors.
28372 (Indexer::Define): Implement.
28374 2001-09-09 Miguel de Icaza <miguel@ximian.com>
28376 * expression.cs (Binary::Resolve): Beginning of it. I scratched
28377 my previous implementation, did not work.
28379 * typemanager.cs: Add a couple of missing types (the longs).
28381 * literal.cs: Use TypeManager.bool_type instead of getting it.
28383 * expression.cs (EventExpr): New kind of expressions.
28384 (Expressio::ExprClassFromMemberInfo): finish
28386 2001-09-08 Miguel de Icaza <miguel@ximian.com>
28388 * assign.cs: Emit stores to static fields differently.
28390 2001-09-08 Ravi Pratap <ravi@ximian.com>
28392 * Merge in changes and adjust code to tackle conflicts. Backed out my
28393 code in Assign::Resolve ;-)
28395 2001-09-08 Ravi Pratap <ravi@ximian.com>
28397 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
28398 instead Report.Error and also pass in the location.
28399 (CSharpParser::Lexer): New readonly property to return the reference
28400 to the Tokenizer object.
28401 (declare_local_variables): Use Report.Error with location instead of plain
28405 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
28406 (Operator.CheckBinaryOperator): Ditto.
28408 * cs-parser.jay (operator_declarator): Update accordingly.
28410 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
28411 (CheckBinaryOperator): Same here.
28413 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
28414 on the name without any prefixes of namespace names etc. This is because we
28415 already might have something already fully qualified like
28416 'System.Console.WriteLine'
28418 * assign.cs (Resolve): Begin implementation. Stuck ;-)
28420 2001-09-07 Ravi Pratap <ravi@ximian.com>
28422 * cs-tokenizer.cs (location): Return a string which also contains
28425 * expression.cs (ElementAccess): New class for expressions of the
28426 type 'element access.'
28427 (BaseAccess): New class for expressions of the type 'base access.'
28428 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
28431 * cs-parser.jay (element_access): Implement action.
28432 (base_access): Implement actions.
28433 (checked_expression, unchecked_expression): Implement.
28435 * cs-parser.jay (local_variable_type): Correct and implement.
28436 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
28438 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
28440 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
28441 name and the specifiers.
28443 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
28445 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
28446 making them all public ;-)
28448 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
28451 2001-09-07 Miguel de Icaza <miguel@ximian.com>
28453 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
28455 (FieldExpr, PropertyExprs): New resolved expressions.
28456 (SimpleName::MemberStaticCheck): Perform static checks for access
28457 to non-static fields on static methods. Maybe this should be
28458 generalized for MemberAccesses.
28459 (SimpleName::ResolveSimpleName): More work on simple name
28462 * cs-parser.jay (primary_expression/qualified_identifier): track
28463 the parameter index.
28465 * codegen.cs (CodeGen::Save): Catch save exception, report error.
28466 (EmitContext::EmitBoolExpression): Chain to expression generation
28467 instead of temporary hack.
28468 (::EmitStatementExpression): Put generic expression code generation.
28470 * assign.cs (Assign::Emit): Implement variable assignments to
28471 local variables, parameters and fields.
28473 2001-09-06 Miguel de Icaza <miguel@ximian.com>
28475 * statement.cs (Block::GetVariableInfo): New method, returns the
28476 VariableInfo for a variable name in a block.
28477 (Block::GetVariableType): Implement in terms of GetVariableInfo
28479 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
28480 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
28482 2001-09-06 Ravi Pratap <ravi@ximian.com>
28484 * cs-parser.jay (operator_declaration): Continue on my quest : update
28485 to take attributes argument.
28486 (event_declaration): Ditto.
28487 (enum_declaration): Ditto.
28488 (indexer_declaration): Ditto.
28490 * class.cs (Operator::Operator): Update constructor accordingly.
28491 (Event::Event): Ditto.
28493 * delegate.cs (Delegate::Delegate): Same here.
28495 * enum.cs (Enum::Enum): Same here.
28497 2001-09-05 Ravi Pratap <ravi@ximian.com>
28499 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
28501 * ../tests/cs0658.cs : New file to demonstrate error 0658.
28503 * attribute.cs (Attributes): New class to encapsulate all attributes which were
28504 being passed around as an arraylist.
28505 (Attributes::AddAttribute): Method to add attribute sections.
28507 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
28508 (struct_declaration): Update accordingly.
28509 (constant_declaration): Update.
28510 (field_declaration): Update.
28511 (method_header): Update.
28512 (fixed_parameter): Update.
28513 (parameter_array): Ditto.
28514 (property_declaration): Ditto.
28515 (destructor_declaration): Ditto.
28517 * class.cs (Struct::Struct): Update constructors accordingly.
28518 (Class::Class): Ditto.
28519 (Field::Field): Ditto.
28520 (Method::Method): Ditto.
28521 (Property::Property): Ditto.
28522 (TypeContainer::OptAttribute): update property's return type.
28524 * interface.cs (Interface.opt_attributes): New member.
28525 (Interface::Interface): Update to take the extra Attributes argument.
28527 * parameter.cs (Parameter::Parameter): Ditto.
28529 * constant.cs (Constant::Constant): Ditto.
28531 * interface.cs (InterfaceMemberBase): New OptAttributes field.
28532 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
28533 the attributes as a parameter.
28534 (InterfaceProperty): Update constructor call.
28535 (InterfaceEvent): Ditto.
28536 (InterfaceMethod): Ditto.
28537 (InterfaceIndexer): Ditto.
28539 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
28540 pass the attributes too.
28541 (interface_event_declaration): Ditto.
28542 (interface_property_declaration): Ditto.
28543 (interface_method_declaration): Ditto.
28544 (interface_declaration): Ditto.
28546 2001-09-05 Miguel de Icaza <miguel@ximian.com>
28548 * class.cs (Method::Define): Track the "static Main" definition to
28549 create an entry point.
28551 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
28552 EntryPoint if we find it.
28554 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
28555 (EmitContext::ig): Make this variable public.
28557 * driver.cs: Make the default output file be the first file name
28558 with the .exe extension.
28560 Detect empty compilations
28562 Handle various kinds of output targets. Handle --target and
28563 rename -t to --dumper.
28565 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
28566 methods inherited from Expression return now an Expression. This
28567 will is used during the tree rewriting as we resolve them during
28570 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
28571 the spec. Missing entirely is the information about
28572 accessability of elements of it.
28574 (Expression::ExprClassFromMemberInfo): New constructor for
28575 Expressions that creates a fully initialized Expression based on
28576 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
28579 (Invocation::Resolve): Begin implementing resolution of invocations.
28581 * literal.cs (StringLiteral): Implement Emit.
28583 2001-09-05 Ravi Pratap <ravi@ximian.com>
28585 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
28588 2001-09-04 Ravi Pratap <ravi@ximian.com>
28590 * cs-parser.jay (attribute_arguments): Implement actions.
28591 (attribute): Fix bug in production. Implement action.
28592 (attribute_list): Implement.
28593 (attribute_target): Implement.
28594 (attribute_target_specifier, opt_target_specifier): Implement
28595 (CheckAttributeTarget): New method to check if the attribute target
28597 (attribute_section): Implement.
28598 (opt_attributes): Implement.
28600 * attribute.cs : New file to handle attributes.
28601 (Attribute): Class to hold attribute info.
28603 * cs-parser.jay (opt_attribute_target_specifier): Remove production
28604 (attribute_section): Modify production to use 2 different rules to
28605 achieve the same thing. 1 s/r conflict down !
28606 Clean out commented, useless, non-reducing dimension_separator rules.
28608 * class.cs (TypeContainer.attributes): New member to hold list
28609 of attributes for a type.
28610 (Struct::Struct): Modify to take one more argument, the attribute list.
28611 (Class::Class): Ditto.
28612 (Field::Field): Ditto.
28613 (Method::Method): Ditto.
28614 (Property::Property): Ditto.
28616 * cs-parser.jay (struct_declaration): Update constructor call to
28617 pass in the attributes too.
28618 (class_declaration): Ditto.
28619 (constant_declaration): Ditto.
28620 (field_declaration): Ditto.
28621 (method_header): Ditto.
28622 (fixed_parameter): Ditto.
28623 (parameter_array): Ditto.
28624 (property_declaration): Ditto.
28626 * constant.cs (Constant::Constant): Update constructor similarly.
28627 Use System.Collections.
28629 * parameter.cs (Parameter::Parameter): Update as above.
28631 2001-09-02 Ravi Pratap <ravi@ximian.com>
28633 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
28634 (TypeContainer.delegates): New member to hold list of delegates.
28636 * cs-parser.jay (delegate_declaration): Implement the action correctly
28637 this time as I seem to be on crack ;-)
28639 2001-09-02 Miguel de Icaza <miguel@ximian.com>
28641 * rootcontext.cs (RootContext::IsNamespace): new function, used to
28642 tell whether an identifier represents a namespace.
28644 * expression.cs (NamespaceExpr): A namespace expression, used only
28645 temporarly during expression resolution.
28646 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
28647 utility functions to resolve names on expressions.
28649 2001-09-01 Miguel de Icaza <miguel@ximian.com>
28651 * codegen.cs: Add hook for StatementExpressions.
28653 * class.cs: Fix inverted test for static flag in methods.
28655 2001-09-02 Ravi Pratap <ravi@ximian.com>
28657 * class.cs (Operator::CheckUnaryOperator): Correct error number used
28658 to make it coincide with MS' number.
28659 (Operator::CheckBinaryOperator): Ditto.
28661 * ../errors/errors.txt : Remove error numbers added earlier.
28663 * ../errors/cs1019.cs : Test case for error # 1019
28665 * ../errros/cs1020.cs : Test case for error # 1020
28667 * cs-parser.jay : Clean out commented cruft.
28668 (dimension_separators, dimension_separator): Comment out. Ostensibly not
28669 used anywhere - non-reducing rule.
28670 (namespace_declarations): Non-reducing rule - comment out.
28672 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
28673 with TypeContainer::AddEnum.
28675 * delegate.cs : New file for delegate handling classes.
28676 (Delegate): Class for declaring delegates.
28678 * makefile : Update.
28680 * cs-parser.jay (delegate_declaration): Implement.
28682 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
28684 * class.cs (Event::Define): Implement.
28685 (Event.EventBuilder): New member.
28687 * class.cs (TypeContainer::Populate): Update to define all enums and events
28689 (Events): New property for the events arraylist we hold. Shouldn't we move to using
28690 readonly fields for all these cases ?
28692 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28694 * class.cs (Property): Revamp to use the convention of making fields readonly.
28695 Accordingly modify code elsewhere.
28697 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
28698 the Define method of the Property class.
28700 * class.cs : Clean up applied patch and update references to variables etc. Fix
28702 (TypeContainer::Populate): Update to define all the properties we have. Also
28703 define all enumerations.
28705 * enum.cs (Define): Implement.
28707 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28709 * cs-parser.jay (overloadable_operator): The semantic value is an
28710 enum of the Operator class.
28711 (operator_declarator): Implement actions.
28712 (operator_declaration): Implement.
28714 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
28715 validity of definitions.
28716 (Operator::CheckBinaryOperator): Static method to check for binary operators
28717 (TypeContainer::AddOperator): New method to add an operator to a type.
28719 * cs-parser.jay (indexer_declaration): Added line to actually call the
28720 AddIndexer method so it gets added ;-)
28722 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
28723 already taken care of by the MS compiler ?
28725 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28727 * class.cs (Operator): New class for operator declarations.
28728 (Operator::OpType): Enum for the various operators.
28730 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28732 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
28733 ostensibly handle this in semantic analysis.
28735 * cs-parser.jay (general_catch_clause): Comment out
28736 (specific_catch_clauses, specific_catch_clause): Ditto.
28737 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
28738 (catch_args, opt_catch_args): New productions.
28739 (catch_clause): Rewrite to use the new productions above
28740 (catch_clauses): Modify accordingly.
28741 (opt_catch_clauses): New production to use in try_statement
28742 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
28743 and re-write the code in the actions to extract the specific and
28744 general catch clauses by being a little smart ;-)
28746 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
28747 Hooray, try and catch statements parse fine !
28749 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28751 * statement.cs (Block::GetVariableType): Fix logic to extract the type
28752 string from the hashtable of variables.
28754 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
28755 I end up making that mistake ;-)
28756 (catch_clauses): Fixed gross error which made Key and Value of the
28757 DictionaryEntry the same : $1 !!
28759 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28761 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
28763 * cs-parser.jay (event_declaration): Correct to remove the semicolon
28764 when the add and remove accessors are specified.
28766 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28768 * cs-parser.jay (IndexerDeclaration): New helper class to hold
28769 information about indexer_declarator.
28770 (indexer_declarator): Implement actions.
28771 (parsing_indexer): New local boolean used to keep track of whether
28772 we are parsing indexers or properties. This is necessary because
28773 implicit_parameters come into picture even for the get accessor in the
28774 case of an indexer.
28775 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
28777 * class.cs (Indexer): New class for indexer declarations.
28778 (TypeContainer::AddIndexer): New method to add an indexer to a type.
28779 (TypeContainer::indexers): New member to hold list of indexers for the
28782 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28784 * cs-parser.jay (add_accessor_declaration): Implement action.
28785 (remove_accessor_declaration): Implement action.
28786 (event_accessors_declaration): Implement
28787 (variable_declarators): swap statements for first rule - trivial.
28789 * class.cs (Event): New class to hold information about event
28791 (TypeContainer::AddEvent): New method to add an event to a type
28792 (TypeContainer::events): New member to hold list of events.
28794 * cs-parser.jay (event_declaration): Implement actions.
28796 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28798 * cs-parser.jay (dim_separators): Implement. Make it a string
28799 concatenating all the commas together, just as they appear.
28800 (opt_dim_separators): Modify accordingly
28801 (rank_specifiers): Update accordingly. Basically do the same
28802 thing - instead, collect the brackets here.
28803 (opt_rank_sepcifiers): Modify accordingly.
28804 (array_type): Modify to actually return the complete type string
28805 instead of ignoring the rank_specifiers.
28806 (expression_list): Implement to collect the expressions
28807 (variable_initializer): Implement. We make it a list of expressions
28808 essentially so that we can handle the array_initializer case neatly too.
28809 (variable_initializer_list): Implement.
28810 (array_initializer): Make it a list of variable_initializers
28811 (opt_array_initializer): Modify accordingly.
28813 * expression.cs (New::NType): Add enumeration to help us
28814 keep track of whether we have an object/delegate creation
28815 or an array creation.
28816 (New:NewType, New::Rank, New::Indices, New::Initializers): New
28817 members to hold data about array creation.
28818 (New:New): Modify to update NewType
28819 (New:New): New Overloaded contructor for the array creation
28822 * cs-parser.jay (array_creation_expression): Implement to call
28823 the overloaded New constructor.
28825 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
28827 * class.cs (TypeContainer::Constructors): Return member
28828 constructors instead of returning null.
28830 2001-08-26 Miguel de Icaza <miguel@ximian.com>
28832 * typemanager.cs (InitCoreTypes): Initialize the various core
28833 types after we have populated the type manager with the user
28834 defined types (this distinction will be important later while
28835 compiling corlib.dll)
28837 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
28838 on Expression Classification. Now all expressions have a method
28839 `Resolve' and a method `Emit'.
28841 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
28842 generation from working. Also add some temporary debugging
28845 2001-08-24 Miguel de Icaza <miguel@ximian.com>
28847 * codegen.cs: Lots of code generation pieces. This is only the
28848 beginning, will continue tomorrow with more touches of polish. We
28849 handle the fundamentals of if, while, do, for, return. Others are
28850 trickier and I need to start working on invocations soon.
28852 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28855 * codegen.cs (EmitContext): New struct, used during code
28856 emission to keep a context. Most of the code generation will be
28859 * cs-parser.jay: Add embedded blocks to the list of statements of
28860 this block. So code generation proceeds in a top down fashion.
28862 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28864 * statement.cs: Add support for multiple child blocks.
28866 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28868 * codegen.cs (EmitCode): New function, will emit the code for a
28869 Block of code given a TypeContainer and its ILGenerator.
28871 * statement.cs (Block): Standard public readonly optimization.
28872 (Block::Block constructors): Link children.
28873 (Block::Child): Child Linker.
28874 (Block::EmitVariables): Emits IL variable declarations.
28876 * class.cs: Drop support for MethodGroups here, delay until
28878 (Method::): Applied the same simplification that I did before, and
28879 move from Properties to public readonly fields.
28880 (Method::ParameterTypes): Returns the parameter types for the
28881 function, and implements a cache that will be useful later when I
28882 do error checking and the semantic analysis on the methods is
28884 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28885 and made a method, optional argument tells whether this is a class
28886 or a structure to apply the `has-this' bit.
28887 (Method::GetCallingConvention): Implement, returns the calling
28889 (Method::Define): Defines the type, a second pass is performed
28890 later to populate the methods.
28892 (Constructor::ParameterTypes): implement a cache similar to the
28893 one on Method::ParameterTypes, useful later when we do semantic
28896 (TypeContainer::EmitMethod): New method. Emits methods.
28898 * expression.cs: Removed MethodGroup class from here.
28900 * parameter.cs (Parameters::GetCallingConvention): new method.
28902 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28904 * class.cs (TypeContainer::Populate): Drop RootContext from the
28907 (Constructor::CallingConvention): Returns the calling convention.
28908 (Constructor::ParameterTypes): Returns the constructor parameter
28911 (TypeContainer::AddConstructor): Keep track of default constructor
28912 and the default static constructor.
28914 (Constructor::) Another class that starts using `public readonly'
28915 instead of properties.
28917 (Constructor::IsDefault): Whether this is a default constructor.
28919 (Field::) use readonly public fields instead of properties also.
28921 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28922 track of static constructors; If none is used, turn on
28923 BeforeFieldInit in the TypeAttributes.
28925 * cs-parser.jay (opt_argument_list): now the return can be null
28926 for the cases where there are no arguments.
28928 (constructor_declarator): If there is no implicit `base' or
28929 `this', then invoke the default parent constructor.
28931 * modifiers.cs (MethodAttr): New static function maps a set of
28932 modifiers flags into a MethodAttributes enum
28933 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28934 MethodAttr, TypeAttr to represent the various mappings where the
28935 modifiers are used.
28936 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28938 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28940 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28943 * interface.cs (PopulateIndexer): Implemented the code generator
28944 for interface indexers.
28946 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28948 * interface.cs (InterfaceMemberBase): Now we track the new status
28951 (PopulateProperty): Implement property population. Woohoo! Got
28952 Methods and Properties going today.
28954 Removed all the properties for interfaces, and replaced them with
28955 `public readonly' fields.
28957 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28959 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28960 initialize their hashtables/arraylists only when they are needed
28961 instead of doing this always.
28963 * parameter.cs: Handle refs and out parameters.
28965 * cs-parser.jay: Use an ArrayList to construct the arguments
28966 instead of the ParameterCollection, and then cast that to a
28969 * parameter.cs: Drop the use of ParameterCollection and use
28970 instead arrays of Parameters.
28972 (GetParameterInfo): Use the Type, not the Name when resolving
28975 2001-08-13 Miguel de Icaza <miguel@ximian.com>
28977 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
28978 and instead use public readonly fields.
28980 * class.cs: Put back walking code for type containers.
28982 2001-08-11 Miguel de Icaza <miguel@ximian.com>
28984 * class.cs (MakeConstant): Code to define constants.
28986 * rootcontext.cs (LookupType): New function. Used to locate types
28989 2001-08-08 Miguel de Icaza <miguel@ximian.com>
28991 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
28992 this System.Reflection code is. Kudos to Microsoft
28994 * typemanager.cs: Implement a type cache and avoid loading all
28995 types at boot time. Wrap in LookupType the internals. This made
28996 the compiler so much faster. Wow. I rule!
28998 * driver.cs: Make sure we always load mscorlib first (for
28999 debugging purposes, nothing really important).
29001 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
29002 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
29004 * rootcontext.cs: Lookup types on their namespace; Lookup types
29005 on namespaces that have been imported using the `using' keyword.
29007 * class.cs (TypeContainer::TypeAttr): Virtualize.
29008 (Class::TypeAttr): Return attributes suitable for this bad boy.
29009 (Struct::TypeAttr): ditto.
29010 Handle nested classes.
29011 (TypeContainer::) Remove all the type visiting code, it is now
29012 replaced with the rootcontext.cs code
29014 * rootcontext.cs (GetClassBases): Added support for structs.
29016 2001-08-06 Miguel de Icaza <miguel@ximian.com>
29018 * interface.cs, statement.cs, class.cs, parameter.cs,
29019 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
29020 Drop use of TypeRefs, and use strings instead.
29022 2001-08-04 Miguel de Icaza <miguel@ximian.com>
29026 * class.cs (Struct::Struct): set the SEALED flags after
29027 checking the modifiers.
29028 (TypeContainer::TypeAttr): new property, returns the
29029 TypeAttributes for a class.
29031 * cs-parser.jay (type_list): Oops, list production was creating a
29032 new list of base types.
29034 * rootcontext.cs (StdLib): New property.
29035 (GetInterfaceTypeByName): returns an interface by type name, and
29036 encapsulates error handling here.
29037 (GetInterfaces): simplified.
29038 (ResolveTree): Encapsulated all the tree resolution here.
29039 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
29042 * driver.cs: Add support for --nostdlib, to avoid loading the
29043 default assemblies.
29044 (Main): Do not put tree resolution here.
29046 * rootcontext.cs: Beginning of the class resolution.
29048 2001-08-03 Miguel de Icaza <miguel@ximian.com>
29050 * rootcontext.cs: Provide better error reporting.
29052 * cs-parser.jay (interface_base): set our $$ to be interfaces.
29054 * rootcontext.cs (CreateInterface): Handle the case where there
29055 are no parent interfaces.
29057 (CloseTypes): Routine to flush types at the end.
29058 (CreateInterface): Track types.
29059 (GetInterfaces): Returns an array of Types from the list of
29060 defined interfaces.
29062 * typemanager.c (AddUserType): Mechanism to track user types (puts
29063 the type on the global type hash, and allows us to close it at the
29066 2001-08-02 Miguel de Icaza <miguel@ximian.com>
29068 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
29069 RecordInterface instead.
29071 * cs-parser.jay: Updated to reflect changes above.
29073 * decl.cs (Definition): Keep track of the TypeBuilder type that
29074 represents this type here. Not sure we will use it in the long
29075 run, but wont hurt for now.
29077 * driver.cs: Smaller changes to accomodate the new code.
29079 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
29082 * rootcontext.cs (CreateInterface): New method, used to create
29083 the System.TypeBuilder type for interfaces.
29084 (ResolveInterfaces): new entry point to resolve the interface
29086 (CodeGen): Property, used to keep track of the code generator.
29088 2001-07-26 Miguel de Icaza <miguel@ximian.com>
29090 * cs-parser.jay: Add a second production for delegate_declaration
29093 (enum_body): Put an opt_comma here instead of putting it on
29094 enum_body or enum_member_declarations so we can handle trailing
29095 commas on enumeration members. Gets rid of a shift/reduce.
29097 (type_list): Need a COMMA in the middle.
29099 (indexer_declaration): Tell tokenizer to recognize get/set
29101 * Remove old targets.
29103 * Re-add the parser target.
29105 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29107 * cs-parser.jay: Add precendence rules for a number of operators
29108 ot reduce the number of shift/reduce conflicts in the grammar.
29110 2001-07-17 Miguel de Icaza <miguel@ximian.com>
29112 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
29115 Get rid of old crufty code.
29117 * rootcontext.cs: Use this to keep track of the parsed
29118 representation and the defined types available to the program.
29120 * gen-treedump.cs: adjust for new convention.
29122 * type.cs: Split out the type manager, and the assembly builder
29125 * typemanager.cs: the type manager will live here now.
29127 * cil-codegen.cs: And the code generator here.
29129 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
29131 * makefile: Fixed up for easy making.
29133 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29135 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
29138 (unary_expression): Expand pre_increment_expression and
29139 post_decrement_expression to reduce a shift/reduce.
29141 2001-07-11 Simon Cozens
29143 * cs-tokenizer.cs: Hex numbers should begin with a 0.
29145 Improve allow_keyword_as_indent name.
29147 2001-06-19 Miguel de Icaza <miguel@ximian.com>
29149 * Adjustments for Beta2.
29151 2001-06-13 Miguel de Icaza <miguel@ximian.com>
29153 * decl.cs: Added `Define' abstract method.
29154 (InTransit): new property, used to catch recursive definitions.
29156 * interface.cs: Implement `Define'.
29158 * modifiers.cs: Map Modifiers.constants to
29159 System.Reflection.TypeAttribute flags.
29161 * class.cs: Keep track of types and user-defined types.
29162 (BuilderInit): New method for creating an assembly
29163 (ResolveType): New function to launch the resolution process, only
29164 used by interfaces for now.
29166 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
29167 that are inserted into the name space.
29169 2001-06-08 Miguel de Icaza <miguel@ximian.com>
29171 * ARGH. I have screwed up my tree so many times due to the use of
29172 rsync rather than using CVS. Going to fix this at once.
29174 * driver.cs: Objetify driver. Load assemblies, use assemblies to
29177 2001-06-07 Miguel de Icaza <miguel@ximian.com>
29179 * Experiment successful: Use System.Type rather that our own
29182 2001-05-25 Miguel de Icaza <miguel@ximian.com>
29184 * cs-parser.jay: Removed nsAliases from here.
29186 Use new namespaces, handle `using XXX;'
29188 * namespace.cs: Reimplemented namespace handling, use a recursive
29189 definition of the class. Now we can keep track of using clauses
29190 and catch invalid using clauses.
29192 2001-05-24 Miguel de Icaza <miguel@ximian.com>
29194 * gen-treedump.cs: Adapted for all the renaming.
29196 * expression.cs (Expression): this class now has a Type property
29197 which returns an expression Type.
29199 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
29200 `Type', as this has a different meaning now in the base
29202 2001-05-22 Miguel de Icaza <miguel@ximian.com>
29204 * interface.cs, class.cs: Removed from all the sources the
29205 references to signature computation, as we can not do method
29206 signature computation during the parsing time, as we are not
29207 trying to solve at that point distinguishing:
29211 void a (NS.Blah x) {}
29214 Which depending on the context might be valid or not, as we do not
29215 know if Blah is the same thing as NS.Blah at that point.
29217 * Redid everything so the code uses TypeRefs now instead of
29218 Types. TypeRefs are just temporary type placeholders, that need
29219 to be resolved. They initially have a pointer to a string and the
29220 current scope in which they are used. This is used later by the
29221 compiler to resolve the reference to an actual Type.
29223 * DeclSpace is no longer a CIR.Type, and neither are
29224 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
29225 are all DeclSpaces, but no Types.
29227 * type.cs (TypeRefManager): This implements the TypeRef manager,
29228 which keeps track of all the types that need to be resolved after
29229 the parsing has finished.
29231 2001-05-13 Miguel de Icaza <miguel@ximian.com>
29233 * ARGH. We are going to have to store `foreach' as a class rather
29234 than resolving it, as we need to verify error 1579 after name
29235 resolution. *OR* we could keep a flag that says `This request to
29236 IEnumerator comes from a foreach statement' which we can then use
29237 to generate the error.
29239 2001-05-10 Miguel de Icaza <miguel@ximian.com>
29241 * class.cs (TypeContainer.AddMethod): we now add methods to the
29242 MethodGroup instead of the method hashtable.
29244 * expression.cs: Add MethodGroup abstraction, which gets us one
29245 step closer to the specification in the way we handle method
29248 * cs-parser.jay (primary_expression): qualified_identifier now
29249 tried to match up an identifier to a local variable reference or
29250 to a parameter reference.
29252 current_local_parameters is now a parser global variable that
29253 points to the current parameters for the block, used during name
29256 (property_declaration): Now creates an implicit `value' argument to
29259 2001-05-09 Miguel de Icaza <miguel@ximian.com>
29261 * parameter.cs: Do not use `param' arguments as part of the
29262 signature, per the spec.
29264 2001-05-08 Miguel de Icaza <miguel@ximian.com>
29266 * decl.cs: Base class for classes, structs and interfaces. This
29267 is the "Declaration Space"
29269 * cs-parser.jay: Use CheckDef for checking declaration errors
29270 instead of having one on each function.
29272 * class.cs: Factor out some code for handling error handling in
29273 accordance to the "Declarations" section in the "Basic Concepts"
29274 chapter in the ECMA C# spec.
29276 * interface.cs: Make all interface member classes derive from
29277 InterfaceMemberBase.
29279 2001-05-07 Miguel de Icaza <miguel@ximian.com>
29281 * Many things: all interfaces are parsed and generated in
29282 gen-treedump. Support for member variables, constructors,
29283 destructors, properties, constants is there.
29285 Beginning of the IL backend, but very little done, just there for
29288 2001-04-29 Miguel de Icaza <miguel@ximian.com>
29290 * cs-parser.jay: Fix labeled statement.
29292 * cs-tokenizer.cs (escape): Escape " and ' always.
29293 ref_line, ref_name: keep track of the line/filename as instructed
29294 by #line by the compiler.
29297 2001-04-27 Miguel de Icaza <miguel@ximian.com>
29299 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
29300 to match the values in System.CodeDOM.
29302 Divid renamed to Divide.
29304 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
29306 (Statements.set): remove.
29308 * System.CodeDOM/CodeCatchClause.cs: always have a valid
29311 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
29312 falseStatements always have valid values.
29314 * cs-parser.jay: Use System.CodeDOM now.