1 2008-01-25 Martin Baulig <martin@ximian.com>
4 (NamespaceEntry.SymbolFileID): Make this work again after
5 MemberName.ToString() is gone.
7 2008-01-25 Marek Safar <marek.safar@gmail.com>
9 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
12 2008-01-25 Marek Safar <marek.safar@gmail.com>
14 * generic.cs: Use full implicit conversion for type inference fixing.
16 2008-01-24 Marek Safar <marek.safar@gmail.com>
18 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
19 Fixed user operator conversions.
21 2008-01-24 Marek Safar <marek.safar@gmail.com>
23 * generic.cs: Do nullable type to null comparison optimization during
26 2008-01-24 Marek Safar <marek.safar@gmail.com>
29 * generic.cs: Enabled l-value resolve on nullable expressions.
31 2008-01-24 Marek Safar <marek.safar@gmail.com>
34 * class.cs: Ingore static ctors with parameters for any further checks.
36 2008-01-24 Marek Safar <marek.safar@gmail.com>
39 * namespace.cs: Removed redundant check.
41 2008-01-24 Marek Safar <marek.safar@gmail.com>
44 * expression.cs: ElementInitializers can be resolved only once.
46 2008-01-24 Marek Safar <marek.safar@gmail.com>
48 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
49 Condition expressions.
51 2008-01-23 Marek Safar <marek.safar@gmail.com>
53 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
55 2008-01-22 Marek Safar <marek.safar@gmail.com>
57 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
60 * generic.cs: Implemented coalesce expression.
62 2008-01-22 Marek Safar <marek.safar@gmail.com>
65 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
66 expression tree type inference.
68 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
71 * expression.cs (Binary.IsUnsignedType): Fix typo.
73 2008-01-22 Marek Safar <marek.safar@gmail.com>
75 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
77 2008-01-22 Marek Safar <marek.safar@gmail.com>
80 * ecore.cs, expression.cs: Wider range of extension method supported
83 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
85 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
86 AssemblyBuilder to operate in compiler context. Fixes mcs part of
89 2008-01-22 Marek Safar <marek.safar@gmail.com>
92 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
94 2008-01-22 Miguel de Icaza <miguel@novell.com>
96 * expression.cs (CreateExpressionTree): Add support for or and
97 logical or, and indent following the coding conventions.
99 * typemanager.cs (LinqExpression): renamed from
100 ExpressionTreeManager, for a shorter name.
102 Use TypeManager.CoreLookupType to lookup types from our core
103 assemblies and turn those into "Type" variables.
105 Consumers that previously used "Namespace" and "Type" from this
106 class should instead use the TypeExpression which is a type that
107 is fully resolved (without involving the regular C# resolution
110 This typically looks like this:
112 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
113 new MemberAccess (texpr, name, type_arguments, loc)
115 This avoids the problem in: #355178
117 2008-01-21 Marek Safar <marek.safar@gmail.com>
119 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
120 feature in parser only as we do in other cases.
122 2008-01-21 Marek Safar <marek.safar@gmail.com>
124 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
125 typemanager.cs: A refactoring of params arguments to reuse existing
126 expressions (params -> array initializer) to emit params argument instead
127 of specialized handling.
128 It was required by expression tree implementation and it has other benefits
129 as well, we now apply same optimization for params arguments as we do for
132 2008-01-18 Marek Safar <marek.safar@gmail.com>
134 A fix for bug #353526
135 * generic.cs: A type inference of params arguments may not required any
136 temporary array creation.
138 2008-01-18 Marek Safar <marek.safar@gmail.com>
140 A fix for bug #353534
141 * generic.cs, ecore.cs, expression.cs: A method group type inference is
142 supported for delegates only.
144 2008-01-18 Marek Safar <marek.safar@gmail.com>
146 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
147 type for more than 1 candidates.
149 2008-01-18 Marek Safar <marek.safar@gmail.com>
151 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
154 2008-01-16 Marek Safar <marek.safar@gmail.com>
156 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
157 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
158 operator) expressions.
160 2008-01-16 Zoltan Varga <vargaz@gmail.com>
162 * statement.cs: Avoid declaring an IL variable for this_variable since it is
163 not accessed from the generated IL.
165 2008-01-14 Marek Safar <marek.safar@gmail.com>
167 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
168 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
169 statement.cs: The first expression tree implementation drop, mostly
172 2008-01-14 Marek Safar <marek.safar@gmail.com>
174 * ecore.cs (IsNestedChild): Refactored.
176 2008-01-11 Marek Safar <marek.safar@gmail.com>
178 * lambda.cs: Don't use a cast on unknown expression statement.
180 2008-01-10 Geoff Norton <gnorton@novell.com>
182 * cs-tokenizer.cs: One more token to distinguish between method and lambda
185 2008-01-09 Marek Safar <marek.safar@gmail.com>
187 * doc.cs: Report better /doc crash details.
189 2008-01-09 Marek Safar <marek.safar@gmail.com>
191 A fix for bug #352536
192 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
194 2008-01-08 Marek Safar <marek.safar@gmail.com>
196 A fix for bug #352287
197 * ecore.cs, expression.cs: Do `this' access checking in all member access
200 2008-01-08 Marek Safar <marek.safar@gmail.com>
202 * rootcontext.cs, driver.cs: Switch to linq mode by default.
204 * report.cs: Reset message stacks.
206 2008-01-08 Marek Safar <marek.safar@gmail.com>
208 * generic.cs (InferInPhases): Correctly calculate params position.
210 2008-01-08 Marek Safar <marek.safar@gmail.com>
212 * cs-tokenizer.cs: No need to parse full string when parsing lambda
215 2008-01-07 Marek Safar <marek.safar@gmail.com>
217 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
219 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
221 * driver.cs: Updated --help option.
223 2008-01-07 Marek Safar <marek.safar@gmail.com>
225 * generic.cs (InferParamsTypeArguments): Removed.
226 (InferInPhases): Add params type inference.
227 (LowerBoundInference): Fixed scoring mechanism.
229 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
231 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
233 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
234 byte array for unsigned "baked" assemblies.
236 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
238 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
239 array for assemblies that are not strongnamed.
241 2008-01-04 Marek Safar <marek.safar@gmail.com>
243 A fix for bug #351481
244 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
245 declaring type for nested generic types.
247 2008-01-04 Marek Safar <marek.safar@gmail.com>
249 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
252 2008-01-03 Marek Safar <marek.safar@gmail.com>
254 A fix for bug #351047
255 * expression.cs (Binary.ResolveOperator): Allow equality operators between
256 null and structs only when equality and inequality operators are defined
257 either as an user-operators or predefined operators.
259 2008-01-03 Marek Safar <marek.safar@gmail.com>
261 A fix for bug #351047
262 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
264 2008-01-03 Marek Safar <marek.safar@gmail.com>
266 A fix for bug #351257
267 * cs-tokenizer.cs: Advance line number for '\r' correctly.
269 2008-01-03 Marek Safar <marek.safar@gmail.com>
271 A fix for bug #351157
272 * class.cs (Using): Fixed yet another broken cloning.
274 (Block): Put back more sensible default value for statements.
276 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
278 * codegen.cs: Allow AssemblyVersion with only major version component.
281 2007-12-29 Marek Safar <marek.safar@gmail.com>
283 A fix for bug #324654
284 * class.cs: Use FullName property as member name.
286 2007-12-28 Marek Safar <marek.safar@gmail.com>
288 A fix for bug #342117
289 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
290 constructor constraint.
292 2007-12-28 Marek Safar <marek.safar@gmail.com>
294 A fix for bug #338273
295 * class.cs (ProbertyBase): Access modifier checks are required for overrides
298 2007-12-28 Marek Safar <marek.safar@gmail.com>
300 A fix for bug #350839
301 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
303 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
305 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
308 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
310 * statement.cs: Changed some Hashtables to use HybridDictionaries
311 instead. It was observed that some HashTables only contained a few
312 items in the vast majority of cases. Since HybridDictionary is
313 more efficient on small sets (<10 elements), "known_variables"
314 from class ExplicitBlock as well as "labels" and "constants " from
315 class Block were changed to HybridDictionaries.
317 Atsai results: (56216kb->54987kb)
319 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
322 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
324 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
327 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
329 * expression.cs: foreach loop to for loop, saved on allocation of
330 enumerator (59333kb->59141kb)
332 * statement.cs. Changed foreach loops to for loops, saved on
333 allocation of enumerator (59141kb->59006kb)
335 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
336 when constructed with no specified capacity. This was causing a
337 few ArrayLists to allocate more memory than they would potentially
338 need in the Block class and MemberCache class. Setting the
339 ArrayLists to construct with a capacity of 1 saves some
340 memory. (56216kb->55585kb)
342 2007-12-27 Marek Safar <marek.safar@gmail.com>
344 A fix for bug #347189 (2nd issue)
345 * expression.cs (MemberAccess): Nested type can be found in base non-generic
348 2007-12-27 Miguel de Icaza <miguel@novell.com>
350 * report.cs: Do not use colors if stdout and stderr are not a
353 2007-12-27 Marek Safar <marek.safar@gmail.com>
355 A fix for bug #346998
356 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
359 2007-12-27 Marek Safar <marek.safar@gmail.com>
361 A fix for bug #343465
362 * class.cs: Explicit method name for nested types uses dots only.
364 2007-12-27 Marek Safar <marek.safar@gmail.com>
366 A fix for bug #343707
367 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
369 2007-12-27 Marek Safar <marek.safar@gmail.com>
371 * ecore.cs: Report type inference errors only when arguments count matches
374 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
376 * expression.cs, report.cs: New warning.
378 * typemanager.cs: Catch anonymous method type too.
380 2007-12-23 Marek Safar <marek.safar@gmail.com>
382 A fix for bug #346379
383 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
385 2007-12-23 Marek Safar <marek.safar@gmail.com>
387 A fix for bug #347359
388 * expression.cs (Invocation): Don't resolve already resolved expression.
390 2007-12-23 Marek Safar <marek.safar@gmail.com>
392 A fix for bug #347189
393 * class.cs (FixedField): Use non-dependent code only in the define phase.
395 2007-12-23 Marek Safar <marek.safar@gmail.com>
397 A fix for bug #348076
398 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
400 2007-12-22 Marek Safar <marek.safar@gmail.com>
402 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
403 discovered extension methods.
405 2007-12-22 Marek Safar <marek.safar@gmail.com>
407 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
410 2007-12-21 Miguel de Icaza <miguel@novell.com>
412 * report.cs (ErrorMessage): Add support for using colors on
413 terminals that support it.
415 2007-12-21 Marek Safar <marek.safar@gmail.com>
417 * ecore.cs: Use information about expanded params for error reporting.
419 2007-12-21 Marek Safar <marek.safar@gmail.com>
421 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
422 and logic for params overloads.
424 2007-12-15 Miguel de Icaza <miguel@novell.com>
426 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
427 as this is also created from the parser. Fixes #349034
429 2007-12-12 Miguel de Icaza <miguel@novell.com>
431 * statement.cs (Throw.CloneTo): it is valid to have empty
432 expressions for throw.
434 2007-12-03 Marek Safar <marek.safar@gmail.com>
436 * cs-parser.jay: Set delegate constraint parsing region correctly.
438 2007-12-03 Marek Safar <marek.safar@gmail.com>
440 A fix for bug #345467
441 * typemanager.cs (IsEqual): Compare generic parameters position only.
443 2007-11-28 Marek Safar <marek.safar@gmail.com>
445 * expression.cs (BaseAccess): Type arguments can be null.
447 2007-11-27 Raja R Harinath <harinath@gmail.com>
449 * statement.cs (Block.Resolve): Ensure flow-branching tree is
450 consistent even when an error has occured.
451 (Switch.Resolve): Likewise.
453 2007-11-22 Marek Safar <marek.safar@gmail.com>
455 A fix for bug #334505
456 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
459 2007-11-22 Marek Safar <marek.safar@gmail.com>
461 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
462 refactorings required to resolve extension methods correctly when mixing
463 generics and non-generics members.
465 2007-11-20 Marek Safar <marek.safar@gmail.com>
467 A fix for bug #342584
468 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
471 2007-11-19 Marek Safar <marek.safar@gmail.com>
473 A fix for bug #342512
474 * delegate.cs: Use delegate argument expression when is available. Don't
475 emit virtual call when class is sealed.
477 2007-11-16 Marek Safar <marek.safar@gmail.com>
479 A fix for bug #325423
480 * assign.cs (FieldInitializer): Use resolved expression for emit.
482 * class.cs: Print less confusing error message.
484 2007-11-16 Marek Safar <marek.safar@gmail.com>
486 * cs-tokenizer.cs: Removed GMCS ifdefs.
488 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
491 * cs-parser.jay: Disabled nullable check.
493 * generic-mcs: Copied more generic stuff.
495 2007-11-16 Marek Safar <marek.safar@gmail.com>
497 * gcs-parser.jay: Merged to cs-parser.jay.
499 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
500 * *.csproj, *.sources: Updated to use only jay parser file.
502 2007-11-16 Marek Safar <marek.safar@gmail.com>
504 * gcs-parser.jay: Added nullable and default expression feature checks.
506 2007-11-16 Marek Safar <marek.safar@gmail.com>
508 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
509 it fixes many TODOs and hidden bugs.
511 * expression: Removed duplicate error check.
513 2007-11-15 Marek Safar <marek.safar@gmail.com>
515 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
516 implicitly type local variable only when it is used in a declaration.
518 2007-11-15 Marek Safar <marek.safar@gmail.com>
520 * attribute.cs: Use CS0612 for empty strings.
522 2007-11-14 Marek Safar <marek.safar@gmail.com>
524 * lambda.cs, statement.cs: Contextual return may act as a statement.
526 2007-11-14 Marek Safar <marek.safar@gmail.com>
528 A fix for a regression cause by #324222
529 * class.cs: Don't report unused even when it implements an interface.
531 2007-11-13 Marek Safar <marek.safar@gmail.com>
533 A fix for bug #341205
534 * ecore.cs, expression.cs: Method group expression cannot do static
535 method access with an instance reference check before overloading takes
538 2007-11-13 Marek Safar <marek.safar@gmail.com>
540 A fix for bug #325359
541 * class.cs: Use predictable name for automatically generated property.
543 2007-11-12 Marek Safar <marek.safar@gmail.com>
545 A fix for bug #324996
546 * expression.cs (Is): Handle case where D is nullable and T is not
549 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
551 2007-11-12 Marek Safar <marek.safar@gmail.com>
553 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
554 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
555 Flush small error reporting changes.
557 2007-11-09 Marek Safar <marek.safar@gmail.com>
559 A fix for bug #324996
560 * expression.cs: Rewrote Is expression implementation to work with
561 generics, nullable types, anonymous method. A const result expression
562 uses existing infrastructure instead of custom not fully-featured one.
564 2007-11-08 Marek Safar <marek.safar@gmail.com>
566 A fix for bug #340202
567 * class.cs: Consider generics for volatile field.
569 2007-11-08 Marek Safar <marek.safar@gmail.com>
571 A fix for bug #335594
572 * expression.cs: Use conversion rules when handling string addition.
574 2007-11-07 Marek Safar <marek.safar@gmail.com>
576 A fix for bug #336651
577 * expression.cs: Fixed a crash when probing is on.
579 2007-11-07 Marek Safar <marek.safar@gmail.com>
581 A fix for bug #324242
582 * covert.cs: Added a conversion from any nullable-type with an
583 underlying enum-type to the type System.Enum.
585 2007-11-07 Marek Safar <marek.safar@gmail.com>
587 A fix for bug #324222
588 * class.cs: Report all non-used event fields.
590 2007-11-07 Marek Safar <marek.safar@gmail.com>
592 A fix for bug #325161
593 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
594 qualifier for generic types.
596 2007-11-07 Marek Safar <marek.safar@gmail.com>
598 A fix for bug #322971
599 * expression.cs, ecore.cs: Added intermediate result value check for
602 2007-11-07 Marek Safar <marek.safar@gmail.com>
604 A fix for bug #324754
605 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
606 when it was requested.
608 2007-11-07 Marek Safar <marek.safar@gmail.com>
610 A fix for bug #325101
611 * expression.cs: Do type not value comparison for `is' expression.
613 2007-11-07 Marek Safar <marek.safar@gmail.com>
615 A fix for bug #320236
616 * convert.cs: Don't apply user conversion on underlying target type.
618 2007-11-06 Marek Safar <marek.safar@gmail.com>
620 * expression.cs: Don't use unresolved expression for error reporting.
622 2007-11-06 Marek Safar <marek.safar@gmail.com>
624 A fix for bugs #337712, #324490
625 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
626 overloading resolution too.
628 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
629 the process consistent and more robust.
631 * expression.cs, linq.cs, report.cs: Update.
633 2007-11-02 Marek Safar <marek.safar@gmail.com>
635 A fix for bug #332909
636 * attribute.cs: Resolve attributes in correct context using error
639 * rootcontext.cs: Define Obsolete attribute members as core members.
641 2007-11-02 Marek Safar <marek.safar@gmail.com>
643 * statement.cs: Removed unused methods.
645 2007-10-31 Wade Berrier <wberrier@novell.com>
647 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
648 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
651 2007-10-31 Marek Safar <marek.safar@gmail.com>
653 A fix for bug #338102
654 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
655 methods registered as non-generics.
657 2007-10-31 Marek Safar <marek.safar@gmail.com>
659 A fix for bugs #337712, #324490
660 * delegate.cs: Delegate covariance and contravariance is not allowed for
663 2007-10-31 Marek Safar <marek.safar@gmail.com>
665 A fix for bug #337719
666 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
669 2007-10-30 Marek Safar <marek.safar@gmail.com>
671 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
673 2007-10-29 Marek Safar <marek.safar@gmail.com>
675 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
678 2007-10-29 Raja R Harinath <rharinath@novell.com>
680 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
682 2007-10-29 Marek Safar <marek.safar@gmail.com>
684 A fix for bug #334652
685 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
686 extension methods when we have not found the best candidate in normal
689 2007-10-27 Marek Safar <marek.safar@gmail.com>
691 * AssemblyInfo.cs: Keep up-to-date.
693 2007-10-27 Marek Safar <marek.safar@gmail.com>
695 * Makefile: Fixed generics compiler name.
697 2007-10-27 Marek Safar <marek.safar@gmail.com>
699 * lambda.test: removed, lambda parsing is done differently.
701 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
703 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
705 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
707 2007-10-27 Marek Safar <marek.safar@gmail.com>
709 * Makefile, *.sources : All C# compilers are in mcs folder.
711 * *.cs: Use existing 2_1 define for smcs.
713 2007-10-26 Marek Safar <marek.safar@gmail.com>
715 A fix for bug #335847
716 * assign.cs, expression.cs: Couple of changes to avoid creating a
717 temporary variable for each object initializer assignment statement. It
718 simplifies struct initialization too, otherwise two temporary variables
720 Implemented optimization of redundant default element initializers.
722 2007-10-25 Marek Safar <marek.safar@gmail.com>
724 A fix for bug #336766
725 * expression.cs (Class.CheckBase): Use generic name when method is
728 2007-10-25 Marek Safar <marek.safar@gmail.com>
730 A fix for bug #334737
731 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
732 variable and not variable argument for prepared copies.
734 2007-10-24 Marek Safar <marek.safar@gmail.com>
736 A fix for bug #325110
737 * class.cs, expression.cs, attribute.cs: Use open generic method when
738 checking conditional attribute.
740 2007-10-24 Marek Safar <marek.safar@gmail.com>
742 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
743 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
744 FeatureIsNotAvailable.
746 2007-10-24 Marek Safar <marek.safar@gmail.com>
748 ** C# 3.0 Partial methods
750 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
751 methods support. Because of member cache issue with generics only
752 non-generics partial methods are fully supported.
754 2007-10-23 Marek Safar <marek.safar@gmail.com>
756 * class.cs, decl.cs: Rewrote member overloads check to cope with
757 generics and to use member cache for member checking. It also improves
758 performance and fixes remaining overloads issues.
760 2007-10-20 Marek Safar <marek.safar@gmail.com>
762 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
763 roottypes.cs, typemanager.cs:
765 A member cache creation logic changed to add members immediately and
766 not rely on fallback. The member cache is now only prefered way
767 how to access and find type declaration members. It saves 5 MB of memory
768 during MWF compilation and makes code ready for more optimizations and
769 clean-ups, it's also a pre-requirement for partial methods.
771 2007-10-18 Raja R Harinath <harinath@gmail.com>
773 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
774 handling for generic parameters.
776 2007-10-15 Marek Safar <marek.safar@gmail.com>
778 * class.cs (FixedField): Removed redundant volatile check.
780 2007-10-15 Marek Safar <marek.safar@gmail.com>
782 * class.cs, decl.cs: Fixed overload members verification to do only one
783 check per possible collision.
785 2007-10-13 Marek Safar <marek.safar@gmail.com>
787 A fix for bug #325478
788 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
789 and create only one disposable flags container.
791 2007-10-12 Marek Safar <marek.safar@gmail.com>
793 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
794 * statement.cs (Fixed): Fixed variables cloning.
796 2007-10-12 Marek Safar <marek.safar@gmail.com>
798 A fix for bug #333342
799 * class.cs (EventField): Don't mark value type event as synchronized.
801 2007-10-12 Marek Safar <marek.safar@gmail.com>
803 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
804 inference to identify best candidate method correctly.
805 (ProperyExpr): A range variable is read only and cannot be modified.
807 2007-10-11 Marek Safar <marek.safar@gmail.com>
809 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
810 logic to identify best candidate method correctly.
812 2007-10-11 Marek Safar <marek.safar@gmail.com>
814 * location.cs (Equals, GetHashCode): Removed.
816 2007-10-11 Marek Safar <marek.safar@gmail.com>
818 * report.cs: Implemented message recorder. It is used mainly for lambda
819 expressions to capture otherwise swallowed error messages.
821 * anonymous.cs, lambda.cs.cs: Do full parameters check.
823 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
825 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
827 * expression.cs (MemberAccess): Always report lookup failure.
829 * location.cs: Implemented Equals, GetHashCode.
831 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
833 2007-10-10 Jb Evain <jbevain@novell.com>
835 * codegen.cs: re-enable assembly version check.
837 2007-10-09 Marek Safar <marek.safar@gmail.com>
839 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
842 * namespace.cs (UsingAlias): Do correct version check.
844 2007-10-08 Marek Safar <marek.safar@gmail.com>
846 * expresison.cs, ecore.cs: Issue extension method error message when
849 * rootcontext.cs: Added ISO_2 compiler mode option.
851 2007-10-08 Marek Safar <marek.safar@gmail.com>
853 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
856 2007-10-08 Marek Safar <marek.safar@gmail.com>
858 * attribute.cs (GetString, GetBoolean): Work with both literal and
861 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
862 Moved method overload specific methods to MethodGroupExpr.
864 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
865 it should be less memory consuming.
867 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
869 * codegen.cs: remove the assembly version check until the buildbot is
872 2007-10-07 Jb Evain <jbevain@novell.com>
874 * attribute.cs (Attribute.GetString): if the value
875 expression is a StringConstant, return its string value.
877 2007-10-07 Jb Evain <jbevain@novell.com>
879 * typemanager.cs: add `assembly_version_attribute_type`.
880 * codegen.cs: on attribute emission, check that the
881 AssemblyVersionAttribute doesn't overflow.
883 2007-10-05 Marek Safar <marek.safar@gmail.com>
885 A fix for bug #324677
886 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
887 parent container of a scope container with currently resolved one.
889 2007-10-05 Marek Safar <marek.safar@gmail.com>
891 A fix for bug #325534
892 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
895 2007-10-05 Marek Safar <marek.safar@gmail.com>
897 A fix for bug #327504
898 * class.cs (Operator.Define): Refactored implicit and explicit user
899 operator conversion rules.
901 2007-10-05 Marek Safar <marek.safar@gmail.com>
903 A fix for bug #327520
904 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
906 2007-10-04 Marek Safar <marek.safar@gmail.com>
908 A fix for bug #328022
909 * class.cs (MethodData.Define): Use correct method to check whether
910 a method implementents an accessor.
912 2007-10-04 Marek Safar <marek.safar@gmail.com>
914 A fix for bug #330069
915 * statement.cs (Fixed.Resolve): Read the first array element only when
916 an array is instantiated.
918 2007-10-04 Marek Safar <marek.safar@gmail.com>
920 * expression.cs, assign.cs, generics.cs: Print correct operator when
921 compound assignment is used.
923 2007-10-04 Marek Safar <marek.safar@gmail.com>
925 A fix for bug #325841
926 * expression.cs (ArrayAccess): Use full argument cloning only for
927 string compound concatenation.
929 2007-10-03 Marek Safar <marek.safar@gmail.com>
931 A fix for bug #328774
932 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
934 (PropertyExpr.EmitAssign): Fixed string concatenation compound
937 2007-10-03 Raja R Harinath <rharinath@novell.com>
940 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
941 Event accessibility checks here. Remove some bogus code that
942 accidently made GenericMethods work.
943 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
945 2007-09-25 Marek Safar <marek.safar@gmail.com>
947 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
949 * statement.cs (Block): Refactored AddVariable to allow error handling
952 * generic.cs: New stub.
954 2007-09-23 Marek Safar <marek.safar@gmail.com>
956 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
959 2007-09-17 Marek Safar <marek.safar@gmail.com>
961 * class.cs: Use partial container to record whether any partial part
962 contains static field initializer and therefore default contructor has
965 2007-09-14 Marek Safar <marek.safar@gmail.com>
967 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
968 mono-list when only one of two partial parts has defined accessibility
971 2007-09-14 Marek Safar <marek.safar@gmail.com>
975 * class.cs (TypeContainer): Set correct resolve context for all field
978 2007-09-13 Marek Safar <marek.safar@gmail.com>
980 * assign.cs: Fixed a crash when field is resolved twice with an error.
982 * codegen.cs: Changed InFieldInitializer to be flag.
984 * anonymous.cs, ecore.cs, expression.cs: Update after
985 IsInFieldInitializer rename.
987 * const.cs: Removed unused parameter.
989 * class.cs: Changed the way how we resolve and emit field initializers.
990 The field initilizers have to have access to contructor block to emit
991 compiler generated code.
993 2007-09-13 Marek Safar <marek.safar@gmail.com>
995 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
996 generics use TypeContainer instead.
998 2007-09-12 Marek Safar <marek.safar@gmail.com>
1000 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
1002 * lambda.cs (ResolveParameters): Use more powerful
1003 InflateGenericArgument.
1005 * parameters.cs: Better exception message.
1007 2007-09-10 Marek Safar <marek.safar@gmail.com>
1009 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
1010 correct expression block type.
1012 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
1014 * expression.cs (Invocation): Extracted method group resolve to
1017 2007-09-07 Marek Safar <marek.safar@gmail.com>
1019 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
1020 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
1022 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
1023 generic extension methods.
1025 2007-09-06 Marek Safar <marek.safar@gmail.com>
1027 A fix for bug #82676 (Do I get it right now?)
1028 * convert.cs (Binary.ResolveOperator): An interface is converted to the
1029 object before a standard conversion is applied.
1031 2007-09-06 Marek Safar <marek.safar@gmail.com>
1033 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
1036 2007-09-05 Marek Safar <marek.safar@gmail.com>
1038 A fix for bug #82676
1039 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
1040 non-generic interface types.
1042 2007-09-05 Marek Safar <marek.safar@gmail.com>
1044 A fix for bug #82690
1045 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
1047 2007-09-05 Marek Safar <marek.safar@gmail.com>
1049 A fix for bug #82571
1050 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
1051 modifier for container based methods.
1053 2007-09-05 Marek Safar <marek.safar@gmail.com>
1055 A fix for bug #82676
1056 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
1057 any interface-type T means to any of interface type T.
1059 2007-09-04 Marek Safar <marek.safar@gmail.com>
1061 * namespace.cs: We have 2 versions of System.Core assembly.
1063 2007-09-04 Marek Safar <marek.safar@gmail.com>
1065 A fix for bug #82652
1066 * class.cs (Class.GetClassBases): Compare types and not expressions.
1068 2007-09-04 Marek Safar <marek.safar@gmail.com>
1070 A fix for bug #82620
1071 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
1072 actually never worked before.
1073 (IndexerAccess): Emit prepared arguments before they are modified.
1075 2007-09-04 Marek Safar <marek.safar@gmail.com>
1077 A fix for bug #82563
1078 * assign.cs: Revert wrong fix.
1080 * expression.cs (VariableReference.EmitAssign): Handle ref reference
1082 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
1083 Instead of ldelema/stdind we have to use temporary variables to handle
1084 cases like String.Concat (params string[]).
1086 2007-08-31 Marek Safar <marek.safar@gmail.com>
1088 * class.cs: EmitAttributes to Emit rename.
1090 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
1092 (MemberCore.HasClsCompliantAttribute): Don't depend on
1093 GetClsCompliantAttributeValue execution.
1095 2007-08-31 Marek Safar <marek.safar@gmail.com>
1097 * anonymous.cs: Use shorter type prefix.
1099 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
1102 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
1103 variables when probing is on.
1105 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
1106 unresolved variables.
1107 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
1108 handle transparent identifiers.
1110 2007-08-26 Marek Safar <marek.safar@gmail.com>
1112 * attribute.cs (IsClsCompliant): Add nullable types test.
1114 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
1116 * doc.cs : catch other types of exception than XmlException to
1117 report CS1570. Fixed bug #82565.
1119 2007-08-23 Marek Safar <marek.safar@gmail.com>
1121 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
1122 The number of delegate parameters has to match.
1123 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
1126 2007-08-21 Marek Safar <marek.safar@gmail.com>
1128 * anonymous.cs (AnonymousMethod): Generate private anonymous method
1129 to fix problem with private arguments.
1131 2007-08-20 Marek Safar <marek.safar@gmail.com>
1133 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
1135 * decl.cs (MemberName): Ignore generic type with no generic arguments.
1137 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
1138 empty. Add cloning suport.
1140 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
1142 2007-08-20 Marek Safar <marek.safar@gmail.com>
1144 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
1145 to create EmptyCast. It handles EmptyConstantCast specialization for
1148 2007-08-18 Marek Safar <marek.safar@gmail.com>
1150 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
1151 (EmitArrayArgument): One routine for array arguments.
1152 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
1154 2007-08-17 Marek Safar <marek.safar@gmail.com>
1156 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
1158 2007-08-17 Marek Safar <marek.safar@gmail.com>
1160 * anonymous.cs: MemberLookupFinal update.
1162 * class.cs (ConstructorInitializer): Is expression based.
1164 * delegate.cs: MethodGroupExpr update.
1166 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
1168 (Error_MemberLookupFailed): Customizable error override.
1169 (MethodGroupExpr): Keep queried type for later usage.
1170 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
1173 * expression.cs: Error_MemberLookupFailed refactoring.
1174 (New.DoResolve): Resolve as much as possible.
1175 (ElementInitializer.Error_MemberLookupFailed): Object initializer
1176 customization for invalid member types.
1178 * statement.cs: MethodGroupExpr update.
1180 2007-08-16 Marek Safar <marek.safar@gmail.com>
1182 * modifier.cs (Check): Check all modifiers and not only accessibility
1185 2007-08-16 Marek Safar <marek.safar@gmail.com>
1187 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
1188 type and not an expression.
1190 2007-08-16 Marek Safar <marek.safar@gmail.com>
1192 * statement.cs (Catch.Clone): Type and variable can be null.
1194 2007-08-16 Marek Safar <marek.safar@gmail.com>
1196 A fix for bug #81979
1197 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
1198 I am really not sure whether this is the best fix.
1200 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
1203 2007-08-14 Marek Safar <marek.safar@gmail.com>
1205 ** C# 3.0 Object and collection initializers (major re-write)
1207 * assign.cs (DoResolve): Initializers are not assign related.
1209 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
1210 used during collection or object initialization.
1212 * expression.cs (Error_InvalidArguments): Add initializers specific
1213 messages. More will come later because it requires some general
1215 (New.DoResolve): Better error handling for unsafe types.
1216 (EmptyExpressionStatement): New class.
1217 (ElementInitializer): An object initializer expression.
1218 (CollectionElementInitializer): A collection initializer expression.
1219 (CollectionOrObjectInitializers): A block of object or collection
1221 (NewInitialize): New expression with element/object initializers.
1223 * statement.cs: Reverted object/collection initializer hacks.
1225 * typemanager.cs (CSharpName): Filter __arglist type.
1227 2007-08-09 Marek Safar <marek.safar@gmail.com>
1229 ** C# 3.0 Anonymous Types (update to the latest standard)
1231 * expression.cs (Binary.ResolveOperator): Threat all null based types
1233 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
1234 (AnonymousTypeParameter): Updated.
1236 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
1237 (AnonymousTypeClass): New anonymous type container.
1239 * class.cs (AddField): Return operation result.
1241 * generic.cs: Another empty TypeArguments overload.
1243 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
1244 are stored at top of normal hierarchy.
1246 * typemanager.cs (CSharpName): Filter anonymous types.
1248 2007-08-09 Marek Safar <marek.safar@gmail.com>
1250 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
1251 as single Concat call. How could we miss that :-(
1253 2007-08-08 Marek Safar <marek.safar@gmail.com>
1255 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
1257 2007-08-07 Miguel de Icaza <miguel@novell.com>
1259 * expression.cs: Fix the previous commit, the creation of the
1260 arguments array list needs also to be conditional on the arguments
1263 * class.cs: Add a little bit of help to help narrow down problems.
1265 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
1266 not try to copy in that case.
1268 * driver.cs: When building SMCS, include a new different set of
1269 default assemblies here. Do this here so we can control whether
1270 to include the default assemblies with /noconfig.
1272 2007-08-03 Marek Safar <marek.safar@gmail.com>
1274 A fix for bug #81979
1275 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
1278 2007-08-03 Marek Safar <marek.safar@gmail.com>
1280 A fix for bug #82300
1282 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
1283 we are in probing scope.
1285 2007-08-03 Marek Safar <marek.safar@gmail.com>
1287 A fix for bug #82301
1289 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
1290 (Statement.CloneTo): Clone and not map children blocks.
1292 2007-08-03 Marek Safar <marek.safar@gmail.com>
1294 A fix for bug #82299
1296 * expression.cs (LocalVariableReference.CloneTo): Remap local info
1299 * statement.cs (Statement.CloneTo): Clone variables before statements
1300 to allow remaping of local variables.
1302 2007-08-03 Marek Safar <marek.safar@gmail.com>
1304 A fix for bug #82296
1307 * report.cs: Log crash details for future clone problems.
1309 * statement.cs (Return.Clone): Don't clone non-existent expression.
1311 2007-08-03 Raja R Harinath <harinath@gmail.com>
1313 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
1314 (Class.AddBasesForPart): Move CS0537 check here from ...
1315 * cs-parser.jay (class_declaration): ... here. Move calling of
1316 'AddBasesForPart' to ...
1317 (class_bases): ... here.
1318 (struct_declaration, interface_declaration): Update to changes.
1320 2007-08-02 Marek Safar <marek.safar@gmail.com>
1322 A fix for bug #81923
1324 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
1325 conversion is allowed.
1327 2007-08-02 Marek Safar <marek.safar@gmail.com>
1329 A fix for bug #81564
1331 * ecore.cs (EventExpr): Add IsBase handling.
1333 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
1336 2007-08-02 Raja R Harinath <harinath@gmail.com>
1338 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
1339 * cs-parser.jay: Some whitespace cleanups.
1340 (current_delegate): New.
1342 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
1343 a dummy code block, and use 'type_name' instead of 'member_name'.
1344 (interface_declaration, class_declaration): Likewise.
1345 (delegate_declaration): Likewise. Rearrange slightly and use
1347 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
1348 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
1350 2007-08-02 Marek Safar <marek.safar@gmail.com>
1352 A fix for bug #82039
1354 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
1357 * typemanager.cs (CSharpName): Split to string overload.
1359 2007-08-02 Marek Safar <marek.safar@gmail.com>
1362 * report.cs: Updated warning CS0472.
1364 2007-08-01 Marek Safar <marek.safar@gmail.com>
1366 A fix for bug #82181
1368 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
1370 2007-08-01 Marek Safar <marek.safar@gmail.com>
1372 A fix for bug #82277
1373 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
1375 2007-08-01 Marek Safar <marek.safar@gmail.com>
1377 ** C# 3.0 Type Inference (major bits are working)
1379 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
1380 (.ImplicitStandardConversionExists): Uses compatible.
1381 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
1382 (.InferReturnType): New method.
1383 (.Compatible): Refactored.
1384 (.ResolveParameters): Uses factory to create resolved parameters.
1385 (.CompatibleMethod): Add probing mode support.
1386 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
1387 clearly distinguish between 2 different operations.
1388 (LambdaMethod): Moved to lambda.cs.
1389 (AnonymousMethod): Removed unused fields and methods.
1390 (AnonymousDelegate): Simplified.
1392 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
1394 * convert. cs (ImplicitConversionStandard): Compatible works differently.
1396 * delegate.cs (Delegate): New mehods to reduce code duplication.
1397 (.GetConstructor): New method.
1398 (.GetInvokeMethod): New method.
1399 (DelegateCreation): Updated.
1401 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
1403 (OverloadResolve): Made probing little bit faster.
1405 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
1408 * generic.cs (TypeInferenceContext): Dummy implementation.
1410 * iterators.cs: Updated after Resolve/Define rename.
1412 * lambda.cs (LambdaExpression)
1413 (.ResolveParameters): Handles both type of arguments and type inference too.
1415 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
1416 (InflateTypes): Updated.
1418 * support.cs (InflateTypes): Changed signature and updated.
1420 * typemanager.cs (LookupMemberCache): Better dynamic type check.
1421 (MemberLookup_FindMembers): More MS tricks.
1422 (GetParameterData): Ditto.
1423 (GetDelegateParameters): Uses quick path for dynamic types.
1425 2007-08-01 Marek Safar <marek.safar@gmail.com>
1427 * class.cs (MethodData.Define): EmitContext is required for generic stuff
1430 2007-07-31 Marek Safar <marek.safar@gmail.com>
1432 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
1435 2007-07-26 Jb Evain <jbevain@novell.com>
1437 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
1438 which takes a boolean 'report_errors', similar to the GetMethod.
1439 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
1440 in .net 2.1, do not report errors here.
1442 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
1443 System.Runtime.CompilerServices.RequiredAttributeAttribute and
1444 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
1447 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
1448 of the type InternalsVisibleToAttribute before the first call
1449 to CoreLookupType which is allowed to fail (third boolean parameter
1450 to true). Because, during the resolution for a type that is not
1451 immediately found, we try to check if the type is not defined in
1452 a friend assembly, and to do so, we need the
1453 InternalVisibleToAttribute.
1455 2007-07-23 Miguel de Icaza <miguel@novell.com>
1457 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
1458 feature that allows structs to be compared against null and inline
1459 the result as true or false.
1461 Notice that the same code is not permitted inside a generic block
1462 of code that would do:
1464 class Foo<T> where T : struct {
1471 It is only allowed if the type of T is not bound (no where
1472 clause). In my opinion, this CSC 2 behavior is broken but people
1473 seem to be using it (IronRuby does, a few bug reports on bugzilla
1474 have it and some people have complained about it).
1476 All of the users that depend on this behavior have code that is
1479 * report.cs (Warning, Error): make these take object arguments,
1480 not strings, as that allows us to take advantage of Format.
1482 2007-07-20 William Holmes <billholmes54@gmail.com>
1484 * decl.cs: Changed MemberName.CountTypeArguments to also check the
1485 Left member variable for the Count.
1486 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
1487 MemberName.CountTypeArguments to avoid a NRE.
1489 This code is contributed under the MIT X11 license
1491 2007-07-18 Marek Safar <marek.safar@gmail.com>
1493 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
1495 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1497 * doc.cs : generic method arguments are written as ``x while generic
1498 type arguments are `x. Combined with the previous change, fixed bug
1501 2007-07-18 Raja R Harinath <rharinath@novell.com>
1504 * expression.cs (Binary.ResolveOperator): When converting
1505 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
1507 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1509 * doc.cs : when T: or whatever x: is specified, it does not really
1510 check the doc comment's syntax correctness. Fixed bug #82006.
1512 2007-07-18 Marek Safar <marek.safar@gmail.com>
1514 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
1515 LambdaExpression better.
1517 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
1519 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
1521 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
1522 as it can be generated.
1524 * expression.cs (Invocation.Error_InvalidArguments): Show correct
1527 * lambda.cs (LambdaExpression): Refactored to share same code with
1528 AnonymousMethodExpression.
1530 2007-07-17 Marek Safar <marek.safar@gmail.com>
1532 * anonymous.cs (MakeName): Include host name for easier debugging.
1533 (LambdaMethod): New class for lambda spcecific stuff.
1535 * attribute.cs: Set EmitContext return type.
1537 * class.cs: Set EmitContext return type.
1539 * codegen.cs (EmitContext): Return type cannot be null to stop messing
1540 with null/void meaning.
1542 * iterators.cs (ContainerType): Implemented.
1544 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
1546 * statement.cs (Return): Updated to lambda expressions.
1547 (Block.CloneTo): Parent can be null.
1549 2007-07-13 Marek Safar <marek.safar@gmail.com>
1551 A fix for bug #81917
1552 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
1554 * class.cs (FixedField): Check whether field is in unsafe scope.
1556 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
1557 (FieldExpr.Emit): Fixed buffers cannot be volatile.
1559 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
1562 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
1564 2007-07-13 Marek Safar <marek.safar@gmail.com>
1566 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
1567 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
1570 2007-07-13 Marek Safar <marek.safar@gmail.com>
1572 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
1574 2007-07-13 Marek Safar <marek.safar@gmail.com>
1576 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
1577 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
1579 * codegen.cs(EmitContext): Add ProbingMode flag.
1581 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
1583 * driver.cs: For now set both warning values.
1585 * ecore.cs (SimpleName): Name is readonly.
1586 (MethodGroup.OverloadResolve): One quick path for probing.
1588 * expression.cs (Unary): Set Oper r/o.
1589 (Binary): Set Oper r/o.
1590 (ParameterReference): Set few instance variables as r/o.
1591 (ParameterReference.DoResolveBase): Don't capture aruments when
1593 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
1594 (Arglist): arguments are private.
1595 (SizeOf): type is private and r/o.
1596 (MemberAccess): arguments are private.
1598 * report.cs: Enhanced reporting on/off capabilities.
1600 * lambda.cs: Uses ec.IsInProbingMode.
1601 (ContextualReturn): Derives from return.
1603 * rootcontext.cs: For now set both warning values.
1605 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
1607 (Return.Resolve): Don't die immediately.
1608 (Block.Resolve): Speed-up probing.
1609 (Block.CloneTo): Clone only child blocks.
1611 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
1613 * iterators.cs: reverted Miguel's latest change (r81925) as it
1614 breaks the build in System.
1616 2007-07-13 Miguel de Icaza <miguel@novell.com>
1618 * iterators.cs (Yield.CheckContext): Check for the iterator type
1619 also here as we can call into Yield even in codepaths that are not
1621 (MethodOrOperator is the only path that was checked).
1623 In addition to the standard check, use a more specific check for
1624 constructors to report a more verbose error.
1626 2007-07-12 Miguel de Icaza <miguel@novell.com>
1628 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
1629 report the warning and continue
1631 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
1632 values on the stack on the call to Emit. Use EmitStatement if
1633 possible, or using Emit + Pop if not possible. Fixes #82064
1635 2007-07-12 Raja R Harinath <rharinath@novell.com>
1637 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
1638 avoid try...finally in some cases.
1640 2007-07-10 Marek Safar <marek.safar@gmail.com>
1642 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
1644 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
1645 instead of method. Re-use standard error handling.
1646 (ConstructorInitializer.Emit): Simplified.
1648 * delegate.cs: Updated after Invocation.EmitCall change.
1650 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
1651 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
1652 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
1653 method and don't permanently changing input arguments.
1654 (MethodGroupExpr): Introduced resolved best_candidate, when method group
1655 is resolved it has one of the candidates is the best one which is later
1656 used to emit. Removed a few unused method.
1657 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
1659 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
1660 (Binary.ResolveOperator): Ditto.
1661 (ConditionalLogicalOperator.DoResolve): Ditto.
1662 (Invocation): Uses method group.
1663 (Invocation.DoResolve): Simplified.
1664 (Invocation.EmitCall): Removed useless is_static.
1665 (Invocation.Emit): Delegate to method group.
1666 (Invocation.EmitStatement): Simplified.
1667 (New): Uses method group.
1668 (MemberAccess.DoResolve): Don't destroy original expression.
1670 * statement.cs (ForEach.Resolve): Use null for no method arguments.
1672 2007-07-04 Marek Safar <marek.safar@gmail.com>
1674 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
1677 * lambda.cs: Add custom error message type.
1679 2007-07-03 Marek Safar <marek.safar@gmail.com>
1681 * lambda.cs: Simplified little bit.
1683 * parameter.cs: Introduced ImplicitLambdaParameter.
1684 (Parameters.CreateFullyResolved): New factory instead of ctor.
1688 * delegate.cs: Updated parameter creation.
1690 2007-07-03 Marek Safar <marek.safar@gmail.com>
1692 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
1695 * generic.cs: Synchronized with gmcs.
1697 2007-07-03 Marek Safar <marek.safar@gmail.com>
1699 * class.cs (Indexer): Check return type as soon as possible.
1701 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
1704 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
1706 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
1708 * parameter.cs (Parameter): Use expression type when it is available.
1710 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
1711 method modifier for the first parameter only.
1713 2007-06-24 Marek Safar <marek.safar@gmail.com>
1715 A fix for bug #81938
1716 * typemanager.cs (ChangeType): Fixed couple of char conversions.
1718 * constant.cs: Tide up an exception message.
1720 2007-06-22 Marek Safar <marek.safar@gmail.com>
1722 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
1723 an uninitialized variable is used.
1725 * expression.cs (LocalVariableReference.DoResolve): Ditto.
1727 2007-06-22 Marek Safar <marek.safar@gmail.com>
1729 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
1730 not found error handling.
1732 * expression.cs (ArrayCreation): Removed redundant fields and little bit
1734 (ArrayCreation.ResolveArrayElement): To be ready to customization.
1735 (ArrayCreation.DoResolve): Simplified.
1736 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
1737 its own resolve process.
1738 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
1740 2007-06-20 Marek Safar <marek.safar@gmail.com>
1742 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
1745 2007-06-20 Marek Safar <marek.safar@gmail.com>
1747 * cs-tokenizer.cs: Removed var related stuff.
1749 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
1750 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
1751 a type and a keyword at same time.
1753 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
1756 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
1757 implicitly typed arrays, more changes will follow.
1759 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
1761 2007-06-19 Marek Safar <marek.safar@gmail.com>
1763 * ecore.cs (VarExpr): Removed Handled field.
1765 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
1766 build-in assign functionality.
1767 (ForEach.Resolve): Removed all implicitly typed local variable code and
1769 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
1770 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
1772 2007-06-18 Marek Safar <marek.safar@gmail.com>
1774 * assign.cs: Removed implicitly typed local variable check.
1776 * expression.cs (LocalVariableReference.DoResolve): Add check for self
1777 referencing implicitly typed local variable.
1778 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
1781 * statement.cs (Fixed): Removed unsupported implicitly typed local
1784 2007-06-15 Marek Safar <marek.safar@gmail.com>
1786 * decl.cs (MemberName): Moved all Unbound stuff to parser.
1788 2007-06-14 Marek Safar <marek.safar@gmail.com>
1790 A fix for bugs #81855 and #76274
1791 * attribute.cs (AttachTo): Always set owner for global attributes to
1794 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
1797 * cs-parser.jay: Assembly and module attributes must precede all other
1798 elements except using clauses and extern alias declarations.
1800 2007-06-13 Marek Safar <marek.safar@gmail.com>
1802 A fix for bug #81748
1804 * expression.cs: More checks for non ISO-1 features.
1806 2007-06-12 Marek Safar <marek.safar@gmail.com>
1808 A fix for bug #81807
1809 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
1810 present inside switch statement and it is required by nullable check.
1812 2007-06-12 Marek Safar <marek.safar@gmail.com>
1814 A fix for bug #81840
1815 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
1816 when type matching fails.
1818 * namespace.cs: Tiny error message change.
1820 2007-06-12 Marek Safar <marek.safar@gmail.com>
1822 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
1823 reporting. Added automatic property check.
1825 * class.cs: Updated after CheckAbstractAndExtern relocation.
1826 (AEventPropertyAccessor.GetSignatureForError): Customized.
1828 2007-06-11 Marek Safar <marek.safar@gmail.com>
1830 * class.cs (DefineBaseTypes): Base type can be undefined.
1832 * ecore.cs (TypeLookup): Minor refactoring.
1833 (DoResolveAsTypeStep): Removed redundant check.
1835 * namespace.cs (Lookup): Removed redundant check.
1837 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
1838 ResolveAsTypeTerminal step.
1839 (BootstrapCorlib_*): Simplified.
1840 (PopulateCoreType): Core types can be now external.
1842 2007-06-07 Marek Safar <marek.safar@gmail.com>
1844 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
1846 (InferTypeArguments): Infers anonymous expression type arguments.
1847 (Compatible): Split to Compatible and InferTypeArguments.
1849 * lambda.cs: Updated.
1851 2007-06-08 Marek Safar <marek.safar@gmail.com>
1853 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
1855 2007-06-07 Raja R Harinath <harinath@gmail.com>
1857 Fix #80477, cs0135-2.cs, cs0135-3.cs
1858 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
1859 names to the "known" variables list.
1860 (Block.CheckInvariantMeaningInBlock): Handle the fact the
1861 parameter names are also "known".
1862 (Block.CheckError136): Remove.
1863 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
1866 2007-06-07 Marek Safar <marek.safar@gmail.com>
1868 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
1870 2007-06-06 Marek Safar <marek.safar@gmail.com>
1872 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
1873 internal error not an user error.
1875 * expression.cs (IsApplicable): Refactored to make debugging easier.
1877 * support.cs: More tricks for non-mono runtimes.
1879 * typemanager.cs (CoreLookupType): Made public.
1880 (InitSystemCore): All linq specific stuff moved to linq.cs
1882 2007-06-05 Marek Safar <marek.safar@gmail.com>
1884 * typemanager.cs (CSharpSignature): One more missing build-in types
1886 More tricks for non-mono runtime.
1888 2007-06-05 Raja R Harinath <harinath@gmail.com>
1890 * statement.cs (Block.CheckError136_InParents): Remove.
1891 (Block.AddVariable): Use GetParameterInfo instead.
1892 (ToplevelBlock.ProcessArguments): Likewise.
1894 2007-06-04 Raja R Harinath <rharinath@novell.com>
1896 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
1898 (ToplevelBlock.GetParameterInfo): Split out of ...
1899 (ToplevelBlock.GetParameterRefernce): ... this.
1900 (ToplevelBlock.ParameterMap): Remove.
1901 * expression.cs (ParameterReference): Update to use
1902 ToplevelParameterInfo.
1904 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
1907 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
1908 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
1910 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
1911 (ToplevelBlock.ProcessParameters) ... here.
1912 (ToplevelBlock..ctor): Invoke it.
1914 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
1917 * statement.cs (IKnownVariable): New interface.
1918 (LocalInfo): Implement it.
1919 (ToplevelParameterInfo): New class.
1920 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
1921 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
1922 GetKnownVariableInfo.
1924 2007-06-03 Raja R Harinath <harinath@gmail.com>
1926 Partly speed up CS0136 error checks.
1927 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
1928 'recurse' parameter.
1929 (Block.DoCheckError136): Only check errors in parameters. Move
1930 local variable checks ...
1931 (Block.AddVariable): ... here, and ...
1932 (ToplevelBlock.ResolveMeta): ... here.
1934 2007-06-02 Raja R Harinath <harinath@gmail.com>
1936 * statement.cs (Block.IsChildOf): Remove.
1938 * statement.cs (Statement.Clone): Move special case code ...
1939 (Block.CloneTo): ... here.
1941 2007-05-29 Raja R Harinath <rharinath@novell.com>
1943 * statement.cs (ToplevelBlock.container): Remove field. It's
1944 redundant with 'Parent'.
1945 (ToplevelBlock.ContainerBlock): Remove accessor.
1946 (ToplevelBlock..ctor): Update to changes. Register anonymous
1947 child with parent here, ...
1948 * cs-parser.jay (end_anonymous): ... not here. Don't modify
1950 (start_anonymous): Don't save current_block.
1951 (top_current_block): Remove.
1953 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
1954 (Block.Resolve): Update to changes.
1955 (Block..ctor): Move setting of "correct" 'Toplevel'
1956 and 'Explicit' fields to ...
1957 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
1959 2007-05-27 Raja R Harinath <harinath@gmail.com>
1962 * statement.cs (Block.Implicit): Remove.
1963 (Block): Update to changes.
1964 * flowanalysis.cs: Likewise.
1966 Mildly speed up CheckInvariantMeaningInBlock
1967 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
1968 Recursively call AddKnownVariable to all enclosing blocks.
1969 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
1970 Remove recursive calls.
1971 (Block): Update to changes.
1973 New ExplicitBlock invariants
1974 * statement.cs (Block.Explicit): New field. It points to the
1975 immediately enclosing non-implicit block.
1976 (Block..ctor): Maintain the invariant.
1977 * cs-parser.jay: Take advantage of invariant.
1979 Introduce ExplicitBlock
1980 * statement.cs (ExplicitBlock): New.
1981 (ToplevelBlock): Derive from it.
1982 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
1984 (Block.Implicit): Update to changes.
1985 * cs-parser.jay: Update to changes.
1988 * codegen.cs (EmitContext.IsLastStatement): Remove.
1989 * statement.cs (Block.DoEmit): Update to changes.
1991 2007-05-25 Raja R Harinath <rharinath@novell.com>
1993 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
1994 modifying current_block directly.
1996 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
1998 * class.cs: Implemented automatic properties (C# 3.0)
1999 Thanks to Marek for the help.
2001 2007-05-23 Raja R Harinath <rharinath@novell.com>
2003 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
2004 variable as assigned, note also that all its components are
2006 (MyBitVector.SetRange): New. Function to set multiple bits to true.
2008 2007-05-19 Marek Safar <marek.safar@gmail.com>
2010 * anonymous.cs, class.cs: Emit Compiler generated attribute when
2011 member is marked as compiler generated.
2013 * decl.cs (MemberCore): Refactored ModFlags into property.
2015 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
2016 (Check): Check only accessibility modifiers.
2018 2007-05-18 Raja R Harinath <rharinath@novell.com>
2020 Track all assignable slots in one bit array
2021 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
2022 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
2023 logic from VariableMap constructor here. Use the same 'offset'
2024 variable that's later used for computing offsets of local
2026 * flowanalysis.cs (UsageVector.parameters): Remove.
2027 (UsageVector): Update to changes.
2028 (VariableMap): Remove.
2030 Avoid creating ParameterMap in every block
2031 * statement.cs (Block.ParameterMap): Move ...
2032 (ToplevelBlock.ParameterMap): ... here.
2033 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
2035 * flowanalysis.cs (FlowBranching.param_map): Remove.
2036 (FlowBranching.UsageVector): Update to changes.
2037 (FlowBranchingToplevel.CheckOutParameters): Likewise.
2039 * statement.cs (Block.CloneTo): Clone Toplevel field too.
2041 * expression.cs (ParameterReference): Distinguish between block
2042 where parameter was referenced and declared.
2044 2007-05-18 Marek Safar <marek.safar@gmail.com>
2046 * flowanalysis.cs, statement.cs: Put back improved error handling.
2048 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
2052 Imporved object and collection initialization (C# 3.0).
2054 2007-05-15 Marek Safar <marek.safar@gmail.com>
2056 A fix for bug #81380
2057 * expression.cs (Is.DoResolve): Only value types have constant `is'
2060 2007-05-15 Raja R Harinath <rharinath@novell.com>
2062 * statement.cs (ToplevelBlock.child): Remove.
2064 2007-05-15 Raja R Harinath <harinath@gmail.com>
2066 Rationalize ResolveMeta: refactoring
2067 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2068 out constant handling code into ...
2069 (Block.DoResolveConstants): ... this.
2071 Rationalize ResolveMeta: kill local_map
2072 * statement.cs (Block.local_map, Block.LocalMap): Remove.
2073 (Block.AssignableSlots): New.
2074 (Block.ResolveMeta): Make protected. Don't create a VariableMap
2075 for locals -- move code from VariableMap here. Avoid unnecessary
2077 * flowanalysis.cs (FlowBranching.local_map): Remove.
2078 (FlowBranching..ctor): Use Block.AssignableSlots.
2079 (VariableMap): Remove unused constructors.
2081 2007-05-11 Raja R Harinath <rharinath@novell.com>
2083 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
2085 2007-05-11 Marek Safar <marek.safar@gmail.com>
2087 * typemanager.cs (IsFriendAssembly): Should not be called for building
2090 2007-05-09 Marek Safar <marek.safar@gmail.com>
2092 * literal.cs (NullConstant): Print null in all cases.
2094 * expression.cs (Binary.ResolveOperator): Implemented delegate
2095 comparison based on C# 2.0 changes.
2097 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
2099 This code is contributed under the MIT X11 license
2101 The following enables support for several C# 3.0 language features:
2103 * cs-tokenizer.cs: Added support for the "var" keyword.
2105 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
2106 Added VarExpr class to facilitate type inferencing.
2108 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
2109 to support anonymous types.
2111 * assign.cs: Added support for type inferencing and initialization.
2113 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
2115 * expression.cs: Added implicit array support to ArrayCreation.
2116 Added 5 types and 1 interface:
2118 IInitializable Implementing classes can inject initializing
2119 statements after object instantiation.
2121 Initializer Stores data for object initialization.
2123 AnonymousType An expression for anonymous types.
2125 AnonymousTypeParameter Stores data about an anonymous type's field.
2127 NewInitialize An expression for object initialization.
2129 CollectionInitialize An expression for collection initialization.
2131 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
2134 2007-05-06 Marek Safar <marek.safar@gmail.com>
2136 A fix for bug #81500
2137 * cs-tokenizer.cs: Add special handling for coalescing operator.
2139 2007-05-06 Marek Safar <marek.safar@gmail.com>
2141 A fix for bug #81529
2142 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
2143 its value from base class until it is redefined.
2145 2007-05-02 Raja R Harinath <rharinath@novell.com>
2147 Fix regression in cs0631-3.cs
2148 * cs-parser.jay (operator_declarator): Add opt_attributes to error
2149 fallback. Make error fallback catch more cases.
2151 2007-05-01 Miguel de Icaza <miguel@novell.com>
2153 * cs-parser.jay: Allow parameters in operator declarations to have
2156 2007-04-27 Miguel de Icaza <miguel@novell.com>
2158 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
2161 * lambda.cs (ContextualReturn.Resolve): An expression is valid
2162 inside the ContextualReturn, it does not have to be an
2163 ExpressionStatement.
2165 2007-04-24 Miguel de Icaza <miguel@novell.com>
2167 * lambda.cs (ContextualReturn.Resolve): if the return type is not
2170 2007-04-23 Miguel de Icaza <miguel@novell.com>
2172 * anonymous.cs (AnonymousContainer): split the virtual Resolve
2173 method in two methods: ResolveNoDefine and Resolve.
2175 ResolveNoDefine will stop just after ResolveTopBlock has been
2178 Resolve will then continue by creating a method and issuing the
2179 call to method.Define ().
2181 (AnonymousMethod): Split and implement the new Resolve and
2182 ResolveNoDefine as well.
2184 * lambda.cs (LambdaExpression): Split the anonymous method
2185 resolution code into a separate routine (CoreCompatibilityTest)
2186 from DoCompatibleTest.
2188 (LambdaExpression.TryBuild): New method, this method tries to
2189 build the LambdaExpression with the given set of types to be used
2190 as the types for the various parameters of the lambda expression.
2192 If the compilation succeed with the given types, the infered type
2193 of the Anonymous method is returned, otherwise null is returned.
2195 2007-04-23 Marek Safar <marek.safar@gmail.com>
2197 A fix for bug #81414
2198 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
2200 2007-04-22 Miguel de Icaza <miguel@novell.com>
2202 * cs-tokenizer.cs: Change various identifiers here from the
2203 camelCasing to the recommended Linux-like style for instance
2204 variables from the Coding Guidelines.
2206 2007-04-19 Martin Baulig <martin@ximian.com>
2209 (Convert.ImplicitReferenceConversionCore): Allow conversions from
2210 System.Enum to System.ValueType.
2212 2007-04-13 Martin Baulig <martin@ximian.com>
2214 Rewrote implicit reference conversions. We need to distinguish
2215 between implicit reference conversions (13.1.4) and implicit
2216 boxing conversions (13.1.5).
2218 According to the spec, there's an an implicit conversion
2219 "From a one-dimensional array-type S[] to IList<T> and base
2220 interfaces of this interface, provided there is an implicit
2221 reference conversion from S to T." Note that this does not
2222 include boxing conversions.
2225 (Convert.ImplicitTypeParameterBoxingConversion): New method.
2226 (Convert.ImplicitReferenceConversion): Split into
2227 ImplicitReferenceConversionCore() and
2228 ImplicitBoxingConversionExist().
2229 (Convert.ImplicitReferenceConversionExists): Use the new
2230 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
2232 2007-04-12 Martin Baulig <martin@ximian.com>
2234 * convert.cs (Convert.ImplicitReferenceConversion): Move the
2235 `TypeManager.null_type' checks up to the top of the method.
2237 2007-04-11 Marek Safar <marek.safar@gmail.com>
2239 A fix for bug #81350
2240 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
2243 2007-04-11 Martin Baulig <martin@ximian.com>
2245 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
2246 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
2247 to make this work for generic classes; fixes #79561.
2249 2007-04-11 Martin Baulig <martin@ximian.com>
2251 * expression.cs (As): Add support for nullable types; fixes #79371.
2253 2007-04-11 Martin Baulig <martin@ximian.com>
2255 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
2256 `type.FullName' is null; fixes #80243.
2258 2007-04-11 Martin Baulig <martin@ximian.com>
2260 * expression.cs (Invocation.IsApplicable): Don't modify the method
2261 if type inference succeeded, but the method was not applicable.
2264 2007-04-10 Marek Safar <marek.safar@gmail.com>
2266 A fix for bug #81324
2267 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
2268 internal and external namespaces containers.
2270 2007-04-10 Martin Baulig <martin@ximian.com>
2272 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
2273 TypeManager.DropGenericMethodArguments() so we also call
2274 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
2276 2007-04-10 Martin Baulig <martin@ximian.com>
2278 * iterators.cs (Iterator.CreateIterator): Don't crash if
2279 `method.ReturnType' is null. This happens if something went wrong
2280 while resolving that typ (we already reported an error in this case).
2282 2007-04-10 Martin Baulig <martin@ximian.com>
2284 * expression.cs (New.DoResolve): Don't call CheckComImport() on
2285 generic interfaces; report the CS0144 directly.
2287 2007-04-10 Martin Baulig <martin@ximian.com>
2289 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
2290 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
2292 2007-04-10 Martin Baulig <martin@ximian.com>
2294 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
2296 2007-04-09 Raja R Harinath <rharinath@novell.com>
2299 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
2300 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
2303 * statement.cs (For.Resolve): If resolution fails, use
2306 2007-04-08 Marek Safar <marek.safar@gmail.com>
2308 * anonymous.cs (MakeName): Make faster and zero-based.
2309 (VerifyExplicitParameterCompatibility): Back to mode where generic
2310 parameter is ignored.
2311 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
2313 * class.cs (EmitType): Method can emit another new method.
2315 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
2317 * driver.cs: Updated.
2319 * lambda.cs: Reuse predefined empty parameters.
2321 * parameter.cs: Updated
2323 * support.cs: Implemented InflateTypes.
2325 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
2326 (InitSystemCore): Introduced to isolate 3.0 dependencies.
2328 2007-04-03 Martin Baulig <martin@ximian.com>
2332 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
2333 version of TypeManager.IsOverride() which also works with generic
2336 2007-04-03 Martin Baulig <martin@ximian.com>
2341 (Convert.ExplicitReferenceConversion): We need to cast when
2342 converting from IList<T> to S[].
2344 2007-04-01 Marek Safar <marek.safar@gmail.com>
2346 * decl.cs (FindExtensionMethods): Consider all candidates with same name
2349 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
2351 2007-03-31 Marek Safar <marek.safar@gmail.com>
2353 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
2354 argument and return type inferring.
2356 * codegen.cs (InferReturnType): Flag whether return can be inferred.
2357 (ReturnType): Turned to property.
2359 * statement.cs (Return): Implemented return type inferring.
2361 * support.cs (ReflectionParameters): Use local types if possible.
2363 2007-03-30 Raja R Harinath <rharinath@novell.com>
2365 * flowanalysis.cs (FlowBranching.Reachability): Remove.
2366 (FlowBranching.UsageVector): Update to changes.
2368 Prepare to kill 'Reachability'
2369 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
2370 argument of constructor.
2372 2007-03-29 Raja R Harinath <rharinath@novell.com>
2374 Prepare to kill 'Reachability'
2375 * flowanalysis.cs (UsageVector.is_unreachable): New.
2376 (UsageVector): Update to maintain 'is_unreachable' in parallel to
2377 'reachability', and verify they're consistent.
2380 * expression.cs (New.EmitStatement): Handle type parameters here too.
2382 2007-03-29 Martin Baulig <martin@ximian.com>
2387 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
2388 CompilerGeneratedClass.
2389 (ScopeInfo.EmitScopeInstance): Make this protected.
2390 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
2391 `ec.CurrentAnonymousMethod.Scope == Scope'.
2393 * statement.cs (Block.ScopeInfo): Make this a property.
2395 2007-03-27 Raja R Harinath <harinath@gmail.com>
2397 Prepare to kill 'Reachability'
2398 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
2399 (FlowBranching.UsageVector.Reachability): Remove property.
2400 (FlowBranching.UsageVector.IsUnreachable): New property.
2401 (FlowBranching.UsageVector.ResetBarrier): New.
2402 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
2403 * codegen.cs, statement.cs: Update to changes.
2405 2007-03-27 Martin Baulig <martin@ximian.com>
2410 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
2413 2007-03-26 Raja R Harinath <rharinath@novell.com>
2415 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
2416 instead of TriState. Remove all mention of TriState.
2418 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
2419 replaced by a boolean. Add boolean 'is_unreachable' field, check
2420 and maintain invariants.
2422 2007-03-25 Marek Safar <marek.safar@gmail.com>
2424 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
2426 2007-03-25 Marek Safar <marek.safar@gmail.com>
2428 * expression.cs: Stop using obsolete 2.0 opcodes.
2430 2007-03-25 Marek Safar <marek.safar@gmail.com>
2432 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
2433 one of the latests Martin's fixes.
2435 2007-03-23 Miguel de Icaza <miguel@novell.com>
2437 * expression.cs: On BigEndian systems, swap the bytes, temporary
2438 solution until we get a new bitconverter class.
2440 2007-03-23 Martin Baulig <martin@ximian.com>
2444 * decl.cs (MemberCache.AddMembers): Add generic methods both as
2445 "Method" and "Method`1". Normally, a cache lookup is done on the
2446 "Method" form (ie. without the generic arity), but this one makes
2447 lookups on the full form work as well.
2449 2007-03-22 Raja R Harinath <rharinath@novell.com>
2451 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
2454 2007-03-20 Bill Holmes <billholmes54@gmail.com>
2456 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
2457 ordered_member_list, to TypeBuilder to store members to be defined
2458 in the order they were parsed in.
2459 - ordered_explicit_member_list contains all properties indexers
2460 and methods that are defined as explicit implementation of an
2461 interface or base class.
2462 - ordered_member_list contains all properties indexers and methods
2463 that are not defined as explicit implementation of an interface
2466 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
2467 functionality in these removed classes has been replaced with
2468 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
2469 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
2471 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
2472 to CheckForDuplications inside GetMethod and SetMethod Define Method
2473 to handle method property and indexer name conflicts.
2477 All code is contributed under the MIT/X11 license.
2479 2007-03-20 Martin Baulig <martin@ximian.com>
2481 * class.cs (TypeContainer.Interfaces): Removed; they're now
2482 included in `TypeContainer.Types'.
2484 2007-03-20 Martin Baulig <martin@ximian.com>
2486 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
2488 * class.cs (TypeContainer.CreateType): New public method. This is
2489 now called before DefineType() to create the TypeBuilders.
2490 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
2491 has already been created by CreateType().
2492 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
2493 don't resolve our base classes here; this has been moved into
2494 DefineBaseTypes(). We're now called from CreateType().
2495 (TypeContainer.DefineBaseTypes): New private method; resolve our
2496 base classes here. We're now called from DefineType().
2499 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
2500 our types first to create all the TypeBuilders. After that, call
2501 TypeContainer.DefineType() on all the types which'll resolve their
2502 base classes and setup the resolve order.
2504 2007-03-20 Martin Baulig <martin@ximian.com>
2506 * class.cs (TypeContainer.Enums): Removed; they're now included in
2507 `TypeContainer.Types'.
2509 2007-03-20 Martin Baulig <martin@ximian.com>
2512 (TypeContainer.DefineType): Don't call ResolveMembers() here.
2513 (TypeContainer.DoResolveMembers): Call DefineType() on our
2514 `compiler_generated' classes; moved here from DefineNestedTypes().
2517 (RootContext.ResolveTree): Call ResolveMembers() on all
2518 TypeContainer's in the `type_container_resolve_order'.
2520 2007-03-19 Marek Safar <marek.safar@gmail.com>
2522 * class.cs: Use corlib to handle InternalMethodImplAttribute.
2524 2007-03-17 Marek Safar <marek.safar@gmail.com>
2526 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
2527 implementation flags.
2529 2007-03-17 Marek Safar <marek.safar@gmail.com>
2531 * class.cs: More optimizations for type parameters.
2533 2007-03-15 Marek Safar <marek.safar@gmail.com>
2535 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
2537 * ecore.cs, parameter.cs: More common code for both corlibs.
2539 * typemanager.cs (IsGenericMethod): Simplified.
2541 2007-03-15 Raja R Harinath <rharinath@novell.com>
2543 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2545 * statement.cs, iterators.cs, lambda.cs: Update to changes.
2547 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
2548 unconditionally. Simplify explanation.
2549 (Try.Resolve, Using.Resolve): Likewise.
2551 2007-03-15 Martin Baulig <martin@ximian.com>
2555 * decl.cs (DeclSpace): If we're a partial class, use our
2556 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
2558 2007-03-15 Raja R Harinath <rharinath@novell.com>
2560 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2562 (FlowBranching.UsageVector): Update to changes.
2563 (FlowBranching.MergeSiblings): Likewise.
2564 * statement.cs: Likewise.
2566 2007-03-15 Martin Baulig <martin@ximian.com>
2571 (MemberCache): Added a special .ctor for type parameters.
2574 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
2577 2007-03-09 Martin Baulig <martin@ximian.com>
2579 * enum.cs (Enum): Make this a TypeContainer.
2580 (EnumMember): Derive from `Const'.
2583 (Const.DoResolveValue): New protected virtual method; move most of
2584 the functionality of ResolveValue() here so we can override it in
2586 (Const.CreateConstantReference): Make this virtual.
2588 * class.cs (Kind): Add `Kind.Enum'.
2589 (TypeContainer.Emit): Don't emit the enums here; they're already
2590 in the `RootContext.typecontainer_resolve_order'.
2592 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
2593 here; they're already in the `typecontainer_resolve_order'.
2595 * ecore.cs (EnumConstant.ConvertImplicitly): Add
2596 TypeManager.DropGenericTypeArguments().
2599 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
2600 (TypeManager.IsEnumType): Likewise.
2601 (TypeManager.EnumToUnderlying): Likewise.
2602 (TypeManager.IsEqual): Add support for enums.
2604 2007-03-12 Raja R Harinath <rharinath@novell.com>
2606 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
2607 DefaultParameterValueAttribute to be undefined, say if System.dll
2610 2007-03-11 Marek Safar <marek.safar@gmail.com>
2612 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
2615 2007-03-10 Marek Safar <marek.safar@gmail.com>
2617 * class.cs, parameter.cs: Unified parameters verification.
2619 2007-03-08 Martin Baulig <martin@ximian.com>
2621 * cs-parser.jay (constructor_header): Pass the location to the
2622 newly created TopLevelBlock.
2624 2007-03-07 Martin Baulig <martin@ximian.com>
2626 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
2628 2007-03-06 Miguel de Icaza <miguel@novell.com>
2630 * convert.cs (ExplicitReferenceConversionExists): Sync this method
2631 with the changes from David, fixes the build.
2633 2007-03-05 David Mitchell <dmitchell@logos.com>
2635 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
2636 and its base interfaces to a one-dimensional array type S[],
2637 provided there is an implicit or explicit reference conversion
2640 2007-03-03 Marek Safar <marek.safar@gmail.com>
2642 * cs-tokenizer.cs: Implemented basic linq grammar.
2644 * driver.cs: Set linq lang version on demand.
2646 2007-02-26 Marek Safar <marek.safar@gmail.com>
2648 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
2650 2007-02-25 Marek Safar <marek.safar@gmail.com>
2652 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
2655 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
2657 Check property and event extern attributes.
2659 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
2662 2007-02-24 Marek Safar <marek.safar@gmail.com>
2664 A fix for bug #80407
2665 * ecore.cs: Don't report ambiguity error when methods have same parent.
2667 2007-02-23 Marek Safar <marek.safar@gmail.com>
2669 A fix for bug #80878
2670 * class.cs, cs-parser.jay: Event property can host anonymous methods.
2672 2007-02-22 Marek Safar <marek.safar@gmail.com>
2674 * attribute.cs: Enable ExtensionAttribute presence test.
2676 2007-02-22 Marek Safar <marek.safar@gmail.com>
2678 * class.cs: Warn about missing GetHashCode only when Equals is override.
2680 * decl.cs: Check accessibility of type arguments.
2682 * typemanager.cs: Correctly report nullable array.
2684 2007-02-20 Marek Safar <marek.safar@gmail.com>
2686 * class.cs, report.cs: Capture more details when things go wrong.
2688 2007-02-20 Marek Safar <marek.safar@gmail.com>
2690 A fix for bug #80650
2691 * cs-parser.jay: Anonymous container starts at constructor declaration
2692 and not at block beginning because it has to be usable in constructor
2695 * statement.cs: Use context location and not block one for error reporting.
2697 2007-02-18 Marek Safar <marek.safar@gmail.com>
2699 A fix for bug #78712
2700 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
2703 2007-02-18 Marek Safar <marek.safar@gmail.com>
2705 A fix for bug #80493 by Atsushi Enomoto
2706 * cs-parser.jay: Ignore invalid attribute target.
2708 2007-02-18 Marek Safar <marek.safar@gmail.com>
2710 * cs-tokenizer.cs: Ignore '\0' as white space character.
2712 2007-02-17 Miguel de Icaza <miguel@novell.com>
2714 * cs-parser.jay: Add support for lambda expressions to the mcs
2717 * lambda.cs: Only clone when we are probing, not on the final call
2718 (Compatible is the final call).
2720 * statement.cs (CloneContext): Introduce class to provide block
2721 remapping during clone.
2723 All statements Clone themselves now.
2725 (Clone): special handling for blocks, when we clone a block, we
2726 register the block inside this routine, as children of the block
2727 might trigger a lookup.
2729 * expression.cs: Add support for CloneContext in all expressions.
2731 2007-02-17 Marek Safar <marek.safar@gmail.com>
2733 A fix for bug #80493
2734 * statement.cs: Report ambiguous warning when interfaces are not related.
2736 2007-02-15 Marek Safar <marek.safar@gmail.com>
2738 C# 3.0 extension methods.
2740 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
2741 cannot be used directly.
2743 * class.cs (Class.Emit): Emit extension attribute if any class method
2744 is extension method.
2745 (Method.Define): Add basic extension method validation conditions.
2746 (Method.Emit): Emit extension attribute for method.
2748 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
2749 extension method exists. Currently we follow same approach as Microsoft
2750 does, emit even if a method or a class are private but this can change
2753 * cs-parser.jay: Add handling of `this' keyword in method parameters
2756 * decl.cs (DeclSpace.IsStaticClass): New property.
2757 (MemberCache.FindExtensionMethods): Looks for extension methods with
2758 defined name and extension type.
2760 * doc.cs: Updated after OverloadResolve changes.
2762 * driver.cs: Add new soft reference to System.Core.dll.
2764 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
2765 (ExtensionMethodGroupExpr): Represents group of extension methods.
2767 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
2768 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
2769 to MethodGroupExpr and made non-static for easier customization.
2770 (Invocation.DoResolve): Add extension method lookup when no standard
2772 (MemberAccess.DoResolve): Try extension methods if no member exists.
2774 * modifiers.cs: Add METHOD_EXTENSION modifier.
2776 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
2777 as well as candidate extension type.
2778 (ComputeNamespaces): When assembly constains extension methods registers
2780 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
2781 extension method lookup.
2782 (Namespace.LookupExtensionMethod): Looks for extension method in this
2784 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
2785 find a method which matches name and extensionType.
2787 * parameter.cs (Parameter): Add This modifer.
2788 (HasExtensionMethodModifier): New property.
2789 (Resolve): Add extension parameter check.
2790 (ModFlags): turned to property to exclude this modifier as it is not real
2792 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
2794 * support.cs (ParameterData): Add ExtensionMethodType.
2795 (ReflectionParameters): Implemented ExtensionMethodType interface property.
2797 * typemanager.cs: Add type and ctor extension attribute type.
2799 2007-02-15 Miguel de Icaza <miguel@novell.com>
2801 * report.cs (DisableErrors, EnableErrors): used to prevent error
2802 output when we are "trying" to compile various methods with
2805 * ecore.cs (Expression): Add Clone method that calls the virtual
2806 CloneTo method. The current CloneTo method in Expression throws
2807 an exception so we can track down all the places where this must
2808 be implemented (not using abstract, because that would be a lot of
2809 up-front-work before we can start testing the implementation
2812 Important: we only need Clone capabilities for expressions created
2813 by the parser, as the expressions we will be cloning are
2814 expressions in the pre-resolved state. This vastly simplifies
2817 (SimpleName): Add CloneTo that does nothing.
2818 (EmptyCast): Add CloneTo.
2820 * expression.cs (Binary): Implement CloneTo.
2821 (Invocation.IsApplicable): Store the current ec in
2822 EmitContext.TempEc and restore it on return. This is used so we
2823 do not have to sprinkle hundres of methods with an extra
2824 EmitContext, we know that the only user is the lambda expression
2825 ImplicitConversionExists code.
2827 (Argument): Add Cloning capabilities.
2828 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
2829 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
2830 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
2831 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
2832 IndexerAccess): Add Clone capability.
2834 (LocalVariableReference, This): TODO: needs cloned Block mapping.
2836 (Argument): Add cloning capability.
2838 * assign.cs (Assign): Implement CloneTo.
2840 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
2842 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
2843 version by calling Convert with the EmitContext (that we are
2844 currently storing in ec, this is not great, but will do for now,
2845 to avoid passing EmitContext parameters to hundreds of functions
2846 that do not need them now).
2848 (SetExpression): Remove, it is not needed.
2850 (ContextualReturn): Implement CloneTo.
2852 * statement.cs (Statement): Implement cloning infrastructure,
2853 similar to expressions.
2855 (Block): Partial implementation of Clone for statements.
2857 (Return): Implement clone.
2859 * constant.cs (Constant.CloneTo): New method, does nothing.
2861 * codegen.cs (TempEc): Add a static EmitContext as a temporary
2862 solution, until we decide how to exactly do this.
2864 2007-02-14 Marek Safar <marek.safar@gmail.com>
2866 A fix for bug #80493
2867 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
2868 a property is override we need to use second accessor.
2870 2007-02-13 Marek Safar <marek.safar@gmail.com>
2872 A fix for bug #80418
2873 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
2876 2007-02-13 Marek Safar <marek.safar@gmail.com>
2878 Another fix for bug #80749
2879 * pending.cs: Abstract class has priority over interfaces.
2881 2007-02-13 Marek Safar <marek.safar@gmail.com>
2883 Another fix for bug #80749
2884 * pending.cs: Abstract class has priority over interfaces.
2886 2007-02-13 Marek Safar <marek.safar@gmail.com>
2888 Another fix for bug #80749
2889 * pending.cs: Abstract class has priority over interfaces.
2891 2007-02-13 Marek Safar <marek.safar@gmail.com>
2893 Another fix for bug #80749
2894 * pending.cs: Abstract class has priority over interfaces.
2896 2007-02-13 Marek Safar <marek.safar@gmail.com>
2898 * class.cs Better error message.
2900 * driver.cs: Add shorter versions of -optimize option.
2902 2007-02-13 Martin Baulig <martin@ximian.com>
2904 * class.cs (Constructor.Emit): Check the return value of
2905 ec.ResolveTopBlock() and return on error.
2907 2007-02-13 Raja R Harinath <rharinath@novell.com>
2909 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
2910 message to fix error message regression.
2912 2007-02-12 Marek Safar <marek.safar@gmail.com>
2914 * delegate.cs: Delegate creation expression cannot be of Nullable type.
2916 2007-02-12 Marek Safar <marek.safar@gmail.com>
2918 A fix for bug #80749
2919 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
2920 its parent container.
2922 * class.cs (DefineFieldInitializers): Each initializer can has different
2925 * const.cs: Updated.
2927 2007-02-11 Miguel de Icaza <miguel@novell.com>
2929 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
2930 now all the heavy lifting to check that embedded statements or
2931 expressions have the right form is done in the ContextualReturn.
2933 (ContextualReturn): New class.
2935 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
2936 method that can be invoked to report 201, so we do not replicate
2939 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
2941 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
2942 treating tabs as spaces.
2944 2007-02-09 Marek Safar <marek.safar@gmail.com>
2946 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
2947 * assign.cs: Use full implicit conversion for right side check.
2949 2007-02-09 Marek Safar <marek.safar@gmail.com>
2951 * statement.cs (Switch): Switch over boolean type is not standardized.
2953 2007-02-08 Marek Safar <marek.safar@gmail.com>
2955 A fix for bug #80755
2956 * decl.cs (FindBaseEvent): Don't use method cache for events.
2958 2007-02-07 Marek Safar <marek.safar@gmail.com>
2960 * cs-parser.jay: Better syntax error handling.
2962 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
2963 instead of underlying type value.
2965 2007-02-06 Marek Safar <marek.safar@gmail.com>
2967 * driver.cs: Check define identifier before is registered.
2969 * namespace.cs: Use existing error message.
2971 * report.cs: New warning.
2973 2007-02-06 Marek Safar <marek.safar@gmail.com>
2975 A fix for bug #80742
2976 * expression.cs: Delegate Invoke method can be called directly.
2978 2007-02-06 Marek Safar <marek.safar@gmail.com>
2980 A fix for bug #80676
2981 * class.cs (IsEntryPoint): The Main method can have params modifier.
2983 2007-02-04 Miguel de Icaza <miguel@novell.com>
2985 * parameter.cs (Parameter, Parameters): Add Clone method.
2987 * anonymous.cs (Compatible): Turn method into virtual method, so
2988 LambdaExpression can implement a different behavior.
2990 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
2991 out the basic checking here, so it can be used by
2994 * lambda.cs: Introduce "Compatible" function that will do the
2997 2007-02-02 Marek Safar <marek.safar@gmail.com>
2999 * attribute.cs: Unified one error message.
3001 * class.cs (Class): Use type attributes and not properties to test static
3003 (IsEntryPoint): Don's pass local variable.
3005 * convert.cs: Removed duplicate check.
3007 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
3009 * driver.cs: Don't crash when soft reference does not exist.
3011 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
3012 (UsingEntry): Removed redundant allocation.
3014 * parameter.cs: Add fast path for type parameters.
3016 * support.cs: Don't allocate attribute when it's not used.
3018 2007-01-30 Miguel de Icaza <miguel@novell.com>
3021 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
3022 this into a virtual method, so we can override it in LambdaExpression.
3024 * driver.cs: Improve diagnostics in case of failure.
3026 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
3027 write a function that is slightly more complex and that parses:
3029 type identifier [, type identifier]* )
3031 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
3034 (canEmpty ? i >= 0 : i > 0)
3036 2007-01-30 Raja R Harinath <rharinath@novell.com>
3038 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
3039 exception on possibly valid code.
3041 2007-01-29 Raja R Harinath <rharinath@novell.com>
3043 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
3045 (parse_opt_type_arguments): Remove. It's almost the same as
3047 (parse_namespace_or_typename): Use parse_less_than.
3049 2007-01-28 Miguel de Icaza <miguel@novell.com>
3051 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
3052 this bug took a few hours to find, because the state saved and
3053 restored by PushPosition and PopPosition was ignoring the state of
3054 parse_generic_less_than.
3056 I can also now remove the handling of OP_LT and OP_GT, this solves
3059 * cs-tokenizer.cs: store the location for the ARROW token, we use
3062 (PushPosition, PopPosition): save/restore also `current_token',
3063 restore `parse_generic_less_than' (was missing).
3065 (parse_opt_type_arguments): use parse_type, not
3066 parse_namespace_or_typename to parse types.
3068 * lambda.cs: Empty new file, will eventually have the lambda
3069 expression implementation.
3071 * lambda.test: used to test the internal tokenizer.
3073 * report.cs (FeatureIsNotISO1): Rename from
3074 FeatureIsNotStandardized, because it was about the language level
3075 (1 vs 2) it was not about standarization.
3077 (FeatureRequiresLINQ): New.
3079 * support.cs (SeekableStreamReader): Only require that the reader
3080 is a TextReader, not a StreamReader, so we can plug StringReader.
3082 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
3083 given position in the input stream the following tokens can be
3084 parsed as a type followed by an identifier.
3086 (is_punct): after a '(' if parse_type_and_parameter returns true,
3087 then return a special token OPEN_PARENS_LAMBDA which is used to
3088 avoid reduce/reduce errors in the grammar for the
3089 lambda_expression rules.
3091 (parse_type): implement a type parser inside the
3092 tokenizer, the parser only returns true or false depending on
3093 whether the input at a given position can be parsed as a type.
3095 (peek_token): new method used during type parsing.
3097 2007-01-28 Raja R Harinath <rharinath@novell.com>
3100 * anonymous.cs (ScopeInfo.InflateParameters): New.
3101 (AnonymousContainer.Resolve): Use it to redirect types of
3102 delegate parameters.
3104 2007-01-27 Raja R Harinath <rharinath@novell.com>
3107 * expression.cs (Error_InvalidArguments): Don't use two different
3108 messages for CS1503. Use ExtraInformation and
3109 SymbolRelatedToPreviousError instead.
3112 * decl.cs (DeclSpace.initialize_type_params): Don't access
3113 'type_params' of a partial class directly.
3115 2007-01-26 Miguel de Icaza <miguel@novell.com>
3117 * constant.cs: Removed a handful of out-of-range checks that were
3120 2007-01-25 Marek Safar <marek.safar@gmail.com>
3122 * expression.cs (CheckUselessComparison): Add additional check for char
3125 * namespace.cs: Fixed typo.
3127 2007-01-23 Miguel de Icaza <miguel@novell.com>
3129 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
3130 gone, instead we inline the test, preventing the needless casts to
3131 longs, ulongs and doubles for the parameters, avoiding calls to
3132 methods that overchecked stuff, and instead inlined things
3135 2007-01-20 Marek Safar <marek.safar@gmail.com>
3137 * cs-parser.jay: Better parameter error handling.
3139 2007-01-17 Marek Safar <marek.safar@gmail.com>
3141 A fix for bug #80368, #80522
3142 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
3143 whether array initializer contains constants only.
3144 (ArrayCreation.Emit): Use better formula to decide when
3145 are array initializers for static initialization.
3146 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
3147 have to emit even constants otherwise they are pre-initialized.
3149 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
3150 Raja R Harinath <rharinath@novell.com>
3152 Fix emit order of 'get' vs. 'set'.
3153 * support.cs (Accessors): New.
3154 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
3155 Note the order in which accessors are declared in the source.
3156 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
3157 Refactored from Property.Define and Indexer.Define.
3158 (PropertyBase.DefineAccessors): New helper that calls the above in
3159 appropriate order as noted by the parser.
3160 (Property.Define, Indexer.Define): Update to changes.
3161 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
3163 2007-01-17 Raja R Harinath <rharinath@novell.com>
3165 Fix cs0029-6.cs and gcs0029-2.cs (regression)
3166 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
3167 there's an implicit conversion from the current type to the target
3168 type before converting the underlying constant.
3170 2007-01-16 Marek Safar <marek.safar@gmail.com>
3172 * const.cs (ResolveValue): Updated after constant conversion was made more
3175 * constant.cs (GetAttributableValue): constant to object conversion is
3176 used for attributes only.
3177 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
3178 constant conversions.
3179 (LongConstant.ConvertImplicitly): Ditto.
3181 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
3182 (ImplicitConversionStandard): Handle constant conversion as extra step.
3183 It solves the issue when constant conversion was called indirectly like
3184 inside array initializer and constant folding was skipped.
3186 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
3189 * statement.cs(ImplicitConversionStandard): Updated after constant
3190 conversion was made more generic.
3192 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
3194 * expression.cs (As.DoResolve): Use GenericConstraints instead of
3195 Constraints, solves the problem where the compiler incorrectly
3196 reported that a type parameter was not constrained to a class (Bug
3199 2007-01-14 Marek Habersack <grendello@gmail.com>
3201 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
3203 2007-01-14 Marek Safar <marek.safar@gmail.com>
3205 A fix for bug #80368
3206 * assign.cs (FieldInitializer): New class implements field
3207 initializer statement.
3209 * attribute.cs: Update after FieldMember rename.
3211 * class.cs (PropertyBasedMember): New common class for property based
3213 (InterfaceMemberBase): New base class for all members which can be used as
3214 an interface members.
3215 (MethodCore): Moved really common code to InterfaceMemberBase.
3216 (Method.Define): Equal and GetHasCode detection is relevant for methods
3218 (MethodData.Define): Don't assume that public event implements an
3219 interface automatically.
3220 (MethodData.DefineMethodBuilder): Issue an error even if only extern
3222 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
3223 (FieldMember): Merged with FieldBase.
3224 (EventProperty.AEventPropertyAccessor): New specialization to check whether
3225 event extern modifier can be used.
3226 (EventField.EventFieldAccessor): Moved event field specific code here.
3227 (Event.AllowedModifiers): Even event can be extern.
3228 (Event.FindOutBaseMethod): New override specific to events.
3229 (Indexer.parameters): Reintroduce parameters because base class holds
3230 only properties common data.
3231 (Indexer.CheckForDuplications): Indexers are threated as methods so we
3232 need do extra parameters check.
3234 * const.cs: Update after FieldMember rename.
3236 * decl.cs (MemberCache.FindBaseEvent): New method.
3238 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
3239 to reflect that indexer is now derived from PropertyBased.
3241 * ecore.cs (GetMemberType): Made public.
3242 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
3245 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
3247 * typemanager.cs (CSharpSignature): Correctly print event accessors.
3248 (RegisterEvent): Removed.
3249 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
3250 (GetPrivateFieldOfEvent): Renamed to GetEventField.
3252 2007-01-11 Raja R Harinath <rharinath@novell.com>
3255 * statement.cs (CollectionForeach.TryType): Prefer generic
3256 GetEnumerator over non-generic variant. Fix code to follow comments.
3258 2007-01-09 Raja R Harinath <rharinath@novell.com>
3261 * support.cs (ReflectionParameter): Don't use an invalid index on
3262 the generic parameter data.
3264 2007-01-08 Miguel de Icaza <miguel@novell.com>
3266 * driver.cs: Just add a tiny bit of infrastructure.
3268 2007-01-02 Marek Safar <marek.safar@gmail.com>
3270 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
3271 where field type is struct from current assembly.
3273 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
3276 2007-01-02 Marek Safar <marek.safar@gmail.com>
3278 A fix for bug #80381
3279 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
3282 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
3284 (Namespace.LookupType): Always use core types from corlib when speficied.
3286 * report.cs: A new warning.
3288 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
3289 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
3290 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
3292 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
3293 (InitCoreTypes): Set expression type of object_type and value_type
3294 immediately after lookup.
3296 2007-01-01 Miguel de Icaza <miguel@novell.com>
3298 * cs-tokenizer.cs: Accept Pc class characters (Connector
3299 Punctuation) as valid identifiers. Fixes #78259
3301 * expression.cs (Invocation.DoResolve): Moved the check for the
3302 use of `this' for doing method calls to the Invocation resolution
3303 step, after overload resolution has taken place instead of doing
3304 the check at the low-level `This.DoResolve' level.
3306 The `This.DoResolve'(appens before overload resolution, so it has
3307 no way of knowing if the method that will be called will be
3308 instace or static, triggering an erroneous report for cs0188 (Bug
3311 We now do the check for instance method invocations after we know
3312 what method will be called.
3314 (This.CheckThisUsage): Move the actual use of this structure
3315 checking into its own method and expose it.
3317 * Everywhere that called Error_ValueCannotBeConverted: pass a new
3320 Exceptions: Null.ConvertImplicitly,
3321 Constant.ImplicitConversionRequired as there are too many call
3322 sites for passing the ec.
3324 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
3325 EmitContext, if the value is null, then we do not try to provide
3326 the extra information from the error (If a userdefined conversion
3327 exists, as UserDefinedConversion requires a non null-EmitContext).
3331 2006-12-30 Raja R Harinath <rharinath@novell.com>
3333 * flowanalysis.cs (MyBitVector): Document some invariants.
3334 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
3335 introduced below, and add a couple of others,
3337 2006-12-30 Marek Safar <marek.safar@gmail.com>
3339 * attribute.cs (GetMethodObsoleteAttribute): Uses new
3340 GetPropertyFromAccessor and GetEventFromAccessor.
3342 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
3343 overrides non-obsolete one.
3344 (Indexer.Define): Error message has been moved to the parser.
3346 * cs-parser.jay: Better syntax errors handling.
3348 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
3349 when an invocation has no arguments.
3351 * ecore.cs: Removed not used caching.
3353 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
3356 * report.cs: Add a new warning.
3358 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
3360 * typemanager.cs (enumeration_type): Removed.
3361 (CSharpSignature): Reuses IsSpecialMethod.
3362 (IsEqual): Hack for MS BCL.
3363 (GetPropertyFromAccessor): New method.
3364 (GetEventFromAccessor): New method.
3365 (IsSpecialMethod): Fixed to handle more cases.
3367 2006-12-30 Marek Safar <marek.safar@gmail.com>
3369 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
3370 Made white spaces array static.
3372 * ecore.cs (RemoveGenericArity): Optimized.
3374 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
3376 (MyBitVector.initialize_vector): Simplified.
3378 2006-12-22 Miguel de Icaza <miguel@novell.com>
3380 * ecore.cs: Am not entirely happy with this hack, but it seems to
3381 address the issue in 80257 (a small test case for
3384 I set the MethodGroupExpr.Type to an internal compiler type
3385 (itself in this case) to force the resolution to take place. Why
3386 it does not take place with a null is beyond me.
3388 2006-12-20 Marek Safar <marek.safar@gmail.com>
3390 A fix for bug #80288
3391 * expression.cs (ResolveOperator): Consider user defined conversion for
3392 logical and operator too.
3393 (EmitBranchable): Optimization for logical and when full constant folding
3394 could not be applied but one operand is constant.
3396 2006-12-19 Marek Safar <marek.safar@gmail.com>
3398 * class.cs (GetClassBases): Write 5 times every day, will never use
3399 FullName for error reporting.
3401 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
3403 2006-12-19 Martin Baulig <martin@ximian.com>
3405 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
3406 the symbol file info here.
3408 2006-12-18 Marek Safar <marek.safar@gmail.com>
3410 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
3411 of `elseif' is taking then following sections are not taking.
3412 Fixes an issue reported on mono mailing list.
3414 2006-12-18 Marek Safar <marek.safar@gmail.com>
3416 A fix for bug #80300
3417 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
3418 a caller is not taking.
3420 2006-12-18 Raja R Harinath <rharinath@novell.com>
3422 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
3423 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
3424 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
3425 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
3426 * class.cs: Update to changes.
3428 2006-12-17 Marek Safar <marek.safar@gmail.com>
3430 A fix for bug #79934
3431 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
3434 * class.cs (ResolveMembers): Register an iterator in current container and
3437 2006-12-16 Raja R Harinath <rharinath@novell.com>
3440 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
3441 satisfy a params annotated parameter.
3443 2006-12-16 Marek Safar <marek.safar@gmail.com>
3445 A fix for bug #77014
3446 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
3447 paramters correctly and not rely on hacks in Parameters class.
3448 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
3450 (Invocation.VerifyArgumentsCompat): Ditto.
3451 (Invocation.EmitArguments): Changed to correctly emit params arguments at
3454 * parameter.cs (HasParams): Don't assume that params is the last one.
3456 * support.cs (ReflectionParameters.ctor): Look for params attribute
3458 (ReflectionParameters.ParameterType): Removed hack when we returned last
3459 parameter for out of range parameters.
3460 (ParameterName, ParameterModifier): Ditto.
3462 2006-12-14 Marek Safar <marek.safar@gmail.com>
3464 A fix for bug #79987
3465 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
3466 when assembly is not CLS compliant but type is. I have no idea why is this
3469 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
3471 2006-12-13 Miguel de Icaza <miguel@novell.com>
3473 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
3474 in struct constructors, they are basically no-ops.
3476 2006-12-12 Marek Safar <marek.safar@gmail.com>
3478 * cs-tokenizer.cs (Position): Save preprocessor status too.
3480 2006-12-12 Marek Safar <marek.safar@gmail.com>
3482 A fix for bug #77794
3483 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
3485 2006-12-12 Marek Safar <marek.safar@gmail.com>
3487 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
3489 (pp_expr): Report error for an invalid expression.
3490 (handle_preprocessing_directive): Simplified; add more error checking.
3492 2006-12-11 Marek Safar <marek.safar@gmail.com>
3494 A fix for bug #74939
3495 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
3496 directives handling.
3498 2006-12-10 Marek Safar <marek.safar@gmail.com>
3500 A fix for bugs #80093, and #75984
3501 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
3502 logic, it seems to me as it worked before "by coincidence".
3503 (xtoken): Simplified to use reworked handle_preprocessing_directive.
3504 (cleanup): Enabled endif check.
3506 2006-12-09 Marek Safar <marek.safar@gmail.com>
3508 A fix for bug #80162
3509 * statement.cs (CollectionForeach.TryType): Generics and non-generics
3510 enumerators are never ambiguous.
3512 2006-12-08 Raja R Harinath <rharinath@novell.com>
3515 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
3517 2006-12-06 Marek Safar <marek.safar@gmail.com>
3519 A fix for bug #80144
3520 * class.cs (EventProperty.Define): Explicit implementation means
3521 that an even is used.
3523 2006-12-06 Marek Safar <marek.safar@gmail.com>
3525 Fixes the operators implementation (part II)
3527 * cfold.cs (DoConstantNumericPromotions): Renamed to
3528 DoBinaryNumericPromotions and simplified.
3529 (BinaryFold): Couple of conversion fixes; simplified.
3531 * constant.cs, ecore.cs, literal.cs
3532 (ToType): Renamed to ConvertImplicitly.
3533 (Reduce): Renamed to ConvertExplicitly.
3535 * class.cs, convert.cs: Updated.
3537 * expression.cs: TryReduce doesn't throw an exception.
3539 2006-12-01 Marek Safar <marek.safar@gmail.com>
3541 A fix for bug #80108
3542 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
3545 2006-11-30 Marek Safar <marek.safar@gmail.com>
3547 Fixes unary operators implementation (part I)
3550 * cfold.cs (Error_CompileTimeOverflow): Made internal
3552 * const.cs (IConstant): Changed to use reference to constant and
3553 not constant itself.
3554 Updated IConstant implementations.
3556 * constant.cs (CreateConstant): New factory method.
3557 Updated IConstant implementation.
3559 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
3561 * ecore.cs: Updated to use CreateConstantReference.
3563 * enum.cs: Reflects IConstant changes.
3565 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
3567 * literal.cs (NullConstant): Change to be independently usable.
3569 2006-11-29 Martin Baulig <martin@ximian.com>
3571 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
3572 we need to emit the scope initializer before calling the base .ctor.
3574 * anonymous.cs: Merged back from the new anonymous methods branch.
3575 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
3577 * expression.cs (ParameterReference.DoResolveBase): Create a
3578 "normal" ScopeInfo when capturing parameters rather than using the
3579 root scope; this makes things work with anonymous methods having
3583 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
3585 2006-11-22 Marek Safar <marek.safar@gmail.com>
3587 A fix for bug #79987
3588 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
3589 check to a base class.
3590 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
3591 only when assembly has missing attribute.
3592 * report.cs: Update.
3594 2006-11-21 Marek Safar <marek.safar@gmail.com>
3596 * cs-tokenizer.cs: Merged with gmcs version.
3598 2006-11-20 Marek Safar <marek.safar@gmail.com>
3601 * cs-parser.jay: Better error message when partial keyword is misplaced.
3603 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
3605 A fix for bug #79810
3606 report.cs: CS1058 only applies to 2.0 profile (gmcs).
3607 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
3608 a RuntimeWrappedException by default.
3610 2006-11-18 Marek Safar <marek.safar@gmail.com>
3612 A fix for bug #79843
3613 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
3615 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
3617 2006-11-18 Marek Safar <marek.safar@gmail.com>
3619 * driver.cs, namespace.cs: Uses faster IndexOf version.
3621 2006-11-17 Marek Safar <marek.safar@gmail.com>
3623 A fix for bug #79941
3624 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
3626 (Operator.Define): Implicit/Explicit operator of same type is duplicate
3627 even if internal name is different.
3628 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
3629 (UserDefinedConversion): Simplified as the operators cannot be internal.
3630 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
3632 (MethodLookup): Replaced EmitContext with parentType.
3633 * expression.cs: Updated.
3635 2006-11-09 Raja R Harinath <rharinath@novell.com>
3637 * driver.cs (BadAssembly): Handle all the ugliness of
3638 DefineDynamicAssembly.
3640 2006-11-08 Raja R Harinath <rharinath@novell.com>
3642 Address parts of #58244 -- most of what's left is in the runtime
3643 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
3644 CS1509 error checks, and handle them for all assembly loads, not
3645 just the first invocation.
3646 (LoadModule): Likewise. Move handling of 'adder_method' ...
3647 * codegen.cs (AssemblyClass.AddModule): ... here.
3649 2006-11-02 Marek Safar <marek.safar@gmail.com>
3651 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
3652 IEnumerable<T> is ambiguous.
3654 2006-10-31 Marek Safar <marek.safar@gmail.com>
3656 A fix for bug #67689
3657 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
3658 GetEnumerator is ambiguous.
3660 * report.cs: Add new warning.
3662 2006-10-29 Marek Safar <marek.safar@gmail.com>
3664 A fix for bug #78602
3665 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3666 to protected member can be nested type.
3668 2006-10-28 Marek Safar <marek.safar@gmail.com>
3670 A fix for bug #78965
3671 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3672 to protected member must derive from current type.
3674 2006-10-27 Marek Safar <marek.safar@gmail.com>
3676 assign.cs: Reuses error method.
3678 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
3679 instead of type for constants.
3680 (Expression.Error_ValueAssignment): Common error method.
3682 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
3685 2006-10-27 Marek Safar <marek.safar@gmail.com>
3687 A fix for bug #79081
3688 * expression.cs (MemberAccess.DoResolve): Check nested type
3691 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
3693 * doc.cs : nested delegates were not handled. Fixed bug #79754.
3695 2006-10-26 Marek Safar <marek.safar@gmail.com>
3697 A fix for bug #76591
3698 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
3700 2006-10-26 Marek Safar <marek.safar@gmail.com>
3702 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
3703 type forwarder of the same type multiple times.
3705 2006-10-26 Raja R Harinath <rharinath@novell.com>
3708 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
3709 instance as an rvalue, even when we later resolve as an lvalue.
3711 2006-10-25 Martin Baulig <martin@ximian.com>
3713 * anonymous.cs: Fix #79673.
3715 2006-10-24 Marek Safar <marek.safar@seznam.cz>
3717 A fix for bug #79666
3718 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
3719 ignored when is optimized (= default value) as its value is already set.
3721 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3723 A fix for bug #79724
3724 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
3725 TypeContainer for type lookup.
3727 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3729 A fix for bug #79231
3730 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
3731 * expression.cs (OverloadResolve): Always convert type name for
3733 (ResolveNamespaceOrType): Don't confuse a nested type with any
3736 2006-10-18 Martin Baulig <martin@ximian.com>
3738 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
3740 2006-10-17 Miguel de Icaza <miguel@novell.com>
3742 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
3743 an int32, but requesting an int64 from the conversion
3745 2006-10-12 Martin Baulig <martin@ximian.com>
3748 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
3750 2006-10-12 Martin Baulig <martin@ximian.com>
3753 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
3755 2006-10-11 Miguel de Icaza <miguel@novell.com>
3757 * convert.cs: Remove broken code: I was doing the "Existance"
3758 tests for Implicit conversions.
3760 2006-10-10 Miguel de Icaza <miguel@novell.com>
3762 * convert.cs: Added one missing case in
3763 ImplicitStandardConversionExists uint64 to intptr.
3767 * typemanager.cs (uintptr_type): another core known type.
3769 * ecore.cs (OperatorCast): routine used to do cast operations that
3770 depend on op_Explicit. We could change some of the Decimal
3771 conversions to use this.
3773 This one has a probe mechanism that checks both types for an op_
3774 which it coudl be used to eliminate two classes: CastToDecimal
3775 and CastFromDecimal.
3777 * convert.cs: Implement the conversions documented in #59800
3779 2006-10-10 Martin Baulig <martin@ximian.com>
3781 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
3782 before RootScope.ResolveMembers().
3784 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
3785 `CurrentType' if appropriate.
3787 2006-10-09 Marek Safar <marek.safar@seznam.cz>
3789 A fix for bug #78568
3790 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
3791 when contains binary operators.
3792 * cs-parser.jay: Updated.
3794 2006-10-09 Martin Baulig <martin@ximian.com>
3797 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
3798 moved that into Define() and also do the other type parameter
3799 checks there. Fixes #79094. Added gtest-292.cs.
3802 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
3803 since that doesn't include type parameters; don't use `Ldelema'
3804 for type parameters. Fixes #78980. Added gtest-293.cs.
3806 2006-10-08 Marek Safar <marek.safar@seznam.cz>
3809 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
3810 conversion is allowed.
3812 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3814 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
3815 error reporting when no error occurs.
3817 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3819 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
3822 2006-10-06 Raja R Harinath <rharinath@novell.com>
3825 * class.cs (DefineTypeBuilder): Check circular dependencies before
3826 setting the parent of the TypeBuilder.
3827 (CheckRecursiveDefinition): Don't use 'BaseType', since
3828 it may not be valid until after DefineTypeBuilder. Use
3829 'base_type' instead.
3831 2006-10-04 Martin Baulig <martin@ximian.com>
3833 Merged the Anonymous Methods patch.
3835 * anonymous.cs, iterators.cs: The new anonymous methods code.
3837 * statement.cs (Variable): New public abstract class.
3838 (LocalInfo.Variable): New public property.
3839 (LocalInfo.ResolveVariable): New public method.
3840 (Block.Flags): Add `IsIterator'.
3841 (Block.AddVariable): Improved the CS0136 check.
3842 (Block.AnonymousChildren): New public property.
3843 (Block.AddAnonymousChild): New public method.
3844 (ToplevelBlock): Update to use the new anonymous method framework.
3845 (ToplevelBlock.ctor): `container' is now a `Block' and not a
3846 `ToplevelBlock'; this is required to correctly implement the
3848 (Fixed, Using): Use `TemporaryVariable' instead of directly
3849 creating the `LocalBuilder'.
3851 * parameter.cs (Parameter.ResolveVariable): New public method.
3852 (Parameters.ResolveVariable): Likewise.
3854 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
3856 * class.cs (TypeContainer): Replaced the `iterators' list and
3857 corresponding methods with a list of `CompilerGeneratedClass'es.
3858 (TypeContainer.ResolveMembers): New public method.
3859 (Method): `IIteratorContainer' has been replaced by
3862 * expression.cs (VariableReference): New public abstract base
3863 class for `LocalVariableReference', `ParameterReference' and
3866 * codegen.cs (EmitContext): Removed `capture_context',
3867 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
3868 (EmitContext.EmitThis): Removed.
3870 * cs-parser.jay: Replace `iterator_container' with
3873 2006-10-04 Martin Baulig <martin@ximian.com>
3875 * generic.cs (GenericMethod): Don't make this abstract.
3876 (Constraints.Clone): Added dummy implementation.
3878 2006-10-04 Raja R Harinath <harinath@gmail.com>
3881 * namespace.cs (LookForAnyGenericType): Avoid nullref on
3882 'declspaces'. Avoid allocating arrays willy-nilly.
3885 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
3886 cases out of the switch.
3888 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3890 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
3891 message when non-generic type is used with the type arguments.
3892 * expression.cs: Updated.
3894 2006-09-28 Raja R Harinath <rharinath@novell.com>
3897 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
3898 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
3899 Change semantics slightly. Don't insist on having only one
3900 temporary EmptyExpression -- just throttle the creation of new ones.
3903 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
3904 non-interfaces too. If no methods are found, don't try to create
3907 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3909 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
3912 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
3913 us produce better error message.
3915 2006-09-27 Marek Safar <marek.safar@seznam.cz>
3917 * expression.cs (Binary.ResolveOperator): Warn about a side effect
3918 of the `|' operator.
3920 * report.cs: A new warning added.
3922 2006-09-27 Martin Baulig <martin@ximian.com>
3924 * generic.cs (GenericMethod): Don't make this abstract.
3926 2006-09-27 Martin Baulig <martin@ximian.com>
3929 (InternalErrorException): Added overloaded ctor taking a params array.
3931 2006-09-26 Marek Safar <marek.safar@seznam.cz>
3933 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
3934 Fixed the cases when same error was reported twice.
3936 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
3937 now report symbol information.
3939 2006-09-25 Martin Baulig <martin@ximian.com>
3941 * class.cs: Completely unified with the gmcs version.
3943 2006-09-25 Martin Baulig <martin@ximian.com>
3945 * typemanager.cs (TypeManager.IsNullableType): New public function.
3946 (TypeManager.IsNullableTypeOf): Likewise.
3947 (TypeManager.IsNullableValueType): Likewise.
3949 * class.cs (MethodCore): Added the `GenericMethod' argument from
3950 gmcs and also unified all classes derived from `MethodCore' with gmcs.
3952 2006-09-24 Raja R Harinath <harinath@gmail.com>
3954 * convert.cs: Unify with gmcs version.
3956 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3958 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
3959 verify them as well.
3961 * report.cs: New warning.
3963 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3965 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
3966 for anonymous block with out argument.
3968 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3970 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
3971 not used private events only.
3973 2006-09-23 Marek Safar <marek.safar@seznam.cz>
3975 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
3977 * const.cs (Const.Define): Check for constant type.
3978 (Const.IsConstantTypeValid): Looks for valid constant types.
3980 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
3982 * ecore.cs (EmptyConstantCast): New common class for all constant based
3985 * expression.cs (Is.DoResolve): Handle null constant especially.
3986 (New.DoResolve): Check for new void().
3987 (MemberAccess.DoResolve): Cope with all kind of nulls.
3989 * literal.cs (NullConstant): Uses EmptyConstantCast.
3990 (NullDefault): Based on EmptyConstantCast.
3991 (NullLiteral): Uses EmptyConstantCast.
3993 * statement.cs (Block.ResolveMeta): Check for constant type.
3995 2006-09-22 Martin Baulig <martin@ximian.com>
3997 * delegate.cs, attribute.cs: Merged with the gmcs versions.
3999 2006-09-22 Raja R Harinath <rharinath@novell.com>
4001 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
4005 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
4006 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
4009 2006-09-22 Martin Baulig <martin@ximian.com>
4011 * ecore.cs: Merged with the gmcs version.
4013 * generic.cs (ConstructedType): New dummy class.
4014 (TypeArguments): Don't make this abstract.
4017 (TypeManager.IsGenericTypeDefinition): New method.
4018 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
4020 2006-09-22 Raja R Harinath <rharinath@novell.com>
4022 * expression.cs (ComposedCast): Check for arrays of TypedReference
4023 before creating the type, not after.
4025 2006-09-21 Marek Safar <marek.safar@seznam.cz>
4027 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
4028 after ToType change.
4030 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
4031 when constant must be implicitly convertible.
4033 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
4035 * ecore.cs (NullCast): Derives from NullConstant.
4037 * expression.cs (Is.DoResolve): Removed useless variables.
4038 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
4039 (New.Constantify): Add enum support.
4040 (MemberAccess.DoResolve): Add warning when accessing null constant or
4043 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
4046 * literal.cs (NullConstant): New abstract class with common
4047 functionality for all null specializations.
4048 (NullDefault): Represents default(X) when result can be
4050 (NullLiteral): Updated.
4052 * report.cs: Add new warning.
4054 2006-09-21 Martin Baulig <martin@ximian.com>
4056 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
4058 2006-09-21 Martin Baulig <martin@ximian.com>
4060 * generic.cs (GenericConstraints): New dummy class.
4061 (Constraints): Likewise.
4062 (TypeParameter): Likewise.
4063 (TypeParameterName): Likewise.
4064 (GenericMethod): Likewise.
4066 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4068 * decl.cs: Merged with the gmcs version.
4070 2006-09-21 Raja R Harinath <rharinath@novell.com>
4072 * generic.cs (TypeParameter): Implement IMemberContainer.
4073 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
4075 * rootcontext.cs: Unify with gmcs version.
4077 * report.cs: Unify with gmcs version.
4078 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
4079 from gmcs/generics.cs.
4080 * generics.cs (TypeParameter): New dummy class.
4082 * support.cs: Unify with gmcs version.
4084 2006-09-20 Raja R Harinath <rharinath@novell.com>
4086 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
4087 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
4089 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
4090 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
4091 * mcs.exe.sources: Add generic.cs.
4093 * codegen.cs: Unify with gmcs version.
4095 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
4096 (EmitContext): Add GenericDeclContainer implementation.
4097 * decl.cs (MemberCore, DeclSpace): Likewise.
4098 * namespace.cs: Remove #ifdef GMCS_SOURCE.
4100 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
4101 MCS TypeManager has a corresponding dummy method.
4103 2006-09-19 Martin Baulig <martin@ximian.com>
4105 * expression.cs: Completely merged with the gmcs version.
4107 2006-09-19 Martin Baulig <martin@ximian.com>
4109 * expression.cs (Invocation): Merged with the gmcs version.
4110 (ArrayAccess.GetStoreOpcode): Likewise.
4112 2006-09-19 Martin Baulig <martin@ximian.com>
4115 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
4116 (TypeManager.IsGenericMethodDefinition): Likewise.
4118 2006-09-19 Martin Baulig <martin@ximian.com>
4121 (TypeManager.IsEqual): Moved the gmcs implementation here.
4122 (TypeManager.DropGenericTypeArguments): Likewise.
4123 (TypeManager.DropGenericMethodArguments): Likewise.
4124 (TypeManager.GetTypeArguments): Moved here from gmcs.
4125 (TypeManager.HasGenericArguments): Likewise.
4127 2006-09-19 Martin Baulig <martin@ximian.com>
4129 * expression.cs (Binary): Merged with the gmcs version.
4131 2006-09-19 Martin Baulig <martin@ximian.com>
4133 * expression.cs (Probe, As, Is): Merged with the gmcs version.
4135 2006-09-19 Martin Baulig <martin@ximian.com>
4137 * typemanager.cs: Merged with the gmcs version.
4139 2006-09-16 Raja R Harinath <rharinath@novell.com>
4141 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
4142 * driver.cs: Likewise.
4144 2006-09-16 Marek Safar <marek.safar@seznam.cz>
4147 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
4148 only if parent type is class.
4149 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
4152 2006-09-15 Marek Safar <marek.safar@seznam.cz>
4155 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
4157 * typemanager.cs(CSharpName): Converts NullType to null.
4159 2006-09-15 Martin Baulig <martin@ximian.com>
4162 (TypeManager.GetMethodName): Added mcs implementation.
4163 (TypeManager.IsEqual): Likewise.
4166 (SimpleName.RemoveGenericArity): Added dummy implementation.
4168 * pending.cs: Merged with the gmcs version.
4170 2006-09-15 Martin Baulig <martin@ximian.com>
4172 * statement.cs: Merge with the gmcs version.
4174 2006-09-15 Martin Baulig <martin@ximian.com>
4176 * statement.cs (Switch): Merge with the gmcs implementation
4177 (without nullables), which is newer.
4179 2006-09-15 Martin Baulig <martin@ximian.com>
4181 * statement.cs (Block.Variables): Make this public.
4182 (ToplevelBlock.Parameters): Make this a property.
4183 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
4185 2006-09-15 Martin Baulig <martin@ximian.com>
4187 * namespace.cs: Merge with the gmcs version.
4189 2006-09-15 Martin Baulig <martin@ximian.com>
4191 * decl.cs (MemberName): Minor code cleanups.
4193 2006-09-15 Martin Baulig <martin@ximian.com>
4195 * parameter.cs: Merge with the gmcs version.
4197 2006-09-15 Martin Baulig <martin@ximian.com>
4199 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
4200 and an error in mcs.
4202 2006-09-15 Martin Baulig <martin@ximian.com>
4204 * flowanalysis.cs: Merged from GMCS; added the generics code into
4205 a `GMCS_SOURCE' conditional so we can share this file.
4207 2006-09-08 Martin Baulig <martin@ximian.com>
4209 * typemanager.cs (TypeManager.interlocked_type): New public field.
4210 (TypeManager.int_interlocked_compare-exchange): New public field.
4211 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
4212 enumerator types here and call InitGenericCoreTypes().
4213 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
4214 after calling InitEnumUnderlyingTypes().
4217 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
4218 `classes_second_stage'.
4220 2006-09-14 Marek Safar <marek.safar@seznam.cz>
4222 * assign.cs, ecore.cs, expression.cs: Share error message text.
4223 * class.cs (FieldMember.Define): Check for varible of static type.
4224 * driver.cs (LoadAssembly): Uses error output for errors.
4225 * statement.cs: Updated.
4227 2006-09-08 Marek Safar <marek.safar@seznam.cz>
4229 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
4232 2006-09-07 Martin Baulig <martin@ximian.com>
4235 (MainDriver): Revert r62663 from Marek; see #70506 for details.
4237 2006-08-29 Miguel de Icaza <miguel@novell.com>
4239 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
4241 2006-08-17 Miguel de Icaza <miguel@novell.com>
4243 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
4244 #52019 and #79064, the use of the \uXXXX sequence in source code
4245 to represent unicode characters.
4247 2006-08-15 Marek Safar <marek.safar@seznam.cz>
4249 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
4251 * class.cs, ecore.cs, statement.cs: Merged to one error message.
4253 2006-08-13 Miguel de Icaza <miguel@novell.com>
4255 * assign.cs: Catch attempts to assign to a method groups in += and
4258 2006-08-13 Marek Safar <marek.safar@seznam.cz>
4261 * cs-parser.jay: Don't destroy current array type by typeof of array's.
4263 2006-08-12 Marek Safar <marek.safar@seznam.cz>
4265 * class.cs (Method.Define): Issue a warning when generic method looks like
4267 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
4270 2006-08-09 Marek Safar <marek.safar@seznam.cz>
4272 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
4274 * decl.cs (MemberCache.FindMembers): When container is interface we need to
4275 search all base interfaces as a member can be ambiguous.
4276 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
4277 Constructor member type filter.
4278 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
4279 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
4280 reporting for returned memberinfos.
4281 * report.cs: Updated.
4282 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
4283 version to work on all runtimes.
4284 (TypeManager.RealMemberLookup): Removed members filtering.
4286 2006-08-08 Raja R Harinath <rharinath@novell.com>
4288 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
4289 (PropertyExpr.EmitAssign): Likewise.
4290 * expression.cs (Indirection.EmitAssign): Likewise.
4291 (LocalVariableReference.EmitAssign): Likewise.
4292 (ParameterReference.EmitAssign): Likewise.
4293 (Invocation.EmitArguments): Likewise.
4294 (ArrayAccess.EmitAssign): Likewise.
4295 (IndexerAccess.EmitAssign): Likewise.
4296 (This.EmitAssign): Likewise.
4297 (ConditionalLogicalOperator.Emit): Likewise.
4300 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
4301 instead of ArrayList. If the hashtable has a LocalBuilder, don't
4302 leave it in after returning it.
4303 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
4305 2006-08-06 Marek Safar <marek.safar@seznam.cz>
4307 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
4310 2006-08-03 Raja R Harinath <rharinath@novell.com>
4312 Fix cs0146-3.cs and cs0146-4.cs.
4313 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
4314 enclosing types don't depend on the current type.
4316 2006-08-02 Raja R Harinath <rharinath@novell.com>
4319 * class.cs (TypeContainer.DoDefineMembers): Use
4320 FindBaseMemberWithSameName on Parent, since we're interested in
4321 whether we hide inherited members or not.
4322 (FindBaseMemberWithSameName): Make slightly more robust.
4324 Fix the non-generic testcase from #77396
4325 * decl.cs (DeclSpace.DeclContainer): Remove override.
4327 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
4328 declspaces for doppelgangers too.
4329 (UsingEntry): Implement IResolveContext.
4330 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
4331 'this' as the resolve context.
4332 (LocalAliasEntry): Likewise.
4334 Implement parts of #77403
4335 * roottypes.cs (RootDeclSpace): New. Used to represent the
4336 toplevel declaration space. Each namespace declaration introduces
4337 a "partial" root declaretion space.
4338 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
4339 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
4340 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
4341 from 'current_namespace.SlaveDeclSpace'.
4342 (namespace_declaration): Likewise.
4343 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
4344 check. It can't happen now.
4345 * decl.cs (DeclSpace.LookupType): Likewise.
4346 * driver.cs (MainDriver): Sanity check.
4348 2006-08-01 Raja R Harinath <rharinath@novell.com>
4350 * decl.cs (DeclSpace.FindNestedType): Remove.
4351 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
4352 LookupTypeContainer to get the container of the nested type.
4353 * class.cs (TypeContainer.FindNestedType): Make non-override.
4355 2006-07-31 Raja R Harinath <rharinath@novell.com>
4357 * decl.cs (DeclSpace.PartialContainer): Move field from ...
4358 * class.cs (TypeContainer.PartialContainer): ... here.
4359 (TypeContainer.AddBasesForPart): New helper.
4360 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
4362 * cs-parser.jay (current_class): Convert to DeclSpace.
4363 (struct_declaration, interface_declaration, class_declaration):
4364 Use AddBasesForPart instead of .Bases directly.
4365 * const.cs, iterators.cs: Update to changes.
4367 2006-07-28 Raja R Harinath <rharinath@novell.com>
4369 * class.cs (TypeContainer.AddMemberType): Rename from
4371 (TypeContainer.AddMember): Rename from AddToMemberContainer.
4372 (AddTypeContainer): New. Combine AddClassOrStruct and
4374 (AddPartial): Update. Add 'is_partial' argument.
4375 * roottypes.cs: Update to changes.
4376 * cs-parser.jay (push_current_class): New helper for handling
4377 current_container and current_class.
4378 (struct_declaration, interface_declaration, class_declaration):
4381 2006-07-26 Raja R Harinath <rharinath@novell.com>
4383 * roottypes.cs: Rename from tree.cs.
4385 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
4386 * tree.cs (Tree, ITreeDump): Remove types.
4387 * rootcontext.cs (tree, Tree): Remove fields.
4388 (root, ToplevelTypes): New.
4389 * *.cs: Update to rename.
4391 * tree.cs (Tree.RecordDecl): Remove.
4392 (RootTypes.AddToTypeContainer): Record the toplevel type in its
4394 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
4396 2006-07-23 Raja R Harinath <harinath@gmail.com>
4398 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
4399 DoFlowAnalysis and OmitStructFlowAnalysis here.
4400 (ec.With): Rename from WithUnsafe and generalize.
4401 (ec.WithCheckState): Remove. All users can be handled by 'With'.
4402 (ec.WithFlowAnalyis): New.
4403 * ecore.cs, expression.cs, statement.cs: Update.
4405 2006-07-22 Raja R Harinath <harinath@gmail.com>
4407 * statement.cs (Block.ResolveMeta): Simplify slightly.
4409 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
4410 multiple boolean fields. Convert InUnsafe, constant_check_state,
4411 check_state to flags.
4412 (CheckState, ConstantCheckState): Update.
4413 (InUnsafe): New read-only property.
4414 (FlagsHandle): Rename from CheckStateHandle and convert to handle
4416 (WithUnsafe): New helper similar to WithCheckState.
4417 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
4418 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
4420 2006-07-21 Raja R Harinath <rharinath@novell.com>
4422 Make comparisons use the same IL irrespective of whether they're
4423 in a 'checked' or 'unchecked' context: one of the issues in #78899
4424 * codegen.cs (EmitContext.CheckState): Make read-only property.
4425 (EmitContext.ConstantCheckState): Likewise.
4426 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
4427 helper that implement a save/restore stack for CheckState
4428 values. This is the only way to change check-state.
4429 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
4430 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
4431 (CheckedExpr.EmitBranchable): New forwarding method.
4432 (UnCheckedExpr): Likewise.
4433 * statement.cs (Block.ResolveMeta): Use WithCheckState.
4434 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
4435 (Checked.Resolve, checked.DoEmit): Likewise.
4437 2006-07-20 Miguel de Icaza <miguel@novell.com>
4439 * anonymous.cs: Cache the resolved anonymous delegate, and return
4440 this so that the ResolveTopBlock is only triggered once, not
4443 Currently we trigger ResolvetopBlock twice due to a first pass of
4444 argument check compatibility, and a second pass that does the
4447 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4449 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
4451 * rootcontext.cs (Reset): Add helper_classes.
4453 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4456 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
4459 2006-07-13 Miguel de Icaza <miguel@novell.com>
4461 * statement.cs (Lock): Handle expressions of type
4462 TypeManager.null_type specially. Fixes #78770
4464 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4466 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
4469 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4471 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
4472 for accessors as well.
4473 * ecore.cs (EventExpr): Add AccessorTable.
4475 2006-07-01 Marek Safar <marek.safar@seznam.cz>
4478 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
4479 for CS0122 where appropriate.
4480 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
4482 (Filter): Assembly can be null in the case of top level attributes.
4484 2006-06-25 Marek Safar <marek.safar@seznam.cz>
4488 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
4489 is done at global level.
4491 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4493 A fix for #77002, Implemented TypeForwarder support.
4495 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
4496 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
4497 * typemanager.cs (): Add type_forwarder_attr_type.
4499 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4501 * report.cs: Add CS0469 warning.
4503 2006-06-21 Martin Baulig <martin@ximian.com>
4505 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
4506 the `try'-block, so we also report CS0016 etc. there.
4508 2006-06-21 Martin Baulig <martin@ximian.com>
4511 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
4513 2006-06-21 Martin Baulig <martin@ximian.com>
4515 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
4516 also report CS1686 for parameters.
4518 2006-06-21 Martin Baulig <martin@ximian.com>
4520 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
4521 instead of an error if the value is not implicitly convertible to
4522 the switch types; fixes #77964.
4524 2006-06-21 Raja R Harinath <rharinath@novell.com>
4527 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
4528 FieldBuilder is null.
4531 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
4532 'left' and 'right' before error-checking.
4534 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
4536 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
4538 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
4539 (FieldExpr.DoResolve): likewise.
4540 (PropertyExpr.InstanceResolve): likewise.
4541 (EventExpr.InstanceResolve): likewise.
4543 2006-06-04 Marek Safar <marek.safar@seznam.cz>
4545 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
4546 attribute applicable tests for attribute argument.
4548 2006-06-02 Raja R Harinath <rharinath@novell.com>
4551 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
4552 (Binary.OverloadResolve_PredefinedIntegral): New.
4553 (Binary.OverloadResolve_PredefinedFloating): New.
4554 (Binary.OverloadResolve_PredefinedString): New.
4555 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
4556 Follow the standard more closely, and treat numeric promotions in
4557 terms of overload resolution.
4558 (Binary.CheckShiftArguments): Simplify.
4560 2006-06-01 Raja R Harinath <rharinath@novell.com>
4562 * flowanalysis.cs (MyBitVector): Simplify representation.
4563 (MyBitVector.Clone): Avoid allocating BitArray.
4564 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
4565 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
4566 (*): Update. Change all references to MyBitVector.And and
4567 MyBitVector.Or to &= and |=.
4569 2006-05-29 Raja R Harinath <rharinath@novell.com>
4572 * cs-parser.jay (formal_parameter_list): Extend the pattern below
4573 to param arguments too.
4575 2006-05-26 Miguel de Icaza <miguel@novell.com>
4577 * cs-parser.jay: Catch another parsing form for arglist being
4578 followed by other arguments. Fixes #78313.
4580 2006-05-24 Raja R Harinath <rharinath@novell.com>
4582 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
4583 checking of out parameters to ...
4584 (FlowBranchingToplevel.Merge): ... here.
4585 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
4586 set, propagate the origin upward, and only complain if there was
4588 (FlowBranchingException.AddContinueOrigin): Likewise.
4589 (FlowBranchingException.AddReturnOrigin): Likewise.
4590 (FlowBranchingException.AddGotoOrigin): Likewise.
4592 2006-05-23 Raja R Harinath <rharinath@novell.com>
4594 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
4595 unreachable, skip it.
4596 (FlowBranchingException.Merge): Always propagate jumps, even if
4597 the finally block renders subsequent code unreachable.
4599 2006-05-18 Raja R Harinath <rharinath@novell.com>
4602 * statement.cs (Goto.Resolve): Move responsibility for resolving
4603 'goto' to FlowBranching.AddGotoOrigin.
4604 (Goto.SetResolvedTarget): New. Callback to set the
4605 LabeledStatement that's the target of the goto.
4606 (Goto.DoEmit): Use Leave instead of Br when crossing an
4607 unwind-protect boundary.
4608 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
4609 LookupLabel and adjust to new semantics.
4610 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
4611 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
4612 Goto.SetResolvedTarget to update target.
4613 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
4614 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
4615 AddBreakOrigin & co. Delay propagation until ...
4616 (FlowBranchingException.Merge): ... this.
4618 * statement.cs (Block.Resolve): Always depend on flow-branching to
4619 determine unreachability. Kill workaround that originally emitted
4620 only one statement after an "unreachable" label (see infloop in
4623 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
4624 This is still "wrong", but anything better would probably need a
4625 multi-pass algorithm.
4626 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
4627 usage vector. Force current usage vector to be reachable, to
4628 optimistically signify backward jumps.
4629 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
4631 (FlowBranchingLabeled.Merge): New. If no backward jump was
4632 detected, return the original salted-away usage vector instead,
4633 updated with appropriate changes. Print unreachable warning if
4635 * statement.cs (Block.Resolve): Don't print unreachable warning on
4636 a labeled statement.
4638 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
4640 * driver.cs: Pass filename without path to AssemblyBuilder's
4641 AddResourceFile. Fixes bug #78407.
4643 2006-05-17 Raja R Harinath <rharinath@novell.com>
4645 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
4646 * flowanalysis.cs (FlowBranchingLabeled): ... here.
4647 (FlowBranching.MergeChild): Overwrite
4648 reachability information from Labeled branchings too.
4650 2006-05-16 Raja R Harinath <rharinath@novell.com>
4652 * statement.cs (Goto.Resolve): Merge jump origins here ...
4653 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
4655 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
4656 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
4657 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
4658 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
4660 * statement.cs (Goto.Resolve): ... not here.
4661 (Goto.Emit): Remove CS1632 check.
4663 2006-05-14 Marek Safar <marek.safar@seznam.cz>
4665 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
4668 2006-05-11 Raja R Harinath <rharinath@novell.com>
4670 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
4671 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
4672 (FlowBranchingException.Label): Likewise.
4674 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
4676 (MyBitVector.Or): Use it to avoid losing information (Count).
4677 (FlowBranching.MergeOrigins): Likewise.
4679 * flowanalysis.cs (UsageVector.IsDirty): Remove.
4680 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
4681 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
4682 (UsageVector.ToString): Simplify.
4683 (UsageVector.MergeSiblings): Move here from ...
4684 (FlowBranching.Merge): ... here.
4685 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
4688 2006-05-10 Raja R Harinath <rharinath@novell.com>
4690 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
4691 null bitvector is treated as all-true.
4693 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
4694 (MyBitVector): Rationalize invariants. 'vector != null' implies
4695 that we have our own copy of the bitvector. Otherwise,
4696 'InheritsFrom == null' implies all inherited bits are true.
4698 2006-05-09 Marek Safar <marek.safar@seznam.cz>
4700 * statement.cs (LocalInfo): Add IsConstant.
4701 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
4702 local variable for constants.
4704 2006-05-09 Raja R Harinath <rharinath@novell.com>
4706 * flowanalysis.cs (MyBitVector.Empty): New.
4707 (MyBitVector): Don't allow InheritedFrom to be null.
4708 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
4709 (UsageVector, FlowBranching): Update to changes.
4711 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
4712 recursion. The 'Parent == null' condition isn't sufficient for
4714 (FlowBranching.AddBreakOrigin): Likewise.
4715 (FlowBranching.AddContinueOrigin): Likewise.
4716 (FlowBranching.AddReturnOrigin): Likewise.
4717 (FlowBranching.StealFinallyClauses): Likewise.
4718 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
4719 (FlowBranching.CheckOutParameters): Likewise.
4720 (FlowBranchingToplevel): Terminate all the above recursions here.
4721 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
4722 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
4724 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
4726 (FlowBranchingToplevel): New. Empty for now.
4727 (FlowBranching.MergeTopBlock): Update.
4728 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
4729 branching for the anonymous delegate.
4730 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
4732 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
4733 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
4734 information at the start of the merge. Reorganize.
4736 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4738 * class.cs (MethodData.Define): Method cannot implement interface accessor.
4740 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4742 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
4743 to newly introduced ctor.
4745 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
4746 message to one place.
4747 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
4750 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4752 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
4754 * ecore.cs (Expression.ResolveAsConstant): Updated.
4756 * statement.cs (ResolveMeta): Updated.
4758 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4760 * cs-parser.jay: __arglist cannot be used in initializer.
4762 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4765 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
4768 2006-05-05 Raja R Harinath <rharinath@novell.com>
4770 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
4771 (LabeledStatement): Add 'name' parameter.
4772 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
4773 (Block.AddLabel): Update to changes.
4774 * cs-parser.jay (labeled_statement): Likewise.
4776 * flowanalysis.cs (BranchingType.Labeled): New.
4777 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
4778 (FlowBranchingLabeled): New. Does nothing for now, but will
4779 eventually handle 'goto' flows.
4780 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
4781 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
4782 that's terminated ...
4783 (Block.Resolve): ... here.
4785 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
4786 (UsageVector.MergeFinallyOrigins): Likewise.
4787 (FlowBranching.InTryOrCatch): Likewise.
4788 (FlowBranching.AddFinallyVector): Likewise.
4789 (FlowBranchingException): Update to changes.
4792 * statement.cs (Return.Resolve): Move error checking to ...
4793 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
4794 (FlowBranchingException): Handle return origins like break and
4796 (FlowBranching.UsageVector.CheckOutParameters): Remove.
4798 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4801 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
4804 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4807 * class.cs (MethodData.Define): Do public accessor check only when method
4808 implements an interface.
4810 2006-05-04 Raja R Harinath <rharinath@novell.com>
4812 Remove special handling of 'break'
4813 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
4814 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
4815 (UsageVector.Break): Remove.
4816 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
4818 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
4820 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
4821 UsageVector.Breaks (). Don't set NeedsReturnLabel.
4823 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4826 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
4827 be the interface member.
4829 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4832 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
4833 for emitting small (int) values.
4835 2006-05-03 Raja R Harinath <rharinath@novell.com>
4838 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
4839 control-flow passes through the 'finally' after merging-in all the
4840 control-flows from 'try' and the 'catch' clauses.
4842 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
4843 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
4844 always true at the only non-recursive entry point.
4845 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
4846 FlowBranchingBreakable.
4847 (FlowBranchingLoop): Remove.
4848 * statement.cs (Return.DoResolve): Update to changes.
4851 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
4852 (FlowBranching.CreateBranching): Handle it: create a
4853 FlowBranchingContinuable.
4854 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
4855 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
4856 except that it handles the 'continue' command.
4857 (FlowBranching.UsageVector.MergeOrigins): Rename from
4859 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
4860 except that it overrides AddContinueOrigin.
4861 (FlowBranchingException): Override AddContinueOrigin, similar to
4863 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
4864 Create a new branching around the embedded statement.
4865 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
4866 control flow after the embedded statement.
4867 (Continue.Resolve): Move all error checking to AddContinueOrigin.
4869 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
4870 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
4871 FlowBranchingBreakable.
4872 (FlowBranchingSwitch): Remove.
4875 * statement.cs (Break.Resolve): Simplify. Move responsibility for
4876 error reporting to ...
4877 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
4878 Rename from 'AddBreakVector'. Add new location argument. Return
4879 a bool indicating whether the 'break' crosses an unwind-protect.
4880 (FlowBranchingException.AddBreakOrigin): Add.
4881 (FlowBranchingException.Merge): Propagate 'break's to surrounding
4882 flowbranching after updating with the effects of the 'finally'
4884 (FlowBranchingBreakable): New common base class for
4885 FlowBranchingLoop and FlowBranchingSwitch.
4887 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
4889 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
4891 2006-05-02 Raja R Harinath <rharinath@novell.com>
4893 * statement.cs (Do.Resolve): If the loop is infinite, set the
4895 (While.Resolve, For.Resolve): Set a barrier after the embedded
4896 statement. There's no direct control flow that goes from the end
4897 of the embedded statement to the end of the loop.
4898 * flowanalysis.cs (FlowBranching.Infinite): Remove.
4899 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
4900 above ensure that the reachability is correctly computed.
4902 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
4903 (UsageVector.MergeBreakOrigins): If the current path is
4904 unreachable, treat it as if all parameters/locals are initialized.
4905 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
4906 infinite loops before merging-in break origins.
4908 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
4909 (Reachability.Reachable): Split part into ...
4910 (Reachability.Unreachable): ... this. Simplify.
4911 (Reachability.IsUnreachable): Use 'Unreachable' instead.
4913 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
4914 (Reachability.SetThrowsSometimes): Likewise.
4915 (FlowBranchingBlock.MergeTopBlock): Don't compare against
4916 TriState.Always, use corresponding property.
4917 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
4918 (Block.Resolve): Likewise. Remove some redundant checks.
4920 2006-05-02 Raja R Harinath <harinath@gmail.com>
4922 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
4923 (Reachability.Meet): Don't bother checking AlwaysThrows --
4924 barrier is always set.
4925 (FlowBranchingBlock.Merge): Likewise.
4927 2006-05-01 Raja R Harinath <harinath@gmail.com>
4929 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
4930 checks for unreachable.
4932 2006-05-01 Marek Safar <marek.safar@seznam.cz>
4935 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
4937 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
4938 whether field is really assigned.
4940 2006-04-30 Raja R Harinath <harinath@gmail.com>
4942 * flowanalysis.cs (Reachability): Make 4-argument constructor
4944 (Reachability.Meet): Rename from 'And'. Remove static variant.
4945 (Reachability.Always): Rename from the highly misleading
4946 'Reachability.Never'.
4947 (FlowBranching.Merge): Update to changes. Mark an impossible
4948 situation with a 'throw'.
4949 (*): Update to changes.
4951 2006-04-29 Raja R Harinath <harinath@gmail.com>
4953 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
4955 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
4956 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
4957 (*): Update to changes.
4958 * statement.cs: Update to changes.
4960 2006-04-28 Marek Safar <marek.safar@seznam.cz>
4963 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
4965 2006-04-28 Raja R Harinath <harinath@gmail.com>
4967 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
4970 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
4971 argument to two arguments: an usage-vector and a bool. Move call
4972 to FlowBranching.Merge () ...
4973 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
4975 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
4976 handling of loop and switch reachability to ...
4977 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
4979 2006-04-27 Raja R Harinath <harinath@gmail.com>
4981 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
4982 handling to FlowBranchingLoop.InLoop.
4983 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
4985 2006-04-26 Marek Safar <marek.safar@seznam.cz>
4988 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
4989 anonymous method is allowed from AnonymousContainer here.
4991 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
4993 2006-04-24 Raja R Harinath <rharinath@novell.com>
4996 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
4998 2006-04-23 Marek Safar <marek.safar@seznam.cz>
5001 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
5002 (DoubleConstant.Reduce): Ditto.
5004 2006-04-23 Raja R Harinath <rharinath@novell.com>
5006 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
5007 Remove 'lvalue_right_side' argument. Move parts to ...
5008 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
5009 (LocalVariable.DoResolveLValue): ... these.
5011 2006-04-21 Raja R Harinath <rharinath@novell.com>
5014 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
5015 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
5016 (LocalVariableReference.DoResolveBase): Use it to implement new
5018 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
5019 (Argument.Resolve): Simplify. Move CS1510 check ...
5020 * ecore.cs (Expression.ResolveLValue): ... here.
5021 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
5022 (PropertyExpr.DoResolveLValue): Likewise.
5023 (FieldExpr.Report_AssignToReadonly): Likewise.
5024 (FieldExpr.DoResolve): Add 'out_access' argument. Use
5025 LValueMemberAccess or LValueMemberOutAccess on instance depending
5027 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
5028 DoResolve as appropriate.
5030 2006-04-20 Raja R Harinath <rharinath@novell.com>
5033 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
5034 implicit conversions on 'out' and 'ref' arguments.
5036 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
5037 improve clarity. Remove dead code.
5040 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
5041 (Catch.Resolve): Resolve VarBlock if it exists.
5043 2006-04-19 Miguel de Icaza <miguel@novell.com>
5045 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
5046 twice, this was some residual code, the enumerator was emitted
5047 properly in the two branche of if later.
5049 2006-04-19 Raja R Harinath <rharinath@novell.com>
5051 * expression.cs (Cast.ResolveLValue): Remove. The result of a
5052 cast is never an lvalue.
5053 (Cast.DoResolve, Cast.ResolveRest): Combine.
5054 (Argument.Emit): Simplify slightly. Move 'Expr is
5055 IMemoryLocation' check ...
5056 (Argument.Resolve): ... here.
5057 (Argument.Error_LValueRequired): Remove. Inline into only user.
5059 Simplifications. Fix cs0191-2.cs
5060 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
5061 CS1649 and CS1651 to ...
5062 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
5063 the actual selection of the error code and message to a lookup
5064 table. Add a dummy return value to simplify callsites.
5065 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
5066 readonly fields of other instances of the same type. Move CS0197
5068 * expression.cs (Argument.Resolve): ... here. Simplify code.
5069 Ensure that ec.InRefOutArgumentResolving is only set during LValue
5070 resolution of an out or ref argument. The code simplification
5071 above uses this invariant.
5073 2006-04-18 Raja R Harinath <rharinath@novell.com>
5075 Possibly fix #77752. Fix cs1690-[4-7].cs.
5076 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
5077 CheckMarshallByRefAccess. Drop parameter.
5078 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
5080 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
5082 * report.cs (AllWarnings): Add CS1690.
5083 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
5085 (LocalVariableReference.DoResolveBase): Update.
5087 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5089 * class.cs (MethodOrOperator): Moved common parts from method class.
5090 detect obsolete attributes.
5091 (Method.Define): Simplified as it reuses code from base.
5092 (Constructor.ValidAttributeTargets): Fixed issue found during
5094 (Destructor.ValidAttributeTargets): Fixed issue found during
5096 (Operator): Finished refactoring set off by #78020. Operator class is now
5097 ordinary method class.
5099 * anonymous.cs: Updated.
5101 * decl.cs (DeclSpace): Add IsGeneric
5103 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5105 * class.cs (Constructor.Emit): Don't emit the attributes twice.
5107 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5109 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
5110 detect obsolete attributes.
5111 (Method.CreateEmitContext): Moved to MethodOrOperator.
5113 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5116 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
5117 customized exception to make crash detection easier.
5118 (MethodOrOperator): Started to work on new base class for methods and
5120 (Method): Derives from MethodOrOperator.
5121 (Constructor.Emit): Emits its own attributes.
5122 (AbstractPropertyEventMethod.Emit): Ditto.
5123 (Operator): Derives from MethodOrOperator, will refactor fully in extra
5125 (Operator.Emit): It's temporary more tricky than should be.
5127 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
5129 * report.cs (InternalErrorException): Add ctor with inner exception.
5131 2006-04-08 Marek Safar <marek.safar@seznam.cz>
5134 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
5137 2006-04-07 Marek Safar <marek.safar@seznam.cz>
5140 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
5143 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5145 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
5146 attribute is present and Guid not.
5147 (Interface.ApplyAttributeBuilder): Ditto.
5149 * attribute.cs: Add error message.
5151 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5155 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
5156 sources (it's composite) so hold them in extra array as they are used in
5157 Emit phase only. It worked in the previous versions by mistake.
5158 (Attribute.Emit): Emit attribute for more owners when exist.
5160 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
5161 it has now different behaviour.
5163 2006-04-04 Marek Safar <marek.safar@seznam.cz>
5165 * constant.cs (Constant.IsDefaultInitializer): New method.
5167 * class.cs: Updated.
5169 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
5170 re-initialize default values. It saves KBs almost for every assembly.
5171 Thanks Zoltan for the idea.
5172 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
5173 (ArrayCreation.DoResolve): Resolve only once.
5174 (ArrayCreation.Emit): Emit static initializer only when it is faster.
5175 (ArrayCreation.GetAttributableValue): Cope with optimized values.
5177 2006-04-03 Zoltan Varga <vargaz@gmail.com>
5179 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
5182 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5184 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
5185 in an embedded statement too.
5187 2006-04-01 Raja R Harinath <rharinath@novell.com>
5190 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
5192 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5196 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
5199 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
5201 2006-03-31 Marek Safar <marek.safar@seznam.cz>
5203 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
5206 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
5207 LocalTemporary change.
5209 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
5211 (ClassOrStruct.DefineFieldInitializers): Implemented static field
5212 initializers optimization.
5213 (ClassOrStruct.TypeAttr): Moved from modifiers.
5214 (Constructor.CheckBase): Don't crash when static ctor has parameters.
5215 (FieldBase.ResolveInitializer): Resolves initializer.
5216 (FieldBase.HasDefaultInitializer): New property.
5218 * cs-parser.jay: Removed message.
5220 * expression.cs (CompilerGeneratedThis): New specialization.
5222 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
5224 2006-03-28 Marek Safar <marek.safar@seznam.cz>
5226 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
5228 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5230 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
5231 be now EnumConstants only.
5233 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5235 * attribute.cs, driver.cs: Reset more caches.
5237 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5239 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
5241 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5243 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
5244 for easier reuse. Updated all overrides.
5245 (IntegralConstant): New base class for all integral constants.
5246 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
5247 of the constant range, report custom error.
5248 (UIntConstant.Reduce): Fixed uint conversion.
5250 * ecore.cs, literal.cs: Reduce updates.
5252 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5256 * class.cs (Constructor.Define): Removed extra if for default ctors.
5257 A patch from Atsushi Enomoto.
5259 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5261 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
5262 GetAttributableValue.
5264 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
5267 * convert.cs (ImplicitConversionRequired): Error message moved to
5270 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
5271 automatic implicit conversion of an output value.
5272 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
5274 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
5276 (TypeOf.GetAttributableValue): Add extra handling for object type.
5278 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
5279 special error message.
5281 2006-03-25 Marek Safar <marek.safar@seznam.cz>
5283 * class.cs (Constructor.Emit): Don't crash when struct ctor is
5285 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
5286 compatible with MS runtime.
5288 2006-03-23 Marek Safar <marek.safar@seznam.cz>
5290 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
5291 attribute arguments here.
5293 * class.cs (Indexer.Define): The check was moved to attribute class.
5295 2006-03-22 Marek Safar <marek.safar@seznam.cz>
5297 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
5298 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
5301 2006-03-22 Raja R Harinath <rharinath@novell.com>
5303 Support ParameterDefaultValueAttribute in gmcs. Also applied to
5304 mcs to keep code differences small.
5305 * attribute.cs (Attribute.GetParameterDefaultValue): New.
5306 * typemanager.cs (parameter_default_value_attribute_type): New.
5307 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
5310 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5312 * expression.cs (StringConcat.Append): Reverted back to no warning state.
5314 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5316 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
5318 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
5321 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
5323 * doc-bootstrap.cs : fix build.
5325 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5327 * expression.cs (StringConcat.Append): Issue a warning when empty string
5330 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5332 * assign.cs (CompoundAssign.ResolveSource): Removed.
5334 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
5337 * class.cs (TypeContainer.FindMethods): Removed.
5338 (TypeContainer.CheckMemberUsage): Made static.
5340 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
5342 * constant.cs (CheckRange): Removed unused type argument.
5343 (CheckUnsigned): Removed unused type argument.
5345 * cs-parser.jay: Updated after MemberAccess clean up.
5346 Uses Length for empty string test.
5348 * cs-tokenizer.cs: Uses Length for empty string test.
5349 (IsCastToken): Made static.
5350 (is_hex): Made static.
5351 (real_type_suffix): Made static.
5353 * decl.cs (SetupCache): Made static.
5354 (OnGenerateDocComment): Removed unused ds argument.
5356 * delegate.cs (VerifyDelegate): Removed unused argument.
5358 * doc.cs: Uses Length for empty string test.
5360 * driver.cs: Uses Length for empty string test.
5362 * enum.cs (IsValidEnumType): Made static
5364 * expression.cs (EnumLiftUp): Removed unused argument.
5365 (ResolveMethodGroup): Ditto.
5366 (BetterConversion): Ditto.
5367 (GetVarargsTypes): Ditto.
5368 (UpdateIndices): Ditto.
5369 (ValidateInitializers): Ditto.
5370 (MemberAccess.ctor): Ditto.
5371 (GetIndexersForType): Ditto.
5373 * flowanalysis.cs: (MergeFinally): Removed unused argument.
5375 * iterators.cs: Updated after MemberAccess clean up.
5377 * location.cs: Uses Length for empty string test.
5379 * namespace.cs: Uses Length for empty string test.
5381 * report.cs (CheckWarningCode): Made static.
5383 * statement.cs (LabeledStatement): Removed unused argument.
5385 * typemanager.cs (FilterNone): Removed.
5387 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5389 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
5392 * class.cs: Updated.
5394 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5396 * cs-parser.jay.cs: __arglist is not allowed for delegates.
5398 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5402 * expression.cs (VerifyArgumentsCompat): Reverted to double error
5403 reporting, it's more tricky than I thought.
5405 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5409 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
5411 (AnonymousMethod.ImplicitStandardConversionExists): New method.
5412 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
5413 Add more error reporting; Fixed issue with params.
5415 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
5417 * cs-parser.jay: AnonymousMethod requires host container.
5419 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
5421 2006-03-18 Raja R Harinath <harinath@gmail.com>
5423 * class.cs: Change 'TypeContainer ds' constructor argument to
5424 'DeclSpace parent'. Some classes were missed below due to
5425 different naming convention.
5427 * class.cs (MemberCore.Parent): Delete. This makes the
5428 ParentContainer changes below enforceable by the compiler.
5430 Treat pointers to enclosing declaration space as 'DeclSpace', not
5432 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
5433 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
5435 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
5437 (Block.AddThisVariable): Likewise.
5438 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
5439 (AbstractPropertyEventMethod.Emit): Likewise.
5440 (AbstractPropertyEventMethod.EmitMethod): Likewise.
5441 (GetMethod.Define, SetMethod.Define): Likewise.
5442 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
5443 (DelegateMethod.EmitMethod): Likewise.
5445 Fix regression test-partial-13.cs.
5446 Rationalize use of PartialContainer. Ensure that the partial
5447 class semantics can be tied to type-correctness, i.e., any
5448 violation will cause a compile error.
5449 * class.cs, const.cs: Access all fields that belong to class
5450 TypeContainer via ParentContainer. Arguments of EmitContexts and
5451 Resolve()-like functions still use 'Parent'.
5453 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
5454 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
5455 (PropertyMethod.CheckModifiers): Remove unused argument.
5456 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
5459 2006-03-17 Raja R Harinath <harinath@gmail.com>
5461 Make semantics of PartialContainer simpler.
5462 * decl.cs (DeclSpace.IsPartial): Remove.
5463 * class.cs (TypeContainer.IsPartial): Likewise.
5464 (TypeContainer..ctor): Set PartialContainer to point to self.
5465 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
5466 (TypeContainer.FindNestedType): Likewise.
5467 (MemberCore.ParentContainer): Simplify. Remove deprecation.
5469 2006-03-17 Marek Safar <marek.safar@seznam.cz>
5471 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
5473 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5475 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
5478 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5480 * class.cs (Operator.Define): An error for base conversion was not
5483 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
5485 * iterator.cs : yield break is allowed in try statement which has
5486 catch clauses. Fixed bug #77767.
5488 2006-03-13 Marek Safar <marek.safar@seznam.cz>
5490 A fix for #77593, #77574.
5492 * class.cs (MethodCore.CheckBase): Another if for operator.
5494 2006-03-09 Marek Safar <marek.safar@seznam.cz>
5496 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
5499 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
5500 (DelegateCreation.ImplicitStandardConversionExists): New method for just
5503 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
5506 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
5507 Updated after another emitcontext usage was clean up. It should help us to
5508 synchronize with gmcs easier.
5510 2006-03-04 Marek Safar <marek.safar@seznam.cz>
5514 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
5515 (Event.Define): ditto
5516 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
5518 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
5519 Removed redundant code and set NewSlot for Invoke method too.
5521 * parameter.cs (Parameters.ctor): Add custom, type ctor.
5522 (Parameters.MergeGenerated): New method. Use this method when you merge
5523 compiler generated argument with user arguments.
5525 2006-03-03 Marek Safar <marek.safar@seznam.cz>
5527 * attribute.cs (ResolveAsTypeTerminal): Removed.
5529 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
5530 specialization for predefined types; 30% speed up.
5531 Finally placed obsolete check to right place.
5532 (Expression.ResolveType): Removed.
5534 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
5535 Updated after ResolveType was removed.
5537 * expression.cs (Cast.ctor): Check void cast.
5538 (Binary.ResolveAsTypeTerminal): Is never type.
5539 (Conditional.ResolveAsTypeTerminal): Is never type.
5541 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
5543 2006-03-01 Raja R Harinath <rharinath@novell.com>
5546 * expression.cs (ParameterReference.DoResolveBase): Change return
5548 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
5552 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
5555 * typemanager.cs (GetFullNameSignature): Don't nullref on
5556 protected accessors.
5558 2006-02-27 Marek Safar <marek.safar@seznam.cz>
5560 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
5561 these two separated members to simplify the code.
5562 (Attribute.Resolve): Refactored to use new fields and methods.
5563 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
5564 implemented obsolete attribute checking.
5565 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
5566 implemented obsolete checking again. It look line never ending quest ;-)
5567 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
5569 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
5571 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
5573 *class.cs (Property.Define): Add RegisterProperty call.
5575 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
5576 argument groups (only 2).
5578 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
5579 encoding expression to arguments.
5580 (Expression.ExprClassToResolveFlags): Just turned to property.
5582 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
5583 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
5584 optimized as well as implemented support for zero-length attributes.
5586 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
5587 Add caching of PropertyInfo's.
5589 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5591 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
5592 error multiple times.
5594 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5596 New partial class implementation.
5597 A fix for #77027, #77029, #77403
5599 * attribute.cs (Attributable): Made attributes protected.
5601 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
5602 the replacements of ClassPart and PartialContainer.
5603 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
5604 (TypeContainer.AddInterface): Ditto.
5605 (TypeContainer.AddPartial): The main method for partial classes. It checks
5606 for errors and merges ModFlags and attributes. At the end class is added to
5608 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
5610 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
5611 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
5612 from the rest of partial classes.
5613 (TypeContainer.GetClassBases): Simplified.
5614 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
5616 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
5617 (TypeContainer.HasExplicitLayout): Uses Flags now.
5618 (PartialContainer): Removed.
5619 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
5620 (StaticClass): Was merged with Class.
5621 (Class.GetClassBases): class and static class bases are verified here.
5622 (Class.TypeAttr): Added static attributes when class is static.
5623 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
5624 (MemberBase): In some cases we need to call parent container for partial
5625 class. It should be eliminated but it's not easy now.
5627 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
5629 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
5630 partial classed to accumulate class comments.
5631 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
5633 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
5635 * driver.cs (MainDriver): Tree.GetDecl was removed.
5637 * modifiers.cs (Modifiers): Add partial modifier.
5639 * tree.cs (Tree.decl): Removed.
5640 (RootTypes): Started to use this class more often for root types
5643 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5647 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
5648 external interface does not have an attribute.
5650 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5652 Another prerequisites for new partial classs implementation.
5654 * attribute.cs (Attribute.Equal): Implemented.
5655 (Attribute.Emit): Changed as attributes can be applied more than twice.
5656 (Attributes.Emit): Check for duplicate attributes here.
5658 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
5659 as a parameter, clean-up.
5661 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5665 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
5666 contains obsolete attribute check which can in some cases look for base
5667 type of current class which is not initialized yet.
5668 (TypeContainer.BaseType): Replacement of ptype.
5670 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
5672 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5674 First of prerequisites for new partial classs implemention.
5676 * attribute.cs (Attributable): Extended by ResolveContext;
5677 Attributes finally have correct context for resolving in all cases.
5678 (AttachTo): Attribute owner is assigned here.
5680 * codegen.cs (IResolveContext): Introduce new interface to hold
5681 all information needed in resolving phase.
5682 (EmitContext): Implements IResolveContext; more clean-up needed here.
5684 * decl.cs (MemberCore): Implemented IResolveContext.
5686 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
5687 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
5688 parameter.cs, statement.cs, tree.cs, typemanager.cs:
5689 Refactored to use new IResolveContext instead of EmitContext; cleanup
5691 2006-02-06 Miguel de Icaza <miguel@novell.com>
5693 * codegen.cs (EmitScopeInitFromBlock): check here the
5694 capture_context, there is no need to make two calls to the
5697 * anonymous.cs: Add some debugging messages that might help me
5698 track other instances of this problem in the future (the
5699 regression of test 467).
5701 * cs-parser.jay: track the variable block, as we need to initalize
5702 any captured variables declared in this block for the "catch"
5703 portion of the "Try" statement.
5705 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
5706 scope initialization for captured variables.
5708 Also, move the emit for the variables after the block location has
5711 2006-02-06 Marek Safar <marek.safar@seznam.cz>
5713 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
5715 2006-02-02 Miguel de Icaza <miguel@novell.com>
5717 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
5718 commit yesterday, the initialization for the roots is necessary.
5719 What is not necessary is the scope activation.
5721 2006-02-02 Raja R Harinath <rharinath@novell.com>
5723 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
5724 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
5726 (Argument.Resolve): Remove CS0206 checks.
5728 2006-02-01 Miguel de Icaza <miguel@novell.com>
5730 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
5731 scopes for all the roots, the scopes will now be emitted when the
5732 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
5734 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
5735 code. This reduces a lot of existing cruft.
5737 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
5738 that the ScopeInfo is generated as we enter the scope, not at the
5739 time of use, which is what we used to do before.
5741 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
5742 every time a Block is about to be emitted if we have a
5745 2006-02-01 Raja R Harinath <rharinath@novell.com>
5747 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
5749 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
5751 * typemanager.cs (cons_param_array_attribute): Make private.
5752 (Reset): Set it to null.
5753 (InitCoreHelpers): Don't initialize it.
5754 (ConsParamArrayAttribute): New. Initialize it as needed.
5755 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
5757 2006-01-31 Miguel de Icaza <miguel@novell.com>
5759 * expression.cs: There might be errors reported during the
5760 selection of applicable methods. If there are errors, do not
5761 continue execution as it will lead the compiler to crash.
5763 2006-01-30 Miguel de Icaza <miguel@novell.com>
5765 * expression.cs: Member access is not allowed on anonymous
5766 methods. Fixes #77402.
5768 2006-01-30 Raja R Harinath <rharinath@novell.com>
5771 * cs-parser.jay (VariableDeclaration): Don't set
5772 current_array_type to null.
5773 (field_declaration, event_declaration, declaration_statement):
5774 Set it to null here.
5776 2006-01-28 Raja R Harinath <harinath@gmail.com>
5778 * typemanager.cs (GenericParameterPosition): New.
5781 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
5783 * doc.cs : To process "include" elements, first we should create
5784 another list than XmlNodeList, because it could result in node
5785 removal, which could result in that the XmlNodeList gives up
5788 (Also made code identical to gmcs again.)
5790 2006-01-25 Miguel de Icaza <miguel@novell.com>
5792 * ecore.cs: Introduce an error report that we were not catching
5793 before, if not silent, we must report the error. Gonzalo ran into
5796 2006-01-23 Miguel de Icaza <miguel@novell.com>
5798 A fix for bug: #76957
5800 * iterators.cs (MoveNextMethod.CreateMethodHost): call
5801 ComputeMethodHost before creating the method, this is a new
5804 * anonymous.cs (AnonymousContainer): Now we track all the scopes
5805 that this method references (RegisterScope). The actual scope
5806 where the method is hosted is computed with the ComputeMethodHost
5807 before we create the method.
5809 Moved the Deepest routine here.
5811 (AnonymousContainer.ComputeMethodHost): New routine used to
5812 compute the proper ScopeInfo that will host the anonymous method.
5814 (ScopeInfo): Deal with multiple roots. The problem was that we
5815 did not have a unique root where all ScopeInfos could be hanged
5816 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
5819 Remove AdjustMethodScope which is now computed at the end. Remove
5820 LinkScope which did a partial link, instead link all ScopeInfos
5821 before code generation from the new "LinkScopes" routine.
5823 Simplify all the Add* routines as they no longer need to maintain
5824 the tree, they just need to record that they are using variables
5827 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
5828 routines to produce the forest of ScopeInfo trees.
5830 * class.cs (TypeContainer.AppendMethod): This is just like
5831 AddMethod, but ensures that an interface implementation method
5832 (IEnumerable.XXX) is not inserted at the beginning of the queue of
5833 methods, but at the end.
5835 We use this functionality to ensure that the generated MoveNext
5836 method in the iterator class is resolved/emitted before the
5837 enumerator methods created.
5839 This is required because the MoveNext method computes the right
5840 ScopeInfo for the method. And the other methods will eventually
5841 need to resolve and fetch information computed from the anonymous
5844 2006-01-21 Raja R Harinath <harinath@gmail.com>
5845 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5848 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
5850 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
5851 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
5853 2006-01-18 Raja R Harinath <rharinath@novell.com>
5855 Fix #76656, cs0231-2.cs.
5856 * cs-parser.jay (formal_parameter_list): Make error case catch
5858 (parenthesized_expression_0): Add CS1026 check.
5859 (invocation_expression): Remove unused { $$ = lexer.Location }.
5861 2006-01-17 Raja R Harinath <rharinath@novell.com>
5864 * cs-parser.jay (statement_expression): Don't list out the
5865 individual statement-expressions. Convert syntax error into
5868 2006-01-16 Raja R Harinath <rharinath@novell.com>
5871 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
5872 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
5873 CheckIntermediateModification.
5874 (FieldExpr.DoResolve): Add new two-argument version that
5875 allows us to resolve the InstanceExpression as an lvalue.
5876 The one-argument variant is now just a wrapper.
5877 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
5878 Resolve the lhs as an lvalue if the it has a value type.
5879 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
5880 from Assign.DoResolve.
5881 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
5882 resolved as an lvalue.
5883 (PropertyExpr.DoResolve): Update.
5884 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
5885 has a value type. Move CS1612 check here from
5886 CheckIntermediateModification.
5887 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
5888 * expression.cs (EmptyExpression.OutAccess): New. Used as the
5889 'right_side' of a ResolveLValue on an 'out' argument.
5890 (EmptyExpression.LValueMemberAccess): New. Used as the
5891 'right_side' of a propagated ResolveLValue on a value type.
5892 (LocalVariableReference.DoResolveBase): Recognize
5893 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
5895 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
5896 EmptyExpression.Null.
5898 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
5900 * typemanager.cs : added IsGenericParameter(). In mcs it always
5902 * doc.cs : for generic parameters, use GenericParameterPosition,
5905 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
5907 * expression.cs: Fix Console.WriteLine ((this = x).foo);
5909 2006-01-12 Miguel de Icaza <miguel@novell.com>
5911 This fixes the problem where we used ldfld instead of ldflda to
5912 load the "THIS" pointer on captured parameters, when THIS is a
5913 value type. See bug #77205.
5915 * iterators.cs (CapturedThisReference.Emit): Pass false to
5916 EmitThis (we do not need the address).
5918 * codegen.cs (EmitThis): it needs to know whether we need the
5919 address of `this' or not. This is used by value types.
5921 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
5922 every other call passes false.
5924 2006-01-12 Raja R Harinath <rharinath@novell.com>
5927 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
5929 * expression.cs (Invocation.OverloadResolve): Update.
5930 (Invocation.DoResolve): Avoid double resolution of invocation.
5932 2006-01-11 Raja R Harinath <rharinath@novell.com>
5935 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
5936 unary negation of floating point types as 0-expr; negation cannot
5937 overflow in floating point types.
5940 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
5941 on operands of 'void' type.
5944 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
5945 and ExclusiveOr for boolean constants too.
5947 2006-01-09 Raja R Harinath <rharinath@novell.com>
5950 * expression.cs (Invocation.OverloadResolve): Replace reflected
5951 override methods with their base virtual methods, rather than
5953 * typemanager.cs (TypeManager.GetOverride): New.
5955 2006-01-05 Jb Evain <jbevain@gmail.com>
5957 * class.cs (Property.Define, Indexer.Define): do not tag the
5958 properties as SpecialName | RTSpecialName.
5960 2006-01-04 Miguel de Icaza <miguel@novell.com>
5962 * class.cs (MethodCore.IsDuplicateImplementation): This method was
5963 doing a low-level comparission of parameter types. It was lacking
5964 a check for __argslist.
5966 2005-12-30 Miguel de Icaza <miguel@novell.com>
5968 * expression.cs (ParameterReference.DoResolveBase): Allow
5969 reference parameters if they are local to this block.
5971 This allows the ref and out parameters of a delegate to be used in
5972 an anonymous method, for example:
5974 delegate void set (out int x);
5976 set s = delegate (out int x){
5980 This is used by functionality introduced late in the C# language.
5982 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
5983 method that take ref and out parameters.
5985 Fixes #77119 which was a late change in the spec.
5987 2005-12-23 Miguel de Icaza <miguel@novell.com>
5989 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
5990 parent if its the same scope. Fixes #77060.
5992 2005-12-21 Miguel de Icaza <miguel@novell.com>
5994 * driver.cs: Report the case of no source files and no -out:
5997 2005-12-20 Raja R Harinath <rharinath@novell.com>
6000 * expression.cs (ComposedCast.GetSignatureForError): Define.
6002 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6006 * namespace.cs (NamespaceEntry): Add extern_aliases as a
6007 ListDictionary, to contain the ExternAliasEntry entries (in
6008 addition to the NamespaceEntry.aliases hashtable). This field is
6009 shared between the original entry and its doppelganger (bodyless
6011 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
6012 extern_aliases field.
6013 (NamespaceEntry.Lookup): Move the IsImplicit check after the
6014 lookup in extern_aliases.
6016 2005-12-16 Raja R Harinath <rharinath@novell.com>
6019 * class.cs (TypeContainer.Mark_HasEquals): New.
6020 (TypeContainer.Mark_HasGetHashCode): New.
6021 (ClassPart): Override them.
6022 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
6025 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
6026 'parent' argument to the base constructor.
6028 Remove all mention of TypeContainer from decl.cs.
6029 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
6030 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
6031 (DeclSpace.DeclSpace): Likewise.
6032 (DeclSpace.DefineMembers): Remove unused argument.
6033 * cs-parser.jay (pop_current_class): Update to changes. Simplify
6034 debugging check -- we don't care if the debug code throws an
6035 InvalidCastException instead of an InternalErrorException.
6036 * class.cs (TypeContainer.DefineMembers): Update to changes.
6037 (TypeContainer.DoDefineMembers): Likewise.
6038 (TypeContainer.GetMethods): Likewise.
6039 (PropertyMember.Define): Likewise.
6040 (MemberBase.Parent): New property that forwards to
6041 MemberCore.Parent, but ensures that we get a TypeContainer.
6042 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
6043 (RootContext.PopulateTypes): Likewise. Remove special case code
6044 for !RootContext.StdLib: DefineMembers is idempotent.
6046 2005-12-14 Miguel de Icaza <miguel@novell.com>
6048 * convert.cs (ExplicitConversionCore): Check the return value from
6049 ExplicitConversionCore which can return null on failure. Fixes #76914
6051 2005-12-13 Marek Safar <marek.safar@seznam.cz>
6053 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
6055 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
6057 * doc.cs : The search for referenced namespace was insufficient to
6058 get global one as it used to do. Fixed bug #76965.
6060 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
6062 * doc.cs : check name in cref in the last phase that whether it is
6065 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6067 * cs-tokenizer.cs : reverted the latest change: it somehow broke
6070 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6072 * doc.cs : so it turned out that we cannot skip override check for
6073 interface members. Fixed bug #76954.
6075 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6077 * cs-tokenizer.cs : fixed bug #75984:
6078 - #warning and #error should not be handled when the source line
6080 - #line is not checked strictly when the source line is disabled.
6081 - #define and #undef is on the other hand checked strictly at any
6084 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
6086 * cs-tokenizer.cs : missing Location (actually, filename) in one of
6089 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6091 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
6093 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
6095 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
6096 (FieldBase.Initializer): Initializer is now optional.
6097 (EventField.Define): Only event field can have initializer.
6099 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
6101 * const.cs (Const): Reuse initializer.
6103 * cs-parser.jay: Updated after FieldBase changes.
6104 Added current_array_type to simplify array initializers.
6106 * ecore.cs (NullCast.IsDefaultValue): Implemented.
6108 * expression.cs, iterators.cs: Updated.
6110 * namespace.cs (NamespaceEntry): Made UsingFound private.
6112 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6114 * parameterCollection.cs: Obsolete, removed.
6115 * parser.cs: Obsolete, removed.
6117 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6120 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
6122 * enum.cs (Enum.Define): Set obsolete context here.
6124 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6127 - FindDocumentedMember() now expects 1) paramList as null
6128 when "we don't have to check the number of parameters" and
6129 2) Type.EmptyTypes when "there is no arguments".
6130 - Introduced FoundMember struct to hold the exact type which was
6131 used to find the documented member (the above change broke
6132 test-xml-044; it might be better just to use DeclaringType than
6133 what MS does, like this change does, but it depends on usage.)
6135 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6137 * doc.cs : documented member might be from DeclaringType for nested
6138 types. Fixed bug #76782.
6140 2005-12-03 Ben Maurer <bmaurer@ximian.com>
6142 * anonymous.cs: Have the param code handle leaving copies on the
6143 stack etc. Allows anonymous params to take part in the assignment
6144 code (++, +=, etc). Fixes bug #76550
6146 * expression.cs: Handle the prepare_for_load/leave_copy by passing
6147 it down to the anon code.
6149 * iterators.cs: Use dummy var here
6151 * codegen.cs: Handle new vars
6153 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6156 * class.cs (MethodData.Define): Set proper Obsolete context.
6158 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
6160 (FieldExpr.DoResolve): Ditto.
6162 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6165 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
6166 parent is not obsolete.
6168 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
6170 * doc.cs : (FindDocumentedMember) find parameterless members first
6171 and get CS0419 in the early stage. Fixed first case of bug #76727.
6173 2005-11-30 Marek Safar <marek.safar@seznam.cz>
6176 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
6177 no error was reported.
6179 *expression.cs (Binary.DoResolve): left can be null.
6181 2005-11-22 Marek Safar <marek.safar@seznam.cz>
6184 * class.cs (MethodData.Emit): Parameters should be labeled first.
6186 2005-11-21 Marek Safar <marek.safar@seznam.cz>
6189 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
6191 2005-11-18 Marek Safar <marek.safar@seznam.cz>
6193 * attribute.cs (AreParametersCompliant): Moved to Parameter.
6195 * class.cs (MethodCore): Parameter clean up.
6196 (IMethodData): Added ParameterInfo.
6197 (MethodData): Parameter clean up.
6198 (Indexer.Define): Parameter clean up.
6210 * typemanager.cs: Parameter clean up.
6212 * delegate.cs (Define): Get rid of duplicated code.
6214 * expression.cs (ParameterReference): Removed useless parameters
6216 (Invocation): Ditto.
6218 * parameter.cs (ParamsParameter): New class, params specialization.
6219 (ArglistParameter): Attemp to separate arglist.
6220 (Parameter): Refactored to be reusable and faster.
6221 (Parameter.Modifier): Made understandable.
6222 (Parameters): Changed to be used as a class for `this' assembly
6223 parameters. Refactored to use new specialized classes.
6225 * support.cs (ParameterData): Added Types property.
6226 (InternalParameters): Deleted.
6228 2005-08-20 Martin Baulig <martin@ximian.com>
6230 Merging this patch from GMCS to fix #75867.
6232 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6233 scope if we don't already have it.
6235 2005-11-17 Martin Baulig <martin@ximian.com>
6238 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
6239 inherit the scope from our parent. Fixes #76653.
6241 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6243 * doc.cs : the previous patch does not actually fix the bug.
6244 PropertyInfo override check is now implemented and really fixed it.
6245 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
6247 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6249 * doc.cs : apply "override filter" also to properties.
6252 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6254 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
6255 no need to check overrides. For classes, omit those results from
6256 interfaces since they must exist in the class. Fixed bug #76726.
6258 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6260 * typemanager.cs : (GetFullNameSignature) differentiate indexers
6261 with different parameters. Fixed the second problem in #76685.
6263 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6265 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
6266 get expected 'protected' access in CheckValidFamilyAccess()).
6269 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6271 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
6272 Fixed bug #76705. CS1569 was incorrectly commented out.
6274 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6276 * doc.cs : use Invocation.IsOverride() to do real override check.
6277 * expression.cs : made Invocation.IsOverride() internal.
6279 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6281 * doc.cs : use TypeManager.FindMembers() instead of (possible)
6282 TypeBuilder.FindMembers() and filter overriden base members out.
6285 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6287 * doc.cs : ref/out parameters are represented as '@' (instead of
6288 '&' in type FullName). Fixed bug #76630 (additionally crefs).
6290 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6292 * doc.cs : when there was no '.' in cref to methods in doc comment,
6293 then parameters were missing in the output. Fixed bug #76691.
6295 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6297 * driver.cs : don't output docs when there is an error.
6300 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6303 Now it should detect indexers. Fixed primary concern in bug #76685.
6304 Fixed CS0419 message to not show the identical member signature in
6307 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6309 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
6310 instead of Type.FindMembers() since it does not handle events.
6313 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
6315 * codegen.cs: Fixed typo (speficied -> specified).
6317 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6320 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
6322 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6324 * attribute.cs: Changed error message.
6326 * cs-tokenizer.cs: One more check.
6328 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6330 * statement.cs (Block.Resolve): Ignore empty statement.
6332 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6334 * report.cs: Made error/warning methods more strict to avoid
6337 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
6338 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
6339 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
6340 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
6342 2005-11-08 Marek Safar <marek.safar@seznam.cz>
6344 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
6345 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
6347 * class.cs (TypeContainer.IsComImport): New property.
6348 (Constructor.Define): Create proper ctor for ComImport types.
6350 * expression.cs (New.CheckComImport): Fixed.
6352 2005-11-07 Miguel de Icaza <miguel@novell.com>
6354 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
6355 that a parameter has been captured does not mean that we do not
6356 have to do the rest of the processing. This fixes the second part
6357 of #76592. If there was another anonymous method capturing
6358 values in the past, the Scope would never be set for the second
6359 method that captured the same parameter.
6361 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
6362 properly manipulate the stack. Second part of fix for #76592.
6364 * expression.cs (New): Add support for invoking "new" on
6365 interfaces that have been flagged with the ComImport attribute and
6366 the CoClass. Fixes #76637
6368 * statement.cs (Try.DoEmit): When a variable is captured, do not
6369 try to emit the vi.LocalBuilder variable as it has been captured.
6370 Create a temporary variable and store the results on the
6371 FieldBuilder. Fixes #76642
6373 2005-11-07 Marek Safar <marek.safar@seznam.cz>
6375 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
6377 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
6379 * expression.cs (Binary.DoResolve): Added && optimalization.
6381 * typemanager.cs (AddUserType): Removed useless argument.
6383 2005-11-04 Marek Safar <marek.safar@seznam.cz>
6385 * statement.cs (Block.variables): Uses ListDictionary.
6387 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6390 * class.cs (PartialContainer.EmitType): Customized to emit
6391 security attributes.
6392 (ClassPart.ApplyAttributeBuilder): Transform security attribute
6393 for partial classes.
6395 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6398 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
6399 access has to be fixed.
6401 * typemanager.cs (IsUnmanagedType): Wrong common field type.
6403 2005-11-01 Marek Safar <marek.safar@seznam.cz>
6406 * ecore.cs (NullCast.Reduce): Implemented.
6408 * expression.cs (ArrayCreation.CheckIndices): Correcly check
6411 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
6413 (Foreach.Resolve): Catch null properly.
6415 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6417 * cs-tokenizer.cs: Warning text fix.
6419 * driver.cs: AllWarningNumbers exposed on public interface.
6421 * report.cs (): Reviewed warning numbers.
6422 (IsValidWarning): Use binary search.
6424 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6426 * driver.cs: Implemeted resource visibility.
6427 (Resources): New class for code sharing between /res: and
6430 2005-10-28 Marek Safar <marek.safar@seznam.cz>
6433 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
6436 * convert (Convert.ImplicitReferenceConversion): NullCast holds
6439 * ecore.cs (NullCast): Child is contant only.
6441 * literal.cs (NullLiteral.Reduce): null can be converted to any
6444 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
6446 * driver.cs: Use Encoding.Default as default code page instead
6449 2005-10-27 Raja R Harinath <rharinath@novell.com>
6452 * expression.cs (Invocation.Error_InvalidArguments): Handle
6453 __arglist parameters.
6454 (Invocation.VerifyArgumentsCompat): Likewise.
6455 * support.cs (ReflectionParameters.GetSignatureForError): Print
6456 __arglist parameters.
6457 (InternalParamters.GetSignatureForError): Likewise.
6458 * parameter.cs (Parameters.GetSignatureForError): Likewise.
6460 2005-10-26 Marek Safar <marek.safar@seznam.cz>
6462 * attribute.cs (GetPropertyValue): Made public.
6464 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
6466 Add new property WrapNonExceptionThrows to handle 2.0 assembly
6468 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
6471 * driver.cs: Reflect method name change.
6473 * statement.cs (Try.Resolve): Warn when try has both general
6476 * typemanager.cs: runtime_compatibility_attr_type new predefined
6479 2005-10-26 Raja R Harinath <harinath@gmail.com>
6482 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
6483 treat it as an empty parameter list.
6485 2005-10-26 Raja R Harinath <rharinath@novell.com>
6488 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
6489 ResolveAsTypeStep silent.
6490 * statement.cs (Block.AddConstant): Mark block as used.
6491 (Block.ResolveMeta): Avoid piling on error messages
6492 if a constant initializer resolution fails.
6494 2005-10-25 Raja R Harinath <rharinath@novell.com>
6496 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
6498 (NamespaceEntry.VerifyAllUsing): New.
6499 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
6500 behaviour. Delegates actual resolution of alias to ...
6501 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
6502 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
6504 * driver.cs (Driver.MainDriver): Update.
6506 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
6507 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
6509 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
6511 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
6512 RootNamespace.DefineNamespacesForAll.
6514 2005-10-24 Raja R Harinath <harinath@gmail.com>
6516 * typemanager.cs (assemblies, external_aliases, modules)
6517 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
6518 (ComputeNamespaces, GetRootNamespace): Remove extra staging
6519 overhead. Move resposibility ...
6520 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
6521 * driver.cs, attribute.cs, codegen.cs: Update to changes.
6523 2005-10-23 Raja R Harinath <harinath@gmail.com>
6525 * namespace.cs (RootNamespace.all_namespaces): Renamed from
6526 cached_namespaces. Improve usage.
6527 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
6528 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
6529 Move from GlobalRootNamespace and simplify.
6530 (RootNamespace.Global): Make instance variable.
6531 (RootNamespace.RootNamespace): Add "alias name" parameter.
6532 (GlobalRootNamespace): Simplify drastically.
6533 (Namespace.Lookup): Don't use GetNamespace.
6534 * typemanager.cs (GetRootNamespace): Rename from
6535 ComputeNamespaceForAlias.
6536 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
6538 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6540 * anonymous.cs (AnonymousContainer): Don't crash when container
6543 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6545 * expression.cs (Binary.DoResolve): Warn when comparing same
6548 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6551 * expression.cs (Binary.DoResolve): It looks like there are no
6552 convetsion rules in enum context.
6554 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6556 Add support for extern alias qualifiers.
6557 * typemanager.cs: Move some LookupTypeReflection code
6558 to namespace.cs, to have cleaner code. Added some methods
6559 to help us keep track of the extern aliased references.
6560 * driver.cs: Add suport for extern alias assemblies on command
6561 line and check for their warnings/errors. Also keep track of the
6562 extern aliased assemblies.
6563 * namespace.cs: Move the global functionality of Namespace
6564 to GlobalRootNamespace/RootNamespace. Now the global namespace
6565 is GlobalRootNamespace.Globa. Also the code moved from
6566 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
6567 Finally added LocalAliasEntry (AliasEntry before) and
6568 ExternAliasEntry, to handle alias statements.
6569 * cs-parser.jay: Add support in the grammar for extern alias
6571 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
6572 Update callings to Namespace (now in GlobalRootNamespace).
6574 2005-10-18 Raja R Harinath <rharinath@novell.com>
6577 * class.cs (TypeContainer.DefineType): Move updating of
6578 topological sort earlier in the code.
6579 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
6581 2005-10-18 Marek Safar <marek.safar@seznam.cz>
6584 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
6586 * constant.cs (Constant.TryReduce): Moved from Cast class.
6587 (Reduce): Made little bit more OO and fixed missing conversions.
6589 * ecore.cs (Reduce): Implemented.
6590 (Binary.EnumLiftUp): New method to upgrade values to enum values.
6592 * literal.cs (Reduce): Implemented.
6594 * class.cs: Reverted Miguel's wrong commit.
6596 2005-10-14 Miguel de Icaza <miguel@novell.com>
6598 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
6600 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
6602 * cs-parser.jay, expression.cs : CS0214 was missing error location
6603 for constants. Fixed bug #76404.
6605 2005-10-11 Marek Safar <marek.safar@seznam.cz>
6608 * convert.cs (ExplicitConversionCore): Fixed object->enum
6611 2005-10-10 Raja R Harinath <rharinath@novell.com>
6613 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
6615 (PropertyExpr.EmitCall): Likewise.
6616 * expression.cs (Invocation.EmitArguments): Handle case where
6618 (Invocation.EmitCall): Avoid allocating temporary variable if
6619 there are no arguments.
6621 2005-10-07 Raja R Harinath <rharinath@novell.com>
6624 * convert.cs (ImplicitConversionStandard): Move conversion of
6625 void* to arbitrary pointer types ...
6626 (ExplicitConversionStandard): .. here.
6627 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
6628 error to always print typenames.
6630 2005-10-07 Raja R Harinath <rharinath@novell.com>
6632 * convert.cs (GetConversionOperator): Rename from
6633 GetConversionOperators. Move operator selection code from ...
6634 (UserDefinedConversion): ... here.
6636 2005-10-06 Marek Safar <marek.safar@seznam.cz>
6638 * convert.cs (ExplicitConversionCore): Removed duplicate enum
6641 2005-10-05 Marek Safar <marek.safar@seznam.cz>
6643 * assign.cs (Assign.DoResolve): Error method changed.
6645 * cfold.cs (DoConstantNumericPromotions): Error method changed.
6647 * const.cs (ResolveValue): Reset in_transit immediately.
6649 * constant.cs: Error method changed.
6651 * convert.cs: Removed useless location parameter.
6652 (ExplicitNumericConversion): Don't do double enum check.
6653 (ExplicitConversionCore): Renamed from ExplicitConversion.
6654 (ExplicitUnsafe): Extracted from ExplicitConversion.
6655 (ExplicitConversion): Uses for error reporting.
6657 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
6659 (ResolveBoolean): Uses common error method.
6660 (CastToDecimal): Get rid of ec.
6661 (CastFromDecimal): Optimized.
6662 (ConvCast): Get rid of ec.
6664 * enum.cs (ResolveValue): Reset in_transit immediately.
6665 (Emit): Return after first error.
6667 * expression.cs: Convert changes.
6669 * literal.cs: Error method changed.
6671 * statement.cs: Error method changed.
6673 2005-10-03 Raja R Harinath <rharinath@novell.com>
6675 * support.cs (SeekableStreamReader.Position): Don't error out when
6676 the requested position is just beyond the end of the current
6679 2005-09-28 Raja R Harinath <rharinath@novell.com>
6681 * support.cs (SeekableStreamReader): Simplify drastically. Don't
6682 try to keep in sync with the byte count of the underlying Stream.
6683 However, this limits us to a window size of 2048 characters: i.e.,
6684 the maximum lookahead of our lexer/parser can be 2048 characters.
6686 2005-09-28 Marek Safar <marek.safar@seznam.cz>
6689 * driver.cs: Fix compilation files with full root path.
6691 2005-09-25 Miguel de Icaza <miguel@novell.com>
6693 * report.cs (SymbolRelatedToPreviousError): Format the output so
6694 it does not use an open parenthesis that is never closed.
6696 * driver.cs: Follow coding guidelines
6698 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6701 * const.cs (Const.ResolveValue): Check for assigning non-null
6702 value to reference type.
6704 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6706 * anonymous.cs: Implemented ExprClassName.
6708 * assign.cs (Assign.DoResolve): Don't chrash when type is not
6711 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
6714 * class.cs (StaticClass.DefineContainerMembers): Report protected
6717 * codegen.cs: if(ed) PRODUCTION.
6719 * convert.cs (Error_CannotImplicitConversion): Better error
6722 * cs-parser.jay: More error checks.
6724 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
6726 * driver.cs (CSCParseOption): Enabled wrong option check.
6728 * ecore.cs (Expression.ExprClassName): Turned to property.
6729 (MemberExpr.CheckIntermediateModification): For checking boxed
6730 value types modification.
6732 * statement.cs (Fixed.Resolve): Expression type must be
6733 convertible to fixed type.
6734 (CollectionForeach.GetEnumeratorFilter,TryType):
6735 Small refactoring for easier error checking.
6737 2005-09-26 Marek Safar <marek.safar@seznam.cz>
6739 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
6742 * class.cs (GeneratedBaseInitializer): New class for customization
6743 compiler generated initializers.
6744 (MemberBase.DoDefine): Check Obsolete attribute here.
6745 (FieldMember.DoDefine): Ditto.
6747 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
6750 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
6751 (MemberCore.GetObsoleteAttribute): Removed argument.
6752 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
6753 (MemberCore.CheckObsoleteType): New helper.
6757 * statement.cs: Updates after MemberCore changes.
6759 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
6760 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
6762 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
6763 obsolete attribute for compiler construct.
6764 (As.DoResolve): Cache result.
6766 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
6768 2005-09-26 Raja R Harinath <rharinath@novell.com>
6771 * expression.cs (This.VerifyFixed): In a value type T, the type of
6772 'this' is T&, iow, 'this' is either an out or ref parameter. In a
6773 value type R, 'this' is treated as a value parameter.
6775 2005-09-22 Miguel de Icaza <miguel@novell.com>
6777 * statement.cs (Lock): Use the TemporaryVariable class instead of
6778 manually using local variables as those do not work when variables
6781 * ecore.cs: Moved the TemporaryVariable class from being a nested
6782 class inside Foreach to be a public class that can be employed in
6785 2005-09-19 Marek Safar <marek.safar@seznam.cz>
6787 * cs-parser.jay: interface_accessors replaced by
6788 accessor_declarations.
6790 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
6793 * statement.cs (GotoCase.Resolve): Convert null constant to
6795 (SwitchLabel.ResolveAndReduce): Ditto.
6796 (SwitchLabel.NullStringCase): Custom null stamp.
6797 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
6799 typemanager.cs (CSharpSignature): Don't skip first argument
6802 2005-09-18 Miguel de Icaza <miguel@novell.com>
6804 * driver.cs: Set InEmacs based on the environment variable EMACS.
6806 * location.cs (InEmacs): in this mode, do not report column
6807 location as it confuses Emacs.
6809 2005-09-16 Marek Safar <marek.safar@seznam.cz>
6811 * cfold.cs, constant.cs, convert.cs, ecore.cs,
6812 expression.cs, iterators.cs, literal.cs: Store constants and
6815 * class.cs (MemberBase.ShortName): Pass location.
6817 * cs-parser.jay: Some location fixes.
6819 * ecore.cs (Expression.Location): Made virtual.
6821 2005-09-05 Miguel de Icaza <miguel@novell.com>
6823 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
6824 if the underlying types are the same, otherwise we need to produce
6825 code that will do the proper cast.
6827 This was exposed by Marek's constant rewrite which produced
6828 invalid code for the call site:
6831 void Method (X v) {}
6835 This fixes test-49.cs
6837 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6839 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
6840 Type/Object should be allowed as well. Fixed bug #75968.
6842 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6844 * expression.cs : (Binary.DoResolve): when one is enum constant and
6845 another is constant 0, then return enum one *as enum type*.
6848 2005-09-02 Raja R Harinath <rharinath@novell.com>
6850 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
6854 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
6855 flow-branching for LocalVariableReferences in case we were invoked
6856 from a MemberAccess.
6857 * expression.cs (LocalVariableReference.VerifyAssigned): New.
6859 (LocalVariableReference.DoResolveBase): ... this.
6860 (MemberAccess.Resolve): Do the check that was disabled during
6863 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6866 (PartialContainer.Create): check abstract/sealed/static strictly
6867 but abstract/sealed can exist only at one side. Fixed bug #75883.
6869 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
6872 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
6873 specified, don't default to UnmanagedType.I4.
6875 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6877 * expression.cs : conditional operator should check possibly
6878 incorrect assign expression. Fixed bug #75946.
6880 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6882 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
6883 Reverting the change. gmcs is much complex than mcs on this matter.
6885 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6887 * cs-tokenizer.cs : To read another token ahead of the actual
6888 consumption, use new SavedToken and cache token instead of moving
6889 back the stream with SeekableStreamReader (it seemed problematic).
6891 driver.cs : Thus use StreamReader directly.
6892 * support.cs : Thus removed SeekableStreamReader.
6894 2005-08-30 Raja R Harinath <rharinath@novell.com>
6897 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
6898 (ScopeInfo.EmitScopeType): Use it to construct field names from
6899 names of captured locals.
6902 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
6903 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
6904 Pass 'target_type' to BoxedCast. Don't default to 'object'.
6905 (ExplicitConversion): Remove enum cases already handled by
6906 implicit conversion. Move implicit conversion check to the beginning.
6907 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
6908 * expression.cs (ArrayCreation.EmitDynamicInitializers):
6909 Don't treat System.Enum as a struct.
6911 2005-08-30 Jb Evain <jbevain@gmail.com>
6913 * attribute.cs: handles as expression in parameters.
6915 2005-08-30 Raja R Harinath <rharinath@novell.com>
6918 * class.cs (TypeContainer.VerifyClsName): Don't use a
6919 PartialContainer when verifying CLS compliance.
6920 (AbstractPropertyEventMethod): Set Parent here, ...
6921 (PropertyMethod): ... not here.
6923 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
6925 * attribute.cs : escaped attribute name should not be allowed to be
6926 resolved (e.g. @class as classAttribute). Fixed bug #75930.
6928 2005-08-29 Raja R Harinath <rharinath@novell.com>
6931 * convert.cs (ImplicitStandardConversionExists): Allow zero also
6932 when converting a long constant to unsigned long.
6933 * expression.cs (Invocation.OverloadResolve): Add sanity check to
6934 detect where IsApplicable and VerifyArgumentsCompat disagree.
6936 2005-08-29 Raja R Harinath <rharinath@novell.com>
6937 and Carlos Alberto Cortez <carlos@unixmexico.org>
6940 * class.cs (TypeContainer.CanElideInitializer): New helper.
6941 (TypeContainer.EmitFieldInitializers): Use it to determine if we
6942 can safely emitting the initializer of a field.
6944 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6946 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
6947 allowed inside a switch (without loop). Fixed bug #75433.
6949 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
6951 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
6952 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
6954 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6956 * driver.cs : kinda reverting the default encoding changes (not exact
6957 revert since I noticed that "codepage:reset" might not work fine).
6959 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6961 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
6962 Location. Now getter and setter store location correctly.
6963 (errors/cs0111-12.cs now reports the expected location.)
6965 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6967 * driver.cs : Use default encoding on the environment.
6968 Removed (now that) extra parameter for SeekableStreamReader.
6969 * support.cs : (SeekableStreamReader) third .ctor() argument for
6970 StreamReader is not required (always true). preamble size could
6971 be acquired in simpler and safe way.
6973 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
6975 * cs-parser.jay: report CS0642 at warning level 3
6976 and report CS0642 for an if else statement also
6977 fixes bug #74745. Patch by John Luke (and a bit
6979 Removed extra CS0642 warning check for "while",
6981 * statement.cs: In Block.Resolve(), CS0642 check
6982 is reimplemented to check a sequence of an empty
6983 statement and a block.
6985 Both fix bug #66777.
6987 2005-08-24 Marek Safar <marek.safar@seznam.cz>
6989 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
6990 detection until I fix it.
6992 * cs-tokenizer.cs: Changed error message.
6994 * cs-parser.jay: Fixed 2 error locations.
6996 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
6997 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
7000 * enum.cs (GetSignatureForError): Fixed.
7002 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
7006 * typemanager.cs (RegisterProperty): Removed.
7008 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
7010 2005-08-24 Raja R Harinath <rharinath@novell.com>
7013 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
7014 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
7016 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7018 * expression.cs : tiny fix is required for not warning positive ulong.
7021 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7023 * expression.cs : add CS0652 check for constant and integral
7024 expression. Fixed bug #53974.
7026 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7028 * expression.cs : in DoNumericPromotions(), check if there is implicit
7029 conversion overload for string (to check CS0034). Fixed bug #52492.
7031 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7033 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
7035 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7037 * ecore.cs : report location when it is *not* Null.
7039 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7045 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
7046 correctly. Fixed bug #75721.
7048 2005-08-23 Raja R Harinath <rharinath@novell.com>
7050 * support.cs (SeekableStreamReader.Position): Avoid an expensive
7051 loop that performs 'min (pos, char_count)'.
7054 * expression.cs (Unary.ResolveOperator): Don't discard implicit
7055 converted value in Operator.OnesComplement.
7057 2005-08-22 Ben Maurer <bmaurer@ximian.com>
7059 * anonymous.cs: If the anon method is pulled into a helper class,
7060 it needs to be `internal' not `private'. Fixes runtime behavior on
7063 2005-08-20 Martin Baulig <martin@ximian.com>
7065 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7066 scope if we don't already have it.
7068 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7069 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
7072 2005-08-17 Marek Safar <marek.safar@seznam.cz>
7075 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
7078 2005-08-16 Marek Safar <marek.safar@seznam.cz>
7080 The big constants rewrite
7081 Fix #75746, #75685 and more
7082 As a side effect saved 1MB for MWF ;-)
7084 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
7085 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
7086 enum based for corlib compilation.
7088 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
7091 * class.cs (FixedField.Define): Use ResolveAsConstant.
7093 * const.cs (IConstant): Interface constants and enums.
7094 (Const.ResolveValue): New method for constant resolvning.
7095 (ExternalConstant): Constants from imported assemblies.
7097 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
7098 conversion; like enums.
7099 (Constant.ToType): Converts this constant to different type.
7100 (Constant.Increment): Adds 1.
7102 * convert.cs (ImplicitConversionRequired): Simplified.
7104 * cs-parser.jay: Create EnumMember directly.
7106 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
7108 * doc.cs (GenerateEnumDocComment): Removed.
7110 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
7111 (ConvertIntLiteral): Removed.
7112 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
7114 * enum.cs (EnumMember): Implement IConstant.
7115 (Enum.IsValidEnumConstant): Removed.
7116 (Enum.GetNextDefaultValue): Removed.
7117 (Enum.FindMembers): Updated.
7118 (Enum.GenerateDocComment): Iterate enum members.
7120 * expression.cs (Cast.TryReduce): Handle enums correctly.
7121 (New.Constantify): Made public.
7122 (MemberAccess.DoResolve): Removed contant specific if(s).
7124 * literal.cs (NullLiteral): Implement new abstract methods.
7126 * statement.cs (GotoCase.Resolve): Use new constant methods.
7127 (SwitchLabel.ResolveAndReduce): Use new constant methods.
7129 * typemanager.cs (LookupEnum): Removed.
7130 (IsEnumType): Fixed to work with corlib.
7131 (RegisterConstant): Removed.
7132 (LookupConstant): Removed.
7133 (GetConstant): Changed to work with IConstant.
7135 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
7137 * location.cs : Fixed overflown (>255) column number.
7139 2005-08-03 Raja R Harinath <rharinath@novell.com>
7141 First cut of the qualified-alias-member feature.
7142 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
7144 * cs-parser.jay (DOUBLE_COLON): New token.
7145 (namespace_or_type_name): Add rule for recognizing
7146 qualified-alias-members.
7147 (primary_expression): Likewise.
7148 (element_access): Allow QualifiedAliasMember as a possible
7149 type-bearing expression.
7150 (local_variable_type, local_variable_pointer_type): Likewise.
7151 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
7152 aliases in the current and enclosing namespace declarations.
7153 (NamespaceEntry.UsingAlias): Add CS0440 warning.
7154 * decl.cs (MemberName.is_double_colon): New.
7155 (MemberName.MemberName): Add new constructor for alias-member.
7156 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
7157 * expression.cs (QualifiedAliasMember): New expression type.
7159 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7161 * location.cs : it borked when no argument was specified.
7163 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7165 * location.cs : tiny ToString() format fix.
7167 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7169 * statement.cs : oops, it was missing.
7171 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7173 A set of fixes for precise line/column location.
7176 "token" field now holds a file/line "delta", a line number offset
7177 from the segment, and a column number. See also:
7178 http://lists.ximian.com/pipermail/mono-devel-list/2004-
7179 December/009508.html
7180 Removed static IsNull. Use instance IsNull property instead.
7182 For some tokens it stores Location. For Identifier it stores
7183 LocatedToken which is a pair of string name and location.
7184 Column numbers are adjusted only at getChar().
7186 Use Location.ToString() for reporting (it now contains column).
7188 Largely modified to use LocatedToken instead of
7189 string (IDENTIFIER), and to acquire Location from some tokens.
7190 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
7191 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
7193 Now MemberName holds Location. DeclSpace.ctor() receives Location
7194 as a parameter. Removed extra parameters to all derived classes.
7195 Replaced Location.IsNull() with instance property.
7196 * assign.cs, expression.cs :
7197 Added .ctor() overload that omits Location.
7199 Added "nameEscaped" flag that indicates the identifier was escaped
7200 in the source file. This fixes bug #57047.
7202 2005-08-02 Marek Safar <marek.safar@seznam.cz>
7204 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
7205 New method, looking for lo-case imported cls type.
7207 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
7210 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
7212 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
7214 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
7216 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
7218 Optimized to save 3.5 MB for SWF compilation.
7220 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7222 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
7223 (PartialContainer.Create): Moved logic AddToContainer.
7224 (PartialContainer.MarkForDuplicationCheck): Shares name.
7226 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
7229 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
7231 (Namespace.GetSignatureForError): New method.
7233 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
7234 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
7236 2005-08-01 Raja R Harinath <rharinath@novell.com>
7239 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
7240 member lookup rather than qualifier_type, since qualifier_type can
7243 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7245 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
7248 2005-07-31 Miguel de Icaza <miguel@novell.com>
7250 * statement.cs: Copy the local exception into the exception
7251 captured local. Fixes 75674
7253 2005-07-31 Raja R Harinath <harinath@gmail.com>
7256 * expression.cs (Invocation.OverloadResolve): Don't report error
7257 CS1501 if error CS1502 has been reported.
7258 (New.DoResolve): Delegate CS1501 reporting to
7259 Invocation.OverloadResolve.
7262 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
7263 invariant-meaning-in-block property in an enclosing block if
7266 2005-07-29 Marek Safar <marek.safar@seznam.cz>
7268 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
7269 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
7270 (Switch.CheckSwitch): Just save 50kb for SWF.
7272 2005-07-27 Martin Baulig <martin@ximian.com>
7274 * anonymous.cs (CaptureContext.AddField): Added
7275 `AnonymousContainer am' argument; compute its toplevel scope if
7276 it's not already computed. Fixes #75649.
7278 2005-07-26 Raja R Harinath <rharinath@novell.com>
7281 * class.cs (Constructor.Emit): Reset block to null if the block
7284 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7286 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
7288 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7290 * class.cs (MethodData.Define): Check whether accessor implementing
7291 interface is public.
7293 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
7295 2005-07-22 Marek Safar <marek.safar@seznam.cz>
7298 * namespace.cs (LookupType): Moved same type check to...
7300 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
7303 2005-07-21 Raja R Harinath <rharinath@novell.com>
7305 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
7306 already found a typebuilder.
7307 * class.cs (MethodCore.IsDuplicateImplementation): Compare
7308 MemberNames, not strings.
7310 * const.cs (Error_ExpressionMustBeConst):
7311 Rename from Error_EpressionMustBeConst.
7312 * const.cs, class.cs, statement.cd: Update.
7314 2005-07-21 Marek Safar <marek.safar@seznam.cz>
7318 * const.cs (Const.LookupConstantValue): Report missing contant expression
7320 (Error_EpressionMustBeConstant): Only one error method.
7322 * class.cs, statement.c: Updated.
7324 2005-07-20 Raja R Harinath <rharinath@novell.com>
7326 * statement.cs (Block.Flags): Add back HasVarargs.
7327 (Block.flags): Make protected.
7328 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
7330 * typemanager.cs (types, typecontainers, user_types): Remove.
7331 (UserTypes, TypeContainers): Likewise.
7332 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
7333 (CleanUp, Reset): Update.
7334 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
7335 (GetNestedType): Use Type.GetNestedType.
7336 (CoreLookupType): Take two arguments, the namespace and the
7337 basename of the type. Update to use the Namespace.Lookup
7339 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
7340 (RealMemberLookup): Use IsNestedChildOf instead of playing with
7341 string concatenation and substring matches.
7342 * class.cs, enum.cs, delegate.cs: Update to changes.
7344 2005-07-20 Marek Safar <marek.safar@seznam.cz>
7346 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
7347 Expression and made virtual.
7349 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
7350 (ImplicitStandardConversionExists): Fixed `byte' typo ?
7352 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
7354 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
7357 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
7360 2005-07-18 Marek Safar <marek.safar@seznam.cz>
7363 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
7364 AssemblyCultureAttribute is not used on executable.
7367 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
7369 2005-07-16 Raja R Harinath <rharinath@novell.com>
7372 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
7373 New. Reports CS0252/CS0253.
7374 Mostly taken from preliminary patch by Duncak Mak.
7375 (Binary.DoResolveOperator): Store results of operator lookup.
7376 Use them to detect if we need to warn about unintended reference
7379 2005-07-15 Raja R Harinath <rharinath@novell.com>
7382 * namespace.cs (Namespace.Lookup): Add back location parameter.
7383 (Namespace.LookupType): Add CS0436 report. Add location parameter.
7384 * delegate.cs, ecore.cs, expression.cs: Update to changes.
7386 * codegen.cs (EmitContext.DeclSpace): Make readonly.
7387 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
7388 (Namespace.LookupType): ... this.
7389 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
7391 * typemanager.cs (LookupTypeReflection): Remove buggy code that
7392 purported to handle pointers.
7393 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
7396 2005-07-15 Marek Safar <marek.safar@seznam.cz>
7398 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
7401 2005-07-15 Raja R Harinath <rharinath@novell.com>
7403 * namespace.cs (Namespace.Lookup): Drop location parameter.
7404 (NamespaceEntry.LookupAlias): Remove. Merge into ...
7405 (NamespaceEntry.Lookup): ... this.
7406 (NamespaceEntry.Error_AmbiguousTypeReference):
7407 Move here from DeclSpace.
7408 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
7410 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
7411 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
7412 Move to NamespaceEntry.
7413 * delegate.cs, expression.cs: Update to changes.
7415 2005-07-14 Marek Safar <marek.safar@seznam.cz>
7417 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
7418 CheckAttributeType and refactored.
7419 (Attribute.ResolvePossibleAttributeType): Changed to reuse
7420 ResolveAsTypeTerminal error handling.
7421 (ResolveAsTypeTerminal): Introduced because of global attributes extra
7423 (GetSignatureForError): Print errors in same way.
7426 * codegen.cs: Reflect attribute GetSignatureForError change.
7429 * expression.cs: Add silent parameter to ResolveAsTypeStep.
7431 * namespace.cs (UsingEntry): Refactored to make fields private.
7434 statement.cs: Error_UnexpectedKind has extra parameter.
7436 2005-07-14 Raja R Harinath <rharinath@novell.com>
7438 * ecore.cs (IAlias): Remove.
7439 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
7440 that implement the interface.
7441 * namespace.cs (Namespace): Likewise.
7442 (Namespace.declspaces): Renamed from 'defined_names'.
7443 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
7444 DeclSpace instead of an IAlias.
7445 * tree.cs (Tree.AddDecl): Update.
7447 2005-07-12 Raja R Harinath <rharinath@novell.com>
7449 * statement.cs (Block.Flags); Remove HasVarargs.
7450 (Block.HasVarargs): Move to ToplevelBlock.
7451 (Block.ThisVariable, Block.AddThisVariable): Likewise.
7452 (Block.Variables): Make protected. Initialize variable hashtable
7454 (Block.AddVariable): Update.
7455 (Block.Resolve): Update to changes.
7456 (ToplevelBlock.HasVarargs): New boolean.
7457 (ToplevelBlock.ThisVariable): Move here from Block.
7458 (ToplevelBlock.AddThisVariable): Likewise.
7459 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
7460 * expression.cs (This.ResolveBase): Update to changes.
7461 (ArglistAccess.DoResolve): Likewise.
7463 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7466 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
7468 * class.cs (TypeContainer.VerifyMembers): Distinguish between
7469 not used and not used & assigned.
7470 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
7472 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7475 * expression.cs (Is.DoResolve): null is never provided type.
7477 2005-07-08 Marek Safar <marek.safar@seznam.cz>
7480 * cs-parser.jay: Less strict event error rule to catch more errors.
7482 2005-07-08 Martin Baulig <martin@ximian.com>
7484 Fix test-iter-10.cs - distinguish whether we `yield' in a property
7485 gettter (allowed) or setter (not allowed).
7487 * class.cs (Accessor): Implement IIteratorContainer.
7488 (Accessor.Yields): New public field.
7489 (PropertyBase.PropertyMethod.Define): Handle iterators on a
7493 (get_accessor_declaration, set_accessor_declaration): Set the
7494 `yields' flag on the accessor, not the property.
7495 (property_declaration): Do the iterators check on a per-accessor
7496 basis and not for the whole property.
7498 2005-07-08 Martin Baulig <martin@ximian.com>
7500 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
7501 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
7503 2005-07-07 Marek Safar <marek.safar@seznam.cz>
7506 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
7507 (ExtractSecurityPermissionSet): Cope with self referencing security
7508 attributes properly.
7510 * driver.cs (SetOutputFile): Made public property OutputFile.
7512 2005-07-07 Raja R Harinath <rharinath@novell.com>
7515 * class.cs (TypeContainer.first_nonstatic_field): Rename from
7516 has_nonstatic_fields. Make into a FieldBase pointer.
7517 (TypeContainer.AddField): Add CS0282 check.
7518 (TypeContainer.EmitType): Update.
7520 2005-07-06 Miguel de Icaza <miguel@novell.com>
7522 * cs-tokenizer.cs (consume_identifier): Do not create strings to
7523 compare if they start with __.
7525 2005-07-06 Raja R Harinath <rharinath@novell.com>
7527 * statement.cs (Switch.SwitchGoverningType): Only look at
7528 UserCasts that don't need implicit standard conversions to one of
7529 the allowed switch types (Fixes test-322.cs).
7530 (LocalInfo.Resolve): Re-enable sanity-test.
7532 2005-07-06 Marek Safar <marek.safar@seznam.cz>
7534 * cs-tokenizer.cs (consume_identifier): Detect double undescores
7536 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
7538 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
7540 2005-07-06 Raja R Harinath <rharinath@novell.com>
7543 * ecore.cs (SimpleName.GetSignatureForError): Add.
7544 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
7545 (MemberAccess.GetSignatureForError): Add.
7547 2005-07-05 Marek Safar <marek.safar@seznam.cz>
7549 The big error and warning messages review.
7579 * typemanager.cs: Updated.
7581 * class.cs: (MethodCore.SetYields): Moved here to share.
7582 (PropertyMethod.Define): Moved iterator setup here.
7584 * iterators.cs: Add orig_method to have full access to parent
7587 2005-07-05 Raja R Harinath <rharinath@novell.com>
7589 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
7590 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
7591 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
7592 variable of struct type.
7593 * expression.cs (Unary.ResolveOperator): Update to change.
7594 (Indirection.VerifyFixed): Likewise.
7595 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
7596 (ParameterReference.VerifyFixed): Value parameters are fixed.
7597 (This.VerifyFixed): Treat 'this' as a value parameter.
7598 * statement.cs (LocalInfo.IsFixed): Remove.
7600 2005-07-01 Martin Baulig <martin@ximian.com>
7602 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
7603 `ec.EmitThis ()' to get the correct scope.
7605 2005-07-01 Martin Baulig <martin@ximian.com>
7607 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
7608 instance is a ParameterReference; fixes #75299.
7610 2005-07-01 Martin Baulig <martin@ximian.com>
7612 Reverted Marek's latest patch (r46725):
7613 - it contains structural changes which are neither mentioned in
7614 the ChangeLog nor explained anywhere; for example the additional
7615 argument of EmitContext's and Iterator's .ctor's and the
7616 TypeContainer.DefineMembers() change.
7617 - structural changes like this should go in in seperate patches
7618 and not be hidden in a huge patch which just seems to affect
7619 warnings and errors.
7620 a big and hard to understand patch.
7621 - it breaks iterators and causes regressions, for instance in
7624 2005-06-30 Raja R Harinath <rharinath@novell.com>
7627 * expression.cs (Indexers.map): Remove.
7628 (Indexers.Append): Filter out inaccessible setters and getters.
7629 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
7632 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
7634 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
7635 (FieldExpr.Emit, PropertyExpr.Emit): Update.
7636 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
7637 * expression.cs (Invocation.EmitCall): Add CS0120 check.
7639 2005-06-30 Marek Safar <marek.safar@seznam.cz>
7642 * class.cs (FieldBase.GetInitializerExpression): One more field
7645 2005-06-28 Miguel de Icaza <miguel@novell.com>
7647 * pending.cs: Do not define a proxy if the base method is virtual,
7648 it will be picked up by the runtime (bug 75270).
7650 2005-06-08 Martin Baulig <martin@ximian.com>
7652 The big Iterators rewrite :-)
7654 * iterators.cs: Rewrite this to use the anonymous methods framework.
7656 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
7657 before the TypeContainers; see 2test-21.cs.
7660 (TypeContainer.DefineType): Don't create a new EmitContext if we
7661 already have one (this only happens if we're an Iterator).
7662 (TypeContainer.Define): Also call Define() on all our iterators.
7663 (Method.CreateEmitContext): Added support for iterators.
7666 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
7667 (AnonymousContainer.CreateMethodHost): Moved here from
7668 AnonymousMethod and made abstract.
7669 (AnonymousContainer.CreateScopeType): New abstract method.
7670 (AnonymousContainer.IsIterator): New public property.
7671 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
7672 get the ScopeTypeBuilder rather than manually defining it here.
7673 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
7676 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
7677 before RootContext.DefineTypes().
7679 * codegen.cs (EmitContext.RemapToProxy): Removed.
7680 (EmitContext.CurrentAnonymousMethod): Changed type from
7681 AnonymousMethod -> AnonymousContainer.
7682 (EmitContext.ResolveTopBlock): Protect from being called twice.
7683 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
7684 (EmitContext.EmitThis): Removed the iterators hacks; use the
7685 anonymous methods framework for that.
7688 (ToplevelBlock.Container): Make this a property, not a field.
7689 (ToplevelBlock.ReParent): New public method; move the
7690 ToplevelBlock into a new container.
7691 (Foreach.TemporaryVariable): Simplify.
7693 2005-06-05 Martin Baulig <martin@ximian.com>
7695 * statement.cs (LocalInfo.CompilerGenerated): New flag.
7696 (Block.AddTemporaryVariable): New public method; creates a new
7697 `LocalInfo' for a temporary variable.
7698 (Block.EmitMeta): Create the LocalBuilders for all the temporary
7700 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
7701 non-iterator variables.
7703 2005-06-05 Martin Baulig <martin@ximian.com>
7705 * statement.cs (Foreach.TemporaryVariable): Create the
7706 LocalBuilder in the Emit phase and not in Resolve since in some
7707 situations, we don't have an ILGenerator during Resolve; see
7708 2test-19.cs for an example.
7710 2005-06-04 Martin Baulig <martin@ximian.com>
7712 **** Merged r45395 from GCS ****
7714 The big Foreach rewrite - Part II.
7716 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
7717 with `PropertyInfo ienumerator_getcurrent'.
7719 * codegen.cs (VariableStorage): Removed.
7722 (Foreach): Derive from Statement, not ExceptionStatement.
7723 (Foreach.CollectionForeach): New nested class. Moved all the code
7724 dealing with collection foreach here.
7725 (Foreach.ForeachHelperMethods): Removed.
7726 (Foreach.TemporaryVariable): Implement IMemoryLocation.
7728 2005-05-23 Martin Baulig <martin@ximian.com>
7730 * statement.cs (Try.DoResolve): Don't create a `finally' if we
7731 don't need to. Fix #75014.
7733 2005-05-20 Martin Baulig <martin@ximian.com>
7735 Merged r44808 from GMCS.
7737 * class.cs (TypeContainer.CircularDepException): Removed.
7738 (TypeContainer.DefineType): Removed the `InTransit' stuff.
7739 (TypeContainer.CheckRecursiveDefinition): Check for circular class
7740 (CS0146) and interface (CS0529) dependencies here.
7742 2005-06-21 Raja R Harinath <rharinath@novell.com>
7744 * expression.cs (Invocation.EmitCall): Fix initialization
7745 'this_call' to reflect current behaviour. Fix indentation.
7747 * convert.cs (FindMostEncompassedType): Add two trivial special
7748 cases (number_of_types == 0 || number_of_types == 1).
7749 (FindMostEncompasingType): Likewise.
7751 2005-06-17 Raja R Harinath <rharinath@novell.com>
7753 Some cleanups preparing for the fix of #75283.
7754 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
7756 (EventExpr.InstanceResolve): Likewise.
7757 (EventExpr.DoResolve): Remove redundant checks.
7759 2005-06-10 Duncan Mak <duncan@novell.com>
7761 * cs-tokenizer.cs (process_directives): New flag for controlling
7762 the processing of preprocessor directives.
7763 (x_token): After seeing a '#', return Token.NONE instead of going
7764 to handle_preprocessing_directive() when not processing
7765 directives. This avoids unnecessary processing during the token peek in
7770 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
7771 the existing error reporting methods instead of Report.Error.
7773 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
7774 after Raja's rewrite.
7776 2005-06-08 Miguel de Icaza <miguel@novell.com>
7778 * class.cs: Small fix.
7780 2005-06-08 Raja R Harinath <rharinath@novell.com>
7783 * class.cs (GetPartialBases): Fix return value check of
7786 2005-06-07 Raja R Harinath <rharinath@novell.com>
7788 Ensure that partial classes are registered in their enclosing
7789 namespace. Initial part of fix of #75160.
7790 * tree.cs (Tree.RecordDecl): Add new namespace argument.
7791 Register declspace with namespace here, not in
7792 DeclSpace.RecordDecl.
7793 * cs-parser.jay: Pass namespace to RecordDecl.
7794 * class.cs (PartialContainer.Create): Likewise.
7795 (ClassPart.DefineType): New sanity-check. Throws an exception if
7797 * decl.cs (Declspace.RecordDecl): Remove.
7798 * namespace.cs (NamespaceEntry.DefineName): Remove.
7800 2005-06-06 Marek Safar <marek.safar@seznam.cz>
7802 * rootcontext.cs: Reset TargetExt as well.
7804 2005-06-03 Raja R Harinath <rharinath@novell.com>
7806 * ecore.cs (Expression.Resolve): Emit CS0654 error when
7809 2005-06-02 Raja R Harinath <rharinath@novell.com>
7811 Fix #75080, cs0119.cs.
7812 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
7814 (Expression.Resolve): ... this. Use it. Remove bogus code
7815 allowing ExprClass.Type and ExprClass.Namespace for
7816 ResolveFlags.VariableOrValue.
7817 (Expression.Resolve) [1-argument variant]: Change default resolve
7818 flags based on language version.
7819 (Expression.Error_UnexpectedKind): Use a simple string array
7820 rather than an ArrayList.
7821 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
7823 (TypeOfVoid.DoResolve): Likewise.
7824 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
7825 flags argument -- it always has the same value.
7827 2005-05-31 Raja R Harinath <rharinath@novell.com>
7830 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
7831 Use it in the error message.
7832 * assign.cs, expression.cs, statement.cs: Update.
7834 2005-05-30 Raja R Harinath <rharinath@novell.com>
7837 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
7838 the "almostMatchedMember" case too.
7839 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
7840 that failed the accessibility checks to 'almost_match'.
7842 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
7844 * attribute.cs: Use internal MethodBuilder methods to set
7845 ExactSpelling and SetLastError on PInvoke methods, instead
7846 of passing them via charset. Fixes #75060.
7848 2005-05-27 Raja R Harinath <rharinath@novell.com>
7850 * parameter.cs (Parameter): Remove TODO comment.
7851 (Parameter.DefineParameter): Remove Location parameter.
7852 (Parameters.LabelParameters): Likewise.
7853 * class.cs (Constructor.Emit): Update to change.
7854 (MethodData.Emit): Likewise.
7855 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
7856 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
7858 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
7861 Removed Parameters.Location and added Parameter.Location instead.
7862 Removed Location parameter from Emit() and GetSignature().
7869 Modified all related calls.
7871 2005-05-26 Raja R Harinath <rharinath@novell.com>
7873 Improve user-defined conversion handling.
7874 * convert.cs (GetConversionOperators): Rewrite. Return only the
7875 applicable operators.
7876 (AddConversionOperators): New. Helper for GetConversionOperators.
7877 (FindMostEncompassedType, FindMostEncompassingType): Verify that
7878 there is only one most encompassed/encompassing type.
7879 (FindMostSpecificSource, FindMostSpecificTarget): Remove
7880 "applicable operator" handling.
7881 (UserConversion): Move cache here from GetConversionOperators.
7882 Directly cache the chosen operator, rather than the whole
7884 (ExplicitNumericConversion): Fix buggy implementation of Decimal
7885 case. Allow conversion of decimal to sbyte and byte too.
7886 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
7887 New static methods. Used to avoid allocating EmptyExpressions in
7890 2005-05-24 Duncan Mak <duncan@novell.com>
7892 * ecore.cs (CastFromDecimal): New class for casting a decimal to
7893 another class, used in Convert.ExplicitNumericConversion.
7894 (CastToDecimal): New class, similar to above, but casts to
7895 System.Decimal, used in Convert.ImplicitNumericConversion and also
7896 in explicit convesion from double/float to decimal.
7898 * convert.cs (ImplicitNumericConversion): Handle implicit
7899 conversions to System.Decimal.
7900 (ExplicitNumericConversion): handle explicit conversions to
7905 2005-05-20 Miguel de Icaza <miguel@novell.com>
7907 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
7908 know the type at this stage, just break through. Fixes #75008
7910 2005-05-19 Martin Baulig <martin@ximian.com>
7913 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
7914 to disable error reporting.
7916 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
7917 here since we don't want to report an error; see the new test-336.cs.
7919 2005-05-19 Raja R Harinath <rharinath@novell.com>
7921 * statement.cs (ToplevelBlock.GetParameterReference)
7922 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
7923 Move here from class Block.
7924 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
7925 * expression.cs (ParameterReference.DoResolveBase): Likewise.
7927 2005-05-18 Martin Baulig <martin@ximian.com>
7932 (FlowBranching.Reachability): Add non-static public And() and Or()
7934 (FlowBranchingSwitch): New class; do the `break_origins' thing
7935 like in FlowBranchingLoop.
7936 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
7937 reachability, not just locals and parameters.
7938 (FlowBranching.MergeChild): Remove some of the hacks for loop and
7939 switch; MergeBreakOrigins() now takes care of that.
7941 2005-05-18 Martin Baulig <martin@ximian.com>
7943 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7944 a loop and may leave it, reset the barrier; fixes #74974.
7946 2005-05-17 Marek Safar <marek.safar@seznam.cz>
7948 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
7951 * cs-parser.jay: Catch more lexical errors.
7953 * report.cs: Add one more Error method.
7956 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
7958 2005-05-17 Martin Baulig <martin@ximian.com>
7960 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
7963 2005-05-16 Raja R Harinath <rharinath@novell.com>
7965 Fix test-382.cs. Emit values of decimal constants.
7966 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
7968 (TypeContainer.AddField): ... this.
7969 (TypeContainer.EmitFieldInitializers): Allow the list of fields
7970 with initializers to include 'Const's.
7971 (ClassPart.RegisterFieldForInitialization): Forward to
7973 * const.cs (Const.Const): Pass initializer to base class.
7974 (Const.Define): In case of decimal constants, register them for
7975 initialization in a static constructor.
7977 2005-05-14 Martin Baulig <martin@ximian.com>
7979 * statement.cs (Block.Resolve): Correctly handle unreachable code;
7980 do not call ResolveUnreachable() on unreachable statements in
7981 here, see the comment in the source code.
7983 2005-05-13 Raja R Harinath <rharinath@novell.com>
7986 * expression.cs (BinaryResolveOperator): If one of the operands of
7987 an equality comparison is 'null' and the other is a pointer type,
7988 convert the null to a NullPointer.
7989 * convert.cs (ImplicitReferenceConversion): If the expression is a
7990 NullLiteral and the target type is a pointer type, return a
7991 NullPointer instead.
7992 (ImplicitConversionStandard): Likewise.
7994 2005-05-13 Marek Safar <marek.safar@seznam.cz>
7996 * cs-parser.jay: Set readonly context based on special constructs.
7998 * expression.cs (LocalVariableReference.DoResolveBase): Improved
7999 readonly variable error handling.
8001 * rootcontext.cs (EmitCode): Don't verify members when error
8004 * statement.cs (LocalInfo): Add reaodnly context information.
8005 (SetReadOnlyContext, GetReadOnlyContext): New methods.
8007 2005-05-13 Raja R Harinath <rharinath@novell.com>
8009 * statement.cs (Block.Resolve): Revert change below. Modify fix
8010 for #74041 to initialize 'resolved' to false only for explicit
8011 blocks. Fixes #74873.
8013 2005-05-12 Raja R Harinath <harinath@gmail.com>
8016 * typemanager.cs (unmanaged_enclosing_types): New.
8017 (IsUnmanagedType): Avoid infloops by using
8018 'unmanaged_enclosing_types' to talk with recursive invocations.
8020 2005-05-13 Martin Baulig <martin@ximian.com>
8022 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
8023 instance variable, not a local. Fix #74873.
8024 (Block.ResolveUnreachable): Set it to true here.
8026 2005-05-11 Duncan Mak <duncan@novell.com>
8028 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
8029 continuing to process for 'arg'.
8030 (handle_preprocessing_directive): Check the argument of the #endif
8031 directive and report error CS1025 if there are any trailing
8034 According to the C# spec, having even whitespace after the #endif
8035 directive is illegal; however, because we call arg.TrimEnd ()
8036 beforehand, we have the same behavior as csc, allowing whitespace
8037 after the directive.
8041 2005-05-11 Marek Safar <marek.safar@seznam.cz>
8045 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
8046 (Constructor.GetObsoleteAttribute): Implemented correctly.
8048 2005-05-10 Martin Baulig <martin@ximian.com>
8050 * support.cs (ReflectionParameters.ParameterModifier): Use
8051 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
8052 and `ParameterAttributes.In'. Fixes #74884.
8054 2005-05-10 Marek Safar <marek.safar@seznam.cz>
8056 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
8058 * expression.cs (Argument.GetParameterModifier): Turned to property.
8059 (Invocation.Error_InvalidArguments): Add more descriptive errors.
8061 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
8064 2005-05-09 Raja R Harinath <rharinath@novell.com>
8067 * decl.cs (MemberCache.AddMethods): Register override methods,
8068 rather than non-override methods.
8069 * typemanager.cs (RegisterOverride): New.
8070 (IsOverride): Update.
8072 2005-05-09 Marek Safar <marek.safar@seznam.cz>
8076 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
8077 recursive declaration.
8079 * statement.cs (Block.ResolveMeta): Report any error in resolving.
8081 2005-05-06 Marek Safar <marek.safar@seznam.cz>
8083 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
8085 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
8087 2005-05-05 Raja R Harinath <rharinath@novell.com>
8090 * decl.cs (DeclSpace.FamilyAccessible):
8091 Use TypeManager.IsNestedFamilyAccessible.
8093 Fix reopened #64812.
8094 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
8097 2005-05-04 Raja R Harinath <rharinath@novell.com>
8098 Abin Thomas <projectmonokochi@rediffmail.com>
8099 Anoob V E <projectmonokochi@rediffmail.com>
8100 Harilal P R <projectmonokochi@rediffmail.com>
8103 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
8104 allow access to all static members.
8106 2005-05-04 Martin Baulig <martin@ximian.com>
8108 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
8110 2005-05-04 Martin Baulig <martin@ximian.com>
8114 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
8115 section at the end; make things work if `default' is not the last
8118 2005-05-04 Martin Baulig <martin@ximian.com>
8122 * statement.cs (Switch): Replaced the `got_default' field with a
8123 `default_section' one.
8124 (Switch.CheckSwitch): Set `default_section' here.
8125 (Switch.Resolve): If we're a constant switch and the constant is
8126 not found, use the default section.
8128 2005-05-03 Martin Baulig <martin@ximian.com>
8130 * expression.cs (ArrayAccess.EmitGetLength): New public method.
8132 * statement.cs (Foreach.ArrayForeach): New nested class.
8133 (Foreach.TemporaryVariable): New nested class.
8134 (Foreach.EmitArrayForeach): Removed; this is now in the new
8137 2005-05-03 Raja R Harinath <rharinath@novell.com>
8139 * pending.cs (BaseImplements): Move the #74773 fix here. This is
8141 (VerifyPendingMethods): Revert change below.
8143 * typemanager.cs (IsOverride, RegisterNonOverride): New.
8144 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
8145 that used to trigger warning -28. Remove warning -28.
8146 * expression.cs (Invocation.OverloadResolve): Use
8147 TypeManager.IsOverride to distinguish override methods.
8150 * pending.cs (VerifyPendingMethods): If a base type implements the
8151 requested interface, don't bother checking individual methods of
8152 the base type. As a side-effect, this prevents the creation of
8153 unnecessary proxies.
8155 2005-05-02 Martin Baulig <martin@ximian.com>
8159 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
8160 Also `And' the locals if the old vector is null.
8161 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
8162 null; in this case we basically reset all the variables.
8164 2005-05-02 Martin Baulig <martin@ximian.com>
8168 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
8169 Added `FlowBranching branching' argument; always `and' the
8170 variables instead of `or'ing them unless we're an infinite loop.
8172 * statement.cs (While.Resolve): Create a new sibling unless we're
8175 2005-05-02 Martin Baulig <martin@ximian.com>
8179 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
8180 arguments; use it instead of creating a new TopLevelBlock.
8181 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
8182 our ConstructorInitializer.
8185 (TopLevelBlock.TopLevelBranching): New public property.
8186 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
8187 and create our `TopLevelBranching'.
8189 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
8190 anonymous method host, use `block.TopLevelBranching' rather than
8191 creating a new branching.
8193 2005-04-20 Miguel de Icaza <miguel@novell.com>
8195 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
8196 a ScopeInfo, if any of the current children is a child of the new
8197 entry, move those children there.
8199 2005-04-30 Martin Baulig <martin@ximian.com>
8201 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
8202 at the beginning of a SwitchSection. Fix #73335.
8204 2005-04-27 Marek Safar <marek.safar@seznam.cz>
8207 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
8209 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
8210 (FieldExpr.DoResolve): Obsolete members are ignored for field
8213 2005-04-26 Marek Safar <marek.safar@seznam.cz>
8215 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
8216 of arrays detection.
8218 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
8220 (Field.VerifyClsCompliance): Volatile fields are not compliant.
8222 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
8225 2005-04-25 Ben Maurer <bmaurer@ximian.com>
8227 * cs-parser.jay: Use the prefered version of -unsafe in error
8230 2005-04-22 Marek Safar <marek.safar@seznam.cz>
8232 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
8235 2005-04-20 John Luke <john.luke@gmail.com>
8237 * driver.cs: fix typo in error message, --outout to --output
8239 2005-04-20 Marek Safar <marek.safar@seznam.cz>
8241 * codegen.cs (InRefOutArgumentResolving): New field.
8243 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
8244 fields outside contructor.
8246 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
8248 2005-04-19 Miguel de Icaza <miguel@novell.com>
8250 * anonymous.cs (CaptureContext.EmitParameterInstance): The
8251 parameter code was not completed ever, so it was not as up-to-date
8252 as local variables. Must finish it.
8254 The bug fix was to compare the Toplevel of the block, not the
8255 current block. Thanks for Ben for pointing this out.
8257 2005-04-19 Raja R Harinath <rharinath@novell.com>
8259 * decl.cs (AddMethods): Use the declaring type of the problem
8260 method to determine if we want to squash a warning.
8262 2005-04-19 Marek Safar <marek.safar@seznam.cz>
8264 * attribute.cs: Removed debug output.
8266 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
8268 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
8271 2005-04-18 Raja R Harinath <rharinath@novell.com>
8274 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
8275 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
8276 all null comparisons against reference types.
8278 2005-04-18 Marek Safar <marek.safar@seznam.cz>
8281 * class.cs (TypeContainer.CircularDepException) New nested
8283 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
8284 (TypeContainer.DefineType): Removed error, reset InTransit before
8286 (Class.DefineType): Throw exception when is in Transit.
8287 Catch exception and report error.
8288 (Struct.DefineType): Throw exception when is in Transit.
8289 Catch exception and report error.
8290 (Interface.DefineType): Throw exception when is in Transit.
8291 Catch exception and report error.
8293 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
8294 handle nested exception handlers.
8296 * flowanalysis.cs (InTryWithCatch): New method, search for try with
8299 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
8300 InFinally and InCatch storage.
8302 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
8303 (Catch.Resolve): Set and Restore ec.InCatch.
8304 (Try.Resolve): Set and Restore ec.InFinally.
8305 (Try.HasCatch): True when try has catch.
8307 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
8309 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
8310 for the same event member, so exclude such cases from warning 419.
8313 2005-04-16 Miguel de Icaza <miguel@novell.com>
8315 * expression.cs (Binary.ResolveOperator): Apply patch from John
8316 Luke to fix bug 59864: operators &, | and ^ on enumerations
8317 require that the same enum type on both sides.
8319 * driver.cs: Add warnings to old flag usage, this is to assist
8320 people who produce Makefiles and hope that the Makefiles will be
8323 * class.cs (TypeContainer.EmitType): Moved the definition of the
8324 special $PRIVATE$ field from the resolve phase to the Emit phase.
8325 During resolve we do not know if we are a struct with
8326 HasExplicitLayout, we know this only after the attributes for the
8329 Set the FieldOffset to zero on the dummy field that we create for
8330 the class. Fixes 74590.
8332 2005-04-16 Raja R Harinath <rharinath@novell.com>
8335 * ecore.cs (PropertyExpr.resolved): New.
8336 (DoResolve): Use it to handle a case of double resolution here.
8337 Handle a case of identical-name-and-type-name.
8338 * expression.cs (ArrayCreation.CheckIndices): Avoid double
8339 resolution by storing the results of expression resolution back
8340 into the "probes" array.
8342 2005-04-15 Raja R Harinath <rharinath@novell.com>
8344 Fix cs0208-7.cs and cs0208-8.cs.
8345 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
8346 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
8347 error reporting to point out the reason a struct is not unmanaged.
8349 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8351 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
8352 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
8354 2005-04-13 Raja R Harinath <rharinath@novell.com>
8357 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
8358 IdenticalNameAndTypeName here.
8359 (EventExpr.InstanceResolve): Likewise.
8361 2005-04-13 Marek Safar <marek.safar@seznam.cz>
8363 C# 2.0 DefaultCharSetAttribute implementation
8365 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
8366 which allows us to set GlobalNamespace for every resolve.
8367 (Attribute.ResolveArguments): Cut from Resolve.
8368 (Attribute.GetCharSetValue): Returns CharSet named argument.
8369 (Attribute.DefinePInvokeMethod): Gets default charset from
8371 (GlobalAttribute.ResolveAsTypeStep): Override.
8372 (GlobalAttribute.ResolveArguments): Override.
8374 * class.cs (TypeAttr): Is protected.
8376 * codegen.cs (ModuleClass.DefaultCharSet): New member.
8377 (ModuleClass.DefaultCharSetType): New memeber.
8378 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
8380 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
8381 charset from module.
8383 * delegate.cs (TypeAttr): Override.
8384 (Delegate.DefineType): Use this TypeAttr.
8386 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
8387 at very early stage (before types are defined) to resolve model
8388 module attributes. It will probably not work with corlib but it
8391 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
8392 charset from module.
8394 * typemanager.cs (default_charset_type): New type.
8396 2005-04-13 Raja R Harinath <rharinath@novell.com>
8398 * decl.cs (MemberCache.AddMethods): Don't warn if
8399 System.Object.Finalize has buggy MethodAttributes.
8401 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
8404 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8406 * doc.cs : detect ambiguous reference to overloaded members.
8407 Fixed bug #71603. MS 1.1 csc does not detect it.
8409 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8411 * doc.cs : delegates must not be referenced with parameters.
8414 2005-04-12 Miguel de Icaza <miguel@novell.com>
8416 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
8418 2005-04-10 Miguel de Icaza <miguel@novell.com>
8420 * driver.cs (MainDriver): Stop processing if the CLS stage found
8423 (CompilerCallableEntryPoint.InvokeCompiler): Always
8424 reset after execution; Take a TextWriter argument for the
8427 * report.cs: Use the error stream instead of hardcoding stderr.
8429 2005-04-09 Miguel de Icaza <miguel@novell.com>
8431 * class.cs: Reduce code paths to test, too small of an
8432 optimization to make it worth the extra testing. Always perform
8435 2005-04-08 Raja R Harinath <rharinath@novell.com>
8438 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
8439 operators that had errors reported on them.
8441 2005-04-08 Marek Safar <marek.safar@seznam.cz>
8443 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
8445 (Attribute.Resolve): Add named argument type checking.
8447 * class.cs (FixedField.Define): Use IsPrimitiveType
8449 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
8451 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
8452 unsafe parameter types.
8454 * statement.cs (Using.ResolveExpression): Add better error description.
8456 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
8458 2005-04-08 Raja R Harinath <rharinath@novell.com>
8461 * attribute.cs (Attribute.GetAttributeUsage): Resolve
8462 AttributeUsageAttribute in the emitcontext of the attribute class,
8463 not in the emitcontext of the attributable entity it was attached to.
8464 * cs-parser.jay: Use 'current_class', not 'current_container',
8465 when creating a GlobalAttribute.
8467 2005-04-08 Alp Toker <alp@atoker.com>
8469 * pending.cs: The fix to #58413 failed to compile methods implementing
8470 interfaces with/without params modifiers and vice versa, even though
8471 params modifiers aren't part of the signature. Make the modifier check
8472 less strict as in csc.
8474 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
8475 Anoob V E <projectmonokochi@rediffmail.com>
8476 Harilal P R <projectmonokochi@rediffmail.com>
8479 * pending.cs (TypeAndMethods.mods): New. Store the parameter
8480 modifiers of pending methods.
8481 (PendingImplementation.PendingImplementation): Initialize it.
8482 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
8483 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
8484 with ParameterData. Add check for modifiers.
8485 * class.cs (MethodData.Define): Update to changes.
8487 2005-04-07 Raja R Harinath <rharinath@novell.com>
8489 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
8491 2005-04-07 Marek Safar <marek.safar@seznam.cz>
8493 * class.cs (PropertyMethod.Define): Check private accessor in abstract
8496 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
8499 * typemanager.cs: Registered RequiredAttributeAttribute.
8501 2005-04-06 Marek Safar <marek.safar@seznam.cz>
8503 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
8504 Warning CS0169 is back at level 3.
8505 (IMethodData.SetMemberIsUsed): New method.
8507 * decl.cs (IsUsed): New value; moved from FieldBase.Status
8508 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
8510 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
8512 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
8514 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
8517 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
8520 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
8521 to avoid the problems with nested types.
8523 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
8524 Anoob V.E <projectmonokochi@rediffmail.com>
8525 Harilal P.R <projectmonokochi@rediffmail.com>
8526 Raja R Harinath <rharinath@novell.com>
8529 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
8531 * typemanager (GetConstructor): Make public.
8533 2005-04-05 John Luke <john.luke@gmail.com>
8534 Raja R Harinath <rharinath@novell.com>
8537 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
8538 struct too. Return false quicker in a few cases.
8539 (VerifyUnManaged): Use it.
8541 2005-04-05 Raja R Harinath <rharinath@novell.com>
8544 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
8545 not 'unreachable_seen'.
8547 2005-04-04 Marek Safar <marek.safar@seznam.cz>
8549 * attribute.cs (Attribute.GetValue): Removed unused.
8551 * codegen.cs (CodeGen.TrimExt): Removed unused.
8553 * cs-parser.jay (output): Removed unused.
8555 * cs-tokenizer.cs (hex_digits): Removed unused.
8557 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
8559 * expression.cs (Indirection.LoadExprValue): Removed unused.
8560 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
8562 * iterators.cs (Iterator.param_types): Removed unused.
8564 * statement.cs (Goto.block): Removed unused.
8565 (ToplevelBlock.did): Removed unused.
8566 (Switch.ResolveConstantSwitch): Removed unused.
8568 2005-04-01 Ben Maurer <bmaurer@ximian.com>
8570 * rootcontext.cs: Allow mcs to bootstrap with the compilation
8573 2005-04-01 Raja R Harinath <rharinath@novell.com>
8575 Fix #74232 and cs0208-3.cs.
8576 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
8577 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
8578 unmanaged type. Don't use FieldBuilders when 't' is a
8579 TypeBuilder. Use ModFlags and MemberType fields.
8580 * class.cs (MemberBase.member_type): Rename from MemberType.
8581 (MemberBase.MemberType): New property. Determines member_type on
8583 (MemberBase.DoDefine): Don't initialize MemberType here.
8584 (FieldMember.Define): Likewise.
8586 2005-04-01 Marek Safar <marek.safar@seznam.cz>
8589 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
8590 Attributes are emitted there.
8592 2005-04-01 Raja R Harinath <rharinath@novell.com>
8594 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
8595 keyword in 'partial enum' too.
8596 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
8598 Report from Kamil Skalski <nazgul@omega.pl>.
8601 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
8602 have partial containers too.
8604 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
8605 in block' checks to Block.CheckInvariantMeaningInBlock.
8606 * statement.cs (Block.GetKnownVariableInfo): Make private.
8607 (Block.IsVariableUsedInChildBlock): Remove.
8608 (Block.IsVariableUsedInBlock): Likewise.
8609 (Block.CheckInvariantMeaningInBlock): New. Show location of
8610 conflicting declaration.
8611 (Block.AddVariable): Make error messages less long-winded and more
8612 specific. Show location of conflicting declaration.
8613 * parameter.cs (Parameters.Location): New readonly property.
8615 2005-03-31 Raja R Harinath <rharinath@novell.com>
8617 Clean up semantics of invoking ResolveMemberAccess.
8618 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
8619 can have an instance, ensure that we pass in a non-TypeExpression
8620 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
8621 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
8622 argument. Update to changes and simplify.
8623 (FieldExpr.Emitinstance): Remove CS0120 check.
8624 (PropertyExpr.EmitInstance): Likewise.
8625 * expression.cs (Argument.Resolve): Likewise.
8626 (Invocation.DoResolve): Update to changes in semantics of
8629 2005-03-31 Marek Safar <marek.safar@seznam.cz>
8632 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
8635 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
8637 2005-03-31 Raja R Harinath <rharinath@novell.com>
8639 Fix difference in behaviour with commandline invocation.
8640 * driver.cs (Driver.Reset): New.
8641 (CompilerCallableEntryPoint): Call it.
8643 * statement.cs (If.Resolve): Avoid spurious "uninitialized
8644 variable" warnings if the boolean expression failed to resolve.
8646 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
8648 * attribute.cs: Fix the union of several permissions when some of them
8649 are unrestricted (so the result isn't an unrestricted permission set).
8652 2005-03-30 Raja R Harinath <rharinath@novell.com>
8654 * ecore.cs (MemberExpr): New class. Convert from interface
8656 (MemberExpr.ResolveMemberAccess): Refactor and move here from
8657 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
8659 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
8660 (MethodGroupExpr.IsExplicitImpl): Remove.
8661 (Expression.GetFieldFromEvent): Remove.
8662 (SimpleName.MemberStaticCheck): Remove.
8663 (SimpleName.DoSimpleNameResolve): Update to changes.
8664 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
8665 (MemberAccess.IdenticalNameAndTypeName): Remove.
8666 (MemberAccess.error176): Move to MemberExpr.
8667 (MemberAccess.DoResolve): Update to changes.
8668 (BaseAccess.DoResolve): Likewise.
8670 2005-03-30 Marek Safar <marek.safar@seznam.cz>
8672 C# 2.0 Conditional attribute class implementation
8674 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
8675 Analyzes class whether it has attribute which has ConditionalAttribute
8676 and its condition is not defined.
8678 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
8679 (Class.IsExcluded): New method. Search for at least one defined
8680 condition in ConditionalAttribute of attribute class.
8682 2005-03-30 Raja R Harinath <rharinath@novell.com>
8684 * ecore.cs (PropertyExpr): Derive from Expression, not
8685 ExpressionStatement.
8686 (PropertyExpr.EmitStatement): Remove.
8688 2005-03-29 Raja R Harinath <rharinath@novell.com>
8691 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
8692 internal field "value__" of an enum be private. The examples for
8693 "value__" that I found on MSDN all used FieldAttributes.Private.
8695 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
8696 Don't mention IL method attribute names.
8698 Fix #47991. Remove a TODO.
8699 * statement.cs (Block.Toplevel): Make into a field.
8700 (Block.Parameters): Move into ToplevelBlock.
8701 (Block.known_variables): Rename from child_variable_names.
8702 (Block.Block): Remove variants that take Parameters. Initialize
8703 'Toplevel' with the immediately surrounding toplevel block.
8704 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
8705 LocalInfo parameter.
8706 (Block.GetKnownVariableInfo): New.
8707 (Block.IsVariableNameUsedInChildBlock): Update.
8708 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
8709 the block, even though it may not be in scope.
8710 (Block.AddVariable): Remove Parameters parameter. Use
8711 Toplevel.Parameters instead.
8712 (Block.AddConstant): Remove Parameters parameter.
8713 (Block.GetParameterReference): Update to use Toplevel.Parameters.
8714 (Block.IsParamaterReference): Likewise.
8715 (Block.IsLocalParameter): Likewise. Simplify a lot.
8716 (ToplevelBlock.Parameters): New. Moved from Block.
8717 (ToplevelBlock.ToplevelBlock): Update to changes. Always
8718 initialize Parameters to a non-null value.
8719 * cs-parser.jay: Update to changes.
8720 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
8721 simple names that mean different things in the same block. Use
8722 Block.IsVariableNameUsedInBlock.
8724 2005-03-28 Raja R Harinath <rharinath@novell.com>
8726 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
8727 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
8728 GetTypeHandle. It is possible for a reflected type to derive from
8729 a TypeBuilder (e.g., int[] derives from the TypeBuilder
8730 System.Array during mscorlib compilation).
8731 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
8732 contain a method_hash, don't create one either. Don't create a
8733 deep copy of the base cache's method_hash.
8734 (MemberCache.SetupCache): Rename back from DeepCopy.
8735 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
8736 already initialized. If we see an override function, add its
8737 underlying base virtual function to the member_hash too.
8739 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
8741 2005-03-26 Raja R Harinath <harinath@acm.org>
8744 * assign.cs (Assign.DoResolve): When the RHS of an assignment
8745 fails to resolve, ensure that the LHS is still resolved as an
8748 2005-03-25 Raja R Harinath <harinath@acm.org>
8750 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
8752 (Enum.current_ec): Remove.
8753 (Enum.LookupEnumValue): Remove EmitContext argument.
8754 Just uses the one created during DefineType.
8755 (Enum.FindMembers): Update.
8756 * expression.cs (MemberAccess.DoResolve): Update.
8758 2005-03-22 Marek Safar <marek.safar@seznam.cz>
8760 * assign.cs (Assign.DoResolve): Check for CS1717 when
8761 source and target are same (uses Equals).
8763 * expression.cs (LocalVariableReference, ParameterReference,
8764 This): Implemented Equals, GetHashCode.
8766 * statement.cs (Block.GetParameterReference): Removed useless
8769 2005-03-22 Raja R Harinath <rharinath@novell.com>
8772 * statement.cs (Block.AddVariable): Ensure that we skip implicit
8773 blocks before deciding whether the error is cs0136 or cs0128.
8775 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
8776 (using_alias_directive, using_namespace_directive): Pass
8777 MemberName, not an expression to Namespace.UsingAlias and
8779 (MakeName): Use the MemberName of the namespace.
8780 * namespace.cs (Namespace.MemberName): New.
8781 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
8782 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
8784 * decl.cs (MemberName.Name): Make readonly.
8785 (MemberName.FromDotted): New "constructor".
8786 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
8787 (MemberCore.Name): Compute from MemberName on demand.
8788 (MemberCore.SetMemberName): Provide a way to change the
8790 (MemberCore.AddToContainer): Don't take a fullname parameter.
8791 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
8792 fully qualified name of the container to the member name.
8793 (TypeContainer.AddToTypeContainer): Use a fully qualified name
8794 only if the type is a member of the root container.
8795 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
8796 MemberName.Left rather than searching for an embedded ".".
8797 (PartialContainer.CreatePart): Update to changes in RootContext.
8798 (MemberBase.ShortName): Turn into a property. Use
8799 MemberCore.SetMemberName.
8800 (MemberBase.ExplicitInterfaceName): Remove.
8801 (MemberBase.UpdateMemberName): Remove.
8802 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
8803 (PropertyBase.SetMemberName): New override.
8804 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
8805 (Tree.GetDecl): New.
8806 (Tree.AllDecls): Rename from Decls.
8807 * attribute.cs, enum.cs, report.cs: Update to changes.
8808 * driver.cs (MainDriver): Use MemberName.FromDotted on
8809 RootContext.MainClass.
8811 2005-03-21 Marek Safar <marek.safar@seznam.cz>
8813 * class.cs (FixedField.Define): Check for CS1664 and more sanity
8816 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
8818 2005-03-18 Marek Safar <marek.safar@seznam.cz>
8820 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
8821 property accessor modifiers.
8823 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
8824 fixed buffer attribute (CS1716).
8825 (PropertyMethod.HasCustomAccessModifier): When property accessor
8826 has custom modifier.
8828 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
8830 (PropertyExpr.DoResolveLValue): Add CS0272.
8832 2005-03-17 Miguel de Icaza <miguel@novell.com>
8834 * convert.cs: When converting to a pointer, use the proper Conv.U
8835 or Conv.I depending on the source data type.
8837 * cs-tokenizer.cs: Make the size for large decimal constants,
8840 2005-03-17 Martin Baulig <martin@ximian.com>
8842 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
8843 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
8845 2005-03-17 Martin Baulig <martin@ximian.com>
8847 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
8848 to bool so we can return an error condition.
8849 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
8852 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
8854 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
8857 2005-03-16 Raja R Harinath <rharinath@novell.com>
8859 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
8860 Refactor to avoid traversing the list of assemblies, and to avoid
8861 string concatenation.
8862 * typemanager.cs (guid_attr_type): Remove.
8863 (negative_hits, pointers, references): Remove hashes.
8865 (GetConstructedType): New. Uses type_hash to handle constructed
8866 types (arrays, references, pointers).
8867 (GetReferenceType, GetPointerType): Use it.
8868 (GetNestedType): New. Uses type_hash to handle nested types of
8870 (LookupType, LookupTypeDirect): Remove.
8871 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
8872 'types' hash and LookupTypeReflection directly.
8873 (params_string, params_object): Use GetConstructedType.
8874 * namespace.cs (Namespace.cached_types): New. Cache of reflected
8876 (Namespace.Lookup): Use cached_types.
8877 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
8878 provided by old TypeManager.LookupType.
8879 * rootcontext.cs (MakeFQN): Remove.
8880 * decl.cs (DeclSpace.MakeFQN): Likewise.
8881 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
8882 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
8883 TypeManager.GetConstructedType.
8884 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
8886 2005-03-15 Marek Safar <marek.safar@seznam.cz>
8888 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
8891 * cs-parser.jay: Reports CS1527 for any namespace element.
8893 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
8896 * expression.cs (ParameterReference.IsAssigned): Changed error to
8898 (Error_WrongNumArguments): Moved CS0245 detection here.
8900 * statement.cs (Return.Resolve): Add CS1622 report.
8902 2005-03-11 Marek Safar <marek.safar@seznam.cz>
8904 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
8906 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
8908 * attribute.cs expression.cs: Get rid of some allocations.
8910 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
8912 * doc.cs : just eliminate the latest change.
8914 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8916 * doc.cs : commented out the latest change. It breaks xml-030.cs
8918 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8920 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
8921 fail. So invoke CreateType() in FindDocumentedType().
8923 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8925 * cs-tokenizer.cs : added IsKeyword().
8926 * doc.cs : Detect keyword incorrectly used as identifier.
8927 Allow identifiers prefixed by @.
8929 2005-03-10 Marek Safar <marek.safar@seznam.cz>
8931 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
8932 It caused exception in namespace resolving (again!).
8934 * class.cs (Class.ctor): Removed exit.
8935 (PropertyMethod.ctor): ditto.
8937 * codegen.cs (Codegen.Reset): Reset static data.
8938 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
8940 * cs-tokenizer.cs (Cleanup): Removed.
8942 * driver.cs (GetSystemDir): Rewrote to one line command.
8943 It caused problem with unloaded dynamic modules.
8944 (UnixParseOption): Removed Exit.
8945 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
8946 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
8947 Now can be mcs used as library.
8949 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
8952 * location.cs (Reset): Reset static data.
8954 * namespace.cs (Reset): Reset static data.
8956 * report.cs (Report.Reset): Reset static data.
8958 * rootcontext.cs (RootContext.Reset): Reset static data.
8960 * tree.cs (RootTypes.ctor): Use Location.Null
8962 * typemanager.cs (TypeManager.Reset): Reset static data.
8963 (CoreLookupType): Removed Exit.
8964 (TypeHandle.Reset): Reset static data.
8966 2005-03-10 Raja R Harinath <rharinath@novell.com>
8969 * typemanager.cs (ComputeNamespaces): Import namespaces from
8970 referenced modules too.
8972 2005-03-09 Raja R Harinath <rharinath@novell.com>
8974 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
8977 2005-03-09 Raja R Harinath <rharinath@novell.com>
8979 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
8980 enclosing DeclSpace. This ensures that a name-lookup populates
8981 more caches and there are fewer 'TypeExpression's. Carve out
8982 nested type lookup into ...
8983 (LookupNestedTypeInHierarchy): ... this.
8985 2005-03-09 Raja R Harinath <rharinath@novell.com>
8987 Clean up a few partial-class semantics.
8988 Fixes test-357.cs and cs1618-2.cs.
8989 * cs-parser.jay (struct_declaration): Use 'current_class' as
8990 parent of newly-created struct. Remove call to Register ().
8991 Use 'pop_current_class' to complete handing the current struct.
8992 (interface_declaration): Likewise.
8993 (class_declaration): Likewise.
8994 (enum_declaration): Use 'current_class' as parent of newly created
8996 (delegate_declaration): Likewise.
8997 (pop_current_class): New function. This is used to handle closing
8998 up the 'current_class' and 'current_container', and pointing them
8999 to the enclosing class/container.
9000 (CSharpParser): Initialize 'current_class' too.
9001 * decl.cs (MemberCore): Add check for invariant: a partial
9002 container is not a parsed entity, and thus does not enclose any
9004 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
9005 (DeclSpace.BaseTypeExpr): Use it.
9006 (DeclSpace.LookupType): Add check for invariant.
9007 * class.cs (TypeContainer): Add check for invariant: a nested
9008 class should have the same NamespaceEntry as its enclosing class.
9009 (TypeContainer.EmitFieldInitializers): Make virtual.
9010 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
9012 (TypeContainer.Register): Remove.
9013 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
9014 null. Use TypeResolveEmitContext for resolving base types and
9015 interfaces. Move initialization of Parts.TypeBuilder here from
9017 (TypeContainer.DefineNestedTypes): ... here.
9018 (PartialContainer): Take a Namespace not a NamespaceEntry.
9019 (PartialContainer.Create): Don't use Register. Call the
9020 appropriate Add... function directly.
9021 (ClassPart): Take both the PartialContainer and the enclosing
9022 class as constructor arguments.
9023 (ClassPart.EmitFieldInitializers): Override.
9024 (ClassPart.PartFindNestedTypes): Remove.
9025 (FieldBase.GetInitializerExpression): Resolve the initializer
9026 expression in the emit context of the enclosing class.
9027 * tree.cs (RootTypes): Remove Register ().
9029 2005-03-08 Marek Safar <marek.safar@seznam.cz>
9031 * cs-parser.jay: Removed CS0134.
9033 * driver.cs: Removed CS1901.
9035 * expression.cs (SizeOf.DoResolve): Don't report CS0233
9036 for predefined types.
9038 2005-03-07 Duncan Mak <duncan@novell.com>
9040 * codegen.cs (Save): Catch UnauthorizedAccessException as
9041 well. Fixes bug #73454.
9043 2005-03-07 Marek Safar <marek.safar@seznam.cz>
9045 * cs-tokenizer.cs (xtoken): Add CS1035.
9047 * class.cs (MethodData.Define): Add CS0683.
9048 (FieldMember.ctor): Add CS0681.
9050 2005-03-07 Raja R Harinath <rharinath@novell.com>
9052 * ecore.cs (SimpleName.DoResolve): Rename from
9053 SimpleName.DoResolveAllowStatic.
9054 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
9055 Pass 'intermediate' flag to MemberStaticCheck.
9056 (SimpleName.MemberStaticCheck): Skip "static check" only in case
9057 of "intermediate" lookups via MemberAccess.
9058 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
9059 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
9061 2005-03-07 Raja R Harinath <rharinath@novell.com>
9064 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
9065 slipped in because of variable names that are identical to a
9066 builtin type's BCL equivalent ('string String;', 'int Int32;').
9067 (PropertyExpr.EmitInstance): Likewise.
9069 2005-03-04 Marek Safar <marek.safar@seznam.cz>
9071 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
9073 * report.cs (warning_ignore_table): Made public.
9075 2005-03-04 Raja R Harinath <rharinath@novell.com>
9078 * class.cs (MethodData.Emit): Pass 'container' to
9079 container.GetObsoleteAttribute instead of 'container.Parent'.
9081 2005-03-03 Marek Safar <marek.safar@seznam.cz>
9083 * cs-parser.jay: Add 1534 error test.
9085 * iterators.cs (Yield.CheckContext): Add error 1629.
9086 (Iterator.ctor): Save unsafe modifier.
9087 (MoveNextMethod.DoEmit): Restore unsafe context.
9089 * namespace.cs (UsingAlias): Better error message.
9091 2005-03-03 Dan Winship <danw@novell.com>
9093 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
9094 the warning message [#73219]
9096 2005-03-03 Raja R Harinath <rharinath@novell.com>
9098 Fix compile with MCS 1.0.0.0.
9099 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
9100 w_restore to not depend on string constant folding.
9102 2005-03-03 Raja R Harinath <rharinath@novell.com>
9104 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
9105 CS0246 check to users who passed 'silent = false'.
9106 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
9108 (SimpleName.SimpleNameResolve): Update.
9109 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
9110 (MemberAccess.IdenticalNameAndTypeName): Update.
9111 * doc.cs (FindDocumentedTypeNonArray): Update.
9113 2005-03-03 Raja R Harinath <rharinath@novell.com>
9115 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
9116 * parameters.cs (ComputeAndDefineParameters): Remove.
9117 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
9118 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
9119 Use GetParameterInfo.
9121 2005-03-02 Marek Safar <marek.safar@seznam.cz>
9123 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
9125 2005-03-02 Raja R Harinath <rharinath@novell.com>
9127 Unify DeclSpace.LookupType and DeclSpace.FindType.
9128 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
9129 is in charge of defining nested types on demand.
9130 (DeclSpace.LookupType): Use it when the current_type is a
9131 TypeBuilder. Use LookupTypeDirect for reflected types.
9132 (DeclSpace.FindType): Remove.
9133 (DeclSpace.LookupInterfaceOrClass): Likewise.
9134 (DeclSpace.DefineTypeAndParents): Likewise.
9135 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
9136 DeclSpace.LookupType.
9137 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
9138 * typemanager.cs (LookupType): Simplify.
9139 (AddUserType): Remove type from negative_hits.
9140 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
9141 * class.cs (TypeContainer.FindMembers): Move handling of nested
9143 (TypeContainer.FindMembers_NestedTypes): ... here.
9144 (TypeContainer.FindNestedType): Implement override.
9145 (ClassPart.FindNestedType): Delegate to PartialContainer.
9146 (ClassPart.PartFindNestedType): Looks up the nested types of the
9149 2005-03-02 Martin Baulig <martin@ximian.com>
9151 * class.cs (TypeContainer.DoDefineMembers): We also need a default
9152 static constructor in static classes.
9154 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
9156 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
9157 sizeParamIndex is not specified.
9159 2005-03-01 Marek Safar <marek.safar@seznam.cz>
9162 * report.cs (WarningMessage.IsEnabled): Missing null check.
9164 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9166 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
9167 in the fields and not in the properties.
9169 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
9171 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
9174 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9176 * attribute.cs: Small refactoring (improved robustness).
9177 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
9178 (ValidateGuid): Removed.
9179 (Resolve): Removed referenced to above mentioned.
9180 (GetAttributeUsage): Made private and changed to work without
9182 (GetIndexerAttributeValue): Don't crash.
9183 (GetConditionalAttributeValue): Ditto.
9184 (GetClsCompliantAttributeValue): Ditto.
9185 (ExtractSecurityPermissionSet): All attributes exceptions are
9187 (GetPropertyValue): New helper.
9188 (GetMethodImplOptions): New method.
9189 (DefinePInvokeMethod): Reuse common code. Implemented handling of
9190 some missing properties.
9192 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
9193 (Method.ApplyAttributeBuilder): Updated.
9195 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
9198 2005-02-28 Raja R Harinath <rharinath@novell.com>
9201 * report.cs (Report.SymbolRelatedToPreviousError): Handle
9202 non-simple types (array, pointer, reference).
9204 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9206 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
9208 * class.cs (MethodCore.IsDuplicateImplementation): Special error
9210 (Method.CheckBase): Catch wrong destructor here.
9211 (MethodData.Define): Add errors 550, 668.
9213 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
9215 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
9217 * pending.cs (VerifyPendingMethods): Add error 551.
9219 * typemanager.cs (CSharpName): Next error report helper.
9221 2005-02-25 Marek Safar <marek.safar@seznam.cz>
9223 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
9224 attributes. Removed useless attribute double check.
9225 It saves almost 2MBs for corlib.
9227 2005-02-25 Raja R Harinath <rharinath@novell.com>
9230 * statement.cs (ExpressionStatement.Resolve): Make robust to being
9231 called twice in case of error.
9233 2005-02-23 Chris Toshok <toshok@ximian.com>
9235 Fix compiler portions of #72827.
9236 * statement.cs (Block.Emit): call Begin/EndScope on the
9237 EmitContext instead of the ILGenerator.
9239 * codegen.cs (EmitContext.BeginScope): new method, call
9240 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
9242 (EmitContext.BeginScope): same, but EndScope and CloseScope
9244 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
9245 offset and call the superclass's OpenScope(int) with it.
9246 (SymbolWriter.CloseScope): get the current il
9247 offset and call superclass's CloseScope(int) with it.
9249 2005-02-23 Marek Safar <marek.safar@seznam.cz>
9251 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
9252 CS1677 for out and ref as well.
9254 * class.cs (Method.Define): Add error CS1599 detection.
9256 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
9258 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
9260 * delegate.cs (Delegate.Define): Add error CS1599 detection.
9262 * support.cs.cs (ModifierDesc): New helper method.
9264 2005-02-23 Raja R Harinath <rharinath@novell.com>
9265 Abin Thomas <projectmonokochi@rediffmail.com>
9266 Anoob V E <projectmonokochi@rediffmail.com>
9267 Harilal P R <projectmonokochi@rediffmail.com>
9270 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
9271 MemberLookup (used for error reporting) actually returns a result.
9272 Fix error report number (122, not 112).
9274 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
9275 Anoob V E <projectmonokochi@rediffmail.com>
9276 Harilal P R <projectmonokochi@rediffmail.com>
9279 * pending.cs (PendingImplementation.GetAbstractMethods):
9280 Find NonPublic members too.
9282 2005-02-22 Marek Safar <marek.safar@seznam.cz>
9284 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
9287 * class.cs (MethodCore.CheckMethodAgainstBase):
9288 Add error 239 report.
9290 2005-02-21 Raja R Harinath <rharinath@novell.com>
9293 * expression.cs (Invocation.IsApplicable): Make public.
9294 (Invocation.IsParamsMethodApplicable): Likewise.
9295 * delegate.cs (Delegate.VerifyApplicability): Don't use
9296 Invocation.VerifyArgumentCompat for parameter applicability
9297 testing. Use Invocation.IsApplicable and
9298 Invocation.IsParamsMethodApplicable.
9300 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9302 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
9304 * class.cs (Operator.Define): Add error 217 report.
9306 2005-02-21 Raja R Harinath <rharinath@novell.com>
9308 * namespace.cs (UsingEntry.Resolve): Undo change below.
9310 2005-02-21 Raja R Harinath <rharinath@novell.com>
9313 * ecore.cs (Expression.MemberLookupFailed): Add argument to
9314 disable the error message when the extended MemberLookup also
9316 (Expression.MemberLookupFinal): Update.
9317 (SimpleName.DoSimpleNameResolve): Update.
9318 * expression.cs (MemberAccess.ResolveNamespaceOrType):
9319 Don't use MemberLookupFinal.
9320 (New.DoResolve): Update.
9321 (BaseAccess.CommonResolve): Update.
9323 2005-02-21 Raja R Harinath <rharinath@novell.com>
9326 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
9327 occured previously, don't resolve again.
9329 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9332 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
9333 argument. Call ResolveAttributeUsage for unresolved.
9334 when types doesn't match ctor arguments.
9336 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
9337 for nested attribute classes.
9338 (Class.attribute_usage): Removed.
9339 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
9340 for attribute class.
9342 * ecore.cs (IsAttribute): Removed.
9344 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
9346 * rootcontext.cs (RegisterAttribute): Removed, attributes are
9348 (attribute_types): Removed.
9349 (EmitCode): Global attributes are emited as the latest.
9351 2005-02-18 Marek Safar <marek.safar@seznam.cz>
9353 * class.cs (EmitFieldInitializers): Don't emit field initializer
9354 for default values when optimilization is on.
9356 * constant.cs (Constant.IsDefaultValue): New property.
9358 * driver.cs: Add /optimize handling.
9362 * literal.cs: Implement new IsDefaultValue property.
9364 * rootcontext.cs (Optimize): New field, holds /optimize option.
9366 2005-02-18 Raja R Harinath <rharinath@novell.com>
9368 Fix crasher in re-opened #72347.
9369 * namespace.cs (Namespace.Lookup): Return null if
9370 DeclSpace.DefineType returns null.
9373 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
9375 2005-02-18 Raja R Harinath <rharinath@novell.com>
9377 Fix remainder of #63202. Change semantics of DoResolveLValue: it
9378 now returns null if it cannot resolve to an lvalue.
9379 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
9380 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
9381 returned null. Remove check for SimpleName.
9382 (EventExpr.DoResolveLValue): New.
9383 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
9384 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
9386 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
9388 (Unary.ResolveOperator): Move CS0211 check ...
9389 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
9391 (Unary.DoResolveLValue): Simplify.
9392 (AddressOf.DoResolveLValue): New.
9393 (ArrayAccess.DoResolveLValue): New.
9395 2005-02-16 Marek Safar <marek.safar@seznam.cz>
9397 * attribute.cs (Attribute.Resolve): Add arguments casting for
9398 when types doesn't match ctor arguments.
9400 2005-02-16 Raja R Harinath <rharinath@novell.com>
9402 Fix parts of #63202.
9403 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
9404 lookup of operator in base type. Ensure that all checks happen
9405 when the operator resolves to an "op_..." method.
9407 2005-02-15 Raja R Harinath <rharinath@novell.com>
9410 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
9411 'ignore_cs0104' parameter. Pass it to ...
9412 (NamespaceEntry.Lookup): ... this.
9413 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
9414 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9415 (TypeLookupExpression.DoResolveAsTypeStep): Update.
9416 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
9417 Update. Request that cs0104 errors be ignored.
9418 (ComposedCast.ResolveAsTypeStep): Update.
9420 2005-02-14 Raja R Harinath <rharinath@novell.com>
9423 * expression.cs (Invocation.BetterFunction): Remove support for
9424 comparing virtual functions and their overrides.
9425 (Invocation.IsOverride): New.
9426 (Invocation.OverloadResolve): Don't consider 'override' functions
9427 during candidate selection. Store them in a lookaside list.
9428 If the selected method is a 'virtual' function, use the list to
9429 find any overrides that are closer to the LHS type.
9431 2005-02-14 Marek Safar <marek.safar@seznam.cz>
9433 * expression.cs (New.DoResolve): Add complex core type reduction.
9434 (New.Constantify): Converts complex core type syntax like 'new int ()'
9437 2005-02-14 Raja R Harinath <rharinath@novell.com>
9439 * decl.cs (EntryType.EntryType): New constructor to create an
9440 updated copy of a cache entry.
9441 (MemberCache.AddMethods): Use it.
9442 (MemberCache.ClearDeclaredOnly): Remove.
9443 (MemberCache.MemberCache): Update.
9445 2005-02-11 Miguel de Icaza <miguel@novell.com>
9447 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
9448 variable. This one is represents the actual low-level declaration
9449 of the method, as opposed to the semantic level `IsStatic'.
9451 An anonymous method which is hosted into a static method might be
9452 actually an instance method. IsStatic would reflect the
9453 container, while MethodIsStatic represents the actual code
9456 * expression.cs (ParameterReference): Use the new MethodIsStatic
9457 instead of IsStatic.
9459 * anonymous.cs (AnonymousMethod.Compatible): Pass the
9460 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
9461 set on the current EmitContext.
9463 * expression.cs (Cast): Overload DoResolveLValue so we can pass
9464 resolve our casted expression as an LValue. This triggers the
9465 proper LValue processing that is later required by Assign.
9469 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
9471 2005-02-11 Marek Safar <marek.safar@seznam.cz>
9473 C# 2.0 Fixed buffer implementation
9475 * anonymous.cs: Update after RegisterHelperClass renaming.
9477 * attribute.cs (AttributeTester.fixed_buffer_cache):
9478 Cache of external fixed buffers.
9479 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
9480 implementation if field is fixed buffer else null.
9483 (TypeContainer.AddField): Accept FieldMember instead of Field.
9484 (FieldBase.IsFieldClsCompliant): Extracted code from
9485 VerifyClsCompliance descendant customization.
9486 (FixedField): New class handles fixed buffer fields.
9487 (FixedFieldExternal): Keeps information about imported fixed
9489 (IFixedField): Make access to internal or external fixed buffer
9492 * cs-parser.jay: Add fixed buffer parsing.
9494 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
9497 * expression.cs (Indirection): Extended implementation to accept
9499 (PointerArithmetic.Emit): Get element from fixed buffer as well.
9500 (ElementAccess.MakePointerAccess): Get type as parameter.
9501 (DoResolve): Add fixed buffer field expression conversion.
9502 (DoResolveLValue): Ditto.
9503 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
9504 (ArrayPtr): Derives from FixedBufferPtr.
9505 (ArrayPtr.Emit): Add extra emit for array elements.
9507 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
9509 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
9510 for compiler generated types.
9511 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
9513 * statement.cs (Fixed): Refactored to be easier add fixed buffer
9514 and consume less memory.
9515 (Fixed.Resolve): Add fixed buffer case.
9517 * typemanager.cs (compiler_generated_attr_ctor,
9518 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
9519 (HasElementType): Add our own implementation to work on every
9522 2005-02-11 Miguel de Icaza <miguel@novell.com>
9524 * anonymous.cs (CaptureContext): Track whether `this' has been
9527 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
9528 only captured `this' if it was implicitly done (instance
9529 methods/variables were used).
9531 * codegen.cs (EmitContext.CaptureThis): New method to flag that
9532 `this' must be captured.
9534 2005-01-30 Miguel de Icaza <miguel@novell.com>
9536 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
9537 is null it means that there has been no need to capture anything,
9538 so we just create a sibling.
9540 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9542 Just a partial fix. The other half is fairly elusive.
9544 2005-02-10 Raja R Harinath <rharinath@novell.com>
9546 Fix #52586, cs0121-4.cs.
9547 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
9548 and return a hashtable.
9549 (MemberCache.ClearDeclaredOnly): New.
9550 (MemberCache.MemberCache): Update to change. Make a deep copy of
9551 the method_hash of a base type too.
9552 (MemberCache.AddMethods): Adapt to having a deep copy of the base
9553 type methods. Overwrite entries with the same MethodHandle so
9554 that the ReflectedType is correct. The process leaves in base
9555 virtual functions and their overrides as distinct entries.
9556 (CacheEntry): Now a class instead of a struct. It shouldn't alter
9557 matters since it was boxed in a ArrayList before.
9558 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
9560 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
9561 case of a virtual function and its override (choose the overload
9563 (Invocation.OverloadResolve): Avoid 'override' members during
9564 'applicable_type' calculation.
9566 2005-02-09 Raja R Harinath <rharinath@novell.com>
9568 Combine two near-redundant caches.
9569 * typemanager.cs (method_params): Rename from method_internal_params.
9570 (TypeManager.GetParameterData): New. Replace
9571 Invocation.GetParameterData.
9572 (TypeManager.LookupParametersByBuilder): Remove.
9573 * expression.cs (Invocation.method_parameter_cache): Remove.
9574 (Invocation.GetParameterData): Remove.
9576 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
9579 2005-02-08 Raja R Harinath <rharinath@novell.com>
9582 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
9583 TypeManager.multicast_delegate_type is null, resolve it by looking
9584 up "System.MulticastDelegate".
9585 * rootcontext.cs (RootContext.ResolveCore): Simplify.
9587 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
9588 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
9589 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
9592 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
9593 (LabeledStatement.AddReference): New. Set 'referenced'.
9594 (Goto.Resolve): Use it.
9596 2005-02-05 John Luke <john.luke@gmail.com>
9598 * driver.cs: remove duplicate -doc line in Usage ()
9600 2005-02-04 Raja R Harinath <rharinath@novell.com>
9602 * location.cs (Location.AddFile): Fix CS2002 error report.
9604 2005-02-02 Martin Baulig <martin@ximian.com>
9606 * delegate.cs (Delegate.DefineType): Report an internal error if
9607 TypeManager.multicast_delegate_type is null. See bug #72015 for
9610 2005-02-02 Raja R Harinath <rharinath@novell.com>
9612 Fix a crasher in a variant of #31984.
9613 * const.cs (Constant.CheckBase): New override that defers the
9614 new-or-override check in case the base type hasn't been populated
9616 (Constant.Define): Ensure the new-or-override check is performed.
9618 2005-02-01 Duncan Mak <duncan@ximian.com>
9620 * const.cs (LookupConstantValue): Check that `ce' is not null
9621 before calling GetValue ().
9623 2005-02-01 Raja R Harinath <rharinath@novell.com>
9625 Fix test-334.cs (#69519).
9626 * cs-parser.jay (using_alias_directive): Pass in an expression to
9627 NamespaceEntry.UsingAlias.
9628 (using_namespace_directive): Pass in an expression to
9629 NamespaceEntry.Using.
9630 (namespace_name): Don't flatten to a string.
9631 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
9632 (NamespaceEntry.AliasEntry.Resolve): Lookup using
9634 (NamespaceEntry.UsingEntry): Likewise.
9635 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
9637 (NamespaceEntry.LookupForUsing): Remove.
9638 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
9640 (NamespaceEntry.Lookup): Remove support for dotted names.
9642 2005-02-01 Raja R Harinath <rharinath@novell.com>
9644 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
9646 (NamespaceEntry.ImplicitParent): Compute on demand.
9647 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
9648 parallels the current.
9649 (NamespaceEntry.LookupForUsing): Use it.
9650 (NamespaceEntry.Lookup): If the current namespace-entry is
9651 implicit, don't search aliases and using tables.
9653 2005-02-01 Raja R Harinath <rharinath@novell.com>
9656 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
9658 (TypeContainer.BaseCache): Compute on demand.
9659 (TypeContainer.FindMembers): Define constants and types if they're
9660 not already created.
9661 (FieldMember.Define): Move resetting of ec.InUnsafe before error
9663 * const.cs (Constant.Define): Make idempotent.
9665 2005-01-29 Miguel de Icaza <miguel@novell.com>
9667 * pending.cs: Produce better code (no nops produced by using Ldarg
9670 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
9671 i - 1' it should be arg + 1.
9675 2005-01-28 Raja R Harinath <rharinath@novell.com>
9677 * attribute.cs (Attribute.CheckAttributeType): Make private
9679 (Attribute.ResolveType): Make virtual.
9680 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
9681 handling of RootContext.Tree.Types.
9683 2005-01-27 Raja R Harinath <rharinath@novell.com>
9685 Update attribute-handling to use the SimpleName/MemberAccess
9687 * cs-parser.jay (attribute): Pass in an expression to the
9688 constructors of Attribute and GlobalAttribute.
9689 * attribute.cs (Attribute): Take an expression for the name.
9690 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
9691 passed in attribute name expression.
9692 (Attribute.CheckAttributeType): Use it.
9693 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
9694 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
9695 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
9696 argument to prevent error messages if the lookup fails.
9698 2005-01-27 Marek Safar <marek.safar@seznam.cz>
9700 * expression.cs (Indirection): Implemented IVariable interface
9701 to support indirection in AddressOf operator.
9702 (PointerArithmetic.Emit): Add optimalization for case where
9703 result can be precomputed.
9705 2005-01-26 Martin Baulig <martin@ximian.com>
9707 * class.cs (TypeContainer.AttributeTargets): Return the correct
9708 AttributeTargets depending on our `Kind' instead of throwing an
9709 exception; fixes #71632.
9711 2005-01-26 Marek Safar <marek.safar@seznam.cz>
9714 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
9717 2005-01-25 Raja R Harinath <rharinath@novell.com>
9720 * expression.cs (MemberAccess.DoResolve): Don't complain with
9721 cs0572 when the LHS of a member access has identical name and type
9724 2005-01-25 Marek Safar <marek.safar@seznam.cz>
9727 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
9729 Create custom PermissionSet only for PermissionSetAttribute.
9731 2005-01-24 Marek Safar <marek.safar@seznam.cz>
9734 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
9735 delegates in static class.
9737 2005-01-24 Martin Baulig <martin@ximian.com>
9739 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9740 merging an implicit block, just use its reachability.
9742 * statement.cs (Block.Resolve): Make the unreachable code check
9743 work wrt. implicit blocks; see test-337 from #63842.
9745 2005-01-21 Alp Toker <alp@atoker.com>
9747 * cs-parser.jay: destructor_declaration's container is PartialContainer
9748 not Class when partial types are used, so use Kind prop instead of
9751 2005-01-22 Miguel de Icaza <miguel@ximian.com>
9753 * cs-parser.jay: Improve error reporting when an interface
9756 2005-01-20 Dick Porter <dick@ximian.com>
9758 * support.cs: SeekableStreamReader fix from Sandor Dobos
9759 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
9760 chars are read. Fixes bug 70369.
9762 2005-01-20 Raja R Harinath <rharinath@novell.com>
9764 * cs-parser.jay (catch_clause): Simplify current_block handling
9767 2005-01-17 Miguel de Icaza <miguel@ximian.com>
9769 * convert.cs (ImplicitStandardConversionExists): Synchronize the
9770 code with ImplicitStandardConversion to handle the implicit
9771 conversion of method groups into valid delegate invocations.
9773 The problem is that in parameter handling we were using this code
9774 path. Fixes bug #64698
9776 2005-01-19 Raja R Harinath <rharinath@novell.com>
9778 * cs-parser.jay: Fix several infelicities.
9779 - Avoid assigning to the parser value stack. Code like
9780 '$3 = null' is unclean. Synthesize a value for the code block
9782 - Avoid using oob_stack for storing location information. Use ...
9783 (_mark_): ... this. New (empty) rule. Saves the current location
9785 (foreach_statement): Avoid using oob_stack for current_block
9786 handling. Use technique used in for_statement and
9787 using_statement. Synthesize a value for the code block to store
9788 additional intermediate information.
9790 2005-01-13 Miguel de Icaza <miguel@ximian.com>
9792 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
9793 of a different type is only allowed to private fields of a
9794 containing type, not on fields of a base class.
9796 See test-174.cs and error cs0122-9.cs
9798 2005-01-13 Raja R Harinath <rharinath@novell.com>
9800 Fix test-335.cs (bug #58126).
9801 * cs-parser.jay (argument): Split out non-expression parts of the
9802 rule into 'non_simple_argument'.
9803 (invocation_expression): Support parenthesized invocations with
9804 multiple arguments, and with single non-simple arguments.
9806 2005-01-13 Raja R Harinath <rharinath@novell.com>
9808 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
9811 2005-01-12 Raja R Harinath <rharinath@novell.com>
9813 Fix cs0038-1.cs, cs1640-6.cs.
9814 * ecore.cs (Expression.Resolve): Remove special-case for
9815 SimpleName in error-handling.
9816 (Expression.almostMatchedMembers): Relax access permission to
9818 (Expression.MemberLookupFailed): Handle duplicates in
9819 almostMatchedMembers list.
9820 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
9821 * expression.cs (New.DoResolve): Report CS1540 for more cases.
9822 * typemanager.cs (GetFullNameSignature): Use the MethodBase
9823 overload if the passed in MemberInfo is a MethodBase.
9825 2005-01-12 Marek Safar <marek.safar@seznam.cz>
9828 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
9829 for non-CAS & merge permission sets properly.
9831 2005-01-11 Raja R Harinath <rharinath@novell.com>
9833 Improve standard-compliance of simple name and member access
9834 resolution. Fixes bugs #52697, #57200, #67520, #69519.
9835 * ecore.cs (FullNamedExpression): New abstract base class
9836 for Namespaces and TypeExpressions.
9837 (ResolveFlags.SimpleName): Remove.
9838 (SimpleName): Remove support for dotted names.
9839 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
9840 DeclSpace.FindType and DeclSpace.LookupType.
9841 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
9842 (Expression.ExprClassName): Make member function.
9843 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
9844 a namespace. Remove creation of dotted "SimpleName"s.
9845 (MemberAccess.DoResolve): Likewise.
9846 * decl.cs (DeclSpace.Cache): Make private.
9847 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
9848 (DeclSpace.FindType): Update.
9849 (DeclSpace.LookupType): Move here from RootContext. Return a
9850 FullNamedExpression.
9851 * namespace.cs (Namespace): Derive from FullNamedExpression
9852 so that it can be part of expression resolution.
9853 (Namespace.Lookup): Return an FullNamedExpression.
9854 (NamespaceEntry.LookupAlias): Lookup aliases only in current
9856 * rootcontext.cs (NamespaceLookup): Remove.
9857 (LookupType): Move to DeclSpace.
9858 * attribute.cs (CheckAttributeType): Update.
9859 * doc.cs (FindDocumentedType): Remove allowAlias argument.
9860 (FindDocumentedTypeNonArray): Likewise.
9862 2005-01-11 Raja R Harinath <rharinath@novell.com>
9864 Fix cs0509.cs, cs1632.cs.
9865 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
9866 is the same as IsInterface.
9867 (TypeContainer.GetClassBases): Likewise.
9868 * statement.cs (LabeledStatement.ig): New field.
9869 (LabeledStatement.LabelTarget): Save ILGenerator which created the
9871 (LabeledStatement.DoEmit): Check that the label was created with
9872 the same ILGenerator.
9874 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9877 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
9878 accessors to its properties.
9880 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
9881 from accessors to property.
9883 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9886 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
9889 2005-01-08 Miguel de Icaza <miguel@ximian.com>
9891 * attribute.cs: Check for null and empty strings.
9893 I have lost another battle to Paolo.
9895 2005-01-07 Marek Safar <marek.safar@seznam.cz>
9898 * class.cs (PropertyMethod): Set Parent field in ctors.
9899 (SetMethod.InternalParameters): Add unsafe switch hack.
9900 Override MarkForDuplicationCheck where it is appropriate.
9902 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
9903 It says whether container allows members with the same name.
9905 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
9906 Removed is_method parameter.
9908 2005-01-06 Duncan Mak <duncan@ximian.com>
9910 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
9911 because the previous change led to incorrect reporting of CS1032
9912 ("Cannot define/undefine preprocessor symbols after first token in
9913 file"). Instead of using `tokens_seen' as the only flag that
9914 triggers CS1040, introduce `comments_seen'. This new flag is used
9915 to signify having seen comments on the current line, so it is
9916 unset after a newline.
9918 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9920 * doc.cs : When searching for a type, find nested type too.
9921 This fixes bug #71040.
9923 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9926 - Warn missing member comment on those classes which also does not
9927 have doc comments. Fixed bug #71041.
9928 - Don't warn missing doc comment on default constructor.
9931 2005-01-06 Duncan Mak <duncan@ximian.com>
9933 * cs-tokenizer.cs (xtoken): After handling traditional C-style
9934 comments, set `tokens_seen' to true. This allows us to detect
9935 misplaced preprocessor directives (i.e. not at the beginning of
9936 the a line, nor after whitespaces). In that case, report error
9937 CS1040. This fixes bug #56460.
9939 * cs-parser.jay (interface_member_declaration): Add checks for
9940 IsExplicitImpl, and report CS0541 error if an interface member is
9941 defined as an explicit interface declaration.
9943 2005-01-06 Marek Safar <marek.safar@seznam.cz>
9946 * class.cs (PropertyMethod): Set Parent field in ctors.
9947 (SetMethod.InternalParameters): Add unsafe switch hack.
9949 * decl.cs (MemberCore.Parent): Cannot be readonly.
9951 2005-01-06 Raja R Harinath <rharinath@novell.com>
9953 * decl.cs (DeclSpace.ResolveType): Remove.
9954 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
9955 Merge in code from ...
9956 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
9957 * class.cs, enum.cs: Update to changes.
9959 2005-01-06 Miguel de Icaza <miguel@ximian.com>
9961 * anonymous.cs: Ensure that we init the scope of our parent if it
9962 has not been initialized yet.
9964 2004-12-30 Duncan Mak <duncan@ximian.com>
9966 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
9967 if field.FieldBuilder is null. Fixes #70758.
9969 * convert.cs: Fixed some typos and updated some of the comments.
9970 (ImplicitStandardConversionExists):
9971 (TryImplicitIntConversion): If `target_type' is an interface and
9972 the type of `ic' implements this interface, return true or a new
9973 BoxedCast instead of null. This fixes #70468.
9975 2004-12-29 Duncan Mak <duncan@ximian.com>
9977 * expression.cs (Argument.Emit): Check that Expr is
9978 IMemoryLocation before casting to it, and report CS1510 otherwise.
9982 2004-12-21 Ben Maurer <bmaurer@ximian.com>
9984 * statement.cs (Block.ThisVariable): remove the recursion here, to
9985 make the --profile more sane.
9987 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
9989 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
9990 assembly, by JB Evain.
9992 2004-12-17 Raja R Harinath <rharinath@novell.com>
9994 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
9995 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
9996 "parent" refers to enclosing type/class. "base" refers to superclass.
9998 2004-12-17 Raja R Harinath <rharinath@novell.com>
10000 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10001 Ensure that we only have GlobalAttributes.
10002 * attribute.cs (Attribute.Emit): Make non-virtual.
10003 (GlobalAttribute.Emit): Remove.
10004 (Attribute.Resolve): Make virtual.
10005 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
10006 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
10007 the argument. Don't create one.
10008 (Attribute.GetObsoleteAttribute): Likewise.
10009 (Attribute.GetClsCompliantAttributeValue): Likewise.
10010 * class.cs, decl.cs: Update to changes.
10012 2004-12-17 Marek Safar <marek.safar@seznam.cz>
10014 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
10016 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
10018 * statement.cs (Foreach.Resolve): Add error 186 report.
10020 2004-12-16 Marek Safar <marek.safar@seznam.cz>
10022 * expression.cs (Conditional.DoResolve): Add warning 429.
10024 * statement.cs (If.Resolve): Add warning 665.
10026 2004-12-16 Raja R Harinath <rharinath@novell.com>
10028 New invariant: RootContext.Tree.Types.NamespaceEntry == null
10029 except when in the parser, and in GlobalAttribute.
10030 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
10031 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
10032 RootContext.Tree.Types.NamespaceEntry once work is done.
10033 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
10034 and resets RootContext.Tree.Types.NamespaceEntry.
10036 2004-12-15 Marek Safar <marek.safar@seznam.cz>
10038 * cs-parser.jay: Don't create a block for every variable.
10040 2004-12-14 Miguel de Icaza <miguel@ximian.com>
10042 * location.cs: Provide extra information.
10044 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
10045 variables from the captured environment, it is the ldarg_0.
10047 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10049 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
10052 * class.cs: Changed warning level for 169 to avoid developer
10053 displeasure from warning flooding. It will be changed back when they
10054 fix most of current BCL warnings.
10056 * RootContext.cs: Pushed default WarningLevel to 3.
10058 * statement.cs: Removed unused variable.
10060 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10062 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
10063 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
10064 Add error 502 report.
10065 (StaticClass.DefineType): Add error 441 report.
10066 (Class.AllowedModifiersProp): New virtual property as temporary
10067 extension to AllowedModifiers.
10068 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10069 to share implementation with StaticClass and don't call virtual
10072 * driver.cs (MainDriver): Add error 1558 test.
10074 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
10075 report. Moved error 36 test here.
10077 * statement.cs (Throw.Resolve): Add error 724 report.
10079 * typemanager.cs: Add out_attribute_type core type.
10081 2004-12-13 Marek Safar <marek.safar@seznam.cz>
10083 * class.cs (TypeContainer.VerifyClsCompliance): Add error
10085 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
10087 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
10090 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
10092 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
10093 Add error 3023 report.
10094 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
10096 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
10099 2004-12-12 John Luke <john.luke@gmail.com>
10101 * driver.cs (AddArgs): take -- into account when
10102 adding arguments, fixes bug 65710
10104 2004-12-12 Martin Baulig <martin@ximian.com>
10106 * expression.cs (Unary.TryReduceNegative): Added support for
10107 SByteConstant and ByteConstant.
10108 (Unary.Reduce): Check error values from TryReduceNegative().
10110 2004-12-10 Marek Safar <marek.safar@seznam.cz>
10112 * attributes.cs (Attribute.Resolve): Avoid multiple error report
10113 and report exception as error 182.
10115 2004-12-10 Raja R Harinath <rharinath@novell.com>
10117 * driver.cs (Main): Fix message when there are warnings.
10119 2004-12-09 Miguel de Icaza <miguel@ximian.com>
10121 * delegate.cs: Fixed my fix from yesterday, sorry about that.
10123 2004-12-09 Marek Safar <marek.safar@seznam.cz>
10125 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
10126 Reduced number of warnings.
10128 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
10130 2004-12-08 Miguel de Icaza <miguel@ximian.com>
10132 * driver.cs: Removed message.
10134 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
10136 2004-12-08 <vargaz@freemail.hu>
10138 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
10140 2004-12-08 Martin Baulig <martin@ximian.com>
10142 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
10143 instead of a CS3002 for properties and indexer.
10145 2004-12-08 Martin Baulig <martin@ximian.com>
10147 * decl.cs (MemberName.ToString): Make this work again.
10149 2004-12-08 Marek Safar <marek.safar@seznam.cz>
10151 * attribute.cs (Resolve): Add error 591 detection.
10153 * class.cs (FieldMember.Define): Add error 1547 detection.
10154 (Indexer.Define): Add error 620 detection.
10155 (Operator.Define): Add error 590 detection.
10157 * ecore.cs: Missing argument for error 79.
10159 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
10162 2004-12-07 Marek Safar <marek.safar@seznam.cz>
10165 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
10168 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
10170 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10171 Some operator comments were suppressed.
10172 * doc.cs : Implicit/explicit operator name in doc comments are like
10173 "op_Explicit(type)~returnType", so added suffix handling.
10175 2004-12-07 Martin Baulig <martin@ximian.com>
10178 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
10179 (MemberCore.GetClsCompliantAttributeValue): Likewise.
10180 (DeclSpace.ec): New protected field; store the EmitContext here.
10181 (DeclSpace.EmitContext): New public property; moved here from
10183 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
10186 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
10187 (Enum.Emit): Don't create a new EmitContext.
10189 * delegate.cs (Delegate.DefineType): Always create the
10192 * iterators.cs (Iterators.DefineIterator): Create a new
10193 EmitContext and store it in `ec'.
10195 2004-08-24 Martin Baulig <martin@ximian.com>
10198 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10199 this for accessibility checks.
10200 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10201 IsNestedFamilyAccessible.
10202 (TypeManager.IsSubclassOf): New method, do what the name actually
10205 2004-12-06 Raja R Harinath <rharinath@novell.com>
10207 Fix crash on cs0657-17.cs.
10208 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10209 Use RootContext.Tree.Types, not 'new RootTypes ()'.
10210 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
10211 the case where the NamespaceEntry gets overwritten.
10213 2004-12-06 Marek Safar <marek.safar@seznam.cz>
10215 Fixed #69195, #56821
10216 * ecore.cs (ResolveBoolean): Tiny refactoring.
10218 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
10219 of right expression resolving when left is false constant and
10220 operator is LogicalAnd OR true constant and operator is LogicalOr.
10222 * statement.cs (ResolveUnreachable): Always reports warning.
10224 2004-12-05 Miguel de Icaza <miguel@ximian.com>
10226 * class.cs: Distinguish between 1721 and 1722 (just a little help
10227 for the programmer).
10229 2004-12-03 Miguel de Icaza <miguel@ximian.com>
10231 * delegate.cs: Only allow this on new versions of the language.
10233 2004-12-02 Duncan Mak <duncan@ximian.com>
10235 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
10237 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
10238 here as a static method. Take an additional bool out parameter
10239 `must_do_cs1540_check' for signaling to InstanceResolve.
10240 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
10241 member field from PropertyExpr class and made it an argument of
10242 the method instead.
10243 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
10244 check for MarshalByRefObject, and report CS0122 instead of CS1540.
10245 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
10246 and `remove_accessor' as well as InstanceResolve: report CS0122
10251 2004-12-03 Raja R Harinath <rharinath@novell.com>
10253 Fix test-327.cs, test-328.cs, and put in early infrastructure
10254 for eventually fixing #52697.
10255 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
10256 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
10257 from other methods.
10258 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
10259 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
10260 (VerifyUsing, error246): Update.
10261 * rootcontext.cs (RootContext.NamespaceLookup): Just use
10262 'NamespaceEntry.LookupNamespaceOrType'.
10264 2004-12-03 Martin Baulig <martin@ximian.com>
10266 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10267 method as our child, call AnonymousMethod.Compatible() on it.
10269 2004-12-03 Raja R Harinath <rharinath@novell.com>
10271 Disable XML documentation support in 'basic' profile.
10272 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
10273 Redirect XmlElement to System.Object.
10274 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
10275 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
10276 * mcs.exe.sources: Add doc-bootstrap.cs.
10277 * doc-bootstrap.cs: New file. Contains empty stub implementation
10280 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
10282 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
10283 comments are allowed.
10285 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10287 * delegate.cs: Add checks for subtypes in paramaters and return values
10288 in VerifyMethod () to add support for Covariance/Contravariance
10291 2004-12-02 Miguel de Icaza <miguel@ximian.com>
10293 * report.cs: Remove extra closing parenthesis.
10295 * convert.cs (Error_CannotImplicitConversion): If the name of the
10296 types are the same, provide some extra information.
10298 * class.cs (FieldBase): Use an unused bit field from the field to
10299 encode the `has_offset' property from the FieldMember. This saves
10300 a couple of Ks on bootstrap compilation.
10302 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10303 method as our child, return the AnonymousMethod resolved
10306 * expression.cs (New.DoResolve): Allow return values from
10307 NewDelegate to also include AnonymousMethods.
10311 2004-12-02 Marek Safar <marek.safar@seznam.cz>
10314 * attribute.cs (Resolve): Improved implementation of params
10315 attribute arguments.
10317 * support.cs (ParameterData): Add HasParams to be faster.
10319 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
10321 all things are for /doc support:
10323 * doc.cs: new file that supports XML documentation generation.
10324 * mcs.exe.sources: added doc.cs.
10326 Handle /doc command line option.
10327 Report error 2006 instead of 5 for missing file name for /doc.
10328 Generate XML documentation when required, after type resolution.
10330 Added support for picking up documentation (/// and /** ... */),
10331 including a new XmlCommentState enumeration.
10333 Added lines to fill Documentation element for field, constant,
10334 property, indexer, method, constructor, destructor, operator, event
10335 and class, struct, interface, delegate, enum.
10336 Added lines to warn incorrect comment.
10338 Added Documentation field (passed only when /doc was specified).
10340 Added DocComment, DocCommentHeader, GenerateDocComment() and
10341 OnGenerateDocComment() and some supporting private members for
10342 /doc feature to MemberCore.
10344 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
10346 Added overriden DocCommentHeader.
10348 Added overriden DocCommentHeader and GenerateDocComment().
10350 2004-12-01 Miguel de Icaza <miguel@ximian.com>
10352 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
10353 unwrapping the enumeration values, chain to
10354 DoConstantNumericPromotions again, so we can promote things to the
10355 fundamental types (takes care of enums that are bytes, sbytes).
10359 2004-12-01 Raja R Harinath <rharinath@novell.com>
10361 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
10362 Fix long-standing bug in type-lookup. Use FindType instead of
10363 LookupType when ec.ResolvingTypeTree.
10364 (Attribute.ResolveType, Attribute.Resolve)
10365 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
10367 (Attributes.Search): Remove internal version. Update.
10368 (Attributes.SearchMulti): Update.
10369 (Attributes.GetClsCompliantAttribute): Remove.
10370 (Attributes.GetIndexerNameAttribute): Remove.
10371 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
10372 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
10373 * class.cs (Indexer.Define): Likewise.
10375 2004-12-01 Marek Safar <marek.safar@seznam.cz>
10378 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
10379 MarshallByReference members access.
10381 * expression.cs: Use CheckMarshallByRefAccess;
10382 Better error CS0197 message.
10384 * report.cs: Print whole related error message.
10386 2004-11-30 Raja R Harinath <rharinath@novell.com>
10388 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
10389 the current directory to help debugging.
10391 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10393 * class (GetClassBases): Better error 60 report.
10394 (EventProperty): Disabled warning 67 detection.
10396 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10399 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
10401 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
10404 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10407 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
10409 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
10411 2004-11-26 Miguel de Icaza <miguel@ximian.com>
10413 * attribute.cs (Attribute.Resolve): Refine error reporting and
10414 report a cs0117 if the identifier does not exist, to distinguish
10415 from 0617 which is a miss-use of the actual identifier.
10417 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
10418 between cs0070 and cs0079.
10420 * class.cs (MemberBase.DoDefine): When reporting a wrong
10421 accessibility level, we use MethodCore to compare instead of
10422 Method (this was a regression in some refactoring effort).
10424 So now we correctly report cs0056 again.
10426 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
10427 testing the target_type (which was known to be object_type) and
10428 not the source type (which is anonymous_method).
10430 Fixed reporting of error cs1660.
10432 * expression.cs (UserCast.Source): Expose the underlying cast.
10434 * statement.cs (Switch.SwitchGoverningType): Sort the list of
10435 allowed types to find a match to int32 first (most common).
10437 In addition, it ignores any ImplicitUserConversions that did an
10438 internal implicit conversion (as the switch statement allows only
10439 one integral conversion to exist).
10441 * class.cs (PartialContainer.Create): rename `name' to
10442 `member_name' for clarity. Then replace the string calls with a
10443 call to MemberName.GetPartialName, as now using
10444 MemberName.ToString is an error (this is due to the side effects
10445 it had, that were fixed in the past).
10447 This will restore the error reporting on a number of partial class
10448 errors that were missusing this (and getting an exception as a
10449 results, which is now just a plain textual warning, because
10450 yyparse debug output would crash otherwise).
10452 2004-11-26 Raja R Harinath <rharinath@novell.com>
10454 * Makefile (PROGRAM_INSTALL_DIR): Remove.
10456 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10458 * rootcontext.cs (LookupType): Make sure to cache lookups that
10459 don't give us a negative result. This saves about 5% of corlib
10462 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10464 * report.cs (AbstractMessage.Print): messages are sent to stderr
10466 * class.cs (TypeContainer.GetClassBases): It is an error to have a
10467 non-interface in the list of interfaces (at this point, either
10468 parent was properly set, or a base class is being listed in the
10469 interfaces section).
10471 This flags error 1722, and resolves the crash from bug 69259.
10473 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10475 * statement.cs (Using.EmitExpressionFinally): make this work right
10476 for valuetypes. Fixes 69926.
10478 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10480 * const.cs (Const.ChangeType): Cope with the "0 literal can be
10481 converted to an enum" here, before we try to change the underlying
10482 type. This code exists, but it is a different code path than the
10483 one used while encoding constants.
10485 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
10486 old bug: when converting from the null literal to a pointer,
10487 return an EmptyCast, not the NullLiteral.
10489 This fixes #69921, the recent null_type changes probably made this
10490 bug more prominent.
10492 (ImplicitReferenceConversionExists): In addition, resynchronized
10493 the code here, so it matches the same code in
10494 ImplicitReferenceConversionExists for the `from any class-type S
10495 to any interface-type T'.
10498 2004-11-25 Marek Safar <marek.safar@seznam.cz>
10500 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
10502 2004-11-24 Miguel de Icaza <miguel@ximian.com>
10504 * cs-parser.jay: Use verbosity accordingly.
10506 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10508 * expression.cs (Unary.ResolveOperator): Do not report warning;
10509 AddressOf reads from variable.
10511 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
10513 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10517 * attribute.cs (Attributable): Removed CheckTargets.
10518 (Attributes.Emit): Explicit attribute targets are tested here.
10520 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
10521 not enabled for interfaces.
10523 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
10524 (GetAssemblyName): Ouch next bug there.
10526 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10528 * expression.cs: Error 275 added.
10530 2004-11-23 Marek Safar <marek.safar@seznam.cz>
10532 Fix bug #69177 (Implemented decimal constant support)
10534 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
10535 (BinaryFold): Add DecimalConstant.
10537 * const.cs (Define): Decimal constant
10539 (ChangeType): Add decimal type handling.
10540 (LookupConstantValue): Don't set value for decimal type but
10541 emit DecimalConstantAttribute. Needed for constant optimization.
10543 * constant.cs (ToDecimal): New method.
10544 (ConvertToDecimal): New method.
10545 (IntConstant): Implemented ConvertToDecimal.
10546 (DecimalConstant.Emit): Emit optimized version for decimals in
10549 * expression.cs (ResolveOperator): Changed order of constant
10550 reduction to work correctly with native types which have
10551 overloaded operators.
10552 (ResolveMemberAccess): Extract constant value from attribute
10555 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
10557 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
10558 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
10559 (ChangeType): Decimal is special.
10560 (TypeToCoreType): Add decimal type.
10562 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10564 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
10567 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10569 * class.cs (EventField.ApplyAttributeBuilder): Fix error
10572 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10574 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
10576 * pending.cs (PendingImplementation): Grab only interfaces.
10578 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10580 * statement.cs (ForeachHelperMethods): Add location member and
10581 error 202 detection.
10583 2004-11-19 Raja R Harinath <rharinath@novell.com>
10585 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
10586 automatically handled by executable.make.
10587 (PROGRAM): Make profile-specific.
10589 2004-11-18 Marek Safar <marek.safar@seznam.cz>
10591 * expression.cs (DoResolveBase): Fixed wrong warning for out
10594 2004-11-18 Martin Baulig <martin@ximian.com>
10596 Merged latest changes into gmcs. Please keep this comment in
10597 here, it makes it easier for me to see what changed in MCS since
10598 the last time I merged.
10600 2004-11-17 Raja R Harinath <rharinath@novell.com>
10602 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
10603 (TypeHandle.GetMemberCache): New.
10604 (TypeHandle.TypeHandle): Update.
10605 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
10606 (TypeManager.LookupParentInterfacesCache):
10607 Rename from LookupInterfaceCache. Optimize slightly.
10608 (TypeManager.MemberLookup_FindMembers): Update.
10609 * decl.cs (MemberCache.MemberCache): Set Container to null in the
10610 multi-type variant.
10611 (AddCacheContents): Rename from AddHashtable.
10612 * class.cs (TypeContainer.parent_container): Remove.
10613 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
10614 (TypeContainer.DoDefineMembers): Don't initialize it.
10615 Update to name changes.
10617 2004-11-17 Miguel de Icaza <miguel@ximian.com>
10619 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
10620 that factors the code to check access modifiers on override.
10622 (PropertyBase): Use the code here.
10624 Patch from Lluis S'anchez, fixes bug #69361.
10626 2004-11-15 Miguel de Icaza <miguel@ximian.com>
10628 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
10629 routine that is used to report the use of a captured variable
10630 whose address has been taken.
10632 There are two checks: one when variables are being captured and
10633 the other check is when the address of a variable is taken.
10635 (because an anonymous methods might be resolved before *or* after
10636 the address has been taken) and
10638 * expression.cs (Conditional.DoResolve): Remove the special
10639 casing that Martin added to trueExpr and falseExpr being both
10640 NullLiteral. We get the right behavior now just by introducing
10641 the null_type into the compiler.
10643 * convert.cs (ExplicitConversion): Change the code to use
10644 null_type instead of testing `expr is NullLiteral'.
10645 (ImplicitConversionStandard): use null_type too.
10646 (ImplicitReferenceConversionExists): use null_type too.
10647 (ImplicitReferenceConversion): use null_type too.
10649 * literal.cs: The type of `NullLiteral' is now null_type instead
10651 (Resolve): Set the type here.
10653 * typemanager.cs: Introduce null_type.
10655 2004-11-17 Martin Baulig <martin@ximian.com>
10657 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
10658 direction, like FindMembers() does. Fixes #69546, testcase is in
10661 2004-11-16 Martin Baulig <martin@ximian.com>
10663 This is based on a patch from Marek Safar, see bug #69082.
10664 Fixes bugs #63705 and #67130.
10666 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
10667 method; create a MemberCache for an interface type and cache the
10670 * decl.cs (IMemberContainer.ParentContainer): Removed.
10671 (IMemberContainer.ParentCache): New property.
10672 (MemberCache.SetupCacheForInterface): Removed.
10673 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
10674 to create a cache for an interface's "parent".
10676 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
10679 2004-11-16 Martin Baulig <martin@ximian.com>
10681 Merged back from gmcs; these changes already went into gmcs a
10682 couple of weeks ago.
10685 (TypeManager.AddUserType): Removed the `ifaces' argument.
10686 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
10688 (TypeManager.AddUserInterface): Removed.
10689 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
10691 (TypeManager.GetInterfaces): Likewise.
10692 (TypeManager.GetExplicitInterfaces): Likewise.
10694 * ecore.cs (TypeExpr.GetInterfaces): Removed.
10696 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
10697 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
10699 2004-11-14 Ben Maurer <bmaurer@ximian.com>
10701 * statement.cs: Avoid adding bools to a hashtable.
10703 2004-11-07 Miguel de Icaza <miguel@ximian.com>
10705 * expression.cs (Invocation.OverloadResolve): Flag error if we are
10706 calling an unsafe method from a safe location.
10708 2004-11-06 Marek Safar <marek.safar@seznam.cz>
10711 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
10713 2004-11-06 Miguel de Icaza <miguel@ximian.com>
10715 * namespace.cs (VerifyUsing): use GetPartialName instead of
10718 2004-11-05 Miguel de Icaza <miguel@ximian.com>
10720 * statement.cs (Return.Resolve): Fix regression in typo: if
10721 `in_exc', we have to request a NeedReturnLabel, this was a typo
10722 introduced in the anonymous method check-in. Fixes #69131.
10724 * Indexers were using the ShortName when defining themselves,
10725 causing a regression in the compiler bootstrap when applying the
10726 patch from 2004-11-02 (first part), now they use their full name
10727 and the bug is gone.
10729 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
10731 * driver.cs: Strip the path from the names of embedded resources. Fixes
10734 2004-11-04 Raja R Harinath <rharinath@novell.com>
10736 Fix error message regression: cs0104-2.cs.
10737 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
10738 (AliasEntry.Resolve): Update.
10739 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
10741 (RootContext.LookupType): Update.
10743 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
10745 * cs-parser.jay: Add support for handling accessor modifiers
10746 * class: Add support port accessor modifiers and error checking,
10747 define PropertyMethod.Define as virtual (not abstract anymore)
10748 * ecore.cs: Add checking for proeprties access with access modifiers
10749 * iterators.cs: Modify Accessor constructor call based in the modified
10751 2004-11-02 Ben Maurer <bmaurer@ximian.com>
10753 * expression.cs (StringConcat): Handle being called twice,
10754 as when we have a concat in a field init with more than two
10757 2004-11-02 Miguel de Icaza <miguel@ximian.com>
10759 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
10760 special case explicit implementations, we should always produce
10761 the .property or .event declaration.
10763 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
10764 since it will not return correct data if people use this
10765 unresolved in the presence of using statements (see test-313).
10767 * class.cs (MethodData.Define): If we are an explicit interface
10768 implementation, set the method name to the full name of the
10769 interface plus the name of the method.
10771 Notice that using the method.MethodName.GetFullName() does not
10772 work, as it will only contain the name as declared on the source
10773 file (it can be a shorthand in the presence of using statements)
10774 and not the fully qualifed type name, for example:
10778 class D : ICloneable {
10779 object ICloneable.Clone () {
10783 Would produce a method called `ICloneable.Clone' instead of
10784 `System.ICloneable.Clone'.
10786 * namespace.cs (Alias.Resolve): Use GetPartialName.
10788 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10790 * cs-parser.jay: Add error 1055 report.
10792 2004-11-01 Miguel de Icaza <miguel@ximian.com>
10794 * assign.cs (Assign.DoResolve): Only do the transform of
10795 assignment into a New if the types are compatible, if not, fall
10796 through and let the implicit code deal with the errors and with
10797 the necessary conversions.
10799 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10801 * cs-parser.jay: Add error 1031 report.
10803 * cs-tokenizer.cs: Add location for error 1038.
10805 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10807 * cs-parser.jay: Add error 1016 report.
10809 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10811 * cs-parser.jay: Add errors 1575,1611 report.
10813 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10815 * cs-parser.jay: Add error 1001 report.
10817 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10820 * attribute.cs (GetMarshal): Add method argument for
10821 caller identification.
10823 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
10824 agument for GetMarshal and RuntimeMissingSupport.
10826 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10828 * attribute.cs (ExtractSecurityPermissionSet): Removed
10829 TypeManager.code_access_permission_type.
10831 * typemanager.cs: Removed TypeManager.code_access_permission_type.
10833 2004-10-27 Miguel de Icaza <miguel@ximian.com>
10835 * expression.cs (LocalVariableReference.DoResolveLValue): Check
10836 for obsolete use of a variable here. Fixes regression on errors
10837 cs0619-25 and cs0619-26.
10839 2004-10-27 Marek Safar <marek.safar@seznam.cz>
10841 Fix #62358, implemented security attribute encoding.
10843 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
10844 Tests permitted SecurityAction for assembly or other types.
10845 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
10846 data from SecurityPermissionAttribute to PermisionSet class.
10848 * class.cs (ApplyAttributeBuilder): Added special handling
10849 for System.Security.Permissions.SecurityAttribute based types.
10851 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
10852 special handling for System.Security.Permissions.SecurityAttribute
10855 * enum.cs (ApplyAttributeBuilder): Added special handling
10856 for System.Security.Permissions.SecurityAttribute based types.
10858 * parameter.cs (ApplyAttributeBuilder): Added special handling
10859 for System.Security.Permissions.SecurityAttribute based types.
10861 * rootcontext.cs: Next 2 core types.
10863 * typemanager.cs (TypeManager.security_permission_attr_type):
10864 Built in type for the SecurityPermission Attribute.
10865 (code_access_permission_type): Build in type.
10867 2004-10-17 Miguel de Icaza <miguel@ximian.com>
10869 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
10870 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
10871 all of this information into
10872 EmitContext.EmitCapturedVariableInstance.
10874 * codegen.cs (EmitCapturedVariableInstance): move here the
10875 funcionality of emitting an ldarg.0 in the presence of a
10876 remapping. This centralizes the instance emit code.
10878 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
10879 then emit a load of this: it means that we have reached the
10880 topmost ScopeInfo: the one that contains the pointer to the
10881 instance of the class hosting the anonymous method.
10883 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
10884 captures to the topmost CaptureContext.
10886 2004-10-12 Miguel de Icaza <miguel@ximian.com>
10888 * expression.cs (LocalVariableReference): Move the knowledge about
10889 the iterators into codegen's EmitCapturedVariableInstance.
10891 2004-10-11 Miguel de Icaza <miguel@ximian.com>
10893 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
10894 all code paths return a value from an anonymous method (it is the
10895 same as the 161 error, but for anonymous methods).
10897 2004-10-08 Miguel de Icaza <miguel@ximian.com>
10899 The introduction of anonymous methods in the compiler changed
10900 various ways of doing things in the compiler. The most
10901 significant one is the hard split between the resolution phase
10902 and the emission phases of the compiler.
10904 For instance, routines that referenced local variables no
10905 longer can safely create temporary variables during the
10906 resolution phase: they must do so from the emission phase,
10907 since the variable might have been "captured", hence access to
10908 it can not be done with the local-variable operations from the runtime.
10912 (Block.Flags): New flag `IsTopLevel' to indicate that this block
10913 is a toplevel block.
10915 (ToplevelBlock): A new kind of Block, these are the blocks that
10916 are created by the parser for all toplevel method bodies. These
10917 include methods, accessors and anonymous methods.
10919 These contain some extra information not found in regular blocks:
10920 A pointer to an optional CaptureContext (for tracking captured
10921 local variables and parameters). A pointer to the parent
10924 (Return.Resolve): Catch missmatches when returning a value from an
10925 anonymous method (error 1662).
10926 Invoke NeedReturnLabel from the Resolve phase instead of the emit
10929 (Break.Resolve): ditto.
10931 (SwitchLabel): instead of defining the labels during the
10932 resolution phase, we now turned the public ILLabel and ILLabelCode
10933 labels into methods called GetILLabelCode() and GetILLabel() that
10934 only define the label during the Emit phase.
10936 (GotoCase): Track the SwitchLabel instead of the computed label
10937 (its contained therein). Emit the code by using
10938 SwitchLabel.GetILLabelCode ().
10940 (LocalInfo.Flags.Captured): A new flag has been introduce to track
10941 whether the Local has been captured or not.
10943 (LocalInfo.IsCaptured): New property, used to tell whether the
10944 local has been captured.
10946 * anonymous.cs: Vastly updated to contain the anonymous method
10949 The main classes here are: CaptureContext which tracks any
10950 captured information for a toplevel block and ScopeInfo used to
10951 track the activation frames for various local variables.
10953 Each toplevel block has an optional capture context associated
10954 with it. When a method contains an anonymous method both the
10955 toplevel method and the anonymous method will create a capture
10956 context. When variables or parameters are captured, they are
10957 recorded on the CaptureContext that owns them, for example:
10961 MyDelegate d = delegate {
10966 Here `a' will be recorded as captured on the toplevel
10967 CapturedContext, the inner captured context will not have anything
10968 (it will only have data if local variables or parameters from it
10969 are captured in a nested anonymous method.
10971 The ScopeInfo is used to track the activation frames for local
10972 variables, for example:
10974 for (int i = 0; i < 10; i++)
10975 for (int j = 0; j < 10; j++){
10976 MyDelegate d = delegate {
10981 At runtime this captures a single captured variable `i', but it
10982 captures 10 different versions of the variable `j'. The variable
10983 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
10984 recorded on a child.
10986 The toplevel ScopeInfo will also track information like the `this'
10987 pointer if instance variables were referenced (this is necessary
10988 as the anonymous method lives inside a nested class in the host
10989 type of the method).
10991 (AnonymousMethod): Expanded to track the Toplevel, implement
10992 `AnonymousMethod.Compatible' to tell whether an anonymous method
10993 can be converted to a target delegate type.
10995 The routine now also produces the anonymous method content
10997 (AnonymousDelegate): A helper class that derives from
10998 DelegateCreation, this is used to generate the code necessary to
10999 produce the delegate for the anonymous method that was created.
11001 * assign.cs: API adjustments for new changes in
11002 Convert.ImplicitStandardConversionExists.
11004 * class.cs: Adjustments to cope with the fact that now toplevel
11005 blocks are of type `ToplevelBlock'.
11007 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
11008 insteda of standard blocks.
11010 Flag errors if params arguments are passed to anonymous methods.
11012 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
11013 `CurrentAnonymousMethod' which points to the current Anonymous
11014 Method. The variable points to the AnonymousMethod class that
11015 holds the code being compiled. It is set in the new EmitContext
11016 created for the anonymous method.
11018 (EmitContext.Phase): Introduce a variable and an enumeration to
11019 assist in enforcing some rules about when and where we are allowed
11020 to invoke certain methods (EmitContext.NeedsReturnLabel is the
11021 only one that enfonces this right now).
11023 (EmitContext.HaveCaptureInfo): new helper method that returns
11024 whether we have a CapturedContext initialized.
11026 (EmitContext.CaptureVariable): New method used to register that a
11027 LocalInfo must be flagged for capturing.
11029 (EmitContext.CapturedParameter): New method used to register that a
11030 parameters must be flagged for capturing.
11032 (EmitContext.CapturedField): New method used to register that a
11033 field must be flagged for capturing.
11035 (EmitContext.HaveCapturedVariables,
11036 EmitContext.HaveCapturedFields): Return whether there are captured
11037 variables or fields.
11039 (EmitContext.EmitMethodHostInstance): This is used to emit the
11040 instance for the anonymous method. The instance might be null
11041 (static methods), this (for anonymous methods that capture nothing
11042 and happen to live side-by-side with the current method body) or a
11043 more complicated expression if the method has a CaptureContext.
11045 (EmitContext.EmitTopBlock): Routine that drives the emission of
11046 code: it will first resolve the top block, then emit any metadata
11047 and then emit the code. The split is done so that we can extract
11048 any anonymous methods and flag any captured variables/parameters.
11050 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
11051 during this phase, the ILGenerator should not be used as labels
11052 and local variables declared here might not be accessible to any
11053 code that is part of an anonymous method.
11055 Exceptions to this include the temporary variables that are
11056 created by some statements internally for holding temporary
11059 (EmitContext.EmitMeta): New routine, in charge of emitting all the
11062 (EmitContext.TemporaryReturn): This method is typically called
11063 from the Emit phase, and its the only place where we allow the
11064 ReturnLabel to be defined other than the EmitMeta. The reason is
11065 that otherwise we would have to duplicate a lot of logic in the
11066 Resolve phases of various methods that today is on the Emit
11069 (EmitContext.NeedReturnLabel): This no longer creates the label,
11070 as the ILGenerator is not valid during the resolve phase.
11072 (EmitContext.EmitThis): Extended the knowledge in this class to
11073 work in anonymous methods in addition to iterators.
11075 (EmitContext.EmitCapturedVariableInstance): This emits whatever
11076 code is necessary on the stack to access the instance to a local
11077 variable (the variable will be accessed as a field).
11079 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
11080 EmitContext.EmitAddressOfParameter): Routines to support
11081 parameters (not completed at this point).
11083 Removals: Removed RemapLocal and RemapLocalLValue. We probably
11084 will also remove the parameters.
11086 * convert.cs (Convert): Define a `ConstantEC' which points to a
11087 null. This is just to prefity some code that uses
11088 ImplicitStandardConversion code and do not have an EmitContext
11091 The idea is to flag explicitly that at that point in time, it is
11092 known that the conversion will not trigger the delegate checking
11093 code in implicit conversions (which requires a valid
11096 Everywhere: pass new EmitContext parameter since
11097 ImplicitStandardConversionExists now requires it to check for
11098 anonymous method conversions.
11100 (Convert.ImplicitStandardConversionExists): If the type of an
11101 expression is the anonymous_method_type, and the type is a
11102 delegate, we invoke the AnonymousMethod.Compatible method to check
11103 whether an implicit conversion is possible.
11105 (Convert.ImplicitConversionStandard): Only do implicit method
11106 group conversions if the language level is not ISO_1.
11108 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
11109 MethodInfo for the Invoke method. used by Delegate and
11112 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
11113 method conversions if the target type is a delegate.
11115 Removed extra debugging nops.
11117 (LocalVariableReference): Turn the `local_info' into a public
11120 Add `prepared' field, the same hack used for FieldExprs to cope
11121 with composed assignments, as Local variables do not necessarily
11122 operate purely on the stack as they used to: they can be captured
11125 Add `temp' for a temporary result, like fields.
11127 Refactor DoResolve and DoResolveLValue into DoResolveBase.
11129 It now copes with Local variables that are captured and emits the
11130 proper instance variable to load it from a field in the captured
11133 (ParameterReference.DoResolveBase): During the resolve phase,
11134 capture parameters if we are in an anonymous method.
11136 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
11137 anonymous method, use the EmitContext helper routines to emit the
11138 parameter reference.
11140 * iterators.cs: Set RemapToProxy to true/false during the
11143 * parameters.cs (GetParameterByName): New helper method.
11145 * typemanager.cs (anonymous_method_type) a new type that
11146 represents an anonyous method. This is always an internal type,
11147 used as a fencepost to test against the anonymous-methodness of an
11150 2004-10-20 Marek Safar <marek.safar@seznam.cz>
11152 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
11154 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
11156 2004-10-18 Martin Baulig <martin@ximian.com>
11158 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
11159 `Type' directly, but call ResolveType() on it.
11160 (Catch.Resolve): Likewise.
11161 (Foreach.Resolve): Likewise.
11163 2004-10-18 Martin Baulig <martin@ximian.com>
11165 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
11166 `Type' directly, but call ResolveType() on it.
11167 (Probe.DoResolve): Likewise.
11168 (ArrayCreation.LookupType): Likewise.
11169 (TypeOf.DoResolve): Likewise.
11170 (SizeOf.DoResolve): Likewise.
11172 2004-10-18 Martin Baulig <martin@ximian.com>
11174 * expression.cs (Invocation.BetterFunction): Put back
11175 TypeManager.TypeToCoreType().
11177 2004-10-18 Raja R Harinath <rharinath@novell.com>
11179 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
11182 2004-10-18 Martin Baulig <martin@ximian.com>
11184 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
11185 `Type' directly, but call ResolveType() on it.
11187 2004-10-18 Martin Baulig <martin@ximian.com>
11189 * class.cs (FieldMember.Define): Don't access the TypeExpr's
11190 `Type' directly, but call ResolveType() on it.
11191 (MemberBase.DoDefine): Likewise.
11193 * expression.cs (New.DoResolve): Don't access the TypeExpr's
11194 `Type' directly, but call ResolveType() on it.
11195 (ComposedCast.DoResolveAsTypeStep): Likewise.
11197 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
11198 `Type' directly, but call ResolveType() on it.
11200 2004-10-17 John Luke <john.luke@gmail.com>
11202 * class.cs (Operator.GetSignatureForError): use CSharpName
11204 * parameter.cs (Parameter.GetSignatureForError): Returns
11205 correct name even if was not defined.
11207 2004-10-13 Raja R Harinath <rharinath@novell.com>
11210 * class.cs (TypeContainer.EmitContext): New property.
11211 (DefineNestedTypes): Create an emitcontext for each part.
11212 (MethodCore.DoDefineParameters): Use container's emitcontext.
11213 Pass type array to InternalParameters.
11214 (MemberBase.DoDefine): Use container's emitcontext.
11215 (FieldMember.Define): Likewise.
11216 (Event.Define): Likewise.
11217 (SetMethod.GetParameterInfo): Change argument to EmitContext.
11218 Pass type array to InternalParameters.
11219 (SetIndexerMethod.GetParameterInfo): Likewise.
11220 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
11221 * delegate.cs (Define): Pass emitcontext to
11222 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
11223 array to InternalParameters.
11224 * expression.cs (ParameterReference.DoResolveBase): Pass
11225 emitcontext to GetParameterInfo.
11226 (ComposedCast.DoResolveAsTypeStep): Remove check on
11227 ec.ResolvingTypeTree.
11228 * parameter.cs (Parameter.Resolve): Change argument to
11229 EmitContext. Use ResolveAsTypeTerminal.
11230 (Parameter.GetSignature): Change argument to EmitContext.
11231 (Parameters.ComputeSignature): Likewise.
11232 (Parameters.ComputeParameterTypes): Likewise.
11233 (Parameters.GetParameterInfo): Likewise.
11234 (Parameters.ComputeAndDefineParameterTypes): Likewise.
11235 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
11236 * support.cs (InternalParameters..ctor): Remove variant that takes
11238 * typemanager.cs (system_intptr_expr): New.
11239 (InitExpressionTypes): Initialize it.
11241 2004-10-12 Chris Toshok <toshok@ximian.com>
11243 * cs-parser.jay: fix location for try_statement and catch_clause.
11245 2004-10-11 Martin Baulig <martin@ximian.com>
11247 * report.cs: Don't make --fatal abort on warnings, we have
11248 -warnaserror for that.
11250 2004-10-07 Raja R Harinath <rharinath@novell.com>
11252 More DeclSpace.ResolveType avoidance.
11253 * decl.cs (MemberCore.InUnsafe): New property.
11254 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
11255 with newly created EmitContext.
11256 (FieldMember.Define): Likewise.
11257 * delegate.cs (Delegate.Define): Likewise.
11258 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
11259 only if normal name-lookup fails.
11260 (TypeExpr.DoResolve): Enable error-checking.
11261 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
11262 (SizeOf.DoResolve): Likewise.
11263 (ComposedCast.DoResolveAsTypeStep): Likewise.
11264 (StackAlloc.DoResolve): Likewise.
11265 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
11266 (Block.Unsafe): New property.
11267 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
11268 (Unsafe): Set 'unsafe' flag of contained block.
11269 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
11270 (Fixed.Resolve): Likewise.
11271 (Catch.Resolve): Likewise.
11272 (Using.ResolveLocalVariableDecls): Likewise.
11273 (Foreach.Resolve): Likewise.
11275 2004-10-05 John Luke <john.luke@gmail.com>
11277 * cs-parser.jay: add location to error CS0175
11279 2004-10-04 Miguel de Icaza <miguel@ximian.com>
11281 * ecore.cs (Expression.Constantity): Add support for turning null
11284 * const.cs (Const.Define): Allow constants to be reference types
11285 as long as the value is Null.
11287 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
11289 * namespace.cs (NamespaceEntry.Using): No matter which warning
11290 level is set, check if this namespace name has already been added.
11292 2004-10-03 Ben Maurer <bmaurer@ximian.com>
11294 * expression.cs: reftype [!=]= null should always use br[true,false].
11297 2004-10-03 Marek Safar <marek.safar@seznam.cz>
11300 * attribute.cs: Enum conversion moved to
11301 GetAttributeArgumentExpression to be applied to the all
11304 2004-10-01 Raja R Harinath <rharinath@novell.com>
11306 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
11307 * class.c (TypeContainer.DefineType): Flag error if
11308 base types aren't accessible due to access permissions.
11309 * decl.cs (DeclSpace.ResolveType): Move logic to
11310 Expression.ResolveAsTypeTerminal.
11311 (DeclSpace.ResolveTypeExpr): Thin layer over
11312 Expression.ResolveAsTypeTerminal.
11313 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
11314 Refactor code into NestedAccess. Use it.
11315 (DeclSpace.NestedAccess): New.
11316 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
11317 argument to silence errors. Check access permissions.
11318 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
11319 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
11320 (Cast.DoResolve): Likewise.
11321 (New.DoResolve): Likewise.
11322 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
11323 (TypeOf.DoResolve): Likewise.
11325 * expression.cs (Invocation.BetterConversion): Return the Type of
11326 the better conversion. Implement section 14.4.2.3 more faithfully.
11327 (Invocation.BetterFunction): Make boolean. Make correspondence to
11328 section 14.4.2.2 explicit.
11329 (Invocation.OverloadResolve): Update.
11330 (Invocation): Remove is_base field.
11331 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
11332 (Invocation.Emit): Likewise.
11334 2004-09-27 Raja R Harinath <rharinath@novell.com>
11336 * README: Update to changes.
11338 2004-09-24 Marek Safar <marek.safar@seznam.cz>
11340 * cs-parser.jay: Reverted 642 warning fix.
11342 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11345 * decl.cs (FindMemberWithSameName): Indexer can have more than
11348 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11350 * expression.cs (LocalVariableReference.DoResolveLValue):
11351 Do not report warning 219 for out values.
11352 (EmptyExpression.Null): New member to avoid extra allocations.
11354 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11356 * cs-parser.jay: Fix wrong warning 642 report.
11358 * cs-tokenizer.cs (CheckNextToken): New helper;
11359 Inspect next character if is same as expected.
11361 2004-09-23 Martin Baulig <martin@ximian.com>
11363 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
11364 (Convert.ImplicitReferenceConversionExists): Likewise.
11366 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11368 * class.cs (Operator.Define): Add error 448 and 559 report.
11370 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11372 * class.cs (MemberBase.IsTypePermitted): New protected
11373 method for checking error CS0610.
11375 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11377 * class.cs (TypeContainer.HasExplicitLayout): New property
11378 Returns whether container has StructLayout attribute set Explicit.
11379 (FieldMember): New abstract class for consts and fields.
11380 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
11381 (Field): Reuse FieldMember.
11383 * const.cs (Const): Reuse FieldMember.
11385 * rootcontext.cs: EmitConstants call moved to class.
11387 2004-09-22 Martin Baulig <martin@ximian.com>
11389 Thanks to Peter Sestoft for this bug report.
11391 * expression.cs (Conditional): If both the `trueExpr' and the
11392 `falseExpr' is a NullLiteral, return a NullLiteral.
11394 2004-09-22 Martin Baulig <martin@ximian.com>
11396 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
11397 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
11398 for the "get_Current" call.
11400 2004-09-22 Martin Baulig <martin@ximian.com>
11402 Marek and me just fixed one of our oldest bugs: #28562 :-)
11404 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
11406 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
11407 we're an EnumConstant, just return that.
11408 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
11409 an EnumConstant. In this case, we need to use GetValueAsEnumType()
11410 to get the value which'll actually be written into the attribute.
11411 However, we have to use GetValue() to access the attribute's value
11414 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11416 * constant.cs (Constant.IsNegative): New abstract property
11419 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
11420 (StackAlloc.DoResolve): Reused IsNegative.
11422 2004-09-21 Martin Baulig <martin@ximian.com>
11424 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
11425 if we're used in an iterator, we may be called from different
11428 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
11429 we actually have an exception block.
11431 2004-09-20 John Luke <jluke@cfl.rr.com>
11433 * class.cs, cs-parser.jay: Improve the error report for 1520:
11434 report the actual line where the error happens, not where the
11435 class was declared.
11437 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
11438 Pass location information that was available elsewhere.
11440 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
11442 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
11443 runtime to delay sign assemblies.
11445 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11447 * cs-parser.jay: Do not report the stack trace, this is barely
11450 2004-08-22 John Luke <john.luke@gmail.com>
11452 * driver.cs : check that a resource id is not already used
11453 before adding it, report CS1508 if it is, bug #63637
11455 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11457 * ecore.cs: Removed dead code.
11459 2004-09-18 Marek Safar <marek.safar@seznam.cz>
11461 * class.cs: Do not report warning CS0067 on the interfaces.
11463 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11465 * cs-parser.jay: Add error 504 report.
11467 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11469 * rootcontext.cs: WarningLevel is 4 by default now.
11471 * statement.cs (Fixed.Resolve): Do not null
11474 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11477 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
11478 deep search when property is not virtual.
11479 (PropertyExpr.ResolveAccessors): Make one call for both
11482 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11485 * statement.cs: Error 152 report constains also location.
11487 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11490 * const.cs: Explicitly set constant as static.
11492 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11495 * cs-parser.jay: Add error 1017 report.
11497 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11499 Fixed bug #59980, #64224
11500 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
11502 * typemanager.cs (IsSpecialMethod): Simplified
11504 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11506 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11507 condition with better params.
11509 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11512 * attribute.cs (Resolve): Property has to have both
11515 2004-09-14 Martin Baulig <martin@ximian.com>
11517 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
11519 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11522 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
11523 called and is obsolete then this member suppress message
11524 when call is inside next [Obsolete] method or type.
11526 * expression.cs: Use TestObsoleteMethodUsage member.
11528 2004-09-14 Martin Baulig <martin@ximian.com>
11530 * cs-parser.jay: Sync a bit with the GMCS version.
11532 2004-09-14 Martin Baulig <martin@ximian.com>
11534 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
11535 (CSharpParser.yacc_verbose_flag): New public field.
11537 * genericparser.cs: Removed.
11539 2004-09-14 Raja R Harinath <rharinath@novell.com>
11541 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
11543 2004-09-13 Marek Safar <marek.safar@seznam.cz>
11545 * class.cs (MethodCore.CheckBase): Fix bug #65757.
11547 2004-09-10 Martin Baulig <martin@ximian.com>
11549 Backported my MemberName changes from GMCS into MCS.
11551 - we are now using a special `MemberName' class instead of using
11552 strings; in GMCS, the `MemberName' also contains the type
11555 - changed the grammar rules a bit:
11556 * the old `member_name' is now a `namespace_or_type_name':
11557 The rule is that we use `namespace_or_type_name' everywhere
11558 where we expect either a "member name" (GetEnumerator) or a
11559 "member name" with an explicit interface name
11560 (IEnumerable.GetEnumerator).
11561 In GMCS, the explicit interface name may include type arguments
11562 (IEnumerable<T>.GetEnumerator).
11563 * we use `member_name' instead of just `IDENTIFIER' for
11565 The rule is that we use `member_name' wherever a member may
11566 have type parameters in GMCS.
11568 * decl.cs (MemberName): New public class.
11569 (MemberCore.MemberName): New public readonly field.
11570 (MemberCore.ctor): Take a `MemberName' argument, not a string.
11571 (DeclSpace): Likewise.
11573 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
11574 * enum.cs (Enum.ctor): Likewise.
11576 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
11578 (AliasEntry.ctor): Take a MemberName, not an Expression.
11579 (AliasEntry.UsingAlias): Likewise.
11581 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
11582 (IMethodData.MemberName): Changed type from string to MemberName.
11583 (MemberBase.ExplicitInterfaceName): Likewise.
11584 (AbstractPropertyEventMethod.SetupName): Make this private.
11585 (AbstractPropertyEventMethod.ctor): Added `string prefix'
11586 argument; compute the member name here.
11587 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
11588 on the `member.MemberName' and the `prefix'.
11590 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
11592 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
11593 thus, we get a `MemberName' instead of a `string'. These
11594 declarations may have type parameters in GMCS.
11595 (interface_method_declaration, delegate_declaration): Likewise.
11596 (class_declaration, interface_declaration): Likewise.
11597 (method_header): Use `namespace_or_type_name' instead of
11598 `member_name'. We may be an explicit interface implementation.
11599 (property_declaration, event_declaration): Likewise.
11600 (member_name): This is now just an `IDENTIFIER', not a
11601 `namespace_or_type_name'.
11602 (type_name, interface_type): Removed.
11603 (namespace_or_type_name): Return a MemberName, not an Expression.
11604 (primary_expression): Use `member_name' instead of `IDENTIFIER';
11605 call GetTypeExpression() on the MemberName to get an expression.
11606 (IndexerDeclaration.interface_type): Changed type from string to
11608 (MakeName): Operate on MemberName's instead of string's.
11610 2004-09-13 Raja R Harinath <rharinath@novell.com>
11613 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
11614 (NamespaceEntry.Lookup): Add new argument to flag if we want the
11615 lookup to avoid symbols introduced by 'using'.
11616 * rootcontext.cs (NamespaceLookup): Update.
11618 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11620 * class.cs (TypeContainer.DoDefineMembers): Do not call
11621 DefineDefaultConstructor for static classes.
11623 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11625 * attribute.cs (Attribute.Resolve): Add error 653 report.
11627 * class.cs (Class.ApplyAttributeBuilder): Add error 641
11629 (Method.ApplyAttributeBuilder): Add error 685 report.
11630 (Operator.Define): Add error 564 report.
11632 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
11634 * expression.cs (Invocation.DoResolve): Add error
11635 245 and 250 report.
11637 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
11640 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11642 * class.cs (ConstructorInitializer.Resolve):
11643 Wrong error number (515->516).
11645 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11647 * class.cs (Indexer.Define): Add error 631 report.
11649 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11651 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
11653 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11655 * expression.cs (Probe.DoResolve): Add error CS0241 report.
11657 2004-09-10 Marek Safar <marek.safar@seznam.cz>
11659 * cs-parser.jay: Added error CS0241 report.
11661 2004-09-10 Raja R Harinath <rharinath@novell.com>
11663 * cs-parser.jay (fixed_statement): Introduce a scope for the
11664 declaration in the 'fixed' statement.
11666 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11668 * cs-parser.jay: Added CS0230 error report.
11670 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11672 * cs-parser.jay: Added errors CS0231 and CS0257 report.
11674 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11676 * expression.cs (Argument.Resolve): Added error CS0192 and
11679 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11681 C# 2.0 #pragma warning feature
11683 * cs-tokenizer.cs (PreProcessPragma): New method;
11684 Handles #pragma directive.
11686 * report.cs (WarningRegions): New class; Support
11687 class for #pragma warning directive. It tests whether
11688 warning is enabled for a given line.
11690 2004-09-08 Miguel de Icaza <miguel@ximian.com>
11692 * const.cs: Add more descriptive error report, tahnks to
11695 2004-09-08 Marek Safar <marek.safar@seznam.cz>
11697 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
11699 2004-09-07 Miguel de Icaza <miguel@ximian.com>
11701 * expression.cs: Apply patch from Ben: Remove dead code from
11702 ArrayCreation, and remove the TurnintoConstant call in const.cs,
11703 as that code just threw an exception anwyays.
11705 * const.cs: Remove the call to the turnintoconstant, for details
11708 * literal.cs: The type of the null-literal is the null type; So
11709 we use a placeholder type (literal.cs:System.Null, defined here)
11712 * expression.cs (Conditional.DoResolve): Remove some old code that
11713 is no longer needed, conversions have been fixed.
11715 (ArrayCreationExpression.DoResolve): Return false if we fail to
11716 resolve the inner expression.
11718 2004-09-07 Raja R Harinath <rharinath@novell.com>
11721 * cs-parser.jay (delegate_declaration): Record a delegate
11722 declaration as a type declaration.
11723 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
11725 2004-09-06 Miguel de Icaza <miguel@ximian.com>
11727 * parameter.cs: Do not crash if the type can not be resolved.
11729 * expression.cs: Report errors with unsafe pointers, fixes #64896
11731 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
11733 * expression.cs: Pointer arith always needs to do a conv.i
11734 if the operand is a long. fix 65320
11736 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11738 Fixed cs0619-37.cs, cs0619-38.cs
11740 * enum.cs (GetObsoleteAttribute): Removed.
11742 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
11743 on Enum member is double staged. The first is tested member
11746 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11748 Fixed #56986, #63631, #65231
11750 * class.cs: (TypeContainer.AddToMemberContainer): New method,
11751 adds member to name container.
11752 (TypeContainer.AddToTypeContainer): New method, adds type to
11754 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
11755 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
11756 AddOperator): Simplified by reusing AddToMemberContainer.
11757 (TypeContainer.UserDefinedStaticConstructor): Changed to property
11759 (Method.CheckForDuplications): Fixed implementation to test all
11761 (MemberBase): Detection whether member is explicit interface
11762 implementation is now in constructor.
11763 (MemberBase.UpdateMemberName): Handles IndexerName.
11764 (Accessor): Changed to keep also location information.
11765 (AbstractPropertyEventMethod): Is derived from MemberCore.
11766 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
11767 will be emited or not.
11768 (PropertyBase.AreAccessorsDuplicateImplementation):
11769 Tests whether accessors are not in collision with some method.
11770 (Operator): Is derived from MethodCore to simplify common
11773 * decl.cs (Flags.TestMethodDuplication): Test for duplication
11775 (DeclSpace.AddToContainer): Adds the member to defined_names
11776 table. It tests for duplications and enclosing name conflicts.
11778 * enum.cs (EnumMember): Clean up to reuse the base structures
11780 2004-09-03 Martin Baulig <martin@ximian.com>
11782 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
11783 into TypeContainer, to make partial classes work again.
11785 2004-09-03 Martin Baulig <martin@ximian.com>
11787 * rootcontext.cs (RootContext.V2): Removed.
11789 2004-03-23 Martin Baulig <martin@ximian.com>
11791 * expression.cs (Invocation.OverloadResolve): Added `bool
11792 may_fail' argument and use it instead of the Location.IsNull() hack.
11794 2004-09-03 Martin Baulig <martin@ximian.com>
11796 Merged latest changes into gmcs. Please keep this comment in
11797 here, it makes it easier for me to see what changed in MCS since
11798 the last time I merged.
11800 2004-09-03 Raja R Harinath <rharinath@novell.com>
11803 * expression.cs (BetterConversion): Don't allow either conversion
11804 to be null. Remove redundant implicit conversion test when 'q ==
11805 null' -- when this function is invoked, we already know that the
11806 implicit conversion exists.
11807 (BetterFunction): Assume that 'best' is non-null. Remove
11808 redundant reimplementation of IsApplicable when 'best' is null.
11809 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
11810 number of arguments.
11811 (IsAncestralType): Extract from OverloadResolve.
11812 (OverloadResolve): Make robust to the MethodGroupExpr being
11813 unsorted. Implement all the logic of Section 14.5.5.1, and
11814 support overloading of methods from multiple applicable types.
11815 Clean up logic somewhat. Don't pass null methods to BetterFunction.
11817 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
11818 (RealError, Warning): Append type of report to related symbol.
11820 2004-09-03 Marek Safar <marek.safar@seznam.cz>
11822 * enum.cs: Fixed CLS-Compliance checks for enum members.
11823 Error tests cs3008-8.cs, cs3014-8.cs
11825 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11827 Fixed bug #62342, #63102
11828 * class.cs: ImplementIndexer uses member.IsExplicitImpl
11829 like ImplementMethod.
11831 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11833 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11836 2004-09-02 Martin Baulig <martin@ximian.com>
11838 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
11839 TypeManager.GetArgumentTypes() rather than calling GetParameters()
11842 2004-09-01 Marek Safar <marek.safar@seznam.cz>
11844 C# 2.0 Static classes implemented
11846 * class.cs (TypeContainer): instance_constructors,
11847 initialized_fields, initialized_static_fields,
11848 default_constructor, base_inteface_types are protected to be
11849 accessible from StaticClass.
11850 (TypeContainer.DefineDefaultConstructor): New virtual method
11851 for custom default constructor generating
11852 (StaticClass): New class to handle "Static classes" feature.
11854 * cs-parser.jay: Handle static keyword on class like instance
11857 * driver.cs: Added "/langversion" command line switch with two
11858 options (iso-1, default).
11860 2004-08-31 Marek Safar <marek.safar@seznam.cz>
11862 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
11864 2004-08-31 Miguel de Icaza <miguel@ximian.com>
11866 * delegate.cs: Style.
11868 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
11870 * delegate.cs: Add seperate instance expr field for miguel.
11872 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11874 * PointerArithmetic (Resolve): make sure we are not doing
11875 pointer arith on void*. Also, make sure we are resolved
11876 by not setting eclass until resolve.
11878 All callers: Make sure that PointerArithmetic gets resolved.
11880 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11882 * ArrayCreation (LookupType): If the type does not resolve
11883 to an array, give an error.
11885 2004-08-27 Marek Safar <marek.safar@seznam.cz>
11887 * statement.cs (Try.Resolve): Fixed bug #64222
11889 2004-08-27 Martin Baulig <martin@ximian.com>
11892 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
11895 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11897 * ecore.cs (Constantify): Get underlying type via
11898 System.Enum.GetUnderlyingType to avoid StackOverflow on the
11899 Windows in special cases.
11901 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11903 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
11904 for obtaining also private methods.
11905 (GetRemoveMethod): Used GetRemoveMethod (true)
11906 for obtaining also private methods.
11908 2004-08-24 Martin Baulig <martin@ximian.com>
11910 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
11911 MethodAttributes.HideBySig for operators.
11913 2004-08-23 Martin Baulig <martin@ximian.com>
11915 Back to the old error reporting system :-)
11917 * report.cs (Message): Removed.
11918 (Report.MessageData, ErrorData, WarningData): Removed.
11919 (Report.Error, Warning): Back to the old system.
11921 2004-08-23 Martin Baulig <martin@ximian.com>
11923 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
11925 * class.cs (TypeContainer.ParentContainer): New public virtual
11926 method; replaces the explicit interface implementation.
11927 (ClassPart.ParentContainer): Override.
11929 2004-08-23 Martin Baulig <martin@ximian.com>
11931 * statement.cs (Switch): Added support for constant switches; see
11932 #59428 or test-285.cs.
11934 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11937 * statement.cs (GetEnumeratorFilter): Removed useless
11938 logic because C# specs is strict. GetEnumerator must be
11941 2004-08-22 Martin Baulig <martin@ximian.com>
11943 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11944 a switch and may break, reset the barrier. Fixes #59867.
11946 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11948 CLS-Compliance speed up (~5% for corlib)
11950 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
11951 New method. Tests container for CLS-Compliant names
11953 * class.cs (TypeContainer.VerifyClsName): New method.
11954 Checks whether container name is CLS Compliant.
11955 (Constructor): Implements IMethodData.
11957 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
11958 low-case table for CLS Compliance test.
11959 (MemberCache.VerifyClsParameterConflict): New method.
11960 Checks method parameters for CS3006 error.
11962 * enum.cs (EnumMember): Is derived from MemberCore.
11963 (Enum.VerifyClsName): Optimized for better performance.
11965 2004-08-06 Marek Safar <marek.safar@seznam.cz>
11967 * report.cs: Renamed Error_T to Error and changed all
11970 2004-08-06 Marek Safar <marek.safar@seznam.cz>
11972 * class.cs (TypeContainer.IndexerArrayList): New inner class
11973 container for indexers.
11974 (TypeContainer.DefaultIndexerName): New constant for default
11975 indexer name. Replaced all "Item" with this constant.
11976 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
11978 * typemanager.cs (TypeManager.default_member_ctor): Cache here
11979 DefaultMemberAttribute constructor.
11981 2004-08-05 Martin Baulig <martin@ximian.com>
11983 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
11986 2004-08-05 Marek Safar <marek.safar@seznam.cz>
11988 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
11989 multi platforms problem.
11991 * compiler.csproj: Included shared files.
11993 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11995 Fix bug 60333, 55971 in the more general way
11996 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11997 Added arg_type argument for constant conversion.
11998 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
12000 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12003 * class.cs (TypeContainer ): New inner classes MethodArrayList,
12004 OperatorArrayList, MethodCoreArrayList for typecontainer
12005 containers. Changed class member types to these new types.
12006 (MethodArrayList.DefineMembers): Added test for CS0659.
12008 2004-08-04 Miguel de Icaza <miguel@ximian.com>
12010 * cfold.cs: Synchronize the folding with the code in expression.cs
12011 Binary.DoNumericPromotions for uint operands.
12013 * attribute.cs: Revert patch from Raja, it introduced a regression
12014 while building Blam-1.2.1 (hard to isolate a test case).
12016 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12020 (TypeContainer.Define): Renamed to DefineContainerMembers because of
12022 (MethodCore.parent_method): New member. The method we're overriding
12023 if this is an override method.
12024 (MethodCore.CheckBase): Moved from Method class and made common.
12025 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
12027 (MethodCore.CheckForDuplications): New abstract method. For custom
12028 member duplication search in a container
12029 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
12030 method and its return type.
12031 (Event.conflict_symbol): New member. Symbol with same name in the
12035 (MemberCache.FindMemberWithSameName): New method. The method
12036 is looking for conflict with inherited symbols.
12038 2004-08-04 Martin Baulig <martin@ximian.com>
12040 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
12042 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
12044 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12046 * report.cs (Message): New enum for better error, warning reference in
12048 (MessageData): New inner abstract class. It generally handles printing of
12049 error and warning messages.
12050 Removed unused Error, Warning, Message methods.
12052 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12054 Fix for cs0592-8.cs test
12056 (Attributable.ValidAttributeTargets): Made public.
12057 (Attribute.ExplicitTarget): New member for explicit target value.
12058 (Attribute.CheckTargets): Now we translate explicit attribute
12059 target to Target here.
12061 2004-08-03 Ben Maurer <bmaurer@ximian.com>
12063 * ecore.cs (MethodGroupExpr): new IsBase property.
12065 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12067 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12068 rather than an instance expr.
12070 (DelegateCreation.Emit): Use the method group rather than
12071 the instance expression. Also, if you have base.Foo as the
12072 method for a delegate, make sure to emit ldftn, not ldftnvirt.
12074 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
12076 (NewDelegate.DoResolve): Only check for the existance of Invoke
12077 if the method is going to be needed. Use MethodGroupExpr.
12079 (NewDelegate.Emit): Remove, DelegateCreation implements this.
12081 * expression.cs: For pointer arith., make sure to use
12082 the size of the type, not the size of the pointer to
12085 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12088 * class.cs (Class): Added error CS0502 test.
12090 2004-08-03 John Luke <jluke@cfl.rr.com>
12091 Raja R Harinath <rharinath@novell.com>
12094 * attribute.cs (Attribute.complained_before): New flag.
12095 (Attribute.ResolveType, Attribute.Resolve),
12096 (Attribute.DefinePInvokeMethod): Set it.
12097 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
12099 2004-08-03 Martin Baulig <martin@ximian.com>
12101 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
12102 use a user-defined operator; we still need to do numeric
12103 promotions in case one argument is a builtin type and the other
12104 one has an implicit conversion to that type. Fixes #62322.
12106 2004-08-02 Martin Baulig <martin@ximian.com>
12108 * statement.cs (LocalInfo.Flags): Added `IsThis'.
12109 (LocalInfo.IsThis): New public property.
12110 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
12112 2004-08-01 Martin Baulig <martin@ximian.com>
12114 * class.cs (TypeContainer.GetClassBases): Don't set the default
12115 here since we may get called from GetPartialBases().
12116 (TypeContainer.DefineType): If GetClassBases() didn't return a
12117 parent, use the default one.
12119 2004-07-30 Duncan Mak <duncan@ximian.com>
12121 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
12123 2004-07-30 Martin Baulig <martin@ximian.com>
12125 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
12127 * class.cs (SourceMethod): New public class, derive from the
12128 symbol writer's ISourceMethod.
12129 (Method): Use the new symbol writer API.
12131 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
12132 as argument and use the new symbol writer.
12135 (SourceFile): Implement the symbol writer's ISourceFile.
12136 (Location.SymbolDocument): Removed.
12137 (Location.SourceFile): New public property.
12139 * symbolwriter.cs: Use the new symbol writer API.
12141 2004-07-30 Raja R Harinath <rharinath@novell.com>
12143 * Makefile (install-local): Remove. Functionality moved to
12146 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
12148 * Makefile: Install mcs.exe.config file together with mcs.exe.
12149 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
12150 correct runtime version.
12152 2004-07-25 Martin Baulig <martin@ximian.com>
12155 (TypeContainer.RegisterOrder): Removed, this was unused.
12156 (TypeContainer, interface_order): Removed.
12157 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
12158 TypeContainer as argument since we can also be called with a
12159 `PartialContainer' for a partial class/struct/interface.
12160 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
12161 of checking whether we're an `Interface' - we could be a
12162 `PartialContainer'.
12163 (PartialContainer.Register): Override; call
12164 AddClass()/AddStruct()/AddInterface() on our parent.
12166 * cs-parser.jay (interface_member_declaration): Add things to the
12167 `current_container', not the `current_class'.
12169 * rootcontext.cs (RegisterOrder): The overloaded version which
12170 takes an `Interface' was unused, removed.
12172 * typemanager.cs (TypeManager.LookupInterface): Return a
12173 `TypeContainer', not an `Interface'.
12174 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
12175 contain a `PartialContainer' for an interface, so check it's
12176 `Kind' to figure out what it is.
12178 2004-07-25 Martin Baulig <martin@ximian.com>
12180 * class.cs (Class.DefaultTypeAttributes): New public constant.
12181 (Struct.DefaultTypeAttributes): Likewise.
12182 (Interface.DefaultTypeAttributes): Likewise.
12183 (PartialContainer.TypeAttr): Override this and add the
12184 DefaultTypeAttributes.
12186 2004-07-25 Martin Baulig <martin@ximian.com>
12188 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
12189 we can just use the `Parent' field instead.
12191 2004-07-25 Martin Baulig <martin@ximian.com>
12193 * class.cs (TypeContainer.Emit): Renamed to EmitType().
12195 2004-07-25 Martin Baulig <martin@ximian.com>
12197 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
12198 our parts before defining any methods.
12199 (TypeContainer.VerifyImplements): Make this virtual.
12200 (ClassPart.VerifyImplements): Override and call VerifyImplements()
12201 on our PartialContainer.
12203 2004-07-25 Martin Baulig <martin@ximian.com>
12205 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
12207 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
12208 argument, we can just use the `Parent' field instead.
12211 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
12212 (MemberBase.DoDefine): Likewise.
12214 2004-07-24 Martin Baulig <martin@ximian.com>
12216 * decl.cs (MemberCore.Parent): New public field.
12217 (DeclSpace.Parent): Moved to MemberCore.
12219 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
12220 (MemberBase.ctor): Added TypeContainer argument, pass it to our
12222 (FieldBase, Field, Operator): Likewise.
12223 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
12224 (EventField, Event): Likewise.
12226 2004-07-23 Martin Baulig <martin@ximian.com>
12228 * class.cs (PartialContainer): New public class.
12229 (ClassPart): New public class.
12230 (TypeContainer): Added support for partial classes.
12231 (TypeContainer.GetClassBases): Splitted some of the functionality
12232 out into GetNormalBases() and GetPartialBases().
12234 * cs-tokenizer.cs (Token.PARTIAL): New token.
12235 (Tokenizer.consume_identifier): Added some hacks to recognize
12236 `partial', but only if it's immediately followed by `class',
12237 `struct' or `interface'.
12239 * cs-parser.jay: Added support for partial clases.
12241 2004-07-23 Martin Baulig <martin@ximian.com>
12243 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
12244 a `DeclSpace' and also made it readonly.
12245 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
12246 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
12247 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
12249 * cs-parser.jay: Pass the `current_class', not the
12250 `current_container' (at the moment, this is still the same thing)
12251 to a new Method, Property, Event, Indexer or Constructor.
12253 2004-07-23 Martin Baulig <martin@ximian.com>
12255 * cs-parser.jay (CSharpParser): Added a new `current_class' field
12256 and removed the `current_interface' one.
12257 (struct_declaration, class_declaration, interface_declaration):
12258 Set `current_class' to the newly created class/struct/interface;
12259 set their `Bases' and call Register() before parsing their body.
12261 2004-07-23 Martin Baulig <martin@ximian.com>
12263 * class.cs (Kind): New public enum.
12264 (TypeContainer): Made this class abstract.
12265 (TypeContainer.Kind): New public readonly field.
12266 (TypeContainer.CheckDef): New public method; moved here from
12268 (TypeContainer.Register): New public abstract method.
12269 (TypeContainer.GetPendingImplementations): New public abstract
12271 (TypeContainer.GetClassBases): Removed the `is_class' and
12272 `is_iface' parameters.
12273 (TypeContainer.DefineNestedTypes): Formerly known as
12275 (ClassOrStruct): Made this class abstract.
12277 * tree.cs (RootTypes): New public type.
12279 2004-07-20 Martin Baulig <martin@ximian.com>
12281 * tree.cs (Tree.RecordNamespace): Removed.
12282 (Tree.Namespaces): Removed.
12284 * rootcontext.cs (RootContext.IsNamespace): Removed.
12286 * cs-parser.jay (namespace_declaration): Just create a new
12287 NamespaceEntry here.
12289 2004-07-20 Martin Baulig <martin@ximian.com>
12291 * statement.cs (ExceptionStatement): New abstract class. This is
12292 now used as a base class for everyone who's using `finally'.
12293 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
12294 our local variables before using them.
12296 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
12297 virtual method. This is used by Yield.Resolve() to "steal" an
12298 outer block's `finally' clauses.
12299 (FlowBranchingException): The .ctor now takes an ExceptionStatement
12302 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
12303 version which takes an ExceptionStatement. This version must be
12304 used to create exception branchings.
12307 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
12308 (Iterator.EmitMoveNext): Added exception support; protect the
12309 block with a `fault' clause, properly handle 'finally' clauses.
12310 (Iterator.EmitDispose): Run all the `finally' clauses here.
12312 2004-07-20 Martin Baulig <martin@ximian.com>
12314 * iterator.cs: This is the first of a set of changes in the
12315 iterator code. Match the spec more closely: if we're an
12316 IEnumerable, then GetEnumerator() must be called. The first time
12317 GetEnumerator() is called, it returns the current instance; all
12318 subsequent invocations (if any) must create a copy.
12320 2004-07-19 Miguel de Icaza <miguel@ximian.com>
12322 * expression.cs: Resolve the constant expression before returning
12325 2004-07-19 Martin Baulig <martin@ximian.com>
12327 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
12328 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
12329 the return type of the new EmitContext.
12331 2004-07-18 Martin Baulig <martin@ximian.com>
12333 * class.cs (Property.Define): Fix iterators.
12335 * iterators.cs (Iterator.Define): Moved the
12336 `container.AddInterator (this)' call here from the .ctor; only do
12337 it if we resolved successfully.
12339 2004-07-17 Miguel de Icaza <miguel@ximian.com>
12341 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
12342 `true' for preprocessing directives that we parse. The return
12343 value indicates whether we should return to regular tokenizing or
12344 not, not whether it was parsed successfully.
12346 In the past if we were in: #if false ... #line #endif, we would
12347 resume parsing after `#line'. See bug 61604.
12349 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
12350 building: IsEnumType should return true only for enums, not for
12351 enums or System.Enum itself. This fixes #61593.
12353 Likely what happened is that corlib was wrong: mcs depended on
12354 this bug in some places. The bug got fixed, we had to add the
12355 hack, which caused bug 61593.
12357 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
12358 that was a workaround for the older conditions.
12360 2004-07-16 Ben Maurer <bmaurer@ximian.com>
12362 * assign.cs: IAssignMethod has a new interface, as documented
12363 inline. All assignment code now uses this new api.
12365 * ecore.cs, expression.cs: All classes which implement
12366 IAssignMethod now use the new interface.
12368 * expression.cs (Invocation): add a hack to EmitCall so that
12369 IndexerAccess can be the target of a compound assignment without
12370 evaluating its arguments twice.
12372 * statement.cs: Handle changes in Invocation api.
12374 2004-07-16 Martin Baulig <martin@ximian.com>
12376 * iterators.cs: Rewrote this. We're now using one single Proxy
12377 class for both the IEnumerable and the IEnumerator interface and
12378 `Iterator' derives from Class so we can use the high-level API.
12380 * class.cs (TypeContainer.AddIterator): New method.
12381 (TypeContainer.DoDefineType): New protected virtual method, which
12382 is called from DefineType().
12383 (TypeContainer.DoDefineMembers): Call DefineType() and
12384 DefineMembers() on all our iterators.
12385 (TypeContainer.Emit): Call Emit() on all our iterators.
12386 (TypeContainer.CloseType): Call CloseType() on all our iterators.
12388 * codegen.cs (EmitContext.CurrentIterator): New public field.
12390 2004-07-15 Martin Baulig <martin@ximian.com>
12393 (TypeManager.not_supported_exception_type): New type.
12395 2004-07-14 Martin Baulig <martin@ximian.com>
12397 * iterators.cs: Use real error numbers.
12399 2004-07-14 Martin Baulig <martin@ximian.com>
12401 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
12402 requires this to be a System.Collection.IEnumerable and not a
12403 class implementing that interface.
12404 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
12406 2004-07-13 Marek Safar <marek.safar@seznam.cz>
12408 * class.cs: Fixed previous fix, it broke some error tests.
12410 2004-07-12 Martin Baulig <martin@ximian.com>
12412 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
12415 2004-07-09 Miguel de Icaza <miguel@ximian.com>
12417 * assign.cs (LocalTemporary): Add new argument: is_address,If
12418 `is_address' is true, then the value that we store is the address
12419 to the real value, and not the value itself.
12421 * ecore.cs (PropertyExpr): use the new local temporary
12422 stuff to allow us to handle X.Y += z (where X is a struct)
12424 2004-07-08 Martin Baulig <martin@ximian.com>
12426 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
12427 not always return, just like we're doing in Using.Resolve().
12429 2004-07-07 Miguel de Icaza <miguel@ximian.com>
12431 * cs-parser.jay (fixed_statement): flag this as Pinned.
12433 2004-07-06 Miguel de Icaza <miguel@ximian.com>
12435 * typemanager.cs (TypeManager): Removed MakePinned method, this
12436 mechanism is replaced with the .NET 2.x compatible mechanism of
12437 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
12439 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
12440 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
12441 `IsFixed' property which has a different meaning.
12443 2004-07-02 Raja R Harinath <rharinath@novell.com>
12445 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
12446 visible from inside a nested class, not just the names of the
12447 immediately enclosing class.
12448 Fix for bug #60730.
12450 2004-06-24 Raja R Harinath <rharinath@novell.com>
12452 * expression.cs (BetterConversion): Remove buggy special-case
12453 handling of "implicit constant expression conversions". At this
12454 point, we already know that the conversion is possible -- we're
12455 only checking to see which is better.
12457 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12459 * cs-parser.jay: Added error CS0210 test.
12461 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12463 * cs-parser.jay: Added error CS0134 test.
12465 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12468 * cs-parser.jay: Added error CS0145 test.
12470 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12472 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
12474 2004-06-23 Ben Maurer <bmaurer@ximian.com>
12476 * expression.cs (StackAlloc.Resolve): The argument may not
12477 be a constant; deal with this case.
12479 2004-06-23 Marek Safar <marek.safar@seznam.cz>
12481 * attribute.cs (IndexerName_GetIndexerName): Renamed to
12482 GetIndexerAttributeValue.
12483 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
12485 * class.cs (Indexer.Define): Added error tests for CS0415,
12488 2004-06-23 Miguel de Icaza <miguel@ximian.com>
12490 * attribute.cs (Attribute.Resolve): Keep field code in sync with
12493 2004-06-23 Martin Baulig <martin@ximian.com>
12495 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
12496 neither return nor throw, reset the barrier as well. Fixes #60457.
12498 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
12500 * class.cs : EventAttributes is now set to None by default.
12501 This fixes bug #60459.
12503 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12506 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12507 Don't throw exception but return null (it's sufficient now).
12509 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12511 * typemanager.cs (GetArgumentTypes): Faster implementation.
12513 2004-06-18 Martin Baulig <martin@ximian.com>
12515 * attribute.cs (Attribute.Resolve): Check whether we're an
12516 EmptyCast which a Constant child. Fixes #60333.
12518 2004-06-17 Ben Maurer <bmaurer@ximian.com>
12520 * statement.cs (EmitCollectionForeach): Account for the fact that
12521 not all valuetypes are in areas which we can take the address of.
12522 For these variables, we store to a temporary variable. Also, make
12523 sure that we dont emit a `callvirt' on a valuetype method.
12525 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12527 * expression.cs (StackAlloc.DoReSolve): Added test for
12528 negative parameter (CS0247).
12530 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12533 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
12535 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12538 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
12541 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12543 Fix bug #58254 & cs1555.cs, cs1556.cs
12544 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
12546 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12548 * cs-parser.jay: Added error CS1669 test for indexers.
12550 2004-06-11 Martin Baulig <martin@ximian.com>
12552 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
12553 call this twice: for params and varargs methods.
12555 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12558 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
12560 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12562 * attribute.cs (Attribute.GetValidTargets): Made public.
12565 (AbstractPropertyEventMethod): New class for better code sharing.
12566 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
12568 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
12570 2004-06-11 Raja R Harinath <rharinath@novell.com>
12573 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
12574 that the call to Resolve is part of a MemberAccess.
12575 (Expression.Resolve): Use it for SimpleName resolution.
12576 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
12577 Add 'intermediate' boolean argument.
12578 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
12579 error message when the SimpleName can be resolved ambiguously
12580 between an expression and a type.
12581 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
12583 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
12584 call on the left-side.
12586 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12589 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
12591 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12593 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
12595 2004-06-11 Martin Baulig <martin@ximian.com>
12597 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
12598 varargs methods if applicable.
12600 2004-06-11 Martin Baulig <martin@ximian.com>
12602 * expression.cs (Invocation.EmitCall): Don't use
12603 `method.CallingConvention == CallingConventions.VarArgs' since the
12604 method could also have `CallingConventions.HasThis'.
12606 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12608 * class.cs (Event.GetSignatureForError): Implemented.
12609 Fixed crash in error test cs3010.cs
12611 2004-06-10 Miguel de Icaza <miguel@ximian.com>
12613 * cs-tokenizer.cs: Change the way we track __arglist to be
12614 consistent with the other keywords.
12616 2004-06-09 Miguel de Icaza <miguel@ximian.com>
12618 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
12621 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
12623 * codegen.cs: Check that all referenced assemblies have a strongname
12624 before strongnaming the compiled assembly. If not report error CS1577.
12625 Fix bug #56563. Patch by Jackson Harper.
12626 * typemanager.cs: Added a method to return all referenced assemblies.
12627 Fix bug #56563. Patch by Jackson Harper.
12629 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12632 (Method.ApplyAttributeBuilder): Moved and added conditional
12633 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
12636 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
12638 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12641 * class.cs: (EventField.attribute_targets): Changed default target.
12643 2004-06-08 Martin Baulig <martin@ximian.com>
12645 * expression.cs (Invocation.EmitCall): Enable varargs methods.
12647 2004-06-08 Martin Baulig <martin@ximian.com>
12649 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
12651 2004-06-07 Martin Baulig <martin@ximian.com>
12653 Added support for varargs methods.
12655 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
12658 * cs-parser.jay: Added support for `__arglist'.
12660 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
12662 * expression.cs (Argument.AType): Added `ArgList'.
12663 (Invocation): Added support for varargs methods.
12664 (ArglistAccess): New public class.
12665 (Arglist): New public class.
12667 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
12669 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
12670 a method's top-level block if the method has varargs.
12672 * support.cs (ReflectionParameters, InternalParameters): Added
12673 support for varargs methods.
12675 2004-06-07 Miguel de Icaza <miguel@ximian.com>
12677 * class.cs: Provide location in indexer error report.
12679 * driver.cs: Use standard names.
12681 * namespace.cs: Catch the use of using after a namespace has been
12682 declared also on using aliases.
12684 2004-06-03 Raja R Harinath <rharinath@novell.com>
12687 * typemanager.cs (closure_private_ok, closure_invocation_type)
12688 (closure_qualifier_type, closure_invocation_assembly)
12689 (FilterWithClosure): Move to ...
12690 (Closure): New internal nested class.
12691 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
12692 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
12693 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
12694 (MemberLookup, MemberLookupFailed): Use it.
12695 * expression.cs (New.DoResolve): Treat the lookup for the
12696 constructor as being qualified by the 'new'ed type.
12697 (Indexers.GetIndexersForTypeOrInterface): Update.
12699 2004-06-03 Marek Safar <marek.safar@seznam.cz>
12702 (GetConditionalAttributeValue): New method. Returns
12703 condition of ConditionalAttribute.
12704 (SearchMulti): New method. Returns all attributes of type 't'.
12705 Use it when attribute is AllowMultiple = true.
12706 (IsConditionalMethodExcluded): New method.
12709 (Method.IsExcluded): Implemented. Returns true if method has conditional
12710 attribute and the conditions is not defined (method is excluded).
12711 (IMethodData): Extended interface for ConditionalAttribute support.
12712 (PropertyMethod.IsExcluded): Implemented.
12715 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
12718 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
12721 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
12723 * expression.cs (ArrayCreationExpression): Make this just an
12724 `expression'. It can't be a statement, so the code here was
12727 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12730 * typemanager.cs (GetFullNameSignature): New method for
12733 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12736 * class.cs (MemberBase.GetSignatureForError): New virtual method.
12737 Use this method when MethodBuilder is null.
12738 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
12739 Added test for error CS0626 (MONO reports error for this situation).
12740 (IMethodData.GetSignatureForError): Extended interface.
12742 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12745 (AttributeTester.GetObsoleteAttribute): Returns instance of
12746 ObsoleteAttribute when type is obsolete.
12749 (TypeContainer.VerifyObsoleteAttribute): Override.
12750 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
12751 (MethodCode.VerifyObsoleteAttribute): Override.
12752 (MemberBase.VerifyObsoleteAttribute): Override.
12755 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
12756 and report proper error.
12759 Delegate.VerifyObsoleteAttribute): Override.
12762 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
12763 and report proper error.
12764 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
12767 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
12771 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
12772 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
12773 Added test for ObsoleteAttribute.
12776 (Catch): Derived from Statement.
12778 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12780 Fixed bug #59071 & cs0160.cs
12782 * statement.cs (Try.Resolve): Check here whether order of catch
12783 clauses matches their dependencies.
12785 2004-05-31 Miguel de Icaza <miguel@ximian.com>
12787 * Reverted patch to namespace.cs (Use lookuptypedirect). This
12788 caused a regression: #59343. Referencing nested classes from an
12789 assembly stopped working.
12791 2004-05-31 Martin Baulig <martin@ximian.com>
12793 MCS is now frozen for beta 2.
12795 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12797 * convert.cs: add a trivial cache for overload operator resolution.
12799 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12801 * decl.cs: If possible, use lookuptypedirect here. We can only do
12802 this if there is no `.' after the namespace. Avoids using
12803 LookupType, which does lots of slow processing.
12804 (FindNestedType) New method, does what it says :-).
12805 * namespace.cs: use LookupTypeDirect.
12806 * rootcontext.cs: use membercache, if possible.
12807 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
12809 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12812 According to the spec,
12814 In a member access of the form E.I, if E is a single identifier,
12815 and if the meaning of E as a simple-name (§7.5.2) is a constant,
12816 field, property, localvariable, or parameter with the same type as
12817 the meaning of E as a type-name (§3.8), then both possible
12818 meanings of E are permitted.
12820 We did not check that E as a simple-name had the same type as E as
12823 This trivial check gives us 5-7% on bootstrap time.
12825 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12827 * expression.cs (Invocation.OverloadResolve): Avoid the
12828 use of hashtables and boxing here by allocating on demand.
12830 2004-05-30 Martin Baulig <martin@ximian.com>
12832 * rootcontext.cs (RootContext.LookupType): Don't cache things if
12833 we're doing a silent lookup. Don't try to lookup nested types in
12834 TypeManager.object_type (thanks to Ben Maurer).
12836 2004-05-30 Martin Baulig <martin@ximian.com>
12838 Committing a patch from Ben Maurer.
12840 * rootcontext.cs (RootContext.LookupType): Cache negative results.
12842 2004-05-29 Martin Baulig <martin@ximian.com>
12844 * class.cs (IMethodData.ShouldIgnore): New method.
12846 * typemanager.cs (TypeManager.MethodFlags): Don't take a
12847 `Location' argument, we don't need it anywhere. Use
12848 `IMethodData.ShouldIgnore ()' instead of
12849 `MethodData.GetMethodFlags ()'.
12850 (TypeManager.AddMethod): Removed.
12851 (TypeManager.AddMethod2): Renamed to AddMethod.
12853 2004-05-29 Martin Baulig <martin@ximian.com>
12855 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
12857 * convert.cs (Convert.ImplicitReferenceConversion): If we're
12858 converting from a class type S to an interface type and we already
12859 have an object on the stack, don't box it again. Fixes #52578.
12861 2004-05-29 Martin Baulig <martin@ximian.com>
12863 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12864 Added support for `params' parameters. Fixes #59267.
12866 2004-05-29 Martin Baulig <martin@ximian.com>
12868 * literal.cs (NullPointer): Provide a private .ctor which sets
12869 `type' to TypeManager.object_type. Fixes #59048.
12871 2004-05-29 Martin Baulig <martin@ximian.com>
12873 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
12874 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
12876 * ecore.cs (EventExpr.instance_expr): Make the field private.
12878 2004-05-26 Marek Safar <marek.safar@seznam.cz>
12880 Fixed bug #50080 & cs0214-2.cs
12881 * expression.cs (Cast.DoResolve): Check unsafe context here.
12883 * statement.cs (Resolve.DoResolve): Likewise.
12885 2004-05-26 Martin Baulig <martin@ximian.com>
12887 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
12889 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
12890 (RootContext.LookupType): Pass down the `silent' flag.
12892 2004-05-25 Martin Baulig <martin@ximian.com>
12895 (MethodGroupExpr.IdenticalTypeName): New public property.
12896 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
12897 expression actually refers to a type.
12899 2004-05-25 Martin Baulig <martin@ximian.com>
12901 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
12902 for #56176 and made it actually work.
12904 2004-05-25 Martin Baulig <martin@ximian.com>
12906 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
12907 (FieldExpr, PropertyExpr): Override and implement
12908 CacheTemporaries. Fixes #52279.
12910 2004-05-25 Miguel de Icaza <miguel@ximian.com>
12912 * location.cs: In the new compiler listing a file twice is a
12913 warning, not an error.
12915 2004-05-24 Martin Baulig <martin@ximian.com>
12917 * enum.cs (Enum.DefineType): For the `BaseType' to be a
12918 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
12920 2004-05-24 Martin Baulig <martin@ximian.com>
12922 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
12923 walking the `using' list. Fixes #53921.
12925 2004-05-24 Martin Baulig <martin@ximian.com>
12927 * const.cs (Const.LookupConstantValue): Added support for
12928 EmptyCast's; fixes #55251.
12930 2004-05-24 Martin Baulig <martin@ximian.com>
12932 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
12933 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
12934 which does the CS0135 check. The reason is that we first need to
12935 check whether the variable actually exists.
12937 2004-05-24 Martin Baulig <martin@ximian.com>
12939 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
12940 than RootContext.LookupType() to find the explicit interface
12941 type. Fixes #58584.
12943 2004-05-24 Raja R Harinath <rharinath@novell.com>
12945 * Makefile: Simplify. Use executable.make.
12946 * mcs.exe.sources: New file. List of sources of mcs.exe.
12948 2004-05-24 Anders Carlsson <andersca@gnome.org>
12952 Use the invariant culture when doing String.Compare for CLS case
12955 2004-05-23 Martin Baulig <martin@ximian.com>
12957 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
12958 don't have any dots. Fixes #52622, added cs0246-8.cs.
12960 * namespace.cs (NamespaceEntry.Lookup): Likewise.
12962 2004-05-23 Marek Safar <marek.safar@seznam.cz>
12964 * class.cs (MemberBase.Define): Reuse MemberType member for
12965 resolved type. Other methods can use it too.
12967 2004-05-23 Martin Baulig <martin@ximian.com>
12969 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
12970 the variable also exists in the current block (otherwise, we need
12971 to report a CS0103). Fixes #58670.
12973 2004-05-23 Martin Baulig <martin@ximian.com>
12975 * flowanalysis.cs (Reachability.Reachable): Compute this
12976 on-the-fly rather than storing it as a field.
12978 2004-05-23 Martin Baulig <martin@ximian.com>
12980 * flowanalysis.cs (Reachability.And): Manually compute the
12981 resulting `barrier' from the reachability.
12983 2004-05-23 Marek Safar <marek.safar@seznam.cz>
12986 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
12987 instance of ObsoleteAttribute when symbol is obsolete.
12990 (IMethodData): Extended interface for ObsoleteAttribute support.
12992 2004-05-22 Marek Safar <marek.safar@seznam.cz>
12994 * attribute.cs: Fix bug #55970
12996 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13000 (GetObsoleteAttribute): New method. Creates the instance of
13002 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
13003 ObsoleteAttribute when member is obsolete.
13004 (AttributeTester.Report_ObsoleteMessage): Common method for
13005 Obsolete error/warning reporting.
13008 (TypeContainer.base_classs_type): New member for storing parent type.
13011 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
13012 for this MemberCore.
13014 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13016 * attribute.cs, const.cs: Fix bug #58590
13018 2004-05-21 Martin Baulig <martin@ximian.com>
13020 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
13021 out parameters if the end of the method is unreachable. Fixes
13024 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13026 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
13027 Hari was right, why extra method.
13029 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13031 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
13033 2004-05-20 Martin Baulig <martin@ximian.com>
13035 Merged this back from gmcs to keep the differences to a minumum.
13037 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
13038 instead of a Declspace.
13039 (Attribute.ResolveType): Likewise.
13040 (Attributes.Search): Likewise.
13041 (Attributes.Contains): Likewise.
13042 (Attributes.GetClsCompliantAttribute): Likewise.
13044 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
13046 (MethodData.ApplyAttributes): Take an EmitContext instead of a
13049 2004-05-19 Marek Safar <marek.safar@seznam.cz>
13051 Fix bug #58688 (MCS does not report error when the same attribute
13054 * attribute.cs (Attribute.Emit): Distinction between null and default.
13056 2004-05-19 Raja R Harinath <rharinath@novell.com>
13058 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
13059 of a top-level attribute without an attribute target.
13060 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
13062 (Attribute.Conditional_GetConditionName),
13063 (Attribute.Obsolete_GetObsoleteMessage): Update.
13064 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
13065 part of ScanForIndexerName.
13066 (Attribute.CanIgnoreInvalidAttribute): New function.
13067 (Attribute.ScanForIndexerName): Move to ...
13068 (Attributes.ScanForIndexerName): ... here.
13069 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
13070 (Attributes.Search): New internal variant that can choose not to
13071 complain if types aren't resolved. The original signature now
13073 (Attributes.GetClsCompliantAttribute): Use internal variant, with
13074 complaints suppressed.
13075 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
13076 only if it not useful.
13077 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
13078 top-level for attributes that are shared between the assembly
13079 and a top-level class.
13080 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
13081 * class.cs: Update to reflect changes.
13082 (DefineIndexers): Fuse loops.
13083 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
13084 a couple more variants of attribute names.
13086 2004-05-18 Marek Safar <marek.safar@seznam.cz>
13088 Fix bug #52585 (Implemented explicit attribute declaration)
13091 (Attributable.ValidAttributeTargets): New abstract method. It gets
13092 list of valid attribute targets for explicit target declaration.
13093 (Attribute.Target): It holds target itself.
13094 (AttributeSection): Removed.
13095 (Attribute.CheckTargets): New method. It checks whether attribute
13096 target is valid for the current element.
13099 (EventProperty): New class. For events that are declared like
13100 property (with add and remove accessors).
13101 (EventField): New class. For events that are declared like field.
13104 * cs-parser.jay: Implemented explicit attribute target declaration.
13106 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
13107 Override ValidAttributeTargets.
13110 (ReturnParameter): Class for applying custom attributes on
13112 (ParameterAtribute): New class. Class for applying custom
13113 attributes on the parameter type.
13115 2004-05-17 Miguel de Icaza <miguel@ximian.com>
13117 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
13120 (Method): Allow UNSAFE here.
13122 * modifiers.cs: Support unsafe reporting.
13124 2004-05-17 Marek Safar <marek.safar@seznam.cz>
13126 * decl.cs: Fix bug #58478.
13128 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13130 * statement.cs: When checking for unreachable code on an EmptyStatement,
13131 set the location. Fixes bug #58488.
13133 2004-05-13 Miguel de Icaza <miguel@ximian.com>
13135 * driver.cs: Add -pkg handling.
13137 From Gonzalo: UseShelLExecute=false
13139 2004-05-12 Marek Safar <marek.safar@seznam.cz>
13142 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
13144 (Attribute.IsClsCompliaceRequired): Moved to base for better
13146 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
13147 when attribute is AttributeUsageAttribute.
13148 (Attribute.GetValidTargets): Simplified.
13149 (Attribute.GetAttributeUsage): New method returns AttributeUsage
13150 attribute for this type.
13151 (Attribute.ApplyAttributes): Method renamed to Emit and make
13153 (GlobalAttributeSection): New class for special handling of global
13154 attributes (assembly, module).
13155 (AttributeSection.Emit): New method.
13157 * class.cs: Implemented Attributable abstract methods.
13158 (MethodCore.LabelParameters): Moved to Parameter class.
13159 (Accessor): Is back simple class.
13160 (PropertyMethod): Implemented Attributable abstract class.
13161 (DelegateMethod): Implemented Attributable abstract class.
13162 (Event): New constructor for disctintion between normal Event
13163 and Event with accessors.
13165 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
13167 * codegen.cs, const.cs, decl.cs, delegate.cs:
13168 (CommonAssemblyModulClass): Implemented Attributable abstract class
13171 * enum.cs: Implement IAttributeSupport interface.
13172 (EnumMember): New class for emum members. Implemented Attributable
13176 (ParameterBase): Is abstract.
13177 (ReturnParameter): New class for easier [return:] attribute handling.
13179 * typemanager.cs: Removed builder_to_attr.
13181 2004-05-11 Raja R Harinath <rharinath@novell.com>
13184 * attribute.cs (Attribute.GetPositionalValue): New function.
13185 * class.cs (TypeContainer.VerifyMembers): New function.
13186 (TypeContainer.Emit): Use it.
13187 (ClassOrStruct): New base class for Class and Struct.
13188 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
13189 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
13191 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
13192 then each non-static field should have a FieldOffset attribute.
13193 Otherwise, none of the fields should have a FieldOffset attribute.
13194 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
13195 and FieldOffset attributes.
13196 * typemanager.cs (TypeManager.struct_layout_attribute_type)
13197 (TypeManager.field_offset_attribute_type): New core types.
13198 (TypeManager.InitCoreTypes): Initialize them.
13200 2004-05-11 Michal Moskal <malekith@pld-linux.org>
13202 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
13203 Return correct type.
13206 2004-05-09 Miguel de Icaza <miguel@ximian.com>
13208 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
13209 be implicitly converted to ulong.
13211 * expression.cs: The logic for allowing operator &, | and ^ worked
13212 was wrong, it worked before because we did not report an error in
13213 an else branch. Fixes 57895.
13215 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
13216 allow volatile fields to be reference types.
13218 2004-05-07 Miguel de Icaza <miguel@ximian.com>
13220 * driver.cs: Add support for /debug-
13222 2004-05-07 Raja R Harinath <rharinath@novell.com>
13224 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
13225 Add a 'complain' parameter to silence errors.
13226 (Attribute.Resolve): Update to changes. Put in sanity check to catch
13227 silently overlooked type-resolutions.
13228 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
13229 to reflect changes.
13230 (Attributes.Search): New function.
13231 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
13232 (Attributes.GetAttributeFullName): Remove hack.
13233 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
13234 Update to reflect changes.
13235 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
13236 Use Attributes.Search instead of nested loops.
13238 2004-05-07 Marek Safar <marek.safar@seznam.cz>
13241 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
13242 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
13243 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
13245 * report.cs: (Report.Warning): Renamed to Warning_T because of
13246 parameter collision.
13248 2004-05-05 Raja R Harinath <rharinath@novell.com>
13250 * expression.cs (MemberAccess.ResolveMemberAccess):
13251 Exit with non-zero status after Report.Error.
13252 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
13254 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
13256 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13258 * support.cs: Don't hang when the file is empty.
13260 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13262 * support.cs: In SeekableStreamReader, compute the preamble size of the
13263 underlying stream. Position changes should take into account that initial
13266 2004-05-03 Todd Berman <tberman@sevenl.net>
13268 * driver.cs: remove unused GetSysVersion function.
13270 2004-05-03 Todd Berman <tberman@sevenl.net>
13272 * driver.cs: Remove the hack from saturday, as well as the hack
13273 from jackson (LoadAssemblyFromGac), also adds the CWD to the
13274 link_paths to get that bit proper.
13276 2004-05-01 Todd Berman <tberman@sevenl.net>
13278 * driver.cs: Try a LoadFrom before a Load, this checks the current
13279 path. This is currently a bug in mono that is be fixed, however, this
13280 provides a workaround for now. This will be removed when the bug
13283 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
13285 * CryptoConvert.cs: Updated to latest version. Fix issue with
13286 incomplete key pairs (#57941).
13288 2004-05-01 Todd Berman <tberman@sevenl.net>
13290 * driver.cs: Remove '.' from path_chars, now System.* loads properly
13293 2004-04-30 Jackson Harper <jackson@ximian.com>
13295 * codegen.cs: Open keys readonly.
13297 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13299 * typemanager.cs: don't report cyclic struct layout when a struct
13300 contains 2 or more fields of the same type. Failed for Pango.AttrShape
13301 which has 2 Pango.Rectangle fields.
13303 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
13305 * expression.cs: Handle IntPtr comparisons with IL code
13306 rather than a method call.
13308 2004-04-29 Martin Baulig <martin@ximian.com>
13310 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
13311 the list of PropertyInfo's in class hierarchy and find the
13312 accessor. Fixes #56013.
13314 2004-04-29 Martin Baulig <martin@ximian.com>
13316 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
13318 2004-04-29 Martin Baulig <martin@ximian.com>
13320 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13322 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
13324 2004-04-29 Martin Baulig <martin@ximian.com>
13326 * class.cs (ConstructorInitializer.Resolve): Check whether the
13327 parent .ctor is accessible. Fixes #52146.
13329 2004-04-29 Martin Baulig <martin@ximian.com>
13331 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13333 * statement.cs (Using.EmitLocalVariableDecls): Use
13334 TypeManager.idisposable_type, not typeof (IDisposable).
13335 (Foreach.EmitCollectionForeach): Added support for valuetypes.
13337 2004-04-29 Martin Baulig <martin@ximian.com>
13339 * class.cs (Event.Define): Don't emit the field and don't set
13340 RTSpecialName and SpecialName for events on interfaces. Fixes
13343 2004-04-29 Raja R Harinath <rharinath@novell.com>
13345 Refactor Attribute.ApplyAttributes.
13346 * attribute.cs (Attributable): New base class for objects that can
13347 have Attributes applied on them.
13348 (Attribute): Make AttributeUsage fields public.
13349 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
13350 (Attribute.IsInternalCall): New property.
13351 (Attribute.UsageAttr): Convert to a public read-only property.
13352 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
13353 (Attribute.ResolveType, Attribute.Resolve)
13354 (Attribute.ScanForIndexerName): Update to reflect changes.
13355 (Attribute.CheckAttributeTarget): Re-format.
13356 (Attribute.ApplyAttributes): Refactor, to various
13357 Attributable.ApplyAttributeBuilder methods.
13358 * decl.cs (MemberCore): Make Attributable.
13359 * class.cs (Accessor): Make Attributable.
13360 (MethodData.ApplyAttributes): Use proper attribute types, not
13362 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
13363 (TypeContainer.ApplyAttributeBuilder)
13364 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
13365 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
13366 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
13367 (Operator.ApplyAttributeBuilder): New factored-out methods.
13368 * const.cs (Const.ApplyAttributeBuilder): Likewise.
13369 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
13370 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
13371 * parameter.cs (ParameterBase): New Attributable base class
13372 that can also represent Return types.
13373 (Parameter): Update to the changes.
13375 2004-04-29 Jackson Harper <jackson@ximian.com>
13377 * driver.cs: Prefer the corlib system version when looking for
13378 assemblies in the GAC. This is still a hack, but its a better hack
13381 2004-04-29 Marek Safar <marek.safar@seznam.cz>
13383 * decl.cs, enum.cs: Improved error 3005 reporting.
13385 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
13386 (related_symbols): New private member for list of symbols
13387 related to reported error/warning.
13389 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
13391 2004-04-29 Martin Baulig <martin@ximian.com>
13393 * ecore.cs (Expression.Constantify): If we're an enum and
13394 TypeManager.TypeToCoreType() doesn't give us another type, use
13395 t.UnderlyingSystemType. Fixes #56178.
13397 2004-04-29 Martin Baulig <martin@ximian.com>
13399 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
13400 interfaces and for each interface, only add members directly
13401 declared in that interface. Fixes #53255.
13403 2004-04-28 Martin Baulig <martin@ximian.com>
13405 * expression.cs (ConditionalLogicalOperator): Use a temporary
13406 variable for `left' to avoid that we evaluate it more than once;
13409 2004-04-28 Martin Baulig <martin@ximian.com>
13411 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
13414 2004-04-28 Martin Baulig <martin@ximian.com>
13416 * statement.cs (LocalInfo.Resolve): Check whether the type is not
13419 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
13420 whether the type is not void (CS1547).
13422 2004-04-28 Martin Baulig <martin@ximian.com>
13424 * expression.cs (Unary.DoResolveLValue): Override this and report
13425 CS0131 for anything but Operator.Indirection.
13427 2004-04-28 Martin Baulig <martin@ximian.com>
13429 Committing a patch from Ben Maurer; see bug #50820.
13431 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13434 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13437 2004-04-28 Martin Baulig <martin@ximian.com>
13439 Committing a patch from Ben Maurer; see bug #50820.
13441 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13444 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13447 2004-04-28 Martin Baulig <martin@ximian.com>
13449 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
13450 (Block.AddLabel): Call DoLookupLabel() to only search in the
13453 2004-04-28 Martin Baulig <martin@ximian.com>
13455 * cfold.cs (ConstantFold.BinaryFold): Added special support for
13456 comparing StringConstants and NullLiterals in Equality and Inequality.
13458 2004-04-28 Jackson Harper <jackson@ximian.com>
13460 * driver.cs: Attempt to load referenced assemblies from the
13461 GAC. This is the quick and dirty version of this method that
13462 doesnt take into account versions and just takes the first
13463 canidate found. Will be good enough for now as we will not have more
13464 then one version installed into the GAC until I update this method.
13466 2004-04-28 Martin Baulig <martin@ximian.com>
13468 * typemanager.cs (TypeManager.CheckStructCycles): New public
13469 static method to check for cycles in the struct layout.
13471 * rootcontext.cs (RootContext.PopulateTypes): Call
13472 TypeManager.CheckStructCycles() for each TypeContainer.
13473 [Note: We only need to visit each type once.]
13475 2004-04-28 Martin Baulig <martin@ximian.com>
13477 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
13479 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
13480 success and added `out object value'. Use a `bool resolved' field
13481 to check whether we've already been called rather than
13482 `ConstantValue != null' since this breaks for NullLiterals.
13484 2004-04-28 Raja R Harinath <rharinath@novell.com>
13486 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
13487 setting of this flag, since the 'set' method may be non-public.
13489 2004-04-28 Raja R Harinath <rharinath@novell.com>
13491 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
13492 check on current_vector.Block.
13494 2004-04-27 Martin Baulig <martin@ximian.com>
13496 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
13497 a field initializer. Fixes #56459.
13499 2004-04-27 Martin Baulig <martin@ximian.com>
13501 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
13502 we're not attempting to use an indexer. Fixes #52154.
13504 2004-04-27 Martin Baulig <martin@ximian.com>
13506 * statement.cs (Return): Don't create a return label if we don't
13507 need it; reverts my change from January 20th. Thanks to Ben
13510 2004-04-27 Martin Baulig <martin@ximian.com>
13512 According to the spec, `goto' can only leave a nested scope, but
13515 * statement.cs (Block.LookupLabel): Only lookup in the current
13516 block, don't recurse into parent or child blocks.
13517 (Block.AddLabel): Check in parent and child blocks, report
13518 CS0140/CS0158 if we find a duplicate.
13519 (Block): Removed this indexer for label lookups.
13520 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
13521 this already does the error reporting for us.
13524 (FlowBranching.UsageVector.Block): New public variable; may be null.
13525 (FlowBranching.CreateSibling): Added `Block' argument.
13526 (FlowBranching.LookupLabel): New public virtual method. Lookup a
13527 label for the target of a `goto' and check whether we're not
13528 leaving a `finally'.
13530 2004-04-27 Martin Baulig <martin@ximian.com>
13532 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13533 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
13536 2004-04-27 Martin Baulig <martin@ximian.com>
13538 * statement.cs (Block.AddLabel): Also check for implicit blocks
13539 and added a CS0158 check.
13541 2004-04-27 Martin Baulig <martin@ximian.com>
13543 * flowanalysis.cs (FlowBranchingLoop): New class.
13544 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
13545 UsageVector's instead of an ArrayList.
13546 (FlowBranching.Label): Likewise.
13547 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
13548 (FlowBranching.AddBreakVector): New method.
13550 2004-04-27 Miguel de Icaza <miguel@ximian.com>
13552 * attribute.cs: Small regression fix: only convert the type if we
13553 the type is different, fixes System.Drawing build.
13555 2004-04-27 Martin Baulig <martin@ximian.com>
13557 * attribute.cs (Attribute.Resolve): If we have a constant value
13558 for a named field or property, implicity convert it to the correct
13561 2004-04-27 Raja R Harinath <rharinath@novell.com>
13563 * statement.cs (Block.Block): Implicit blocks share
13564 'child_variable_names' fields with parent blocks.
13565 (Block.AddChildVariableNames): Remove.
13566 (Block.AddVariable): Mark variable as "used by a child block" in
13567 every surrounding block.
13568 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
13569 been used in a child block, complain about violation of "Invariant
13570 meaning in blocks" rule.
13571 * cs-parser.jay (declare_local_variables): Don't use
13572 AddChildVariableNames.
13573 (foreach_statement): Don't create an implicit block: 'foreach'
13574 introduces a scope.
13576 2004-04-23 Miguel de Icaza <miguel@ximian.com>
13578 * convert.cs (ImplicitNumericConversion): 0 is also positive when
13579 converting from 0L to ulong. Fixes 57522.
13581 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13583 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
13584 derived class hides via 'new' keyword field from base class (test-242.cs).
13585 TODO: Handle this in the more general way.
13587 * class.cs (CheckBase): Ditto.
13589 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13591 * decl.cs (caching_flags): New member for storing cached values
13593 (MemberCore.Flags): New enum where bit flags for caching_flags
13595 (MemberCore.cls_compliance): Moved to caching_flags.
13596 (DeclSpace.Created): Moved to caching_flags.
13598 * class.cs: Use caching_flags instead of DeclSpace.Created
13600 2004-04-21 Miguel de Icaza <miguel@ximian.com>
13602 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
13603 if we are only a derived class, not a nested class.
13605 * typemanager.cs: Same as above, but do this at the MemberLookup
13606 level (used by field and methods, properties are handled in
13607 PropertyExpr). Allow for the qualified access if we are a nested
13610 2004-04-21 Marek Safar <marek.safar@seznam.cz>
13612 * class.cs: Refactoring.
13613 (IMethodData): New inteface; Holds links to parent members
13614 to avoid member duplication (reduced memory allocation).
13615 (Method): Implemented IMethodData interface.
13616 (PropertyBase): New inner classes for get/set methods.
13617 (PropertyBase.PropertyMethod): Implemented IMethodData interface
13618 (Event): New inner classes for add/remove methods.
13619 (Event.DelegateMethod): Implemented IMethodData interface.
13621 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
13622 EmitContext (related to class.cs refactoring).
13624 2004-04-21 Raja R Harinath <rharinath@novell.com>
13626 * delegate.cs (Delegate.VerifyApplicability): If the number of
13627 arguments are the same as the number of parameters, first try to
13628 verify applicability ignoring any 'params' modifier on the last
13632 2004-04-16 Raja R Harinath <rharinath@novell.com>
13634 * class.cs (TypeContainer.AddIndexer): Use
13635 'ExplicitInterfaceName' to determine if interface name was
13636 explicitly specified. 'InterfaceType' is not initialized at this time.
13637 (TypeContainer.DefineIndexers): Remove use of temporary list. The
13638 Indexers array is already in the required order. Initialize
13639 'IndexerName' only if there are normal indexers.
13640 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
13641 (TypeContainer.Emit): Emit DefaultMember attribute only if
13642 IndexerName is initialized.
13645 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
13647 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
13650 2004-04-15 Raja R Harinath <rharinath@novell.com>
13652 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
13656 * attribute.cs (Attribute.Resolve): Check for duplicate named
13660 2004-04-15 Miguel de Icaza <miguel@ximian.com>
13662 * iterators.cs (MarkYield): track whether we are in an exception,
13663 and generate code accordingly. Use a temporary value to store the
13664 result for our state.
13666 I had ignored a bit the interaction of try/catch with iterators
13667 since their behavior was not entirely obvious, but now it is
13668 possible to verify that our behavior is the same as MS .NET 2.0
13672 2004-04-14 Miguel de Icaza <miguel@ximian.com>
13674 * iterators.cs: Avoid creating temporaries if there is no work to
13677 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
13678 Enumerations, use TypeManager.EnumToUnderlying and call
13681 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
13684 (This.Emit): Use EmitContext.EmitThis to emit our
13687 (This.EmitAssign): Ditto.
13689 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
13690 codepaths, we will move all the functionality into
13693 (FieldExpr.EmitAssign): Ditto.
13695 This fixes several hidden bugs that I uncovered while doing a code
13696 review of this today.
13698 * codegen.cs (EmitThis): reworked so the semantics are more clear
13699 and also support value types "this" instances.
13701 * iterators.cs: Changed so that for iterators in value types, we
13702 do not pass the value type as a parameter.
13704 Initialization of the enumerator helpers is now done in the caller
13705 instead of passing the parameters to the constructors and having
13706 the constructor set the fields.
13708 The fields have now `assembly' visibility instead of private.
13710 2004-04-11 Miguel de Icaza <miguel@ximian.com>
13712 * expression.cs (Argument.Resolve): Check if fields passed as ref
13713 or out are contained in a MarshalByRefObject.
13715 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
13716 another compiler type.
13718 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
13720 * class.cs (Indexer.Define): use the new name checking method.
13721 Also, return false on an error.
13722 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
13723 (is_identifier_[start/part]_character): make static.
13725 2004-04-10 Miguel de Icaza <miguel@ximian.com>
13727 * expression.cs (Binary.ResolveOperator): Do no append strings
13728 twice: since we can be invoked more than once (array evaluation)
13729 on the same concatenation, take care of this here. Based on a fix
13730 from Ben (bug #56454)
13732 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
13734 * codegen.cs: Fix another case where CS1548 must be reported (when
13735 delay-sign isn't specified and no private is available #56564). Fix
13736 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
13737 error when MCS is used on the MS runtime and we need to delay-sign
13738 (which seems unsupported by AssemblyBuilder - see #56621).
13740 2004-04-08 Marek Safar <marek.safar@seznam.cz>
13742 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
13743 (TypeManager.ComputeNamespaces): Faster implementation for
13746 * compiler.csproj: Updated AssemblyName to mcs.
13748 2004-04-07 Miguel de Icaza <miguel@ximian.com>
13750 * rootcontext.cs: Add new types to the boot resolution.
13752 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
13753 MulticastDelegate is not allowed.
13755 * typemanager.cs: Add new types to lookup: System.TypedReference
13758 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
13759 check for TypedReference or ArgIterator, they are not allowed.
13761 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
13762 makes us properly catch 1510 in some conditions (see bug 56016 for
13765 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
13767 * CryptoConvert.cs: update from corlib version
13770 2004-04-05 Miguel de Icaza <miguel@ximian.com>
13772 * class.cs (Indexer.Define): Check indexername declaration
13774 2004-04-05 Marek Safar <marek.safar@seznam.cz>
13776 * attribute.cs (IsClsCompliant): Fixed problem with handling
13777 all three states (compliant, not-compliant, undetected).
13779 2004-03-30 Marek Safar <marek.safar@seznam.cz>
13781 * attribute.cs (Attribute): Location is now public.
13782 (Resolve): Store resolved arguments (pos_values) in attribute class.
13783 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
13784 (GetClsCompliantAttributeValue): New method that gets
13785 CLSCompliantAttribute value.
13786 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
13787 if exists else null.
13788 (AttributeTester): New class for CLS-Compliant verification routines.
13790 * class.cs (Emit): Add CLS-Compliant verification.
13791 (Method.GetSignatureForError): Implemented.
13792 (Constructor.GetSignatureForError): Implemented
13793 (Constructor.HasCompliantArgs): Returns if constructor has
13794 CLS-Compliant arguments.
13795 (Constructor.Emit): Override.
13796 (Construcor.IsIdentifierClsCompliant): New method; For constructors
13797 is needed to test only parameters.
13798 (FieldBase.GetSignatureForError): Implemented.
13799 (TypeContainer): New member for storing base interfaces.
13800 (TypeContainer.FindMembers): Search in base interfaces too.
13802 * codegen.cs (GetClsComplianceAttribute): New method that gets
13803 assembly or module CLSCompliantAttribute value.
13804 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
13806 (ModuleClass.Emit): Add error 3012 test.
13808 * const.cs (Emit): Override and call base for CLS-Compliant tests.
13810 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
13811 state for all decl types.
13812 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
13813 if CLS-Compliant tests are required.
13814 (IsClsCompliaceRequired): New method. Analyze whether code
13815 must be CLS-Compliant.
13816 (IsExposedFromAssembly): New method. Returns true when MemberCore
13817 is exposed from assembly.
13818 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
13819 value or gets cached value.
13820 (HasClsCompliantAttribute): New method. Returns true if MemberCore
13821 is explicitly marked with CLSCompliantAttribute.
13822 (IsIdentifierClsCompliant): New abstract method. This method is
13823 used to testing error 3005.
13824 (IsIdentifierAndParamClsCompliant): New method. Common helper method
13825 for identifier and parameters CLS-Compliant testing.
13826 (VerifyClsCompliance): New method. The main virtual method for
13827 CLS-Compliant verifications.
13828 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
13829 null. I don't know why is null (too many public members !).
13830 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
13831 and get value of first CLSCompliantAttribute that found.
13833 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
13834 (VerifyClsCompliance): Override and add extra tests.
13836 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
13837 clscheck- disable CLS-Compliant verification event if assembly is has
13838 CLSCompliantAttribute(true).
13840 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
13841 ApllyAttribute is now called in emit section as in the other cases.
13842 Possible future Emit integration.
13843 (IsIdentifierClsCompliant): New override.
13844 (VerifyClsCompliance): New override.
13845 (GetEnumeratorName): Returns full enum name.
13847 * parameter.cs (GetSignatureForError): Implemented.
13849 * report.cs (WarningData): New struct for Warning message information.
13850 (LocationOfPreviousError): New method.
13851 (Warning): New method. Reports warning based on the warning table.
13852 (Error_T): New method. Reports error based on the error table.
13854 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
13855 verifications are done here.
13857 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
13859 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
13860 CLSCompliantAttribute.
13861 (all_imported_types): New member holds all imported types from other
13863 (LoadAllImportedTypes): New method fills static table with exported types
13864 from all referenced assemblies.
13865 (Modules): New property returns all assembly modules.
13867 2004-03-30 Miguel de Icaza <miguel@ximian.com>
13869 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
13870 throwing a parser error.
13872 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
13873 which removes the hardcoded get_/set_ prefixes for properties, as
13874 IL allows for the properties to be named something else.
13878 * expression.cs: Do not override operand before we know if it is
13879 non-null. Fix 56207
13881 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13883 * typemanager.cs: support for pinned variables.
13885 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13887 * decl.cs, typemanager.cs: Avoid using an arraylist
13888 as a buffer if there is only one result set.
13890 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13892 * expression.cs: Make sure you cant call a static method
13893 with an instance expression, bug #56174.
13895 2004-03-29 Miguel de Icaza <miguel@ximian.com>
13897 * class.cs (IsDuplicateImplementation): Improve error reporting to
13898 flag 663 (method only differs in parameter modifier).
13900 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
13901 in preprocessor directives.
13903 * location.cs (LookupFile): Allow for the empty path.
13905 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
13906 better approach for some of that patch, but its failing with the
13907 CharSet enumeration. For now try/catch will do.
13909 * typemanager.cs: Do not crash if a struct does not have fields.
13912 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13914 * expression.cs: cs0213, cant fix a fixed expression.
13917 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13919 * cs-parser.jay: detect invalid embeded statements gracefully.
13922 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13924 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
13927 the invocation type may not be a subclass of the tye of the item/
13928 The type of the item must be a subclass of the invocation item.
13933 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
13935 * attribute.cs: Added methods to get a string and a bool from an
13936 attribute. Required to information from AssemblyKeyFileAttribute,
13937 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
13938 * codegen.cs: Modified AssemblyName creation to include support for
13939 strongnames. Catch additional exceptions to report them as CS1548.
13940 * compiler.csproj: Updated include CryptoConvert.cs.
13941 * compiler.csproj.user: Removed file - user specific configuration.
13942 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
13943 Mono.Security assembly. The original class is maintained and tested in
13944 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
13945 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
13946 like CSC 8.0 (C# v2) supports.
13947 * Makefile: Added CryptoConvert.cs to mcs sources.
13948 * rootcontext.cs: Added new options for strongnames.
13950 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
13952 * driver.cs: For --expect-error, report error code `2'
13953 if the program compiled with no errors, error code `1' if
13954 it compiled with an error other than the one expected.
13956 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
13958 * compiler.csproj: Updated for Visual Studio .NET 2003.
13959 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
13960 * compiler.sln: Updated for Visual Studio .NET 2003.
13962 2004-03-24 Ravi Pratap M <ravi@ximian.com>
13964 * expression.cs: Fix bug #47234. We basically need to apply the
13965 rule that we prefer the conversion of null to a reference type
13966 when faced with a conversion to 'object' (csc behaviour).
13968 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13970 * statement.cs: Shorter form for foreach, eliminates
13971 a local variable. r=Martin.
13973 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13975 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
13976 checks if we can use brtrue/brfalse to test for 0.
13977 * expression.cs: use the above in the test for using brtrue/brfalse.
13978 cleanup code a bit.
13980 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13982 * expression.cs: Rewrite string concat stuff. Benefits:
13984 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
13985 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
13986 rather than a concat chain.
13988 * typemanager.cs: Add lookups for more concat overloads.
13990 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13992 * expression.cs: Emit shorter il code for array init.
14009 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
14011 * statement.cs: Before, two switch blocks would be merged if the
14012 total size of the blocks (end_item - begin_item + 1) was less than
14013 two times the combined sizes of the blocks.
14015 Now, it will only merge if after the merge at least half of the
14020 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
14022 * class.cs : csc build fix for GetMethods(). See bug #52503.
14024 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
14026 * expression.cs: Make sure fp comparisons work with NaN.
14027 This fixes bug #54303. Mig approved this patch a long
14028 time ago, but we were not able to test b/c the runtime
14031 2004-03-19 Miguel de Icaza <miguel@ximian.com>
14033 * ecore.cs (TypExpr.GetHashCode): implement this overload.
14035 2004-03-19 Martin Baulig <martin@ximian.com>
14037 * class.cs (MemberCore.IsDuplicateImplementation): Report the
14038 error here and not in our caller.
14040 2004-03-19 Martin Baulig <martin@ximian.com>
14042 * interface.cs: Completely killed this file.
14043 (Interface): We're now a TypeContainer and live in class.cs.
14045 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
14046 argument; we're now also called for interfaces.
14047 (TypeContainer.DefineMembers): Allow this method being called
14049 (TypeContainer.GetMethods): New public method; formerly known as
14050 Interface.GetMethod(). This is used by PendingImplementation.
14051 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
14052 it's now private and non-static.
14053 (Interface): Moved this here; it's now implemented similar to
14055 (Method, Property, Event, Indexer): Added `bool is_interface'
14056 argument to their .ctor's.
14057 (MemberBase.IsInterface): New public field.
14059 * cs-parser.jay: Create normal Method, Property, Event, Indexer
14060 instances instead of InterfaceMethod, InterfaceProperty, etc.
14061 (opt_interface_base): Removed; we now use `opt_class_base' instead.
14062 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
14064 2004-03-19 Martin Baulig <martin@ximian.com>
14066 * class.cs (MethodCore.IsDuplicateImplementation): New private
14067 method which does the CS0111 checking.
14068 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14069 Use IsDuplicateImplementation().
14071 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
14073 * decl.cs (FindMemberToOverride): New method to find the correct
14074 method or property to override in the base class.
14076 - Make Method/Property use the above method to find the
14077 version in the base class.
14078 - Remove the InheritableMemberSignatureCompare as it is now
14081 This patch makes large code bases much faster to compile, as it is
14082 O(n) rather than O(n^2) to do this validation.
14084 Also, it fixes bug 52458 which is that nested classes are not
14085 taken into account when finding the base class member.
14087 Reviewed/Approved by Martin.
14089 2004-03-17 Marek Safar <marek.safar@seznam.cz>
14091 * interface.cs: In all interface classes removed redundant
14092 member initialization.
14094 2004-03-16 Martin Baulig <martin@ximian.com>
14096 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
14098 2004-03-15 Miguel de Icaza <miguel@ximian.com>
14100 * decl.cs (DefineTypeAndParents): New helper method to define a
14101 type's containers before the type itself is defined; This is a
14102 bug exposed by the recent changes to Windows.Forms when an
14103 implemented interface was defined inside a class that had not been
14106 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
14108 (Check): Loop correctly to report errors modifiers
14109 (UNSAFE was not in the loop, since it was the same as TOP).
14111 * interface.cs: Every interface member now takes a ModFlags,
14112 instead of a "is_new" bool, which we set on the base MemberCore.
14114 Every place where we called "UnsafeOk" in the interface, now we
14115 call the proper member (InterfaceMethod.UnsafeOK) instead to get
14116 the unsafe settings from the member declaration instead of the
14117 container interface.
14119 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
14121 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
14122 `set_indexer_name' to the pending bits (one per type).
14124 We fixed a bug today that was picking the wrong method to
14125 override, since for properties the existing InterfaceMethod code
14126 basically ignored the method name. Now we make sure that the
14127 method name is one of the valid indexer names.
14129 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
14131 * support.cs (SeekableStreamReader): Keep track of stream byte
14132 positions and don't mix them with character offsets to the buffer.
14134 Patch from Gustavo Giráldez
14136 2004-03-15 Marek Safar <marek.safar@seznam.cz>
14138 * interface.cs (InterfaceSetGetBase): Removed double member
14139 initialization, base class does it as well.
14141 2004-03-13 Martin Baulig <martin@ximian.com>
14143 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
14144 when compiling corlib.
14146 2004-03-13 Miguel de Icaza <miguel@ximian.com>
14148 * convert.cs (ExplicitConversion): We were reporting an error on
14149 certain conversions (object_type source to a value type, when the
14150 expression was `null') before we had a chance to pass it through
14151 the user defined conversions.
14153 * driver.cs: Replace / and \ in resource specifications to dots.
14156 * class.cs: Add check for duplicate operators. Fixes 52477
14158 2004-03-11 Miguel de Icaza <miguel@ximian.com>
14160 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
14161 that are in the middle of the statements, not only at the end.
14164 * class.cs (TypeContainer.AddField): No longer set the
14165 `HaveStaticConstructor' flag, now we call it
14166 `UserDefineStaticConstructor' to diferentiate the slightly
14167 semantic difference.
14169 The situation is that we were not adding BeforeFieldInit (from
14170 Modifiers.TypeAttr) to classes that could have it.
14171 BeforeFieldInit should be set to classes that have no static
14176 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
14178 And most importantly Zoltan's comment:
14180 http://bugzilla.ximian.com/show_bug.cgi?id=44229
14182 "I think beforefieldinit means 'it's ok to initialize the type sometime
14183 before its static fields are used', i.e. initialization does not need
14184 to be triggered by the first access to the type. Setting this flag
14185 helps the JIT to compile better code, since it can run the static
14186 constructor at JIT time, and does not need to generate code to call it
14187 (possibly lots of times) at runtime. Unfortunately, mcs does not set
14188 this flag for lots of classes like String.
14190 csc sets this flag if the type does not have an explicit static
14191 constructor. The reasoning seems to be that if there are only static
14192 initalizers for a type, and no static constructor, then the programmer
14193 does not care when this initialization happens, so beforefieldinit
14196 This bug prevents the AOT compiler from being usable, since it
14197 generates so many calls to mono_runtime_class_init that the AOT code
14198 is much slower than the JITted code. The JITted code is faster,
14199 because it does not generate these calls if the vtable is type is
14200 already initialized, which is true in the majority of cases. But the
14201 AOT compiler can't do this."
14203 2004-03-10 Miguel de Icaza <miguel@ximian.com>
14205 * class.cs (MethodData.Emit): Refactor the code so symbolic
14206 information is generated for destructors; For some reasons we
14207 were taking a code path that did not generate symbolic information
14210 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
14212 * class.cs: Create a Constructor.CheckBase method that
14213 takes care of all validation type code. The method
14214 contains some code that was moved from Define.
14216 It also includes new code that checks for duplicate ctors.
14217 This fixes bug #55148.
14219 2004-03-09 Joshua Tauberer <tauberer@for.net>
14221 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
14222 a { ... }-style array creation invokes EmitStaticInitializers
14223 which is not good for reference-type arrays. String, decimal
14224 and now null constants (NullCast) are not counted toward
14225 static initializers.
14227 2004-03-05 Martin Baulig <martin@ximian.com>
14229 * location.cs (SourceFile.HasLineDirective): New public field;
14230 specifies whether the file contains or is referenced by a "#line"
14232 (Location.DefineSymbolDocuments): Ignore source files which
14233 either contain or are referenced by a "#line" directive.
14235 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
14237 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
14238 direct access to our parent, so check the method inline there.
14240 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
14242 * expression.cs (Invocation.EmitCall): Miguel's last commit
14243 caused a regression. If you had:
14248 In Foo the implict this would be null.
14250 2004-02-27 Miguel de Icaza <miguel@ximian.com>
14252 * expression.cs (Invocation.EmitCall): If the method is not
14253 virtual, do not emit a CallVirt to it, use Call.
14255 * typemanager.cs (GetFullNameSignature): Improve the method to
14256 cope with ".ctor" and replace it with the type name.
14258 * class.cs (ConstructorInitializer.Resolve): Now the method takes
14259 as an argument the ConstructorBuilder where it is being defined,
14260 to catch the recursive constructor invocations.
14262 2004-02-26 Miguel de Icaza <miguel@ximian.com>
14264 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
14265 routines to check if a type is an enumerable/enumerator allow
14266 classes that implement the IEnumerable or IEnumerator interfaces.
14268 * class.cs (Property, Operator): Implement IIteratorContainer, and
14269 implement SetYields.
14271 (Property.Define): Do the block swapping for get_methods in the
14272 context of iterators. We need to check if Properties also
14273 include indexers or not.
14275 (Operator): Assign the Block before invoking the
14276 OperatorMethod.Define, so we can trigger the Iterator code
14279 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
14280 Property and Operator classes are not created when we parse the
14281 declarator but until we have the block completed, so we use a
14282 singleton SimpleIteratorContainer.Simple to flag whether the
14283 SetYields has been invoked.
14285 We propagate this setting then to the Property or the Operator to
14286 allow the `yield' to function.
14288 2004-02-25 Marek Safar <marek.safar@seznam.cz>
14290 * codegen.cs: Implemented attribute support for modules.
14291 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
14292 Assembly/Module functionality.
14294 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
14295 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
14296 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
14298 2004-02-16 Marek Safar <marek.safar@seznam.cz>
14300 * interface.cs (FindMembers): The operation is performed on all base
14301 interfaces and not only on the first. It is required for future CLS Compliance patch.
14303 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
14305 * statement.cs, codegen.cs:
14306 This patch deals with patterns such as:
14308 public class List : IEnumerable {
14310 public MyEnumerator GetEnumerator () {
14311 return new MyEnumerator(this);
14314 IEnumerator IEnumerable.GetEnumerator () {
14318 public struct MyEnumerator : IEnumerator {
14323 Before, there were a few things we did wrong:
14324 1) we would emit callvirt on a struct, which is illegal
14325 2) we emited ldarg when we needed to emit ldarga
14326 3) we would mistakenly call the interface methods on an enumerator
14327 type that derived from IEnumerator and was in another assembly. For example:
14329 public class MyEnumerator : IEnumerator
14331 Would have the interface methods called, even if there were public impls of the
14332 method. In a struct, this lead to invalid IL code.
14334 2004-02-11 Marek Safar <marek.safar@seznam.cz>
14336 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
14339 * delegate.cs (Define): Fixed crash when delegate type is undefined.
14341 2004-02-11 Miguel de Icaza <miguel@ximian.com>
14343 * cs-parser.jay: Fix small regression: we were not testing V2
14344 compiler features correctly.
14346 * interface.cs: If the emit context is null, then create one
14348 2004-02-09 Marek Safar <marek.safar@seznam.cz>
14350 * decl.cs (GetSignatureForError): New virtual method to get full name
14351 for error messages.
14353 * attribute.cs (IAttributeSupport): New interface for attribute setting.
14354 Now it is possible to rewrite ApplyAttributes method to be less if/else.
14356 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
14357 Duplicated members and code in these classes has been removed.
14358 Better encapsulation in these classes.
14360 2004-02-07 Miguel de Icaza <miguel@ximian.com>
14362 * assign.cs (Assign.DoResolve): When dealing with compound
14363 assignments, there is a new rule in ECMA C# 2.4 (might have been
14364 there before, but it is documented here) that states that in:
14368 If b is of type int, and the `op' is a shift-operator, then the
14369 above is evaluated as:
14373 * expression.cs (Binary.ResolveOperator): Instead of testing for
14374 int/uint/long/ulong, try to implicitly convert to any of those
14375 types and use that in pointer arithmetic.
14377 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
14378 method to print information for from the type, not from the
14379 null-method we were given.
14381 2004-02-01 Duncan Mak <duncan@ximian.com>
14383 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
14384 parsing for cmd, fixes bug #53694.
14386 2004-02-04 Marek Safar <marek.safar@seznam.cz>
14388 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
14389 in the member name duplication tests. Property and operator name duplication
14390 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
14392 2004-02-03 Marek Safar <marek.safar@seznam.cz>
14394 * interface.cs (PopulateMethod): Fixed crash when interface method
14395 returns not existing type (error test cs0246-3.cs).
14397 2004-02-02 Ravi Pratap M <ravi@ximian.com>
14399 * cs-parser.jay (interface_accessors): Re-write actions to also
14400 store attributes attached to get and set methods. Fix spelling
14403 (inteface_property_declaration): Modify accordingly.
14405 (InterfaceAccessorInfo): New helper class to store information to pass
14406 around between rules that use interface_accessors.
14408 * interface.cs (Emit): Apply attributes on the get and set
14409 accessors of properties and indexers too.
14411 * attribute.cs (ApplyAttributes): Modify accordingly to use the
14412 right MethodBuilder when applying attributes to the get and set accessors.
14414 2004-01-31 Miguel de Icaza <miguel@ximian.com>
14416 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
14418 2004-01-26 Miguel de Icaza <miguel@ximian.com>
14420 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
14422 2004-01-25 Miguel de Icaza <miguel@ximian.com>
14424 * cs-parser.jay: Remove YIELD token, instead use the new grammar
14425 changes that treat `yield' specially when present before `break'
14426 or `return' tokens.
14428 * cs-tokenizer.cs: yield is no longer a keyword.
14430 2004-01-23 Marek Safar <marek.safar@seznam.cz>
14432 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
14433 setting for default constructors.
14434 For default constructors are almost every time set wrong Modifier. The
14435 generated IL code has been alright. But inside mcs this values was
14436 wrong and this was reason why several of my CLS Compliance tests
14439 2004-01-22 Martin Baulig <martin@ximian.com>
14441 * cs-parser.jay (namespace_or_type_name): Return an Expression,
14442 not a QualifiedIdentifier. This is what `type_name_expression'
14443 was previously doing.
14444 (type_name_expression): Removed; the code is now in
14445 `namespace_or_type_name'.
14446 (qualified_identifier): Removed, use `namespace_or_type_name'
14448 (QualifiedIdentifier): Removed this class.
14450 2004-01-22 Martin Baulig <martin@ximian.com>
14452 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
14453 not a string as alias name.
14455 2004-01-21 Miguel de Icaza <miguel@ximian.com>
14457 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
14458 #52730 bug, and instead compute correctly the need to use a
14459 temporary variable when requesting an address based on the
14460 static/instace modified of the field and the constructor.
14462 2004-01-21 Martin Baulig <martin@ximian.com>
14464 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
14465 class and namespace before looking up aliases. Fixes #52517.
14467 2004-01-21 Martin Baulig <martin@ximian.com>
14469 * flowanalysis.cs (UsageVector.Merge): Allow variables being
14470 assinged in a 'try'; fixes exception4.cs.
14472 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14473 * class.cs : Implemented parameter-less constructor for TypeContainer
14475 * decl.cs: Attributes are now stored here. New property OptAttributes
14477 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
14479 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
14481 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14483 * typemanager.cs (CSharpSignature): Now reports also inner class name.
14484 (CSharpSignature): New method for indexer and property signature.
14486 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14488 * pending.cs (IsVirtualFilter): Faster implementation.
14490 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14492 * typemanager.cs: Avoid inclusion of same assembly more than once.
14494 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14496 * cs-parser.jay: Fixed problem where the last assembly attribute
14497 has been applied also to following declaration (class, struct, etc.)
14499 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14501 * class.cs: Added error CS0538, CS0539 reporting.
14502 Fixed crash on Microsoft runtime when field type is void.
14504 * cs-parser.jay: Added error CS0537 reporting.
14506 * pending.cs: Added error CS0535 reporting.
14507 Improved error report for errors CS0536, CS0534.
14509 2004-01-20 Miguel de Icaza <miguel@ximian.com>
14511 Merge a few bits from the Anonymous Method MCS tree.
14513 * statement.cs (ToplevelBlock): New class for toplevel methods,
14514 will hold anonymous methods, lifted variables.
14516 * cs-parser.jay: Create toplevel blocks for delegates and for
14517 regular blocks of code.
14519 2004-01-20 Martin Baulig <martin@ximian.com>
14521 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
14522 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
14523 and `NeedExplicitReturn'; added `IsLastStatement'.
14524 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
14525 have a `ReturnLabel' or we're not unreachable.
14527 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
14528 child's reachability; don't just override ours with it. Fixes
14529 #58058 (lluis's example).
14530 (FlowBranching): Added public InTryOrCatch(), InCatch(),
14531 InFinally(), InLoop(), InSwitch() and
14532 BreakCrossesTryCatchBoundary() methods.
14534 * statement.cs (Return): Do all error checking in Resolve().
14535 Unless we are the last statement in a top-level block, always
14536 create a return label and jump to it.
14537 (Break, Continue): Do all error checking in Resolve(); also make
14538 sure we aren't leaving a `finally'.
14539 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
14540 statement in a top-level block.
14541 (Block.Flags): Added `IsDestructor'.
14542 (Block.IsDestructor): New public property.
14544 2004-01-20 Martin Baulig <martin@ximian.com>
14546 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
14548 2004-01-20 Martin Baulig <martin@ximian.com>
14550 * statement.cs (Statement.ResolveUnreachable): New public method.
14551 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
14552 (Block.Resolve): Resolve unreachable statements.
14554 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14556 * expression.cs: We need to fix the case where we do
14557 not have a temp variable here.
14559 * assign.cs: Only expression compound assignments need
14560 temporary variables.
14562 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14564 * flowanalysis.cs: Reduce memory allocation in a few ways:
14565 - A block with no variables should not allocate a bit
14567 - A method with no out parameters does not need any tracking
14568 for assignment of the parameters, so we need not allocate
14571 public readonly Type[] VariableTypes;
14572 public readonly string[] VariableNames;
14573 Are redundant. The data is already stored in the variable
14574 map, so we need not allocate another array for it.
14575 - We need to add alot of checks for if (params | locals) == null
14576 due to the first two changes.
14578 2004-01-18 Miguel de Icaza <miguel@ximian.com>
14580 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
14581 implement IMemoryLocation, we store a copy on a local variable and
14582 take the address of it. Patch from Benjamin Jemlich
14584 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
14585 to use a special "type_name_expression" rule which reduces the
14586 number of "QualifiedIdentifier" classes created, and instead
14587 directly creates MemberAccess expressions.
14589 2004-01-17 Miguel de Icaza <miguel@ximian.com>
14591 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
14592 that fixes #52853. Null literal assignment to ValueType
14594 * class.cs (MethodData.Emit): Instead of checking the name of the
14595 method to determine if its a destructor, create a new derived
14596 class from Method called Destructor, and test for that.
14598 * cs-parser.jay: Create a Destructor object instead of a Method.
14600 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
14604 2004-01-16 Miguel de Icaza <miguel@ximian.com>
14606 * expression.cs (Binary.ResolveOperator): Perform an implicit
14607 conversion from MethodGroups to their delegate types on the
14608 Addition operation.
14610 * delegate.cs: Introduce a new class DelegateCreation that is the
14611 base class for `NewDelegate' and `ImplicitDelegateCreation',
14612 factor some code in here.
14614 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
14615 conversion from MethodGroups to compatible delegate types.
14617 * ecore.cs (Expression.Resolve): Do not flag error 654
14618 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
14619 we allow conversions from MethodGroups to delegate types now.
14621 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
14622 assignments in v2 either.
14624 2004-01-10 Miguel de Icaza <miguel@ximian.com>
14626 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
14627 static read-only fields in ctors.
14629 Applied patch from Benjamin Jemlich
14631 * expression.cs (UnaryMutator): Avoid leaking local variables.
14633 2004-01-09 Miguel de Icaza <miguel@ximian.com>
14635 * cs-tokenizer.cs (IsCastToken): Allow the various native types
14636 here to return true, as they can be used like this:
14638 (XXX) int.MEMBER ()
14640 Fixed 49836 and all the other dups
14642 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
14644 * driver.cs: Implement /win32res and /win32icon.
14646 2004-01-08 Miguel de Icaza <miguel@ximian.com>
14648 * cs-parser.jay: Add a rule to improve error handling for the
14649 common mistake of placing modifiers after the type.
14651 2004-01-07 Miguel de Icaza <miguel@ximian.com>
14653 * cs-parser.jay (interface_event_declaration): Catch
14654 initialization of events on interfaces, and report cs0068
14656 * cs-parser.jay (interface_event_declaration): Catch
14657 initialization of events.
14659 * ecore.cs: Better report missing constructors.
14661 * expression.cs (Binary.ResolveOperator): My previous bug fix had
14662 the error reporting done in the wrong place. Fix.
14664 * expression.cs (Binary.ResolveOperator): Catch the
14665 operator + (E x, E y) error earlier, and later allow for implicit
14666 conversions in operator +/- (E e, U x) from U to the underlying
14669 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
14670 52596, if the container class is abstract, the default constructor
14671 is protected otherwise its public (before, we were always public).
14673 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
14676 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
14677 Jemlich that fixes bug #52597, MCS was generating invalid code for
14678 idisposable structs. Thanks to Ben for following up with this
14681 2004-01-06 Miguel de Icaza <miguel@ximian.com>
14683 * driver.cs: Allow assemblies without code to be generated, fixes
14686 2004-01-07 Nick Drochak <ndrochak@gol.com>
14688 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
14690 2004-01-05 Miguel de Icaza <miguel@ximian.com>
14692 * cs-parser.jay: Add rules to improve error reporting if fields or
14693 methods are declared at the namespace level (error 116)
14695 * Add rules to catch event add/remove
14697 2004-01-04 David Sheldon <dave-mono@earth.li>
14699 * expression.cs: Added matching ")" to error message for
14702 2004-01-03 Todd Berman <tberman@gentoo.org>
14704 * ecore.cs, attribute.cs:
14705 Applying fix from #52429.
14707 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14709 * ecore.cs, expression.cs, statement.cs:
14710 Total rewrite of how we handle branching. We
14711 now handle complex boolean expressions with fewer
14712 jumps. As well if (x == 0) no longer emits a ceq.
14714 if (x is Foo) is much faster now, because we generate
14717 Overall, we get a pretty big improvement on our benchmark
14718 tests. The code we generate is smaller and more readable.
14720 I did a full two-stage bootstrap. The patch was reviewed
14721 by Martin and Miguel.
14723 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14725 * cs-parser.jay: Make primary_expression not take a QI.
14726 we dont need this because the member_access rule covers
14727 us here. So we replace the rule with just IDENTIFIER.
14729 This has two good effects. First, we remove a s/r conflict.
14730 Second, we allocate many fewer QualifiedIdentifier objects.
14732 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14734 * attribute.cs: Handle MarshalAs attributes as pseudo, and
14735 set the correct information via SRE. This prevents
14736 hanging on the MS runtime. Fixes #29374.
14738 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14740 * convert.cs: correctly handle conversions to value types
14741 from Enum and ValueType as unboxing conversions.
14743 Fixes bug #52569. Patch by Benjamin Jemlich.
14745 2004-01-02 Ravi Pratap <ravi@ximian.com>
14747 * expression.cs (BetterConversion): Prefer int -> uint
14748 over int -> ulong (csc's behaviour). This fixed bug #52046.
14750 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
14752 * decl.cs (MemberCache.FindMembers): now returns a
14755 * typemanager.cs: In general, go with with ^^.
14756 (CopyNewMethods): take an IList.
14757 (RealMemberLookup): Only allocate an arraylist
14758 if we copy from two sets of methods.
14760 This change basically does two things:
14761 1) Fewer array lists allocated due to CopyNewMethods.
14762 2) the explicit cast in MemberList costed ALOT.
14764 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
14766 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
14767 a hashtable to avoid needless string allocations when an identifier is
14768 used more than once (the common case).
14770 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14772 * pending.cs: MS's TypeBuilder.GetInterfaces ()
14773 is broken, it will not return anything. So, we
14774 have to use the information we have in mcs to
14777 * typemanager.cs: Add a cache for GetInterfaces,
14778 since this will now be used more often (due to ^^)
14780 (GetExplicitInterfaces) New method that gets the
14781 declared, not effective, interfaces on a type
14782 builder (eg, if you have interface IFoo, interface
14783 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
14786 This patch makes MCS able to bootstrap itself on
14789 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14791 * expression.cs: Remove the Nop's that Miguel put
14794 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14796 * report.cs, codegen.cs: Give the real stack trace to
14797 the error when an exception is thrown.
14799 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14801 * decl.cs: only allocate hashtables for ifaces if
14804 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14806 * expression.cs: fix the error from cs0121-2.cs
14807 (a parent interface has two child interfaces that
14808 have a function with the same name and 0 params
14809 and the function is called through the parent).
14811 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
14813 * class.cs, rootcontext.cs, typmanager.cs: do not
14816 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
14818 * codegen.cs: remove stack for the ec flow branching.
14819 It is already a linked list, so no need.
14821 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
14823 * Makefile: Allow custom profiler here.
14825 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14827 * typemanager.cs (LookupType):
14828 - Use a static char [], because split takes
14829 a param array for args, so it was allocating
14831 - Do not store true in a hashtable, it boxes.
14833 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14835 * flowanalysis.cs: bytify common enums.
14837 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14839 * modifiers.cs: Add a new set of flags for the
14840 flags allowed on explicit interface impls.
14841 * cs-parser.jay: catch the use of modifiers in
14842 interfaces correctly.
14843 * class.cs: catch private void IFoo.Blah ().
14845 All related to bug #50572.
14847 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14849 * decl.cs: Rewrite the consistant accessability checking.
14850 Accessability is not linear, it must be implemented in
14851 a tableish way. Fixes #49704.
14853 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14855 * expression.cs: Handle negation in a checked context.
14856 We must use subtraction from zero. Fixes #38674.
14858 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14860 * class.cs: Ignore static void main in DLLs.
14861 * rootcontext.cs: Handle the target type here,
14862 since we are have to access it from class.cs
14863 * driver.cs: account for the above.
14865 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14867 * report.cs: Give line numbers and files if available.
14869 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
14871 * driver.cs: Implement /addmodule.
14873 * typemanager.cs: Change 'modules' field so it now contains Modules not
14876 2003-12-20 Martin Baulig <martin@ximian.com>
14878 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
14879 (FieldBase.IsAssigned): Removed this field.
14880 (FieldBase.SetAssigned): New public method.
14881 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
14883 2003-12-20 Martin Baulig <martin@ximian.com>
14885 * expression.cs (LocalVariableReference.DoResolve): Don't set
14886 `vi.Used' if we're called from DoResolveLValue().
14888 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
14889 returns the usage vector it just merged into the current one -
14890 pass this one to UsageWarning().
14891 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
14892 of the `EmitContext', don't call this recursively on our children.
14894 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
14896 * driver.cs: Implement /target:module.
14898 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
14900 * support.cs (CharArrayHashtable): New helper class.
14902 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
14903 char arrays, not strings, so we can avoid creating a string in
14904 consume_identifier if the identifier is a keyword.
14906 2003-12-16 Martin Baulig <martin@ximian.com>
14908 * statement.cs (LocalInfo.Assigned): Removed this property.
14909 (LocalInfo.Flags): Removed `Assigned'.
14910 (LocalInfo.IsAssigned): New public method; takes the EmitContext
14911 and uses flow analysis.
14912 (Block.UsageWarning): Made this method private.
14913 (Block.Resolve): Call UsageWarning() if appropriate.
14915 * expression.cs (LocalVariableReference.DoResolve): Always set
14916 LocalInfo.Used here.
14918 2003-12-13 Martin Baulig <martin@ximian.com>
14920 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
14921 any value here; we're now using flow analysis to figure out
14922 whether a statement/block returns a value.
14924 2003-12-13 Martin Baulig <martin@ximian.com>
14926 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
14928 (FlowBranching.MergeFinally): Don't call
14929 `branching.CheckOutParameters()' here, this is called in
14931 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
14932 when adding the `finally' vector.
14934 2003-12-13 Martin Baulig <martin@ximian.com>
14937 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
14938 actually work and also fix #48962.
14940 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
14942 * decl.cs: Do not check System.Object for nested types,
14943 since we know it does not have any. Big bang for buck:
14946 Run 1: 8.35 seconds
14947 Run 2: 8.32 seconds
14948 corlib: 17.99 seconds
14950 Run 1: 8.17 seconds
14951 Run 2: 8.17 seconds
14952 corlib: 17.39 seconds
14954 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
14956 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
14957 time we are returning 0 members, so we save alot here.
14959 2003-12-11 Martin Baulig <martin@ximian.com>
14961 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
14962 `MergeChild()', also just take the `FlowBranching' as argument;
14963 call Merge() on it and return the result.
14964 (FlowBranching.Merge): We don't need to do anything if we just
14967 2003-12-11 Martin Baulig <martin@ximian.com>
14969 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
14970 them in an `ArrayList' to reduce memory usage. Thanks to Ben
14971 Maurer for this idea.
14973 2003-12-11 Martin Baulig <martin@ximian.com>
14975 * flowanalysis.cs (MergeResult): This class is now gone; we now
14976 use the `UsageVector' for this. The reason for this is that if a
14977 branching just has one sibling, we don't need to "merge" them at
14978 all - that's the next step to do.
14979 (FlowBranching.Merge): We now return a `UsageVector' instead of a
14982 2003-12-11 Martin Baulig <martin@ximian.com>
14984 Reworked flow analyis and made it more precise and bug-free. The
14985 most important change is that we're now using a special `Reachability'
14986 class instead of having "magic" meanings of `FlowReturns'. I'll
14987 do some more cleanups and optimizations and also add some more
14988 documentation this week.
14990 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
14991 largely reworked this class.
14992 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
14993 the new `Reachability' class instead of having "magic" values here.
14994 (FlowBranching): We're now using an instance of `Reachability'
14995 instead of having separate `Returns', `Breaks' etc. fields.
14997 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
14998 based on flow analysis; ignore the return value of block.Emit ().
15000 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
15002 * driver.cs typemanager.cs: Find the mono extensions to corlib even
15003 if they are private.
15005 2003-12-09 Martin Baulig <martin@ximian.com>
15007 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
15008 call them directly on the UsageVector.
15010 2003-12-09 Martin Baulig <martin@ximian.com>
15012 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
15013 Changed return type from `FlowReturns' to `Reachability'.
15015 2003-12-09 Martin Baulig <martin@ximian.com>
15017 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
15018 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
15019 `Reachable' fields with a single `Reachability' one.
15021 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15023 * class.cs (FindMembers): Remove foreach's.
15028 Run 1: 8.74 seconds
15029 Run 2: 8.71 seconds
15032 Run 1: 8.64 seconds
15033 Run 2: 8.58 seconds
15036 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15041 This patch does a few things:
15042 1. EmptyStatement is now a singleton, so it is never reallocated.
15043 2. All blah is EmptyStatement constructs have been changed to
15044 blah == EmptyStatement.Value, which is much faster and valid
15045 now that EmptyStatement is a singleton.
15046 3. When resolving a block, rather than allocating a new array for
15047 the non-empty statements, empty statements are replaced with
15048 EmptyStatement.Value
15049 4. Some recursive functions have been made non-recursive.
15050 Mainly the performance impact is from (3), however (1) and (2) are needed for
15051 this to work. (4) does not make a big difference in normal situations, however
15052 it makes the profile look saner.
15057 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15058 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15059 Total memory allocated: 56397 KB
15062 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
15063 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
15064 Total memory allocated: 55666 KB
15066 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15068 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15069 than the hashtable in a hashtable version
15071 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
15072 we always end up concating a string. This results in a huge perf
15073 loss, because many strings have to be tracked by the GC. In this
15074 patch, we first use a hashtable that works with two keys, so that
15075 the strings do not need to be concat'ed.
15079 Run 1: 8.74 seconds
15080 Run 2: 8.71 seconds
15083 Run 1: 8.65 seconds
15084 Run 2: 8.56 seconds
15086 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15088 * Makefile: Add a new target `do-time' that does a quick and simple
15089 profile, leaving easy to parse output.
15091 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
15093 * codegen.cs (Init): Create the dynamic assembly with
15094 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
15096 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
15098 * support.cs: Make the PtrHashtable use only one
15099 instance of its comparer.
15101 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
15103 * typemanager.cs: Fix lookup of GetNamespaces.
15105 2003-11-29 Miguel de Icaza <miguel@ximian.com>
15107 * expression.cs: Removed redundant line.
15109 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
15110 ArrayLists, use for loops with bounds.
15112 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
15115 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
15116 arraylists, use for loop with bounds.
15118 The above three changes give us a 0.071 second performance
15119 improvement out of 3.294 seconds down to 3.223. On my machine
15120 the above changes reduced the memory usage by 1,387 KB during
15121 compiler bootstrap.
15123 * cs-parser.jay (QualifiedIdentifier): New class used to represent
15124 QualifiedIdentifiers. Before we created a new string through
15125 concatenation, and mostly later on, the result would be
15126 manipulated by DecomposeQI through string manipulation.
15128 This reduced the compiler memory usage for bootstrapping from
15129 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
15130 compile times in 0.05 seconds.
15132 2003-11-28 Dick Porter <dick@ximian.com>
15134 * support.cs: Do string compares with the Invariant culture.
15142 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
15143 the comparison is done with the Invariant culture.
15145 2003-11-27 Miguel de Icaza <miguel@ximian.com>
15147 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
15148 GetEnumerator method.
15150 (ProbeCollectionType): Iterate starting at the most specific type
15151 upwards looking for a GetEnumerator
15153 * expression.cs: Shift count can be up to 31 for int/uint and 63
15156 2003-11-26 Miguel de Icaza <miguel@ximian.com>
15158 * statement.cs (Block.LookupLabel): Also look for the label on the
15159 children blocks. Use a hash table to keep track of visited
15162 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
15163 we actually did transform the other operand, otherwise fall back
15164 to the common codepath that casts to long.
15166 * cs-tokenizer.cs: Use the same code pattern as the int case.
15167 Maybe I should do the parsing myself, and avoid depending on the
15168 Parse routines to get this done.
15170 2003-11-25 Miguel de Icaza <miguel@ximian.com>
15172 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15173 which fixes bug 51347. This time test it.
15175 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
15176 attributes for example can not tell the difference between these.
15177 The difference was only a syntax feature of the language.
15179 * attribute.cs: Apply attributes to delegates.
15181 * delegate.cs: Call the apply attributes method.
15183 2003-11-24 Miguel de Icaza <miguel@ximian.com>
15185 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
15186 comparing 0 vs Byte.MinValue, not the value
15188 (ImplicitConversionRequired): When reporting a conversion error,
15189 use error 31 to print out the constant error instead of the
15192 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15193 which fixes bug 51347.
15195 2003-11-22 Miguel de Icaza <miguel@ximian.com>
15197 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
15198 which fixes the -warnaserror command line option.
15200 2003-11-21 Miguel de Icaza <miguel@ximian.com>
15202 * cfold.cs (DoNumericPromotions): During constant folding of
15203 additions on UIntConstant, special case intconstants with
15204 IntConstants like we do on the expression binary operator.
15206 2003-11-12 Miguel de Icaza <miguel@ximian.com>
15208 * convert.cs (ImplicitReferenceConversion): We were missing a case
15209 (System.Enum are not value types or class types, so we need to
15210 classify them separatedly).
15212 * driver.cs: We do not support error 2007.
15214 2003-11-12 Jackson Harper <jackson@ximian.com>
15216 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
15217 system directory. Also use the full file name so users can
15218 libraries names mscorlib-o-tron.dll in a non system dir.
15220 2003-11-10 Martin Baulig <martin@ximian.com>
15222 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
15223 (TypeManager.InitCoreTypes): Initialize them here, but instead of
15224 calling `ResolveType()' on them, directly assign their `Type'.
15226 2003-11-08 Martin Baulig <martin@ximian.com>
15228 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
15229 return value and the `out parent' parameter.
15230 (TypeContainer.DefineType): Moved the CS0644 check into
15231 GetClassBases(). Don't pass the interface types to the
15232 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
15233 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
15235 * ecore.cs (TypeExpr.IsAttribute): New property.
15236 (TypeExpr.GetInterfaces): New method.
15238 * interface.cs (Interface.GetInterfaceTypeByName): Return a
15239 TypeExpr instead of a Type.
15240 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
15241 (Interface.DefineType): Don't pass the interface types to the
15242 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
15243 them later and then call `TypeBulider.AddInterfaceImplementation()'.
15245 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
15246 instead of a `Type[]'.
15247 (TypeManager.RegisterBuilder): Likewise.
15248 (TypeManager.AddUserInterface): Likewise.
15249 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
15250 `Type[]' and also return a `TypeExpr[]'.
15251 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
15253 2003-11-08 Martin Baulig <martin@ximian.com>
15255 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
15258 2003-11-08 Martin Baulig <martin@ximian.com>
15260 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
15261 TypeManager.ResolveExpressionTypes().
15263 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
15264 instead of an Expression.
15265 (TypeExpr): This is now an abstract base class for `TypeExpression'.
15266 (TypeExpression): New public class; formerly known as `TypeExpr'.
15268 * expression.cs (ComposedCast): Derive from TypeExpr.
15270 * typemanager.cs (TypeManager.system_*_expr): These are now
15271 TypExpr's instead of Expression's.
15272 (TypeManager.ResolveExpressionTypes): New public static function;
15273 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
15276 2003-11-06 Miguel de Icaza <miguel@ximian.com>
15278 * expression.cs (New.DoResolve): Do not dereference value that
15279 might be a null return.
15281 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
15282 sure that the constant value has the right type. Fixes an
15283 unreported bug, similar to 50425.
15285 * const.cs (Const.LookupConstantValue): Call
15286 ImplicitStandardConversionExists before doing a conversion to
15287 avoid havng the TypeManager.ChangeType do conversions.
15289 Reduced the number of casts used
15291 (Const.ChangeType): New routine to enable reuse of the constant
15292 type changing code from statement.
15294 * typemanager.cs (ChangeType): Move common initialization to
15295 static global variables.
15299 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
15300 every value type to go through, even if it was void. Fix that.
15302 * cs-tokenizer.cs: Use is_identifier_start_character on the start
15303 character of the define, and the is_identifier_part_character for
15304 the rest of the string.
15306 2003-11-05 Miguel de Icaza <miguel@ximian.com>
15308 * expression.cs (UnaryMutator.EmitCode): When I updated
15309 LocalVariableReference.DoResolve, I overdid it, and dropped an
15310 optimization done on local variable references.
15312 2003-11-04 Miguel de Icaza <miguel@ximian.com>
15314 * ecore.cs: Convert the return from Ldlen into an int.
15316 2003-10-20 Miguel de Icaza <miguel@ximian.com>
15318 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
15319 the accessibility, this is a special case for toplevel non-public
15320 classes (internal for instance).
15322 2003-10-20 Nick Drochak <ndrochak@gol.com>
15324 * ecore.cs: Fix typo and build. Needed another right paren.
15326 2003-10-19 Miguel de Icaza <miguel@ximian.com>
15328 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
15329 `internal' case regular and protected, but not allowing protected
15330 to be evaluated later. Bug 49840
15332 2003-10-15 Miguel de Icaza <miguel@ximian.com>
15334 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
15335 to kb.Nlast, and not the kb.nFirst to isolate the switch
15338 Extract the underlying type, so enumerations of long/ulong are
15339 treated like long/ulong.
15341 2003-10-14 Miguel de Icaza <miguel@ximian.com>
15343 * expression.cs (New): Overload the meaning of RequestedType to
15344 track the possible creation of the NewDelegate type, since
15345 DoResolve is invoked more than once for new constructors on field
15348 See bugs: #48800 and #37014
15350 * cs-parser.jay (declare_local_constants): Take an arraylist
15351 instead of a single constant.
15353 (local_constant_declaration): It should take a
15354 constant_declarators, not a constant_declarator. Fixes 49487
15356 * convert.cs: Fix error report.
15358 2003-10-13 Jackson Harper <jackson@ximian.com>
15360 * typemanager.cs (TypeToCoreType): Add float and double this fixes
15363 2003-10-09 Martin Baulig <martin@ximian.com>
15365 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
15367 (MethodCore.DoDefineParameters): Removed the TypeContainer
15368 argument; use the DeclSpace which was passed to the .ctor instead.
15369 (MethodCore.CheckParameter): Take a DeclSpace instead of a
15370 TypeContainer; we only need a DeclSpace here.
15372 2003-10-09 Martin Baulig <martin@ximian.com>
15374 * class.cs (MethodData): Added additional `DeclSpace ds' argument
15376 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
15377 EmitContext's .ctor.
15379 2003-10-09 Martin Baulig <martin@ximian.com>
15381 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
15382 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
15383 AsAccessible(), moved them as well.
15385 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
15387 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
15389 * cs-parser.jay : Renamed yyName to yyNames related to jay.
15391 2003-10-07 Miguel de Icaza <miguel@ximian.com>
15393 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
15394 generation for >=, as spotted by Paolo, bug 48679.
15395 Patch from David Waite.
15397 * cs-tokenizer.cs: Add handling for #pragma.
15399 * cs-parser.jay: Allow for both yield and yield return in the
15400 syntax. The anti-cobolization of C# fight will go on!
15402 * class.cs (TypeBuilder.DefineType): Catch error condition here
15403 (Parent.DefineType erroring out and returning null).
15405 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15406 coping with enumerations variables, we were mistakenly processing
15407 them as a regular value type instead of built-in types. Fixes the
15410 * typemanager.cs (IsBuiltinOrEnum): New method.
15412 2003-09-30 Miguel de Icaza <miguel@ximian.com>
15414 * cs-parser.jay: Upgrade: yield now needs the return clause.
15416 2003-09-19 Martin Baulig <martin@ximian.com>
15418 * decl.cs (MemberCache.SetupCacheForInterface): Take a
15419 `MemberCache parent' argument. Normally, an interface doesn't
15420 have a parent type except System.Object, but we use this in gmcs
15421 for generic type parameters.
15423 2003-09-18 Martin Baulig <martin@ximian.com>
15425 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
15426 on `type.IsInterface'; don't check whether the type has a parent
15427 to determine whether it's an interface.
15429 2003-09-15 Martin Baulig <martin@ximian.com>
15431 * class.cs (TypeContainer.DefineType): Added an error flag to
15432 avoid reporting duplicate CS0146's ("class definition is
15435 * driver.cs (Driver.MainDriver): Abort if
15436 RootContext.ResolveTree() reported any errors.
15438 2003-09-07 Martin Baulig <martin@ximian.com>
15440 * report.cs (Error, Warning): Added overloaded versions which take
15441 a `params object[] args' and call String.Format().
15443 2003-09-07 Martin Baulig <martin@ximian.com>
15445 * decl.cs (DeclSpace..ctor): Don't call
15446 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
15447 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
15448 (DeclSpace.RecordDecl): New method.
15450 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
15452 2003-09-02 Ravi Pratap <ravi@ximian.com>
15454 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
15455 value attributes to be applied to ParameterBuilders.
15457 * class.cs (MethodCore.LabelParameters): Make static and more
15458 generic so that it can be used from other places - like interface
15459 methods, for instance.
15461 * interface.cs (Interface.Emit): Call LabelParameters before
15462 emitting attributes on the InterfaceMethod.
15464 2003-08-26 Martin Baulig <martin@ximian.com>
15466 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
15467 resolving aliases; fixes #47927.
15469 2003-08-26 Martin Baulig <martin@ximian.com>
15471 * statement.cs (Using.DoResolve): This is internally emitting a
15472 try/finally clause, so we need to set ec.NeedExplicitReturn if we
15473 do not always return. Fixes #47681.
15475 2003-08-26 Martin Baulig <martin@ximian.com>
15477 * decl.cs (MemberCore): Moved WarningNotHiding(),
15478 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
15480 (AdditionResult): Make this nested in DeclSpace.
15481 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
15482 argument; call NamespaceEntry.Define() unless we're nested in a
15485 * namespace.cs (Namespace.DefineName): New public function. This
15486 is called from DeclSpace's .ctor to add
15487 (Namespace.Lookup): Include DeclSpaces in the lookup.
15489 * class.cs (Operator): Derive from MemberBase, not MemberCore.
15491 * const.cs (Const): Derive from MemberBase, not MemberCore.
15493 2003-08-25 Martin Baulig <martin@ximian.com>
15495 * convert.cs (Convert.ExplicitReferenceConversion): When
15496 converting from an interface type to a class, unbox if the target
15497 type is a struct type. Fixes #47822.
15499 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15501 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
15504 2003-08-22 Martin Baulig <martin@ximian.com>
15506 * class.cs (TypeManager.DefineType): When defining a nested type,
15507 call DefineType() on our parent; fixes #47801.
15509 2003-08-22 Martin Baulig <martin@ximian.com>
15511 * class.cs (MethodData.Define): While checking if a method is an
15512 interface implementation, improve the test a bit more to fix #47654.
15514 2003-08-22 Martin Baulig <martin@ximian.com>
15516 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
15517 correctly; fixes #47722.
15519 2003-08-22 Martin Baulig <martin@ximian.com>
15521 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
15522 LocalVariableReference, ensure it's not read-only. Fixes #47536.
15524 * statement.cs (Fixed.DoResolve): Make all variables read-only.
15526 2003-08-22 Martin Baulig <martin@ximian.com>
15528 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
15529 can only be assigned in static constructors. Fixes #47161.
15531 2003-08-22 Martin Baulig <martin@ximian.com>
15533 Rewrote and improved the flow analysis code.
15535 * flowbranching.cs (FlowBranching): Make this class abstract.
15536 (FlowBranching.CreateBranching): New static function to create a
15537 new flow branching.
15538 (FlowBranchingBlock, FlowBranchingException): New classes.
15539 (FlowBranching.UsageVector.Type): New public readonly field.
15540 (FlowBranching.UsageVector.Breaks): Removed the setter.
15541 (FlowBranching.UsageVector.Returns): Removed the setter.
15542 (FlowBranching.UsageVector): Added Break(), Return(),
15543 NeverReachable() and Throw() methods to modify the reachability.
15544 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
15545 done by FlowBranching.Merge().
15546 (FlowBranching.UsageVector.MergeChild): New method; merges the
15547 merge result into the current vector.
15548 (FlowBranching.Merge): New abstract method to merge a branching.
15550 2003-08-12 Martin Baulig <martin@ximian.com>
15552 * expression.cs (Indirection.CacheTemporaries): Create the
15553 LocalTemporary with the pointer type, not its element type.
15555 2003-08-10 Miguel de Icaza <miguel@ximian.com>
15557 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
15558 token was a keyword or not.
15560 Add `error' options where an IDENTIFIER was expected; Provide
15561 CheckToken and CheckIdentifierToken convenience error reporting
15564 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
15566 * decl.cs: Rename `NamespaceEntry Namespace' public field into
15567 NameSpaceEntry NameSpaceEntry.
15569 (LookupInterfaceOrClass): Avoid creating a full qualified name
15570 from namespace and name: avoid doing lookups when we know the
15571 namespace is non-existant. Use new Tree.LookupByNamespace which
15572 looks up DeclSpaces based on their namespace, name pair.
15574 * driver.cs: Provide a new `parser verbose' to display the
15575 exception thrown during parsing. This is turned off by default
15576 now, so the output of a failure from mcs is more graceful.
15578 * namespace.cs: Track all the namespaces defined in a hashtable
15581 (IsNamespace): New method
15583 2003-08-09 Miguel de Icaza <miguel@ximian.com>
15585 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
15586 we know that we need to concatenate (full typename can never be
15591 * statement.cs: Use a bitfield; Do not initialize to null things
15592 which are done by the constructor by default.
15594 * cs-parser.jay: bug fix, parameter was 4, not 3.
15596 * expression.cs: Just use the property;
15598 * statement.cs: No need for GetVariableInfo method.
15600 2003-08-08 Martin Baulig <martin@ximian.com>
15602 * flowanalysis.cs (FlowReturns): This is now nested in the
15603 `FlowBranching' class.
15604 (MyBitVector): Moved this here from statement.cs.
15605 (FlowBranching.SiblingType): New enum type.
15606 (FlowBranching.CreateSibling): Added `SiblingType' argument.
15608 2003-08-07 Martin Baulig <martin@ximian.com>
15610 * flowanalysis.cs (FlowBranchingType): This is now nested in the
15611 `FlowBranching' class and called `BranchingType'.
15613 2003-08-07 Martin Baulig <martin@ximian.com>
15615 * flowanalysis.cs: Moved all the control flow analysis code into
15618 2003-08-07 Martin Baulig <martin@ximian.com>
15620 * assign.cs (Assign.DoResolve): `target' must either be an
15621 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
15624 2003-08-07 Miguel de Icaza <miguel@ximian.com>
15626 * expression.cs (BinaryMethod): This kind of expression is created by the
15627 Binary class if it determines that the operator has to be handled
15630 (BinaryDelegate): This kind of expression is created if we are
15631 dealing with a + or - operator on delegates.
15633 (Binary): remove method, argumetns, and DelegateOperator: when
15634 dealing with methods,
15636 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
15638 * statement.cs (Block): use bitfields for the three extra booleans
15639 we had in use. Remove unused topblock parameter.
15641 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
15643 * assign.cs: Drop extra unneeded tests.
15645 2003-08-06 Miguel de Icaza <miguel@ximian.com>
15647 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
15649 * statement.cs (Foreach): Use VariableStorage instead of
15652 * codegen.cs (VariableStorage): New class used by clients that
15653 require a variable stored: locals or fields for variables that
15654 need to live across yield.
15656 Maybe provide a convenience api for EmitThis+EmitLoad?
15658 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
15661 2003-08-05 Miguel de Icaza <miguel@ximian.com>
15663 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
15664 RemapParameterLValue): New methods that are used to turn a
15665 precomputed FieldInfo into an expression like this:
15669 The idea is to use this instead of making LocalVariableReference
15670 have more than one meaning.
15672 * cs-parser.jay: Add error production to BASE.
15674 * ecore.cs: Deal with TypeManager.GetField returning null, which
15675 is now a valid return value.
15677 (FieldExprNoAddress): New expression for Fields whose address can
15680 * expression.cs (LocalVariableReference): During the resolve
15681 phases, create new expressions if we are in a remapping context.
15682 Remove code that dealt with remapping here.
15684 (ParameterReference): same.
15686 (ProxyInstance): New expression, like the `This' expression, but
15687 it is born fully resolved. We know what we are doing, so remove
15688 the errors that are targeted to user-provided uses of `this'.
15690 * statement.cs (Foreach): our variable is now stored as an
15691 Expression; During resolution, follow the protocol, dont just
15692 assume it will return this.
15694 2003-08-06 Martin Baulig <martin@ximian.com>
15696 * support.cs (SeekableStreamReader.cs): New public class.
15698 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
15699 SeekableStreamReader instead of the normal StreamReader.
15701 2003-08-04 Martin Baulig <martin@ximian.com>
15703 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
15704 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
15705 deambiguate casts and delegate invocations.
15706 (parenthesized_expression): Use the new tokens to ensure this is
15707 not a cast of method invocation.
15709 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
15710 when reading a `)' and Deambiguate_CloseParens () was previously
15713 * expression.cs (ParenthesizedExpression): New class. This is
15714 just used for the CS0075 test.
15715 (Binary.DoResolve): Check for CS0075.
15717 2003-07-29 Ravi Pratap <ravi@ximian.com>
15719 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
15720 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
15721 reference comparison.
15723 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
15724 examine the ReturnType for equality - this is necessary in the
15725 cases of implicit and explicit operators whose signature also
15726 includes the return type.
15728 2003-07-26 Miguel de Icaza <miguel@ximian.com>
15730 * namespace.cs: Cache the result of the namespace computation,
15731 instead of computing it every time.
15733 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15735 * decl.cs: Use a global arraylist that we reuse over invocations
15736 to avoid excesive memory consumption. Reduces memory usage on an
15737 mcs compile by one meg (45 average).
15739 * typemanager.cs (LookupTypeReflection): In .NET pointers are
15740 private, work around that.
15742 2003-07-23 Miguel de Icaza <miguel@ximian.com>
15744 * literal.cs (IntLiteral): Define Zero and One static literals.
15746 * cs-parser.jay (integer_literal): use static literals to reduce
15747 memory usage for the most used literals (0, 1 and -1). 211kb
15748 reduced in memory usage.
15750 Replace all calls to `new ArrayList' with `new
15751 ArrayList(4)' which is a good average number for most allocations,
15752 and also requires only 16 bytes of memory for its buffer by
15755 This reduced MCS memory usage in seven megabytes for the RSS after
15758 2003-07-28 Ravi Pratap <ravi@ximian.com>
15760 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
15761 handle params methods the correct way by forming only one
15762 applicable set with params and normal methods in them. Earlier we
15763 were looking at params methods only if we found no normal methods
15764 which was not the correct thing to do.
15766 (Invocation.BetterFunction): Take separate arguments indicating
15767 when candidate and the best method are params methods in their
15770 This fixes bugs #43367 and #46199.
15772 * attribute.cs: Documentation updates.
15774 (CheckAttribute): Rename to CheckAttributeTarget.
15775 (GetValidPlaces): Rename to GetValidTargets.
15777 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
15778 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
15782 2003-07-28 Martin Baulig <martin@ximian.com>
15784 * class.cs (TypeContainer.DefineMembers): Use the base type's full
15785 name when looking up the base class of a nested class. Fixes #46977.
15787 2003-07-26 Martin Baulig <martin@ximian.com>
15789 * expression.cs (Indexers.Indexer): New nested struct; contains
15790 getter, setter and the indexer's type.
15791 (Indexers.Properties): This is now an ArrayList of
15792 Indexers.Indexer's.
15793 (IndexerAccess.DoResolveLValue): Correctly set the type if the
15794 indexer doesn't have any getters.
15796 * assign.cs (Assign.DoResolve): Also do the implicit conversions
15797 for embedded property and indexer assignments.
15799 2003-07-26 Martin Baulig <martin@ximian.com>
15801 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
15802 preprocessor directive is not the first non-whitespace character
15805 2003-07-26 Martin Baulig <martin@ximian.com>
15807 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
15808 namespace parsing, follow the spec more closely.
15810 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
15811 NamespaceEntry.Lookup().
15813 2003-07-25 Martin Baulig <martin@ximian.com>
15815 * MethodCore.cs (OverridesSomething): New public field; it's set
15816 from TypeContainer.DefineMembers if this method overrides
15817 something (which doesn't need to be a method). Fix #39462.
15819 2003-07-25 Ravi Pratap <ravi@ximian.com>
15821 * typemanager.cs (GetMembers): Ensure that the list of members is
15822 reversed. This keeps things in sync.
15824 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
15825 find an AttributeUsage attribute.
15827 * expression.cs (Invocation.OverloadResolve): Perform the check
15828 which disallows Invoke to be directly called on a Delegate.
15830 (Error_InvokeOnDelegate): Report error cs1533.
15832 2003-07-25 Martin Baulig <martin@ximian.com>
15834 * expression.cs (Indexers.GetIndexersForType): Only look in the
15835 interface hierarchy if the requested type is already an
15836 interface. Fixes #46788 while keeping #46502 fixed.
15838 2003-07-25 Martin Baulig <martin@ximian.com>
15840 * class.cs (TypeContainer.DefineMembers): Check whether all
15841 readonly fields have been assigned and report warning CS0649 if
15844 * statement.cs (LocalInfo.IsFixed): Always return true if this is
15847 2003-07-24 Ravi Pratap <ravi@ximian.com>
15849 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
15850 returned from GetMethods to make things consistent with the
15851 assumptions MCS makes about ordering of methods.
15853 This should comprehensively fix bug #45127 and it does :-)
15855 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
15856 ordering is actually reverse.
15858 * Clean up some debug messages I left lying around.
15860 * interface.cs (Populate*): Get rid of code which emits attributes
15861 since the stage in which we emit attributes is the 'Emit' stage,
15862 not the define stage.
15864 (Emit): Move attribute emission for interface members here.
15866 2003-07-22 Ravi Pratap <ravi@ximian.com>
15868 * expression.cs (Invocation.OverloadResolve): Follow the spec more
15869 closely: we eliminate methods in base types when we have an
15870 applicable method in a top-level type.
15872 Please see section 14.5.5.1 for an exact description of what goes
15875 This fixes bug #45127 and a host of other related to corlib compilation.
15877 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
15878 array is the method corresponding to the top-level type (this is
15879 because of the changes made to icall.c) so we change this
15882 (MethodGroupExpr.Name): This too.
15884 * typemanager.cs (GetElementType): New method which does the right
15885 thing when compiling corlib.
15887 * everywhere: Make use of the above in the relevant places.
15889 2003-07-22 Martin Baulig <martin@ximian.com>
15891 * cs-parser.jay (invocation_expression): Moved
15892 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
15893 `cast_expression', but create a InvocationOrCast which later
15894 resolves to either an Invocation or a Cast.
15896 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
15897 method; call this before EmitStatement() to make sure that this
15898 expression can be used as a statement.
15900 * expression.cs (InvocationOrCast): New class; resolves to either
15901 an Invocation or a Cast.
15903 * statement.cs (StatementExpression): Call ResolveStatement() on
15904 the ExpressionStatement before emitting it.
15906 2003-07-21 Martin Baulig <martin@ximian.com>
15908 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
15909 `ref' and `out' attributes match; fixes #46220.
15910 (MemberAccess.ResolveMemberAccess): You can't reference a type
15911 through an expression; fixes #33180.
15912 (Indexers.GetIndexersForType): Don't return the indexers from
15913 interfaces the class implements; fixes #46502.
15915 2003-07-21 Martin Baulig <martin@ximian.com>
15917 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15918 CS0661 checks; fixes bug #30442.
15920 2003-07-21 Martin Baulig <martin@ximian.com>
15922 * decl.cs (AdditionResult): Added `Error'.
15924 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15926 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
15927 makes cs0031.cs actually work.
15929 2003-07-20 Martin Baulig <martin@ximian.com>
15931 * namespace.cs: Fixed that bug which caused a crash when compiling
15932 the debugger's GUI.
15934 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15936 * typemanager.cs (LookupTypeReflection): Never expose types which
15937 are NotPublic, NestedPrivate, NestedAssembly, or
15938 NestedFamANDAssem. We used to return these, and later do a check
15939 that would report a meaningful error, but the problem is that we
15940 would not get the real match, if there was a name override.
15942 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15944 * namespace.cs (Namespace, Name): Do not compute the namespace
15945 name dynamically, compute it in the constructor. This reduced
15946 memory usage by 1697 KB.
15948 * driver.cs: Use --pause to pause at the end.
15950 2003-07-17 Peter Williams <peter@newton.cx>
15952 * Makefile: Change the name of the test target so that it doesn't
15953 conflict with the recursive test target.
15955 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15957 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15958 AddressOf): Do not use EmitThis, that was wrong, use the actual
15961 2003-07-15 Miguel de Icaza <miguel@ximian.com>
15963 * class.cs (MethodData.Define): While checking if a method is an
15964 interface implementation, improve the test: If we are not public
15965 (use new test here: use the computed MethodAttributes directly,
15966 instead of the parsed modifier flags) check if the `implementing'
15967 method comes from an interface or not.
15969 * pending.cs (VerifyPendingMethods): Slightly better error
15972 * makefile: add test target that does the mcs bootstrap.
15974 2003-07-16 Ravi Pratap <ravi@ximian.com>
15976 * interface.cs (Define): Do nothing here since there are no
15977 members to populate etc. Move the attribute emission out of here
15978 since this was just totally the wrong place to put it. Attribute
15979 application happens during the 'Emit' phase, not in the 'Define'
15982 (Emit): Add this method and move the attribute emission here
15984 * rootcontext.cs (EmitCode): Call the Emit method on interface
15987 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15989 * expression.cs (OverloadResolve): Report error only if Location
15990 is not 'Null' which means that there was a probe going on.
15992 2003-07-14 Martin Baulig <martin@ximian.com>
15994 * expression.cs (ConditionalLogicalOperator): New public class to
15995 implement user defined conditional logical operators.
15996 This is section 14.11.2 in the spec and bug #40505.
15998 2003-07-14 Martin Baulig <martin@ximian.com>
16000 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
16002 2003-07-14 Martin Baulig <martin@ximian.com>
16004 * codegen.cs (EmitContext.InFixedInitializer): New public field.
16006 * ecore.cs (IVariable.VerifyFixed): New interface method.
16008 * expression.cs (Unary.ResolveOperator): When resolving the `&'
16009 operator, check whether the variable is actually fixed. Fixes bug
16010 #36055. Set a variable definitely assigned when taking its
16011 address as required by the spec.
16013 * statement.cs (LocalInfo.IsFixed): New field.
16014 (LocalInfo.MakePinned): Set `IsFixed' to true.
16016 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16018 * attribute.cs (Attribute.Resolve): While doing a Member lookup
16019 for .ctors, ensure that we only ask for members declared in the
16020 attribute type (BindingFlags.DeclaredOnly).
16024 * expression.cs (Error_WrongNumArguments): Report error 1501
16025 correctly the way CSC does.
16027 2003-07-13 Martin Baulig <martin@ximian.com>
16029 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
16030 lookup on the fully qualified name, to make things like "X.X" work
16031 where "X.X" is a fully qualified type name, but we also have a
16032 namespace "X" in the using list. Fixes #41975.
16034 2003-07-13 Martin Baulig <martin@ximian.com>
16036 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
16037 function. If we're a CompoundAssign, we need to create an embedded
16038 CompoundAssign, not an embedded Assign.
16039 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
16042 2003-07-13 Martin Baulig <martin@ximian.com>
16044 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
16045 work to fix bug #46088.
16047 2003-07-13 Ravi Pratap <ravi@ximian.com>
16049 * class.cs (Operator.Emit): Do not emit attributes here - it is
16050 taken care of by the Method class that we delegate too. This takes
16051 care of bug #45876.
16053 2003-07-10 Martin Baulig <martin@ximian.com>
16055 * expression.cs (TypeOfVoid): New class.
16056 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
16058 2003-07-10 Martin Baulig <martin@ximian.com>
16060 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
16063 2003-07-10 Martin Baulig <martin@ximian.com>
16065 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
16066 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16068 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
16070 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
16072 2003-07-10 Martin Baulig <martin@ximian.com>
16074 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
16075 of decimal. Fixes #42850.
16077 NOTE: I also fixed the created byte blob, but this doesn't work on
16078 the MS runtime and csc never produces any byte blobs for decimal
16081 2003-07-10 Martin Baulig <martin@ximian.com>
16083 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
16084 structs; fixes #32068.
16085 (Block.AddChildVariableNames): Fixed #44302.
16087 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16089 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
16091 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16093 * attribute.cs: And this test is onger needed.
16095 2003-07-08 Martin Baulig <martin@ximian.com>
16097 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
16098 inaccessible types. Fixes #36313.
16100 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
16102 * namespace.cs (NamespaceEntry): Create implicit entries for all
16103 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
16104 implicit entries for N1.N2 and N1.
16106 2003-07-08 Martin Baulig <martin@ximian.com>
16108 Rewrote the handling of namespaces to fix a lot of the issues
16109 wrt. `using' aliases etc.
16111 * namespace.cs (Namespace): Splitted this class into a
16112 per-assembly `Namespace' and a per-file `NamespaceEntry'.
16114 * typemanager.cs (TypeManager.IsNamespace): Removed.
16115 (TypeManager.ComputeNamespaces): Only compute namespaces from
16116 loaded assemblies here, not the namespaces from the assembly we're
16117 currently compiling.
16119 2003-07-08 Martin Baulig <martin@ximian.com>
16121 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
16123 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16125 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
16128 I thought about the memory savings here, but LookupTypeReflection
16129 is used under already very constrained scenarios. Compiling
16130 corlib or mcs only exposes one hit, so it would not really reduce
16131 any memory consumption.
16133 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16135 * typemanager.cs: fixes bug #45889 by only adding public types from
16136 other assemblies to the list of known types.
16138 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16140 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
16141 on the type we resolved.
16143 2003-07-05 Martin Baulig <martin@ximian.com>
16145 * pending.cs (PendingImplementation.ParentImplements): Don't
16146 create the proxy if the parent is abstract.
16148 * class.cs (TypeContainer.DefineIndexers): Process explicit
16149 interface implementations first. Fixes #37714.
16151 2003-07-04 Miguel de Icaza <miguel@ximian.com>
16153 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
16154 defined recursively; but since we modify the input parameters
16155 (left is set to `this' temporarily), we reset this value if the
16156 left_is_explicit is false, which gives the original semantics to
16159 * literal.cs (NullPointer): new class used to represent a null
16160 literal in a pointer context.
16162 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
16163 type is a pointer, use a NullPointer object instead of a
16164 NullLiteral. Closes 43687
16166 (ExplicitConversion): Convert pointer values using
16167 the conv opcode to the proper type.
16169 * ecore.cs (New): change ValueTypeVariable property into a method,
16170 that returns whether the valuetype is suitable for being used.
16172 * expression.cs (Binary.DoNumericPromotions): Only return if we
16173 the int constant was a valid uint, and we can return both left and
16174 right as uints. If not, we continue processing, to trigger the
16175 type conversion. This fixes 39018.
16177 * statement.cs (Block.EmitMeta): During constant resolution, set
16178 the CurrentBlock property on the emitcontext, so that we resolve
16179 constants propertly.
16181 2003-07-02 Martin Baulig <martin@ximian.com>
16183 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
16184 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
16186 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
16187 than emitting it here.
16189 * statement.cs: Fixed some more flow analysis bugs.
16191 2003-07-02 Martin Baulig <martin@ximian.com>
16193 * class.cs (MethodData.Define): When implementing interface
16194 methods, set Final unless we're Virtual.
16196 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
16197 check work for interface methods.
16199 2003-07-01 Martin Baulig <martin@ximian.com>
16201 * ecore.cs (EmitContext.This): Replaced this property with a
16202 GetThis() method which takes a Location argument. This ensures
16203 that we get the correct error location for a CS0188.
16205 2003-07-01 Miguel de Icaza <miguel@ximian.com>
16207 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
16208 ImplicitStandardConversion.
16210 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
16212 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
16214 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
16217 2003-06-30 Miguel de Icaza <miguel@ximian.com>
16219 * class.cs (Constructor.Define): Turn off initlocals for unsafe
16222 (MethodData.Define): Turn off initlocals for unsafe methods.
16224 2003-06-29 Miguel de Icaza <miguel@ximian.com>
16226 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
16227 complete; Fixes #37521.
16229 * delegate.cs: Use Modifiers.TypeAttr to compute the
16230 TypeAttributes, instead of rolling our own. This makes the flags
16231 correct for the delegates.
16233 2003-06-28 Miguel de Icaza <miguel@ximian.com>
16235 * class.cs (Constructor.Define): Set the private flag for static
16236 constructors as well.
16238 * cs-parser.jay (statement_expression): Set the return value to
16239 null, to avoid a crash when we catch an error.
16241 2003-06-24 Miguel de Icaza <miguel@ximian.com>
16243 * cs-parser.jay: Applied patch from Jackson that adds support for
16244 extern and unsafe modifiers to destructor declarations.
16246 * expression.cs: Report error 21 if the user is trying to index a
16249 * driver.cs: Add an error message, suggested by the bug report.
16251 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
16252 if we do not have a ": this ()" constructor initializer. Fixes 45149
16254 2003-06-14 Miguel de Icaza <miguel@ximian.com>
16256 * namespace.cs: Add some information to reduce FAQs.
16258 2003-06-13 Miguel de Icaza <miguel@ximian.com>
16260 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
16261 underlying enumeration types. Fixes #43915.
16263 * expression.cs: Treat ushort/short as legal values to be used in
16264 bitwise operations.
16266 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
16268 * delegate.cs: transfer custom attributes for paramenters from
16269 the delegate declaration to Invoke and BeginInvoke.
16271 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
16273 * attribute.cs: handle custom marshalers and emit marshal info
16276 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
16278 * makefile.gnu: Added anonymous.cs to the compiler sources.
16280 2003-05-28 Miguel de Icaza <miguel@ximian.com>
16282 * iterators.cs: Change the name of the proxy class to include two
16285 * cs-parser.jay: Update grammar to include anonymous methods.
16287 * anonymous.cs: new file.
16289 2003-05-27 Miguel de Icaza <miguel@ximian.com>
16291 * class.cs (Field.Define): Add missing test for pointers and
16294 2003-05-27 Ravi Pratap <ravi@ximian.com>
16296 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
16297 we use the stobj opcode.
16299 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
16300 since it wasn't the correct fix.
16302 It still is puzzling that we are required to use stobj for IntPtr
16303 which seems to be a ValueType.
16305 2003-05-26 Miguel de Icaza <miguel@ximian.com>
16307 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
16308 during regular simple name resolution. Now, the trick is that
16309 instead of returning for processing the simplename, we do a
16310 TypeManager.LookupType (ie, a rooted lookup as opposed to a
16311 contextual lookup type). If a match is found, return that, if
16312 not, return for further composition.
16314 This fixes long-standing 30485.
16316 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16317 using the address to initialize an object, do an Stobj instead of
16318 using the regular Stelem.
16320 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
16321 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
16322 Because if we are a BaseIndexerAccess that value will be true.
16325 * statement.cs (GotoCase.Resolve): Return after reporting an
16326 error, do not attempt to continue.
16328 * expression.cs (PointerArithmetic.Emit): If our operand is a
16329 long, convert our constants to match the operand before
16330 multiplying. Convert to I type before adding. Fixes 43670.
16332 2003-05-14 Ravi Pratap <ravi@ximian.com>
16334 * enum.cs (ImplicitConversionExists) : Rename to
16335 ImplicitEnumConversionExists to remove ambiguity.
16337 * ecore.cs (NullCast): New type of cast expression class which
16338 basically is very similar to EmptyCast with the difference being
16339 it still is a constant since it is used only to cast a null to
16341 (eg. (string) null)
16343 * convert.cs (ImplicitReferenceConversion): When casting a null
16344 literal, we return a NullCast.
16346 * literal.cs (NullLiteralTyped): Remove - I don't see why this
16347 should be around anymore.
16349 The renaming (reported was slightly wrong). Corrections:
16351 ConvertImplicitStandard -> ImplicitConversionStandard
16352 ConvertExplicitStandard -> ExplicitConversionStandard
16354 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
16355 before passing them in !
16357 * convert.cs (ImplicitConversionStandard): When comparing for
16358 equal expr and target types, ensure that expr is not a
16361 In general, we must not be checking (expr_type ==
16362 target_type) in the top level conversion methods
16363 (ImplicitConversion, ExplicitConversion etc). This checking is
16364 done in the methods that they delegate to.
16366 2003-05-20 Miguel de Icaza <miguel@ximian.com>
16368 * convert.cs: Move Error_CannotConvertType,
16369 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
16370 ImplicitNumericConversion, ImplicitConversionExists,
16371 ImplicitUserConversionExists, StandardConversionExists,
16372 FindMostEncompassedType, FindMostSpecificSource,
16373 FindMostSpecificTarget, ImplicitUserConversion,
16374 ExplicitUserConversion, GetConversionOperators,
16375 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
16376 TryImplicitIntConversion, Error_CannotConvertImplicit,
16377 ConvertImplicitRequired, ConvertNumericExplicit,
16378 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
16379 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
16382 Perform the following renames:
16384 StandardConversionExists -> ImplicitStandardConversionExists
16385 ConvertImplicit -> ImplicitConversion
16386 ConvertImplicitStandard -> ImplicitStandardConversion
16387 TryImplicitIntConversion -> ImplicitIntConversion
16388 ConvertImplicitRequired -> ImplicitConversionRequired
16389 ConvertNumericExplicit -> ExplicitNumericConversion
16390 ConvertReferenceExplicit -> ExplicitReferenceConversion
16391 ConvertExplicit -> ExplicitConversion
16392 ConvertExplicitStandard -> ExplicitStandardConversion
16394 2003-05-19 Martin Baulig <martin@ximian.com>
16396 * statement.cs (TypeInfo.StructInfo): Made this type protected.
16397 (TypeInfo): Added support for structs having structs as fields.
16399 * ecore.cs (FieldExpr): Implement IVariable.
16400 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
16401 VariableInfo for the field.
16403 2003-05-18 Martin Baulig <martin@ximian.com>
16405 * expression.cs (This.DoResolve): Report a CS0027 if we're
16406 emitting a field initializer.
16408 2003-05-18 Martin Baulig <martin@ximian.com>
16410 * expression.cs (This.ResolveBase): New public function.
16411 (This.DoResolve): Check for CS0188.
16413 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
16416 * ecore.cs (MethodGroupExpr.DoResolve): Set the
16417 `instance_expression' to null if we don't have any non-static
16420 2003-05-18 Martin Baulig <martin@ximian.com>
16422 Reworked the way how local variables and parameters are handled by
16423 the flow analysis code.
16425 * statement.cs (TypeInfo, VariableMap): New public classes.
16426 (VariableInfo): New public class. This is now responsible for
16427 checking whether a variable has been assigned. It is used for
16428 parameters and local variables.
16429 (Block.EmitMeta): Take the InternalParameters as argument; compute
16430 the layout of the flow vectors here.
16431 (Block.LocalMap, Block.ParameterMap): New public properties.
16432 (FlowBranching): The .ctor doesn't get the InternalParameters
16433 anymore since Block.EmitMeta() now computes the layout of the flow
16435 (MyStructInfo): This class is now known as `StructInfo' and nested
16436 in `TypeInfo'; we don't access this directly anymore.
16438 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
16439 property and removed IsAssigned(), IsFieldAssigned(),
16440 SetAssigned() and SetFieldAssigned(); we now call them on the
16441 VariableInfo so we don't need to duplicate this code everywhere.
16443 * expression.cs (ParameterReference): Added `Block block' argument
16445 (LocalVariableReference, ParameterReference, This): The new
16446 VariableInfo class is now responsible for all the definite
16449 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
16450 IsParameterAssigned, SetParameterAssigned): Removed.
16452 2003-05-18 Martin Baulig <martin@ximian.com>
16454 * typemanager.cs (InitCoreTypes): Try calling
16455 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
16456 the 3-args-version. Corlib now also needs our `void_type'.
16457 (GetMethod): Added overloaded version which takes an optional
16458 `bool report_errors' to allow lookups of optional methods.
16460 2003-05-12 Martin Baulig <martin@ximian.com>
16462 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
16463 only used for locals and not for parameters.
16465 2003-05-12 Miguel de Icaza <miguel@ximian.com>
16467 * support.cs (InternalParameters.ParameterType): Return the
16468 ExternalType of the parameter.
16470 * parameter.cs (Parameter.ExternalType): drop the two arguments,
16473 2003-05-11 Miguel de Icaza <miguel@ximian.com>
16475 * class.cs (MethodData.Define): Do not set the `newslot' on
16476 interface members, if they are also flagged as "override".
16478 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
16479 better code for ++i and i++. This only works for static fields
16480 and local variables.
16482 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
16483 want to pull the DeclSpace out of the builder_to_declspace instead
16484 of the TypeBuilder (like in TypeContainer.FindMembers).
16486 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
16487 instead of LookupTypeContainer. Fixes the crash on .NET for
16488 looking up interface members.
16490 * const.cs: Create our own emit context during the Definition
16491 stage, so that constants are evaluated in the proper context, when
16492 a recursive definition happens.
16494 2003-05-11 Martin Baulig <martin@ximian.com>
16496 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
16497 new block for a switch section.
16498 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
16499 the adding/lookup in the switch block. Fixes #39828.
16501 2003-05-09 Miguel de Icaza <miguel@ximian.com>
16503 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
16504 functionality: I needed to convert the data after I had performed
16505 the add/sub operation into the operands type size.
16507 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
16508 pass the type for the box operation, otherwise the resulting
16509 object would have been of type object.
16511 (BoxedCast): Add constructor to specify the type to box as.
16513 2003-05-07 Miguel de Icaza <miguel@ximian.com>
16515 * iterators.cs: I was reusing the `count' variable inadvertently,
16516 take steps to not allow this to happen.
16518 2003-05-06 Miguel de Icaza <miguel@ximian.com>
16520 * attribute.cs (Attribute.Resolve): Params attributes are encoded
16521 by creating an array at the point where the params starts and
16522 putting all those arguments there, then adjusting the size of the
16525 2003-05-05 Miguel de Icaza <miguel@ximian.com>
16527 * expression.cs (New.AddressOf): Implement interface
16528 IMemoryLocation. This is used when the `new' operator is used in
16529 the context of an invocation to a method on a value type.
16531 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
16534 * namespace.cs: Also check the using aliases here.
16536 * driver.cs: Move the test for using validity after the types have
16537 been entered, so we do a single pass that also includes the using
16540 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
16541 in the regular case. CreateSiblingForFinally is doing extra
16544 * attribute.cs (GetAttributeArgumentExpression): Store the result
16545 on an out value, and use the return value to indicate failure
16546 instead of using null (which is a valid return for Constant.GetValue).
16548 * statement.cs: Perform the analysis flow for the increment
16549 portion after the statement, because this will be the real flow of
16550 execution. Fixes #42385
16552 * codegen.cs (EmitContext.EmitArgument,
16553 EmitContext.EmitStoreArgument): New helper functions when the
16554 RemapToProxy flag is set.
16556 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
16559 Add support for remapping parameters.
16561 * iterators.cs: Propagate parameter values; Store parameter
16562 values in the proxy classes.
16564 2003-05-04 Miguel de Icaza <miguel@ximian.com>
16566 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
16567 need a proxy reference; I do not know what I was thinking
16569 * cs-parser.jay (constructor_initializer): catch another error,
16570 and display nice message.
16572 (field_declaration): catch void field declaration
16573 to flag a better error.
16575 * class.cs (MemberBase.CheckBase): Report an error instead of a
16576 warning if a new protected member is declared in a struct.
16577 (Field.Define): catch the error of readonly/volatile.
16579 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
16581 (FieldExpr.AddressOf): ditto. Catch error where the address of a
16582 volatile variable is taken
16584 2003-05-02 Miguel de Icaza <miguel@ximian.com>
16586 * statement.cs (Fixed.Resolve): Report an error if we are not in
16589 2003-05-01 Miguel de Icaza <miguel@ximian.com>
16591 * typemanager.cs: reuse the code that handles type clashes for
16592 delegates and enumerations.
16594 * class.cs (Report28): Always report.
16596 * expression.cs (EncodeAsAttribute): Allow nulls here.
16598 2003-04-28 Miguel de Icaza <miguel@ximian.com>
16600 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
16601 the functionality for testing whether an expression is valid for
16602 an attribute here. Also handle the case of arrays of elements
16605 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
16606 encoding a linear array into an array of objects that are suitable
16607 to be passed to an CustomAttributeBuilder.
16609 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
16611 * ecore.cs: (FieldExpr): Handle field remapping here.
16613 * iteratators.cs: Pass the instance variable (if the method is an
16614 instance method) to the constructors, so we can access the field
16615 variables on the class.
16617 TODO: Test this with structs. I think the THIS variable on
16618 structs might have to be a pointer, and not a refenrece
16620 2003-04-27 Miguel de Icaza <miguel@ximian.com>
16622 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
16623 local variables to fields in a proxy class.
16625 * iterators.cs (PopulateProxy): Rename our internal fields to
16627 Create a <THIS> field if we are an instance method, so we can
16628 reference our parent container variables.
16629 (MapVariable): Called back from the EmitContext code to enter a
16630 new variable to field mapping into the proxy class (we just create
16634 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
16635 for using the remapped locals to fields.
16637 I placed the code here, because that gives the same semantics to
16638 local variables, and only changes the Emit code.
16640 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
16641 statements inside iterators.
16642 (VariableInfo): Add a FieldBuilder for the cases when we are
16643 remapping local variables to fields in a proxy class
16645 * ecore.cs (SimpleNameResolve): Avoid testing two times for
16646 current_block != null.
16648 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
16649 not cope with strings, as it has been moved to the
16650 TableSwitchEmit. Fixed bug in switch generation.
16652 * expression.cs (New.DoResolve): Provide more context for the user
16653 when reporting an error.
16655 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
16658 * expression.cs (MemberAccess.DoResolve): When we get a type back,
16659 check the permissions for it. Note than in a type-resolution
16660 context the check was already present in DeclSpace.ResolveType,
16661 but was missing from the MemberAccess.
16663 (ArrayCreation.CheckIndices): warn if the user has
16664 more nested levels of expressions, but there are no more
16665 dimensions specified. Avoids crash on bug 41906.
16667 2003-04-26 Miguel de Icaza <miguel@ximian.com>
16669 * statement.cs (Block): replace Implicit bool, for a generic
16671 New flag: `Unchecked'. This is used during the EmitMeta phase
16672 (which is out-of-line with the regular Resolve/Emit process for a
16673 statement, as this is done ahead of time, but still gets a chance
16674 to call constant resolve).
16676 (Block.Flags): new enum for adding a new flag.
16678 (Block.EmitMeta): track the state of unchecked.
16680 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
16681 to enable constant resolution to work there as well.
16683 2003-04-22 Miguel de Icaza <miguel@ximian.com>
16685 * typemanager.cs (ienumerable_type): Also look up
16686 System.Collections.IEnumerable.
16688 2003-04-21 Miguel de Icaza <miguel@ximian.com>
16690 TODO: Test more than one conditional per method.
16692 * class.cs (Indexer.Define): Report the location where the user is
16693 referencing the unsupported feature.
16695 (MethodData): Overload the use of `conditionals' to
16696 minimize the creation of needless ArrayLists. This saves roughly
16697 212kb on my machine.
16699 (Method): Implement the new IIteratorContainer interface.
16700 (Method.SetYields): Implement the method by setting the ModFlags
16701 to contain METHOD_YIELDS.
16703 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
16704 which just got set to null.
16706 * iterators.cs: New file.
16708 (Yield, YieldBreak): New statements.
16710 * statement.cs (Return.Resolve): Flag an error if we are used in
16711 an iterator method.
16713 * codegen.cs (InIterator): New flag set if the code is being
16714 compiled in an iterator method.
16716 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
16717 internal modifier, and we just use it to avoid adding extra
16718 fields, as this is seldom used.
16720 * cs-parser.jay: Add yield_statement (yield and yield break).
16722 * driver.cs: New flag -v2 to turn on version 2 features.
16724 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
16725 hashtable when v2 is enabled.
16727 2003-04-20 Miguel de Icaza <miguel@ximian.com>
16729 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
16730 there is already a namespace defined with this name.
16732 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
16733 people upgraded their corlibs.
16735 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
16736 always use fully qualified types, no need to use the compiler
16739 (TypeManager.IsNamespace): Use binarysearch.
16741 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
16742 AddDelegate): I did not quite use the new IsValid API properly: I
16743 have to pass the short-name and the fullname. I was passing only
16744 the basename instead of the fullname sometimes.
16746 (TypeContainer.DefineType): call NamespaceClash.
16748 * interface.cs (Interface.DefineType): use NamespaceClash before
16751 * delegate.cs (Delegate.DefineType): use NamespaceClash before
16754 * enum.cs: (Enum.DefineType): use NamespaceClash before
16757 * typemanager.cs (: 3-line patch that gives us some tasty 11%
16758 speed increase. First, use the negative_hits cache when we get a
16759 negative. Second, add the type with its full original name
16760 instead of the new . and + encoded name (reflection uses + to
16761 separate type from a nested type). Use LookupTypeReflection
16762 directly which bypasses the type->name hashtable (that we already
16763 know does not contain the type.
16765 * decl.cs (DeclSpace.ResolveTypeExpr): track the
16766 location/container type.
16768 * driver.cs: When passing utf8, use directly the UTF8Encoding.
16770 2003-04-19 Miguel de Icaza <miguel@ximian.com>
16772 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
16774 * delegate.cs (NewDelegate.Resolve): Test whether an instance
16775 method is being referenced in the method group from a static
16776 context, and report error 120 if so.
16778 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
16781 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
16782 is created, we create the A namespace).
16784 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16787 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16789 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16790 invocation to ModuleBuilder.GetType with the same values will
16791 return a new type instance, so we need to cache its return
16794 * expression.cs (Binary.ResolveOperator): Only allow the compare
16795 operators on enums if they are of the same type.
16797 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16798 types of ValueType on their own case. Before we were giving them
16799 the same treatment as objects.
16801 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16802 fullname. Short name is used to compare against container name.
16803 Fullname is used to check against defined namespace names.
16805 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16806 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16808 (Method.CheckBase): Call parent.
16809 (MemberBase.CheckBase): Check for protected members on sealed
16811 (PropertyBase.CheckBase): Call parent.
16812 (Field.Define): Call parent.
16814 * report.cs: Negative error codes are now mapped to 8000 - code,
16815 so that the display is render more nicely.
16817 * typemanager.cs: Do not use try/catch, instead report a regular
16820 (GetPointerType, GetReferenceType): These methods provide
16821 mechanisms to obtain the T* and T& from a T. We had the code
16822 previously scattered around the code base, and it also used
16823 TypeManager.LookupType that would go through plenty of caches.
16824 This one goes directly to the type source.
16826 In some places we did the Type.GetType followed by
16827 ModuleBuilder.GetType, but not in others, so this unifies the
16828 processing as well.
16830 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16831 statements now that we have namespace information.
16833 * typemanager.cs (IsNamespace): New method, returns whether the
16834 string presented is a namespace or not.
16836 (ComputeNamespaces): New public entry point, computes the list of
16837 available namespaces, using the GetNamespaces API call in Mono, or
16838 the slower version in MS.NET.
16840 Now before we start the semantic analysis phase, we have a
16841 complete list of namespaces including everything that the user has
16844 Deleted old code to cache namespaces in .nsc files.
16846 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16848 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16849 class/struct location definition Location for the implicit
16850 constructor location.
16852 (Operator.Define): Use the location of the operator for the
16853 implicit Method definition.
16855 (Constructor.Emit): use the constructor location for the implicit
16856 base initializer constructor.
16858 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16859 and the Expression class now contains two new methods:
16861 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16862 isolate type lookup from the rest of the resolution process.
16864 Since we use Expressions to hold type definitions due to the way
16865 we parse the input we have historically overloaded Resolve to
16866 perform the Type lookups if a special flag is passed. Now this is
16867 eliminated and two methods take their place.
16869 The differences in the two methods between xStep and xTerminal is
16870 that xStep is involved in our current lookup system that uses
16871 SimpleNames to compose a name, while xTerminal is used just to
16872 catch the case where the simplename lookup failed.
16874 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16876 * expression.cs (ResolveMemberAccess): Remove redundant code.
16877 TypeExpr expressions are always born fully resolved.
16879 * interface.cs (PopulateMethod): Do not lookup the types twice.
16880 We were doing it once during SemanticAnalysis and once during
16883 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16884 in local variable type definitions, were being returned as a
16885 SimpleName (we decomposed everything into a string), that is
16886 because primary_expression was being used instead of a type in the
16887 grammar (reduce/reduce conflicts).
16889 The part that was wrong is that we converted the expression into a
16890 string (an oversimplification in one hand, compounded with primary
16891 expressions doing string concatenation).
16897 Would return "A.B.C[]" as a SimpleName. This stopped things like
16898 using clauses from working on this particular context. And a type
16899 was being matched directly against "A.B.C[]".
16901 We now use the correct approach, and allow for ComposedCast to be
16902 part of the unary expression. So the "A.B.C []" become a composed
16903 cast of "A.B.C" (as a nested group of MemberAccess with a
16904 SimpleName at the end) plus the rank composition "[]".
16908 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16910 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16911 for the access level checking.
16913 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16914 `TypeContainer container', because I kept getting confused when I
16915 was debugging this code.
16917 * expression.cs (Indexers): Instead of tracking getters/setters,
16918 we now track them in parallel. We create one arraylist less, but
16919 most importantly it is possible now for the LValue code to find a
16920 matching get for a set.
16922 (IndexerAccess.DoResolveLValue): Update the code.
16923 GetIndexersForType has been modified already to extract all the
16924 indexers from a type. The code assumed it did not.
16926 Also make the code set the correct return type for the indexer.
16927 This was fixed a long time ago for properties, but was missing for
16928 indexers. It used to be void_type.
16930 (Binary.Emit): Test first for doubles instead of
16931 floats, as they are more common.
16933 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16934 when dealing with floats and the <=, >= operators. This fixes bug
16937 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16938 to load the array value by emitting a load on the foreach variable
16939 type. This was incorrect.
16941 We now emit the code to load an element using the the array
16942 variable type, and then we emit the conversion operator.
16946 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16948 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16950 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16952 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16953 test for protection before we test for signatures.
16955 (MethodSignature.ToString): implement.
16957 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16958 to the case where we reduced into a LongConstant.
16960 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16961 depend on whether the information is acurrate, because the
16962 Microsoft runtime will always claim that the array type is public,
16963 regardless of the real state.
16965 If the type is a pointer, another problem happens: the type is
16966 reported as non-public in Microsoft.
16968 In both cases we have to call CheckAccessLevel recursively with
16969 the underlying type as the argument to be tested.
16971 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16973 * assign.cs (Assign.Emit): If we are dealing with a compound
16974 assignment expression, we should use the code path that stores the
16975 intermediate result in a temporary value. This fixes #40903.
16977 *expression.cs (Indirection.ToString): Provide ToString method for
16980 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16982 * class.cs: Null out fields holding references to Block objects so
16983 they can be garbage collected.
16985 * expression.cs (OverloadResolve): Remove unused local.
16987 2003-04-07 Martin Baulig <martin@ximian.com>
16989 * codegen.cs (EmitContext.CurrentFile): New public field.
16990 (EmitContext.Mark): Use the CurrentFile to check whether the
16991 location is in the correct file.
16992 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16994 2003-04-07 Martin Baulig <martin@ximian.com>
16996 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16998 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16999 location. [FIXME: The location argument which gets passed to this
17000 method is sometimes wrong!]
17002 2003-04-07 Nick Drochak <ndrochak@gol.com>
17004 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
17006 2003-04-07 Miguel de Icaza <miguel@ximian.com>
17008 * expression.cs (Indirection.EmitAssign): We were using the
17009 temporary, but returning immediately instead of continuing the
17012 2003-04-06 Martin Baulig <martin@ximian.com>
17014 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
17015 if it's a nested child, but also deriving from the outer class.
17018 * typemanager.cs (IsNestedChildOf): Make this work if it's a
17019 nested child, but also deriving from the outer class. See
17021 (FilterWithClosure): We may access private members of the outer
17022 class if we're a nested child and deriving from the outer class.
17023 (RealMemberLookup): Only set `closure_private_ok' if the
17024 `original_bf' contained BindingFlags.NonPublic.
17026 2003-04-05 Martin Baulig <martin@ximian.com>
17028 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
17030 2003-04-02 Miguel de Icaza <miguel@ximian.com>
17032 * class.cs (Event.Define): Do not allow abstract events to have
17035 2003-04-01 Miguel de Icaza <miguel@ximian.com>
17037 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
17038 block in event declarations.
17040 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
17041 value type, get its address.
17043 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
17044 leaving a class on the stack instead of a boolean value (int
17045 0/1). Change the code so we compare against null, and then the
17046 result against zero.
17048 * class.cs (TypeContainer.GetClassBases): We were checking for the
17049 parent class being sealed too late.
17051 * expression.cs (Binary.Emit): For <= and >= when dealing with
17052 floating point values, use cgt.un and clt.un instead of cgt and
17055 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
17057 * statement.cs: Apply the same optimization as MS: skip the
17058 GetEnumerator returning an IEnumerator, and use the one returning a
17059 CharEnumerator instead. This allows us to avoid the try-finally block
17062 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
17064 * cs-parser.jay: Attributes cannot be applied to
17065 namespaces. Fixes #40473
17067 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17070 (Add*): check if the name is valid using the full name for constants,
17071 fields, properties and events.
17073 2003-03-28 Miguel de Icaza <miguel@ximian.com>
17075 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
17076 char constants to be part of the enumeration.
17078 * expression.cs (Conditional.DoResolve): Add support for operator
17079 true. Implements the missing functionality from 14.12
17081 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
17082 operator true/false as required by the spec.
17084 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
17085 implicit conversion to boolean.
17087 * statement.cs (Statement.ResolveBoolean): A boolean expression is
17088 also one where the type implements `operator true'.
17090 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
17091 get an expression that will invoke operator true based on an
17094 (GetConversionOperators): Removed the hack that called op_True
17097 (Expression.ResolveBoolean): Move this from Statement.
17099 2003-03-17 Miguel de Icaza <miguel@ximian.com>
17101 * ecore.cs (FieldExpr): do not allow initialization of initonly
17102 fields on derived classes
17104 2003-03-13 Martin Baulig <martin@ximian.com>
17106 * statement.cs (Block.Emit): Call ig.BeginScope() and
17107 ig.EndScope() when compiling with debugging info; call
17108 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
17110 2003-03-08 Miguel de Icaza <miguel@ximian.com>
17112 * expression.cs (Indexers): Do not construct immediately, allow
17113 for new members to be appended as we go. Fixes 38143
17115 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17117 * expression.cs: save/restore context when resolving an unchecked
17120 2003-03-05 Miguel de Icaza <miguel@ximian.com>
17122 * cfold.cs: Catch division by zero in modulus operator during
17125 2003-03-03 Miguel de Icaza <miguel@ximian.com>
17127 * interface.cs (Interface.DefineMembers): Avoid defining members
17130 2003-02-27 Miguel de Icaza <miguel@ximian.com>
17132 * driver.cs: handle the +/- options for -noconfig
17134 * statement.cs (Unckeched.Resolve): Also track the state of
17135 unchecked in the Resolve phase.
17137 2003-02-27 Martin Baulig <martin@ximian.com>
17139 * ecore.cs (Expression.MemberLookup): Don't create a
17140 MethodGroupExpr for something which is not a method. Fixes #38291.
17142 2003-02-25 Miguel de Icaza <miguel@ximian.com>
17144 * class.cs (MemberBase.CheckParameters): Also check that the type
17145 is unmanaged if it is a pointer.
17147 * expression.cs (SizeOf.Resolve): Add location information.
17149 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
17150 a managed type is declared.
17152 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
17153 parameter modifiers as well. Fixes bug 38606
17155 * class.cs: Very sad. Am backing out the speed up changes
17156 introduced by the ArrayList -> Array in the TypeContainer, as they
17157 were not actually that much faster, and introduced a bug (no error
17158 reports on duplicated methods).
17160 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
17161 source first, this will guarantee that we have a valid expression
17162 before calling in lower levels functions that will require a
17163 resolved object. Then use this original_source in the
17164 target.ResolveLValue instead of the original source that was
17167 Another change. Use target.Resolve instead of LValueResolve.
17168 Although we are resolving for LValues, we will let the Assign code
17169 take care of that (it will be called again from Resolve). This
17170 basically allows code like this:
17172 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
17173 class Y { void A (X x) { x [0] += o; }
17175 The problem was that the indexer was trying to resolve for
17176 set_Item (idx, object o) and never finding one. The real set_Item
17177 was set_Item (idx, X). By delaying the process we get the right
17182 2003-02-23 Martin Baulig <martin@ximian.com>
17184 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
17185 while calling DoEmit ().
17187 * codegen.cs (EmitContext.Mark): Don't mark locations in other
17188 source files; if you use the #line directive inside a method, the
17189 compiler stops emitting line numbers for the debugger until it
17190 reaches the end of the method or another #line directive which
17191 restores the original file.
17193 2003-02-23 Martin Baulig <martin@ximian.com>
17195 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
17197 2003-02-23 Martin Baulig <martin@ximian.com>
17199 * statement.cs (Block.AddChildVariableNames): We need to call this
17200 recursively, not just for our immediate children.
17202 2003-02-23 Martin Baulig <martin@ximian.com>
17204 * class.cs (Event.Define): Always make the field private, like csc does.
17206 * typemanager.cs (TypeManager.RealMemberLookup): Make events
17207 actually work, fixes bug #37521.
17209 2003-02-23 Miguel de Icaza <miguel@ximian.com>
17211 * delegate.cs: When creating the various temporary "Parameters"
17212 classes, make sure that we call the ComputeAndDefineParameterTypes
17213 on those new parameters (just like we do with the formal ones), to
17214 allow them to be resolved in the context of the DeclSpace.
17216 This fixes the bug that Dick observed in Bugzilla #38530.
17218 2003-02-22 Miguel de Icaza <miguel@ximian.com>
17220 * expression.cs (ResolveMemberAccess): When resolving a constant,
17221 do not attempt to pull a constant if the value was not able to
17222 generate a valid constant.
17224 * const.cs (LookupConstantValue): Do not report more errors than required.
17226 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17228 * expression.cs: fixes bug #38328.
17230 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17232 * class.cs: Changed all the various members that can be part of a
17233 class from being an ArrayList to be an Array of the right type.
17234 During the DefineType type_list, interface_list, delegate_list and
17235 enum_list are turned into types, interfaces, delegates and enums
17238 And during the member population, indexer_list, event_list,
17239 constant_list, field_list, instance_constructor_list, method_list,
17240 operator_list and property_list are turned into their real arrays.
17242 Although we could probably perform this operation earlier, for
17243 good error reporting we need to keep the lists and remove the
17244 lists for longer than required.
17246 This optimization was triggered by Paolo profiling the compiler
17247 speed on the output of `gen-sample-program.pl' perl script.
17249 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
17250 not crash in methods like MemberLookupFailed that use this field.
17252 This problem arises when the compiler fails to resolve a type
17253 during interface type definition for example.
17255 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17257 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
17258 inherit from System.Object, so we have to stop at null, not only
17259 when reaching System.Object.
17261 2003-02-17 Miguel de Icaza <miguel@ximian.com>
17263 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
17264 DeclaredOnly because the parent indexer might have had a different
17265 name, but did not loop until the top of the hierarchy was reached.
17267 The problem this one fixes is 35492: when a class implemented an
17268 indexer from an interface, we were getting the interface method
17269 (which was abstract) and we were flagging an error (can not invoke
17272 This also keeps bug 33089 functioning, and test-148 functioning.
17274 * typemanager.cs (IsSpecialMethod): The correct way of figuring
17275 out if a method is special is to see if it is declared in a
17276 property or event, or whether it is one of the predefined operator
17277 names. This should fix correctly #36804.
17279 2003-02-15 Miguel de Icaza <miguel@ximian.com>
17281 The goal here is to remove the dependency on EmptyCast.Peel ().
17282 Killing it completely.
17284 The problem is that currently in a number of places where
17285 constants are expected, we have to "probe" for an EmptyCast, and
17286 Peel, which is not the correct thing to do, as this will be
17287 repetitive and will likely lead to errors.
17289 The idea is to remove any EmptyCasts that are used in casts that
17290 can be reduced to constants, so we only have to cope with
17293 This bug hunt was triggered by Bug 37363 and the desire to remove
17294 the duplicate pattern where we were "peeling" emptycasts to check
17295 whether they were constants. Now constants will always be
17298 * ecore.cs: Use an enumconstant here instead of wrapping with
17301 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
17302 throwing me off. By handling this we can get rid of a few hacks.
17304 * statement.cs (Switch): Removed Peel() code.
17306 2003-02-14 Miguel de Icaza <miguel@ximian.com>
17308 * class.cs: Location information for error 508
17310 * expression.cs (New.DoResolve): Add a guard against double
17311 resolution of an expression.
17313 The New DoResolve might be called twice when initializing field
17314 expressions (see EmitFieldInitializers, the call to
17315 GetInitializerExpression will perform a resolve on the expression,
17316 and later the assign will trigger another resolution
17318 This leads to bugs (#37014)
17320 * delegate.cs: The signature for EndInvoke should contain any ref
17321 or out parameters as well. We were not doing this in the past.
17323 * class.cs (Field.Define): Do not overwrite the type definition
17324 inside the `volatile' group. Turns out that volatile enumerations
17325 were changing the type here to perform a validity test, which
17328 2003-02-12 Miguel de Icaza <miguel@ximian.com>
17330 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
17331 and structs, we do not want to load the instance variable
17333 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
17334 enum_type has to be handled like an object reference (implicit
17335 conversions exists from this to object), but the regular IsClass
17336 and IsValueType tests will never return true for this one.
17338 Also we use TypeManager.IsValueType instead of type.IsValueType,
17339 just for consistency with the rest of the code (this is only
17340 needed if we ever use the construct exposed by test-180.cs inside
17341 corlib, which we dont today).
17343 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
17345 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
17348 2003-02-09 Martin Baulig <martin@ximian.com>
17350 * namespace.cs (Namespace..ctor): Added SourceFile argument.
17351 (Namespace.DefineNamespaces): New static public method; this is
17352 called when we're compiling with debugging to add all namespaces
17353 to the symbol file.
17355 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
17356 pass it to the Namespace's .ctor.
17358 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
17359 and MethodBase arguments; pass the namespace ID to the symwriter;
17360 pass the MethodBase instead of the token to the symwriter.
17361 (SymbolWriter.DefineNamespace): New method to add a namespace to
17364 2003-02-09 Martin Baulig <martin@ximian.com>
17366 * symbolwriter.cs: New file. This is a wrapper around
17367 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
17368 methods here in near future.
17370 2003-02-09 Martin Baulig <martin@ximian.com>
17372 * codegen.cs (EmitContext.Mark): Just pass the arguments to
17373 ILGenerator.MarkSequencePoint() which are actually used by the
17376 2003-02-09 Martin Baulig <martin@ximian.com>
17378 * location.cs (SourceFile): New public sealed class. This
17379 contains the name and an index which is used in the location's token.
17380 (Location): Reserve an appropriate number of bits in the token for
17381 the source file instead of walking over that list, this gives us a
17382 really huge performance improvement when compiling with debugging.
17384 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
17385 `SourceFile' argument instead of a string.
17386 (Driver.ProcessFile): Add all the files via Location.AddFile(),
17387 but don't parse/tokenize here, we need to generate the list of all
17388 source files before we do that.
17389 (Driver.ProcessFiles): New static function. Parses/tokenizes all
17392 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
17393 instead of a string.
17395 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
17398 2003-02-09 Martin Baulig <martin@ximian.com>
17400 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
17401 filename on `#line default'.
17403 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
17405 * statement.cs: don't clear the pinned var when the fixed statement
17406 returns from the method (fixes bug#37752).
17408 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
17410 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
17413 2003-02-07 Martin Baulig <martin@ximian.com>
17415 * driver.cs: Removed the `--debug-args' command line argument.
17417 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
17418 automatically by the AsssemblyBuilder.
17419 (CodeGen.InitializeSymbolWriter): We don't need to call any
17420 initialization function on the symbol writer anymore. This method
17421 doesn't take any arguments.
17423 2003-02-03 Miguel de Icaza <miguel@ximian.com>
17425 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
17426 from referenced assemblies as well.
17428 2003-02-02 Martin Baulig <martin@ximian.com>
17430 * class.cs (MethodData.Emit): Generate debugging info for external methods.
17432 2003-02-02 Martin Baulig <martin@ximian.com>
17434 * class.cs (Constructor.Emit): Open the symbol writer before
17435 emitting the constructor initializer.
17436 (ConstructorInitializer.Emit): Call ec.Mark() to allow
17437 single-stepping through constructor initializers.
17439 2003-01-30 Miguel de Icaza <miguel@ximian.com>
17441 * class.cs: Handle error 549: do not allow virtual methods in
17444 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
17446 * decl.cs: Check access levels when resolving types
17448 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
17450 * statement.cs: Add parameters and locals set in catch blocks that might
17451 return to set vector
17453 2003-01-29 Miguel de Icaza <miguel@ximian.com>
17455 * class.cs (Operator): Set the SpecialName flags for operators.
17457 * expression.cs (Invocation.DoResolve): Only block calls to
17458 accessors and operators on SpecialName methods.
17460 (Cast.TryReduce): Handle conversions from char constants.
17463 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
17465 * statement.cs: small memory and time optimization in FlowBranching.
17467 2003-01-28 Pedro Mart <yoros@wanadoo.es>
17469 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
17470 problem that the last fix but in the other sid (Set).
17472 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
17473 access when there is no indexer in the hierarchy.
17475 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
17477 * class.cs: Combine some if statements.
17479 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17481 * driver.cs: fixed bug #37187.
17483 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
17485 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
17486 any indexer, it's needed to build a list with all the indexers in the
17487 hierarchy (AllGetters), else we have problems. Fixes #35653.
17489 2003-01-23 Miguel de Icaza <miguel@ximian.com>
17491 * class.cs (MethodData.Define): It is wrong for an interface
17492 implementation to be static in both cases: explicit and implicit.
17493 We were only handling this in one case.
17495 Improve the if situation there to not have negations.
17497 * class.cs (Field.Define): Turns out that we do not need to check
17498 the unsafe bit on field definition, only on usage. Remove the test.
17500 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17502 * driver.cs: use assembly.Location instead of Codebase (the latest
17503 patch made mcs fail when using MS assemblies).
17505 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
17507 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
17508 get the path to *corlib.dll.
17510 2003-01-21 Nick Drochak <ndrochak@gol.com>
17514 * typemanager.cs: Remove compiler warnings
17516 2003-01-20 Duncan Mak <duncan@ximian.com>
17518 * AssemblyInfo.cs: Bump the version number to 0.19.
17520 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17522 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
17524 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
17526 * class.cs (Constructor::Emit): Emit debugging info for constructors.
17528 2003-01-17 Miguel de Icaza <miguel@ximian.com>
17530 * cs-parser.jay: Small fix: we were not comparing the constructor
17531 name correctly. Thanks to Zoltan for the initial pointer.
17533 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
17535 * cs-tokenizer.cs: Set file name when specified with #line
17537 2003-01-15 Miguel de Icaza <miguel@ximian.com>
17539 * cs-parser.jay: Only perform the constructor checks here if we
17540 are named like the class; This will help provider a better
17541 error. The constructor path is taken when a type definition is
17542 not found, but most likely the user forgot to add the type, so
17543 report that rather than the constructor error.
17545 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
17547 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
17550 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17552 * cs-parser.jay: Add cleanup call.
17554 2003-01-13 Duncan Mak <duncan@ximian.com>
17556 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
17557 consistent with other methods.
17559 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17561 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
17563 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
17565 * attribute.cs: only set GuidAttr to true when we have a
17568 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17572 * typemanager.cs: fixes to allow mcs compile corlib with the new
17573 Type.IsSubclassOf fix.
17575 2003-01-08 Miguel de Icaza <miguel@ximian.com>
17577 * expression.cs (LocalVariableReference.DoResolve): Classify a
17578 constant as a value, not as a variable. Also, set the type for
17581 * cs-parser.jay (fixed_statement): take a type instead of a
17582 pointer_type, so we can produce a better error message later.
17584 * statement.cs (Fixed.Resolve): Flag types that are not pointers
17587 (For.DoEmit): Make inifinite loops have a
17588 non-conditional branch back.
17590 (Fixed.DoEmit): First populate the pinned variables, then emit the
17591 statement, then clear the variables. Before I was emitting the
17592 code once for each fixed piece.
17595 2003-01-08 Martin Baulig <martin@ximian.com>
17597 * statement.cs (FlowBranching.MergeChild): A break in a
17598 SWITCH_SECTION does not leave a loop. Fixes #36155.
17600 2003-01-08 Martin Baulig <martin@ximian.com>
17602 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
17603 lives in the same number space than `param_map'. Fixes #36154.
17605 2003-01-07 Miguel de Icaza <miguel@ximian.com>
17607 * cs-parser.jay (constructor_declaration): Set the
17608 Constructor.ModFlags before probing for it. This makes the
17609 compiler report 514, 515 and 132 (the code was there, but got
17612 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
17613 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
17614 (GotoCase.Resolve): Set `Returns' to ALWAYS.
17616 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
17618 * enum.cs: create the enum static fields using the enum type.
17620 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
17622 * class.cs: don't try to create the ParamBuilder for the return
17623 type if it's not needed (and handle it breaking for the ms runtime
17626 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
17628 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
17630 2002-12-29 Miguel de Icaza <miguel@ximian.com>
17632 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
17633 the command. This showed up while compiling the JANET source
17634 code, which used \r as its only newline separator.
17636 2002-12-28 Miguel de Icaza <miguel@ximian.com>
17638 * class.cs (Method.Define): If we are an operator (because it
17639 reuses our code), then set the SpecialName and HideBySig. #36128
17641 2002-12-22 Miguel de Icaza <miguel@ximian.com>
17643 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
17644 exception, report error 120 `object reference required'.
17646 * driver.cs: Add --pause option, used during to measure the size
17647 of the process as it goes with --timestamp.
17649 * expression.cs (Invocation.DoResolve): Do not allow methods with
17650 SpecialName to be invoked.
17652 2002-12-21 Miguel de Icaza <miguel@ximian.com>
17654 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
17655 number before adding it.
17657 2002-12-21 Ravi Pratap <ravi@ximian.com>
17659 * ecore.cs (StandardImplicitConversion): When in an unsafe
17660 context, we allow conversion between void * to any other pointer
17661 type. This fixes bug #35973.
17663 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
17665 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
17666 is not thrown when extensionless outputs are used
17668 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17670 * rootcontext.cs: fixed compilation of corlib.
17672 2002-12-19 Miguel de Icaza <miguel@ximian.com>
17674 * attribute.cs (Attributes.Contains): Add new method.
17676 * class.cs (MethodCore.LabelParameters): if the parameter is an
17677 `out' parameter, check that no attribute `[In]' has been passed.
17679 * enum.cs: Handle the `value__' name in an enumeration.
17681 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
17683 * decl.cs: Added special case to allow overrides on "protected
17686 2002-12-18 Ravi Pratap <ravi@ximian.com>
17688 * attribute.cs (Attributes.AddAttributeSection): Rename to this
17689 since it makes much more sense.
17691 (Attributes.ctor): Don't require a Location parameter.
17693 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
17695 * attribute.cs (ApplyAttributes): Remove extra Location parameters
17696 since we already have that information per attribute.
17698 * everywhere : make appropriate changes.
17700 * class.cs (LabelParameters): Write the code which actually
17701 applies attributes to the return type. We can't do this on the MS
17702 .NET runtime so we flag a warning in the case an exception is
17705 2002-12-18 Miguel de Icaza <miguel@ximian.com>
17707 * const.cs: Handle implicit null conversions here too.
17709 2002-12-17 Ravi Pratap <ravi@ximian.com>
17711 * class.cs (MethodCore.LabelParameters): Remove the extra
17712 Type [] parameter since it is completely unnecessary. Instead
17713 pass in the method's attributes so that we can extract
17714 the "return" attribute.
17716 2002-12-17 Miguel de Icaza <miguel@ximian.com>
17718 * cs-parser.jay (parse): Use Report.Error to flag errors instead
17719 of ignoring it and letting the compile continue.
17721 * typemanager.cs (ChangeType): use an extra argument to return an
17722 error condition instead of throwing an exception.
17724 2002-12-15 Miguel de Icaza <miguel@ximian.com>
17726 * expression.cs (Unary.TryReduce): mimic the code for the regular
17727 code path. Perform an implicit cast in the cases where we can
17728 implicitly convert to one of the integral types, and then reduce
17729 based on that constant. This fixes bug #35483.
17731 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17733 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
17735 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17737 * namespace.cs: fixed bug #35489.
17739 2002-12-12 Miguel de Icaza <miguel@ximian.com>
17741 * class.cs: Remove some dead code.
17743 * cs-parser.jay: Estimate the number of methods needed
17744 (RootContext.MethodCount);
17746 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
17747 numbers instead of StringBuilders.
17749 * support.cs (PtrHashtable): Add constructor with initial size;
17750 We can now reduce reallocations of the method table.
17752 2002-12-10 Ravi Pratap <ravi@ximian.com>
17754 * attribute.cs (ApplyAttributes): Keep track of the emitted
17755 attributes on a per-target basis. This fixes bug #35413.
17757 2002-12-10 Miguel de Icaza <miguel@ximian.com>
17759 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
17760 default to the Windows 1252 encoding.
17762 (UnixParseOption): Support version, thanks to Alp for the missing
17765 * AssemblyInfo.cs: Add nice assembly information.
17767 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17770 * cs-parser.jay: Allow a trailing comma before the close bracked
17771 in the attribute_section production.
17773 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17774 address of the instance was being taken, I will take this out,
17775 because we take the address of the object immediately here.
17777 2002-12-09 Ravi Pratap <ravi@ximian.com>
17779 * typemanager.cs (AreMultipleAllowed): Take care of the most
17780 obvious case where attribute type is not in the current assembly -
17783 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17785 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17786 definitions, instead of doing that afterwards.
17788 Also we use a nice little hack, depending on the constructor, we
17789 know if we are a "composed" name or a simple name. Hence, we
17790 avoid the IndexOf test, and we avoid
17792 * codegen.cs: Add code to assist in a bug reporter to track down
17793 the source of a compiler crash.
17795 2002-12-07 Ravi Pratap <ravi@ximian.com>
17797 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17798 types have been emitted for a given element and flag an error
17799 if something which does not have AllowMultiple set is used more
17802 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17803 attribute types and their corresponding AllowMultiple properties
17805 (AreMultipleAllowed): Check the property for a given type.
17807 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17808 property in the case we have a TypeContainer.
17810 (Attributes.AddAttribute): Detect duplicates and just skip on
17811 adding them. This trivial fix catches a pretty gross error in our
17812 attribute emission - global attributes were being emitted twice!
17814 Bugzilla bug #33187 is now fixed.
17816 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17818 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17819 instead of pp_and).
17821 * expression.cs (Binary.ResolveOperator): I can only use the
17822 Concat (string, string, string) and Concat (string, string,
17823 string, string) if the child is actually a concatenation of
17826 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17828 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17829 context where we need a 2-character lookahead.
17831 * pending.cs (PendingImplementation): Rework so we can keep track
17832 of interface types all the time, and flag those which were
17833 implemented by parents as optional.
17835 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17837 * expression.cs (Binary.ResolveOperator): Use
17838 String.Concat(string,string,string) or
17839 String.Concat(string,string,string,string) when possible.
17841 * typemanager: More helper methods.
17844 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17846 * pending.cs: remove the bogus return from GetMissingInterfaces()
17847 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17849 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17851 * namespace.cs: avoid duplicated 'using xxx' being added to
17852 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17853 when we get more than one 'using' statement for the same namespace.
17854 Report a CS0105 warning for it.
17856 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17858 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17859 of calling getChar/putback, uses internal knowledge of it.
17861 (xtoken): Reorder tokenizer so most common patterns are checked
17862 first. This reduces the compilation time in another 5% (from 8.11s
17863 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17865 The parsing time is 22% of the compilation in mcs, and from that
17866 64% is spent on the tokenization process.
17868 I tried using a binary search for keywords, but this is slower
17869 than the hashtable. Another option would be to do a couple of
17872 * Not use a StringBuilder, instead use an array of chars,
17873 with a set value. Notice that this way we could catch
17874 the 645 error without having to do it *afterwards*.
17876 * We could write a hand-parser to avoid the hashtable
17877 compares altogether.
17879 The identifier consumption process takes 37% of the tokenization
17880 time. Another 15% is spent on is_number. 56% of the time spent
17881 on is_number is spent on Int64.Parse:
17883 * We could probably choose based on the string length to
17884 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17887 Another 3% is spend on wrapping `xtoken' in the `token' function.
17889 Handle 0xa0 as whitespace (#34752)
17891 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17893 * typemanager.cs (IsCLRType): New routine to tell whether a type
17894 is one of the builtin types.
17896 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17897 typecode in more places instead of doing pointer comparissions.
17898 We could leverage some knowledge about the way the typecodes are
17901 New code to cache namespaces in assemblies, it is currently not
17902 invoked, to be used soon.
17904 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17906 * expression.cs (Binary.ResolveOperator): specially handle
17907 strings, and do not perform user-defined operator overloading for
17910 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17912 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17913 internalcall as it is a pretty simple operation; Avoid whenever
17914 possible to call Char.IsLetter.
17916 (consume_identifier): Cut by half the number of
17917 hashtable calls by merging the is_keyword and GetKeyword behavior.
17919 Do not short-circuit, because if we do, we
17920 report errors (ie, #if false && true would produce an invalid
17924 2002-11-24 Martin Baulig <martin@ximian.com>
17926 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17927 check constant ranges and report a CS0221. Fixes #33186.
17929 2002-11-24 Martin Baulig <martin@ximian.com>
17931 * cs-parser.jay: Make this work for uninitialized variable
17932 declarations in the `for' initializer. Fixes #32416.
17934 2002-11-24 Martin Baulig <martin@ximian.com>
17936 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17937 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17939 2002-11-24 Martin Baulig <martin@ximian.com>
17941 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17942 argument; if true, we also check for user-defined conversions.
17943 This is only needed if both arguments are of a user-defined type.
17944 Fixes #30443, added test-175.cs.
17945 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17947 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17949 2002-11-24 Martin Baulig <martin@ximian.com>
17951 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17952 function to get the store opcode.
17953 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17954 only emit the Ldelema if the store opcode is Stobj. You must run
17955 both test-34 and test-167 to test this. Fixes #34529.
17957 2002-11-23 Martin Baulig <martin@ximian.com>
17959 * ecore.cs (Expression.MemberLookup): Added additional
17960 `qualifier_type' argument which is used when we're being called
17961 from MemberAccess.DoResolve() and null if we're called from a
17963 (Expression.MemberLookupFailed): New method to report errors; this
17964 does the CS1540 check and reports the correct error message.
17966 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17967 argument for the CS1540 check and redone the way how we're dealing
17968 with private members. See the comment in the source code for details.
17969 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17970 `closure_start_type' to `closure_qualifier_type' and check whether
17971 it's not null. It was not this filter being broken, it was just
17972 being called with the wrong arguments.
17974 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17975 and pass it the correct `qualifier_type'; this also does the error
17978 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17980 * expression.cs (Invocation.EmitParams): If the we are dealing
17981 with a non-built-in value type, load its address as well.
17983 (ArrayCreation): Use a a pretty constant instead
17984 of the hardcoded value 2. Use 6 instead of 2 for the number of
17985 static initializers.
17987 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17988 because they are not really value types, just glorified integers.
17990 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17992 * ecore.cs: Remove redundant code for enumerations, make them use
17993 the same code path as everything else, fixes the casting issue
17994 with enumerations in Windows.Forms.
17996 * attribute.cs: Do only cast to string if it is a string, the
17997 validation happens later.
17999 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
18000 people upgrade their corlibs.
18002 * ecore.cs: Oops, enumerations were not following the entire code path
18004 2002-11-21 Miguel de Icaza <miguel@ximian.com>
18006 * typemanager.cs (FilterWithClosure): Commented out the test for
18007 1540 in typemanager.cs, as it has problems when accessing
18008 protected methods from a parent class (see test-174.cs).
18010 * attribute.cs (Attribute.ValidateGuid): new method.
18011 (Attribute.Resolve): Use above.
18013 2002-11-19 Miguel de Icaza <miguel@ximian.com>
18015 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
18017 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
18018 handling for enumerations, as we only needed the TypeContainer
18019 functionality to begin with (this is required for the fix below to
18020 work for enums that reference constants in a container class for
18023 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
18025 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
18026 a valid TypeBuilder to perform lookups on.o
18028 * class.cs (InheritableMemberSignatureCompare): Use true in the
18029 call to GetGetMethod and GetSetMethod, because we are comparing
18030 the signature, and we need to get the methods *even* if they are
18033 (PropertyBase.CheckBase): ditto.
18035 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
18036 GotoCase.Resolve): Use Peel on EmpytCasts.
18038 * ecore.cs (EmptyCast): drop child, add Peel method.
18040 2002-11-17 Martin Baulig <martin@ximian.com>
18042 * ecore.cs (EmptyCast.Child): New public property.
18044 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
18045 label resolved to an EmptyCast. Fixes #34162.
18046 (GotoCase.Resolve): Likewise.
18047 (Block.EmitMeta): Likewise.
18049 2002-11-17 Martin Baulig <martin@ximian.com>
18051 * expression.cs (Invocation.BetterConversion): Prefer int over
18052 uint; short over ushort; long over ulong for integer literals.
18053 Use ImplicitConversionExists instead of StandardConversionExists
18054 since we also need to check for user-defined implicit conversions.
18055 Fixes #34165. Added test-173.cs.
18057 2002-11-16 Martin Baulig <martin@ximian.com>
18059 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
18060 with the `true' and `false' literals. Fixes #33151.
18062 2002-11-16 Martin Baulig <martin@ximian.com>
18064 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
18065 October 22nd; don't do the cs1540 check for static members.
18067 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18068 now using our own filter here and doing the cs1540 check again.
18070 2002-11-16 Martin Baulig <martin@ximian.com>
18072 * support.cs (InternalParameters): Don't crash if we don't have
18073 any fixed parameters. Fixes #33532.
18075 2002-11-16 Martin Baulig <martin@ximian.com>
18077 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
18078 when looking up static methods to make this work on Windows.
18081 2002-11-16 Martin Baulig <martin@ximian.com>
18083 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
18084 a setter rather than using PropertyInfo.CanWrite.
18086 2002-11-15 Nick Drochak <ndrochak@gol.com>
18088 * class.cs: Allow acces to block member by subclasses. Fixes build
18091 2002-11-14 Martin Baulig <martin@ximian.com>
18093 * class.cs (Constructor.Emit): Added the extern/block check.
18096 2002-11-14 Martin Baulig <martin@ximian.com>
18098 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
18099 iteration while looking for indexers, this is needed because the
18100 indexer may have a different name in our base classes. Fixed the
18101 error reporting (no indexers at all, not get accessor, no
18102 overloaded match). Fixes bug #33089.
18103 (IndexerAccess.DoResolveLValue): Likewise.
18105 2002-11-14 Martin Baulig <martin@ximian.com>
18107 * class.cs (PropertyBase.CheckBase): Make this work for multiple
18108 indexers. Fixes the first part of bug #33089.
18109 (MethodSignature.InheritableMemberSignatureCompare): Added support
18112 2002-11-13 Ravi Pratap <ravi@ximian.com>
18114 * attribute.cs (Attribute.Resolve): Catch the
18115 NullReferenceException and report it since it isn't supposed to
18118 2002-11-12 Miguel de Icaza <miguel@ximian.com>
18120 * expression.cs (Binary.EmitBranchable): Also handle the cases for
18121 LogicalOr and LogicalAnd that can benefit from recursively
18122 handling EmitBranchable. The code now should be nice for Paolo.
18124 2002-11-08 Miguel de Icaza <miguel@ximian.com>
18126 * typemanager.cs (LookupType): Added a negative-hit hashtable for
18127 the Type lookups, as we perform quite a number of lookups on
18128 non-Types. This can be removed once we can deterministically tell
18129 whether we have a type or a namespace in advance.
18131 But this might require special hacks from our corlib.
18135 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
18136 and double which avoids a conversion from an integer to a double.
18138 * expression.cs: tiny optimization, avoid calling IsConstant,
18139 because it effectively performs the lookup twice.
18141 2002-11-06 Miguel de Icaza <miguel@ximian.com>
18143 But a bogus return here to keep the semantics of the old code
18144 until the Mono runtime is fixed.
18146 * pending.cs (GetMissingInterfaces): New method used to remove all
18147 the interfaces that are already implemented by our parent
18148 classes from the list of pending methods.
18150 * interface.cs: Add checks for calls after ResolveTypeExpr.
18152 2002-11-05 Miguel de Icaza <miguel@ximian.com>
18154 * class.cs (Class.Emit): Report warning 67: event not used if the
18155 warning level is beyond 3.
18157 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
18158 being a NullLiteral.
18160 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
18163 * class.cs (TypeContainer.GetClassBases): Cover a missing code
18164 path that might fail if a type can not be resolved.
18166 * expression.cs (Binary.Emit): Emit unsigned versions of the
18169 * driver.cs: use error 5.
18171 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
18173 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
18175 2002-11-01 Miguel de Icaza <miguel@ximian.com>
18177 * cs-parser.jay (switch_section): A beautiful patch from Martin
18178 Baulig that fixed 33094.
18180 2002-10-31 Miguel de Icaza <miguel@ximian.com>
18182 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
18183 Check whether the base is abstract and report an error if so.
18185 * expression.cs (IndexerAccess.DoResolveLValue,
18186 IndexerAccess.DoResolve): ditto.
18188 (Invocation.DoResolve): ditto.
18190 (Invocation.FullMethodDesc): Improve the report string.
18192 * statement.cs (Block): Eliminate IsVariableDefined as it is
18193 basically just a wrapper for GetVariableInfo.
18195 * ecore.cs (SimpleName): Use new
18197 * support.cs (ReflectionParamter.ParameterType): We unwrap the
18198 type, as we return the actual parameter ref/unref state on a
18201 2002-10-30 Miguel de Icaza <miguel@ximian.com>
18203 * support.cs: Return proper flags REF/OUT fixing the previous
18206 * expression.cs: Reverted last patch, that was wrong. Is_ref is
18207 not used to mean `ref' but `ref or out' in ParameterReference
18209 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
18210 full type signature instead of calling TypeManger.CSharpName
18213 * support.cs (InternalParameters.ParameterDesc): Do not compare
18214 directly to the modflags, because REF/OUT will actually be bitsets
18217 * delegate.cs (VerifyMethod): Check also the modifiers.
18219 * cs-tokenizer.cs: Fix bug where floating point values with an
18220 exponent where a sign was missing was ignored.
18222 * driver.cs: Allow multiple assemblies to be specified in a single
18225 2002-10-28 Miguel de Icaza <miguel@ximian.com>
18227 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
18228 because identifiers after a parenthesis would end up in this kind
18229 of production, and we needed to desamiguate it for having casts
18232 (UserDefinedType *) xxx
18234 2002-10-24 Miguel de Icaza <miguel@ximian.com>
18236 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
18237 we should set on the Bindingflags.NonPublic, but not turn on
18238 private_ok. private_ok controls whether a Private member is
18239 returned (this is chekced on the filter routine), while the
18240 BindingFlags.NonPublic just controls whether private/protected
18241 will be allowed. This fixes the problem part of the problem of
18242 private properties being allowed to be used in derived classes.
18244 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
18245 so we can call the children DoResolveLValue method (this will
18246 properly signal errors on lvalue assignments to base properties)
18248 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
18249 getter are null, and we have a property info, we know that this
18250 happened because the lookup failed, so we report an error 122 for
18251 protection level violation.
18253 We also silently return if setter and getter are null in the
18254 resolve functions, this condition only happens if we have flagged
18255 the error before. This is the other half of the problem.
18257 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
18258 not have accessibility information, that is why we were returning
18259 true in the filter function in typemanager.cs.
18261 To properly report 122 (property is inaccessible because of its
18262 protection level) correctly, we report this error in ResolveAccess
18263 by failing if both the setter and the getter are lacking (ie, the
18266 DoResolve and DoLResolve have been modified to check for both
18267 setter/getter being null and returning silently, the reason being
18268 that I did not want to put the knowledge about this error in upper
18271 int old = Report.Errors;
18272 x = new PropertyExpr (...);
18273 if (old != Report.Errors)
18278 So the property expr is returned, but it is invalid, so the error
18279 will be flagged during the resolve process.
18281 * class.cs: Remove InheritablePropertySignatureCompare from the
18282 class, as we no longer depend on the property signature to compute
18283 whether it is possible to implement a method or not.
18285 The reason is that calling PropertyInfo.GetGetMethod will return
18286 null (in .NET, in Mono it works, and we should change this), in
18287 cases where the Get Method does not exist in that particular
18292 class X { public virtual int A { get { return 1; } } }
18294 class Z : Y { public override int A { get { return 2; } } }
18296 Would fail in Z because the parent (Y) would not have the property
18297 defined. So we avoid this completely now (because the alternative
18298 fix was ugly and slow), and we now depend exclusively on the
18301 (PropertyBase.CheckBase): Use a method-base mechanism to find our
18302 reference method, instead of using the property.
18304 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
18305 routines are gone now.
18307 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
18308 names, they were incorrectly named.
18310 * cs-tokenizer.cs: Return are more gentle token on failure.
18312 * pending.cs (PendingImplementation.InterfaceMethod): This routine
18313 had an out-of-sync index variable, which caused it to remove from
18314 the list of pending methods the wrong method sometimes.
18316 2002-10-22 Miguel de Icaza <miguel@ximian.com>
18318 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
18319 CanWrite, because those refer to this particular instance of the
18320 property, and do not take into account the fact that we can
18321 override single members of a property.
18323 Constructor requires an EmitContext. The resolution process does
18324 not happen here, but we need to compute the accessors before,
18325 because the resolution does not always happen for properties.
18327 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
18328 subclass, before we did not update this flag, but we did update
18331 (GetAccessors): Drop this routine, as it did not work in the
18332 presence of partially overwritten set/get methods.
18334 Notice that this broke the cs1540 detection, but that will require
18337 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18341 * driver.cs: issue a warning instead of an error if we don't support
18342 debugging for the platform. Also ignore a couple of errors that may
18343 arise when trying to write the symbols. Undo my previous patch.
18345 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18347 * driver.cs: ignore /debug switch except for Unix platforms.
18349 2002-10-23 Nick Drochak <ndrochak@gol.com>
18351 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
18353 2002-10-21 Miguel de Icaza <miguel@ximian.com>
18355 * driver.cs: Do not make mcs-debug conditional, so we do not break
18356 builds that use it.
18358 * statement.cs (UsageVector.MergeChildren): I would like Martin to
18359 review this patch. But basically after all the children variables
18360 have been merged, the value of "Breaks" was not being set to
18361 new_breaks for Switch blocks. I think that it should be set after
18362 it has executed. Currently I set this to the value of new_breaks,
18363 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
18364 conservative, but I do not understand this code very well.
18366 I did not break anything in the build, so that is good ;-)
18368 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
18370 2002-10-20 Mark Crichton <crichton@gimp.org>
18372 * cfold.cs: Fixed compile blocker. Really fixed it this time.
18374 2002-10-20 Nick Drochak <ndrochak@gol.com>
18376 * cfold.cs: Fixed compile blocker.
18378 2002-10-20 Miguel de Icaza <miguel@ximian.com>
18380 * driver.cs: I was chekcing the key, not the file.
18382 2002-10-19 Ravi Pratap <ravi@ximian.com>
18384 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
18385 message that we were generating - we just need to silently return
18388 2002-10-19 Miguel de Icaza <miguel@ximian.com>
18390 * class.cs (Event.Define): Change my previous commit, as this
18391 breaks the debugger. This is a temporary hack, as it seems like
18392 the compiler is generating events incorrectly to begin with.
18394 * expression.cs (Binary.ResolveOperator): Added support for
18395 "U operator - (E x, E y)"
18397 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
18400 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
18401 init-only variables, but this path did not take into account that
18402 there might be also instance readonly variables. Correct this
18405 This fixes bug 32253
18407 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
18410 * driver.cs: Change the extension for modules to `netmodule'
18412 * cs-parser.jay: Improved slightly the location tracking for
18413 the debugger symbols.
18415 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
18416 modifiers that were specified instead of the hardcoded value
18417 (FamAndAssem). This was basically ignoring the static modifier,
18418 and others. Fixes 32429.
18420 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
18421 fixed a bug in the process (32476)
18423 * expression.cs (ArrayAccess.EmitAssign): Patch from
18424 hwang_rob@yahoo.ca that fixes bug 31834.3
18426 2002-10-18 Miguel de Icaza <miguel@ximian.com>
18428 * driver.cs: Make the module extension .netmodule.
18430 2002-10-16 Miguel de Icaza <miguel@ximian.com>
18432 * driver.cs: Report an error if the resource file is not found
18433 instead of crashing.
18435 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
18436 false, like Emit does.
18438 2002-10-16 Nick Drochak <ndrochak@gol.com>
18440 * typemanager.cs: Remove unused private member. Also reported mcs
18441 bug to report this as a warning like csc.
18443 2002-10-15 Martin Baulig <martin@gnome.org>
18445 * statement.cs (Statement.Emit): Made this a virtual method; emits
18446 the line number info and calls DoEmit().
18447 (Statement.DoEmit): New protected abstract method, formerly knows
18448 as Statement.Emit().
18450 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
18452 2002-10-11 Miguel de Icaza <miguel@ximian.com>
18454 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
18455 have fixed a remaining problem: not every AddXXXX was adding a
18456 fully qualified name.
18458 Now everyone registers a fully qualified name in the DeclSpace as
18459 being defined instead of the partial name.
18461 Downsides: we are slower than we need to be due to the excess
18462 copies and the names being registered this way.
18464 The reason for this is that we currently depend (on the corlib
18465 bootstrap for instance) that types are fully qualified, because
18466 we dump all the types in the namespace, and we should really have
18467 types inserted into the proper namespace, so we can only store the
18468 basenames in the defined_names array.
18470 2002-10-10 Martin Baulig <martin@gnome.org>
18472 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
18473 from bug #31834, see the bug report for a testcase which is
18476 2002-10-10 Martin Baulig <martin@gnome.org>
18478 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
18479 flow analysis code for this.
18481 * statement.cs (Do, While, For): Tell the flow analysis code about
18483 (FlowBranching.UsageVector): Added support for infinite loops.
18484 (Block.Resolve): Moved the dead code elimination here and use flow
18487 2002-10-09 Miguel de Icaza <miguel@ximian.com>
18489 * class.cs (Field.Define): Catch cycles on struct type
18492 * typemanager.cs (IsUnmanagedtype): Do not recursively check
18493 fields if the fields are static. We only need to check instance
18496 * expression.cs (As.DoResolve): Test for reference type.
18498 * statement.cs (Using.ResolveExpression): Use
18499 ConvertImplicitRequired, not ConvertImplicit which reports an
18501 (Using.ResolveLocalVariableDecls): ditto.
18503 * expression.cs (Binary.ResolveOperator): Report errors in a few
18504 places where we had to.
18506 * typemanager.cs (IsUnmanagedtype): Finish implementation.
18508 2002-10-08 Miguel de Icaza <miguel@ximian.com>
18510 * expression.cs: Use StoreFromPtr instead of extracting the type
18511 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
18513 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
18514 an enumeration value to a System.Enum, but System.Enum is not a
18515 value type, but an class type, so we need to box.
18517 (Expression.ConvertExplicit): One codepath could return
18518 errors but not flag them. Fix this. Fixes #31853
18520 * parameter.cs (Resolve): Do not allow void as a parameter type.
18522 2002-10-06 Martin Baulig <martin@gnome.org>
18524 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
18525 if it's a class type and not a struct. Fixes #31815.
18527 2002-10-06 Martin Baulig <martin@gnome.org>
18529 * statement.cs: Reworked the flow analysis code a bit to make it
18530 usable for dead code elimination.
18532 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18534 * cs-parser.jay: allow empty source files. Fixes bug #31781.
18536 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18538 * expression.cs (ComposedCast.DoResolveType): A quick workaround
18539 to fix the test 165, will investigate deeper.
18541 2002-10-04 Martin Baulig <martin@gnome.org>
18543 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
18544 finally blocks actually work.
18545 (Try.Resolve): We don't need to create a sibling for `finally' if
18546 there is no finally block.
18548 2002-10-04 Martin Baulig <martin@gnome.org>
18550 * class.cs (Constructor.Define): The default accessibility for a
18551 non-default constructor is private, not public.
18553 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18555 * class.cs (Constructor): Make AllowedModifiers public, add
18558 * cs-parser.jay: Perform the modifiers test here, as the
18559 constructor for the Constructor class usually receives a zero
18560 because of the way we create it (first we create, later we
18561 customize, and we were never checking the modifiers).
18563 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
18564 is a version of LookupTypeReflection that includes the type-name
18565 cache. This can be used as a fast path for functions that know
18566 the fully qualified name and are only calling into *.GetType() to
18567 obtain a composed type.
18569 This is also used by TypeManager.LookupType during its type
18572 (LookupType): We now also track the real type name, as sometimes
18573 we can get a quey for the real type name from things like
18574 ComposedCast. This fixes bug 31422.
18576 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
18577 complete type fullname, it does not have to go through the type
18578 resolution system to obtain the composed version of the type (for
18579 obtaining arrays or pointers).
18581 (Conditional.Emit): Use the EmitBoolExpression to
18582 generate nicer code, as requested by Paolo.
18584 (ArrayCreation.CheckIndices): Use the patch from
18585 hwang_rob@yahoo.ca to validate the array initializers.
18587 2002-10-03 Miguel de Icaza <miguel@ximian.com>
18589 * class.cs (ConstructorInitializer.Emit): simplify code by using
18590 Invocation.EmitCall, and at the same time, fix the bugs in calling
18591 parent constructors that took variable arguments.
18593 * ecore.cs (Expression.ConvertNumericExplicit,
18594 Expression.ImplicitNumericConversion): Remove the code that
18595 manually wrapped decimal (InternalTypeConstructor call is now gone
18598 * expression.cs (Cast.TryReduce): Also handle decimal types when
18599 trying to perform a constant fold on the type.
18601 * typemanager.cs (IsUnmanagedtype): Partially implemented.
18603 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
18604 that only turned off an error report, and did nothing else.
18606 2002-10-02 Miguel de Icaza <miguel@ximian.com>
18608 * driver.cs: Handle and ignore /fullpaths
18610 2002-10-01 Miguel de Icaza <miguel@ximian.com>
18612 * expression.cs (Binary.ResolveOperator): Catch the case where
18613 DoNumericPromotions returns true,
18615 (Binary.DoNumericPromotions): Simplify the code, and the tests.
18617 2002-09-27 Miguel de Icaza <miguel@ximian.com>
18619 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
18622 2002-09-26 Miguel de Icaza <miguel@ximian.com>
18624 * ecore.cs (ConvertNumericExplicit): It is not enough that the
18625 conversion exists, but it is also required that the conversion be
18626 performed. This manifested in "(Type64Enum) 2".
18628 * class.cs (TypeManager.AddMethod): The fix is not to change
18629 AddEnum, because that one was using a fully qualified name (every
18630 DeclSpace derivative does), but to change the AddMethod routine
18631 that was using an un-namespaced name. This now correctly reports
18632 the duplicated name.
18634 Revert patch until I can properly fix it. The issue
18635 is that we have a shared Type space across all namespaces
18636 currently, which is wrong.
18638 Options include making the Namespace a DeclSpace, and merge
18639 current_namespace/current_container in the parser.
18641 2002-09-25 Miguel de Icaza <miguel@ximian.com>
18643 * cs-parser.jay: Improve error reporting when we get a different
18644 kind of expression in local_variable_type and
18645 local_variable_pointer_type.
18647 Propagate this to avoid missleading errors being reported.
18649 * ecore.cs (ImplicitReferenceConversion): treat
18650 TypeManager.value_type as a target just like object_type. As
18655 Is valid, and needs to result in the int 1 being boxed before it
18656 is assigned to the value type v.
18658 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
18659 to validate the enumeration name.
18661 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
18662 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
18663 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
18665 * ecore.cs (TryImplicitIntConversion): When doing an
18666 implicit-enumeration-conversion, check if the type is 64-bits and
18667 perform a conversion before passing to EnumConstant.
18669 2002-09-23 Miguel de Icaza <miguel@ximian.com>
18671 * decl.cs (Error_AmbiguousTypeReference); New routine used to
18672 report ambiguous type references. Unlike the MS version, we
18673 report what the ambiguity is. Innovation at work ;-)
18675 (DeclSpace.FindType): Require a location argument to
18676 display when we display an ambiguous error.
18678 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
18680 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
18682 * expression.cs (EmitDynamicInitializers): Apply patch from
18683 hwang_rob@yahoo.ca that fixes the order in which we emit our
18686 2002-09-21 Martin Baulig <martin@gnome.org>
18688 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
18689 delegate takes no arguments.
18691 2002-09-20 Miguel de Icaza <miguel@ximian.com>
18693 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
18696 * expression.cs: Extract the underlying type.
18698 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
18700 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
18702 2002-09-19 Miguel de Icaza <miguel@ximian.com>
18704 * class.cs (TypeContainer.DefineType): We can not use the nice
18705 PackingSize with the size set to 1 DefineType method, because it
18706 will not allow us to define the interfaces that the struct
18709 This completes the fixing of bug 27287
18711 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
18712 means also structs. This fixes part of the problem.
18713 (Expresion.ImplicitReferenceConversionExists): ditto.
18715 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
18716 error if there were no errors reported during the type lookup
18717 process, to avoid duplicates or redundant errors. Without this
18718 you would get an ambiguous errors plus a type not found. We have
18719 beaten the user enough with the first error.
18721 (DeclSparce.FindType): Emit a warning if we have an ambiguous
18724 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
18725 during the resolution process, stop the lookup, this avoids
18726 repeated error reports (same error twice).
18728 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
18730 * typemanager.cs (LookupType): Redo the type lookup code to match
18731 the needs of System.Reflection.
18733 The issue is that System.Reflection requires references to nested
18734 types to begin with a "+" sign instead of a dot. So toplevel
18735 types look like: "NameSpace.TopLevelClass", and nested ones look
18736 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
18739 2002-09-19 Martin Baulig <martin@gnome.org>
18741 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
18742 says that a method always returns or always throws an exception,
18743 don't report the CS0161.
18745 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
18746 set `Returns = new_returns'.
18748 2002-09-19 Martin Baulig <martin@gnome.org>
18750 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
18751 to an enum constant, check for a CS0176.
18753 2002-09-18 Miguel de Icaza <miguel@ximian.com>
18755 * class.cs (TypeContainer.CheckPairedOperators): Now we check
18756 for operators that must be in pairs and report errors.
18758 * ecore.cs (SimpleName.DoResolveType): During the initial type
18759 resolution process, when we define types recursively, we must
18760 check first for types in our current scope before we perform
18761 lookups in the enclosing scopes.
18763 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18765 (Invocation.VerifyArgumentsCompat): Call
18766 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18767 I thought we were supposed to always call this, but there are a
18768 few places in the code where we dont do it.
18770 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18772 * driver.cs: Add support in -linkres and -resource to specify the
18773 name of the identifier.
18775 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18777 * ecore.cs (StandardConversionExists): Sync with the conversion
18778 code: allow anything-* to void* conversions.
18780 (FindMostSpecificSource): Use an Expression argument
18781 instead of a Type, because we might be handed over a Literal which
18782 gets a few more implicit conversions that plain types do not. So
18783 this information was being lost.
18785 Also, we drop the temporary type-holder expression when not
18788 2002-09-17 Martin Baulig <martin@gnome.org>
18790 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18791 this is an explicit interface implementation.
18793 2002-09-17 Martin Baulig <martin@gnome.org>
18795 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18796 different `IndexerName' attributes.
18798 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18799 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18800 virtual CommonResolve().
18802 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18804 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18805 and convert that to the UnderlyingType.
18807 * statement.cs (Foreach.Resolve): Indexers are just like variables
18808 or PropertyAccesses.
18810 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18811 inside quoted strings, we were not doing this before.
18813 2002-09-16 Martin Baulig <martin@gnome.org>
18815 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18816 resolve it. This is needed for the definite assignment check of the
18817 instance expression, fixes bug #29846.
18818 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18820 2002-09-16 Nick Drochak <ndrochak@gol.com>
18822 * parameter.cs: Fix compile error. Cannot reference static member
18823 from an instance object. Is this an mcs bug?
18825 2002-09-14 Martin Baulig <martin@gnome.org>
18827 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18828 multiple times. Fixes bug #30295, added test-166.cs.
18830 2002-09-14 Martin Baulig <martin@gnome.org>
18832 * statement.cs (Block.Emit): Don't emit unreachable code.
18833 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18834 `break' statements.
18835 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18837 2002-09-14 Martin Baulig <martin@gnome.org>
18839 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18842 2002-09-14 Martin Baulig <martin@gnome.org>
18844 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18845 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18846 be false on the ms runtime.
18848 2002-09-13 Martin Baulig <martin@gnome.org>
18850 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18851 the CS0038 error message.
18853 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18855 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18856 constant inside, return it.
18858 2002-09-12 Martin Baulig <martin@gnome.org>
18860 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18861 implicit conversion can be done between enum types.
18863 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18864 check whether an implicit conversion to the current enum's UnderlyingType
18865 exists and report an error if not.
18867 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18868 without debugging support.
18870 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18871 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18873 2002-09-12 Martin Baulig <martin@gnome.org>
18875 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18877 * ecore.cs (IMemberExpr.DeclaringType): New property.
18878 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18879 nonstatic member of an outer type (CS0038).
18881 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18883 * driver.cs: Activate the using-error detector at warning level
18884 4 (at least for MS-compatible APIs).
18886 * namespace.cs (VerifyUsing): Small buglett fix.
18888 * pending.cs (PendingImplementation): pass the container pointer.
18890 * interface.cs (GetMethods): Allow for recursive definition. Long
18891 term, I would like to move every type to support recursive
18892 definitions, not the current ordering mechanism that we have right
18895 The situation is this: Attributes are handled before interfaces,
18896 so we can apply attributes to interfaces. But some attributes
18897 implement interfaces, we will now handle the simple cases
18898 (recursive definitions will just get an error).
18900 * parameter.cs: Only invalidate types at the end if we fail to
18903 2002-09-09 Martin Baulig <martin@gnome.org>
18905 * ecore.cs (PropertyExpr.Emit): Also check for
18906 TypeManager.system_int_array_get_length so this'll also work when
18907 compiling corlib. Fixes #30003.
18909 2002-09-09 Martin Baulig <martin@gnome.org>
18911 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18912 and throw an exception if we can't get the type's size. Fixed #30040,
18915 2002-09-09 Martin Baulig <martin@gnome.org>
18917 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18919 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18920 context. Fixes bug #30027.
18922 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18923 virtual functions. Fixes bug #30043, added test-164.cs.
18925 2002-09-08 Ravi Pratap <ravi@ximian.com>
18927 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18929 2002-09-08 Nick Drochak <ndrochak@gol.com>
18931 * driver.cs: Use an object to get the windows codepage since it's not a
18934 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18936 * statement.cs (For.Emit): for infinite loops (test == null)
18937 return whether there is a break inside, not always "true".
18939 * namespace.cs (UsingEntry): New struct to hold the name of the
18940 using definition, the location where it is defined, and whether it
18941 has been used in a successful type lookup.
18943 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18948 2002-09-06 Ravi Pratap <ravi@ximian.com>
18950 * attribute.cs : Fix incorrect code which relied on catching
18951 a NullReferenceException to detect a null being passed in
18952 where an object was expected.
18954 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18956 * statement.cs (Try): flag the catch variable as assigned
18958 * expression.cs (Cast): Simplified by using ResolveType instead of
18959 manually resolving.
18961 * statement.cs (Catch): Fix bug by using ResolveType.
18963 2002-09-06 Ravi Pratap <ravi@ximian.com>
18965 * expression.cs (BetterConversion): Special case for when we have
18966 a NullLiteral as the argument and we have to choose between string
18967 and object types - we choose string the way csc does.
18969 * attribute.cs (Attribute.Resolve): Catch the
18970 NullReferenceException and report error #182 since the Mono
18971 runtime no more has the bug and having this exception raised means
18972 we tried to select a constructor which takes an object and is
18975 2002-09-05 Ravi Pratap <ravi@ximian.com>
18977 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18978 message (1502, 1503) when we can't locate a method after overload
18979 resolution. This is much more informative and closes the bug
18982 * interface.cs (PopulateMethod): Return if there are no argument
18983 types. Fixes a NullReferenceException bug.
18985 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18986 expressions too. Previously we were checking only in one place for
18987 positional arguments leaving out named arguments.
18989 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18990 type to the enum type is not allowed. Remove code corresponding to
18993 (ConvertNumericExplicit): Allow explicit conversions from
18994 the underlying type to enum type. This precisely follows the spec
18995 and closes a bug filed by Gonzalo.
18997 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19000 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
19002 2002-09-03 Miguel de Icaza <miguel@ximian.com>
19004 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
19005 it was important that we stored the right value after the
19006 reduction in `converted'.
19008 2002-09-04 Martin Baulig <martin@gnome.org>
19010 * location.cs (Location.SymbolDocument): Use full pathnames for the
19013 2002-08-30 Miguel de Icaza <miguel@ximian.com>
19015 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
19016 of the expression resolve mechanism, because that will catch the
19017 SimpleName error failures.
19019 (Conditional): If we can not resolve the
19020 expression, return, do not crash.
19022 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19025 (location): display token name instead of its number.
19027 2002-08-28 Martin Baulig <martin@gnome.org>
19029 * expression.cs (Binary.ResolveOperator): Don't silently return
19030 but return an error if an operator cannot be applied between two
19033 2002-08-28 Martin Baulig <martin@gnome.org>
19035 * class.cs (Constructor.Define): Set the permission attributes
19036 correctly instead of making all constructors public.
19038 2002-08-28 Martin Baulig <martin@gnome.org>
19040 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
19041 for private members before reporting a CS0103; if we find anything,
19044 2002-08-28 Martin Baulig <martin@gnome.org>
19046 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
19047 to check whether `closure_start_type == closure_invocation_type',
19048 we also need to check whether `m.DeclaringType == closure_invocation_type'
19049 before bypassing the permission checks. We might be accessing
19050 protected/private members from the base class.
19051 (TypeManager.RealMemberLookup): Only set private_ok if private
19052 members were requested via BindingFlags.NonPublic.
19054 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
19056 * expression.cs (MemberAccess.ResolveMemberAccess): Set
19057 MethodGroupExpr.IsExplicitImpl if appropriate.
19058 (Invocation.DoResolve): Don't report the CS0120 for explicit
19059 interface implementations.
19061 2002-08-27 Martin Baulig <martin@gnome.org>
19063 * expression.cs (Invocation.DoResolve): If this is a static
19064 method and we don't have an InstanceExpression, we must report
19067 2002-08-25 Martin Baulig <martin@gnome.org>
19069 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
19070 `==' between a valuetype and an object.
19072 2002-08-25 Miguel de Icaza <miguel@ximian.com>
19074 * ecore.cs (TypeExpr): Provide a ToString method.
19076 2002-08-24 Martin Baulig <martin@gnome.org>
19078 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
19079 now called proggie.dbg and it's a binary file.
19081 2002-08-23 Martin Baulig <martin@gnome.org>
19083 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
19085 2002-08-23 Martin Baulig <martin@gnome.org>
19087 * struct.cs (MyStructInfo.ctor): Make this work with empty
19088 structs; it's not allowed to use foreach() on null.
19090 2002-08-23 Martin Baulig <martin@gnome.org>
19092 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
19093 writer the full pathname of the generated assembly.
19095 2002-08-23 Martin Baulig <martin@gnome.org>
19097 * statements.cs (FlowBranching.UsageVector.MergeChildren):
19098 A `finally' block never returns or breaks; improved handling of
19101 2002-08-23 Martin Baulig <martin@gnome.org>
19103 * statement.cs (Throw.Resolve): Allow `throw null'.
19105 2002-08-23 Martin Baulig <martin@gnome.org>
19107 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
19108 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
19109 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
19110 MemberLookup would return a wrong event if this is an explicit
19111 interface implementation and the class has an event with the same
19114 2002-08-23 Martin Baulig <martin@gnome.org>
19116 * statement.cs (Block.AddChildVariableNames): New public method.
19117 (Block.AddChildVariableName): Likewise.
19118 (Block.IsVariableNameUsedInChildBlock): Likewise.
19119 (Block.AddVariable): Check whether a variable name has already
19120 been used in a child block.
19122 * cs-parser.jay (declare_local_variables): Mark all variable names
19123 from the current block as being used in a child block in the
19126 2002-08-23 Martin Baulig <martin@gnome.org>
19128 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
19129 find the symbol writer.
19131 * driver.cs: csc also allows the arguments to /define being
19132 separated by commas, not only by semicolons.
19134 2002-08-23 Martin Baulig <martin@gnome.org>
19136 * interface.cs (Interface.GetMembers): Added static check for events.
19138 2002-08-15 Martin Baulig <martin@gnome.org>
19140 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
19141 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
19143 * ecore.cs (Expression.MemberLookup): Added documentation and explained
19144 why the MethodData.EmitDestructor() change was necessary.
19146 2002-08-20 Martin Baulig <martin@gnome.org>
19148 * class.cs (TypeContainer.FindMembers): Added static check for events.
19150 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
19152 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
19153 use Type.GetEvents(), not Type.FindMembers().
19155 2002-08-20 Martin Baulig <martin@gnome.org>
19157 * decl.cs (MemberCache): Added a special method cache which will
19158 be used for method-only searched. This ensures that a method
19159 search will return a MethodInfo with the correct ReflectedType for
19162 2002-08-20 Martin Baulig <martin@gnome.org>
19164 * decl.cs (DeclSpace.FindMembers): Made this public.
19166 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19168 * delegate.cs: fixed build on windows.
19169 [FIXME: Filed as bug #29150: MCS must report these errors.]
19171 2002-08-19 Ravi Pratap <ravi@ximian.com>
19173 * ecore.cs (StandardConversionExists): Return a false
19174 if we are trying to convert the void type to anything else
19175 since that is not allowed.
19177 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
19178 we flag error 70 in the event an event is trying to be accessed
19179 directly from outside the declaring type.
19181 2002-08-20 Martin Baulig <martin@gnome.org>
19183 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
19184 MemberCache from typemanager.cs to decl.cs.
19186 2002-08-19 Martin Baulig <martin@gnome.org>
19188 * class.cs (TypeContainer): Implement IMemberContainer.
19189 (TypeContainer.DefineMembers): Create the MemberCache.
19190 (TypeContainer.FindMembers): Do better BindingFlags checking; only
19191 return public members if BindingFlags.Public was given, check
19192 whether members are static.
19194 2002-08-16 Martin Baulig <martin@gnome.org>
19196 * decl.cs (DeclSpace.Define): Splitted this in Define and
19197 DefineMembers. DefineMembers is called first and initializes the
19200 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
19201 DefineMembers() on all our DeclSpaces.
19203 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
19204 but call DefineMembers() on all nested interfaces. We call their
19205 Define() in our new Define() function.
19207 * interface.cs (Interface): Implement IMemberContainer.
19208 (Interface.Define): Moved all code except the attribute stuf to
19210 (Interface.DefineMembers): Initialize the member cache.
19212 * typemanager.cs (IMemberFinder): Removed this interface, we don't
19213 need this anymore since we can use MemberCache.FindMembers directly.
19215 2002-08-19 Martin Baulig <martin@gnome.org>
19217 * typemanager.cs (MemberCache): When creating the cache for an
19218 interface type, add all inherited members.
19219 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
19220 to `out bool used_cache' and documented it.
19221 (TypeManager.MemberLookup): If we already used the cache in the first
19222 iteration, we don't need to do the interfaces check.
19224 2002-08-19 Martin Baulig <martin@gnome.org>
19226 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
19227 here from IMemberFinder and don't implement this interface anymore.
19228 (DeclSpace.MemberCache): Moved here from IMemberFinder.
19230 * typemanager.cs (IMemberFinder): This interface is now only used by
19231 classes which actually support the member cache.
19232 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
19233 since we only put DeclSpaces into this Hashtable.
19234 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
19235 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
19237 2002-08-16 Martin Baulig <martin@gnome.org>
19239 * typemanager.cs (ICachingMemberFinder): Removed.
19240 (IMemberFinder.MemberCache): New property.
19241 (TypeManager.FindMembers): Merged this with RealFindMembers().
19242 This function will never be called from TypeManager.MemberLookup()
19243 so we can't use the cache here, just the IMemberFinder.
19244 (TypeManager.MemberLookup_FindMembers): Check whether the
19245 IMemberFinder has a MemberCache and call the cache's FindMembers
19247 (MemberCache): Rewrote larger parts of this yet another time and
19248 cleaned it up a bit.
19250 2002-08-15 Miguel de Icaza <miguel@ximian.com>
19252 * driver.cs (LoadArgs): Support quoting.
19254 (Usage): Show the CSC-like command line arguments.
19256 Improved a few error messages.
19258 2002-08-15 Martin Baulig <martin@gnome.org>
19260 * typemanager.cs (IMemberContainer.Type): New property.
19261 (IMemberContainer.IsInterface): New property.
19263 The following changes are conditional to BROKEN_RUNTIME, which is
19264 defined at the top of the file.
19266 * typemanager.cs (MemberCache.MemberCache): Don't add the base
19267 class'es members, but add all members from TypeHandle.ObjectType
19268 if we're an interface.
19269 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
19270 is the current type.
19271 (MemberCache.CacheEntry.Container): Removed this field.
19272 (TypeHandle.GetMembers): Include inherited members.
19274 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19276 * typemanager.cs: fixed compilation and added a comment on a field that
19279 2002-08-15 Martin Baulig <martin@gnome.org>
19281 * class.cs (ConstructorInitializer.Resolve): In the
19282 Expression.MemberLookup call, use the queried_type as
19285 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
19286 declared' attribute, it's always true.
19287 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
19288 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
19289 temporary wrapper for FindMembers which tells MemberLookup whether
19290 members from the base classes are included in the return value.
19291 This will go away soon.
19292 (TypeManager.MemberLookup): Use this temporary hack here; once the
19293 new MemberCache is completed, we don't need to do the DeclaredOnly
19294 looping here anymore since the MemberCache will take care of this.
19295 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
19296 (MemberCache): When creating the MemberCache for a class, get
19297 members from the current class and all its base classes.
19298 (MemberCache.CacheEntry.Container): New field. This is a
19299 temporary hack until the Mono runtime is fixed to distinguish
19300 between ReflectedType and DeclaringType. It allows us to use MCS
19301 with both the MS runtime and the unfixed Mono runtime without
19302 problems and without accecting performance.
19303 (MemberCache.SearchMembers): The DeclaredOnly looping from
19304 TypeManager.MemberLookup is now done here.
19306 2002-08-14 Martin Baulig <martin@gnome.org>
19308 * statement.cs (MyStructInfo.MyStructInfo): Don't call
19309 Type.GetFields on dynamic types but get the fields from the
19310 corresponding TypeContainer.
19311 (MyStructInfo.GetStructInfo): Added check for enum types.
19313 * typemanager.cs (MemberList.IsSynchronized): Implemented.
19314 (MemberList.SyncRoot): Implemented.
19315 (TypeManager.FilterWithClosure): No need to check permissions if
19316 closure_start_type == closure_invocation_type, don't crash if
19317 closure_invocation_type is null.
19319 2002-08-13 Martin Baulig <martin@gnome.org>
19321 Rewrote TypeContainer.FindMembers to use a member cache. This
19322 gives us a speed increase of about 35% for the self-hosting MCS
19323 build and of about 15-20% for the class libs (both on GNU/Linux).
19325 * report.cs (Timer): New class to get enhanced profiling. This
19326 whole class is "TIMER" conditional since it remarkably slows down
19329 * class.cs (MemberList): New class. This is an IList wrapper
19330 which we're now using instead of passing MemberInfo[]'s around to
19331 avoid copying this array unnecessarily.
19332 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
19333 (ICachingMemberFinder, IMemberContainer): New interface.
19334 (TypeManager.FilterWithClosure): If `criteria' is null, the name
19335 has already been checked, otherwise use it for the name comparision.
19336 (TypeManager.FindMembers): Renamed to RealMemberFinder and
19337 provided wrapper which tries to use ICachingMemberFinder.FindMembers
19338 if possible. Returns a MemberList, not a MemberInfo [].
19339 (TypeHandle): New class, implements IMemberContainer. We create
19340 one instance of this class per type, it contains a MemberCache
19341 which is used to do the member lookups.
19342 (MemberCache): New class. Each instance of this class contains
19343 all members of a type and a name-based hash table.
19344 (MemberCache.FindMembers): This is our new member lookup
19345 function. First, it looks up all members of the requested name in
19346 the hash table. Then, it walks this list and sorts out all
19347 applicable members and returns them.
19349 2002-08-13 Martin Baulig <martin@gnome.org>
19351 In addition to a nice code cleanup, this gives us a performance
19352 increase of about 1.4% on GNU/Linux - not much, but it's already
19353 half a second for the self-hosting MCS compilation.
19355 * typemanager.cs (IMemberFinder): New interface. It is used by
19356 TypeManager.FindMembers to call FindMembers on a TypeContainer,
19357 Enum, Delegate or Interface.
19358 (TypeManager.finder_to_member_finder): New PtrHashtable.
19359 (TypeManager.finder_to_container): Removed.
19360 (TypeManager.finder_to_delegate): Removed.
19361 (TypeManager.finder_to_interface): Removed.
19362 (TypeManager.finder_to_enum): Removed.
19364 * interface.cs (Interface): Implement IMemberFinder.
19366 * delegate.cs (Delegate): Implement IMemberFinder.
19368 * enum.cs (Enum): Implement IMemberFinder.
19370 * class.cs (TypeContainer): Implement IMemberFinder.
19372 2002-08-12 Martin Baulig <martin@gnome.org>
19374 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
19376 2002-08-12 Martin Baulig <martin@gnome.org>
19378 * ecore.cs (ITypeExpression): New interface for expressions which
19380 (TypeExpression): Renamed to TypeLookupExpression.
19381 (Expression.DoResolve): If we're doing a types-only lookup, the
19382 expression must implement the ITypeExpression interface and we
19383 call DoResolveType() on it.
19384 (SimpleName): Implement the new ITypeExpression interface.
19385 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
19386 hack, the situation that we're only looking up types can't happen
19387 anymore when this method is called. Moved the type lookup code to
19388 DoResolveType() and call it.
19389 (SimpleName.DoResolveType): This ITypeExpression interface method
19390 is now doing the types-only lookup.
19391 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
19392 (ResolveFlags): Added MaskExprClass.
19394 * expression.cs (MemberAccess): Implement the ITypeExpression
19396 (MemberAccess.DoResolve): Added support for a types-only lookup
19397 when we're called via ITypeExpression.DoResolveType().
19398 (ComposedCast): Implement the ITypeExpression interface.
19400 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
19401 Expression.Resolve() with ResolveFlags.Type instead.
19403 2002-08-12 Martin Baulig <martin@gnome.org>
19405 * interface.cs (Interface.Define): Apply attributes.
19407 * attribute.cs (Attribute.ApplyAttributes): Added support for
19408 interface attributes.
19410 2002-08-11 Martin Baulig <martin@gnome.org>
19412 * statement.cs (Block.Emit): Only check the "this" variable if we
19413 do not always throw an exception.
19415 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
19416 whether the property has a set accessor.
19418 2002-08-11 Martin Baulig <martin@gnome.org>
19420 Added control flow analysis support for structs.
19422 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
19423 with control flow analysis turned off.
19424 (IVariable): New interface.
19425 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
19426 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
19427 (FieldExpr.DoResolve): Resolve the instance expression with flow
19428 analysis turned off and do the definite assignment check after the
19429 resolving when we know what the expression will resolve to.
19431 * expression.cs (LocalVariableReference, ParameterReference):
19432 Implement the new IVariable interface, only call the flow analysis
19433 code if ec.DoFlowAnalysis is true.
19434 (This): Added constructor which takes a Block argument. Implement
19435 the new IVariable interface.
19436 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
19437 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
19438 This does the definite assignment checks for struct members.
19440 * class.cs (Constructor.Emit): If this is a non-static `struct'
19441 constructor which doesn't have any initializer, call
19442 Block.AddThisVariable() to tell the flow analysis code that all
19443 struct elements must be initialized before control returns from
19446 * statement.cs (MyStructInfo): New public class.
19447 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
19448 argument to this indexer. If non-zero, check an individual struct
19449 member, not the whole struct.
19450 (FlowBranching.CheckOutParameters): Check struct members.
19451 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
19452 overloaded versions of these methods which take an additional
19453 `int field_idx' argument to check struct members.
19454 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
19455 overloaded versions of these methods which take an additional
19456 `string field_name' argument to check struct member.s
19457 (VariableInfo): Implement the IVariable interface.
19458 (VariableInfo.StructInfo): New public property. Returns the
19459 MyStructInfo instance of the variable if it's a struct or null.
19460 (Block.AddThisVariable): New public method. This is called from
19461 Constructor.Emit() for non-static `struct' constructor which do
19462 not have any initializer. It creates a special variable for the
19463 "this" instance variable which will be checked by the flow
19464 analysis code to ensure that all of the struct's fields are
19465 initialized before control returns from the constructor.
19466 (UsageVector): Added support for struct members. If a
19467 variable/parameter is a struct with N members, we reserve a slot
19468 in the usage vector for each member. A struct is considered fully
19469 initialized if either the struct itself (slot 0) or all its
19470 members are initialized.
19472 2002-08-08 Martin Baulig <martin@gnome.org>
19474 * driver.cs (Driver.MainDriver): Only report an error CS5001
19475 if there were no compilation errors.
19477 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
19478 `UnsafeContext' property to determine whether the parent is in
19479 unsafe context rather than checking the parent's ModFlags:
19480 classes nested in an unsafe class are unsafe as well.
19482 2002-08-08 Martin Baulig <martin@gnome.org>
19484 * statement.cs (UsageVector.MergeChildren): Distinguish between
19485 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
19486 we return. Added test17() and test18() to test-154.cs.
19488 2002-08-08 Martin Baulig <martin@gnome.org>
19490 * typemanager.cs (TypeManager.FilterWithClosure): If we have
19491 Family access, make sure the invoking type isn't a subclass of the
19492 queried type (that'd be a CS1540).
19494 * ecore.cs (Expression.MemberLookup): Added overloaded version of
19495 this method which takes an additional `Type invocation_type'.
19497 * expression.cs (BaseAccess.DoResolve): Use the base type as
19498 invocation and query type.
19499 (MemberAccess.DoResolve): If the lookup failed and we're about to
19500 report a CS0122, try a lookup with the ec.ContainerType - if this
19501 succeeds, we must report a CS1540.
19503 2002-08-08 Martin Baulig <martin@gnome.org>
19505 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
19506 (MethodGroupExpr): Implement the IMemberExpr interface.
19508 * expression (MemberAccess.ResolveMemberAccess): No need to have
19509 any special code for MethodGroupExprs anymore, they're now
19512 2002-08-08 Martin Baulig <martin@gnome.org>
19514 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
19515 Family, FamANDAssem and FamORAssem permissions.
19516 (TypeManager.IsSubclassOrNestedChildOf): New public method.
19518 2002-08-08 Martin Baulig <martin@gnome.org>
19520 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
19521 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
19524 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
19526 * driver.cs: implemented /resource option to embed managed resources.
19528 2002-08-07 Martin Baulig <martin@gnome.org>
19530 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
19531 (FieldBase.HasFieldInitializer): New public property.
19532 (FieldBase.GetInitializerExpression): New public method. Resolves and
19533 returns the field initializer and makes sure it is only resolved once.
19534 (TypeContainer.EmitFieldInitializers): Call
19535 FieldBase.GetInitializerExpression to get the initializer, this ensures
19536 that it isn't resolved multiple times.
19538 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
19539 the resolving process (SimpleName/MemberLookup) that we're currently
19540 emitting a field initializer (which must not access any instance members,
19541 this is an error CS0236).
19543 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
19544 argument, if the `IsFieldInitializer' flag is set, we must report and
19545 error CS0236 and not an error CS0120.
19547 2002-08-07 Martin Baulig <martin@gnome.org>
19549 * ecore.cs (IMemberExpr): New public interface.
19550 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
19551 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
19552 if the expression is an IMemberExpr.
19554 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
19555 to be null, implicitly default to `this' if we're non-static in
19556 this case. Simplified the code a lot by using the new IMemberExpr
19557 interface. Also fixed bug #28176 here.
19559 2002-08-06 Martin Baulig <martin@gnome.org>
19561 * cs-parser.jay (SimpleLookup): Removed. We need to create
19562 ParameterReferences during semantic analysis so that we can do a
19563 type-only search when resolving Cast, TypeOf and SizeOf.
19564 (block): Pass the `current_local_parameters' to the Block's
19567 * class.cs (ConstructorInitializer): Added `Parameters parameters'
19568 argument to the constructor.
19569 (ConstructorInitializer.Resolve): Create a temporary implicit
19570 block with the parameters.
19572 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
19573 references here if we aren't doing a type-only search.
19575 * statement.cs (Block): Added constructor which takes a
19576 `Parameters parameters' argument.
19577 (Block.Parameters): New public property.
19579 * support.cs (InternalParameters.Parameters): Renamed `parameters'
19580 to `Parameters' and made it public readonly.
19582 2002-08-06 Martin Baulig <martin@gnome.org>
19584 * ecore.cs (Expression.Warning): Made this public as well.
19586 * report.cs (Report.Debug): Print the contents of collections.
19588 2002-08-06 Martin Baulig <martin@gnome.org>
19590 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
19591 used to tell Resolve() which kinds of expressions it may return.
19592 (Expression.Resolve): Added overloaded version of this method which
19593 takes a `ResolveFlags flags' argument. This can be used to tell
19594 Resolve() which kinds of expressions it may return. Reports a
19596 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
19597 ResolveFlags.SimpleName.
19598 (Expression.Error118): Added overloaded version of this method which
19599 takes a `ResolveFlags flags' argument. It uses the flags to determine
19600 which kinds of expressions are allowed.
19602 * expression.cs (Argument.ResolveMethodGroup): New public method.
19603 Resolves an argument, but allows a MethodGroup to be returned.
19604 This is used when invoking a delegate.
19606 * TODO: Updated a bit.
19608 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19610 Fixed compilation with csc.
19612 * ecore.cs: Expression.Error made public. Is this correct? Should
19613 Warning be made public too?
19615 * expression.cs: use ea.Location instead of ea.loc.
19616 [FIXME: Filed as bug #28607: MCS must report these errors.]
19618 2002-08-06 Martin Baulig <martin@gnome.org>
19620 * ecore.cs (Expression.loc): Moved the location here instead of
19621 duplicating it in all derived classes.
19622 (Expression.Location): New public property.
19623 (Expression.Error, Expression.Warning): Made them non-static and
19624 removed the location argument.
19625 (Expression.Warning): Added overloaded version which takes an
19626 `int level' argument.
19627 (Expression.Error118): Make this non-static and removed the
19628 expression and location arguments.
19629 (TypeExpr): Added location argument to the constructor.
19631 * expression.cs (StaticCallExpr): Added location argument to
19633 (Indirection, PointerArithmetic): Likewise.
19634 (CheckedExpr, UnCheckedExpr): Likewise.
19635 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
19636 (StringPtr): Likewise.
19639 2002-08-05 Martin Baulig <martin@gnome.org>
19641 * expression.cs (BaseAccess.DoResolve): Actually report errors.
19643 * assign.cs (Assign.DoResolve): Check whether the source
19644 expression is a value or variable.
19646 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
19647 while resolving the corresponding blocks.
19649 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
19650 an error, don't silently return null.
19652 * statement.cs (Block.AddVariable): Do the error reporting here
19653 and distinguish between CS0128 and CS0136.
19654 (Block.DoResolve): Report all unused labels (warning CS0164).
19655 (LabeledStatement): Pass the location to the constructor.
19656 (LabeledStatement.HasBeenReferenced): New property.
19657 (LabeledStatement.Resolve): Set it to true here.
19659 * statement.cs (Return.Emit): Return success even after reporting
19660 a type mismatch error (CS0126 or CS0127), this is what csc does and
19661 it avoids confusing the users with any consecutive errors.
19663 2002-08-05 Martin Baulig <martin@gnome.org>
19665 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
19667 * const.cs (Const.LookupConstantValue): Catch circular definitions.
19669 * expression.cs (MemberAccess.DoResolve): Silently return if an
19670 error has already been reported.
19672 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
19673 error has already been reported.
19675 2002-08-05 Martin Baulig <martin@gnome.org>
19677 * statement.cs (UsageVector): Only initialize the `parameters'
19678 vector if we actually have any "out" parameters.
19680 2002-08-05 Martin Baulig <martin@gnome.org>
19682 * expression.cs (Binary.ResolveOperator): When combining delegates,
19683 they must have the same type.
19685 2002-08-05 Martin Baulig <martin@gnome.org>
19687 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
19688 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
19689 work with the ms runtime and we also don't need it: if we're a
19690 PropertyBuilder and not in the `indexer_arguments' hash, then we
19691 are a property and not an indexer.
19693 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
19694 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
19695 since the latter one doesn't work with the ms runtime.
19697 2002-08-03 Martin Baulig <martin@gnome.org>
19699 Fixed bugs #27998 and #22735.
19701 * class.cs (Method.IsOperator): New public field.
19702 (Method.CheckBase): Report CS0111 if there's already a method
19703 with the same parameters in the current class. Report CS0508 when
19704 attempting to change the return type of an inherited method.
19705 (MethodData.Emit): Report CS0179 if a method doesn't have a body
19706 and it's not marked abstract or extern.
19707 (PropertyBase): New abstract base class for Property and Indexer.
19708 (PropertyBase.CheckBase): Moved here from Property and made it work
19710 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
19711 the same so we can reuse it there.
19712 (Property, Indexer): Derive from PropertyBase.
19713 (MethodSignature.inheritable_property_signature_filter): New delegate
19714 to find properties and indexers.
19716 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
19717 argument and improved error reporting.
19719 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
19720 EmptyReadOnlyParameters and made it a property.
19722 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
19723 version of this method which takes a `PropertyInfo indexer'.
19724 (TypeManager.RegisterIndexer): New method.
19726 * class.cs: Added myself as author of this file :-)
19728 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19730 * class.cs: fixed compilation on windoze.
19732 2002-08-03 Martin Baulig <martin@gnome.org>
19734 * interface.cs (Interface.GetInterfaceBases): Check whether all
19735 base interfaces are at least as accessible than the current one.
19737 * class.cs (TypeContainer.GetClassBases): Check whether base types
19738 are at least as accessible than the current type.
19739 (TypeContainer.AsAccessible): Implemented and made non-static.
19740 (MemberBase.CheckParameters): Report errors if the accessibility
19743 * delegate.cs (Delegate.Delegate): The default visibility is
19744 internal for top-level types and private for nested types.
19745 (Delegate.Define): Report errors if the accessibility checks fail.
19747 * enum.cs (Enum.Enum): The default visibility is internal for
19748 top-level types and private for nested types.
19749 (Enum.DefineType): Compute the correct visibility.
19751 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
19752 function which takes a `bool is_toplevel' instead of a TypeContainer.
19754 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
19757 2002-08-02 Martin Baulig <martin@gnome.org>
19759 * expression.cs (LocalVariableReferenc): Added constructor which
19760 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
19761 (LocalVariableReference.IsReadOnly): New property.
19762 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19763 variable is readonly, use our own readonly flag to do this; you can
19764 use the new constructor to get a writable reference to a read-only
19767 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19768 reference to the local variable.
19770 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19772 * rootcontext.cs (ResolveCore): Also include System.Exception
19774 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19775 we reach an EmptyStatement.
19777 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19780 * expression.cs (Binary.ResolveOperator): Check error result in
19783 use brtrue/brfalse directly and avoid compares to null.
19785 2002-08-02 Martin Baulig <martin@gnome.org>
19787 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19788 Fixes bug #28407, added test-155.cs.
19790 2002-08-01 Martin Baulig <martin@gnome.org>
19792 * class.cs (Event.EmitDefaultMethod): Make this work with static
19793 events. Fixes #28311, added verify-3.cs.
19795 2002-08-01 Martin Baulig <martin@gnome.org>
19797 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19798 `is_disposable' fields.
19799 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19800 `hm.is_disposable' if we're using the collection pattern.
19801 (Foreach.EmitCollectionForeach): Use the correct type for the
19802 enumerator's local variable, only emit the try/finally block if
19803 necessary (fixes #27713).
19805 2002-08-01 Martin Baulig <martin@gnome.org>
19807 * ecore.cs (Expression.report118): Renamed to Error118 and made
19810 * statement.cs (Throw.Resolve): Check whether the expression is of
19811 the correct type (CS0118) and whether the type derives from
19812 System.Exception (CS0155).
19813 (Catch.Resolve): New method. Do the type lookup here and check
19814 whether it derives from System.Exception (CS0155).
19815 (Catch.CatchType, Catch.IsGeneral): New public properties.
19817 * typemanager.cs (TypeManager.exception_type): Added.
19819 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19821 * driver.cs: Updated About function.
19823 2002-07-31 Martin Baulig <martin@gnome.org>
19825 Implemented Control Flow Analysis.
19827 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19828 (EmitContext.CurrentBranching): Added.
19829 (EmitContext.StartFlowBranching): Added.
19830 (EmitContext.EndFlowBranching): Added.
19831 (EmitContext.KillFlowBranching): Added.
19832 (EmitContext.IsVariableAssigned): Added.
19833 (EmitContext.SetVariableAssigned): Added.
19834 (EmitContext.IsParameterAssigned): Added.
19835 (EmitContext.SetParameterAssigned): Added.
19836 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19837 Added control flow analysis stuff here.
19839 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19840 resolve the expression as lvalue.
19841 (LocalVariableReference.DoResolve): Check whether the variable has
19842 already been assigned.
19843 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19844 the parameter as assigned here.
19845 (ParameterReference.DoResolve): Check whether the parameter has already
19847 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19848 expression as lvalue.
19850 * statement.cs (FlowBranching): New class for the flow analysis code.
19851 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19852 (LabeledStatement.IsDefined): New public property.
19853 (LabeledStatement.AddUsageVector): New public method to tell flow
19854 analyis that the label may be reached via a forward jump.
19855 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19857 (VariableInfo.Number): New public field. This is used by flow analysis
19858 to number all locals of a block.
19859 (Block.CountVariables): New public property. This is the number of
19860 local variables in this block (including the locals from all parent
19862 (Block.EmitMeta): Number all the variables.
19864 * statement.cs: Added flow analysis support to all classes.
19866 2002-07-31 Martin Baulig <martin@gnome.org>
19868 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19869 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19870 then use this argument.
19872 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19874 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19875 use this to specify /define options.
19877 2002-07-29 Martin Baulig <martin@gnome.org>
19879 * statement.cs (Fixed): Moved all code that does variable lookups
19880 and resolvings from Emit to Resolve.
19882 * statement.cs (For): Moved all code that does variable lookups
19883 and resolvings from Emit to Resolve.
19885 * statement.cs (Using): Moved all code that does variable lookups
19886 and resolvings from Emit to Resolve.
19888 2002-07-29 Martin Baulig <martin@gnome.org>
19890 * attribute.cs (Attribute.Resolve): Explicitly catch a
19891 System.NullReferenceException when creating the
19892 CustromAttributeBuilder and report a different warning message.
19894 2002-07-29 Martin Baulig <martin@gnome.org>
19896 * support.cs (ParameterData.ParameterName): Added method to
19897 get the name of a parameter.
19899 * typemanager.cs (TypeManager.IsValueType): New public method.
19901 2002-07-29 Martin Baulig <martin@gnome.org>
19903 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19904 is a flag which specifies that it's either ref or out.
19905 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19906 the out parameter to `out Parameter.Modifier mod', also set the
19907 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19909 * support.cs (InternalParameters.ParameterModifier): Distinguish
19910 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19911 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19913 * expression.cs (Argument.GetParameterModifier): Distinguish
19914 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19915 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19917 2002-07-29 Martin Baulig <martin@gnome.org>
19919 * expression.cs (ParameterReference.ParameterReference): Added
19920 `Location loc' argument to the constructor.
19922 * cs-parser.jay: Pass location to ParameterReference.
19924 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19926 * statement.cs (Try): Initialize the location.
19928 * cs-parser.jay: pass location to Try.
19930 * expression.cs (Unary.Reduce): Change the prototype to return
19931 whether a constant fold could be performed or not. The result is
19932 returned in an out parameters. In the case of Indirection and
19933 AddressOf, we want to perform the full tests.
19935 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19937 * statement.cs (Statement.Emit): Flag dead code.
19939 2002-07-27 Andrew Birkett <andy@nobugs.org>
19941 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19943 2002-07-27 Martin Baulig <martin@gnome.org>
19945 * class.cs (MethodData.Define): Put back call to
19946 TypeManager.AddMethod(), accidentally commented this out.
19948 * report.cs (Debug): New public method to print debugging information,
19949 this is `[Conditional ("DEBUG")]'.
19951 2002-07-26 Martin Baulig <martin@gnome.org>
19953 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19954 (switch_statement): Push the current_block to the switch_stack and
19955 pop it again when we're done with the switch.
19956 (switch_section): The new block is a child of the current_block.
19957 Fixes bug #24007, added test-152.cs.
19959 2002-07-27 Martin Baulig <martin@gnome.org>
19961 * expression.cs (Invocation.EmitArguments): When calling a varargs
19962 function with only its fixed arguments, we need to pass an empty
19965 2002-07-27 Martin Baulig <martin@gnome.org>
19967 Mono 0.13 has been released.
19969 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19971 * driver.cs: Rename --resource to --linkres, because that is what
19972 we do currently, we dont support --resource yet.
19974 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19976 2002-07-25 Martin Baulig <martin@gnome.org>
19978 * class.cs (MethodData): New public class. This is a `method builder'
19979 class for a method or one accessor of a Property/Indexer/Event.
19980 (MethodData.GetMethodFlags): Moved here from MemberBase.
19981 (MethodData.ApplyAttributes): Likewise.
19982 (MethodData.ApplyObsoleteAttribute): Likewise.
19983 (MethodData.ApplyConditionalAttribute): Likewise.
19984 (MethodData.ApplyDllImportAttribute): Likewise.
19985 (MethodData.CheckAbstractAndExternal): Likewise.
19986 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19987 (MethodData.Emit): Formerly known as Method.Emit().
19988 (MemberBase): Moved everything which was specific to a single
19989 accessor/method to MethodData.
19990 (Method): Create a new MethodData and call Define() and Emit() on it.
19991 (Property, Indexer, Event): Create a new MethodData objects for each
19992 accessor and call Define() and Emit() on them.
19994 2002-07-25 Martin Baulig <martin@gnome.org>
19996 Made MethodCore derive from MemberBase to reuse the code from there.
19997 MemberBase now also checks for attributes.
19999 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
20000 (MemberBase.GetMethodFlags): Moved here from class Method and marked
20002 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
20003 `CallingConventions cc' and `Attributes opt_attrs' arguments.
20004 (MemberBase.ApplyAttributes): New virtual method; applies the
20005 attributes to a method or accessor.
20006 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
20007 (MemberBase.ApplyConditionalAttribute): Likewise.
20008 (MemberBase.ApplyDllImportAttribute): Likewise.
20009 (MemberBase.CheckAbstractAndExternal): Likewise.
20010 (MethodCore.ParameterTypes): This is now a property instead of a
20011 method, it's initialized from DoDefineParameters().
20012 (MethodCore.ParameterInfo): Removed the set accessor.
20013 (MethodCore.DoDefineParameters): New protected virtual method to
20014 initialize ParameterTypes and ParameterInfo.
20015 (Method.GetReturnType): We can now simply return the MemberType.
20016 (Method.GetMethodFlags): Override the MemberBase version and add
20017 the conditional flags.
20018 (Method.CheckBase): Moved some code from Define() here, call
20019 DoDefineParameters() here.
20020 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
20021 here to avoid some larger code duplication.
20022 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
20023 ensure that abstract and external accessors don't declare a body.
20025 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
20026 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
20027 lookup in the attribute's parent classes, so we need to abort as soon
20028 as we found the first match.
20029 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
20030 the attribute has no arguments.
20032 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
20035 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20037 * cs-parser.jay: reverted previous patch.
20039 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20041 * cs-parser.jay: fixed bug #22119.
20043 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20045 * attribute.cs: fixed compilation. The error was:
20046 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
20047 be assigned to before control leaves the current method."
20048 [FIXME: Filed as bug #28186: MCS must report this error.]
20050 2002-07-25 Martin Baulig <martin@gnome.org>
20052 * attribute.cs (Attribute.Conditional_GetConditionName): New static
20053 method to pull the condition name ouf of a Conditional attribute.
20054 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
20055 the obsolete message and error flag out of an Obsolete attribute.
20057 * class.cs (Method.GetMethodFlags): New public method to get the
20058 TypeManager.MethodFlags for this method.
20059 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
20061 (Method.Define): Get and apply the Obsolete and Conditional attributes;
20062 if we're overriding a virtual function, set the new private variable
20063 `parent_method'; call the new TypeManager.AddMethod().
20065 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
20066 the MethodBuilder and the Method in a PtrHashtable.
20067 (TypeManager.builder_to_method): Added for this purpose.
20068 (TypeManager.MethodFlags): Added IsObsoleteError.
20069 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
20070 Obsolete and Conditional arguments in MethodBuilders. If we discover
20071 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
20072 the message from the attribute.
20074 2002-07-24 Martin Baulig <martin@gnome.org>
20076 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
20077 preprocessor directives, ensure that the argument to #define/#undef is
20078 exactly one identifier and that it's actually an identifier.
20080 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
20083 2002-07-24 Martin Baulig <martin@gnome.org>
20085 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
20086 initialize it to TypeManager.object_type in the constructor.
20087 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
20088 of the `hm.get_current' method if we're using the collection pattern.
20089 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
20090 for the explicit conversion to make it work when we're using the collection
20091 pattern and the `Current' property has a different return type than `object'.
20094 2002-07-24 Martin Baulig <martin@gnome.org>
20096 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
20097 does not match, but don't report any errors. This method is called in
20098 order for all methods in a MethodGroupExpr until a matching method is
20099 found, so we don't want to bail out if the first method doesn't match.
20100 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
20101 matches, report the 123. Fixes #28070.
20103 2002-07-24 Martin Baulig <martin@gnome.org>
20105 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
20106 TypeManager.TypeToCoreType() to the top of the method so the
20107 following equality checks will work. Fixes #28107.
20109 2002-07-24 Martin Baulig <martin@gnome.org>
20111 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
20112 operand is of type uint, and the other operand is of type sbyte,
20113 short or int, the operands are converted to type long." -
20114 Actually do what this comment already told us. Fixes bug #28106,
20117 2002-07-24 Martin Baulig <martin@gnome.org>
20119 * class.cs (MethodBase): New abstract class. This is now a base
20120 class for Property, Indexer and Event to avoid some code duplication
20121 in their Define() and DefineMethods() methods.
20122 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
20123 generic methods for Define() and DefineMethods().
20124 (FieldBase): Derive from MemberBase, not MemberCore.
20125 (Property): Derive from MemberBase, not MemberCore.
20126 (Property.DefineMethod): Moved all the code from this method to the
20127 new MethodBase.DefineAccessor(), just call it with appropriate
20129 (Property.Define): Call the new Property.DoDefine(), this does some
20130 sanity checks and we don't need to duplicate the code everywhere.
20131 (Event): Derive from MemberBase, not MemberCore.
20132 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
20133 accessors, this will also make them work with interface events.
20134 (Indexer): Derive from MemberBase, not MemberCore.
20135 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
20136 (Indexer.Define): Use the new MethodBase functions.
20138 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
20139 argument to the constructor.
20140 (Interface.FindMembers): Added support for interface events.
20141 (Interface.PopluateEvent): Implemented.
20143 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
20145 2002-07-22 Miguel de Icaza <miguel@ximian.com>
20147 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
20148 but this is required to check for a method name being the same as
20149 the containing class.
20153 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20155 * interface.cs: initialize variable.
20157 2002-07-23 Martin Baulig <martin@gnome.org>
20159 Implemented the IndexerName attribute in interfaces.
20161 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
20162 name if this is an explicit interface implementation.
20163 (Indexer.InterfaceIndexerName): New public variable. If we're
20164 implementing an interface indexer, this is the IndexerName in that
20165 interface. Otherwise, it's the IndexerName.
20166 (Indexer.DefineMethod): If we're implementing interface indexer,
20167 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
20168 and Pending.ImplementIndexer methods.
20169 (Indexer.Define): Also define the PropertyBuilder if we're
20170 implementing an interface indexer and this is neither an explicit
20171 interface implementation nor do the IndexerName match the one in
20174 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
20175 If a method is defined here, then we always need to create a proxy
20176 for it. This is used when implementing interface indexers.
20177 (Pending.IsInterfaceIndexer): New public method.
20178 (Pending.ImplementIndexer): New public method.
20179 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
20180 This is used when implementing interface indexers to define a proxy
20182 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
20183 define a proxy if necessary.
20185 * interface.cs (Interface.IndexerName): New public variable.
20186 (Interface.PopulateIndexer): Set the IndexerName.
20187 (Interface.DefineIndexers): New private method. Populate all the
20188 indexers and make sure their IndexerNames match.
20190 * typemanager.cs (IndexerPropertyName): Added support for interface
20193 2002-07-22 Martin Baulig <martin@gnome.org>
20195 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
20196 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
20197 ret if HasReturnLabel.
20198 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
20201 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
20202 and set the ec.LoopBeginTryCatchLevel.
20203 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
20204 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
20205 the current ec.TryCatchLevel, the branch goes out of an exception
20206 block. In this case, we need to use Leave and not Br.
20208 2002-07-22 Martin Baulig <martin@gnome.org>
20210 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
20211 block unless the block does not always return or it is contained in
20212 another try { ... } catch { ... } block. Fixes bug #26506.
20213 Added verify-1.cs to the test suite.
20215 2002-07-22 Martin Baulig <martin@gnome.org>
20217 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
20218 then we do not always return. Fixes bug #24985.
20220 2002-07-22 Martin Baulig <martin@gnome.org>
20222 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
20223 lookup on a per-class level; ie. walk up the class hierarchy until we
20224 found at least one applicable method, then choose the best among them.
20225 Fixes bug #24463 and test-29.cs.
20227 2002-07-22 Martin Baulig <martin@gnome.org>
20229 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
20230 return types of the methods. The return type is not part of the
20231 signature and we must not check it to make the `new' modifier work.
20232 Fixes bug #27999, also added test-147.cs.
20233 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
20235 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
20236 on the method's return type.
20238 2002-07-21 Martin Baulig <martin@gnome.org>
20240 * assign.cs: Make this work if the rightmost source is a constant and
20241 we need to do an implicit type conversion. Also adding a few more tests
20242 to test-38.cs which should have caught this.
20244 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
20245 target in the makefile for this. The makefile.gnu is primarily intended
20246 for end-users who don't want to debug the compiler.
20248 2002-07-21 Martin Baulig <martin@gnome.org>
20250 * assign.cs: Improved the Assign class so it can now handle embedded
20251 assignments (X = Y = Z = something). As a side-effect this'll now also
20252 consume less local variables. test-38.cs now passes with MCS, added
20253 a few new test cases to that test.
20255 2002-07-20 Martin Baulig <martin@gnome.org>
20257 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
20258 instructions. Fixes bug #27977, also added test-146.cs.
20260 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20262 * cs-tokenizer.cs: fixed getHex ().
20264 2002-07-19 Martin Baulig <martin@gnome.org>
20266 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
20267 not Type.GetType() to lookup the array type. This is needed when
20268 we're constructing an array of a user-defined type.
20269 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
20270 single-dimensional arrays, but also for single-dimensial arrays of
20273 2002-07-19 Martin Baulig <martin@gnome.org>
20275 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
20276 this function is called, it's not allowed to share LocalBuilders
20277 among ILGenerators.
20279 2002-07-19 Martin Baulig <martin@gnome.org>
20281 * expression.cs (Argument.Resolve): Report an error 118 when trying
20282 to pass a type as argument.
20284 2002-07-18 Martin Baulig <martin@gnome.org>
20286 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
20287 Conv_R_Un for the signed `long' type.
20289 2002-07-15 Miguel de Icaza <miguel@ximian.com>
20291 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
20292 `expr' for the temporary result, as that will fail if we do
20293 multiple resolves on the same expression.
20295 2002-07-05 Miguel de Icaza <miguel@ximian.com>
20297 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
20298 ec.TypeContainer for looking up aliases.
20300 * class.cs (TypeContainer): Remove LookupAlias from here.
20302 * decl.cs (DeclSpace); Move here.
20304 2002-07-01 Miguel de Icaza <miguel@ximian.com>
20306 * class.cs (FindMembers): Only call filter if the constructor
20307 bulider is not null.
20309 Also handle delegates in `NestedTypes' now. Now we will perform
20310 type lookups using the standard resolution process. This also
20313 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
20314 This uses Expressions (the limited kind that can be parsed by the
20315 tree) instead of strings.
20317 * expression.cs (ComposedCast.ToString): Implement, used to flag
20318 errors since now we have to render expressions.
20320 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
20323 * ecore.cs (SimpleName.ToString): ditto.
20325 * cs-parser.jay: Instead of using strings to assemble types, use
20326 Expressions to assemble the type (using SimpleName, ComposedCast,
20327 MemberAccess). This should fix the type lookups in declarations,
20328 because we were using a different code path for this.
20330 * statement.cs (Block.Resolve): Continue processing statements
20331 even when there is an error.
20333 2002-07-17 Miguel de Icaza <miguel@ximian.com>
20335 * class.cs (Event.Define): Also remove the `remove' method from
20336 the list of pending items.
20338 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
20339 generate more compact code.
20341 2002-07-17 Martin Baulig <martin@gnome.org>
20343 * const.cs (Const.LookupConstantValue): Add support for constant
20344 `unchecked' and `checked' expressions.
20345 Also adding test case test-140.cs for this.
20347 2002-07-17 Martin Baulig <martin@gnome.org>
20349 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
20350 check whether mi.ReturnType implements the IEnumerator interface; the
20351 `==' and the IsAssignableFrom() will fail in this situation.
20353 2002-07-16 Ravi Pratap <ravi@ximian.com>
20355 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
20358 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20360 * expression.cs: fixed bug #27811.
20362 2002-07-14 Miguel de Icaza <miguel@ximian.com>
20364 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
20365 Molaro: when we are a ref, the value already contains a pointer
20366 value, do not take the address of it.
20368 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20369 * removed mb-parser.jay and mb-tokenizer.cs
20371 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20373 * expression.cs: check against the building corlib void type.
20375 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
20377 * ecore.cs: fix for valuetype static readonly fields: when
20378 initializing them, we need their address, not the address of a copy.
20380 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
20382 * typemanager.cs: register also enum_type in corlib.
20384 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20386 * class.cs: allow calling this (but not base) initializers in structs.
20388 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
20390 * ecore.cs: make sure we compare against the building base types
20393 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
20395 * typemanager.cs: fix TypeToCoreType() to handle void and object
20396 (corlib gets no more typerefs after this change).
20398 2002-07-12 Miguel de Icaza <miguel@ximian.com>
20400 * expression.cs (ArrayCreation.EmitArrayArguments): use
20401 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
20403 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
20404 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
20405 array indexes, the runtime actually forbids them.
20407 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
20408 for array arguments here.
20410 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
20411 instead of the default for ValueTypes.
20413 (New.DoEmit): Use IsValueType instead of
20414 IsSubclassOf (value_type)
20415 (New.DoResolve): ditto.
20416 (Invocation.EmitCall): ditto.
20418 * assign.cs (Assign): ditto.
20420 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
20421 Statements *are* currently doing part of their resolution during
20424 Expressions do always resolve during resolve, but statements are
20425 only required to propagate resolution to their children.
20427 2002-07-11 Miguel de Icaza <miguel@ximian.com>
20429 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
20431 (LoadAssembly): Do not add the dll if it is already specified
20433 (MainDriver): Add the System directory to the link path at the end,
20434 after all the other -L arguments.
20436 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
20437 wrong opcode for loading bytes and bools (ldelem.i1 instead of
20438 ldelem.u1) and using the opposite for sbytes.
20440 This fixes Digger, and we can finally run it.
20442 * driver.cs (UnixParseOption): Move the option parsing here.
20443 (CSCParseOption): Implement CSC-like parsing of options.
20445 We now support both modes of operation, the old Unix way, and the
20446 new CSC-like way. This should help those who wanted to make cross
20447 platform makefiles.
20449 The only thing broken is that /r:, /reference: and /lib: are not
20450 implemented, because I want to make those have the same semantics
20451 as the CSC compiler has, and kill once and for all the confussion
20452 around this. Will be doing this tomorrow.
20454 * statement.cs (Unsafe.Resolve): The state is checked during
20455 resolve, not emit, so we have to set the flags for IsUnsfe here.
20457 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20459 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
20460 not catch the Error_ObjectRefRequired in SimpleName (as it is
20461 possible to have a class/instance variable name that later gets
20462 deambiguated), we have to check this here.
20464 2002-07-10 Ravi Pratap <ravi@ximian.com>
20466 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
20467 make static and put into Expression.
20469 (Event.Define): Register the private field of the event with the
20470 TypeManager so that GetFieldFromEvent can get at it.
20472 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
20473 keep track of the private field associated with an event which
20476 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
20479 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
20481 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20483 * expression.cs (Binary.EmitBranchable): this routine emits the
20484 Binary expression in a branchable context. This basically means:
20485 we need to branch somewhere, not just get the value on the stack.
20487 This works together with Statement.EmitBoolExpression.
20489 * statement.cs (Statement.EmitBoolExpression): Use
20492 2002-07-09 Miguel de Icaza <miguel@ximian.com>
20494 * statement.cs (For): Reduce the number of jumps in loops.
20496 (For): Implement loop inversion for the For statement.
20498 (Break): We can be breaking out of a Try/Catch controlled section
20499 (foreach might have an implicit try/catch clause), so we need to
20500 use Leave instead of Br.
20502 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
20503 now). If the instace expression supports IMemoryLocation, we use
20504 the AddressOf method from the IMemoryLocation to extract the
20505 address instead of emitting the instance.
20507 This showed up with `This', as we were emitting the instance
20508 always (Emit) instead of the Address of This. Particularly
20509 interesting when This is a value type, as we dont want the Emit
20510 effect (which was to load the object).
20512 2002-07-08 Miguel de Icaza <miguel@ximian.com>
20514 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
20516 * statement.cs (Checked): Set the CheckedState during the resolve
20517 process too, as the ConvCast operations track the checked state on
20518 the resolve process, and not emit.
20520 * cs-parser.jay (namespace_member_declaration): Flag that we have
20521 found a declaration when we do. This is used to flag error 1529
20523 * driver.cs: Report ok when we display the help only.
20525 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
20527 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
20529 2002-07-04 Miguel de Icaza <miguel@ximian.com>
20531 * cs-tokenizer.cs (define): We also have to track locally the
20532 defines. AllDefines is just used for the Conditional Attribute,
20533 but we also need the local defines for the current source code.
20535 2002-07-03 Miguel de Icaza <miguel@ximian.com>
20537 * statement.cs (While, For, Do): These loops can exit through a
20538 Break statement, use this information to tell whether the
20539 statement is the last piece of code.
20541 (Break): Flag that we break.
20543 * codegen.cs (EmitContexts): New `Breaks' state variable.
20545 2002-07-03 Martin Baulig <martin@gnome.org>
20547 * class.cs (TypeContainer.MethodModifiersValid): Allow override
20548 modifiers in method declarations in structs. Otherwise, you won't
20549 be able to override things like Object.Equals().
20551 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20553 * class.cs (Method, Property, Indexer): Do not allow the public
20554 modifier to be used in explicit interface implementations.
20556 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
20557 override modifiers in method declarations in structs
20559 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
20561 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
20562 integer or real overflow, report an error
20564 2002-07-02 Martin Baulig <martin@gnome.org>
20566 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
20567 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
20568 to tell the runtime about our newly created System.Object and
20569 System.ValueType types.
20571 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20573 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
20574 struct instead of Ldarg/Starg.
20576 2002-07-02 Martin Baulig <martin@gnome.org>
20578 * expression.cs (Indirection.Indirection): Call
20579 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
20581 2002-07-02 Martin Baulig <martin@gnome.org>
20583 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
20584 ValueType, call TypeManager.TypeToCoreType() on it.
20585 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
20586 the OpCodes.Newarr argument.
20588 2002-07-02 Martin Baulig <martin@gnome.org>
20590 * expression.cs (Invocation.EmitCall): When compiling corlib,
20591 replace all calls to the system's System.Array type to calls to
20592 the newly created one.
20594 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
20595 System.Array methods.
20596 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
20597 from the system's System.Array type which must be replaced.
20599 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
20601 * typemanager.cs: load unverifiable_code_ctor so we can build
20602 corlib using the correct type. Avoid using GetTypeCode() with
20604 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
20605 TypeManager.object_type to allow building corlib.
20607 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
20609 * ecore.cs: handle System.Enum separately in LoadFromPtr().
20611 2002-07-01 Martin Baulig <martin@gnome.org>
20613 * class.cs: Make the last change actually work, we need to check
20614 whether `ifaces != null' to avoid a crash.
20616 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20618 * class.cs: when we build structs without fields that implement
20619 interfaces, we need to add the interfaces separately, since there is
20620 no API to both set the size and add the interfaces at type creation
20623 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20625 * expression.cs: the dimension arguments to the array constructors
20626 need to be converted if they are a long.
20628 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
20630 * class.cs: don't emit ldarg.0 if there is no parent constructor
20631 (fixes showstopper for corlib).
20633 2002-06-29 Martin Baulig <martin@gnome.org>
20635 MCS now compiles corlib on GNU/Linux :-)
20637 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
20638 ie. check for MethodImplOptions.InternalCall.
20640 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
20641 and TypeManager.attribute_type are null, so we must explicitly check
20642 whether parent is not null to find out whether it's an attribute type.
20643 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
20644 and SetBuilder, not only if the property is neither abstract nor external.
20645 This is necessary to set the MethodImplOptions on the accessor methods.
20646 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
20647 SetBuilder, see Property.Emit().
20649 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
20650 populate "System.Object", "System.ValueType" and "System.Attribute" since
20651 they've already been populated from BootCorlib_PopulateCoreTypes().
20653 2002-06-29 Martin Baulig <martin@gnome.org>
20655 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
20656 is the NullLiteral, we also need to make sure that target_type is not
20659 2002-06-29 Martin Baulig <martin@gnome.org>
20661 * rootcontext.cs (RootContext.ResolveCore): We must initialize
20662 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
20663 before calling BootstrapCorlib_ResolveDelegate ().
20665 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20667 * statement.cs: fixed build-breaker. All tests passed ok.
20669 2002-06-27 Martin Baulig <martin@gnome.org>
20671 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
20672 for System.Decimal when compiling corlib.
20674 2002-06-27 Martin Baulig <martin@gnome.org>
20676 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
20677 switch blocks which contain nothing but a default clause.
20679 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
20681 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
20683 2002-06-27 Martin Baulig <martin@gnome.org>
20685 * ecore.cs (PropertyExpr.PropertyExpr): Call
20686 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
20688 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
20689 is already a TypeBuilder.
20691 2002-06-27 Martin Baulig <martin@gnome.org>
20693 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
20694 `target_type == TypeManager.array_type', not IsAssignableFrom() in
20695 the "from an array-type to System.Array" case. This makes it work
20696 when compiling corlib.
20698 2002-06-27 Martin Baulig <martin@gnome.org>
20700 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
20701 non-static PropertyExpr, set its InstanceExpression. This makes
20702 the `ICollection.Count' property work in System/Array.cs.
20704 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
20706 * driver.cs: Made error handling more consistent. Errors now
20707 tracked by Report class, so many methods which used to return int
20708 now return void. Main() now prints success/failure and
20709 errors/warnings message.
20711 Renamed '--probe' compiler argument to '--expect-error'. Removed
20712 the magic number return values (123 and 124). Now, if the
20713 expected error occurs, the compiler exits with success (exit value
20714 0). If the compilation completes without seeing that particular
20715 error, the compiler exits with failure (exit value 1). The
20716 makefile in mcs/errors has been changed to handle the new behaviour.
20718 * report.cs: Made 'expected error' number a property and renamed
20719 it from 'Probe' to 'ExpectedError'.
20721 * genericparser.cs: Removed error handling support, since it is
20722 now all done by Report class.
20724 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
20725 class, so parse() no longer returns an int.
20727 * namespace.cs: Use Report.Error instead of GenericParser.error
20729 2002-06-22 Miguel de Icaza <miguel@ximian.com>
20731 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
20732 TypeContainer.AddOperator): At the front of the list put the
20733 explicit implementations, so they get resolved/defined first.
20735 2002-06-21 Miguel de Icaza <miguel@ximian.com>
20737 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
20738 interface type is implemented by this TypeContainer. Used during
20739 explicit interface implementation.
20741 (Property.Define, Indexer.Define, Method.Define): Validate that
20742 the given interface in the explicit implementation is one of the
20743 base classes for the containing type.
20745 Also if we are explicitly implementing an interface, but there is
20746 no match in the pending implementation table, report an error.
20748 (Property.Define): Only define the property if we are
20749 not explicitly implementing a property from an interface. Use the
20750 correct name also for those properties (the same CSC uses,
20751 although that is really not needed).
20753 (Property.Emit): Do not emit attributes for explicitly implemented
20754 properties, as there is no TypeBuilder.
20756 (Indexer.Emit): ditto.
20758 Hiding then means that we do not really *implement* a pending
20759 implementation, which makes code fail.
20761 2002-06-22 Martin Baulig <martin@gnome.org>
20763 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20764 the return value of Object.GetType(). [FIXME: we need to do this whenever
20765 we get a type back from the reflection library].
20767 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20769 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20771 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20773 * attribute.cs: Return null if we can not look up the type.
20775 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20776 the interface types found.
20778 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20779 interface types found.
20781 * typemanager.cs (GetInterfaces): Make this routine returns alll
20782 the interfaces and work around the lame differences between
20783 System.Type and System.Reflection.Emit.TypeBuilder in the results
20784 result for GetInterfaces.
20786 (ExpandInterfaces): Given an array of interface types, expand and
20787 eliminate repeated ocurrences of an interface. This expands in
20788 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20791 2002-06-21 Martin Baulig <martin@gnome.org>
20793 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20796 2002-06-21 Martin Baulig <martin@gnome.org>
20798 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20799 and called with one of the core types, return the corresponding typebuilder for
20802 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20805 2002-06-21 Martin Baulig <martin@gnome.org>
20807 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20808 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20809 (Expression.ConvertReferenceExplicit): Likewise.
20811 * expression.cs (ElementAccess.DoResolve): Likewise.
20812 (ElementAccess.DoResolveLValue): Likewise.
20814 2002-06-10 Martin Baulig <martin@gnome.org>
20816 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20817 add the "value" parameter to the parameter list.
20819 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20822 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20824 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20825 the argument to an int, uint, long or ulong, per the spec. Also
20826 catch negative constants in array creation.
20828 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20830 * class.cs: do not allow the same interface to appear twice in
20831 the definition list.
20833 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20835 * ecore.cs: don't use ldlen with System.Array.
20837 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20839 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20841 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20843 * modifiers.cs: produce correct field attributes for protected
20844 internal. Easy fix so miguel can work on ther harder stuff:-)
20846 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20848 * pending.cs: New file. Move the code from class.cs here.
20849 Support clearning the pending flag for all methods (when not doing
20850 explicit interface implementation).
20852 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20854 * rootcontext.cs: added a couple more types needed to bootstrap.
20856 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20858 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20859 constructor in the type, instead of any constructor in the type
20860 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20861 a bug in the Mono runtime when applying the params attribute).
20863 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20864 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20866 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20868 * expression.cs (Unary.ResolveOperator): Use TypeManager
20869 to resolve the type.
20871 2002-06-13 Ravi Pratap <ravi@ximian.com>
20873 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20876 * enum.cs (AddEnumMember): Add support to store the attributes associated
20877 with each member too.
20879 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20880 field builders too - this takes care of the enum member case.
20882 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20884 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20885 address-of operator on both value types and pointers.
20887 2002-06-10 Martin Baulig <martin@gnome.org>
20889 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20890 PropertyBuilder to the `property_builders' list.
20892 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20893 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20894 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20895 find any indexers which are inherited from an interface.
20897 2002-06-09 Martin Baulig <martin@gnome.org>
20899 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20900 the same type as the constant if necessary. There's also a test-130.cs
20903 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20905 * typemanager.cs (TypeManager.ChangeType): Previously known as
20906 Enum.ChangeEnumType().
20908 2002-06-09 Martin Baulig <martin@gnome.org>
20910 * expression.cs (Cast.TryReduce): Added support for consts.
20912 2002-06-08 Ravi Pratap <ravi@ximian.com>
20914 * class.cs (Accessor): Hold attributes information so we can pass
20917 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20918 Modify to pass in attributes attached to the methods.
20920 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20922 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20923 to handle the Accessor kind :-)
20925 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20927 2002-06-08 Martin Baulig <martin@gnome.org>
20929 * expression.cs (Unary.TryReduceNegative): Added support for
20932 2002-06-08 Martin Baulig <martin@gnome.org>
20934 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20935 name can't be found in the `defined_names' - the caller will do a
20936 MemberLookup in this case and thus find methods in System.Enum
20937 such as Enum.IsDefined().
20939 2002-06-08 Martin Baulig <martin@gnome.org>
20941 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20942 Convert.ChangeType() which works with TypeBuilder created types.
20943 (Enum.LookupEnumValue, Enum.Define): Use it here.
20945 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20946 `TypeBuilder.BaseType != null' check.
20947 (TypeContainer.FindMembers): Only lookup parent members if we
20948 actually have a parent.
20949 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20950 (ConstructorInitializer.Resolve): Likewise.
20952 * interface.cs (Interface.FindMembers): Added
20953 `TypeBuilder.BaseType != null' check.
20955 * rootcontext.cs (RootContext.ResolveCore): Added
20956 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20957 classes_second_stage.
20959 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20960 debug_type and trace_type when compiling with --nostdlib.
20962 2002-06-07 Martin Baulig <martin@gnome.org>
20964 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20965 (AddField): Set it to true when adding a non-static field.
20966 (DefineType): Use `have_nonstatic_fields' to find out whether we
20967 have non-static fields, not `Fields != null'.
20969 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20971 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20972 dereferencing a null on the static-field code path)
20974 2002-05-30 Martin Baulig <martin@gnome.org>
20976 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20977 to take command line arguments. Use reflection to call the new
20978 custom `Initialize' function on the symbol writer and pass it the
20979 command line arguments.
20981 * driver.cs (--debug-args): New command line argument to pass command
20982 line arguments to the symbol writer.
20984 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20986 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20987 the target type for indexers and properties. Thanks to Joe for
20990 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20992 * typemanager.cs (MethodFlags): returns the method flags
20993 (Obsolete/ShouldIgnore) that control warning emission and whether
20994 the invocation should be made, or ignored.
20996 * expression.cs (Invocation.Emit): Remove previous hack, we should
20997 not do this on matching a base type, we should do this based on an attribute
20999 Only emit calls to System.Diagnostics.Debug and
21000 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
21001 on the command line.
21003 * rootcontext.cs: Global settings for tracing and debugging.
21005 * cs-tokenizer.cs (define): New utility function to track
21006 defines. Set the global settings for TRACE and DEBUG if found.
21008 2002-05-25 Ravi Pratap <ravi@ximian.com>
21010 * interface.cs (Populate*): Pass in the TypeContainer as well as
21011 the DeclSpace as parameters so that we can create EmitContexts and
21012 then use that to apply attributes etc.
21014 (PopulateMethod, PopulateEvent, PopulateProperty)
21015 (PopulateIndexer): Apply attributes everywhere.
21017 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
21020 (ApplyAttributes): Update accordingly.
21022 We now apply interface attributes for all members too.
21024 2002-05-26 Miguel de Icaza <miguel@ximian.com>
21026 * class.cs (Indexer.Define); Correctly check if we are explicit
21027 implementation (instead of checking the Name for a ".", we
21028 directly look up if the InterfaceType was specified).
21030 Delay the creation of the PropertyBuilder.
21032 Only create the PropertyBuilder if we are not an explicit
21033 interface implementation. This means that explicit interface
21034 implementation members do not participate in regular function
21035 lookups, and hence fixes another major ambiguity problem in
21036 overload resolution (that was the visible effect).
21038 (DefineMethod): Return whether we are doing an interface
21041 * typemanager.cs: Temporary hack until we get attributes in
21042 interfaces (Ravi is working on that) and we get IndexerName
21043 support in interfaces.
21045 * interface.cs: Register the indexers as properties.
21047 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
21048 warning, I have verified that this is a bug in the .NET runtime
21049 (JavaScript suffers of the same problem).
21051 * typemanager.cs (MemberLookup): When looking up members for
21052 interfaces, the parent of an interface is the implicit
21053 System.Object (so we succeed in searches of Object methods in an
21054 interface method invocation. Example: IEnumerable x; x.ToString
21057 2002-05-25 Miguel de Icaza <miguel@ximian.com>
21059 * class.cs (Event): Events should also register if they do
21060 implement the methods that an interface requires.
21062 * typemanager.cs (MemberLookup); use the new GetInterfaces
21065 (GetInterfaces): The code used to lookup interfaces for a type is
21066 used in more than one place, factor it here.
21068 * driver.cs: Track the errors at the bottom of the file, we kept
21071 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
21072 instance if the method we are calling is static!
21074 2002-05-24 Miguel de Icaza <miguel@ximian.com>
21076 * attribute.cs (ApplyAttributes): Make this function filter out
21077 the IndexerName attribute (as that attribute in reality is never
21078 applied) and return the string constant for the IndexerName
21081 * class.cs (TypeContainer.Emit): Validate that all the indexers
21082 have the same IndexerName attribute, and if so, set the
21083 DefaultName attribute on the class.
21085 * typemanager.cs: The return value might contain other stuff (not
21086 only methods). For instance, consider a method with an "Item"
21087 property and an Item method.
21089 * class.cs: If there is a problem with the parameter types,
21092 2002-05-24 Ravi Pratap <ravi@ximian.com>
21094 * ecore.cs (ImplicitConversionExists): Wrapper function which also
21095 looks at user defined conversion after making a call to
21096 StandardConversionExists - we need this for overload resolution.
21098 * expression.cs : Update accordingly the various method calls.
21100 This fixes 2 bugs filed against implicit user defined conversions
21102 2002-05-22 Miguel de Icaza <miguel@ximian.com>
21104 * statement.cs: Track the result of the assignment.
21106 2002-05-21 Miguel de Icaza <miguel@ximian.com>
21108 * expression.cs (MemberAccess): Improved error reporting for
21109 inaccessible members.
21111 2002-05-22 Martin Baulig <martin@gnome.org>
21113 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
21114 itself with debugging support.
21116 2002-05-22 Martin Baulig <martin@gnome.org>
21118 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
21119 Removed, this isn't needed anymore.
21121 2002-05-20 Martin Baulig <martin@gnome.org>
21123 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
21124 be underlying type for an enum.
21126 2002-05-20 Miguel de Icaza <miguel@ximian.com>
21128 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
21129 that splits out the loading of just the core types.
21131 * rootcontext.cs (ResolveCore): Split the struct resolution in
21132 two, so we can load the enumeration underlying types before any
21135 * expression.cs (Is): Bandaid until we fix properly Switch (see
21136 bug #24985 for details).
21138 * typemanager.cs (ImplementsInterface): The hashtable will contain
21139 a null if there are no interfaces implemented.
21141 2002-05-18 Miguel de Icaza <miguel@ximian.com>
21143 * cs-parser.jay (indexer_declarator): It is fine to have array
21146 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21148 * typemanager.cs: (RegisterBuilder): New function used to register
21149 TypeBuilders that implement interfaces. Since
21150 TypeBuilder.GetInterfaces (as usual) does not work with lame
21152 (AddUserType): register interfaces.
21154 (ImplementsInterface): Use the builder_to_ifaces hash if we are
21155 dealing with TypeBuilder. Also, arrays are showing up as
21156 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
21157 methods can not be invoked on them!
21159 * ecore.cs (ExplicitReferenceConversionExists): Made public.
21160 (ImplicitReferenceConversionExists): Split out from
21161 StandardConversionExists.
21163 * expression.cs (As): We were only implementing one of the three
21164 cases for the as operator. We now implement them all.
21165 (Is): Implement the various other cases for Is as well.
21167 * typemanager.cs (CACHE): New define used to control if we want or
21168 not the FindMembers cache. Seems to have a negative impact on
21169 performance currently
21171 (MemberLookup): Nested types have full acess to
21172 enclosing type members
21174 Remove code that coped with instance/static returns for events, we
21175 now catch this in RealFindMembers.
21177 (RealFindMembers): only perform static lookup if the instance
21178 lookup did not return a type or an event.
21180 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21182 * assign.cs (CompoundAssign): We pass more semantic information
21183 now to Compound Assignments than we did before: now we have all
21184 the information at hand, and now we resolve the target *before* we
21185 do the expression expansion, which allows the "CacheValue" method
21186 to have the effect we intended (before, a [x] += 1 would generate
21187 two differen ArrayAccess expressions from the ElementAccess,
21188 during the resolution process).
21190 (CompoundAssign.DoResolve): Resolve target and original_source here.
21192 2002-05-16 Miguel de Icaza <miguel@ximian.com>
21194 * expression.cs (ArrayAccess): dropped debugging information.
21196 * typemanager.cs: Small bug fix: I was always returning i_members,
21197 instead of one of i_members or s_members (depending on which had
21200 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
21201 method is invoked before any code generation takes place, and it
21202 is a mechanism to inform that the expression will be invoked more
21203 than once, and that the method should use temporary values to
21204 avoid having side effects
21206 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
21208 * ecore.cs (Expression.CacheTemporaries): Provide empty default
21211 * expression.cs (Indirection, ArrayAccess): Add support for
21212 CacheTemporaries in these two bad boys.
21214 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
21215 ldobj or ldind_ref.
21216 (StoreFromPtr): Handle stobj as well.
21218 * expression.cs (UnaryMutator): Share more code.
21220 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
21221 down: I was not tracking the Filter function as well, which
21222 was affecting the results of the cache.
21224 2002-05-15 Miguel de Icaza <miguel@ximian.com>
21226 * attribute.cs: Remove the hack to handle the CharSet property on
21229 2002-05-14 Miguel de Icaza <miguel@ximian.com>
21231 * attribute.cs (DoResolve): More uglyness, we now only try to
21232 resolve the attribute partially, to extract the CharSet
21233 information (only if we are a StructLayout attribute). Otherwise
21235 (GetExtraTypeInfo): Add some code to conditionally kill in the
21236 future this. I am more and more convinced that the .NET
21237 framework has special code to handle the attribute setting on
21240 * expression.cs (IsParamsMethodApplicable): Revert my previous
21241 foreach change here, it was wrong.
21243 2002-05-13 Miguel de Icaza <miguel@ximian.com>
21245 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
21246 (pp_expr): do not abort on unknown input, just return.
21247 (eval): abort if there are pending chars.
21249 * attribute.cs (Attribute.Resolve): Positional parameters are
21250 optional. Deal with that case.
21252 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
21253 the Ansi/Unicode/Auto information for the type.
21255 (TypeContainer.DefineType): instantiate the EmitContext here, as
21256 we will be using it during the type definition (to resolve
21257 attributes) and during the emit phase.
21259 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
21260 to pull type information out of the attributes
21262 (Attribute.Resolve): track the constructor builder, and allow for
21263 multiple invocations (structs and classes will use this).
21265 * ecore.cs (MemberLookupFinal): new version with all the
21266 parameters customizable.
21268 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
21269 constructors. Return if the result value is null (as the error
21270 would have been flagged already by MemberLookupFinal)
21272 Do not allow instances of abstract classes or interfaces to be
21275 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
21276 We have to compare the assembly property here when dealing with
21277 FamANDAssem and Assembly access modifiers, because we might be
21278 creating an assembly from *modules* (that means that we are not
21279 getting TypeBuilders for types defined in other modules that are
21280 part of this assembly).
21282 (Method.Emit): If the method is marked abstract and has a body,
21285 (TypeContainer.DefineMembers): If both the defined member and the
21286 parent name match are methods, then do not emit any warnings: let
21287 the Method.Define routine take care of flagging warnings. But if
21288 there is a mismatch (method overrides something else, or method is
21289 overriwritten by something, then emit warning).
21291 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
21292 set to null, this means `do not check for the return type on the
21295 (Method.Define): set the return type for the method signature to
21296 null, so that we get methods with the same name and parameters and
21297 different return types. This is used to flag warning 114 (you are
21298 hiding a method, and you probably want to use the new/override
21301 * typemanager.cs (MemberLookup): Implemented proper access
21302 control, closing a long standing set of bug reports. The problem
21303 was that the Framework only has two bits: Public and NonPublic,
21304 and NonPublic includes private and protected methods, but we need
21305 to enforce the FamANDAssem, FamOrAssem and Family.
21307 2002-05-11 Miguel de Icaza <miguel@ximian.com>
21309 * statement.cs (GotoCase): Return true: Ammounts to giving up
21310 knowledge on whether we return or not, and letting the other case
21311 be responsible for it.
21313 2002-05-10 Miguel de Icaza <miguel@ximian.com>
21315 * driver.cs: Do not load directories for each file processed, only
21316 do it if there is a pattern.
21318 * ecore.cs: Report readonly assigns here as well, as we might have
21319 been resolved only by MemberAccess.
21321 (SimpleName.SimpleNameResolve): Also be useful for LValue
21322 resolution. We need this to propagate assign to local readonly variables
21324 * typemanager.cs: Use a ptrhashtable for the criteria, because we
21325 do not want to reuse potential criteria memory.
21327 * class.cs (MyEventBuilder): Set reflected_type;
21329 * ecore.cs (Constantify): Added support for constifying bools.
21331 (RootContext.LookupType): Added a cache for values looked up in
21332 the declaration space.
21334 * typemanager.cs (FindMembers): Now is a front-end to
21335 RealFindMembers, and provides a two-level hashtable-based cache to
21338 15% performance improvement: from 22.5 to 19.2 seconds.
21340 * expression.cs (IsParamsMethodApplicable): use foreach.
21341 (Invocation.DoResolve): ditto.
21342 (New.DoResolve): ditto.
21343 (ArrayCreation.DoResolve): ditto.
21345 * ecore.cs (FindMostEncompassingType): use foreach.
21347 * delegate.cs (NewDelegate.DoResolve): Use foreach
21349 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
21350 (RemoveMethods): use foreach.
21352 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
21353 nested foreach statements instead of for, and also break out of
21354 the inner loop once a match is found.
21356 (Invocation.OverloadResolve): Use foreach, simplify the code.
21358 2002-05-08 Miguel de Icaza <miguel@ximian.com>
21360 * cfold.cs (BinaryFold): During an enumeration evaluation context,
21361 we actually unwrap the expression to allow for extra information
21364 * expression.cs: Use Shr_Un on unsigned operations.
21366 2002-05-08 Ravi Pratap <ravi@ximian.com>
21368 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
21369 applicable operators was not being considered correctly. This closes
21370 the bug Miguel reported.
21372 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
21374 * attribute.cs: check that the type derives from System.Attribute
21375 and report the correct error in that case (moved the duplicate code to
21376 its own method, too).
21378 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
21380 * attribute.cs: lookup attribute type name as the spec says: first the
21381 bare attribute name and then name + "Attribute" (nant compiles with
21382 mcs after this fix).
21384 2002-05-07 Miguel de Icaza <miguel@ximian.com>
21386 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
21387 Because of the way we parse things, we should try to see if a
21388 UIntConstant can fit in an integer.
21390 2002-05-07 Ravi Pratap <ravi@ximian.com>
21392 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
21393 when we are in an explicit context.
21395 (ConvertReferenceExplicit): When converting from Iface type S to Class
21396 T make sure the rules are implemented as an OR.
21398 * parameter.cs (ParameterType): Make it a property for now although the
21399 purpose really isn't anything immediate.
21401 * expression.cs (Is*Applicable): Do better checking on the parameter type
21402 of a ref/out parameter. The ones from the system assemblies are already
21403 marked with the correct type so we don't need to do any correction.
21405 * ecore.cs (StandardConversionExists): Conversion from Interface types to
21406 the object type is standard too so include that.
21408 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21410 * ecore.cs (StandardConversionExists): Augment with missing code:
21411 deal with IntConstant, LongConstants and Enumerations.
21413 * assign.cs: Report the error, instead of failing silently
21415 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
21416 typecontainer that they are declared, because the
21417 typecontainer/namespace will have the list of using clauses that
21418 need to be applied.
21420 Assembly Attributes were escaping the normal registration
21423 (EmitCode): Apply attributes within an EmitContext that represents
21424 the container they were declared on.
21426 * cs-parser.jay: Track bases for structs. How did I get this wrong?
21428 2002-05-06 Ravi Pratap <ravi@ximian.com>
21430 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
21431 Revamp completely - make much cleaner as we now operate only
21434 (FindMostSpecificSource, FindMostSpecificTarget): New methods
21435 to implement the logic detailed in the spec more correctly.
21437 (UserDefinedConversion): Update accordingly.
21439 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21441 * statement.cs: Return flow analysis information up.
21443 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
21446 (token): Do not consume an extra character before calling
21449 2002-05-06 Piers Haken <piersh@friskit.com>
21451 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
21453 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21455 * class.cs (Constructor.Emit): Set the IsStatic flag in the
21456 EmitContext during the instance constructor initializer
21457 resolution, to stop access to instance variables.
21459 This is mandated by the spec, last paragraph of the `constructor
21460 initializers' section.
21462 2002-05-05 Miguel de Icaza <miguel@ximian.com>
21464 * cs-parser.jay, class.cs (Accessor): new class used to represent
21465 an accessor (get or set). In the past we used `null' to represent
21466 a missing accessor. But this is ambiguous because there was no
21467 way to tell in abstract indexers/properties if one of them was
21470 Now there is a way of addressing that.
21472 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
21473 instead of FindMembers.
21475 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
21476 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
21478 * attribute.cs: Treat indexers and properties as the same in terms
21479 of applying attributes
21481 * ecore.cs (FindMostEncompassedType): Use statically initialized
21482 EmptyExpressions()s like we do elsewhere to avoid creating useless
21483 objects (and we take this out of the tight loop).
21485 (GetConversionOperators): Move the code to extract the actual
21486 operators to a separate routine to clean things up.
21488 2002-05-04 Miguel de Icaza <miguel@ximian.com>
21490 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
21491 events are always registered FieldBuilders.
21493 * class.cs (FieldBase): New class shared by Fields
21495 * delegate.cs: If we are a toplevel delegate, use our full name.
21496 If we are a nested delegate, then only use our tail name.
21498 2002-05-02 Ravi Pratap <ravi@ximian.com>
21500 * expression.cs (IsApplicable): Ensure that we add the "&" to
21501 ref/out types before comparing it with the type of the argument.
21503 (IsParamsMethodApplicable): Ditto.
21505 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
21508 * delegate.cs : Handle the case when we have more than one applicable
21509 method. Flag an error only when we finish checking all.
21511 2002-05-02 Miguel de Icaza <miguel@ximian.com>
21513 * expression.cs: Add support for boolean static initializers.
21515 2002-05-01 Miguel de Icaza <miguel@ximian.com>
21517 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
21519 * parameter.cs (ComputeParameterTypes,
21520 ComputeAndDefineParameterTypes): Better error handling: now we
21521 clear the `types' cache if we fail during any of the type lookups.
21522 We also return the status code correctly to our caller
21524 * delegate.cs: If we fail to define a delegate, abort the extra
21527 * expression.cs (Binary.ResolveOperator): for
21528 operator==(object,object) and operator !=(object, object) we also
21529 have to verify that there is an implicit conversion from one to
21532 (ArrayAccess.DoResolve): Array Access can operate on
21535 2002-04-30 Miguel de Icaza <miguel@ximian.com>
21537 * assign.cs (CompoundAssign): A new class used as a "flag" that
21538 the assignment actually is happening as part of a compound
21539 assignment operator.
21541 During compound assignment, a few new rules exist to enable things
21548 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
21549 to the type of x) if y is implicitly convertible to the type of x,
21550 and the operator is a builtin operator and the return type of the
21551 operator is explicitly convertible to the type of x.
21553 * rootcontext.cs: Reset warning level to 2. 4 catches various
21554 "interesting" features in mcs, we must clean this up at some
21555 point, but currently am trying to kill other bugs ;-)
21557 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
21558 in container classes as well.
21560 * expression.cs (Binary.ResolveOperator): Handle string case
21561 before anything else (as operator overloading does emit an error
21562 before doing anything else).
21564 This code could go away when we move to a table driven model, but
21565 i could not come up with a good plan last night.
21567 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
21569 * typemanager.cs (CSharpName): reimplementation using regex.
21570 * class.cs: added null check for fields in Emit
21571 * rootcontext.cs: set warninglevel to 4
21573 2002-04-29 Miguel de Icaza <miguel@ximian.com>
21575 * typemanager.cs (CSharpName): reimplemented with Lupus
21578 2002-04-28 Miguel de Icaza <miguel@ximian.com>
21580 * statement.cs (If): correclty implement Resolve, because we were
21581 not catching sem errors in there. The same process is needed
21583 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
21586 (Statement.Warning_DeadCodeFound): Factorize code.
21587 (While): Report dead code here too.
21589 (Statement): Added Resolve virtual method to allow
21590 for resolution split from the emit code.
21592 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21594 * statement.cs (EmitBoolExpression): No longer try to resolve the
21596 (MakeBoolean): New utility function that resolve, implicitly
21597 converts to boolean and tags the expression.
21600 (If, Do): Implement dead code elimination.
21601 (While): Implement loop inversion
21603 (Do, While, For, If): Resolve the expression prior to calling our
21606 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
21609 - added method Report28 (warning: program has more than one entry point)
21610 - added method IsEntryPoint, implements paragraph 10.1 of the spec
21611 - modified method Method.Define, the part at the end of the method
21613 * rootcontext.cs: added static public Location EntryPointLocation;
21615 * ../errors/cs0028.cs : Add test case for the above warning.
21618 - modified method CSharpName to allow arrays of primitive type to
21619 be printed nicely (e.g. instead of System.Int32[][] it now prints
21621 - added method CSharpSignature: returns the signature of a method
21622 in string format to be used in reporting errors, warnings, etc.
21624 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
21627 2002-04-26 Ravi Pratap <ravi@ximian.com>
21629 * delegate.cs (Define): Fix extremely silly bug where I was
21630 setting the type of the 'object' parameter of the BeginInvoke
21631 method to System.IAsyncResult instead of System.Object ;-)
21633 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21635 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
21638 (Constructor.Emit): return if we fail to initialize the
21639 constructor. Another door closed!
21641 * expression.cs (New.DoResolve): Improve error message (from -6 to
21642 1501). Use DeclaredOnly lookup to find the exact constructor.
21644 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
21645 loop. This is useful.
21647 * cs-parser.jay: Adjust the default parameters so that destructors
21648 have the proper signature.
21650 2002-04-26 Martin Baulig <martin@gnome.org>
21652 * driver.cs (LoadAssembly): If `assembly' contains any characters
21653 which are only valid in path names and not in assembly names
21654 (currently slash, backslash and point), use Assembly.LoadFrom ()
21655 instead of Assembly.Load () on the `assembly' (before iteration
21656 over the link_paths).
21658 2002-04-26 Martin Baulig <martin@gnome.org>
21660 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
21662 2002-04-25 Miguel de Icaza <miguel@ximian.com>
21664 * class.cs (Property): use the new typemanager.MemberLookup
21666 (TypeContainer.MemberLookup): Implement using the
21667 TypeManager.MemberLookup now.
21669 * typemanager.cs: Make MemberLookup a function of the TypeManager,
21670 and return MemberInfos, so that these can be used without an
21671 EmitContext (what we had before).
21673 2002-04-24 Miguel de Icaza <miguel@ximian.com>
21675 * expression.cs: Fix the case where the argument to params if the
21676 type of the params. I omitted handling this before. Fixed
21678 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21680 * driver.cs: Call BootCorlib_PopulateCoreType
21682 * class.cs (Property.CheckBase): Check for properties only, not
21685 * interface.cs: Temporary hack: try/catch around the
21686 CustomAttributeBuilder, because I am getting an exception that I
21689 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
21690 types whose definitions are required to be there (attributes are
21691 defined before standard types).
21693 Compute definitions as we boot the various types, as they are used
21694 immediately (value_type class will need object_type, but if we do
21695 not initialize object_type, we will pass a null, which will let
21696 the runtime pick the System.Object from the existing corlib, which
21697 is not what we want).
21699 2002-04-22 Patrik Torstensson <totte@labs2.com>
21701 * cs-tokenizer.cs: fixed a number of trim() issues.
21703 2002-04-22 Ravi Pratap <ravi@ximian.com>
21705 * expression.cs (Argument.Type): Ensure that we return the correct
21706 type when we have out or ref parameters [in which case we
21709 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21711 * class.cs (Property, Indexer): Allow extern modifier in there.
21713 * typemanager.cs (InitBaseTypes): Initializes object_type and
21714 value_type, since those will be used early on during the bootstrap
21715 process to compile corlib.
21717 (InitCoreTypes): Move code from here to InitBaseTypes.
21719 2002-04-21 Miguel de Icaza <miguel@ximian.com>
21721 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
21722 single-dimension arrays as using the ldlen opcode.
21724 Daniel Lewis discovered this optimization.
21726 * typemanager.cs: Add signature for System.Array::get_Length
21728 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21730 * statement.cs: report the error when the foreach does not apply to an
21731 array nor a collection.
21733 2002-04-19 Miguel de Icaza <miguel@ximian.com>
21735 * expression.cs: Add implicit conversions to the operator ~.
21737 * constant.cs (DecimalConstant.Emit): Emit decimal value.
21739 * typemanager.cs: Locate the decimal constructor.
21741 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21743 * attribute.cs: use the new property of TypeOf.
21744 * expression.cs: added 'get' property around typearg.
21746 These changes fix a build breaker reported by NickD. Is this the
21747 correct way to fix? If not, please, revert my changes and make it
21750 2002-04-17 Miguel de Icaza <miguel@ximian.com>
21752 * attribute.cs: Add support for typeof in attribute invocations.
21753 I am not sure that this is right though.
21755 2002-04-14 Duncan Mak <duncan@ximian.com>
21757 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
21758 Binary.Operator.Division case.
21760 2002-04-13 Ravi Pratap <ravi@ximian.com>
21762 * class.cs (DefineType): Ensure that we do a proper check on
21763 attribute types and also register it with the TypeManager.
21765 (TypeContainer.Targets): The default for attribute types is
21766 AttributeTargets.All.
21768 * attribute.cs (ApplyAttributes): Registering the attribute type
21769 is done elsewhere, not when we discover we have a Usage attribute.
21771 2002-04-12 Ravi Pratap <ravi@ximian.com>
21773 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21774 and get rid of is_delegate parameter.
21776 * everywhere : update.
21778 2002-04-12 Ravi Pratap <ravi@ximian.com>
21780 * cs-parser.jay (compilation_unit): Revamp completely to use
21781 some new ideas that I got from Rhys' grammar to solve the problems
21782 with assembly level attributes.
21784 (outer_declaration): New grammar production.
21786 (attribute_sections): Add.
21788 (opt_attributes): Base on attribute_sections
21790 (namespace_declaration): Allow opt_attributes to tackle the case
21791 when we have assembly level attributes - we are clever in this
21794 * attribute.cs (ApplyAttributes): Do not worry about assembly
21795 attributes in the non-global context.
21797 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21798 instead of SetGlobalAttributes.
21800 * class.cs, rootcontext.cs : Ensure we define and generate
21801 attribute types before anything else.
21803 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21804 and flag the new error -20 for the case when the attribute type
21805 does not have valid targets specified. csc does not catch this.
21807 * ../errors/errors.txt : update for error # -20
21809 2002-04-11 Ravi Pratap <ravi@ximian.com>
21811 * support.cs (InternalParameters.ParameterModifier): Do some null
21812 checking and return sane values.
21814 * class.cs (Method.Define): If we are a PInvoke method, ensure
21815 that we are static and extern. Report error # 601
21817 * ../errors/cs0601.cs : Add test case for the above error.
21819 2002-04-07 Ravi Pratap <ravi@ximian.com>
21821 * rootcontext.cs (attribute_types): We need to keep type of
21822 all attribute types separately and emit code for them first.
21824 (RegisterAttribute) : Implement.
21826 * class.cs (DefineType): Check if the current Type is a custom
21827 attribute type and register it accordingly.
21829 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21830 adding the first attribute twice and rename to
21832 (SetGlobalAttributes): this.
21834 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21837 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21838 if we are processing global arguments. Hmm, I am unsure of this.
21840 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21842 * expression.cs: added static array of strings to avoid calling
21843 Enum.ToString () for Operator in Binary. Significant recover of
21846 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21848 * class.cs (FindMembers): Allow the Builders of the various
21849 members to be null. If they are skip them. This only happens
21850 during the PInvoke declaration.
21852 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21854 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21855 failure, so we do not keep going afterwards.
21857 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21858 wanted to pass `false' as the `is_delegate' argument. If this is
21859 the case, why not use delegate_type == null to mean `is_delegate =
21860 false' and anything else as is_delegate = true.
21862 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21864 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21865 code for the section, not the beginning of the tests.
21867 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21869 * cfold.cs: Handle operator + (Enum x, Underlying x)
21871 * expression.cs (Binary): same. Warn about errors where we have
21872 Enum/Enum in operator + as well.
21874 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21877 - added support for switch(bool)
21878 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21879 - add TableSwitchEmit() to handle table-based switch statements
21881 2002-04-05 Ravi Pratap <ravi@ximian.com>
21883 * expression.cs (Invocation.OverloadResolve): Factor out code which
21884 does parameter compatibility checking with arguments so that we can
21885 re-use the code even from Delegate.VerifyApplicability
21887 (VerifyArgumentsCompat): Move above code here.
21889 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21890 and instead make a call to the above method.
21892 2002-03-31 Ravi Pratap <ravi@ximian.com>
21894 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21895 We use it to keep track of classes which are attribute types.
21897 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21899 * delegate.cs (Delegate.Define): Correctly define the types in the
21900 presence of fixed and array parameters.
21902 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21905 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21906 include NonPublic after the first iteration.
21908 * class.cs (Indexer.CheckBase): Only check if both parents are
21911 * cs-parser.jay (accessor_body): If empty, set to null.
21913 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21914 same code path here to resolve constants names that we did have in
21915 MemberAccess.DoResolve. There is too much code duplicated here.
21917 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21919 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21921 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21924 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21925 tokens, numbers and strings.
21927 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21930 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21931 asyncronous parameters and the regular parameters.
21933 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21934 specify the target directory.
21936 * expression.cs: (This.DoResolve): Simplify
21937 (As.Emit): Optimize, do not generate IsInst if the expression is
21938 always of the given type.
21940 (Is.DoResolve): Bug fix, we were reporting both always/never for
21943 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21944 creating too many unnecessary arrays.
21946 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21948 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21949 fields instead of rolling our own initializer. Takes care of all
21950 implicit conversions, and drops unnecessary static checks/argument.
21952 2002-03-31 Dick Porter <dick@ximian.com>
21954 * driver.cs: use the GetDirectories() return values properly, and
21955 use "/" as path separator.
21957 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21959 * expression.cs (Unary): Optimize - - expr into expr.
21960 (Binary): Optimize a + (-b) into a -b.
21962 * codegen.cs (CodeGen): Made all methods static.
21964 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21968 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21969 TypeBuilder property.
21971 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21974 * tree.cs: Removed the various RecordXXXX, and replaced with a
21975 single RecordDecl. Removed all the accessor methods, and just
21976 left a single access point Type
21978 * enum.cs: Rename DefineEnum to DefineType.
21980 * decl.cs: New abstract method `DefineType' used to unify the
21981 Defines for Enumerations, Interfaces, TypeContainers and
21984 (FindType): Moved LookupInterfaceOrClass here. Moved the
21985 LookupBaseClasses method that used to live in class.cs and
21986 interface.cs here, and renamed to FindType.
21988 * delegate.cs: Implement DefineType. Take advantage of the
21989 refactored pattern for locating the parent builder without taking
21990 the parent_builder argument (which we know does not work if we are
21991 nested, and triggering a toplevel definition).
21993 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21995 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21996 accessibility of a member has changed during override and report
21999 * class.cs (Method.Define, Property.Define): Only complain on
22000 overrides if the method is private, any other accessibility is
22001 fine (and since we just checked the permission is the same, we are
22004 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
22005 and elif are processed always. The other pre-processing
22006 directives are only processed if we are "taking" the path
22008 2002-03-29 Martin Baulig <martin@gnome.org>
22010 * class.cs (Method.Emit): Only emit symbolic debugging info if the
22011 current location is not Null.
22013 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
22014 a separate method so we can profile it.
22016 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
22017 `span.Seconds' are just seconds, but no minutes or hours.
22018 (MainDriver): Profile the CodeGen.SaveSymbols calls.
22020 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22022 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
22023 Remove the gratuitous set of Final:
22025 // If an interface implementation, then we can set Final.
22026 if (((flags & MethodAttributes.Abstract) == 0) &&
22027 implementing.DeclaringType.IsInterface)
22028 flags |= MethodAttributes.Final;
22030 I do not know what I was smoking when I used that.
22033 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
22034 step into fixing the name resolution issues for delegates and
22035 unifying the toplevel name resolution.
22037 2002-03-28 Martin Baulig <martin@gnome.org>
22039 * class.cs (Method.Emit): If we have a symbol writer, call its
22040 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
22041 tell it about the current method.
22043 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
22044 writer that we're going to emit the first byte of IL code for a new
22045 statement (a new source line).
22046 (EmitContext.EmitTopBlock): If we have a symbol writer, call
22047 EmitContext.Mark() before emitting any code.
22049 * location.cs (SymbolDocument): Return null when we're Null.
22051 * statement.cs (Statement): Moved the `Location loc' variable here.
22052 (Statement.EmitBoolExpression): If we have a symbol writer, call
22053 ec.Mark() before emitting any code to tell it that we're at the
22054 beginning of a new statement.
22055 (StatementExpression): Added `Location' argument to the constructor.
22056 (Block): Added public readonly variable `StartLocation' and public
22057 variable `EndLocation'. The latter is to be set using SetEndLocation().
22058 (Block): Added constructor which takes a start and end location.
22059 (Block.SetEndLocation): New method. This sets the end location.
22060 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
22061 local variables we create.
22062 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
22063 each statement and do also mark the begin and end of the block.
22065 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
22066 tell it the current lexer.Location, use Location.Null for the end of the
22068 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22069 current block, set its end location using SetEndLocation().
22070 (statement_expression): StatementExpression constructor now takes the
22071 lexer.Location as additional argument.
22072 (for_statement, declare_local_variables): Likewise.
22073 (declare_local_variables): When creating a new implicit block, use the
22074 new Block constructor and pass it the lexer.Location.
22076 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22078 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
22079 members also on the parent interfaces recursively.
22081 2002-03-27 Miguel de Icaza <miguel@ximian.com>
22083 * report.cs: Use new formats, since Gonzalo finished the missing
22086 * expression.cs (Binary.ResolveOperator): added missing operator|
22087 operator& and operator^ for bool/bool.
22089 * cs-parser.jay: CheckDef now takes a Location argument that is
22090 used to report errors more precisly (instead of reporting the end
22091 of a definition, we try to track something which is a lot closer
22092 to the source of the problem).
22094 * cs-tokenizer.cs: Track global token use, so we can properly flag
22095 the use of #define/#undef after the first token has been seen.
22097 Also, rename the reportXXXX to Error_DescriptiveName
22099 * decl.cs (DeclSpace.IsTopLevel): Move property here from
22100 TypeContainer, so that Enum and Interface can use this too.
22102 * class.cs (TypeContainer.LookupInterfaceOrClass,
22103 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
22104 `builder' argument. Typically this was used to pass the parent
22105 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
22108 The problem is that a nested class could trigger the definition of
22109 a toplevel class, and the builder would be obviously wrong in that
22112 So we drop this argument, and we compute dynamically the
22113 TypeBuilder/ModuleBuilder (the correct information was available
22114 to us anyways from DeclSpace.Parent)
22116 * interface.cs (Interface.DefineInterface): Drop builder
22117 parameter cleanup like class.cs
22119 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
22122 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
22125 (Try.Emit): Propagate the returns value from the statement.
22127 (Return.Emit): Even if we are leavning
22129 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
22131 * modifiers.cs: Fix the computation of MethodAttributes flags.
22133 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
22135 * driver.cs: allow compilation of files that start with '/'.
22136 Add a default case when checking the argument of --target.
22138 2002-03-25 Miguel de Icaza <miguel@ximian.com>
22140 * interface.cs: Implement the same search algorithm for types in
22141 the interface code.
22143 * delegate.cs: Do not allow multiple definition.
22145 * Recovered ChangeLog that got accidentally amputated
22147 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
22149 * rootcontext.cs: Load manually enum to allow core classes to
22150 contain enumerations.
22152 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
22153 Update to new static methods in TypeManager.
22155 * typemanager.cs (GetMethod, GetConstructor): Use our
22156 implementation of FindMembers to find the members, since during
22157 corlib compilation, the types are TypeBuilders and GetMethod and
22158 GetConstructor do not work.
22160 Make all methods in TypeManager static.
22162 (InitCodeHelpers): Split the functionality from
22163 the InitCodeTypes function.
22165 * driver.cs: Call InitCodeHelpers after we have populated the
22168 * cs-parser.jay (delegate_declaration): we did not used to compute
22169 the delegate name correctly for void delegates.
22171 2002-03-24 Miguel de Icaza <miguel@ximian.com>
22173 * rootcontext.cs (RootContext): Init the interface_resolve_order
22174 and type_container_resolve_order always.
22176 (ResolveCore, BootstrapCorlib_ResolveClass,
22177 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
22178 compiler when compiling with --nostdlib
22180 * class.cs (TypeContainer.DefineType): Check that our parent is
22181 not null. This test is most important when we are bootstraping
22184 * codegen.cs: Split out the symbol writing code.
22186 2002-03-25 Martin Baulig <martin@gnome.org>
22188 * driver.cs (-g): Made -g an alias for --debug.
22190 2002-03-24 Martin Baulig <martin@gnome.org>
22192 * codegen.cs (SymbolWriter): New public variable. Returns the
22193 current symbol writer.
22194 (CodeGen): Added `bool want_debugging_support' argument to the
22195 constructor. If true, tell the ModuleBuild that we want debugging
22196 support and ask it for the ISymbolWriter.
22197 (Save): If we have a symbol writer, call it's Close() method after
22198 saving the assembly.
22200 * driver.c (--debug): New command line argument to create a
22201 debugger information file.
22203 * location.cs (SymbolDocument): New public property. Returns an
22204 ISymbolDocumentWriter object for the current source file or null
22205 if we don't have a symbol writer.
22207 2002-03-21 Miguel de Icaza <miguel@ximian.com>
22209 * driver.cs (LoadAssembly): Correctly return when all the paths
22210 have been tried and not before.
22212 * statement.cs (Switch.Emit): return the actual coverage for this
22213 statement (returns/not-returns)
22215 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
22216 switch of the statement if we are the last switch section. That
22217 kills two problems: try/catch problems (we used to emit an empty
22218 nop at the end) and switch statements where all branches would
22221 2002-03-19 Miguel de Icaza <miguel@ximian.com>
22223 * driver.cs: Add default assemblies (the equivalent to the
22224 Microsoft CSC.RSP file)
22226 * cs-tokenizer.cs: When updating `cols and setting it to zero,
22227 also update tokens_seen and set it to false.
22229 * driver.cs: Implement --recurse for Mike.
22231 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
22232 correctly splitting out the paths.
22234 2002-03-18 Miguel de Icaza <miguel@ximian.com>
22236 * interface.cs (Interface.PopulateProperty): Instead of using
22237 `parent' as the declaration space for the set parameters, use
22240 * support.cs (InternalParameters): InternalParameters constructor
22241 takes a DeclSpace instead of a TypeContainer.
22243 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
22244 types are being initialized, load the address of it before calling
22247 (New): Provide a mechanism to disable the generation of local
22248 value type temporaries when the caller will be providing us with
22249 an address to store it.
22251 (ArrayCreation.EmitDynamicInitializers): Use it.
22253 2002-03-17 Miguel de Icaza <miguel@ximian.com>
22255 * expression.cs (Invocation.EmitArguments): Only probe for array
22256 property if there is more than one argument. Sorry about that.
22258 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
22259 empty param arrays.
22261 * class.cs (Method.LabelParameters): Fix incorrect code path that
22262 prevented the `ParamArrayAttribute' from being applied to the
22265 2002-03-16 Miguel de Icaza <miguel@ximian.com>
22267 * support.cs (ReflectionParameters): Correctly compute whether the
22268 last argument is a params array. Fixes the problem with
22271 * typemanager.cs: Make the assemblies array always be non-null
22272 (empty, but non-null)
22274 * tree.cs (RecordDecl): New function that abstracts the recording
22275 of names. This reports error 101, and provides a pointer to the
22276 previous declaration. Fixes a crash in the compiler.
22278 * cs-parser.jay (constructor_declaration): Update to new grammar,
22279 and provide a constructor_body that can be empty.
22281 2002-03-15 Miguel de Icaza <miguel@ximian.com>
22283 * driver.cs: Add support for --resources.
22285 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
22286 Make all types for the various array helper methods be integer.
22288 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
22289 CheckState to ConvCast.
22291 (ConvCast): Now it takes a `checked' state argument, to avoid
22292 depending on the emit context for the conversion, and just using
22293 the resolve time setting.
22295 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
22296 instead of Invocation.EmitArguments. We do not emit the original
22297 arguments, instead we emit those which have been converted to
22298 unsigned int expressions.
22300 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
22302 * codegen.cs: ditto.
22304 * expression.cs (LocalVariableReference): Drop the use of the
22305 Store function that depended on the variable index.
22307 * statement.cs (VariableInfo): Drop the `Idx' property from this
22308 class, as this is not taking into account the indexes for
22309 temporaries tat we generate during the execution, getting the
22312 * class.cs: First emit class initializers, then call the parent
22315 * expression.cs (Binary): Fix opcode emision.
22316 (UnaryMutator.EmitCode): Support checked code generation
22318 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
22319 matches for events for both the Static and Instance scans,
22320 pointing to the same element. Fix that.
22322 2002-03-14 Miguel de Icaza <miguel@ximian.com>
22324 * rootcontext.cs (ResolveTree): Always set the
22325 interface_resolve_order, because nested interfaces will be calling
22328 * class.cs (GetInterfaceOrClass): Track the same resolution
22329 process used by TypeManager.LookupType. This fixes the nested
22330 type lookups in class declarations (separate path from
22333 (TypeContainer.DefineType): Also define nested interfaces.
22334 (TypeContainer.RegisterOrder): New public function used to
22335 register the order in which child interfaces need to be closed.
22337 Nested interfaces need to be closed after their parents have been
22340 * interface.cs (InterfaceAttr): Put all the logic for computing
22341 the interface attribute here.
22343 (DefineInterface): Register our interface order with the
22344 RootContext or with the TypeContainer depending on the case.
22346 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22348 * cs-parser.jay: rework foreach statement to work with the new
22349 changes to the policy on SimpleNames.
22351 * report.cs: support Stacktrace on warnings as well.
22353 * makefile: drop --unsafe and /unsafe from the compile.
22355 2002-03-13 Ravi Pratap <ravi@ximian.com>
22357 * ecore.cs (StandardConversionExists): Modify to take an Expression
22358 as the first parameter. Ensure we do null -> reference type conversion
22361 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
22362 temporary Expression objects.
22364 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
22366 * interface.cs: workaround bug in method overloading resolution
22367 (there is already a bugzilla bug for it).
22369 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22371 We could also solve this problem by having a separate path for
22372 performing type lookups, instead of DoResolve, we could have a
22373 ResolveType entry point, and only participating pieces of the
22374 production (simplename, deref, array) would implement this.
22376 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
22377 signal SimpleName to only resolve type names and not attempt to
22378 resolve anything else.
22380 * expression.cs (Cast): Set the flag.
22382 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
22384 * class.cs: Only report 108 if there is no `new' modifier.
22386 * cs-parser.jay: rework foreach statement to work with the new
22387 changes to the policy on SimpleNames.
22389 * report.cs: support Stacktrace on warnings as well.
22391 * makefile: drop --unsafe and /unsafe from the compile.
22393 2002-03-11 Miguel de Icaza <miguel@ximian.com>
22395 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22396 lookups here, instead of doing that at parse time. This means
22397 that our grammar will not introduce `LocalVariableReferences' as
22398 expressions at this point. That solves the problem of code like
22402 static void Main ()
22406 This is only half the fix. The full fix requires parameters to
22407 also be handled in this way.
22409 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
22410 makes the use more obvious of the DeclSpace. The
22411 ec.TypeContainer.TypeBuilder is now only used to pull the
22412 TypeBuilder for it.
22414 My theory is that I can get rid of the TypeBuilder completely from
22415 the EmitContext, and have typecasts where it is used (from
22416 DeclSpace to where it matters).
22418 The only pending problem is that the code that implements Aliases
22419 is on TypeContainer, and probably should go in DeclSpace.
22421 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22422 lookups here, instead of doing that at parse time. This means
22423 that our grammar will not introduce `LocalVariableReferences' as
22424 expressions at this point. That solves the problem of code like
22428 static void Main ()
22432 This is only half the fix. The full fix requires parameters to
22433 also be handled in this way.
22435 * class.cs (Property.DefineMethod): When implementing an interface
22436 method, set newslot, when implementing an abstract method, do not
22437 set the flag (before we tried never setting it, or always setting
22438 it, which is the difference).
22439 (Indexer.DefineMethod): same.
22440 (Method.DefineMethod): same.
22442 * ecore.cs: Only set the status used flag if we get back a Field.
22444 * attribute.cs: Temporary hack, so Paolo can keep working.
22446 2002-03-08 Ravi Pratap <ravi@ximian.com>
22448 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
22449 the unmanaged type in the case we have a MarshalAs attribute.
22451 (Resolve): Handle the case when we are parsing the special MarshalAs
22452 attribute [we need to store the unmanaged type to use later]
22454 * typemanager.cs (marshal_as_attr_type): Built in type for the
22455 MarshalAs Attribute.
22457 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
22458 on parameters and accordingly set the marshalling info.
22460 2002-03-09 Miguel de Icaza <miguel@ximian.com>
22462 * class.cs: Optimizing slightly by removing redundant code after
22463 we switched to the `NoTypes' return value.
22464 (Property.DefineMethod): use NoTypes here too.
22466 This fixes the bug I introduced in my last batch of changes.
22468 2002-03-05 Ravi Pratap <ravi@ximian.com>
22470 * tree.cs (RecordEnum): Add. We now keep track of enums too.
22472 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
22473 Enums since those are types too.
22475 * cs-parser.jay (enum_declaration): Record enums as we parse them.
22477 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
22478 thanks to a call during the lookup process.
22480 2002-03-07 Miguel de Icaza <miguel@ximian.com>
22482 * statement.cs (Foreach): Lots of work to accomodate a particular
22483 kind of foreach statement that I had not kept in mind. It is
22484 possible to have foreachs on classes that provide a GetEnumerator
22485 method that return objects that implement the "pattern" for using
22486 a foreach, there is no need to support GetEnumerator
22489 This is needed to compile nant.
22491 * decl.cs: Only report 114 if the member is not `Finalize' and if
22492 the warning level is at least 2.
22494 * class.cs: Moved the compare function from Method to
22497 (MethodSignature.InheritableMemberSignatureCompare): Add new
22498 filter function that is used to extract inheritable methods from a
22501 (Method.Define): Use the new `inheritable_method_signature_filter'
22504 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
22507 2002-03-06 Miguel de Icaza <miguel@ximian.com>
22509 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
22511 * cs-parser.jay: Add opt_semicolon to the interface declaration.
22513 * expression.cs: Pass location information to
22514 ConvertImplicitStandard.
22516 * class.cs: Added debugging code to track return values from
22519 2002-03-05 Miguel de Icaza <miguel@ximian.com>
22521 * expression.cs (Is.DoResolve): If either side of the `is' is an
22522 interface, do not flag the warning.
22524 * ecore.cs (ImplicitReferenceConversion): We need a separate test
22527 * report.cs: Allow for --fatal to be used with --probe.
22529 * typemanager.cs (NoTypes): Move the definition for the empty Type
22532 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
22534 (TypeContainer.DefineProxy): New function used to proxy to parent
22535 implementations when implementing interfaces.
22536 (TypeContainer.ParentImplements): used to lookup if our parent
22537 implements a public function that is required by an interface.
22538 (TypeContainer.VerifyPendingMethods): Hook this up.
22540 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
22541 `modules' and `assemblies' arraylists into arrays. We only grow
22542 these are the very early start up of the program, so this improves
22543 the speedof LookupType (nicely measured).
22545 * expression.cs (MakeByteBlob): Replaced unsafe code with
22546 BitConverter, as suggested by Paolo.
22548 * cfold.cs (ConstantFold.Binary): Special case: perform constant
22549 folding of string concatenation, but if either side is a string,
22550 and the other is not, then return null, and let the runtime use
22551 the concatenation on the string plus the object (using
22552 `Object.ToString').
22554 2002-03-04 Miguel de Icaza <miguel@ximian.com>
22556 Constant Folding has been implemented now.
22558 * expression.cs (Unary.Reduce): Do not throw an exception, catch
22559 the error instead on types that are not supported in one's
22562 * constant.cs (Constant and all children): New set of functions to
22563 perform implict and explicit conversions.
22565 * ecore.cs (EnumConstant): Implement the new functions to perform
22566 conversion by proxying to the child expression.
22568 * codegen.cs: (ConstantCheckState): Constant evaluation has its
22569 own separate setting that can not be turned off from the command
22570 line using --unchecked or --checked and is only controlled using
22571 the checked/unchecked statements and expressions. This setting is
22572 used by the constant folder to flag errors.
22574 * expression.cs (CheckedExpr, UncheckedExpr): Set the
22575 ConstantCheckState as well.
22577 During Resolve, they also have to flag the state, because the
22578 constant folder runs completely in the Resolve phase.
22580 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
22583 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22585 * cfold.cs: New file, this file contains the constant folder.
22587 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
22588 argument to track whether we are using the resulting address to
22589 load or store a value and provide better error messages.
22591 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
22592 new AddressOf arguments.
22594 * statement.cs (Foreach.EmitCollectionForeach): Update
22596 * expression.cs (Argument.Emit): Call AddressOf with proper
22597 arguments to track usage.
22599 (New.DoEmit): Call AddressOf with new arguments.
22601 (Unary.Emit): Adjust AddressOf call.
22603 2002-03-01 Ravi Pratap <ravi@ximian.com>
22605 * cs-parser.jay (member_access): Change the case for pre-defined types
22606 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
22609 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
22612 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
22613 essentially like methods and apply attributes like MethodImplOptions to them too.
22615 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
22618 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
22619 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
22622 * Update code everywhere accordingly.
22624 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
22626 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
22628 2002-02-28 Ravi Pratap <ravi@ximian.com>
22630 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
22631 try performing lookups against those instead of jumping straight into using
22632 the 'using' clauses.
22634 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
22636 (LookupType): Perform lookups in implicit parents too.
22638 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
22639 sequence as RootContext.LookupType.
22641 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
22642 the various cases of namespace lookups into this method.
22644 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22646 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
22647 in positional arguments)
22649 * class.cs (Operator): Update the AllowedModifiers to contain
22652 * cs-parser.jay: Update operator declaration to allow for the
22653 operator body to be empty.
22655 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
22658 2002-02-27 Miguel de Icaza <miguel@ximian.com>
22660 * class.cs (Method.Emit): Label parameters.
22662 * driver.cs: Return 1 or 0 as the program exit code.
22664 2002-02-26 Miguel de Icaza <miguel@ximian.com>
22666 * expression.cs: Special case the `null' object when trying to
22667 auto-compute the type, as anything can be explicitly converted to
22670 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
22671 spotting this Paolo.
22673 (Expression.ImplicitNumericConversion): Perform comparissions of
22674 the type using the underlying type in the case of an enumeration
22675 rather than using the enumeration type for the compare.
22677 Cope with the underlying == type case, which is not possible to
22680 (Expression.ConvertNumericExplicit): Perform comparissions of
22681 the type using the underlying type in the case of an enumeration
22682 rather than using the enumeration type for the compare.
22684 * driver.cs: If the user does not supply an extension, assume .exe
22686 * cs-parser.jay (if_statement): Rewrote so that we can track the
22687 location for the if statement.
22689 * expression.cs (Binary.ConstantFold): Only concat strings when
22690 the operation is "+", not everything ;-)
22692 * statement.cs (Statement.EmitBoolExpression): Take a location
22694 (If, While, Do): Track location.
22696 * expression.cs (Binary.ResolveOperator): In the object + string
22697 case, I was missing a call to ConvertImplicit
22699 2002-02-25 Ravi Pratap <ravi@ximian.com>
22701 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
22702 Location arguments. Ensure we use RootContext.LookupType to do our work
22703 and not try to do a direct Type.GetType and ModuleBuilder.GetType
22705 * interface.cs (PopulateMethod): Handle the type of the parameter being
22708 * expression.cs (Invocation.BetterFunction): Handle the case when we
22709 have a params method with no fixed arguments and a call is made with no
22712 2002-02-25 Miguel de Icaza <miguel@ximian.com>
22714 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
22715 the verbatim-string-literal
22717 * support.cs (InternalParameters.ParameterModifier): handle null
22719 (InternalParameters.ParameterType): ditto.
22721 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
22722 duplicating the name of the variable parameter.
22723 (GetParameterByName): Fix bug where we were not looking up array
22724 paramters if they were the only present (thanks Paolo!).
22725 (GetParameterInfo): We only have an empty set of types if both
22726 fixed and array are set to null.
22727 (GetParameterInfo-idx): Handle FixedParameter == null
22729 * cs-parser.jay: Handle the case where there is no catch
22730 statements (missing null test).
22732 2002-02-22 Miguel de Icaza <miguel@ximian.com>
22734 * driver.cs (MainDriver): Be conservative on our command line
22737 Catch DirectoryNotFoundException when calling GetFiles.
22739 (SplitPathAndPattern): Used to split the input specification into
22740 a path and a pattern that we can feed to Directory.GetFiles.
22742 2002-02-21 Miguel de Icaza <miguel@ximian.com>
22744 * statement.cs (Fixed): Implement the last case of the Fixed
22745 statement (string handling).
22747 * expression.cs (StringPtr): New class used to return a char * to
22748 a string; Used by the Fixed statement.
22750 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
22752 * expression.cs (Binary.ResolveOperator): Remove redundant
22753 MemberLookup pn parent type.
22754 Optimize union call, we do not need a union if the types are the same.
22755 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
22758 Specialize the use of MemberLookup everywhere, instead of using
22759 the default settings.
22761 (StackAlloc): Implement stackalloc keyword.
22763 * cs-parser.jay: Add rule to parse stackalloc.
22765 * driver.cs: Handle /h, /help, /?
22767 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22768 before we supported unsafe code.
22770 * makefile: add --unsafe to the self compilation of mcs.
22772 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22774 * expression.cs (PointerArithmetic): New class that is used to
22775 perform pointer arithmetic.
22776 (Binary.Resolve): Handle pointer arithmetic
22777 Handle pointer comparission.
22778 (ArrayPtr): Utility expression class that is used to take the
22779 address of an array.
22781 (ElementAccess): Implement array access for pointers
22783 * statement.cs (Fixed): Implement fixed statement for arrays, we
22784 are missing one more case before we are done.
22786 * expression.cs (Indirection): Implement EmitAssign and set the
22787 ExprClass to Variable. This allows pointer dereferences to be
22788 treated as variables, and to have values assigned to them.
22790 * ecore.cs (Expression.StoreFromPtr): New utility function to
22791 store values dereferencing.
22793 2002-02-20 Ravi Pratap <ravi@ximian.com>
22795 * expression.cs (Binary.ResolveOperator): Ensure that we are
22796 not trying to operate on a void type - this fixes the reported
22799 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22800 the parent implementation is sealed.
22802 * ../errors/cs0239.cs : Add.
22804 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22806 * typemanager.cs (unverifiable_code_type): Corresponds to
22807 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22808 which have unsafe code in them.
22810 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22813 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22815 * cs-tokenizer.cs: Add support for @"litreal strings"
22817 Make tokenizer accept pre-processor directives
22818 on any column (remove the old C-like limitation).
22820 * rootcontext.cs (EmitCode): Emit any global attributes.
22821 (AddGlobalAttributes): Used to keep track of assembly attributes.
22823 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22825 * cs-parser.jay: Add support for global attributes.
22827 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22829 * expression.cs (Indirection): New helper class. Unary will
22830 create Indirection classes to be able to implement the
22831 IMemoryLocation interface on it.
22833 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22835 * cs-parser.jay (fixed_statement): reference the right statement.
22837 * statement.cs (Fixed.Emit): Finish implementing the fixed
22838 statement for the &x case.
22840 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22842 * class.cs (Property.Define, Method.Define): Remove newslot when
22845 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22846 wrong. NewSlot should only be used if the `new' keyword is present.
22848 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22849 locating our system dir. Sorry about this.
22851 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22853 * driver.cs (GetSystemDir): Compute correctly the location of our
22854 system assemblies. I was using the compiler directory instead of
22855 the library directory.
22857 2002-02-13 Ravi Pratap <ravi@ximian.com>
22859 * expression.cs (BetterFunction): Put back in what Miguel commented out
22860 since it is the correct fix. The problem is elsewhere ;-)
22862 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22863 parameters of the parms method are themselves compatible or not !
22865 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22866 to check that a class implements an interface before saying that an implicit
22867 conversion was allowed. Use ImplementsInterface to do the checking.
22869 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22871 * class.cs (Method.Define): Track whether we are an explicit
22872 implementation or not. And only call DefineMethodOverride if we
22873 are an explicit implementation.
22875 (Property.DefineMethod): Ditto.
22877 2002-02-11 Ravi Pratap <ravi@ximian.com>
22879 * expression.cs (BetterFunction): Catch hideous bug which was
22880 preventing us from detecting ambiguous calls due to implicit casts i.e
22883 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22885 * support.cs (Pair): Remove un-needed method. I figured why I was
22886 getting the error in cs-parser.jay, the variable in a foreach loop
22887 is readonly, and the compiler does not really treat this as a variable.
22889 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22890 instead of EQUALS in grammar.
22892 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22894 * expression.cs (Unary.DoResolve): Check whether the argument is
22897 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22899 * support.cs: Api for Pair to set a value. Despite the fact that
22900 the variables are public the MS C# compiler refuses to compile
22901 code that accesses the field if the variable is part of a foreach
22904 * statement.cs (Fixed): Begin implementation of the fixed
22907 (Block.AddVariable): Return the VariableInfo on success and null
22908 on failure instead of true/false.
22910 * cs-parser.jay (foreach): Catch errors on variables already
22911 defined (we were ignoring this value before) and properly unwind
22912 the block hierarchy
22914 (fixed_statement): grammar for the fixed statement.
22916 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22918 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22919 pointer types to be incretemented.
22921 (SizeOf): Implement.
22923 * cs-parser.jay (pointer_member_access): Implement
22924 expr->IDENTIFIER production.
22926 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22927 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22930 (Unary): Implement indirection.
22932 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22933 use in non-unsafe context).
22935 (SimpleName.DoResolve): Check for pointers in field access on safe
22938 (Expression.LoadFromPtr): Factor the load-indirect code in this
22939 function. This was duplicated in UnboxCast and ParameterReference
22941 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22943 * expression.cs (ComposedCast): report an error if a pointer cast
22944 is used in a safe region.
22946 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22947 pointer type casts in unsafe context.
22949 * codegen.cs (EmitContext): Set up IsUnsafe.
22951 * cs-parser.jay (non_expression_type): Add productions for pointer
22954 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22955 code. We should not use force into static mode if the method is
22956 not virtual. Fixes bug in MIS
22958 * statement.cs (Do.Emit, While.Emit, For.Emit,
22959 Statement.EmitBoolExpression): Add support to Do and While to
22960 propagate infinite loop as `I do return' semantics.
22962 Improve the For case to also test for boolean constants.
22964 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22965 to the list of attributes we can add.
22967 Remove `EmitContext' argument.
22969 * class.cs (Method.Define): Apply parameter attributes.
22970 (Constructor.Define): Apply parameter attributes.
22971 (MethodCore.LabelParameters): Move here the core of labeling
22974 * support.cs (ReflectionParameters.ParameterModifier,
22975 InternalParameters.ParameterModifier): Use IsByRef on the type and
22976 only return the OUT bit for these parameters instead of in/out/ref
22979 This is because I miss-understood things. The ParameterInfo.IsIn
22980 and IsOut represent whether the parameter has the [In] and [Out]
22983 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22985 * ecore.cs (FieldExpr.Emit): Release temporaries.
22987 * assign.cs (LocalTemporary.Release): new function.
22989 * codegen.cs (EmitContext.GetTemporaryStorage,
22990 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22991 temporary storage. Now we can "put back" localbuilders when we
22994 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22996 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22997 need to make a copy of the variable to generate verifiable code.
22999 2002-01-19 Miguel de Icaza <miguel@ximian.com>
23001 * driver.cs: Compute dynamically the system directory.
23003 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
23004 Slower, but more generally useful. Used by the abstract
23005 registering implementation.
23007 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
23008 the rules for the special rule on Type/instances. First check if
23009 we have the same name, and if so, try that special static path
23010 rather than the instance path.
23012 2002-01-18 Miguel de Icaza <miguel@ximian.com>
23014 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
23017 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
23018 Enum, ValueType, Delegate or Array for non-corlib compiles.
23020 * cs-tokenizer.cs: Catch long identifiers (645)
23022 * typemanager.cs (IndexerPropetyName): Ravi never tested this
23025 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
23026 fix, we were returning too early, so we were not registering
23027 pending methods from abstract classes.
23029 Do not register pending methods if the class is abstract.
23031 * expression.cs (Conditional.DoResolve): Report circular implicit
23032 conversions when we neecd to compute it for conditional
23035 (Is.DoResolve): If the expression is always of the provided type,
23036 flag warning 183. If the expression can not ever be of the
23037 provided type flag warning 184.
23039 * class.cs: Catch 169 as well.
23041 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
23044 2002-01-18 Nick Drochak <ndrochak@gol.com>
23046 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
23048 2002-01-17 Miguel de Icaza <miguel@ximian.com>
23050 * interface.cs: (PopulateMethod): Check for pointers being defined
23051 only if the unsafe context is active.
23052 (PopulateProperty): ditto.
23053 (PopulateIndexer): ditto.
23055 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
23056 specified. If pointers are present, make sure that they are
23057 present in an unsafe context.
23058 (Constructor, Constructor.Define): ditto.
23059 (Field, Field.Define): ditto.
23060 (Property, Property.Define): ditto.
23061 (Event, Event.Define): ditto.
23063 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
23064 hashtable if there are classes or structs defined.
23066 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23067 code, as the constant resolution moved.
23069 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
23070 the metadata, so we can flag error 133.
23072 * decl.cs (MemberCore.UnsafeOK): New function to test that a
23073 pointer is being declared in an unsafe context.
23075 2002-01-16 Miguel de Icaza <miguel@ximian.com>
23077 * modifiers.cs (Modifiers.Check): Require a Location argument.
23078 Report error 227 for Unsafe use.
23080 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
23082 * statement.cs (For.Emit): If the test is null, then report that
23083 we do `return', as we wont reach anything afterwards.
23085 (Switch.SwitchGoverningType): Track the expression that matched
23088 * driver.cs: Allow negative numbers as an error code to flag.
23090 * cs-parser.jay: Handle 1551.
23092 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
23094 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23096 * cs-parser.jay: Report 1518 (type declaration can only contain
23097 class, struct, interface, enum or delegate)
23099 (switch_label): Report 1523 (keywords `case' or `default' must
23102 (opt_switch_sections): Report 1522 (empty switch)
23104 * driver.cs: Report 1515 (response file specified multiple times)
23105 Report 1516 (Source file specified multiple times).
23107 * expression.cs (Argument.Resolve): Signal 1510
23109 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
23110 access not allowed in static code)
23112 2002-01-11 Ravi Pratap <ravi@ximian.com>
23114 * typemanager.cs (IsPointerType): Utility method which we are going
23117 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
23118 the object type, so we take care of that.
23120 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
23122 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
23123 added to non-params parameters :-)
23125 * typemanager.cs (CSharpName): Include 'void' type too.
23127 (void_ptr_type): Include in the set of core types.
23129 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
23132 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
23135 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
23136 completely forgotten about it.
23138 2002-01-10 Ravi Pratap <ravi@ximian.com>
23140 * cs-parser.jay (pointer_type): Add. This begins our implementation
23141 of parsing rules for unsafe code.
23143 (unsafe_statement): Implement.
23145 (embedded_statement): Modify to include the above.
23147 * statement.cs (Unsafe): Implement new class for unsafe blocks.
23149 * codegen.cs (EmitContext.InUnsafe): Add. This determines
23150 if the current context is an unsafe one.
23152 * cs-parser.jay (local_variable_pointer_type): Since local variable types
23153 are handled differently, we need separate rules for them.
23155 (local_variable_declaration): Update to use local_variable_pointer_type
23156 to allow variable declarations of unmanaged pointer types.
23158 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
23159 in unsafe contexts.
23161 * ../errors/cs0214.cs : Add.
23163 2002-01-16 Nick Drochak <ndrochak@gol.com>
23165 * makefile: remove 'response' file when cleaning.
23167 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23169 * cs-parser.jay: Report 1524.
23171 2002-01-14 Miguel de Icaza <miguel@ximian.com>
23173 * typemanager.cs (RegisterMethod): drop checking if we have
23174 registered this from here
23176 2002-01-12 Miguel de Icaza <miguel@ximian.com>
23178 * class.cs (Method.EmitDestructor): Implement calling our base
23181 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
23182 value of InFinally.
23184 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
23185 this routine and will wrap the call in a try/catch block. Deal
23188 2002-01-11 Miguel de Icaza <miguel@ximian.com>
23190 * ecore.cs (Expression.MemberLookup): instead of taking a
23191 parameter `same_type' that was used to tell whether we could
23192 access private members we compute our containing type from the
23195 (FieldExpr): Added partial support for volatile fields. This does
23196 not work for volatile fields exposed from assemblies, as I can not
23197 figure out how to extract the modreq from it.
23199 Updated all the source files to use this.
23201 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
23202 because it is referenced by MemberLookup very often.
23204 2002-01-09 Ravi Pratap <ravi@ximian.com>
23206 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
23207 TypeBuilder.GetCustomAttributes to retrieve what we need.
23209 Get rid of redundant default_member_attr_type as this is the same as
23210 default_member_type which already exists.
23212 * interface.cs, attribute.cs : Update accordingly.
23214 2002-01-08 Miguel de Icaza <miguel@ximian.com>
23216 * typemanager.cs: Enable IndexerPropertyName again. It does not
23217 work for TYpeBuilders though. Ravi, can you please fix this?
23219 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
23221 * expression.cs (Argument.Emit): Handle the case of ref objects
23222 being passed to ref functions;
23224 (ParameterReference.EmitLoad): Loads the content of the pointer
23225 without dereferencing.
23227 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23229 * cs-tokenizer.cs: Implemented the pre-processing expressions.
23231 2002-01-08 Ravi Pratap <ravi@ximian.com>
23233 * class.cs (Indexer.DefineMethod): Incorporate the interface
23234 type in the name of the method if we are doing explicit interface
23237 * expression.cs (ConversionExists): Remove as it is completely obsolete.
23239 (BetterConversion): Fix extremely trivial bug where we were referring to
23240 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
23243 * ../errors/bug16.cs : Add although we have fixed it.
23245 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23247 * expression.cs (BaseIndexer): Begin implementation.
23249 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
23251 * cs-parser.jay (indexer_declarator): Use qualified_identifier
23252 production directly to remove a shift/reduce, and implement
23253 explicit interface implementation.
23255 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
23256 after a floating point suffix.
23258 * expression.cs (DoNumericPromotions): Improved the conversion for
23259 uint/uint. If we have a constant, we avoid doing a typecast to a
23262 * class.cs (Indexer): Implement explicit interface implementation
23265 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
23267 * class.cs: make the default instance constructor public and hidebysig.
23269 2001-01-03 Ravi Pratap <ravi@ximian.com>
23271 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
23272 so we can call it from elsewhere.
23274 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
23275 we emit it internally if the class has a defined indexer; otherwise the user
23276 emits it by decorating the class definition with the DefaultMemberAttribute.
23278 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
23279 attribute is not used on a type which defines an indexer.
23281 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
23282 character when we skip whitespace.
23284 * ../errors/cs0646.cs : Add.
23286 2002-01-03 Miguel de Icaza <miguel@ximian.com>
23288 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
23291 * makefile: Add practical target `mcs3.exe' which builds the third
23292 generation compiler.
23294 * expression.cs (New): Fix structures constructor calling.
23296 * class.cs (Property, Method, Indexer): Emit Final flag on the
23297 method if we are an interface implementation and we are not
23300 * ecore.cs (PropertyExpr): New public field `IsBase', tells
23301 whether this property is referencing a `base' method.
23303 * expression.cs (Invocation.EmitCall): take an extra argument:
23304 is_base, this is used to determine whether the `call' or
23305 `callvirt' opcode should be used.
23308 * delegate.cs: update EmitCall.
23310 * class.cs (Method.Define): Set NewSlot for the cases where we are
23311 not implementing an interface method.
23313 (Property.Define): ditto.
23315 2002-01-02 Miguel de Icaza <miguel@ximian.com>
23317 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
23318 'r'. Allows mcs to parse itself fully.
23320 2002-01-02 Ravi Pratap <ravi@ximian.com>
23322 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
23323 of the number of initializers that require the InitializeArray method.
23325 (CheckIndices): Store the Expression in all cases - not the plain value. Also
23326 update the above field where necessary.
23328 (MakeByteBlob): Update accordingly.
23330 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
23333 (EmitDynamicInitializers): Update in accordance with the new optimization.
23335 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
23336 same OpCode applies.
23338 * cs-parser.jay : Fix some glaring errors I introduced.
23340 2002-01-01 Ravi Pratap <ravi@ximian.com>
23342 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
23343 so that we can check for name clashes there too.
23345 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
23346 for interface indexers.
23348 * interfaces.cs (Define): Emit the default member attribute.
23350 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
23351 variable was being referred to while setting the value ;-)
23353 2002-01-01 Miguel de Icaza <miguel@ximian.com>
23355 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
23356 byte-by-byte information when we know the data is zero.
23358 Make the block always a multiple of 4, because
23359 DefineInitializedData has a bug.
23361 * assign.cs: Fix, we should assign from the temporary, not from
23364 * expression.cs (MakeByteBlob): Fix my incorrect code.
23366 2001-12-31 Miguel de Icaza <miguel@ximian.com>
23368 * typemanager.cs (EnumToUnderlying): This function is used to get
23369 the underlying type from an enumeration, because it does not
23372 * constant.cs: Use the I4_S form for values between -128 and 127.
23374 * statement.cs (Block.LookupLabel): Looks up a label.
23375 (Block): Drop support for labeled blocks.
23377 (LabeledStatement): New kind of statement that represents a label
23380 (Goto): Finally implement this bad boy.
23382 * cs-parser.jay: Update to reflect new mechanism to implement
23385 2001-12-30 Miguel de Icaza <miguel@ximian.com>
23387 * codegen.cs (EmitContext.This): a codegen property that keeps the
23388 a single instance of this instead of creating many different this
23391 * delegate.cs (Delegate.DoResolve): Update to use the property;
23393 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
23395 * expression.cs (BaseAccess.DoResolve): Ditto.
23397 2001-12-29 Ravi Pratap <ravi@ximian.com>
23399 * typemanager.cs (methodimpl_attr_type): Add to hold the type
23400 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
23402 (InitCoreTypes): Update accordingly.
23404 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
23405 so we can quickly store the state.
23407 (ApplyAttributes): Set the correct implementation flags
23408 for InternalCall methods.
23410 2001-12-29 Miguel de Icaza <miguel@ximian.com>
23412 * expression.cs (EmitCall): if a method is not virtual, then do
23413 not use callvirt on it.
23415 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
23416 user defined stuff) requires the use of stobj, which takes an
23417 address on the stack instead of an array and an index. So emit
23418 the Ldelema operation for it.
23420 (EmitStoreOpcode): Use stobj for valuetypes.
23422 (UnaryMutator.EmitCode): Use the right 1 value depending on
23423 whether we are dealing with int64/uint64, float or doubles.
23425 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
23426 constructors that I implemented last night.
23428 (Constructor.IsDefault): Fix to work properly for static
23431 * cs-parser.jay (CheckDef): report method signature errors.
23432 Update error number 103 to be 132.
23434 * decl.cs: New AdditionResult enumeration value: MethodExists.
23435 Although we do this check for methods later on in the semantic
23436 analysis, catching repeated default constructors is so easy that
23437 we catch these here.
23439 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
23442 (ParameterReference.EmitAssign, Emit): handle
23445 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
23446 (ArrayAccess.EmitStoreOpcode): ditto.
23448 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
23450 * expression.cs (MakeByteBlob): Complete all the missing types
23451 (uint, short, ushort, byte, sbyte)
23453 * class.cs: Only init instance field initializers on instance
23456 Rename `constructors' to instance_constructors.
23458 (TypeContainer.AddConstructor): Only add constructors to the list
23459 if it is not static.
23461 Make sure that we handle default_static_constructor independently
23462 everywhere where we handle instance_constructors
23464 2001-12-28 Miguel de Icaza <miguel@ximian.com>
23466 * class.cs: Do not lookup or create a base initializer for a
23467 static constructor.
23469 (ConstructorInitializer.Resolve): use the proper type to lookup
23472 * cs-parser.jay: Report error 1585 (modifiers between type and name).
23474 * enum.cs, interface.cs: Remove CloseType, this is taken care by
23477 * decl.cs: CloseType is now an virtual method, the default
23478 implementation just closes this type.
23480 2001-12-28 Ravi Pratap <ravi@ximian.com>
23482 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
23483 to PreserveSig by default. Also emit HideBySig on such methods.
23485 Basically, set the defaults to standard values.
23487 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
23488 argument, if candidate is better, it can't be worse than the best !
23490 (Invocation): Re-write bits to differentiate between methods being
23491 applicable in their expanded form and their normal form - for params
23494 Get rid of use_standard everywhere as only standard conversions are allowed
23495 in overload resolution.
23497 More spec conformance.
23499 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23501 * driver.cs: Add --timestamp, to see where the compiler spends
23504 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
23505 `this' in static code.
23507 (SimpleName.DoResolve): Implement in terms of a helper function
23508 that allows static-references to be passed upstream to
23511 (Expression.ResolveWithSimpleName): Resolve specially simple
23512 names when called by MemberAccess to implement the special
23515 (Expression.ImplicitReferenceConversion): Handle conversions from
23516 Null to reference types before others, as Null's type is
23519 * expression.cs (Invocation.EmitCall): Handle the special case of
23520 calling methods declared on a reference type from a ValueType
23521 (Base classes System.Object and System.Enum)
23523 (MemberAccess.Resolve): Only perform lookups on Enumerations if
23524 the left hand side is a TypeExpr, not on every enumeration.
23526 (Binary.Resolve): If types are reference types, then do a cast to
23527 object on operators != and == of both arguments.
23529 * typemanager.cs (FindMembers): Extract instance and static
23530 members if requested.
23532 * interface.cs (PopulateProperty): Use void_type instead of null
23533 as the return type for the setter method.
23535 (PopulateIndexer): ditto.
23537 2001-12-27 Ravi Pratap <ravi@ximian.com>
23539 * support.cs (ReflectionParameters): Fix minor bug where we
23540 were examining the wrong parameter for the ParamArray attribute.
23542 Cope with requests for the type of the parameter at position
23543 greater than the params parameter's. We now return the element
23544 type of the params array as that makes more sense.
23546 * expression.cs (Invocation.IsParamsMethodApplicable): Update
23547 accordingly as we no longer have to extract the element type
23550 (Invocation.OverloadResolve): Update.
23552 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23554 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
23555 against IEnumerator, test whether the return value is a descendant
23556 of the IEnumerator interface.
23558 * class.cs (Indexer.Define): Use an auxiliary method to implement
23559 the other bits of the method definition. Begin support for
23560 explicit interface implementation.
23562 (Property.DefineMethod): Use TypeManager.void_type instead of null
23563 for an empty return value.
23565 2001-12-26 Miguel de Icaza <miguel@ximian.com>
23567 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
23568 dealing with a FieldExpr which is composed of a FieldBuilder, in
23569 the code path we did extract the constant, but we should have
23570 obtained the underlying value to be able to cast it (otherwise we
23571 end up in an infinite loop, this is what Ravi was running into).
23573 (ArrayCreation.UpdateIndices): Arrays might be empty.
23575 (MemberAccess.ResolveMemberAccess): Add support for section
23576 14.5.4.1 that deals with the special case of E.I when E is a type
23577 and something else, that I can be a reference to a static member.
23579 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
23580 handle a particular array type to create byte blobs, it is just
23581 something we dont generate byteblobs for.
23583 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
23586 * location.cs (Push): remove the key from the hashtable that we
23587 are about to add. This happens for empty files.
23589 * driver.cs: Dispose files after we have parsed them.
23591 (tokenize): new function that only runs the tokenizer on its
23592 input, for speed testing.
23594 2001-12-26 Ravi Pratap <ravi@ximian.com>
23596 * class.cs (Event.Define): Define the private field only if there
23597 are no accessors defined.
23599 * expression.cs (ResolveMemberAccess): If there is no associated
23600 field with the event, that means we have an event defined with its
23601 own accessors and we should flag error cs0070 since transforming
23602 ourselves into a field is not valid in that case.
23604 * ecore.cs (SimpleName.DoResolve): Same as above.
23606 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
23607 and charset to sane values.
23609 2001-12-25 Ravi Pratap <ravi@ximian.com>
23611 * assign.cs (DoResolve): Perform check on events only if they
23612 are being accessed outside the declaring type.
23614 * cs-parser.jay (event_declarations): Update rules to correctly
23615 set the type of the implicit parameter etc.
23617 (add_accessor, remove_accessor): Set current local parameters.
23619 * expression.cs (Binary): For delegate addition and subtraction,
23620 cast the return value from the method into the appropriate delegate
23623 2001-12-24 Ravi Pratap <ravi@ximian.com>
23625 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
23626 of these as the workaround is unnecessary.
23628 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
23629 delegate data - none of that is needed at all.
23631 Re-write bits to extract the instance expression and the delegate method
23634 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
23637 * attribute.cs (ApplyAttributes): New method to take care of common tasks
23638 of attaching attributes instead of duplicating code everywhere.
23640 * everywhere : Update code to do attribute emission using the above method.
23642 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23644 * expression.cs (IsParamsMethodApplicable): if there are not
23645 parameters, return immediately.
23647 * ecore.cs: The 0 literal can be implicity converted to an enum
23650 (SimpleName.DoResolve): First lookup the type, then lookup the
23653 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
23654 want to get its address. If the InstanceExpression is not
23655 addressable, store the result in a temporary variable, then get
23658 * codegen.cs: Only display 219 errors on warning level or above.
23660 * expression.cs (ArrayAccess): Make it implement the
23661 IMemoryLocation interface.
23663 (Binary.DoResolve): handle the operator == (object a, object b)
23664 and operator != (object a, object b) without incurring into a
23665 BoxedCast (because 5 != o should never be performed).
23667 Handle binary enumerator operators.
23669 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
23670 value type, otherwise use Ldelem_ref.
23672 Use precomputed names;
23674 (AddressOf): Implement address of
23676 * cs-parser.jay (labeled_statement): Fix recursive block
23677 addition by reworking the production.
23679 * expression.cs (New.DoEmit): New has a special case:
23681 If we are dealing with a ValueType, we have a few
23682 situations to deal with:
23684 * The target of New is a ValueType variable, that is
23685 easy, we just pass this as the variable reference
23687 * The target of New is being passed as an argument,
23688 to a boxing operation or a function that takes a
23691 In this case, we need to create a temporary variable
23692 that is the argument of New.
23695 2001-12-23 Ravi Pratap <ravi@ximian.com>
23697 * rootcontext.cs (LookupType): Check that current_type is not null before
23698 going about looking at nested types.
23700 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
23701 not implement the IAssignMethod interface any more.
23703 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
23704 where we tranform them into FieldExprs if they are being resolved from within
23705 the declaring type.
23707 * ecore.cs (SimpleName.DoResolve): Do the same here.
23709 * assign.cs (DoResolve, Emit): Clean up code considerably.
23711 * ../errors/bug10.cs : Add.
23713 * ../errors/cs0070.cs : Add.
23715 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
23717 * assign.cs : Get rid of EventIsLocal everywhere.
23719 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23721 * ecore.cs (ConvertIntLiteral): finished the implementation.
23723 * statement.cs (SwitchLabel): Convert the value we are using as a
23724 key before looking up the table.
23726 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23728 * codegen.cs (EmitTopBlock): Require a Location argument now.
23730 * cs-parser.jay (constructor_declarator): We need to setup
23731 current_local_parameters before we parse the
23732 opt_constructor_initializer, to allow the variables to be bound
23733 to the constructor arguments.
23735 * rootcontext.cs (LookupType): First lookup nested classes in our
23736 class and our parents before we go looking outside our class.
23738 * expression.cs (ConstantFold): Extract/debox the values at the
23741 * rootcontext.cs (EmitCode): Resolve the constants first before we
23742 resolve the types. This is not really needed, but it helps debugging.
23744 * statement.cs: report location.
23746 * cs-parser.jay: pass location to throw statement.
23748 * driver.cs: Small bug fix.
23750 * report.cs: Updated format to be 4-zero filled digits.
23752 2001-12-22 Ravi Pratap <ravi@ximian.com>
23754 * expression.cs (CheckIndices): Fix minor bug where the wrong
23755 variable was being referred to ;-)
23757 (DoEmit): Do not call EmitStaticInitializers when the
23758 underlying type is System.Object.
23760 2001-12-21 Ravi Pratap <ravi@ximian.com>
23762 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23763 and do the usual workaround for SRE.
23765 * class.cs (MyEventBuilder.EventType): New member to get at the type
23766 of the event, quickly.
23768 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23770 * assign.cs (Assign.DoResolve): Handle the case when the target
23771 is an EventExpr and perform the necessary checks.
23773 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23776 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23778 (EventExpr): Set the type in the constructor itself since we
23779 are meant to be born fully resolved.
23781 (EventExpr.Define): Revert code I wrote earlier.
23783 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23784 instance expression is null. The instance expression is a This in that case
23785 or a null, depending on whether it is a static method or not.
23787 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23788 refers to more than one method.
23790 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23791 and accordingly flag errors.
23793 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23795 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23797 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23799 * location.cs (ToString): Provide useful rutine.
23801 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23803 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23804 objects, return the actual integral boxed.
23806 * statement.cs (SwitchLabel): define an ILLabel for each
23809 (Switch.CheckSwitch): If the value is a Literal, extract
23810 the underlying literal.
23812 Also in the unused hashtable we had, add the SwitchLabel so we can
23813 quickly look this value up.
23815 * constant.cs: Implement a bunch of new constants. Rewrite
23816 Literal based on this. Made changes everywhere to adapt to this.
23818 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23819 dereferencing array only once, and also copes with enumrations.
23821 bytes are two bytes wide, not one.
23823 (Cast): Perform constant conversions.
23825 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23826 wrappers to the literals here.
23828 * expression.cs (DoNumericPromotions): long literals can converted
23829 to ulong implicity (this is taken care of elsewhere, but I was
23830 missing this spot).
23832 * ecore.cs (Expression.Literalize): Make the return type Literal,
23833 to improve type checking.
23835 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23837 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23839 * literal.cs: Revert code from ravi that checked the bounds. The
23840 bounds are sane by the definition of the type itself.
23842 * typemanager.cs: Fix implementation of ImplementsInterface. We
23843 need to actually look up in our parent hierarchy for interfaces
23846 * const.cs: Use the underlying type for enumerations
23848 * delegate.cs: Compute the basename for the delegate creation,
23849 that should fix the delegate test case, and restore the correct
23850 Type Lookup semantics in rootcontext
23852 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23853 referencing a nested type with the Reflection API is using the "+"
23856 * cs-parser.jay: Do not require EOF token at the end.
23858 2001-12-20 Ravi Pratap <ravi@ximian.com>
23860 * rootcontext.cs (LookupType): Concatenate type names with
23861 a '.' instead of a '+' The test suite passes again.
23863 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23864 field of the enumeration.
23866 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23867 the case when the member is an EventExpr.
23869 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23870 static has an associated instance expression.
23872 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23874 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23876 * class.cs (Event.Define): Register event and perform appropriate checks
23879 We define the Add and Remove methods even if the use provides none because
23880 in that case, we provide default implementations ourselves.
23882 Define a private field of the type of the event. This is done by the CSC compiler
23883 and we should be doing it too ;-)
23885 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23886 More methods we use in code we generate.
23888 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23891 (InitCoreTypes): Update accordingly for the above.
23893 * class.cs (Event.Emit): Generate code for default accessors that we provide
23895 (EmitDefaultMethod): Do the job in the above.
23897 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23900 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23902 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23903 builders even if we were missing one.
23905 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23906 pass the Basename as our class name instead of the Name. The
23907 basename will be correctly composed for us.
23909 * parameter.cs (Paramters): Now takes a Location argument.
23911 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23912 make all the code call directly LookupType in RootContext and take
23913 this chance to pass the Location information everywhere.
23915 * Everywhere: pass Location information.
23917 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23919 * class.cs (Constructor.Define): Updated way of detecting the
23920 length of the parameters.
23922 (TypeContainer.DefineType): Use basename as the type name for
23925 (TypeContainer.Define): Do not recursively define types here, as
23926 definition is taken care in order by the RootContext.
23928 * tree.cs: Keep track of namespaces in a per-file basis.
23930 * parameter.cs (Parameter.ComputeSignature): Update to use
23933 (Parameters.GetSignature): ditto.
23935 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23936 instead of a TypeContainer.
23938 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23939 resolve names. Because we need to be resolve in our context, not
23942 * driver.cs: Implement response files.
23944 * class.cs (TypeContainer.DefineType): If we are defined, do not
23945 redefine ourselves.
23947 (Event.Emit): Emit the code for add/remove handlers.
23948 (Event.Define): Save the MethodBuilders for add/remove.
23950 * typemanager.cs: Use pair here too.
23952 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23953 DictionaryEntry requires the first argument to be non-null.
23955 (enum_declaration): Compute full name for registering the
23958 (delegate_declaration): Instead of using
23959 formal_parameter_list, use opt_formal_parameter_list as the list
23962 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23963 (EventParsing): New property that controls whether `add' and
23964 `remove' are returned as tokens or identifiers (for events);
23966 2001-12-19 Ravi Pratap <ravi@ximian.com>
23968 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23969 use MyEventBuilder only and let it wrap the real builder for us.
23971 (MyEventBuilder): Revamp constructor etc.
23973 Implement all operations that we perform on EventBuilder in precisely the same
23976 (FindMembers): Update to use the EventBuilder member.
23978 (Event.Emit): Update accordingly.
23980 2001-12-18 Ravi Pratap <ravi@ximian.com>
23982 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23983 by calling the appropriate methods.
23985 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23988 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23990 2001-12-17 Ravi Pratap <ravi@ximian.com>
23992 * delegate.cs (Delegate.Populate): Check that the return type
23993 and various parameters types are indeed accessible.
23995 * class.cs (Constructor.Define): Same here.
23997 (Field.Define): Ditto.
23999 (Event.Define): Ditto.
24001 (Operator.Define): Check that the underlying Method defined itself
24002 correctly - so it's MethodBuilder should not be null.
24004 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
24005 expression happens to be null.
24007 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
24008 members but as of now we don't seem to be able to do anything really useful with it.
24010 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
24011 not the EventBuilder.
24013 2001-12-18 Miguel de Icaza <miguel@ximian.com>
24015 * cs-tokenizer.cs: Add support for defines.
24016 Add support for #if, #elif, #else, #endif
24018 (eval_var): evaluates a variable.
24019 (eval): stubbed for evaluating functions.
24021 * cs-parser.jay: Pass the defines information
24023 * driver.cs: Add --define command line option.
24025 * decl.cs: Move MemberCore here.
24027 Make it the base class for DeclSpace. This allows us to catch and
24028 report 108 and 109 for everything now.
24030 * class.cs (TypeContainer.Define): Extract all the members
24031 before populating and emit the warning 108 (new keyword required
24032 to override) instead of having each member implement this.
24034 (MemberCore.Define): New abstract method, we will be using this in
24035 the warning reporting engine in Populate.
24037 (Operator.Define): Adjust to new MemberCore protocol.
24039 * const.cs (Const): This does not derive from Expression, it is a
24040 temporary object we use to create fields, it is a MemberCore.
24042 * class.cs (Method.Define): Allow the entry point to be in a
24045 * driver.cs: Rewrite the argument handler to clean it up a bit.
24047 * rootcontext.cs: Made it just an auxiliary namespace feature by
24048 making everything static.
24050 * driver.cs: Adapt code to use RootContext type name instead of
24053 * delegate.cs: Remove RootContext argument.
24055 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
24058 * class.cs (Event.Define): The lookup can fail.
24060 * cs-tokenizer.cs: Begin implementation of pre-procesor.
24062 * expression.cs: Resolve the this instance before invoking the code.
24064 2001-12-17 Miguel de Icaza <miguel@ximian.com>
24066 * cs-parser.jay: Add a production in element_access that allows
24067 the thing to become a "type" reference. This way we can parse
24068 things like "(string [])" as a type.
24070 Note that this still does not handle the more complex rules of
24074 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
24076 * ecore.cs: (CopyNewMethods): new utility function used to
24077 assemble the list of methods from running FindMembers.
24079 (MemberLookup): Rework FindMembers so that
24081 2001-12-16 Miguel de Icaza <miguel@ximian.com>
24083 * class.cs (TypeContainer): Remove Delegates who fail to be
24086 * delegate.cs (Populate): Verify that we dont get null return
24087 values. TODO: Check for AsAccessible.
24089 * cs-parser.jay: Use basename to emit error 574 (destructor should
24090 have the same name as container class), not the full name.
24092 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
24093 possible representation.
24095 Also implements integer type suffixes U and L.
24097 2001-12-15 Miguel de Icaza <miguel@ximian.com>
24099 * expression.cs (ArrayCreation.DoResolve): We need to do the
24100 argument resolution *always*.
24102 * decl.cs: Make this hold the namespace. Hold the root context as
24104 (LookupType): Move here.
24106 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
24108 * location.cs (Row, Name): Fixed the code, it was always returning
24109 references to the first file.
24111 * interface.cs: Register properties defined through interfaces.
24113 * driver.cs: Add support for globbing on the command line
24115 * class.cs (Field): Make it derive from MemberCore as well.
24118 2001-12-15 Ravi Pratap <ravi@ximian.com>
24120 * class.cs (Event::Define): Check that the type of the event is a delegate
24121 type else flag error #66.
24123 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
24126 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
24127 values of EntryPoint, CharSet etc etc.
24129 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
24131 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
24132 be null and we should ignore this. I am not sure if this is really clean. Apparently,
24133 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
24134 which needs this to do its work.
24136 * ../errors/cs0066.cs : Add.
24138 2001-12-14 Miguel de Icaza <miguel@ximian.com>
24140 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
24143 * class.cs: (MethodSignature.MethodSignature): Removed hack that
24144 clears out the parameters field.
24145 (MemberSignatureCompare): Cleanup
24147 (MemberCore): New base class used to share code between MethodCore
24150 (RegisterRequiredImplementations) BindingFlags.Public requires
24151 either BindingFlags.Instace or Static. Use instance here.
24153 (Property): Refactored code to cope better with the full spec.
24155 * parameter.cs (GetParameterInfo): Return an empty array instead
24158 * class.cs (Property): Abstract or extern properties have no bodies.
24160 * parameter.cs (GetParameterInfo): return a zero-sized array.
24162 * class.cs (TypeContainer.MethodModifiersValid): Move all the
24163 method modifier validation to the typecontainer so we can reuse
24164 this on properties.
24166 (MethodCore.ParameterTypes): return an empty sized array of types.
24168 (Property.Define): Test property modifier validity.
24170 Add tests for sealed/override too.
24172 (Method.Emit): abstract or extern methods have no bodies.
24174 2001-12-14 Ravi Pratap <ravi@ximian.com>
24176 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
24179 (Method::Define, ::Emit): Modify accordingly.
24181 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
24183 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
24185 * makefile: Pass in /unsafe.
24187 2001-12-13 Miguel de Icaza <miguel@ximian.com>
24189 * class.cs (MakeKey): Kill routine.
24191 * class.cs (TypeContainer.Define): Correctly define explicit
24192 method implementations (they require the full interface name plus
24195 * typemanager.cs: Deply the PtrHashtable here and stop using the
24196 lame keys. Things work so much better.
24198 This of course broke everyone who depended on `RegisterMethod' to
24199 do the `test for existance' test. This has to be done elsewhere.
24201 * support.cs (PtrHashtable): A hashtable that avoid comparing with
24202 the object stupid Equals method (because, that like fails all over
24203 the place). We still do not use it.
24205 * class.cs (TypeContainer.SetRequiredInterface,
24206 TypeContainer.RequireMethods): Killed these two routines and moved
24207 all the functionality to RegisterRequiredImplementations.
24209 (TypeContainer.RegisterRequiredImplementations): This routine now
24210 registers all the implementations required in an array for the
24211 interfaces and abstract methods. We use an array of structures
24212 which can be computed ahead of time to reduce memory usage and we
24213 also assume that lookups are cheap as most classes will not
24214 implement too many interfaces.
24216 We also avoid creating too many MethodSignatures.
24218 (TypeContainer.IsInterfaceMethod): Update and optionally does not
24219 clear the "pending" bit if we find that there are problems with
24222 (TypeContainer.VerifyPendingMethods): Update to report errors of
24223 methods that look like implementations but are not.
24225 (TypeContainer.Define): Add support for explicit interface method
24228 2001-12-12 Miguel de Icaza <miguel@ximian.com>
24230 * typemanager.cs: Keep track of the parameters here instead of
24231 being a feature of the TypeContainer.
24233 * class.cs: Drop the registration of parameters here, as
24234 InterfaceMethods are also interface declarations.
24236 * delegate.cs: Register methods with the TypeManager not only with
24237 the TypeContainer. This code was buggy.
24239 * interface.cs: Full registation here.
24241 2001-12-11 Miguel de Icaza <miguel@ximian.com>
24243 * expression.cs: Remove reducer for binary expressions, it can not
24246 * const.cs: Put here the code that used to go into constant.cs
24248 * constant.cs: Put here the code for constants, this is a new base
24249 class for Literals.
24251 * literal.cs: Make Literal derive from Constant.
24253 2001-12-09 Miguel de Icaza <miguel@ximian.com>
24255 * statement.cs (Return.Emit): Report error 157 if the user
24256 attempts to return from a finally block.
24258 (Return.Emit): Instead of emitting a return, jump to the end of
24261 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
24262 LocalBuilder to store the result of the function. ReturnLabel is
24263 the target where we jump.
24266 2001-12-09 Radek Doulik <rodo@ximian.com>
24268 * cs-parser.jay: remember alias in current namespace
24270 * ecore.cs (SimpleName::DoResolve): use aliases for types or
24273 * class.cs (LookupAlias): lookup alias in my_namespace
24275 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
24277 (LookupAlias): lookup alias in this and if needed in parent
24280 2001-12-08 Miguel de Icaza <miguel@ximian.com>
24284 * rootcontext.cs: (ModuleBuilder) Made static, first step into
24285 making things static. I need this to avoid passing the
24286 TypeContainer when calling ParameterType.
24288 * support.cs (InternalParameters.ParameterType): Remove ugly hack
24289 that did string manipulation to compute the type and then call
24290 GetType. Use Parameter.ParameterType instead.
24292 * cs-tokenizer.cs: Consume the suffix for floating values.
24294 * expression.cs (ParameterReference): figure out whether this is a
24295 reference parameter or not. Kill an extra variable by computing
24296 the arg_idx during emission.
24298 * parameter.cs (Parameters.GetParameterInfo): New overloaded
24299 function that returns whether a parameter is an out/ref value or not.
24301 (Parameter.ParameterType): The type of the parameter (base,
24302 without ref/out applied).
24304 (Parameter.Resolve): Perform resolution here.
24305 (Parameter.ExternalType): The full type (with ref/out applied).
24307 * statement.cs (Using.Emit, Using.EmitExpression): Implement
24308 support for expressions on the using statement.
24310 2001-12-07 Miguel de Icaza <miguel@ximian.com>
24312 * statement.cs (Using.EmitLocalVariableDecls): Split the
24313 localvariable handling of the using statement.
24315 (Block.EmitMeta): Keep track of variable count across blocks. We
24316 were reusing slots on separate branches of blocks.
24318 (Try.Emit): Emit the general code block, we were not emitting it.
24320 Check the type of the declaration to be an IDisposable or
24321 something that can be implicity converted to it.
24323 Emit conversions if required.
24325 * ecore.cs (EmptyExpression): New utility class.
24326 (Expression.ImplicitConversionExists): New utility function.
24328 2001-12-06 Miguel de Icaza <miguel@ximian.com>
24330 * statement.cs (Using): Implement.
24332 * expression.cs (LocalVariableReference): Support read only variables.
24334 * statement.cs: Remove the explicit emit for the Leave opcode.
24335 (VariableInfo): Add a readonly field.
24337 2001-12-05 Miguel de Icaza <miguel@ximian.com>
24339 * ecore.cs (ConvCast): new class used to encapsulate the various
24340 explicit integer conversions that works in both checked and
24341 unchecked contexts.
24343 (Expression.ConvertNumericExplicit): Use new ConvCast class to
24344 properly generate the overflow opcodes.
24346 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24348 * statement.cs: The correct type for the EmptyExpression is the
24349 element_type, not the variable type. Ravi pointed this out.
24351 2001-12-04 Ravi Pratap <ravi@ximian.com>
24353 * class.cs (Method::Define): Handle PInvoke methods specially
24354 by using DefinePInvokeMethod instead of the usual one.
24356 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
24357 above to do the task of extracting information and defining the method.
24359 2001-12-04 Ravi Pratap <ravi@ximian.com>
24361 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
24362 of the condition for string type.
24364 (Emit): Move that here.
24366 (ArrayCreation::CheckIndices): Keep string literals in their expression
24369 (EmitDynamicInitializers): Handle strings appropriately.
24371 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24373 * codegen.cs (EmitContext): Replace multiple variables with a
24374 single pointer to the current Switch statement.
24376 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
24379 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24383 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
24386 (Foreach.Emit): Foreach on arrays was not setting
24387 up the loop variables (for break/continue).
24389 (GotoCase): Semi-implented.
24391 2001-12-03 Ravi Pratap <ravi@ximian.com>
24393 * attribute.cs (CheckAttribute): Handle system attributes by using
24394 Attribute.GetAttributes to examine information we need.
24396 (GetValidPlaces): Same here.
24398 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
24400 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
24402 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
24404 (Method::Define): Set appropriate flags if we have a DllImport attribute.
24406 (Method::Emit): Handle the case when we are a PInvoke method.
24408 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24410 * expression.cs: Use ResolveWithSimpleName on compound names.
24412 2001-12-02 Ravi Pratap <ravi@ximian.com>
24414 * constant.cs (EmitConstant): Make sure we resolve the associated expression
24415 before trying to reduce it.
24417 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
24419 * constant.cs (LookupConstantValue): Implement.
24421 (EmitConstant): Use the above in emitting the constant.
24423 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
24424 that are user-defined by doing a LookupConstantValue on them.
24426 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
24429 2001-11-29 Miguel de Icaza <miguel@ximian.com>
24431 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
24433 (BaseAccess.DoResolve): Implement.
24435 (MemberAccess.DoResolve): Split this routine into a
24436 ResolveMemberAccess routine that can be used independently
24438 2001-11-28 Miguel de Icaza <miguel@ximian.com>
24440 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
24441 As that share bits of the implementation. Is returns a boolean,
24442 while As returns the Type that is being probed.
24444 2001-12-01 Ravi Pratap <ravi@ximian.com>
24446 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
24447 instead of a Literal - much easier.
24449 (EnumInTransit): Remove - utterly useless :-)
24451 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
24453 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
24455 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
24456 chain when we have no associated expression.
24458 2001-11-30 Ravi Pratap <ravi@ximian.com>
24460 * constant.cs (Define): Use Location while reporting the errror.
24462 Also emit a warning when 'new' is used and there is no inherited
24465 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
24468 (LookupEnumValue): Implement to lookup an enum member's value and define it
24471 (Populate): Re-write accordingly to use the above routine.
24473 2001-11-27 Miguel de Icaza <miguel@ximian.com>
24475 * expression.cs (This): Fix prototype for DoResolveLValue to
24476 override the base class DoResolveLValue.
24478 * cs-parser.cs: Report errors cs574 and cs575 (destructor
24481 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
24482 (we need to load the address of the field here). This fixes
24485 (FieldExpr.DoResolveLValue): Call the DoResolve
24486 function to initialize the Instance expression.
24488 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
24489 correctly the GetEnumerator operation on a value type.
24491 * cs-parser.jay: Add more simple parsing error catches.
24493 * statement.cs (Switch): Add support for string switches.
24494 Handle null specially.
24496 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
24498 2001-11-28 Ravi Pratap <ravi@ximian.com>
24500 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
24502 (declare_local_constant): New helper function.
24504 * statement.cs (AddConstant): Keep a separate record of constants
24506 (IsConstant): Implement to determine if a variable is a constant.
24508 (GetConstantExpression): Implement.
24510 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
24512 * statement.cs (IsVariableDefined): Re-write.
24514 2001-11-27 Ravi Pratap <ravi@ximian.com>
24516 * class.cs (TypeContainer::FindMembers): Look for constants
24517 in the case when we are looking for MemberTypes.Field
24519 * expression.cs (MemberAccess::DoResolve): Check that in the
24520 case we are a FieldExpr and a Literal, we are not being accessed
24521 by an instance reference.
24523 * cs-parser.jay (local_constant_declaration): Implement.
24525 (declaration_statement): Implement for constant declarations.
24527 2001-11-26 Miguel de Icaza <miguel@ximian.com>
24529 * statement.cs (Switch): Catch double defaults.
24531 (Switch): More work on the switch() statement
24532 implementation. It works for integral values now, need to finish
24536 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24538 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
24539 integer literals into other integer literals. To be used by
24542 2001-11-24 Ravi Pratap <ravi@ximian.com>
24544 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
24547 (EmitDynamicInitializers): Cope with the above since we extract data
24548 directly from ArrayData now.
24550 (ExpectInitializers): Keep track of whether initializers are mandatory
24553 (Bounds): Make it a hashtable to prevent the same dimension being
24554 recorded for every element in that dimension.
24556 (EmitDynamicInitializers): Fix bug which prevented the Set array method
24559 Also fix bug which was causing the indices to be emitted in the reverse
24562 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24564 * expression.cs (ArrayCreation): Implement the bits that Ravi left
24565 unfinished. They do not work, because the underlying code is
24568 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24570 * cs-parser.jay: Remove bogus fixme.
24572 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
24573 on Switch statement.
24575 2001-11-23 Ravi Pratap <ravi@ximian.com>
24577 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
24580 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
24581 parameter. Apparently, any expression is allowed.
24583 (ValidateInitializers): Update accordingly.
24585 (CheckIndices): Fix some tricky bugs thanks to recursion.
24587 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
24588 I was being completely brain-dead.
24590 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
24591 and re-write acordingly.
24593 (DelegateInvocation): Re-write accordingly.
24595 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
24597 (MakeByteBlob): Handle types more correctly.
24599 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
24600 initialization from expressions but it is incomplete because I am a complete
24603 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24605 * statement.cs (If.Emit): Fix a bug that generated incorrect code
24606 on If. Basically, we have to return `true' (ie, we do return to
24607 our caller) only if both branches of the if return.
24609 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
24610 short-circuit operators, handle them as short circuit operators.
24612 (Cast.DoResolve): Resolve type.
24613 (Cast.Cast): Take an expression as the target type.
24615 * cs-parser.jay (cast_expression): Remove old hack that only
24616 allowed a limited set of types to be handled. Now we take a
24617 unary_expression and we resolve to a type during semantic
24620 Use the grammar productions from Rhys to handle casts (this is
24621 not complete like Rhys syntax yet, we fail to handle that corner
24622 case that C# has regarding (-x), but we will get there.
24624 2001-11-22 Ravi Pratap <ravi@ximian.com>
24626 * class.cs (EmitFieldInitializer): Take care of the case when we have a
24627 field which is an array type.
24629 * cs-parser.jay (declare_local_variables): Support array initialization too.
24631 * typemanager.cs (MakeKey): Implement.
24633 (everywhere): Use the above appropriately.
24635 * cs-parser.jay (for_statement): Update for array initialization while
24636 declaring variables.
24638 * ecore.cs : The error message was correct, it's the variable's names that
24639 were misleading ;-) Make the code more readable.
24641 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
24642 the correct type etc.
24644 (ConvertExplicit): Handle Enum types by examining the underlying type.
24646 2001-11-21 Ravi Pratap <ravi@ximian.com>
24648 * parameter.cs (GetCallingConvention): Always return
24649 CallingConventions.Standard for now.
24651 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24653 * expression.cs (Binary.ResolveOperator): Update the values of `l'
24654 and `r' after calling DoNumericPromotions.
24656 * ecore.cs: Fix error message (the types were in the wrong order).
24658 * statement.cs (Foreach.ProbeCollectionType): Need to pass
24659 BindingFlags.Instance as well
24661 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
24662 implicit int literal conversion in an empty cast so that we
24663 propagate the right type upstream.
24665 (UnboxCast): new class used to unbox value types.
24666 (Expression.ConvertExplicit): Add explicit type conversions done
24669 (Expression.ImplicitNumericConversion): Oops, forgot to test for
24670 the target type before applying the implicit LongLiterals to ULong
24673 2001-11-21 Miguel de Icaza <miguel@ximian.com>
24675 * cs-parser.jay (for_statement): Reworked the way For works: now
24676 we declare manually any variables that are introduced in
24677 for_initializer to solve the problem of having out-of-band code
24678 emition (that is what got for broken).
24680 (declaration_statement): Perform the actual variable declaration
24681 that used to be done in local_variable_declaration here.
24683 (local_variable_declaration): Do not declare anything, just pass
24684 the information on a DictionaryEntry
24686 2001-11-20 Ravi Pratap <ravi@ximian.com>
24688 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
24689 re-write of the logic to now make it recursive.
24691 (UpdateIndices): Re-write accordingly.
24693 Store element data in a separate ArrayData list in the above methods.
24695 (MakeByteBlob): Implement to dump the array data into a byte array.
24697 2001-11-19 Ravi Pratap <ravi@ximian.com>
24699 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
24702 * constant.cs (Define): Implement.
24704 (EmitConstant): Re-write fully.
24706 Pass in location info.
24708 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
24711 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
24712 DictionaryEntry since we need location info too.
24714 (constant_declaration): Update accordingly.
24716 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
24717 code into another method : UpdateIndices.
24719 2001-11-18 Ravi Pratap <ravi@ximian.com>
24721 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
24722 some type checking etc.
24724 2001-11-17 Ravi Pratap <ravi@ximian.com>
24726 * expression.cs (ArrayCreation::ValidateInitializers): Implement
24727 bits to provide dimension info if the user skips doing that.
24729 Update second constructor to store the rank correctly.
24731 2001-11-16 Ravi Pratap <ravi@ximian.com>
24733 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
24734 and try to implement.
24736 * ../errors/cs0150.cs : Add.
24738 * ../errors/cs0178.cs : Add.
24740 2001-11-16 Miguel de Icaza <miguel@ximian.com>
24742 * statement.cs: Implement foreach on multi-dimensional arrays.
24744 * parameter.cs (Parameters.GetParameterByName): Also lookup the
24745 name of the params argument.
24747 * expression.cs: Use EmitStoreOpcode to get the right opcode while
24748 initializing the array.
24750 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
24751 we can use this elsewhere.
24753 * statement.cs: Finish implementation of foreach for single
24756 * cs-parser.jay: Use an out-of-band stack to pass information
24757 around, I wonder why I need this.
24759 foreach_block: Make the new foreach_block the current_block.
24761 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
24762 function used to return a static Parameters structure. Used for
24763 empty parameters, as those are created very frequently.
24765 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24767 2001-11-15 Ravi Pratap <ravi@ximian.com>
24769 * interface.cs : Default modifier is private, not public. The
24770 make verify test passes again.
24772 2001-11-15 Ravi Pratap <ravi@ximian.com>
24774 * support.cs (ReflectionParameters): Fix logic to determine
24775 whether the last parameter is a params one. Test 9 passes again.
24777 * delegate.cs (Populate): Register the builders we define with
24778 RegisterParameterForBuilder. Test 19 passes again.
24780 * cs-parser.jay (property_declaration): Reference $6 instead
24781 of $$ to get at the location.
24783 (indexer_declaration): Similar stuff.
24785 (attribute): Ditto.
24787 * class.cs (Property): Register parameters for the Get and Set methods
24788 if they exist. Test 23 passes again.
24790 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24791 call to EmitArguments as we are sure there aren't any params arguments.
24792 Test 32 passes again.
24794 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24795 IndexOutOfRangeException.
24797 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24798 Test 33 now passes again.
24800 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24802 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24803 broke a bunch of things. Will have to come up with a better way
24804 of tracking locations.
24806 * statement.cs: Implemented foreach for single dimension arrays.
24808 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24810 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24811 an error. This removes the lookup from the critical path.
24813 * cs-parser.jay: Removed use of temporary_loc, which is completely
24816 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24818 * support.cs (ReflectionParameters.ParameterModifier): Report
24819 whether the argument is a PARAMS argument or not.
24821 * class.cs: Set the attribute `ParamArrayAttribute' on the
24822 parameter argument.
24824 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24825 and cons_param_array_attribute (ConstructorInfo for
24826 ParamArrayAttribute).,
24828 * codegen.cs: Emit the return using the `Return' statement, that
24829 way we can report the error correctly for missing return values.
24831 * class.cs (Method.Emit): Clean up.
24833 * expression.cs (Argument.Resolve): Take another argument: the
24834 location where this argument is used. Notice that this is not
24835 part of the "Argument" class as to reduce the size of the
24836 structure (we know the approximate location anyways).
24838 Test if the argument is a variable-reference, if not, then
24839 complain with a 206.
24841 (Argument.Emit): Emit addresses of variables.
24843 (Argument.FullDesc): Simplify.
24845 (Invocation.DoResolve): Update for Argument.Resolve.
24847 (ElementAccess.DoResolve): ditto.
24849 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24850 method should be virtual, as this method is always virtual.
24852 (NewDelegate.DoResolve): Update for Argument.Resolve.
24854 * class.cs (ConstructorInitializer.DoResolve): ditto.
24856 * attribute.cs (Attribute.Resolve): ditto.
24858 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24860 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24862 * expression.cs (ParameterReference): Drop IStackStorage and implement
24863 IAssignMethod instead.
24865 (LocalVariableReference): ditto.
24867 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24868 IAssignMethod instead.
24870 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24872 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24873 enumerations that are used in heavily used structures derive from
24874 byte in a laughable and pathetic attempt to reduce memory usage.
24875 This is the kind of pre-optimzations that you should not do at
24876 home without adult supervision.
24878 * expression.cs (UnaryMutator): New class, used to handle ++ and
24879 -- separatedly from the other unary operators. Cleans up the
24880 code, and kills the ExpressionStatement dependency in Unary.
24882 (Unary): Removed `method' and `Arguments' from this class, making
24883 it smaller, and moving it all to SimpleCall, so I can reuse this
24884 code in other locations and avoid creating a lot of transient data
24885 strucutres when not required.
24887 * cs-parser.jay: Adjust for new changes.
24889 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24891 * enum.cs (Enum.Populate): If there is a failure during
24894 * cs-parser.jay (opt_enum_base): we used to catch type errors
24895 here, but this is really incorrect. The type error should be
24896 catched during semantic analysis.
24898 2001-12-11 Ravi Pratap <ravi@ximian.com>
24900 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24901 current_local_parameters as expected since I, in my stupidity, had forgotten
24904 * attribute.cs (GetValidPlaces): Fix stupid bug.
24906 * class.cs (Method::Emit): Perform check on applicability of attributes.
24908 (Constructor::Emit): Ditto.
24910 (Field::Emit): Ditto.
24912 (Field.Location): Store location information.
24914 (Property, Event, Indexer, Operator): Ditto.
24916 * cs-parser.jay (field_declaration): Pass in location for each field.
24918 * ../errors/cs0592.cs : Add.
24920 2001-11-12 Ravi Pratap <ravi@ximian.com>
24922 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24924 (InitCoreTypes): Update accordingly.
24926 (RegisterAttrType, LookupAttr): Implement.
24928 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24929 info about the same.
24931 (Resolve): Update to populate the above as necessary.
24933 (Error592): Helper.
24935 (GetValidPlaces): Helper to the above.
24937 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24939 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24941 2001-11-12 Ravi Pratap <ravi@ximian.com>
24943 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24945 * ../errors/cs0617.cs : Add.
24947 2001-11-11 Ravi Pratap <ravi@ximian.com>
24949 * enum.cs (Emit): Rename to Populate to be more consistent with what
24950 we expect it to do and when exactly it is called.
24952 * class.cs, rootcontext.cs : Update accordingly.
24954 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24955 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24957 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24959 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24960 of a fieldinfo using the above, when dealing with a FieldBuilder.
24962 2001-11-10 Ravi Pratap <ravi@ximian.com>
24964 * ../errors/cs0031.cs : Add.
24966 * ../errors/cs1008.cs : Add.
24968 * ../errrors/cs0543.cs : Add.
24970 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24973 (FindMembers): Implement.
24975 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24976 enums and delegates too.
24978 (enum_types): Rename to builder_to_enum.
24980 (delegate_types): Rename to builder_to_delegate.
24982 * delegate.cs (FindMembers): Implement.
24984 2001-11-09 Ravi Pratap <ravi@ximian.com>
24986 * typemanager.cs (IsEnumType): Implement.
24988 * enum.cs (Emit): Re-write parts to account for the underlying type
24989 better and perform checking etc.
24991 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24992 of the underlying type.
24994 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24997 * enum.cs (error31): Helper to report error #31.
24999 * cs-parser.jay (enum_declaration): Store location of each member too.
25001 * enum.cs (member_to_location): New hashtable.
25003 (AddEnumMember): Update location hashtable.
25005 (Emit): Use the location of each member while reporting errors.
25007 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25009 * cs-parser.jay: A for_initializer if is a
25010 local_variable_declaration really ammount to have an implicit
25011 block with the variable declaration and no initializer for for.
25013 * statement.cs (For.Emit): Cope with null initializers.
25015 This fixes the infinite loop on for initializers.
25017 2001-11-08 Miguel de Icaza <miguel@ximian.com>
25019 * enum.cs: More cleanup.
25021 * ecore.cs: Remove dead code.
25023 * class.cs (Property.Emit): More simplification.
25024 (Event.Emit): ditto.
25026 Reworked to have less levels of indentation.
25028 2001-11-08 Ravi Pratap <ravi@ximian.com>
25030 * class.cs (Property): Emit attributes.
25040 * enum.cs (Emit): Ditto.
25042 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
25045 * class.cs (Field, Event, etc.): Move attribute generation into the
25046 Emit method everywhere.
25048 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
25049 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
25050 as we had no way of defining nested enums !
25052 * rootcontext.cs : Adjust code accordingly.
25054 * typemanager.cs (AddEnumType): To keep track of enum types separately.
25056 2001-11-07 Ravi Pratap <ravi@ximian.com>
25058 * expression.cs (EvalConstantExpression): Move into ecore.cs
25060 * enum.cs (Enum): Rename some members and make them public and readonly
25061 according to our convention.
25063 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
25066 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25068 (Enum::Emit): Write a simple version for now which doesn't try to compute
25069 expressions. I shall modify this to be more robust in just a while.
25071 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
25073 (TypeContainer::CloseType): Create the Enum types too.
25075 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
25077 * expression.cs (EvalConstantExpression): Get rid of completely.
25079 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
25080 user-defined values and other cases.
25082 (IsValidEnumLiteral): Helper function.
25084 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
25085 out there in the case we had a literal FieldExpr.
25087 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
25089 (Literalize): Revamp a bit to take two arguments.
25091 (EnumLiteral): New class which derives from Literal to wrap enum literals.
25093 2001-11-06 Ravi Pratap <ravi@ximian.com>
25095 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
25097 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
25099 (Resolve): Use the above to ensure we have proper initializers.
25101 2001-11-05 Ravi Pratap <ravi@ximian.com>
25103 * expression.cs (Expression::EvalConstantExpression): New method to
25104 evaluate constant expressions.
25106 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
25108 2001-11-07 Miguel de Icaza <miguel@ximian.com>
25110 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
25113 (Binary.ResolveOperator): Handle operator != (object a, object b)
25114 and operator == (object a, object b);
25116 (Binary.DoNumericPromotions): Indicate whether the numeric
25117 promotion was possible.
25119 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
25122 Made the ArrayAccess implement interface IAssignMethod instead of
25123 IStackStore as the order in which arguments are passed reflects
25126 * assign.cs: Instead of using expr.ExprClass to select the way of
25127 assinging, probe for the IStackStore/IAssignMethod interfaces.
25129 * typemanager.cs: Load InitializeArray definition.
25131 * rootcontext.cs (RootContext.MakeStaticData): Used to define
25132 static data that can be used to initialize arrays.
25134 2001-11-05 Miguel de Icaza <miguel@ximian.com>
25136 * expression.cs: Handle operator== and operator!= for booleans.
25138 (Conditioal.Reduce): Implement reducer for the ?: operator.
25140 (Conditional.Resolve): Implement dead code elimination.
25142 (Binary.Resolve): Catch string literals and return a new
25143 concatenated string.
25145 (Unary.Reduce): Implement reduction of unary expressions.
25147 * ecore.cs: Split out the expression core handling here.
25149 (Expression.Reduce): New method used to perform constant folding
25150 and CSE. This is needed to support constant-expressions.
25152 * statement.cs (Statement.EmitBoolExpression): Pass true and false
25153 targets, and optimize for !x.
25155 2001-11-04 Ravi Pratap <ravi@ximian.com>
25157 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
25158 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
25159 set custom atttributes.
25161 * literal.cs (Literal::GetValue): New abstract method to return the actual
25162 value of the literal, cast as an object.
25164 (*Literal): Implement GetValue method.
25166 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
25167 expressions to the arraylist but objects of type Argument.
25169 * class.cs (TypeContainer::Emit): Emit our attributes too.
25171 (Method::Emit, Constructor::Emit): Ditto.
25173 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
25174 to be ignoring earlier.
25176 2001-11-03 Ravi Pratap <ravi@ximian.com>
25178 * attribute.cs (AttributeSection::Define): Implement to do the business
25179 of constructing a CustomAttributeBuilder.
25181 (Attribute): New trivial class. Increases readability of code.
25183 * cs-parser.jay : Update accordingly.
25185 (positional_argument_list, named_argument_list, named_argument): New rules
25187 (attribute_arguments): Use the above so that we are more correct.
25189 2001-11-02 Ravi Pratap <ravi@ximian.com>
25191 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
25192 to perform all checks for a method with a params parameter.
25194 (Invocation::OverloadResolve): Update to use the above method and therefore
25195 cope correctly with params method invocations.
25197 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
25200 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
25201 constructors in our parent too because we can't afford to miss out on
25204 * attribute.cs (AttributeSection): New name for the class Attribute
25206 Other trivial changes to improve readability.
25208 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
25209 use the new class names.
25211 2001-11-01 Ravi Pratap <ravi@ximian.com>
25213 * class.cs (Method::Define): Complete definition for params types too
25215 (Indexer::Define): Ditto.
25217 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
25218 Cope everywhere with a request for info about the array parameter.
25220 2001-11-01 Ravi Pratap <ravi@ximian.com>
25222 * tree.cs (RecordNamespace): Fix up to check for the correct key.
25224 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
25225 local_variable_type to extract the string corresponding to the type.
25227 (local_variable_type): Fixup the action to use the new helper method.
25229 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
25232 * expression.cs : Clean out code which uses the above.
25234 2001-10-31 Ravi Pratap <ravi@ximian.com>
25236 * typemanager.cs (RegisterMethod): Check if we already have an existing key
25237 and bale out if necessary by returning a false.
25239 (RegisterProperty): Ditto.
25241 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
25242 and print out appropriate error messages.
25244 * interface.cs (everywhere): Ditto.
25246 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
25247 location to constructor.
25249 * class.cs (Property, Event, Indexer): Update accordingly.
25251 * ../errors/cs111.cs : Added.
25253 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
25254 of a method, as laid down by the spec.
25256 (Invocation::OverloadResolve): Use the above method.
25258 2001-10-31 Ravi Pratap <ravi@ximian.com>
25260 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
25261 now take a TypeContainer and a Parameters object.
25263 (ParameterData): Modify return type of ParameterModifier method to be
25264 Parameter.Modifier and not a string.
25266 (ReflectionParameters, InternalParameters): Update accordingly.
25268 * expression.cs (Argument::GetParameterModifier): Same here.
25270 * support.cs (InternalParameters::ParameterType): Find a better way of determining
25271 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
25272 symbol in it at all so maybe this is only for now.
25274 2001-10-30 Ravi Pratap <ravi@ximian.com>
25276 * support.cs (InternalParameters): Constructor now takes an extra argument
25277 which is the actual Parameters class.
25279 (ParameterDesc): Update to provide info on ref/out modifiers.
25281 * class.cs (everywhere): Update call to InternalParameters to pass in
25282 the second argument too.
25284 * support.cs (ParameterData): Add ParameterModifier, which is a method
25285 to return the modifier info [ref/out etc]
25287 (InternalParameters, ReflectionParameters): Implement the above.
25289 * expression.cs (Argument::ParameterModifier): Similar function to return
25290 info about the argument's modifiers.
25292 (Invocation::OverloadResolve): Update to take into account matching modifiers
25295 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
25296 a new SetFormalParameters object which we pass to InternalParameters.
25298 2001-10-30 Ravi Pratap <ravi@ximian.com>
25300 * expression.cs (NewArray): Merge into the ArrayCreation class.
25302 2001-10-29 Ravi Pratap <ravi@ximian.com>
25304 * expression.cs (NewArray): Merge classes NewBuiltinArray and
25305 NewUserdefinedArray into one as there wasn't much of a use in having
25308 * expression.cs (Argument): Change field's name to ArgType from Type.
25310 (Type): New readonly property which returns the proper type, taking into
25311 account ref/out modifiers.
25313 (everywhere): Adjust code accordingly for the above.
25315 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
25316 whether we are emitting for a ref or out parameter.
25318 * expression.cs (Argument::Emit): Use the above field to set the state.
25320 (LocalVariableReference::Emit): Update to honour the flag and emit the
25323 * parameter.cs (Attributes): Set the correct flags for ref parameters.
25325 * expression.cs (Argument::FullDesc): New function to provide a full desc.
25327 * support.cs (ParameterData): Add method ParameterDesc to the interface.
25329 (ReflectionParameters, InternalParameters): Implement the above method.
25331 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
25334 (Invocation::FullMethodDesc): Ditto.
25336 2001-10-29 Miguel de Icaza <miguel@ximian.com>
25338 * cs-parser.jay: Add extra production for the second form of array
25341 * expression.cs (ArrayCreation): Update to reflect the above
25344 * Small changes to prepare for Array initialization.
25346 2001-10-28 Miguel de Icaza <miguel@ximian.com>
25348 * typemanager.cs (ImplementsInterface): interface might be null;
25349 Deal with this problem;
25351 Also, we do store negative hits on the cache (null values), so use
25352 this instead of calling t.GetInterfaces on the type everytime.
25354 2001-10-28 Ravi Pratap <ravi@ximian.com>
25356 * typemanager.cs (IsBuiltinType): New method to help determine the same.
25358 * expression.cs (New::DoResolve): Get rid of array creation code and instead
25359 split functionality out into different classes.
25361 (New::FormArrayType): Move into NewBuiltinArray.
25363 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
25366 (NewBuiltinArray): New class to handle creation of built-in arrays.
25368 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
25369 account creation of one-dimensional arrays.
25371 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
25373 (NewUserdefinedArray::DoResolve): Implement.
25375 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
25377 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
25378 we maintain inside the TypeManager. This is necessary to perform lookups on the
25381 (LookupType): Update to perform GetType on the module builders too.
25383 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
25385 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
25387 2001-10-23 Ravi Pratap <ravi@ximian.com>
25389 * expression.cs (New::DoResolve): Implement guts of array creation.
25391 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
25393 2001-10-27 Miguel de Icaza <miguel@ximian.com>
25395 * expression.cs: Fix bug I introduced lsat night that broke
25398 (Expression.Resolve): Report a 246 error (can not resolve name)
25399 if we find a SimpleName in the stream.
25401 (Expression.ResolveLValue): Ditto.
25403 (Expression.ResolveWithSimpleName): This function is a variant of
25404 ResolveName, this one allows SimpleNames to be returned without a
25405 warning. The only consumer of SimpleNames is MemberAccess
25407 2001-10-26 Miguel de Icaza <miguel@ximian.com>
25409 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
25410 might arrive here. I have my doubts that this is correct.
25412 * statement.cs (Lock): Implement lock statement.
25414 * cs-parser.jay: Small fixes to support `lock' and `using'
25416 * cs-tokenizer.cs: Remove extra space
25418 * driver.cs: New flag --checked, allows to turn on integer math
25421 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
25422 Threading.Monitor.Exit
25424 2001-10-23 Miguel de Icaza <miguel@ximian.com>
25426 * expression.cs (IndexerAccess::DoResolveLValue): Set the
25427 Expression Class to be IndexerAccess.
25429 Notice that Indexer::DoResolve sets the eclass to Value.
25431 2001-10-22 Miguel de Icaza <miguel@ximian.com>
25433 * class.cs (TypeContainer::Emit): Emit code for indexers.
25435 * assign.cs (IAssignMethod): New interface implemented by Indexers
25436 and Properties for handling assignment.
25438 (Assign::Emit): Simplify and reuse code.
25440 * expression.cs (IndexerAccess, PropertyExpr): Implement
25441 IAssignMethod, clean up old code.
25443 2001-10-22 Ravi Pratap <ravi@ximian.com>
25445 * typemanager.cs (ImplementsInterface): New method to determine if a type
25446 implements a given interface. Provides a nice cache too.
25448 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
25451 (ConvertReferenceExplicit): Ditto.
25453 * delegate.cs (Delegate::Populate): Update to define the parameters on the
25454 various methods, with correct names etc.
25456 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
25457 Operator.UnaryNegation.
25459 * cs-parser.jay (operator_declarator): Be a little clever in the case where
25460 we have a unary plus or minus operator.
25462 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
25465 * everywhere : update accordingly.
25467 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
25470 * class.cs (Method::Define): For the case where we are implementing a method
25471 inherited from an interface, we need to set the MethodAttributes.Final flag too.
25472 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
25474 2001-10-21 Ravi Pratap <ravi@ximian.com>
25476 * interface.cs (FindMembers): Implement to work around S.R.E
25479 * typemanager.cs (IsInterfaceType): Implement.
25481 (FindMembers): Update to handle interface types too.
25483 * expression.cs (ImplicitReferenceConversion): Re-write bits which
25484 use IsAssignableFrom as that is not correct - it doesn't work.
25486 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
25487 and accordingly override EmitStatement.
25489 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
25490 using the correct logic :-)
25492 2001-10-19 Ravi Pratap <ravi@ximian.com>
25494 * ../errors/cs-11.cs : Add to demonstrate error -11
25496 2001-10-17 Miguel de Icaza <miguel@ximian.com>
25498 * assign.cs (Assign::Resolve): Resolve right hand side first, and
25499 then pass this as a hint to ResolveLValue.
25501 * expression.cs (FieldExpr): Add Location information
25503 (FieldExpr::LValueResolve): Report assignment to readonly
25506 (Expression::ExprClassFromMemberInfo): Pass location information.
25508 (Expression::ResolveLValue): Add new method that resolves an
25511 (Expression::DoResolveLValue): Default invocation calls
25514 (Indexers): New class used to keep track of indexers in a given
25517 (IStackStore): Renamed from LValue, as it did not really describe
25518 what this did. Also ResolveLValue is gone from this interface and
25519 now is part of Expression.
25521 (ElementAccess): Depending on the element access type
25523 * typemanager.cs: Add `indexer_name_type' as a Core type
25524 (System.Runtime.CompilerServices.IndexerNameAttribute)
25526 * statement.cs (Goto): Take a location.
25528 2001-10-18 Ravi Pratap <ravi@ximian.com>
25530 * delegate.cs (Delegate::VerifyDelegate): New method to verify
25531 if two delegates are compatible.
25533 (NewDelegate::DoResolve): Update to take care of the case when
25534 we instantiate a delegate from another delegate.
25536 * typemanager.cs (FindMembers): Don't even try to look up members
25537 of Delegate types for now.
25539 2001-10-18 Ravi Pratap <ravi@ximian.com>
25541 * delegate.cs (NewDelegate): New class to take care of delegate
25544 * expression.cs (New): Split the delegate related code out into
25545 the NewDelegate class.
25547 * delegate.cs (DelegateInvocation): New class to handle delegate
25550 * expression.cs (Invocation): Split out delegate related code into
25551 the DelegateInvocation class.
25553 2001-10-17 Ravi Pratap <ravi@ximian.com>
25555 * expression.cs (New::DoResolve): Implement delegate creation fully
25556 and according to the spec.
25558 (New::DoEmit): Update to handle delegates differently.
25560 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
25561 because of which we were printing out arguments in reverse order !
25563 * delegate.cs (VerifyMethod): Implement to check if the given method
25564 matches the delegate.
25566 (FullDelegateDesc): Implement.
25568 (VerifyApplicability): Implement.
25570 * expression.cs (Invocation::DoResolve): Update to accordingly handle
25571 delegate invocations too.
25573 (Invocation::Emit): Ditto.
25575 * ../errors/cs1593.cs : Added.
25577 * ../errors/cs1594.cs : Added.
25579 * delegate.cs (InstanceExpression, TargetMethod): New properties.
25581 2001-10-16 Ravi Pratap <ravi@ximian.com>
25583 * typemanager.cs (intptr_type): Core type for System.IntPtr
25585 (InitCoreTypes): Update for the same.
25587 (iasyncresult_type, asynccallback_type): Ditto.
25589 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
25592 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
25595 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
25596 the builders for the 4 members of a delegate type :-)
25598 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
25601 * expression.cs (New::DoResolve): Implement guts for delegate creation.
25603 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
25605 2001-10-15 Miguel de Icaza <miguel@ximian.com>
25607 * statement.cs (Break::Emit): Implement.
25608 (Continue::Emit): Implement.
25610 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
25611 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
25612 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
25613 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
25616 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
25617 properties that track the label for the current loop (begin of the
25618 loop and end of the loop).
25620 2001-10-15 Ravi Pratap <ravi@ximian.com>
25622 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
25623 use of emitting anything at all.
25625 * class.cs, rootcontext.cs : Get rid of calls to the same.
25627 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
25629 (Populate): Define the constructor correctly and set the implementation
25632 * typemanager.cs (delegate_types): New hashtable to hold delegates that
25635 (AddDelegateType): Implement.
25637 (IsDelegateType): Implement helper method.
25639 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
25641 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
25642 and accordingly handle it.
25644 * delegate.cs (Populate): Take TypeContainer argument.
25645 Implement bits to define the Invoke method. However, I still haven't figured out
25646 how to take care of the native int bit :-(
25648 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
25649 Qualify the name of the delegate, not its return type !
25651 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
25654 (StandardConversionExists): Checking for array types turns out to be recursive.
25656 (ConvertReferenceExplicit): Implement array conversion.
25658 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
25660 2001-10-12 Ravi Pratap <ravi@ximian.com>
25662 * cs-parser.jay (delegate_declaration): Store the fully qualified
25663 name as it is a type declaration.
25665 * delegate.cs (ReturnType, Name): Rename members to these. Make them
25668 (DefineDelegate): Renamed from Define. Does the same thing essentially,
25669 as TypeContainer::DefineType.
25671 (Populate): Method in which all the definition of the various methods (Invoke)
25674 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
25677 (CloseDelegate): Finally creates the delegate.
25679 * class.cs (TypeContainer::DefineType): Update to define delegates.
25680 (Populate, Emit and CloseType): Do the same thing here too.
25682 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
25683 delegates in all these operations.
25685 2001-10-14 Miguel de Icaza <miguel@ximian.com>
25687 * expression.cs: LocalTemporary: a new expression used to
25688 reference a temporary that has been created.
25690 * assign.cs: Handle PropertyAccess back here, so that we can
25691 provide the proper semantic access to properties.
25693 * expression.cs (Expression::ConvertReferenceExplicit): Implement
25694 a few more explicit conversions.
25696 * modifiers.cs: `NEW' modifier maps to HideBySig.
25698 * expression.cs (PropertyExpr): Make this into an
25699 ExpressionStatement, and support the EmitStatement code path.
25701 Perform get/set error checking, clean up the interface.
25703 * assign.cs: recognize PropertyExprs as targets, and if so, turn
25704 them into toplevel access objects.
25706 2001-10-12 Miguel de Icaza <miguel@ximian.com>
25708 * expression.cs: PropertyExpr::PropertyExpr: use work around the
25711 * typemanager.cs: Keep track here of our PropertyBuilders again to
25712 work around lameness in SRE.
25714 2001-10-11 Miguel de Icaza <miguel@ximian.com>
25716 * expression.cs (LValue::LValueResolve): New method in the
25717 interface, used to perform a second resolution pass for LValues.
25719 (This::DoResolve): Catch the use of this in static methods.
25721 (This::LValueResolve): Implement.
25723 (This::Store): Remove warning, assigning to `this' in structures
25726 (Invocation::Emit): Deal with invocation of
25727 methods on value types. We need to pass the address to structure
25728 methods rather than the object itself. (The equivalent code to
25729 emit "this" for structures leaves the entire structure on the
25730 stack instead of a pointer to it).
25732 (ParameterReference::DoResolve): Compute the real index for the
25733 argument based on whether the method takes or not a `this' pointer
25734 (ie, the method is static).
25736 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
25737 value types returned from functions when we need to invoke a
25738 method on the sturcture.
25741 2001-10-11 Ravi Pratap <ravi@ximian.com>
25743 * class.cs (TypeContainer::DefineType): Method to actually do the business of
25744 defining the type in the Modulebuilder or Typebuilder. This is to take
25745 care of nested types which need to be defined on the TypeBuilder using
25746 DefineNestedMethod.
25748 (TypeContainer::GetClassBases): Implement. Essentially the code from the
25749 methods in RootContext, only ported to be part of TypeContainer.
25751 (TypeContainer::GetInterfaceOrClass): Ditto.
25753 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
25755 * interface.cs (Interface::DefineInterface): New method. Does exactly
25756 what RootContext.CreateInterface did earlier, only it takes care of nested types
25759 (Interface::GetInterfaces): Move from RootContext here and port.
25761 (Interface::GetInterfaceByName): Same here.
25763 * rootcontext.cs (ResolveTree): Re-write.
25765 (PopulateTypes): Re-write.
25767 * class.cs (TypeContainer::Populate): Populate nested types too.
25768 (TypeContainer::Emit): Emit nested members too.
25770 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25771 instead just use the name argument passed in as it is already fully
25774 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25775 to TypeContainer mapping to see if a type is user-defined.
25777 * class.cs (TypeContainer::CloseType): Implement.
25779 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25780 the default constructor.
25782 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25785 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25787 * interface.cs (CloseType): Create the type here.
25789 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25792 Remove all the methods which are now in TypeContainer.
25794 2001-10-10 Ravi Pratap <ravi@ximian.com>
25796 * delegate.cs (Define): Re-write bits to define the delegate
25799 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25801 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25803 * expression.cs (ImplicitReferenceConversion): handle null as well
25804 as a source to convert to any reference type.
25806 * statement.cs (Return): Perform any implicit conversions to
25807 expected return type.
25809 Validate use of return statement.
25811 * codegen.cs (EmitContext): Pass the expected return type here.
25813 * class.cs (Method, Constructor, Property): Pass expected return
25814 type to EmitContext.
25816 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25818 * expression.cs: Make DoResolve take an EmitContext instead of a
25821 Replaced `l' and `location' for `loc', for consistency.
25823 (Error, Warning): Remove unneeded Tc argument.
25825 * assign.cs, literal.cs, constant.cs: Update to new calling
25828 * codegen.cs: EmitContext now contains a flag indicating whether
25829 code is being generated in a static method or not.
25831 * cs-parser.jay: DecomposeQI, new function that replaces the old
25832 QualifiedIdentifier. Now we always decompose the assembled
25833 strings from qualified_identifier productions into a group of
25836 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25838 * rootcontext.cs: Deal with field-less struct types correctly now
25839 by passing the size option to Define Type.
25841 * class.cs: Removed hack that created one static field.
25843 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25845 * statement.cs: Moved most of the code generation here.
25847 2001-10-09 Ravi Pratap <ravi@ximian.com>
25849 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25852 (ElementAccess): Remove useless bits for now - keep checks as the spec
25855 2001-10-08 Ravi Pratap <ravi@ximian.com>
25857 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25858 and start performing checks according to the spec.
25860 2001-10-07 Ravi Pratap <ravi@ximian.com>
25862 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25863 rank_specifiers instead.
25865 (rank_specifiers): Change the order in which the rank specifiers are stored
25867 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25869 * expression.cs (ElementAccess): Implement the LValue interface too.
25871 2001-10-06 Ravi Pratap <ravi@ximian.com>
25873 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25874 except that user defined conversions are not included.
25876 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25877 perform the conversion of the return type, if necessary.
25879 (New::DoResolve): Check whether we are creating an array or an object
25880 and accordingly do the needful.
25882 (New::Emit): Same here.
25884 (New::DoResolve): Implement guts of array creation.
25886 (New::FormLookupType): Helper function.
25888 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25890 * codegen.cs: Removed most of the code generation here, and move the
25891 corresponding code generation bits to the statement classes.
25893 Added support for try/catch/finalize and throw.
25895 * cs-parser.jay: Added support for try/catch/finalize.
25897 * class.cs: Catch static methods having the flags override,
25898 virtual or abstract.
25900 * expression.cs (UserCast): This user cast was not really doing
25901 what it was supposed to do. Which is to be born in fully resolved
25902 state. Parts of the resolution were being performed at Emit time!
25906 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25908 * expression.cs: Implicity convert the result from UserCast.
25910 2001-10-05 Ravi Pratap <ravi@ximian.com>
25912 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25913 prevented it from working correctly.
25915 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25916 merely ConvertImplicit.
25918 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25920 * typemanager.cs: Make the LookupTypeContainer function static,
25921 and not per-instance.
25923 * class.cs: Make static FindMembers (the one that takes a Type
25926 * codegen.cs: Add EmitForeach here.
25928 * cs-parser.jay: Make foreach a toplevel object instead of the
25929 inline expansion, as we need to perform semantic analysis on it.
25931 2001-10-05 Ravi Pratap <ravi@ximian.com>
25933 * expression.cs (Expression::ImplicitUserConversion): Rename to
25934 UserDefinedConversion.
25936 (Expression::UserDefinedConversion): Take an extra argument specifying
25937 whether we look for explicit user conversions too.
25939 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25941 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25943 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25944 with the appropriate arguments.
25946 * cs-parser.jay (cast_expression): Record location too.
25948 * expression.cs (Cast): Record location info.
25950 (Expression::ConvertExplicit): Take location argument.
25952 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25953 to determine if we are doing explicit conversions.
25955 (UserCast::Emit): Update accordingly.
25957 (Expression::ConvertExplicit): Report an error if everything fails.
25959 * ../errors/cs0030.cs : Add.
25961 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25963 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25964 virtual and newslot bits.
25966 * class.cs (TypeContainer::RegisterRequiredImplementations):
25967 Record methods we need.
25969 (TypeContainer::MakeKey): Helper function to make keys for
25970 MethodBases, since the Methodbase key is useless.
25972 (TypeContainer::Populate): Call RegisterRequiredImplementations
25973 before defining the methods.
25975 Create a mapping for method_builders_to_methods ahead of time
25976 instead of inside a tight loop.
25978 (::RequireMethods): Accept an object as the data to set into the
25979 hashtable so we can report interface vs abstract method mismatch.
25981 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25983 * report.cs: Make all of it static.
25985 * rootcontext.cs: Drop object_type and value_type computations, as
25986 we have those in the TypeManager anyways.
25988 Drop report instance variable too, now it is a global.
25990 * driver.cs: Use try/catch on command line handling.
25992 Add --probe option to debug the error reporting system with a test
25995 * report.cs: Add support for exiting program when a probe
25996 condition is reached.
25998 2001-10-03 Ravi Pratap <ravi@ximian.com>
26000 * expression.cs (Binary::DoNumericPromotions): Fix the case when
26001 we do a forcible conversion regardless of type, to check if
26002 ForceConversion returns a null.
26004 (Binary::error19): Use location to report error.
26006 (Unary::error23): Use location here too.
26008 * ../errors/cs0019.cs : Check in.
26010 * ../errors/cs0023.cs : Check in.
26012 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
26013 case of a non-null MethodInfo object with a length of 0 !
26015 (Binary::ResolveOperator): Flag error if overload resolution fails to find
26016 an applicable member - according to the spec :-)
26017 Also fix logic to find members in base types.
26019 (Unary::ResolveOperator): Same here.
26021 (Unary::report23): Change name to error23 and make first argument a TypeContainer
26022 as I was getting thoroughly confused between this and error19 :-)
26024 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
26025 (::FindMostEncompassedType): Implement.
26026 (::FindMostEncompassingType): Implement.
26027 (::StandardConversionExists): Implement.
26029 (UserImplicitCast): Re-vamp. We now need info about most specific
26030 source and target types so that we can do the necessary conversions.
26032 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
26033 mathematical union with no duplicates.
26035 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26037 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
26038 in order from base classes to child classes, so that we can in
26039 child classes look up in our parent for method names and
26040 attributes (required for handling abstract, virtual, new, override
26041 constructs: we need to instrospect our base class, and if we dont
26042 populate the classes in order, the introspection might be
26043 incorrect. For example, a method could query its parent before
26044 the parent has any methods and would determine that the parent has
26045 no abstract methods (while it could have had them)).
26047 (RootContext::CreateType): Record the order in which we define the
26050 2001-10-02 Miguel de Icaza <miguel@ximian.com>
26052 * class.cs (TypeContainer::Populate): Also method definitions can
26053 fail now, keep track of this.
26055 (TypeContainer::FindMembers): Implement support for
26056 DeclaredOnly/noDeclaredOnly flag.
26058 (Constructor::Emit) Return the ConstructorBuilder.
26060 (Method::Emit) Return the MethodBuilder.
26061 Check for abstract or virtual methods to be public.
26063 * rootcontext.cs (RootContext::CreateType): Register all the
26064 abstract methods required for the class to be complete and the
26065 interface methods that must be implemented.
26067 * cs-parser.jay: Report error 501 (method requires body if it is
26068 not marked abstract or extern).
26070 * expression.cs (TypeOf::Emit): Implement.
26072 * typemanager.cs: runtime_handle_type, new global type.
26074 * class.cs (Property::Emit): Generate code for properties.
26076 2001-10-02 Ravi Pratap <ravi@ximian.com>
26078 * expression.cs (Unary::ResolveOperator): Find operators on base type
26079 too - we now conform exactly to the spec.
26081 (Binary::ResolveOperator): Same here.
26083 * class.cs (Operator::Define): Fix minor quirk in the tests.
26085 * ../errors/cs0215.cs : Added.
26087 * ../errors/cs0556.cs : Added.
26089 * ../errors/cs0555.cs : Added.
26091 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26093 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
26094 single integer which is really efficient
26096 2001-10-01 Ravi Pratap <ravi@ximian.com>
26098 * expression.cs (Expression::ImplicitUserConversion): Use location
26099 even in the case when we are examining True operators.
26101 * class.cs (Operator::Define): Perform extensive checks to conform
26102 with the rules for operator overloading in the spec.
26104 * expression.cs (Expression::ImplicitReferenceConversion): Implement
26105 some of the other conversions mentioned in the spec.
26107 * typemanager.cs (array_type): New static member for the System.Array built-in
26110 (cloneable_interface): For System.ICloneable interface.
26112 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
26113 we start resolving the tree and populating types.
26115 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
26117 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26119 * expression.cs (Expression::ExprClassFromMemberInfo,
26120 Expression::Literalize): Create literal expressions from
26121 FieldInfos which are literals.
26123 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
26124 type casts, because they were wrong. The test suite in tests
26127 (ImplicitNumericConversion): ushort to ulong requires a widening
26130 Int32 constant to long requires widening cast as well.
26132 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
26133 for integers because the type on the stack is not i4.
26135 2001-09-30 Miguel de Icaza <miguel@ximian.com>
26137 * expression.cs (report118): require location argument.
26139 * parameter.cs: Do not dereference potential null value.
26141 * class.cs: Catch methods that lack the `new' keyword when
26142 overriding a name. Report warnings when `new' is used without
26143 anything being there to override.
26145 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
26147 * class.cs: Only add constructor to hashtable if it is non-null
26148 (as now constructors can fail on define).
26150 (TypeManager, Class, Struct): Take location arguments.
26152 Catch field instance initialization in structs as errors.
26154 accepting_filter: a new filter for FindMembers that is static so
26155 that we dont create an instance per invocation.
26157 (Constructor::Define): Catch errors where a struct constructor is
26160 * cs-parser.jay: Pass location information for various new
26163 * delegate.cs (Delegate): take a location argument.
26165 * driver.cs: Do not call EmitCode if there were problesm in the
26166 Definition of the types, as many Builders wont be there.
26168 * decl.cs (Decl::Decl): Require a location argument.
26170 * cs-tokenizer.cs: Handle properly hex constants that can not fit
26171 into integers, and find the most appropiate integer for it.
26173 * literal.cs: Implement ULongLiteral.
26175 * rootcontext.cs: Provide better information about the location of
26176 failure when CreateType fails.
26178 2001-09-29 Miguel de Icaza <miguel@ximian.com>
26180 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
26183 * expression.cs (Binary::CheckShiftArguments): Add missing type
26185 (Binary::ResolveOperator): Add type to the logical and and logical
26186 or, Bitwise And/Or and Exclusive Or code paths, it was missing
26189 (Binary::DoNumericPromotions): In the case where either argument
26190 is ulong (and most signed types combined with ulong cause an
26191 error) perform implicit integer constant conversions as well.
26193 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26195 * expression.cs (UserImplicitCast): Method should always be
26197 (Invocation::BetterConversion): Simplified test for IntLiteral.
26199 (Expression::ImplicitNumericConversion): Split this routine out.
26200 Put the code that performs implicit constant integer conversions
26203 (Expression::Resolve): Become a wrapper around DoResolve so we can
26204 check eclass and type being set after resolve.
26206 (Invocation::Badness): Remove this dead function
26208 (Binary::ResolveOperator): Do not compute the expensive argumnets
26209 unless we have a union for it.
26211 (Probe::Emit): Is needs to do an isinst and then
26212 compare against null.
26214 (::CanConvert): Added Location argument. If the Location argument
26215 is null (Location.Null), then we do not report errors. This is
26216 used by the `probe' mechanism of the Explicit conversion. We do
26217 not want to generate an error for something that the user
26218 explicitly requested to be casted. But the pipeline for an
26219 explicit cast first tests for potential implicit casts.
26221 So for now, if the Location is null, it means `Probe only' to
26222 avoid adding another argument. Might have to revise this
26225 (ClassCast): New class used to type cast objects into arbitrary
26226 classes (used in Explicit Reference Conversions).
26228 Implement `as' as well.
26230 Reverted all the patches from Ravi below: they were broken:
26232 * The use of `level' as a mechanism to stop recursive
26233 invocations is wrong. That was there just to catch the
26234 bug with a strack trace but not as a way of addressing
26237 To fix the problem we have to *understand* what is going
26238 on and the interactions and come up with a plan, not
26239 just get things going.
26241 * The use of the type conversion cache that I proposed
26242 last night had an open topic: How does this work across
26243 protection domains. A user defined conversion might not
26244 be public in the location where we are applying the
26245 conversion, a different conversion might be selected
26246 (ie, private A->B (better) but public B->A (worse),
26247 inside A, A->B applies, but outside it, B->A will
26250 * On top of that (ie, even if the above is solved),
26251 conversions in a cache need to be abstract. Ie, `To
26252 convert from an Int to a Short use an OpcodeCast', not
26253 `To convert from an Int to a Short use the OpcodeCast on
26254 the variable 5' (which is what this patch was doing).
26256 2001-09-28 Ravi Pratap <ravi@ximian.com>
26258 * expression.cs (Invocation::ConversionExists): Re-write to use
26259 the conversion cache
26261 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
26262 cache all conversions done, not just user-defined ones.
26264 (Invocation::BetterConversion): The real culprit. Use ConversionExists
26265 to determine if a conversion exists instead of acutually trying to
26266 perform the conversion. It's faster too.
26268 (Expression::ConvertExplicit): Modify to use ConversionExists to check
26269 and only then attempt the implicit conversion.
26271 2001-09-28 Ravi Pratap <ravi@ximian.com>
26273 * expression.cs (ConvertImplicit): Use a cache for conversions
26274 already found. Check level of recursion and bail out if necessary.
26276 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26278 * typemanager.cs (string_concat_string_string, string_concat_object_object):
26279 Export standard methods that we expect for string operations.
26281 * statement.cs (Block::UsageWarning): Track usage of variables and
26282 report the errors for not used variables.
26284 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
26287 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26289 * codegen.cs: remove unnneded code
26291 * expression.cs: Removed BuiltinTypeAccess class
26293 Fix the order in which implicit conversions are
26296 The previous fixed dropped support for boxed conversions (adding a
26297 test to the test suite now)
26299 (UserImplicitCast::CanConvert): Remove test for source being null,
26300 that code is broken. We should not feed a null to begin with, if
26301 we do, then we should track the bug where the problem originates
26302 and not try to cover it up here.
26304 Return a resolved expression of type UserImplicitCast on success
26305 rather than true/false. Ravi: this is what I was talking about,
26306 the pattern is to use a static method as a "constructor" for
26309 Also, do not create arguments until the very last minute,
26310 otherwise we always create the arguments even for lookups that
26311 will never be performed.
26313 (UserImplicitCast::Resolve): Eliminate, objects of type
26314 UserImplicitCast are born in a fully resolved state.
26316 * typemanager.cs (InitCoreTypes): Init also value_type
26317 (System.ValueType).
26319 * expression.cs (Cast::Resolve): First resolve the child expression.
26321 (LValue): Add new method AddressOf to be used by
26324 Change the argument of Store to take an EmitContext instead of an
26325 ILGenerator, because things like FieldExpr need to be able to call
26326 their children expression to generate the instance code.
26328 (Expression::Error, Expression::Warning): Sugar functions for
26331 (Expression::MemberLookup): Accept a TypeContainer instead of a
26332 Report as the first argument.
26334 (Expression::ResolvePrimary): Killed. I still want to improve
26335 this as currently the code is just not right.
26337 (Expression::ResolveMemberAccess): Simplify, but it is still
26340 (Unary::Resolve): Catch errors in AddressOf operators.
26342 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
26343 index to a byte for the short-version, or the compiler will choose
26344 the wrong Emit call, which generates the wrong data.
26346 (ParameterReference::Emit, ::Store): same.
26348 (FieldExpr::AddressOf): Implement.
26350 * typemanager.cs: TypeManager: made public variable instead of
26353 * driver.cs: document --fatal.
26355 * report.cs (ErrorMessage, WarningMessage): new names for the old
26356 Error and Warning classes.
26358 * cs-parser.jay (member_access): Turn built-in access to types
26359 into a normal simplename
26361 2001-09-27 Ravi Pratap <ravi@ximian.com>
26363 * expression.cs (Invocation::BetterConversion): Fix to cope
26364 with q being null, since this was introducing a bug.
26366 * expression.cs (ConvertImplicit): Do built-in conversions first.
26368 2001-09-27 Ravi Pratap <ravi@ximian.com>
26370 * expression.cs (UserImplicitCast::Resolve): Fix bug.
26372 2001-09-27 Ravi Pratap <ravi@ximian.com>
26374 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
26375 I had introduced long ago (what's new ?).
26377 * expression.cs (UserImplicitCast::CanConvert): Static method to do
26378 the work of all the checking.
26379 (ConvertImplicit): Call CanConvert and only then create object if necessary.
26380 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
26382 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
26383 that is the right way.
26385 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
26386 overloading resolution. Use everywhere instead of cutting and pasting code.
26388 (Binary::ResolveOperator): Use MakeUnionSet.
26390 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
26391 we have to convert to bool types. Not complete yet.
26393 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26395 * typemanager.cs (TypeManager::CSharpName): support ushort.
26397 * expression.cs (Expression::TryImplicitIntConversion): Attempts
26398 to provide an expression that performsn an implicit constant int
26399 conversion (section 6.1.6).
26400 (Expression::ConvertImplicitRequired): Reworked to include
26401 implicit constant expression conversions.
26403 (Expression::ConvertNumericExplicit): Finished.
26405 (Invocation::Emit): If InstanceExpression is null, then it means
26406 that we perform a call on this.
26408 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26410 * expression.cs (Unary::Emit): Remove some dead code.
26411 (Probe): Implement Resolve and Emit for `is'.
26412 (Expression::ConvertImplicitRequired): Attempt to do constant
26413 expression conversions here. Maybe should be moved to
26414 ConvertImplicit, but I am not sure.
26415 (Expression::ImplicitLongConstantConversionPossible,
26416 Expression::ImplicitIntConstantConversionPossible): New functions
26417 that tell whether is it possible to apply an implicit constant
26418 expression conversion.
26420 (ConvertNumericExplicit): Started work on explicit numeric
26423 * cs-parser.jay: Update operator constants.
26425 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
26426 (Parameters::GetSignature): Hook up VerifyArgs here.
26427 (Parameters::VerifyArgs): Verifies that no two arguments have the
26430 * class.cs (Operator): Update the operator names to reflect the
26431 ones that the spec expects (as we are just stringizing the
26434 * expression.cs (Unary::ResolveOperator): Fix bug: Use
26435 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
26436 previous usage did only work for our methods.
26437 (Expression::ConvertImplicit): Handle decimal implicit numeric
26438 conversions as well.
26439 (Expression::InternalTypeConstructor): Used to invoke constructors
26440 on internal types for default promotions.
26442 (Unary::Emit): Implement special handling for the pre/post
26443 increment/decrement for overloaded operators, as they need to have
26444 the same semantics as the other operators.
26446 (Binary::ResolveOperator): ditto.
26447 (Invocation::ConversionExists): ditto.
26448 (UserImplicitCast::Resolve): ditto.
26450 2001-09-26 Ravi Pratap <ravi@ximian.com>
26452 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
26453 operator, return after emitting body. Regression tests pass again !
26455 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
26456 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
26457 (Invocation::OverloadResolve): Ditto.
26458 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
26460 * everywhere : update calls to the above methods accordingly.
26462 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26464 * assign.cs (Assign): Make it inherit from ExpressionStatement.
26466 * expression.cs (ExpressionStatement): New base class used for
26467 expressions that can appear in statements, so that we can provide
26468 an alternate path to generate expression that do not leave a value
26471 (Expression::Emit, and all the derivatives): We no longer return
26472 whether a value is left on the stack or not. Every expression
26473 after being emitted leaves a single value on the stack.
26475 * codegen.cs (EmitContext::EmitStatementExpression): Use the
26476 facilties of ExpressionStatement if possible.
26478 * cs-parser.jay: Update statement_expression.
26480 2001-09-25 Miguel de Icaza <miguel@ximian.com>
26482 * driver.cs: Change the wording of message
26484 2001-09-25 Ravi Pratap <ravi@ximian.com>
26486 * expression.cs (Binary::ResolveOperator): Had forgottten to set
26487 the type of the expression to the return type of the method if
26488 we have an overloaded operator match ! The regression tests pass again !
26489 (Unary::ResolveOperator): Ditto.
26491 * expression.cs (Invocation::ConversionExists): Correct the member lookup
26492 to find "op_Implicit", not "implicit" ;-)
26493 (UserImplicitCast): New class to take care of user-defined implicit conversions.
26494 (ConvertImplicit, ForceConversion): Take TypeContainer argument
26496 * everywhere : Correct calls to the above accordingly.
26498 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
26499 (ConvertImplicit): Do user-defined conversion if it exists.
26501 2001-09-24 Miguel de Icaza <miguel@ximian.com>
26503 * assign.cs: track location.
26504 (Resolve): Use implicit conversions on assignment.
26506 * literal.cs: Oops. Not good, Emit of short access values should
26507 pass (Bytes) or the wrong argument will be selected.
26509 * expression.cs (Unary::Emit): Emit code for -expr.
26511 (Unary::ResolveOperator): Handle `Substract' for non-constants
26512 (substract from zero from the non-constants).
26513 Deal with Doubles as well.
26515 (Expression::ConvertImplicitRequired): New routine that reports an
26516 error if no implicit conversion exists.
26518 (Invocation::OverloadResolve): Store the converted implicit
26519 expressions if we make them
26521 2001-09-24 Ravi Pratap <ravi@ximian.com>
26523 * class.cs (ConstructorInitializer): Take a Location argument.
26524 (ConstructorBaseInitializer): Same here.
26525 (ConstructorThisInitializer): Same here.
26527 * cs-parser.jay : Update all calls accordingly.
26529 * expression.cs (Unary, Binary, New): Take location argument.
26530 Update accordingly everywhere.
26532 * cs-parser.jay : Update all calls to the above to take a location
26535 * class.cs : Ditto.
26537 2001-09-24 Ravi Pratap <ravi@ximian.com>
26539 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
26540 (Invocation::BetterConversion): Same here
26541 (Invocation::ConversionExists): Ditto.
26543 (Invocation::ConversionExists): Implement.
26545 2001-09-22 Ravi Pratap <ravi@ximian.com>
26547 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
26548 Also take an additional TypeContainer argument.
26550 * All over : Pass in TypeContainer as argument to OverloadResolve.
26552 * typemanager.cs (CSharpName): Update to check for the string type and return
26555 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
26558 2001-09-21 Ravi Pratap <ravi@ximian.com>
26560 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
26561 (Invocation::BetterFunction): Implement.
26562 (Invocation::BetterConversion): Implement.
26563 (Invocation::ConversionExists): Skeleton, no implementation yet.
26565 Okay, things work fine !
26567 2001-09-21 Miguel de Icaza <miguel@ximian.com>
26569 * typemanager.cs: declare and load enum_type, delegate_type and
26572 * expression.cs (Expression::Emit): Now emit returns a value that
26573 tells whether a value is left on the stack or not. This strategy
26574 might be reveted tomorrow with a mechanism that would address
26575 multiple assignments.
26576 (Expression::report118): Utility routine to report mismatches on
26579 (Unary::Report23): Report impossible type/operator combination
26582 (Unary::IsIncrementableNumber): Whether the type can be
26583 incremented or decremented with add.
26584 (Unary::ResolveOperator): Also allow enumerations to be bitwise
26586 (Unary::ResolveOperator): Implement ++, !, ~,
26588 (Invocation::Emit): Deal with new Emit convetion.
26590 * All Expression derivatives: Updated their Emit method to return
26591 whether they leave values on the stack or not.
26593 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
26594 stack for expressions that are statements.
26596 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26598 * expression.cs (LValue): New interface. Must be implemented by
26600 (LocalVariableReference, ParameterReference, FieldExpr): Implement
26603 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
26604 interface for generating code, simplifies the code.
26606 2001-09-20 Ravi Pratap <ravi@ximian.com>
26608 * expression.cs (everywhere): Comment out return statements in ::Resolve
26609 methods to avoid the warnings.
26611 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26613 * driver.cs (parse): Report error 2001 if we can not open the
26616 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
26619 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
26622 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
26623 otherwise nested blocks end up with the same index.
26625 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
26627 * expression.cs: Instead of having FIXMEs in the Resolve
26628 functions, throw exceptions so it is obvious that we are facing a
26631 * cs-parser.jay (invocation_expression): Pass Location information.
26633 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
26634 Use a basename for those routines because .NET does not like paths
26637 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
26640 2001-09-19 Miguel de Icaza <miguel@ximian.com>
26642 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
26643 are loading the correct data types (throws an exception if not).
26644 (TypeManager::InitCoreTypes): Use CoreLookupType
26646 * expression.cs (Unary::ResolveOperator): return the child
26647 expression for expressions which are just +expr.
26648 (Unary::ResolveOperator): Return negative literals for -LITERAL
26649 expressions (otherwise they are Unary {Literal}).
26650 (Invocation::Badness): Take into account `Implicit constant
26651 expression conversions'.
26653 * literal.cs (LongLiteral): Implement long literal class.
26654 (IntLiteral): export the `Value' of the intliteral.
26656 2001-09-19 Ravi Pratap <ravi@ximian.com>
26658 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
26660 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
26661 instead of 'Operator'
26663 * expression.cs (Binary::ResolveOperator): Update accordingly.
26664 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
26667 * cs-parser.jay (unary_expression): Update to use the new names.
26669 * gen-treedump.cs (GetUnary): Same here.
26671 * expression.cs (Unary::Resolve): Implement.
26672 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
26673 operators are found instead of making noise ;-)
26674 (Unary::ResolveOperator): New method to do precisely the same thing which
26675 Binary::ResolveOperator does for Binary expressions.
26676 (Unary.method, .Arguments): Add.
26677 (Unary::OperName): Implement.
26678 (Unary::ForceConversion): Copy and Paste !
26680 * class.cs (Operator::Define): Fix a small bug for the case when we have
26683 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
26684 for the inbuilt operators. Only overloading works for now ;-)
26686 2001-09-18 Miguel de Icaza <miguel@ximian.com>
26688 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
26689 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
26691 * expression.cs (This::Emit): Implement.
26692 (This::Resolve): Implement.
26693 (TypeOf:Resolve): Implement.
26694 (Expression::ResolveSimpleName): Add an implicit this to instance
26696 (MemberAccess::Resolve): Deal with Parameters and Fields.
26697 Bind instance variable to Field expressions.
26698 (FieldExpr::Instance): New field used to track the expression that
26699 represents the object instance.
26700 (FieldExpr::Resolve): Track potential errors from MemberLookup not
26702 (FieldExpr::Emit): Implement.
26704 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
26705 the last instruction contains a return opcode to avoid generating
26706 the last `ret' instruction (this generates correct code, and it is
26707 nice to pass the peverify output).
26709 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
26710 initializer for static and instance variables.
26711 (Constructor::Emit): Allow initializer to be null in the case of
26712 static constructors. Only emit initializer for instance
26715 (TypeContainer::FindMembers): Return a null array if there are no
26718 Also fix the code for the MemberTypes.Method branch, as it was not
26719 scanning that for operators (or tried to access null variables before).
26721 * assign.cs (Assign::Emit): Handle instance and static fields.
26725 * driver.cs: Stop compilation if there are parse errors.
26727 * cs-parser.jay (constructor_declaration): Provide default base
26728 initializer for non-static constructors.
26729 (constructor_declarator): Do not provide a default base
26730 initializers if none was specified.
26731 Catch the fact that constructors should not have parameters.
26733 * class.cs: Do not emit parent class initializers for static
26734 constructors, that should be flagged as an error.
26736 2001-09-18 Ravi Pratap <ravi@ximian.com>
26738 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
26739 Move back code into TypeContainer::Populate.
26741 2001-09-18 Ravi Pratap <ravi@ximian.com>
26743 * class.cs (TypeContainer::AddConstructor): Fix the check to
26744 compare against Name, not Basename.
26745 (Operator::OpType): Change Plus and Minus to Add and Subtract.
26747 * cs-parser.jay : Update accordingly.
26749 * class.cs (TypeContainer::FindMembers): For the case where we are searching
26750 for methods, don't forget to look into the operators too.
26751 (RegisterMethodBuilder): Helper method to take care of this for
26752 methods, constructors and operators.
26753 (Operator::Define): Completely revamp.
26754 (Operator.OperatorMethod, MethodName): New fields.
26755 (TypeContainer::Populate): Move the registering of builders into
26756 RegisterMethodBuilder.
26757 (Operator::Emit): Re-write.
26759 * expression.cs (Binary::Emit): Comment out code path to emit method
26760 invocation stuff for the case when we have a user defined operator. I am
26761 just not able to get it right !
26763 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26765 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26768 (Expression::MemberLookup): Provide a version that allows to
26769 specify the MemberTypes and BindingFlags.
26771 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26772 so it was not fetching variable information from outer blocks.
26774 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26775 Beforefieldinit as it was buggy.
26777 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26778 that Ravi put here.
26780 * class.cs (Constructor::Emit): Only emit if block is not null.
26781 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26782 deal with this by semantically definining it as if the user had
26785 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26786 constructors as we now "emit" them at a higher level.
26788 (TypeContainer::DefineDefaultConstructor): Used to define the
26789 default constructors if none was provided.
26791 (ConstructorInitializer): Add methods Resolve and Emit.
26793 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26795 2001-09-17 Ravi Pratap <ravi@ximian.com>
26797 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26798 the default constructor builder with our hashtable for methodbuilders
26801 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26802 and argument_count is 0 in which case we have a match.
26803 (Binary::ResolveOperator): More null checking and miscellaneous coding
26806 2001-09-17 Ravi Pratap <ravi@ximian.com>
26808 * rootcontext.cs (IsNameSpace): Compare against null.
26810 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26812 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26813 and Unary::Operator.
26815 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26818 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26819 we have overloaded operators.
26820 (Binary::ResolveOperator): Implement the part which does the operator overload
26823 * class.cs (Operator::Emit): Implement.
26824 (TypeContainer::Emit): Emit the operators we have too.
26826 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26827 the case when we have a user-defined operator.
26829 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26831 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26833 2001-09-16 Ravi Pratap <ravi@ximian.com>
26835 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26836 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26837 (Constructor::Emit): Implement.
26838 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26839 if we have no work to do.
26840 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26843 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26844 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26846 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26849 2001-09-15 Ravi Pratap <ravi@ximian.com>
26851 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26853 (Tree::RecordNamespace): Method to do what the name says ;-)
26854 (Tree::Namespaces): Property to get at the namespaces hashtable.
26856 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26859 * rootcontext.cs (IsNamespace): Fixed it :-)
26861 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26863 * class.cs (TypeContainer::FindMembers): Add support for
26865 (MethodCore): New class that encapsulates both the shared aspects
26866 of a Constructor and a Method.
26867 (Method, Constructor): Factored pieces into MethodCore.
26869 * driver.cs: Added --fatal which makes errors throw exceptions.
26870 Load System assembly as well as part of the standard library.
26872 * report.cs: Allow throwing exceptions on errors for debugging.
26874 * modifiers.cs: Do not use `parent', instead use the real type
26875 container to evaluate permission settings.
26877 * class.cs: Put Ravi's patch back in. He is right, and we will
26878 have to cope with the
26880 2001-09-14 Ravi Pratap <ravi@ximian.com>
26882 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26883 FamORAssem, not FamANDAssem.
26885 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26887 * driver.cs: Added --parse option that only parses its input files
26890 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26891 incorrect. IsTopLevel is not used to tell whether an object is
26892 root_types or not (that can be achieved by testing this ==
26893 root_types). But to see if this is a top-level *class* (not
26894 necessarly our "toplevel" container).
26896 2001-09-14 Ravi Pratap <ravi@ximian.com>
26898 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26899 parent instead of a direct call to GetType.
26901 2001-09-14 Ravi Pratap <ravi@ximian.com>
26903 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26904 Modifiers.TypeAttr. This should just be a call to that method.
26906 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26907 object so that we can determine if we are top-level or not.
26909 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26912 * enum.cs (Enum::Define): Ditto.
26914 * modifiers.cs (FieldAttr): Re-write.
26916 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26917 (TypeContainer::HaveStaticConstructor): New property to provide access
26918 to precisely that info.
26920 * modifiers.cs (MethodAttr): Re-write.
26921 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26923 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26924 of top-level types as claimed.
26926 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26928 * expression.cs (MemberLookup): Fruitless attempt to lookup
26929 constructors. Maybe I need to emit default constructors? That
26930 might be it (currently .NET emits this for me automatically).
26931 (Invocation::OverloadResolve): Cope with Arguments == null.
26932 (Invocation::EmitArguments): new function, shared by the new
26933 constructor and us.
26934 (Invocation::Emit): Handle static and instance methods. Emit
26935 proper call instruction for virtual or non-virtual invocations.
26936 (New::Emit): Implement.
26937 (New::Resolve): Implement.
26938 (MemberAccess:Resolve): Implement.
26939 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26940 to track instances.
26941 (FieldExpr::Resolve): Set type.
26943 * support.cs: Handle empty arguments.
26945 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26946 SimpleLookup): Auxiliary routines to help parse a qualifier
26949 Update qualifier_identifier rule.
26951 * codegen.cs: Removed debugging messages.
26953 * class.cs: Make this a global thing, this acts just as a "key" to
26954 objects that we might have around.
26956 (Populate): Only initialize method_builders_to_methods once.
26958 * expression.cs (PropertyExpr): Initialize type from the
26961 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26962 Resolve pattern. Attempt to implicitly convert value to boolean.
26965 * expression.cs: Set the type for the int32/int32 argument case.
26966 (Binary::ResolveOperator): Set the return type to boolean for
26967 comparission operators
26969 * typemanager.cs: Remove debugging print code.
26971 (Invocation::Resolve): resolve type.
26973 * class.cs: Allocate a MemberInfo of the correct size, as the code
26974 elsewhere depends on the test to reflect the correct contents.
26976 (Method::) Keep track of parameters, due to System.Reflection holes
26978 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26981 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26982 of the exact size and return that.
26984 (Class::LookupMethodByBuilder): New function that maps
26985 MethodBuilders to its methods. Required to locate the information
26986 on methods because System.Reflection bit us again.
26988 * support.cs: New file, contains an interface ParameterData and
26989 two implementations: ReflectionParameters and InternalParameters
26990 used to access Parameter information. We will need to grow this
26993 * expression.cs (Invocation::GetParameterData): implement a cache
26994 and a wrapper around the ParameterData creation for methods.
26995 (Invocation::OverloadResolve): Use new code.
26997 2001-09-13 Ravi Pratap <ravi@ximian.com>
26999 * class.cs (TypeContainer::EmitField): Remove and move into
27000 (Field::Define): here and modify accordingly.
27001 (Field.FieldBuilder): New member.
27002 (TypeContainer::Populate): Update accordingly.
27003 (TypeContainer::FindMembers): Implement.
27005 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27007 * statement.cs: (VariableInfo::VariableType): New field to be
27008 initialized with the full type once it is resolved.
27010 2001-09-12 Miguel de Icaza <miguel@ximian.com>
27012 * parameter.cs (GetParameterInfo): Use a type cache to compute
27013 things only once, and to reuse this information
27015 * expression.cs (LocalVariableReference::Emit): Implement.
27016 (OpcodeCast::Emit): fix.
27018 (ParameterReference::Resolve): Implement.
27019 (ParameterReference::Emit): Implement.
27021 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
27022 that are expressions need to stay as Expressions.
27024 * typemanager.cs (CSharpName): Returns the C# name of a type if
27027 * expression.cs (Expression::ConvertImplicit): New function that
27028 implements implicit type conversions.
27030 (Expression::ImplicitReferenceConversion): Implements implicit
27031 reference conversions.
27033 (EmptyCast): New type for transparent casts.
27035 (OpcodeCast): New type for casts of types that are performed with
27036 a sequence of bytecodes.
27038 (BoxedCast): New type used for casting value types into reference
27039 types. Emits a box opcode.
27041 (Binary::DoNumericPromotions): Implements numeric promotions of
27042 and computation of the Binary::Type.
27044 (Binary::EmitBranchable): Optimization.
27046 (Binary::Emit): Implement code emission for expressions.
27048 * typemanager.cs (TypeManager): Added two new core types: sbyte
27051 2001-09-12 Ravi Pratap <ravi@ximian.com>
27053 * class.cs (TypeContainer::FindMembers): Method which does exactly
27054 what Type.FindMembers does, only we don't have to use reflection. No
27055 implementation yet.
27057 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
27058 typecontainer objects as we need to get at them.
27059 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
27061 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
27062 typecontainer object.
27064 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
27065 of just a Report object.
27067 2001-09-11 Ravi Pratap <ravi@ximian.com>
27069 * class.cs (Event::Define): Go back to using the prefixes "add_" and
27071 (TypeContainer::Populate): Now define the delegates of the type too.
27072 (TypeContainer.Delegates): Property to access the list of delegates defined
27075 * delegates.cs (Delegate::Define): Implement partially.
27077 * modifiers.cs (TypeAttr): Handle more flags.
27079 2001-09-11 Ravi Pratap <ravi@ximian.com>
27081 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
27083 (Operator::Define): Re-write logic to get types by using the LookupType method
27084 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
27085 (Indexer::Define): Ditto.
27086 (Event::Define): Ditto.
27087 (Property::Define): Ditto.
27089 2001-09-10 Ravi Pratap <ravi@ximian.com>
27091 * class.cs (TypeContainer::Populate): Now define operators too.
27092 (TypeContainer.Operators): New property to access the list of operators
27094 (Operator.OperatorMethodBuilder): New member to hold the method builder
27095 for the operator we are defining.
27096 (Operator::Define): Implement.
27098 2001-09-10 Ravi Pratap <ravi@ximian.com>
27100 * class.cs (Event::Define): Make the prefixes of the accessor methods
27101 addOn_ and removeOn_
27103 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
27104 of the location being passed in too. Ideally, this should go later since all
27105 error reporting should be done through the Report object.
27107 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
27108 (Populate): Iterate thru the indexers we have and define them too.
27109 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
27110 for the get and set accessors.
27111 (Indexer::Define): Implement.
27113 2001-09-09 Miguel de Icaza <miguel@ximian.com>
27115 * expression.cs (Binary::Resolve): Beginning of it. I scratched
27116 my previous implementation, did not work.
27118 * typemanager.cs: Add a couple of missing types (the longs).
27120 * literal.cs: Use TypeManager.bool_type instead of getting it.
27122 * expression.cs (EventExpr): New kind of expressions.
27123 (Expressio::ExprClassFromMemberInfo): finish
27125 2001-09-08 Miguel de Icaza <miguel@ximian.com>
27127 * assign.cs: Emit stores to static fields differently.
27129 2001-09-08 Ravi Pratap <ravi@ximian.com>
27131 * Merge in changes and adjust code to tackle conflicts. Backed out my
27132 code in Assign::Resolve ;-)
27134 2001-09-08 Ravi Pratap <ravi@ximian.com>
27136 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
27137 instead Report.Error and also pass in the location.
27138 (CSharpParser::Lexer): New readonly property to return the reference
27139 to the Tokenizer object.
27140 (declare_local_variables): Use Report.Error with location instead of plain
27144 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
27145 (Operator.CheckBinaryOperator): Ditto.
27147 * cs-parser.jay (operator_declarator): Update accordingly.
27149 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
27150 (CheckBinaryOperator): Same here.
27152 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
27153 on the name without any prefixes of namespace names etc. This is because we
27154 already might have something already fully qualified like
27155 'System.Console.WriteLine'
27157 * assign.cs (Resolve): Begin implementation. Stuck ;-)
27159 2001-09-07 Ravi Pratap <ravi@ximian.com>
27161 * cs-tokenizer.cs (location): Return a string which also contains
27164 * expression.cs (ElementAccess): New class for expressions of the
27165 type 'element access.'
27166 (BaseAccess): New class for expressions of the type 'base access.'
27167 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
27170 * cs-parser.jay (element_access): Implement action.
27171 (base_access): Implement actions.
27172 (checked_expression, unchecked_expression): Implement.
27174 * cs-parser.jay (local_variable_type): Correct and implement.
27175 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
27177 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
27179 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
27180 name and the specifiers.
27182 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
27184 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
27185 making them all public ;-)
27187 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
27190 2001-09-07 Miguel de Icaza <miguel@ximian.com>
27192 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
27194 (FieldExpr, PropertyExprs): New resolved expressions.
27195 (SimpleName::MemberStaticCheck): Perform static checks for access
27196 to non-static fields on static methods. Maybe this should be
27197 generalized for MemberAccesses.
27198 (SimpleName::ResolveSimpleName): More work on simple name
27201 * cs-parser.jay (primary_expression/qualified_identifier): track
27202 the parameter index.
27204 * codegen.cs (CodeGen::Save): Catch save exception, report error.
27205 (EmitContext::EmitBoolExpression): Chain to expression generation
27206 instead of temporary hack.
27207 (::EmitStatementExpression): Put generic expression code generation.
27209 * assign.cs (Assign::Emit): Implement variable assignments to
27210 local variables, parameters and fields.
27212 2001-09-06 Miguel de Icaza <miguel@ximian.com>
27214 * statement.cs (Block::GetVariableInfo): New method, returns the
27215 VariableInfo for a variable name in a block.
27216 (Block::GetVariableType): Implement in terms of GetVariableInfo
27218 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
27219 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
27221 2001-09-06 Ravi Pratap <ravi@ximian.com>
27223 * cs-parser.jay (operator_declaration): Continue on my quest : update
27224 to take attributes argument.
27225 (event_declaration): Ditto.
27226 (enum_declaration): Ditto.
27227 (indexer_declaration): Ditto.
27229 * class.cs (Operator::Operator): Update constructor accordingly.
27230 (Event::Event): Ditto.
27232 * delegate.cs (Delegate::Delegate): Same here.
27234 * enum.cs (Enum::Enum): Same here.
27236 2001-09-05 Ravi Pratap <ravi@ximian.com>
27238 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
27240 * ../tests/cs0658.cs : New file to demonstrate error 0658.
27242 * attribute.cs (Attributes): New class to encapsulate all attributes which were
27243 being passed around as an arraylist.
27244 (Attributes::AddAttribute): Method to add attribute sections.
27246 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
27247 (struct_declaration): Update accordingly.
27248 (constant_declaration): Update.
27249 (field_declaration): Update.
27250 (method_header): Update.
27251 (fixed_parameter): Update.
27252 (parameter_array): Ditto.
27253 (property_declaration): Ditto.
27254 (destructor_declaration): Ditto.
27256 * class.cs (Struct::Struct): Update constructors accordingly.
27257 (Class::Class): Ditto.
27258 (Field::Field): Ditto.
27259 (Method::Method): Ditto.
27260 (Property::Property): Ditto.
27261 (TypeContainer::OptAttribute): update property's return type.
27263 * interface.cs (Interface.opt_attributes): New member.
27264 (Interface::Interface): Update to take the extra Attributes argument.
27266 * parameter.cs (Parameter::Parameter): Ditto.
27268 * constant.cs (Constant::Constant): Ditto.
27270 * interface.cs (InterfaceMemberBase): New OptAttributes field.
27271 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
27272 the attributes as a parameter.
27273 (InterfaceProperty): Update constructor call.
27274 (InterfaceEvent): Ditto.
27275 (InterfaceMethod): Ditto.
27276 (InterfaceIndexer): Ditto.
27278 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
27279 pass the attributes too.
27280 (interface_event_declaration): Ditto.
27281 (interface_property_declaration): Ditto.
27282 (interface_method_declaration): Ditto.
27283 (interface_declaration): Ditto.
27285 2001-09-05 Miguel de Icaza <miguel@ximian.com>
27287 * class.cs (Method::Define): Track the "static Main" definition to
27288 create an entry point.
27290 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
27291 EntryPoint if we find it.
27293 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
27294 (EmitContext::ig): Make this variable public.
27296 * driver.cs: Make the default output file be the first file name
27297 with the .exe extension.
27299 Detect empty compilations
27301 Handle various kinds of output targets. Handle --target and
27302 rename -t to --dumper.
27304 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
27305 methods inherited from Expression return now an Expression. This
27306 will is used during the tree rewriting as we resolve them during
27309 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
27310 the spec. Missing entirely is the information about
27311 accessability of elements of it.
27313 (Expression::ExprClassFromMemberInfo): New constructor for
27314 Expressions that creates a fully initialized Expression based on
27315 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
27318 (Invocation::Resolve): Begin implementing resolution of invocations.
27320 * literal.cs (StringLiteral): Implement Emit.
27322 2001-09-05 Ravi Pratap <ravi@ximian.com>
27324 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
27327 2001-09-04 Ravi Pratap <ravi@ximian.com>
27329 * cs-parser.jay (attribute_arguments): Implement actions.
27330 (attribute): Fix bug in production. Implement action.
27331 (attribute_list): Implement.
27332 (attribute_target): Implement.
27333 (attribute_target_specifier, opt_target_specifier): Implement
27334 (CheckAttributeTarget): New method to check if the attribute target
27336 (attribute_section): Implement.
27337 (opt_attributes): Implement.
27339 * attribute.cs : New file to handle attributes.
27340 (Attribute): Class to hold attribute info.
27342 * cs-parser.jay (opt_attribute_target_specifier): Remove production
27343 (attribute_section): Modify production to use 2 different rules to
27344 achieve the same thing. 1 s/r conflict down !
27345 Clean out commented, useless, non-reducing dimension_separator rules.
27347 * class.cs (TypeContainer.attributes): New member to hold list
27348 of attributes for a type.
27349 (Struct::Struct): Modify to take one more argument, the attribute list.
27350 (Class::Class): Ditto.
27351 (Field::Field): Ditto.
27352 (Method::Method): Ditto.
27353 (Property::Property): Ditto.
27355 * cs-parser.jay (struct_declaration): Update constructor call to
27356 pass in the attributes too.
27357 (class_declaration): Ditto.
27358 (constant_declaration): Ditto.
27359 (field_declaration): Ditto.
27360 (method_header): Ditto.
27361 (fixed_parameter): Ditto.
27362 (parameter_array): Ditto.
27363 (property_declaration): Ditto.
27365 * constant.cs (Constant::Constant): Update constructor similarly.
27366 Use System.Collections.
27368 * parameter.cs (Parameter::Parameter): Update as above.
27370 2001-09-02 Ravi Pratap <ravi@ximian.com>
27372 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
27373 (TypeContainer.delegates): New member to hold list of delegates.
27375 * cs-parser.jay (delegate_declaration): Implement the action correctly
27376 this time as I seem to be on crack ;-)
27378 2001-09-02 Miguel de Icaza <miguel@ximian.com>
27380 * rootcontext.cs (RootContext::IsNamespace): new function, used to
27381 tell whether an identifier represents a namespace.
27383 * expression.cs (NamespaceExpr): A namespace expression, used only
27384 temporarly during expression resolution.
27385 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
27386 utility functions to resolve names on expressions.
27388 2001-09-01 Miguel de Icaza <miguel@ximian.com>
27390 * codegen.cs: Add hook for StatementExpressions.
27392 * class.cs: Fix inverted test for static flag in methods.
27394 2001-09-02 Ravi Pratap <ravi@ximian.com>
27396 * class.cs (Operator::CheckUnaryOperator): Correct error number used
27397 to make it coincide with MS' number.
27398 (Operator::CheckBinaryOperator): Ditto.
27400 * ../errors/errors.txt : Remove error numbers added earlier.
27402 * ../errors/cs1019.cs : Test case for error # 1019
27404 * ../errros/cs1020.cs : Test case for error # 1020
27406 * cs-parser.jay : Clean out commented cruft.
27407 (dimension_separators, dimension_separator): Comment out. Ostensibly not
27408 used anywhere - non-reducing rule.
27409 (namespace_declarations): Non-reducing rule - comment out.
27411 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
27412 with TypeContainer::AddEnum.
27414 * delegate.cs : New file for delegate handling classes.
27415 (Delegate): Class for declaring delegates.
27417 * makefile : Update.
27419 * cs-parser.jay (delegate_declaration): Implement.
27421 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
27423 * class.cs (Event::Define): Implement.
27424 (Event.EventBuilder): New member.
27426 * class.cs (TypeContainer::Populate): Update to define all enums and events
27428 (Events): New property for the events arraylist we hold. Shouldn't we move to using
27429 readonly fields for all these cases ?
27431 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27433 * class.cs (Property): Revamp to use the convention of making fields readonly.
27434 Accordingly modify code elsewhere.
27436 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
27437 the Define method of the Property class.
27439 * class.cs : Clean up applied patch and update references to variables etc. Fix
27441 (TypeContainer::Populate): Update to define all the properties we have. Also
27442 define all enumerations.
27444 * enum.cs (Define): Implement.
27446 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27448 * cs-parser.jay (overloadable_operator): The semantic value is an
27449 enum of the Operator class.
27450 (operator_declarator): Implement actions.
27451 (operator_declaration): Implement.
27453 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
27454 validity of definitions.
27455 (Operator::CheckBinaryOperator): Static method to check for binary operators
27456 (TypeContainer::AddOperator): New method to add an operator to a type.
27458 * cs-parser.jay (indexer_declaration): Added line to actually call the
27459 AddIndexer method so it gets added ;-)
27461 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
27462 already taken care of by the MS compiler ?
27464 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27466 * class.cs (Operator): New class for operator declarations.
27467 (Operator::OpType): Enum for the various operators.
27469 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27471 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
27472 ostensibly handle this in semantic analysis.
27474 * cs-parser.jay (general_catch_clause): Comment out
27475 (specific_catch_clauses, specific_catch_clause): Ditto.
27476 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
27477 (catch_args, opt_catch_args): New productions.
27478 (catch_clause): Rewrite to use the new productions above
27479 (catch_clauses): Modify accordingly.
27480 (opt_catch_clauses): New production to use in try_statement
27481 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
27482 and re-write the code in the actions to extract the specific and
27483 general catch clauses by being a little smart ;-)
27485 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
27486 Hooray, try and catch statements parse fine !
27488 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27490 * statement.cs (Block::GetVariableType): Fix logic to extract the type
27491 string from the hashtable of variables.
27493 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
27494 I end up making that mistake ;-)
27495 (catch_clauses): Fixed gross error which made Key and Value of the
27496 DictionaryEntry the same : $1 !!
27498 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27500 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
27502 * cs-parser.jay (event_declaration): Correct to remove the semicolon
27503 when the add and remove accessors are specified.
27505 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27507 * cs-parser.jay (IndexerDeclaration): New helper class to hold
27508 information about indexer_declarator.
27509 (indexer_declarator): Implement actions.
27510 (parsing_indexer): New local boolean used to keep track of whether
27511 we are parsing indexers or properties. This is necessary because
27512 implicit_parameters come into picture even for the get accessor in the
27513 case of an indexer.
27514 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
27516 * class.cs (Indexer): New class for indexer declarations.
27517 (TypeContainer::AddIndexer): New method to add an indexer to a type.
27518 (TypeContainer::indexers): New member to hold list of indexers for the
27521 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27523 * cs-parser.jay (add_accessor_declaration): Implement action.
27524 (remove_accessor_declaration): Implement action.
27525 (event_accessors_declaration): Implement
27526 (variable_declarators): swap statements for first rule - trivial.
27528 * class.cs (Event): New class to hold information about event
27530 (TypeContainer::AddEvent): New method to add an event to a type
27531 (TypeContainer::events): New member to hold list of events.
27533 * cs-parser.jay (event_declaration): Implement actions.
27535 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27537 * cs-parser.jay (dim_separators): Implement. Make it a string
27538 concatenating all the commas together, just as they appear.
27539 (opt_dim_separators): Modify accordingly
27540 (rank_specifiers): Update accordingly. Basically do the same
27541 thing - instead, collect the brackets here.
27542 (opt_rank_sepcifiers): Modify accordingly.
27543 (array_type): Modify to actually return the complete type string
27544 instead of ignoring the rank_specifiers.
27545 (expression_list): Implement to collect the expressions
27546 (variable_initializer): Implement. We make it a list of expressions
27547 essentially so that we can handle the array_initializer case neatly too.
27548 (variable_initializer_list): Implement.
27549 (array_initializer): Make it a list of variable_initializers
27550 (opt_array_initializer): Modify accordingly.
27552 * expression.cs (New::NType): Add enumeration to help us
27553 keep track of whether we have an object/delegate creation
27554 or an array creation.
27555 (New:NewType, New::Rank, New::Indices, New::Initializers): New
27556 members to hold data about array creation.
27557 (New:New): Modify to update NewType
27558 (New:New): New Overloaded contructor for the array creation
27561 * cs-parser.jay (array_creation_expression): Implement to call
27562 the overloaded New constructor.
27564 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
27566 * class.cs (TypeContainer::Constructors): Return member
27567 constructors instead of returning null.
27569 2001-08-26 Miguel de Icaza <miguel@ximian.com>
27571 * typemanager.cs (InitCoreTypes): Initialize the various core
27572 types after we have populated the type manager with the user
27573 defined types (this distinction will be important later while
27574 compiling corlib.dll)
27576 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
27577 on Expression Classification. Now all expressions have a method
27578 `Resolve' and a method `Emit'.
27580 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
27581 generation from working. Also add some temporary debugging
27584 2001-08-24 Miguel de Icaza <miguel@ximian.com>
27586 * codegen.cs: Lots of code generation pieces. This is only the
27587 beginning, will continue tomorrow with more touches of polish. We
27588 handle the fundamentals of if, while, do, for, return. Others are
27589 trickier and I need to start working on invocations soon.
27591 * gen-treedump.cs: Bug fix, use s.Increment here instead of
27594 * codegen.cs (EmitContext): New struct, used during code
27595 emission to keep a context. Most of the code generation will be
27598 * cs-parser.jay: Add embedded blocks to the list of statements of
27599 this block. So code generation proceeds in a top down fashion.
27601 2001-08-23 Miguel de Icaza <miguel@ximian.com>
27603 * statement.cs: Add support for multiple child blocks.
27605 2001-08-22 Miguel de Icaza <miguel@ximian.com>
27607 * codegen.cs (EmitCode): New function, will emit the code for a
27608 Block of code given a TypeContainer and its ILGenerator.
27610 * statement.cs (Block): Standard public readonly optimization.
27611 (Block::Block constructors): Link children.
27612 (Block::Child): Child Linker.
27613 (Block::EmitVariables): Emits IL variable declarations.
27615 * class.cs: Drop support for MethodGroups here, delay until
27617 (Method::): Applied the same simplification that I did before, and
27618 move from Properties to public readonly fields.
27619 (Method::ParameterTypes): Returns the parameter types for the
27620 function, and implements a cache that will be useful later when I
27621 do error checking and the semantic analysis on the methods is
27623 (Constructor::GetCallingConvention): Renamed from CallingConvetion
27624 and made a method, optional argument tells whether this is a class
27625 or a structure to apply the `has-this' bit.
27626 (Method::GetCallingConvention): Implement, returns the calling
27628 (Method::Define): Defines the type, a second pass is performed
27629 later to populate the methods.
27631 (Constructor::ParameterTypes): implement a cache similar to the
27632 one on Method::ParameterTypes, useful later when we do semantic
27635 (TypeContainer::EmitMethod): New method. Emits methods.
27637 * expression.cs: Removed MethodGroup class from here.
27639 * parameter.cs (Parameters::GetCallingConvention): new method.
27641 2001-08-21 Miguel de Icaza <miguel@ximian.com>
27643 * class.cs (TypeContainer::Populate): Drop RootContext from the
27646 (Constructor::CallingConvention): Returns the calling convention.
27647 (Constructor::ParameterTypes): Returns the constructor parameter
27650 (TypeContainer::AddConstructor): Keep track of default constructor
27651 and the default static constructor.
27653 (Constructor::) Another class that starts using `public readonly'
27654 instead of properties.
27656 (Constructor::IsDefault): Whether this is a default constructor.
27658 (Field::) use readonly public fields instead of properties also.
27660 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
27661 track of static constructors; If none is used, turn on
27662 BeforeFieldInit in the TypeAttributes.
27664 * cs-parser.jay (opt_argument_list): now the return can be null
27665 for the cases where there are no arguments.
27667 (constructor_declarator): If there is no implicit `base' or
27668 `this', then invoke the default parent constructor.
27670 * modifiers.cs (MethodAttr): New static function maps a set of
27671 modifiers flags into a MethodAttributes enum
27672 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
27673 MethodAttr, TypeAttr to represent the various mappings where the
27674 modifiers are used.
27675 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
27677 2001-08-19 Miguel de Icaza <miguel@ximian.com>
27679 * parameter.cs (GetParameterInfo): Fix bug where there would be no
27682 * interface.cs (PopulateIndexer): Implemented the code generator
27683 for interface indexers.
27685 2001-08-17 Miguel de Icaza <miguel@ximian.com>
27687 * interface.cs (InterfaceMemberBase): Now we track the new status
27690 (PopulateProperty): Implement property population. Woohoo! Got
27691 Methods and Properties going today.
27693 Removed all the properties for interfaces, and replaced them with
27694 `public readonly' fields.
27696 2001-08-16 Miguel de Icaza <miguel@ximian.com>
27698 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
27699 initialize their hashtables/arraylists only when they are needed
27700 instead of doing this always.
27702 * parameter.cs: Handle refs and out parameters.
27704 * cs-parser.jay: Use an ArrayList to construct the arguments
27705 instead of the ParameterCollection, and then cast that to a
27708 * parameter.cs: Drop the use of ParameterCollection and use
27709 instead arrays of Parameters.
27711 (GetParameterInfo): Use the Type, not the Name when resolving
27714 2001-08-13 Miguel de Icaza <miguel@ximian.com>
27716 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
27717 and instead use public readonly fields.
27719 * class.cs: Put back walking code for type containers.
27721 2001-08-11 Miguel de Icaza <miguel@ximian.com>
27723 * class.cs (MakeConstant): Code to define constants.
27725 * rootcontext.cs (LookupType): New function. Used to locate types
27728 2001-08-08 Miguel de Icaza <miguel@ximian.com>
27730 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
27731 this System.Reflection code is. Kudos to Microsoft
27733 * typemanager.cs: Implement a type cache and avoid loading all
27734 types at boot time. Wrap in LookupType the internals. This made
27735 the compiler so much faster. Wow. I rule!
27737 * driver.cs: Make sure we always load mscorlib first (for
27738 debugging purposes, nothing really important).
27740 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
27741 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
27743 * rootcontext.cs: Lookup types on their namespace; Lookup types
27744 on namespaces that have been imported using the `using' keyword.
27746 * class.cs (TypeContainer::TypeAttr): Virtualize.
27747 (Class::TypeAttr): Return attributes suitable for this bad boy.
27748 (Struct::TypeAttr): ditto.
27749 Handle nested classes.
27750 (TypeContainer::) Remove all the type visiting code, it is now
27751 replaced with the rootcontext.cs code
27753 * rootcontext.cs (GetClassBases): Added support for structs.
27755 2001-08-06 Miguel de Icaza <miguel@ximian.com>
27757 * interface.cs, statement.cs, class.cs, parameter.cs,
27758 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
27759 Drop use of TypeRefs, and use strings instead.
27761 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27765 * class.cs (Struct::Struct): set the SEALED flags after
27766 checking the modifiers.
27767 (TypeContainer::TypeAttr): new property, returns the
27768 TypeAttributes for a class.
27770 * cs-parser.jay (type_list): Oops, list production was creating a
27771 new list of base types.
27773 * rootcontext.cs (StdLib): New property.
27774 (GetInterfaceTypeByName): returns an interface by type name, and
27775 encapsulates error handling here.
27776 (GetInterfaces): simplified.
27777 (ResolveTree): Encapsulated all the tree resolution here.
27778 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27781 * driver.cs: Add support for --nostdlib, to avoid loading the
27782 default assemblies.
27783 (Main): Do not put tree resolution here.
27785 * rootcontext.cs: Beginning of the class resolution.
27787 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27789 * rootcontext.cs: Provide better error reporting.
27791 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27793 * rootcontext.cs (CreateInterface): Handle the case where there
27794 are no parent interfaces.
27796 (CloseTypes): Routine to flush types at the end.
27797 (CreateInterface): Track types.
27798 (GetInterfaces): Returns an array of Types from the list of
27799 defined interfaces.
27801 * typemanager.c (AddUserType): Mechanism to track user types (puts
27802 the type on the global type hash, and allows us to close it at the
27805 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27807 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27808 RecordInterface instead.
27810 * cs-parser.jay: Updated to reflect changes above.
27812 * decl.cs (Definition): Keep track of the TypeBuilder type that
27813 represents this type here. Not sure we will use it in the long
27814 run, but wont hurt for now.
27816 * driver.cs: Smaller changes to accomodate the new code.
27818 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27821 * rootcontext.cs (CreateInterface): New method, used to create
27822 the System.TypeBuilder type for interfaces.
27823 (ResolveInterfaces): new entry point to resolve the interface
27825 (CodeGen): Property, used to keep track of the code generator.
27827 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27829 * cs-parser.jay: Add a second production for delegate_declaration
27832 (enum_body): Put an opt_comma here instead of putting it on
27833 enum_body or enum_member_declarations so we can handle trailing
27834 commas on enumeration members. Gets rid of a shift/reduce.
27836 (type_list): Need a COMMA in the middle.
27838 (indexer_declaration): Tell tokenizer to recognize get/set
27840 * Remove old targets.
27842 * Re-add the parser target.
27844 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27846 * cs-parser.jay: Add precendence rules for a number of operators
27847 ot reduce the number of shift/reduce conflicts in the grammar.
27849 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27851 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27854 Get rid of old crufty code.
27856 * rootcontext.cs: Use this to keep track of the parsed
27857 representation and the defined types available to the program.
27859 * gen-treedump.cs: adjust for new convention.
27861 * type.cs: Split out the type manager, and the assembly builder
27864 * typemanager.cs: the type manager will live here now.
27866 * cil-codegen.cs: And the code generator here.
27868 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27870 * makefile: Fixed up for easy making.
27872 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27874 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27877 (unary_expression): Expand pre_increment_expression and
27878 post_decrement_expression to reduce a shift/reduce.
27880 2001-07-11 Simon Cozens
27882 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27884 Improve allow_keyword_as_indent name.
27886 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27888 * Adjustments for Beta2.
27890 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27892 * decl.cs: Added `Define' abstract method.
27893 (InTransit): new property, used to catch recursive definitions.
27895 * interface.cs: Implement `Define'.
27897 * modifiers.cs: Map Modifiers.constants to
27898 System.Reflection.TypeAttribute flags.
27900 * class.cs: Keep track of types and user-defined types.
27901 (BuilderInit): New method for creating an assembly
27902 (ResolveType): New function to launch the resolution process, only
27903 used by interfaces for now.
27905 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27906 that are inserted into the name space.
27908 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27910 * ARGH. I have screwed up my tree so many times due to the use of
27911 rsync rather than using CVS. Going to fix this at once.
27913 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27916 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27918 * Experiment successful: Use System.Type rather that our own
27921 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27923 * cs-parser.jay: Removed nsAliases from here.
27925 Use new namespaces, handle `using XXX;'
27927 * namespace.cs: Reimplemented namespace handling, use a recursive
27928 definition of the class. Now we can keep track of using clauses
27929 and catch invalid using clauses.
27931 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27933 * gen-treedump.cs: Adapted for all the renaming.
27935 * expression.cs (Expression): this class now has a Type property
27936 which returns an expression Type.
27938 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27939 `Type', as this has a different meaning now in the base
27941 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27943 * interface.cs, class.cs: Removed from all the sources the
27944 references to signature computation, as we can not do method
27945 signature computation during the parsing time, as we are not
27946 trying to solve at that point distinguishing:
27950 void a (NS.Blah x) {}
27953 Which depending on the context might be valid or not, as we do not
27954 know if Blah is the same thing as NS.Blah at that point.
27956 * Redid everything so the code uses TypeRefs now instead of
27957 Types. TypeRefs are just temporary type placeholders, that need
27958 to be resolved. They initially have a pointer to a string and the
27959 current scope in which they are used. This is used later by the
27960 compiler to resolve the reference to an actual Type.
27962 * DeclSpace is no longer a CIR.Type, and neither are
27963 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27964 are all DeclSpaces, but no Types.
27966 * type.cs (TypeRefManager): This implements the TypeRef manager,
27967 which keeps track of all the types that need to be resolved after
27968 the parsing has finished.
27970 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27972 * ARGH. We are going to have to store `foreach' as a class rather
27973 than resolving it, as we need to verify error 1579 after name
27974 resolution. *OR* we could keep a flag that says `This request to
27975 IEnumerator comes from a foreach statement' which we can then use
27976 to generate the error.
27978 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27980 * class.cs (TypeContainer.AddMethod): we now add methods to the
27981 MethodGroup instead of the method hashtable.
27983 * expression.cs: Add MethodGroup abstraction, which gets us one
27984 step closer to the specification in the way we handle method
27987 * cs-parser.jay (primary_expression): qualified_identifier now
27988 tried to match up an identifier to a local variable reference or
27989 to a parameter reference.
27991 current_local_parameters is now a parser global variable that
27992 points to the current parameters for the block, used during name
27995 (property_declaration): Now creates an implicit `value' argument to
27998 2001-05-09 Miguel de Icaza <miguel@ximian.com>
28000 * parameter.cs: Do not use `param' arguments as part of the
28001 signature, per the spec.
28003 2001-05-08 Miguel de Icaza <miguel@ximian.com>
28005 * decl.cs: Base class for classes, structs and interfaces. This
28006 is the "Declaration Space"
28008 * cs-parser.jay: Use CheckDef for checking declaration errors
28009 instead of having one on each function.
28011 * class.cs: Factor out some code for handling error handling in
28012 accordance to the "Declarations" section in the "Basic Concepts"
28013 chapter in the ECMA C# spec.
28015 * interface.cs: Make all interface member classes derive from
28016 InterfaceMemberBase.
28018 2001-05-07 Miguel de Icaza <miguel@ximian.com>
28020 * Many things: all interfaces are parsed and generated in
28021 gen-treedump. Support for member variables, constructors,
28022 destructors, properties, constants is there.
28024 Beginning of the IL backend, but very little done, just there for
28027 2001-04-29 Miguel de Icaza <miguel@ximian.com>
28029 * cs-parser.jay: Fix labeled statement.
28031 * cs-tokenizer.cs (escape): Escape " and ' always.
28032 ref_line, ref_name: keep track of the line/filename as instructed
28033 by #line by the compiler.
28036 2001-04-27 Miguel de Icaza <miguel@ximian.com>
28038 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
28039 to match the values in System.CodeDOM.
28041 Divid renamed to Divide.
28043 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
28045 (Statements.set): remove.
28047 * System.CodeDOM/CodeCatchClause.cs: always have a valid
28050 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
28051 falseStatements always have valid values.
28053 * cs-parser.jay: Use System.CodeDOM now.