1 2010-05-11 Marek Safar <marek.safar@gmail.com>
4 * namespace.cs: Don't report namespace collision.
6 2010-05-11 Marek Safar <marek.safar@gmail.com>
9 * class.cs, typespec.cs: Search full imported attribute hierarchy
12 2010-05-11 Marek Safar <marek.safar@gmail.com>
14 * namespace.cs: Ignore missing dependencies failure at
17 2010-05-11 Marek Safar <marek.safar@gmail.com>
20 * namespace.cs: Don't resolve using constraints too early.
22 2010-05-11 Marek Safar <marek.safar@gmail.com>
25 * generic.cs: Copy partial type constraints to partial container.
27 2010-05-10 Marek Safar <marek.safar@gmail.com>
30 * import.cs: Relax underlying enum field rules.
32 2010-05-10 Marek Safar <marek.safar@gmail.com>
35 * property.cs: Implement IParametersMember for indexer accessors.
37 2010-05-07 Marek Safar <marek.safar@gmail.com>
40 * class.cs: Update all partial modifiers.
42 2010-05-06 Marek Safar <marek.safar@gmail.com>
45 * method.cs, membercache.cs: Destructors cannot be hidden.
47 2010-05-06 Marek Safar <marek.safar@gmail.com>
50 * class.cs: Resursive reference of type definition is allowed.
52 2010-05-06 Marek Safar <marek.safar@gmail.com>
54 * anonymous.cs: Mutate cached storey instance types too.
56 2010-05-06 Marek Safar <marek.safar@gmail.com>
59 * convert.cs: Explicit enum conversion cannot involve user operators
61 2010-05-05 Miguel de Icaza <miguel@novell.com>
63 * class.cs (TypeContainer.DefineBaseTypes)
64 (TypeContainer.CheckRecursiveDefinition): check for the iface not
65 being null, as we could have failed resolution and crashed;
68 * cs-parser.jay: Productions to catch common mistakes when other
69 punctuation operators are used instead of comma. Fixes 571702
71 2010-05-05 Marek Safar <marek.safar@gmail.com>
73 * anonymous.cs: Mutate correct set of constraints.
75 2010-05-05 Marek Safar <marek.safar@gmail.com>
78 * expression.cs: Resolve all array bound arguments.
80 2010-05-05 Marek Safar <marek.safar@gmail.com>
82 * import.cs: Don't import private fields.
84 2010-04-30 Marek Safar <marek.safar@gmail.com>
86 Partially based on patch by <sami.lamti@gmail.com>
88 * eval.cs, ecore.cs: Fixed eval show methods.
90 2010-04-30 Marek Safar <marek.safar@gmail.com>
92 * generic.cs, delegate.cs: Implement output type inference of
93 methodgroup now when the specification was cleared at least little
96 2010-04-29 Marek Safar <marek.safar@gmail.com>
99 * class.cs: Fix recursive unmanaged recursice sruct check.
101 2010-04-29 Marek Safar <marek.safar@gmail.com>
103 A fix for bug #479776
104 * expression.cs: Implement typeof unbounded nested generic types.
106 2010-04-29 Marek Safar <marek.safar@gmail.com>
108 A fix for bug #474953
109 * class.cs: Fix valid recursive base type definition.
111 2010-04-29 Marek Safar <marek.safar@gmail.com>
113 A fix for bug #421737
114 * convert.cs, expression.cs: A boxing conversion exists from a
115 nullable-type to a reference type, if a boxing conversion exists
116 from the underlying non-nullable-value-type to the reference type.
118 2010-04-29 Marek Safar <marek.safar@gmail.com>
120 A fix for bug #376875
121 * import.cs: Import volatile modifier.
123 2010-04-29 Marek Safar <marek.safar@gmail.com>
125 A fix for bug #372412
126 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
129 2010-04-29 Marek Safar <marek.safar@gmail.com>
131 A fix for bug #568955
132 * statements.cs: Handle recursive scope initializers.
134 2010-04-28 Marek Safar <marek.safar@gmail.com>
136 A fix for bug #566511
137 * anonymous.cs: Always get inflated version of hoisted variable
138 on generic type definition.
140 2010-04-28 Marek Safar <marek.safar@gmail.com>
142 * import.cs, membercache.cs: Relax rules for valid properties.
144 2010-04-28 Marek Safar <marek.safar@gmail.com>
146 * import.cs: Intern arrays used in generic arguments.
148 2010-04-28 Marek Safar <marek.safar@gmail.com>
150 A fix for bug #600398
151 * convert.cs: Actually use effective base type for the comparison.
153 2010-04-28 Marek Safar <marek.safar@gmail.com>
155 A fix for bug #600326
156 * ecore.cs: Pass arity to base member lookup.
158 2010-04-28 Marek Safar <marek.safar@gmail.com>
160 A fix for bug #573385
161 * expression.cs: MemberAccess is of generic type based on right
164 2010-05-28 Marek Safar <marek.safar@gmail.com>
166 * cs-tokenizer.cs: Made tab size configurable.
168 2010-05-27 Marek Safar <marek.safar@gmail.com>
170 * attribute.cs: Ensure Obsolete members are defined before doing
173 2010-05-27 Marek Safar <marek.safar@gmail.com>
175 * visit.cs: Add DOM visitor skeleton.
179 2010-05-27 Marek Safar <marek.safar@gmail.com>
181 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
183 2010-05-27 Marek Safar <marek.safar@gmail.com>
185 * *.cs: Major rewrite of compiler internals to better work with
186 unmodified System.Reflection.Emit. Some of the key changes are
187 - TypeSpec replaces reflection specific System.Type.
188 - All Type(TypeSpec) operations are now done in compiler therefore
189 no dependency on SRE to inflate generic members and types or to
190 query unclosed types.
191 - MemberCache is now the only and full hierarchical topology.
192 - Generic constraints are implemented properly.
193 - And as a bonus compilation is on average 30% faster.
195 2010-04-15 Jb Evain <jbevain@novell.com>
197 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
199 2010-04-12 Marek Safar <marek.safar@gmail.com>
201 * expression.cs, attribute.cs, parameter.cs: More attribute type
204 2010-04-12 Marek Safar <marek.safar@gmail.com>
206 A fix for bug #593342
208 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
209 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
210 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
211 codegen.cs: Add custom attribute encoder to deal with unfinished
212 types and easier corlib bootstrap from its own types.
214 2010-03-26 Marek Safar <marek.safar@gmail.com>
216 * cs-parser.jay: Report invalid constraint types.
218 2010-03-16 Jb Evain <jbevain@novell.com>
220 * Makefile: rename the net_2_1 profile to moonlight.
222 2010-03-11 Marek Safar <marek.safar@gmail.com>
224 * statement.cs, cs-parser.jay: Use correct location for empty
227 2010-03-11 Marek Safar <marek.safar@gmail.com>
229 * cs-parser.jay: Disable Location from expression.
231 * generic.cs: Check constraints for overrides in the parser.
233 2010-03-09 Marek Safar <marek.safar@gmail.com>
235 * cs-parser.jay (GetLocation): Use an expression when available.
237 2010-03-04 Marek Safar <marek.safar@gmail.com>
239 A fix for bug #582579
240 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
242 2010-03-04 Marek Safar <marek.safar@gmail.com>
244 A patch by kornelpal@gmail.com
246 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
247 compiler generated classes sealed by default. Emit and close top
248 level compiler generated classes as well.
250 * support.cs: Use RuntimeHelpers.GetHashCode.
252 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
254 * Makefile: We need to use the internal bootstrapping gmcs for
255 net_2_1_bootstrap too now.
257 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
259 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
261 2010-03-02 Marek Safar <marek.safar@gmail.com>
263 * cs-tokenizer.cs: Missed few locations in previous fix.
265 2010-03-02 Marek Safar <marek.safar@gmail.com>
267 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
268 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
269 Report correct location for operator errors.
271 2010-03-02 Marek Safar <marek.safar@gmail.com>
273 * typemanager.cs (IsDynamicType): Don't check external types when
274 the attribute is not external.
276 2010-02-24 Marek Safar <marek.safar@gmail.com>
278 A fix for bug #582579
279 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
282 2010-02-24 Marek Safar <marek.safar@gmail.com>
284 A fix for bug #581804
285 * ecore.cs: Fixed type comparison.
287 2010-02-08 Miguel de Icaza <miguel@novell.com>
289 * namespace.cs (CompletionGetTypesStartingWith): Do not include
290 private types in the completion results.
292 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
295 2010-02-17 Marek Safar <marek.safar@gmail.com>
297 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
300 2010-02-14 Miguel de Icaza <miguel@novell.com>
302 * eval.cs: Do not do the report printer dance unless the user has
303 set the DescribeTypes feature.
305 2010-02-10 Marek Safar <marek.safar@gmail.com>
307 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
309 2010-02-08 Marek Safar <marek.safar@gmail.com>
311 A fix for bug #577029
312 * anonymous.cs: Fixed TypeBuilder* check.
314 2010-02-06 Miguel de Icaza <miguel@novell.com>
316 * eval.cs (CompileBlock): Also undo if there are problems during
317 semantic analysis, fixes various cases where invalid C# code would
318 be reported, but the internal changes would not be undone.
320 2010-02-03 Miguel de Icaza <miguel@novell.com>
322 * driver.cs: Change the --fatal flag to allow a number to be
323 passed, this ignores the first N fatal errors. Useful to debug
324 errors that do not happen on the first hit.
326 * cs-parser.jay (invocation_expression): accept both the
327 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
328 inside an invocation.
330 * driver.cs: Expose FatalErrors.
332 * eval.cs: Initialize the printer's Fatal property from the
333 Driver's FatalError flag, this allows csharp --fatal to work
336 Add support for calling Describe (typeof (TYPE)) if the expression
339 2010-02-02 Marek Safar <marek.safar@gmail.com>
341 A fix for bug #574991
342 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
345 2010-02-02 Marek Safar <marek.safar@gmail.com>
347 A fix for bug #575986
348 * expression.cs: Don't mutate typeof type definitions.
350 2010-01-28 Marek Safar <marek.safar@gmail.com>
352 * decl.cs: Use only one set of modifiers.
354 2010-01-26 Marek Safar <marek.safar@gmail.com>
356 A fix for bug #573329
357 * eval.cs: Don't disable error reporting completely on silent mode.
359 2010-01-25 Marek Safar <marek.safar@gmail.com>
361 A fix for bug #573312
362 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
363 pointer index of unknown size types greater than 2.
365 2010-01-15 Marek Safar <marek.safar@gmail.com>
367 * *.cs: Use only 1 member kind enum.
369 2010-01-15 Marek Safar <marek.safar@gmail.com>
371 * *.cs: Add event specification.
373 2010-01-14 Marek Safar <marek.safar@gmail.com>
375 * membercache.cs: Extracted from decl.cs.
377 * *.cs: Put more infrastructure in place.
379 2010-01-13 Marek Safar <marek.safar@gmail.com>
381 * *.cs: Add property specification, unused yet.
383 2010-01-13 Marek Safar <marek.safar@gmail.com>
385 * property.cs: Move all property based declarations into a new file.
387 2010-01-13 Marek Safar <marek.safar at gmail.com>
389 * expression.cs (Conditional): Resolve reduced expression.
391 2010-01-13 Marek Safar <marek.safar at gmail.com>
393 * *.cs: Introduced non-generic method specification.
395 2010-01-07 Marek Safar <marek.safar@gmail.com>
397 * method.cs: Move all method based declarations into a new file.
399 2010-01-07 Marek Safar <marek.safar@gmail.com>
401 * *.cs: Extract field specification.
403 2009-12-17 Marek Safar <marek.safar@gmail.com>
405 * field.cs: Extracted from class.cs
407 2009-12-15 Marek Safar <marek.safar@gmail.com>
409 * attribute.cs (GetFixedBuffer): Work on field definition only.
411 2009-12-15 Marek Safar <marek.safar@gmail.com>
413 * *.cs: Clean up NET_4_0 conditional where possible.
415 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
417 support.cs (DynamicType): Assembly property returns the assembly builder.
418 This is required due to how compiler context works in corlib.
420 2009-12-14 Marek Safar <marek.safar@gmail.com>
422 A fix for bug #564376
423 * assign.cs (LocalTemporary): Removed no longer needed special
426 2009-12-11 Marek Safar <marek.safar@gmail.com>
428 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
429 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
430 enum for easier debugging.
432 2009-12-10 Marek Safar <marek.safar@gmail.com>
434 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
437 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
440 2009-12-10 Marek Safar <marek.safar@gmail.com>
442 * cs-parser.jay, statement.cs: Handle parser error in code
445 2009-12-10 Marek Safar <marek.safar@gmail.com>
447 * ecore.cs: Ignore base imported methods when they are already
450 * eval.cs: Handle non-existent keys.
452 * report.cs, driver.cs: Make fatal work with console printer only.
454 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
456 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
458 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
460 * typemanager.cs: Add MakeGenericMethod that checks if the method
461 is really the generic method definition.
463 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
464 to inflate generic methods.
466 2009-12-08 Marek Safar <marek.safar@gmail.com>
468 A fix for bug #561149
469 * anonymous.cs: Use actual type parameters when checking for generic
472 2009-12-08 Marek Safar <marek.safar@gmail.com>
474 A fix for bug #561369
475 * expression.cs (DoNumericPromotion): Fixed typo.
477 2009-12-08 Marek Safar <marek.safar@gmail.com>
479 *.cs: Moving to generics world.
481 cs-parser.jay: Removed current_array_type.
483 2009-12-07 Marek Safar <marek.safar@gmail.com>
485 *.cs: Moving to generics world.
487 2009-12-04 Marek Safar <marek.safar@gmail.com>
489 *.cs: Moving to generics world (day 2).
491 2009-12-03 Marek Safar <marek.safar@gmail.com>
493 *.cs: Moving to generics world.
495 2009-12-02 Marek Safar <marek.safar@gmail.com>
497 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
498 Encode dynamic type attribute for elements where attributes cannot
501 2009-12-01 Marek Safar <marek.safar@gmail.com>
503 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
506 2009-12-01 Marek Safar <marek.safar@gmail.com>
508 A fix for bug #360455
509 * class.cs: Never report a unused warning for generic events to
510 workaround wrong expression type.
512 2009-11-30 Marek Safar <marek.safar@gmail.com>
514 A fix for bug #558305
515 * decl.cs, class.cs: Check partial method definitions using correct
518 2009-11-30 Marek Safar <marek.safar@gmail.com>
520 * argument.cs: Don't cache rarely used dynamic flag.
522 2009-11-27 Marek Safar <marek.safar@gmail.com>
524 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
526 2009-11-27 Marek Safar <marek.safar@gmail.com>
528 * ecore.cs (SimpleName): Removed no longer needed in_transit as
529 Resolve is now non-reentrant (saves ~0.6MB for corlib).
531 2009-11-26 Marek Safar <marek.safar@gmail.com>
533 A fix for bug #545081
534 * decl.cs: Check private nested types of nested types recursively.
536 2009-11-26 Marek Safar <marek.safar@gmail.com>
538 A fix for bug #558305
539 * location.cs: Ignore self referencing #line directive
541 2009-11-26 Marek Safar <marek.safar@gmail.com>
543 A fix for bug #558292
544 * class.cs: Allow single unsafe fixed buffer fields.
546 2009-11-26 Marek Safar <marek.safar@gmail.com>
548 * expression: Optimize few more zero-based operations.
550 2009-11-26 Marek Safar <marek.safar@gmail.com>
552 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
553 avoids boxing of literal values.
555 2009-11-26 Marek Safar <marek.safar@gmail.com>
557 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
558 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
559 codegen.cs: LocatedToken redesing to avoid excessive allocation and
560 boxing (saves ~7MB for corlib). Also fixes presise token location.
562 2009-11-25 Marek Safar <marek.safar@gmail.com>
564 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
567 2009-11-24 Marek Safar <marek.safar@gmail.com>
569 * expression.cs: Lower static array initializer barrier.
571 * support.cs, driver.cs: Share reader buffer.
573 2009-11-23 Marek Safar <marek.safar@gmail.com>
575 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
577 2009-11-23 Marek Safar <marek.safar@gmail.com>
579 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
580 cleanup some obsolete code.
582 2009-11-20 Marek Safar <marek.safar@gmail.com>
584 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
587 2009-11-20 Marek Safar <marek.safar@gmail.com>
589 * *.cs: Resolved expressions are never resolved again, this helps to
590 uncover some not easy to find bugs and improve the performance.
592 2009-11-19 Marek Safar <marek.safar@gmail.com>
594 * *.cs: Made constant expressions fully compatible with any other
597 2009-11-19 Marek Safar <marek.safar@gmail.com>
599 * *.cs: DoResolve is a worker method and has to be protected.
601 2009-11-18 Marek Safar <marek.safar@gmail.com>
603 * *.cs: More context specific handling.
605 2009-11-17 Marek Safar <marek.safar@gmail.com>
607 * *.cs: More context specific handling.
609 2009-11-16 Marek Safar <marek.safar@gmail.com>
611 * dynamic.cs, class.cs: Removed few fixed user types conversions.
613 * symbolwriter.cs: Uses public ILOffset.
615 2009-11-13 Marek Safar <marek.safar@gmail.com>
617 A fix for bug #553650
618 * generic.cs: Another missing TypeToCoreType, still too many to fix.
620 2009-11-13 Marek Safar <marek.safar@gmail.com>
622 A fix for bug #555170
624 * class.cs, delegate.cs, enum.cs: Constants have to be available
625 for parameters resolve.
627 2009-11-12 Marek Safar <marek.safar@gmail.com>
629 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
632 2009-11-12 Marek Safar <marek.safar@gmail.com>
634 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
635 with a statically known candidate set.
637 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
639 * generic.cs: Made type inflation for generic constraint checks
640 recursive. This fixes BGO #553655.
642 2009-11-11 Marek Safar <marek.safar@gmail.com>
644 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
647 2009-11-10 Marek Safar <marek.safar@gmail.com>
649 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
650 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
651 attribute.cs: Add some dynamic error checking.
653 2009-11-07 Marek Safar <marek.safar@gmail.com>
655 A fix for bug #553465
657 * expression.cs: Fixed mixed version of expression tree anonymous
660 2009-11-06 Marek Safar <marek.safar@gmail.com>
662 A fix for bug #553031
664 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
665 expression tree version of anonymous type with members declaration.
667 2009-11-05 Marek Safar <marek.safar@gmail.com>
669 * parameter.cs: Handle nullable parameter default expression.
671 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
672 class.cs, attribute.cs: Check for wrong dynamic arguments.
674 2009-11-05 Marek Safar <marek.safar@gmail.com>
676 * statement.cs: Dynamic statements.
678 2009-11-04 Marek Safar <marek.safar@gmail.com>
680 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
681 Compound assignments over dynamic type.
683 2009-11-03 Marek Safar <marek.safar@gmail.com>
685 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
686 constructor arguments.
688 2009-10-30 Marek Safar <marek.safar@gmail.com>
690 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
691 codegen.cs: Unary mutator on dynamic member access expression.
693 2009-10-29 Marek Safar <marek.safar@gmail.com>
695 A fix for bug #550580
696 * convert.cs: Don't eliminate explicit precission casts.
698 2009-10-28 Marek Safar <marek.safar@gmail.com>
700 A fix for bug #550404
702 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
703 expression.cs, statement.cs, ecore.cs: Quote any nested expression
706 2009-10-27 Marek Safar <marek.safar@gmail.com>
708 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
711 * class.cs: Allow nullable binary user operators.
713 2009-10-26 Marek Safar <marek.safar@gmail.com>
715 * expression.cs: Move binary expression optimization at the end of
718 2009-10-23 Marek Safar <marek.safar@gmail.com>
720 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
721 Separate NullConstant from NullLiteral.
723 2009-10-23 Marek Safar <marek.safar@gmail.com>
725 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
726 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
727 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
728 ModuleContainer. Add common unclosed member check routine.
730 2009-10-22 Marek Safar <marek.safar@gmail.com>
732 * argument.cs: Use literal flag for real literals only.
734 * dynamic.cs: Use correct return type for custom delegates.
736 2009-10-22 Marek Safar <marek.safar@gmail.com>
738 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
741 2009-10-22 Marek Safar <marek.safar@gmail.com>
743 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
745 2009-10-21 Marek Safar <marek.safar@gmail.com>
747 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
750 2009-10-21 Marek Safar <marek.safar@gmail.com>
752 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
755 2009-10-20 Marek Safar <marek.safar@gmail.com>
757 * argument.cs, dynamic.cs, expression.cs: Latest API update.
759 2009-10-19 Marek Safar <marek.safar@gmail.com>
761 * typemanager.cs, expression.cs: Dynamic array initializer.
763 2009-10-16 Marek Safar <marek.safar@gmail.com>
765 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
768 2009-10-16 Marek Safar <marek.safar@gmail.com>
770 A fix for bug #493523, #507067
771 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
772 standard nullable conversion using underlying standard conversion
773 and not full conversion.
775 2009-10-15 Marek Safar <marek.safar@gmail.com>
777 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
778 type in VerifyArgumentsCompat.
780 2009-10-15 Marek Safar <marek.safar@gmail.com>
782 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
783 Reject variable used with type arguments.
785 2009-10-14 Marek Safar <marek.safar@gmail.com>
787 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
788 Implement dynamic expressions assignment.
790 2009-10-14 Marek Safar <marek.safar@gmail.com>
792 * expression.cs: Build underlying expression when resolving unary
795 2009-10-14 Marek Safar <marek.safar@gmail.com>
797 * expression.cs: Emit enum array initializer using binary blob.
799 2009-10-08 Marek Safar <marek.safar@gmail.com>
801 * typemanager.cs, constant.cs: Optimize decimal constants which fit
804 2009-10-07 Marek Safar <marek.safar@gmail.com>
806 * typemanager.cs: Reset object_type.
808 * assign: Made SimpleAssign public.
810 2009-10-06 Marek Safar <marek.safar@gmail.com>
812 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
813 invocation assembly to IsThisOrFriendAssembly.
815 2009-10-05 Marek Safar <marek.safar@gmail.com>
817 * expression.cs: Equality comparison of generic parameter with
820 2009-10-05 Marek Safar <marek.safar@gmail.com>
822 A fix for bug #543570
823 * generic.cs: Import predefined constraints correctly.
825 2009-10-02 Marek Safar <marek.safar@gmail.com>
827 * ecore.cs: Don't crash on overloads with optional paremeters where
828 arguments count overflows.
830 * parameter.cs: Import optional parameter constants using optional
833 2009-10-01 Marek Safar <marek.safar@gmail.com>
835 * Makefile: Default is gmcs compiler.
837 2009-10-01 Marek Safar <marek.safar@gmail.com>
839 * cs-parser.jay: Fixed few NRE.
841 2009-10-01 Marek Safar <marek.safar@gmail.com>
843 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
845 2009-09-30 Marek Safar <marek.safar@gmail.com>
847 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
848 ShimExpression, ImplicitCast.
850 2009-09-30 Marek Safar <marek.safar@gmail.com>
852 A fix for bug #542959
853 * delegate.cs: Emit correct delegate instance variable when there
854 are static and non-static overloads.
856 2009-09-29 Marek Safar <marek.safar@gmail.com>
858 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
859 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
861 2009-09-28 Marek Safar <marek.safar@gmail.com>
863 A fix for bug #542487
864 * ecore.cs: Resolve extension methods hidden by properties.
866 2009-09-25 Marek Safar <marek.safar@gmail.com>
868 * expression.cs, ecore.cs: More dynamic binary expressions.
870 2009-09-22 Marek Safar <marek.safar@gmail.com>
872 * nullable.cs, expression.cs: Fixed null lifted conversion for
873 bitwise enum operations.
875 2009-09-22 Marek Safar <marek.safar@gmail.com>
877 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
878 values in checked context.
880 2009-09-22 Marek Safar <marek.safar@gmail.com>
882 * expression.cs, ecore.cs: Fixed array index constant conversion.
884 2009-09-20 Miguel de Icaza <miguel@novell.com>
886 * expression.cs: Do not crash when MemberLookup returns something
887 that is not a MemberExpr here. Report error 582 instead.
891 2009-09-18 Marek Safar <marek.safar@gmail.com>
893 * decl.cs, class.cs: Check protected property accessors.
895 2009-09-18 Marek Safar <marek.safar@gmail.com>
897 * dynamic.cs, assign.cs: Dynamic compound assignment.
899 2009-09-17 Marek Safar <marek.safar@gmail.com>
901 * expression.cs: Fixed compound assignment explicit conversion.
903 2009-09-17 Marek Safar <marek.safar@gmail.com>
905 * expression.cs, ecore.cs: Cannot infer variables from method group.
907 2009-09-16 Marek Safar <marek.safar@gmail.com>
909 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
910 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
911 codegen.cs: Dynamic binary operations scaffolding.
913 2009-09-15 Marek Safar <marek.safar@gmail.com>
915 * expression.cs: Fixes nullable promotion for enum type variables.
917 2009-09-11 Marek Safar <marek.safar@gmail.com>
919 * driver.cs, dynamic.cs: Reset more static variables.
921 2009-09-11 Marek Safar <marek.safar@gmail.com>
923 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
924 driver.cs: Introduced Expression::MakeExpression.
926 2009-09-11 Marek Safar <marek.safar@gmail.com>
928 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
930 2009-09-09 Marek Safar <marek.safar@gmail.com>
932 * eval.cs, report.cs: Use Console.Out for all eval error or warning
935 2009-09-09 Marek Safar <marek.safar@gmail.com>
937 A fix for bug #518707
938 * expression.cs (Is): Optimize only generic parameter type
939 expression probing value type generic parameter.
941 2009-09-09 Marek Safar <marek.safar@gmail.com>
943 A fix for bug #532571
944 * ecore.cs: Check for simple name type arguments used with
947 2009-09-08 Marek Safar <marek.safar@gmail.com>
949 A fix for bug #497421
950 * generic.cs (CheckConstraint): Don't use buildin types to check for
951 parameterless constructor.
953 2009-09-08 Marek Safar <marek.safar@gmail.com>
955 A fix for bug #537402
956 * generic.cs (CheckConstraint): Correctly inflate generic type
957 arguments when checking generic method.
959 2009-09-08 Marek Safar <marek.safar@gmail.com>
961 A fix for bug #536463
962 * decl.cs (AddToContainer): Don't report collision between explicit
963 and parameterless non-explicit members.
965 2009-09-08 Marek Safar <marek.safar@gmail.com>
967 * eval.cs: Reset more static stuff.
969 2009-09-07 Marek Safar <marek.safar@gmail.com>
971 A fix for bug #324625
972 * expression.cs, ecore.cs: Create nested generic type expression
973 using declaring and not current type.
975 2009-09-07 Marek Safar <marek.safar@gmail.com>
977 * *.cs: Changed Report class to accept various output printers and
978 be an instance class. An expression resolver can now use different
979 message reporter for each call and Report.Error can safely throw
980 an exception. Part of ongoing work to turn mcs into proper library.
982 2009-09-04 Marek Safar <marek.safar@gmail.com>
984 * statement.cs, ecore.cs: Removed error reporting from emit code.
986 2009-09-04 Marek Safar <marek.safar@gmail.com>
988 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
990 2009-09-03 Marek Safar <marek.safar@gmail.com>
992 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
993 parser checks out of constructors.
995 2009-09-02 Marek Safar <marek.safar@gmail.com>
997 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
999 2009-09-02 Marek Safar <marek.safar@gmail.com>
1001 A fix for bug #535448
1002 * anonymous.cs, class.cs: Copy return label between all contexts.
1004 2009-09-02 Marek Safar <marek.safar@gmail.com>
1006 A fix for bug #535395
1007 * namespace.cs: Resolve context can be null.
1009 2009-08-25 Marek Safar <marek.safar@gmail.com>
1011 A fix for bug #533912
1012 * generic.cs: Use correct context for constraints resolving.
1014 2009-08-25 Marek Safar <marek.safar@gmail.com>
1016 A fix for bug #532630
1017 * driver.cs: Trim conditional symbols.
1019 2009-08-25 Marek Safar <marek.safar@gmail.com>
1021 * context.cs: New file.
1023 * *.exe.sources, *.csproj: Updated.
1025 2009-08-25 Marek Safar <marek.safar@gmail.com>
1027 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1028 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1029 IMembercontext, some small cleanups.
1031 2009-08-24 Marek Safar <marek.safar@gmail.com>
1033 * *.cs: Split ResolveContext and EmitContext.
1035 2009-08-24 Marek Safar <marek.safar@gmail.com>
1037 * *.cs: Only ResolveContext implements IMemberContext.
1039 2009-08-21 Marek Safar <marek.safar@gmail.com>
1041 * *.cs: Renamed IResolveContext to IMemberContext.
1043 2009-08-21 Marek Safar <marek.safar@gmail.com>
1045 * *.cs: Detached ResolveContext from EmitContext.
1047 2009-08-21 Marek Safar <marek.safar@gmail.com>
1049 * codegen.cs: Moved flow-analysis to BlockContext.
1051 2009-08-21 Marek Safar <marek.safar@gmail.com>
1053 * *.cs: Detached BlockContext from EmitContext.
1055 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1057 * statement.cs: avoid nullref when the return value of GetEnumerator()
1058 does not contain any MoveNext() method.
1060 2009-08-19 Marek Safar <marek.safar@gmail.com>
1062 * *.cs: Removed IResolveContext::GenericDeclContainer.
1064 2009-08-19 Marek Safar <marek.safar@gmail.com>
1066 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1068 2009-08-19 Marek Safar <marek.safar@gmail.com>
1070 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1071 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1073 2009-08-18 Marek Safar <marek.safar@gmail.com>
1075 * *.cs: Removed boolean fields from EmitContext.
1077 2009-08-18 Marek Safar <marek.safar@gmail.com>
1079 * *.cs: Add IResolveContext::IsStatic.
1081 2009-08-18 Marek Safar <marek.safar@gmail.com>
1083 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1085 2009-08-17 Marek Safar <marek.safar@gmail.com>
1087 * *.cs: Removed DeclContainer from EmitContext.
1089 2009-08-17 Marek Safar <marek.safar@gmail.com>
1091 * *.cs: Add IResolveContext::CurrentTypeParameters.
1093 2009-08-14 Marek Safar <marek.safar@gmail.com>
1095 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1097 2009-08-14 Marek Safar <marek.safar@gmail.com>
1099 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1100 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1102 2009-08-13 Marek Safar <marek.safar@gmail.com>
1104 * decl.cs: Look in PartialContainer for parent type parameters.
1106 2009-08-13 Marek Safar <marek.safar@gmail.com>
1108 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1109 codegen.cs: Add IResolveContext::LookupTypeParameter.
1111 2009-08-13 Marek Safar <marek.safar@gmail.com>
1113 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1114 Moved resolved logic from Emit to Resolve.
1116 2009-08-13 Marek Safar <marek.safar@gmail.com>
1118 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1119 codegen.cs: Reworked atttributes handling of ResolveContext.
1121 2009-08-12 Marek Safar <marek.safar@gmail.com>
1123 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1124 LookupNamespaceOrType to ResolveContext.
1126 2009-08-12 Marek Safar <marek.safar@gmail.com>
1128 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1129 class.cs: Removed unused parameters and methods.
1131 2009-08-11 Marek Safar <marek.safar@gmail.com>
1133 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1134 codegen.cs: Finding the best common type of a set of expressions for
1137 2009-08-07 Marek Safar <marek.safar@gmail.com>
1139 * dynamic.cs, expression.cs: More dynamic conversions.
1141 2009-08-06 Miguel de Icaza <miguel@novell.com>
1143 * generic.cs: This loop was incorrect, it was increment ii, but
1144 checking for `i'. This was a change introduced to fix #327497,
1147 * class.cs: Catch another case for cs0533 error, fixes #324782.
1149 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1151 * typemanager.cs (GetGenericArguments): SRE returns null for
1152 generic methods on type builder instances if they are not generic
1153 themselves. For example, for Foo<int>::Bar() it returns null, but
1154 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1156 2009-08-05 Marek Safar <marek.safar@gmail.com>
1158 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1159 delegate.cs: Work on dynamic binding.
1161 2009-08-04 Marek Safar <marek.safar@gmail.com>
1163 A second fix for bug #525342
1164 * class.cs: Attach partial method attributes to method
1167 2009-08-03 Marek Safar <marek.safar@gmail.com>
1169 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1172 * rootcontext.cs: Default to langversion v4.
1174 2009-08-03 Marek Safar <marek.safar@gmail.com>
1176 * pending.cs: Check return type before member info is set.
1178 2009-08-03 Marek Safar <marek.safar@gmail.com>
1180 * anonymous.cs: Fully initialize generic hoisted field expression.
1182 2009-08-02 Miguel de Icaza <miguel@novell.com>
1184 * cs-parser.jay: Flag variables declared on the interactive shell
1185 as used to prevent the 168 warning about local variable not being
1188 2009-07-31 Marek Safar <marek.safar@gmail.com>
1190 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1191 attribute.cs: Emit dynamic export attribute.
1193 2009-07-30 Marek Safar <marek.safar@gmail.com>
1195 * expression.cs: More verifier work.
1197 2009-07-29 Marek Safar <marek.safar@gmail.com>
1199 * nullable.cs: Fixed SRE crash during corlib compilation.
1201 2009-07-29 Marek Safar <marek.safar@gmail.com>
1203 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1204 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1205 More TypeManager.TypeToCoreType needed.
1207 2009-07-29 Marek Safar <marek.safar@gmail.com>
1209 * anonymous.cs: Update after recent SRE fixes.
1211 2009-07-28 Marek Safar <marek.safar@gmail.com>
1213 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1214 version of GetFieldHandle for fields of generic types.
1216 2009-07-27 Marek Safar <marek.safar@gmail.com>
1218 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1219 ecore.cs: Add TypeManager.IsDynamicType,
1220 PredefinedAttributes.Dynamic.
1222 2009-07-27 Marek Safar <marek.safar@gmail.com>
1224 A fix for bug #415375
1225 * expression.cs: Fixed object and reference type parameter
1228 2009-07-27 Marek Safar <marek.safar@gmail.com>
1230 A fix for bug #525342
1231 * class.cs: Attach partial method attributes to method
1234 2009-07-24 Marek Safar <marek.safar@gmail.com>
1236 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1239 2009-07-24 Marek Safar <marek.safar@gmail.com>
1241 * anonymous.cs (MutateField): Add imported types handling.
1243 2009-07-23 Marek Safar <marek.safar@gmail.com>
1245 * expression.cs, delegate.cs: Moved arguments resolve into their
1246 counterparts expressions. Removed argument resolve from
1247 CollectionElementInitializer.
1249 2009-07-23 Marek Safar <marek.safar@gmail.com>
1251 A fix for bug #523683
1252 * convert.cs, delegate.cs: Use common overload mechanism for method
1253 group conversion check.
1255 2009-07-22 Marek Safar <marek.safar@gmail.com>
1257 A fix for bug #523899
1258 * generics.cs: Exact type inference with other bound types.
1260 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1262 Don't complain when the same type is implemented by the output
1263 assembly as well as multiple referenced assemblies
1264 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1265 'must_be_unique' flag.
1266 (GlobalRootNamespace): Update to changes.
1267 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1268 already have a type in hand.
1270 2009-07-22 Marek Safar <marek.safar@gmail.com>
1272 * expression.cs: More verifier instrumentation.
1274 * statement.cs: Do proper throw expression conversion.
1276 2009-07-22 Marek Safar <marek.safar@gmail.com>
1278 A fix for bug #522789
1279 * expression.cs: Mutate invocation return type.
1281 2009-07-16 Marek Safar <marek.safar@gmail.com>
1283 * anonymous.cs: Split assignable and readonly generated variable
1286 2009-07-16 Marek Safar <marek.safar@gmail.com>
1288 A fix for bug #521671
1289 * statement.cs: Fixed crash when checking missing type.
1291 2009-07-16 Marek Safar <marek.safar@gmail.com>
1293 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1294 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1295 class.cs, driver.cs: Work on dynamic binding.
1297 * dynamic.cs: New file.
1299 * *.sources, *.proj: Updated.
1301 2009-07-15 Marek Safar <marek.safar@gmail.com>
1303 * expression.cs (Conditional): Avoid double Resolve.
1305 2009-07-13 Marcus Griep <marcus@griep.us>
1307 * ecore.cs: Fix obscure bug with resolving members of interfaces
1308 that hide parent interface members. Fixes bug #444388 and corrects
1311 2009-07-13 Marek Safar <marek.safar@gmail.com>
1313 * expression.cs (LocalVariableReference): Bounce resolve.
1315 2009-07-10 Marek Safar <marek.safar@gmail.com>
1317 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1318 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1321 * support.cs: New dynamic type wrapper.
1323 2009-07-08 Marek Safar <marek.safar@gmail.com>
1325 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1326 typed local variable.
1328 2009-07-06 Marek Safar <marek.safar@gmail.com>
1330 A fix for bug #519005
1331 * anonymous.cs: Use null_type as no return type placeholder.
1333 2009-07-02 Marek Safar <marek.safar@gmail.com>
1335 * generic.cs: Handle type inference of identical type parameters
1336 with different bounds.
1338 2009-07-01 Marek Safar <marek.safar@gmail.com>
1340 * expression.cs, class.cs: Events variance.
1342 * cs-parser.jay: Interface events error messages.
1344 2009-07-01 Marek Safar <marek.safar@gmail.com>
1346 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1348 2009-06-29 Marek Safar <marek.safar@gmail.com>
1350 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1351 parameter expression can be value-type New.
1353 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1355 2009-06-26 Marek Safar <marek.safar@gmail.com>
1357 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1358 Implemented C# 4.0 named arguments.
1360 2009-06-24 Marek Safar <marek.safar@gmail.com>
1362 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1363 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1364 parameter modifier. Also fixes bug #515497.
1366 2009-06-24 Marek Safar <marek.safar@gmail.com>
1368 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1369 arguments expression to be implemented.
1371 *.sources: Add argument.cs
1373 2009-06-23 Marek Safar <marek.safar@gmail.com>
1375 * parameter.cs: Moved GetParameterIndexByName to base class.
1377 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1378 unused AType. Use argument's version of GetExpressionTree.
1380 2009-06-22 Marek Safar <marek.safar@gmail.com>
1382 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1385 2009-06-17 Marek Safar <marek.safar@gmail.com>
1387 A fix for bug #514096
1388 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1390 2009-06-17 Marek Safar <marek.safar@gmail.com>
1392 * expression.cs: The first multi-dimensional array nested array
1393 initializers was not checked.
1395 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1397 2009-06-17 Marek Safar <marek.safar@gmail.com>
1399 A fix for bug #513400
1400 * nullable.cs (EmitEquality): Operands emit could be simplified for
1401 built-in types when we now emit user operators differently.
1403 2009-06-16 Marek Safar <marek.safar@gmail.com>
1405 * ecore.cs: Report inaccessible delegate methods correctly.
1407 2009-06-16 Marek Safar <marek.safar@gmail.com>
1409 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1410 cs-parser.jay: Implemented C# 4.0 optional parameters.
1412 2009-06-16 Marek Safar <marek.safar@gmail.com>
1414 * driver.cs: Removed broken DefineManifestResource.
1416 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1418 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1419 Use $(BOOTSTRAP_PROFILE) instead.
1421 2009-06-12 Jb Evain <jbevain@novell.com>
1423 * rootcontext.cs: add a Platform field.
1424 * driver.cs: handle /platform.
1425 * codegen.cs: pass the proper flags according to
1426 the platform when saving the assembly.
1428 2009-06-11 Marek Safar <marek.safar@gmail.com>
1430 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1431 Add optional parameters grammar.
1433 2009-06-10 Marek Safar <marek.safar@gmail.com>
1435 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1436 driver.cs: Split lang version and metadata version.
1438 2009-06-10 Marek Safar <marek.safar@gmail.com>
1440 * decl.cs: Better overload ctor collision error message.
1442 2009-06-05 Jb Evain <jbevain@novell.com>
1444 * driver.cs (EmbededResource): avoid using an internal method
1445 in gmcs to embed manifest resources.
1447 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1449 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1450 the compiler from older mono versions (like moon's bots)
1452 2009-06-04 Marek Safar <marek.safar@gmail.com>
1454 * namespace.cs (LookupTypeReflection): Ignore collisions between
1457 2009-06-04 Marek Safar <marek.safar@gmail.com>
1459 * codegen.cs: Enabled generic type forwarders.
1461 2009-06-04 Marek Safar <marek.safar@gmail.com>
1463 * dmcs.*: Add another version of SRE compiler.
1465 2009-06-03 Marek Safar <marek.safar@gmail.com>
1467 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1468 generic-mcs.cs: Fixed variant type conversions.
1470 2009-06-02 Marek Safar <marek.safar@gmail.com>
1472 A fix for bug #507863
1473 * codegen.cs: Fixes a crash on invalid string value attribute.
1475 2009-06-01 Marek Safar <marek.safar@gmail.com>
1477 A fix for bug #508334
1478 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1479 cs-parser.jay: Fully import __arglist modifier.
1481 2009-05-29 Marek Safar <marek.safar@gmail.com>
1483 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1484 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1485 actually work with closed generic types.
1487 2009-05-27 Alan McGovern <amcgovern@novell.com>
1489 * class.cs, decl.cs, delegate.cs, parameter.cs:
1490 Fix the build by replacing the use of 'var' with the actual type.
1492 2009-05-27 Marek Safar <marek.safar@gmail.com>
1494 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1495 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1498 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1501 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1502 Marek Safar <marek.safar@gmail.com>
1504 A fix for bug #377509
1505 * parameter.cs: Use predefined and not empty name for implicit
1508 2009-05-21 Marek Safar <marek.safar@gmail.com>
1510 * class.cs: Don't report wrong warnings for event fields.
1512 2009-05-21 Marek Safar <marek.safar@gmail.com>
1514 A fix for bug #504667
1515 * class.cs: Check for static class using parent container instead of
1518 2009-05-08 Marek Safar <marek.safar@gmail.com>
1520 A fix for bug #496922
1521 * expression.cs: Always use temporary variable when using object
1524 2009-04-28 Marek Safar <marek.safar@gmail.com>
1526 A fix for bug #495112
1527 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1530 2009-04-27 Miguel de Icaza <miguel@novell.com>
1532 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1534 2009-04-24 Miguel de Icaza <miguel@novell.com>
1536 * complete.cs: No idea how gonzalo got a null in the list, but
1539 2009-04-24 Miguel de Icaza <miguel@novell.com>
1541 * complete.cs (CompletionElementInitializer): New completion class
1542 to support completing inside a C# 3 element initializer, so this
1543 allows completion for Silverlight situations where it is very
1546 new TextBlock () { Fo<TAB>
1548 (CompletionSimpleName): Expose the prefix that was
1549 passed to the simple name.
1551 * cs-parser.jay (object_or_collection_initializer): Add support
1552 for element_initializers.
1554 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1555 special case completion expressions as this method aggressively
1556 collects data before it operates, and errors were being thrown
1557 earlier than we were able to complete.
1559 2009-04-23 Miguel de Icaza <miguel@novell.com>
1561 * eval.cs: Make getcompletions silent and enable debugging output
1562 if the -v option is passed.
1564 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1565 Consider looking up the namespace that matches the prefix being
1568 This is part of the support for allowing completions like:
1569 `System.Co<TAB>' to complete to System.Console.
1571 * complete.cs (CompletionSimpleName.AppendResults): Make this
1574 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1576 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1577 COMPLETE_COMPLETION as internal.
1579 2009-04-17 Miguel de Icaza <miguel@novell.com>
1581 * complete.cs: Include namespace resolution in simple names as
1582 well as global types and types in the using scope in the
1585 * namespace.cs: Supporting infrastrcture to provide completions
1586 based on the current using scope.
1588 * eval.cs: Introduce an entry point that allows for initialization
1589 to return a list of the files passed on the command line.
1591 2009-04-14 Marek Safar <marek.safar@gmail.com>
1593 A fix for bug #494243
1594 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1596 2009-04-13 Marek Safar <marek.safar@gmail.com>
1598 A fix for bug #493887
1599 * statement.cs: Don't skip string multi-section with default or
1600 null label when populating string hashtable.
1602 2009-04-06 Marek Safar <marek.safar@gmail.com>
1604 A fix for bug #492329
1605 * expression.cs (New): Load variable when assigning type parameter
1608 2009-04-06 Marek Safar <marek.safar@gmail.com>
1610 A fix for bug #488960
1611 * decl.cs: Compare MVAR types using non-null values.
1613 2009-03-27 Marek Safar <marek.safar@gmail.com>
1615 * typemanager.cs, expression.cs: Removed unused nullable checks.
1617 2009-03-27 Marek Safar <marek.safar@gmail.com>
1619 * *.cs: Removed some gmcs conditionals.
1621 2009-03-26 Marek Safar <marek.safar@gmail.com>
1623 * generic.cs, support.cs: Moved generics stuff out of support.cs
1625 2009-03-24 Marek Safar <marek.safar@gmail.com>
1627 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1630 2009-03-23 Marek Safar <marek.safar@gmail.com>
1632 * attribute.cs: Consider all members for error reporting when
1633 checking named arguments.
1635 2009-03-23 Marek Safar <marek.safar@gmail.com>
1637 A fix for bug #487625
1638 * namespace.cs: Use a warning for all predefined type conflicts.
1640 2009-03-23 Marek Safar <marek.safar@gmail.com>
1642 A fix for bug #485706
1643 * statement.cs: Explicitly type catch type argument to pass verifier
1646 2009-03-22 Miguel de Icaza <miguel@novell.com>
1648 Initial support to provide code completion facilities to consumers
1649 of the evaluator API.
1651 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1652 support the completion engine. When we reach the end of the
1653 input stream instead of returning EOF, when this flag is true the
1654 tokenizer instead produces:
1656 One GENERATE_COMPLETION token: this token then must be
1657 handled in the grammar at every point where the user
1658 would likely request a completion.
1660 As many COMPLETE_COMPLETION tokens as necessary. These
1661 tokens are generated to assist the parser in unwinding and
1662 producing a valid parse tree.
1664 The parser rules do not have to be perfect, the parser needs to be
1665 augmented with judicious use of GENERATE_COMPLETION tokens to
1666 improve the areas where we can provide completion and the parser
1667 needs to add support for COMPLETE_COMPLETION tokens in productions
1670 It is common to not have enough support for COMPLETE_COMPLETION
1671 under certain rules and that even if we generated the
1672 GENERATE_COMPLETION token that the resulting tree will be invalid
1673 due to the missing rules that support COMPLETE_COMPLETION.
1675 The final EOF token is produced by having the parser notify the
1676 tokenizer when it reaches the root production that the next token
1679 * support.cs (CompletionResult): New Exception. This exception
1680 is thrown to return the completion results when one of the special
1681 completion expressions is reached.
1683 This exception is thrown by the completing ExpressionStatements
1684 classes that live in complete.cs
1686 * complete.cs (CompletingExpression): a new base class for
1687 completing expressions. This derives from the
1688 ExpressionStatement class and not from Expression as it allows
1689 completion to happen not only where expressions are expected in
1690 the grammar, but also where statements are expected.
1692 (CompletionSimpleName): A new class used to provide completions
1693 for SimpleNames. This currently only resolves to local
1694 variables from the evaluator context (GetVars call).
1696 (CompletionMemberAccess): Implements support for completing member
1699 * cs-parser.jay: Add support for completion in a few places.
1701 * eval.cs (GetCompletions): New public API for the evaluator that
1702 returns a list of possible completions given the input. The
1703 return value is an array of completions
1705 * anonymous.cs (Compatible): If the exception thrown from the
1706 resolved expression is a CompletionResult exception let that one
1707 through instead of printing a diagnostic error in the try/catch.
1709 2009-03-22 Miguel de Icaza <miguel@novell.com>
1713 * driver.cs (Main): Use Environment.Exit to quit quickly and
1714 prevent the compiler from doing the usual wait for helper thread
1717 This is to prevent a slowdown that was reported by Gonzalo on
1720 2009-03-19 Marek Safar <marek.safar@gmail.com>
1722 * ecore.cs: Load build-in types directly instead of accessing
1725 2009-03-18 Marek Safar <marek.safar@gmail.com>
1727 * ecore.cs: Always use unbox.any when available.
1729 2009-03-18 Marek Safar <marek.safar@gmail.com>
1731 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1733 2009-03-17 Marek Safar <marek.safar@gmail.com>
1735 * generic.cs: Removed obsolete version of type inference.
1737 2009-03-16 Marek Safar <marek.safar@gmail.com>
1739 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1740 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1741 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1742 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1744 2009-03-11 Marek Safar <marek.safar@gmail.com>
1746 A fix for bug #482996
1747 * anonymous.cs: Make sure we are not infering return type when
1748 checking type compatibility.
1750 2009-03-11 Marek Safar <marek.safar@gmail.com>
1752 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1753 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1754 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1755 attributes in their own structure. Needed when accessing their
1756 properties before they are resolved.
1758 2009-03-09 Marek Safar <marek.safar@gmail.com>
1760 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1761 hashtable (~10x faster).
1763 * driver.cs: Removed wrong Reset.
1765 2009-03-08 Marek Safar <marek.safar@gmail.com>
1767 * class.cs: Use correct common base type for unmanaged delayed
1770 * rootcontext.cs: Wrap unhandled exception.
1772 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1774 Make SeekableStreamReader self-tuning and arbitrarily seekable
1775 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1777 (SeekableStreamReader.Position.set): Use it. Simplify logic
1778 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1779 buffer size when the stream needs to be re-read from the beginning.
1781 2009-03-05 Marek Safar <marek.safar@gmail.com>
1783 A fix for bug #480100
1784 * parameter.cs: A parameter is not hoisted when used directly as ET.
1786 2009-03-04 Marek Safar <marek.safar@gmail.com>
1788 * statement.cs: Fixed an issue when using variable is of interface
1791 2009-03-03 Marek Safar <marek.safar@gmail.com>
1793 A fix for bug #480319
1794 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1796 2009-03-03 Marek Safar <marek.safar@gmail.com>
1798 A fix for bug #480867
1799 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1800 expression to have no valid type.
1802 2009-03-03 Marek Safar <marek.safar@gmail.com>
1804 A fix for bug #481258
1805 * class.cs: Set extension method flag in partial container.
1807 2009-03-03 Marek Safar <marek.safar@gmail.com>
1809 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1811 * attribute.cs: Add sanity check.
1813 2009-02-27 Marek Safar <marek.safar@gmail.com>
1815 * class.cs: Add external constructor error.
1817 2009-02-26 Marek Safar <marek.safar@gmail.com>
1819 A fix for bug #475354
1820 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1821 correctly user defined nullable equality operators.
1823 2009-02-25 Marek Safar <marek.safar@gmail.com>
1825 A fix for bug #479532
1826 * expression.cs: Implement NewInitialize::AddressOf.
1828 2009-02-25 Marek Safar <marek.safar@gmail.com>
1830 A fix for bug #413633
1831 * expression.cs: Iterate all base class-constraint types.
1833 2009-02-24 Marek Safar <marek.safar@gmail.com>
1835 A fix for bug #479209
1836 * literal.cs: Mutate null underlying type.
1838 2009-02-24 Marek Safar <marek.safar@gmail.com>
1840 A fix for bug #476295
1841 * convert.cs: Avoid wrapping implicitly convertible reference type.
1843 2009-02-23 Marek Safar <marek.safar@gmail.com>
1845 * iterators.cs: Create MemberName correctly.
1847 2009-02-23 Marek Safar <marek.safar@gmail.com>
1849 A fix for bug #478655
1850 * literal.cs: Check also underlying null type conversion.
1852 2009-02-21 Marek Safar <marek.safar@gmail.com>
1854 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1856 2009-02-20 Marek Safar <marek.safar@gmail.com>
1858 A fix for bug #477447
1859 * statement.cs: Add reference to correct parent storey when this
1860 is accessible from deep children storey (more than 1 level).
1862 2009-02-19 Marek Safar <marek.safar@gmail.com>
1864 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1865 * class.cs: Define base type members before setting up member cache.
1867 2009-02-18 Marek Safar <marek.safar@gmail.com>
1869 A fix for bug #477378
1870 * nullable.cs, expression.cs, statement.cs: More precise null type
1873 2009-02-18 Marek Safar <marek.safar@gmail.com>
1875 A fix for bug #472805
1876 * typemanager.cs, namespace.cs: Import only visible extension method
1879 2009-02-18 Marek Safar <marek.safar@gmail.com>
1881 A fix for bug #476895
1882 * attribute.cs: Use correct resolve context for attribute type.
1884 2009-02-18 Marek Safar <marek.safar@gmail.com>
1886 A fix for bug #476266
1887 * anonymous.cs: Mutate multi-dimensional arrays.
1889 2009-02-18 Marek Safar <marek.safar@gmail.com>
1891 A fix for bug #476400
1892 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1894 2009-02-18 Marek Safar <marek.safar@gmail.com>
1896 A fix for bug #476811
1897 * generics.cs: Fixed null-literal check.
1899 2009-02-17 Marek Safar <marek.safar@gmail.com>
1901 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1902 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1903 messing with static variables.
1905 2009-02-16 Marek Safar <marek.safar@gmail.com>
1907 A fix for bug #475965
1908 * generics.cs: Check generic parameter type after extracting from
1911 2009-02-16 Marek Safar <marek.safar@gmail.com>
1913 A fix for bug #475823
1914 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1917 2009-02-14 Marek Safar <marek.safar@gmail.com>
1919 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1920 Simplified event field definition using backing field and not
1921 field builder directly.
1923 * expression.cs (EmitLdArg): Optimize fast paths.
1925 2009-02-13 Marek Safar <marek.safar@gmail.com>
1927 A fix for bug #475327
1928 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1930 2009-02-13 Marek Safar <marek.safar@gmail.com>
1932 A fix for bug #475342
1933 * cs-parser.jay: Using 'super' instead of 'base' to call base
1934 constructor crashes compiler.
1936 2009-02-13 Marek Safar <marek.safar@gmail.com>
1938 A fix for bug #475354
1939 * expression.cs (Constantify): Add nullable types.
1941 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1943 2009-02-12 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #475246
1946 * expression.cs: More broken flowanalysis hacking needed.
1948 2009-02-12 Marek Safar <marek.safar@gmail.com>
1950 * attribute.cs: Compare only ref/out array modifiers.
1952 2009-02-11 Marek Safar <marek.safar@gmail.com>
1954 * statement.cs: Use member cache when looking for foreach members.
1956 2009-02-11 Marek Safar <marek.safar@gmail.com>
1958 * expression.cs: Don't expose internal initializer types.
1960 * statement.cs: Check also explicit conversions for goto case.
1962 2009-02-11 Marek Safar <marek.safar@gmail.com>
1964 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1966 2009-02-10 Marek Safar <marek.safar@gmail.com>
1968 * *.cs: Replace null-type with NullLiteral where appropriate.
1970 2009-02-09 Marek Safar <marek.safar@gmail.com>
1972 * expression.cs: Initializer of reference argument use temporary
1973 variable to be verifiable.
1975 * parameter.cs: Share EmitLdArg.
1977 2009-02-09 Marek Safar <marek.safar@gmail.com>
1979 A fix for bug #473559
1980 * class.cs: Fixed: Not reporting error about nested class with the
1983 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1985 Contributed under the MIT/X11 license.
1987 * generic.cs: Added VerifyVariantTypeParameters which performs new
1988 variance verification logic. The old logic, based on the spec, was
1989 wrong because the spec is full of LIES!
1991 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1993 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1996 * ecore.cs: Added calls to the new variance verification logic.
1999 * delegate.cs: Removed calls to the old variance verification logic.
2001 2009-02-06 Marek Safar <marek.safar@gmail.com>
2003 * delegate.cs: Use cached Invoke method directly.
2005 2009-02-06 Marek Safar <marek.safar@gmail.com>
2007 * expression.cs: Emit expression tree for hoisted variable access.
2009 2009-02-04 Marek Safar <marek.safar@gmail.com>
2011 * namespace.cs: Add better extension class check.
2013 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2015 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2017 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2019 This patch adds initial generic variance support to the compiler.
2020 It is contributed under the MIT/X11 license.
2022 * typemanager.cs: Modified ImplementsInterface to check variance.
2023 Added VerifyVariantTypeParameters which checks the specified type to see
2024 if it uses a variant type parameter as a type argument (which is not
2025 allowed). Added IsVariantOf which determins if the first type is a
2026 variant of the second. NOTE: This only supports reference types at
2027 the moment to conform with the current level of VM support. When the
2028 VM supports value types, this will follow step.
2030 * generic.cs: Added the Variance enum. Added a Variance property to
2031 TypeParameter and added variance support to definition phase. Added a
2032 Variance property to TypeParameterName. Also check to make sure that
2033 no variant types appear in generic method parameters.
2035 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2036 keywords if the langversion supports it.
2038 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2039 that variant types are only used in legal positions. Also added
2040 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2043 * decl.cs: Construct TypeParameter with the variance information.
2045 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2046 and ImplicitConversionStandard.
2048 * rootcontext.cs: Added new "Future" language version.
2050 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2051 type parameters are not used as type arguments in interface inheritance.
2052 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2053 parameters are not used as method return types. In MemberBase.
2054 ResolveMemberType, ensure that variant type parameters are not used
2055 as type arguments. Also call VerifyNoVariantTypeParameters on every
2056 set of parameters which are resolved.
2058 * delegate.cs: Modified Delegate.Define to ensure that variant
2059 parameters are not used as type arguments and that a contravariant
2060 parameter is not used as the return type. Also call
2061 VerifyNoVariantTypeParameters on the delegate parameters.
2063 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2064 to specify generic variance.
2066 * driver.cs: Added support for LanguageVersion.Future in the form of
2067 "-langversion:future".
2069 * generic-mcs.cs: Stubbed out new members in generic.cs.
2071 2009-02-03 Marek Safar <marek.safar@gmail.com>
2073 * class.cs, generic.cs: Emit type parameter constraints for nested
2076 2009-02-02 Marek Safar <marek.safar@gmail.com>
2078 A fix for bug #471213
2079 * class.cs: Avoid emitting backing field for abstract event fields.
2081 2009-02-01 Marek Safar <marek.safar@gmail.com>
2083 A fix for bug #359731
2084 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2087 2009-01-30 Marek Safar <marek.safar@gmail.com>
2089 A fix for bug #470767
2090 * statement.cs: Introduced BlockScopeExpression, needed when
2091 expression tree conversion has to emit scope variables.
2093 2009-01-29 Marek Safar <marek.safar@gmail.com>
2095 * class.cs: Remove duplicate CallingConvention.
2097 2009-01-29 Marek Safar <marek.safar@gmail.com>
2099 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2100 when I finally found the right naming convention.
2102 2009-01-29 Marek Safar <marek.safar@gmail.com>
2104 * cs-tokenizer.cs: Put back different open parens optimization.
2106 2009-01-28 Marek Safar <marek.safar@gmail.com>
2108 A fix for bug #470227
2109 * cs-tokenizer.cs: Remove too agressive parser optimization.
2111 2009-01-28 Marek Safar <marek.safar@gmail.com>
2113 A fix for bug #324319
2114 * class.cs: Remove too early base type resolve.
2116 2009-01-27 Marek Safar <marek.safar@gmail.com>
2118 A fix for bug #324319
2119 * ecore.cs: Explicitly type null when assigning to type argument to
2120 make pass verifier check.
2122 2009-01-27 Marek Safar <marek.safar@gmail.com>
2124 * anonymous.cs: Fixed recent regression when initializing captured
2127 2009-01-26 Marek Safar <marek.safar@gmail.com>
2129 A fix for bug #469019
2130 * anonymous.cs: Use all parent type parameters when instantiating
2131 nested generic storey.
2133 2009-01-26 Marek Safar <marek.safar@gmail.com>
2135 * expression.cs: Check for null instance methodgroup expression.
2137 2009-01-26 Marek Safar <marek.safar@gmail.com>
2139 A fix for bug #469244
2140 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2141 instance inside a conditional expression.
2143 2009-01-23 Marek Safar <marek.safar@gmail.com>
2145 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2146 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2147 GetElementType and HasElementType. IsValueType clean up.
2149 2009-01-23 Marek Safar <marek.safar@gmail.com>
2151 * nullable.cs: Use common EmitCall.
2153 * expression.cs: Emit constraint. for virtual calls only.
2155 2009-01-23 Marek Safar <marek.safar@gmail.com>
2157 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2158 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2159 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2162 2009-01-22 Jb Evain <jbevain@novell.com>
2164 * anonymous.cs: make anonymous types' ToString implementation
2165 match what csc outputs.
2167 2009-01-21 Marek Safar <marek.safar@gmail.com>
2169 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2172 2009-01-17 Marek Safar <marek.safar@gmail.com>
2174 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2177 2009-01-16 Marek Safar <marek.safar@gmail.com>
2179 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2182 2009-01-15 Marek Safar <marek.safar@gmail.com>
2184 A fix for bug #466634
2185 * statement.cs: Add reference for nested storey when only this
2188 2009-01-15 Marek Safar <marek.safar@gmail.com>
2190 A fix for bug #466474
2191 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2194 2009-01-15 Marek Safar <marek.safar@gmail.com>
2196 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2197 Fixed nested stories parent referencing process. Also fixes #463985.
2199 2009-01-06 Marek Safar <marek.safar@gmail.com>
2201 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2202 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2203 implementation. Also fixes #463108.
2205 2009-01-05 Marek Safar <marek.safar@gmail.com>
2207 A fix for bug #416109
2208 * decl.cs: Issue correct CLSAttribute warning location.
2210 2009-01-05 Marek Safar <marek.safar@gmail.com>
2212 A fix for bug #456775
2213 * attribute.cs: Use attribute owner scope when resolving attribute
2216 2009-01-05 Marek Safar <marek.safar@gmail.com>
2218 A fix for bug #457257
2219 * decl.cs: Fixed incorrect member declaring type comparison.
2221 2009-01-05 Marek Safar <marek.safar@gmail.com>
2223 A fix for bug #460896
2224 * driver.cs: Handle /RES resources as embeddable.
2226 2009-01-05 Marek Safar <marek.safar@gmail.com>
2228 A fix for bug #462515
2229 * ecore.cs: Report inacessible members upwards.
2231 2009-01-05 Marek Safar <marek.safar@gmail.com>
2233 A fix for bug #463190, #463192
2234 * decl.cs, namespace.cs: Also import internal extension classes.
2236 2009-01-04 Marek Safar <marek.safar@gmail.com>
2238 A fix for bug #463415
2239 * generic.cs: Use right index for RemoveDependentTypes.
2241 2009-01-02 Marek Safar <marek.safar@gmail.com>
2243 A fix for bug #463196
2244 * expression.cs: Fixed enum to null comparison.
2246 2009-01-02 Marek Safar <marek.safar@gmail.com>
2248 A fix for bug #463121
2249 * nullable.cs: Fixed nullable user equality operator comparison.
2251 2009-01-02 Marek Safar <marek.safar@gmail.com>
2253 A fix for bug #462950
2254 * class.cs, decl.cs: Use full explicit name when defining automatic
2255 property backing field.
2257 2009-01-02 Marek Safar <marek.safar@gmail.com>
2259 A fix for bug #462592
2260 * pending.cs: Emit type arguments for generic proxy method.
2262 2008-12-30 Marek Safar <marek.safar@gmail.com>
2264 * expression.cs (As): Mutate all type arguments.
2266 2008-12-29 Marek Safar <marek.safar@gmail.com>
2268 A fix for bug #462622
2269 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2272 2008-12-29 Marek Safar <marek.safar@gmail.com>
2274 A fix for bug #450782
2275 * ecore.cs: Consider more variables of form V.I to be fixed.
2277 2008-12-29 Marek Safar <marek.safar@gmail.com>
2279 A fix for bug #460712
2280 * typemanager.cs: Core types could be imported.
2282 2008-12-28 Marek Safar <marek.safar@gmail.com>
2284 A fix for bugs #460847, #460772, #458049, #457339, #447807
2285 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2286 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2287 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2288 user lambdas used inside query clauses.
2290 2008-12-18 Marek Safar <marek.safar@gmail.com>
2292 A fix for bug #460229
2293 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2295 2008-12-18 Marek Safar <marek.safar@gmail.com>
2297 A fix for bug #459952
2298 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2300 2008-12-18 Marek Safar <marek.safar@gmail.com>
2302 A fix for bug #459630
2303 * convert.cs: Enum to valuetype conversion is not allowed.
2305 2008-12-18 Marek Safar <marek.safar@gmail.com>
2307 A fix for bug #457087
2308 * generic.cs: Don't crash when constraint comes from type
2311 2008-12-16 Marek Safar <marek.safar@gmail.com>
2313 A fix for bug #459221
2314 * anonymous.cs, statement.cs: Delay only captured this
2317 2008-12-12 Marek Safar <marek.safar@gmail.com>
2319 A fix for bug #457489
2320 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2321 and initialization to capture scope initializers correctly.
2323 2008-12-11 Marek Safar <marek.safar@gmail.com>
2325 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2326 ParameterReference refactoring.
2328 2008-12-03 Marek Safar <marek.safar@gmail.com>
2330 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2331 to be imported from any assembly.
2333 2008-12-03 Marek Safar <marek.safar@gmail.com>
2335 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2336 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2337 from anonymous method and lambda expression.
2339 2008-12-01 Marek Safar <marek.safar@gmail.com>
2341 A fix for bug #448560
2342 * expression.cs (As): Box any generic type arguments to be
2345 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2347 Add tripwire for implicit conversion bugs
2348 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2350 (MethodGroupExpr.OverloadResolve): Add sanity check between
2351 IsApplicable and VerifyArgumentsCompat.
2352 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2354 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2356 Fix build break in System.Data_test
2357 * convert.cs (ImplicitConversionExists): Move NullLiteral
2359 (ImplicitStandardConversionExists): ... here.
2361 2008-11-28 Marek Safar <marek.safar@gmail.com>
2363 * literal.cs: Emit correctly explicit null to nullable cast.
2365 2008-11-28 Marek Safar <marek.safar@gmail.com>
2367 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2370 2008-11-28 Marek Safar <marek.safar@gmail.com>
2372 A fix for bug #449005
2373 * convert.cs, nullable.cs: Use only one implicit nullable
2376 2008-11-27 Marek Safar <marek.safar@gmail.com>
2378 * convert.cs, literal.cs: More Convert cleanup is needed.
2380 2008-11-27 Marek Safar <marek.safar@gmail.com>
2382 * decl.cs, class.cs: Fixed misleading error message.
2384 2008-11-26 Marek Safar <marek.safar@gmail.com>
2386 A fix for bug #449005
2387 * nullable.cs (EmitEquality): Disable optimization for user operator
2390 2008-11-25 Marek Safar <marek.safar@gmail.com>
2392 A fix for bug #447027
2393 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2394 with context variables stored as expression instances.
2396 2008-11-25 Marek Safar <marek.safar@gmail.com>
2398 A fix for bug #447027
2399 * delegate.cs: Fixed delegate VerifyMethod logic.
2401 2008-11-24 Marek Safar <marek.safar@gmail.com>
2403 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2406 2008-11-21 Marek Safar <marek.safar@gmail.com>
2408 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2409 member type resolve to follow normal flow, instead of random
2412 2008-11-21 Marek Safar <marek.safar@gmail.com>
2414 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2417 2008-11-21 Marek Safar <marek.safar@gmail.com>
2419 * const.cs: Emit decimal array constant as literal.
2421 2008-11-20 Marek Safar <marek.safar@gmail.com>
2423 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2425 2008-11-19 Marek Safar <marek.safar@gmail.com>
2427 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2428 into real property (saves 8 MB for corlib compilation).
2430 2008-11-19 Marek Safar <marek.safar@gmail.com>
2432 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2433 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2434 generic-mcs.cs: Small cleanup of TypeArguments.
2436 2008-11-18 Marek Safar <marek.safar@gmail.com>
2438 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2439 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2440 of ConstructedType expression, renamed to GenericTypeExpr.
2442 2008-11-17 Marek Safar <marek.safar@gmail.com>
2444 A fix for bug #445303
2445 * location.cs (IsConditionalDefined): Handle undefined global
2448 2008-11-17 Marek Safar <marek.safar@gmail.com>
2450 A fix for bug #444678
2451 * expression.cs (TryReduceConstant): Always create new constant
2454 2008-11-17 Marek Safar <marek.safar@gmail.com>
2456 A fix for bug #444673
2457 * ecore.cs: Ignore open generic types when used as generic type
2460 2008-11-17 Marek Safar <marek.safar@gmail.com>
2462 A fix for bug #445458
2463 * expression.cs, cs-parser.jay: Don't crash when an expression
2466 2008-11-17 Marek Safar <marek.safar@gmail.com>
2468 A fix for bug #445464
2469 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2470 inside unbound type.
2472 2008-11-14 Jb Evain <jbevain@novell.com>
2474 * driver.cs: ignore empty -nowarn argument such as
2475 the one in -nowarn:12,13,,.
2477 2008-11-13 Marek Safar <marek.safar@gmail.com>
2479 A fix for bug #444271
2480 * anonymous.cs: Rescan parent storeys when best candidate was
2483 2008-11-13 Marek Safar <marek.safar@gmail.com>
2485 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2486 useless UnboundTypeExpression.
2488 * attribute.cs: Do check obsolete attribute on generic types.
2490 2008-11-12 Marek Safar <marek.safar@gmail.com>
2492 A fix for bugs #425680, #400139
2493 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2496 2008-11-11 Marek Safar <marek.safar@gmail.com>
2498 A fix for bug #435747
2499 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2500 compound value types assignment. Few micro optimizations added.
2502 2008-11-10 Marek Safar <marek.safar@gmail.com>
2504 A fix for bug #442610
2505 * anonymous.cs (MutateConstructor): More SRE hacking.
2507 2008-11-10 Marek Safar <marek.safar@gmail.com>
2509 A fix for bug #442579
2510 * ecore.cs: Also initialize expanded form of a method with 1 params
2513 2008-11-06 Marek Safar <marek.safar@gmail.com>
2515 * expression.cs (UnaryMutator): Do early l-side check.
2517 2008-11-05 Miguel de Icaza <miguel@novell.com>
2519 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2520 Init, otherwise we would crash later on when checking for friend
2523 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2524 Otherwise we never get any meaningful information as to what
2527 2008-11-05 Marek Safar <marek.safar@gmail.com>
2529 A fix for bug #436318
2530 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2532 2008-11-05 Miguel de Icaza <miguel@novell.com>
2534 * namespace.cs: Turns out that it was a really bad idea to hide
2535 the errors for namespaces not found here in eval mode.
2537 * eval.cs: When we process using clauses, only enter those into
2538 the list of valid using clauses after they have been validated.
2540 The above change gives the proper semantics: it does not
2541 senselessly report the same errors with broken using statements by
2542 never storing them in the first place when they are invalid.
2544 2008-11-05 Marek Safar <marek.safar@gmail.com>
2546 A fix for bug #421839
2547 * cs-parser.jay: Remove expression from coalesce rule to force lower
2548 priority than the assignment operator.
2550 2008-11-05 Marek Safar <marek.safar@gmail.com>
2552 A fix for bug #437875
2553 * nullable.cs: Compile correctly method group operand used with null
2554 coalescing operator.
2556 2008-11-04 Marek Safar <marek.safar@gmail.com>
2558 A fix for bug #434589
2559 * expression.cs (Binary): Ignore lifted conversions when at least
2560 one operand is of reference type.
2562 2008-11-04 Marek Safar <marek.safar@gmail.com>
2564 * cs-parser.jay: Better syntax error report.
2566 2008-11-03 Marek Safar <marek.safar@gmail.com>
2568 A fix for bug #436792
2569 * cs-parser.jay: Use GetLocation to access location.
2571 2008-11-03 Marek Safar <marek.safar@gmail.com>
2573 A fix for bug #440774
2574 * cs-parser.jay: Also set current_array_type when parsing local
2577 2008-11-03 Marek Safar <marek.safar@gmail.com>
2579 A fix for bug #440785
2580 * expression.cs (As): Don't resolve self modifing expression
2583 2008-11-03 Marek Safar <marek.safar@gmail.com>
2585 A fix for bug #439447
2586 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2588 2008-11-03 Marek Safar <marek.safar@gmail.com>
2590 A fix for bug #437571
2591 * cs-parser.jay: Fixes internal error for invalid expression
2594 2008-10-17 Marek Safar <marek.safar@gmail.com>
2596 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2598 2008-10-17 Marek Safar <marek.safar@gmail.com>
2600 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2602 2008-10-17 Marek Safar <marek.safar@gmail.com>
2604 * cs-tokenizer.cs: More precise cast parsing.
2606 2008-10-16 Martin Baulig <martin@ximian.com>
2608 * anonymous.cs (AnonymousMethodStorey): Put back the
2609 `hoisted_locals' hashtable and use it in EmitType().
2611 2008-10-15 Marek Safar <marek.safar@gmail.com>
2613 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2614 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2617 2008-10-14 Marek Safar <marek.safar@gmail.com>
2619 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2621 2008-10-14 Marek Safar <marek.safar@gmail.com>
2623 * statement.cs: Mutate scope initializers.
2625 2008-10-14 Marek Safar <marek.safar@gmail.com>
2627 * expression.cs: Use typeless value for This constant.
2629 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2631 2008-10-14 Marek Safar <marek.safar@gmail.com>
2633 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2636 2008-10-13 Marek Safar <marek.safar@gmail.com>
2638 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2641 2008-10-13 Marek Safar <marek.safar@gmail.com>
2643 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2644 parser and tokenizer. Fixes many ambiguities including #433258.
2646 2008-10-10 Marek Safar <marek.safar@gmail.com>
2648 * cs-parser.jay: Fixed missing accessor recovery.
2650 2008-10-10 Marek Safar <marek.safar@gmail.com>
2652 A fix for bug #433701
2653 * expression.cs: Better error message.
2655 2008-10-10 Marek Safar <marek.safar@gmail.com>
2657 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2659 * Makefile: Disabled unused debug symbols.
2661 Also fixes: #320556, #321097, #321656, #321876, #351316
2663 2008-10-09 Miguel de Icaza <miguel@novell.com>
2665 * eval.cs: rename "<interactive>" to "{interactive}", to work
2666 around a requirement in the compiler that this be a valid
2667 filename, and in Windows it is not (433886).
2669 2008-10-09 Marek Safar <marek.safar@gmail.com>
2671 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2673 2008-10-08 Marek Safar <marek.safar@gmail.com>
2675 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2676 cs-parser.jay: Generic type declaration and type arguments cleanup.
2678 2008-10-05 Marek Safar <marek.safar@gmail.com>
2680 * cs-parser.jay: Allow parsing weird array creation construct.
2682 2008-10-05 Marek Safar <marek.safar@gmail.com>
2684 * cs-parser.jay: Conflicts reduction.
2686 2008-10-04 Marek Safar <marek.safar@gmail.com>
2688 * cs-parser.jay: Conflicts reduction.
2690 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2693 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2694 property. Add a 'count' hint about the use of the shared vector.
2695 Ensure that we don't leak out dirty bits.
2696 (UsageVector.MergeChild): Throw away information about variables
2698 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2700 2008-10-03 Marek Safar <marek.safar@gmail.com>
2702 A fix for bug #431746
2703 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2704 parameters when iterator is created.
2706 2008-10-03 Marek Safar <marek.safar@gmail.com>
2708 A fix for bug #431827
2709 * expression.cs: Fixed right based pointer arithmetic operations
2712 2008-10-03 Marek Safar <marek.safar@gmail.com>
2714 A fix for bug #353779
2715 * assign.cs, expression.cs: Fixed compound assignment conversions.
2717 2008-10-02 Marek Safar <marek.safar@gmail.com>
2719 A fix for bug #375262
2720 * statement.cs: Refactor ArrayForeach to be usable with string
2721 indexer. Optimized single dimentional arrays foreach.
2723 2008-10-02 Marek Safar <marek.safar@gmail.com>
2725 A fix for bug #431255
2726 * anonymous.cs, expression.cs: Removed broken optimization.
2728 2008-10-01 Marek Safar <marek.safar@gmail.com>
2730 * anonymous.cs: Use full type parameters of parent generic
2731 containers. Removed unnecessary AddParentStoreyReference call.
2733 2008-10-01 Marek Safar <marek.safar@gmail.com>
2735 A fix for bug #324702
2736 * class.cs: Use better shorter names for explicit interface member
2739 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2741 2008-10-01 Marek Safar <marek.safar@gmail.com>
2743 * expression.cs: Use new interface to check fixed expression.
2745 2008-10-01 Marek Safar <marek.safar@gmail.com>
2747 A fix for bug #421101
2748 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2749 interface to check for fixed fixed-buffers.
2751 2008-10-01 Marek Safar <marek.safar@gmail.com>
2753 A fix for bug #429264
2754 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2756 * delegate.cs: Removed unnecessary casts.
2758 2008-09-30 Marek Safar <marek.safar@gmail.com>
2760 A fix for bug #352151
2761 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2762 class.cs: Fixed already defined explicit interface members check.
2764 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2766 cs-tokenizer.cs: Fix typo.
2768 2008-09-28 Miguel de Icaza <miguel@novell.com>
2770 * eval.cs (InteractiveBase): The quit command now just sets a
2771 flag, instead of calling Environment.Exit(), it is milder on
2774 CompiledMethod is now in Mono.CSharp, not nested inside
2775 the Evaluator, it was inconvenient to use.
2777 2008-09-27 Miguel de Icaza <miguel@novell.com>
2779 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2780 code to be invoked without having to reparse.
2782 2008-09-27 Miguel de Icaza <miguel@novell.com>
2784 * ecore.cs: The recent changes to FieldExpr broke this as well.
2785 Fixes LINQ queries in the interactive shell.
2787 * Multiple files: indentation fixing for the Mono coding
2788 guidelines for the switch statement.
2790 * eval.cs: Make the Evaluator API thread safe.
2792 2008-09-26 Marek Safar <marek.safar@gmail.com>
2794 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2795 constructor parsing.
2797 2008-09-26 Marek Safar <marek.safar@gmail.com>
2799 A fix for bug #325326
2800 * statement.cs: Check possible mistaken empty statement using
2801 explicit blocks only.
2803 2008-09-25 Miguel de Icaza <miguel@novell.com>
2805 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2806 RootNamespace.ComputeNamespaces to update the internal list of
2807 namespaces, this is no longer done for us.
2809 (InteractiveBase): Use the Evaluator APIs instead of calling into
2812 2008-09-25 Marek Safar <marek.safar@gmail.com>
2814 A fix for bug #429264
2815 * expression.cs: Missing mutator for access to multidimensional
2818 2008-09-25 Marek Safar <marek.safar@gmail.com>
2820 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2823 * driver.cs: Missing input argument check.
2825 2008-09-25 Marek Safar <marek.safar@gmail.com>
2827 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2828 expression.cs, statement.cs, rootcontext.cs, class.cs,
2829 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2832 2008-09-24 Miguel de Icaza <miguel@novell.com>
2834 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2835 fully constructed FieldExpr, fixes the regression introduced in
2838 * ecore.cs, expression.cs: Plug back the eclass initialization as
2839 otherwise it regresses `csharp'.
2841 2008-09-24 Marek Safar <marek.safar@gmail.com>
2843 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2844 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2845 phase to resolve phase. It resolves problems with expression trees
2846 and fixes bugs #323796, #325156.
2848 2008-09-23 Marek Safar <marek.safar@gmail.com>
2850 * codegen.cs: Report better error when symbol writer is missing.
2852 2008-09-23 Marek Safar <marek.safar@gmail.com>
2854 * codegen.cs: Set .NET symbol writer.
2856 * decl.cs: Guard against null generic arguments.
2858 * report.cs: Don't report exactly same additional details.
2860 2008-09-22 Marek Safar <marek.safar@gmail.com>
2862 A fix for bug #324917
2863 * cs-parser.jay: Add missing multidimensional non-expression type
2866 2008-09-22 Marek Safar <marek.safar@gmail.com>
2868 A fix for bug #428191
2869 * anonymous.cs: Create an outer generic fields also for non-storey
2872 2008-09-22 Marek Safar <marek.safar@gmail.com>
2874 A fix for bug #378294
2875 * class.cs: Make fixed size buffers gmcs feature only.
2877 2008-09-22 Marek Safar <marek.safar@gmail.com>
2879 A fix for bug #355622, #324993
2880 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2883 2008-09-19 Marek Safar <marek.safar@gmail.com>
2885 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2888 2008-09-19 Marek Safar <marek.safar@gmail.com>
2890 A fix for bug #416110
2891 * generic.cs: Struct constraint results in default ctor and
2892 ValueType base type constraint to be set.
2894 2008-09-19 Marek Safar <marek.safar@gmail.com>
2896 A fix for bug #423791
2897 * generic.cs: Fixed params output type type-inference.
2899 2008-09-19 Marek Safar <marek.safar@gmail.com>
2901 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2903 2008-09-19 Marek Safar <marek.safar@gmail.com>
2905 * cs-tokenizer.cs: Don't break on extra partial modifier.
2907 2008-09-19 Marek Safar <marek.safar@gmail.com>
2909 A fix for bug #427592
2910 * generic.cs: Use common parameter resolve method.
2912 2008-09-18 Marek Safar <marek.safar@gmail.com>
2914 A fix for bug #414758
2915 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2918 2008-09-18 Marek Safar <marek.safar@gmail.com>
2920 * driver.cs, namespace.cs: Read types and namespaces after all
2921 requested assemblies are loaded, fixes issues with System.Core
2922 auto-reference, and #419888.
2924 2008-09-18 Marek Safar <marek.safar@gmail.com>
2926 A fix for bug #417705
2927 * cs-parser.jay: Fixed as/is operator expression split.
2929 2008-09-18 Marek Safar <marek.safar@gmail.com>
2931 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2932 Fixed expression tree representation of empty new expression and
2933 new initializer expression.
2935 2008-09-18 Miguel de Icaza <miguel@novell.com>
2937 * eval.cs: Remove warning, keep reference to driver around.
2939 * Hide fields that do not need to be public.
2941 2008-09-17 Marek Safar <marek.safar@gmail.com>
2943 A fix for bug #426385
2944 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2945 conversion for array elements.
2947 2008-09-17 Marek Safar <marek.safar@gmail.com>
2949 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2950 void parsing conflicts.
2952 2008-09-15 Marek Safar <marek.safar@gmail.com>
2954 A fix for bug #425601
2955 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2956 System.Core only when there is no custom ExtensionAttribute
2959 2008-09-15 Miguel de Icaza <miguel@novell.com>
2961 * namespace.cs: Do not report CS0246 (name
2963 2008-09-12 Marek Safar <marek.safar@gmail.com>
2965 A fix for bug #425669
2966 * generic.cs: Don't cache generic static anonymous method
2969 2008-09-12 Marek Safar <marek.safar@gmail.com>
2971 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2972 conflicting constraints.
2974 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2976 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2979 2008-09-12 Marek Safar <marek.safar@gmail.com>
2981 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2982 to null pointer conversion fixes.
2984 2008-09-11 Marek Safar <marek.safar@gmail.com>
2986 * cs-parser.jay, expression.cs: An implicitly typed local variable
2987 declarator cannot use an array initializer.
2989 2008-09-11 Marek Safar <marek.safar@gmail.com>
2991 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2993 2008-09-11 Marek Safar <marek.safar@gmail.com>
2995 * generic.cs (InflatedConstraints): Don't crash when constraints
2998 * cs-parser.jay: const_declarator is a block.
3000 * constant.cs: Check for not allowed NaN conversions.
3002 2008-09-10 Miguel de Icaza <miguel@novell.com>
3004 * driver.cs: Drop --shell argument, the compiler is no longer a
3007 * eval.cs: Move most of the code that deals with evaluation into
3008 this file and document the public API from repl.cs
3010 * repl.cs: Remove from here.
3012 2008-09-10 Marek Safar <marek.safar@gmail.com>
3014 A fix for bug #424684
3015 * generic.cs: Generic class constraints must come first.
3017 2008-09-09 Miguel de Icaza <miguel@novell.com>
3019 * cs-parser.jay: Improve error reporting for syntax errors in
3020 statements and expressions, we now report the expected tokens
3021 instead of reporting the useless "; expected".
3023 Drop the strings from the token declaration, it turns out that
3024 they did not do what I thought they did. Instead they were adding
3025 two sets of tokens to the tables.
3027 2008-09-09 Marek Safar <marek.safar@gmail.com>
3029 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3030 delegate.cs: Share special type check.
3032 2008-09-09 Marek Safar <marek.safar@gmail.com>
3034 A fix for bug #423981
3035 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3037 2008-09-09 Marek Safar <marek.safar@gmail.com>
3039 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3042 2008-09-09 Marek Safar <marek.safar@gmail.com>
3044 A fix for bugs: #324750, #335946
3045 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3046 lookup rule to determine ?-based tokens.
3048 2008-09-08 Miguel de Icaza <miguel@novell.com>
3050 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3051 expressions (like event adding or removing) end up here, so we
3052 need to treat those as statements.
3054 Add LoadAssembly method.
3056 2008-09-04 Miguel de Icaza <miguel@novell.com>
3058 * repl.cs: Add Time method.
3060 2008-09-05 Marek Safar <marek.safar@gmail.com>
3062 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3064 2008-09-05 Miguel de Icaza <miguel@novell.com>
3066 * repl.cs: Add workaround for old compilers.
3068 2008-09-04 Jb Evain <jbevain@novell.com>
3070 * repl.cs (PrettyPrint): pretty print everything that
3071 implements IDictionary, as well as IEnumerables. Also,
3072 add a quit helper property.
3074 2008-09-04 Marek Safar <marek.safar@gmail.com>
3076 * constant.cs: Better error reporting for decimal literals.
3078 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3081 2008-09-04 Marek Safar <marek.safar@gmail.com>
3082 Miguel de Icaza <miguel@novell.com>
3084 A fix for bug #422951
3085 * assign.cs (Assign.DoResolve): Perform the type conversions
3086 checks before we attempt to initialize `New' initializers.
3088 2008-09-04 Marek Safar <marek.safar@gmail.com>
3090 A fix for bug #422853
3091 * delegate.cs (DelegateCreation): Add special handling for
3092 EmptyExpression.Null instance expression which is just another
3093 hack for undecided member instance exression.
3095 2008-09-04 Marek Safar <marek.safar@gmail.com>
3097 * expression.cs, ecore.cs: Emit full expression tree for reduced
3100 2008-09-04 Marek Safar <marek.safar@gmail.com>
3102 * expression.cs (This): Guard against multi-resolving.
3104 * ecore.cs, statement.cs (Throw): Simplified.
3106 * flowanalysis.cs: Also verify event fields.
3108 2008-09-04 Miguel de Icaza <miguel@novell.com>
3110 * assign.cs (Assign.DoResolve): Perform the type conversions
3111 checks before we attempt to initialize `New' initializers.
3113 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3115 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3118 * repl.cs: Update help.
3120 2008-09-03 Miguel de Icaza <miguel@novell.com>
3122 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3123 handling of the default config handling, including the special
3124 treatment of System.Core assembly.
3126 Fixes the REPL processing for LINQ.
3128 2008-09-03 Marek Safar <marek.safar@gmail.com>
3130 A fix for bug #422507
3131 * expression.cs (UnboxCast): Add missing child expression mutator.
3133 2008-09-03 Marek Safar <marek.safar@gmail.com>
3135 * driver.cs: Don't self reference System.Core assembly.
3137 2008-09-03 Marek Safar <marek.safar@gmail.com>
3139 A fix for bug #422507
3140 * expression.cs (StringConcat): Add missing type mutator.
3142 2008-09-03 Marek Safar <marek.safar@gmail.com>
3144 * generic.cs (TypeInferenceContext): Follow equality rule for
3145 constructed type lower bound type inference.
3147 2008-09-02 Miguel de Icaza <miguel@novell.com>
3149 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3150 <dblank@cs.brynmawr.edu> which updates the cursor position on
3153 2008-09-02 Marek Safar <marek.safar@gmail.com>
3155 A fix for bug #367145
3156 * driver.cs: Fixed import of extension methods when using -noconfig
3159 2008-09-02 Marek Safar <marek.safar@gmail.com>
3161 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3162 version from non-generic implementation instead.
3164 2008-09-01 Marek Safar <marek.safar@gmail.com>
3166 A fix for bug #418908
3167 * class.cs: Use AddScopeStatement for field initializers.
3169 2008-09-01 Marek Safar <marek.safar@gmail.com>
3171 A fix for bug #415385
3172 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3174 2008-09-01 Marek Safar <marek.safar@gmail.com>
3176 A fix for bug #421736
3177 * iterators.cs: Don't crash on unreachable iterators.
3179 2008-09-01 Marek Safar <marek.safar@gmail.com>
3181 A fix for bug #421628
3182 * parameter.cs, attribute.cs: Clone also parameter attributes.
3184 2008-08-30 Miguel de Icaza <miguel@novell.com>
3186 * namespace.cs (LookupType): In EvalMode, try to replace
3187 the TypeBuilder from our cache with a Type as Reflection.Emit does
3188 not like to mix code from older assemblies emitted and new
3191 This sounds like a serious Mono bug that prevents multiple
3192 assemblies to be generated and consumed at the same time.
3194 * cs-parser.jay (push_current_class): Do not make interactive
3195 classes internal or private, make them public as we currently
3196 generate each new class in a new assembly.
3198 2008-08-29 Miguel de Icaza <miguel@novell.com>
3200 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3201 remove types that are entered into the global namespace during
3202 parsing so that we can remove them on failure.
3204 * cs-parser.jay: Parsing: we now keep track of types that are
3205 entered into global variables and queue those in case the parsing
3208 This happens in a few situations: during partial-input, we invoke
3209 the parser repeatedly for example with the string "class X", this
3210 would cause X to be registed, and we need to remove this
3211 registration so that another parse attempt later with say "class X {"
3212 would actually work.
3214 Additionally, if there is an error in the resolution phase, for
3215 example: "class X : NonExistant {}" th
3217 * cs-parser.jay: Be more precise with the errors being raised,
3218 instead of flagging all exceptions during parsing to be attributed
3219 to the parsing process, distinguish those from errors happening in
3220 the actions and hint that using -v would produce the actual
3223 * repl.cs: Do not load all compiler references on each reset,
3224 doing the partial reset takes care of this.
3226 2008-08-28 Miguel de Icaza <miguel@novell.com>
3228 * repl.cs: Add support for loading all the files from
3229 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3232 Introduce a micro-parser that is able to deambiguate on its input
3233 whether we are dealing with a compilation unit (namespace, class,
3234 interface, struct, delegate) declaration or a statement. This
3235 allows both declarations and statements to be entered.
3237 Set history size by default to 300 lines.
3239 Instead of distinguishing based on the parser.InteractiveResult,
3240 have only two cases: statements were parsed, or a compilation unit
3241 was. Always pull the Using statement additions from the
3242 compilation unit parse.
3244 * cs-tokenizer.cs: Rename tokens to better describe their intent
3245 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3247 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3248 EvalMode is used to trigger the lookup of global variables while
3249 StatementMode is used turn variable declarations into static
3252 * getline.cs: Allow history size to be set.
3254 2008-08-29 Marek Safar <marek.safar@gmail.com>
3256 A fix for bug #360755
3257 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3259 2008-08-29 Marek Safar <marek.safar@gmail.com>
3261 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3263 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3264 member name, it is too confusing
3266 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3268 * rootcontext.cs: Finally default to warning level 4.
3270 2008-08-28 Marek Safar <marek.safar@gmail.com>
3272 * class.cs (CheckBase): Ignore overloaded operators.
3274 2008-08-28 Marek Safar <marek.safar@gmail.com>
3276 A fix for bug #420830
3277 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3279 2008-08-28 Marek Safar <marek.safar@gmail.com>
3281 A fix for bug #420832
3282 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3284 2008-08-28 Marek Safar <marek.safar@gmail.com>
3286 A fix for bug #420386
3287 * nullables.cs: Fixed logic of nullable user comparison operators involving
3290 2008-08-28 Marek Safar <marek.safar@gmail.com>
3292 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3294 2008-08-27 Miguel de Icaza <miguel@novell.com>
3296 * repl.cs: Add support for aborting the running code with C-c.
3298 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3300 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3302 2008-08-27 Miguel de Icaza <miguel@novell.com>
3304 * cs-parser.jay (interactive_statement_list): A new set of rules
3305 for hosting statements that uses the "interactive_" prefix.
3307 * repl.cs: Add support for parsing `using' as a statement or as a
3308 directive. Deambiguating before passing this to the parser.
3310 We need to distinguish statement_expressions that occur at the
3311 toplevel vs those that occur embedded into expressions.
3313 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3314 that fixes the cursor key handling, and a history bug.
3316 2008-08-26 Miguel de Icaza <miguel@novell.com>
3318 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3319 limitations in Console, instead the 2.0 bootstrap libraries now
3320 include the Console bits.
3322 Also, remove the use of Nullables from getline.cs
3326 Interactive support for the C# compiler. Use gmcs --shell to
3327 enter a read-eval-print loop shell.
3329 Docs: http://www.mono-project.com/CsharpRepl
3331 * sources: include repl.cs here and getline.cs for gmcs.exe,
3332 everything else is getline.cs impaired.
3334 * Makefile: when bootstrapping pass a special flag
3335 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3336 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3337 This distinguishes those two cases.
3339 * repl.cs: Support for a read-eval-print loop. Will be soon
3340 refactored into eval support and then REPL on top of it.
3342 * ecore.cs: If a simplename lookup fails, before erroring out,
3343 if we are in EvalMode to resolve the name to a declaration in the
3346 This means that variable declarations that happened in previous
3347 classes (as repl puts every statement in a separate class) are
3348 made visible in this way.
3350 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3351 triggered an error due to the end of file being reached. This is
3352 used to do multi-line input, and notify the caller that the user
3353 needs to provide more text before a successful parse.
3355 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3356 to drive the evaluation with a custom wrapper.
3358 * driver.cs: Add support for --shell, and refactor some code to be
3361 * namespace.cs: Add support for serializing the contents of the
3362 namespaces and reloading them.
3364 * getline.cs: A managed implementation of ReadLine under
3365 X11/Apache2 license terms. Easy to embed in other applications as
3368 * namespace.cs: Add some functions to save and restore the
3371 * rootcontext.cs: New public field.
3373 * cs-tokenizer.cs: Add support for one of the possible characters
3374 we introduce into the token stream.
3376 This patch does not affect the regular tokenization process, the
3377 only performance hit would happen if there is an invalid character
3378 on the input string.
3380 * support.cs: Move isatty helper routine here.
3382 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3383 code generator for in-memory assemblies.
3385 2008-08-26 Marek Safar <marek.safar@gmail.com>
3387 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3388 parameter cannot be always used as a type.
3390 2008-08-21 Marek Safar <marek.safar@gmail.com>
3392 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3394 2008-08-21 Marek Safar <marek.safar@gmail.com>
3396 * convert.cs: Implement explicit array to IList<T> conversion.
3398 2008-08-20 Marek Safar <marek.safar@gmail.com>
3400 A fix for bug #362740
3401 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3403 2008-08-20 Marek Safar <marek.safar@gmail.com>
3405 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3406 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3407 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3408 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3409 handling to use just one type of infrastructure and deal with generics
3412 2008-07-23 Martin Baulig <martin@ximian.com>
3414 *** Merged this from trunk revision 108527 ***
3417 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3418 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3421 2008-08-15 Marek Safar <marek.safar@gmail.com>
3423 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3426 2008-08-15 Marek Safar <marek.safar@gmail.com>
3428 * delegate.cs: Fixed compiler crash when creating delegate using partial
3431 * typemanager.cs: MulticastDelegate is not a delegate.
3433 2008-08-14 Marek Safar <marek.safar@gmail.com>
3435 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3438 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3440 * cs-parser.jay (type): Allow 'var' in mcs too.
3441 (local_variable_type): Likewise.
3443 2008-08-14 Marek Safar <marek.safar@gmail.com>
3445 * driver.cs: Removed broken -noconfig variants.
3447 2008-08-14 Marek Safar <marek.safar@gmail.com>
3449 A fix for bug #417078
3450 * expression.cs: Emit correctly left side pointer operators.
3452 2008-08-13 Marek Safar <marek.safar@gmail.com>
3454 * generic.cs, lambda.cs: Inflate method generic arguments only.
3456 2008-08-12 Marek Safar <marek.safar@gmail.com>
3458 * class.cs: Fixed struct layout check regression.
3460 2008-08-12 Marek Safar <marek.safar@gmail.com>
3462 * cs-parser.jay, enum.cs: Simplified enum parsing.
3464 * decl.cs: Check all type parameters conflicts.
3466 * expression.cs, statement.cs, attribute.cs: More expression checks.
3468 2008-08-11 Marek Safar <marek.safar@gmail.com>
3470 * generic.cs: Add type inference types restriction.
3472 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3473 anonymous.cs, expression.cs: Allocate less accessor parameters.
3475 2008-08-08 Marek Safar <marek.safar@gmail.com>
3477 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3480 2008-08-08 Marek Safar <marek.safar@gmail.com>
3482 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3484 2008-08-07 Marek Safar <marek.safar@gmail.com>
3486 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3487 Also fixes #362146 and #381592.
3489 2008-08-07 Marek Safar <marek.safar@gmail.com>
3491 * ecore.cs: Reduced constant cannot be used as an attribute value.
3493 * cs-parser.jay: Base expression has to be a type.
3495 * expression.cs (Conditional): Uses ReducedExpression.
3497 2008-08-06 Marek Safar <marek.safar@gmail.com>
3499 A fix for bug #376826
3500 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3501 address of hoisted local variable or parameter cannot be taken.
3503 2008-08-05 Marek Safar <marek.safar@gmail.com>
3505 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3506 anonymous method inside checked/unchecked expression.
3508 2008-08-05 Marek Safar <marek.safar@gmail.com>
3510 * typemanager.cs (IsEqual): Guard against null.
3512 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3513 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3514 routine. Fixed few misleading conversion errors.
3516 2008-08-04 Marek Safar <marek.safar@gmail.com>
3518 * class.cs: Consider generics when checking cycles in struct layout.
3520 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3522 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3524 2008-08-04 Marek Safar <marek.safar@gmail.com>
3526 A fix for bug #414165
3527 * anonymous.cs: Use same anonymous implementation method for all anonymous
3530 2008-08-04 Marek Safar <marek.safar@gmail.com>
3532 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3535 2008-08-04 Marek Safar <marek.safar@gmail.com>
3537 * cs-parser.jay: Typeof argument has to be a type expression.
3539 * namespace.cs: Check alias and namespace definitions collisions.
3541 * class.cs, pending.cs: Moved explicit interface accessor implementation
3544 * delegate.cs, expression.cs: Verify special name invocations.
3546 2008-08-01 Marek Safar <marek.safar@gmail.com>
3548 * cs-parser.jay: Don't choke on empty generic type arguments.
3550 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3552 * expression.cs, ecore.cs: Minor expressions bugs.
3554 2008-08-01 Marek Safar <marek.safar@gmail.com>
3556 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3557 and added more error handling.
3559 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3561 * modifiers.cs, enum.cs: Fixed.
3563 2008-07-31 Jb Evain <jbevain@novell.com>
3565 * driver.cs: remove -pkg ability of smcs.
3567 2008-07-30 Marek Safar <marek.safar@gmail.com>
3569 * statement.cs (Switch): Correctly set empty default target for single
3572 2008-07-30 Marek Safar <marek.safar@gmail.com>
3574 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3575 string switch statement implementation to use string dictionary which
3576 significantly (2-8x) improves performance of generated code.
3578 2008-07-29 Marek Safar <marek.safar@gmail.com>
3580 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3581 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3583 2008-07-29 Marek Safar <marek.safar@gmail.com>
3585 A fix for bug #412595
3586 * typemanager.cs, convert.cs, expression.cs: Some types are never
3587 convertible to each other.
3589 2008-07-29 Marek Safar <marek.safar@gmail.com>
3591 * nullable.cs (CreateNullConstant): An error messages update.
3593 2008-07-29 Marek Safar <marek.safar@gmail.com>
3595 A fix for bug #412595
3596 * cfold.cs: Don't cast undefined bool constant.
3598 2008-07-29 Martin Baulig <martin@ximian.com>
3601 (SymbolWriter.Reset): New public static method.
3604 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3606 2008-07-28 Marek Safar <marek.safar@gmail.com>
3608 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3610 * expression.cs (ElementAccess): Exact size allocation.
3612 2008-07-26 Marek Safar <marek.safar@gmail.com>
3614 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3616 2008-07-25 Marek Safar <marek.safar@gmail.com>
3618 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3620 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3623 2008-07-25 Marek Safar <marek.safar@gmail.com>
3625 A fix for bug #412217
3626 * assign.cs: Mutate also assignment type.
3628 2008-07-25 Marek Safar <marek.safar@gmail.com>
3630 A fix for bug #323644
3631 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3634 2008-07-25 Marek Safar <marek.safar@gmail.com>
3636 A fix for bug #412134
3637 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3638 non-enumerable operands when overloading equality or bitwise operators.
3640 2008-07-25 Marek Safar <marek.safar@gmail.com>
3642 * anonymous.cs: Cache closed generic anonymous method delegates.
3644 2008-07-24 Marek Safar <marek.safar@gmail.com>
3646 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3647 anonymous.cs, statement.cs: Always emit anonymous method as static method
3648 when is instance free. Use nesting for nested anynomous methods blocks.
3650 2008-07-23 Marek Safar <marek.safar@gmail.com>
3652 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3655 2008-07-23 Marek Safar <marek.safar@gmail.com>
3657 * expression.cs: Removed MakeSimpleCall.
3659 2008-07-23 Marek Safar <marek.safar@gmail.com>
3661 A fix for bug #323012
3662 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3663 Base method implementing interface has to be public.
3665 2008-07-23 Marek Safar <marek.safar@gmail.com>
3667 * cs-parser.jay: Don't break on missing argument.
3669 2008-07-22 Marek Safar <marek.safar@gmail.com>
3671 A fix for bug #320993
3672 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3673 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3675 2008-07-22 Marek Safar <marek.safar@gmail.com>
3677 A fix for bug #320748
3678 * convert.cs: Implicit user operators cannot convert to interfaces
3680 2008-07-22 Marek Safar <marek.safar@gmail.com>
3682 A fix for bug #312686
3683 * driver.cs: Ignore empty assembly references.
3685 2008-07-22 Marek Safar <marek.safar@gmail.com>
3687 A fix for bug #387040
3688 * ecore.cs: Skip constrains check for an explicit implementation.
3690 2008-07-21 Marek Safar <marek.safar@gmail.com>
3692 A fix for bug #409045
3693 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3694 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3695 identifiers are file specific unless passed as input arguments.
3697 2008-07-21 Marek Safar <marek.safar@gmail.com>
3699 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3700 to emit UnmanagedMarshal data under 2.0 profile.
3702 2008-07-21 Marek Safar <marek.safar@gmail.com>
3704 A fix for bug #410369
3705 * parameter.cs: Clone correctly ParamsParameter.
3707 2008-07-21 Marek Safar <marek.safar@gmail.com>
3709 * expression.cs (Argument): Always report type for type based expressions
3712 2008-07-18 Marek Safar <marek.safar@gmail.com>
3714 A fix for bug #410666
3715 * anonymous.cs: Correctly initialize generic storey reference.
3717 2008-07-18 Marek Safar <marek.safar@gmail.com>
3719 * convert.cs: Don't box same type arguments.
3721 2008-07-18 Marek Safar <marek.safar@gmail.com>
3723 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3724 Finished missing generic type mutators.
3726 2008-07-18 Marek Safar <marek.safar@gmail.com>
3728 * iterators.cs, statement.cs: Finished statements CloneTo.
3730 2008-07-18 Marek Safar <marek.safar@gmail.com>
3732 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3734 * expression.cs: Emit optimized default value expressions in expression tree
3737 2008-07-18 Marek Safar <marek.safar@gmail.com>
3739 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3741 2008-07-17 Marek Safar <marek.safar@gmail.com>
3743 A fix for bug #367536
3744 * cs-parser.jay: Check static constructor of generic types for an access
3747 2008-07-17 Marek Safar <marek.safar@gmail.com>
3749 A fix for bug #353800
3750 * lambda.cs: Emit ret for contextual statements.
3752 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3753 up emitting redundant ret for all anonymous methods with return.
3755 2008-07-17 Marek Safar <marek.safar@gmail.com>
3757 A fix for bug #365188
3758 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3759 create anonymous method storey in unreachable block.
3761 2008-07-17 Marek Safar <marek.safar@gmail.com>
3763 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3764 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3765 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3766 statement.cs: Fixed relevant defects found by Gendarme.
3768 2008-07-17 Marek Safar <marek.safar@gmail.com>
3770 A fix for bug #325291
3771 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3772 statement.cs: Replaced IAnonymousHost with top level block flag.
3774 2008-07-17 Marek Safar <marek.safar@gmail.com>
3776 * cs-parser.jay: Clean up unused open_parens.
3778 2008-07-17 Marek Safar <marek.safar@gmail.com>
3780 * ecore.cs: Custom error message for a range variable assignment.
3782 2008-07-16 Marek Safar <marek.safar@gmail.com>
3784 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3787 2008-07-16 Marek Safar <marek.safar@gmail.com>
3789 * literal.cs: Null literal is of object type.
3791 2008-07-16 Marek Safar <marek.safar@gmail.com>
3793 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3794 expression of nullable equality comparison.
3796 2008-07-15 Marek Safar <marek.safar@gmail.com>
3798 * expression.cs(PointerArithmetic): Removed redundant assignment.
3800 2008-07-15 Marek Safar <marek.safar@gmail.com>
3802 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3804 2008-07-14 Marek Safar <marek.safar@gmail.com>
3806 A fix for bug #408361
3807 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3808 they are replaced by GetMethod.
3810 2008-07-14 Marek Safar <marek.safar@gmail.com>
3812 A fix for bug #408721 by jeremie.laval@gmail.com
3813 * expression.cs (Indirection): Implemented CloneTo.
3815 2008-07-14 Marek Safar <marek.safar@gmail.com>
3817 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3820 2008-07-14 Marek Safar <marek.safar@gmail.com>
3822 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3824 2008-07-11 Marek Safar <marek.safar@gmail.com>
3826 * linq.cs: Reset tranparent parameter counter in probing mode.
3828 2008-07-11 Marek Safar <marek.safar@gmail.com>
3830 * anonymous.cs: Mutate anonymous method type.
3832 2008-07-11 Marek Safar <marek.safar@gmail.com>
3834 * ecore.cs, anonymous.cs: Mutate field expressions.
3836 2008-07-10 Marek Safar <marek.safar@gmail.com>
3838 A fix for bug #369670
3839 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3841 2008-07-10 Marek Safar <marek.safar@gmail.com>
3843 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3845 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3848 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3849 only one '>', and finds a '>>', abort the generic lookahead.
3851 2008-07-10 Marek Safar <marek.safar@gmail.com>
3853 A fix for bug #319902
3854 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3856 2008-07-10 Marek Safar <marek.safar@gmail.com>
3858 A fix for bug #406371
3859 * statement.cs: Moved EmitSymbolInfo to Block.
3861 2008-07-09 Marek Safar <marek.safar@gmail.com>
3863 * ecore.cs: Report better error for extension method overload failures.
3865 2008-07-09 Marek Safar <marek.safar@gmail.com>
3867 * expression.cs (Is): No need to box reference values.
3869 2008-07-09 Marek Safar <marek.safar@gmail.com>
3871 * class.cs: Use event resolve context when initializing CreateEmitContext.
3873 2008-07-09 Marek Safar <marek.safar@gmail.com>
3875 A fix for bug #394436
3876 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3877 method used inside expression trees. Added more LINQ to expression tree
3880 2008-07-08 Marek Safar <marek.safar@gmail.com>
3882 A fix for bug #378189, #370577
3883 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3886 2008-07-08 Marek Safar <marek.safar@gmail.com>
3888 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3891 2008-07-08 Marek Safar <marek.safar@gmail.com>
3893 A fix for bug #406702
3894 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3896 2008-07-07 Marek Safar <marek.safar@gmail.com>
3898 A fix for bug #406648
3899 * cs-parser.jay: Report nullable use in mcs for some cases.
3901 2008-07-07 Marek Safar <marek.safar@gmail.com>
3903 * ecore.cs: Improved argument mismatch error messages.
3905 2008-07-07 Marek Safar <marek.safar@gmail.com>
3907 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3909 2008-07-07 Marek Safar <marek.safar@gmail.com>
3911 * expression.cs (TypeOf): Mutate type argument.
3913 2008-07-04 Marek Safar <marek.safar@gmail.com>
3915 * class.cs: Report missing partial modifier for correct type.
3917 2008-07-04 Marek Safar <marek.safar@gmail.com>
3919 * ecore.cs, expression.cs (VariableReference): Variable property is
3922 2008-07-04 Marek Safar <marek.safar@gmail.com>
3924 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3926 2008-07-04 Marek Safar <marek.safar@gmail.com>
3928 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3931 2008-07-04 Marek Safar <marek.safar@gmail.com>
3933 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3934 anonymous method storey to an instance method when only "this" is hoisted.
3936 2008-07-03 Marek Safar <marek.safar@gmail.com>
3938 A fix for bug #321615
3939 * expression.cs: Pointer comparisons use unsigned operator.
3941 2008-07-03 Marek Safar <marek.safar@gmail.com>
3943 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3945 2008-07-02 Marek Safar <marek.safar@gmail.com>
3947 A fix for bug #404905
3948 * class.cs: Always initialize local unsafe variables.
3950 2008-06-30 Marek Safar <marek.safar@gmail.com>
3952 A fix for bug #396987
3953 * expression.cs (NewInitialize): Clear local temporary variable for next run
3955 2008-06-27 Marek Safar <marek.safar@gmail.com>
3957 A fix for bug #401020
3958 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3960 2008-06-27 Marek Safar <marek.safar@gmail.com>
3962 A fix for bug #398319
3963 * cs-parser.jay: Implemented undocumented base access expression inside
3966 2008-06-26 Marek Safar <marek.safar@gmail.com>
3968 A fix for bug #404227
3969 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3971 2008-06-26 Marek Safar <marek.safar@gmail.com>
3973 A fix for bug #404227
3974 * convert.cs: Fixed explicit array to interface cast.
3976 2008-06-26 Marek Safar <marek.safar@gmail.com>
3978 A fix for bug #403894
3979 * delegate.cs: Mutate DelegateInvocation type.
3981 2008-06-26 Marek Safar <marek.safar@gmail.com>
3983 A fix for bug #379348
3984 * delegate.cs: Box a load of generic parameters.
3986 2008-06-26 Marek Safar <marek.safar@gmail.com>
3988 * expression.cs: Add an array creation arguments mutate.
3990 2008-06-26 Marek Safar <marek.safar@gmail.com>
3992 A fix for bug #386068
3993 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3996 2008-06-25 Marek Safar <marek.safar@gmail.com>
3998 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4001 2008-06-25 Marek Safar <marek.safar@gmail.com>
4003 A fix for bug #403518
4004 * delegate.cs: Type correctly anonymous method new invocation.
4006 2008-06-24 Marek Safar <marek.safar@gmail.com>
4008 A fix for bug #394826
4009 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4012 2008-06-24 Marek Safar <marek.safar@gmail.com>
4014 A fix for bug #394826
4015 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4018 2008-06-24 Marek Safar <marek.safar@gmail.com>
4020 * class.cs: Clone indexer parameters for localized capturing.
4022 2008-06-24 Marek Safar <marek.safar@gmail.com>
4024 A fix for bug #402379
4025 * expression.cs: Don't crash when an object initializer resolve fails.
4027 2008-06-24 Marek Safar <marek.safar@gmail.com>
4029 A fix for bug #402888
4030 * expression.cs: Mutate conditional expression.
4032 2008-06-24 Marek Safar <marek.safar@gmail.com>
4034 A fix for bug #401012
4035 * class.cs: Keep StructLayout in shared container.
4037 2008-06-24 Marek Safar <marek.safar@gmail.com>
4039 A fix for bug #400438
4040 * decl.cs, class.cs: Only properties can be automatically implemented.
4042 2008-06-24 Marek Safar <marek.safar@gmail.com>
4044 * statement.cs (ChangeToIterator): Copy also labels.
4046 2008-06-23 Marek Safar <marek.safar@gmail.com>
4048 * ecore.cs: Pass type argument details to parent extension method.
4050 2008-06-23 Marek Safar <marek.safar@gmail.com>
4052 A fix for bug #375966
4053 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4055 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4057 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4059 2008-06-22 Marek Safar <marek.safar@gmail.com>
4061 A fix for bug #394347
4062 * anonymous.cs: Cache compatible delegates as compatibility check produces
4063 a new method every time.
4065 2008-06-20 Marek Safar <marek.safar@gmail.com>
4067 * anonymous.cs: Propagate storey reference for single references.
4069 2008-06-20 Marek Safar <marek.safar@gmail.com>
4071 A fix for bug #387615
4072 * assign.cs, expression.cs: Correctly clone compound assignment.
4074 2008-06-19 Marek Safar <marek.safar@gmail.com>
4076 A fix for bug #359611, #359604
4077 * anonymous.cs: Mutate all types of hoisted parameters.
4079 2008-06-19 Marek Safar <marek.safar@gmail.com>
4081 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4082 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4083 expression.cs, codegen.cs, statement.cs
4085 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4086 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4088 ** Anonymous methods, lambda expressions rewrite **
4090 Anonymous expressions are now resolved when an explicit block is resolved
4091 and they don't require any registration procedure anymore. Further,
4092 anonymous methods are defined when explicit block is emitted which allows
4093 better control of whole process and opens possibilities for more
4094 optimizations as well as alternative to reverse whole process.
4096 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4097 process consistent and to correctly emit hoisted generic methods when they
4098 have at least 1 hoisted variable.
4100 2008-06-17 Martin Baulig <martin@ximian.com>
4102 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4104 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4105 virtual property; check it in Emit().
4106 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4108 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4110 (Indexer.Define): Likewise.
4112 2008-06-17 Marek Safar <marek.safar@gmail.com>
4114 * convert.cs: Don't use IsInterface on type arguments.
4116 * delegate.cs: DelegateInvocation uses MethodInfo.
4118 * parameter.cs: Removed IsTypeParameter.
4120 * generic-mcs.cs: More missing stuff.
4122 2008-06-16 Martin Baulig <martin@ximian.com>
4125 (Modifiers.DEBUGGER_HIDDEN): New public const.
4128 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4131 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4132 (AbstractPropertyEventMethod): Likewise.
4133 (Constructor.Emit): Likewise.
4134 (SourceMethod.SetCompilerGenerated): Removed.
4136 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4140 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4141 if we're an `IteratorHost'.
4142 (AnonymousMethodMethod..ctor): Don't set
4143 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4146 2008-06-16 Marek Safar <marek.safar@gmail.com>
4148 * statement.cs: Clean-up foreach statements.
4150 2008-06-12 Marek Safar <marek.safar@gmail.com>
4152 * class.cs: Stop using public method which should not exist
4153 (MethodBuilder.SetGenericMethodSignature).
4155 2008-06-11 Martin Baulig <martin@ximian.com>
4158 (Location.LookupFile): Add `CompilationUnit' argument; when given
4159 a relative file name, make it relative to the directory the .cs
4160 file is located in instead of using the current directory.
4162 2008-06-11 Martin Baulig <martin@ximian.com>
4165 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4166 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4167 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4168 (SourceMethod.SetCompilerGenerated): Likewise.
4170 2008-06-11 Marek Safar <marek.safar@gmail.com>
4172 * codegen.cs, driver: Only write symbol file when it's asked for.
4174 2008-06-11 Marek Safar <marek.safar@gmail.com>
4176 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4178 2008-06-10 Martin Baulig <martin@ximian.com>
4180 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4182 2008-06-09 Marek Safar <marek.safar@gmail.com>
4184 A fix for bug #316290
4185 * expression.cs: Include decimal operators in predefined table.
4187 * parameters.cs: More readonlyness.
4189 2008-06-09 Marek Safar <marek.safar@gmail.com>
4191 A fix for bug #397213
4192 * cs-parser.jay: One more missing current_local_parameters reset.
4194 2008-06-09 Marek Safar <marek.safar@gmail.com>
4196 A fix for bug #396633
4197 * class.cs: Host backing field in partial container.
4199 2008-06-09 Marek Safar <marek.safar@gmail.com>
4201 A fix for bug #397068
4202 * expression.cs: Check both operand types when predefined operator is used.
4204 2008-06-05 Martin Baulig <martin@ximian.com>
4206 Merged the `debugger-kahalo' branch.
4209 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4210 we're an iterator method.
4211 (SourceMethod): Reflect latest symbol writer changes;
4212 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4213 now `start_row' and `end_row'.
4214 (Constructor.Emit): Fix the logic whether to emit symbol information.
4216 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4220 (CompilationUnit): New public class; derives from `SourceFile'.
4221 (SourceFileEntry.DefineSymbolInfo): New public method.
4222 (SourceFileEntry.SetChecksum): New public method.
4223 (Location): Encode hidden line numbers by using `column == 255';
4224 the .ctor now accepts `column == -1' to mark a hidden line number.
4225 (Location.Hidden): New public property.
4226 (Location.CheckPoint): Add `CompilationUnit'.
4227 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4228 (Location.Push): Add `CompilationUnit compile_unit' argument.
4229 (Location.CompilationUnit): New public property.
4232 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4234 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4236 * driver.cs: `SourceFile' -> `CompilationUnit'.
4238 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4240 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4242 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4246 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4247 new symbol writer API to also pass the file.
4249 2008-06-05 Marek Safar <marek.safar@gmail.com>
4251 * statement.cs: Emit catch variable assignment using variable expression.
4253 2008-06-05 Marek Safar <marek.safar@gmail.com>
4255 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4256 with other variable types.
4258 2008-06-04 Marek Safar <marek.safar@gmail.com>
4260 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4261 GetLength method emit, it breaks resolve rules.
4263 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4264 Marek Safar <marek.safar@gmail.com>
4266 A fix for bug #395542
4267 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4270 2008-06-02 Marek Safar <marek.safar@gmail.com>
4272 A fix for bug #395287
4273 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4275 2008-05-31 Marek Safar <marek.safar@gmail.com>
4277 A fix for bug #395845
4278 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4279 non-nullable parameter type.
4281 2008-05-31 Marek Safar <marek.safar@gmail.com>
4283 * class.cs: Handle contructor initializer as a statement in top-level block.
4285 2008-05-30 Marek Safar <marek.safar@gmail.com>
4287 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4288 security attributes.
4290 2008-05-24 Marek Safar <marek.safar@gmail.com>
4292 * ecore.cs, expression.cs: Small IVariable refactoring.
4294 2008-05-22 Marek Safar <marek.safar@gmail.com>
4296 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4298 2008-05-21 Marek Safar <marek.safar@gmail.com>
4300 * cs-parser.jay: Removed redundant catch type check.
4302 2008-05-21 Marek Safar <marek.safar@gmail.com>
4304 A fix for bug #390372
4305 * nullable.cs: Set correct return type.
4307 2008-05-21 Marek Safar <marek.safar@gmail.com>
4309 A fix for bug #391062
4310 * typemanager.cs: Fixed crash when comparing null types.
4312 2008-05-21 Marek Safar <marek.safar@gmail.com>
4314 A fix for bug #391871
4315 * cs-parser.jay: Better error handling for invalid catch type.
4317 2008-05-20 Marek Safar <marek.safar@gmail.com>
4319 A fix for bug #392155
4320 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4322 2008-05-15 Marek Safar <marek.safar@gmail.com>
4324 A fix for bug #390666
4325 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4328 2008-05-15 Marek Safar <marek.safar@gmail.com>
4330 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4333 2008-05-13 Marek Safar <marek.safar@gmail.com>
4335 A fix for bug #389625
4336 * delegate.cs, generic.cs: Some progress on method group return type
4339 2008-05-13 Marek Safar <marek.safar@gmail.com>
4341 A fix for bug #378419
4342 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4344 2008-05-12 Marek Safar <marek.safar@gmail.com>
4346 * class.cs (Constructor): Added IsCompilerGenerated.
4348 2008-05-12 Marek Safar <marek.safar@gmail.com>
4350 * expression.cs: Enum binary operators can accept non-enum operand only when
4351 is implicitly convertible to underlying type.
4353 2008-05-12 Marek Safar <marek.safar@gmail.com>
4355 A fix for bug #389272
4356 * support.cs: Workaround System.InvalidOperationException for enums.
4358 2008-05-12 Marek Safar <marek.safar@gmail.com>
4360 A fix for bug #389073
4361 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4363 2008-05-10 Marek Safar <marek.safar@gmail.com>
4365 * driver.cs: Split Parse.
4367 * location.cs (LookupFile): Uses string.Empty.
4369 2008-05-07 Marek Safar <marek.safar@gmail.com>
4371 * expression.cs, parameter.cs: Small ParameterReference clean up.
4373 2008-05-07 Marek Safar <marek.safar@gmail.com>
4375 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4376 hack. Fixes #387502.
4378 2008-05-06 Martin Baulig <martin@ximian.com>
4380 * class.cs (Constructor.Emit): Fix the logic whether to emit
4383 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4386 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4387 InvalidOperationException when the iterator is before the start or
4390 2008-05-06 Marek Safar <marek.safar@gmail.com>
4392 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4393 when left is nullable type.
4395 2008-05-06 Marek Safar <marek.safar@gmail.com>
4397 A fix for bug #386628
4398 * expression.cs (LocalVariableReference): Continue in resolving when
4399 variable is not assigned.
4401 2008-05-05 Marek Safar <marek.safar@gmail.com>
4403 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4404 nullable operations.
4406 2008-05-04 Marek Safar <marek.safar@gmail.com>
4408 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4409 it saves many redundant temporary variables for nullable operations.
4411 2008-05-03 Marek Safar <marek.safar@gmail.com>
4413 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4415 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4418 * nullable.cs: Constant coalescing operator optimizations.
4420 2008-05-03 Marek Safar <marek.safar@gmail.com>
4422 * constant.cs: Use unsigned conversion for values which are unsigned only.
4424 2008-05-03 Marek Safar <marek.safar@gmail.com>
4426 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4427 coalescing operator as it should be.
4429 2008-05-02 Marek Safar <marek.safar@gmail.com>
4431 A fix for bug #371016
4432 * expression.cs: All predefined delegate operators require implicit method
4435 2008-05-02 Marek Safar <marek.safar@gmail.com>
4437 * constant.cs: Emit long constant as uint when fits the range.
4439 * convert.cs, expression.cs: Fixed few unsafe conversions.
4441 2008-05-02 Marek Safar <marek.safar@gmail.com>
4443 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4445 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4448 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4450 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4452 2008-05-01 Marek Safar <marek.safar@gmail.com>
4454 * constant.cs, literal.cs: IsLiteral property for error reporting.
4456 * ecore.cs, expression.cs: Implemented Property expression.
4458 2008-05-01 Marek Safar <marek.safar@gmail.com>
4460 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4462 * nullable.cs: Implemented nullable coalescing null operator.
4464 * ecore.cs, expression.cs: Expression trees work.
4466 2008-05-01 Marek Safar <marek.safar@gmail.com>
4468 * ecore.cs: CreateExpressionTree is finally abstract.
4470 * expression.cs, linq.cs: Updated.
4472 2008-05-01 Marek Safar <marek.safar@gmail.com>
4474 * expression.cs, ecore.cs: Block base access expression inside expression
4477 2008-05-01 Marek Safar <marek.safar@gmail.com>
4479 A fix for bug #385058
4480 * expression.cs: User-defined operator implementations always take
4481 precedence over predefined operator implementations.
4483 2008-04-30 Marek Safar <marek.safar@gmail.com>
4485 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4486 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4487 expression tree conversions.
4489 2008-04-30 Marek Safar <marek.safar@gmail.com>
4491 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4492 operators method details to Operator class.
4494 2008-04-30 Marek Safar <marek.safar@gmail.com>
4496 * anonymous.cs: Pass unsafe flags to anonymous container.
4498 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4499 inside expression tree.
4501 2008-04-29 Martin Baulig <martin@ximian.com>
4503 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4504 (Tokenizer.PopPosition): Also restore the `line'.
4506 2008-04-29 Marek Safar <marek.safar@gmail.com>
4508 * delegate.cs: Implemented Invoke expression.
4510 2008-04-29 Marek Safar <marek.safar@gmail.com>
4512 * expression.cs: Fixed equality reference comparison regression.
4514 2008-04-29 Marek Safar <marek.safar@gmail.com>
4516 * ecore.cs: Clean up EmptyCast hack.
4518 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4519 using correct conversion rules. Also fixes #383993.
4521 2008-04-28 Martin Baulig <martin@ximian.com>
4523 * class.cs (Constructor.Emit): Don't emit debugging information
4524 for generated default .ctor's.
4526 2008-04-28 Marek Safar <marek.safar@gmail.com>
4528 * convert.cs: Empty-cast ushort to int conversion.
4530 2008-04-28 Marek Safar <marek.safar@gmail.com>
4532 A fix for bug #384191
4533 * ecore.cs, expression.cs: Fixed expression cloning.
4535 2008-04-28 Marek Safar <marek.safar@gmail.com>
4537 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4539 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4541 Fix #381559, test-638.cs, test-639.cs
4542 * assign.cs (CompoundAssign.Helper): New wrapper.
4543 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4545 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4546 Pass unconverted expressions to the params array creation expression.
4547 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4548 (PropertyExpr.EmitAssign): Likewise.
4549 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4550 element if it is of kind CompoundAssign.Helper.
4551 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4552 first before anything else.
4553 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4554 (ArrayAccess.LoadArrayAndArguments): Simplify.
4556 2008-04-27 Marek Safar <marek.safar@gmail.com>
4558 * expression.cs: Fixed cloning of typeof(void).
4560 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4562 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4563 (Assign.Emit): Likewise. Move it to ...
4564 (CompoundAssign.DoResolve): ... here and ...
4565 (CompoundAssign.Emit): ... here.
4566 (EventAddOrRemove): New helper to handle += and -= on events, and
4567 avoid the use of BinaryDelegates.
4568 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4569 (EventExpr.EmitAddOrRemove): Improve.
4570 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4572 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4573 create VarExprs for 'foo.bar.var'.
4574 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4575 is a highly inappropriate name for its functionality.
4577 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4579 Simplify handling of multiple assignments
4580 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4582 (SimpleAssign): New. Class to be used for normal assignments.
4583 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4584 * expression.cs, parameter.cs, statement.cs: Likewise.
4586 2008-04-25 Marek Safar <marek.safar@gmail.com>
4588 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4589 for incompatible underlying types, more to come, uff.
4591 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4594 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4595 Handle 'leave_copy'.
4597 2008-04-25 Marek Safar <marek.safar@gmail.com>
4599 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4601 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4603 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4604 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4605 * statement.cs (While, Do, For): Allow test to have side effects.
4606 (For.DoEmit): Always emit InitStatement.
4609 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4610 Always create SideEffectConstant.
4611 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4612 of type EnumConstant.
4614 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4615 Handle 'right' being SideEffectConstant of type 'bool'.
4617 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4618 Use left.EmitBranchable instead of open coding it, so as to
4619 improve optimization opportunities.
4621 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4623 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4625 (Expression.EmitSideEffect): Document.
4627 2008-04-23 Marek Safar <marek.safar@gmail.com>
4629 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4631 2008-04-23 Marek Safar <marek.safar@gmail.com>
4633 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4635 2008-04-23 Marek Safar <marek.safar@gmail.com>
4637 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4638 conversion to expression tree.
4640 2008-04-23 Marek Safar <marek.safar@gmail.com>
4642 * ecore.cs: Removed unused expression.
4644 2008-04-22 Marek Safar <marek.safar@gmail.com>
4646 * expression.cs: Implemented NegateChecked and New expressions.
4648 2008-04-22 Marek Safar <marek.safar@gmail.com>
4650 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4652 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4655 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4656 needing final 'ret' instruction.
4658 2008-04-22 Marek Safar <marek.safar@gmail.com>
4660 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4662 2008-04-21 Marek Safar <marek.safar@gmail.com>
4664 * expression.cs: Emit ldnull and not null expression as an instance argument
4665 of static method expression calls.
4667 2008-04-21 Marek Safar <marek.safar@gmail.com>
4669 A fix for bug #378200
4670 * expression.cs: Fixed crash when creating parameterless expression tree
4673 2008-04-21 Marek Safar <marek.safar@gmail.com>
4675 A fix for bug #375297
4676 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4679 2008-04-21 Marek Safar <marek.safar@gmail.com>
4681 A fix for bug #377596
4682 * decl.cs, class.cs: Emit delegate type argument attributes.
4684 2008-04-21 Marek Safar <marek.safar@gmail.com>
4686 A fix for bug #365314
4687 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4689 2008-04-21 Marek Safar <marek.safar@gmail.com>
4691 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4694 2008-04-21 Marek Safar <marek.safar@gmail.com>
4696 * generic.cs (TypeParameter): Removed redundant location.
4698 2008-04-19 Marek Safar <marek.safar@gmail.com>
4700 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4701 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4702 FullNamedExpression in all declaration type expression, statements will come
4705 2008-04-18 Marek Safar <marek.safar@gmail.com>
4707 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4708 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4710 2008-04-18 Marek Safar <marek.safar@gmail.com>
4712 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4715 2008-04-17 Marek Safar <marek.safar@gmail.com>
4717 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4720 2008-04-17 Marek Safar <marek.safar@gmail.com>
4722 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4726 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4728 Hook up 'EmitSideEffect'
4729 * constant.cs (Constant.EmitSideEffect): New.
4730 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4731 (SideEffectConstant.EmitSideEffect): New.
4732 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4733 unconditional branch in EmitBranchable.
4734 (FieldExpr.EmitBranchable): New.
4735 * expression.cs (Unary.EmitSideEffect): New.
4736 (Binary.EmitSideEffect): New.
4737 (VariableReference.EmitSideEffect): New. Do nothing.
4739 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4741 Introduce 'EmitSideEffect'
4742 * ecore.cs (Expression.EmitSideEffect): New.
4743 (TypeCast): Rename from EmptyCast.
4745 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4746 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4747 * convert.cs, nullable.cs: Update to changes.
4749 2008-04-16 Marek Safar <marek.safar@gmail.com>
4751 * class.cs, cs-parser.jay: Early check for base types expression.
4753 2008-04-16 Marek Safar <marek.safar@gmail.com>
4755 * decl.cs (MemberName): Declare PrettyName as obsolete.
4757 2008-04-16 Marek Safar <marek.safar@gmail.com>
4759 * namespace.cs: Use MemberName comparison.
4761 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4764 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4766 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4767 (MemberName.FullyQualifiedName): New. Provides the functionality
4768 that users assume FullName would have.
4769 * ecore.cs, namespace.cs: Update to changes.
4771 * statement.cs (Using.assign): Make into ExpressionStatement.
4772 (Using.EmitPreTryBody): Simplify.
4774 2008-04-16 Marek Safar <marek.safar@gmail.com>
4776 * report.cs: ColorFormat is protected.
4778 * rootcontext.cs: Unused fields clean-up.
4780 * namespace.cs: Made UsingEntry name private.
4782 2008-04-16 Marek Safar <marek.safar@gmail.com>
4784 * cs-tokenizer.cs, location.cs: Removed unused field.
4786 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4787 Raja R Harinath <harinath@hurrynot.org>
4790 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4791 (SideEffectConstant.side_effect): Rename from 'right'.
4792 (SideEffectConstant..ctor): Normalize 'side_effect'.
4793 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4794 value of this constant.
4795 * cfold.cs: Update to changes.
4797 2008-04-15 Marek Safar <marek.safar@gmail.com>
4799 * cs-paser.jay: Removed unused variable.
4801 * driver.cs: Made Compile instance method.
4803 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4805 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4807 2008-04-15 Marek Safar <marek.safar@gmail.com>
4809 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4811 2008-04-13 Jb Evain <jbevain@novell.com>
4813 * namespace.cs: update the System.Core fullname for 2.1
4814 * driver.cs: update the list of required assemblies for 2.1.
4815 Merged from the Moonlight 2 branch.
4817 2008-04-11 Marek Safar <marek.safar@gmail.com>
4819 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4820 types and user defined operators. User operators arguments has to be checked
4821 for null value before invocation, which also means no operator is called
4822 when any argument is not convertible to unwrapped nullable type.
4824 2008-04-09 Marek Safar <marek.safar@gmail.com>
4826 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4827 of Unary expressions to follow operator overloading rules precisely.
4828 Also fixes #321794, #323794
4830 2008-04-08 Marek Safar <marek.safar@gmail.com>
4832 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4835 2008-04-08 Marek Safar <marek.safar@gmail.com>
4837 * expression.cs, ecore.cs: Implemented MemberInit expression.
4839 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4841 Fix mono/tests/exception4.cs
4842 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4843 ec.NeedReturnLabel () rather emitting a 'nop'.
4845 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4847 (TryCatch.SomeCodeFollows): Likewise.
4848 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4849 for 'break', 'continue' and 'return' statements inside a try.
4850 We're fairly sure that the generated IL stream will have more
4851 instructions textually following the try.
4852 (FlowBranchingTryCatch): Likewise.
4854 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4855 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4858 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4859 wrapper -- forward everything to CollectionForeach.
4860 (CollectionForeach.NonDisposableWrapper): New.
4861 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4862 instead of a pop + branch to end.
4864 2008-04-07 Marek Safar <marek.safar@gmail.com>
4866 A fix for bug #377485
4867 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4868 Propagate location for extension method groups. Report conversion failure at
4871 2008-04-07 Marek Safar <marek.safar@gmail.com>
4873 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4874 ListInit and Field expressions.
4876 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4878 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4879 Since $PC is always -1 inside the body of MoveNext, the fault
4881 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4882 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4883 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4885 The denouement! Fix #324708
4886 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4887 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4888 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4889 'finally' inside the finally clause.
4891 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4892 inside an iterator. Don't emit the body of the 'finally' inside
4893 the finally clause yet.
4895 Use the ResumableStatement infrastructure for MoveNext ()
4896 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4897 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4898 'old_resume_points'. Move dispatcher upfront.
4899 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4900 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4901 in an enumerator. This encodes the main fix in this patch series
4902 -- we can only jump into the first instruction of a try from the
4903 outside, but we want to emit try/finally regions in iterators and
4904 resume in the middle of them.
4906 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4908 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4909 of NeedReturnLabel here.
4911 Introduce a common point for emitting try/finally to IL
4912 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4913 features of the various subclasses, which are now driven by ...
4914 (ExceptionStatement.EmitPreTryBody): ... this and ...
4915 (ExceptionStatement.EmitTryBody): ... this and the original
4917 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4918 Remove DoEmit and update to follow above protocol.
4920 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4921 of the dispatcher are the same, skip emitting the 'switch'.
4922 * iterator.cs (Iterator.EmitDispose): Update to changes.
4924 Clean up handling of 'using' statement
4925 * statement.cs (UsingTemporary): New. Carved out of ...
4926 (Using): ... this. Simplify drastically. Handle exactly
4928 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4929 or Using as appropriate. If there are multiple variable declared,
4930 create nested Using statements.
4931 (resource_acquisition): Kill.
4933 * statement.cs (ExceptionStatement.EmitForDispose): Use
4934 EmitFinallyBody, not EmitFinally.
4936 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4937 * iterator.cs: Update to changes.
4939 Start using the ResumableStatement infrastructure
4940 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4941 (ResumableStatement.EmitForDispose): New.
4942 (ExceptionStatement): Override them.
4943 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4944 EmitForDispose to create the body of the Dispose method. Don't
4947 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4948 * statement.cs (Toplevel.AddResumePoint): ... here.
4949 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4950 * flowanalysis.cs (FlowBranchingIterator): New.
4951 * codegen.cs (EmitContext): Update to changes.
4953 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4954 (Iterator.old_resume_points): Rename from 'resume_points'.
4955 (Iterator.MoveNextStatement): Remove unused class.
4957 New infrastructure for try/finally in iterators (still unused)
4958 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4959 (FlowBranchingToplevel.AddResumePoint): Hook into
4960 ToplevelBlock.AddResumePoint.
4961 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4962 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4963 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4964 resume points and assign program-counter values.
4965 (ExceptionBlock.AddResumePoint): Collect resume points for
4966 de-muxer at the top of try block.
4967 * iterators.cs (Yield.CheckContext): Simplify.
4968 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4970 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4972 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4973 argument to an ExitStatement.
4974 (FlowBranchingException): Refactor saved origins code.
4975 * statement.cs (ExitStatement): Update to cahges.
4976 * iterator.cs (YieldBreak): Likewise.
4978 * statement.cs (ResumableStatement): New. Common base class for
4979 YieldReturn and ExceptionStatement.
4980 (ExitStatement): New. Common base class for Return and YieldBreak.
4981 (Return): Update to changes.
4982 * iterator.cs (YieldBreak): Likewise.
4983 * lambda.cs (ContextualReturn): Likewise.
4986 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4987 emit a meaningful error message.
4989 Fix #324765, #319508
4990 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4991 (VariableInfo.SetAssigned): Set it.
4992 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4993 determine if CS0219 or CS0168 is appropriate. Don't use
4994 flow-analysis information.
4995 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4996 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4997 (EmitContext.EndFlowBranching): ... this.
4999 2008-04-03 Marek Safar <marek.safar@gmail.com>
5001 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5003 2008-04-03 Marek Safar <marek.safar@gmail.com>
5005 A fix for bug #376508
5006 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5007 ImplicitConversionExists.
5009 2008-04-03 Marek Safar <marek.safar@gmail.com>
5011 * expression.cs (Binary): Added remaining binary operators to expression
5014 * nullable.cs: Optimize shift with null argument.
5016 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5018 Fix minor IL regression
5019 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5020 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5021 * cs-parser.jay (try_statement): Update to changes.
5023 * statement.cs (TryFinally.need_exc_block): Delete.
5024 (TryFinally): Update to changes.
5026 Now all ExceptionStatements are unconditional
5027 * statement.cs (CollectionForeach.DisposableWrapper): New.
5028 Extract out the try/finally code into a new wrapper.
5029 (CollectionForeach.Resolve): Use it to simplify the code.
5031 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5033 Start at simplifying ExceptionStatement semantics a bit
5034 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5035 * cs-parser.jay (try_statement): Update to changes.
5036 (opt_catch_clauses): Remove.
5037 * flowanalysis.cs: Update to changes.
5038 (FlowBranching.BranchingType.TryCatch): New.
5039 (FlowBranchingTryCatch): New.
5041 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5042 (FlowBranching.CreateBranching): Update to changes.
5043 (FlowBranchingBlock.AddSibling): Add sanity check.
5044 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5047 * iterators.cs (Iterator.MarkFinally): Remove.
5048 * statement.cs (ExceptionStatement): Update to changes.
5050 Add support for skipping over finally blocks at runtime. First
5051 in a series to fix #324708
5052 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5053 (Iterator.EmitMoveNext): Initialize it.
5054 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5055 branch over the body of the 'finally' clause.
5057 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5059 Avoid lopsided use of Foo/DoFoo names
5060 * statement.cs (ExpressionStatement.EmitFinallyBody):
5061 Rename from EmitFinally.
5062 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5063 * iterator.cs: Update to changes.
5065 2008-04-02 Marek Safar <marek.safar@gmail.com>
5067 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5068 based on UserOperatorCall. More binary nullable operators clean up.
5070 2008-04-02 Martin Baulig <martin@ximian.com>
5072 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5074 2008-04-02 Marek Safar <marek.safar@gmail.com>
5076 * nullable.cs: Merge user and empty conversions when lifting expression
5079 * expression.cs (StringConcat): Implemented expression tree representation.
5081 2008-04-01 Marek Safar <marek.safar@gmail.com>
5083 * nullable.cs: When lifting null literal and a user operator exists, no call
5086 2008-04-01 Marek Safar <marek.safar@gmail.com>
5088 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5091 2008-04-01 Marek Safar <marek.safar@gmail.com>
5093 * nullable.cs, expression.cs: Use namespace instead heavily nested
5094 monster abstract class.
5096 2008-04-01 Marek Safar <marek.safar@gmail.com>
5098 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5099 lifting of null literal and user operators. Clean up of some temporary
5102 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5104 Fix #368224, test-629.cs
5105 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5106 if it crossed an unwind-protect boundary.
5107 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5108 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5109 inside an unwind-protected region.
5110 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5111 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5112 'leave' instead of a 'br' if unwind-protected.
5113 (Iterator.EmitYieldBreak): Likewise.
5115 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5117 * driver.cs: Only define versioninfo resources if no win32 resource
5120 2008-03-28 Marek Safar <marek.safar@gmail.com>
5122 A fix for bug #372375
5123 * convert.cs: Fixed boxing of nullable types.
5125 2008-03-28 Marek Safar <marek.safar@gmail.com>
5127 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5130 2008-03-28 Marek Safar <marek.safar@gmail.com>
5132 A fix for bug #374619
5133 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5135 2008-03-27 Marek Safar <marek.safar@gmail.com>
5137 * lambda.cs: Check return type only for invocation.
5139 2008-03-27 Marek Safar <marek.safar@gmail.com>
5141 A fix for bug #374214
5142 * ecore.cs: Correctly report argument type mismatch.
5144 2008-03-27 Marek Safar <marek.safar@gmail.com>
5146 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5147 and not rely on broken IsEnum.
5149 2008-03-27 Marek Safar <marek.safar@gmail.com>
5151 * nullable.cs: New file, extracted from generic.cs.
5153 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5155 2008-03-27 Marek Safar <marek.safar@gmail.com>
5157 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5158 predefined comparison operators and null literals.
5160 * report.cs: New warning ID.
5162 2008-03-25 Marek Safar <marek.safar@gmail.com>
5164 A fix for bug #370577
5165 * lambda.cs: Check return type too.
5167 2008-03-25 Marek Safar <marek.safar@gmail.com>
5169 A fix for bug #372846
5170 * class.cs: Automatic properties can be declared as unsafe.
5172 2008-03-20 Marek Safar <marek.safar@gmail.com>
5174 * location.cs: Use string based concatenation.
5176 * expression.cs: LiftedBinaryOperator is gmcs only.
5178 2008-03-20 Marek Safar <marek.safar@gmail.com>
5180 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5181 conversions rules and expression trees.
5183 2008-03-19 Marek Safar <marek.safar@gmail.com>
5185 * delegate.cs: Use extension method source as delegate target.
5187 2008-03-19 Marek Safar <marek.safar@gmail.com>
5189 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5190 binary operations to be purely based on binary operations and optimized
5191 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5192 and other ET refactoring.
5194 * typemanager.cs: Fixed warning.
5196 2008-03-17 Marek Safar <marek.safar@gmail.com>
5198 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5200 * symbolwriter.cs: Fixed.
5202 2008-03-17 Marek Safar <marek.safar@gmail.com>
5204 * anonymous.cs, driver.cs: Reset anonymous types counters.
5206 2008-03-17 Marek Safar <marek.safar@gmail.com>
5208 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5210 * class.cs: Use fullname for all type member definitions.
5212 2008-02-19 Martin Baulig <martin@ximian.com>
5215 (IMethodData.EmitExtraSymbolInfo): New interface method.
5216 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5217 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5218 interface method here as an empty public virtual method.
5221 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5222 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5223 CodeGen.SymbolWriter.SetRealMethodName().
5225 2008-02-18 Martin Baulig <martin@ximian.com>
5228 (ScopeInfo.EmitType): Override this and emit debugging
5229 information for captured variables.
5230 (RootScopeInfo.EmitType): Override this and emit symbol
5231 information for a captured `this'.
5233 2008-02-15 Martin Baulig <martin@ximian.com>
5235 * iterators.cs: Emit debugging info.
5238 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5239 (EmitContext.OmitDebuggingInfo): New public property.
5242 (While): Override Emit() and don't emit symbol info there; do it
5243 inside DoEmit() instead.
5244 (Block.Emit): Omit symbol information while emitting the scope
5245 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5247 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5248 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5249 .ctor to make `IsIterator' work.
5251 2008-03-14 Martin Baulig <martin@ximian.com>
5253 * symbolwriter.cs: Added the new symbol writer function from the
5254 debugger's `terrania' branch; temporarily enclose them inside
5255 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5258 2008-03-14 Martin Baulig <martin@ximian.com>
5261 (SymbolWriter): Make this a public static class.
5264 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5265 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5267 2008-03-14 Marek Safar <marek.safar@gmail.com>
5269 A fix for bug #370577
5270 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5273 2008-03-14 Marek Safar <marek.safar@gmail.com>
5275 * typemanager.cs (CSharpName): Made 250 times faster.
5277 2008-03-13 Marek Safar <marek.safar@gmail.com>
5279 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5281 2008-03-12 Marek Safar <marek.safar@gmail.com>
5283 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5284 crash when predefined field does not exist.
5286 2008-03-12 Marek Safar <marek.safar@gmail.com>
5288 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5290 2008-03-12 Marek Safar <marek.safar@gmail.com>
5292 * class.cs (FixedField): Don't crash when contructors are missing.
5294 2008-03-11 Marek Safar <marek.safar@gmail.com>
5296 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5297 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5298 check internal types accessibility for internal and external types.
5299 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5301 2008-03-11 Marek Safar <marek.safar@gmail.com>
5303 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5304 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5305 attribute.cs, statement: Use corect instance of predefined types (work
5306 related to #364674).
5308 2008-03-07 Marek Safar <marek.safar@gmail.com>
5310 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5312 2008-03-07 Marek Safar <marek.safar@gmail.com>
5314 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5315 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5316 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5317 predefined types clean up, delayed predefined types members initialization
5318 (work related to #364674).
5320 2008-03-05 Marek Safar <marek.safar@gmail.com>
5322 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5324 2008-03-05 Marek Safar <marek.safar@gmail.com>
5326 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5327 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5328 predefined types clean up (work related to #364674).
5330 2008-03-04 Marek Safar <marek.safar@gmail.com>
5332 * ecore.cs: Print an error message instead of throwing exception.
5334 2008-03-04 Marek Safar <marek.safar@gmail.com>
5336 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5337 expression.cs, statement.cs: Unififed null literal representation.
5339 2008-03-03 Marek Safar <marek.safar@gmail.com>
5341 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5342 expression.cs: Refactored binary operators resolve phase and improved speed.
5343 The nullable code is still missing and won't work correctly, more fixes
5346 It also fixes #323726, #324312, #324248, and many other unreported issues.
5348 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5350 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5353 2008-02-27 Marek Safar <marek.safar@gmail.com>
5355 * ecore.cs: Clean-up and split BetterConversion.
5357 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5360 * enum.cs (EnumMember.Value): Only access 'value' if
5361 ResolveValue says it's ok.
5362 (EnumMember.DoResolveValue): Don't set prev_member.value.
5363 (Enum.GetDefinition): Reverse arguments of Equals --
5364 EnumMember.Value can return 'null'.
5366 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5368 2008-02-22 Marek Safar <marek.safar@gmail.com>
5370 * generic.cs, expression.cs: More ongoing work on expression trees.
5372 2008-02-21 Marek Safar <marek.safar@gmail.com>
5374 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5375 handle missing matches when mutiple operators exist.
5377 2008-02-20 Marek Safar <marek.safar@gmail.com>
5379 A fix for bug #363218
5380 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5383 2008-02-20 Marek Safar <marek.safar@gmail.com>
5385 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5386 update. This time to deal correctly with SideEffectConstant expression used
5387 as an argument for another constant folding.
5389 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5391 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5394 2008-02-19 Marek Safar <marek.safar@gmail.com>
5396 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5398 2008-02-19 Marek Safar <marek.safar@gmail.com>
5400 A fix for bug #328136
5401 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5402 side is a false constant, because we still need to evaluate the right-hand
5405 * statement.cs (If): Emit two types of boolean constants (simple constant,
5406 side-effect constant).
5408 2008-02-19 Marek Safar <marek.safar@gmail.com>
5410 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5412 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5415 2008-02-18 Marek Safar <marek.safar@gmail.com>
5417 A fix for bug #361457
5418 * ecore.cs (IsApplicable): Params methods have lower priority.
5420 * support.cs: Return correct parameter modifier for params types.
5422 2008-02-18 Marek Safar <marek.safar@gmail.com>
5424 * generic.cs (TypeParameter): Cache attribute target name.
5426 * support.cs: Removed unused variable.
5428 * typemanager.cs: Removed debugging leftover.
5430 * ecore.cs: Use local type instead of a property;
5432 * class.cs (VerifyMembers): Consider also parent to test whether type member
5435 * expression.cs (FullMethodDesc): Removed.
5437 * attribute.cs (IsValidArgumentType): Made static.
5439 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5441 Cleanup to be more readable.
5442 * Makefile (GMCS_PROFILE): Remove.
5443 (COMPILER_NAME): New helper.
5445 2008-02-15 Miguel de Icaza <miguel@novell.com>
5447 * cs-tokenizer.cs: if a conditional expression happens inside a
5448 (...) this also means that we do not need to de-ambiguate between
5449 an parenthesized expression and a cast.
5453 * constant.cs (SideEffectConstant): a constant value that happens
5454 to have a side effect.
5456 Fixes the build regressions introduced by the fix for #359789
5458 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5460 * expression.cs (Conditional.Emit): when emitting the ternary
5461 operator, use local variables to generate code verifiable code.
5463 The verifier cannot infer that the type on stack before the
5464 stloc.0 is executed is of type ParentB. This happens because the
5465 stack merge algorithm uses only parent types when deciding which
5466 is the common type. This is described in Part III 1.8.1.3 of ECMA
5469 This code compiled with mcs is not verifiable under MS. The MS
5470 verifier picks the first common interface of Foo and Bar, which is
5471 wrong, but doesn't use a full join type of the 2 interfaces.
5473 CSC uses a clever hack to compile such code in a verifiable
5474 way. It stores the intermediate values in a local variable with
5479 2008-02-14 Miguel de Icaza <miguel@novell.com>
5481 * expression.cs: Do not fold BitwiseAnd operators when the left
5482 side is a false constant, because we still need to evaluate the
5487 * support.cs: Instead of throwing an InternalErrorException when
5488 the position of the stream is outside the boundary of our buffer,
5489 reset the state of the reader, and restart the reading from the
5490 beginning of the file.
5492 2008-02-14 Marek Safar <marek.safar@gmail.com>
5494 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5496 2008-02-14 Marek Safar <marek.safar@gmail.com>
5498 A fix for bug #361686
5499 * decl.cs: A protected types used inside a private class which parents
5500 derives from the protected class are accessible.
5502 2008-02-13 Marek Safar <marek.safar@gmail.com>
5504 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5505 the parameterless constructor.
5507 2008-02-13 Marek Safar <marek.safar@gmail.com>
5509 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5510 lookup methods to use standard member cache when doing member lookup.
5512 2008-02-12 Marek Safar <marek.safar@gmail.com>
5514 * driver.cs: Don't report full path for referenced module as assembly error.
5516 2008-02-12 Marek Safar <marek.safar@gmail.com>
5518 * Makefile: Fixed `qh' target to work on all machines.
5520 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5521 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5522 and HasElementType with TypeManager implementation.
5524 2008-02-08 Marek Safar <marek.safar@gmail.com>
5526 A fix for bugs #325134, #359749
5527 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5528 first binds point to non-method member expression.
5530 2008-02-08 Marek Safar <marek.safar@gmail.com>
5532 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5534 2008-02-08 Marek Safar <marek.safar@gmail.com>
5536 A fix for bugs #321394, #323028
5537 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5538 Reworked naive IsAccessibleAs implementation to handle nested types.
5540 2008-02-05 Jb Evain <jbevain@novell.com>
5542 * class.cs: use generic type comparison for parameters
5545 2008-02-05 Marek Safar <marek.safar@gmail.com>
5547 A fix for bug #325372
5548 * class.cs: Use generic type comparison when testing method signatures.
5550 2008-02-05 Marek Safar <marek.safar@gmail.com>
5552 A fix for bug #357047
5553 * ecore.cs: Applied C# 3.0 changes to better conversion.
5555 2008-02-05 Marek Safar <marek.safar@gmail.com>
5557 A fix for bug #358374
5558 * cs-parser.jay: Correctly set modifiers for all constructor types.
5560 2008-02-04 Marek Safar <marek.safar@gmail.com>
5562 A fix for bug #355251
5563 * generic.cs: Added base class constraint based type inference.
5565 2008-02-01 Marek Safar <marek.safar@gmail.com>
5567 A fix for bug #357255
5568 * decl.cs: One more missing visibility check.
5570 2008-02-01 Marek Safar <marek.safar@gmail.com>
5572 * support.cs: Fixed broken return.
5574 2008-01-25 Marek Safar <marek.safar@gmail.com>
5576 * report.cs: Correctly reset warnings count after probing.
5578 2008-01-25 Martin Baulig <martin@ximian.com>
5581 (NamespaceEntry.SymbolFileID): Make this work again after
5582 MemberName.ToString() is gone.
5584 2008-01-25 Marek Safar <marek.safar@gmail.com>
5586 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5589 2008-01-25 Marek Safar <marek.safar@gmail.com>
5591 * generic.cs: Use full implicit conversion for type inference fixing.
5593 2008-01-24 Marek Safar <marek.safar@gmail.com>
5595 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5596 Fixed user operator conversions.
5598 2008-01-24 Marek Safar <marek.safar@gmail.com>
5600 * generic.cs: Do nullable type to null comparison optimization during
5603 2008-01-24 Marek Safar <marek.safar@gmail.com>
5605 A fix for bug #355163
5606 * generic.cs: Enabled l-value resolve on nullable expressions.
5608 2008-01-24 Marek Safar <marek.safar@gmail.com>
5610 A fix for bug #353986
5611 * class.cs: Ingore static ctors with parameters for any further checks.
5613 2008-01-24 Marek Safar <marek.safar@gmail.com>
5615 A fix for bug #354310
5616 * namespace.cs: Removed redundant check.
5618 2008-01-24 Marek Safar <marek.safar@gmail.com>
5620 A fix for bug #354928
5621 * expression.cs: ElementInitializers can be resolved only once.
5623 2008-01-24 Marek Safar <marek.safar@gmail.com>
5625 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5626 Condition expressions.
5628 2008-01-23 Marek Safar <marek.safar@gmail.com>
5630 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5632 2008-01-22 Marek Safar <marek.safar@gmail.com>
5634 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5637 * generic.cs: Implemented coalesce expression.
5639 2008-01-22 Marek Safar <marek.safar@gmail.com>
5641 A fix for bug #355145
5642 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5643 expression tree type inference.
5645 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5648 * expression.cs (Binary.IsUnsignedType): Fix typo.
5650 2008-01-22 Marek Safar <marek.safar@gmail.com>
5652 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5654 2008-01-22 Marek Safar <marek.safar@gmail.com>
5656 A fix for bug #355161
5657 * ecore.cs, expression.cs: Wider range of extension method supported
5660 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5662 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5663 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5666 2008-01-22 Marek Safar <marek.safar@gmail.com>
5668 A fix for bug #355148
5669 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5671 2008-01-22 Miguel de Icaza <miguel@novell.com>
5673 * expression.cs (CreateExpressionTree): Add support for or and
5674 logical or, and indent following the coding conventions.
5676 * typemanager.cs (LinqExpression): renamed from
5677 ExpressionTreeManager, for a shorter name.
5679 Use TypeManager.CoreLookupType to lookup types from our core
5680 assemblies and turn those into "Type" variables.
5682 Consumers that previously used "Namespace" and "Type" from this
5683 class should instead use the TypeExpression which is a type that
5684 is fully resolved (without involving the regular C# resolution
5687 This typically looks like this:
5689 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5690 new MemberAccess (texpr, name, type_arguments, loc)
5692 This avoids the problem in: #355178
5694 2008-01-21 Marek Safar <marek.safar@gmail.com>
5696 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5697 feature in parser only as we do in other cases.
5699 2008-01-21 Marek Safar <marek.safar@gmail.com>
5701 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5702 typemanager.cs: A refactoring of params arguments to reuse existing
5703 expressions (params -> array initializer) to emit params argument instead
5704 of specialized handling.
5705 It was required by expression tree implementation and it has other benefits
5706 as well, we now apply same optimization for params arguments as we do for
5709 2008-01-18 Marek Safar <marek.safar@gmail.com>
5711 A fix for bug #353526
5712 * generic.cs: A type inference of params arguments may not required any
5713 temporary array creation.
5715 2008-01-18 Marek Safar <marek.safar@gmail.com>
5717 A fix for bug #353534
5718 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5719 supported for delegates only.
5721 2008-01-18 Marek Safar <marek.safar@gmail.com>
5723 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5724 type for more than 1 candidates.
5726 2008-01-18 Marek Safar <marek.safar@gmail.com>
5728 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5731 2008-01-16 Marek Safar <marek.safar@gmail.com>
5733 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5734 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5735 operator) expressions.
5737 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5739 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5740 not accessed from the generated IL.
5742 2008-01-14 Marek Safar <marek.safar@gmail.com>
5744 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5745 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5746 statement.cs: The first expression tree implementation drop, mostly
5747 infrastructure work.
5749 2008-01-14 Marek Safar <marek.safar@gmail.com>
5751 * ecore.cs (IsNestedChild): Refactored.
5753 2008-01-11 Marek Safar <marek.safar@gmail.com>
5755 * lambda.cs: Don't use a cast on unknown expression statement.
5757 2008-01-10 Geoff Norton <gnorton@novell.com>
5759 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5762 2008-01-09 Marek Safar <marek.safar@gmail.com>
5764 * doc.cs: Report better /doc crash details.
5766 2008-01-09 Marek Safar <marek.safar@gmail.com>
5768 A fix for bug #352536
5769 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5771 2008-01-08 Marek Safar <marek.safar@gmail.com>
5773 A fix for bug #352287
5774 * ecore.cs, expression.cs: Do `this' access checking in all member access
5777 2008-01-08 Marek Safar <marek.safar@gmail.com>
5779 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5781 * report.cs: Reset message stacks.
5783 2008-01-08 Marek Safar <marek.safar@gmail.com>
5785 * generic.cs (InferInPhases): Correctly calculate params position.
5787 2008-01-08 Marek Safar <marek.safar@gmail.com>
5789 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5792 2008-01-07 Marek Safar <marek.safar@gmail.com>
5794 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5796 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5798 * driver.cs: Updated --help option.
5800 2008-01-07 Marek Safar <marek.safar@gmail.com>
5802 * generic.cs (InferParamsTypeArguments): Removed.
5803 (InferInPhases): Add params type inference.
5804 (LowerBoundInference): Fixed scoring mechanism.
5806 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5808 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5810 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5811 byte array for unsigned "baked" assemblies.
5813 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5815 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5816 array for assemblies that are not strongnamed.
5818 2008-01-04 Marek Safar <marek.safar@gmail.com>
5820 A fix for bug #351481
5821 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5822 declaring type for nested generic types.
5824 2008-01-04 Marek Safar <marek.safar@gmail.com>
5826 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5827 instead of ToString.
5829 2008-01-03 Marek Safar <marek.safar@gmail.com>
5831 A fix for bug #351047
5832 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5833 null and structs only when equality and inequality operators are defined
5834 either as an user-operators or predefined operators.
5836 2008-01-03 Marek Safar <marek.safar@gmail.com>
5838 A fix for bug #351047
5839 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5841 2008-01-03 Marek Safar <marek.safar@gmail.com>
5843 A fix for bug #351257
5844 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5846 2008-01-03 Marek Safar <marek.safar@gmail.com>
5848 A fix for bug #351157
5849 * class.cs (Using): Fixed yet another broken cloning.
5851 (Block): Put back more sensible default value for statements.
5853 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5855 * codegen.cs: Allow AssemblyVersion with only major version component.
5858 2007-12-29 Marek Safar <marek.safar@gmail.com>
5860 A fix for bug #324654
5861 * class.cs: Use FullName property as member name.
5863 2007-12-28 Marek Safar <marek.safar@gmail.com>
5865 A fix for bug #342117
5866 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5867 constructor constraint.
5869 2007-12-28 Marek Safar <marek.safar@gmail.com>
5871 A fix for bug #338273
5872 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5875 2007-12-28 Marek Safar <marek.safar@gmail.com>
5877 A fix for bug #350839
5878 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5880 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5882 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5885 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5887 * statement.cs: Changed some Hashtables to use HybridDictionaries
5888 instead. It was observed that some HashTables only contained a few
5889 items in the vast majority of cases. Since HybridDictionary is
5890 more efficient on small sets (<10 elements), "known_variables"
5891 from class ExplicitBlock as well as "labels" and "constants " from
5892 class Block were changed to HybridDictionaries.
5894 Atsai results: (56216kb->54987kb)
5896 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5899 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5901 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5904 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5906 * expression.cs: foreach loop to for loop, saved on allocation of
5907 enumerator (59333kb->59141kb)
5909 * statement.cs. Changed foreach loops to for loops, saved on
5910 allocation of enumerator (59141kb->59006kb)
5912 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5913 when constructed with no specified capacity. This was causing a
5914 few ArrayLists to allocate more memory than they would potentially
5915 need in the Block class and MemberCache class. Setting the
5916 ArrayLists to construct with a capacity of 1 saves some
5917 memory. (56216kb->55585kb)
5919 2007-12-27 Marek Safar <marek.safar@gmail.com>
5921 A fix for bug #347189 (2nd issue)
5922 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5925 2007-12-27 Miguel de Icaza <miguel@novell.com>
5927 * report.cs: Do not use colors if stdout and stderr are not a
5930 2007-12-27 Marek Safar <marek.safar@gmail.com>
5932 A fix for bug #346998
5933 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5936 2007-12-27 Marek Safar <marek.safar@gmail.com>
5938 A fix for bug #343465
5939 * class.cs: Explicit method name for nested types uses dots only.
5941 2007-12-27 Marek Safar <marek.safar@gmail.com>
5943 A fix for bug #343707
5944 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5946 2007-12-27 Marek Safar <marek.safar@gmail.com>
5948 * ecore.cs: Report type inference errors only when arguments count matches
5951 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5953 * expression.cs, report.cs: New warning.
5955 * typemanager.cs: Catch anonymous method type too.
5957 2007-12-23 Marek Safar <marek.safar@gmail.com>
5959 A fix for bug #346379
5960 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5962 2007-12-23 Marek Safar <marek.safar@gmail.com>
5964 A fix for bug #347359
5965 * expression.cs (Invocation): Don't resolve already resolved expression.
5967 2007-12-23 Marek Safar <marek.safar@gmail.com>
5969 A fix for bug #347189
5970 * class.cs (FixedField): Use non-dependent code only in the define phase.
5972 2007-12-23 Marek Safar <marek.safar@gmail.com>
5974 A fix for bug #348076
5975 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5977 2007-12-22 Marek Safar <marek.safar@gmail.com>
5979 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5980 discovered extension methods.
5982 2007-12-22 Marek Safar <marek.safar@gmail.com>
5984 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5987 2007-12-21 Miguel de Icaza <miguel@novell.com>
5989 * report.cs (ErrorMessage): Add support for using colors on
5990 terminals that support it.
5992 2007-12-21 Marek Safar <marek.safar@gmail.com>
5994 * ecore.cs: Use information about expanded params for error reporting.
5996 2007-12-21 Marek Safar <marek.safar@gmail.com>
5998 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5999 and logic for params overloads.
6001 2007-12-15 Miguel de Icaza <miguel@novell.com>
6003 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6004 as this is also created from the parser. Fixes #349034
6006 2007-12-12 Miguel de Icaza <miguel@novell.com>
6008 * statement.cs (Throw.CloneTo): it is valid to have empty
6009 expressions for throw.
6011 2007-12-03 Marek Safar <marek.safar@gmail.com>
6013 * cs-parser.jay: Set delegate constraint parsing region correctly.
6015 2007-12-03 Marek Safar <marek.safar@gmail.com>
6017 A fix for bug #345467
6018 * typemanager.cs (IsEqual): Compare generic parameters position only.
6020 2007-11-28 Marek Safar <marek.safar@gmail.com>
6022 * expression.cs (BaseAccess): Type arguments can be null.
6024 2007-11-27 Raja R Harinath <harinath@gmail.com>
6026 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6027 consistent even when an error has occured.
6028 (Switch.Resolve): Likewise.
6030 2007-11-22 Marek Safar <marek.safar@gmail.com>
6032 A fix for bug #334505
6033 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6036 2007-11-22 Marek Safar <marek.safar@gmail.com>
6038 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6039 refactorings required to resolve extension methods correctly when mixing
6040 generics and non-generics members.
6042 2007-11-20 Marek Safar <marek.safar@gmail.com>
6044 A fix for bug #342584
6045 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6048 2007-11-19 Marek Safar <marek.safar@gmail.com>
6050 A fix for bug #342512
6051 * delegate.cs: Use delegate argument expression when is available. Don't
6052 emit virtual call when class is sealed.
6054 2007-11-16 Marek Safar <marek.safar@gmail.com>
6056 A fix for bug #325423
6057 * assign.cs (FieldInitializer): Use resolved expression for emit.
6059 * class.cs: Print less confusing error message.
6061 2007-11-16 Marek Safar <marek.safar@gmail.com>
6063 * cs-tokenizer.cs: Removed GMCS ifdefs.
6065 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6068 * cs-parser.jay: Disabled nullable check.
6070 * generic-mcs: Copied more generic stuff.
6072 2007-11-16 Marek Safar <marek.safar@gmail.com>
6074 * gcs-parser.jay: Merged to cs-parser.jay.
6076 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6077 * *.csproj, *.sources: Updated to use only jay parser file.
6079 2007-11-16 Marek Safar <marek.safar@gmail.com>
6081 * gcs-parser.jay: Added nullable and default expression feature checks.
6083 2007-11-16 Marek Safar <marek.safar@gmail.com>
6085 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6086 it fixes many TODOs and hidden bugs.
6088 * expression: Removed duplicate error check.
6090 2007-11-15 Marek Safar <marek.safar@gmail.com>
6092 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6093 implicitly type local variable only when it is used in a declaration.
6095 2007-11-15 Marek Safar <marek.safar@gmail.com>
6097 * attribute.cs: Use CS0612 for empty strings.
6099 2007-11-14 Marek Safar <marek.safar@gmail.com>
6101 * lambda.cs, statement.cs: Contextual return may act as a statement.
6103 2007-11-14 Marek Safar <marek.safar@gmail.com>
6105 A fix for a regression cause by #324222
6106 * class.cs: Don't report unused even when it implements an interface.
6108 2007-11-13 Marek Safar <marek.safar@gmail.com>
6110 A fix for bug #341205
6111 * ecore.cs, expression.cs: Method group expression cannot do static
6112 method access with an instance reference check before overloading takes
6115 2007-11-13 Marek Safar <marek.safar@gmail.com>
6117 A fix for bug #325359
6118 * class.cs: Use predictable name for automatically generated property.
6120 2007-11-12 Marek Safar <marek.safar@gmail.com>
6122 A fix for bug #324996
6123 * expression.cs (Is): Handle case where D is nullable and T is not
6126 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6128 2007-11-12 Marek Safar <marek.safar@gmail.com>
6130 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6131 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6132 Flush small error reporting changes.
6134 2007-11-09 Marek Safar <marek.safar@gmail.com>
6136 A fix for bug #324996
6137 * expression.cs: Rewrote Is expression implementation to work with
6138 generics, nullable types, anonymous method. A const result expression
6139 uses existing infrastructure instead of custom not fully-featured one.
6141 2007-11-08 Marek Safar <marek.safar@gmail.com>
6143 A fix for bug #340202
6144 * class.cs: Consider generics for volatile field.
6146 2007-11-08 Marek Safar <marek.safar@gmail.com>
6148 A fix for bug #335594
6149 * expression.cs: Use conversion rules when handling string addition.
6151 2007-11-07 Marek Safar <marek.safar@gmail.com>
6153 A fix for bug #336651
6154 * expression.cs: Fixed a crash when probing is on.
6156 2007-11-07 Marek Safar <marek.safar@gmail.com>
6158 A fix for bug #324242
6159 * covert.cs: Added a conversion from any nullable-type with an
6160 underlying enum-type to the type System.Enum.
6162 2007-11-07 Marek Safar <marek.safar@gmail.com>
6164 A fix for bug #324222
6165 * class.cs: Report all non-used event fields.
6167 2007-11-07 Marek Safar <marek.safar@gmail.com>
6169 A fix for bug #325161
6170 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6171 qualifier for generic types.
6173 2007-11-07 Marek Safar <marek.safar@gmail.com>
6175 A fix for bug #322971
6176 * expression.cs, ecore.cs: Added intermediate result value check for
6179 2007-11-07 Marek Safar <marek.safar@gmail.com>
6181 A fix for bug #324754
6182 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6183 when it was requested.
6185 2007-11-07 Marek Safar <marek.safar@gmail.com>
6187 A fix for bug #325101
6188 * expression.cs: Do type not value comparison for `is' expression.
6190 2007-11-07 Marek Safar <marek.safar@gmail.com>
6192 A fix for bug #320236
6193 * convert.cs: Don't apply user conversion on underlying target type.
6195 2007-11-06 Marek Safar <marek.safar@gmail.com>
6197 * expression.cs: Don't use unresolved expression for error reporting.
6199 2007-11-06 Marek Safar <marek.safar@gmail.com>
6201 A fix for bugs #337712, #324490
6202 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6203 overloading resolution too.
6205 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6206 the process consistent and more robust.
6208 * expression.cs, linq.cs, report.cs: Update.
6210 2007-11-02 Marek Safar <marek.safar@gmail.com>
6212 A fix for bug #332909
6213 * attribute.cs: Resolve attributes in correct context using error
6216 * rootcontext.cs: Define Obsolete attribute members as core members.
6218 2007-11-02 Marek Safar <marek.safar@gmail.com>
6220 * statement.cs: Removed unused methods.
6222 2007-10-31 Wade Berrier <wberrier@novell.com>
6224 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6225 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6228 2007-10-31 Marek Safar <marek.safar@gmail.com>
6230 A fix for bug #338102
6231 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6232 methods registered as non-generics.
6234 2007-10-31 Marek Safar <marek.safar@gmail.com>
6236 A fix for bugs #337712, #324490
6237 * delegate.cs: Delegate covariance and contravariance is not allowed for
6240 2007-10-31 Marek Safar <marek.safar@gmail.com>
6242 A fix for bug #337719
6243 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6246 2007-10-30 Marek Safar <marek.safar@gmail.com>
6248 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6250 2007-10-29 Marek Safar <marek.safar@gmail.com>
6252 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6255 2007-10-29 Raja R Harinath <rharinath@novell.com>
6257 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6259 2007-10-29 Marek Safar <marek.safar@gmail.com>
6261 A fix for bug #334652
6262 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6263 extension methods when we have not found the best candidate in normal
6266 2007-10-27 Marek Safar <marek.safar@gmail.com>
6268 * AssemblyInfo.cs: Keep up-to-date.
6270 2007-10-27 Marek Safar <marek.safar@gmail.com>
6272 * Makefile: Fixed generics compiler name.
6274 2007-10-27 Marek Safar <marek.safar@gmail.com>
6276 * lambda.test: removed, lambda parsing is done differently.
6278 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6280 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6282 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6284 2007-10-27 Marek Safar <marek.safar@gmail.com>
6286 * Makefile, *.sources : All C# compilers are in mcs folder.
6288 * *.cs: Use existing 2_1 define for smcs.
6290 2007-10-26 Marek Safar <marek.safar@gmail.com>
6292 A fix for bug #335847
6293 * assign.cs, expression.cs: Couple of changes to avoid creating a
6294 temporary variable for each object initializer assignment statement. It
6295 simplifies struct initialization too, otherwise two temporary variables
6297 Implemented optimization of redundant default element initializers.
6299 2007-10-25 Marek Safar <marek.safar@gmail.com>
6301 A fix for bug #336766
6302 * expression.cs (Class.CheckBase): Use generic name when method is
6305 2007-10-25 Marek Safar <marek.safar@gmail.com>
6307 A fix for bug #334737
6308 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6309 variable and not variable argument for prepared copies.
6311 2007-10-24 Marek Safar <marek.safar@gmail.com>
6313 A fix for bug #325110
6314 * class.cs, expression.cs, attribute.cs: Use open generic method when
6315 checking conditional attribute.
6317 2007-10-24 Marek Safar <marek.safar@gmail.com>
6319 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6320 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6321 FeatureIsNotAvailable.
6323 2007-10-24 Marek Safar <marek.safar@gmail.com>
6325 ** C# 3.0 Partial methods
6327 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6328 methods support. Because of member cache issue with generics only
6329 non-generics partial methods are fully supported.
6331 2007-10-23 Marek Safar <marek.safar@gmail.com>
6333 * class.cs, decl.cs: Rewrote member overloads check to cope with
6334 generics and to use member cache for member checking. It also improves
6335 performance and fixes remaining overloads issues.
6337 2007-10-20 Marek Safar <marek.safar@gmail.com>
6339 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6340 roottypes.cs, typemanager.cs:
6342 A member cache creation logic changed to add members immediately and
6343 not rely on fallback. The member cache is now only prefered way
6344 how to access and find type declaration members. It saves 5 MB of memory
6345 during MWF compilation and makes code ready for more optimizations and
6346 clean-ups, it's also a pre-requirement for partial methods.
6348 2007-10-18 Raja R Harinath <harinath@gmail.com>
6350 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6351 handling for generic parameters.
6353 2007-10-15 Marek Safar <marek.safar@gmail.com>
6355 * class.cs (FixedField): Removed redundant volatile check.
6357 2007-10-15 Marek Safar <marek.safar@gmail.com>
6359 * class.cs, decl.cs: Fixed overload members verification to do only one
6360 check per possible collision.
6362 2007-10-13 Marek Safar <marek.safar@gmail.com>
6364 A fix for bug #325478
6365 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6366 and create only one disposable flags container.
6368 2007-10-12 Marek Safar <marek.safar@gmail.com>
6370 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6371 * statement.cs (Fixed): Fixed variables cloning.
6373 2007-10-12 Marek Safar <marek.safar@gmail.com>
6375 A fix for bug #333342
6376 * class.cs (EventField): Don't mark value type event as synchronized.
6378 2007-10-12 Marek Safar <marek.safar@gmail.com>
6380 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6381 inference to identify best candidate method correctly.
6382 (ProperyExpr): A range variable is read only and cannot be modified.
6384 2007-10-11 Marek Safar <marek.safar@gmail.com>
6386 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6387 logic to identify best candidate method correctly.
6389 2007-10-11 Marek Safar <marek.safar@gmail.com>
6391 * location.cs (Equals, GetHashCode): Removed.
6393 2007-10-11 Marek Safar <marek.safar@gmail.com>
6395 * report.cs: Implemented message recorder. It is used mainly for lambda
6396 expressions to capture otherwise swallowed error messages.
6398 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6400 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6402 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6404 * expression.cs (MemberAccess): Always report lookup failure.
6406 * location.cs: Implemented Equals, GetHashCode.
6408 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6410 2007-10-10 Jb Evain <jbevain@novell.com>
6412 * codegen.cs: re-enable assembly version check.
6414 2007-10-09 Marek Safar <marek.safar@gmail.com>
6416 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6419 * namespace.cs (UsingAlias): Do correct version check.
6421 2007-10-08 Marek Safar <marek.safar@gmail.com>
6423 * expresison.cs, ecore.cs: Issue extension method error message when
6426 * rootcontext.cs: Added ISO_2 compiler mode option.
6428 2007-10-08 Marek Safar <marek.safar@gmail.com>
6430 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6433 2007-10-08 Marek Safar <marek.safar@gmail.com>
6435 * attribute.cs (GetString, GetBoolean): Work with both literal and
6438 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6439 Moved method overload specific methods to MethodGroupExpr.
6441 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6442 it should be less memory consuming.
6444 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6446 * codegen.cs: remove the assembly version check until the buildbot is
6449 2007-10-07 Jb Evain <jbevain@novell.com>
6451 * attribute.cs (Attribute.GetString): if the value
6452 expression is a StringConstant, return its string value.
6454 2007-10-07 Jb Evain <jbevain@novell.com>
6456 * typemanager.cs: add `assembly_version_attribute_type`.
6457 * codegen.cs: on attribute emission, check that the
6458 AssemblyVersionAttribute doesn't overflow.
6460 2007-10-05 Marek Safar <marek.safar@gmail.com>
6462 A fix for bug #324677
6463 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6464 parent container of a scope container with currently resolved one.
6466 2007-10-05 Marek Safar <marek.safar@gmail.com>
6468 A fix for bug #325534
6469 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6472 2007-10-05 Marek Safar <marek.safar@gmail.com>
6474 A fix for bug #327504
6475 * class.cs (Operator.Define): Refactored implicit and explicit user
6476 operator conversion rules.
6478 2007-10-05 Marek Safar <marek.safar@gmail.com>
6480 A fix for bug #327520
6481 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6483 2007-10-04 Marek Safar <marek.safar@gmail.com>
6485 A fix for bug #328022
6486 * class.cs (MethodData.Define): Use correct method to check whether
6487 a method implementents an accessor.
6489 2007-10-04 Marek Safar <marek.safar@gmail.com>
6491 A fix for bug #330069
6492 * statement.cs (Fixed.Resolve): Read the first array element only when
6493 an array is instantiated.
6495 2007-10-04 Marek Safar <marek.safar@gmail.com>
6497 * expression.cs, assign.cs, generics.cs: Print correct operator when
6498 compound assignment is used.
6500 2007-10-04 Marek Safar <marek.safar@gmail.com>
6502 A fix for bug #325841
6503 * expression.cs (ArrayAccess): Use full argument cloning only for
6504 string compound concatenation.
6506 2007-10-03 Marek Safar <marek.safar@gmail.com>
6508 A fix for bug #328774
6509 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6511 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6514 2007-10-03 Raja R Harinath <rharinath@novell.com>
6517 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6518 Event accessibility checks here. Remove some bogus code that
6519 accidently made GenericMethods work.
6520 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6522 2007-09-25 Marek Safar <marek.safar@gmail.com>
6524 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6526 * statement.cs (Block): Refactored AddVariable to allow error handling
6529 * generic.cs: New stub.
6531 2007-09-23 Marek Safar <marek.safar@gmail.com>
6533 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6536 2007-09-17 Marek Safar <marek.safar@gmail.com>
6538 * class.cs: Use partial container to record whether any partial part
6539 contains static field initializer and therefore default contructor has
6542 2007-09-14 Marek Safar <marek.safar@gmail.com>
6544 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6545 mono-list when only one of two partial parts has defined accessibility
6548 2007-09-14 Marek Safar <marek.safar@gmail.com>
6550 A fix for bug #82845
6552 * class.cs (TypeContainer): Set correct resolve context for all field
6555 2007-09-13 Marek Safar <marek.safar@gmail.com>
6557 * assign.cs: Fixed a crash when field is resolved twice with an error.
6559 * codegen.cs: Changed InFieldInitializer to be flag.
6561 * anonymous.cs, ecore.cs, expression.cs: Update after
6562 IsInFieldInitializer rename.
6564 * const.cs: Removed unused parameter.
6566 * class.cs: Changed the way how we resolve and emit field initializers.
6567 The field initilizers have to have access to contructor block to emit
6568 compiler generated code.
6570 2007-09-13 Marek Safar <marek.safar@gmail.com>
6572 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6573 generics use TypeContainer instead.
6575 2007-09-12 Marek Safar <marek.safar@gmail.com>
6577 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6579 * lambda.cs (ResolveParameters): Use more powerful
6580 InflateGenericArgument.
6582 * parameters.cs: Better exception message.
6584 2007-09-10 Marek Safar <marek.safar@gmail.com>
6586 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6587 correct expression block type.
6589 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6591 * expression.cs (Invocation): Extracted method group resolve to
6594 2007-09-07 Marek Safar <marek.safar@gmail.com>
6596 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6597 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6599 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6600 generic extension methods.
6602 2007-09-06 Marek Safar <marek.safar@gmail.com>
6604 A fix for bug #82676 (Do I get it right now?)
6605 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6606 object before a standard conversion is applied.
6608 2007-09-06 Marek Safar <marek.safar@gmail.com>
6610 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6613 2007-09-05 Marek Safar <marek.safar@gmail.com>
6615 A fix for bug #82676
6616 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6617 non-generic interface types.
6619 2007-09-05 Marek Safar <marek.safar@gmail.com>
6621 A fix for bug #82690
6622 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6624 2007-09-05 Marek Safar <marek.safar@gmail.com>
6626 A fix for bug #82571
6627 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6628 modifier for container based methods.
6630 2007-09-05 Marek Safar <marek.safar@gmail.com>
6632 A fix for bug #82676
6633 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6634 any interface-type T means to any of interface type T.
6636 2007-09-04 Marek Safar <marek.safar@gmail.com>
6638 * namespace.cs: We have 2 versions of System.Core assembly.
6640 2007-09-04 Marek Safar <marek.safar@gmail.com>
6642 A fix for bug #82652
6643 * class.cs (Class.GetClassBases): Compare types and not expressions.
6645 2007-09-04 Marek Safar <marek.safar@gmail.com>
6647 A fix for bug #82620
6648 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6649 actually never worked before.
6650 (IndexerAccess): Emit prepared arguments before they are modified.
6652 2007-09-04 Marek Safar <marek.safar@gmail.com>
6654 A fix for bug #82563
6655 * assign.cs: Revert wrong fix.
6657 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6659 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6660 Instead of ldelema/stdind we have to use temporary variables to handle
6661 cases like String.Concat (params string[]).
6663 2007-08-31 Marek Safar <marek.safar@gmail.com>
6665 * class.cs: EmitAttributes to Emit rename.
6667 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6669 (MemberCore.HasClsCompliantAttribute): Don't depend on
6670 GetClsCompliantAttributeValue execution.
6672 2007-08-31 Marek Safar <marek.safar@gmail.com>
6674 * anonymous.cs: Use shorter type prefix.
6676 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6679 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6680 variables when probing is on.
6682 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6683 unresolved variables.
6684 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6685 handle transparent identifiers.
6687 2007-08-26 Marek Safar <marek.safar@gmail.com>
6689 * attribute.cs (IsClsCompliant): Add nullable types test.
6691 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6693 * doc.cs : catch other types of exception than XmlException to
6694 report CS1570. Fixed bug #82565.
6696 2007-08-23 Marek Safar <marek.safar@gmail.com>
6698 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6699 The number of delegate parameters has to match.
6700 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6703 2007-08-21 Marek Safar <marek.safar@gmail.com>
6705 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6706 to fix problem with private arguments.
6708 2007-08-20 Marek Safar <marek.safar@gmail.com>
6710 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6712 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6714 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6715 empty. Add cloning suport.
6717 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6719 2007-08-20 Marek Safar <marek.safar@gmail.com>
6721 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6722 to create EmptyCast. It handles EmptyConstantCast specialization for
6725 2007-08-18 Marek Safar <marek.safar@gmail.com>
6727 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6728 (EmitArrayArgument): One routine for array arguments.
6729 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6731 2007-08-17 Marek Safar <marek.safar@gmail.com>
6733 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6735 2007-08-17 Marek Safar <marek.safar@gmail.com>
6737 * anonymous.cs: MemberLookupFinal update.
6739 * class.cs (ConstructorInitializer): Is expression based.
6741 * delegate.cs: MethodGroupExpr update.
6743 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6745 (Error_MemberLookupFailed): Customizable error override.
6746 (MethodGroupExpr): Keep queried type for later usage.
6747 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6750 * expression.cs: Error_MemberLookupFailed refactoring.
6751 (New.DoResolve): Resolve as much as possible.
6752 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6753 customization for invalid member types.
6755 * statement.cs: MethodGroupExpr update.
6757 2007-08-16 Marek Safar <marek.safar@gmail.com>
6759 * modifier.cs (Check): Check all modifiers and not only accessibility
6762 2007-08-16 Marek Safar <marek.safar@gmail.com>
6764 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6765 type and not an expression.
6767 2007-08-16 Marek Safar <marek.safar@gmail.com>
6769 * statement.cs (Catch.Clone): Type and variable can be null.
6771 2007-08-16 Marek Safar <marek.safar@gmail.com>
6773 A fix for bug #81979
6774 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6775 I am really not sure whether this is the best fix.
6777 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6780 2007-08-14 Marek Safar <marek.safar@gmail.com>
6782 ** C# 3.0 Object and collection initializers (major re-write)
6784 * assign.cs (DoResolve): Initializers are not assign related.
6786 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6787 used during collection or object initialization.
6789 * expression.cs (Error_InvalidArguments): Add initializers specific
6790 messages. More will come later because it requires some general
6792 (New.DoResolve): Better error handling for unsafe types.
6793 (EmptyExpressionStatement): New class.
6794 (ElementInitializer): An object initializer expression.
6795 (CollectionElementInitializer): A collection initializer expression.
6796 (CollectionOrObjectInitializers): A block of object or collection
6798 (NewInitialize): New expression with element/object initializers.
6800 * statement.cs: Reverted object/collection initializer hacks.
6802 * typemanager.cs (CSharpName): Filter __arglist type.
6804 2007-08-09 Marek Safar <marek.safar@gmail.com>
6806 ** C# 3.0 Anonymous Types (update to the latest standard)
6808 * expression.cs (Binary.ResolveOperator): Threat all null based types
6810 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6811 (AnonymousTypeParameter): Updated.
6813 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6814 (AnonymousTypeClass): New anonymous type container.
6816 * class.cs (AddField): Return operation result.
6818 * generic.cs: Another empty TypeArguments overload.
6820 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6821 are stored at top of normal hierarchy.
6823 * typemanager.cs (CSharpName): Filter anonymous types.
6825 2007-08-09 Marek Safar <marek.safar@gmail.com>
6827 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6828 as single Concat call. How could we miss that :-(
6830 2007-08-08 Marek Safar <marek.safar@gmail.com>
6832 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6834 2007-08-07 Miguel de Icaza <miguel@novell.com>
6836 * expression.cs: Fix the previous commit, the creation of the
6837 arguments array list needs also to be conditional on the arguments
6840 * class.cs: Add a little bit of help to help narrow down problems.
6842 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6843 not try to copy in that case.
6845 * driver.cs: When building SMCS, include a new different set of
6846 default assemblies here. Do this here so we can control whether
6847 to include the default assemblies with /noconfig.
6849 2007-08-03 Marek Safar <marek.safar@gmail.com>
6851 A fix for bug #81979
6852 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6855 2007-08-03 Marek Safar <marek.safar@gmail.com>
6857 A fix for bug #82300
6859 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6860 we are in probing scope.
6862 2007-08-03 Marek Safar <marek.safar@gmail.com>
6864 A fix for bug #82301
6866 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6867 (Statement.CloneTo): Clone and not map children blocks.
6869 2007-08-03 Marek Safar <marek.safar@gmail.com>
6871 A fix for bug #82299
6873 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6876 * statement.cs (Statement.CloneTo): Clone variables before statements
6877 to allow remaping of local variables.
6879 2007-08-03 Marek Safar <marek.safar@gmail.com>
6881 A fix for bug #82296
6884 * report.cs: Log crash details for future clone problems.
6886 * statement.cs (Return.Clone): Don't clone non-existent expression.
6888 2007-08-03 Raja R Harinath <harinath@gmail.com>
6890 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6891 (Class.AddBasesForPart): Move CS0537 check here from ...
6892 * cs-parser.jay (class_declaration): ... here. Move calling of
6893 'AddBasesForPart' to ...
6894 (class_bases): ... here.
6895 (struct_declaration, interface_declaration): Update to changes.
6897 2007-08-02 Marek Safar <marek.safar@gmail.com>
6899 A fix for bug #81923
6901 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6902 conversion is allowed.
6904 2007-08-02 Marek Safar <marek.safar@gmail.com>
6906 A fix for bug #81564
6908 * ecore.cs (EventExpr): Add IsBase handling.
6910 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6913 2007-08-02 Raja R Harinath <harinath@gmail.com>
6915 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6916 * cs-parser.jay: Some whitespace cleanups.
6917 (current_delegate): New.
6919 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6920 a dummy code block, and use 'type_name' instead of 'member_name'.
6921 (interface_declaration, class_declaration): Likewise.
6922 (delegate_declaration): Likewise. Rearrange slightly and use
6924 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6925 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6927 2007-08-02 Marek Safar <marek.safar@gmail.com>
6929 A fix for bug #82039
6931 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6934 * typemanager.cs (CSharpName): Split to string overload.
6936 2007-08-02 Marek Safar <marek.safar@gmail.com>
6939 * report.cs: Updated warning CS0472.
6941 2007-08-01 Marek Safar <marek.safar@gmail.com>
6943 A fix for bug #82181
6945 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6947 2007-08-01 Marek Safar <marek.safar@gmail.com>
6949 A fix for bug #82277
6950 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6952 2007-08-01 Marek Safar <marek.safar@gmail.com>
6954 ** C# 3.0 Type Inference (major bits are working)
6956 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6957 (.ImplicitStandardConversionExists): Uses compatible.
6958 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6959 (.InferReturnType): New method.
6960 (.Compatible): Refactored.
6961 (.ResolveParameters): Uses factory to create resolved parameters.
6962 (.CompatibleMethod): Add probing mode support.
6963 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6964 clearly distinguish between 2 different operations.
6965 (LambdaMethod): Moved to lambda.cs.
6966 (AnonymousMethod): Removed unused fields and methods.
6967 (AnonymousDelegate): Simplified.
6969 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6971 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6973 * delegate.cs (Delegate): New mehods to reduce code duplication.
6974 (.GetConstructor): New method.
6975 (.GetInvokeMethod): New method.
6976 (DelegateCreation): Updated.
6978 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6980 (OverloadResolve): Made probing little bit faster.
6982 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6985 * generic.cs (TypeInferenceContext): Dummy implementation.
6987 * iterators.cs: Updated after Resolve/Define rename.
6989 * lambda.cs (LambdaExpression)
6990 (.ResolveParameters): Handles both type of arguments and type inference too.
6992 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6993 (InflateTypes): Updated.
6995 * support.cs (InflateTypes): Changed signature and updated.
6997 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6998 (MemberLookup_FindMembers): More MS tricks.
6999 (GetParameterData): Ditto.
7000 (GetDelegateParameters): Uses quick path for dynamic types.
7002 2007-08-01 Marek Safar <marek.safar@gmail.com>
7004 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7007 2007-07-31 Marek Safar <marek.safar@gmail.com>
7009 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7012 2007-07-26 Jb Evain <jbevain@novell.com>
7014 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7015 which takes a boolean 'report_errors', similar to the GetMethod.
7016 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7017 in .net 2.1, do not report errors here.
7019 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7020 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7021 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7024 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7025 of the type InternalsVisibleToAttribute before the first call
7026 to CoreLookupType which is allowed to fail (third boolean parameter
7027 to true). Because, during the resolution for a type that is not
7028 immediately found, we try to check if the type is not defined in
7029 a friend assembly, and to do so, we need the
7030 InternalVisibleToAttribute.
7032 2007-07-23 Miguel de Icaza <miguel@novell.com>
7034 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7035 feature that allows structs to be compared against null and inline
7036 the result as true or false.
7038 Notice that the same code is not permitted inside a generic block
7039 of code that would do:
7041 class Foo<T> where T : struct {
7048 It is only allowed if the type of T is not bound (no where
7049 clause). In my opinion, this CSC 2 behavior is broken but people
7050 seem to be using it (IronRuby does, a few bug reports on bugzilla
7051 have it and some people have complained about it).
7053 All of the users that depend on this behavior have code that is
7056 * report.cs (Warning, Error): make these take object arguments,
7057 not strings, as that allows us to take advantage of Format.
7059 2007-07-20 William Holmes <billholmes54@gmail.com>
7061 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7062 Left member variable for the Count.
7063 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7064 MemberName.CountTypeArguments to avoid a NRE.
7066 This code is contributed under the MIT X11 license
7068 2007-07-18 Marek Safar <marek.safar@gmail.com>
7070 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7072 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7074 * doc.cs : generic method arguments are written as ``x while generic
7075 type arguments are `x. Combined with the previous change, fixed bug
7078 2007-07-18 Raja R Harinath <rharinath@novell.com>
7081 * expression.cs (Binary.ResolveOperator): When converting
7082 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7084 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7086 * doc.cs : when T: or whatever x: is specified, it does not really
7087 check the doc comment's syntax correctness. Fixed bug #82006.
7089 2007-07-18 Marek Safar <marek.safar@gmail.com>
7091 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7092 LambdaExpression better.
7094 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7096 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7098 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7099 as it can be generated.
7101 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7104 * lambda.cs (LambdaExpression): Refactored to share same code with
7105 AnonymousMethodExpression.
7107 2007-07-17 Marek Safar <marek.safar@gmail.com>
7109 * anonymous.cs (MakeName): Include host name for easier debugging.
7110 (LambdaMethod): New class for lambda spcecific stuff.
7112 * attribute.cs: Set EmitContext return type.
7114 * class.cs: Set EmitContext return type.
7116 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7117 with null/void meaning.
7119 * iterators.cs (ContainerType): Implemented.
7121 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7123 * statement.cs (Return): Updated to lambda expressions.
7124 (Block.CloneTo): Parent can be null.
7126 2007-07-13 Marek Safar <marek.safar@gmail.com>
7128 A fix for bug #81917
7129 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7131 * class.cs (FixedField): Check whether field is in unsafe scope.
7133 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7134 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7136 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7139 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7141 2007-07-13 Marek Safar <marek.safar@gmail.com>
7143 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7144 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7147 2007-07-13 Marek Safar <marek.safar@gmail.com>
7149 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7151 2007-07-13 Marek Safar <marek.safar@gmail.com>
7153 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7154 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7156 * codegen.cs(EmitContext): Add ProbingMode flag.
7158 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7160 * driver.cs: For now set both warning values.
7162 * ecore.cs (SimpleName): Name is readonly.
7163 (MethodGroup.OverloadResolve): One quick path for probing.
7165 * expression.cs (Unary): Set Oper r/o.
7166 (Binary): Set Oper r/o.
7167 (ParameterReference): Set few instance variables as r/o.
7168 (ParameterReference.DoResolveBase): Don't capture aruments when
7170 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7171 (Arglist): arguments are private.
7172 (SizeOf): type is private and r/o.
7173 (MemberAccess): arguments are private.
7175 * report.cs: Enhanced reporting on/off capabilities.
7177 * lambda.cs: Uses ec.IsInProbingMode.
7178 (ContextualReturn): Derives from return.
7180 * rootcontext.cs: For now set both warning values.
7182 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7184 (Return.Resolve): Don't die immediately.
7185 (Block.Resolve): Speed-up probing.
7186 (Block.CloneTo): Clone only child blocks.
7188 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7190 * iterators.cs: reverted Miguel's latest change (r81925) as it
7191 breaks the build in System.
7193 2007-07-13 Miguel de Icaza <miguel@novell.com>
7195 * iterators.cs (Yield.CheckContext): Check for the iterator type
7196 also here as we can call into Yield even in codepaths that are not
7198 (MethodOrOperator is the only path that was checked).
7200 In addition to the standard check, use a more specific check for
7201 constructors to report a more verbose error.
7203 2007-07-12 Miguel de Icaza <miguel@novell.com>
7205 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7206 report the warning and continue
7208 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7209 values on the stack on the call to Emit. Use EmitStatement if
7210 possible, or using Emit + Pop if not possible. Fixes #82064
7212 2007-07-12 Raja R Harinath <rharinath@novell.com>
7214 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7215 avoid try...finally in some cases.
7217 2007-07-10 Marek Safar <marek.safar@gmail.com>
7219 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7221 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7222 instead of method. Re-use standard error handling.
7223 (ConstructorInitializer.Emit): Simplified.
7225 * delegate.cs: Updated after Invocation.EmitCall change.
7227 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7228 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7229 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7230 method and don't permanently changing input arguments.
7231 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7232 is resolved it has one of the candidates is the best one which is later
7233 used to emit. Removed a few unused method.
7234 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7236 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7237 (Binary.ResolveOperator): Ditto.
7238 (ConditionalLogicalOperator.DoResolve): Ditto.
7239 (Invocation): Uses method group.
7240 (Invocation.DoResolve): Simplified.
7241 (Invocation.EmitCall): Removed useless is_static.
7242 (Invocation.Emit): Delegate to method group.
7243 (Invocation.EmitStatement): Simplified.
7244 (New): Uses method group.
7245 (MemberAccess.DoResolve): Don't destroy original expression.
7247 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7249 2007-07-04 Marek Safar <marek.safar@gmail.com>
7251 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7254 * lambda.cs: Add custom error message type.
7256 2007-07-03 Marek Safar <marek.safar@gmail.com>
7258 * lambda.cs: Simplified little bit.
7260 * parameter.cs: Introduced ImplicitLambdaParameter.
7261 (Parameters.CreateFullyResolved): New factory instead of ctor.
7265 * delegate.cs: Updated parameter creation.
7267 2007-07-03 Marek Safar <marek.safar@gmail.com>
7269 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7272 * generic.cs: Synchronized with gmcs.
7274 2007-07-03 Marek Safar <marek.safar@gmail.com>
7276 * class.cs (Indexer): Check return type as soon as possible.
7278 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7281 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7283 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7285 * parameter.cs (Parameter): Use expression type when it is available.
7287 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7288 method modifier for the first parameter only.
7290 2007-06-24 Marek Safar <marek.safar@gmail.com>
7292 A fix for bug #81938
7293 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7295 * constant.cs: Tide up an exception message.
7297 2007-06-22 Marek Safar <marek.safar@gmail.com>
7299 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7300 an uninitialized variable is used.
7302 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7304 2007-06-22 Marek Safar <marek.safar@gmail.com>
7306 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7307 not found error handling.
7309 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7311 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7312 (ArrayCreation.DoResolve): Simplified.
7313 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7314 its own resolve process.
7315 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7317 2007-06-20 Marek Safar <marek.safar@gmail.com>
7319 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7322 2007-06-20 Marek Safar <marek.safar@gmail.com>
7324 * cs-tokenizer.cs: Removed var related stuff.
7326 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7327 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7328 a type and a keyword at same time.
7330 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7333 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7334 implicitly typed arrays, more changes will follow.
7336 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7338 2007-06-19 Marek Safar <marek.safar@gmail.com>
7340 * ecore.cs (VarExpr): Removed Handled field.
7342 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7343 build-in assign functionality.
7344 (ForEach.Resolve): Removed all implicitly typed local variable code and
7346 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7347 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7349 2007-06-18 Marek Safar <marek.safar@gmail.com>
7351 * assign.cs: Removed implicitly typed local variable check.
7353 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7354 referencing implicitly typed local variable.
7355 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7358 * statement.cs (Fixed): Removed unsupported implicitly typed local
7361 2007-06-15 Marek Safar <marek.safar@gmail.com>
7363 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7365 2007-06-14 Marek Safar <marek.safar@gmail.com>
7367 A fix for bugs #81855 and #76274
7368 * attribute.cs (AttachTo): Always set owner for global attributes to
7371 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7374 * cs-parser.jay: Assembly and module attributes must precede all other
7375 elements except using clauses and extern alias declarations.
7377 2007-06-13 Marek Safar <marek.safar@gmail.com>
7379 A fix for bug #81748
7381 * expression.cs: More checks for non ISO-1 features.
7383 2007-06-12 Marek Safar <marek.safar@gmail.com>
7385 A fix for bug #81807
7386 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7387 present inside switch statement and it is required by nullable check.
7389 2007-06-12 Marek Safar <marek.safar@gmail.com>
7391 A fix for bug #81840
7392 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7393 when type matching fails.
7395 * namespace.cs: Tiny error message change.
7397 2007-06-12 Marek Safar <marek.safar@gmail.com>
7399 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7400 reporting. Added automatic property check.
7402 * class.cs: Updated after CheckAbstractAndExtern relocation.
7403 (AEventPropertyAccessor.GetSignatureForError): Customized.
7405 2007-06-11 Marek Safar <marek.safar@gmail.com>
7407 * class.cs (DefineBaseTypes): Base type can be undefined.
7409 * ecore.cs (TypeLookup): Minor refactoring.
7410 (DoResolveAsTypeStep): Removed redundant check.
7412 * namespace.cs (Lookup): Removed redundant check.
7414 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7415 ResolveAsTypeTerminal step.
7416 (BootstrapCorlib_*): Simplified.
7417 (PopulateCoreType): Core types can be now external.
7419 2007-06-07 Marek Safar <marek.safar@gmail.com>
7421 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7423 (InferTypeArguments): Infers anonymous expression type arguments.
7424 (Compatible): Split to Compatible and InferTypeArguments.
7426 * lambda.cs: Updated.
7428 2007-06-08 Marek Safar <marek.safar@gmail.com>
7430 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7432 2007-06-07 Raja R Harinath <harinath@gmail.com>
7434 Fix #80477, cs0135-2.cs, cs0135-3.cs
7435 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7436 names to the "known" variables list.
7437 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7438 parameter names are also "known".
7439 (Block.CheckError136): Remove.
7440 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7443 2007-06-07 Marek Safar <marek.safar@gmail.com>
7445 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7447 2007-06-06 Marek Safar <marek.safar@gmail.com>
7449 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7450 internal error not an user error.
7452 * expression.cs (IsApplicable): Refactored to make debugging easier.
7454 * support.cs: More tricks for non-mono runtimes.
7456 * typemanager.cs (CoreLookupType): Made public.
7457 (InitSystemCore): All linq specific stuff moved to linq.cs
7459 2007-06-05 Marek Safar <marek.safar@gmail.com>
7461 * typemanager.cs (CSharpSignature): One more missing build-in types
7463 More tricks for non-mono runtime.
7465 2007-06-05 Raja R Harinath <harinath@gmail.com>
7467 * statement.cs (Block.CheckError136_InParents): Remove.
7468 (Block.AddVariable): Use GetParameterInfo instead.
7469 (ToplevelBlock.ProcessArguments): Likewise.
7471 2007-06-04 Raja R Harinath <rharinath@novell.com>
7473 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7475 (ToplevelBlock.GetParameterInfo): Split out of ...
7476 (ToplevelBlock.GetParameterRefernce): ... this.
7477 (ToplevelBlock.ParameterMap): Remove.
7478 * expression.cs (ParameterReference): Update to use
7479 ToplevelParameterInfo.
7481 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7484 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7485 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7487 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7488 (ToplevelBlock.ProcessParameters) ... here.
7489 (ToplevelBlock..ctor): Invoke it.
7491 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7494 * statement.cs (IKnownVariable): New interface.
7495 (LocalInfo): Implement it.
7496 (ToplevelParameterInfo): New class.
7497 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7498 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7499 GetKnownVariableInfo.
7501 2007-06-03 Raja R Harinath <harinath@gmail.com>
7503 Partly speed up CS0136 error checks.
7504 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7505 'recurse' parameter.
7506 (Block.DoCheckError136): Only check errors in parameters. Move
7507 local variable checks ...
7508 (Block.AddVariable): ... here, and ...
7509 (ToplevelBlock.ResolveMeta): ... here.
7511 2007-06-02 Raja R Harinath <harinath@gmail.com>
7513 * statement.cs (Block.IsChildOf): Remove.
7515 * statement.cs (Statement.Clone): Move special case code ...
7516 (Block.CloneTo): ... here.
7518 2007-05-29 Raja R Harinath <rharinath@novell.com>
7520 * statement.cs (ToplevelBlock.container): Remove field. It's
7521 redundant with 'Parent'.
7522 (ToplevelBlock.ContainerBlock): Remove accessor.
7523 (ToplevelBlock..ctor): Update to changes. Register anonymous
7524 child with parent here, ...
7525 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7527 (start_anonymous): Don't save current_block.
7528 (top_current_block): Remove.
7530 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7531 (Block.Resolve): Update to changes.
7532 (Block..ctor): Move setting of "correct" 'Toplevel'
7533 and 'Explicit' fields to ...
7534 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7536 2007-05-27 Raja R Harinath <harinath@gmail.com>
7539 * statement.cs (Block.Implicit): Remove.
7540 (Block): Update to changes.
7541 * flowanalysis.cs: Likewise.
7543 Mildly speed up CheckInvariantMeaningInBlock
7544 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7545 Recursively call AddKnownVariable to all enclosing blocks.
7546 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7547 Remove recursive calls.
7548 (Block): Update to changes.
7550 New ExplicitBlock invariants
7551 * statement.cs (Block.Explicit): New field. It points to the
7552 immediately enclosing non-implicit block.
7553 (Block..ctor): Maintain the invariant.
7554 * cs-parser.jay: Take advantage of invariant.
7556 Introduce ExplicitBlock
7557 * statement.cs (ExplicitBlock): New.
7558 (ToplevelBlock): Derive from it.
7559 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7561 (Block.Implicit): Update to changes.
7562 * cs-parser.jay: Update to changes.
7565 * codegen.cs (EmitContext.IsLastStatement): Remove.
7566 * statement.cs (Block.DoEmit): Update to changes.
7568 2007-05-25 Raja R Harinath <rharinath@novell.com>
7570 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7571 modifying current_block directly.
7573 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7575 * class.cs: Implemented automatic properties (C# 3.0)
7576 Thanks to Marek for the help.
7578 2007-05-23 Raja R Harinath <rharinath@novell.com>
7580 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7581 variable as assigned, note also that all its components are
7583 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7585 2007-05-19 Marek Safar <marek.safar@gmail.com>
7587 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7588 member is marked as compiler generated.
7590 * decl.cs (MemberCore): Refactored ModFlags into property.
7592 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7593 (Check): Check only accessibility modifiers.
7595 2007-05-18 Raja R Harinath <rharinath@novell.com>
7597 Track all assignable slots in one bit array
7598 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7599 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7600 logic from VariableMap constructor here. Use the same 'offset'
7601 variable that's later used for computing offsets of local
7603 * flowanalysis.cs (UsageVector.parameters): Remove.
7604 (UsageVector): Update to changes.
7605 (VariableMap): Remove.
7607 Avoid creating ParameterMap in every block
7608 * statement.cs (Block.ParameterMap): Move ...
7609 (ToplevelBlock.ParameterMap): ... here.
7610 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7612 * flowanalysis.cs (FlowBranching.param_map): Remove.
7613 (FlowBranching.UsageVector): Update to changes.
7614 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7616 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7618 * expression.cs (ParameterReference): Distinguish between block
7619 where parameter was referenced and declared.
7621 2007-05-18 Marek Safar <marek.safar@gmail.com>
7623 * flowanalysis.cs, statement.cs: Put back improved error handling.
7625 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7629 Imporved object and collection initialization (C# 3.0).
7631 2007-05-15 Marek Safar <marek.safar@gmail.com>
7633 A fix for bug #81380
7634 * expression.cs (Is.DoResolve): Only value types have constant `is'
7637 2007-05-15 Raja R Harinath <rharinath@novell.com>
7639 * statement.cs (ToplevelBlock.child): Remove.
7641 2007-05-15 Raja R Harinath <harinath@gmail.com>
7643 Rationalize ResolveMeta: refactoring
7644 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7645 out constant handling code into ...
7646 (Block.DoResolveConstants): ... this.
7648 Rationalize ResolveMeta: kill local_map
7649 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7650 (Block.AssignableSlots): New.
7651 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7652 for locals -- move code from VariableMap here. Avoid unnecessary
7654 * flowanalysis.cs (FlowBranching.local_map): Remove.
7655 (FlowBranching..ctor): Use Block.AssignableSlots.
7656 (VariableMap): Remove unused constructors.
7658 2007-05-11 Raja R Harinath <rharinath@novell.com>
7660 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7662 2007-05-11 Marek Safar <marek.safar@gmail.com>
7664 * typemanager.cs (IsFriendAssembly): Should not be called for building
7667 2007-05-09 Marek Safar <marek.safar@gmail.com>
7669 * literal.cs (NullConstant): Print null in all cases.
7671 * expression.cs (Binary.ResolveOperator): Implemented delegate
7672 comparison based on C# 2.0 changes.
7674 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7676 This code is contributed under the MIT X11 license
7678 The following enables support for several C# 3.0 language features:
7680 * cs-tokenizer.cs: Added support for the "var" keyword.
7682 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7683 Added VarExpr class to facilitate type inferencing.
7685 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7686 to support anonymous types.
7688 * assign.cs: Added support for type inferencing and initialization.
7690 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7692 * expression.cs: Added implicit array support to ArrayCreation.
7693 Added 5 types and 1 interface:
7695 IInitializable Implementing classes can inject initializing
7696 statements after object instantiation.
7698 Initializer Stores data for object initialization.
7700 AnonymousType An expression for anonymous types.
7702 AnonymousTypeParameter Stores data about an anonymous type's field.
7704 NewInitialize An expression for object initialization.
7706 CollectionInitialize An expression for collection initialization.
7708 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7711 2007-05-06 Marek Safar <marek.safar@gmail.com>
7713 A fix for bug #81500
7714 * cs-tokenizer.cs: Add special handling for coalescing operator.
7716 2007-05-06 Marek Safar <marek.safar@gmail.com>
7718 A fix for bug #81529
7719 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7720 its value from base class until it is redefined.
7722 2007-05-02 Raja R Harinath <rharinath@novell.com>
7724 Fix regression in cs0631-3.cs
7725 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7726 fallback. Make error fallback catch more cases.
7728 2007-05-01 Miguel de Icaza <miguel@novell.com>
7730 * cs-parser.jay: Allow parameters in operator declarations to have
7733 2007-04-27 Miguel de Icaza <miguel@novell.com>
7735 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7738 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7739 inside the ContextualReturn, it does not have to be an
7740 ExpressionStatement.
7742 2007-04-24 Miguel de Icaza <miguel@novell.com>
7744 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7747 2007-04-23 Miguel de Icaza <miguel@novell.com>
7749 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7750 method in two methods: ResolveNoDefine and Resolve.
7752 ResolveNoDefine will stop just after ResolveTopBlock has been
7755 Resolve will then continue by creating a method and issuing the
7756 call to method.Define ().
7758 (AnonymousMethod): Split and implement the new Resolve and
7759 ResolveNoDefine as well.
7761 * lambda.cs (LambdaExpression): Split the anonymous method
7762 resolution code into a separate routine (CoreCompatibilityTest)
7763 from DoCompatibleTest.
7765 (LambdaExpression.TryBuild): New method, this method tries to
7766 build the LambdaExpression with the given set of types to be used
7767 as the types for the various parameters of the lambda expression.
7769 If the compilation succeed with the given types, the infered type
7770 of the Anonymous method is returned, otherwise null is returned.
7772 2007-04-23 Marek Safar <marek.safar@gmail.com>
7774 A fix for bug #81414
7775 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7777 2007-04-22 Miguel de Icaza <miguel@novell.com>
7779 * cs-tokenizer.cs: Change various identifiers here from the
7780 camelCasing to the recommended Linux-like style for instance
7781 variables from the Coding Guidelines.
7783 2007-04-19 Martin Baulig <martin@ximian.com>
7786 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7787 System.Enum to System.ValueType.
7789 2007-04-13 Martin Baulig <martin@ximian.com>
7791 Rewrote implicit reference conversions. We need to distinguish
7792 between implicit reference conversions (13.1.4) and implicit
7793 boxing conversions (13.1.5).
7795 According to the spec, there's an an implicit conversion
7796 "From a one-dimensional array-type S[] to IList<T> and base
7797 interfaces of this interface, provided there is an implicit
7798 reference conversion from S to T." Note that this does not
7799 include boxing conversions.
7802 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7803 (Convert.ImplicitReferenceConversion): Split into
7804 ImplicitReferenceConversionCore() and
7805 ImplicitBoxingConversionExist().
7806 (Convert.ImplicitReferenceConversionExists): Use the new
7807 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7809 2007-04-12 Martin Baulig <martin@ximian.com>
7811 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7812 `TypeManager.null_type' checks up to the top of the method.
7814 2007-04-11 Marek Safar <marek.safar@gmail.com>
7816 A fix for bug #81350
7817 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7820 2007-04-11 Martin Baulig <martin@ximian.com>
7822 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7823 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7824 to make this work for generic classes; fixes #79561.
7826 2007-04-11 Martin Baulig <martin@ximian.com>
7828 * expression.cs (As): Add support for nullable types; fixes #79371.
7830 2007-04-11 Martin Baulig <martin@ximian.com>
7832 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7833 `type.FullName' is null; fixes #80243.
7835 2007-04-11 Martin Baulig <martin@ximian.com>
7837 * expression.cs (Invocation.IsApplicable): Don't modify the method
7838 if type inference succeeded, but the method was not applicable.
7841 2007-04-10 Marek Safar <marek.safar@gmail.com>
7843 A fix for bug #81324
7844 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7845 internal and external namespaces containers.
7847 2007-04-10 Martin Baulig <martin@ximian.com>
7849 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7850 TypeManager.DropGenericMethodArguments() so we also call
7851 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7853 2007-04-10 Martin Baulig <martin@ximian.com>
7855 * iterators.cs (Iterator.CreateIterator): Don't crash if
7856 `method.ReturnType' is null. This happens if something went wrong
7857 while resolving that typ (we already reported an error in this case).
7859 2007-04-10 Martin Baulig <martin@ximian.com>
7861 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7862 generic interfaces; report the CS0144 directly.
7864 2007-04-10 Martin Baulig <martin@ximian.com>
7866 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7867 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7869 2007-04-10 Martin Baulig <martin@ximian.com>
7871 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7873 2007-04-09 Raja R Harinath <rharinath@novell.com>
7876 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7877 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7880 * statement.cs (For.Resolve): If resolution fails, use
7883 2007-04-08 Marek Safar <marek.safar@gmail.com>
7885 * anonymous.cs (MakeName): Make faster and zero-based.
7886 (VerifyExplicitParameterCompatibility): Back to mode where generic
7887 parameter is ignored.
7888 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7890 * class.cs (EmitType): Method can emit another new method.
7892 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7894 * driver.cs: Updated.
7896 * lambda.cs: Reuse predefined empty parameters.
7898 * parameter.cs: Updated
7900 * support.cs: Implemented InflateTypes.
7902 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7903 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7905 2007-04-03 Martin Baulig <martin@ximian.com>
7909 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7910 version of TypeManager.IsOverride() which also works with generic
7913 2007-04-03 Martin Baulig <martin@ximian.com>
7918 (Convert.ExplicitReferenceConversion): We need to cast when
7919 converting from IList<T> to S[].
7921 2007-04-01 Marek Safar <marek.safar@gmail.com>
7923 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7926 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7928 2007-03-31 Marek Safar <marek.safar@gmail.com>
7930 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7931 argument and return type inferring.
7933 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7934 (ReturnType): Turned to property.
7936 * statement.cs (Return): Implemented return type inferring.
7938 * support.cs (ReflectionParameters): Use local types if possible.
7940 2007-03-30 Raja R Harinath <rharinath@novell.com>
7942 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7943 (FlowBranching.UsageVector): Update to changes.
7945 Prepare to kill 'Reachability'
7946 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7947 argument of constructor.
7949 2007-03-29 Raja R Harinath <rharinath@novell.com>
7951 Prepare to kill 'Reachability'
7952 * flowanalysis.cs (UsageVector.is_unreachable): New.
7953 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7954 'reachability', and verify they're consistent.
7957 * expression.cs (New.EmitStatement): Handle type parameters here too.
7959 2007-03-29 Martin Baulig <martin@ximian.com>
7964 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7965 CompilerGeneratedClass.
7966 (ScopeInfo.EmitScopeInstance): Make this protected.
7967 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7968 `ec.CurrentAnonymousMethod.Scope == Scope'.
7970 * statement.cs (Block.ScopeInfo): Make this a property.
7972 2007-03-27 Raja R Harinath <harinath@gmail.com>
7974 Prepare to kill 'Reachability'
7975 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7976 (FlowBranching.UsageVector.Reachability): Remove property.
7977 (FlowBranching.UsageVector.IsUnreachable): New property.
7978 (FlowBranching.UsageVector.ResetBarrier): New.
7979 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7980 * codegen.cs, statement.cs: Update to changes.
7982 2007-03-27 Martin Baulig <martin@ximian.com>
7987 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7990 2007-03-26 Raja R Harinath <rharinath@novell.com>
7992 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7993 instead of TriState. Remove all mention of TriState.
7995 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7996 replaced by a boolean. Add boolean 'is_unreachable' field, check
7997 and maintain invariants.
7999 2007-03-25 Marek Safar <marek.safar@gmail.com>
8001 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8003 2007-03-25 Marek Safar <marek.safar@gmail.com>
8005 * expression.cs: Stop using obsolete 2.0 opcodes.
8007 2007-03-25 Marek Safar <marek.safar@gmail.com>
8009 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8010 one of the latests Martin's fixes.
8012 2007-03-23 Miguel de Icaza <miguel@novell.com>
8014 * expression.cs: On BigEndian systems, swap the bytes, temporary
8015 solution until we get a new bitconverter class.
8017 2007-03-23 Martin Baulig <martin@ximian.com>
8021 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8022 "Method" and "Method`1". Normally, a cache lookup is done on the
8023 "Method" form (ie. without the generic arity), but this one makes
8024 lookups on the full form work as well.
8026 2007-03-22 Raja R Harinath <rharinath@novell.com>
8028 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8031 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8033 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8034 ordered_member_list, to TypeBuilder to store members to be defined
8035 in the order they were parsed in.
8036 - ordered_explicit_member_list contains all properties indexers
8037 and methods that are defined as explicit implementation of an
8038 interface or base class.
8039 - ordered_member_list contains all properties indexers and methods
8040 that are not defined as explicit implementation of an interface
8043 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8044 functionality in these removed classes has been replaced with
8045 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8046 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8048 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8049 to CheckForDuplications inside GetMethod and SetMethod Define Method
8050 to handle method property and indexer name conflicts.
8054 All code is contributed under the MIT/X11 license.
8056 2007-03-20 Martin Baulig <martin@ximian.com>
8058 * class.cs (TypeContainer.Interfaces): Removed; they're now
8059 included in `TypeContainer.Types'.
8061 2007-03-20 Martin Baulig <martin@ximian.com>
8063 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8065 * class.cs (TypeContainer.CreateType): New public method. This is
8066 now called before DefineType() to create the TypeBuilders.
8067 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8068 has already been created by CreateType().
8069 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8070 don't resolve our base classes here; this has been moved into
8071 DefineBaseTypes(). We're now called from CreateType().
8072 (TypeContainer.DefineBaseTypes): New private method; resolve our
8073 base classes here. We're now called from DefineType().
8076 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8077 our types first to create all the TypeBuilders. After that, call
8078 TypeContainer.DefineType() on all the types which'll resolve their
8079 base classes and setup the resolve order.
8081 2007-03-20 Martin Baulig <martin@ximian.com>
8083 * class.cs (TypeContainer.Enums): Removed; they're now included in
8084 `TypeContainer.Types'.
8086 2007-03-20 Martin Baulig <martin@ximian.com>
8089 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8090 (TypeContainer.DoResolveMembers): Call DefineType() on our
8091 `compiler_generated' classes; moved here from DefineNestedTypes().
8094 (RootContext.ResolveTree): Call ResolveMembers() on all
8095 TypeContainer's in the `type_container_resolve_order'.
8097 2007-03-19 Marek Safar <marek.safar@gmail.com>
8099 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8101 2007-03-17 Marek Safar <marek.safar@gmail.com>
8103 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8104 implementation flags.
8106 2007-03-17 Marek Safar <marek.safar@gmail.com>
8108 * class.cs: More optimizations for type parameters.
8110 2007-03-15 Marek Safar <marek.safar@gmail.com>
8112 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8114 * ecore.cs, parameter.cs: More common code for both corlibs.
8116 * typemanager.cs (IsGenericMethod): Simplified.
8118 2007-03-15 Raja R Harinath <rharinath@novell.com>
8120 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8122 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8124 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8125 unconditionally. Simplify explanation.
8126 (Try.Resolve, Using.Resolve): Likewise.
8128 2007-03-15 Martin Baulig <martin@ximian.com>
8132 * decl.cs (DeclSpace): If we're a partial class, use our
8133 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8135 2007-03-15 Raja R Harinath <rharinath@novell.com>
8137 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8139 (FlowBranching.UsageVector): Update to changes.
8140 (FlowBranching.MergeSiblings): Likewise.
8141 * statement.cs: Likewise.
8143 2007-03-15 Martin Baulig <martin@ximian.com>
8148 (MemberCache): Added a special .ctor for type parameters.
8151 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8154 2007-03-09 Martin Baulig <martin@ximian.com>
8156 * enum.cs (Enum): Make this a TypeContainer.
8157 (EnumMember): Derive from `Const'.
8160 (Const.DoResolveValue): New protected virtual method; move most of
8161 the functionality of ResolveValue() here so we can override it in
8163 (Const.CreateConstantReference): Make this virtual.
8165 * class.cs (Kind): Add `Kind.Enum'.
8166 (TypeContainer.Emit): Don't emit the enums here; they're already
8167 in the `RootContext.typecontainer_resolve_order'.
8169 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8170 here; they're already in the `typecontainer_resolve_order'.
8172 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8173 TypeManager.DropGenericTypeArguments().
8176 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8177 (TypeManager.IsEnumType): Likewise.
8178 (TypeManager.EnumToUnderlying): Likewise.
8179 (TypeManager.IsEqual): Add support for enums.
8181 2007-03-12 Raja R Harinath <rharinath@novell.com>
8183 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8184 DefaultParameterValueAttribute to be undefined, say if System.dll
8187 2007-03-11 Marek Safar <marek.safar@gmail.com>
8189 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8192 2007-03-10 Marek Safar <marek.safar@gmail.com>
8194 * class.cs, parameter.cs: Unified parameters verification.
8196 2007-03-08 Martin Baulig <martin@ximian.com>
8198 * cs-parser.jay (constructor_header): Pass the location to the
8199 newly created TopLevelBlock.
8201 2007-03-07 Martin Baulig <martin@ximian.com>
8203 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8205 2007-03-06 Miguel de Icaza <miguel@novell.com>
8207 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8208 with the changes from David, fixes the build.
8210 2007-03-05 David Mitchell <dmitchell@logos.com>
8212 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8213 and its base interfaces to a one-dimensional array type S[],
8214 provided there is an implicit or explicit reference conversion
8217 2007-03-03 Marek Safar <marek.safar@gmail.com>
8219 * cs-tokenizer.cs: Implemented basic linq grammar.
8221 * driver.cs: Set linq lang version on demand.
8223 2007-02-26 Marek Safar <marek.safar@gmail.com>
8225 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8227 2007-02-25 Marek Safar <marek.safar@gmail.com>
8229 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8232 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8234 Check property and event extern attributes.
8236 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8239 2007-02-24 Marek Safar <marek.safar@gmail.com>
8241 A fix for bug #80407
8242 * ecore.cs: Don't report ambiguity error when methods have same parent.
8244 2007-02-23 Marek Safar <marek.safar@gmail.com>
8246 A fix for bug #80878
8247 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8249 2007-02-22 Marek Safar <marek.safar@gmail.com>
8251 * attribute.cs: Enable ExtensionAttribute presence test.
8253 2007-02-22 Marek Safar <marek.safar@gmail.com>
8255 * class.cs: Warn about missing GetHashCode only when Equals is override.
8257 * decl.cs: Check accessibility of type arguments.
8259 * typemanager.cs: Correctly report nullable array.
8261 2007-02-20 Marek Safar <marek.safar@gmail.com>
8263 * class.cs, report.cs: Capture more details when things go wrong.
8265 2007-02-20 Marek Safar <marek.safar@gmail.com>
8267 A fix for bug #80650
8268 * cs-parser.jay: Anonymous container starts at constructor declaration
8269 and not at block beginning because it has to be usable in constructor
8272 * statement.cs: Use context location and not block one for error reporting.
8274 2007-02-18 Marek Safar <marek.safar@gmail.com>
8276 A fix for bug #78712
8277 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8280 2007-02-18 Marek Safar <marek.safar@gmail.com>
8282 A fix for bug #80493 by Atsushi Enomoto
8283 * cs-parser.jay: Ignore invalid attribute target.
8285 2007-02-18 Marek Safar <marek.safar@gmail.com>
8287 * cs-tokenizer.cs: Ignore '\0' as white space character.
8289 2007-02-17 Miguel de Icaza <miguel@novell.com>
8291 * cs-parser.jay: Add support for lambda expressions to the mcs
8294 * lambda.cs: Only clone when we are probing, not on the final call
8295 (Compatible is the final call).
8297 * statement.cs (CloneContext): Introduce class to provide block
8298 remapping during clone.
8300 All statements Clone themselves now.
8302 (Clone): special handling for blocks, when we clone a block, we
8303 register the block inside this routine, as children of the block
8304 might trigger a lookup.
8306 * expression.cs: Add support for CloneContext in all expressions.
8308 2007-02-17 Marek Safar <marek.safar@gmail.com>
8310 A fix for bug #80493
8311 * statement.cs: Report ambiguous warning when interfaces are not related.
8313 2007-02-15 Marek Safar <marek.safar@gmail.com>
8315 C# 3.0 extension methods.
8317 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8318 cannot be used directly.
8320 * class.cs (Class.Emit): Emit extension attribute if any class method
8321 is extension method.
8322 (Method.Define): Add basic extension method validation conditions.
8323 (Method.Emit): Emit extension attribute for method.
8325 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8326 extension method exists. Currently we follow same approach as Microsoft
8327 does, emit even if a method or a class are private but this can change
8330 * cs-parser.jay: Add handling of `this' keyword in method parameters
8333 * decl.cs (DeclSpace.IsStaticClass): New property.
8334 (MemberCache.FindExtensionMethods): Looks for extension methods with
8335 defined name and extension type.
8337 * doc.cs: Updated after OverloadResolve changes.
8339 * driver.cs: Add new soft reference to System.Core.dll.
8341 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8342 (ExtensionMethodGroupExpr): Represents group of extension methods.
8344 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8345 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8346 to MethodGroupExpr and made non-static for easier customization.
8347 (Invocation.DoResolve): Add extension method lookup when no standard
8349 (MemberAccess.DoResolve): Try extension methods if no member exists.
8351 * modifiers.cs: Add METHOD_EXTENSION modifier.
8353 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8354 as well as candidate extension type.
8355 (ComputeNamespaces): When assembly constains extension methods registers
8357 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8358 extension method lookup.
8359 (Namespace.LookupExtensionMethod): Looks for extension method in this
8361 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8362 find a method which matches name and extensionType.
8364 * parameter.cs (Parameter): Add This modifer.
8365 (HasExtensionMethodModifier): New property.
8366 (Resolve): Add extension parameter check.
8367 (ModFlags): turned to property to exclude this modifier as it is not real
8369 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8371 * support.cs (ParameterData): Add ExtensionMethodType.
8372 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8374 * typemanager.cs: Add type and ctor extension attribute type.
8376 2007-02-15 Miguel de Icaza <miguel@novell.com>
8378 * report.cs (DisableErrors, EnableErrors): used to prevent error
8379 output when we are "trying" to compile various methods with
8382 * ecore.cs (Expression): Add Clone method that calls the virtual
8383 CloneTo method. The current CloneTo method in Expression throws
8384 an exception so we can track down all the places where this must
8385 be implemented (not using abstract, because that would be a lot of
8386 up-front-work before we can start testing the implementation
8389 Important: we only need Clone capabilities for expressions created
8390 by the parser, as the expressions we will be cloning are
8391 expressions in the pre-resolved state. This vastly simplifies
8394 (SimpleName): Add CloneTo that does nothing.
8395 (EmptyCast): Add CloneTo.
8397 * expression.cs (Binary): Implement CloneTo.
8398 (Invocation.IsApplicable): Store the current ec in
8399 EmitContext.TempEc and restore it on return. This is used so we
8400 do not have to sprinkle hundres of methods with an extra
8401 EmitContext, we know that the only user is the lambda expression
8402 ImplicitConversionExists code.
8404 (Argument): Add Cloning capabilities.
8405 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8406 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8407 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8408 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8409 IndexerAccess): Add Clone capability.
8411 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8413 (Argument): Add cloning capability.
8415 * assign.cs (Assign): Implement CloneTo.
8417 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8419 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8420 version by calling Convert with the EmitContext (that we are
8421 currently storing in ec, this is not great, but will do for now,
8422 to avoid passing EmitContext parameters to hundreds of functions
8423 that do not need them now).
8425 (SetExpression): Remove, it is not needed.
8427 (ContextualReturn): Implement CloneTo.
8429 * statement.cs (Statement): Implement cloning infrastructure,
8430 similar to expressions.
8432 (Block): Partial implementation of Clone for statements.
8434 (Return): Implement clone.
8436 * constant.cs (Constant.CloneTo): New method, does nothing.
8438 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8439 solution, until we decide how to exactly do this.
8441 2007-02-14 Marek Safar <marek.safar@gmail.com>
8443 A fix for bug #80493
8444 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8445 a property is override we need to use second accessor.
8447 2007-02-13 Marek Safar <marek.safar@gmail.com>
8449 A fix for bug #80418
8450 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8453 2007-02-13 Marek Safar <marek.safar@gmail.com>
8455 Another fix for bug #80749
8456 * pending.cs: Abstract class has priority over interfaces.
8458 2007-02-13 Marek Safar <marek.safar@gmail.com>
8460 Another fix for bug #80749
8461 * pending.cs: Abstract class has priority over interfaces.
8463 2007-02-13 Marek Safar <marek.safar@gmail.com>
8465 Another fix for bug #80749
8466 * pending.cs: Abstract class has priority over interfaces.
8468 2007-02-13 Marek Safar <marek.safar@gmail.com>
8470 Another fix for bug #80749
8471 * pending.cs: Abstract class has priority over interfaces.
8473 2007-02-13 Marek Safar <marek.safar@gmail.com>
8475 * class.cs Better error message.
8477 * driver.cs: Add shorter versions of -optimize option.
8479 2007-02-13 Martin Baulig <martin@ximian.com>
8481 * class.cs (Constructor.Emit): Check the return value of
8482 ec.ResolveTopBlock() and return on error.
8484 2007-02-13 Raja R Harinath <rharinath@novell.com>
8486 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8487 message to fix error message regression.
8489 2007-02-12 Marek Safar <marek.safar@gmail.com>
8491 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8493 2007-02-12 Marek Safar <marek.safar@gmail.com>
8495 A fix for bug #80749
8496 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8497 its parent container.
8499 * class.cs (DefineFieldInitializers): Each initializer can has different
8502 * const.cs: Updated.
8504 2007-02-11 Miguel de Icaza <miguel@novell.com>
8506 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8507 now all the heavy lifting to check that embedded statements or
8508 expressions have the right form is done in the ContextualReturn.
8510 (ContextualReturn): New class.
8512 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8513 method that can be invoked to report 201, so we do not replicate
8516 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8518 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8519 treating tabs as spaces.
8521 2007-02-09 Marek Safar <marek.safar@gmail.com>
8523 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8524 * assign.cs: Use full implicit conversion for right side check.
8526 2007-02-09 Marek Safar <marek.safar@gmail.com>
8528 * statement.cs (Switch): Switch over boolean type is not standardized.
8530 2007-02-08 Marek Safar <marek.safar@gmail.com>
8532 A fix for bug #80755
8533 * decl.cs (FindBaseEvent): Don't use method cache for events.
8535 2007-02-07 Marek Safar <marek.safar@gmail.com>
8537 * cs-parser.jay: Better syntax error handling.
8539 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8540 instead of underlying type value.
8542 2007-02-06 Marek Safar <marek.safar@gmail.com>
8544 * driver.cs: Check define identifier before is registered.
8546 * namespace.cs: Use existing error message.
8548 * report.cs: New warning.
8550 2007-02-06 Marek Safar <marek.safar@gmail.com>
8552 A fix for bug #80742
8553 * expression.cs: Delegate Invoke method can be called directly.
8555 2007-02-06 Marek Safar <marek.safar@gmail.com>
8557 A fix for bug #80676
8558 * class.cs (IsEntryPoint): The Main method can have params modifier.
8560 2007-02-04 Miguel de Icaza <miguel@novell.com>
8562 * parameter.cs (Parameter, Parameters): Add Clone method.
8564 * anonymous.cs (Compatible): Turn method into virtual method, so
8565 LambdaExpression can implement a different behavior.
8567 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8568 out the basic checking here, so it can be used by
8571 * lambda.cs: Introduce "Compatible" function that will do the
8574 2007-02-02 Marek Safar <marek.safar@gmail.com>
8576 * attribute.cs: Unified one error message.
8578 * class.cs (Class): Use type attributes and not properties to test static
8580 (IsEntryPoint): Don's pass local variable.
8582 * convert.cs: Removed duplicate check.
8584 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8586 * driver.cs: Don't crash when soft reference does not exist.
8588 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8589 (UsingEntry): Removed redundant allocation.
8591 * parameter.cs: Add fast path for type parameters.
8593 * support.cs: Don't allocate attribute when it's not used.
8595 2007-01-30 Miguel de Icaza <miguel@novell.com>
8598 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8599 this into a virtual method, so we can override it in LambdaExpression.
8601 * driver.cs: Improve diagnostics in case of failure.
8603 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8604 write a function that is slightly more complex and that parses:
8606 type identifier [, type identifier]* )
8608 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8611 (canEmpty ? i >= 0 : i > 0)
8613 2007-01-30 Raja R Harinath <rharinath@novell.com>
8615 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8616 exception on possibly valid code.
8618 2007-01-29 Raja R Harinath <rharinath@novell.com>
8620 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8622 (parse_opt_type_arguments): Remove. It's almost the same as
8624 (parse_namespace_or_typename): Use parse_less_than.
8626 2007-01-28 Miguel de Icaza <miguel@novell.com>
8628 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8629 this bug took a few hours to find, because the state saved and
8630 restored by PushPosition and PopPosition was ignoring the state of
8631 parse_generic_less_than.
8633 I can also now remove the handling of OP_LT and OP_GT, this solves
8636 * cs-tokenizer.cs: store the location for the ARROW token, we use
8639 (PushPosition, PopPosition): save/restore also `current_token',
8640 restore `parse_generic_less_than' (was missing).
8642 (parse_opt_type_arguments): use parse_type, not
8643 parse_namespace_or_typename to parse types.
8645 * lambda.cs: Empty new file, will eventually have the lambda
8646 expression implementation.
8648 * lambda.test: used to test the internal tokenizer.
8650 * report.cs (FeatureIsNotISO1): Rename from
8651 FeatureIsNotStandardized, because it was about the language level
8652 (1 vs 2) it was not about standarization.
8654 (FeatureRequiresLINQ): New.
8656 * support.cs (SeekableStreamReader): Only require that the reader
8657 is a TextReader, not a StreamReader, so we can plug StringReader.
8659 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8660 given position in the input stream the following tokens can be
8661 parsed as a type followed by an identifier.
8663 (is_punct): after a '(' if parse_type_and_parameter returns true,
8664 then return a special token OPEN_PARENS_LAMBDA which is used to
8665 avoid reduce/reduce errors in the grammar for the
8666 lambda_expression rules.
8668 (parse_type): implement a type parser inside the
8669 tokenizer, the parser only returns true or false depending on
8670 whether the input at a given position can be parsed as a type.
8672 (peek_token): new method used during type parsing.
8674 2007-01-28 Raja R Harinath <rharinath@novell.com>
8677 * anonymous.cs (ScopeInfo.InflateParameters): New.
8678 (AnonymousContainer.Resolve): Use it to redirect types of
8679 delegate parameters.
8681 2007-01-27 Raja R Harinath <rharinath@novell.com>
8684 * expression.cs (Error_InvalidArguments): Don't use two different
8685 messages for CS1503. Use ExtraInformation and
8686 SymbolRelatedToPreviousError instead.
8689 * decl.cs (DeclSpace.initialize_type_params): Don't access
8690 'type_params' of a partial class directly.
8692 2007-01-26 Miguel de Icaza <miguel@novell.com>
8694 * constant.cs: Removed a handful of out-of-range checks that were
8697 2007-01-25 Marek Safar <marek.safar@gmail.com>
8699 * expression.cs (CheckUselessComparison): Add additional check for char
8702 * namespace.cs: Fixed typo.
8704 2007-01-23 Miguel de Icaza <miguel@novell.com>
8706 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8707 gone, instead we inline the test, preventing the needless casts to
8708 longs, ulongs and doubles for the parameters, avoiding calls to
8709 methods that overchecked stuff, and instead inlined things
8712 2007-01-20 Marek Safar <marek.safar@gmail.com>
8714 * cs-parser.jay: Better parameter error handling.
8716 2007-01-17 Marek Safar <marek.safar@gmail.com>
8718 A fix for bug #80368, #80522
8719 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8720 whether array initializer contains constants only.
8721 (ArrayCreation.Emit): Use better formula to decide when
8722 are array initializers for static initialization.
8723 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8724 have to emit even constants otherwise they are pre-initialized.
8726 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8727 Raja R Harinath <rharinath@novell.com>
8729 Fix emit order of 'get' vs. 'set'.
8730 * support.cs (Accessors): New.
8731 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8732 Note the order in which accessors are declared in the source.
8733 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8734 Refactored from Property.Define and Indexer.Define.
8735 (PropertyBase.DefineAccessors): New helper that calls the above in
8736 appropriate order as noted by the parser.
8737 (Property.Define, Indexer.Define): Update to changes.
8738 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8740 2007-01-17 Raja R Harinath <rharinath@novell.com>
8742 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8743 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8744 there's an implicit conversion from the current type to the target
8745 type before converting the underlying constant.
8747 2007-01-16 Marek Safar <marek.safar@gmail.com>
8749 * const.cs (ResolveValue): Updated after constant conversion was made more
8752 * constant.cs (GetAttributableValue): constant to object conversion is
8753 used for attributes only.
8754 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8755 constant conversions.
8756 (LongConstant.ConvertImplicitly): Ditto.
8758 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8759 (ImplicitConversionStandard): Handle constant conversion as extra step.
8760 It solves the issue when constant conversion was called indirectly like
8761 inside array initializer and constant folding was skipped.
8763 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8766 * statement.cs(ImplicitConversionStandard): Updated after constant
8767 conversion was made more generic.
8769 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8771 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8772 Constraints, solves the problem where the compiler incorrectly
8773 reported that a type parameter was not constrained to a class (Bug
8776 2007-01-14 Marek Habersack <grendello@gmail.com>
8778 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8780 2007-01-14 Marek Safar <marek.safar@gmail.com>
8782 A fix for bug #80368
8783 * assign.cs (FieldInitializer): New class implements field
8784 initializer statement.
8786 * attribute.cs: Update after FieldMember rename.
8788 * class.cs (PropertyBasedMember): New common class for property based
8790 (InterfaceMemberBase): New base class for all members which can be used as
8791 an interface members.
8792 (MethodCore): Moved really common code to InterfaceMemberBase.
8793 (Method.Define): Equal and GetHasCode detection is relevant for methods
8795 (MethodData.Define): Don't assume that public event implements an
8796 interface automatically.
8797 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8799 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8800 (FieldMember): Merged with FieldBase.
8801 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8802 event extern modifier can be used.
8803 (EventField.EventFieldAccessor): Moved event field specific code here.
8804 (Event.AllowedModifiers): Even event can be extern.
8805 (Event.FindOutBaseMethod): New override specific to events.
8806 (Indexer.parameters): Reintroduce parameters because base class holds
8807 only properties common data.
8808 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8809 need do extra parameters check.
8811 * const.cs: Update after FieldMember rename.
8813 * decl.cs (MemberCache.FindBaseEvent): New method.
8815 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8816 to reflect that indexer is now derived from PropertyBased.
8818 * ecore.cs (GetMemberType): Made public.
8819 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8822 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8824 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8825 (RegisterEvent): Removed.
8826 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8827 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8829 2007-01-11 Raja R Harinath <rharinath@novell.com>
8832 * statement.cs (CollectionForeach.TryType): Prefer generic
8833 GetEnumerator over non-generic variant. Fix code to follow comments.
8835 2007-01-09 Raja R Harinath <rharinath@novell.com>
8838 * support.cs (ReflectionParameter): Don't use an invalid index on
8839 the generic parameter data.
8841 2007-01-08 Miguel de Icaza <miguel@novell.com>
8843 * driver.cs: Just add a tiny bit of infrastructure.
8845 2007-01-02 Marek Safar <marek.safar@gmail.com>
8847 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8848 where field type is struct from current assembly.
8850 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8853 2007-01-02 Marek Safar <marek.safar@gmail.com>
8855 A fix for bug #80381
8856 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8859 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8861 (Namespace.LookupType): Always use core types from corlib when speficied.
8863 * report.cs: A new warning.
8865 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8866 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8867 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8869 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8870 (InitCoreTypes): Set expression type of object_type and value_type
8871 immediately after lookup.
8873 2007-01-01 Miguel de Icaza <miguel@novell.com>
8875 * cs-tokenizer.cs: Accept Pc class characters (Connector
8876 Punctuation) as valid identifiers. Fixes #78259
8878 * expression.cs (Invocation.DoResolve): Moved the check for the
8879 use of `this' for doing method calls to the Invocation resolution
8880 step, after overload resolution has taken place instead of doing
8881 the check at the low-level `This.DoResolve' level.
8883 The `This.DoResolve'(appens before overload resolution, so it has
8884 no way of knowing if the method that will be called will be
8885 instace or static, triggering an erroneous report for cs0188 (Bug
8888 We now do the check for instance method invocations after we know
8889 what method will be called.
8891 (This.CheckThisUsage): Move the actual use of this structure
8892 checking into its own method and expose it.
8894 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8897 Exceptions: Null.ConvertImplicitly,
8898 Constant.ImplicitConversionRequired as there are too many call
8899 sites for passing the ec.
8901 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8902 EmitContext, if the value is null, then we do not try to provide
8903 the extra information from the error (If a userdefined conversion
8904 exists, as UserDefinedConversion requires a non null-EmitContext).
8908 2006-12-30 Raja R Harinath <rharinath@novell.com>
8910 * flowanalysis.cs (MyBitVector): Document some invariants.
8911 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8912 introduced below, and add a couple of others,
8914 2006-12-30 Marek Safar <marek.safar@gmail.com>
8916 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8917 GetPropertyFromAccessor and GetEventFromAccessor.
8919 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8920 overrides non-obsolete one.
8921 (Indexer.Define): Error message has been moved to the parser.
8923 * cs-parser.jay: Better syntax errors handling.
8925 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8926 when an invocation has no arguments.
8928 * ecore.cs: Removed not used caching.
8930 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8933 * report.cs: Add a new warning.
8935 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8937 * typemanager.cs (enumeration_type): Removed.
8938 (CSharpSignature): Reuses IsSpecialMethod.
8939 (IsEqual): Hack for MS BCL.
8940 (GetPropertyFromAccessor): New method.
8941 (GetEventFromAccessor): New method.
8942 (IsSpecialMethod): Fixed to handle more cases.
8944 2006-12-30 Marek Safar <marek.safar@gmail.com>
8946 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8947 Made white spaces array static.
8949 * ecore.cs (RemoveGenericArity): Optimized.
8951 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8953 (MyBitVector.initialize_vector): Simplified.
8955 2006-12-22 Miguel de Icaza <miguel@novell.com>
8957 * ecore.cs: Am not entirely happy with this hack, but it seems to
8958 address the issue in 80257 (a small test case for
8961 I set the MethodGroupExpr.Type to an internal compiler type
8962 (itself in this case) to force the resolution to take place. Why
8963 it does not take place with a null is beyond me.
8965 2006-12-20 Marek Safar <marek.safar@gmail.com>
8967 A fix for bug #80288
8968 * expression.cs (ResolveOperator): Consider user defined conversion for
8969 logical and operator too.
8970 (EmitBranchable): Optimization for logical and when full constant folding
8971 could not be applied but one operand is constant.
8973 2006-12-19 Marek Safar <marek.safar@gmail.com>
8975 * class.cs (GetClassBases): Write 5 times every day, will never use
8976 FullName for error reporting.
8978 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8980 2006-12-19 Martin Baulig <martin@ximian.com>
8982 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8983 the symbol file info here.
8985 2006-12-18 Marek Safar <marek.safar@gmail.com>
8987 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8988 of `elseif' is taking then following sections are not taking.
8989 Fixes an issue reported on mono mailing list.
8991 2006-12-18 Marek Safar <marek.safar@gmail.com>
8993 A fix for bug #80300
8994 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8995 a caller is not taking.
8997 2006-12-18 Raja R Harinath <rharinath@novell.com>
8999 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9000 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9001 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9002 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9003 * class.cs: Update to changes.
9005 2006-12-17 Marek Safar <marek.safar@gmail.com>
9007 A fix for bug #79934
9008 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9011 * class.cs (ResolveMembers): Register an iterator in current container and
9014 2006-12-16 Raja R Harinath <rharinath@novell.com>
9017 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9018 satisfy a params annotated parameter.
9020 2006-12-16 Marek Safar <marek.safar@gmail.com>
9022 A fix for bug #77014
9023 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9024 paramters correctly and not rely on hacks in Parameters class.
9025 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9027 (Invocation.VerifyArgumentsCompat): Ditto.
9028 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9031 * parameter.cs (HasParams): Don't assume that params is the last one.
9033 * support.cs (ReflectionParameters.ctor): Look for params attribute
9035 (ReflectionParameters.ParameterType): Removed hack when we returned last
9036 parameter for out of range parameters.
9037 (ParameterName, ParameterModifier): Ditto.
9039 2006-12-14 Marek Safar <marek.safar@gmail.com>
9041 A fix for bug #79987
9042 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9043 when assembly is not CLS compliant but type is. I have no idea why is this
9046 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9048 2006-12-13 Miguel de Icaza <miguel@novell.com>
9050 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9051 in struct constructors, they are basically no-ops.
9053 2006-12-12 Marek Safar <marek.safar@gmail.com>
9055 * cs-tokenizer.cs (Position): Save preprocessor status too.
9057 2006-12-12 Marek Safar <marek.safar@gmail.com>
9059 A fix for bug #77794
9060 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9062 2006-12-12 Marek Safar <marek.safar@gmail.com>
9064 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9066 (pp_expr): Report error for an invalid expression.
9067 (handle_preprocessing_directive): Simplified; add more error checking.
9069 2006-12-11 Marek Safar <marek.safar@gmail.com>
9071 A fix for bug #74939
9072 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9073 directives handling.
9075 2006-12-10 Marek Safar <marek.safar@gmail.com>
9077 A fix for bugs #80093, and #75984
9078 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9079 logic, it seems to me as it worked before "by coincidence".
9080 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9081 (cleanup): Enabled endif check.
9083 2006-12-09 Marek Safar <marek.safar@gmail.com>
9085 A fix for bug #80162
9086 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9087 enumerators are never ambiguous.
9089 2006-12-08 Raja R Harinath <rharinath@novell.com>
9092 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9094 2006-12-06 Marek Safar <marek.safar@gmail.com>
9096 A fix for bug #80144
9097 * class.cs (EventProperty.Define): Explicit implementation means
9098 that an even is used.
9100 2006-12-06 Marek Safar <marek.safar@gmail.com>
9102 Fixes the operators implementation (part II)
9104 * cfold.cs (DoConstantNumericPromotions): Renamed to
9105 DoBinaryNumericPromotions and simplified.
9106 (BinaryFold): Couple of conversion fixes; simplified.
9108 * constant.cs, ecore.cs, literal.cs
9109 (ToType): Renamed to ConvertImplicitly.
9110 (Reduce): Renamed to ConvertExplicitly.
9112 * class.cs, convert.cs: Updated.
9114 * expression.cs: TryReduce doesn't throw an exception.
9116 2006-12-01 Marek Safar <marek.safar@gmail.com>
9118 A fix for bug #80108
9119 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9122 2006-11-30 Marek Safar <marek.safar@gmail.com>
9124 Fixes unary operators implementation (part I)
9127 * cfold.cs (Error_CompileTimeOverflow): Made internal
9129 * const.cs (IConstant): Changed to use reference to constant and
9130 not constant itself.
9131 Updated IConstant implementations.
9133 * constant.cs (CreateConstant): New factory method.
9134 Updated IConstant implementation.
9136 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9138 * ecore.cs: Updated to use CreateConstantReference.
9140 * enum.cs: Reflects IConstant changes.
9142 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9144 * literal.cs (NullConstant): Change to be independently usable.
9146 2006-11-29 Martin Baulig <martin@ximian.com>
9148 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9149 we need to emit the scope initializer before calling the base .ctor.
9151 * anonymous.cs: Merged back from the new anonymous methods branch.
9152 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9154 * expression.cs (ParameterReference.DoResolveBase): Create a
9155 "normal" ScopeInfo when capturing parameters rather than using the
9156 root scope; this makes things work with anonymous methods having
9160 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9162 2006-11-22 Marek Safar <marek.safar@gmail.com>
9164 A fix for bug #79987
9165 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9166 check to a base class.
9167 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9168 only when assembly has missing attribute.
9169 * report.cs: Update.
9171 2006-11-21 Marek Safar <marek.safar@gmail.com>
9173 * cs-tokenizer.cs: Merged with gmcs version.
9175 2006-11-20 Marek Safar <marek.safar@gmail.com>
9178 * cs-parser.jay: Better error message when partial keyword is misplaced.
9180 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9182 A fix for bug #79810
9183 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9184 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9185 a RuntimeWrappedException by default.
9187 2006-11-18 Marek Safar <marek.safar@gmail.com>
9189 A fix for bug #79843
9190 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9192 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9194 2006-11-18 Marek Safar <marek.safar@gmail.com>
9196 * driver.cs, namespace.cs: Uses faster IndexOf version.
9198 2006-11-17 Marek Safar <marek.safar@gmail.com>
9200 A fix for bug #79941
9201 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9203 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9204 even if internal name is different.
9205 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9206 (UserDefinedConversion): Simplified as the operators cannot be internal.
9207 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9209 (MethodLookup): Replaced EmitContext with parentType.
9210 * expression.cs: Updated.
9212 2006-11-09 Raja R Harinath <rharinath@novell.com>
9214 * driver.cs (BadAssembly): Handle all the ugliness of
9215 DefineDynamicAssembly.
9217 2006-11-08 Raja R Harinath <rharinath@novell.com>
9219 Address parts of #58244 -- most of what's left is in the runtime
9220 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9221 CS1509 error checks, and handle them for all assembly loads, not
9222 just the first invocation.
9223 (LoadModule): Likewise. Move handling of 'adder_method' ...
9224 * codegen.cs (AssemblyClass.AddModule): ... here.
9226 2006-11-02 Marek Safar <marek.safar@gmail.com>
9228 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9229 IEnumerable<T> is ambiguous.
9231 2006-10-31 Marek Safar <marek.safar@gmail.com>
9233 A fix for bug #67689
9234 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9235 GetEnumerator is ambiguous.
9237 * report.cs: Add new warning.
9239 2006-10-29 Marek Safar <marek.safar@gmail.com>
9241 A fix for bug #78602
9242 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9243 to protected member can be nested type.
9245 2006-10-28 Marek Safar <marek.safar@gmail.com>
9247 A fix for bug #78965
9248 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9249 to protected member must derive from current type.
9251 2006-10-27 Marek Safar <marek.safar@gmail.com>
9253 assign.cs: Reuses error method.
9255 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9256 instead of type for constants.
9257 (Expression.Error_ValueAssignment): Common error method.
9259 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9262 2006-10-27 Marek Safar <marek.safar@gmail.com>
9264 A fix for bug #79081
9265 * expression.cs (MemberAccess.DoResolve): Check nested type
9268 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9270 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9272 2006-10-26 Marek Safar <marek.safar@gmail.com>
9274 A fix for bug #76591
9275 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9277 2006-10-26 Marek Safar <marek.safar@gmail.com>
9279 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9280 type forwarder of the same type multiple times.
9282 2006-10-26 Raja R Harinath <rharinath@novell.com>
9285 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9286 instance as an rvalue, even when we later resolve as an lvalue.
9288 2006-10-25 Martin Baulig <martin@ximian.com>
9290 * anonymous.cs: Fix #79673.
9292 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9294 A fix for bug #79666
9295 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9296 ignored when is optimized (= default value) as its value is already set.
9298 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9300 A fix for bug #79724
9301 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9302 TypeContainer for type lookup.
9304 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9306 A fix for bug #79231
9307 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9308 * expression.cs (OverloadResolve): Always convert type name for
9310 (ResolveNamespaceOrType): Don't confuse a nested type with any
9313 2006-10-18 Martin Baulig <martin@ximian.com>
9315 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9317 2006-10-17 Miguel de Icaza <miguel@novell.com>
9319 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9320 an int32, but requesting an int64 from the conversion
9322 2006-10-12 Martin Baulig <martin@ximian.com>
9325 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9327 2006-10-12 Martin Baulig <martin@ximian.com>
9330 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9332 2006-10-11 Miguel de Icaza <miguel@novell.com>
9334 * convert.cs: Remove broken code: I was doing the "Existance"
9335 tests for Implicit conversions.
9337 2006-10-10 Miguel de Icaza <miguel@novell.com>
9339 * convert.cs: Added one missing case in
9340 ImplicitStandardConversionExists uint64 to intptr.
9344 * typemanager.cs (uintptr_type): another core known type.
9346 * ecore.cs (OperatorCast): routine used to do cast operations that
9347 depend on op_Explicit. We could change some of the Decimal
9348 conversions to use this.
9350 This one has a probe mechanism that checks both types for an op_
9351 which it coudl be used to eliminate two classes: CastToDecimal
9352 and CastFromDecimal.
9354 * convert.cs: Implement the conversions documented in #59800
9356 2006-10-10 Martin Baulig <martin@ximian.com>
9358 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9359 before RootScope.ResolveMembers().
9361 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9362 `CurrentType' if appropriate.
9364 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9366 A fix for bug #78568
9367 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9368 when contains binary operators.
9369 * cs-parser.jay: Updated.
9371 2006-10-09 Martin Baulig <martin@ximian.com>
9374 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9375 moved that into Define() and also do the other type parameter
9376 checks there. Fixes #79094. Added gtest-292.cs.
9379 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9380 since that doesn't include type parameters; don't use `Ldelema'
9381 for type parameters. Fixes #78980. Added gtest-293.cs.
9383 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9386 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9387 conversion is allowed.
9389 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9391 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9392 error reporting when no error occurs.
9394 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9396 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9399 2006-10-06 Raja R Harinath <rharinath@novell.com>
9402 * class.cs (DefineTypeBuilder): Check circular dependencies before
9403 setting the parent of the TypeBuilder.
9404 (CheckRecursiveDefinition): Don't use 'BaseType', since
9405 it may not be valid until after DefineTypeBuilder. Use
9406 'base_type' instead.
9408 2006-10-04 Martin Baulig <martin@ximian.com>
9410 Merged the Anonymous Methods patch.
9412 * anonymous.cs, iterators.cs: The new anonymous methods code.
9414 * statement.cs (Variable): New public abstract class.
9415 (LocalInfo.Variable): New public property.
9416 (LocalInfo.ResolveVariable): New public method.
9417 (Block.Flags): Add `IsIterator'.
9418 (Block.AddVariable): Improved the CS0136 check.
9419 (Block.AnonymousChildren): New public property.
9420 (Block.AddAnonymousChild): New public method.
9421 (ToplevelBlock): Update to use the new anonymous method framework.
9422 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9423 `ToplevelBlock'; this is required to correctly implement the
9425 (Fixed, Using): Use `TemporaryVariable' instead of directly
9426 creating the `LocalBuilder'.
9428 * parameter.cs (Parameter.ResolveVariable): New public method.
9429 (Parameters.ResolveVariable): Likewise.
9431 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9433 * class.cs (TypeContainer): Replaced the `iterators' list and
9434 corresponding methods with a list of `CompilerGeneratedClass'es.
9435 (TypeContainer.ResolveMembers): New public method.
9436 (Method): `IIteratorContainer' has been replaced by
9439 * expression.cs (VariableReference): New public abstract base
9440 class for `LocalVariableReference', `ParameterReference' and
9443 * codegen.cs (EmitContext): Removed `capture_context',
9444 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9445 (EmitContext.EmitThis): Removed.
9447 * cs-parser.jay: Replace `iterator_container' with
9450 2006-10-04 Martin Baulig <martin@ximian.com>
9452 * generic.cs (GenericMethod): Don't make this abstract.
9453 (Constraints.Clone): Added dummy implementation.
9455 2006-10-04 Raja R Harinath <harinath@gmail.com>
9458 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9459 'declspaces'. Avoid allocating arrays willy-nilly.
9462 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9463 cases out of the switch.
9465 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9467 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9468 message when non-generic type is used with the type arguments.
9469 * expression.cs: Updated.
9471 2006-09-28 Raja R Harinath <rharinath@novell.com>
9474 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9475 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9476 Change semantics slightly. Don't insist on having only one
9477 temporary EmptyExpression -- just throttle the creation of new ones.
9480 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9481 non-interfaces too. If no methods are found, don't try to create
9484 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9486 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9489 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9490 us produce better error message.
9492 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9494 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9495 of the `|' operator.
9497 * report.cs: A new warning added.
9499 2006-09-27 Martin Baulig <martin@ximian.com>
9501 * generic.cs (GenericMethod): Don't make this abstract.
9503 2006-09-27 Martin Baulig <martin@ximian.com>
9506 (InternalErrorException): Added overloaded ctor taking a params array.
9508 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9510 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9511 Fixed the cases when same error was reported twice.
9513 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9514 now report symbol information.
9516 2006-09-25 Martin Baulig <martin@ximian.com>
9518 * class.cs: Completely unified with the gmcs version.
9520 2006-09-25 Martin Baulig <martin@ximian.com>
9522 * typemanager.cs (TypeManager.IsNullableType): New public function.
9523 (TypeManager.IsNullableTypeOf): Likewise.
9524 (TypeManager.IsNullableValueType): Likewise.
9526 * class.cs (MethodCore): Added the `GenericMethod' argument from
9527 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9529 2006-09-24 Raja R Harinath <harinath@gmail.com>
9531 * convert.cs: Unify with gmcs version.
9533 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9535 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9536 verify them as well.
9538 * report.cs: New warning.
9540 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9542 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9543 for anonymous block with out argument.
9545 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9547 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9548 not used private events only.
9550 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9552 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9554 * const.cs (Const.Define): Check for constant type.
9555 (Const.IsConstantTypeValid): Looks for valid constant types.
9557 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9559 * ecore.cs (EmptyConstantCast): New common class for all constant based
9562 * expression.cs (Is.DoResolve): Handle null constant especially.
9563 (New.DoResolve): Check for new void().
9564 (MemberAccess.DoResolve): Cope with all kind of nulls.
9566 * literal.cs (NullConstant): Uses EmptyConstantCast.
9567 (NullDefault): Based on EmptyConstantCast.
9568 (NullLiteral): Uses EmptyConstantCast.
9570 * statement.cs (Block.ResolveMeta): Check for constant type.
9572 2006-09-22 Martin Baulig <martin@ximian.com>
9574 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9576 2006-09-22 Raja R Harinath <rharinath@novell.com>
9578 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9582 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9583 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9586 2006-09-22 Martin Baulig <martin@ximian.com>
9588 * ecore.cs: Merged with the gmcs version.
9590 * generic.cs (ConstructedType): New dummy class.
9591 (TypeArguments): Don't make this abstract.
9594 (TypeManager.IsGenericTypeDefinition): New method.
9595 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9597 2006-09-22 Raja R Harinath <rharinath@novell.com>
9599 * expression.cs (ComposedCast): Check for arrays of TypedReference
9600 before creating the type, not after.
9602 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9604 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9605 after ToType change.
9607 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9608 when constant must be implicitly convertible.
9610 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9612 * ecore.cs (NullCast): Derives from NullConstant.
9614 * expression.cs (Is.DoResolve): Removed useless variables.
9615 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9616 (New.Constantify): Add enum support.
9617 (MemberAccess.DoResolve): Add warning when accessing null constant or
9620 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9623 * literal.cs (NullConstant): New abstract class with common
9624 functionality for all null specializations.
9625 (NullDefault): Represents default(X) when result can be
9627 (NullLiteral): Updated.
9629 * report.cs: Add new warning.
9631 2006-09-21 Martin Baulig <martin@ximian.com>
9633 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9635 2006-09-21 Martin Baulig <martin@ximian.com>
9637 * generic.cs (GenericConstraints): New dummy class.
9638 (Constraints): Likewise.
9639 (TypeParameter): Likewise.
9640 (TypeParameterName): Likewise.
9641 (GenericMethod): Likewise.
9643 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9645 * decl.cs: Merged with the gmcs version.
9647 2006-09-21 Raja R Harinath <rharinath@novell.com>
9649 * generic.cs (TypeParameter): Implement IMemberContainer.
9650 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9652 * rootcontext.cs: Unify with gmcs version.
9654 * report.cs: Unify with gmcs version.
9655 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9656 from gmcs/generics.cs.
9657 * generics.cs (TypeParameter): New dummy class.
9659 * support.cs: Unify with gmcs version.
9661 2006-09-20 Raja R Harinath <rharinath@novell.com>
9663 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9664 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9666 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9667 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9668 * mcs.exe.sources: Add generic.cs.
9670 * codegen.cs: Unify with gmcs version.
9672 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9673 (EmitContext): Add GenericDeclContainer implementation.
9674 * decl.cs (MemberCore, DeclSpace): Likewise.
9675 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9677 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9678 MCS TypeManager has a corresponding dummy method.
9680 2006-09-19 Martin Baulig <martin@ximian.com>
9682 * expression.cs: Completely merged with the gmcs version.
9684 2006-09-19 Martin Baulig <martin@ximian.com>
9686 * expression.cs (Invocation): Merged with the gmcs version.
9687 (ArrayAccess.GetStoreOpcode): Likewise.
9689 2006-09-19 Martin Baulig <martin@ximian.com>
9692 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9693 (TypeManager.IsGenericMethodDefinition): Likewise.
9695 2006-09-19 Martin Baulig <martin@ximian.com>
9698 (TypeManager.IsEqual): Moved the gmcs implementation here.
9699 (TypeManager.DropGenericTypeArguments): Likewise.
9700 (TypeManager.DropGenericMethodArguments): Likewise.
9701 (TypeManager.GetTypeArguments): Moved here from gmcs.
9702 (TypeManager.HasGenericArguments): Likewise.
9704 2006-09-19 Martin Baulig <martin@ximian.com>
9706 * expression.cs (Binary): Merged with the gmcs version.
9708 2006-09-19 Martin Baulig <martin@ximian.com>
9710 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9712 2006-09-19 Martin Baulig <martin@ximian.com>
9714 * typemanager.cs: Merged with the gmcs version.
9716 2006-09-16 Raja R Harinath <rharinath@novell.com>
9718 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9719 * driver.cs: Likewise.
9721 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9724 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9725 only if parent type is class.
9726 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9729 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9732 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9734 * typemanager.cs(CSharpName): Converts NullType to null.
9736 2006-09-15 Martin Baulig <martin@ximian.com>
9739 (TypeManager.GetMethodName): Added mcs implementation.
9740 (TypeManager.IsEqual): Likewise.
9743 (SimpleName.RemoveGenericArity): Added dummy implementation.
9745 * pending.cs: Merged with the gmcs version.
9747 2006-09-15 Martin Baulig <martin@ximian.com>
9749 * statement.cs: Merge with the gmcs version.
9751 2006-09-15 Martin Baulig <martin@ximian.com>
9753 * statement.cs (Switch): Merge with the gmcs implementation
9754 (without nullables), which is newer.
9756 2006-09-15 Martin Baulig <martin@ximian.com>
9758 * statement.cs (Block.Variables): Make this public.
9759 (ToplevelBlock.Parameters): Make this a property.
9760 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9762 2006-09-15 Martin Baulig <martin@ximian.com>
9764 * namespace.cs: Merge with the gmcs version.
9766 2006-09-15 Martin Baulig <martin@ximian.com>
9768 * decl.cs (MemberName): Minor code cleanups.
9770 2006-09-15 Martin Baulig <martin@ximian.com>
9772 * parameter.cs: Merge with the gmcs version.
9774 2006-09-15 Martin Baulig <martin@ximian.com>
9776 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9777 and an error in mcs.
9779 2006-09-15 Martin Baulig <martin@ximian.com>
9781 * flowanalysis.cs: Merged from GMCS; added the generics code into
9782 a `GMCS_SOURCE' conditional so we can share this file.
9784 2006-09-08 Martin Baulig <martin@ximian.com>
9786 * typemanager.cs (TypeManager.interlocked_type): New public field.
9787 (TypeManager.int_interlocked_compare-exchange): New public field.
9788 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9789 enumerator types here and call InitGenericCoreTypes().
9790 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9791 after calling InitEnumUnderlyingTypes().
9794 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9795 `classes_second_stage'.
9797 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9799 * assign.cs, ecore.cs, expression.cs: Share error message text.
9800 * class.cs (FieldMember.Define): Check for varible of static type.
9801 * driver.cs (LoadAssembly): Uses error output for errors.
9802 * statement.cs: Updated.
9804 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9806 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9809 2006-09-07 Martin Baulig <martin@ximian.com>
9812 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9814 2006-08-29 Miguel de Icaza <miguel@novell.com>
9816 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9818 2006-08-17 Miguel de Icaza <miguel@novell.com>
9820 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9821 #52019 and #79064, the use of the \uXXXX sequence in source code
9822 to represent unicode characters.
9824 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9826 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9828 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9830 2006-08-13 Miguel de Icaza <miguel@novell.com>
9832 * assign.cs: Catch attempts to assign to a method groups in += and
9835 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9838 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9840 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9842 * class.cs (Method.Define): Issue a warning when generic method looks like
9844 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9847 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9849 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9851 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9852 search all base interfaces as a member can be ambiguous.
9853 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9854 Constructor member type filter.
9855 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9856 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9857 reporting for returned memberinfos.
9858 * report.cs: Updated.
9859 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9860 version to work on all runtimes.
9861 (TypeManager.RealMemberLookup): Removed members filtering.
9863 2006-08-08 Raja R Harinath <rharinath@novell.com>
9865 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9866 (PropertyExpr.EmitAssign): Likewise.
9867 * expression.cs (Indirection.EmitAssign): Likewise.
9868 (LocalVariableReference.EmitAssign): Likewise.
9869 (ParameterReference.EmitAssign): Likewise.
9870 (Invocation.EmitArguments): Likewise.
9871 (ArrayAccess.EmitAssign): Likewise.
9872 (IndexerAccess.EmitAssign): Likewise.
9873 (This.EmitAssign): Likewise.
9874 (ConditionalLogicalOperator.Emit): Likewise.
9877 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9878 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9879 leave it in after returning it.
9880 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9882 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9884 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9887 2006-08-03 Raja R Harinath <rharinath@novell.com>
9889 Fix cs0146-3.cs and cs0146-4.cs.
9890 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9891 enclosing types don't depend on the current type.
9893 2006-08-02 Raja R Harinath <rharinath@novell.com>
9896 * class.cs (TypeContainer.DoDefineMembers): Use
9897 FindBaseMemberWithSameName on Parent, since we're interested in
9898 whether we hide inherited members or not.
9899 (FindBaseMemberWithSameName): Make slightly more robust.
9901 Fix the non-generic testcase from #77396
9902 * decl.cs (DeclSpace.DeclContainer): Remove override.
9904 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9905 declspaces for doppelgangers too.
9906 (UsingEntry): Implement IResolveContext.
9907 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9908 'this' as the resolve context.
9909 (LocalAliasEntry): Likewise.
9911 Implement parts of #77403
9912 * roottypes.cs (RootDeclSpace): New. Used to represent the
9913 toplevel declaration space. Each namespace declaration introduces
9914 a "partial" root declaretion space.
9915 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9916 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9917 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9918 from 'current_namespace.SlaveDeclSpace'.
9919 (namespace_declaration): Likewise.
9920 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9921 check. It can't happen now.
9922 * decl.cs (DeclSpace.LookupType): Likewise.
9923 * driver.cs (MainDriver): Sanity check.
9925 2006-08-01 Raja R Harinath <rharinath@novell.com>
9927 * decl.cs (DeclSpace.FindNestedType): Remove.
9928 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9929 LookupTypeContainer to get the container of the nested type.
9930 * class.cs (TypeContainer.FindNestedType): Make non-override.
9932 2006-07-31 Raja R Harinath <rharinath@novell.com>
9934 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9935 * class.cs (TypeContainer.PartialContainer): ... here.
9936 (TypeContainer.AddBasesForPart): New helper.
9937 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9939 * cs-parser.jay (current_class): Convert to DeclSpace.
9940 (struct_declaration, interface_declaration, class_declaration):
9941 Use AddBasesForPart instead of .Bases directly.
9942 * const.cs, iterators.cs: Update to changes.
9944 2006-07-28 Raja R Harinath <rharinath@novell.com>
9946 * class.cs (TypeContainer.AddMemberType): Rename from
9948 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9949 (AddTypeContainer): New. Combine AddClassOrStruct and
9951 (AddPartial): Update. Add 'is_partial' argument.
9952 * roottypes.cs: Update to changes.
9953 * cs-parser.jay (push_current_class): New helper for handling
9954 current_container and current_class.
9955 (struct_declaration, interface_declaration, class_declaration):
9958 2006-07-26 Raja R Harinath <rharinath@novell.com>
9960 * roottypes.cs: Rename from tree.cs.
9962 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9963 * tree.cs (Tree, ITreeDump): Remove types.
9964 * rootcontext.cs (tree, Tree): Remove fields.
9965 (root, ToplevelTypes): New.
9966 * *.cs: Update to rename.
9968 * tree.cs (Tree.RecordDecl): Remove.
9969 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9971 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9973 2006-07-23 Raja R Harinath <harinath@gmail.com>
9975 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9976 DoFlowAnalysis and OmitStructFlowAnalysis here.
9977 (ec.With): Rename from WithUnsafe and generalize.
9978 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9979 (ec.WithFlowAnalyis): New.
9980 * ecore.cs, expression.cs, statement.cs: Update.
9982 2006-07-22 Raja R Harinath <harinath@gmail.com>
9984 * statement.cs (Block.ResolveMeta): Simplify slightly.
9986 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9987 multiple boolean fields. Convert InUnsafe, constant_check_state,
9988 check_state to flags.
9989 (CheckState, ConstantCheckState): Update.
9990 (InUnsafe): New read-only property.
9991 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9993 (WithUnsafe): New helper similar to WithCheckState.
9994 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9995 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9997 2006-07-21 Raja R Harinath <rharinath@novell.com>
9999 Make comparisons use the same IL irrespective of whether they're
10000 in a 'checked' or 'unchecked' context: one of the issues in #78899
10001 * codegen.cs (EmitContext.CheckState): Make read-only property.
10002 (EmitContext.ConstantCheckState): Likewise.
10003 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10004 helper that implement a save/restore stack for CheckState
10005 values. This is the only way to change check-state.
10006 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10007 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10008 (CheckedExpr.EmitBranchable): New forwarding method.
10009 (UnCheckedExpr): Likewise.
10010 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10011 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10012 (Checked.Resolve, checked.DoEmit): Likewise.
10014 2006-07-20 Miguel de Icaza <miguel@novell.com>
10016 * anonymous.cs: Cache the resolved anonymous delegate, and return
10017 this so that the ResolveTopBlock is only triggered once, not
10020 Currently we trigger ResolvetopBlock twice due to a first pass of
10021 argument check compatibility, and a second pass that does the
10024 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10026 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10028 * rootcontext.cs (Reset): Add helper_classes.
10030 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10033 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10036 2006-07-13 Miguel de Icaza <miguel@novell.com>
10038 * statement.cs (Lock): Handle expressions of type
10039 TypeManager.null_type specially. Fixes #78770
10041 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10043 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10046 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10048 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10049 for accessors as well.
10050 * ecore.cs (EventExpr): Add AccessorTable.
10052 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10055 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10056 for CS0122 where appropriate.
10057 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10059 (Filter): Assembly can be null in the case of top level attributes.
10061 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10065 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10066 is done at global level.
10068 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10070 A fix for #77002, Implemented TypeForwarder support.
10072 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10073 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10074 * typemanager.cs (): Add type_forwarder_attr_type.
10076 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10078 * report.cs: Add CS0469 warning.
10080 2006-06-21 Martin Baulig <martin@ximian.com>
10082 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10083 the `try'-block, so we also report CS0016 etc. there.
10085 2006-06-21 Martin Baulig <martin@ximian.com>
10088 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10090 2006-06-21 Martin Baulig <martin@ximian.com>
10092 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10093 also report CS1686 for parameters.
10095 2006-06-21 Martin Baulig <martin@ximian.com>
10097 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10098 instead of an error if the value is not implicitly convertible to
10099 the switch types; fixes #77964.
10101 2006-06-21 Raja R Harinath <rharinath@novell.com>
10104 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10105 FieldBuilder is null.
10108 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10109 'left' and 'right' before error-checking.
10111 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10113 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10115 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10116 (FieldExpr.DoResolve): likewise.
10117 (PropertyExpr.InstanceResolve): likewise.
10118 (EventExpr.InstanceResolve): likewise.
10120 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10122 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10123 attribute applicable tests for attribute argument.
10125 2006-06-02 Raja R Harinath <rharinath@novell.com>
10128 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10129 (Binary.OverloadResolve_PredefinedIntegral): New.
10130 (Binary.OverloadResolve_PredefinedFloating): New.
10131 (Binary.OverloadResolve_PredefinedString): New.
10132 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10133 Follow the standard more closely, and treat numeric promotions in
10134 terms of overload resolution.
10135 (Binary.CheckShiftArguments): Simplify.
10137 2006-06-01 Raja R Harinath <rharinath@novell.com>
10139 * flowanalysis.cs (MyBitVector): Simplify representation.
10140 (MyBitVector.Clone): Avoid allocating BitArray.
10141 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10142 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10143 (*): Update. Change all references to MyBitVector.And and
10144 MyBitVector.Or to &= and |=.
10146 2006-05-29 Raja R Harinath <rharinath@novell.com>
10148 Fix cs0231-[34].cs.
10149 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10150 to param arguments too.
10152 2006-05-26 Miguel de Icaza <miguel@novell.com>
10154 * cs-parser.jay: Catch another parsing form for arglist being
10155 followed by other arguments. Fixes #78313.
10157 2006-05-24 Raja R Harinath <rharinath@novell.com>
10159 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10160 checking of out parameters to ...
10161 (FlowBranchingToplevel.Merge): ... here.
10162 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10163 set, propagate the origin upward, and only complain if there was
10165 (FlowBranchingException.AddContinueOrigin): Likewise.
10166 (FlowBranchingException.AddReturnOrigin): Likewise.
10167 (FlowBranchingException.AddGotoOrigin): Likewise.
10169 2006-05-23 Raja R Harinath <rharinath@novell.com>
10171 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10172 unreachable, skip it.
10173 (FlowBranchingException.Merge): Always propagate jumps, even if
10174 the finally block renders subsequent code unreachable.
10176 2006-05-18 Raja R Harinath <rharinath@novell.com>
10179 * statement.cs (Goto.Resolve): Move responsibility for resolving
10180 'goto' to FlowBranching.AddGotoOrigin.
10181 (Goto.SetResolvedTarget): New. Callback to set the
10182 LabeledStatement that's the target of the goto.
10183 (Goto.DoEmit): Use Leave instead of Br when crossing an
10184 unwind-protect boundary.
10185 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10186 LookupLabel and adjust to new semantics.
10187 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10188 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10189 Goto.SetResolvedTarget to update target.
10190 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10191 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10192 AddBreakOrigin & co. Delay propagation until ...
10193 (FlowBranchingException.Merge): ... this.
10195 * statement.cs (Block.Resolve): Always depend on flow-branching to
10196 determine unreachability. Kill workaround that originally emitted
10197 only one statement after an "unreachable" label (see infloop in
10200 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10201 This is still "wrong", but anything better would probably need a
10202 multi-pass algorithm.
10203 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10204 usage vector. Force current usage vector to be reachable, to
10205 optimistically signify backward jumps.
10206 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10208 (FlowBranchingLabeled.Merge): New. If no backward jump was
10209 detected, return the original salted-away usage vector instead,
10210 updated with appropriate changes. Print unreachable warning if
10212 * statement.cs (Block.Resolve): Don't print unreachable warning on
10213 a labeled statement.
10215 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10217 * driver.cs: Pass filename without path to AssemblyBuilder's
10218 AddResourceFile. Fixes bug #78407.
10220 2006-05-17 Raja R Harinath <rharinath@novell.com>
10222 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10223 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10224 (FlowBranching.MergeChild): Overwrite
10225 reachability information from Labeled branchings too.
10227 2006-05-16 Raja R Harinath <rharinath@novell.com>
10229 * statement.cs (Goto.Resolve): Merge jump origins here ...
10230 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10232 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10233 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10234 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10235 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10237 * statement.cs (Goto.Resolve): ... not here.
10238 (Goto.Emit): Remove CS1632 check.
10240 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10242 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10245 2006-05-11 Raja R Harinath <rharinath@novell.com>
10247 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10248 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10249 (FlowBranchingException.Label): Likewise.
10251 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10253 (MyBitVector.Or): Use it to avoid losing information (Count).
10254 (FlowBranching.MergeOrigins): Likewise.
10256 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10257 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10258 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10259 (UsageVector.ToString): Simplify.
10260 (UsageVector.MergeSiblings): Move here from ...
10261 (FlowBranching.Merge): ... here.
10262 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10265 2006-05-10 Raja R Harinath <rharinath@novell.com>
10267 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10268 null bitvector is treated as all-true.
10270 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10271 (MyBitVector): Rationalize invariants. 'vector != null' implies
10272 that we have our own copy of the bitvector. Otherwise,
10273 'InheritsFrom == null' implies all inherited bits are true.
10275 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10277 * statement.cs (LocalInfo): Add IsConstant.
10278 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10279 local variable for constants.
10281 2006-05-09 Raja R Harinath <rharinath@novell.com>
10283 * flowanalysis.cs (MyBitVector.Empty): New.
10284 (MyBitVector): Don't allow InheritedFrom to be null.
10285 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10286 (UsageVector, FlowBranching): Update to changes.
10288 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10289 recursion. The 'Parent == null' condition isn't sufficient for
10291 (FlowBranching.AddBreakOrigin): Likewise.
10292 (FlowBranching.AddContinueOrigin): Likewise.
10293 (FlowBranching.AddReturnOrigin): Likewise.
10294 (FlowBranching.StealFinallyClauses): Likewise.
10295 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10296 (FlowBranching.CheckOutParameters): Likewise.
10297 (FlowBranchingToplevel): Terminate all the above recursions here.
10298 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10299 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10301 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10303 (FlowBranchingToplevel): New. Empty for now.
10304 (FlowBranching.MergeTopBlock): Update.
10305 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10306 branching for the anonymous delegate.
10307 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10309 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10310 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10311 information at the start of the merge. Reorganize.
10313 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10315 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10317 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10319 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10320 to newly introduced ctor.
10322 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10323 message to one place.
10324 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10327 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10329 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10331 * ecore.cs (Expression.ResolveAsConstant): Updated.
10333 * statement.cs (ResolveMeta): Updated.
10335 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10337 * cs-parser.jay: __arglist cannot be used in initializer.
10339 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10342 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10345 2006-05-05 Raja R Harinath <rharinath@novell.com>
10347 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10348 (LabeledStatement): Add 'name' parameter.
10349 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10350 (Block.AddLabel): Update to changes.
10351 * cs-parser.jay (labeled_statement): Likewise.
10353 * flowanalysis.cs (BranchingType.Labeled): New.
10354 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10355 (FlowBranchingLabeled): New. Does nothing for now, but will
10356 eventually handle 'goto' flows.
10357 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10358 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10359 that's terminated ...
10360 (Block.Resolve): ... here.
10362 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10363 (UsageVector.MergeFinallyOrigins): Likewise.
10364 (FlowBranching.InTryOrCatch): Likewise.
10365 (FlowBranching.AddFinallyVector): Likewise.
10366 (FlowBranchingException): Update to changes.
10369 * statement.cs (Return.Resolve): Move error checking to ...
10370 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10371 (FlowBranchingException): Handle return origins like break and
10373 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10375 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10378 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10381 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10384 * class.cs (MethodData.Define): Do public accessor check only when method
10385 implements an interface.
10387 2006-05-04 Raja R Harinath <rharinath@novell.com>
10389 Remove special handling of 'break'
10390 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10391 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10392 (UsageVector.Break): Remove.
10393 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10395 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10397 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10398 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10400 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10403 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10404 be the interface member.
10406 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10409 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10410 for emitting small (int) values.
10412 2006-05-03 Raja R Harinath <rharinath@novell.com>
10415 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10416 control-flow passes through the 'finally' after merging-in all the
10417 control-flows from 'try' and the 'catch' clauses.
10419 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10420 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10421 always true at the only non-recursive entry point.
10422 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10423 FlowBranchingBreakable.
10424 (FlowBranchingLoop): Remove.
10425 * statement.cs (Return.DoResolve): Update to changes.
10428 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10429 (FlowBranching.CreateBranching): Handle it: create a
10430 FlowBranchingContinuable.
10431 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10432 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10433 except that it handles the 'continue' command.
10434 (FlowBranching.UsageVector.MergeOrigins): Rename from
10436 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10437 except that it overrides AddContinueOrigin.
10438 (FlowBranchingException): Override AddContinueOrigin, similar to
10440 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10441 Create a new branching around the embedded statement.
10442 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10443 control flow after the embedded statement.
10444 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10446 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10447 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10448 FlowBranchingBreakable.
10449 (FlowBranchingSwitch): Remove.
10452 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10453 error reporting to ...
10454 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10455 Rename from 'AddBreakVector'. Add new location argument. Return
10456 a bool indicating whether the 'break' crosses an unwind-protect.
10457 (FlowBranchingException.AddBreakOrigin): Add.
10458 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10459 flowbranching after updating with the effects of the 'finally'
10461 (FlowBranchingBreakable): New common base class for
10462 FlowBranchingLoop and FlowBranchingSwitch.
10464 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10465 embedded statement.
10466 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10468 2006-05-02 Raja R Harinath <rharinath@novell.com>
10470 * statement.cs (Do.Resolve): If the loop is infinite, set the
10472 (While.Resolve, For.Resolve): Set a barrier after the embedded
10473 statement. There's no direct control flow that goes from the end
10474 of the embedded statement to the end of the loop.
10475 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10476 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10477 above ensure that the reachability is correctly computed.
10479 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10480 (UsageVector.MergeBreakOrigins): If the current path is
10481 unreachable, treat it as if all parameters/locals are initialized.
10482 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10483 infinite loops before merging-in break origins.
10485 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10486 (Reachability.Reachable): Split part into ...
10487 (Reachability.Unreachable): ... this. Simplify.
10488 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10490 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10491 (Reachability.SetThrowsSometimes): Likewise.
10492 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10493 TriState.Always, use corresponding property.
10494 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10495 (Block.Resolve): Likewise. Remove some redundant checks.
10497 2006-05-02 Raja R Harinath <harinath@gmail.com>
10499 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10500 (Reachability.Meet): Don't bother checking AlwaysThrows --
10501 barrier is always set.
10502 (FlowBranchingBlock.Merge): Likewise.
10504 2006-05-01 Raja R Harinath <harinath@gmail.com>
10506 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10507 checks for unreachable.
10509 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10512 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10514 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10515 whether field is really assigned.
10517 2006-04-30 Raja R Harinath <harinath@gmail.com>
10519 * flowanalysis.cs (Reachability): Make 4-argument constructor
10521 (Reachability.Meet): Rename from 'And'. Remove static variant.
10522 (Reachability.Always): Rename from the highly misleading
10523 'Reachability.Never'.
10524 (FlowBranching.Merge): Update to changes. Mark an impossible
10525 situation with a 'throw'.
10526 (*): Update to changes.
10528 2006-04-29 Raja R Harinath <harinath@gmail.com>
10530 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10531 Remove 'Undefined'.
10532 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10533 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10534 (*): Update to changes.
10535 * statement.cs: Update to changes.
10537 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10540 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10542 2006-04-28 Raja R Harinath <harinath@gmail.com>
10544 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10547 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10548 argument to two arguments: an usage-vector and a bool. Move call
10549 to FlowBranching.Merge () ...
10550 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10552 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10553 handling of loop and switch reachability to ...
10554 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10556 2006-04-27 Raja R Harinath <harinath@gmail.com>
10558 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10559 handling to FlowBranchingLoop.InLoop.
10560 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10562 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10565 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10566 anonymous method is allowed from AnonymousContainer here.
10568 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10570 2006-04-24 Raja R Harinath <rharinath@novell.com>
10573 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10575 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10578 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10579 (DoubleConstant.Reduce): Ditto.
10581 2006-04-23 Raja R Harinath <rharinath@novell.com>
10583 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10584 Remove 'lvalue_right_side' argument. Move parts to ...
10585 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10586 (LocalVariable.DoResolveLValue): ... these.
10588 2006-04-21 Raja R Harinath <rharinath@novell.com>
10591 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10592 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10593 (LocalVariableReference.DoResolveBase): Use it to implement new
10595 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10596 (Argument.Resolve): Simplify. Move CS1510 check ...
10597 * ecore.cs (Expression.ResolveLValue): ... here.
10598 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10599 (PropertyExpr.DoResolveLValue): Likewise.
10600 (FieldExpr.Report_AssignToReadonly): Likewise.
10601 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10602 LValueMemberAccess or LValueMemberOutAccess on instance depending
10604 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10605 DoResolve as appropriate.
10607 2006-04-20 Raja R Harinath <rharinath@novell.com>
10610 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10611 implicit conversions on 'out' and 'ref' arguments.
10613 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10614 improve clarity. Remove dead code.
10617 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10618 (Catch.Resolve): Resolve VarBlock if it exists.
10620 2006-04-19 Miguel de Icaza <miguel@novell.com>
10622 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10623 twice, this was some residual code, the enumerator was emitted
10624 properly in the two branche of if later.
10626 2006-04-19 Raja R Harinath <rharinath@novell.com>
10628 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10629 cast is never an lvalue.
10630 (Cast.DoResolve, Cast.ResolveRest): Combine.
10631 (Argument.Emit): Simplify slightly. Move 'Expr is
10632 IMemoryLocation' check ...
10633 (Argument.Resolve): ... here.
10634 (Argument.Error_LValueRequired): Remove. Inline into only user.
10636 Simplifications. Fix cs0191-2.cs
10637 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10638 CS1649 and CS1651 to ...
10639 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10640 the actual selection of the error code and message to a lookup
10641 table. Add a dummy return value to simplify callsites.
10642 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10643 readonly fields of other instances of the same type. Move CS0197
10645 * expression.cs (Argument.Resolve): ... here. Simplify code.
10646 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10647 resolution of an out or ref argument. The code simplification
10648 above uses this invariant.
10650 2006-04-18 Raja R Harinath <rharinath@novell.com>
10652 Possibly fix #77752. Fix cs1690-[4-7].cs.
10653 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10654 CheckMarshallByRefAccess. Drop parameter.
10655 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10657 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10658 InstanceExpression.
10659 * report.cs (AllWarnings): Add CS1690.
10660 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10661 for ref access too.
10662 (LocalVariableReference.DoResolveBase): Update.
10664 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10666 * class.cs (MethodOrOperator): Moved common parts from method class.
10667 detect obsolete attributes.
10668 (Method.Define): Simplified as it reuses code from base.
10669 (Constructor.ValidAttributeTargets): Fixed issue found during
10671 (Destructor.ValidAttributeTargets): Fixed issue found during
10673 (Operator): Finished refactoring set off by #78020. Operator class is now
10674 ordinary method class.
10676 * anonymous.cs: Updated.
10678 * decl.cs (DeclSpace): Add IsGeneric
10680 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10682 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10684 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10686 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10687 detect obsolete attributes.
10688 (Method.CreateEmitContext): Moved to MethodOrOperator.
10690 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10693 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10694 customized exception to make crash detection easier.
10695 (MethodOrOperator): Started to work on new base class for methods and
10697 (Method): Derives from MethodOrOperator.
10698 (Constructor.Emit): Emits its own attributes.
10699 (AbstractPropertyEventMethod.Emit): Ditto.
10700 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10702 (Operator.Emit): It's temporary more tricky than should be.
10704 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10706 * report.cs (InternalErrorException): Add ctor with inner exception.
10708 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10711 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10714 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10717 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10720 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10722 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10723 attribute is present and Guid not.
10724 (Interface.ApplyAttributeBuilder): Ditto.
10726 * attribute.cs: Add error message.
10728 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10732 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10733 sources (it's composite) so hold them in extra array as they are used in
10734 Emit phase only. It worked in the previous versions by mistake.
10735 (Attribute.Emit): Emit attribute for more owners when exist.
10737 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10738 it has now different behaviour.
10740 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10742 * constant.cs (Constant.IsDefaultInitializer): New method.
10744 * class.cs: Updated.
10746 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10747 re-initialize default values. It saves KBs almost for every assembly.
10748 Thanks Zoltan for the idea.
10749 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10750 (ArrayCreation.DoResolve): Resolve only once.
10751 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10752 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10754 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10756 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10759 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10761 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10762 in an embedded statement too.
10764 2006-04-01 Raja R Harinath <rharinath@novell.com>
10767 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10769 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10773 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10776 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10778 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10780 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10783 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10784 LocalTemporary change.
10786 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10788 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10789 initializers optimization.
10790 (ClassOrStruct.TypeAttr): Moved from modifiers.
10791 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10792 (FieldBase.ResolveInitializer): Resolves initializer.
10793 (FieldBase.HasDefaultInitializer): New property.
10795 * cs-parser.jay: Removed message.
10797 * expression.cs (CompilerGeneratedThis): New specialization.
10799 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10801 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10803 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10805 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10807 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10808 be now EnumConstants only.
10810 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10812 * attribute.cs, driver.cs: Reset more caches.
10814 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10816 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10818 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10820 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10821 for easier reuse. Updated all overrides.
10822 (IntegralConstant): New base class for all integral constants.
10823 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10824 of the constant range, report custom error.
10825 (UIntConstant.Reduce): Fixed uint conversion.
10827 * ecore.cs, literal.cs: Reduce updates.
10829 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10833 * class.cs (Constructor.Define): Removed extra if for default ctors.
10834 A patch from Atsushi Enomoto.
10836 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10838 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10839 GetAttributableValue.
10841 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10844 * convert.cs (ImplicitConversionRequired): Error message moved to
10847 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10848 automatic implicit conversion of an output value.
10849 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10851 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10853 (TypeOf.GetAttributableValue): Add extra handling for object type.
10855 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10856 special error message.
10858 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10860 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10862 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10863 compatible with MS runtime.
10865 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10867 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10868 attribute arguments here.
10870 * class.cs (Indexer.Define): The check was moved to attribute class.
10872 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10874 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10875 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10878 2006-03-22 Raja R Harinath <rharinath@novell.com>
10880 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10881 mcs to keep code differences small.
10882 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10883 * typemanager.cs (parameter_default_value_attribute_type): New.
10884 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10887 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10889 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10891 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10893 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10895 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10898 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10900 * doc-bootstrap.cs : fix build.
10902 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10904 * expression.cs (StringConcat.Append): Issue a warning when empty string
10905 is going to append.
10907 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10909 * assign.cs (CompoundAssign.ResolveSource): Removed.
10911 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10914 * class.cs (TypeContainer.FindMethods): Removed.
10915 (TypeContainer.CheckMemberUsage): Made static.
10917 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10919 * constant.cs (CheckRange): Removed unused type argument.
10920 (CheckUnsigned): Removed unused type argument.
10922 * cs-parser.jay: Updated after MemberAccess clean up.
10923 Uses Length for empty string test.
10925 * cs-tokenizer.cs: Uses Length for empty string test.
10926 (IsCastToken): Made static.
10927 (is_hex): Made static.
10928 (real_type_suffix): Made static.
10930 * decl.cs (SetupCache): Made static.
10931 (OnGenerateDocComment): Removed unused ds argument.
10933 * delegate.cs (VerifyDelegate): Removed unused argument.
10935 * doc.cs: Uses Length for empty string test.
10937 * driver.cs: Uses Length for empty string test.
10939 * enum.cs (IsValidEnumType): Made static
10941 * expression.cs (EnumLiftUp): Removed unused argument.
10942 (ResolveMethodGroup): Ditto.
10943 (BetterConversion): Ditto.
10944 (GetVarargsTypes): Ditto.
10945 (UpdateIndices): Ditto.
10946 (ValidateInitializers): Ditto.
10947 (MemberAccess.ctor): Ditto.
10948 (GetIndexersForType): Ditto.
10950 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10952 * iterators.cs: Updated after MemberAccess clean up.
10954 * location.cs: Uses Length for empty string test.
10956 * namespace.cs: Uses Length for empty string test.
10958 * report.cs (CheckWarningCode): Made static.
10960 * statement.cs (LabeledStatement): Removed unused argument.
10962 * typemanager.cs (FilterNone): Removed.
10964 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10966 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10969 * class.cs: Updated.
10971 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10973 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10975 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10979 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10980 reporting, it's more tricky than I thought.
10982 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10986 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10988 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10989 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10990 Add more error reporting; Fixed issue with params.
10992 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10994 * cs-parser.jay: AnonymousMethod requires host container.
10996 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10998 2006-03-18 Raja R Harinath <harinath@gmail.com>
11000 * class.cs: Change 'TypeContainer ds' constructor argument to
11001 'DeclSpace parent'. Some classes were missed below due to
11002 different naming convention.
11004 * class.cs (MemberCore.Parent): Delete. This makes the
11005 ParentContainer changes below enforceable by the compiler.
11007 Treat pointers to enclosing declaration space as 'DeclSpace', not
11009 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11010 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11012 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11014 (Block.AddThisVariable): Likewise.
11015 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11016 (AbstractPropertyEventMethod.Emit): Likewise.
11017 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11018 (GetMethod.Define, SetMethod.Define): Likewise.
11019 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11020 (DelegateMethod.EmitMethod): Likewise.
11022 Fix regression test-partial-13.cs.
11023 Rationalize use of PartialContainer. Ensure that the partial
11024 class semantics can be tied to type-correctness, i.e., any
11025 violation will cause a compile error.
11026 * class.cs, const.cs: Access all fields that belong to class
11027 TypeContainer via ParentContainer. Arguments of EmitContexts and
11028 Resolve()-like functions still use 'Parent'.
11030 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11031 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11032 (PropertyMethod.CheckModifiers): Remove unused argument.
11033 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11036 2006-03-17 Raja R Harinath <harinath@gmail.com>
11038 Make semantics of PartialContainer simpler.
11039 * decl.cs (DeclSpace.IsPartial): Remove.
11040 * class.cs (TypeContainer.IsPartial): Likewise.
11041 (TypeContainer..ctor): Set PartialContainer to point to self.
11042 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11043 (TypeContainer.FindNestedType): Likewise.
11044 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11046 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11048 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11050 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11052 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11055 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11057 * class.cs (Operator.Define): An error for base conversion was not
11058 reported correctly.
11060 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11062 * iterator.cs : yield break is allowed in try statement which has
11063 catch clauses. Fixed bug #77767.
11065 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11067 A fix for #77593, #77574.
11069 * class.cs (MethodCore.CheckBase): Another if for operator.
11071 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11073 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11076 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11077 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11080 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11083 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11084 Updated after another emitcontext usage was clean up. It should help us to
11085 synchronize with gmcs easier.
11087 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11091 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11092 (Event.Define): ditto
11093 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11095 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11096 Removed redundant code and set NewSlot for Invoke method too.
11098 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11099 (Parameters.MergeGenerated): New method. Use this method when you merge
11100 compiler generated argument with user arguments.
11102 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11104 * attribute.cs (ResolveAsTypeTerminal): Removed.
11106 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11107 specialization for predefined types; 30% speed up.
11108 Finally placed obsolete check to right place.
11109 (Expression.ResolveType): Removed.
11111 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11112 Updated after ResolveType was removed.
11114 * expression.cs (Cast.ctor): Check void cast.
11115 (Binary.ResolveAsTypeTerminal): Is never type.
11116 (Conditional.ResolveAsTypeTerminal): Is never type.
11118 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11120 2006-03-01 Raja R Harinath <rharinath@novell.com>
11123 * expression.cs (ParameterReference.DoResolveBase): Change return
11125 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11129 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11132 * typemanager.cs (GetFullNameSignature): Don't nullref on
11133 protected accessors.
11135 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11137 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11138 these two separated members to simplify the code.
11139 (Attribute.Resolve): Refactored to use new fields and methods.
11140 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11141 implemented obsolete attribute checking.
11142 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11143 implemented obsolete checking again. It look line never ending quest ;-)
11144 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11146 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11148 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11150 *class.cs (Property.Define): Add RegisterProperty call.
11152 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11153 argument groups (only 2).
11155 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11156 encoding expression to arguments.
11157 (Expression.ExprClassToResolveFlags): Just turned to property.
11159 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11160 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11161 optimized as well as implemented support for zero-length attributes.
11163 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11164 Add caching of PropertyInfo's.
11166 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11168 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11169 error multiple times.
11171 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11173 New partial class implementation.
11174 A fix for #77027, #77029, #77403
11176 * attribute.cs (Attributable): Made attributes protected.
11178 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11179 the replacements of ClassPart and PartialContainer.
11180 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11181 (TypeContainer.AddInterface): Ditto.
11182 (TypeContainer.AddPartial): The main method for partial classes. It checks
11183 for errors and merges ModFlags and attributes. At the end class is added to
11184 partial_parts list.
11185 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11187 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11188 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11189 from the rest of partial classes.
11190 (TypeContainer.GetClassBases): Simplified.
11191 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11193 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11194 (TypeContainer.HasExplicitLayout): Uses Flags now.
11195 (PartialContainer): Removed.
11196 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11197 (StaticClass): Was merged with Class.
11198 (Class.GetClassBases): class and static class bases are verified here.
11199 (Class.TypeAttr): Added static attributes when class is static.
11200 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11201 (MemberBase): In some cases we need to call parent container for partial
11202 class. It should be eliminated but it's not easy now.
11204 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11206 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11207 partial classed to accumulate class comments.
11208 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11210 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11212 * driver.cs (MainDriver): Tree.GetDecl was removed.
11214 * modifiers.cs (Modifiers): Add partial modifier.
11216 * tree.cs (Tree.decl): Removed.
11217 (RootTypes): Started to use this class more often for root types
11220 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11224 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11225 external interface does not have an attribute.
11227 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11229 Another prerequisites for new partial classs implementation.
11231 * attribute.cs (Attribute.Equal): Implemented.
11232 (Attribute.Emit): Changed as attributes can be applied more than twice.
11233 (Attributes.Emit): Check for duplicate attributes here.
11235 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11236 as a parameter, clean-up.
11238 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11242 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11243 contains obsolete attribute check which can in some cases look for base
11244 type of current class which is not initialized yet.
11245 (TypeContainer.BaseType): Replacement of ptype.
11247 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11249 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11251 First of prerequisites for new partial classs implemention.
11253 * attribute.cs (Attributable): Extended by ResolveContext;
11254 Attributes finally have correct context for resolving in all cases.
11255 (AttachTo): Attribute owner is assigned here.
11257 * codegen.cs (IResolveContext): Introduce new interface to hold
11258 all information needed in resolving phase.
11259 (EmitContext): Implements IResolveContext; more clean-up needed here.
11261 * decl.cs (MemberCore): Implemented IResolveContext.
11263 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11264 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11265 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11266 Refactored to use new IResolveContext instead of EmitContext; cleanup
11268 2006-02-06 Miguel de Icaza <miguel@novell.com>
11270 * codegen.cs (EmitScopeInitFromBlock): check here the
11271 capture_context, there is no need to make two calls to the
11274 * anonymous.cs: Add some debugging messages that might help me
11275 track other instances of this problem in the future (the
11276 regression of test 467).
11278 * cs-parser.jay: track the variable block, as we need to initalize
11279 any captured variables declared in this block for the "catch"
11280 portion of the "Try" statement.
11282 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11283 scope initialization for captured variables.
11285 Also, move the emit for the variables after the block location has
11288 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11290 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11292 2006-02-02 Miguel de Icaza <miguel@novell.com>
11294 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11295 commit yesterday, the initialization for the roots is necessary.
11296 What is not necessary is the scope activation.
11298 2006-02-02 Raja R Harinath <rharinath@novell.com>
11300 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11301 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11303 (Argument.Resolve): Remove CS0206 checks.
11305 2006-02-01 Miguel de Icaza <miguel@novell.com>
11307 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11308 scopes for all the roots, the scopes will now be emitted when the
11309 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11311 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11312 code. This reduces a lot of existing cruft.
11314 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11315 that the ScopeInfo is generated as we enter the scope, not at the
11316 time of use, which is what we used to do before.
11318 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11319 every time a Block is about to be emitted if we have a
11322 2006-02-01 Raja R Harinath <rharinath@novell.com>
11324 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11326 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11328 * typemanager.cs (cons_param_array_attribute): Make private.
11329 (Reset): Set it to null.
11330 (InitCoreHelpers): Don't initialize it.
11331 (ConsParamArrayAttribute): New. Initialize it as needed.
11332 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11334 2006-01-31 Miguel de Icaza <miguel@novell.com>
11336 * expression.cs: There might be errors reported during the
11337 selection of applicable methods. If there are errors, do not
11338 continue execution as it will lead the compiler to crash.
11340 2006-01-30 Miguel de Icaza <miguel@novell.com>
11342 * expression.cs: Member access is not allowed on anonymous
11343 methods. Fixes #77402.
11345 2006-01-30 Raja R Harinath <rharinath@novell.com>
11348 * cs-parser.jay (VariableDeclaration): Don't set
11349 current_array_type to null.
11350 (field_declaration, event_declaration, declaration_statement):
11351 Set it to null here.
11353 2006-01-28 Raja R Harinath <harinath@gmail.com>
11355 * typemanager.cs (GenericParameterPosition): New.
11358 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11360 * doc.cs : To process "include" elements, first we should create
11361 another list than XmlNodeList, because it could result in node
11362 removal, which could result in that the XmlNodeList gives up
11363 yielding next node.
11365 (Also made code identical to gmcs again.)
11367 2006-01-25 Miguel de Icaza <miguel@novell.com>
11369 * ecore.cs: Introduce an error report that we were not catching
11370 before, if not silent, we must report the error. Gonzalo ran into
11373 2006-01-23 Miguel de Icaza <miguel@novell.com>
11375 A fix for bug: #76957
11377 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11378 ComputeMethodHost before creating the method, this is a new
11381 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11382 that this method references (RegisterScope). The actual scope
11383 where the method is hosted is computed with the ComputeMethodHost
11384 before we create the method.
11386 Moved the Deepest routine here.
11388 (AnonymousContainer.ComputeMethodHost): New routine used to
11389 compute the proper ScopeInfo that will host the anonymous method.
11391 (ScopeInfo): Deal with multiple roots. The problem was that we
11392 did not have a unique root where all ScopeInfos could be hanged
11393 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11396 Remove AdjustMethodScope which is now computed at the end. Remove
11397 LinkScope which did a partial link, instead link all ScopeInfos
11398 before code generation from the new "LinkScopes" routine.
11400 Simplify all the Add* routines as they no longer need to maintain
11401 the tree, they just need to record that they are using variables
11404 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11405 routines to produce the forest of ScopeInfo trees.
11407 * class.cs (TypeContainer.AppendMethod): This is just like
11408 AddMethod, but ensures that an interface implementation method
11409 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11410 methods, but at the end.
11412 We use this functionality to ensure that the generated MoveNext
11413 method in the iterator class is resolved/emitted before the
11414 enumerator methods created.
11416 This is required because the MoveNext method computes the right
11417 ScopeInfo for the method. And the other methods will eventually
11418 need to resolve and fetch information computed from the anonymous
11421 2006-01-21 Raja R Harinath <harinath@gmail.com>
11422 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11424 Fix rest of #76995.
11425 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11426 the 'aliases' hash.
11427 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11428 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11430 2006-01-18 Raja R Harinath <rharinath@novell.com>
11432 Fix #76656, cs0231-2.cs.
11433 * cs-parser.jay (formal_parameter_list): Make error case catch
11435 (parenthesized_expression_0): Add CS1026 check.
11436 (invocation_expression): Remove unused { $$ = lexer.Location }.
11438 2006-01-17 Raja R Harinath <rharinath@novell.com>
11441 * cs-parser.jay (statement_expression): Don't list out the
11442 individual statement-expressions. Convert syntax error into
11445 2006-01-16 Raja R Harinath <rharinath@novell.com>
11448 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11449 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11450 CheckIntermediateModification.
11451 (FieldExpr.DoResolve): Add new two-argument version that
11452 allows us to resolve the InstanceExpression as an lvalue.
11453 The one-argument variant is now just a wrapper.
11454 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11455 Resolve the lhs as an lvalue if the it has a value type.
11456 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11457 from Assign.DoResolve.
11458 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11459 resolved as an lvalue.
11460 (PropertyExpr.DoResolve): Update.
11461 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11462 has a value type. Move CS1612 check here from
11463 CheckIntermediateModification.
11464 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11465 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11466 'right_side' of a ResolveLValue on an 'out' argument.
11467 (EmptyExpression.LValueMemberAccess): New. Used as the
11468 'right_side' of a propagated ResolveLValue on a value type.
11469 (LocalVariableReference.DoResolveBase): Recognize
11470 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11472 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11473 EmptyExpression.Null.
11475 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11477 * typemanager.cs : added IsGenericParameter(). In mcs it always
11479 * doc.cs : for generic parameters, use GenericParameterPosition,
11482 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11484 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11486 2006-01-12 Miguel de Icaza <miguel@novell.com>
11488 This fixes the problem where we used ldfld instead of ldflda to
11489 load the "THIS" pointer on captured parameters, when THIS is a
11490 value type. See bug #77205.
11492 * iterators.cs (CapturedThisReference.Emit): Pass false to
11493 EmitThis (we do not need the address).
11495 * codegen.cs (EmitThis): it needs to know whether we need the
11496 address of `this' or not. This is used by value types.
11498 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11499 every other call passes false.
11501 2006-01-12 Raja R Harinath <rharinath@novell.com>
11504 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11506 * expression.cs (Invocation.OverloadResolve): Update.
11507 (Invocation.DoResolve): Avoid double resolution of invocation.
11509 2006-01-11 Raja R Harinath <rharinath@novell.com>
11512 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11513 unary negation of floating point types as 0-expr; negation cannot
11514 overflow in floating point types.
11517 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11518 on operands of 'void' type.
11521 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11522 and ExclusiveOr for boolean constants too.
11524 2006-01-09 Raja R Harinath <rharinath@novell.com>
11527 * expression.cs (Invocation.OverloadResolve): Replace reflected
11528 override methods with their base virtual methods, rather than
11529 skipping over them.
11530 * typemanager.cs (TypeManager.GetOverride): New.
11532 2006-01-05 Jb Evain <jbevain@gmail.com>
11534 * class.cs (Property.Define, Indexer.Define): do not tag the
11535 properties as SpecialName | RTSpecialName.
11537 2006-01-04 Miguel de Icaza <miguel@novell.com>
11539 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11540 doing a low-level comparission of parameter types. It was lacking
11541 a check for __argslist.
11543 2005-12-30 Miguel de Icaza <miguel@novell.com>
11545 * expression.cs (ParameterReference.DoResolveBase): Allow
11546 reference parameters if they are local to this block.
11548 This allows the ref and out parameters of a delegate to be used in
11549 an anonymous method, for example:
11551 delegate void set (out int x);
11553 set s = delegate (out int x){
11557 This is used by functionality introduced late in the C# language.
11559 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11560 method that take ref and out parameters.
11562 Fixes #77119 which was a late change in the spec.
11564 2005-12-23 Miguel de Icaza <miguel@novell.com>
11566 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11567 parent if its the same scope. Fixes #77060.
11569 2005-12-21 Miguel de Icaza <miguel@novell.com>
11571 * driver.cs: Report the case of no source files and no -out:
11574 2005-12-20 Raja R Harinath <rharinath@novell.com>
11577 * expression.cs (ComposedCast.GetSignatureForError): Define.
11579 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11583 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11584 ListDictionary, to contain the ExternAliasEntry entries (in
11585 addition to the NamespaceEntry.aliases hashtable). This field is
11586 shared between the original entry and its doppelganger (bodyless
11588 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11589 extern_aliases field.
11590 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11591 lookup in extern_aliases.
11593 2005-12-16 Raja R Harinath <rharinath@novell.com>
11596 * class.cs (TypeContainer.Mark_HasEquals): New.
11597 (TypeContainer.Mark_HasGetHashCode): New.
11598 (ClassPart): Override them.
11599 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11602 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11603 'parent' argument to the base constructor.
11605 Remove all mention of TypeContainer from decl.cs.
11606 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11607 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11608 (DeclSpace.DeclSpace): Likewise.
11609 (DeclSpace.DefineMembers): Remove unused argument.
11610 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11611 debugging check -- we don't care if the debug code throws an
11612 InvalidCastException instead of an InternalErrorException.
11613 * class.cs (TypeContainer.DefineMembers): Update to changes.
11614 (TypeContainer.DoDefineMembers): Likewise.
11615 (TypeContainer.GetMethods): Likewise.
11616 (PropertyMember.Define): Likewise.
11617 (MemberBase.Parent): New property that forwards to
11618 MemberCore.Parent, but ensures that we get a TypeContainer.
11619 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11620 (RootContext.PopulateTypes): Likewise. Remove special case code
11621 for !RootContext.StdLib: DefineMembers is idempotent.
11623 2005-12-14 Miguel de Icaza <miguel@novell.com>
11625 * convert.cs (ExplicitConversionCore): Check the return value from
11626 ExplicitConversionCore which can return null on failure. Fixes #76914
11628 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11630 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11632 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11634 * doc.cs : The search for referenced namespace was insufficient to
11635 get global one as it used to do. Fixed bug #76965.
11637 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11639 * doc.cs : check name in cref in the last phase that whether it is
11642 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11644 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11647 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11649 * doc.cs : so it turned out that we cannot skip override check for
11650 interface members. Fixed bug #76954.
11652 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11654 * cs-tokenizer.cs : fixed bug #75984:
11655 - #warning and #error should not be handled when the source line
11657 - #line is not checked strictly when the source line is disabled.
11658 - #define and #undef is on the other hand checked strictly at any
11661 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11663 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11666 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11668 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11670 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11671 event initializers.
11672 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11673 (FieldBase.Initializer): Initializer is now optional.
11674 (EventField.Define): Only event field can have initializer.
11676 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11678 * const.cs (Const): Reuse initializer.
11680 * cs-parser.jay: Updated after FieldBase changes.
11681 Added current_array_type to simplify array initializers.
11683 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11685 * expression.cs, iterators.cs: Updated.
11687 * namespace.cs (NamespaceEntry): Made UsingFound private.
11689 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11691 * parameterCollection.cs: Obsolete, removed.
11692 * parser.cs: Obsolete, removed.
11694 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11697 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11699 * enum.cs (Enum.Define): Set obsolete context here.
11701 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11704 - FindDocumentedMember() now expects 1) paramList as null
11705 when "we don't have to check the number of parameters" and
11706 2) Type.EmptyTypes when "there is no arguments".
11707 - Introduced FoundMember struct to hold the exact type which was
11708 used to find the documented member (the above change broke
11709 test-xml-044; it might be better just to use DeclaringType than
11710 what MS does, like this change does, but it depends on usage.)
11712 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11714 * doc.cs : documented member might be from DeclaringType for nested
11715 types. Fixed bug #76782.
11717 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11719 * anonymous.cs: Have the param code handle leaving copies on the
11720 stack etc. Allows anonymous params to take part in the assignment
11721 code (++, +=, etc). Fixes bug #76550
11723 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11724 it down to the anon code.
11726 * iterators.cs: Use dummy var here
11728 * codegen.cs: Handle new vars
11730 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11733 * class.cs (MethodData.Define): Set proper Obsolete context.
11735 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11737 (FieldExpr.DoResolve): Ditto.
11739 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11742 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11743 parent is not obsolete.
11745 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11747 * doc.cs : (FindDocumentedMember) find parameterless members first
11748 and get CS0419 in the early stage. Fixed first case of bug #76727.
11750 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11753 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11754 no error was reported.
11756 *expression.cs (Binary.DoResolve): left can be null.
11758 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11761 * class.cs (MethodData.Emit): Parameters should be labeled first.
11763 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11766 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11768 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11770 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11772 * class.cs (MethodCore): Parameter clean up.
11773 (IMethodData): Added ParameterInfo.
11774 (MethodData): Parameter clean up.
11775 (Indexer.Define): Parameter clean up.
11787 * typemanager.cs: Parameter clean up.
11789 * delegate.cs (Define): Get rid of duplicated code.
11791 * expression.cs (ParameterReference): Removed useless parameters
11793 (Invocation): Ditto.
11795 * parameter.cs (ParamsParameter): New class, params specialization.
11796 (ArglistParameter): Attemp to separate arglist.
11797 (Parameter): Refactored to be reusable and faster.
11798 (Parameter.Modifier): Made understandable.
11799 (Parameters): Changed to be used as a class for `this' assembly
11800 parameters. Refactored to use new specialized classes.
11802 * support.cs (ParameterData): Added Types property.
11803 (InternalParameters): Deleted.
11805 2005-08-20 Martin Baulig <martin@ximian.com>
11807 Merging this patch from GMCS to fix #75867.
11809 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11810 scope if we don't already have it.
11812 2005-11-17 Martin Baulig <martin@ximian.com>
11815 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11816 inherit the scope from our parent. Fixes #76653.
11818 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11820 * doc.cs : the previous patch does not actually fix the bug.
11821 PropertyInfo override check is now implemented and really fixed it.
11822 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11824 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11826 * doc.cs : apply "override filter" also to properties.
11829 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11831 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11832 no need to check overrides. For classes, omit those results from
11833 interfaces since they must exist in the class. Fixed bug #76726.
11835 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11837 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11838 with different parameters. Fixed the second problem in #76685.
11840 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11842 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11843 get expected 'protected' access in CheckValidFamilyAccess()).
11846 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11848 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11849 Fixed bug #76705. CS1569 was incorrectly commented out.
11851 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11853 * doc.cs : use Invocation.IsOverride() to do real override check.
11854 * expression.cs : made Invocation.IsOverride() internal.
11856 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11858 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11859 TypeBuilder.FindMembers() and filter overriden base members out.
11862 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11864 * doc.cs : ref/out parameters are represented as '@' (instead of
11865 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11867 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11869 * doc.cs : when there was no '.' in cref to methods in doc comment,
11870 then parameters were missing in the output. Fixed bug #76691.
11872 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11874 * driver.cs : don't output docs when there is an error.
11877 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11880 Now it should detect indexers. Fixed primary concern in bug #76685.
11881 Fixed CS0419 message to not show the identical member signature in
11884 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11886 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11887 instead of Type.FindMembers() since it does not handle events.
11890 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11892 * codegen.cs: Fixed typo (speficied -> specified).
11894 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11897 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11899 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11901 * attribute.cs: Changed error message.
11903 * cs-tokenizer.cs: One more check.
11905 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11907 * statement.cs (Block.Resolve): Ignore empty statement.
11909 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11911 * report.cs: Made error/warning methods more strict to avoid
11914 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11915 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11916 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11917 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11919 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11921 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11922 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11924 * class.cs (TypeContainer.IsComImport): New property.
11925 (Constructor.Define): Create proper ctor for ComImport types.
11927 * expression.cs (New.CheckComImport): Fixed.
11929 2005-11-07 Miguel de Icaza <miguel@novell.com>
11931 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11932 that a parameter has been captured does not mean that we do not
11933 have to do the rest of the processing. This fixes the second part
11934 of #76592. If there was another anonymous method capturing
11935 values in the past, the Scope would never be set for the second
11936 method that captured the same parameter.
11938 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11939 properly manipulate the stack. Second part of fix for #76592.
11941 * expression.cs (New): Add support for invoking "new" on
11942 interfaces that have been flagged with the ComImport attribute and
11943 the CoClass. Fixes #76637
11945 * statement.cs (Try.DoEmit): When a variable is captured, do not
11946 try to emit the vi.LocalBuilder variable as it has been captured.
11947 Create a temporary variable and store the results on the
11948 FieldBuilder. Fixes #76642
11950 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11952 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11954 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11956 * expression.cs (Binary.DoResolve): Added && optimalization.
11958 * typemanager.cs (AddUserType): Removed useless argument.
11960 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11962 * statement.cs (Block.variables): Uses ListDictionary.
11964 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11967 * class.cs (PartialContainer.EmitType): Customized to emit
11968 security attributes.
11969 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11970 for partial classes.
11972 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11975 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11976 access has to be fixed.
11978 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11980 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11983 * ecore.cs (NullCast.Reduce): Implemented.
11985 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11988 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11990 (Foreach.Resolve): Catch null properly.
11992 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11994 * cs-tokenizer.cs: Warning text fix.
11996 * driver.cs: AllWarningNumbers exposed on public interface.
11998 * report.cs (): Reviewed warning numbers.
11999 (IsValidWarning): Use binary search.
12001 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12003 * driver.cs: Implemeted resource visibility.
12004 (Resources): New class for code sharing between /res: and
12007 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12010 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12013 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12016 * ecore.cs (NullCast): Child is contant only.
12018 * literal.cs (NullLiteral.Reduce): null can be converted to any
12021 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12023 * driver.cs: Use Encoding.Default as default code page instead
12026 2005-10-27 Raja R Harinath <rharinath@novell.com>
12029 * expression.cs (Invocation.Error_InvalidArguments): Handle
12030 __arglist parameters.
12031 (Invocation.VerifyArgumentsCompat): Likewise.
12032 * support.cs (ReflectionParameters.GetSignatureForError): Print
12033 __arglist parameters.
12034 (InternalParamters.GetSignatureForError): Likewise.
12035 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12037 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12039 * attribute.cs (GetPropertyValue): Made public.
12041 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12043 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12045 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12048 * driver.cs: Reflect method name change.
12050 * statement.cs (Try.Resolve): Warn when try has both general
12051 exception handlers.
12053 * typemanager.cs: runtime_compatibility_attr_type new predefined
12056 2005-10-26 Raja R Harinath <harinath@gmail.com>
12059 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12060 treat it as an empty parameter list.
12062 2005-10-26 Raja R Harinath <rharinath@novell.com>
12065 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12066 ResolveAsTypeStep silent.
12067 * statement.cs (Block.AddConstant): Mark block as used.
12068 (Block.ResolveMeta): Avoid piling on error messages
12069 if a constant initializer resolution fails.
12071 2005-10-25 Raja R Harinath <rharinath@novell.com>
12073 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12075 (NamespaceEntry.VerifyAllUsing): New.
12076 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12077 behaviour. Delegates actual resolution of alias to ...
12078 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12079 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12081 * driver.cs (Driver.MainDriver): Update.
12083 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12084 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12086 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12088 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12089 RootNamespace.DefineNamespacesForAll.
12091 2005-10-24 Raja R Harinath <harinath@gmail.com>
12093 * typemanager.cs (assemblies, external_aliases, modules)
12094 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12095 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12096 overhead. Move resposibility ...
12097 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12098 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12100 2005-10-23 Raja R Harinath <harinath@gmail.com>
12102 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12103 cached_namespaces. Improve usage.
12104 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12105 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12106 Move from GlobalRootNamespace and simplify.
12107 (RootNamespace.Global): Make instance variable.
12108 (RootNamespace.RootNamespace): Add "alias name" parameter.
12109 (GlobalRootNamespace): Simplify drastically.
12110 (Namespace.Lookup): Don't use GetNamespace.
12111 * typemanager.cs (GetRootNamespace): Rename from
12112 ComputeNamespaceForAlias.
12113 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12115 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12117 * anonymous.cs (AnonymousContainer): Don't crash when container
12120 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12122 * expression.cs (Binary.DoResolve): Warn when comparing same
12125 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12128 * expression.cs (Binary.DoResolve): It looks like there are no
12129 convetsion rules in enum context.
12131 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12133 Add support for extern alias qualifiers.
12134 * typemanager.cs: Move some LookupTypeReflection code
12135 to namespace.cs, to have cleaner code. Added some methods
12136 to help us keep track of the extern aliased references.
12137 * driver.cs: Add suport for extern alias assemblies on command
12138 line and check for their warnings/errors. Also keep track of the
12139 extern aliased assemblies.
12140 * namespace.cs: Move the global functionality of Namespace
12141 to GlobalRootNamespace/RootNamespace. Now the global namespace
12142 is GlobalRootNamespace.Globa. Also the code moved from
12143 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12144 Finally added LocalAliasEntry (AliasEntry before) and
12145 ExternAliasEntry, to handle alias statements.
12146 * cs-parser.jay: Add support in the grammar for extern alias
12148 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12149 Update callings to Namespace (now in GlobalRootNamespace).
12151 2005-10-18 Raja R Harinath <rharinath@novell.com>
12154 * class.cs (TypeContainer.DefineType): Move updating of
12155 topological sort earlier in the code.
12156 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12158 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12161 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12163 * constant.cs (Constant.TryReduce): Moved from Cast class.
12164 (Reduce): Made little bit more OO and fixed missing conversions.
12166 * ecore.cs (Reduce): Implemented.
12167 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12169 * literal.cs (Reduce): Implemented.
12171 * class.cs: Reverted Miguel's wrong commit.
12173 2005-10-14 Miguel de Icaza <miguel@novell.com>
12175 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12177 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12179 * cs-parser.jay, expression.cs : CS0214 was missing error location
12180 for constants. Fixed bug #76404.
12182 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12185 * convert.cs (ExplicitConversionCore): Fixed object->enum
12188 2005-10-10 Raja R Harinath <rharinath@novell.com>
12190 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12191 InstanceExpression.
12192 (PropertyExpr.EmitCall): Likewise.
12193 * expression.cs (Invocation.EmitArguments): Handle case where
12195 (Invocation.EmitCall): Avoid allocating temporary variable if
12196 there are no arguments.
12198 2005-10-07 Raja R Harinath <rharinath@novell.com>
12201 * convert.cs (ImplicitConversionStandard): Move conversion of
12202 void* to arbitrary pointer types ...
12203 (ExplicitConversionStandard): .. here.
12204 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12205 error to always print typenames.
12207 2005-10-07 Raja R Harinath <rharinath@novell.com>
12209 * convert.cs (GetConversionOperator): Rename from
12210 GetConversionOperators. Move operator selection code from ...
12211 (UserDefinedConversion): ... here.
12213 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12215 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12218 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12220 * assign.cs (Assign.DoResolve): Error method changed.
12222 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12224 * const.cs (ResolveValue): Reset in_transit immediately.
12226 * constant.cs: Error method changed.
12228 * convert.cs: Removed useless location parameter.
12229 (ExplicitNumericConversion): Don't do double enum check.
12230 (ExplicitConversionCore): Renamed from ExplicitConversion.
12231 (ExplicitUnsafe): Extracted from ExplicitConversion.
12232 (ExplicitConversion): Uses for error reporting.
12234 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12236 (ResolveBoolean): Uses common error method.
12237 (CastToDecimal): Get rid of ec.
12238 (CastFromDecimal): Optimized.
12239 (ConvCast): Get rid of ec.
12241 * enum.cs (ResolveValue): Reset in_transit immediately.
12242 (Emit): Return after first error.
12244 * expression.cs: Convert changes.
12246 * literal.cs: Error method changed.
12248 * statement.cs: Error method changed.
12250 2005-10-03 Raja R Harinath <rharinath@novell.com>
12252 * support.cs (SeekableStreamReader.Position): Don't error out when
12253 the requested position is just beyond the end of the current
12256 2005-09-28 Raja R Harinath <rharinath@novell.com>
12258 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12259 try to keep in sync with the byte count of the underlying Stream.
12260 However, this limits us to a window size of 2048 characters: i.e.,
12261 the maximum lookahead of our lexer/parser can be 2048 characters.
12263 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12266 * driver.cs: Fix compilation files with full root path.
12268 2005-09-25 Miguel de Icaza <miguel@novell.com>
12270 * report.cs (SymbolRelatedToPreviousError): Format the output so
12271 it does not use an open parenthesis that is never closed.
12273 * driver.cs: Follow coding guidelines
12275 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12278 * const.cs (Const.ResolveValue): Check for assigning non-null
12279 value to reference type.
12281 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12283 * anonymous.cs: Implemented ExprClassName.
12285 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12288 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12291 * class.cs (StaticClass.DefineContainerMembers): Report protected
12294 * codegen.cs: if(ed) PRODUCTION.
12296 * convert.cs (Error_CannotImplicitConversion): Better error
12299 * cs-parser.jay: More error checks.
12301 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12303 * driver.cs (CSCParseOption): Enabled wrong option check.
12305 * ecore.cs (Expression.ExprClassName): Turned to property.
12306 (MemberExpr.CheckIntermediateModification): For checking boxed
12307 value types modification.
12309 * statement.cs (Fixed.Resolve): Expression type must be
12310 convertible to fixed type.
12311 (CollectionForeach.GetEnumeratorFilter,TryType):
12312 Small refactoring for easier error checking.
12314 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12316 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12319 * class.cs (GeneratedBaseInitializer): New class for customization
12320 compiler generated initializers.
12321 (MemberBase.DoDefine): Check Obsolete attribute here.
12322 (FieldMember.DoDefine): Ditto.
12324 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12327 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12328 (MemberCore.GetObsoleteAttribute): Removed argument.
12329 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12330 (MemberCore.CheckObsoleteType): New helper.
12334 * statement.cs: Updates after MemberCore changes.
12336 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12337 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12339 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12340 obsolete attribute for compiler construct.
12341 (As.DoResolve): Cache result.
12343 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12345 2005-09-26 Raja R Harinath <rharinath@novell.com>
12348 * expression.cs (This.VerifyFixed): In a value type T, the type of
12349 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12350 value type R, 'this' is treated as a value parameter.
12352 2005-09-22 Miguel de Icaza <miguel@novell.com>
12354 * statement.cs (Lock): Use the TemporaryVariable class instead of
12355 manually using local variables as those do not work when variables
12358 * ecore.cs: Moved the TemporaryVariable class from being a nested
12359 class inside Foreach to be a public class that can be employed in
12362 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12364 * cs-parser.jay: interface_accessors replaced by
12365 accessor_declarations.
12367 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12370 * statement.cs (GotoCase.Resolve): Convert null constant to
12372 (SwitchLabel.ResolveAndReduce): Ditto.
12373 (SwitchLabel.NullStringCase): Custom null stamp.
12374 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12376 typemanager.cs (CSharpSignature): Don't skip first argument
12379 2005-09-18 Miguel de Icaza <miguel@novell.com>
12381 * driver.cs: Set InEmacs based on the environment variable EMACS.
12383 * location.cs (InEmacs): in this mode, do not report column
12384 location as it confuses Emacs.
12386 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12388 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12389 expression.cs, iterators.cs, literal.cs: Store constants and
12392 * class.cs (MemberBase.ShortName): Pass location.
12394 * cs-parser.jay: Some location fixes.
12396 * ecore.cs (Expression.Location): Made virtual.
12398 2005-09-05 Miguel de Icaza <miguel@novell.com>
12400 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12401 if the underlying types are the same, otherwise we need to produce
12402 code that will do the proper cast.
12404 This was exposed by Marek's constant rewrite which produced
12405 invalid code for the call site:
12407 enum X : long { a }
12408 void Method (X v) {}
12412 This fixes test-49.cs
12414 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12416 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12417 Type/Object should be allowed as well. Fixed bug #75968.
12419 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12421 * expression.cs : (Binary.DoResolve): when one is enum constant and
12422 another is constant 0, then return enum one *as enum type*.
12425 2005-09-02 Raja R Harinath <rharinath@novell.com>
12427 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12431 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12432 flow-branching for LocalVariableReferences in case we were invoked
12433 from a MemberAccess.
12434 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12436 (LocalVariableReference.DoResolveBase): ... this.
12437 (MemberAccess.Resolve): Do the check that was disabled during
12440 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12443 (PartialContainer.Create): check abstract/sealed/static strictly
12444 but abstract/sealed can exist only at one side. Fixed bug #75883.
12446 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12449 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12450 specified, don't default to UnmanagedType.I4.
12452 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12454 * expression.cs : conditional operator should check possibly
12455 incorrect assign expression. Fixed bug #75946.
12457 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12459 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12460 Reverting the change. gmcs is much complex than mcs on this matter.
12462 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12464 * cs-tokenizer.cs : To read another token ahead of the actual
12465 consumption, use new SavedToken and cache token instead of moving
12466 back the stream with SeekableStreamReader (it seemed problematic).
12468 driver.cs : Thus use StreamReader directly.
12469 * support.cs : Thus removed SeekableStreamReader.
12471 2005-08-30 Raja R Harinath <rharinath@novell.com>
12474 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12475 (ScopeInfo.EmitScopeType): Use it to construct field names from
12476 names of captured locals.
12479 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12480 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12481 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12482 (ExplicitConversion): Remove enum cases already handled by
12483 implicit conversion. Move implicit conversion check to the beginning.
12484 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12485 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12486 Don't treat System.Enum as a struct.
12488 2005-08-30 Jb Evain <jbevain@gmail.com>
12490 * attribute.cs: handles as expression in parameters.
12492 2005-08-30 Raja R Harinath <rharinath@novell.com>
12495 * class.cs (TypeContainer.VerifyClsName): Don't use a
12496 PartialContainer when verifying CLS compliance.
12497 (AbstractPropertyEventMethod): Set Parent here, ...
12498 (PropertyMethod): ... not here.
12500 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12502 * attribute.cs : escaped attribute name should not be allowed to be
12503 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12505 2005-08-29 Raja R Harinath <rharinath@novell.com>
12508 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12509 when converting a long constant to unsigned long.
12510 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12511 detect where IsApplicable and VerifyArgumentsCompat disagree.
12513 2005-08-29 Raja R Harinath <rharinath@novell.com>
12514 and Carlos Alberto Cortez <carlos@unixmexico.org>
12517 * class.cs (TypeContainer.CanElideInitializer): New helper.
12518 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12519 can safely emitting the initializer of a field.
12521 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12523 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12524 allowed inside a switch (without loop). Fixed bug #75433.
12526 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12528 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12529 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12531 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12533 * driver.cs : kinda reverting the default encoding changes (not exact
12534 revert since I noticed that "codepage:reset" might not work fine).
12536 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12538 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12539 Location. Now getter and setter store location correctly.
12540 (errors/cs0111-12.cs now reports the expected location.)
12542 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12544 * driver.cs : Use default encoding on the environment.
12545 Removed (now that) extra parameter for SeekableStreamReader.
12546 * support.cs : (SeekableStreamReader) third .ctor() argument for
12547 StreamReader is not required (always true). preamble size could
12548 be acquired in simpler and safe way.
12550 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12552 * cs-parser.jay: report CS0642 at warning level 3
12553 and report CS0642 for an if else statement also
12554 fixes bug #74745. Patch by John Luke (and a bit
12556 Removed extra CS0642 warning check for "while",
12558 * statement.cs: In Block.Resolve(), CS0642 check
12559 is reimplemented to check a sequence of an empty
12560 statement and a block.
12562 Both fix bug #66777.
12564 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12566 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12567 detection until I fix it.
12569 * cs-tokenizer.cs: Changed error message.
12571 * cs-parser.jay: Fixed 2 error locations.
12573 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12574 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12577 * enum.cs (GetSignatureForError): Fixed.
12579 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12583 * typemanager.cs (RegisterProperty): Removed.
12585 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12587 2005-08-24 Raja R Harinath <rharinath@novell.com>
12590 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12591 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12593 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12595 * expression.cs : tiny fix is required for not warning positive ulong.
12598 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12600 * expression.cs : add CS0652 check for constant and integral
12601 expression. Fixed bug #53974.
12603 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12605 * expression.cs : in DoNumericPromotions(), check if there is implicit
12606 conversion overload for string (to check CS0034). Fixed bug #52492.
12608 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12610 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12612 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12614 * ecore.cs : report location when it is *not* Null.
12616 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12622 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12623 correctly. Fixed bug #75721.
12625 2005-08-23 Raja R Harinath <rharinath@novell.com>
12627 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12628 loop that performs 'min (pos, char_count)'.
12631 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12632 converted value in Operator.OnesComplement.
12634 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12636 * anonymous.cs: If the anon method is pulled into a helper class,
12637 it needs to be `internal' not `private'. Fixes runtime behavior on
12640 2005-08-20 Martin Baulig <martin@ximian.com>
12642 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12643 scope if we don't already have it.
12645 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12646 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12649 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12652 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12653 is a partial class.
12655 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12657 The big constants rewrite
12658 Fix #75746, #75685 and more
12659 As a side effect saved 1MB for MWF ;-)
12661 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12662 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12663 enum based for corlib compilation.
12665 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12668 * class.cs (FixedField.Define): Use ResolveAsConstant.
12670 * const.cs (IConstant): Interface constants and enums.
12671 (Const.ResolveValue): New method for constant resolvning.
12672 (ExternalConstant): Constants from imported assemblies.
12674 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12675 conversion; like enums.
12676 (Constant.ToType): Converts this constant to different type.
12677 (Constant.Increment): Adds 1.
12679 * convert.cs (ImplicitConversionRequired): Simplified.
12681 * cs-parser.jay: Create EnumMember directly.
12683 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12685 * doc.cs (GenerateEnumDocComment): Removed.
12687 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12688 (ConvertIntLiteral): Removed.
12689 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12691 * enum.cs (EnumMember): Implement IConstant.
12692 (Enum.IsValidEnumConstant): Removed.
12693 (Enum.GetNextDefaultValue): Removed.
12694 (Enum.FindMembers): Updated.
12695 (Enum.GenerateDocComment): Iterate enum members.
12697 * expression.cs (Cast.TryReduce): Handle enums correctly.
12698 (New.Constantify): Made public.
12699 (MemberAccess.DoResolve): Removed contant specific if(s).
12701 * literal.cs (NullLiteral): Implement new abstract methods.
12703 * statement.cs (GotoCase.Resolve): Use new constant methods.
12704 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12706 * typemanager.cs (LookupEnum): Removed.
12707 (IsEnumType): Fixed to work with corlib.
12708 (RegisterConstant): Removed.
12709 (LookupConstant): Removed.
12710 (GetConstant): Changed to work with IConstant.
12712 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12714 * location.cs : Fixed overflown (>255) column number.
12716 2005-08-03 Raja R Harinath <rharinath@novell.com>
12718 First cut of the qualified-alias-member feature.
12719 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12721 * cs-parser.jay (DOUBLE_COLON): New token.
12722 (namespace_or_type_name): Add rule for recognizing
12723 qualified-alias-members.
12724 (primary_expression): Likewise.
12725 (element_access): Allow QualifiedAliasMember as a possible
12726 type-bearing expression.
12727 (local_variable_type, local_variable_pointer_type): Likewise.
12728 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12729 aliases in the current and enclosing namespace declarations.
12730 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12731 * decl.cs (MemberName.is_double_colon): New.
12732 (MemberName.MemberName): Add new constructor for alias-member.
12733 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12734 * expression.cs (QualifiedAliasMember): New expression type.
12736 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12738 * location.cs : it borked when no argument was specified.
12740 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12742 * location.cs : tiny ToString() format fix.
12744 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12746 * statement.cs : oops, it was missing.
12748 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12750 A set of fixes for precise line/column location.
12753 "token" field now holds a file/line "delta", a line number offset
12754 from the segment, and a column number. See also:
12755 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12756 December/009508.html
12757 Removed static IsNull. Use instance IsNull property instead.
12758 * cs-tokenizer.cs :
12759 For some tokens it stores Location. For Identifier it stores
12760 LocatedToken which is a pair of string name and location.
12761 Column numbers are adjusted only at getChar().
12763 Use Location.ToString() for reporting (it now contains column).
12765 Largely modified to use LocatedToken instead of
12766 string (IDENTIFIER), and to acquire Location from some tokens.
12767 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12768 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12770 Now MemberName holds Location. DeclSpace.ctor() receives Location
12771 as a parameter. Removed extra parameters to all derived classes.
12772 Replaced Location.IsNull() with instance property.
12773 * assign.cs, expression.cs :
12774 Added .ctor() overload that omits Location.
12776 Added "nameEscaped" flag that indicates the identifier was escaped
12777 in the source file. This fixes bug #57047.
12779 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12781 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12782 New method, looking for lo-case imported cls type.
12784 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12787 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12789 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12791 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12792 all_imported_types.
12793 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12795 Optimized to save 3.5 MB for SWF compilation.
12797 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12799 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12800 (PartialContainer.Create): Moved logic AddToContainer.
12801 (PartialContainer.MarkForDuplicationCheck): Shares name.
12803 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12806 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12808 (Namespace.GetSignatureForError): New method.
12810 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12811 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12813 2005-08-01 Raja R Harinath <rharinath@novell.com>
12816 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12817 member lookup rather than qualifier_type, since qualifier_type can
12820 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12822 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12825 2005-07-31 Miguel de Icaza <miguel@novell.com>
12827 * statement.cs: Copy the local exception into the exception
12828 captured local. Fixes 75674
12830 2005-07-31 Raja R Harinath <harinath@gmail.com>
12833 * expression.cs (Invocation.OverloadResolve): Don't report error
12834 CS1501 if error CS1502 has been reported.
12835 (New.DoResolve): Delegate CS1501 reporting to
12836 Invocation.OverloadResolve.
12839 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12840 invariant-meaning-in-block property in an enclosing block if
12843 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12845 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12846 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12847 (Switch.CheckSwitch): Just save 50kb for SWF.
12849 2005-07-27 Martin Baulig <martin@ximian.com>
12851 * anonymous.cs (CaptureContext.AddField): Added
12852 `AnonymousContainer am' argument; compute its toplevel scope if
12853 it's not already computed. Fixes #75649.
12855 2005-07-26 Raja R Harinath <rharinath@novell.com>
12858 * class.cs (Constructor.Emit): Reset block to null if the block
12861 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12863 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12865 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12867 * class.cs (MethodData.Define): Check whether accessor implementing
12868 interface is public.
12870 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12872 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12875 * namespace.cs (LookupType): Moved same type check to...
12877 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12878 with the same name.
12880 2005-07-21 Raja R Harinath <rharinath@novell.com>
12882 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12883 already found a typebuilder.
12884 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12885 MemberNames, not strings.
12887 * const.cs (Error_ExpressionMustBeConst):
12888 Rename from Error_EpressionMustBeConst.
12889 * const.cs, class.cs, statement.cd: Update.
12891 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12895 * const.cs (Const.LookupConstantValue): Report missing contant expression
12897 (Error_EpressionMustBeConstant): Only one error method.
12899 * class.cs, statement.c: Updated.
12901 2005-07-20 Raja R Harinath <rharinath@novell.com>
12903 * statement.cs (Block.Flags): Add back HasVarargs.
12904 (Block.flags): Make protected.
12905 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12907 * typemanager.cs (types, typecontainers, user_types): Remove.
12908 (UserTypes, TypeContainers): Likewise.
12909 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12910 (CleanUp, Reset): Update.
12911 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12912 (GetNestedType): Use Type.GetNestedType.
12913 (CoreLookupType): Take two arguments, the namespace and the
12914 basename of the type. Update to use the Namespace.Lookup
12916 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12917 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12918 string concatenation and substring matches.
12919 * class.cs, enum.cs, delegate.cs: Update to changes.
12921 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12923 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12924 Expression and made virtual.
12926 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12927 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12929 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12931 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12934 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12937 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12940 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12941 AssemblyCultureAttribute is not used on executable.
12944 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12946 2005-07-16 Raja R Harinath <rharinath@novell.com>
12949 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12950 New. Reports CS0252/CS0253.
12951 Mostly taken from preliminary patch by Duncak Mak.
12952 (Binary.DoResolveOperator): Store results of operator lookup.
12953 Use them to detect if we need to warn about unintended reference
12956 2005-07-15 Raja R Harinath <rharinath@novell.com>
12959 * namespace.cs (Namespace.Lookup): Add back location parameter.
12960 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12961 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12963 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12964 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12965 (Namespace.LookupType): ... this.
12966 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12968 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12969 purported to handle pointers.
12970 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12973 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12975 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12978 2005-07-15 Raja R Harinath <rharinath@novell.com>
12980 * namespace.cs (Namespace.Lookup): Drop location parameter.
12981 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12982 (NamespaceEntry.Lookup): ... this.
12983 (NamespaceEntry.Error_AmbiguousTypeReference):
12984 Move here from DeclSpace.
12985 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12987 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12988 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12989 Move to NamespaceEntry.
12990 * delegate.cs, expression.cs: Update to changes.
12992 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12994 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12995 CheckAttributeType and refactored.
12996 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12997 ResolveAsTypeTerminal error handling.
12998 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13000 (GetSignatureForError): Print errors in same way.
13003 * codegen.cs: Reflect attribute GetSignatureForError change.
13006 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13008 * namespace.cs (UsingEntry): Refactored to make fields private.
13011 statement.cs: Error_UnexpectedKind has extra parameter.
13013 2005-07-14 Raja R Harinath <rharinath@novell.com>
13015 * ecore.cs (IAlias): Remove.
13016 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13017 that implement the interface.
13018 * namespace.cs (Namespace): Likewise.
13019 (Namespace.declspaces): Renamed from 'defined_names'.
13020 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13021 DeclSpace instead of an IAlias.
13022 * tree.cs (Tree.AddDecl): Update.
13024 2005-07-12 Raja R Harinath <rharinath@novell.com>
13026 * statement.cs (Block.Flags); Remove HasVarargs.
13027 (Block.HasVarargs): Move to ToplevelBlock.
13028 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13029 (Block.Variables): Make protected. Initialize variable hashtable
13031 (Block.AddVariable): Update.
13032 (Block.Resolve): Update to changes.
13033 (ToplevelBlock.HasVarargs): New boolean.
13034 (ToplevelBlock.ThisVariable): Move here from Block.
13035 (ToplevelBlock.AddThisVariable): Likewise.
13036 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13037 * expression.cs (This.ResolveBase): Update to changes.
13038 (ArglistAccess.DoResolve): Likewise.
13040 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13043 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13045 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13046 not used and not used & assigned.
13047 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13049 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13052 * expression.cs (Is.DoResolve): null is never provided type.
13054 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13057 * cs-parser.jay: Less strict event error rule to catch more errors.
13059 2005-07-08 Martin Baulig <martin@ximian.com>
13061 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13062 gettter (allowed) or setter (not allowed).
13064 * class.cs (Accessor): Implement IIteratorContainer.
13065 (Accessor.Yields): New public field.
13066 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13067 per-accessor basis.
13070 (get_accessor_declaration, set_accessor_declaration): Set the
13071 `yields' flag on the accessor, not the property.
13072 (property_declaration): Do the iterators check on a per-accessor
13073 basis and not for the whole property.
13075 2005-07-08 Martin Baulig <martin@ximian.com>
13077 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13078 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13080 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13083 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13084 (ExtractSecurityPermissionSet): Cope with self referencing security
13085 attributes properly.
13087 * driver.cs (SetOutputFile): Made public property OutputFile.
13089 2005-07-07 Raja R Harinath <rharinath@novell.com>
13092 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13093 has_nonstatic_fields. Make into a FieldBase pointer.
13094 (TypeContainer.AddField): Add CS0282 check.
13095 (TypeContainer.EmitType): Update.
13097 2005-07-06 Miguel de Icaza <miguel@novell.com>
13099 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13100 compare if they start with __.
13102 2005-07-06 Raja R Harinath <rharinath@novell.com>
13104 * statement.cs (Switch.SwitchGoverningType): Only look at
13105 UserCasts that don't need implicit standard conversions to one of
13106 the allowed switch types (Fixes test-322.cs).
13107 (LocalInfo.Resolve): Re-enable sanity-test.
13109 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13111 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13113 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13115 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13117 2005-07-06 Raja R Harinath <rharinath@novell.com>
13120 * ecore.cs (SimpleName.GetSignatureForError): Add.
13121 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13122 (MemberAccess.GetSignatureForError): Add.
13124 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13126 The big error and warning messages review.
13156 * typemanager.cs: Updated.
13158 * class.cs: (MethodCore.SetYields): Moved here to share.
13159 (PropertyMethod.Define): Moved iterator setup here.
13161 * iterators.cs: Add orig_method to have full access to parent
13164 2005-07-05 Raja R Harinath <rharinath@novell.com>
13166 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13167 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13168 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13169 variable of struct type.
13170 * expression.cs (Unary.ResolveOperator): Update to change.
13171 (Indirection.VerifyFixed): Likewise.
13172 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13173 (ParameterReference.VerifyFixed): Value parameters are fixed.
13174 (This.VerifyFixed): Treat 'this' as a value parameter.
13175 * statement.cs (LocalInfo.IsFixed): Remove.
13177 2005-07-01 Martin Baulig <martin@ximian.com>
13179 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13180 `ec.EmitThis ()' to get the correct scope.
13182 2005-07-01 Martin Baulig <martin@ximian.com>
13184 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13185 instance is a ParameterReference; fixes #75299.
13187 2005-07-01 Martin Baulig <martin@ximian.com>
13189 Reverted Marek's latest patch (r46725):
13190 - it contains structural changes which are neither mentioned in
13191 the ChangeLog nor explained anywhere; for example the additional
13192 argument of EmitContext's and Iterator's .ctor's and the
13193 TypeContainer.DefineMembers() change.
13194 - structural changes like this should go in in seperate patches
13195 and not be hidden in a huge patch which just seems to affect
13196 warnings and errors.
13197 a big and hard to understand patch.
13198 - it breaks iterators and causes regressions, for instance in
13201 2005-06-30 Raja R Harinath <rharinath@novell.com>
13204 * expression.cs (Indexers.map): Remove.
13205 (Indexers.Append): Filter out inaccessible setters and getters.
13206 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13209 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13210 Refactored from ...
13211 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13212 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13213 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13214 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13216 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13219 * class.cs (FieldBase.GetInitializerExpression): One more field
13222 2005-06-28 Miguel de Icaza <miguel@novell.com>
13224 * pending.cs: Do not define a proxy if the base method is virtual,
13225 it will be picked up by the runtime (bug 75270).
13227 2005-06-08 Martin Baulig <martin@ximian.com>
13229 The big Iterators rewrite :-)
13231 * iterators.cs: Rewrite this to use the anonymous methods framework.
13233 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13234 before the TypeContainers; see 2test-21.cs.
13237 (TypeContainer.DefineType): Don't create a new EmitContext if we
13238 already have one (this only happens if we're an Iterator).
13239 (TypeContainer.Define): Also call Define() on all our iterators.
13240 (Method.CreateEmitContext): Added support for iterators.
13243 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13244 (AnonymousContainer.CreateMethodHost): Moved here from
13245 AnonymousMethod and made abstract.
13246 (AnonymousContainer.CreateScopeType): New abstract method.
13247 (AnonymousContainer.IsIterator): New public property.
13248 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13249 get the ScopeTypeBuilder rather than manually defining it here.
13250 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13253 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13254 before RootContext.DefineTypes().
13256 * codegen.cs (EmitContext.RemapToProxy): Removed.
13257 (EmitContext.CurrentAnonymousMethod): Changed type from
13258 AnonymousMethod -> AnonymousContainer.
13259 (EmitContext.ResolveTopBlock): Protect from being called twice.
13260 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13261 (EmitContext.EmitThis): Removed the iterators hacks; use the
13262 anonymous methods framework for that.
13265 (ToplevelBlock.Container): Make this a property, not a field.
13266 (ToplevelBlock.ReParent): New public method; move the
13267 ToplevelBlock into a new container.
13268 (Foreach.TemporaryVariable): Simplify.
13270 2005-06-05 Martin Baulig <martin@ximian.com>
13272 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13273 (Block.AddTemporaryVariable): New public method; creates a new
13274 `LocalInfo' for a temporary variable.
13275 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13277 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13278 non-iterator variables.
13280 2005-06-05 Martin Baulig <martin@ximian.com>
13282 * statement.cs (Foreach.TemporaryVariable): Create the
13283 LocalBuilder in the Emit phase and not in Resolve since in some
13284 situations, we don't have an ILGenerator during Resolve; see
13285 2test-19.cs for an example.
13287 2005-06-04 Martin Baulig <martin@ximian.com>
13289 **** Merged r45395 from GCS ****
13291 The big Foreach rewrite - Part II.
13293 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13294 with `PropertyInfo ienumerator_getcurrent'.
13296 * codegen.cs (VariableStorage): Removed.
13299 (Foreach): Derive from Statement, not ExceptionStatement.
13300 (Foreach.CollectionForeach): New nested class. Moved all the code
13301 dealing with collection foreach here.
13302 (Foreach.ForeachHelperMethods): Removed.
13303 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13305 2005-05-23 Martin Baulig <martin@ximian.com>
13307 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13308 don't need to. Fix #75014.
13310 2005-05-20 Martin Baulig <martin@ximian.com>
13312 Merged r44808 from GMCS.
13314 * class.cs (TypeContainer.CircularDepException): Removed.
13315 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13316 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13317 (CS0146) and interface (CS0529) dependencies here.
13319 2005-06-21 Raja R Harinath <rharinath@novell.com>
13321 * expression.cs (Invocation.EmitCall): Fix initialization
13322 'this_call' to reflect current behaviour. Fix indentation.
13324 * convert.cs (FindMostEncompassedType): Add two trivial special
13325 cases (number_of_types == 0 || number_of_types == 1).
13326 (FindMostEncompasingType): Likewise.
13328 2005-06-17 Raja R Harinath <rharinath@novell.com>
13330 Some cleanups preparing for the fix of #75283.
13331 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13333 (EventExpr.InstanceResolve): Likewise.
13334 (EventExpr.DoResolve): Remove redundant checks.
13336 2005-06-10 Duncan Mak <duncan@novell.com>
13338 * cs-tokenizer.cs (process_directives): New flag for controlling
13339 the processing of preprocessor directives.
13340 (x_token): After seeing a '#', return Token.NONE instead of going
13341 to handle_preprocessing_directive() when not processing
13342 directives. This avoids unnecessary processing during the token peek in
13347 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13348 the existing error reporting methods instead of Report.Error.
13350 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13351 after Raja's rewrite.
13353 2005-06-08 Miguel de Icaza <miguel@novell.com>
13355 * class.cs: Small fix.
13357 2005-06-08 Raja R Harinath <rharinath@novell.com>
13360 * class.cs (GetPartialBases): Fix return value check of
13361 part.GetClassBases.
13363 2005-06-07 Raja R Harinath <rharinath@novell.com>
13365 Ensure that partial classes are registered in their enclosing
13366 namespace. Initial part of fix of #75160.
13367 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13368 Register declspace with namespace here, not in
13369 DeclSpace.RecordDecl.
13370 * cs-parser.jay: Pass namespace to RecordDecl.
13371 * class.cs (PartialContainer.Create): Likewise.
13372 (ClassPart.DefineType): New sanity-check. Throws an exception if
13374 * decl.cs (Declspace.RecordDecl): Remove.
13375 * namespace.cs (NamespaceEntry.DefineName): Remove.
13377 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13379 * rootcontext.cs: Reset TargetExt as well.
13381 2005-06-03 Raja R Harinath <rharinath@novell.com>
13383 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13384 -langversion:ISO-1.
13386 2005-06-02 Raja R Harinath <rharinath@novell.com>
13388 Fix #75080, cs0119.cs.
13389 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13391 (Expression.Resolve): ... this. Use it. Remove bogus code
13392 allowing ExprClass.Type and ExprClass.Namespace for
13393 ResolveFlags.VariableOrValue.
13394 (Expression.Resolve) [1-argument variant]: Change default resolve
13395 flags based on language version.
13396 (Expression.Error_UnexpectedKind): Use a simple string array
13397 rather than an ArrayList.
13398 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13399 not ExprClass.Type.
13400 (TypeOfVoid.DoResolve): Likewise.
13401 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13402 flags argument -- it always has the same value.
13404 2005-05-31 Raja R Harinath <rharinath@novell.com>
13407 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13408 Use it in the error message.
13409 * assign.cs, expression.cs, statement.cs: Update.
13411 2005-05-30 Raja R Harinath <rharinath@novell.com>
13414 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13415 the "almostMatchedMember" case too.
13416 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13417 that failed the accessibility checks to 'almost_match'.
13419 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13421 * attribute.cs: Use internal MethodBuilder methods to set
13422 ExactSpelling and SetLastError on PInvoke methods, instead
13423 of passing them via charset. Fixes #75060.
13425 2005-05-27 Raja R Harinath <rharinath@novell.com>
13427 * parameter.cs (Parameter): Remove TODO comment.
13428 (Parameter.DefineParameter): Remove Location parameter.
13429 (Parameters.LabelParameters): Likewise.
13430 * class.cs (Constructor.Emit): Update to change.
13431 (MethodData.Emit): Likewise.
13432 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13433 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13435 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13438 Removed Parameters.Location and added Parameter.Location instead.
13439 Removed Location parameter from Emit() and GetSignature().
13446 Modified all related calls.
13448 2005-05-26 Raja R Harinath <rharinath@novell.com>
13450 Improve user-defined conversion handling.
13451 * convert.cs (GetConversionOperators): Rewrite. Return only the
13452 applicable operators.
13453 (AddConversionOperators): New. Helper for GetConversionOperators.
13454 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13455 there is only one most encompassed/encompassing type.
13456 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13457 "applicable operator" handling.
13458 (UserConversion): Move cache here from GetConversionOperators.
13459 Directly cache the chosen operator, rather than the whole
13461 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13462 case. Allow conversion of decimal to sbyte and byte too.
13463 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13464 New static methods. Used to avoid allocating EmptyExpressions in
13467 2005-05-24 Duncan Mak <duncan@novell.com>
13469 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13470 another class, used in Convert.ExplicitNumericConversion.
13471 (CastToDecimal): New class, similar to above, but casts to
13472 System.Decimal, used in Convert.ImplicitNumericConversion and also
13473 in explicit convesion from double/float to decimal.
13475 * convert.cs (ImplicitNumericConversion): Handle implicit
13476 conversions to System.Decimal.
13477 (ExplicitNumericConversion): handle explicit conversions to
13482 2005-05-20 Miguel de Icaza <miguel@novell.com>
13484 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13485 know the type at this stage, just break through. Fixes #75008
13487 2005-05-19 Martin Baulig <martin@ximian.com>
13490 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13491 to disable error reporting.
13493 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13494 here since we don't want to report an error; see the new test-336.cs.
13496 2005-05-19 Raja R Harinath <rharinath@novell.com>
13498 * statement.cs (ToplevelBlock.GetParameterReference)
13499 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13500 Move here from class Block.
13501 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13502 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13504 2005-05-18 Martin Baulig <martin@ximian.com>
13509 (FlowBranching.Reachability): Add non-static public And() and Or()
13511 (FlowBranchingSwitch): New class; do the `break_origins' thing
13512 like in FlowBranchingLoop.
13513 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13514 reachability, not just locals and parameters.
13515 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13516 switch; MergeBreakOrigins() now takes care of that.
13518 2005-05-18 Martin Baulig <martin@ximian.com>
13520 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13521 a loop and may leave it, reset the barrier; fixes #74974.
13523 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13525 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13528 * cs-parser.jay: Catch more lexical errors.
13530 * report.cs: Add one more Error method.
13533 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13535 2005-05-17 Martin Baulig <martin@ximian.com>
13537 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13540 2005-05-16 Raja R Harinath <rharinath@novell.com>
13542 Fix test-382.cs. Emit values of decimal constants.
13543 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13545 (TypeContainer.AddField): ... this.
13546 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13547 with initializers to include 'Const's.
13548 (ClassPart.RegisterFieldForInitialization): Forward to
13550 * const.cs (Const.Const): Pass initializer to base class.
13551 (Const.Define): In case of decimal constants, register them for
13552 initialization in a static constructor.
13554 2005-05-14 Martin Baulig <martin@ximian.com>
13556 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13557 do not call ResolveUnreachable() on unreachable statements in
13558 here, see the comment in the source code.
13560 2005-05-13 Raja R Harinath <rharinath@novell.com>
13563 * expression.cs (BinaryResolveOperator): If one of the operands of
13564 an equality comparison is 'null' and the other is a pointer type,
13565 convert the null to a NullPointer.
13566 * convert.cs (ImplicitReferenceConversion): If the expression is a
13567 NullLiteral and the target type is a pointer type, return a
13568 NullPointer instead.
13569 (ImplicitConversionStandard): Likewise.
13571 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13573 * cs-parser.jay: Set readonly context based on special constructs.
13575 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13576 readonly variable error handling.
13578 * rootcontext.cs (EmitCode): Don't verify members when error
13581 * statement.cs (LocalInfo): Add reaodnly context information.
13582 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13584 2005-05-13 Raja R Harinath <rharinath@novell.com>
13586 * statement.cs (Block.Resolve): Revert change below. Modify fix
13587 for #74041 to initialize 'resolved' to false only for explicit
13588 blocks. Fixes #74873.
13590 2005-05-12 Raja R Harinath <harinath@gmail.com>
13593 * typemanager.cs (unmanaged_enclosing_types): New.
13594 (IsUnmanagedType): Avoid infloops by using
13595 'unmanaged_enclosing_types' to talk with recursive invocations.
13597 2005-05-13 Martin Baulig <martin@ximian.com>
13599 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13600 instance variable, not a local. Fix #74873.
13601 (Block.ResolveUnreachable): Set it to true here.
13603 2005-05-11 Duncan Mak <duncan@novell.com>
13605 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13606 continuing to process for 'arg'.
13607 (handle_preprocessing_directive): Check the argument of the #endif
13608 directive and report error CS1025 if there are any trailing
13611 According to the C# spec, having even whitespace after the #endif
13612 directive is illegal; however, because we call arg.TrimEnd ()
13613 beforehand, we have the same behavior as csc, allowing whitespace
13614 after the directive.
13618 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13622 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13623 (Constructor.GetObsoleteAttribute): Implemented correctly.
13625 2005-05-10 Martin Baulig <martin@ximian.com>
13627 * support.cs (ReflectionParameters.ParameterModifier): Use
13628 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13629 and `ParameterAttributes.In'. Fixes #74884.
13631 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13633 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13635 * expression.cs (Argument.GetParameterModifier): Turned to property.
13636 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13638 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13641 2005-05-09 Raja R Harinath <rharinath@novell.com>
13644 * decl.cs (MemberCache.AddMethods): Register override methods,
13645 rather than non-override methods.
13646 * typemanager.cs (RegisterOverride): New.
13647 (IsOverride): Update.
13649 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13653 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13654 recursive declaration.
13656 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13658 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13660 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13662 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13664 2005-05-05 Raja R Harinath <rharinath@novell.com>
13667 * decl.cs (DeclSpace.FamilyAccessible):
13668 Use TypeManager.IsNestedFamilyAccessible.
13670 Fix reopened #64812.
13671 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13674 2005-05-04 Raja R Harinath <rharinath@novell.com>
13675 Abin Thomas <projectmonokochi@rediffmail.com>
13676 Anoob V E <projectmonokochi@rediffmail.com>
13677 Harilal P R <projectmonokochi@rediffmail.com>
13680 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13681 allow access to all static members.
13683 2005-05-04 Martin Baulig <martin@ximian.com>
13685 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13687 2005-05-04 Martin Baulig <martin@ximian.com>
13691 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13692 section at the end; make things work if `default' is not the last
13695 2005-05-04 Martin Baulig <martin@ximian.com>
13699 * statement.cs (Switch): Replaced the `got_default' field with a
13700 `default_section' one.
13701 (Switch.CheckSwitch): Set `default_section' here.
13702 (Switch.Resolve): If we're a constant switch and the constant is
13703 not found, use the default section.
13705 2005-05-03 Martin Baulig <martin@ximian.com>
13707 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13709 * statement.cs (Foreach.ArrayForeach): New nested class.
13710 (Foreach.TemporaryVariable): New nested class.
13711 (Foreach.EmitArrayForeach): Removed; this is now in the new
13712 ArrayForeach class.
13714 2005-05-03 Raja R Harinath <rharinath@novell.com>
13716 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13718 (VerifyPendingMethods): Revert change below.
13720 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13721 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13722 that used to trigger warning -28. Remove warning -28.
13723 * expression.cs (Invocation.OverloadResolve): Use
13724 TypeManager.IsOverride to distinguish override methods.
13727 * pending.cs (VerifyPendingMethods): If a base type implements the
13728 requested interface, don't bother checking individual methods of
13729 the base type. As a side-effect, this prevents the creation of
13730 unnecessary proxies.
13732 2005-05-02 Martin Baulig <martin@ximian.com>
13736 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13737 Also `And' the locals if the old vector is null.
13738 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13739 null; in this case we basically reset all the variables.
13741 2005-05-02 Martin Baulig <martin@ximian.com>
13745 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13746 Added `FlowBranching branching' argument; always `and' the
13747 variables instead of `or'ing them unless we're an infinite loop.
13749 * statement.cs (While.Resolve): Create a new sibling unless we're
13752 2005-05-02 Martin Baulig <martin@ximian.com>
13756 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13757 arguments; use it instead of creating a new TopLevelBlock.
13758 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13759 our ConstructorInitializer.
13762 (TopLevelBlock.TopLevelBranching): New public property.
13763 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13764 and create our `TopLevelBranching'.
13766 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13767 anonymous method host, use `block.TopLevelBranching' rather than
13768 creating a new branching.
13770 2005-04-20 Miguel de Icaza <miguel@novell.com>
13772 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13773 a ScopeInfo, if any of the current children is a child of the new
13774 entry, move those children there.
13776 2005-04-30 Martin Baulig <martin@ximian.com>
13778 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13779 at the beginning of a SwitchSection. Fix #73335.
13781 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13784 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13786 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13787 (FieldExpr.DoResolve): Obsolete members are ignored for field
13790 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13792 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13793 of arrays detection.
13795 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13797 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13799 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13802 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13804 * cs-parser.jay: Use the prefered version of -unsafe in error
13807 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13809 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13812 2005-04-20 John Luke <john.luke@gmail.com>
13814 * driver.cs: fix typo in error message, --outout to --output
13816 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13818 * codegen.cs (InRefOutArgumentResolving): New field.
13820 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13821 fields outside contructor.
13823 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13825 2005-04-19 Miguel de Icaza <miguel@novell.com>
13827 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13828 parameter code was not completed ever, so it was not as up-to-date
13829 as local variables. Must finish it.
13831 The bug fix was to compare the Toplevel of the block, not the
13832 current block. Thanks for Ben for pointing this out.
13834 2005-04-19 Raja R Harinath <rharinath@novell.com>
13836 * decl.cs (AddMethods): Use the declaring type of the problem
13837 method to determine if we want to squash a warning.
13839 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13841 * attribute.cs: Removed debug output.
13843 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13845 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13848 2005-04-18 Raja R Harinath <rharinath@novell.com>
13851 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13852 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13853 all null comparisons against reference types.
13855 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13858 * class.cs (TypeContainer.CircularDepException) New nested
13860 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13861 (TypeContainer.DefineType): Removed error, reset InTransit before
13863 (Class.DefineType): Throw exception when is in Transit.
13864 Catch exception and report error.
13865 (Struct.DefineType): Throw exception when is in Transit.
13866 Catch exception and report error.
13867 (Interface.DefineType): Throw exception when is in Transit.
13868 Catch exception and report error.
13870 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13871 handle nested exception handlers.
13873 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13876 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13877 InFinally and InCatch storage.
13879 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13880 (Catch.Resolve): Set and Restore ec.InCatch.
13881 (Try.Resolve): Set and Restore ec.InFinally.
13882 (Try.HasCatch): True when try has catch.
13884 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13886 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13887 for the same event member, so exclude such cases from warning 419.
13890 2005-04-16 Miguel de Icaza <miguel@novell.com>
13892 * expression.cs (Binary.ResolveOperator): Apply patch from John
13893 Luke to fix bug 59864: operators &, | and ^ on enumerations
13894 require that the same enum type on both sides.
13896 * driver.cs: Add warnings to old flag usage, this is to assist
13897 people who produce Makefiles and hope that the Makefiles will be
13900 * class.cs (TypeContainer.EmitType): Moved the definition of the
13901 special $PRIVATE$ field from the resolve phase to the Emit phase.
13902 During resolve we do not know if we are a struct with
13903 HasExplicitLayout, we know this only after the attributes for the
13906 Set the FieldOffset to zero on the dummy field that we create for
13907 the class. Fixes 74590.
13909 2005-04-16 Raja R Harinath <rharinath@novell.com>
13912 * ecore.cs (PropertyExpr.resolved): New.
13913 (DoResolve): Use it to handle a case of double resolution here.
13914 Handle a case of identical-name-and-type-name.
13915 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13916 resolution by storing the results of expression resolution back
13917 into the "probes" array.
13919 2005-04-15 Raja R Harinath <rharinath@novell.com>
13921 Fix cs0208-7.cs and cs0208-8.cs.
13922 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13923 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13924 error reporting to point out the reason a struct is not unmanaged.
13926 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13928 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13929 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13931 2005-04-13 Raja R Harinath <rharinath@novell.com>
13934 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13935 IdenticalNameAndTypeName here.
13936 (EventExpr.InstanceResolve): Likewise.
13938 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13940 C# 2.0 DefaultCharSetAttribute implementation
13942 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13943 which allows us to set GlobalNamespace for every resolve.
13944 (Attribute.ResolveArguments): Cut from Resolve.
13945 (Attribute.GetCharSetValue): Returns CharSet named argument.
13946 (Attribute.DefinePInvokeMethod): Gets default charset from
13948 (GlobalAttribute.ResolveAsTypeStep): Override.
13949 (GlobalAttribute.ResolveArguments): Override.
13951 * class.cs (TypeAttr): Is protected.
13953 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13954 (ModuleClass.DefaultCharSetType): New memeber.
13955 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13957 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13958 charset from module.
13960 * delegate.cs (TypeAttr): Override.
13961 (Delegate.DefineType): Use this TypeAttr.
13963 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13964 at very early stage (before types are defined) to resolve model
13965 module attributes. It will probably not work with corlib but it
13968 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13969 charset from module.
13971 * typemanager.cs (default_charset_type): New type.
13973 2005-04-13 Raja R Harinath <rharinath@novell.com>
13975 * decl.cs (MemberCache.AddMethods): Don't warn if
13976 System.Object.Finalize has buggy MethodAttributes.
13978 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13981 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13983 * doc.cs : detect ambiguous reference to overloaded members.
13984 Fixed bug #71603. MS 1.1 csc does not detect it.
13986 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13988 * doc.cs : delegates must not be referenced with parameters.
13991 2005-04-12 Miguel de Icaza <miguel@novell.com>
13993 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13995 2005-04-10 Miguel de Icaza <miguel@novell.com>
13997 * driver.cs (MainDriver): Stop processing if the CLS stage found
14000 (CompilerCallableEntryPoint.InvokeCompiler): Always
14001 reset after execution; Take a TextWriter argument for the
14004 * report.cs: Use the error stream instead of hardcoding stderr.
14006 2005-04-09 Miguel de Icaza <miguel@novell.com>
14008 * class.cs: Reduce code paths to test, too small of an
14009 optimization to make it worth the extra testing. Always perform
14012 2005-04-08 Raja R Harinath <rharinath@novell.com>
14015 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14016 operators that had errors reported on them.
14018 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14020 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14022 (Attribute.Resolve): Add named argument type checking.
14024 * class.cs (FixedField.Define): Use IsPrimitiveType
14026 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14028 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14029 unsafe parameter types.
14031 * statement.cs (Using.ResolveExpression): Add better error description.
14033 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14035 2005-04-08 Raja R Harinath <rharinath@novell.com>
14038 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14039 AttributeUsageAttribute in the emitcontext of the attribute class,
14040 not in the emitcontext of the attributable entity it was attached to.
14041 * cs-parser.jay: Use 'current_class', not 'current_container',
14042 when creating a GlobalAttribute.
14044 2005-04-08 Alp Toker <alp@atoker.com>
14046 * pending.cs: The fix to #58413 failed to compile methods implementing
14047 interfaces with/without params modifiers and vice versa, even though
14048 params modifiers aren't part of the signature. Make the modifier check
14049 less strict as in csc.
14051 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14052 Anoob V E <projectmonokochi@rediffmail.com>
14053 Harilal P R <projectmonokochi@rediffmail.com>
14056 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14057 modifiers of pending methods.
14058 (PendingImplementation.PendingImplementation): Initialize it.
14059 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14060 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14061 with ParameterData. Add check for modifiers.
14062 * class.cs (MethodData.Define): Update to changes.
14064 2005-04-07 Raja R Harinath <rharinath@novell.com>
14066 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14068 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14070 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14073 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14076 * typemanager.cs: Registered RequiredAttributeAttribute.
14078 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14080 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14081 Warning CS0169 is back at level 3.
14082 (IMethodData.SetMemberIsUsed): New method.
14084 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14085 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14087 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14089 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14091 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14094 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14097 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14098 to avoid the problems with nested types.
14100 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14101 Anoob V.E <projectmonokochi@rediffmail.com>
14102 Harilal P.R <projectmonokochi@rediffmail.com>
14103 Raja R Harinath <rharinath@novell.com>
14106 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14108 * typemanager (GetConstructor): Make public.
14110 2005-04-05 John Luke <john.luke@gmail.com>
14111 Raja R Harinath <rharinath@novell.com>
14114 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14115 struct too. Return false quicker in a few cases.
14116 (VerifyUnManaged): Use it.
14118 2005-04-05 Raja R Harinath <rharinath@novell.com>
14121 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14122 not 'unreachable_seen'.
14124 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14126 * attribute.cs (Attribute.GetValue): Removed unused.
14128 * codegen.cs (CodeGen.TrimExt): Removed unused.
14130 * cs-parser.jay (output): Removed unused.
14132 * cs-tokenizer.cs (hex_digits): Removed unused.
14134 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14136 * expression.cs (Indirection.LoadExprValue): Removed unused.
14137 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14139 * iterators.cs (Iterator.param_types): Removed unused.
14141 * statement.cs (Goto.block): Removed unused.
14142 (ToplevelBlock.did): Removed unused.
14143 (Switch.ResolveConstantSwitch): Removed unused.
14145 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14147 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14150 2005-04-01 Raja R Harinath <rharinath@novell.com>
14152 Fix #74232 and cs0208-3.cs.
14153 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14154 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14155 unmanaged type. Don't use FieldBuilders when 't' is a
14156 TypeBuilder. Use ModFlags and MemberType fields.
14157 * class.cs (MemberBase.member_type): Rename from MemberType.
14158 (MemberBase.MemberType): New property. Determines member_type on
14160 (MemberBase.DoDefine): Don't initialize MemberType here.
14161 (FieldMember.Define): Likewise.
14163 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14166 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14167 Attributes are emitted there.
14169 2005-04-01 Raja R Harinath <rharinath@novell.com>
14171 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14172 keyword in 'partial enum' too.
14173 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14175 Report from Kamil Skalski <nazgul@omega.pl>.
14178 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14179 have partial containers too.
14181 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14182 in block' checks to Block.CheckInvariantMeaningInBlock.
14183 * statement.cs (Block.GetKnownVariableInfo): Make private.
14184 (Block.IsVariableUsedInChildBlock): Remove.
14185 (Block.IsVariableUsedInBlock): Likewise.
14186 (Block.CheckInvariantMeaningInBlock): New. Show location of
14187 conflicting declaration.
14188 (Block.AddVariable): Make error messages less long-winded and more
14189 specific. Show location of conflicting declaration.
14190 * parameter.cs (Parameters.Location): New readonly property.
14192 2005-03-31 Raja R Harinath <rharinath@novell.com>
14194 Clean up semantics of invoking ResolveMemberAccess.
14195 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14196 can have an instance, ensure that we pass in a non-TypeExpression
14197 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14198 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14199 argument. Update to changes and simplify.
14200 (FieldExpr.Emitinstance): Remove CS0120 check.
14201 (PropertyExpr.EmitInstance): Likewise.
14202 * expression.cs (Argument.Resolve): Likewise.
14203 (Invocation.DoResolve): Update to changes in semantics of
14204 InstanceExpression.
14206 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14209 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14212 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14214 2005-03-31 Raja R Harinath <rharinath@novell.com>
14216 Fix difference in behaviour with commandline invocation.
14217 * driver.cs (Driver.Reset): New.
14218 (CompilerCallableEntryPoint): Call it.
14220 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14221 variable" warnings if the boolean expression failed to resolve.
14223 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14225 * attribute.cs: Fix the union of several permissions when some of them
14226 are unrestricted (so the result isn't an unrestricted permission set).
14229 2005-03-30 Raja R Harinath <rharinath@novell.com>
14231 * ecore.cs (MemberExpr): New class. Convert from interface
14233 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14234 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14236 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14237 (MethodGroupExpr.IsExplicitImpl): Remove.
14238 (Expression.GetFieldFromEvent): Remove.
14239 (SimpleName.MemberStaticCheck): Remove.
14240 (SimpleName.DoSimpleNameResolve): Update to changes.
14241 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14242 (MemberAccess.IdenticalNameAndTypeName): Remove.
14243 (MemberAccess.error176): Move to MemberExpr.
14244 (MemberAccess.DoResolve): Update to changes.
14245 (BaseAccess.DoResolve): Likewise.
14247 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14249 C# 2.0 Conditional attribute class implementation
14251 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14252 Analyzes class whether it has attribute which has ConditionalAttribute
14253 and its condition is not defined.
14255 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14256 (Class.IsExcluded): New method. Search for at least one defined
14257 condition in ConditionalAttribute of attribute class.
14259 2005-03-30 Raja R Harinath <rharinath@novell.com>
14261 * ecore.cs (PropertyExpr): Derive from Expression, not
14262 ExpressionStatement.
14263 (PropertyExpr.EmitStatement): Remove.
14265 2005-03-29 Raja R Harinath <rharinath@novell.com>
14268 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14269 internal field "value__" of an enum be private. The examples for
14270 "value__" that I found on MSDN all used FieldAttributes.Private.
14272 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14273 Don't mention IL method attribute names.
14275 Fix #47991. Remove a TODO.
14276 * statement.cs (Block.Toplevel): Make into a field.
14277 (Block.Parameters): Move into ToplevelBlock.
14278 (Block.known_variables): Rename from child_variable_names.
14279 (Block.Block): Remove variants that take Parameters. Initialize
14280 'Toplevel' with the immediately surrounding toplevel block.
14281 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14282 LocalInfo parameter.
14283 (Block.GetKnownVariableInfo): New.
14284 (Block.IsVariableNameUsedInChildBlock): Update.
14285 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14286 the block, even though it may not be in scope.
14287 (Block.AddVariable): Remove Parameters parameter. Use
14288 Toplevel.Parameters instead.
14289 (Block.AddConstant): Remove Parameters parameter.
14290 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14291 (Block.IsParamaterReference): Likewise.
14292 (Block.IsLocalParameter): Likewise. Simplify a lot.
14293 (ToplevelBlock.Parameters): New. Moved from Block.
14294 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14295 initialize Parameters to a non-null value.
14296 * cs-parser.jay: Update to changes.
14297 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14298 simple names that mean different things in the same block. Use
14299 Block.IsVariableNameUsedInBlock.
14301 2005-03-28 Raja R Harinath <rharinath@novell.com>
14303 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14304 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14305 GetTypeHandle. It is possible for a reflected type to derive from
14306 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14307 System.Array during mscorlib compilation).
14308 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14309 contain a method_hash, don't create one either. Don't create a
14310 deep copy of the base cache's method_hash.
14311 (MemberCache.SetupCache): Rename back from DeepCopy.
14312 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14313 already initialized. If we see an override function, add its
14314 underlying base virtual function to the member_hash too.
14316 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14318 2005-03-26 Raja R Harinath <harinath@acm.org>
14321 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14322 fails to resolve, ensure that the LHS is still resolved as an
14325 2005-03-25 Raja R Harinath <harinath@acm.org>
14327 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14329 (Enum.current_ec): Remove.
14330 (Enum.LookupEnumValue): Remove EmitContext argument.
14331 Just uses the one created during DefineType.
14332 (Enum.FindMembers): Update.
14333 * expression.cs (MemberAccess.DoResolve): Update.
14335 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14337 * assign.cs (Assign.DoResolve): Check for CS1717 when
14338 source and target are same (uses Equals).
14340 * expression.cs (LocalVariableReference, ParameterReference,
14341 This): Implemented Equals, GetHashCode.
14343 * statement.cs (Block.GetParameterReference): Removed useless
14346 2005-03-22 Raja R Harinath <rharinath@novell.com>
14349 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14350 blocks before deciding whether the error is cs0136 or cs0128.
14352 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14353 (using_alias_directive, using_namespace_directive): Pass
14354 MemberName, not an expression to Namespace.UsingAlias and
14356 (MakeName): Use the MemberName of the namespace.
14357 * namespace.cs (Namespace.MemberName): New.
14358 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14359 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14361 * decl.cs (MemberName.Name): Make readonly.
14362 (MemberName.FromDotted): New "constructor".
14363 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14364 (MemberCore.Name): Compute from MemberName on demand.
14365 (MemberCore.SetMemberName): Provide a way to change the
14367 (MemberCore.AddToContainer): Don't take a fullname parameter.
14368 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14369 fully qualified name of the container to the member name.
14370 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14371 only if the type is a member of the root container.
14372 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14373 MemberName.Left rather than searching for an embedded ".".
14374 (PartialContainer.CreatePart): Update to changes in RootContext.
14375 (MemberBase.ShortName): Turn into a property. Use
14376 MemberCore.SetMemberName.
14377 (MemberBase.ExplicitInterfaceName): Remove.
14378 (MemberBase.UpdateMemberName): Remove.
14379 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14380 (PropertyBase.SetMemberName): New override.
14381 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14382 (Tree.GetDecl): New.
14383 (Tree.AllDecls): Rename from Decls.
14384 * attribute.cs, enum.cs, report.cs: Update to changes.
14385 * driver.cs (MainDriver): Use MemberName.FromDotted on
14386 RootContext.MainClass.
14388 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14390 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14393 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14395 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14397 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14398 property accessor modifiers.
14400 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14401 fixed buffer attribute (CS1716).
14402 (PropertyMethod.HasCustomAccessModifier): When property accessor
14403 has custom modifier.
14405 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14407 (PropertyExpr.DoResolveLValue): Add CS0272.
14409 2005-03-17 Miguel de Icaza <miguel@novell.com>
14411 * convert.cs: When converting to a pointer, use the proper Conv.U
14412 or Conv.I depending on the source data type.
14414 * cs-tokenizer.cs: Make the size for large decimal constants,
14417 2005-03-17 Martin Baulig <martin@ximian.com>
14419 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14420 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14422 2005-03-17 Martin Baulig <martin@ximian.com>
14424 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14425 to bool so we can return an error condition.
14426 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14429 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14431 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14434 2005-03-16 Raja R Harinath <rharinath@novell.com>
14436 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14437 Refactor to avoid traversing the list of assemblies, and to avoid
14438 string concatenation.
14439 * typemanager.cs (guid_attr_type): Remove.
14440 (negative_hits, pointers, references): Remove hashes.
14442 (GetConstructedType): New. Uses type_hash to handle constructed
14443 types (arrays, references, pointers).
14444 (GetReferenceType, GetPointerType): Use it.
14445 (GetNestedType): New. Uses type_hash to handle nested types of
14447 (LookupType, LookupTypeDirect): Remove.
14448 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14449 'types' hash and LookupTypeReflection directly.
14450 (params_string, params_object): Use GetConstructedType.
14451 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14453 (Namespace.Lookup): Use cached_types.
14454 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14455 provided by old TypeManager.LookupType.
14456 * rootcontext.cs (MakeFQN): Remove.
14457 * decl.cs (DeclSpace.MakeFQN): Likewise.
14458 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14459 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14460 TypeManager.GetConstructedType.
14461 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14463 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14465 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14468 * cs-parser.jay: Reports CS1527 for any namespace element.
14470 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14473 * expression.cs (ParameterReference.IsAssigned): Changed error to
14475 (Error_WrongNumArguments): Moved CS0245 detection here.
14477 * statement.cs (Return.Resolve): Add CS1622 report.
14479 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14481 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14483 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14485 * attribute.cs expression.cs: Get rid of some allocations.
14487 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14489 * doc.cs : just eliminate the latest change.
14491 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14493 * doc.cs : commented out the latest change. It breaks xml-030.cs
14495 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14497 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14498 fail. So invoke CreateType() in FindDocumentedType().
14500 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14502 * cs-tokenizer.cs : added IsKeyword().
14503 * doc.cs : Detect keyword incorrectly used as identifier.
14504 Allow identifiers prefixed by @.
14506 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14508 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14509 It caused exception in namespace resolving (again!).
14511 * class.cs (Class.ctor): Removed exit.
14512 (PropertyMethod.ctor): ditto.
14514 * codegen.cs (Codegen.Reset): Reset static data.
14515 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14517 * cs-tokenizer.cs (Cleanup): Removed.
14519 * driver.cs (GetSystemDir): Rewrote to one line command.
14520 It caused problem with unloaded dynamic modules.
14521 (UnixParseOption): Removed Exit.
14522 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14523 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14524 Now can be mcs used as library.
14526 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14529 * location.cs (Reset): Reset static data.
14531 * namespace.cs (Reset): Reset static data.
14533 * report.cs (Report.Reset): Reset static data.
14535 * rootcontext.cs (RootContext.Reset): Reset static data.
14537 * tree.cs (RootTypes.ctor): Use Location.Null
14539 * typemanager.cs (TypeManager.Reset): Reset static data.
14540 (CoreLookupType): Removed Exit.
14541 (TypeHandle.Reset): Reset static data.
14543 2005-03-10 Raja R Harinath <rharinath@novell.com>
14546 * typemanager.cs (ComputeNamespaces): Import namespaces from
14547 referenced modules too.
14549 2005-03-09 Raja R Harinath <rharinath@novell.com>
14551 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14554 2005-03-09 Raja R Harinath <rharinath@novell.com>
14556 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14557 enclosing DeclSpace. This ensures that a name-lookup populates
14558 more caches and there are fewer 'TypeExpression's. Carve out
14559 nested type lookup into ...
14560 (LookupNestedTypeInHierarchy): ... this.
14562 2005-03-09 Raja R Harinath <rharinath@novell.com>
14564 Clean up a few partial-class semantics.
14565 Fixes test-357.cs and cs1618-2.cs.
14566 * cs-parser.jay (struct_declaration): Use 'current_class' as
14567 parent of newly-created struct. Remove call to Register ().
14568 Use 'pop_current_class' to complete handing the current struct.
14569 (interface_declaration): Likewise.
14570 (class_declaration): Likewise.
14571 (enum_declaration): Use 'current_class' as parent of newly created
14573 (delegate_declaration): Likewise.
14574 (pop_current_class): New function. This is used to handle closing
14575 up the 'current_class' and 'current_container', and pointing them
14576 to the enclosing class/container.
14577 (CSharpParser): Initialize 'current_class' too.
14578 * decl.cs (MemberCore): Add check for invariant: a partial
14579 container is not a parsed entity, and thus does not enclose any
14581 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14582 (DeclSpace.BaseTypeExpr): Use it.
14583 (DeclSpace.LookupType): Add check for invariant.
14584 * class.cs (TypeContainer): Add check for invariant: a nested
14585 class should have the same NamespaceEntry as its enclosing class.
14586 (TypeContainer.EmitFieldInitializers): Make virtual.
14587 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14589 (TypeContainer.Register): Remove.
14590 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14591 null. Use TypeResolveEmitContext for resolving base types and
14592 interfaces. Move initialization of Parts.TypeBuilder here from
14594 (TypeContainer.DefineNestedTypes): ... here.
14595 (PartialContainer): Take a Namespace not a NamespaceEntry.
14596 (PartialContainer.Create): Don't use Register. Call the
14597 appropriate Add... function directly.
14598 (ClassPart): Take both the PartialContainer and the enclosing
14599 class as constructor arguments.
14600 (ClassPart.EmitFieldInitializers): Override.
14601 (ClassPart.PartFindNestedTypes): Remove.
14602 (FieldBase.GetInitializerExpression): Resolve the initializer
14603 expression in the emit context of the enclosing class.
14604 * tree.cs (RootTypes): Remove Register ().
14606 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14608 * cs-parser.jay: Removed CS0134.
14610 * driver.cs: Removed CS1901.
14612 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14613 for predefined types.
14615 2005-03-07 Duncan Mak <duncan@novell.com>
14617 * codegen.cs (Save): Catch UnauthorizedAccessException as
14618 well. Fixes bug #73454.
14620 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14622 * cs-tokenizer.cs (xtoken): Add CS1035.
14624 * class.cs (MethodData.Define): Add CS0683.
14625 (FieldMember.ctor): Add CS0681.
14627 2005-03-07 Raja R Harinath <rharinath@novell.com>
14629 * ecore.cs (SimpleName.DoResolve): Rename from
14630 SimpleName.DoResolveAllowStatic.
14631 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14632 Pass 'intermediate' flag to MemberStaticCheck.
14633 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14634 of "intermediate" lookups via MemberAccess.
14635 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14636 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14638 2005-03-07 Raja R Harinath <rharinath@novell.com>
14641 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14642 slipped in because of variable names that are identical to a
14643 builtin type's BCL equivalent ('string String;', 'int Int32;').
14644 (PropertyExpr.EmitInstance): Likewise.
14646 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14648 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14650 * report.cs (warning_ignore_table): Made public.
14652 2005-03-04 Raja R Harinath <rharinath@novell.com>
14655 * class.cs (MethodData.Emit): Pass 'container' to
14656 container.GetObsoleteAttribute instead of 'container.Parent'.
14658 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14660 * cs-parser.jay: Add 1534 error test.
14662 * iterators.cs (Yield.CheckContext): Add error 1629.
14663 (Iterator.ctor): Save unsafe modifier.
14664 (MoveNextMethod.DoEmit): Restore unsafe context.
14666 * namespace.cs (UsingAlias): Better error message.
14668 2005-03-03 Dan Winship <danw@novell.com>
14670 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14671 the warning message [#73219]
14673 2005-03-03 Raja R Harinath <rharinath@novell.com>
14675 Fix compile with MCS 1.0.0.0.
14676 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14677 w_restore to not depend on string constant folding.
14679 2005-03-03 Raja R Harinath <rharinath@novell.com>
14681 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14682 CS0246 check to users who passed 'silent = false'.
14683 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14685 (SimpleName.SimpleNameResolve): Update.
14686 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14687 (MemberAccess.IdenticalNameAndTypeName): Update.
14688 * doc.cs (FindDocumentedTypeNonArray): Update.
14690 2005-03-03 Raja R Harinath <rharinath@novell.com>
14692 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14693 * parameters.cs (ComputeAndDefineParameters): Remove.
14694 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14695 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14696 Use GetParameterInfo.
14698 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14700 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14702 2005-03-02 Raja R Harinath <rharinath@novell.com>
14704 Unify DeclSpace.LookupType and DeclSpace.FindType.
14705 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14706 is in charge of defining nested types on demand.
14707 (DeclSpace.LookupType): Use it when the current_type is a
14708 TypeBuilder. Use LookupTypeDirect for reflected types.
14709 (DeclSpace.FindType): Remove.
14710 (DeclSpace.LookupInterfaceOrClass): Likewise.
14711 (DeclSpace.DefineTypeAndParents): Likewise.
14712 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14713 DeclSpace.LookupType.
14714 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14715 * typemanager.cs (LookupType): Simplify.
14716 (AddUserType): Remove type from negative_hits.
14717 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14718 * class.cs (TypeContainer.FindMembers): Move handling of nested
14720 (TypeContainer.FindMembers_NestedTypes): ... here.
14721 (TypeContainer.FindNestedType): Implement override.
14722 (ClassPart.FindNestedType): Delegate to PartialContainer.
14723 (ClassPart.PartFindNestedType): Looks up the nested types of the
14726 2005-03-02 Martin Baulig <martin@ximian.com>
14728 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14729 static constructor in static classes.
14731 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14733 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14734 sizeParamIndex is not specified.
14736 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14739 * report.cs (WarningMessage.IsEnabled): Missing null check.
14741 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14743 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14744 in the fields and not in the properties.
14746 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14748 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14751 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14753 * attribute.cs: Small refactoring (improved robustness).
14754 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14755 (ValidateGuid): Removed.
14756 (Resolve): Removed referenced to above mentioned.
14757 (GetAttributeUsage): Made private and changed to work without
14759 (GetIndexerAttributeValue): Don't crash.
14760 (GetConditionalAttributeValue): Ditto.
14761 (GetClsCompliantAttributeValue): Ditto.
14762 (ExtractSecurityPermissionSet): All attributes exceptions are
14764 (GetPropertyValue): New helper.
14765 (GetMethodImplOptions): New method.
14766 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14767 some missing properties.
14769 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14770 (Method.ApplyAttributeBuilder): Updated.
14772 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14775 2005-02-28 Raja R Harinath <rharinath@novell.com>
14778 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14779 non-simple types (array, pointer, reference).
14781 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14783 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14785 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14787 (Method.CheckBase): Catch wrong destructor here.
14788 (MethodData.Define): Add errors 550, 668.
14790 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14792 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14794 * pending.cs (VerifyPendingMethods): Add error 551.
14796 * typemanager.cs (CSharpName): Next error report helper.
14798 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14800 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14801 attributes. Removed useless attribute double check.
14802 It saves almost 2MBs for corlib.
14804 2005-02-25 Raja R Harinath <rharinath@novell.com>
14807 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14808 called twice in case of error.
14810 2005-02-23 Chris Toshok <toshok@ximian.com>
14812 Fix compiler portions of #72827.
14813 * statement.cs (Block.Emit): call Begin/EndScope on the
14814 EmitContext instead of the ILGenerator.
14816 * codegen.cs (EmitContext.BeginScope): new method, call
14817 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14819 (EmitContext.BeginScope): same, but EndScope and CloseScope
14821 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14822 offset and call the superclass's OpenScope(int) with it.
14823 (SymbolWriter.CloseScope): get the current il
14824 offset and call superclass's CloseScope(int) with it.
14826 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14828 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14829 CS1677 for out and ref as well.
14831 * class.cs (Method.Define): Add error CS1599 detection.
14833 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14835 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14837 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14839 * support.cs.cs (ModifierDesc): New helper method.
14841 2005-02-23 Raja R Harinath <rharinath@novell.com>
14842 Abin Thomas <projectmonokochi@rediffmail.com>
14843 Anoob V E <projectmonokochi@rediffmail.com>
14844 Harilal P R <projectmonokochi@rediffmail.com>
14846 Fix #57851, #72718.
14847 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14848 MemberLookup (used for error reporting) actually returns a result.
14849 Fix error report number (122, not 112).
14851 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14852 Anoob V E <projectmonokochi@rediffmail.com>
14853 Harilal P R <projectmonokochi@rediffmail.com>
14856 * pending.cs (PendingImplementation.GetAbstractMethods):
14857 Find NonPublic members too.
14859 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14861 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14864 * class.cs (MethodCore.CheckMethodAgainstBase):
14865 Add error 239 report.
14867 2005-02-21 Raja R Harinath <rharinath@novell.com>
14870 * expression.cs (Invocation.IsApplicable): Make public.
14871 (Invocation.IsParamsMethodApplicable): Likewise.
14872 * delegate.cs (Delegate.VerifyApplicability): Don't use
14873 Invocation.VerifyArgumentCompat for parameter applicability
14874 testing. Use Invocation.IsApplicable and
14875 Invocation.IsParamsMethodApplicable.
14877 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14879 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14881 * class.cs (Operator.Define): Add error 217 report.
14883 2005-02-21 Raja R Harinath <rharinath@novell.com>
14885 * namespace.cs (UsingEntry.Resolve): Undo change below.
14887 2005-02-21 Raja R Harinath <rharinath@novell.com>
14890 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14891 disable the error message when the extended MemberLookup also
14893 (Expression.MemberLookupFinal): Update.
14894 (SimpleName.DoSimpleNameResolve): Update.
14895 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14896 Don't use MemberLookupFinal.
14897 (New.DoResolve): Update.
14898 (BaseAccess.CommonResolve): Update.
14900 2005-02-21 Raja R Harinath <rharinath@novell.com>
14903 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14904 occured previously, don't resolve again.
14906 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14909 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14910 argument. Call ResolveAttributeUsage for unresolved.
14911 when types doesn't match ctor arguments.
14913 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14914 for nested attribute classes.
14915 (Class.attribute_usage): Removed.
14916 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14917 for attribute class.
14919 * ecore.cs (IsAttribute): Removed.
14921 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14923 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14925 (attribute_types): Removed.
14926 (EmitCode): Global attributes are emited as the latest.
14928 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14930 * class.cs (EmitFieldInitializers): Don't emit field initializer
14931 for default values when optimilization is on.
14933 * constant.cs (Constant.IsDefaultValue): New property.
14935 * driver.cs: Add /optimize handling.
14939 * literal.cs: Implement new IsDefaultValue property.
14941 * rootcontext.cs (Optimize): New field, holds /optimize option.
14943 2005-02-18 Raja R Harinath <rharinath@novell.com>
14945 Fix crasher in re-opened #72347.
14946 * namespace.cs (Namespace.Lookup): Return null if
14947 DeclSpace.DefineType returns null.
14950 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14952 2005-02-18 Raja R Harinath <rharinath@novell.com>
14954 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14955 now returns null if it cannot resolve to an lvalue.
14956 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14957 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14958 returned null. Remove check for SimpleName.
14959 (EventExpr.DoResolveLValue): New.
14960 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14961 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14963 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14964 avoid CS0131 error.
14965 (Unary.ResolveOperator): Move CS0211 check ...
14966 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14968 (Unary.DoResolveLValue): Simplify.
14969 (AddressOf.DoResolveLValue): New.
14970 (ArrayAccess.DoResolveLValue): New.
14972 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14974 * attribute.cs (Attribute.Resolve): Add arguments casting for
14975 when types doesn't match ctor arguments.
14977 2005-02-16 Raja R Harinath <rharinath@novell.com>
14979 Fix parts of #63202.
14980 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14981 lookup of operator in base type. Ensure that all checks happen
14982 when the operator resolves to an "op_..." method.
14984 2005-02-15 Raja R Harinath <rharinath@novell.com>
14987 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14988 'ignore_cs0104' parameter. Pass it to ...
14989 (NamespaceEntry.Lookup): ... this.
14990 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14991 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14992 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14993 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14994 Update. Request that cs0104 errors be ignored.
14995 (ComposedCast.ResolveAsTypeStep): Update.
14997 2005-02-14 Raja R Harinath <rharinath@novell.com>
15000 * expression.cs (Invocation.BetterFunction): Remove support for
15001 comparing virtual functions and their overrides.
15002 (Invocation.IsOverride): New.
15003 (Invocation.OverloadResolve): Don't consider 'override' functions
15004 during candidate selection. Store them in a lookaside list.
15005 If the selected method is a 'virtual' function, use the list to
15006 find any overrides that are closer to the LHS type.
15008 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15010 * expression.cs (New.DoResolve): Add complex core type reduction.
15011 (New.Constantify): Converts complex core type syntax like 'new int ()'
15012 to simple constant.
15014 2005-02-14 Raja R Harinath <rharinath@novell.com>
15016 * decl.cs (EntryType.EntryType): New constructor to create an
15017 updated copy of a cache entry.
15018 (MemberCache.AddMethods): Use it.
15019 (MemberCache.ClearDeclaredOnly): Remove.
15020 (MemberCache.MemberCache): Update.
15022 2005-02-11 Miguel de Icaza <miguel@novell.com>
15024 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15025 variable. This one is represents the actual low-level declaration
15026 of the method, as opposed to the semantic level `IsStatic'.
15028 An anonymous method which is hosted into a static method might be
15029 actually an instance method. IsStatic would reflect the
15030 container, while MethodIsStatic represents the actual code
15033 * expression.cs (ParameterReference): Use the new MethodIsStatic
15034 instead of IsStatic.
15036 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15037 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15038 set on the current EmitContext.
15040 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15041 resolve our casted expression as an LValue. This triggers the
15042 proper LValue processing that is later required by Assign.
15046 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15048 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15050 C# 2.0 Fixed buffer implementation
15052 * anonymous.cs: Update after RegisterHelperClass renaming.
15054 * attribute.cs (AttributeTester.fixed_buffer_cache):
15055 Cache of external fixed buffers.
15056 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15057 implementation if field is fixed buffer else null.
15060 (TypeContainer.AddField): Accept FieldMember instead of Field.
15061 (FieldBase.IsFieldClsCompliant): Extracted code from
15062 VerifyClsCompliance descendant customization.
15063 (FixedField): New class handles fixed buffer fields.
15064 (FixedFieldExternal): Keeps information about imported fixed
15066 (IFixedField): Make access to internal or external fixed buffer
15069 * cs-parser.jay: Add fixed buffer parsing.
15071 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15074 * expression.cs (Indirection): Extended implementation to accept
15075 fixed buffer field.
15076 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15077 (ElementAccess.MakePointerAccess): Get type as parameter.
15078 (DoResolve): Add fixed buffer field expression conversion.
15079 (DoResolveLValue): Ditto.
15080 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15081 (ArrayPtr): Derives from FixedBufferPtr.
15082 (ArrayPtr.Emit): Add extra emit for array elements.
15084 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15086 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15087 for compiler generated types.
15088 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15090 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15091 and consume less memory.
15092 (Fixed.Resolve): Add fixed buffer case.
15094 * typemanager.cs (compiler_generated_attr_ctor,
15095 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15096 (HasElementType): Add our own implementation to work on every
15099 2005-02-11 Miguel de Icaza <miguel@novell.com>
15101 * anonymous.cs (CaptureContext): Track whether `this' has been
15104 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15105 only captured `this' if it was implicitly done (instance
15106 methods/variables were used).
15108 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15109 `this' must be captured.
15111 2005-01-30 Miguel de Icaza <miguel@novell.com>
15113 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15114 is null it means that there has been no need to capture anything,
15115 so we just create a sibling.
15117 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15119 Just a partial fix. The other half is fairly elusive.
15121 2005-02-10 Raja R Harinath <rharinath@novell.com>
15123 Fix #52586, cs0121-4.cs.
15124 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15125 and return a hashtable.
15126 (MemberCache.ClearDeclaredOnly): New.
15127 (MemberCache.MemberCache): Update to change. Make a deep copy of
15128 the method_hash of a base type too.
15129 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15130 type methods. Overwrite entries with the same MethodHandle so
15131 that the ReflectedType is correct. The process leaves in base
15132 virtual functions and their overrides as distinct entries.
15133 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15134 matters since it was boxed in a ArrayList before.
15135 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15137 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15138 case of a virtual function and its override (choose the overload
15140 (Invocation.OverloadResolve): Avoid 'override' members during
15141 'applicable_type' calculation.
15143 2005-02-09 Raja R Harinath <rharinath@novell.com>
15145 Combine two near-redundant caches.
15146 * typemanager.cs (method_params): Rename from method_internal_params.
15147 (TypeManager.GetParameterData): New. Replace
15148 Invocation.GetParameterData.
15149 (TypeManager.LookupParametersByBuilder): Remove.
15150 * expression.cs (Invocation.method_parameter_cache): Remove.
15151 (Invocation.GetParameterData): Remove.
15153 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15156 2005-02-08 Raja R Harinath <rharinath@novell.com>
15159 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15160 TypeManager.multicast_delegate_type is null, resolve it by looking
15161 up "System.MulticastDelegate".
15162 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15164 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15165 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15166 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15169 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15170 (LabeledStatement.AddReference): New. Set 'referenced'.
15171 (Goto.Resolve): Use it.
15173 2005-02-05 John Luke <john.luke@gmail.com>
15175 * driver.cs: remove duplicate -doc line in Usage ()
15177 2005-02-04 Raja R Harinath <rharinath@novell.com>
15179 * location.cs (Location.AddFile): Fix CS2002 error report.
15181 2005-02-02 Martin Baulig <martin@ximian.com>
15183 * delegate.cs (Delegate.DefineType): Report an internal error if
15184 TypeManager.multicast_delegate_type is null. See bug #72015 for
15187 2005-02-02 Raja R Harinath <rharinath@novell.com>
15189 Fix a crasher in a variant of #31984.
15190 * const.cs (Constant.CheckBase): New override that defers the
15191 new-or-override check in case the base type hasn't been populated
15193 (Constant.Define): Ensure the new-or-override check is performed.
15195 2005-02-01 Duncan Mak <duncan@ximian.com>
15197 * const.cs (LookupConstantValue): Check that `ce' is not null
15198 before calling GetValue ().
15200 2005-02-01 Raja R Harinath <rharinath@novell.com>
15202 Fix test-334.cs (#69519).
15203 * cs-parser.jay (using_alias_directive): Pass in an expression to
15204 NamespaceEntry.UsingAlias.
15205 (using_namespace_directive): Pass in an expression to
15206 NamespaceEntry.Using.
15207 (namespace_name): Don't flatten to a string.
15208 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15209 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15211 (NamespaceEntry.UsingEntry): Likewise.
15212 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15214 (NamespaceEntry.LookupForUsing): Remove.
15215 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15217 (NamespaceEntry.Lookup): Remove support for dotted names.
15219 2005-02-01 Raja R Harinath <rharinath@novell.com>
15221 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15223 (NamespaceEntry.ImplicitParent): Compute on demand.
15224 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15225 parallels the current.
15226 (NamespaceEntry.LookupForUsing): Use it.
15227 (NamespaceEntry.Lookup): If the current namespace-entry is
15228 implicit, don't search aliases and using tables.
15230 2005-02-01 Raja R Harinath <rharinath@novell.com>
15233 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15235 (TypeContainer.BaseCache): Compute on demand.
15236 (TypeContainer.FindMembers): Define constants and types if they're
15237 not already created.
15238 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15240 * const.cs (Constant.Define): Make idempotent.
15242 2005-01-29 Miguel de Icaza <miguel@novell.com>
15244 * pending.cs: Produce better code (no nops produced by using Ldarg
15247 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15248 i - 1' it should be arg + 1.
15252 2005-01-28 Raja R Harinath <rharinath@novell.com>
15254 * attribute.cs (Attribute.CheckAttributeType): Make private
15256 (Attribute.ResolveType): Make virtual.
15257 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15258 handling of RootContext.Tree.Types.
15260 2005-01-27 Raja R Harinath <rharinath@novell.com>
15262 Update attribute-handling to use the SimpleName/MemberAccess
15264 * cs-parser.jay (attribute): Pass in an expression to the
15265 constructors of Attribute and GlobalAttribute.
15266 * attribute.cs (Attribute): Take an expression for the name.
15267 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15268 passed in attribute name expression.
15269 (Attribute.CheckAttributeType): Use it.
15270 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15271 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15272 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15273 argument to prevent error messages if the lookup fails.
15275 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15277 * expression.cs (Indirection): Implemented IVariable interface
15278 to support indirection in AddressOf operator.
15279 (PointerArithmetic.Emit): Add optimalization for case where
15280 result can be precomputed.
15282 2005-01-26 Martin Baulig <martin@ximian.com>
15284 * class.cs (TypeContainer.AttributeTargets): Return the correct
15285 AttributeTargets depending on our `Kind' instead of throwing an
15286 exception; fixes #71632.
15288 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15291 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15294 2005-01-25 Raja R Harinath <rharinath@novell.com>
15297 * expression.cs (MemberAccess.DoResolve): Don't complain with
15298 cs0572 when the LHS of a member access has identical name and type
15301 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15304 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15306 Create custom PermissionSet only for PermissionSetAttribute.
15308 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15311 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15312 delegates in static class.
15314 2005-01-24 Martin Baulig <martin@ximian.com>
15316 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15317 merging an implicit block, just use its reachability.
15319 * statement.cs (Block.Resolve): Make the unreachable code check
15320 work wrt. implicit blocks; see test-337 from #63842.
15322 2005-01-21 Alp Toker <alp@atoker.com>
15324 * cs-parser.jay: destructor_declaration's container is PartialContainer
15325 not Class when partial types are used, so use Kind prop instead of
15328 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15330 * cs-parser.jay: Improve error reporting when an interface
15331 declares new types.
15333 2005-01-20 Dick Porter <dick@ximian.com>
15335 * support.cs: SeekableStreamReader fix from Sandor Dobos
15336 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15337 chars are read. Fixes bug 70369.
15339 2005-01-20 Raja R Harinath <rharinath@novell.com>
15341 * cs-parser.jay (catch_clause): Simplify current_block handling
15344 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15346 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15347 code with ImplicitStandardConversion to handle the implicit
15348 conversion of method groups into valid delegate invocations.
15350 The problem is that in parameter handling we were using this code
15351 path. Fixes bug #64698
15353 2005-01-19 Raja R Harinath <rharinath@novell.com>
15355 * cs-parser.jay: Fix several infelicities.
15356 - Avoid assigning to the parser value stack. Code like
15357 '$3 = null' is unclean. Synthesize a value for the code block
15359 - Avoid using oob_stack for storing location information. Use ...
15360 (_mark_): ... this. New (empty) rule. Saves the current location
15362 (foreach_statement): Avoid using oob_stack for current_block
15363 handling. Use technique used in for_statement and
15364 using_statement. Synthesize a value for the code block to store
15365 additional intermediate information.
15367 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15369 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15370 of a different type is only allowed to private fields of a
15371 containing type, not on fields of a base class.
15373 See test-174.cs and error cs0122-9.cs
15375 2005-01-13 Raja R Harinath <rharinath@novell.com>
15377 Fix test-335.cs (bug #58126).
15378 * cs-parser.jay (argument): Split out non-expression parts of the
15379 rule into 'non_simple_argument'.
15380 (invocation_expression): Support parenthesized invocations with
15381 multiple arguments, and with single non-simple arguments.
15383 2005-01-13 Raja R Harinath <rharinath@novell.com>
15385 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15388 2005-01-12 Raja R Harinath <rharinath@novell.com>
15390 Fix cs0038-1.cs, cs1640-6.cs.
15391 * ecore.cs (Expression.Resolve): Remove special-case for
15392 SimpleName in error-handling.
15393 (Expression.almostMatchedMembers): Relax access permission to
15395 (Expression.MemberLookupFailed): Handle duplicates in
15396 almostMatchedMembers list.
15397 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15398 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15399 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15400 overload if the passed in MemberInfo is a MethodBase.
15402 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15405 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15406 for non-CAS & merge permission sets properly.
15408 2005-01-11 Raja R Harinath <rharinath@novell.com>
15410 Improve standard-compliance of simple name and member access
15411 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15412 * ecore.cs (FullNamedExpression): New abstract base class
15413 for Namespaces and TypeExpressions.
15414 (ResolveFlags.SimpleName): Remove.
15415 (SimpleName): Remove support for dotted names.
15416 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15417 DeclSpace.FindType and DeclSpace.LookupType.
15418 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15419 (Expression.ExprClassName): Make member function.
15420 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15421 a namespace. Remove creation of dotted "SimpleName"s.
15422 (MemberAccess.DoResolve): Likewise.
15423 * decl.cs (DeclSpace.Cache): Make private.
15424 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15425 (DeclSpace.FindType): Update.
15426 (DeclSpace.LookupType): Move here from RootContext. Return a
15427 FullNamedExpression.
15428 * namespace.cs (Namespace): Derive from FullNamedExpression
15429 so that it can be part of expression resolution.
15430 (Namespace.Lookup): Return an FullNamedExpression.
15431 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15433 * rootcontext.cs (NamespaceLookup): Remove.
15434 (LookupType): Move to DeclSpace.
15435 * attribute.cs (CheckAttributeType): Update.
15436 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15437 (FindDocumentedTypeNonArray): Likewise.
15439 2005-01-11 Raja R Harinath <rharinath@novell.com>
15441 Fix cs0509.cs, cs1632.cs.
15442 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15443 is the same as IsInterface.
15444 (TypeContainer.GetClassBases): Likewise.
15445 * statement.cs (LabeledStatement.ig): New field.
15446 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15448 (LabeledStatement.DoEmit): Check that the label was created with
15449 the same ILGenerator.
15451 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15454 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15455 accessors to its properties.
15457 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15458 from accessors to property.
15460 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15463 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15464 only for overrides.
15466 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15468 * attribute.cs: Check for null and empty strings.
15470 I have lost another battle to Paolo.
15472 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15475 * class.cs (PropertyMethod): Set Parent field in ctors.
15476 (SetMethod.InternalParameters): Add unsafe switch hack.
15477 Override MarkForDuplicationCheck where it is appropriate.
15479 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15480 It says whether container allows members with the same name.
15481 Base default is no.
15482 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15483 Removed is_method parameter.
15485 2005-01-06 Duncan Mak <duncan@ximian.com>
15487 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15488 because the previous change led to incorrect reporting of CS1032
15489 ("Cannot define/undefine preprocessor symbols after first token in
15490 file"). Instead of using `tokens_seen' as the only flag that
15491 triggers CS1040, introduce `comments_seen'. This new flag is used
15492 to signify having seen comments on the current line, so it is
15493 unset after a newline.
15495 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15497 * doc.cs : When searching for a type, find nested type too.
15498 This fixes bug #71040.
15500 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15503 - Warn missing member comment on those classes which also does not
15504 have doc comments. Fixed bug #71041.
15505 - Don't warn missing doc comment on default constructor.
15508 2005-01-06 Duncan Mak <duncan@ximian.com>
15510 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15511 comments, set `tokens_seen' to true. This allows us to detect
15512 misplaced preprocessor directives (i.e. not at the beginning of
15513 the a line, nor after whitespaces). In that case, report error
15514 CS1040. This fixes bug #56460.
15516 * cs-parser.jay (interface_member_declaration): Add checks for
15517 IsExplicitImpl, and report CS0541 error if an interface member is
15518 defined as an explicit interface declaration.
15520 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15523 * class.cs (PropertyMethod): Set Parent field in ctors.
15524 (SetMethod.InternalParameters): Add unsafe switch hack.
15526 * decl.cs (MemberCore.Parent): Cannot be readonly.
15528 2005-01-06 Raja R Harinath <rharinath@novell.com>
15530 * decl.cs (DeclSpace.ResolveType): Remove.
15531 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15532 Merge in code from ...
15533 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15534 * class.cs, enum.cs: Update to changes.
15536 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15538 * anonymous.cs: Ensure that we init the scope of our parent if it
15539 has not been initialized yet.
15541 2004-12-30 Duncan Mak <duncan@ximian.com>
15543 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15544 if field.FieldBuilder is null. Fixes #70758.
15546 * convert.cs: Fixed some typos and updated some of the comments.
15547 (ImplicitStandardConversionExists):
15548 (TryImplicitIntConversion): If `target_type' is an interface and
15549 the type of `ic' implements this interface, return true or a new
15550 BoxedCast instead of null. This fixes #70468.
15552 2004-12-29 Duncan Mak <duncan@ximian.com>
15554 * expression.cs (Argument.Emit): Check that Expr is
15555 IMemoryLocation before casting to it, and report CS1510 otherwise.
15559 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15561 * statement.cs (Block.ThisVariable): remove the recursion here, to
15562 make the --profile more sane.
15564 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15566 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15567 assembly, by JB Evain.
15569 2004-12-17 Raja R Harinath <rharinath@novell.com>
15571 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15572 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15573 "parent" refers to enclosing type/class. "base" refers to superclass.
15575 2004-12-17 Raja R Harinath <rharinath@novell.com>
15577 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15578 Ensure that we only have GlobalAttributes.
15579 * attribute.cs (Attribute.Emit): Make non-virtual.
15580 (GlobalAttribute.Emit): Remove.
15581 (Attribute.Resolve): Make virtual.
15582 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15583 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15584 the argument. Don't create one.
15585 (Attribute.GetObsoleteAttribute): Likewise.
15586 (Attribute.GetClsCompliantAttributeValue): Likewise.
15587 * class.cs, decl.cs: Update to changes.
15589 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15591 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15593 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15595 * statement.cs (Foreach.Resolve): Add error 186 report.
15597 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15599 * expression.cs (Conditional.DoResolve): Add warning 429.
15601 * statement.cs (If.Resolve): Add warning 665.
15603 2004-12-16 Raja R Harinath <rharinath@novell.com>
15605 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15606 except when in the parser, and in GlobalAttribute.
15607 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15608 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15609 RootContext.Tree.Types.NamespaceEntry once work is done.
15610 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15611 and resets RootContext.Tree.Types.NamespaceEntry.
15613 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15615 * cs-parser.jay: Don't create a block for every variable.
15617 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15619 * location.cs: Provide extra information.
15621 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15622 variables from the captured environment, it is the ldarg_0.
15624 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15626 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15629 * class.cs: Changed warning level for 169 to avoid developer
15630 displeasure from warning flooding. It will be changed back when they
15631 fix most of current BCL warnings.
15633 * RootContext.cs: Pushed default WarningLevel to 3.
15635 * statement.cs: Removed unused variable.
15637 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15639 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15640 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15641 Add error 502 report.
15642 (StaticClass.DefineType): Add error 441 report.
15643 (Class.AllowedModifiersProp): New virtual property as temporary
15644 extension to AllowedModifiers.
15645 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15646 to share implementation with StaticClass and don't call virtual
15649 * driver.cs (MainDriver): Add error 1558 test.
15651 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15652 report. Moved error 36 test here.
15654 * statement.cs (Throw.Resolve): Add error 724 report.
15656 * typemanager.cs: Add out_attribute_type core type.
15658 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15660 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15662 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15664 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15667 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15669 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15670 Add error 3023 report.
15671 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15673 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15676 2004-12-12 John Luke <john.luke@gmail.com>
15678 * driver.cs (AddArgs): take -- into account when
15679 adding arguments, fixes bug 65710
15681 2004-12-12 Martin Baulig <martin@ximian.com>
15683 * expression.cs (Unary.TryReduceNegative): Added support for
15684 SByteConstant and ByteConstant.
15685 (Unary.Reduce): Check error values from TryReduceNegative().
15687 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15689 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15690 and report exception as error 182.
15692 2004-12-10 Raja R Harinath <rharinath@novell.com>
15694 * driver.cs (Main): Fix message when there are warnings.
15696 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15698 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15700 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15702 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15703 Reduced number of warnings.
15705 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15707 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15709 * driver.cs: Removed message.
15711 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15713 2004-12-08 <vargaz@freemail.hu>
15715 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15717 2004-12-08 Martin Baulig <martin@ximian.com>
15719 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15720 instead of a CS3002 for properties and indexer.
15722 2004-12-08 Martin Baulig <martin@ximian.com>
15724 * decl.cs (MemberName.ToString): Make this work again.
15726 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15728 * attribute.cs (Resolve): Add error 591 detection.
15730 * class.cs (FieldMember.Define): Add error 1547 detection.
15731 (Indexer.Define): Add error 620 detection.
15732 (Operator.Define): Add error 590 detection.
15734 * ecore.cs: Missing argument for error 79.
15736 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15739 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15742 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15745 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15747 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15748 Some operator comments were suppressed.
15749 * doc.cs : Implicit/explicit operator name in doc comments are like
15750 "op_Explicit(type)~returnType", so added suffix handling.
15752 2004-12-07 Martin Baulig <martin@ximian.com>
15755 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15756 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15757 (DeclSpace.ec): New protected field; store the EmitContext here.
15758 (DeclSpace.EmitContext): New public property; moved here from
15760 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15763 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15764 (Enum.Emit): Don't create a new EmitContext.
15766 * delegate.cs (Delegate.DefineType): Always create the
15769 * iterators.cs (Iterators.DefineIterator): Create a new
15770 EmitContext and store it in `ec'.
15772 2004-08-24 Martin Baulig <martin@ximian.com>
15775 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15776 this for accessibility checks.
15777 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15778 IsNestedFamilyAccessible.
15779 (TypeManager.IsSubclassOf): New method, do what the name actually
15782 2004-12-06 Raja R Harinath <rharinath@novell.com>
15784 Fix crash on cs0657-17.cs.
15785 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15786 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15787 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15788 the case where the NamespaceEntry gets overwritten.
15790 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15792 Fixed #69195, #56821
15793 * ecore.cs (ResolveBoolean): Tiny refactoring.
15795 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15796 of right expression resolving when left is false constant and
15797 operator is LogicalAnd OR true constant and operator is LogicalOr.
15799 * statement.cs (ResolveUnreachable): Always reports warning.
15801 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15803 * class.cs: Distinguish between 1721 and 1722 (just a little help
15804 for the programmer).
15806 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15808 * delegate.cs: Only allow this on new versions of the language.
15810 2004-12-02 Duncan Mak <duncan@ximian.com>
15812 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15814 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15815 here as a static method. Take an additional bool out parameter
15816 `must_do_cs1540_check' for signaling to InstanceResolve.
15817 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15818 member field from PropertyExpr class and made it an argument of
15819 the method instead.
15820 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15821 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15822 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15823 and `remove_accessor' as well as InstanceResolve: report CS0122
15828 2004-12-03 Raja R Harinath <rharinath@novell.com>
15830 Fix test-327.cs, test-328.cs, and put in early infrastructure
15831 for eventually fixing #52697.
15832 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15833 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15834 from other methods.
15835 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15836 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15837 (VerifyUsing, error246): Update.
15838 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15839 'NamespaceEntry.LookupNamespaceOrType'.
15841 2004-12-03 Martin Baulig <martin@ximian.com>
15843 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15844 method as our child, call AnonymousMethod.Compatible() on it.
15846 2004-12-03 Raja R Harinath <rharinath@novell.com>
15848 Disable XML documentation support in 'basic' profile.
15849 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15850 Redirect XmlElement to System.Object.
15851 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15852 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15853 * mcs.exe.sources: Add doc-bootstrap.cs.
15854 * doc-bootstrap.cs: New file. Contains empty stub implementation
15857 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15859 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15860 comments are allowed.
15862 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15864 * delegate.cs: Add checks for subtypes in paramaters and return values
15865 in VerifyMethod () to add support for Covariance/Contravariance
15868 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15870 * report.cs: Remove extra closing parenthesis.
15872 * convert.cs (Error_CannotImplicitConversion): If the name of the
15873 types are the same, provide some extra information.
15875 * class.cs (FieldBase): Use an unused bit field from the field to
15876 encode the `has_offset' property from the FieldMember. This saves
15877 a couple of Ks on bootstrap compilation.
15879 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15880 method as our child, return the AnonymousMethod resolved
15883 * expression.cs (New.DoResolve): Allow return values from
15884 NewDelegate to also include AnonymousMethods.
15888 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15891 * attribute.cs (Resolve): Improved implementation of params
15892 attribute arguments.
15894 * support.cs (ParameterData): Add HasParams to be faster.
15896 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15898 all things are for /doc support:
15900 * doc.cs: new file that supports XML documentation generation.
15901 * mcs.exe.sources: added doc.cs.
15903 Handle /doc command line option.
15904 Report error 2006 instead of 5 for missing file name for /doc.
15905 Generate XML documentation when required, after type resolution.
15907 Added support for picking up documentation (/// and /** ... */),
15908 including a new XmlCommentState enumeration.
15910 Added lines to fill Documentation element for field, constant,
15911 property, indexer, method, constructor, destructor, operator, event
15912 and class, struct, interface, delegate, enum.
15913 Added lines to warn incorrect comment.
15915 Added Documentation field (passed only when /doc was specified).
15917 Added DocComment, DocCommentHeader, GenerateDocComment() and
15918 OnGenerateDocComment() and some supporting private members for
15919 /doc feature to MemberCore.
15921 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15923 Added overriden DocCommentHeader.
15925 Added overriden DocCommentHeader and GenerateDocComment().
15927 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15929 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15930 unwrapping the enumeration values, chain to
15931 DoConstantNumericPromotions again, so we can promote things to the
15932 fundamental types (takes care of enums that are bytes, sbytes).
15936 2004-12-01 Raja R Harinath <rharinath@novell.com>
15938 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15939 Fix long-standing bug in type-lookup. Use FindType instead of
15940 LookupType when ec.ResolvingTypeTree.
15941 (Attribute.ResolveType, Attribute.Resolve)
15942 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15944 (Attributes.Search): Remove internal version. Update.
15945 (Attributes.SearchMulti): Update.
15946 (Attributes.GetClsCompliantAttribute): Remove.
15947 (Attributes.GetIndexerNameAttribute): Remove.
15948 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15949 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15950 * class.cs (Indexer.Define): Likewise.
15952 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15955 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15956 MarshallByReference members access.
15958 * expression.cs: Use CheckMarshallByRefAccess;
15959 Better error CS0197 message.
15961 * report.cs: Print whole related error message.
15963 2004-11-30 Raja R Harinath <rharinath@novell.com>
15965 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15966 the current directory to help debugging.
15968 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15970 * class (GetClassBases): Better error 60 report.
15971 (EventProperty): Disabled warning 67 detection.
15973 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15976 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15978 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15981 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15984 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15986 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15988 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15990 * attribute.cs (Attribute.Resolve): Refine error reporting and
15991 report a cs0117 if the identifier does not exist, to distinguish
15992 from 0617 which is a miss-use of the actual identifier.
15994 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15995 between cs0070 and cs0079.
15997 * class.cs (MemberBase.DoDefine): When reporting a wrong
15998 accessibility level, we use MethodCore to compare instead of
15999 Method (this was a regression in some refactoring effort).
16001 So now we correctly report cs0056 again.
16003 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16004 testing the target_type (which was known to be object_type) and
16005 not the source type (which is anonymous_method).
16007 Fixed reporting of error cs1660.
16009 * expression.cs (UserCast.Source): Expose the underlying cast.
16011 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16012 allowed types to find a match to int32 first (most common).
16014 In addition, it ignores any ImplicitUserConversions that did an
16015 internal implicit conversion (as the switch statement allows only
16016 one integral conversion to exist).
16018 * class.cs (PartialContainer.Create): rename `name' to
16019 `member_name' for clarity. Then replace the string calls with a
16020 call to MemberName.GetPartialName, as now using
16021 MemberName.ToString is an error (this is due to the side effects
16022 it had, that were fixed in the past).
16024 This will restore the error reporting on a number of partial class
16025 errors that were missusing this (and getting an exception as a
16026 results, which is now just a plain textual warning, because
16027 yyparse debug output would crash otherwise).
16029 2004-11-26 Raja R Harinath <rharinath@novell.com>
16031 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16033 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16035 * rootcontext.cs (LookupType): Make sure to cache lookups that
16036 don't give us a negative result. This saves about 5% of corlib
16039 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16041 * report.cs (AbstractMessage.Print): messages are sent to stderr
16043 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16044 non-interface in the list of interfaces (at this point, either
16045 parent was properly set, or a base class is being listed in the
16046 interfaces section).
16048 This flags error 1722, and resolves the crash from bug 69259.
16050 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16052 * statement.cs (Using.EmitExpressionFinally): make this work right
16053 for valuetypes. Fixes 69926.
16055 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16057 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16058 converted to an enum" here, before we try to change the underlying
16059 type. This code exists, but it is a different code path than the
16060 one used while encoding constants.
16062 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16063 old bug: when converting from the null literal to a pointer,
16064 return an EmptyCast, not the NullLiteral.
16066 This fixes #69921, the recent null_type changes probably made this
16067 bug more prominent.
16069 (ImplicitReferenceConversionExists): In addition, resynchronized
16070 the code here, so it matches the same code in
16071 ImplicitReferenceConversionExists for the `from any class-type S
16072 to any interface-type T'.
16075 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16077 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16079 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16081 * cs-parser.jay: Use verbosity accordingly.
16083 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16085 * expression.cs (Unary.ResolveOperator): Do not report warning;
16086 AddressOf reads from variable.
16088 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16090 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16094 * attribute.cs (Attributable): Removed CheckTargets.
16095 (Attributes.Emit): Explicit attribute targets are tested here.
16097 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16098 not enabled for interfaces.
16100 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16101 (GetAssemblyName): Ouch next bug there.
16103 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16105 * expression.cs: Error 275 added.
16107 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16109 Fix bug #69177 (Implemented decimal constant support)
16111 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16112 (BinaryFold): Add DecimalConstant.
16114 * const.cs (Define): Decimal constant
16116 (ChangeType): Add decimal type handling.
16117 (LookupConstantValue): Don't set value for decimal type but
16118 emit DecimalConstantAttribute. Needed for constant optimization.
16120 * constant.cs (ToDecimal): New method.
16121 (ConvertToDecimal): New method.
16122 (IntConstant): Implemented ConvertToDecimal.
16123 (DecimalConstant.Emit): Emit optimized version for decimals in
16126 * expression.cs (ResolveOperator): Changed order of constant
16127 reduction to work correctly with native types which have
16128 overloaded operators.
16129 (ResolveMemberAccess): Extract constant value from attribute
16132 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16134 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16135 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16136 (ChangeType): Decimal is special.
16137 (TypeToCoreType): Add decimal type.
16139 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16141 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16144 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16146 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16149 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16151 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16153 * pending.cs (PendingImplementation): Grab only interfaces.
16155 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16157 * statement.cs (ForeachHelperMethods): Add location member and
16158 error 202 detection.
16160 2004-11-19 Raja R Harinath <rharinath@novell.com>
16162 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16163 automatically handled by executable.make.
16164 (PROGRAM): Make profile-specific.
16166 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16168 * expression.cs (DoResolveBase): Fixed wrong warning for out
16171 2004-11-18 Martin Baulig <martin@ximian.com>
16173 Merged latest changes into gmcs. Please keep this comment in
16174 here, it makes it easier for me to see what changed in MCS since
16175 the last time I merged.
16177 2004-11-17 Raja R Harinath <rharinath@novell.com>
16179 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16180 (TypeHandle.GetMemberCache): New.
16181 (TypeHandle.TypeHandle): Update.
16182 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16183 (TypeManager.LookupParentInterfacesCache):
16184 Rename from LookupInterfaceCache. Optimize slightly.
16185 (TypeManager.MemberLookup_FindMembers): Update.
16186 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16187 multi-type variant.
16188 (AddCacheContents): Rename from AddHashtable.
16189 * class.cs (TypeContainer.parent_container): Remove.
16190 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16191 (TypeContainer.DoDefineMembers): Don't initialize it.
16192 Update to name changes.
16194 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16196 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16197 that factors the code to check access modifiers on override.
16199 (PropertyBase): Use the code here.
16201 Patch from Lluis S'anchez, fixes bug #69361.
16203 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16205 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16206 routine that is used to report the use of a captured variable
16207 whose address has been taken.
16209 There are two checks: one when variables are being captured and
16210 the other check is when the address of a variable is taken.
16212 (because an anonymous methods might be resolved before *or* after
16213 the address has been taken) and
16215 * expression.cs (Conditional.DoResolve): Remove the special
16216 casing that Martin added to trueExpr and falseExpr being both
16217 NullLiteral. We get the right behavior now just by introducing
16218 the null_type into the compiler.
16220 * convert.cs (ExplicitConversion): Change the code to use
16221 null_type instead of testing `expr is NullLiteral'.
16222 (ImplicitConversionStandard): use null_type too.
16223 (ImplicitReferenceConversionExists): use null_type too.
16224 (ImplicitReferenceConversion): use null_type too.
16226 * literal.cs: The type of `NullLiteral' is now null_type instead
16228 (Resolve): Set the type here.
16230 * typemanager.cs: Introduce null_type.
16232 2004-11-17 Martin Baulig <martin@ximian.com>
16234 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16235 direction, like FindMembers() does. Fixes #69546, testcase is in
16238 2004-11-16 Martin Baulig <martin@ximian.com>
16240 This is based on a patch from Marek Safar, see bug #69082.
16241 Fixes bugs #63705 and #67130.
16243 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16244 method; create a MemberCache for an interface type and cache the
16247 * decl.cs (IMemberContainer.ParentContainer): Removed.
16248 (IMemberContainer.ParentCache): New property.
16249 (MemberCache.SetupCacheForInterface): Removed.
16250 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16251 to create a cache for an interface's "parent".
16253 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16256 2004-11-16 Martin Baulig <martin@ximian.com>
16258 Merged back from gmcs; these changes already went into gmcs a
16259 couple of weeks ago.
16262 (TypeManager.AddUserType): Removed the `ifaces' argument.
16263 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16265 (TypeManager.AddUserInterface): Removed.
16266 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16268 (TypeManager.GetInterfaces): Likewise.
16269 (TypeManager.GetExplicitInterfaces): Likewise.
16271 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16273 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16274 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16276 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16278 * statement.cs: Avoid adding bools to a hashtable.
16280 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16282 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16283 calling an unsafe method from a safe location.
16285 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16288 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16290 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16292 * namespace.cs (VerifyUsing): use GetPartialName instead of
16295 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16297 * statement.cs (Return.Resolve): Fix regression in typo: if
16298 `in_exc', we have to request a NeedReturnLabel, this was a typo
16299 introduced in the anonymous method check-in. Fixes #69131.
16301 * Indexers were using the ShortName when defining themselves,
16302 causing a regression in the compiler bootstrap when applying the
16303 patch from 2004-11-02 (first part), now they use their full name
16304 and the bug is gone.
16306 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16308 * driver.cs: Strip the path from the names of embedded resources. Fixes
16311 2004-11-04 Raja R Harinath <rharinath@novell.com>
16313 Fix error message regression: cs0104-2.cs.
16314 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16315 (AliasEntry.Resolve): Update.
16316 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16318 (RootContext.LookupType): Update.
16320 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16322 * cs-parser.jay: Add support for handling accessor modifiers
16323 * class: Add support port accessor modifiers and error checking,
16324 define PropertyMethod.Define as virtual (not abstract anymore)
16325 * ecore.cs: Add checking for proeprties access with access modifiers
16326 * iterators.cs: Modify Accessor constructor call based in the modified
16328 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16330 * expression.cs (StringConcat): Handle being called twice,
16331 as when we have a concat in a field init with more than two
16334 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16336 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16337 special case explicit implementations, we should always produce
16338 the .property or .event declaration.
16340 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16341 since it will not return correct data if people use this
16342 unresolved in the presence of using statements (see test-313).
16344 * class.cs (MethodData.Define): If we are an explicit interface
16345 implementation, set the method name to the full name of the
16346 interface plus the name of the method.
16348 Notice that using the method.MethodName.GetFullName() does not
16349 work, as it will only contain the name as declared on the source
16350 file (it can be a shorthand in the presence of using statements)
16351 and not the fully qualifed type name, for example:
16355 class D : ICloneable {
16356 object ICloneable.Clone () {
16360 Would produce a method called `ICloneable.Clone' instead of
16361 `System.ICloneable.Clone'.
16363 * namespace.cs (Alias.Resolve): Use GetPartialName.
16365 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16367 * cs-parser.jay: Add error 1055 report.
16369 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16371 * assign.cs (Assign.DoResolve): Only do the transform of
16372 assignment into a New if the types are compatible, if not, fall
16373 through and let the implicit code deal with the errors and with
16374 the necessary conversions.
16376 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16378 * cs-parser.jay: Add error 1031 report.
16380 * cs-tokenizer.cs: Add location for error 1038.
16382 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16384 * cs-parser.jay: Add error 1016 report.
16386 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16388 * cs-parser.jay: Add errors 1575,1611 report.
16390 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16392 * cs-parser.jay: Add error 1001 report.
16394 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16397 * attribute.cs (GetMarshal): Add method argument for
16398 caller identification.
16400 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16401 agument for GetMarshal and RuntimeMissingSupport.
16403 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16405 * attribute.cs (ExtractSecurityPermissionSet): Removed
16406 TypeManager.code_access_permission_type.
16408 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16410 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16412 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16413 for obsolete use of a variable here. Fixes regression on errors
16414 cs0619-25 and cs0619-26.
16416 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16418 Fix #62358, implemented security attribute encoding.
16420 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16421 Tests permitted SecurityAction for assembly or other types.
16422 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16423 data from SecurityPermissionAttribute to PermisionSet class.
16425 * class.cs (ApplyAttributeBuilder): Added special handling
16426 for System.Security.Permissions.SecurityAttribute based types.
16428 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16429 special handling for System.Security.Permissions.SecurityAttribute
16432 * enum.cs (ApplyAttributeBuilder): Added special handling
16433 for System.Security.Permissions.SecurityAttribute based types.
16435 * parameter.cs (ApplyAttributeBuilder): Added special handling
16436 for System.Security.Permissions.SecurityAttribute based types.
16438 * rootcontext.cs: Next 2 core types.
16440 * typemanager.cs (TypeManager.security_permission_attr_type):
16441 Built in type for the SecurityPermission Attribute.
16442 (code_access_permission_type): Build in type.
16444 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16446 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16447 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16448 all of this information into
16449 EmitContext.EmitCapturedVariableInstance.
16451 * codegen.cs (EmitCapturedVariableInstance): move here the
16452 funcionality of emitting an ldarg.0 in the presence of a
16453 remapping. This centralizes the instance emit code.
16455 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16456 then emit a load of this: it means that we have reached the
16457 topmost ScopeInfo: the one that contains the pointer to the
16458 instance of the class hosting the anonymous method.
16460 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16461 captures to the topmost CaptureContext.
16463 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16465 * expression.cs (LocalVariableReference): Move the knowledge about
16466 the iterators into codegen's EmitCapturedVariableInstance.
16468 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16470 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16471 all code paths return a value from an anonymous method (it is the
16472 same as the 161 error, but for anonymous methods).
16474 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16476 The introduction of anonymous methods in the compiler changed
16477 various ways of doing things in the compiler. The most
16478 significant one is the hard split between the resolution phase
16479 and the emission phases of the compiler.
16481 For instance, routines that referenced local variables no
16482 longer can safely create temporary variables during the
16483 resolution phase: they must do so from the emission phase,
16484 since the variable might have been "captured", hence access to
16485 it can not be done with the local-variable operations from the runtime.
16489 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16490 is a toplevel block.
16492 (ToplevelBlock): A new kind of Block, these are the blocks that
16493 are created by the parser for all toplevel method bodies. These
16494 include methods, accessors and anonymous methods.
16496 These contain some extra information not found in regular blocks:
16497 A pointer to an optional CaptureContext (for tracking captured
16498 local variables and parameters). A pointer to the parent
16501 (Return.Resolve): Catch missmatches when returning a value from an
16502 anonymous method (error 1662).
16503 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16506 (Break.Resolve): ditto.
16508 (SwitchLabel): instead of defining the labels during the
16509 resolution phase, we now turned the public ILLabel and ILLabelCode
16510 labels into methods called GetILLabelCode() and GetILLabel() that
16511 only define the label during the Emit phase.
16513 (GotoCase): Track the SwitchLabel instead of the computed label
16514 (its contained therein). Emit the code by using
16515 SwitchLabel.GetILLabelCode ().
16517 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16518 whether the Local has been captured or not.
16520 (LocalInfo.IsCaptured): New property, used to tell whether the
16521 local has been captured.
16523 * anonymous.cs: Vastly updated to contain the anonymous method
16526 The main classes here are: CaptureContext which tracks any
16527 captured information for a toplevel block and ScopeInfo used to
16528 track the activation frames for various local variables.
16530 Each toplevel block has an optional capture context associated
16531 with it. When a method contains an anonymous method both the
16532 toplevel method and the anonymous method will create a capture
16533 context. When variables or parameters are captured, they are
16534 recorded on the CaptureContext that owns them, for example:
16538 MyDelegate d = delegate {
16543 Here `a' will be recorded as captured on the toplevel
16544 CapturedContext, the inner captured context will not have anything
16545 (it will only have data if local variables or parameters from it
16546 are captured in a nested anonymous method.
16548 The ScopeInfo is used to track the activation frames for local
16549 variables, for example:
16551 for (int i = 0; i < 10; i++)
16552 for (int j = 0; j < 10; j++){
16553 MyDelegate d = delegate {
16558 At runtime this captures a single captured variable `i', but it
16559 captures 10 different versions of the variable `j'. The variable
16560 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16561 recorded on a child.
16563 The toplevel ScopeInfo will also track information like the `this'
16564 pointer if instance variables were referenced (this is necessary
16565 as the anonymous method lives inside a nested class in the host
16566 type of the method).
16568 (AnonymousMethod): Expanded to track the Toplevel, implement
16569 `AnonymousMethod.Compatible' to tell whether an anonymous method
16570 can be converted to a target delegate type.
16572 The routine now also produces the anonymous method content
16574 (AnonymousDelegate): A helper class that derives from
16575 DelegateCreation, this is used to generate the code necessary to
16576 produce the delegate for the anonymous method that was created.
16578 * assign.cs: API adjustments for new changes in
16579 Convert.ImplicitStandardConversionExists.
16581 * class.cs: Adjustments to cope with the fact that now toplevel
16582 blocks are of type `ToplevelBlock'.
16584 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16585 insteda of standard blocks.
16587 Flag errors if params arguments are passed to anonymous methods.
16589 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16590 `CurrentAnonymousMethod' which points to the current Anonymous
16591 Method. The variable points to the AnonymousMethod class that
16592 holds the code being compiled. It is set in the new EmitContext
16593 created for the anonymous method.
16595 (EmitContext.Phase): Introduce a variable and an enumeration to
16596 assist in enforcing some rules about when and where we are allowed
16597 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16598 only one that enfonces this right now).
16600 (EmitContext.HaveCaptureInfo): new helper method that returns
16601 whether we have a CapturedContext initialized.
16603 (EmitContext.CaptureVariable): New method used to register that a
16604 LocalInfo must be flagged for capturing.
16606 (EmitContext.CapturedParameter): New method used to register that a
16607 parameters must be flagged for capturing.
16609 (EmitContext.CapturedField): New method used to register that a
16610 field must be flagged for capturing.
16612 (EmitContext.HaveCapturedVariables,
16613 EmitContext.HaveCapturedFields): Return whether there are captured
16614 variables or fields.
16616 (EmitContext.EmitMethodHostInstance): This is used to emit the
16617 instance for the anonymous method. The instance might be null
16618 (static methods), this (for anonymous methods that capture nothing
16619 and happen to live side-by-side with the current method body) or a
16620 more complicated expression if the method has a CaptureContext.
16622 (EmitContext.EmitTopBlock): Routine that drives the emission of
16623 code: it will first resolve the top block, then emit any metadata
16624 and then emit the code. The split is done so that we can extract
16625 any anonymous methods and flag any captured variables/parameters.
16627 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16628 during this phase, the ILGenerator should not be used as labels
16629 and local variables declared here might not be accessible to any
16630 code that is part of an anonymous method.
16632 Exceptions to this include the temporary variables that are
16633 created by some statements internally for holding temporary
16636 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16639 (EmitContext.TemporaryReturn): This method is typically called
16640 from the Emit phase, and its the only place where we allow the
16641 ReturnLabel to be defined other than the EmitMeta. The reason is
16642 that otherwise we would have to duplicate a lot of logic in the
16643 Resolve phases of various methods that today is on the Emit
16646 (EmitContext.NeedReturnLabel): This no longer creates the label,
16647 as the ILGenerator is not valid during the resolve phase.
16649 (EmitContext.EmitThis): Extended the knowledge in this class to
16650 work in anonymous methods in addition to iterators.
16652 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16653 code is necessary on the stack to access the instance to a local
16654 variable (the variable will be accessed as a field).
16656 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16657 EmitContext.EmitAddressOfParameter): Routines to support
16658 parameters (not completed at this point).
16660 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16661 will also remove the parameters.
16663 * convert.cs (Convert): Define a `ConstantEC' which points to a
16664 null. This is just to prefity some code that uses
16665 ImplicitStandardConversion code and do not have an EmitContext
16668 The idea is to flag explicitly that at that point in time, it is
16669 known that the conversion will not trigger the delegate checking
16670 code in implicit conversions (which requires a valid
16673 Everywhere: pass new EmitContext parameter since
16674 ImplicitStandardConversionExists now requires it to check for
16675 anonymous method conversions.
16677 (Convert.ImplicitStandardConversionExists): If the type of an
16678 expression is the anonymous_method_type, and the type is a
16679 delegate, we invoke the AnonymousMethod.Compatible method to check
16680 whether an implicit conversion is possible.
16682 (Convert.ImplicitConversionStandard): Only do implicit method
16683 group conversions if the language level is not ISO_1.
16685 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16686 MethodInfo for the Invoke method. used by Delegate and
16689 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16690 method conversions if the target type is a delegate.
16692 Removed extra debugging nops.
16694 (LocalVariableReference): Turn the `local_info' into a public
16697 Add `prepared' field, the same hack used for FieldExprs to cope
16698 with composed assignments, as Local variables do not necessarily
16699 operate purely on the stack as they used to: they can be captured
16702 Add `temp' for a temporary result, like fields.
16704 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16706 It now copes with Local variables that are captured and emits the
16707 proper instance variable to load it from a field in the captured
16710 (ParameterReference.DoResolveBase): During the resolve phase,
16711 capture parameters if we are in an anonymous method.
16713 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16714 anonymous method, use the EmitContext helper routines to emit the
16715 parameter reference.
16717 * iterators.cs: Set RemapToProxy to true/false during the
16720 * parameters.cs (GetParameterByName): New helper method.
16722 * typemanager.cs (anonymous_method_type) a new type that
16723 represents an anonyous method. This is always an internal type,
16724 used as a fencepost to test against the anonymous-methodness of an
16727 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16729 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16731 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16733 2004-10-18 Martin Baulig <martin@ximian.com>
16735 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16736 `Type' directly, but call ResolveType() on it.
16737 (Catch.Resolve): Likewise.
16738 (Foreach.Resolve): Likewise.
16740 2004-10-18 Martin Baulig <martin@ximian.com>
16742 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16743 `Type' directly, but call ResolveType() on it.
16744 (Probe.DoResolve): Likewise.
16745 (ArrayCreation.LookupType): Likewise.
16746 (TypeOf.DoResolve): Likewise.
16747 (SizeOf.DoResolve): Likewise.
16749 2004-10-18 Martin Baulig <martin@ximian.com>
16751 * expression.cs (Invocation.BetterFunction): Put back
16752 TypeManager.TypeToCoreType().
16754 2004-10-18 Raja R Harinath <rharinath@novell.com>
16756 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16759 2004-10-18 Martin Baulig <martin@ximian.com>
16761 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16762 `Type' directly, but call ResolveType() on it.
16764 2004-10-18 Martin Baulig <martin@ximian.com>
16766 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16767 `Type' directly, but call ResolveType() on it.
16768 (MemberBase.DoDefine): Likewise.
16770 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16771 `Type' directly, but call ResolveType() on it.
16772 (ComposedCast.DoResolveAsTypeStep): Likewise.
16774 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16775 `Type' directly, but call ResolveType() on it.
16777 2004-10-17 John Luke <john.luke@gmail.com>
16779 * class.cs (Operator.GetSignatureForError): use CSharpName
16781 * parameter.cs (Parameter.GetSignatureForError): Returns
16782 correct name even if was not defined.
16784 2004-10-13 Raja R Harinath <rharinath@novell.com>
16787 * class.cs (TypeContainer.EmitContext): New property.
16788 (DefineNestedTypes): Create an emitcontext for each part.
16789 (MethodCore.DoDefineParameters): Use container's emitcontext.
16790 Pass type array to InternalParameters.
16791 (MemberBase.DoDefine): Use container's emitcontext.
16792 (FieldMember.Define): Likewise.
16793 (Event.Define): Likewise.
16794 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16795 Pass type array to InternalParameters.
16796 (SetIndexerMethod.GetParameterInfo): Likewise.
16797 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16798 * delegate.cs (Define): Pass emitcontext to
16799 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16800 array to InternalParameters.
16801 * expression.cs (ParameterReference.DoResolveBase): Pass
16802 emitcontext to GetParameterInfo.
16803 (ComposedCast.DoResolveAsTypeStep): Remove check on
16804 ec.ResolvingTypeTree.
16805 * parameter.cs (Parameter.Resolve): Change argument to
16806 EmitContext. Use ResolveAsTypeTerminal.
16807 (Parameter.GetSignature): Change argument to EmitContext.
16808 (Parameters.ComputeSignature): Likewise.
16809 (Parameters.ComputeParameterTypes): Likewise.
16810 (Parameters.GetParameterInfo): Likewise.
16811 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16812 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16813 * support.cs (InternalParameters..ctor): Remove variant that takes
16815 * typemanager.cs (system_intptr_expr): New.
16816 (InitExpressionTypes): Initialize it.
16818 2004-10-12 Chris Toshok <toshok@ximian.com>
16820 * cs-parser.jay: fix location for try_statement and catch_clause.
16822 2004-10-11 Martin Baulig <martin@ximian.com>
16824 * report.cs: Don't make --fatal abort on warnings, we have
16825 -warnaserror for that.
16827 2004-10-07 Raja R Harinath <rharinath@novell.com>
16829 More DeclSpace.ResolveType avoidance.
16830 * decl.cs (MemberCore.InUnsafe): New property.
16831 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16832 with newly created EmitContext.
16833 (FieldMember.Define): Likewise.
16834 * delegate.cs (Delegate.Define): Likewise.
16835 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16836 only if normal name-lookup fails.
16837 (TypeExpr.DoResolve): Enable error-checking.
16838 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16839 (SizeOf.DoResolve): Likewise.
16840 (ComposedCast.DoResolveAsTypeStep): Likewise.
16841 (StackAlloc.DoResolve): Likewise.
16842 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16843 (Block.Unsafe): New property.
16844 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16845 (Unsafe): Set 'unsafe' flag of contained block.
16846 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16847 (Fixed.Resolve): Likewise.
16848 (Catch.Resolve): Likewise.
16849 (Using.ResolveLocalVariableDecls): Likewise.
16850 (Foreach.Resolve): Likewise.
16852 2004-10-05 John Luke <john.luke@gmail.com>
16854 * cs-parser.jay: add location to error CS0175
16856 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16858 * ecore.cs (Expression.Constantity): Add support for turning null
16861 * const.cs (Const.Define): Allow constants to be reference types
16862 as long as the value is Null.
16864 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16866 * namespace.cs (NamespaceEntry.Using): No matter which warning
16867 level is set, check if this namespace name has already been added.
16869 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16871 * expression.cs: reftype [!=]= null should always use br[true,false].
16874 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16877 * attribute.cs: Enum conversion moved to
16878 GetAttributeArgumentExpression to be applied to the all
16881 2004-10-01 Raja R Harinath <rharinath@novell.com>
16883 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16884 * class.c (TypeContainer.DefineType): Flag error if
16885 base types aren't accessible due to access permissions.
16886 * decl.cs (DeclSpace.ResolveType): Move logic to
16887 Expression.ResolveAsTypeTerminal.
16888 (DeclSpace.ResolveTypeExpr): Thin layer over
16889 Expression.ResolveAsTypeTerminal.
16890 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16891 Refactor code into NestedAccess. Use it.
16892 (DeclSpace.NestedAccess): New.
16893 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16894 argument to silence errors. Check access permissions.
16895 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16896 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16897 (Cast.DoResolve): Likewise.
16898 (New.DoResolve): Likewise.
16899 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16900 (TypeOf.DoResolve): Likewise.
16902 * expression.cs (Invocation.BetterConversion): Return the Type of
16903 the better conversion. Implement section 14.4.2.3 more faithfully.
16904 (Invocation.BetterFunction): Make boolean. Make correspondence to
16905 section 14.4.2.2 explicit.
16906 (Invocation.OverloadResolve): Update.
16907 (Invocation): Remove is_base field.
16908 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16909 (Invocation.Emit): Likewise.
16911 2004-09-27 Raja R Harinath <rharinath@novell.com>
16913 * README: Update to changes.
16915 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16917 * cs-parser.jay: Reverted 642 warning fix.
16919 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16922 * decl.cs (FindMemberWithSameName): Indexer can have more than
16925 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16927 * expression.cs (LocalVariableReference.DoResolveLValue):
16928 Do not report warning 219 for out values.
16929 (EmptyExpression.Null): New member to avoid extra allocations.
16931 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16933 * cs-parser.jay: Fix wrong warning 642 report.
16935 * cs-tokenizer.cs (CheckNextToken): New helper;
16936 Inspect next character if is same as expected.
16938 2004-09-23 Martin Baulig <martin@ximian.com>
16940 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16941 (Convert.ImplicitReferenceConversionExists): Likewise.
16943 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16945 * class.cs (Operator.Define): Add error 448 and 559 report.
16947 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16949 * class.cs (MemberBase.IsTypePermitted): New protected
16950 method for checking error CS0610.
16952 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16954 * class.cs (TypeContainer.HasExplicitLayout): New property
16955 Returns whether container has StructLayout attribute set Explicit.
16956 (FieldMember): New abstract class for consts and fields.
16957 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16958 (Field): Reuse FieldMember.
16960 * const.cs (Const): Reuse FieldMember.
16962 * rootcontext.cs: EmitConstants call moved to class.
16964 2004-09-22 Martin Baulig <martin@ximian.com>
16966 Thanks to Peter Sestoft for this bug report.
16968 * expression.cs (Conditional): If both the `trueExpr' and the
16969 `falseExpr' is a NullLiteral, return a NullLiteral.
16971 2004-09-22 Martin Baulig <martin@ximian.com>
16973 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16974 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16975 for the "get_Current" call.
16977 2004-09-22 Martin Baulig <martin@ximian.com>
16979 Marek and me just fixed one of our oldest bugs: #28562 :-)
16981 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16983 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16984 we're an EnumConstant, just return that.
16985 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16986 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16987 to get the value which'll actually be written into the attribute.
16988 However, we have to use GetValue() to access the attribute's value
16991 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16993 * constant.cs (Constant.IsNegative): New abstract property
16996 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16997 (StackAlloc.DoResolve): Reused IsNegative.
16999 2004-09-21 Martin Baulig <martin@ximian.com>
17001 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17002 if we're used in an iterator, we may be called from different
17005 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17006 we actually have an exception block.
17008 2004-09-20 John Luke <jluke@cfl.rr.com>
17010 * class.cs, cs-parser.jay: Improve the error report for 1520:
17011 report the actual line where the error happens, not where the
17012 class was declared.
17014 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17015 Pass location information that was available elsewhere.
17017 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17019 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17020 runtime to delay sign assemblies.
17022 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17024 * cs-parser.jay: Do not report the stack trace, this is barely
17027 2004-08-22 John Luke <john.luke@gmail.com>
17029 * driver.cs : check that a resource id is not already used
17030 before adding it, report CS1508 if it is, bug #63637
17032 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17034 * ecore.cs: Removed dead code.
17036 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17038 * class.cs: Do not report warning CS0067 on the interfaces.
17040 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17042 * cs-parser.jay: Add error 504 report.
17044 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17046 * rootcontext.cs: WarningLevel is 4 by default now.
17048 * statement.cs (Fixed.Resolve): Do not null
17051 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17054 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17055 deep search when property is not virtual.
17056 (PropertyExpr.ResolveAccessors): Make one call for both
17059 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17062 * statement.cs: Error 152 report constains also location.
17064 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17067 * const.cs: Explicitly set constant as static.
17069 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17072 * cs-parser.jay: Add error 1017 report.
17074 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17076 Fixed bug #59980, #64224
17077 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17079 * typemanager.cs (IsSpecialMethod): Simplified
17081 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17083 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17084 condition with better params.
17086 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17089 * attribute.cs (Resolve): Property has to have both
17092 2004-09-14 Martin Baulig <martin@ximian.com>
17094 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17096 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17099 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17100 called and is obsolete then this member suppress message
17101 when call is inside next [Obsolete] method or type.
17103 * expression.cs: Use TestObsoleteMethodUsage member.
17105 2004-09-14 Martin Baulig <martin@ximian.com>
17107 * cs-parser.jay: Sync a bit with the GMCS version.
17109 2004-09-14 Martin Baulig <martin@ximian.com>
17111 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17112 (CSharpParser.yacc_verbose_flag): New public field.
17114 * genericparser.cs: Removed.
17116 2004-09-14 Raja R Harinath <rharinath@novell.com>
17118 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17120 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17122 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17124 2004-09-10 Martin Baulig <martin@ximian.com>
17126 Backported my MemberName changes from GMCS into MCS.
17128 - we are now using a special `MemberName' class instead of using
17129 strings; in GMCS, the `MemberName' also contains the type
17132 - changed the grammar rules a bit:
17133 * the old `member_name' is now a `namespace_or_type_name':
17134 The rule is that we use `namespace_or_type_name' everywhere
17135 where we expect either a "member name" (GetEnumerator) or a
17136 "member name" with an explicit interface name
17137 (IEnumerable.GetEnumerator).
17138 In GMCS, the explicit interface name may include type arguments
17139 (IEnumerable<T>.GetEnumerator).
17140 * we use `member_name' instead of just `IDENTIFIER' for
17142 The rule is that we use `member_name' wherever a member may
17143 have type parameters in GMCS.
17145 * decl.cs (MemberName): New public class.
17146 (MemberCore.MemberName): New public readonly field.
17147 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17148 (DeclSpace): Likewise.
17150 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17151 * enum.cs (Enum.ctor): Likewise.
17153 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17155 (AliasEntry.ctor): Take a MemberName, not an Expression.
17156 (AliasEntry.UsingAlias): Likewise.
17158 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17159 (IMethodData.MemberName): Changed type from string to MemberName.
17160 (MemberBase.ExplicitInterfaceName): Likewise.
17161 (AbstractPropertyEventMethod.SetupName): Make this private.
17162 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17163 argument; compute the member name here.
17164 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17165 on the `member.MemberName' and the `prefix'.
17167 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17169 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17170 thus, we get a `MemberName' instead of a `string'. These
17171 declarations may have type parameters in GMCS.
17172 (interface_method_declaration, delegate_declaration): Likewise.
17173 (class_declaration, interface_declaration): Likewise.
17174 (method_header): Use `namespace_or_type_name' instead of
17175 `member_name'. We may be an explicit interface implementation.
17176 (property_declaration, event_declaration): Likewise.
17177 (member_name): This is now just an `IDENTIFIER', not a
17178 `namespace_or_type_name'.
17179 (type_name, interface_type): Removed.
17180 (namespace_or_type_name): Return a MemberName, not an Expression.
17181 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17182 call GetTypeExpression() on the MemberName to get an expression.
17183 (IndexerDeclaration.interface_type): Changed type from string to
17185 (MakeName): Operate on MemberName's instead of string's.
17187 2004-09-13 Raja R Harinath <rharinath@novell.com>
17190 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17191 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17192 lookup to avoid symbols introduced by 'using'.
17193 * rootcontext.cs (NamespaceLookup): Update.
17195 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17197 * class.cs (TypeContainer.DoDefineMembers): Do not call
17198 DefineDefaultConstructor for static classes.
17200 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17202 * attribute.cs (Attribute.Resolve): Add error 653 report.
17204 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17206 (Method.ApplyAttributeBuilder): Add error 685 report.
17207 (Operator.Define): Add error 564 report.
17209 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17211 * expression.cs (Invocation.DoResolve): Add error
17212 245 and 250 report.
17214 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17217 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17219 * class.cs (ConstructorInitializer.Resolve):
17220 Wrong error number (515->516).
17222 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17224 * class.cs (Indexer.Define): Add error 631 report.
17226 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17228 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17230 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17232 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17234 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17236 * cs-parser.jay: Added error CS0241 report.
17238 2004-09-10 Raja R Harinath <rharinath@novell.com>
17240 * cs-parser.jay (fixed_statement): Introduce a scope for the
17241 declaration in the 'fixed' statement.
17243 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17245 * cs-parser.jay: Added CS0230 error report.
17247 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17249 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17251 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17253 * expression.cs (Argument.Resolve): Added error CS0192 and
17256 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17258 C# 2.0 #pragma warning feature
17260 * cs-tokenizer.cs (PreProcessPragma): New method;
17261 Handles #pragma directive.
17263 * report.cs (WarningRegions): New class; Support
17264 class for #pragma warning directive. It tests whether
17265 warning is enabled for a given line.
17267 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17269 * const.cs: Add more descriptive error report, tahnks to
17272 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17274 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17276 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17278 * expression.cs: Apply patch from Ben: Remove dead code from
17279 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17280 as that code just threw an exception anwyays.
17282 * const.cs: Remove the call to the turnintoconstant, for details
17285 * literal.cs: The type of the null-literal is the null type; So
17286 we use a placeholder type (literal.cs:System.Null, defined here)
17289 * expression.cs (Conditional.DoResolve): Remove some old code that
17290 is no longer needed, conversions have been fixed.
17292 (ArrayCreationExpression.DoResolve): Return false if we fail to
17293 resolve the inner expression.
17295 2004-09-07 Raja R Harinath <rharinath@novell.com>
17298 * cs-parser.jay (delegate_declaration): Record a delegate
17299 declaration as a type declaration.
17300 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17302 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17304 * parameter.cs: Do not crash if the type can not be resolved.
17306 * expression.cs: Report errors with unsafe pointers, fixes #64896
17308 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17310 * expression.cs: Pointer arith always needs to do a conv.i
17311 if the operand is a long. fix 65320
17313 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17315 Fixed cs0619-37.cs, cs0619-38.cs
17317 * enum.cs (GetObsoleteAttribute): Removed.
17319 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17320 on Enum member is double staged. The first is tested member
17323 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17325 Fixed #56986, #63631, #65231
17327 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17328 adds member to name container.
17329 (TypeContainer.AddToTypeContainer): New method, adds type to
17331 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17332 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17333 AddOperator): Simplified by reusing AddToMemberContainer.
17334 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17336 (Method.CheckForDuplications): Fixed implementation to test all
17338 (MemberBase): Detection whether member is explicit interface
17339 implementation is now in constructor.
17340 (MemberBase.UpdateMemberName): Handles IndexerName.
17341 (Accessor): Changed to keep also location information.
17342 (AbstractPropertyEventMethod): Is derived from MemberCore.
17343 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17344 will be emited or not.
17345 (PropertyBase.AreAccessorsDuplicateImplementation):
17346 Tests whether accessors are not in collision with some method.
17347 (Operator): Is derived from MethodCore to simplify common
17350 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17352 (DeclSpace.AddToContainer): Adds the member to defined_names
17353 table. It tests for duplications and enclosing name conflicts.
17355 * enum.cs (EnumMember): Clean up to reuse the base structures
17357 2004-09-03 Martin Baulig <martin@ximian.com>
17359 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17360 into TypeContainer, to make partial classes work again.
17362 2004-09-03 Martin Baulig <martin@ximian.com>
17364 * rootcontext.cs (RootContext.V2): Removed.
17366 2004-03-23 Martin Baulig <martin@ximian.com>
17368 * expression.cs (Invocation.OverloadResolve): Added `bool
17369 may_fail' argument and use it instead of the Location.IsNull() hack.
17371 2004-09-03 Martin Baulig <martin@ximian.com>
17373 Merged latest changes into gmcs. Please keep this comment in
17374 here, it makes it easier for me to see what changed in MCS since
17375 the last time I merged.
17377 2004-09-03 Raja R Harinath <rharinath@novell.com>
17380 * expression.cs (BetterConversion): Don't allow either conversion
17381 to be null. Remove redundant implicit conversion test when 'q ==
17382 null' -- when this function is invoked, we already know that the
17383 implicit conversion exists.
17384 (BetterFunction): Assume that 'best' is non-null. Remove
17385 redundant reimplementation of IsApplicable when 'best' is null.
17386 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17387 number of arguments.
17388 (IsAncestralType): Extract from OverloadResolve.
17389 (OverloadResolve): Make robust to the MethodGroupExpr being
17390 unsorted. Implement all the logic of Section 14.5.5.1, and
17391 support overloading of methods from multiple applicable types.
17392 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17394 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17395 (RealError, Warning): Append type of report to related symbol.
17397 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17399 * enum.cs: Fixed CLS-Compliance checks for enum members.
17400 Error tests cs3008-8.cs, cs3014-8.cs
17402 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17404 Fixed bug #62342, #63102
17405 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17406 like ImplementMethod.
17408 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17410 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17413 2004-09-02 Martin Baulig <martin@ximian.com>
17415 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17416 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17419 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17421 C# 2.0 Static classes implemented
17423 * class.cs (TypeContainer): instance_constructors,
17424 initialized_fields, initialized_static_fields,
17425 default_constructor, base_inteface_types are protected to be
17426 accessible from StaticClass.
17427 (TypeContainer.DefineDefaultConstructor): New virtual method
17428 for custom default constructor generating
17429 (StaticClass): New class to handle "Static classes" feature.
17431 * cs-parser.jay: Handle static keyword on class like instance
17434 * driver.cs: Added "/langversion" command line switch with two
17435 options (iso-1, default).
17437 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17439 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17441 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17443 * delegate.cs: Style.
17445 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17447 * delegate.cs: Add seperate instance expr field for miguel.
17449 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17451 * PointerArithmetic (Resolve): make sure we are not doing
17452 pointer arith on void*. Also, make sure we are resolved
17453 by not setting eclass until resolve.
17455 All callers: Make sure that PointerArithmetic gets resolved.
17457 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17459 * ArrayCreation (LookupType): If the type does not resolve
17460 to an array, give an error.
17462 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17464 * statement.cs (Try.Resolve): Fixed bug #64222
17466 2004-08-27 Martin Baulig <martin@ximian.com>
17469 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17472 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17474 * ecore.cs (Constantify): Get underlying type via
17475 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17476 Windows in special cases.
17478 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17480 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17481 for obtaining also private methods.
17482 (GetRemoveMethod): Used GetRemoveMethod (true)
17483 for obtaining also private methods.
17485 2004-08-24 Martin Baulig <martin@ximian.com>
17487 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17488 MethodAttributes.HideBySig for operators.
17490 2004-08-23 Martin Baulig <martin@ximian.com>
17492 Back to the old error reporting system :-)
17494 * report.cs (Message): Removed.
17495 (Report.MessageData, ErrorData, WarningData): Removed.
17496 (Report.Error, Warning): Back to the old system.
17498 2004-08-23 Martin Baulig <martin@ximian.com>
17500 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17502 * class.cs (TypeContainer.ParentContainer): New public virtual
17503 method; replaces the explicit interface implementation.
17504 (ClassPart.ParentContainer): Override.
17506 2004-08-23 Martin Baulig <martin@ximian.com>
17508 * statement.cs (Switch): Added support for constant switches; see
17509 #59428 or test-285.cs.
17511 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17514 * statement.cs (GetEnumeratorFilter): Removed useless
17515 logic because C# specs is strict. GetEnumerator must be
17518 2004-08-22 Martin Baulig <martin@ximian.com>
17520 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17521 a switch and may break, reset the barrier. Fixes #59867.
17523 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17525 CLS-Compliance speed up (~5% for corlib)
17527 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17528 New method. Tests container for CLS-Compliant names
17530 * class.cs (TypeContainer.VerifyClsName): New method.
17531 Checks whether container name is CLS Compliant.
17532 (Constructor): Implements IMethodData.
17534 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17535 low-case table for CLS Compliance test.
17536 (MemberCache.VerifyClsParameterConflict): New method.
17537 Checks method parameters for CS3006 error.
17539 * enum.cs (EnumMember): Is derived from MemberCore.
17540 (Enum.VerifyClsName): Optimized for better performance.
17542 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17544 * report.cs: Renamed Error_T to Error and changed all
17547 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17549 * class.cs (TypeContainer.IndexerArrayList): New inner class
17550 container for indexers.
17551 (TypeContainer.DefaultIndexerName): New constant for default
17552 indexer name. Replaced all "Item" with this constant.
17553 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17555 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17556 DefaultMemberAttribute constructor.
17558 2004-08-05 Martin Baulig <martin@ximian.com>
17560 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17563 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17565 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17566 multi platforms problem.
17568 * compiler.csproj: Included shared files.
17570 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17572 Fix bug 60333, 55971 in the more general way
17573 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17574 Added arg_type argument for constant conversion.
17575 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17577 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17580 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17581 OperatorArrayList, MethodCoreArrayList for typecontainer
17582 containers. Changed class member types to these new types.
17583 (MethodArrayList.DefineMembers): Added test for CS0659.
17585 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17587 * cfold.cs: Synchronize the folding with the code in expression.cs
17588 Binary.DoNumericPromotions for uint operands.
17590 * attribute.cs: Revert patch from Raja, it introduced a regression
17591 while building Blam-1.2.1 (hard to isolate a test case).
17593 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17597 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17599 (MethodCore.parent_method): New member. The method we're overriding
17600 if this is an override method.
17601 (MethodCore.CheckBase): Moved from Method class and made common.
17602 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17604 (MethodCore.CheckForDuplications): New abstract method. For custom
17605 member duplication search in a container
17606 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17607 method and its return type.
17608 (Event.conflict_symbol): New member. Symbol with same name in the
17612 (MemberCache.FindMemberWithSameName): New method. The method
17613 is looking for conflict with inherited symbols.
17615 2004-08-04 Martin Baulig <martin@ximian.com>
17617 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17619 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17621 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17623 * report.cs (Message): New enum for better error, warning reference in
17625 (MessageData): New inner abstract class. It generally handles printing of
17626 error and warning messages.
17627 Removed unused Error, Warning, Message methods.
17629 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17631 Fix for cs0592-8.cs test
17633 (Attributable.ValidAttributeTargets): Made public.
17634 (Attribute.ExplicitTarget): New member for explicit target value.
17635 (Attribute.CheckTargets): Now we translate explicit attribute
17636 target to Target here.
17638 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17640 * ecore.cs (MethodGroupExpr): new IsBase property.
17642 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17644 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17645 rather than an instance expr.
17647 (DelegateCreation.Emit): Use the method group rather than
17648 the instance expression. Also, if you have base.Foo as the
17649 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17651 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17653 (NewDelegate.DoResolve): Only check for the existance of Invoke
17654 if the method is going to be needed. Use MethodGroupExpr.
17656 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17658 * expression.cs: For pointer arith., make sure to use
17659 the size of the type, not the size of the pointer to
17662 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17665 * class.cs (Class): Added error CS0502 test.
17667 2004-08-03 John Luke <jluke@cfl.rr.com>
17668 Raja R Harinath <rharinath@novell.com>
17671 * attribute.cs (Attribute.complained_before): New flag.
17672 (Attribute.ResolveType, Attribute.Resolve),
17673 (Attribute.DefinePInvokeMethod): Set it.
17674 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17676 2004-08-03 Martin Baulig <martin@ximian.com>
17678 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17679 use a user-defined operator; we still need to do numeric
17680 promotions in case one argument is a builtin type and the other
17681 one has an implicit conversion to that type. Fixes #62322.
17683 2004-08-02 Martin Baulig <martin@ximian.com>
17685 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17686 (LocalInfo.IsThis): New public property.
17687 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17689 2004-08-01 Martin Baulig <martin@ximian.com>
17691 * class.cs (TypeContainer.GetClassBases): Don't set the default
17692 here since we may get called from GetPartialBases().
17693 (TypeContainer.DefineType): If GetClassBases() didn't return a
17694 parent, use the default one.
17696 2004-07-30 Duncan Mak <duncan@ximian.com>
17698 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17700 2004-07-30 Martin Baulig <martin@ximian.com>
17702 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17704 * class.cs (SourceMethod): New public class, derive from the
17705 symbol writer's ISourceMethod.
17706 (Method): Use the new symbol writer API.
17708 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17709 as argument and use the new symbol writer.
17712 (SourceFile): Implement the symbol writer's ISourceFile.
17713 (Location.SymbolDocument): Removed.
17714 (Location.SourceFile): New public property.
17716 * symbolwriter.cs: Use the new symbol writer API.
17718 2004-07-30 Raja R Harinath <rharinath@novell.com>
17720 * Makefile (install-local): Remove. Functionality moved to
17723 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17725 * Makefile: Install mcs.exe.config file together with mcs.exe.
17726 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17727 correct runtime version.
17729 2004-07-25 Martin Baulig <martin@ximian.com>
17732 (TypeContainer.RegisterOrder): Removed, this was unused.
17733 (TypeContainer, interface_order): Removed.
17734 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17735 TypeContainer as argument since we can also be called with a
17736 `PartialContainer' for a partial class/struct/interface.
17737 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17738 of checking whether we're an `Interface' - we could be a
17739 `PartialContainer'.
17740 (PartialContainer.Register): Override; call
17741 AddClass()/AddStruct()/AddInterface() on our parent.
17743 * cs-parser.jay (interface_member_declaration): Add things to the
17744 `current_container', not the `current_class'.
17746 * rootcontext.cs (RegisterOrder): The overloaded version which
17747 takes an `Interface' was unused, removed.
17749 * typemanager.cs (TypeManager.LookupInterface): Return a
17750 `TypeContainer', not an `Interface'.
17751 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17752 contain a `PartialContainer' for an interface, so check it's
17753 `Kind' to figure out what it is.
17755 2004-07-25 Martin Baulig <martin@ximian.com>
17757 * class.cs (Class.DefaultTypeAttributes): New public constant.
17758 (Struct.DefaultTypeAttributes): Likewise.
17759 (Interface.DefaultTypeAttributes): Likewise.
17760 (PartialContainer.TypeAttr): Override this and add the
17761 DefaultTypeAttributes.
17763 2004-07-25 Martin Baulig <martin@ximian.com>
17765 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17766 we can just use the `Parent' field instead.
17768 2004-07-25 Martin Baulig <martin@ximian.com>
17770 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17772 2004-07-25 Martin Baulig <martin@ximian.com>
17774 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17775 our parts before defining any methods.
17776 (TypeContainer.VerifyImplements): Make this virtual.
17777 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17778 on our PartialContainer.
17780 2004-07-25 Martin Baulig <martin@ximian.com>
17782 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17784 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17785 argument, we can just use the `Parent' field instead.
17788 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17789 (MemberBase.DoDefine): Likewise.
17791 2004-07-24 Martin Baulig <martin@ximian.com>
17793 * decl.cs (MemberCore.Parent): New public field.
17794 (DeclSpace.Parent): Moved to MemberCore.
17796 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17797 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17799 (FieldBase, Field, Operator): Likewise.
17800 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17801 (EventField, Event): Likewise.
17803 2004-07-23 Martin Baulig <martin@ximian.com>
17805 * class.cs (PartialContainer): New public class.
17806 (ClassPart): New public class.
17807 (TypeContainer): Added support for partial classes.
17808 (TypeContainer.GetClassBases): Splitted some of the functionality
17809 out into GetNormalBases() and GetPartialBases().
17811 * cs-tokenizer.cs (Token.PARTIAL): New token.
17812 (Tokenizer.consume_identifier): Added some hacks to recognize
17813 `partial', but only if it's immediately followed by `class',
17814 `struct' or `interface'.
17816 * cs-parser.jay: Added support for partial clases.
17818 2004-07-23 Martin Baulig <martin@ximian.com>
17820 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17821 a `DeclSpace' and also made it readonly.
17822 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17823 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17824 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17826 * cs-parser.jay: Pass the `current_class', not the
17827 `current_container' (at the moment, this is still the same thing)
17828 to a new Method, Property, Event, Indexer or Constructor.
17830 2004-07-23 Martin Baulig <martin@ximian.com>
17832 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17833 and removed the `current_interface' one.
17834 (struct_declaration, class_declaration, interface_declaration):
17835 Set `current_class' to the newly created class/struct/interface;
17836 set their `Bases' and call Register() before parsing their body.
17838 2004-07-23 Martin Baulig <martin@ximian.com>
17840 * class.cs (Kind): New public enum.
17841 (TypeContainer): Made this class abstract.
17842 (TypeContainer.Kind): New public readonly field.
17843 (TypeContainer.CheckDef): New public method; moved here from
17845 (TypeContainer.Register): New public abstract method.
17846 (TypeContainer.GetPendingImplementations): New public abstract
17848 (TypeContainer.GetClassBases): Removed the `is_class' and
17849 `is_iface' parameters.
17850 (TypeContainer.DefineNestedTypes): Formerly known as
17852 (ClassOrStruct): Made this class abstract.
17854 * tree.cs (RootTypes): New public type.
17856 2004-07-20 Martin Baulig <martin@ximian.com>
17858 * tree.cs (Tree.RecordNamespace): Removed.
17859 (Tree.Namespaces): Removed.
17861 * rootcontext.cs (RootContext.IsNamespace): Removed.
17863 * cs-parser.jay (namespace_declaration): Just create a new
17864 NamespaceEntry here.
17866 2004-07-20 Martin Baulig <martin@ximian.com>
17868 * statement.cs (ExceptionStatement): New abstract class. This is
17869 now used as a base class for everyone who's using `finally'.
17870 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17871 our local variables before using them.
17873 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17874 virtual method. This is used by Yield.Resolve() to "steal" an
17875 outer block's `finally' clauses.
17876 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17879 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17880 version which takes an ExceptionStatement. This version must be
17881 used to create exception branchings.
17884 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17885 (Iterator.EmitMoveNext): Added exception support; protect the
17886 block with a `fault' clause, properly handle 'finally' clauses.
17887 (Iterator.EmitDispose): Run all the `finally' clauses here.
17889 2004-07-20 Martin Baulig <martin@ximian.com>
17891 * iterator.cs: This is the first of a set of changes in the
17892 iterator code. Match the spec more closely: if we're an
17893 IEnumerable, then GetEnumerator() must be called. The first time
17894 GetEnumerator() is called, it returns the current instance; all
17895 subsequent invocations (if any) must create a copy.
17897 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17899 * expression.cs: Resolve the constant expression before returning
17902 2004-07-19 Martin Baulig <martin@ximian.com>
17904 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17905 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17906 the return type of the new EmitContext.
17908 2004-07-18 Martin Baulig <martin@ximian.com>
17910 * class.cs (Property.Define): Fix iterators.
17912 * iterators.cs (Iterator.Define): Moved the
17913 `container.AddInterator (this)' call here from the .ctor; only do
17914 it if we resolved successfully.
17916 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17918 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17919 `true' for preprocessing directives that we parse. The return
17920 value indicates whether we should return to regular tokenizing or
17921 not, not whether it was parsed successfully.
17923 In the past if we were in: #if false ... #line #endif, we would
17924 resume parsing after `#line'. See bug 61604.
17926 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17927 building: IsEnumType should return true only for enums, not for
17928 enums or System.Enum itself. This fixes #61593.
17930 Likely what happened is that corlib was wrong: mcs depended on
17931 this bug in some places. The bug got fixed, we had to add the
17932 hack, which caused bug 61593.
17934 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17935 that was a workaround for the older conditions.
17937 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17939 * assign.cs: IAssignMethod has a new interface, as documented
17940 inline. All assignment code now uses this new api.
17942 * ecore.cs, expression.cs: All classes which implement
17943 IAssignMethod now use the new interface.
17945 * expression.cs (Invocation): add a hack to EmitCall so that
17946 IndexerAccess can be the target of a compound assignment without
17947 evaluating its arguments twice.
17949 * statement.cs: Handle changes in Invocation api.
17951 2004-07-16 Martin Baulig <martin@ximian.com>
17953 * iterators.cs: Rewrote this. We're now using one single Proxy
17954 class for both the IEnumerable and the IEnumerator interface and
17955 `Iterator' derives from Class so we can use the high-level API.
17957 * class.cs (TypeContainer.AddIterator): New method.
17958 (TypeContainer.DoDefineType): New protected virtual method, which
17959 is called from DefineType().
17960 (TypeContainer.DoDefineMembers): Call DefineType() and
17961 DefineMembers() on all our iterators.
17962 (TypeContainer.Emit): Call Emit() on all our iterators.
17963 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17965 * codegen.cs (EmitContext.CurrentIterator): New public field.
17967 2004-07-15 Martin Baulig <martin@ximian.com>
17970 (TypeManager.not_supported_exception_type): New type.
17972 2004-07-14 Martin Baulig <martin@ximian.com>
17974 * iterators.cs: Use real error numbers.
17976 2004-07-14 Martin Baulig <martin@ximian.com>
17978 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17979 requires this to be a System.Collection.IEnumerable and not a
17980 class implementing that interface.
17981 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17983 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17985 * class.cs: Fixed previous fix, it broke some error tests.
17987 2004-07-12 Martin Baulig <martin@ximian.com>
17989 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17992 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17994 * assign.cs (LocalTemporary): Add new argument: is_address,If
17995 `is_address' is true, then the value that we store is the address
17996 to the real value, and not the value itself.
17998 * ecore.cs (PropertyExpr): use the new local temporary
17999 stuff to allow us to handle X.Y += z (where X is a struct)
18001 2004-07-08 Martin Baulig <martin@ximian.com>
18003 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18004 not always return, just like we're doing in Using.Resolve().
18006 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18008 * cs-parser.jay (fixed_statement): flag this as Pinned.
18010 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18012 * typemanager.cs (TypeManager): Removed MakePinned method, this
18013 mechanism is replaced with the .NET 2.x compatible mechanism of
18014 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18016 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18017 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18018 `IsFixed' property which has a different meaning.
18020 2004-07-02 Raja R Harinath <rharinath@novell.com>
18022 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18023 visible from inside a nested class, not just the names of the
18024 immediately enclosing class.
18025 Fix for bug #60730.
18027 2004-06-24 Raja R Harinath <rharinath@novell.com>
18029 * expression.cs (BetterConversion): Remove buggy special-case
18030 handling of "implicit constant expression conversions". At this
18031 point, we already know that the conversion is possible -- we're
18032 only checking to see which is better.
18034 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18036 * cs-parser.jay: Added error CS0210 test.
18038 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18040 * cs-parser.jay: Added error CS0134 test.
18042 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18045 * cs-parser.jay: Added error CS0145 test.
18047 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18049 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18051 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18053 * expression.cs (StackAlloc.Resolve): The argument may not
18054 be a constant; deal with this case.
18056 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18058 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18059 GetIndexerAttributeValue.
18060 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18062 * class.cs (Indexer.Define): Added error tests for CS0415,
18065 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18067 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18070 2004-06-23 Martin Baulig <martin@ximian.com>
18072 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18073 neither return nor throw, reset the barrier as well. Fixes #60457.
18075 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18077 * class.cs : EventAttributes is now set to None by default.
18078 This fixes bug #60459.
18080 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18083 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18084 Don't throw exception but return null (it's sufficient now).
18086 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18088 * typemanager.cs (GetArgumentTypes): Faster implementation.
18090 2004-06-18 Martin Baulig <martin@ximian.com>
18092 * attribute.cs (Attribute.Resolve): Check whether we're an
18093 EmptyCast which a Constant child. Fixes #60333.
18095 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18097 * statement.cs (EmitCollectionForeach): Account for the fact that
18098 not all valuetypes are in areas which we can take the address of.
18099 For these variables, we store to a temporary variable. Also, make
18100 sure that we dont emit a `callvirt' on a valuetype method.
18102 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18104 * expression.cs (StackAlloc.DoReSolve): Added test for
18105 negative parameter (CS0247).
18107 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18110 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18112 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18115 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18118 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18120 Fix bug #58254 & cs1555.cs, cs1556.cs
18121 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18123 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18125 * cs-parser.jay: Added error CS1669 test for indexers.
18127 2004-06-11 Martin Baulig <martin@ximian.com>
18129 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18130 call this twice: for params and varargs methods.
18132 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18135 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18137 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18139 * attribute.cs (Attribute.GetValidTargets): Made public.
18142 (AbstractPropertyEventMethod): New class for better code sharing.
18143 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18145 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18147 2004-06-11 Raja R Harinath <rharinath@novell.com>
18150 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18151 that the call to Resolve is part of a MemberAccess.
18152 (Expression.Resolve): Use it for SimpleName resolution.
18153 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18154 Add 'intermediate' boolean argument.
18155 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18156 error message when the SimpleName can be resolved ambiguously
18157 between an expression and a type.
18158 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18160 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18161 call on the left-side.
18163 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18166 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18168 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18170 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18172 2004-06-11 Martin Baulig <martin@ximian.com>
18174 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18175 varargs methods if applicable.
18177 2004-06-11 Martin Baulig <martin@ximian.com>
18179 * expression.cs (Invocation.EmitCall): Don't use
18180 `method.CallingConvention == CallingConventions.VarArgs' since the
18181 method could also have `CallingConventions.HasThis'.
18183 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18185 * class.cs (Event.GetSignatureForError): Implemented.
18186 Fixed crash in error test cs3010.cs
18188 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18190 * cs-tokenizer.cs: Change the way we track __arglist to be
18191 consistent with the other keywords.
18193 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18195 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18198 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18200 * codegen.cs: Check that all referenced assemblies have a strongname
18201 before strongnaming the compiled assembly. If not report error CS1577.
18202 Fix bug #56563. Patch by Jackson Harper.
18203 * typemanager.cs: Added a method to return all referenced assemblies.
18204 Fix bug #56563. Patch by Jackson Harper.
18206 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18209 (Method.ApplyAttributeBuilder): Moved and added conditional
18210 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18213 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18215 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18218 * class.cs: (EventField.attribute_targets): Changed default target.
18220 2004-06-08 Martin Baulig <martin@ximian.com>
18222 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18224 2004-06-08 Martin Baulig <martin@ximian.com>
18226 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18228 2004-06-07 Martin Baulig <martin@ximian.com>
18230 Added support for varargs methods.
18232 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18235 * cs-parser.jay: Added support for `__arglist'.
18237 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18239 * expression.cs (Argument.AType): Added `ArgList'.
18240 (Invocation): Added support for varargs methods.
18241 (ArglistAccess): New public class.
18242 (Arglist): New public class.
18244 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18246 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18247 a method's top-level block if the method has varargs.
18249 * support.cs (ReflectionParameters, InternalParameters): Added
18250 support for varargs methods.
18252 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18254 * class.cs: Provide location in indexer error report.
18256 * driver.cs: Use standard names.
18258 * namespace.cs: Catch the use of using after a namespace has been
18259 declared also on using aliases.
18261 2004-06-03 Raja R Harinath <rharinath@novell.com>
18264 * typemanager.cs (closure_private_ok, closure_invocation_type)
18265 (closure_qualifier_type, closure_invocation_assembly)
18266 (FilterWithClosure): Move to ...
18267 (Closure): New internal nested class.
18268 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18269 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18270 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18271 (MemberLookup, MemberLookupFailed): Use it.
18272 * expression.cs (New.DoResolve): Treat the lookup for the
18273 constructor as being qualified by the 'new'ed type.
18274 (Indexers.GetIndexersForTypeOrInterface): Update.
18276 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18279 (GetConditionalAttributeValue): New method. Returns
18280 condition of ConditionalAttribute.
18281 (SearchMulti): New method. Returns all attributes of type 't'.
18282 Use it when attribute is AllowMultiple = true.
18283 (IsConditionalMethodExcluded): New method.
18286 (Method.IsExcluded): Implemented. Returns true if method has conditional
18287 attribute and the conditions is not defined (method is excluded).
18288 (IMethodData): Extended interface for ConditionalAttribute support.
18289 (PropertyMethod.IsExcluded): Implemented.
18292 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18295 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18298 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18300 * expression.cs (ArrayCreationExpression): Make this just an
18301 `expression'. It can't be a statement, so the code here was
18304 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18307 * typemanager.cs (GetFullNameSignature): New method for
18310 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18313 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18314 Use this method when MethodBuilder is null.
18315 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18316 Added test for error CS0626 (MONO reports error for this situation).
18317 (IMethodData.GetSignatureForError): Extended interface.
18319 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18322 (AttributeTester.GetObsoleteAttribute): Returns instance of
18323 ObsoleteAttribute when type is obsolete.
18326 (TypeContainer.VerifyObsoleteAttribute): Override.
18327 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18328 (MethodCode.VerifyObsoleteAttribute): Override.
18329 (MemberBase.VerifyObsoleteAttribute): Override.
18332 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18333 and report proper error.
18336 Delegate.VerifyObsoleteAttribute): Override.
18339 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18340 and report proper error.
18341 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18344 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18348 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18349 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18350 Added test for ObsoleteAttribute.
18353 (Catch): Derived from Statement.
18355 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18357 Fixed bug #59071 & cs0160.cs
18359 * statement.cs (Try.Resolve): Check here whether order of catch
18360 clauses matches their dependencies.
18362 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18364 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18365 caused a regression: #59343. Referencing nested classes from an
18366 assembly stopped working.
18368 2004-05-31 Martin Baulig <martin@ximian.com>
18370 MCS is now frozen for beta 2.
18372 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18374 * convert.cs: add a trivial cache for overload operator resolution.
18376 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18378 * decl.cs: If possible, use lookuptypedirect here. We can only do
18379 this if there is no `.' after the namespace. Avoids using
18380 LookupType, which does lots of slow processing.
18381 (FindNestedType) New method, does what it says :-).
18382 * namespace.cs: use LookupTypeDirect.
18383 * rootcontext.cs: use membercache, if possible.
18384 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18386 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18389 According to the spec,
18391 In a member access of the form E.I, if E is a single identifier,
18392 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18393 field, property, localvariable, or parameter with the same type as
18394 the meaning of E as a type-name (§3.8), then both possible
18395 meanings of E are permitted.
18397 We did not check that E as a simple-name had the same type as E as
18400 This trivial check gives us 5-7% on bootstrap time.
18402 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18404 * expression.cs (Invocation.OverloadResolve): Avoid the
18405 use of hashtables and boxing here by allocating on demand.
18407 2004-05-30 Martin Baulig <martin@ximian.com>
18409 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18410 we're doing a silent lookup. Don't try to lookup nested types in
18411 TypeManager.object_type (thanks to Ben Maurer).
18413 2004-05-30 Martin Baulig <martin@ximian.com>
18415 Committing a patch from Ben Maurer.
18417 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18419 2004-05-29 Martin Baulig <martin@ximian.com>
18421 * class.cs (IMethodData.ShouldIgnore): New method.
18423 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18424 `Location' argument, we don't need it anywhere. Use
18425 `IMethodData.ShouldIgnore ()' instead of
18426 `MethodData.GetMethodFlags ()'.
18427 (TypeManager.AddMethod): Removed.
18428 (TypeManager.AddMethod2): Renamed to AddMethod.
18430 2004-05-29 Martin Baulig <martin@ximian.com>
18432 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18434 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18435 converting from a class type S to an interface type and we already
18436 have an object on the stack, don't box it again. Fixes #52578.
18438 2004-05-29 Martin Baulig <martin@ximian.com>
18440 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18441 Added support for `params' parameters. Fixes #59267.
18443 2004-05-29 Martin Baulig <martin@ximian.com>
18445 * literal.cs (NullPointer): Provide a private .ctor which sets
18446 `type' to TypeManager.object_type. Fixes #59048.
18448 2004-05-29 Martin Baulig <martin@ximian.com>
18450 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18451 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18453 * ecore.cs (EventExpr.instance_expr): Make the field private.
18455 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18457 Fixed bug #50080 & cs0214-2.cs
18458 * expression.cs (Cast.DoResolve): Check unsafe context here.
18460 * statement.cs (Resolve.DoResolve): Likewise.
18462 2004-05-26 Martin Baulig <martin@ximian.com>
18464 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18466 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18467 (RootContext.LookupType): Pass down the `silent' flag.
18469 2004-05-25 Martin Baulig <martin@ximian.com>
18472 (MethodGroupExpr.IdenticalTypeName): New public property.
18473 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18474 expression actually refers to a type.
18476 2004-05-25 Martin Baulig <martin@ximian.com>
18478 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18479 for #56176 and made it actually work.
18481 2004-05-25 Martin Baulig <martin@ximian.com>
18483 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18484 (FieldExpr, PropertyExpr): Override and implement
18485 CacheTemporaries. Fixes #52279.
18487 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18489 * location.cs: In the new compiler listing a file twice is a
18490 warning, not an error.
18492 2004-05-24 Martin Baulig <martin@ximian.com>
18494 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18495 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18497 2004-05-24 Martin Baulig <martin@ximian.com>
18499 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18500 walking the `using' list. Fixes #53921.
18502 2004-05-24 Martin Baulig <martin@ximian.com>
18504 * const.cs (Const.LookupConstantValue): Added support for
18505 EmptyCast's; fixes #55251.
18507 2004-05-24 Martin Baulig <martin@ximian.com>
18509 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18510 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18511 which does the CS0135 check. The reason is that we first need to
18512 check whether the variable actually exists.
18514 2004-05-24 Martin Baulig <martin@ximian.com>
18516 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18517 than RootContext.LookupType() to find the explicit interface
18518 type. Fixes #58584.
18520 2004-05-24 Raja R Harinath <rharinath@novell.com>
18522 * Makefile: Simplify. Use executable.make.
18523 * mcs.exe.sources: New file. List of sources of mcs.exe.
18525 2004-05-24 Anders Carlsson <andersca@gnome.org>
18529 Use the invariant culture when doing String.Compare for CLS case
18532 2004-05-23 Martin Baulig <martin@ximian.com>
18534 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18535 don't have any dots. Fixes #52622, added cs0246-8.cs.
18537 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18539 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18541 * class.cs (MemberBase.Define): Reuse MemberType member for
18542 resolved type. Other methods can use it too.
18544 2004-05-23 Martin Baulig <martin@ximian.com>
18546 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18547 the variable also exists in the current block (otherwise, we need
18548 to report a CS0103). Fixes #58670.
18550 2004-05-23 Martin Baulig <martin@ximian.com>
18552 * flowanalysis.cs (Reachability.Reachable): Compute this
18553 on-the-fly rather than storing it as a field.
18555 2004-05-23 Martin Baulig <martin@ximian.com>
18557 * flowanalysis.cs (Reachability.And): Manually compute the
18558 resulting `barrier' from the reachability.
18560 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18563 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18564 instance of ObsoleteAttribute when symbol is obsolete.
18567 (IMethodData): Extended interface for ObsoleteAttribute support.
18569 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18571 * attribute.cs: Fix bug #55970
18573 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18577 (GetObsoleteAttribute): New method. Creates the instance of
18579 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18580 ObsoleteAttribute when member is obsolete.
18581 (AttributeTester.Report_ObsoleteMessage): Common method for
18582 Obsolete error/warning reporting.
18585 (TypeContainer.base_classs_type): New member for storing parent type.
18588 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18589 for this MemberCore.
18591 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18593 * attribute.cs, const.cs: Fix bug #58590
18595 2004-05-21 Martin Baulig <martin@ximian.com>
18597 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18598 out parameters if the end of the method is unreachable. Fixes
18601 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18603 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18604 Hari was right, why extra method.
18606 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18608 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18610 2004-05-20 Martin Baulig <martin@ximian.com>
18612 Merged this back from gmcs to keep the differences to a minumum.
18614 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18615 instead of a Declspace.
18616 (Attribute.ResolveType): Likewise.
18617 (Attributes.Search): Likewise.
18618 (Attributes.Contains): Likewise.
18619 (Attributes.GetClsCompliantAttribute): Likewise.
18621 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18623 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18626 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18628 Fix bug #58688 (MCS does not report error when the same attribute
18631 * attribute.cs (Attribute.Emit): Distinction between null and default.
18633 2004-05-19 Raja R Harinath <rharinath@novell.com>
18635 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18636 of a top-level attribute without an attribute target.
18637 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18639 (Attribute.Conditional_GetConditionName),
18640 (Attribute.Obsolete_GetObsoleteMessage): Update.
18641 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18642 part of ScanForIndexerName.
18643 (Attribute.CanIgnoreInvalidAttribute): New function.
18644 (Attribute.ScanForIndexerName): Move to ...
18645 (Attributes.ScanForIndexerName): ... here.
18646 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18647 (Attributes.Search): New internal variant that can choose not to
18648 complain if types aren't resolved. The original signature now
18650 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18651 complaints suppressed.
18652 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18653 only if it not useful.
18654 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18655 top-level for attributes that are shared between the assembly
18656 and a top-level class.
18657 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18658 * class.cs: Update to reflect changes.
18659 (DefineIndexers): Fuse loops.
18660 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18661 a couple more variants of attribute names.
18663 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18665 Fix bug #52585 (Implemented explicit attribute declaration)
18668 (Attributable.ValidAttributeTargets): New abstract method. It gets
18669 list of valid attribute targets for explicit target declaration.
18670 (Attribute.Target): It holds target itself.
18671 (AttributeSection): Removed.
18672 (Attribute.CheckTargets): New method. It checks whether attribute
18673 target is valid for the current element.
18676 (EventProperty): New class. For events that are declared like
18677 property (with add and remove accessors).
18678 (EventField): New class. For events that are declared like field.
18681 * cs-parser.jay: Implemented explicit attribute target declaration.
18683 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18684 Override ValidAttributeTargets.
18687 (ReturnParameter): Class for applying custom attributes on
18689 (ParameterAtribute): New class. Class for applying custom
18690 attributes on the parameter type.
18692 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18694 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18697 (Method): Allow UNSAFE here.
18699 * modifiers.cs: Support unsafe reporting.
18701 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18703 * decl.cs: Fix bug #58478.
18705 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18707 * statement.cs: When checking for unreachable code on an EmptyStatement,
18708 set the location. Fixes bug #58488.
18710 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18712 * driver.cs: Add -pkg handling.
18714 From Gonzalo: UseShelLExecute=false
18716 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18719 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18721 (Attribute.IsClsCompliaceRequired): Moved to base for better
18723 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18724 when attribute is AttributeUsageAttribute.
18725 (Attribute.GetValidTargets): Simplified.
18726 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18727 attribute for this type.
18728 (Attribute.ApplyAttributes): Method renamed to Emit and make
18730 (GlobalAttributeSection): New class for special handling of global
18731 attributes (assembly, module).
18732 (AttributeSection.Emit): New method.
18734 * class.cs: Implemented Attributable abstract methods.
18735 (MethodCore.LabelParameters): Moved to Parameter class.
18736 (Accessor): Is back simple class.
18737 (PropertyMethod): Implemented Attributable abstract class.
18738 (DelegateMethod): Implemented Attributable abstract class.
18739 (Event): New constructor for disctintion between normal Event
18740 and Event with accessors.
18742 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18744 * codegen.cs, const.cs, decl.cs, delegate.cs:
18745 (CommonAssemblyModulClass): Implemented Attributable abstract class
18748 * enum.cs: Implement IAttributeSupport interface.
18749 (EnumMember): New class for emum members. Implemented Attributable
18753 (ParameterBase): Is abstract.
18754 (ReturnParameter): New class for easier [return:] attribute handling.
18756 * typemanager.cs: Removed builder_to_attr.
18758 2004-05-11 Raja R Harinath <rharinath@novell.com>
18761 * attribute.cs (Attribute.GetPositionalValue): New function.
18762 * class.cs (TypeContainer.VerifyMembers): New function.
18763 (TypeContainer.Emit): Use it.
18764 (ClassOrStruct): New base class for Class and Struct.
18765 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18766 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18768 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18769 then each non-static field should have a FieldOffset attribute.
18770 Otherwise, none of the fields should have a FieldOffset attribute.
18771 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18772 and FieldOffset attributes.
18773 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18774 (TypeManager.field_offset_attribute_type): New core types.
18775 (TypeManager.InitCoreTypes): Initialize them.
18777 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18779 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18780 Return correct type.
18783 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18785 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18786 be implicitly converted to ulong.
18788 * expression.cs: The logic for allowing operator &, | and ^ worked
18789 was wrong, it worked before because we did not report an error in
18790 an else branch. Fixes 57895.
18792 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18793 allow volatile fields to be reference types.
18795 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18797 * driver.cs: Add support for /debug-
18799 2004-05-07 Raja R Harinath <rharinath@novell.com>
18801 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18802 Add a 'complain' parameter to silence errors.
18803 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18804 silently overlooked type-resolutions.
18805 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18806 to reflect changes.
18807 (Attributes.Search): New function.
18808 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18809 (Attributes.GetAttributeFullName): Remove hack.
18810 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18811 Update to reflect changes.
18812 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18813 Use Attributes.Search instead of nested loops.
18815 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18818 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18819 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18820 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18822 * report.cs: (Report.Warning): Renamed to Warning_T because of
18823 parameter collision.
18825 2004-05-05 Raja R Harinath <rharinath@novell.com>
18827 * expression.cs (MemberAccess.ResolveMemberAccess):
18828 Exit with non-zero status after Report.Error.
18829 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18831 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18833 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18835 * support.cs: Don't hang when the file is empty.
18837 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18839 * support.cs: In SeekableStreamReader, compute the preamble size of the
18840 underlying stream. Position changes should take into account that initial
18843 2004-05-03 Todd Berman <tberman@sevenl.net>
18845 * driver.cs: remove unused GetSysVersion function.
18847 2004-05-03 Todd Berman <tberman@sevenl.net>
18849 * driver.cs: Remove the hack from saturday, as well as the hack
18850 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18851 link_paths to get that bit proper.
18853 2004-05-01 Todd Berman <tberman@sevenl.net>
18855 * driver.cs: Try a LoadFrom before a Load, this checks the current
18856 path. This is currently a bug in mono that is be fixed, however, this
18857 provides a workaround for now. This will be removed when the bug
18860 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18862 * CryptoConvert.cs: Updated to latest version. Fix issue with
18863 incomplete key pairs (#57941).
18865 2004-05-01 Todd Berman <tberman@sevenl.net>
18867 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18870 2004-04-30 Jackson Harper <jackson@ximian.com>
18872 * codegen.cs: Open keys readonly.
18874 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18876 * typemanager.cs: don't report cyclic struct layout when a struct
18877 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18878 which has 2 Pango.Rectangle fields.
18880 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18882 * expression.cs: Handle IntPtr comparisons with IL code
18883 rather than a method call.
18885 2004-04-29 Martin Baulig <martin@ximian.com>
18887 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18888 the list of PropertyInfo's in class hierarchy and find the
18889 accessor. Fixes #56013.
18891 2004-04-29 Martin Baulig <martin@ximian.com>
18893 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18895 2004-04-29 Martin Baulig <martin@ximian.com>
18897 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18899 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18901 2004-04-29 Martin Baulig <martin@ximian.com>
18903 * class.cs (ConstructorInitializer.Resolve): Check whether the
18904 parent .ctor is accessible. Fixes #52146.
18906 2004-04-29 Martin Baulig <martin@ximian.com>
18908 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18910 * statement.cs (Using.EmitLocalVariableDecls): Use
18911 TypeManager.idisposable_type, not typeof (IDisposable).
18912 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18914 2004-04-29 Martin Baulig <martin@ximian.com>
18916 * class.cs (Event.Define): Don't emit the field and don't set
18917 RTSpecialName and SpecialName for events on interfaces. Fixes
18920 2004-04-29 Raja R Harinath <rharinath@novell.com>
18922 Refactor Attribute.ApplyAttributes.
18923 * attribute.cs (Attributable): New base class for objects that can
18924 have Attributes applied on them.
18925 (Attribute): Make AttributeUsage fields public.
18926 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18927 (Attribute.IsInternalCall): New property.
18928 (Attribute.UsageAttr): Convert to a public read-only property.
18929 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18930 (Attribute.ResolveType, Attribute.Resolve)
18931 (Attribute.ScanForIndexerName): Update to reflect changes.
18932 (Attribute.CheckAttributeTarget): Re-format.
18933 (Attribute.ApplyAttributes): Refactor, to various
18934 Attributable.ApplyAttributeBuilder methods.
18935 * decl.cs (MemberCore): Make Attributable.
18936 * class.cs (Accessor): Make Attributable.
18937 (MethodData.ApplyAttributes): Use proper attribute types, not
18939 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18940 (TypeContainer.ApplyAttributeBuilder)
18941 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18942 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18943 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18944 (Operator.ApplyAttributeBuilder): New factored-out methods.
18945 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18946 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18947 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18948 * parameter.cs (ParameterBase): New Attributable base class
18949 that can also represent Return types.
18950 (Parameter): Update to the changes.
18952 2004-04-29 Jackson Harper <jackson@ximian.com>
18954 * driver.cs: Prefer the corlib system version when looking for
18955 assemblies in the GAC. This is still a hack, but its a better hack
18958 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18960 * decl.cs, enum.cs: Improved error 3005 reporting.
18962 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18963 (related_symbols): New private member for list of symbols
18964 related to reported error/warning.
18966 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18968 2004-04-29 Martin Baulig <martin@ximian.com>
18970 * ecore.cs (Expression.Constantify): If we're an enum and
18971 TypeManager.TypeToCoreType() doesn't give us another type, use
18972 t.UnderlyingSystemType. Fixes #56178.
18974 2004-04-29 Martin Baulig <martin@ximian.com>
18976 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18977 interfaces and for each interface, only add members directly
18978 declared in that interface. Fixes #53255.
18980 2004-04-28 Martin Baulig <martin@ximian.com>
18982 * expression.cs (ConditionalLogicalOperator): Use a temporary
18983 variable for `left' to avoid that we evaluate it more than once;
18986 2004-04-28 Martin Baulig <martin@ximian.com>
18988 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18991 2004-04-28 Martin Baulig <martin@ximian.com>
18993 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18996 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18997 whether the type is not void (CS1547).
18999 2004-04-28 Martin Baulig <martin@ximian.com>
19001 * expression.cs (Unary.DoResolveLValue): Override this and report
19002 CS0131 for anything but Operator.Indirection.
19004 2004-04-28 Martin Baulig <martin@ximian.com>
19006 Committing a patch from Ben Maurer; see bug #50820.
19008 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19011 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19014 2004-04-28 Martin Baulig <martin@ximian.com>
19016 Committing a patch from Ben Maurer; see bug #50820.
19018 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19021 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19024 2004-04-28 Martin Baulig <martin@ximian.com>
19026 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19027 (Block.AddLabel): Call DoLookupLabel() to only search in the
19030 2004-04-28 Martin Baulig <martin@ximian.com>
19032 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19033 comparing StringConstants and NullLiterals in Equality and Inequality.
19035 2004-04-28 Jackson Harper <jackson@ximian.com>
19037 * driver.cs: Attempt to load referenced assemblies from the
19038 GAC. This is the quick and dirty version of this method that
19039 doesnt take into account versions and just takes the first
19040 canidate found. Will be good enough for now as we will not have more
19041 then one version installed into the GAC until I update this method.
19043 2004-04-28 Martin Baulig <martin@ximian.com>
19045 * typemanager.cs (TypeManager.CheckStructCycles): New public
19046 static method to check for cycles in the struct layout.
19048 * rootcontext.cs (RootContext.PopulateTypes): Call
19049 TypeManager.CheckStructCycles() for each TypeContainer.
19050 [Note: We only need to visit each type once.]
19052 2004-04-28 Martin Baulig <martin@ximian.com>
19054 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19056 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19057 success and added `out object value'. Use a `bool resolved' field
19058 to check whether we've already been called rather than
19059 `ConstantValue != null' since this breaks for NullLiterals.
19061 2004-04-28 Raja R Harinath <rharinath@novell.com>
19063 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19064 setting of this flag, since the 'set' method may be non-public.
19066 2004-04-28 Raja R Harinath <rharinath@novell.com>
19068 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19069 check on current_vector.Block.
19071 2004-04-27 Martin Baulig <martin@ximian.com>
19073 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19074 a field initializer. Fixes #56459.
19076 2004-04-27 Martin Baulig <martin@ximian.com>
19078 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19079 we're not attempting to use an indexer. Fixes #52154.
19081 2004-04-27 Martin Baulig <martin@ximian.com>
19083 * statement.cs (Return): Don't create a return label if we don't
19084 need it; reverts my change from January 20th. Thanks to Ben
19087 2004-04-27 Martin Baulig <martin@ximian.com>
19089 According to the spec, `goto' can only leave a nested scope, but
19092 * statement.cs (Block.LookupLabel): Only lookup in the current
19093 block, don't recurse into parent or child blocks.
19094 (Block.AddLabel): Check in parent and child blocks, report
19095 CS0140/CS0158 if we find a duplicate.
19096 (Block): Removed this indexer for label lookups.
19097 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19098 this already does the error reporting for us.
19101 (FlowBranching.UsageVector.Block): New public variable; may be null.
19102 (FlowBranching.CreateSibling): Added `Block' argument.
19103 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19104 label for the target of a `goto' and check whether we're not
19105 leaving a `finally'.
19107 2004-04-27 Martin Baulig <martin@ximian.com>
19109 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19110 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19113 2004-04-27 Martin Baulig <martin@ximian.com>
19115 * statement.cs (Block.AddLabel): Also check for implicit blocks
19116 and added a CS0158 check.
19118 2004-04-27 Martin Baulig <martin@ximian.com>
19120 * flowanalysis.cs (FlowBranchingLoop): New class.
19121 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19122 UsageVector's instead of an ArrayList.
19123 (FlowBranching.Label): Likewise.
19124 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19125 (FlowBranching.AddBreakVector): New method.
19127 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19129 * attribute.cs: Small regression fix: only convert the type if we
19130 the type is different, fixes System.Drawing build.
19132 2004-04-27 Martin Baulig <martin@ximian.com>
19134 * attribute.cs (Attribute.Resolve): If we have a constant value
19135 for a named field or property, implicity convert it to the correct
19138 2004-04-27 Raja R Harinath <rharinath@novell.com>
19140 * statement.cs (Block.Block): Implicit blocks share
19141 'child_variable_names' fields with parent blocks.
19142 (Block.AddChildVariableNames): Remove.
19143 (Block.AddVariable): Mark variable as "used by a child block" in
19144 every surrounding block.
19145 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19146 been used in a child block, complain about violation of "Invariant
19147 meaning in blocks" rule.
19148 * cs-parser.jay (declare_local_variables): Don't use
19149 AddChildVariableNames.
19150 (foreach_statement): Don't create an implicit block: 'foreach'
19151 introduces a scope.
19153 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19155 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19156 converting from 0L to ulong. Fixes 57522.
19158 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19160 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19161 derived class hides via 'new' keyword field from base class (test-242.cs).
19162 TODO: Handle this in the more general way.
19164 * class.cs (CheckBase): Ditto.
19166 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19168 * decl.cs (caching_flags): New member for storing cached values
19170 (MemberCore.Flags): New enum where bit flags for caching_flags
19172 (MemberCore.cls_compliance): Moved to caching_flags.
19173 (DeclSpace.Created): Moved to caching_flags.
19175 * class.cs: Use caching_flags instead of DeclSpace.Created
19177 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19179 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19180 if we are only a derived class, not a nested class.
19182 * typemanager.cs: Same as above, but do this at the MemberLookup
19183 level (used by field and methods, properties are handled in
19184 PropertyExpr). Allow for the qualified access if we are a nested
19187 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19189 * class.cs: Refactoring.
19190 (IMethodData): New inteface; Holds links to parent members
19191 to avoid member duplication (reduced memory allocation).
19192 (Method): Implemented IMethodData interface.
19193 (PropertyBase): New inner classes for get/set methods.
19194 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19195 (Event): New inner classes for add/remove methods.
19196 (Event.DelegateMethod): Implemented IMethodData interface.
19198 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19199 EmitContext (related to class.cs refactoring).
19201 2004-04-21 Raja R Harinath <rharinath@novell.com>
19203 * delegate.cs (Delegate.VerifyApplicability): If the number of
19204 arguments are the same as the number of parameters, first try to
19205 verify applicability ignoring any 'params' modifier on the last
19209 2004-04-16 Raja R Harinath <rharinath@novell.com>
19211 * class.cs (TypeContainer.AddIndexer): Use
19212 'ExplicitInterfaceName' to determine if interface name was
19213 explicitly specified. 'InterfaceType' is not initialized at this time.
19214 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19215 Indexers array is already in the required order. Initialize
19216 'IndexerName' only if there are normal indexers.
19217 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19218 (TypeContainer.Emit): Emit DefaultMember attribute only if
19219 IndexerName is initialized.
19222 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19224 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19227 2004-04-15 Raja R Harinath <rharinath@novell.com>
19229 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19233 * attribute.cs (Attribute.Resolve): Check for duplicate named
19237 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19239 * iterators.cs (MarkYield): track whether we are in an exception,
19240 and generate code accordingly. Use a temporary value to store the
19241 result for our state.
19243 I had ignored a bit the interaction of try/catch with iterators
19244 since their behavior was not entirely obvious, but now it is
19245 possible to verify that our behavior is the same as MS .NET 2.0
19249 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19251 * iterators.cs: Avoid creating temporaries if there is no work to
19254 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19255 Enumerations, use TypeManager.EnumToUnderlying and call
19258 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19261 (This.Emit): Use EmitContext.EmitThis to emit our
19264 (This.EmitAssign): Ditto.
19266 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19267 codepaths, we will move all the functionality into
19270 (FieldExpr.EmitAssign): Ditto.
19272 This fixes several hidden bugs that I uncovered while doing a code
19273 review of this today.
19275 * codegen.cs (EmitThis): reworked so the semantics are more clear
19276 and also support value types "this" instances.
19278 * iterators.cs: Changed so that for iterators in value types, we
19279 do not pass the value type as a parameter.
19281 Initialization of the enumerator helpers is now done in the caller
19282 instead of passing the parameters to the constructors and having
19283 the constructor set the fields.
19285 The fields have now `assembly' visibility instead of private.
19287 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19289 * expression.cs (Argument.Resolve): Check if fields passed as ref
19290 or out are contained in a MarshalByRefObject.
19292 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19293 another compiler type.
19295 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19297 * class.cs (Indexer.Define): use the new name checking method.
19298 Also, return false on an error.
19299 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19300 (is_identifier_[start/part]_character): make static.
19302 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19304 * expression.cs (Binary.ResolveOperator): Do no append strings
19305 twice: since we can be invoked more than once (array evaluation)
19306 on the same concatenation, take care of this here. Based on a fix
19307 from Ben (bug #56454)
19309 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19311 * codegen.cs: Fix another case where CS1548 must be reported (when
19312 delay-sign isn't specified and no private is available #56564). Fix
19313 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19314 error when MCS is used on the MS runtime and we need to delay-sign
19315 (which seems unsupported by AssemblyBuilder - see #56621).
19317 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19319 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19320 (TypeManager.ComputeNamespaces): Faster implementation for
19323 * compiler.csproj: Updated AssemblyName to mcs.
19325 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19327 * rootcontext.cs: Add new types to the boot resolution.
19329 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19330 MulticastDelegate is not allowed.
19332 * typemanager.cs: Add new types to lookup: System.TypedReference
19335 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19336 check for TypedReference or ArgIterator, they are not allowed.
19338 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19339 makes us properly catch 1510 in some conditions (see bug 56016 for
19342 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19344 * CryptoConvert.cs: update from corlib version
19347 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19349 * class.cs (Indexer.Define): Check indexername declaration
19351 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19353 * attribute.cs (IsClsCompliant): Fixed problem with handling
19354 all three states (compliant, not-compliant, undetected).
19356 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19358 * attribute.cs (Attribute): Location is now public.
19359 (Resolve): Store resolved arguments (pos_values) in attribute class.
19360 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19361 (GetClsCompliantAttributeValue): New method that gets
19362 CLSCompliantAttribute value.
19363 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19364 if exists else null.
19365 (AttributeTester): New class for CLS-Compliant verification routines.
19367 * class.cs (Emit): Add CLS-Compliant verification.
19368 (Method.GetSignatureForError): Implemented.
19369 (Constructor.GetSignatureForError): Implemented
19370 (Constructor.HasCompliantArgs): Returns if constructor has
19371 CLS-Compliant arguments.
19372 (Constructor.Emit): Override.
19373 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19374 is needed to test only parameters.
19375 (FieldBase.GetSignatureForError): Implemented.
19376 (TypeContainer): New member for storing base interfaces.
19377 (TypeContainer.FindMembers): Search in base interfaces too.
19379 * codegen.cs (GetClsComplianceAttribute): New method that gets
19380 assembly or module CLSCompliantAttribute value.
19381 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19383 (ModuleClass.Emit): Add error 3012 test.
19385 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19387 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19388 state for all decl types.
19389 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19390 if CLS-Compliant tests are required.
19391 (IsClsCompliaceRequired): New method. Analyze whether code
19392 must be CLS-Compliant.
19393 (IsExposedFromAssembly): New method. Returns true when MemberCore
19394 is exposed from assembly.
19395 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19396 value or gets cached value.
19397 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19398 is explicitly marked with CLSCompliantAttribute.
19399 (IsIdentifierClsCompliant): New abstract method. This method is
19400 used to testing error 3005.
19401 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19402 for identifier and parameters CLS-Compliant testing.
19403 (VerifyClsCompliance): New method. The main virtual method for
19404 CLS-Compliant verifications.
19405 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19406 null. I don't know why is null (too many public members !).
19407 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19408 and get value of first CLSCompliantAttribute that found.
19410 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19411 (VerifyClsCompliance): Override and add extra tests.
19413 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19414 clscheck- disable CLS-Compliant verification event if assembly is has
19415 CLSCompliantAttribute(true).
19417 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19418 ApllyAttribute is now called in emit section as in the other cases.
19419 Possible future Emit integration.
19420 (IsIdentifierClsCompliant): New override.
19421 (VerifyClsCompliance): New override.
19422 (GetEnumeratorName): Returns full enum name.
19424 * parameter.cs (GetSignatureForError): Implemented.
19426 * report.cs (WarningData): New struct for Warning message information.
19427 (LocationOfPreviousError): New method.
19428 (Warning): New method. Reports warning based on the warning table.
19429 (Error_T): New method. Reports error based on the error table.
19431 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19432 verifications are done here.
19434 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19436 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19437 CLSCompliantAttribute.
19438 (all_imported_types): New member holds all imported types from other
19440 (LoadAllImportedTypes): New method fills static table with exported types
19441 from all referenced assemblies.
19442 (Modules): New property returns all assembly modules.
19444 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19446 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19447 throwing a parser error.
19449 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19450 which removes the hardcoded get_/set_ prefixes for properties, as
19451 IL allows for the properties to be named something else.
19455 * expression.cs: Do not override operand before we know if it is
19456 non-null. Fix 56207
19458 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19460 * typemanager.cs: support for pinned variables.
19462 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19464 * decl.cs, typemanager.cs: Avoid using an arraylist
19465 as a buffer if there is only one result set.
19467 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19469 * expression.cs: Make sure you cant call a static method
19470 with an instance expression, bug #56174.
19472 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19474 * class.cs (IsDuplicateImplementation): Improve error reporting to
19475 flag 663 (method only differs in parameter modifier).
19477 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19478 in preprocessor directives.
19480 * location.cs (LookupFile): Allow for the empty path.
19482 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19483 better approach for some of that patch, but its failing with the
19484 CharSet enumeration. For now try/catch will do.
19486 * typemanager.cs: Do not crash if a struct does not have fields.
19489 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19491 * expression.cs: cs0213, cant fix a fixed expression.
19494 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19496 * cs-parser.jay: detect invalid embeded statements gracefully.
19499 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19501 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19504 the invocation type may not be a subclass of the tye of the item/
19505 The type of the item must be a subclass of the invocation item.
19510 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19512 * attribute.cs: Added methods to get a string and a bool from an
19513 attribute. Required to information from AssemblyKeyFileAttribute,
19514 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19515 * codegen.cs: Modified AssemblyName creation to include support for
19516 strongnames. Catch additional exceptions to report them as CS1548.
19517 * compiler.csproj: Updated include CryptoConvert.cs.
19518 * compiler.csproj.user: Removed file - user specific configuration.
19519 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19520 Mono.Security assembly. The original class is maintained and tested in
19521 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19522 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19523 like CSC 8.0 (C# v2) supports.
19524 * Makefile: Added CryptoConvert.cs to mcs sources.
19525 * rootcontext.cs: Added new options for strongnames.
19527 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19529 * driver.cs: For --expect-error, report error code `2'
19530 if the program compiled with no errors, error code `1' if
19531 it compiled with an error other than the one expected.
19533 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19535 * compiler.csproj: Updated for Visual Studio .NET 2003.
19536 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19537 * compiler.sln: Updated for Visual Studio .NET 2003.
19539 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19541 * expression.cs: Fix bug #47234. We basically need to apply the
19542 rule that we prefer the conversion of null to a reference type
19543 when faced with a conversion to 'object' (csc behaviour).
19545 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19547 * statement.cs: Shorter form for foreach, eliminates
19548 a local variable. r=Martin.
19550 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19552 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19553 checks if we can use brtrue/brfalse to test for 0.
19554 * expression.cs: use the above in the test for using brtrue/brfalse.
19555 cleanup code a bit.
19557 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19559 * expression.cs: Rewrite string concat stuff. Benefits:
19561 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19562 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19563 rather than a concat chain.
19565 * typemanager.cs: Add lookups for more concat overloads.
19567 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19569 * expression.cs: Emit shorter il code for array init.
19586 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19588 * statement.cs: Before, two switch blocks would be merged if the
19589 total size of the blocks (end_item - begin_item + 1) was less than
19590 two times the combined sizes of the blocks.
19592 Now, it will only merge if after the merge at least half of the
19597 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19599 * class.cs : csc build fix for GetMethods(). See bug #52503.
19601 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19603 * expression.cs: Make sure fp comparisons work with NaN.
19604 This fixes bug #54303. Mig approved this patch a long
19605 time ago, but we were not able to test b/c the runtime
19608 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19610 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19612 2004-03-19 Martin Baulig <martin@ximian.com>
19614 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19615 error here and not in our caller.
19617 2004-03-19 Martin Baulig <martin@ximian.com>
19619 * interface.cs: Completely killed this file.
19620 (Interface): We're now a TypeContainer and live in class.cs.
19622 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19623 argument; we're now also called for interfaces.
19624 (TypeContainer.DefineMembers): Allow this method being called
19626 (TypeContainer.GetMethods): New public method; formerly known as
19627 Interface.GetMethod(). This is used by PendingImplementation.
19628 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19629 it's now private and non-static.
19630 (Interface): Moved this here; it's now implemented similar to
19632 (Method, Property, Event, Indexer): Added `bool is_interface'
19633 argument to their .ctor's.
19634 (MemberBase.IsInterface): New public field.
19636 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19637 instances instead of InterfaceMethod, InterfaceProperty, etc.
19638 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19639 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19641 2004-03-19 Martin Baulig <martin@ximian.com>
19643 * class.cs (MethodCore.IsDuplicateImplementation): New private
19644 method which does the CS0111 checking.
19645 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19646 Use IsDuplicateImplementation().
19648 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19650 * decl.cs (FindMemberToOverride): New method to find the correct
19651 method or property to override in the base class.
19653 - Make Method/Property use the above method to find the
19654 version in the base class.
19655 - Remove the InheritableMemberSignatureCompare as it is now
19658 This patch makes large code bases much faster to compile, as it is
19659 O(n) rather than O(n^2) to do this validation.
19661 Also, it fixes bug 52458 which is that nested classes are not
19662 taken into account when finding the base class member.
19664 Reviewed/Approved by Martin.
19666 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19668 * interface.cs: In all interface classes removed redundant
19669 member initialization.
19671 2004-03-16 Martin Baulig <martin@ximian.com>
19673 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19675 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19677 * decl.cs (DefineTypeAndParents): New helper method to define a
19678 type's containers before the type itself is defined; This is a
19679 bug exposed by the recent changes to Windows.Forms when an
19680 implemented interface was defined inside a class that had not been
19683 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19685 (Check): Loop correctly to report errors modifiers
19686 (UNSAFE was not in the loop, since it was the same as TOP).
19688 * interface.cs: Every interface member now takes a ModFlags,
19689 instead of a "is_new" bool, which we set on the base MemberCore.
19691 Every place where we called "UnsafeOk" in the interface, now we
19692 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19693 the unsafe settings from the member declaration instead of the
19694 container interface.
19696 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19698 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19699 `set_indexer_name' to the pending bits (one per type).
19701 We fixed a bug today that was picking the wrong method to
19702 override, since for properties the existing InterfaceMethod code
19703 basically ignored the method name. Now we make sure that the
19704 method name is one of the valid indexer names.
19706 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19708 * support.cs (SeekableStreamReader): Keep track of stream byte
19709 positions and don't mix them with character offsets to the buffer.
19711 Patch from Gustavo Giráldez
19713 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19715 * interface.cs (InterfaceSetGetBase): Removed double member
19716 initialization, base class does it as well.
19718 2004-03-13 Martin Baulig <martin@ximian.com>
19720 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19721 when compiling corlib.
19723 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19725 * convert.cs (ExplicitConversion): We were reporting an error on
19726 certain conversions (object_type source to a value type, when the
19727 expression was `null') before we had a chance to pass it through
19728 the user defined conversions.
19730 * driver.cs: Replace / and \ in resource specifications to dots.
19733 * class.cs: Add check for duplicate operators. Fixes 52477
19735 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19737 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19738 that are in the middle of the statements, not only at the end.
19741 * class.cs (TypeContainer.AddField): No longer set the
19742 `HaveStaticConstructor' flag, now we call it
19743 `UserDefineStaticConstructor' to diferentiate the slightly
19744 semantic difference.
19746 The situation is that we were not adding BeforeFieldInit (from
19747 Modifiers.TypeAttr) to classes that could have it.
19748 BeforeFieldInit should be set to classes that have no static
19753 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19755 And most importantly Zoltan's comment:
19757 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19759 "I think beforefieldinit means 'it's ok to initialize the type sometime
19760 before its static fields are used', i.e. initialization does not need
19761 to be triggered by the first access to the type. Setting this flag
19762 helps the JIT to compile better code, since it can run the static
19763 constructor at JIT time, and does not need to generate code to call it
19764 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19765 this flag for lots of classes like String.
19767 csc sets this flag if the type does not have an explicit static
19768 constructor. The reasoning seems to be that if there are only static
19769 initalizers for a type, and no static constructor, then the programmer
19770 does not care when this initialization happens, so beforefieldinit
19773 This bug prevents the AOT compiler from being usable, since it
19774 generates so many calls to mono_runtime_class_init that the AOT code
19775 is much slower than the JITted code. The JITted code is faster,
19776 because it does not generate these calls if the vtable is type is
19777 already initialized, which is true in the majority of cases. But the
19778 AOT compiler can't do this."
19780 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19782 * class.cs (MethodData.Emit): Refactor the code so symbolic
19783 information is generated for destructors; For some reasons we
19784 were taking a code path that did not generate symbolic information
19787 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19789 * class.cs: Create a Constructor.CheckBase method that
19790 takes care of all validation type code. The method
19791 contains some code that was moved from Define.
19793 It also includes new code that checks for duplicate ctors.
19794 This fixes bug #55148.
19796 2004-03-09 Joshua Tauberer <tauberer@for.net>
19798 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19799 a { ... }-style array creation invokes EmitStaticInitializers
19800 which is not good for reference-type arrays. String, decimal
19801 and now null constants (NullCast) are not counted toward
19802 static initializers.
19804 2004-03-05 Martin Baulig <martin@ximian.com>
19806 * location.cs (SourceFile.HasLineDirective): New public field;
19807 specifies whether the file contains or is referenced by a "#line"
19809 (Location.DefineSymbolDocuments): Ignore source files which
19810 either contain or are referenced by a "#line" directive.
19812 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19814 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19815 direct access to our parent, so check the method inline there.
19817 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19819 * expression.cs (Invocation.EmitCall): Miguel's last commit
19820 caused a regression. If you had:
19825 In Foo the implict this would be null.
19827 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19829 * expression.cs (Invocation.EmitCall): If the method is not
19830 virtual, do not emit a CallVirt to it, use Call.
19832 * typemanager.cs (GetFullNameSignature): Improve the method to
19833 cope with ".ctor" and replace it with the type name.
19835 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19836 as an argument the ConstructorBuilder where it is being defined,
19837 to catch the recursive constructor invocations.
19839 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19841 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19842 routines to check if a type is an enumerable/enumerator allow
19843 classes that implement the IEnumerable or IEnumerator interfaces.
19845 * class.cs (Property, Operator): Implement IIteratorContainer, and
19846 implement SetYields.
19848 (Property.Define): Do the block swapping for get_methods in the
19849 context of iterators. We need to check if Properties also
19850 include indexers or not.
19852 (Operator): Assign the Block before invoking the
19853 OperatorMethod.Define, so we can trigger the Iterator code
19856 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19857 Property and Operator classes are not created when we parse the
19858 declarator but until we have the block completed, so we use a
19859 singleton SimpleIteratorContainer.Simple to flag whether the
19860 SetYields has been invoked.
19862 We propagate this setting then to the Property or the Operator to
19863 allow the `yield' to function.
19865 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19867 * codegen.cs: Implemented attribute support for modules.
19868 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19869 Assembly/Module functionality.
19871 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19872 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19873 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19875 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19877 * interface.cs (FindMembers): The operation is performed on all base
19878 interfaces and not only on the first. It is required for future CLS Compliance patch.
19880 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19882 * statement.cs, codegen.cs:
19883 This patch deals with patterns such as:
19885 public class List : IEnumerable {
19887 public MyEnumerator GetEnumerator () {
19888 return new MyEnumerator(this);
19891 IEnumerator IEnumerable.GetEnumerator () {
19895 public struct MyEnumerator : IEnumerator {
19900 Before, there were a few things we did wrong:
19901 1) we would emit callvirt on a struct, which is illegal
19902 2) we emited ldarg when we needed to emit ldarga
19903 3) we would mistakenly call the interface methods on an enumerator
19904 type that derived from IEnumerator and was in another assembly. For example:
19906 public class MyEnumerator : IEnumerator
19908 Would have the interface methods called, even if there were public impls of the
19909 method. In a struct, this lead to invalid IL code.
19911 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19913 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19916 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19918 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19920 * cs-parser.jay: Fix small regression: we were not testing V2
19921 compiler features correctly.
19923 * interface.cs: If the emit context is null, then create one
19925 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19927 * decl.cs (GetSignatureForError): New virtual method to get full name
19928 for error messages.
19930 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19931 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19933 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19934 Duplicated members and code in these classes has been removed.
19935 Better encapsulation in these classes.
19937 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19939 * assign.cs (Assign.DoResolve): When dealing with compound
19940 assignments, there is a new rule in ECMA C# 2.4 (might have been
19941 there before, but it is documented here) that states that in:
19945 If b is of type int, and the `op' is a shift-operator, then the
19946 above is evaluated as:
19950 * expression.cs (Binary.ResolveOperator): Instead of testing for
19951 int/uint/long/ulong, try to implicitly convert to any of those
19952 types and use that in pointer arithmetic.
19954 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19955 method to print information for from the type, not from the
19956 null-method we were given.
19958 2004-02-01 Duncan Mak <duncan@ximian.com>
19960 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19961 parsing for cmd, fixes bug #53694.
19963 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19965 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19966 in the member name duplication tests. Property and operator name duplication
19967 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19969 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19971 * interface.cs (PopulateMethod): Fixed crash when interface method
19972 returns not existing type (error test cs0246-3.cs).
19974 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19976 * cs-parser.jay (interface_accessors): Re-write actions to also
19977 store attributes attached to get and set methods. Fix spelling
19980 (inteface_property_declaration): Modify accordingly.
19982 (InterfaceAccessorInfo): New helper class to store information to pass
19983 around between rules that use interface_accessors.
19985 * interface.cs (Emit): Apply attributes on the get and set
19986 accessors of properties and indexers too.
19988 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19989 right MethodBuilder when applying attributes to the get and set accessors.
19991 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19993 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19995 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19997 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19999 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20001 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20002 changes that treat `yield' specially when present before `break'
20003 or `return' tokens.
20005 * cs-tokenizer.cs: yield is no longer a keyword.
20007 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20009 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20010 setting for default constructors.
20011 For default constructors are almost every time set wrong Modifier. The
20012 generated IL code has been alright. But inside mcs this values was
20013 wrong and this was reason why several of my CLS Compliance tests
20016 2004-01-22 Martin Baulig <martin@ximian.com>
20018 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20019 not a QualifiedIdentifier. This is what `type_name_expression'
20020 was previously doing.
20021 (type_name_expression): Removed; the code is now in
20022 `namespace_or_type_name'.
20023 (qualified_identifier): Removed, use `namespace_or_type_name'
20025 (QualifiedIdentifier): Removed this class.
20027 2004-01-22 Martin Baulig <martin@ximian.com>
20029 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20030 not a string as alias name.
20032 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20034 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20035 #52730 bug, and instead compute correctly the need to use a
20036 temporary variable when requesting an address based on the
20037 static/instace modified of the field and the constructor.
20039 2004-01-21 Martin Baulig <martin@ximian.com>
20041 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20042 class and namespace before looking up aliases. Fixes #52517.
20044 2004-01-21 Martin Baulig <martin@ximian.com>
20046 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20047 assinged in a 'try'; fixes exception4.cs.
20049 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20050 * class.cs : Implemented parameter-less constructor for TypeContainer
20052 * decl.cs: Attributes are now stored here. New property OptAttributes
20054 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20056 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20058 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20060 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20061 (CSharpSignature): New method for indexer and property signature.
20063 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20065 * pending.cs (IsVirtualFilter): Faster implementation.
20067 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20069 * typemanager.cs: Avoid inclusion of same assembly more than once.
20071 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20073 * cs-parser.jay: Fixed problem where the last assembly attribute
20074 has been applied also to following declaration (class, struct, etc.)
20076 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20078 * class.cs: Added error CS0538, CS0539 reporting.
20079 Fixed crash on Microsoft runtime when field type is void.
20081 * cs-parser.jay: Added error CS0537 reporting.
20083 * pending.cs: Added error CS0535 reporting.
20084 Improved error report for errors CS0536, CS0534.
20086 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20088 Merge a few bits from the Anonymous Method MCS tree.
20090 * statement.cs (ToplevelBlock): New class for toplevel methods,
20091 will hold anonymous methods, lifted variables.
20093 * cs-parser.jay: Create toplevel blocks for delegates and for
20094 regular blocks of code.
20096 2004-01-20 Martin Baulig <martin@ximian.com>
20098 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20099 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20100 and `NeedExplicitReturn'; added `IsLastStatement'.
20101 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20102 have a `ReturnLabel' or we're not unreachable.
20104 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20105 child's reachability; don't just override ours with it. Fixes
20106 #58058 (lluis's example).
20107 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20108 InFinally(), InLoop(), InSwitch() and
20109 BreakCrossesTryCatchBoundary() methods.
20111 * statement.cs (Return): Do all error checking in Resolve().
20112 Unless we are the last statement in a top-level block, always
20113 create a return label and jump to it.
20114 (Break, Continue): Do all error checking in Resolve(); also make
20115 sure we aren't leaving a `finally'.
20116 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20117 statement in a top-level block.
20118 (Block.Flags): Added `IsDestructor'.
20119 (Block.IsDestructor): New public property.
20121 2004-01-20 Martin Baulig <martin@ximian.com>
20123 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20125 2004-01-20 Martin Baulig <martin@ximian.com>
20127 * statement.cs (Statement.ResolveUnreachable): New public method.
20128 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20129 (Block.Resolve): Resolve unreachable statements.
20131 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20133 * expression.cs: We need to fix the case where we do
20134 not have a temp variable here.
20136 * assign.cs: Only expression compound assignments need
20137 temporary variables.
20139 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20141 * flowanalysis.cs: Reduce memory allocation in a few ways:
20142 - A block with no variables should not allocate a bit
20144 - A method with no out parameters does not need any tracking
20145 for assignment of the parameters, so we need not allocate
20148 public readonly Type[] VariableTypes;
20149 public readonly string[] VariableNames;
20150 Are redundant. The data is already stored in the variable
20151 map, so we need not allocate another array for it.
20152 - We need to add alot of checks for if (params | locals) == null
20153 due to the first two changes.
20155 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20157 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20158 implement IMemoryLocation, we store a copy on a local variable and
20159 take the address of it. Patch from Benjamin Jemlich
20161 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20162 to use a special "type_name_expression" rule which reduces the
20163 number of "QualifiedIdentifier" classes created, and instead
20164 directly creates MemberAccess expressions.
20166 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20168 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20169 that fixes #52853. Null literal assignment to ValueType
20171 * class.cs (MethodData.Emit): Instead of checking the name of the
20172 method to determine if its a destructor, create a new derived
20173 class from Method called Destructor, and test for that.
20175 * cs-parser.jay: Create a Destructor object instead of a Method.
20177 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20181 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20183 * expression.cs (Binary.ResolveOperator): Perform an implicit
20184 conversion from MethodGroups to their delegate types on the
20185 Addition operation.
20187 * delegate.cs: Introduce a new class DelegateCreation that is the
20188 base class for `NewDelegate' and `ImplicitDelegateCreation',
20189 factor some code in here.
20191 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20192 conversion from MethodGroups to compatible delegate types.
20194 * ecore.cs (Expression.Resolve): Do not flag error 654
20195 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20196 we allow conversions from MethodGroups to delegate types now.
20198 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20199 assignments in v2 either.
20201 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20203 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20204 static read-only fields in ctors.
20206 Applied patch from Benjamin Jemlich
20208 * expression.cs (UnaryMutator): Avoid leaking local variables.
20210 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20212 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20213 here to return true, as they can be used like this:
20215 (XXX) int.MEMBER ()
20217 Fixed 49836 and all the other dups
20219 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20221 * driver.cs: Implement /win32res and /win32icon.
20223 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20225 * cs-parser.jay: Add a rule to improve error handling for the
20226 common mistake of placing modifiers after the type.
20228 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20230 * cs-parser.jay (interface_event_declaration): Catch
20231 initialization of events on interfaces, and report cs0068
20233 * cs-parser.jay (interface_event_declaration): Catch
20234 initialization of events.
20236 * ecore.cs: Better report missing constructors.
20238 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20239 the error reporting done in the wrong place. Fix.
20241 * expression.cs (Binary.ResolveOperator): Catch the
20242 operator + (E x, E y) error earlier, and later allow for implicit
20243 conversions in operator +/- (E e, U x) from U to the underlying
20246 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20247 52596, if the container class is abstract, the default constructor
20248 is protected otherwise its public (before, we were always public).
20250 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20253 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20254 Jemlich that fixes bug #52597, MCS was generating invalid code for
20255 idisposable structs. Thanks to Ben for following up with this
20258 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20260 * driver.cs: Allow assemblies without code to be generated, fixes
20263 2004-01-07 Nick Drochak <ndrochak@gol.com>
20265 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20267 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20269 * cs-parser.jay: Add rules to improve error reporting if fields or
20270 methods are declared at the namespace level (error 116)
20272 * Add rules to catch event add/remove
20274 2004-01-04 David Sheldon <dave-mono@earth.li>
20276 * expression.cs: Added matching ")" to error message for
20279 2004-01-03 Todd Berman <tberman@gentoo.org>
20281 * ecore.cs, attribute.cs:
20282 Applying fix from #52429.
20284 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20286 * ecore.cs, expression.cs, statement.cs:
20287 Total rewrite of how we handle branching. We
20288 now handle complex boolean expressions with fewer
20289 jumps. As well if (x == 0) no longer emits a ceq.
20291 if (x is Foo) is much faster now, because we generate
20294 Overall, we get a pretty big improvement on our benchmark
20295 tests. The code we generate is smaller and more readable.
20297 I did a full two-stage bootstrap. The patch was reviewed
20298 by Martin and Miguel.
20300 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20302 * cs-parser.jay: Make primary_expression not take a QI.
20303 we dont need this because the member_access rule covers
20304 us here. So we replace the rule with just IDENTIFIER.
20306 This has two good effects. First, we remove a s/r conflict.
20307 Second, we allocate many fewer QualifiedIdentifier objects.
20309 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20311 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20312 set the correct information via SRE. This prevents
20313 hanging on the MS runtime. Fixes #29374.
20315 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20317 * convert.cs: correctly handle conversions to value types
20318 from Enum and ValueType as unboxing conversions.
20320 Fixes bug #52569. Patch by Benjamin Jemlich.
20322 2004-01-02 Ravi Pratap <ravi@ximian.com>
20324 * expression.cs (BetterConversion): Prefer int -> uint
20325 over int -> ulong (csc's behaviour). This fixed bug #52046.
20327 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20329 * decl.cs (MemberCache.FindMembers): now returns a
20332 * typemanager.cs: In general, go with with ^^.
20333 (CopyNewMethods): take an IList.
20334 (RealMemberLookup): Only allocate an arraylist
20335 if we copy from two sets of methods.
20337 This change basically does two things:
20338 1) Fewer array lists allocated due to CopyNewMethods.
20339 2) the explicit cast in MemberList costed ALOT.
20341 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20343 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20344 a hashtable to avoid needless string allocations when an identifier is
20345 used more than once (the common case).
20347 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20349 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20350 is broken, it will not return anything. So, we
20351 have to use the information we have in mcs to
20354 * typemanager.cs: Add a cache for GetInterfaces,
20355 since this will now be used more often (due to ^^)
20357 (GetExplicitInterfaces) New method that gets the
20358 declared, not effective, interfaces on a type
20359 builder (eg, if you have interface IFoo, interface
20360 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20363 This patch makes MCS able to bootstrap itself on
20366 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20368 * expression.cs: Remove the Nop's that Miguel put
20371 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20373 * report.cs, codegen.cs: Give the real stack trace to
20374 the error when an exception is thrown.
20376 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20378 * decl.cs: only allocate hashtables for ifaces if
20381 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20383 * expression.cs: fix the error from cs0121-2.cs
20384 (a parent interface has two child interfaces that
20385 have a function with the same name and 0 params
20386 and the function is called through the parent).
20388 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20390 * class.cs, rootcontext.cs, typmanager.cs: do not
20393 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20395 * codegen.cs: remove stack for the ec flow branching.
20396 It is already a linked list, so no need.
20398 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20400 * Makefile: Allow custom profiler here.
20402 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20404 * typemanager.cs (LookupType):
20405 - Use a static char [], because split takes
20406 a param array for args, so it was allocating
20408 - Do not store true in a hashtable, it boxes.
20410 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20412 * flowanalysis.cs: bytify common enums.
20414 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20416 * modifiers.cs: Add a new set of flags for the
20417 flags allowed on explicit interface impls.
20418 * cs-parser.jay: catch the use of modifiers in
20419 interfaces correctly.
20420 * class.cs: catch private void IFoo.Blah ().
20422 All related to bug #50572.
20424 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20426 * decl.cs: Rewrite the consistant accessability checking.
20427 Accessability is not linear, it must be implemented in
20428 a tableish way. Fixes #49704.
20430 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20432 * expression.cs: Handle negation in a checked context.
20433 We must use subtraction from zero. Fixes #38674.
20435 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20437 * class.cs: Ignore static void main in DLLs.
20438 * rootcontext.cs: Handle the target type here,
20439 since we are have to access it from class.cs
20440 * driver.cs: account for the above.
20442 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20444 * report.cs: Give line numbers and files if available.
20446 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20448 * driver.cs: Implement /addmodule.
20450 * typemanager.cs: Change 'modules' field so it now contains Modules not
20453 2003-12-20 Martin Baulig <martin@ximian.com>
20455 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20456 (FieldBase.IsAssigned): Removed this field.
20457 (FieldBase.SetAssigned): New public method.
20458 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20460 2003-12-20 Martin Baulig <martin@ximian.com>
20462 * expression.cs (LocalVariableReference.DoResolve): Don't set
20463 `vi.Used' if we're called from DoResolveLValue().
20465 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20466 returns the usage vector it just merged into the current one -
20467 pass this one to UsageWarning().
20468 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20469 of the `EmitContext', don't call this recursively on our children.
20471 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20473 * driver.cs: Implement /target:module.
20475 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20477 * support.cs (CharArrayHashtable): New helper class.
20479 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20480 char arrays, not strings, so we can avoid creating a string in
20481 consume_identifier if the identifier is a keyword.
20483 2003-12-16 Martin Baulig <martin@ximian.com>
20485 * statement.cs (LocalInfo.Assigned): Removed this property.
20486 (LocalInfo.Flags): Removed `Assigned'.
20487 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20488 and uses flow analysis.
20489 (Block.UsageWarning): Made this method private.
20490 (Block.Resolve): Call UsageWarning() if appropriate.
20492 * expression.cs (LocalVariableReference.DoResolve): Always set
20493 LocalInfo.Used here.
20495 2003-12-13 Martin Baulig <martin@ximian.com>
20497 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20498 any value here; we're now using flow analysis to figure out
20499 whether a statement/block returns a value.
20501 2003-12-13 Martin Baulig <martin@ximian.com>
20503 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20505 (FlowBranching.MergeFinally): Don't call
20506 `branching.CheckOutParameters()' here, this is called in
20508 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20509 when adding the `finally' vector.
20511 2003-12-13 Martin Baulig <martin@ximian.com>
20514 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20515 actually work and also fix #48962.
20517 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20519 * decl.cs: Do not check System.Object for nested types,
20520 since we know it does not have any. Big bang for buck:
20523 Run 1: 8.35 seconds
20524 Run 2: 8.32 seconds
20525 corlib: 17.99 seconds
20527 Run 1: 8.17 seconds
20528 Run 2: 8.17 seconds
20529 corlib: 17.39 seconds
20531 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20533 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20534 time we are returning 0 members, so we save alot here.
20536 2003-12-11 Martin Baulig <martin@ximian.com>
20538 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20539 `MergeChild()', also just take the `FlowBranching' as argument;
20540 call Merge() on it and return the result.
20541 (FlowBranching.Merge): We don't need to do anything if we just
20544 2003-12-11 Martin Baulig <martin@ximian.com>
20546 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20547 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20548 Maurer for this idea.
20550 2003-12-11 Martin Baulig <martin@ximian.com>
20552 * flowanalysis.cs (MergeResult): This class is now gone; we now
20553 use the `UsageVector' for this. The reason for this is that if a
20554 branching just has one sibling, we don't need to "merge" them at
20555 all - that's the next step to do.
20556 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20559 2003-12-11 Martin Baulig <martin@ximian.com>
20561 Reworked flow analyis and made it more precise and bug-free. The
20562 most important change is that we're now using a special `Reachability'
20563 class instead of having "magic" meanings of `FlowReturns'. I'll
20564 do some more cleanups and optimizations and also add some more
20565 documentation this week.
20567 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20568 largely reworked this class.
20569 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20570 the new `Reachability' class instead of having "magic" values here.
20571 (FlowBranching): We're now using an instance of `Reachability'
20572 instead of having separate `Returns', `Breaks' etc. fields.
20574 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20575 based on flow analysis; ignore the return value of block.Emit ().
20577 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20579 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20580 if they are private.
20582 2003-12-09 Martin Baulig <martin@ximian.com>
20584 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20585 call them directly on the UsageVector.
20587 2003-12-09 Martin Baulig <martin@ximian.com>
20589 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20590 Changed return type from `FlowReturns' to `Reachability'.
20592 2003-12-09 Martin Baulig <martin@ximian.com>
20594 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20595 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20596 `Reachable' fields with a single `Reachability' one.
20598 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20600 * class.cs (FindMembers): Remove foreach's.
20605 Run 1: 8.74 seconds
20606 Run 2: 8.71 seconds
20609 Run 1: 8.64 seconds
20610 Run 2: 8.58 seconds
20613 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20618 This patch does a few things:
20619 1. EmptyStatement is now a singleton, so it is never reallocated.
20620 2. All blah is EmptyStatement constructs have been changed to
20621 blah == EmptyStatement.Value, which is much faster and valid
20622 now that EmptyStatement is a singleton.
20623 3. When resolving a block, rather than allocating a new array for
20624 the non-empty statements, empty statements are replaced with
20625 EmptyStatement.Value
20626 4. Some recursive functions have been made non-recursive.
20627 Mainly the performance impact is from (3), however (1) and (2) are needed for
20628 this to work. (4) does not make a big difference in normal situations, however
20629 it makes the profile look saner.
20634 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20635 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20636 Total memory allocated: 56397 KB
20639 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20640 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20641 Total memory allocated: 55666 KB
20643 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20645 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20646 than the hashtable in a hashtable version
20648 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20649 we always end up concating a string. This results in a huge perf
20650 loss, because many strings have to be tracked by the GC. In this
20651 patch, we first use a hashtable that works with two keys, so that
20652 the strings do not need to be concat'ed.
20656 Run 1: 8.74 seconds
20657 Run 2: 8.71 seconds
20660 Run 1: 8.65 seconds
20661 Run 2: 8.56 seconds
20663 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20665 * Makefile: Add a new target `do-time' that does a quick and simple
20666 profile, leaving easy to parse output.
20668 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20670 * codegen.cs (Init): Create the dynamic assembly with
20671 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20673 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20675 * support.cs: Make the PtrHashtable use only one
20676 instance of its comparer.
20678 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20680 * typemanager.cs: Fix lookup of GetNamespaces.
20682 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20684 * expression.cs: Removed redundant line.
20686 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20687 ArrayLists, use for loops with bounds.
20689 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20692 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20693 arraylists, use for loop with bounds.
20695 The above three changes give us a 0.071 second performance
20696 improvement out of 3.294 seconds down to 3.223. On my machine
20697 the above changes reduced the memory usage by 1,387 KB during
20698 compiler bootstrap.
20700 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20701 QualifiedIdentifiers. Before we created a new string through
20702 concatenation, and mostly later on, the result would be
20703 manipulated by DecomposeQI through string manipulation.
20705 This reduced the compiler memory usage for bootstrapping from
20706 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20707 compile times in 0.05 seconds.
20709 2003-11-28 Dick Porter <dick@ximian.com>
20711 * support.cs: Do string compares with the Invariant culture.
20719 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20720 the comparison is done with the Invariant culture.
20722 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20724 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20725 GetEnumerator method.
20727 (ProbeCollectionType): Iterate starting at the most specific type
20728 upwards looking for a GetEnumerator
20730 * expression.cs: Shift count can be up to 31 for int/uint and 63
20733 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20735 * statement.cs (Block.LookupLabel): Also look for the label on the
20736 children blocks. Use a hash table to keep track of visited
20739 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20740 we actually did transform the other operand, otherwise fall back
20741 to the common codepath that casts to long.
20743 * cs-tokenizer.cs: Use the same code pattern as the int case.
20744 Maybe I should do the parsing myself, and avoid depending on the
20745 Parse routines to get this done.
20747 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20749 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20750 which fixes bug 51347. This time test it.
20752 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20753 attributes for example can not tell the difference between these.
20754 The difference was only a syntax feature of the language.
20756 * attribute.cs: Apply attributes to delegates.
20758 * delegate.cs: Call the apply attributes method.
20760 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20762 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20763 comparing 0 vs Byte.MinValue, not the value
20765 (ImplicitConversionRequired): When reporting a conversion error,
20766 use error 31 to print out the constant error instead of the
20769 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20770 which fixes bug 51347.
20772 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20774 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20775 which fixes the -warnaserror command line option.
20777 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20779 * cfold.cs (DoNumericPromotions): During constant folding of
20780 additions on UIntConstant, special case intconstants with
20781 IntConstants like we do on the expression binary operator.
20783 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20785 * convert.cs (ImplicitReferenceConversion): We were missing a case
20786 (System.Enum are not value types or class types, so we need to
20787 classify them separatedly).
20789 * driver.cs: We do not support error 2007.
20791 2003-11-12 Jackson Harper <jackson@ximian.com>
20793 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20794 system directory. Also use the full file name so users can
20795 libraries names mscorlib-o-tron.dll in a non system dir.
20797 2003-11-10 Martin Baulig <martin@ximian.com>
20799 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20800 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20801 calling `ResolveType()' on them, directly assign their `Type'.
20803 2003-11-08 Martin Baulig <martin@ximian.com>
20805 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20806 return value and the `out parent' parameter.
20807 (TypeContainer.DefineType): Moved the CS0644 check into
20808 GetClassBases(). Don't pass the interface types to the
20809 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20810 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20812 * ecore.cs (TypeExpr.IsAttribute): New property.
20813 (TypeExpr.GetInterfaces): New method.
20815 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20816 TypeExpr instead of a Type.
20817 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20818 (Interface.DefineType): Don't pass the interface types to the
20819 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20820 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20822 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20823 instead of a `Type[]'.
20824 (TypeManager.RegisterBuilder): Likewise.
20825 (TypeManager.AddUserInterface): Likewise.
20826 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20827 `Type[]' and also return a `TypeExpr[]'.
20828 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20830 2003-11-08 Martin Baulig <martin@ximian.com>
20832 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20835 2003-11-08 Martin Baulig <martin@ximian.com>
20837 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20838 TypeManager.ResolveExpressionTypes().
20840 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20841 instead of an Expression.
20842 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20843 (TypeExpression): New public class; formerly known as `TypeExpr'.
20845 * expression.cs (ComposedCast): Derive from TypeExpr.
20847 * typemanager.cs (TypeManager.system_*_expr): These are now
20848 TypExpr's instead of Expression's.
20849 (TypeManager.ResolveExpressionTypes): New public static function;
20850 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20853 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20855 * expression.cs (New.DoResolve): Do not dereference value that
20856 might be a null return.
20858 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20859 sure that the constant value has the right type. Fixes an
20860 unreported bug, similar to 50425.
20862 * const.cs (Const.LookupConstantValue): Call
20863 ImplicitStandardConversionExists before doing a conversion to
20864 avoid havng the TypeManager.ChangeType do conversions.
20866 Reduced the number of casts used
20868 (Const.ChangeType): New routine to enable reuse of the constant
20869 type changing code from statement.
20871 * typemanager.cs (ChangeType): Move common initialization to
20872 static global variables.
20876 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20877 every value type to go through, even if it was void. Fix that.
20879 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20880 character of the define, and the is_identifier_part_character for
20881 the rest of the string.
20883 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20885 * expression.cs (UnaryMutator.EmitCode): When I updated
20886 LocalVariableReference.DoResolve, I overdid it, and dropped an
20887 optimization done on local variable references.
20889 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20891 * ecore.cs: Convert the return from Ldlen into an int.
20893 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20895 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20896 the accessibility, this is a special case for toplevel non-public
20897 classes (internal for instance).
20899 2003-10-20 Nick Drochak <ndrochak@gol.com>
20901 * ecore.cs: Fix typo and build. Needed another right paren.
20903 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20905 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20906 `internal' case regular and protected, but not allowing protected
20907 to be evaluated later. Bug 49840
20909 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20911 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20912 to kb.Nlast, and not the kb.nFirst to isolate the switch
20915 Extract the underlying type, so enumerations of long/ulong are
20916 treated like long/ulong.
20918 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20920 * expression.cs (New): Overload the meaning of RequestedType to
20921 track the possible creation of the NewDelegate type, since
20922 DoResolve is invoked more than once for new constructors on field
20925 See bugs: #48800 and #37014
20927 * cs-parser.jay (declare_local_constants): Take an arraylist
20928 instead of a single constant.
20930 (local_constant_declaration): It should take a
20931 constant_declarators, not a constant_declarator. Fixes 49487
20933 * convert.cs: Fix error report.
20935 2003-10-13 Jackson Harper <jackson@ximian.com>
20937 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20940 2003-10-09 Martin Baulig <martin@ximian.com>
20942 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20944 (MethodCore.DoDefineParameters): Removed the TypeContainer
20945 argument; use the DeclSpace which was passed to the .ctor instead.
20946 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20947 TypeContainer; we only need a DeclSpace here.
20949 2003-10-09 Martin Baulig <martin@ximian.com>
20951 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20953 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20954 EmitContext's .ctor.
20956 2003-10-09 Martin Baulig <martin@ximian.com>
20958 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20959 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20960 AsAccessible(), moved them as well.
20962 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20964 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20966 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20968 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20970 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20971 generation for >=, as spotted by Paolo, bug 48679.
20972 Patch from David Waite.
20974 * cs-tokenizer.cs: Add handling for #pragma.
20976 * cs-parser.jay: Allow for both yield and yield return in the
20977 syntax. The anti-cobolization of C# fight will go on!
20979 * class.cs (TypeBuilder.DefineType): Catch error condition here
20980 (Parent.DefineType erroring out and returning null).
20982 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20983 coping with enumerations variables, we were mistakenly processing
20984 them as a regular value type instead of built-in types. Fixes the
20987 * typemanager.cs (IsBuiltinOrEnum): New method.
20989 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20991 * cs-parser.jay: Upgrade: yield now needs the return clause.
20993 2003-09-19 Martin Baulig <martin@ximian.com>
20995 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20996 `MemberCache parent' argument. Normally, an interface doesn't
20997 have a parent type except System.Object, but we use this in gmcs
20998 for generic type parameters.
21000 2003-09-18 Martin Baulig <martin@ximian.com>
21002 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21003 on `type.IsInterface'; don't check whether the type has a parent
21004 to determine whether it's an interface.
21006 2003-09-15 Martin Baulig <martin@ximian.com>
21008 * class.cs (TypeContainer.DefineType): Added an error flag to
21009 avoid reporting duplicate CS0146's ("class definition is
21012 * driver.cs (Driver.MainDriver): Abort if
21013 RootContext.ResolveTree() reported any errors.
21015 2003-09-07 Martin Baulig <martin@ximian.com>
21017 * report.cs (Error, Warning): Added overloaded versions which take
21018 a `params object[] args' and call String.Format().
21020 2003-09-07 Martin Baulig <martin@ximian.com>
21022 * decl.cs (DeclSpace..ctor): Don't call
21023 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21024 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21025 (DeclSpace.RecordDecl): New method.
21027 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21029 2003-09-02 Ravi Pratap <ravi@ximian.com>
21031 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21032 value attributes to be applied to ParameterBuilders.
21034 * class.cs (MethodCore.LabelParameters): Make static and more
21035 generic so that it can be used from other places - like interface
21036 methods, for instance.
21038 * interface.cs (Interface.Emit): Call LabelParameters before
21039 emitting attributes on the InterfaceMethod.
21041 2003-08-26 Martin Baulig <martin@ximian.com>
21043 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21044 resolving aliases; fixes #47927.
21046 2003-08-26 Martin Baulig <martin@ximian.com>
21048 * statement.cs (Using.DoResolve): This is internally emitting a
21049 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21050 do not always return. Fixes #47681.
21052 2003-08-26 Martin Baulig <martin@ximian.com>
21054 * decl.cs (MemberCore): Moved WarningNotHiding(),
21055 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21057 (AdditionResult): Make this nested in DeclSpace.
21058 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21059 argument; call NamespaceEntry.Define() unless we're nested in a
21062 * namespace.cs (Namespace.DefineName): New public function. This
21063 is called from DeclSpace's .ctor to add
21064 (Namespace.Lookup): Include DeclSpaces in the lookup.
21066 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21068 * const.cs (Const): Derive from MemberBase, not MemberCore.
21070 2003-08-25 Martin Baulig <martin@ximian.com>
21072 * convert.cs (Convert.ExplicitReferenceConversion): When
21073 converting from an interface type to a class, unbox if the target
21074 type is a struct type. Fixes #47822.
21076 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21078 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21081 2003-08-22 Martin Baulig <martin@ximian.com>
21083 * class.cs (TypeManager.DefineType): When defining a nested type,
21084 call DefineType() on our parent; fixes #47801.
21086 2003-08-22 Martin Baulig <martin@ximian.com>
21088 * class.cs (MethodData.Define): While checking if a method is an
21089 interface implementation, improve the test a bit more to fix #47654.
21091 2003-08-22 Martin Baulig <martin@ximian.com>
21093 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21094 correctly; fixes #47722.
21096 2003-08-22 Martin Baulig <martin@ximian.com>
21098 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21099 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21101 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21103 2003-08-22 Martin Baulig <martin@ximian.com>
21105 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21106 can only be assigned in static constructors. Fixes #47161.
21108 2003-08-22 Martin Baulig <martin@ximian.com>
21110 Rewrote and improved the flow analysis code.
21112 * flowbranching.cs (FlowBranching): Make this class abstract.
21113 (FlowBranching.CreateBranching): New static function to create a
21114 new flow branching.
21115 (FlowBranchingBlock, FlowBranchingException): New classes.
21116 (FlowBranching.UsageVector.Type): New public readonly field.
21117 (FlowBranching.UsageVector.Breaks): Removed the setter.
21118 (FlowBranching.UsageVector.Returns): Removed the setter.
21119 (FlowBranching.UsageVector): Added Break(), Return(),
21120 NeverReachable() and Throw() methods to modify the reachability.
21121 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21122 done by FlowBranching.Merge().
21123 (FlowBranching.UsageVector.MergeChild): New method; merges the
21124 merge result into the current vector.
21125 (FlowBranching.Merge): New abstract method to merge a branching.
21127 2003-08-12 Martin Baulig <martin@ximian.com>
21129 * expression.cs (Indirection.CacheTemporaries): Create the
21130 LocalTemporary with the pointer type, not its element type.
21132 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21134 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21135 token was a keyword or not.
21137 Add `error' options where an IDENTIFIER was expected; Provide
21138 CheckToken and CheckIdentifierToken convenience error reporting
21141 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21143 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21144 NameSpaceEntry NameSpaceEntry.
21146 (LookupInterfaceOrClass): Avoid creating a full qualified name
21147 from namespace and name: avoid doing lookups when we know the
21148 namespace is non-existant. Use new Tree.LookupByNamespace which
21149 looks up DeclSpaces based on their namespace, name pair.
21151 * driver.cs: Provide a new `parser verbose' to display the
21152 exception thrown during parsing. This is turned off by default
21153 now, so the output of a failure from mcs is more graceful.
21155 * namespace.cs: Track all the namespaces defined in a hashtable
21158 (IsNamespace): New method
21160 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21162 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21163 we know that we need to concatenate (full typename can never be
21168 * statement.cs: Use a bitfield; Do not initialize to null things
21169 which are done by the constructor by default.
21171 * cs-parser.jay: bug fix, parameter was 4, not 3.
21173 * expression.cs: Just use the property;
21175 * statement.cs: No need for GetVariableInfo method.
21177 2003-08-08 Martin Baulig <martin@ximian.com>
21179 * flowanalysis.cs (FlowReturns): This is now nested in the
21180 `FlowBranching' class.
21181 (MyBitVector): Moved this here from statement.cs.
21182 (FlowBranching.SiblingType): New enum type.
21183 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21185 2003-08-07 Martin Baulig <martin@ximian.com>
21187 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21188 `FlowBranching' class and called `BranchingType'.
21190 2003-08-07 Martin Baulig <martin@ximian.com>
21192 * flowanalysis.cs: Moved all the control flow analysis code into
21195 2003-08-07 Martin Baulig <martin@ximian.com>
21197 * assign.cs (Assign.DoResolve): `target' must either be an
21198 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21201 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21203 * expression.cs (BinaryMethod): This kind of expression is created by the
21204 Binary class if it determines that the operator has to be handled
21207 (BinaryDelegate): This kind of expression is created if we are
21208 dealing with a + or - operator on delegates.
21210 (Binary): remove method, argumetns, and DelegateOperator: when
21211 dealing with methods,
21213 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21215 * statement.cs (Block): use bitfields for the three extra booleans
21216 we had in use. Remove unused topblock parameter.
21218 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21220 * assign.cs: Drop extra unneeded tests.
21222 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21224 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21226 * statement.cs (Foreach): Use VariableStorage instead of
21229 * codegen.cs (VariableStorage): New class used by clients that
21230 require a variable stored: locals or fields for variables that
21231 need to live across yield.
21233 Maybe provide a convenience api for EmitThis+EmitLoad?
21235 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21238 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21240 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21241 RemapParameterLValue): New methods that are used to turn a
21242 precomputed FieldInfo into an expression like this:
21246 The idea is to use this instead of making LocalVariableReference
21247 have more than one meaning.
21249 * cs-parser.jay: Add error production to BASE.
21251 * ecore.cs: Deal with TypeManager.GetField returning null, which
21252 is now a valid return value.
21254 (FieldExprNoAddress): New expression for Fields whose address can
21257 * expression.cs (LocalVariableReference): During the resolve
21258 phases, create new expressions if we are in a remapping context.
21259 Remove code that dealt with remapping here.
21261 (ParameterReference): same.
21263 (ProxyInstance): New expression, like the `This' expression, but
21264 it is born fully resolved. We know what we are doing, so remove
21265 the errors that are targeted to user-provided uses of `this'.
21267 * statement.cs (Foreach): our variable is now stored as an
21268 Expression; During resolution, follow the protocol, dont just
21269 assume it will return this.
21271 2003-08-06 Martin Baulig <martin@ximian.com>
21273 * support.cs (SeekableStreamReader.cs): New public class.
21275 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21276 SeekableStreamReader instead of the normal StreamReader.
21278 2003-08-04 Martin Baulig <martin@ximian.com>
21280 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21281 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21282 deambiguate casts and delegate invocations.
21283 (parenthesized_expression): Use the new tokens to ensure this is
21284 not a cast of method invocation.
21286 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21287 when reading a `)' and Deambiguate_CloseParens () was previously
21290 * expression.cs (ParenthesizedExpression): New class. This is
21291 just used for the CS0075 test.
21292 (Binary.DoResolve): Check for CS0075.
21294 2003-07-29 Ravi Pratap <ravi@ximian.com>
21296 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21297 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21298 reference comparison.
21300 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21301 examine the ReturnType for equality - this is necessary in the
21302 cases of implicit and explicit operators whose signature also
21303 includes the return type.
21305 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21307 * namespace.cs: Cache the result of the namespace computation,
21308 instead of computing it every time.
21310 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21312 * decl.cs: Use a global arraylist that we reuse over invocations
21313 to avoid excesive memory consumption. Reduces memory usage on an
21314 mcs compile by one meg (45 average).
21316 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21317 private, work around that.
21319 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21321 * literal.cs (IntLiteral): Define Zero and One static literals.
21323 * cs-parser.jay (integer_literal): use static literals to reduce
21324 memory usage for the most used literals (0, 1 and -1). 211kb
21325 reduced in memory usage.
21327 Replace all calls to `new ArrayList' with `new
21328 ArrayList(4)' which is a good average number for most allocations,
21329 and also requires only 16 bytes of memory for its buffer by
21332 This reduced MCS memory usage in seven megabytes for the RSS after
21335 2003-07-28 Ravi Pratap <ravi@ximian.com>
21337 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21338 handle params methods the correct way by forming only one
21339 applicable set with params and normal methods in them. Earlier we
21340 were looking at params methods only if we found no normal methods
21341 which was not the correct thing to do.
21343 (Invocation.BetterFunction): Take separate arguments indicating
21344 when candidate and the best method are params methods in their
21347 This fixes bugs #43367 and #46199.
21349 * attribute.cs: Documentation updates.
21351 (CheckAttribute): Rename to CheckAttributeTarget.
21352 (GetValidPlaces): Rename to GetValidTargets.
21354 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21355 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21359 2003-07-28 Martin Baulig <martin@ximian.com>
21361 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21362 name when looking up the base class of a nested class. Fixes #46977.
21364 2003-07-26 Martin Baulig <martin@ximian.com>
21366 * expression.cs (Indexers.Indexer): New nested struct; contains
21367 getter, setter and the indexer's type.
21368 (Indexers.Properties): This is now an ArrayList of
21369 Indexers.Indexer's.
21370 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21371 indexer doesn't have any getters.
21373 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21374 for embedded property and indexer assignments.
21376 2003-07-26 Martin Baulig <martin@ximian.com>
21378 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21379 preprocessor directive is not the first non-whitespace character
21382 2003-07-26 Martin Baulig <martin@ximian.com>
21384 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21385 namespace parsing, follow the spec more closely.
21387 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21388 NamespaceEntry.Lookup().
21390 2003-07-25 Martin Baulig <martin@ximian.com>
21392 * MethodCore.cs (OverridesSomething): New public field; it's set
21393 from TypeContainer.DefineMembers if this method overrides
21394 something (which doesn't need to be a method). Fix #39462.
21396 2003-07-25 Ravi Pratap <ravi@ximian.com>
21398 * typemanager.cs (GetMembers): Ensure that the list of members is
21399 reversed. This keeps things in sync.
21401 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21402 find an AttributeUsage attribute.
21404 * expression.cs (Invocation.OverloadResolve): Perform the check
21405 which disallows Invoke to be directly called on a Delegate.
21407 (Error_InvokeOnDelegate): Report error cs1533.
21409 2003-07-25 Martin Baulig <martin@ximian.com>
21411 * expression.cs (Indexers.GetIndexersForType): Only look in the
21412 interface hierarchy if the requested type is already an
21413 interface. Fixes #46788 while keeping #46502 fixed.
21415 2003-07-25 Martin Baulig <martin@ximian.com>
21417 * class.cs (TypeContainer.DefineMembers): Check whether all
21418 readonly fields have been assigned and report warning CS0649 if
21421 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21424 2003-07-24 Ravi Pratap <ravi@ximian.com>
21426 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21427 returned from GetMethods to make things consistent with the
21428 assumptions MCS makes about ordering of methods.
21430 This should comprehensively fix bug #45127 and it does :-)
21432 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21433 ordering is actually reverse.
21435 * Clean up some debug messages I left lying around.
21437 * interface.cs (Populate*): Get rid of code which emits attributes
21438 since the stage in which we emit attributes is the 'Emit' stage,
21439 not the define stage.
21441 (Emit): Move attribute emission for interface members here.
21443 2003-07-22 Ravi Pratap <ravi@ximian.com>
21445 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21446 closely: we eliminate methods in base types when we have an
21447 applicable method in a top-level type.
21449 Please see section 14.5.5.1 for an exact description of what goes
21452 This fixes bug #45127 and a host of other related to corlib compilation.
21454 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21455 array is the method corresponding to the top-level type (this is
21456 because of the changes made to icall.c) so we change this
21459 (MethodGroupExpr.Name): This too.
21461 * typemanager.cs (GetElementType): New method which does the right
21462 thing when compiling corlib.
21464 * everywhere: Make use of the above in the relevant places.
21466 2003-07-22 Martin Baulig <martin@ximian.com>
21468 * cs-parser.jay (invocation_expression): Moved
21469 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21470 `cast_expression', but create a InvocationOrCast which later
21471 resolves to either an Invocation or a Cast.
21473 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21474 method; call this before EmitStatement() to make sure that this
21475 expression can be used as a statement.
21477 * expression.cs (InvocationOrCast): New class; resolves to either
21478 an Invocation or a Cast.
21480 * statement.cs (StatementExpression): Call ResolveStatement() on
21481 the ExpressionStatement before emitting it.
21483 2003-07-21 Martin Baulig <martin@ximian.com>
21485 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21486 `ref' and `out' attributes match; fixes #46220.
21487 (MemberAccess.ResolveMemberAccess): You can't reference a type
21488 through an expression; fixes #33180.
21489 (Indexers.GetIndexersForType): Don't return the indexers from
21490 interfaces the class implements; fixes #46502.
21492 2003-07-21 Martin Baulig <martin@ximian.com>
21494 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21495 CS0661 checks; fixes bug #30442.
21497 2003-07-21 Martin Baulig <martin@ximian.com>
21499 * decl.cs (AdditionResult): Added `Error'.
21501 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21503 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21504 makes cs0031.cs actually work.
21506 2003-07-20 Martin Baulig <martin@ximian.com>
21508 * namespace.cs: Fixed that bug which caused a crash when compiling
21509 the debugger's GUI.
21511 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21513 * typemanager.cs (LookupTypeReflection): Never expose types which
21514 are NotPublic, NestedPrivate, NestedAssembly, or
21515 NestedFamANDAssem. We used to return these, and later do a check
21516 that would report a meaningful error, but the problem is that we
21517 would not get the real match, if there was a name override.
21519 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21521 * namespace.cs (Namespace, Name): Do not compute the namespace
21522 name dynamically, compute it in the constructor. This reduced
21523 memory usage by 1697 KB.
21525 * driver.cs: Use --pause to pause at the end.
21527 2003-07-17 Peter Williams <peter@newton.cx>
21529 * Makefile: Change the name of the test target so that it doesn't
21530 conflict with the recursive test target.
21532 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21534 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21535 AddressOf): Do not use EmitThis, that was wrong, use the actual
21538 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21540 * class.cs (MethodData.Define): While checking if a method is an
21541 interface implementation, improve the test: If we are not public
21542 (use new test here: use the computed MethodAttributes directly,
21543 instead of the parsed modifier flags) check if the `implementing'
21544 method comes from an interface or not.
21546 * pending.cs (VerifyPendingMethods): Slightly better error
21549 * makefile: add test target that does the mcs bootstrap.
21551 2003-07-16 Ravi Pratap <ravi@ximian.com>
21553 * interface.cs (Define): Do nothing here since there are no
21554 members to populate etc. Move the attribute emission out of here
21555 since this was just totally the wrong place to put it. Attribute
21556 application happens during the 'Emit' phase, not in the 'Define'
21559 (Emit): Add this method and move the attribute emission here
21561 * rootcontext.cs (EmitCode): Call the Emit method on interface
21564 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21566 * expression.cs (OverloadResolve): Report error only if Location
21567 is not 'Null' which means that there was a probe going on.
21569 2003-07-14 Martin Baulig <martin@ximian.com>
21571 * expression.cs (ConditionalLogicalOperator): New public class to
21572 implement user defined conditional logical operators.
21573 This is section 14.11.2 in the spec and bug #40505.
21575 2003-07-14 Martin Baulig <martin@ximian.com>
21577 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21579 2003-07-14 Martin Baulig <martin@ximian.com>
21581 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21583 * ecore.cs (IVariable.VerifyFixed): New interface method.
21585 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21586 operator, check whether the variable is actually fixed. Fixes bug
21587 #36055. Set a variable definitely assigned when taking its
21588 address as required by the spec.
21590 * statement.cs (LocalInfo.IsFixed): New field.
21591 (LocalInfo.MakePinned): Set `IsFixed' to true.
21593 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21595 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21596 for .ctors, ensure that we only ask for members declared in the
21597 attribute type (BindingFlags.DeclaredOnly).
21601 * expression.cs (Error_WrongNumArguments): Report error 1501
21602 correctly the way CSC does.
21604 2003-07-13 Martin Baulig <martin@ximian.com>
21606 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21607 lookup on the fully qualified name, to make things like "X.X" work
21608 where "X.X" is a fully qualified type name, but we also have a
21609 namespace "X" in the using list. Fixes #41975.
21611 2003-07-13 Martin Baulig <martin@ximian.com>
21613 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21614 function. If we're a CompoundAssign, we need to create an embedded
21615 CompoundAssign, not an embedded Assign.
21616 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21619 2003-07-13 Martin Baulig <martin@ximian.com>
21621 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21622 work to fix bug #46088.
21624 2003-07-13 Ravi Pratap <ravi@ximian.com>
21626 * class.cs (Operator.Emit): Do not emit attributes here - it is
21627 taken care of by the Method class that we delegate too. This takes
21628 care of bug #45876.
21630 2003-07-10 Martin Baulig <martin@ximian.com>
21632 * expression.cs (TypeOfVoid): New class.
21633 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21635 2003-07-10 Martin Baulig <martin@ximian.com>
21637 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21640 2003-07-10 Martin Baulig <martin@ximian.com>
21642 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21643 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21645 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21647 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21649 2003-07-10 Martin Baulig <martin@ximian.com>
21651 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21652 of decimal. Fixes #42850.
21654 NOTE: I also fixed the created byte blob, but this doesn't work on
21655 the MS runtime and csc never produces any byte blobs for decimal
21658 2003-07-10 Martin Baulig <martin@ximian.com>
21660 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21661 structs; fixes #32068.
21662 (Block.AddChildVariableNames): Fixed #44302.
21664 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21666 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21668 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21670 * attribute.cs: And this test is onger needed.
21672 2003-07-08 Martin Baulig <martin@ximian.com>
21674 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21675 inaccessible types. Fixes #36313.
21677 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21679 * namespace.cs (NamespaceEntry): Create implicit entries for all
21680 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21681 implicit entries for N1.N2 and N1.
21683 2003-07-08 Martin Baulig <martin@ximian.com>
21685 Rewrote the handling of namespaces to fix a lot of the issues
21686 wrt. `using' aliases etc.
21688 * namespace.cs (Namespace): Splitted this class into a
21689 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21691 * typemanager.cs (TypeManager.IsNamespace): Removed.
21692 (TypeManager.ComputeNamespaces): Only compute namespaces from
21693 loaded assemblies here, not the namespaces from the assembly we're
21694 currently compiling.
21696 2003-07-08 Martin Baulig <martin@ximian.com>
21698 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21700 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21702 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21705 I thought about the memory savings here, but LookupTypeReflection
21706 is used under already very constrained scenarios. Compiling
21707 corlib or mcs only exposes one hit, so it would not really reduce
21708 any memory consumption.
21710 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21712 * typemanager.cs: fixes bug #45889 by only adding public types from
21713 other assemblies to the list of known types.
21715 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21717 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21718 on the type we resolved.
21720 2003-07-05 Martin Baulig <martin@ximian.com>
21722 * pending.cs (PendingImplementation.ParentImplements): Don't
21723 create the proxy if the parent is abstract.
21725 * class.cs (TypeContainer.DefineIndexers): Process explicit
21726 interface implementations first. Fixes #37714.
21728 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21730 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21731 defined recursively; but since we modify the input parameters
21732 (left is set to `this' temporarily), we reset this value if the
21733 left_is_explicit is false, which gives the original semantics to
21736 * literal.cs (NullPointer): new class used to represent a null
21737 literal in a pointer context.
21739 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21740 type is a pointer, use a NullPointer object instead of a
21741 NullLiteral. Closes 43687
21743 (ExplicitConversion): Convert pointer values using
21744 the conv opcode to the proper type.
21746 * ecore.cs (New): change ValueTypeVariable property into a method,
21747 that returns whether the valuetype is suitable for being used.
21749 * expression.cs (Binary.DoNumericPromotions): Only return if we
21750 the int constant was a valid uint, and we can return both left and
21751 right as uints. If not, we continue processing, to trigger the
21752 type conversion. This fixes 39018.
21754 * statement.cs (Block.EmitMeta): During constant resolution, set
21755 the CurrentBlock property on the emitcontext, so that we resolve
21756 constants propertly.
21758 2003-07-02 Martin Baulig <martin@ximian.com>
21760 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21761 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21763 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21764 than emitting it here.
21766 * statement.cs: Fixed some more flow analysis bugs.
21768 2003-07-02 Martin Baulig <martin@ximian.com>
21770 * class.cs (MethodData.Define): When implementing interface
21771 methods, set Final unless we're Virtual.
21773 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21774 check work for interface methods.
21776 2003-07-01 Martin Baulig <martin@ximian.com>
21778 * ecore.cs (EmitContext.This): Replaced this property with a
21779 GetThis() method which takes a Location argument. This ensures
21780 that we get the correct error location for a CS0188.
21782 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21784 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21785 ImplicitStandardConversion.
21787 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21789 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21791 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21794 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21796 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21799 (MethodData.Define): Turn off initlocals for unsafe methods.
21801 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21803 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21804 complete; Fixes #37521.
21806 * delegate.cs: Use Modifiers.TypeAttr to compute the
21807 TypeAttributes, instead of rolling our own. This makes the flags
21808 correct for the delegates.
21810 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21812 * class.cs (Constructor.Define): Set the private flag for static
21813 constructors as well.
21815 * cs-parser.jay (statement_expression): Set the return value to
21816 null, to avoid a crash when we catch an error.
21818 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21820 * cs-parser.jay: Applied patch from Jackson that adds support for
21821 extern and unsafe modifiers to destructor declarations.
21823 * expression.cs: Report error 21 if the user is trying to index a
21826 * driver.cs: Add an error message, suggested by the bug report.
21828 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21829 if we do not have a ": this ()" constructor initializer. Fixes 45149
21831 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21833 * namespace.cs: Add some information to reduce FAQs.
21835 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21837 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21838 underlying enumeration types. Fixes #43915.
21840 * expression.cs: Treat ushort/short as legal values to be used in
21841 bitwise operations.
21843 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21845 * delegate.cs: transfer custom attributes for paramenters from
21846 the delegate declaration to Invoke and BeginInvoke.
21848 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21850 * attribute.cs: handle custom marshalers and emit marshal info
21853 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21855 * makefile.gnu: Added anonymous.cs to the compiler sources.
21857 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21859 * iterators.cs: Change the name of the proxy class to include two
21862 * cs-parser.jay: Update grammar to include anonymous methods.
21864 * anonymous.cs: new file.
21866 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21868 * class.cs (Field.Define): Add missing test for pointers and
21871 2003-05-27 Ravi Pratap <ravi@ximian.com>
21873 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21874 we use the stobj opcode.
21876 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21877 since it wasn't the correct fix.
21879 It still is puzzling that we are required to use stobj for IntPtr
21880 which seems to be a ValueType.
21882 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21884 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21885 during regular simple name resolution. Now, the trick is that
21886 instead of returning for processing the simplename, we do a
21887 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21888 contextual lookup type). If a match is found, return that, if
21889 not, return for further composition.
21891 This fixes long-standing 30485.
21893 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21894 using the address to initialize an object, do an Stobj instead of
21895 using the regular Stelem.
21897 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21898 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21899 Because if we are a BaseIndexerAccess that value will be true.
21902 * statement.cs (GotoCase.Resolve): Return after reporting an
21903 error, do not attempt to continue.
21905 * expression.cs (PointerArithmetic.Emit): If our operand is a
21906 long, convert our constants to match the operand before
21907 multiplying. Convert to I type before adding. Fixes 43670.
21909 2003-05-14 Ravi Pratap <ravi@ximian.com>
21911 * enum.cs (ImplicitConversionExists) : Rename to
21912 ImplicitEnumConversionExists to remove ambiguity.
21914 * ecore.cs (NullCast): New type of cast expression class which
21915 basically is very similar to EmptyCast with the difference being
21916 it still is a constant since it is used only to cast a null to
21918 (eg. (string) null)
21920 * convert.cs (ImplicitReferenceConversion): When casting a null
21921 literal, we return a NullCast.
21923 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21924 should be around anymore.
21926 The renaming (reported was slightly wrong). Corrections:
21928 ConvertImplicitStandard -> ImplicitConversionStandard
21929 ConvertExplicitStandard -> ExplicitConversionStandard
21931 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21932 before passing them in !
21934 * convert.cs (ImplicitConversionStandard): When comparing for
21935 equal expr and target types, ensure that expr is not a
21938 In general, we must not be checking (expr_type ==
21939 target_type) in the top level conversion methods
21940 (ImplicitConversion, ExplicitConversion etc). This checking is
21941 done in the methods that they delegate to.
21943 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21945 * convert.cs: Move Error_CannotConvertType,
21946 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21947 ImplicitNumericConversion, ImplicitConversionExists,
21948 ImplicitUserConversionExists, StandardConversionExists,
21949 FindMostEncompassedType, FindMostSpecificSource,
21950 FindMostSpecificTarget, ImplicitUserConversion,
21951 ExplicitUserConversion, GetConversionOperators,
21952 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21953 TryImplicitIntConversion, Error_CannotConvertImplicit,
21954 ConvertImplicitRequired, ConvertNumericExplicit,
21955 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21956 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21959 Perform the following renames:
21961 StandardConversionExists -> ImplicitStandardConversionExists
21962 ConvertImplicit -> ImplicitConversion
21963 ConvertImplicitStandard -> ImplicitStandardConversion
21964 TryImplicitIntConversion -> ImplicitIntConversion
21965 ConvertImplicitRequired -> ImplicitConversionRequired
21966 ConvertNumericExplicit -> ExplicitNumericConversion
21967 ConvertReferenceExplicit -> ExplicitReferenceConversion
21968 ConvertExplicit -> ExplicitConversion
21969 ConvertExplicitStandard -> ExplicitStandardConversion
21971 2003-05-19 Martin Baulig <martin@ximian.com>
21973 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21974 (TypeInfo): Added support for structs having structs as fields.
21976 * ecore.cs (FieldExpr): Implement IVariable.
21977 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21978 VariableInfo for the field.
21980 2003-05-18 Martin Baulig <martin@ximian.com>
21982 * expression.cs (This.DoResolve): Report a CS0027 if we're
21983 emitting a field initializer.
21985 2003-05-18 Martin Baulig <martin@ximian.com>
21987 * expression.cs (This.ResolveBase): New public function.
21988 (This.DoResolve): Check for CS0188.
21990 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21993 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21994 `instance_expression' to null if we don't have any non-static
21997 2003-05-18 Martin Baulig <martin@ximian.com>
21999 Reworked the way how local variables and parameters are handled by
22000 the flow analysis code.
22002 * statement.cs (TypeInfo, VariableMap): New public classes.
22003 (VariableInfo): New public class. This is now responsible for
22004 checking whether a variable has been assigned. It is used for
22005 parameters and local variables.
22006 (Block.EmitMeta): Take the InternalParameters as argument; compute
22007 the layout of the flow vectors here.
22008 (Block.LocalMap, Block.ParameterMap): New public properties.
22009 (FlowBranching): The .ctor doesn't get the InternalParameters
22010 anymore since Block.EmitMeta() now computes the layout of the flow
22012 (MyStructInfo): This class is now known as `StructInfo' and nested
22013 in `TypeInfo'; we don't access this directly anymore.
22015 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22016 property and removed IsAssigned(), IsFieldAssigned(),
22017 SetAssigned() and SetFieldAssigned(); we now call them on the
22018 VariableInfo so we don't need to duplicate this code everywhere.
22020 * expression.cs (ParameterReference): Added `Block block' argument
22022 (LocalVariableReference, ParameterReference, This): The new
22023 VariableInfo class is now responsible for all the definite
22026 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22027 IsParameterAssigned, SetParameterAssigned): Removed.
22029 2003-05-18 Martin Baulig <martin@ximian.com>
22031 * typemanager.cs (InitCoreTypes): Try calling
22032 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22033 the 3-args-version. Corlib now also needs our `void_type'.
22034 (GetMethod): Added overloaded version which takes an optional
22035 `bool report_errors' to allow lookups of optional methods.
22037 2003-05-12 Martin Baulig <martin@ximian.com>
22039 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22040 only used for locals and not for parameters.
22042 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22044 * support.cs (InternalParameters.ParameterType): Return the
22045 ExternalType of the parameter.
22047 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22050 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22052 * class.cs (MethodData.Define): Do not set the `newslot' on
22053 interface members, if they are also flagged as "override".
22055 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22056 better code for ++i and i++. This only works for static fields
22057 and local variables.
22059 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22060 want to pull the DeclSpace out of the builder_to_declspace instead
22061 of the TypeBuilder (like in TypeContainer.FindMembers).
22063 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22064 instead of LookupTypeContainer. Fixes the crash on .NET for
22065 looking up interface members.
22067 * const.cs: Create our own emit context during the Definition
22068 stage, so that constants are evaluated in the proper context, when
22069 a recursive definition happens.
22071 2003-05-11 Martin Baulig <martin@ximian.com>
22073 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22074 new block for a switch section.
22075 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22076 the adding/lookup in the switch block. Fixes #39828.
22078 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22080 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22081 functionality: I needed to convert the data after I had performed
22082 the add/sub operation into the operands type size.
22084 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22085 pass the type for the box operation, otherwise the resulting
22086 object would have been of type object.
22088 (BoxedCast): Add constructor to specify the type to box as.
22090 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22092 * iterators.cs: I was reusing the `count' variable inadvertently,
22093 take steps to not allow this to happen.
22095 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22097 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22098 by creating an array at the point where the params starts and
22099 putting all those arguments there, then adjusting the size of the
22102 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22104 * expression.cs (New.AddressOf): Implement interface
22105 IMemoryLocation. This is used when the `new' operator is used in
22106 the context of an invocation to a method on a value type.
22108 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22111 * namespace.cs: Also check the using aliases here.
22113 * driver.cs: Move the test for using validity after the types have
22114 been entered, so we do a single pass that also includes the using
22117 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22118 in the regular case. CreateSiblingForFinally is doing extra
22121 * attribute.cs (GetAttributeArgumentExpression): Store the result
22122 on an out value, and use the return value to indicate failure
22123 instead of using null (which is a valid return for Constant.GetValue).
22125 * statement.cs: Perform the analysis flow for the increment
22126 portion after the statement, because this will be the real flow of
22127 execution. Fixes #42385
22129 * codegen.cs (EmitContext.EmitArgument,
22130 EmitContext.EmitStoreArgument): New helper functions when the
22131 RemapToProxy flag is set.
22133 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22136 Add support for remapping parameters.
22138 * iterators.cs: Propagate parameter values; Store parameter
22139 values in the proxy classes.
22141 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22143 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22144 need a proxy reference; I do not know what I was thinking
22146 * cs-parser.jay (constructor_initializer): catch another error,
22147 and display nice message.
22149 (field_declaration): catch void field declaration
22150 to flag a better error.
22152 * class.cs (MemberBase.CheckBase): Report an error instead of a
22153 warning if a new protected member is declared in a struct.
22154 (Field.Define): catch the error of readonly/volatile.
22156 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22158 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22159 volatile variable is taken
22161 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22163 * statement.cs (Fixed.Resolve): Report an error if we are not in
22166 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22168 * typemanager.cs: reuse the code that handles type clashes for
22169 delegates and enumerations.
22171 * class.cs (Report28): Always report.
22173 * expression.cs (EncodeAsAttribute): Allow nulls here.
22175 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22177 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22178 the functionality for testing whether an expression is valid for
22179 an attribute here. Also handle the case of arrays of elements
22182 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22183 encoding a linear array into an array of objects that are suitable
22184 to be passed to an CustomAttributeBuilder.
22186 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22188 * ecore.cs: (FieldExpr): Handle field remapping here.
22190 * iteratators.cs: Pass the instance variable (if the method is an
22191 instance method) to the constructors, so we can access the field
22192 variables on the class.
22194 TODO: Test this with structs. I think the THIS variable on
22195 structs might have to be a pointer, and not a refenrece
22197 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22199 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22200 local variables to fields in a proxy class.
22202 * iterators.cs (PopulateProxy): Rename our internal fields to
22204 Create a <THIS> field if we are an instance method, so we can
22205 reference our parent container variables.
22206 (MapVariable): Called back from the EmitContext code to enter a
22207 new variable to field mapping into the proxy class (we just create
22211 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22212 for using the remapped locals to fields.
22214 I placed the code here, because that gives the same semantics to
22215 local variables, and only changes the Emit code.
22217 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22218 statements inside iterators.
22219 (VariableInfo): Add a FieldBuilder for the cases when we are
22220 remapping local variables to fields in a proxy class
22222 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22223 current_block != null.
22225 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22226 not cope with strings, as it has been moved to the
22227 TableSwitchEmit. Fixed bug in switch generation.
22229 * expression.cs (New.DoResolve): Provide more context for the user
22230 when reporting an error.
22232 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22235 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22236 check the permissions for it. Note than in a type-resolution
22237 context the check was already present in DeclSpace.ResolveType,
22238 but was missing from the MemberAccess.
22240 (ArrayCreation.CheckIndices): warn if the user has
22241 more nested levels of expressions, but there are no more
22242 dimensions specified. Avoids crash on bug 41906.
22244 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22246 * statement.cs (Block): replace Implicit bool, for a generic
22248 New flag: `Unchecked'. This is used during the EmitMeta phase
22249 (which is out-of-line with the regular Resolve/Emit process for a
22250 statement, as this is done ahead of time, but still gets a chance
22251 to call constant resolve).
22253 (Block.Flags): new enum for adding a new flag.
22255 (Block.EmitMeta): track the state of unchecked.
22257 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22258 to enable constant resolution to work there as well.
22260 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22262 * typemanager.cs (ienumerable_type): Also look up
22263 System.Collections.IEnumerable.
22265 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22267 TODO: Test more than one conditional per method.
22269 * class.cs (Indexer.Define): Report the location where the user is
22270 referencing the unsupported feature.
22272 (MethodData): Overload the use of `conditionals' to
22273 minimize the creation of needless ArrayLists. This saves roughly
22274 212kb on my machine.
22276 (Method): Implement the new IIteratorContainer interface.
22277 (Method.SetYields): Implement the method by setting the ModFlags
22278 to contain METHOD_YIELDS.
22280 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22281 which just got set to null.
22283 * iterators.cs: New file.
22285 (Yield, YieldBreak): New statements.
22287 * statement.cs (Return.Resolve): Flag an error if we are used in
22288 an iterator method.
22290 * codegen.cs (InIterator): New flag set if the code is being
22291 compiled in an iterator method.
22293 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22294 internal modifier, and we just use it to avoid adding extra
22295 fields, as this is seldom used.
22297 * cs-parser.jay: Add yield_statement (yield and yield break).
22299 * driver.cs: New flag -v2 to turn on version 2 features.
22301 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22302 hashtable when v2 is enabled.
22304 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22306 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22307 there is already a namespace defined with this name.
22309 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22310 people upgraded their corlibs.
22312 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22313 always use fully qualified types, no need to use the compiler
22316 (TypeManager.IsNamespace): Use binarysearch.
22318 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22319 AddDelegate): I did not quite use the new IsValid API properly: I
22320 have to pass the short-name and the fullname. I was passing only
22321 the basename instead of the fullname sometimes.
22323 (TypeContainer.DefineType): call NamespaceClash.
22325 * interface.cs (Interface.DefineType): use NamespaceClash before
22328 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22331 * enum.cs: (Enum.DefineType): use NamespaceClash before
22334 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22335 speed increase. First, use the negative_hits cache when we get a
22336 negative. Second, add the type with its full original name
22337 instead of the new . and + encoded name (reflection uses + to
22338 separate type from a nested type). Use LookupTypeReflection
22339 directly which bypasses the type->name hashtable (that we already
22340 know does not contain the type.
22342 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22343 location/container type.
22345 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22347 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22349 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22351 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22352 method is being referenced in the method group from a static
22353 context, and report error 120 if so.
22355 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22358 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22359 is created, we create the A namespace).
22361 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22364 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22366 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22367 invocation to ModuleBuilder.GetType with the same values will
22368 return a new type instance, so we need to cache its return
22371 * expression.cs (Binary.ResolveOperator): Only allow the compare
22372 operators on enums if they are of the same type.
22374 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22375 types of ValueType on their own case. Before we were giving them
22376 the same treatment as objects.
22378 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22379 fullname. Short name is used to compare against container name.
22380 Fullname is used to check against defined namespace names.
22382 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22383 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22385 (Method.CheckBase): Call parent.
22386 (MemberBase.CheckBase): Check for protected members on sealed
22388 (PropertyBase.CheckBase): Call parent.
22389 (Field.Define): Call parent.
22391 * report.cs: Negative error codes are now mapped to 8000 - code,
22392 so that the display is render more nicely.
22394 * typemanager.cs: Do not use try/catch, instead report a regular
22397 (GetPointerType, GetReferenceType): These methods provide
22398 mechanisms to obtain the T* and T& from a T. We had the code
22399 previously scattered around the code base, and it also used
22400 TypeManager.LookupType that would go through plenty of caches.
22401 This one goes directly to the type source.
22403 In some places we did the Type.GetType followed by
22404 ModuleBuilder.GetType, but not in others, so this unifies the
22405 processing as well.
22407 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22408 statements now that we have namespace information.
22410 * typemanager.cs (IsNamespace): New method, returns whether the
22411 string presented is a namespace or not.
22413 (ComputeNamespaces): New public entry point, computes the list of
22414 available namespaces, using the GetNamespaces API call in Mono, or
22415 the slower version in MS.NET.
22417 Now before we start the semantic analysis phase, we have a
22418 complete list of namespaces including everything that the user has
22421 Deleted old code to cache namespaces in .nsc files.
22423 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22425 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22426 class/struct location definition Location for the implicit
22427 constructor location.
22429 (Operator.Define): Use the location of the operator for the
22430 implicit Method definition.
22432 (Constructor.Emit): use the constructor location for the implicit
22433 base initializer constructor.
22435 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22436 and the Expression class now contains two new methods:
22438 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22439 isolate type lookup from the rest of the resolution process.
22441 Since we use Expressions to hold type definitions due to the way
22442 we parse the input we have historically overloaded Resolve to
22443 perform the Type lookups if a special flag is passed. Now this is
22444 eliminated and two methods take their place.
22446 The differences in the two methods between xStep and xTerminal is
22447 that xStep is involved in our current lookup system that uses
22448 SimpleNames to compose a name, while xTerminal is used just to
22449 catch the case where the simplename lookup failed.
22451 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22453 * expression.cs (ResolveMemberAccess): Remove redundant code.
22454 TypeExpr expressions are always born fully resolved.
22456 * interface.cs (PopulateMethod): Do not lookup the types twice.
22457 We were doing it once during SemanticAnalysis and once during
22460 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22461 in local variable type definitions, were being returned as a
22462 SimpleName (we decomposed everything into a string), that is
22463 because primary_expression was being used instead of a type in the
22464 grammar (reduce/reduce conflicts).
22466 The part that was wrong is that we converted the expression into a
22467 string (an oversimplification in one hand, compounded with primary
22468 expressions doing string concatenation).
22474 Would return "A.B.C[]" as a SimpleName. This stopped things like
22475 using clauses from working on this particular context. And a type
22476 was being matched directly against "A.B.C[]".
22478 We now use the correct approach, and allow for ComposedCast to be
22479 part of the unary expression. So the "A.B.C []" become a composed
22480 cast of "A.B.C" (as a nested group of MemberAccess with a
22481 SimpleName at the end) plus the rank composition "[]".
22485 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22487 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22488 for the access level checking.
22490 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22491 `TypeContainer container', because I kept getting confused when I
22492 was debugging this code.
22494 * expression.cs (Indexers): Instead of tracking getters/setters,
22495 we now track them in parallel. We create one arraylist less, but
22496 most importantly it is possible now for the LValue code to find a
22497 matching get for a set.
22499 (IndexerAccess.DoResolveLValue): Update the code.
22500 GetIndexersForType has been modified already to extract all the
22501 indexers from a type. The code assumed it did not.
22503 Also make the code set the correct return type for the indexer.
22504 This was fixed a long time ago for properties, but was missing for
22505 indexers. It used to be void_type.
22507 (Binary.Emit): Test first for doubles instead of
22508 floats, as they are more common.
22510 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22511 when dealing with floats and the <=, >= operators. This fixes bug
22514 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22515 to load the array value by emitting a load on the foreach variable
22516 type. This was incorrect.
22518 We now emit the code to load an element using the the array
22519 variable type, and then we emit the conversion operator.
22523 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22525 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22527 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22529 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22530 test for protection before we test for signatures.
22532 (MethodSignature.ToString): implement.
22534 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22535 to the case where we reduced into a LongConstant.
22537 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22538 depend on whether the information is acurrate, because the
22539 Microsoft runtime will always claim that the array type is public,
22540 regardless of the real state.
22542 If the type is a pointer, another problem happens: the type is
22543 reported as non-public in Microsoft.
22545 In both cases we have to call CheckAccessLevel recursively with
22546 the underlying type as the argument to be tested.
22548 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22550 * assign.cs (Assign.Emit): If we are dealing with a compound
22551 assignment expression, we should use the code path that stores the
22552 intermediate result in a temporary value. This fixes #40903.
22554 *expression.cs (Indirection.ToString): Provide ToString method for
22557 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22559 * class.cs: Null out fields holding references to Block objects so
22560 they can be garbage collected.
22562 * expression.cs (OverloadResolve): Remove unused local.
22564 2003-04-07 Martin Baulig <martin@ximian.com>
22566 * codegen.cs (EmitContext.CurrentFile): New public field.
22567 (EmitContext.Mark): Use the CurrentFile to check whether the
22568 location is in the correct file.
22569 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22571 2003-04-07 Martin Baulig <martin@ximian.com>
22573 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22575 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22576 location. [FIXME: The location argument which gets passed to this
22577 method is sometimes wrong!]
22579 2003-04-07 Nick Drochak <ndrochak@gol.com>
22581 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22583 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22585 * expression.cs (Indirection.EmitAssign): We were using the
22586 temporary, but returning immediately instead of continuing the
22589 2003-04-06 Martin Baulig <martin@ximian.com>
22591 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22592 if it's a nested child, but also deriving from the outer class.
22595 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22596 nested child, but also deriving from the outer class. See
22598 (FilterWithClosure): We may access private members of the outer
22599 class if we're a nested child and deriving from the outer class.
22600 (RealMemberLookup): Only set `closure_private_ok' if the
22601 `original_bf' contained BindingFlags.NonPublic.
22603 2003-04-05 Martin Baulig <martin@ximian.com>
22605 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22607 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22609 * class.cs (Event.Define): Do not allow abstract events to have
22612 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22614 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22615 block in event declarations.
22617 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22618 value type, get its address.
22620 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22621 leaving a class on the stack instead of a boolean value (int
22622 0/1). Change the code so we compare against null, and then the
22623 result against zero.
22625 * class.cs (TypeContainer.GetClassBases): We were checking for the
22626 parent class being sealed too late.
22628 * expression.cs (Binary.Emit): For <= and >= when dealing with
22629 floating point values, use cgt.un and clt.un instead of cgt and
22632 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22634 * statement.cs: Apply the same optimization as MS: skip the
22635 GetEnumerator returning an IEnumerator, and use the one returning a
22636 CharEnumerator instead. This allows us to avoid the try-finally block
22639 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22641 * cs-parser.jay: Attributes cannot be applied to
22642 namespaces. Fixes #40473
22644 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22647 (Add*): check if the name is valid using the full name for constants,
22648 fields, properties and events.
22650 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22652 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22653 char constants to be part of the enumeration.
22655 * expression.cs (Conditional.DoResolve): Add support for operator
22656 true. Implements the missing functionality from 14.12
22658 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22659 operator true/false as required by the spec.
22661 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22662 implicit conversion to boolean.
22664 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22665 also one where the type implements `operator true'.
22667 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22668 get an expression that will invoke operator true based on an
22671 (GetConversionOperators): Removed the hack that called op_True
22674 (Expression.ResolveBoolean): Move this from Statement.
22676 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22678 * ecore.cs (FieldExpr): do not allow initialization of initonly
22679 fields on derived classes
22681 2003-03-13 Martin Baulig <martin@ximian.com>
22683 * statement.cs (Block.Emit): Call ig.BeginScope() and
22684 ig.EndScope() when compiling with debugging info; call
22685 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22687 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22689 * expression.cs (Indexers): Do not construct immediately, allow
22690 for new members to be appended as we go. Fixes 38143
22692 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22694 * expression.cs: save/restore context when resolving an unchecked
22697 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22699 * cfold.cs: Catch division by zero in modulus operator during
22702 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22704 * interface.cs (Interface.DefineMembers): Avoid defining members
22707 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22709 * driver.cs: handle the +/- options for -noconfig
22711 * statement.cs (Unckeched.Resolve): Also track the state of
22712 unchecked in the Resolve phase.
22714 2003-02-27 Martin Baulig <martin@ximian.com>
22716 * ecore.cs (Expression.MemberLookup): Don't create a
22717 MethodGroupExpr for something which is not a method. Fixes #38291.
22719 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22721 * class.cs (MemberBase.CheckParameters): Also check that the type
22722 is unmanaged if it is a pointer.
22724 * expression.cs (SizeOf.Resolve): Add location information.
22726 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22727 a managed type is declared.
22729 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22730 parameter modifiers as well. Fixes bug 38606
22732 * class.cs: Very sad. Am backing out the speed up changes
22733 introduced by the ArrayList -> Array in the TypeContainer, as they
22734 were not actually that much faster, and introduced a bug (no error
22735 reports on duplicated methods).
22737 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22738 source first, this will guarantee that we have a valid expression
22739 before calling in lower levels functions that will require a
22740 resolved object. Then use this original_source in the
22741 target.ResolveLValue instead of the original source that was
22744 Another change. Use target.Resolve instead of LValueResolve.
22745 Although we are resolving for LValues, we will let the Assign code
22746 take care of that (it will be called again from Resolve). This
22747 basically allows code like this:
22749 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22750 class Y { void A (X x) { x [0] += o; }
22752 The problem was that the indexer was trying to resolve for
22753 set_Item (idx, object o) and never finding one. The real set_Item
22754 was set_Item (idx, X). By delaying the process we get the right
22759 2003-02-23 Martin Baulig <martin@ximian.com>
22761 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22762 while calling DoEmit ().
22764 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22765 source files; if you use the #line directive inside a method, the
22766 compiler stops emitting line numbers for the debugger until it
22767 reaches the end of the method or another #line directive which
22768 restores the original file.
22770 2003-02-23 Martin Baulig <martin@ximian.com>
22772 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22774 2003-02-23 Martin Baulig <martin@ximian.com>
22776 * statement.cs (Block.AddChildVariableNames): We need to call this
22777 recursively, not just for our immediate children.
22779 2003-02-23 Martin Baulig <martin@ximian.com>
22781 * class.cs (Event.Define): Always make the field private, like csc does.
22783 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22784 actually work, fixes bug #37521.
22786 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22788 * delegate.cs: When creating the various temporary "Parameters"
22789 classes, make sure that we call the ComputeAndDefineParameterTypes
22790 on those new parameters (just like we do with the formal ones), to
22791 allow them to be resolved in the context of the DeclSpace.
22793 This fixes the bug that Dick observed in Bugzilla #38530.
22795 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22797 * expression.cs (ResolveMemberAccess): When resolving a constant,
22798 do not attempt to pull a constant if the value was not able to
22799 generate a valid constant.
22801 * const.cs (LookupConstantValue): Do not report more errors than required.
22803 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22805 * expression.cs: fixes bug #38328.
22807 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22809 * class.cs: Changed all the various members that can be part of a
22810 class from being an ArrayList to be an Array of the right type.
22811 During the DefineType type_list, interface_list, delegate_list and
22812 enum_list are turned into types, interfaces, delegates and enums
22815 And during the member population, indexer_list, event_list,
22816 constant_list, field_list, instance_constructor_list, method_list,
22817 operator_list and property_list are turned into their real arrays.
22819 Although we could probably perform this operation earlier, for
22820 good error reporting we need to keep the lists and remove the
22821 lists for longer than required.
22823 This optimization was triggered by Paolo profiling the compiler
22824 speed on the output of `gen-sample-program.pl' perl script.
22826 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22827 not crash in methods like MemberLookupFailed that use this field.
22829 This problem arises when the compiler fails to resolve a type
22830 during interface type definition for example.
22832 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22834 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22835 inherit from System.Object, so we have to stop at null, not only
22836 when reaching System.Object.
22838 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22840 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22841 DeclaredOnly because the parent indexer might have had a different
22842 name, but did not loop until the top of the hierarchy was reached.
22844 The problem this one fixes is 35492: when a class implemented an
22845 indexer from an interface, we were getting the interface method
22846 (which was abstract) and we were flagging an error (can not invoke
22849 This also keeps bug 33089 functioning, and test-148 functioning.
22851 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22852 out if a method is special is to see if it is declared in a
22853 property or event, or whether it is one of the predefined operator
22854 names. This should fix correctly #36804.
22856 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22858 The goal here is to remove the dependency on EmptyCast.Peel ().
22859 Killing it completely.
22861 The problem is that currently in a number of places where
22862 constants are expected, we have to "probe" for an EmptyCast, and
22863 Peel, which is not the correct thing to do, as this will be
22864 repetitive and will likely lead to errors.
22866 The idea is to remove any EmptyCasts that are used in casts that
22867 can be reduced to constants, so we only have to cope with
22870 This bug hunt was triggered by Bug 37363 and the desire to remove
22871 the duplicate pattern where we were "peeling" emptycasts to check
22872 whether they were constants. Now constants will always be
22875 * ecore.cs: Use an enumconstant here instead of wrapping with
22878 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22879 throwing me off. By handling this we can get rid of a few hacks.
22881 * statement.cs (Switch): Removed Peel() code.
22883 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22885 * class.cs: Location information for error 508
22887 * expression.cs (New.DoResolve): Add a guard against double
22888 resolution of an expression.
22890 The New DoResolve might be called twice when initializing field
22891 expressions (see EmitFieldInitializers, the call to
22892 GetInitializerExpression will perform a resolve on the expression,
22893 and later the assign will trigger another resolution
22895 This leads to bugs (#37014)
22897 * delegate.cs: The signature for EndInvoke should contain any ref
22898 or out parameters as well. We were not doing this in the past.
22900 * class.cs (Field.Define): Do not overwrite the type definition
22901 inside the `volatile' group. Turns out that volatile enumerations
22902 were changing the type here to perform a validity test, which
22905 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22907 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22908 and structs, we do not want to load the instance variable
22910 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22911 enum_type has to be handled like an object reference (implicit
22912 conversions exists from this to object), but the regular IsClass
22913 and IsValueType tests will never return true for this one.
22915 Also we use TypeManager.IsValueType instead of type.IsValueType,
22916 just for consistency with the rest of the code (this is only
22917 needed if we ever use the construct exposed by test-180.cs inside
22918 corlib, which we dont today).
22920 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22922 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22925 2003-02-09 Martin Baulig <martin@ximian.com>
22927 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22928 (Namespace.DefineNamespaces): New static public method; this is
22929 called when we're compiling with debugging to add all namespaces
22930 to the symbol file.
22932 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22933 pass it to the Namespace's .ctor.
22935 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22936 and MethodBase arguments; pass the namespace ID to the symwriter;
22937 pass the MethodBase instead of the token to the symwriter.
22938 (SymbolWriter.DefineNamespace): New method to add a namespace to
22941 2003-02-09 Martin Baulig <martin@ximian.com>
22943 * symbolwriter.cs: New file. This is a wrapper around
22944 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22945 methods here in near future.
22947 2003-02-09 Martin Baulig <martin@ximian.com>
22949 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22950 ILGenerator.MarkSequencePoint() which are actually used by the
22953 2003-02-09 Martin Baulig <martin@ximian.com>
22955 * location.cs (SourceFile): New public sealed class. This
22956 contains the name and an index which is used in the location's token.
22957 (Location): Reserve an appropriate number of bits in the token for
22958 the source file instead of walking over that list, this gives us a
22959 really huge performance improvement when compiling with debugging.
22961 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22962 `SourceFile' argument instead of a string.
22963 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22964 but don't parse/tokenize here, we need to generate the list of all
22965 source files before we do that.
22966 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22969 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22970 instead of a string.
22972 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22975 2003-02-09 Martin Baulig <martin@ximian.com>
22977 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22978 filename on `#line default'.
22980 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22982 * statement.cs: don't clear the pinned var when the fixed statement
22983 returns from the method (fixes bug#37752).
22985 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22987 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22990 2003-02-07 Martin Baulig <martin@ximian.com>
22992 * driver.cs: Removed the `--debug-args' command line argument.
22994 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22995 automatically by the AsssemblyBuilder.
22996 (CodeGen.InitializeSymbolWriter): We don't need to call any
22997 initialization function on the symbol writer anymore. This method
22998 doesn't take any arguments.
23000 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23002 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23003 from referenced assemblies as well.
23005 2003-02-02 Martin Baulig <martin@ximian.com>
23007 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23009 2003-02-02 Martin Baulig <martin@ximian.com>
23011 * class.cs (Constructor.Emit): Open the symbol writer before
23012 emitting the constructor initializer.
23013 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23014 single-stepping through constructor initializers.
23016 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23018 * class.cs: Handle error 549: do not allow virtual methods in
23021 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23023 * decl.cs: Check access levels when resolving types
23025 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23027 * statement.cs: Add parameters and locals set in catch blocks that might
23028 return to set vector
23030 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23032 * class.cs (Operator): Set the SpecialName flags for operators.
23034 * expression.cs (Invocation.DoResolve): Only block calls to
23035 accessors and operators on SpecialName methods.
23037 (Cast.TryReduce): Handle conversions from char constants.
23040 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23042 * statement.cs: small memory and time optimization in FlowBranching.
23044 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23046 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23047 problem that the last fix but in the other sid (Set).
23049 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23050 access when there is no indexer in the hierarchy.
23052 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23054 * class.cs: Combine some if statements.
23056 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23058 * driver.cs: fixed bug #37187.
23060 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23062 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23063 any indexer, it's needed to build a list with all the indexers in the
23064 hierarchy (AllGetters), else we have problems. Fixes #35653.
23066 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23068 * class.cs (MethodData.Define): It is wrong for an interface
23069 implementation to be static in both cases: explicit and implicit.
23070 We were only handling this in one case.
23072 Improve the if situation there to not have negations.
23074 * class.cs (Field.Define): Turns out that we do not need to check
23075 the unsafe bit on field definition, only on usage. Remove the test.
23077 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23079 * driver.cs: use assembly.Location instead of Codebase (the latest
23080 patch made mcs fail when using MS assemblies).
23082 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23084 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23085 get the path to *corlib.dll.
23087 2003-01-21 Nick Drochak <ndrochak@gol.com>
23091 * typemanager.cs: Remove compiler warnings
23093 2003-01-20 Duncan Mak <duncan@ximian.com>
23095 * AssemblyInfo.cs: Bump the version number to 0.19.
23097 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23099 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23101 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23103 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23105 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23107 * cs-parser.jay: Small fix: we were not comparing the constructor
23108 name correctly. Thanks to Zoltan for the initial pointer.
23110 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23112 * cs-tokenizer.cs: Set file name when specified with #line
23114 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23116 * cs-parser.jay: Only perform the constructor checks here if we
23117 are named like the class; This will help provider a better
23118 error. The constructor path is taken when a type definition is
23119 not found, but most likely the user forgot to add the type, so
23120 report that rather than the constructor error.
23122 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23124 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23127 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23129 * cs-parser.jay: Add cleanup call.
23131 2003-01-13 Duncan Mak <duncan@ximian.com>
23133 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23134 consistent with other methods.
23136 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23138 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23140 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23142 * attribute.cs: only set GuidAttr to true when we have a
23145 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23149 * typemanager.cs: fixes to allow mcs compile corlib with the new
23150 Type.IsSubclassOf fix.
23152 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23154 * expression.cs (LocalVariableReference.DoResolve): Classify a
23155 constant as a value, not as a variable. Also, set the type for
23158 * cs-parser.jay (fixed_statement): take a type instead of a
23159 pointer_type, so we can produce a better error message later.
23161 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23164 (For.DoEmit): Make inifinite loops have a
23165 non-conditional branch back.
23167 (Fixed.DoEmit): First populate the pinned variables, then emit the
23168 statement, then clear the variables. Before I was emitting the
23169 code once for each fixed piece.
23172 2003-01-08 Martin Baulig <martin@ximian.com>
23174 * statement.cs (FlowBranching.MergeChild): A break in a
23175 SWITCH_SECTION does not leave a loop. Fixes #36155.
23177 2003-01-08 Martin Baulig <martin@ximian.com>
23179 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23180 lives in the same number space than `param_map'. Fixes #36154.
23182 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23184 * cs-parser.jay (constructor_declaration): Set the
23185 Constructor.ModFlags before probing for it. This makes the
23186 compiler report 514, 515 and 132 (the code was there, but got
23189 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23190 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23191 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23193 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23195 * enum.cs: create the enum static fields using the enum type.
23197 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23199 * class.cs: don't try to create the ParamBuilder for the return
23200 type if it's not needed (and handle it breaking for the ms runtime
23203 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23205 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23207 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23209 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23210 the command. This showed up while compiling the JANET source
23211 code, which used \r as its only newline separator.
23213 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23215 * class.cs (Method.Define): If we are an operator (because it
23216 reuses our code), then set the SpecialName and HideBySig. #36128
23218 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23220 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23221 exception, report error 120 `object reference required'.
23223 * driver.cs: Add --pause option, used during to measure the size
23224 of the process as it goes with --timestamp.
23226 * expression.cs (Invocation.DoResolve): Do not allow methods with
23227 SpecialName to be invoked.
23229 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23231 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23232 number before adding it.
23234 2002-12-21 Ravi Pratap <ravi@ximian.com>
23236 * ecore.cs (StandardImplicitConversion): When in an unsafe
23237 context, we allow conversion between void * to any other pointer
23238 type. This fixes bug #35973.
23240 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23242 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23243 is not thrown when extensionless outputs are used
23245 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23247 * rootcontext.cs: fixed compilation of corlib.
23249 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23251 * attribute.cs (Attributes.Contains): Add new method.
23253 * class.cs (MethodCore.LabelParameters): if the parameter is an
23254 `out' parameter, check that no attribute `[In]' has been passed.
23256 * enum.cs: Handle the `value__' name in an enumeration.
23258 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23260 * decl.cs: Added special case to allow overrides on "protected
23263 2002-12-18 Ravi Pratap <ravi@ximian.com>
23265 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23266 since it makes much more sense.
23268 (Attributes.ctor): Don't require a Location parameter.
23270 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23272 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23273 since we already have that information per attribute.
23275 * everywhere : make appropriate changes.
23277 * class.cs (LabelParameters): Write the code which actually
23278 applies attributes to the return type. We can't do this on the MS
23279 .NET runtime so we flag a warning in the case an exception is
23282 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23284 * const.cs: Handle implicit null conversions here too.
23286 2002-12-17 Ravi Pratap <ravi@ximian.com>
23288 * class.cs (MethodCore.LabelParameters): Remove the extra
23289 Type [] parameter since it is completely unnecessary. Instead
23290 pass in the method's attributes so that we can extract
23291 the "return" attribute.
23293 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23295 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23296 of ignoring it and letting the compile continue.
23298 * typemanager.cs (ChangeType): use an extra argument to return an
23299 error condition instead of throwing an exception.
23301 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23303 * expression.cs (Unary.TryReduce): mimic the code for the regular
23304 code path. Perform an implicit cast in the cases where we can
23305 implicitly convert to one of the integral types, and then reduce
23306 based on that constant. This fixes bug #35483.
23308 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23310 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23312 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23314 * namespace.cs: fixed bug #35489.
23316 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23318 * class.cs: Remove some dead code.
23320 * cs-parser.jay: Estimate the number of methods needed
23321 (RootContext.MethodCount);
23323 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23324 numbers instead of StringBuilders.
23326 * support.cs (PtrHashtable): Add constructor with initial size;
23327 We can now reduce reallocations of the method table.
23329 2002-12-10 Ravi Pratap <ravi@ximian.com>
23331 * attribute.cs (ApplyAttributes): Keep track of the emitted
23332 attributes on a per-target basis. This fixes bug #35413.
23334 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23336 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23337 default to the Windows 1252 encoding.
23339 (UnixParseOption): Support version, thanks to Alp for the missing
23342 * AssemblyInfo.cs: Add nice assembly information.
23344 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23347 * cs-parser.jay: Allow a trailing comma before the close bracked
23348 in the attribute_section production.
23350 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23351 address of the instance was being taken, I will take this out,
23352 because we take the address of the object immediately here.
23354 2002-12-09 Ravi Pratap <ravi@ximian.com>
23356 * typemanager.cs (AreMultipleAllowed): Take care of the most
23357 obvious case where attribute type is not in the current assembly -
23360 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23362 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23363 definitions, instead of doing that afterwards.
23365 Also we use a nice little hack, depending on the constructor, we
23366 know if we are a "composed" name or a simple name. Hence, we
23367 avoid the IndexOf test, and we avoid
23369 * codegen.cs: Add code to assist in a bug reporter to track down
23370 the source of a compiler crash.
23372 2002-12-07 Ravi Pratap <ravi@ximian.com>
23374 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23375 types have been emitted for a given element and flag an error
23376 if something which does not have AllowMultiple set is used more
23379 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23380 attribute types and their corresponding AllowMultiple properties
23382 (AreMultipleAllowed): Check the property for a given type.
23384 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23385 property in the case we have a TypeContainer.
23387 (Attributes.AddAttribute): Detect duplicates and just skip on
23388 adding them. This trivial fix catches a pretty gross error in our
23389 attribute emission - global attributes were being emitted twice!
23391 Bugzilla bug #33187 is now fixed.
23393 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23395 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23396 instead of pp_and).
23398 * expression.cs (Binary.ResolveOperator): I can only use the
23399 Concat (string, string, string) and Concat (string, string,
23400 string, string) if the child is actually a concatenation of
23403 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23405 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23406 context where we need a 2-character lookahead.
23408 * pending.cs (PendingImplementation): Rework so we can keep track
23409 of interface types all the time, and flag those which were
23410 implemented by parents as optional.
23412 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23414 * expression.cs (Binary.ResolveOperator): Use
23415 String.Concat(string,string,string) or
23416 String.Concat(string,string,string,string) when possible.
23418 * typemanager: More helper methods.
23421 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23423 * pending.cs: remove the bogus return from GetMissingInterfaces()
23424 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23426 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23428 * namespace.cs: avoid duplicated 'using xxx' being added to
23429 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23430 when we get more than one 'using' statement for the same namespace.
23431 Report a CS0105 warning for it.
23433 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23435 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23436 of calling getChar/putback, uses internal knowledge of it.
23438 (xtoken): Reorder tokenizer so most common patterns are checked
23439 first. This reduces the compilation time in another 5% (from 8.11s
23440 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23442 The parsing time is 22% of the compilation in mcs, and from that
23443 64% is spent on the tokenization process.
23445 I tried using a binary search for keywords, but this is slower
23446 than the hashtable. Another option would be to do a couple of
23449 * Not use a StringBuilder, instead use an array of chars,
23450 with a set value. Notice that this way we could catch
23451 the 645 error without having to do it *afterwards*.
23453 * We could write a hand-parser to avoid the hashtable
23454 compares altogether.
23456 The identifier consumption process takes 37% of the tokenization
23457 time. Another 15% is spent on is_number. 56% of the time spent
23458 on is_number is spent on Int64.Parse:
23460 * We could probably choose based on the string length to
23461 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23464 Another 3% is spend on wrapping `xtoken' in the `token' function.
23466 Handle 0xa0 as whitespace (#34752)
23468 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23470 * typemanager.cs (IsCLRType): New routine to tell whether a type
23471 is one of the builtin types.
23473 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23474 typecode in more places instead of doing pointer comparissions.
23475 We could leverage some knowledge about the way the typecodes are
23478 New code to cache namespaces in assemblies, it is currently not
23479 invoked, to be used soon.
23481 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23483 * expression.cs (Binary.ResolveOperator): specially handle
23484 strings, and do not perform user-defined operator overloading for
23487 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23489 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23490 internalcall as it is a pretty simple operation; Avoid whenever
23491 possible to call Char.IsLetter.
23493 (consume_identifier): Cut by half the number of
23494 hashtable calls by merging the is_keyword and GetKeyword behavior.
23496 Do not short-circuit, because if we do, we
23497 report errors (ie, #if false && true would produce an invalid
23501 2002-11-24 Martin Baulig <martin@ximian.com>
23503 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23504 check constant ranges and report a CS0221. Fixes #33186.
23506 2002-11-24 Martin Baulig <martin@ximian.com>
23508 * cs-parser.jay: Make this work for uninitialized variable
23509 declarations in the `for' initializer. Fixes #32416.
23511 2002-11-24 Martin Baulig <martin@ximian.com>
23513 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23514 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23516 2002-11-24 Martin Baulig <martin@ximian.com>
23518 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23519 argument; if true, we also check for user-defined conversions.
23520 This is only needed if both arguments are of a user-defined type.
23521 Fixes #30443, added test-175.cs.
23522 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23524 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23526 2002-11-24 Martin Baulig <martin@ximian.com>
23528 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23529 function to get the store opcode.
23530 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23531 only emit the Ldelema if the store opcode is Stobj. You must run
23532 both test-34 and test-167 to test this. Fixes #34529.
23534 2002-11-23 Martin Baulig <martin@ximian.com>
23536 * ecore.cs (Expression.MemberLookup): Added additional
23537 `qualifier_type' argument which is used when we're being called
23538 from MemberAccess.DoResolve() and null if we're called from a
23540 (Expression.MemberLookupFailed): New method to report errors; this
23541 does the CS1540 check and reports the correct error message.
23543 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23544 argument for the CS1540 check and redone the way how we're dealing
23545 with private members. See the comment in the source code for details.
23546 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23547 `closure_start_type' to `closure_qualifier_type' and check whether
23548 it's not null. It was not this filter being broken, it was just
23549 being called with the wrong arguments.
23551 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23552 and pass it the correct `qualifier_type'; this also does the error
23555 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23557 * expression.cs (Invocation.EmitParams): If the we are dealing
23558 with a non-built-in value type, load its address as well.
23560 (ArrayCreation): Use a a pretty constant instead
23561 of the hardcoded value 2. Use 6 instead of 2 for the number of
23562 static initializers.
23564 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23565 because they are not really value types, just glorified integers.
23567 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23569 * ecore.cs: Remove redundant code for enumerations, make them use
23570 the same code path as everything else, fixes the casting issue
23571 with enumerations in Windows.Forms.
23573 * attribute.cs: Do only cast to string if it is a string, the
23574 validation happens later.
23576 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23577 people upgrade their corlibs.
23579 * ecore.cs: Oops, enumerations were not following the entire code path
23581 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23583 * typemanager.cs (FilterWithClosure): Commented out the test for
23584 1540 in typemanager.cs, as it has problems when accessing
23585 protected methods from a parent class (see test-174.cs).
23587 * attribute.cs (Attribute.ValidateGuid): new method.
23588 (Attribute.Resolve): Use above.
23590 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23592 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23594 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23595 handling for enumerations, as we only needed the TypeContainer
23596 functionality to begin with (this is required for the fix below to
23597 work for enums that reference constants in a container class for
23600 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23602 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23603 a valid TypeBuilder to perform lookups on.o
23605 * class.cs (InheritableMemberSignatureCompare): Use true in the
23606 call to GetGetMethod and GetSetMethod, because we are comparing
23607 the signature, and we need to get the methods *even* if they are
23610 (PropertyBase.CheckBase): ditto.
23612 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23613 GotoCase.Resolve): Use Peel on EmpytCasts.
23615 * ecore.cs (EmptyCast): drop child, add Peel method.
23617 2002-11-17 Martin Baulig <martin@ximian.com>
23619 * ecore.cs (EmptyCast.Child): New public property.
23621 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23622 label resolved to an EmptyCast. Fixes #34162.
23623 (GotoCase.Resolve): Likewise.
23624 (Block.EmitMeta): Likewise.
23626 2002-11-17 Martin Baulig <martin@ximian.com>
23628 * expression.cs (Invocation.BetterConversion): Prefer int over
23629 uint; short over ushort; long over ulong for integer literals.
23630 Use ImplicitConversionExists instead of StandardConversionExists
23631 since we also need to check for user-defined implicit conversions.
23632 Fixes #34165. Added test-173.cs.
23634 2002-11-16 Martin Baulig <martin@ximian.com>
23636 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23637 with the `true' and `false' literals. Fixes #33151.
23639 2002-11-16 Martin Baulig <martin@ximian.com>
23641 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23642 October 22nd; don't do the cs1540 check for static members.
23644 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23645 now using our own filter here and doing the cs1540 check again.
23647 2002-11-16 Martin Baulig <martin@ximian.com>
23649 * support.cs (InternalParameters): Don't crash if we don't have
23650 any fixed parameters. Fixes #33532.
23652 2002-11-16 Martin Baulig <martin@ximian.com>
23654 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23655 when looking up static methods to make this work on Windows.
23658 2002-11-16 Martin Baulig <martin@ximian.com>
23660 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23661 a setter rather than using PropertyInfo.CanWrite.
23663 2002-11-15 Nick Drochak <ndrochak@gol.com>
23665 * class.cs: Allow acces to block member by subclasses. Fixes build
23668 2002-11-14 Martin Baulig <martin@ximian.com>
23670 * class.cs (Constructor.Emit): Added the extern/block check.
23673 2002-11-14 Martin Baulig <martin@ximian.com>
23675 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23676 iteration while looking for indexers, this is needed because the
23677 indexer may have a different name in our base classes. Fixed the
23678 error reporting (no indexers at all, not get accessor, no
23679 overloaded match). Fixes bug #33089.
23680 (IndexerAccess.DoResolveLValue): Likewise.
23682 2002-11-14 Martin Baulig <martin@ximian.com>
23684 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23685 indexers. Fixes the first part of bug #33089.
23686 (MethodSignature.InheritableMemberSignatureCompare): Added support
23689 2002-11-13 Ravi Pratap <ravi@ximian.com>
23691 * attribute.cs (Attribute.Resolve): Catch the
23692 NullReferenceException and report it since it isn't supposed to
23695 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23697 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23698 LogicalOr and LogicalAnd that can benefit from recursively
23699 handling EmitBranchable. The code now should be nice for Paolo.
23701 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23703 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23704 the Type lookups, as we perform quite a number of lookups on
23705 non-Types. This can be removed once we can deterministically tell
23706 whether we have a type or a namespace in advance.
23708 But this might require special hacks from our corlib.
23712 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23713 and double which avoids a conversion from an integer to a double.
23715 * expression.cs: tiny optimization, avoid calling IsConstant,
23716 because it effectively performs the lookup twice.
23718 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23720 But a bogus return here to keep the semantics of the old code
23721 until the Mono runtime is fixed.
23723 * pending.cs (GetMissingInterfaces): New method used to remove all
23724 the interfaces that are already implemented by our parent
23725 classes from the list of pending methods.
23727 * interface.cs: Add checks for calls after ResolveTypeExpr.
23729 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23731 * class.cs (Class.Emit): Report warning 67: event not used if the
23732 warning level is beyond 3.
23734 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23735 being a NullLiteral.
23737 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23740 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23741 path that might fail if a type can not be resolved.
23743 * expression.cs (Binary.Emit): Emit unsigned versions of the
23746 * driver.cs: use error 5.
23748 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23750 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23752 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23754 * cs-parser.jay (switch_section): A beautiful patch from Martin
23755 Baulig that fixed 33094.
23757 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23759 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23760 Check whether the base is abstract and report an error if so.
23762 * expression.cs (IndexerAccess.DoResolveLValue,
23763 IndexerAccess.DoResolve): ditto.
23765 (Invocation.DoResolve): ditto.
23767 (Invocation.FullMethodDesc): Improve the report string.
23769 * statement.cs (Block): Eliminate IsVariableDefined as it is
23770 basically just a wrapper for GetVariableInfo.
23772 * ecore.cs (SimpleName): Use new
23774 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23775 type, as we return the actual parameter ref/unref state on a
23778 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23780 * support.cs: Return proper flags REF/OUT fixing the previous
23783 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23784 not used to mean `ref' but `ref or out' in ParameterReference
23786 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23787 full type signature instead of calling TypeManger.CSharpName
23790 * support.cs (InternalParameters.ParameterDesc): Do not compare
23791 directly to the modflags, because REF/OUT will actually be bitsets
23794 * delegate.cs (VerifyMethod): Check also the modifiers.
23796 * cs-tokenizer.cs: Fix bug where floating point values with an
23797 exponent where a sign was missing was ignored.
23799 * driver.cs: Allow multiple assemblies to be specified in a single
23802 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23804 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23805 because identifiers after a parenthesis would end up in this kind
23806 of production, and we needed to desamiguate it for having casts
23809 (UserDefinedType *) xxx
23811 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23813 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23814 we should set on the Bindingflags.NonPublic, but not turn on
23815 private_ok. private_ok controls whether a Private member is
23816 returned (this is chekced on the filter routine), while the
23817 BindingFlags.NonPublic just controls whether private/protected
23818 will be allowed. This fixes the problem part of the problem of
23819 private properties being allowed to be used in derived classes.
23821 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23822 so we can call the children DoResolveLValue method (this will
23823 properly signal errors on lvalue assignments to base properties)
23825 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23826 getter are null, and we have a property info, we know that this
23827 happened because the lookup failed, so we report an error 122 for
23828 protection level violation.
23830 We also silently return if setter and getter are null in the
23831 resolve functions, this condition only happens if we have flagged
23832 the error before. This is the other half of the problem.
23834 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23835 not have accessibility information, that is why we were returning
23836 true in the filter function in typemanager.cs.
23838 To properly report 122 (property is inaccessible because of its
23839 protection level) correctly, we report this error in ResolveAccess
23840 by failing if both the setter and the getter are lacking (ie, the
23843 DoResolve and DoLResolve have been modified to check for both
23844 setter/getter being null and returning silently, the reason being
23845 that I did not want to put the knowledge about this error in upper
23848 int old = Report.Errors;
23849 x = new PropertyExpr (...);
23850 if (old != Report.Errors)
23855 So the property expr is returned, but it is invalid, so the error
23856 will be flagged during the resolve process.
23858 * class.cs: Remove InheritablePropertySignatureCompare from the
23859 class, as we no longer depend on the property signature to compute
23860 whether it is possible to implement a method or not.
23862 The reason is that calling PropertyInfo.GetGetMethod will return
23863 null (in .NET, in Mono it works, and we should change this), in
23864 cases where the Get Method does not exist in that particular
23869 class X { public virtual int A { get { return 1; } } }
23871 class Z : Y { public override int A { get { return 2; } } }
23873 Would fail in Z because the parent (Y) would not have the property
23874 defined. So we avoid this completely now (because the alternative
23875 fix was ugly and slow), and we now depend exclusively on the
23878 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23879 reference method, instead of using the property.
23881 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23882 routines are gone now.
23884 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23885 names, they were incorrectly named.
23887 * cs-tokenizer.cs: Return are more gentle token on failure.
23889 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23890 had an out-of-sync index variable, which caused it to remove from
23891 the list of pending methods the wrong method sometimes.
23893 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23895 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23896 CanWrite, because those refer to this particular instance of the
23897 property, and do not take into account the fact that we can
23898 override single members of a property.
23900 Constructor requires an EmitContext. The resolution process does
23901 not happen here, but we need to compute the accessors before,
23902 because the resolution does not always happen for properties.
23904 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23905 subclass, before we did not update this flag, but we did update
23908 (GetAccessors): Drop this routine, as it did not work in the
23909 presence of partially overwritten set/get methods.
23911 Notice that this broke the cs1540 detection, but that will require
23914 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23918 * driver.cs: issue a warning instead of an error if we don't support
23919 debugging for the platform. Also ignore a couple of errors that may
23920 arise when trying to write the symbols. Undo my previous patch.
23922 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23924 * driver.cs: ignore /debug switch except for Unix platforms.
23926 2002-10-23 Nick Drochak <ndrochak@gol.com>
23928 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23930 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23932 * driver.cs: Do not make mcs-debug conditional, so we do not break
23933 builds that use it.
23935 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23936 review this patch. But basically after all the children variables
23937 have been merged, the value of "Breaks" was not being set to
23938 new_breaks for Switch blocks. I think that it should be set after
23939 it has executed. Currently I set this to the value of new_breaks,
23940 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23941 conservative, but I do not understand this code very well.
23943 I did not break anything in the build, so that is good ;-)
23945 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23947 2002-10-20 Mark Crichton <crichton@gimp.org>
23949 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23951 2002-10-20 Nick Drochak <ndrochak@gol.com>
23953 * cfold.cs: Fixed compile blocker.
23955 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23957 * driver.cs: I was chekcing the key, not the file.
23959 2002-10-19 Ravi Pratap <ravi@ximian.com>
23961 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23962 message that we were generating - we just need to silently return
23965 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23967 * class.cs (Event.Define): Change my previous commit, as this
23968 breaks the debugger. This is a temporary hack, as it seems like
23969 the compiler is generating events incorrectly to begin with.
23971 * expression.cs (Binary.ResolveOperator): Added support for
23972 "U operator - (E x, E y)"
23974 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23977 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23978 init-only variables, but this path did not take into account that
23979 there might be also instance readonly variables. Correct this
23982 This fixes bug 32253
23984 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23987 * driver.cs: Change the extension for modules to `netmodule'
23989 * cs-parser.jay: Improved slightly the location tracking for
23990 the debugger symbols.
23992 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23993 modifiers that were specified instead of the hardcoded value
23994 (FamAndAssem). This was basically ignoring the static modifier,
23995 and others. Fixes 32429.
23997 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23998 fixed a bug in the process (32476)
24000 * expression.cs (ArrayAccess.EmitAssign): Patch from
24001 hwang_rob@yahoo.ca that fixes bug 31834.3
24003 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24005 * driver.cs: Make the module extension .netmodule.
24007 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24009 * driver.cs: Report an error if the resource file is not found
24010 instead of crashing.
24012 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24013 false, like Emit does.
24015 2002-10-16 Nick Drochak <ndrochak@gol.com>
24017 * typemanager.cs: Remove unused private member. Also reported mcs
24018 bug to report this as a warning like csc.
24020 2002-10-15 Martin Baulig <martin@gnome.org>
24022 * statement.cs (Statement.Emit): Made this a virtual method; emits
24023 the line number info and calls DoEmit().
24024 (Statement.DoEmit): New protected abstract method, formerly knows
24025 as Statement.Emit().
24027 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24029 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24031 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24032 have fixed a remaining problem: not every AddXXXX was adding a
24033 fully qualified name.
24035 Now everyone registers a fully qualified name in the DeclSpace as
24036 being defined instead of the partial name.
24038 Downsides: we are slower than we need to be due to the excess
24039 copies and the names being registered this way.
24041 The reason for this is that we currently depend (on the corlib
24042 bootstrap for instance) that types are fully qualified, because
24043 we dump all the types in the namespace, and we should really have
24044 types inserted into the proper namespace, so we can only store the
24045 basenames in the defined_names array.
24047 2002-10-10 Martin Baulig <martin@gnome.org>
24049 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24050 from bug #31834, see the bug report for a testcase which is
24053 2002-10-10 Martin Baulig <martin@gnome.org>
24055 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24056 flow analysis code for this.
24058 * statement.cs (Do, While, For): Tell the flow analysis code about
24060 (FlowBranching.UsageVector): Added support for infinite loops.
24061 (Block.Resolve): Moved the dead code elimination here and use flow
24064 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24066 * class.cs (Field.Define): Catch cycles on struct type
24069 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24070 fields if the fields are static. We only need to check instance
24073 * expression.cs (As.DoResolve): Test for reference type.
24075 * statement.cs (Using.ResolveExpression): Use
24076 ConvertImplicitRequired, not ConvertImplicit which reports an
24078 (Using.ResolveLocalVariableDecls): ditto.
24080 * expression.cs (Binary.ResolveOperator): Report errors in a few
24081 places where we had to.
24083 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24085 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24087 * expression.cs: Use StoreFromPtr instead of extracting the type
24088 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24090 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24091 an enumeration value to a System.Enum, but System.Enum is not a
24092 value type, but an class type, so we need to box.
24094 (Expression.ConvertExplicit): One codepath could return
24095 errors but not flag them. Fix this. Fixes #31853
24097 * parameter.cs (Resolve): Do not allow void as a parameter type.
24099 2002-10-06 Martin Baulig <martin@gnome.org>
24101 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24102 if it's a class type and not a struct. Fixes #31815.
24104 2002-10-06 Martin Baulig <martin@gnome.org>
24106 * statement.cs: Reworked the flow analysis code a bit to make it
24107 usable for dead code elimination.
24109 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24111 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24113 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24115 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24116 to fix the test 165, will investigate deeper.
24118 2002-10-04 Martin Baulig <martin@gnome.org>
24120 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24121 finally blocks actually work.
24122 (Try.Resolve): We don't need to create a sibling for `finally' if
24123 there is no finally block.
24125 2002-10-04 Martin Baulig <martin@gnome.org>
24127 * class.cs (Constructor.Define): The default accessibility for a
24128 non-default constructor is private, not public.
24130 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24132 * class.cs (Constructor): Make AllowedModifiers public, add
24135 * cs-parser.jay: Perform the modifiers test here, as the
24136 constructor for the Constructor class usually receives a zero
24137 because of the way we create it (first we create, later we
24138 customize, and we were never checking the modifiers).
24140 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24141 is a version of LookupTypeReflection that includes the type-name
24142 cache. This can be used as a fast path for functions that know
24143 the fully qualified name and are only calling into *.GetType() to
24144 obtain a composed type.
24146 This is also used by TypeManager.LookupType during its type
24149 (LookupType): We now also track the real type name, as sometimes
24150 we can get a quey for the real type name from things like
24151 ComposedCast. This fixes bug 31422.
24153 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24154 complete type fullname, it does not have to go through the type
24155 resolution system to obtain the composed version of the type (for
24156 obtaining arrays or pointers).
24158 (Conditional.Emit): Use the EmitBoolExpression to
24159 generate nicer code, as requested by Paolo.
24161 (ArrayCreation.CheckIndices): Use the patch from
24162 hwang_rob@yahoo.ca to validate the array initializers.
24164 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24166 * class.cs (ConstructorInitializer.Emit): simplify code by using
24167 Invocation.EmitCall, and at the same time, fix the bugs in calling
24168 parent constructors that took variable arguments.
24170 * ecore.cs (Expression.ConvertNumericExplicit,
24171 Expression.ImplicitNumericConversion): Remove the code that
24172 manually wrapped decimal (InternalTypeConstructor call is now gone
24175 * expression.cs (Cast.TryReduce): Also handle decimal types when
24176 trying to perform a constant fold on the type.
24178 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24180 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24181 that only turned off an error report, and did nothing else.
24183 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24185 * driver.cs: Handle and ignore /fullpaths
24187 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24189 * expression.cs (Binary.ResolveOperator): Catch the case where
24190 DoNumericPromotions returns true,
24192 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24194 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24196 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24199 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24201 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24202 conversion exists, but it is also required that the conversion be
24203 performed. This manifested in "(Type64Enum) 2".
24205 * class.cs (TypeManager.AddMethod): The fix is not to change
24206 AddEnum, because that one was using a fully qualified name (every
24207 DeclSpace derivative does), but to change the AddMethod routine
24208 that was using an un-namespaced name. This now correctly reports
24209 the duplicated name.
24211 Revert patch until I can properly fix it. The issue
24212 is that we have a shared Type space across all namespaces
24213 currently, which is wrong.
24215 Options include making the Namespace a DeclSpace, and merge
24216 current_namespace/current_container in the parser.
24218 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24220 * cs-parser.jay: Improve error reporting when we get a different
24221 kind of expression in local_variable_type and
24222 local_variable_pointer_type.
24224 Propagate this to avoid missleading errors being reported.
24226 * ecore.cs (ImplicitReferenceConversion): treat
24227 TypeManager.value_type as a target just like object_type. As
24232 Is valid, and needs to result in the int 1 being boxed before it
24233 is assigned to the value type v.
24235 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24236 to validate the enumeration name.
24238 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24239 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24240 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24242 * ecore.cs (TryImplicitIntConversion): When doing an
24243 implicit-enumeration-conversion, check if the type is 64-bits and
24244 perform a conversion before passing to EnumConstant.
24246 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24248 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24249 report ambiguous type references. Unlike the MS version, we
24250 report what the ambiguity is. Innovation at work ;-)
24252 (DeclSpace.FindType): Require a location argument to
24253 display when we display an ambiguous error.
24255 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24257 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24259 * expression.cs (EmitDynamicInitializers): Apply patch from
24260 hwang_rob@yahoo.ca that fixes the order in which we emit our
24263 2002-09-21 Martin Baulig <martin@gnome.org>
24265 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24266 delegate takes no arguments.
24268 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24270 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24273 * expression.cs: Extract the underlying type.
24275 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24277 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24279 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24281 * class.cs (TypeContainer.DefineType): We can not use the nice
24282 PackingSize with the size set to 1 DefineType method, because it
24283 will not allow us to define the interfaces that the struct
24286 This completes the fixing of bug 27287
24288 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24289 means also structs. This fixes part of the problem.
24290 (Expresion.ImplicitReferenceConversionExists): ditto.
24292 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24293 error if there were no errors reported during the type lookup
24294 process, to avoid duplicates or redundant errors. Without this
24295 you would get an ambiguous errors plus a type not found. We have
24296 beaten the user enough with the first error.
24298 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24301 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24302 during the resolution process, stop the lookup, this avoids
24303 repeated error reports (same error twice).
24305 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24307 * typemanager.cs (LookupType): Redo the type lookup code to match
24308 the needs of System.Reflection.
24310 The issue is that System.Reflection requires references to nested
24311 types to begin with a "+" sign instead of a dot. So toplevel
24312 types look like: "NameSpace.TopLevelClass", and nested ones look
24313 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24316 2002-09-19 Martin Baulig <martin@gnome.org>
24318 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24319 says that a method always returns or always throws an exception,
24320 don't report the CS0161.
24322 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24323 set `Returns = new_returns'.
24325 2002-09-19 Martin Baulig <martin@gnome.org>
24327 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24328 to an enum constant, check for a CS0176.
24330 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24332 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24333 for operators that must be in pairs and report errors.
24335 * ecore.cs (SimpleName.DoResolveType): During the initial type
24336 resolution process, when we define types recursively, we must
24337 check first for types in our current scope before we perform
24338 lookups in the enclosing scopes.
24340 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24342 (Invocation.VerifyArgumentsCompat): Call
24343 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24344 I thought we were supposed to always call this, but there are a
24345 few places in the code where we dont do it.
24347 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24349 * driver.cs: Add support in -linkres and -resource to specify the
24350 name of the identifier.
24352 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24354 * ecore.cs (StandardConversionExists): Sync with the conversion
24355 code: allow anything-* to void* conversions.
24357 (FindMostSpecificSource): Use an Expression argument
24358 instead of a Type, because we might be handed over a Literal which
24359 gets a few more implicit conversions that plain types do not. So
24360 this information was being lost.
24362 Also, we drop the temporary type-holder expression when not
24365 2002-09-17 Martin Baulig <martin@gnome.org>
24367 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24368 this is an explicit interface implementation.
24370 2002-09-17 Martin Baulig <martin@gnome.org>
24372 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24373 different `IndexerName' attributes.
24375 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24376 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24377 virtual CommonResolve().
24379 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24381 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24382 and convert that to the UnderlyingType.
24384 * statement.cs (Foreach.Resolve): Indexers are just like variables
24385 or PropertyAccesses.
24387 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24388 inside quoted strings, we were not doing this before.
24390 2002-09-16 Martin Baulig <martin@gnome.org>
24392 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24393 resolve it. This is needed for the definite assignment check of the
24394 instance expression, fixes bug #29846.
24395 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24397 2002-09-16 Nick Drochak <ndrochak@gol.com>
24399 * parameter.cs: Fix compile error. Cannot reference static member
24400 from an instance object. Is this an mcs bug?
24402 2002-09-14 Martin Baulig <martin@gnome.org>
24404 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24405 multiple times. Fixes bug #30295, added test-166.cs.
24407 2002-09-14 Martin Baulig <martin@gnome.org>
24409 * statement.cs (Block.Emit): Don't emit unreachable code.
24410 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24411 `break' statements.
24412 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24414 2002-09-14 Martin Baulig <martin@gnome.org>
24416 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24419 2002-09-14 Martin Baulig <martin@gnome.org>
24421 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24422 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24423 be false on the ms runtime.
24425 2002-09-13 Martin Baulig <martin@gnome.org>
24427 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24428 the CS0038 error message.
24430 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24432 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24433 constant inside, return it.
24435 2002-09-12 Martin Baulig <martin@gnome.org>
24437 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24438 implicit conversion can be done between enum types.
24440 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24441 check whether an implicit conversion to the current enum's UnderlyingType
24442 exists and report an error if not.
24444 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24445 without debugging support.
24447 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24448 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24450 2002-09-12 Martin Baulig <martin@gnome.org>
24452 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24454 * ecore.cs (IMemberExpr.DeclaringType): New property.
24455 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24456 nonstatic member of an outer type (CS0038).
24458 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24460 * driver.cs: Activate the using-error detector at warning level
24461 4 (at least for MS-compatible APIs).
24463 * namespace.cs (VerifyUsing): Small buglett fix.
24465 * pending.cs (PendingImplementation): pass the container pointer.
24467 * interface.cs (GetMethods): Allow for recursive definition. Long
24468 term, I would like to move every type to support recursive
24469 definitions, not the current ordering mechanism that we have right
24472 The situation is this: Attributes are handled before interfaces,
24473 so we can apply attributes to interfaces. But some attributes
24474 implement interfaces, we will now handle the simple cases
24475 (recursive definitions will just get an error).
24477 * parameter.cs: Only invalidate types at the end if we fail to
24480 2002-09-09 Martin Baulig <martin@gnome.org>
24482 * ecore.cs (PropertyExpr.Emit): Also check for
24483 TypeManager.system_int_array_get_length so this'll also work when
24484 compiling corlib. Fixes #30003.
24486 2002-09-09 Martin Baulig <martin@gnome.org>
24488 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24489 and throw an exception if we can't get the type's size. Fixed #30040,
24492 2002-09-09 Martin Baulig <martin@gnome.org>
24494 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24496 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24497 context. Fixes bug #30027.
24499 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24500 virtual functions. Fixes bug #30043, added test-164.cs.
24502 2002-09-08 Ravi Pratap <ravi@ximian.com>
24504 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24506 2002-09-08 Nick Drochak <ndrochak@gol.com>
24508 * driver.cs: Use an object to get the windows codepage since it's not a
24511 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24513 * statement.cs (For.Emit): for infinite loops (test == null)
24514 return whether there is a break inside, not always "true".
24516 * namespace.cs (UsingEntry): New struct to hold the name of the
24517 using definition, the location where it is defined, and whether it
24518 has been used in a successful type lookup.
24520 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24525 2002-09-06 Ravi Pratap <ravi@ximian.com>
24527 * attribute.cs : Fix incorrect code which relied on catching
24528 a NullReferenceException to detect a null being passed in
24529 where an object was expected.
24531 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24533 * statement.cs (Try): flag the catch variable as assigned
24535 * expression.cs (Cast): Simplified by using ResolveType instead of
24536 manually resolving.
24538 * statement.cs (Catch): Fix bug by using ResolveType.
24540 2002-09-06 Ravi Pratap <ravi@ximian.com>
24542 * expression.cs (BetterConversion): Special case for when we have
24543 a NullLiteral as the argument and we have to choose between string
24544 and object types - we choose string the way csc does.
24546 * attribute.cs (Attribute.Resolve): Catch the
24547 NullReferenceException and report error #182 since the Mono
24548 runtime no more has the bug and having this exception raised means
24549 we tried to select a constructor which takes an object and is
24552 2002-09-05 Ravi Pratap <ravi@ximian.com>
24554 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24555 message (1502, 1503) when we can't locate a method after overload
24556 resolution. This is much more informative and closes the bug
24559 * interface.cs (PopulateMethod): Return if there are no argument
24560 types. Fixes a NullReferenceException bug.
24562 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24563 expressions too. Previously we were checking only in one place for
24564 positional arguments leaving out named arguments.
24566 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24567 type to the enum type is not allowed. Remove code corresponding to
24570 (ConvertNumericExplicit): Allow explicit conversions from
24571 the underlying type to enum type. This precisely follows the spec
24572 and closes a bug filed by Gonzalo.
24574 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24577 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24579 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24581 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24582 it was important that we stored the right value after the
24583 reduction in `converted'.
24585 2002-09-04 Martin Baulig <martin@gnome.org>
24587 * location.cs (Location.SymbolDocument): Use full pathnames for the
24590 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24592 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24593 of the expression resolve mechanism, because that will catch the
24594 SimpleName error failures.
24596 (Conditional): If we can not resolve the
24597 expression, return, do not crash.
24599 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24602 (location): display token name instead of its number.
24604 2002-08-28 Martin Baulig <martin@gnome.org>
24606 * expression.cs (Binary.ResolveOperator): Don't silently return
24607 but return an error if an operator cannot be applied between two
24610 2002-08-28 Martin Baulig <martin@gnome.org>
24612 * class.cs (Constructor.Define): Set the permission attributes
24613 correctly instead of making all constructors public.
24615 2002-08-28 Martin Baulig <martin@gnome.org>
24617 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24618 for private members before reporting a CS0103; if we find anything,
24621 2002-08-28 Martin Baulig <martin@gnome.org>
24623 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24624 to check whether `closure_start_type == closure_invocation_type',
24625 we also need to check whether `m.DeclaringType == closure_invocation_type'
24626 before bypassing the permission checks. We might be accessing
24627 protected/private members from the base class.
24628 (TypeManager.RealMemberLookup): Only set private_ok if private
24629 members were requested via BindingFlags.NonPublic.
24631 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24633 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24634 MethodGroupExpr.IsExplicitImpl if appropriate.
24635 (Invocation.DoResolve): Don't report the CS0120 for explicit
24636 interface implementations.
24638 2002-08-27 Martin Baulig <martin@gnome.org>
24640 * expression.cs (Invocation.DoResolve): If this is a static
24641 method and we don't have an InstanceExpression, we must report
24644 2002-08-25 Martin Baulig <martin@gnome.org>
24646 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24647 `==' between a valuetype and an object.
24649 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24651 * ecore.cs (TypeExpr): Provide a ToString method.
24653 2002-08-24 Martin Baulig <martin@gnome.org>
24655 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24656 now called proggie.dbg and it's a binary file.
24658 2002-08-23 Martin Baulig <martin@gnome.org>
24660 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24662 2002-08-23 Martin Baulig <martin@gnome.org>
24664 * struct.cs (MyStructInfo.ctor): Make this work with empty
24665 structs; it's not allowed to use foreach() on null.
24667 2002-08-23 Martin Baulig <martin@gnome.org>
24669 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24670 writer the full pathname of the generated assembly.
24672 2002-08-23 Martin Baulig <martin@gnome.org>
24674 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24675 A `finally' block never returns or breaks; improved handling of
24678 2002-08-23 Martin Baulig <martin@gnome.org>
24680 * statement.cs (Throw.Resolve): Allow `throw null'.
24682 2002-08-23 Martin Baulig <martin@gnome.org>
24684 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24685 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24686 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24687 MemberLookup would return a wrong event if this is an explicit
24688 interface implementation and the class has an event with the same
24691 2002-08-23 Martin Baulig <martin@gnome.org>
24693 * statement.cs (Block.AddChildVariableNames): New public method.
24694 (Block.AddChildVariableName): Likewise.
24695 (Block.IsVariableNameUsedInChildBlock): Likewise.
24696 (Block.AddVariable): Check whether a variable name has already
24697 been used in a child block.
24699 * cs-parser.jay (declare_local_variables): Mark all variable names
24700 from the current block as being used in a child block in the
24703 2002-08-23 Martin Baulig <martin@gnome.org>
24705 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24706 find the symbol writer.
24708 * driver.cs: csc also allows the arguments to /define being
24709 separated by commas, not only by semicolons.
24711 2002-08-23 Martin Baulig <martin@gnome.org>
24713 * interface.cs (Interface.GetMembers): Added static check for events.
24715 2002-08-15 Martin Baulig <martin@gnome.org>
24717 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24718 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24720 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24721 why the MethodData.EmitDestructor() change was necessary.
24723 2002-08-20 Martin Baulig <martin@gnome.org>
24725 * class.cs (TypeContainer.FindMembers): Added static check for events.
24727 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24729 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24730 use Type.GetEvents(), not Type.FindMembers().
24732 2002-08-20 Martin Baulig <martin@gnome.org>
24734 * decl.cs (MemberCache): Added a special method cache which will
24735 be used for method-only searched. This ensures that a method
24736 search will return a MethodInfo with the correct ReflectedType for
24739 2002-08-20 Martin Baulig <martin@gnome.org>
24741 * decl.cs (DeclSpace.FindMembers): Made this public.
24743 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24745 * delegate.cs: fixed build on windows.
24746 [FIXME: Filed as bug #29150: MCS must report these errors.]
24748 2002-08-19 Ravi Pratap <ravi@ximian.com>
24750 * ecore.cs (StandardConversionExists): Return a false
24751 if we are trying to convert the void type to anything else
24752 since that is not allowed.
24754 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24755 we flag error 70 in the event an event is trying to be accessed
24756 directly from outside the declaring type.
24758 2002-08-20 Martin Baulig <martin@gnome.org>
24760 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24761 MemberCache from typemanager.cs to decl.cs.
24763 2002-08-19 Martin Baulig <martin@gnome.org>
24765 * class.cs (TypeContainer): Implement IMemberContainer.
24766 (TypeContainer.DefineMembers): Create the MemberCache.
24767 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24768 return public members if BindingFlags.Public was given, check
24769 whether members are static.
24771 2002-08-16 Martin Baulig <martin@gnome.org>
24773 * decl.cs (DeclSpace.Define): Splitted this in Define and
24774 DefineMembers. DefineMembers is called first and initializes the
24777 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24778 DefineMembers() on all our DeclSpaces.
24780 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24781 but call DefineMembers() on all nested interfaces. We call their
24782 Define() in our new Define() function.
24784 * interface.cs (Interface): Implement IMemberContainer.
24785 (Interface.Define): Moved all code except the attribute stuf to
24787 (Interface.DefineMembers): Initialize the member cache.
24789 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24790 need this anymore since we can use MemberCache.FindMembers directly.
24792 2002-08-19 Martin Baulig <martin@gnome.org>
24794 * typemanager.cs (MemberCache): When creating the cache for an
24795 interface type, add all inherited members.
24796 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24797 to `out bool used_cache' and documented it.
24798 (TypeManager.MemberLookup): If we already used the cache in the first
24799 iteration, we don't need to do the interfaces check.
24801 2002-08-19 Martin Baulig <martin@gnome.org>
24803 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24804 here from IMemberFinder and don't implement this interface anymore.
24805 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24807 * typemanager.cs (IMemberFinder): This interface is now only used by
24808 classes which actually support the member cache.
24809 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24810 since we only put DeclSpaces into this Hashtable.
24811 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24812 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24814 2002-08-16 Martin Baulig <martin@gnome.org>
24816 * typemanager.cs (ICachingMemberFinder): Removed.
24817 (IMemberFinder.MemberCache): New property.
24818 (TypeManager.FindMembers): Merged this with RealFindMembers().
24819 This function will never be called from TypeManager.MemberLookup()
24820 so we can't use the cache here, just the IMemberFinder.
24821 (TypeManager.MemberLookup_FindMembers): Check whether the
24822 IMemberFinder has a MemberCache and call the cache's FindMembers
24824 (MemberCache): Rewrote larger parts of this yet another time and
24825 cleaned it up a bit.
24827 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24829 * driver.cs (LoadArgs): Support quoting.
24831 (Usage): Show the CSC-like command line arguments.
24833 Improved a few error messages.
24835 2002-08-15 Martin Baulig <martin@gnome.org>
24837 * typemanager.cs (IMemberContainer.Type): New property.
24838 (IMemberContainer.IsInterface): New property.
24840 The following changes are conditional to BROKEN_RUNTIME, which is
24841 defined at the top of the file.
24843 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24844 class'es members, but add all members from TypeHandle.ObjectType
24845 if we're an interface.
24846 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24847 is the current type.
24848 (MemberCache.CacheEntry.Container): Removed this field.
24849 (TypeHandle.GetMembers): Include inherited members.
24851 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24853 * typemanager.cs: fixed compilation and added a comment on a field that
24856 2002-08-15 Martin Baulig <martin@gnome.org>
24858 * class.cs (ConstructorInitializer.Resolve): In the
24859 Expression.MemberLookup call, use the queried_type as
24862 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24863 declared' attribute, it's always true.
24864 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24865 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24866 temporary wrapper for FindMembers which tells MemberLookup whether
24867 members from the base classes are included in the return value.
24868 This will go away soon.
24869 (TypeManager.MemberLookup): Use this temporary hack here; once the
24870 new MemberCache is completed, we don't need to do the DeclaredOnly
24871 looping here anymore since the MemberCache will take care of this.
24872 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24873 (MemberCache): When creating the MemberCache for a class, get
24874 members from the current class and all its base classes.
24875 (MemberCache.CacheEntry.Container): New field. This is a
24876 temporary hack until the Mono runtime is fixed to distinguish
24877 between ReflectedType and DeclaringType. It allows us to use MCS
24878 with both the MS runtime and the unfixed Mono runtime without
24879 problems and without accecting performance.
24880 (MemberCache.SearchMembers): The DeclaredOnly looping from
24881 TypeManager.MemberLookup is now done here.
24883 2002-08-14 Martin Baulig <martin@gnome.org>
24885 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24886 Type.GetFields on dynamic types but get the fields from the
24887 corresponding TypeContainer.
24888 (MyStructInfo.GetStructInfo): Added check for enum types.
24890 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24891 (MemberList.SyncRoot): Implemented.
24892 (TypeManager.FilterWithClosure): No need to check permissions if
24893 closure_start_type == closure_invocation_type, don't crash if
24894 closure_invocation_type is null.
24896 2002-08-13 Martin Baulig <martin@gnome.org>
24898 Rewrote TypeContainer.FindMembers to use a member cache. This
24899 gives us a speed increase of about 35% for the self-hosting MCS
24900 build and of about 15-20% for the class libs (both on GNU/Linux).
24902 * report.cs (Timer): New class to get enhanced profiling. This
24903 whole class is "TIMER" conditional since it remarkably slows down
24906 * class.cs (MemberList): New class. This is an IList wrapper
24907 which we're now using instead of passing MemberInfo[]'s around to
24908 avoid copying this array unnecessarily.
24909 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24910 (ICachingMemberFinder, IMemberContainer): New interface.
24911 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24912 has already been checked, otherwise use it for the name comparision.
24913 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24914 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24915 if possible. Returns a MemberList, not a MemberInfo [].
24916 (TypeHandle): New class, implements IMemberContainer. We create
24917 one instance of this class per type, it contains a MemberCache
24918 which is used to do the member lookups.
24919 (MemberCache): New class. Each instance of this class contains
24920 all members of a type and a name-based hash table.
24921 (MemberCache.FindMembers): This is our new member lookup
24922 function. First, it looks up all members of the requested name in
24923 the hash table. Then, it walks this list and sorts out all
24924 applicable members and returns them.
24926 2002-08-13 Martin Baulig <martin@gnome.org>
24928 In addition to a nice code cleanup, this gives us a performance
24929 increase of about 1.4% on GNU/Linux - not much, but it's already
24930 half a second for the self-hosting MCS compilation.
24932 * typemanager.cs (IMemberFinder): New interface. It is used by
24933 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24934 Enum, Delegate or Interface.
24935 (TypeManager.finder_to_member_finder): New PtrHashtable.
24936 (TypeManager.finder_to_container): Removed.
24937 (TypeManager.finder_to_delegate): Removed.
24938 (TypeManager.finder_to_interface): Removed.
24939 (TypeManager.finder_to_enum): Removed.
24941 * interface.cs (Interface): Implement IMemberFinder.
24943 * delegate.cs (Delegate): Implement IMemberFinder.
24945 * enum.cs (Enum): Implement IMemberFinder.
24947 * class.cs (TypeContainer): Implement IMemberFinder.
24949 2002-08-12 Martin Baulig <martin@gnome.org>
24951 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24953 2002-08-12 Martin Baulig <martin@gnome.org>
24955 * ecore.cs (ITypeExpression): New interface for expressions which
24957 (TypeExpression): Renamed to TypeLookupExpression.
24958 (Expression.DoResolve): If we're doing a types-only lookup, the
24959 expression must implement the ITypeExpression interface and we
24960 call DoResolveType() on it.
24961 (SimpleName): Implement the new ITypeExpression interface.
24962 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24963 hack, the situation that we're only looking up types can't happen
24964 anymore when this method is called. Moved the type lookup code to
24965 DoResolveType() and call it.
24966 (SimpleName.DoResolveType): This ITypeExpression interface method
24967 is now doing the types-only lookup.
24968 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24969 (ResolveFlags): Added MaskExprClass.
24971 * expression.cs (MemberAccess): Implement the ITypeExpression
24973 (MemberAccess.DoResolve): Added support for a types-only lookup
24974 when we're called via ITypeExpression.DoResolveType().
24975 (ComposedCast): Implement the ITypeExpression interface.
24977 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24978 Expression.Resolve() with ResolveFlags.Type instead.
24980 2002-08-12 Martin Baulig <martin@gnome.org>
24982 * interface.cs (Interface.Define): Apply attributes.
24984 * attribute.cs (Attribute.ApplyAttributes): Added support for
24985 interface attributes.
24987 2002-08-11 Martin Baulig <martin@gnome.org>
24989 * statement.cs (Block.Emit): Only check the "this" variable if we
24990 do not always throw an exception.
24992 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24993 whether the property has a set accessor.
24995 2002-08-11 Martin Baulig <martin@gnome.org>
24997 Added control flow analysis support for structs.
24999 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25000 with control flow analysis turned off.
25001 (IVariable): New interface.
25002 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25003 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25004 (FieldExpr.DoResolve): Resolve the instance expression with flow
25005 analysis turned off and do the definite assignment check after the
25006 resolving when we know what the expression will resolve to.
25008 * expression.cs (LocalVariableReference, ParameterReference):
25009 Implement the new IVariable interface, only call the flow analysis
25010 code if ec.DoFlowAnalysis is true.
25011 (This): Added constructor which takes a Block argument. Implement
25012 the new IVariable interface.
25013 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25014 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25015 This does the definite assignment checks for struct members.
25017 * class.cs (Constructor.Emit): If this is a non-static `struct'
25018 constructor which doesn't have any initializer, call
25019 Block.AddThisVariable() to tell the flow analysis code that all
25020 struct elements must be initialized before control returns from
25023 * statement.cs (MyStructInfo): New public class.
25024 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25025 argument to this indexer. If non-zero, check an individual struct
25026 member, not the whole struct.
25027 (FlowBranching.CheckOutParameters): Check struct members.
25028 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25029 overloaded versions of these methods which take an additional
25030 `int field_idx' argument to check struct members.
25031 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25032 overloaded versions of these methods which take an additional
25033 `string field_name' argument to check struct member.s
25034 (VariableInfo): Implement the IVariable interface.
25035 (VariableInfo.StructInfo): New public property. Returns the
25036 MyStructInfo instance of the variable if it's a struct or null.
25037 (Block.AddThisVariable): New public method. This is called from
25038 Constructor.Emit() for non-static `struct' constructor which do
25039 not have any initializer. It creates a special variable for the
25040 "this" instance variable which will be checked by the flow
25041 analysis code to ensure that all of the struct's fields are
25042 initialized before control returns from the constructor.
25043 (UsageVector): Added support for struct members. If a
25044 variable/parameter is a struct with N members, we reserve a slot
25045 in the usage vector for each member. A struct is considered fully
25046 initialized if either the struct itself (slot 0) or all its
25047 members are initialized.
25049 2002-08-08 Martin Baulig <martin@gnome.org>
25051 * driver.cs (Driver.MainDriver): Only report an error CS5001
25052 if there were no compilation errors.
25054 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25055 `UnsafeContext' property to determine whether the parent is in
25056 unsafe context rather than checking the parent's ModFlags:
25057 classes nested in an unsafe class are unsafe as well.
25059 2002-08-08 Martin Baulig <martin@gnome.org>
25061 * statement.cs (UsageVector.MergeChildren): Distinguish between
25062 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25063 we return. Added test17() and test18() to test-154.cs.
25065 2002-08-08 Martin Baulig <martin@gnome.org>
25067 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25068 Family access, make sure the invoking type isn't a subclass of the
25069 queried type (that'd be a CS1540).
25071 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25072 this method which takes an additional `Type invocation_type'.
25074 * expression.cs (BaseAccess.DoResolve): Use the base type as
25075 invocation and query type.
25076 (MemberAccess.DoResolve): If the lookup failed and we're about to
25077 report a CS0122, try a lookup with the ec.ContainerType - if this
25078 succeeds, we must report a CS1540.
25080 2002-08-08 Martin Baulig <martin@gnome.org>
25082 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25083 (MethodGroupExpr): Implement the IMemberExpr interface.
25085 * expression (MemberAccess.ResolveMemberAccess): No need to have
25086 any special code for MethodGroupExprs anymore, they're now
25089 2002-08-08 Martin Baulig <martin@gnome.org>
25091 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25092 Family, FamANDAssem and FamORAssem permissions.
25093 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25095 2002-08-08 Martin Baulig <martin@gnome.org>
25097 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25098 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25101 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25103 * driver.cs: implemented /resource option to embed managed resources.
25105 2002-08-07 Martin Baulig <martin@gnome.org>
25107 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25108 (FieldBase.HasFieldInitializer): New public property.
25109 (FieldBase.GetInitializerExpression): New public method. Resolves and
25110 returns the field initializer and makes sure it is only resolved once.
25111 (TypeContainer.EmitFieldInitializers): Call
25112 FieldBase.GetInitializerExpression to get the initializer, this ensures
25113 that it isn't resolved multiple times.
25115 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25116 the resolving process (SimpleName/MemberLookup) that we're currently
25117 emitting a field initializer (which must not access any instance members,
25118 this is an error CS0236).
25120 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25121 argument, if the `IsFieldInitializer' flag is set, we must report and
25122 error CS0236 and not an error CS0120.
25124 2002-08-07 Martin Baulig <martin@gnome.org>
25126 * ecore.cs (IMemberExpr): New public interface.
25127 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25128 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25129 if the expression is an IMemberExpr.
25131 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25132 to be null, implicitly default to `this' if we're non-static in
25133 this case. Simplified the code a lot by using the new IMemberExpr
25134 interface. Also fixed bug #28176 here.
25136 2002-08-06 Martin Baulig <martin@gnome.org>
25138 * cs-parser.jay (SimpleLookup): Removed. We need to create
25139 ParameterReferences during semantic analysis so that we can do a
25140 type-only search when resolving Cast, TypeOf and SizeOf.
25141 (block): Pass the `current_local_parameters' to the Block's
25144 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25145 argument to the constructor.
25146 (ConstructorInitializer.Resolve): Create a temporary implicit
25147 block with the parameters.
25149 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25150 references here if we aren't doing a type-only search.
25152 * statement.cs (Block): Added constructor which takes a
25153 `Parameters parameters' argument.
25154 (Block.Parameters): New public property.
25156 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25157 to `Parameters' and made it public readonly.
25159 2002-08-06 Martin Baulig <martin@gnome.org>
25161 * ecore.cs (Expression.Warning): Made this public as well.
25163 * report.cs (Report.Debug): Print the contents of collections.
25165 2002-08-06 Martin Baulig <martin@gnome.org>
25167 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25168 used to tell Resolve() which kinds of expressions it may return.
25169 (Expression.Resolve): Added overloaded version of this method which
25170 takes a `ResolveFlags flags' argument. This can be used to tell
25171 Resolve() which kinds of expressions it may return. Reports a
25173 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25174 ResolveFlags.SimpleName.
25175 (Expression.Error118): Added overloaded version of this method which
25176 takes a `ResolveFlags flags' argument. It uses the flags to determine
25177 which kinds of expressions are allowed.
25179 * expression.cs (Argument.ResolveMethodGroup): New public method.
25180 Resolves an argument, but allows a MethodGroup to be returned.
25181 This is used when invoking a delegate.
25183 * TODO: Updated a bit.
25185 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25187 Fixed compilation with csc.
25189 * ecore.cs: Expression.Error made public. Is this correct? Should
25190 Warning be made public too?
25192 * expression.cs: use ea.Location instead of ea.loc.
25193 [FIXME: Filed as bug #28607: MCS must report these errors.]
25195 2002-08-06 Martin Baulig <martin@gnome.org>
25197 * ecore.cs (Expression.loc): Moved the location here instead of
25198 duplicating it in all derived classes.
25199 (Expression.Location): New public property.
25200 (Expression.Error, Expression.Warning): Made them non-static and
25201 removed the location argument.
25202 (Expression.Warning): Added overloaded version which takes an
25203 `int level' argument.
25204 (Expression.Error118): Make this non-static and removed the
25205 expression and location arguments.
25206 (TypeExpr): Added location argument to the constructor.
25208 * expression.cs (StaticCallExpr): Added location argument to
25210 (Indirection, PointerArithmetic): Likewise.
25211 (CheckedExpr, UnCheckedExpr): Likewise.
25212 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25213 (StringPtr): Likewise.
25216 2002-08-05 Martin Baulig <martin@gnome.org>
25218 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25220 * assign.cs (Assign.DoResolve): Check whether the source
25221 expression is a value or variable.
25223 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25224 while resolving the corresponding blocks.
25226 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25227 an error, don't silently return null.
25229 * statement.cs (Block.AddVariable): Do the error reporting here
25230 and distinguish between CS0128 and CS0136.
25231 (Block.DoResolve): Report all unused labels (warning CS0164).
25232 (LabeledStatement): Pass the location to the constructor.
25233 (LabeledStatement.HasBeenReferenced): New property.
25234 (LabeledStatement.Resolve): Set it to true here.
25236 * statement.cs (Return.Emit): Return success even after reporting
25237 a type mismatch error (CS0126 or CS0127), this is what csc does and
25238 it avoids confusing the users with any consecutive errors.
25240 2002-08-05 Martin Baulig <martin@gnome.org>
25242 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25244 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25246 * expression.cs (MemberAccess.DoResolve): Silently return if an
25247 error has already been reported.
25249 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25250 error has already been reported.
25252 2002-08-05 Martin Baulig <martin@gnome.org>
25254 * statement.cs (UsageVector): Only initialize the `parameters'
25255 vector if we actually have any "out" parameters.
25257 2002-08-05 Martin Baulig <martin@gnome.org>
25259 * expression.cs (Binary.ResolveOperator): When combining delegates,
25260 they must have the same type.
25262 2002-08-05 Martin Baulig <martin@gnome.org>
25264 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25265 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25266 work with the ms runtime and we also don't need it: if we're a
25267 PropertyBuilder and not in the `indexer_arguments' hash, then we
25268 are a property and not an indexer.
25270 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25271 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25272 since the latter one doesn't work with the ms runtime.
25274 2002-08-03 Martin Baulig <martin@gnome.org>
25276 Fixed bugs #27998 and #22735.
25278 * class.cs (Method.IsOperator): New public field.
25279 (Method.CheckBase): Report CS0111 if there's already a method
25280 with the same parameters in the current class. Report CS0508 when
25281 attempting to change the return type of an inherited method.
25282 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25283 and it's not marked abstract or extern.
25284 (PropertyBase): New abstract base class for Property and Indexer.
25285 (PropertyBase.CheckBase): Moved here from Property and made it work
25287 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25288 the same so we can reuse it there.
25289 (Property, Indexer): Derive from PropertyBase.
25290 (MethodSignature.inheritable_property_signature_filter): New delegate
25291 to find properties and indexers.
25293 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25294 argument and improved error reporting.
25296 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25297 EmptyReadOnlyParameters and made it a property.
25299 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25300 version of this method which takes a `PropertyInfo indexer'.
25301 (TypeManager.RegisterIndexer): New method.
25303 * class.cs: Added myself as author of this file :-)
25305 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25307 * class.cs: fixed compilation on windoze.
25309 2002-08-03 Martin Baulig <martin@gnome.org>
25311 * interface.cs (Interface.GetInterfaceBases): Check whether all
25312 base interfaces are at least as accessible than the current one.
25314 * class.cs (TypeContainer.GetClassBases): Check whether base types
25315 are at least as accessible than the current type.
25316 (TypeContainer.AsAccessible): Implemented and made non-static.
25317 (MemberBase.CheckParameters): Report errors if the accessibility
25320 * delegate.cs (Delegate.Delegate): The default visibility is
25321 internal for top-level types and private for nested types.
25322 (Delegate.Define): Report errors if the accessibility checks fail.
25324 * enum.cs (Enum.Enum): The default visibility is internal for
25325 top-level types and private for nested types.
25326 (Enum.DefineType): Compute the correct visibility.
25328 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25329 function which takes a `bool is_toplevel' instead of a TypeContainer.
25331 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25334 2002-08-02 Martin Baulig <martin@gnome.org>
25336 * expression.cs (LocalVariableReferenc): Added constructor which
25337 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25338 (LocalVariableReference.IsReadOnly): New property.
25339 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25340 variable is readonly, use our own readonly flag to do this; you can
25341 use the new constructor to get a writable reference to a read-only
25344 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25345 reference to the local variable.
25347 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25349 * rootcontext.cs (ResolveCore): Also include System.Exception
25351 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25352 we reach an EmptyStatement.
25354 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25357 * expression.cs (Binary.ResolveOperator): Check error result in
25360 use brtrue/brfalse directly and avoid compares to null.
25362 2002-08-02 Martin Baulig <martin@gnome.org>
25364 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25365 Fixes bug #28407, added test-155.cs.
25367 2002-08-01 Martin Baulig <martin@gnome.org>
25369 * class.cs (Event.EmitDefaultMethod): Make this work with static
25370 events. Fixes #28311, added verify-3.cs.
25372 2002-08-01 Martin Baulig <martin@gnome.org>
25374 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25375 `is_disposable' fields.
25376 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25377 `hm.is_disposable' if we're using the collection pattern.
25378 (Foreach.EmitCollectionForeach): Use the correct type for the
25379 enumerator's local variable, only emit the try/finally block if
25380 necessary (fixes #27713).
25382 2002-08-01 Martin Baulig <martin@gnome.org>
25384 * ecore.cs (Expression.report118): Renamed to Error118 and made
25387 * statement.cs (Throw.Resolve): Check whether the expression is of
25388 the correct type (CS0118) and whether the type derives from
25389 System.Exception (CS0155).
25390 (Catch.Resolve): New method. Do the type lookup here and check
25391 whether it derives from System.Exception (CS0155).
25392 (Catch.CatchType, Catch.IsGeneral): New public properties.
25394 * typemanager.cs (TypeManager.exception_type): Added.
25396 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25398 * driver.cs: Updated About function.
25400 2002-07-31 Martin Baulig <martin@gnome.org>
25402 Implemented Control Flow Analysis.
25404 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25405 (EmitContext.CurrentBranching): Added.
25406 (EmitContext.StartFlowBranching): Added.
25407 (EmitContext.EndFlowBranching): Added.
25408 (EmitContext.KillFlowBranching): Added.
25409 (EmitContext.IsVariableAssigned): Added.
25410 (EmitContext.SetVariableAssigned): Added.
25411 (EmitContext.IsParameterAssigned): Added.
25412 (EmitContext.SetParameterAssigned): Added.
25413 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25414 Added control flow analysis stuff here.
25416 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25417 resolve the expression as lvalue.
25418 (LocalVariableReference.DoResolve): Check whether the variable has
25419 already been assigned.
25420 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25421 the parameter as assigned here.
25422 (ParameterReference.DoResolve): Check whether the parameter has already
25424 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25425 expression as lvalue.
25427 * statement.cs (FlowBranching): New class for the flow analysis code.
25428 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25429 (LabeledStatement.IsDefined): New public property.
25430 (LabeledStatement.AddUsageVector): New public method to tell flow
25431 analyis that the label may be reached via a forward jump.
25432 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25434 (VariableInfo.Number): New public field. This is used by flow analysis
25435 to number all locals of a block.
25436 (Block.CountVariables): New public property. This is the number of
25437 local variables in this block (including the locals from all parent
25439 (Block.EmitMeta): Number all the variables.
25441 * statement.cs: Added flow analysis support to all classes.
25443 2002-07-31 Martin Baulig <martin@gnome.org>
25445 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25446 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25447 then use this argument.
25449 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25451 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25452 use this to specify /define options.
25454 2002-07-29 Martin Baulig <martin@gnome.org>
25456 * statement.cs (Fixed): Moved all code that does variable lookups
25457 and resolvings from Emit to Resolve.
25459 * statement.cs (For): Moved all code that does variable lookups
25460 and resolvings from Emit to Resolve.
25462 * statement.cs (Using): Moved all code that does variable lookups
25463 and resolvings from Emit to Resolve.
25465 2002-07-29 Martin Baulig <martin@gnome.org>
25467 * attribute.cs (Attribute.Resolve): Explicitly catch a
25468 System.NullReferenceException when creating the
25469 CustromAttributeBuilder and report a different warning message.
25471 2002-07-29 Martin Baulig <martin@gnome.org>
25473 * support.cs (ParameterData.ParameterName): Added method to
25474 get the name of a parameter.
25476 * typemanager.cs (TypeManager.IsValueType): New public method.
25478 2002-07-29 Martin Baulig <martin@gnome.org>
25480 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25481 is a flag which specifies that it's either ref or out.
25482 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25483 the out parameter to `out Parameter.Modifier mod', also set the
25484 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25486 * support.cs (InternalParameters.ParameterModifier): Distinguish
25487 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25488 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25490 * expression.cs (Argument.GetParameterModifier): Distinguish
25491 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25492 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25494 2002-07-29 Martin Baulig <martin@gnome.org>
25496 * expression.cs (ParameterReference.ParameterReference): Added
25497 `Location loc' argument to the constructor.
25499 * cs-parser.jay: Pass location to ParameterReference.
25501 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25503 * statement.cs (Try): Initialize the location.
25505 * cs-parser.jay: pass location to Try.
25507 * expression.cs (Unary.Reduce): Change the prototype to return
25508 whether a constant fold could be performed or not. The result is
25509 returned in an out parameters. In the case of Indirection and
25510 AddressOf, we want to perform the full tests.
25512 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25514 * statement.cs (Statement.Emit): Flag dead code.
25516 2002-07-27 Andrew Birkett <andy@nobugs.org>
25518 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25520 2002-07-27 Martin Baulig <martin@gnome.org>
25522 * class.cs (MethodData.Define): Put back call to
25523 TypeManager.AddMethod(), accidentally commented this out.
25525 * report.cs (Debug): New public method to print debugging information,
25526 this is `[Conditional ("DEBUG")]'.
25528 2002-07-26 Martin Baulig <martin@gnome.org>
25530 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25531 (switch_statement): Push the current_block to the switch_stack and
25532 pop it again when we're done with the switch.
25533 (switch_section): The new block is a child of the current_block.
25534 Fixes bug #24007, added test-152.cs.
25536 2002-07-27 Martin Baulig <martin@gnome.org>
25538 * expression.cs (Invocation.EmitArguments): When calling a varargs
25539 function with only its fixed arguments, we need to pass an empty
25542 2002-07-27 Martin Baulig <martin@gnome.org>
25544 Mono 0.13 has been released.
25546 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25548 * driver.cs: Rename --resource to --linkres, because that is what
25549 we do currently, we dont support --resource yet.
25551 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25553 2002-07-25 Martin Baulig <martin@gnome.org>
25555 * class.cs (MethodData): New public class. This is a `method builder'
25556 class for a method or one accessor of a Property/Indexer/Event.
25557 (MethodData.GetMethodFlags): Moved here from MemberBase.
25558 (MethodData.ApplyAttributes): Likewise.
25559 (MethodData.ApplyObsoleteAttribute): Likewise.
25560 (MethodData.ApplyConditionalAttribute): Likewise.
25561 (MethodData.ApplyDllImportAttribute): Likewise.
25562 (MethodData.CheckAbstractAndExternal): Likewise.
25563 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25564 (MethodData.Emit): Formerly known as Method.Emit().
25565 (MemberBase): Moved everything which was specific to a single
25566 accessor/method to MethodData.
25567 (Method): Create a new MethodData and call Define() and Emit() on it.
25568 (Property, Indexer, Event): Create a new MethodData objects for each
25569 accessor and call Define() and Emit() on them.
25571 2002-07-25 Martin Baulig <martin@gnome.org>
25573 Made MethodCore derive from MemberBase to reuse the code from there.
25574 MemberBase now also checks for attributes.
25576 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25577 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25579 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25580 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25581 (MemberBase.ApplyAttributes): New virtual method; applies the
25582 attributes to a method or accessor.
25583 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25584 (MemberBase.ApplyConditionalAttribute): Likewise.
25585 (MemberBase.ApplyDllImportAttribute): Likewise.
25586 (MemberBase.CheckAbstractAndExternal): Likewise.
25587 (MethodCore.ParameterTypes): This is now a property instead of a
25588 method, it's initialized from DoDefineParameters().
25589 (MethodCore.ParameterInfo): Removed the set accessor.
25590 (MethodCore.DoDefineParameters): New protected virtual method to
25591 initialize ParameterTypes and ParameterInfo.
25592 (Method.GetReturnType): We can now simply return the MemberType.
25593 (Method.GetMethodFlags): Override the MemberBase version and add
25594 the conditional flags.
25595 (Method.CheckBase): Moved some code from Define() here, call
25596 DoDefineParameters() here.
25597 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25598 here to avoid some larger code duplication.
25599 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25600 ensure that abstract and external accessors don't declare a body.
25602 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25603 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25604 lookup in the attribute's parent classes, so we need to abort as soon
25605 as we found the first match.
25606 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25607 the attribute has no arguments.
25609 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25612 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25614 * cs-parser.jay: reverted previous patch.
25616 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25618 * cs-parser.jay: fixed bug #22119.
25620 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25622 * attribute.cs: fixed compilation. The error was:
25623 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25624 be assigned to before control leaves the current method."
25625 [FIXME: Filed as bug #28186: MCS must report this error.]
25627 2002-07-25 Martin Baulig <martin@gnome.org>
25629 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25630 method to pull the condition name ouf of a Conditional attribute.
25631 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25632 the obsolete message and error flag out of an Obsolete attribute.
25634 * class.cs (Method.GetMethodFlags): New public method to get the
25635 TypeManager.MethodFlags for this method.
25636 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25638 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25639 if we're overriding a virtual function, set the new private variable
25640 `parent_method'; call the new TypeManager.AddMethod().
25642 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25643 the MethodBuilder and the Method in a PtrHashtable.
25644 (TypeManager.builder_to_method): Added for this purpose.
25645 (TypeManager.MethodFlags): Added IsObsoleteError.
25646 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25647 Obsolete and Conditional arguments in MethodBuilders. If we discover
25648 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25649 the message from the attribute.
25651 2002-07-24 Martin Baulig <martin@gnome.org>
25653 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25654 preprocessor directives, ensure that the argument to #define/#undef is
25655 exactly one identifier and that it's actually an identifier.
25657 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25660 2002-07-24 Martin Baulig <martin@gnome.org>
25662 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25663 initialize it to TypeManager.object_type in the constructor.
25664 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25665 of the `hm.get_current' method if we're using the collection pattern.
25666 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25667 for the explicit conversion to make it work when we're using the collection
25668 pattern and the `Current' property has a different return type than `object'.
25671 2002-07-24 Martin Baulig <martin@gnome.org>
25673 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25674 does not match, but don't report any errors. This method is called in
25675 order for all methods in a MethodGroupExpr until a matching method is
25676 found, so we don't want to bail out if the first method doesn't match.
25677 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25678 matches, report the 123. Fixes #28070.
25680 2002-07-24 Martin Baulig <martin@gnome.org>
25682 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25683 TypeManager.TypeToCoreType() to the top of the method so the
25684 following equality checks will work. Fixes #28107.
25686 2002-07-24 Martin Baulig <martin@gnome.org>
25688 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25689 operand is of type uint, and the other operand is of type sbyte,
25690 short or int, the operands are converted to type long." -
25691 Actually do what this comment already told us. Fixes bug #28106,
25694 2002-07-24 Martin Baulig <martin@gnome.org>
25696 * class.cs (MethodBase): New abstract class. This is now a base
25697 class for Property, Indexer and Event to avoid some code duplication
25698 in their Define() and DefineMethods() methods.
25699 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25700 generic methods for Define() and DefineMethods().
25701 (FieldBase): Derive from MemberBase, not MemberCore.
25702 (Property): Derive from MemberBase, not MemberCore.
25703 (Property.DefineMethod): Moved all the code from this method to the
25704 new MethodBase.DefineAccessor(), just call it with appropriate
25706 (Property.Define): Call the new Property.DoDefine(), this does some
25707 sanity checks and we don't need to duplicate the code everywhere.
25708 (Event): Derive from MemberBase, not MemberCore.
25709 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25710 accessors, this will also make them work with interface events.
25711 (Indexer): Derive from MemberBase, not MemberCore.
25712 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25713 (Indexer.Define): Use the new MethodBase functions.
25715 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25716 argument to the constructor.
25717 (Interface.FindMembers): Added support for interface events.
25718 (Interface.PopluateEvent): Implemented.
25720 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25722 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25724 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25725 but this is required to check for a method name being the same as
25726 the containing class.
25730 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25732 * interface.cs: initialize variable.
25734 2002-07-23 Martin Baulig <martin@gnome.org>
25736 Implemented the IndexerName attribute in interfaces.
25738 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25739 name if this is an explicit interface implementation.
25740 (Indexer.InterfaceIndexerName): New public variable. If we're
25741 implementing an interface indexer, this is the IndexerName in that
25742 interface. Otherwise, it's the IndexerName.
25743 (Indexer.DefineMethod): If we're implementing interface indexer,
25744 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25745 and Pending.ImplementIndexer methods.
25746 (Indexer.Define): Also define the PropertyBuilder if we're
25747 implementing an interface indexer and this is neither an explicit
25748 interface implementation nor do the IndexerName match the one in
25751 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25752 If a method is defined here, then we always need to create a proxy
25753 for it. This is used when implementing interface indexers.
25754 (Pending.IsInterfaceIndexer): New public method.
25755 (Pending.ImplementIndexer): New public method.
25756 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25757 This is used when implementing interface indexers to define a proxy
25759 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25760 define a proxy if necessary.
25762 * interface.cs (Interface.IndexerName): New public variable.
25763 (Interface.PopulateIndexer): Set the IndexerName.
25764 (Interface.DefineIndexers): New private method. Populate all the
25765 indexers and make sure their IndexerNames match.
25767 * typemanager.cs (IndexerPropertyName): Added support for interface
25770 2002-07-22 Martin Baulig <martin@gnome.org>
25772 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25773 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25774 ret if HasReturnLabel.
25775 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25778 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25779 and set the ec.LoopBeginTryCatchLevel.
25780 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25781 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25782 the current ec.TryCatchLevel, the branch goes out of an exception
25783 block. In this case, we need to use Leave and not Br.
25785 2002-07-22 Martin Baulig <martin@gnome.org>
25787 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25788 block unless the block does not always return or it is contained in
25789 another try { ... } catch { ... } block. Fixes bug #26506.
25790 Added verify-1.cs to the test suite.
25792 2002-07-22 Martin Baulig <martin@gnome.org>
25794 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25795 then we do not always return. Fixes bug #24985.
25797 2002-07-22 Martin Baulig <martin@gnome.org>
25799 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25800 lookup on a per-class level; ie. walk up the class hierarchy until we
25801 found at least one applicable method, then choose the best among them.
25802 Fixes bug #24463 and test-29.cs.
25804 2002-07-22 Martin Baulig <martin@gnome.org>
25806 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25807 return types of the methods. The return type is not part of the
25808 signature and we must not check it to make the `new' modifier work.
25809 Fixes bug #27999, also added test-147.cs.
25810 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25812 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25813 on the method's return type.
25815 2002-07-21 Martin Baulig <martin@gnome.org>
25817 * assign.cs: Make this work if the rightmost source is a constant and
25818 we need to do an implicit type conversion. Also adding a few more tests
25819 to test-38.cs which should have caught this.
25821 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25822 target in the makefile for this. The makefile.gnu is primarily intended
25823 for end-users who don't want to debug the compiler.
25825 2002-07-21 Martin Baulig <martin@gnome.org>
25827 * assign.cs: Improved the Assign class so it can now handle embedded
25828 assignments (X = Y = Z = something). As a side-effect this'll now also
25829 consume less local variables. test-38.cs now passes with MCS, added
25830 a few new test cases to that test.
25832 2002-07-20 Martin Baulig <martin@gnome.org>
25834 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25835 instructions. Fixes bug #27977, also added test-146.cs.
25837 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25839 * cs-tokenizer.cs: fixed getHex ().
25841 2002-07-19 Martin Baulig <martin@gnome.org>
25843 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25844 not Type.GetType() to lookup the array type. This is needed when
25845 we're constructing an array of a user-defined type.
25846 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25847 single-dimensional arrays, but also for single-dimensial arrays of
25850 2002-07-19 Martin Baulig <martin@gnome.org>
25852 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25853 this function is called, it's not allowed to share LocalBuilders
25854 among ILGenerators.
25856 2002-07-19 Martin Baulig <martin@gnome.org>
25858 * expression.cs (Argument.Resolve): Report an error 118 when trying
25859 to pass a type as argument.
25861 2002-07-18 Martin Baulig <martin@gnome.org>
25863 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25864 Conv_R_Un for the signed `long' type.
25866 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25868 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25869 `expr' for the temporary result, as that will fail if we do
25870 multiple resolves on the same expression.
25872 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25874 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25875 ec.TypeContainer for looking up aliases.
25877 * class.cs (TypeContainer): Remove LookupAlias from here.
25879 * decl.cs (DeclSpace); Move here.
25881 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25883 * class.cs (FindMembers): Only call filter if the constructor
25884 bulider is not null.
25886 Also handle delegates in `NestedTypes' now. Now we will perform
25887 type lookups using the standard resolution process. This also
25890 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25891 This uses Expressions (the limited kind that can be parsed by the
25892 tree) instead of strings.
25894 * expression.cs (ComposedCast.ToString): Implement, used to flag
25895 errors since now we have to render expressions.
25897 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25900 * ecore.cs (SimpleName.ToString): ditto.
25902 * cs-parser.jay: Instead of using strings to assemble types, use
25903 Expressions to assemble the type (using SimpleName, ComposedCast,
25904 MemberAccess). This should fix the type lookups in declarations,
25905 because we were using a different code path for this.
25907 * statement.cs (Block.Resolve): Continue processing statements
25908 even when there is an error.
25910 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25912 * class.cs (Event.Define): Also remove the `remove' method from
25913 the list of pending items.
25915 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25916 generate more compact code.
25918 2002-07-17 Martin Baulig <martin@gnome.org>
25920 * const.cs (Const.LookupConstantValue): Add support for constant
25921 `unchecked' and `checked' expressions.
25922 Also adding test case test-140.cs for this.
25924 2002-07-17 Martin Baulig <martin@gnome.org>
25926 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25927 check whether mi.ReturnType implements the IEnumerator interface; the
25928 `==' and the IsAssignableFrom() will fail in this situation.
25930 2002-07-16 Ravi Pratap <ravi@ximian.com>
25932 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25935 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25937 * expression.cs: fixed bug #27811.
25939 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25941 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25942 Molaro: when we are a ref, the value already contains a pointer
25943 value, do not take the address of it.
25945 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25946 * removed mb-parser.jay and mb-tokenizer.cs
25948 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25950 * expression.cs: check against the building corlib void type.
25952 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25954 * ecore.cs: fix for valuetype static readonly fields: when
25955 initializing them, we need their address, not the address of a copy.
25957 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25959 * typemanager.cs: register also enum_type in corlib.
25961 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25963 * class.cs: allow calling this (but not base) initializers in structs.
25965 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25967 * ecore.cs: make sure we compare against the building base types
25970 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25972 * typemanager.cs: fix TypeToCoreType() to handle void and object
25973 (corlib gets no more typerefs after this change).
25975 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25977 * expression.cs (ArrayCreation.EmitArrayArguments): use
25978 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25980 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25981 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25982 array indexes, the runtime actually forbids them.
25984 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25985 for array arguments here.
25987 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25988 instead of the default for ValueTypes.
25990 (New.DoEmit): Use IsValueType instead of
25991 IsSubclassOf (value_type)
25992 (New.DoResolve): ditto.
25993 (Invocation.EmitCall): ditto.
25995 * assign.cs (Assign): ditto.
25997 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25998 Statements *are* currently doing part of their resolution during
26001 Expressions do always resolve during resolve, but statements are
26002 only required to propagate resolution to their children.
26004 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26006 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26008 (LoadAssembly): Do not add the dll if it is already specified
26010 (MainDriver): Add the System directory to the link path at the end,
26011 after all the other -L arguments.
26013 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26014 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26015 ldelem.u1) and using the opposite for sbytes.
26017 This fixes Digger, and we can finally run it.
26019 * driver.cs (UnixParseOption): Move the option parsing here.
26020 (CSCParseOption): Implement CSC-like parsing of options.
26022 We now support both modes of operation, the old Unix way, and the
26023 new CSC-like way. This should help those who wanted to make cross
26024 platform makefiles.
26026 The only thing broken is that /r:, /reference: and /lib: are not
26027 implemented, because I want to make those have the same semantics
26028 as the CSC compiler has, and kill once and for all the confussion
26029 around this. Will be doing this tomorrow.
26031 * statement.cs (Unsafe.Resolve): The state is checked during
26032 resolve, not emit, so we have to set the flags for IsUnsfe here.
26034 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26036 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26037 not catch the Error_ObjectRefRequired in SimpleName (as it is
26038 possible to have a class/instance variable name that later gets
26039 deambiguated), we have to check this here.
26041 2002-07-10 Ravi Pratap <ravi@ximian.com>
26043 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26044 make static and put into Expression.
26046 (Event.Define): Register the private field of the event with the
26047 TypeManager so that GetFieldFromEvent can get at it.
26049 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26050 keep track of the private field associated with an event which
26053 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26056 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26058 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26060 * expression.cs (Binary.EmitBranchable): this routine emits the
26061 Binary expression in a branchable context. This basically means:
26062 we need to branch somewhere, not just get the value on the stack.
26064 This works together with Statement.EmitBoolExpression.
26066 * statement.cs (Statement.EmitBoolExpression): Use
26069 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26071 * statement.cs (For): Reduce the number of jumps in loops.
26073 (For): Implement loop inversion for the For statement.
26075 (Break): We can be breaking out of a Try/Catch controlled section
26076 (foreach might have an implicit try/catch clause), so we need to
26077 use Leave instead of Br.
26079 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26080 now). If the instace expression supports IMemoryLocation, we use
26081 the AddressOf method from the IMemoryLocation to extract the
26082 address instead of emitting the instance.
26084 This showed up with `This', as we were emitting the instance
26085 always (Emit) instead of the Address of This. Particularly
26086 interesting when This is a value type, as we dont want the Emit
26087 effect (which was to load the object).
26089 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26091 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26093 * statement.cs (Checked): Set the CheckedState during the resolve
26094 process too, as the ConvCast operations track the checked state on
26095 the resolve process, and not emit.
26097 * cs-parser.jay (namespace_member_declaration): Flag that we have
26098 found a declaration when we do. This is used to flag error 1529
26100 * driver.cs: Report ok when we display the help only.
26102 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26104 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26106 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26108 * cs-tokenizer.cs (define): We also have to track locally the
26109 defines. AllDefines is just used for the Conditional Attribute,
26110 but we also need the local defines for the current source code.
26112 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26114 * statement.cs (While, For, Do): These loops can exit through a
26115 Break statement, use this information to tell whether the
26116 statement is the last piece of code.
26118 (Break): Flag that we break.
26120 * codegen.cs (EmitContexts): New `Breaks' state variable.
26122 2002-07-03 Martin Baulig <martin@gnome.org>
26124 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26125 modifiers in method declarations in structs. Otherwise, you won't
26126 be able to override things like Object.Equals().
26128 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26130 * class.cs (Method, Property, Indexer): Do not allow the public
26131 modifier to be used in explicit interface implementations.
26133 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26134 override modifiers in method declarations in structs
26136 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26138 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26139 integer or real overflow, report an error
26141 2002-07-02 Martin Baulig <martin@gnome.org>
26143 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26144 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26145 to tell the runtime about our newly created System.Object and
26146 System.ValueType types.
26148 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26150 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26151 struct instead of Ldarg/Starg.
26153 2002-07-02 Martin Baulig <martin@gnome.org>
26155 * expression.cs (Indirection.Indirection): Call
26156 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26158 2002-07-02 Martin Baulig <martin@gnome.org>
26160 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26161 ValueType, call TypeManager.TypeToCoreType() on it.
26162 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26163 the OpCodes.Newarr argument.
26165 2002-07-02 Martin Baulig <martin@gnome.org>
26167 * expression.cs (Invocation.EmitCall): When compiling corlib,
26168 replace all calls to the system's System.Array type to calls to
26169 the newly created one.
26171 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26172 System.Array methods.
26173 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26174 from the system's System.Array type which must be replaced.
26176 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26178 * typemanager.cs: load unverifiable_code_ctor so we can build
26179 corlib using the correct type. Avoid using GetTypeCode() with
26181 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26182 TypeManager.object_type to allow building corlib.
26184 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26186 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26188 2002-07-01 Martin Baulig <martin@gnome.org>
26190 * class.cs: Make the last change actually work, we need to check
26191 whether `ifaces != null' to avoid a crash.
26193 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26195 * class.cs: when we build structs without fields that implement
26196 interfaces, we need to add the interfaces separately, since there is
26197 no API to both set the size and add the interfaces at type creation
26200 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26202 * expression.cs: the dimension arguments to the array constructors
26203 need to be converted if they are a long.
26205 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26207 * class.cs: don't emit ldarg.0 if there is no parent constructor
26208 (fixes showstopper for corlib).
26210 2002-06-29 Martin Baulig <martin@gnome.org>
26212 MCS now compiles corlib on GNU/Linux :-)
26214 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26215 ie. check for MethodImplOptions.InternalCall.
26217 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26218 and TypeManager.attribute_type are null, so we must explicitly check
26219 whether parent is not null to find out whether it's an attribute type.
26220 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26221 and SetBuilder, not only if the property is neither abstract nor external.
26222 This is necessary to set the MethodImplOptions on the accessor methods.
26223 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26224 SetBuilder, see Property.Emit().
26226 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26227 populate "System.Object", "System.ValueType" and "System.Attribute" since
26228 they've already been populated from BootCorlib_PopulateCoreTypes().
26230 2002-06-29 Martin Baulig <martin@gnome.org>
26232 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26233 is the NullLiteral, we also need to make sure that target_type is not
26236 2002-06-29 Martin Baulig <martin@gnome.org>
26238 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26239 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26240 before calling BootstrapCorlib_ResolveDelegate ().
26242 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26244 * statement.cs: fixed build-breaker. All tests passed ok.
26246 2002-06-27 Martin Baulig <martin@gnome.org>
26248 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26249 for System.Decimal when compiling corlib.
26251 2002-06-27 Martin Baulig <martin@gnome.org>
26253 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26254 switch blocks which contain nothing but a default clause.
26256 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26258 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26260 2002-06-27 Martin Baulig <martin@gnome.org>
26262 * ecore.cs (PropertyExpr.PropertyExpr): Call
26263 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26265 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26266 is already a TypeBuilder.
26268 2002-06-27 Martin Baulig <martin@gnome.org>
26270 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26271 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26272 the "from an array-type to System.Array" case. This makes it work
26273 when compiling corlib.
26275 2002-06-27 Martin Baulig <martin@gnome.org>
26277 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26278 non-static PropertyExpr, set its InstanceExpression. This makes
26279 the `ICollection.Count' property work in System/Array.cs.
26281 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26283 * driver.cs: Made error handling more consistent. Errors now
26284 tracked by Report class, so many methods which used to return int
26285 now return void. Main() now prints success/failure and
26286 errors/warnings message.
26288 Renamed '--probe' compiler argument to '--expect-error'. Removed
26289 the magic number return values (123 and 124). Now, if the
26290 expected error occurs, the compiler exits with success (exit value
26291 0). If the compilation completes without seeing that particular
26292 error, the compiler exits with failure (exit value 1). The
26293 makefile in mcs/errors has been changed to handle the new behaviour.
26295 * report.cs: Made 'expected error' number a property and renamed
26296 it from 'Probe' to 'ExpectedError'.
26298 * genericparser.cs: Removed error handling support, since it is
26299 now all done by Report class.
26301 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26302 class, so parse() no longer returns an int.
26304 * namespace.cs: Use Report.Error instead of GenericParser.error
26306 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26308 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26309 TypeContainer.AddOperator): At the front of the list put the
26310 explicit implementations, so they get resolved/defined first.
26312 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26314 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26315 interface type is implemented by this TypeContainer. Used during
26316 explicit interface implementation.
26318 (Property.Define, Indexer.Define, Method.Define): Validate that
26319 the given interface in the explicit implementation is one of the
26320 base classes for the containing type.
26322 Also if we are explicitly implementing an interface, but there is
26323 no match in the pending implementation table, report an error.
26325 (Property.Define): Only define the property if we are
26326 not explicitly implementing a property from an interface. Use the
26327 correct name also for those properties (the same CSC uses,
26328 although that is really not needed).
26330 (Property.Emit): Do not emit attributes for explicitly implemented
26331 properties, as there is no TypeBuilder.
26333 (Indexer.Emit): ditto.
26335 Hiding then means that we do not really *implement* a pending
26336 implementation, which makes code fail.
26338 2002-06-22 Martin Baulig <martin@gnome.org>
26340 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26341 the return value of Object.GetType(). [FIXME: we need to do this whenever
26342 we get a type back from the reflection library].
26344 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26346 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26348 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26350 * attribute.cs: Return null if we can not look up the type.
26352 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26353 the interface types found.
26355 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26356 interface types found.
26358 * typemanager.cs (GetInterfaces): Make this routine returns alll
26359 the interfaces and work around the lame differences between
26360 System.Type and System.Reflection.Emit.TypeBuilder in the results
26361 result for GetInterfaces.
26363 (ExpandInterfaces): Given an array of interface types, expand and
26364 eliminate repeated ocurrences of an interface. This expands in
26365 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26368 2002-06-21 Martin Baulig <martin@gnome.org>
26370 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26373 2002-06-21 Martin Baulig <martin@gnome.org>
26375 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26376 and called with one of the core types, return the corresponding typebuilder for
26379 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26382 2002-06-21 Martin Baulig <martin@gnome.org>
26384 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26385 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26386 (Expression.ConvertReferenceExplicit): Likewise.
26388 * expression.cs (ElementAccess.DoResolve): Likewise.
26389 (ElementAccess.DoResolveLValue): Likewise.
26391 2002-06-10 Martin Baulig <martin@gnome.org>
26393 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26394 add the "value" parameter to the parameter list.
26396 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26399 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26401 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26402 the argument to an int, uint, long or ulong, per the spec. Also
26403 catch negative constants in array creation.
26405 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26407 * class.cs: do not allow the same interface to appear twice in
26408 the definition list.
26410 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26412 * ecore.cs: don't use ldlen with System.Array.
26414 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26416 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26418 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26420 * modifiers.cs: produce correct field attributes for protected
26421 internal. Easy fix so miguel can work on ther harder stuff:-)
26423 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26425 * pending.cs: New file. Move the code from class.cs here.
26426 Support clearning the pending flag for all methods (when not doing
26427 explicit interface implementation).
26429 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26431 * rootcontext.cs: added a couple more types needed to bootstrap.
26433 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26435 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26436 constructor in the type, instead of any constructor in the type
26437 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26438 a bug in the Mono runtime when applying the params attribute).
26440 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26441 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26443 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26445 * expression.cs (Unary.ResolveOperator): Use TypeManager
26446 to resolve the type.
26448 2002-06-13 Ravi Pratap <ravi@ximian.com>
26450 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26453 * enum.cs (AddEnumMember): Add support to store the attributes associated
26454 with each member too.
26456 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26457 field builders too - this takes care of the enum member case.
26459 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26461 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26462 address-of operator on both value types and pointers.
26464 2002-06-10 Martin Baulig <martin@gnome.org>
26466 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26467 PropertyBuilder to the `property_builders' list.
26469 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26470 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26471 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26472 find any indexers which are inherited from an interface.
26474 2002-06-09 Martin Baulig <martin@gnome.org>
26476 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26477 the same type as the constant if necessary. There's also a test-130.cs
26480 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26482 * typemanager.cs (TypeManager.ChangeType): Previously known as
26483 Enum.ChangeEnumType().
26485 2002-06-09 Martin Baulig <martin@gnome.org>
26487 * expression.cs (Cast.TryReduce): Added support for consts.
26489 2002-06-08 Ravi Pratap <ravi@ximian.com>
26491 * class.cs (Accessor): Hold attributes information so we can pass
26494 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26495 Modify to pass in attributes attached to the methods.
26497 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26499 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26500 to handle the Accessor kind :-)
26502 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26504 2002-06-08 Martin Baulig <martin@gnome.org>
26506 * expression.cs (Unary.TryReduceNegative): Added support for
26509 2002-06-08 Martin Baulig <martin@gnome.org>
26511 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26512 name can't be found in the `defined_names' - the caller will do a
26513 MemberLookup in this case and thus find methods in System.Enum
26514 such as Enum.IsDefined().
26516 2002-06-08 Martin Baulig <martin@gnome.org>
26518 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26519 Convert.ChangeType() which works with TypeBuilder created types.
26520 (Enum.LookupEnumValue, Enum.Define): Use it here.
26522 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26523 `TypeBuilder.BaseType != null' check.
26524 (TypeContainer.FindMembers): Only lookup parent members if we
26525 actually have a parent.
26526 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26527 (ConstructorInitializer.Resolve): Likewise.
26529 * interface.cs (Interface.FindMembers): Added
26530 `TypeBuilder.BaseType != null' check.
26532 * rootcontext.cs (RootContext.ResolveCore): Added
26533 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26534 classes_second_stage.
26536 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26537 debug_type and trace_type when compiling with --nostdlib.
26539 2002-06-07 Martin Baulig <martin@gnome.org>
26541 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26542 (AddField): Set it to true when adding a non-static field.
26543 (DefineType): Use `have_nonstatic_fields' to find out whether we
26544 have non-static fields, not `Fields != null'.
26546 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26548 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26549 dereferencing a null on the static-field code path)
26551 2002-05-30 Martin Baulig <martin@gnome.org>
26553 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26554 to take command line arguments. Use reflection to call the new
26555 custom `Initialize' function on the symbol writer and pass it the
26556 command line arguments.
26558 * driver.cs (--debug-args): New command line argument to pass command
26559 line arguments to the symbol writer.
26561 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26563 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26564 the target type for indexers and properties. Thanks to Joe for
26567 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26569 * typemanager.cs (MethodFlags): returns the method flags
26570 (Obsolete/ShouldIgnore) that control warning emission and whether
26571 the invocation should be made, or ignored.
26573 * expression.cs (Invocation.Emit): Remove previous hack, we should
26574 not do this on matching a base type, we should do this based on an attribute
26576 Only emit calls to System.Diagnostics.Debug and
26577 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26578 on the command line.
26580 * rootcontext.cs: Global settings for tracing and debugging.
26582 * cs-tokenizer.cs (define): New utility function to track
26583 defines. Set the global settings for TRACE and DEBUG if found.
26585 2002-05-25 Ravi Pratap <ravi@ximian.com>
26587 * interface.cs (Populate*): Pass in the TypeContainer as well as
26588 the DeclSpace as parameters so that we can create EmitContexts and
26589 then use that to apply attributes etc.
26591 (PopulateMethod, PopulateEvent, PopulateProperty)
26592 (PopulateIndexer): Apply attributes everywhere.
26594 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26597 (ApplyAttributes): Update accordingly.
26599 We now apply interface attributes for all members too.
26601 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26603 * class.cs (Indexer.Define); Correctly check if we are explicit
26604 implementation (instead of checking the Name for a ".", we
26605 directly look up if the InterfaceType was specified).
26607 Delay the creation of the PropertyBuilder.
26609 Only create the PropertyBuilder if we are not an explicit
26610 interface implementation. This means that explicit interface
26611 implementation members do not participate in regular function
26612 lookups, and hence fixes another major ambiguity problem in
26613 overload resolution (that was the visible effect).
26615 (DefineMethod): Return whether we are doing an interface
26618 * typemanager.cs: Temporary hack until we get attributes in
26619 interfaces (Ravi is working on that) and we get IndexerName
26620 support in interfaces.
26622 * interface.cs: Register the indexers as properties.
26624 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26625 warning, I have verified that this is a bug in the .NET runtime
26626 (JavaScript suffers of the same problem).
26628 * typemanager.cs (MemberLookup): When looking up members for
26629 interfaces, the parent of an interface is the implicit
26630 System.Object (so we succeed in searches of Object methods in an
26631 interface method invocation. Example: IEnumerable x; x.ToString
26634 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26636 * class.cs (Event): Events should also register if they do
26637 implement the methods that an interface requires.
26639 * typemanager.cs (MemberLookup); use the new GetInterfaces
26642 (GetInterfaces): The code used to lookup interfaces for a type is
26643 used in more than one place, factor it here.
26645 * driver.cs: Track the errors at the bottom of the file, we kept
26648 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26649 instance if the method we are calling is static!
26651 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26653 * attribute.cs (ApplyAttributes): Make this function filter out
26654 the IndexerName attribute (as that attribute in reality is never
26655 applied) and return the string constant for the IndexerName
26658 * class.cs (TypeContainer.Emit): Validate that all the indexers
26659 have the same IndexerName attribute, and if so, set the
26660 DefaultName attribute on the class.
26662 * typemanager.cs: The return value might contain other stuff (not
26663 only methods). For instance, consider a method with an "Item"
26664 property and an Item method.
26666 * class.cs: If there is a problem with the parameter types,
26669 2002-05-24 Ravi Pratap <ravi@ximian.com>
26671 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26672 looks at user defined conversion after making a call to
26673 StandardConversionExists - we need this for overload resolution.
26675 * expression.cs : Update accordingly the various method calls.
26677 This fixes 2 bugs filed against implicit user defined conversions
26679 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26681 * statement.cs: Track the result of the assignment.
26683 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26685 * expression.cs (MemberAccess): Improved error reporting for
26686 inaccessible members.
26688 2002-05-22 Martin Baulig <martin@gnome.org>
26690 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26691 itself with debugging support.
26693 2002-05-22 Martin Baulig <martin@gnome.org>
26695 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26696 Removed, this isn't needed anymore.
26698 2002-05-20 Martin Baulig <martin@gnome.org>
26700 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26701 be underlying type for an enum.
26703 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26705 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26706 that splits out the loading of just the core types.
26708 * rootcontext.cs (ResolveCore): Split the struct resolution in
26709 two, so we can load the enumeration underlying types before any
26712 * expression.cs (Is): Bandaid until we fix properly Switch (see
26713 bug #24985 for details).
26715 * typemanager.cs (ImplementsInterface): The hashtable will contain
26716 a null if there are no interfaces implemented.
26718 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26720 * cs-parser.jay (indexer_declarator): It is fine to have array
26723 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26725 * typemanager.cs: (RegisterBuilder): New function used to register
26726 TypeBuilders that implement interfaces. Since
26727 TypeBuilder.GetInterfaces (as usual) does not work with lame
26729 (AddUserType): register interfaces.
26731 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26732 dealing with TypeBuilder. Also, arrays are showing up as
26733 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26734 methods can not be invoked on them!
26736 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26737 (ImplicitReferenceConversionExists): Split out from
26738 StandardConversionExists.
26740 * expression.cs (As): We were only implementing one of the three
26741 cases for the as operator. We now implement them all.
26742 (Is): Implement the various other cases for Is as well.
26744 * typemanager.cs (CACHE): New define used to control if we want or
26745 not the FindMembers cache. Seems to have a negative impact on
26746 performance currently
26748 (MemberLookup): Nested types have full acess to
26749 enclosing type members
26751 Remove code that coped with instance/static returns for events, we
26752 now catch this in RealFindMembers.
26754 (RealFindMembers): only perform static lookup if the instance
26755 lookup did not return a type or an event.
26757 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26759 * assign.cs (CompoundAssign): We pass more semantic information
26760 now to Compound Assignments than we did before: now we have all
26761 the information at hand, and now we resolve the target *before* we
26762 do the expression expansion, which allows the "CacheValue" method
26763 to have the effect we intended (before, a [x] += 1 would generate
26764 two differen ArrayAccess expressions from the ElementAccess,
26765 during the resolution process).
26767 (CompoundAssign.DoResolve): Resolve target and original_source here.
26769 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26771 * expression.cs (ArrayAccess): dropped debugging information.
26773 * typemanager.cs: Small bug fix: I was always returning i_members,
26774 instead of one of i_members or s_members (depending on which had
26777 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26778 method is invoked before any code generation takes place, and it
26779 is a mechanism to inform that the expression will be invoked more
26780 than once, and that the method should use temporary values to
26781 avoid having side effects
26783 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26785 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26788 * expression.cs (Indirection, ArrayAccess): Add support for
26789 CacheTemporaries in these two bad boys.
26791 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26792 ldobj or ldind_ref.
26793 (StoreFromPtr): Handle stobj as well.
26795 * expression.cs (UnaryMutator): Share more code.
26797 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26798 down: I was not tracking the Filter function as well, which
26799 was affecting the results of the cache.
26801 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26803 * attribute.cs: Remove the hack to handle the CharSet property on
26806 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26808 * attribute.cs (DoResolve): More uglyness, we now only try to
26809 resolve the attribute partially, to extract the CharSet
26810 information (only if we are a StructLayout attribute). Otherwise
26812 (GetExtraTypeInfo): Add some code to conditionally kill in the
26813 future this. I am more and more convinced that the .NET
26814 framework has special code to handle the attribute setting on
26817 * expression.cs (IsParamsMethodApplicable): Revert my previous
26818 foreach change here, it was wrong.
26820 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26822 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26823 (pp_expr): do not abort on unknown input, just return.
26824 (eval): abort if there are pending chars.
26826 * attribute.cs (Attribute.Resolve): Positional parameters are
26827 optional. Deal with that case.
26829 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26830 the Ansi/Unicode/Auto information for the type.
26832 (TypeContainer.DefineType): instantiate the EmitContext here, as
26833 we will be using it during the type definition (to resolve
26834 attributes) and during the emit phase.
26836 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26837 to pull type information out of the attributes
26839 (Attribute.Resolve): track the constructor builder, and allow for
26840 multiple invocations (structs and classes will use this).
26842 * ecore.cs (MemberLookupFinal): new version with all the
26843 parameters customizable.
26845 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26846 constructors. Return if the result value is null (as the error
26847 would have been flagged already by MemberLookupFinal)
26849 Do not allow instances of abstract classes or interfaces to be
26852 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26853 We have to compare the assembly property here when dealing with
26854 FamANDAssem and Assembly access modifiers, because we might be
26855 creating an assembly from *modules* (that means that we are not
26856 getting TypeBuilders for types defined in other modules that are
26857 part of this assembly).
26859 (Method.Emit): If the method is marked abstract and has a body,
26862 (TypeContainer.DefineMembers): If both the defined member and the
26863 parent name match are methods, then do not emit any warnings: let
26864 the Method.Define routine take care of flagging warnings. But if
26865 there is a mismatch (method overrides something else, or method is
26866 overriwritten by something, then emit warning).
26868 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26869 set to null, this means `do not check for the return type on the
26872 (Method.Define): set the return type for the method signature to
26873 null, so that we get methods with the same name and parameters and
26874 different return types. This is used to flag warning 114 (you are
26875 hiding a method, and you probably want to use the new/override
26878 * typemanager.cs (MemberLookup): Implemented proper access
26879 control, closing a long standing set of bug reports. The problem
26880 was that the Framework only has two bits: Public and NonPublic,
26881 and NonPublic includes private and protected methods, but we need
26882 to enforce the FamANDAssem, FamOrAssem and Family.
26884 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26886 * statement.cs (GotoCase): Return true: Ammounts to giving up
26887 knowledge on whether we return or not, and letting the other case
26888 be responsible for it.
26890 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26892 * driver.cs: Do not load directories for each file processed, only
26893 do it if there is a pattern.
26895 * ecore.cs: Report readonly assigns here as well, as we might have
26896 been resolved only by MemberAccess.
26898 (SimpleName.SimpleNameResolve): Also be useful for LValue
26899 resolution. We need this to propagate assign to local readonly variables
26901 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26902 do not want to reuse potential criteria memory.
26904 * class.cs (MyEventBuilder): Set reflected_type;
26906 * ecore.cs (Constantify): Added support for constifying bools.
26908 (RootContext.LookupType): Added a cache for values looked up in
26909 the declaration space.
26911 * typemanager.cs (FindMembers): Now is a front-end to
26912 RealFindMembers, and provides a two-level hashtable-based cache to
26915 15% performance improvement: from 22.5 to 19.2 seconds.
26917 * expression.cs (IsParamsMethodApplicable): use foreach.
26918 (Invocation.DoResolve): ditto.
26919 (New.DoResolve): ditto.
26920 (ArrayCreation.DoResolve): ditto.
26922 * ecore.cs (FindMostEncompassingType): use foreach.
26924 * delegate.cs (NewDelegate.DoResolve): Use foreach
26926 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26927 (RemoveMethods): use foreach.
26929 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26930 nested foreach statements instead of for, and also break out of
26931 the inner loop once a match is found.
26933 (Invocation.OverloadResolve): Use foreach, simplify the code.
26935 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26937 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26938 we actually unwrap the expression to allow for extra information
26941 * expression.cs: Use Shr_Un on unsigned operations.
26943 2002-05-08 Ravi Pratap <ravi@ximian.com>
26945 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26946 applicable operators was not being considered correctly. This closes
26947 the bug Miguel reported.
26949 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26951 * attribute.cs: check that the type derives from System.Attribute
26952 and report the correct error in that case (moved the duplicate code to
26953 its own method, too).
26955 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26957 * attribute.cs: lookup attribute type name as the spec says: first the
26958 bare attribute name and then name + "Attribute" (nant compiles with
26959 mcs after this fix).
26961 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26963 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26964 Because of the way we parse things, we should try to see if a
26965 UIntConstant can fit in an integer.
26967 2002-05-07 Ravi Pratap <ravi@ximian.com>
26969 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26970 when we are in an explicit context.
26972 (ConvertReferenceExplicit): When converting from Iface type S to Class
26973 T make sure the rules are implemented as an OR.
26975 * parameter.cs (ParameterType): Make it a property for now although the
26976 purpose really isn't anything immediate.
26978 * expression.cs (Is*Applicable): Do better checking on the parameter type
26979 of a ref/out parameter. The ones from the system assemblies are already
26980 marked with the correct type so we don't need to do any correction.
26982 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26983 the object type is standard too so include that.
26985 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26987 * ecore.cs (StandardConversionExists): Augment with missing code:
26988 deal with IntConstant, LongConstants and Enumerations.
26990 * assign.cs: Report the error, instead of failing silently
26992 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26993 typecontainer that they are declared, because the
26994 typecontainer/namespace will have the list of using clauses that
26995 need to be applied.
26997 Assembly Attributes were escaping the normal registration
27000 (EmitCode): Apply attributes within an EmitContext that represents
27001 the container they were declared on.
27003 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27005 2002-05-06 Ravi Pratap <ravi@ximian.com>
27007 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27008 Revamp completely - make much cleaner as we now operate only
27011 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27012 to implement the logic detailed in the spec more correctly.
27014 (UserDefinedConversion): Update accordingly.
27016 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27018 * statement.cs: Return flow analysis information up.
27020 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27023 (token): Do not consume an extra character before calling
27026 2002-05-06 Piers Haken <piersh@friskit.com>
27028 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27030 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27032 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27033 EmitContext during the instance constructor initializer
27034 resolution, to stop access to instance variables.
27036 This is mandated by the spec, last paragraph of the `constructor
27037 initializers' section.
27039 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27041 * cs-parser.jay, class.cs (Accessor): new class used to represent
27042 an accessor (get or set). In the past we used `null' to represent
27043 a missing accessor. But this is ambiguous because there was no
27044 way to tell in abstract indexers/properties if one of them was
27047 Now there is a way of addressing that.
27049 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27050 instead of FindMembers.
27052 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27053 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27055 * attribute.cs: Treat indexers and properties as the same in terms
27056 of applying attributes
27058 * ecore.cs (FindMostEncompassedType): Use statically initialized
27059 EmptyExpressions()s like we do elsewhere to avoid creating useless
27060 objects (and we take this out of the tight loop).
27062 (GetConversionOperators): Move the code to extract the actual
27063 operators to a separate routine to clean things up.
27065 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27067 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27068 events are always registered FieldBuilders.
27070 * class.cs (FieldBase): New class shared by Fields
27072 * delegate.cs: If we are a toplevel delegate, use our full name.
27073 If we are a nested delegate, then only use our tail name.
27075 2002-05-02 Ravi Pratap <ravi@ximian.com>
27077 * expression.cs (IsApplicable): Ensure that we add the "&" to
27078 ref/out types before comparing it with the type of the argument.
27080 (IsParamsMethodApplicable): Ditto.
27082 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27085 * delegate.cs : Handle the case when we have more than one applicable
27086 method. Flag an error only when we finish checking all.
27088 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27090 * expression.cs: Add support for boolean static initializers.
27092 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27094 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27096 * parameter.cs (ComputeParameterTypes,
27097 ComputeAndDefineParameterTypes): Better error handling: now we
27098 clear the `types' cache if we fail during any of the type lookups.
27099 We also return the status code correctly to our caller
27101 * delegate.cs: If we fail to define a delegate, abort the extra
27104 * expression.cs (Binary.ResolveOperator): for
27105 operator==(object,object) and operator !=(object, object) we also
27106 have to verify that there is an implicit conversion from one to
27109 (ArrayAccess.DoResolve): Array Access can operate on
27112 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27114 * assign.cs (CompoundAssign): A new class used as a "flag" that
27115 the assignment actually is happening as part of a compound
27116 assignment operator.
27118 During compound assignment, a few new rules exist to enable things
27125 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27126 to the type of x) if y is implicitly convertible to the type of x,
27127 and the operator is a builtin operator and the return type of the
27128 operator is explicitly convertible to the type of x.
27130 * rootcontext.cs: Reset warning level to 2. 4 catches various
27131 "interesting" features in mcs, we must clean this up at some
27132 point, but currently am trying to kill other bugs ;-)
27134 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27135 in container classes as well.
27137 * expression.cs (Binary.ResolveOperator): Handle string case
27138 before anything else (as operator overloading does emit an error
27139 before doing anything else).
27141 This code could go away when we move to a table driven model, but
27142 i could not come up with a good plan last night.
27144 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27146 * typemanager.cs (CSharpName): reimplementation using regex.
27147 * class.cs: added null check for fields in Emit
27148 * rootcontext.cs: set warninglevel to 4
27150 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27152 * typemanager.cs (CSharpName): reimplemented with Lupus
27155 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27157 * statement.cs (If): correclty implement Resolve, because we were
27158 not catching sem errors in there. The same process is needed
27160 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27163 (Statement.Warning_DeadCodeFound): Factorize code.
27164 (While): Report dead code here too.
27166 (Statement): Added Resolve virtual method to allow
27167 for resolution split from the emit code.
27169 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27171 * statement.cs (EmitBoolExpression): No longer try to resolve the
27173 (MakeBoolean): New utility function that resolve, implicitly
27174 converts to boolean and tags the expression.
27177 (If, Do): Implement dead code elimination.
27178 (While): Implement loop inversion
27180 (Do, While, For, If): Resolve the expression prior to calling our
27183 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27186 - added method Report28 (warning: program has more than one entry point)
27187 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27188 - modified method Method.Define, the part at the end of the method
27190 * rootcontext.cs: added static public Location EntryPointLocation;
27192 * ../errors/cs0028.cs : Add test case for the above warning.
27195 - modified method CSharpName to allow arrays of primitive type to
27196 be printed nicely (e.g. instead of System.Int32[][] it now prints
27198 - added method CSharpSignature: returns the signature of a method
27199 in string format to be used in reporting errors, warnings, etc.
27201 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27204 2002-04-26 Ravi Pratap <ravi@ximian.com>
27206 * delegate.cs (Define): Fix extremely silly bug where I was
27207 setting the type of the 'object' parameter of the BeginInvoke
27208 method to System.IAsyncResult instead of System.Object ;-)
27210 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27212 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27215 (Constructor.Emit): return if we fail to initialize the
27216 constructor. Another door closed!
27218 * expression.cs (New.DoResolve): Improve error message (from -6 to
27219 1501). Use DeclaredOnly lookup to find the exact constructor.
27221 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27222 loop. This is useful.
27224 * cs-parser.jay: Adjust the default parameters so that destructors
27225 have the proper signature.
27227 2002-04-26 Martin Baulig <martin@gnome.org>
27229 * driver.cs (LoadAssembly): If `assembly' contains any characters
27230 which are only valid in path names and not in assembly names
27231 (currently slash, backslash and point), use Assembly.LoadFrom ()
27232 instead of Assembly.Load () on the `assembly' (before iteration
27233 over the link_paths).
27235 2002-04-26 Martin Baulig <martin@gnome.org>
27237 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27239 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27241 * class.cs (Property): use the new typemanager.MemberLookup
27243 (TypeContainer.MemberLookup): Implement using the
27244 TypeManager.MemberLookup now.
27246 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27247 and return MemberInfos, so that these can be used without an
27248 EmitContext (what we had before).
27250 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27252 * expression.cs: Fix the case where the argument to params if the
27253 type of the params. I omitted handling this before. Fixed
27255 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27257 * driver.cs: Call BootCorlib_PopulateCoreType
27259 * class.cs (Property.CheckBase): Check for properties only, not
27262 * interface.cs: Temporary hack: try/catch around the
27263 CustomAttributeBuilder, because I am getting an exception that I
27266 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27267 types whose definitions are required to be there (attributes are
27268 defined before standard types).
27270 Compute definitions as we boot the various types, as they are used
27271 immediately (value_type class will need object_type, but if we do
27272 not initialize object_type, we will pass a null, which will let
27273 the runtime pick the System.Object from the existing corlib, which
27274 is not what we want).
27276 2002-04-22 Patrik Torstensson <totte@labs2.com>
27278 * cs-tokenizer.cs: fixed a number of trim() issues.
27280 2002-04-22 Ravi Pratap <ravi@ximian.com>
27282 * expression.cs (Argument.Type): Ensure that we return the correct
27283 type when we have out or ref parameters [in which case we
27286 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27288 * class.cs (Property, Indexer): Allow extern modifier in there.
27290 * typemanager.cs (InitBaseTypes): Initializes object_type and
27291 value_type, since those will be used early on during the bootstrap
27292 process to compile corlib.
27294 (InitCoreTypes): Move code from here to InitBaseTypes.
27296 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27298 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27299 single-dimension arrays as using the ldlen opcode.
27301 Daniel Lewis discovered this optimization.
27303 * typemanager.cs: Add signature for System.Array::get_Length
27305 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27307 * statement.cs: report the error when the foreach does not apply to an
27308 array nor a collection.
27310 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27312 * expression.cs: Add implicit conversions to the operator ~.
27314 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27316 * typemanager.cs: Locate the decimal constructor.
27318 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27320 * attribute.cs: use the new property of TypeOf.
27321 * expression.cs: added 'get' property around typearg.
27323 These changes fix a build breaker reported by NickD. Is this the
27324 correct way to fix? If not, please, revert my changes and make it
27327 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27329 * attribute.cs: Add support for typeof in attribute invocations.
27330 I am not sure that this is right though.
27332 2002-04-14 Duncan Mak <duncan@ximian.com>
27334 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27335 Binary.Operator.Division case.
27337 2002-04-13 Ravi Pratap <ravi@ximian.com>
27339 * class.cs (DefineType): Ensure that we do a proper check on
27340 attribute types and also register it with the TypeManager.
27342 (TypeContainer.Targets): The default for attribute types is
27343 AttributeTargets.All.
27345 * attribute.cs (ApplyAttributes): Registering the attribute type
27346 is done elsewhere, not when we discover we have a Usage attribute.
27348 2002-04-12 Ravi Pratap <ravi@ximian.com>
27350 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27351 and get rid of is_delegate parameter.
27353 * everywhere : update.
27355 2002-04-12 Ravi Pratap <ravi@ximian.com>
27357 * cs-parser.jay (compilation_unit): Revamp completely to use
27358 some new ideas that I got from Rhys' grammar to solve the problems
27359 with assembly level attributes.
27361 (outer_declaration): New grammar production.
27363 (attribute_sections): Add.
27365 (opt_attributes): Base on attribute_sections
27367 (namespace_declaration): Allow opt_attributes to tackle the case
27368 when we have assembly level attributes - we are clever in this
27371 * attribute.cs (ApplyAttributes): Do not worry about assembly
27372 attributes in the non-global context.
27374 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27375 instead of SetGlobalAttributes.
27377 * class.cs, rootcontext.cs : Ensure we define and generate
27378 attribute types before anything else.
27380 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27381 and flag the new error -20 for the case when the attribute type
27382 does not have valid targets specified. csc does not catch this.
27384 * ../errors/errors.txt : update for error # -20
27386 2002-04-11 Ravi Pratap <ravi@ximian.com>
27388 * support.cs (InternalParameters.ParameterModifier): Do some null
27389 checking and return sane values.
27391 * class.cs (Method.Define): If we are a PInvoke method, ensure
27392 that we are static and extern. Report error # 601
27394 * ../errors/cs0601.cs : Add test case for the above error.
27396 2002-04-07 Ravi Pratap <ravi@ximian.com>
27398 * rootcontext.cs (attribute_types): We need to keep type of
27399 all attribute types separately and emit code for them first.
27401 (RegisterAttribute) : Implement.
27403 * class.cs (DefineType): Check if the current Type is a custom
27404 attribute type and register it accordingly.
27406 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27407 adding the first attribute twice and rename to
27409 (SetGlobalAttributes): this.
27411 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27414 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27415 if we are processing global arguments. Hmm, I am unsure of this.
27417 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27419 * expression.cs: added static array of strings to avoid calling
27420 Enum.ToString () for Operator in Binary. Significant recover of
27423 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27425 * class.cs (FindMembers): Allow the Builders of the various
27426 members to be null. If they are skip them. This only happens
27427 during the PInvoke declaration.
27429 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27431 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27432 failure, so we do not keep going afterwards.
27434 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27435 wanted to pass `false' as the `is_delegate' argument. If this is
27436 the case, why not use delegate_type == null to mean `is_delegate =
27437 false' and anything else as is_delegate = true.
27439 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27441 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27442 code for the section, not the beginning of the tests.
27444 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27446 * cfold.cs: Handle operator + (Enum x, Underlying x)
27448 * expression.cs (Binary): same. Warn about errors where we have
27449 Enum/Enum in operator + as well.
27451 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27454 - added support for switch(bool)
27455 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27456 - add TableSwitchEmit() to handle table-based switch statements
27458 2002-04-05 Ravi Pratap <ravi@ximian.com>
27460 * expression.cs (Invocation.OverloadResolve): Factor out code which
27461 does parameter compatibility checking with arguments so that we can
27462 re-use the code even from Delegate.VerifyApplicability
27464 (VerifyArgumentsCompat): Move above code here.
27466 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27467 and instead make a call to the above method.
27469 2002-03-31 Ravi Pratap <ravi@ximian.com>
27471 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27472 We use it to keep track of classes which are attribute types.
27474 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27476 * delegate.cs (Delegate.Define): Correctly define the types in the
27477 presence of fixed and array parameters.
27479 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27482 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27483 include NonPublic after the first iteration.
27485 * class.cs (Indexer.CheckBase): Only check if both parents are
27488 * cs-parser.jay (accessor_body): If empty, set to null.
27490 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27491 same code path here to resolve constants names that we did have in
27492 MemberAccess.DoResolve. There is too much code duplicated here.
27494 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27496 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27498 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27501 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27502 tokens, numbers and strings.
27504 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27507 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27508 asyncronous parameters and the regular parameters.
27510 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27511 specify the target directory.
27513 * expression.cs: (This.DoResolve): Simplify
27514 (As.Emit): Optimize, do not generate IsInst if the expression is
27515 always of the given type.
27517 (Is.DoResolve): Bug fix, we were reporting both always/never for
27520 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27521 creating too many unnecessary arrays.
27523 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27525 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27526 fields instead of rolling our own initializer. Takes care of all
27527 implicit conversions, and drops unnecessary static checks/argument.
27529 2002-03-31 Dick Porter <dick@ximian.com>
27531 * driver.cs: use the GetDirectories() return values properly, and
27532 use "/" as path separator.
27534 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27536 * expression.cs (Unary): Optimize - - expr into expr.
27537 (Binary): Optimize a + (-b) into a -b.
27539 * codegen.cs (CodeGen): Made all methods static.
27541 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27545 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27546 TypeBuilder property.
27548 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27551 * tree.cs: Removed the various RecordXXXX, and replaced with a
27552 single RecordDecl. Removed all the accessor methods, and just
27553 left a single access point Type
27555 * enum.cs: Rename DefineEnum to DefineType.
27557 * decl.cs: New abstract method `DefineType' used to unify the
27558 Defines for Enumerations, Interfaces, TypeContainers and
27561 (FindType): Moved LookupInterfaceOrClass here. Moved the
27562 LookupBaseClasses method that used to live in class.cs and
27563 interface.cs here, and renamed to FindType.
27565 * delegate.cs: Implement DefineType. Take advantage of the
27566 refactored pattern for locating the parent builder without taking
27567 the parent_builder argument (which we know does not work if we are
27568 nested, and triggering a toplevel definition).
27570 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27572 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27573 accessibility of a member has changed during override and report
27576 * class.cs (Method.Define, Property.Define): Only complain on
27577 overrides if the method is private, any other accessibility is
27578 fine (and since we just checked the permission is the same, we are
27581 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27582 and elif are processed always. The other pre-processing
27583 directives are only processed if we are "taking" the path
27585 2002-03-29 Martin Baulig <martin@gnome.org>
27587 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27588 current location is not Null.
27590 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27591 a separate method so we can profile it.
27593 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27594 `span.Seconds' are just seconds, but no minutes or hours.
27595 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27597 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27599 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27600 Remove the gratuitous set of Final:
27602 // If an interface implementation, then we can set Final.
27603 if (((flags & MethodAttributes.Abstract) == 0) &&
27604 implementing.DeclaringType.IsInterface)
27605 flags |= MethodAttributes.Final;
27607 I do not know what I was smoking when I used that.
27610 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27611 step into fixing the name resolution issues for delegates and
27612 unifying the toplevel name resolution.
27614 2002-03-28 Martin Baulig <martin@gnome.org>
27616 * class.cs (Method.Emit): If we have a symbol writer, call its
27617 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27618 tell it about the current method.
27620 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27621 writer that we're going to emit the first byte of IL code for a new
27622 statement (a new source line).
27623 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27624 EmitContext.Mark() before emitting any code.
27626 * location.cs (SymbolDocument): Return null when we're Null.
27628 * statement.cs (Statement): Moved the `Location loc' variable here.
27629 (Statement.EmitBoolExpression): If we have a symbol writer, call
27630 ec.Mark() before emitting any code to tell it that we're at the
27631 beginning of a new statement.
27632 (StatementExpression): Added `Location' argument to the constructor.
27633 (Block): Added public readonly variable `StartLocation' and public
27634 variable `EndLocation'. The latter is to be set using SetEndLocation().
27635 (Block): Added constructor which takes a start and end location.
27636 (Block.SetEndLocation): New method. This sets the end location.
27637 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27638 local variables we create.
27639 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27640 each statement and do also mark the begin and end of the block.
27642 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27643 tell it the current lexer.Location, use Location.Null for the end of the
27645 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27646 current block, set its end location using SetEndLocation().
27647 (statement_expression): StatementExpression constructor now takes the
27648 lexer.Location as additional argument.
27649 (for_statement, declare_local_variables): Likewise.
27650 (declare_local_variables): When creating a new implicit block, use the
27651 new Block constructor and pass it the lexer.Location.
27653 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27655 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27656 members also on the parent interfaces recursively.
27658 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27660 * report.cs: Use new formats, since Gonzalo finished the missing
27663 * expression.cs (Binary.ResolveOperator): added missing operator|
27664 operator& and operator^ for bool/bool.
27666 * cs-parser.jay: CheckDef now takes a Location argument that is
27667 used to report errors more precisly (instead of reporting the end
27668 of a definition, we try to track something which is a lot closer
27669 to the source of the problem).
27671 * cs-tokenizer.cs: Track global token use, so we can properly flag
27672 the use of #define/#undef after the first token has been seen.
27674 Also, rename the reportXXXX to Error_DescriptiveName
27676 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27677 TypeContainer, so that Enum and Interface can use this too.
27679 * class.cs (TypeContainer.LookupInterfaceOrClass,
27680 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27681 `builder' argument. Typically this was used to pass the parent
27682 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27685 The problem is that a nested class could trigger the definition of
27686 a toplevel class, and the builder would be obviously wrong in that
27689 So we drop this argument, and we compute dynamically the
27690 TypeBuilder/ModuleBuilder (the correct information was available
27691 to us anyways from DeclSpace.Parent)
27693 * interface.cs (Interface.DefineInterface): Drop builder
27694 parameter cleanup like class.cs
27696 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27699 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27702 (Try.Emit): Propagate the returns value from the statement.
27704 (Return.Emit): Even if we are leavning
27706 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27708 * modifiers.cs: Fix the computation of MethodAttributes flags.
27710 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27712 * driver.cs: allow compilation of files that start with '/'.
27713 Add a default case when checking the argument of --target.
27715 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27717 * interface.cs: Implement the same search algorithm for types in
27718 the interface code.
27720 * delegate.cs: Do not allow multiple definition.
27722 * Recovered ChangeLog that got accidentally amputated
27724 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27726 * rootcontext.cs: Load manually enum to allow core classes to
27727 contain enumerations.
27729 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27730 Update to new static methods in TypeManager.
27732 * typemanager.cs (GetMethod, GetConstructor): Use our
27733 implementation of FindMembers to find the members, since during
27734 corlib compilation, the types are TypeBuilders and GetMethod and
27735 GetConstructor do not work.
27737 Make all methods in TypeManager static.
27739 (InitCodeHelpers): Split the functionality from
27740 the InitCodeTypes function.
27742 * driver.cs: Call InitCodeHelpers after we have populated the
27745 * cs-parser.jay (delegate_declaration): we did not used to compute
27746 the delegate name correctly for void delegates.
27748 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27750 * rootcontext.cs (RootContext): Init the interface_resolve_order
27751 and type_container_resolve_order always.
27753 (ResolveCore, BootstrapCorlib_ResolveClass,
27754 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27755 compiler when compiling with --nostdlib
27757 * class.cs (TypeContainer.DefineType): Check that our parent is
27758 not null. This test is most important when we are bootstraping
27761 * codegen.cs: Split out the symbol writing code.
27763 2002-03-25 Martin Baulig <martin@gnome.org>
27765 * driver.cs (-g): Made -g an alias for --debug.
27767 2002-03-24 Martin Baulig <martin@gnome.org>
27769 * codegen.cs (SymbolWriter): New public variable. Returns the
27770 current symbol writer.
27771 (CodeGen): Added `bool want_debugging_support' argument to the
27772 constructor. If true, tell the ModuleBuild that we want debugging
27773 support and ask it for the ISymbolWriter.
27774 (Save): If we have a symbol writer, call it's Close() method after
27775 saving the assembly.
27777 * driver.c (--debug): New command line argument to create a
27778 debugger information file.
27780 * location.cs (SymbolDocument): New public property. Returns an
27781 ISymbolDocumentWriter object for the current source file or null
27782 if we don't have a symbol writer.
27784 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27786 * driver.cs (LoadAssembly): Correctly return when all the paths
27787 have been tried and not before.
27789 * statement.cs (Switch.Emit): return the actual coverage for this
27790 statement (returns/not-returns)
27792 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27793 switch of the statement if we are the last switch section. That
27794 kills two problems: try/catch problems (we used to emit an empty
27795 nop at the end) and switch statements where all branches would
27798 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27800 * driver.cs: Add default assemblies (the equivalent to the
27801 Microsoft CSC.RSP file)
27803 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27804 also update tokens_seen and set it to false.
27806 * driver.cs: Implement --recurse for Mike.
27808 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27809 correctly splitting out the paths.
27811 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27813 * interface.cs (Interface.PopulateProperty): Instead of using
27814 `parent' as the declaration space for the set parameters, use
27817 * support.cs (InternalParameters): InternalParameters constructor
27818 takes a DeclSpace instead of a TypeContainer.
27820 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27821 types are being initialized, load the address of it before calling
27824 (New): Provide a mechanism to disable the generation of local
27825 value type temporaries when the caller will be providing us with
27826 an address to store it.
27828 (ArrayCreation.EmitDynamicInitializers): Use it.
27830 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27832 * expression.cs (Invocation.EmitArguments): Only probe for array
27833 property if there is more than one argument. Sorry about that.
27835 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27836 empty param arrays.
27838 * class.cs (Method.LabelParameters): Fix incorrect code path that
27839 prevented the `ParamArrayAttribute' from being applied to the
27842 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27844 * support.cs (ReflectionParameters): Correctly compute whether the
27845 last argument is a params array. Fixes the problem with
27848 * typemanager.cs: Make the assemblies array always be non-null
27849 (empty, but non-null)
27851 * tree.cs (RecordDecl): New function that abstracts the recording
27852 of names. This reports error 101, and provides a pointer to the
27853 previous declaration. Fixes a crash in the compiler.
27855 * cs-parser.jay (constructor_declaration): Update to new grammar,
27856 and provide a constructor_body that can be empty.
27858 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27860 * driver.cs: Add support for --resources.
27862 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27863 Make all types for the various array helper methods be integer.
27865 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27866 CheckState to ConvCast.
27868 (ConvCast): Now it takes a `checked' state argument, to avoid
27869 depending on the emit context for the conversion, and just using
27870 the resolve time setting.
27872 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27873 instead of Invocation.EmitArguments. We do not emit the original
27874 arguments, instead we emit those which have been converted to
27875 unsigned int expressions.
27877 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27879 * codegen.cs: ditto.
27881 * expression.cs (LocalVariableReference): Drop the use of the
27882 Store function that depended on the variable index.
27884 * statement.cs (VariableInfo): Drop the `Idx' property from this
27885 class, as this is not taking into account the indexes for
27886 temporaries tat we generate during the execution, getting the
27889 * class.cs: First emit class initializers, then call the parent
27892 * expression.cs (Binary): Fix opcode emision.
27893 (UnaryMutator.EmitCode): Support checked code generation
27895 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27896 matches for events for both the Static and Instance scans,
27897 pointing to the same element. Fix that.
27899 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27901 * rootcontext.cs (ResolveTree): Always set the
27902 interface_resolve_order, because nested interfaces will be calling
27905 * class.cs (GetInterfaceOrClass): Track the same resolution
27906 process used by TypeManager.LookupType. This fixes the nested
27907 type lookups in class declarations (separate path from
27910 (TypeContainer.DefineType): Also define nested interfaces.
27911 (TypeContainer.RegisterOrder): New public function used to
27912 register the order in which child interfaces need to be closed.
27914 Nested interfaces need to be closed after their parents have been
27917 * interface.cs (InterfaceAttr): Put all the logic for computing
27918 the interface attribute here.
27920 (DefineInterface): Register our interface order with the
27921 RootContext or with the TypeContainer depending on the case.
27923 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27925 * cs-parser.jay: rework foreach statement to work with the new
27926 changes to the policy on SimpleNames.
27928 * report.cs: support Stacktrace on warnings as well.
27930 * makefile: drop --unsafe and /unsafe from the compile.
27932 2002-03-13 Ravi Pratap <ravi@ximian.com>
27934 * ecore.cs (StandardConversionExists): Modify to take an Expression
27935 as the first parameter. Ensure we do null -> reference type conversion
27938 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27939 temporary Expression objects.
27941 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27943 * interface.cs: workaround bug in method overloading resolution
27944 (there is already a bugzilla bug for it).
27946 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27948 We could also solve this problem by having a separate path for
27949 performing type lookups, instead of DoResolve, we could have a
27950 ResolveType entry point, and only participating pieces of the
27951 production (simplename, deref, array) would implement this.
27953 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27954 signal SimpleName to only resolve type names and not attempt to
27955 resolve anything else.
27957 * expression.cs (Cast): Set the flag.
27959 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27961 * class.cs: Only report 108 if there is no `new' modifier.
27963 * cs-parser.jay: rework foreach statement to work with the new
27964 changes to the policy on SimpleNames.
27966 * report.cs: support Stacktrace on warnings as well.
27968 * makefile: drop --unsafe and /unsafe from the compile.
27970 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27972 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27973 lookups here, instead of doing that at parse time. This means
27974 that our grammar will not introduce `LocalVariableReferences' as
27975 expressions at this point. That solves the problem of code like
27979 static void Main ()
27983 This is only half the fix. The full fix requires parameters to
27984 also be handled in this way.
27986 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27987 makes the use more obvious of the DeclSpace. The
27988 ec.TypeContainer.TypeBuilder is now only used to pull the
27989 TypeBuilder for it.
27991 My theory is that I can get rid of the TypeBuilder completely from
27992 the EmitContext, and have typecasts where it is used (from
27993 DeclSpace to where it matters).
27995 The only pending problem is that the code that implements Aliases
27996 is on TypeContainer, and probably should go in DeclSpace.
27998 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27999 lookups here, instead of doing that at parse time. This means
28000 that our grammar will not introduce `LocalVariableReferences' as
28001 expressions at this point. That solves the problem of code like
28005 static void Main ()
28009 This is only half the fix. The full fix requires parameters to
28010 also be handled in this way.
28012 * class.cs (Property.DefineMethod): When implementing an interface
28013 method, set newslot, when implementing an abstract method, do not
28014 set the flag (before we tried never setting it, or always setting
28015 it, which is the difference).
28016 (Indexer.DefineMethod): same.
28017 (Method.DefineMethod): same.
28019 * ecore.cs: Only set the status used flag if we get back a Field.
28021 * attribute.cs: Temporary hack, so Paolo can keep working.
28023 2002-03-08 Ravi Pratap <ravi@ximian.com>
28025 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28026 the unmanaged type in the case we have a MarshalAs attribute.
28028 (Resolve): Handle the case when we are parsing the special MarshalAs
28029 attribute [we need to store the unmanaged type to use later]
28031 * typemanager.cs (marshal_as_attr_type): Built in type for the
28032 MarshalAs Attribute.
28034 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28035 on parameters and accordingly set the marshalling info.
28037 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28039 * class.cs: Optimizing slightly by removing redundant code after
28040 we switched to the `NoTypes' return value.
28041 (Property.DefineMethod): use NoTypes here too.
28043 This fixes the bug I introduced in my last batch of changes.
28045 2002-03-05 Ravi Pratap <ravi@ximian.com>
28047 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28049 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28050 Enums since those are types too.
28052 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28054 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28055 thanks to a call during the lookup process.
28057 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28059 * statement.cs (Foreach): Lots of work to accomodate a particular
28060 kind of foreach statement that I had not kept in mind. It is
28061 possible to have foreachs on classes that provide a GetEnumerator
28062 method that return objects that implement the "pattern" for using
28063 a foreach, there is no need to support GetEnumerator
28066 This is needed to compile nant.
28068 * decl.cs: Only report 114 if the member is not `Finalize' and if
28069 the warning level is at least 2.
28071 * class.cs: Moved the compare function from Method to
28074 (MethodSignature.InheritableMemberSignatureCompare): Add new
28075 filter function that is used to extract inheritable methods from a
28078 (Method.Define): Use the new `inheritable_method_signature_filter'
28081 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28084 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28086 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28088 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28090 * expression.cs: Pass location information to
28091 ConvertImplicitStandard.
28093 * class.cs: Added debugging code to track return values from
28096 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28098 * expression.cs (Is.DoResolve): If either side of the `is' is an
28099 interface, do not flag the warning.
28101 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28104 * report.cs: Allow for --fatal to be used with --probe.
28106 * typemanager.cs (NoTypes): Move the definition for the empty Type
28109 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28111 (TypeContainer.DefineProxy): New function used to proxy to parent
28112 implementations when implementing interfaces.
28113 (TypeContainer.ParentImplements): used to lookup if our parent
28114 implements a public function that is required by an interface.
28115 (TypeContainer.VerifyPendingMethods): Hook this up.
28117 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28118 `modules' and `assemblies' arraylists into arrays. We only grow
28119 these are the very early start up of the program, so this improves
28120 the speedof LookupType (nicely measured).
28122 * expression.cs (MakeByteBlob): Replaced unsafe code with
28123 BitConverter, as suggested by Paolo.
28125 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28126 folding of string concatenation, but if either side is a string,
28127 and the other is not, then return null, and let the runtime use
28128 the concatenation on the string plus the object (using
28129 `Object.ToString').
28131 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28133 Constant Folding has been implemented now.
28135 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28136 the error instead on types that are not supported in one's
28139 * constant.cs (Constant and all children): New set of functions to
28140 perform implict and explicit conversions.
28142 * ecore.cs (EnumConstant): Implement the new functions to perform
28143 conversion by proxying to the child expression.
28145 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28146 own separate setting that can not be turned off from the command
28147 line using --unchecked or --checked and is only controlled using
28148 the checked/unchecked statements and expressions. This setting is
28149 used by the constant folder to flag errors.
28151 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28152 ConstantCheckState as well.
28154 During Resolve, they also have to flag the state, because the
28155 constant folder runs completely in the Resolve phase.
28157 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28160 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28162 * cfold.cs: New file, this file contains the constant folder.
28164 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28165 argument to track whether we are using the resulting address to
28166 load or store a value and provide better error messages.
28168 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28169 new AddressOf arguments.
28171 * statement.cs (Foreach.EmitCollectionForeach): Update
28173 * expression.cs (Argument.Emit): Call AddressOf with proper
28174 arguments to track usage.
28176 (New.DoEmit): Call AddressOf with new arguments.
28178 (Unary.Emit): Adjust AddressOf call.
28180 2002-03-01 Ravi Pratap <ravi@ximian.com>
28182 * cs-parser.jay (member_access): Change the case for pre-defined types
28183 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28186 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28189 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28190 essentially like methods and apply attributes like MethodImplOptions to them too.
28192 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28195 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28196 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28199 * Update code everywhere accordingly.
28201 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28203 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28205 2002-02-28 Ravi Pratap <ravi@ximian.com>
28207 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28208 try performing lookups against those instead of jumping straight into using
28209 the 'using' clauses.
28211 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28213 (LookupType): Perform lookups in implicit parents too.
28215 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28216 sequence as RootContext.LookupType.
28218 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28219 the various cases of namespace lookups into this method.
28221 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28223 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28224 in positional arguments)
28226 * class.cs (Operator): Update the AllowedModifiers to contain
28229 * cs-parser.jay: Update operator declaration to allow for the
28230 operator body to be empty.
28232 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28235 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28237 * class.cs (Method.Emit): Label parameters.
28239 * driver.cs: Return 1 or 0 as the program exit code.
28241 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28243 * expression.cs: Special case the `null' object when trying to
28244 auto-compute the type, as anything can be explicitly converted to
28247 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28248 spotting this Paolo.
28250 (Expression.ImplicitNumericConversion): Perform comparissions of
28251 the type using the underlying type in the case of an enumeration
28252 rather than using the enumeration type for the compare.
28254 Cope with the underlying == type case, which is not possible to
28257 (Expression.ConvertNumericExplicit): Perform comparissions of
28258 the type using the underlying type in the case of an enumeration
28259 rather than using the enumeration type for the compare.
28261 * driver.cs: If the user does not supply an extension, assume .exe
28263 * cs-parser.jay (if_statement): Rewrote so that we can track the
28264 location for the if statement.
28266 * expression.cs (Binary.ConstantFold): Only concat strings when
28267 the operation is "+", not everything ;-)
28269 * statement.cs (Statement.EmitBoolExpression): Take a location
28271 (If, While, Do): Track location.
28273 * expression.cs (Binary.ResolveOperator): In the object + string
28274 case, I was missing a call to ConvertImplicit
28276 2002-02-25 Ravi Pratap <ravi@ximian.com>
28278 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28279 Location arguments. Ensure we use RootContext.LookupType to do our work
28280 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28282 * interface.cs (PopulateMethod): Handle the type of the parameter being
28285 * expression.cs (Invocation.BetterFunction): Handle the case when we
28286 have a params method with no fixed arguments and a call is made with no
28289 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28291 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28292 the verbatim-string-literal
28294 * support.cs (InternalParameters.ParameterModifier): handle null
28296 (InternalParameters.ParameterType): ditto.
28298 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28299 duplicating the name of the variable parameter.
28300 (GetParameterByName): Fix bug where we were not looking up array
28301 paramters if they were the only present (thanks Paolo!).
28302 (GetParameterInfo): We only have an empty set of types if both
28303 fixed and array are set to null.
28304 (GetParameterInfo-idx): Handle FixedParameter == null
28306 * cs-parser.jay: Handle the case where there is no catch
28307 statements (missing null test).
28309 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28311 * driver.cs (MainDriver): Be conservative on our command line
28314 Catch DirectoryNotFoundException when calling GetFiles.
28316 (SplitPathAndPattern): Used to split the input specification into
28317 a path and a pattern that we can feed to Directory.GetFiles.
28319 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28321 * statement.cs (Fixed): Implement the last case of the Fixed
28322 statement (string handling).
28324 * expression.cs (StringPtr): New class used to return a char * to
28325 a string; Used by the Fixed statement.
28327 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28329 * expression.cs (Binary.ResolveOperator): Remove redundant
28330 MemberLookup pn parent type.
28331 Optimize union call, we do not need a union if the types are the same.
28332 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28335 Specialize the use of MemberLookup everywhere, instead of using
28336 the default settings.
28338 (StackAlloc): Implement stackalloc keyword.
28340 * cs-parser.jay: Add rule to parse stackalloc.
28342 * driver.cs: Handle /h, /help, /?
28344 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28345 before we supported unsafe code.
28347 * makefile: add --unsafe to the self compilation of mcs.
28349 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28351 * expression.cs (PointerArithmetic): New class that is used to
28352 perform pointer arithmetic.
28353 (Binary.Resolve): Handle pointer arithmetic
28354 Handle pointer comparission.
28355 (ArrayPtr): Utility expression class that is used to take the
28356 address of an array.
28358 (ElementAccess): Implement array access for pointers
28360 * statement.cs (Fixed): Implement fixed statement for arrays, we
28361 are missing one more case before we are done.
28363 * expression.cs (Indirection): Implement EmitAssign and set the
28364 ExprClass to Variable. This allows pointer dereferences to be
28365 treated as variables, and to have values assigned to them.
28367 * ecore.cs (Expression.StoreFromPtr): New utility function to
28368 store values dereferencing.
28370 2002-02-20 Ravi Pratap <ravi@ximian.com>
28372 * expression.cs (Binary.ResolveOperator): Ensure that we are
28373 not trying to operate on a void type - this fixes the reported
28376 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28377 the parent implementation is sealed.
28379 * ../errors/cs0239.cs : Add.
28381 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28383 * typemanager.cs (unverifiable_code_type): Corresponds to
28384 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28385 which have unsafe code in them.
28387 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28390 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28392 * cs-tokenizer.cs: Add support for @"litreal strings"
28394 Make tokenizer accept pre-processor directives
28395 on any column (remove the old C-like limitation).
28397 * rootcontext.cs (EmitCode): Emit any global attributes.
28398 (AddGlobalAttributes): Used to keep track of assembly attributes.
28400 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28402 * cs-parser.jay: Add support for global attributes.
28404 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28406 * expression.cs (Indirection): New helper class. Unary will
28407 create Indirection classes to be able to implement the
28408 IMemoryLocation interface on it.
28410 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28412 * cs-parser.jay (fixed_statement): reference the right statement.
28414 * statement.cs (Fixed.Emit): Finish implementing the fixed
28415 statement for the &x case.
28417 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28419 * class.cs (Property.Define, Method.Define): Remove newslot when
28422 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28423 wrong. NewSlot should only be used if the `new' keyword is present.
28425 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28426 locating our system dir. Sorry about this.
28428 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28430 * driver.cs (GetSystemDir): Compute correctly the location of our
28431 system assemblies. I was using the compiler directory instead of
28432 the library directory.
28434 2002-02-13 Ravi Pratap <ravi@ximian.com>
28436 * expression.cs (BetterFunction): Put back in what Miguel commented out
28437 since it is the correct fix. The problem is elsewhere ;-)
28439 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28440 parameters of the parms method are themselves compatible or not !
28442 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28443 to check that a class implements an interface before saying that an implicit
28444 conversion was allowed. Use ImplementsInterface to do the checking.
28446 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28448 * class.cs (Method.Define): Track whether we are an explicit
28449 implementation or not. And only call DefineMethodOverride if we
28450 are an explicit implementation.
28452 (Property.DefineMethod): Ditto.
28454 2002-02-11 Ravi Pratap <ravi@ximian.com>
28456 * expression.cs (BetterFunction): Catch hideous bug which was
28457 preventing us from detecting ambiguous calls due to implicit casts i.e
28460 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28462 * support.cs (Pair): Remove un-needed method. I figured why I was
28463 getting the error in cs-parser.jay, the variable in a foreach loop
28464 is readonly, and the compiler does not really treat this as a variable.
28466 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28467 instead of EQUALS in grammar.
28469 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28471 * expression.cs (Unary.DoResolve): Check whether the argument is
28474 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28476 * support.cs: Api for Pair to set a value. Despite the fact that
28477 the variables are public the MS C# compiler refuses to compile
28478 code that accesses the field if the variable is part of a foreach
28481 * statement.cs (Fixed): Begin implementation of the fixed
28484 (Block.AddVariable): Return the VariableInfo on success and null
28485 on failure instead of true/false.
28487 * cs-parser.jay (foreach): Catch errors on variables already
28488 defined (we were ignoring this value before) and properly unwind
28489 the block hierarchy
28491 (fixed_statement): grammar for the fixed statement.
28493 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28495 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28496 pointer types to be incretemented.
28498 (SizeOf): Implement.
28500 * cs-parser.jay (pointer_member_access): Implement
28501 expr->IDENTIFIER production.
28503 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28504 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28507 (Unary): Implement indirection.
28509 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28510 use in non-unsafe context).
28512 (SimpleName.DoResolve): Check for pointers in field access on safe
28515 (Expression.LoadFromPtr): Factor the load-indirect code in this
28516 function. This was duplicated in UnboxCast and ParameterReference
28518 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28520 * expression.cs (ComposedCast): report an error if a pointer cast
28521 is used in a safe region.
28523 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28524 pointer type casts in unsafe context.
28526 * codegen.cs (EmitContext): Set up IsUnsafe.
28528 * cs-parser.jay (non_expression_type): Add productions for pointer
28531 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28532 code. We should not use force into static mode if the method is
28533 not virtual. Fixes bug in MIS
28535 * statement.cs (Do.Emit, While.Emit, For.Emit,
28536 Statement.EmitBoolExpression): Add support to Do and While to
28537 propagate infinite loop as `I do return' semantics.
28539 Improve the For case to also test for boolean constants.
28541 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28542 to the list of attributes we can add.
28544 Remove `EmitContext' argument.
28546 * class.cs (Method.Define): Apply parameter attributes.
28547 (Constructor.Define): Apply parameter attributes.
28548 (MethodCore.LabelParameters): Move here the core of labeling
28551 * support.cs (ReflectionParameters.ParameterModifier,
28552 InternalParameters.ParameterModifier): Use IsByRef on the type and
28553 only return the OUT bit for these parameters instead of in/out/ref
28556 This is because I miss-understood things. The ParameterInfo.IsIn
28557 and IsOut represent whether the parameter has the [In] and [Out]
28560 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28562 * ecore.cs (FieldExpr.Emit): Release temporaries.
28564 * assign.cs (LocalTemporary.Release): new function.
28566 * codegen.cs (EmitContext.GetTemporaryStorage,
28567 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28568 temporary storage. Now we can "put back" localbuilders when we
28571 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28573 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28574 need to make a copy of the variable to generate verifiable code.
28576 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28578 * driver.cs: Compute dynamically the system directory.
28580 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28581 Slower, but more generally useful. Used by the abstract
28582 registering implementation.
28584 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28585 the rules for the special rule on Type/instances. First check if
28586 we have the same name, and if so, try that special static path
28587 rather than the instance path.
28589 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28591 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28594 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28595 Enum, ValueType, Delegate or Array for non-corlib compiles.
28597 * cs-tokenizer.cs: Catch long identifiers (645)
28599 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28602 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28603 fix, we were returning too early, so we were not registering
28604 pending methods from abstract classes.
28606 Do not register pending methods if the class is abstract.
28608 * expression.cs (Conditional.DoResolve): Report circular implicit
28609 conversions when we neecd to compute it for conditional
28612 (Is.DoResolve): If the expression is always of the provided type,
28613 flag warning 183. If the expression can not ever be of the
28614 provided type flag warning 184.
28616 * class.cs: Catch 169 as well.
28618 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28621 2002-01-18 Nick Drochak <ndrochak@gol.com>
28623 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28625 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28627 * interface.cs: (PopulateMethod): Check for pointers being defined
28628 only if the unsafe context is active.
28629 (PopulateProperty): ditto.
28630 (PopulateIndexer): ditto.
28632 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28633 specified. If pointers are present, make sure that they are
28634 present in an unsafe context.
28635 (Constructor, Constructor.Define): ditto.
28636 (Field, Field.Define): ditto.
28637 (Property, Property.Define): ditto.
28638 (Event, Event.Define): ditto.
28640 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28641 hashtable if there are classes or structs defined.
28643 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28644 code, as the constant resolution moved.
28646 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28647 the metadata, so we can flag error 133.
28649 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28650 pointer is being declared in an unsafe context.
28652 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28654 * modifiers.cs (Modifiers.Check): Require a Location argument.
28655 Report error 227 for Unsafe use.
28657 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28659 * statement.cs (For.Emit): If the test is null, then report that
28660 we do `return', as we wont reach anything afterwards.
28662 (Switch.SwitchGoverningType): Track the expression that matched
28665 * driver.cs: Allow negative numbers as an error code to flag.
28667 * cs-parser.jay: Handle 1551.
28669 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28671 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28673 * cs-parser.jay: Report 1518 (type declaration can only contain
28674 class, struct, interface, enum or delegate)
28676 (switch_label): Report 1523 (keywords `case' or `default' must
28679 (opt_switch_sections): Report 1522 (empty switch)
28681 * driver.cs: Report 1515 (response file specified multiple times)
28682 Report 1516 (Source file specified multiple times).
28684 * expression.cs (Argument.Resolve): Signal 1510
28686 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28687 access not allowed in static code)
28689 2002-01-11 Ravi Pratap <ravi@ximian.com>
28691 * typemanager.cs (IsPointerType): Utility method which we are going
28694 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28695 the object type, so we take care of that.
28697 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28699 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28700 added to non-params parameters :-)
28702 * typemanager.cs (CSharpName): Include 'void' type too.
28704 (void_ptr_type): Include in the set of core types.
28706 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28709 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28712 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28713 completely forgotten about it.
28715 2002-01-10 Ravi Pratap <ravi@ximian.com>
28717 * cs-parser.jay (pointer_type): Add. This begins our implementation
28718 of parsing rules for unsafe code.
28720 (unsafe_statement): Implement.
28722 (embedded_statement): Modify to include the above.
28724 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28726 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28727 if the current context is an unsafe one.
28729 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28730 are handled differently, we need separate rules for them.
28732 (local_variable_declaration): Update to use local_variable_pointer_type
28733 to allow variable declarations of unmanaged pointer types.
28735 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28736 in unsafe contexts.
28738 * ../errors/cs0214.cs : Add.
28740 2002-01-16 Nick Drochak <ndrochak@gol.com>
28742 * makefile: remove 'response' file when cleaning.
28744 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28746 * cs-parser.jay: Report 1524.
28748 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28750 * typemanager.cs (RegisterMethod): drop checking if we have
28751 registered this from here
28753 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28755 * class.cs (Method.EmitDestructor): Implement calling our base
28758 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28759 value of InFinally.
28761 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28762 this routine and will wrap the call in a try/catch block. Deal
28765 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28767 * ecore.cs (Expression.MemberLookup): instead of taking a
28768 parameter `same_type' that was used to tell whether we could
28769 access private members we compute our containing type from the
28772 (FieldExpr): Added partial support for volatile fields. This does
28773 not work for volatile fields exposed from assemblies, as I can not
28774 figure out how to extract the modreq from it.
28776 Updated all the source files to use this.
28778 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28779 because it is referenced by MemberLookup very often.
28781 2002-01-09 Ravi Pratap <ravi@ximian.com>
28783 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28784 TypeBuilder.GetCustomAttributes to retrieve what we need.
28786 Get rid of redundant default_member_attr_type as this is the same as
28787 default_member_type which already exists.
28789 * interface.cs, attribute.cs : Update accordingly.
28791 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28793 * typemanager.cs: Enable IndexerPropertyName again. It does not
28794 work for TYpeBuilders though. Ravi, can you please fix this?
28796 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28798 * expression.cs (Argument.Emit): Handle the case of ref objects
28799 being passed to ref functions;
28801 (ParameterReference.EmitLoad): Loads the content of the pointer
28802 without dereferencing.
28804 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28806 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28808 2002-01-08 Ravi Pratap <ravi@ximian.com>
28810 * class.cs (Indexer.DefineMethod): Incorporate the interface
28811 type in the name of the method if we are doing explicit interface
28814 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28816 (BetterConversion): Fix extremely trivial bug where we were referring to
28817 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28820 * ../errors/bug16.cs : Add although we have fixed it.
28822 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28824 * expression.cs (BaseIndexer): Begin implementation.
28826 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28828 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28829 production directly to remove a shift/reduce, and implement
28830 explicit interface implementation.
28832 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28833 after a floating point suffix.
28835 * expression.cs (DoNumericPromotions): Improved the conversion for
28836 uint/uint. If we have a constant, we avoid doing a typecast to a
28839 * class.cs (Indexer): Implement explicit interface implementation
28842 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28844 * class.cs: make the default instance constructor public and hidebysig.
28846 2001-01-03 Ravi Pratap <ravi@ximian.com>
28848 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28849 so we can call it from elsewhere.
28851 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28852 we emit it internally if the class has a defined indexer; otherwise the user
28853 emits it by decorating the class definition with the DefaultMemberAttribute.
28855 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28856 attribute is not used on a type which defines an indexer.
28858 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28859 character when we skip whitespace.
28861 * ../errors/cs0646.cs : Add.
28863 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28865 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28868 * makefile: Add practical target `mcs3.exe' which builds the third
28869 generation compiler.
28871 * expression.cs (New): Fix structures constructor calling.
28873 * class.cs (Property, Method, Indexer): Emit Final flag on the
28874 method if we are an interface implementation and we are not
28877 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28878 whether this property is referencing a `base' method.
28880 * expression.cs (Invocation.EmitCall): take an extra argument:
28881 is_base, this is used to determine whether the `call' or
28882 `callvirt' opcode should be used.
28885 * delegate.cs: update EmitCall.
28887 * class.cs (Method.Define): Set NewSlot for the cases where we are
28888 not implementing an interface method.
28890 (Property.Define): ditto.
28892 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28894 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28895 'r'. Allows mcs to parse itself fully.
28897 2002-01-02 Ravi Pratap <ravi@ximian.com>
28899 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28900 of the number of initializers that require the InitializeArray method.
28902 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28903 update the above field where necessary.
28905 (MakeByteBlob): Update accordingly.
28907 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28910 (EmitDynamicInitializers): Update in accordance with the new optimization.
28912 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28913 same OpCode applies.
28915 * cs-parser.jay : Fix some glaring errors I introduced.
28917 2002-01-01 Ravi Pratap <ravi@ximian.com>
28919 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28920 so that we can check for name clashes there too.
28922 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28923 for interface indexers.
28925 * interfaces.cs (Define): Emit the default member attribute.
28927 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28928 variable was being referred to while setting the value ;-)
28930 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28932 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28933 byte-by-byte information when we know the data is zero.
28935 Make the block always a multiple of 4, because
28936 DefineInitializedData has a bug.
28938 * assign.cs: Fix, we should assign from the temporary, not from
28941 * expression.cs (MakeByteBlob): Fix my incorrect code.
28943 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28945 * typemanager.cs (EnumToUnderlying): This function is used to get
28946 the underlying type from an enumeration, because it does not
28949 * constant.cs: Use the I4_S form for values between -128 and 127.
28951 * statement.cs (Block.LookupLabel): Looks up a label.
28952 (Block): Drop support for labeled blocks.
28954 (LabeledStatement): New kind of statement that represents a label
28957 (Goto): Finally implement this bad boy.
28959 * cs-parser.jay: Update to reflect new mechanism to implement
28962 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28964 * codegen.cs (EmitContext.This): a codegen property that keeps the
28965 a single instance of this instead of creating many different this
28968 * delegate.cs (Delegate.DoResolve): Update to use the property;
28970 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28972 * expression.cs (BaseAccess.DoResolve): Ditto.
28974 2001-12-29 Ravi Pratap <ravi@ximian.com>
28976 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28977 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28979 (InitCoreTypes): Update accordingly.
28981 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28982 so we can quickly store the state.
28984 (ApplyAttributes): Set the correct implementation flags
28985 for InternalCall methods.
28987 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28989 * expression.cs (EmitCall): if a method is not virtual, then do
28990 not use callvirt on it.
28992 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28993 user defined stuff) requires the use of stobj, which takes an
28994 address on the stack instead of an array and an index. So emit
28995 the Ldelema operation for it.
28997 (EmitStoreOpcode): Use stobj for valuetypes.
28999 (UnaryMutator.EmitCode): Use the right 1 value depending on
29000 whether we are dealing with int64/uint64, float or doubles.
29002 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29003 constructors that I implemented last night.
29005 (Constructor.IsDefault): Fix to work properly for static
29008 * cs-parser.jay (CheckDef): report method signature errors.
29009 Update error number 103 to be 132.
29011 * decl.cs: New AdditionResult enumeration value: MethodExists.
29012 Although we do this check for methods later on in the semantic
29013 analysis, catching repeated default constructors is so easy that
29014 we catch these here.
29016 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29019 (ParameterReference.EmitAssign, Emit): handle
29022 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29023 (ArrayAccess.EmitStoreOpcode): ditto.
29025 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29027 * expression.cs (MakeByteBlob): Complete all the missing types
29028 (uint, short, ushort, byte, sbyte)
29030 * class.cs: Only init instance field initializers on instance
29033 Rename `constructors' to instance_constructors.
29035 (TypeContainer.AddConstructor): Only add constructors to the list
29036 if it is not static.
29038 Make sure that we handle default_static_constructor independently
29039 everywhere where we handle instance_constructors
29041 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29043 * class.cs: Do not lookup or create a base initializer for a
29044 static constructor.
29046 (ConstructorInitializer.Resolve): use the proper type to lookup
29049 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29051 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29054 * decl.cs: CloseType is now an virtual method, the default
29055 implementation just closes this type.
29057 2001-12-28 Ravi Pratap <ravi@ximian.com>
29059 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29060 to PreserveSig by default. Also emit HideBySig on such methods.
29062 Basically, set the defaults to standard values.
29064 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29065 argument, if candidate is better, it can't be worse than the best !
29067 (Invocation): Re-write bits to differentiate between methods being
29068 applicable in their expanded form and their normal form - for params
29071 Get rid of use_standard everywhere as only standard conversions are allowed
29072 in overload resolution.
29074 More spec conformance.
29076 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29078 * driver.cs: Add --timestamp, to see where the compiler spends
29081 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29082 `this' in static code.
29084 (SimpleName.DoResolve): Implement in terms of a helper function
29085 that allows static-references to be passed upstream to
29088 (Expression.ResolveWithSimpleName): Resolve specially simple
29089 names when called by MemberAccess to implement the special
29092 (Expression.ImplicitReferenceConversion): Handle conversions from
29093 Null to reference types before others, as Null's type is
29096 * expression.cs (Invocation.EmitCall): Handle the special case of
29097 calling methods declared on a reference type from a ValueType
29098 (Base classes System.Object and System.Enum)
29100 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29101 the left hand side is a TypeExpr, not on every enumeration.
29103 (Binary.Resolve): If types are reference types, then do a cast to
29104 object on operators != and == of both arguments.
29106 * typemanager.cs (FindMembers): Extract instance and static
29107 members if requested.
29109 * interface.cs (PopulateProperty): Use void_type instead of null
29110 as the return type for the setter method.
29112 (PopulateIndexer): ditto.
29114 2001-12-27 Ravi Pratap <ravi@ximian.com>
29116 * support.cs (ReflectionParameters): Fix minor bug where we
29117 were examining the wrong parameter for the ParamArray attribute.
29119 Cope with requests for the type of the parameter at position
29120 greater than the params parameter's. We now return the element
29121 type of the params array as that makes more sense.
29123 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29124 accordingly as we no longer have to extract the element type
29127 (Invocation.OverloadResolve): Update.
29129 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29131 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29132 against IEnumerator, test whether the return value is a descendant
29133 of the IEnumerator interface.
29135 * class.cs (Indexer.Define): Use an auxiliary method to implement
29136 the other bits of the method definition. Begin support for
29137 explicit interface implementation.
29139 (Property.DefineMethod): Use TypeManager.void_type instead of null
29140 for an empty return value.
29142 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29144 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29145 dealing with a FieldExpr which is composed of a FieldBuilder, in
29146 the code path we did extract the constant, but we should have
29147 obtained the underlying value to be able to cast it (otherwise we
29148 end up in an infinite loop, this is what Ravi was running into).
29150 (ArrayCreation.UpdateIndices): Arrays might be empty.
29152 (MemberAccess.ResolveMemberAccess): Add support for section
29153 14.5.4.1 that deals with the special case of E.I when E is a type
29154 and something else, that I can be a reference to a static member.
29156 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29157 handle a particular array type to create byte blobs, it is just
29158 something we dont generate byteblobs for.
29160 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29163 * location.cs (Push): remove the key from the hashtable that we
29164 are about to add. This happens for empty files.
29166 * driver.cs: Dispose files after we have parsed them.
29168 (tokenize): new function that only runs the tokenizer on its
29169 input, for speed testing.
29171 2001-12-26 Ravi Pratap <ravi@ximian.com>
29173 * class.cs (Event.Define): Define the private field only if there
29174 are no accessors defined.
29176 * expression.cs (ResolveMemberAccess): If there is no associated
29177 field with the event, that means we have an event defined with its
29178 own accessors and we should flag error cs0070 since transforming
29179 ourselves into a field is not valid in that case.
29181 * ecore.cs (SimpleName.DoResolve): Same as above.
29183 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29184 and charset to sane values.
29186 2001-12-25 Ravi Pratap <ravi@ximian.com>
29188 * assign.cs (DoResolve): Perform check on events only if they
29189 are being accessed outside the declaring type.
29191 * cs-parser.jay (event_declarations): Update rules to correctly
29192 set the type of the implicit parameter etc.
29194 (add_accessor, remove_accessor): Set current local parameters.
29196 * expression.cs (Binary): For delegate addition and subtraction,
29197 cast the return value from the method into the appropriate delegate
29200 2001-12-24 Ravi Pratap <ravi@ximian.com>
29202 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29203 of these as the workaround is unnecessary.
29205 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29206 delegate data - none of that is needed at all.
29208 Re-write bits to extract the instance expression and the delegate method
29211 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29214 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29215 of attaching attributes instead of duplicating code everywhere.
29217 * everywhere : Update code to do attribute emission using the above method.
29219 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29221 * expression.cs (IsParamsMethodApplicable): if there are not
29222 parameters, return immediately.
29224 * ecore.cs: The 0 literal can be implicity converted to an enum
29227 (SimpleName.DoResolve): First lookup the type, then lookup the
29230 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29231 want to get its address. If the InstanceExpression is not
29232 addressable, store the result in a temporary variable, then get
29235 * codegen.cs: Only display 219 errors on warning level or above.
29237 * expression.cs (ArrayAccess): Make it implement the
29238 IMemoryLocation interface.
29240 (Binary.DoResolve): handle the operator == (object a, object b)
29241 and operator != (object a, object b) without incurring into a
29242 BoxedCast (because 5 != o should never be performed).
29244 Handle binary enumerator operators.
29246 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29247 value type, otherwise use Ldelem_ref.
29249 Use precomputed names;
29251 (AddressOf): Implement address of
29253 * cs-parser.jay (labeled_statement): Fix recursive block
29254 addition by reworking the production.
29256 * expression.cs (New.DoEmit): New has a special case:
29258 If we are dealing with a ValueType, we have a few
29259 situations to deal with:
29261 * The target of New is a ValueType variable, that is
29262 easy, we just pass this as the variable reference
29264 * The target of New is being passed as an argument,
29265 to a boxing operation or a function that takes a
29268 In this case, we need to create a temporary variable
29269 that is the argument of New.
29272 2001-12-23 Ravi Pratap <ravi@ximian.com>
29274 * rootcontext.cs (LookupType): Check that current_type is not null before
29275 going about looking at nested types.
29277 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29278 not implement the IAssignMethod interface any more.
29280 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29281 where we tranform them into FieldExprs if they are being resolved from within
29282 the declaring type.
29284 * ecore.cs (SimpleName.DoResolve): Do the same here.
29286 * assign.cs (DoResolve, Emit): Clean up code considerably.
29288 * ../errors/bug10.cs : Add.
29290 * ../errors/cs0070.cs : Add.
29292 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29294 * assign.cs : Get rid of EventIsLocal everywhere.
29296 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29298 * ecore.cs (ConvertIntLiteral): finished the implementation.
29300 * statement.cs (SwitchLabel): Convert the value we are using as a
29301 key before looking up the table.
29303 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29305 * codegen.cs (EmitTopBlock): Require a Location argument now.
29307 * cs-parser.jay (constructor_declarator): We need to setup
29308 current_local_parameters before we parse the
29309 opt_constructor_initializer, to allow the variables to be bound
29310 to the constructor arguments.
29312 * rootcontext.cs (LookupType): First lookup nested classes in our
29313 class and our parents before we go looking outside our class.
29315 * expression.cs (ConstantFold): Extract/debox the values at the
29318 * rootcontext.cs (EmitCode): Resolve the constants first before we
29319 resolve the types. This is not really needed, but it helps debugging.
29321 * statement.cs: report location.
29323 * cs-parser.jay: pass location to throw statement.
29325 * driver.cs: Small bug fix.
29327 * report.cs: Updated format to be 4-zero filled digits.
29329 2001-12-22 Ravi Pratap <ravi@ximian.com>
29331 * expression.cs (CheckIndices): Fix minor bug where the wrong
29332 variable was being referred to ;-)
29334 (DoEmit): Do not call EmitStaticInitializers when the
29335 underlying type is System.Object.
29337 2001-12-21 Ravi Pratap <ravi@ximian.com>
29339 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29340 and do the usual workaround for SRE.
29342 * class.cs (MyEventBuilder.EventType): New member to get at the type
29343 of the event, quickly.
29345 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29347 * assign.cs (Assign.DoResolve): Handle the case when the target
29348 is an EventExpr and perform the necessary checks.
29350 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29353 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29355 (EventExpr): Set the type in the constructor itself since we
29356 are meant to be born fully resolved.
29358 (EventExpr.Define): Revert code I wrote earlier.
29360 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29361 instance expression is null. The instance expression is a This in that case
29362 or a null, depending on whether it is a static method or not.
29364 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29365 refers to more than one method.
29367 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29368 and accordingly flag errors.
29370 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29372 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29374 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29376 * location.cs (ToString): Provide useful rutine.
29378 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29380 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29381 objects, return the actual integral boxed.
29383 * statement.cs (SwitchLabel): define an ILLabel for each
29386 (Switch.CheckSwitch): If the value is a Literal, extract
29387 the underlying literal.
29389 Also in the unused hashtable we had, add the SwitchLabel so we can
29390 quickly look this value up.
29392 * constant.cs: Implement a bunch of new constants. Rewrite
29393 Literal based on this. Made changes everywhere to adapt to this.
29395 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29396 dereferencing array only once, and also copes with enumrations.
29398 bytes are two bytes wide, not one.
29400 (Cast): Perform constant conversions.
29402 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29403 wrappers to the literals here.
29405 * expression.cs (DoNumericPromotions): long literals can converted
29406 to ulong implicity (this is taken care of elsewhere, but I was
29407 missing this spot).
29409 * ecore.cs (Expression.Literalize): Make the return type Literal,
29410 to improve type checking.
29412 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29414 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29416 * literal.cs: Revert code from ravi that checked the bounds. The
29417 bounds are sane by the definition of the type itself.
29419 * typemanager.cs: Fix implementation of ImplementsInterface. We
29420 need to actually look up in our parent hierarchy for interfaces
29423 * const.cs: Use the underlying type for enumerations
29425 * delegate.cs: Compute the basename for the delegate creation,
29426 that should fix the delegate test case, and restore the correct
29427 Type Lookup semantics in rootcontext
29429 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29430 referencing a nested type with the Reflection API is using the "+"
29433 * cs-parser.jay: Do not require EOF token at the end.
29435 2001-12-20 Ravi Pratap <ravi@ximian.com>
29437 * rootcontext.cs (LookupType): Concatenate type names with
29438 a '.' instead of a '+' The test suite passes again.
29440 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29441 field of the enumeration.
29443 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29444 the case when the member is an EventExpr.
29446 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29447 static has an associated instance expression.
29449 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29451 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29453 * class.cs (Event.Define): Register event and perform appropriate checks
29456 We define the Add and Remove methods even if the use provides none because
29457 in that case, we provide default implementations ourselves.
29459 Define a private field of the type of the event. This is done by the CSC compiler
29460 and we should be doing it too ;-)
29462 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29463 More methods we use in code we generate.
29465 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29468 (InitCoreTypes): Update accordingly for the above.
29470 * class.cs (Event.Emit): Generate code for default accessors that we provide
29472 (EmitDefaultMethod): Do the job in the above.
29474 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29477 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29479 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29480 builders even if we were missing one.
29482 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29483 pass the Basename as our class name instead of the Name. The
29484 basename will be correctly composed for us.
29486 * parameter.cs (Paramters): Now takes a Location argument.
29488 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29489 make all the code call directly LookupType in RootContext and take
29490 this chance to pass the Location information everywhere.
29492 * Everywhere: pass Location information.
29494 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29496 * class.cs (Constructor.Define): Updated way of detecting the
29497 length of the parameters.
29499 (TypeContainer.DefineType): Use basename as the type name for
29502 (TypeContainer.Define): Do not recursively define types here, as
29503 definition is taken care in order by the RootContext.
29505 * tree.cs: Keep track of namespaces in a per-file basis.
29507 * parameter.cs (Parameter.ComputeSignature): Update to use
29510 (Parameters.GetSignature): ditto.
29512 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29513 instead of a TypeContainer.
29515 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29516 resolve names. Because we need to be resolve in our context, not
29519 * driver.cs: Implement response files.
29521 * class.cs (TypeContainer.DefineType): If we are defined, do not
29522 redefine ourselves.
29524 (Event.Emit): Emit the code for add/remove handlers.
29525 (Event.Define): Save the MethodBuilders for add/remove.
29527 * typemanager.cs: Use pair here too.
29529 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29530 DictionaryEntry requires the first argument to be non-null.
29532 (enum_declaration): Compute full name for registering the
29535 (delegate_declaration): Instead of using
29536 formal_parameter_list, use opt_formal_parameter_list as the list
29539 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29540 (EventParsing): New property that controls whether `add' and
29541 `remove' are returned as tokens or identifiers (for events);
29543 2001-12-19 Ravi Pratap <ravi@ximian.com>
29545 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29546 use MyEventBuilder only and let it wrap the real builder for us.
29548 (MyEventBuilder): Revamp constructor etc.
29550 Implement all operations that we perform on EventBuilder in precisely the same
29553 (FindMembers): Update to use the EventBuilder member.
29555 (Event.Emit): Update accordingly.
29557 2001-12-18 Ravi Pratap <ravi@ximian.com>
29559 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29560 by calling the appropriate methods.
29562 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29565 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29567 2001-12-17 Ravi Pratap <ravi@ximian.com>
29569 * delegate.cs (Delegate.Populate): Check that the return type
29570 and various parameters types are indeed accessible.
29572 * class.cs (Constructor.Define): Same here.
29574 (Field.Define): Ditto.
29576 (Event.Define): Ditto.
29578 (Operator.Define): Check that the underlying Method defined itself
29579 correctly - so it's MethodBuilder should not be null.
29581 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29582 expression happens to be null.
29584 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29585 members but as of now we don't seem to be able to do anything really useful with it.
29587 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29588 not the EventBuilder.
29590 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29592 * cs-tokenizer.cs: Add support for defines.
29593 Add support for #if, #elif, #else, #endif
29595 (eval_var): evaluates a variable.
29596 (eval): stubbed for evaluating functions.
29598 * cs-parser.jay: Pass the defines information
29600 * driver.cs: Add --define command line option.
29602 * decl.cs: Move MemberCore here.
29604 Make it the base class for DeclSpace. This allows us to catch and
29605 report 108 and 109 for everything now.
29607 * class.cs (TypeContainer.Define): Extract all the members
29608 before populating and emit the warning 108 (new keyword required
29609 to override) instead of having each member implement this.
29611 (MemberCore.Define): New abstract method, we will be using this in
29612 the warning reporting engine in Populate.
29614 (Operator.Define): Adjust to new MemberCore protocol.
29616 * const.cs (Const): This does not derive from Expression, it is a
29617 temporary object we use to create fields, it is a MemberCore.
29619 * class.cs (Method.Define): Allow the entry point to be in a
29622 * driver.cs: Rewrite the argument handler to clean it up a bit.
29624 * rootcontext.cs: Made it just an auxiliary namespace feature by
29625 making everything static.
29627 * driver.cs: Adapt code to use RootContext type name instead of
29630 * delegate.cs: Remove RootContext argument.
29632 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29635 * class.cs (Event.Define): The lookup can fail.
29637 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29639 * expression.cs: Resolve the this instance before invoking the code.
29641 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29643 * cs-parser.jay: Add a production in element_access that allows
29644 the thing to become a "type" reference. This way we can parse
29645 things like "(string [])" as a type.
29647 Note that this still does not handle the more complex rules of
29651 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29653 * ecore.cs: (CopyNewMethods): new utility function used to
29654 assemble the list of methods from running FindMembers.
29656 (MemberLookup): Rework FindMembers so that
29658 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29660 * class.cs (TypeContainer): Remove Delegates who fail to be
29663 * delegate.cs (Populate): Verify that we dont get null return
29664 values. TODO: Check for AsAccessible.
29666 * cs-parser.jay: Use basename to emit error 574 (destructor should
29667 have the same name as container class), not the full name.
29669 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29670 possible representation.
29672 Also implements integer type suffixes U and L.
29674 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29676 * expression.cs (ArrayCreation.DoResolve): We need to do the
29677 argument resolution *always*.
29679 * decl.cs: Make this hold the namespace. Hold the root context as
29681 (LookupType): Move here.
29683 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29685 * location.cs (Row, Name): Fixed the code, it was always returning
29686 references to the first file.
29688 * interface.cs: Register properties defined through interfaces.
29690 * driver.cs: Add support for globbing on the command line
29692 * class.cs (Field): Make it derive from MemberCore as well.
29695 2001-12-15 Ravi Pratap <ravi@ximian.com>
29697 * class.cs (Event::Define): Check that the type of the event is a delegate
29698 type else flag error #66.
29700 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29703 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29704 values of EntryPoint, CharSet etc etc.
29706 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29708 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29709 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29710 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29711 which needs this to do its work.
29713 * ../errors/cs0066.cs : Add.
29715 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29717 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29720 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29721 clears out the parameters field.
29722 (MemberSignatureCompare): Cleanup
29724 (MemberCore): New base class used to share code between MethodCore
29727 (RegisterRequiredImplementations) BindingFlags.Public requires
29728 either BindingFlags.Instace or Static. Use instance here.
29730 (Property): Refactored code to cope better with the full spec.
29732 * parameter.cs (GetParameterInfo): Return an empty array instead
29735 * class.cs (Property): Abstract or extern properties have no bodies.
29737 * parameter.cs (GetParameterInfo): return a zero-sized array.
29739 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29740 method modifier validation to the typecontainer so we can reuse
29741 this on properties.
29743 (MethodCore.ParameterTypes): return an empty sized array of types.
29745 (Property.Define): Test property modifier validity.
29747 Add tests for sealed/override too.
29749 (Method.Emit): abstract or extern methods have no bodies.
29751 2001-12-14 Ravi Pratap <ravi@ximian.com>
29753 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29756 (Method::Define, ::Emit): Modify accordingly.
29758 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29760 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29762 * makefile: Pass in /unsafe.
29764 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29766 * class.cs (MakeKey): Kill routine.
29768 * class.cs (TypeContainer.Define): Correctly define explicit
29769 method implementations (they require the full interface name plus
29772 * typemanager.cs: Deply the PtrHashtable here and stop using the
29773 lame keys. Things work so much better.
29775 This of course broke everyone who depended on `RegisterMethod' to
29776 do the `test for existance' test. This has to be done elsewhere.
29778 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29779 the object stupid Equals method (because, that like fails all over
29780 the place). We still do not use it.
29782 * class.cs (TypeContainer.SetRequiredInterface,
29783 TypeContainer.RequireMethods): Killed these two routines and moved
29784 all the functionality to RegisterRequiredImplementations.
29786 (TypeContainer.RegisterRequiredImplementations): This routine now
29787 registers all the implementations required in an array for the
29788 interfaces and abstract methods. We use an array of structures
29789 which can be computed ahead of time to reduce memory usage and we
29790 also assume that lookups are cheap as most classes will not
29791 implement too many interfaces.
29793 We also avoid creating too many MethodSignatures.
29795 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29796 clear the "pending" bit if we find that there are problems with
29799 (TypeContainer.VerifyPendingMethods): Update to report errors of
29800 methods that look like implementations but are not.
29802 (TypeContainer.Define): Add support for explicit interface method
29805 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29807 * typemanager.cs: Keep track of the parameters here instead of
29808 being a feature of the TypeContainer.
29810 * class.cs: Drop the registration of parameters here, as
29811 InterfaceMethods are also interface declarations.
29813 * delegate.cs: Register methods with the TypeManager not only with
29814 the TypeContainer. This code was buggy.
29816 * interface.cs: Full registation here.
29818 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29820 * expression.cs: Remove reducer for binary expressions, it can not
29823 * const.cs: Put here the code that used to go into constant.cs
29825 * constant.cs: Put here the code for constants, this is a new base
29826 class for Literals.
29828 * literal.cs: Make Literal derive from Constant.
29830 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29832 * statement.cs (Return.Emit): Report error 157 if the user
29833 attempts to return from a finally block.
29835 (Return.Emit): Instead of emitting a return, jump to the end of
29838 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29839 LocalBuilder to store the result of the function. ReturnLabel is
29840 the target where we jump.
29843 2001-12-09 Radek Doulik <rodo@ximian.com>
29845 * cs-parser.jay: remember alias in current namespace
29847 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29850 * class.cs (LookupAlias): lookup alias in my_namespace
29852 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29854 (LookupAlias): lookup alias in this and if needed in parent
29857 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29861 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29862 making things static. I need this to avoid passing the
29863 TypeContainer when calling ParameterType.
29865 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29866 that did string manipulation to compute the type and then call
29867 GetType. Use Parameter.ParameterType instead.
29869 * cs-tokenizer.cs: Consume the suffix for floating values.
29871 * expression.cs (ParameterReference): figure out whether this is a
29872 reference parameter or not. Kill an extra variable by computing
29873 the arg_idx during emission.
29875 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29876 function that returns whether a parameter is an out/ref value or not.
29878 (Parameter.ParameterType): The type of the parameter (base,
29879 without ref/out applied).
29881 (Parameter.Resolve): Perform resolution here.
29882 (Parameter.ExternalType): The full type (with ref/out applied).
29884 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29885 support for expressions on the using statement.
29887 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29889 * statement.cs (Using.EmitLocalVariableDecls): Split the
29890 localvariable handling of the using statement.
29892 (Block.EmitMeta): Keep track of variable count across blocks. We
29893 were reusing slots on separate branches of blocks.
29895 (Try.Emit): Emit the general code block, we were not emitting it.
29897 Check the type of the declaration to be an IDisposable or
29898 something that can be implicity converted to it.
29900 Emit conversions if required.
29902 * ecore.cs (EmptyExpression): New utility class.
29903 (Expression.ImplicitConversionExists): New utility function.
29905 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29907 * statement.cs (Using): Implement.
29909 * expression.cs (LocalVariableReference): Support read only variables.
29911 * statement.cs: Remove the explicit emit for the Leave opcode.
29912 (VariableInfo): Add a readonly field.
29914 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29916 * ecore.cs (ConvCast): new class used to encapsulate the various
29917 explicit integer conversions that works in both checked and
29918 unchecked contexts.
29920 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29921 properly generate the overflow opcodes.
29923 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29925 * statement.cs: The correct type for the EmptyExpression is the
29926 element_type, not the variable type. Ravi pointed this out.
29928 2001-12-04 Ravi Pratap <ravi@ximian.com>
29930 * class.cs (Method::Define): Handle PInvoke methods specially
29931 by using DefinePInvokeMethod instead of the usual one.
29933 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29934 above to do the task of extracting information and defining the method.
29936 2001-12-04 Ravi Pratap <ravi@ximian.com>
29938 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29939 of the condition for string type.
29941 (Emit): Move that here.
29943 (ArrayCreation::CheckIndices): Keep string literals in their expression
29946 (EmitDynamicInitializers): Handle strings appropriately.
29948 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29950 * codegen.cs (EmitContext): Replace multiple variables with a
29951 single pointer to the current Switch statement.
29953 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29956 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29960 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29963 (Foreach.Emit): Foreach on arrays was not setting
29964 up the loop variables (for break/continue).
29966 (GotoCase): Semi-implented.
29968 2001-12-03 Ravi Pratap <ravi@ximian.com>
29970 * attribute.cs (CheckAttribute): Handle system attributes by using
29971 Attribute.GetAttributes to examine information we need.
29973 (GetValidPlaces): Same here.
29975 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29977 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29979 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29981 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29983 (Method::Emit): Handle the case when we are a PInvoke method.
29985 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29987 * expression.cs: Use ResolveWithSimpleName on compound names.
29989 2001-12-02 Ravi Pratap <ravi@ximian.com>
29991 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29992 before trying to reduce it.
29994 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29996 * constant.cs (LookupConstantValue): Implement.
29998 (EmitConstant): Use the above in emitting the constant.
30000 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30001 that are user-defined by doing a LookupConstantValue on them.
30003 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30006 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30008 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30010 (BaseAccess.DoResolve): Implement.
30012 (MemberAccess.DoResolve): Split this routine into a
30013 ResolveMemberAccess routine that can be used independently
30015 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30017 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30018 As that share bits of the implementation. Is returns a boolean,
30019 while As returns the Type that is being probed.
30021 2001-12-01 Ravi Pratap <ravi@ximian.com>
30023 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30024 instead of a Literal - much easier.
30026 (EnumInTransit): Remove - utterly useless :-)
30028 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30030 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30032 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30033 chain when we have no associated expression.
30035 2001-11-30 Ravi Pratap <ravi@ximian.com>
30037 * constant.cs (Define): Use Location while reporting the errror.
30039 Also emit a warning when 'new' is used and there is no inherited
30042 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30045 (LookupEnumValue): Implement to lookup an enum member's value and define it
30048 (Populate): Re-write accordingly to use the above routine.
30050 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30052 * expression.cs (This): Fix prototype for DoResolveLValue to
30053 override the base class DoResolveLValue.
30055 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30058 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30059 (we need to load the address of the field here). This fixes
30062 (FieldExpr.DoResolveLValue): Call the DoResolve
30063 function to initialize the Instance expression.
30065 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30066 correctly the GetEnumerator operation on a value type.
30068 * cs-parser.jay: Add more simple parsing error catches.
30070 * statement.cs (Switch): Add support for string switches.
30071 Handle null specially.
30073 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30075 2001-11-28 Ravi Pratap <ravi@ximian.com>
30077 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30079 (declare_local_constant): New helper function.
30081 * statement.cs (AddConstant): Keep a separate record of constants
30083 (IsConstant): Implement to determine if a variable is a constant.
30085 (GetConstantExpression): Implement.
30087 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30089 * statement.cs (IsVariableDefined): Re-write.
30091 2001-11-27 Ravi Pratap <ravi@ximian.com>
30093 * class.cs (TypeContainer::FindMembers): Look for constants
30094 in the case when we are looking for MemberTypes.Field
30096 * expression.cs (MemberAccess::DoResolve): Check that in the
30097 case we are a FieldExpr and a Literal, we are not being accessed
30098 by an instance reference.
30100 * cs-parser.jay (local_constant_declaration): Implement.
30102 (declaration_statement): Implement for constant declarations.
30104 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30106 * statement.cs (Switch): Catch double defaults.
30108 (Switch): More work on the switch() statement
30109 implementation. It works for integral values now, need to finish
30113 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30115 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30116 integer literals into other integer literals. To be used by
30119 2001-11-24 Ravi Pratap <ravi@ximian.com>
30121 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30124 (EmitDynamicInitializers): Cope with the above since we extract data
30125 directly from ArrayData now.
30127 (ExpectInitializers): Keep track of whether initializers are mandatory
30130 (Bounds): Make it a hashtable to prevent the same dimension being
30131 recorded for every element in that dimension.
30133 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30136 Also fix bug which was causing the indices to be emitted in the reverse
30139 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30141 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30142 unfinished. They do not work, because the underlying code is
30145 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30147 * cs-parser.jay: Remove bogus fixme.
30149 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30150 on Switch statement.
30152 2001-11-23 Ravi Pratap <ravi@ximian.com>
30154 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30157 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30158 parameter. Apparently, any expression is allowed.
30160 (ValidateInitializers): Update accordingly.
30162 (CheckIndices): Fix some tricky bugs thanks to recursion.
30164 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30165 I was being completely brain-dead.
30167 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30168 and re-write acordingly.
30170 (DelegateInvocation): Re-write accordingly.
30172 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30174 (MakeByteBlob): Handle types more correctly.
30176 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30177 initialization from expressions but it is incomplete because I am a complete
30180 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30182 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30183 on If. Basically, we have to return `true' (ie, we do return to
30184 our caller) only if both branches of the if return.
30186 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30187 short-circuit operators, handle them as short circuit operators.
30189 (Cast.DoResolve): Resolve type.
30190 (Cast.Cast): Take an expression as the target type.
30192 * cs-parser.jay (cast_expression): Remove old hack that only
30193 allowed a limited set of types to be handled. Now we take a
30194 unary_expression and we resolve to a type during semantic
30197 Use the grammar productions from Rhys to handle casts (this is
30198 not complete like Rhys syntax yet, we fail to handle that corner
30199 case that C# has regarding (-x), but we will get there.
30201 2001-11-22 Ravi Pratap <ravi@ximian.com>
30203 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30204 field which is an array type.
30206 * cs-parser.jay (declare_local_variables): Support array initialization too.
30208 * typemanager.cs (MakeKey): Implement.
30210 (everywhere): Use the above appropriately.
30212 * cs-parser.jay (for_statement): Update for array initialization while
30213 declaring variables.
30215 * ecore.cs : The error message was correct, it's the variable's names that
30216 were misleading ;-) Make the code more readable.
30218 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30219 the correct type etc.
30221 (ConvertExplicit): Handle Enum types by examining the underlying type.
30223 2001-11-21 Ravi Pratap <ravi@ximian.com>
30225 * parameter.cs (GetCallingConvention): Always return
30226 CallingConventions.Standard for now.
30228 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30230 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30231 and `r' after calling DoNumericPromotions.
30233 * ecore.cs: Fix error message (the types were in the wrong order).
30235 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30236 BindingFlags.Instance as well
30238 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30239 implicit int literal conversion in an empty cast so that we
30240 propagate the right type upstream.
30242 (UnboxCast): new class used to unbox value types.
30243 (Expression.ConvertExplicit): Add explicit type conversions done
30246 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30247 the target type before applying the implicit LongLiterals to ULong
30250 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30252 * cs-parser.jay (for_statement): Reworked the way For works: now
30253 we declare manually any variables that are introduced in
30254 for_initializer to solve the problem of having out-of-band code
30255 emition (that is what got for broken).
30257 (declaration_statement): Perform the actual variable declaration
30258 that used to be done in local_variable_declaration here.
30260 (local_variable_declaration): Do not declare anything, just pass
30261 the information on a DictionaryEntry
30263 2001-11-20 Ravi Pratap <ravi@ximian.com>
30265 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30266 re-write of the logic to now make it recursive.
30268 (UpdateIndices): Re-write accordingly.
30270 Store element data in a separate ArrayData list in the above methods.
30272 (MakeByteBlob): Implement to dump the array data into a byte array.
30274 2001-11-19 Ravi Pratap <ravi@ximian.com>
30276 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30279 * constant.cs (Define): Implement.
30281 (EmitConstant): Re-write fully.
30283 Pass in location info.
30285 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30288 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30289 DictionaryEntry since we need location info too.
30291 (constant_declaration): Update accordingly.
30293 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30294 code into another method : UpdateIndices.
30296 2001-11-18 Ravi Pratap <ravi@ximian.com>
30298 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30299 some type checking etc.
30301 2001-11-17 Ravi Pratap <ravi@ximian.com>
30303 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30304 bits to provide dimension info if the user skips doing that.
30306 Update second constructor to store the rank correctly.
30308 2001-11-16 Ravi Pratap <ravi@ximian.com>
30310 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30311 and try to implement.
30313 * ../errors/cs0150.cs : Add.
30315 * ../errors/cs0178.cs : Add.
30317 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30319 * statement.cs: Implement foreach on multi-dimensional arrays.
30321 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30322 name of the params argument.
30324 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30325 initializing the array.
30327 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30328 we can use this elsewhere.
30330 * statement.cs: Finish implementation of foreach for single
30333 * cs-parser.jay: Use an out-of-band stack to pass information
30334 around, I wonder why I need this.
30336 foreach_block: Make the new foreach_block the current_block.
30338 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30339 function used to return a static Parameters structure. Used for
30340 empty parameters, as those are created very frequently.
30342 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30344 2001-11-15 Ravi Pratap <ravi@ximian.com>
30346 * interface.cs : Default modifier is private, not public. The
30347 make verify test passes again.
30349 2001-11-15 Ravi Pratap <ravi@ximian.com>
30351 * support.cs (ReflectionParameters): Fix logic to determine
30352 whether the last parameter is a params one. Test 9 passes again.
30354 * delegate.cs (Populate): Register the builders we define with
30355 RegisterParameterForBuilder. Test 19 passes again.
30357 * cs-parser.jay (property_declaration): Reference $6 instead
30358 of $$ to get at the location.
30360 (indexer_declaration): Similar stuff.
30362 (attribute): Ditto.
30364 * class.cs (Property): Register parameters for the Get and Set methods
30365 if they exist. Test 23 passes again.
30367 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30368 call to EmitArguments as we are sure there aren't any params arguments.
30369 Test 32 passes again.
30371 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30372 IndexOutOfRangeException.
30374 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30375 Test 33 now passes again.
30377 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30379 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30380 broke a bunch of things. Will have to come up with a better way
30381 of tracking locations.
30383 * statement.cs: Implemented foreach for single dimension arrays.
30385 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30387 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30388 an error. This removes the lookup from the critical path.
30390 * cs-parser.jay: Removed use of temporary_loc, which is completely
30393 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30395 * support.cs (ReflectionParameters.ParameterModifier): Report
30396 whether the argument is a PARAMS argument or not.
30398 * class.cs: Set the attribute `ParamArrayAttribute' on the
30399 parameter argument.
30401 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30402 and cons_param_array_attribute (ConstructorInfo for
30403 ParamArrayAttribute).,
30405 * codegen.cs: Emit the return using the `Return' statement, that
30406 way we can report the error correctly for missing return values.
30408 * class.cs (Method.Emit): Clean up.
30410 * expression.cs (Argument.Resolve): Take another argument: the
30411 location where this argument is used. Notice that this is not
30412 part of the "Argument" class as to reduce the size of the
30413 structure (we know the approximate location anyways).
30415 Test if the argument is a variable-reference, if not, then
30416 complain with a 206.
30418 (Argument.Emit): Emit addresses of variables.
30420 (Argument.FullDesc): Simplify.
30422 (Invocation.DoResolve): Update for Argument.Resolve.
30424 (ElementAccess.DoResolve): ditto.
30426 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30427 method should be virtual, as this method is always virtual.
30429 (NewDelegate.DoResolve): Update for Argument.Resolve.
30431 * class.cs (ConstructorInitializer.DoResolve): ditto.
30433 * attribute.cs (Attribute.Resolve): ditto.
30435 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30437 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30439 * expression.cs (ParameterReference): Drop IStackStorage and implement
30440 IAssignMethod instead.
30442 (LocalVariableReference): ditto.
30444 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30445 IAssignMethod instead.
30447 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30449 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30450 enumerations that are used in heavily used structures derive from
30451 byte in a laughable and pathetic attempt to reduce memory usage.
30452 This is the kind of pre-optimzations that you should not do at
30453 home without adult supervision.
30455 * expression.cs (UnaryMutator): New class, used to handle ++ and
30456 -- separatedly from the other unary operators. Cleans up the
30457 code, and kills the ExpressionStatement dependency in Unary.
30459 (Unary): Removed `method' and `Arguments' from this class, making
30460 it smaller, and moving it all to SimpleCall, so I can reuse this
30461 code in other locations and avoid creating a lot of transient data
30462 strucutres when not required.
30464 * cs-parser.jay: Adjust for new changes.
30466 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30468 * enum.cs (Enum.Populate): If there is a failure during
30471 * cs-parser.jay (opt_enum_base): we used to catch type errors
30472 here, but this is really incorrect. The type error should be
30473 catched during semantic analysis.
30475 2001-12-11 Ravi Pratap <ravi@ximian.com>
30477 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30478 current_local_parameters as expected since I, in my stupidity, had forgotten
30481 * attribute.cs (GetValidPlaces): Fix stupid bug.
30483 * class.cs (Method::Emit): Perform check on applicability of attributes.
30485 (Constructor::Emit): Ditto.
30487 (Field::Emit): Ditto.
30489 (Field.Location): Store location information.
30491 (Property, Event, Indexer, Operator): Ditto.
30493 * cs-parser.jay (field_declaration): Pass in location for each field.
30495 * ../errors/cs0592.cs : Add.
30497 2001-11-12 Ravi Pratap <ravi@ximian.com>
30499 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30501 (InitCoreTypes): Update accordingly.
30503 (RegisterAttrType, LookupAttr): Implement.
30505 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30506 info about the same.
30508 (Resolve): Update to populate the above as necessary.
30510 (Error592): Helper.
30512 (GetValidPlaces): Helper to the above.
30514 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30516 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30518 2001-11-12 Ravi Pratap <ravi@ximian.com>
30520 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30522 * ../errors/cs0617.cs : Add.
30524 2001-11-11 Ravi Pratap <ravi@ximian.com>
30526 * enum.cs (Emit): Rename to Populate to be more consistent with what
30527 we expect it to do and when exactly it is called.
30529 * class.cs, rootcontext.cs : Update accordingly.
30531 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30532 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30534 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30536 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30537 of a fieldinfo using the above, when dealing with a FieldBuilder.
30539 2001-11-10 Ravi Pratap <ravi@ximian.com>
30541 * ../errors/cs0031.cs : Add.
30543 * ../errors/cs1008.cs : Add.
30545 * ../errrors/cs0543.cs : Add.
30547 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30550 (FindMembers): Implement.
30552 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30553 enums and delegates too.
30555 (enum_types): Rename to builder_to_enum.
30557 (delegate_types): Rename to builder_to_delegate.
30559 * delegate.cs (FindMembers): Implement.
30561 2001-11-09 Ravi Pratap <ravi@ximian.com>
30563 * typemanager.cs (IsEnumType): Implement.
30565 * enum.cs (Emit): Re-write parts to account for the underlying type
30566 better and perform checking etc.
30568 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30569 of the underlying type.
30571 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30574 * enum.cs (error31): Helper to report error #31.
30576 * cs-parser.jay (enum_declaration): Store location of each member too.
30578 * enum.cs (member_to_location): New hashtable.
30580 (AddEnumMember): Update location hashtable.
30582 (Emit): Use the location of each member while reporting errors.
30584 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30586 * cs-parser.jay: A for_initializer if is a
30587 local_variable_declaration really ammount to have an implicit
30588 block with the variable declaration and no initializer for for.
30590 * statement.cs (For.Emit): Cope with null initializers.
30592 This fixes the infinite loop on for initializers.
30594 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30596 * enum.cs: More cleanup.
30598 * ecore.cs: Remove dead code.
30600 * class.cs (Property.Emit): More simplification.
30601 (Event.Emit): ditto.
30603 Reworked to have less levels of indentation.
30605 2001-11-08 Ravi Pratap <ravi@ximian.com>
30607 * class.cs (Property): Emit attributes.
30617 * enum.cs (Emit): Ditto.
30619 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30622 * class.cs (Field, Event, etc.): Move attribute generation into the
30623 Emit method everywhere.
30625 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30626 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30627 as we had no way of defining nested enums !
30629 * rootcontext.cs : Adjust code accordingly.
30631 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30633 2001-11-07 Ravi Pratap <ravi@ximian.com>
30635 * expression.cs (EvalConstantExpression): Move into ecore.cs
30637 * enum.cs (Enum): Rename some members and make them public and readonly
30638 according to our convention.
30640 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30643 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30645 (Enum::Emit): Write a simple version for now which doesn't try to compute
30646 expressions. I shall modify this to be more robust in just a while.
30648 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30650 (TypeContainer::CloseType): Create the Enum types too.
30652 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30654 * expression.cs (EvalConstantExpression): Get rid of completely.
30656 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30657 user-defined values and other cases.
30659 (IsValidEnumLiteral): Helper function.
30661 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30662 out there in the case we had a literal FieldExpr.
30664 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30666 (Literalize): Revamp a bit to take two arguments.
30668 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30670 2001-11-06 Ravi Pratap <ravi@ximian.com>
30672 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30674 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30676 (Resolve): Use the above to ensure we have proper initializers.
30678 2001-11-05 Ravi Pratap <ravi@ximian.com>
30680 * expression.cs (Expression::EvalConstantExpression): New method to
30681 evaluate constant expressions.
30683 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30685 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30687 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30690 (Binary.ResolveOperator): Handle operator != (object a, object b)
30691 and operator == (object a, object b);
30693 (Binary.DoNumericPromotions): Indicate whether the numeric
30694 promotion was possible.
30696 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30699 Made the ArrayAccess implement interface IAssignMethod instead of
30700 IStackStore as the order in which arguments are passed reflects
30703 * assign.cs: Instead of using expr.ExprClass to select the way of
30704 assinging, probe for the IStackStore/IAssignMethod interfaces.
30706 * typemanager.cs: Load InitializeArray definition.
30708 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30709 static data that can be used to initialize arrays.
30711 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30713 * expression.cs: Handle operator== and operator!= for booleans.
30715 (Conditioal.Reduce): Implement reducer for the ?: operator.
30717 (Conditional.Resolve): Implement dead code elimination.
30719 (Binary.Resolve): Catch string literals and return a new
30720 concatenated string.
30722 (Unary.Reduce): Implement reduction of unary expressions.
30724 * ecore.cs: Split out the expression core handling here.
30726 (Expression.Reduce): New method used to perform constant folding
30727 and CSE. This is needed to support constant-expressions.
30729 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30730 targets, and optimize for !x.
30732 2001-11-04 Ravi Pratap <ravi@ximian.com>
30734 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30735 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30736 set custom atttributes.
30738 * literal.cs (Literal::GetValue): New abstract method to return the actual
30739 value of the literal, cast as an object.
30741 (*Literal): Implement GetValue method.
30743 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30744 expressions to the arraylist but objects of type Argument.
30746 * class.cs (TypeContainer::Emit): Emit our attributes too.
30748 (Method::Emit, Constructor::Emit): Ditto.
30750 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30751 to be ignoring earlier.
30753 2001-11-03 Ravi Pratap <ravi@ximian.com>
30755 * attribute.cs (AttributeSection::Define): Implement to do the business
30756 of constructing a CustomAttributeBuilder.
30758 (Attribute): New trivial class. Increases readability of code.
30760 * cs-parser.jay : Update accordingly.
30762 (positional_argument_list, named_argument_list, named_argument): New rules
30764 (attribute_arguments): Use the above so that we are more correct.
30766 2001-11-02 Ravi Pratap <ravi@ximian.com>
30768 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30769 to perform all checks for a method with a params parameter.
30771 (Invocation::OverloadResolve): Update to use the above method and therefore
30772 cope correctly with params method invocations.
30774 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30777 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30778 constructors in our parent too because we can't afford to miss out on
30781 * attribute.cs (AttributeSection): New name for the class Attribute
30783 Other trivial changes to improve readability.
30785 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30786 use the new class names.
30788 2001-11-01 Ravi Pratap <ravi@ximian.com>
30790 * class.cs (Method::Define): Complete definition for params types too
30792 (Indexer::Define): Ditto.
30794 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30795 Cope everywhere with a request for info about the array parameter.
30797 2001-11-01 Ravi Pratap <ravi@ximian.com>
30799 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30801 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30802 local_variable_type to extract the string corresponding to the type.
30804 (local_variable_type): Fixup the action to use the new helper method.
30806 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30809 * expression.cs : Clean out code which uses the above.
30811 2001-10-31 Ravi Pratap <ravi@ximian.com>
30813 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30814 and bale out if necessary by returning a false.
30816 (RegisterProperty): Ditto.
30818 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30819 and print out appropriate error messages.
30821 * interface.cs (everywhere): Ditto.
30823 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30824 location to constructor.
30826 * class.cs (Property, Event, Indexer): Update accordingly.
30828 * ../errors/cs111.cs : Added.
30830 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30831 of a method, as laid down by the spec.
30833 (Invocation::OverloadResolve): Use the above method.
30835 2001-10-31 Ravi Pratap <ravi@ximian.com>
30837 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30838 now take a TypeContainer and a Parameters object.
30840 (ParameterData): Modify return type of ParameterModifier method to be
30841 Parameter.Modifier and not a string.
30843 (ReflectionParameters, InternalParameters): Update accordingly.
30845 * expression.cs (Argument::GetParameterModifier): Same here.
30847 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30848 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30849 symbol in it at all so maybe this is only for now.
30851 2001-10-30 Ravi Pratap <ravi@ximian.com>
30853 * support.cs (InternalParameters): Constructor now takes an extra argument
30854 which is the actual Parameters class.
30856 (ParameterDesc): Update to provide info on ref/out modifiers.
30858 * class.cs (everywhere): Update call to InternalParameters to pass in
30859 the second argument too.
30861 * support.cs (ParameterData): Add ParameterModifier, which is a method
30862 to return the modifier info [ref/out etc]
30864 (InternalParameters, ReflectionParameters): Implement the above.
30866 * expression.cs (Argument::ParameterModifier): Similar function to return
30867 info about the argument's modifiers.
30869 (Invocation::OverloadResolve): Update to take into account matching modifiers
30872 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30873 a new SetFormalParameters object which we pass to InternalParameters.
30875 2001-10-30 Ravi Pratap <ravi@ximian.com>
30877 * expression.cs (NewArray): Merge into the ArrayCreation class.
30879 2001-10-29 Ravi Pratap <ravi@ximian.com>
30881 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30882 NewUserdefinedArray into one as there wasn't much of a use in having
30885 * expression.cs (Argument): Change field's name to ArgType from Type.
30887 (Type): New readonly property which returns the proper type, taking into
30888 account ref/out modifiers.
30890 (everywhere): Adjust code accordingly for the above.
30892 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30893 whether we are emitting for a ref or out parameter.
30895 * expression.cs (Argument::Emit): Use the above field to set the state.
30897 (LocalVariableReference::Emit): Update to honour the flag and emit the
30900 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30902 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30904 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30906 (ReflectionParameters, InternalParameters): Implement the above method.
30908 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30911 (Invocation::FullMethodDesc): Ditto.
30913 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30915 * cs-parser.jay: Add extra production for the second form of array
30918 * expression.cs (ArrayCreation): Update to reflect the above
30921 * Small changes to prepare for Array initialization.
30923 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30925 * typemanager.cs (ImplementsInterface): interface might be null;
30926 Deal with this problem;
30928 Also, we do store negative hits on the cache (null values), so use
30929 this instead of calling t.GetInterfaces on the type everytime.
30931 2001-10-28 Ravi Pratap <ravi@ximian.com>
30933 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30935 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30936 split functionality out into different classes.
30938 (New::FormArrayType): Move into NewBuiltinArray.
30940 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30943 (NewBuiltinArray): New class to handle creation of built-in arrays.
30945 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30946 account creation of one-dimensional arrays.
30948 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30950 (NewUserdefinedArray::DoResolve): Implement.
30952 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30954 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30955 we maintain inside the TypeManager. This is necessary to perform lookups on the
30958 (LookupType): Update to perform GetType on the module builders too.
30960 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30962 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30964 2001-10-23 Ravi Pratap <ravi@ximian.com>
30966 * expression.cs (New::DoResolve): Implement guts of array creation.
30968 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30970 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30972 * expression.cs: Fix bug I introduced lsat night that broke
30975 (Expression.Resolve): Report a 246 error (can not resolve name)
30976 if we find a SimpleName in the stream.
30978 (Expression.ResolveLValue): Ditto.
30980 (Expression.ResolveWithSimpleName): This function is a variant of
30981 ResolveName, this one allows SimpleNames to be returned without a
30982 warning. The only consumer of SimpleNames is MemberAccess
30984 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30986 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30987 might arrive here. I have my doubts that this is correct.
30989 * statement.cs (Lock): Implement lock statement.
30991 * cs-parser.jay: Small fixes to support `lock' and `using'
30993 * cs-tokenizer.cs: Remove extra space
30995 * driver.cs: New flag --checked, allows to turn on integer math
30998 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30999 Threading.Monitor.Exit
31001 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31003 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31004 Expression Class to be IndexerAccess.
31006 Notice that Indexer::DoResolve sets the eclass to Value.
31008 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31010 * class.cs (TypeContainer::Emit): Emit code for indexers.
31012 * assign.cs (IAssignMethod): New interface implemented by Indexers
31013 and Properties for handling assignment.
31015 (Assign::Emit): Simplify and reuse code.
31017 * expression.cs (IndexerAccess, PropertyExpr): Implement
31018 IAssignMethod, clean up old code.
31020 2001-10-22 Ravi Pratap <ravi@ximian.com>
31022 * typemanager.cs (ImplementsInterface): New method to determine if a type
31023 implements a given interface. Provides a nice cache too.
31025 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31028 (ConvertReferenceExplicit): Ditto.
31030 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31031 various methods, with correct names etc.
31033 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31034 Operator.UnaryNegation.
31036 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31037 we have a unary plus or minus operator.
31039 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31042 * everywhere : update accordingly.
31044 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31047 * class.cs (Method::Define): For the case where we are implementing a method
31048 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31049 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31051 2001-10-21 Ravi Pratap <ravi@ximian.com>
31053 * interface.cs (FindMembers): Implement to work around S.R.E
31056 * typemanager.cs (IsInterfaceType): Implement.
31058 (FindMembers): Update to handle interface types too.
31060 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31061 use IsAssignableFrom as that is not correct - it doesn't work.
31063 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31064 and accordingly override EmitStatement.
31066 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31067 using the correct logic :-)
31069 2001-10-19 Ravi Pratap <ravi@ximian.com>
31071 * ../errors/cs-11.cs : Add to demonstrate error -11
31073 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31075 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31076 then pass this as a hint to ResolveLValue.
31078 * expression.cs (FieldExpr): Add Location information
31080 (FieldExpr::LValueResolve): Report assignment to readonly
31083 (Expression::ExprClassFromMemberInfo): Pass location information.
31085 (Expression::ResolveLValue): Add new method that resolves an
31088 (Expression::DoResolveLValue): Default invocation calls
31091 (Indexers): New class used to keep track of indexers in a given
31094 (IStackStore): Renamed from LValue, as it did not really describe
31095 what this did. Also ResolveLValue is gone from this interface and
31096 now is part of Expression.
31098 (ElementAccess): Depending on the element access type
31100 * typemanager.cs: Add `indexer_name_type' as a Core type
31101 (System.Runtime.CompilerServices.IndexerNameAttribute)
31103 * statement.cs (Goto): Take a location.
31105 2001-10-18 Ravi Pratap <ravi@ximian.com>
31107 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31108 if two delegates are compatible.
31110 (NewDelegate::DoResolve): Update to take care of the case when
31111 we instantiate a delegate from another delegate.
31113 * typemanager.cs (FindMembers): Don't even try to look up members
31114 of Delegate types for now.
31116 2001-10-18 Ravi Pratap <ravi@ximian.com>
31118 * delegate.cs (NewDelegate): New class to take care of delegate
31121 * expression.cs (New): Split the delegate related code out into
31122 the NewDelegate class.
31124 * delegate.cs (DelegateInvocation): New class to handle delegate
31127 * expression.cs (Invocation): Split out delegate related code into
31128 the DelegateInvocation class.
31130 2001-10-17 Ravi Pratap <ravi@ximian.com>
31132 * expression.cs (New::DoResolve): Implement delegate creation fully
31133 and according to the spec.
31135 (New::DoEmit): Update to handle delegates differently.
31137 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31138 because of which we were printing out arguments in reverse order !
31140 * delegate.cs (VerifyMethod): Implement to check if the given method
31141 matches the delegate.
31143 (FullDelegateDesc): Implement.
31145 (VerifyApplicability): Implement.
31147 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31148 delegate invocations too.
31150 (Invocation::Emit): Ditto.
31152 * ../errors/cs1593.cs : Added.
31154 * ../errors/cs1594.cs : Added.
31156 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31158 2001-10-16 Ravi Pratap <ravi@ximian.com>
31160 * typemanager.cs (intptr_type): Core type for System.IntPtr
31162 (InitCoreTypes): Update for the same.
31164 (iasyncresult_type, asynccallback_type): Ditto.
31166 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31169 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31172 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31173 the builders for the 4 members of a delegate type :-)
31175 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31178 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31180 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31182 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31184 * statement.cs (Break::Emit): Implement.
31185 (Continue::Emit): Implement.
31187 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31188 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31189 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31190 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31193 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31194 properties that track the label for the current loop (begin of the
31195 loop and end of the loop).
31197 2001-10-15 Ravi Pratap <ravi@ximian.com>
31199 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31200 use of emitting anything at all.
31202 * class.cs, rootcontext.cs : Get rid of calls to the same.
31204 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31206 (Populate): Define the constructor correctly and set the implementation
31209 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31212 (AddDelegateType): Implement.
31214 (IsDelegateType): Implement helper method.
31216 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31218 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31219 and accordingly handle it.
31221 * delegate.cs (Populate): Take TypeContainer argument.
31222 Implement bits to define the Invoke method. However, I still haven't figured out
31223 how to take care of the native int bit :-(
31225 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31226 Qualify the name of the delegate, not its return type !
31228 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31231 (StandardConversionExists): Checking for array types turns out to be recursive.
31233 (ConvertReferenceExplicit): Implement array conversion.
31235 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31237 2001-10-12 Ravi Pratap <ravi@ximian.com>
31239 * cs-parser.jay (delegate_declaration): Store the fully qualified
31240 name as it is a type declaration.
31242 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31245 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31246 as TypeContainer::DefineType.
31248 (Populate): Method in which all the definition of the various methods (Invoke)
31251 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31254 (CloseDelegate): Finally creates the delegate.
31256 * class.cs (TypeContainer::DefineType): Update to define delegates.
31257 (Populate, Emit and CloseType): Do the same thing here too.
31259 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31260 delegates in all these operations.
31262 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31264 * expression.cs: LocalTemporary: a new expression used to
31265 reference a temporary that has been created.
31267 * assign.cs: Handle PropertyAccess back here, so that we can
31268 provide the proper semantic access to properties.
31270 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31271 a few more explicit conversions.
31273 * modifiers.cs: `NEW' modifier maps to HideBySig.
31275 * expression.cs (PropertyExpr): Make this into an
31276 ExpressionStatement, and support the EmitStatement code path.
31278 Perform get/set error checking, clean up the interface.
31280 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31281 them into toplevel access objects.
31283 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31285 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31288 * typemanager.cs: Keep track here of our PropertyBuilders again to
31289 work around lameness in SRE.
31291 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31293 * expression.cs (LValue::LValueResolve): New method in the
31294 interface, used to perform a second resolution pass for LValues.
31296 (This::DoResolve): Catch the use of this in static methods.
31298 (This::LValueResolve): Implement.
31300 (This::Store): Remove warning, assigning to `this' in structures
31303 (Invocation::Emit): Deal with invocation of
31304 methods on value types. We need to pass the address to structure
31305 methods rather than the object itself. (The equivalent code to
31306 emit "this" for structures leaves the entire structure on the
31307 stack instead of a pointer to it).
31309 (ParameterReference::DoResolve): Compute the real index for the
31310 argument based on whether the method takes or not a `this' pointer
31311 (ie, the method is static).
31313 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31314 value types returned from functions when we need to invoke a
31315 method on the sturcture.
31318 2001-10-11 Ravi Pratap <ravi@ximian.com>
31320 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31321 defining the type in the Modulebuilder or Typebuilder. This is to take
31322 care of nested types which need to be defined on the TypeBuilder using
31323 DefineNestedMethod.
31325 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31326 methods in RootContext, only ported to be part of TypeContainer.
31328 (TypeContainer::GetInterfaceOrClass): Ditto.
31330 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31332 * interface.cs (Interface::DefineInterface): New method. Does exactly
31333 what RootContext.CreateInterface did earlier, only it takes care of nested types
31336 (Interface::GetInterfaces): Move from RootContext here and port.
31338 (Interface::GetInterfaceByName): Same here.
31340 * rootcontext.cs (ResolveTree): Re-write.
31342 (PopulateTypes): Re-write.
31344 * class.cs (TypeContainer::Populate): Populate nested types too.
31345 (TypeContainer::Emit): Emit nested members too.
31347 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31348 instead just use the name argument passed in as it is already fully
31351 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31352 to TypeContainer mapping to see if a type is user-defined.
31354 * class.cs (TypeContainer::CloseType): Implement.
31356 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31357 the default constructor.
31359 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31362 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31364 * interface.cs (CloseType): Create the type here.
31366 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31369 Remove all the methods which are now in TypeContainer.
31371 2001-10-10 Ravi Pratap <ravi@ximian.com>
31373 * delegate.cs (Define): Re-write bits to define the delegate
31376 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31378 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31380 * expression.cs (ImplicitReferenceConversion): handle null as well
31381 as a source to convert to any reference type.
31383 * statement.cs (Return): Perform any implicit conversions to
31384 expected return type.
31386 Validate use of return statement.
31388 * codegen.cs (EmitContext): Pass the expected return type here.
31390 * class.cs (Method, Constructor, Property): Pass expected return
31391 type to EmitContext.
31393 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31395 * expression.cs: Make DoResolve take an EmitContext instead of a
31398 Replaced `l' and `location' for `loc', for consistency.
31400 (Error, Warning): Remove unneeded Tc argument.
31402 * assign.cs, literal.cs, constant.cs: Update to new calling
31405 * codegen.cs: EmitContext now contains a flag indicating whether
31406 code is being generated in a static method or not.
31408 * cs-parser.jay: DecomposeQI, new function that replaces the old
31409 QualifiedIdentifier. Now we always decompose the assembled
31410 strings from qualified_identifier productions into a group of
31413 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31415 * rootcontext.cs: Deal with field-less struct types correctly now
31416 by passing the size option to Define Type.
31418 * class.cs: Removed hack that created one static field.
31420 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31422 * statement.cs: Moved most of the code generation here.
31424 2001-10-09 Ravi Pratap <ravi@ximian.com>
31426 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31429 (ElementAccess): Remove useless bits for now - keep checks as the spec
31432 2001-10-08 Ravi Pratap <ravi@ximian.com>
31434 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31435 and start performing checks according to the spec.
31437 2001-10-07 Ravi Pratap <ravi@ximian.com>
31439 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31440 rank_specifiers instead.
31442 (rank_specifiers): Change the order in which the rank specifiers are stored
31444 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31446 * expression.cs (ElementAccess): Implement the LValue interface too.
31448 2001-10-06 Ravi Pratap <ravi@ximian.com>
31450 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31451 except that user defined conversions are not included.
31453 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31454 perform the conversion of the return type, if necessary.
31456 (New::DoResolve): Check whether we are creating an array or an object
31457 and accordingly do the needful.
31459 (New::Emit): Same here.
31461 (New::DoResolve): Implement guts of array creation.
31463 (New::FormLookupType): Helper function.
31465 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31467 * codegen.cs: Removed most of the code generation here, and move the
31468 corresponding code generation bits to the statement classes.
31470 Added support for try/catch/finalize and throw.
31472 * cs-parser.jay: Added support for try/catch/finalize.
31474 * class.cs: Catch static methods having the flags override,
31475 virtual or abstract.
31477 * expression.cs (UserCast): This user cast was not really doing
31478 what it was supposed to do. Which is to be born in fully resolved
31479 state. Parts of the resolution were being performed at Emit time!
31483 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31485 * expression.cs: Implicity convert the result from UserCast.
31487 2001-10-05 Ravi Pratap <ravi@ximian.com>
31489 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31490 prevented it from working correctly.
31492 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31493 merely ConvertImplicit.
31495 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31497 * typemanager.cs: Make the LookupTypeContainer function static,
31498 and not per-instance.
31500 * class.cs: Make static FindMembers (the one that takes a Type
31503 * codegen.cs: Add EmitForeach here.
31505 * cs-parser.jay: Make foreach a toplevel object instead of the
31506 inline expansion, as we need to perform semantic analysis on it.
31508 2001-10-05 Ravi Pratap <ravi@ximian.com>
31510 * expression.cs (Expression::ImplicitUserConversion): Rename to
31511 UserDefinedConversion.
31513 (Expression::UserDefinedConversion): Take an extra argument specifying
31514 whether we look for explicit user conversions too.
31516 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31518 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31520 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31521 with the appropriate arguments.
31523 * cs-parser.jay (cast_expression): Record location too.
31525 * expression.cs (Cast): Record location info.
31527 (Expression::ConvertExplicit): Take location argument.
31529 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31530 to determine if we are doing explicit conversions.
31532 (UserCast::Emit): Update accordingly.
31534 (Expression::ConvertExplicit): Report an error if everything fails.
31536 * ../errors/cs0030.cs : Add.
31538 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31540 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31541 virtual and newslot bits.
31543 * class.cs (TypeContainer::RegisterRequiredImplementations):
31544 Record methods we need.
31546 (TypeContainer::MakeKey): Helper function to make keys for
31547 MethodBases, since the Methodbase key is useless.
31549 (TypeContainer::Populate): Call RegisterRequiredImplementations
31550 before defining the methods.
31552 Create a mapping for method_builders_to_methods ahead of time
31553 instead of inside a tight loop.
31555 (::RequireMethods): Accept an object as the data to set into the
31556 hashtable so we can report interface vs abstract method mismatch.
31558 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31560 * report.cs: Make all of it static.
31562 * rootcontext.cs: Drop object_type and value_type computations, as
31563 we have those in the TypeManager anyways.
31565 Drop report instance variable too, now it is a global.
31567 * driver.cs: Use try/catch on command line handling.
31569 Add --probe option to debug the error reporting system with a test
31572 * report.cs: Add support for exiting program when a probe
31573 condition is reached.
31575 2001-10-03 Ravi Pratap <ravi@ximian.com>
31577 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31578 we do a forcible conversion regardless of type, to check if
31579 ForceConversion returns a null.
31581 (Binary::error19): Use location to report error.
31583 (Unary::error23): Use location here too.
31585 * ../errors/cs0019.cs : Check in.
31587 * ../errors/cs0023.cs : Check in.
31589 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31590 case of a non-null MethodInfo object with a length of 0 !
31592 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31593 an applicable member - according to the spec :-)
31594 Also fix logic to find members in base types.
31596 (Unary::ResolveOperator): Same here.
31598 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31599 as I was getting thoroughly confused between this and error19 :-)
31601 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31602 (::FindMostEncompassedType): Implement.
31603 (::FindMostEncompassingType): Implement.
31604 (::StandardConversionExists): Implement.
31606 (UserImplicitCast): Re-vamp. We now need info about most specific
31607 source and target types so that we can do the necessary conversions.
31609 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31610 mathematical union with no duplicates.
31612 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31614 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31615 in order from base classes to child classes, so that we can in
31616 child classes look up in our parent for method names and
31617 attributes (required for handling abstract, virtual, new, override
31618 constructs: we need to instrospect our base class, and if we dont
31619 populate the classes in order, the introspection might be
31620 incorrect. For example, a method could query its parent before
31621 the parent has any methods and would determine that the parent has
31622 no abstract methods (while it could have had them)).
31624 (RootContext::CreateType): Record the order in which we define the
31627 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31629 * class.cs (TypeContainer::Populate): Also method definitions can
31630 fail now, keep track of this.
31632 (TypeContainer::FindMembers): Implement support for
31633 DeclaredOnly/noDeclaredOnly flag.
31635 (Constructor::Emit) Return the ConstructorBuilder.
31637 (Method::Emit) Return the MethodBuilder.
31638 Check for abstract or virtual methods to be public.
31640 * rootcontext.cs (RootContext::CreateType): Register all the
31641 abstract methods required for the class to be complete and the
31642 interface methods that must be implemented.
31644 * cs-parser.jay: Report error 501 (method requires body if it is
31645 not marked abstract or extern).
31647 * expression.cs (TypeOf::Emit): Implement.
31649 * typemanager.cs: runtime_handle_type, new global type.
31651 * class.cs (Property::Emit): Generate code for properties.
31653 2001-10-02 Ravi Pratap <ravi@ximian.com>
31655 * expression.cs (Unary::ResolveOperator): Find operators on base type
31656 too - we now conform exactly to the spec.
31658 (Binary::ResolveOperator): Same here.
31660 * class.cs (Operator::Define): Fix minor quirk in the tests.
31662 * ../errors/cs0215.cs : Added.
31664 * ../errors/cs0556.cs : Added.
31666 * ../errors/cs0555.cs : Added.
31668 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31670 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31671 single integer which is really efficient
31673 2001-10-01 Ravi Pratap <ravi@ximian.com>
31675 * expression.cs (Expression::ImplicitUserConversion): Use location
31676 even in the case when we are examining True operators.
31678 * class.cs (Operator::Define): Perform extensive checks to conform
31679 with the rules for operator overloading in the spec.
31681 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31682 some of the other conversions mentioned in the spec.
31684 * typemanager.cs (array_type): New static member for the System.Array built-in
31687 (cloneable_interface): For System.ICloneable interface.
31689 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31690 we start resolving the tree and populating types.
31692 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31694 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31696 * expression.cs (Expression::ExprClassFromMemberInfo,
31697 Expression::Literalize): Create literal expressions from
31698 FieldInfos which are literals.
31700 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31701 type casts, because they were wrong. The test suite in tests
31704 (ImplicitNumericConversion): ushort to ulong requires a widening
31707 Int32 constant to long requires widening cast as well.
31709 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31710 for integers because the type on the stack is not i4.
31712 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31714 * expression.cs (report118): require location argument.
31716 * parameter.cs: Do not dereference potential null value.
31718 * class.cs: Catch methods that lack the `new' keyword when
31719 overriding a name. Report warnings when `new' is used without
31720 anything being there to override.
31722 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31724 * class.cs: Only add constructor to hashtable if it is non-null
31725 (as now constructors can fail on define).
31727 (TypeManager, Class, Struct): Take location arguments.
31729 Catch field instance initialization in structs as errors.
31731 accepting_filter: a new filter for FindMembers that is static so
31732 that we dont create an instance per invocation.
31734 (Constructor::Define): Catch errors where a struct constructor is
31737 * cs-parser.jay: Pass location information for various new
31740 * delegate.cs (Delegate): take a location argument.
31742 * driver.cs: Do not call EmitCode if there were problesm in the
31743 Definition of the types, as many Builders wont be there.
31745 * decl.cs (Decl::Decl): Require a location argument.
31747 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31748 into integers, and find the most appropiate integer for it.
31750 * literal.cs: Implement ULongLiteral.
31752 * rootcontext.cs: Provide better information about the location of
31753 failure when CreateType fails.
31755 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31757 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31760 * expression.cs (Binary::CheckShiftArguments): Add missing type
31762 (Binary::ResolveOperator): Add type to the logical and and logical
31763 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31766 (Binary::DoNumericPromotions): In the case where either argument
31767 is ulong (and most signed types combined with ulong cause an
31768 error) perform implicit integer constant conversions as well.
31770 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31772 * expression.cs (UserImplicitCast): Method should always be
31774 (Invocation::BetterConversion): Simplified test for IntLiteral.
31776 (Expression::ImplicitNumericConversion): Split this routine out.
31777 Put the code that performs implicit constant integer conversions
31780 (Expression::Resolve): Become a wrapper around DoResolve so we can
31781 check eclass and type being set after resolve.
31783 (Invocation::Badness): Remove this dead function
31785 (Binary::ResolveOperator): Do not compute the expensive argumnets
31786 unless we have a union for it.
31788 (Probe::Emit): Is needs to do an isinst and then
31789 compare against null.
31791 (::CanConvert): Added Location argument. If the Location argument
31792 is null (Location.Null), then we do not report errors. This is
31793 used by the `probe' mechanism of the Explicit conversion. We do
31794 not want to generate an error for something that the user
31795 explicitly requested to be casted. But the pipeline for an
31796 explicit cast first tests for potential implicit casts.
31798 So for now, if the Location is null, it means `Probe only' to
31799 avoid adding another argument. Might have to revise this
31802 (ClassCast): New class used to type cast objects into arbitrary
31803 classes (used in Explicit Reference Conversions).
31805 Implement `as' as well.
31807 Reverted all the patches from Ravi below: they were broken:
31809 * The use of `level' as a mechanism to stop recursive
31810 invocations is wrong. That was there just to catch the
31811 bug with a strack trace but not as a way of addressing
31814 To fix the problem we have to *understand* what is going
31815 on and the interactions and come up with a plan, not
31816 just get things going.
31818 * The use of the type conversion cache that I proposed
31819 last night had an open topic: How does this work across
31820 protection domains. A user defined conversion might not
31821 be public in the location where we are applying the
31822 conversion, a different conversion might be selected
31823 (ie, private A->B (better) but public B->A (worse),
31824 inside A, A->B applies, but outside it, B->A will
31827 * On top of that (ie, even if the above is solved),
31828 conversions in a cache need to be abstract. Ie, `To
31829 convert from an Int to a Short use an OpcodeCast', not
31830 `To convert from an Int to a Short use the OpcodeCast on
31831 the variable 5' (which is what this patch was doing).
31833 2001-09-28 Ravi Pratap <ravi@ximian.com>
31835 * expression.cs (Invocation::ConversionExists): Re-write to use
31836 the conversion cache
31838 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31839 cache all conversions done, not just user-defined ones.
31841 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31842 to determine if a conversion exists instead of acutually trying to
31843 perform the conversion. It's faster too.
31845 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31846 and only then attempt the implicit conversion.
31848 2001-09-28 Ravi Pratap <ravi@ximian.com>
31850 * expression.cs (ConvertImplicit): Use a cache for conversions
31851 already found. Check level of recursion and bail out if necessary.
31853 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31855 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31856 Export standard methods that we expect for string operations.
31858 * statement.cs (Block::UsageWarning): Track usage of variables and
31859 report the errors for not used variables.
31861 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31864 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31866 * codegen.cs: remove unnneded code
31868 * expression.cs: Removed BuiltinTypeAccess class
31870 Fix the order in which implicit conversions are
31873 The previous fixed dropped support for boxed conversions (adding a
31874 test to the test suite now)
31876 (UserImplicitCast::CanConvert): Remove test for source being null,
31877 that code is broken. We should not feed a null to begin with, if
31878 we do, then we should track the bug where the problem originates
31879 and not try to cover it up here.
31881 Return a resolved expression of type UserImplicitCast on success
31882 rather than true/false. Ravi: this is what I was talking about,
31883 the pattern is to use a static method as a "constructor" for
31886 Also, do not create arguments until the very last minute,
31887 otherwise we always create the arguments even for lookups that
31888 will never be performed.
31890 (UserImplicitCast::Resolve): Eliminate, objects of type
31891 UserImplicitCast are born in a fully resolved state.
31893 * typemanager.cs (InitCoreTypes): Init also value_type
31894 (System.ValueType).
31896 * expression.cs (Cast::Resolve): First resolve the child expression.
31898 (LValue): Add new method AddressOf to be used by
31901 Change the argument of Store to take an EmitContext instead of an
31902 ILGenerator, because things like FieldExpr need to be able to call
31903 their children expression to generate the instance code.
31905 (Expression::Error, Expression::Warning): Sugar functions for
31908 (Expression::MemberLookup): Accept a TypeContainer instead of a
31909 Report as the first argument.
31911 (Expression::ResolvePrimary): Killed. I still want to improve
31912 this as currently the code is just not right.
31914 (Expression::ResolveMemberAccess): Simplify, but it is still
31917 (Unary::Resolve): Catch errors in AddressOf operators.
31919 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31920 index to a byte for the short-version, or the compiler will choose
31921 the wrong Emit call, which generates the wrong data.
31923 (ParameterReference::Emit, ::Store): same.
31925 (FieldExpr::AddressOf): Implement.
31927 * typemanager.cs: TypeManager: made public variable instead of
31930 * driver.cs: document --fatal.
31932 * report.cs (ErrorMessage, WarningMessage): new names for the old
31933 Error and Warning classes.
31935 * cs-parser.jay (member_access): Turn built-in access to types
31936 into a normal simplename
31938 2001-09-27 Ravi Pratap <ravi@ximian.com>
31940 * expression.cs (Invocation::BetterConversion): Fix to cope
31941 with q being null, since this was introducing a bug.
31943 * expression.cs (ConvertImplicit): Do built-in conversions first.
31945 2001-09-27 Ravi Pratap <ravi@ximian.com>
31947 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31949 2001-09-27 Ravi Pratap <ravi@ximian.com>
31951 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31952 I had introduced long ago (what's new ?).
31954 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31955 the work of all the checking.
31956 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31957 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31959 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31960 that is the right way.
31962 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31963 overloading resolution. Use everywhere instead of cutting and pasting code.
31965 (Binary::ResolveOperator): Use MakeUnionSet.
31967 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31968 we have to convert to bool types. Not complete yet.
31970 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31972 * typemanager.cs (TypeManager::CSharpName): support ushort.
31974 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31975 to provide an expression that performsn an implicit constant int
31976 conversion (section 6.1.6).
31977 (Expression::ConvertImplicitRequired): Reworked to include
31978 implicit constant expression conversions.
31980 (Expression::ConvertNumericExplicit): Finished.
31982 (Invocation::Emit): If InstanceExpression is null, then it means
31983 that we perform a call on this.
31985 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31987 * expression.cs (Unary::Emit): Remove some dead code.
31988 (Probe): Implement Resolve and Emit for `is'.
31989 (Expression::ConvertImplicitRequired): Attempt to do constant
31990 expression conversions here. Maybe should be moved to
31991 ConvertImplicit, but I am not sure.
31992 (Expression::ImplicitLongConstantConversionPossible,
31993 Expression::ImplicitIntConstantConversionPossible): New functions
31994 that tell whether is it possible to apply an implicit constant
31995 expression conversion.
31997 (ConvertNumericExplicit): Started work on explicit numeric
32000 * cs-parser.jay: Update operator constants.
32002 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32003 (Parameters::GetSignature): Hook up VerifyArgs here.
32004 (Parameters::VerifyArgs): Verifies that no two arguments have the
32007 * class.cs (Operator): Update the operator names to reflect the
32008 ones that the spec expects (as we are just stringizing the
32011 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32012 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32013 previous usage did only work for our methods.
32014 (Expression::ConvertImplicit): Handle decimal implicit numeric
32015 conversions as well.
32016 (Expression::InternalTypeConstructor): Used to invoke constructors
32017 on internal types for default promotions.
32019 (Unary::Emit): Implement special handling for the pre/post
32020 increment/decrement for overloaded operators, as they need to have
32021 the same semantics as the other operators.
32023 (Binary::ResolveOperator): ditto.
32024 (Invocation::ConversionExists): ditto.
32025 (UserImplicitCast::Resolve): ditto.
32027 2001-09-26 Ravi Pratap <ravi@ximian.com>
32029 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32030 operator, return after emitting body. Regression tests pass again !
32032 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32033 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32034 (Invocation::OverloadResolve): Ditto.
32035 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32037 * everywhere : update calls to the above methods accordingly.
32039 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32041 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32043 * expression.cs (ExpressionStatement): New base class used for
32044 expressions that can appear in statements, so that we can provide
32045 an alternate path to generate expression that do not leave a value
32048 (Expression::Emit, and all the derivatives): We no longer return
32049 whether a value is left on the stack or not. Every expression
32050 after being emitted leaves a single value on the stack.
32052 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32053 facilties of ExpressionStatement if possible.
32055 * cs-parser.jay: Update statement_expression.
32057 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32059 * driver.cs: Change the wording of message
32061 2001-09-25 Ravi Pratap <ravi@ximian.com>
32063 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32064 the type of the expression to the return type of the method if
32065 we have an overloaded operator match ! The regression tests pass again !
32066 (Unary::ResolveOperator): Ditto.
32068 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32069 to find "op_Implicit", not "implicit" ;-)
32070 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32071 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32073 * everywhere : Correct calls to the above accordingly.
32075 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32076 (ConvertImplicit): Do user-defined conversion if it exists.
32078 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32080 * assign.cs: track location.
32081 (Resolve): Use implicit conversions on assignment.
32083 * literal.cs: Oops. Not good, Emit of short access values should
32084 pass (Bytes) or the wrong argument will be selected.
32086 * expression.cs (Unary::Emit): Emit code for -expr.
32088 (Unary::ResolveOperator): Handle `Substract' for non-constants
32089 (substract from zero from the non-constants).
32090 Deal with Doubles as well.
32092 (Expression::ConvertImplicitRequired): New routine that reports an
32093 error if no implicit conversion exists.
32095 (Invocation::OverloadResolve): Store the converted implicit
32096 expressions if we make them
32098 2001-09-24 Ravi Pratap <ravi@ximian.com>
32100 * class.cs (ConstructorInitializer): Take a Location argument.
32101 (ConstructorBaseInitializer): Same here.
32102 (ConstructorThisInitializer): Same here.
32104 * cs-parser.jay : Update all calls accordingly.
32106 * expression.cs (Unary, Binary, New): Take location argument.
32107 Update accordingly everywhere.
32109 * cs-parser.jay : Update all calls to the above to take a location
32112 * class.cs : Ditto.
32114 2001-09-24 Ravi Pratap <ravi@ximian.com>
32116 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32117 (Invocation::BetterConversion): Same here
32118 (Invocation::ConversionExists): Ditto.
32120 (Invocation::ConversionExists): Implement.
32122 2001-09-22 Ravi Pratap <ravi@ximian.com>
32124 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32125 Also take an additional TypeContainer argument.
32127 * All over : Pass in TypeContainer as argument to OverloadResolve.
32129 * typemanager.cs (CSharpName): Update to check for the string type and return
32132 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32135 2001-09-21 Ravi Pratap <ravi@ximian.com>
32137 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32138 (Invocation::BetterFunction): Implement.
32139 (Invocation::BetterConversion): Implement.
32140 (Invocation::ConversionExists): Skeleton, no implementation yet.
32142 Okay, things work fine !
32144 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32146 * typemanager.cs: declare and load enum_type, delegate_type and
32149 * expression.cs (Expression::Emit): Now emit returns a value that
32150 tells whether a value is left on the stack or not. This strategy
32151 might be reveted tomorrow with a mechanism that would address
32152 multiple assignments.
32153 (Expression::report118): Utility routine to report mismatches on
32156 (Unary::Report23): Report impossible type/operator combination
32159 (Unary::IsIncrementableNumber): Whether the type can be
32160 incremented or decremented with add.
32161 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32163 (Unary::ResolveOperator): Implement ++, !, ~,
32165 (Invocation::Emit): Deal with new Emit convetion.
32167 * All Expression derivatives: Updated their Emit method to return
32168 whether they leave values on the stack or not.
32170 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32171 stack for expressions that are statements.
32173 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32175 * expression.cs (LValue): New interface. Must be implemented by
32177 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32180 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32181 interface for generating code, simplifies the code.
32183 2001-09-20 Ravi Pratap <ravi@ximian.com>
32185 * expression.cs (everywhere): Comment out return statements in ::Resolve
32186 methods to avoid the warnings.
32188 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32190 * driver.cs (parse): Report error 2001 if we can not open the
32193 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32196 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32199 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32200 otherwise nested blocks end up with the same index.
32202 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32204 * expression.cs: Instead of having FIXMEs in the Resolve
32205 functions, throw exceptions so it is obvious that we are facing a
32208 * cs-parser.jay (invocation_expression): Pass Location information.
32210 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32211 Use a basename for those routines because .NET does not like paths
32214 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32217 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32219 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32220 are loading the correct data types (throws an exception if not).
32221 (TypeManager::InitCoreTypes): Use CoreLookupType
32223 * expression.cs (Unary::ResolveOperator): return the child
32224 expression for expressions which are just +expr.
32225 (Unary::ResolveOperator): Return negative literals for -LITERAL
32226 expressions (otherwise they are Unary {Literal}).
32227 (Invocation::Badness): Take into account `Implicit constant
32228 expression conversions'.
32230 * literal.cs (LongLiteral): Implement long literal class.
32231 (IntLiteral): export the `Value' of the intliteral.
32233 2001-09-19 Ravi Pratap <ravi@ximian.com>
32235 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32237 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32238 instead of 'Operator'
32240 * expression.cs (Binary::ResolveOperator): Update accordingly.
32241 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32244 * cs-parser.jay (unary_expression): Update to use the new names.
32246 * gen-treedump.cs (GetUnary): Same here.
32248 * expression.cs (Unary::Resolve): Implement.
32249 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32250 operators are found instead of making noise ;-)
32251 (Unary::ResolveOperator): New method to do precisely the same thing which
32252 Binary::ResolveOperator does for Binary expressions.
32253 (Unary.method, .Arguments): Add.
32254 (Unary::OperName): Implement.
32255 (Unary::ForceConversion): Copy and Paste !
32257 * class.cs (Operator::Define): Fix a small bug for the case when we have
32260 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32261 for the inbuilt operators. Only overloading works for now ;-)
32263 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32265 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32266 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32268 * expression.cs (This::Emit): Implement.
32269 (This::Resolve): Implement.
32270 (TypeOf:Resolve): Implement.
32271 (Expression::ResolveSimpleName): Add an implicit this to instance
32273 (MemberAccess::Resolve): Deal with Parameters and Fields.
32274 Bind instance variable to Field expressions.
32275 (FieldExpr::Instance): New field used to track the expression that
32276 represents the object instance.
32277 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32279 (FieldExpr::Emit): Implement.
32281 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32282 the last instruction contains a return opcode to avoid generating
32283 the last `ret' instruction (this generates correct code, and it is
32284 nice to pass the peverify output).
32286 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32287 initializer for static and instance variables.
32288 (Constructor::Emit): Allow initializer to be null in the case of
32289 static constructors. Only emit initializer for instance
32292 (TypeContainer::FindMembers): Return a null array if there are no
32295 Also fix the code for the MemberTypes.Method branch, as it was not
32296 scanning that for operators (or tried to access null variables before).
32298 * assign.cs (Assign::Emit): Handle instance and static fields.
32302 * driver.cs: Stop compilation if there are parse errors.
32304 * cs-parser.jay (constructor_declaration): Provide default base
32305 initializer for non-static constructors.
32306 (constructor_declarator): Do not provide a default base
32307 initializers if none was specified.
32308 Catch the fact that constructors should not have parameters.
32310 * class.cs: Do not emit parent class initializers for static
32311 constructors, that should be flagged as an error.
32313 2001-09-18 Ravi Pratap <ravi@ximian.com>
32315 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32316 Move back code into TypeContainer::Populate.
32318 2001-09-18 Ravi Pratap <ravi@ximian.com>
32320 * class.cs (TypeContainer::AddConstructor): Fix the check to
32321 compare against Name, not Basename.
32322 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32324 * cs-parser.jay : Update accordingly.
32326 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32327 for methods, don't forget to look into the operators too.
32328 (RegisterMethodBuilder): Helper method to take care of this for
32329 methods, constructors and operators.
32330 (Operator::Define): Completely revamp.
32331 (Operator.OperatorMethod, MethodName): New fields.
32332 (TypeContainer::Populate): Move the registering of builders into
32333 RegisterMethodBuilder.
32334 (Operator::Emit): Re-write.
32336 * expression.cs (Binary::Emit): Comment out code path to emit method
32337 invocation stuff for the case when we have a user defined operator. I am
32338 just not able to get it right !
32340 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32342 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32345 (Expression::MemberLookup): Provide a version that allows to
32346 specify the MemberTypes and BindingFlags.
32348 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32349 so it was not fetching variable information from outer blocks.
32351 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32352 Beforefieldinit as it was buggy.
32354 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32355 that Ravi put here.
32357 * class.cs (Constructor::Emit): Only emit if block is not null.
32358 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32359 deal with this by semantically definining it as if the user had
32362 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32363 constructors as we now "emit" them at a higher level.
32365 (TypeContainer::DefineDefaultConstructor): Used to define the
32366 default constructors if none was provided.
32368 (ConstructorInitializer): Add methods Resolve and Emit.
32370 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32372 2001-09-17 Ravi Pratap <ravi@ximian.com>
32374 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32375 the default constructor builder with our hashtable for methodbuilders
32378 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32379 and argument_count is 0 in which case we have a match.
32380 (Binary::ResolveOperator): More null checking and miscellaneous coding
32383 2001-09-17 Ravi Pratap <ravi@ximian.com>
32385 * rootcontext.cs (IsNameSpace): Compare against null.
32387 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32389 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32390 and Unary::Operator.
32392 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32395 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32396 we have overloaded operators.
32397 (Binary::ResolveOperator): Implement the part which does the operator overload
32400 * class.cs (Operator::Emit): Implement.
32401 (TypeContainer::Emit): Emit the operators we have too.
32403 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32404 the case when we have a user-defined operator.
32406 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32408 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32410 2001-09-16 Ravi Pratap <ravi@ximian.com>
32412 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32413 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32414 (Constructor::Emit): Implement.
32415 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32416 if we have no work to do.
32417 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32420 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32421 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32423 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32426 2001-09-15 Ravi Pratap <ravi@ximian.com>
32428 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32430 (Tree::RecordNamespace): Method to do what the name says ;-)
32431 (Tree::Namespaces): Property to get at the namespaces hashtable.
32433 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32436 * rootcontext.cs (IsNamespace): Fixed it :-)
32438 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32440 * class.cs (TypeContainer::FindMembers): Add support for
32442 (MethodCore): New class that encapsulates both the shared aspects
32443 of a Constructor and a Method.
32444 (Method, Constructor): Factored pieces into MethodCore.
32446 * driver.cs: Added --fatal which makes errors throw exceptions.
32447 Load System assembly as well as part of the standard library.
32449 * report.cs: Allow throwing exceptions on errors for debugging.
32451 * modifiers.cs: Do not use `parent', instead use the real type
32452 container to evaluate permission settings.
32454 * class.cs: Put Ravi's patch back in. He is right, and we will
32455 have to cope with the
32457 2001-09-14 Ravi Pratap <ravi@ximian.com>
32459 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32460 FamORAssem, not FamANDAssem.
32462 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32464 * driver.cs: Added --parse option that only parses its input files
32467 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32468 incorrect. IsTopLevel is not used to tell whether an object is
32469 root_types or not (that can be achieved by testing this ==
32470 root_types). But to see if this is a top-level *class* (not
32471 necessarly our "toplevel" container).
32473 2001-09-14 Ravi Pratap <ravi@ximian.com>
32475 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32476 parent instead of a direct call to GetType.
32478 2001-09-14 Ravi Pratap <ravi@ximian.com>
32480 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32481 Modifiers.TypeAttr. This should just be a call to that method.
32483 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32484 object so that we can determine if we are top-level or not.
32486 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32489 * enum.cs (Enum::Define): Ditto.
32491 * modifiers.cs (FieldAttr): Re-write.
32493 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32494 (TypeContainer::HaveStaticConstructor): New property to provide access
32495 to precisely that info.
32497 * modifiers.cs (MethodAttr): Re-write.
32498 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32500 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32501 of top-level types as claimed.
32503 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32505 * expression.cs (MemberLookup): Fruitless attempt to lookup
32506 constructors. Maybe I need to emit default constructors? That
32507 might be it (currently .NET emits this for me automatically).
32508 (Invocation::OverloadResolve): Cope with Arguments == null.
32509 (Invocation::EmitArguments): new function, shared by the new
32510 constructor and us.
32511 (Invocation::Emit): Handle static and instance methods. Emit
32512 proper call instruction for virtual or non-virtual invocations.
32513 (New::Emit): Implement.
32514 (New::Resolve): Implement.
32515 (MemberAccess:Resolve): Implement.
32516 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32517 to track instances.
32518 (FieldExpr::Resolve): Set type.
32520 * support.cs: Handle empty arguments.
32522 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32523 SimpleLookup): Auxiliary routines to help parse a qualifier
32526 Update qualifier_identifier rule.
32528 * codegen.cs: Removed debugging messages.
32530 * class.cs: Make this a global thing, this acts just as a "key" to
32531 objects that we might have around.
32533 (Populate): Only initialize method_builders_to_methods once.
32535 * expression.cs (PropertyExpr): Initialize type from the
32538 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32539 Resolve pattern. Attempt to implicitly convert value to boolean.
32542 * expression.cs: Set the type for the int32/int32 argument case.
32543 (Binary::ResolveOperator): Set the return type to boolean for
32544 comparission operators
32546 * typemanager.cs: Remove debugging print code.
32548 (Invocation::Resolve): resolve type.
32550 * class.cs: Allocate a MemberInfo of the correct size, as the code
32551 elsewhere depends on the test to reflect the correct contents.
32553 (Method::) Keep track of parameters, due to System.Reflection holes
32555 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32558 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32559 of the exact size and return that.
32561 (Class::LookupMethodByBuilder): New function that maps
32562 MethodBuilders to its methods. Required to locate the information
32563 on methods because System.Reflection bit us again.
32565 * support.cs: New file, contains an interface ParameterData and
32566 two implementations: ReflectionParameters and InternalParameters
32567 used to access Parameter information. We will need to grow this
32570 * expression.cs (Invocation::GetParameterData): implement a cache
32571 and a wrapper around the ParameterData creation for methods.
32572 (Invocation::OverloadResolve): Use new code.
32574 2001-09-13 Ravi Pratap <ravi@ximian.com>
32576 * class.cs (TypeContainer::EmitField): Remove and move into
32577 (Field::Define): here and modify accordingly.
32578 (Field.FieldBuilder): New member.
32579 (TypeContainer::Populate): Update accordingly.
32580 (TypeContainer::FindMembers): Implement.
32582 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32584 * statement.cs: (VariableInfo::VariableType): New field to be
32585 initialized with the full type once it is resolved.
32587 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32589 * parameter.cs (GetParameterInfo): Use a type cache to compute
32590 things only once, and to reuse this information
32592 * expression.cs (LocalVariableReference::Emit): Implement.
32593 (OpcodeCast::Emit): fix.
32595 (ParameterReference::Resolve): Implement.
32596 (ParameterReference::Emit): Implement.
32598 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32599 that are expressions need to stay as Expressions.
32601 * typemanager.cs (CSharpName): Returns the C# name of a type if
32604 * expression.cs (Expression::ConvertImplicit): New function that
32605 implements implicit type conversions.
32607 (Expression::ImplicitReferenceConversion): Implements implicit
32608 reference conversions.
32610 (EmptyCast): New type for transparent casts.
32612 (OpcodeCast): New type for casts of types that are performed with
32613 a sequence of bytecodes.
32615 (BoxedCast): New type used for casting value types into reference
32616 types. Emits a box opcode.
32618 (Binary::DoNumericPromotions): Implements numeric promotions of
32619 and computation of the Binary::Type.
32621 (Binary::EmitBranchable): Optimization.
32623 (Binary::Emit): Implement code emission for expressions.
32625 * typemanager.cs (TypeManager): Added two new core types: sbyte
32628 2001-09-12 Ravi Pratap <ravi@ximian.com>
32630 * class.cs (TypeContainer::FindMembers): Method which does exactly
32631 what Type.FindMembers does, only we don't have to use reflection. No
32632 implementation yet.
32634 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32635 typecontainer objects as we need to get at them.
32636 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32638 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32639 typecontainer object.
32641 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32642 of just a Report object.
32644 2001-09-11 Ravi Pratap <ravi@ximian.com>
32646 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32648 (TypeContainer::Populate): Now define the delegates of the type too.
32649 (TypeContainer.Delegates): Property to access the list of delegates defined
32652 * delegates.cs (Delegate::Define): Implement partially.
32654 * modifiers.cs (TypeAttr): Handle more flags.
32656 2001-09-11 Ravi Pratap <ravi@ximian.com>
32658 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32660 (Operator::Define): Re-write logic to get types by using the LookupType method
32661 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32662 (Indexer::Define): Ditto.
32663 (Event::Define): Ditto.
32664 (Property::Define): Ditto.
32666 2001-09-10 Ravi Pratap <ravi@ximian.com>
32668 * class.cs (TypeContainer::Populate): Now define operators too.
32669 (TypeContainer.Operators): New property to access the list of operators
32671 (Operator.OperatorMethodBuilder): New member to hold the method builder
32672 for the operator we are defining.
32673 (Operator::Define): Implement.
32675 2001-09-10 Ravi Pratap <ravi@ximian.com>
32677 * class.cs (Event::Define): Make the prefixes of the accessor methods
32678 addOn_ and removeOn_
32680 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32681 of the location being passed in too. Ideally, this should go later since all
32682 error reporting should be done through the Report object.
32684 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32685 (Populate): Iterate thru the indexers we have and define them too.
32686 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32687 for the get and set accessors.
32688 (Indexer::Define): Implement.
32690 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32692 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32693 my previous implementation, did not work.
32695 * typemanager.cs: Add a couple of missing types (the longs).
32697 * literal.cs: Use TypeManager.bool_type instead of getting it.
32699 * expression.cs (EventExpr): New kind of expressions.
32700 (Expressio::ExprClassFromMemberInfo): finish
32702 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32704 * assign.cs: Emit stores to static fields differently.
32706 2001-09-08 Ravi Pratap <ravi@ximian.com>
32708 * Merge in changes and adjust code to tackle conflicts. Backed out my
32709 code in Assign::Resolve ;-)
32711 2001-09-08 Ravi Pratap <ravi@ximian.com>
32713 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32714 instead Report.Error and also pass in the location.
32715 (CSharpParser::Lexer): New readonly property to return the reference
32716 to the Tokenizer object.
32717 (declare_local_variables): Use Report.Error with location instead of plain
32721 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32722 (Operator.CheckBinaryOperator): Ditto.
32724 * cs-parser.jay (operator_declarator): Update accordingly.
32726 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32727 (CheckBinaryOperator): Same here.
32729 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32730 on the name without any prefixes of namespace names etc. This is because we
32731 already might have something already fully qualified like
32732 'System.Console.WriteLine'
32734 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32736 2001-09-07 Ravi Pratap <ravi@ximian.com>
32738 * cs-tokenizer.cs (location): Return a string which also contains
32741 * expression.cs (ElementAccess): New class for expressions of the
32742 type 'element access.'
32743 (BaseAccess): New class for expressions of the type 'base access.'
32744 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32747 * cs-parser.jay (element_access): Implement action.
32748 (base_access): Implement actions.
32749 (checked_expression, unchecked_expression): Implement.
32751 * cs-parser.jay (local_variable_type): Correct and implement.
32752 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32754 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32756 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32757 name and the specifiers.
32759 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32761 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32762 making them all public ;-)
32764 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32767 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32769 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32771 (FieldExpr, PropertyExprs): New resolved expressions.
32772 (SimpleName::MemberStaticCheck): Perform static checks for access
32773 to non-static fields on static methods. Maybe this should be
32774 generalized for MemberAccesses.
32775 (SimpleName::ResolveSimpleName): More work on simple name
32778 * cs-parser.jay (primary_expression/qualified_identifier): track
32779 the parameter index.
32781 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32782 (EmitContext::EmitBoolExpression): Chain to expression generation
32783 instead of temporary hack.
32784 (::EmitStatementExpression): Put generic expression code generation.
32786 * assign.cs (Assign::Emit): Implement variable assignments to
32787 local variables, parameters and fields.
32789 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32791 * statement.cs (Block::GetVariableInfo): New method, returns the
32792 VariableInfo for a variable name in a block.
32793 (Block::GetVariableType): Implement in terms of GetVariableInfo
32795 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32796 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32798 2001-09-06 Ravi Pratap <ravi@ximian.com>
32800 * cs-parser.jay (operator_declaration): Continue on my quest : update
32801 to take attributes argument.
32802 (event_declaration): Ditto.
32803 (enum_declaration): Ditto.
32804 (indexer_declaration): Ditto.
32806 * class.cs (Operator::Operator): Update constructor accordingly.
32807 (Event::Event): Ditto.
32809 * delegate.cs (Delegate::Delegate): Same here.
32811 * enum.cs (Enum::Enum): Same here.
32813 2001-09-05 Ravi Pratap <ravi@ximian.com>
32815 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32817 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32819 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32820 being passed around as an arraylist.
32821 (Attributes::AddAttribute): Method to add attribute sections.
32823 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32824 (struct_declaration): Update accordingly.
32825 (constant_declaration): Update.
32826 (field_declaration): Update.
32827 (method_header): Update.
32828 (fixed_parameter): Update.
32829 (parameter_array): Ditto.
32830 (property_declaration): Ditto.
32831 (destructor_declaration): Ditto.
32833 * class.cs (Struct::Struct): Update constructors accordingly.
32834 (Class::Class): Ditto.
32835 (Field::Field): Ditto.
32836 (Method::Method): Ditto.
32837 (Property::Property): Ditto.
32838 (TypeContainer::OptAttribute): update property's return type.
32840 * interface.cs (Interface.opt_attributes): New member.
32841 (Interface::Interface): Update to take the extra Attributes argument.
32843 * parameter.cs (Parameter::Parameter): Ditto.
32845 * constant.cs (Constant::Constant): Ditto.
32847 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32848 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32849 the attributes as a parameter.
32850 (InterfaceProperty): Update constructor call.
32851 (InterfaceEvent): Ditto.
32852 (InterfaceMethod): Ditto.
32853 (InterfaceIndexer): Ditto.
32855 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32856 pass the attributes too.
32857 (interface_event_declaration): Ditto.
32858 (interface_property_declaration): Ditto.
32859 (interface_method_declaration): Ditto.
32860 (interface_declaration): Ditto.
32862 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32864 * class.cs (Method::Define): Track the "static Main" definition to
32865 create an entry point.
32867 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32868 EntryPoint if we find it.
32870 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32871 (EmitContext::ig): Make this variable public.
32873 * driver.cs: Make the default output file be the first file name
32874 with the .exe extension.
32876 Detect empty compilations
32878 Handle various kinds of output targets. Handle --target and
32879 rename -t to --dumper.
32881 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32882 methods inherited from Expression return now an Expression. This
32883 will is used during the tree rewriting as we resolve them during
32886 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32887 the spec. Missing entirely is the information about
32888 accessability of elements of it.
32890 (Expression::ExprClassFromMemberInfo): New constructor for
32891 Expressions that creates a fully initialized Expression based on
32892 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32895 (Invocation::Resolve): Begin implementing resolution of invocations.
32897 * literal.cs (StringLiteral): Implement Emit.
32899 2001-09-05 Ravi Pratap <ravi@ximian.com>
32901 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32904 2001-09-04 Ravi Pratap <ravi@ximian.com>
32906 * cs-parser.jay (attribute_arguments): Implement actions.
32907 (attribute): Fix bug in production. Implement action.
32908 (attribute_list): Implement.
32909 (attribute_target): Implement.
32910 (attribute_target_specifier, opt_target_specifier): Implement
32911 (CheckAttributeTarget): New method to check if the attribute target
32913 (attribute_section): Implement.
32914 (opt_attributes): Implement.
32916 * attribute.cs : New file to handle attributes.
32917 (Attribute): Class to hold attribute info.
32919 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32920 (attribute_section): Modify production to use 2 different rules to
32921 achieve the same thing. 1 s/r conflict down !
32922 Clean out commented, useless, non-reducing dimension_separator rules.
32924 * class.cs (TypeContainer.attributes): New member to hold list
32925 of attributes for a type.
32926 (Struct::Struct): Modify to take one more argument, the attribute list.
32927 (Class::Class): Ditto.
32928 (Field::Field): Ditto.
32929 (Method::Method): Ditto.
32930 (Property::Property): Ditto.
32932 * cs-parser.jay (struct_declaration): Update constructor call to
32933 pass in the attributes too.
32934 (class_declaration): Ditto.
32935 (constant_declaration): Ditto.
32936 (field_declaration): Ditto.
32937 (method_header): Ditto.
32938 (fixed_parameter): Ditto.
32939 (parameter_array): Ditto.
32940 (property_declaration): Ditto.
32942 * constant.cs (Constant::Constant): Update constructor similarly.
32943 Use System.Collections.
32945 * parameter.cs (Parameter::Parameter): Update as above.
32947 2001-09-02 Ravi Pratap <ravi@ximian.com>
32949 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32950 (TypeContainer.delegates): New member to hold list of delegates.
32952 * cs-parser.jay (delegate_declaration): Implement the action correctly
32953 this time as I seem to be on crack ;-)
32955 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32957 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32958 tell whether an identifier represents a namespace.
32960 * expression.cs (NamespaceExpr): A namespace expression, used only
32961 temporarly during expression resolution.
32962 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32963 utility functions to resolve names on expressions.
32965 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32967 * codegen.cs: Add hook for StatementExpressions.
32969 * class.cs: Fix inverted test for static flag in methods.
32971 2001-09-02 Ravi Pratap <ravi@ximian.com>
32973 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32974 to make it coincide with MS' number.
32975 (Operator::CheckBinaryOperator): Ditto.
32977 * ../errors/errors.txt : Remove error numbers added earlier.
32979 * ../errors/cs1019.cs : Test case for error # 1019
32981 * ../errros/cs1020.cs : Test case for error # 1020
32983 * cs-parser.jay : Clean out commented cruft.
32984 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32985 used anywhere - non-reducing rule.
32986 (namespace_declarations): Non-reducing rule - comment out.
32988 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32989 with TypeContainer::AddEnum.
32991 * delegate.cs : New file for delegate handling classes.
32992 (Delegate): Class for declaring delegates.
32994 * makefile : Update.
32996 * cs-parser.jay (delegate_declaration): Implement.
32998 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33000 * class.cs (Event::Define): Implement.
33001 (Event.EventBuilder): New member.
33003 * class.cs (TypeContainer::Populate): Update to define all enums and events
33005 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33006 readonly fields for all these cases ?
33008 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33010 * class.cs (Property): Revamp to use the convention of making fields readonly.
33011 Accordingly modify code elsewhere.
33013 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33014 the Define method of the Property class.
33016 * class.cs : Clean up applied patch and update references to variables etc. Fix
33018 (TypeContainer::Populate): Update to define all the properties we have. Also
33019 define all enumerations.
33021 * enum.cs (Define): Implement.
33023 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33025 * cs-parser.jay (overloadable_operator): The semantic value is an
33026 enum of the Operator class.
33027 (operator_declarator): Implement actions.
33028 (operator_declaration): Implement.
33030 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33031 validity of definitions.
33032 (Operator::CheckBinaryOperator): Static method to check for binary operators
33033 (TypeContainer::AddOperator): New method to add an operator to a type.
33035 * cs-parser.jay (indexer_declaration): Added line to actually call the
33036 AddIndexer method so it gets added ;-)
33038 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33039 already taken care of by the MS compiler ?
33041 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33043 * class.cs (Operator): New class for operator declarations.
33044 (Operator::OpType): Enum for the various operators.
33046 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33048 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33049 ostensibly handle this in semantic analysis.
33051 * cs-parser.jay (general_catch_clause): Comment out
33052 (specific_catch_clauses, specific_catch_clause): Ditto.
33053 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33054 (catch_args, opt_catch_args): New productions.
33055 (catch_clause): Rewrite to use the new productions above
33056 (catch_clauses): Modify accordingly.
33057 (opt_catch_clauses): New production to use in try_statement
33058 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33059 and re-write the code in the actions to extract the specific and
33060 general catch clauses by being a little smart ;-)
33062 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33063 Hooray, try and catch statements parse fine !
33065 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33067 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33068 string from the hashtable of variables.
33070 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33071 I end up making that mistake ;-)
33072 (catch_clauses): Fixed gross error which made Key and Value of the
33073 DictionaryEntry the same : $1 !!
33075 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33077 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33079 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33080 when the add and remove accessors are specified.
33082 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33084 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33085 information about indexer_declarator.
33086 (indexer_declarator): Implement actions.
33087 (parsing_indexer): New local boolean used to keep track of whether
33088 we are parsing indexers or properties. This is necessary because
33089 implicit_parameters come into picture even for the get accessor in the
33090 case of an indexer.
33091 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33093 * class.cs (Indexer): New class for indexer declarations.
33094 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33095 (TypeContainer::indexers): New member to hold list of indexers for the
33098 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33100 * cs-parser.jay (add_accessor_declaration): Implement action.
33101 (remove_accessor_declaration): Implement action.
33102 (event_accessors_declaration): Implement
33103 (variable_declarators): swap statements for first rule - trivial.
33105 * class.cs (Event): New class to hold information about event
33107 (TypeContainer::AddEvent): New method to add an event to a type
33108 (TypeContainer::events): New member to hold list of events.
33110 * cs-parser.jay (event_declaration): Implement actions.
33112 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33114 * cs-parser.jay (dim_separators): Implement. Make it a string
33115 concatenating all the commas together, just as they appear.
33116 (opt_dim_separators): Modify accordingly
33117 (rank_specifiers): Update accordingly. Basically do the same
33118 thing - instead, collect the brackets here.
33119 (opt_rank_sepcifiers): Modify accordingly.
33120 (array_type): Modify to actually return the complete type string
33121 instead of ignoring the rank_specifiers.
33122 (expression_list): Implement to collect the expressions
33123 (variable_initializer): Implement. We make it a list of expressions
33124 essentially so that we can handle the array_initializer case neatly too.
33125 (variable_initializer_list): Implement.
33126 (array_initializer): Make it a list of variable_initializers
33127 (opt_array_initializer): Modify accordingly.
33129 * expression.cs (New::NType): Add enumeration to help us
33130 keep track of whether we have an object/delegate creation
33131 or an array creation.
33132 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33133 members to hold data about array creation.
33134 (New:New): Modify to update NewType
33135 (New:New): New Overloaded contructor for the array creation
33138 * cs-parser.jay (array_creation_expression): Implement to call
33139 the overloaded New constructor.
33141 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33143 * class.cs (TypeContainer::Constructors): Return member
33144 constructors instead of returning null.
33146 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33148 * typemanager.cs (InitCoreTypes): Initialize the various core
33149 types after we have populated the type manager with the user
33150 defined types (this distinction will be important later while
33151 compiling corlib.dll)
33153 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33154 on Expression Classification. Now all expressions have a method
33155 `Resolve' and a method `Emit'.
33157 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33158 generation from working. Also add some temporary debugging
33161 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33163 * codegen.cs: Lots of code generation pieces. This is only the
33164 beginning, will continue tomorrow with more touches of polish. We
33165 handle the fundamentals of if, while, do, for, return. Others are
33166 trickier and I need to start working on invocations soon.
33168 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33171 * codegen.cs (EmitContext): New struct, used during code
33172 emission to keep a context. Most of the code generation will be
33175 * cs-parser.jay: Add embedded blocks to the list of statements of
33176 this block. So code generation proceeds in a top down fashion.
33178 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33180 * statement.cs: Add support for multiple child blocks.
33182 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33184 * codegen.cs (EmitCode): New function, will emit the code for a
33185 Block of code given a TypeContainer and its ILGenerator.
33187 * statement.cs (Block): Standard public readonly optimization.
33188 (Block::Block constructors): Link children.
33189 (Block::Child): Child Linker.
33190 (Block::EmitVariables): Emits IL variable declarations.
33192 * class.cs: Drop support for MethodGroups here, delay until
33194 (Method::): Applied the same simplification that I did before, and
33195 move from Properties to public readonly fields.
33196 (Method::ParameterTypes): Returns the parameter types for the
33197 function, and implements a cache that will be useful later when I
33198 do error checking and the semantic analysis on the methods is
33200 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33201 and made a method, optional argument tells whether this is a class
33202 or a structure to apply the `has-this' bit.
33203 (Method::GetCallingConvention): Implement, returns the calling
33205 (Method::Define): Defines the type, a second pass is performed
33206 later to populate the methods.
33208 (Constructor::ParameterTypes): implement a cache similar to the
33209 one on Method::ParameterTypes, useful later when we do semantic
33212 (TypeContainer::EmitMethod): New method. Emits methods.
33214 * expression.cs: Removed MethodGroup class from here.
33216 * parameter.cs (Parameters::GetCallingConvention): new method.
33218 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33220 * class.cs (TypeContainer::Populate): Drop RootContext from the
33223 (Constructor::CallingConvention): Returns the calling convention.
33224 (Constructor::ParameterTypes): Returns the constructor parameter
33227 (TypeContainer::AddConstructor): Keep track of default constructor
33228 and the default static constructor.
33230 (Constructor::) Another class that starts using `public readonly'
33231 instead of properties.
33233 (Constructor::IsDefault): Whether this is a default constructor.
33235 (Field::) use readonly public fields instead of properties also.
33237 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33238 track of static constructors; If none is used, turn on
33239 BeforeFieldInit in the TypeAttributes.
33241 * cs-parser.jay (opt_argument_list): now the return can be null
33242 for the cases where there are no arguments.
33244 (constructor_declarator): If there is no implicit `base' or
33245 `this', then invoke the default parent constructor.
33247 * modifiers.cs (MethodAttr): New static function maps a set of
33248 modifiers flags into a MethodAttributes enum
33249 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33250 MethodAttr, TypeAttr to represent the various mappings where the
33251 modifiers are used.
33252 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33254 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33256 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33259 * interface.cs (PopulateIndexer): Implemented the code generator
33260 for interface indexers.
33262 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33264 * interface.cs (InterfaceMemberBase): Now we track the new status
33267 (PopulateProperty): Implement property population. Woohoo! Got
33268 Methods and Properties going today.
33270 Removed all the properties for interfaces, and replaced them with
33271 `public readonly' fields.
33273 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33275 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33276 initialize their hashtables/arraylists only when they are needed
33277 instead of doing this always.
33279 * parameter.cs: Handle refs and out parameters.
33281 * cs-parser.jay: Use an ArrayList to construct the arguments
33282 instead of the ParameterCollection, and then cast that to a
33285 * parameter.cs: Drop the use of ParameterCollection and use
33286 instead arrays of Parameters.
33288 (GetParameterInfo): Use the Type, not the Name when resolving
33291 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33293 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33294 and instead use public readonly fields.
33296 * class.cs: Put back walking code for type containers.
33298 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33300 * class.cs (MakeConstant): Code to define constants.
33302 * rootcontext.cs (LookupType): New function. Used to locate types
33305 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33307 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33308 this System.Reflection code is. Kudos to Microsoft
33310 * typemanager.cs: Implement a type cache and avoid loading all
33311 types at boot time. Wrap in LookupType the internals. This made
33312 the compiler so much faster. Wow. I rule!
33314 * driver.cs: Make sure we always load mscorlib first (for
33315 debugging purposes, nothing really important).
33317 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33318 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33320 * rootcontext.cs: Lookup types on their namespace; Lookup types
33321 on namespaces that have been imported using the `using' keyword.
33323 * class.cs (TypeContainer::TypeAttr): Virtualize.
33324 (Class::TypeAttr): Return attributes suitable for this bad boy.
33325 (Struct::TypeAttr): ditto.
33326 Handle nested classes.
33327 (TypeContainer::) Remove all the type visiting code, it is now
33328 replaced with the rootcontext.cs code
33330 * rootcontext.cs (GetClassBases): Added support for structs.
33332 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33334 * interface.cs, statement.cs, class.cs, parameter.cs,
33335 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33336 Drop use of TypeRefs, and use strings instead.
33338 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33342 * class.cs (Struct::Struct): set the SEALED flags after
33343 checking the modifiers.
33344 (TypeContainer::TypeAttr): new property, returns the
33345 TypeAttributes for a class.
33347 * cs-parser.jay (type_list): Oops, list production was creating a
33348 new list of base types.
33350 * rootcontext.cs (StdLib): New property.
33351 (GetInterfaceTypeByName): returns an interface by type name, and
33352 encapsulates error handling here.
33353 (GetInterfaces): simplified.
33354 (ResolveTree): Encapsulated all the tree resolution here.
33355 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33358 * driver.cs: Add support for --nostdlib, to avoid loading the
33359 default assemblies.
33360 (Main): Do not put tree resolution here.
33362 * rootcontext.cs: Beginning of the class resolution.
33364 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33366 * rootcontext.cs: Provide better error reporting.
33368 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33370 * rootcontext.cs (CreateInterface): Handle the case where there
33371 are no parent interfaces.
33373 (CloseTypes): Routine to flush types at the end.
33374 (CreateInterface): Track types.
33375 (GetInterfaces): Returns an array of Types from the list of
33376 defined interfaces.
33378 * typemanager.c (AddUserType): Mechanism to track user types (puts
33379 the type on the global type hash, and allows us to close it at the
33382 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33384 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33385 RecordInterface instead.
33387 * cs-parser.jay: Updated to reflect changes above.
33389 * decl.cs (Definition): Keep track of the TypeBuilder type that
33390 represents this type here. Not sure we will use it in the long
33391 run, but wont hurt for now.
33393 * driver.cs: Smaller changes to accomodate the new code.
33395 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33398 * rootcontext.cs (CreateInterface): New method, used to create
33399 the System.TypeBuilder type for interfaces.
33400 (ResolveInterfaces): new entry point to resolve the interface
33402 (CodeGen): Property, used to keep track of the code generator.
33404 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33406 * cs-parser.jay: Add a second production for delegate_declaration
33409 (enum_body): Put an opt_comma here instead of putting it on
33410 enum_body or enum_member_declarations so we can handle trailing
33411 commas on enumeration members. Gets rid of a shift/reduce.
33413 (type_list): Need a COMMA in the middle.
33415 (indexer_declaration): Tell tokenizer to recognize get/set
33417 * Remove old targets.
33419 * Re-add the parser target.
33421 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33423 * cs-parser.jay: Add precendence rules for a number of operators
33424 ot reduce the number of shift/reduce conflicts in the grammar.
33426 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33428 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33431 Get rid of old crufty code.
33433 * rootcontext.cs: Use this to keep track of the parsed
33434 representation and the defined types available to the program.
33436 * gen-treedump.cs: adjust for new convention.
33438 * type.cs: Split out the type manager, and the assembly builder
33441 * typemanager.cs: the type manager will live here now.
33443 * cil-codegen.cs: And the code generator here.
33445 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33447 * makefile: Fixed up for easy making.
33449 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33451 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33454 (unary_expression): Expand pre_increment_expression and
33455 post_decrement_expression to reduce a shift/reduce.
33457 2001-07-11 Simon Cozens
33459 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33461 Improve allow_keyword_as_indent name.
33463 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33465 * Adjustments for Beta2.
33467 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33469 * decl.cs: Added `Define' abstract method.
33470 (InTransit): new property, used to catch recursive definitions.
33472 * interface.cs: Implement `Define'.
33474 * modifiers.cs: Map Modifiers.constants to
33475 System.Reflection.TypeAttribute flags.
33477 * class.cs: Keep track of types and user-defined types.
33478 (BuilderInit): New method for creating an assembly
33479 (ResolveType): New function to launch the resolution process, only
33480 used by interfaces for now.
33482 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33483 that are inserted into the name space.
33485 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33487 * ARGH. I have screwed up my tree so many times due to the use of
33488 rsync rather than using CVS. Going to fix this at once.
33490 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33493 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33495 * Experiment successful: Use System.Type rather that our own
33498 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33500 * cs-parser.jay: Removed nsAliases from here.
33502 Use new namespaces, handle `using XXX;'
33504 * namespace.cs: Reimplemented namespace handling, use a recursive
33505 definition of the class. Now we can keep track of using clauses
33506 and catch invalid using clauses.
33508 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33510 * gen-treedump.cs: Adapted for all the renaming.
33512 * expression.cs (Expression): this class now has a Type property
33513 which returns an expression Type.
33515 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33516 `Type', as this has a different meaning now in the base
33518 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33520 * interface.cs, class.cs: Removed from all the sources the
33521 references to signature computation, as we can not do method
33522 signature computation during the parsing time, as we are not
33523 trying to solve at that point distinguishing:
33527 void a (NS.Blah x) {}
33530 Which depending on the context might be valid or not, as we do not
33531 know if Blah is the same thing as NS.Blah at that point.
33533 * Redid everything so the code uses TypeRefs now instead of
33534 Types. TypeRefs are just temporary type placeholders, that need
33535 to be resolved. They initially have a pointer to a string and the
33536 current scope in which they are used. This is used later by the
33537 compiler to resolve the reference to an actual Type.
33539 * DeclSpace is no longer a CIR.Type, and neither are
33540 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33541 are all DeclSpaces, but no Types.
33543 * type.cs (TypeRefManager): This implements the TypeRef manager,
33544 which keeps track of all the types that need to be resolved after
33545 the parsing has finished.
33547 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33549 * ARGH. We are going to have to store `foreach' as a class rather
33550 than resolving it, as we need to verify error 1579 after name
33551 resolution. *OR* we could keep a flag that says `This request to
33552 IEnumerator comes from a foreach statement' which we can then use
33553 to generate the error.
33555 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33557 * class.cs (TypeContainer.AddMethod): we now add methods to the
33558 MethodGroup instead of the method hashtable.
33560 * expression.cs: Add MethodGroup abstraction, which gets us one
33561 step closer to the specification in the way we handle method
33564 * cs-parser.jay (primary_expression): qualified_identifier now
33565 tried to match up an identifier to a local variable reference or
33566 to a parameter reference.
33568 current_local_parameters is now a parser global variable that
33569 points to the current parameters for the block, used during name
33572 (property_declaration): Now creates an implicit `value' argument to
33575 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33577 * parameter.cs: Do not use `param' arguments as part of the
33578 signature, per the spec.
33580 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33582 * decl.cs: Base class for classes, structs and interfaces. This
33583 is the "Declaration Space"
33585 * cs-parser.jay: Use CheckDef for checking declaration errors
33586 instead of having one on each function.
33588 * class.cs: Factor out some code for handling error handling in
33589 accordance to the "Declarations" section in the "Basic Concepts"
33590 chapter in the ECMA C# spec.
33592 * interface.cs: Make all interface member classes derive from
33593 InterfaceMemberBase.
33595 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33597 * Many things: all interfaces are parsed and generated in
33598 gen-treedump. Support for member variables, constructors,
33599 destructors, properties, constants is there.
33601 Beginning of the IL backend, but very little done, just there for
33604 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33606 * cs-parser.jay: Fix labeled statement.
33608 * cs-tokenizer.cs (escape): Escape " and ' always.
33609 ref_line, ref_name: keep track of the line/filename as instructed
33610 by #line by the compiler.
33613 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33615 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33616 to match the values in System.CodeDOM.
33618 Divid renamed to Divide.
33620 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33622 (Statements.set): remove.
33624 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33627 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33628 falseStatements always have valid values.
33630 * cs-parser.jay: Use System.CodeDOM now.