1 2008-02-14 Miguel de Icaza <miguel@novell.com>
3 * expression.cs: Do not fold BitwiseAnd operators when the left
4 side is a false constant, because we still need to evaluate the
9 * support.cs: Instead of throwing an InternalErrorException when
10 the position of the stream is outside the boundary of our buffer,
11 reset the state of the reader, and restart the reading from the
12 beginning of the file.
14 2008-02-14 Marek Safar <marek.safar@gmail.com>
16 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
18 2008-02-14 Marek Safar <marek.safar@gmail.com>
21 * decl.cs: A protected types used inside a private class which parents
22 derives from the protected class are accessible.
24 2008-02-13 Marek Safar <marek.safar@gmail.com>
26 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
27 the parameterless constructor.
29 2008-02-13 Marek Safar <marek.safar@gmail.com>
31 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
32 lookup methods to use standard member cache when doing member lookup.
34 2008-02-12 Marek Safar <marek.safar@gmail.com>
36 * driver.cs: Don't report full path for referenced module as assembly error.
38 2008-02-12 Marek Safar <marek.safar@gmail.com>
40 * Makefile: Fixed `qh' target to work on all machines.
42 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
43 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
44 and HasElementType with TypeManager implementation.
46 2008-02-08 Marek Safar <marek.safar@gmail.com>
48 A fix for bugs #325134, #359749
49 * expression.cs, ecore.cs: Try to resolve an extension method even if the
50 first binds point to non-method member expression.
52 2008-02-08 Marek Safar <marek.safar@gmail.com>
54 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
56 2008-02-08 Marek Safar <marek.safar@gmail.com>
58 A fix for bugs #321394, #323028
59 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
60 Reworked naive IsAccessibleAs implementation to handle nested types.
62 2008-02-05 Jb Evain <jbevain@novell.com>
64 * class.cs: use generic type comparison for parameters
67 2008-02-05 Marek Safar <marek.safar@gmail.com>
70 * class.cs: Use generic type comparison when testing method signatures.
72 2008-02-05 Marek Safar <marek.safar@gmail.com>
75 * ecore.cs: Applied C# 3.0 changes to better conversion.
77 2008-02-05 Marek Safar <marek.safar@gmail.com>
80 * cs-parser.jay: Correctly set modifiers for all constructor types.
82 2008-02-04 Marek Safar <marek.safar@gmail.com>
85 * generic.cs: Added base class constraint based type inference.
87 2008-02-01 Marek Safar <marek.safar@gmail.com>
90 * decl.cs: One more missing visibility check.
92 2008-02-01 Marek Safar <marek.safar@gmail.com>
94 * support.cs: Fixed broken return.
96 2008-01-25 Marek Safar <marek.safar@gmail.com>
98 * report.cs: Correctly reset warnings count after probing.
100 2008-01-25 Martin Baulig <martin@ximian.com>
103 (NamespaceEntry.SymbolFileID): Make this work again after
104 MemberName.ToString() is gone.
106 2008-01-25 Marek Safar <marek.safar@gmail.com>
108 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
111 2008-01-25 Marek Safar <marek.safar@gmail.com>
113 * generic.cs: Use full implicit conversion for type inference fixing.
115 2008-01-24 Marek Safar <marek.safar@gmail.com>
117 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
118 Fixed user operator conversions.
120 2008-01-24 Marek Safar <marek.safar@gmail.com>
122 * generic.cs: Do nullable type to null comparison optimization during
125 2008-01-24 Marek Safar <marek.safar@gmail.com>
127 A fix for bug #355163
128 * generic.cs: Enabled l-value resolve on nullable expressions.
130 2008-01-24 Marek Safar <marek.safar@gmail.com>
132 A fix for bug #353986
133 * class.cs: Ingore static ctors with parameters for any further checks.
135 2008-01-24 Marek Safar <marek.safar@gmail.com>
137 A fix for bug #354310
138 * namespace.cs: Removed redundant check.
140 2008-01-24 Marek Safar <marek.safar@gmail.com>
142 A fix for bug #354928
143 * expression.cs: ElementInitializers can be resolved only once.
145 2008-01-24 Marek Safar <marek.safar@gmail.com>
147 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
148 Condition expressions.
150 2008-01-23 Marek Safar <marek.safar@gmail.com>
152 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
154 2008-01-22 Marek Safar <marek.safar@gmail.com>
156 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
159 * generic.cs: Implemented coalesce expression.
161 2008-01-22 Marek Safar <marek.safar@gmail.com>
163 A fix for bug #355145
164 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
165 expression tree type inference.
167 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
170 * expression.cs (Binary.IsUnsignedType): Fix typo.
172 2008-01-22 Marek Safar <marek.safar@gmail.com>
174 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
176 2008-01-22 Marek Safar <marek.safar@gmail.com>
178 A fix for bug #355161
179 * ecore.cs, expression.cs: Wider range of extension method supported
182 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
184 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
185 AssemblyBuilder to operate in compiler context. Fixes mcs part of
188 2008-01-22 Marek Safar <marek.safar@gmail.com>
190 A fix for bug #355148
191 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
193 2008-01-22 Miguel de Icaza <miguel@novell.com>
195 * expression.cs (CreateExpressionTree): Add support for or and
196 logical or, and indent following the coding conventions.
198 * typemanager.cs (LinqExpression): renamed from
199 ExpressionTreeManager, for a shorter name.
201 Use TypeManager.CoreLookupType to lookup types from our core
202 assemblies and turn those into "Type" variables.
204 Consumers that previously used "Namespace" and "Type" from this
205 class should instead use the TypeExpression which is a type that
206 is fully resolved (without involving the regular C# resolution
209 This typically looks like this:
211 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
212 new MemberAccess (texpr, name, type_arguments, loc)
214 This avoids the problem in: #355178
216 2008-01-21 Marek Safar <marek.safar@gmail.com>
218 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
219 feature in parser only as we do in other cases.
221 2008-01-21 Marek Safar <marek.safar@gmail.com>
223 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
224 typemanager.cs: A refactoring of params arguments to reuse existing
225 expressions (params -> array initializer) to emit params argument instead
226 of specialized handling.
227 It was required by expression tree implementation and it has other benefits
228 as well, we now apply same optimization for params arguments as we do for
231 2008-01-18 Marek Safar <marek.safar@gmail.com>
233 A fix for bug #353526
234 * generic.cs: A type inference of params arguments may not required any
235 temporary array creation.
237 2008-01-18 Marek Safar <marek.safar@gmail.com>
239 A fix for bug #353534
240 * generic.cs, ecore.cs, expression.cs: A method group type inference is
241 supported for delegates only.
243 2008-01-18 Marek Safar <marek.safar@gmail.com>
245 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
246 type for more than 1 candidates.
248 2008-01-18 Marek Safar <marek.safar@gmail.com>
250 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
253 2008-01-16 Marek Safar <marek.safar@gmail.com>
255 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
256 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
257 operator) expressions.
259 2008-01-16 Zoltan Varga <vargaz@gmail.com>
261 * statement.cs: Avoid declaring an IL variable for this_variable since it is
262 not accessed from the generated IL.
264 2008-01-14 Marek Safar <marek.safar@gmail.com>
266 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
267 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
268 statement.cs: The first expression tree implementation drop, mostly
271 2008-01-14 Marek Safar <marek.safar@gmail.com>
273 * ecore.cs (IsNestedChild): Refactored.
275 2008-01-11 Marek Safar <marek.safar@gmail.com>
277 * lambda.cs: Don't use a cast on unknown expression statement.
279 2008-01-10 Geoff Norton <gnorton@novell.com>
281 * cs-tokenizer.cs: One more token to distinguish between method and lambda
284 2008-01-09 Marek Safar <marek.safar@gmail.com>
286 * doc.cs: Report better /doc crash details.
288 2008-01-09 Marek Safar <marek.safar@gmail.com>
290 A fix for bug #352536
291 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
293 2008-01-08 Marek Safar <marek.safar@gmail.com>
295 A fix for bug #352287
296 * ecore.cs, expression.cs: Do `this' access checking in all member access
299 2008-01-08 Marek Safar <marek.safar@gmail.com>
301 * rootcontext.cs, driver.cs: Switch to linq mode by default.
303 * report.cs: Reset message stacks.
305 2008-01-08 Marek Safar <marek.safar@gmail.com>
307 * generic.cs (InferInPhases): Correctly calculate params position.
309 2008-01-08 Marek Safar <marek.safar@gmail.com>
311 * cs-tokenizer.cs: No need to parse full string when parsing lambda
314 2008-01-07 Marek Safar <marek.safar@gmail.com>
316 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
318 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
320 * driver.cs: Updated --help option.
322 2008-01-07 Marek Safar <marek.safar@gmail.com>
324 * generic.cs (InferParamsTypeArguments): Removed.
325 (InferInPhases): Add params type inference.
326 (LowerBoundInference): Fixed scoring mechanism.
328 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
330 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
332 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
333 byte array for unsigned "baked" assemblies.
335 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
337 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
338 array for assemblies that are not strongnamed.
340 2008-01-04 Marek Safar <marek.safar@gmail.com>
342 A fix for bug #351481
343 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
344 declaring type for nested generic types.
346 2008-01-04 Marek Safar <marek.safar@gmail.com>
348 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
351 2008-01-03 Marek Safar <marek.safar@gmail.com>
353 A fix for bug #351047
354 * expression.cs (Binary.ResolveOperator): Allow equality operators between
355 null and structs only when equality and inequality operators are defined
356 either as an user-operators or predefined operators.
358 2008-01-03 Marek Safar <marek.safar@gmail.com>
360 A fix for bug #351047
361 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
363 2008-01-03 Marek Safar <marek.safar@gmail.com>
365 A fix for bug #351257
366 * cs-tokenizer.cs: Advance line number for '\r' correctly.
368 2008-01-03 Marek Safar <marek.safar@gmail.com>
370 A fix for bug #351157
371 * class.cs (Using): Fixed yet another broken cloning.
373 (Block): Put back more sensible default value for statements.
375 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
377 * codegen.cs: Allow AssemblyVersion with only major version component.
380 2007-12-29 Marek Safar <marek.safar@gmail.com>
382 A fix for bug #324654
383 * class.cs: Use FullName property as member name.
385 2007-12-28 Marek Safar <marek.safar@gmail.com>
387 A fix for bug #342117
388 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
389 constructor constraint.
391 2007-12-28 Marek Safar <marek.safar@gmail.com>
393 A fix for bug #338273
394 * class.cs (ProbertyBase): Access modifier checks are required for overrides
397 2007-12-28 Marek Safar <marek.safar@gmail.com>
399 A fix for bug #350839
400 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
402 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
404 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
407 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
409 * statement.cs: Changed some Hashtables to use HybridDictionaries
410 instead. It was observed that some HashTables only contained a few
411 items in the vast majority of cases. Since HybridDictionary is
412 more efficient on small sets (<10 elements), "known_variables"
413 from class ExplicitBlock as well as "labels" and "constants " from
414 class Block were changed to HybridDictionaries.
416 Atsai results: (56216kb->54987kb)
418 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
421 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
423 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
426 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
428 * expression.cs: foreach loop to for loop, saved on allocation of
429 enumerator (59333kb->59141kb)
431 * statement.cs. Changed foreach loops to for loops, saved on
432 allocation of enumerator (59141kb->59006kb)
434 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
435 when constructed with no specified capacity. This was causing a
436 few ArrayLists to allocate more memory than they would potentially
437 need in the Block class and MemberCache class. Setting the
438 ArrayLists to construct with a capacity of 1 saves some
439 memory. (56216kb->55585kb)
441 2007-12-27 Marek Safar <marek.safar@gmail.com>
443 A fix for bug #347189 (2nd issue)
444 * expression.cs (MemberAccess): Nested type can be found in base non-generic
447 2007-12-27 Miguel de Icaza <miguel@novell.com>
449 * report.cs: Do not use colors if stdout and stderr are not a
452 2007-12-27 Marek Safar <marek.safar@gmail.com>
454 A fix for bug #346998
455 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
458 2007-12-27 Marek Safar <marek.safar@gmail.com>
460 A fix for bug #343465
461 * class.cs: Explicit method name for nested types uses dots only.
463 2007-12-27 Marek Safar <marek.safar@gmail.com>
465 A fix for bug #343707
466 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
468 2007-12-27 Marek Safar <marek.safar@gmail.com>
470 * ecore.cs: Report type inference errors only when arguments count matches
473 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
475 * expression.cs, report.cs: New warning.
477 * typemanager.cs: Catch anonymous method type too.
479 2007-12-23 Marek Safar <marek.safar@gmail.com>
481 A fix for bug #346379
482 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
484 2007-12-23 Marek Safar <marek.safar@gmail.com>
486 A fix for bug #347359
487 * expression.cs (Invocation): Don't resolve already resolved expression.
489 2007-12-23 Marek Safar <marek.safar@gmail.com>
491 A fix for bug #347189
492 * class.cs (FixedField): Use non-dependent code only in the define phase.
494 2007-12-23 Marek Safar <marek.safar@gmail.com>
496 A fix for bug #348076
497 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
499 2007-12-22 Marek Safar <marek.safar@gmail.com>
501 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
502 discovered extension methods.
504 2007-12-22 Marek Safar <marek.safar@gmail.com>
506 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
509 2007-12-21 Miguel de Icaza <miguel@novell.com>
511 * report.cs (ErrorMessage): Add support for using colors on
512 terminals that support it.
514 2007-12-21 Marek Safar <marek.safar@gmail.com>
516 * ecore.cs: Use information about expanded params for error reporting.
518 2007-12-21 Marek Safar <marek.safar@gmail.com>
520 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
521 and logic for params overloads.
523 2007-12-15 Miguel de Icaza <miguel@novell.com>
525 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
526 as this is also created from the parser. Fixes #349034
528 2007-12-12 Miguel de Icaza <miguel@novell.com>
530 * statement.cs (Throw.CloneTo): it is valid to have empty
531 expressions for throw.
533 2007-12-03 Marek Safar <marek.safar@gmail.com>
535 * cs-parser.jay: Set delegate constraint parsing region correctly.
537 2007-12-03 Marek Safar <marek.safar@gmail.com>
539 A fix for bug #345467
540 * typemanager.cs (IsEqual): Compare generic parameters position only.
542 2007-11-28 Marek Safar <marek.safar@gmail.com>
544 * expression.cs (BaseAccess): Type arguments can be null.
546 2007-11-27 Raja R Harinath <harinath@gmail.com>
548 * statement.cs (Block.Resolve): Ensure flow-branching tree is
549 consistent even when an error has occured.
550 (Switch.Resolve): Likewise.
552 2007-11-22 Marek Safar <marek.safar@gmail.com>
554 A fix for bug #334505
555 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
558 2007-11-22 Marek Safar <marek.safar@gmail.com>
560 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
561 refactorings required to resolve extension methods correctly when mixing
562 generics and non-generics members.
564 2007-11-20 Marek Safar <marek.safar@gmail.com>
566 A fix for bug #342584
567 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
570 2007-11-19 Marek Safar <marek.safar@gmail.com>
572 A fix for bug #342512
573 * delegate.cs: Use delegate argument expression when is available. Don't
574 emit virtual call when class is sealed.
576 2007-11-16 Marek Safar <marek.safar@gmail.com>
578 A fix for bug #325423
579 * assign.cs (FieldInitializer): Use resolved expression for emit.
581 * class.cs: Print less confusing error message.
583 2007-11-16 Marek Safar <marek.safar@gmail.com>
585 * cs-tokenizer.cs: Removed GMCS ifdefs.
587 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
590 * cs-parser.jay: Disabled nullable check.
592 * generic-mcs: Copied more generic stuff.
594 2007-11-16 Marek Safar <marek.safar@gmail.com>
596 * gcs-parser.jay: Merged to cs-parser.jay.
598 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
599 * *.csproj, *.sources: Updated to use only jay parser file.
601 2007-11-16 Marek Safar <marek.safar@gmail.com>
603 * gcs-parser.jay: Added nullable and default expression feature checks.
605 2007-11-16 Marek Safar <marek.safar@gmail.com>
607 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
608 it fixes many TODOs and hidden bugs.
610 * expression: Removed duplicate error check.
612 2007-11-15 Marek Safar <marek.safar@gmail.com>
614 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
615 implicitly type local variable only when it is used in a declaration.
617 2007-11-15 Marek Safar <marek.safar@gmail.com>
619 * attribute.cs: Use CS0612 for empty strings.
621 2007-11-14 Marek Safar <marek.safar@gmail.com>
623 * lambda.cs, statement.cs: Contextual return may act as a statement.
625 2007-11-14 Marek Safar <marek.safar@gmail.com>
627 A fix for a regression cause by #324222
628 * class.cs: Don't report unused even when it implements an interface.
630 2007-11-13 Marek Safar <marek.safar@gmail.com>
632 A fix for bug #341205
633 * ecore.cs, expression.cs: Method group expression cannot do static
634 method access with an instance reference check before overloading takes
637 2007-11-13 Marek Safar <marek.safar@gmail.com>
639 A fix for bug #325359
640 * class.cs: Use predictable name for automatically generated property.
642 2007-11-12 Marek Safar <marek.safar@gmail.com>
644 A fix for bug #324996
645 * expression.cs (Is): Handle case where D is nullable and T is not
648 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
650 2007-11-12 Marek Safar <marek.safar@gmail.com>
652 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
653 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
654 Flush small error reporting changes.
656 2007-11-09 Marek Safar <marek.safar@gmail.com>
658 A fix for bug #324996
659 * expression.cs: Rewrote Is expression implementation to work with
660 generics, nullable types, anonymous method. A const result expression
661 uses existing infrastructure instead of custom not fully-featured one.
663 2007-11-08 Marek Safar <marek.safar@gmail.com>
665 A fix for bug #340202
666 * class.cs: Consider generics for volatile field.
668 2007-11-08 Marek Safar <marek.safar@gmail.com>
670 A fix for bug #335594
671 * expression.cs: Use conversion rules when handling string addition.
673 2007-11-07 Marek Safar <marek.safar@gmail.com>
675 A fix for bug #336651
676 * expression.cs: Fixed a crash when probing is on.
678 2007-11-07 Marek Safar <marek.safar@gmail.com>
680 A fix for bug #324242
681 * covert.cs: Added a conversion from any nullable-type with an
682 underlying enum-type to the type System.Enum.
684 2007-11-07 Marek Safar <marek.safar@gmail.com>
686 A fix for bug #324222
687 * class.cs: Report all non-used event fields.
689 2007-11-07 Marek Safar <marek.safar@gmail.com>
691 A fix for bug #325161
692 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
693 qualifier for generic types.
695 2007-11-07 Marek Safar <marek.safar@gmail.com>
697 A fix for bug #322971
698 * expression.cs, ecore.cs: Added intermediate result value check for
701 2007-11-07 Marek Safar <marek.safar@gmail.com>
703 A fix for bug #324754
704 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
705 when it was requested.
707 2007-11-07 Marek Safar <marek.safar@gmail.com>
709 A fix for bug #325101
710 * expression.cs: Do type not value comparison for `is' expression.
712 2007-11-07 Marek Safar <marek.safar@gmail.com>
714 A fix for bug #320236
715 * convert.cs: Don't apply user conversion on underlying target type.
717 2007-11-06 Marek Safar <marek.safar@gmail.com>
719 * expression.cs: Don't use unresolved expression for error reporting.
721 2007-11-06 Marek Safar <marek.safar@gmail.com>
723 A fix for bugs #337712, #324490
724 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
725 overloading resolution too.
727 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
728 the process consistent and more robust.
730 * expression.cs, linq.cs, report.cs: Update.
732 2007-11-02 Marek Safar <marek.safar@gmail.com>
734 A fix for bug #332909
735 * attribute.cs: Resolve attributes in correct context using error
738 * rootcontext.cs: Define Obsolete attribute members as core members.
740 2007-11-02 Marek Safar <marek.safar@gmail.com>
742 * statement.cs: Removed unused methods.
744 2007-10-31 Wade Berrier <wberrier@novell.com>
746 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
747 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
750 2007-10-31 Marek Safar <marek.safar@gmail.com>
752 A fix for bug #338102
753 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
754 methods registered as non-generics.
756 2007-10-31 Marek Safar <marek.safar@gmail.com>
758 A fix for bugs #337712, #324490
759 * delegate.cs: Delegate covariance and contravariance is not allowed for
762 2007-10-31 Marek Safar <marek.safar@gmail.com>
764 A fix for bug #337719
765 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
768 2007-10-30 Marek Safar <marek.safar@gmail.com>
770 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
772 2007-10-29 Marek Safar <marek.safar@gmail.com>
774 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
777 2007-10-29 Raja R Harinath <rharinath@novell.com>
779 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
781 2007-10-29 Marek Safar <marek.safar@gmail.com>
783 A fix for bug #334652
784 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
785 extension methods when we have not found the best candidate in normal
788 2007-10-27 Marek Safar <marek.safar@gmail.com>
790 * AssemblyInfo.cs: Keep up-to-date.
792 2007-10-27 Marek Safar <marek.safar@gmail.com>
794 * Makefile: Fixed generics compiler name.
796 2007-10-27 Marek Safar <marek.safar@gmail.com>
798 * lambda.test: removed, lambda parsing is done differently.
800 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
802 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
804 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
806 2007-10-27 Marek Safar <marek.safar@gmail.com>
808 * Makefile, *.sources : All C# compilers are in mcs folder.
810 * *.cs: Use existing 2_1 define for smcs.
812 2007-10-26 Marek Safar <marek.safar@gmail.com>
814 A fix for bug #335847
815 * assign.cs, expression.cs: Couple of changes to avoid creating a
816 temporary variable for each object initializer assignment statement. It
817 simplifies struct initialization too, otherwise two temporary variables
819 Implemented optimization of redundant default element initializers.
821 2007-10-25 Marek Safar <marek.safar@gmail.com>
823 A fix for bug #336766
824 * expression.cs (Class.CheckBase): Use generic name when method is
827 2007-10-25 Marek Safar <marek.safar@gmail.com>
829 A fix for bug #334737
830 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
831 variable and not variable argument for prepared copies.
833 2007-10-24 Marek Safar <marek.safar@gmail.com>
835 A fix for bug #325110
836 * class.cs, expression.cs, attribute.cs: Use open generic method when
837 checking conditional attribute.
839 2007-10-24 Marek Safar <marek.safar@gmail.com>
841 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
842 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
843 FeatureIsNotAvailable.
845 2007-10-24 Marek Safar <marek.safar@gmail.com>
847 ** C# 3.0 Partial methods
849 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
850 methods support. Because of member cache issue with generics only
851 non-generics partial methods are fully supported.
853 2007-10-23 Marek Safar <marek.safar@gmail.com>
855 * class.cs, decl.cs: Rewrote member overloads check to cope with
856 generics and to use member cache for member checking. It also improves
857 performance and fixes remaining overloads issues.
859 2007-10-20 Marek Safar <marek.safar@gmail.com>
861 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
862 roottypes.cs, typemanager.cs:
864 A member cache creation logic changed to add members immediately and
865 not rely on fallback. The member cache is now only prefered way
866 how to access and find type declaration members. It saves 5 MB of memory
867 during MWF compilation and makes code ready for more optimizations and
868 clean-ups, it's also a pre-requirement for partial methods.
870 2007-10-18 Raja R Harinath <harinath@gmail.com>
872 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
873 handling for generic parameters.
875 2007-10-15 Marek Safar <marek.safar@gmail.com>
877 * class.cs (FixedField): Removed redundant volatile check.
879 2007-10-15 Marek Safar <marek.safar@gmail.com>
881 * class.cs, decl.cs: Fixed overload members verification to do only one
882 check per possible collision.
884 2007-10-13 Marek Safar <marek.safar@gmail.com>
886 A fix for bug #325478
887 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
888 and create only one disposable flags container.
890 2007-10-12 Marek Safar <marek.safar@gmail.com>
892 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
893 * statement.cs (Fixed): Fixed variables cloning.
895 2007-10-12 Marek Safar <marek.safar@gmail.com>
897 A fix for bug #333342
898 * class.cs (EventField): Don't mark value type event as synchronized.
900 2007-10-12 Marek Safar <marek.safar@gmail.com>
902 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
903 inference to identify best candidate method correctly.
904 (ProperyExpr): A range variable is read only and cannot be modified.
906 2007-10-11 Marek Safar <marek.safar@gmail.com>
908 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
909 logic to identify best candidate method correctly.
911 2007-10-11 Marek Safar <marek.safar@gmail.com>
913 * location.cs (Equals, GetHashCode): Removed.
915 2007-10-11 Marek Safar <marek.safar@gmail.com>
917 * report.cs: Implemented message recorder. It is used mainly for lambda
918 expressions to capture otherwise swallowed error messages.
920 * anonymous.cs, lambda.cs.cs: Do full parameters check.
922 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
924 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
926 * expression.cs (MemberAccess): Always report lookup failure.
928 * location.cs: Implemented Equals, GetHashCode.
930 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
932 2007-10-10 Jb Evain <jbevain@novell.com>
934 * codegen.cs: re-enable assembly version check.
936 2007-10-09 Marek Safar <marek.safar@gmail.com>
938 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
941 * namespace.cs (UsingAlias): Do correct version check.
943 2007-10-08 Marek Safar <marek.safar@gmail.com>
945 * expresison.cs, ecore.cs: Issue extension method error message when
948 * rootcontext.cs: Added ISO_2 compiler mode option.
950 2007-10-08 Marek Safar <marek.safar@gmail.com>
952 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
955 2007-10-08 Marek Safar <marek.safar@gmail.com>
957 * attribute.cs (GetString, GetBoolean): Work with both literal and
960 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
961 Moved method overload specific methods to MethodGroupExpr.
963 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
964 it should be less memory consuming.
966 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
968 * codegen.cs: remove the assembly version check until the buildbot is
971 2007-10-07 Jb Evain <jbevain@novell.com>
973 * attribute.cs (Attribute.GetString): if the value
974 expression is a StringConstant, return its string value.
976 2007-10-07 Jb Evain <jbevain@novell.com>
978 * typemanager.cs: add `assembly_version_attribute_type`.
979 * codegen.cs: on attribute emission, check that the
980 AssemblyVersionAttribute doesn't overflow.
982 2007-10-05 Marek Safar <marek.safar@gmail.com>
984 A fix for bug #324677
985 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
986 parent container of a scope container with currently resolved one.
988 2007-10-05 Marek Safar <marek.safar@gmail.com>
990 A fix for bug #325534
991 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
994 2007-10-05 Marek Safar <marek.safar@gmail.com>
996 A fix for bug #327504
997 * class.cs (Operator.Define): Refactored implicit and explicit user
998 operator conversion rules.
1000 2007-10-05 Marek Safar <marek.safar@gmail.com>
1002 A fix for bug #327520
1003 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
1005 2007-10-04 Marek Safar <marek.safar@gmail.com>
1007 A fix for bug #328022
1008 * class.cs (MethodData.Define): Use correct method to check whether
1009 a method implementents an accessor.
1011 2007-10-04 Marek Safar <marek.safar@gmail.com>
1013 A fix for bug #330069
1014 * statement.cs (Fixed.Resolve): Read the first array element only when
1015 an array is instantiated.
1017 2007-10-04 Marek Safar <marek.safar@gmail.com>
1019 * expression.cs, assign.cs, generics.cs: Print correct operator when
1020 compound assignment is used.
1022 2007-10-04 Marek Safar <marek.safar@gmail.com>
1024 A fix for bug #325841
1025 * expression.cs (ArrayAccess): Use full argument cloning only for
1026 string compound concatenation.
1028 2007-10-03 Marek Safar <marek.safar@gmail.com>
1030 A fix for bug #328774
1031 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
1033 (PropertyExpr.EmitAssign): Fixed string concatenation compound
1036 2007-10-03 Raja R Harinath <rharinath@novell.com>
1039 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
1040 Event accessibility checks here. Remove some bogus code that
1041 accidently made GenericMethods work.
1042 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
1044 2007-09-25 Marek Safar <marek.safar@gmail.com>
1046 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
1048 * statement.cs (Block): Refactored AddVariable to allow error handling
1051 * generic.cs: New stub.
1053 2007-09-23 Marek Safar <marek.safar@gmail.com>
1055 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
1058 2007-09-17 Marek Safar <marek.safar@gmail.com>
1060 * class.cs: Use partial container to record whether any partial part
1061 contains static field initializer and therefore default contructor has
1064 2007-09-14 Marek Safar <marek.safar@gmail.com>
1066 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
1067 mono-list when only one of two partial parts has defined accessibility
1070 2007-09-14 Marek Safar <marek.safar@gmail.com>
1072 A fix for bug #82845
1074 * class.cs (TypeContainer): Set correct resolve context for all field
1077 2007-09-13 Marek Safar <marek.safar@gmail.com>
1079 * assign.cs: Fixed a crash when field is resolved twice with an error.
1081 * codegen.cs: Changed InFieldInitializer to be flag.
1083 * anonymous.cs, ecore.cs, expression.cs: Update after
1084 IsInFieldInitializer rename.
1086 * const.cs: Removed unused parameter.
1088 * class.cs: Changed the way how we resolve and emit field initializers.
1089 The field initilizers have to have access to contructor block to emit
1090 compiler generated code.
1092 2007-09-13 Marek Safar <marek.safar@gmail.com>
1094 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
1095 generics use TypeContainer instead.
1097 2007-09-12 Marek Safar <marek.safar@gmail.com>
1099 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
1101 * lambda.cs (ResolveParameters): Use more powerful
1102 InflateGenericArgument.
1104 * parameters.cs: Better exception message.
1106 2007-09-10 Marek Safar <marek.safar@gmail.com>
1108 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
1109 correct expression block type.
1111 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
1113 * expression.cs (Invocation): Extracted method group resolve to
1116 2007-09-07 Marek Safar <marek.safar@gmail.com>
1118 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
1119 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
1121 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
1122 generic extension methods.
1124 2007-09-06 Marek Safar <marek.safar@gmail.com>
1126 A fix for bug #82676 (Do I get it right now?)
1127 * convert.cs (Binary.ResolveOperator): An interface is converted to the
1128 object before a standard conversion is applied.
1130 2007-09-06 Marek Safar <marek.safar@gmail.com>
1132 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
1135 2007-09-05 Marek Safar <marek.safar@gmail.com>
1137 A fix for bug #82676
1138 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
1139 non-generic interface types.
1141 2007-09-05 Marek Safar <marek.safar@gmail.com>
1143 A fix for bug #82690
1144 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
1146 2007-09-05 Marek Safar <marek.safar@gmail.com>
1148 A fix for bug #82571
1149 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
1150 modifier for container based methods.
1152 2007-09-05 Marek Safar <marek.safar@gmail.com>
1154 A fix for bug #82676
1155 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
1156 any interface-type T means to any of interface type T.
1158 2007-09-04 Marek Safar <marek.safar@gmail.com>
1160 * namespace.cs: We have 2 versions of System.Core assembly.
1162 2007-09-04 Marek Safar <marek.safar@gmail.com>
1164 A fix for bug #82652
1165 * class.cs (Class.GetClassBases): Compare types and not expressions.
1167 2007-09-04 Marek Safar <marek.safar@gmail.com>
1169 A fix for bug #82620
1170 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
1171 actually never worked before.
1172 (IndexerAccess): Emit prepared arguments before they are modified.
1174 2007-09-04 Marek Safar <marek.safar@gmail.com>
1176 A fix for bug #82563
1177 * assign.cs: Revert wrong fix.
1179 * expression.cs (VariableReference.EmitAssign): Handle ref reference
1181 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
1182 Instead of ldelema/stdind we have to use temporary variables to handle
1183 cases like String.Concat (params string[]).
1185 2007-08-31 Marek Safar <marek.safar@gmail.com>
1187 * class.cs: EmitAttributes to Emit rename.
1189 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
1191 (MemberCore.HasClsCompliantAttribute): Don't depend on
1192 GetClsCompliantAttributeValue execution.
1194 2007-08-31 Marek Safar <marek.safar@gmail.com>
1196 * anonymous.cs: Use shorter type prefix.
1198 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
1201 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
1202 variables when probing is on.
1204 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
1205 unresolved variables.
1206 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
1207 handle transparent identifiers.
1209 2007-08-26 Marek Safar <marek.safar@gmail.com>
1211 * attribute.cs (IsClsCompliant): Add nullable types test.
1213 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
1215 * doc.cs : catch other types of exception than XmlException to
1216 report CS1570. Fixed bug #82565.
1218 2007-08-23 Marek Safar <marek.safar@gmail.com>
1220 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
1221 The number of delegate parameters has to match.
1222 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
1225 2007-08-21 Marek Safar <marek.safar@gmail.com>
1227 * anonymous.cs (AnonymousMethod): Generate private anonymous method
1228 to fix problem with private arguments.
1230 2007-08-20 Marek Safar <marek.safar@gmail.com>
1232 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
1234 * decl.cs (MemberName): Ignore generic type with no generic arguments.
1236 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
1237 empty. Add cloning suport.
1239 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
1241 2007-08-20 Marek Safar <marek.safar@gmail.com>
1243 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
1244 to create EmptyCast. It handles EmptyConstantCast specialization for
1247 2007-08-18 Marek Safar <marek.safar@gmail.com>
1249 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
1250 (EmitArrayArgument): One routine for array arguments.
1251 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
1253 2007-08-17 Marek Safar <marek.safar@gmail.com>
1255 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
1257 2007-08-17 Marek Safar <marek.safar@gmail.com>
1259 * anonymous.cs: MemberLookupFinal update.
1261 * class.cs (ConstructorInitializer): Is expression based.
1263 * delegate.cs: MethodGroupExpr update.
1265 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
1267 (Error_MemberLookupFailed): Customizable error override.
1268 (MethodGroupExpr): Keep queried type for later usage.
1269 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
1272 * expression.cs: Error_MemberLookupFailed refactoring.
1273 (New.DoResolve): Resolve as much as possible.
1274 (ElementInitializer.Error_MemberLookupFailed): Object initializer
1275 customization for invalid member types.
1277 * statement.cs: MethodGroupExpr update.
1279 2007-08-16 Marek Safar <marek.safar@gmail.com>
1281 * modifier.cs (Check): Check all modifiers and not only accessibility
1284 2007-08-16 Marek Safar <marek.safar@gmail.com>
1286 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
1287 type and not an expression.
1289 2007-08-16 Marek Safar <marek.safar@gmail.com>
1291 * statement.cs (Catch.Clone): Type and variable can be null.
1293 2007-08-16 Marek Safar <marek.safar@gmail.com>
1295 A fix for bug #81979
1296 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
1297 I am really not sure whether this is the best fix.
1299 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
1302 2007-08-14 Marek Safar <marek.safar@gmail.com>
1304 ** C# 3.0 Object and collection initializers (major re-write)
1306 * assign.cs (DoResolve): Initializers are not assign related.
1308 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
1309 used during collection or object initialization.
1311 * expression.cs (Error_InvalidArguments): Add initializers specific
1312 messages. More will come later because it requires some general
1314 (New.DoResolve): Better error handling for unsafe types.
1315 (EmptyExpressionStatement): New class.
1316 (ElementInitializer): An object initializer expression.
1317 (CollectionElementInitializer): A collection initializer expression.
1318 (CollectionOrObjectInitializers): A block of object or collection
1320 (NewInitialize): New expression with element/object initializers.
1322 * statement.cs: Reverted object/collection initializer hacks.
1324 * typemanager.cs (CSharpName): Filter __arglist type.
1326 2007-08-09 Marek Safar <marek.safar@gmail.com>
1328 ** C# 3.0 Anonymous Types (update to the latest standard)
1330 * expression.cs (Binary.ResolveOperator): Threat all null based types
1332 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
1333 (AnonymousTypeParameter): Updated.
1335 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
1336 (AnonymousTypeClass): New anonymous type container.
1338 * class.cs (AddField): Return operation result.
1340 * generic.cs: Another empty TypeArguments overload.
1342 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
1343 are stored at top of normal hierarchy.
1345 * typemanager.cs (CSharpName): Filter anonymous types.
1347 2007-08-09 Marek Safar <marek.safar@gmail.com>
1349 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
1350 as single Concat call. How could we miss that :-(
1352 2007-08-08 Marek Safar <marek.safar@gmail.com>
1354 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
1356 2007-08-07 Miguel de Icaza <miguel@novell.com>
1358 * expression.cs: Fix the previous commit, the creation of the
1359 arguments array list needs also to be conditional on the arguments
1362 * class.cs: Add a little bit of help to help narrow down problems.
1364 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
1365 not try to copy in that case.
1367 * driver.cs: When building SMCS, include a new different set of
1368 default assemblies here. Do this here so we can control whether
1369 to include the default assemblies with /noconfig.
1371 2007-08-03 Marek Safar <marek.safar@gmail.com>
1373 A fix for bug #81979
1374 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
1377 2007-08-03 Marek Safar <marek.safar@gmail.com>
1379 A fix for bug #82300
1381 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
1382 we are in probing scope.
1384 2007-08-03 Marek Safar <marek.safar@gmail.com>
1386 A fix for bug #82301
1388 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
1389 (Statement.CloneTo): Clone and not map children blocks.
1391 2007-08-03 Marek Safar <marek.safar@gmail.com>
1393 A fix for bug #82299
1395 * expression.cs (LocalVariableReference.CloneTo): Remap local info
1398 * statement.cs (Statement.CloneTo): Clone variables before statements
1399 to allow remaping of local variables.
1401 2007-08-03 Marek Safar <marek.safar@gmail.com>
1403 A fix for bug #82296
1406 * report.cs: Log crash details for future clone problems.
1408 * statement.cs (Return.Clone): Don't clone non-existent expression.
1410 2007-08-03 Raja R Harinath <harinath@gmail.com>
1412 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
1413 (Class.AddBasesForPart): Move CS0537 check here from ...
1414 * cs-parser.jay (class_declaration): ... here. Move calling of
1415 'AddBasesForPart' to ...
1416 (class_bases): ... here.
1417 (struct_declaration, interface_declaration): Update to changes.
1419 2007-08-02 Marek Safar <marek.safar@gmail.com>
1421 A fix for bug #81923
1423 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
1424 conversion is allowed.
1426 2007-08-02 Marek Safar <marek.safar@gmail.com>
1428 A fix for bug #81564
1430 * ecore.cs (EventExpr): Add IsBase handling.
1432 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
1435 2007-08-02 Raja R Harinath <harinath@gmail.com>
1437 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
1438 * cs-parser.jay: Some whitespace cleanups.
1439 (current_delegate): New.
1441 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
1442 a dummy code block, and use 'type_name' instead of 'member_name'.
1443 (interface_declaration, class_declaration): Likewise.
1444 (delegate_declaration): Likewise. Rearrange slightly and use
1446 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
1447 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
1449 2007-08-02 Marek Safar <marek.safar@gmail.com>
1451 A fix for bug #82039
1453 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
1456 * typemanager.cs (CSharpName): Split to string overload.
1458 2007-08-02 Marek Safar <marek.safar@gmail.com>
1461 * report.cs: Updated warning CS0472.
1463 2007-08-01 Marek Safar <marek.safar@gmail.com>
1465 A fix for bug #82181
1467 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
1469 2007-08-01 Marek Safar <marek.safar@gmail.com>
1471 A fix for bug #82277
1472 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
1474 2007-08-01 Marek Safar <marek.safar@gmail.com>
1476 ** C# 3.0 Type Inference (major bits are working)
1478 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
1479 (.ImplicitStandardConversionExists): Uses compatible.
1480 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
1481 (.InferReturnType): New method.
1482 (.Compatible): Refactored.
1483 (.ResolveParameters): Uses factory to create resolved parameters.
1484 (.CompatibleMethod): Add probing mode support.
1485 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
1486 clearly distinguish between 2 different operations.
1487 (LambdaMethod): Moved to lambda.cs.
1488 (AnonymousMethod): Removed unused fields and methods.
1489 (AnonymousDelegate): Simplified.
1491 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
1493 * convert. cs (ImplicitConversionStandard): Compatible works differently.
1495 * delegate.cs (Delegate): New mehods to reduce code duplication.
1496 (.GetConstructor): New method.
1497 (.GetInvokeMethod): New method.
1498 (DelegateCreation): Updated.
1500 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
1502 (OverloadResolve): Made probing little bit faster.
1504 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
1507 * generic.cs (TypeInferenceContext): Dummy implementation.
1509 * iterators.cs: Updated after Resolve/Define rename.
1511 * lambda.cs (LambdaExpression)
1512 (.ResolveParameters): Handles both type of arguments and type inference too.
1514 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
1515 (InflateTypes): Updated.
1517 * support.cs (InflateTypes): Changed signature and updated.
1519 * typemanager.cs (LookupMemberCache): Better dynamic type check.
1520 (MemberLookup_FindMembers): More MS tricks.
1521 (GetParameterData): Ditto.
1522 (GetDelegateParameters): Uses quick path for dynamic types.
1524 2007-08-01 Marek Safar <marek.safar@gmail.com>
1526 * class.cs (MethodData.Define): EmitContext is required for generic stuff
1529 2007-07-31 Marek Safar <marek.safar@gmail.com>
1531 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
1534 2007-07-26 Jb Evain <jbevain@novell.com>
1536 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
1537 which takes a boolean 'report_errors', similar to the GetMethod.
1538 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
1539 in .net 2.1, do not report errors here.
1541 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
1542 System.Runtime.CompilerServices.RequiredAttributeAttribute and
1543 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
1546 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
1547 of the type InternalsVisibleToAttribute before the first call
1548 to CoreLookupType which is allowed to fail (third boolean parameter
1549 to true). Because, during the resolution for a type that is not
1550 immediately found, we try to check if the type is not defined in
1551 a friend assembly, and to do so, we need the
1552 InternalVisibleToAttribute.
1554 2007-07-23 Miguel de Icaza <miguel@novell.com>
1556 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
1557 feature that allows structs to be compared against null and inline
1558 the result as true or false.
1560 Notice that the same code is not permitted inside a generic block
1561 of code that would do:
1563 class Foo<T> where T : struct {
1570 It is only allowed if the type of T is not bound (no where
1571 clause). In my opinion, this CSC 2 behavior is broken but people
1572 seem to be using it (IronRuby does, a few bug reports on bugzilla
1573 have it and some people have complained about it).
1575 All of the users that depend on this behavior have code that is
1578 * report.cs (Warning, Error): make these take object arguments,
1579 not strings, as that allows us to take advantage of Format.
1581 2007-07-20 William Holmes <billholmes54@gmail.com>
1583 * decl.cs: Changed MemberName.CountTypeArguments to also check the
1584 Left member variable for the Count.
1585 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
1586 MemberName.CountTypeArguments to avoid a NRE.
1588 This code is contributed under the MIT X11 license
1590 2007-07-18 Marek Safar <marek.safar@gmail.com>
1592 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
1594 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1596 * doc.cs : generic method arguments are written as ``x while generic
1597 type arguments are `x. Combined with the previous change, fixed bug
1600 2007-07-18 Raja R Harinath <rharinath@novell.com>
1603 * expression.cs (Binary.ResolveOperator): When converting
1604 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
1606 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1608 * doc.cs : when T: or whatever x: is specified, it does not really
1609 check the doc comment's syntax correctness. Fixed bug #82006.
1611 2007-07-18 Marek Safar <marek.safar@gmail.com>
1613 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
1614 LambdaExpression better.
1616 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
1618 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
1620 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
1621 as it can be generated.
1623 * expression.cs (Invocation.Error_InvalidArguments): Show correct
1626 * lambda.cs (LambdaExpression): Refactored to share same code with
1627 AnonymousMethodExpression.
1629 2007-07-17 Marek Safar <marek.safar@gmail.com>
1631 * anonymous.cs (MakeName): Include host name for easier debugging.
1632 (LambdaMethod): New class for lambda spcecific stuff.
1634 * attribute.cs: Set EmitContext return type.
1636 * class.cs: Set EmitContext return type.
1638 * codegen.cs (EmitContext): Return type cannot be null to stop messing
1639 with null/void meaning.
1641 * iterators.cs (ContainerType): Implemented.
1643 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
1645 * statement.cs (Return): Updated to lambda expressions.
1646 (Block.CloneTo): Parent can be null.
1648 2007-07-13 Marek Safar <marek.safar@gmail.com>
1650 A fix for bug #81917
1651 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
1653 * class.cs (FixedField): Check whether field is in unsafe scope.
1655 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
1656 (FieldExpr.Emit): Fixed buffers cannot be volatile.
1658 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
1661 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
1663 2007-07-13 Marek Safar <marek.safar@gmail.com>
1665 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
1666 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
1669 2007-07-13 Marek Safar <marek.safar@gmail.com>
1671 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
1673 2007-07-13 Marek Safar <marek.safar@gmail.com>
1675 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
1676 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
1678 * codegen.cs(EmitContext): Add ProbingMode flag.
1680 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
1682 * driver.cs: For now set both warning values.
1684 * ecore.cs (SimpleName): Name is readonly.
1685 (MethodGroup.OverloadResolve): One quick path for probing.
1687 * expression.cs (Unary): Set Oper r/o.
1688 (Binary): Set Oper r/o.
1689 (ParameterReference): Set few instance variables as r/o.
1690 (ParameterReference.DoResolveBase): Don't capture aruments when
1692 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
1693 (Arglist): arguments are private.
1694 (SizeOf): type is private and r/o.
1695 (MemberAccess): arguments are private.
1697 * report.cs: Enhanced reporting on/off capabilities.
1699 * lambda.cs: Uses ec.IsInProbingMode.
1700 (ContextualReturn): Derives from return.
1702 * rootcontext.cs: For now set both warning values.
1704 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
1706 (Return.Resolve): Don't die immediately.
1707 (Block.Resolve): Speed-up probing.
1708 (Block.CloneTo): Clone only child blocks.
1710 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
1712 * iterators.cs: reverted Miguel's latest change (r81925) as it
1713 breaks the build in System.
1715 2007-07-13 Miguel de Icaza <miguel@novell.com>
1717 * iterators.cs (Yield.CheckContext): Check for the iterator type
1718 also here as we can call into Yield even in codepaths that are not
1720 (MethodOrOperator is the only path that was checked).
1722 In addition to the standard check, use a more specific check for
1723 constructors to report a more verbose error.
1725 2007-07-12 Miguel de Icaza <miguel@novell.com>
1727 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
1728 report the warning and continue
1730 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
1731 values on the stack on the call to Emit. Use EmitStatement if
1732 possible, or using Emit + Pop if not possible. Fixes #82064
1734 2007-07-12 Raja R Harinath <rharinath@novell.com>
1736 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
1737 avoid try...finally in some cases.
1739 2007-07-10 Marek Safar <marek.safar@gmail.com>
1741 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
1743 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
1744 instead of method. Re-use standard error handling.
1745 (ConstructorInitializer.Emit): Simplified.
1747 * delegate.cs: Updated after Invocation.EmitCall change.
1749 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
1750 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
1751 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
1752 method and don't permanently changing input arguments.
1753 (MethodGroupExpr): Introduced resolved best_candidate, when method group
1754 is resolved it has one of the candidates is the best one which is later
1755 used to emit. Removed a few unused method.
1756 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
1758 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
1759 (Binary.ResolveOperator): Ditto.
1760 (ConditionalLogicalOperator.DoResolve): Ditto.
1761 (Invocation): Uses method group.
1762 (Invocation.DoResolve): Simplified.
1763 (Invocation.EmitCall): Removed useless is_static.
1764 (Invocation.Emit): Delegate to method group.
1765 (Invocation.EmitStatement): Simplified.
1766 (New): Uses method group.
1767 (MemberAccess.DoResolve): Don't destroy original expression.
1769 * statement.cs (ForEach.Resolve): Use null for no method arguments.
1771 2007-07-04 Marek Safar <marek.safar@gmail.com>
1773 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
1776 * lambda.cs: Add custom error message type.
1778 2007-07-03 Marek Safar <marek.safar@gmail.com>
1780 * lambda.cs: Simplified little bit.
1782 * parameter.cs: Introduced ImplicitLambdaParameter.
1783 (Parameters.CreateFullyResolved): New factory instead of ctor.
1787 * delegate.cs: Updated parameter creation.
1789 2007-07-03 Marek Safar <marek.safar@gmail.com>
1791 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
1794 * generic.cs: Synchronized with gmcs.
1796 2007-07-03 Marek Safar <marek.safar@gmail.com>
1798 * class.cs (Indexer): Check return type as soon as possible.
1800 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
1803 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
1805 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
1807 * parameter.cs (Parameter): Use expression type when it is available.
1809 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
1810 method modifier for the first parameter only.
1812 2007-06-24 Marek Safar <marek.safar@gmail.com>
1814 A fix for bug #81938
1815 * typemanager.cs (ChangeType): Fixed couple of char conversions.
1817 * constant.cs: Tide up an exception message.
1819 2007-06-22 Marek Safar <marek.safar@gmail.com>
1821 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
1822 an uninitialized variable is used.
1824 * expression.cs (LocalVariableReference.DoResolve): Ditto.
1826 2007-06-22 Marek Safar <marek.safar@gmail.com>
1828 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
1829 not found error handling.
1831 * expression.cs (ArrayCreation): Removed redundant fields and little bit
1833 (ArrayCreation.ResolveArrayElement): To be ready to customization.
1834 (ArrayCreation.DoResolve): Simplified.
1835 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
1836 its own resolve process.
1837 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
1839 2007-06-20 Marek Safar <marek.safar@gmail.com>
1841 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
1844 2007-06-20 Marek Safar <marek.safar@gmail.com>
1846 * cs-tokenizer.cs: Removed var related stuff.
1848 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
1849 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
1850 a type and a keyword at same time.
1852 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
1855 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
1856 implicitly typed arrays, more changes will follow.
1858 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
1860 2007-06-19 Marek Safar <marek.safar@gmail.com>
1862 * ecore.cs (VarExpr): Removed Handled field.
1864 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
1865 build-in assign functionality.
1866 (ForEach.Resolve): Removed all implicitly typed local variable code and
1868 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
1869 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
1871 2007-06-18 Marek Safar <marek.safar@gmail.com>
1873 * assign.cs: Removed implicitly typed local variable check.
1875 * expression.cs (LocalVariableReference.DoResolve): Add check for self
1876 referencing implicitly typed local variable.
1877 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
1880 * statement.cs (Fixed): Removed unsupported implicitly typed local
1883 2007-06-15 Marek Safar <marek.safar@gmail.com>
1885 * decl.cs (MemberName): Moved all Unbound stuff to parser.
1887 2007-06-14 Marek Safar <marek.safar@gmail.com>
1889 A fix for bugs #81855 and #76274
1890 * attribute.cs (AttachTo): Always set owner for global attributes to
1893 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
1896 * cs-parser.jay: Assembly and module attributes must precede all other
1897 elements except using clauses and extern alias declarations.
1899 2007-06-13 Marek Safar <marek.safar@gmail.com>
1901 A fix for bug #81748
1903 * expression.cs: More checks for non ISO-1 features.
1905 2007-06-12 Marek Safar <marek.safar@gmail.com>
1907 A fix for bug #81807
1908 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
1909 present inside switch statement and it is required by nullable check.
1911 2007-06-12 Marek Safar <marek.safar@gmail.com>
1913 A fix for bug #81840
1914 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
1915 when type matching fails.
1917 * namespace.cs: Tiny error message change.
1919 2007-06-12 Marek Safar <marek.safar@gmail.com>
1921 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
1922 reporting. Added automatic property check.
1924 * class.cs: Updated after CheckAbstractAndExtern relocation.
1925 (AEventPropertyAccessor.GetSignatureForError): Customized.
1927 2007-06-11 Marek Safar <marek.safar@gmail.com>
1929 * class.cs (DefineBaseTypes): Base type can be undefined.
1931 * ecore.cs (TypeLookup): Minor refactoring.
1932 (DoResolveAsTypeStep): Removed redundant check.
1934 * namespace.cs (Lookup): Removed redundant check.
1936 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
1937 ResolveAsTypeTerminal step.
1938 (BootstrapCorlib_*): Simplified.
1939 (PopulateCoreType): Core types can be now external.
1941 2007-06-07 Marek Safar <marek.safar@gmail.com>
1943 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
1945 (InferTypeArguments): Infers anonymous expression type arguments.
1946 (Compatible): Split to Compatible and InferTypeArguments.
1948 * lambda.cs: Updated.
1950 2007-06-08 Marek Safar <marek.safar@gmail.com>
1952 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
1954 2007-06-07 Raja R Harinath <harinath@gmail.com>
1956 Fix #80477, cs0135-2.cs, cs0135-3.cs
1957 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
1958 names to the "known" variables list.
1959 (Block.CheckInvariantMeaningInBlock): Handle the fact the
1960 parameter names are also "known".
1961 (Block.CheckError136): Remove.
1962 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
1965 2007-06-07 Marek Safar <marek.safar@gmail.com>
1967 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
1969 2007-06-06 Marek Safar <marek.safar@gmail.com>
1971 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
1972 internal error not an user error.
1974 * expression.cs (IsApplicable): Refactored to make debugging easier.
1976 * support.cs: More tricks for non-mono runtimes.
1978 * typemanager.cs (CoreLookupType): Made public.
1979 (InitSystemCore): All linq specific stuff moved to linq.cs
1981 2007-06-05 Marek Safar <marek.safar@gmail.com>
1983 * typemanager.cs (CSharpSignature): One more missing build-in types
1985 More tricks for non-mono runtime.
1987 2007-06-05 Raja R Harinath <harinath@gmail.com>
1989 * statement.cs (Block.CheckError136_InParents): Remove.
1990 (Block.AddVariable): Use GetParameterInfo instead.
1991 (ToplevelBlock.ProcessArguments): Likewise.
1993 2007-06-04 Raja R Harinath <rharinath@novell.com>
1995 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
1997 (ToplevelBlock.GetParameterInfo): Split out of ...
1998 (ToplevelBlock.GetParameterRefernce): ... this.
1999 (ToplevelBlock.ParameterMap): Remove.
2000 * expression.cs (ParameterReference): Update to use
2001 ToplevelParameterInfo.
2003 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
2006 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
2007 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
2009 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
2010 (ToplevelBlock.ProcessParameters) ... here.
2011 (ToplevelBlock..ctor): Invoke it.
2013 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
2016 * statement.cs (IKnownVariable): New interface.
2017 (LocalInfo): Implement it.
2018 (ToplevelParameterInfo): New class.
2019 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
2020 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
2021 GetKnownVariableInfo.
2023 2007-06-03 Raja R Harinath <harinath@gmail.com>
2025 Partly speed up CS0136 error checks.
2026 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
2027 'recurse' parameter.
2028 (Block.DoCheckError136): Only check errors in parameters. Move
2029 local variable checks ...
2030 (Block.AddVariable): ... here, and ...
2031 (ToplevelBlock.ResolveMeta): ... here.
2033 2007-06-02 Raja R Harinath <harinath@gmail.com>
2035 * statement.cs (Block.IsChildOf): Remove.
2037 * statement.cs (Statement.Clone): Move special case code ...
2038 (Block.CloneTo): ... here.
2040 2007-05-29 Raja R Harinath <rharinath@novell.com>
2042 * statement.cs (ToplevelBlock.container): Remove field. It's
2043 redundant with 'Parent'.
2044 (ToplevelBlock.ContainerBlock): Remove accessor.
2045 (ToplevelBlock..ctor): Update to changes. Register anonymous
2046 child with parent here, ...
2047 * cs-parser.jay (end_anonymous): ... not here. Don't modify
2049 (start_anonymous): Don't save current_block.
2050 (top_current_block): Remove.
2052 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
2053 (Block.Resolve): Update to changes.
2054 (Block..ctor): Move setting of "correct" 'Toplevel'
2055 and 'Explicit' fields to ...
2056 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
2058 2007-05-27 Raja R Harinath <harinath@gmail.com>
2061 * statement.cs (Block.Implicit): Remove.
2062 (Block): Update to changes.
2063 * flowanalysis.cs: Likewise.
2065 Mildly speed up CheckInvariantMeaningInBlock
2066 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
2067 Recursively call AddKnownVariable to all enclosing blocks.
2068 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
2069 Remove recursive calls.
2070 (Block): Update to changes.
2072 New ExplicitBlock invariants
2073 * statement.cs (Block.Explicit): New field. It points to the
2074 immediately enclosing non-implicit block.
2075 (Block..ctor): Maintain the invariant.
2076 * cs-parser.jay: Take advantage of invariant.
2078 Introduce ExplicitBlock
2079 * statement.cs (ExplicitBlock): New.
2080 (ToplevelBlock): Derive from it.
2081 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
2083 (Block.Implicit): Update to changes.
2084 * cs-parser.jay: Update to changes.
2087 * codegen.cs (EmitContext.IsLastStatement): Remove.
2088 * statement.cs (Block.DoEmit): Update to changes.
2090 2007-05-25 Raja R Harinath <rharinath@novell.com>
2092 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
2093 modifying current_block directly.
2095 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
2097 * class.cs: Implemented automatic properties (C# 3.0)
2098 Thanks to Marek for the help.
2100 2007-05-23 Raja R Harinath <rharinath@novell.com>
2102 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
2103 variable as assigned, note also that all its components are
2105 (MyBitVector.SetRange): New. Function to set multiple bits to true.
2107 2007-05-19 Marek Safar <marek.safar@gmail.com>
2109 * anonymous.cs, class.cs: Emit Compiler generated attribute when
2110 member is marked as compiler generated.
2112 * decl.cs (MemberCore): Refactored ModFlags into property.
2114 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
2115 (Check): Check only accessibility modifiers.
2117 2007-05-18 Raja R Harinath <rharinath@novell.com>
2119 Track all assignable slots in one bit array
2120 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
2121 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
2122 logic from VariableMap constructor here. Use the same 'offset'
2123 variable that's later used for computing offsets of local
2125 * flowanalysis.cs (UsageVector.parameters): Remove.
2126 (UsageVector): Update to changes.
2127 (VariableMap): Remove.
2129 Avoid creating ParameterMap in every block
2130 * statement.cs (Block.ParameterMap): Move ...
2131 (ToplevelBlock.ParameterMap): ... here.
2132 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
2134 * flowanalysis.cs (FlowBranching.param_map): Remove.
2135 (FlowBranching.UsageVector): Update to changes.
2136 (FlowBranchingToplevel.CheckOutParameters): Likewise.
2138 * statement.cs (Block.CloneTo): Clone Toplevel field too.
2140 * expression.cs (ParameterReference): Distinguish between block
2141 where parameter was referenced and declared.
2143 2007-05-18 Marek Safar <marek.safar@gmail.com>
2145 * flowanalysis.cs, statement.cs: Put back improved error handling.
2147 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
2151 Imporved object and collection initialization (C# 3.0).
2153 2007-05-15 Marek Safar <marek.safar@gmail.com>
2155 A fix for bug #81380
2156 * expression.cs (Is.DoResolve): Only value types have constant `is'
2159 2007-05-15 Raja R Harinath <rharinath@novell.com>
2161 * statement.cs (ToplevelBlock.child): Remove.
2163 2007-05-15 Raja R Harinath <harinath@gmail.com>
2165 Rationalize ResolveMeta: refactoring
2166 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2167 out constant handling code into ...
2168 (Block.DoResolveConstants): ... this.
2170 Rationalize ResolveMeta: kill local_map
2171 * statement.cs (Block.local_map, Block.LocalMap): Remove.
2172 (Block.AssignableSlots): New.
2173 (Block.ResolveMeta): Make protected. Don't create a VariableMap
2174 for locals -- move code from VariableMap here. Avoid unnecessary
2176 * flowanalysis.cs (FlowBranching.local_map): Remove.
2177 (FlowBranching..ctor): Use Block.AssignableSlots.
2178 (VariableMap): Remove unused constructors.
2180 2007-05-11 Raja R Harinath <rharinath@novell.com>
2182 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
2184 2007-05-11 Marek Safar <marek.safar@gmail.com>
2186 * typemanager.cs (IsFriendAssembly): Should not be called for building
2189 2007-05-09 Marek Safar <marek.safar@gmail.com>
2191 * literal.cs (NullConstant): Print null in all cases.
2193 * expression.cs (Binary.ResolveOperator): Implemented delegate
2194 comparison based on C# 2.0 changes.
2196 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
2198 This code is contributed under the MIT X11 license
2200 The following enables support for several C# 3.0 language features:
2202 * cs-tokenizer.cs: Added support for the "var" keyword.
2204 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
2205 Added VarExpr class to facilitate type inferencing.
2207 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
2208 to support anonymous types.
2210 * assign.cs: Added support for type inferencing and initialization.
2212 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
2214 * expression.cs: Added implicit array support to ArrayCreation.
2215 Added 5 types and 1 interface:
2217 IInitializable Implementing classes can inject initializing
2218 statements after object instantiation.
2220 Initializer Stores data for object initialization.
2222 AnonymousType An expression for anonymous types.
2224 AnonymousTypeParameter Stores data about an anonymous type's field.
2226 NewInitialize An expression for object initialization.
2228 CollectionInitialize An expression for collection initialization.
2230 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
2233 2007-05-06 Marek Safar <marek.safar@gmail.com>
2235 A fix for bug #81500
2236 * cs-tokenizer.cs: Add special handling for coalescing operator.
2238 2007-05-06 Marek Safar <marek.safar@gmail.com>
2240 A fix for bug #81529
2241 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
2242 its value from base class until it is redefined.
2244 2007-05-02 Raja R Harinath <rharinath@novell.com>
2246 Fix regression in cs0631-3.cs
2247 * cs-parser.jay (operator_declarator): Add opt_attributes to error
2248 fallback. Make error fallback catch more cases.
2250 2007-05-01 Miguel de Icaza <miguel@novell.com>
2252 * cs-parser.jay: Allow parameters in operator declarations to have
2255 2007-04-27 Miguel de Icaza <miguel@novell.com>
2257 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
2260 * lambda.cs (ContextualReturn.Resolve): An expression is valid
2261 inside the ContextualReturn, it does not have to be an
2262 ExpressionStatement.
2264 2007-04-24 Miguel de Icaza <miguel@novell.com>
2266 * lambda.cs (ContextualReturn.Resolve): if the return type is not
2269 2007-04-23 Miguel de Icaza <miguel@novell.com>
2271 * anonymous.cs (AnonymousContainer): split the virtual Resolve
2272 method in two methods: ResolveNoDefine and Resolve.
2274 ResolveNoDefine will stop just after ResolveTopBlock has been
2277 Resolve will then continue by creating a method and issuing the
2278 call to method.Define ().
2280 (AnonymousMethod): Split and implement the new Resolve and
2281 ResolveNoDefine as well.
2283 * lambda.cs (LambdaExpression): Split the anonymous method
2284 resolution code into a separate routine (CoreCompatibilityTest)
2285 from DoCompatibleTest.
2287 (LambdaExpression.TryBuild): New method, this method tries to
2288 build the LambdaExpression with the given set of types to be used
2289 as the types for the various parameters of the lambda expression.
2291 If the compilation succeed with the given types, the infered type
2292 of the Anonymous method is returned, otherwise null is returned.
2294 2007-04-23 Marek Safar <marek.safar@gmail.com>
2296 A fix for bug #81414
2297 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
2299 2007-04-22 Miguel de Icaza <miguel@novell.com>
2301 * cs-tokenizer.cs: Change various identifiers here from the
2302 camelCasing to the recommended Linux-like style for instance
2303 variables from the Coding Guidelines.
2305 2007-04-19 Martin Baulig <martin@ximian.com>
2308 (Convert.ImplicitReferenceConversionCore): Allow conversions from
2309 System.Enum to System.ValueType.
2311 2007-04-13 Martin Baulig <martin@ximian.com>
2313 Rewrote implicit reference conversions. We need to distinguish
2314 between implicit reference conversions (13.1.4) and implicit
2315 boxing conversions (13.1.5).
2317 According to the spec, there's an an implicit conversion
2318 "From a one-dimensional array-type S[] to IList<T> and base
2319 interfaces of this interface, provided there is an implicit
2320 reference conversion from S to T." Note that this does not
2321 include boxing conversions.
2324 (Convert.ImplicitTypeParameterBoxingConversion): New method.
2325 (Convert.ImplicitReferenceConversion): Split into
2326 ImplicitReferenceConversionCore() and
2327 ImplicitBoxingConversionExist().
2328 (Convert.ImplicitReferenceConversionExists): Use the new
2329 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
2331 2007-04-12 Martin Baulig <martin@ximian.com>
2333 * convert.cs (Convert.ImplicitReferenceConversion): Move the
2334 `TypeManager.null_type' checks up to the top of the method.
2336 2007-04-11 Marek Safar <marek.safar@gmail.com>
2338 A fix for bug #81350
2339 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
2342 2007-04-11 Martin Baulig <martin@ximian.com>
2344 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
2345 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
2346 to make this work for generic classes; fixes #79561.
2348 2007-04-11 Martin Baulig <martin@ximian.com>
2350 * expression.cs (As): Add support for nullable types; fixes #79371.
2352 2007-04-11 Martin Baulig <martin@ximian.com>
2354 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
2355 `type.FullName' is null; fixes #80243.
2357 2007-04-11 Martin Baulig <martin@ximian.com>
2359 * expression.cs (Invocation.IsApplicable): Don't modify the method
2360 if type inference succeeded, but the method was not applicable.
2363 2007-04-10 Marek Safar <marek.safar@gmail.com>
2365 A fix for bug #81324
2366 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
2367 internal and external namespaces containers.
2369 2007-04-10 Martin Baulig <martin@ximian.com>
2371 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
2372 TypeManager.DropGenericMethodArguments() so we also call
2373 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
2375 2007-04-10 Martin Baulig <martin@ximian.com>
2377 * iterators.cs (Iterator.CreateIterator): Don't crash if
2378 `method.ReturnType' is null. This happens if something went wrong
2379 while resolving that typ (we already reported an error in this case).
2381 2007-04-10 Martin Baulig <martin@ximian.com>
2383 * expression.cs (New.DoResolve): Don't call CheckComImport() on
2384 generic interfaces; report the CS0144 directly.
2386 2007-04-10 Martin Baulig <martin@ximian.com>
2388 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
2389 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
2391 2007-04-10 Martin Baulig <martin@ximian.com>
2393 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
2395 2007-04-09 Raja R Harinath <rharinath@novell.com>
2398 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
2399 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
2402 * statement.cs (For.Resolve): If resolution fails, use
2405 2007-04-08 Marek Safar <marek.safar@gmail.com>
2407 * anonymous.cs (MakeName): Make faster and zero-based.
2408 (VerifyExplicitParameterCompatibility): Back to mode where generic
2409 parameter is ignored.
2410 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
2412 * class.cs (EmitType): Method can emit another new method.
2414 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
2416 * driver.cs: Updated.
2418 * lambda.cs: Reuse predefined empty parameters.
2420 * parameter.cs: Updated
2422 * support.cs: Implemented InflateTypes.
2424 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
2425 (InitSystemCore): Introduced to isolate 3.0 dependencies.
2427 2007-04-03 Martin Baulig <martin@ximian.com>
2431 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
2432 version of TypeManager.IsOverride() which also works with generic
2435 2007-04-03 Martin Baulig <martin@ximian.com>
2440 (Convert.ExplicitReferenceConversion): We need to cast when
2441 converting from IList<T> to S[].
2443 2007-04-01 Marek Safar <marek.safar@gmail.com>
2445 * decl.cs (FindExtensionMethods): Consider all candidates with same name
2448 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
2450 2007-03-31 Marek Safar <marek.safar@gmail.com>
2452 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
2453 argument and return type inferring.
2455 * codegen.cs (InferReturnType): Flag whether return can be inferred.
2456 (ReturnType): Turned to property.
2458 * statement.cs (Return): Implemented return type inferring.
2460 * support.cs (ReflectionParameters): Use local types if possible.
2462 2007-03-30 Raja R Harinath <rharinath@novell.com>
2464 * flowanalysis.cs (FlowBranching.Reachability): Remove.
2465 (FlowBranching.UsageVector): Update to changes.
2467 Prepare to kill 'Reachability'
2468 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
2469 argument of constructor.
2471 2007-03-29 Raja R Harinath <rharinath@novell.com>
2473 Prepare to kill 'Reachability'
2474 * flowanalysis.cs (UsageVector.is_unreachable): New.
2475 (UsageVector): Update to maintain 'is_unreachable' in parallel to
2476 'reachability', and verify they're consistent.
2479 * expression.cs (New.EmitStatement): Handle type parameters here too.
2481 2007-03-29 Martin Baulig <martin@ximian.com>
2486 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
2487 CompilerGeneratedClass.
2488 (ScopeInfo.EmitScopeInstance): Make this protected.
2489 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
2490 `ec.CurrentAnonymousMethod.Scope == Scope'.
2492 * statement.cs (Block.ScopeInfo): Make this a property.
2494 2007-03-27 Raja R Harinath <harinath@gmail.com>
2496 Prepare to kill 'Reachability'
2497 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
2498 (FlowBranching.UsageVector.Reachability): Remove property.
2499 (FlowBranching.UsageVector.IsUnreachable): New property.
2500 (FlowBranching.UsageVector.ResetBarrier): New.
2501 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
2502 * codegen.cs, statement.cs: Update to changes.
2504 2007-03-27 Martin Baulig <martin@ximian.com>
2509 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
2512 2007-03-26 Raja R Harinath <rharinath@novell.com>
2514 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
2515 instead of TriState. Remove all mention of TriState.
2517 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
2518 replaced by a boolean. Add boolean 'is_unreachable' field, check
2519 and maintain invariants.
2521 2007-03-25 Marek Safar <marek.safar@gmail.com>
2523 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
2525 2007-03-25 Marek Safar <marek.safar@gmail.com>
2527 * expression.cs: Stop using obsolete 2.0 opcodes.
2529 2007-03-25 Marek Safar <marek.safar@gmail.com>
2531 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
2532 one of the latests Martin's fixes.
2534 2007-03-23 Miguel de Icaza <miguel@novell.com>
2536 * expression.cs: On BigEndian systems, swap the bytes, temporary
2537 solution until we get a new bitconverter class.
2539 2007-03-23 Martin Baulig <martin@ximian.com>
2543 * decl.cs (MemberCache.AddMembers): Add generic methods both as
2544 "Method" and "Method`1". Normally, a cache lookup is done on the
2545 "Method" form (ie. without the generic arity), but this one makes
2546 lookups on the full form work as well.
2548 2007-03-22 Raja R Harinath <rharinath@novell.com>
2550 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
2553 2007-03-20 Bill Holmes <billholmes54@gmail.com>
2555 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
2556 ordered_member_list, to TypeBuilder to store members to be defined
2557 in the order they were parsed in.
2558 - ordered_explicit_member_list contains all properties indexers
2559 and methods that are defined as explicit implementation of an
2560 interface or base class.
2561 - ordered_member_list contains all properties indexers and methods
2562 that are not defined as explicit implementation of an interface
2565 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
2566 functionality in these removed classes has been replaced with
2567 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
2568 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
2570 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
2571 to CheckForDuplications inside GetMethod and SetMethod Define Method
2572 to handle method property and indexer name conflicts.
2576 All code is contributed under the MIT/X11 license.
2578 2007-03-20 Martin Baulig <martin@ximian.com>
2580 * class.cs (TypeContainer.Interfaces): Removed; they're now
2581 included in `TypeContainer.Types'.
2583 2007-03-20 Martin Baulig <martin@ximian.com>
2585 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
2587 * class.cs (TypeContainer.CreateType): New public method. This is
2588 now called before DefineType() to create the TypeBuilders.
2589 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
2590 has already been created by CreateType().
2591 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
2592 don't resolve our base classes here; this has been moved into
2593 DefineBaseTypes(). We're now called from CreateType().
2594 (TypeContainer.DefineBaseTypes): New private method; resolve our
2595 base classes here. We're now called from DefineType().
2598 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
2599 our types first to create all the TypeBuilders. After that, call
2600 TypeContainer.DefineType() on all the types which'll resolve their
2601 base classes and setup the resolve order.
2603 2007-03-20 Martin Baulig <martin@ximian.com>
2605 * class.cs (TypeContainer.Enums): Removed; they're now included in
2606 `TypeContainer.Types'.
2608 2007-03-20 Martin Baulig <martin@ximian.com>
2611 (TypeContainer.DefineType): Don't call ResolveMembers() here.
2612 (TypeContainer.DoResolveMembers): Call DefineType() on our
2613 `compiler_generated' classes; moved here from DefineNestedTypes().
2616 (RootContext.ResolveTree): Call ResolveMembers() on all
2617 TypeContainer's in the `type_container_resolve_order'.
2619 2007-03-19 Marek Safar <marek.safar@gmail.com>
2621 * class.cs: Use corlib to handle InternalMethodImplAttribute.
2623 2007-03-17 Marek Safar <marek.safar@gmail.com>
2625 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
2626 implementation flags.
2628 2007-03-17 Marek Safar <marek.safar@gmail.com>
2630 * class.cs: More optimizations for type parameters.
2632 2007-03-15 Marek Safar <marek.safar@gmail.com>
2634 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
2636 * ecore.cs, parameter.cs: More common code for both corlibs.
2638 * typemanager.cs (IsGenericMethod): Simplified.
2640 2007-03-15 Raja R Harinath <rharinath@novell.com>
2642 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2644 * statement.cs, iterators.cs, lambda.cs: Update to changes.
2646 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
2647 unconditionally. Simplify explanation.
2648 (Try.Resolve, Using.Resolve): Likewise.
2650 2007-03-15 Martin Baulig <martin@ximian.com>
2654 * decl.cs (DeclSpace): If we're a partial class, use our
2655 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
2657 2007-03-15 Raja R Harinath <rharinath@novell.com>
2659 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2661 (FlowBranching.UsageVector): Update to changes.
2662 (FlowBranching.MergeSiblings): Likewise.
2663 * statement.cs: Likewise.
2665 2007-03-15 Martin Baulig <martin@ximian.com>
2670 (MemberCache): Added a special .ctor for type parameters.
2673 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
2676 2007-03-09 Martin Baulig <martin@ximian.com>
2678 * enum.cs (Enum): Make this a TypeContainer.
2679 (EnumMember): Derive from `Const'.
2682 (Const.DoResolveValue): New protected virtual method; move most of
2683 the functionality of ResolveValue() here so we can override it in
2685 (Const.CreateConstantReference): Make this virtual.
2687 * class.cs (Kind): Add `Kind.Enum'.
2688 (TypeContainer.Emit): Don't emit the enums here; they're already
2689 in the `RootContext.typecontainer_resolve_order'.
2691 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
2692 here; they're already in the `typecontainer_resolve_order'.
2694 * ecore.cs (EnumConstant.ConvertImplicitly): Add
2695 TypeManager.DropGenericTypeArguments().
2698 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
2699 (TypeManager.IsEnumType): Likewise.
2700 (TypeManager.EnumToUnderlying): Likewise.
2701 (TypeManager.IsEqual): Add support for enums.
2703 2007-03-12 Raja R Harinath <rharinath@novell.com>
2705 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
2706 DefaultParameterValueAttribute to be undefined, say if System.dll
2709 2007-03-11 Marek Safar <marek.safar@gmail.com>
2711 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
2714 2007-03-10 Marek Safar <marek.safar@gmail.com>
2716 * class.cs, parameter.cs: Unified parameters verification.
2718 2007-03-08 Martin Baulig <martin@ximian.com>
2720 * cs-parser.jay (constructor_header): Pass the location to the
2721 newly created TopLevelBlock.
2723 2007-03-07 Martin Baulig <martin@ximian.com>
2725 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
2727 2007-03-06 Miguel de Icaza <miguel@novell.com>
2729 * convert.cs (ExplicitReferenceConversionExists): Sync this method
2730 with the changes from David, fixes the build.
2732 2007-03-05 David Mitchell <dmitchell@logos.com>
2734 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
2735 and its base interfaces to a one-dimensional array type S[],
2736 provided there is an implicit or explicit reference conversion
2739 2007-03-03 Marek Safar <marek.safar@gmail.com>
2741 * cs-tokenizer.cs: Implemented basic linq grammar.
2743 * driver.cs: Set linq lang version on demand.
2745 2007-02-26 Marek Safar <marek.safar@gmail.com>
2747 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
2749 2007-02-25 Marek Safar <marek.safar@gmail.com>
2751 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
2754 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
2756 Check property and event extern attributes.
2758 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
2761 2007-02-24 Marek Safar <marek.safar@gmail.com>
2763 A fix for bug #80407
2764 * ecore.cs: Don't report ambiguity error when methods have same parent.
2766 2007-02-23 Marek Safar <marek.safar@gmail.com>
2768 A fix for bug #80878
2769 * class.cs, cs-parser.jay: Event property can host anonymous methods.
2771 2007-02-22 Marek Safar <marek.safar@gmail.com>
2773 * attribute.cs: Enable ExtensionAttribute presence test.
2775 2007-02-22 Marek Safar <marek.safar@gmail.com>
2777 * class.cs: Warn about missing GetHashCode only when Equals is override.
2779 * decl.cs: Check accessibility of type arguments.
2781 * typemanager.cs: Correctly report nullable array.
2783 2007-02-20 Marek Safar <marek.safar@gmail.com>
2785 * class.cs, report.cs: Capture more details when things go wrong.
2787 2007-02-20 Marek Safar <marek.safar@gmail.com>
2789 A fix for bug #80650
2790 * cs-parser.jay: Anonymous container starts at constructor declaration
2791 and not at block beginning because it has to be usable in constructor
2794 * statement.cs: Use context location and not block one for error reporting.
2796 2007-02-18 Marek Safar <marek.safar@gmail.com>
2798 A fix for bug #78712
2799 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
2802 2007-02-18 Marek Safar <marek.safar@gmail.com>
2804 A fix for bug #80493 by Atsushi Enomoto
2805 * cs-parser.jay: Ignore invalid attribute target.
2807 2007-02-18 Marek Safar <marek.safar@gmail.com>
2809 * cs-tokenizer.cs: Ignore '\0' as white space character.
2811 2007-02-17 Miguel de Icaza <miguel@novell.com>
2813 * cs-parser.jay: Add support for lambda expressions to the mcs
2816 * lambda.cs: Only clone when we are probing, not on the final call
2817 (Compatible is the final call).
2819 * statement.cs (CloneContext): Introduce class to provide block
2820 remapping during clone.
2822 All statements Clone themselves now.
2824 (Clone): special handling for blocks, when we clone a block, we
2825 register the block inside this routine, as children of the block
2826 might trigger a lookup.
2828 * expression.cs: Add support for CloneContext in all expressions.
2830 2007-02-17 Marek Safar <marek.safar@gmail.com>
2832 A fix for bug #80493
2833 * statement.cs: Report ambiguous warning when interfaces are not related.
2835 2007-02-15 Marek Safar <marek.safar@gmail.com>
2837 C# 3.0 extension methods.
2839 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
2840 cannot be used directly.
2842 * class.cs (Class.Emit): Emit extension attribute if any class method
2843 is extension method.
2844 (Method.Define): Add basic extension method validation conditions.
2845 (Method.Emit): Emit extension attribute for method.
2847 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
2848 extension method exists. Currently we follow same approach as Microsoft
2849 does, emit even if a method or a class are private but this can change
2852 * cs-parser.jay: Add handling of `this' keyword in method parameters
2855 * decl.cs (DeclSpace.IsStaticClass): New property.
2856 (MemberCache.FindExtensionMethods): Looks for extension methods with
2857 defined name and extension type.
2859 * doc.cs: Updated after OverloadResolve changes.
2861 * driver.cs: Add new soft reference to System.Core.dll.
2863 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
2864 (ExtensionMethodGroupExpr): Represents group of extension methods.
2866 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
2867 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
2868 to MethodGroupExpr and made non-static for easier customization.
2869 (Invocation.DoResolve): Add extension method lookup when no standard
2871 (MemberAccess.DoResolve): Try extension methods if no member exists.
2873 * modifiers.cs: Add METHOD_EXTENSION modifier.
2875 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
2876 as well as candidate extension type.
2877 (ComputeNamespaces): When assembly constains extension methods registers
2879 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
2880 extension method lookup.
2881 (Namespace.LookupExtensionMethod): Looks for extension method in this
2883 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
2884 find a method which matches name and extensionType.
2886 * parameter.cs (Parameter): Add This modifer.
2887 (HasExtensionMethodModifier): New property.
2888 (Resolve): Add extension parameter check.
2889 (ModFlags): turned to property to exclude this modifier as it is not real
2891 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
2893 * support.cs (ParameterData): Add ExtensionMethodType.
2894 (ReflectionParameters): Implemented ExtensionMethodType interface property.
2896 * typemanager.cs: Add type and ctor extension attribute type.
2898 2007-02-15 Miguel de Icaza <miguel@novell.com>
2900 * report.cs (DisableErrors, EnableErrors): used to prevent error
2901 output when we are "trying" to compile various methods with
2904 * ecore.cs (Expression): Add Clone method that calls the virtual
2905 CloneTo method. The current CloneTo method in Expression throws
2906 an exception so we can track down all the places where this must
2907 be implemented (not using abstract, because that would be a lot of
2908 up-front-work before we can start testing the implementation
2911 Important: we only need Clone capabilities for expressions created
2912 by the parser, as the expressions we will be cloning are
2913 expressions in the pre-resolved state. This vastly simplifies
2916 (SimpleName): Add CloneTo that does nothing.
2917 (EmptyCast): Add CloneTo.
2919 * expression.cs (Binary): Implement CloneTo.
2920 (Invocation.IsApplicable): Store the current ec in
2921 EmitContext.TempEc and restore it on return. This is used so we
2922 do not have to sprinkle hundres of methods with an extra
2923 EmitContext, we know that the only user is the lambda expression
2924 ImplicitConversionExists code.
2926 (Argument): Add Cloning capabilities.
2927 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
2928 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
2929 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
2930 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
2931 IndexerAccess): Add Clone capability.
2933 (LocalVariableReference, This): TODO: needs cloned Block mapping.
2935 (Argument): Add cloning capability.
2937 * assign.cs (Assign): Implement CloneTo.
2939 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
2941 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
2942 version by calling Convert with the EmitContext (that we are
2943 currently storing in ec, this is not great, but will do for now,
2944 to avoid passing EmitContext parameters to hundreds of functions
2945 that do not need them now).
2947 (SetExpression): Remove, it is not needed.
2949 (ContextualReturn): Implement CloneTo.
2951 * statement.cs (Statement): Implement cloning infrastructure,
2952 similar to expressions.
2954 (Block): Partial implementation of Clone for statements.
2956 (Return): Implement clone.
2958 * constant.cs (Constant.CloneTo): New method, does nothing.
2960 * codegen.cs (TempEc): Add a static EmitContext as a temporary
2961 solution, until we decide how to exactly do this.
2963 2007-02-14 Marek Safar <marek.safar@gmail.com>
2965 A fix for bug #80493
2966 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
2967 a property is override we need to use second accessor.
2969 2007-02-13 Marek Safar <marek.safar@gmail.com>
2971 A fix for bug #80418
2972 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
2975 2007-02-13 Marek Safar <marek.safar@gmail.com>
2977 Another fix for bug #80749
2978 * pending.cs: Abstract class has priority over interfaces.
2980 2007-02-13 Marek Safar <marek.safar@gmail.com>
2982 Another fix for bug #80749
2983 * pending.cs: Abstract class has priority over interfaces.
2985 2007-02-13 Marek Safar <marek.safar@gmail.com>
2987 Another fix for bug #80749
2988 * pending.cs: Abstract class has priority over interfaces.
2990 2007-02-13 Marek Safar <marek.safar@gmail.com>
2992 Another fix for bug #80749
2993 * pending.cs: Abstract class has priority over interfaces.
2995 2007-02-13 Marek Safar <marek.safar@gmail.com>
2997 * class.cs Better error message.
2999 * driver.cs: Add shorter versions of -optimize option.
3001 2007-02-13 Martin Baulig <martin@ximian.com>
3003 * class.cs (Constructor.Emit): Check the return value of
3004 ec.ResolveTopBlock() and return on error.
3006 2007-02-13 Raja R Harinath <rharinath@novell.com>
3008 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
3009 message to fix error message regression.
3011 2007-02-12 Marek Safar <marek.safar@gmail.com>
3013 * delegate.cs: Delegate creation expression cannot be of Nullable type.
3015 2007-02-12 Marek Safar <marek.safar@gmail.com>
3017 A fix for bug #80749
3018 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
3019 its parent container.
3021 * class.cs (DefineFieldInitializers): Each initializer can has different
3024 * const.cs: Updated.
3026 2007-02-11 Miguel de Icaza <miguel@novell.com>
3028 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
3029 now all the heavy lifting to check that embedded statements or
3030 expressions have the right form is done in the ContextualReturn.
3032 (ContextualReturn): New class.
3034 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
3035 method that can be invoked to report 201, so we do not replicate
3038 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
3040 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
3041 treating tabs as spaces.
3043 2007-02-09 Marek Safar <marek.safar@gmail.com>
3045 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
3046 * assign.cs: Use full implicit conversion for right side check.
3048 2007-02-09 Marek Safar <marek.safar@gmail.com>
3050 * statement.cs (Switch): Switch over boolean type is not standardized.
3052 2007-02-08 Marek Safar <marek.safar@gmail.com>
3054 A fix for bug #80755
3055 * decl.cs (FindBaseEvent): Don't use method cache for events.
3057 2007-02-07 Marek Safar <marek.safar@gmail.com>
3059 * cs-parser.jay: Better syntax error handling.
3061 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
3062 instead of underlying type value.
3064 2007-02-06 Marek Safar <marek.safar@gmail.com>
3066 * driver.cs: Check define identifier before is registered.
3068 * namespace.cs: Use existing error message.
3070 * report.cs: New warning.
3072 2007-02-06 Marek Safar <marek.safar@gmail.com>
3074 A fix for bug #80742
3075 * expression.cs: Delegate Invoke method can be called directly.
3077 2007-02-06 Marek Safar <marek.safar@gmail.com>
3079 A fix for bug #80676
3080 * class.cs (IsEntryPoint): The Main method can have params modifier.
3082 2007-02-04 Miguel de Icaza <miguel@novell.com>
3084 * parameter.cs (Parameter, Parameters): Add Clone method.
3086 * anonymous.cs (Compatible): Turn method into virtual method, so
3087 LambdaExpression can implement a different behavior.
3089 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
3090 out the basic checking here, so it can be used by
3093 * lambda.cs: Introduce "Compatible" function that will do the
3096 2007-02-02 Marek Safar <marek.safar@gmail.com>
3098 * attribute.cs: Unified one error message.
3100 * class.cs (Class): Use type attributes and not properties to test static
3102 (IsEntryPoint): Don's pass local variable.
3104 * convert.cs: Removed duplicate check.
3106 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
3108 * driver.cs: Don't crash when soft reference does not exist.
3110 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
3111 (UsingEntry): Removed redundant allocation.
3113 * parameter.cs: Add fast path for type parameters.
3115 * support.cs: Don't allocate attribute when it's not used.
3117 2007-01-30 Miguel de Icaza <miguel@novell.com>
3120 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
3121 this into a virtual method, so we can override it in LambdaExpression.
3123 * driver.cs: Improve diagnostics in case of failure.
3125 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
3126 write a function that is slightly more complex and that parses:
3128 type identifier [, type identifier]* )
3130 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
3133 (canEmpty ? i >= 0 : i > 0)
3135 2007-01-30 Raja R Harinath <rharinath@novell.com>
3137 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
3138 exception on possibly valid code.
3140 2007-01-29 Raja R Harinath <rharinath@novell.com>
3142 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
3144 (parse_opt_type_arguments): Remove. It's almost the same as
3146 (parse_namespace_or_typename): Use parse_less_than.
3148 2007-01-28 Miguel de Icaza <miguel@novell.com>
3150 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
3151 this bug took a few hours to find, because the state saved and
3152 restored by PushPosition and PopPosition was ignoring the state of
3153 parse_generic_less_than.
3155 I can also now remove the handling of OP_LT and OP_GT, this solves
3158 * cs-tokenizer.cs: store the location for the ARROW token, we use
3161 (PushPosition, PopPosition): save/restore also `current_token',
3162 restore `parse_generic_less_than' (was missing).
3164 (parse_opt_type_arguments): use parse_type, not
3165 parse_namespace_or_typename to parse types.
3167 * lambda.cs: Empty new file, will eventually have the lambda
3168 expression implementation.
3170 * lambda.test: used to test the internal tokenizer.
3172 * report.cs (FeatureIsNotISO1): Rename from
3173 FeatureIsNotStandardized, because it was about the language level
3174 (1 vs 2) it was not about standarization.
3176 (FeatureRequiresLINQ): New.
3178 * support.cs (SeekableStreamReader): Only require that the reader
3179 is a TextReader, not a StreamReader, so we can plug StringReader.
3181 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
3182 given position in the input stream the following tokens can be
3183 parsed as a type followed by an identifier.
3185 (is_punct): after a '(' if parse_type_and_parameter returns true,
3186 then return a special token OPEN_PARENS_LAMBDA which is used to
3187 avoid reduce/reduce errors in the grammar for the
3188 lambda_expression rules.
3190 (parse_type): implement a type parser inside the
3191 tokenizer, the parser only returns true or false depending on
3192 whether the input at a given position can be parsed as a type.
3194 (peek_token): new method used during type parsing.
3196 2007-01-28 Raja R Harinath <rharinath@novell.com>
3199 * anonymous.cs (ScopeInfo.InflateParameters): New.
3200 (AnonymousContainer.Resolve): Use it to redirect types of
3201 delegate parameters.
3203 2007-01-27 Raja R Harinath <rharinath@novell.com>
3206 * expression.cs (Error_InvalidArguments): Don't use two different
3207 messages for CS1503. Use ExtraInformation and
3208 SymbolRelatedToPreviousError instead.
3211 * decl.cs (DeclSpace.initialize_type_params): Don't access
3212 'type_params' of a partial class directly.
3214 2007-01-26 Miguel de Icaza <miguel@novell.com>
3216 * constant.cs: Removed a handful of out-of-range checks that were
3219 2007-01-25 Marek Safar <marek.safar@gmail.com>
3221 * expression.cs (CheckUselessComparison): Add additional check for char
3224 * namespace.cs: Fixed typo.
3226 2007-01-23 Miguel de Icaza <miguel@novell.com>
3228 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
3229 gone, instead we inline the test, preventing the needless casts to
3230 longs, ulongs and doubles for the parameters, avoiding calls to
3231 methods that overchecked stuff, and instead inlined things
3234 2007-01-20 Marek Safar <marek.safar@gmail.com>
3236 * cs-parser.jay: Better parameter error handling.
3238 2007-01-17 Marek Safar <marek.safar@gmail.com>
3240 A fix for bug #80368, #80522
3241 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
3242 whether array initializer contains constants only.
3243 (ArrayCreation.Emit): Use better formula to decide when
3244 are array initializers for static initialization.
3245 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
3246 have to emit even constants otherwise they are pre-initialized.
3248 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
3249 Raja R Harinath <rharinath@novell.com>
3251 Fix emit order of 'get' vs. 'set'.
3252 * support.cs (Accessors): New.
3253 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
3254 Note the order in which accessors are declared in the source.
3255 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
3256 Refactored from Property.Define and Indexer.Define.
3257 (PropertyBase.DefineAccessors): New helper that calls the above in
3258 appropriate order as noted by the parser.
3259 (Property.Define, Indexer.Define): Update to changes.
3260 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
3262 2007-01-17 Raja R Harinath <rharinath@novell.com>
3264 Fix cs0029-6.cs and gcs0029-2.cs (regression)
3265 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
3266 there's an implicit conversion from the current type to the target
3267 type before converting the underlying constant.
3269 2007-01-16 Marek Safar <marek.safar@gmail.com>
3271 * const.cs (ResolveValue): Updated after constant conversion was made more
3274 * constant.cs (GetAttributableValue): constant to object conversion is
3275 used for attributes only.
3276 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
3277 constant conversions.
3278 (LongConstant.ConvertImplicitly): Ditto.
3280 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
3281 (ImplicitConversionStandard): Handle constant conversion as extra step.
3282 It solves the issue when constant conversion was called indirectly like
3283 inside array initializer and constant folding was skipped.
3285 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
3288 * statement.cs(ImplicitConversionStandard): Updated after constant
3289 conversion was made more generic.
3291 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
3293 * expression.cs (As.DoResolve): Use GenericConstraints instead of
3294 Constraints, solves the problem where the compiler incorrectly
3295 reported that a type parameter was not constrained to a class (Bug
3298 2007-01-14 Marek Habersack <grendello@gmail.com>
3300 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
3302 2007-01-14 Marek Safar <marek.safar@gmail.com>
3304 A fix for bug #80368
3305 * assign.cs (FieldInitializer): New class implements field
3306 initializer statement.
3308 * attribute.cs: Update after FieldMember rename.
3310 * class.cs (PropertyBasedMember): New common class for property based
3312 (InterfaceMemberBase): New base class for all members which can be used as
3313 an interface members.
3314 (MethodCore): Moved really common code to InterfaceMemberBase.
3315 (Method.Define): Equal and GetHasCode detection is relevant for methods
3317 (MethodData.Define): Don't assume that public event implements an
3318 interface automatically.
3319 (MethodData.DefineMethodBuilder): Issue an error even if only extern
3321 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
3322 (FieldMember): Merged with FieldBase.
3323 (EventProperty.AEventPropertyAccessor): New specialization to check whether
3324 event extern modifier can be used.
3325 (EventField.EventFieldAccessor): Moved event field specific code here.
3326 (Event.AllowedModifiers): Even event can be extern.
3327 (Event.FindOutBaseMethod): New override specific to events.
3328 (Indexer.parameters): Reintroduce parameters because base class holds
3329 only properties common data.
3330 (Indexer.CheckForDuplications): Indexers are threated as methods so we
3331 need do extra parameters check.
3333 * const.cs: Update after FieldMember rename.
3335 * decl.cs (MemberCache.FindBaseEvent): New method.
3337 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
3338 to reflect that indexer is now derived from PropertyBased.
3340 * ecore.cs (GetMemberType): Made public.
3341 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
3344 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
3346 * typemanager.cs (CSharpSignature): Correctly print event accessors.
3347 (RegisterEvent): Removed.
3348 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
3349 (GetPrivateFieldOfEvent): Renamed to GetEventField.
3351 2007-01-11 Raja R Harinath <rharinath@novell.com>
3354 * statement.cs (CollectionForeach.TryType): Prefer generic
3355 GetEnumerator over non-generic variant. Fix code to follow comments.
3357 2007-01-09 Raja R Harinath <rharinath@novell.com>
3360 * support.cs (ReflectionParameter): Don't use an invalid index on
3361 the generic parameter data.
3363 2007-01-08 Miguel de Icaza <miguel@novell.com>
3365 * driver.cs: Just add a tiny bit of infrastructure.
3367 2007-01-02 Marek Safar <marek.safar@gmail.com>
3369 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
3370 where field type is struct from current assembly.
3372 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
3375 2007-01-02 Marek Safar <marek.safar@gmail.com>
3377 A fix for bug #80381
3378 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
3381 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
3383 (Namespace.LookupType): Always use core types from corlib when speficied.
3385 * report.cs: A new warning.
3387 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
3388 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
3389 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
3391 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
3392 (InitCoreTypes): Set expression type of object_type and value_type
3393 immediately after lookup.
3395 2007-01-01 Miguel de Icaza <miguel@novell.com>
3397 * cs-tokenizer.cs: Accept Pc class characters (Connector
3398 Punctuation) as valid identifiers. Fixes #78259
3400 * expression.cs (Invocation.DoResolve): Moved the check for the
3401 use of `this' for doing method calls to the Invocation resolution
3402 step, after overload resolution has taken place instead of doing
3403 the check at the low-level `This.DoResolve' level.
3405 The `This.DoResolve'(appens before overload resolution, so it has
3406 no way of knowing if the method that will be called will be
3407 instace or static, triggering an erroneous report for cs0188 (Bug
3410 We now do the check for instance method invocations after we know
3411 what method will be called.
3413 (This.CheckThisUsage): Move the actual use of this structure
3414 checking into its own method and expose it.
3416 * Everywhere that called Error_ValueCannotBeConverted: pass a new
3419 Exceptions: Null.ConvertImplicitly,
3420 Constant.ImplicitConversionRequired as there are too many call
3421 sites for passing the ec.
3423 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
3424 EmitContext, if the value is null, then we do not try to provide
3425 the extra information from the error (If a userdefined conversion
3426 exists, as UserDefinedConversion requires a non null-EmitContext).
3430 2006-12-30 Raja R Harinath <rharinath@novell.com>
3432 * flowanalysis.cs (MyBitVector): Document some invariants.
3433 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
3434 introduced below, and add a couple of others,
3436 2006-12-30 Marek Safar <marek.safar@gmail.com>
3438 * attribute.cs (GetMethodObsoleteAttribute): Uses new
3439 GetPropertyFromAccessor and GetEventFromAccessor.
3441 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
3442 overrides non-obsolete one.
3443 (Indexer.Define): Error message has been moved to the parser.
3445 * cs-parser.jay: Better syntax errors handling.
3447 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
3448 when an invocation has no arguments.
3450 * ecore.cs: Removed not used caching.
3452 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
3455 * report.cs: Add a new warning.
3457 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
3459 * typemanager.cs (enumeration_type): Removed.
3460 (CSharpSignature): Reuses IsSpecialMethod.
3461 (IsEqual): Hack for MS BCL.
3462 (GetPropertyFromAccessor): New method.
3463 (GetEventFromAccessor): New method.
3464 (IsSpecialMethod): Fixed to handle more cases.
3466 2006-12-30 Marek Safar <marek.safar@gmail.com>
3468 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
3469 Made white spaces array static.
3471 * ecore.cs (RemoveGenericArity): Optimized.
3473 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
3475 (MyBitVector.initialize_vector): Simplified.
3477 2006-12-22 Miguel de Icaza <miguel@novell.com>
3479 * ecore.cs: Am not entirely happy with this hack, but it seems to
3480 address the issue in 80257 (a small test case for
3483 I set the MethodGroupExpr.Type to an internal compiler type
3484 (itself in this case) to force the resolution to take place. Why
3485 it does not take place with a null is beyond me.
3487 2006-12-20 Marek Safar <marek.safar@gmail.com>
3489 A fix for bug #80288
3490 * expression.cs (ResolveOperator): Consider user defined conversion for
3491 logical and operator too.
3492 (EmitBranchable): Optimization for logical and when full constant folding
3493 could not be applied but one operand is constant.
3495 2006-12-19 Marek Safar <marek.safar@gmail.com>
3497 * class.cs (GetClassBases): Write 5 times every day, will never use
3498 FullName for error reporting.
3500 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
3502 2006-12-19 Martin Baulig <martin@ximian.com>
3504 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
3505 the symbol file info here.
3507 2006-12-18 Marek Safar <marek.safar@gmail.com>
3509 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
3510 of `elseif' is taking then following sections are not taking.
3511 Fixes an issue reported on mono mailing list.
3513 2006-12-18 Marek Safar <marek.safar@gmail.com>
3515 A fix for bug #80300
3516 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
3517 a caller is not taking.
3519 2006-12-18 Raja R Harinath <rharinath@novell.com>
3521 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
3522 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
3523 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
3524 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
3525 * class.cs: Update to changes.
3527 2006-12-17 Marek Safar <marek.safar@gmail.com>
3529 A fix for bug #79934
3530 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
3533 * class.cs (ResolveMembers): Register an iterator in current container and
3536 2006-12-16 Raja R Harinath <rharinath@novell.com>
3539 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
3540 satisfy a params annotated parameter.
3542 2006-12-16 Marek Safar <marek.safar@gmail.com>
3544 A fix for bug #77014
3545 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
3546 paramters correctly and not rely on hacks in Parameters class.
3547 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
3549 (Invocation.VerifyArgumentsCompat): Ditto.
3550 (Invocation.EmitArguments): Changed to correctly emit params arguments at
3553 * parameter.cs (HasParams): Don't assume that params is the last one.
3555 * support.cs (ReflectionParameters.ctor): Look for params attribute
3557 (ReflectionParameters.ParameterType): Removed hack when we returned last
3558 parameter for out of range parameters.
3559 (ParameterName, ParameterModifier): Ditto.
3561 2006-12-14 Marek Safar <marek.safar@gmail.com>
3563 A fix for bug #79987
3564 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
3565 when assembly is not CLS compliant but type is. I have no idea why is this
3568 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
3570 2006-12-13 Miguel de Icaza <miguel@novell.com>
3572 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
3573 in struct constructors, they are basically no-ops.
3575 2006-12-12 Marek Safar <marek.safar@gmail.com>
3577 * cs-tokenizer.cs (Position): Save preprocessor status too.
3579 2006-12-12 Marek Safar <marek.safar@gmail.com>
3581 A fix for bug #77794
3582 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
3584 2006-12-12 Marek Safar <marek.safar@gmail.com>
3586 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
3588 (pp_expr): Report error for an invalid expression.
3589 (handle_preprocessing_directive): Simplified; add more error checking.
3591 2006-12-11 Marek Safar <marek.safar@gmail.com>
3593 A fix for bug #74939
3594 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
3595 directives handling.
3597 2006-12-10 Marek Safar <marek.safar@gmail.com>
3599 A fix for bugs #80093, and #75984
3600 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
3601 logic, it seems to me as it worked before "by coincidence".
3602 (xtoken): Simplified to use reworked handle_preprocessing_directive.
3603 (cleanup): Enabled endif check.
3605 2006-12-09 Marek Safar <marek.safar@gmail.com>
3607 A fix for bug #80162
3608 * statement.cs (CollectionForeach.TryType): Generics and non-generics
3609 enumerators are never ambiguous.
3611 2006-12-08 Raja R Harinath <rharinath@novell.com>
3614 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
3616 2006-12-06 Marek Safar <marek.safar@gmail.com>
3618 A fix for bug #80144
3619 * class.cs (EventProperty.Define): Explicit implementation means
3620 that an even is used.
3622 2006-12-06 Marek Safar <marek.safar@gmail.com>
3624 Fixes the operators implementation (part II)
3626 * cfold.cs (DoConstantNumericPromotions): Renamed to
3627 DoBinaryNumericPromotions and simplified.
3628 (BinaryFold): Couple of conversion fixes; simplified.
3630 * constant.cs, ecore.cs, literal.cs
3631 (ToType): Renamed to ConvertImplicitly.
3632 (Reduce): Renamed to ConvertExplicitly.
3634 * class.cs, convert.cs: Updated.
3636 * expression.cs: TryReduce doesn't throw an exception.
3638 2006-12-01 Marek Safar <marek.safar@gmail.com>
3640 A fix for bug #80108
3641 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
3644 2006-11-30 Marek Safar <marek.safar@gmail.com>
3646 Fixes unary operators implementation (part I)
3649 * cfold.cs (Error_CompileTimeOverflow): Made internal
3651 * const.cs (IConstant): Changed to use reference to constant and
3652 not constant itself.
3653 Updated IConstant implementations.
3655 * constant.cs (CreateConstant): New factory method.
3656 Updated IConstant implementation.
3658 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
3660 * ecore.cs: Updated to use CreateConstantReference.
3662 * enum.cs: Reflects IConstant changes.
3664 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
3666 * literal.cs (NullConstant): Change to be independently usable.
3668 2006-11-29 Martin Baulig <martin@ximian.com>
3670 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
3671 we need to emit the scope initializer before calling the base .ctor.
3673 * anonymous.cs: Merged back from the new anonymous methods branch.
3674 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
3676 * expression.cs (ParameterReference.DoResolveBase): Create a
3677 "normal" ScopeInfo when capturing parameters rather than using the
3678 root scope; this makes things work with anonymous methods having
3682 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
3684 2006-11-22 Marek Safar <marek.safar@gmail.com>
3686 A fix for bug #79987
3687 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
3688 check to a base class.
3689 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
3690 only when assembly has missing attribute.
3691 * report.cs: Update.
3693 2006-11-21 Marek Safar <marek.safar@gmail.com>
3695 * cs-tokenizer.cs: Merged with gmcs version.
3697 2006-11-20 Marek Safar <marek.safar@gmail.com>
3700 * cs-parser.jay: Better error message when partial keyword is misplaced.
3702 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
3704 A fix for bug #79810
3705 report.cs: CS1058 only applies to 2.0 profile (gmcs).
3706 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
3707 a RuntimeWrappedException by default.
3709 2006-11-18 Marek Safar <marek.safar@gmail.com>
3711 A fix for bug #79843
3712 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
3714 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
3716 2006-11-18 Marek Safar <marek.safar@gmail.com>
3718 * driver.cs, namespace.cs: Uses faster IndexOf version.
3720 2006-11-17 Marek Safar <marek.safar@gmail.com>
3722 A fix for bug #79941
3723 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
3725 (Operator.Define): Implicit/Explicit operator of same type is duplicate
3726 even if internal name is different.
3727 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
3728 (UserDefinedConversion): Simplified as the operators cannot be internal.
3729 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
3731 (MethodLookup): Replaced EmitContext with parentType.
3732 * expression.cs: Updated.
3734 2006-11-09 Raja R Harinath <rharinath@novell.com>
3736 * driver.cs (BadAssembly): Handle all the ugliness of
3737 DefineDynamicAssembly.
3739 2006-11-08 Raja R Harinath <rharinath@novell.com>
3741 Address parts of #58244 -- most of what's left is in the runtime
3742 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
3743 CS1509 error checks, and handle them for all assembly loads, not
3744 just the first invocation.
3745 (LoadModule): Likewise. Move handling of 'adder_method' ...
3746 * codegen.cs (AssemblyClass.AddModule): ... here.
3748 2006-11-02 Marek Safar <marek.safar@gmail.com>
3750 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
3751 IEnumerable<T> is ambiguous.
3753 2006-10-31 Marek Safar <marek.safar@gmail.com>
3755 A fix for bug #67689
3756 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
3757 GetEnumerator is ambiguous.
3759 * report.cs: Add new warning.
3761 2006-10-29 Marek Safar <marek.safar@gmail.com>
3763 A fix for bug #78602
3764 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3765 to protected member can be nested type.
3767 2006-10-28 Marek Safar <marek.safar@gmail.com>
3769 A fix for bug #78965
3770 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3771 to protected member must derive from current type.
3773 2006-10-27 Marek Safar <marek.safar@gmail.com>
3775 assign.cs: Reuses error method.
3777 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
3778 instead of type for constants.
3779 (Expression.Error_ValueAssignment): Common error method.
3781 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
3784 2006-10-27 Marek Safar <marek.safar@gmail.com>
3786 A fix for bug #79081
3787 * expression.cs (MemberAccess.DoResolve): Check nested type
3790 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
3792 * doc.cs : nested delegates were not handled. Fixed bug #79754.
3794 2006-10-26 Marek Safar <marek.safar@gmail.com>
3796 A fix for bug #76591
3797 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
3799 2006-10-26 Marek Safar <marek.safar@gmail.com>
3801 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
3802 type forwarder of the same type multiple times.
3804 2006-10-26 Raja R Harinath <rharinath@novell.com>
3807 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
3808 instance as an rvalue, even when we later resolve as an lvalue.
3810 2006-10-25 Martin Baulig <martin@ximian.com>
3812 * anonymous.cs: Fix #79673.
3814 2006-10-24 Marek Safar <marek.safar@seznam.cz>
3816 A fix for bug #79666
3817 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
3818 ignored when is optimized (= default value) as its value is already set.
3820 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3822 A fix for bug #79724
3823 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
3824 TypeContainer for type lookup.
3826 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3828 A fix for bug #79231
3829 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
3830 * expression.cs (OverloadResolve): Always convert type name for
3832 (ResolveNamespaceOrType): Don't confuse a nested type with any
3835 2006-10-18 Martin Baulig <martin@ximian.com>
3837 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
3839 2006-10-17 Miguel de Icaza <miguel@novell.com>
3841 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
3842 an int32, but requesting an int64 from the conversion
3844 2006-10-12 Martin Baulig <martin@ximian.com>
3847 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
3849 2006-10-12 Martin Baulig <martin@ximian.com>
3852 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
3854 2006-10-11 Miguel de Icaza <miguel@novell.com>
3856 * convert.cs: Remove broken code: I was doing the "Existance"
3857 tests for Implicit conversions.
3859 2006-10-10 Miguel de Icaza <miguel@novell.com>
3861 * convert.cs: Added one missing case in
3862 ImplicitStandardConversionExists uint64 to intptr.
3866 * typemanager.cs (uintptr_type): another core known type.
3868 * ecore.cs (OperatorCast): routine used to do cast operations that
3869 depend on op_Explicit. We could change some of the Decimal
3870 conversions to use this.
3872 This one has a probe mechanism that checks both types for an op_
3873 which it coudl be used to eliminate two classes: CastToDecimal
3874 and CastFromDecimal.
3876 * convert.cs: Implement the conversions documented in #59800
3878 2006-10-10 Martin Baulig <martin@ximian.com>
3880 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
3881 before RootScope.ResolveMembers().
3883 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
3884 `CurrentType' if appropriate.
3886 2006-10-09 Marek Safar <marek.safar@seznam.cz>
3888 A fix for bug #78568
3889 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
3890 when contains binary operators.
3891 * cs-parser.jay: Updated.
3893 2006-10-09 Martin Baulig <martin@ximian.com>
3896 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
3897 moved that into Define() and also do the other type parameter
3898 checks there. Fixes #79094. Added gtest-292.cs.
3901 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
3902 since that doesn't include type parameters; don't use `Ldelema'
3903 for type parameters. Fixes #78980. Added gtest-293.cs.
3905 2006-10-08 Marek Safar <marek.safar@seznam.cz>
3908 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
3909 conversion is allowed.
3911 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3913 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
3914 error reporting when no error occurs.
3916 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3918 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
3921 2006-10-06 Raja R Harinath <rharinath@novell.com>
3924 * class.cs (DefineTypeBuilder): Check circular dependencies before
3925 setting the parent of the TypeBuilder.
3926 (CheckRecursiveDefinition): Don't use 'BaseType', since
3927 it may not be valid until after DefineTypeBuilder. Use
3928 'base_type' instead.
3930 2006-10-04 Martin Baulig <martin@ximian.com>
3932 Merged the Anonymous Methods patch.
3934 * anonymous.cs, iterators.cs: The new anonymous methods code.
3936 * statement.cs (Variable): New public abstract class.
3937 (LocalInfo.Variable): New public property.
3938 (LocalInfo.ResolveVariable): New public method.
3939 (Block.Flags): Add `IsIterator'.
3940 (Block.AddVariable): Improved the CS0136 check.
3941 (Block.AnonymousChildren): New public property.
3942 (Block.AddAnonymousChild): New public method.
3943 (ToplevelBlock): Update to use the new anonymous method framework.
3944 (ToplevelBlock.ctor): `container' is now a `Block' and not a
3945 `ToplevelBlock'; this is required to correctly implement the
3947 (Fixed, Using): Use `TemporaryVariable' instead of directly
3948 creating the `LocalBuilder'.
3950 * parameter.cs (Parameter.ResolveVariable): New public method.
3951 (Parameters.ResolveVariable): Likewise.
3953 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
3955 * class.cs (TypeContainer): Replaced the `iterators' list and
3956 corresponding methods with a list of `CompilerGeneratedClass'es.
3957 (TypeContainer.ResolveMembers): New public method.
3958 (Method): `IIteratorContainer' has been replaced by
3961 * expression.cs (VariableReference): New public abstract base
3962 class for `LocalVariableReference', `ParameterReference' and
3965 * codegen.cs (EmitContext): Removed `capture_context',
3966 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
3967 (EmitContext.EmitThis): Removed.
3969 * cs-parser.jay: Replace `iterator_container' with
3972 2006-10-04 Martin Baulig <martin@ximian.com>
3974 * generic.cs (GenericMethod): Don't make this abstract.
3975 (Constraints.Clone): Added dummy implementation.
3977 2006-10-04 Raja R Harinath <harinath@gmail.com>
3980 * namespace.cs (LookForAnyGenericType): Avoid nullref on
3981 'declspaces'. Avoid allocating arrays willy-nilly.
3984 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
3985 cases out of the switch.
3987 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3989 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
3990 message when non-generic type is used with the type arguments.
3991 * expression.cs: Updated.
3993 2006-09-28 Raja R Harinath <rharinath@novell.com>
3996 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
3997 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
3998 Change semantics slightly. Don't insist on having only one
3999 temporary EmptyExpression -- just throttle the creation of new ones.
4002 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
4003 non-interfaces too. If no methods are found, don't try to create
4006 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4008 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
4011 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
4012 us produce better error message.
4014 2006-09-27 Marek Safar <marek.safar@seznam.cz>
4016 * expression.cs (Binary.ResolveOperator): Warn about a side effect
4017 of the `|' operator.
4019 * report.cs: A new warning added.
4021 2006-09-27 Martin Baulig <martin@ximian.com>
4023 * generic.cs (GenericMethod): Don't make this abstract.
4025 2006-09-27 Martin Baulig <martin@ximian.com>
4028 (InternalErrorException): Added overloaded ctor taking a params array.
4030 2006-09-26 Marek Safar <marek.safar@seznam.cz>
4032 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
4033 Fixed the cases when same error was reported twice.
4035 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
4036 now report symbol information.
4038 2006-09-25 Martin Baulig <martin@ximian.com>
4040 * class.cs: Completely unified with the gmcs version.
4042 2006-09-25 Martin Baulig <martin@ximian.com>
4044 * typemanager.cs (TypeManager.IsNullableType): New public function.
4045 (TypeManager.IsNullableTypeOf): Likewise.
4046 (TypeManager.IsNullableValueType): Likewise.
4048 * class.cs (MethodCore): Added the `GenericMethod' argument from
4049 gmcs and also unified all classes derived from `MethodCore' with gmcs.
4051 2006-09-24 Raja R Harinath <harinath@gmail.com>
4053 * convert.cs: Unify with gmcs version.
4055 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4057 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
4058 verify them as well.
4060 * report.cs: New warning.
4062 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4064 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
4065 for anonymous block with out argument.
4067 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4069 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
4070 not used private events only.
4072 2006-09-23 Marek Safar <marek.safar@seznam.cz>
4074 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
4076 * const.cs (Const.Define): Check for constant type.
4077 (Const.IsConstantTypeValid): Looks for valid constant types.
4079 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
4081 * ecore.cs (EmptyConstantCast): New common class for all constant based
4084 * expression.cs (Is.DoResolve): Handle null constant especially.
4085 (New.DoResolve): Check for new void().
4086 (MemberAccess.DoResolve): Cope with all kind of nulls.
4088 * literal.cs (NullConstant): Uses EmptyConstantCast.
4089 (NullDefault): Based on EmptyConstantCast.
4090 (NullLiteral): Uses EmptyConstantCast.
4092 * statement.cs (Block.ResolveMeta): Check for constant type.
4094 2006-09-22 Martin Baulig <martin@ximian.com>
4096 * delegate.cs, attribute.cs: Merged with the gmcs versions.
4098 2006-09-22 Raja R Harinath <rharinath@novell.com>
4100 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
4104 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
4105 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
4108 2006-09-22 Martin Baulig <martin@ximian.com>
4110 * ecore.cs: Merged with the gmcs version.
4112 * generic.cs (ConstructedType): New dummy class.
4113 (TypeArguments): Don't make this abstract.
4116 (TypeManager.IsGenericTypeDefinition): New method.
4117 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
4119 2006-09-22 Raja R Harinath <rharinath@novell.com>
4121 * expression.cs (ComposedCast): Check for arrays of TypedReference
4122 before creating the type, not after.
4124 2006-09-21 Marek Safar <marek.safar@seznam.cz>
4126 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
4127 after ToType change.
4129 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
4130 when constant must be implicitly convertible.
4132 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
4134 * ecore.cs (NullCast): Derives from NullConstant.
4136 * expression.cs (Is.DoResolve): Removed useless variables.
4137 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
4138 (New.Constantify): Add enum support.
4139 (MemberAccess.DoResolve): Add warning when accessing null constant or
4142 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
4145 * literal.cs (NullConstant): New abstract class with common
4146 functionality for all null specializations.
4147 (NullDefault): Represents default(X) when result can be
4149 (NullLiteral): Updated.
4151 * report.cs: Add new warning.
4153 2006-09-21 Martin Baulig <martin@ximian.com>
4155 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
4157 2006-09-21 Martin Baulig <martin@ximian.com>
4159 * generic.cs (GenericConstraints): New dummy class.
4160 (Constraints): Likewise.
4161 (TypeParameter): Likewise.
4162 (TypeParameterName): Likewise.
4163 (GenericMethod): Likewise.
4165 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4167 * decl.cs: Merged with the gmcs version.
4169 2006-09-21 Raja R Harinath <rharinath@novell.com>
4171 * generic.cs (TypeParameter): Implement IMemberContainer.
4172 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
4174 * rootcontext.cs: Unify with gmcs version.
4176 * report.cs: Unify with gmcs version.
4177 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
4178 from gmcs/generics.cs.
4179 * generics.cs (TypeParameter): New dummy class.
4181 * support.cs: Unify with gmcs version.
4183 2006-09-20 Raja R Harinath <rharinath@novell.com>
4185 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
4186 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
4188 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
4189 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
4190 * mcs.exe.sources: Add generic.cs.
4192 * codegen.cs: Unify with gmcs version.
4194 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
4195 (EmitContext): Add GenericDeclContainer implementation.
4196 * decl.cs (MemberCore, DeclSpace): Likewise.
4197 * namespace.cs: Remove #ifdef GMCS_SOURCE.
4199 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
4200 MCS TypeManager has a corresponding dummy method.
4202 2006-09-19 Martin Baulig <martin@ximian.com>
4204 * expression.cs: Completely merged with the gmcs version.
4206 2006-09-19 Martin Baulig <martin@ximian.com>
4208 * expression.cs (Invocation): Merged with the gmcs version.
4209 (ArrayAccess.GetStoreOpcode): Likewise.
4211 2006-09-19 Martin Baulig <martin@ximian.com>
4214 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
4215 (TypeManager.IsGenericMethodDefinition): Likewise.
4217 2006-09-19 Martin Baulig <martin@ximian.com>
4220 (TypeManager.IsEqual): Moved the gmcs implementation here.
4221 (TypeManager.DropGenericTypeArguments): Likewise.
4222 (TypeManager.DropGenericMethodArguments): Likewise.
4223 (TypeManager.GetTypeArguments): Moved here from gmcs.
4224 (TypeManager.HasGenericArguments): Likewise.
4226 2006-09-19 Martin Baulig <martin@ximian.com>
4228 * expression.cs (Binary): Merged with the gmcs version.
4230 2006-09-19 Martin Baulig <martin@ximian.com>
4232 * expression.cs (Probe, As, Is): Merged with the gmcs version.
4234 2006-09-19 Martin Baulig <martin@ximian.com>
4236 * typemanager.cs: Merged with the gmcs version.
4238 2006-09-16 Raja R Harinath <rharinath@novell.com>
4240 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
4241 * driver.cs: Likewise.
4243 2006-09-16 Marek Safar <marek.safar@seznam.cz>
4246 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
4247 only if parent type is class.
4248 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
4251 2006-09-15 Marek Safar <marek.safar@seznam.cz>
4254 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
4256 * typemanager.cs(CSharpName): Converts NullType to null.
4258 2006-09-15 Martin Baulig <martin@ximian.com>
4261 (TypeManager.GetMethodName): Added mcs implementation.
4262 (TypeManager.IsEqual): Likewise.
4265 (SimpleName.RemoveGenericArity): Added dummy implementation.
4267 * pending.cs: Merged with the gmcs version.
4269 2006-09-15 Martin Baulig <martin@ximian.com>
4271 * statement.cs: Merge with the gmcs version.
4273 2006-09-15 Martin Baulig <martin@ximian.com>
4275 * statement.cs (Switch): Merge with the gmcs implementation
4276 (without nullables), which is newer.
4278 2006-09-15 Martin Baulig <martin@ximian.com>
4280 * statement.cs (Block.Variables): Make this public.
4281 (ToplevelBlock.Parameters): Make this a property.
4282 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
4284 2006-09-15 Martin Baulig <martin@ximian.com>
4286 * namespace.cs: Merge with the gmcs version.
4288 2006-09-15 Martin Baulig <martin@ximian.com>
4290 * decl.cs (MemberName): Minor code cleanups.
4292 2006-09-15 Martin Baulig <martin@ximian.com>
4294 * parameter.cs: Merge with the gmcs version.
4296 2006-09-15 Martin Baulig <martin@ximian.com>
4298 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
4299 and an error in mcs.
4301 2006-09-15 Martin Baulig <martin@ximian.com>
4303 * flowanalysis.cs: Merged from GMCS; added the generics code into
4304 a `GMCS_SOURCE' conditional so we can share this file.
4306 2006-09-08 Martin Baulig <martin@ximian.com>
4308 * typemanager.cs (TypeManager.interlocked_type): New public field.
4309 (TypeManager.int_interlocked_compare-exchange): New public field.
4310 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
4311 enumerator types here and call InitGenericCoreTypes().
4312 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
4313 after calling InitEnumUnderlyingTypes().
4316 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
4317 `classes_second_stage'.
4319 2006-09-14 Marek Safar <marek.safar@seznam.cz>
4321 * assign.cs, ecore.cs, expression.cs: Share error message text.
4322 * class.cs (FieldMember.Define): Check for varible of static type.
4323 * driver.cs (LoadAssembly): Uses error output for errors.
4324 * statement.cs: Updated.
4326 2006-09-08 Marek Safar <marek.safar@seznam.cz>
4328 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
4331 2006-09-07 Martin Baulig <martin@ximian.com>
4334 (MainDriver): Revert r62663 from Marek; see #70506 for details.
4336 2006-08-29 Miguel de Icaza <miguel@novell.com>
4338 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
4340 2006-08-17 Miguel de Icaza <miguel@novell.com>
4342 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
4343 #52019 and #79064, the use of the \uXXXX sequence in source code
4344 to represent unicode characters.
4346 2006-08-15 Marek Safar <marek.safar@seznam.cz>
4348 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
4350 * class.cs, ecore.cs, statement.cs: Merged to one error message.
4352 2006-08-13 Miguel de Icaza <miguel@novell.com>
4354 * assign.cs: Catch attempts to assign to a method groups in += and
4357 2006-08-13 Marek Safar <marek.safar@seznam.cz>
4360 * cs-parser.jay: Don't destroy current array type by typeof of array's.
4362 2006-08-12 Marek Safar <marek.safar@seznam.cz>
4364 * class.cs (Method.Define): Issue a warning when generic method looks like
4366 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
4369 2006-08-09 Marek Safar <marek.safar@seznam.cz>
4371 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
4373 * decl.cs (MemberCache.FindMembers): When container is interface we need to
4374 search all base interfaces as a member can be ambiguous.
4375 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
4376 Constructor member type filter.
4377 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
4378 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
4379 reporting for returned memberinfos.
4380 * report.cs: Updated.
4381 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
4382 version to work on all runtimes.
4383 (TypeManager.RealMemberLookup): Removed members filtering.
4385 2006-08-08 Raja R Harinath <rharinath@novell.com>
4387 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
4388 (PropertyExpr.EmitAssign): Likewise.
4389 * expression.cs (Indirection.EmitAssign): Likewise.
4390 (LocalVariableReference.EmitAssign): Likewise.
4391 (ParameterReference.EmitAssign): Likewise.
4392 (Invocation.EmitArguments): Likewise.
4393 (ArrayAccess.EmitAssign): Likewise.
4394 (IndexerAccess.EmitAssign): Likewise.
4395 (This.EmitAssign): Likewise.
4396 (ConditionalLogicalOperator.Emit): Likewise.
4399 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
4400 instead of ArrayList. If the hashtable has a LocalBuilder, don't
4401 leave it in after returning it.
4402 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
4404 2006-08-06 Marek Safar <marek.safar@seznam.cz>
4406 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
4409 2006-08-03 Raja R Harinath <rharinath@novell.com>
4411 Fix cs0146-3.cs and cs0146-4.cs.
4412 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
4413 enclosing types don't depend on the current type.
4415 2006-08-02 Raja R Harinath <rharinath@novell.com>
4418 * class.cs (TypeContainer.DoDefineMembers): Use
4419 FindBaseMemberWithSameName on Parent, since we're interested in
4420 whether we hide inherited members or not.
4421 (FindBaseMemberWithSameName): Make slightly more robust.
4423 Fix the non-generic testcase from #77396
4424 * decl.cs (DeclSpace.DeclContainer): Remove override.
4426 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
4427 declspaces for doppelgangers too.
4428 (UsingEntry): Implement IResolveContext.
4429 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
4430 'this' as the resolve context.
4431 (LocalAliasEntry): Likewise.
4433 Implement parts of #77403
4434 * roottypes.cs (RootDeclSpace): New. Used to represent the
4435 toplevel declaration space. Each namespace declaration introduces
4436 a "partial" root declaretion space.
4437 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
4438 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
4439 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
4440 from 'current_namespace.SlaveDeclSpace'.
4441 (namespace_declaration): Likewise.
4442 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
4443 check. It can't happen now.
4444 * decl.cs (DeclSpace.LookupType): Likewise.
4445 * driver.cs (MainDriver): Sanity check.
4447 2006-08-01 Raja R Harinath <rharinath@novell.com>
4449 * decl.cs (DeclSpace.FindNestedType): Remove.
4450 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
4451 LookupTypeContainer to get the container of the nested type.
4452 * class.cs (TypeContainer.FindNestedType): Make non-override.
4454 2006-07-31 Raja R Harinath <rharinath@novell.com>
4456 * decl.cs (DeclSpace.PartialContainer): Move field from ...
4457 * class.cs (TypeContainer.PartialContainer): ... here.
4458 (TypeContainer.AddBasesForPart): New helper.
4459 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
4461 * cs-parser.jay (current_class): Convert to DeclSpace.
4462 (struct_declaration, interface_declaration, class_declaration):
4463 Use AddBasesForPart instead of .Bases directly.
4464 * const.cs, iterators.cs: Update to changes.
4466 2006-07-28 Raja R Harinath <rharinath@novell.com>
4468 * class.cs (TypeContainer.AddMemberType): Rename from
4470 (TypeContainer.AddMember): Rename from AddToMemberContainer.
4471 (AddTypeContainer): New. Combine AddClassOrStruct and
4473 (AddPartial): Update. Add 'is_partial' argument.
4474 * roottypes.cs: Update to changes.
4475 * cs-parser.jay (push_current_class): New helper for handling
4476 current_container and current_class.
4477 (struct_declaration, interface_declaration, class_declaration):
4480 2006-07-26 Raja R Harinath <rharinath@novell.com>
4482 * roottypes.cs: Rename from tree.cs.
4484 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
4485 * tree.cs (Tree, ITreeDump): Remove types.
4486 * rootcontext.cs (tree, Tree): Remove fields.
4487 (root, ToplevelTypes): New.
4488 * *.cs: Update to rename.
4490 * tree.cs (Tree.RecordDecl): Remove.
4491 (RootTypes.AddToTypeContainer): Record the toplevel type in its
4493 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
4495 2006-07-23 Raja R Harinath <harinath@gmail.com>
4497 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
4498 DoFlowAnalysis and OmitStructFlowAnalysis here.
4499 (ec.With): Rename from WithUnsafe and generalize.
4500 (ec.WithCheckState): Remove. All users can be handled by 'With'.
4501 (ec.WithFlowAnalyis): New.
4502 * ecore.cs, expression.cs, statement.cs: Update.
4504 2006-07-22 Raja R Harinath <harinath@gmail.com>
4506 * statement.cs (Block.ResolveMeta): Simplify slightly.
4508 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
4509 multiple boolean fields. Convert InUnsafe, constant_check_state,
4510 check_state to flags.
4511 (CheckState, ConstantCheckState): Update.
4512 (InUnsafe): New read-only property.
4513 (FlagsHandle): Rename from CheckStateHandle and convert to handle
4515 (WithUnsafe): New helper similar to WithCheckState.
4516 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
4517 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
4519 2006-07-21 Raja R Harinath <rharinath@novell.com>
4521 Make comparisons use the same IL irrespective of whether they're
4522 in a 'checked' or 'unchecked' context: one of the issues in #78899
4523 * codegen.cs (EmitContext.CheckState): Make read-only property.
4524 (EmitContext.ConstantCheckState): Likewise.
4525 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
4526 helper that implement a save/restore stack for CheckState
4527 values. This is the only way to change check-state.
4528 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
4529 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
4530 (CheckedExpr.EmitBranchable): New forwarding method.
4531 (UnCheckedExpr): Likewise.
4532 * statement.cs (Block.ResolveMeta): Use WithCheckState.
4533 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
4534 (Checked.Resolve, checked.DoEmit): Likewise.
4536 2006-07-20 Miguel de Icaza <miguel@novell.com>
4538 * anonymous.cs: Cache the resolved anonymous delegate, and return
4539 this so that the ResolveTopBlock is only triggered once, not
4542 Currently we trigger ResolvetopBlock twice due to a first pass of
4543 argument check compatibility, and a second pass that does the
4546 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4548 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
4550 * rootcontext.cs (Reset): Add helper_classes.
4552 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4555 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
4558 2006-07-13 Miguel de Icaza <miguel@novell.com>
4560 * statement.cs (Lock): Handle expressions of type
4561 TypeManager.null_type specially. Fixes #78770
4563 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4565 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
4568 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4570 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
4571 for accessors as well.
4572 * ecore.cs (EventExpr): Add AccessorTable.
4574 2006-07-01 Marek Safar <marek.safar@seznam.cz>
4577 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
4578 for CS0122 where appropriate.
4579 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
4581 (Filter): Assembly can be null in the case of top level attributes.
4583 2006-06-25 Marek Safar <marek.safar@seznam.cz>
4587 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
4588 is done at global level.
4590 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4592 A fix for #77002, Implemented TypeForwarder support.
4594 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
4595 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
4596 * typemanager.cs (): Add type_forwarder_attr_type.
4598 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4600 * report.cs: Add CS0469 warning.
4602 2006-06-21 Martin Baulig <martin@ximian.com>
4604 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
4605 the `try'-block, so we also report CS0016 etc. there.
4607 2006-06-21 Martin Baulig <martin@ximian.com>
4610 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
4612 2006-06-21 Martin Baulig <martin@ximian.com>
4614 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
4615 also report CS1686 for parameters.
4617 2006-06-21 Martin Baulig <martin@ximian.com>
4619 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
4620 instead of an error if the value is not implicitly convertible to
4621 the switch types; fixes #77964.
4623 2006-06-21 Raja R Harinath <rharinath@novell.com>
4626 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
4627 FieldBuilder is null.
4630 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
4631 'left' and 'right' before error-checking.
4633 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
4635 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
4637 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
4638 (FieldExpr.DoResolve): likewise.
4639 (PropertyExpr.InstanceResolve): likewise.
4640 (EventExpr.InstanceResolve): likewise.
4642 2006-06-04 Marek Safar <marek.safar@seznam.cz>
4644 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
4645 attribute applicable tests for attribute argument.
4647 2006-06-02 Raja R Harinath <rharinath@novell.com>
4650 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
4651 (Binary.OverloadResolve_PredefinedIntegral): New.
4652 (Binary.OverloadResolve_PredefinedFloating): New.
4653 (Binary.OverloadResolve_PredefinedString): New.
4654 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
4655 Follow the standard more closely, and treat numeric promotions in
4656 terms of overload resolution.
4657 (Binary.CheckShiftArguments): Simplify.
4659 2006-06-01 Raja R Harinath <rharinath@novell.com>
4661 * flowanalysis.cs (MyBitVector): Simplify representation.
4662 (MyBitVector.Clone): Avoid allocating BitArray.
4663 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
4664 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
4665 (*): Update. Change all references to MyBitVector.And and
4666 MyBitVector.Or to &= and |=.
4668 2006-05-29 Raja R Harinath <rharinath@novell.com>
4671 * cs-parser.jay (formal_parameter_list): Extend the pattern below
4672 to param arguments too.
4674 2006-05-26 Miguel de Icaza <miguel@novell.com>
4676 * cs-parser.jay: Catch another parsing form for arglist being
4677 followed by other arguments. Fixes #78313.
4679 2006-05-24 Raja R Harinath <rharinath@novell.com>
4681 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
4682 checking of out parameters to ...
4683 (FlowBranchingToplevel.Merge): ... here.
4684 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
4685 set, propagate the origin upward, and only complain if there was
4687 (FlowBranchingException.AddContinueOrigin): Likewise.
4688 (FlowBranchingException.AddReturnOrigin): Likewise.
4689 (FlowBranchingException.AddGotoOrigin): Likewise.
4691 2006-05-23 Raja R Harinath <rharinath@novell.com>
4693 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
4694 unreachable, skip it.
4695 (FlowBranchingException.Merge): Always propagate jumps, even if
4696 the finally block renders subsequent code unreachable.
4698 2006-05-18 Raja R Harinath <rharinath@novell.com>
4701 * statement.cs (Goto.Resolve): Move responsibility for resolving
4702 'goto' to FlowBranching.AddGotoOrigin.
4703 (Goto.SetResolvedTarget): New. Callback to set the
4704 LabeledStatement that's the target of the goto.
4705 (Goto.DoEmit): Use Leave instead of Br when crossing an
4706 unwind-protect boundary.
4707 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
4708 LookupLabel and adjust to new semantics.
4709 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
4710 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
4711 Goto.SetResolvedTarget to update target.
4712 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
4713 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
4714 AddBreakOrigin & co. Delay propagation until ...
4715 (FlowBranchingException.Merge): ... this.
4717 * statement.cs (Block.Resolve): Always depend on flow-branching to
4718 determine unreachability. Kill workaround that originally emitted
4719 only one statement after an "unreachable" label (see infloop in
4722 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
4723 This is still "wrong", but anything better would probably need a
4724 multi-pass algorithm.
4725 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
4726 usage vector. Force current usage vector to be reachable, to
4727 optimistically signify backward jumps.
4728 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
4730 (FlowBranchingLabeled.Merge): New. If no backward jump was
4731 detected, return the original salted-away usage vector instead,
4732 updated with appropriate changes. Print unreachable warning if
4734 * statement.cs (Block.Resolve): Don't print unreachable warning on
4735 a labeled statement.
4737 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
4739 * driver.cs: Pass filename without path to AssemblyBuilder's
4740 AddResourceFile. Fixes bug #78407.
4742 2006-05-17 Raja R Harinath <rharinath@novell.com>
4744 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
4745 * flowanalysis.cs (FlowBranchingLabeled): ... here.
4746 (FlowBranching.MergeChild): Overwrite
4747 reachability information from Labeled branchings too.
4749 2006-05-16 Raja R Harinath <rharinath@novell.com>
4751 * statement.cs (Goto.Resolve): Merge jump origins here ...
4752 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
4754 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
4755 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
4756 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
4757 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
4759 * statement.cs (Goto.Resolve): ... not here.
4760 (Goto.Emit): Remove CS1632 check.
4762 2006-05-14 Marek Safar <marek.safar@seznam.cz>
4764 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
4767 2006-05-11 Raja R Harinath <rharinath@novell.com>
4769 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
4770 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
4771 (FlowBranchingException.Label): Likewise.
4773 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
4775 (MyBitVector.Or): Use it to avoid losing information (Count).
4776 (FlowBranching.MergeOrigins): Likewise.
4778 * flowanalysis.cs (UsageVector.IsDirty): Remove.
4779 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
4780 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
4781 (UsageVector.ToString): Simplify.
4782 (UsageVector.MergeSiblings): Move here from ...
4783 (FlowBranching.Merge): ... here.
4784 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
4787 2006-05-10 Raja R Harinath <rharinath@novell.com>
4789 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
4790 null bitvector is treated as all-true.
4792 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
4793 (MyBitVector): Rationalize invariants. 'vector != null' implies
4794 that we have our own copy of the bitvector. Otherwise,
4795 'InheritsFrom == null' implies all inherited bits are true.
4797 2006-05-09 Marek Safar <marek.safar@seznam.cz>
4799 * statement.cs (LocalInfo): Add IsConstant.
4800 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
4801 local variable for constants.
4803 2006-05-09 Raja R Harinath <rharinath@novell.com>
4805 * flowanalysis.cs (MyBitVector.Empty): New.
4806 (MyBitVector): Don't allow InheritedFrom to be null.
4807 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
4808 (UsageVector, FlowBranching): Update to changes.
4810 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
4811 recursion. The 'Parent == null' condition isn't sufficient for
4813 (FlowBranching.AddBreakOrigin): Likewise.
4814 (FlowBranching.AddContinueOrigin): Likewise.
4815 (FlowBranching.AddReturnOrigin): Likewise.
4816 (FlowBranching.StealFinallyClauses): Likewise.
4817 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
4818 (FlowBranching.CheckOutParameters): Likewise.
4819 (FlowBranchingToplevel): Terminate all the above recursions here.
4820 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
4821 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
4823 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
4825 (FlowBranchingToplevel): New. Empty for now.
4826 (FlowBranching.MergeTopBlock): Update.
4827 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
4828 branching for the anonymous delegate.
4829 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
4831 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
4832 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
4833 information at the start of the merge. Reorganize.
4835 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4837 * class.cs (MethodData.Define): Method cannot implement interface accessor.
4839 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4841 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
4842 to newly introduced ctor.
4844 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
4845 message to one place.
4846 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
4849 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4851 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
4853 * ecore.cs (Expression.ResolveAsConstant): Updated.
4855 * statement.cs (ResolveMeta): Updated.
4857 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4859 * cs-parser.jay: __arglist cannot be used in initializer.
4861 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4864 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
4867 2006-05-05 Raja R Harinath <rharinath@novell.com>
4869 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
4870 (LabeledStatement): Add 'name' parameter.
4871 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
4872 (Block.AddLabel): Update to changes.
4873 * cs-parser.jay (labeled_statement): Likewise.
4875 * flowanalysis.cs (BranchingType.Labeled): New.
4876 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
4877 (FlowBranchingLabeled): New. Does nothing for now, but will
4878 eventually handle 'goto' flows.
4879 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
4880 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
4881 that's terminated ...
4882 (Block.Resolve): ... here.
4884 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
4885 (UsageVector.MergeFinallyOrigins): Likewise.
4886 (FlowBranching.InTryOrCatch): Likewise.
4887 (FlowBranching.AddFinallyVector): Likewise.
4888 (FlowBranchingException): Update to changes.
4891 * statement.cs (Return.Resolve): Move error checking to ...
4892 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
4893 (FlowBranchingException): Handle return origins like break and
4895 (FlowBranching.UsageVector.CheckOutParameters): Remove.
4897 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4900 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
4903 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4906 * class.cs (MethodData.Define): Do public accessor check only when method
4907 implements an interface.
4909 2006-05-04 Raja R Harinath <rharinath@novell.com>
4911 Remove special handling of 'break'
4912 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
4913 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
4914 (UsageVector.Break): Remove.
4915 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
4917 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
4919 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
4920 UsageVector.Breaks (). Don't set NeedsReturnLabel.
4922 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4925 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
4926 be the interface member.
4928 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4931 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
4932 for emitting small (int) values.
4934 2006-05-03 Raja R Harinath <rharinath@novell.com>
4937 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
4938 control-flow passes through the 'finally' after merging-in all the
4939 control-flows from 'try' and the 'catch' clauses.
4941 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
4942 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
4943 always true at the only non-recursive entry point.
4944 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
4945 FlowBranchingBreakable.
4946 (FlowBranchingLoop): Remove.
4947 * statement.cs (Return.DoResolve): Update to changes.
4950 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
4951 (FlowBranching.CreateBranching): Handle it: create a
4952 FlowBranchingContinuable.
4953 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
4954 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
4955 except that it handles the 'continue' command.
4956 (FlowBranching.UsageVector.MergeOrigins): Rename from
4958 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
4959 except that it overrides AddContinueOrigin.
4960 (FlowBranchingException): Override AddContinueOrigin, similar to
4962 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
4963 Create a new branching around the embedded statement.
4964 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
4965 control flow after the embedded statement.
4966 (Continue.Resolve): Move all error checking to AddContinueOrigin.
4968 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
4969 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
4970 FlowBranchingBreakable.
4971 (FlowBranchingSwitch): Remove.
4974 * statement.cs (Break.Resolve): Simplify. Move responsibility for
4975 error reporting to ...
4976 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
4977 Rename from 'AddBreakVector'. Add new location argument. Return
4978 a bool indicating whether the 'break' crosses an unwind-protect.
4979 (FlowBranchingException.AddBreakOrigin): Add.
4980 (FlowBranchingException.Merge): Propagate 'break's to surrounding
4981 flowbranching after updating with the effects of the 'finally'
4983 (FlowBranchingBreakable): New common base class for
4984 FlowBranchingLoop and FlowBranchingSwitch.
4986 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
4988 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
4990 2006-05-02 Raja R Harinath <rharinath@novell.com>
4992 * statement.cs (Do.Resolve): If the loop is infinite, set the
4994 (While.Resolve, For.Resolve): Set a barrier after the embedded
4995 statement. There's no direct control flow that goes from the end
4996 of the embedded statement to the end of the loop.
4997 * flowanalysis.cs (FlowBranching.Infinite): Remove.
4998 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
4999 above ensure that the reachability is correctly computed.
5001 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
5002 (UsageVector.MergeBreakOrigins): If the current path is
5003 unreachable, treat it as if all parameters/locals are initialized.
5004 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
5005 infinite loops before merging-in break origins.
5007 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
5008 (Reachability.Reachable): Split part into ...
5009 (Reachability.Unreachable): ... this. Simplify.
5010 (Reachability.IsUnreachable): Use 'Unreachable' instead.
5012 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
5013 (Reachability.SetThrowsSometimes): Likewise.
5014 (FlowBranchingBlock.MergeTopBlock): Don't compare against
5015 TriState.Always, use corresponding property.
5016 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
5017 (Block.Resolve): Likewise. Remove some redundant checks.
5019 2006-05-02 Raja R Harinath <harinath@gmail.com>
5021 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
5022 (Reachability.Meet): Don't bother checking AlwaysThrows --
5023 barrier is always set.
5024 (FlowBranchingBlock.Merge): Likewise.
5026 2006-05-01 Raja R Harinath <harinath@gmail.com>
5028 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
5029 checks for unreachable.
5031 2006-05-01 Marek Safar <marek.safar@seznam.cz>
5034 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
5036 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
5037 whether field is really assigned.
5039 2006-04-30 Raja R Harinath <harinath@gmail.com>
5041 * flowanalysis.cs (Reachability): Make 4-argument constructor
5043 (Reachability.Meet): Rename from 'And'. Remove static variant.
5044 (Reachability.Always): Rename from the highly misleading
5045 'Reachability.Never'.
5046 (FlowBranching.Merge): Update to changes. Mark an impossible
5047 situation with a 'throw'.
5048 (*): Update to changes.
5050 2006-04-29 Raja R Harinath <harinath@gmail.com>
5052 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
5054 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
5055 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
5056 (*): Update to changes.
5057 * statement.cs: Update to changes.
5059 2006-04-28 Marek Safar <marek.safar@seznam.cz>
5062 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
5064 2006-04-28 Raja R Harinath <harinath@gmail.com>
5066 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
5069 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
5070 argument to two arguments: an usage-vector and a bool. Move call
5071 to FlowBranching.Merge () ...
5072 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
5074 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
5075 handling of loop and switch reachability to ...
5076 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
5078 2006-04-27 Raja R Harinath <harinath@gmail.com>
5080 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
5081 handling to FlowBranchingLoop.InLoop.
5082 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
5084 2006-04-26 Marek Safar <marek.safar@seznam.cz>
5087 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
5088 anonymous method is allowed from AnonymousContainer here.
5090 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
5092 2006-04-24 Raja R Harinath <rharinath@novell.com>
5095 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
5097 2006-04-23 Marek Safar <marek.safar@seznam.cz>
5100 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
5101 (DoubleConstant.Reduce): Ditto.
5103 2006-04-23 Raja R Harinath <rharinath@novell.com>
5105 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
5106 Remove 'lvalue_right_side' argument. Move parts to ...
5107 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
5108 (LocalVariable.DoResolveLValue): ... these.
5110 2006-04-21 Raja R Harinath <rharinath@novell.com>
5113 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
5114 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
5115 (LocalVariableReference.DoResolveBase): Use it to implement new
5117 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
5118 (Argument.Resolve): Simplify. Move CS1510 check ...
5119 * ecore.cs (Expression.ResolveLValue): ... here.
5120 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
5121 (PropertyExpr.DoResolveLValue): Likewise.
5122 (FieldExpr.Report_AssignToReadonly): Likewise.
5123 (FieldExpr.DoResolve): Add 'out_access' argument. Use
5124 LValueMemberAccess or LValueMemberOutAccess on instance depending
5126 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
5127 DoResolve as appropriate.
5129 2006-04-20 Raja R Harinath <rharinath@novell.com>
5132 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
5133 implicit conversions on 'out' and 'ref' arguments.
5135 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
5136 improve clarity. Remove dead code.
5139 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
5140 (Catch.Resolve): Resolve VarBlock if it exists.
5142 2006-04-19 Miguel de Icaza <miguel@novell.com>
5144 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
5145 twice, this was some residual code, the enumerator was emitted
5146 properly in the two branche of if later.
5148 2006-04-19 Raja R Harinath <rharinath@novell.com>
5150 * expression.cs (Cast.ResolveLValue): Remove. The result of a
5151 cast is never an lvalue.
5152 (Cast.DoResolve, Cast.ResolveRest): Combine.
5153 (Argument.Emit): Simplify slightly. Move 'Expr is
5154 IMemoryLocation' check ...
5155 (Argument.Resolve): ... here.
5156 (Argument.Error_LValueRequired): Remove. Inline into only user.
5158 Simplifications. Fix cs0191-2.cs
5159 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
5160 CS1649 and CS1651 to ...
5161 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
5162 the actual selection of the error code and message to a lookup
5163 table. Add a dummy return value to simplify callsites.
5164 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
5165 readonly fields of other instances of the same type. Move CS0197
5167 * expression.cs (Argument.Resolve): ... here. Simplify code.
5168 Ensure that ec.InRefOutArgumentResolving is only set during LValue
5169 resolution of an out or ref argument. The code simplification
5170 above uses this invariant.
5172 2006-04-18 Raja R Harinath <rharinath@novell.com>
5174 Possibly fix #77752. Fix cs1690-[4-7].cs.
5175 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
5176 CheckMarshallByRefAccess. Drop parameter.
5177 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
5179 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
5181 * report.cs (AllWarnings): Add CS1690.
5182 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
5184 (LocalVariableReference.DoResolveBase): Update.
5186 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5188 * class.cs (MethodOrOperator): Moved common parts from method class.
5189 detect obsolete attributes.
5190 (Method.Define): Simplified as it reuses code from base.
5191 (Constructor.ValidAttributeTargets): Fixed issue found during
5193 (Destructor.ValidAttributeTargets): Fixed issue found during
5195 (Operator): Finished refactoring set off by #78020. Operator class is now
5196 ordinary method class.
5198 * anonymous.cs: Updated.
5200 * decl.cs (DeclSpace): Add IsGeneric
5202 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5204 * class.cs (Constructor.Emit): Don't emit the attributes twice.
5206 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5208 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
5209 detect obsolete attributes.
5210 (Method.CreateEmitContext): Moved to MethodOrOperator.
5212 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5215 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
5216 customized exception to make crash detection easier.
5217 (MethodOrOperator): Started to work on new base class for methods and
5219 (Method): Derives from MethodOrOperator.
5220 (Constructor.Emit): Emits its own attributes.
5221 (AbstractPropertyEventMethod.Emit): Ditto.
5222 (Operator): Derives from MethodOrOperator, will refactor fully in extra
5224 (Operator.Emit): It's temporary more tricky than should be.
5226 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
5228 * report.cs (InternalErrorException): Add ctor with inner exception.
5230 2006-04-08 Marek Safar <marek.safar@seznam.cz>
5233 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
5236 2006-04-07 Marek Safar <marek.safar@seznam.cz>
5239 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
5242 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5244 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
5245 attribute is present and Guid not.
5246 (Interface.ApplyAttributeBuilder): Ditto.
5248 * attribute.cs: Add error message.
5250 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5254 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
5255 sources (it's composite) so hold them in extra array as they are used in
5256 Emit phase only. It worked in the previous versions by mistake.
5257 (Attribute.Emit): Emit attribute for more owners when exist.
5259 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
5260 it has now different behaviour.
5262 2006-04-04 Marek Safar <marek.safar@seznam.cz>
5264 * constant.cs (Constant.IsDefaultInitializer): New method.
5266 * class.cs: Updated.
5268 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
5269 re-initialize default values. It saves KBs almost for every assembly.
5270 Thanks Zoltan for the idea.
5271 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
5272 (ArrayCreation.DoResolve): Resolve only once.
5273 (ArrayCreation.Emit): Emit static initializer only when it is faster.
5274 (ArrayCreation.GetAttributableValue): Cope with optimized values.
5276 2006-04-03 Zoltan Varga <vargaz@gmail.com>
5278 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
5281 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5283 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
5284 in an embedded statement too.
5286 2006-04-01 Raja R Harinath <rharinath@novell.com>
5289 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
5291 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5295 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
5298 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
5300 2006-03-31 Marek Safar <marek.safar@seznam.cz>
5302 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
5305 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
5306 LocalTemporary change.
5308 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
5310 (ClassOrStruct.DefineFieldInitializers): Implemented static field
5311 initializers optimization.
5312 (ClassOrStruct.TypeAttr): Moved from modifiers.
5313 (Constructor.CheckBase): Don't crash when static ctor has parameters.
5314 (FieldBase.ResolveInitializer): Resolves initializer.
5315 (FieldBase.HasDefaultInitializer): New property.
5317 * cs-parser.jay: Removed message.
5319 * expression.cs (CompilerGeneratedThis): New specialization.
5321 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
5323 2006-03-28 Marek Safar <marek.safar@seznam.cz>
5325 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
5327 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5329 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
5330 be now EnumConstants only.
5332 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5334 * attribute.cs, driver.cs: Reset more caches.
5336 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5338 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
5340 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5342 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
5343 for easier reuse. Updated all overrides.
5344 (IntegralConstant): New base class for all integral constants.
5345 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
5346 of the constant range, report custom error.
5347 (UIntConstant.Reduce): Fixed uint conversion.
5349 * ecore.cs, literal.cs: Reduce updates.
5351 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5355 * class.cs (Constructor.Define): Removed extra if for default ctors.
5356 A patch from Atsushi Enomoto.
5358 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5360 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
5361 GetAttributableValue.
5363 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
5366 * convert.cs (ImplicitConversionRequired): Error message moved to
5369 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
5370 automatic implicit conversion of an output value.
5371 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
5373 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
5375 (TypeOf.GetAttributableValue): Add extra handling for object type.
5377 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
5378 special error message.
5380 2006-03-25 Marek Safar <marek.safar@seznam.cz>
5382 * class.cs (Constructor.Emit): Don't crash when struct ctor is
5384 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
5385 compatible with MS runtime.
5387 2006-03-23 Marek Safar <marek.safar@seznam.cz>
5389 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
5390 attribute arguments here.
5392 * class.cs (Indexer.Define): The check was moved to attribute class.
5394 2006-03-22 Marek Safar <marek.safar@seznam.cz>
5396 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
5397 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
5400 2006-03-22 Raja R Harinath <rharinath@novell.com>
5402 Support ParameterDefaultValueAttribute in gmcs. Also applied to
5403 mcs to keep code differences small.
5404 * attribute.cs (Attribute.GetParameterDefaultValue): New.
5405 * typemanager.cs (parameter_default_value_attribute_type): New.
5406 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
5409 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5411 * expression.cs (StringConcat.Append): Reverted back to no warning state.
5413 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5415 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
5417 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
5420 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
5422 * doc-bootstrap.cs : fix build.
5424 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5426 * expression.cs (StringConcat.Append): Issue a warning when empty string
5429 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5431 * assign.cs (CompoundAssign.ResolveSource): Removed.
5433 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
5436 * class.cs (TypeContainer.FindMethods): Removed.
5437 (TypeContainer.CheckMemberUsage): Made static.
5439 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
5441 * constant.cs (CheckRange): Removed unused type argument.
5442 (CheckUnsigned): Removed unused type argument.
5444 * cs-parser.jay: Updated after MemberAccess clean up.
5445 Uses Length for empty string test.
5447 * cs-tokenizer.cs: Uses Length for empty string test.
5448 (IsCastToken): Made static.
5449 (is_hex): Made static.
5450 (real_type_suffix): Made static.
5452 * decl.cs (SetupCache): Made static.
5453 (OnGenerateDocComment): Removed unused ds argument.
5455 * delegate.cs (VerifyDelegate): Removed unused argument.
5457 * doc.cs: Uses Length for empty string test.
5459 * driver.cs: Uses Length for empty string test.
5461 * enum.cs (IsValidEnumType): Made static
5463 * expression.cs (EnumLiftUp): Removed unused argument.
5464 (ResolveMethodGroup): Ditto.
5465 (BetterConversion): Ditto.
5466 (GetVarargsTypes): Ditto.
5467 (UpdateIndices): Ditto.
5468 (ValidateInitializers): Ditto.
5469 (MemberAccess.ctor): Ditto.
5470 (GetIndexersForType): Ditto.
5472 * flowanalysis.cs: (MergeFinally): Removed unused argument.
5474 * iterators.cs: Updated after MemberAccess clean up.
5476 * location.cs: Uses Length for empty string test.
5478 * namespace.cs: Uses Length for empty string test.
5480 * report.cs (CheckWarningCode): Made static.
5482 * statement.cs (LabeledStatement): Removed unused argument.
5484 * typemanager.cs (FilterNone): Removed.
5486 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5488 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
5491 * class.cs: Updated.
5493 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5495 * cs-parser.jay.cs: __arglist is not allowed for delegates.
5497 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5501 * expression.cs (VerifyArgumentsCompat): Reverted to double error
5502 reporting, it's more tricky than I thought.
5504 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5508 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
5510 (AnonymousMethod.ImplicitStandardConversionExists): New method.
5511 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
5512 Add more error reporting; Fixed issue with params.
5514 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
5516 * cs-parser.jay: AnonymousMethod requires host container.
5518 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
5520 2006-03-18 Raja R Harinath <harinath@gmail.com>
5522 * class.cs: Change 'TypeContainer ds' constructor argument to
5523 'DeclSpace parent'. Some classes were missed below due to
5524 different naming convention.
5526 * class.cs (MemberCore.Parent): Delete. This makes the
5527 ParentContainer changes below enforceable by the compiler.
5529 Treat pointers to enclosing declaration space as 'DeclSpace', not
5531 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
5532 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
5534 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
5536 (Block.AddThisVariable): Likewise.
5537 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
5538 (AbstractPropertyEventMethod.Emit): Likewise.
5539 (AbstractPropertyEventMethod.EmitMethod): Likewise.
5540 (GetMethod.Define, SetMethod.Define): Likewise.
5541 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
5542 (DelegateMethod.EmitMethod): Likewise.
5544 Fix regression test-partial-13.cs.
5545 Rationalize use of PartialContainer. Ensure that the partial
5546 class semantics can be tied to type-correctness, i.e., any
5547 violation will cause a compile error.
5548 * class.cs, const.cs: Access all fields that belong to class
5549 TypeContainer via ParentContainer. Arguments of EmitContexts and
5550 Resolve()-like functions still use 'Parent'.
5552 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
5553 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
5554 (PropertyMethod.CheckModifiers): Remove unused argument.
5555 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
5558 2006-03-17 Raja R Harinath <harinath@gmail.com>
5560 Make semantics of PartialContainer simpler.
5561 * decl.cs (DeclSpace.IsPartial): Remove.
5562 * class.cs (TypeContainer.IsPartial): Likewise.
5563 (TypeContainer..ctor): Set PartialContainer to point to self.
5564 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
5565 (TypeContainer.FindNestedType): Likewise.
5566 (MemberCore.ParentContainer): Simplify. Remove deprecation.
5568 2006-03-17 Marek Safar <marek.safar@seznam.cz>
5570 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
5572 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5574 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
5577 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5579 * class.cs (Operator.Define): An error for base conversion was not
5582 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
5584 * iterator.cs : yield break is allowed in try statement which has
5585 catch clauses. Fixed bug #77767.
5587 2006-03-13 Marek Safar <marek.safar@seznam.cz>
5589 A fix for #77593, #77574.
5591 * class.cs (MethodCore.CheckBase): Another if for operator.
5593 2006-03-09 Marek Safar <marek.safar@seznam.cz>
5595 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
5598 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
5599 (DelegateCreation.ImplicitStandardConversionExists): New method for just
5602 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
5605 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
5606 Updated after another emitcontext usage was clean up. It should help us to
5607 synchronize with gmcs easier.
5609 2006-03-04 Marek Safar <marek.safar@seznam.cz>
5613 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
5614 (Event.Define): ditto
5615 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
5617 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
5618 Removed redundant code and set NewSlot for Invoke method too.
5620 * parameter.cs (Parameters.ctor): Add custom, type ctor.
5621 (Parameters.MergeGenerated): New method. Use this method when you merge
5622 compiler generated argument with user arguments.
5624 2006-03-03 Marek Safar <marek.safar@seznam.cz>
5626 * attribute.cs (ResolveAsTypeTerminal): Removed.
5628 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
5629 specialization for predefined types; 30% speed up.
5630 Finally placed obsolete check to right place.
5631 (Expression.ResolveType): Removed.
5633 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
5634 Updated after ResolveType was removed.
5636 * expression.cs (Cast.ctor): Check void cast.
5637 (Binary.ResolveAsTypeTerminal): Is never type.
5638 (Conditional.ResolveAsTypeTerminal): Is never type.
5640 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
5642 2006-03-01 Raja R Harinath <rharinath@novell.com>
5645 * expression.cs (ParameterReference.DoResolveBase): Change return
5647 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
5651 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
5654 * typemanager.cs (GetFullNameSignature): Don't nullref on
5655 protected accessors.
5657 2006-02-27 Marek Safar <marek.safar@seznam.cz>
5659 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
5660 these two separated members to simplify the code.
5661 (Attribute.Resolve): Refactored to use new fields and methods.
5662 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
5663 implemented obsolete attribute checking.
5664 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
5665 implemented obsolete checking again. It look line never ending quest ;-)
5666 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
5668 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
5670 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
5672 *class.cs (Property.Define): Add RegisterProperty call.
5674 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
5675 argument groups (only 2).
5677 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
5678 encoding expression to arguments.
5679 (Expression.ExprClassToResolveFlags): Just turned to property.
5681 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
5682 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
5683 optimized as well as implemented support for zero-length attributes.
5685 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
5686 Add caching of PropertyInfo's.
5688 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5690 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
5691 error multiple times.
5693 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5695 New partial class implementation.
5696 A fix for #77027, #77029, #77403
5698 * attribute.cs (Attributable): Made attributes protected.
5700 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
5701 the replacements of ClassPart and PartialContainer.
5702 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
5703 (TypeContainer.AddInterface): Ditto.
5704 (TypeContainer.AddPartial): The main method for partial classes. It checks
5705 for errors and merges ModFlags and attributes. At the end class is added to
5707 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
5709 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
5710 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
5711 from the rest of partial classes.
5712 (TypeContainer.GetClassBases): Simplified.
5713 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
5715 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
5716 (TypeContainer.HasExplicitLayout): Uses Flags now.
5717 (PartialContainer): Removed.
5718 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
5719 (StaticClass): Was merged with Class.
5720 (Class.GetClassBases): class and static class bases are verified here.
5721 (Class.TypeAttr): Added static attributes when class is static.
5722 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
5723 (MemberBase): In some cases we need to call parent container for partial
5724 class. It should be eliminated but it's not easy now.
5726 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
5728 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
5729 partial classed to accumulate class comments.
5730 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
5732 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
5734 * driver.cs (MainDriver): Tree.GetDecl was removed.
5736 * modifiers.cs (Modifiers): Add partial modifier.
5738 * tree.cs (Tree.decl): Removed.
5739 (RootTypes): Started to use this class more often for root types
5742 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5746 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
5747 external interface does not have an attribute.
5749 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5751 Another prerequisites for new partial classs implementation.
5753 * attribute.cs (Attribute.Equal): Implemented.
5754 (Attribute.Emit): Changed as attributes can be applied more than twice.
5755 (Attributes.Emit): Check for duplicate attributes here.
5757 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
5758 as a parameter, clean-up.
5760 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5764 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
5765 contains obsolete attribute check which can in some cases look for base
5766 type of current class which is not initialized yet.
5767 (TypeContainer.BaseType): Replacement of ptype.
5769 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
5771 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5773 First of prerequisites for new partial classs implemention.
5775 * attribute.cs (Attributable): Extended by ResolveContext;
5776 Attributes finally have correct context for resolving in all cases.
5777 (AttachTo): Attribute owner is assigned here.
5779 * codegen.cs (IResolveContext): Introduce new interface to hold
5780 all information needed in resolving phase.
5781 (EmitContext): Implements IResolveContext; more clean-up needed here.
5783 * decl.cs (MemberCore): Implemented IResolveContext.
5785 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
5786 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
5787 parameter.cs, statement.cs, tree.cs, typemanager.cs:
5788 Refactored to use new IResolveContext instead of EmitContext; cleanup
5790 2006-02-06 Miguel de Icaza <miguel@novell.com>
5792 * codegen.cs (EmitScopeInitFromBlock): check here the
5793 capture_context, there is no need to make two calls to the
5796 * anonymous.cs: Add some debugging messages that might help me
5797 track other instances of this problem in the future (the
5798 regression of test 467).
5800 * cs-parser.jay: track the variable block, as we need to initalize
5801 any captured variables declared in this block for the "catch"
5802 portion of the "Try" statement.
5804 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
5805 scope initialization for captured variables.
5807 Also, move the emit for the variables after the block location has
5810 2006-02-06 Marek Safar <marek.safar@seznam.cz>
5812 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
5814 2006-02-02 Miguel de Icaza <miguel@novell.com>
5816 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
5817 commit yesterday, the initialization for the roots is necessary.
5818 What is not necessary is the scope activation.
5820 2006-02-02 Raja R Harinath <rharinath@novell.com>
5822 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
5823 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
5825 (Argument.Resolve): Remove CS0206 checks.
5827 2006-02-01 Miguel de Icaza <miguel@novell.com>
5829 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
5830 scopes for all the roots, the scopes will now be emitted when the
5831 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
5833 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
5834 code. This reduces a lot of existing cruft.
5836 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
5837 that the ScopeInfo is generated as we enter the scope, not at the
5838 time of use, which is what we used to do before.
5840 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
5841 every time a Block is about to be emitted if we have a
5844 2006-02-01 Raja R Harinath <rharinath@novell.com>
5846 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
5848 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
5850 * typemanager.cs (cons_param_array_attribute): Make private.
5851 (Reset): Set it to null.
5852 (InitCoreHelpers): Don't initialize it.
5853 (ConsParamArrayAttribute): New. Initialize it as needed.
5854 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
5856 2006-01-31 Miguel de Icaza <miguel@novell.com>
5858 * expression.cs: There might be errors reported during the
5859 selection of applicable methods. If there are errors, do not
5860 continue execution as it will lead the compiler to crash.
5862 2006-01-30 Miguel de Icaza <miguel@novell.com>
5864 * expression.cs: Member access is not allowed on anonymous
5865 methods. Fixes #77402.
5867 2006-01-30 Raja R Harinath <rharinath@novell.com>
5870 * cs-parser.jay (VariableDeclaration): Don't set
5871 current_array_type to null.
5872 (field_declaration, event_declaration, declaration_statement):
5873 Set it to null here.
5875 2006-01-28 Raja R Harinath <harinath@gmail.com>
5877 * typemanager.cs (GenericParameterPosition): New.
5880 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
5882 * doc.cs : To process "include" elements, first we should create
5883 another list than XmlNodeList, because it could result in node
5884 removal, which could result in that the XmlNodeList gives up
5887 (Also made code identical to gmcs again.)
5889 2006-01-25 Miguel de Icaza <miguel@novell.com>
5891 * ecore.cs: Introduce an error report that we were not catching
5892 before, if not silent, we must report the error. Gonzalo ran into
5895 2006-01-23 Miguel de Icaza <miguel@novell.com>
5897 A fix for bug: #76957
5899 * iterators.cs (MoveNextMethod.CreateMethodHost): call
5900 ComputeMethodHost before creating the method, this is a new
5903 * anonymous.cs (AnonymousContainer): Now we track all the scopes
5904 that this method references (RegisterScope). The actual scope
5905 where the method is hosted is computed with the ComputeMethodHost
5906 before we create the method.
5908 Moved the Deepest routine here.
5910 (AnonymousContainer.ComputeMethodHost): New routine used to
5911 compute the proper ScopeInfo that will host the anonymous method.
5913 (ScopeInfo): Deal with multiple roots. The problem was that we
5914 did not have a unique root where all ScopeInfos could be hanged
5915 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
5918 Remove AdjustMethodScope which is now computed at the end. Remove
5919 LinkScope which did a partial link, instead link all ScopeInfos
5920 before code generation from the new "LinkScopes" routine.
5922 Simplify all the Add* routines as they no longer need to maintain
5923 the tree, they just need to record that they are using variables
5926 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
5927 routines to produce the forest of ScopeInfo trees.
5929 * class.cs (TypeContainer.AppendMethod): This is just like
5930 AddMethod, but ensures that an interface implementation method
5931 (IEnumerable.XXX) is not inserted at the beginning of the queue of
5932 methods, but at the end.
5934 We use this functionality to ensure that the generated MoveNext
5935 method in the iterator class is resolved/emitted before the
5936 enumerator methods created.
5938 This is required because the MoveNext method computes the right
5939 ScopeInfo for the method. And the other methods will eventually
5940 need to resolve and fetch information computed from the anonymous
5943 2006-01-21 Raja R Harinath <harinath@gmail.com>
5944 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5947 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
5949 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
5950 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
5952 2006-01-18 Raja R Harinath <rharinath@novell.com>
5954 Fix #76656, cs0231-2.cs.
5955 * cs-parser.jay (formal_parameter_list): Make error case catch
5957 (parenthesized_expression_0): Add CS1026 check.
5958 (invocation_expression): Remove unused { $$ = lexer.Location }.
5960 2006-01-17 Raja R Harinath <rharinath@novell.com>
5963 * cs-parser.jay (statement_expression): Don't list out the
5964 individual statement-expressions. Convert syntax error into
5967 2006-01-16 Raja R Harinath <rharinath@novell.com>
5970 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
5971 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
5972 CheckIntermediateModification.
5973 (FieldExpr.DoResolve): Add new two-argument version that
5974 allows us to resolve the InstanceExpression as an lvalue.
5975 The one-argument variant is now just a wrapper.
5976 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
5977 Resolve the lhs as an lvalue if the it has a value type.
5978 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
5979 from Assign.DoResolve.
5980 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
5981 resolved as an lvalue.
5982 (PropertyExpr.DoResolve): Update.
5983 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
5984 has a value type. Move CS1612 check here from
5985 CheckIntermediateModification.
5986 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
5987 * expression.cs (EmptyExpression.OutAccess): New. Used as the
5988 'right_side' of a ResolveLValue on an 'out' argument.
5989 (EmptyExpression.LValueMemberAccess): New. Used as the
5990 'right_side' of a propagated ResolveLValue on a value type.
5991 (LocalVariableReference.DoResolveBase): Recognize
5992 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
5994 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
5995 EmptyExpression.Null.
5997 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
5999 * typemanager.cs : added IsGenericParameter(). In mcs it always
6001 * doc.cs : for generic parameters, use GenericParameterPosition,
6004 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
6006 * expression.cs: Fix Console.WriteLine ((this = x).foo);
6008 2006-01-12 Miguel de Icaza <miguel@novell.com>
6010 This fixes the problem where we used ldfld instead of ldflda to
6011 load the "THIS" pointer on captured parameters, when THIS is a
6012 value type. See bug #77205.
6014 * iterators.cs (CapturedThisReference.Emit): Pass false to
6015 EmitThis (we do not need the address).
6017 * codegen.cs (EmitThis): it needs to know whether we need the
6018 address of `this' or not. This is used by value types.
6020 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
6021 every other call passes false.
6023 2006-01-12 Raja R Harinath <rharinath@novell.com>
6026 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
6028 * expression.cs (Invocation.OverloadResolve): Update.
6029 (Invocation.DoResolve): Avoid double resolution of invocation.
6031 2006-01-11 Raja R Harinath <rharinath@novell.com>
6034 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
6035 unary negation of floating point types as 0-expr; negation cannot
6036 overflow in floating point types.
6039 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
6040 on operands of 'void' type.
6043 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
6044 and ExclusiveOr for boolean constants too.
6046 2006-01-09 Raja R Harinath <rharinath@novell.com>
6049 * expression.cs (Invocation.OverloadResolve): Replace reflected
6050 override methods with their base virtual methods, rather than
6052 * typemanager.cs (TypeManager.GetOverride): New.
6054 2006-01-05 Jb Evain <jbevain@gmail.com>
6056 * class.cs (Property.Define, Indexer.Define): do not tag the
6057 properties as SpecialName | RTSpecialName.
6059 2006-01-04 Miguel de Icaza <miguel@novell.com>
6061 * class.cs (MethodCore.IsDuplicateImplementation): This method was
6062 doing a low-level comparission of parameter types. It was lacking
6063 a check for __argslist.
6065 2005-12-30 Miguel de Icaza <miguel@novell.com>
6067 * expression.cs (ParameterReference.DoResolveBase): Allow
6068 reference parameters if they are local to this block.
6070 This allows the ref and out parameters of a delegate to be used in
6071 an anonymous method, for example:
6073 delegate void set (out int x);
6075 set s = delegate (out int x){
6079 This is used by functionality introduced late in the C# language.
6081 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
6082 method that take ref and out parameters.
6084 Fixes #77119 which was a late change in the spec.
6086 2005-12-23 Miguel de Icaza <miguel@novell.com>
6088 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
6089 parent if its the same scope. Fixes #77060.
6091 2005-12-21 Miguel de Icaza <miguel@novell.com>
6093 * driver.cs: Report the case of no source files and no -out:
6096 2005-12-20 Raja R Harinath <rharinath@novell.com>
6099 * expression.cs (ComposedCast.GetSignatureForError): Define.
6101 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6105 * namespace.cs (NamespaceEntry): Add extern_aliases as a
6106 ListDictionary, to contain the ExternAliasEntry entries (in
6107 addition to the NamespaceEntry.aliases hashtable). This field is
6108 shared between the original entry and its doppelganger (bodyless
6110 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
6111 extern_aliases field.
6112 (NamespaceEntry.Lookup): Move the IsImplicit check after the
6113 lookup in extern_aliases.
6115 2005-12-16 Raja R Harinath <rharinath@novell.com>
6118 * class.cs (TypeContainer.Mark_HasEquals): New.
6119 (TypeContainer.Mark_HasGetHashCode): New.
6120 (ClassPart): Override them.
6121 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
6124 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
6125 'parent' argument to the base constructor.
6127 Remove all mention of TypeContainer from decl.cs.
6128 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
6129 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
6130 (DeclSpace.DeclSpace): Likewise.
6131 (DeclSpace.DefineMembers): Remove unused argument.
6132 * cs-parser.jay (pop_current_class): Update to changes. Simplify
6133 debugging check -- we don't care if the debug code throws an
6134 InvalidCastException instead of an InternalErrorException.
6135 * class.cs (TypeContainer.DefineMembers): Update to changes.
6136 (TypeContainer.DoDefineMembers): Likewise.
6137 (TypeContainer.GetMethods): Likewise.
6138 (PropertyMember.Define): Likewise.
6139 (MemberBase.Parent): New property that forwards to
6140 MemberCore.Parent, but ensures that we get a TypeContainer.
6141 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
6142 (RootContext.PopulateTypes): Likewise. Remove special case code
6143 for !RootContext.StdLib: DefineMembers is idempotent.
6145 2005-12-14 Miguel de Icaza <miguel@novell.com>
6147 * convert.cs (ExplicitConversionCore): Check the return value from
6148 ExplicitConversionCore which can return null on failure. Fixes #76914
6150 2005-12-13 Marek Safar <marek.safar@seznam.cz>
6152 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
6154 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
6156 * doc.cs : The search for referenced namespace was insufficient to
6157 get global one as it used to do. Fixed bug #76965.
6159 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
6161 * doc.cs : check name in cref in the last phase that whether it is
6164 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6166 * cs-tokenizer.cs : reverted the latest change: it somehow broke
6169 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6171 * doc.cs : so it turned out that we cannot skip override check for
6172 interface members. Fixed bug #76954.
6174 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6176 * cs-tokenizer.cs : fixed bug #75984:
6177 - #warning and #error should not be handled when the source line
6179 - #line is not checked strictly when the source line is disabled.
6180 - #define and #undef is on the other hand checked strictly at any
6183 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
6185 * cs-tokenizer.cs : missing Location (actually, filename) in one of
6188 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6190 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
6192 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
6194 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
6195 (FieldBase.Initializer): Initializer is now optional.
6196 (EventField.Define): Only event field can have initializer.
6198 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
6200 * const.cs (Const): Reuse initializer.
6202 * cs-parser.jay: Updated after FieldBase changes.
6203 Added current_array_type to simplify array initializers.
6205 * ecore.cs (NullCast.IsDefaultValue): Implemented.
6207 * expression.cs, iterators.cs: Updated.
6209 * namespace.cs (NamespaceEntry): Made UsingFound private.
6211 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6213 * parameterCollection.cs: Obsolete, removed.
6214 * parser.cs: Obsolete, removed.
6216 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6219 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
6221 * enum.cs (Enum.Define): Set obsolete context here.
6223 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6226 - FindDocumentedMember() now expects 1) paramList as null
6227 when "we don't have to check the number of parameters" and
6228 2) Type.EmptyTypes when "there is no arguments".
6229 - Introduced FoundMember struct to hold the exact type which was
6230 used to find the documented member (the above change broke
6231 test-xml-044; it might be better just to use DeclaringType than
6232 what MS does, like this change does, but it depends on usage.)
6234 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6236 * doc.cs : documented member might be from DeclaringType for nested
6237 types. Fixed bug #76782.
6239 2005-12-03 Ben Maurer <bmaurer@ximian.com>
6241 * anonymous.cs: Have the param code handle leaving copies on the
6242 stack etc. Allows anonymous params to take part in the assignment
6243 code (++, +=, etc). Fixes bug #76550
6245 * expression.cs: Handle the prepare_for_load/leave_copy by passing
6246 it down to the anon code.
6248 * iterators.cs: Use dummy var here
6250 * codegen.cs: Handle new vars
6252 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6255 * class.cs (MethodData.Define): Set proper Obsolete context.
6257 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
6259 (FieldExpr.DoResolve): Ditto.
6261 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6264 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
6265 parent is not obsolete.
6267 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
6269 * doc.cs : (FindDocumentedMember) find parameterless members first
6270 and get CS0419 in the early stage. Fixed first case of bug #76727.
6272 2005-11-30 Marek Safar <marek.safar@seznam.cz>
6275 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
6276 no error was reported.
6278 *expression.cs (Binary.DoResolve): left can be null.
6280 2005-11-22 Marek Safar <marek.safar@seznam.cz>
6283 * class.cs (MethodData.Emit): Parameters should be labeled first.
6285 2005-11-21 Marek Safar <marek.safar@seznam.cz>
6288 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
6290 2005-11-18 Marek Safar <marek.safar@seznam.cz>
6292 * attribute.cs (AreParametersCompliant): Moved to Parameter.
6294 * class.cs (MethodCore): Parameter clean up.
6295 (IMethodData): Added ParameterInfo.
6296 (MethodData): Parameter clean up.
6297 (Indexer.Define): Parameter clean up.
6309 * typemanager.cs: Parameter clean up.
6311 * delegate.cs (Define): Get rid of duplicated code.
6313 * expression.cs (ParameterReference): Removed useless parameters
6315 (Invocation): Ditto.
6317 * parameter.cs (ParamsParameter): New class, params specialization.
6318 (ArglistParameter): Attemp to separate arglist.
6319 (Parameter): Refactored to be reusable and faster.
6320 (Parameter.Modifier): Made understandable.
6321 (Parameters): Changed to be used as a class for `this' assembly
6322 parameters. Refactored to use new specialized classes.
6324 * support.cs (ParameterData): Added Types property.
6325 (InternalParameters): Deleted.
6327 2005-08-20 Martin Baulig <martin@ximian.com>
6329 Merging this patch from GMCS to fix #75867.
6331 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6332 scope if we don't already have it.
6334 2005-11-17 Martin Baulig <martin@ximian.com>
6337 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
6338 inherit the scope from our parent. Fixes #76653.
6340 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6342 * doc.cs : the previous patch does not actually fix the bug.
6343 PropertyInfo override check is now implemented and really fixed it.
6344 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
6346 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6348 * doc.cs : apply "override filter" also to properties.
6351 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6353 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
6354 no need to check overrides. For classes, omit those results from
6355 interfaces since they must exist in the class. Fixed bug #76726.
6357 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6359 * typemanager.cs : (GetFullNameSignature) differentiate indexers
6360 with different parameters. Fixed the second problem in #76685.
6362 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6364 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
6365 get expected 'protected' access in CheckValidFamilyAccess()).
6368 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6370 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
6371 Fixed bug #76705. CS1569 was incorrectly commented out.
6373 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6375 * doc.cs : use Invocation.IsOverride() to do real override check.
6376 * expression.cs : made Invocation.IsOverride() internal.
6378 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6380 * doc.cs : use TypeManager.FindMembers() instead of (possible)
6381 TypeBuilder.FindMembers() and filter overriden base members out.
6384 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6386 * doc.cs : ref/out parameters are represented as '@' (instead of
6387 '&' in type FullName). Fixed bug #76630 (additionally crefs).
6389 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6391 * doc.cs : when there was no '.' in cref to methods in doc comment,
6392 then parameters were missing in the output. Fixed bug #76691.
6394 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6396 * driver.cs : don't output docs when there is an error.
6399 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6402 Now it should detect indexers. Fixed primary concern in bug #76685.
6403 Fixed CS0419 message to not show the identical member signature in
6406 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6408 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
6409 instead of Type.FindMembers() since it does not handle events.
6412 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
6414 * codegen.cs: Fixed typo (speficied -> specified).
6416 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6419 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
6421 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6423 * attribute.cs: Changed error message.
6425 * cs-tokenizer.cs: One more check.
6427 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6429 * statement.cs (Block.Resolve): Ignore empty statement.
6431 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6433 * report.cs: Made error/warning methods more strict to avoid
6436 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
6437 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
6438 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
6439 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
6441 2005-11-08 Marek Safar <marek.safar@seznam.cz>
6443 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
6444 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
6446 * class.cs (TypeContainer.IsComImport): New property.
6447 (Constructor.Define): Create proper ctor for ComImport types.
6449 * expression.cs (New.CheckComImport): Fixed.
6451 2005-11-07 Miguel de Icaza <miguel@novell.com>
6453 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
6454 that a parameter has been captured does not mean that we do not
6455 have to do the rest of the processing. This fixes the second part
6456 of #76592. If there was another anonymous method capturing
6457 values in the past, the Scope would never be set for the second
6458 method that captured the same parameter.
6460 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
6461 properly manipulate the stack. Second part of fix for #76592.
6463 * expression.cs (New): Add support for invoking "new" on
6464 interfaces that have been flagged with the ComImport attribute and
6465 the CoClass. Fixes #76637
6467 * statement.cs (Try.DoEmit): When a variable is captured, do not
6468 try to emit the vi.LocalBuilder variable as it has been captured.
6469 Create a temporary variable and store the results on the
6470 FieldBuilder. Fixes #76642
6472 2005-11-07 Marek Safar <marek.safar@seznam.cz>
6474 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
6476 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
6478 * expression.cs (Binary.DoResolve): Added && optimalization.
6480 * typemanager.cs (AddUserType): Removed useless argument.
6482 2005-11-04 Marek Safar <marek.safar@seznam.cz>
6484 * statement.cs (Block.variables): Uses ListDictionary.
6486 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6489 * class.cs (PartialContainer.EmitType): Customized to emit
6490 security attributes.
6491 (ClassPart.ApplyAttributeBuilder): Transform security attribute
6492 for partial classes.
6494 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6497 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
6498 access has to be fixed.
6500 * typemanager.cs (IsUnmanagedType): Wrong common field type.
6502 2005-11-01 Marek Safar <marek.safar@seznam.cz>
6505 * ecore.cs (NullCast.Reduce): Implemented.
6507 * expression.cs (ArrayCreation.CheckIndices): Correcly check
6510 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
6512 (Foreach.Resolve): Catch null properly.
6514 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6516 * cs-tokenizer.cs: Warning text fix.
6518 * driver.cs: AllWarningNumbers exposed on public interface.
6520 * report.cs (): Reviewed warning numbers.
6521 (IsValidWarning): Use binary search.
6523 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6525 * driver.cs: Implemeted resource visibility.
6526 (Resources): New class for code sharing between /res: and
6529 2005-10-28 Marek Safar <marek.safar@seznam.cz>
6532 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
6535 * convert (Convert.ImplicitReferenceConversion): NullCast holds
6538 * ecore.cs (NullCast): Child is contant only.
6540 * literal.cs (NullLiteral.Reduce): null can be converted to any
6543 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
6545 * driver.cs: Use Encoding.Default as default code page instead
6548 2005-10-27 Raja R Harinath <rharinath@novell.com>
6551 * expression.cs (Invocation.Error_InvalidArguments): Handle
6552 __arglist parameters.
6553 (Invocation.VerifyArgumentsCompat): Likewise.
6554 * support.cs (ReflectionParameters.GetSignatureForError): Print
6555 __arglist parameters.
6556 (InternalParamters.GetSignatureForError): Likewise.
6557 * parameter.cs (Parameters.GetSignatureForError): Likewise.
6559 2005-10-26 Marek Safar <marek.safar@seznam.cz>
6561 * attribute.cs (GetPropertyValue): Made public.
6563 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
6565 Add new property WrapNonExceptionThrows to handle 2.0 assembly
6567 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
6570 * driver.cs: Reflect method name change.
6572 * statement.cs (Try.Resolve): Warn when try has both general
6575 * typemanager.cs: runtime_compatibility_attr_type new predefined
6578 2005-10-26 Raja R Harinath <harinath@gmail.com>
6581 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
6582 treat it as an empty parameter list.
6584 2005-10-26 Raja R Harinath <rharinath@novell.com>
6587 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
6588 ResolveAsTypeStep silent.
6589 * statement.cs (Block.AddConstant): Mark block as used.
6590 (Block.ResolveMeta): Avoid piling on error messages
6591 if a constant initializer resolution fails.
6593 2005-10-25 Raja R Harinath <rharinath@novell.com>
6595 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
6597 (NamespaceEntry.VerifyAllUsing): New.
6598 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
6599 behaviour. Delegates actual resolution of alias to ...
6600 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
6601 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
6603 * driver.cs (Driver.MainDriver): Update.
6605 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
6606 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
6608 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
6610 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
6611 RootNamespace.DefineNamespacesForAll.
6613 2005-10-24 Raja R Harinath <harinath@gmail.com>
6615 * typemanager.cs (assemblies, external_aliases, modules)
6616 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
6617 (ComputeNamespaces, GetRootNamespace): Remove extra staging
6618 overhead. Move resposibility ...
6619 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
6620 * driver.cs, attribute.cs, codegen.cs: Update to changes.
6622 2005-10-23 Raja R Harinath <harinath@gmail.com>
6624 * namespace.cs (RootNamespace.all_namespaces): Renamed from
6625 cached_namespaces. Improve usage.
6626 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
6627 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
6628 Move from GlobalRootNamespace and simplify.
6629 (RootNamespace.Global): Make instance variable.
6630 (RootNamespace.RootNamespace): Add "alias name" parameter.
6631 (GlobalRootNamespace): Simplify drastically.
6632 (Namespace.Lookup): Don't use GetNamespace.
6633 * typemanager.cs (GetRootNamespace): Rename from
6634 ComputeNamespaceForAlias.
6635 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
6637 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6639 * anonymous.cs (AnonymousContainer): Don't crash when container
6642 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6644 * expression.cs (Binary.DoResolve): Warn when comparing same
6647 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6650 * expression.cs (Binary.DoResolve): It looks like there are no
6651 convetsion rules in enum context.
6653 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6655 Add support for extern alias qualifiers.
6656 * typemanager.cs: Move some LookupTypeReflection code
6657 to namespace.cs, to have cleaner code. Added some methods
6658 to help us keep track of the extern aliased references.
6659 * driver.cs: Add suport for extern alias assemblies on command
6660 line and check for their warnings/errors. Also keep track of the
6661 extern aliased assemblies.
6662 * namespace.cs: Move the global functionality of Namespace
6663 to GlobalRootNamespace/RootNamespace. Now the global namespace
6664 is GlobalRootNamespace.Globa. Also the code moved from
6665 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
6666 Finally added LocalAliasEntry (AliasEntry before) and
6667 ExternAliasEntry, to handle alias statements.
6668 * cs-parser.jay: Add support in the grammar for extern alias
6670 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
6671 Update callings to Namespace (now in GlobalRootNamespace).
6673 2005-10-18 Raja R Harinath <rharinath@novell.com>
6676 * class.cs (TypeContainer.DefineType): Move updating of
6677 topological sort earlier in the code.
6678 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
6680 2005-10-18 Marek Safar <marek.safar@seznam.cz>
6683 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
6685 * constant.cs (Constant.TryReduce): Moved from Cast class.
6686 (Reduce): Made little bit more OO and fixed missing conversions.
6688 * ecore.cs (Reduce): Implemented.
6689 (Binary.EnumLiftUp): New method to upgrade values to enum values.
6691 * literal.cs (Reduce): Implemented.
6693 * class.cs: Reverted Miguel's wrong commit.
6695 2005-10-14 Miguel de Icaza <miguel@novell.com>
6697 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
6699 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
6701 * cs-parser.jay, expression.cs : CS0214 was missing error location
6702 for constants. Fixed bug #76404.
6704 2005-10-11 Marek Safar <marek.safar@seznam.cz>
6707 * convert.cs (ExplicitConversionCore): Fixed object->enum
6710 2005-10-10 Raja R Harinath <rharinath@novell.com>
6712 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
6714 (PropertyExpr.EmitCall): Likewise.
6715 * expression.cs (Invocation.EmitArguments): Handle case where
6717 (Invocation.EmitCall): Avoid allocating temporary variable if
6718 there are no arguments.
6720 2005-10-07 Raja R Harinath <rharinath@novell.com>
6723 * convert.cs (ImplicitConversionStandard): Move conversion of
6724 void* to arbitrary pointer types ...
6725 (ExplicitConversionStandard): .. here.
6726 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
6727 error to always print typenames.
6729 2005-10-07 Raja R Harinath <rharinath@novell.com>
6731 * convert.cs (GetConversionOperator): Rename from
6732 GetConversionOperators. Move operator selection code from ...
6733 (UserDefinedConversion): ... here.
6735 2005-10-06 Marek Safar <marek.safar@seznam.cz>
6737 * convert.cs (ExplicitConversionCore): Removed duplicate enum
6740 2005-10-05 Marek Safar <marek.safar@seznam.cz>
6742 * assign.cs (Assign.DoResolve): Error method changed.
6744 * cfold.cs (DoConstantNumericPromotions): Error method changed.
6746 * const.cs (ResolveValue): Reset in_transit immediately.
6748 * constant.cs: Error method changed.
6750 * convert.cs: Removed useless location parameter.
6751 (ExplicitNumericConversion): Don't do double enum check.
6752 (ExplicitConversionCore): Renamed from ExplicitConversion.
6753 (ExplicitUnsafe): Extracted from ExplicitConversion.
6754 (ExplicitConversion): Uses for error reporting.
6756 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
6758 (ResolveBoolean): Uses common error method.
6759 (CastToDecimal): Get rid of ec.
6760 (CastFromDecimal): Optimized.
6761 (ConvCast): Get rid of ec.
6763 * enum.cs (ResolveValue): Reset in_transit immediately.
6764 (Emit): Return after first error.
6766 * expression.cs: Convert changes.
6768 * literal.cs: Error method changed.
6770 * statement.cs: Error method changed.
6772 2005-10-03 Raja R Harinath <rharinath@novell.com>
6774 * support.cs (SeekableStreamReader.Position): Don't error out when
6775 the requested position is just beyond the end of the current
6778 2005-09-28 Raja R Harinath <rharinath@novell.com>
6780 * support.cs (SeekableStreamReader): Simplify drastically. Don't
6781 try to keep in sync with the byte count of the underlying Stream.
6782 However, this limits us to a window size of 2048 characters: i.e.,
6783 the maximum lookahead of our lexer/parser can be 2048 characters.
6785 2005-09-28 Marek Safar <marek.safar@seznam.cz>
6788 * driver.cs: Fix compilation files with full root path.
6790 2005-09-25 Miguel de Icaza <miguel@novell.com>
6792 * report.cs (SymbolRelatedToPreviousError): Format the output so
6793 it does not use an open parenthesis that is never closed.
6795 * driver.cs: Follow coding guidelines
6797 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6800 * const.cs (Const.ResolveValue): Check for assigning non-null
6801 value to reference type.
6803 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6805 * anonymous.cs: Implemented ExprClassName.
6807 * assign.cs (Assign.DoResolve): Don't chrash when type is not
6810 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
6813 * class.cs (StaticClass.DefineContainerMembers): Report protected
6816 * codegen.cs: if(ed) PRODUCTION.
6818 * convert.cs (Error_CannotImplicitConversion): Better error
6821 * cs-parser.jay: More error checks.
6823 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
6825 * driver.cs (CSCParseOption): Enabled wrong option check.
6827 * ecore.cs (Expression.ExprClassName): Turned to property.
6828 (MemberExpr.CheckIntermediateModification): For checking boxed
6829 value types modification.
6831 * statement.cs (Fixed.Resolve): Expression type must be
6832 convertible to fixed type.
6833 (CollectionForeach.GetEnumeratorFilter,TryType):
6834 Small refactoring for easier error checking.
6836 2005-09-26 Marek Safar <marek.safar@seznam.cz>
6838 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
6841 * class.cs (GeneratedBaseInitializer): New class for customization
6842 compiler generated initializers.
6843 (MemberBase.DoDefine): Check Obsolete attribute here.
6844 (FieldMember.DoDefine): Ditto.
6846 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
6849 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
6850 (MemberCore.GetObsoleteAttribute): Removed argument.
6851 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
6852 (MemberCore.CheckObsoleteType): New helper.
6856 * statement.cs: Updates after MemberCore changes.
6858 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
6859 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
6861 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
6862 obsolete attribute for compiler construct.
6863 (As.DoResolve): Cache result.
6865 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
6867 2005-09-26 Raja R Harinath <rharinath@novell.com>
6870 * expression.cs (This.VerifyFixed): In a value type T, the type of
6871 'this' is T&, iow, 'this' is either an out or ref parameter. In a
6872 value type R, 'this' is treated as a value parameter.
6874 2005-09-22 Miguel de Icaza <miguel@novell.com>
6876 * statement.cs (Lock): Use the TemporaryVariable class instead of
6877 manually using local variables as those do not work when variables
6880 * ecore.cs: Moved the TemporaryVariable class from being a nested
6881 class inside Foreach to be a public class that can be employed in
6884 2005-09-19 Marek Safar <marek.safar@seznam.cz>
6886 * cs-parser.jay: interface_accessors replaced by
6887 accessor_declarations.
6889 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
6892 * statement.cs (GotoCase.Resolve): Convert null constant to
6894 (SwitchLabel.ResolveAndReduce): Ditto.
6895 (SwitchLabel.NullStringCase): Custom null stamp.
6896 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
6898 typemanager.cs (CSharpSignature): Don't skip first argument
6901 2005-09-18 Miguel de Icaza <miguel@novell.com>
6903 * driver.cs: Set InEmacs based on the environment variable EMACS.
6905 * location.cs (InEmacs): in this mode, do not report column
6906 location as it confuses Emacs.
6908 2005-09-16 Marek Safar <marek.safar@seznam.cz>
6910 * cfold.cs, constant.cs, convert.cs, ecore.cs,
6911 expression.cs, iterators.cs, literal.cs: Store constants and
6914 * class.cs (MemberBase.ShortName): Pass location.
6916 * cs-parser.jay: Some location fixes.
6918 * ecore.cs (Expression.Location): Made virtual.
6920 2005-09-05 Miguel de Icaza <miguel@novell.com>
6922 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
6923 if the underlying types are the same, otherwise we need to produce
6924 code that will do the proper cast.
6926 This was exposed by Marek's constant rewrite which produced
6927 invalid code for the call site:
6930 void Method (X v) {}
6934 This fixes test-49.cs
6936 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6938 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
6939 Type/Object should be allowed as well. Fixed bug #75968.
6941 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6943 * expression.cs : (Binary.DoResolve): when one is enum constant and
6944 another is constant 0, then return enum one *as enum type*.
6947 2005-09-02 Raja R Harinath <rharinath@novell.com>
6949 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
6953 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
6954 flow-branching for LocalVariableReferences in case we were invoked
6955 from a MemberAccess.
6956 * expression.cs (LocalVariableReference.VerifyAssigned): New.
6958 (LocalVariableReference.DoResolveBase): ... this.
6959 (MemberAccess.Resolve): Do the check that was disabled during
6962 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6965 (PartialContainer.Create): check abstract/sealed/static strictly
6966 but abstract/sealed can exist only at one side. Fixed bug #75883.
6968 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
6971 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
6972 specified, don't default to UnmanagedType.I4.
6974 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6976 * expression.cs : conditional operator should check possibly
6977 incorrect assign expression. Fixed bug #75946.
6979 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6981 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
6982 Reverting the change. gmcs is much complex than mcs on this matter.
6984 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6986 * cs-tokenizer.cs : To read another token ahead of the actual
6987 consumption, use new SavedToken and cache token instead of moving
6988 back the stream with SeekableStreamReader (it seemed problematic).
6990 driver.cs : Thus use StreamReader directly.
6991 * support.cs : Thus removed SeekableStreamReader.
6993 2005-08-30 Raja R Harinath <rharinath@novell.com>
6996 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
6997 (ScopeInfo.EmitScopeType): Use it to construct field names from
6998 names of captured locals.
7001 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
7002 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
7003 Pass 'target_type' to BoxedCast. Don't default to 'object'.
7004 (ExplicitConversion): Remove enum cases already handled by
7005 implicit conversion. Move implicit conversion check to the beginning.
7006 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
7007 * expression.cs (ArrayCreation.EmitDynamicInitializers):
7008 Don't treat System.Enum as a struct.
7010 2005-08-30 Jb Evain <jbevain@gmail.com>
7012 * attribute.cs: handles as expression in parameters.
7014 2005-08-30 Raja R Harinath <rharinath@novell.com>
7017 * class.cs (TypeContainer.VerifyClsName): Don't use a
7018 PartialContainer when verifying CLS compliance.
7019 (AbstractPropertyEventMethod): Set Parent here, ...
7020 (PropertyMethod): ... not here.
7022 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
7024 * attribute.cs : escaped attribute name should not be allowed to be
7025 resolved (e.g. @class as classAttribute). Fixed bug #75930.
7027 2005-08-29 Raja R Harinath <rharinath@novell.com>
7030 * convert.cs (ImplicitStandardConversionExists): Allow zero also
7031 when converting a long constant to unsigned long.
7032 * expression.cs (Invocation.OverloadResolve): Add sanity check to
7033 detect where IsApplicable and VerifyArgumentsCompat disagree.
7035 2005-08-29 Raja R Harinath <rharinath@novell.com>
7036 and Carlos Alberto Cortez <carlos@unixmexico.org>
7039 * class.cs (TypeContainer.CanElideInitializer): New helper.
7040 (TypeContainer.EmitFieldInitializers): Use it to determine if we
7041 can safely emitting the initializer of a field.
7043 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7045 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
7046 allowed inside a switch (without loop). Fixed bug #75433.
7048 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
7050 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
7051 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
7053 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7055 * driver.cs : kinda reverting the default encoding changes (not exact
7056 revert since I noticed that "codepage:reset" might not work fine).
7058 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7060 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
7061 Location. Now getter and setter store location correctly.
7062 (errors/cs0111-12.cs now reports the expected location.)
7064 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7066 * driver.cs : Use default encoding on the environment.
7067 Removed (now that) extra parameter for SeekableStreamReader.
7068 * support.cs : (SeekableStreamReader) third .ctor() argument for
7069 StreamReader is not required (always true). preamble size could
7070 be acquired in simpler and safe way.
7072 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
7074 * cs-parser.jay: report CS0642 at warning level 3
7075 and report CS0642 for an if else statement also
7076 fixes bug #74745. Patch by John Luke (and a bit
7078 Removed extra CS0642 warning check for "while",
7080 * statement.cs: In Block.Resolve(), CS0642 check
7081 is reimplemented to check a sequence of an empty
7082 statement and a block.
7084 Both fix bug #66777.
7086 2005-08-24 Marek Safar <marek.safar@seznam.cz>
7088 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
7089 detection until I fix it.
7091 * cs-tokenizer.cs: Changed error message.
7093 * cs-parser.jay: Fixed 2 error locations.
7095 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
7096 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
7099 * enum.cs (GetSignatureForError): Fixed.
7101 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
7105 * typemanager.cs (RegisterProperty): Removed.
7107 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
7109 2005-08-24 Raja R Harinath <rharinath@novell.com>
7112 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
7113 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
7115 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7117 * expression.cs : tiny fix is required for not warning positive ulong.
7120 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7122 * expression.cs : add CS0652 check for constant and integral
7123 expression. Fixed bug #53974.
7125 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7127 * expression.cs : in DoNumericPromotions(), check if there is implicit
7128 conversion overload for string (to check CS0034). Fixed bug #52492.
7130 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7132 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
7134 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7136 * ecore.cs : report location when it is *not* Null.
7138 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7144 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
7145 correctly. Fixed bug #75721.
7147 2005-08-23 Raja R Harinath <rharinath@novell.com>
7149 * support.cs (SeekableStreamReader.Position): Avoid an expensive
7150 loop that performs 'min (pos, char_count)'.
7153 * expression.cs (Unary.ResolveOperator): Don't discard implicit
7154 converted value in Operator.OnesComplement.
7156 2005-08-22 Ben Maurer <bmaurer@ximian.com>
7158 * anonymous.cs: If the anon method is pulled into a helper class,
7159 it needs to be `internal' not `private'. Fixes runtime behavior on
7162 2005-08-20 Martin Baulig <martin@ximian.com>
7164 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7165 scope if we don't already have it.
7167 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7168 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
7171 2005-08-17 Marek Safar <marek.safar@seznam.cz>
7174 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
7177 2005-08-16 Marek Safar <marek.safar@seznam.cz>
7179 The big constants rewrite
7180 Fix #75746, #75685 and more
7181 As a side effect saved 1MB for MWF ;-)
7183 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
7184 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
7185 enum based for corlib compilation.
7187 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
7190 * class.cs (FixedField.Define): Use ResolveAsConstant.
7192 * const.cs (IConstant): Interface constants and enums.
7193 (Const.ResolveValue): New method for constant resolvning.
7194 (ExternalConstant): Constants from imported assemblies.
7196 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
7197 conversion; like enums.
7198 (Constant.ToType): Converts this constant to different type.
7199 (Constant.Increment): Adds 1.
7201 * convert.cs (ImplicitConversionRequired): Simplified.
7203 * cs-parser.jay: Create EnumMember directly.
7205 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
7207 * doc.cs (GenerateEnumDocComment): Removed.
7209 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
7210 (ConvertIntLiteral): Removed.
7211 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
7213 * enum.cs (EnumMember): Implement IConstant.
7214 (Enum.IsValidEnumConstant): Removed.
7215 (Enum.GetNextDefaultValue): Removed.
7216 (Enum.FindMembers): Updated.
7217 (Enum.GenerateDocComment): Iterate enum members.
7219 * expression.cs (Cast.TryReduce): Handle enums correctly.
7220 (New.Constantify): Made public.
7221 (MemberAccess.DoResolve): Removed contant specific if(s).
7223 * literal.cs (NullLiteral): Implement new abstract methods.
7225 * statement.cs (GotoCase.Resolve): Use new constant methods.
7226 (SwitchLabel.ResolveAndReduce): Use new constant methods.
7228 * typemanager.cs (LookupEnum): Removed.
7229 (IsEnumType): Fixed to work with corlib.
7230 (RegisterConstant): Removed.
7231 (LookupConstant): Removed.
7232 (GetConstant): Changed to work with IConstant.
7234 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
7236 * location.cs : Fixed overflown (>255) column number.
7238 2005-08-03 Raja R Harinath <rharinath@novell.com>
7240 First cut of the qualified-alias-member feature.
7241 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
7243 * cs-parser.jay (DOUBLE_COLON): New token.
7244 (namespace_or_type_name): Add rule for recognizing
7245 qualified-alias-members.
7246 (primary_expression): Likewise.
7247 (element_access): Allow QualifiedAliasMember as a possible
7248 type-bearing expression.
7249 (local_variable_type, local_variable_pointer_type): Likewise.
7250 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
7251 aliases in the current and enclosing namespace declarations.
7252 (NamespaceEntry.UsingAlias): Add CS0440 warning.
7253 * decl.cs (MemberName.is_double_colon): New.
7254 (MemberName.MemberName): Add new constructor for alias-member.
7255 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
7256 * expression.cs (QualifiedAliasMember): New expression type.
7258 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7260 * location.cs : it borked when no argument was specified.
7262 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7264 * location.cs : tiny ToString() format fix.
7266 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7268 * statement.cs : oops, it was missing.
7270 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7272 A set of fixes for precise line/column location.
7275 "token" field now holds a file/line "delta", a line number offset
7276 from the segment, and a column number. See also:
7277 http://lists.ximian.com/pipermail/mono-devel-list/2004-
7278 December/009508.html
7279 Removed static IsNull. Use instance IsNull property instead.
7281 For some tokens it stores Location. For Identifier it stores
7282 LocatedToken which is a pair of string name and location.
7283 Column numbers are adjusted only at getChar().
7285 Use Location.ToString() for reporting (it now contains column).
7287 Largely modified to use LocatedToken instead of
7288 string (IDENTIFIER), and to acquire Location from some tokens.
7289 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
7290 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
7292 Now MemberName holds Location. DeclSpace.ctor() receives Location
7293 as a parameter. Removed extra parameters to all derived classes.
7294 Replaced Location.IsNull() with instance property.
7295 * assign.cs, expression.cs :
7296 Added .ctor() overload that omits Location.
7298 Added "nameEscaped" flag that indicates the identifier was escaped
7299 in the source file. This fixes bug #57047.
7301 2005-08-02 Marek Safar <marek.safar@seznam.cz>
7303 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
7304 New method, looking for lo-case imported cls type.
7306 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
7309 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
7311 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
7313 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
7315 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
7317 Optimized to save 3.5 MB for SWF compilation.
7319 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7321 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
7322 (PartialContainer.Create): Moved logic AddToContainer.
7323 (PartialContainer.MarkForDuplicationCheck): Shares name.
7325 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
7328 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
7330 (Namespace.GetSignatureForError): New method.
7332 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
7333 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
7335 2005-08-01 Raja R Harinath <rharinath@novell.com>
7338 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
7339 member lookup rather than qualifier_type, since qualifier_type can
7342 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7344 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
7347 2005-07-31 Miguel de Icaza <miguel@novell.com>
7349 * statement.cs: Copy the local exception into the exception
7350 captured local. Fixes 75674
7352 2005-07-31 Raja R Harinath <harinath@gmail.com>
7355 * expression.cs (Invocation.OverloadResolve): Don't report error
7356 CS1501 if error CS1502 has been reported.
7357 (New.DoResolve): Delegate CS1501 reporting to
7358 Invocation.OverloadResolve.
7361 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
7362 invariant-meaning-in-block property in an enclosing block if
7365 2005-07-29 Marek Safar <marek.safar@seznam.cz>
7367 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
7368 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
7369 (Switch.CheckSwitch): Just save 50kb for SWF.
7371 2005-07-27 Martin Baulig <martin@ximian.com>
7373 * anonymous.cs (CaptureContext.AddField): Added
7374 `AnonymousContainer am' argument; compute its toplevel scope if
7375 it's not already computed. Fixes #75649.
7377 2005-07-26 Raja R Harinath <rharinath@novell.com>
7380 * class.cs (Constructor.Emit): Reset block to null if the block
7383 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7385 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
7387 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7389 * class.cs (MethodData.Define): Check whether accessor implementing
7390 interface is public.
7392 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
7394 2005-07-22 Marek Safar <marek.safar@seznam.cz>
7397 * namespace.cs (LookupType): Moved same type check to...
7399 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
7402 2005-07-21 Raja R Harinath <rharinath@novell.com>
7404 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
7405 already found a typebuilder.
7406 * class.cs (MethodCore.IsDuplicateImplementation): Compare
7407 MemberNames, not strings.
7409 * const.cs (Error_ExpressionMustBeConst):
7410 Rename from Error_EpressionMustBeConst.
7411 * const.cs, class.cs, statement.cd: Update.
7413 2005-07-21 Marek Safar <marek.safar@seznam.cz>
7417 * const.cs (Const.LookupConstantValue): Report missing contant expression
7419 (Error_EpressionMustBeConstant): Only one error method.
7421 * class.cs, statement.c: Updated.
7423 2005-07-20 Raja R Harinath <rharinath@novell.com>
7425 * statement.cs (Block.Flags): Add back HasVarargs.
7426 (Block.flags): Make protected.
7427 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
7429 * typemanager.cs (types, typecontainers, user_types): Remove.
7430 (UserTypes, TypeContainers): Likewise.
7431 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
7432 (CleanUp, Reset): Update.
7433 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
7434 (GetNestedType): Use Type.GetNestedType.
7435 (CoreLookupType): Take two arguments, the namespace and the
7436 basename of the type. Update to use the Namespace.Lookup
7438 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
7439 (RealMemberLookup): Use IsNestedChildOf instead of playing with
7440 string concatenation and substring matches.
7441 * class.cs, enum.cs, delegate.cs: Update to changes.
7443 2005-07-20 Marek Safar <marek.safar@seznam.cz>
7445 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
7446 Expression and made virtual.
7448 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
7449 (ImplicitStandardConversionExists): Fixed `byte' typo ?
7451 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
7453 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
7456 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
7459 2005-07-18 Marek Safar <marek.safar@seznam.cz>
7462 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
7463 AssemblyCultureAttribute is not used on executable.
7466 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
7468 2005-07-16 Raja R Harinath <rharinath@novell.com>
7471 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
7472 New. Reports CS0252/CS0253.
7473 Mostly taken from preliminary patch by Duncak Mak.
7474 (Binary.DoResolveOperator): Store results of operator lookup.
7475 Use them to detect if we need to warn about unintended reference
7478 2005-07-15 Raja R Harinath <rharinath@novell.com>
7481 * namespace.cs (Namespace.Lookup): Add back location parameter.
7482 (Namespace.LookupType): Add CS0436 report. Add location parameter.
7483 * delegate.cs, ecore.cs, expression.cs: Update to changes.
7485 * codegen.cs (EmitContext.DeclSpace): Make readonly.
7486 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
7487 (Namespace.LookupType): ... this.
7488 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
7490 * typemanager.cs (LookupTypeReflection): Remove buggy code that
7491 purported to handle pointers.
7492 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
7495 2005-07-15 Marek Safar <marek.safar@seznam.cz>
7497 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
7500 2005-07-15 Raja R Harinath <rharinath@novell.com>
7502 * namespace.cs (Namespace.Lookup): Drop location parameter.
7503 (NamespaceEntry.LookupAlias): Remove. Merge into ...
7504 (NamespaceEntry.Lookup): ... this.
7505 (NamespaceEntry.Error_AmbiguousTypeReference):
7506 Move here from DeclSpace.
7507 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
7509 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
7510 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
7511 Move to NamespaceEntry.
7512 * delegate.cs, expression.cs: Update to changes.
7514 2005-07-14 Marek Safar <marek.safar@seznam.cz>
7516 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
7517 CheckAttributeType and refactored.
7518 (Attribute.ResolvePossibleAttributeType): Changed to reuse
7519 ResolveAsTypeTerminal error handling.
7520 (ResolveAsTypeTerminal): Introduced because of global attributes extra
7522 (GetSignatureForError): Print errors in same way.
7525 * codegen.cs: Reflect attribute GetSignatureForError change.
7528 * expression.cs: Add silent parameter to ResolveAsTypeStep.
7530 * namespace.cs (UsingEntry): Refactored to make fields private.
7533 statement.cs: Error_UnexpectedKind has extra parameter.
7535 2005-07-14 Raja R Harinath <rharinath@novell.com>
7537 * ecore.cs (IAlias): Remove.
7538 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
7539 that implement the interface.
7540 * namespace.cs (Namespace): Likewise.
7541 (Namespace.declspaces): Renamed from 'defined_names'.
7542 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
7543 DeclSpace instead of an IAlias.
7544 * tree.cs (Tree.AddDecl): Update.
7546 2005-07-12 Raja R Harinath <rharinath@novell.com>
7548 * statement.cs (Block.Flags); Remove HasVarargs.
7549 (Block.HasVarargs): Move to ToplevelBlock.
7550 (Block.ThisVariable, Block.AddThisVariable): Likewise.
7551 (Block.Variables): Make protected. Initialize variable hashtable
7553 (Block.AddVariable): Update.
7554 (Block.Resolve): Update to changes.
7555 (ToplevelBlock.HasVarargs): New boolean.
7556 (ToplevelBlock.ThisVariable): Move here from Block.
7557 (ToplevelBlock.AddThisVariable): Likewise.
7558 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
7559 * expression.cs (This.ResolveBase): Update to changes.
7560 (ArglistAccess.DoResolve): Likewise.
7562 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7565 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
7567 * class.cs (TypeContainer.VerifyMembers): Distinguish between
7568 not used and not used & assigned.
7569 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
7571 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7574 * expression.cs (Is.DoResolve): null is never provided type.
7576 2005-07-08 Marek Safar <marek.safar@seznam.cz>
7579 * cs-parser.jay: Less strict event error rule to catch more errors.
7581 2005-07-08 Martin Baulig <martin@ximian.com>
7583 Fix test-iter-10.cs - distinguish whether we `yield' in a property
7584 gettter (allowed) or setter (not allowed).
7586 * class.cs (Accessor): Implement IIteratorContainer.
7587 (Accessor.Yields): New public field.
7588 (PropertyBase.PropertyMethod.Define): Handle iterators on a
7592 (get_accessor_declaration, set_accessor_declaration): Set the
7593 `yields' flag on the accessor, not the property.
7594 (property_declaration): Do the iterators check on a per-accessor
7595 basis and not for the whole property.
7597 2005-07-08 Martin Baulig <martin@ximian.com>
7599 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
7600 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
7602 2005-07-07 Marek Safar <marek.safar@seznam.cz>
7605 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
7606 (ExtractSecurityPermissionSet): Cope with self referencing security
7607 attributes properly.
7609 * driver.cs (SetOutputFile): Made public property OutputFile.
7611 2005-07-07 Raja R Harinath <rharinath@novell.com>
7614 * class.cs (TypeContainer.first_nonstatic_field): Rename from
7615 has_nonstatic_fields. Make into a FieldBase pointer.
7616 (TypeContainer.AddField): Add CS0282 check.
7617 (TypeContainer.EmitType): Update.
7619 2005-07-06 Miguel de Icaza <miguel@novell.com>
7621 * cs-tokenizer.cs (consume_identifier): Do not create strings to
7622 compare if they start with __.
7624 2005-07-06 Raja R Harinath <rharinath@novell.com>
7626 * statement.cs (Switch.SwitchGoverningType): Only look at
7627 UserCasts that don't need implicit standard conversions to one of
7628 the allowed switch types (Fixes test-322.cs).
7629 (LocalInfo.Resolve): Re-enable sanity-test.
7631 2005-07-06 Marek Safar <marek.safar@seznam.cz>
7633 * cs-tokenizer.cs (consume_identifier): Detect double undescores
7635 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
7637 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
7639 2005-07-06 Raja R Harinath <rharinath@novell.com>
7642 * ecore.cs (SimpleName.GetSignatureForError): Add.
7643 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
7644 (MemberAccess.GetSignatureForError): Add.
7646 2005-07-05 Marek Safar <marek.safar@seznam.cz>
7648 The big error and warning messages review.
7678 * typemanager.cs: Updated.
7680 * class.cs: (MethodCore.SetYields): Moved here to share.
7681 (PropertyMethod.Define): Moved iterator setup here.
7683 * iterators.cs: Add orig_method to have full access to parent
7686 2005-07-05 Raja R Harinath <rharinath@novell.com>
7688 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
7689 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
7690 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
7691 variable of struct type.
7692 * expression.cs (Unary.ResolveOperator): Update to change.
7693 (Indirection.VerifyFixed): Likewise.
7694 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
7695 (ParameterReference.VerifyFixed): Value parameters are fixed.
7696 (This.VerifyFixed): Treat 'this' as a value parameter.
7697 * statement.cs (LocalInfo.IsFixed): Remove.
7699 2005-07-01 Martin Baulig <martin@ximian.com>
7701 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
7702 `ec.EmitThis ()' to get the correct scope.
7704 2005-07-01 Martin Baulig <martin@ximian.com>
7706 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
7707 instance is a ParameterReference; fixes #75299.
7709 2005-07-01 Martin Baulig <martin@ximian.com>
7711 Reverted Marek's latest patch (r46725):
7712 - it contains structural changes which are neither mentioned in
7713 the ChangeLog nor explained anywhere; for example the additional
7714 argument of EmitContext's and Iterator's .ctor's and the
7715 TypeContainer.DefineMembers() change.
7716 - structural changes like this should go in in seperate patches
7717 and not be hidden in a huge patch which just seems to affect
7718 warnings and errors.
7719 a big and hard to understand patch.
7720 - it breaks iterators and causes regressions, for instance in
7723 2005-06-30 Raja R Harinath <rharinath@novell.com>
7726 * expression.cs (Indexers.map): Remove.
7727 (Indexers.Append): Filter out inaccessible setters and getters.
7728 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
7731 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
7733 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
7734 (FieldExpr.Emit, PropertyExpr.Emit): Update.
7735 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
7736 * expression.cs (Invocation.EmitCall): Add CS0120 check.
7738 2005-06-30 Marek Safar <marek.safar@seznam.cz>
7741 * class.cs (FieldBase.GetInitializerExpression): One more field
7744 2005-06-28 Miguel de Icaza <miguel@novell.com>
7746 * pending.cs: Do not define a proxy if the base method is virtual,
7747 it will be picked up by the runtime (bug 75270).
7749 2005-06-08 Martin Baulig <martin@ximian.com>
7751 The big Iterators rewrite :-)
7753 * iterators.cs: Rewrite this to use the anonymous methods framework.
7755 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
7756 before the TypeContainers; see 2test-21.cs.
7759 (TypeContainer.DefineType): Don't create a new EmitContext if we
7760 already have one (this only happens if we're an Iterator).
7761 (TypeContainer.Define): Also call Define() on all our iterators.
7762 (Method.CreateEmitContext): Added support for iterators.
7765 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
7766 (AnonymousContainer.CreateMethodHost): Moved here from
7767 AnonymousMethod and made abstract.
7768 (AnonymousContainer.CreateScopeType): New abstract method.
7769 (AnonymousContainer.IsIterator): New public property.
7770 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
7771 get the ScopeTypeBuilder rather than manually defining it here.
7772 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
7775 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
7776 before RootContext.DefineTypes().
7778 * codegen.cs (EmitContext.RemapToProxy): Removed.
7779 (EmitContext.CurrentAnonymousMethod): Changed type from
7780 AnonymousMethod -> AnonymousContainer.
7781 (EmitContext.ResolveTopBlock): Protect from being called twice.
7782 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
7783 (EmitContext.EmitThis): Removed the iterators hacks; use the
7784 anonymous methods framework for that.
7787 (ToplevelBlock.Container): Make this a property, not a field.
7788 (ToplevelBlock.ReParent): New public method; move the
7789 ToplevelBlock into a new container.
7790 (Foreach.TemporaryVariable): Simplify.
7792 2005-06-05 Martin Baulig <martin@ximian.com>
7794 * statement.cs (LocalInfo.CompilerGenerated): New flag.
7795 (Block.AddTemporaryVariable): New public method; creates a new
7796 `LocalInfo' for a temporary variable.
7797 (Block.EmitMeta): Create the LocalBuilders for all the temporary
7799 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
7800 non-iterator variables.
7802 2005-06-05 Martin Baulig <martin@ximian.com>
7804 * statement.cs (Foreach.TemporaryVariable): Create the
7805 LocalBuilder in the Emit phase and not in Resolve since in some
7806 situations, we don't have an ILGenerator during Resolve; see
7807 2test-19.cs for an example.
7809 2005-06-04 Martin Baulig <martin@ximian.com>
7811 **** Merged r45395 from GCS ****
7813 The big Foreach rewrite - Part II.
7815 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
7816 with `PropertyInfo ienumerator_getcurrent'.
7818 * codegen.cs (VariableStorage): Removed.
7821 (Foreach): Derive from Statement, not ExceptionStatement.
7822 (Foreach.CollectionForeach): New nested class. Moved all the code
7823 dealing with collection foreach here.
7824 (Foreach.ForeachHelperMethods): Removed.
7825 (Foreach.TemporaryVariable): Implement IMemoryLocation.
7827 2005-05-23 Martin Baulig <martin@ximian.com>
7829 * statement.cs (Try.DoResolve): Don't create a `finally' if we
7830 don't need to. Fix #75014.
7832 2005-05-20 Martin Baulig <martin@ximian.com>
7834 Merged r44808 from GMCS.
7836 * class.cs (TypeContainer.CircularDepException): Removed.
7837 (TypeContainer.DefineType): Removed the `InTransit' stuff.
7838 (TypeContainer.CheckRecursiveDefinition): Check for circular class
7839 (CS0146) and interface (CS0529) dependencies here.
7841 2005-06-21 Raja R Harinath <rharinath@novell.com>
7843 * expression.cs (Invocation.EmitCall): Fix initialization
7844 'this_call' to reflect current behaviour. Fix indentation.
7846 * convert.cs (FindMostEncompassedType): Add two trivial special
7847 cases (number_of_types == 0 || number_of_types == 1).
7848 (FindMostEncompasingType): Likewise.
7850 2005-06-17 Raja R Harinath <rharinath@novell.com>
7852 Some cleanups preparing for the fix of #75283.
7853 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
7855 (EventExpr.InstanceResolve): Likewise.
7856 (EventExpr.DoResolve): Remove redundant checks.
7858 2005-06-10 Duncan Mak <duncan@novell.com>
7860 * cs-tokenizer.cs (process_directives): New flag for controlling
7861 the processing of preprocessor directives.
7862 (x_token): After seeing a '#', return Token.NONE instead of going
7863 to handle_preprocessing_directive() when not processing
7864 directives. This avoids unnecessary processing during the token peek in
7869 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
7870 the existing error reporting methods instead of Report.Error.
7872 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
7873 after Raja's rewrite.
7875 2005-06-08 Miguel de Icaza <miguel@novell.com>
7877 * class.cs: Small fix.
7879 2005-06-08 Raja R Harinath <rharinath@novell.com>
7882 * class.cs (GetPartialBases): Fix return value check of
7885 2005-06-07 Raja R Harinath <rharinath@novell.com>
7887 Ensure that partial classes are registered in their enclosing
7888 namespace. Initial part of fix of #75160.
7889 * tree.cs (Tree.RecordDecl): Add new namespace argument.
7890 Register declspace with namespace here, not in
7891 DeclSpace.RecordDecl.
7892 * cs-parser.jay: Pass namespace to RecordDecl.
7893 * class.cs (PartialContainer.Create): Likewise.
7894 (ClassPart.DefineType): New sanity-check. Throws an exception if
7896 * decl.cs (Declspace.RecordDecl): Remove.
7897 * namespace.cs (NamespaceEntry.DefineName): Remove.
7899 2005-06-06 Marek Safar <marek.safar@seznam.cz>
7901 * rootcontext.cs: Reset TargetExt as well.
7903 2005-06-03 Raja R Harinath <rharinath@novell.com>
7905 * ecore.cs (Expression.Resolve): Emit CS0654 error when
7908 2005-06-02 Raja R Harinath <rharinath@novell.com>
7910 Fix #75080, cs0119.cs.
7911 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
7913 (Expression.Resolve): ... this. Use it. Remove bogus code
7914 allowing ExprClass.Type and ExprClass.Namespace for
7915 ResolveFlags.VariableOrValue.
7916 (Expression.Resolve) [1-argument variant]: Change default resolve
7917 flags based on language version.
7918 (Expression.Error_UnexpectedKind): Use a simple string array
7919 rather than an ArrayList.
7920 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
7922 (TypeOfVoid.DoResolve): Likewise.
7923 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
7924 flags argument -- it always has the same value.
7926 2005-05-31 Raja R Harinath <rharinath@novell.com>
7929 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
7930 Use it in the error message.
7931 * assign.cs, expression.cs, statement.cs: Update.
7933 2005-05-30 Raja R Harinath <rharinath@novell.com>
7936 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
7937 the "almostMatchedMember" case too.
7938 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
7939 that failed the accessibility checks to 'almost_match'.
7941 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
7943 * attribute.cs: Use internal MethodBuilder methods to set
7944 ExactSpelling and SetLastError on PInvoke methods, instead
7945 of passing them via charset. Fixes #75060.
7947 2005-05-27 Raja R Harinath <rharinath@novell.com>
7949 * parameter.cs (Parameter): Remove TODO comment.
7950 (Parameter.DefineParameter): Remove Location parameter.
7951 (Parameters.LabelParameters): Likewise.
7952 * class.cs (Constructor.Emit): Update to change.
7953 (MethodData.Emit): Likewise.
7954 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
7955 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
7957 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
7960 Removed Parameters.Location and added Parameter.Location instead.
7961 Removed Location parameter from Emit() and GetSignature().
7968 Modified all related calls.
7970 2005-05-26 Raja R Harinath <rharinath@novell.com>
7972 Improve user-defined conversion handling.
7973 * convert.cs (GetConversionOperators): Rewrite. Return only the
7974 applicable operators.
7975 (AddConversionOperators): New. Helper for GetConversionOperators.
7976 (FindMostEncompassedType, FindMostEncompassingType): Verify that
7977 there is only one most encompassed/encompassing type.
7978 (FindMostSpecificSource, FindMostSpecificTarget): Remove
7979 "applicable operator" handling.
7980 (UserConversion): Move cache here from GetConversionOperators.
7981 Directly cache the chosen operator, rather than the whole
7983 (ExplicitNumericConversion): Fix buggy implementation of Decimal
7984 case. Allow conversion of decimal to sbyte and byte too.
7985 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
7986 New static methods. Used to avoid allocating EmptyExpressions in
7989 2005-05-24 Duncan Mak <duncan@novell.com>
7991 * ecore.cs (CastFromDecimal): New class for casting a decimal to
7992 another class, used in Convert.ExplicitNumericConversion.
7993 (CastToDecimal): New class, similar to above, but casts to
7994 System.Decimal, used in Convert.ImplicitNumericConversion and also
7995 in explicit convesion from double/float to decimal.
7997 * convert.cs (ImplicitNumericConversion): Handle implicit
7998 conversions to System.Decimal.
7999 (ExplicitNumericConversion): handle explicit conversions to
8004 2005-05-20 Miguel de Icaza <miguel@novell.com>
8006 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
8007 know the type at this stage, just break through. Fixes #75008
8009 2005-05-19 Martin Baulig <martin@ximian.com>
8012 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
8013 to disable error reporting.
8015 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
8016 here since we don't want to report an error; see the new test-336.cs.
8018 2005-05-19 Raja R Harinath <rharinath@novell.com>
8020 * statement.cs (ToplevelBlock.GetParameterReference)
8021 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
8022 Move here from class Block.
8023 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
8024 * expression.cs (ParameterReference.DoResolveBase): Likewise.
8026 2005-05-18 Martin Baulig <martin@ximian.com>
8031 (FlowBranching.Reachability): Add non-static public And() and Or()
8033 (FlowBranchingSwitch): New class; do the `break_origins' thing
8034 like in FlowBranchingLoop.
8035 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
8036 reachability, not just locals and parameters.
8037 (FlowBranching.MergeChild): Remove some of the hacks for loop and
8038 switch; MergeBreakOrigins() now takes care of that.
8040 2005-05-18 Martin Baulig <martin@ximian.com>
8042 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
8043 a loop and may leave it, reset the barrier; fixes #74974.
8045 2005-05-17 Marek Safar <marek.safar@seznam.cz>
8047 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
8050 * cs-parser.jay: Catch more lexical errors.
8052 * report.cs: Add one more Error method.
8055 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
8057 2005-05-17 Martin Baulig <martin@ximian.com>
8059 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
8062 2005-05-16 Raja R Harinath <rharinath@novell.com>
8064 Fix test-382.cs. Emit values of decimal constants.
8065 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
8067 (TypeContainer.AddField): ... this.
8068 (TypeContainer.EmitFieldInitializers): Allow the list of fields
8069 with initializers to include 'Const's.
8070 (ClassPart.RegisterFieldForInitialization): Forward to
8072 * const.cs (Const.Const): Pass initializer to base class.
8073 (Const.Define): In case of decimal constants, register them for
8074 initialization in a static constructor.
8076 2005-05-14 Martin Baulig <martin@ximian.com>
8078 * statement.cs (Block.Resolve): Correctly handle unreachable code;
8079 do not call ResolveUnreachable() on unreachable statements in
8080 here, see the comment in the source code.
8082 2005-05-13 Raja R Harinath <rharinath@novell.com>
8085 * expression.cs (BinaryResolveOperator): If one of the operands of
8086 an equality comparison is 'null' and the other is a pointer type,
8087 convert the null to a NullPointer.
8088 * convert.cs (ImplicitReferenceConversion): If the expression is a
8089 NullLiteral and the target type is a pointer type, return a
8090 NullPointer instead.
8091 (ImplicitConversionStandard): Likewise.
8093 2005-05-13 Marek Safar <marek.safar@seznam.cz>
8095 * cs-parser.jay: Set readonly context based on special constructs.
8097 * expression.cs (LocalVariableReference.DoResolveBase): Improved
8098 readonly variable error handling.
8100 * rootcontext.cs (EmitCode): Don't verify members when error
8103 * statement.cs (LocalInfo): Add reaodnly context information.
8104 (SetReadOnlyContext, GetReadOnlyContext): New methods.
8106 2005-05-13 Raja R Harinath <rharinath@novell.com>
8108 * statement.cs (Block.Resolve): Revert change below. Modify fix
8109 for #74041 to initialize 'resolved' to false only for explicit
8110 blocks. Fixes #74873.
8112 2005-05-12 Raja R Harinath <harinath@gmail.com>
8115 * typemanager.cs (unmanaged_enclosing_types): New.
8116 (IsUnmanagedType): Avoid infloops by using
8117 'unmanaged_enclosing_types' to talk with recursive invocations.
8119 2005-05-13 Martin Baulig <martin@ximian.com>
8121 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
8122 instance variable, not a local. Fix #74873.
8123 (Block.ResolveUnreachable): Set it to true here.
8125 2005-05-11 Duncan Mak <duncan@novell.com>
8127 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
8128 continuing to process for 'arg'.
8129 (handle_preprocessing_directive): Check the argument of the #endif
8130 directive and report error CS1025 if there are any trailing
8133 According to the C# spec, having even whitespace after the #endif
8134 directive is illegal; however, because we call arg.TrimEnd ()
8135 beforehand, we have the same behavior as csc, allowing whitespace
8136 after the directive.
8140 2005-05-11 Marek Safar <marek.safar@seznam.cz>
8144 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
8145 (Constructor.GetObsoleteAttribute): Implemented correctly.
8147 2005-05-10 Martin Baulig <martin@ximian.com>
8149 * support.cs (ReflectionParameters.ParameterModifier): Use
8150 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
8151 and `ParameterAttributes.In'. Fixes #74884.
8153 2005-05-10 Marek Safar <marek.safar@seznam.cz>
8155 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
8157 * expression.cs (Argument.GetParameterModifier): Turned to property.
8158 (Invocation.Error_InvalidArguments): Add more descriptive errors.
8160 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
8163 2005-05-09 Raja R Harinath <rharinath@novell.com>
8166 * decl.cs (MemberCache.AddMethods): Register override methods,
8167 rather than non-override methods.
8168 * typemanager.cs (RegisterOverride): New.
8169 (IsOverride): Update.
8171 2005-05-09 Marek Safar <marek.safar@seznam.cz>
8175 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
8176 recursive declaration.
8178 * statement.cs (Block.ResolveMeta): Report any error in resolving.
8180 2005-05-06 Marek Safar <marek.safar@seznam.cz>
8182 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
8184 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
8186 2005-05-05 Raja R Harinath <rharinath@novell.com>
8189 * decl.cs (DeclSpace.FamilyAccessible):
8190 Use TypeManager.IsNestedFamilyAccessible.
8192 Fix reopened #64812.
8193 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
8196 2005-05-04 Raja R Harinath <rharinath@novell.com>
8197 Abin Thomas <projectmonokochi@rediffmail.com>
8198 Anoob V E <projectmonokochi@rediffmail.com>
8199 Harilal P R <projectmonokochi@rediffmail.com>
8202 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
8203 allow access to all static members.
8205 2005-05-04 Martin Baulig <martin@ximian.com>
8207 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
8209 2005-05-04 Martin Baulig <martin@ximian.com>
8213 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
8214 section at the end; make things work if `default' is not the last
8217 2005-05-04 Martin Baulig <martin@ximian.com>
8221 * statement.cs (Switch): Replaced the `got_default' field with a
8222 `default_section' one.
8223 (Switch.CheckSwitch): Set `default_section' here.
8224 (Switch.Resolve): If we're a constant switch and the constant is
8225 not found, use the default section.
8227 2005-05-03 Martin Baulig <martin@ximian.com>
8229 * expression.cs (ArrayAccess.EmitGetLength): New public method.
8231 * statement.cs (Foreach.ArrayForeach): New nested class.
8232 (Foreach.TemporaryVariable): New nested class.
8233 (Foreach.EmitArrayForeach): Removed; this is now in the new
8236 2005-05-03 Raja R Harinath <rharinath@novell.com>
8238 * pending.cs (BaseImplements): Move the #74773 fix here. This is
8240 (VerifyPendingMethods): Revert change below.
8242 * typemanager.cs (IsOverride, RegisterNonOverride): New.
8243 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
8244 that used to trigger warning -28. Remove warning -28.
8245 * expression.cs (Invocation.OverloadResolve): Use
8246 TypeManager.IsOverride to distinguish override methods.
8249 * pending.cs (VerifyPendingMethods): If a base type implements the
8250 requested interface, don't bother checking individual methods of
8251 the base type. As a side-effect, this prevents the creation of
8252 unnecessary proxies.
8254 2005-05-02 Martin Baulig <martin@ximian.com>
8258 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
8259 Also `And' the locals if the old vector is null.
8260 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
8261 null; in this case we basically reset all the variables.
8263 2005-05-02 Martin Baulig <martin@ximian.com>
8267 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
8268 Added `FlowBranching branching' argument; always `and' the
8269 variables instead of `or'ing them unless we're an infinite loop.
8271 * statement.cs (While.Resolve): Create a new sibling unless we're
8274 2005-05-02 Martin Baulig <martin@ximian.com>
8278 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
8279 arguments; use it instead of creating a new TopLevelBlock.
8280 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
8281 our ConstructorInitializer.
8284 (TopLevelBlock.TopLevelBranching): New public property.
8285 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
8286 and create our `TopLevelBranching'.
8288 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
8289 anonymous method host, use `block.TopLevelBranching' rather than
8290 creating a new branching.
8292 2005-04-20 Miguel de Icaza <miguel@novell.com>
8294 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
8295 a ScopeInfo, if any of the current children is a child of the new
8296 entry, move those children there.
8298 2005-04-30 Martin Baulig <martin@ximian.com>
8300 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
8301 at the beginning of a SwitchSection. Fix #73335.
8303 2005-04-27 Marek Safar <marek.safar@seznam.cz>
8306 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
8308 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
8309 (FieldExpr.DoResolve): Obsolete members are ignored for field
8312 2005-04-26 Marek Safar <marek.safar@seznam.cz>
8314 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
8315 of arrays detection.
8317 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
8319 (Field.VerifyClsCompliance): Volatile fields are not compliant.
8321 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
8324 2005-04-25 Ben Maurer <bmaurer@ximian.com>
8326 * cs-parser.jay: Use the prefered version of -unsafe in error
8329 2005-04-22 Marek Safar <marek.safar@seznam.cz>
8331 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
8334 2005-04-20 John Luke <john.luke@gmail.com>
8336 * driver.cs: fix typo in error message, --outout to --output
8338 2005-04-20 Marek Safar <marek.safar@seznam.cz>
8340 * codegen.cs (InRefOutArgumentResolving): New field.
8342 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
8343 fields outside contructor.
8345 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
8347 2005-04-19 Miguel de Icaza <miguel@novell.com>
8349 * anonymous.cs (CaptureContext.EmitParameterInstance): The
8350 parameter code was not completed ever, so it was not as up-to-date
8351 as local variables. Must finish it.
8353 The bug fix was to compare the Toplevel of the block, not the
8354 current block. Thanks for Ben for pointing this out.
8356 2005-04-19 Raja R Harinath <rharinath@novell.com>
8358 * decl.cs (AddMethods): Use the declaring type of the problem
8359 method to determine if we want to squash a warning.
8361 2005-04-19 Marek Safar <marek.safar@seznam.cz>
8363 * attribute.cs: Removed debug output.
8365 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
8367 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
8370 2005-04-18 Raja R Harinath <rharinath@novell.com>
8373 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
8374 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
8375 all null comparisons against reference types.
8377 2005-04-18 Marek Safar <marek.safar@seznam.cz>
8380 * class.cs (TypeContainer.CircularDepException) New nested
8382 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
8383 (TypeContainer.DefineType): Removed error, reset InTransit before
8385 (Class.DefineType): Throw exception when is in Transit.
8386 Catch exception and report error.
8387 (Struct.DefineType): Throw exception when is in Transit.
8388 Catch exception and report error.
8389 (Interface.DefineType): Throw exception when is in Transit.
8390 Catch exception and report error.
8392 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
8393 handle nested exception handlers.
8395 * flowanalysis.cs (InTryWithCatch): New method, search for try with
8398 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
8399 InFinally and InCatch storage.
8401 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
8402 (Catch.Resolve): Set and Restore ec.InCatch.
8403 (Try.Resolve): Set and Restore ec.InFinally.
8404 (Try.HasCatch): True when try has catch.
8406 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
8408 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
8409 for the same event member, so exclude such cases from warning 419.
8412 2005-04-16 Miguel de Icaza <miguel@novell.com>
8414 * expression.cs (Binary.ResolveOperator): Apply patch from John
8415 Luke to fix bug 59864: operators &, | and ^ on enumerations
8416 require that the same enum type on both sides.
8418 * driver.cs: Add warnings to old flag usage, this is to assist
8419 people who produce Makefiles and hope that the Makefiles will be
8422 * class.cs (TypeContainer.EmitType): Moved the definition of the
8423 special $PRIVATE$ field from the resolve phase to the Emit phase.
8424 During resolve we do not know if we are a struct with
8425 HasExplicitLayout, we know this only after the attributes for the
8428 Set the FieldOffset to zero on the dummy field that we create for
8429 the class. Fixes 74590.
8431 2005-04-16 Raja R Harinath <rharinath@novell.com>
8434 * ecore.cs (PropertyExpr.resolved): New.
8435 (DoResolve): Use it to handle a case of double resolution here.
8436 Handle a case of identical-name-and-type-name.
8437 * expression.cs (ArrayCreation.CheckIndices): Avoid double
8438 resolution by storing the results of expression resolution back
8439 into the "probes" array.
8441 2005-04-15 Raja R Harinath <rharinath@novell.com>
8443 Fix cs0208-7.cs and cs0208-8.cs.
8444 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
8445 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
8446 error reporting to point out the reason a struct is not unmanaged.
8448 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8450 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
8451 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
8453 2005-04-13 Raja R Harinath <rharinath@novell.com>
8456 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
8457 IdenticalNameAndTypeName here.
8458 (EventExpr.InstanceResolve): Likewise.
8460 2005-04-13 Marek Safar <marek.safar@seznam.cz>
8462 C# 2.0 DefaultCharSetAttribute implementation
8464 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
8465 which allows us to set GlobalNamespace for every resolve.
8466 (Attribute.ResolveArguments): Cut from Resolve.
8467 (Attribute.GetCharSetValue): Returns CharSet named argument.
8468 (Attribute.DefinePInvokeMethod): Gets default charset from
8470 (GlobalAttribute.ResolveAsTypeStep): Override.
8471 (GlobalAttribute.ResolveArguments): Override.
8473 * class.cs (TypeAttr): Is protected.
8475 * codegen.cs (ModuleClass.DefaultCharSet): New member.
8476 (ModuleClass.DefaultCharSetType): New memeber.
8477 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
8479 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
8480 charset from module.
8482 * delegate.cs (TypeAttr): Override.
8483 (Delegate.DefineType): Use this TypeAttr.
8485 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
8486 at very early stage (before types are defined) to resolve model
8487 module attributes. It will probably not work with corlib but it
8490 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
8491 charset from module.
8493 * typemanager.cs (default_charset_type): New type.
8495 2005-04-13 Raja R Harinath <rharinath@novell.com>
8497 * decl.cs (MemberCache.AddMethods): Don't warn if
8498 System.Object.Finalize has buggy MethodAttributes.
8500 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
8503 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8505 * doc.cs : detect ambiguous reference to overloaded members.
8506 Fixed bug #71603. MS 1.1 csc does not detect it.
8508 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8510 * doc.cs : delegates must not be referenced with parameters.
8513 2005-04-12 Miguel de Icaza <miguel@novell.com>
8515 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
8517 2005-04-10 Miguel de Icaza <miguel@novell.com>
8519 * driver.cs (MainDriver): Stop processing if the CLS stage found
8522 (CompilerCallableEntryPoint.InvokeCompiler): Always
8523 reset after execution; Take a TextWriter argument for the
8526 * report.cs: Use the error stream instead of hardcoding stderr.
8528 2005-04-09 Miguel de Icaza <miguel@novell.com>
8530 * class.cs: Reduce code paths to test, too small of an
8531 optimization to make it worth the extra testing. Always perform
8534 2005-04-08 Raja R Harinath <rharinath@novell.com>
8537 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
8538 operators that had errors reported on them.
8540 2005-04-08 Marek Safar <marek.safar@seznam.cz>
8542 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
8544 (Attribute.Resolve): Add named argument type checking.
8546 * class.cs (FixedField.Define): Use IsPrimitiveType
8548 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
8550 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
8551 unsafe parameter types.
8553 * statement.cs (Using.ResolveExpression): Add better error description.
8555 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
8557 2005-04-08 Raja R Harinath <rharinath@novell.com>
8560 * attribute.cs (Attribute.GetAttributeUsage): Resolve
8561 AttributeUsageAttribute in the emitcontext of the attribute class,
8562 not in the emitcontext of the attributable entity it was attached to.
8563 * cs-parser.jay: Use 'current_class', not 'current_container',
8564 when creating a GlobalAttribute.
8566 2005-04-08 Alp Toker <alp@atoker.com>
8568 * pending.cs: The fix to #58413 failed to compile methods implementing
8569 interfaces with/without params modifiers and vice versa, even though
8570 params modifiers aren't part of the signature. Make the modifier check
8571 less strict as in csc.
8573 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
8574 Anoob V E <projectmonokochi@rediffmail.com>
8575 Harilal P R <projectmonokochi@rediffmail.com>
8578 * pending.cs (TypeAndMethods.mods): New. Store the parameter
8579 modifiers of pending methods.
8580 (PendingImplementation.PendingImplementation): Initialize it.
8581 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
8582 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
8583 with ParameterData. Add check for modifiers.
8584 * class.cs (MethodData.Define): Update to changes.
8586 2005-04-07 Raja R Harinath <rharinath@novell.com>
8588 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
8590 2005-04-07 Marek Safar <marek.safar@seznam.cz>
8592 * class.cs (PropertyMethod.Define): Check private accessor in abstract
8595 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
8598 * typemanager.cs: Registered RequiredAttributeAttribute.
8600 2005-04-06 Marek Safar <marek.safar@seznam.cz>
8602 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
8603 Warning CS0169 is back at level 3.
8604 (IMethodData.SetMemberIsUsed): New method.
8606 * decl.cs (IsUsed): New value; moved from FieldBase.Status
8607 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
8609 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
8611 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
8613 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
8616 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
8619 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
8620 to avoid the problems with nested types.
8622 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
8623 Anoob V.E <projectmonokochi@rediffmail.com>
8624 Harilal P.R <projectmonokochi@rediffmail.com>
8625 Raja R Harinath <rharinath@novell.com>
8628 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
8630 * typemanager (GetConstructor): Make public.
8632 2005-04-05 John Luke <john.luke@gmail.com>
8633 Raja R Harinath <rharinath@novell.com>
8636 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
8637 struct too. Return false quicker in a few cases.
8638 (VerifyUnManaged): Use it.
8640 2005-04-05 Raja R Harinath <rharinath@novell.com>
8643 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
8644 not 'unreachable_seen'.
8646 2005-04-04 Marek Safar <marek.safar@seznam.cz>
8648 * attribute.cs (Attribute.GetValue): Removed unused.
8650 * codegen.cs (CodeGen.TrimExt): Removed unused.
8652 * cs-parser.jay (output): Removed unused.
8654 * cs-tokenizer.cs (hex_digits): Removed unused.
8656 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
8658 * expression.cs (Indirection.LoadExprValue): Removed unused.
8659 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
8661 * iterators.cs (Iterator.param_types): Removed unused.
8663 * statement.cs (Goto.block): Removed unused.
8664 (ToplevelBlock.did): Removed unused.
8665 (Switch.ResolveConstantSwitch): Removed unused.
8667 2005-04-01 Ben Maurer <bmaurer@ximian.com>
8669 * rootcontext.cs: Allow mcs to bootstrap with the compilation
8672 2005-04-01 Raja R Harinath <rharinath@novell.com>
8674 Fix #74232 and cs0208-3.cs.
8675 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
8676 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
8677 unmanaged type. Don't use FieldBuilders when 't' is a
8678 TypeBuilder. Use ModFlags and MemberType fields.
8679 * class.cs (MemberBase.member_type): Rename from MemberType.
8680 (MemberBase.MemberType): New property. Determines member_type on
8682 (MemberBase.DoDefine): Don't initialize MemberType here.
8683 (FieldMember.Define): Likewise.
8685 2005-04-01 Marek Safar <marek.safar@seznam.cz>
8688 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
8689 Attributes are emitted there.
8691 2005-04-01 Raja R Harinath <rharinath@novell.com>
8693 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
8694 keyword in 'partial enum' too.
8695 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
8697 Report from Kamil Skalski <nazgul@omega.pl>.
8700 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
8701 have partial containers too.
8703 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
8704 in block' checks to Block.CheckInvariantMeaningInBlock.
8705 * statement.cs (Block.GetKnownVariableInfo): Make private.
8706 (Block.IsVariableUsedInChildBlock): Remove.
8707 (Block.IsVariableUsedInBlock): Likewise.
8708 (Block.CheckInvariantMeaningInBlock): New. Show location of
8709 conflicting declaration.
8710 (Block.AddVariable): Make error messages less long-winded and more
8711 specific. Show location of conflicting declaration.
8712 * parameter.cs (Parameters.Location): New readonly property.
8714 2005-03-31 Raja R Harinath <rharinath@novell.com>
8716 Clean up semantics of invoking ResolveMemberAccess.
8717 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
8718 can have an instance, ensure that we pass in a non-TypeExpression
8719 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
8720 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
8721 argument. Update to changes and simplify.
8722 (FieldExpr.Emitinstance): Remove CS0120 check.
8723 (PropertyExpr.EmitInstance): Likewise.
8724 * expression.cs (Argument.Resolve): Likewise.
8725 (Invocation.DoResolve): Update to changes in semantics of
8728 2005-03-31 Marek Safar <marek.safar@seznam.cz>
8731 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
8734 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
8736 2005-03-31 Raja R Harinath <rharinath@novell.com>
8738 Fix difference in behaviour with commandline invocation.
8739 * driver.cs (Driver.Reset): New.
8740 (CompilerCallableEntryPoint): Call it.
8742 * statement.cs (If.Resolve): Avoid spurious "uninitialized
8743 variable" warnings if the boolean expression failed to resolve.
8745 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
8747 * attribute.cs: Fix the union of several permissions when some of them
8748 are unrestricted (so the result isn't an unrestricted permission set).
8751 2005-03-30 Raja R Harinath <rharinath@novell.com>
8753 * ecore.cs (MemberExpr): New class. Convert from interface
8755 (MemberExpr.ResolveMemberAccess): Refactor and move here from
8756 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
8758 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
8759 (MethodGroupExpr.IsExplicitImpl): Remove.
8760 (Expression.GetFieldFromEvent): Remove.
8761 (SimpleName.MemberStaticCheck): Remove.
8762 (SimpleName.DoSimpleNameResolve): Update to changes.
8763 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
8764 (MemberAccess.IdenticalNameAndTypeName): Remove.
8765 (MemberAccess.error176): Move to MemberExpr.
8766 (MemberAccess.DoResolve): Update to changes.
8767 (BaseAccess.DoResolve): Likewise.
8769 2005-03-30 Marek Safar <marek.safar@seznam.cz>
8771 C# 2.0 Conditional attribute class implementation
8773 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
8774 Analyzes class whether it has attribute which has ConditionalAttribute
8775 and its condition is not defined.
8777 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
8778 (Class.IsExcluded): New method. Search for at least one defined
8779 condition in ConditionalAttribute of attribute class.
8781 2005-03-30 Raja R Harinath <rharinath@novell.com>
8783 * ecore.cs (PropertyExpr): Derive from Expression, not
8784 ExpressionStatement.
8785 (PropertyExpr.EmitStatement): Remove.
8787 2005-03-29 Raja R Harinath <rharinath@novell.com>
8790 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
8791 internal field "value__" of an enum be private. The examples for
8792 "value__" that I found on MSDN all used FieldAttributes.Private.
8794 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
8795 Don't mention IL method attribute names.
8797 Fix #47991. Remove a TODO.
8798 * statement.cs (Block.Toplevel): Make into a field.
8799 (Block.Parameters): Move into ToplevelBlock.
8800 (Block.known_variables): Rename from child_variable_names.
8801 (Block.Block): Remove variants that take Parameters. Initialize
8802 'Toplevel' with the immediately surrounding toplevel block.
8803 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
8804 LocalInfo parameter.
8805 (Block.GetKnownVariableInfo): New.
8806 (Block.IsVariableNameUsedInChildBlock): Update.
8807 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
8808 the block, even though it may not be in scope.
8809 (Block.AddVariable): Remove Parameters parameter. Use
8810 Toplevel.Parameters instead.
8811 (Block.AddConstant): Remove Parameters parameter.
8812 (Block.GetParameterReference): Update to use Toplevel.Parameters.
8813 (Block.IsParamaterReference): Likewise.
8814 (Block.IsLocalParameter): Likewise. Simplify a lot.
8815 (ToplevelBlock.Parameters): New. Moved from Block.
8816 (ToplevelBlock.ToplevelBlock): Update to changes. Always
8817 initialize Parameters to a non-null value.
8818 * cs-parser.jay: Update to changes.
8819 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
8820 simple names that mean different things in the same block. Use
8821 Block.IsVariableNameUsedInBlock.
8823 2005-03-28 Raja R Harinath <rharinath@novell.com>
8825 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
8826 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
8827 GetTypeHandle. It is possible for a reflected type to derive from
8828 a TypeBuilder (e.g., int[] derives from the TypeBuilder
8829 System.Array during mscorlib compilation).
8830 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
8831 contain a method_hash, don't create one either. Don't create a
8832 deep copy of the base cache's method_hash.
8833 (MemberCache.SetupCache): Rename back from DeepCopy.
8834 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
8835 already initialized. If we see an override function, add its
8836 underlying base virtual function to the member_hash too.
8838 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
8840 2005-03-26 Raja R Harinath <harinath@acm.org>
8843 * assign.cs (Assign.DoResolve): When the RHS of an assignment
8844 fails to resolve, ensure that the LHS is still resolved as an
8847 2005-03-25 Raja R Harinath <harinath@acm.org>
8849 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
8851 (Enum.current_ec): Remove.
8852 (Enum.LookupEnumValue): Remove EmitContext argument.
8853 Just uses the one created during DefineType.
8854 (Enum.FindMembers): Update.
8855 * expression.cs (MemberAccess.DoResolve): Update.
8857 2005-03-22 Marek Safar <marek.safar@seznam.cz>
8859 * assign.cs (Assign.DoResolve): Check for CS1717 when
8860 source and target are same (uses Equals).
8862 * expression.cs (LocalVariableReference, ParameterReference,
8863 This): Implemented Equals, GetHashCode.
8865 * statement.cs (Block.GetParameterReference): Removed useless
8868 2005-03-22 Raja R Harinath <rharinath@novell.com>
8871 * statement.cs (Block.AddVariable): Ensure that we skip implicit
8872 blocks before deciding whether the error is cs0136 or cs0128.
8874 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
8875 (using_alias_directive, using_namespace_directive): Pass
8876 MemberName, not an expression to Namespace.UsingAlias and
8878 (MakeName): Use the MemberName of the namespace.
8879 * namespace.cs (Namespace.MemberName): New.
8880 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
8881 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
8883 * decl.cs (MemberName.Name): Make readonly.
8884 (MemberName.FromDotted): New "constructor".
8885 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
8886 (MemberCore.Name): Compute from MemberName on demand.
8887 (MemberCore.SetMemberName): Provide a way to change the
8889 (MemberCore.AddToContainer): Don't take a fullname parameter.
8890 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
8891 fully qualified name of the container to the member name.
8892 (TypeContainer.AddToTypeContainer): Use a fully qualified name
8893 only if the type is a member of the root container.
8894 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
8895 MemberName.Left rather than searching for an embedded ".".
8896 (PartialContainer.CreatePart): Update to changes in RootContext.
8897 (MemberBase.ShortName): Turn into a property. Use
8898 MemberCore.SetMemberName.
8899 (MemberBase.ExplicitInterfaceName): Remove.
8900 (MemberBase.UpdateMemberName): Remove.
8901 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
8902 (PropertyBase.SetMemberName): New override.
8903 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
8904 (Tree.GetDecl): New.
8905 (Tree.AllDecls): Rename from Decls.
8906 * attribute.cs, enum.cs, report.cs: Update to changes.
8907 * driver.cs (MainDriver): Use MemberName.FromDotted on
8908 RootContext.MainClass.
8910 2005-03-21 Marek Safar <marek.safar@seznam.cz>
8912 * class.cs (FixedField.Define): Check for CS1664 and more sanity
8915 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
8917 2005-03-18 Marek Safar <marek.safar@seznam.cz>
8919 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
8920 property accessor modifiers.
8922 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
8923 fixed buffer attribute (CS1716).
8924 (PropertyMethod.HasCustomAccessModifier): When property accessor
8925 has custom modifier.
8927 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
8929 (PropertyExpr.DoResolveLValue): Add CS0272.
8931 2005-03-17 Miguel de Icaza <miguel@novell.com>
8933 * convert.cs: When converting to a pointer, use the proper Conv.U
8934 or Conv.I depending on the source data type.
8936 * cs-tokenizer.cs: Make the size for large decimal constants,
8939 2005-03-17 Martin Baulig <martin@ximian.com>
8941 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
8942 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
8944 2005-03-17 Martin Baulig <martin@ximian.com>
8946 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
8947 to bool so we can return an error condition.
8948 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
8951 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
8953 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
8956 2005-03-16 Raja R Harinath <rharinath@novell.com>
8958 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
8959 Refactor to avoid traversing the list of assemblies, and to avoid
8960 string concatenation.
8961 * typemanager.cs (guid_attr_type): Remove.
8962 (negative_hits, pointers, references): Remove hashes.
8964 (GetConstructedType): New. Uses type_hash to handle constructed
8965 types (arrays, references, pointers).
8966 (GetReferenceType, GetPointerType): Use it.
8967 (GetNestedType): New. Uses type_hash to handle nested types of
8969 (LookupType, LookupTypeDirect): Remove.
8970 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
8971 'types' hash and LookupTypeReflection directly.
8972 (params_string, params_object): Use GetConstructedType.
8973 * namespace.cs (Namespace.cached_types): New. Cache of reflected
8975 (Namespace.Lookup): Use cached_types.
8976 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
8977 provided by old TypeManager.LookupType.
8978 * rootcontext.cs (MakeFQN): Remove.
8979 * decl.cs (DeclSpace.MakeFQN): Likewise.
8980 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
8981 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
8982 TypeManager.GetConstructedType.
8983 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
8985 2005-03-15 Marek Safar <marek.safar@seznam.cz>
8987 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
8990 * cs-parser.jay: Reports CS1527 for any namespace element.
8992 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
8995 * expression.cs (ParameterReference.IsAssigned): Changed error to
8997 (Error_WrongNumArguments): Moved CS0245 detection here.
8999 * statement.cs (Return.Resolve): Add CS1622 report.
9001 2005-03-11 Marek Safar <marek.safar@seznam.cz>
9003 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
9005 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
9007 * attribute.cs expression.cs: Get rid of some allocations.
9009 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
9011 * doc.cs : just eliminate the latest change.
9013 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9015 * doc.cs : commented out the latest change. It breaks xml-030.cs
9017 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9019 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
9020 fail. So invoke CreateType() in FindDocumentedType().
9022 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9024 * cs-tokenizer.cs : added IsKeyword().
9025 * doc.cs : Detect keyword incorrectly used as identifier.
9026 Allow identifiers prefixed by @.
9028 2005-03-10 Marek Safar <marek.safar@seznam.cz>
9030 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
9031 It caused exception in namespace resolving (again!).
9033 * class.cs (Class.ctor): Removed exit.
9034 (PropertyMethod.ctor): ditto.
9036 * codegen.cs (Codegen.Reset): Reset static data.
9037 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
9039 * cs-tokenizer.cs (Cleanup): Removed.
9041 * driver.cs (GetSystemDir): Rewrote to one line command.
9042 It caused problem with unloaded dynamic modules.
9043 (UnixParseOption): Removed Exit.
9044 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
9045 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
9046 Now can be mcs used as library.
9048 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
9051 * location.cs (Reset): Reset static data.
9053 * namespace.cs (Reset): Reset static data.
9055 * report.cs (Report.Reset): Reset static data.
9057 * rootcontext.cs (RootContext.Reset): Reset static data.
9059 * tree.cs (RootTypes.ctor): Use Location.Null
9061 * typemanager.cs (TypeManager.Reset): Reset static data.
9062 (CoreLookupType): Removed Exit.
9063 (TypeHandle.Reset): Reset static data.
9065 2005-03-10 Raja R Harinath <rharinath@novell.com>
9068 * typemanager.cs (ComputeNamespaces): Import namespaces from
9069 referenced modules too.
9071 2005-03-09 Raja R Harinath <rharinath@novell.com>
9073 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
9076 2005-03-09 Raja R Harinath <rharinath@novell.com>
9078 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
9079 enclosing DeclSpace. This ensures that a name-lookup populates
9080 more caches and there are fewer 'TypeExpression's. Carve out
9081 nested type lookup into ...
9082 (LookupNestedTypeInHierarchy): ... this.
9084 2005-03-09 Raja R Harinath <rharinath@novell.com>
9086 Clean up a few partial-class semantics.
9087 Fixes test-357.cs and cs1618-2.cs.
9088 * cs-parser.jay (struct_declaration): Use 'current_class' as
9089 parent of newly-created struct. Remove call to Register ().
9090 Use 'pop_current_class' to complete handing the current struct.
9091 (interface_declaration): Likewise.
9092 (class_declaration): Likewise.
9093 (enum_declaration): Use 'current_class' as parent of newly created
9095 (delegate_declaration): Likewise.
9096 (pop_current_class): New function. This is used to handle closing
9097 up the 'current_class' and 'current_container', and pointing them
9098 to the enclosing class/container.
9099 (CSharpParser): Initialize 'current_class' too.
9100 * decl.cs (MemberCore): Add check for invariant: a partial
9101 container is not a parsed entity, and thus does not enclose any
9103 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
9104 (DeclSpace.BaseTypeExpr): Use it.
9105 (DeclSpace.LookupType): Add check for invariant.
9106 * class.cs (TypeContainer): Add check for invariant: a nested
9107 class should have the same NamespaceEntry as its enclosing class.
9108 (TypeContainer.EmitFieldInitializers): Make virtual.
9109 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
9111 (TypeContainer.Register): Remove.
9112 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
9113 null. Use TypeResolveEmitContext for resolving base types and
9114 interfaces. Move initialization of Parts.TypeBuilder here from
9116 (TypeContainer.DefineNestedTypes): ... here.
9117 (PartialContainer): Take a Namespace not a NamespaceEntry.
9118 (PartialContainer.Create): Don't use Register. Call the
9119 appropriate Add... function directly.
9120 (ClassPart): Take both the PartialContainer and the enclosing
9121 class as constructor arguments.
9122 (ClassPart.EmitFieldInitializers): Override.
9123 (ClassPart.PartFindNestedTypes): Remove.
9124 (FieldBase.GetInitializerExpression): Resolve the initializer
9125 expression in the emit context of the enclosing class.
9126 * tree.cs (RootTypes): Remove Register ().
9128 2005-03-08 Marek Safar <marek.safar@seznam.cz>
9130 * cs-parser.jay: Removed CS0134.
9132 * driver.cs: Removed CS1901.
9134 * expression.cs (SizeOf.DoResolve): Don't report CS0233
9135 for predefined types.
9137 2005-03-07 Duncan Mak <duncan@novell.com>
9139 * codegen.cs (Save): Catch UnauthorizedAccessException as
9140 well. Fixes bug #73454.
9142 2005-03-07 Marek Safar <marek.safar@seznam.cz>
9144 * cs-tokenizer.cs (xtoken): Add CS1035.
9146 * class.cs (MethodData.Define): Add CS0683.
9147 (FieldMember.ctor): Add CS0681.
9149 2005-03-07 Raja R Harinath <rharinath@novell.com>
9151 * ecore.cs (SimpleName.DoResolve): Rename from
9152 SimpleName.DoResolveAllowStatic.
9153 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
9154 Pass 'intermediate' flag to MemberStaticCheck.
9155 (SimpleName.MemberStaticCheck): Skip "static check" only in case
9156 of "intermediate" lookups via MemberAccess.
9157 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
9158 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
9160 2005-03-07 Raja R Harinath <rharinath@novell.com>
9163 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
9164 slipped in because of variable names that are identical to a
9165 builtin type's BCL equivalent ('string String;', 'int Int32;').
9166 (PropertyExpr.EmitInstance): Likewise.
9168 2005-03-04 Marek Safar <marek.safar@seznam.cz>
9170 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
9172 * report.cs (warning_ignore_table): Made public.
9174 2005-03-04 Raja R Harinath <rharinath@novell.com>
9177 * class.cs (MethodData.Emit): Pass 'container' to
9178 container.GetObsoleteAttribute instead of 'container.Parent'.
9180 2005-03-03 Marek Safar <marek.safar@seznam.cz>
9182 * cs-parser.jay: Add 1534 error test.
9184 * iterators.cs (Yield.CheckContext): Add error 1629.
9185 (Iterator.ctor): Save unsafe modifier.
9186 (MoveNextMethod.DoEmit): Restore unsafe context.
9188 * namespace.cs (UsingAlias): Better error message.
9190 2005-03-03 Dan Winship <danw@novell.com>
9192 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
9193 the warning message [#73219]
9195 2005-03-03 Raja R Harinath <rharinath@novell.com>
9197 Fix compile with MCS 1.0.0.0.
9198 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
9199 w_restore to not depend on string constant folding.
9201 2005-03-03 Raja R Harinath <rharinath@novell.com>
9203 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
9204 CS0246 check to users who passed 'silent = false'.
9205 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
9207 (SimpleName.SimpleNameResolve): Update.
9208 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
9209 (MemberAccess.IdenticalNameAndTypeName): Update.
9210 * doc.cs (FindDocumentedTypeNonArray): Update.
9212 2005-03-03 Raja R Harinath <rharinath@novell.com>
9214 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
9215 * parameters.cs (ComputeAndDefineParameters): Remove.
9216 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
9217 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
9218 Use GetParameterInfo.
9220 2005-03-02 Marek Safar <marek.safar@seznam.cz>
9222 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
9224 2005-03-02 Raja R Harinath <rharinath@novell.com>
9226 Unify DeclSpace.LookupType and DeclSpace.FindType.
9227 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
9228 is in charge of defining nested types on demand.
9229 (DeclSpace.LookupType): Use it when the current_type is a
9230 TypeBuilder. Use LookupTypeDirect for reflected types.
9231 (DeclSpace.FindType): Remove.
9232 (DeclSpace.LookupInterfaceOrClass): Likewise.
9233 (DeclSpace.DefineTypeAndParents): Likewise.
9234 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
9235 DeclSpace.LookupType.
9236 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
9237 * typemanager.cs (LookupType): Simplify.
9238 (AddUserType): Remove type from negative_hits.
9239 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
9240 * class.cs (TypeContainer.FindMembers): Move handling of nested
9242 (TypeContainer.FindMembers_NestedTypes): ... here.
9243 (TypeContainer.FindNestedType): Implement override.
9244 (ClassPart.FindNestedType): Delegate to PartialContainer.
9245 (ClassPart.PartFindNestedType): Looks up the nested types of the
9248 2005-03-02 Martin Baulig <martin@ximian.com>
9250 * class.cs (TypeContainer.DoDefineMembers): We also need a default
9251 static constructor in static classes.
9253 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
9255 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
9256 sizeParamIndex is not specified.
9258 2005-03-01 Marek Safar <marek.safar@seznam.cz>
9261 * report.cs (WarningMessage.IsEnabled): Missing null check.
9263 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9265 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
9266 in the fields and not in the properties.
9268 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
9270 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
9273 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9275 * attribute.cs: Small refactoring (improved robustness).
9276 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
9277 (ValidateGuid): Removed.
9278 (Resolve): Removed referenced to above mentioned.
9279 (GetAttributeUsage): Made private and changed to work without
9281 (GetIndexerAttributeValue): Don't crash.
9282 (GetConditionalAttributeValue): Ditto.
9283 (GetClsCompliantAttributeValue): Ditto.
9284 (ExtractSecurityPermissionSet): All attributes exceptions are
9286 (GetPropertyValue): New helper.
9287 (GetMethodImplOptions): New method.
9288 (DefinePInvokeMethod): Reuse common code. Implemented handling of
9289 some missing properties.
9291 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
9292 (Method.ApplyAttributeBuilder): Updated.
9294 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
9297 2005-02-28 Raja R Harinath <rharinath@novell.com>
9300 * report.cs (Report.SymbolRelatedToPreviousError): Handle
9301 non-simple types (array, pointer, reference).
9303 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9305 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
9307 * class.cs (MethodCore.IsDuplicateImplementation): Special error
9309 (Method.CheckBase): Catch wrong destructor here.
9310 (MethodData.Define): Add errors 550, 668.
9312 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
9314 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
9316 * pending.cs (VerifyPendingMethods): Add error 551.
9318 * typemanager.cs (CSharpName): Next error report helper.
9320 2005-02-25 Marek Safar <marek.safar@seznam.cz>
9322 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
9323 attributes. Removed useless attribute double check.
9324 It saves almost 2MBs for corlib.
9326 2005-02-25 Raja R Harinath <rharinath@novell.com>
9329 * statement.cs (ExpressionStatement.Resolve): Make robust to being
9330 called twice in case of error.
9332 2005-02-23 Chris Toshok <toshok@ximian.com>
9334 Fix compiler portions of #72827.
9335 * statement.cs (Block.Emit): call Begin/EndScope on the
9336 EmitContext instead of the ILGenerator.
9338 * codegen.cs (EmitContext.BeginScope): new method, call
9339 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
9341 (EmitContext.BeginScope): same, but EndScope and CloseScope
9343 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
9344 offset and call the superclass's OpenScope(int) with it.
9345 (SymbolWriter.CloseScope): get the current il
9346 offset and call superclass's CloseScope(int) with it.
9348 2005-02-23 Marek Safar <marek.safar@seznam.cz>
9350 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
9351 CS1677 for out and ref as well.
9353 * class.cs (Method.Define): Add error CS1599 detection.
9355 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
9357 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
9359 * delegate.cs (Delegate.Define): Add error CS1599 detection.
9361 * support.cs.cs (ModifierDesc): New helper method.
9363 2005-02-23 Raja R Harinath <rharinath@novell.com>
9364 Abin Thomas <projectmonokochi@rediffmail.com>
9365 Anoob V E <projectmonokochi@rediffmail.com>
9366 Harilal P R <projectmonokochi@rediffmail.com>
9369 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
9370 MemberLookup (used for error reporting) actually returns a result.
9371 Fix error report number (122, not 112).
9373 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
9374 Anoob V E <projectmonokochi@rediffmail.com>
9375 Harilal P R <projectmonokochi@rediffmail.com>
9378 * pending.cs (PendingImplementation.GetAbstractMethods):
9379 Find NonPublic members too.
9381 2005-02-22 Marek Safar <marek.safar@seznam.cz>
9383 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
9386 * class.cs (MethodCore.CheckMethodAgainstBase):
9387 Add error 239 report.
9389 2005-02-21 Raja R Harinath <rharinath@novell.com>
9392 * expression.cs (Invocation.IsApplicable): Make public.
9393 (Invocation.IsParamsMethodApplicable): Likewise.
9394 * delegate.cs (Delegate.VerifyApplicability): Don't use
9395 Invocation.VerifyArgumentCompat for parameter applicability
9396 testing. Use Invocation.IsApplicable and
9397 Invocation.IsParamsMethodApplicable.
9399 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9401 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
9403 * class.cs (Operator.Define): Add error 217 report.
9405 2005-02-21 Raja R Harinath <rharinath@novell.com>
9407 * namespace.cs (UsingEntry.Resolve): Undo change below.
9409 2005-02-21 Raja R Harinath <rharinath@novell.com>
9412 * ecore.cs (Expression.MemberLookupFailed): Add argument to
9413 disable the error message when the extended MemberLookup also
9415 (Expression.MemberLookupFinal): Update.
9416 (SimpleName.DoSimpleNameResolve): Update.
9417 * expression.cs (MemberAccess.ResolveNamespaceOrType):
9418 Don't use MemberLookupFinal.
9419 (New.DoResolve): Update.
9420 (BaseAccess.CommonResolve): Update.
9422 2005-02-21 Raja R Harinath <rharinath@novell.com>
9425 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
9426 occured previously, don't resolve again.
9428 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9431 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
9432 argument. Call ResolveAttributeUsage for unresolved.
9433 when types doesn't match ctor arguments.
9435 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
9436 for nested attribute classes.
9437 (Class.attribute_usage): Removed.
9438 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
9439 for attribute class.
9441 * ecore.cs (IsAttribute): Removed.
9443 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
9445 * rootcontext.cs (RegisterAttribute): Removed, attributes are
9447 (attribute_types): Removed.
9448 (EmitCode): Global attributes are emited as the latest.
9450 2005-02-18 Marek Safar <marek.safar@seznam.cz>
9452 * class.cs (EmitFieldInitializers): Don't emit field initializer
9453 for default values when optimilization is on.
9455 * constant.cs (Constant.IsDefaultValue): New property.
9457 * driver.cs: Add /optimize handling.
9461 * literal.cs: Implement new IsDefaultValue property.
9463 * rootcontext.cs (Optimize): New field, holds /optimize option.
9465 2005-02-18 Raja R Harinath <rharinath@novell.com>
9467 Fix crasher in re-opened #72347.
9468 * namespace.cs (Namespace.Lookup): Return null if
9469 DeclSpace.DefineType returns null.
9472 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
9474 2005-02-18 Raja R Harinath <rharinath@novell.com>
9476 Fix remainder of #63202. Change semantics of DoResolveLValue: it
9477 now returns null if it cannot resolve to an lvalue.
9478 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
9479 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
9480 returned null. Remove check for SimpleName.
9481 (EventExpr.DoResolveLValue): New.
9482 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
9483 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
9485 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
9487 (Unary.ResolveOperator): Move CS0211 check ...
9488 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
9490 (Unary.DoResolveLValue): Simplify.
9491 (AddressOf.DoResolveLValue): New.
9492 (ArrayAccess.DoResolveLValue): New.
9494 2005-02-16 Marek Safar <marek.safar@seznam.cz>
9496 * attribute.cs (Attribute.Resolve): Add arguments casting for
9497 when types doesn't match ctor arguments.
9499 2005-02-16 Raja R Harinath <rharinath@novell.com>
9501 Fix parts of #63202.
9502 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
9503 lookup of operator in base type. Ensure that all checks happen
9504 when the operator resolves to an "op_..." method.
9506 2005-02-15 Raja R Harinath <rharinath@novell.com>
9509 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
9510 'ignore_cs0104' parameter. Pass it to ...
9511 (NamespaceEntry.Lookup): ... this.
9512 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
9513 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9514 (TypeLookupExpression.DoResolveAsTypeStep): Update.
9515 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
9516 Update. Request that cs0104 errors be ignored.
9517 (ComposedCast.ResolveAsTypeStep): Update.
9519 2005-02-14 Raja R Harinath <rharinath@novell.com>
9522 * expression.cs (Invocation.BetterFunction): Remove support for
9523 comparing virtual functions and their overrides.
9524 (Invocation.IsOverride): New.
9525 (Invocation.OverloadResolve): Don't consider 'override' functions
9526 during candidate selection. Store them in a lookaside list.
9527 If the selected method is a 'virtual' function, use the list to
9528 find any overrides that are closer to the LHS type.
9530 2005-02-14 Marek Safar <marek.safar@seznam.cz>
9532 * expression.cs (New.DoResolve): Add complex core type reduction.
9533 (New.Constantify): Converts complex core type syntax like 'new int ()'
9536 2005-02-14 Raja R Harinath <rharinath@novell.com>
9538 * decl.cs (EntryType.EntryType): New constructor to create an
9539 updated copy of a cache entry.
9540 (MemberCache.AddMethods): Use it.
9541 (MemberCache.ClearDeclaredOnly): Remove.
9542 (MemberCache.MemberCache): Update.
9544 2005-02-11 Miguel de Icaza <miguel@novell.com>
9546 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
9547 variable. This one is represents the actual low-level declaration
9548 of the method, as opposed to the semantic level `IsStatic'.
9550 An anonymous method which is hosted into a static method might be
9551 actually an instance method. IsStatic would reflect the
9552 container, while MethodIsStatic represents the actual code
9555 * expression.cs (ParameterReference): Use the new MethodIsStatic
9556 instead of IsStatic.
9558 * anonymous.cs (AnonymousMethod.Compatible): Pass the
9559 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
9560 set on the current EmitContext.
9562 * expression.cs (Cast): Overload DoResolveLValue so we can pass
9563 resolve our casted expression as an LValue. This triggers the
9564 proper LValue processing that is later required by Assign.
9568 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
9570 2005-02-11 Marek Safar <marek.safar@seznam.cz>
9572 C# 2.0 Fixed buffer implementation
9574 * anonymous.cs: Update after RegisterHelperClass renaming.
9576 * attribute.cs (AttributeTester.fixed_buffer_cache):
9577 Cache of external fixed buffers.
9578 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
9579 implementation if field is fixed buffer else null.
9582 (TypeContainer.AddField): Accept FieldMember instead of Field.
9583 (FieldBase.IsFieldClsCompliant): Extracted code from
9584 VerifyClsCompliance descendant customization.
9585 (FixedField): New class handles fixed buffer fields.
9586 (FixedFieldExternal): Keeps information about imported fixed
9588 (IFixedField): Make access to internal or external fixed buffer
9591 * cs-parser.jay: Add fixed buffer parsing.
9593 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
9596 * expression.cs (Indirection): Extended implementation to accept
9598 (PointerArithmetic.Emit): Get element from fixed buffer as well.
9599 (ElementAccess.MakePointerAccess): Get type as parameter.
9600 (DoResolve): Add fixed buffer field expression conversion.
9601 (DoResolveLValue): Ditto.
9602 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
9603 (ArrayPtr): Derives from FixedBufferPtr.
9604 (ArrayPtr.Emit): Add extra emit for array elements.
9606 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
9608 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
9609 for compiler generated types.
9610 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
9612 * statement.cs (Fixed): Refactored to be easier add fixed buffer
9613 and consume less memory.
9614 (Fixed.Resolve): Add fixed buffer case.
9616 * typemanager.cs (compiler_generated_attr_ctor,
9617 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
9618 (HasElementType): Add our own implementation to work on every
9621 2005-02-11 Miguel de Icaza <miguel@novell.com>
9623 * anonymous.cs (CaptureContext): Track whether `this' has been
9626 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
9627 only captured `this' if it was implicitly done (instance
9628 methods/variables were used).
9630 * codegen.cs (EmitContext.CaptureThis): New method to flag that
9631 `this' must be captured.
9633 2005-01-30 Miguel de Icaza <miguel@novell.com>
9635 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
9636 is null it means that there has been no need to capture anything,
9637 so we just create a sibling.
9639 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9641 Just a partial fix. The other half is fairly elusive.
9643 2005-02-10 Raja R Harinath <rharinath@novell.com>
9645 Fix #52586, cs0121-4.cs.
9646 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
9647 and return a hashtable.
9648 (MemberCache.ClearDeclaredOnly): New.
9649 (MemberCache.MemberCache): Update to change. Make a deep copy of
9650 the method_hash of a base type too.
9651 (MemberCache.AddMethods): Adapt to having a deep copy of the base
9652 type methods. Overwrite entries with the same MethodHandle so
9653 that the ReflectedType is correct. The process leaves in base
9654 virtual functions and their overrides as distinct entries.
9655 (CacheEntry): Now a class instead of a struct. It shouldn't alter
9656 matters since it was boxed in a ArrayList before.
9657 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
9659 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
9660 case of a virtual function and its override (choose the overload
9662 (Invocation.OverloadResolve): Avoid 'override' members during
9663 'applicable_type' calculation.
9665 2005-02-09 Raja R Harinath <rharinath@novell.com>
9667 Combine two near-redundant caches.
9668 * typemanager.cs (method_params): Rename from method_internal_params.
9669 (TypeManager.GetParameterData): New. Replace
9670 Invocation.GetParameterData.
9671 (TypeManager.LookupParametersByBuilder): Remove.
9672 * expression.cs (Invocation.method_parameter_cache): Remove.
9673 (Invocation.GetParameterData): Remove.
9675 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
9678 2005-02-08 Raja R Harinath <rharinath@novell.com>
9681 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
9682 TypeManager.multicast_delegate_type is null, resolve it by looking
9683 up "System.MulticastDelegate".
9684 * rootcontext.cs (RootContext.ResolveCore): Simplify.
9686 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
9687 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
9688 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
9691 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
9692 (LabeledStatement.AddReference): New. Set 'referenced'.
9693 (Goto.Resolve): Use it.
9695 2005-02-05 John Luke <john.luke@gmail.com>
9697 * driver.cs: remove duplicate -doc line in Usage ()
9699 2005-02-04 Raja R Harinath <rharinath@novell.com>
9701 * location.cs (Location.AddFile): Fix CS2002 error report.
9703 2005-02-02 Martin Baulig <martin@ximian.com>
9705 * delegate.cs (Delegate.DefineType): Report an internal error if
9706 TypeManager.multicast_delegate_type is null. See bug #72015 for
9709 2005-02-02 Raja R Harinath <rharinath@novell.com>
9711 Fix a crasher in a variant of #31984.
9712 * const.cs (Constant.CheckBase): New override that defers the
9713 new-or-override check in case the base type hasn't been populated
9715 (Constant.Define): Ensure the new-or-override check is performed.
9717 2005-02-01 Duncan Mak <duncan@ximian.com>
9719 * const.cs (LookupConstantValue): Check that `ce' is not null
9720 before calling GetValue ().
9722 2005-02-01 Raja R Harinath <rharinath@novell.com>
9724 Fix test-334.cs (#69519).
9725 * cs-parser.jay (using_alias_directive): Pass in an expression to
9726 NamespaceEntry.UsingAlias.
9727 (using_namespace_directive): Pass in an expression to
9728 NamespaceEntry.Using.
9729 (namespace_name): Don't flatten to a string.
9730 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
9731 (NamespaceEntry.AliasEntry.Resolve): Lookup using
9733 (NamespaceEntry.UsingEntry): Likewise.
9734 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
9736 (NamespaceEntry.LookupForUsing): Remove.
9737 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
9739 (NamespaceEntry.Lookup): Remove support for dotted names.
9741 2005-02-01 Raja R Harinath <rharinath@novell.com>
9743 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
9745 (NamespaceEntry.ImplicitParent): Compute on demand.
9746 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
9747 parallels the current.
9748 (NamespaceEntry.LookupForUsing): Use it.
9749 (NamespaceEntry.Lookup): If the current namespace-entry is
9750 implicit, don't search aliases and using tables.
9752 2005-02-01 Raja R Harinath <rharinath@novell.com>
9755 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
9757 (TypeContainer.BaseCache): Compute on demand.
9758 (TypeContainer.FindMembers): Define constants and types if they're
9759 not already created.
9760 (FieldMember.Define): Move resetting of ec.InUnsafe before error
9762 * const.cs (Constant.Define): Make idempotent.
9764 2005-01-29 Miguel de Icaza <miguel@novell.com>
9766 * pending.cs: Produce better code (no nops produced by using Ldarg
9769 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
9770 i - 1' it should be arg + 1.
9774 2005-01-28 Raja R Harinath <rharinath@novell.com>
9776 * attribute.cs (Attribute.CheckAttributeType): Make private
9778 (Attribute.ResolveType): Make virtual.
9779 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
9780 handling of RootContext.Tree.Types.
9782 2005-01-27 Raja R Harinath <rharinath@novell.com>
9784 Update attribute-handling to use the SimpleName/MemberAccess
9786 * cs-parser.jay (attribute): Pass in an expression to the
9787 constructors of Attribute and GlobalAttribute.
9788 * attribute.cs (Attribute): Take an expression for the name.
9789 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
9790 passed in attribute name expression.
9791 (Attribute.CheckAttributeType): Use it.
9792 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
9793 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
9794 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
9795 argument to prevent error messages if the lookup fails.
9797 2005-01-27 Marek Safar <marek.safar@seznam.cz>
9799 * expression.cs (Indirection): Implemented IVariable interface
9800 to support indirection in AddressOf operator.
9801 (PointerArithmetic.Emit): Add optimalization for case where
9802 result can be precomputed.
9804 2005-01-26 Martin Baulig <martin@ximian.com>
9806 * class.cs (TypeContainer.AttributeTargets): Return the correct
9807 AttributeTargets depending on our `Kind' instead of throwing an
9808 exception; fixes #71632.
9810 2005-01-26 Marek Safar <marek.safar@seznam.cz>
9813 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
9816 2005-01-25 Raja R Harinath <rharinath@novell.com>
9819 * expression.cs (MemberAccess.DoResolve): Don't complain with
9820 cs0572 when the LHS of a member access has identical name and type
9823 2005-01-25 Marek Safar <marek.safar@seznam.cz>
9826 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
9828 Create custom PermissionSet only for PermissionSetAttribute.
9830 2005-01-24 Marek Safar <marek.safar@seznam.cz>
9833 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
9834 delegates in static class.
9836 2005-01-24 Martin Baulig <martin@ximian.com>
9838 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9839 merging an implicit block, just use its reachability.
9841 * statement.cs (Block.Resolve): Make the unreachable code check
9842 work wrt. implicit blocks; see test-337 from #63842.
9844 2005-01-21 Alp Toker <alp@atoker.com>
9846 * cs-parser.jay: destructor_declaration's container is PartialContainer
9847 not Class when partial types are used, so use Kind prop instead of
9850 2005-01-22 Miguel de Icaza <miguel@ximian.com>
9852 * cs-parser.jay: Improve error reporting when an interface
9855 2005-01-20 Dick Porter <dick@ximian.com>
9857 * support.cs: SeekableStreamReader fix from Sandor Dobos
9858 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
9859 chars are read. Fixes bug 70369.
9861 2005-01-20 Raja R Harinath <rharinath@novell.com>
9863 * cs-parser.jay (catch_clause): Simplify current_block handling
9866 2005-01-17 Miguel de Icaza <miguel@ximian.com>
9868 * convert.cs (ImplicitStandardConversionExists): Synchronize the
9869 code with ImplicitStandardConversion to handle the implicit
9870 conversion of method groups into valid delegate invocations.
9872 The problem is that in parameter handling we were using this code
9873 path. Fixes bug #64698
9875 2005-01-19 Raja R Harinath <rharinath@novell.com>
9877 * cs-parser.jay: Fix several infelicities.
9878 - Avoid assigning to the parser value stack. Code like
9879 '$3 = null' is unclean. Synthesize a value for the code block
9881 - Avoid using oob_stack for storing location information. Use ...
9882 (_mark_): ... this. New (empty) rule. Saves the current location
9884 (foreach_statement): Avoid using oob_stack for current_block
9885 handling. Use technique used in for_statement and
9886 using_statement. Synthesize a value for the code block to store
9887 additional intermediate information.
9889 2005-01-13 Miguel de Icaza <miguel@ximian.com>
9891 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
9892 of a different type is only allowed to private fields of a
9893 containing type, not on fields of a base class.
9895 See test-174.cs and error cs0122-9.cs
9897 2005-01-13 Raja R Harinath <rharinath@novell.com>
9899 Fix test-335.cs (bug #58126).
9900 * cs-parser.jay (argument): Split out non-expression parts of the
9901 rule into 'non_simple_argument'.
9902 (invocation_expression): Support parenthesized invocations with
9903 multiple arguments, and with single non-simple arguments.
9905 2005-01-13 Raja R Harinath <rharinath@novell.com>
9907 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
9910 2005-01-12 Raja R Harinath <rharinath@novell.com>
9912 Fix cs0038-1.cs, cs1640-6.cs.
9913 * ecore.cs (Expression.Resolve): Remove special-case for
9914 SimpleName in error-handling.
9915 (Expression.almostMatchedMembers): Relax access permission to
9917 (Expression.MemberLookupFailed): Handle duplicates in
9918 almostMatchedMembers list.
9919 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
9920 * expression.cs (New.DoResolve): Report CS1540 for more cases.
9921 * typemanager.cs (GetFullNameSignature): Use the MethodBase
9922 overload if the passed in MemberInfo is a MethodBase.
9924 2005-01-12 Marek Safar <marek.safar@seznam.cz>
9927 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
9928 for non-CAS & merge permission sets properly.
9930 2005-01-11 Raja R Harinath <rharinath@novell.com>
9932 Improve standard-compliance of simple name and member access
9933 resolution. Fixes bugs #52697, #57200, #67520, #69519.
9934 * ecore.cs (FullNamedExpression): New abstract base class
9935 for Namespaces and TypeExpressions.
9936 (ResolveFlags.SimpleName): Remove.
9937 (SimpleName): Remove support for dotted names.
9938 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
9939 DeclSpace.FindType and DeclSpace.LookupType.
9940 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
9941 (Expression.ExprClassName): Make member function.
9942 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
9943 a namespace. Remove creation of dotted "SimpleName"s.
9944 (MemberAccess.DoResolve): Likewise.
9945 * decl.cs (DeclSpace.Cache): Make private.
9946 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
9947 (DeclSpace.FindType): Update.
9948 (DeclSpace.LookupType): Move here from RootContext. Return a
9949 FullNamedExpression.
9950 * namespace.cs (Namespace): Derive from FullNamedExpression
9951 so that it can be part of expression resolution.
9952 (Namespace.Lookup): Return an FullNamedExpression.
9953 (NamespaceEntry.LookupAlias): Lookup aliases only in current
9955 * rootcontext.cs (NamespaceLookup): Remove.
9956 (LookupType): Move to DeclSpace.
9957 * attribute.cs (CheckAttributeType): Update.
9958 * doc.cs (FindDocumentedType): Remove allowAlias argument.
9959 (FindDocumentedTypeNonArray): Likewise.
9961 2005-01-11 Raja R Harinath <rharinath@novell.com>
9963 Fix cs0509.cs, cs1632.cs.
9964 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
9965 is the same as IsInterface.
9966 (TypeContainer.GetClassBases): Likewise.
9967 * statement.cs (LabeledStatement.ig): New field.
9968 (LabeledStatement.LabelTarget): Save ILGenerator which created the
9970 (LabeledStatement.DoEmit): Check that the label was created with
9971 the same ILGenerator.
9973 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9976 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
9977 accessors to its properties.
9979 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
9980 from accessors to property.
9982 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9985 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
9988 2005-01-08 Miguel de Icaza <miguel@ximian.com>
9990 * attribute.cs: Check for null and empty strings.
9992 I have lost another battle to Paolo.
9994 2005-01-07 Marek Safar <marek.safar@seznam.cz>
9997 * class.cs (PropertyMethod): Set Parent field in ctors.
9998 (SetMethod.InternalParameters): Add unsafe switch hack.
9999 Override MarkForDuplicationCheck where it is appropriate.
10001 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
10002 It says whether container allows members with the same name.
10003 Base default is no.
10004 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
10005 Removed is_method parameter.
10007 2005-01-06 Duncan Mak <duncan@ximian.com>
10009 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
10010 because the previous change led to incorrect reporting of CS1032
10011 ("Cannot define/undefine preprocessor symbols after first token in
10012 file"). Instead of using `tokens_seen' as the only flag that
10013 triggers CS1040, introduce `comments_seen'. This new flag is used
10014 to signify having seen comments on the current line, so it is
10015 unset after a newline.
10017 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10019 * doc.cs : When searching for a type, find nested type too.
10020 This fixes bug #71040.
10022 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10025 - Warn missing member comment on those classes which also does not
10026 have doc comments. Fixed bug #71041.
10027 - Don't warn missing doc comment on default constructor.
10030 2005-01-06 Duncan Mak <duncan@ximian.com>
10032 * cs-tokenizer.cs (xtoken): After handling traditional C-style
10033 comments, set `tokens_seen' to true. This allows us to detect
10034 misplaced preprocessor directives (i.e. not at the beginning of
10035 the a line, nor after whitespaces). In that case, report error
10036 CS1040. This fixes bug #56460.
10038 * cs-parser.jay (interface_member_declaration): Add checks for
10039 IsExplicitImpl, and report CS0541 error if an interface member is
10040 defined as an explicit interface declaration.
10042 2005-01-06 Marek Safar <marek.safar@seznam.cz>
10045 * class.cs (PropertyMethod): Set Parent field in ctors.
10046 (SetMethod.InternalParameters): Add unsafe switch hack.
10048 * decl.cs (MemberCore.Parent): Cannot be readonly.
10050 2005-01-06 Raja R Harinath <rharinath@novell.com>
10052 * decl.cs (DeclSpace.ResolveType): Remove.
10053 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
10054 Merge in code from ...
10055 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
10056 * class.cs, enum.cs: Update to changes.
10058 2005-01-06 Miguel de Icaza <miguel@ximian.com>
10060 * anonymous.cs: Ensure that we init the scope of our parent if it
10061 has not been initialized yet.
10063 2004-12-30 Duncan Mak <duncan@ximian.com>
10065 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
10066 if field.FieldBuilder is null. Fixes #70758.
10068 * convert.cs: Fixed some typos and updated some of the comments.
10069 (ImplicitStandardConversionExists):
10070 (TryImplicitIntConversion): If `target_type' is an interface and
10071 the type of `ic' implements this interface, return true or a new
10072 BoxedCast instead of null. This fixes #70468.
10074 2004-12-29 Duncan Mak <duncan@ximian.com>
10076 * expression.cs (Argument.Emit): Check that Expr is
10077 IMemoryLocation before casting to it, and report CS1510 otherwise.
10081 2004-12-21 Ben Maurer <bmaurer@ximian.com>
10083 * statement.cs (Block.ThisVariable): remove the recursion here, to
10084 make the --profile more sane.
10086 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
10088 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
10089 assembly, by JB Evain.
10091 2004-12-17 Raja R Harinath <rharinath@novell.com>
10093 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
10094 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
10095 "parent" refers to enclosing type/class. "base" refers to superclass.
10097 2004-12-17 Raja R Harinath <rharinath@novell.com>
10099 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10100 Ensure that we only have GlobalAttributes.
10101 * attribute.cs (Attribute.Emit): Make non-virtual.
10102 (GlobalAttribute.Emit): Remove.
10103 (Attribute.Resolve): Make virtual.
10104 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
10105 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
10106 the argument. Don't create one.
10107 (Attribute.GetObsoleteAttribute): Likewise.
10108 (Attribute.GetClsCompliantAttributeValue): Likewise.
10109 * class.cs, decl.cs: Update to changes.
10111 2004-12-17 Marek Safar <marek.safar@seznam.cz>
10113 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
10115 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
10117 * statement.cs (Foreach.Resolve): Add error 186 report.
10119 2004-12-16 Marek Safar <marek.safar@seznam.cz>
10121 * expression.cs (Conditional.DoResolve): Add warning 429.
10123 * statement.cs (If.Resolve): Add warning 665.
10125 2004-12-16 Raja R Harinath <rharinath@novell.com>
10127 New invariant: RootContext.Tree.Types.NamespaceEntry == null
10128 except when in the parser, and in GlobalAttribute.
10129 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
10130 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
10131 RootContext.Tree.Types.NamespaceEntry once work is done.
10132 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
10133 and resets RootContext.Tree.Types.NamespaceEntry.
10135 2004-12-15 Marek Safar <marek.safar@seznam.cz>
10137 * cs-parser.jay: Don't create a block for every variable.
10139 2004-12-14 Miguel de Icaza <miguel@ximian.com>
10141 * location.cs: Provide extra information.
10143 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
10144 variables from the captured environment, it is the ldarg_0.
10146 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10148 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
10151 * class.cs: Changed warning level for 169 to avoid developer
10152 displeasure from warning flooding. It will be changed back when they
10153 fix most of current BCL warnings.
10155 * RootContext.cs: Pushed default WarningLevel to 3.
10157 * statement.cs: Removed unused variable.
10159 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10161 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
10162 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
10163 Add error 502 report.
10164 (StaticClass.DefineType): Add error 441 report.
10165 (Class.AllowedModifiersProp): New virtual property as temporary
10166 extension to AllowedModifiers.
10167 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10168 to share implementation with StaticClass and don't call virtual
10171 * driver.cs (MainDriver): Add error 1558 test.
10173 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
10174 report. Moved error 36 test here.
10176 * statement.cs (Throw.Resolve): Add error 724 report.
10178 * typemanager.cs: Add out_attribute_type core type.
10180 2004-12-13 Marek Safar <marek.safar@seznam.cz>
10182 * class.cs (TypeContainer.VerifyClsCompliance): Add error
10184 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
10186 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
10189 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
10191 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
10192 Add error 3023 report.
10193 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
10195 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
10198 2004-12-12 John Luke <john.luke@gmail.com>
10200 * driver.cs (AddArgs): take -- into account when
10201 adding arguments, fixes bug 65710
10203 2004-12-12 Martin Baulig <martin@ximian.com>
10205 * expression.cs (Unary.TryReduceNegative): Added support for
10206 SByteConstant and ByteConstant.
10207 (Unary.Reduce): Check error values from TryReduceNegative().
10209 2004-12-10 Marek Safar <marek.safar@seznam.cz>
10211 * attributes.cs (Attribute.Resolve): Avoid multiple error report
10212 and report exception as error 182.
10214 2004-12-10 Raja R Harinath <rharinath@novell.com>
10216 * driver.cs (Main): Fix message when there are warnings.
10218 2004-12-09 Miguel de Icaza <miguel@ximian.com>
10220 * delegate.cs: Fixed my fix from yesterday, sorry about that.
10222 2004-12-09 Marek Safar <marek.safar@seznam.cz>
10224 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
10225 Reduced number of warnings.
10227 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
10229 2004-12-08 Miguel de Icaza <miguel@ximian.com>
10231 * driver.cs: Removed message.
10233 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
10235 2004-12-08 <vargaz@freemail.hu>
10237 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
10239 2004-12-08 Martin Baulig <martin@ximian.com>
10241 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
10242 instead of a CS3002 for properties and indexer.
10244 2004-12-08 Martin Baulig <martin@ximian.com>
10246 * decl.cs (MemberName.ToString): Make this work again.
10248 2004-12-08 Marek Safar <marek.safar@seznam.cz>
10250 * attribute.cs (Resolve): Add error 591 detection.
10252 * class.cs (FieldMember.Define): Add error 1547 detection.
10253 (Indexer.Define): Add error 620 detection.
10254 (Operator.Define): Add error 590 detection.
10256 * ecore.cs: Missing argument for error 79.
10258 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
10261 2004-12-07 Marek Safar <marek.safar@seznam.cz>
10264 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
10267 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
10269 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10270 Some operator comments were suppressed.
10271 * doc.cs : Implicit/explicit operator name in doc comments are like
10272 "op_Explicit(type)~returnType", so added suffix handling.
10274 2004-12-07 Martin Baulig <martin@ximian.com>
10277 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
10278 (MemberCore.GetClsCompliantAttributeValue): Likewise.
10279 (DeclSpace.ec): New protected field; store the EmitContext here.
10280 (DeclSpace.EmitContext): New public property; moved here from
10282 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
10285 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
10286 (Enum.Emit): Don't create a new EmitContext.
10288 * delegate.cs (Delegate.DefineType): Always create the
10291 * iterators.cs (Iterators.DefineIterator): Create a new
10292 EmitContext and store it in `ec'.
10294 2004-08-24 Martin Baulig <martin@ximian.com>
10297 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10298 this for accessibility checks.
10299 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10300 IsNestedFamilyAccessible.
10301 (TypeManager.IsSubclassOf): New method, do what the name actually
10304 2004-12-06 Raja R Harinath <rharinath@novell.com>
10306 Fix crash on cs0657-17.cs.
10307 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10308 Use RootContext.Tree.Types, not 'new RootTypes ()'.
10309 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
10310 the case where the NamespaceEntry gets overwritten.
10312 2004-12-06 Marek Safar <marek.safar@seznam.cz>
10314 Fixed #69195, #56821
10315 * ecore.cs (ResolveBoolean): Tiny refactoring.
10317 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
10318 of right expression resolving when left is false constant and
10319 operator is LogicalAnd OR true constant and operator is LogicalOr.
10321 * statement.cs (ResolveUnreachable): Always reports warning.
10323 2004-12-05 Miguel de Icaza <miguel@ximian.com>
10325 * class.cs: Distinguish between 1721 and 1722 (just a little help
10326 for the programmer).
10328 2004-12-03 Miguel de Icaza <miguel@ximian.com>
10330 * delegate.cs: Only allow this on new versions of the language.
10332 2004-12-02 Duncan Mak <duncan@ximian.com>
10334 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
10336 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
10337 here as a static method. Take an additional bool out parameter
10338 `must_do_cs1540_check' for signaling to InstanceResolve.
10339 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
10340 member field from PropertyExpr class and made it an argument of
10341 the method instead.
10342 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
10343 check for MarshalByRefObject, and report CS0122 instead of CS1540.
10344 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
10345 and `remove_accessor' as well as InstanceResolve: report CS0122
10350 2004-12-03 Raja R Harinath <rharinath@novell.com>
10352 Fix test-327.cs, test-328.cs, and put in early infrastructure
10353 for eventually fixing #52697.
10354 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
10355 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
10356 from other methods.
10357 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
10358 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
10359 (VerifyUsing, error246): Update.
10360 * rootcontext.cs (RootContext.NamespaceLookup): Just use
10361 'NamespaceEntry.LookupNamespaceOrType'.
10363 2004-12-03 Martin Baulig <martin@ximian.com>
10365 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10366 method as our child, call AnonymousMethod.Compatible() on it.
10368 2004-12-03 Raja R Harinath <rharinath@novell.com>
10370 Disable XML documentation support in 'basic' profile.
10371 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
10372 Redirect XmlElement to System.Object.
10373 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
10374 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
10375 * mcs.exe.sources: Add doc-bootstrap.cs.
10376 * doc-bootstrap.cs: New file. Contains empty stub implementation
10379 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
10381 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
10382 comments are allowed.
10384 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10386 * delegate.cs: Add checks for subtypes in paramaters and return values
10387 in VerifyMethod () to add support for Covariance/Contravariance
10390 2004-12-02 Miguel de Icaza <miguel@ximian.com>
10392 * report.cs: Remove extra closing parenthesis.
10394 * convert.cs (Error_CannotImplicitConversion): If the name of the
10395 types are the same, provide some extra information.
10397 * class.cs (FieldBase): Use an unused bit field from the field to
10398 encode the `has_offset' property from the FieldMember. This saves
10399 a couple of Ks on bootstrap compilation.
10401 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10402 method as our child, return the AnonymousMethod resolved
10405 * expression.cs (New.DoResolve): Allow return values from
10406 NewDelegate to also include AnonymousMethods.
10410 2004-12-02 Marek Safar <marek.safar@seznam.cz>
10413 * attribute.cs (Resolve): Improved implementation of params
10414 attribute arguments.
10416 * support.cs (ParameterData): Add HasParams to be faster.
10418 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
10420 all things are for /doc support:
10422 * doc.cs: new file that supports XML documentation generation.
10423 * mcs.exe.sources: added doc.cs.
10425 Handle /doc command line option.
10426 Report error 2006 instead of 5 for missing file name for /doc.
10427 Generate XML documentation when required, after type resolution.
10429 Added support for picking up documentation (/// and /** ... */),
10430 including a new XmlCommentState enumeration.
10432 Added lines to fill Documentation element for field, constant,
10433 property, indexer, method, constructor, destructor, operator, event
10434 and class, struct, interface, delegate, enum.
10435 Added lines to warn incorrect comment.
10437 Added Documentation field (passed only when /doc was specified).
10439 Added DocComment, DocCommentHeader, GenerateDocComment() and
10440 OnGenerateDocComment() and some supporting private members for
10441 /doc feature to MemberCore.
10443 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
10445 Added overriden DocCommentHeader.
10447 Added overriden DocCommentHeader and GenerateDocComment().
10449 2004-12-01 Miguel de Icaza <miguel@ximian.com>
10451 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
10452 unwrapping the enumeration values, chain to
10453 DoConstantNumericPromotions again, so we can promote things to the
10454 fundamental types (takes care of enums that are bytes, sbytes).
10458 2004-12-01 Raja R Harinath <rharinath@novell.com>
10460 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
10461 Fix long-standing bug in type-lookup. Use FindType instead of
10462 LookupType when ec.ResolvingTypeTree.
10463 (Attribute.ResolveType, Attribute.Resolve)
10464 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
10466 (Attributes.Search): Remove internal version. Update.
10467 (Attributes.SearchMulti): Update.
10468 (Attributes.GetClsCompliantAttribute): Remove.
10469 (Attributes.GetIndexerNameAttribute): Remove.
10470 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
10471 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
10472 * class.cs (Indexer.Define): Likewise.
10474 2004-12-01 Marek Safar <marek.safar@seznam.cz>
10477 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
10478 MarshallByReference members access.
10480 * expression.cs: Use CheckMarshallByRefAccess;
10481 Better error CS0197 message.
10483 * report.cs: Print whole related error message.
10485 2004-11-30 Raja R Harinath <rharinath@novell.com>
10487 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
10488 the current directory to help debugging.
10490 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10492 * class (GetClassBases): Better error 60 report.
10493 (EventProperty): Disabled warning 67 detection.
10495 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10498 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
10500 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
10503 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10506 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
10508 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
10510 2004-11-26 Miguel de Icaza <miguel@ximian.com>
10512 * attribute.cs (Attribute.Resolve): Refine error reporting and
10513 report a cs0117 if the identifier does not exist, to distinguish
10514 from 0617 which is a miss-use of the actual identifier.
10516 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
10517 between cs0070 and cs0079.
10519 * class.cs (MemberBase.DoDefine): When reporting a wrong
10520 accessibility level, we use MethodCore to compare instead of
10521 Method (this was a regression in some refactoring effort).
10523 So now we correctly report cs0056 again.
10525 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
10526 testing the target_type (which was known to be object_type) and
10527 not the source type (which is anonymous_method).
10529 Fixed reporting of error cs1660.
10531 * expression.cs (UserCast.Source): Expose the underlying cast.
10533 * statement.cs (Switch.SwitchGoverningType): Sort the list of
10534 allowed types to find a match to int32 first (most common).
10536 In addition, it ignores any ImplicitUserConversions that did an
10537 internal implicit conversion (as the switch statement allows only
10538 one integral conversion to exist).
10540 * class.cs (PartialContainer.Create): rename `name' to
10541 `member_name' for clarity. Then replace the string calls with a
10542 call to MemberName.GetPartialName, as now using
10543 MemberName.ToString is an error (this is due to the side effects
10544 it had, that were fixed in the past).
10546 This will restore the error reporting on a number of partial class
10547 errors that were missusing this (and getting an exception as a
10548 results, which is now just a plain textual warning, because
10549 yyparse debug output would crash otherwise).
10551 2004-11-26 Raja R Harinath <rharinath@novell.com>
10553 * Makefile (PROGRAM_INSTALL_DIR): Remove.
10555 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10557 * rootcontext.cs (LookupType): Make sure to cache lookups that
10558 don't give us a negative result. This saves about 5% of corlib
10561 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10563 * report.cs (AbstractMessage.Print): messages are sent to stderr
10565 * class.cs (TypeContainer.GetClassBases): It is an error to have a
10566 non-interface in the list of interfaces (at this point, either
10567 parent was properly set, or a base class is being listed in the
10568 interfaces section).
10570 This flags error 1722, and resolves the crash from bug 69259.
10572 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10574 * statement.cs (Using.EmitExpressionFinally): make this work right
10575 for valuetypes. Fixes 69926.
10577 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10579 * const.cs (Const.ChangeType): Cope with the "0 literal can be
10580 converted to an enum" here, before we try to change the underlying
10581 type. This code exists, but it is a different code path than the
10582 one used while encoding constants.
10584 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
10585 old bug: when converting from the null literal to a pointer,
10586 return an EmptyCast, not the NullLiteral.
10588 This fixes #69921, the recent null_type changes probably made this
10589 bug more prominent.
10591 (ImplicitReferenceConversionExists): In addition, resynchronized
10592 the code here, so it matches the same code in
10593 ImplicitReferenceConversionExists for the `from any class-type S
10594 to any interface-type T'.
10597 2004-11-25 Marek Safar <marek.safar@seznam.cz>
10599 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
10601 2004-11-24 Miguel de Icaza <miguel@ximian.com>
10603 * cs-parser.jay: Use verbosity accordingly.
10605 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10607 * expression.cs (Unary.ResolveOperator): Do not report warning;
10608 AddressOf reads from variable.
10610 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
10612 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10616 * attribute.cs (Attributable): Removed CheckTargets.
10617 (Attributes.Emit): Explicit attribute targets are tested here.
10619 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
10620 not enabled for interfaces.
10622 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
10623 (GetAssemblyName): Ouch next bug there.
10625 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10627 * expression.cs: Error 275 added.
10629 2004-11-23 Marek Safar <marek.safar@seznam.cz>
10631 Fix bug #69177 (Implemented decimal constant support)
10633 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
10634 (BinaryFold): Add DecimalConstant.
10636 * const.cs (Define): Decimal constant
10638 (ChangeType): Add decimal type handling.
10639 (LookupConstantValue): Don't set value for decimal type but
10640 emit DecimalConstantAttribute. Needed for constant optimization.
10642 * constant.cs (ToDecimal): New method.
10643 (ConvertToDecimal): New method.
10644 (IntConstant): Implemented ConvertToDecimal.
10645 (DecimalConstant.Emit): Emit optimized version for decimals in
10648 * expression.cs (ResolveOperator): Changed order of constant
10649 reduction to work correctly with native types which have
10650 overloaded operators.
10651 (ResolveMemberAccess): Extract constant value from attribute
10654 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
10656 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
10657 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
10658 (ChangeType): Decimal is special.
10659 (TypeToCoreType): Add decimal type.
10661 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10663 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
10666 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10668 * class.cs (EventField.ApplyAttributeBuilder): Fix error
10671 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10673 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
10675 * pending.cs (PendingImplementation): Grab only interfaces.
10677 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10679 * statement.cs (ForeachHelperMethods): Add location member and
10680 error 202 detection.
10682 2004-11-19 Raja R Harinath <rharinath@novell.com>
10684 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
10685 automatically handled by executable.make.
10686 (PROGRAM): Make profile-specific.
10688 2004-11-18 Marek Safar <marek.safar@seznam.cz>
10690 * expression.cs (DoResolveBase): Fixed wrong warning for out
10693 2004-11-18 Martin Baulig <martin@ximian.com>
10695 Merged latest changes into gmcs. Please keep this comment in
10696 here, it makes it easier for me to see what changed in MCS since
10697 the last time I merged.
10699 2004-11-17 Raja R Harinath <rharinath@novell.com>
10701 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
10702 (TypeHandle.GetMemberCache): New.
10703 (TypeHandle.TypeHandle): Update.
10704 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
10705 (TypeManager.LookupParentInterfacesCache):
10706 Rename from LookupInterfaceCache. Optimize slightly.
10707 (TypeManager.MemberLookup_FindMembers): Update.
10708 * decl.cs (MemberCache.MemberCache): Set Container to null in the
10709 multi-type variant.
10710 (AddCacheContents): Rename from AddHashtable.
10711 * class.cs (TypeContainer.parent_container): Remove.
10712 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
10713 (TypeContainer.DoDefineMembers): Don't initialize it.
10714 Update to name changes.
10716 2004-11-17 Miguel de Icaza <miguel@ximian.com>
10718 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
10719 that factors the code to check access modifiers on override.
10721 (PropertyBase): Use the code here.
10723 Patch from Lluis S'anchez, fixes bug #69361.
10725 2004-11-15 Miguel de Icaza <miguel@ximian.com>
10727 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
10728 routine that is used to report the use of a captured variable
10729 whose address has been taken.
10731 There are two checks: one when variables are being captured and
10732 the other check is when the address of a variable is taken.
10734 (because an anonymous methods might be resolved before *or* after
10735 the address has been taken) and
10737 * expression.cs (Conditional.DoResolve): Remove the special
10738 casing that Martin added to trueExpr and falseExpr being both
10739 NullLiteral. We get the right behavior now just by introducing
10740 the null_type into the compiler.
10742 * convert.cs (ExplicitConversion): Change the code to use
10743 null_type instead of testing `expr is NullLiteral'.
10744 (ImplicitConversionStandard): use null_type too.
10745 (ImplicitReferenceConversionExists): use null_type too.
10746 (ImplicitReferenceConversion): use null_type too.
10748 * literal.cs: The type of `NullLiteral' is now null_type instead
10750 (Resolve): Set the type here.
10752 * typemanager.cs: Introduce null_type.
10754 2004-11-17 Martin Baulig <martin@ximian.com>
10756 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
10757 direction, like FindMembers() does. Fixes #69546, testcase is in
10760 2004-11-16 Martin Baulig <martin@ximian.com>
10762 This is based on a patch from Marek Safar, see bug #69082.
10763 Fixes bugs #63705 and #67130.
10765 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
10766 method; create a MemberCache for an interface type and cache the
10769 * decl.cs (IMemberContainer.ParentContainer): Removed.
10770 (IMemberContainer.ParentCache): New property.
10771 (MemberCache.SetupCacheForInterface): Removed.
10772 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
10773 to create a cache for an interface's "parent".
10775 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
10778 2004-11-16 Martin Baulig <martin@ximian.com>
10780 Merged back from gmcs; these changes already went into gmcs a
10781 couple of weeks ago.
10784 (TypeManager.AddUserType): Removed the `ifaces' argument.
10785 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
10787 (TypeManager.AddUserInterface): Removed.
10788 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
10790 (TypeManager.GetInterfaces): Likewise.
10791 (TypeManager.GetExplicitInterfaces): Likewise.
10793 * ecore.cs (TypeExpr.GetInterfaces): Removed.
10795 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
10796 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
10798 2004-11-14 Ben Maurer <bmaurer@ximian.com>
10800 * statement.cs: Avoid adding bools to a hashtable.
10802 2004-11-07 Miguel de Icaza <miguel@ximian.com>
10804 * expression.cs (Invocation.OverloadResolve): Flag error if we are
10805 calling an unsafe method from a safe location.
10807 2004-11-06 Marek Safar <marek.safar@seznam.cz>
10810 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
10812 2004-11-06 Miguel de Icaza <miguel@ximian.com>
10814 * namespace.cs (VerifyUsing): use GetPartialName instead of
10817 2004-11-05 Miguel de Icaza <miguel@ximian.com>
10819 * statement.cs (Return.Resolve): Fix regression in typo: if
10820 `in_exc', we have to request a NeedReturnLabel, this was a typo
10821 introduced in the anonymous method check-in. Fixes #69131.
10823 * Indexers were using the ShortName when defining themselves,
10824 causing a regression in the compiler bootstrap when applying the
10825 patch from 2004-11-02 (first part), now they use their full name
10826 and the bug is gone.
10828 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
10830 * driver.cs: Strip the path from the names of embedded resources. Fixes
10833 2004-11-04 Raja R Harinath <rharinath@novell.com>
10835 Fix error message regression: cs0104-2.cs.
10836 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
10837 (AliasEntry.Resolve): Update.
10838 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
10840 (RootContext.LookupType): Update.
10842 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
10844 * cs-parser.jay: Add support for handling accessor modifiers
10845 * class: Add support port accessor modifiers and error checking,
10846 define PropertyMethod.Define as virtual (not abstract anymore)
10847 * ecore.cs: Add checking for proeprties access with access modifiers
10848 * iterators.cs: Modify Accessor constructor call based in the modified
10850 2004-11-02 Ben Maurer <bmaurer@ximian.com>
10852 * expression.cs (StringConcat): Handle being called twice,
10853 as when we have a concat in a field init with more than two
10856 2004-11-02 Miguel de Icaza <miguel@ximian.com>
10858 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
10859 special case explicit implementations, we should always produce
10860 the .property or .event declaration.
10862 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
10863 since it will not return correct data if people use this
10864 unresolved in the presence of using statements (see test-313).
10866 * class.cs (MethodData.Define): If we are an explicit interface
10867 implementation, set the method name to the full name of the
10868 interface plus the name of the method.
10870 Notice that using the method.MethodName.GetFullName() does not
10871 work, as it will only contain the name as declared on the source
10872 file (it can be a shorthand in the presence of using statements)
10873 and not the fully qualifed type name, for example:
10877 class D : ICloneable {
10878 object ICloneable.Clone () {
10882 Would produce a method called `ICloneable.Clone' instead of
10883 `System.ICloneable.Clone'.
10885 * namespace.cs (Alias.Resolve): Use GetPartialName.
10887 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10889 * cs-parser.jay: Add error 1055 report.
10891 2004-11-01 Miguel de Icaza <miguel@ximian.com>
10893 * assign.cs (Assign.DoResolve): Only do the transform of
10894 assignment into a New if the types are compatible, if not, fall
10895 through and let the implicit code deal with the errors and with
10896 the necessary conversions.
10898 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10900 * cs-parser.jay: Add error 1031 report.
10902 * cs-tokenizer.cs: Add location for error 1038.
10904 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10906 * cs-parser.jay: Add error 1016 report.
10908 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10910 * cs-parser.jay: Add errors 1575,1611 report.
10912 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10914 * cs-parser.jay: Add error 1001 report.
10916 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10919 * attribute.cs (GetMarshal): Add method argument for
10920 caller identification.
10922 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
10923 agument for GetMarshal and RuntimeMissingSupport.
10925 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10927 * attribute.cs (ExtractSecurityPermissionSet): Removed
10928 TypeManager.code_access_permission_type.
10930 * typemanager.cs: Removed TypeManager.code_access_permission_type.
10932 2004-10-27 Miguel de Icaza <miguel@ximian.com>
10934 * expression.cs (LocalVariableReference.DoResolveLValue): Check
10935 for obsolete use of a variable here. Fixes regression on errors
10936 cs0619-25 and cs0619-26.
10938 2004-10-27 Marek Safar <marek.safar@seznam.cz>
10940 Fix #62358, implemented security attribute encoding.
10942 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
10943 Tests permitted SecurityAction for assembly or other types.
10944 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
10945 data from SecurityPermissionAttribute to PermisionSet class.
10947 * class.cs (ApplyAttributeBuilder): Added special handling
10948 for System.Security.Permissions.SecurityAttribute based types.
10950 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
10951 special handling for System.Security.Permissions.SecurityAttribute
10954 * enum.cs (ApplyAttributeBuilder): Added special handling
10955 for System.Security.Permissions.SecurityAttribute based types.
10957 * parameter.cs (ApplyAttributeBuilder): Added special handling
10958 for System.Security.Permissions.SecurityAttribute based types.
10960 * rootcontext.cs: Next 2 core types.
10962 * typemanager.cs (TypeManager.security_permission_attr_type):
10963 Built in type for the SecurityPermission Attribute.
10964 (code_access_permission_type): Build in type.
10966 2004-10-17 Miguel de Icaza <miguel@ximian.com>
10968 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
10969 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
10970 all of this information into
10971 EmitContext.EmitCapturedVariableInstance.
10973 * codegen.cs (EmitCapturedVariableInstance): move here the
10974 funcionality of emitting an ldarg.0 in the presence of a
10975 remapping. This centralizes the instance emit code.
10977 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
10978 then emit a load of this: it means that we have reached the
10979 topmost ScopeInfo: the one that contains the pointer to the
10980 instance of the class hosting the anonymous method.
10982 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
10983 captures to the topmost CaptureContext.
10985 2004-10-12 Miguel de Icaza <miguel@ximian.com>
10987 * expression.cs (LocalVariableReference): Move the knowledge about
10988 the iterators into codegen's EmitCapturedVariableInstance.
10990 2004-10-11 Miguel de Icaza <miguel@ximian.com>
10992 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
10993 all code paths return a value from an anonymous method (it is the
10994 same as the 161 error, but for anonymous methods).
10996 2004-10-08 Miguel de Icaza <miguel@ximian.com>
10998 The introduction of anonymous methods in the compiler changed
10999 various ways of doing things in the compiler. The most
11000 significant one is the hard split between the resolution phase
11001 and the emission phases of the compiler.
11003 For instance, routines that referenced local variables no
11004 longer can safely create temporary variables during the
11005 resolution phase: they must do so from the emission phase,
11006 since the variable might have been "captured", hence access to
11007 it can not be done with the local-variable operations from the runtime.
11011 (Block.Flags): New flag `IsTopLevel' to indicate that this block
11012 is a toplevel block.
11014 (ToplevelBlock): A new kind of Block, these are the blocks that
11015 are created by the parser for all toplevel method bodies. These
11016 include methods, accessors and anonymous methods.
11018 These contain some extra information not found in regular blocks:
11019 A pointer to an optional CaptureContext (for tracking captured
11020 local variables and parameters). A pointer to the parent
11023 (Return.Resolve): Catch missmatches when returning a value from an
11024 anonymous method (error 1662).
11025 Invoke NeedReturnLabel from the Resolve phase instead of the emit
11028 (Break.Resolve): ditto.
11030 (SwitchLabel): instead of defining the labels during the
11031 resolution phase, we now turned the public ILLabel and ILLabelCode
11032 labels into methods called GetILLabelCode() and GetILLabel() that
11033 only define the label during the Emit phase.
11035 (GotoCase): Track the SwitchLabel instead of the computed label
11036 (its contained therein). Emit the code by using
11037 SwitchLabel.GetILLabelCode ().
11039 (LocalInfo.Flags.Captured): A new flag has been introduce to track
11040 whether the Local has been captured or not.
11042 (LocalInfo.IsCaptured): New property, used to tell whether the
11043 local has been captured.
11045 * anonymous.cs: Vastly updated to contain the anonymous method
11048 The main classes here are: CaptureContext which tracks any
11049 captured information for a toplevel block and ScopeInfo used to
11050 track the activation frames for various local variables.
11052 Each toplevel block has an optional capture context associated
11053 with it. When a method contains an anonymous method both the
11054 toplevel method and the anonymous method will create a capture
11055 context. When variables or parameters are captured, they are
11056 recorded on the CaptureContext that owns them, for example:
11060 MyDelegate d = delegate {
11065 Here `a' will be recorded as captured on the toplevel
11066 CapturedContext, the inner captured context will not have anything
11067 (it will only have data if local variables or parameters from it
11068 are captured in a nested anonymous method.
11070 The ScopeInfo is used to track the activation frames for local
11071 variables, for example:
11073 for (int i = 0; i < 10; i++)
11074 for (int j = 0; j < 10; j++){
11075 MyDelegate d = delegate {
11080 At runtime this captures a single captured variable `i', but it
11081 captures 10 different versions of the variable `j'. The variable
11082 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
11083 recorded on a child.
11085 The toplevel ScopeInfo will also track information like the `this'
11086 pointer if instance variables were referenced (this is necessary
11087 as the anonymous method lives inside a nested class in the host
11088 type of the method).
11090 (AnonymousMethod): Expanded to track the Toplevel, implement
11091 `AnonymousMethod.Compatible' to tell whether an anonymous method
11092 can be converted to a target delegate type.
11094 The routine now also produces the anonymous method content
11096 (AnonymousDelegate): A helper class that derives from
11097 DelegateCreation, this is used to generate the code necessary to
11098 produce the delegate for the anonymous method that was created.
11100 * assign.cs: API adjustments for new changes in
11101 Convert.ImplicitStandardConversionExists.
11103 * class.cs: Adjustments to cope with the fact that now toplevel
11104 blocks are of type `ToplevelBlock'.
11106 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
11107 insteda of standard blocks.
11109 Flag errors if params arguments are passed to anonymous methods.
11111 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
11112 `CurrentAnonymousMethod' which points to the current Anonymous
11113 Method. The variable points to the AnonymousMethod class that
11114 holds the code being compiled. It is set in the new EmitContext
11115 created for the anonymous method.
11117 (EmitContext.Phase): Introduce a variable and an enumeration to
11118 assist in enforcing some rules about when and where we are allowed
11119 to invoke certain methods (EmitContext.NeedsReturnLabel is the
11120 only one that enfonces this right now).
11122 (EmitContext.HaveCaptureInfo): new helper method that returns
11123 whether we have a CapturedContext initialized.
11125 (EmitContext.CaptureVariable): New method used to register that a
11126 LocalInfo must be flagged for capturing.
11128 (EmitContext.CapturedParameter): New method used to register that a
11129 parameters must be flagged for capturing.
11131 (EmitContext.CapturedField): New method used to register that a
11132 field must be flagged for capturing.
11134 (EmitContext.HaveCapturedVariables,
11135 EmitContext.HaveCapturedFields): Return whether there are captured
11136 variables or fields.
11138 (EmitContext.EmitMethodHostInstance): This is used to emit the
11139 instance for the anonymous method. The instance might be null
11140 (static methods), this (for anonymous methods that capture nothing
11141 and happen to live side-by-side with the current method body) or a
11142 more complicated expression if the method has a CaptureContext.
11144 (EmitContext.EmitTopBlock): Routine that drives the emission of
11145 code: it will first resolve the top block, then emit any metadata
11146 and then emit the code. The split is done so that we can extract
11147 any anonymous methods and flag any captured variables/parameters.
11149 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
11150 during this phase, the ILGenerator should not be used as labels
11151 and local variables declared here might not be accessible to any
11152 code that is part of an anonymous method.
11154 Exceptions to this include the temporary variables that are
11155 created by some statements internally for holding temporary
11158 (EmitContext.EmitMeta): New routine, in charge of emitting all the
11161 (EmitContext.TemporaryReturn): This method is typically called
11162 from the Emit phase, and its the only place where we allow the
11163 ReturnLabel to be defined other than the EmitMeta. The reason is
11164 that otherwise we would have to duplicate a lot of logic in the
11165 Resolve phases of various methods that today is on the Emit
11168 (EmitContext.NeedReturnLabel): This no longer creates the label,
11169 as the ILGenerator is not valid during the resolve phase.
11171 (EmitContext.EmitThis): Extended the knowledge in this class to
11172 work in anonymous methods in addition to iterators.
11174 (EmitContext.EmitCapturedVariableInstance): This emits whatever
11175 code is necessary on the stack to access the instance to a local
11176 variable (the variable will be accessed as a field).
11178 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
11179 EmitContext.EmitAddressOfParameter): Routines to support
11180 parameters (not completed at this point).
11182 Removals: Removed RemapLocal and RemapLocalLValue. We probably
11183 will also remove the parameters.
11185 * convert.cs (Convert): Define a `ConstantEC' which points to a
11186 null. This is just to prefity some code that uses
11187 ImplicitStandardConversion code and do not have an EmitContext
11190 The idea is to flag explicitly that at that point in time, it is
11191 known that the conversion will not trigger the delegate checking
11192 code in implicit conversions (which requires a valid
11195 Everywhere: pass new EmitContext parameter since
11196 ImplicitStandardConversionExists now requires it to check for
11197 anonymous method conversions.
11199 (Convert.ImplicitStandardConversionExists): If the type of an
11200 expression is the anonymous_method_type, and the type is a
11201 delegate, we invoke the AnonymousMethod.Compatible method to check
11202 whether an implicit conversion is possible.
11204 (Convert.ImplicitConversionStandard): Only do implicit method
11205 group conversions if the language level is not ISO_1.
11207 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
11208 MethodInfo for the Invoke method. used by Delegate and
11211 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
11212 method conversions if the target type is a delegate.
11214 Removed extra debugging nops.
11216 (LocalVariableReference): Turn the `local_info' into a public
11219 Add `prepared' field, the same hack used for FieldExprs to cope
11220 with composed assignments, as Local variables do not necessarily
11221 operate purely on the stack as they used to: they can be captured
11224 Add `temp' for a temporary result, like fields.
11226 Refactor DoResolve and DoResolveLValue into DoResolveBase.
11228 It now copes with Local variables that are captured and emits the
11229 proper instance variable to load it from a field in the captured
11232 (ParameterReference.DoResolveBase): During the resolve phase,
11233 capture parameters if we are in an anonymous method.
11235 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
11236 anonymous method, use the EmitContext helper routines to emit the
11237 parameter reference.
11239 * iterators.cs: Set RemapToProxy to true/false during the
11242 * parameters.cs (GetParameterByName): New helper method.
11244 * typemanager.cs (anonymous_method_type) a new type that
11245 represents an anonyous method. This is always an internal type,
11246 used as a fencepost to test against the anonymous-methodness of an
11249 2004-10-20 Marek Safar <marek.safar@seznam.cz>
11251 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
11253 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
11255 2004-10-18 Martin Baulig <martin@ximian.com>
11257 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
11258 `Type' directly, but call ResolveType() on it.
11259 (Catch.Resolve): Likewise.
11260 (Foreach.Resolve): Likewise.
11262 2004-10-18 Martin Baulig <martin@ximian.com>
11264 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
11265 `Type' directly, but call ResolveType() on it.
11266 (Probe.DoResolve): Likewise.
11267 (ArrayCreation.LookupType): Likewise.
11268 (TypeOf.DoResolve): Likewise.
11269 (SizeOf.DoResolve): Likewise.
11271 2004-10-18 Martin Baulig <martin@ximian.com>
11273 * expression.cs (Invocation.BetterFunction): Put back
11274 TypeManager.TypeToCoreType().
11276 2004-10-18 Raja R Harinath <rharinath@novell.com>
11278 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
11281 2004-10-18 Martin Baulig <martin@ximian.com>
11283 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
11284 `Type' directly, but call ResolveType() on it.
11286 2004-10-18 Martin Baulig <martin@ximian.com>
11288 * class.cs (FieldMember.Define): Don't access the TypeExpr's
11289 `Type' directly, but call ResolveType() on it.
11290 (MemberBase.DoDefine): Likewise.
11292 * expression.cs (New.DoResolve): Don't access the TypeExpr's
11293 `Type' directly, but call ResolveType() on it.
11294 (ComposedCast.DoResolveAsTypeStep): Likewise.
11296 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
11297 `Type' directly, but call ResolveType() on it.
11299 2004-10-17 John Luke <john.luke@gmail.com>
11301 * class.cs (Operator.GetSignatureForError): use CSharpName
11303 * parameter.cs (Parameter.GetSignatureForError): Returns
11304 correct name even if was not defined.
11306 2004-10-13 Raja R Harinath <rharinath@novell.com>
11309 * class.cs (TypeContainer.EmitContext): New property.
11310 (DefineNestedTypes): Create an emitcontext for each part.
11311 (MethodCore.DoDefineParameters): Use container's emitcontext.
11312 Pass type array to InternalParameters.
11313 (MemberBase.DoDefine): Use container's emitcontext.
11314 (FieldMember.Define): Likewise.
11315 (Event.Define): Likewise.
11316 (SetMethod.GetParameterInfo): Change argument to EmitContext.
11317 Pass type array to InternalParameters.
11318 (SetIndexerMethod.GetParameterInfo): Likewise.
11319 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
11320 * delegate.cs (Define): Pass emitcontext to
11321 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
11322 array to InternalParameters.
11323 * expression.cs (ParameterReference.DoResolveBase): Pass
11324 emitcontext to GetParameterInfo.
11325 (ComposedCast.DoResolveAsTypeStep): Remove check on
11326 ec.ResolvingTypeTree.
11327 * parameter.cs (Parameter.Resolve): Change argument to
11328 EmitContext. Use ResolveAsTypeTerminal.
11329 (Parameter.GetSignature): Change argument to EmitContext.
11330 (Parameters.ComputeSignature): Likewise.
11331 (Parameters.ComputeParameterTypes): Likewise.
11332 (Parameters.GetParameterInfo): Likewise.
11333 (Parameters.ComputeAndDefineParameterTypes): Likewise.
11334 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
11335 * support.cs (InternalParameters..ctor): Remove variant that takes
11337 * typemanager.cs (system_intptr_expr): New.
11338 (InitExpressionTypes): Initialize it.
11340 2004-10-12 Chris Toshok <toshok@ximian.com>
11342 * cs-parser.jay: fix location for try_statement and catch_clause.
11344 2004-10-11 Martin Baulig <martin@ximian.com>
11346 * report.cs: Don't make --fatal abort on warnings, we have
11347 -warnaserror for that.
11349 2004-10-07 Raja R Harinath <rharinath@novell.com>
11351 More DeclSpace.ResolveType avoidance.
11352 * decl.cs (MemberCore.InUnsafe): New property.
11353 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
11354 with newly created EmitContext.
11355 (FieldMember.Define): Likewise.
11356 * delegate.cs (Delegate.Define): Likewise.
11357 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
11358 only if normal name-lookup fails.
11359 (TypeExpr.DoResolve): Enable error-checking.
11360 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
11361 (SizeOf.DoResolve): Likewise.
11362 (ComposedCast.DoResolveAsTypeStep): Likewise.
11363 (StackAlloc.DoResolve): Likewise.
11364 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
11365 (Block.Unsafe): New property.
11366 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
11367 (Unsafe): Set 'unsafe' flag of contained block.
11368 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
11369 (Fixed.Resolve): Likewise.
11370 (Catch.Resolve): Likewise.
11371 (Using.ResolveLocalVariableDecls): Likewise.
11372 (Foreach.Resolve): Likewise.
11374 2004-10-05 John Luke <john.luke@gmail.com>
11376 * cs-parser.jay: add location to error CS0175
11378 2004-10-04 Miguel de Icaza <miguel@ximian.com>
11380 * ecore.cs (Expression.Constantity): Add support for turning null
11383 * const.cs (Const.Define): Allow constants to be reference types
11384 as long as the value is Null.
11386 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
11388 * namespace.cs (NamespaceEntry.Using): No matter which warning
11389 level is set, check if this namespace name has already been added.
11391 2004-10-03 Ben Maurer <bmaurer@ximian.com>
11393 * expression.cs: reftype [!=]= null should always use br[true,false].
11396 2004-10-03 Marek Safar <marek.safar@seznam.cz>
11399 * attribute.cs: Enum conversion moved to
11400 GetAttributeArgumentExpression to be applied to the all
11403 2004-10-01 Raja R Harinath <rharinath@novell.com>
11405 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
11406 * class.c (TypeContainer.DefineType): Flag error if
11407 base types aren't accessible due to access permissions.
11408 * decl.cs (DeclSpace.ResolveType): Move logic to
11409 Expression.ResolveAsTypeTerminal.
11410 (DeclSpace.ResolveTypeExpr): Thin layer over
11411 Expression.ResolveAsTypeTerminal.
11412 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
11413 Refactor code into NestedAccess. Use it.
11414 (DeclSpace.NestedAccess): New.
11415 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
11416 argument to silence errors. Check access permissions.
11417 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
11418 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
11419 (Cast.DoResolve): Likewise.
11420 (New.DoResolve): Likewise.
11421 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
11422 (TypeOf.DoResolve): Likewise.
11424 * expression.cs (Invocation.BetterConversion): Return the Type of
11425 the better conversion. Implement section 14.4.2.3 more faithfully.
11426 (Invocation.BetterFunction): Make boolean. Make correspondence to
11427 section 14.4.2.2 explicit.
11428 (Invocation.OverloadResolve): Update.
11429 (Invocation): Remove is_base field.
11430 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
11431 (Invocation.Emit): Likewise.
11433 2004-09-27 Raja R Harinath <rharinath@novell.com>
11435 * README: Update to changes.
11437 2004-09-24 Marek Safar <marek.safar@seznam.cz>
11439 * cs-parser.jay: Reverted 642 warning fix.
11441 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11444 * decl.cs (FindMemberWithSameName): Indexer can have more than
11447 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11449 * expression.cs (LocalVariableReference.DoResolveLValue):
11450 Do not report warning 219 for out values.
11451 (EmptyExpression.Null): New member to avoid extra allocations.
11453 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11455 * cs-parser.jay: Fix wrong warning 642 report.
11457 * cs-tokenizer.cs (CheckNextToken): New helper;
11458 Inspect next character if is same as expected.
11460 2004-09-23 Martin Baulig <martin@ximian.com>
11462 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
11463 (Convert.ImplicitReferenceConversionExists): Likewise.
11465 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11467 * class.cs (Operator.Define): Add error 448 and 559 report.
11469 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11471 * class.cs (MemberBase.IsTypePermitted): New protected
11472 method for checking error CS0610.
11474 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11476 * class.cs (TypeContainer.HasExplicitLayout): New property
11477 Returns whether container has StructLayout attribute set Explicit.
11478 (FieldMember): New abstract class for consts and fields.
11479 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
11480 (Field): Reuse FieldMember.
11482 * const.cs (Const): Reuse FieldMember.
11484 * rootcontext.cs: EmitConstants call moved to class.
11486 2004-09-22 Martin Baulig <martin@ximian.com>
11488 Thanks to Peter Sestoft for this bug report.
11490 * expression.cs (Conditional): If both the `trueExpr' and the
11491 `falseExpr' is a NullLiteral, return a NullLiteral.
11493 2004-09-22 Martin Baulig <martin@ximian.com>
11495 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
11496 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
11497 for the "get_Current" call.
11499 2004-09-22 Martin Baulig <martin@ximian.com>
11501 Marek and me just fixed one of our oldest bugs: #28562 :-)
11503 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
11505 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
11506 we're an EnumConstant, just return that.
11507 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
11508 an EnumConstant. In this case, we need to use GetValueAsEnumType()
11509 to get the value which'll actually be written into the attribute.
11510 However, we have to use GetValue() to access the attribute's value
11513 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11515 * constant.cs (Constant.IsNegative): New abstract property
11518 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
11519 (StackAlloc.DoResolve): Reused IsNegative.
11521 2004-09-21 Martin Baulig <martin@ximian.com>
11523 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
11524 if we're used in an iterator, we may be called from different
11527 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
11528 we actually have an exception block.
11530 2004-09-20 John Luke <jluke@cfl.rr.com>
11532 * class.cs, cs-parser.jay: Improve the error report for 1520:
11533 report the actual line where the error happens, not where the
11534 class was declared.
11536 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
11537 Pass location information that was available elsewhere.
11539 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
11541 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
11542 runtime to delay sign assemblies.
11544 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11546 * cs-parser.jay: Do not report the stack trace, this is barely
11549 2004-08-22 John Luke <john.luke@gmail.com>
11551 * driver.cs : check that a resource id is not already used
11552 before adding it, report CS1508 if it is, bug #63637
11554 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11556 * ecore.cs: Removed dead code.
11558 2004-09-18 Marek Safar <marek.safar@seznam.cz>
11560 * class.cs: Do not report warning CS0067 on the interfaces.
11562 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11564 * cs-parser.jay: Add error 504 report.
11566 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11568 * rootcontext.cs: WarningLevel is 4 by default now.
11570 * statement.cs (Fixed.Resolve): Do not null
11573 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11576 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
11577 deep search when property is not virtual.
11578 (PropertyExpr.ResolveAccessors): Make one call for both
11581 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11584 * statement.cs: Error 152 report constains also location.
11586 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11589 * const.cs: Explicitly set constant as static.
11591 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11594 * cs-parser.jay: Add error 1017 report.
11596 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11598 Fixed bug #59980, #64224
11599 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
11601 * typemanager.cs (IsSpecialMethod): Simplified
11603 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11605 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11606 condition with better params.
11608 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11611 * attribute.cs (Resolve): Property has to have both
11614 2004-09-14 Martin Baulig <martin@ximian.com>
11616 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
11618 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11621 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
11622 called and is obsolete then this member suppress message
11623 when call is inside next [Obsolete] method or type.
11625 * expression.cs: Use TestObsoleteMethodUsage member.
11627 2004-09-14 Martin Baulig <martin@ximian.com>
11629 * cs-parser.jay: Sync a bit with the GMCS version.
11631 2004-09-14 Martin Baulig <martin@ximian.com>
11633 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
11634 (CSharpParser.yacc_verbose_flag): New public field.
11636 * genericparser.cs: Removed.
11638 2004-09-14 Raja R Harinath <rharinath@novell.com>
11640 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
11642 2004-09-13 Marek Safar <marek.safar@seznam.cz>
11644 * class.cs (MethodCore.CheckBase): Fix bug #65757.
11646 2004-09-10 Martin Baulig <martin@ximian.com>
11648 Backported my MemberName changes from GMCS into MCS.
11650 - we are now using a special `MemberName' class instead of using
11651 strings; in GMCS, the `MemberName' also contains the type
11654 - changed the grammar rules a bit:
11655 * the old `member_name' is now a `namespace_or_type_name':
11656 The rule is that we use `namespace_or_type_name' everywhere
11657 where we expect either a "member name" (GetEnumerator) or a
11658 "member name" with an explicit interface name
11659 (IEnumerable.GetEnumerator).
11660 In GMCS, the explicit interface name may include type arguments
11661 (IEnumerable<T>.GetEnumerator).
11662 * we use `member_name' instead of just `IDENTIFIER' for
11664 The rule is that we use `member_name' wherever a member may
11665 have type parameters in GMCS.
11667 * decl.cs (MemberName): New public class.
11668 (MemberCore.MemberName): New public readonly field.
11669 (MemberCore.ctor): Take a `MemberName' argument, not a string.
11670 (DeclSpace): Likewise.
11672 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
11673 * enum.cs (Enum.ctor): Likewise.
11675 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
11677 (AliasEntry.ctor): Take a MemberName, not an Expression.
11678 (AliasEntry.UsingAlias): Likewise.
11680 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
11681 (IMethodData.MemberName): Changed type from string to MemberName.
11682 (MemberBase.ExplicitInterfaceName): Likewise.
11683 (AbstractPropertyEventMethod.SetupName): Make this private.
11684 (AbstractPropertyEventMethod.ctor): Added `string prefix'
11685 argument; compute the member name here.
11686 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
11687 on the `member.MemberName' and the `prefix'.
11689 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
11691 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
11692 thus, we get a `MemberName' instead of a `string'. These
11693 declarations may have type parameters in GMCS.
11694 (interface_method_declaration, delegate_declaration): Likewise.
11695 (class_declaration, interface_declaration): Likewise.
11696 (method_header): Use `namespace_or_type_name' instead of
11697 `member_name'. We may be an explicit interface implementation.
11698 (property_declaration, event_declaration): Likewise.
11699 (member_name): This is now just an `IDENTIFIER', not a
11700 `namespace_or_type_name'.
11701 (type_name, interface_type): Removed.
11702 (namespace_or_type_name): Return a MemberName, not an Expression.
11703 (primary_expression): Use `member_name' instead of `IDENTIFIER';
11704 call GetTypeExpression() on the MemberName to get an expression.
11705 (IndexerDeclaration.interface_type): Changed type from string to
11707 (MakeName): Operate on MemberName's instead of string's.
11709 2004-09-13 Raja R Harinath <rharinath@novell.com>
11712 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
11713 (NamespaceEntry.Lookup): Add new argument to flag if we want the
11714 lookup to avoid symbols introduced by 'using'.
11715 * rootcontext.cs (NamespaceLookup): Update.
11717 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11719 * class.cs (TypeContainer.DoDefineMembers): Do not call
11720 DefineDefaultConstructor for static classes.
11722 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11724 * attribute.cs (Attribute.Resolve): Add error 653 report.
11726 * class.cs (Class.ApplyAttributeBuilder): Add error 641
11728 (Method.ApplyAttributeBuilder): Add error 685 report.
11729 (Operator.Define): Add error 564 report.
11731 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
11733 * expression.cs (Invocation.DoResolve): Add error
11734 245 and 250 report.
11736 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
11739 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11741 * class.cs (ConstructorInitializer.Resolve):
11742 Wrong error number (515->516).
11744 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11746 * class.cs (Indexer.Define): Add error 631 report.
11748 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11750 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
11752 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11754 * expression.cs (Probe.DoResolve): Add error CS0241 report.
11756 2004-09-10 Marek Safar <marek.safar@seznam.cz>
11758 * cs-parser.jay: Added error CS0241 report.
11760 2004-09-10 Raja R Harinath <rharinath@novell.com>
11762 * cs-parser.jay (fixed_statement): Introduce a scope for the
11763 declaration in the 'fixed' statement.
11765 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11767 * cs-parser.jay: Added CS0230 error report.
11769 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11771 * cs-parser.jay: Added errors CS0231 and CS0257 report.
11773 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11775 * expression.cs (Argument.Resolve): Added error CS0192 and
11778 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11780 C# 2.0 #pragma warning feature
11782 * cs-tokenizer.cs (PreProcessPragma): New method;
11783 Handles #pragma directive.
11785 * report.cs (WarningRegions): New class; Support
11786 class for #pragma warning directive. It tests whether
11787 warning is enabled for a given line.
11789 2004-09-08 Miguel de Icaza <miguel@ximian.com>
11791 * const.cs: Add more descriptive error report, tahnks to
11794 2004-09-08 Marek Safar <marek.safar@seznam.cz>
11796 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
11798 2004-09-07 Miguel de Icaza <miguel@ximian.com>
11800 * expression.cs: Apply patch from Ben: Remove dead code from
11801 ArrayCreation, and remove the TurnintoConstant call in const.cs,
11802 as that code just threw an exception anwyays.
11804 * const.cs: Remove the call to the turnintoconstant, for details
11807 * literal.cs: The type of the null-literal is the null type; So
11808 we use a placeholder type (literal.cs:System.Null, defined here)
11811 * expression.cs (Conditional.DoResolve): Remove some old code that
11812 is no longer needed, conversions have been fixed.
11814 (ArrayCreationExpression.DoResolve): Return false if we fail to
11815 resolve the inner expression.
11817 2004-09-07 Raja R Harinath <rharinath@novell.com>
11820 * cs-parser.jay (delegate_declaration): Record a delegate
11821 declaration as a type declaration.
11822 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
11824 2004-09-06 Miguel de Icaza <miguel@ximian.com>
11826 * parameter.cs: Do not crash if the type can not be resolved.
11828 * expression.cs: Report errors with unsafe pointers, fixes #64896
11830 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
11832 * expression.cs: Pointer arith always needs to do a conv.i
11833 if the operand is a long. fix 65320
11835 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11837 Fixed cs0619-37.cs, cs0619-38.cs
11839 * enum.cs (GetObsoleteAttribute): Removed.
11841 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
11842 on Enum member is double staged. The first is tested member
11845 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11847 Fixed #56986, #63631, #65231
11849 * class.cs: (TypeContainer.AddToMemberContainer): New method,
11850 adds member to name container.
11851 (TypeContainer.AddToTypeContainer): New method, adds type to
11853 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
11854 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
11855 AddOperator): Simplified by reusing AddToMemberContainer.
11856 (TypeContainer.UserDefinedStaticConstructor): Changed to property
11858 (Method.CheckForDuplications): Fixed implementation to test all
11860 (MemberBase): Detection whether member is explicit interface
11861 implementation is now in constructor.
11862 (MemberBase.UpdateMemberName): Handles IndexerName.
11863 (Accessor): Changed to keep also location information.
11864 (AbstractPropertyEventMethod): Is derived from MemberCore.
11865 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
11866 will be emited or not.
11867 (PropertyBase.AreAccessorsDuplicateImplementation):
11868 Tests whether accessors are not in collision with some method.
11869 (Operator): Is derived from MethodCore to simplify common
11872 * decl.cs (Flags.TestMethodDuplication): Test for duplication
11874 (DeclSpace.AddToContainer): Adds the member to defined_names
11875 table. It tests for duplications and enclosing name conflicts.
11877 * enum.cs (EnumMember): Clean up to reuse the base structures
11879 2004-09-03 Martin Baulig <martin@ximian.com>
11881 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
11882 into TypeContainer, to make partial classes work again.
11884 2004-09-03 Martin Baulig <martin@ximian.com>
11886 * rootcontext.cs (RootContext.V2): Removed.
11888 2004-03-23 Martin Baulig <martin@ximian.com>
11890 * expression.cs (Invocation.OverloadResolve): Added `bool
11891 may_fail' argument and use it instead of the Location.IsNull() hack.
11893 2004-09-03 Martin Baulig <martin@ximian.com>
11895 Merged latest changes into gmcs. Please keep this comment in
11896 here, it makes it easier for me to see what changed in MCS since
11897 the last time I merged.
11899 2004-09-03 Raja R Harinath <rharinath@novell.com>
11902 * expression.cs (BetterConversion): Don't allow either conversion
11903 to be null. Remove redundant implicit conversion test when 'q ==
11904 null' -- when this function is invoked, we already know that the
11905 implicit conversion exists.
11906 (BetterFunction): Assume that 'best' is non-null. Remove
11907 redundant reimplementation of IsApplicable when 'best' is null.
11908 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
11909 number of arguments.
11910 (IsAncestralType): Extract from OverloadResolve.
11911 (OverloadResolve): Make robust to the MethodGroupExpr being
11912 unsorted. Implement all the logic of Section 14.5.5.1, and
11913 support overloading of methods from multiple applicable types.
11914 Clean up logic somewhat. Don't pass null methods to BetterFunction.
11916 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
11917 (RealError, Warning): Append type of report to related symbol.
11919 2004-09-03 Marek Safar <marek.safar@seznam.cz>
11921 * enum.cs: Fixed CLS-Compliance checks for enum members.
11922 Error tests cs3008-8.cs, cs3014-8.cs
11924 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11926 Fixed bug #62342, #63102
11927 * class.cs: ImplementIndexer uses member.IsExplicitImpl
11928 like ImplementMethod.
11930 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11932 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11935 2004-09-02 Martin Baulig <martin@ximian.com>
11937 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
11938 TypeManager.GetArgumentTypes() rather than calling GetParameters()
11941 2004-09-01 Marek Safar <marek.safar@seznam.cz>
11943 C# 2.0 Static classes implemented
11945 * class.cs (TypeContainer): instance_constructors,
11946 initialized_fields, initialized_static_fields,
11947 default_constructor, base_inteface_types are protected to be
11948 accessible from StaticClass.
11949 (TypeContainer.DefineDefaultConstructor): New virtual method
11950 for custom default constructor generating
11951 (StaticClass): New class to handle "Static classes" feature.
11953 * cs-parser.jay: Handle static keyword on class like instance
11956 * driver.cs: Added "/langversion" command line switch with two
11957 options (iso-1, default).
11959 2004-08-31 Marek Safar <marek.safar@seznam.cz>
11961 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
11963 2004-08-31 Miguel de Icaza <miguel@ximian.com>
11965 * delegate.cs: Style.
11967 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
11969 * delegate.cs: Add seperate instance expr field for miguel.
11971 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11973 * PointerArithmetic (Resolve): make sure we are not doing
11974 pointer arith on void*. Also, make sure we are resolved
11975 by not setting eclass until resolve.
11977 All callers: Make sure that PointerArithmetic gets resolved.
11979 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11981 * ArrayCreation (LookupType): If the type does not resolve
11982 to an array, give an error.
11984 2004-08-27 Marek Safar <marek.safar@seznam.cz>
11986 * statement.cs (Try.Resolve): Fixed bug #64222
11988 2004-08-27 Martin Baulig <martin@ximian.com>
11991 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
11994 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11996 * ecore.cs (Constantify): Get underlying type via
11997 System.Enum.GetUnderlyingType to avoid StackOverflow on the
11998 Windows in special cases.
12000 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12002 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
12003 for obtaining also private methods.
12004 (GetRemoveMethod): Used GetRemoveMethod (true)
12005 for obtaining also private methods.
12007 2004-08-24 Martin Baulig <martin@ximian.com>
12009 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
12010 MethodAttributes.HideBySig for operators.
12012 2004-08-23 Martin Baulig <martin@ximian.com>
12014 Back to the old error reporting system :-)
12016 * report.cs (Message): Removed.
12017 (Report.MessageData, ErrorData, WarningData): Removed.
12018 (Report.Error, Warning): Back to the old system.
12020 2004-08-23 Martin Baulig <martin@ximian.com>
12022 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
12024 * class.cs (TypeContainer.ParentContainer): New public virtual
12025 method; replaces the explicit interface implementation.
12026 (ClassPart.ParentContainer): Override.
12028 2004-08-23 Martin Baulig <martin@ximian.com>
12030 * statement.cs (Switch): Added support for constant switches; see
12031 #59428 or test-285.cs.
12033 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12036 * statement.cs (GetEnumeratorFilter): Removed useless
12037 logic because C# specs is strict. GetEnumerator must be
12040 2004-08-22 Martin Baulig <martin@ximian.com>
12042 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12043 a switch and may break, reset the barrier. Fixes #59867.
12045 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12047 CLS-Compliance speed up (~5% for corlib)
12049 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
12050 New method. Tests container for CLS-Compliant names
12052 * class.cs (TypeContainer.VerifyClsName): New method.
12053 Checks whether container name is CLS Compliant.
12054 (Constructor): Implements IMethodData.
12056 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
12057 low-case table for CLS Compliance test.
12058 (MemberCache.VerifyClsParameterConflict): New method.
12059 Checks method parameters for CS3006 error.
12061 * enum.cs (EnumMember): Is derived from MemberCore.
12062 (Enum.VerifyClsName): Optimized for better performance.
12064 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12066 * report.cs: Renamed Error_T to Error and changed all
12069 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12071 * class.cs (TypeContainer.IndexerArrayList): New inner class
12072 container for indexers.
12073 (TypeContainer.DefaultIndexerName): New constant for default
12074 indexer name. Replaced all "Item" with this constant.
12075 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
12077 * typemanager.cs (TypeManager.default_member_ctor): Cache here
12078 DefaultMemberAttribute constructor.
12080 2004-08-05 Martin Baulig <martin@ximian.com>
12082 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12085 2004-08-05 Marek Safar <marek.safar@seznam.cz>
12087 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
12088 multi platforms problem.
12090 * compiler.csproj: Included shared files.
12092 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12094 Fix bug 60333, 55971 in the more general way
12095 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12096 Added arg_type argument for constant conversion.
12097 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
12099 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12102 * class.cs (TypeContainer ): New inner classes MethodArrayList,
12103 OperatorArrayList, MethodCoreArrayList for typecontainer
12104 containers. Changed class member types to these new types.
12105 (MethodArrayList.DefineMembers): Added test for CS0659.
12107 2004-08-04 Miguel de Icaza <miguel@ximian.com>
12109 * cfold.cs: Synchronize the folding with the code in expression.cs
12110 Binary.DoNumericPromotions for uint operands.
12112 * attribute.cs: Revert patch from Raja, it introduced a regression
12113 while building Blam-1.2.1 (hard to isolate a test case).
12115 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12119 (TypeContainer.Define): Renamed to DefineContainerMembers because of
12121 (MethodCore.parent_method): New member. The method we're overriding
12122 if this is an override method.
12123 (MethodCore.CheckBase): Moved from Method class and made common.
12124 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
12126 (MethodCore.CheckForDuplications): New abstract method. For custom
12127 member duplication search in a container
12128 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
12129 method and its return type.
12130 (Event.conflict_symbol): New member. Symbol with same name in the
12134 (MemberCache.FindMemberWithSameName): New method. The method
12135 is looking for conflict with inherited symbols.
12137 2004-08-04 Martin Baulig <martin@ximian.com>
12139 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
12141 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
12143 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12145 * report.cs (Message): New enum for better error, warning reference in
12147 (MessageData): New inner abstract class. It generally handles printing of
12148 error and warning messages.
12149 Removed unused Error, Warning, Message methods.
12151 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12153 Fix for cs0592-8.cs test
12155 (Attributable.ValidAttributeTargets): Made public.
12156 (Attribute.ExplicitTarget): New member for explicit target value.
12157 (Attribute.CheckTargets): Now we translate explicit attribute
12158 target to Target here.
12160 2004-08-03 Ben Maurer <bmaurer@ximian.com>
12162 * ecore.cs (MethodGroupExpr): new IsBase property.
12164 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12166 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12167 rather than an instance expr.
12169 (DelegateCreation.Emit): Use the method group rather than
12170 the instance expression. Also, if you have base.Foo as the
12171 method for a delegate, make sure to emit ldftn, not ldftnvirt.
12173 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
12175 (NewDelegate.DoResolve): Only check for the existance of Invoke
12176 if the method is going to be needed. Use MethodGroupExpr.
12178 (NewDelegate.Emit): Remove, DelegateCreation implements this.
12180 * expression.cs: For pointer arith., make sure to use
12181 the size of the type, not the size of the pointer to
12184 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12187 * class.cs (Class): Added error CS0502 test.
12189 2004-08-03 John Luke <jluke@cfl.rr.com>
12190 Raja R Harinath <rharinath@novell.com>
12193 * attribute.cs (Attribute.complained_before): New flag.
12194 (Attribute.ResolveType, Attribute.Resolve),
12195 (Attribute.DefinePInvokeMethod): Set it.
12196 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
12198 2004-08-03 Martin Baulig <martin@ximian.com>
12200 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
12201 use a user-defined operator; we still need to do numeric
12202 promotions in case one argument is a builtin type and the other
12203 one has an implicit conversion to that type. Fixes #62322.
12205 2004-08-02 Martin Baulig <martin@ximian.com>
12207 * statement.cs (LocalInfo.Flags): Added `IsThis'.
12208 (LocalInfo.IsThis): New public property.
12209 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
12211 2004-08-01 Martin Baulig <martin@ximian.com>
12213 * class.cs (TypeContainer.GetClassBases): Don't set the default
12214 here since we may get called from GetPartialBases().
12215 (TypeContainer.DefineType): If GetClassBases() didn't return a
12216 parent, use the default one.
12218 2004-07-30 Duncan Mak <duncan@ximian.com>
12220 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
12222 2004-07-30 Martin Baulig <martin@ximian.com>
12224 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
12226 * class.cs (SourceMethod): New public class, derive from the
12227 symbol writer's ISourceMethod.
12228 (Method): Use the new symbol writer API.
12230 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
12231 as argument and use the new symbol writer.
12234 (SourceFile): Implement the symbol writer's ISourceFile.
12235 (Location.SymbolDocument): Removed.
12236 (Location.SourceFile): New public property.
12238 * symbolwriter.cs: Use the new symbol writer API.
12240 2004-07-30 Raja R Harinath <rharinath@novell.com>
12242 * Makefile (install-local): Remove. Functionality moved to
12245 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
12247 * Makefile: Install mcs.exe.config file together with mcs.exe.
12248 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
12249 correct runtime version.
12251 2004-07-25 Martin Baulig <martin@ximian.com>
12254 (TypeContainer.RegisterOrder): Removed, this was unused.
12255 (TypeContainer, interface_order): Removed.
12256 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
12257 TypeContainer as argument since we can also be called with a
12258 `PartialContainer' for a partial class/struct/interface.
12259 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
12260 of checking whether we're an `Interface' - we could be a
12261 `PartialContainer'.
12262 (PartialContainer.Register): Override; call
12263 AddClass()/AddStruct()/AddInterface() on our parent.
12265 * cs-parser.jay (interface_member_declaration): Add things to the
12266 `current_container', not the `current_class'.
12268 * rootcontext.cs (RegisterOrder): The overloaded version which
12269 takes an `Interface' was unused, removed.
12271 * typemanager.cs (TypeManager.LookupInterface): Return a
12272 `TypeContainer', not an `Interface'.
12273 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
12274 contain a `PartialContainer' for an interface, so check it's
12275 `Kind' to figure out what it is.
12277 2004-07-25 Martin Baulig <martin@ximian.com>
12279 * class.cs (Class.DefaultTypeAttributes): New public constant.
12280 (Struct.DefaultTypeAttributes): Likewise.
12281 (Interface.DefaultTypeAttributes): Likewise.
12282 (PartialContainer.TypeAttr): Override this and add the
12283 DefaultTypeAttributes.
12285 2004-07-25 Martin Baulig <martin@ximian.com>
12287 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
12288 we can just use the `Parent' field instead.
12290 2004-07-25 Martin Baulig <martin@ximian.com>
12292 * class.cs (TypeContainer.Emit): Renamed to EmitType().
12294 2004-07-25 Martin Baulig <martin@ximian.com>
12296 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
12297 our parts before defining any methods.
12298 (TypeContainer.VerifyImplements): Make this virtual.
12299 (ClassPart.VerifyImplements): Override and call VerifyImplements()
12300 on our PartialContainer.
12302 2004-07-25 Martin Baulig <martin@ximian.com>
12304 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
12306 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
12307 argument, we can just use the `Parent' field instead.
12310 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
12311 (MemberBase.DoDefine): Likewise.
12313 2004-07-24 Martin Baulig <martin@ximian.com>
12315 * decl.cs (MemberCore.Parent): New public field.
12316 (DeclSpace.Parent): Moved to MemberCore.
12318 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
12319 (MemberBase.ctor): Added TypeContainer argument, pass it to our
12321 (FieldBase, Field, Operator): Likewise.
12322 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
12323 (EventField, Event): Likewise.
12325 2004-07-23 Martin Baulig <martin@ximian.com>
12327 * class.cs (PartialContainer): New public class.
12328 (ClassPart): New public class.
12329 (TypeContainer): Added support for partial classes.
12330 (TypeContainer.GetClassBases): Splitted some of the functionality
12331 out into GetNormalBases() and GetPartialBases().
12333 * cs-tokenizer.cs (Token.PARTIAL): New token.
12334 (Tokenizer.consume_identifier): Added some hacks to recognize
12335 `partial', but only if it's immediately followed by `class',
12336 `struct' or `interface'.
12338 * cs-parser.jay: Added support for partial clases.
12340 2004-07-23 Martin Baulig <martin@ximian.com>
12342 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
12343 a `DeclSpace' and also made it readonly.
12344 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
12345 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
12346 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
12348 * cs-parser.jay: Pass the `current_class', not the
12349 `current_container' (at the moment, this is still the same thing)
12350 to a new Method, Property, Event, Indexer or Constructor.
12352 2004-07-23 Martin Baulig <martin@ximian.com>
12354 * cs-parser.jay (CSharpParser): Added a new `current_class' field
12355 and removed the `current_interface' one.
12356 (struct_declaration, class_declaration, interface_declaration):
12357 Set `current_class' to the newly created class/struct/interface;
12358 set their `Bases' and call Register() before parsing their body.
12360 2004-07-23 Martin Baulig <martin@ximian.com>
12362 * class.cs (Kind): New public enum.
12363 (TypeContainer): Made this class abstract.
12364 (TypeContainer.Kind): New public readonly field.
12365 (TypeContainer.CheckDef): New public method; moved here from
12367 (TypeContainer.Register): New public abstract method.
12368 (TypeContainer.GetPendingImplementations): New public abstract
12370 (TypeContainer.GetClassBases): Removed the `is_class' and
12371 `is_iface' parameters.
12372 (TypeContainer.DefineNestedTypes): Formerly known as
12374 (ClassOrStruct): Made this class abstract.
12376 * tree.cs (RootTypes): New public type.
12378 2004-07-20 Martin Baulig <martin@ximian.com>
12380 * tree.cs (Tree.RecordNamespace): Removed.
12381 (Tree.Namespaces): Removed.
12383 * rootcontext.cs (RootContext.IsNamespace): Removed.
12385 * cs-parser.jay (namespace_declaration): Just create a new
12386 NamespaceEntry here.
12388 2004-07-20 Martin Baulig <martin@ximian.com>
12390 * statement.cs (ExceptionStatement): New abstract class. This is
12391 now used as a base class for everyone who's using `finally'.
12392 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
12393 our local variables before using them.
12395 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
12396 virtual method. This is used by Yield.Resolve() to "steal" an
12397 outer block's `finally' clauses.
12398 (FlowBranchingException): The .ctor now takes an ExceptionStatement
12401 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
12402 version which takes an ExceptionStatement. This version must be
12403 used to create exception branchings.
12406 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
12407 (Iterator.EmitMoveNext): Added exception support; protect the
12408 block with a `fault' clause, properly handle 'finally' clauses.
12409 (Iterator.EmitDispose): Run all the `finally' clauses here.
12411 2004-07-20 Martin Baulig <martin@ximian.com>
12413 * iterator.cs: This is the first of a set of changes in the
12414 iterator code. Match the spec more closely: if we're an
12415 IEnumerable, then GetEnumerator() must be called. The first time
12416 GetEnumerator() is called, it returns the current instance; all
12417 subsequent invocations (if any) must create a copy.
12419 2004-07-19 Miguel de Icaza <miguel@ximian.com>
12421 * expression.cs: Resolve the constant expression before returning
12424 2004-07-19 Martin Baulig <martin@ximian.com>
12426 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
12427 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
12428 the return type of the new EmitContext.
12430 2004-07-18 Martin Baulig <martin@ximian.com>
12432 * class.cs (Property.Define): Fix iterators.
12434 * iterators.cs (Iterator.Define): Moved the
12435 `container.AddInterator (this)' call here from the .ctor; only do
12436 it if we resolved successfully.
12438 2004-07-17 Miguel de Icaza <miguel@ximian.com>
12440 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
12441 `true' for preprocessing directives that we parse. The return
12442 value indicates whether we should return to regular tokenizing or
12443 not, not whether it was parsed successfully.
12445 In the past if we were in: #if false ... #line #endif, we would
12446 resume parsing after `#line'. See bug 61604.
12448 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
12449 building: IsEnumType should return true only for enums, not for
12450 enums or System.Enum itself. This fixes #61593.
12452 Likely what happened is that corlib was wrong: mcs depended on
12453 this bug in some places. The bug got fixed, we had to add the
12454 hack, which caused bug 61593.
12456 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
12457 that was a workaround for the older conditions.
12459 2004-07-16 Ben Maurer <bmaurer@ximian.com>
12461 * assign.cs: IAssignMethod has a new interface, as documented
12462 inline. All assignment code now uses this new api.
12464 * ecore.cs, expression.cs: All classes which implement
12465 IAssignMethod now use the new interface.
12467 * expression.cs (Invocation): add a hack to EmitCall so that
12468 IndexerAccess can be the target of a compound assignment without
12469 evaluating its arguments twice.
12471 * statement.cs: Handle changes in Invocation api.
12473 2004-07-16 Martin Baulig <martin@ximian.com>
12475 * iterators.cs: Rewrote this. We're now using one single Proxy
12476 class for both the IEnumerable and the IEnumerator interface and
12477 `Iterator' derives from Class so we can use the high-level API.
12479 * class.cs (TypeContainer.AddIterator): New method.
12480 (TypeContainer.DoDefineType): New protected virtual method, which
12481 is called from DefineType().
12482 (TypeContainer.DoDefineMembers): Call DefineType() and
12483 DefineMembers() on all our iterators.
12484 (TypeContainer.Emit): Call Emit() on all our iterators.
12485 (TypeContainer.CloseType): Call CloseType() on all our iterators.
12487 * codegen.cs (EmitContext.CurrentIterator): New public field.
12489 2004-07-15 Martin Baulig <martin@ximian.com>
12492 (TypeManager.not_supported_exception_type): New type.
12494 2004-07-14 Martin Baulig <martin@ximian.com>
12496 * iterators.cs: Use real error numbers.
12498 2004-07-14 Martin Baulig <martin@ximian.com>
12500 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
12501 requires this to be a System.Collection.IEnumerable and not a
12502 class implementing that interface.
12503 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
12505 2004-07-13 Marek Safar <marek.safar@seznam.cz>
12507 * class.cs: Fixed previous fix, it broke some error tests.
12509 2004-07-12 Martin Baulig <martin@ximian.com>
12511 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
12514 2004-07-09 Miguel de Icaza <miguel@ximian.com>
12516 * assign.cs (LocalTemporary): Add new argument: is_address,If
12517 `is_address' is true, then the value that we store is the address
12518 to the real value, and not the value itself.
12520 * ecore.cs (PropertyExpr): use the new local temporary
12521 stuff to allow us to handle X.Y += z (where X is a struct)
12523 2004-07-08 Martin Baulig <martin@ximian.com>
12525 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
12526 not always return, just like we're doing in Using.Resolve().
12528 2004-07-07 Miguel de Icaza <miguel@ximian.com>
12530 * cs-parser.jay (fixed_statement): flag this as Pinned.
12532 2004-07-06 Miguel de Icaza <miguel@ximian.com>
12534 * typemanager.cs (TypeManager): Removed MakePinned method, this
12535 mechanism is replaced with the .NET 2.x compatible mechanism of
12536 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
12538 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
12539 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
12540 `IsFixed' property which has a different meaning.
12542 2004-07-02 Raja R Harinath <rharinath@novell.com>
12544 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
12545 visible from inside a nested class, not just the names of the
12546 immediately enclosing class.
12547 Fix for bug #60730.
12549 2004-06-24 Raja R Harinath <rharinath@novell.com>
12551 * expression.cs (BetterConversion): Remove buggy special-case
12552 handling of "implicit constant expression conversions". At this
12553 point, we already know that the conversion is possible -- we're
12554 only checking to see which is better.
12556 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12558 * cs-parser.jay: Added error CS0210 test.
12560 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12562 * cs-parser.jay: Added error CS0134 test.
12564 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12567 * cs-parser.jay: Added error CS0145 test.
12569 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12571 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
12573 2004-06-23 Ben Maurer <bmaurer@ximian.com>
12575 * expression.cs (StackAlloc.Resolve): The argument may not
12576 be a constant; deal with this case.
12578 2004-06-23 Marek Safar <marek.safar@seznam.cz>
12580 * attribute.cs (IndexerName_GetIndexerName): Renamed to
12581 GetIndexerAttributeValue.
12582 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
12584 * class.cs (Indexer.Define): Added error tests for CS0415,
12587 2004-06-23 Miguel de Icaza <miguel@ximian.com>
12589 * attribute.cs (Attribute.Resolve): Keep field code in sync with
12592 2004-06-23 Martin Baulig <martin@ximian.com>
12594 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
12595 neither return nor throw, reset the barrier as well. Fixes #60457.
12597 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
12599 * class.cs : EventAttributes is now set to None by default.
12600 This fixes bug #60459.
12602 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12605 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12606 Don't throw exception but return null (it's sufficient now).
12608 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12610 * typemanager.cs (GetArgumentTypes): Faster implementation.
12612 2004-06-18 Martin Baulig <martin@ximian.com>
12614 * attribute.cs (Attribute.Resolve): Check whether we're an
12615 EmptyCast which a Constant child. Fixes #60333.
12617 2004-06-17 Ben Maurer <bmaurer@ximian.com>
12619 * statement.cs (EmitCollectionForeach): Account for the fact that
12620 not all valuetypes are in areas which we can take the address of.
12621 For these variables, we store to a temporary variable. Also, make
12622 sure that we dont emit a `callvirt' on a valuetype method.
12624 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12626 * expression.cs (StackAlloc.DoReSolve): Added test for
12627 negative parameter (CS0247).
12629 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12632 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
12634 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12637 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
12640 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12642 Fix bug #58254 & cs1555.cs, cs1556.cs
12643 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
12645 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12647 * cs-parser.jay: Added error CS1669 test for indexers.
12649 2004-06-11 Martin Baulig <martin@ximian.com>
12651 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
12652 call this twice: for params and varargs methods.
12654 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12657 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
12659 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12661 * attribute.cs (Attribute.GetValidTargets): Made public.
12664 (AbstractPropertyEventMethod): New class for better code sharing.
12665 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
12667 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
12669 2004-06-11 Raja R Harinath <rharinath@novell.com>
12672 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
12673 that the call to Resolve is part of a MemberAccess.
12674 (Expression.Resolve): Use it for SimpleName resolution.
12675 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
12676 Add 'intermediate' boolean argument.
12677 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
12678 error message when the SimpleName can be resolved ambiguously
12679 between an expression and a type.
12680 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
12682 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
12683 call on the left-side.
12685 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12688 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
12690 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12692 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
12694 2004-06-11 Martin Baulig <martin@ximian.com>
12696 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
12697 varargs methods if applicable.
12699 2004-06-11 Martin Baulig <martin@ximian.com>
12701 * expression.cs (Invocation.EmitCall): Don't use
12702 `method.CallingConvention == CallingConventions.VarArgs' since the
12703 method could also have `CallingConventions.HasThis'.
12705 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12707 * class.cs (Event.GetSignatureForError): Implemented.
12708 Fixed crash in error test cs3010.cs
12710 2004-06-10 Miguel de Icaza <miguel@ximian.com>
12712 * cs-tokenizer.cs: Change the way we track __arglist to be
12713 consistent with the other keywords.
12715 2004-06-09 Miguel de Icaza <miguel@ximian.com>
12717 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
12720 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
12722 * codegen.cs: Check that all referenced assemblies have a strongname
12723 before strongnaming the compiled assembly. If not report error CS1577.
12724 Fix bug #56563. Patch by Jackson Harper.
12725 * typemanager.cs: Added a method to return all referenced assemblies.
12726 Fix bug #56563. Patch by Jackson Harper.
12728 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12731 (Method.ApplyAttributeBuilder): Moved and added conditional
12732 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
12735 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
12737 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12740 * class.cs: (EventField.attribute_targets): Changed default target.
12742 2004-06-08 Martin Baulig <martin@ximian.com>
12744 * expression.cs (Invocation.EmitCall): Enable varargs methods.
12746 2004-06-08 Martin Baulig <martin@ximian.com>
12748 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
12750 2004-06-07 Martin Baulig <martin@ximian.com>
12752 Added support for varargs methods.
12754 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
12757 * cs-parser.jay: Added support for `__arglist'.
12759 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
12761 * expression.cs (Argument.AType): Added `ArgList'.
12762 (Invocation): Added support for varargs methods.
12763 (ArglistAccess): New public class.
12764 (Arglist): New public class.
12766 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
12768 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
12769 a method's top-level block if the method has varargs.
12771 * support.cs (ReflectionParameters, InternalParameters): Added
12772 support for varargs methods.
12774 2004-06-07 Miguel de Icaza <miguel@ximian.com>
12776 * class.cs: Provide location in indexer error report.
12778 * driver.cs: Use standard names.
12780 * namespace.cs: Catch the use of using after a namespace has been
12781 declared also on using aliases.
12783 2004-06-03 Raja R Harinath <rharinath@novell.com>
12786 * typemanager.cs (closure_private_ok, closure_invocation_type)
12787 (closure_qualifier_type, closure_invocation_assembly)
12788 (FilterWithClosure): Move to ...
12789 (Closure): New internal nested class.
12790 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
12791 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
12792 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
12793 (MemberLookup, MemberLookupFailed): Use it.
12794 * expression.cs (New.DoResolve): Treat the lookup for the
12795 constructor as being qualified by the 'new'ed type.
12796 (Indexers.GetIndexersForTypeOrInterface): Update.
12798 2004-06-03 Marek Safar <marek.safar@seznam.cz>
12801 (GetConditionalAttributeValue): New method. Returns
12802 condition of ConditionalAttribute.
12803 (SearchMulti): New method. Returns all attributes of type 't'.
12804 Use it when attribute is AllowMultiple = true.
12805 (IsConditionalMethodExcluded): New method.
12808 (Method.IsExcluded): Implemented. Returns true if method has conditional
12809 attribute and the conditions is not defined (method is excluded).
12810 (IMethodData): Extended interface for ConditionalAttribute support.
12811 (PropertyMethod.IsExcluded): Implemented.
12814 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
12817 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
12820 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
12822 * expression.cs (ArrayCreationExpression): Make this just an
12823 `expression'. It can't be a statement, so the code here was
12826 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12829 * typemanager.cs (GetFullNameSignature): New method for
12832 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12835 * class.cs (MemberBase.GetSignatureForError): New virtual method.
12836 Use this method when MethodBuilder is null.
12837 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
12838 Added test for error CS0626 (MONO reports error for this situation).
12839 (IMethodData.GetSignatureForError): Extended interface.
12841 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12844 (AttributeTester.GetObsoleteAttribute): Returns instance of
12845 ObsoleteAttribute when type is obsolete.
12848 (TypeContainer.VerifyObsoleteAttribute): Override.
12849 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
12850 (MethodCode.VerifyObsoleteAttribute): Override.
12851 (MemberBase.VerifyObsoleteAttribute): Override.
12854 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
12855 and report proper error.
12858 Delegate.VerifyObsoleteAttribute): Override.
12861 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
12862 and report proper error.
12863 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
12866 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
12870 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
12871 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
12872 Added test for ObsoleteAttribute.
12875 (Catch): Derived from Statement.
12877 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12879 Fixed bug #59071 & cs0160.cs
12881 * statement.cs (Try.Resolve): Check here whether order of catch
12882 clauses matches their dependencies.
12884 2004-05-31 Miguel de Icaza <miguel@ximian.com>
12886 * Reverted patch to namespace.cs (Use lookuptypedirect). This
12887 caused a regression: #59343. Referencing nested classes from an
12888 assembly stopped working.
12890 2004-05-31 Martin Baulig <martin@ximian.com>
12892 MCS is now frozen for beta 2.
12894 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12896 * convert.cs: add a trivial cache for overload operator resolution.
12898 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12900 * decl.cs: If possible, use lookuptypedirect here. We can only do
12901 this if there is no `.' after the namespace. Avoids using
12902 LookupType, which does lots of slow processing.
12903 (FindNestedType) New method, does what it says :-).
12904 * namespace.cs: use LookupTypeDirect.
12905 * rootcontext.cs: use membercache, if possible.
12906 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
12908 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12911 According to the spec,
12913 In a member access of the form E.I, if E is a single identifier,
12914 and if the meaning of E as a simple-name (§7.5.2) is a constant,
12915 field, property, localvariable, or parameter with the same type as
12916 the meaning of E as a type-name (§3.8), then both possible
12917 meanings of E are permitted.
12919 We did not check that E as a simple-name had the same type as E as
12922 This trivial check gives us 5-7% on bootstrap time.
12924 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12926 * expression.cs (Invocation.OverloadResolve): Avoid the
12927 use of hashtables and boxing here by allocating on demand.
12929 2004-05-30 Martin Baulig <martin@ximian.com>
12931 * rootcontext.cs (RootContext.LookupType): Don't cache things if
12932 we're doing a silent lookup. Don't try to lookup nested types in
12933 TypeManager.object_type (thanks to Ben Maurer).
12935 2004-05-30 Martin Baulig <martin@ximian.com>
12937 Committing a patch from Ben Maurer.
12939 * rootcontext.cs (RootContext.LookupType): Cache negative results.
12941 2004-05-29 Martin Baulig <martin@ximian.com>
12943 * class.cs (IMethodData.ShouldIgnore): New method.
12945 * typemanager.cs (TypeManager.MethodFlags): Don't take a
12946 `Location' argument, we don't need it anywhere. Use
12947 `IMethodData.ShouldIgnore ()' instead of
12948 `MethodData.GetMethodFlags ()'.
12949 (TypeManager.AddMethod): Removed.
12950 (TypeManager.AddMethod2): Renamed to AddMethod.
12952 2004-05-29 Martin Baulig <martin@ximian.com>
12954 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
12956 * convert.cs (Convert.ImplicitReferenceConversion): If we're
12957 converting from a class type S to an interface type and we already
12958 have an object on the stack, don't box it again. Fixes #52578.
12960 2004-05-29 Martin Baulig <martin@ximian.com>
12962 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12963 Added support for `params' parameters. Fixes #59267.
12965 2004-05-29 Martin Baulig <martin@ximian.com>
12967 * literal.cs (NullPointer): Provide a private .ctor which sets
12968 `type' to TypeManager.object_type. Fixes #59048.
12970 2004-05-29 Martin Baulig <martin@ximian.com>
12972 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
12973 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
12975 * ecore.cs (EventExpr.instance_expr): Make the field private.
12977 2004-05-26 Marek Safar <marek.safar@seznam.cz>
12979 Fixed bug #50080 & cs0214-2.cs
12980 * expression.cs (Cast.DoResolve): Check unsafe context here.
12982 * statement.cs (Resolve.DoResolve): Likewise.
12984 2004-05-26 Martin Baulig <martin@ximian.com>
12986 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
12988 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
12989 (RootContext.LookupType): Pass down the `silent' flag.
12991 2004-05-25 Martin Baulig <martin@ximian.com>
12994 (MethodGroupExpr.IdenticalTypeName): New public property.
12995 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
12996 expression actually refers to a type.
12998 2004-05-25 Martin Baulig <martin@ximian.com>
13000 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
13001 for #56176 and made it actually work.
13003 2004-05-25 Martin Baulig <martin@ximian.com>
13005 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
13006 (FieldExpr, PropertyExpr): Override and implement
13007 CacheTemporaries. Fixes #52279.
13009 2004-05-25 Miguel de Icaza <miguel@ximian.com>
13011 * location.cs: In the new compiler listing a file twice is a
13012 warning, not an error.
13014 2004-05-24 Martin Baulig <martin@ximian.com>
13016 * enum.cs (Enum.DefineType): For the `BaseType' to be a
13017 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
13019 2004-05-24 Martin Baulig <martin@ximian.com>
13021 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
13022 walking the `using' list. Fixes #53921.
13024 2004-05-24 Martin Baulig <martin@ximian.com>
13026 * const.cs (Const.LookupConstantValue): Added support for
13027 EmptyCast's; fixes #55251.
13029 2004-05-24 Martin Baulig <martin@ximian.com>
13031 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
13032 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
13033 which does the CS0135 check. The reason is that we first need to
13034 check whether the variable actually exists.
13036 2004-05-24 Martin Baulig <martin@ximian.com>
13038 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
13039 than RootContext.LookupType() to find the explicit interface
13040 type. Fixes #58584.
13042 2004-05-24 Raja R Harinath <rharinath@novell.com>
13044 * Makefile: Simplify. Use executable.make.
13045 * mcs.exe.sources: New file. List of sources of mcs.exe.
13047 2004-05-24 Anders Carlsson <andersca@gnome.org>
13051 Use the invariant culture when doing String.Compare for CLS case
13054 2004-05-23 Martin Baulig <martin@ximian.com>
13056 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
13057 don't have any dots. Fixes #52622, added cs0246-8.cs.
13059 * namespace.cs (NamespaceEntry.Lookup): Likewise.
13061 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13063 * class.cs (MemberBase.Define): Reuse MemberType member for
13064 resolved type. Other methods can use it too.
13066 2004-05-23 Martin Baulig <martin@ximian.com>
13068 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
13069 the variable also exists in the current block (otherwise, we need
13070 to report a CS0103). Fixes #58670.
13072 2004-05-23 Martin Baulig <martin@ximian.com>
13074 * flowanalysis.cs (Reachability.Reachable): Compute this
13075 on-the-fly rather than storing it as a field.
13077 2004-05-23 Martin Baulig <martin@ximian.com>
13079 * flowanalysis.cs (Reachability.And): Manually compute the
13080 resulting `barrier' from the reachability.
13082 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13085 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
13086 instance of ObsoleteAttribute when symbol is obsolete.
13089 (IMethodData): Extended interface for ObsoleteAttribute support.
13091 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13093 * attribute.cs: Fix bug #55970
13095 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13099 (GetObsoleteAttribute): New method. Creates the instance of
13101 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
13102 ObsoleteAttribute when member is obsolete.
13103 (AttributeTester.Report_ObsoleteMessage): Common method for
13104 Obsolete error/warning reporting.
13107 (TypeContainer.base_classs_type): New member for storing parent type.
13110 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
13111 for this MemberCore.
13113 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13115 * attribute.cs, const.cs: Fix bug #58590
13117 2004-05-21 Martin Baulig <martin@ximian.com>
13119 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
13120 out parameters if the end of the method is unreachable. Fixes
13123 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13125 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
13126 Hari was right, why extra method.
13128 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13130 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
13132 2004-05-20 Martin Baulig <martin@ximian.com>
13134 Merged this back from gmcs to keep the differences to a minumum.
13136 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
13137 instead of a Declspace.
13138 (Attribute.ResolveType): Likewise.
13139 (Attributes.Search): Likewise.
13140 (Attributes.Contains): Likewise.
13141 (Attributes.GetClsCompliantAttribute): Likewise.
13143 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
13145 (MethodData.ApplyAttributes): Take an EmitContext instead of a
13148 2004-05-19 Marek Safar <marek.safar@seznam.cz>
13150 Fix bug #58688 (MCS does not report error when the same attribute
13153 * attribute.cs (Attribute.Emit): Distinction between null and default.
13155 2004-05-19 Raja R Harinath <rharinath@novell.com>
13157 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
13158 of a top-level attribute without an attribute target.
13159 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
13161 (Attribute.Conditional_GetConditionName),
13162 (Attribute.Obsolete_GetObsoleteMessage): Update.
13163 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
13164 part of ScanForIndexerName.
13165 (Attribute.CanIgnoreInvalidAttribute): New function.
13166 (Attribute.ScanForIndexerName): Move to ...
13167 (Attributes.ScanForIndexerName): ... here.
13168 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
13169 (Attributes.Search): New internal variant that can choose not to
13170 complain if types aren't resolved. The original signature now
13172 (Attributes.GetClsCompliantAttribute): Use internal variant, with
13173 complaints suppressed.
13174 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
13175 only if it not useful.
13176 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
13177 top-level for attributes that are shared between the assembly
13178 and a top-level class.
13179 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
13180 * class.cs: Update to reflect changes.
13181 (DefineIndexers): Fuse loops.
13182 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
13183 a couple more variants of attribute names.
13185 2004-05-18 Marek Safar <marek.safar@seznam.cz>
13187 Fix bug #52585 (Implemented explicit attribute declaration)
13190 (Attributable.ValidAttributeTargets): New abstract method. It gets
13191 list of valid attribute targets for explicit target declaration.
13192 (Attribute.Target): It holds target itself.
13193 (AttributeSection): Removed.
13194 (Attribute.CheckTargets): New method. It checks whether attribute
13195 target is valid for the current element.
13198 (EventProperty): New class. For events that are declared like
13199 property (with add and remove accessors).
13200 (EventField): New class. For events that are declared like field.
13203 * cs-parser.jay: Implemented explicit attribute target declaration.
13205 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
13206 Override ValidAttributeTargets.
13209 (ReturnParameter): Class for applying custom attributes on
13211 (ParameterAtribute): New class. Class for applying custom
13212 attributes on the parameter type.
13214 2004-05-17 Miguel de Icaza <miguel@ximian.com>
13216 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
13219 (Method): Allow UNSAFE here.
13221 * modifiers.cs: Support unsafe reporting.
13223 2004-05-17 Marek Safar <marek.safar@seznam.cz>
13225 * decl.cs: Fix bug #58478.
13227 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13229 * statement.cs: When checking for unreachable code on an EmptyStatement,
13230 set the location. Fixes bug #58488.
13232 2004-05-13 Miguel de Icaza <miguel@ximian.com>
13234 * driver.cs: Add -pkg handling.
13236 From Gonzalo: UseShelLExecute=false
13238 2004-05-12 Marek Safar <marek.safar@seznam.cz>
13241 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
13243 (Attribute.IsClsCompliaceRequired): Moved to base for better
13245 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
13246 when attribute is AttributeUsageAttribute.
13247 (Attribute.GetValidTargets): Simplified.
13248 (Attribute.GetAttributeUsage): New method returns AttributeUsage
13249 attribute for this type.
13250 (Attribute.ApplyAttributes): Method renamed to Emit and make
13252 (GlobalAttributeSection): New class for special handling of global
13253 attributes (assembly, module).
13254 (AttributeSection.Emit): New method.
13256 * class.cs: Implemented Attributable abstract methods.
13257 (MethodCore.LabelParameters): Moved to Parameter class.
13258 (Accessor): Is back simple class.
13259 (PropertyMethod): Implemented Attributable abstract class.
13260 (DelegateMethod): Implemented Attributable abstract class.
13261 (Event): New constructor for disctintion between normal Event
13262 and Event with accessors.
13264 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
13266 * codegen.cs, const.cs, decl.cs, delegate.cs:
13267 (CommonAssemblyModulClass): Implemented Attributable abstract class
13270 * enum.cs: Implement IAttributeSupport interface.
13271 (EnumMember): New class for emum members. Implemented Attributable
13275 (ParameterBase): Is abstract.
13276 (ReturnParameter): New class for easier [return:] attribute handling.
13278 * typemanager.cs: Removed builder_to_attr.
13280 2004-05-11 Raja R Harinath <rharinath@novell.com>
13283 * attribute.cs (Attribute.GetPositionalValue): New function.
13284 * class.cs (TypeContainer.VerifyMembers): New function.
13285 (TypeContainer.Emit): Use it.
13286 (ClassOrStruct): New base class for Class and Struct.
13287 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
13288 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
13290 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
13291 then each non-static field should have a FieldOffset attribute.
13292 Otherwise, none of the fields should have a FieldOffset attribute.
13293 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
13294 and FieldOffset attributes.
13295 * typemanager.cs (TypeManager.struct_layout_attribute_type)
13296 (TypeManager.field_offset_attribute_type): New core types.
13297 (TypeManager.InitCoreTypes): Initialize them.
13299 2004-05-11 Michal Moskal <malekith@pld-linux.org>
13301 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
13302 Return correct type.
13305 2004-05-09 Miguel de Icaza <miguel@ximian.com>
13307 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
13308 be implicitly converted to ulong.
13310 * expression.cs: The logic for allowing operator &, | and ^ worked
13311 was wrong, it worked before because we did not report an error in
13312 an else branch. Fixes 57895.
13314 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
13315 allow volatile fields to be reference types.
13317 2004-05-07 Miguel de Icaza <miguel@ximian.com>
13319 * driver.cs: Add support for /debug-
13321 2004-05-07 Raja R Harinath <rharinath@novell.com>
13323 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
13324 Add a 'complain' parameter to silence errors.
13325 (Attribute.Resolve): Update to changes. Put in sanity check to catch
13326 silently overlooked type-resolutions.
13327 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
13328 to reflect changes.
13329 (Attributes.Search): New function.
13330 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
13331 (Attributes.GetAttributeFullName): Remove hack.
13332 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
13333 Update to reflect changes.
13334 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
13335 Use Attributes.Search instead of nested loops.
13337 2004-05-07 Marek Safar <marek.safar@seznam.cz>
13340 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
13341 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
13342 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
13344 * report.cs: (Report.Warning): Renamed to Warning_T because of
13345 parameter collision.
13347 2004-05-05 Raja R Harinath <rharinath@novell.com>
13349 * expression.cs (MemberAccess.ResolveMemberAccess):
13350 Exit with non-zero status after Report.Error.
13351 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
13353 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
13355 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13357 * support.cs: Don't hang when the file is empty.
13359 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13361 * support.cs: In SeekableStreamReader, compute the preamble size of the
13362 underlying stream. Position changes should take into account that initial
13365 2004-05-03 Todd Berman <tberman@sevenl.net>
13367 * driver.cs: remove unused GetSysVersion function.
13369 2004-05-03 Todd Berman <tberman@sevenl.net>
13371 * driver.cs: Remove the hack from saturday, as well as the hack
13372 from jackson (LoadAssemblyFromGac), also adds the CWD to the
13373 link_paths to get that bit proper.
13375 2004-05-01 Todd Berman <tberman@sevenl.net>
13377 * driver.cs: Try a LoadFrom before a Load, this checks the current
13378 path. This is currently a bug in mono that is be fixed, however, this
13379 provides a workaround for now. This will be removed when the bug
13382 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
13384 * CryptoConvert.cs: Updated to latest version. Fix issue with
13385 incomplete key pairs (#57941).
13387 2004-05-01 Todd Berman <tberman@sevenl.net>
13389 * driver.cs: Remove '.' from path_chars, now System.* loads properly
13392 2004-04-30 Jackson Harper <jackson@ximian.com>
13394 * codegen.cs: Open keys readonly.
13396 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13398 * typemanager.cs: don't report cyclic struct layout when a struct
13399 contains 2 or more fields of the same type. Failed for Pango.AttrShape
13400 which has 2 Pango.Rectangle fields.
13402 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
13404 * expression.cs: Handle IntPtr comparisons with IL code
13405 rather than a method call.
13407 2004-04-29 Martin Baulig <martin@ximian.com>
13409 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
13410 the list of PropertyInfo's in class hierarchy and find the
13411 accessor. Fixes #56013.
13413 2004-04-29 Martin Baulig <martin@ximian.com>
13415 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
13417 2004-04-29 Martin Baulig <martin@ximian.com>
13419 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13421 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
13423 2004-04-29 Martin Baulig <martin@ximian.com>
13425 * class.cs (ConstructorInitializer.Resolve): Check whether the
13426 parent .ctor is accessible. Fixes #52146.
13428 2004-04-29 Martin Baulig <martin@ximian.com>
13430 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13432 * statement.cs (Using.EmitLocalVariableDecls): Use
13433 TypeManager.idisposable_type, not typeof (IDisposable).
13434 (Foreach.EmitCollectionForeach): Added support for valuetypes.
13436 2004-04-29 Martin Baulig <martin@ximian.com>
13438 * class.cs (Event.Define): Don't emit the field and don't set
13439 RTSpecialName and SpecialName for events on interfaces. Fixes
13442 2004-04-29 Raja R Harinath <rharinath@novell.com>
13444 Refactor Attribute.ApplyAttributes.
13445 * attribute.cs (Attributable): New base class for objects that can
13446 have Attributes applied on them.
13447 (Attribute): Make AttributeUsage fields public.
13448 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
13449 (Attribute.IsInternalCall): New property.
13450 (Attribute.UsageAttr): Convert to a public read-only property.
13451 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
13452 (Attribute.ResolveType, Attribute.Resolve)
13453 (Attribute.ScanForIndexerName): Update to reflect changes.
13454 (Attribute.CheckAttributeTarget): Re-format.
13455 (Attribute.ApplyAttributes): Refactor, to various
13456 Attributable.ApplyAttributeBuilder methods.
13457 * decl.cs (MemberCore): Make Attributable.
13458 * class.cs (Accessor): Make Attributable.
13459 (MethodData.ApplyAttributes): Use proper attribute types, not
13461 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
13462 (TypeContainer.ApplyAttributeBuilder)
13463 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
13464 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
13465 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
13466 (Operator.ApplyAttributeBuilder): New factored-out methods.
13467 * const.cs (Const.ApplyAttributeBuilder): Likewise.
13468 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
13469 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
13470 * parameter.cs (ParameterBase): New Attributable base class
13471 that can also represent Return types.
13472 (Parameter): Update to the changes.
13474 2004-04-29 Jackson Harper <jackson@ximian.com>
13476 * driver.cs: Prefer the corlib system version when looking for
13477 assemblies in the GAC. This is still a hack, but its a better hack
13480 2004-04-29 Marek Safar <marek.safar@seznam.cz>
13482 * decl.cs, enum.cs: Improved error 3005 reporting.
13484 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
13485 (related_symbols): New private member for list of symbols
13486 related to reported error/warning.
13488 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
13490 2004-04-29 Martin Baulig <martin@ximian.com>
13492 * ecore.cs (Expression.Constantify): If we're an enum and
13493 TypeManager.TypeToCoreType() doesn't give us another type, use
13494 t.UnderlyingSystemType. Fixes #56178.
13496 2004-04-29 Martin Baulig <martin@ximian.com>
13498 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
13499 interfaces and for each interface, only add members directly
13500 declared in that interface. Fixes #53255.
13502 2004-04-28 Martin Baulig <martin@ximian.com>
13504 * expression.cs (ConditionalLogicalOperator): Use a temporary
13505 variable for `left' to avoid that we evaluate it more than once;
13508 2004-04-28 Martin Baulig <martin@ximian.com>
13510 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
13513 2004-04-28 Martin Baulig <martin@ximian.com>
13515 * statement.cs (LocalInfo.Resolve): Check whether the type is not
13518 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
13519 whether the type is not void (CS1547).
13521 2004-04-28 Martin Baulig <martin@ximian.com>
13523 * expression.cs (Unary.DoResolveLValue): Override this and report
13524 CS0131 for anything but Operator.Indirection.
13526 2004-04-28 Martin Baulig <martin@ximian.com>
13528 Committing a patch from Ben Maurer; see bug #50820.
13530 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13533 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13536 2004-04-28 Martin Baulig <martin@ximian.com>
13538 Committing a patch from Ben Maurer; see bug #50820.
13540 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13543 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13546 2004-04-28 Martin Baulig <martin@ximian.com>
13548 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
13549 (Block.AddLabel): Call DoLookupLabel() to only search in the
13552 2004-04-28 Martin Baulig <martin@ximian.com>
13554 * cfold.cs (ConstantFold.BinaryFold): Added special support for
13555 comparing StringConstants and NullLiterals in Equality and Inequality.
13557 2004-04-28 Jackson Harper <jackson@ximian.com>
13559 * driver.cs: Attempt to load referenced assemblies from the
13560 GAC. This is the quick and dirty version of this method that
13561 doesnt take into account versions and just takes the first
13562 canidate found. Will be good enough for now as we will not have more
13563 then one version installed into the GAC until I update this method.
13565 2004-04-28 Martin Baulig <martin@ximian.com>
13567 * typemanager.cs (TypeManager.CheckStructCycles): New public
13568 static method to check for cycles in the struct layout.
13570 * rootcontext.cs (RootContext.PopulateTypes): Call
13571 TypeManager.CheckStructCycles() for each TypeContainer.
13572 [Note: We only need to visit each type once.]
13574 2004-04-28 Martin Baulig <martin@ximian.com>
13576 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
13578 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
13579 success and added `out object value'. Use a `bool resolved' field
13580 to check whether we've already been called rather than
13581 `ConstantValue != null' since this breaks for NullLiterals.
13583 2004-04-28 Raja R Harinath <rharinath@novell.com>
13585 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
13586 setting of this flag, since the 'set' method may be non-public.
13588 2004-04-28 Raja R Harinath <rharinath@novell.com>
13590 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
13591 check on current_vector.Block.
13593 2004-04-27 Martin Baulig <martin@ximian.com>
13595 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
13596 a field initializer. Fixes #56459.
13598 2004-04-27 Martin Baulig <martin@ximian.com>
13600 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
13601 we're not attempting to use an indexer. Fixes #52154.
13603 2004-04-27 Martin Baulig <martin@ximian.com>
13605 * statement.cs (Return): Don't create a return label if we don't
13606 need it; reverts my change from January 20th. Thanks to Ben
13609 2004-04-27 Martin Baulig <martin@ximian.com>
13611 According to the spec, `goto' can only leave a nested scope, but
13614 * statement.cs (Block.LookupLabel): Only lookup in the current
13615 block, don't recurse into parent or child blocks.
13616 (Block.AddLabel): Check in parent and child blocks, report
13617 CS0140/CS0158 if we find a duplicate.
13618 (Block): Removed this indexer for label lookups.
13619 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
13620 this already does the error reporting for us.
13623 (FlowBranching.UsageVector.Block): New public variable; may be null.
13624 (FlowBranching.CreateSibling): Added `Block' argument.
13625 (FlowBranching.LookupLabel): New public virtual method. Lookup a
13626 label for the target of a `goto' and check whether we're not
13627 leaving a `finally'.
13629 2004-04-27 Martin Baulig <martin@ximian.com>
13631 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13632 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
13635 2004-04-27 Martin Baulig <martin@ximian.com>
13637 * statement.cs (Block.AddLabel): Also check for implicit blocks
13638 and added a CS0158 check.
13640 2004-04-27 Martin Baulig <martin@ximian.com>
13642 * flowanalysis.cs (FlowBranchingLoop): New class.
13643 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
13644 UsageVector's instead of an ArrayList.
13645 (FlowBranching.Label): Likewise.
13646 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
13647 (FlowBranching.AddBreakVector): New method.
13649 2004-04-27 Miguel de Icaza <miguel@ximian.com>
13651 * attribute.cs: Small regression fix: only convert the type if we
13652 the type is different, fixes System.Drawing build.
13654 2004-04-27 Martin Baulig <martin@ximian.com>
13656 * attribute.cs (Attribute.Resolve): If we have a constant value
13657 for a named field or property, implicity convert it to the correct
13660 2004-04-27 Raja R Harinath <rharinath@novell.com>
13662 * statement.cs (Block.Block): Implicit blocks share
13663 'child_variable_names' fields with parent blocks.
13664 (Block.AddChildVariableNames): Remove.
13665 (Block.AddVariable): Mark variable as "used by a child block" in
13666 every surrounding block.
13667 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
13668 been used in a child block, complain about violation of "Invariant
13669 meaning in blocks" rule.
13670 * cs-parser.jay (declare_local_variables): Don't use
13671 AddChildVariableNames.
13672 (foreach_statement): Don't create an implicit block: 'foreach'
13673 introduces a scope.
13675 2004-04-23 Miguel de Icaza <miguel@ximian.com>
13677 * convert.cs (ImplicitNumericConversion): 0 is also positive when
13678 converting from 0L to ulong. Fixes 57522.
13680 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13682 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
13683 derived class hides via 'new' keyword field from base class (test-242.cs).
13684 TODO: Handle this in the more general way.
13686 * class.cs (CheckBase): Ditto.
13688 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13690 * decl.cs (caching_flags): New member for storing cached values
13692 (MemberCore.Flags): New enum where bit flags for caching_flags
13694 (MemberCore.cls_compliance): Moved to caching_flags.
13695 (DeclSpace.Created): Moved to caching_flags.
13697 * class.cs: Use caching_flags instead of DeclSpace.Created
13699 2004-04-21 Miguel de Icaza <miguel@ximian.com>
13701 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
13702 if we are only a derived class, not a nested class.
13704 * typemanager.cs: Same as above, but do this at the MemberLookup
13705 level (used by field and methods, properties are handled in
13706 PropertyExpr). Allow for the qualified access if we are a nested
13709 2004-04-21 Marek Safar <marek.safar@seznam.cz>
13711 * class.cs: Refactoring.
13712 (IMethodData): New inteface; Holds links to parent members
13713 to avoid member duplication (reduced memory allocation).
13714 (Method): Implemented IMethodData interface.
13715 (PropertyBase): New inner classes for get/set methods.
13716 (PropertyBase.PropertyMethod): Implemented IMethodData interface
13717 (Event): New inner classes for add/remove methods.
13718 (Event.DelegateMethod): Implemented IMethodData interface.
13720 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
13721 EmitContext (related to class.cs refactoring).
13723 2004-04-21 Raja R Harinath <rharinath@novell.com>
13725 * delegate.cs (Delegate.VerifyApplicability): If the number of
13726 arguments are the same as the number of parameters, first try to
13727 verify applicability ignoring any 'params' modifier on the last
13731 2004-04-16 Raja R Harinath <rharinath@novell.com>
13733 * class.cs (TypeContainer.AddIndexer): Use
13734 'ExplicitInterfaceName' to determine if interface name was
13735 explicitly specified. 'InterfaceType' is not initialized at this time.
13736 (TypeContainer.DefineIndexers): Remove use of temporary list. The
13737 Indexers array is already in the required order. Initialize
13738 'IndexerName' only if there are normal indexers.
13739 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
13740 (TypeContainer.Emit): Emit DefaultMember attribute only if
13741 IndexerName is initialized.
13744 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
13746 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
13749 2004-04-15 Raja R Harinath <rharinath@novell.com>
13751 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
13755 * attribute.cs (Attribute.Resolve): Check for duplicate named
13759 2004-04-15 Miguel de Icaza <miguel@ximian.com>
13761 * iterators.cs (MarkYield): track whether we are in an exception,
13762 and generate code accordingly. Use a temporary value to store the
13763 result for our state.
13765 I had ignored a bit the interaction of try/catch with iterators
13766 since their behavior was not entirely obvious, but now it is
13767 possible to verify that our behavior is the same as MS .NET 2.0
13771 2004-04-14 Miguel de Icaza <miguel@ximian.com>
13773 * iterators.cs: Avoid creating temporaries if there is no work to
13776 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
13777 Enumerations, use TypeManager.EnumToUnderlying and call
13780 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
13783 (This.Emit): Use EmitContext.EmitThis to emit our
13786 (This.EmitAssign): Ditto.
13788 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
13789 codepaths, we will move all the functionality into
13792 (FieldExpr.EmitAssign): Ditto.
13794 This fixes several hidden bugs that I uncovered while doing a code
13795 review of this today.
13797 * codegen.cs (EmitThis): reworked so the semantics are more clear
13798 and also support value types "this" instances.
13800 * iterators.cs: Changed so that for iterators in value types, we
13801 do not pass the value type as a parameter.
13803 Initialization of the enumerator helpers is now done in the caller
13804 instead of passing the parameters to the constructors and having
13805 the constructor set the fields.
13807 The fields have now `assembly' visibility instead of private.
13809 2004-04-11 Miguel de Icaza <miguel@ximian.com>
13811 * expression.cs (Argument.Resolve): Check if fields passed as ref
13812 or out are contained in a MarshalByRefObject.
13814 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
13815 another compiler type.
13817 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
13819 * class.cs (Indexer.Define): use the new name checking method.
13820 Also, return false on an error.
13821 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
13822 (is_identifier_[start/part]_character): make static.
13824 2004-04-10 Miguel de Icaza <miguel@ximian.com>
13826 * expression.cs (Binary.ResolveOperator): Do no append strings
13827 twice: since we can be invoked more than once (array evaluation)
13828 on the same concatenation, take care of this here. Based on a fix
13829 from Ben (bug #56454)
13831 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
13833 * codegen.cs: Fix another case where CS1548 must be reported (when
13834 delay-sign isn't specified and no private is available #56564). Fix
13835 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
13836 error when MCS is used on the MS runtime and we need to delay-sign
13837 (which seems unsupported by AssemblyBuilder - see #56621).
13839 2004-04-08 Marek Safar <marek.safar@seznam.cz>
13841 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
13842 (TypeManager.ComputeNamespaces): Faster implementation for
13845 * compiler.csproj: Updated AssemblyName to mcs.
13847 2004-04-07 Miguel de Icaza <miguel@ximian.com>
13849 * rootcontext.cs: Add new types to the boot resolution.
13851 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
13852 MulticastDelegate is not allowed.
13854 * typemanager.cs: Add new types to lookup: System.TypedReference
13857 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
13858 check for TypedReference or ArgIterator, they are not allowed.
13860 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
13861 makes us properly catch 1510 in some conditions (see bug 56016 for
13864 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
13866 * CryptoConvert.cs: update from corlib version
13869 2004-04-05 Miguel de Icaza <miguel@ximian.com>
13871 * class.cs (Indexer.Define): Check indexername declaration
13873 2004-04-05 Marek Safar <marek.safar@seznam.cz>
13875 * attribute.cs (IsClsCompliant): Fixed problem with handling
13876 all three states (compliant, not-compliant, undetected).
13878 2004-03-30 Marek Safar <marek.safar@seznam.cz>
13880 * attribute.cs (Attribute): Location is now public.
13881 (Resolve): Store resolved arguments (pos_values) in attribute class.
13882 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
13883 (GetClsCompliantAttributeValue): New method that gets
13884 CLSCompliantAttribute value.
13885 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
13886 if exists else null.
13887 (AttributeTester): New class for CLS-Compliant verification routines.
13889 * class.cs (Emit): Add CLS-Compliant verification.
13890 (Method.GetSignatureForError): Implemented.
13891 (Constructor.GetSignatureForError): Implemented
13892 (Constructor.HasCompliantArgs): Returns if constructor has
13893 CLS-Compliant arguments.
13894 (Constructor.Emit): Override.
13895 (Construcor.IsIdentifierClsCompliant): New method; For constructors
13896 is needed to test only parameters.
13897 (FieldBase.GetSignatureForError): Implemented.
13898 (TypeContainer): New member for storing base interfaces.
13899 (TypeContainer.FindMembers): Search in base interfaces too.
13901 * codegen.cs (GetClsComplianceAttribute): New method that gets
13902 assembly or module CLSCompliantAttribute value.
13903 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
13905 (ModuleClass.Emit): Add error 3012 test.
13907 * const.cs (Emit): Override and call base for CLS-Compliant tests.
13909 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
13910 state for all decl types.
13911 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
13912 if CLS-Compliant tests are required.
13913 (IsClsCompliaceRequired): New method. Analyze whether code
13914 must be CLS-Compliant.
13915 (IsExposedFromAssembly): New method. Returns true when MemberCore
13916 is exposed from assembly.
13917 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
13918 value or gets cached value.
13919 (HasClsCompliantAttribute): New method. Returns true if MemberCore
13920 is explicitly marked with CLSCompliantAttribute.
13921 (IsIdentifierClsCompliant): New abstract method. This method is
13922 used to testing error 3005.
13923 (IsIdentifierAndParamClsCompliant): New method. Common helper method
13924 for identifier and parameters CLS-Compliant testing.
13925 (VerifyClsCompliance): New method. The main virtual method for
13926 CLS-Compliant verifications.
13927 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
13928 null. I don't know why is null (too many public members !).
13929 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
13930 and get value of first CLSCompliantAttribute that found.
13932 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
13933 (VerifyClsCompliance): Override and add extra tests.
13935 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
13936 clscheck- disable CLS-Compliant verification event if assembly is has
13937 CLSCompliantAttribute(true).
13939 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
13940 ApllyAttribute is now called in emit section as in the other cases.
13941 Possible future Emit integration.
13942 (IsIdentifierClsCompliant): New override.
13943 (VerifyClsCompliance): New override.
13944 (GetEnumeratorName): Returns full enum name.
13946 * parameter.cs (GetSignatureForError): Implemented.
13948 * report.cs (WarningData): New struct for Warning message information.
13949 (LocationOfPreviousError): New method.
13950 (Warning): New method. Reports warning based on the warning table.
13951 (Error_T): New method. Reports error based on the error table.
13953 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
13954 verifications are done here.
13956 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
13958 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
13959 CLSCompliantAttribute.
13960 (all_imported_types): New member holds all imported types from other
13962 (LoadAllImportedTypes): New method fills static table with exported types
13963 from all referenced assemblies.
13964 (Modules): New property returns all assembly modules.
13966 2004-03-30 Miguel de Icaza <miguel@ximian.com>
13968 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
13969 throwing a parser error.
13971 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
13972 which removes the hardcoded get_/set_ prefixes for properties, as
13973 IL allows for the properties to be named something else.
13977 * expression.cs: Do not override operand before we know if it is
13978 non-null. Fix 56207
13980 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13982 * typemanager.cs: support for pinned variables.
13984 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13986 * decl.cs, typemanager.cs: Avoid using an arraylist
13987 as a buffer if there is only one result set.
13989 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13991 * expression.cs: Make sure you cant call a static method
13992 with an instance expression, bug #56174.
13994 2004-03-29 Miguel de Icaza <miguel@ximian.com>
13996 * class.cs (IsDuplicateImplementation): Improve error reporting to
13997 flag 663 (method only differs in parameter modifier).
13999 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
14000 in preprocessor directives.
14002 * location.cs (LookupFile): Allow for the empty path.
14004 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
14005 better approach for some of that patch, but its failing with the
14006 CharSet enumeration. For now try/catch will do.
14008 * typemanager.cs: Do not crash if a struct does not have fields.
14011 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14013 * expression.cs: cs0213, cant fix a fixed expression.
14016 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14018 * cs-parser.jay: detect invalid embeded statements gracefully.
14021 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14023 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
14026 the invocation type may not be a subclass of the tye of the item/
14027 The type of the item must be a subclass of the invocation item.
14032 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
14034 * attribute.cs: Added methods to get a string and a bool from an
14035 attribute. Required to information from AssemblyKeyFileAttribute,
14036 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
14037 * codegen.cs: Modified AssemblyName creation to include support for
14038 strongnames. Catch additional exceptions to report them as CS1548.
14039 * compiler.csproj: Updated include CryptoConvert.cs.
14040 * compiler.csproj.user: Removed file - user specific configuration.
14041 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
14042 Mono.Security assembly. The original class is maintained and tested in
14043 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
14044 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
14045 like CSC 8.0 (C# v2) supports.
14046 * Makefile: Added CryptoConvert.cs to mcs sources.
14047 * rootcontext.cs: Added new options for strongnames.
14049 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
14051 * driver.cs: For --expect-error, report error code `2'
14052 if the program compiled with no errors, error code `1' if
14053 it compiled with an error other than the one expected.
14055 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
14057 * compiler.csproj: Updated for Visual Studio .NET 2003.
14058 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
14059 * compiler.sln: Updated for Visual Studio .NET 2003.
14061 2004-03-24 Ravi Pratap M <ravi@ximian.com>
14063 * expression.cs: Fix bug #47234. We basically need to apply the
14064 rule that we prefer the conversion of null to a reference type
14065 when faced with a conversion to 'object' (csc behaviour).
14067 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14069 * statement.cs: Shorter form for foreach, eliminates
14070 a local variable. r=Martin.
14072 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14074 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
14075 checks if we can use brtrue/brfalse to test for 0.
14076 * expression.cs: use the above in the test for using brtrue/brfalse.
14077 cleanup code a bit.
14079 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14081 * expression.cs: Rewrite string concat stuff. Benefits:
14083 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
14084 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
14085 rather than a concat chain.
14087 * typemanager.cs: Add lookups for more concat overloads.
14089 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14091 * expression.cs: Emit shorter il code for array init.
14108 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
14110 * statement.cs: Before, two switch blocks would be merged if the
14111 total size of the blocks (end_item - begin_item + 1) was less than
14112 two times the combined sizes of the blocks.
14114 Now, it will only merge if after the merge at least half of the
14119 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
14121 * class.cs : csc build fix for GetMethods(). See bug #52503.
14123 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
14125 * expression.cs: Make sure fp comparisons work with NaN.
14126 This fixes bug #54303. Mig approved this patch a long
14127 time ago, but we were not able to test b/c the runtime
14130 2004-03-19 Miguel de Icaza <miguel@ximian.com>
14132 * ecore.cs (TypExpr.GetHashCode): implement this overload.
14134 2004-03-19 Martin Baulig <martin@ximian.com>
14136 * class.cs (MemberCore.IsDuplicateImplementation): Report the
14137 error here and not in our caller.
14139 2004-03-19 Martin Baulig <martin@ximian.com>
14141 * interface.cs: Completely killed this file.
14142 (Interface): We're now a TypeContainer and live in class.cs.
14144 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
14145 argument; we're now also called for interfaces.
14146 (TypeContainer.DefineMembers): Allow this method being called
14148 (TypeContainer.GetMethods): New public method; formerly known as
14149 Interface.GetMethod(). This is used by PendingImplementation.
14150 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
14151 it's now private and non-static.
14152 (Interface): Moved this here; it's now implemented similar to
14154 (Method, Property, Event, Indexer): Added `bool is_interface'
14155 argument to their .ctor's.
14156 (MemberBase.IsInterface): New public field.
14158 * cs-parser.jay: Create normal Method, Property, Event, Indexer
14159 instances instead of InterfaceMethod, InterfaceProperty, etc.
14160 (opt_interface_base): Removed; we now use `opt_class_base' instead.
14161 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
14163 2004-03-19 Martin Baulig <martin@ximian.com>
14165 * class.cs (MethodCore.IsDuplicateImplementation): New private
14166 method which does the CS0111 checking.
14167 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14168 Use IsDuplicateImplementation().
14170 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
14172 * decl.cs (FindMemberToOverride): New method to find the correct
14173 method or property to override in the base class.
14175 - Make Method/Property use the above method to find the
14176 version in the base class.
14177 - Remove the InheritableMemberSignatureCompare as it is now
14180 This patch makes large code bases much faster to compile, as it is
14181 O(n) rather than O(n^2) to do this validation.
14183 Also, it fixes bug 52458 which is that nested classes are not
14184 taken into account when finding the base class member.
14186 Reviewed/Approved by Martin.
14188 2004-03-17 Marek Safar <marek.safar@seznam.cz>
14190 * interface.cs: In all interface classes removed redundant
14191 member initialization.
14193 2004-03-16 Martin Baulig <martin@ximian.com>
14195 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
14197 2004-03-15 Miguel de Icaza <miguel@ximian.com>
14199 * decl.cs (DefineTypeAndParents): New helper method to define a
14200 type's containers before the type itself is defined; This is a
14201 bug exposed by the recent changes to Windows.Forms when an
14202 implemented interface was defined inside a class that had not been
14205 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
14207 (Check): Loop correctly to report errors modifiers
14208 (UNSAFE was not in the loop, since it was the same as TOP).
14210 * interface.cs: Every interface member now takes a ModFlags,
14211 instead of a "is_new" bool, which we set on the base MemberCore.
14213 Every place where we called "UnsafeOk" in the interface, now we
14214 call the proper member (InterfaceMethod.UnsafeOK) instead to get
14215 the unsafe settings from the member declaration instead of the
14216 container interface.
14218 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
14220 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
14221 `set_indexer_name' to the pending bits (one per type).
14223 We fixed a bug today that was picking the wrong method to
14224 override, since for properties the existing InterfaceMethod code
14225 basically ignored the method name. Now we make sure that the
14226 method name is one of the valid indexer names.
14228 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
14230 * support.cs (SeekableStreamReader): Keep track of stream byte
14231 positions and don't mix them with character offsets to the buffer.
14233 Patch from Gustavo Giráldez
14235 2004-03-15 Marek Safar <marek.safar@seznam.cz>
14237 * interface.cs (InterfaceSetGetBase): Removed double member
14238 initialization, base class does it as well.
14240 2004-03-13 Martin Baulig <martin@ximian.com>
14242 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
14243 when compiling corlib.
14245 2004-03-13 Miguel de Icaza <miguel@ximian.com>
14247 * convert.cs (ExplicitConversion): We were reporting an error on
14248 certain conversions (object_type source to a value type, when the
14249 expression was `null') before we had a chance to pass it through
14250 the user defined conversions.
14252 * driver.cs: Replace / and \ in resource specifications to dots.
14255 * class.cs: Add check for duplicate operators. Fixes 52477
14257 2004-03-11 Miguel de Icaza <miguel@ximian.com>
14259 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
14260 that are in the middle of the statements, not only at the end.
14263 * class.cs (TypeContainer.AddField): No longer set the
14264 `HaveStaticConstructor' flag, now we call it
14265 `UserDefineStaticConstructor' to diferentiate the slightly
14266 semantic difference.
14268 The situation is that we were not adding BeforeFieldInit (from
14269 Modifiers.TypeAttr) to classes that could have it.
14270 BeforeFieldInit should be set to classes that have no static
14275 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
14277 And most importantly Zoltan's comment:
14279 http://bugzilla.ximian.com/show_bug.cgi?id=44229
14281 "I think beforefieldinit means 'it's ok to initialize the type sometime
14282 before its static fields are used', i.e. initialization does not need
14283 to be triggered by the first access to the type. Setting this flag
14284 helps the JIT to compile better code, since it can run the static
14285 constructor at JIT time, and does not need to generate code to call it
14286 (possibly lots of times) at runtime. Unfortunately, mcs does not set
14287 this flag for lots of classes like String.
14289 csc sets this flag if the type does not have an explicit static
14290 constructor. The reasoning seems to be that if there are only static
14291 initalizers for a type, and no static constructor, then the programmer
14292 does not care when this initialization happens, so beforefieldinit
14295 This bug prevents the AOT compiler from being usable, since it
14296 generates so many calls to mono_runtime_class_init that the AOT code
14297 is much slower than the JITted code. The JITted code is faster,
14298 because it does not generate these calls if the vtable is type is
14299 already initialized, which is true in the majority of cases. But the
14300 AOT compiler can't do this."
14302 2004-03-10 Miguel de Icaza <miguel@ximian.com>
14304 * class.cs (MethodData.Emit): Refactor the code so symbolic
14305 information is generated for destructors; For some reasons we
14306 were taking a code path that did not generate symbolic information
14309 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
14311 * class.cs: Create a Constructor.CheckBase method that
14312 takes care of all validation type code. The method
14313 contains some code that was moved from Define.
14315 It also includes new code that checks for duplicate ctors.
14316 This fixes bug #55148.
14318 2004-03-09 Joshua Tauberer <tauberer@for.net>
14320 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
14321 a { ... }-style array creation invokes EmitStaticInitializers
14322 which is not good for reference-type arrays. String, decimal
14323 and now null constants (NullCast) are not counted toward
14324 static initializers.
14326 2004-03-05 Martin Baulig <martin@ximian.com>
14328 * location.cs (SourceFile.HasLineDirective): New public field;
14329 specifies whether the file contains or is referenced by a "#line"
14331 (Location.DefineSymbolDocuments): Ignore source files which
14332 either contain or are referenced by a "#line" directive.
14334 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
14336 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
14337 direct access to our parent, so check the method inline there.
14339 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
14341 * expression.cs (Invocation.EmitCall): Miguel's last commit
14342 caused a regression. If you had:
14347 In Foo the implict this would be null.
14349 2004-02-27 Miguel de Icaza <miguel@ximian.com>
14351 * expression.cs (Invocation.EmitCall): If the method is not
14352 virtual, do not emit a CallVirt to it, use Call.
14354 * typemanager.cs (GetFullNameSignature): Improve the method to
14355 cope with ".ctor" and replace it with the type name.
14357 * class.cs (ConstructorInitializer.Resolve): Now the method takes
14358 as an argument the ConstructorBuilder where it is being defined,
14359 to catch the recursive constructor invocations.
14361 2004-02-26 Miguel de Icaza <miguel@ximian.com>
14363 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
14364 routines to check if a type is an enumerable/enumerator allow
14365 classes that implement the IEnumerable or IEnumerator interfaces.
14367 * class.cs (Property, Operator): Implement IIteratorContainer, and
14368 implement SetYields.
14370 (Property.Define): Do the block swapping for get_methods in the
14371 context of iterators. We need to check if Properties also
14372 include indexers or not.
14374 (Operator): Assign the Block before invoking the
14375 OperatorMethod.Define, so we can trigger the Iterator code
14378 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
14379 Property and Operator classes are not created when we parse the
14380 declarator but until we have the block completed, so we use a
14381 singleton SimpleIteratorContainer.Simple to flag whether the
14382 SetYields has been invoked.
14384 We propagate this setting then to the Property or the Operator to
14385 allow the `yield' to function.
14387 2004-02-25 Marek Safar <marek.safar@seznam.cz>
14389 * codegen.cs: Implemented attribute support for modules.
14390 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
14391 Assembly/Module functionality.
14393 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
14394 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
14395 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
14397 2004-02-16 Marek Safar <marek.safar@seznam.cz>
14399 * interface.cs (FindMembers): The operation is performed on all base
14400 interfaces and not only on the first. It is required for future CLS Compliance patch.
14402 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
14404 * statement.cs, codegen.cs:
14405 This patch deals with patterns such as:
14407 public class List : IEnumerable {
14409 public MyEnumerator GetEnumerator () {
14410 return new MyEnumerator(this);
14413 IEnumerator IEnumerable.GetEnumerator () {
14417 public struct MyEnumerator : IEnumerator {
14422 Before, there were a few things we did wrong:
14423 1) we would emit callvirt on a struct, which is illegal
14424 2) we emited ldarg when we needed to emit ldarga
14425 3) we would mistakenly call the interface methods on an enumerator
14426 type that derived from IEnumerator and was in another assembly. For example:
14428 public class MyEnumerator : IEnumerator
14430 Would have the interface methods called, even if there were public impls of the
14431 method. In a struct, this lead to invalid IL code.
14433 2004-02-11 Marek Safar <marek.safar@seznam.cz>
14435 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
14438 * delegate.cs (Define): Fixed crash when delegate type is undefined.
14440 2004-02-11 Miguel de Icaza <miguel@ximian.com>
14442 * cs-parser.jay: Fix small regression: we were not testing V2
14443 compiler features correctly.
14445 * interface.cs: If the emit context is null, then create one
14447 2004-02-09 Marek Safar <marek.safar@seznam.cz>
14449 * decl.cs (GetSignatureForError): New virtual method to get full name
14450 for error messages.
14452 * attribute.cs (IAttributeSupport): New interface for attribute setting.
14453 Now it is possible to rewrite ApplyAttributes method to be less if/else.
14455 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
14456 Duplicated members and code in these classes has been removed.
14457 Better encapsulation in these classes.
14459 2004-02-07 Miguel de Icaza <miguel@ximian.com>
14461 * assign.cs (Assign.DoResolve): When dealing with compound
14462 assignments, there is a new rule in ECMA C# 2.4 (might have been
14463 there before, but it is documented here) that states that in:
14467 If b is of type int, and the `op' is a shift-operator, then the
14468 above is evaluated as:
14472 * expression.cs (Binary.ResolveOperator): Instead of testing for
14473 int/uint/long/ulong, try to implicitly convert to any of those
14474 types and use that in pointer arithmetic.
14476 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
14477 method to print information for from the type, not from the
14478 null-method we were given.
14480 2004-02-01 Duncan Mak <duncan@ximian.com>
14482 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
14483 parsing for cmd, fixes bug #53694.
14485 2004-02-04 Marek Safar <marek.safar@seznam.cz>
14487 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
14488 in the member name duplication tests. Property and operator name duplication
14489 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
14491 2004-02-03 Marek Safar <marek.safar@seznam.cz>
14493 * interface.cs (PopulateMethod): Fixed crash when interface method
14494 returns not existing type (error test cs0246-3.cs).
14496 2004-02-02 Ravi Pratap M <ravi@ximian.com>
14498 * cs-parser.jay (interface_accessors): Re-write actions to also
14499 store attributes attached to get and set methods. Fix spelling
14502 (inteface_property_declaration): Modify accordingly.
14504 (InterfaceAccessorInfo): New helper class to store information to pass
14505 around between rules that use interface_accessors.
14507 * interface.cs (Emit): Apply attributes on the get and set
14508 accessors of properties and indexers too.
14510 * attribute.cs (ApplyAttributes): Modify accordingly to use the
14511 right MethodBuilder when applying attributes to the get and set accessors.
14513 2004-01-31 Miguel de Icaza <miguel@ximian.com>
14515 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
14517 2004-01-26 Miguel de Icaza <miguel@ximian.com>
14519 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
14521 2004-01-25 Miguel de Icaza <miguel@ximian.com>
14523 * cs-parser.jay: Remove YIELD token, instead use the new grammar
14524 changes that treat `yield' specially when present before `break'
14525 or `return' tokens.
14527 * cs-tokenizer.cs: yield is no longer a keyword.
14529 2004-01-23 Marek Safar <marek.safar@seznam.cz>
14531 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
14532 setting for default constructors.
14533 For default constructors are almost every time set wrong Modifier. The
14534 generated IL code has been alright. But inside mcs this values was
14535 wrong and this was reason why several of my CLS Compliance tests
14538 2004-01-22 Martin Baulig <martin@ximian.com>
14540 * cs-parser.jay (namespace_or_type_name): Return an Expression,
14541 not a QualifiedIdentifier. This is what `type_name_expression'
14542 was previously doing.
14543 (type_name_expression): Removed; the code is now in
14544 `namespace_or_type_name'.
14545 (qualified_identifier): Removed, use `namespace_or_type_name'
14547 (QualifiedIdentifier): Removed this class.
14549 2004-01-22 Martin Baulig <martin@ximian.com>
14551 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
14552 not a string as alias name.
14554 2004-01-21 Miguel de Icaza <miguel@ximian.com>
14556 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
14557 #52730 bug, and instead compute correctly the need to use a
14558 temporary variable when requesting an address based on the
14559 static/instace modified of the field and the constructor.
14561 2004-01-21 Martin Baulig <martin@ximian.com>
14563 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
14564 class and namespace before looking up aliases. Fixes #52517.
14566 2004-01-21 Martin Baulig <martin@ximian.com>
14568 * flowanalysis.cs (UsageVector.Merge): Allow variables being
14569 assinged in a 'try'; fixes exception4.cs.
14571 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14572 * class.cs : Implemented parameter-less constructor for TypeContainer
14574 * decl.cs: Attributes are now stored here. New property OptAttributes
14576 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
14578 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
14580 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14582 * typemanager.cs (CSharpSignature): Now reports also inner class name.
14583 (CSharpSignature): New method for indexer and property signature.
14585 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14587 * pending.cs (IsVirtualFilter): Faster implementation.
14589 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14591 * typemanager.cs: Avoid inclusion of same assembly more than once.
14593 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14595 * cs-parser.jay: Fixed problem where the last assembly attribute
14596 has been applied also to following declaration (class, struct, etc.)
14598 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14600 * class.cs: Added error CS0538, CS0539 reporting.
14601 Fixed crash on Microsoft runtime when field type is void.
14603 * cs-parser.jay: Added error CS0537 reporting.
14605 * pending.cs: Added error CS0535 reporting.
14606 Improved error report for errors CS0536, CS0534.
14608 2004-01-20 Miguel de Icaza <miguel@ximian.com>
14610 Merge a few bits from the Anonymous Method MCS tree.
14612 * statement.cs (ToplevelBlock): New class for toplevel methods,
14613 will hold anonymous methods, lifted variables.
14615 * cs-parser.jay: Create toplevel blocks for delegates and for
14616 regular blocks of code.
14618 2004-01-20 Martin Baulig <martin@ximian.com>
14620 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
14621 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
14622 and `NeedExplicitReturn'; added `IsLastStatement'.
14623 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
14624 have a `ReturnLabel' or we're not unreachable.
14626 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
14627 child's reachability; don't just override ours with it. Fixes
14628 #58058 (lluis's example).
14629 (FlowBranching): Added public InTryOrCatch(), InCatch(),
14630 InFinally(), InLoop(), InSwitch() and
14631 BreakCrossesTryCatchBoundary() methods.
14633 * statement.cs (Return): Do all error checking in Resolve().
14634 Unless we are the last statement in a top-level block, always
14635 create a return label and jump to it.
14636 (Break, Continue): Do all error checking in Resolve(); also make
14637 sure we aren't leaving a `finally'.
14638 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
14639 statement in a top-level block.
14640 (Block.Flags): Added `IsDestructor'.
14641 (Block.IsDestructor): New public property.
14643 2004-01-20 Martin Baulig <martin@ximian.com>
14645 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
14647 2004-01-20 Martin Baulig <martin@ximian.com>
14649 * statement.cs (Statement.ResolveUnreachable): New public method.
14650 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
14651 (Block.Resolve): Resolve unreachable statements.
14653 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14655 * expression.cs: We need to fix the case where we do
14656 not have a temp variable here.
14658 * assign.cs: Only expression compound assignments need
14659 temporary variables.
14661 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14663 * flowanalysis.cs: Reduce memory allocation in a few ways:
14664 - A block with no variables should not allocate a bit
14666 - A method with no out parameters does not need any tracking
14667 for assignment of the parameters, so we need not allocate
14670 public readonly Type[] VariableTypes;
14671 public readonly string[] VariableNames;
14672 Are redundant. The data is already stored in the variable
14673 map, so we need not allocate another array for it.
14674 - We need to add alot of checks for if (params | locals) == null
14675 due to the first two changes.
14677 2004-01-18 Miguel de Icaza <miguel@ximian.com>
14679 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
14680 implement IMemoryLocation, we store a copy on a local variable and
14681 take the address of it. Patch from Benjamin Jemlich
14683 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
14684 to use a special "type_name_expression" rule which reduces the
14685 number of "QualifiedIdentifier" classes created, and instead
14686 directly creates MemberAccess expressions.
14688 2004-01-17 Miguel de Icaza <miguel@ximian.com>
14690 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
14691 that fixes #52853. Null literal assignment to ValueType
14693 * class.cs (MethodData.Emit): Instead of checking the name of the
14694 method to determine if its a destructor, create a new derived
14695 class from Method called Destructor, and test for that.
14697 * cs-parser.jay: Create a Destructor object instead of a Method.
14699 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
14703 2004-01-16 Miguel de Icaza <miguel@ximian.com>
14705 * expression.cs (Binary.ResolveOperator): Perform an implicit
14706 conversion from MethodGroups to their delegate types on the
14707 Addition operation.
14709 * delegate.cs: Introduce a new class DelegateCreation that is the
14710 base class for `NewDelegate' and `ImplicitDelegateCreation',
14711 factor some code in here.
14713 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
14714 conversion from MethodGroups to compatible delegate types.
14716 * ecore.cs (Expression.Resolve): Do not flag error 654
14717 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
14718 we allow conversions from MethodGroups to delegate types now.
14720 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
14721 assignments in v2 either.
14723 2004-01-10 Miguel de Icaza <miguel@ximian.com>
14725 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
14726 static read-only fields in ctors.
14728 Applied patch from Benjamin Jemlich
14730 * expression.cs (UnaryMutator): Avoid leaking local variables.
14732 2004-01-09 Miguel de Icaza <miguel@ximian.com>
14734 * cs-tokenizer.cs (IsCastToken): Allow the various native types
14735 here to return true, as they can be used like this:
14737 (XXX) int.MEMBER ()
14739 Fixed 49836 and all the other dups
14741 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
14743 * driver.cs: Implement /win32res and /win32icon.
14745 2004-01-08 Miguel de Icaza <miguel@ximian.com>
14747 * cs-parser.jay: Add a rule to improve error handling for the
14748 common mistake of placing modifiers after the type.
14750 2004-01-07 Miguel de Icaza <miguel@ximian.com>
14752 * cs-parser.jay (interface_event_declaration): Catch
14753 initialization of events on interfaces, and report cs0068
14755 * cs-parser.jay (interface_event_declaration): Catch
14756 initialization of events.
14758 * ecore.cs: Better report missing constructors.
14760 * expression.cs (Binary.ResolveOperator): My previous bug fix had
14761 the error reporting done in the wrong place. Fix.
14763 * expression.cs (Binary.ResolveOperator): Catch the
14764 operator + (E x, E y) error earlier, and later allow for implicit
14765 conversions in operator +/- (E e, U x) from U to the underlying
14768 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
14769 52596, if the container class is abstract, the default constructor
14770 is protected otherwise its public (before, we were always public).
14772 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
14775 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
14776 Jemlich that fixes bug #52597, MCS was generating invalid code for
14777 idisposable structs. Thanks to Ben for following up with this
14780 2004-01-06 Miguel de Icaza <miguel@ximian.com>
14782 * driver.cs: Allow assemblies without code to be generated, fixes
14785 2004-01-07 Nick Drochak <ndrochak@gol.com>
14787 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
14789 2004-01-05 Miguel de Icaza <miguel@ximian.com>
14791 * cs-parser.jay: Add rules to improve error reporting if fields or
14792 methods are declared at the namespace level (error 116)
14794 * Add rules to catch event add/remove
14796 2004-01-04 David Sheldon <dave-mono@earth.li>
14798 * expression.cs: Added matching ")" to error message for
14801 2004-01-03 Todd Berman <tberman@gentoo.org>
14803 * ecore.cs, attribute.cs:
14804 Applying fix from #52429.
14806 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14808 * ecore.cs, expression.cs, statement.cs:
14809 Total rewrite of how we handle branching. We
14810 now handle complex boolean expressions with fewer
14811 jumps. As well if (x == 0) no longer emits a ceq.
14813 if (x is Foo) is much faster now, because we generate
14816 Overall, we get a pretty big improvement on our benchmark
14817 tests. The code we generate is smaller and more readable.
14819 I did a full two-stage bootstrap. The patch was reviewed
14820 by Martin and Miguel.
14822 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14824 * cs-parser.jay: Make primary_expression not take a QI.
14825 we dont need this because the member_access rule covers
14826 us here. So we replace the rule with just IDENTIFIER.
14828 This has two good effects. First, we remove a s/r conflict.
14829 Second, we allocate many fewer QualifiedIdentifier objects.
14831 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14833 * attribute.cs: Handle MarshalAs attributes as pseudo, and
14834 set the correct information via SRE. This prevents
14835 hanging on the MS runtime. Fixes #29374.
14837 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14839 * convert.cs: correctly handle conversions to value types
14840 from Enum and ValueType as unboxing conversions.
14842 Fixes bug #52569. Patch by Benjamin Jemlich.
14844 2004-01-02 Ravi Pratap <ravi@ximian.com>
14846 * expression.cs (BetterConversion): Prefer int -> uint
14847 over int -> ulong (csc's behaviour). This fixed bug #52046.
14849 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
14851 * decl.cs (MemberCache.FindMembers): now returns a
14854 * typemanager.cs: In general, go with with ^^.
14855 (CopyNewMethods): take an IList.
14856 (RealMemberLookup): Only allocate an arraylist
14857 if we copy from two sets of methods.
14859 This change basically does two things:
14860 1) Fewer array lists allocated due to CopyNewMethods.
14861 2) the explicit cast in MemberList costed ALOT.
14863 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
14865 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
14866 a hashtable to avoid needless string allocations when an identifier is
14867 used more than once (the common case).
14869 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14871 * pending.cs: MS's TypeBuilder.GetInterfaces ()
14872 is broken, it will not return anything. So, we
14873 have to use the information we have in mcs to
14876 * typemanager.cs: Add a cache for GetInterfaces,
14877 since this will now be used more often (due to ^^)
14879 (GetExplicitInterfaces) New method that gets the
14880 declared, not effective, interfaces on a type
14881 builder (eg, if you have interface IFoo, interface
14882 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
14885 This patch makes MCS able to bootstrap itself on
14888 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14890 * expression.cs: Remove the Nop's that Miguel put
14893 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14895 * report.cs, codegen.cs: Give the real stack trace to
14896 the error when an exception is thrown.
14898 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14900 * decl.cs: only allocate hashtables for ifaces if
14903 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14905 * expression.cs: fix the error from cs0121-2.cs
14906 (a parent interface has two child interfaces that
14907 have a function with the same name and 0 params
14908 and the function is called through the parent).
14910 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
14912 * class.cs, rootcontext.cs, typmanager.cs: do not
14915 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
14917 * codegen.cs: remove stack for the ec flow branching.
14918 It is already a linked list, so no need.
14920 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
14922 * Makefile: Allow custom profiler here.
14924 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14926 * typemanager.cs (LookupType):
14927 - Use a static char [], because split takes
14928 a param array for args, so it was allocating
14930 - Do not store true in a hashtable, it boxes.
14932 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14934 * flowanalysis.cs: bytify common enums.
14936 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14938 * modifiers.cs: Add a new set of flags for the
14939 flags allowed on explicit interface impls.
14940 * cs-parser.jay: catch the use of modifiers in
14941 interfaces correctly.
14942 * class.cs: catch private void IFoo.Blah ().
14944 All related to bug #50572.
14946 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14948 * decl.cs: Rewrite the consistant accessability checking.
14949 Accessability is not linear, it must be implemented in
14950 a tableish way. Fixes #49704.
14952 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14954 * expression.cs: Handle negation in a checked context.
14955 We must use subtraction from zero. Fixes #38674.
14957 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14959 * class.cs: Ignore static void main in DLLs.
14960 * rootcontext.cs: Handle the target type here,
14961 since we are have to access it from class.cs
14962 * driver.cs: account for the above.
14964 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14966 * report.cs: Give line numbers and files if available.
14968 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
14970 * driver.cs: Implement /addmodule.
14972 * typemanager.cs: Change 'modules' field so it now contains Modules not
14975 2003-12-20 Martin Baulig <martin@ximian.com>
14977 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
14978 (FieldBase.IsAssigned): Removed this field.
14979 (FieldBase.SetAssigned): New public method.
14980 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
14982 2003-12-20 Martin Baulig <martin@ximian.com>
14984 * expression.cs (LocalVariableReference.DoResolve): Don't set
14985 `vi.Used' if we're called from DoResolveLValue().
14987 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
14988 returns the usage vector it just merged into the current one -
14989 pass this one to UsageWarning().
14990 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
14991 of the `EmitContext', don't call this recursively on our children.
14993 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
14995 * driver.cs: Implement /target:module.
14997 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
14999 * support.cs (CharArrayHashtable): New helper class.
15001 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
15002 char arrays, not strings, so we can avoid creating a string in
15003 consume_identifier if the identifier is a keyword.
15005 2003-12-16 Martin Baulig <martin@ximian.com>
15007 * statement.cs (LocalInfo.Assigned): Removed this property.
15008 (LocalInfo.Flags): Removed `Assigned'.
15009 (LocalInfo.IsAssigned): New public method; takes the EmitContext
15010 and uses flow analysis.
15011 (Block.UsageWarning): Made this method private.
15012 (Block.Resolve): Call UsageWarning() if appropriate.
15014 * expression.cs (LocalVariableReference.DoResolve): Always set
15015 LocalInfo.Used here.
15017 2003-12-13 Martin Baulig <martin@ximian.com>
15019 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
15020 any value here; we're now using flow analysis to figure out
15021 whether a statement/block returns a value.
15023 2003-12-13 Martin Baulig <martin@ximian.com>
15025 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
15027 (FlowBranching.MergeFinally): Don't call
15028 `branching.CheckOutParameters()' here, this is called in
15030 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
15031 when adding the `finally' vector.
15033 2003-12-13 Martin Baulig <martin@ximian.com>
15036 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
15037 actually work and also fix #48962.
15039 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
15041 * decl.cs: Do not check System.Object for nested types,
15042 since we know it does not have any. Big bang for buck:
15045 Run 1: 8.35 seconds
15046 Run 2: 8.32 seconds
15047 corlib: 17.99 seconds
15049 Run 1: 8.17 seconds
15050 Run 2: 8.17 seconds
15051 corlib: 17.39 seconds
15053 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
15055 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
15056 time we are returning 0 members, so we save alot here.
15058 2003-12-11 Martin Baulig <martin@ximian.com>
15060 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
15061 `MergeChild()', also just take the `FlowBranching' as argument;
15062 call Merge() on it and return the result.
15063 (FlowBranching.Merge): We don't need to do anything if we just
15066 2003-12-11 Martin Baulig <martin@ximian.com>
15068 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
15069 them in an `ArrayList' to reduce memory usage. Thanks to Ben
15070 Maurer for this idea.
15072 2003-12-11 Martin Baulig <martin@ximian.com>
15074 * flowanalysis.cs (MergeResult): This class is now gone; we now
15075 use the `UsageVector' for this. The reason for this is that if a
15076 branching just has one sibling, we don't need to "merge" them at
15077 all - that's the next step to do.
15078 (FlowBranching.Merge): We now return a `UsageVector' instead of a
15081 2003-12-11 Martin Baulig <martin@ximian.com>
15083 Reworked flow analyis and made it more precise and bug-free. The
15084 most important change is that we're now using a special `Reachability'
15085 class instead of having "magic" meanings of `FlowReturns'. I'll
15086 do some more cleanups and optimizations and also add some more
15087 documentation this week.
15089 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
15090 largely reworked this class.
15091 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
15092 the new `Reachability' class instead of having "magic" values here.
15093 (FlowBranching): We're now using an instance of `Reachability'
15094 instead of having separate `Returns', `Breaks' etc. fields.
15096 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
15097 based on flow analysis; ignore the return value of block.Emit ().
15099 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
15101 * driver.cs typemanager.cs: Find the mono extensions to corlib even
15102 if they are private.
15104 2003-12-09 Martin Baulig <martin@ximian.com>
15106 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
15107 call them directly on the UsageVector.
15109 2003-12-09 Martin Baulig <martin@ximian.com>
15111 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
15112 Changed return type from `FlowReturns' to `Reachability'.
15114 2003-12-09 Martin Baulig <martin@ximian.com>
15116 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
15117 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
15118 `Reachable' fields with a single `Reachability' one.
15120 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15122 * class.cs (FindMembers): Remove foreach's.
15127 Run 1: 8.74 seconds
15128 Run 2: 8.71 seconds
15131 Run 1: 8.64 seconds
15132 Run 2: 8.58 seconds
15135 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15140 This patch does a few things:
15141 1. EmptyStatement is now a singleton, so it is never reallocated.
15142 2. All blah is EmptyStatement constructs have been changed to
15143 blah == EmptyStatement.Value, which is much faster and valid
15144 now that EmptyStatement is a singleton.
15145 3. When resolving a block, rather than allocating a new array for
15146 the non-empty statements, empty statements are replaced with
15147 EmptyStatement.Value
15148 4. Some recursive functions have been made non-recursive.
15149 Mainly the performance impact is from (3), however (1) and (2) are needed for
15150 this to work. (4) does not make a big difference in normal situations, however
15151 it makes the profile look saner.
15156 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15157 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15158 Total memory allocated: 56397 KB
15161 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
15162 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
15163 Total memory allocated: 55666 KB
15165 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15167 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15168 than the hashtable in a hashtable version
15170 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
15171 we always end up concating a string. This results in a huge perf
15172 loss, because many strings have to be tracked by the GC. In this
15173 patch, we first use a hashtable that works with two keys, so that
15174 the strings do not need to be concat'ed.
15178 Run 1: 8.74 seconds
15179 Run 2: 8.71 seconds
15182 Run 1: 8.65 seconds
15183 Run 2: 8.56 seconds
15185 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15187 * Makefile: Add a new target `do-time' that does a quick and simple
15188 profile, leaving easy to parse output.
15190 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
15192 * codegen.cs (Init): Create the dynamic assembly with
15193 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
15195 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
15197 * support.cs: Make the PtrHashtable use only one
15198 instance of its comparer.
15200 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
15202 * typemanager.cs: Fix lookup of GetNamespaces.
15204 2003-11-29 Miguel de Icaza <miguel@ximian.com>
15206 * expression.cs: Removed redundant line.
15208 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
15209 ArrayLists, use for loops with bounds.
15211 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
15214 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
15215 arraylists, use for loop with bounds.
15217 The above three changes give us a 0.071 second performance
15218 improvement out of 3.294 seconds down to 3.223. On my machine
15219 the above changes reduced the memory usage by 1,387 KB during
15220 compiler bootstrap.
15222 * cs-parser.jay (QualifiedIdentifier): New class used to represent
15223 QualifiedIdentifiers. Before we created a new string through
15224 concatenation, and mostly later on, the result would be
15225 manipulated by DecomposeQI through string manipulation.
15227 This reduced the compiler memory usage for bootstrapping from
15228 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
15229 compile times in 0.05 seconds.
15231 2003-11-28 Dick Porter <dick@ximian.com>
15233 * support.cs: Do string compares with the Invariant culture.
15241 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
15242 the comparison is done with the Invariant culture.
15244 2003-11-27 Miguel de Icaza <miguel@ximian.com>
15246 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
15247 GetEnumerator method.
15249 (ProbeCollectionType): Iterate starting at the most specific type
15250 upwards looking for a GetEnumerator
15252 * expression.cs: Shift count can be up to 31 for int/uint and 63
15255 2003-11-26 Miguel de Icaza <miguel@ximian.com>
15257 * statement.cs (Block.LookupLabel): Also look for the label on the
15258 children blocks. Use a hash table to keep track of visited
15261 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
15262 we actually did transform the other operand, otherwise fall back
15263 to the common codepath that casts to long.
15265 * cs-tokenizer.cs: Use the same code pattern as the int case.
15266 Maybe I should do the parsing myself, and avoid depending on the
15267 Parse routines to get this done.
15269 2003-11-25 Miguel de Icaza <miguel@ximian.com>
15271 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15272 which fixes bug 51347. This time test it.
15274 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
15275 attributes for example can not tell the difference between these.
15276 The difference was only a syntax feature of the language.
15278 * attribute.cs: Apply attributes to delegates.
15280 * delegate.cs: Call the apply attributes method.
15282 2003-11-24 Miguel de Icaza <miguel@ximian.com>
15284 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
15285 comparing 0 vs Byte.MinValue, not the value
15287 (ImplicitConversionRequired): When reporting a conversion error,
15288 use error 31 to print out the constant error instead of the
15291 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15292 which fixes bug 51347.
15294 2003-11-22 Miguel de Icaza <miguel@ximian.com>
15296 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
15297 which fixes the -warnaserror command line option.
15299 2003-11-21 Miguel de Icaza <miguel@ximian.com>
15301 * cfold.cs (DoNumericPromotions): During constant folding of
15302 additions on UIntConstant, special case intconstants with
15303 IntConstants like we do on the expression binary operator.
15305 2003-11-12 Miguel de Icaza <miguel@ximian.com>
15307 * convert.cs (ImplicitReferenceConversion): We were missing a case
15308 (System.Enum are not value types or class types, so we need to
15309 classify them separatedly).
15311 * driver.cs: We do not support error 2007.
15313 2003-11-12 Jackson Harper <jackson@ximian.com>
15315 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
15316 system directory. Also use the full file name so users can
15317 libraries names mscorlib-o-tron.dll in a non system dir.
15319 2003-11-10 Martin Baulig <martin@ximian.com>
15321 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
15322 (TypeManager.InitCoreTypes): Initialize them here, but instead of
15323 calling `ResolveType()' on them, directly assign their `Type'.
15325 2003-11-08 Martin Baulig <martin@ximian.com>
15327 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
15328 return value and the `out parent' parameter.
15329 (TypeContainer.DefineType): Moved the CS0644 check into
15330 GetClassBases(). Don't pass the interface types to the
15331 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
15332 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
15334 * ecore.cs (TypeExpr.IsAttribute): New property.
15335 (TypeExpr.GetInterfaces): New method.
15337 * interface.cs (Interface.GetInterfaceTypeByName): Return a
15338 TypeExpr instead of a Type.
15339 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
15340 (Interface.DefineType): Don't pass the interface types to the
15341 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
15342 them later and then call `TypeBulider.AddInterfaceImplementation()'.
15344 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
15345 instead of a `Type[]'.
15346 (TypeManager.RegisterBuilder): Likewise.
15347 (TypeManager.AddUserInterface): Likewise.
15348 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
15349 `Type[]' and also return a `TypeExpr[]'.
15350 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
15352 2003-11-08 Martin Baulig <martin@ximian.com>
15354 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
15357 2003-11-08 Martin Baulig <martin@ximian.com>
15359 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
15360 TypeManager.ResolveExpressionTypes().
15362 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
15363 instead of an Expression.
15364 (TypeExpr): This is now an abstract base class for `TypeExpression'.
15365 (TypeExpression): New public class; formerly known as `TypeExpr'.
15367 * expression.cs (ComposedCast): Derive from TypeExpr.
15369 * typemanager.cs (TypeManager.system_*_expr): These are now
15370 TypExpr's instead of Expression's.
15371 (TypeManager.ResolveExpressionTypes): New public static function;
15372 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
15375 2003-11-06 Miguel de Icaza <miguel@ximian.com>
15377 * expression.cs (New.DoResolve): Do not dereference value that
15378 might be a null return.
15380 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
15381 sure that the constant value has the right type. Fixes an
15382 unreported bug, similar to 50425.
15384 * const.cs (Const.LookupConstantValue): Call
15385 ImplicitStandardConversionExists before doing a conversion to
15386 avoid havng the TypeManager.ChangeType do conversions.
15388 Reduced the number of casts used
15390 (Const.ChangeType): New routine to enable reuse of the constant
15391 type changing code from statement.
15393 * typemanager.cs (ChangeType): Move common initialization to
15394 static global variables.
15398 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
15399 every value type to go through, even if it was void. Fix that.
15401 * cs-tokenizer.cs: Use is_identifier_start_character on the start
15402 character of the define, and the is_identifier_part_character for
15403 the rest of the string.
15405 2003-11-05 Miguel de Icaza <miguel@ximian.com>
15407 * expression.cs (UnaryMutator.EmitCode): When I updated
15408 LocalVariableReference.DoResolve, I overdid it, and dropped an
15409 optimization done on local variable references.
15411 2003-11-04 Miguel de Icaza <miguel@ximian.com>
15413 * ecore.cs: Convert the return from Ldlen into an int.
15415 2003-10-20 Miguel de Icaza <miguel@ximian.com>
15417 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
15418 the accessibility, this is a special case for toplevel non-public
15419 classes (internal for instance).
15421 2003-10-20 Nick Drochak <ndrochak@gol.com>
15423 * ecore.cs: Fix typo and build. Needed another right paren.
15425 2003-10-19 Miguel de Icaza <miguel@ximian.com>
15427 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
15428 `internal' case regular and protected, but not allowing protected
15429 to be evaluated later. Bug 49840
15431 2003-10-15 Miguel de Icaza <miguel@ximian.com>
15433 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
15434 to kb.Nlast, and not the kb.nFirst to isolate the switch
15437 Extract the underlying type, so enumerations of long/ulong are
15438 treated like long/ulong.
15440 2003-10-14 Miguel de Icaza <miguel@ximian.com>
15442 * expression.cs (New): Overload the meaning of RequestedType to
15443 track the possible creation of the NewDelegate type, since
15444 DoResolve is invoked more than once for new constructors on field
15447 See bugs: #48800 and #37014
15449 * cs-parser.jay (declare_local_constants): Take an arraylist
15450 instead of a single constant.
15452 (local_constant_declaration): It should take a
15453 constant_declarators, not a constant_declarator. Fixes 49487
15455 * convert.cs: Fix error report.
15457 2003-10-13 Jackson Harper <jackson@ximian.com>
15459 * typemanager.cs (TypeToCoreType): Add float and double this fixes
15462 2003-10-09 Martin Baulig <martin@ximian.com>
15464 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
15466 (MethodCore.DoDefineParameters): Removed the TypeContainer
15467 argument; use the DeclSpace which was passed to the .ctor instead.
15468 (MethodCore.CheckParameter): Take a DeclSpace instead of a
15469 TypeContainer; we only need a DeclSpace here.
15471 2003-10-09 Martin Baulig <martin@ximian.com>
15473 * class.cs (MethodData): Added additional `DeclSpace ds' argument
15475 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
15476 EmitContext's .ctor.
15478 2003-10-09 Martin Baulig <martin@ximian.com>
15480 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
15481 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
15482 AsAccessible(), moved them as well.
15484 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
15486 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
15488 * cs-parser.jay : Renamed yyName to yyNames related to jay.
15490 2003-10-07 Miguel de Icaza <miguel@ximian.com>
15492 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
15493 generation for >=, as spotted by Paolo, bug 48679.
15494 Patch from David Waite.
15496 * cs-tokenizer.cs: Add handling for #pragma.
15498 * cs-parser.jay: Allow for both yield and yield return in the
15499 syntax. The anti-cobolization of C# fight will go on!
15501 * class.cs (TypeBuilder.DefineType): Catch error condition here
15502 (Parent.DefineType erroring out and returning null).
15504 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15505 coping with enumerations variables, we were mistakenly processing
15506 them as a regular value type instead of built-in types. Fixes the
15509 * typemanager.cs (IsBuiltinOrEnum): New method.
15511 2003-09-30 Miguel de Icaza <miguel@ximian.com>
15513 * cs-parser.jay: Upgrade: yield now needs the return clause.
15515 2003-09-19 Martin Baulig <martin@ximian.com>
15517 * decl.cs (MemberCache.SetupCacheForInterface): Take a
15518 `MemberCache parent' argument. Normally, an interface doesn't
15519 have a parent type except System.Object, but we use this in gmcs
15520 for generic type parameters.
15522 2003-09-18 Martin Baulig <martin@ximian.com>
15524 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
15525 on `type.IsInterface'; don't check whether the type has a parent
15526 to determine whether it's an interface.
15528 2003-09-15 Martin Baulig <martin@ximian.com>
15530 * class.cs (TypeContainer.DefineType): Added an error flag to
15531 avoid reporting duplicate CS0146's ("class definition is
15534 * driver.cs (Driver.MainDriver): Abort if
15535 RootContext.ResolveTree() reported any errors.
15537 2003-09-07 Martin Baulig <martin@ximian.com>
15539 * report.cs (Error, Warning): Added overloaded versions which take
15540 a `params object[] args' and call String.Format().
15542 2003-09-07 Martin Baulig <martin@ximian.com>
15544 * decl.cs (DeclSpace..ctor): Don't call
15545 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
15546 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
15547 (DeclSpace.RecordDecl): New method.
15549 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
15551 2003-09-02 Ravi Pratap <ravi@ximian.com>
15553 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
15554 value attributes to be applied to ParameterBuilders.
15556 * class.cs (MethodCore.LabelParameters): Make static and more
15557 generic so that it can be used from other places - like interface
15558 methods, for instance.
15560 * interface.cs (Interface.Emit): Call LabelParameters before
15561 emitting attributes on the InterfaceMethod.
15563 2003-08-26 Martin Baulig <martin@ximian.com>
15565 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
15566 resolving aliases; fixes #47927.
15568 2003-08-26 Martin Baulig <martin@ximian.com>
15570 * statement.cs (Using.DoResolve): This is internally emitting a
15571 try/finally clause, so we need to set ec.NeedExplicitReturn if we
15572 do not always return. Fixes #47681.
15574 2003-08-26 Martin Baulig <martin@ximian.com>
15576 * decl.cs (MemberCore): Moved WarningNotHiding(),
15577 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
15579 (AdditionResult): Make this nested in DeclSpace.
15580 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
15581 argument; call NamespaceEntry.Define() unless we're nested in a
15584 * namespace.cs (Namespace.DefineName): New public function. This
15585 is called from DeclSpace's .ctor to add
15586 (Namespace.Lookup): Include DeclSpaces in the lookup.
15588 * class.cs (Operator): Derive from MemberBase, not MemberCore.
15590 * const.cs (Const): Derive from MemberBase, not MemberCore.
15592 2003-08-25 Martin Baulig <martin@ximian.com>
15594 * convert.cs (Convert.ExplicitReferenceConversion): When
15595 converting from an interface type to a class, unbox if the target
15596 type is a struct type. Fixes #47822.
15598 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15600 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
15603 2003-08-22 Martin Baulig <martin@ximian.com>
15605 * class.cs (TypeManager.DefineType): When defining a nested type,
15606 call DefineType() on our parent; fixes #47801.
15608 2003-08-22 Martin Baulig <martin@ximian.com>
15610 * class.cs (MethodData.Define): While checking if a method is an
15611 interface implementation, improve the test a bit more to fix #47654.
15613 2003-08-22 Martin Baulig <martin@ximian.com>
15615 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
15616 correctly; fixes #47722.
15618 2003-08-22 Martin Baulig <martin@ximian.com>
15620 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
15621 LocalVariableReference, ensure it's not read-only. Fixes #47536.
15623 * statement.cs (Fixed.DoResolve): Make all variables read-only.
15625 2003-08-22 Martin Baulig <martin@ximian.com>
15627 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
15628 can only be assigned in static constructors. Fixes #47161.
15630 2003-08-22 Martin Baulig <martin@ximian.com>
15632 Rewrote and improved the flow analysis code.
15634 * flowbranching.cs (FlowBranching): Make this class abstract.
15635 (FlowBranching.CreateBranching): New static function to create a
15636 new flow branching.
15637 (FlowBranchingBlock, FlowBranchingException): New classes.
15638 (FlowBranching.UsageVector.Type): New public readonly field.
15639 (FlowBranching.UsageVector.Breaks): Removed the setter.
15640 (FlowBranching.UsageVector.Returns): Removed the setter.
15641 (FlowBranching.UsageVector): Added Break(), Return(),
15642 NeverReachable() and Throw() methods to modify the reachability.
15643 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
15644 done by FlowBranching.Merge().
15645 (FlowBranching.UsageVector.MergeChild): New method; merges the
15646 merge result into the current vector.
15647 (FlowBranching.Merge): New abstract method to merge a branching.
15649 2003-08-12 Martin Baulig <martin@ximian.com>
15651 * expression.cs (Indirection.CacheTemporaries): Create the
15652 LocalTemporary with the pointer type, not its element type.
15654 2003-08-10 Miguel de Icaza <miguel@ximian.com>
15656 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
15657 token was a keyword or not.
15659 Add `error' options where an IDENTIFIER was expected; Provide
15660 CheckToken and CheckIdentifierToken convenience error reporting
15663 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
15665 * decl.cs: Rename `NamespaceEntry Namespace' public field into
15666 NameSpaceEntry NameSpaceEntry.
15668 (LookupInterfaceOrClass): Avoid creating a full qualified name
15669 from namespace and name: avoid doing lookups when we know the
15670 namespace is non-existant. Use new Tree.LookupByNamespace which
15671 looks up DeclSpaces based on their namespace, name pair.
15673 * driver.cs: Provide a new `parser verbose' to display the
15674 exception thrown during parsing. This is turned off by default
15675 now, so the output of a failure from mcs is more graceful.
15677 * namespace.cs: Track all the namespaces defined in a hashtable
15680 (IsNamespace): New method
15682 2003-08-09 Miguel de Icaza <miguel@ximian.com>
15684 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
15685 we know that we need to concatenate (full typename can never be
15690 * statement.cs: Use a bitfield; Do not initialize to null things
15691 which are done by the constructor by default.
15693 * cs-parser.jay: bug fix, parameter was 4, not 3.
15695 * expression.cs: Just use the property;
15697 * statement.cs: No need for GetVariableInfo method.
15699 2003-08-08 Martin Baulig <martin@ximian.com>
15701 * flowanalysis.cs (FlowReturns): This is now nested in the
15702 `FlowBranching' class.
15703 (MyBitVector): Moved this here from statement.cs.
15704 (FlowBranching.SiblingType): New enum type.
15705 (FlowBranching.CreateSibling): Added `SiblingType' argument.
15707 2003-08-07 Martin Baulig <martin@ximian.com>
15709 * flowanalysis.cs (FlowBranchingType): This is now nested in the
15710 `FlowBranching' class and called `BranchingType'.
15712 2003-08-07 Martin Baulig <martin@ximian.com>
15714 * flowanalysis.cs: Moved all the control flow analysis code into
15717 2003-08-07 Martin Baulig <martin@ximian.com>
15719 * assign.cs (Assign.DoResolve): `target' must either be an
15720 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
15723 2003-08-07 Miguel de Icaza <miguel@ximian.com>
15725 * expression.cs (BinaryMethod): This kind of expression is created by the
15726 Binary class if it determines that the operator has to be handled
15729 (BinaryDelegate): This kind of expression is created if we are
15730 dealing with a + or - operator on delegates.
15732 (Binary): remove method, argumetns, and DelegateOperator: when
15733 dealing with methods,
15735 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
15737 * statement.cs (Block): use bitfields for the three extra booleans
15738 we had in use. Remove unused topblock parameter.
15740 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
15742 * assign.cs: Drop extra unneeded tests.
15744 2003-08-06 Miguel de Icaza <miguel@ximian.com>
15746 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
15748 * statement.cs (Foreach): Use VariableStorage instead of
15751 * codegen.cs (VariableStorage): New class used by clients that
15752 require a variable stored: locals or fields for variables that
15753 need to live across yield.
15755 Maybe provide a convenience api for EmitThis+EmitLoad?
15757 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
15760 2003-08-05 Miguel de Icaza <miguel@ximian.com>
15762 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
15763 RemapParameterLValue): New methods that are used to turn a
15764 precomputed FieldInfo into an expression like this:
15768 The idea is to use this instead of making LocalVariableReference
15769 have more than one meaning.
15771 * cs-parser.jay: Add error production to BASE.
15773 * ecore.cs: Deal with TypeManager.GetField returning null, which
15774 is now a valid return value.
15776 (FieldExprNoAddress): New expression for Fields whose address can
15779 * expression.cs (LocalVariableReference): During the resolve
15780 phases, create new expressions if we are in a remapping context.
15781 Remove code that dealt with remapping here.
15783 (ParameterReference): same.
15785 (ProxyInstance): New expression, like the `This' expression, but
15786 it is born fully resolved. We know what we are doing, so remove
15787 the errors that are targeted to user-provided uses of `this'.
15789 * statement.cs (Foreach): our variable is now stored as an
15790 Expression; During resolution, follow the protocol, dont just
15791 assume it will return this.
15793 2003-08-06 Martin Baulig <martin@ximian.com>
15795 * support.cs (SeekableStreamReader.cs): New public class.
15797 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
15798 SeekableStreamReader instead of the normal StreamReader.
15800 2003-08-04 Martin Baulig <martin@ximian.com>
15802 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
15803 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
15804 deambiguate casts and delegate invocations.
15805 (parenthesized_expression): Use the new tokens to ensure this is
15806 not a cast of method invocation.
15808 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
15809 when reading a `)' and Deambiguate_CloseParens () was previously
15812 * expression.cs (ParenthesizedExpression): New class. This is
15813 just used for the CS0075 test.
15814 (Binary.DoResolve): Check for CS0075.
15816 2003-07-29 Ravi Pratap <ravi@ximian.com>
15818 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
15819 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
15820 reference comparison.
15822 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
15823 examine the ReturnType for equality - this is necessary in the
15824 cases of implicit and explicit operators whose signature also
15825 includes the return type.
15827 2003-07-26 Miguel de Icaza <miguel@ximian.com>
15829 * namespace.cs: Cache the result of the namespace computation,
15830 instead of computing it every time.
15832 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15834 * decl.cs: Use a global arraylist that we reuse over invocations
15835 to avoid excesive memory consumption. Reduces memory usage on an
15836 mcs compile by one meg (45 average).
15838 * typemanager.cs (LookupTypeReflection): In .NET pointers are
15839 private, work around that.
15841 2003-07-23 Miguel de Icaza <miguel@ximian.com>
15843 * literal.cs (IntLiteral): Define Zero and One static literals.
15845 * cs-parser.jay (integer_literal): use static literals to reduce
15846 memory usage for the most used literals (0, 1 and -1). 211kb
15847 reduced in memory usage.
15849 Replace all calls to `new ArrayList' with `new
15850 ArrayList(4)' which is a good average number for most allocations,
15851 and also requires only 16 bytes of memory for its buffer by
15854 This reduced MCS memory usage in seven megabytes for the RSS after
15857 2003-07-28 Ravi Pratap <ravi@ximian.com>
15859 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
15860 handle params methods the correct way by forming only one
15861 applicable set with params and normal methods in them. Earlier we
15862 were looking at params methods only if we found no normal methods
15863 which was not the correct thing to do.
15865 (Invocation.BetterFunction): Take separate arguments indicating
15866 when candidate and the best method are params methods in their
15869 This fixes bugs #43367 and #46199.
15871 * attribute.cs: Documentation updates.
15873 (CheckAttribute): Rename to CheckAttributeTarget.
15874 (GetValidPlaces): Rename to GetValidTargets.
15876 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
15877 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
15881 2003-07-28 Martin Baulig <martin@ximian.com>
15883 * class.cs (TypeContainer.DefineMembers): Use the base type's full
15884 name when looking up the base class of a nested class. Fixes #46977.
15886 2003-07-26 Martin Baulig <martin@ximian.com>
15888 * expression.cs (Indexers.Indexer): New nested struct; contains
15889 getter, setter and the indexer's type.
15890 (Indexers.Properties): This is now an ArrayList of
15891 Indexers.Indexer's.
15892 (IndexerAccess.DoResolveLValue): Correctly set the type if the
15893 indexer doesn't have any getters.
15895 * assign.cs (Assign.DoResolve): Also do the implicit conversions
15896 for embedded property and indexer assignments.
15898 2003-07-26 Martin Baulig <martin@ximian.com>
15900 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
15901 preprocessor directive is not the first non-whitespace character
15904 2003-07-26 Martin Baulig <martin@ximian.com>
15906 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
15907 namespace parsing, follow the spec more closely.
15909 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
15910 NamespaceEntry.Lookup().
15912 2003-07-25 Martin Baulig <martin@ximian.com>
15914 * MethodCore.cs (OverridesSomething): New public field; it's set
15915 from TypeContainer.DefineMembers if this method overrides
15916 something (which doesn't need to be a method). Fix #39462.
15918 2003-07-25 Ravi Pratap <ravi@ximian.com>
15920 * typemanager.cs (GetMembers): Ensure that the list of members is
15921 reversed. This keeps things in sync.
15923 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
15924 find an AttributeUsage attribute.
15926 * expression.cs (Invocation.OverloadResolve): Perform the check
15927 which disallows Invoke to be directly called on a Delegate.
15929 (Error_InvokeOnDelegate): Report error cs1533.
15931 2003-07-25 Martin Baulig <martin@ximian.com>
15933 * expression.cs (Indexers.GetIndexersForType): Only look in the
15934 interface hierarchy if the requested type is already an
15935 interface. Fixes #46788 while keeping #46502 fixed.
15937 2003-07-25 Martin Baulig <martin@ximian.com>
15939 * class.cs (TypeContainer.DefineMembers): Check whether all
15940 readonly fields have been assigned and report warning CS0649 if
15943 * statement.cs (LocalInfo.IsFixed): Always return true if this is
15946 2003-07-24 Ravi Pratap <ravi@ximian.com>
15948 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
15949 returned from GetMethods to make things consistent with the
15950 assumptions MCS makes about ordering of methods.
15952 This should comprehensively fix bug #45127 and it does :-)
15954 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
15955 ordering is actually reverse.
15957 * Clean up some debug messages I left lying around.
15959 * interface.cs (Populate*): Get rid of code which emits attributes
15960 since the stage in which we emit attributes is the 'Emit' stage,
15961 not the define stage.
15963 (Emit): Move attribute emission for interface members here.
15965 2003-07-22 Ravi Pratap <ravi@ximian.com>
15967 * expression.cs (Invocation.OverloadResolve): Follow the spec more
15968 closely: we eliminate methods in base types when we have an
15969 applicable method in a top-level type.
15971 Please see section 14.5.5.1 for an exact description of what goes
15974 This fixes bug #45127 and a host of other related to corlib compilation.
15976 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
15977 array is the method corresponding to the top-level type (this is
15978 because of the changes made to icall.c) so we change this
15981 (MethodGroupExpr.Name): This too.
15983 * typemanager.cs (GetElementType): New method which does the right
15984 thing when compiling corlib.
15986 * everywhere: Make use of the above in the relevant places.
15988 2003-07-22 Martin Baulig <martin@ximian.com>
15990 * cs-parser.jay (invocation_expression): Moved
15991 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
15992 `cast_expression', but create a InvocationOrCast which later
15993 resolves to either an Invocation or a Cast.
15995 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
15996 method; call this before EmitStatement() to make sure that this
15997 expression can be used as a statement.
15999 * expression.cs (InvocationOrCast): New class; resolves to either
16000 an Invocation or a Cast.
16002 * statement.cs (StatementExpression): Call ResolveStatement() on
16003 the ExpressionStatement before emitting it.
16005 2003-07-21 Martin Baulig <martin@ximian.com>
16007 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
16008 `ref' and `out' attributes match; fixes #46220.
16009 (MemberAccess.ResolveMemberAccess): You can't reference a type
16010 through an expression; fixes #33180.
16011 (Indexers.GetIndexersForType): Don't return the indexers from
16012 interfaces the class implements; fixes #46502.
16014 2003-07-21 Martin Baulig <martin@ximian.com>
16016 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
16017 CS0661 checks; fixes bug #30442.
16019 2003-07-21 Martin Baulig <martin@ximian.com>
16021 * decl.cs (AdditionResult): Added `Error'.
16023 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
16025 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
16026 makes cs0031.cs actually work.
16028 2003-07-20 Martin Baulig <martin@ximian.com>
16030 * namespace.cs: Fixed that bug which caused a crash when compiling
16031 the debugger's GUI.
16033 2003-07-20 Miguel de Icaza <miguel@ximian.com>
16035 * typemanager.cs (LookupTypeReflection): Never expose types which
16036 are NotPublic, NestedPrivate, NestedAssembly, or
16037 NestedFamANDAssem. We used to return these, and later do a check
16038 that would report a meaningful error, but the problem is that we
16039 would not get the real match, if there was a name override.
16041 2003-07-18 Miguel de Icaza <miguel@ximian.com>
16043 * namespace.cs (Namespace, Name): Do not compute the namespace
16044 name dynamically, compute it in the constructor. This reduced
16045 memory usage by 1697 KB.
16047 * driver.cs: Use --pause to pause at the end.
16049 2003-07-17 Peter Williams <peter@newton.cx>
16051 * Makefile: Change the name of the test target so that it doesn't
16052 conflict with the recursive test target.
16054 2003-07-17 Miguel de Icaza <miguel@ximian.com>
16056 * expression.cs (LocalVariableReference.Emit, EmitAssign,
16057 AddressOf): Do not use EmitThis, that was wrong, use the actual
16060 2003-07-15 Miguel de Icaza <miguel@ximian.com>
16062 * class.cs (MethodData.Define): While checking if a method is an
16063 interface implementation, improve the test: If we are not public
16064 (use new test here: use the computed MethodAttributes directly,
16065 instead of the parsed modifier flags) check if the `implementing'
16066 method comes from an interface or not.
16068 * pending.cs (VerifyPendingMethods): Slightly better error
16071 * makefile: add test target that does the mcs bootstrap.
16073 2003-07-16 Ravi Pratap <ravi@ximian.com>
16075 * interface.cs (Define): Do nothing here since there are no
16076 members to populate etc. Move the attribute emission out of here
16077 since this was just totally the wrong place to put it. Attribute
16078 application happens during the 'Emit' phase, not in the 'Define'
16081 (Emit): Add this method and move the attribute emission here
16083 * rootcontext.cs (EmitCode): Call the Emit method on interface
16086 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16088 * expression.cs (OverloadResolve): Report error only if Location
16089 is not 'Null' which means that there was a probe going on.
16091 2003-07-14 Martin Baulig <martin@ximian.com>
16093 * expression.cs (ConditionalLogicalOperator): New public class to
16094 implement user defined conditional logical operators.
16095 This is section 14.11.2 in the spec and bug #40505.
16097 2003-07-14 Martin Baulig <martin@ximian.com>
16099 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
16101 2003-07-14 Martin Baulig <martin@ximian.com>
16103 * codegen.cs (EmitContext.InFixedInitializer): New public field.
16105 * ecore.cs (IVariable.VerifyFixed): New interface method.
16107 * expression.cs (Unary.ResolveOperator): When resolving the `&'
16108 operator, check whether the variable is actually fixed. Fixes bug
16109 #36055. Set a variable definitely assigned when taking its
16110 address as required by the spec.
16112 * statement.cs (LocalInfo.IsFixed): New field.
16113 (LocalInfo.MakePinned): Set `IsFixed' to true.
16115 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16117 * attribute.cs (Attribute.Resolve): While doing a Member lookup
16118 for .ctors, ensure that we only ask for members declared in the
16119 attribute type (BindingFlags.DeclaredOnly).
16123 * expression.cs (Error_WrongNumArguments): Report error 1501
16124 correctly the way CSC does.
16126 2003-07-13 Martin Baulig <martin@ximian.com>
16128 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
16129 lookup on the fully qualified name, to make things like "X.X" work
16130 where "X.X" is a fully qualified type name, but we also have a
16131 namespace "X" in the using list. Fixes #41975.
16133 2003-07-13 Martin Baulig <martin@ximian.com>
16135 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
16136 function. If we're a CompoundAssign, we need to create an embedded
16137 CompoundAssign, not an embedded Assign.
16138 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
16141 2003-07-13 Martin Baulig <martin@ximian.com>
16143 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
16144 work to fix bug #46088.
16146 2003-07-13 Ravi Pratap <ravi@ximian.com>
16148 * class.cs (Operator.Emit): Do not emit attributes here - it is
16149 taken care of by the Method class that we delegate too. This takes
16150 care of bug #45876.
16152 2003-07-10 Martin Baulig <martin@ximian.com>
16154 * expression.cs (TypeOfVoid): New class.
16155 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
16157 2003-07-10 Martin Baulig <martin@ximian.com>
16159 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
16162 2003-07-10 Martin Baulig <martin@ximian.com>
16164 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
16165 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16167 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
16169 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
16171 2003-07-10 Martin Baulig <martin@ximian.com>
16173 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
16174 of decimal. Fixes #42850.
16176 NOTE: I also fixed the created byte blob, but this doesn't work on
16177 the MS runtime and csc never produces any byte blobs for decimal
16180 2003-07-10 Martin Baulig <martin@ximian.com>
16182 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
16183 structs; fixes #32068.
16184 (Block.AddChildVariableNames): Fixed #44302.
16186 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16188 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
16190 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16192 * attribute.cs: And this test is onger needed.
16194 2003-07-08 Martin Baulig <martin@ximian.com>
16196 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
16197 inaccessible types. Fixes #36313.
16199 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
16201 * namespace.cs (NamespaceEntry): Create implicit entries for all
16202 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
16203 implicit entries for N1.N2 and N1.
16205 2003-07-08 Martin Baulig <martin@ximian.com>
16207 Rewrote the handling of namespaces to fix a lot of the issues
16208 wrt. `using' aliases etc.
16210 * namespace.cs (Namespace): Splitted this class into a
16211 per-assembly `Namespace' and a per-file `NamespaceEntry'.
16213 * typemanager.cs (TypeManager.IsNamespace): Removed.
16214 (TypeManager.ComputeNamespaces): Only compute namespaces from
16215 loaded assemblies here, not the namespaces from the assembly we're
16216 currently compiling.
16218 2003-07-08 Martin Baulig <martin@ximian.com>
16220 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
16222 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16224 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
16227 I thought about the memory savings here, but LookupTypeReflection
16228 is used under already very constrained scenarios. Compiling
16229 corlib or mcs only exposes one hit, so it would not really reduce
16230 any memory consumption.
16232 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16234 * typemanager.cs: fixes bug #45889 by only adding public types from
16235 other assemblies to the list of known types.
16237 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16239 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
16240 on the type we resolved.
16242 2003-07-05 Martin Baulig <martin@ximian.com>
16244 * pending.cs (PendingImplementation.ParentImplements): Don't
16245 create the proxy if the parent is abstract.
16247 * class.cs (TypeContainer.DefineIndexers): Process explicit
16248 interface implementations first. Fixes #37714.
16250 2003-07-04 Miguel de Icaza <miguel@ximian.com>
16252 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
16253 defined recursively; but since we modify the input parameters
16254 (left is set to `this' temporarily), we reset this value if the
16255 left_is_explicit is false, which gives the original semantics to
16258 * literal.cs (NullPointer): new class used to represent a null
16259 literal in a pointer context.
16261 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
16262 type is a pointer, use a NullPointer object instead of a
16263 NullLiteral. Closes 43687
16265 (ExplicitConversion): Convert pointer values using
16266 the conv opcode to the proper type.
16268 * ecore.cs (New): change ValueTypeVariable property into a method,
16269 that returns whether the valuetype is suitable for being used.
16271 * expression.cs (Binary.DoNumericPromotions): Only return if we
16272 the int constant was a valid uint, and we can return both left and
16273 right as uints. If not, we continue processing, to trigger the
16274 type conversion. This fixes 39018.
16276 * statement.cs (Block.EmitMeta): During constant resolution, set
16277 the CurrentBlock property on the emitcontext, so that we resolve
16278 constants propertly.
16280 2003-07-02 Martin Baulig <martin@ximian.com>
16282 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
16283 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
16285 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
16286 than emitting it here.
16288 * statement.cs: Fixed some more flow analysis bugs.
16290 2003-07-02 Martin Baulig <martin@ximian.com>
16292 * class.cs (MethodData.Define): When implementing interface
16293 methods, set Final unless we're Virtual.
16295 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
16296 check work for interface methods.
16298 2003-07-01 Martin Baulig <martin@ximian.com>
16300 * ecore.cs (EmitContext.This): Replaced this property with a
16301 GetThis() method which takes a Location argument. This ensures
16302 that we get the correct error location for a CS0188.
16304 2003-07-01 Miguel de Icaza <miguel@ximian.com>
16306 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
16307 ImplicitStandardConversion.
16309 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
16311 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
16313 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
16316 2003-06-30 Miguel de Icaza <miguel@ximian.com>
16318 * class.cs (Constructor.Define): Turn off initlocals for unsafe
16321 (MethodData.Define): Turn off initlocals for unsafe methods.
16323 2003-06-29 Miguel de Icaza <miguel@ximian.com>
16325 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
16326 complete; Fixes #37521.
16328 * delegate.cs: Use Modifiers.TypeAttr to compute the
16329 TypeAttributes, instead of rolling our own. This makes the flags
16330 correct for the delegates.
16332 2003-06-28 Miguel de Icaza <miguel@ximian.com>
16334 * class.cs (Constructor.Define): Set the private flag for static
16335 constructors as well.
16337 * cs-parser.jay (statement_expression): Set the return value to
16338 null, to avoid a crash when we catch an error.
16340 2003-06-24 Miguel de Icaza <miguel@ximian.com>
16342 * cs-parser.jay: Applied patch from Jackson that adds support for
16343 extern and unsafe modifiers to destructor declarations.
16345 * expression.cs: Report error 21 if the user is trying to index a
16348 * driver.cs: Add an error message, suggested by the bug report.
16350 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
16351 if we do not have a ": this ()" constructor initializer. Fixes 45149
16353 2003-06-14 Miguel de Icaza <miguel@ximian.com>
16355 * namespace.cs: Add some information to reduce FAQs.
16357 2003-06-13 Miguel de Icaza <miguel@ximian.com>
16359 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
16360 underlying enumeration types. Fixes #43915.
16362 * expression.cs: Treat ushort/short as legal values to be used in
16363 bitwise operations.
16365 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
16367 * delegate.cs: transfer custom attributes for paramenters from
16368 the delegate declaration to Invoke and BeginInvoke.
16370 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
16372 * attribute.cs: handle custom marshalers and emit marshal info
16375 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
16377 * makefile.gnu: Added anonymous.cs to the compiler sources.
16379 2003-05-28 Miguel de Icaza <miguel@ximian.com>
16381 * iterators.cs: Change the name of the proxy class to include two
16384 * cs-parser.jay: Update grammar to include anonymous methods.
16386 * anonymous.cs: new file.
16388 2003-05-27 Miguel de Icaza <miguel@ximian.com>
16390 * class.cs (Field.Define): Add missing test for pointers and
16393 2003-05-27 Ravi Pratap <ravi@ximian.com>
16395 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
16396 we use the stobj opcode.
16398 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
16399 since it wasn't the correct fix.
16401 It still is puzzling that we are required to use stobj for IntPtr
16402 which seems to be a ValueType.
16404 2003-05-26 Miguel de Icaza <miguel@ximian.com>
16406 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
16407 during regular simple name resolution. Now, the trick is that
16408 instead of returning for processing the simplename, we do a
16409 TypeManager.LookupType (ie, a rooted lookup as opposed to a
16410 contextual lookup type). If a match is found, return that, if
16411 not, return for further composition.
16413 This fixes long-standing 30485.
16415 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16416 using the address to initialize an object, do an Stobj instead of
16417 using the regular Stelem.
16419 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
16420 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
16421 Because if we are a BaseIndexerAccess that value will be true.
16424 * statement.cs (GotoCase.Resolve): Return after reporting an
16425 error, do not attempt to continue.
16427 * expression.cs (PointerArithmetic.Emit): If our operand is a
16428 long, convert our constants to match the operand before
16429 multiplying. Convert to I type before adding. Fixes 43670.
16431 2003-05-14 Ravi Pratap <ravi@ximian.com>
16433 * enum.cs (ImplicitConversionExists) : Rename to
16434 ImplicitEnumConversionExists to remove ambiguity.
16436 * ecore.cs (NullCast): New type of cast expression class which
16437 basically is very similar to EmptyCast with the difference being
16438 it still is a constant since it is used only to cast a null to
16440 (eg. (string) null)
16442 * convert.cs (ImplicitReferenceConversion): When casting a null
16443 literal, we return a NullCast.
16445 * literal.cs (NullLiteralTyped): Remove - I don't see why this
16446 should be around anymore.
16448 The renaming (reported was slightly wrong). Corrections:
16450 ConvertImplicitStandard -> ImplicitConversionStandard
16451 ConvertExplicitStandard -> ExplicitConversionStandard
16453 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
16454 before passing them in !
16456 * convert.cs (ImplicitConversionStandard): When comparing for
16457 equal expr and target types, ensure that expr is not a
16460 In general, we must not be checking (expr_type ==
16461 target_type) in the top level conversion methods
16462 (ImplicitConversion, ExplicitConversion etc). This checking is
16463 done in the methods that they delegate to.
16465 2003-05-20 Miguel de Icaza <miguel@ximian.com>
16467 * convert.cs: Move Error_CannotConvertType,
16468 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
16469 ImplicitNumericConversion, ImplicitConversionExists,
16470 ImplicitUserConversionExists, StandardConversionExists,
16471 FindMostEncompassedType, FindMostSpecificSource,
16472 FindMostSpecificTarget, ImplicitUserConversion,
16473 ExplicitUserConversion, GetConversionOperators,
16474 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
16475 TryImplicitIntConversion, Error_CannotConvertImplicit,
16476 ConvertImplicitRequired, ConvertNumericExplicit,
16477 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
16478 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
16481 Perform the following renames:
16483 StandardConversionExists -> ImplicitStandardConversionExists
16484 ConvertImplicit -> ImplicitConversion
16485 ConvertImplicitStandard -> ImplicitStandardConversion
16486 TryImplicitIntConversion -> ImplicitIntConversion
16487 ConvertImplicitRequired -> ImplicitConversionRequired
16488 ConvertNumericExplicit -> ExplicitNumericConversion
16489 ConvertReferenceExplicit -> ExplicitReferenceConversion
16490 ConvertExplicit -> ExplicitConversion
16491 ConvertExplicitStandard -> ExplicitStandardConversion
16493 2003-05-19 Martin Baulig <martin@ximian.com>
16495 * statement.cs (TypeInfo.StructInfo): Made this type protected.
16496 (TypeInfo): Added support for structs having structs as fields.
16498 * ecore.cs (FieldExpr): Implement IVariable.
16499 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
16500 VariableInfo for the field.
16502 2003-05-18 Martin Baulig <martin@ximian.com>
16504 * expression.cs (This.DoResolve): Report a CS0027 if we're
16505 emitting a field initializer.
16507 2003-05-18 Martin Baulig <martin@ximian.com>
16509 * expression.cs (This.ResolveBase): New public function.
16510 (This.DoResolve): Check for CS0188.
16512 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
16515 * ecore.cs (MethodGroupExpr.DoResolve): Set the
16516 `instance_expression' to null if we don't have any non-static
16519 2003-05-18 Martin Baulig <martin@ximian.com>
16521 Reworked the way how local variables and parameters are handled by
16522 the flow analysis code.
16524 * statement.cs (TypeInfo, VariableMap): New public classes.
16525 (VariableInfo): New public class. This is now responsible for
16526 checking whether a variable has been assigned. It is used for
16527 parameters and local variables.
16528 (Block.EmitMeta): Take the InternalParameters as argument; compute
16529 the layout of the flow vectors here.
16530 (Block.LocalMap, Block.ParameterMap): New public properties.
16531 (FlowBranching): The .ctor doesn't get the InternalParameters
16532 anymore since Block.EmitMeta() now computes the layout of the flow
16534 (MyStructInfo): This class is now known as `StructInfo' and nested
16535 in `TypeInfo'; we don't access this directly anymore.
16537 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
16538 property and removed IsAssigned(), IsFieldAssigned(),
16539 SetAssigned() and SetFieldAssigned(); we now call them on the
16540 VariableInfo so we don't need to duplicate this code everywhere.
16542 * expression.cs (ParameterReference): Added `Block block' argument
16544 (LocalVariableReference, ParameterReference, This): The new
16545 VariableInfo class is now responsible for all the definite
16548 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
16549 IsParameterAssigned, SetParameterAssigned): Removed.
16551 2003-05-18 Martin Baulig <martin@ximian.com>
16553 * typemanager.cs (InitCoreTypes): Try calling
16554 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
16555 the 3-args-version. Corlib now also needs our `void_type'.
16556 (GetMethod): Added overloaded version which takes an optional
16557 `bool report_errors' to allow lookups of optional methods.
16559 2003-05-12 Martin Baulig <martin@ximian.com>
16561 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
16562 only used for locals and not for parameters.
16564 2003-05-12 Miguel de Icaza <miguel@ximian.com>
16566 * support.cs (InternalParameters.ParameterType): Return the
16567 ExternalType of the parameter.
16569 * parameter.cs (Parameter.ExternalType): drop the two arguments,
16572 2003-05-11 Miguel de Icaza <miguel@ximian.com>
16574 * class.cs (MethodData.Define): Do not set the `newslot' on
16575 interface members, if they are also flagged as "override".
16577 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
16578 better code for ++i and i++. This only works for static fields
16579 and local variables.
16581 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
16582 want to pull the DeclSpace out of the builder_to_declspace instead
16583 of the TypeBuilder (like in TypeContainer.FindMembers).
16585 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
16586 instead of LookupTypeContainer. Fixes the crash on .NET for
16587 looking up interface members.
16589 * const.cs: Create our own emit context during the Definition
16590 stage, so that constants are evaluated in the proper context, when
16591 a recursive definition happens.
16593 2003-05-11 Martin Baulig <martin@ximian.com>
16595 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
16596 new block for a switch section.
16597 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
16598 the adding/lookup in the switch block. Fixes #39828.
16600 2003-05-09 Miguel de Icaza <miguel@ximian.com>
16602 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
16603 functionality: I needed to convert the data after I had performed
16604 the add/sub operation into the operands type size.
16606 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
16607 pass the type for the box operation, otherwise the resulting
16608 object would have been of type object.
16610 (BoxedCast): Add constructor to specify the type to box as.
16612 2003-05-07 Miguel de Icaza <miguel@ximian.com>
16614 * iterators.cs: I was reusing the `count' variable inadvertently,
16615 take steps to not allow this to happen.
16617 2003-05-06 Miguel de Icaza <miguel@ximian.com>
16619 * attribute.cs (Attribute.Resolve): Params attributes are encoded
16620 by creating an array at the point where the params starts and
16621 putting all those arguments there, then adjusting the size of the
16624 2003-05-05 Miguel de Icaza <miguel@ximian.com>
16626 * expression.cs (New.AddressOf): Implement interface
16627 IMemoryLocation. This is used when the `new' operator is used in
16628 the context of an invocation to a method on a value type.
16630 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
16633 * namespace.cs: Also check the using aliases here.
16635 * driver.cs: Move the test for using validity after the types have
16636 been entered, so we do a single pass that also includes the using
16639 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
16640 in the regular case. CreateSiblingForFinally is doing extra
16643 * attribute.cs (GetAttributeArgumentExpression): Store the result
16644 on an out value, and use the return value to indicate failure
16645 instead of using null (which is a valid return for Constant.GetValue).
16647 * statement.cs: Perform the analysis flow for the increment
16648 portion after the statement, because this will be the real flow of
16649 execution. Fixes #42385
16651 * codegen.cs (EmitContext.EmitArgument,
16652 EmitContext.EmitStoreArgument): New helper functions when the
16653 RemapToProxy flag is set.
16655 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
16658 Add support for remapping parameters.
16660 * iterators.cs: Propagate parameter values; Store parameter
16661 values in the proxy classes.
16663 2003-05-04 Miguel de Icaza <miguel@ximian.com>
16665 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
16666 need a proxy reference; I do not know what I was thinking
16668 * cs-parser.jay (constructor_initializer): catch another error,
16669 and display nice message.
16671 (field_declaration): catch void field declaration
16672 to flag a better error.
16674 * class.cs (MemberBase.CheckBase): Report an error instead of a
16675 warning if a new protected member is declared in a struct.
16676 (Field.Define): catch the error of readonly/volatile.
16678 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
16680 (FieldExpr.AddressOf): ditto. Catch error where the address of a
16681 volatile variable is taken
16683 2003-05-02 Miguel de Icaza <miguel@ximian.com>
16685 * statement.cs (Fixed.Resolve): Report an error if we are not in
16688 2003-05-01 Miguel de Icaza <miguel@ximian.com>
16690 * typemanager.cs: reuse the code that handles type clashes for
16691 delegates and enumerations.
16693 * class.cs (Report28): Always report.
16695 * expression.cs (EncodeAsAttribute): Allow nulls here.
16697 2003-04-28 Miguel de Icaza <miguel@ximian.com>
16699 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
16700 the functionality for testing whether an expression is valid for
16701 an attribute here. Also handle the case of arrays of elements
16704 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
16705 encoding a linear array into an array of objects that are suitable
16706 to be passed to an CustomAttributeBuilder.
16708 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
16710 * ecore.cs: (FieldExpr): Handle field remapping here.
16712 * iteratators.cs: Pass the instance variable (if the method is an
16713 instance method) to the constructors, so we can access the field
16714 variables on the class.
16716 TODO: Test this with structs. I think the THIS variable on
16717 structs might have to be a pointer, and not a refenrece
16719 2003-04-27 Miguel de Icaza <miguel@ximian.com>
16721 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
16722 local variables to fields in a proxy class.
16724 * iterators.cs (PopulateProxy): Rename our internal fields to
16726 Create a <THIS> field if we are an instance method, so we can
16727 reference our parent container variables.
16728 (MapVariable): Called back from the EmitContext code to enter a
16729 new variable to field mapping into the proxy class (we just create
16733 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
16734 for using the remapped locals to fields.
16736 I placed the code here, because that gives the same semantics to
16737 local variables, and only changes the Emit code.
16739 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
16740 statements inside iterators.
16741 (VariableInfo): Add a FieldBuilder for the cases when we are
16742 remapping local variables to fields in a proxy class
16744 * ecore.cs (SimpleNameResolve): Avoid testing two times for
16745 current_block != null.
16747 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
16748 not cope with strings, as it has been moved to the
16749 TableSwitchEmit. Fixed bug in switch generation.
16751 * expression.cs (New.DoResolve): Provide more context for the user
16752 when reporting an error.
16754 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
16757 * expression.cs (MemberAccess.DoResolve): When we get a type back,
16758 check the permissions for it. Note than in a type-resolution
16759 context the check was already present in DeclSpace.ResolveType,
16760 but was missing from the MemberAccess.
16762 (ArrayCreation.CheckIndices): warn if the user has
16763 more nested levels of expressions, but there are no more
16764 dimensions specified. Avoids crash on bug 41906.
16766 2003-04-26 Miguel de Icaza <miguel@ximian.com>
16768 * statement.cs (Block): replace Implicit bool, for a generic
16770 New flag: `Unchecked'. This is used during the EmitMeta phase
16771 (which is out-of-line with the regular Resolve/Emit process for a
16772 statement, as this is done ahead of time, but still gets a chance
16773 to call constant resolve).
16775 (Block.Flags): new enum for adding a new flag.
16777 (Block.EmitMeta): track the state of unchecked.
16779 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
16780 to enable constant resolution to work there as well.
16782 2003-04-22 Miguel de Icaza <miguel@ximian.com>
16784 * typemanager.cs (ienumerable_type): Also look up
16785 System.Collections.IEnumerable.
16787 2003-04-21 Miguel de Icaza <miguel@ximian.com>
16789 TODO: Test more than one conditional per method.
16791 * class.cs (Indexer.Define): Report the location where the user is
16792 referencing the unsupported feature.
16794 (MethodData): Overload the use of `conditionals' to
16795 minimize the creation of needless ArrayLists. This saves roughly
16796 212kb on my machine.
16798 (Method): Implement the new IIteratorContainer interface.
16799 (Method.SetYields): Implement the method by setting the ModFlags
16800 to contain METHOD_YIELDS.
16802 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
16803 which just got set to null.
16805 * iterators.cs: New file.
16807 (Yield, YieldBreak): New statements.
16809 * statement.cs (Return.Resolve): Flag an error if we are used in
16810 an iterator method.
16812 * codegen.cs (InIterator): New flag set if the code is being
16813 compiled in an iterator method.
16815 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
16816 internal modifier, and we just use it to avoid adding extra
16817 fields, as this is seldom used.
16819 * cs-parser.jay: Add yield_statement (yield and yield break).
16821 * driver.cs: New flag -v2 to turn on version 2 features.
16823 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
16824 hashtable when v2 is enabled.
16826 2003-04-20 Miguel de Icaza <miguel@ximian.com>
16828 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
16829 there is already a namespace defined with this name.
16831 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
16832 people upgraded their corlibs.
16834 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
16835 always use fully qualified types, no need to use the compiler
16838 (TypeManager.IsNamespace): Use binarysearch.
16840 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
16841 AddDelegate): I did not quite use the new IsValid API properly: I
16842 have to pass the short-name and the fullname. I was passing only
16843 the basename instead of the fullname sometimes.
16845 (TypeContainer.DefineType): call NamespaceClash.
16847 * interface.cs (Interface.DefineType): use NamespaceClash before
16850 * delegate.cs (Delegate.DefineType): use NamespaceClash before
16853 * enum.cs: (Enum.DefineType): use NamespaceClash before
16856 * typemanager.cs (: 3-line patch that gives us some tasty 11%
16857 speed increase. First, use the negative_hits cache when we get a
16858 negative. Second, add the type with its full original name
16859 instead of the new . and + encoded name (reflection uses + to
16860 separate type from a nested type). Use LookupTypeReflection
16861 directly which bypasses the type->name hashtable (that we already
16862 know does not contain the type.
16864 * decl.cs (DeclSpace.ResolveTypeExpr): track the
16865 location/container type.
16867 * driver.cs: When passing utf8, use directly the UTF8Encoding.
16869 2003-04-19 Miguel de Icaza <miguel@ximian.com>
16871 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
16873 * delegate.cs (NewDelegate.Resolve): Test whether an instance
16874 method is being referenced in the method group from a static
16875 context, and report error 120 if so.
16877 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
16880 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
16881 is created, we create the A namespace).
16883 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16886 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16888 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16889 invocation to ModuleBuilder.GetType with the same values will
16890 return a new type instance, so we need to cache its return
16893 * expression.cs (Binary.ResolveOperator): Only allow the compare
16894 operators on enums if they are of the same type.
16896 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16897 types of ValueType on their own case. Before we were giving them
16898 the same treatment as objects.
16900 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16901 fullname. Short name is used to compare against container name.
16902 Fullname is used to check against defined namespace names.
16904 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16905 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16907 (Method.CheckBase): Call parent.
16908 (MemberBase.CheckBase): Check for protected members on sealed
16910 (PropertyBase.CheckBase): Call parent.
16911 (Field.Define): Call parent.
16913 * report.cs: Negative error codes are now mapped to 8000 - code,
16914 so that the display is render more nicely.
16916 * typemanager.cs: Do not use try/catch, instead report a regular
16919 (GetPointerType, GetReferenceType): These methods provide
16920 mechanisms to obtain the T* and T& from a T. We had the code
16921 previously scattered around the code base, and it also used
16922 TypeManager.LookupType that would go through plenty of caches.
16923 This one goes directly to the type source.
16925 In some places we did the Type.GetType followed by
16926 ModuleBuilder.GetType, but not in others, so this unifies the
16927 processing as well.
16929 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16930 statements now that we have namespace information.
16932 * typemanager.cs (IsNamespace): New method, returns whether the
16933 string presented is a namespace or not.
16935 (ComputeNamespaces): New public entry point, computes the list of
16936 available namespaces, using the GetNamespaces API call in Mono, or
16937 the slower version in MS.NET.
16939 Now before we start the semantic analysis phase, we have a
16940 complete list of namespaces including everything that the user has
16943 Deleted old code to cache namespaces in .nsc files.
16945 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16947 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16948 class/struct location definition Location for the implicit
16949 constructor location.
16951 (Operator.Define): Use the location of the operator for the
16952 implicit Method definition.
16954 (Constructor.Emit): use the constructor location for the implicit
16955 base initializer constructor.
16957 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16958 and the Expression class now contains two new methods:
16960 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16961 isolate type lookup from the rest of the resolution process.
16963 Since we use Expressions to hold type definitions due to the way
16964 we parse the input we have historically overloaded Resolve to
16965 perform the Type lookups if a special flag is passed. Now this is
16966 eliminated and two methods take their place.
16968 The differences in the two methods between xStep and xTerminal is
16969 that xStep is involved in our current lookup system that uses
16970 SimpleNames to compose a name, while xTerminal is used just to
16971 catch the case where the simplename lookup failed.
16973 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16975 * expression.cs (ResolveMemberAccess): Remove redundant code.
16976 TypeExpr expressions are always born fully resolved.
16978 * interface.cs (PopulateMethod): Do not lookup the types twice.
16979 We were doing it once during SemanticAnalysis and once during
16982 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16983 in local variable type definitions, were being returned as a
16984 SimpleName (we decomposed everything into a string), that is
16985 because primary_expression was being used instead of a type in the
16986 grammar (reduce/reduce conflicts).
16988 The part that was wrong is that we converted the expression into a
16989 string (an oversimplification in one hand, compounded with primary
16990 expressions doing string concatenation).
16996 Would return "A.B.C[]" as a SimpleName. This stopped things like
16997 using clauses from working on this particular context. And a type
16998 was being matched directly against "A.B.C[]".
17000 We now use the correct approach, and allow for ComposedCast to be
17001 part of the unary expression. So the "A.B.C []" become a composed
17002 cast of "A.B.C" (as a nested group of MemberAccess with a
17003 SimpleName at the end) plus the rank composition "[]".
17007 2003-04-10 Miguel de Icaza <miguel@ximian.com>
17009 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
17010 for the access level checking.
17012 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
17013 `TypeContainer container', because I kept getting confused when I
17014 was debugging this code.
17016 * expression.cs (Indexers): Instead of tracking getters/setters,
17017 we now track them in parallel. We create one arraylist less, but
17018 most importantly it is possible now for the LValue code to find a
17019 matching get for a set.
17021 (IndexerAccess.DoResolveLValue): Update the code.
17022 GetIndexersForType has been modified already to extract all the
17023 indexers from a type. The code assumed it did not.
17025 Also make the code set the correct return type for the indexer.
17026 This was fixed a long time ago for properties, but was missing for
17027 indexers. It used to be void_type.
17029 (Binary.Emit): Test first for doubles instead of
17030 floats, as they are more common.
17032 (Binary.EmitBranchable): Use the .un version of the branch opcodes
17033 when dealing with floats and the <=, >= operators. This fixes bug
17036 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
17037 to load the array value by emitting a load on the foreach variable
17038 type. This was incorrect.
17040 We now emit the code to load an element using the the array
17041 variable type, and then we emit the conversion operator.
17045 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
17047 * attribute.cs: Avoid allocation of ArrayLists in the common case.
17049 2003-04-09 Miguel de Icaza <miguel@ximian.com>
17051 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
17052 test for protection before we test for signatures.
17054 (MethodSignature.ToString): implement.
17056 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
17057 to the case where we reduced into a LongConstant.
17059 * decl.cs (CheckAccessLevel): If the type is an array, we can not
17060 depend on whether the information is acurrate, because the
17061 Microsoft runtime will always claim that the array type is public,
17062 regardless of the real state.
17064 If the type is a pointer, another problem happens: the type is
17065 reported as non-public in Microsoft.
17067 In both cases we have to call CheckAccessLevel recursively with
17068 the underlying type as the argument to be tested.
17070 2003-04-08 Miguel de Icaza <miguel@ximian.com>
17072 * assign.cs (Assign.Emit): If we are dealing with a compound
17073 assignment expression, we should use the code path that stores the
17074 intermediate result in a temporary value. This fixes #40903.
17076 *expression.cs (Indirection.ToString): Provide ToString method for
17079 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
17081 * class.cs: Null out fields holding references to Block objects so
17082 they can be garbage collected.
17084 * expression.cs (OverloadResolve): Remove unused local.
17086 2003-04-07 Martin Baulig <martin@ximian.com>
17088 * codegen.cs (EmitContext.CurrentFile): New public field.
17089 (EmitContext.Mark): Use the CurrentFile to check whether the
17090 location is in the correct file.
17091 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
17093 2003-04-07 Martin Baulig <martin@ximian.com>
17095 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
17097 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
17098 location. [FIXME: The location argument which gets passed to this
17099 method is sometimes wrong!]
17101 2003-04-07 Nick Drochak <ndrochak@gol.com>
17103 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
17105 2003-04-07 Miguel de Icaza <miguel@ximian.com>
17107 * expression.cs (Indirection.EmitAssign): We were using the
17108 temporary, but returning immediately instead of continuing the
17111 2003-04-06 Martin Baulig <martin@ximian.com>
17113 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
17114 if it's a nested child, but also deriving from the outer class.
17117 * typemanager.cs (IsNestedChildOf): Make this work if it's a
17118 nested child, but also deriving from the outer class. See
17120 (FilterWithClosure): We may access private members of the outer
17121 class if we're a nested child and deriving from the outer class.
17122 (RealMemberLookup): Only set `closure_private_ok' if the
17123 `original_bf' contained BindingFlags.NonPublic.
17125 2003-04-05 Martin Baulig <martin@ximian.com>
17127 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
17129 2003-04-02 Miguel de Icaza <miguel@ximian.com>
17131 * class.cs (Event.Define): Do not allow abstract events to have
17134 2003-04-01 Miguel de Icaza <miguel@ximian.com>
17136 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
17137 block in event declarations.
17139 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
17140 value type, get its address.
17142 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
17143 leaving a class on the stack instead of a boolean value (int
17144 0/1). Change the code so we compare against null, and then the
17145 result against zero.
17147 * class.cs (TypeContainer.GetClassBases): We were checking for the
17148 parent class being sealed too late.
17150 * expression.cs (Binary.Emit): For <= and >= when dealing with
17151 floating point values, use cgt.un and clt.un instead of cgt and
17154 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
17156 * statement.cs: Apply the same optimization as MS: skip the
17157 GetEnumerator returning an IEnumerator, and use the one returning a
17158 CharEnumerator instead. This allows us to avoid the try-finally block
17161 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
17163 * cs-parser.jay: Attributes cannot be applied to
17164 namespaces. Fixes #40473
17166 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17169 (Add*): check if the name is valid using the full name for constants,
17170 fields, properties and events.
17172 2003-03-28 Miguel de Icaza <miguel@ximian.com>
17174 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
17175 char constants to be part of the enumeration.
17177 * expression.cs (Conditional.DoResolve): Add support for operator
17178 true. Implements the missing functionality from 14.12
17180 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
17181 operator true/false as required by the spec.
17183 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
17184 implicit conversion to boolean.
17186 * statement.cs (Statement.ResolveBoolean): A boolean expression is
17187 also one where the type implements `operator true'.
17189 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
17190 get an expression that will invoke operator true based on an
17193 (GetConversionOperators): Removed the hack that called op_True
17196 (Expression.ResolveBoolean): Move this from Statement.
17198 2003-03-17 Miguel de Icaza <miguel@ximian.com>
17200 * ecore.cs (FieldExpr): do not allow initialization of initonly
17201 fields on derived classes
17203 2003-03-13 Martin Baulig <martin@ximian.com>
17205 * statement.cs (Block.Emit): Call ig.BeginScope() and
17206 ig.EndScope() when compiling with debugging info; call
17207 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
17209 2003-03-08 Miguel de Icaza <miguel@ximian.com>
17211 * expression.cs (Indexers): Do not construct immediately, allow
17212 for new members to be appended as we go. Fixes 38143
17214 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17216 * expression.cs: save/restore context when resolving an unchecked
17219 2003-03-05 Miguel de Icaza <miguel@ximian.com>
17221 * cfold.cs: Catch division by zero in modulus operator during
17224 2003-03-03 Miguel de Icaza <miguel@ximian.com>
17226 * interface.cs (Interface.DefineMembers): Avoid defining members
17229 2003-02-27 Miguel de Icaza <miguel@ximian.com>
17231 * driver.cs: handle the +/- options for -noconfig
17233 * statement.cs (Unckeched.Resolve): Also track the state of
17234 unchecked in the Resolve phase.
17236 2003-02-27 Martin Baulig <martin@ximian.com>
17238 * ecore.cs (Expression.MemberLookup): Don't create a
17239 MethodGroupExpr for something which is not a method. Fixes #38291.
17241 2003-02-25 Miguel de Icaza <miguel@ximian.com>
17243 * class.cs (MemberBase.CheckParameters): Also check that the type
17244 is unmanaged if it is a pointer.
17246 * expression.cs (SizeOf.Resolve): Add location information.
17248 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
17249 a managed type is declared.
17251 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
17252 parameter modifiers as well. Fixes bug 38606
17254 * class.cs: Very sad. Am backing out the speed up changes
17255 introduced by the ArrayList -> Array in the TypeContainer, as they
17256 were not actually that much faster, and introduced a bug (no error
17257 reports on duplicated methods).
17259 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
17260 source first, this will guarantee that we have a valid expression
17261 before calling in lower levels functions that will require a
17262 resolved object. Then use this original_source in the
17263 target.ResolveLValue instead of the original source that was
17266 Another change. Use target.Resolve instead of LValueResolve.
17267 Although we are resolving for LValues, we will let the Assign code
17268 take care of that (it will be called again from Resolve). This
17269 basically allows code like this:
17271 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
17272 class Y { void A (X x) { x [0] += o; }
17274 The problem was that the indexer was trying to resolve for
17275 set_Item (idx, object o) and never finding one. The real set_Item
17276 was set_Item (idx, X). By delaying the process we get the right
17281 2003-02-23 Martin Baulig <martin@ximian.com>
17283 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
17284 while calling DoEmit ().
17286 * codegen.cs (EmitContext.Mark): Don't mark locations in other
17287 source files; if you use the #line directive inside a method, the
17288 compiler stops emitting line numbers for the debugger until it
17289 reaches the end of the method or another #line directive which
17290 restores the original file.
17292 2003-02-23 Martin Baulig <martin@ximian.com>
17294 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
17296 2003-02-23 Martin Baulig <martin@ximian.com>
17298 * statement.cs (Block.AddChildVariableNames): We need to call this
17299 recursively, not just for our immediate children.
17301 2003-02-23 Martin Baulig <martin@ximian.com>
17303 * class.cs (Event.Define): Always make the field private, like csc does.
17305 * typemanager.cs (TypeManager.RealMemberLookup): Make events
17306 actually work, fixes bug #37521.
17308 2003-02-23 Miguel de Icaza <miguel@ximian.com>
17310 * delegate.cs: When creating the various temporary "Parameters"
17311 classes, make sure that we call the ComputeAndDefineParameterTypes
17312 on those new parameters (just like we do with the formal ones), to
17313 allow them to be resolved in the context of the DeclSpace.
17315 This fixes the bug that Dick observed in Bugzilla #38530.
17317 2003-02-22 Miguel de Icaza <miguel@ximian.com>
17319 * expression.cs (ResolveMemberAccess): When resolving a constant,
17320 do not attempt to pull a constant if the value was not able to
17321 generate a valid constant.
17323 * const.cs (LookupConstantValue): Do not report more errors than required.
17325 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17327 * expression.cs: fixes bug #38328.
17329 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17331 * class.cs: Changed all the various members that can be part of a
17332 class from being an ArrayList to be an Array of the right type.
17333 During the DefineType type_list, interface_list, delegate_list and
17334 enum_list are turned into types, interfaces, delegates and enums
17337 And during the member population, indexer_list, event_list,
17338 constant_list, field_list, instance_constructor_list, method_list,
17339 operator_list and property_list are turned into their real arrays.
17341 Although we could probably perform this operation earlier, for
17342 good error reporting we need to keep the lists and remove the
17343 lists for longer than required.
17345 This optimization was triggered by Paolo profiling the compiler
17346 speed on the output of `gen-sample-program.pl' perl script.
17348 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
17349 not crash in methods like MemberLookupFailed that use this field.
17351 This problem arises when the compiler fails to resolve a type
17352 during interface type definition for example.
17354 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17356 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
17357 inherit from System.Object, so we have to stop at null, not only
17358 when reaching System.Object.
17360 2003-02-17 Miguel de Icaza <miguel@ximian.com>
17362 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
17363 DeclaredOnly because the parent indexer might have had a different
17364 name, but did not loop until the top of the hierarchy was reached.
17366 The problem this one fixes is 35492: when a class implemented an
17367 indexer from an interface, we were getting the interface method
17368 (which was abstract) and we were flagging an error (can not invoke
17371 This also keeps bug 33089 functioning, and test-148 functioning.
17373 * typemanager.cs (IsSpecialMethod): The correct way of figuring
17374 out if a method is special is to see if it is declared in a
17375 property or event, or whether it is one of the predefined operator
17376 names. This should fix correctly #36804.
17378 2003-02-15 Miguel de Icaza <miguel@ximian.com>
17380 The goal here is to remove the dependency on EmptyCast.Peel ().
17381 Killing it completely.
17383 The problem is that currently in a number of places where
17384 constants are expected, we have to "probe" for an EmptyCast, and
17385 Peel, which is not the correct thing to do, as this will be
17386 repetitive and will likely lead to errors.
17388 The idea is to remove any EmptyCasts that are used in casts that
17389 can be reduced to constants, so we only have to cope with
17392 This bug hunt was triggered by Bug 37363 and the desire to remove
17393 the duplicate pattern where we were "peeling" emptycasts to check
17394 whether they were constants. Now constants will always be
17397 * ecore.cs: Use an enumconstant here instead of wrapping with
17400 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
17401 throwing me off. By handling this we can get rid of a few hacks.
17403 * statement.cs (Switch): Removed Peel() code.
17405 2003-02-14 Miguel de Icaza <miguel@ximian.com>
17407 * class.cs: Location information for error 508
17409 * expression.cs (New.DoResolve): Add a guard against double
17410 resolution of an expression.
17412 The New DoResolve might be called twice when initializing field
17413 expressions (see EmitFieldInitializers, the call to
17414 GetInitializerExpression will perform a resolve on the expression,
17415 and later the assign will trigger another resolution
17417 This leads to bugs (#37014)
17419 * delegate.cs: The signature for EndInvoke should contain any ref
17420 or out parameters as well. We were not doing this in the past.
17422 * class.cs (Field.Define): Do not overwrite the type definition
17423 inside the `volatile' group. Turns out that volatile enumerations
17424 were changing the type here to perform a validity test, which
17427 2003-02-12 Miguel de Icaza <miguel@ximian.com>
17429 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
17430 and structs, we do not want to load the instance variable
17432 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
17433 enum_type has to be handled like an object reference (implicit
17434 conversions exists from this to object), but the regular IsClass
17435 and IsValueType tests will never return true for this one.
17437 Also we use TypeManager.IsValueType instead of type.IsValueType,
17438 just for consistency with the rest of the code (this is only
17439 needed if we ever use the construct exposed by test-180.cs inside
17440 corlib, which we dont today).
17442 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
17444 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
17447 2003-02-09 Martin Baulig <martin@ximian.com>
17449 * namespace.cs (Namespace..ctor): Added SourceFile argument.
17450 (Namespace.DefineNamespaces): New static public method; this is
17451 called when we're compiling with debugging to add all namespaces
17452 to the symbol file.
17454 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
17455 pass it to the Namespace's .ctor.
17457 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
17458 and MethodBase arguments; pass the namespace ID to the symwriter;
17459 pass the MethodBase instead of the token to the symwriter.
17460 (SymbolWriter.DefineNamespace): New method to add a namespace to
17463 2003-02-09 Martin Baulig <martin@ximian.com>
17465 * symbolwriter.cs: New file. This is a wrapper around
17466 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
17467 methods here in near future.
17469 2003-02-09 Martin Baulig <martin@ximian.com>
17471 * codegen.cs (EmitContext.Mark): Just pass the arguments to
17472 ILGenerator.MarkSequencePoint() which are actually used by the
17475 2003-02-09 Martin Baulig <martin@ximian.com>
17477 * location.cs (SourceFile): New public sealed class. This
17478 contains the name and an index which is used in the location's token.
17479 (Location): Reserve an appropriate number of bits in the token for
17480 the source file instead of walking over that list, this gives us a
17481 really huge performance improvement when compiling with debugging.
17483 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
17484 `SourceFile' argument instead of a string.
17485 (Driver.ProcessFile): Add all the files via Location.AddFile(),
17486 but don't parse/tokenize here, we need to generate the list of all
17487 source files before we do that.
17488 (Driver.ProcessFiles): New static function. Parses/tokenizes all
17491 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
17492 instead of a string.
17494 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
17497 2003-02-09 Martin Baulig <martin@ximian.com>
17499 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
17500 filename on `#line default'.
17502 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
17504 * statement.cs: don't clear the pinned var when the fixed statement
17505 returns from the method (fixes bug#37752).
17507 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
17509 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
17512 2003-02-07 Martin Baulig <martin@ximian.com>
17514 * driver.cs: Removed the `--debug-args' command line argument.
17516 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
17517 automatically by the AsssemblyBuilder.
17518 (CodeGen.InitializeSymbolWriter): We don't need to call any
17519 initialization function on the symbol writer anymore. This method
17520 doesn't take any arguments.
17522 2003-02-03 Miguel de Icaza <miguel@ximian.com>
17524 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
17525 from referenced assemblies as well.
17527 2003-02-02 Martin Baulig <martin@ximian.com>
17529 * class.cs (MethodData.Emit): Generate debugging info for external methods.
17531 2003-02-02 Martin Baulig <martin@ximian.com>
17533 * class.cs (Constructor.Emit): Open the symbol writer before
17534 emitting the constructor initializer.
17535 (ConstructorInitializer.Emit): Call ec.Mark() to allow
17536 single-stepping through constructor initializers.
17538 2003-01-30 Miguel de Icaza <miguel@ximian.com>
17540 * class.cs: Handle error 549: do not allow virtual methods in
17543 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
17545 * decl.cs: Check access levels when resolving types
17547 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
17549 * statement.cs: Add parameters and locals set in catch blocks that might
17550 return to set vector
17552 2003-01-29 Miguel de Icaza <miguel@ximian.com>
17554 * class.cs (Operator): Set the SpecialName flags for operators.
17556 * expression.cs (Invocation.DoResolve): Only block calls to
17557 accessors and operators on SpecialName methods.
17559 (Cast.TryReduce): Handle conversions from char constants.
17562 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
17564 * statement.cs: small memory and time optimization in FlowBranching.
17566 2003-01-28 Pedro Mart <yoros@wanadoo.es>
17568 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
17569 problem that the last fix but in the other sid (Set).
17571 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
17572 access when there is no indexer in the hierarchy.
17574 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
17576 * class.cs: Combine some if statements.
17578 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17580 * driver.cs: fixed bug #37187.
17582 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
17584 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
17585 any indexer, it's needed to build a list with all the indexers in the
17586 hierarchy (AllGetters), else we have problems. Fixes #35653.
17588 2003-01-23 Miguel de Icaza <miguel@ximian.com>
17590 * class.cs (MethodData.Define): It is wrong for an interface
17591 implementation to be static in both cases: explicit and implicit.
17592 We were only handling this in one case.
17594 Improve the if situation there to not have negations.
17596 * class.cs (Field.Define): Turns out that we do not need to check
17597 the unsafe bit on field definition, only on usage. Remove the test.
17599 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17601 * driver.cs: use assembly.Location instead of Codebase (the latest
17602 patch made mcs fail when using MS assemblies).
17604 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
17606 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
17607 get the path to *corlib.dll.
17609 2003-01-21 Nick Drochak <ndrochak@gol.com>
17613 * typemanager.cs: Remove compiler warnings
17615 2003-01-20 Duncan Mak <duncan@ximian.com>
17617 * AssemblyInfo.cs: Bump the version number to 0.19.
17619 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17621 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
17623 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
17625 * class.cs (Constructor::Emit): Emit debugging info for constructors.
17627 2003-01-17 Miguel de Icaza <miguel@ximian.com>
17629 * cs-parser.jay: Small fix: we were not comparing the constructor
17630 name correctly. Thanks to Zoltan for the initial pointer.
17632 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
17634 * cs-tokenizer.cs: Set file name when specified with #line
17636 2003-01-15 Miguel de Icaza <miguel@ximian.com>
17638 * cs-parser.jay: Only perform the constructor checks here if we
17639 are named like the class; This will help provider a better
17640 error. The constructor path is taken when a type definition is
17641 not found, but most likely the user forgot to add the type, so
17642 report that rather than the constructor error.
17644 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
17646 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
17649 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17651 * cs-parser.jay: Add cleanup call.
17653 2003-01-13 Duncan Mak <duncan@ximian.com>
17655 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
17656 consistent with other methods.
17658 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17660 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
17662 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
17664 * attribute.cs: only set GuidAttr to true when we have a
17667 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17671 * typemanager.cs: fixes to allow mcs compile corlib with the new
17672 Type.IsSubclassOf fix.
17674 2003-01-08 Miguel de Icaza <miguel@ximian.com>
17676 * expression.cs (LocalVariableReference.DoResolve): Classify a
17677 constant as a value, not as a variable. Also, set the type for
17680 * cs-parser.jay (fixed_statement): take a type instead of a
17681 pointer_type, so we can produce a better error message later.
17683 * statement.cs (Fixed.Resolve): Flag types that are not pointers
17686 (For.DoEmit): Make inifinite loops have a
17687 non-conditional branch back.
17689 (Fixed.DoEmit): First populate the pinned variables, then emit the
17690 statement, then clear the variables. Before I was emitting the
17691 code once for each fixed piece.
17694 2003-01-08 Martin Baulig <martin@ximian.com>
17696 * statement.cs (FlowBranching.MergeChild): A break in a
17697 SWITCH_SECTION does not leave a loop. Fixes #36155.
17699 2003-01-08 Martin Baulig <martin@ximian.com>
17701 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
17702 lives in the same number space than `param_map'. Fixes #36154.
17704 2003-01-07 Miguel de Icaza <miguel@ximian.com>
17706 * cs-parser.jay (constructor_declaration): Set the
17707 Constructor.ModFlags before probing for it. This makes the
17708 compiler report 514, 515 and 132 (the code was there, but got
17711 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
17712 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
17713 (GotoCase.Resolve): Set `Returns' to ALWAYS.
17715 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
17717 * enum.cs: create the enum static fields using the enum type.
17719 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
17721 * class.cs: don't try to create the ParamBuilder for the return
17722 type if it's not needed (and handle it breaking for the ms runtime
17725 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
17727 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
17729 2002-12-29 Miguel de Icaza <miguel@ximian.com>
17731 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
17732 the command. This showed up while compiling the JANET source
17733 code, which used \r as its only newline separator.
17735 2002-12-28 Miguel de Icaza <miguel@ximian.com>
17737 * class.cs (Method.Define): If we are an operator (because it
17738 reuses our code), then set the SpecialName and HideBySig. #36128
17740 2002-12-22 Miguel de Icaza <miguel@ximian.com>
17742 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
17743 exception, report error 120 `object reference required'.
17745 * driver.cs: Add --pause option, used during to measure the size
17746 of the process as it goes with --timestamp.
17748 * expression.cs (Invocation.DoResolve): Do not allow methods with
17749 SpecialName to be invoked.
17751 2002-12-21 Miguel de Icaza <miguel@ximian.com>
17753 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
17754 number before adding it.
17756 2002-12-21 Ravi Pratap <ravi@ximian.com>
17758 * ecore.cs (StandardImplicitConversion): When in an unsafe
17759 context, we allow conversion between void * to any other pointer
17760 type. This fixes bug #35973.
17762 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
17764 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
17765 is not thrown when extensionless outputs are used
17767 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17769 * rootcontext.cs: fixed compilation of corlib.
17771 2002-12-19 Miguel de Icaza <miguel@ximian.com>
17773 * attribute.cs (Attributes.Contains): Add new method.
17775 * class.cs (MethodCore.LabelParameters): if the parameter is an
17776 `out' parameter, check that no attribute `[In]' has been passed.
17778 * enum.cs: Handle the `value__' name in an enumeration.
17780 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
17782 * decl.cs: Added special case to allow overrides on "protected
17785 2002-12-18 Ravi Pratap <ravi@ximian.com>
17787 * attribute.cs (Attributes.AddAttributeSection): Rename to this
17788 since it makes much more sense.
17790 (Attributes.ctor): Don't require a Location parameter.
17792 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
17794 * attribute.cs (ApplyAttributes): Remove extra Location parameters
17795 since we already have that information per attribute.
17797 * everywhere : make appropriate changes.
17799 * class.cs (LabelParameters): Write the code which actually
17800 applies attributes to the return type. We can't do this on the MS
17801 .NET runtime so we flag a warning in the case an exception is
17804 2002-12-18 Miguel de Icaza <miguel@ximian.com>
17806 * const.cs: Handle implicit null conversions here too.
17808 2002-12-17 Ravi Pratap <ravi@ximian.com>
17810 * class.cs (MethodCore.LabelParameters): Remove the extra
17811 Type [] parameter since it is completely unnecessary. Instead
17812 pass in the method's attributes so that we can extract
17813 the "return" attribute.
17815 2002-12-17 Miguel de Icaza <miguel@ximian.com>
17817 * cs-parser.jay (parse): Use Report.Error to flag errors instead
17818 of ignoring it and letting the compile continue.
17820 * typemanager.cs (ChangeType): use an extra argument to return an
17821 error condition instead of throwing an exception.
17823 2002-12-15 Miguel de Icaza <miguel@ximian.com>
17825 * expression.cs (Unary.TryReduce): mimic the code for the regular
17826 code path. Perform an implicit cast in the cases where we can
17827 implicitly convert to one of the integral types, and then reduce
17828 based on that constant. This fixes bug #35483.
17830 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17832 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
17834 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17836 * namespace.cs: fixed bug #35489.
17838 2002-12-12 Miguel de Icaza <miguel@ximian.com>
17840 * class.cs: Remove some dead code.
17842 * cs-parser.jay: Estimate the number of methods needed
17843 (RootContext.MethodCount);
17845 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
17846 numbers instead of StringBuilders.
17848 * support.cs (PtrHashtable): Add constructor with initial size;
17849 We can now reduce reallocations of the method table.
17851 2002-12-10 Ravi Pratap <ravi@ximian.com>
17853 * attribute.cs (ApplyAttributes): Keep track of the emitted
17854 attributes on a per-target basis. This fixes bug #35413.
17856 2002-12-10 Miguel de Icaza <miguel@ximian.com>
17858 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
17859 default to the Windows 1252 encoding.
17861 (UnixParseOption): Support version, thanks to Alp for the missing
17864 * AssemblyInfo.cs: Add nice assembly information.
17866 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17869 * cs-parser.jay: Allow a trailing comma before the close bracked
17870 in the attribute_section production.
17872 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17873 address of the instance was being taken, I will take this out,
17874 because we take the address of the object immediately here.
17876 2002-12-09 Ravi Pratap <ravi@ximian.com>
17878 * typemanager.cs (AreMultipleAllowed): Take care of the most
17879 obvious case where attribute type is not in the current assembly -
17882 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17884 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17885 definitions, instead of doing that afterwards.
17887 Also we use a nice little hack, depending on the constructor, we
17888 know if we are a "composed" name or a simple name. Hence, we
17889 avoid the IndexOf test, and we avoid
17891 * codegen.cs: Add code to assist in a bug reporter to track down
17892 the source of a compiler crash.
17894 2002-12-07 Ravi Pratap <ravi@ximian.com>
17896 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17897 types have been emitted for a given element and flag an error
17898 if something which does not have AllowMultiple set is used more
17901 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17902 attribute types and their corresponding AllowMultiple properties
17904 (AreMultipleAllowed): Check the property for a given type.
17906 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17907 property in the case we have a TypeContainer.
17909 (Attributes.AddAttribute): Detect duplicates and just skip on
17910 adding them. This trivial fix catches a pretty gross error in our
17911 attribute emission - global attributes were being emitted twice!
17913 Bugzilla bug #33187 is now fixed.
17915 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17917 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17918 instead of pp_and).
17920 * expression.cs (Binary.ResolveOperator): I can only use the
17921 Concat (string, string, string) and Concat (string, string,
17922 string, string) if the child is actually a concatenation of
17925 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17927 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17928 context where we need a 2-character lookahead.
17930 * pending.cs (PendingImplementation): Rework so we can keep track
17931 of interface types all the time, and flag those which were
17932 implemented by parents as optional.
17934 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17936 * expression.cs (Binary.ResolveOperator): Use
17937 String.Concat(string,string,string) or
17938 String.Concat(string,string,string,string) when possible.
17940 * typemanager: More helper methods.
17943 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17945 * pending.cs: remove the bogus return from GetMissingInterfaces()
17946 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17948 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17950 * namespace.cs: avoid duplicated 'using xxx' being added to
17951 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17952 when we get more than one 'using' statement for the same namespace.
17953 Report a CS0105 warning for it.
17955 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17957 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17958 of calling getChar/putback, uses internal knowledge of it.
17960 (xtoken): Reorder tokenizer so most common patterns are checked
17961 first. This reduces the compilation time in another 5% (from 8.11s
17962 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17964 The parsing time is 22% of the compilation in mcs, and from that
17965 64% is spent on the tokenization process.
17967 I tried using a binary search for keywords, but this is slower
17968 than the hashtable. Another option would be to do a couple of
17971 * Not use a StringBuilder, instead use an array of chars,
17972 with a set value. Notice that this way we could catch
17973 the 645 error without having to do it *afterwards*.
17975 * We could write a hand-parser to avoid the hashtable
17976 compares altogether.
17978 The identifier consumption process takes 37% of the tokenization
17979 time. Another 15% is spent on is_number. 56% of the time spent
17980 on is_number is spent on Int64.Parse:
17982 * We could probably choose based on the string length to
17983 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17986 Another 3% is spend on wrapping `xtoken' in the `token' function.
17988 Handle 0xa0 as whitespace (#34752)
17990 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17992 * typemanager.cs (IsCLRType): New routine to tell whether a type
17993 is one of the builtin types.
17995 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17996 typecode in more places instead of doing pointer comparissions.
17997 We could leverage some knowledge about the way the typecodes are
18000 New code to cache namespaces in assemblies, it is currently not
18001 invoked, to be used soon.
18003 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
18005 * expression.cs (Binary.ResolveOperator): specially handle
18006 strings, and do not perform user-defined operator overloading for
18009 2002-11-24 Miguel de Icaza <miguel@ximian.com>
18011 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
18012 internalcall as it is a pretty simple operation; Avoid whenever
18013 possible to call Char.IsLetter.
18015 (consume_identifier): Cut by half the number of
18016 hashtable calls by merging the is_keyword and GetKeyword behavior.
18018 Do not short-circuit, because if we do, we
18019 report errors (ie, #if false && true would produce an invalid
18023 2002-11-24 Martin Baulig <martin@ximian.com>
18025 * expression.cs (Cast.TryReduce): If we're in checked syntax,
18026 check constant ranges and report a CS0221. Fixes #33186.
18028 2002-11-24 Martin Baulig <martin@ximian.com>
18030 * cs-parser.jay: Make this work for uninitialized variable
18031 declarations in the `for' initializer. Fixes #32416.
18033 2002-11-24 Martin Baulig <martin@ximian.com>
18035 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
18036 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
18038 2002-11-24 Martin Baulig <martin@ximian.com>
18040 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
18041 argument; if true, we also check for user-defined conversions.
18042 This is only needed if both arguments are of a user-defined type.
18043 Fixes #30443, added test-175.cs.
18044 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
18046 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
18048 2002-11-24 Martin Baulig <martin@ximian.com>
18050 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
18051 function to get the store opcode.
18052 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
18053 only emit the Ldelema if the store opcode is Stobj. You must run
18054 both test-34 and test-167 to test this. Fixes #34529.
18056 2002-11-23 Martin Baulig <martin@ximian.com>
18058 * ecore.cs (Expression.MemberLookup): Added additional
18059 `qualifier_type' argument which is used when we're being called
18060 from MemberAccess.DoResolve() and null if we're called from a
18062 (Expression.MemberLookupFailed): New method to report errors; this
18063 does the CS1540 check and reports the correct error message.
18065 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
18066 argument for the CS1540 check and redone the way how we're dealing
18067 with private members. See the comment in the source code for details.
18068 (FilterWithClosure): Reverted this back to revision 1.197; renamed
18069 `closure_start_type' to `closure_qualifier_type' and check whether
18070 it's not null. It was not this filter being broken, it was just
18071 being called with the wrong arguments.
18073 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
18074 and pass it the correct `qualifier_type'; this also does the error
18077 2002-11-22 Miguel de Icaza <miguel@ximian.com>
18079 * expression.cs (Invocation.EmitParams): If the we are dealing
18080 with a non-built-in value type, load its address as well.
18082 (ArrayCreation): Use a a pretty constant instead
18083 of the hardcoded value 2. Use 6 instead of 2 for the number of
18084 static initializers.
18086 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
18087 because they are not really value types, just glorified integers.
18089 * driver.cs: Do not append .exe, the CSC compiler does not do it.
18091 * ecore.cs: Remove redundant code for enumerations, make them use
18092 the same code path as everything else, fixes the casting issue
18093 with enumerations in Windows.Forms.
18095 * attribute.cs: Do only cast to string if it is a string, the
18096 validation happens later.
18098 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
18099 people upgrade their corlibs.
18101 * ecore.cs: Oops, enumerations were not following the entire code path
18103 2002-11-21 Miguel de Icaza <miguel@ximian.com>
18105 * typemanager.cs (FilterWithClosure): Commented out the test for
18106 1540 in typemanager.cs, as it has problems when accessing
18107 protected methods from a parent class (see test-174.cs).
18109 * attribute.cs (Attribute.ValidateGuid): new method.
18110 (Attribute.Resolve): Use above.
18112 2002-11-19 Miguel de Icaza <miguel@ximian.com>
18114 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
18116 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
18117 handling for enumerations, as we only needed the TypeContainer
18118 functionality to begin with (this is required for the fix below to
18119 work for enums that reference constants in a container class for
18122 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
18124 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
18125 a valid TypeBuilder to perform lookups on.o
18127 * class.cs (InheritableMemberSignatureCompare): Use true in the
18128 call to GetGetMethod and GetSetMethod, because we are comparing
18129 the signature, and we need to get the methods *even* if they are
18132 (PropertyBase.CheckBase): ditto.
18134 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
18135 GotoCase.Resolve): Use Peel on EmpytCasts.
18137 * ecore.cs (EmptyCast): drop child, add Peel method.
18139 2002-11-17 Martin Baulig <martin@ximian.com>
18141 * ecore.cs (EmptyCast.Child): New public property.
18143 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
18144 label resolved to an EmptyCast. Fixes #34162.
18145 (GotoCase.Resolve): Likewise.
18146 (Block.EmitMeta): Likewise.
18148 2002-11-17 Martin Baulig <martin@ximian.com>
18150 * expression.cs (Invocation.BetterConversion): Prefer int over
18151 uint; short over ushort; long over ulong for integer literals.
18152 Use ImplicitConversionExists instead of StandardConversionExists
18153 since we also need to check for user-defined implicit conversions.
18154 Fixes #34165. Added test-173.cs.
18156 2002-11-16 Martin Baulig <martin@ximian.com>
18158 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
18159 with the `true' and `false' literals. Fixes #33151.
18161 2002-11-16 Martin Baulig <martin@ximian.com>
18163 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
18164 October 22nd; don't do the cs1540 check for static members.
18166 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18167 now using our own filter here and doing the cs1540 check again.
18169 2002-11-16 Martin Baulig <martin@ximian.com>
18171 * support.cs (InternalParameters): Don't crash if we don't have
18172 any fixed parameters. Fixes #33532.
18174 2002-11-16 Martin Baulig <martin@ximian.com>
18176 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
18177 when looking up static methods to make this work on Windows.
18180 2002-11-16 Martin Baulig <martin@ximian.com>
18182 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
18183 a setter rather than using PropertyInfo.CanWrite.
18185 2002-11-15 Nick Drochak <ndrochak@gol.com>
18187 * class.cs: Allow acces to block member by subclasses. Fixes build
18190 2002-11-14 Martin Baulig <martin@ximian.com>
18192 * class.cs (Constructor.Emit): Added the extern/block check.
18195 2002-11-14 Martin Baulig <martin@ximian.com>
18197 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
18198 iteration while looking for indexers, this is needed because the
18199 indexer may have a different name in our base classes. Fixed the
18200 error reporting (no indexers at all, not get accessor, no
18201 overloaded match). Fixes bug #33089.
18202 (IndexerAccess.DoResolveLValue): Likewise.
18204 2002-11-14 Martin Baulig <martin@ximian.com>
18206 * class.cs (PropertyBase.CheckBase): Make this work for multiple
18207 indexers. Fixes the first part of bug #33089.
18208 (MethodSignature.InheritableMemberSignatureCompare): Added support
18211 2002-11-13 Ravi Pratap <ravi@ximian.com>
18213 * attribute.cs (Attribute.Resolve): Catch the
18214 NullReferenceException and report it since it isn't supposed to
18217 2002-11-12 Miguel de Icaza <miguel@ximian.com>
18219 * expression.cs (Binary.EmitBranchable): Also handle the cases for
18220 LogicalOr and LogicalAnd that can benefit from recursively
18221 handling EmitBranchable. The code now should be nice for Paolo.
18223 2002-11-08 Miguel de Icaza <miguel@ximian.com>
18225 * typemanager.cs (LookupType): Added a negative-hit hashtable for
18226 the Type lookups, as we perform quite a number of lookups on
18227 non-Types. This can be removed once we can deterministically tell
18228 whether we have a type or a namespace in advance.
18230 But this might require special hacks from our corlib.
18234 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
18235 and double which avoids a conversion from an integer to a double.
18237 * expression.cs: tiny optimization, avoid calling IsConstant,
18238 because it effectively performs the lookup twice.
18240 2002-11-06 Miguel de Icaza <miguel@ximian.com>
18242 But a bogus return here to keep the semantics of the old code
18243 until the Mono runtime is fixed.
18245 * pending.cs (GetMissingInterfaces): New method used to remove all
18246 the interfaces that are already implemented by our parent
18247 classes from the list of pending methods.
18249 * interface.cs: Add checks for calls after ResolveTypeExpr.
18251 2002-11-05 Miguel de Icaza <miguel@ximian.com>
18253 * class.cs (Class.Emit): Report warning 67: event not used if the
18254 warning level is beyond 3.
18256 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
18257 being a NullLiteral.
18259 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
18262 * class.cs (TypeContainer.GetClassBases): Cover a missing code
18263 path that might fail if a type can not be resolved.
18265 * expression.cs (Binary.Emit): Emit unsigned versions of the
18268 * driver.cs: use error 5.
18270 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
18272 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
18274 2002-11-01 Miguel de Icaza <miguel@ximian.com>
18276 * cs-parser.jay (switch_section): A beautiful patch from Martin
18277 Baulig that fixed 33094.
18279 2002-10-31 Miguel de Icaza <miguel@ximian.com>
18281 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
18282 Check whether the base is abstract and report an error if so.
18284 * expression.cs (IndexerAccess.DoResolveLValue,
18285 IndexerAccess.DoResolve): ditto.
18287 (Invocation.DoResolve): ditto.
18289 (Invocation.FullMethodDesc): Improve the report string.
18291 * statement.cs (Block): Eliminate IsVariableDefined as it is
18292 basically just a wrapper for GetVariableInfo.
18294 * ecore.cs (SimpleName): Use new
18296 * support.cs (ReflectionParamter.ParameterType): We unwrap the
18297 type, as we return the actual parameter ref/unref state on a
18300 2002-10-30 Miguel de Icaza <miguel@ximian.com>
18302 * support.cs: Return proper flags REF/OUT fixing the previous
18305 * expression.cs: Reverted last patch, that was wrong. Is_ref is
18306 not used to mean `ref' but `ref or out' in ParameterReference
18308 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
18309 full type signature instead of calling TypeManger.CSharpName
18312 * support.cs (InternalParameters.ParameterDesc): Do not compare
18313 directly to the modflags, because REF/OUT will actually be bitsets
18316 * delegate.cs (VerifyMethod): Check also the modifiers.
18318 * cs-tokenizer.cs: Fix bug where floating point values with an
18319 exponent where a sign was missing was ignored.
18321 * driver.cs: Allow multiple assemblies to be specified in a single
18324 2002-10-28 Miguel de Icaza <miguel@ximian.com>
18326 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
18327 because identifiers after a parenthesis would end up in this kind
18328 of production, and we needed to desamiguate it for having casts
18331 (UserDefinedType *) xxx
18333 2002-10-24 Miguel de Icaza <miguel@ximian.com>
18335 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
18336 we should set on the Bindingflags.NonPublic, but not turn on
18337 private_ok. private_ok controls whether a Private member is
18338 returned (this is chekced on the filter routine), while the
18339 BindingFlags.NonPublic just controls whether private/protected
18340 will be allowed. This fixes the problem part of the problem of
18341 private properties being allowed to be used in derived classes.
18343 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
18344 so we can call the children DoResolveLValue method (this will
18345 properly signal errors on lvalue assignments to base properties)
18347 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
18348 getter are null, and we have a property info, we know that this
18349 happened because the lookup failed, so we report an error 122 for
18350 protection level violation.
18352 We also silently return if setter and getter are null in the
18353 resolve functions, this condition only happens if we have flagged
18354 the error before. This is the other half of the problem.
18356 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
18357 not have accessibility information, that is why we were returning
18358 true in the filter function in typemanager.cs.
18360 To properly report 122 (property is inaccessible because of its
18361 protection level) correctly, we report this error in ResolveAccess
18362 by failing if both the setter and the getter are lacking (ie, the
18365 DoResolve and DoLResolve have been modified to check for both
18366 setter/getter being null and returning silently, the reason being
18367 that I did not want to put the knowledge about this error in upper
18370 int old = Report.Errors;
18371 x = new PropertyExpr (...);
18372 if (old != Report.Errors)
18377 So the property expr is returned, but it is invalid, so the error
18378 will be flagged during the resolve process.
18380 * class.cs: Remove InheritablePropertySignatureCompare from the
18381 class, as we no longer depend on the property signature to compute
18382 whether it is possible to implement a method or not.
18384 The reason is that calling PropertyInfo.GetGetMethod will return
18385 null (in .NET, in Mono it works, and we should change this), in
18386 cases where the Get Method does not exist in that particular
18391 class X { public virtual int A { get { return 1; } } }
18393 class Z : Y { public override int A { get { return 2; } } }
18395 Would fail in Z because the parent (Y) would not have the property
18396 defined. So we avoid this completely now (because the alternative
18397 fix was ugly and slow), and we now depend exclusively on the
18400 (PropertyBase.CheckBase): Use a method-base mechanism to find our
18401 reference method, instead of using the property.
18403 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
18404 routines are gone now.
18406 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
18407 names, they were incorrectly named.
18409 * cs-tokenizer.cs: Return are more gentle token on failure.
18411 * pending.cs (PendingImplementation.InterfaceMethod): This routine
18412 had an out-of-sync index variable, which caused it to remove from
18413 the list of pending methods the wrong method sometimes.
18415 2002-10-22 Miguel de Icaza <miguel@ximian.com>
18417 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
18418 CanWrite, because those refer to this particular instance of the
18419 property, and do not take into account the fact that we can
18420 override single members of a property.
18422 Constructor requires an EmitContext. The resolution process does
18423 not happen here, but we need to compute the accessors before,
18424 because the resolution does not always happen for properties.
18426 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
18427 subclass, before we did not update this flag, but we did update
18430 (GetAccessors): Drop this routine, as it did not work in the
18431 presence of partially overwritten set/get methods.
18433 Notice that this broke the cs1540 detection, but that will require
18436 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18440 * driver.cs: issue a warning instead of an error if we don't support
18441 debugging for the platform. Also ignore a couple of errors that may
18442 arise when trying to write the symbols. Undo my previous patch.
18444 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18446 * driver.cs: ignore /debug switch except for Unix platforms.
18448 2002-10-23 Nick Drochak <ndrochak@gol.com>
18450 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
18452 2002-10-21 Miguel de Icaza <miguel@ximian.com>
18454 * driver.cs: Do not make mcs-debug conditional, so we do not break
18455 builds that use it.
18457 * statement.cs (UsageVector.MergeChildren): I would like Martin to
18458 review this patch. But basically after all the children variables
18459 have been merged, the value of "Breaks" was not being set to
18460 new_breaks for Switch blocks. I think that it should be set after
18461 it has executed. Currently I set this to the value of new_breaks,
18462 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
18463 conservative, but I do not understand this code very well.
18465 I did not break anything in the build, so that is good ;-)
18467 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
18469 2002-10-20 Mark Crichton <crichton@gimp.org>
18471 * cfold.cs: Fixed compile blocker. Really fixed it this time.
18473 2002-10-20 Nick Drochak <ndrochak@gol.com>
18475 * cfold.cs: Fixed compile blocker.
18477 2002-10-20 Miguel de Icaza <miguel@ximian.com>
18479 * driver.cs: I was chekcing the key, not the file.
18481 2002-10-19 Ravi Pratap <ravi@ximian.com>
18483 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
18484 message that we were generating - we just need to silently return
18487 2002-10-19 Miguel de Icaza <miguel@ximian.com>
18489 * class.cs (Event.Define): Change my previous commit, as this
18490 breaks the debugger. This is a temporary hack, as it seems like
18491 the compiler is generating events incorrectly to begin with.
18493 * expression.cs (Binary.ResolveOperator): Added support for
18494 "U operator - (E x, E y)"
18496 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
18499 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
18500 init-only variables, but this path did not take into account that
18501 there might be also instance readonly variables. Correct this
18504 This fixes bug 32253
18506 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
18509 * driver.cs: Change the extension for modules to `netmodule'
18511 * cs-parser.jay: Improved slightly the location tracking for
18512 the debugger symbols.
18514 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
18515 modifiers that were specified instead of the hardcoded value
18516 (FamAndAssem). This was basically ignoring the static modifier,
18517 and others. Fixes 32429.
18519 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
18520 fixed a bug in the process (32476)
18522 * expression.cs (ArrayAccess.EmitAssign): Patch from
18523 hwang_rob@yahoo.ca that fixes bug 31834.3
18525 2002-10-18 Miguel de Icaza <miguel@ximian.com>
18527 * driver.cs: Make the module extension .netmodule.
18529 2002-10-16 Miguel de Icaza <miguel@ximian.com>
18531 * driver.cs: Report an error if the resource file is not found
18532 instead of crashing.
18534 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
18535 false, like Emit does.
18537 2002-10-16 Nick Drochak <ndrochak@gol.com>
18539 * typemanager.cs: Remove unused private member. Also reported mcs
18540 bug to report this as a warning like csc.
18542 2002-10-15 Martin Baulig <martin@gnome.org>
18544 * statement.cs (Statement.Emit): Made this a virtual method; emits
18545 the line number info and calls DoEmit().
18546 (Statement.DoEmit): New protected abstract method, formerly knows
18547 as Statement.Emit().
18549 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
18551 2002-10-11 Miguel de Icaza <miguel@ximian.com>
18553 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
18554 have fixed a remaining problem: not every AddXXXX was adding a
18555 fully qualified name.
18557 Now everyone registers a fully qualified name in the DeclSpace as
18558 being defined instead of the partial name.
18560 Downsides: we are slower than we need to be due to the excess
18561 copies and the names being registered this way.
18563 The reason for this is that we currently depend (on the corlib
18564 bootstrap for instance) that types are fully qualified, because
18565 we dump all the types in the namespace, and we should really have
18566 types inserted into the proper namespace, so we can only store the
18567 basenames in the defined_names array.
18569 2002-10-10 Martin Baulig <martin@gnome.org>
18571 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
18572 from bug #31834, see the bug report for a testcase which is
18575 2002-10-10 Martin Baulig <martin@gnome.org>
18577 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
18578 flow analysis code for this.
18580 * statement.cs (Do, While, For): Tell the flow analysis code about
18582 (FlowBranching.UsageVector): Added support for infinite loops.
18583 (Block.Resolve): Moved the dead code elimination here and use flow
18586 2002-10-09 Miguel de Icaza <miguel@ximian.com>
18588 * class.cs (Field.Define): Catch cycles on struct type
18591 * typemanager.cs (IsUnmanagedtype): Do not recursively check
18592 fields if the fields are static. We only need to check instance
18595 * expression.cs (As.DoResolve): Test for reference type.
18597 * statement.cs (Using.ResolveExpression): Use
18598 ConvertImplicitRequired, not ConvertImplicit which reports an
18600 (Using.ResolveLocalVariableDecls): ditto.
18602 * expression.cs (Binary.ResolveOperator): Report errors in a few
18603 places where we had to.
18605 * typemanager.cs (IsUnmanagedtype): Finish implementation.
18607 2002-10-08 Miguel de Icaza <miguel@ximian.com>
18609 * expression.cs: Use StoreFromPtr instead of extracting the type
18610 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
18612 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
18613 an enumeration value to a System.Enum, but System.Enum is not a
18614 value type, but an class type, so we need to box.
18616 (Expression.ConvertExplicit): One codepath could return
18617 errors but not flag them. Fix this. Fixes #31853
18619 * parameter.cs (Resolve): Do not allow void as a parameter type.
18621 2002-10-06 Martin Baulig <martin@gnome.org>
18623 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
18624 if it's a class type and not a struct. Fixes #31815.
18626 2002-10-06 Martin Baulig <martin@gnome.org>
18628 * statement.cs: Reworked the flow analysis code a bit to make it
18629 usable for dead code elimination.
18631 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18633 * cs-parser.jay: allow empty source files. Fixes bug #31781.
18635 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18637 * expression.cs (ComposedCast.DoResolveType): A quick workaround
18638 to fix the test 165, will investigate deeper.
18640 2002-10-04 Martin Baulig <martin@gnome.org>
18642 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
18643 finally blocks actually work.
18644 (Try.Resolve): We don't need to create a sibling for `finally' if
18645 there is no finally block.
18647 2002-10-04 Martin Baulig <martin@gnome.org>
18649 * class.cs (Constructor.Define): The default accessibility for a
18650 non-default constructor is private, not public.
18652 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18654 * class.cs (Constructor): Make AllowedModifiers public, add
18657 * cs-parser.jay: Perform the modifiers test here, as the
18658 constructor for the Constructor class usually receives a zero
18659 because of the way we create it (first we create, later we
18660 customize, and we were never checking the modifiers).
18662 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
18663 is a version of LookupTypeReflection that includes the type-name
18664 cache. This can be used as a fast path for functions that know
18665 the fully qualified name and are only calling into *.GetType() to
18666 obtain a composed type.
18668 This is also used by TypeManager.LookupType during its type
18671 (LookupType): We now also track the real type name, as sometimes
18672 we can get a quey for the real type name from things like
18673 ComposedCast. This fixes bug 31422.
18675 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
18676 complete type fullname, it does not have to go through the type
18677 resolution system to obtain the composed version of the type (for
18678 obtaining arrays or pointers).
18680 (Conditional.Emit): Use the EmitBoolExpression to
18681 generate nicer code, as requested by Paolo.
18683 (ArrayCreation.CheckIndices): Use the patch from
18684 hwang_rob@yahoo.ca to validate the array initializers.
18686 2002-10-03 Miguel de Icaza <miguel@ximian.com>
18688 * class.cs (ConstructorInitializer.Emit): simplify code by using
18689 Invocation.EmitCall, and at the same time, fix the bugs in calling
18690 parent constructors that took variable arguments.
18692 * ecore.cs (Expression.ConvertNumericExplicit,
18693 Expression.ImplicitNumericConversion): Remove the code that
18694 manually wrapped decimal (InternalTypeConstructor call is now gone
18697 * expression.cs (Cast.TryReduce): Also handle decimal types when
18698 trying to perform a constant fold on the type.
18700 * typemanager.cs (IsUnmanagedtype): Partially implemented.
18702 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
18703 that only turned off an error report, and did nothing else.
18705 2002-10-02 Miguel de Icaza <miguel@ximian.com>
18707 * driver.cs: Handle and ignore /fullpaths
18709 2002-10-01 Miguel de Icaza <miguel@ximian.com>
18711 * expression.cs (Binary.ResolveOperator): Catch the case where
18712 DoNumericPromotions returns true,
18714 (Binary.DoNumericPromotions): Simplify the code, and the tests.
18716 2002-09-27 Miguel de Icaza <miguel@ximian.com>
18718 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
18721 2002-09-26 Miguel de Icaza <miguel@ximian.com>
18723 * ecore.cs (ConvertNumericExplicit): It is not enough that the
18724 conversion exists, but it is also required that the conversion be
18725 performed. This manifested in "(Type64Enum) 2".
18727 * class.cs (TypeManager.AddMethod): The fix is not to change
18728 AddEnum, because that one was using a fully qualified name (every
18729 DeclSpace derivative does), but to change the AddMethod routine
18730 that was using an un-namespaced name. This now correctly reports
18731 the duplicated name.
18733 Revert patch until I can properly fix it. The issue
18734 is that we have a shared Type space across all namespaces
18735 currently, which is wrong.
18737 Options include making the Namespace a DeclSpace, and merge
18738 current_namespace/current_container in the parser.
18740 2002-09-25 Miguel de Icaza <miguel@ximian.com>
18742 * cs-parser.jay: Improve error reporting when we get a different
18743 kind of expression in local_variable_type and
18744 local_variable_pointer_type.
18746 Propagate this to avoid missleading errors being reported.
18748 * ecore.cs (ImplicitReferenceConversion): treat
18749 TypeManager.value_type as a target just like object_type. As
18754 Is valid, and needs to result in the int 1 being boxed before it
18755 is assigned to the value type v.
18757 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
18758 to validate the enumeration name.
18760 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
18761 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
18762 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
18764 * ecore.cs (TryImplicitIntConversion): When doing an
18765 implicit-enumeration-conversion, check if the type is 64-bits and
18766 perform a conversion before passing to EnumConstant.
18768 2002-09-23 Miguel de Icaza <miguel@ximian.com>
18770 * decl.cs (Error_AmbiguousTypeReference); New routine used to
18771 report ambiguous type references. Unlike the MS version, we
18772 report what the ambiguity is. Innovation at work ;-)
18774 (DeclSpace.FindType): Require a location argument to
18775 display when we display an ambiguous error.
18777 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
18779 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
18781 * expression.cs (EmitDynamicInitializers): Apply patch from
18782 hwang_rob@yahoo.ca that fixes the order in which we emit our
18785 2002-09-21 Martin Baulig <martin@gnome.org>
18787 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
18788 delegate takes no arguments.
18790 2002-09-20 Miguel de Icaza <miguel@ximian.com>
18792 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
18795 * expression.cs: Extract the underlying type.
18797 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
18799 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
18801 2002-09-19 Miguel de Icaza <miguel@ximian.com>
18803 * class.cs (TypeContainer.DefineType): We can not use the nice
18804 PackingSize with the size set to 1 DefineType method, because it
18805 will not allow us to define the interfaces that the struct
18808 This completes the fixing of bug 27287
18810 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
18811 means also structs. This fixes part of the problem.
18812 (Expresion.ImplicitReferenceConversionExists): ditto.
18814 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
18815 error if there were no errors reported during the type lookup
18816 process, to avoid duplicates or redundant errors. Without this
18817 you would get an ambiguous errors plus a type not found. We have
18818 beaten the user enough with the first error.
18820 (DeclSparce.FindType): Emit a warning if we have an ambiguous
18823 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
18824 during the resolution process, stop the lookup, this avoids
18825 repeated error reports (same error twice).
18827 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
18829 * typemanager.cs (LookupType): Redo the type lookup code to match
18830 the needs of System.Reflection.
18832 The issue is that System.Reflection requires references to nested
18833 types to begin with a "+" sign instead of a dot. So toplevel
18834 types look like: "NameSpace.TopLevelClass", and nested ones look
18835 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
18838 2002-09-19 Martin Baulig <martin@gnome.org>
18840 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
18841 says that a method always returns or always throws an exception,
18842 don't report the CS0161.
18844 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
18845 set `Returns = new_returns'.
18847 2002-09-19 Martin Baulig <martin@gnome.org>
18849 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
18850 to an enum constant, check for a CS0176.
18852 2002-09-18 Miguel de Icaza <miguel@ximian.com>
18854 * class.cs (TypeContainer.CheckPairedOperators): Now we check
18855 for operators that must be in pairs and report errors.
18857 * ecore.cs (SimpleName.DoResolveType): During the initial type
18858 resolution process, when we define types recursively, we must
18859 check first for types in our current scope before we perform
18860 lookups in the enclosing scopes.
18862 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18864 (Invocation.VerifyArgumentsCompat): Call
18865 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18866 I thought we were supposed to always call this, but there are a
18867 few places in the code where we dont do it.
18869 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18871 * driver.cs: Add support in -linkres and -resource to specify the
18872 name of the identifier.
18874 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18876 * ecore.cs (StandardConversionExists): Sync with the conversion
18877 code: allow anything-* to void* conversions.
18879 (FindMostSpecificSource): Use an Expression argument
18880 instead of a Type, because we might be handed over a Literal which
18881 gets a few more implicit conversions that plain types do not. So
18882 this information was being lost.
18884 Also, we drop the temporary type-holder expression when not
18887 2002-09-17 Martin Baulig <martin@gnome.org>
18889 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18890 this is an explicit interface implementation.
18892 2002-09-17 Martin Baulig <martin@gnome.org>
18894 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18895 different `IndexerName' attributes.
18897 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18898 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18899 virtual CommonResolve().
18901 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18903 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18904 and convert that to the UnderlyingType.
18906 * statement.cs (Foreach.Resolve): Indexers are just like variables
18907 or PropertyAccesses.
18909 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18910 inside quoted strings, we were not doing this before.
18912 2002-09-16 Martin Baulig <martin@gnome.org>
18914 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18915 resolve it. This is needed for the definite assignment check of the
18916 instance expression, fixes bug #29846.
18917 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18919 2002-09-16 Nick Drochak <ndrochak@gol.com>
18921 * parameter.cs: Fix compile error. Cannot reference static member
18922 from an instance object. Is this an mcs bug?
18924 2002-09-14 Martin Baulig <martin@gnome.org>
18926 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18927 multiple times. Fixes bug #30295, added test-166.cs.
18929 2002-09-14 Martin Baulig <martin@gnome.org>
18931 * statement.cs (Block.Emit): Don't emit unreachable code.
18932 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18933 `break' statements.
18934 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18936 2002-09-14 Martin Baulig <martin@gnome.org>
18938 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18941 2002-09-14 Martin Baulig <martin@gnome.org>
18943 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18944 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18945 be false on the ms runtime.
18947 2002-09-13 Martin Baulig <martin@gnome.org>
18949 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18950 the CS0038 error message.
18952 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18954 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18955 constant inside, return it.
18957 2002-09-12 Martin Baulig <martin@gnome.org>
18959 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18960 implicit conversion can be done between enum types.
18962 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18963 check whether an implicit conversion to the current enum's UnderlyingType
18964 exists and report an error if not.
18966 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18967 without debugging support.
18969 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18970 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18972 2002-09-12 Martin Baulig <martin@gnome.org>
18974 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18976 * ecore.cs (IMemberExpr.DeclaringType): New property.
18977 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18978 nonstatic member of an outer type (CS0038).
18980 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18982 * driver.cs: Activate the using-error detector at warning level
18983 4 (at least for MS-compatible APIs).
18985 * namespace.cs (VerifyUsing): Small buglett fix.
18987 * pending.cs (PendingImplementation): pass the container pointer.
18989 * interface.cs (GetMethods): Allow for recursive definition. Long
18990 term, I would like to move every type to support recursive
18991 definitions, not the current ordering mechanism that we have right
18994 The situation is this: Attributes are handled before interfaces,
18995 so we can apply attributes to interfaces. But some attributes
18996 implement interfaces, we will now handle the simple cases
18997 (recursive definitions will just get an error).
18999 * parameter.cs: Only invalidate types at the end if we fail to
19002 2002-09-09 Martin Baulig <martin@gnome.org>
19004 * ecore.cs (PropertyExpr.Emit): Also check for
19005 TypeManager.system_int_array_get_length so this'll also work when
19006 compiling corlib. Fixes #30003.
19008 2002-09-09 Martin Baulig <martin@gnome.org>
19010 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
19011 and throw an exception if we can't get the type's size. Fixed #30040,
19014 2002-09-09 Martin Baulig <martin@gnome.org>
19016 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
19018 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
19019 context. Fixes bug #30027.
19021 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
19022 virtual functions. Fixes bug #30043, added test-164.cs.
19024 2002-09-08 Ravi Pratap <ravi@ximian.com>
19026 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
19028 2002-09-08 Nick Drochak <ndrochak@gol.com>
19030 * driver.cs: Use an object to get the windows codepage since it's not a
19033 2002-09-08 Miguel de Icaza <miguel@ximian.com>
19035 * statement.cs (For.Emit): for infinite loops (test == null)
19036 return whether there is a break inside, not always "true".
19038 * namespace.cs (UsingEntry): New struct to hold the name of the
19039 using definition, the location where it is defined, and whether it
19040 has been used in a successful type lookup.
19042 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
19047 2002-09-06 Ravi Pratap <ravi@ximian.com>
19049 * attribute.cs : Fix incorrect code which relied on catching
19050 a NullReferenceException to detect a null being passed in
19051 where an object was expected.
19053 2002-09-06 Miguel de Icaza <miguel@ximian.com>
19055 * statement.cs (Try): flag the catch variable as assigned
19057 * expression.cs (Cast): Simplified by using ResolveType instead of
19058 manually resolving.
19060 * statement.cs (Catch): Fix bug by using ResolveType.
19062 2002-09-06 Ravi Pratap <ravi@ximian.com>
19064 * expression.cs (BetterConversion): Special case for when we have
19065 a NullLiteral as the argument and we have to choose between string
19066 and object types - we choose string the way csc does.
19068 * attribute.cs (Attribute.Resolve): Catch the
19069 NullReferenceException and report error #182 since the Mono
19070 runtime no more has the bug and having this exception raised means
19071 we tried to select a constructor which takes an object and is
19074 2002-09-05 Ravi Pratap <ravi@ximian.com>
19076 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
19077 message (1502, 1503) when we can't locate a method after overload
19078 resolution. This is much more informative and closes the bug
19081 * interface.cs (PopulateMethod): Return if there are no argument
19082 types. Fixes a NullReferenceException bug.
19084 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
19085 expressions too. Previously we were checking only in one place for
19086 positional arguments leaving out named arguments.
19088 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
19089 type to the enum type is not allowed. Remove code corresponding to
19092 (ConvertNumericExplicit): Allow explicit conversions from
19093 the underlying type to enum type. This precisely follows the spec
19094 and closes a bug filed by Gonzalo.
19096 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19099 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
19101 2002-09-03 Miguel de Icaza <miguel@ximian.com>
19103 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
19104 it was important that we stored the right value after the
19105 reduction in `converted'.
19107 2002-09-04 Martin Baulig <martin@gnome.org>
19109 * location.cs (Location.SymbolDocument): Use full pathnames for the
19112 2002-08-30 Miguel de Icaza <miguel@ximian.com>
19114 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
19115 of the expression resolve mechanism, because that will catch the
19116 SimpleName error failures.
19118 (Conditional): If we can not resolve the
19119 expression, return, do not crash.
19121 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19124 (location): display token name instead of its number.
19126 2002-08-28 Martin Baulig <martin@gnome.org>
19128 * expression.cs (Binary.ResolveOperator): Don't silently return
19129 but return an error if an operator cannot be applied between two
19132 2002-08-28 Martin Baulig <martin@gnome.org>
19134 * class.cs (Constructor.Define): Set the permission attributes
19135 correctly instead of making all constructors public.
19137 2002-08-28 Martin Baulig <martin@gnome.org>
19139 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
19140 for private members before reporting a CS0103; if we find anything,
19143 2002-08-28 Martin Baulig <martin@gnome.org>
19145 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
19146 to check whether `closure_start_type == closure_invocation_type',
19147 we also need to check whether `m.DeclaringType == closure_invocation_type'
19148 before bypassing the permission checks. We might be accessing
19149 protected/private members from the base class.
19150 (TypeManager.RealMemberLookup): Only set private_ok if private
19151 members were requested via BindingFlags.NonPublic.
19153 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
19155 * expression.cs (MemberAccess.ResolveMemberAccess): Set
19156 MethodGroupExpr.IsExplicitImpl if appropriate.
19157 (Invocation.DoResolve): Don't report the CS0120 for explicit
19158 interface implementations.
19160 2002-08-27 Martin Baulig <martin@gnome.org>
19162 * expression.cs (Invocation.DoResolve): If this is a static
19163 method and we don't have an InstanceExpression, we must report
19166 2002-08-25 Martin Baulig <martin@gnome.org>
19168 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
19169 `==' between a valuetype and an object.
19171 2002-08-25 Miguel de Icaza <miguel@ximian.com>
19173 * ecore.cs (TypeExpr): Provide a ToString method.
19175 2002-08-24 Martin Baulig <martin@gnome.org>
19177 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
19178 now called proggie.dbg and it's a binary file.
19180 2002-08-23 Martin Baulig <martin@gnome.org>
19182 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
19184 2002-08-23 Martin Baulig <martin@gnome.org>
19186 * struct.cs (MyStructInfo.ctor): Make this work with empty
19187 structs; it's not allowed to use foreach() on null.
19189 2002-08-23 Martin Baulig <martin@gnome.org>
19191 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
19192 writer the full pathname of the generated assembly.
19194 2002-08-23 Martin Baulig <martin@gnome.org>
19196 * statements.cs (FlowBranching.UsageVector.MergeChildren):
19197 A `finally' block never returns or breaks; improved handling of
19200 2002-08-23 Martin Baulig <martin@gnome.org>
19202 * statement.cs (Throw.Resolve): Allow `throw null'.
19204 2002-08-23 Martin Baulig <martin@gnome.org>
19206 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
19207 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
19208 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
19209 MemberLookup would return a wrong event if this is an explicit
19210 interface implementation and the class has an event with the same
19213 2002-08-23 Martin Baulig <martin@gnome.org>
19215 * statement.cs (Block.AddChildVariableNames): New public method.
19216 (Block.AddChildVariableName): Likewise.
19217 (Block.IsVariableNameUsedInChildBlock): Likewise.
19218 (Block.AddVariable): Check whether a variable name has already
19219 been used in a child block.
19221 * cs-parser.jay (declare_local_variables): Mark all variable names
19222 from the current block as being used in a child block in the
19225 2002-08-23 Martin Baulig <martin@gnome.org>
19227 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
19228 find the symbol writer.
19230 * driver.cs: csc also allows the arguments to /define being
19231 separated by commas, not only by semicolons.
19233 2002-08-23 Martin Baulig <martin@gnome.org>
19235 * interface.cs (Interface.GetMembers): Added static check for events.
19237 2002-08-15 Martin Baulig <martin@gnome.org>
19239 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
19240 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
19242 * ecore.cs (Expression.MemberLookup): Added documentation and explained
19243 why the MethodData.EmitDestructor() change was necessary.
19245 2002-08-20 Martin Baulig <martin@gnome.org>
19247 * class.cs (TypeContainer.FindMembers): Added static check for events.
19249 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
19251 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
19252 use Type.GetEvents(), not Type.FindMembers().
19254 2002-08-20 Martin Baulig <martin@gnome.org>
19256 * decl.cs (MemberCache): Added a special method cache which will
19257 be used for method-only searched. This ensures that a method
19258 search will return a MethodInfo with the correct ReflectedType for
19261 2002-08-20 Martin Baulig <martin@gnome.org>
19263 * decl.cs (DeclSpace.FindMembers): Made this public.
19265 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19267 * delegate.cs: fixed build on windows.
19268 [FIXME: Filed as bug #29150: MCS must report these errors.]
19270 2002-08-19 Ravi Pratap <ravi@ximian.com>
19272 * ecore.cs (StandardConversionExists): Return a false
19273 if we are trying to convert the void type to anything else
19274 since that is not allowed.
19276 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
19277 we flag error 70 in the event an event is trying to be accessed
19278 directly from outside the declaring type.
19280 2002-08-20 Martin Baulig <martin@gnome.org>
19282 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
19283 MemberCache from typemanager.cs to decl.cs.
19285 2002-08-19 Martin Baulig <martin@gnome.org>
19287 * class.cs (TypeContainer): Implement IMemberContainer.
19288 (TypeContainer.DefineMembers): Create the MemberCache.
19289 (TypeContainer.FindMembers): Do better BindingFlags checking; only
19290 return public members if BindingFlags.Public was given, check
19291 whether members are static.
19293 2002-08-16 Martin Baulig <martin@gnome.org>
19295 * decl.cs (DeclSpace.Define): Splitted this in Define and
19296 DefineMembers. DefineMembers is called first and initializes the
19299 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
19300 DefineMembers() on all our DeclSpaces.
19302 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
19303 but call DefineMembers() on all nested interfaces. We call their
19304 Define() in our new Define() function.
19306 * interface.cs (Interface): Implement IMemberContainer.
19307 (Interface.Define): Moved all code except the attribute stuf to
19309 (Interface.DefineMembers): Initialize the member cache.
19311 * typemanager.cs (IMemberFinder): Removed this interface, we don't
19312 need this anymore since we can use MemberCache.FindMembers directly.
19314 2002-08-19 Martin Baulig <martin@gnome.org>
19316 * typemanager.cs (MemberCache): When creating the cache for an
19317 interface type, add all inherited members.
19318 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
19319 to `out bool used_cache' and documented it.
19320 (TypeManager.MemberLookup): If we already used the cache in the first
19321 iteration, we don't need to do the interfaces check.
19323 2002-08-19 Martin Baulig <martin@gnome.org>
19325 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
19326 here from IMemberFinder and don't implement this interface anymore.
19327 (DeclSpace.MemberCache): Moved here from IMemberFinder.
19329 * typemanager.cs (IMemberFinder): This interface is now only used by
19330 classes which actually support the member cache.
19331 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
19332 since we only put DeclSpaces into this Hashtable.
19333 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
19334 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
19336 2002-08-16 Martin Baulig <martin@gnome.org>
19338 * typemanager.cs (ICachingMemberFinder): Removed.
19339 (IMemberFinder.MemberCache): New property.
19340 (TypeManager.FindMembers): Merged this with RealFindMembers().
19341 This function will never be called from TypeManager.MemberLookup()
19342 so we can't use the cache here, just the IMemberFinder.
19343 (TypeManager.MemberLookup_FindMembers): Check whether the
19344 IMemberFinder has a MemberCache and call the cache's FindMembers
19346 (MemberCache): Rewrote larger parts of this yet another time and
19347 cleaned it up a bit.
19349 2002-08-15 Miguel de Icaza <miguel@ximian.com>
19351 * driver.cs (LoadArgs): Support quoting.
19353 (Usage): Show the CSC-like command line arguments.
19355 Improved a few error messages.
19357 2002-08-15 Martin Baulig <martin@gnome.org>
19359 * typemanager.cs (IMemberContainer.Type): New property.
19360 (IMemberContainer.IsInterface): New property.
19362 The following changes are conditional to BROKEN_RUNTIME, which is
19363 defined at the top of the file.
19365 * typemanager.cs (MemberCache.MemberCache): Don't add the base
19366 class'es members, but add all members from TypeHandle.ObjectType
19367 if we're an interface.
19368 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
19369 is the current type.
19370 (MemberCache.CacheEntry.Container): Removed this field.
19371 (TypeHandle.GetMembers): Include inherited members.
19373 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19375 * typemanager.cs: fixed compilation and added a comment on a field that
19378 2002-08-15 Martin Baulig <martin@gnome.org>
19380 * class.cs (ConstructorInitializer.Resolve): In the
19381 Expression.MemberLookup call, use the queried_type as
19384 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
19385 declared' attribute, it's always true.
19386 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
19387 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
19388 temporary wrapper for FindMembers which tells MemberLookup whether
19389 members from the base classes are included in the return value.
19390 This will go away soon.
19391 (TypeManager.MemberLookup): Use this temporary hack here; once the
19392 new MemberCache is completed, we don't need to do the DeclaredOnly
19393 looping here anymore since the MemberCache will take care of this.
19394 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
19395 (MemberCache): When creating the MemberCache for a class, get
19396 members from the current class and all its base classes.
19397 (MemberCache.CacheEntry.Container): New field. This is a
19398 temporary hack until the Mono runtime is fixed to distinguish
19399 between ReflectedType and DeclaringType. It allows us to use MCS
19400 with both the MS runtime and the unfixed Mono runtime without
19401 problems and without accecting performance.
19402 (MemberCache.SearchMembers): The DeclaredOnly looping from
19403 TypeManager.MemberLookup is now done here.
19405 2002-08-14 Martin Baulig <martin@gnome.org>
19407 * statement.cs (MyStructInfo.MyStructInfo): Don't call
19408 Type.GetFields on dynamic types but get the fields from the
19409 corresponding TypeContainer.
19410 (MyStructInfo.GetStructInfo): Added check for enum types.
19412 * typemanager.cs (MemberList.IsSynchronized): Implemented.
19413 (MemberList.SyncRoot): Implemented.
19414 (TypeManager.FilterWithClosure): No need to check permissions if
19415 closure_start_type == closure_invocation_type, don't crash if
19416 closure_invocation_type is null.
19418 2002-08-13 Martin Baulig <martin@gnome.org>
19420 Rewrote TypeContainer.FindMembers to use a member cache. This
19421 gives us a speed increase of about 35% for the self-hosting MCS
19422 build and of about 15-20% for the class libs (both on GNU/Linux).
19424 * report.cs (Timer): New class to get enhanced profiling. This
19425 whole class is "TIMER" conditional since it remarkably slows down
19428 * class.cs (MemberList): New class. This is an IList wrapper
19429 which we're now using instead of passing MemberInfo[]'s around to
19430 avoid copying this array unnecessarily.
19431 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
19432 (ICachingMemberFinder, IMemberContainer): New interface.
19433 (TypeManager.FilterWithClosure): If `criteria' is null, the name
19434 has already been checked, otherwise use it for the name comparision.
19435 (TypeManager.FindMembers): Renamed to RealMemberFinder and
19436 provided wrapper which tries to use ICachingMemberFinder.FindMembers
19437 if possible. Returns a MemberList, not a MemberInfo [].
19438 (TypeHandle): New class, implements IMemberContainer. We create
19439 one instance of this class per type, it contains a MemberCache
19440 which is used to do the member lookups.
19441 (MemberCache): New class. Each instance of this class contains
19442 all members of a type and a name-based hash table.
19443 (MemberCache.FindMembers): This is our new member lookup
19444 function. First, it looks up all members of the requested name in
19445 the hash table. Then, it walks this list and sorts out all
19446 applicable members and returns them.
19448 2002-08-13 Martin Baulig <martin@gnome.org>
19450 In addition to a nice code cleanup, this gives us a performance
19451 increase of about 1.4% on GNU/Linux - not much, but it's already
19452 half a second for the self-hosting MCS compilation.
19454 * typemanager.cs (IMemberFinder): New interface. It is used by
19455 TypeManager.FindMembers to call FindMembers on a TypeContainer,
19456 Enum, Delegate or Interface.
19457 (TypeManager.finder_to_member_finder): New PtrHashtable.
19458 (TypeManager.finder_to_container): Removed.
19459 (TypeManager.finder_to_delegate): Removed.
19460 (TypeManager.finder_to_interface): Removed.
19461 (TypeManager.finder_to_enum): Removed.
19463 * interface.cs (Interface): Implement IMemberFinder.
19465 * delegate.cs (Delegate): Implement IMemberFinder.
19467 * enum.cs (Enum): Implement IMemberFinder.
19469 * class.cs (TypeContainer): Implement IMemberFinder.
19471 2002-08-12 Martin Baulig <martin@gnome.org>
19473 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
19475 2002-08-12 Martin Baulig <martin@gnome.org>
19477 * ecore.cs (ITypeExpression): New interface for expressions which
19479 (TypeExpression): Renamed to TypeLookupExpression.
19480 (Expression.DoResolve): If we're doing a types-only lookup, the
19481 expression must implement the ITypeExpression interface and we
19482 call DoResolveType() on it.
19483 (SimpleName): Implement the new ITypeExpression interface.
19484 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
19485 hack, the situation that we're only looking up types can't happen
19486 anymore when this method is called. Moved the type lookup code to
19487 DoResolveType() and call it.
19488 (SimpleName.DoResolveType): This ITypeExpression interface method
19489 is now doing the types-only lookup.
19490 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
19491 (ResolveFlags): Added MaskExprClass.
19493 * expression.cs (MemberAccess): Implement the ITypeExpression
19495 (MemberAccess.DoResolve): Added support for a types-only lookup
19496 when we're called via ITypeExpression.DoResolveType().
19497 (ComposedCast): Implement the ITypeExpression interface.
19499 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
19500 Expression.Resolve() with ResolveFlags.Type instead.
19502 2002-08-12 Martin Baulig <martin@gnome.org>
19504 * interface.cs (Interface.Define): Apply attributes.
19506 * attribute.cs (Attribute.ApplyAttributes): Added support for
19507 interface attributes.
19509 2002-08-11 Martin Baulig <martin@gnome.org>
19511 * statement.cs (Block.Emit): Only check the "this" variable if we
19512 do not always throw an exception.
19514 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
19515 whether the property has a set accessor.
19517 2002-08-11 Martin Baulig <martin@gnome.org>
19519 Added control flow analysis support for structs.
19521 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
19522 with control flow analysis turned off.
19523 (IVariable): New interface.
19524 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
19525 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
19526 (FieldExpr.DoResolve): Resolve the instance expression with flow
19527 analysis turned off and do the definite assignment check after the
19528 resolving when we know what the expression will resolve to.
19530 * expression.cs (LocalVariableReference, ParameterReference):
19531 Implement the new IVariable interface, only call the flow analysis
19532 code if ec.DoFlowAnalysis is true.
19533 (This): Added constructor which takes a Block argument. Implement
19534 the new IVariable interface.
19535 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
19536 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
19537 This does the definite assignment checks for struct members.
19539 * class.cs (Constructor.Emit): If this is a non-static `struct'
19540 constructor which doesn't have any initializer, call
19541 Block.AddThisVariable() to tell the flow analysis code that all
19542 struct elements must be initialized before control returns from
19545 * statement.cs (MyStructInfo): New public class.
19546 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
19547 argument to this indexer. If non-zero, check an individual struct
19548 member, not the whole struct.
19549 (FlowBranching.CheckOutParameters): Check struct members.
19550 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
19551 overloaded versions of these methods which take an additional
19552 `int field_idx' argument to check struct members.
19553 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
19554 overloaded versions of these methods which take an additional
19555 `string field_name' argument to check struct member.s
19556 (VariableInfo): Implement the IVariable interface.
19557 (VariableInfo.StructInfo): New public property. Returns the
19558 MyStructInfo instance of the variable if it's a struct or null.
19559 (Block.AddThisVariable): New public method. This is called from
19560 Constructor.Emit() for non-static `struct' constructor which do
19561 not have any initializer. It creates a special variable for the
19562 "this" instance variable which will be checked by the flow
19563 analysis code to ensure that all of the struct's fields are
19564 initialized before control returns from the constructor.
19565 (UsageVector): Added support for struct members. If a
19566 variable/parameter is a struct with N members, we reserve a slot
19567 in the usage vector for each member. A struct is considered fully
19568 initialized if either the struct itself (slot 0) or all its
19569 members are initialized.
19571 2002-08-08 Martin Baulig <martin@gnome.org>
19573 * driver.cs (Driver.MainDriver): Only report an error CS5001
19574 if there were no compilation errors.
19576 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
19577 `UnsafeContext' property to determine whether the parent is in
19578 unsafe context rather than checking the parent's ModFlags:
19579 classes nested in an unsafe class are unsafe as well.
19581 2002-08-08 Martin Baulig <martin@gnome.org>
19583 * statement.cs (UsageVector.MergeChildren): Distinguish between
19584 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
19585 we return. Added test17() and test18() to test-154.cs.
19587 2002-08-08 Martin Baulig <martin@gnome.org>
19589 * typemanager.cs (TypeManager.FilterWithClosure): If we have
19590 Family access, make sure the invoking type isn't a subclass of the
19591 queried type (that'd be a CS1540).
19593 * ecore.cs (Expression.MemberLookup): Added overloaded version of
19594 this method which takes an additional `Type invocation_type'.
19596 * expression.cs (BaseAccess.DoResolve): Use the base type as
19597 invocation and query type.
19598 (MemberAccess.DoResolve): If the lookup failed and we're about to
19599 report a CS0122, try a lookup with the ec.ContainerType - if this
19600 succeeds, we must report a CS1540.
19602 2002-08-08 Martin Baulig <martin@gnome.org>
19604 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
19605 (MethodGroupExpr): Implement the IMemberExpr interface.
19607 * expression (MemberAccess.ResolveMemberAccess): No need to have
19608 any special code for MethodGroupExprs anymore, they're now
19611 2002-08-08 Martin Baulig <martin@gnome.org>
19613 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
19614 Family, FamANDAssem and FamORAssem permissions.
19615 (TypeManager.IsSubclassOrNestedChildOf): New public method.
19617 2002-08-08 Martin Baulig <martin@gnome.org>
19619 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
19620 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
19623 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
19625 * driver.cs: implemented /resource option to embed managed resources.
19627 2002-08-07 Martin Baulig <martin@gnome.org>
19629 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
19630 (FieldBase.HasFieldInitializer): New public property.
19631 (FieldBase.GetInitializerExpression): New public method. Resolves and
19632 returns the field initializer and makes sure it is only resolved once.
19633 (TypeContainer.EmitFieldInitializers): Call
19634 FieldBase.GetInitializerExpression to get the initializer, this ensures
19635 that it isn't resolved multiple times.
19637 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
19638 the resolving process (SimpleName/MemberLookup) that we're currently
19639 emitting a field initializer (which must not access any instance members,
19640 this is an error CS0236).
19642 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
19643 argument, if the `IsFieldInitializer' flag is set, we must report and
19644 error CS0236 and not an error CS0120.
19646 2002-08-07 Martin Baulig <martin@gnome.org>
19648 * ecore.cs (IMemberExpr): New public interface.
19649 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
19650 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
19651 if the expression is an IMemberExpr.
19653 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
19654 to be null, implicitly default to `this' if we're non-static in
19655 this case. Simplified the code a lot by using the new IMemberExpr
19656 interface. Also fixed bug #28176 here.
19658 2002-08-06 Martin Baulig <martin@gnome.org>
19660 * cs-parser.jay (SimpleLookup): Removed. We need to create
19661 ParameterReferences during semantic analysis so that we can do a
19662 type-only search when resolving Cast, TypeOf and SizeOf.
19663 (block): Pass the `current_local_parameters' to the Block's
19666 * class.cs (ConstructorInitializer): Added `Parameters parameters'
19667 argument to the constructor.
19668 (ConstructorInitializer.Resolve): Create a temporary implicit
19669 block with the parameters.
19671 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
19672 references here if we aren't doing a type-only search.
19674 * statement.cs (Block): Added constructor which takes a
19675 `Parameters parameters' argument.
19676 (Block.Parameters): New public property.
19678 * support.cs (InternalParameters.Parameters): Renamed `parameters'
19679 to `Parameters' and made it public readonly.
19681 2002-08-06 Martin Baulig <martin@gnome.org>
19683 * ecore.cs (Expression.Warning): Made this public as well.
19685 * report.cs (Report.Debug): Print the contents of collections.
19687 2002-08-06 Martin Baulig <martin@gnome.org>
19689 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
19690 used to tell Resolve() which kinds of expressions it may return.
19691 (Expression.Resolve): Added overloaded version of this method which
19692 takes a `ResolveFlags flags' argument. This can be used to tell
19693 Resolve() which kinds of expressions it may return. Reports a
19695 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
19696 ResolveFlags.SimpleName.
19697 (Expression.Error118): Added overloaded version of this method which
19698 takes a `ResolveFlags flags' argument. It uses the flags to determine
19699 which kinds of expressions are allowed.
19701 * expression.cs (Argument.ResolveMethodGroup): New public method.
19702 Resolves an argument, but allows a MethodGroup to be returned.
19703 This is used when invoking a delegate.
19705 * TODO: Updated a bit.
19707 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19709 Fixed compilation with csc.
19711 * ecore.cs: Expression.Error made public. Is this correct? Should
19712 Warning be made public too?
19714 * expression.cs: use ea.Location instead of ea.loc.
19715 [FIXME: Filed as bug #28607: MCS must report these errors.]
19717 2002-08-06 Martin Baulig <martin@gnome.org>
19719 * ecore.cs (Expression.loc): Moved the location here instead of
19720 duplicating it in all derived classes.
19721 (Expression.Location): New public property.
19722 (Expression.Error, Expression.Warning): Made them non-static and
19723 removed the location argument.
19724 (Expression.Warning): Added overloaded version which takes an
19725 `int level' argument.
19726 (Expression.Error118): Make this non-static and removed the
19727 expression and location arguments.
19728 (TypeExpr): Added location argument to the constructor.
19730 * expression.cs (StaticCallExpr): Added location argument to
19732 (Indirection, PointerArithmetic): Likewise.
19733 (CheckedExpr, UnCheckedExpr): Likewise.
19734 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
19735 (StringPtr): Likewise.
19738 2002-08-05 Martin Baulig <martin@gnome.org>
19740 * expression.cs (BaseAccess.DoResolve): Actually report errors.
19742 * assign.cs (Assign.DoResolve): Check whether the source
19743 expression is a value or variable.
19745 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
19746 while resolving the corresponding blocks.
19748 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
19749 an error, don't silently return null.
19751 * statement.cs (Block.AddVariable): Do the error reporting here
19752 and distinguish between CS0128 and CS0136.
19753 (Block.DoResolve): Report all unused labels (warning CS0164).
19754 (LabeledStatement): Pass the location to the constructor.
19755 (LabeledStatement.HasBeenReferenced): New property.
19756 (LabeledStatement.Resolve): Set it to true here.
19758 * statement.cs (Return.Emit): Return success even after reporting
19759 a type mismatch error (CS0126 or CS0127), this is what csc does and
19760 it avoids confusing the users with any consecutive errors.
19762 2002-08-05 Martin Baulig <martin@gnome.org>
19764 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
19766 * const.cs (Const.LookupConstantValue): Catch circular definitions.
19768 * expression.cs (MemberAccess.DoResolve): Silently return if an
19769 error has already been reported.
19771 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
19772 error has already been reported.
19774 2002-08-05 Martin Baulig <martin@gnome.org>
19776 * statement.cs (UsageVector): Only initialize the `parameters'
19777 vector if we actually have any "out" parameters.
19779 2002-08-05 Martin Baulig <martin@gnome.org>
19781 * expression.cs (Binary.ResolveOperator): When combining delegates,
19782 they must have the same type.
19784 2002-08-05 Martin Baulig <martin@gnome.org>
19786 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
19787 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
19788 work with the ms runtime and we also don't need it: if we're a
19789 PropertyBuilder and not in the `indexer_arguments' hash, then we
19790 are a property and not an indexer.
19792 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
19793 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
19794 since the latter one doesn't work with the ms runtime.
19796 2002-08-03 Martin Baulig <martin@gnome.org>
19798 Fixed bugs #27998 and #22735.
19800 * class.cs (Method.IsOperator): New public field.
19801 (Method.CheckBase): Report CS0111 if there's already a method
19802 with the same parameters in the current class. Report CS0508 when
19803 attempting to change the return type of an inherited method.
19804 (MethodData.Emit): Report CS0179 if a method doesn't have a body
19805 and it's not marked abstract or extern.
19806 (PropertyBase): New abstract base class for Property and Indexer.
19807 (PropertyBase.CheckBase): Moved here from Property and made it work
19809 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
19810 the same so we can reuse it there.
19811 (Property, Indexer): Derive from PropertyBase.
19812 (MethodSignature.inheritable_property_signature_filter): New delegate
19813 to find properties and indexers.
19815 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
19816 argument and improved error reporting.
19818 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
19819 EmptyReadOnlyParameters and made it a property.
19821 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
19822 version of this method which takes a `PropertyInfo indexer'.
19823 (TypeManager.RegisterIndexer): New method.
19825 * class.cs: Added myself as author of this file :-)
19827 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19829 * class.cs: fixed compilation on windoze.
19831 2002-08-03 Martin Baulig <martin@gnome.org>
19833 * interface.cs (Interface.GetInterfaceBases): Check whether all
19834 base interfaces are at least as accessible than the current one.
19836 * class.cs (TypeContainer.GetClassBases): Check whether base types
19837 are at least as accessible than the current type.
19838 (TypeContainer.AsAccessible): Implemented and made non-static.
19839 (MemberBase.CheckParameters): Report errors if the accessibility
19842 * delegate.cs (Delegate.Delegate): The default visibility is
19843 internal for top-level types and private for nested types.
19844 (Delegate.Define): Report errors if the accessibility checks fail.
19846 * enum.cs (Enum.Enum): The default visibility is internal for
19847 top-level types and private for nested types.
19848 (Enum.DefineType): Compute the correct visibility.
19850 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
19851 function which takes a `bool is_toplevel' instead of a TypeContainer.
19853 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
19856 2002-08-02 Martin Baulig <martin@gnome.org>
19858 * expression.cs (LocalVariableReferenc): Added constructor which
19859 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
19860 (LocalVariableReference.IsReadOnly): New property.
19861 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19862 variable is readonly, use our own readonly flag to do this; you can
19863 use the new constructor to get a writable reference to a read-only
19866 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19867 reference to the local variable.
19869 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19871 * rootcontext.cs (ResolveCore): Also include System.Exception
19873 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19874 we reach an EmptyStatement.
19876 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19879 * expression.cs (Binary.ResolveOperator): Check error result in
19882 use brtrue/brfalse directly and avoid compares to null.
19884 2002-08-02 Martin Baulig <martin@gnome.org>
19886 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19887 Fixes bug #28407, added test-155.cs.
19889 2002-08-01 Martin Baulig <martin@gnome.org>
19891 * class.cs (Event.EmitDefaultMethod): Make this work with static
19892 events. Fixes #28311, added verify-3.cs.
19894 2002-08-01 Martin Baulig <martin@gnome.org>
19896 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19897 `is_disposable' fields.
19898 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19899 `hm.is_disposable' if we're using the collection pattern.
19900 (Foreach.EmitCollectionForeach): Use the correct type for the
19901 enumerator's local variable, only emit the try/finally block if
19902 necessary (fixes #27713).
19904 2002-08-01 Martin Baulig <martin@gnome.org>
19906 * ecore.cs (Expression.report118): Renamed to Error118 and made
19909 * statement.cs (Throw.Resolve): Check whether the expression is of
19910 the correct type (CS0118) and whether the type derives from
19911 System.Exception (CS0155).
19912 (Catch.Resolve): New method. Do the type lookup here and check
19913 whether it derives from System.Exception (CS0155).
19914 (Catch.CatchType, Catch.IsGeneral): New public properties.
19916 * typemanager.cs (TypeManager.exception_type): Added.
19918 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19920 * driver.cs: Updated About function.
19922 2002-07-31 Martin Baulig <martin@gnome.org>
19924 Implemented Control Flow Analysis.
19926 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19927 (EmitContext.CurrentBranching): Added.
19928 (EmitContext.StartFlowBranching): Added.
19929 (EmitContext.EndFlowBranching): Added.
19930 (EmitContext.KillFlowBranching): Added.
19931 (EmitContext.IsVariableAssigned): Added.
19932 (EmitContext.SetVariableAssigned): Added.
19933 (EmitContext.IsParameterAssigned): Added.
19934 (EmitContext.SetParameterAssigned): Added.
19935 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19936 Added control flow analysis stuff here.
19938 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19939 resolve the expression as lvalue.
19940 (LocalVariableReference.DoResolve): Check whether the variable has
19941 already been assigned.
19942 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19943 the parameter as assigned here.
19944 (ParameterReference.DoResolve): Check whether the parameter has already
19946 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19947 expression as lvalue.
19949 * statement.cs (FlowBranching): New class for the flow analysis code.
19950 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19951 (LabeledStatement.IsDefined): New public property.
19952 (LabeledStatement.AddUsageVector): New public method to tell flow
19953 analyis that the label may be reached via a forward jump.
19954 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19956 (VariableInfo.Number): New public field. This is used by flow analysis
19957 to number all locals of a block.
19958 (Block.CountVariables): New public property. This is the number of
19959 local variables in this block (including the locals from all parent
19961 (Block.EmitMeta): Number all the variables.
19963 * statement.cs: Added flow analysis support to all classes.
19965 2002-07-31 Martin Baulig <martin@gnome.org>
19967 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19968 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19969 then use this argument.
19971 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19973 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19974 use this to specify /define options.
19976 2002-07-29 Martin Baulig <martin@gnome.org>
19978 * statement.cs (Fixed): Moved all code that does variable lookups
19979 and resolvings from Emit to Resolve.
19981 * statement.cs (For): Moved all code that does variable lookups
19982 and resolvings from Emit to Resolve.
19984 * statement.cs (Using): Moved all code that does variable lookups
19985 and resolvings from Emit to Resolve.
19987 2002-07-29 Martin Baulig <martin@gnome.org>
19989 * attribute.cs (Attribute.Resolve): Explicitly catch a
19990 System.NullReferenceException when creating the
19991 CustromAttributeBuilder and report a different warning message.
19993 2002-07-29 Martin Baulig <martin@gnome.org>
19995 * support.cs (ParameterData.ParameterName): Added method to
19996 get the name of a parameter.
19998 * typemanager.cs (TypeManager.IsValueType): New public method.
20000 2002-07-29 Martin Baulig <martin@gnome.org>
20002 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
20003 is a flag which specifies that it's either ref or out.
20004 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
20005 the out parameter to `out Parameter.Modifier mod', also set the
20006 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
20008 * support.cs (InternalParameters.ParameterModifier): Distinguish
20009 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20010 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20012 * expression.cs (Argument.GetParameterModifier): Distinguish
20013 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20014 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20016 2002-07-29 Martin Baulig <martin@gnome.org>
20018 * expression.cs (ParameterReference.ParameterReference): Added
20019 `Location loc' argument to the constructor.
20021 * cs-parser.jay: Pass location to ParameterReference.
20023 2002-07-28 Miguel de Icaza <miguel@ximian.com>
20025 * statement.cs (Try): Initialize the location.
20027 * cs-parser.jay: pass location to Try.
20029 * expression.cs (Unary.Reduce): Change the prototype to return
20030 whether a constant fold could be performed or not. The result is
20031 returned in an out parameters. In the case of Indirection and
20032 AddressOf, we want to perform the full tests.
20034 2002-07-26 Miguel de Icaza <miguel@ximian.com>
20036 * statement.cs (Statement.Emit): Flag dead code.
20038 2002-07-27 Andrew Birkett <andy@nobugs.org>
20040 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
20042 2002-07-27 Martin Baulig <martin@gnome.org>
20044 * class.cs (MethodData.Define): Put back call to
20045 TypeManager.AddMethod(), accidentally commented this out.
20047 * report.cs (Debug): New public method to print debugging information,
20048 this is `[Conditional ("DEBUG")]'.
20050 2002-07-26 Martin Baulig <martin@gnome.org>
20052 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
20053 (switch_statement): Push the current_block to the switch_stack and
20054 pop it again when we're done with the switch.
20055 (switch_section): The new block is a child of the current_block.
20056 Fixes bug #24007, added test-152.cs.
20058 2002-07-27 Martin Baulig <martin@gnome.org>
20060 * expression.cs (Invocation.EmitArguments): When calling a varargs
20061 function with only its fixed arguments, we need to pass an empty
20064 2002-07-27 Martin Baulig <martin@gnome.org>
20066 Mono 0.13 has been released.
20068 2002-07-25 Miguel de Icaza <miguel@ximian.com>
20070 * driver.cs: Rename --resource to --linkres, because that is what
20071 we do currently, we dont support --resource yet.
20073 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
20075 2002-07-25 Martin Baulig <martin@gnome.org>
20077 * class.cs (MethodData): New public class. This is a `method builder'
20078 class for a method or one accessor of a Property/Indexer/Event.
20079 (MethodData.GetMethodFlags): Moved here from MemberBase.
20080 (MethodData.ApplyAttributes): Likewise.
20081 (MethodData.ApplyObsoleteAttribute): Likewise.
20082 (MethodData.ApplyConditionalAttribute): Likewise.
20083 (MethodData.ApplyDllImportAttribute): Likewise.
20084 (MethodData.CheckAbstractAndExternal): Likewise.
20085 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
20086 (MethodData.Emit): Formerly known as Method.Emit().
20087 (MemberBase): Moved everything which was specific to a single
20088 accessor/method to MethodData.
20089 (Method): Create a new MethodData and call Define() and Emit() on it.
20090 (Property, Indexer, Event): Create a new MethodData objects for each
20091 accessor and call Define() and Emit() on them.
20093 2002-07-25 Martin Baulig <martin@gnome.org>
20095 Made MethodCore derive from MemberBase to reuse the code from there.
20096 MemberBase now also checks for attributes.
20098 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
20099 (MemberBase.GetMethodFlags): Moved here from class Method and marked
20101 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
20102 `CallingConventions cc' and `Attributes opt_attrs' arguments.
20103 (MemberBase.ApplyAttributes): New virtual method; applies the
20104 attributes to a method or accessor.
20105 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
20106 (MemberBase.ApplyConditionalAttribute): Likewise.
20107 (MemberBase.ApplyDllImportAttribute): Likewise.
20108 (MemberBase.CheckAbstractAndExternal): Likewise.
20109 (MethodCore.ParameterTypes): This is now a property instead of a
20110 method, it's initialized from DoDefineParameters().
20111 (MethodCore.ParameterInfo): Removed the set accessor.
20112 (MethodCore.DoDefineParameters): New protected virtual method to
20113 initialize ParameterTypes and ParameterInfo.
20114 (Method.GetReturnType): We can now simply return the MemberType.
20115 (Method.GetMethodFlags): Override the MemberBase version and add
20116 the conditional flags.
20117 (Method.CheckBase): Moved some code from Define() here, call
20118 DoDefineParameters() here.
20119 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
20120 here to avoid some larger code duplication.
20121 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
20122 ensure that abstract and external accessors don't declare a body.
20124 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
20125 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
20126 lookup in the attribute's parent classes, so we need to abort as soon
20127 as we found the first match.
20128 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
20129 the attribute has no arguments.
20131 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
20134 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20136 * cs-parser.jay: reverted previous patch.
20138 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20140 * cs-parser.jay: fixed bug #22119.
20142 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20144 * attribute.cs: fixed compilation. The error was:
20145 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
20146 be assigned to before control leaves the current method."
20147 [FIXME: Filed as bug #28186: MCS must report this error.]
20149 2002-07-25 Martin Baulig <martin@gnome.org>
20151 * attribute.cs (Attribute.Conditional_GetConditionName): New static
20152 method to pull the condition name ouf of a Conditional attribute.
20153 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
20154 the obsolete message and error flag out of an Obsolete attribute.
20156 * class.cs (Method.GetMethodFlags): New public method to get the
20157 TypeManager.MethodFlags for this method.
20158 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
20160 (Method.Define): Get and apply the Obsolete and Conditional attributes;
20161 if we're overriding a virtual function, set the new private variable
20162 `parent_method'; call the new TypeManager.AddMethod().
20164 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
20165 the MethodBuilder and the Method in a PtrHashtable.
20166 (TypeManager.builder_to_method): Added for this purpose.
20167 (TypeManager.MethodFlags): Added IsObsoleteError.
20168 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
20169 Obsolete and Conditional arguments in MethodBuilders. If we discover
20170 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
20171 the message from the attribute.
20173 2002-07-24 Martin Baulig <martin@gnome.org>
20175 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
20176 preprocessor directives, ensure that the argument to #define/#undef is
20177 exactly one identifier and that it's actually an identifier.
20179 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
20182 2002-07-24 Martin Baulig <martin@gnome.org>
20184 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
20185 initialize it to TypeManager.object_type in the constructor.
20186 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
20187 of the `hm.get_current' method if we're using the collection pattern.
20188 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
20189 for the explicit conversion to make it work when we're using the collection
20190 pattern and the `Current' property has a different return type than `object'.
20193 2002-07-24 Martin Baulig <martin@gnome.org>
20195 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
20196 does not match, but don't report any errors. This method is called in
20197 order for all methods in a MethodGroupExpr until a matching method is
20198 found, so we don't want to bail out if the first method doesn't match.
20199 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
20200 matches, report the 123. Fixes #28070.
20202 2002-07-24 Martin Baulig <martin@gnome.org>
20204 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
20205 TypeManager.TypeToCoreType() to the top of the method so the
20206 following equality checks will work. Fixes #28107.
20208 2002-07-24 Martin Baulig <martin@gnome.org>
20210 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
20211 operand is of type uint, and the other operand is of type sbyte,
20212 short or int, the operands are converted to type long." -
20213 Actually do what this comment already told us. Fixes bug #28106,
20216 2002-07-24 Martin Baulig <martin@gnome.org>
20218 * class.cs (MethodBase): New abstract class. This is now a base
20219 class for Property, Indexer and Event to avoid some code duplication
20220 in their Define() and DefineMethods() methods.
20221 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
20222 generic methods for Define() and DefineMethods().
20223 (FieldBase): Derive from MemberBase, not MemberCore.
20224 (Property): Derive from MemberBase, not MemberCore.
20225 (Property.DefineMethod): Moved all the code from this method to the
20226 new MethodBase.DefineAccessor(), just call it with appropriate
20228 (Property.Define): Call the new Property.DoDefine(), this does some
20229 sanity checks and we don't need to duplicate the code everywhere.
20230 (Event): Derive from MemberBase, not MemberCore.
20231 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
20232 accessors, this will also make them work with interface events.
20233 (Indexer): Derive from MemberBase, not MemberCore.
20234 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
20235 (Indexer.Define): Use the new MethodBase functions.
20237 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
20238 argument to the constructor.
20239 (Interface.FindMembers): Added support for interface events.
20240 (Interface.PopluateEvent): Implemented.
20242 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
20244 2002-07-22 Miguel de Icaza <miguel@ximian.com>
20246 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
20247 but this is required to check for a method name being the same as
20248 the containing class.
20252 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20254 * interface.cs: initialize variable.
20256 2002-07-23 Martin Baulig <martin@gnome.org>
20258 Implemented the IndexerName attribute in interfaces.
20260 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
20261 name if this is an explicit interface implementation.
20262 (Indexer.InterfaceIndexerName): New public variable. If we're
20263 implementing an interface indexer, this is the IndexerName in that
20264 interface. Otherwise, it's the IndexerName.
20265 (Indexer.DefineMethod): If we're implementing interface indexer,
20266 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
20267 and Pending.ImplementIndexer methods.
20268 (Indexer.Define): Also define the PropertyBuilder if we're
20269 implementing an interface indexer and this is neither an explicit
20270 interface implementation nor do the IndexerName match the one in
20273 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
20274 If a method is defined here, then we always need to create a proxy
20275 for it. This is used when implementing interface indexers.
20276 (Pending.IsInterfaceIndexer): New public method.
20277 (Pending.ImplementIndexer): New public method.
20278 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
20279 This is used when implementing interface indexers to define a proxy
20281 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
20282 define a proxy if necessary.
20284 * interface.cs (Interface.IndexerName): New public variable.
20285 (Interface.PopulateIndexer): Set the IndexerName.
20286 (Interface.DefineIndexers): New private method. Populate all the
20287 indexers and make sure their IndexerNames match.
20289 * typemanager.cs (IndexerPropertyName): Added support for interface
20292 2002-07-22 Martin Baulig <martin@gnome.org>
20294 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
20295 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
20296 ret if HasReturnLabel.
20297 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
20300 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
20301 and set the ec.LoopBeginTryCatchLevel.
20302 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
20303 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
20304 the current ec.TryCatchLevel, the branch goes out of an exception
20305 block. In this case, we need to use Leave and not Br.
20307 2002-07-22 Martin Baulig <martin@gnome.org>
20309 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
20310 block unless the block does not always return or it is contained in
20311 another try { ... } catch { ... } block. Fixes bug #26506.
20312 Added verify-1.cs to the test suite.
20314 2002-07-22 Martin Baulig <martin@gnome.org>
20316 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
20317 then we do not always return. Fixes bug #24985.
20319 2002-07-22 Martin Baulig <martin@gnome.org>
20321 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
20322 lookup on a per-class level; ie. walk up the class hierarchy until we
20323 found at least one applicable method, then choose the best among them.
20324 Fixes bug #24463 and test-29.cs.
20326 2002-07-22 Martin Baulig <martin@gnome.org>
20328 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
20329 return types of the methods. The return type is not part of the
20330 signature and we must not check it to make the `new' modifier work.
20331 Fixes bug #27999, also added test-147.cs.
20332 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
20334 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
20335 on the method's return type.
20337 2002-07-21 Martin Baulig <martin@gnome.org>
20339 * assign.cs: Make this work if the rightmost source is a constant and
20340 we need to do an implicit type conversion. Also adding a few more tests
20341 to test-38.cs which should have caught this.
20343 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
20344 target in the makefile for this. The makefile.gnu is primarily intended
20345 for end-users who don't want to debug the compiler.
20347 2002-07-21 Martin Baulig <martin@gnome.org>
20349 * assign.cs: Improved the Assign class so it can now handle embedded
20350 assignments (X = Y = Z = something). As a side-effect this'll now also
20351 consume less local variables. test-38.cs now passes with MCS, added
20352 a few new test cases to that test.
20354 2002-07-20 Martin Baulig <martin@gnome.org>
20356 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
20357 instructions. Fixes bug #27977, also added test-146.cs.
20359 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20361 * cs-tokenizer.cs: fixed getHex ().
20363 2002-07-19 Martin Baulig <martin@gnome.org>
20365 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
20366 not Type.GetType() to lookup the array type. This is needed when
20367 we're constructing an array of a user-defined type.
20368 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
20369 single-dimensional arrays, but also for single-dimensial arrays of
20372 2002-07-19 Martin Baulig <martin@gnome.org>
20374 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
20375 this function is called, it's not allowed to share LocalBuilders
20376 among ILGenerators.
20378 2002-07-19 Martin Baulig <martin@gnome.org>
20380 * expression.cs (Argument.Resolve): Report an error 118 when trying
20381 to pass a type as argument.
20383 2002-07-18 Martin Baulig <martin@gnome.org>
20385 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
20386 Conv_R_Un for the signed `long' type.
20388 2002-07-15 Miguel de Icaza <miguel@ximian.com>
20390 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
20391 `expr' for the temporary result, as that will fail if we do
20392 multiple resolves on the same expression.
20394 2002-07-05 Miguel de Icaza <miguel@ximian.com>
20396 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
20397 ec.TypeContainer for looking up aliases.
20399 * class.cs (TypeContainer): Remove LookupAlias from here.
20401 * decl.cs (DeclSpace); Move here.
20403 2002-07-01 Miguel de Icaza <miguel@ximian.com>
20405 * class.cs (FindMembers): Only call filter if the constructor
20406 bulider is not null.
20408 Also handle delegates in `NestedTypes' now. Now we will perform
20409 type lookups using the standard resolution process. This also
20412 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
20413 This uses Expressions (the limited kind that can be parsed by the
20414 tree) instead of strings.
20416 * expression.cs (ComposedCast.ToString): Implement, used to flag
20417 errors since now we have to render expressions.
20419 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
20422 * ecore.cs (SimpleName.ToString): ditto.
20424 * cs-parser.jay: Instead of using strings to assemble types, use
20425 Expressions to assemble the type (using SimpleName, ComposedCast,
20426 MemberAccess). This should fix the type lookups in declarations,
20427 because we were using a different code path for this.
20429 * statement.cs (Block.Resolve): Continue processing statements
20430 even when there is an error.
20432 2002-07-17 Miguel de Icaza <miguel@ximian.com>
20434 * class.cs (Event.Define): Also remove the `remove' method from
20435 the list of pending items.
20437 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
20438 generate more compact code.
20440 2002-07-17 Martin Baulig <martin@gnome.org>
20442 * const.cs (Const.LookupConstantValue): Add support for constant
20443 `unchecked' and `checked' expressions.
20444 Also adding test case test-140.cs for this.
20446 2002-07-17 Martin Baulig <martin@gnome.org>
20448 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
20449 check whether mi.ReturnType implements the IEnumerator interface; the
20450 `==' and the IsAssignableFrom() will fail in this situation.
20452 2002-07-16 Ravi Pratap <ravi@ximian.com>
20454 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
20457 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20459 * expression.cs: fixed bug #27811.
20461 2002-07-14 Miguel de Icaza <miguel@ximian.com>
20463 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
20464 Molaro: when we are a ref, the value already contains a pointer
20465 value, do not take the address of it.
20467 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20468 * removed mb-parser.jay and mb-tokenizer.cs
20470 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20472 * expression.cs: check against the building corlib void type.
20474 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
20476 * ecore.cs: fix for valuetype static readonly fields: when
20477 initializing them, we need their address, not the address of a copy.
20479 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
20481 * typemanager.cs: register also enum_type in corlib.
20483 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20485 * class.cs: allow calling this (but not base) initializers in structs.
20487 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
20489 * ecore.cs: make sure we compare against the building base types
20492 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
20494 * typemanager.cs: fix TypeToCoreType() to handle void and object
20495 (corlib gets no more typerefs after this change).
20497 2002-07-12 Miguel de Icaza <miguel@ximian.com>
20499 * expression.cs (ArrayCreation.EmitArrayArguments): use
20500 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
20502 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
20503 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
20504 array indexes, the runtime actually forbids them.
20506 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
20507 for array arguments here.
20509 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
20510 instead of the default for ValueTypes.
20512 (New.DoEmit): Use IsValueType instead of
20513 IsSubclassOf (value_type)
20514 (New.DoResolve): ditto.
20515 (Invocation.EmitCall): ditto.
20517 * assign.cs (Assign): ditto.
20519 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
20520 Statements *are* currently doing part of their resolution during
20523 Expressions do always resolve during resolve, but statements are
20524 only required to propagate resolution to their children.
20526 2002-07-11 Miguel de Icaza <miguel@ximian.com>
20528 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
20530 (LoadAssembly): Do not add the dll if it is already specified
20532 (MainDriver): Add the System directory to the link path at the end,
20533 after all the other -L arguments.
20535 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
20536 wrong opcode for loading bytes and bools (ldelem.i1 instead of
20537 ldelem.u1) and using the opposite for sbytes.
20539 This fixes Digger, and we can finally run it.
20541 * driver.cs (UnixParseOption): Move the option parsing here.
20542 (CSCParseOption): Implement CSC-like parsing of options.
20544 We now support both modes of operation, the old Unix way, and the
20545 new CSC-like way. This should help those who wanted to make cross
20546 platform makefiles.
20548 The only thing broken is that /r:, /reference: and /lib: are not
20549 implemented, because I want to make those have the same semantics
20550 as the CSC compiler has, and kill once and for all the confussion
20551 around this. Will be doing this tomorrow.
20553 * statement.cs (Unsafe.Resolve): The state is checked during
20554 resolve, not emit, so we have to set the flags for IsUnsfe here.
20556 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20558 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
20559 not catch the Error_ObjectRefRequired in SimpleName (as it is
20560 possible to have a class/instance variable name that later gets
20561 deambiguated), we have to check this here.
20563 2002-07-10 Ravi Pratap <ravi@ximian.com>
20565 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
20566 make static and put into Expression.
20568 (Event.Define): Register the private field of the event with the
20569 TypeManager so that GetFieldFromEvent can get at it.
20571 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
20572 keep track of the private field associated with an event which
20575 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
20578 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
20580 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20582 * expression.cs (Binary.EmitBranchable): this routine emits the
20583 Binary expression in a branchable context. This basically means:
20584 we need to branch somewhere, not just get the value on the stack.
20586 This works together with Statement.EmitBoolExpression.
20588 * statement.cs (Statement.EmitBoolExpression): Use
20591 2002-07-09 Miguel de Icaza <miguel@ximian.com>
20593 * statement.cs (For): Reduce the number of jumps in loops.
20595 (For): Implement loop inversion for the For statement.
20597 (Break): We can be breaking out of a Try/Catch controlled section
20598 (foreach might have an implicit try/catch clause), so we need to
20599 use Leave instead of Br.
20601 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
20602 now). If the instace expression supports IMemoryLocation, we use
20603 the AddressOf method from the IMemoryLocation to extract the
20604 address instead of emitting the instance.
20606 This showed up with `This', as we were emitting the instance
20607 always (Emit) instead of the Address of This. Particularly
20608 interesting when This is a value type, as we dont want the Emit
20609 effect (which was to load the object).
20611 2002-07-08 Miguel de Icaza <miguel@ximian.com>
20613 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
20615 * statement.cs (Checked): Set the CheckedState during the resolve
20616 process too, as the ConvCast operations track the checked state on
20617 the resolve process, and not emit.
20619 * cs-parser.jay (namespace_member_declaration): Flag that we have
20620 found a declaration when we do. This is used to flag error 1529
20622 * driver.cs: Report ok when we display the help only.
20624 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
20626 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
20628 2002-07-04 Miguel de Icaza <miguel@ximian.com>
20630 * cs-tokenizer.cs (define): We also have to track locally the
20631 defines. AllDefines is just used for the Conditional Attribute,
20632 but we also need the local defines for the current source code.
20634 2002-07-03 Miguel de Icaza <miguel@ximian.com>
20636 * statement.cs (While, For, Do): These loops can exit through a
20637 Break statement, use this information to tell whether the
20638 statement is the last piece of code.
20640 (Break): Flag that we break.
20642 * codegen.cs (EmitContexts): New `Breaks' state variable.
20644 2002-07-03 Martin Baulig <martin@gnome.org>
20646 * class.cs (TypeContainer.MethodModifiersValid): Allow override
20647 modifiers in method declarations in structs. Otherwise, you won't
20648 be able to override things like Object.Equals().
20650 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20652 * class.cs (Method, Property, Indexer): Do not allow the public
20653 modifier to be used in explicit interface implementations.
20655 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
20656 override modifiers in method declarations in structs
20658 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
20660 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
20661 integer or real overflow, report an error
20663 2002-07-02 Martin Baulig <martin@gnome.org>
20665 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
20666 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
20667 to tell the runtime about our newly created System.Object and
20668 System.ValueType types.
20670 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20672 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
20673 struct instead of Ldarg/Starg.
20675 2002-07-02 Martin Baulig <martin@gnome.org>
20677 * expression.cs (Indirection.Indirection): Call
20678 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
20680 2002-07-02 Martin Baulig <martin@gnome.org>
20682 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
20683 ValueType, call TypeManager.TypeToCoreType() on it.
20684 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
20685 the OpCodes.Newarr argument.
20687 2002-07-02 Martin Baulig <martin@gnome.org>
20689 * expression.cs (Invocation.EmitCall): When compiling corlib,
20690 replace all calls to the system's System.Array type to calls to
20691 the newly created one.
20693 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
20694 System.Array methods.
20695 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
20696 from the system's System.Array type which must be replaced.
20698 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
20700 * typemanager.cs: load unverifiable_code_ctor so we can build
20701 corlib using the correct type. Avoid using GetTypeCode() with
20703 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
20704 TypeManager.object_type to allow building corlib.
20706 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
20708 * ecore.cs: handle System.Enum separately in LoadFromPtr().
20710 2002-07-01 Martin Baulig <martin@gnome.org>
20712 * class.cs: Make the last change actually work, we need to check
20713 whether `ifaces != null' to avoid a crash.
20715 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20717 * class.cs: when we build structs without fields that implement
20718 interfaces, we need to add the interfaces separately, since there is
20719 no API to both set the size and add the interfaces at type creation
20722 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20724 * expression.cs: the dimension arguments to the array constructors
20725 need to be converted if they are a long.
20727 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
20729 * class.cs: don't emit ldarg.0 if there is no parent constructor
20730 (fixes showstopper for corlib).
20732 2002-06-29 Martin Baulig <martin@gnome.org>
20734 MCS now compiles corlib on GNU/Linux :-)
20736 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
20737 ie. check for MethodImplOptions.InternalCall.
20739 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
20740 and TypeManager.attribute_type are null, so we must explicitly check
20741 whether parent is not null to find out whether it's an attribute type.
20742 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
20743 and SetBuilder, not only if the property is neither abstract nor external.
20744 This is necessary to set the MethodImplOptions on the accessor methods.
20745 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
20746 SetBuilder, see Property.Emit().
20748 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
20749 populate "System.Object", "System.ValueType" and "System.Attribute" since
20750 they've already been populated from BootCorlib_PopulateCoreTypes().
20752 2002-06-29 Martin Baulig <martin@gnome.org>
20754 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
20755 is the NullLiteral, we also need to make sure that target_type is not
20758 2002-06-29 Martin Baulig <martin@gnome.org>
20760 * rootcontext.cs (RootContext.ResolveCore): We must initialize
20761 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
20762 before calling BootstrapCorlib_ResolveDelegate ().
20764 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20766 * statement.cs: fixed build-breaker. All tests passed ok.
20768 2002-06-27 Martin Baulig <martin@gnome.org>
20770 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
20771 for System.Decimal when compiling corlib.
20773 2002-06-27 Martin Baulig <martin@gnome.org>
20775 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
20776 switch blocks which contain nothing but a default clause.
20778 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
20780 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
20782 2002-06-27 Martin Baulig <martin@gnome.org>
20784 * ecore.cs (PropertyExpr.PropertyExpr): Call
20785 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
20787 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
20788 is already a TypeBuilder.
20790 2002-06-27 Martin Baulig <martin@gnome.org>
20792 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
20793 `target_type == TypeManager.array_type', not IsAssignableFrom() in
20794 the "from an array-type to System.Array" case. This makes it work
20795 when compiling corlib.
20797 2002-06-27 Martin Baulig <martin@gnome.org>
20799 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
20800 non-static PropertyExpr, set its InstanceExpression. This makes
20801 the `ICollection.Count' property work in System/Array.cs.
20803 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
20805 * driver.cs: Made error handling more consistent. Errors now
20806 tracked by Report class, so many methods which used to return int
20807 now return void. Main() now prints success/failure and
20808 errors/warnings message.
20810 Renamed '--probe' compiler argument to '--expect-error'. Removed
20811 the magic number return values (123 and 124). Now, if the
20812 expected error occurs, the compiler exits with success (exit value
20813 0). If the compilation completes without seeing that particular
20814 error, the compiler exits with failure (exit value 1). The
20815 makefile in mcs/errors has been changed to handle the new behaviour.
20817 * report.cs: Made 'expected error' number a property and renamed
20818 it from 'Probe' to 'ExpectedError'.
20820 * genericparser.cs: Removed error handling support, since it is
20821 now all done by Report class.
20823 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
20824 class, so parse() no longer returns an int.
20826 * namespace.cs: Use Report.Error instead of GenericParser.error
20828 2002-06-22 Miguel de Icaza <miguel@ximian.com>
20830 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
20831 TypeContainer.AddOperator): At the front of the list put the
20832 explicit implementations, so they get resolved/defined first.
20834 2002-06-21 Miguel de Icaza <miguel@ximian.com>
20836 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
20837 interface type is implemented by this TypeContainer. Used during
20838 explicit interface implementation.
20840 (Property.Define, Indexer.Define, Method.Define): Validate that
20841 the given interface in the explicit implementation is one of the
20842 base classes for the containing type.
20844 Also if we are explicitly implementing an interface, but there is
20845 no match in the pending implementation table, report an error.
20847 (Property.Define): Only define the property if we are
20848 not explicitly implementing a property from an interface. Use the
20849 correct name also for those properties (the same CSC uses,
20850 although that is really not needed).
20852 (Property.Emit): Do not emit attributes for explicitly implemented
20853 properties, as there is no TypeBuilder.
20855 (Indexer.Emit): ditto.
20857 Hiding then means that we do not really *implement* a pending
20858 implementation, which makes code fail.
20860 2002-06-22 Martin Baulig <martin@gnome.org>
20862 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20863 the return value of Object.GetType(). [FIXME: we need to do this whenever
20864 we get a type back from the reflection library].
20866 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20868 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20870 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20872 * attribute.cs: Return null if we can not look up the type.
20874 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20875 the interface types found.
20877 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20878 interface types found.
20880 * typemanager.cs (GetInterfaces): Make this routine returns alll
20881 the interfaces and work around the lame differences between
20882 System.Type and System.Reflection.Emit.TypeBuilder in the results
20883 result for GetInterfaces.
20885 (ExpandInterfaces): Given an array of interface types, expand and
20886 eliminate repeated ocurrences of an interface. This expands in
20887 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20890 2002-06-21 Martin Baulig <martin@gnome.org>
20892 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20895 2002-06-21 Martin Baulig <martin@gnome.org>
20897 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20898 and called with one of the core types, return the corresponding typebuilder for
20901 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20904 2002-06-21 Martin Baulig <martin@gnome.org>
20906 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20907 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20908 (Expression.ConvertReferenceExplicit): Likewise.
20910 * expression.cs (ElementAccess.DoResolve): Likewise.
20911 (ElementAccess.DoResolveLValue): Likewise.
20913 2002-06-10 Martin Baulig <martin@gnome.org>
20915 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20916 add the "value" parameter to the parameter list.
20918 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20921 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20923 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20924 the argument to an int, uint, long or ulong, per the spec. Also
20925 catch negative constants in array creation.
20927 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20929 * class.cs: do not allow the same interface to appear twice in
20930 the definition list.
20932 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20934 * ecore.cs: don't use ldlen with System.Array.
20936 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20938 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20940 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20942 * modifiers.cs: produce correct field attributes for protected
20943 internal. Easy fix so miguel can work on ther harder stuff:-)
20945 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20947 * pending.cs: New file. Move the code from class.cs here.
20948 Support clearning the pending flag for all methods (when not doing
20949 explicit interface implementation).
20951 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20953 * rootcontext.cs: added a couple more types needed to bootstrap.
20955 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20957 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20958 constructor in the type, instead of any constructor in the type
20959 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20960 a bug in the Mono runtime when applying the params attribute).
20962 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20963 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20965 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20967 * expression.cs (Unary.ResolveOperator): Use TypeManager
20968 to resolve the type.
20970 2002-06-13 Ravi Pratap <ravi@ximian.com>
20972 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20975 * enum.cs (AddEnumMember): Add support to store the attributes associated
20976 with each member too.
20978 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20979 field builders too - this takes care of the enum member case.
20981 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20983 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20984 address-of operator on both value types and pointers.
20986 2002-06-10 Martin Baulig <martin@gnome.org>
20988 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20989 PropertyBuilder to the `property_builders' list.
20991 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20992 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20993 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20994 find any indexers which are inherited from an interface.
20996 2002-06-09 Martin Baulig <martin@gnome.org>
20998 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20999 the same type as the constant if necessary. There's also a test-130.cs
21002 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
21004 * typemanager.cs (TypeManager.ChangeType): Previously known as
21005 Enum.ChangeEnumType().
21007 2002-06-09 Martin Baulig <martin@gnome.org>
21009 * expression.cs (Cast.TryReduce): Added support for consts.
21011 2002-06-08 Ravi Pratap <ravi@ximian.com>
21013 * class.cs (Accessor): Hold attributes information so we can pass
21016 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
21017 Modify to pass in attributes attached to the methods.
21019 (add_accessor_declaration, remove_accessor_declaration): Ditto.
21021 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
21022 to handle the Accessor kind :-)
21024 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
21026 2002-06-08 Martin Baulig <martin@gnome.org>
21028 * expression.cs (Unary.TryReduceNegative): Added support for
21031 2002-06-08 Martin Baulig <martin@gnome.org>
21033 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
21034 name can't be found in the `defined_names' - the caller will do a
21035 MemberLookup in this case and thus find methods in System.Enum
21036 such as Enum.IsDefined().
21038 2002-06-08 Martin Baulig <martin@gnome.org>
21040 * enum.cs (Enum.ChangeEnumType): This is a custom version of
21041 Convert.ChangeType() which works with TypeBuilder created types.
21042 (Enum.LookupEnumValue, Enum.Define): Use it here.
21044 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
21045 `TypeBuilder.BaseType != null' check.
21046 (TypeContainer.FindMembers): Only lookup parent members if we
21047 actually have a parent.
21048 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
21049 (ConstructorInitializer.Resolve): Likewise.
21051 * interface.cs (Interface.FindMembers): Added
21052 `TypeBuilder.BaseType != null' check.
21054 * rootcontext.cs (RootContext.ResolveCore): Added
21055 "System.Runtime.CompilerServices.IndexerNameAttribute" to
21056 classes_second_stage.
21058 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
21059 debug_type and trace_type when compiling with --nostdlib.
21061 2002-06-07 Martin Baulig <martin@gnome.org>
21063 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
21064 (AddField): Set it to true when adding a non-static field.
21065 (DefineType): Use `have_nonstatic_fields' to find out whether we
21066 have non-static fields, not `Fields != null'.
21068 2002-06-02 Miguel de Icaza <miguel@ximian.com>
21070 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
21071 dereferencing a null on the static-field code path)
21073 2002-05-30 Martin Baulig <martin@gnome.org>
21075 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
21076 to take command line arguments. Use reflection to call the new
21077 custom `Initialize' function on the symbol writer and pass it the
21078 command line arguments.
21080 * driver.cs (--debug-args): New command line argument to pass command
21081 line arguments to the symbol writer.
21083 2002-05-28 Miguel de Icaza <miguel@ximian.com>
21085 * assign.cs (DoResolve): Forgot to do the implicit conversion to
21086 the target type for indexers and properties. Thanks to Joe for
21089 2002-05-27 Miguel de Icaza <miguel@ximian.com>
21091 * typemanager.cs (MethodFlags): returns the method flags
21092 (Obsolete/ShouldIgnore) that control warning emission and whether
21093 the invocation should be made, or ignored.
21095 * expression.cs (Invocation.Emit): Remove previous hack, we should
21096 not do this on matching a base type, we should do this based on an attribute
21098 Only emit calls to System.Diagnostics.Debug and
21099 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
21100 on the command line.
21102 * rootcontext.cs: Global settings for tracing and debugging.
21104 * cs-tokenizer.cs (define): New utility function to track
21105 defines. Set the global settings for TRACE and DEBUG if found.
21107 2002-05-25 Ravi Pratap <ravi@ximian.com>
21109 * interface.cs (Populate*): Pass in the TypeContainer as well as
21110 the DeclSpace as parameters so that we can create EmitContexts and
21111 then use that to apply attributes etc.
21113 (PopulateMethod, PopulateEvent, PopulateProperty)
21114 (PopulateIndexer): Apply attributes everywhere.
21116 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
21119 (ApplyAttributes): Update accordingly.
21121 We now apply interface attributes for all members too.
21123 2002-05-26 Miguel de Icaza <miguel@ximian.com>
21125 * class.cs (Indexer.Define); Correctly check if we are explicit
21126 implementation (instead of checking the Name for a ".", we
21127 directly look up if the InterfaceType was specified).
21129 Delay the creation of the PropertyBuilder.
21131 Only create the PropertyBuilder if we are not an explicit
21132 interface implementation. This means that explicit interface
21133 implementation members do not participate in regular function
21134 lookups, and hence fixes another major ambiguity problem in
21135 overload resolution (that was the visible effect).
21137 (DefineMethod): Return whether we are doing an interface
21140 * typemanager.cs: Temporary hack until we get attributes in
21141 interfaces (Ravi is working on that) and we get IndexerName
21142 support in interfaces.
21144 * interface.cs: Register the indexers as properties.
21146 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
21147 warning, I have verified that this is a bug in the .NET runtime
21148 (JavaScript suffers of the same problem).
21150 * typemanager.cs (MemberLookup): When looking up members for
21151 interfaces, the parent of an interface is the implicit
21152 System.Object (so we succeed in searches of Object methods in an
21153 interface method invocation. Example: IEnumerable x; x.ToString
21156 2002-05-25 Miguel de Icaza <miguel@ximian.com>
21158 * class.cs (Event): Events should also register if they do
21159 implement the methods that an interface requires.
21161 * typemanager.cs (MemberLookup); use the new GetInterfaces
21164 (GetInterfaces): The code used to lookup interfaces for a type is
21165 used in more than one place, factor it here.
21167 * driver.cs: Track the errors at the bottom of the file, we kept
21170 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
21171 instance if the method we are calling is static!
21173 2002-05-24 Miguel de Icaza <miguel@ximian.com>
21175 * attribute.cs (ApplyAttributes): Make this function filter out
21176 the IndexerName attribute (as that attribute in reality is never
21177 applied) and return the string constant for the IndexerName
21180 * class.cs (TypeContainer.Emit): Validate that all the indexers
21181 have the same IndexerName attribute, and if so, set the
21182 DefaultName attribute on the class.
21184 * typemanager.cs: The return value might contain other stuff (not
21185 only methods). For instance, consider a method with an "Item"
21186 property and an Item method.
21188 * class.cs: If there is a problem with the parameter types,
21191 2002-05-24 Ravi Pratap <ravi@ximian.com>
21193 * ecore.cs (ImplicitConversionExists): Wrapper function which also
21194 looks at user defined conversion after making a call to
21195 StandardConversionExists - we need this for overload resolution.
21197 * expression.cs : Update accordingly the various method calls.
21199 This fixes 2 bugs filed against implicit user defined conversions
21201 2002-05-22 Miguel de Icaza <miguel@ximian.com>
21203 * statement.cs: Track the result of the assignment.
21205 2002-05-21 Miguel de Icaza <miguel@ximian.com>
21207 * expression.cs (MemberAccess): Improved error reporting for
21208 inaccessible members.
21210 2002-05-22 Martin Baulig <martin@gnome.org>
21212 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
21213 itself with debugging support.
21215 2002-05-22 Martin Baulig <martin@gnome.org>
21217 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
21218 Removed, this isn't needed anymore.
21220 2002-05-20 Martin Baulig <martin@gnome.org>
21222 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
21223 be underlying type for an enum.
21225 2002-05-20 Miguel de Icaza <miguel@ximian.com>
21227 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
21228 that splits out the loading of just the core types.
21230 * rootcontext.cs (ResolveCore): Split the struct resolution in
21231 two, so we can load the enumeration underlying types before any
21234 * expression.cs (Is): Bandaid until we fix properly Switch (see
21235 bug #24985 for details).
21237 * typemanager.cs (ImplementsInterface): The hashtable will contain
21238 a null if there are no interfaces implemented.
21240 2002-05-18 Miguel de Icaza <miguel@ximian.com>
21242 * cs-parser.jay (indexer_declarator): It is fine to have array
21245 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21247 * typemanager.cs: (RegisterBuilder): New function used to register
21248 TypeBuilders that implement interfaces. Since
21249 TypeBuilder.GetInterfaces (as usual) does not work with lame
21251 (AddUserType): register interfaces.
21253 (ImplementsInterface): Use the builder_to_ifaces hash if we are
21254 dealing with TypeBuilder. Also, arrays are showing up as
21255 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
21256 methods can not be invoked on them!
21258 * ecore.cs (ExplicitReferenceConversionExists): Made public.
21259 (ImplicitReferenceConversionExists): Split out from
21260 StandardConversionExists.
21262 * expression.cs (As): We were only implementing one of the three
21263 cases for the as operator. We now implement them all.
21264 (Is): Implement the various other cases for Is as well.
21266 * typemanager.cs (CACHE): New define used to control if we want or
21267 not the FindMembers cache. Seems to have a negative impact on
21268 performance currently
21270 (MemberLookup): Nested types have full acess to
21271 enclosing type members
21273 Remove code that coped with instance/static returns for events, we
21274 now catch this in RealFindMembers.
21276 (RealFindMembers): only perform static lookup if the instance
21277 lookup did not return a type or an event.
21279 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21281 * assign.cs (CompoundAssign): We pass more semantic information
21282 now to Compound Assignments than we did before: now we have all
21283 the information at hand, and now we resolve the target *before* we
21284 do the expression expansion, which allows the "CacheValue" method
21285 to have the effect we intended (before, a [x] += 1 would generate
21286 two differen ArrayAccess expressions from the ElementAccess,
21287 during the resolution process).
21289 (CompoundAssign.DoResolve): Resolve target and original_source here.
21291 2002-05-16 Miguel de Icaza <miguel@ximian.com>
21293 * expression.cs (ArrayAccess): dropped debugging information.
21295 * typemanager.cs: Small bug fix: I was always returning i_members,
21296 instead of one of i_members or s_members (depending on which had
21299 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
21300 method is invoked before any code generation takes place, and it
21301 is a mechanism to inform that the expression will be invoked more
21302 than once, and that the method should use temporary values to
21303 avoid having side effects
21305 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
21307 * ecore.cs (Expression.CacheTemporaries): Provide empty default
21310 * expression.cs (Indirection, ArrayAccess): Add support for
21311 CacheTemporaries in these two bad boys.
21313 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
21314 ldobj or ldind_ref.
21315 (StoreFromPtr): Handle stobj as well.
21317 * expression.cs (UnaryMutator): Share more code.
21319 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
21320 down: I was not tracking the Filter function as well, which
21321 was affecting the results of the cache.
21323 2002-05-15 Miguel de Icaza <miguel@ximian.com>
21325 * attribute.cs: Remove the hack to handle the CharSet property on
21328 2002-05-14 Miguel de Icaza <miguel@ximian.com>
21330 * attribute.cs (DoResolve): More uglyness, we now only try to
21331 resolve the attribute partially, to extract the CharSet
21332 information (only if we are a StructLayout attribute). Otherwise
21334 (GetExtraTypeInfo): Add some code to conditionally kill in the
21335 future this. I am more and more convinced that the .NET
21336 framework has special code to handle the attribute setting on
21339 * expression.cs (IsParamsMethodApplicable): Revert my previous
21340 foreach change here, it was wrong.
21342 2002-05-13 Miguel de Icaza <miguel@ximian.com>
21344 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
21345 (pp_expr): do not abort on unknown input, just return.
21346 (eval): abort if there are pending chars.
21348 * attribute.cs (Attribute.Resolve): Positional parameters are
21349 optional. Deal with that case.
21351 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
21352 the Ansi/Unicode/Auto information for the type.
21354 (TypeContainer.DefineType): instantiate the EmitContext here, as
21355 we will be using it during the type definition (to resolve
21356 attributes) and during the emit phase.
21358 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
21359 to pull type information out of the attributes
21361 (Attribute.Resolve): track the constructor builder, and allow for
21362 multiple invocations (structs and classes will use this).
21364 * ecore.cs (MemberLookupFinal): new version with all the
21365 parameters customizable.
21367 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
21368 constructors. Return if the result value is null (as the error
21369 would have been flagged already by MemberLookupFinal)
21371 Do not allow instances of abstract classes or interfaces to be
21374 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
21375 We have to compare the assembly property here when dealing with
21376 FamANDAssem and Assembly access modifiers, because we might be
21377 creating an assembly from *modules* (that means that we are not
21378 getting TypeBuilders for types defined in other modules that are
21379 part of this assembly).
21381 (Method.Emit): If the method is marked abstract and has a body,
21384 (TypeContainer.DefineMembers): If both the defined member and the
21385 parent name match are methods, then do not emit any warnings: let
21386 the Method.Define routine take care of flagging warnings. But if
21387 there is a mismatch (method overrides something else, or method is
21388 overriwritten by something, then emit warning).
21390 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
21391 set to null, this means `do not check for the return type on the
21394 (Method.Define): set the return type for the method signature to
21395 null, so that we get methods with the same name and parameters and
21396 different return types. This is used to flag warning 114 (you are
21397 hiding a method, and you probably want to use the new/override
21400 * typemanager.cs (MemberLookup): Implemented proper access
21401 control, closing a long standing set of bug reports. The problem
21402 was that the Framework only has two bits: Public and NonPublic,
21403 and NonPublic includes private and protected methods, but we need
21404 to enforce the FamANDAssem, FamOrAssem and Family.
21406 2002-05-11 Miguel de Icaza <miguel@ximian.com>
21408 * statement.cs (GotoCase): Return true: Ammounts to giving up
21409 knowledge on whether we return or not, and letting the other case
21410 be responsible for it.
21412 2002-05-10 Miguel de Icaza <miguel@ximian.com>
21414 * driver.cs: Do not load directories for each file processed, only
21415 do it if there is a pattern.
21417 * ecore.cs: Report readonly assigns here as well, as we might have
21418 been resolved only by MemberAccess.
21420 (SimpleName.SimpleNameResolve): Also be useful for LValue
21421 resolution. We need this to propagate assign to local readonly variables
21423 * typemanager.cs: Use a ptrhashtable for the criteria, because we
21424 do not want to reuse potential criteria memory.
21426 * class.cs (MyEventBuilder): Set reflected_type;
21428 * ecore.cs (Constantify): Added support for constifying bools.
21430 (RootContext.LookupType): Added a cache for values looked up in
21431 the declaration space.
21433 * typemanager.cs (FindMembers): Now is a front-end to
21434 RealFindMembers, and provides a two-level hashtable-based cache to
21437 15% performance improvement: from 22.5 to 19.2 seconds.
21439 * expression.cs (IsParamsMethodApplicable): use foreach.
21440 (Invocation.DoResolve): ditto.
21441 (New.DoResolve): ditto.
21442 (ArrayCreation.DoResolve): ditto.
21444 * ecore.cs (FindMostEncompassingType): use foreach.
21446 * delegate.cs (NewDelegate.DoResolve): Use foreach
21448 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
21449 (RemoveMethods): use foreach.
21451 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
21452 nested foreach statements instead of for, and also break out of
21453 the inner loop once a match is found.
21455 (Invocation.OverloadResolve): Use foreach, simplify the code.
21457 2002-05-08 Miguel de Icaza <miguel@ximian.com>
21459 * cfold.cs (BinaryFold): During an enumeration evaluation context,
21460 we actually unwrap the expression to allow for extra information
21463 * expression.cs: Use Shr_Un on unsigned operations.
21465 2002-05-08 Ravi Pratap <ravi@ximian.com>
21467 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
21468 applicable operators was not being considered correctly. This closes
21469 the bug Miguel reported.
21471 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
21473 * attribute.cs: check that the type derives from System.Attribute
21474 and report the correct error in that case (moved the duplicate code to
21475 its own method, too).
21477 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
21479 * attribute.cs: lookup attribute type name as the spec says: first the
21480 bare attribute name and then name + "Attribute" (nant compiles with
21481 mcs after this fix).
21483 2002-05-07 Miguel de Icaza <miguel@ximian.com>
21485 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
21486 Because of the way we parse things, we should try to see if a
21487 UIntConstant can fit in an integer.
21489 2002-05-07 Ravi Pratap <ravi@ximian.com>
21491 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
21492 when we are in an explicit context.
21494 (ConvertReferenceExplicit): When converting from Iface type S to Class
21495 T make sure the rules are implemented as an OR.
21497 * parameter.cs (ParameterType): Make it a property for now although the
21498 purpose really isn't anything immediate.
21500 * expression.cs (Is*Applicable): Do better checking on the parameter type
21501 of a ref/out parameter. The ones from the system assemblies are already
21502 marked with the correct type so we don't need to do any correction.
21504 * ecore.cs (StandardConversionExists): Conversion from Interface types to
21505 the object type is standard too so include that.
21507 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21509 * ecore.cs (StandardConversionExists): Augment with missing code:
21510 deal with IntConstant, LongConstants and Enumerations.
21512 * assign.cs: Report the error, instead of failing silently
21514 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
21515 typecontainer that they are declared, because the
21516 typecontainer/namespace will have the list of using clauses that
21517 need to be applied.
21519 Assembly Attributes were escaping the normal registration
21522 (EmitCode): Apply attributes within an EmitContext that represents
21523 the container they were declared on.
21525 * cs-parser.jay: Track bases for structs. How did I get this wrong?
21527 2002-05-06 Ravi Pratap <ravi@ximian.com>
21529 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
21530 Revamp completely - make much cleaner as we now operate only
21533 (FindMostSpecificSource, FindMostSpecificTarget): New methods
21534 to implement the logic detailed in the spec more correctly.
21536 (UserDefinedConversion): Update accordingly.
21538 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21540 * statement.cs: Return flow analysis information up.
21542 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
21545 (token): Do not consume an extra character before calling
21548 2002-05-06 Piers Haken <piersh@friskit.com>
21550 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
21552 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21554 * class.cs (Constructor.Emit): Set the IsStatic flag in the
21555 EmitContext during the instance constructor initializer
21556 resolution, to stop access to instance variables.
21558 This is mandated by the spec, last paragraph of the `constructor
21559 initializers' section.
21561 2002-05-05 Miguel de Icaza <miguel@ximian.com>
21563 * cs-parser.jay, class.cs (Accessor): new class used to represent
21564 an accessor (get or set). In the past we used `null' to represent
21565 a missing accessor. But this is ambiguous because there was no
21566 way to tell in abstract indexers/properties if one of them was
21569 Now there is a way of addressing that.
21571 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
21572 instead of FindMembers.
21574 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
21575 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
21577 * attribute.cs: Treat indexers and properties as the same in terms
21578 of applying attributes
21580 * ecore.cs (FindMostEncompassedType): Use statically initialized
21581 EmptyExpressions()s like we do elsewhere to avoid creating useless
21582 objects (and we take this out of the tight loop).
21584 (GetConversionOperators): Move the code to extract the actual
21585 operators to a separate routine to clean things up.
21587 2002-05-04 Miguel de Icaza <miguel@ximian.com>
21589 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
21590 events are always registered FieldBuilders.
21592 * class.cs (FieldBase): New class shared by Fields
21594 * delegate.cs: If we are a toplevel delegate, use our full name.
21595 If we are a nested delegate, then only use our tail name.
21597 2002-05-02 Ravi Pratap <ravi@ximian.com>
21599 * expression.cs (IsApplicable): Ensure that we add the "&" to
21600 ref/out types before comparing it with the type of the argument.
21602 (IsParamsMethodApplicable): Ditto.
21604 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
21607 * delegate.cs : Handle the case when we have more than one applicable
21608 method. Flag an error only when we finish checking all.
21610 2002-05-02 Miguel de Icaza <miguel@ximian.com>
21612 * expression.cs: Add support for boolean static initializers.
21614 2002-05-01 Miguel de Icaza <miguel@ximian.com>
21616 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
21618 * parameter.cs (ComputeParameterTypes,
21619 ComputeAndDefineParameterTypes): Better error handling: now we
21620 clear the `types' cache if we fail during any of the type lookups.
21621 We also return the status code correctly to our caller
21623 * delegate.cs: If we fail to define a delegate, abort the extra
21626 * expression.cs (Binary.ResolveOperator): for
21627 operator==(object,object) and operator !=(object, object) we also
21628 have to verify that there is an implicit conversion from one to
21631 (ArrayAccess.DoResolve): Array Access can operate on
21634 2002-04-30 Miguel de Icaza <miguel@ximian.com>
21636 * assign.cs (CompoundAssign): A new class used as a "flag" that
21637 the assignment actually is happening as part of a compound
21638 assignment operator.
21640 During compound assignment, a few new rules exist to enable things
21647 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
21648 to the type of x) if y is implicitly convertible to the type of x,
21649 and the operator is a builtin operator and the return type of the
21650 operator is explicitly convertible to the type of x.
21652 * rootcontext.cs: Reset warning level to 2. 4 catches various
21653 "interesting" features in mcs, we must clean this up at some
21654 point, but currently am trying to kill other bugs ;-)
21656 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
21657 in container classes as well.
21659 * expression.cs (Binary.ResolveOperator): Handle string case
21660 before anything else (as operator overloading does emit an error
21661 before doing anything else).
21663 This code could go away when we move to a table driven model, but
21664 i could not come up with a good plan last night.
21666 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
21668 * typemanager.cs (CSharpName): reimplementation using regex.
21669 * class.cs: added null check for fields in Emit
21670 * rootcontext.cs: set warninglevel to 4
21672 2002-04-29 Miguel de Icaza <miguel@ximian.com>
21674 * typemanager.cs (CSharpName): reimplemented with Lupus
21677 2002-04-28 Miguel de Icaza <miguel@ximian.com>
21679 * statement.cs (If): correclty implement Resolve, because we were
21680 not catching sem errors in there. The same process is needed
21682 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
21685 (Statement.Warning_DeadCodeFound): Factorize code.
21686 (While): Report dead code here too.
21688 (Statement): Added Resolve virtual method to allow
21689 for resolution split from the emit code.
21691 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21693 * statement.cs (EmitBoolExpression): No longer try to resolve the
21695 (MakeBoolean): New utility function that resolve, implicitly
21696 converts to boolean and tags the expression.
21699 (If, Do): Implement dead code elimination.
21700 (While): Implement loop inversion
21702 (Do, While, For, If): Resolve the expression prior to calling our
21705 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
21708 - added method Report28 (warning: program has more than one entry point)
21709 - added method IsEntryPoint, implements paragraph 10.1 of the spec
21710 - modified method Method.Define, the part at the end of the method
21712 * rootcontext.cs: added static public Location EntryPointLocation;
21714 * ../errors/cs0028.cs : Add test case for the above warning.
21717 - modified method CSharpName to allow arrays of primitive type to
21718 be printed nicely (e.g. instead of System.Int32[][] it now prints
21720 - added method CSharpSignature: returns the signature of a method
21721 in string format to be used in reporting errors, warnings, etc.
21723 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
21726 2002-04-26 Ravi Pratap <ravi@ximian.com>
21728 * delegate.cs (Define): Fix extremely silly bug where I was
21729 setting the type of the 'object' parameter of the BeginInvoke
21730 method to System.IAsyncResult instead of System.Object ;-)
21732 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21734 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
21737 (Constructor.Emit): return if we fail to initialize the
21738 constructor. Another door closed!
21740 * expression.cs (New.DoResolve): Improve error message (from -6 to
21741 1501). Use DeclaredOnly lookup to find the exact constructor.
21743 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
21744 loop. This is useful.
21746 * cs-parser.jay: Adjust the default parameters so that destructors
21747 have the proper signature.
21749 2002-04-26 Martin Baulig <martin@gnome.org>
21751 * driver.cs (LoadAssembly): If `assembly' contains any characters
21752 which are only valid in path names and not in assembly names
21753 (currently slash, backslash and point), use Assembly.LoadFrom ()
21754 instead of Assembly.Load () on the `assembly' (before iteration
21755 over the link_paths).
21757 2002-04-26 Martin Baulig <martin@gnome.org>
21759 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
21761 2002-04-25 Miguel de Icaza <miguel@ximian.com>
21763 * class.cs (Property): use the new typemanager.MemberLookup
21765 (TypeContainer.MemberLookup): Implement using the
21766 TypeManager.MemberLookup now.
21768 * typemanager.cs: Make MemberLookup a function of the TypeManager,
21769 and return MemberInfos, so that these can be used without an
21770 EmitContext (what we had before).
21772 2002-04-24 Miguel de Icaza <miguel@ximian.com>
21774 * expression.cs: Fix the case where the argument to params if the
21775 type of the params. I omitted handling this before. Fixed
21777 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21779 * driver.cs: Call BootCorlib_PopulateCoreType
21781 * class.cs (Property.CheckBase): Check for properties only, not
21784 * interface.cs: Temporary hack: try/catch around the
21785 CustomAttributeBuilder, because I am getting an exception that I
21788 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
21789 types whose definitions are required to be there (attributes are
21790 defined before standard types).
21792 Compute definitions as we boot the various types, as they are used
21793 immediately (value_type class will need object_type, but if we do
21794 not initialize object_type, we will pass a null, which will let
21795 the runtime pick the System.Object from the existing corlib, which
21796 is not what we want).
21798 2002-04-22 Patrik Torstensson <totte@labs2.com>
21800 * cs-tokenizer.cs: fixed a number of trim() issues.
21802 2002-04-22 Ravi Pratap <ravi@ximian.com>
21804 * expression.cs (Argument.Type): Ensure that we return the correct
21805 type when we have out or ref parameters [in which case we
21808 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21810 * class.cs (Property, Indexer): Allow extern modifier in there.
21812 * typemanager.cs (InitBaseTypes): Initializes object_type and
21813 value_type, since those will be used early on during the bootstrap
21814 process to compile corlib.
21816 (InitCoreTypes): Move code from here to InitBaseTypes.
21818 2002-04-21 Miguel de Icaza <miguel@ximian.com>
21820 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
21821 single-dimension arrays as using the ldlen opcode.
21823 Daniel Lewis discovered this optimization.
21825 * typemanager.cs: Add signature for System.Array::get_Length
21827 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21829 * statement.cs: report the error when the foreach does not apply to an
21830 array nor a collection.
21832 2002-04-19 Miguel de Icaza <miguel@ximian.com>
21834 * expression.cs: Add implicit conversions to the operator ~.
21836 * constant.cs (DecimalConstant.Emit): Emit decimal value.
21838 * typemanager.cs: Locate the decimal constructor.
21840 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21842 * attribute.cs: use the new property of TypeOf.
21843 * expression.cs: added 'get' property around typearg.
21845 These changes fix a build breaker reported by NickD. Is this the
21846 correct way to fix? If not, please, revert my changes and make it
21849 2002-04-17 Miguel de Icaza <miguel@ximian.com>
21851 * attribute.cs: Add support for typeof in attribute invocations.
21852 I am not sure that this is right though.
21854 2002-04-14 Duncan Mak <duncan@ximian.com>
21856 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
21857 Binary.Operator.Division case.
21859 2002-04-13 Ravi Pratap <ravi@ximian.com>
21861 * class.cs (DefineType): Ensure that we do a proper check on
21862 attribute types and also register it with the TypeManager.
21864 (TypeContainer.Targets): The default for attribute types is
21865 AttributeTargets.All.
21867 * attribute.cs (ApplyAttributes): Registering the attribute type
21868 is done elsewhere, not when we discover we have a Usage attribute.
21870 2002-04-12 Ravi Pratap <ravi@ximian.com>
21872 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21873 and get rid of is_delegate parameter.
21875 * everywhere : update.
21877 2002-04-12 Ravi Pratap <ravi@ximian.com>
21879 * cs-parser.jay (compilation_unit): Revamp completely to use
21880 some new ideas that I got from Rhys' grammar to solve the problems
21881 with assembly level attributes.
21883 (outer_declaration): New grammar production.
21885 (attribute_sections): Add.
21887 (opt_attributes): Base on attribute_sections
21889 (namespace_declaration): Allow opt_attributes to tackle the case
21890 when we have assembly level attributes - we are clever in this
21893 * attribute.cs (ApplyAttributes): Do not worry about assembly
21894 attributes in the non-global context.
21896 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21897 instead of SetGlobalAttributes.
21899 * class.cs, rootcontext.cs : Ensure we define and generate
21900 attribute types before anything else.
21902 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21903 and flag the new error -20 for the case when the attribute type
21904 does not have valid targets specified. csc does not catch this.
21906 * ../errors/errors.txt : update for error # -20
21908 2002-04-11 Ravi Pratap <ravi@ximian.com>
21910 * support.cs (InternalParameters.ParameterModifier): Do some null
21911 checking and return sane values.
21913 * class.cs (Method.Define): If we are a PInvoke method, ensure
21914 that we are static and extern. Report error # 601
21916 * ../errors/cs0601.cs : Add test case for the above error.
21918 2002-04-07 Ravi Pratap <ravi@ximian.com>
21920 * rootcontext.cs (attribute_types): We need to keep type of
21921 all attribute types separately and emit code for them first.
21923 (RegisterAttribute) : Implement.
21925 * class.cs (DefineType): Check if the current Type is a custom
21926 attribute type and register it accordingly.
21928 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21929 adding the first attribute twice and rename to
21931 (SetGlobalAttributes): this.
21933 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21936 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21937 if we are processing global arguments. Hmm, I am unsure of this.
21939 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21941 * expression.cs: added static array of strings to avoid calling
21942 Enum.ToString () for Operator in Binary. Significant recover of
21945 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21947 * class.cs (FindMembers): Allow the Builders of the various
21948 members to be null. If they are skip them. This only happens
21949 during the PInvoke declaration.
21951 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21953 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21954 failure, so we do not keep going afterwards.
21956 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21957 wanted to pass `false' as the `is_delegate' argument. If this is
21958 the case, why not use delegate_type == null to mean `is_delegate =
21959 false' and anything else as is_delegate = true.
21961 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21963 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21964 code for the section, not the beginning of the tests.
21966 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21968 * cfold.cs: Handle operator + (Enum x, Underlying x)
21970 * expression.cs (Binary): same. Warn about errors where we have
21971 Enum/Enum in operator + as well.
21973 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21976 - added support for switch(bool)
21977 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21978 - add TableSwitchEmit() to handle table-based switch statements
21980 2002-04-05 Ravi Pratap <ravi@ximian.com>
21982 * expression.cs (Invocation.OverloadResolve): Factor out code which
21983 does parameter compatibility checking with arguments so that we can
21984 re-use the code even from Delegate.VerifyApplicability
21986 (VerifyArgumentsCompat): Move above code here.
21988 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21989 and instead make a call to the above method.
21991 2002-03-31 Ravi Pratap <ravi@ximian.com>
21993 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21994 We use it to keep track of classes which are attribute types.
21996 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21998 * delegate.cs (Delegate.Define): Correctly define the types in the
21999 presence of fixed and array parameters.
22001 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
22004 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
22005 include NonPublic after the first iteration.
22007 * class.cs (Indexer.CheckBase): Only check if both parents are
22010 * cs-parser.jay (accessor_body): If empty, set to null.
22012 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
22013 same code path here to resolve constants names that we did have in
22014 MemberAccess.DoResolve. There is too much code duplicated here.
22016 2002-04-01 Miguel de Icaza <miguel@ximian.com>
22018 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
22020 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
22023 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
22024 tokens, numbers and strings.
22026 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
22029 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
22030 asyncronous parameters and the regular parameters.
22032 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
22033 specify the target directory.
22035 * expression.cs: (This.DoResolve): Simplify
22036 (As.Emit): Optimize, do not generate IsInst if the expression is
22037 always of the given type.
22039 (Is.DoResolve): Bug fix, we were reporting both always/never for
22042 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
22043 creating too many unnecessary arrays.
22045 2002-03-31 Miguel de Icaza <miguel@ximian.com>
22047 * class.cs (EmitFieldInitializer): Use Assign expression to assign
22048 fields instead of rolling our own initializer. Takes care of all
22049 implicit conversions, and drops unnecessary static checks/argument.
22051 2002-03-31 Dick Porter <dick@ximian.com>
22053 * driver.cs: use the GetDirectories() return values properly, and
22054 use "/" as path separator.
22056 2002-03-30 Miguel de Icaza <miguel@ximian.com>
22058 * expression.cs (Unary): Optimize - - expr into expr.
22059 (Binary): Optimize a + (-b) into a -b.
22061 * codegen.cs (CodeGen): Made all methods static.
22063 2002-03-29 Miguel de Icaza <miguel@ximian.com>
22067 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
22068 TypeBuilder property.
22070 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
22073 * tree.cs: Removed the various RecordXXXX, and replaced with a
22074 single RecordDecl. Removed all the accessor methods, and just
22075 left a single access point Type
22077 * enum.cs: Rename DefineEnum to DefineType.
22079 * decl.cs: New abstract method `DefineType' used to unify the
22080 Defines for Enumerations, Interfaces, TypeContainers and
22083 (FindType): Moved LookupInterfaceOrClass here. Moved the
22084 LookupBaseClasses method that used to live in class.cs and
22085 interface.cs here, and renamed to FindType.
22087 * delegate.cs: Implement DefineType. Take advantage of the
22088 refactored pattern for locating the parent builder without taking
22089 the parent_builder argument (which we know does not work if we are
22090 nested, and triggering a toplevel definition).
22092 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22094 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
22095 accessibility of a member has changed during override and report
22098 * class.cs (Method.Define, Property.Define): Only complain on
22099 overrides if the method is private, any other accessibility is
22100 fine (and since we just checked the permission is the same, we are
22103 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
22104 and elif are processed always. The other pre-processing
22105 directives are only processed if we are "taking" the path
22107 2002-03-29 Martin Baulig <martin@gnome.org>
22109 * class.cs (Method.Emit): Only emit symbolic debugging info if the
22110 current location is not Null.
22112 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
22113 a separate method so we can profile it.
22115 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
22116 `span.Seconds' are just seconds, but no minutes or hours.
22117 (MainDriver): Profile the CodeGen.SaveSymbols calls.
22119 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22121 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
22122 Remove the gratuitous set of Final:
22124 // If an interface implementation, then we can set Final.
22125 if (((flags & MethodAttributes.Abstract) == 0) &&
22126 implementing.DeclaringType.IsInterface)
22127 flags |= MethodAttributes.Final;
22129 I do not know what I was smoking when I used that.
22132 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
22133 step into fixing the name resolution issues for delegates and
22134 unifying the toplevel name resolution.
22136 2002-03-28 Martin Baulig <martin@gnome.org>
22138 * class.cs (Method.Emit): If we have a symbol writer, call its
22139 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
22140 tell it about the current method.
22142 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
22143 writer that we're going to emit the first byte of IL code for a new
22144 statement (a new source line).
22145 (EmitContext.EmitTopBlock): If we have a symbol writer, call
22146 EmitContext.Mark() before emitting any code.
22148 * location.cs (SymbolDocument): Return null when we're Null.
22150 * statement.cs (Statement): Moved the `Location loc' variable here.
22151 (Statement.EmitBoolExpression): If we have a symbol writer, call
22152 ec.Mark() before emitting any code to tell it that we're at the
22153 beginning of a new statement.
22154 (StatementExpression): Added `Location' argument to the constructor.
22155 (Block): Added public readonly variable `StartLocation' and public
22156 variable `EndLocation'. The latter is to be set using SetEndLocation().
22157 (Block): Added constructor which takes a start and end location.
22158 (Block.SetEndLocation): New method. This sets the end location.
22159 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
22160 local variables we create.
22161 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
22162 each statement and do also mark the begin and end of the block.
22164 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
22165 tell it the current lexer.Location, use Location.Null for the end of the
22167 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22168 current block, set its end location using SetEndLocation().
22169 (statement_expression): StatementExpression constructor now takes the
22170 lexer.Location as additional argument.
22171 (for_statement, declare_local_variables): Likewise.
22172 (declare_local_variables): When creating a new implicit block, use the
22173 new Block constructor and pass it the lexer.Location.
22175 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22177 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
22178 members also on the parent interfaces recursively.
22180 2002-03-27 Miguel de Icaza <miguel@ximian.com>
22182 * report.cs: Use new formats, since Gonzalo finished the missing
22185 * expression.cs (Binary.ResolveOperator): added missing operator|
22186 operator& and operator^ for bool/bool.
22188 * cs-parser.jay: CheckDef now takes a Location argument that is
22189 used to report errors more precisly (instead of reporting the end
22190 of a definition, we try to track something which is a lot closer
22191 to the source of the problem).
22193 * cs-tokenizer.cs: Track global token use, so we can properly flag
22194 the use of #define/#undef after the first token has been seen.
22196 Also, rename the reportXXXX to Error_DescriptiveName
22198 * decl.cs (DeclSpace.IsTopLevel): Move property here from
22199 TypeContainer, so that Enum and Interface can use this too.
22201 * class.cs (TypeContainer.LookupInterfaceOrClass,
22202 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
22203 `builder' argument. Typically this was used to pass the parent
22204 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
22207 The problem is that a nested class could trigger the definition of
22208 a toplevel class, and the builder would be obviously wrong in that
22211 So we drop this argument, and we compute dynamically the
22212 TypeBuilder/ModuleBuilder (the correct information was available
22213 to us anyways from DeclSpace.Parent)
22215 * interface.cs (Interface.DefineInterface): Drop builder
22216 parameter cleanup like class.cs
22218 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
22221 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
22224 (Try.Emit): Propagate the returns value from the statement.
22226 (Return.Emit): Even if we are leavning
22228 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
22230 * modifiers.cs: Fix the computation of MethodAttributes flags.
22232 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
22234 * driver.cs: allow compilation of files that start with '/'.
22235 Add a default case when checking the argument of --target.
22237 2002-03-25 Miguel de Icaza <miguel@ximian.com>
22239 * interface.cs: Implement the same search algorithm for types in
22240 the interface code.
22242 * delegate.cs: Do not allow multiple definition.
22244 * Recovered ChangeLog that got accidentally amputated
22246 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
22248 * rootcontext.cs: Load manually enum to allow core classes to
22249 contain enumerations.
22251 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
22252 Update to new static methods in TypeManager.
22254 * typemanager.cs (GetMethod, GetConstructor): Use our
22255 implementation of FindMembers to find the members, since during
22256 corlib compilation, the types are TypeBuilders and GetMethod and
22257 GetConstructor do not work.
22259 Make all methods in TypeManager static.
22261 (InitCodeHelpers): Split the functionality from
22262 the InitCodeTypes function.
22264 * driver.cs: Call InitCodeHelpers after we have populated the
22267 * cs-parser.jay (delegate_declaration): we did not used to compute
22268 the delegate name correctly for void delegates.
22270 2002-03-24 Miguel de Icaza <miguel@ximian.com>
22272 * rootcontext.cs (RootContext): Init the interface_resolve_order
22273 and type_container_resolve_order always.
22275 (ResolveCore, BootstrapCorlib_ResolveClass,
22276 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
22277 compiler when compiling with --nostdlib
22279 * class.cs (TypeContainer.DefineType): Check that our parent is
22280 not null. This test is most important when we are bootstraping
22283 * codegen.cs: Split out the symbol writing code.
22285 2002-03-25 Martin Baulig <martin@gnome.org>
22287 * driver.cs (-g): Made -g an alias for --debug.
22289 2002-03-24 Martin Baulig <martin@gnome.org>
22291 * codegen.cs (SymbolWriter): New public variable. Returns the
22292 current symbol writer.
22293 (CodeGen): Added `bool want_debugging_support' argument to the
22294 constructor. If true, tell the ModuleBuild that we want debugging
22295 support and ask it for the ISymbolWriter.
22296 (Save): If we have a symbol writer, call it's Close() method after
22297 saving the assembly.
22299 * driver.c (--debug): New command line argument to create a
22300 debugger information file.
22302 * location.cs (SymbolDocument): New public property. Returns an
22303 ISymbolDocumentWriter object for the current source file or null
22304 if we don't have a symbol writer.
22306 2002-03-21 Miguel de Icaza <miguel@ximian.com>
22308 * driver.cs (LoadAssembly): Correctly return when all the paths
22309 have been tried and not before.
22311 * statement.cs (Switch.Emit): return the actual coverage for this
22312 statement (returns/not-returns)
22314 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
22315 switch of the statement if we are the last switch section. That
22316 kills two problems: try/catch problems (we used to emit an empty
22317 nop at the end) and switch statements where all branches would
22320 2002-03-19 Miguel de Icaza <miguel@ximian.com>
22322 * driver.cs: Add default assemblies (the equivalent to the
22323 Microsoft CSC.RSP file)
22325 * cs-tokenizer.cs: When updating `cols and setting it to zero,
22326 also update tokens_seen and set it to false.
22328 * driver.cs: Implement --recurse for Mike.
22330 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
22331 correctly splitting out the paths.
22333 2002-03-18 Miguel de Icaza <miguel@ximian.com>
22335 * interface.cs (Interface.PopulateProperty): Instead of using
22336 `parent' as the declaration space for the set parameters, use
22339 * support.cs (InternalParameters): InternalParameters constructor
22340 takes a DeclSpace instead of a TypeContainer.
22342 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
22343 types are being initialized, load the address of it before calling
22346 (New): Provide a mechanism to disable the generation of local
22347 value type temporaries when the caller will be providing us with
22348 an address to store it.
22350 (ArrayCreation.EmitDynamicInitializers): Use it.
22352 2002-03-17 Miguel de Icaza <miguel@ximian.com>
22354 * expression.cs (Invocation.EmitArguments): Only probe for array
22355 property if there is more than one argument. Sorry about that.
22357 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
22358 empty param arrays.
22360 * class.cs (Method.LabelParameters): Fix incorrect code path that
22361 prevented the `ParamArrayAttribute' from being applied to the
22364 2002-03-16 Miguel de Icaza <miguel@ximian.com>
22366 * support.cs (ReflectionParameters): Correctly compute whether the
22367 last argument is a params array. Fixes the problem with
22370 * typemanager.cs: Make the assemblies array always be non-null
22371 (empty, but non-null)
22373 * tree.cs (RecordDecl): New function that abstracts the recording
22374 of names. This reports error 101, and provides a pointer to the
22375 previous declaration. Fixes a crash in the compiler.
22377 * cs-parser.jay (constructor_declaration): Update to new grammar,
22378 and provide a constructor_body that can be empty.
22380 2002-03-15 Miguel de Icaza <miguel@ximian.com>
22382 * driver.cs: Add support for --resources.
22384 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
22385 Make all types for the various array helper methods be integer.
22387 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
22388 CheckState to ConvCast.
22390 (ConvCast): Now it takes a `checked' state argument, to avoid
22391 depending on the emit context for the conversion, and just using
22392 the resolve time setting.
22394 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
22395 instead of Invocation.EmitArguments. We do not emit the original
22396 arguments, instead we emit those which have been converted to
22397 unsigned int expressions.
22399 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
22401 * codegen.cs: ditto.
22403 * expression.cs (LocalVariableReference): Drop the use of the
22404 Store function that depended on the variable index.
22406 * statement.cs (VariableInfo): Drop the `Idx' property from this
22407 class, as this is not taking into account the indexes for
22408 temporaries tat we generate during the execution, getting the
22411 * class.cs: First emit class initializers, then call the parent
22414 * expression.cs (Binary): Fix opcode emision.
22415 (UnaryMutator.EmitCode): Support checked code generation
22417 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
22418 matches for events for both the Static and Instance scans,
22419 pointing to the same element. Fix that.
22421 2002-03-14 Miguel de Icaza <miguel@ximian.com>
22423 * rootcontext.cs (ResolveTree): Always set the
22424 interface_resolve_order, because nested interfaces will be calling
22427 * class.cs (GetInterfaceOrClass): Track the same resolution
22428 process used by TypeManager.LookupType. This fixes the nested
22429 type lookups in class declarations (separate path from
22432 (TypeContainer.DefineType): Also define nested interfaces.
22433 (TypeContainer.RegisterOrder): New public function used to
22434 register the order in which child interfaces need to be closed.
22436 Nested interfaces need to be closed after their parents have been
22439 * interface.cs (InterfaceAttr): Put all the logic for computing
22440 the interface attribute here.
22442 (DefineInterface): Register our interface order with the
22443 RootContext or with the TypeContainer depending on the case.
22445 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22447 * cs-parser.jay: rework foreach statement to work with the new
22448 changes to the policy on SimpleNames.
22450 * report.cs: support Stacktrace on warnings as well.
22452 * makefile: drop --unsafe and /unsafe from the compile.
22454 2002-03-13 Ravi Pratap <ravi@ximian.com>
22456 * ecore.cs (StandardConversionExists): Modify to take an Expression
22457 as the first parameter. Ensure we do null -> reference type conversion
22460 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
22461 temporary Expression objects.
22463 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
22465 * interface.cs: workaround bug in method overloading resolution
22466 (there is already a bugzilla bug for it).
22468 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22470 We could also solve this problem by having a separate path for
22471 performing type lookups, instead of DoResolve, we could have a
22472 ResolveType entry point, and only participating pieces of the
22473 production (simplename, deref, array) would implement this.
22475 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
22476 signal SimpleName to only resolve type names and not attempt to
22477 resolve anything else.
22479 * expression.cs (Cast): Set the flag.
22481 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
22483 * class.cs: Only report 108 if there is no `new' modifier.
22485 * cs-parser.jay: rework foreach statement to work with the new
22486 changes to the policy on SimpleNames.
22488 * report.cs: support Stacktrace on warnings as well.
22490 * makefile: drop --unsafe and /unsafe from the compile.
22492 2002-03-11 Miguel de Icaza <miguel@ximian.com>
22494 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22495 lookups here, instead of doing that at parse time. This means
22496 that our grammar will not introduce `LocalVariableReferences' as
22497 expressions at this point. That solves the problem of code like
22501 static void Main ()
22505 This is only half the fix. The full fix requires parameters to
22506 also be handled in this way.
22508 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
22509 makes the use more obvious of the DeclSpace. The
22510 ec.TypeContainer.TypeBuilder is now only used to pull the
22511 TypeBuilder for it.
22513 My theory is that I can get rid of the TypeBuilder completely from
22514 the EmitContext, and have typecasts where it is used (from
22515 DeclSpace to where it matters).
22517 The only pending problem is that the code that implements Aliases
22518 is on TypeContainer, and probably should go in DeclSpace.
22520 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22521 lookups here, instead of doing that at parse time. This means
22522 that our grammar will not introduce `LocalVariableReferences' as
22523 expressions at this point. That solves the problem of code like
22527 static void Main ()
22531 This is only half the fix. The full fix requires parameters to
22532 also be handled in this way.
22534 * class.cs (Property.DefineMethod): When implementing an interface
22535 method, set newslot, when implementing an abstract method, do not
22536 set the flag (before we tried never setting it, or always setting
22537 it, which is the difference).
22538 (Indexer.DefineMethod): same.
22539 (Method.DefineMethod): same.
22541 * ecore.cs: Only set the status used flag if we get back a Field.
22543 * attribute.cs: Temporary hack, so Paolo can keep working.
22545 2002-03-08 Ravi Pratap <ravi@ximian.com>
22547 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
22548 the unmanaged type in the case we have a MarshalAs attribute.
22550 (Resolve): Handle the case when we are parsing the special MarshalAs
22551 attribute [we need to store the unmanaged type to use later]
22553 * typemanager.cs (marshal_as_attr_type): Built in type for the
22554 MarshalAs Attribute.
22556 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
22557 on parameters and accordingly set the marshalling info.
22559 2002-03-09 Miguel de Icaza <miguel@ximian.com>
22561 * class.cs: Optimizing slightly by removing redundant code after
22562 we switched to the `NoTypes' return value.
22563 (Property.DefineMethod): use NoTypes here too.
22565 This fixes the bug I introduced in my last batch of changes.
22567 2002-03-05 Ravi Pratap <ravi@ximian.com>
22569 * tree.cs (RecordEnum): Add. We now keep track of enums too.
22571 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
22572 Enums since those are types too.
22574 * cs-parser.jay (enum_declaration): Record enums as we parse them.
22576 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
22577 thanks to a call during the lookup process.
22579 2002-03-07 Miguel de Icaza <miguel@ximian.com>
22581 * statement.cs (Foreach): Lots of work to accomodate a particular
22582 kind of foreach statement that I had not kept in mind. It is
22583 possible to have foreachs on classes that provide a GetEnumerator
22584 method that return objects that implement the "pattern" for using
22585 a foreach, there is no need to support GetEnumerator
22588 This is needed to compile nant.
22590 * decl.cs: Only report 114 if the member is not `Finalize' and if
22591 the warning level is at least 2.
22593 * class.cs: Moved the compare function from Method to
22596 (MethodSignature.InheritableMemberSignatureCompare): Add new
22597 filter function that is used to extract inheritable methods from a
22600 (Method.Define): Use the new `inheritable_method_signature_filter'
22603 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
22606 2002-03-06 Miguel de Icaza <miguel@ximian.com>
22608 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
22610 * cs-parser.jay: Add opt_semicolon to the interface declaration.
22612 * expression.cs: Pass location information to
22613 ConvertImplicitStandard.
22615 * class.cs: Added debugging code to track return values from
22618 2002-03-05 Miguel de Icaza <miguel@ximian.com>
22620 * expression.cs (Is.DoResolve): If either side of the `is' is an
22621 interface, do not flag the warning.
22623 * ecore.cs (ImplicitReferenceConversion): We need a separate test
22626 * report.cs: Allow for --fatal to be used with --probe.
22628 * typemanager.cs (NoTypes): Move the definition for the empty Type
22631 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
22633 (TypeContainer.DefineProxy): New function used to proxy to parent
22634 implementations when implementing interfaces.
22635 (TypeContainer.ParentImplements): used to lookup if our parent
22636 implements a public function that is required by an interface.
22637 (TypeContainer.VerifyPendingMethods): Hook this up.
22639 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
22640 `modules' and `assemblies' arraylists into arrays. We only grow
22641 these are the very early start up of the program, so this improves
22642 the speedof LookupType (nicely measured).
22644 * expression.cs (MakeByteBlob): Replaced unsafe code with
22645 BitConverter, as suggested by Paolo.
22647 * cfold.cs (ConstantFold.Binary): Special case: perform constant
22648 folding of string concatenation, but if either side is a string,
22649 and the other is not, then return null, and let the runtime use
22650 the concatenation on the string plus the object (using
22651 `Object.ToString').
22653 2002-03-04 Miguel de Icaza <miguel@ximian.com>
22655 Constant Folding has been implemented now.
22657 * expression.cs (Unary.Reduce): Do not throw an exception, catch
22658 the error instead on types that are not supported in one's
22661 * constant.cs (Constant and all children): New set of functions to
22662 perform implict and explicit conversions.
22664 * ecore.cs (EnumConstant): Implement the new functions to perform
22665 conversion by proxying to the child expression.
22667 * codegen.cs: (ConstantCheckState): Constant evaluation has its
22668 own separate setting that can not be turned off from the command
22669 line using --unchecked or --checked and is only controlled using
22670 the checked/unchecked statements and expressions. This setting is
22671 used by the constant folder to flag errors.
22673 * expression.cs (CheckedExpr, UncheckedExpr): Set the
22674 ConstantCheckState as well.
22676 During Resolve, they also have to flag the state, because the
22677 constant folder runs completely in the Resolve phase.
22679 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
22682 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22684 * cfold.cs: New file, this file contains the constant folder.
22686 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
22687 argument to track whether we are using the resulting address to
22688 load or store a value and provide better error messages.
22690 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
22691 new AddressOf arguments.
22693 * statement.cs (Foreach.EmitCollectionForeach): Update
22695 * expression.cs (Argument.Emit): Call AddressOf with proper
22696 arguments to track usage.
22698 (New.DoEmit): Call AddressOf with new arguments.
22700 (Unary.Emit): Adjust AddressOf call.
22702 2002-03-01 Ravi Pratap <ravi@ximian.com>
22704 * cs-parser.jay (member_access): Change the case for pre-defined types
22705 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
22708 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
22711 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
22712 essentially like methods and apply attributes like MethodImplOptions to them too.
22714 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
22717 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
22718 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
22721 * Update code everywhere accordingly.
22723 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
22725 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
22727 2002-02-28 Ravi Pratap <ravi@ximian.com>
22729 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
22730 try performing lookups against those instead of jumping straight into using
22731 the 'using' clauses.
22733 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
22735 (LookupType): Perform lookups in implicit parents too.
22737 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
22738 sequence as RootContext.LookupType.
22740 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
22741 the various cases of namespace lookups into this method.
22743 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22745 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
22746 in positional arguments)
22748 * class.cs (Operator): Update the AllowedModifiers to contain
22751 * cs-parser.jay: Update operator declaration to allow for the
22752 operator body to be empty.
22754 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
22757 2002-02-27 Miguel de Icaza <miguel@ximian.com>
22759 * class.cs (Method.Emit): Label parameters.
22761 * driver.cs: Return 1 or 0 as the program exit code.
22763 2002-02-26 Miguel de Icaza <miguel@ximian.com>
22765 * expression.cs: Special case the `null' object when trying to
22766 auto-compute the type, as anything can be explicitly converted to
22769 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
22770 spotting this Paolo.
22772 (Expression.ImplicitNumericConversion): Perform comparissions of
22773 the type using the underlying type in the case of an enumeration
22774 rather than using the enumeration type for the compare.
22776 Cope with the underlying == type case, which is not possible to
22779 (Expression.ConvertNumericExplicit): Perform comparissions of
22780 the type using the underlying type in the case of an enumeration
22781 rather than using the enumeration type for the compare.
22783 * driver.cs: If the user does not supply an extension, assume .exe
22785 * cs-parser.jay (if_statement): Rewrote so that we can track the
22786 location for the if statement.
22788 * expression.cs (Binary.ConstantFold): Only concat strings when
22789 the operation is "+", not everything ;-)
22791 * statement.cs (Statement.EmitBoolExpression): Take a location
22793 (If, While, Do): Track location.
22795 * expression.cs (Binary.ResolveOperator): In the object + string
22796 case, I was missing a call to ConvertImplicit
22798 2002-02-25 Ravi Pratap <ravi@ximian.com>
22800 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
22801 Location arguments. Ensure we use RootContext.LookupType to do our work
22802 and not try to do a direct Type.GetType and ModuleBuilder.GetType
22804 * interface.cs (PopulateMethod): Handle the type of the parameter being
22807 * expression.cs (Invocation.BetterFunction): Handle the case when we
22808 have a params method with no fixed arguments and a call is made with no
22811 2002-02-25 Miguel de Icaza <miguel@ximian.com>
22813 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
22814 the verbatim-string-literal
22816 * support.cs (InternalParameters.ParameterModifier): handle null
22818 (InternalParameters.ParameterType): ditto.
22820 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
22821 duplicating the name of the variable parameter.
22822 (GetParameterByName): Fix bug where we were not looking up array
22823 paramters if they were the only present (thanks Paolo!).
22824 (GetParameterInfo): We only have an empty set of types if both
22825 fixed and array are set to null.
22826 (GetParameterInfo-idx): Handle FixedParameter == null
22828 * cs-parser.jay: Handle the case where there is no catch
22829 statements (missing null test).
22831 2002-02-22 Miguel de Icaza <miguel@ximian.com>
22833 * driver.cs (MainDriver): Be conservative on our command line
22836 Catch DirectoryNotFoundException when calling GetFiles.
22838 (SplitPathAndPattern): Used to split the input specification into
22839 a path and a pattern that we can feed to Directory.GetFiles.
22841 2002-02-21 Miguel de Icaza <miguel@ximian.com>
22843 * statement.cs (Fixed): Implement the last case of the Fixed
22844 statement (string handling).
22846 * expression.cs (StringPtr): New class used to return a char * to
22847 a string; Used by the Fixed statement.
22849 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
22851 * expression.cs (Binary.ResolveOperator): Remove redundant
22852 MemberLookup pn parent type.
22853 Optimize union call, we do not need a union if the types are the same.
22854 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
22857 Specialize the use of MemberLookup everywhere, instead of using
22858 the default settings.
22860 (StackAlloc): Implement stackalloc keyword.
22862 * cs-parser.jay: Add rule to parse stackalloc.
22864 * driver.cs: Handle /h, /help, /?
22866 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22867 before we supported unsafe code.
22869 * makefile: add --unsafe to the self compilation of mcs.
22871 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22873 * expression.cs (PointerArithmetic): New class that is used to
22874 perform pointer arithmetic.
22875 (Binary.Resolve): Handle pointer arithmetic
22876 Handle pointer comparission.
22877 (ArrayPtr): Utility expression class that is used to take the
22878 address of an array.
22880 (ElementAccess): Implement array access for pointers
22882 * statement.cs (Fixed): Implement fixed statement for arrays, we
22883 are missing one more case before we are done.
22885 * expression.cs (Indirection): Implement EmitAssign and set the
22886 ExprClass to Variable. This allows pointer dereferences to be
22887 treated as variables, and to have values assigned to them.
22889 * ecore.cs (Expression.StoreFromPtr): New utility function to
22890 store values dereferencing.
22892 2002-02-20 Ravi Pratap <ravi@ximian.com>
22894 * expression.cs (Binary.ResolveOperator): Ensure that we are
22895 not trying to operate on a void type - this fixes the reported
22898 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22899 the parent implementation is sealed.
22901 * ../errors/cs0239.cs : Add.
22903 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22905 * typemanager.cs (unverifiable_code_type): Corresponds to
22906 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22907 which have unsafe code in them.
22909 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22912 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22914 * cs-tokenizer.cs: Add support for @"litreal strings"
22916 Make tokenizer accept pre-processor directives
22917 on any column (remove the old C-like limitation).
22919 * rootcontext.cs (EmitCode): Emit any global attributes.
22920 (AddGlobalAttributes): Used to keep track of assembly attributes.
22922 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22924 * cs-parser.jay: Add support for global attributes.
22926 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22928 * expression.cs (Indirection): New helper class. Unary will
22929 create Indirection classes to be able to implement the
22930 IMemoryLocation interface on it.
22932 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22934 * cs-parser.jay (fixed_statement): reference the right statement.
22936 * statement.cs (Fixed.Emit): Finish implementing the fixed
22937 statement for the &x case.
22939 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22941 * class.cs (Property.Define, Method.Define): Remove newslot when
22944 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22945 wrong. NewSlot should only be used if the `new' keyword is present.
22947 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22948 locating our system dir. Sorry about this.
22950 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22952 * driver.cs (GetSystemDir): Compute correctly the location of our
22953 system assemblies. I was using the compiler directory instead of
22954 the library directory.
22956 2002-02-13 Ravi Pratap <ravi@ximian.com>
22958 * expression.cs (BetterFunction): Put back in what Miguel commented out
22959 since it is the correct fix. The problem is elsewhere ;-)
22961 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22962 parameters of the parms method are themselves compatible or not !
22964 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22965 to check that a class implements an interface before saying that an implicit
22966 conversion was allowed. Use ImplementsInterface to do the checking.
22968 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22970 * class.cs (Method.Define): Track whether we are an explicit
22971 implementation or not. And only call DefineMethodOverride if we
22972 are an explicit implementation.
22974 (Property.DefineMethod): Ditto.
22976 2002-02-11 Ravi Pratap <ravi@ximian.com>
22978 * expression.cs (BetterFunction): Catch hideous bug which was
22979 preventing us from detecting ambiguous calls due to implicit casts i.e
22982 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22984 * support.cs (Pair): Remove un-needed method. I figured why I was
22985 getting the error in cs-parser.jay, the variable in a foreach loop
22986 is readonly, and the compiler does not really treat this as a variable.
22988 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22989 instead of EQUALS in grammar.
22991 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22993 * expression.cs (Unary.DoResolve): Check whether the argument is
22996 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22998 * support.cs: Api for Pair to set a value. Despite the fact that
22999 the variables are public the MS C# compiler refuses to compile
23000 code that accesses the field if the variable is part of a foreach
23003 * statement.cs (Fixed): Begin implementation of the fixed
23006 (Block.AddVariable): Return the VariableInfo on success and null
23007 on failure instead of true/false.
23009 * cs-parser.jay (foreach): Catch errors on variables already
23010 defined (we were ignoring this value before) and properly unwind
23011 the block hierarchy
23013 (fixed_statement): grammar for the fixed statement.
23015 2002-01-25 Miguel de Icaza <miguel@ximian.com>
23017 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
23018 pointer types to be incretemented.
23020 (SizeOf): Implement.
23022 * cs-parser.jay (pointer_member_access): Implement
23023 expr->IDENTIFIER production.
23025 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
23026 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
23029 (Unary): Implement indirection.
23031 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
23032 use in non-unsafe context).
23034 (SimpleName.DoResolve): Check for pointers in field access on safe
23037 (Expression.LoadFromPtr): Factor the load-indirect code in this
23038 function. This was duplicated in UnboxCast and ParameterReference
23040 2002-01-24 Miguel de Icaza <miguel@ximian.com>
23042 * expression.cs (ComposedCast): report an error if a pointer cast
23043 is used in a safe region.
23045 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
23046 pointer type casts in unsafe context.
23048 * codegen.cs (EmitContext): Set up IsUnsafe.
23050 * cs-parser.jay (non_expression_type): Add productions for pointer
23053 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
23054 code. We should not use force into static mode if the method is
23055 not virtual. Fixes bug in MIS
23057 * statement.cs (Do.Emit, While.Emit, For.Emit,
23058 Statement.EmitBoolExpression): Add support to Do and While to
23059 propagate infinite loop as `I do return' semantics.
23061 Improve the For case to also test for boolean constants.
23063 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
23064 to the list of attributes we can add.
23066 Remove `EmitContext' argument.
23068 * class.cs (Method.Define): Apply parameter attributes.
23069 (Constructor.Define): Apply parameter attributes.
23070 (MethodCore.LabelParameters): Move here the core of labeling
23073 * support.cs (ReflectionParameters.ParameterModifier,
23074 InternalParameters.ParameterModifier): Use IsByRef on the type and
23075 only return the OUT bit for these parameters instead of in/out/ref
23078 This is because I miss-understood things. The ParameterInfo.IsIn
23079 and IsOut represent whether the parameter has the [In] and [Out]
23082 2002-01-22 Miguel de Icaza <miguel@ximian.com>
23084 * ecore.cs (FieldExpr.Emit): Release temporaries.
23086 * assign.cs (LocalTemporary.Release): new function.
23088 * codegen.cs (EmitContext.GetTemporaryStorage,
23089 EmitContext.FreeTemporaryStorage): Rework the way we deal with
23090 temporary storage. Now we can "put back" localbuilders when we
23093 2002-01-21 Miguel de Icaza <miguel@ximian.com>
23095 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
23096 need to make a copy of the variable to generate verifiable code.
23098 2002-01-19 Miguel de Icaza <miguel@ximian.com>
23100 * driver.cs: Compute dynamically the system directory.
23102 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
23103 Slower, but more generally useful. Used by the abstract
23104 registering implementation.
23106 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
23107 the rules for the special rule on Type/instances. First check if
23108 we have the same name, and if so, try that special static path
23109 rather than the instance path.
23111 2002-01-18 Miguel de Icaza <miguel@ximian.com>
23113 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
23116 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
23117 Enum, ValueType, Delegate or Array for non-corlib compiles.
23119 * cs-tokenizer.cs: Catch long identifiers (645)
23121 * typemanager.cs (IndexerPropetyName): Ravi never tested this
23124 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
23125 fix, we were returning too early, so we were not registering
23126 pending methods from abstract classes.
23128 Do not register pending methods if the class is abstract.
23130 * expression.cs (Conditional.DoResolve): Report circular implicit
23131 conversions when we neecd to compute it for conditional
23134 (Is.DoResolve): If the expression is always of the provided type,
23135 flag warning 183. If the expression can not ever be of the
23136 provided type flag warning 184.
23138 * class.cs: Catch 169 as well.
23140 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
23143 2002-01-18 Nick Drochak <ndrochak@gol.com>
23145 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
23147 2002-01-17 Miguel de Icaza <miguel@ximian.com>
23149 * interface.cs: (PopulateMethod): Check for pointers being defined
23150 only if the unsafe context is active.
23151 (PopulateProperty): ditto.
23152 (PopulateIndexer): ditto.
23154 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
23155 specified. If pointers are present, make sure that they are
23156 present in an unsafe context.
23157 (Constructor, Constructor.Define): ditto.
23158 (Field, Field.Define): ditto.
23159 (Property, Property.Define): ditto.
23160 (Event, Event.Define): ditto.
23162 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
23163 hashtable if there are classes or structs defined.
23165 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23166 code, as the constant resolution moved.
23168 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
23169 the metadata, so we can flag error 133.
23171 * decl.cs (MemberCore.UnsafeOK): New function to test that a
23172 pointer is being declared in an unsafe context.
23174 2002-01-16 Miguel de Icaza <miguel@ximian.com>
23176 * modifiers.cs (Modifiers.Check): Require a Location argument.
23177 Report error 227 for Unsafe use.
23179 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
23181 * statement.cs (For.Emit): If the test is null, then report that
23182 we do `return', as we wont reach anything afterwards.
23184 (Switch.SwitchGoverningType): Track the expression that matched
23187 * driver.cs: Allow negative numbers as an error code to flag.
23189 * cs-parser.jay: Handle 1551.
23191 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
23193 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23195 * cs-parser.jay: Report 1518 (type declaration can only contain
23196 class, struct, interface, enum or delegate)
23198 (switch_label): Report 1523 (keywords `case' or `default' must
23201 (opt_switch_sections): Report 1522 (empty switch)
23203 * driver.cs: Report 1515 (response file specified multiple times)
23204 Report 1516 (Source file specified multiple times).
23206 * expression.cs (Argument.Resolve): Signal 1510
23208 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
23209 access not allowed in static code)
23211 2002-01-11 Ravi Pratap <ravi@ximian.com>
23213 * typemanager.cs (IsPointerType): Utility method which we are going
23216 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
23217 the object type, so we take care of that.
23219 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
23221 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
23222 added to non-params parameters :-)
23224 * typemanager.cs (CSharpName): Include 'void' type too.
23226 (void_ptr_type): Include in the set of core types.
23228 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
23231 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
23234 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
23235 completely forgotten about it.
23237 2002-01-10 Ravi Pratap <ravi@ximian.com>
23239 * cs-parser.jay (pointer_type): Add. This begins our implementation
23240 of parsing rules for unsafe code.
23242 (unsafe_statement): Implement.
23244 (embedded_statement): Modify to include the above.
23246 * statement.cs (Unsafe): Implement new class for unsafe blocks.
23248 * codegen.cs (EmitContext.InUnsafe): Add. This determines
23249 if the current context is an unsafe one.
23251 * cs-parser.jay (local_variable_pointer_type): Since local variable types
23252 are handled differently, we need separate rules for them.
23254 (local_variable_declaration): Update to use local_variable_pointer_type
23255 to allow variable declarations of unmanaged pointer types.
23257 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
23258 in unsafe contexts.
23260 * ../errors/cs0214.cs : Add.
23262 2002-01-16 Nick Drochak <ndrochak@gol.com>
23264 * makefile: remove 'response' file when cleaning.
23266 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23268 * cs-parser.jay: Report 1524.
23270 2002-01-14 Miguel de Icaza <miguel@ximian.com>
23272 * typemanager.cs (RegisterMethod): drop checking if we have
23273 registered this from here
23275 2002-01-12 Miguel de Icaza <miguel@ximian.com>
23277 * class.cs (Method.EmitDestructor): Implement calling our base
23280 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
23281 value of InFinally.
23283 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
23284 this routine and will wrap the call in a try/catch block. Deal
23287 2002-01-11 Miguel de Icaza <miguel@ximian.com>
23289 * ecore.cs (Expression.MemberLookup): instead of taking a
23290 parameter `same_type' that was used to tell whether we could
23291 access private members we compute our containing type from the
23294 (FieldExpr): Added partial support for volatile fields. This does
23295 not work for volatile fields exposed from assemblies, as I can not
23296 figure out how to extract the modreq from it.
23298 Updated all the source files to use this.
23300 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
23301 because it is referenced by MemberLookup very often.
23303 2002-01-09 Ravi Pratap <ravi@ximian.com>
23305 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
23306 TypeBuilder.GetCustomAttributes to retrieve what we need.
23308 Get rid of redundant default_member_attr_type as this is the same as
23309 default_member_type which already exists.
23311 * interface.cs, attribute.cs : Update accordingly.
23313 2002-01-08 Miguel de Icaza <miguel@ximian.com>
23315 * typemanager.cs: Enable IndexerPropertyName again. It does not
23316 work for TYpeBuilders though. Ravi, can you please fix this?
23318 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
23320 * expression.cs (Argument.Emit): Handle the case of ref objects
23321 being passed to ref functions;
23323 (ParameterReference.EmitLoad): Loads the content of the pointer
23324 without dereferencing.
23326 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23328 * cs-tokenizer.cs: Implemented the pre-processing expressions.
23330 2002-01-08 Ravi Pratap <ravi@ximian.com>
23332 * class.cs (Indexer.DefineMethod): Incorporate the interface
23333 type in the name of the method if we are doing explicit interface
23336 * expression.cs (ConversionExists): Remove as it is completely obsolete.
23338 (BetterConversion): Fix extremely trivial bug where we were referring to
23339 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
23342 * ../errors/bug16.cs : Add although we have fixed it.
23344 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23346 * expression.cs (BaseIndexer): Begin implementation.
23348 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
23350 * cs-parser.jay (indexer_declarator): Use qualified_identifier
23351 production directly to remove a shift/reduce, and implement
23352 explicit interface implementation.
23354 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
23355 after a floating point suffix.
23357 * expression.cs (DoNumericPromotions): Improved the conversion for
23358 uint/uint. If we have a constant, we avoid doing a typecast to a
23361 * class.cs (Indexer): Implement explicit interface implementation
23364 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
23366 * class.cs: make the default instance constructor public and hidebysig.
23368 2001-01-03 Ravi Pratap <ravi@ximian.com>
23370 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
23371 so we can call it from elsewhere.
23373 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
23374 we emit it internally if the class has a defined indexer; otherwise the user
23375 emits it by decorating the class definition with the DefaultMemberAttribute.
23377 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
23378 attribute is not used on a type which defines an indexer.
23380 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
23381 character when we skip whitespace.
23383 * ../errors/cs0646.cs : Add.
23385 2002-01-03 Miguel de Icaza <miguel@ximian.com>
23387 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
23390 * makefile: Add practical target `mcs3.exe' which builds the third
23391 generation compiler.
23393 * expression.cs (New): Fix structures constructor calling.
23395 * class.cs (Property, Method, Indexer): Emit Final flag on the
23396 method if we are an interface implementation and we are not
23399 * ecore.cs (PropertyExpr): New public field `IsBase', tells
23400 whether this property is referencing a `base' method.
23402 * expression.cs (Invocation.EmitCall): take an extra argument:
23403 is_base, this is used to determine whether the `call' or
23404 `callvirt' opcode should be used.
23407 * delegate.cs: update EmitCall.
23409 * class.cs (Method.Define): Set NewSlot for the cases where we are
23410 not implementing an interface method.
23412 (Property.Define): ditto.
23414 2002-01-02 Miguel de Icaza <miguel@ximian.com>
23416 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
23417 'r'. Allows mcs to parse itself fully.
23419 2002-01-02 Ravi Pratap <ravi@ximian.com>
23421 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
23422 of the number of initializers that require the InitializeArray method.
23424 (CheckIndices): Store the Expression in all cases - not the plain value. Also
23425 update the above field where necessary.
23427 (MakeByteBlob): Update accordingly.
23429 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
23432 (EmitDynamicInitializers): Update in accordance with the new optimization.
23434 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
23435 same OpCode applies.
23437 * cs-parser.jay : Fix some glaring errors I introduced.
23439 2002-01-01 Ravi Pratap <ravi@ximian.com>
23441 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
23442 so that we can check for name clashes there too.
23444 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
23445 for interface indexers.
23447 * interfaces.cs (Define): Emit the default member attribute.
23449 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
23450 variable was being referred to while setting the value ;-)
23452 2002-01-01 Miguel de Icaza <miguel@ximian.com>
23454 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
23455 byte-by-byte information when we know the data is zero.
23457 Make the block always a multiple of 4, because
23458 DefineInitializedData has a bug.
23460 * assign.cs: Fix, we should assign from the temporary, not from
23463 * expression.cs (MakeByteBlob): Fix my incorrect code.
23465 2001-12-31 Miguel de Icaza <miguel@ximian.com>
23467 * typemanager.cs (EnumToUnderlying): This function is used to get
23468 the underlying type from an enumeration, because it does not
23471 * constant.cs: Use the I4_S form for values between -128 and 127.
23473 * statement.cs (Block.LookupLabel): Looks up a label.
23474 (Block): Drop support for labeled blocks.
23476 (LabeledStatement): New kind of statement that represents a label
23479 (Goto): Finally implement this bad boy.
23481 * cs-parser.jay: Update to reflect new mechanism to implement
23484 2001-12-30 Miguel de Icaza <miguel@ximian.com>
23486 * codegen.cs (EmitContext.This): a codegen property that keeps the
23487 a single instance of this instead of creating many different this
23490 * delegate.cs (Delegate.DoResolve): Update to use the property;
23492 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
23494 * expression.cs (BaseAccess.DoResolve): Ditto.
23496 2001-12-29 Ravi Pratap <ravi@ximian.com>
23498 * typemanager.cs (methodimpl_attr_type): Add to hold the type
23499 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
23501 (InitCoreTypes): Update accordingly.
23503 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
23504 so we can quickly store the state.
23506 (ApplyAttributes): Set the correct implementation flags
23507 for InternalCall methods.
23509 2001-12-29 Miguel de Icaza <miguel@ximian.com>
23511 * expression.cs (EmitCall): if a method is not virtual, then do
23512 not use callvirt on it.
23514 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
23515 user defined stuff) requires the use of stobj, which takes an
23516 address on the stack instead of an array and an index. So emit
23517 the Ldelema operation for it.
23519 (EmitStoreOpcode): Use stobj for valuetypes.
23521 (UnaryMutator.EmitCode): Use the right 1 value depending on
23522 whether we are dealing with int64/uint64, float or doubles.
23524 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
23525 constructors that I implemented last night.
23527 (Constructor.IsDefault): Fix to work properly for static
23530 * cs-parser.jay (CheckDef): report method signature errors.
23531 Update error number 103 to be 132.
23533 * decl.cs: New AdditionResult enumeration value: MethodExists.
23534 Although we do this check for methods later on in the semantic
23535 analysis, catching repeated default constructors is so easy that
23536 we catch these here.
23538 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
23541 (ParameterReference.EmitAssign, Emit): handle
23544 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
23545 (ArrayAccess.EmitStoreOpcode): ditto.
23547 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
23549 * expression.cs (MakeByteBlob): Complete all the missing types
23550 (uint, short, ushort, byte, sbyte)
23552 * class.cs: Only init instance field initializers on instance
23555 Rename `constructors' to instance_constructors.
23557 (TypeContainer.AddConstructor): Only add constructors to the list
23558 if it is not static.
23560 Make sure that we handle default_static_constructor independently
23561 everywhere where we handle instance_constructors
23563 2001-12-28 Miguel de Icaza <miguel@ximian.com>
23565 * class.cs: Do not lookup or create a base initializer for a
23566 static constructor.
23568 (ConstructorInitializer.Resolve): use the proper type to lookup
23571 * cs-parser.jay: Report error 1585 (modifiers between type and name).
23573 * enum.cs, interface.cs: Remove CloseType, this is taken care by
23576 * decl.cs: CloseType is now an virtual method, the default
23577 implementation just closes this type.
23579 2001-12-28 Ravi Pratap <ravi@ximian.com>
23581 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
23582 to PreserveSig by default. Also emit HideBySig on such methods.
23584 Basically, set the defaults to standard values.
23586 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
23587 argument, if candidate is better, it can't be worse than the best !
23589 (Invocation): Re-write bits to differentiate between methods being
23590 applicable in their expanded form and their normal form - for params
23593 Get rid of use_standard everywhere as only standard conversions are allowed
23594 in overload resolution.
23596 More spec conformance.
23598 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23600 * driver.cs: Add --timestamp, to see where the compiler spends
23603 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
23604 `this' in static code.
23606 (SimpleName.DoResolve): Implement in terms of a helper function
23607 that allows static-references to be passed upstream to
23610 (Expression.ResolveWithSimpleName): Resolve specially simple
23611 names when called by MemberAccess to implement the special
23614 (Expression.ImplicitReferenceConversion): Handle conversions from
23615 Null to reference types before others, as Null's type is
23618 * expression.cs (Invocation.EmitCall): Handle the special case of
23619 calling methods declared on a reference type from a ValueType
23620 (Base classes System.Object and System.Enum)
23622 (MemberAccess.Resolve): Only perform lookups on Enumerations if
23623 the left hand side is a TypeExpr, not on every enumeration.
23625 (Binary.Resolve): If types are reference types, then do a cast to
23626 object on operators != and == of both arguments.
23628 * typemanager.cs (FindMembers): Extract instance and static
23629 members if requested.
23631 * interface.cs (PopulateProperty): Use void_type instead of null
23632 as the return type for the setter method.
23634 (PopulateIndexer): ditto.
23636 2001-12-27 Ravi Pratap <ravi@ximian.com>
23638 * support.cs (ReflectionParameters): Fix minor bug where we
23639 were examining the wrong parameter for the ParamArray attribute.
23641 Cope with requests for the type of the parameter at position
23642 greater than the params parameter's. We now return the element
23643 type of the params array as that makes more sense.
23645 * expression.cs (Invocation.IsParamsMethodApplicable): Update
23646 accordingly as we no longer have to extract the element type
23649 (Invocation.OverloadResolve): Update.
23651 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23653 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
23654 against IEnumerator, test whether the return value is a descendant
23655 of the IEnumerator interface.
23657 * class.cs (Indexer.Define): Use an auxiliary method to implement
23658 the other bits of the method definition. Begin support for
23659 explicit interface implementation.
23661 (Property.DefineMethod): Use TypeManager.void_type instead of null
23662 for an empty return value.
23664 2001-12-26 Miguel de Icaza <miguel@ximian.com>
23666 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
23667 dealing with a FieldExpr which is composed of a FieldBuilder, in
23668 the code path we did extract the constant, but we should have
23669 obtained the underlying value to be able to cast it (otherwise we
23670 end up in an infinite loop, this is what Ravi was running into).
23672 (ArrayCreation.UpdateIndices): Arrays might be empty.
23674 (MemberAccess.ResolveMemberAccess): Add support for section
23675 14.5.4.1 that deals with the special case of E.I when E is a type
23676 and something else, that I can be a reference to a static member.
23678 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
23679 handle a particular array type to create byte blobs, it is just
23680 something we dont generate byteblobs for.
23682 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
23685 * location.cs (Push): remove the key from the hashtable that we
23686 are about to add. This happens for empty files.
23688 * driver.cs: Dispose files after we have parsed them.
23690 (tokenize): new function that only runs the tokenizer on its
23691 input, for speed testing.
23693 2001-12-26 Ravi Pratap <ravi@ximian.com>
23695 * class.cs (Event.Define): Define the private field only if there
23696 are no accessors defined.
23698 * expression.cs (ResolveMemberAccess): If there is no associated
23699 field with the event, that means we have an event defined with its
23700 own accessors and we should flag error cs0070 since transforming
23701 ourselves into a field is not valid in that case.
23703 * ecore.cs (SimpleName.DoResolve): Same as above.
23705 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
23706 and charset to sane values.
23708 2001-12-25 Ravi Pratap <ravi@ximian.com>
23710 * assign.cs (DoResolve): Perform check on events only if they
23711 are being accessed outside the declaring type.
23713 * cs-parser.jay (event_declarations): Update rules to correctly
23714 set the type of the implicit parameter etc.
23716 (add_accessor, remove_accessor): Set current local parameters.
23718 * expression.cs (Binary): For delegate addition and subtraction,
23719 cast the return value from the method into the appropriate delegate
23722 2001-12-24 Ravi Pratap <ravi@ximian.com>
23724 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
23725 of these as the workaround is unnecessary.
23727 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
23728 delegate data - none of that is needed at all.
23730 Re-write bits to extract the instance expression and the delegate method
23733 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
23736 * attribute.cs (ApplyAttributes): New method to take care of common tasks
23737 of attaching attributes instead of duplicating code everywhere.
23739 * everywhere : Update code to do attribute emission using the above method.
23741 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23743 * expression.cs (IsParamsMethodApplicable): if there are not
23744 parameters, return immediately.
23746 * ecore.cs: The 0 literal can be implicity converted to an enum
23749 (SimpleName.DoResolve): First lookup the type, then lookup the
23752 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
23753 want to get its address. If the InstanceExpression is not
23754 addressable, store the result in a temporary variable, then get
23757 * codegen.cs: Only display 219 errors on warning level or above.
23759 * expression.cs (ArrayAccess): Make it implement the
23760 IMemoryLocation interface.
23762 (Binary.DoResolve): handle the operator == (object a, object b)
23763 and operator != (object a, object b) without incurring into a
23764 BoxedCast (because 5 != o should never be performed).
23766 Handle binary enumerator operators.
23768 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
23769 value type, otherwise use Ldelem_ref.
23771 Use precomputed names;
23773 (AddressOf): Implement address of
23775 * cs-parser.jay (labeled_statement): Fix recursive block
23776 addition by reworking the production.
23778 * expression.cs (New.DoEmit): New has a special case:
23780 If we are dealing with a ValueType, we have a few
23781 situations to deal with:
23783 * The target of New is a ValueType variable, that is
23784 easy, we just pass this as the variable reference
23786 * The target of New is being passed as an argument,
23787 to a boxing operation or a function that takes a
23790 In this case, we need to create a temporary variable
23791 that is the argument of New.
23794 2001-12-23 Ravi Pratap <ravi@ximian.com>
23796 * rootcontext.cs (LookupType): Check that current_type is not null before
23797 going about looking at nested types.
23799 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
23800 not implement the IAssignMethod interface any more.
23802 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
23803 where we tranform them into FieldExprs if they are being resolved from within
23804 the declaring type.
23806 * ecore.cs (SimpleName.DoResolve): Do the same here.
23808 * assign.cs (DoResolve, Emit): Clean up code considerably.
23810 * ../errors/bug10.cs : Add.
23812 * ../errors/cs0070.cs : Add.
23814 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
23816 * assign.cs : Get rid of EventIsLocal everywhere.
23818 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23820 * ecore.cs (ConvertIntLiteral): finished the implementation.
23822 * statement.cs (SwitchLabel): Convert the value we are using as a
23823 key before looking up the table.
23825 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23827 * codegen.cs (EmitTopBlock): Require a Location argument now.
23829 * cs-parser.jay (constructor_declarator): We need to setup
23830 current_local_parameters before we parse the
23831 opt_constructor_initializer, to allow the variables to be bound
23832 to the constructor arguments.
23834 * rootcontext.cs (LookupType): First lookup nested classes in our
23835 class and our parents before we go looking outside our class.
23837 * expression.cs (ConstantFold): Extract/debox the values at the
23840 * rootcontext.cs (EmitCode): Resolve the constants first before we
23841 resolve the types. This is not really needed, but it helps debugging.
23843 * statement.cs: report location.
23845 * cs-parser.jay: pass location to throw statement.
23847 * driver.cs: Small bug fix.
23849 * report.cs: Updated format to be 4-zero filled digits.
23851 2001-12-22 Ravi Pratap <ravi@ximian.com>
23853 * expression.cs (CheckIndices): Fix minor bug where the wrong
23854 variable was being referred to ;-)
23856 (DoEmit): Do not call EmitStaticInitializers when the
23857 underlying type is System.Object.
23859 2001-12-21 Ravi Pratap <ravi@ximian.com>
23861 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23862 and do the usual workaround for SRE.
23864 * class.cs (MyEventBuilder.EventType): New member to get at the type
23865 of the event, quickly.
23867 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23869 * assign.cs (Assign.DoResolve): Handle the case when the target
23870 is an EventExpr and perform the necessary checks.
23872 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23875 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23877 (EventExpr): Set the type in the constructor itself since we
23878 are meant to be born fully resolved.
23880 (EventExpr.Define): Revert code I wrote earlier.
23882 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23883 instance expression is null. The instance expression is a This in that case
23884 or a null, depending on whether it is a static method or not.
23886 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23887 refers to more than one method.
23889 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23890 and accordingly flag errors.
23892 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23894 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23896 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23898 * location.cs (ToString): Provide useful rutine.
23900 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23902 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23903 objects, return the actual integral boxed.
23905 * statement.cs (SwitchLabel): define an ILLabel for each
23908 (Switch.CheckSwitch): If the value is a Literal, extract
23909 the underlying literal.
23911 Also in the unused hashtable we had, add the SwitchLabel so we can
23912 quickly look this value up.
23914 * constant.cs: Implement a bunch of new constants. Rewrite
23915 Literal based on this. Made changes everywhere to adapt to this.
23917 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23918 dereferencing array only once, and also copes with enumrations.
23920 bytes are two bytes wide, not one.
23922 (Cast): Perform constant conversions.
23924 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23925 wrappers to the literals here.
23927 * expression.cs (DoNumericPromotions): long literals can converted
23928 to ulong implicity (this is taken care of elsewhere, but I was
23929 missing this spot).
23931 * ecore.cs (Expression.Literalize): Make the return type Literal,
23932 to improve type checking.
23934 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23936 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23938 * literal.cs: Revert code from ravi that checked the bounds. The
23939 bounds are sane by the definition of the type itself.
23941 * typemanager.cs: Fix implementation of ImplementsInterface. We
23942 need to actually look up in our parent hierarchy for interfaces
23945 * const.cs: Use the underlying type for enumerations
23947 * delegate.cs: Compute the basename for the delegate creation,
23948 that should fix the delegate test case, and restore the correct
23949 Type Lookup semantics in rootcontext
23951 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23952 referencing a nested type with the Reflection API is using the "+"
23955 * cs-parser.jay: Do not require EOF token at the end.
23957 2001-12-20 Ravi Pratap <ravi@ximian.com>
23959 * rootcontext.cs (LookupType): Concatenate type names with
23960 a '.' instead of a '+' The test suite passes again.
23962 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23963 field of the enumeration.
23965 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23966 the case when the member is an EventExpr.
23968 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23969 static has an associated instance expression.
23971 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23973 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23975 * class.cs (Event.Define): Register event and perform appropriate checks
23978 We define the Add and Remove methods even if the use provides none because
23979 in that case, we provide default implementations ourselves.
23981 Define a private field of the type of the event. This is done by the CSC compiler
23982 and we should be doing it too ;-)
23984 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23985 More methods we use in code we generate.
23987 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23990 (InitCoreTypes): Update accordingly for the above.
23992 * class.cs (Event.Emit): Generate code for default accessors that we provide
23994 (EmitDefaultMethod): Do the job in the above.
23996 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23999 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24001 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
24002 builders even if we were missing one.
24004 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
24005 pass the Basename as our class name instead of the Name. The
24006 basename will be correctly composed for us.
24008 * parameter.cs (Paramters): Now takes a Location argument.
24010 * decl.cs (DeclSpace.LookupType): Removed convenience function and
24011 make all the code call directly LookupType in RootContext and take
24012 this chance to pass the Location information everywhere.
24014 * Everywhere: pass Location information.
24016 2001-12-19 Miguel de Icaza <miguel@ximian.com>
24018 * class.cs (Constructor.Define): Updated way of detecting the
24019 length of the parameters.
24021 (TypeContainer.DefineType): Use basename as the type name for
24024 (TypeContainer.Define): Do not recursively define types here, as
24025 definition is taken care in order by the RootContext.
24027 * tree.cs: Keep track of namespaces in a per-file basis.
24029 * parameter.cs (Parameter.ComputeSignature): Update to use
24032 (Parameters.GetSignature): ditto.
24034 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
24035 instead of a TypeContainer.
24037 (Interface.SemanticAnalysis): Use `this' instead of our parent to
24038 resolve names. Because we need to be resolve in our context, not
24041 * driver.cs: Implement response files.
24043 * class.cs (TypeContainer.DefineType): If we are defined, do not
24044 redefine ourselves.
24046 (Event.Emit): Emit the code for add/remove handlers.
24047 (Event.Define): Save the MethodBuilders for add/remove.
24049 * typemanager.cs: Use pair here too.
24051 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
24052 DictionaryEntry requires the first argument to be non-null.
24054 (enum_declaration): Compute full name for registering the
24057 (delegate_declaration): Instead of using
24058 formal_parameter_list, use opt_formal_parameter_list as the list
24061 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
24062 (EventParsing): New property that controls whether `add' and
24063 `remove' are returned as tokens or identifiers (for events);
24065 2001-12-19 Ravi Pratap <ravi@ximian.com>
24067 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
24068 use MyEventBuilder only and let it wrap the real builder for us.
24070 (MyEventBuilder): Revamp constructor etc.
24072 Implement all operations that we perform on EventBuilder in precisely the same
24075 (FindMembers): Update to use the EventBuilder member.
24077 (Event.Emit): Update accordingly.
24079 2001-12-18 Ravi Pratap <ravi@ximian.com>
24081 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
24082 by calling the appropriate methods.
24084 (GetCustomAttributes): Make stubs as they cannot possibly do anything
24087 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
24089 2001-12-17 Ravi Pratap <ravi@ximian.com>
24091 * delegate.cs (Delegate.Populate): Check that the return type
24092 and various parameters types are indeed accessible.
24094 * class.cs (Constructor.Define): Same here.
24096 (Field.Define): Ditto.
24098 (Event.Define): Ditto.
24100 (Operator.Define): Check that the underlying Method defined itself
24101 correctly - so it's MethodBuilder should not be null.
24103 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
24104 expression happens to be null.
24106 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
24107 members but as of now we don't seem to be able to do anything really useful with it.
24109 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
24110 not the EventBuilder.
24112 2001-12-18 Miguel de Icaza <miguel@ximian.com>
24114 * cs-tokenizer.cs: Add support for defines.
24115 Add support for #if, #elif, #else, #endif
24117 (eval_var): evaluates a variable.
24118 (eval): stubbed for evaluating functions.
24120 * cs-parser.jay: Pass the defines information
24122 * driver.cs: Add --define command line option.
24124 * decl.cs: Move MemberCore here.
24126 Make it the base class for DeclSpace. This allows us to catch and
24127 report 108 and 109 for everything now.
24129 * class.cs (TypeContainer.Define): Extract all the members
24130 before populating and emit the warning 108 (new keyword required
24131 to override) instead of having each member implement this.
24133 (MemberCore.Define): New abstract method, we will be using this in
24134 the warning reporting engine in Populate.
24136 (Operator.Define): Adjust to new MemberCore protocol.
24138 * const.cs (Const): This does not derive from Expression, it is a
24139 temporary object we use to create fields, it is a MemberCore.
24141 * class.cs (Method.Define): Allow the entry point to be in a
24144 * driver.cs: Rewrite the argument handler to clean it up a bit.
24146 * rootcontext.cs: Made it just an auxiliary namespace feature by
24147 making everything static.
24149 * driver.cs: Adapt code to use RootContext type name instead of
24152 * delegate.cs: Remove RootContext argument.
24154 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
24157 * class.cs (Event.Define): The lookup can fail.
24159 * cs-tokenizer.cs: Begin implementation of pre-procesor.
24161 * expression.cs: Resolve the this instance before invoking the code.
24163 2001-12-17 Miguel de Icaza <miguel@ximian.com>
24165 * cs-parser.jay: Add a production in element_access that allows
24166 the thing to become a "type" reference. This way we can parse
24167 things like "(string [])" as a type.
24169 Note that this still does not handle the more complex rules of
24173 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
24175 * ecore.cs: (CopyNewMethods): new utility function used to
24176 assemble the list of methods from running FindMembers.
24178 (MemberLookup): Rework FindMembers so that
24180 2001-12-16 Miguel de Icaza <miguel@ximian.com>
24182 * class.cs (TypeContainer): Remove Delegates who fail to be
24185 * delegate.cs (Populate): Verify that we dont get null return
24186 values. TODO: Check for AsAccessible.
24188 * cs-parser.jay: Use basename to emit error 574 (destructor should
24189 have the same name as container class), not the full name.
24191 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
24192 possible representation.
24194 Also implements integer type suffixes U and L.
24196 2001-12-15 Miguel de Icaza <miguel@ximian.com>
24198 * expression.cs (ArrayCreation.DoResolve): We need to do the
24199 argument resolution *always*.
24201 * decl.cs: Make this hold the namespace. Hold the root context as
24203 (LookupType): Move here.
24205 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
24207 * location.cs (Row, Name): Fixed the code, it was always returning
24208 references to the first file.
24210 * interface.cs: Register properties defined through interfaces.
24212 * driver.cs: Add support for globbing on the command line
24214 * class.cs (Field): Make it derive from MemberCore as well.
24217 2001-12-15 Ravi Pratap <ravi@ximian.com>
24219 * class.cs (Event::Define): Check that the type of the event is a delegate
24220 type else flag error #66.
24222 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
24225 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
24226 values of EntryPoint, CharSet etc etc.
24228 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
24230 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
24231 be null and we should ignore this. I am not sure if this is really clean. Apparently,
24232 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
24233 which needs this to do its work.
24235 * ../errors/cs0066.cs : Add.
24237 2001-12-14 Miguel de Icaza <miguel@ximian.com>
24239 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
24242 * class.cs: (MethodSignature.MethodSignature): Removed hack that
24243 clears out the parameters field.
24244 (MemberSignatureCompare): Cleanup
24246 (MemberCore): New base class used to share code between MethodCore
24249 (RegisterRequiredImplementations) BindingFlags.Public requires
24250 either BindingFlags.Instace or Static. Use instance here.
24252 (Property): Refactored code to cope better with the full spec.
24254 * parameter.cs (GetParameterInfo): Return an empty array instead
24257 * class.cs (Property): Abstract or extern properties have no bodies.
24259 * parameter.cs (GetParameterInfo): return a zero-sized array.
24261 * class.cs (TypeContainer.MethodModifiersValid): Move all the
24262 method modifier validation to the typecontainer so we can reuse
24263 this on properties.
24265 (MethodCore.ParameterTypes): return an empty sized array of types.
24267 (Property.Define): Test property modifier validity.
24269 Add tests for sealed/override too.
24271 (Method.Emit): abstract or extern methods have no bodies.
24273 2001-12-14 Ravi Pratap <ravi@ximian.com>
24275 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
24278 (Method::Define, ::Emit): Modify accordingly.
24280 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
24282 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
24284 * makefile: Pass in /unsafe.
24286 2001-12-13 Miguel de Icaza <miguel@ximian.com>
24288 * class.cs (MakeKey): Kill routine.
24290 * class.cs (TypeContainer.Define): Correctly define explicit
24291 method implementations (they require the full interface name plus
24294 * typemanager.cs: Deply the PtrHashtable here and stop using the
24295 lame keys. Things work so much better.
24297 This of course broke everyone who depended on `RegisterMethod' to
24298 do the `test for existance' test. This has to be done elsewhere.
24300 * support.cs (PtrHashtable): A hashtable that avoid comparing with
24301 the object stupid Equals method (because, that like fails all over
24302 the place). We still do not use it.
24304 * class.cs (TypeContainer.SetRequiredInterface,
24305 TypeContainer.RequireMethods): Killed these two routines and moved
24306 all the functionality to RegisterRequiredImplementations.
24308 (TypeContainer.RegisterRequiredImplementations): This routine now
24309 registers all the implementations required in an array for the
24310 interfaces and abstract methods. We use an array of structures
24311 which can be computed ahead of time to reduce memory usage and we
24312 also assume that lookups are cheap as most classes will not
24313 implement too many interfaces.
24315 We also avoid creating too many MethodSignatures.
24317 (TypeContainer.IsInterfaceMethod): Update and optionally does not
24318 clear the "pending" bit if we find that there are problems with
24321 (TypeContainer.VerifyPendingMethods): Update to report errors of
24322 methods that look like implementations but are not.
24324 (TypeContainer.Define): Add support for explicit interface method
24327 2001-12-12 Miguel de Icaza <miguel@ximian.com>
24329 * typemanager.cs: Keep track of the parameters here instead of
24330 being a feature of the TypeContainer.
24332 * class.cs: Drop the registration of parameters here, as
24333 InterfaceMethods are also interface declarations.
24335 * delegate.cs: Register methods with the TypeManager not only with
24336 the TypeContainer. This code was buggy.
24338 * interface.cs: Full registation here.
24340 2001-12-11 Miguel de Icaza <miguel@ximian.com>
24342 * expression.cs: Remove reducer for binary expressions, it can not
24345 * const.cs: Put here the code that used to go into constant.cs
24347 * constant.cs: Put here the code for constants, this is a new base
24348 class for Literals.
24350 * literal.cs: Make Literal derive from Constant.
24352 2001-12-09 Miguel de Icaza <miguel@ximian.com>
24354 * statement.cs (Return.Emit): Report error 157 if the user
24355 attempts to return from a finally block.
24357 (Return.Emit): Instead of emitting a return, jump to the end of
24360 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
24361 LocalBuilder to store the result of the function. ReturnLabel is
24362 the target where we jump.
24365 2001-12-09 Radek Doulik <rodo@ximian.com>
24367 * cs-parser.jay: remember alias in current namespace
24369 * ecore.cs (SimpleName::DoResolve): use aliases for types or
24372 * class.cs (LookupAlias): lookup alias in my_namespace
24374 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
24376 (LookupAlias): lookup alias in this and if needed in parent
24379 2001-12-08 Miguel de Icaza <miguel@ximian.com>
24383 * rootcontext.cs: (ModuleBuilder) Made static, first step into
24384 making things static. I need this to avoid passing the
24385 TypeContainer when calling ParameterType.
24387 * support.cs (InternalParameters.ParameterType): Remove ugly hack
24388 that did string manipulation to compute the type and then call
24389 GetType. Use Parameter.ParameterType instead.
24391 * cs-tokenizer.cs: Consume the suffix for floating values.
24393 * expression.cs (ParameterReference): figure out whether this is a
24394 reference parameter or not. Kill an extra variable by computing
24395 the arg_idx during emission.
24397 * parameter.cs (Parameters.GetParameterInfo): New overloaded
24398 function that returns whether a parameter is an out/ref value or not.
24400 (Parameter.ParameterType): The type of the parameter (base,
24401 without ref/out applied).
24403 (Parameter.Resolve): Perform resolution here.
24404 (Parameter.ExternalType): The full type (with ref/out applied).
24406 * statement.cs (Using.Emit, Using.EmitExpression): Implement
24407 support for expressions on the using statement.
24409 2001-12-07 Miguel de Icaza <miguel@ximian.com>
24411 * statement.cs (Using.EmitLocalVariableDecls): Split the
24412 localvariable handling of the using statement.
24414 (Block.EmitMeta): Keep track of variable count across blocks. We
24415 were reusing slots on separate branches of blocks.
24417 (Try.Emit): Emit the general code block, we were not emitting it.
24419 Check the type of the declaration to be an IDisposable or
24420 something that can be implicity converted to it.
24422 Emit conversions if required.
24424 * ecore.cs (EmptyExpression): New utility class.
24425 (Expression.ImplicitConversionExists): New utility function.
24427 2001-12-06 Miguel de Icaza <miguel@ximian.com>
24429 * statement.cs (Using): Implement.
24431 * expression.cs (LocalVariableReference): Support read only variables.
24433 * statement.cs: Remove the explicit emit for the Leave opcode.
24434 (VariableInfo): Add a readonly field.
24436 2001-12-05 Miguel de Icaza <miguel@ximian.com>
24438 * ecore.cs (ConvCast): new class used to encapsulate the various
24439 explicit integer conversions that works in both checked and
24440 unchecked contexts.
24442 (Expression.ConvertNumericExplicit): Use new ConvCast class to
24443 properly generate the overflow opcodes.
24445 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24447 * statement.cs: The correct type for the EmptyExpression is the
24448 element_type, not the variable type. Ravi pointed this out.
24450 2001-12-04 Ravi Pratap <ravi@ximian.com>
24452 * class.cs (Method::Define): Handle PInvoke methods specially
24453 by using DefinePInvokeMethod instead of the usual one.
24455 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
24456 above to do the task of extracting information and defining the method.
24458 2001-12-04 Ravi Pratap <ravi@ximian.com>
24460 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
24461 of the condition for string type.
24463 (Emit): Move that here.
24465 (ArrayCreation::CheckIndices): Keep string literals in their expression
24468 (EmitDynamicInitializers): Handle strings appropriately.
24470 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24472 * codegen.cs (EmitContext): Replace multiple variables with a
24473 single pointer to the current Switch statement.
24475 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
24478 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24482 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
24485 (Foreach.Emit): Foreach on arrays was not setting
24486 up the loop variables (for break/continue).
24488 (GotoCase): Semi-implented.
24490 2001-12-03 Ravi Pratap <ravi@ximian.com>
24492 * attribute.cs (CheckAttribute): Handle system attributes by using
24493 Attribute.GetAttributes to examine information we need.
24495 (GetValidPlaces): Same here.
24497 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
24499 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
24501 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
24503 (Method::Define): Set appropriate flags if we have a DllImport attribute.
24505 (Method::Emit): Handle the case when we are a PInvoke method.
24507 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24509 * expression.cs: Use ResolveWithSimpleName on compound names.
24511 2001-12-02 Ravi Pratap <ravi@ximian.com>
24513 * constant.cs (EmitConstant): Make sure we resolve the associated expression
24514 before trying to reduce it.
24516 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
24518 * constant.cs (LookupConstantValue): Implement.
24520 (EmitConstant): Use the above in emitting the constant.
24522 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
24523 that are user-defined by doing a LookupConstantValue on them.
24525 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
24528 2001-11-29 Miguel de Icaza <miguel@ximian.com>
24530 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
24532 (BaseAccess.DoResolve): Implement.
24534 (MemberAccess.DoResolve): Split this routine into a
24535 ResolveMemberAccess routine that can be used independently
24537 2001-11-28 Miguel de Icaza <miguel@ximian.com>
24539 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
24540 As that share bits of the implementation. Is returns a boolean,
24541 while As returns the Type that is being probed.
24543 2001-12-01 Ravi Pratap <ravi@ximian.com>
24545 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
24546 instead of a Literal - much easier.
24548 (EnumInTransit): Remove - utterly useless :-)
24550 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
24552 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
24554 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
24555 chain when we have no associated expression.
24557 2001-11-30 Ravi Pratap <ravi@ximian.com>
24559 * constant.cs (Define): Use Location while reporting the errror.
24561 Also emit a warning when 'new' is used and there is no inherited
24564 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
24567 (LookupEnumValue): Implement to lookup an enum member's value and define it
24570 (Populate): Re-write accordingly to use the above routine.
24572 2001-11-27 Miguel de Icaza <miguel@ximian.com>
24574 * expression.cs (This): Fix prototype for DoResolveLValue to
24575 override the base class DoResolveLValue.
24577 * cs-parser.cs: Report errors cs574 and cs575 (destructor
24580 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
24581 (we need to load the address of the field here). This fixes
24584 (FieldExpr.DoResolveLValue): Call the DoResolve
24585 function to initialize the Instance expression.
24587 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
24588 correctly the GetEnumerator operation on a value type.
24590 * cs-parser.jay: Add more simple parsing error catches.
24592 * statement.cs (Switch): Add support for string switches.
24593 Handle null specially.
24595 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
24597 2001-11-28 Ravi Pratap <ravi@ximian.com>
24599 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
24601 (declare_local_constant): New helper function.
24603 * statement.cs (AddConstant): Keep a separate record of constants
24605 (IsConstant): Implement to determine if a variable is a constant.
24607 (GetConstantExpression): Implement.
24609 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
24611 * statement.cs (IsVariableDefined): Re-write.
24613 2001-11-27 Ravi Pratap <ravi@ximian.com>
24615 * class.cs (TypeContainer::FindMembers): Look for constants
24616 in the case when we are looking for MemberTypes.Field
24618 * expression.cs (MemberAccess::DoResolve): Check that in the
24619 case we are a FieldExpr and a Literal, we are not being accessed
24620 by an instance reference.
24622 * cs-parser.jay (local_constant_declaration): Implement.
24624 (declaration_statement): Implement for constant declarations.
24626 2001-11-26 Miguel de Icaza <miguel@ximian.com>
24628 * statement.cs (Switch): Catch double defaults.
24630 (Switch): More work on the switch() statement
24631 implementation. It works for integral values now, need to finish
24635 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24637 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
24638 integer literals into other integer literals. To be used by
24641 2001-11-24 Ravi Pratap <ravi@ximian.com>
24643 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
24646 (EmitDynamicInitializers): Cope with the above since we extract data
24647 directly from ArrayData now.
24649 (ExpectInitializers): Keep track of whether initializers are mandatory
24652 (Bounds): Make it a hashtable to prevent the same dimension being
24653 recorded for every element in that dimension.
24655 (EmitDynamicInitializers): Fix bug which prevented the Set array method
24658 Also fix bug which was causing the indices to be emitted in the reverse
24661 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24663 * expression.cs (ArrayCreation): Implement the bits that Ravi left
24664 unfinished. They do not work, because the underlying code is
24667 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24669 * cs-parser.jay: Remove bogus fixme.
24671 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
24672 on Switch statement.
24674 2001-11-23 Ravi Pratap <ravi@ximian.com>
24676 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
24679 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
24680 parameter. Apparently, any expression is allowed.
24682 (ValidateInitializers): Update accordingly.
24684 (CheckIndices): Fix some tricky bugs thanks to recursion.
24686 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
24687 I was being completely brain-dead.
24689 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
24690 and re-write acordingly.
24692 (DelegateInvocation): Re-write accordingly.
24694 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
24696 (MakeByteBlob): Handle types more correctly.
24698 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
24699 initialization from expressions but it is incomplete because I am a complete
24702 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24704 * statement.cs (If.Emit): Fix a bug that generated incorrect code
24705 on If. Basically, we have to return `true' (ie, we do return to
24706 our caller) only if both branches of the if return.
24708 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
24709 short-circuit operators, handle them as short circuit operators.
24711 (Cast.DoResolve): Resolve type.
24712 (Cast.Cast): Take an expression as the target type.
24714 * cs-parser.jay (cast_expression): Remove old hack that only
24715 allowed a limited set of types to be handled. Now we take a
24716 unary_expression and we resolve to a type during semantic
24719 Use the grammar productions from Rhys to handle casts (this is
24720 not complete like Rhys syntax yet, we fail to handle that corner
24721 case that C# has regarding (-x), but we will get there.
24723 2001-11-22 Ravi Pratap <ravi@ximian.com>
24725 * class.cs (EmitFieldInitializer): Take care of the case when we have a
24726 field which is an array type.
24728 * cs-parser.jay (declare_local_variables): Support array initialization too.
24730 * typemanager.cs (MakeKey): Implement.
24732 (everywhere): Use the above appropriately.
24734 * cs-parser.jay (for_statement): Update for array initialization while
24735 declaring variables.
24737 * ecore.cs : The error message was correct, it's the variable's names that
24738 were misleading ;-) Make the code more readable.
24740 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
24741 the correct type etc.
24743 (ConvertExplicit): Handle Enum types by examining the underlying type.
24745 2001-11-21 Ravi Pratap <ravi@ximian.com>
24747 * parameter.cs (GetCallingConvention): Always return
24748 CallingConventions.Standard for now.
24750 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24752 * expression.cs (Binary.ResolveOperator): Update the values of `l'
24753 and `r' after calling DoNumericPromotions.
24755 * ecore.cs: Fix error message (the types were in the wrong order).
24757 * statement.cs (Foreach.ProbeCollectionType): Need to pass
24758 BindingFlags.Instance as well
24760 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
24761 implicit int literal conversion in an empty cast so that we
24762 propagate the right type upstream.
24764 (UnboxCast): new class used to unbox value types.
24765 (Expression.ConvertExplicit): Add explicit type conversions done
24768 (Expression.ImplicitNumericConversion): Oops, forgot to test for
24769 the target type before applying the implicit LongLiterals to ULong
24772 2001-11-21 Miguel de Icaza <miguel@ximian.com>
24774 * cs-parser.jay (for_statement): Reworked the way For works: now
24775 we declare manually any variables that are introduced in
24776 for_initializer to solve the problem of having out-of-band code
24777 emition (that is what got for broken).
24779 (declaration_statement): Perform the actual variable declaration
24780 that used to be done in local_variable_declaration here.
24782 (local_variable_declaration): Do not declare anything, just pass
24783 the information on a DictionaryEntry
24785 2001-11-20 Ravi Pratap <ravi@ximian.com>
24787 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
24788 re-write of the logic to now make it recursive.
24790 (UpdateIndices): Re-write accordingly.
24792 Store element data in a separate ArrayData list in the above methods.
24794 (MakeByteBlob): Implement to dump the array data into a byte array.
24796 2001-11-19 Ravi Pratap <ravi@ximian.com>
24798 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
24801 * constant.cs (Define): Implement.
24803 (EmitConstant): Re-write fully.
24805 Pass in location info.
24807 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
24810 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
24811 DictionaryEntry since we need location info too.
24813 (constant_declaration): Update accordingly.
24815 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
24816 code into another method : UpdateIndices.
24818 2001-11-18 Ravi Pratap <ravi@ximian.com>
24820 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
24821 some type checking etc.
24823 2001-11-17 Ravi Pratap <ravi@ximian.com>
24825 * expression.cs (ArrayCreation::ValidateInitializers): Implement
24826 bits to provide dimension info if the user skips doing that.
24828 Update second constructor to store the rank correctly.
24830 2001-11-16 Ravi Pratap <ravi@ximian.com>
24832 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
24833 and try to implement.
24835 * ../errors/cs0150.cs : Add.
24837 * ../errors/cs0178.cs : Add.
24839 2001-11-16 Miguel de Icaza <miguel@ximian.com>
24841 * statement.cs: Implement foreach on multi-dimensional arrays.
24843 * parameter.cs (Parameters.GetParameterByName): Also lookup the
24844 name of the params argument.
24846 * expression.cs: Use EmitStoreOpcode to get the right opcode while
24847 initializing the array.
24849 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
24850 we can use this elsewhere.
24852 * statement.cs: Finish implementation of foreach for single
24855 * cs-parser.jay: Use an out-of-band stack to pass information
24856 around, I wonder why I need this.
24858 foreach_block: Make the new foreach_block the current_block.
24860 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
24861 function used to return a static Parameters structure. Used for
24862 empty parameters, as those are created very frequently.
24864 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24866 2001-11-15 Ravi Pratap <ravi@ximian.com>
24868 * interface.cs : Default modifier is private, not public. The
24869 make verify test passes again.
24871 2001-11-15 Ravi Pratap <ravi@ximian.com>
24873 * support.cs (ReflectionParameters): Fix logic to determine
24874 whether the last parameter is a params one. Test 9 passes again.
24876 * delegate.cs (Populate): Register the builders we define with
24877 RegisterParameterForBuilder. Test 19 passes again.
24879 * cs-parser.jay (property_declaration): Reference $6 instead
24880 of $$ to get at the location.
24882 (indexer_declaration): Similar stuff.
24884 (attribute): Ditto.
24886 * class.cs (Property): Register parameters for the Get and Set methods
24887 if they exist. Test 23 passes again.
24889 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24890 call to EmitArguments as we are sure there aren't any params arguments.
24891 Test 32 passes again.
24893 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24894 IndexOutOfRangeException.
24896 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24897 Test 33 now passes again.
24899 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24901 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24902 broke a bunch of things. Will have to come up with a better way
24903 of tracking locations.
24905 * statement.cs: Implemented foreach for single dimension arrays.
24907 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24909 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24910 an error. This removes the lookup from the critical path.
24912 * cs-parser.jay: Removed use of temporary_loc, which is completely
24915 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24917 * support.cs (ReflectionParameters.ParameterModifier): Report
24918 whether the argument is a PARAMS argument or not.
24920 * class.cs: Set the attribute `ParamArrayAttribute' on the
24921 parameter argument.
24923 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24924 and cons_param_array_attribute (ConstructorInfo for
24925 ParamArrayAttribute).,
24927 * codegen.cs: Emit the return using the `Return' statement, that
24928 way we can report the error correctly for missing return values.
24930 * class.cs (Method.Emit): Clean up.
24932 * expression.cs (Argument.Resolve): Take another argument: the
24933 location where this argument is used. Notice that this is not
24934 part of the "Argument" class as to reduce the size of the
24935 structure (we know the approximate location anyways).
24937 Test if the argument is a variable-reference, if not, then
24938 complain with a 206.
24940 (Argument.Emit): Emit addresses of variables.
24942 (Argument.FullDesc): Simplify.
24944 (Invocation.DoResolve): Update for Argument.Resolve.
24946 (ElementAccess.DoResolve): ditto.
24948 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24949 method should be virtual, as this method is always virtual.
24951 (NewDelegate.DoResolve): Update for Argument.Resolve.
24953 * class.cs (ConstructorInitializer.DoResolve): ditto.
24955 * attribute.cs (Attribute.Resolve): ditto.
24957 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24959 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24961 * expression.cs (ParameterReference): Drop IStackStorage and implement
24962 IAssignMethod instead.
24964 (LocalVariableReference): ditto.
24966 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24967 IAssignMethod instead.
24969 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24971 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24972 enumerations that are used in heavily used structures derive from
24973 byte in a laughable and pathetic attempt to reduce memory usage.
24974 This is the kind of pre-optimzations that you should not do at
24975 home without adult supervision.
24977 * expression.cs (UnaryMutator): New class, used to handle ++ and
24978 -- separatedly from the other unary operators. Cleans up the
24979 code, and kills the ExpressionStatement dependency in Unary.
24981 (Unary): Removed `method' and `Arguments' from this class, making
24982 it smaller, and moving it all to SimpleCall, so I can reuse this
24983 code in other locations and avoid creating a lot of transient data
24984 strucutres when not required.
24986 * cs-parser.jay: Adjust for new changes.
24988 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24990 * enum.cs (Enum.Populate): If there is a failure during
24993 * cs-parser.jay (opt_enum_base): we used to catch type errors
24994 here, but this is really incorrect. The type error should be
24995 catched during semantic analysis.
24997 2001-12-11 Ravi Pratap <ravi@ximian.com>
24999 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
25000 current_local_parameters as expected since I, in my stupidity, had forgotten
25003 * attribute.cs (GetValidPlaces): Fix stupid bug.
25005 * class.cs (Method::Emit): Perform check on applicability of attributes.
25007 (Constructor::Emit): Ditto.
25009 (Field::Emit): Ditto.
25011 (Field.Location): Store location information.
25013 (Property, Event, Indexer, Operator): Ditto.
25015 * cs-parser.jay (field_declaration): Pass in location for each field.
25017 * ../errors/cs0592.cs : Add.
25019 2001-11-12 Ravi Pratap <ravi@ximian.com>
25021 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
25023 (InitCoreTypes): Update accordingly.
25025 (RegisterAttrType, LookupAttr): Implement.
25027 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
25028 info about the same.
25030 (Resolve): Update to populate the above as necessary.
25032 (Error592): Helper.
25034 (GetValidPlaces): Helper to the above.
25036 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
25038 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
25040 2001-11-12 Ravi Pratap <ravi@ximian.com>
25042 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
25044 * ../errors/cs0617.cs : Add.
25046 2001-11-11 Ravi Pratap <ravi@ximian.com>
25048 * enum.cs (Emit): Rename to Populate to be more consistent with what
25049 we expect it to do and when exactly it is called.
25051 * class.cs, rootcontext.cs : Update accordingly.
25053 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
25054 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
25056 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
25058 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
25059 of a fieldinfo using the above, when dealing with a FieldBuilder.
25061 2001-11-10 Ravi Pratap <ravi@ximian.com>
25063 * ../errors/cs0031.cs : Add.
25065 * ../errors/cs1008.cs : Add.
25067 * ../errrors/cs0543.cs : Add.
25069 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
25072 (FindMembers): Implement.
25074 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
25075 enums and delegates too.
25077 (enum_types): Rename to builder_to_enum.
25079 (delegate_types): Rename to builder_to_delegate.
25081 * delegate.cs (FindMembers): Implement.
25083 2001-11-09 Ravi Pratap <ravi@ximian.com>
25085 * typemanager.cs (IsEnumType): Implement.
25087 * enum.cs (Emit): Re-write parts to account for the underlying type
25088 better and perform checking etc.
25090 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
25091 of the underlying type.
25093 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
25096 * enum.cs (error31): Helper to report error #31.
25098 * cs-parser.jay (enum_declaration): Store location of each member too.
25100 * enum.cs (member_to_location): New hashtable.
25102 (AddEnumMember): Update location hashtable.
25104 (Emit): Use the location of each member while reporting errors.
25106 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25108 * cs-parser.jay: A for_initializer if is a
25109 local_variable_declaration really ammount to have an implicit
25110 block with the variable declaration and no initializer for for.
25112 * statement.cs (For.Emit): Cope with null initializers.
25114 This fixes the infinite loop on for initializers.
25116 2001-11-08 Miguel de Icaza <miguel@ximian.com>
25118 * enum.cs: More cleanup.
25120 * ecore.cs: Remove dead code.
25122 * class.cs (Property.Emit): More simplification.
25123 (Event.Emit): ditto.
25125 Reworked to have less levels of indentation.
25127 2001-11-08 Ravi Pratap <ravi@ximian.com>
25129 * class.cs (Property): Emit attributes.
25139 * enum.cs (Emit): Ditto.
25141 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
25144 * class.cs (Field, Event, etc.): Move attribute generation into the
25145 Emit method everywhere.
25147 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
25148 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
25149 as we had no way of defining nested enums !
25151 * rootcontext.cs : Adjust code accordingly.
25153 * typemanager.cs (AddEnumType): To keep track of enum types separately.
25155 2001-11-07 Ravi Pratap <ravi@ximian.com>
25157 * expression.cs (EvalConstantExpression): Move into ecore.cs
25159 * enum.cs (Enum): Rename some members and make them public and readonly
25160 according to our convention.
25162 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
25165 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25167 (Enum::Emit): Write a simple version for now which doesn't try to compute
25168 expressions. I shall modify this to be more robust in just a while.
25170 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
25172 (TypeContainer::CloseType): Create the Enum types too.
25174 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
25176 * expression.cs (EvalConstantExpression): Get rid of completely.
25178 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
25179 user-defined values and other cases.
25181 (IsValidEnumLiteral): Helper function.
25183 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
25184 out there in the case we had a literal FieldExpr.
25186 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
25188 (Literalize): Revamp a bit to take two arguments.
25190 (EnumLiteral): New class which derives from Literal to wrap enum literals.
25192 2001-11-06 Ravi Pratap <ravi@ximian.com>
25194 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
25196 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
25198 (Resolve): Use the above to ensure we have proper initializers.
25200 2001-11-05 Ravi Pratap <ravi@ximian.com>
25202 * expression.cs (Expression::EvalConstantExpression): New method to
25203 evaluate constant expressions.
25205 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
25207 2001-11-07 Miguel de Icaza <miguel@ximian.com>
25209 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
25212 (Binary.ResolveOperator): Handle operator != (object a, object b)
25213 and operator == (object a, object b);
25215 (Binary.DoNumericPromotions): Indicate whether the numeric
25216 promotion was possible.
25218 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
25221 Made the ArrayAccess implement interface IAssignMethod instead of
25222 IStackStore as the order in which arguments are passed reflects
25225 * assign.cs: Instead of using expr.ExprClass to select the way of
25226 assinging, probe for the IStackStore/IAssignMethod interfaces.
25228 * typemanager.cs: Load InitializeArray definition.
25230 * rootcontext.cs (RootContext.MakeStaticData): Used to define
25231 static data that can be used to initialize arrays.
25233 2001-11-05 Miguel de Icaza <miguel@ximian.com>
25235 * expression.cs: Handle operator== and operator!= for booleans.
25237 (Conditioal.Reduce): Implement reducer for the ?: operator.
25239 (Conditional.Resolve): Implement dead code elimination.
25241 (Binary.Resolve): Catch string literals and return a new
25242 concatenated string.
25244 (Unary.Reduce): Implement reduction of unary expressions.
25246 * ecore.cs: Split out the expression core handling here.
25248 (Expression.Reduce): New method used to perform constant folding
25249 and CSE. This is needed to support constant-expressions.
25251 * statement.cs (Statement.EmitBoolExpression): Pass true and false
25252 targets, and optimize for !x.
25254 2001-11-04 Ravi Pratap <ravi@ximian.com>
25256 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
25257 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
25258 set custom atttributes.
25260 * literal.cs (Literal::GetValue): New abstract method to return the actual
25261 value of the literal, cast as an object.
25263 (*Literal): Implement GetValue method.
25265 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
25266 expressions to the arraylist but objects of type Argument.
25268 * class.cs (TypeContainer::Emit): Emit our attributes too.
25270 (Method::Emit, Constructor::Emit): Ditto.
25272 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
25273 to be ignoring earlier.
25275 2001-11-03 Ravi Pratap <ravi@ximian.com>
25277 * attribute.cs (AttributeSection::Define): Implement to do the business
25278 of constructing a CustomAttributeBuilder.
25280 (Attribute): New trivial class. Increases readability of code.
25282 * cs-parser.jay : Update accordingly.
25284 (positional_argument_list, named_argument_list, named_argument): New rules
25286 (attribute_arguments): Use the above so that we are more correct.
25288 2001-11-02 Ravi Pratap <ravi@ximian.com>
25290 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
25291 to perform all checks for a method with a params parameter.
25293 (Invocation::OverloadResolve): Update to use the above method and therefore
25294 cope correctly with params method invocations.
25296 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
25299 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
25300 constructors in our parent too because we can't afford to miss out on
25303 * attribute.cs (AttributeSection): New name for the class Attribute
25305 Other trivial changes to improve readability.
25307 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
25308 use the new class names.
25310 2001-11-01 Ravi Pratap <ravi@ximian.com>
25312 * class.cs (Method::Define): Complete definition for params types too
25314 (Indexer::Define): Ditto.
25316 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
25317 Cope everywhere with a request for info about the array parameter.
25319 2001-11-01 Ravi Pratap <ravi@ximian.com>
25321 * tree.cs (RecordNamespace): Fix up to check for the correct key.
25323 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
25324 local_variable_type to extract the string corresponding to the type.
25326 (local_variable_type): Fixup the action to use the new helper method.
25328 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
25331 * expression.cs : Clean out code which uses the above.
25333 2001-10-31 Ravi Pratap <ravi@ximian.com>
25335 * typemanager.cs (RegisterMethod): Check if we already have an existing key
25336 and bale out if necessary by returning a false.
25338 (RegisterProperty): Ditto.
25340 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
25341 and print out appropriate error messages.
25343 * interface.cs (everywhere): Ditto.
25345 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
25346 location to constructor.
25348 * class.cs (Property, Event, Indexer): Update accordingly.
25350 * ../errors/cs111.cs : Added.
25352 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
25353 of a method, as laid down by the spec.
25355 (Invocation::OverloadResolve): Use the above method.
25357 2001-10-31 Ravi Pratap <ravi@ximian.com>
25359 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
25360 now take a TypeContainer and a Parameters object.
25362 (ParameterData): Modify return type of ParameterModifier method to be
25363 Parameter.Modifier and not a string.
25365 (ReflectionParameters, InternalParameters): Update accordingly.
25367 * expression.cs (Argument::GetParameterModifier): Same here.
25369 * support.cs (InternalParameters::ParameterType): Find a better way of determining
25370 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
25371 symbol in it at all so maybe this is only for now.
25373 2001-10-30 Ravi Pratap <ravi@ximian.com>
25375 * support.cs (InternalParameters): Constructor now takes an extra argument
25376 which is the actual Parameters class.
25378 (ParameterDesc): Update to provide info on ref/out modifiers.
25380 * class.cs (everywhere): Update call to InternalParameters to pass in
25381 the second argument too.
25383 * support.cs (ParameterData): Add ParameterModifier, which is a method
25384 to return the modifier info [ref/out etc]
25386 (InternalParameters, ReflectionParameters): Implement the above.
25388 * expression.cs (Argument::ParameterModifier): Similar function to return
25389 info about the argument's modifiers.
25391 (Invocation::OverloadResolve): Update to take into account matching modifiers
25394 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
25395 a new SetFormalParameters object which we pass to InternalParameters.
25397 2001-10-30 Ravi Pratap <ravi@ximian.com>
25399 * expression.cs (NewArray): Merge into the ArrayCreation class.
25401 2001-10-29 Ravi Pratap <ravi@ximian.com>
25403 * expression.cs (NewArray): Merge classes NewBuiltinArray and
25404 NewUserdefinedArray into one as there wasn't much of a use in having
25407 * expression.cs (Argument): Change field's name to ArgType from Type.
25409 (Type): New readonly property which returns the proper type, taking into
25410 account ref/out modifiers.
25412 (everywhere): Adjust code accordingly for the above.
25414 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
25415 whether we are emitting for a ref or out parameter.
25417 * expression.cs (Argument::Emit): Use the above field to set the state.
25419 (LocalVariableReference::Emit): Update to honour the flag and emit the
25422 * parameter.cs (Attributes): Set the correct flags for ref parameters.
25424 * expression.cs (Argument::FullDesc): New function to provide a full desc.
25426 * support.cs (ParameterData): Add method ParameterDesc to the interface.
25428 (ReflectionParameters, InternalParameters): Implement the above method.
25430 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
25433 (Invocation::FullMethodDesc): Ditto.
25435 2001-10-29 Miguel de Icaza <miguel@ximian.com>
25437 * cs-parser.jay: Add extra production for the second form of array
25440 * expression.cs (ArrayCreation): Update to reflect the above
25443 * Small changes to prepare for Array initialization.
25445 2001-10-28 Miguel de Icaza <miguel@ximian.com>
25447 * typemanager.cs (ImplementsInterface): interface might be null;
25448 Deal with this problem;
25450 Also, we do store negative hits on the cache (null values), so use
25451 this instead of calling t.GetInterfaces on the type everytime.
25453 2001-10-28 Ravi Pratap <ravi@ximian.com>
25455 * typemanager.cs (IsBuiltinType): New method to help determine the same.
25457 * expression.cs (New::DoResolve): Get rid of array creation code and instead
25458 split functionality out into different classes.
25460 (New::FormArrayType): Move into NewBuiltinArray.
25462 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
25465 (NewBuiltinArray): New class to handle creation of built-in arrays.
25467 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
25468 account creation of one-dimensional arrays.
25470 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
25472 (NewUserdefinedArray::DoResolve): Implement.
25474 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
25476 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
25477 we maintain inside the TypeManager. This is necessary to perform lookups on the
25480 (LookupType): Update to perform GetType on the module builders too.
25482 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
25484 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
25486 2001-10-23 Ravi Pratap <ravi@ximian.com>
25488 * expression.cs (New::DoResolve): Implement guts of array creation.
25490 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
25492 2001-10-27 Miguel de Icaza <miguel@ximian.com>
25494 * expression.cs: Fix bug I introduced lsat night that broke
25497 (Expression.Resolve): Report a 246 error (can not resolve name)
25498 if we find a SimpleName in the stream.
25500 (Expression.ResolveLValue): Ditto.
25502 (Expression.ResolveWithSimpleName): This function is a variant of
25503 ResolveName, this one allows SimpleNames to be returned without a
25504 warning. The only consumer of SimpleNames is MemberAccess
25506 2001-10-26 Miguel de Icaza <miguel@ximian.com>
25508 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
25509 might arrive here. I have my doubts that this is correct.
25511 * statement.cs (Lock): Implement lock statement.
25513 * cs-parser.jay: Small fixes to support `lock' and `using'
25515 * cs-tokenizer.cs: Remove extra space
25517 * driver.cs: New flag --checked, allows to turn on integer math
25520 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
25521 Threading.Monitor.Exit
25523 2001-10-23 Miguel de Icaza <miguel@ximian.com>
25525 * expression.cs (IndexerAccess::DoResolveLValue): Set the
25526 Expression Class to be IndexerAccess.
25528 Notice that Indexer::DoResolve sets the eclass to Value.
25530 2001-10-22 Miguel de Icaza <miguel@ximian.com>
25532 * class.cs (TypeContainer::Emit): Emit code for indexers.
25534 * assign.cs (IAssignMethod): New interface implemented by Indexers
25535 and Properties for handling assignment.
25537 (Assign::Emit): Simplify and reuse code.
25539 * expression.cs (IndexerAccess, PropertyExpr): Implement
25540 IAssignMethod, clean up old code.
25542 2001-10-22 Ravi Pratap <ravi@ximian.com>
25544 * typemanager.cs (ImplementsInterface): New method to determine if a type
25545 implements a given interface. Provides a nice cache too.
25547 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
25550 (ConvertReferenceExplicit): Ditto.
25552 * delegate.cs (Delegate::Populate): Update to define the parameters on the
25553 various methods, with correct names etc.
25555 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
25556 Operator.UnaryNegation.
25558 * cs-parser.jay (operator_declarator): Be a little clever in the case where
25559 we have a unary plus or minus operator.
25561 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
25564 * everywhere : update accordingly.
25566 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
25569 * class.cs (Method::Define): For the case where we are implementing a method
25570 inherited from an interface, we need to set the MethodAttributes.Final flag too.
25571 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
25573 2001-10-21 Ravi Pratap <ravi@ximian.com>
25575 * interface.cs (FindMembers): Implement to work around S.R.E
25578 * typemanager.cs (IsInterfaceType): Implement.
25580 (FindMembers): Update to handle interface types too.
25582 * expression.cs (ImplicitReferenceConversion): Re-write bits which
25583 use IsAssignableFrom as that is not correct - it doesn't work.
25585 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
25586 and accordingly override EmitStatement.
25588 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
25589 using the correct logic :-)
25591 2001-10-19 Ravi Pratap <ravi@ximian.com>
25593 * ../errors/cs-11.cs : Add to demonstrate error -11
25595 2001-10-17 Miguel de Icaza <miguel@ximian.com>
25597 * assign.cs (Assign::Resolve): Resolve right hand side first, and
25598 then pass this as a hint to ResolveLValue.
25600 * expression.cs (FieldExpr): Add Location information
25602 (FieldExpr::LValueResolve): Report assignment to readonly
25605 (Expression::ExprClassFromMemberInfo): Pass location information.
25607 (Expression::ResolveLValue): Add new method that resolves an
25610 (Expression::DoResolveLValue): Default invocation calls
25613 (Indexers): New class used to keep track of indexers in a given
25616 (IStackStore): Renamed from LValue, as it did not really describe
25617 what this did. Also ResolveLValue is gone from this interface and
25618 now is part of Expression.
25620 (ElementAccess): Depending on the element access type
25622 * typemanager.cs: Add `indexer_name_type' as a Core type
25623 (System.Runtime.CompilerServices.IndexerNameAttribute)
25625 * statement.cs (Goto): Take a location.
25627 2001-10-18 Ravi Pratap <ravi@ximian.com>
25629 * delegate.cs (Delegate::VerifyDelegate): New method to verify
25630 if two delegates are compatible.
25632 (NewDelegate::DoResolve): Update to take care of the case when
25633 we instantiate a delegate from another delegate.
25635 * typemanager.cs (FindMembers): Don't even try to look up members
25636 of Delegate types for now.
25638 2001-10-18 Ravi Pratap <ravi@ximian.com>
25640 * delegate.cs (NewDelegate): New class to take care of delegate
25643 * expression.cs (New): Split the delegate related code out into
25644 the NewDelegate class.
25646 * delegate.cs (DelegateInvocation): New class to handle delegate
25649 * expression.cs (Invocation): Split out delegate related code into
25650 the DelegateInvocation class.
25652 2001-10-17 Ravi Pratap <ravi@ximian.com>
25654 * expression.cs (New::DoResolve): Implement delegate creation fully
25655 and according to the spec.
25657 (New::DoEmit): Update to handle delegates differently.
25659 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
25660 because of which we were printing out arguments in reverse order !
25662 * delegate.cs (VerifyMethod): Implement to check if the given method
25663 matches the delegate.
25665 (FullDelegateDesc): Implement.
25667 (VerifyApplicability): Implement.
25669 * expression.cs (Invocation::DoResolve): Update to accordingly handle
25670 delegate invocations too.
25672 (Invocation::Emit): Ditto.
25674 * ../errors/cs1593.cs : Added.
25676 * ../errors/cs1594.cs : Added.
25678 * delegate.cs (InstanceExpression, TargetMethod): New properties.
25680 2001-10-16 Ravi Pratap <ravi@ximian.com>
25682 * typemanager.cs (intptr_type): Core type for System.IntPtr
25684 (InitCoreTypes): Update for the same.
25686 (iasyncresult_type, asynccallback_type): Ditto.
25688 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
25691 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
25694 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
25695 the builders for the 4 members of a delegate type :-)
25697 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
25700 * expression.cs (New::DoResolve): Implement guts for delegate creation.
25702 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
25704 2001-10-15 Miguel de Icaza <miguel@ximian.com>
25706 * statement.cs (Break::Emit): Implement.
25707 (Continue::Emit): Implement.
25709 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
25710 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
25711 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
25712 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
25715 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
25716 properties that track the label for the current loop (begin of the
25717 loop and end of the loop).
25719 2001-10-15 Ravi Pratap <ravi@ximian.com>
25721 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
25722 use of emitting anything at all.
25724 * class.cs, rootcontext.cs : Get rid of calls to the same.
25726 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
25728 (Populate): Define the constructor correctly and set the implementation
25731 * typemanager.cs (delegate_types): New hashtable to hold delegates that
25734 (AddDelegateType): Implement.
25736 (IsDelegateType): Implement helper method.
25738 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
25740 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
25741 and accordingly handle it.
25743 * delegate.cs (Populate): Take TypeContainer argument.
25744 Implement bits to define the Invoke method. However, I still haven't figured out
25745 how to take care of the native int bit :-(
25747 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
25748 Qualify the name of the delegate, not its return type !
25750 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
25753 (StandardConversionExists): Checking for array types turns out to be recursive.
25755 (ConvertReferenceExplicit): Implement array conversion.
25757 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
25759 2001-10-12 Ravi Pratap <ravi@ximian.com>
25761 * cs-parser.jay (delegate_declaration): Store the fully qualified
25762 name as it is a type declaration.
25764 * delegate.cs (ReturnType, Name): Rename members to these. Make them
25767 (DefineDelegate): Renamed from Define. Does the same thing essentially,
25768 as TypeContainer::DefineType.
25770 (Populate): Method in which all the definition of the various methods (Invoke)
25773 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
25776 (CloseDelegate): Finally creates the delegate.
25778 * class.cs (TypeContainer::DefineType): Update to define delegates.
25779 (Populate, Emit and CloseType): Do the same thing here too.
25781 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
25782 delegates in all these operations.
25784 2001-10-14 Miguel de Icaza <miguel@ximian.com>
25786 * expression.cs: LocalTemporary: a new expression used to
25787 reference a temporary that has been created.
25789 * assign.cs: Handle PropertyAccess back here, so that we can
25790 provide the proper semantic access to properties.
25792 * expression.cs (Expression::ConvertReferenceExplicit): Implement
25793 a few more explicit conversions.
25795 * modifiers.cs: `NEW' modifier maps to HideBySig.
25797 * expression.cs (PropertyExpr): Make this into an
25798 ExpressionStatement, and support the EmitStatement code path.
25800 Perform get/set error checking, clean up the interface.
25802 * assign.cs: recognize PropertyExprs as targets, and if so, turn
25803 them into toplevel access objects.
25805 2001-10-12 Miguel de Icaza <miguel@ximian.com>
25807 * expression.cs: PropertyExpr::PropertyExpr: use work around the
25810 * typemanager.cs: Keep track here of our PropertyBuilders again to
25811 work around lameness in SRE.
25813 2001-10-11 Miguel de Icaza <miguel@ximian.com>
25815 * expression.cs (LValue::LValueResolve): New method in the
25816 interface, used to perform a second resolution pass for LValues.
25818 (This::DoResolve): Catch the use of this in static methods.
25820 (This::LValueResolve): Implement.
25822 (This::Store): Remove warning, assigning to `this' in structures
25825 (Invocation::Emit): Deal with invocation of
25826 methods on value types. We need to pass the address to structure
25827 methods rather than the object itself. (The equivalent code to
25828 emit "this" for structures leaves the entire structure on the
25829 stack instead of a pointer to it).
25831 (ParameterReference::DoResolve): Compute the real index for the
25832 argument based on whether the method takes or not a `this' pointer
25833 (ie, the method is static).
25835 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
25836 value types returned from functions when we need to invoke a
25837 method on the sturcture.
25840 2001-10-11 Ravi Pratap <ravi@ximian.com>
25842 * class.cs (TypeContainer::DefineType): Method to actually do the business of
25843 defining the type in the Modulebuilder or Typebuilder. This is to take
25844 care of nested types which need to be defined on the TypeBuilder using
25845 DefineNestedMethod.
25847 (TypeContainer::GetClassBases): Implement. Essentially the code from the
25848 methods in RootContext, only ported to be part of TypeContainer.
25850 (TypeContainer::GetInterfaceOrClass): Ditto.
25852 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
25854 * interface.cs (Interface::DefineInterface): New method. Does exactly
25855 what RootContext.CreateInterface did earlier, only it takes care of nested types
25858 (Interface::GetInterfaces): Move from RootContext here and port.
25860 (Interface::GetInterfaceByName): Same here.
25862 * rootcontext.cs (ResolveTree): Re-write.
25864 (PopulateTypes): Re-write.
25866 * class.cs (TypeContainer::Populate): Populate nested types too.
25867 (TypeContainer::Emit): Emit nested members too.
25869 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25870 instead just use the name argument passed in as it is already fully
25873 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25874 to TypeContainer mapping to see if a type is user-defined.
25876 * class.cs (TypeContainer::CloseType): Implement.
25878 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25879 the default constructor.
25881 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25884 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25886 * interface.cs (CloseType): Create the type here.
25888 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25891 Remove all the methods which are now in TypeContainer.
25893 2001-10-10 Ravi Pratap <ravi@ximian.com>
25895 * delegate.cs (Define): Re-write bits to define the delegate
25898 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25900 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25902 * expression.cs (ImplicitReferenceConversion): handle null as well
25903 as a source to convert to any reference type.
25905 * statement.cs (Return): Perform any implicit conversions to
25906 expected return type.
25908 Validate use of return statement.
25910 * codegen.cs (EmitContext): Pass the expected return type here.
25912 * class.cs (Method, Constructor, Property): Pass expected return
25913 type to EmitContext.
25915 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25917 * expression.cs: Make DoResolve take an EmitContext instead of a
25920 Replaced `l' and `location' for `loc', for consistency.
25922 (Error, Warning): Remove unneeded Tc argument.
25924 * assign.cs, literal.cs, constant.cs: Update to new calling
25927 * codegen.cs: EmitContext now contains a flag indicating whether
25928 code is being generated in a static method or not.
25930 * cs-parser.jay: DecomposeQI, new function that replaces the old
25931 QualifiedIdentifier. Now we always decompose the assembled
25932 strings from qualified_identifier productions into a group of
25935 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25937 * rootcontext.cs: Deal with field-less struct types correctly now
25938 by passing the size option to Define Type.
25940 * class.cs: Removed hack that created one static field.
25942 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25944 * statement.cs: Moved most of the code generation here.
25946 2001-10-09 Ravi Pratap <ravi@ximian.com>
25948 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25951 (ElementAccess): Remove useless bits for now - keep checks as the spec
25954 2001-10-08 Ravi Pratap <ravi@ximian.com>
25956 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25957 and start performing checks according to the spec.
25959 2001-10-07 Ravi Pratap <ravi@ximian.com>
25961 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25962 rank_specifiers instead.
25964 (rank_specifiers): Change the order in which the rank specifiers are stored
25966 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25968 * expression.cs (ElementAccess): Implement the LValue interface too.
25970 2001-10-06 Ravi Pratap <ravi@ximian.com>
25972 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25973 except that user defined conversions are not included.
25975 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25976 perform the conversion of the return type, if necessary.
25978 (New::DoResolve): Check whether we are creating an array or an object
25979 and accordingly do the needful.
25981 (New::Emit): Same here.
25983 (New::DoResolve): Implement guts of array creation.
25985 (New::FormLookupType): Helper function.
25987 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25989 * codegen.cs: Removed most of the code generation here, and move the
25990 corresponding code generation bits to the statement classes.
25992 Added support for try/catch/finalize and throw.
25994 * cs-parser.jay: Added support for try/catch/finalize.
25996 * class.cs: Catch static methods having the flags override,
25997 virtual or abstract.
25999 * expression.cs (UserCast): This user cast was not really doing
26000 what it was supposed to do. Which is to be born in fully resolved
26001 state. Parts of the resolution were being performed at Emit time!
26005 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26007 * expression.cs: Implicity convert the result from UserCast.
26009 2001-10-05 Ravi Pratap <ravi@ximian.com>
26011 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
26012 prevented it from working correctly.
26014 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
26015 merely ConvertImplicit.
26017 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26019 * typemanager.cs: Make the LookupTypeContainer function static,
26020 and not per-instance.
26022 * class.cs: Make static FindMembers (the one that takes a Type
26025 * codegen.cs: Add EmitForeach here.
26027 * cs-parser.jay: Make foreach a toplevel object instead of the
26028 inline expansion, as we need to perform semantic analysis on it.
26030 2001-10-05 Ravi Pratap <ravi@ximian.com>
26032 * expression.cs (Expression::ImplicitUserConversion): Rename to
26033 UserDefinedConversion.
26035 (Expression::UserDefinedConversion): Take an extra argument specifying
26036 whether we look for explicit user conversions too.
26038 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
26040 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
26042 (ExplicitUserConversion): Make it a call to UserDefinedConversion
26043 with the appropriate arguments.
26045 * cs-parser.jay (cast_expression): Record location too.
26047 * expression.cs (Cast): Record location info.
26049 (Expression::ConvertExplicit): Take location argument.
26051 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
26052 to determine if we are doing explicit conversions.
26054 (UserCast::Emit): Update accordingly.
26056 (Expression::ConvertExplicit): Report an error if everything fails.
26058 * ../errors/cs0030.cs : Add.
26060 2001-10-04 Miguel de Icaza <miguel@ximian.com>
26062 * modifiers.cs: If the ABSTRACT keyword is present, also set the
26063 virtual and newslot bits.
26065 * class.cs (TypeContainer::RegisterRequiredImplementations):
26066 Record methods we need.
26068 (TypeContainer::MakeKey): Helper function to make keys for
26069 MethodBases, since the Methodbase key is useless.
26071 (TypeContainer::Populate): Call RegisterRequiredImplementations
26072 before defining the methods.
26074 Create a mapping for method_builders_to_methods ahead of time
26075 instead of inside a tight loop.
26077 (::RequireMethods): Accept an object as the data to set into the
26078 hashtable so we can report interface vs abstract method mismatch.
26080 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26082 * report.cs: Make all of it static.
26084 * rootcontext.cs: Drop object_type and value_type computations, as
26085 we have those in the TypeManager anyways.
26087 Drop report instance variable too, now it is a global.
26089 * driver.cs: Use try/catch on command line handling.
26091 Add --probe option to debug the error reporting system with a test
26094 * report.cs: Add support for exiting program when a probe
26095 condition is reached.
26097 2001-10-03 Ravi Pratap <ravi@ximian.com>
26099 * expression.cs (Binary::DoNumericPromotions): Fix the case when
26100 we do a forcible conversion regardless of type, to check if
26101 ForceConversion returns a null.
26103 (Binary::error19): Use location to report error.
26105 (Unary::error23): Use location here too.
26107 * ../errors/cs0019.cs : Check in.
26109 * ../errors/cs0023.cs : Check in.
26111 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
26112 case of a non-null MethodInfo object with a length of 0 !
26114 (Binary::ResolveOperator): Flag error if overload resolution fails to find
26115 an applicable member - according to the spec :-)
26116 Also fix logic to find members in base types.
26118 (Unary::ResolveOperator): Same here.
26120 (Unary::report23): Change name to error23 and make first argument a TypeContainer
26121 as I was getting thoroughly confused between this and error19 :-)
26123 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
26124 (::FindMostEncompassedType): Implement.
26125 (::FindMostEncompassingType): Implement.
26126 (::StandardConversionExists): Implement.
26128 (UserImplicitCast): Re-vamp. We now need info about most specific
26129 source and target types so that we can do the necessary conversions.
26131 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
26132 mathematical union with no duplicates.
26134 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26136 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
26137 in order from base classes to child classes, so that we can in
26138 child classes look up in our parent for method names and
26139 attributes (required for handling abstract, virtual, new, override
26140 constructs: we need to instrospect our base class, and if we dont
26141 populate the classes in order, the introspection might be
26142 incorrect. For example, a method could query its parent before
26143 the parent has any methods and would determine that the parent has
26144 no abstract methods (while it could have had them)).
26146 (RootContext::CreateType): Record the order in which we define the
26149 2001-10-02 Miguel de Icaza <miguel@ximian.com>
26151 * class.cs (TypeContainer::Populate): Also method definitions can
26152 fail now, keep track of this.
26154 (TypeContainer::FindMembers): Implement support for
26155 DeclaredOnly/noDeclaredOnly flag.
26157 (Constructor::Emit) Return the ConstructorBuilder.
26159 (Method::Emit) Return the MethodBuilder.
26160 Check for abstract or virtual methods to be public.
26162 * rootcontext.cs (RootContext::CreateType): Register all the
26163 abstract methods required for the class to be complete and the
26164 interface methods that must be implemented.
26166 * cs-parser.jay: Report error 501 (method requires body if it is
26167 not marked abstract or extern).
26169 * expression.cs (TypeOf::Emit): Implement.
26171 * typemanager.cs: runtime_handle_type, new global type.
26173 * class.cs (Property::Emit): Generate code for properties.
26175 2001-10-02 Ravi Pratap <ravi@ximian.com>
26177 * expression.cs (Unary::ResolveOperator): Find operators on base type
26178 too - we now conform exactly to the spec.
26180 (Binary::ResolveOperator): Same here.
26182 * class.cs (Operator::Define): Fix minor quirk in the tests.
26184 * ../errors/cs0215.cs : Added.
26186 * ../errors/cs0556.cs : Added.
26188 * ../errors/cs0555.cs : Added.
26190 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26192 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
26193 single integer which is really efficient
26195 2001-10-01 Ravi Pratap <ravi@ximian.com>
26197 * expression.cs (Expression::ImplicitUserConversion): Use location
26198 even in the case when we are examining True operators.
26200 * class.cs (Operator::Define): Perform extensive checks to conform
26201 with the rules for operator overloading in the spec.
26203 * expression.cs (Expression::ImplicitReferenceConversion): Implement
26204 some of the other conversions mentioned in the spec.
26206 * typemanager.cs (array_type): New static member for the System.Array built-in
26209 (cloneable_interface): For System.ICloneable interface.
26211 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
26212 we start resolving the tree and populating types.
26214 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
26216 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26218 * expression.cs (Expression::ExprClassFromMemberInfo,
26219 Expression::Literalize): Create literal expressions from
26220 FieldInfos which are literals.
26222 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
26223 type casts, because they were wrong. The test suite in tests
26226 (ImplicitNumericConversion): ushort to ulong requires a widening
26229 Int32 constant to long requires widening cast as well.
26231 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
26232 for integers because the type on the stack is not i4.
26234 2001-09-30 Miguel de Icaza <miguel@ximian.com>
26236 * expression.cs (report118): require location argument.
26238 * parameter.cs: Do not dereference potential null value.
26240 * class.cs: Catch methods that lack the `new' keyword when
26241 overriding a name. Report warnings when `new' is used without
26242 anything being there to override.
26244 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
26246 * class.cs: Only add constructor to hashtable if it is non-null
26247 (as now constructors can fail on define).
26249 (TypeManager, Class, Struct): Take location arguments.
26251 Catch field instance initialization in structs as errors.
26253 accepting_filter: a new filter for FindMembers that is static so
26254 that we dont create an instance per invocation.
26256 (Constructor::Define): Catch errors where a struct constructor is
26259 * cs-parser.jay: Pass location information for various new
26262 * delegate.cs (Delegate): take a location argument.
26264 * driver.cs: Do not call EmitCode if there were problesm in the
26265 Definition of the types, as many Builders wont be there.
26267 * decl.cs (Decl::Decl): Require a location argument.
26269 * cs-tokenizer.cs: Handle properly hex constants that can not fit
26270 into integers, and find the most appropiate integer for it.
26272 * literal.cs: Implement ULongLiteral.
26274 * rootcontext.cs: Provide better information about the location of
26275 failure when CreateType fails.
26277 2001-09-29 Miguel de Icaza <miguel@ximian.com>
26279 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
26282 * expression.cs (Binary::CheckShiftArguments): Add missing type
26284 (Binary::ResolveOperator): Add type to the logical and and logical
26285 or, Bitwise And/Or and Exclusive Or code paths, it was missing
26288 (Binary::DoNumericPromotions): In the case where either argument
26289 is ulong (and most signed types combined with ulong cause an
26290 error) perform implicit integer constant conversions as well.
26292 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26294 * expression.cs (UserImplicitCast): Method should always be
26296 (Invocation::BetterConversion): Simplified test for IntLiteral.
26298 (Expression::ImplicitNumericConversion): Split this routine out.
26299 Put the code that performs implicit constant integer conversions
26302 (Expression::Resolve): Become a wrapper around DoResolve so we can
26303 check eclass and type being set after resolve.
26305 (Invocation::Badness): Remove this dead function
26307 (Binary::ResolveOperator): Do not compute the expensive argumnets
26308 unless we have a union for it.
26310 (Probe::Emit): Is needs to do an isinst and then
26311 compare against null.
26313 (::CanConvert): Added Location argument. If the Location argument
26314 is null (Location.Null), then we do not report errors. This is
26315 used by the `probe' mechanism of the Explicit conversion. We do
26316 not want to generate an error for something that the user
26317 explicitly requested to be casted. But the pipeline for an
26318 explicit cast first tests for potential implicit casts.
26320 So for now, if the Location is null, it means `Probe only' to
26321 avoid adding another argument. Might have to revise this
26324 (ClassCast): New class used to type cast objects into arbitrary
26325 classes (used in Explicit Reference Conversions).
26327 Implement `as' as well.
26329 Reverted all the patches from Ravi below: they were broken:
26331 * The use of `level' as a mechanism to stop recursive
26332 invocations is wrong. That was there just to catch the
26333 bug with a strack trace but not as a way of addressing
26336 To fix the problem we have to *understand* what is going
26337 on and the interactions and come up with a plan, not
26338 just get things going.
26340 * The use of the type conversion cache that I proposed
26341 last night had an open topic: How does this work across
26342 protection domains. A user defined conversion might not
26343 be public in the location where we are applying the
26344 conversion, a different conversion might be selected
26345 (ie, private A->B (better) but public B->A (worse),
26346 inside A, A->B applies, but outside it, B->A will
26349 * On top of that (ie, even if the above is solved),
26350 conversions in a cache need to be abstract. Ie, `To
26351 convert from an Int to a Short use an OpcodeCast', not
26352 `To convert from an Int to a Short use the OpcodeCast on
26353 the variable 5' (which is what this patch was doing).
26355 2001-09-28 Ravi Pratap <ravi@ximian.com>
26357 * expression.cs (Invocation::ConversionExists): Re-write to use
26358 the conversion cache
26360 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
26361 cache all conversions done, not just user-defined ones.
26363 (Invocation::BetterConversion): The real culprit. Use ConversionExists
26364 to determine if a conversion exists instead of acutually trying to
26365 perform the conversion. It's faster too.
26367 (Expression::ConvertExplicit): Modify to use ConversionExists to check
26368 and only then attempt the implicit conversion.
26370 2001-09-28 Ravi Pratap <ravi@ximian.com>
26372 * expression.cs (ConvertImplicit): Use a cache for conversions
26373 already found. Check level of recursion and bail out if necessary.
26375 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26377 * typemanager.cs (string_concat_string_string, string_concat_object_object):
26378 Export standard methods that we expect for string operations.
26380 * statement.cs (Block::UsageWarning): Track usage of variables and
26381 report the errors for not used variables.
26383 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
26386 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26388 * codegen.cs: remove unnneded code
26390 * expression.cs: Removed BuiltinTypeAccess class
26392 Fix the order in which implicit conversions are
26395 The previous fixed dropped support for boxed conversions (adding a
26396 test to the test suite now)
26398 (UserImplicitCast::CanConvert): Remove test for source being null,
26399 that code is broken. We should not feed a null to begin with, if
26400 we do, then we should track the bug where the problem originates
26401 and not try to cover it up here.
26403 Return a resolved expression of type UserImplicitCast on success
26404 rather than true/false. Ravi: this is what I was talking about,
26405 the pattern is to use a static method as a "constructor" for
26408 Also, do not create arguments until the very last minute,
26409 otherwise we always create the arguments even for lookups that
26410 will never be performed.
26412 (UserImplicitCast::Resolve): Eliminate, objects of type
26413 UserImplicitCast are born in a fully resolved state.
26415 * typemanager.cs (InitCoreTypes): Init also value_type
26416 (System.ValueType).
26418 * expression.cs (Cast::Resolve): First resolve the child expression.
26420 (LValue): Add new method AddressOf to be used by
26423 Change the argument of Store to take an EmitContext instead of an
26424 ILGenerator, because things like FieldExpr need to be able to call
26425 their children expression to generate the instance code.
26427 (Expression::Error, Expression::Warning): Sugar functions for
26430 (Expression::MemberLookup): Accept a TypeContainer instead of a
26431 Report as the first argument.
26433 (Expression::ResolvePrimary): Killed. I still want to improve
26434 this as currently the code is just not right.
26436 (Expression::ResolveMemberAccess): Simplify, but it is still
26439 (Unary::Resolve): Catch errors in AddressOf operators.
26441 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
26442 index to a byte for the short-version, or the compiler will choose
26443 the wrong Emit call, which generates the wrong data.
26445 (ParameterReference::Emit, ::Store): same.
26447 (FieldExpr::AddressOf): Implement.
26449 * typemanager.cs: TypeManager: made public variable instead of
26452 * driver.cs: document --fatal.
26454 * report.cs (ErrorMessage, WarningMessage): new names for the old
26455 Error and Warning classes.
26457 * cs-parser.jay (member_access): Turn built-in access to types
26458 into a normal simplename
26460 2001-09-27 Ravi Pratap <ravi@ximian.com>
26462 * expression.cs (Invocation::BetterConversion): Fix to cope
26463 with q being null, since this was introducing a bug.
26465 * expression.cs (ConvertImplicit): Do built-in conversions first.
26467 2001-09-27 Ravi Pratap <ravi@ximian.com>
26469 * expression.cs (UserImplicitCast::Resolve): Fix bug.
26471 2001-09-27 Ravi Pratap <ravi@ximian.com>
26473 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
26474 I had introduced long ago (what's new ?).
26476 * expression.cs (UserImplicitCast::CanConvert): Static method to do
26477 the work of all the checking.
26478 (ConvertImplicit): Call CanConvert and only then create object if necessary.
26479 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
26481 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
26482 that is the right way.
26484 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
26485 overloading resolution. Use everywhere instead of cutting and pasting code.
26487 (Binary::ResolveOperator): Use MakeUnionSet.
26489 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
26490 we have to convert to bool types. Not complete yet.
26492 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26494 * typemanager.cs (TypeManager::CSharpName): support ushort.
26496 * expression.cs (Expression::TryImplicitIntConversion): Attempts
26497 to provide an expression that performsn an implicit constant int
26498 conversion (section 6.1.6).
26499 (Expression::ConvertImplicitRequired): Reworked to include
26500 implicit constant expression conversions.
26502 (Expression::ConvertNumericExplicit): Finished.
26504 (Invocation::Emit): If InstanceExpression is null, then it means
26505 that we perform a call on this.
26507 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26509 * expression.cs (Unary::Emit): Remove some dead code.
26510 (Probe): Implement Resolve and Emit for `is'.
26511 (Expression::ConvertImplicitRequired): Attempt to do constant
26512 expression conversions here. Maybe should be moved to
26513 ConvertImplicit, but I am not sure.
26514 (Expression::ImplicitLongConstantConversionPossible,
26515 Expression::ImplicitIntConstantConversionPossible): New functions
26516 that tell whether is it possible to apply an implicit constant
26517 expression conversion.
26519 (ConvertNumericExplicit): Started work on explicit numeric
26522 * cs-parser.jay: Update operator constants.
26524 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
26525 (Parameters::GetSignature): Hook up VerifyArgs here.
26526 (Parameters::VerifyArgs): Verifies that no two arguments have the
26529 * class.cs (Operator): Update the operator names to reflect the
26530 ones that the spec expects (as we are just stringizing the
26533 * expression.cs (Unary::ResolveOperator): Fix bug: Use
26534 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
26535 previous usage did only work for our methods.
26536 (Expression::ConvertImplicit): Handle decimal implicit numeric
26537 conversions as well.
26538 (Expression::InternalTypeConstructor): Used to invoke constructors
26539 on internal types for default promotions.
26541 (Unary::Emit): Implement special handling for the pre/post
26542 increment/decrement for overloaded operators, as they need to have
26543 the same semantics as the other operators.
26545 (Binary::ResolveOperator): ditto.
26546 (Invocation::ConversionExists): ditto.
26547 (UserImplicitCast::Resolve): ditto.
26549 2001-09-26 Ravi Pratap <ravi@ximian.com>
26551 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
26552 operator, return after emitting body. Regression tests pass again !
26554 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
26555 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
26556 (Invocation::OverloadResolve): Ditto.
26557 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
26559 * everywhere : update calls to the above methods accordingly.
26561 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26563 * assign.cs (Assign): Make it inherit from ExpressionStatement.
26565 * expression.cs (ExpressionStatement): New base class used for
26566 expressions that can appear in statements, so that we can provide
26567 an alternate path to generate expression that do not leave a value
26570 (Expression::Emit, and all the derivatives): We no longer return
26571 whether a value is left on the stack or not. Every expression
26572 after being emitted leaves a single value on the stack.
26574 * codegen.cs (EmitContext::EmitStatementExpression): Use the
26575 facilties of ExpressionStatement if possible.
26577 * cs-parser.jay: Update statement_expression.
26579 2001-09-25 Miguel de Icaza <miguel@ximian.com>
26581 * driver.cs: Change the wording of message
26583 2001-09-25 Ravi Pratap <ravi@ximian.com>
26585 * expression.cs (Binary::ResolveOperator): Had forgottten to set
26586 the type of the expression to the return type of the method if
26587 we have an overloaded operator match ! The regression tests pass again !
26588 (Unary::ResolveOperator): Ditto.
26590 * expression.cs (Invocation::ConversionExists): Correct the member lookup
26591 to find "op_Implicit", not "implicit" ;-)
26592 (UserImplicitCast): New class to take care of user-defined implicit conversions.
26593 (ConvertImplicit, ForceConversion): Take TypeContainer argument
26595 * everywhere : Correct calls to the above accordingly.
26597 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
26598 (ConvertImplicit): Do user-defined conversion if it exists.
26600 2001-09-24 Miguel de Icaza <miguel@ximian.com>
26602 * assign.cs: track location.
26603 (Resolve): Use implicit conversions on assignment.
26605 * literal.cs: Oops. Not good, Emit of short access values should
26606 pass (Bytes) or the wrong argument will be selected.
26608 * expression.cs (Unary::Emit): Emit code for -expr.
26610 (Unary::ResolveOperator): Handle `Substract' for non-constants
26611 (substract from zero from the non-constants).
26612 Deal with Doubles as well.
26614 (Expression::ConvertImplicitRequired): New routine that reports an
26615 error if no implicit conversion exists.
26617 (Invocation::OverloadResolve): Store the converted implicit
26618 expressions if we make them
26620 2001-09-24 Ravi Pratap <ravi@ximian.com>
26622 * class.cs (ConstructorInitializer): Take a Location argument.
26623 (ConstructorBaseInitializer): Same here.
26624 (ConstructorThisInitializer): Same here.
26626 * cs-parser.jay : Update all calls accordingly.
26628 * expression.cs (Unary, Binary, New): Take location argument.
26629 Update accordingly everywhere.
26631 * cs-parser.jay : Update all calls to the above to take a location
26634 * class.cs : Ditto.
26636 2001-09-24 Ravi Pratap <ravi@ximian.com>
26638 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
26639 (Invocation::BetterConversion): Same here
26640 (Invocation::ConversionExists): Ditto.
26642 (Invocation::ConversionExists): Implement.
26644 2001-09-22 Ravi Pratap <ravi@ximian.com>
26646 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
26647 Also take an additional TypeContainer argument.
26649 * All over : Pass in TypeContainer as argument to OverloadResolve.
26651 * typemanager.cs (CSharpName): Update to check for the string type and return
26654 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
26657 2001-09-21 Ravi Pratap <ravi@ximian.com>
26659 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
26660 (Invocation::BetterFunction): Implement.
26661 (Invocation::BetterConversion): Implement.
26662 (Invocation::ConversionExists): Skeleton, no implementation yet.
26664 Okay, things work fine !
26666 2001-09-21 Miguel de Icaza <miguel@ximian.com>
26668 * typemanager.cs: declare and load enum_type, delegate_type and
26671 * expression.cs (Expression::Emit): Now emit returns a value that
26672 tells whether a value is left on the stack or not. This strategy
26673 might be reveted tomorrow with a mechanism that would address
26674 multiple assignments.
26675 (Expression::report118): Utility routine to report mismatches on
26678 (Unary::Report23): Report impossible type/operator combination
26681 (Unary::IsIncrementableNumber): Whether the type can be
26682 incremented or decremented with add.
26683 (Unary::ResolveOperator): Also allow enumerations to be bitwise
26685 (Unary::ResolveOperator): Implement ++, !, ~,
26687 (Invocation::Emit): Deal with new Emit convetion.
26689 * All Expression derivatives: Updated their Emit method to return
26690 whether they leave values on the stack or not.
26692 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
26693 stack for expressions that are statements.
26695 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26697 * expression.cs (LValue): New interface. Must be implemented by
26699 (LocalVariableReference, ParameterReference, FieldExpr): Implement
26702 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
26703 interface for generating code, simplifies the code.
26705 2001-09-20 Ravi Pratap <ravi@ximian.com>
26707 * expression.cs (everywhere): Comment out return statements in ::Resolve
26708 methods to avoid the warnings.
26710 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26712 * driver.cs (parse): Report error 2001 if we can not open the
26715 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
26718 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
26721 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
26722 otherwise nested blocks end up with the same index.
26724 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
26726 * expression.cs: Instead of having FIXMEs in the Resolve
26727 functions, throw exceptions so it is obvious that we are facing a
26730 * cs-parser.jay (invocation_expression): Pass Location information.
26732 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
26733 Use a basename for those routines because .NET does not like paths
26736 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
26739 2001-09-19 Miguel de Icaza <miguel@ximian.com>
26741 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
26742 are loading the correct data types (throws an exception if not).
26743 (TypeManager::InitCoreTypes): Use CoreLookupType
26745 * expression.cs (Unary::ResolveOperator): return the child
26746 expression for expressions which are just +expr.
26747 (Unary::ResolveOperator): Return negative literals for -LITERAL
26748 expressions (otherwise they are Unary {Literal}).
26749 (Invocation::Badness): Take into account `Implicit constant
26750 expression conversions'.
26752 * literal.cs (LongLiteral): Implement long literal class.
26753 (IntLiteral): export the `Value' of the intliteral.
26755 2001-09-19 Ravi Pratap <ravi@ximian.com>
26757 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
26759 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
26760 instead of 'Operator'
26762 * expression.cs (Binary::ResolveOperator): Update accordingly.
26763 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
26766 * cs-parser.jay (unary_expression): Update to use the new names.
26768 * gen-treedump.cs (GetUnary): Same here.
26770 * expression.cs (Unary::Resolve): Implement.
26771 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
26772 operators are found instead of making noise ;-)
26773 (Unary::ResolveOperator): New method to do precisely the same thing which
26774 Binary::ResolveOperator does for Binary expressions.
26775 (Unary.method, .Arguments): Add.
26776 (Unary::OperName): Implement.
26777 (Unary::ForceConversion): Copy and Paste !
26779 * class.cs (Operator::Define): Fix a small bug for the case when we have
26782 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
26783 for the inbuilt operators. Only overloading works for now ;-)
26785 2001-09-18 Miguel de Icaza <miguel@ximian.com>
26787 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
26788 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
26790 * expression.cs (This::Emit): Implement.
26791 (This::Resolve): Implement.
26792 (TypeOf:Resolve): Implement.
26793 (Expression::ResolveSimpleName): Add an implicit this to instance
26795 (MemberAccess::Resolve): Deal with Parameters and Fields.
26796 Bind instance variable to Field expressions.
26797 (FieldExpr::Instance): New field used to track the expression that
26798 represents the object instance.
26799 (FieldExpr::Resolve): Track potential errors from MemberLookup not
26801 (FieldExpr::Emit): Implement.
26803 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
26804 the last instruction contains a return opcode to avoid generating
26805 the last `ret' instruction (this generates correct code, and it is
26806 nice to pass the peverify output).
26808 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
26809 initializer for static and instance variables.
26810 (Constructor::Emit): Allow initializer to be null in the case of
26811 static constructors. Only emit initializer for instance
26814 (TypeContainer::FindMembers): Return a null array if there are no
26817 Also fix the code for the MemberTypes.Method branch, as it was not
26818 scanning that for operators (or tried to access null variables before).
26820 * assign.cs (Assign::Emit): Handle instance and static fields.
26824 * driver.cs: Stop compilation if there are parse errors.
26826 * cs-parser.jay (constructor_declaration): Provide default base
26827 initializer for non-static constructors.
26828 (constructor_declarator): Do not provide a default base
26829 initializers if none was specified.
26830 Catch the fact that constructors should not have parameters.
26832 * class.cs: Do not emit parent class initializers for static
26833 constructors, that should be flagged as an error.
26835 2001-09-18 Ravi Pratap <ravi@ximian.com>
26837 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
26838 Move back code into TypeContainer::Populate.
26840 2001-09-18 Ravi Pratap <ravi@ximian.com>
26842 * class.cs (TypeContainer::AddConstructor): Fix the check to
26843 compare against Name, not Basename.
26844 (Operator::OpType): Change Plus and Minus to Add and Subtract.
26846 * cs-parser.jay : Update accordingly.
26848 * class.cs (TypeContainer::FindMembers): For the case where we are searching
26849 for methods, don't forget to look into the operators too.
26850 (RegisterMethodBuilder): Helper method to take care of this for
26851 methods, constructors and operators.
26852 (Operator::Define): Completely revamp.
26853 (Operator.OperatorMethod, MethodName): New fields.
26854 (TypeContainer::Populate): Move the registering of builders into
26855 RegisterMethodBuilder.
26856 (Operator::Emit): Re-write.
26858 * expression.cs (Binary::Emit): Comment out code path to emit method
26859 invocation stuff for the case when we have a user defined operator. I am
26860 just not able to get it right !
26862 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26864 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26867 (Expression::MemberLookup): Provide a version that allows to
26868 specify the MemberTypes and BindingFlags.
26870 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26871 so it was not fetching variable information from outer blocks.
26873 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26874 Beforefieldinit as it was buggy.
26876 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26877 that Ravi put here.
26879 * class.cs (Constructor::Emit): Only emit if block is not null.
26880 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26881 deal with this by semantically definining it as if the user had
26884 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26885 constructors as we now "emit" them at a higher level.
26887 (TypeContainer::DefineDefaultConstructor): Used to define the
26888 default constructors if none was provided.
26890 (ConstructorInitializer): Add methods Resolve and Emit.
26892 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26894 2001-09-17 Ravi Pratap <ravi@ximian.com>
26896 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26897 the default constructor builder with our hashtable for methodbuilders
26900 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26901 and argument_count is 0 in which case we have a match.
26902 (Binary::ResolveOperator): More null checking and miscellaneous coding
26905 2001-09-17 Ravi Pratap <ravi@ximian.com>
26907 * rootcontext.cs (IsNameSpace): Compare against null.
26909 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26911 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26912 and Unary::Operator.
26914 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26917 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26918 we have overloaded operators.
26919 (Binary::ResolveOperator): Implement the part which does the operator overload
26922 * class.cs (Operator::Emit): Implement.
26923 (TypeContainer::Emit): Emit the operators we have too.
26925 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26926 the case when we have a user-defined operator.
26928 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26930 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26932 2001-09-16 Ravi Pratap <ravi@ximian.com>
26934 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26935 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26936 (Constructor::Emit): Implement.
26937 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26938 if we have no work to do.
26939 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26942 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26943 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26945 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26948 2001-09-15 Ravi Pratap <ravi@ximian.com>
26950 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26952 (Tree::RecordNamespace): Method to do what the name says ;-)
26953 (Tree::Namespaces): Property to get at the namespaces hashtable.
26955 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26958 * rootcontext.cs (IsNamespace): Fixed it :-)
26960 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26962 * class.cs (TypeContainer::FindMembers): Add support for
26964 (MethodCore): New class that encapsulates both the shared aspects
26965 of a Constructor and a Method.
26966 (Method, Constructor): Factored pieces into MethodCore.
26968 * driver.cs: Added --fatal which makes errors throw exceptions.
26969 Load System assembly as well as part of the standard library.
26971 * report.cs: Allow throwing exceptions on errors for debugging.
26973 * modifiers.cs: Do not use `parent', instead use the real type
26974 container to evaluate permission settings.
26976 * class.cs: Put Ravi's patch back in. He is right, and we will
26977 have to cope with the
26979 2001-09-14 Ravi Pratap <ravi@ximian.com>
26981 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26982 FamORAssem, not FamANDAssem.
26984 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26986 * driver.cs: Added --parse option that only parses its input files
26989 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26990 incorrect. IsTopLevel is not used to tell whether an object is
26991 root_types or not (that can be achieved by testing this ==
26992 root_types). But to see if this is a top-level *class* (not
26993 necessarly our "toplevel" container).
26995 2001-09-14 Ravi Pratap <ravi@ximian.com>
26997 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26998 parent instead of a direct call to GetType.
27000 2001-09-14 Ravi Pratap <ravi@ximian.com>
27002 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
27003 Modifiers.TypeAttr. This should just be a call to that method.
27005 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
27006 object so that we can determine if we are top-level or not.
27008 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
27011 * enum.cs (Enum::Define): Ditto.
27013 * modifiers.cs (FieldAttr): Re-write.
27015 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
27016 (TypeContainer::HaveStaticConstructor): New property to provide access
27017 to precisely that info.
27019 * modifiers.cs (MethodAttr): Re-write.
27020 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
27022 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
27023 of top-level types as claimed.
27025 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27027 * expression.cs (MemberLookup): Fruitless attempt to lookup
27028 constructors. Maybe I need to emit default constructors? That
27029 might be it (currently .NET emits this for me automatically).
27030 (Invocation::OverloadResolve): Cope with Arguments == null.
27031 (Invocation::EmitArguments): new function, shared by the new
27032 constructor and us.
27033 (Invocation::Emit): Handle static and instance methods. Emit
27034 proper call instruction for virtual or non-virtual invocations.
27035 (New::Emit): Implement.
27036 (New::Resolve): Implement.
27037 (MemberAccess:Resolve): Implement.
27038 (MethodGroupExpr::InstanceExpression): used conforming to the spec
27039 to track instances.
27040 (FieldExpr::Resolve): Set type.
27042 * support.cs: Handle empty arguments.
27044 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
27045 SimpleLookup): Auxiliary routines to help parse a qualifier
27048 Update qualifier_identifier rule.
27050 * codegen.cs: Removed debugging messages.
27052 * class.cs: Make this a global thing, this acts just as a "key" to
27053 objects that we might have around.
27055 (Populate): Only initialize method_builders_to_methods once.
27057 * expression.cs (PropertyExpr): Initialize type from the
27060 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
27061 Resolve pattern. Attempt to implicitly convert value to boolean.
27064 * expression.cs: Set the type for the int32/int32 argument case.
27065 (Binary::ResolveOperator): Set the return type to boolean for
27066 comparission operators
27068 * typemanager.cs: Remove debugging print code.
27070 (Invocation::Resolve): resolve type.
27072 * class.cs: Allocate a MemberInfo of the correct size, as the code
27073 elsewhere depends on the test to reflect the correct contents.
27075 (Method::) Keep track of parameters, due to System.Reflection holes
27077 (TypeContainer::Populate): Keep track of MethodBuilders to Method
27080 (TypeContainer::FindMembers): Use ArrayList and then copy an array
27081 of the exact size and return that.
27083 (Class::LookupMethodByBuilder): New function that maps
27084 MethodBuilders to its methods. Required to locate the information
27085 on methods because System.Reflection bit us again.
27087 * support.cs: New file, contains an interface ParameterData and
27088 two implementations: ReflectionParameters and InternalParameters
27089 used to access Parameter information. We will need to grow this
27092 * expression.cs (Invocation::GetParameterData): implement a cache
27093 and a wrapper around the ParameterData creation for methods.
27094 (Invocation::OverloadResolve): Use new code.
27096 2001-09-13 Ravi Pratap <ravi@ximian.com>
27098 * class.cs (TypeContainer::EmitField): Remove and move into
27099 (Field::Define): here and modify accordingly.
27100 (Field.FieldBuilder): New member.
27101 (TypeContainer::Populate): Update accordingly.
27102 (TypeContainer::FindMembers): Implement.
27104 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27106 * statement.cs: (VariableInfo::VariableType): New field to be
27107 initialized with the full type once it is resolved.
27109 2001-09-12 Miguel de Icaza <miguel@ximian.com>
27111 * parameter.cs (GetParameterInfo): Use a type cache to compute
27112 things only once, and to reuse this information
27114 * expression.cs (LocalVariableReference::Emit): Implement.
27115 (OpcodeCast::Emit): fix.
27117 (ParameterReference::Resolve): Implement.
27118 (ParameterReference::Emit): Implement.
27120 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
27121 that are expressions need to stay as Expressions.
27123 * typemanager.cs (CSharpName): Returns the C# name of a type if
27126 * expression.cs (Expression::ConvertImplicit): New function that
27127 implements implicit type conversions.
27129 (Expression::ImplicitReferenceConversion): Implements implicit
27130 reference conversions.
27132 (EmptyCast): New type for transparent casts.
27134 (OpcodeCast): New type for casts of types that are performed with
27135 a sequence of bytecodes.
27137 (BoxedCast): New type used for casting value types into reference
27138 types. Emits a box opcode.
27140 (Binary::DoNumericPromotions): Implements numeric promotions of
27141 and computation of the Binary::Type.
27143 (Binary::EmitBranchable): Optimization.
27145 (Binary::Emit): Implement code emission for expressions.
27147 * typemanager.cs (TypeManager): Added two new core types: sbyte
27150 2001-09-12 Ravi Pratap <ravi@ximian.com>
27152 * class.cs (TypeContainer::FindMembers): Method which does exactly
27153 what Type.FindMembers does, only we don't have to use reflection. No
27154 implementation yet.
27156 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
27157 typecontainer objects as we need to get at them.
27158 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
27160 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
27161 typecontainer object.
27163 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
27164 of just a Report object.
27166 2001-09-11 Ravi Pratap <ravi@ximian.com>
27168 * class.cs (Event::Define): Go back to using the prefixes "add_" and
27170 (TypeContainer::Populate): Now define the delegates of the type too.
27171 (TypeContainer.Delegates): Property to access the list of delegates defined
27174 * delegates.cs (Delegate::Define): Implement partially.
27176 * modifiers.cs (TypeAttr): Handle more flags.
27178 2001-09-11 Ravi Pratap <ravi@ximian.com>
27180 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
27182 (Operator::Define): Re-write logic to get types by using the LookupType method
27183 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
27184 (Indexer::Define): Ditto.
27185 (Event::Define): Ditto.
27186 (Property::Define): Ditto.
27188 2001-09-10 Ravi Pratap <ravi@ximian.com>
27190 * class.cs (TypeContainer::Populate): Now define operators too.
27191 (TypeContainer.Operators): New property to access the list of operators
27193 (Operator.OperatorMethodBuilder): New member to hold the method builder
27194 for the operator we are defining.
27195 (Operator::Define): Implement.
27197 2001-09-10 Ravi Pratap <ravi@ximian.com>
27199 * class.cs (Event::Define): Make the prefixes of the accessor methods
27200 addOn_ and removeOn_
27202 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
27203 of the location being passed in too. Ideally, this should go later since all
27204 error reporting should be done through the Report object.
27206 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
27207 (Populate): Iterate thru the indexers we have and define them too.
27208 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
27209 for the get and set accessors.
27210 (Indexer::Define): Implement.
27212 2001-09-09 Miguel de Icaza <miguel@ximian.com>
27214 * expression.cs (Binary::Resolve): Beginning of it. I scratched
27215 my previous implementation, did not work.
27217 * typemanager.cs: Add a couple of missing types (the longs).
27219 * literal.cs: Use TypeManager.bool_type instead of getting it.
27221 * expression.cs (EventExpr): New kind of expressions.
27222 (Expressio::ExprClassFromMemberInfo): finish
27224 2001-09-08 Miguel de Icaza <miguel@ximian.com>
27226 * assign.cs: Emit stores to static fields differently.
27228 2001-09-08 Ravi Pratap <ravi@ximian.com>
27230 * Merge in changes and adjust code to tackle conflicts. Backed out my
27231 code in Assign::Resolve ;-)
27233 2001-09-08 Ravi Pratap <ravi@ximian.com>
27235 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
27236 instead Report.Error and also pass in the location.
27237 (CSharpParser::Lexer): New readonly property to return the reference
27238 to the Tokenizer object.
27239 (declare_local_variables): Use Report.Error with location instead of plain
27243 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
27244 (Operator.CheckBinaryOperator): Ditto.
27246 * cs-parser.jay (operator_declarator): Update accordingly.
27248 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
27249 (CheckBinaryOperator): Same here.
27251 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
27252 on the name without any prefixes of namespace names etc. This is because we
27253 already might have something already fully qualified like
27254 'System.Console.WriteLine'
27256 * assign.cs (Resolve): Begin implementation. Stuck ;-)
27258 2001-09-07 Ravi Pratap <ravi@ximian.com>
27260 * cs-tokenizer.cs (location): Return a string which also contains
27263 * expression.cs (ElementAccess): New class for expressions of the
27264 type 'element access.'
27265 (BaseAccess): New class for expressions of the type 'base access.'
27266 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
27269 * cs-parser.jay (element_access): Implement action.
27270 (base_access): Implement actions.
27271 (checked_expression, unchecked_expression): Implement.
27273 * cs-parser.jay (local_variable_type): Correct and implement.
27274 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
27276 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
27278 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
27279 name and the specifiers.
27281 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
27283 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
27284 making them all public ;-)
27286 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
27289 2001-09-07 Miguel de Icaza <miguel@ximian.com>
27291 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
27293 (FieldExpr, PropertyExprs): New resolved expressions.
27294 (SimpleName::MemberStaticCheck): Perform static checks for access
27295 to non-static fields on static methods. Maybe this should be
27296 generalized for MemberAccesses.
27297 (SimpleName::ResolveSimpleName): More work on simple name
27300 * cs-parser.jay (primary_expression/qualified_identifier): track
27301 the parameter index.
27303 * codegen.cs (CodeGen::Save): Catch save exception, report error.
27304 (EmitContext::EmitBoolExpression): Chain to expression generation
27305 instead of temporary hack.
27306 (::EmitStatementExpression): Put generic expression code generation.
27308 * assign.cs (Assign::Emit): Implement variable assignments to
27309 local variables, parameters and fields.
27311 2001-09-06 Miguel de Icaza <miguel@ximian.com>
27313 * statement.cs (Block::GetVariableInfo): New method, returns the
27314 VariableInfo for a variable name in a block.
27315 (Block::GetVariableType): Implement in terms of GetVariableInfo
27317 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
27318 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
27320 2001-09-06 Ravi Pratap <ravi@ximian.com>
27322 * cs-parser.jay (operator_declaration): Continue on my quest : update
27323 to take attributes argument.
27324 (event_declaration): Ditto.
27325 (enum_declaration): Ditto.
27326 (indexer_declaration): Ditto.
27328 * class.cs (Operator::Operator): Update constructor accordingly.
27329 (Event::Event): Ditto.
27331 * delegate.cs (Delegate::Delegate): Same here.
27333 * enum.cs (Enum::Enum): Same here.
27335 2001-09-05 Ravi Pratap <ravi@ximian.com>
27337 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
27339 * ../tests/cs0658.cs : New file to demonstrate error 0658.
27341 * attribute.cs (Attributes): New class to encapsulate all attributes which were
27342 being passed around as an arraylist.
27343 (Attributes::AddAttribute): Method to add attribute sections.
27345 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
27346 (struct_declaration): Update accordingly.
27347 (constant_declaration): Update.
27348 (field_declaration): Update.
27349 (method_header): Update.
27350 (fixed_parameter): Update.
27351 (parameter_array): Ditto.
27352 (property_declaration): Ditto.
27353 (destructor_declaration): Ditto.
27355 * class.cs (Struct::Struct): Update constructors accordingly.
27356 (Class::Class): Ditto.
27357 (Field::Field): Ditto.
27358 (Method::Method): Ditto.
27359 (Property::Property): Ditto.
27360 (TypeContainer::OptAttribute): update property's return type.
27362 * interface.cs (Interface.opt_attributes): New member.
27363 (Interface::Interface): Update to take the extra Attributes argument.
27365 * parameter.cs (Parameter::Parameter): Ditto.
27367 * constant.cs (Constant::Constant): Ditto.
27369 * interface.cs (InterfaceMemberBase): New OptAttributes field.
27370 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
27371 the attributes as a parameter.
27372 (InterfaceProperty): Update constructor call.
27373 (InterfaceEvent): Ditto.
27374 (InterfaceMethod): Ditto.
27375 (InterfaceIndexer): Ditto.
27377 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
27378 pass the attributes too.
27379 (interface_event_declaration): Ditto.
27380 (interface_property_declaration): Ditto.
27381 (interface_method_declaration): Ditto.
27382 (interface_declaration): Ditto.
27384 2001-09-05 Miguel de Icaza <miguel@ximian.com>
27386 * class.cs (Method::Define): Track the "static Main" definition to
27387 create an entry point.
27389 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
27390 EntryPoint if we find it.
27392 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
27393 (EmitContext::ig): Make this variable public.
27395 * driver.cs: Make the default output file be the first file name
27396 with the .exe extension.
27398 Detect empty compilations
27400 Handle various kinds of output targets. Handle --target and
27401 rename -t to --dumper.
27403 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
27404 methods inherited from Expression return now an Expression. This
27405 will is used during the tree rewriting as we resolve them during
27408 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
27409 the spec. Missing entirely is the information about
27410 accessability of elements of it.
27412 (Expression::ExprClassFromMemberInfo): New constructor for
27413 Expressions that creates a fully initialized Expression based on
27414 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
27417 (Invocation::Resolve): Begin implementing resolution of invocations.
27419 * literal.cs (StringLiteral): Implement Emit.
27421 2001-09-05 Ravi Pratap <ravi@ximian.com>
27423 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
27426 2001-09-04 Ravi Pratap <ravi@ximian.com>
27428 * cs-parser.jay (attribute_arguments): Implement actions.
27429 (attribute): Fix bug in production. Implement action.
27430 (attribute_list): Implement.
27431 (attribute_target): Implement.
27432 (attribute_target_specifier, opt_target_specifier): Implement
27433 (CheckAttributeTarget): New method to check if the attribute target
27435 (attribute_section): Implement.
27436 (opt_attributes): Implement.
27438 * attribute.cs : New file to handle attributes.
27439 (Attribute): Class to hold attribute info.
27441 * cs-parser.jay (opt_attribute_target_specifier): Remove production
27442 (attribute_section): Modify production to use 2 different rules to
27443 achieve the same thing. 1 s/r conflict down !
27444 Clean out commented, useless, non-reducing dimension_separator rules.
27446 * class.cs (TypeContainer.attributes): New member to hold list
27447 of attributes for a type.
27448 (Struct::Struct): Modify to take one more argument, the attribute list.
27449 (Class::Class): Ditto.
27450 (Field::Field): Ditto.
27451 (Method::Method): Ditto.
27452 (Property::Property): Ditto.
27454 * cs-parser.jay (struct_declaration): Update constructor call to
27455 pass in the attributes too.
27456 (class_declaration): Ditto.
27457 (constant_declaration): Ditto.
27458 (field_declaration): Ditto.
27459 (method_header): Ditto.
27460 (fixed_parameter): Ditto.
27461 (parameter_array): Ditto.
27462 (property_declaration): Ditto.
27464 * constant.cs (Constant::Constant): Update constructor similarly.
27465 Use System.Collections.
27467 * parameter.cs (Parameter::Parameter): Update as above.
27469 2001-09-02 Ravi Pratap <ravi@ximian.com>
27471 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
27472 (TypeContainer.delegates): New member to hold list of delegates.
27474 * cs-parser.jay (delegate_declaration): Implement the action correctly
27475 this time as I seem to be on crack ;-)
27477 2001-09-02 Miguel de Icaza <miguel@ximian.com>
27479 * rootcontext.cs (RootContext::IsNamespace): new function, used to
27480 tell whether an identifier represents a namespace.
27482 * expression.cs (NamespaceExpr): A namespace expression, used only
27483 temporarly during expression resolution.
27484 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
27485 utility functions to resolve names on expressions.
27487 2001-09-01 Miguel de Icaza <miguel@ximian.com>
27489 * codegen.cs: Add hook for StatementExpressions.
27491 * class.cs: Fix inverted test for static flag in methods.
27493 2001-09-02 Ravi Pratap <ravi@ximian.com>
27495 * class.cs (Operator::CheckUnaryOperator): Correct error number used
27496 to make it coincide with MS' number.
27497 (Operator::CheckBinaryOperator): Ditto.
27499 * ../errors/errors.txt : Remove error numbers added earlier.
27501 * ../errors/cs1019.cs : Test case for error # 1019
27503 * ../errros/cs1020.cs : Test case for error # 1020
27505 * cs-parser.jay : Clean out commented cruft.
27506 (dimension_separators, dimension_separator): Comment out. Ostensibly not
27507 used anywhere - non-reducing rule.
27508 (namespace_declarations): Non-reducing rule - comment out.
27510 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
27511 with TypeContainer::AddEnum.
27513 * delegate.cs : New file for delegate handling classes.
27514 (Delegate): Class for declaring delegates.
27516 * makefile : Update.
27518 * cs-parser.jay (delegate_declaration): Implement.
27520 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
27522 * class.cs (Event::Define): Implement.
27523 (Event.EventBuilder): New member.
27525 * class.cs (TypeContainer::Populate): Update to define all enums and events
27527 (Events): New property for the events arraylist we hold. Shouldn't we move to using
27528 readonly fields for all these cases ?
27530 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27532 * class.cs (Property): Revamp to use the convention of making fields readonly.
27533 Accordingly modify code elsewhere.
27535 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
27536 the Define method of the Property class.
27538 * class.cs : Clean up applied patch and update references to variables etc. Fix
27540 (TypeContainer::Populate): Update to define all the properties we have. Also
27541 define all enumerations.
27543 * enum.cs (Define): Implement.
27545 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27547 * cs-parser.jay (overloadable_operator): The semantic value is an
27548 enum of the Operator class.
27549 (operator_declarator): Implement actions.
27550 (operator_declaration): Implement.
27552 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
27553 validity of definitions.
27554 (Operator::CheckBinaryOperator): Static method to check for binary operators
27555 (TypeContainer::AddOperator): New method to add an operator to a type.
27557 * cs-parser.jay (indexer_declaration): Added line to actually call the
27558 AddIndexer method so it gets added ;-)
27560 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
27561 already taken care of by the MS compiler ?
27563 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27565 * class.cs (Operator): New class for operator declarations.
27566 (Operator::OpType): Enum for the various operators.
27568 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27570 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
27571 ostensibly handle this in semantic analysis.
27573 * cs-parser.jay (general_catch_clause): Comment out
27574 (specific_catch_clauses, specific_catch_clause): Ditto.
27575 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
27576 (catch_args, opt_catch_args): New productions.
27577 (catch_clause): Rewrite to use the new productions above
27578 (catch_clauses): Modify accordingly.
27579 (opt_catch_clauses): New production to use in try_statement
27580 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
27581 and re-write the code in the actions to extract the specific and
27582 general catch clauses by being a little smart ;-)
27584 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
27585 Hooray, try and catch statements parse fine !
27587 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27589 * statement.cs (Block::GetVariableType): Fix logic to extract the type
27590 string from the hashtable of variables.
27592 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
27593 I end up making that mistake ;-)
27594 (catch_clauses): Fixed gross error which made Key and Value of the
27595 DictionaryEntry the same : $1 !!
27597 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27599 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
27601 * cs-parser.jay (event_declaration): Correct to remove the semicolon
27602 when the add and remove accessors are specified.
27604 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27606 * cs-parser.jay (IndexerDeclaration): New helper class to hold
27607 information about indexer_declarator.
27608 (indexer_declarator): Implement actions.
27609 (parsing_indexer): New local boolean used to keep track of whether
27610 we are parsing indexers or properties. This is necessary because
27611 implicit_parameters come into picture even for the get accessor in the
27612 case of an indexer.
27613 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
27615 * class.cs (Indexer): New class for indexer declarations.
27616 (TypeContainer::AddIndexer): New method to add an indexer to a type.
27617 (TypeContainer::indexers): New member to hold list of indexers for the
27620 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27622 * cs-parser.jay (add_accessor_declaration): Implement action.
27623 (remove_accessor_declaration): Implement action.
27624 (event_accessors_declaration): Implement
27625 (variable_declarators): swap statements for first rule - trivial.
27627 * class.cs (Event): New class to hold information about event
27629 (TypeContainer::AddEvent): New method to add an event to a type
27630 (TypeContainer::events): New member to hold list of events.
27632 * cs-parser.jay (event_declaration): Implement actions.
27634 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27636 * cs-parser.jay (dim_separators): Implement. Make it a string
27637 concatenating all the commas together, just as they appear.
27638 (opt_dim_separators): Modify accordingly
27639 (rank_specifiers): Update accordingly. Basically do the same
27640 thing - instead, collect the brackets here.
27641 (opt_rank_sepcifiers): Modify accordingly.
27642 (array_type): Modify to actually return the complete type string
27643 instead of ignoring the rank_specifiers.
27644 (expression_list): Implement to collect the expressions
27645 (variable_initializer): Implement. We make it a list of expressions
27646 essentially so that we can handle the array_initializer case neatly too.
27647 (variable_initializer_list): Implement.
27648 (array_initializer): Make it a list of variable_initializers
27649 (opt_array_initializer): Modify accordingly.
27651 * expression.cs (New::NType): Add enumeration to help us
27652 keep track of whether we have an object/delegate creation
27653 or an array creation.
27654 (New:NewType, New::Rank, New::Indices, New::Initializers): New
27655 members to hold data about array creation.
27656 (New:New): Modify to update NewType
27657 (New:New): New Overloaded contructor for the array creation
27660 * cs-parser.jay (array_creation_expression): Implement to call
27661 the overloaded New constructor.
27663 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
27665 * class.cs (TypeContainer::Constructors): Return member
27666 constructors instead of returning null.
27668 2001-08-26 Miguel de Icaza <miguel@ximian.com>
27670 * typemanager.cs (InitCoreTypes): Initialize the various core
27671 types after we have populated the type manager with the user
27672 defined types (this distinction will be important later while
27673 compiling corlib.dll)
27675 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
27676 on Expression Classification. Now all expressions have a method
27677 `Resolve' and a method `Emit'.
27679 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
27680 generation from working. Also add some temporary debugging
27683 2001-08-24 Miguel de Icaza <miguel@ximian.com>
27685 * codegen.cs: Lots of code generation pieces. This is only the
27686 beginning, will continue tomorrow with more touches of polish. We
27687 handle the fundamentals of if, while, do, for, return. Others are
27688 trickier and I need to start working on invocations soon.
27690 * gen-treedump.cs: Bug fix, use s.Increment here instead of
27693 * codegen.cs (EmitContext): New struct, used during code
27694 emission to keep a context. Most of the code generation will be
27697 * cs-parser.jay: Add embedded blocks to the list of statements of
27698 this block. So code generation proceeds in a top down fashion.
27700 2001-08-23 Miguel de Icaza <miguel@ximian.com>
27702 * statement.cs: Add support for multiple child blocks.
27704 2001-08-22 Miguel de Icaza <miguel@ximian.com>
27706 * codegen.cs (EmitCode): New function, will emit the code for a
27707 Block of code given a TypeContainer and its ILGenerator.
27709 * statement.cs (Block): Standard public readonly optimization.
27710 (Block::Block constructors): Link children.
27711 (Block::Child): Child Linker.
27712 (Block::EmitVariables): Emits IL variable declarations.
27714 * class.cs: Drop support for MethodGroups here, delay until
27716 (Method::): Applied the same simplification that I did before, and
27717 move from Properties to public readonly fields.
27718 (Method::ParameterTypes): Returns the parameter types for the
27719 function, and implements a cache that will be useful later when I
27720 do error checking and the semantic analysis on the methods is
27722 (Constructor::GetCallingConvention): Renamed from CallingConvetion
27723 and made a method, optional argument tells whether this is a class
27724 or a structure to apply the `has-this' bit.
27725 (Method::GetCallingConvention): Implement, returns the calling
27727 (Method::Define): Defines the type, a second pass is performed
27728 later to populate the methods.
27730 (Constructor::ParameterTypes): implement a cache similar to the
27731 one on Method::ParameterTypes, useful later when we do semantic
27734 (TypeContainer::EmitMethod): New method. Emits methods.
27736 * expression.cs: Removed MethodGroup class from here.
27738 * parameter.cs (Parameters::GetCallingConvention): new method.
27740 2001-08-21 Miguel de Icaza <miguel@ximian.com>
27742 * class.cs (TypeContainer::Populate): Drop RootContext from the
27745 (Constructor::CallingConvention): Returns the calling convention.
27746 (Constructor::ParameterTypes): Returns the constructor parameter
27749 (TypeContainer::AddConstructor): Keep track of default constructor
27750 and the default static constructor.
27752 (Constructor::) Another class that starts using `public readonly'
27753 instead of properties.
27755 (Constructor::IsDefault): Whether this is a default constructor.
27757 (Field::) use readonly public fields instead of properties also.
27759 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
27760 track of static constructors; If none is used, turn on
27761 BeforeFieldInit in the TypeAttributes.
27763 * cs-parser.jay (opt_argument_list): now the return can be null
27764 for the cases where there are no arguments.
27766 (constructor_declarator): If there is no implicit `base' or
27767 `this', then invoke the default parent constructor.
27769 * modifiers.cs (MethodAttr): New static function maps a set of
27770 modifiers flags into a MethodAttributes enum
27771 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
27772 MethodAttr, TypeAttr to represent the various mappings where the
27773 modifiers are used.
27774 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
27776 2001-08-19 Miguel de Icaza <miguel@ximian.com>
27778 * parameter.cs (GetParameterInfo): Fix bug where there would be no
27781 * interface.cs (PopulateIndexer): Implemented the code generator
27782 for interface indexers.
27784 2001-08-17 Miguel de Icaza <miguel@ximian.com>
27786 * interface.cs (InterfaceMemberBase): Now we track the new status
27789 (PopulateProperty): Implement property population. Woohoo! Got
27790 Methods and Properties going today.
27792 Removed all the properties for interfaces, and replaced them with
27793 `public readonly' fields.
27795 2001-08-16 Miguel de Icaza <miguel@ximian.com>
27797 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
27798 initialize their hashtables/arraylists only when they are needed
27799 instead of doing this always.
27801 * parameter.cs: Handle refs and out parameters.
27803 * cs-parser.jay: Use an ArrayList to construct the arguments
27804 instead of the ParameterCollection, and then cast that to a
27807 * parameter.cs: Drop the use of ParameterCollection and use
27808 instead arrays of Parameters.
27810 (GetParameterInfo): Use the Type, not the Name when resolving
27813 2001-08-13 Miguel de Icaza <miguel@ximian.com>
27815 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
27816 and instead use public readonly fields.
27818 * class.cs: Put back walking code for type containers.
27820 2001-08-11 Miguel de Icaza <miguel@ximian.com>
27822 * class.cs (MakeConstant): Code to define constants.
27824 * rootcontext.cs (LookupType): New function. Used to locate types
27827 2001-08-08 Miguel de Icaza <miguel@ximian.com>
27829 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
27830 this System.Reflection code is. Kudos to Microsoft
27832 * typemanager.cs: Implement a type cache and avoid loading all
27833 types at boot time. Wrap in LookupType the internals. This made
27834 the compiler so much faster. Wow. I rule!
27836 * driver.cs: Make sure we always load mscorlib first (for
27837 debugging purposes, nothing really important).
27839 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
27840 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
27842 * rootcontext.cs: Lookup types on their namespace; Lookup types
27843 on namespaces that have been imported using the `using' keyword.
27845 * class.cs (TypeContainer::TypeAttr): Virtualize.
27846 (Class::TypeAttr): Return attributes suitable for this bad boy.
27847 (Struct::TypeAttr): ditto.
27848 Handle nested classes.
27849 (TypeContainer::) Remove all the type visiting code, it is now
27850 replaced with the rootcontext.cs code
27852 * rootcontext.cs (GetClassBases): Added support for structs.
27854 2001-08-06 Miguel de Icaza <miguel@ximian.com>
27856 * interface.cs, statement.cs, class.cs, parameter.cs,
27857 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
27858 Drop use of TypeRefs, and use strings instead.
27860 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27864 * class.cs (Struct::Struct): set the SEALED flags after
27865 checking the modifiers.
27866 (TypeContainer::TypeAttr): new property, returns the
27867 TypeAttributes for a class.
27869 * cs-parser.jay (type_list): Oops, list production was creating a
27870 new list of base types.
27872 * rootcontext.cs (StdLib): New property.
27873 (GetInterfaceTypeByName): returns an interface by type name, and
27874 encapsulates error handling here.
27875 (GetInterfaces): simplified.
27876 (ResolveTree): Encapsulated all the tree resolution here.
27877 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27880 * driver.cs: Add support for --nostdlib, to avoid loading the
27881 default assemblies.
27882 (Main): Do not put tree resolution here.
27884 * rootcontext.cs: Beginning of the class resolution.
27886 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27888 * rootcontext.cs: Provide better error reporting.
27890 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27892 * rootcontext.cs (CreateInterface): Handle the case where there
27893 are no parent interfaces.
27895 (CloseTypes): Routine to flush types at the end.
27896 (CreateInterface): Track types.
27897 (GetInterfaces): Returns an array of Types from the list of
27898 defined interfaces.
27900 * typemanager.c (AddUserType): Mechanism to track user types (puts
27901 the type on the global type hash, and allows us to close it at the
27904 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27906 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27907 RecordInterface instead.
27909 * cs-parser.jay: Updated to reflect changes above.
27911 * decl.cs (Definition): Keep track of the TypeBuilder type that
27912 represents this type here. Not sure we will use it in the long
27913 run, but wont hurt for now.
27915 * driver.cs: Smaller changes to accomodate the new code.
27917 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27920 * rootcontext.cs (CreateInterface): New method, used to create
27921 the System.TypeBuilder type for interfaces.
27922 (ResolveInterfaces): new entry point to resolve the interface
27924 (CodeGen): Property, used to keep track of the code generator.
27926 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27928 * cs-parser.jay: Add a second production for delegate_declaration
27931 (enum_body): Put an opt_comma here instead of putting it on
27932 enum_body or enum_member_declarations so we can handle trailing
27933 commas on enumeration members. Gets rid of a shift/reduce.
27935 (type_list): Need a COMMA in the middle.
27937 (indexer_declaration): Tell tokenizer to recognize get/set
27939 * Remove old targets.
27941 * Re-add the parser target.
27943 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27945 * cs-parser.jay: Add precendence rules for a number of operators
27946 ot reduce the number of shift/reduce conflicts in the grammar.
27948 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27950 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27953 Get rid of old crufty code.
27955 * rootcontext.cs: Use this to keep track of the parsed
27956 representation and the defined types available to the program.
27958 * gen-treedump.cs: adjust for new convention.
27960 * type.cs: Split out the type manager, and the assembly builder
27963 * typemanager.cs: the type manager will live here now.
27965 * cil-codegen.cs: And the code generator here.
27967 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27969 * makefile: Fixed up for easy making.
27971 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27973 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27976 (unary_expression): Expand pre_increment_expression and
27977 post_decrement_expression to reduce a shift/reduce.
27979 2001-07-11 Simon Cozens
27981 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27983 Improve allow_keyword_as_indent name.
27985 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27987 * Adjustments for Beta2.
27989 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27991 * decl.cs: Added `Define' abstract method.
27992 (InTransit): new property, used to catch recursive definitions.
27994 * interface.cs: Implement `Define'.
27996 * modifiers.cs: Map Modifiers.constants to
27997 System.Reflection.TypeAttribute flags.
27999 * class.cs: Keep track of types and user-defined types.
28000 (BuilderInit): New method for creating an assembly
28001 (ResolveType): New function to launch the resolution process, only
28002 used by interfaces for now.
28004 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
28005 that are inserted into the name space.
28007 2001-06-08 Miguel de Icaza <miguel@ximian.com>
28009 * ARGH. I have screwed up my tree so many times due to the use of
28010 rsync rather than using CVS. Going to fix this at once.
28012 * driver.cs: Objetify driver. Load assemblies, use assemblies to
28015 2001-06-07 Miguel de Icaza <miguel@ximian.com>
28017 * Experiment successful: Use System.Type rather that our own
28020 2001-05-25 Miguel de Icaza <miguel@ximian.com>
28022 * cs-parser.jay: Removed nsAliases from here.
28024 Use new namespaces, handle `using XXX;'
28026 * namespace.cs: Reimplemented namespace handling, use a recursive
28027 definition of the class. Now we can keep track of using clauses
28028 and catch invalid using clauses.
28030 2001-05-24 Miguel de Icaza <miguel@ximian.com>
28032 * gen-treedump.cs: Adapted for all the renaming.
28034 * expression.cs (Expression): this class now has a Type property
28035 which returns an expression Type.
28037 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
28038 `Type', as this has a different meaning now in the base
28040 2001-05-22 Miguel de Icaza <miguel@ximian.com>
28042 * interface.cs, class.cs: Removed from all the sources the
28043 references to signature computation, as we can not do method
28044 signature computation during the parsing time, as we are not
28045 trying to solve at that point distinguishing:
28049 void a (NS.Blah x) {}
28052 Which depending on the context might be valid or not, as we do not
28053 know if Blah is the same thing as NS.Blah at that point.
28055 * Redid everything so the code uses TypeRefs now instead of
28056 Types. TypeRefs are just temporary type placeholders, that need
28057 to be resolved. They initially have a pointer to a string and the
28058 current scope in which they are used. This is used later by the
28059 compiler to resolve the reference to an actual Type.
28061 * DeclSpace is no longer a CIR.Type, and neither are
28062 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
28063 are all DeclSpaces, but no Types.
28065 * type.cs (TypeRefManager): This implements the TypeRef manager,
28066 which keeps track of all the types that need to be resolved after
28067 the parsing has finished.
28069 2001-05-13 Miguel de Icaza <miguel@ximian.com>
28071 * ARGH. We are going to have to store `foreach' as a class rather
28072 than resolving it, as we need to verify error 1579 after name
28073 resolution. *OR* we could keep a flag that says `This request to
28074 IEnumerator comes from a foreach statement' which we can then use
28075 to generate the error.
28077 2001-05-10 Miguel de Icaza <miguel@ximian.com>
28079 * class.cs (TypeContainer.AddMethod): we now add methods to the
28080 MethodGroup instead of the method hashtable.
28082 * expression.cs: Add MethodGroup abstraction, which gets us one
28083 step closer to the specification in the way we handle method
28086 * cs-parser.jay (primary_expression): qualified_identifier now
28087 tried to match up an identifier to a local variable reference or
28088 to a parameter reference.
28090 current_local_parameters is now a parser global variable that
28091 points to the current parameters for the block, used during name
28094 (property_declaration): Now creates an implicit `value' argument to
28097 2001-05-09 Miguel de Icaza <miguel@ximian.com>
28099 * parameter.cs: Do not use `param' arguments as part of the
28100 signature, per the spec.
28102 2001-05-08 Miguel de Icaza <miguel@ximian.com>
28104 * decl.cs: Base class for classes, structs and interfaces. This
28105 is the "Declaration Space"
28107 * cs-parser.jay: Use CheckDef for checking declaration errors
28108 instead of having one on each function.
28110 * class.cs: Factor out some code for handling error handling in
28111 accordance to the "Declarations" section in the "Basic Concepts"
28112 chapter in the ECMA C# spec.
28114 * interface.cs: Make all interface member classes derive from
28115 InterfaceMemberBase.
28117 2001-05-07 Miguel de Icaza <miguel@ximian.com>
28119 * Many things: all interfaces are parsed and generated in
28120 gen-treedump. Support for member variables, constructors,
28121 destructors, properties, constants is there.
28123 Beginning of the IL backend, but very little done, just there for
28126 2001-04-29 Miguel de Icaza <miguel@ximian.com>
28128 * cs-parser.jay: Fix labeled statement.
28130 * cs-tokenizer.cs (escape): Escape " and ' always.
28131 ref_line, ref_name: keep track of the line/filename as instructed
28132 by #line by the compiler.
28135 2001-04-27 Miguel de Icaza <miguel@ximian.com>
28137 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
28138 to match the values in System.CodeDOM.
28140 Divid renamed to Divide.
28142 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
28144 (Statements.set): remove.
28146 * System.CodeDOM/CodeCatchClause.cs: always have a valid
28149 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
28150 falseStatements always have valid values.
28152 * cs-parser.jay: Use System.CodeDOM now.