1 2009-10-14 Marek Safar <marek.safar@gmail.com>
3 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
4 Implement dynamic expressions assignment.
6 2009-10-14 Marek Safar <marek.safar@gmail.com>
8 * expression.cs: Build underlying expression when resolving unary
11 2009-10-14 Marek Safar <marek.safar@gmail.com>
13 * expression.cs: Emit enum array initializer using binary blob.
15 2009-10-08 Marek Safar <marek.safar@gmail.com>
17 * typemanager.cs, constant.cs: Optimize decimal constants which fit
20 2009-10-07 Marek Safar <marek.safar@gmail.com>
22 * typemanager.cs: Reset object_type.
24 * assign: Made SimpleAssign public.
26 2009-10-06 Marek Safar <marek.safar@gmail.com>
28 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
29 invocation assembly to IsThisOrFriendAssembly.
31 2009-10-05 Marek Safar <marek.safar@gmail.com>
33 * expression.cs: Equality comparison of generic parameter with
36 2009-10-05 Marek Safar <marek.safar@gmail.com>
39 * generic.cs: Import predefined constraints correctly.
41 2009-10-02 Marek Safar <marek.safar@gmail.com>
43 * ecore.cs: Don't crash on overloads with optional paremeters where
44 arguments count overflows.
46 * parameter.cs: Import optional parameter constants using optional
49 2009-10-01 Marek Safar <marek.safar@gmail.com>
51 * Makefile: Default is gmcs compiler.
53 2009-10-01 Marek Safar <marek.safar@gmail.com>
55 * cs-parser.jay: Fixed few NRE.
57 2009-10-01 Marek Safar <marek.safar@gmail.com>
59 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
61 2009-09-30 Marek Safar <marek.safar@gmail.com>
63 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
64 ShimExpression, ImplicitCast.
66 2009-09-30 Marek Safar <marek.safar@gmail.com>
69 * delegate.cs: Emit correct delegate instance variable when there
70 are static and non-static overloads.
72 2009-09-29 Marek Safar <marek.safar@gmail.com>
74 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
75 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
77 2009-09-28 Marek Safar <marek.safar@gmail.com>
80 * ecore.cs: Resolve extension methods hidden by properties.
82 2009-09-25 Marek Safar <marek.safar@gmail.com>
84 * expression.cs, ecore.cs: More dynamic binary expressions.
86 2009-09-22 Marek Safar <marek.safar@gmail.com>
88 * nullable.cs, expression.cs: Fixed null lifted conversion for
89 bitwise enum operations.
91 2009-09-22 Marek Safar <marek.safar@gmail.com>
93 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
94 values in checked context.
96 2009-09-22 Marek Safar <marek.safar@gmail.com>
98 * expression.cs, ecore.cs: Fixed array index constant conversion.
100 2009-09-20 Miguel de Icaza <miguel@novell.com>
102 * expression.cs: Do not crash when MemberLookup returns something
103 that is not a MemberExpr here. Report error 582 instead.
107 2009-09-18 Marek Safar <marek.safar@gmail.com>
109 * decl.cs, class.cs: Check protected property accessors.
111 2009-09-18 Marek Safar <marek.safar@gmail.com>
113 * dynamic.cs, assign.cs: Dynamic compound assignment.
115 2009-09-17 Marek Safar <marek.safar@gmail.com>
117 * expression.cs: Fixed compound assignment explicit conversion.
119 2009-09-17 Marek Safar <marek.safar@gmail.com>
121 * expression.cs, ecore.cs: Cannot infer variables from method group.
123 2009-09-16 Marek Safar <marek.safar@gmail.com>
125 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
126 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
127 codegen.cs: Dynamic binary operations scaffolding.
129 2009-09-15 Marek Safar <marek.safar@gmail.com>
131 * expression.cs: Fixes nullable promotion for enum type variables.
133 2009-09-11 Marek Safar <marek.safar@gmail.com>
135 * driver.cs, dynamic.cs: Reset more static variables.
137 2009-09-11 Marek Safar <marek.safar@gmail.com>
139 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
140 driver.cs: Introduced Expression::MakeExpression.
142 2009-09-11 Marek Safar <marek.safar@gmail.com>
144 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
146 2009-09-09 Marek Safar <marek.safar@gmail.com>
148 * eval.cs, report.cs: Use Console.Out for all eval error or warning
151 2009-09-09 Marek Safar <marek.safar@gmail.com>
153 A fix for bug #518707
154 * expression.cs (Is): Optimize only generic parameter type
155 expression probing value type generic parameter.
157 2009-09-09 Marek Safar <marek.safar@gmail.com>
159 A fix for bug #532571
160 * ecore.cs: Check for simple name type arguments used with
163 2009-09-08 Marek Safar <marek.safar@gmail.com>
165 A fix for bug #497421
166 * generic.cs (CheckConstraint): Don't use buildin types to check for
167 parameterless constructor.
169 2009-09-08 Marek Safar <marek.safar@gmail.com>
171 A fix for bug #537402
172 * generic.cs (CheckConstraint): Correctly inflate generic type
173 arguments when checking generic method.
175 2009-09-08 Marek Safar <marek.safar@gmail.com>
177 A fix for bug #536463
178 * decl.cs (AddToContainer): Don't report collision between explicit
179 and parameterless non-explicit members.
181 2009-09-08 Marek Safar <marek.safar@gmail.com>
183 * eval.cs: Reset more static stuff.
185 2009-09-07 Marek Safar <marek.safar@gmail.com>
187 A fix for bug #324625
188 * expression.cs, ecore.cs: Create nested generic type expression
189 using declaring and not current type.
191 2009-09-07 Marek Safar <marek.safar@gmail.com>
193 * *.cs: Changed Report class to accept various output printers and
194 be an instance class. An expression resolver can now use different
195 message reporter for each call and Report.Error can safely throw
196 an exception. Part of ongoing work to turn mcs into proper library.
198 2009-09-04 Marek Safar <marek.safar@gmail.com>
200 * statement.cs, ecore.cs: Removed error reporting from emit code.
202 2009-09-04 Marek Safar <marek.safar@gmail.com>
204 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
206 2009-09-03 Marek Safar <marek.safar@gmail.com>
208 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
209 parser checks out of constructors.
211 2009-09-02 Marek Safar <marek.safar@gmail.com>
213 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
215 2009-09-02 Marek Safar <marek.safar@gmail.com>
217 A fix for bug #535448
218 * anonymous.cs, class.cs: Copy return label between all contexts.
220 2009-09-02 Marek Safar <marek.safar@gmail.com>
222 A fix for bug #535395
223 * namespace.cs: Resolve context can be null.
225 2009-08-25 Marek Safar <marek.safar@gmail.com>
227 A fix for bug #533912
228 * generic.cs: Use correct context for constraints resolving.
230 2009-08-25 Marek Safar <marek.safar@gmail.com>
232 A fix for bug #532630
233 * driver.cs: Trim conditional symbols.
235 2009-08-25 Marek Safar <marek.safar@gmail.com>
237 * context.cs: New file.
239 * *.exe.sources, *.csproj: Updated.
241 2009-08-25 Marek Safar <marek.safar@gmail.com>
243 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
244 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
245 IMembercontext, some small cleanups.
247 2009-08-24 Marek Safar <marek.safar@gmail.com>
249 * *.cs: Split ResolveContext and EmitContext.
251 2009-08-24 Marek Safar <marek.safar@gmail.com>
253 * *.cs: Only ResolveContext implements IMemberContext.
255 2009-08-21 Marek Safar <marek.safar@gmail.com>
257 * *.cs: Renamed IResolveContext to IMemberContext.
259 2009-08-21 Marek Safar <marek.safar@gmail.com>
261 * *.cs: Detached ResolveContext from EmitContext.
263 2009-08-21 Marek Safar <marek.safar@gmail.com>
265 * codegen.cs: Moved flow-analysis to BlockContext.
267 2009-08-21 Marek Safar <marek.safar@gmail.com>
269 * *.cs: Detached BlockContext from EmitContext.
271 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
273 * statement.cs: avoid nullref when the return value of GetEnumerator()
274 does not contain any MoveNext() method.
276 2009-08-19 Marek Safar <marek.safar@gmail.com>
278 * *.cs: Removed IResolveContext::GenericDeclContainer.
280 2009-08-19 Marek Safar <marek.safar@gmail.com>
282 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
284 2009-08-19 Marek Safar <marek.safar@gmail.com>
286 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
287 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
289 2009-08-18 Marek Safar <marek.safar@gmail.com>
291 * *.cs: Removed boolean fields from EmitContext.
293 2009-08-18 Marek Safar <marek.safar@gmail.com>
295 * *.cs: Add IResolveContext::IsStatic.
297 2009-08-18 Marek Safar <marek.safar@gmail.com>
299 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
301 2009-08-17 Marek Safar <marek.safar@gmail.com>
303 * *.cs: Removed DeclContainer from EmitContext.
305 2009-08-17 Marek Safar <marek.safar@gmail.com>
307 * *.cs: Add IResolveContext::CurrentTypeParameters.
309 2009-08-14 Marek Safar <marek.safar@gmail.com>
311 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
313 2009-08-14 Marek Safar <marek.safar@gmail.com>
315 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
316 codegen.cs: Add IResolveContext::LookupExtensionMethod.
318 2009-08-13 Marek Safar <marek.safar@gmail.com>
320 * decl.cs: Look in PartialContainer for parent type parameters.
322 2009-08-13 Marek Safar <marek.safar@gmail.com>
324 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
325 codegen.cs: Add IResolveContext::LookupTypeParameter.
327 2009-08-13 Marek Safar <marek.safar@gmail.com>
329 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
330 Moved resolved logic from Emit to Resolve.
332 2009-08-13 Marek Safar <marek.safar@gmail.com>
334 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
335 codegen.cs: Reworked atttributes handling of ResolveContext.
337 2009-08-12 Marek Safar <marek.safar@gmail.com>
339 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
340 LookupNamespaceOrType to ResolveContext.
342 2009-08-12 Marek Safar <marek.safar@gmail.com>
344 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
345 class.cs: Removed unused parameters and methods.
347 2009-08-11 Marek Safar <marek.safar@gmail.com>
349 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
350 codegen.cs: Finding the best common type of a set of expressions for
353 2009-08-07 Marek Safar <marek.safar@gmail.com>
355 * dynamic.cs, expression.cs: More dynamic conversions.
357 2009-08-06 Miguel de Icaza <miguel@novell.com>
359 * generic.cs: This loop was incorrect, it was increment ii, but
360 checking for `i'. This was a change introduced to fix #327497,
363 * class.cs: Catch another case for cs0533 error, fixes #324782.
365 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
367 * typemanager.cs (GetGenericArguments): SRE returns null for
368 generic methods on type builder instances if they are not generic
369 themselves. For example, for Foo<int>::Bar() it returns null, but
370 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
372 2009-08-05 Marek Safar <marek.safar@gmail.com>
374 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
375 delegate.cs: Work on dynamic binding.
377 2009-08-04 Marek Safar <marek.safar@gmail.com>
379 A second fix for bug #525342
380 * class.cs: Attach partial method attributes to method
383 2009-08-03 Marek Safar <marek.safar@gmail.com>
385 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
388 * rootcontext.cs: Default to langversion v4.
390 2009-08-03 Marek Safar <marek.safar@gmail.com>
392 * pending.cs: Check return type before member info is set.
394 2009-08-03 Marek Safar <marek.safar@gmail.com>
396 * anonymous.cs: Fully initialize generic hoisted field expression.
398 2009-08-02 Miguel de Icaza <miguel@novell.com>
400 * cs-parser.jay: Flag variables declared on the interactive shell
401 as used to prevent the 168 warning about local variable not being
404 2009-07-31 Marek Safar <marek.safar@gmail.com>
406 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
407 attribute.cs: Emit dynamic export attribute.
409 2009-07-30 Marek Safar <marek.safar@gmail.com>
411 * expression.cs: More verifier work.
413 2009-07-29 Marek Safar <marek.safar@gmail.com>
415 * nullable.cs: Fixed SRE crash during corlib compilation.
417 2009-07-29 Marek Safar <marek.safar@gmail.com>
419 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
420 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
421 More TypeManager.TypeToCoreType needed.
423 2009-07-29 Marek Safar <marek.safar@gmail.com>
425 * anonymous.cs: Update after recent SRE fixes.
427 2009-07-28 Marek Safar <marek.safar@gmail.com>
429 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
430 version of GetFieldHandle for fields of generic types.
432 2009-07-27 Marek Safar <marek.safar@gmail.com>
434 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
435 ecore.cs: Add TypeManager.IsDynamicType,
436 PredefinedAttributes.Dynamic.
438 2009-07-27 Marek Safar <marek.safar@gmail.com>
440 A fix for bug #415375
441 * expression.cs: Fixed object and reference type parameter
444 2009-07-27 Marek Safar <marek.safar@gmail.com>
446 A fix for bug #525342
447 * class.cs: Attach partial method attributes to method
450 2009-07-24 Marek Safar <marek.safar@gmail.com>
452 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
455 2009-07-24 Marek Safar <marek.safar@gmail.com>
457 * anonymous.cs (MutateField): Add imported types handling.
459 2009-07-23 Marek Safar <marek.safar@gmail.com>
461 * expression.cs, delegate.cs: Moved arguments resolve into their
462 counterparts expressions. Removed argument resolve from
463 CollectionElementInitializer.
465 2009-07-23 Marek Safar <marek.safar@gmail.com>
467 A fix for bug #523683
468 * convert.cs, delegate.cs: Use common overload mechanism for method
469 group conversion check.
471 2009-07-22 Marek Safar <marek.safar@gmail.com>
473 A fix for bug #523899
474 * generics.cs: Exact type inference with other bound types.
476 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
478 Don't complain when the same type is implemented by the output
479 assembly as well as multiple referenced assemblies
480 * namespace.cs (RootNamespace.LookupTypeReflection): Add
481 'must_be_unique' flag.
482 (GlobalRootNamespace): Update to changes.
483 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
484 already have a type in hand.
486 2009-07-22 Marek Safar <marek.safar@gmail.com>
488 * expression.cs: More verifier instrumentation.
490 * statement.cs: Do proper throw expression conversion.
492 2009-07-22 Marek Safar <marek.safar@gmail.com>
494 A fix for bug #522789
495 * expression.cs: Mutate invocation return type.
497 2009-07-16 Marek Safar <marek.safar@gmail.com>
499 * anonymous.cs: Split assignable and readonly generated variable
502 2009-07-16 Marek Safar <marek.safar@gmail.com>
504 A fix for bug #521671
505 * statement.cs: Fixed crash when checking missing type.
507 2009-07-16 Marek Safar <marek.safar@gmail.com>
509 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
510 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
511 class.cs, driver.cs: Work on dynamic binding.
513 * dynamic.cs: New file.
515 * *.sources, *.proj: Updated.
517 2009-07-15 Marek Safar <marek.safar@gmail.com>
519 * expression.cs (Conditional): Avoid double Resolve.
521 2009-07-13 Marcus Griep <marcus@griep.us>
523 * ecore.cs: Fix obscure bug with resolving members of interfaces
524 that hide parent interface members. Fixes bug #444388 and corrects
527 2009-07-13 Marek Safar <marek.safar@gmail.com>
529 * expression.cs (LocalVariableReference): Bounce resolve.
531 2009-07-10 Marek Safar <marek.safar@gmail.com>
533 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
534 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
537 * support.cs: New dynamic type wrapper.
539 2009-07-08 Marek Safar <marek.safar@gmail.com>
541 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
542 typed local variable.
544 2009-07-06 Marek Safar <marek.safar@gmail.com>
546 A fix for bug #519005
547 * anonymous.cs: Use null_type as no return type placeholder.
549 2009-07-02 Marek Safar <marek.safar@gmail.com>
551 * generic.cs: Handle type inference of identical type parameters
552 with different bounds.
554 2009-07-01 Marek Safar <marek.safar@gmail.com>
556 * expression.cs, class.cs: Events variance.
558 * cs-parser.jay: Interface events error messages.
560 2009-07-01 Marek Safar <marek.safar@gmail.com>
562 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
564 2009-06-29 Marek Safar <marek.safar@gmail.com>
566 * parameter.cs, convert.cs, expression.cs, class.cs: Default
567 parameter expression can be value-type New.
569 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
571 2009-06-26 Marek Safar <marek.safar@gmail.com>
573 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
574 Implemented C# 4.0 named arguments.
576 2009-06-24 Marek Safar <marek.safar@gmail.com>
578 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
579 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
580 parameter modifier. Also fixes bug #515497.
582 2009-06-24 Marek Safar <marek.safar@gmail.com>
584 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
585 arguments expression to be implemented.
587 *.sources: Add argument.cs
589 2009-06-23 Marek Safar <marek.safar@gmail.com>
591 * parameter.cs: Moved GetParameterIndexByName to base class.
593 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
594 unused AType. Use argument's version of GetExpressionTree.
596 2009-06-22 Marek Safar <marek.safar@gmail.com>
598 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
601 2009-06-17 Marek Safar <marek.safar@gmail.com>
603 A fix for bug #514096
604 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
606 2009-06-17 Marek Safar <marek.safar@gmail.com>
608 * expression.cs: The first multi-dimensional array nested array
609 initializers was not checked.
611 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
613 2009-06-17 Marek Safar <marek.safar@gmail.com>
615 A fix for bug #513400
616 * nullable.cs (EmitEquality): Operands emit could be simplified for
617 built-in types when we now emit user operators differently.
619 2009-06-16 Marek Safar <marek.safar@gmail.com>
621 * ecore.cs: Report inaccessible delegate methods correctly.
623 2009-06-16 Marek Safar <marek.safar@gmail.com>
625 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
626 cs-parser.jay: Implemented C# 4.0 optional parameters.
628 2009-06-16 Marek Safar <marek.safar@gmail.com>
630 * driver.cs: Removed broken DefineManifestResource.
632 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
634 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
635 Use $(BOOTSTRAP_PROFILE) instead.
637 2009-06-12 Jb Evain <jbevain@novell.com>
639 * rootcontext.cs: add a Platform field.
640 * driver.cs: handle /platform.
641 * codegen.cs: pass the proper flags according to
642 the platform when saving the assembly.
644 2009-06-11 Marek Safar <marek.safar@gmail.com>
646 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
647 Add optional parameters grammar.
649 2009-06-10 Marek Safar <marek.safar@gmail.com>
651 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
652 driver.cs: Split lang version and metadata version.
654 2009-06-10 Marek Safar <marek.safar@gmail.com>
656 * decl.cs: Better overload ctor collision error message.
658 2009-06-05 Jb Evain <jbevain@novell.com>
660 * driver.cs (EmbededResource): avoid using an internal method
661 in gmcs to embed manifest resources.
663 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
665 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
666 the compiler from older mono versions (like moon's bots)
668 2009-06-04 Marek Safar <marek.safar@gmail.com>
670 * namespace.cs (LookupTypeReflection): Ignore collisions between
673 2009-06-04 Marek Safar <marek.safar@gmail.com>
675 * codegen.cs: Enabled generic type forwarders.
677 2009-06-04 Marek Safar <marek.safar@gmail.com>
679 * dmcs.*: Add another version of SRE compiler.
681 2009-06-03 Marek Safar <marek.safar@gmail.com>
683 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
684 generic-mcs.cs: Fixed variant type conversions.
686 2009-06-02 Marek Safar <marek.safar@gmail.com>
688 A fix for bug #507863
689 * codegen.cs: Fixes a crash on invalid string value attribute.
691 2009-06-01 Marek Safar <marek.safar@gmail.com>
693 A fix for bug #508334
694 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
695 cs-parser.jay: Fully import __arglist modifier.
697 2009-05-29 Marek Safar <marek.safar@gmail.com>
699 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
700 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
701 actually work with closed generic types.
703 2009-05-27 Alan McGovern <amcgovern@novell.com>
705 * class.cs, decl.cs, delegate.cs, parameter.cs:
706 Fix the build by replacing the use of 'var' with the actual type.
708 2009-05-27 Marek Safar <marek.safar@gmail.com>
710 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
711 cs-parser.jay, generic-mcs.cs: Report wrong variant types
714 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
717 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
718 Marek Safar <marek.safar@gmail.com>
720 A fix for bug #377509
721 * parameter.cs: Use predefined and not empty name for implicit
724 2009-05-21 Marek Safar <marek.safar@gmail.com>
726 * class.cs: Don't report wrong warnings for event fields.
728 2009-05-21 Marek Safar <marek.safar@gmail.com>
730 A fix for bug #504667
731 * class.cs: Check for static class using parent container instead of
734 2009-05-08 Marek Safar <marek.safar@gmail.com>
736 A fix for bug #496922
737 * expression.cs: Always use temporary variable when using object
740 2009-04-28 Marek Safar <marek.safar@gmail.com>
742 A fix for bug #495112
743 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
746 2009-04-27 Miguel de Icaza <miguel@novell.com>
748 * driver.cs: Add a flag to work as a replacement for CSC in VS.
750 2009-04-24 Miguel de Icaza <miguel@novell.com>
752 * complete.cs: No idea how gonzalo got a null in the list, but
755 2009-04-24 Miguel de Icaza <miguel@novell.com>
757 * complete.cs (CompletionElementInitializer): New completion class
758 to support completing inside a C# 3 element initializer, so this
759 allows completion for Silverlight situations where it is very
762 new TextBlock () { Fo<TAB>
764 (CompletionSimpleName): Expose the prefix that was
765 passed to the simple name.
767 * cs-parser.jay (object_or_collection_initializer): Add support
768 for element_initializers.
770 * expression.cs (CollectionOrObjectInitializers.DoResolve):
771 special case completion expressions as this method aggressively
772 collects data before it operates, and errors were being thrown
773 earlier than we were able to complete.
775 2009-04-23 Miguel de Icaza <miguel@novell.com>
777 * eval.cs: Make getcompletions silent and enable debugging output
778 if the -v option is passed.
780 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
781 Consider looking up the namespace that matches the prefix being
784 This is part of the support for allowing completions like:
785 `System.Co<TAB>' to complete to System.Console.
787 * complete.cs (CompletionSimpleName.AppendResults): Make this
790 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
792 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
793 COMPLETE_COMPLETION as internal.
795 2009-04-17 Miguel de Icaza <miguel@novell.com>
797 * complete.cs: Include namespace resolution in simple names as
798 well as global types and types in the using scope in the
801 * namespace.cs: Supporting infrastrcture to provide completions
802 based on the current using scope.
804 * eval.cs: Introduce an entry point that allows for initialization
805 to return a list of the files passed on the command line.
807 2009-04-14 Marek Safar <marek.safar@gmail.com>
809 A fix for bug #494243
810 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
812 2009-04-13 Marek Safar <marek.safar@gmail.com>
814 A fix for bug #493887
815 * statement.cs: Don't skip string multi-section with default or
816 null label when populating string hashtable.
818 2009-04-06 Marek Safar <marek.safar@gmail.com>
820 A fix for bug #492329
821 * expression.cs (New): Load variable when assigning type parameter
824 2009-04-06 Marek Safar <marek.safar@gmail.com>
826 A fix for bug #488960
827 * decl.cs: Compare MVAR types using non-null values.
829 2009-03-27 Marek Safar <marek.safar@gmail.com>
831 * typemanager.cs, expression.cs: Removed unused nullable checks.
833 2009-03-27 Marek Safar <marek.safar@gmail.com>
835 * *.cs: Removed some gmcs conditionals.
837 2009-03-26 Marek Safar <marek.safar@gmail.com>
839 * generic.cs, support.cs: Moved generics stuff out of support.cs
841 2009-03-24 Marek Safar <marek.safar@gmail.com>
843 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
846 2009-03-23 Marek Safar <marek.safar@gmail.com>
848 * attribute.cs: Consider all members for error reporting when
849 checking named arguments.
851 2009-03-23 Marek Safar <marek.safar@gmail.com>
853 A fix for bug #487625
854 * namespace.cs: Use a warning for all predefined type conflicts.
856 2009-03-23 Marek Safar <marek.safar@gmail.com>
858 A fix for bug #485706
859 * statement.cs: Explicitly type catch type argument to pass verifier
862 2009-03-22 Miguel de Icaza <miguel@novell.com>
864 Initial support to provide code completion facilities to consumers
865 of the evaluator API.
867 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
868 support the completion engine. When we reach the end of the
869 input stream instead of returning EOF, when this flag is true the
870 tokenizer instead produces:
872 One GENERATE_COMPLETION token: this token then must be
873 handled in the grammar at every point where the user
874 would likely request a completion.
876 As many COMPLETE_COMPLETION tokens as necessary. These
877 tokens are generated to assist the parser in unwinding and
878 producing a valid parse tree.
880 The parser rules do not have to be perfect, the parser needs to be
881 augmented with judicious use of GENERATE_COMPLETION tokens to
882 improve the areas where we can provide completion and the parser
883 needs to add support for COMPLETE_COMPLETION tokens in productions
886 It is common to not have enough support for COMPLETE_COMPLETION
887 under certain rules and that even if we generated the
888 GENERATE_COMPLETION token that the resulting tree will be invalid
889 due to the missing rules that support COMPLETE_COMPLETION.
891 The final EOF token is produced by having the parser notify the
892 tokenizer when it reaches the root production that the next token
895 * support.cs (CompletionResult): New Exception. This exception
896 is thrown to return the completion results when one of the special
897 completion expressions is reached.
899 This exception is thrown by the completing ExpressionStatements
900 classes that live in complete.cs
902 * complete.cs (CompletingExpression): a new base class for
903 completing expressions. This derives from the
904 ExpressionStatement class and not from Expression as it allows
905 completion to happen not only where expressions are expected in
906 the grammar, but also where statements are expected.
908 (CompletionSimpleName): A new class used to provide completions
909 for SimpleNames. This currently only resolves to local
910 variables from the evaluator context (GetVars call).
912 (CompletionMemberAccess): Implements support for completing member
915 * cs-parser.jay: Add support for completion in a few places.
917 * eval.cs (GetCompletions): New public API for the evaluator that
918 returns a list of possible completions given the input. The
919 return value is an array of completions
921 * anonymous.cs (Compatible): If the exception thrown from the
922 resolved expression is a CompletionResult exception let that one
923 through instead of printing a diagnostic error in the try/catch.
925 2009-03-22 Miguel de Icaza <miguel@novell.com>
929 * driver.cs (Main): Use Environment.Exit to quit quickly and
930 prevent the compiler from doing the usual wait for helper thread
933 This is to prevent a slowdown that was reported by Gonzalo on
936 2009-03-19 Marek Safar <marek.safar@gmail.com>
938 * ecore.cs: Load build-in types directly instead of accessing
941 2009-03-18 Marek Safar <marek.safar@gmail.com>
943 * ecore.cs: Always use unbox.any when available.
945 2009-03-18 Marek Safar <marek.safar@gmail.com>
947 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
949 2009-03-17 Marek Safar <marek.safar@gmail.com>
951 * generic.cs: Removed obsolete version of type inference.
953 2009-03-16 Marek Safar <marek.safar@gmail.com>
955 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
956 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
957 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
958 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
960 2009-03-11 Marek Safar <marek.safar@gmail.com>
962 A fix for bug #482996
963 * anonymous.cs: Make sure we are not infering return type when
964 checking type compatibility.
966 2009-03-11 Marek Safar <marek.safar@gmail.com>
968 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
969 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
970 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
971 attributes in their own structure. Needed when accessing their
972 properties before they are resolved.
974 2009-03-09 Marek Safar <marek.safar@gmail.com>
976 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
977 hashtable (~10x faster).
979 * driver.cs: Removed wrong Reset.
981 2009-03-08 Marek Safar <marek.safar@gmail.com>
983 * class.cs: Use correct common base type for unmanaged delayed
986 * rootcontext.cs: Wrap unhandled exception.
988 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
990 Make SeekableStreamReader self-tuning and arbitrarily seekable
991 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
993 (SeekableStreamReader.Position.set): Use it. Simplify logic
994 which, as a side-effect, makes it arbitrarily-seekable. Tune the
995 buffer size when the stream needs to be re-read from the beginning.
997 2009-03-05 Marek Safar <marek.safar@gmail.com>
999 A fix for bug #480100
1000 * parameter.cs: A parameter is not hoisted when used directly as ET.
1002 2009-03-04 Marek Safar <marek.safar@gmail.com>
1004 * statement.cs: Fixed an issue when using variable is of interface
1007 2009-03-03 Marek Safar <marek.safar@gmail.com>
1009 A fix for bug #480319
1010 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1012 2009-03-03 Marek Safar <marek.safar@gmail.com>
1014 A fix for bug #480867
1015 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1016 expression to have no valid type.
1018 2009-03-03 Marek Safar <marek.safar@gmail.com>
1020 A fix for bug #481258
1021 * class.cs: Set extension method flag in partial container.
1023 2009-03-03 Marek Safar <marek.safar@gmail.com>
1025 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1027 * attribute.cs: Add sanity check.
1029 2009-02-27 Marek Safar <marek.safar@gmail.com>
1031 * class.cs: Add external constructor error.
1033 2009-02-26 Marek Safar <marek.safar@gmail.com>
1035 A fix for bug #475354
1036 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1037 correctly user defined nullable equality operators.
1039 2009-02-25 Marek Safar <marek.safar@gmail.com>
1041 A fix for bug #479532
1042 * expression.cs: Implement NewInitialize::AddressOf.
1044 2009-02-25 Marek Safar <marek.safar@gmail.com>
1046 A fix for bug #413633
1047 * expression.cs: Iterate all base class-constraint types.
1049 2009-02-24 Marek Safar <marek.safar@gmail.com>
1051 A fix for bug #479209
1052 * literal.cs: Mutate null underlying type.
1054 2009-02-24 Marek Safar <marek.safar@gmail.com>
1056 A fix for bug #476295
1057 * convert.cs: Avoid wrapping implicitly convertible reference type.
1059 2009-02-23 Marek Safar <marek.safar@gmail.com>
1061 * iterators.cs: Create MemberName correctly.
1063 2009-02-23 Marek Safar <marek.safar@gmail.com>
1065 A fix for bug #478655
1066 * literal.cs: Check also underlying null type conversion.
1068 2009-02-21 Marek Safar <marek.safar@gmail.com>
1070 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1072 2009-02-20 Marek Safar <marek.safar@gmail.com>
1074 A fix for bug #477447
1075 * statement.cs: Add reference to correct parent storey when this
1076 is accessible from deep children storey (more than 1 level).
1078 2009-02-19 Marek Safar <marek.safar@gmail.com>
1080 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1081 * class.cs: Define base type members before setting up member cache.
1083 2009-02-18 Marek Safar <marek.safar@gmail.com>
1085 A fix for bug #477378
1086 * nullable.cs, expression.cs, statement.cs: More precise null type
1089 2009-02-18 Marek Safar <marek.safar@gmail.com>
1091 A fix for bug #472805
1092 * typemanager.cs, namespace.cs: Import only visible extension method
1095 2009-02-18 Marek Safar <marek.safar@gmail.com>
1097 A fix for bug #476895
1098 * attribute.cs: Use correct resolve context for attribute type.
1100 2009-02-18 Marek Safar <marek.safar@gmail.com>
1102 A fix for bug #476266
1103 * anonymous.cs: Mutate multi-dimensional arrays.
1105 2009-02-18 Marek Safar <marek.safar@gmail.com>
1107 A fix for bug #476400
1108 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1110 2009-02-18 Marek Safar <marek.safar@gmail.com>
1112 A fix for bug #476811
1113 * generics.cs: Fixed null-literal check.
1115 2009-02-17 Marek Safar <marek.safar@gmail.com>
1117 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1118 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1119 messing with static variables.
1121 2009-02-16 Marek Safar <marek.safar@gmail.com>
1123 A fix for bug #475965
1124 * generics.cs: Check generic parameter type after extracting from
1127 2009-02-16 Marek Safar <marek.safar@gmail.com>
1129 A fix for bug #475823
1130 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1133 2009-02-14 Marek Safar <marek.safar@gmail.com>
1135 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1136 Simplified event field definition using backing field and not
1137 field builder directly.
1139 * expression.cs (EmitLdArg): Optimize fast paths.
1141 2009-02-13 Marek Safar <marek.safar@gmail.com>
1143 A fix for bug #475327
1144 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1146 2009-02-13 Marek Safar <marek.safar@gmail.com>
1148 A fix for bug #475342
1149 * cs-parser.jay: Using 'super' instead of 'base' to call base
1150 constructor crashes compiler.
1152 2009-02-13 Marek Safar <marek.safar@gmail.com>
1154 A fix for bug #475354
1155 * expression.cs (Constantify): Add nullable types.
1157 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1159 2009-02-12 Marek Safar <marek.safar@gmail.com>
1161 A fix for bug #475246
1162 * expression.cs: More broken flowanalysis hacking needed.
1164 2009-02-12 Marek Safar <marek.safar@gmail.com>
1166 * attribute.cs: Compare only ref/out array modifiers.
1168 2009-02-11 Marek Safar <marek.safar@gmail.com>
1170 * statement.cs: Use member cache when looking for foreach members.
1172 2009-02-11 Marek Safar <marek.safar@gmail.com>
1174 * expression.cs: Don't expose internal initializer types.
1176 * statement.cs: Check also explicit conversions for goto case.
1178 2009-02-11 Marek Safar <marek.safar@gmail.com>
1180 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1182 2009-02-10 Marek Safar <marek.safar@gmail.com>
1184 * *.cs: Replace null-type with NullLiteral where appropriate.
1186 2009-02-09 Marek Safar <marek.safar@gmail.com>
1188 * expression.cs: Initializer of reference argument use temporary
1189 variable to be verifiable.
1191 * parameter.cs: Share EmitLdArg.
1193 2009-02-09 Marek Safar <marek.safar@gmail.com>
1195 A fix for bug #473559
1196 * class.cs: Fixed: Not reporting error about nested class with the
1199 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1201 Contributed under the MIT/X11 license.
1203 * generic.cs: Added VerifyVariantTypeParameters which performs new
1204 variance verification logic. The old logic, based on the spec, was
1205 wrong because the spec is full of LIES!
1207 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1209 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1212 * ecore.cs: Added calls to the new variance verification logic.
1215 * delegate.cs: Removed calls to the old variance verification logic.
1217 2009-02-06 Marek Safar <marek.safar@gmail.com>
1219 * delegate.cs: Use cached Invoke method directly.
1221 2009-02-06 Marek Safar <marek.safar@gmail.com>
1223 * expression.cs: Emit expression tree for hoisted variable access.
1225 2009-02-04 Marek Safar <marek.safar@gmail.com>
1227 * namespace.cs: Add better extension class check.
1229 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1231 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1233 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1235 This patch adds initial generic variance support to the compiler.
1236 It is contributed under the MIT/X11 license.
1238 * typemanager.cs: Modified ImplementsInterface to check variance.
1239 Added VerifyVariantTypeParameters which checks the specified type to see
1240 if it uses a variant type parameter as a type argument (which is not
1241 allowed). Added IsVariantOf which determins if the first type is a
1242 variant of the second. NOTE: This only supports reference types at
1243 the moment to conform with the current level of VM support. When the
1244 VM supports value types, this will follow step.
1246 * generic.cs: Added the Variance enum. Added a Variance property to
1247 TypeParameter and added variance support to definition phase. Added a
1248 Variance property to TypeParameterName. Also check to make sure that
1249 no variant types appear in generic method parameters.
1251 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1252 keywords if the langversion supports it.
1254 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1255 that variant types are only used in legal positions. Also added
1256 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1259 * decl.cs: Construct TypeParameter with the variance information.
1261 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1262 and ImplicitConversionStandard.
1264 * rootcontext.cs: Added new "Future" language version.
1266 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1267 type parameters are not used as type arguments in interface inheritance.
1268 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1269 parameters are not used as method return types. In MemberBase.
1270 ResolveMemberType, ensure that variant type parameters are not used
1271 as type arguments. Also call VerifyNoVariantTypeParameters on every
1272 set of parameters which are resolved.
1274 * delegate.cs: Modified Delegate.Define to ensure that variant
1275 parameters are not used as type arguments and that a contravariant
1276 parameter is not used as the return type. Also call
1277 VerifyNoVariantTypeParameters on the delegate parameters.
1279 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1280 to specify generic variance.
1282 * driver.cs: Added support for LanguageVersion.Future in the form of
1283 "-langversion:future".
1285 * generic-mcs.cs: Stubbed out new members in generic.cs.
1287 2009-02-03 Marek Safar <marek.safar@gmail.com>
1289 * class.cs, generic.cs: Emit type parameter constraints for nested
1292 2009-02-02 Marek Safar <marek.safar@gmail.com>
1294 A fix for bug #471213
1295 * class.cs: Avoid emitting backing field for abstract event fields.
1297 2009-02-01 Marek Safar <marek.safar@gmail.com>
1299 A fix for bug #359731
1300 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1303 2009-01-30 Marek Safar <marek.safar@gmail.com>
1305 A fix for bug #470767
1306 * statement.cs: Introduced BlockScopeExpression, needed when
1307 expression tree conversion has to emit scope variables.
1309 2009-01-29 Marek Safar <marek.safar@gmail.com>
1311 * class.cs: Remove duplicate CallingConvention.
1313 2009-01-29 Marek Safar <marek.safar@gmail.com>
1315 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1316 when I finally found the right naming convention.
1318 2009-01-29 Marek Safar <marek.safar@gmail.com>
1320 * cs-tokenizer.cs: Put back different open parens optimization.
1322 2009-01-28 Marek Safar <marek.safar@gmail.com>
1324 A fix for bug #470227
1325 * cs-tokenizer.cs: Remove too agressive parser optimization.
1327 2009-01-28 Marek Safar <marek.safar@gmail.com>
1329 A fix for bug #324319
1330 * class.cs: Remove too early base type resolve.
1332 2009-01-27 Marek Safar <marek.safar@gmail.com>
1334 A fix for bug #324319
1335 * ecore.cs: Explicitly type null when assigning to type argument to
1336 make pass verifier check.
1338 2009-01-27 Marek Safar <marek.safar@gmail.com>
1340 * anonymous.cs: Fixed recent regression when initializing captured
1343 2009-01-26 Marek Safar <marek.safar@gmail.com>
1345 A fix for bug #469019
1346 * anonymous.cs: Use all parent type parameters when instantiating
1347 nested generic storey.
1349 2009-01-26 Marek Safar <marek.safar@gmail.com>
1351 * expression.cs: Check for null instance methodgroup expression.
1353 2009-01-26 Marek Safar <marek.safar@gmail.com>
1355 A fix for bug #469244
1356 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1357 instance inside a conditional expression.
1359 2009-01-23 Marek Safar <marek.safar@gmail.com>
1361 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1362 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1363 GetElementType and HasElementType. IsValueType clean up.
1365 2009-01-23 Marek Safar <marek.safar@gmail.com>
1367 * nullable.cs: Use common EmitCall.
1369 * expression.cs: Emit constraint. for virtual calls only.
1371 2009-01-23 Marek Safar <marek.safar@gmail.com>
1373 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1374 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1375 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1378 2009-01-22 Jb Evain <jbevain@novell.com>
1380 * anonymous.cs: make anonymous types' ToString implementation
1381 match what csc outputs.
1383 2009-01-21 Marek Safar <marek.safar@gmail.com>
1385 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1388 2009-01-17 Marek Safar <marek.safar@gmail.com>
1390 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1393 2009-01-16 Marek Safar <marek.safar@gmail.com>
1395 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1398 2009-01-15 Marek Safar <marek.safar@gmail.com>
1400 A fix for bug #466634
1401 * statement.cs: Add reference for nested storey when only this
1404 2009-01-15 Marek Safar <marek.safar@gmail.com>
1406 A fix for bug #466474
1407 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1410 2009-01-15 Marek Safar <marek.safar@gmail.com>
1412 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1413 Fixed nested stories parent referencing process. Also fixes #463985.
1415 2009-01-06 Marek Safar <marek.safar@gmail.com>
1417 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1418 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1419 implementation. Also fixes #463108.
1421 2009-01-05 Marek Safar <marek.safar@gmail.com>
1423 A fix for bug #416109
1424 * decl.cs: Issue correct CLSAttribute warning location.
1426 2009-01-05 Marek Safar <marek.safar@gmail.com>
1428 A fix for bug #456775
1429 * attribute.cs: Use attribute owner scope when resolving attribute
1432 2009-01-05 Marek Safar <marek.safar@gmail.com>
1434 A fix for bug #457257
1435 * decl.cs: Fixed incorrect member declaring type comparison.
1437 2009-01-05 Marek Safar <marek.safar@gmail.com>
1439 A fix for bug #460896
1440 * driver.cs: Handle /RES resources as embeddable.
1442 2009-01-05 Marek Safar <marek.safar@gmail.com>
1444 A fix for bug #462515
1445 * ecore.cs: Report inacessible members upwards.
1447 2009-01-05 Marek Safar <marek.safar@gmail.com>
1449 A fix for bug #463190, #463192
1450 * decl.cs, namespace.cs: Also import internal extension classes.
1452 2009-01-04 Marek Safar <marek.safar@gmail.com>
1454 A fix for bug #463415
1455 * generic.cs: Use right index for RemoveDependentTypes.
1457 2009-01-02 Marek Safar <marek.safar@gmail.com>
1459 A fix for bug #463196
1460 * expression.cs: Fixed enum to null comparison.
1462 2009-01-02 Marek Safar <marek.safar@gmail.com>
1464 A fix for bug #463121
1465 * nullable.cs: Fixed nullable user equality operator comparison.
1467 2009-01-02 Marek Safar <marek.safar@gmail.com>
1469 A fix for bug #462950
1470 * class.cs, decl.cs: Use full explicit name when defining automatic
1471 property backing field.
1473 2009-01-02 Marek Safar <marek.safar@gmail.com>
1475 A fix for bug #462592
1476 * pending.cs: Emit type arguments for generic proxy method.
1478 2008-12-30 Marek Safar <marek.safar@gmail.com>
1480 * expression.cs (As): Mutate all type arguments.
1482 2008-12-29 Marek Safar <marek.safar@gmail.com>
1484 A fix for bug #462622
1485 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1488 2008-12-29 Marek Safar <marek.safar@gmail.com>
1490 A fix for bug #450782
1491 * ecore.cs: Consider more variables of form V.I to be fixed.
1493 2008-12-29 Marek Safar <marek.safar@gmail.com>
1495 A fix for bug #460712
1496 * typemanager.cs: Core types could be imported.
1498 2008-12-28 Marek Safar <marek.safar@gmail.com>
1500 A fix for bugs #460847, #460772, #458049, #457339, #447807
1501 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
1502 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
1503 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
1504 user lambdas used inside query clauses.
1506 2008-12-18 Marek Safar <marek.safar@gmail.com>
1508 A fix for bug #460229
1509 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
1511 2008-12-18 Marek Safar <marek.safar@gmail.com>
1513 A fix for bug #459952
1514 * decl.cs, namespace.cs: Use common CheckAccessLevel.
1516 2008-12-18 Marek Safar <marek.safar@gmail.com>
1518 A fix for bug #459630
1519 * convert.cs: Enum to valuetype conversion is not allowed.
1521 2008-12-18 Marek Safar <marek.safar@gmail.com>
1523 A fix for bug #457087
1524 * generic.cs: Don't crash when constraint comes from type
1527 2008-12-16 Marek Safar <marek.safar@gmail.com>
1529 A fix for bug #459221
1530 * anonymous.cs, statement.cs: Delay only captured this
1533 2008-12-12 Marek Safar <marek.safar@gmail.com>
1535 A fix for bug #457489
1536 * anonymous.cs, statement.cs: Split anonymous storey instantiation
1537 and initialization to capture scope initializers correctly.
1539 2008-12-11 Marek Safar <marek.safar@gmail.com>
1541 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
1542 ParameterReference refactoring.
1544 2008-12-03 Marek Safar <marek.safar@gmail.com>
1546 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
1547 to be imported from any assembly.
1549 2008-12-03 Marek Safar <marek.safar@gmail.com>
1551 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
1552 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
1553 from anonymous method and lambda expression.
1555 2008-12-01 Marek Safar <marek.safar@gmail.com>
1557 A fix for bug #448560
1558 * expression.cs (As): Box any generic type arguments to be
1561 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1563 Add tripwire for implicit conversion bugs
1564 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
1566 (MethodGroupExpr.OverloadResolve): Add sanity check between
1567 IsApplicable and VerifyArgumentsCompat.
1568 (VerifyArgumentsCompat): Report CS1501 where appropriate.
1570 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1572 Fix build break in System.Data_test
1573 * convert.cs (ImplicitConversionExists): Move NullLiteral
1575 (ImplicitStandardConversionExists): ... here.
1577 2008-11-28 Marek Safar <marek.safar@gmail.com>
1579 * literal.cs: Emit correctly explicit null to nullable cast.
1581 2008-11-28 Marek Safar <marek.safar@gmail.com>
1583 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
1586 2008-11-28 Marek Safar <marek.safar@gmail.com>
1588 A fix for bug #449005
1589 * convert.cs, nullable.cs: Use only one implicit nullable
1592 2008-11-27 Marek Safar <marek.safar@gmail.com>
1594 * convert.cs, literal.cs: More Convert cleanup is needed.
1596 2008-11-27 Marek Safar <marek.safar@gmail.com>
1598 * decl.cs, class.cs: Fixed misleading error message.
1600 2008-11-26 Marek Safar <marek.safar@gmail.com>
1602 A fix for bug #449005
1603 * nullable.cs (EmitEquality): Disable optimization for user operator
1606 2008-11-25 Marek Safar <marek.safar@gmail.com>
1608 A fix for bug #447027
1609 * anonymous.cs (HoistedVariable): Cache also outer access to deal
1610 with context variables stored as expression instances.
1612 2008-11-25 Marek Safar <marek.safar@gmail.com>
1614 A fix for bug #447027
1615 * delegate.cs: Fixed delegate VerifyMethod logic.
1617 2008-11-24 Marek Safar <marek.safar@gmail.com>
1619 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
1622 2008-11-21 Marek Safar <marek.safar@gmail.com>
1624 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
1625 member type resolve to follow normal flow, instead of random
1628 2008-11-21 Marek Safar <marek.safar@gmail.com>
1630 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
1633 2008-11-21 Marek Safar <marek.safar@gmail.com>
1635 * const.cs: Emit decimal array constant as literal.
1637 2008-11-20 Marek Safar <marek.safar@gmail.com>
1639 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
1641 2008-11-19 Marek Safar <marek.safar@gmail.com>
1643 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
1644 into real property (saves 8 MB for corlib compilation).
1646 2008-11-19 Marek Safar <marek.safar@gmail.com>
1648 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
1649 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
1650 generic-mcs.cs: Small cleanup of TypeArguments.
1652 2008-11-18 Marek Safar <marek.safar@gmail.com>
1654 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
1655 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
1656 of ConstructedType expression, renamed to GenericTypeExpr.
1658 2008-11-17 Marek Safar <marek.safar@gmail.com>
1660 A fix for bug #445303
1661 * location.cs (IsConditionalDefined): Handle undefined global
1664 2008-11-17 Marek Safar <marek.safar@gmail.com>
1666 A fix for bug #444678
1667 * expression.cs (TryReduceConstant): Always create new constant
1670 2008-11-17 Marek Safar <marek.safar@gmail.com>
1672 A fix for bug #444673
1673 * ecore.cs: Ignore open generic types when used as generic type
1676 2008-11-17 Marek Safar <marek.safar@gmail.com>
1678 A fix for bug #445458
1679 * expression.cs, cs-parser.jay: Don't crash when an expression
1682 2008-11-17 Marek Safar <marek.safar@gmail.com>
1684 A fix for bug #445464
1685 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
1686 inside unbound type.
1688 2008-11-14 Jb Evain <jbevain@novell.com>
1690 * driver.cs: ignore empty -nowarn argument such as
1691 the one in -nowarn:12,13,,.
1693 2008-11-13 Marek Safar <marek.safar@gmail.com>
1695 A fix for bug #444271
1696 * anonymous.cs: Rescan parent storeys when best candidate was
1699 2008-11-13 Marek Safar <marek.safar@gmail.com>
1701 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
1702 useless UnboundTypeExpression.
1704 * attribute.cs: Do check obsolete attribute on generic types.
1706 2008-11-12 Marek Safar <marek.safar@gmail.com>
1708 A fix for bugs #425680, #400139
1709 * ecore.cs, expression.cs: Trying to do some almost_matched_members
1712 2008-11-11 Marek Safar <marek.safar@gmail.com>
1714 A fix for bug #435747
1715 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
1716 compound value types assignment. Few micro optimizations added.
1718 2008-11-10 Marek Safar <marek.safar@gmail.com>
1720 A fix for bug #442610
1721 * anonymous.cs (MutateConstructor): More SRE hacking.
1723 2008-11-10 Marek Safar <marek.safar@gmail.com>
1725 A fix for bug #442579
1726 * ecore.cs: Also initialize expanded form of a method with 1 params
1729 2008-11-06 Marek Safar <marek.safar@gmail.com>
1731 * expression.cs (UnaryMutator): Do early l-side check.
1733 2008-11-05 Miguel de Icaza <miguel@novell.com>
1735 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
1736 Init, otherwise we would crash later on when checking for friend
1739 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
1740 Otherwise we never get any meaningful information as to what
1743 2008-11-05 Marek Safar <marek.safar@gmail.com>
1745 A fix for bug #436318
1746 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
1748 2008-11-05 Miguel de Icaza <miguel@novell.com>
1750 * namespace.cs: Turns out that it was a really bad idea to hide
1751 the errors for namespaces not found here in eval mode.
1753 * eval.cs: When we process using clauses, only enter those into
1754 the list of valid using clauses after they have been validated.
1756 The above change gives the proper semantics: it does not
1757 senselessly report the same errors with broken using statements by
1758 never storing them in the first place when they are invalid.
1760 2008-11-05 Marek Safar <marek.safar@gmail.com>
1762 A fix for bug #421839
1763 * cs-parser.jay: Remove expression from coalesce rule to force lower
1764 priority than the assignment operator.
1766 2008-11-05 Marek Safar <marek.safar@gmail.com>
1768 A fix for bug #437875
1769 * nullable.cs: Compile correctly method group operand used with null
1770 coalescing operator.
1772 2008-11-04 Marek Safar <marek.safar@gmail.com>
1774 A fix for bug #434589
1775 * expression.cs (Binary): Ignore lifted conversions when at least
1776 one operand is of reference type.
1778 2008-11-04 Marek Safar <marek.safar@gmail.com>
1780 * cs-parser.jay: Better syntax error report.
1782 2008-11-03 Marek Safar <marek.safar@gmail.com>
1784 A fix for bug #436792
1785 * cs-parser.jay: Use GetLocation to access location.
1787 2008-11-03 Marek Safar <marek.safar@gmail.com>
1789 A fix for bug #440774
1790 * cs-parser.jay: Also set current_array_type when parsing local
1793 2008-11-03 Marek Safar <marek.safar@gmail.com>
1795 A fix for bug #440785
1796 * expression.cs (As): Don't resolve self modifing expression
1799 2008-11-03 Marek Safar <marek.safar@gmail.com>
1801 A fix for bug #439447
1802 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
1804 2008-11-03 Marek Safar <marek.safar@gmail.com>
1806 A fix for bug #437571
1807 * cs-parser.jay: Fixes internal error for invalid expression
1810 2008-10-17 Marek Safar <marek.safar@gmail.com>
1812 * ecore.cs: Resolve correctly ambiguous params delegate methods.
1814 2008-10-17 Marek Safar <marek.safar@gmail.com>
1816 * generic.cs, anonymous.cs: Simplified GetDeclarations.
1818 2008-10-17 Marek Safar <marek.safar@gmail.com>
1820 * cs-tokenizer.cs: More precise cast parsing.
1822 2008-10-16 Martin Baulig <martin@ximian.com>
1824 * anonymous.cs (AnonymousMethodStorey): Put back the
1825 `hoisted_locals' hashtable and use it in EmitType().
1827 2008-10-15 Marek Safar <marek.safar@gmail.com>
1829 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
1830 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
1833 2008-10-14 Marek Safar <marek.safar@gmail.com>
1835 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
1837 2008-10-14 Marek Safar <marek.safar@gmail.com>
1839 * statement.cs: Mutate scope initializers.
1841 2008-10-14 Marek Safar <marek.safar@gmail.com>
1843 * expression.cs: Use typeless value for This constant.
1845 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
1847 2008-10-14 Marek Safar <marek.safar@gmail.com>
1849 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
1852 2008-10-13 Marek Safar <marek.safar@gmail.com>
1854 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
1857 2008-10-13 Marek Safar <marek.safar@gmail.com>
1859 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
1860 parser and tokenizer. Fixes many ambiguities including #433258.
1862 2008-10-10 Marek Safar <marek.safar@gmail.com>
1864 * cs-parser.jay: Fixed missing accessor recovery.
1866 2008-10-10 Marek Safar <marek.safar@gmail.com>
1868 A fix for bug #433701
1869 * expression.cs: Better error message.
1871 2008-10-10 Marek Safar <marek.safar@gmail.com>
1873 * cs-parser.jay, expression.cs: Start reporting real parser errors.
1875 * Makefile: Disabled unused debug symbols.
1877 Also fixes: #320556, #321097, #321656, #321876, #351316
1879 2008-10-09 Miguel de Icaza <miguel@novell.com>
1881 * eval.cs: rename "<interactive>" to "{interactive}", to work
1882 around a requirement in the compiler that this be a valid
1883 filename, and in Windows it is not (433886).
1885 2008-10-09 Marek Safar <marek.safar@gmail.com>
1887 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
1889 2008-10-08 Marek Safar <marek.safar@gmail.com>
1891 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
1892 cs-parser.jay: Generic type declaration and type arguments cleanup.
1894 2008-10-05 Marek Safar <marek.safar@gmail.com>
1896 * cs-parser.jay: Allow parsing weird array creation construct.
1898 2008-10-05 Marek Safar <marek.safar@gmail.com>
1900 * cs-parser.jay: Conflicts reduction.
1902 2008-10-04 Marek Safar <marek.safar@gmail.com>
1904 * cs-parser.jay: Conflicts reduction.
1906 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
1909 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
1910 property. Add a 'count' hint about the use of the shared vector.
1911 Ensure that we don't leak out dirty bits.
1912 (UsageVector.MergeChild): Throw away information about variables
1914 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
1916 2008-10-03 Marek Safar <marek.safar@gmail.com>
1918 A fix for bug #431746
1919 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
1920 parameters when iterator is created.
1922 2008-10-03 Marek Safar <marek.safar@gmail.com>
1924 A fix for bug #431827
1925 * expression.cs: Fixed right based pointer arithmetic operations
1928 2008-10-03 Marek Safar <marek.safar@gmail.com>
1930 A fix for bug #353779
1931 * assign.cs, expression.cs: Fixed compound assignment conversions.
1933 2008-10-02 Marek Safar <marek.safar@gmail.com>
1935 A fix for bug #375262
1936 * statement.cs: Refactor ArrayForeach to be usable with string
1937 indexer. Optimized single dimentional arrays foreach.
1939 2008-10-02 Marek Safar <marek.safar@gmail.com>
1941 A fix for bug #431255
1942 * anonymous.cs, expression.cs: Removed broken optimization.
1944 2008-10-01 Marek Safar <marek.safar@gmail.com>
1946 * anonymous.cs: Use full type parameters of parent generic
1947 containers. Removed unnecessary AddParentStoreyReference call.
1949 2008-10-01 Marek Safar <marek.safar@gmail.com>
1951 A fix for bug #324702
1952 * class.cs: Use better shorter names for explicit interface member
1955 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
1957 2008-10-01 Marek Safar <marek.safar@gmail.com>
1959 * expression.cs: Use new interface to check fixed expression.
1961 2008-10-01 Marek Safar <marek.safar@gmail.com>
1963 A fix for bug #421101
1964 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
1965 interface to check for fixed fixed-buffers.
1967 2008-10-01 Marek Safar <marek.safar@gmail.com>
1969 A fix for bug #429264
1970 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
1972 * delegate.cs: Removed unnecessary casts.
1974 2008-09-30 Marek Safar <marek.safar@gmail.com>
1976 A fix for bug #352151
1977 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
1978 class.cs: Fixed already defined explicit interface members check.
1980 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
1982 cs-tokenizer.cs: Fix typo.
1984 2008-09-28 Miguel de Icaza <miguel@novell.com>
1986 * eval.cs (InteractiveBase): The quit command now just sets a
1987 flag, instead of calling Environment.Exit(), it is milder on
1990 CompiledMethod is now in Mono.CSharp, not nested inside
1991 the Evaluator, it was inconvenient to use.
1993 2008-09-27 Miguel de Icaza <miguel@novell.com>
1995 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
1996 code to be invoked without having to reparse.
1998 2008-09-27 Miguel de Icaza <miguel@novell.com>
2000 * ecore.cs: The recent changes to FieldExpr broke this as well.
2001 Fixes LINQ queries in the interactive shell.
2003 * Multiple files: indentation fixing for the Mono coding
2004 guidelines for the switch statement.
2006 * eval.cs: Make the Evaluator API thread safe.
2008 2008-09-26 Marek Safar <marek.safar@gmail.com>
2010 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2011 constructor parsing.
2013 2008-09-26 Marek Safar <marek.safar@gmail.com>
2015 A fix for bug #325326
2016 * statement.cs: Check possible mistaken empty statement using
2017 explicit blocks only.
2019 2008-09-25 Miguel de Icaza <miguel@novell.com>
2021 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2022 RootNamespace.ComputeNamespaces to update the internal list of
2023 namespaces, this is no longer done for us.
2025 (InteractiveBase): Use the Evaluator APIs instead of calling into
2028 2008-09-25 Marek Safar <marek.safar@gmail.com>
2030 A fix for bug #429264
2031 * expression.cs: Missing mutator for access to multidimensional
2034 2008-09-25 Marek Safar <marek.safar@gmail.com>
2036 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2039 * driver.cs: Missing input argument check.
2041 2008-09-25 Marek Safar <marek.safar@gmail.com>
2043 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2044 expression.cs, statement.cs, rootcontext.cs, class.cs,
2045 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2048 2008-09-24 Miguel de Icaza <miguel@novell.com>
2050 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2051 fully constructed FieldExpr, fixes the regression introduced in
2054 * ecore.cs, expression.cs: Plug back the eclass initialization as
2055 otherwise it regresses `csharp'.
2057 2008-09-24 Marek Safar <marek.safar@gmail.com>
2059 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2060 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2061 phase to resolve phase. It resolves problems with expression trees
2062 and fixes bugs #323796, #325156.
2064 2008-09-23 Marek Safar <marek.safar@gmail.com>
2066 * codegen.cs: Report better error when symbol writer is missing.
2068 2008-09-23 Marek Safar <marek.safar@gmail.com>
2070 * codegen.cs: Set .NET symbol writer.
2072 * decl.cs: Guard against null generic arguments.
2074 * report.cs: Don't report exactly same additional details.
2076 2008-09-22 Marek Safar <marek.safar@gmail.com>
2078 A fix for bug #324917
2079 * cs-parser.jay: Add missing multidimensional non-expression type
2082 2008-09-22 Marek Safar <marek.safar@gmail.com>
2084 A fix for bug #428191
2085 * anonymous.cs: Create an outer generic fields also for non-storey
2088 2008-09-22 Marek Safar <marek.safar@gmail.com>
2090 A fix for bug #378294
2091 * class.cs: Make fixed size buffers gmcs feature only.
2093 2008-09-22 Marek Safar <marek.safar@gmail.com>
2095 A fix for bug #355622, #324993
2096 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2099 2008-09-19 Marek Safar <marek.safar@gmail.com>
2101 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2104 2008-09-19 Marek Safar <marek.safar@gmail.com>
2106 A fix for bug #416110
2107 * generic.cs: Struct constraint results in default ctor and
2108 ValueType base type constraint to be set.
2110 2008-09-19 Marek Safar <marek.safar@gmail.com>
2112 A fix for bug #423791
2113 * generic.cs: Fixed params output type type-inference.
2115 2008-09-19 Marek Safar <marek.safar@gmail.com>
2117 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2119 2008-09-19 Marek Safar <marek.safar@gmail.com>
2121 * cs-tokenizer.cs: Don't break on extra partial modifier.
2123 2008-09-19 Marek Safar <marek.safar@gmail.com>
2125 A fix for bug #427592
2126 * generic.cs: Use common parameter resolve method.
2128 2008-09-18 Marek Safar <marek.safar@gmail.com>
2130 A fix for bug #414758
2131 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2134 2008-09-18 Marek Safar <marek.safar@gmail.com>
2136 * driver.cs, namespace.cs: Read types and namespaces after all
2137 requested assemblies are loaded, fixes issues with System.Core
2138 auto-reference, and #419888.
2140 2008-09-18 Marek Safar <marek.safar@gmail.com>
2142 A fix for bug #417705
2143 * cs-parser.jay: Fixed as/is operator expression split.
2145 2008-09-18 Marek Safar <marek.safar@gmail.com>
2147 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2148 Fixed expression tree representation of empty new expression and
2149 new initializer expression.
2151 2008-09-18 Miguel de Icaza <miguel@novell.com>
2153 * eval.cs: Remove warning, keep reference to driver around.
2155 * Hide fields that do not need to be public.
2157 2008-09-17 Marek Safar <marek.safar@gmail.com>
2159 A fix for bug #426385
2160 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2161 conversion for array elements.
2163 2008-09-17 Marek Safar <marek.safar@gmail.com>
2165 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2166 void parsing conflicts.
2168 2008-09-15 Marek Safar <marek.safar@gmail.com>
2170 A fix for bug #425601
2171 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2172 System.Core only when there is no custom ExtensionAttribute
2175 2008-09-15 Miguel de Icaza <miguel@novell.com>
2177 * namespace.cs: Do not report CS0246 (name
2179 2008-09-12 Marek Safar <marek.safar@gmail.com>
2181 A fix for bug #425669
2182 * generic.cs: Don't cache generic static anonymous method
2185 2008-09-12 Marek Safar <marek.safar@gmail.com>
2187 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2188 conflicting constraints.
2190 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2192 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2195 2008-09-12 Marek Safar <marek.safar@gmail.com>
2197 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2198 to null pointer conversion fixes.
2200 2008-09-11 Marek Safar <marek.safar@gmail.com>
2202 * cs-parser.jay, expression.cs: An implicitly typed local variable
2203 declarator cannot use an array initializer.
2205 2008-09-11 Marek Safar <marek.safar@gmail.com>
2207 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2209 2008-09-11 Marek Safar <marek.safar@gmail.com>
2211 * generic.cs (InflatedConstraints): Don't crash when constraints
2214 * cs-parser.jay: const_declarator is a block.
2216 * constant.cs: Check for not allowed NaN conversions.
2218 2008-09-10 Miguel de Icaza <miguel@novell.com>
2220 * driver.cs: Drop --shell argument, the compiler is no longer a
2223 * eval.cs: Move most of the code that deals with evaluation into
2224 this file and document the public API from repl.cs
2226 * repl.cs: Remove from here.
2228 2008-09-10 Marek Safar <marek.safar@gmail.com>
2230 A fix for bug #424684
2231 * generic.cs: Generic class constraints must come first.
2233 2008-09-09 Miguel de Icaza <miguel@novell.com>
2235 * cs-parser.jay: Improve error reporting for syntax errors in
2236 statements and expressions, we now report the expected tokens
2237 instead of reporting the useless "; expected".
2239 Drop the strings from the token declaration, it turns out that
2240 they did not do what I thought they did. Instead they were adding
2241 two sets of tokens to the tables.
2243 2008-09-09 Marek Safar <marek.safar@gmail.com>
2245 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2246 delegate.cs: Share special type check.
2248 2008-09-09 Marek Safar <marek.safar@gmail.com>
2250 A fix for bug #423981
2251 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2253 2008-09-09 Marek Safar <marek.safar@gmail.com>
2255 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2258 2008-09-09 Marek Safar <marek.safar@gmail.com>
2260 A fix for bugs: #324750, #335946
2261 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2262 lookup rule to determine ?-based tokens.
2264 2008-09-08 Miguel de Icaza <miguel@novell.com>
2266 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2267 expressions (like event adding or removing) end up here, so we
2268 need to treat those as statements.
2270 Add LoadAssembly method.
2272 2008-09-04 Miguel de Icaza <miguel@novell.com>
2274 * repl.cs: Add Time method.
2276 2008-09-05 Marek Safar <marek.safar@gmail.com>
2278 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2280 2008-09-05 Miguel de Icaza <miguel@novell.com>
2282 * repl.cs: Add workaround for old compilers.
2284 2008-09-04 Jb Evain <jbevain@novell.com>
2286 * repl.cs (PrettyPrint): pretty print everything that
2287 implements IDictionary, as well as IEnumerables. Also,
2288 add a quit helper property.
2290 2008-09-04 Marek Safar <marek.safar@gmail.com>
2292 * constant.cs: Better error reporting for decimal literals.
2294 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2297 2008-09-04 Marek Safar <marek.safar@gmail.com>
2298 Miguel de Icaza <miguel@novell.com>
2300 A fix for bug #422951
2301 * assign.cs (Assign.DoResolve): Perform the type conversions
2302 checks before we attempt to initialize `New' initializers.
2304 2008-09-04 Marek Safar <marek.safar@gmail.com>
2306 A fix for bug #422853
2307 * delegate.cs (DelegateCreation): Add special handling for
2308 EmptyExpression.Null instance expression which is just another
2309 hack for undecided member instance exression.
2311 2008-09-04 Marek Safar <marek.safar@gmail.com>
2313 * expression.cs, ecore.cs: Emit full expression tree for reduced
2316 2008-09-04 Marek Safar <marek.safar@gmail.com>
2318 * expression.cs (This): Guard against multi-resolving.
2320 * ecore.cs, statement.cs (Throw): Simplified.
2322 * flowanalysis.cs: Also verify event fields.
2324 2008-09-04 Miguel de Icaza <miguel@novell.com>
2326 * assign.cs (Assign.DoResolve): Perform the type conversions
2327 checks before we attempt to initialize `New' initializers.
2329 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2331 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2334 * repl.cs: Update help.
2336 2008-09-03 Miguel de Icaza <miguel@novell.com>
2338 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2339 handling of the default config handling, including the special
2340 treatment of System.Core assembly.
2342 Fixes the REPL processing for LINQ.
2344 2008-09-03 Marek Safar <marek.safar@gmail.com>
2346 A fix for bug #422507
2347 * expression.cs (UnboxCast): Add missing child expression mutator.
2349 2008-09-03 Marek Safar <marek.safar@gmail.com>
2351 * driver.cs: Don't self reference System.Core assembly.
2353 2008-09-03 Marek Safar <marek.safar@gmail.com>
2355 A fix for bug #422507
2356 * expression.cs (StringConcat): Add missing type mutator.
2358 2008-09-03 Marek Safar <marek.safar@gmail.com>
2360 * generic.cs (TypeInferenceContext): Follow equality rule for
2361 constructed type lower bound type inference.
2363 2008-09-02 Miguel de Icaza <miguel@novell.com>
2365 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2366 <dblank@cs.brynmawr.edu> which updates the cursor position on
2369 2008-09-02 Marek Safar <marek.safar@gmail.com>
2371 A fix for bug #367145
2372 * driver.cs: Fixed import of extension methods when using -noconfig
2375 2008-09-02 Marek Safar <marek.safar@gmail.com>
2377 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2378 version from non-generic implementation instead.
2380 2008-09-01 Marek Safar <marek.safar@gmail.com>
2382 A fix for bug #418908
2383 * class.cs: Use AddScopeStatement for field initializers.
2385 2008-09-01 Marek Safar <marek.safar@gmail.com>
2387 A fix for bug #415385
2388 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2390 2008-09-01 Marek Safar <marek.safar@gmail.com>
2392 A fix for bug #421736
2393 * iterators.cs: Don't crash on unreachable iterators.
2395 2008-09-01 Marek Safar <marek.safar@gmail.com>
2397 A fix for bug #421628
2398 * parameter.cs, attribute.cs: Clone also parameter attributes.
2400 2008-08-30 Miguel de Icaza <miguel@novell.com>
2402 * namespace.cs (LookupType): In EvalMode, try to replace
2403 the TypeBuilder from our cache with a Type as Reflection.Emit does
2404 not like to mix code from older assemblies emitted and new
2407 This sounds like a serious Mono bug that prevents multiple
2408 assemblies to be generated and consumed at the same time.
2410 * cs-parser.jay (push_current_class): Do not make interactive
2411 classes internal or private, make them public as we currently
2412 generate each new class in a new assembly.
2414 2008-08-29 Miguel de Icaza <miguel@novell.com>
2416 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2417 remove types that are entered into the global namespace during
2418 parsing so that we can remove them on failure.
2420 * cs-parser.jay: Parsing: we now keep track of types that are
2421 entered into global variables and queue those in case the parsing
2424 This happens in a few situations: during partial-input, we invoke
2425 the parser repeatedly for example with the string "class X", this
2426 would cause X to be registed, and we need to remove this
2427 registration so that another parse attempt later with say "class X {"
2428 would actually work.
2430 Additionally, if there is an error in the resolution phase, for
2431 example: "class X : NonExistant {}" th
2433 * cs-parser.jay: Be more precise with the errors being raised,
2434 instead of flagging all exceptions during parsing to be attributed
2435 to the parsing process, distinguish those from errors happening in
2436 the actions and hint that using -v would produce the actual
2439 * repl.cs: Do not load all compiler references on each reset,
2440 doing the partial reset takes care of this.
2442 2008-08-28 Miguel de Icaza <miguel@novell.com>
2444 * repl.cs: Add support for loading all the files from
2445 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2448 Introduce a micro-parser that is able to deambiguate on its input
2449 whether we are dealing with a compilation unit (namespace, class,
2450 interface, struct, delegate) declaration or a statement. This
2451 allows both declarations and statements to be entered.
2453 Set history size by default to 300 lines.
2455 Instead of distinguishing based on the parser.InteractiveResult,
2456 have only two cases: statements were parsed, or a compilation unit
2457 was. Always pull the Using statement additions from the
2458 compilation unit parse.
2460 * cs-tokenizer.cs: Rename tokens to better describe their intent
2461 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2463 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2464 EvalMode is used to trigger the lookup of global variables while
2465 StatementMode is used turn variable declarations into static
2468 * getline.cs: Allow history size to be set.
2470 2008-08-29 Marek Safar <marek.safar@gmail.com>
2472 A fix for bug #360755
2473 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2475 2008-08-29 Marek Safar <marek.safar@gmail.com>
2477 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2479 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2480 member name, it is too confusing
2482 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2484 * rootcontext.cs: Finally default to warning level 4.
2486 2008-08-28 Marek Safar <marek.safar@gmail.com>
2488 * class.cs (CheckBase): Ignore overloaded operators.
2490 2008-08-28 Marek Safar <marek.safar@gmail.com>
2492 A fix for bug #420830
2493 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
2495 2008-08-28 Marek Safar <marek.safar@gmail.com>
2497 A fix for bug #420832
2498 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
2500 2008-08-28 Marek Safar <marek.safar@gmail.com>
2502 A fix for bug #420386
2503 * nullables.cs: Fixed logic of nullable user comparison operators involving
2506 2008-08-28 Marek Safar <marek.safar@gmail.com>
2508 * attribute (IsClsCompliant): Use FALSE value for pointer types.
2510 2008-08-27 Miguel de Icaza <miguel@novell.com>
2512 * repl.cs: Add support for aborting the running code with C-c.
2514 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
2516 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
2518 2008-08-27 Miguel de Icaza <miguel@novell.com>
2520 * cs-parser.jay (interactive_statement_list): A new set of rules
2521 for hosting statements that uses the "interactive_" prefix.
2523 * repl.cs: Add support for parsing `using' as a statement or as a
2524 directive. Deambiguating before passing this to the parser.
2526 We need to distinguish statement_expressions that occur at the
2527 toplevel vs those that occur embedded into expressions.
2529 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
2530 that fixes the cursor key handling, and a history bug.
2532 2008-08-26 Miguel de Icaza <miguel@novell.com>
2534 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
2535 limitations in Console, instead the 2.0 bootstrap libraries now
2536 include the Console bits.
2538 Also, remove the use of Nullables from getline.cs
2542 Interactive support for the C# compiler. Use gmcs --shell to
2543 enter a read-eval-print loop shell.
2545 Docs: http://www.mono-project.com/CsharpRepl
2547 * sources: include repl.cs here and getline.cs for gmcs.exe,
2548 everything else is getline.cs impaired.
2550 * Makefile: when bootstrapping pass a special flag
2551 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
2552 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
2553 This distinguishes those two cases.
2555 * repl.cs: Support for a read-eval-print loop. Will be soon
2556 refactored into eval support and then REPL on top of it.
2558 * ecore.cs: If a simplename lookup fails, before erroring out,
2559 if we are in EvalMode to resolve the name to a declaration in the
2562 This means that variable declarations that happened in previous
2563 classes (as repl puts every statement in a separate class) are
2564 made visible in this way.
2566 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
2567 triggered an error due to the end of file being reached. This is
2568 used to do multi-line input, and notify the caller that the user
2569 needs to provide more text before a successful parse.
2571 Add new grammar rules after the INTERACTIVE_PARSER token is seen
2572 to drive the evaluation with a custom wrapper.
2574 * driver.cs: Add support for --shell, and refactor some code to be
2577 * namespace.cs: Add support for serializing the contents of the
2578 namespaces and reloading them.
2580 * getline.cs: A managed implementation of ReadLine under
2581 X11/Apache2 license terms. Easy to embed in other applications as
2584 * namespace.cs: Add some functions to save and restore the
2587 * rootcontext.cs: New public field.
2589 * cs-tokenizer.cs: Add support for one of the possible characters
2590 we introduce into the token stream.
2592 This patch does not affect the regular tokenization process, the
2593 only performance hit would happen if there is an invalid character
2594 on the input string.
2596 * support.cs: Move isatty helper routine here.
2598 * codegen.cs: Small cleanup, and add a mechanism to initialize the
2599 code generator for in-memory assemblies.
2601 2008-08-26 Marek Safar <marek.safar@gmail.com>
2603 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
2604 parameter cannot be always used as a type.
2606 2008-08-21 Marek Safar <marek.safar@gmail.com>
2608 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
2610 2008-08-21 Marek Safar <marek.safar@gmail.com>
2612 * convert.cs: Implement explicit array to IList<T> conversion.
2614 2008-08-20 Marek Safar <marek.safar@gmail.com>
2616 A fix for bug #362740
2617 * cs-tokenizer.cs: Handle UTF-16 surrogates.
2619 2008-08-20 Marek Safar <marek.safar@gmail.com>
2621 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
2622 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
2623 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
2624 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
2625 handling to use just one type of infrastructure and deal with generics
2628 2008-07-23 Martin Baulig <martin@ximian.com>
2630 *** Merged this from trunk revision 108527 ***
2633 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
2634 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
2637 2008-08-15 Marek Safar <marek.safar@gmail.com>
2639 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
2642 2008-08-15 Marek Safar <marek.safar@gmail.com>
2644 * delegate.cs: Fixed compiler crash when creating delegate using partial
2647 * typemanager.cs: MulticastDelegate is not a delegate.
2649 2008-08-14 Marek Safar <marek.safar@gmail.com>
2651 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
2654 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
2656 * cs-parser.jay (type): Allow 'var' in mcs too.
2657 (local_variable_type): Likewise.
2659 2008-08-14 Marek Safar <marek.safar@gmail.com>
2661 * driver.cs: Removed broken -noconfig variants.
2663 2008-08-14 Marek Safar <marek.safar@gmail.com>
2665 A fix for bug #417078
2666 * expression.cs: Emit correctly left side pointer operators.
2668 2008-08-13 Marek Safar <marek.safar@gmail.com>
2670 * generic.cs, lambda.cs: Inflate method generic arguments only.
2672 2008-08-12 Marek Safar <marek.safar@gmail.com>
2674 * class.cs: Fixed struct layout check regression.
2676 2008-08-12 Marek Safar <marek.safar@gmail.com>
2678 * cs-parser.jay, enum.cs: Simplified enum parsing.
2680 * decl.cs: Check all type parameters conflicts.
2682 * expression.cs, statement.cs, attribute.cs: More expression checks.
2684 2008-08-11 Marek Safar <marek.safar@gmail.com>
2686 * generic.cs: Add type inference types restriction.
2688 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
2689 anonymous.cs, expression.cs: Allocate less accessor parameters.
2691 2008-08-08 Marek Safar <marek.safar@gmail.com>
2693 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
2696 2008-08-08 Marek Safar <marek.safar@gmail.com>
2698 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
2700 2008-08-07 Marek Safar <marek.safar@gmail.com>
2702 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
2703 Also fixes #362146 and #381592.
2705 2008-08-07 Marek Safar <marek.safar@gmail.com>
2707 * ecore.cs: Reduced constant cannot be used as an attribute value.
2709 * cs-parser.jay: Base expression has to be a type.
2711 * expression.cs (Conditional): Uses ReducedExpression.
2713 2008-08-06 Marek Safar <marek.safar@gmail.com>
2715 A fix for bug #376826
2716 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
2717 address of hoisted local variable or parameter cannot be taken.
2719 2008-08-05 Marek Safar <marek.safar@gmail.com>
2721 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
2722 anonymous method inside checked/unchecked expression.
2724 2008-08-05 Marek Safar <marek.safar@gmail.com>
2726 * typemanager.cs (IsEqual): Guard against null.
2728 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
2729 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
2730 routine. Fixed few misleading conversion errors.
2732 2008-08-04 Marek Safar <marek.safar@gmail.com>
2734 * class.cs: Consider generics when checking cycles in struct layout.
2736 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
2738 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
2740 2008-08-04 Marek Safar <marek.safar@gmail.com>
2742 A fix for bug #414165
2743 * anonymous.cs: Use same anonymous implementation method for all anonymous
2746 2008-08-04 Marek Safar <marek.safar@gmail.com>
2748 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
2751 2008-08-04 Marek Safar <marek.safar@gmail.com>
2753 * cs-parser.jay: Typeof argument has to be a type expression.
2755 * namespace.cs: Check alias and namespace definitions collisions.
2757 * class.cs, pending.cs: Moved explicit interface accessor implementation
2760 * delegate.cs, expression.cs: Verify special name invocations.
2762 2008-08-01 Marek Safar <marek.safar@gmail.com>
2764 * cs-parser.jay: Don't choke on empty generic type arguments.
2766 * cs-tokenizer.cs: Handle escaped preprocessor directives.
2768 * expression.cs, ecore.cs: Minor expressions bugs.
2770 2008-08-01 Marek Safar <marek.safar@gmail.com>
2772 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
2773 and added more error handling.
2775 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
2777 * modifiers.cs, enum.cs: Fixed.
2779 2008-07-31 Jb Evain <jbevain@novell.com>
2781 * driver.cs: remove -pkg ability of smcs.
2783 2008-07-30 Marek Safar <marek.safar@gmail.com>
2785 * statement.cs (Switch): Correctly set empty default target for single
2788 2008-07-30 Marek Safar <marek.safar@gmail.com>
2790 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
2791 string switch statement implementation to use string dictionary which
2792 significantly (2-8x) improves performance of generated code.
2794 2008-07-29 Marek Safar <marek.safar@gmail.com>
2796 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
2797 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
2799 2008-07-29 Marek Safar <marek.safar@gmail.com>
2801 A fix for bug #412595
2802 * typemanager.cs, convert.cs, expression.cs: Some types are never
2803 convertible to each other.
2805 2008-07-29 Marek Safar <marek.safar@gmail.com>
2807 * nullable.cs (CreateNullConstant): An error messages update.
2809 2008-07-29 Marek Safar <marek.safar@gmail.com>
2811 A fix for bug #412595
2812 * cfold.cs: Don't cast undefined bool constant.
2814 2008-07-29 Martin Baulig <martin@ximian.com>
2817 (SymbolWriter.Reset): New public static method.
2820 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
2822 2008-07-28 Marek Safar <marek.safar@gmail.com>
2824 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
2826 * expression.cs (ElementAccess): Exact size allocation.
2828 2008-07-26 Marek Safar <marek.safar@gmail.com>
2830 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
2832 2008-07-25 Marek Safar <marek.safar@gmail.com>
2834 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
2836 * class.cs: Removed $PRIVATE$ field hack which caused problems during
2839 2008-07-25 Marek Safar <marek.safar@gmail.com>
2841 A fix for bug #412217
2842 * assign.cs: Mutate also assignment type.
2844 2008-07-25 Marek Safar <marek.safar@gmail.com>
2846 A fix for bug #323644
2847 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
2850 2008-07-25 Marek Safar <marek.safar@gmail.com>
2852 A fix for bug #412134
2853 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
2854 non-enumerable operands when overloading equality or bitwise operators.
2856 2008-07-25 Marek Safar <marek.safar@gmail.com>
2858 * anonymous.cs: Cache closed generic anonymous method delegates.
2860 2008-07-24 Marek Safar <marek.safar@gmail.com>
2862 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
2863 anonymous.cs, statement.cs: Always emit anonymous method as static method
2864 when is instance free. Use nesting for nested anynomous methods blocks.
2866 2008-07-23 Marek Safar <marek.safar@gmail.com>
2868 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
2871 2008-07-23 Marek Safar <marek.safar@gmail.com>
2873 * expression.cs: Removed MakeSimpleCall.
2875 2008-07-23 Marek Safar <marek.safar@gmail.com>
2877 A fix for bug #323012
2878 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
2879 Base method implementing interface has to be public.
2881 2008-07-23 Marek Safar <marek.safar@gmail.com>
2883 * cs-parser.jay: Don't break on missing argument.
2885 2008-07-22 Marek Safar <marek.safar@gmail.com>
2887 A fix for bug #320993
2888 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
2889 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
2891 2008-07-22 Marek Safar <marek.safar@gmail.com>
2893 A fix for bug #320748
2894 * convert.cs: Implicit user operators cannot convert to interfaces
2896 2008-07-22 Marek Safar <marek.safar@gmail.com>
2898 A fix for bug #312686
2899 * driver.cs: Ignore empty assembly references.
2901 2008-07-22 Marek Safar <marek.safar@gmail.com>
2903 A fix for bug #387040
2904 * ecore.cs: Skip constrains check for an explicit implementation.
2906 2008-07-21 Marek Safar <marek.safar@gmail.com>
2908 A fix for bug #409045
2909 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
2910 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
2911 identifiers are file specific unless passed as input arguments.
2913 2008-07-21 Marek Safar <marek.safar@gmail.com>
2915 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
2916 to emit UnmanagedMarshal data under 2.0 profile.
2918 2008-07-21 Marek Safar <marek.safar@gmail.com>
2920 A fix for bug #410369
2921 * parameter.cs: Clone correctly ParamsParameter.
2923 2008-07-21 Marek Safar <marek.safar@gmail.com>
2925 * expression.cs (Argument): Always report type for type based expressions
2928 2008-07-18 Marek Safar <marek.safar@gmail.com>
2930 A fix for bug #410666
2931 * anonymous.cs: Correctly initialize generic storey reference.
2933 2008-07-18 Marek Safar <marek.safar@gmail.com>
2935 * convert.cs: Don't box same type arguments.
2937 2008-07-18 Marek Safar <marek.safar@gmail.com>
2939 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
2940 Finished missing generic type mutators.
2942 2008-07-18 Marek Safar <marek.safar@gmail.com>
2944 * iterators.cs, statement.cs: Finished statements CloneTo.
2946 2008-07-18 Marek Safar <marek.safar@gmail.com>
2948 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
2950 * expression.cs: Emit optimized default value expressions in expression tree
2953 2008-07-18 Marek Safar <marek.safar@gmail.com>
2955 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
2957 2008-07-17 Marek Safar <marek.safar@gmail.com>
2959 A fix for bug #367536
2960 * cs-parser.jay: Check static constructor of generic types for an access
2963 2008-07-17 Marek Safar <marek.safar@gmail.com>
2965 A fix for bug #353800
2966 * lambda.cs: Emit ret for contextual statements.
2968 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
2969 up emitting redundant ret for all anonymous methods with return.
2971 2008-07-17 Marek Safar <marek.safar@gmail.com>
2973 A fix for bug #365188
2974 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
2975 create anonymous method storey in unreachable block.
2977 2008-07-17 Marek Safar <marek.safar@gmail.com>
2979 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
2980 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
2981 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
2982 statement.cs: Fixed relevant defects found by Gendarme.
2984 2008-07-17 Marek Safar <marek.safar@gmail.com>
2986 A fix for bug #325291
2987 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
2988 statement.cs: Replaced IAnonymousHost with top level block flag.
2990 2008-07-17 Marek Safar <marek.safar@gmail.com>
2992 * cs-parser.jay: Clean up unused open_parens.
2994 2008-07-17 Marek Safar <marek.safar@gmail.com>
2996 * ecore.cs: Custom error message for a range variable assignment.
2998 2008-07-16 Marek Safar <marek.safar@gmail.com>
3000 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3003 2008-07-16 Marek Safar <marek.safar@gmail.com>
3005 * literal.cs: Null literal is of object type.
3007 2008-07-16 Marek Safar <marek.safar@gmail.com>
3009 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3010 expression of nullable equality comparison.
3012 2008-07-15 Marek Safar <marek.safar@gmail.com>
3014 * expression.cs(PointerArithmetic): Removed redundant assignment.
3016 2008-07-15 Marek Safar <marek.safar@gmail.com>
3018 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3020 2008-07-14 Marek Safar <marek.safar@gmail.com>
3022 A fix for bug #408361
3023 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3024 they are replaced by GetMethod.
3026 2008-07-14 Marek Safar <marek.safar@gmail.com>
3028 A fix for bug #408721 by jeremie.laval@gmail.com
3029 * expression.cs (Indirection): Implemented CloneTo.
3031 2008-07-14 Marek Safar <marek.safar@gmail.com>
3033 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3036 2008-07-14 Marek Safar <marek.safar@gmail.com>
3038 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3040 2008-07-11 Marek Safar <marek.safar@gmail.com>
3042 * linq.cs: Reset tranparent parameter counter in probing mode.
3044 2008-07-11 Marek Safar <marek.safar@gmail.com>
3046 * anonymous.cs: Mutate anonymous method type.
3048 2008-07-11 Marek Safar <marek.safar@gmail.com>
3050 * ecore.cs, anonymous.cs: Mutate field expressions.
3052 2008-07-10 Marek Safar <marek.safar@gmail.com>
3054 A fix for bug #369670
3055 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3057 2008-07-10 Marek Safar <marek.safar@gmail.com>
3059 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3061 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3064 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3065 only one '>', and finds a '>>', abort the generic lookahead.
3067 2008-07-10 Marek Safar <marek.safar@gmail.com>
3069 A fix for bug #319902
3070 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3072 2008-07-10 Marek Safar <marek.safar@gmail.com>
3074 A fix for bug #406371
3075 * statement.cs: Moved EmitSymbolInfo to Block.
3077 2008-07-09 Marek Safar <marek.safar@gmail.com>
3079 * ecore.cs: Report better error for extension method overload failures.
3081 2008-07-09 Marek Safar <marek.safar@gmail.com>
3083 * expression.cs (Is): No need to box reference values.
3085 2008-07-09 Marek Safar <marek.safar@gmail.com>
3087 * class.cs: Use event resolve context when initializing CreateEmitContext.
3089 2008-07-09 Marek Safar <marek.safar@gmail.com>
3091 A fix for bug #394436
3092 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3093 method used inside expression trees. Added more LINQ to expression tree
3096 2008-07-08 Marek Safar <marek.safar@gmail.com>
3098 A fix for bug #378189, #370577
3099 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3102 2008-07-08 Marek Safar <marek.safar@gmail.com>
3104 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3107 2008-07-08 Marek Safar <marek.safar@gmail.com>
3109 A fix for bug #406702
3110 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3112 2008-07-07 Marek Safar <marek.safar@gmail.com>
3114 A fix for bug #406648
3115 * cs-parser.jay: Report nullable use in mcs for some cases.
3117 2008-07-07 Marek Safar <marek.safar@gmail.com>
3119 * ecore.cs: Improved argument mismatch error messages.
3121 2008-07-07 Marek Safar <marek.safar@gmail.com>
3123 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3125 2008-07-07 Marek Safar <marek.safar@gmail.com>
3127 * expression.cs (TypeOf): Mutate type argument.
3129 2008-07-04 Marek Safar <marek.safar@gmail.com>
3131 * class.cs: Report missing partial modifier for correct type.
3133 2008-07-04 Marek Safar <marek.safar@gmail.com>
3135 * ecore.cs, expression.cs (VariableReference): Variable property is
3138 2008-07-04 Marek Safar <marek.safar@gmail.com>
3140 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3142 2008-07-04 Marek Safar <marek.safar@gmail.com>
3144 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3147 2008-07-04 Marek Safar <marek.safar@gmail.com>
3149 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3150 anonymous method storey to an instance method when only "this" is hoisted.
3152 2008-07-03 Marek Safar <marek.safar@gmail.com>
3154 A fix for bug #321615
3155 * expression.cs: Pointer comparisons use unsigned operator.
3157 2008-07-03 Marek Safar <marek.safar@gmail.com>
3159 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3161 2008-07-02 Marek Safar <marek.safar@gmail.com>
3163 A fix for bug #404905
3164 * class.cs: Always initialize local unsafe variables.
3166 2008-06-30 Marek Safar <marek.safar@gmail.com>
3168 A fix for bug #396987
3169 * expression.cs (NewInitialize): Clear local temporary variable for next run
3171 2008-06-27 Marek Safar <marek.safar@gmail.com>
3173 A fix for bug #401020
3174 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3176 2008-06-27 Marek Safar <marek.safar@gmail.com>
3178 A fix for bug #398319
3179 * cs-parser.jay: Implemented undocumented base access expression inside
3182 2008-06-26 Marek Safar <marek.safar@gmail.com>
3184 A fix for bug #404227
3185 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3187 2008-06-26 Marek Safar <marek.safar@gmail.com>
3189 A fix for bug #404227
3190 * convert.cs: Fixed explicit array to interface cast.
3192 2008-06-26 Marek Safar <marek.safar@gmail.com>
3194 A fix for bug #403894
3195 * delegate.cs: Mutate DelegateInvocation type.
3197 2008-06-26 Marek Safar <marek.safar@gmail.com>
3199 A fix for bug #379348
3200 * delegate.cs: Box a load of generic parameters.
3202 2008-06-26 Marek Safar <marek.safar@gmail.com>
3204 * expression.cs: Add an array creation arguments mutate.
3206 2008-06-26 Marek Safar <marek.safar@gmail.com>
3208 A fix for bug #386068
3209 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3212 2008-06-25 Marek Safar <marek.safar@gmail.com>
3214 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3217 2008-06-25 Marek Safar <marek.safar@gmail.com>
3219 A fix for bug #403518
3220 * delegate.cs: Type correctly anonymous method new invocation.
3222 2008-06-24 Marek Safar <marek.safar@gmail.com>
3224 A fix for bug #394826
3225 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3228 2008-06-24 Marek Safar <marek.safar@gmail.com>
3230 A fix for bug #394826
3231 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3234 2008-06-24 Marek Safar <marek.safar@gmail.com>
3236 * class.cs: Clone indexer parameters for localized capturing.
3238 2008-06-24 Marek Safar <marek.safar@gmail.com>
3240 A fix for bug #402379
3241 * expression.cs: Don't crash when an object initializer resolve fails.
3243 2008-06-24 Marek Safar <marek.safar@gmail.com>
3245 A fix for bug #402888
3246 * expression.cs: Mutate conditional expression.
3248 2008-06-24 Marek Safar <marek.safar@gmail.com>
3250 A fix for bug #401012
3251 * class.cs: Keep StructLayout in shared container.
3253 2008-06-24 Marek Safar <marek.safar@gmail.com>
3255 A fix for bug #400438
3256 * decl.cs, class.cs: Only properties can be automatically implemented.
3258 2008-06-24 Marek Safar <marek.safar@gmail.com>
3260 * statement.cs (ChangeToIterator): Copy also labels.
3262 2008-06-23 Marek Safar <marek.safar@gmail.com>
3264 * ecore.cs: Pass type argument details to parent extension method.
3266 2008-06-23 Marek Safar <marek.safar@gmail.com>
3268 A fix for bug #375966
3269 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3271 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3273 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3275 2008-06-22 Marek Safar <marek.safar@gmail.com>
3277 A fix for bug #394347
3278 * anonymous.cs: Cache compatible delegates as compatibility check produces
3279 a new method every time.
3281 2008-06-20 Marek Safar <marek.safar@gmail.com>
3283 * anonymous.cs: Propagate storey reference for single references.
3285 2008-06-20 Marek Safar <marek.safar@gmail.com>
3287 A fix for bug #387615
3288 * assign.cs, expression.cs: Correctly clone compound assignment.
3290 2008-06-19 Marek Safar <marek.safar@gmail.com>
3292 A fix for bug #359611, #359604
3293 * anonymous.cs: Mutate all types of hoisted parameters.
3295 2008-06-19 Marek Safar <marek.safar@gmail.com>
3297 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3298 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3299 expression.cs, codegen.cs, statement.cs
3301 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3302 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3304 ** Anonymous methods, lambda expressions rewrite **
3306 Anonymous expressions are now resolved when an explicit block is resolved
3307 and they don't require any registration procedure anymore. Further,
3308 anonymous methods are defined when explicit block is emitted which allows
3309 better control of whole process and opens possibilities for more
3310 optimizations as well as alternative to reverse whole process.
3312 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3313 process consistent and to correctly emit hoisted generic methods when they
3314 have at least 1 hoisted variable.
3316 2008-06-17 Martin Baulig <martin@ximian.com>
3318 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3320 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3321 virtual property; check it in Emit().
3322 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3324 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3326 (Indexer.Define): Likewise.
3328 2008-06-17 Marek Safar <marek.safar@gmail.com>
3330 * convert.cs: Don't use IsInterface on type arguments.
3332 * delegate.cs: DelegateInvocation uses MethodInfo.
3334 * parameter.cs: Removed IsTypeParameter.
3336 * generic-mcs.cs: More missing stuff.
3338 2008-06-16 Martin Baulig <martin@ximian.com>
3341 (Modifiers.DEBUGGER_HIDDEN): New public const.
3344 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3347 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3348 (AbstractPropertyEventMethod): Likewise.
3349 (Constructor.Emit): Likewise.
3350 (SourceMethod.SetCompilerGenerated): Removed.
3352 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3356 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3357 if we're an `IteratorHost'.
3358 (AnonymousMethodMethod..ctor): Don't set
3359 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3362 2008-06-16 Marek Safar <marek.safar@gmail.com>
3364 * statement.cs: Clean-up foreach statements.
3366 2008-06-12 Marek Safar <marek.safar@gmail.com>
3368 * class.cs: Stop using public method which should not exist
3369 (MethodBuilder.SetGenericMethodSignature).
3371 2008-06-11 Martin Baulig <martin@ximian.com>
3374 (Location.LookupFile): Add `CompilationUnit' argument; when given
3375 a relative file name, make it relative to the directory the .cs
3376 file is located in instead of using the current directory.
3378 2008-06-11 Martin Baulig <martin@ximian.com>
3381 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3382 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3383 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3384 (SourceMethod.SetCompilerGenerated): Likewise.
3386 2008-06-11 Marek Safar <marek.safar@gmail.com>
3388 * codegen.cs, driver: Only write symbol file when it's asked for.
3390 2008-06-11 Marek Safar <marek.safar@gmail.com>
3392 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3394 2008-06-10 Martin Baulig <martin@ximian.com>
3396 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3398 2008-06-09 Marek Safar <marek.safar@gmail.com>
3400 A fix for bug #316290
3401 * expression.cs: Include decimal operators in predefined table.
3403 * parameters.cs: More readonlyness.
3405 2008-06-09 Marek Safar <marek.safar@gmail.com>
3407 A fix for bug #397213
3408 * cs-parser.jay: One more missing current_local_parameters reset.
3410 2008-06-09 Marek Safar <marek.safar@gmail.com>
3412 A fix for bug #396633
3413 * class.cs: Host backing field in partial container.
3415 2008-06-09 Marek Safar <marek.safar@gmail.com>
3417 A fix for bug #397068
3418 * expression.cs: Check both operand types when predefined operator is used.
3420 2008-06-05 Martin Baulig <martin@ximian.com>
3422 Merged the `debugger-kahalo' branch.
3425 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3426 we're an iterator method.
3427 (SourceMethod): Reflect latest symbol writer changes;
3428 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3429 now `start_row' and `end_row'.
3430 (Constructor.Emit): Fix the logic whether to emit symbol information.
3432 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3436 (CompilationUnit): New public class; derives from `SourceFile'.
3437 (SourceFileEntry.DefineSymbolInfo): New public method.
3438 (SourceFileEntry.SetChecksum): New public method.
3439 (Location): Encode hidden line numbers by using `column == 255';
3440 the .ctor now accepts `column == -1' to mark a hidden line number.
3441 (Location.Hidden): New public property.
3442 (Location.CheckPoint): Add `CompilationUnit'.
3443 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3444 (Location.Push): Add `CompilationUnit compile_unit' argument.
3445 (Location.CompilationUnit): New public property.
3448 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3450 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3452 * driver.cs: `SourceFile' -> `CompilationUnit'.
3454 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3456 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3458 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3462 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3463 new symbol writer API to also pass the file.
3465 2008-06-05 Marek Safar <marek.safar@gmail.com>
3467 * statement.cs: Emit catch variable assignment using variable expression.
3469 2008-06-05 Marek Safar <marek.safar@gmail.com>
3471 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3472 with other variable types.
3474 2008-06-04 Marek Safar <marek.safar@gmail.com>
3476 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3477 GetLength method emit, it breaks resolve rules.
3479 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3480 Marek Safar <marek.safar@gmail.com>
3482 A fix for bug #395542
3483 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3486 2008-06-02 Marek Safar <marek.safar@gmail.com>
3488 A fix for bug #395287
3489 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
3491 2008-05-31 Marek Safar <marek.safar@gmail.com>
3493 A fix for bug #395845
3494 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
3495 non-nullable parameter type.
3497 2008-05-31 Marek Safar <marek.safar@gmail.com>
3499 * class.cs: Handle contructor initializer as a statement in top-level block.
3501 2008-05-30 Marek Safar <marek.safar@gmail.com>
3503 * attribute.cs: Don't mix old and new corlib types when emitting corlib
3504 security attributes.
3506 2008-05-24 Marek Safar <marek.safar@gmail.com>
3508 * ecore.cs, expression.cs: Small IVariable refactoring.
3510 2008-05-22 Marek Safar <marek.safar@gmail.com>
3512 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
3514 2008-05-21 Marek Safar <marek.safar@gmail.com>
3516 * cs-parser.jay: Removed redundant catch type check.
3518 2008-05-21 Marek Safar <marek.safar@gmail.com>
3520 A fix for bug #390372
3521 * nullable.cs: Set correct return type.
3523 2008-05-21 Marek Safar <marek.safar@gmail.com>
3525 A fix for bug #391062
3526 * typemanager.cs: Fixed crash when comparing null types.
3528 2008-05-21 Marek Safar <marek.safar@gmail.com>
3530 A fix for bug #391871
3531 * cs-parser.jay: Better error handling for invalid catch type.
3533 2008-05-20 Marek Safar <marek.safar@gmail.com>
3535 A fix for bug #392155
3536 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
3538 2008-05-15 Marek Safar <marek.safar@gmail.com>
3540 A fix for bug #390666
3541 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
3544 2008-05-15 Marek Safar <marek.safar@gmail.com>
3546 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
3549 2008-05-13 Marek Safar <marek.safar@gmail.com>
3551 A fix for bug #389625
3552 * delegate.cs, generic.cs: Some progress on method group return type
3555 2008-05-13 Marek Safar <marek.safar@gmail.com>
3557 A fix for bug #378419
3558 * namespace.cs: Inspect also parent namespaces not only namespace entries.
3560 2008-05-12 Marek Safar <marek.safar@gmail.com>
3562 * class.cs (Constructor): Added IsCompilerGenerated.
3564 2008-05-12 Marek Safar <marek.safar@gmail.com>
3566 * expression.cs: Enum binary operators can accept non-enum operand only when
3567 is implicitly convertible to underlying type.
3569 2008-05-12 Marek Safar <marek.safar@gmail.com>
3571 A fix for bug #389272
3572 * support.cs: Workaround System.InvalidOperationException for enums.
3574 2008-05-12 Marek Safar <marek.safar@gmail.com>
3576 A fix for bug #389073
3577 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
3579 2008-05-10 Marek Safar <marek.safar@gmail.com>
3581 * driver.cs: Split Parse.
3583 * location.cs (LookupFile): Uses string.Empty.
3585 2008-05-07 Marek Safar <marek.safar@gmail.com>
3587 * expression.cs, parameter.cs: Small ParameterReference clean up.
3589 2008-05-07 Marek Safar <marek.safar@gmail.com>
3591 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
3592 hack. Fixes #387502.
3594 2008-05-06 Martin Baulig <martin@ximian.com>
3596 * class.cs (Constructor.Emit): Fix the logic whether to emit
3599 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
3602 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
3603 InvalidOperationException when the iterator is before the start or
3606 2008-05-06 Marek Safar <marek.safar@gmail.com>
3608 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
3609 when left is nullable type.
3611 2008-05-06 Marek Safar <marek.safar@gmail.com>
3613 A fix for bug #386628
3614 * expression.cs (LocalVariableReference): Continue in resolving when
3615 variable is not assigned.
3617 2008-05-05 Marek Safar <marek.safar@gmail.com>
3619 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
3620 nullable operations.
3622 2008-05-04 Marek Safar <marek.safar@gmail.com>
3624 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
3625 it saves many redundant temporary variables for nullable operations.
3627 2008-05-03 Marek Safar <marek.safar@gmail.com>
3629 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
3631 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
3634 * nullable.cs: Constant coalescing operator optimizations.
3636 2008-05-03 Marek Safar <marek.safar@gmail.com>
3638 * constant.cs: Use unsigned conversion for values which are unsigned only.
3640 2008-05-03 Marek Safar <marek.safar@gmail.com>
3642 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
3643 coalescing operator as it should be.
3645 2008-05-02 Marek Safar <marek.safar@gmail.com>
3647 A fix for bug #371016
3648 * expression.cs: All predefined delegate operators require implicit method
3651 2008-05-02 Marek Safar <marek.safar@gmail.com>
3653 * constant.cs: Emit long constant as uint when fits the range.
3655 * convert.cs, expression.cs: Fixed few unsafe conversions.
3657 2008-05-02 Marek Safar <marek.safar@gmail.com>
3659 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
3661 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
3664 * convert.cs (ImplicitNumericConversion): Don't modify the type of
3666 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
3668 2008-05-01 Marek Safar <marek.safar@gmail.com>
3670 * constant.cs, literal.cs: IsLiteral property for error reporting.
3672 * ecore.cs, expression.cs: Implemented Property expression.
3674 2008-05-01 Marek Safar <marek.safar@gmail.com>
3676 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
3678 * nullable.cs: Implemented nullable coalescing null operator.
3680 * ecore.cs, expression.cs: Expression trees work.
3682 2008-05-01 Marek Safar <marek.safar@gmail.com>
3684 * ecore.cs: CreateExpressionTree is finally abstract.
3686 * expression.cs, linq.cs: Updated.
3688 2008-05-01 Marek Safar <marek.safar@gmail.com>
3690 * expression.cs, ecore.cs: Block base access expression inside expression
3693 2008-05-01 Marek Safar <marek.safar@gmail.com>
3695 A fix for bug #385058
3696 * expression.cs: User-defined operator implementations always take
3697 precedence over predefined operator implementations.
3699 2008-04-30 Marek Safar <marek.safar@gmail.com>
3701 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
3702 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
3703 expression tree conversions.
3705 2008-04-30 Marek Safar <marek.safar@gmail.com>
3707 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
3708 operators method details to Operator class.
3710 2008-04-30 Marek Safar <marek.safar@gmail.com>
3712 * anonymous.cs: Pass unsafe flags to anonymous container.
3714 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
3715 inside expression tree.
3717 2008-04-29 Martin Baulig <martin@ximian.com>
3719 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
3720 (Tokenizer.PopPosition): Also restore the `line'.
3722 2008-04-29 Marek Safar <marek.safar@gmail.com>
3724 * delegate.cs: Implemented Invoke expression.
3726 2008-04-29 Marek Safar <marek.safar@gmail.com>
3728 * expression.cs: Fixed equality reference comparison regression.
3730 2008-04-29 Marek Safar <marek.safar@gmail.com>
3732 * ecore.cs: Clean up EmptyCast hack.
3734 * expression.cs, nullable.cs: Implemented enum binary and unary operations
3735 using correct conversion rules. Also fixes #383993.
3737 2008-04-28 Martin Baulig <martin@ximian.com>
3739 * class.cs (Constructor.Emit): Don't emit debugging information
3740 for generated default .ctor's.
3742 2008-04-28 Marek Safar <marek.safar@gmail.com>
3744 * convert.cs: Empty-cast ushort to int conversion.
3746 2008-04-28 Marek Safar <marek.safar@gmail.com>
3748 A fix for bug #384191
3749 * ecore.cs, expression.cs: Fixed expression cloning.
3751 2008-04-28 Marek Safar <marek.safar@gmail.com>
3753 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
3755 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
3757 Fix #381559, test-638.cs, test-639.cs
3758 * assign.cs (CompoundAssign.Helper): New wrapper.
3759 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
3761 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
3762 Pass unconverted expressions to the params array creation expression.
3763 (FieldExpr.EmitAssign): Don't special-case StringConcat.
3764 (PropertyExpr.EmitAssign): Likewise.
3765 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
3766 element if it is of kind CompoundAssign.Helper.
3767 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
3768 first before anything else.
3769 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
3770 (ArrayAccess.LoadArrayAndArguments): Simplify.
3772 2008-04-27 Marek Safar <marek.safar@gmail.com>
3774 * expression.cs: Fixed cloning of typeof(void).
3776 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
3778 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
3779 (Assign.Emit): Likewise. Move it to ...
3780 (CompoundAssign.DoResolve): ... here and ...
3781 (CompoundAssign.Emit): ... here.
3782 (EventAddOrRemove): New helper to handle += and -= on events, and
3783 avoid the use of BinaryDelegates.
3784 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
3785 (EventExpr.EmitAddOrRemove): Improve.
3786 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
3788 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
3789 create VarExprs for 'foo.bar.var'.
3790 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
3791 is a highly inappropriate name for its functionality.
3793 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3795 Simplify handling of multiple assignments
3796 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
3798 (SimpleAssign): New. Class to be used for normal assignments.
3799 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
3800 * expression.cs, parameter.cs, statement.cs: Likewise.
3802 2008-04-25 Marek Safar <marek.safar@gmail.com>
3804 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
3805 for incompatible underlying types, more to come, uff.
3807 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3810 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
3811 Handle 'leave_copy'.
3813 2008-04-25 Marek Safar <marek.safar@gmail.com>
3815 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
3817 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
3819 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
3820 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
3821 * statement.cs (While, Do, For): Allow test to have side effects.
3822 (For.DoEmit): Always emit InitStatement.
3825 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
3826 Always create SideEffectConstant.
3827 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
3828 of type EnumConstant.
3830 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
3831 Handle 'right' being SideEffectConstant of type 'bool'.
3833 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
3834 Use left.EmitBranchable instead of open coding it, so as to
3835 improve optimization opportunities.
3837 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
3839 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
3841 (Expression.EmitSideEffect): Document.
3843 2008-04-23 Marek Safar <marek.safar@gmail.com>
3845 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
3847 2008-04-23 Marek Safar <marek.safar@gmail.com>
3849 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
3851 2008-04-23 Marek Safar <marek.safar@gmail.com>
3853 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
3854 conversion to expression tree.
3856 2008-04-23 Marek Safar <marek.safar@gmail.com>
3858 * ecore.cs: Removed unused expression.
3860 2008-04-22 Marek Safar <marek.safar@gmail.com>
3862 * expression.cs: Implemented NegateChecked and New expressions.
3864 2008-04-22 Marek Safar <marek.safar@gmail.com>
3866 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
3868 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
3871 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
3872 needing final 'ret' instruction.
3874 2008-04-22 Marek Safar <marek.safar@gmail.com>
3876 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
3878 2008-04-21 Marek Safar <marek.safar@gmail.com>
3880 * expression.cs: Emit ldnull and not null expression as an instance argument
3881 of static method expression calls.
3883 2008-04-21 Marek Safar <marek.safar@gmail.com>
3885 A fix for bug #378200
3886 * expression.cs: Fixed crash when creating parameterless expression tree
3889 2008-04-21 Marek Safar <marek.safar@gmail.com>
3891 A fix for bug #375297
3892 * anonymous.cs: Fixed crash when inferring from null argument anonymous
3895 2008-04-21 Marek Safar <marek.safar@gmail.com>
3897 A fix for bug #377596
3898 * decl.cs, class.cs: Emit delegate type argument attributes.
3900 2008-04-21 Marek Safar <marek.safar@gmail.com>
3902 A fix for bug #365314
3903 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
3905 2008-04-21 Marek Safar <marek.safar@gmail.com>
3907 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
3910 2008-04-21 Marek Safar <marek.safar@gmail.com>
3912 * generic.cs (TypeParameter): Removed redundant location.
3914 2008-04-19 Marek Safar <marek.safar@gmail.com>
3916 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
3917 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
3918 FullNamedExpression in all declaration type expression, statements will come
3921 2008-04-18 Marek Safar <marek.safar@gmail.com>
3923 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
3924 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
3926 2008-04-18 Marek Safar <marek.safar@gmail.com>
3928 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
3931 2008-04-17 Marek Safar <marek.safar@gmail.com>
3933 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
3936 2008-04-17 Marek Safar <marek.safar@gmail.com>
3938 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
3942 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
3944 Hook up 'EmitSideEffect'
3945 * constant.cs (Constant.EmitSideEffect): New.
3946 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
3947 (SideEffectConstant.EmitSideEffect): New.
3948 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
3949 unconditional branch in EmitBranchable.
3950 (FieldExpr.EmitBranchable): New.
3951 * expression.cs (Unary.EmitSideEffect): New.
3952 (Binary.EmitSideEffect): New.
3953 (VariableReference.EmitSideEffect): New. Do nothing.
3955 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
3957 Introduce 'EmitSideEffect'
3958 * ecore.cs (Expression.EmitSideEffect): New.
3959 (TypeCast): Rename from EmptyCast.
3961 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
3962 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
3963 * convert.cs, nullable.cs: Update to changes.
3965 2008-04-16 Marek Safar <marek.safar@gmail.com>
3967 * class.cs, cs-parser.jay: Early check for base types expression.
3969 2008-04-16 Marek Safar <marek.safar@gmail.com>
3971 * decl.cs (MemberName): Declare PrettyName as obsolete.
3973 2008-04-16 Marek Safar <marek.safar@gmail.com>
3975 * namespace.cs: Use MemberName comparison.
3977 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
3980 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
3982 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
3983 (MemberName.FullyQualifiedName): New. Provides the functionality
3984 that users assume FullName would have.
3985 * ecore.cs, namespace.cs: Update to changes.
3987 * statement.cs (Using.assign): Make into ExpressionStatement.
3988 (Using.EmitPreTryBody): Simplify.
3990 2008-04-16 Marek Safar <marek.safar@gmail.com>
3992 * report.cs: ColorFormat is protected.
3994 * rootcontext.cs: Unused fields clean-up.
3996 * namespace.cs: Made UsingEntry name private.
3998 2008-04-16 Marek Safar <marek.safar@gmail.com>
4000 * cs-tokenizer.cs, location.cs: Removed unused field.
4002 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4003 Raja R Harinath <harinath@hurrynot.org>
4006 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4007 (SideEffectConstant.side_effect): Rename from 'right'.
4008 (SideEffectConstant..ctor): Normalize 'side_effect'.
4009 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4010 value of this constant.
4011 * cfold.cs: Update to changes.
4013 2008-04-15 Marek Safar <marek.safar@gmail.com>
4015 * cs-paser.jay: Removed unused variable.
4017 * driver.cs: Made Compile instance method.
4019 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4021 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4023 2008-04-15 Marek Safar <marek.safar@gmail.com>
4025 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4027 2008-04-13 Jb Evain <jbevain@novell.com>
4029 * namespace.cs: update the System.Core fullname for 2.1
4030 * driver.cs: update the list of required assemblies for 2.1.
4031 Merged from the Moonlight 2 branch.
4033 2008-04-11 Marek Safar <marek.safar@gmail.com>
4035 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4036 types and user defined operators. User operators arguments has to be checked
4037 for null value before invocation, which also means no operator is called
4038 when any argument is not convertible to unwrapped nullable type.
4040 2008-04-09 Marek Safar <marek.safar@gmail.com>
4042 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4043 of Unary expressions to follow operator overloading rules precisely.
4044 Also fixes #321794, #323794
4046 2008-04-08 Marek Safar <marek.safar@gmail.com>
4048 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4051 2008-04-08 Marek Safar <marek.safar@gmail.com>
4053 * expression.cs, ecore.cs: Implemented MemberInit expression.
4055 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4057 Fix mono/tests/exception4.cs
4058 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4059 ec.NeedReturnLabel () rather emitting a 'nop'.
4061 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4063 (TryCatch.SomeCodeFollows): Likewise.
4064 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4065 for 'break', 'continue' and 'return' statements inside a try.
4066 We're fairly sure that the generated IL stream will have more
4067 instructions textually following the try.
4068 (FlowBranchingTryCatch): Likewise.
4070 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4071 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4074 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4075 wrapper -- forward everything to CollectionForeach.
4076 (CollectionForeach.NonDisposableWrapper): New.
4077 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4078 instead of a pop + branch to end.
4080 2008-04-07 Marek Safar <marek.safar@gmail.com>
4082 A fix for bug #377485
4083 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4084 Propagate location for extension method groups. Report conversion failure at
4087 2008-04-07 Marek Safar <marek.safar@gmail.com>
4089 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4090 ListInit and Field expressions.
4092 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4094 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4095 Since $PC is always -1 inside the body of MoveNext, the fault
4097 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4098 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4099 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4101 The denouement! Fix #324708
4102 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4103 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4104 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4105 'finally' inside the finally clause.
4107 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4108 inside an iterator. Don't emit the body of the 'finally' inside
4109 the finally clause yet.
4111 Use the ResumableStatement infrastructure for MoveNext ()
4112 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4113 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4114 'old_resume_points'. Move dispatcher upfront.
4115 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4116 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4117 in an enumerator. This encodes the main fix in this patch series
4118 -- we can only jump into the first instruction of a try from the
4119 outside, but we want to emit try/finally regions in iterators and
4120 resume in the middle of them.
4122 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4124 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4125 of NeedReturnLabel here.
4127 Introduce a common point for emitting try/finally to IL
4128 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4129 features of the various subclasses, which are now driven by ...
4130 (ExceptionStatement.EmitPreTryBody): ... this and ...
4131 (ExceptionStatement.EmitTryBody): ... this and the original
4133 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4134 Remove DoEmit and update to follow above protocol.
4136 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4137 of the dispatcher are the same, skip emitting the 'switch'.
4138 * iterator.cs (Iterator.EmitDispose): Update to changes.
4140 Clean up handling of 'using' statement
4141 * statement.cs (UsingTemporary): New. Carved out of ...
4142 (Using): ... this. Simplify drastically. Handle exactly
4144 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4145 or Using as appropriate. If there are multiple variable declared,
4146 create nested Using statements.
4147 (resource_acquisition): Kill.
4149 * statement.cs (ExceptionStatement.EmitForDispose): Use
4150 EmitFinallyBody, not EmitFinally.
4152 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4153 * iterator.cs: Update to changes.
4155 Start using the ResumableStatement infrastructure
4156 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4157 (ResumableStatement.EmitForDispose): New.
4158 (ExceptionStatement): Override them.
4159 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4160 EmitForDispose to create the body of the Dispose method. Don't
4163 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4164 * statement.cs (Toplevel.AddResumePoint): ... here.
4165 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4166 * flowanalysis.cs (FlowBranchingIterator): New.
4167 * codegen.cs (EmitContext): Update to changes.
4169 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4170 (Iterator.old_resume_points): Rename from 'resume_points'.
4171 (Iterator.MoveNextStatement): Remove unused class.
4173 New infrastructure for try/finally in iterators (still unused)
4174 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4175 (FlowBranchingToplevel.AddResumePoint): Hook into
4176 ToplevelBlock.AddResumePoint.
4177 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4178 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4179 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4180 resume points and assign program-counter values.
4181 (ExceptionBlock.AddResumePoint): Collect resume points for
4182 de-muxer at the top of try block.
4183 * iterators.cs (Yield.CheckContext): Simplify.
4184 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4186 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4188 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4189 argument to an ExitStatement.
4190 (FlowBranchingException): Refactor saved origins code.
4191 * statement.cs (ExitStatement): Update to cahges.
4192 * iterator.cs (YieldBreak): Likewise.
4194 * statement.cs (ResumableStatement): New. Common base class for
4195 YieldReturn and ExceptionStatement.
4196 (ExitStatement): New. Common base class for Return and YieldBreak.
4197 (Return): Update to changes.
4198 * iterator.cs (YieldBreak): Likewise.
4199 * lambda.cs (ContextualReturn): Likewise.
4202 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4203 emit a meaningful error message.
4205 Fix #324765, #319508
4206 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4207 (VariableInfo.SetAssigned): Set it.
4208 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4209 determine if CS0219 or CS0168 is appropriate. Don't use
4210 flow-analysis information.
4211 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4212 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4213 (EmitContext.EndFlowBranching): ... this.
4215 2008-04-03 Marek Safar <marek.safar@gmail.com>
4217 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4219 2008-04-03 Marek Safar <marek.safar@gmail.com>
4221 A fix for bug #376508
4222 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4223 ImplicitConversionExists.
4225 2008-04-03 Marek Safar <marek.safar@gmail.com>
4227 * expression.cs (Binary): Added remaining binary operators to expression
4230 * nullable.cs: Optimize shift with null argument.
4232 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4234 Fix minor IL regression
4235 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4236 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4237 * cs-parser.jay (try_statement): Update to changes.
4239 * statement.cs (TryFinally.need_exc_block): Delete.
4240 (TryFinally): Update to changes.
4242 Now all ExceptionStatements are unconditional
4243 * statement.cs (CollectionForeach.DisposableWrapper): New.
4244 Extract out the try/finally code into a new wrapper.
4245 (CollectionForeach.Resolve): Use it to simplify the code.
4247 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4249 Start at simplifying ExceptionStatement semantics a bit
4250 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4251 * cs-parser.jay (try_statement): Update to changes.
4252 (opt_catch_clauses): Remove.
4253 * flowanalysis.cs: Update to changes.
4254 (FlowBranching.BranchingType.TryCatch): New.
4255 (FlowBranchingTryCatch): New.
4257 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4258 (FlowBranching.CreateBranching): Update to changes.
4259 (FlowBranchingBlock.AddSibling): Add sanity check.
4260 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4263 * iterators.cs (Iterator.MarkFinally): Remove.
4264 * statement.cs (ExceptionStatement): Update to changes.
4266 Add support for skipping over finally blocks at runtime. First
4267 in a series to fix #324708
4268 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4269 (Iterator.EmitMoveNext): Initialize it.
4270 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4271 branch over the body of the 'finally' clause.
4273 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4275 Avoid lopsided use of Foo/DoFoo names
4276 * statement.cs (ExpressionStatement.EmitFinallyBody):
4277 Rename from EmitFinally.
4278 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4279 * iterator.cs: Update to changes.
4281 2008-04-02 Marek Safar <marek.safar@gmail.com>
4283 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4284 based on UserOperatorCall. More binary nullable operators clean up.
4286 2008-04-02 Martin Baulig <martin@ximian.com>
4288 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4290 2008-04-02 Marek Safar <marek.safar@gmail.com>
4292 * nullable.cs: Merge user and empty conversions when lifting expression
4295 * expression.cs (StringConcat): Implemented expression tree representation.
4297 2008-04-01 Marek Safar <marek.safar@gmail.com>
4299 * nullable.cs: When lifting null literal and a user operator exists, no call
4302 2008-04-01 Marek Safar <marek.safar@gmail.com>
4304 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4307 2008-04-01 Marek Safar <marek.safar@gmail.com>
4309 * nullable.cs, expression.cs: Use namespace instead heavily nested
4310 monster abstract class.
4312 2008-04-01 Marek Safar <marek.safar@gmail.com>
4314 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4315 lifting of null literal and user operators. Clean up of some temporary
4318 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4320 Fix #368224, test-629.cs
4321 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4322 if it crossed an unwind-protect boundary.
4323 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4324 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4325 inside an unwind-protected region.
4326 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4327 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4328 'leave' instead of a 'br' if unwind-protected.
4329 (Iterator.EmitYieldBreak): Likewise.
4331 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4333 * driver.cs: Only define versioninfo resources if no win32 resource
4336 2008-03-28 Marek Safar <marek.safar@gmail.com>
4338 A fix for bug #372375
4339 * convert.cs: Fixed boxing of nullable types.
4341 2008-03-28 Marek Safar <marek.safar@gmail.com>
4343 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4346 2008-03-28 Marek Safar <marek.safar@gmail.com>
4348 A fix for bug #374619
4349 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4351 2008-03-27 Marek Safar <marek.safar@gmail.com>
4353 * lambda.cs: Check return type only for invocation.
4355 2008-03-27 Marek Safar <marek.safar@gmail.com>
4357 A fix for bug #374214
4358 * ecore.cs: Correctly report argument type mismatch.
4360 2008-03-27 Marek Safar <marek.safar@gmail.com>
4362 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4363 and not rely on broken IsEnum.
4365 2008-03-27 Marek Safar <marek.safar@gmail.com>
4367 * nullable.cs: New file, extracted from generic.cs.
4369 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4371 2008-03-27 Marek Safar <marek.safar@gmail.com>
4373 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4374 predefined comparison operators and null literals.
4376 * report.cs: New warning ID.
4378 2008-03-25 Marek Safar <marek.safar@gmail.com>
4380 A fix for bug #370577
4381 * lambda.cs: Check return type too.
4383 2008-03-25 Marek Safar <marek.safar@gmail.com>
4385 A fix for bug #372846
4386 * class.cs: Automatic properties can be declared as unsafe.
4388 2008-03-20 Marek Safar <marek.safar@gmail.com>
4390 * location.cs: Use string based concatenation.
4392 * expression.cs: LiftedBinaryOperator is gmcs only.
4394 2008-03-20 Marek Safar <marek.safar@gmail.com>
4396 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4397 conversions rules and expression trees.
4399 2008-03-19 Marek Safar <marek.safar@gmail.com>
4401 * delegate.cs: Use extension method source as delegate target.
4403 2008-03-19 Marek Safar <marek.safar@gmail.com>
4405 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4406 binary operations to be purely based on binary operations and optimized
4407 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4408 and other ET refactoring.
4410 * typemanager.cs: Fixed warning.
4412 2008-03-17 Marek Safar <marek.safar@gmail.com>
4414 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4416 * symbolwriter.cs: Fixed.
4418 2008-03-17 Marek Safar <marek.safar@gmail.com>
4420 * anonymous.cs, driver.cs: Reset anonymous types counters.
4422 2008-03-17 Marek Safar <marek.safar@gmail.com>
4424 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4426 * class.cs: Use fullname for all type member definitions.
4428 2008-02-19 Martin Baulig <martin@ximian.com>
4431 (IMethodData.EmitExtraSymbolInfo): New interface method.
4432 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4433 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4434 interface method here as an empty public virtual method.
4437 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4438 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4439 CodeGen.SymbolWriter.SetRealMethodName().
4441 2008-02-18 Martin Baulig <martin@ximian.com>
4444 (ScopeInfo.EmitType): Override this and emit debugging
4445 information for captured variables.
4446 (RootScopeInfo.EmitType): Override this and emit symbol
4447 information for a captured `this'.
4449 2008-02-15 Martin Baulig <martin@ximian.com>
4451 * iterators.cs: Emit debugging info.
4454 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4455 (EmitContext.OmitDebuggingInfo): New public property.
4458 (While): Override Emit() and don't emit symbol info there; do it
4459 inside DoEmit() instead.
4460 (Block.Emit): Omit symbol information while emitting the scope
4461 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4463 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4464 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4465 .ctor to make `IsIterator' work.
4467 2008-03-14 Martin Baulig <martin@ximian.com>
4469 * symbolwriter.cs: Added the new symbol writer function from the
4470 debugger's `terrania' branch; temporarily enclose them inside
4471 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4474 2008-03-14 Martin Baulig <martin@ximian.com>
4477 (SymbolWriter): Make this a public static class.
4480 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4481 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4483 2008-03-14 Marek Safar <marek.safar@gmail.com>
4485 A fix for bug #370577
4486 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4489 2008-03-14 Marek Safar <marek.safar@gmail.com>
4491 * typemanager.cs (CSharpName): Made 250 times faster.
4493 2008-03-13 Marek Safar <marek.safar@gmail.com>
4495 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
4497 2008-03-12 Marek Safar <marek.safar@gmail.com>
4499 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
4500 crash when predefined field does not exist.
4502 2008-03-12 Marek Safar <marek.safar@gmail.com>
4504 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
4506 2008-03-12 Marek Safar <marek.safar@gmail.com>
4508 * class.cs (FixedField): Don't crash when contructors are missing.
4510 2008-03-11 Marek Safar <marek.safar@gmail.com>
4512 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
4513 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
4514 check internal types accessibility for internal and external types.
4515 Replaced EnumToUnderlying by GetEnumUnderlyingType.
4517 2008-03-11 Marek Safar <marek.safar@gmail.com>
4519 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
4520 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
4521 attribute.cs, statement: Use corect instance of predefined types (work
4522 related to #364674).
4524 2008-03-07 Marek Safar <marek.safar@gmail.com>
4526 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
4528 2008-03-07 Marek Safar <marek.safar@gmail.com>
4530 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
4531 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
4532 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
4533 predefined types clean up, delayed predefined types members initialization
4534 (work related to #364674).
4536 2008-03-05 Marek Safar <marek.safar@gmail.com>
4538 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
4540 2008-03-05 Marek Safar <marek.safar@gmail.com>
4542 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
4543 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
4544 predefined types clean up (work related to #364674).
4546 2008-03-04 Marek Safar <marek.safar@gmail.com>
4548 * ecore.cs: Print an error message instead of throwing exception.
4550 2008-03-04 Marek Safar <marek.safar@gmail.com>
4552 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
4553 expression.cs, statement.cs: Unififed null literal representation.
4555 2008-03-03 Marek Safar <marek.safar@gmail.com>
4557 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
4558 expression.cs: Refactored binary operators resolve phase and improved speed.
4559 The nullable code is still missing and won't work correctly, more fixes
4562 It also fixes #323726, #324312, #324248, and many other unreported issues.
4564 2008-02-29 Zoltan Varga <vargaz@gmail.com>
4566 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
4569 2008-02-27 Marek Safar <marek.safar@gmail.com>
4571 * ecore.cs: Clean-up and split BetterConversion.
4573 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
4576 * enum.cs (EnumMember.Value): Only access 'value' if
4577 ResolveValue says it's ok.
4578 (EnumMember.DoResolveValue): Don't set prev_member.value.
4579 (Enum.GetDefinition): Reverse arguments of Equals --
4580 EnumMember.Value can return 'null'.
4582 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
4584 2008-02-22 Marek Safar <marek.safar@gmail.com>
4586 * generic.cs, expression.cs: More ongoing work on expression trees.
4588 2008-02-21 Marek Safar <marek.safar@gmail.com>
4590 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
4591 handle missing matches when mutiple operators exist.
4593 2008-02-20 Marek Safar <marek.safar@gmail.com>
4595 A fix for bug #363218
4596 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
4599 2008-02-20 Marek Safar <marek.safar@gmail.com>
4601 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
4602 update. This time to deal correctly with SideEffectConstant expression used
4603 as an argument for another constant folding.
4605 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
4607 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
4610 2008-02-19 Marek Safar <marek.safar@gmail.com>
4612 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
4614 2008-02-19 Marek Safar <marek.safar@gmail.com>
4616 A fix for bug #328136
4617 * expression.cs: Do not fold immediately LogicalAnd operators when the left
4618 side is a false constant, because we still need to evaluate the right-hand
4621 * statement.cs (If): Emit two types of boolean constants (simple constant,
4622 side-effect constant).
4624 2008-02-19 Marek Safar <marek.safar@gmail.com>
4626 * constant.cs (SideEffectConstant): Don't emit boolean constant.
4628 * expression.cs: Fold immediately LogicalAnd operators when both sides are
4631 2008-02-18 Marek Safar <marek.safar@gmail.com>
4633 A fix for bug #361457
4634 * ecore.cs (IsApplicable): Params methods have lower priority.
4636 * support.cs: Return correct parameter modifier for params types.
4638 2008-02-18 Marek Safar <marek.safar@gmail.com>
4640 * generic.cs (TypeParameter): Cache attribute target name.
4642 * support.cs: Removed unused variable.
4644 * typemanager.cs: Removed debugging leftover.
4646 * ecore.cs: Use local type instead of a property;
4648 * class.cs (VerifyMembers): Consider also parent to test whether type member
4651 * expression.cs (FullMethodDesc): Removed.
4653 * attribute.cs (IsValidArgumentType): Made static.
4655 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
4657 Cleanup to be more readable.
4658 * Makefile (GMCS_PROFILE): Remove.
4659 (COMPILER_NAME): New helper.
4661 2008-02-15 Miguel de Icaza <miguel@novell.com>
4663 * cs-tokenizer.cs: if a conditional expression happens inside a
4664 (...) this also means that we do not need to de-ambiguate between
4665 an parenthesized expression and a cast.
4669 * constant.cs (SideEffectConstant): a constant value that happens
4670 to have a side effect.
4672 Fixes the build regressions introduced by the fix for #359789
4674 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
4676 * expression.cs (Conditional.Emit): when emitting the ternary
4677 operator, use local variables to generate code verifiable code.
4679 The verifier cannot infer that the type on stack before the
4680 stloc.0 is executed is of type ParentB. This happens because the
4681 stack merge algorithm uses only parent types when deciding which
4682 is the common type. This is described in Part III 1.8.1.3 of ECMA
4685 This code compiled with mcs is not verifiable under MS. The MS
4686 verifier picks the first common interface of Foo and Bar, which is
4687 wrong, but doesn't use a full join type of the 2 interfaces.
4689 CSC uses a clever hack to compile such code in a verifiable
4690 way. It stores the intermediate values in a local variable with
4695 2008-02-14 Miguel de Icaza <miguel@novell.com>
4697 * expression.cs: Do not fold BitwiseAnd operators when the left
4698 side is a false constant, because we still need to evaluate the
4703 * support.cs: Instead of throwing an InternalErrorException when
4704 the position of the stream is outside the boundary of our buffer,
4705 reset the state of the reader, and restart the reading from the
4706 beginning of the file.
4708 2008-02-14 Marek Safar <marek.safar@gmail.com>
4710 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
4712 2008-02-14 Marek Safar <marek.safar@gmail.com>
4714 A fix for bug #361686
4715 * decl.cs: A protected types used inside a private class which parents
4716 derives from the protected class are accessible.
4718 2008-02-13 Marek Safar <marek.safar@gmail.com>
4720 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
4721 the parameterless constructor.
4723 2008-02-13 Marek Safar <marek.safar@gmail.com>
4725 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
4726 lookup methods to use standard member cache when doing member lookup.
4728 2008-02-12 Marek Safar <marek.safar@gmail.com>
4730 * driver.cs: Don't report full path for referenced module as assembly error.
4732 2008-02-12 Marek Safar <marek.safar@gmail.com>
4734 * Makefile: Fixed `qh' target to work on all machines.
4736 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
4737 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
4738 and HasElementType with TypeManager implementation.
4740 2008-02-08 Marek Safar <marek.safar@gmail.com>
4742 A fix for bugs #325134, #359749
4743 * expression.cs, ecore.cs: Try to resolve an extension method even if the
4744 first binds point to non-method member expression.
4746 2008-02-08 Marek Safar <marek.safar@gmail.com>
4748 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
4750 2008-02-08 Marek Safar <marek.safar@gmail.com>
4752 A fix for bugs #321394, #323028
4753 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
4754 Reworked naive IsAccessibleAs implementation to handle nested types.
4756 2008-02-05 Jb Evain <jbevain@novell.com>
4758 * class.cs: use generic type comparison for parameters
4761 2008-02-05 Marek Safar <marek.safar@gmail.com>
4763 A fix for bug #325372
4764 * class.cs: Use generic type comparison when testing method signatures.
4766 2008-02-05 Marek Safar <marek.safar@gmail.com>
4768 A fix for bug #357047
4769 * ecore.cs: Applied C# 3.0 changes to better conversion.
4771 2008-02-05 Marek Safar <marek.safar@gmail.com>
4773 A fix for bug #358374
4774 * cs-parser.jay: Correctly set modifiers for all constructor types.
4776 2008-02-04 Marek Safar <marek.safar@gmail.com>
4778 A fix for bug #355251
4779 * generic.cs: Added base class constraint based type inference.
4781 2008-02-01 Marek Safar <marek.safar@gmail.com>
4783 A fix for bug #357255
4784 * decl.cs: One more missing visibility check.
4786 2008-02-01 Marek Safar <marek.safar@gmail.com>
4788 * support.cs: Fixed broken return.
4790 2008-01-25 Marek Safar <marek.safar@gmail.com>
4792 * report.cs: Correctly reset warnings count after probing.
4794 2008-01-25 Martin Baulig <martin@ximian.com>
4797 (NamespaceEntry.SymbolFileID): Make this work again after
4798 MemberName.ToString() is gone.
4800 2008-01-25 Marek Safar <marek.safar@gmail.com>
4802 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
4805 2008-01-25 Marek Safar <marek.safar@gmail.com>
4807 * generic.cs: Use full implicit conversion for type inference fixing.
4809 2008-01-24 Marek Safar <marek.safar@gmail.com>
4811 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
4812 Fixed user operator conversions.
4814 2008-01-24 Marek Safar <marek.safar@gmail.com>
4816 * generic.cs: Do nullable type to null comparison optimization during
4819 2008-01-24 Marek Safar <marek.safar@gmail.com>
4821 A fix for bug #355163
4822 * generic.cs: Enabled l-value resolve on nullable expressions.
4824 2008-01-24 Marek Safar <marek.safar@gmail.com>
4826 A fix for bug #353986
4827 * class.cs: Ingore static ctors with parameters for any further checks.
4829 2008-01-24 Marek Safar <marek.safar@gmail.com>
4831 A fix for bug #354310
4832 * namespace.cs: Removed redundant check.
4834 2008-01-24 Marek Safar <marek.safar@gmail.com>
4836 A fix for bug #354928
4837 * expression.cs: ElementInitializers can be resolved only once.
4839 2008-01-24 Marek Safar <marek.safar@gmail.com>
4841 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
4842 Condition expressions.
4844 2008-01-23 Marek Safar <marek.safar@gmail.com>
4846 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
4848 2008-01-22 Marek Safar <marek.safar@gmail.com>
4850 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
4853 * generic.cs: Implemented coalesce expression.
4855 2008-01-22 Marek Safar <marek.safar@gmail.com>
4857 A fix for bug #355145
4858 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
4859 expression tree type inference.
4861 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
4864 * expression.cs (Binary.IsUnsignedType): Fix typo.
4866 2008-01-22 Marek Safar <marek.safar@gmail.com>
4868 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
4870 2008-01-22 Marek Safar <marek.safar@gmail.com>
4872 A fix for bug #355161
4873 * ecore.cs, expression.cs: Wider range of extension method supported
4876 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
4878 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
4879 AssemblyBuilder to operate in compiler context. Fixes mcs part of
4882 2008-01-22 Marek Safar <marek.safar@gmail.com>
4884 A fix for bug #355148
4885 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
4887 2008-01-22 Miguel de Icaza <miguel@novell.com>
4889 * expression.cs (CreateExpressionTree): Add support for or and
4890 logical or, and indent following the coding conventions.
4892 * typemanager.cs (LinqExpression): renamed from
4893 ExpressionTreeManager, for a shorter name.
4895 Use TypeManager.CoreLookupType to lookup types from our core
4896 assemblies and turn those into "Type" variables.
4898 Consumers that previously used "Namespace" and "Type" from this
4899 class should instead use the TypeExpression which is a type that
4900 is fully resolved (without involving the regular C# resolution
4903 This typically looks like this:
4905 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
4906 new MemberAccess (texpr, name, type_arguments, loc)
4908 This avoids the problem in: #355178
4910 2008-01-21 Marek Safar <marek.safar@gmail.com>
4912 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
4913 feature in parser only as we do in other cases.
4915 2008-01-21 Marek Safar <marek.safar@gmail.com>
4917 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
4918 typemanager.cs: A refactoring of params arguments to reuse existing
4919 expressions (params -> array initializer) to emit params argument instead
4920 of specialized handling.
4921 It was required by expression tree implementation and it has other benefits
4922 as well, we now apply same optimization for params arguments as we do for
4925 2008-01-18 Marek Safar <marek.safar@gmail.com>
4927 A fix for bug #353526
4928 * generic.cs: A type inference of params arguments may not required any
4929 temporary array creation.
4931 2008-01-18 Marek Safar <marek.safar@gmail.com>
4933 A fix for bug #353534
4934 * generic.cs, ecore.cs, expression.cs: A method group type inference is
4935 supported for delegates only.
4937 2008-01-18 Marek Safar <marek.safar@gmail.com>
4939 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
4940 type for more than 1 candidates.
4942 2008-01-18 Marek Safar <marek.safar@gmail.com>
4944 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
4947 2008-01-16 Marek Safar <marek.safar@gmail.com>
4949 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
4950 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
4951 operator) expressions.
4953 2008-01-16 Zoltan Varga <vargaz@gmail.com>
4955 * statement.cs: Avoid declaring an IL variable for this_variable since it is
4956 not accessed from the generated IL.
4958 2008-01-14 Marek Safar <marek.safar@gmail.com>
4960 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
4961 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
4962 statement.cs: The first expression tree implementation drop, mostly
4963 infrastructure work.
4965 2008-01-14 Marek Safar <marek.safar@gmail.com>
4967 * ecore.cs (IsNestedChild): Refactored.
4969 2008-01-11 Marek Safar <marek.safar@gmail.com>
4971 * lambda.cs: Don't use a cast on unknown expression statement.
4973 2008-01-10 Geoff Norton <gnorton@novell.com>
4975 * cs-tokenizer.cs: One more token to distinguish between method and lambda
4978 2008-01-09 Marek Safar <marek.safar@gmail.com>
4980 * doc.cs: Report better /doc crash details.
4982 2008-01-09 Marek Safar <marek.safar@gmail.com>
4984 A fix for bug #352536
4985 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
4987 2008-01-08 Marek Safar <marek.safar@gmail.com>
4989 A fix for bug #352287
4990 * ecore.cs, expression.cs: Do `this' access checking in all member access
4993 2008-01-08 Marek Safar <marek.safar@gmail.com>
4995 * rootcontext.cs, driver.cs: Switch to linq mode by default.
4997 * report.cs: Reset message stacks.
4999 2008-01-08 Marek Safar <marek.safar@gmail.com>
5001 * generic.cs (InferInPhases): Correctly calculate params position.
5003 2008-01-08 Marek Safar <marek.safar@gmail.com>
5005 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5008 2008-01-07 Marek Safar <marek.safar@gmail.com>
5010 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5012 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5014 * driver.cs: Updated --help option.
5016 2008-01-07 Marek Safar <marek.safar@gmail.com>
5018 * generic.cs (InferParamsTypeArguments): Removed.
5019 (InferInPhases): Add params type inference.
5020 (LowerBoundInference): Fixed scoring mechanism.
5022 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5024 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5026 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5027 byte array for unsigned "baked" assemblies.
5029 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5031 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5032 array for assemblies that are not strongnamed.
5034 2008-01-04 Marek Safar <marek.safar@gmail.com>
5036 A fix for bug #351481
5037 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5038 declaring type for nested generic types.
5040 2008-01-04 Marek Safar <marek.safar@gmail.com>
5042 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5043 instead of ToString.
5045 2008-01-03 Marek Safar <marek.safar@gmail.com>
5047 A fix for bug #351047
5048 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5049 null and structs only when equality and inequality operators are defined
5050 either as an user-operators or predefined operators.
5052 2008-01-03 Marek Safar <marek.safar@gmail.com>
5054 A fix for bug #351047
5055 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5057 2008-01-03 Marek Safar <marek.safar@gmail.com>
5059 A fix for bug #351257
5060 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5062 2008-01-03 Marek Safar <marek.safar@gmail.com>
5064 A fix for bug #351157
5065 * class.cs (Using): Fixed yet another broken cloning.
5067 (Block): Put back more sensible default value for statements.
5069 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5071 * codegen.cs: Allow AssemblyVersion with only major version component.
5074 2007-12-29 Marek Safar <marek.safar@gmail.com>
5076 A fix for bug #324654
5077 * class.cs: Use FullName property as member name.
5079 2007-12-28 Marek Safar <marek.safar@gmail.com>
5081 A fix for bug #342117
5082 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5083 constructor constraint.
5085 2007-12-28 Marek Safar <marek.safar@gmail.com>
5087 A fix for bug #338273
5088 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5091 2007-12-28 Marek Safar <marek.safar@gmail.com>
5093 A fix for bug #350839
5094 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5096 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5098 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5101 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5103 * statement.cs: Changed some Hashtables to use HybridDictionaries
5104 instead. It was observed that some HashTables only contained a few
5105 items in the vast majority of cases. Since HybridDictionary is
5106 more efficient on small sets (<10 elements), "known_variables"
5107 from class ExplicitBlock as well as "labels" and "constants " from
5108 class Block were changed to HybridDictionaries.
5110 Atsai results: (56216kb->54987kb)
5112 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5115 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5117 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5120 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5122 * expression.cs: foreach loop to for loop, saved on allocation of
5123 enumerator (59333kb->59141kb)
5125 * statement.cs. Changed foreach loops to for loops, saved on
5126 allocation of enumerator (59141kb->59006kb)
5128 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5129 when constructed with no specified capacity. This was causing a
5130 few ArrayLists to allocate more memory than they would potentially
5131 need in the Block class and MemberCache class. Setting the
5132 ArrayLists to construct with a capacity of 1 saves some
5133 memory. (56216kb->55585kb)
5135 2007-12-27 Marek Safar <marek.safar@gmail.com>
5137 A fix for bug #347189 (2nd issue)
5138 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5141 2007-12-27 Miguel de Icaza <miguel@novell.com>
5143 * report.cs: Do not use colors if stdout and stderr are not a
5146 2007-12-27 Marek Safar <marek.safar@gmail.com>
5148 A fix for bug #346998
5149 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5152 2007-12-27 Marek Safar <marek.safar@gmail.com>
5154 A fix for bug #343465
5155 * class.cs: Explicit method name for nested types uses dots only.
5157 2007-12-27 Marek Safar <marek.safar@gmail.com>
5159 A fix for bug #343707
5160 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5162 2007-12-27 Marek Safar <marek.safar@gmail.com>
5164 * ecore.cs: Report type inference errors only when arguments count matches
5167 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5169 * expression.cs, report.cs: New warning.
5171 * typemanager.cs: Catch anonymous method type too.
5173 2007-12-23 Marek Safar <marek.safar@gmail.com>
5175 A fix for bug #346379
5176 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5178 2007-12-23 Marek Safar <marek.safar@gmail.com>
5180 A fix for bug #347359
5181 * expression.cs (Invocation): Don't resolve already resolved expression.
5183 2007-12-23 Marek Safar <marek.safar@gmail.com>
5185 A fix for bug #347189
5186 * class.cs (FixedField): Use non-dependent code only in the define phase.
5188 2007-12-23 Marek Safar <marek.safar@gmail.com>
5190 A fix for bug #348076
5191 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5193 2007-12-22 Marek Safar <marek.safar@gmail.com>
5195 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5196 discovered extension methods.
5198 2007-12-22 Marek Safar <marek.safar@gmail.com>
5200 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5203 2007-12-21 Miguel de Icaza <miguel@novell.com>
5205 * report.cs (ErrorMessage): Add support for using colors on
5206 terminals that support it.
5208 2007-12-21 Marek Safar <marek.safar@gmail.com>
5210 * ecore.cs: Use information about expanded params for error reporting.
5212 2007-12-21 Marek Safar <marek.safar@gmail.com>
5214 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5215 and logic for params overloads.
5217 2007-12-15 Miguel de Icaza <miguel@novell.com>
5219 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5220 as this is also created from the parser. Fixes #349034
5222 2007-12-12 Miguel de Icaza <miguel@novell.com>
5224 * statement.cs (Throw.CloneTo): it is valid to have empty
5225 expressions for throw.
5227 2007-12-03 Marek Safar <marek.safar@gmail.com>
5229 * cs-parser.jay: Set delegate constraint parsing region correctly.
5231 2007-12-03 Marek Safar <marek.safar@gmail.com>
5233 A fix for bug #345467
5234 * typemanager.cs (IsEqual): Compare generic parameters position only.
5236 2007-11-28 Marek Safar <marek.safar@gmail.com>
5238 * expression.cs (BaseAccess): Type arguments can be null.
5240 2007-11-27 Raja R Harinath <harinath@gmail.com>
5242 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5243 consistent even when an error has occured.
5244 (Switch.Resolve): Likewise.
5246 2007-11-22 Marek Safar <marek.safar@gmail.com>
5248 A fix for bug #334505
5249 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5252 2007-11-22 Marek Safar <marek.safar@gmail.com>
5254 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5255 refactorings required to resolve extension methods correctly when mixing
5256 generics and non-generics members.
5258 2007-11-20 Marek Safar <marek.safar@gmail.com>
5260 A fix for bug #342584
5261 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5264 2007-11-19 Marek Safar <marek.safar@gmail.com>
5266 A fix for bug #342512
5267 * delegate.cs: Use delegate argument expression when is available. Don't
5268 emit virtual call when class is sealed.
5270 2007-11-16 Marek Safar <marek.safar@gmail.com>
5272 A fix for bug #325423
5273 * assign.cs (FieldInitializer): Use resolved expression for emit.
5275 * class.cs: Print less confusing error message.
5277 2007-11-16 Marek Safar <marek.safar@gmail.com>
5279 * cs-tokenizer.cs: Removed GMCS ifdefs.
5281 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5284 * cs-parser.jay: Disabled nullable check.
5286 * generic-mcs: Copied more generic stuff.
5288 2007-11-16 Marek Safar <marek.safar@gmail.com>
5290 * gcs-parser.jay: Merged to cs-parser.jay.
5292 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5293 * *.csproj, *.sources: Updated to use only jay parser file.
5295 2007-11-16 Marek Safar <marek.safar@gmail.com>
5297 * gcs-parser.jay: Added nullable and default expression feature checks.
5299 2007-11-16 Marek Safar <marek.safar@gmail.com>
5301 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5302 it fixes many TODOs and hidden bugs.
5304 * expression: Removed duplicate error check.
5306 2007-11-15 Marek Safar <marek.safar@gmail.com>
5308 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5309 implicitly type local variable only when it is used in a declaration.
5311 2007-11-15 Marek Safar <marek.safar@gmail.com>
5313 * attribute.cs: Use CS0612 for empty strings.
5315 2007-11-14 Marek Safar <marek.safar@gmail.com>
5317 * lambda.cs, statement.cs: Contextual return may act as a statement.
5319 2007-11-14 Marek Safar <marek.safar@gmail.com>
5321 A fix for a regression cause by #324222
5322 * class.cs: Don't report unused even when it implements an interface.
5324 2007-11-13 Marek Safar <marek.safar@gmail.com>
5326 A fix for bug #341205
5327 * ecore.cs, expression.cs: Method group expression cannot do static
5328 method access with an instance reference check before overloading takes
5331 2007-11-13 Marek Safar <marek.safar@gmail.com>
5333 A fix for bug #325359
5334 * class.cs: Use predictable name for automatically generated property.
5336 2007-11-12 Marek Safar <marek.safar@gmail.com>
5338 A fix for bug #324996
5339 * expression.cs (Is): Handle case where D is nullable and T is not
5342 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5344 2007-11-12 Marek Safar <marek.safar@gmail.com>
5346 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5347 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5348 Flush small error reporting changes.
5350 2007-11-09 Marek Safar <marek.safar@gmail.com>
5352 A fix for bug #324996
5353 * expression.cs: Rewrote Is expression implementation to work with
5354 generics, nullable types, anonymous method. A const result expression
5355 uses existing infrastructure instead of custom not fully-featured one.
5357 2007-11-08 Marek Safar <marek.safar@gmail.com>
5359 A fix for bug #340202
5360 * class.cs: Consider generics for volatile field.
5362 2007-11-08 Marek Safar <marek.safar@gmail.com>
5364 A fix for bug #335594
5365 * expression.cs: Use conversion rules when handling string addition.
5367 2007-11-07 Marek Safar <marek.safar@gmail.com>
5369 A fix for bug #336651
5370 * expression.cs: Fixed a crash when probing is on.
5372 2007-11-07 Marek Safar <marek.safar@gmail.com>
5374 A fix for bug #324242
5375 * covert.cs: Added a conversion from any nullable-type with an
5376 underlying enum-type to the type System.Enum.
5378 2007-11-07 Marek Safar <marek.safar@gmail.com>
5380 A fix for bug #324222
5381 * class.cs: Report all non-used event fields.
5383 2007-11-07 Marek Safar <marek.safar@gmail.com>
5385 A fix for bug #325161
5386 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5387 qualifier for generic types.
5389 2007-11-07 Marek Safar <marek.safar@gmail.com>
5391 A fix for bug #322971
5392 * expression.cs, ecore.cs: Added intermediate result value check for
5395 2007-11-07 Marek Safar <marek.safar@gmail.com>
5397 A fix for bug #324754
5398 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5399 when it was requested.
5401 2007-11-07 Marek Safar <marek.safar@gmail.com>
5403 A fix for bug #325101
5404 * expression.cs: Do type not value comparison for `is' expression.
5406 2007-11-07 Marek Safar <marek.safar@gmail.com>
5408 A fix for bug #320236
5409 * convert.cs: Don't apply user conversion on underlying target type.
5411 2007-11-06 Marek Safar <marek.safar@gmail.com>
5413 * expression.cs: Don't use unresolved expression for error reporting.
5415 2007-11-06 Marek Safar <marek.safar@gmail.com>
5417 A fix for bugs #337712, #324490
5418 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5419 overloading resolution too.
5421 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5422 the process consistent and more robust.
5424 * expression.cs, linq.cs, report.cs: Update.
5426 2007-11-02 Marek Safar <marek.safar@gmail.com>
5428 A fix for bug #332909
5429 * attribute.cs: Resolve attributes in correct context using error
5432 * rootcontext.cs: Define Obsolete attribute members as core members.
5434 2007-11-02 Marek Safar <marek.safar@gmail.com>
5436 * statement.cs: Removed unused methods.
5438 2007-10-31 Wade Berrier <wberrier@novell.com>
5440 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5441 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5444 2007-10-31 Marek Safar <marek.safar@gmail.com>
5446 A fix for bug #338102
5447 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5448 methods registered as non-generics.
5450 2007-10-31 Marek Safar <marek.safar@gmail.com>
5452 A fix for bugs #337712, #324490
5453 * delegate.cs: Delegate covariance and contravariance is not allowed for
5456 2007-10-31 Marek Safar <marek.safar@gmail.com>
5458 A fix for bug #337719
5459 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5462 2007-10-30 Marek Safar <marek.safar@gmail.com>
5464 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5466 2007-10-29 Marek Safar <marek.safar@gmail.com>
5468 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5471 2007-10-29 Raja R Harinath <rharinath@novell.com>
5473 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5475 2007-10-29 Marek Safar <marek.safar@gmail.com>
5477 A fix for bug #334652
5478 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5479 extension methods when we have not found the best candidate in normal
5482 2007-10-27 Marek Safar <marek.safar@gmail.com>
5484 * AssemblyInfo.cs: Keep up-to-date.
5486 2007-10-27 Marek Safar <marek.safar@gmail.com>
5488 * Makefile: Fixed generics compiler name.
5490 2007-10-27 Marek Safar <marek.safar@gmail.com>
5492 * lambda.test: removed, lambda parsing is done differently.
5494 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
5496 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
5498 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
5500 2007-10-27 Marek Safar <marek.safar@gmail.com>
5502 * Makefile, *.sources : All C# compilers are in mcs folder.
5504 * *.cs: Use existing 2_1 define for smcs.
5506 2007-10-26 Marek Safar <marek.safar@gmail.com>
5508 A fix for bug #335847
5509 * assign.cs, expression.cs: Couple of changes to avoid creating a
5510 temporary variable for each object initializer assignment statement. It
5511 simplifies struct initialization too, otherwise two temporary variables
5513 Implemented optimization of redundant default element initializers.
5515 2007-10-25 Marek Safar <marek.safar@gmail.com>
5517 A fix for bug #336766
5518 * expression.cs (Class.CheckBase): Use generic name when method is
5521 2007-10-25 Marek Safar <marek.safar@gmail.com>
5523 A fix for bug #334737
5524 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
5525 variable and not variable argument for prepared copies.
5527 2007-10-24 Marek Safar <marek.safar@gmail.com>
5529 A fix for bug #325110
5530 * class.cs, expression.cs, attribute.cs: Use open generic method when
5531 checking conditional attribute.
5533 2007-10-24 Marek Safar <marek.safar@gmail.com>
5535 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
5536 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
5537 FeatureIsNotAvailable.
5539 2007-10-24 Marek Safar <marek.safar@gmail.com>
5541 ** C# 3.0 Partial methods
5543 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
5544 methods support. Because of member cache issue with generics only
5545 non-generics partial methods are fully supported.
5547 2007-10-23 Marek Safar <marek.safar@gmail.com>
5549 * class.cs, decl.cs: Rewrote member overloads check to cope with
5550 generics and to use member cache for member checking. It also improves
5551 performance and fixes remaining overloads issues.
5553 2007-10-20 Marek Safar <marek.safar@gmail.com>
5555 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
5556 roottypes.cs, typemanager.cs:
5558 A member cache creation logic changed to add members immediately and
5559 not rely on fallback. The member cache is now only prefered way
5560 how to access and find type declaration members. It saves 5 MB of memory
5561 during MWF compilation and makes code ready for more optimizations and
5562 clean-ups, it's also a pre-requirement for partial methods.
5564 2007-10-18 Raja R Harinath <harinath@gmail.com>
5566 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
5567 handling for generic parameters.
5569 2007-10-15 Marek Safar <marek.safar@gmail.com>
5571 * class.cs (FixedField): Removed redundant volatile check.
5573 2007-10-15 Marek Safar <marek.safar@gmail.com>
5575 * class.cs, decl.cs: Fixed overload members verification to do only one
5576 check per possible collision.
5578 2007-10-13 Marek Safar <marek.safar@gmail.com>
5580 A fix for bug #325478
5581 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
5582 and create only one disposable flags container.
5584 2007-10-12 Marek Safar <marek.safar@gmail.com>
5586 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
5587 * statement.cs (Fixed): Fixed variables cloning.
5589 2007-10-12 Marek Safar <marek.safar@gmail.com>
5591 A fix for bug #333342
5592 * class.cs (EventField): Don't mark value type event as synchronized.
5594 2007-10-12 Marek Safar <marek.safar@gmail.com>
5596 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
5597 inference to identify best candidate method correctly.
5598 (ProperyExpr): A range variable is read only and cannot be modified.
5600 2007-10-11 Marek Safar <marek.safar@gmail.com>
5602 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
5603 logic to identify best candidate method correctly.
5605 2007-10-11 Marek Safar <marek.safar@gmail.com>
5607 * location.cs (Equals, GetHashCode): Removed.
5609 2007-10-11 Marek Safar <marek.safar@gmail.com>
5611 * report.cs: Implemented message recorder. It is used mainly for lambda
5612 expressions to capture otherwise swallowed error messages.
5614 * anonymous.cs, lambda.cs.cs: Do full parameters check.
5616 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
5618 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
5620 * expression.cs (MemberAccess): Always report lookup failure.
5622 * location.cs: Implemented Equals, GetHashCode.
5624 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
5626 2007-10-10 Jb Evain <jbevain@novell.com>
5628 * codegen.cs: re-enable assembly version check.
5630 2007-10-09 Marek Safar <marek.safar@gmail.com>
5632 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
5635 * namespace.cs (UsingAlias): Do correct version check.
5637 2007-10-08 Marek Safar <marek.safar@gmail.com>
5639 * expresison.cs, ecore.cs: Issue extension method error message when
5642 * rootcontext.cs: Added ISO_2 compiler mode option.
5644 2007-10-08 Marek Safar <marek.safar@gmail.com>
5646 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
5649 2007-10-08 Marek Safar <marek.safar@gmail.com>
5651 * attribute.cs (GetString, GetBoolean): Work with both literal and
5654 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
5655 Moved method overload specific methods to MethodGroupExpr.
5657 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
5658 it should be less memory consuming.
5660 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
5662 * codegen.cs: remove the assembly version check until the buildbot is
5665 2007-10-07 Jb Evain <jbevain@novell.com>
5667 * attribute.cs (Attribute.GetString): if the value
5668 expression is a StringConstant, return its string value.
5670 2007-10-07 Jb Evain <jbevain@novell.com>
5672 * typemanager.cs: add `assembly_version_attribute_type`.
5673 * codegen.cs: on attribute emission, check that the
5674 AssemblyVersionAttribute doesn't overflow.
5676 2007-10-05 Marek Safar <marek.safar@gmail.com>
5678 A fix for bug #324677
5679 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
5680 parent container of a scope container with currently resolved one.
5682 2007-10-05 Marek Safar <marek.safar@gmail.com>
5684 A fix for bug #325534
5685 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
5688 2007-10-05 Marek Safar <marek.safar@gmail.com>
5690 A fix for bug #327504
5691 * class.cs (Operator.Define): Refactored implicit and explicit user
5692 operator conversion rules.
5694 2007-10-05 Marek Safar <marek.safar@gmail.com>
5696 A fix for bug #327520
5697 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
5699 2007-10-04 Marek Safar <marek.safar@gmail.com>
5701 A fix for bug #328022
5702 * class.cs (MethodData.Define): Use correct method to check whether
5703 a method implementents an accessor.
5705 2007-10-04 Marek Safar <marek.safar@gmail.com>
5707 A fix for bug #330069
5708 * statement.cs (Fixed.Resolve): Read the first array element only when
5709 an array is instantiated.
5711 2007-10-04 Marek Safar <marek.safar@gmail.com>
5713 * expression.cs, assign.cs, generics.cs: Print correct operator when
5714 compound assignment is used.
5716 2007-10-04 Marek Safar <marek.safar@gmail.com>
5718 A fix for bug #325841
5719 * expression.cs (ArrayAccess): Use full argument cloning only for
5720 string compound concatenation.
5722 2007-10-03 Marek Safar <marek.safar@gmail.com>
5724 A fix for bug #328774
5725 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
5727 (PropertyExpr.EmitAssign): Fixed string concatenation compound
5730 2007-10-03 Raja R Harinath <rharinath@novell.com>
5733 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
5734 Event accessibility checks here. Remove some bogus code that
5735 accidently made GenericMethods work.
5736 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
5738 2007-09-25 Marek Safar <marek.safar@gmail.com>
5740 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
5742 * statement.cs (Block): Refactored AddVariable to allow error handling
5745 * generic.cs: New stub.
5747 2007-09-23 Marek Safar <marek.safar@gmail.com>
5749 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
5752 2007-09-17 Marek Safar <marek.safar@gmail.com>
5754 * class.cs: Use partial container to record whether any partial part
5755 contains static field initializer and therefore default contructor has
5758 2007-09-14 Marek Safar <marek.safar@gmail.com>
5760 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
5761 mono-list when only one of two partial parts has defined accessibility
5764 2007-09-14 Marek Safar <marek.safar@gmail.com>
5766 A fix for bug #82845
5768 * class.cs (TypeContainer): Set correct resolve context for all field
5771 2007-09-13 Marek Safar <marek.safar@gmail.com>
5773 * assign.cs: Fixed a crash when field is resolved twice with an error.
5775 * codegen.cs: Changed InFieldInitializer to be flag.
5777 * anonymous.cs, ecore.cs, expression.cs: Update after
5778 IsInFieldInitializer rename.
5780 * const.cs: Removed unused parameter.
5782 * class.cs: Changed the way how we resolve and emit field initializers.
5783 The field initilizers have to have access to contructor block to emit
5784 compiler generated code.
5786 2007-09-13 Marek Safar <marek.safar@gmail.com>
5788 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
5789 generics use TypeContainer instead.
5791 2007-09-12 Marek Safar <marek.safar@gmail.com>
5793 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
5795 * lambda.cs (ResolveParameters): Use more powerful
5796 InflateGenericArgument.
5798 * parameters.cs: Better exception message.
5800 2007-09-10 Marek Safar <marek.safar@gmail.com>
5802 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
5803 correct expression block type.
5805 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
5807 * expression.cs (Invocation): Extracted method group resolve to
5810 2007-09-07 Marek Safar <marek.safar@gmail.com>
5812 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
5813 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
5815 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
5816 generic extension methods.
5818 2007-09-06 Marek Safar <marek.safar@gmail.com>
5820 A fix for bug #82676 (Do I get it right now?)
5821 * convert.cs (Binary.ResolveOperator): An interface is converted to the
5822 object before a standard conversion is applied.
5824 2007-09-06 Marek Safar <marek.safar@gmail.com>
5826 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
5829 2007-09-05 Marek Safar <marek.safar@gmail.com>
5831 A fix for bug #82676
5832 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
5833 non-generic interface types.
5835 2007-09-05 Marek Safar <marek.safar@gmail.com>
5837 A fix for bug #82690
5838 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
5840 2007-09-05 Marek Safar <marek.safar@gmail.com>
5842 A fix for bug #82571
5843 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
5844 modifier for container based methods.
5846 2007-09-05 Marek Safar <marek.safar@gmail.com>
5848 A fix for bug #82676
5849 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
5850 any interface-type T means to any of interface type T.
5852 2007-09-04 Marek Safar <marek.safar@gmail.com>
5854 * namespace.cs: We have 2 versions of System.Core assembly.
5856 2007-09-04 Marek Safar <marek.safar@gmail.com>
5858 A fix for bug #82652
5859 * class.cs (Class.GetClassBases): Compare types and not expressions.
5861 2007-09-04 Marek Safar <marek.safar@gmail.com>
5863 A fix for bug #82620
5864 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
5865 actually never worked before.
5866 (IndexerAccess): Emit prepared arguments before they are modified.
5868 2007-09-04 Marek Safar <marek.safar@gmail.com>
5870 A fix for bug #82563
5871 * assign.cs: Revert wrong fix.
5873 * expression.cs (VariableReference.EmitAssign): Handle ref reference
5875 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
5876 Instead of ldelema/stdind we have to use temporary variables to handle
5877 cases like String.Concat (params string[]).
5879 2007-08-31 Marek Safar <marek.safar@gmail.com>
5881 * class.cs: EmitAttributes to Emit rename.
5883 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
5885 (MemberCore.HasClsCompliantAttribute): Don't depend on
5886 GetClsCompliantAttributeValue execution.
5888 2007-08-31 Marek Safar <marek.safar@gmail.com>
5890 * anonymous.cs: Use shorter type prefix.
5892 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
5895 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
5896 variables when probing is on.
5898 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
5899 unresolved variables.
5900 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
5901 handle transparent identifiers.
5903 2007-08-26 Marek Safar <marek.safar@gmail.com>
5905 * attribute.cs (IsClsCompliant): Add nullable types test.
5907 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
5909 * doc.cs : catch other types of exception than XmlException to
5910 report CS1570. Fixed bug #82565.
5912 2007-08-23 Marek Safar <marek.safar@gmail.com>
5914 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
5915 The number of delegate parameters has to match.
5916 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
5919 2007-08-21 Marek Safar <marek.safar@gmail.com>
5921 * anonymous.cs (AnonymousMethod): Generate private anonymous method
5922 to fix problem with private arguments.
5924 2007-08-20 Marek Safar <marek.safar@gmail.com>
5926 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
5928 * decl.cs (MemberName): Ignore generic type with no generic arguments.
5930 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
5931 empty. Add cloning suport.
5933 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
5935 2007-08-20 Marek Safar <marek.safar@gmail.com>
5937 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
5938 to create EmptyCast. It handles EmptyConstantCast specialization for
5941 2007-08-18 Marek Safar <marek.safar@gmail.com>
5943 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
5944 (EmitArrayArgument): One routine for array arguments.
5945 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
5947 2007-08-17 Marek Safar <marek.safar@gmail.com>
5949 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
5951 2007-08-17 Marek Safar <marek.safar@gmail.com>
5953 * anonymous.cs: MemberLookupFinal update.
5955 * class.cs (ConstructorInitializer): Is expression based.
5957 * delegate.cs: MethodGroupExpr update.
5959 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
5961 (Error_MemberLookupFailed): Customizable error override.
5962 (MethodGroupExpr): Keep queried type for later usage.
5963 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
5966 * expression.cs: Error_MemberLookupFailed refactoring.
5967 (New.DoResolve): Resolve as much as possible.
5968 (ElementInitializer.Error_MemberLookupFailed): Object initializer
5969 customization for invalid member types.
5971 * statement.cs: MethodGroupExpr update.
5973 2007-08-16 Marek Safar <marek.safar@gmail.com>
5975 * modifier.cs (Check): Check all modifiers and not only accessibility
5978 2007-08-16 Marek Safar <marek.safar@gmail.com>
5980 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
5981 type and not an expression.
5983 2007-08-16 Marek Safar <marek.safar@gmail.com>
5985 * statement.cs (Catch.Clone): Type and variable can be null.
5987 2007-08-16 Marek Safar <marek.safar@gmail.com>
5989 A fix for bug #81979
5990 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
5991 I am really not sure whether this is the best fix.
5993 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
5996 2007-08-14 Marek Safar <marek.safar@gmail.com>
5998 ** C# 3.0 Object and collection initializers (major re-write)
6000 * assign.cs (DoResolve): Initializers are not assign related.
6002 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6003 used during collection or object initialization.
6005 * expression.cs (Error_InvalidArguments): Add initializers specific
6006 messages. More will come later because it requires some general
6008 (New.DoResolve): Better error handling for unsafe types.
6009 (EmptyExpressionStatement): New class.
6010 (ElementInitializer): An object initializer expression.
6011 (CollectionElementInitializer): A collection initializer expression.
6012 (CollectionOrObjectInitializers): A block of object or collection
6014 (NewInitialize): New expression with element/object initializers.
6016 * statement.cs: Reverted object/collection initializer hacks.
6018 * typemanager.cs (CSharpName): Filter __arglist type.
6020 2007-08-09 Marek Safar <marek.safar@gmail.com>
6022 ** C# 3.0 Anonymous Types (update to the latest standard)
6024 * expression.cs (Binary.ResolveOperator): Threat all null based types
6026 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6027 (AnonymousTypeParameter): Updated.
6029 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6030 (AnonymousTypeClass): New anonymous type container.
6032 * class.cs (AddField): Return operation result.
6034 * generic.cs: Another empty TypeArguments overload.
6036 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6037 are stored at top of normal hierarchy.
6039 * typemanager.cs (CSharpName): Filter anonymous types.
6041 2007-08-09 Marek Safar <marek.safar@gmail.com>
6043 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6044 as single Concat call. How could we miss that :-(
6046 2007-08-08 Marek Safar <marek.safar@gmail.com>
6048 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6050 2007-08-07 Miguel de Icaza <miguel@novell.com>
6052 * expression.cs: Fix the previous commit, the creation of the
6053 arguments array list needs also to be conditional on the arguments
6056 * class.cs: Add a little bit of help to help narrow down problems.
6058 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6059 not try to copy in that case.
6061 * driver.cs: When building SMCS, include a new different set of
6062 default assemblies here. Do this here so we can control whether
6063 to include the default assemblies with /noconfig.
6065 2007-08-03 Marek Safar <marek.safar@gmail.com>
6067 A fix for bug #81979
6068 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6071 2007-08-03 Marek Safar <marek.safar@gmail.com>
6073 A fix for bug #82300
6075 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6076 we are in probing scope.
6078 2007-08-03 Marek Safar <marek.safar@gmail.com>
6080 A fix for bug #82301
6082 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6083 (Statement.CloneTo): Clone and not map children blocks.
6085 2007-08-03 Marek Safar <marek.safar@gmail.com>
6087 A fix for bug #82299
6089 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6092 * statement.cs (Statement.CloneTo): Clone variables before statements
6093 to allow remaping of local variables.
6095 2007-08-03 Marek Safar <marek.safar@gmail.com>
6097 A fix for bug #82296
6100 * report.cs: Log crash details for future clone problems.
6102 * statement.cs (Return.Clone): Don't clone non-existent expression.
6104 2007-08-03 Raja R Harinath <harinath@gmail.com>
6106 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6107 (Class.AddBasesForPart): Move CS0537 check here from ...
6108 * cs-parser.jay (class_declaration): ... here. Move calling of
6109 'AddBasesForPart' to ...
6110 (class_bases): ... here.
6111 (struct_declaration, interface_declaration): Update to changes.
6113 2007-08-02 Marek Safar <marek.safar@gmail.com>
6115 A fix for bug #81923
6117 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6118 conversion is allowed.
6120 2007-08-02 Marek Safar <marek.safar@gmail.com>
6122 A fix for bug #81564
6124 * ecore.cs (EventExpr): Add IsBase handling.
6126 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6129 2007-08-02 Raja R Harinath <harinath@gmail.com>
6131 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6132 * cs-parser.jay: Some whitespace cleanups.
6133 (current_delegate): New.
6135 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6136 a dummy code block, and use 'type_name' instead of 'member_name'.
6137 (interface_declaration, class_declaration): Likewise.
6138 (delegate_declaration): Likewise. Rearrange slightly and use
6140 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6141 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6143 2007-08-02 Marek Safar <marek.safar@gmail.com>
6145 A fix for bug #82039
6147 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6150 * typemanager.cs (CSharpName): Split to string overload.
6152 2007-08-02 Marek Safar <marek.safar@gmail.com>
6155 * report.cs: Updated warning CS0472.
6157 2007-08-01 Marek Safar <marek.safar@gmail.com>
6159 A fix for bug #82181
6161 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6163 2007-08-01 Marek Safar <marek.safar@gmail.com>
6165 A fix for bug #82277
6166 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6168 2007-08-01 Marek Safar <marek.safar@gmail.com>
6170 ** C# 3.0 Type Inference (major bits are working)
6172 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6173 (.ImplicitStandardConversionExists): Uses compatible.
6174 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6175 (.InferReturnType): New method.
6176 (.Compatible): Refactored.
6177 (.ResolveParameters): Uses factory to create resolved parameters.
6178 (.CompatibleMethod): Add probing mode support.
6179 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6180 clearly distinguish between 2 different operations.
6181 (LambdaMethod): Moved to lambda.cs.
6182 (AnonymousMethod): Removed unused fields and methods.
6183 (AnonymousDelegate): Simplified.
6185 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6187 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6189 * delegate.cs (Delegate): New mehods to reduce code duplication.
6190 (.GetConstructor): New method.
6191 (.GetInvokeMethod): New method.
6192 (DelegateCreation): Updated.
6194 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6196 (OverloadResolve): Made probing little bit faster.
6198 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6201 * generic.cs (TypeInferenceContext): Dummy implementation.
6203 * iterators.cs: Updated after Resolve/Define rename.
6205 * lambda.cs (LambdaExpression)
6206 (.ResolveParameters): Handles both type of arguments and type inference too.
6208 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6209 (InflateTypes): Updated.
6211 * support.cs (InflateTypes): Changed signature and updated.
6213 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6214 (MemberLookup_FindMembers): More MS tricks.
6215 (GetParameterData): Ditto.
6216 (GetDelegateParameters): Uses quick path for dynamic types.
6218 2007-08-01 Marek Safar <marek.safar@gmail.com>
6220 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6223 2007-07-31 Marek Safar <marek.safar@gmail.com>
6225 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6228 2007-07-26 Jb Evain <jbevain@novell.com>
6230 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6231 which takes a boolean 'report_errors', similar to the GetMethod.
6232 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6233 in .net 2.1, do not report errors here.
6235 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6236 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6237 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6240 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6241 of the type InternalsVisibleToAttribute before the first call
6242 to CoreLookupType which is allowed to fail (third boolean parameter
6243 to true). Because, during the resolution for a type that is not
6244 immediately found, we try to check if the type is not defined in
6245 a friend assembly, and to do so, we need the
6246 InternalVisibleToAttribute.
6248 2007-07-23 Miguel de Icaza <miguel@novell.com>
6250 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6251 feature that allows structs to be compared against null and inline
6252 the result as true or false.
6254 Notice that the same code is not permitted inside a generic block
6255 of code that would do:
6257 class Foo<T> where T : struct {
6264 It is only allowed if the type of T is not bound (no where
6265 clause). In my opinion, this CSC 2 behavior is broken but people
6266 seem to be using it (IronRuby does, a few bug reports on bugzilla
6267 have it and some people have complained about it).
6269 All of the users that depend on this behavior have code that is
6272 * report.cs (Warning, Error): make these take object arguments,
6273 not strings, as that allows us to take advantage of Format.
6275 2007-07-20 William Holmes <billholmes54@gmail.com>
6277 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6278 Left member variable for the Count.
6279 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6280 MemberName.CountTypeArguments to avoid a NRE.
6282 This code is contributed under the MIT X11 license
6284 2007-07-18 Marek Safar <marek.safar@gmail.com>
6286 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6288 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6290 * doc.cs : generic method arguments are written as ``x while generic
6291 type arguments are `x. Combined with the previous change, fixed bug
6294 2007-07-18 Raja R Harinath <rharinath@novell.com>
6297 * expression.cs (Binary.ResolveOperator): When converting
6298 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6300 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6302 * doc.cs : when T: or whatever x: is specified, it does not really
6303 check the doc comment's syntax correctness. Fixed bug #82006.
6305 2007-07-18 Marek Safar <marek.safar@gmail.com>
6307 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6308 LambdaExpression better.
6310 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6312 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6314 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6315 as it can be generated.
6317 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6320 * lambda.cs (LambdaExpression): Refactored to share same code with
6321 AnonymousMethodExpression.
6323 2007-07-17 Marek Safar <marek.safar@gmail.com>
6325 * anonymous.cs (MakeName): Include host name for easier debugging.
6326 (LambdaMethod): New class for lambda spcecific stuff.
6328 * attribute.cs: Set EmitContext return type.
6330 * class.cs: Set EmitContext return type.
6332 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6333 with null/void meaning.
6335 * iterators.cs (ContainerType): Implemented.
6337 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6339 * statement.cs (Return): Updated to lambda expressions.
6340 (Block.CloneTo): Parent can be null.
6342 2007-07-13 Marek Safar <marek.safar@gmail.com>
6344 A fix for bug #81917
6345 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6347 * class.cs (FixedField): Check whether field is in unsafe scope.
6349 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6350 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6352 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6355 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6357 2007-07-13 Marek Safar <marek.safar@gmail.com>
6359 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6360 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6363 2007-07-13 Marek Safar <marek.safar@gmail.com>
6365 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6367 2007-07-13 Marek Safar <marek.safar@gmail.com>
6369 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6370 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6372 * codegen.cs(EmitContext): Add ProbingMode flag.
6374 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6376 * driver.cs: For now set both warning values.
6378 * ecore.cs (SimpleName): Name is readonly.
6379 (MethodGroup.OverloadResolve): One quick path for probing.
6381 * expression.cs (Unary): Set Oper r/o.
6382 (Binary): Set Oper r/o.
6383 (ParameterReference): Set few instance variables as r/o.
6384 (ParameterReference.DoResolveBase): Don't capture aruments when
6386 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6387 (Arglist): arguments are private.
6388 (SizeOf): type is private and r/o.
6389 (MemberAccess): arguments are private.
6391 * report.cs: Enhanced reporting on/off capabilities.
6393 * lambda.cs: Uses ec.IsInProbingMode.
6394 (ContextualReturn): Derives from return.
6396 * rootcontext.cs: For now set both warning values.
6398 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6400 (Return.Resolve): Don't die immediately.
6401 (Block.Resolve): Speed-up probing.
6402 (Block.CloneTo): Clone only child blocks.
6404 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6406 * iterators.cs: reverted Miguel's latest change (r81925) as it
6407 breaks the build in System.
6409 2007-07-13 Miguel de Icaza <miguel@novell.com>
6411 * iterators.cs (Yield.CheckContext): Check for the iterator type
6412 also here as we can call into Yield even in codepaths that are not
6414 (MethodOrOperator is the only path that was checked).
6416 In addition to the standard check, use a more specific check for
6417 constructors to report a more verbose error.
6419 2007-07-12 Miguel de Icaza <miguel@novell.com>
6421 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6422 report the warning and continue
6424 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6425 values on the stack on the call to Emit. Use EmitStatement if
6426 possible, or using Emit + Pop if not possible. Fixes #82064
6428 2007-07-12 Raja R Harinath <rharinath@novell.com>
6430 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6431 avoid try...finally in some cases.
6433 2007-07-10 Marek Safar <marek.safar@gmail.com>
6435 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6437 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6438 instead of method. Re-use standard error handling.
6439 (ConstructorInitializer.Emit): Simplified.
6441 * delegate.cs: Updated after Invocation.EmitCall change.
6443 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6444 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6445 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6446 method and don't permanently changing input arguments.
6447 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6448 is resolved it has one of the candidates is the best one which is later
6449 used to emit. Removed a few unused method.
6450 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6452 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6453 (Binary.ResolveOperator): Ditto.
6454 (ConditionalLogicalOperator.DoResolve): Ditto.
6455 (Invocation): Uses method group.
6456 (Invocation.DoResolve): Simplified.
6457 (Invocation.EmitCall): Removed useless is_static.
6458 (Invocation.Emit): Delegate to method group.
6459 (Invocation.EmitStatement): Simplified.
6460 (New): Uses method group.
6461 (MemberAccess.DoResolve): Don't destroy original expression.
6463 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6465 2007-07-04 Marek Safar <marek.safar@gmail.com>
6467 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6470 * lambda.cs: Add custom error message type.
6472 2007-07-03 Marek Safar <marek.safar@gmail.com>
6474 * lambda.cs: Simplified little bit.
6476 * parameter.cs: Introduced ImplicitLambdaParameter.
6477 (Parameters.CreateFullyResolved): New factory instead of ctor.
6481 * delegate.cs: Updated parameter creation.
6483 2007-07-03 Marek Safar <marek.safar@gmail.com>
6485 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6488 * generic.cs: Synchronized with gmcs.
6490 2007-07-03 Marek Safar <marek.safar@gmail.com>
6492 * class.cs (Indexer): Check return type as soon as possible.
6494 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6497 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
6499 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
6501 * parameter.cs (Parameter): Use expression type when it is available.
6503 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
6504 method modifier for the first parameter only.
6506 2007-06-24 Marek Safar <marek.safar@gmail.com>
6508 A fix for bug #81938
6509 * typemanager.cs (ChangeType): Fixed couple of char conversions.
6511 * constant.cs: Tide up an exception message.
6513 2007-06-22 Marek Safar <marek.safar@gmail.com>
6515 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
6516 an uninitialized variable is used.
6518 * expression.cs (LocalVariableReference.DoResolve): Ditto.
6520 2007-06-22 Marek Safar <marek.safar@gmail.com>
6522 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
6523 not found error handling.
6525 * expression.cs (ArrayCreation): Removed redundant fields and little bit
6527 (ArrayCreation.ResolveArrayElement): To be ready to customization.
6528 (ArrayCreation.DoResolve): Simplified.
6529 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
6530 its own resolve process.
6531 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
6533 2007-06-20 Marek Safar <marek.safar@gmail.com>
6535 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
6538 2007-06-20 Marek Safar <marek.safar@gmail.com>
6540 * cs-tokenizer.cs: Removed var related stuff.
6542 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
6543 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
6544 a type and a keyword at same time.
6546 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
6549 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
6550 implicitly typed arrays, more changes will follow.
6552 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
6554 2007-06-19 Marek Safar <marek.safar@gmail.com>
6556 * ecore.cs (VarExpr): Removed Handled field.
6558 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
6559 build-in assign functionality.
6560 (ForEach.Resolve): Removed all implicitly typed local variable code and
6562 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
6563 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
6565 2007-06-18 Marek Safar <marek.safar@gmail.com>
6567 * assign.cs: Removed implicitly typed local variable check.
6569 * expression.cs (LocalVariableReference.DoResolve): Add check for self
6570 referencing implicitly typed local variable.
6571 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
6574 * statement.cs (Fixed): Removed unsupported implicitly typed local
6577 2007-06-15 Marek Safar <marek.safar@gmail.com>
6579 * decl.cs (MemberName): Moved all Unbound stuff to parser.
6581 2007-06-14 Marek Safar <marek.safar@gmail.com>
6583 A fix for bugs #81855 and #76274
6584 * attribute.cs (AttachTo): Always set owner for global attributes to
6587 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
6590 * cs-parser.jay: Assembly and module attributes must precede all other
6591 elements except using clauses and extern alias declarations.
6593 2007-06-13 Marek Safar <marek.safar@gmail.com>
6595 A fix for bug #81748
6597 * expression.cs: More checks for non ISO-1 features.
6599 2007-06-12 Marek Safar <marek.safar@gmail.com>
6601 A fix for bug #81807
6602 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
6603 present inside switch statement and it is required by nullable check.
6605 2007-06-12 Marek Safar <marek.safar@gmail.com>
6607 A fix for bug #81840
6608 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
6609 when type matching fails.
6611 * namespace.cs: Tiny error message change.
6613 2007-06-12 Marek Safar <marek.safar@gmail.com>
6615 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
6616 reporting. Added automatic property check.
6618 * class.cs: Updated after CheckAbstractAndExtern relocation.
6619 (AEventPropertyAccessor.GetSignatureForError): Customized.
6621 2007-06-11 Marek Safar <marek.safar@gmail.com>
6623 * class.cs (DefineBaseTypes): Base type can be undefined.
6625 * ecore.cs (TypeLookup): Minor refactoring.
6626 (DoResolveAsTypeStep): Removed redundant check.
6628 * namespace.cs (Lookup): Removed redundant check.
6630 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
6631 ResolveAsTypeTerminal step.
6632 (BootstrapCorlib_*): Simplified.
6633 (PopulateCoreType): Core types can be now external.
6635 2007-06-07 Marek Safar <marek.safar@gmail.com>
6637 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
6639 (InferTypeArguments): Infers anonymous expression type arguments.
6640 (Compatible): Split to Compatible and InferTypeArguments.
6642 * lambda.cs: Updated.
6644 2007-06-08 Marek Safar <marek.safar@gmail.com>
6646 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
6648 2007-06-07 Raja R Harinath <harinath@gmail.com>
6650 Fix #80477, cs0135-2.cs, cs0135-3.cs
6651 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
6652 names to the "known" variables list.
6653 (Block.CheckInvariantMeaningInBlock): Handle the fact the
6654 parameter names are also "known".
6655 (Block.CheckError136): Remove.
6656 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
6659 2007-06-07 Marek Safar <marek.safar@gmail.com>
6661 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
6663 2007-06-06 Marek Safar <marek.safar@gmail.com>
6665 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
6666 internal error not an user error.
6668 * expression.cs (IsApplicable): Refactored to make debugging easier.
6670 * support.cs: More tricks for non-mono runtimes.
6672 * typemanager.cs (CoreLookupType): Made public.
6673 (InitSystemCore): All linq specific stuff moved to linq.cs
6675 2007-06-05 Marek Safar <marek.safar@gmail.com>
6677 * typemanager.cs (CSharpSignature): One more missing build-in types
6679 More tricks for non-mono runtime.
6681 2007-06-05 Raja R Harinath <harinath@gmail.com>
6683 * statement.cs (Block.CheckError136_InParents): Remove.
6684 (Block.AddVariable): Use GetParameterInfo instead.
6685 (ToplevelBlock.ProcessArguments): Likewise.
6687 2007-06-04 Raja R Harinath <rharinath@novell.com>
6689 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
6691 (ToplevelBlock.GetParameterInfo): Split out of ...
6692 (ToplevelBlock.GetParameterRefernce): ... this.
6693 (ToplevelBlock.ParameterMap): Remove.
6694 * expression.cs (ParameterReference): Update to use
6695 ToplevelParameterInfo.
6697 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
6700 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
6701 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
6703 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
6704 (ToplevelBlock.ProcessParameters) ... here.
6705 (ToplevelBlock..ctor): Invoke it.
6707 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
6710 * statement.cs (IKnownVariable): New interface.
6711 (LocalInfo): Implement it.
6712 (ToplevelParameterInfo): New class.
6713 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
6714 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
6715 GetKnownVariableInfo.
6717 2007-06-03 Raja R Harinath <harinath@gmail.com>
6719 Partly speed up CS0136 error checks.
6720 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
6721 'recurse' parameter.
6722 (Block.DoCheckError136): Only check errors in parameters. Move
6723 local variable checks ...
6724 (Block.AddVariable): ... here, and ...
6725 (ToplevelBlock.ResolveMeta): ... here.
6727 2007-06-02 Raja R Harinath <harinath@gmail.com>
6729 * statement.cs (Block.IsChildOf): Remove.
6731 * statement.cs (Statement.Clone): Move special case code ...
6732 (Block.CloneTo): ... here.
6734 2007-05-29 Raja R Harinath <rharinath@novell.com>
6736 * statement.cs (ToplevelBlock.container): Remove field. It's
6737 redundant with 'Parent'.
6738 (ToplevelBlock.ContainerBlock): Remove accessor.
6739 (ToplevelBlock..ctor): Update to changes. Register anonymous
6740 child with parent here, ...
6741 * cs-parser.jay (end_anonymous): ... not here. Don't modify
6743 (start_anonymous): Don't save current_block.
6744 (top_current_block): Remove.
6746 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
6747 (Block.Resolve): Update to changes.
6748 (Block..ctor): Move setting of "correct" 'Toplevel'
6749 and 'Explicit' fields to ...
6750 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
6752 2007-05-27 Raja R Harinath <harinath@gmail.com>
6755 * statement.cs (Block.Implicit): Remove.
6756 (Block): Update to changes.
6757 * flowanalysis.cs: Likewise.
6759 Mildly speed up CheckInvariantMeaningInBlock
6760 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
6761 Recursively call AddKnownVariable to all enclosing blocks.
6762 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
6763 Remove recursive calls.
6764 (Block): Update to changes.
6766 New ExplicitBlock invariants
6767 * statement.cs (Block.Explicit): New field. It points to the
6768 immediately enclosing non-implicit block.
6769 (Block..ctor): Maintain the invariant.
6770 * cs-parser.jay: Take advantage of invariant.
6772 Introduce ExplicitBlock
6773 * statement.cs (ExplicitBlock): New.
6774 (ToplevelBlock): Derive from it.
6775 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
6777 (Block.Implicit): Update to changes.
6778 * cs-parser.jay: Update to changes.
6781 * codegen.cs (EmitContext.IsLastStatement): Remove.
6782 * statement.cs (Block.DoEmit): Update to changes.
6784 2007-05-25 Raja R Harinath <rharinath@novell.com>
6786 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
6787 modifying current_block directly.
6789 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
6791 * class.cs: Implemented automatic properties (C# 3.0)
6792 Thanks to Marek for the help.
6794 2007-05-23 Raja R Harinath <rharinath@novell.com>
6796 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
6797 variable as assigned, note also that all its components are
6799 (MyBitVector.SetRange): New. Function to set multiple bits to true.
6801 2007-05-19 Marek Safar <marek.safar@gmail.com>
6803 * anonymous.cs, class.cs: Emit Compiler generated attribute when
6804 member is marked as compiler generated.
6806 * decl.cs (MemberCore): Refactored ModFlags into property.
6808 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
6809 (Check): Check only accessibility modifiers.
6811 2007-05-18 Raja R Harinath <rharinath@novell.com>
6813 Track all assignable slots in one bit array
6814 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
6815 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
6816 logic from VariableMap constructor here. Use the same 'offset'
6817 variable that's later used for computing offsets of local
6819 * flowanalysis.cs (UsageVector.parameters): Remove.
6820 (UsageVector): Update to changes.
6821 (VariableMap): Remove.
6823 Avoid creating ParameterMap in every block
6824 * statement.cs (Block.ParameterMap): Move ...
6825 (ToplevelBlock.ParameterMap): ... here.
6826 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
6828 * flowanalysis.cs (FlowBranching.param_map): Remove.
6829 (FlowBranching.UsageVector): Update to changes.
6830 (FlowBranchingToplevel.CheckOutParameters): Likewise.
6832 * statement.cs (Block.CloneTo): Clone Toplevel field too.
6834 * expression.cs (ParameterReference): Distinguish between block
6835 where parameter was referenced and declared.
6837 2007-05-18 Marek Safar <marek.safar@gmail.com>
6839 * flowanalysis.cs, statement.cs: Put back improved error handling.
6841 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
6845 Imporved object and collection initialization (C# 3.0).
6847 2007-05-15 Marek Safar <marek.safar@gmail.com>
6849 A fix for bug #81380
6850 * expression.cs (Is.DoResolve): Only value types have constant `is'
6853 2007-05-15 Raja R Harinath <rharinath@novell.com>
6855 * statement.cs (ToplevelBlock.child): Remove.
6857 2007-05-15 Raja R Harinath <harinath@gmail.com>
6859 Rationalize ResolveMeta: refactoring
6860 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
6861 out constant handling code into ...
6862 (Block.DoResolveConstants): ... this.
6864 Rationalize ResolveMeta: kill local_map
6865 * statement.cs (Block.local_map, Block.LocalMap): Remove.
6866 (Block.AssignableSlots): New.
6867 (Block.ResolveMeta): Make protected. Don't create a VariableMap
6868 for locals -- move code from VariableMap here. Avoid unnecessary
6870 * flowanalysis.cs (FlowBranching.local_map): Remove.
6871 (FlowBranching..ctor): Use Block.AssignableSlots.
6872 (VariableMap): Remove unused constructors.
6874 2007-05-11 Raja R Harinath <rharinath@novell.com>
6876 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
6878 2007-05-11 Marek Safar <marek.safar@gmail.com>
6880 * typemanager.cs (IsFriendAssembly): Should not be called for building
6883 2007-05-09 Marek Safar <marek.safar@gmail.com>
6885 * literal.cs (NullConstant): Print null in all cases.
6887 * expression.cs (Binary.ResolveOperator): Implemented delegate
6888 comparison based on C# 2.0 changes.
6890 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
6892 This code is contributed under the MIT X11 license
6894 The following enables support for several C# 3.0 language features:
6896 * cs-tokenizer.cs: Added support for the "var" keyword.
6898 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
6899 Added VarExpr class to facilitate type inferencing.
6901 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
6902 to support anonymous types.
6904 * assign.cs: Added support for type inferencing and initialization.
6906 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
6908 * expression.cs: Added implicit array support to ArrayCreation.
6909 Added 5 types and 1 interface:
6911 IInitializable Implementing classes can inject initializing
6912 statements after object instantiation.
6914 Initializer Stores data for object initialization.
6916 AnonymousType An expression for anonymous types.
6918 AnonymousTypeParameter Stores data about an anonymous type's field.
6920 NewInitialize An expression for object initialization.
6922 CollectionInitialize An expression for collection initialization.
6924 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
6927 2007-05-06 Marek Safar <marek.safar@gmail.com>
6929 A fix for bug #81500
6930 * cs-tokenizer.cs: Add special handling for coalescing operator.
6932 2007-05-06 Marek Safar <marek.safar@gmail.com>
6934 A fix for bug #81529
6935 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
6936 its value from base class until it is redefined.
6938 2007-05-02 Raja R Harinath <rharinath@novell.com>
6940 Fix regression in cs0631-3.cs
6941 * cs-parser.jay (operator_declarator): Add opt_attributes to error
6942 fallback. Make error fallback catch more cases.
6944 2007-05-01 Miguel de Icaza <miguel@novell.com>
6946 * cs-parser.jay: Allow parameters in operator declarations to have
6949 2007-04-27 Miguel de Icaza <miguel@novell.com>
6951 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
6954 * lambda.cs (ContextualReturn.Resolve): An expression is valid
6955 inside the ContextualReturn, it does not have to be an
6956 ExpressionStatement.
6958 2007-04-24 Miguel de Icaza <miguel@novell.com>
6960 * lambda.cs (ContextualReturn.Resolve): if the return type is not
6963 2007-04-23 Miguel de Icaza <miguel@novell.com>
6965 * anonymous.cs (AnonymousContainer): split the virtual Resolve
6966 method in two methods: ResolveNoDefine and Resolve.
6968 ResolveNoDefine will stop just after ResolveTopBlock has been
6971 Resolve will then continue by creating a method and issuing the
6972 call to method.Define ().
6974 (AnonymousMethod): Split and implement the new Resolve and
6975 ResolveNoDefine as well.
6977 * lambda.cs (LambdaExpression): Split the anonymous method
6978 resolution code into a separate routine (CoreCompatibilityTest)
6979 from DoCompatibleTest.
6981 (LambdaExpression.TryBuild): New method, this method tries to
6982 build the LambdaExpression with the given set of types to be used
6983 as the types for the various parameters of the lambda expression.
6985 If the compilation succeed with the given types, the infered type
6986 of the Anonymous method is returned, otherwise null is returned.
6988 2007-04-23 Marek Safar <marek.safar@gmail.com>
6990 A fix for bug #81414
6991 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
6993 2007-04-22 Miguel de Icaza <miguel@novell.com>
6995 * cs-tokenizer.cs: Change various identifiers here from the
6996 camelCasing to the recommended Linux-like style for instance
6997 variables from the Coding Guidelines.
6999 2007-04-19 Martin Baulig <martin@ximian.com>
7002 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7003 System.Enum to System.ValueType.
7005 2007-04-13 Martin Baulig <martin@ximian.com>
7007 Rewrote implicit reference conversions. We need to distinguish
7008 between implicit reference conversions (13.1.4) and implicit
7009 boxing conversions (13.1.5).
7011 According to the spec, there's an an implicit conversion
7012 "From a one-dimensional array-type S[] to IList<T> and base
7013 interfaces of this interface, provided there is an implicit
7014 reference conversion from S to T." Note that this does not
7015 include boxing conversions.
7018 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7019 (Convert.ImplicitReferenceConversion): Split into
7020 ImplicitReferenceConversionCore() and
7021 ImplicitBoxingConversionExist().
7022 (Convert.ImplicitReferenceConversionExists): Use the new
7023 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7025 2007-04-12 Martin Baulig <martin@ximian.com>
7027 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7028 `TypeManager.null_type' checks up to the top of the method.
7030 2007-04-11 Marek Safar <marek.safar@gmail.com>
7032 A fix for bug #81350
7033 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7036 2007-04-11 Martin Baulig <martin@ximian.com>
7038 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7039 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7040 to make this work for generic classes; fixes #79561.
7042 2007-04-11 Martin Baulig <martin@ximian.com>
7044 * expression.cs (As): Add support for nullable types; fixes #79371.
7046 2007-04-11 Martin Baulig <martin@ximian.com>
7048 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7049 `type.FullName' is null; fixes #80243.
7051 2007-04-11 Martin Baulig <martin@ximian.com>
7053 * expression.cs (Invocation.IsApplicable): Don't modify the method
7054 if type inference succeeded, but the method was not applicable.
7057 2007-04-10 Marek Safar <marek.safar@gmail.com>
7059 A fix for bug #81324
7060 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7061 internal and external namespaces containers.
7063 2007-04-10 Martin Baulig <martin@ximian.com>
7065 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7066 TypeManager.DropGenericMethodArguments() so we also call
7067 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7069 2007-04-10 Martin Baulig <martin@ximian.com>
7071 * iterators.cs (Iterator.CreateIterator): Don't crash if
7072 `method.ReturnType' is null. This happens if something went wrong
7073 while resolving that typ (we already reported an error in this case).
7075 2007-04-10 Martin Baulig <martin@ximian.com>
7077 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7078 generic interfaces; report the CS0144 directly.
7080 2007-04-10 Martin Baulig <martin@ximian.com>
7082 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7083 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7085 2007-04-10 Martin Baulig <martin@ximian.com>
7087 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7089 2007-04-09 Raja R Harinath <rharinath@novell.com>
7092 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7093 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7096 * statement.cs (For.Resolve): If resolution fails, use
7099 2007-04-08 Marek Safar <marek.safar@gmail.com>
7101 * anonymous.cs (MakeName): Make faster and zero-based.
7102 (VerifyExplicitParameterCompatibility): Back to mode where generic
7103 parameter is ignored.
7104 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7106 * class.cs (EmitType): Method can emit another new method.
7108 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7110 * driver.cs: Updated.
7112 * lambda.cs: Reuse predefined empty parameters.
7114 * parameter.cs: Updated
7116 * support.cs: Implemented InflateTypes.
7118 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7119 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7121 2007-04-03 Martin Baulig <martin@ximian.com>
7125 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7126 version of TypeManager.IsOverride() which also works with generic
7129 2007-04-03 Martin Baulig <martin@ximian.com>
7134 (Convert.ExplicitReferenceConversion): We need to cast when
7135 converting from IList<T> to S[].
7137 2007-04-01 Marek Safar <marek.safar@gmail.com>
7139 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7142 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7144 2007-03-31 Marek Safar <marek.safar@gmail.com>
7146 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7147 argument and return type inferring.
7149 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7150 (ReturnType): Turned to property.
7152 * statement.cs (Return): Implemented return type inferring.
7154 * support.cs (ReflectionParameters): Use local types if possible.
7156 2007-03-30 Raja R Harinath <rharinath@novell.com>
7158 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7159 (FlowBranching.UsageVector): Update to changes.
7161 Prepare to kill 'Reachability'
7162 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7163 argument of constructor.
7165 2007-03-29 Raja R Harinath <rharinath@novell.com>
7167 Prepare to kill 'Reachability'
7168 * flowanalysis.cs (UsageVector.is_unreachable): New.
7169 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7170 'reachability', and verify they're consistent.
7173 * expression.cs (New.EmitStatement): Handle type parameters here too.
7175 2007-03-29 Martin Baulig <martin@ximian.com>
7180 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7181 CompilerGeneratedClass.
7182 (ScopeInfo.EmitScopeInstance): Make this protected.
7183 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7184 `ec.CurrentAnonymousMethod.Scope == Scope'.
7186 * statement.cs (Block.ScopeInfo): Make this a property.
7188 2007-03-27 Raja R Harinath <harinath@gmail.com>
7190 Prepare to kill 'Reachability'
7191 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7192 (FlowBranching.UsageVector.Reachability): Remove property.
7193 (FlowBranching.UsageVector.IsUnreachable): New property.
7194 (FlowBranching.UsageVector.ResetBarrier): New.
7195 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7196 * codegen.cs, statement.cs: Update to changes.
7198 2007-03-27 Martin Baulig <martin@ximian.com>
7203 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7206 2007-03-26 Raja R Harinath <rharinath@novell.com>
7208 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7209 instead of TriState. Remove all mention of TriState.
7211 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7212 replaced by a boolean. Add boolean 'is_unreachable' field, check
7213 and maintain invariants.
7215 2007-03-25 Marek Safar <marek.safar@gmail.com>
7217 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7219 2007-03-25 Marek Safar <marek.safar@gmail.com>
7221 * expression.cs: Stop using obsolete 2.0 opcodes.
7223 2007-03-25 Marek Safar <marek.safar@gmail.com>
7225 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7226 one of the latests Martin's fixes.
7228 2007-03-23 Miguel de Icaza <miguel@novell.com>
7230 * expression.cs: On BigEndian systems, swap the bytes, temporary
7231 solution until we get a new bitconverter class.
7233 2007-03-23 Martin Baulig <martin@ximian.com>
7237 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7238 "Method" and "Method`1". Normally, a cache lookup is done on the
7239 "Method" form (ie. without the generic arity), but this one makes
7240 lookups on the full form work as well.
7242 2007-03-22 Raja R Harinath <rharinath@novell.com>
7244 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7247 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7249 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7250 ordered_member_list, to TypeBuilder to store members to be defined
7251 in the order they were parsed in.
7252 - ordered_explicit_member_list contains all properties indexers
7253 and methods that are defined as explicit implementation of an
7254 interface or base class.
7255 - ordered_member_list contains all properties indexers and methods
7256 that are not defined as explicit implementation of an interface
7259 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7260 functionality in these removed classes has been replaced with
7261 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7262 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7264 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7265 to CheckForDuplications inside GetMethod and SetMethod Define Method
7266 to handle method property and indexer name conflicts.
7270 All code is contributed under the MIT/X11 license.
7272 2007-03-20 Martin Baulig <martin@ximian.com>
7274 * class.cs (TypeContainer.Interfaces): Removed; they're now
7275 included in `TypeContainer.Types'.
7277 2007-03-20 Martin Baulig <martin@ximian.com>
7279 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7281 * class.cs (TypeContainer.CreateType): New public method. This is
7282 now called before DefineType() to create the TypeBuilders.
7283 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7284 has already been created by CreateType().
7285 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7286 don't resolve our base classes here; this has been moved into
7287 DefineBaseTypes(). We're now called from CreateType().
7288 (TypeContainer.DefineBaseTypes): New private method; resolve our
7289 base classes here. We're now called from DefineType().
7292 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7293 our types first to create all the TypeBuilders. After that, call
7294 TypeContainer.DefineType() on all the types which'll resolve their
7295 base classes and setup the resolve order.
7297 2007-03-20 Martin Baulig <martin@ximian.com>
7299 * class.cs (TypeContainer.Enums): Removed; they're now included in
7300 `TypeContainer.Types'.
7302 2007-03-20 Martin Baulig <martin@ximian.com>
7305 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7306 (TypeContainer.DoResolveMembers): Call DefineType() on our
7307 `compiler_generated' classes; moved here from DefineNestedTypes().
7310 (RootContext.ResolveTree): Call ResolveMembers() on all
7311 TypeContainer's in the `type_container_resolve_order'.
7313 2007-03-19 Marek Safar <marek.safar@gmail.com>
7315 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7317 2007-03-17 Marek Safar <marek.safar@gmail.com>
7319 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7320 implementation flags.
7322 2007-03-17 Marek Safar <marek.safar@gmail.com>
7324 * class.cs: More optimizations for type parameters.
7326 2007-03-15 Marek Safar <marek.safar@gmail.com>
7328 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7330 * ecore.cs, parameter.cs: More common code for both corlibs.
7332 * typemanager.cs (IsGenericMethod): Simplified.
7334 2007-03-15 Raja R Harinath <rharinath@novell.com>
7336 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7338 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7340 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7341 unconditionally. Simplify explanation.
7342 (Try.Resolve, Using.Resolve): Likewise.
7344 2007-03-15 Martin Baulig <martin@ximian.com>
7348 * decl.cs (DeclSpace): If we're a partial class, use our
7349 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7351 2007-03-15 Raja R Harinath <rharinath@novell.com>
7353 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7355 (FlowBranching.UsageVector): Update to changes.
7356 (FlowBranching.MergeSiblings): Likewise.
7357 * statement.cs: Likewise.
7359 2007-03-15 Martin Baulig <martin@ximian.com>
7364 (MemberCache): Added a special .ctor for type parameters.
7367 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7370 2007-03-09 Martin Baulig <martin@ximian.com>
7372 * enum.cs (Enum): Make this a TypeContainer.
7373 (EnumMember): Derive from `Const'.
7376 (Const.DoResolveValue): New protected virtual method; move most of
7377 the functionality of ResolveValue() here so we can override it in
7379 (Const.CreateConstantReference): Make this virtual.
7381 * class.cs (Kind): Add `Kind.Enum'.
7382 (TypeContainer.Emit): Don't emit the enums here; they're already
7383 in the `RootContext.typecontainer_resolve_order'.
7385 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7386 here; they're already in the `typecontainer_resolve_order'.
7388 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7389 TypeManager.DropGenericTypeArguments().
7392 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7393 (TypeManager.IsEnumType): Likewise.
7394 (TypeManager.EnumToUnderlying): Likewise.
7395 (TypeManager.IsEqual): Add support for enums.
7397 2007-03-12 Raja R Harinath <rharinath@novell.com>
7399 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7400 DefaultParameterValueAttribute to be undefined, say if System.dll
7403 2007-03-11 Marek Safar <marek.safar@gmail.com>
7405 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7408 2007-03-10 Marek Safar <marek.safar@gmail.com>
7410 * class.cs, parameter.cs: Unified parameters verification.
7412 2007-03-08 Martin Baulig <martin@ximian.com>
7414 * cs-parser.jay (constructor_header): Pass the location to the
7415 newly created TopLevelBlock.
7417 2007-03-07 Martin Baulig <martin@ximian.com>
7419 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7421 2007-03-06 Miguel de Icaza <miguel@novell.com>
7423 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7424 with the changes from David, fixes the build.
7426 2007-03-05 David Mitchell <dmitchell@logos.com>
7428 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7429 and its base interfaces to a one-dimensional array type S[],
7430 provided there is an implicit or explicit reference conversion
7433 2007-03-03 Marek Safar <marek.safar@gmail.com>
7435 * cs-tokenizer.cs: Implemented basic linq grammar.
7437 * driver.cs: Set linq lang version on demand.
7439 2007-02-26 Marek Safar <marek.safar@gmail.com>
7441 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7443 2007-02-25 Marek Safar <marek.safar@gmail.com>
7445 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7448 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7450 Check property and event extern attributes.
7452 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7455 2007-02-24 Marek Safar <marek.safar@gmail.com>
7457 A fix for bug #80407
7458 * ecore.cs: Don't report ambiguity error when methods have same parent.
7460 2007-02-23 Marek Safar <marek.safar@gmail.com>
7462 A fix for bug #80878
7463 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7465 2007-02-22 Marek Safar <marek.safar@gmail.com>
7467 * attribute.cs: Enable ExtensionAttribute presence test.
7469 2007-02-22 Marek Safar <marek.safar@gmail.com>
7471 * class.cs: Warn about missing GetHashCode only when Equals is override.
7473 * decl.cs: Check accessibility of type arguments.
7475 * typemanager.cs: Correctly report nullable array.
7477 2007-02-20 Marek Safar <marek.safar@gmail.com>
7479 * class.cs, report.cs: Capture more details when things go wrong.
7481 2007-02-20 Marek Safar <marek.safar@gmail.com>
7483 A fix for bug #80650
7484 * cs-parser.jay: Anonymous container starts at constructor declaration
7485 and not at block beginning because it has to be usable in constructor
7488 * statement.cs: Use context location and not block one for error reporting.
7490 2007-02-18 Marek Safar <marek.safar@gmail.com>
7492 A fix for bug #78712
7493 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
7496 2007-02-18 Marek Safar <marek.safar@gmail.com>
7498 A fix for bug #80493 by Atsushi Enomoto
7499 * cs-parser.jay: Ignore invalid attribute target.
7501 2007-02-18 Marek Safar <marek.safar@gmail.com>
7503 * cs-tokenizer.cs: Ignore '\0' as white space character.
7505 2007-02-17 Miguel de Icaza <miguel@novell.com>
7507 * cs-parser.jay: Add support for lambda expressions to the mcs
7510 * lambda.cs: Only clone when we are probing, not on the final call
7511 (Compatible is the final call).
7513 * statement.cs (CloneContext): Introduce class to provide block
7514 remapping during clone.
7516 All statements Clone themselves now.
7518 (Clone): special handling for blocks, when we clone a block, we
7519 register the block inside this routine, as children of the block
7520 might trigger a lookup.
7522 * expression.cs: Add support for CloneContext in all expressions.
7524 2007-02-17 Marek Safar <marek.safar@gmail.com>
7526 A fix for bug #80493
7527 * statement.cs: Report ambiguous warning when interfaces are not related.
7529 2007-02-15 Marek Safar <marek.safar@gmail.com>
7531 C# 3.0 extension methods.
7533 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
7534 cannot be used directly.
7536 * class.cs (Class.Emit): Emit extension attribute if any class method
7537 is extension method.
7538 (Method.Define): Add basic extension method validation conditions.
7539 (Method.Emit): Emit extension attribute for method.
7541 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
7542 extension method exists. Currently we follow same approach as Microsoft
7543 does, emit even if a method or a class are private but this can change
7546 * cs-parser.jay: Add handling of `this' keyword in method parameters
7549 * decl.cs (DeclSpace.IsStaticClass): New property.
7550 (MemberCache.FindExtensionMethods): Looks for extension methods with
7551 defined name and extension type.
7553 * doc.cs: Updated after OverloadResolve changes.
7555 * driver.cs: Add new soft reference to System.Core.dll.
7557 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
7558 (ExtensionMethodGroupExpr): Represents group of extension methods.
7560 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
7561 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
7562 to MethodGroupExpr and made non-static for easier customization.
7563 (Invocation.DoResolve): Add extension method lookup when no standard
7565 (MemberAccess.DoResolve): Try extension methods if no member exists.
7567 * modifiers.cs: Add METHOD_EXTENSION modifier.
7569 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
7570 as well as candidate extension type.
7571 (ComputeNamespaces): When assembly constains extension methods registers
7573 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
7574 extension method lookup.
7575 (Namespace.LookupExtensionMethod): Looks for extension method in this
7577 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
7578 find a method which matches name and extensionType.
7580 * parameter.cs (Parameter): Add This modifer.
7581 (HasExtensionMethodModifier): New property.
7582 (Resolve): Add extension parameter check.
7583 (ModFlags): turned to property to exclude this modifier as it is not real
7585 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
7587 * support.cs (ParameterData): Add ExtensionMethodType.
7588 (ReflectionParameters): Implemented ExtensionMethodType interface property.
7590 * typemanager.cs: Add type and ctor extension attribute type.
7592 2007-02-15 Miguel de Icaza <miguel@novell.com>
7594 * report.cs (DisableErrors, EnableErrors): used to prevent error
7595 output when we are "trying" to compile various methods with
7598 * ecore.cs (Expression): Add Clone method that calls the virtual
7599 CloneTo method. The current CloneTo method in Expression throws
7600 an exception so we can track down all the places where this must
7601 be implemented (not using abstract, because that would be a lot of
7602 up-front-work before we can start testing the implementation
7605 Important: we only need Clone capabilities for expressions created
7606 by the parser, as the expressions we will be cloning are
7607 expressions in the pre-resolved state. This vastly simplifies
7610 (SimpleName): Add CloneTo that does nothing.
7611 (EmptyCast): Add CloneTo.
7613 * expression.cs (Binary): Implement CloneTo.
7614 (Invocation.IsApplicable): Store the current ec in
7615 EmitContext.TempEc and restore it on return. This is used so we
7616 do not have to sprinkle hundres of methods with an extra
7617 EmitContext, we know that the only user is the lambda expression
7618 ImplicitConversionExists code.
7620 (Argument): Add Cloning capabilities.
7621 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
7622 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
7623 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
7624 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
7625 IndexerAccess): Add Clone capability.
7627 (LocalVariableReference, This): TODO: needs cloned Block mapping.
7629 (Argument): Add cloning capability.
7631 * assign.cs (Assign): Implement CloneTo.
7633 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
7635 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
7636 version by calling Convert with the EmitContext (that we are
7637 currently storing in ec, this is not great, but will do for now,
7638 to avoid passing EmitContext parameters to hundreds of functions
7639 that do not need them now).
7641 (SetExpression): Remove, it is not needed.
7643 (ContextualReturn): Implement CloneTo.
7645 * statement.cs (Statement): Implement cloning infrastructure,
7646 similar to expressions.
7648 (Block): Partial implementation of Clone for statements.
7650 (Return): Implement clone.
7652 * constant.cs (Constant.CloneTo): New method, does nothing.
7654 * codegen.cs (TempEc): Add a static EmitContext as a temporary
7655 solution, until we decide how to exactly do this.
7657 2007-02-14 Marek Safar <marek.safar@gmail.com>
7659 A fix for bug #80493
7660 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
7661 a property is override we need to use second accessor.
7663 2007-02-13 Marek Safar <marek.safar@gmail.com>
7665 A fix for bug #80418
7666 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
7669 2007-02-13 Marek Safar <marek.safar@gmail.com>
7671 Another fix for bug #80749
7672 * pending.cs: Abstract class has priority over interfaces.
7674 2007-02-13 Marek Safar <marek.safar@gmail.com>
7676 Another fix for bug #80749
7677 * pending.cs: Abstract class has priority over interfaces.
7679 2007-02-13 Marek Safar <marek.safar@gmail.com>
7681 Another fix for bug #80749
7682 * pending.cs: Abstract class has priority over interfaces.
7684 2007-02-13 Marek Safar <marek.safar@gmail.com>
7686 Another fix for bug #80749
7687 * pending.cs: Abstract class has priority over interfaces.
7689 2007-02-13 Marek Safar <marek.safar@gmail.com>
7691 * class.cs Better error message.
7693 * driver.cs: Add shorter versions of -optimize option.
7695 2007-02-13 Martin Baulig <martin@ximian.com>
7697 * class.cs (Constructor.Emit): Check the return value of
7698 ec.ResolveTopBlock() and return on error.
7700 2007-02-13 Raja R Harinath <rharinath@novell.com>
7702 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
7703 message to fix error message regression.
7705 2007-02-12 Marek Safar <marek.safar@gmail.com>
7707 * delegate.cs: Delegate creation expression cannot be of Nullable type.
7709 2007-02-12 Marek Safar <marek.safar@gmail.com>
7711 A fix for bug #80749
7712 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
7713 its parent container.
7715 * class.cs (DefineFieldInitializers): Each initializer can has different
7718 * const.cs: Updated.
7720 2007-02-11 Miguel de Icaza <miguel@novell.com>
7722 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
7723 now all the heavy lifting to check that embedded statements or
7724 expressions have the right form is done in the ContextualReturn.
7726 (ContextualReturn): New class.
7728 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
7729 method that can be invoked to report 201, so we do not replicate
7732 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
7734 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
7735 treating tabs as spaces.
7737 2007-02-09 Marek Safar <marek.safar@gmail.com>
7739 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
7740 * assign.cs: Use full implicit conversion for right side check.
7742 2007-02-09 Marek Safar <marek.safar@gmail.com>
7744 * statement.cs (Switch): Switch over boolean type is not standardized.
7746 2007-02-08 Marek Safar <marek.safar@gmail.com>
7748 A fix for bug #80755
7749 * decl.cs (FindBaseEvent): Don't use method cache for events.
7751 2007-02-07 Marek Safar <marek.safar@gmail.com>
7753 * cs-parser.jay: Better syntax error handling.
7755 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
7756 instead of underlying type value.
7758 2007-02-06 Marek Safar <marek.safar@gmail.com>
7760 * driver.cs: Check define identifier before is registered.
7762 * namespace.cs: Use existing error message.
7764 * report.cs: New warning.
7766 2007-02-06 Marek Safar <marek.safar@gmail.com>
7768 A fix for bug #80742
7769 * expression.cs: Delegate Invoke method can be called directly.
7771 2007-02-06 Marek Safar <marek.safar@gmail.com>
7773 A fix for bug #80676
7774 * class.cs (IsEntryPoint): The Main method can have params modifier.
7776 2007-02-04 Miguel de Icaza <miguel@novell.com>
7778 * parameter.cs (Parameter, Parameters): Add Clone method.
7780 * anonymous.cs (Compatible): Turn method into virtual method, so
7781 LambdaExpression can implement a different behavior.
7783 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
7784 out the basic checking here, so it can be used by
7787 * lambda.cs: Introduce "Compatible" function that will do the
7790 2007-02-02 Marek Safar <marek.safar@gmail.com>
7792 * attribute.cs: Unified one error message.
7794 * class.cs (Class): Use type attributes and not properties to test static
7796 (IsEntryPoint): Don's pass local variable.
7798 * convert.cs: Removed duplicate check.
7800 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
7802 * driver.cs: Don't crash when soft reference does not exist.
7804 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
7805 (UsingEntry): Removed redundant allocation.
7807 * parameter.cs: Add fast path for type parameters.
7809 * support.cs: Don't allocate attribute when it's not used.
7811 2007-01-30 Miguel de Icaza <miguel@novell.com>
7814 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
7815 this into a virtual method, so we can override it in LambdaExpression.
7817 * driver.cs: Improve diagnostics in case of failure.
7819 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
7820 write a function that is slightly more complex and that parses:
7822 type identifier [, type identifier]* )
7824 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
7827 (canEmpty ? i >= 0 : i > 0)
7829 2007-01-30 Raja R Harinath <rharinath@novell.com>
7831 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
7832 exception on possibly valid code.
7834 2007-01-29 Raja R Harinath <rharinath@novell.com>
7836 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
7838 (parse_opt_type_arguments): Remove. It's almost the same as
7840 (parse_namespace_or_typename): Use parse_less_than.
7842 2007-01-28 Miguel de Icaza <miguel@novell.com>
7844 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
7845 this bug took a few hours to find, because the state saved and
7846 restored by PushPosition and PopPosition was ignoring the state of
7847 parse_generic_less_than.
7849 I can also now remove the handling of OP_LT and OP_GT, this solves
7852 * cs-tokenizer.cs: store the location for the ARROW token, we use
7855 (PushPosition, PopPosition): save/restore also `current_token',
7856 restore `parse_generic_less_than' (was missing).
7858 (parse_opt_type_arguments): use parse_type, not
7859 parse_namespace_or_typename to parse types.
7861 * lambda.cs: Empty new file, will eventually have the lambda
7862 expression implementation.
7864 * lambda.test: used to test the internal tokenizer.
7866 * report.cs (FeatureIsNotISO1): Rename from
7867 FeatureIsNotStandardized, because it was about the language level
7868 (1 vs 2) it was not about standarization.
7870 (FeatureRequiresLINQ): New.
7872 * support.cs (SeekableStreamReader): Only require that the reader
7873 is a TextReader, not a StreamReader, so we can plug StringReader.
7875 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
7876 given position in the input stream the following tokens can be
7877 parsed as a type followed by an identifier.
7879 (is_punct): after a '(' if parse_type_and_parameter returns true,
7880 then return a special token OPEN_PARENS_LAMBDA which is used to
7881 avoid reduce/reduce errors in the grammar for the
7882 lambda_expression rules.
7884 (parse_type): implement a type parser inside the
7885 tokenizer, the parser only returns true or false depending on
7886 whether the input at a given position can be parsed as a type.
7888 (peek_token): new method used during type parsing.
7890 2007-01-28 Raja R Harinath <rharinath@novell.com>
7893 * anonymous.cs (ScopeInfo.InflateParameters): New.
7894 (AnonymousContainer.Resolve): Use it to redirect types of
7895 delegate parameters.
7897 2007-01-27 Raja R Harinath <rharinath@novell.com>
7900 * expression.cs (Error_InvalidArguments): Don't use two different
7901 messages for CS1503. Use ExtraInformation and
7902 SymbolRelatedToPreviousError instead.
7905 * decl.cs (DeclSpace.initialize_type_params): Don't access
7906 'type_params' of a partial class directly.
7908 2007-01-26 Miguel de Icaza <miguel@novell.com>
7910 * constant.cs: Removed a handful of out-of-range checks that were
7913 2007-01-25 Marek Safar <marek.safar@gmail.com>
7915 * expression.cs (CheckUselessComparison): Add additional check for char
7918 * namespace.cs: Fixed typo.
7920 2007-01-23 Miguel de Icaza <miguel@novell.com>
7922 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
7923 gone, instead we inline the test, preventing the needless casts to
7924 longs, ulongs and doubles for the parameters, avoiding calls to
7925 methods that overchecked stuff, and instead inlined things
7928 2007-01-20 Marek Safar <marek.safar@gmail.com>
7930 * cs-parser.jay: Better parameter error handling.
7932 2007-01-17 Marek Safar <marek.safar@gmail.com>
7934 A fix for bug #80368, #80522
7935 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
7936 whether array initializer contains constants only.
7937 (ArrayCreation.Emit): Use better formula to decide when
7938 are array initializers for static initialization.
7939 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
7940 have to emit even constants otherwise they are pre-initialized.
7942 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
7943 Raja R Harinath <rharinath@novell.com>
7945 Fix emit order of 'get' vs. 'set'.
7946 * support.cs (Accessors): New.
7947 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
7948 Note the order in which accessors are declared in the source.
7949 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
7950 Refactored from Property.Define and Indexer.Define.
7951 (PropertyBase.DefineAccessors): New helper that calls the above in
7952 appropriate order as noted by the parser.
7953 (Property.Define, Indexer.Define): Update to changes.
7954 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
7956 2007-01-17 Raja R Harinath <rharinath@novell.com>
7958 Fix cs0029-6.cs and gcs0029-2.cs (regression)
7959 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
7960 there's an implicit conversion from the current type to the target
7961 type before converting the underlying constant.
7963 2007-01-16 Marek Safar <marek.safar@gmail.com>
7965 * const.cs (ResolveValue): Updated after constant conversion was made more
7968 * constant.cs (GetAttributableValue): constant to object conversion is
7969 used for attributes only.
7970 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
7971 constant conversions.
7972 (LongConstant.ConvertImplicitly): Ditto.
7974 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
7975 (ImplicitConversionStandard): Handle constant conversion as extra step.
7976 It solves the issue when constant conversion was called indirectly like
7977 inside array initializer and constant folding was skipped.
7979 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
7982 * statement.cs(ImplicitConversionStandard): Updated after constant
7983 conversion was made more generic.
7985 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
7987 * expression.cs (As.DoResolve): Use GenericConstraints instead of
7988 Constraints, solves the problem where the compiler incorrectly
7989 reported that a type parameter was not constrained to a class (Bug
7992 2007-01-14 Marek Habersack <grendello@gmail.com>
7994 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
7996 2007-01-14 Marek Safar <marek.safar@gmail.com>
7998 A fix for bug #80368
7999 * assign.cs (FieldInitializer): New class implements field
8000 initializer statement.
8002 * attribute.cs: Update after FieldMember rename.
8004 * class.cs (PropertyBasedMember): New common class for property based
8006 (InterfaceMemberBase): New base class for all members which can be used as
8007 an interface members.
8008 (MethodCore): Moved really common code to InterfaceMemberBase.
8009 (Method.Define): Equal and GetHasCode detection is relevant for methods
8011 (MethodData.Define): Don't assume that public event implements an
8012 interface automatically.
8013 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8015 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8016 (FieldMember): Merged with FieldBase.
8017 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8018 event extern modifier can be used.
8019 (EventField.EventFieldAccessor): Moved event field specific code here.
8020 (Event.AllowedModifiers): Even event can be extern.
8021 (Event.FindOutBaseMethod): New override specific to events.
8022 (Indexer.parameters): Reintroduce parameters because base class holds
8023 only properties common data.
8024 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8025 need do extra parameters check.
8027 * const.cs: Update after FieldMember rename.
8029 * decl.cs (MemberCache.FindBaseEvent): New method.
8031 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8032 to reflect that indexer is now derived from PropertyBased.
8034 * ecore.cs (GetMemberType): Made public.
8035 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8038 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8040 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8041 (RegisterEvent): Removed.
8042 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8043 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8045 2007-01-11 Raja R Harinath <rharinath@novell.com>
8048 * statement.cs (CollectionForeach.TryType): Prefer generic
8049 GetEnumerator over non-generic variant. Fix code to follow comments.
8051 2007-01-09 Raja R Harinath <rharinath@novell.com>
8054 * support.cs (ReflectionParameter): Don't use an invalid index on
8055 the generic parameter data.
8057 2007-01-08 Miguel de Icaza <miguel@novell.com>
8059 * driver.cs: Just add a tiny bit of infrastructure.
8061 2007-01-02 Marek Safar <marek.safar@gmail.com>
8063 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8064 where field type is struct from current assembly.
8066 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8069 2007-01-02 Marek Safar <marek.safar@gmail.com>
8071 A fix for bug #80381
8072 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8075 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8077 (Namespace.LookupType): Always use core types from corlib when speficied.
8079 * report.cs: A new warning.
8081 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8082 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8083 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8085 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8086 (InitCoreTypes): Set expression type of object_type and value_type
8087 immediately after lookup.
8089 2007-01-01 Miguel de Icaza <miguel@novell.com>
8091 * cs-tokenizer.cs: Accept Pc class characters (Connector
8092 Punctuation) as valid identifiers. Fixes #78259
8094 * expression.cs (Invocation.DoResolve): Moved the check for the
8095 use of `this' for doing method calls to the Invocation resolution
8096 step, after overload resolution has taken place instead of doing
8097 the check at the low-level `This.DoResolve' level.
8099 The `This.DoResolve'(appens before overload resolution, so it has
8100 no way of knowing if the method that will be called will be
8101 instace or static, triggering an erroneous report for cs0188 (Bug
8104 We now do the check for instance method invocations after we know
8105 what method will be called.
8107 (This.CheckThisUsage): Move the actual use of this structure
8108 checking into its own method and expose it.
8110 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8113 Exceptions: Null.ConvertImplicitly,
8114 Constant.ImplicitConversionRequired as there are too many call
8115 sites for passing the ec.
8117 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8118 EmitContext, if the value is null, then we do not try to provide
8119 the extra information from the error (If a userdefined conversion
8120 exists, as UserDefinedConversion requires a non null-EmitContext).
8124 2006-12-30 Raja R Harinath <rharinath@novell.com>
8126 * flowanalysis.cs (MyBitVector): Document some invariants.
8127 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8128 introduced below, and add a couple of others,
8130 2006-12-30 Marek Safar <marek.safar@gmail.com>
8132 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8133 GetPropertyFromAccessor and GetEventFromAccessor.
8135 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8136 overrides non-obsolete one.
8137 (Indexer.Define): Error message has been moved to the parser.
8139 * cs-parser.jay: Better syntax errors handling.
8141 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8142 when an invocation has no arguments.
8144 * ecore.cs: Removed not used caching.
8146 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8149 * report.cs: Add a new warning.
8151 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8153 * typemanager.cs (enumeration_type): Removed.
8154 (CSharpSignature): Reuses IsSpecialMethod.
8155 (IsEqual): Hack for MS BCL.
8156 (GetPropertyFromAccessor): New method.
8157 (GetEventFromAccessor): New method.
8158 (IsSpecialMethod): Fixed to handle more cases.
8160 2006-12-30 Marek Safar <marek.safar@gmail.com>
8162 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8163 Made white spaces array static.
8165 * ecore.cs (RemoveGenericArity): Optimized.
8167 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8169 (MyBitVector.initialize_vector): Simplified.
8171 2006-12-22 Miguel de Icaza <miguel@novell.com>
8173 * ecore.cs: Am not entirely happy with this hack, but it seems to
8174 address the issue in 80257 (a small test case for
8177 I set the MethodGroupExpr.Type to an internal compiler type
8178 (itself in this case) to force the resolution to take place. Why
8179 it does not take place with a null is beyond me.
8181 2006-12-20 Marek Safar <marek.safar@gmail.com>
8183 A fix for bug #80288
8184 * expression.cs (ResolveOperator): Consider user defined conversion for
8185 logical and operator too.
8186 (EmitBranchable): Optimization for logical and when full constant folding
8187 could not be applied but one operand is constant.
8189 2006-12-19 Marek Safar <marek.safar@gmail.com>
8191 * class.cs (GetClassBases): Write 5 times every day, will never use
8192 FullName for error reporting.
8194 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8196 2006-12-19 Martin Baulig <martin@ximian.com>
8198 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8199 the symbol file info here.
8201 2006-12-18 Marek Safar <marek.safar@gmail.com>
8203 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8204 of `elseif' is taking then following sections are not taking.
8205 Fixes an issue reported on mono mailing list.
8207 2006-12-18 Marek Safar <marek.safar@gmail.com>
8209 A fix for bug #80300
8210 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8211 a caller is not taking.
8213 2006-12-18 Raja R Harinath <rharinath@novell.com>
8215 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8216 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8217 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8218 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8219 * class.cs: Update to changes.
8221 2006-12-17 Marek Safar <marek.safar@gmail.com>
8223 A fix for bug #79934
8224 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8227 * class.cs (ResolveMembers): Register an iterator in current container and
8230 2006-12-16 Raja R Harinath <rharinath@novell.com>
8233 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8234 satisfy a params annotated parameter.
8236 2006-12-16 Marek Safar <marek.safar@gmail.com>
8238 A fix for bug #77014
8239 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8240 paramters correctly and not rely on hacks in Parameters class.
8241 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8243 (Invocation.VerifyArgumentsCompat): Ditto.
8244 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8247 * parameter.cs (HasParams): Don't assume that params is the last one.
8249 * support.cs (ReflectionParameters.ctor): Look for params attribute
8251 (ReflectionParameters.ParameterType): Removed hack when we returned last
8252 parameter for out of range parameters.
8253 (ParameterName, ParameterModifier): Ditto.
8255 2006-12-14 Marek Safar <marek.safar@gmail.com>
8257 A fix for bug #79987
8258 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8259 when assembly is not CLS compliant but type is. I have no idea why is this
8262 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8264 2006-12-13 Miguel de Icaza <miguel@novell.com>
8266 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8267 in struct constructors, they are basically no-ops.
8269 2006-12-12 Marek Safar <marek.safar@gmail.com>
8271 * cs-tokenizer.cs (Position): Save preprocessor status too.
8273 2006-12-12 Marek Safar <marek.safar@gmail.com>
8275 A fix for bug #77794
8276 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8278 2006-12-12 Marek Safar <marek.safar@gmail.com>
8280 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8282 (pp_expr): Report error for an invalid expression.
8283 (handle_preprocessing_directive): Simplified; add more error checking.
8285 2006-12-11 Marek Safar <marek.safar@gmail.com>
8287 A fix for bug #74939
8288 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8289 directives handling.
8291 2006-12-10 Marek Safar <marek.safar@gmail.com>
8293 A fix for bugs #80093, and #75984
8294 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8295 logic, it seems to me as it worked before "by coincidence".
8296 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8297 (cleanup): Enabled endif check.
8299 2006-12-09 Marek Safar <marek.safar@gmail.com>
8301 A fix for bug #80162
8302 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8303 enumerators are never ambiguous.
8305 2006-12-08 Raja R Harinath <rharinath@novell.com>
8308 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8310 2006-12-06 Marek Safar <marek.safar@gmail.com>
8312 A fix for bug #80144
8313 * class.cs (EventProperty.Define): Explicit implementation means
8314 that an even is used.
8316 2006-12-06 Marek Safar <marek.safar@gmail.com>
8318 Fixes the operators implementation (part II)
8320 * cfold.cs (DoConstantNumericPromotions): Renamed to
8321 DoBinaryNumericPromotions and simplified.
8322 (BinaryFold): Couple of conversion fixes; simplified.
8324 * constant.cs, ecore.cs, literal.cs
8325 (ToType): Renamed to ConvertImplicitly.
8326 (Reduce): Renamed to ConvertExplicitly.
8328 * class.cs, convert.cs: Updated.
8330 * expression.cs: TryReduce doesn't throw an exception.
8332 2006-12-01 Marek Safar <marek.safar@gmail.com>
8334 A fix for bug #80108
8335 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8338 2006-11-30 Marek Safar <marek.safar@gmail.com>
8340 Fixes unary operators implementation (part I)
8343 * cfold.cs (Error_CompileTimeOverflow): Made internal
8345 * const.cs (IConstant): Changed to use reference to constant and
8346 not constant itself.
8347 Updated IConstant implementations.
8349 * constant.cs (CreateConstant): New factory method.
8350 Updated IConstant implementation.
8352 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8354 * ecore.cs: Updated to use CreateConstantReference.
8356 * enum.cs: Reflects IConstant changes.
8358 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8360 * literal.cs (NullConstant): Change to be independently usable.
8362 2006-11-29 Martin Baulig <martin@ximian.com>
8364 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8365 we need to emit the scope initializer before calling the base .ctor.
8367 * anonymous.cs: Merged back from the new anonymous methods branch.
8368 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8370 * expression.cs (ParameterReference.DoResolveBase): Create a
8371 "normal" ScopeInfo when capturing parameters rather than using the
8372 root scope; this makes things work with anonymous methods having
8376 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8378 2006-11-22 Marek Safar <marek.safar@gmail.com>
8380 A fix for bug #79987
8381 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8382 check to a base class.
8383 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8384 only when assembly has missing attribute.
8385 * report.cs: Update.
8387 2006-11-21 Marek Safar <marek.safar@gmail.com>
8389 * cs-tokenizer.cs: Merged with gmcs version.
8391 2006-11-20 Marek Safar <marek.safar@gmail.com>
8394 * cs-parser.jay: Better error message when partial keyword is misplaced.
8396 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8398 A fix for bug #79810
8399 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8400 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8401 a RuntimeWrappedException by default.
8403 2006-11-18 Marek Safar <marek.safar@gmail.com>
8405 A fix for bug #79843
8406 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8408 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8410 2006-11-18 Marek Safar <marek.safar@gmail.com>
8412 * driver.cs, namespace.cs: Uses faster IndexOf version.
8414 2006-11-17 Marek Safar <marek.safar@gmail.com>
8416 A fix for bug #79941
8417 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8419 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8420 even if internal name is different.
8421 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8422 (UserDefinedConversion): Simplified as the operators cannot be internal.
8423 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8425 (MethodLookup): Replaced EmitContext with parentType.
8426 * expression.cs: Updated.
8428 2006-11-09 Raja R Harinath <rharinath@novell.com>
8430 * driver.cs (BadAssembly): Handle all the ugliness of
8431 DefineDynamicAssembly.
8433 2006-11-08 Raja R Harinath <rharinath@novell.com>
8435 Address parts of #58244 -- most of what's left is in the runtime
8436 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8437 CS1509 error checks, and handle them for all assembly loads, not
8438 just the first invocation.
8439 (LoadModule): Likewise. Move handling of 'adder_method' ...
8440 * codegen.cs (AssemblyClass.AddModule): ... here.
8442 2006-11-02 Marek Safar <marek.safar@gmail.com>
8444 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8445 IEnumerable<T> is ambiguous.
8447 2006-10-31 Marek Safar <marek.safar@gmail.com>
8449 A fix for bug #67689
8450 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8451 GetEnumerator is ambiguous.
8453 * report.cs: Add new warning.
8455 2006-10-29 Marek Safar <marek.safar@gmail.com>
8457 A fix for bug #78602
8458 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8459 to protected member can be nested type.
8461 2006-10-28 Marek Safar <marek.safar@gmail.com>
8463 A fix for bug #78965
8464 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8465 to protected member must derive from current type.
8467 2006-10-27 Marek Safar <marek.safar@gmail.com>
8469 assign.cs: Reuses error method.
8471 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8472 instead of type for constants.
8473 (Expression.Error_ValueAssignment): Common error method.
8475 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8478 2006-10-27 Marek Safar <marek.safar@gmail.com>
8480 A fix for bug #79081
8481 * expression.cs (MemberAccess.DoResolve): Check nested type
8484 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8486 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8488 2006-10-26 Marek Safar <marek.safar@gmail.com>
8490 A fix for bug #76591
8491 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
8493 2006-10-26 Marek Safar <marek.safar@gmail.com>
8495 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
8496 type forwarder of the same type multiple times.
8498 2006-10-26 Raja R Harinath <rharinath@novell.com>
8501 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
8502 instance as an rvalue, even when we later resolve as an lvalue.
8504 2006-10-25 Martin Baulig <martin@ximian.com>
8506 * anonymous.cs: Fix #79673.
8508 2006-10-24 Marek Safar <marek.safar@seznam.cz>
8510 A fix for bug #79666
8511 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
8512 ignored when is optimized (= default value) as its value is already set.
8514 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8516 A fix for bug #79724
8517 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
8518 TypeContainer for type lookup.
8520 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8522 A fix for bug #79231
8523 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
8524 * expression.cs (OverloadResolve): Always convert type name for
8526 (ResolveNamespaceOrType): Don't confuse a nested type with any
8529 2006-10-18 Martin Baulig <martin@ximian.com>
8531 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
8533 2006-10-17 Miguel de Icaza <miguel@novell.com>
8535 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
8536 an int32, but requesting an int64 from the conversion
8538 2006-10-12 Martin Baulig <martin@ximian.com>
8541 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
8543 2006-10-12 Martin Baulig <martin@ximian.com>
8546 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
8548 2006-10-11 Miguel de Icaza <miguel@novell.com>
8550 * convert.cs: Remove broken code: I was doing the "Existance"
8551 tests for Implicit conversions.
8553 2006-10-10 Miguel de Icaza <miguel@novell.com>
8555 * convert.cs: Added one missing case in
8556 ImplicitStandardConversionExists uint64 to intptr.
8560 * typemanager.cs (uintptr_type): another core known type.
8562 * ecore.cs (OperatorCast): routine used to do cast operations that
8563 depend on op_Explicit. We could change some of the Decimal
8564 conversions to use this.
8566 This one has a probe mechanism that checks both types for an op_
8567 which it coudl be used to eliminate two classes: CastToDecimal
8568 and CastFromDecimal.
8570 * convert.cs: Implement the conversions documented in #59800
8572 2006-10-10 Martin Baulig <martin@ximian.com>
8574 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
8575 before RootScope.ResolveMembers().
8577 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
8578 `CurrentType' if appropriate.
8580 2006-10-09 Marek Safar <marek.safar@seznam.cz>
8582 A fix for bug #78568
8583 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
8584 when contains binary operators.
8585 * cs-parser.jay: Updated.
8587 2006-10-09 Martin Baulig <martin@ximian.com>
8590 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
8591 moved that into Define() and also do the other type parameter
8592 checks there. Fixes #79094. Added gtest-292.cs.
8595 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
8596 since that doesn't include type parameters; don't use `Ldelema'
8597 for type parameters. Fixes #78980. Added gtest-293.cs.
8599 2006-10-08 Marek Safar <marek.safar@seznam.cz>
8602 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
8603 conversion is allowed.
8605 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8607 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
8608 error reporting when no error occurs.
8610 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8612 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
8615 2006-10-06 Raja R Harinath <rharinath@novell.com>
8618 * class.cs (DefineTypeBuilder): Check circular dependencies before
8619 setting the parent of the TypeBuilder.
8620 (CheckRecursiveDefinition): Don't use 'BaseType', since
8621 it may not be valid until after DefineTypeBuilder. Use
8622 'base_type' instead.
8624 2006-10-04 Martin Baulig <martin@ximian.com>
8626 Merged the Anonymous Methods patch.
8628 * anonymous.cs, iterators.cs: The new anonymous methods code.
8630 * statement.cs (Variable): New public abstract class.
8631 (LocalInfo.Variable): New public property.
8632 (LocalInfo.ResolveVariable): New public method.
8633 (Block.Flags): Add `IsIterator'.
8634 (Block.AddVariable): Improved the CS0136 check.
8635 (Block.AnonymousChildren): New public property.
8636 (Block.AddAnonymousChild): New public method.
8637 (ToplevelBlock): Update to use the new anonymous method framework.
8638 (ToplevelBlock.ctor): `container' is now a `Block' and not a
8639 `ToplevelBlock'; this is required to correctly implement the
8641 (Fixed, Using): Use `TemporaryVariable' instead of directly
8642 creating the `LocalBuilder'.
8644 * parameter.cs (Parameter.ResolveVariable): New public method.
8645 (Parameters.ResolveVariable): Likewise.
8647 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
8649 * class.cs (TypeContainer): Replaced the `iterators' list and
8650 corresponding methods with a list of `CompilerGeneratedClass'es.
8651 (TypeContainer.ResolveMembers): New public method.
8652 (Method): `IIteratorContainer' has been replaced by
8655 * expression.cs (VariableReference): New public abstract base
8656 class for `LocalVariableReference', `ParameterReference' and
8659 * codegen.cs (EmitContext): Removed `capture_context',
8660 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
8661 (EmitContext.EmitThis): Removed.
8663 * cs-parser.jay: Replace `iterator_container' with
8666 2006-10-04 Martin Baulig <martin@ximian.com>
8668 * generic.cs (GenericMethod): Don't make this abstract.
8669 (Constraints.Clone): Added dummy implementation.
8671 2006-10-04 Raja R Harinath <harinath@gmail.com>
8674 * namespace.cs (LookForAnyGenericType): Avoid nullref on
8675 'declspaces'. Avoid allocating arrays willy-nilly.
8678 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
8679 cases out of the switch.
8681 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8683 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
8684 message when non-generic type is used with the type arguments.
8685 * expression.cs: Updated.
8687 2006-09-28 Raja R Harinath <rharinath@novell.com>
8690 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
8691 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8692 Change semantics slightly. Don't insist on having only one
8693 temporary EmptyExpression -- just throttle the creation of new ones.
8696 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
8697 non-interfaces too. If no methods are found, don't try to create
8700 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8702 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
8705 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
8706 us produce better error message.
8708 2006-09-27 Marek Safar <marek.safar@seznam.cz>
8710 * expression.cs (Binary.ResolveOperator): Warn about a side effect
8711 of the `|' operator.
8713 * report.cs: A new warning added.
8715 2006-09-27 Martin Baulig <martin@ximian.com>
8717 * generic.cs (GenericMethod): Don't make this abstract.
8719 2006-09-27 Martin Baulig <martin@ximian.com>
8722 (InternalErrorException): Added overloaded ctor taking a params array.
8724 2006-09-26 Marek Safar <marek.safar@seznam.cz>
8726 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
8727 Fixed the cases when same error was reported twice.
8729 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
8730 now report symbol information.
8732 2006-09-25 Martin Baulig <martin@ximian.com>
8734 * class.cs: Completely unified with the gmcs version.
8736 2006-09-25 Martin Baulig <martin@ximian.com>
8738 * typemanager.cs (TypeManager.IsNullableType): New public function.
8739 (TypeManager.IsNullableTypeOf): Likewise.
8740 (TypeManager.IsNullableValueType): Likewise.
8742 * class.cs (MethodCore): Added the `GenericMethod' argument from
8743 gmcs and also unified all classes derived from `MethodCore' with gmcs.
8745 2006-09-24 Raja R Harinath <harinath@gmail.com>
8747 * convert.cs: Unify with gmcs version.
8749 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8751 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
8752 verify them as well.
8754 * report.cs: New warning.
8756 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8758 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
8759 for anonymous block with out argument.
8761 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8763 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
8764 not used private events only.
8766 2006-09-23 Marek Safar <marek.safar@seznam.cz>
8768 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
8770 * const.cs (Const.Define): Check for constant type.
8771 (Const.IsConstantTypeValid): Looks for valid constant types.
8773 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
8775 * ecore.cs (EmptyConstantCast): New common class for all constant based
8778 * expression.cs (Is.DoResolve): Handle null constant especially.
8779 (New.DoResolve): Check for new void().
8780 (MemberAccess.DoResolve): Cope with all kind of nulls.
8782 * literal.cs (NullConstant): Uses EmptyConstantCast.
8783 (NullDefault): Based on EmptyConstantCast.
8784 (NullLiteral): Uses EmptyConstantCast.
8786 * statement.cs (Block.ResolveMeta): Check for constant type.
8788 2006-09-22 Martin Baulig <martin@ximian.com>
8790 * delegate.cs, attribute.cs: Merged with the gmcs versions.
8792 2006-09-22 Raja R Harinath <rharinath@novell.com>
8794 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
8798 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
8799 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
8802 2006-09-22 Martin Baulig <martin@ximian.com>
8804 * ecore.cs: Merged with the gmcs version.
8806 * generic.cs (ConstructedType): New dummy class.
8807 (TypeArguments): Don't make this abstract.
8810 (TypeManager.IsGenericTypeDefinition): New method.
8811 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
8813 2006-09-22 Raja R Harinath <rharinath@novell.com>
8815 * expression.cs (ComposedCast): Check for arrays of TypedReference
8816 before creating the type, not after.
8818 2006-09-21 Marek Safar <marek.safar@seznam.cz>
8820 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
8821 after ToType change.
8823 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
8824 when constant must be implicitly convertible.
8826 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
8828 * ecore.cs (NullCast): Derives from NullConstant.
8830 * expression.cs (Is.DoResolve): Removed useless variables.
8831 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
8832 (New.Constantify): Add enum support.
8833 (MemberAccess.DoResolve): Add warning when accessing null constant or
8836 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
8839 * literal.cs (NullConstant): New abstract class with common
8840 functionality for all null specializations.
8841 (NullDefault): Represents default(X) when result can be
8843 (NullLiteral): Updated.
8845 * report.cs: Add new warning.
8847 2006-09-21 Martin Baulig <martin@ximian.com>
8849 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
8851 2006-09-21 Martin Baulig <martin@ximian.com>
8853 * generic.cs (GenericConstraints): New dummy class.
8854 (Constraints): Likewise.
8855 (TypeParameter): Likewise.
8856 (TypeParameterName): Likewise.
8857 (GenericMethod): Likewise.
8859 * typemanager.cs (TypeManager.GetGenericArguments): New method.
8861 * decl.cs: Merged with the gmcs version.
8863 2006-09-21 Raja R Harinath <rharinath@novell.com>
8865 * generic.cs (TypeParameter): Implement IMemberContainer.
8866 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
8868 * rootcontext.cs: Unify with gmcs version.
8870 * report.cs: Unify with gmcs version.
8871 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
8872 from gmcs/generics.cs.
8873 * generics.cs (TypeParameter): New dummy class.
8875 * support.cs: Unify with gmcs version.
8877 2006-09-20 Raja R Harinath <rharinath@novell.com>
8879 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
8880 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
8882 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
8883 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
8884 * mcs.exe.sources: Add generic.cs.
8886 * codegen.cs: Unify with gmcs version.
8888 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
8889 (EmitContext): Add GenericDeclContainer implementation.
8890 * decl.cs (MemberCore, DeclSpace): Likewise.
8891 * namespace.cs: Remove #ifdef GMCS_SOURCE.
8893 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
8894 MCS TypeManager has a corresponding dummy method.
8896 2006-09-19 Martin Baulig <martin@ximian.com>
8898 * expression.cs: Completely merged with the gmcs version.
8900 2006-09-19 Martin Baulig <martin@ximian.com>
8902 * expression.cs (Invocation): Merged with the gmcs version.
8903 (ArrayAccess.GetStoreOpcode): Likewise.
8905 2006-09-19 Martin Baulig <martin@ximian.com>
8908 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
8909 (TypeManager.IsGenericMethodDefinition): Likewise.
8911 2006-09-19 Martin Baulig <martin@ximian.com>
8914 (TypeManager.IsEqual): Moved the gmcs implementation here.
8915 (TypeManager.DropGenericTypeArguments): Likewise.
8916 (TypeManager.DropGenericMethodArguments): Likewise.
8917 (TypeManager.GetTypeArguments): Moved here from gmcs.
8918 (TypeManager.HasGenericArguments): Likewise.
8920 2006-09-19 Martin Baulig <martin@ximian.com>
8922 * expression.cs (Binary): Merged with the gmcs version.
8924 2006-09-19 Martin Baulig <martin@ximian.com>
8926 * expression.cs (Probe, As, Is): Merged with the gmcs version.
8928 2006-09-19 Martin Baulig <martin@ximian.com>
8930 * typemanager.cs: Merged with the gmcs version.
8932 2006-09-16 Raja R Harinath <rharinath@novell.com>
8934 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
8935 * driver.cs: Likewise.
8937 2006-09-16 Marek Safar <marek.safar@seznam.cz>
8940 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
8941 only if parent type is class.
8942 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
8945 2006-09-15 Marek Safar <marek.safar@seznam.cz>
8948 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
8950 * typemanager.cs(CSharpName): Converts NullType to null.
8952 2006-09-15 Martin Baulig <martin@ximian.com>
8955 (TypeManager.GetMethodName): Added mcs implementation.
8956 (TypeManager.IsEqual): Likewise.
8959 (SimpleName.RemoveGenericArity): Added dummy implementation.
8961 * pending.cs: Merged with the gmcs version.
8963 2006-09-15 Martin Baulig <martin@ximian.com>
8965 * statement.cs: Merge with the gmcs version.
8967 2006-09-15 Martin Baulig <martin@ximian.com>
8969 * statement.cs (Switch): Merge with the gmcs implementation
8970 (without nullables), which is newer.
8972 2006-09-15 Martin Baulig <martin@ximian.com>
8974 * statement.cs (Block.Variables): Make this public.
8975 (ToplevelBlock.Parameters): Make this a property.
8976 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
8978 2006-09-15 Martin Baulig <martin@ximian.com>
8980 * namespace.cs: Merge with the gmcs version.
8982 2006-09-15 Martin Baulig <martin@ximian.com>
8984 * decl.cs (MemberName): Minor code cleanups.
8986 2006-09-15 Martin Baulig <martin@ximian.com>
8988 * parameter.cs: Merge with the gmcs version.
8990 2006-09-15 Martin Baulig <martin@ximian.com>
8992 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
8993 and an error in mcs.
8995 2006-09-15 Martin Baulig <martin@ximian.com>
8997 * flowanalysis.cs: Merged from GMCS; added the generics code into
8998 a `GMCS_SOURCE' conditional so we can share this file.
9000 2006-09-08 Martin Baulig <martin@ximian.com>
9002 * typemanager.cs (TypeManager.interlocked_type): New public field.
9003 (TypeManager.int_interlocked_compare-exchange): New public field.
9004 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9005 enumerator types here and call InitGenericCoreTypes().
9006 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9007 after calling InitEnumUnderlyingTypes().
9010 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9011 `classes_second_stage'.
9013 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9015 * assign.cs, ecore.cs, expression.cs: Share error message text.
9016 * class.cs (FieldMember.Define): Check for varible of static type.
9017 * driver.cs (LoadAssembly): Uses error output for errors.
9018 * statement.cs: Updated.
9020 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9022 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9025 2006-09-07 Martin Baulig <martin@ximian.com>
9028 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9030 2006-08-29 Miguel de Icaza <miguel@novell.com>
9032 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9034 2006-08-17 Miguel de Icaza <miguel@novell.com>
9036 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9037 #52019 and #79064, the use of the \uXXXX sequence in source code
9038 to represent unicode characters.
9040 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9042 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9044 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9046 2006-08-13 Miguel de Icaza <miguel@novell.com>
9048 * assign.cs: Catch attempts to assign to a method groups in += and
9051 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9054 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9056 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9058 * class.cs (Method.Define): Issue a warning when generic method looks like
9060 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9063 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9065 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9067 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9068 search all base interfaces as a member can be ambiguous.
9069 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9070 Constructor member type filter.
9071 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9072 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9073 reporting for returned memberinfos.
9074 * report.cs: Updated.
9075 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9076 version to work on all runtimes.
9077 (TypeManager.RealMemberLookup): Removed members filtering.
9079 2006-08-08 Raja R Harinath <rharinath@novell.com>
9081 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9082 (PropertyExpr.EmitAssign): Likewise.
9083 * expression.cs (Indirection.EmitAssign): Likewise.
9084 (LocalVariableReference.EmitAssign): Likewise.
9085 (ParameterReference.EmitAssign): Likewise.
9086 (Invocation.EmitArguments): Likewise.
9087 (ArrayAccess.EmitAssign): Likewise.
9088 (IndexerAccess.EmitAssign): Likewise.
9089 (This.EmitAssign): Likewise.
9090 (ConditionalLogicalOperator.Emit): Likewise.
9093 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9094 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9095 leave it in after returning it.
9096 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9098 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9100 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9103 2006-08-03 Raja R Harinath <rharinath@novell.com>
9105 Fix cs0146-3.cs and cs0146-4.cs.
9106 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9107 enclosing types don't depend on the current type.
9109 2006-08-02 Raja R Harinath <rharinath@novell.com>
9112 * class.cs (TypeContainer.DoDefineMembers): Use
9113 FindBaseMemberWithSameName on Parent, since we're interested in
9114 whether we hide inherited members or not.
9115 (FindBaseMemberWithSameName): Make slightly more robust.
9117 Fix the non-generic testcase from #77396
9118 * decl.cs (DeclSpace.DeclContainer): Remove override.
9120 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9121 declspaces for doppelgangers too.
9122 (UsingEntry): Implement IResolveContext.
9123 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9124 'this' as the resolve context.
9125 (LocalAliasEntry): Likewise.
9127 Implement parts of #77403
9128 * roottypes.cs (RootDeclSpace): New. Used to represent the
9129 toplevel declaration space. Each namespace declaration introduces
9130 a "partial" root declaretion space.
9131 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9132 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9133 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9134 from 'current_namespace.SlaveDeclSpace'.
9135 (namespace_declaration): Likewise.
9136 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9137 check. It can't happen now.
9138 * decl.cs (DeclSpace.LookupType): Likewise.
9139 * driver.cs (MainDriver): Sanity check.
9141 2006-08-01 Raja R Harinath <rharinath@novell.com>
9143 * decl.cs (DeclSpace.FindNestedType): Remove.
9144 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9145 LookupTypeContainer to get the container of the nested type.
9146 * class.cs (TypeContainer.FindNestedType): Make non-override.
9148 2006-07-31 Raja R Harinath <rharinath@novell.com>
9150 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9151 * class.cs (TypeContainer.PartialContainer): ... here.
9152 (TypeContainer.AddBasesForPart): New helper.
9153 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9155 * cs-parser.jay (current_class): Convert to DeclSpace.
9156 (struct_declaration, interface_declaration, class_declaration):
9157 Use AddBasesForPart instead of .Bases directly.
9158 * const.cs, iterators.cs: Update to changes.
9160 2006-07-28 Raja R Harinath <rharinath@novell.com>
9162 * class.cs (TypeContainer.AddMemberType): Rename from
9164 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9165 (AddTypeContainer): New. Combine AddClassOrStruct and
9167 (AddPartial): Update. Add 'is_partial' argument.
9168 * roottypes.cs: Update to changes.
9169 * cs-parser.jay (push_current_class): New helper for handling
9170 current_container and current_class.
9171 (struct_declaration, interface_declaration, class_declaration):
9174 2006-07-26 Raja R Harinath <rharinath@novell.com>
9176 * roottypes.cs: Rename from tree.cs.
9178 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9179 * tree.cs (Tree, ITreeDump): Remove types.
9180 * rootcontext.cs (tree, Tree): Remove fields.
9181 (root, ToplevelTypes): New.
9182 * *.cs: Update to rename.
9184 * tree.cs (Tree.RecordDecl): Remove.
9185 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9187 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9189 2006-07-23 Raja R Harinath <harinath@gmail.com>
9191 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9192 DoFlowAnalysis and OmitStructFlowAnalysis here.
9193 (ec.With): Rename from WithUnsafe and generalize.
9194 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9195 (ec.WithFlowAnalyis): New.
9196 * ecore.cs, expression.cs, statement.cs: Update.
9198 2006-07-22 Raja R Harinath <harinath@gmail.com>
9200 * statement.cs (Block.ResolveMeta): Simplify slightly.
9202 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9203 multiple boolean fields. Convert InUnsafe, constant_check_state,
9204 check_state to flags.
9205 (CheckState, ConstantCheckState): Update.
9206 (InUnsafe): New read-only property.
9207 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9209 (WithUnsafe): New helper similar to WithCheckState.
9210 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9211 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9213 2006-07-21 Raja R Harinath <rharinath@novell.com>
9215 Make comparisons use the same IL irrespective of whether they're
9216 in a 'checked' or 'unchecked' context: one of the issues in #78899
9217 * codegen.cs (EmitContext.CheckState): Make read-only property.
9218 (EmitContext.ConstantCheckState): Likewise.
9219 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9220 helper that implement a save/restore stack for CheckState
9221 values. This is the only way to change check-state.
9222 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9223 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9224 (CheckedExpr.EmitBranchable): New forwarding method.
9225 (UnCheckedExpr): Likewise.
9226 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9227 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9228 (Checked.Resolve, checked.DoEmit): Likewise.
9230 2006-07-20 Miguel de Icaza <miguel@novell.com>
9232 * anonymous.cs: Cache the resolved anonymous delegate, and return
9233 this so that the ResolveTopBlock is only triggered once, not
9236 Currently we trigger ResolvetopBlock twice due to a first pass of
9237 argument check compatibility, and a second pass that does the
9240 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9242 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9244 * rootcontext.cs (Reset): Add helper_classes.
9246 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9249 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9252 2006-07-13 Miguel de Icaza <miguel@novell.com>
9254 * statement.cs (Lock): Handle expressions of type
9255 TypeManager.null_type specially. Fixes #78770
9257 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9259 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9262 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9264 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9265 for accessors as well.
9266 * ecore.cs (EventExpr): Add AccessorTable.
9268 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9271 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9272 for CS0122 where appropriate.
9273 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9275 (Filter): Assembly can be null in the case of top level attributes.
9277 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9281 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9282 is done at global level.
9284 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9286 A fix for #77002, Implemented TypeForwarder support.
9288 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9289 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9290 * typemanager.cs (): Add type_forwarder_attr_type.
9292 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9294 * report.cs: Add CS0469 warning.
9296 2006-06-21 Martin Baulig <martin@ximian.com>
9298 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9299 the `try'-block, so we also report CS0016 etc. there.
9301 2006-06-21 Martin Baulig <martin@ximian.com>
9304 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9306 2006-06-21 Martin Baulig <martin@ximian.com>
9308 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9309 also report CS1686 for parameters.
9311 2006-06-21 Martin Baulig <martin@ximian.com>
9313 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9314 instead of an error if the value is not implicitly convertible to
9315 the switch types; fixes #77964.
9317 2006-06-21 Raja R Harinath <rharinath@novell.com>
9320 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9321 FieldBuilder is null.
9324 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9325 'left' and 'right' before error-checking.
9327 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9329 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9331 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9332 (FieldExpr.DoResolve): likewise.
9333 (PropertyExpr.InstanceResolve): likewise.
9334 (EventExpr.InstanceResolve): likewise.
9336 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9338 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9339 attribute applicable tests for attribute argument.
9341 2006-06-02 Raja R Harinath <rharinath@novell.com>
9344 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9345 (Binary.OverloadResolve_PredefinedIntegral): New.
9346 (Binary.OverloadResolve_PredefinedFloating): New.
9347 (Binary.OverloadResolve_PredefinedString): New.
9348 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9349 Follow the standard more closely, and treat numeric promotions in
9350 terms of overload resolution.
9351 (Binary.CheckShiftArguments): Simplify.
9353 2006-06-01 Raja R Harinath <rharinath@novell.com>
9355 * flowanalysis.cs (MyBitVector): Simplify representation.
9356 (MyBitVector.Clone): Avoid allocating BitArray.
9357 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9358 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9359 (*): Update. Change all references to MyBitVector.And and
9360 MyBitVector.Or to &= and |=.
9362 2006-05-29 Raja R Harinath <rharinath@novell.com>
9365 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9366 to param arguments too.
9368 2006-05-26 Miguel de Icaza <miguel@novell.com>
9370 * cs-parser.jay: Catch another parsing form for arglist being
9371 followed by other arguments. Fixes #78313.
9373 2006-05-24 Raja R Harinath <rharinath@novell.com>
9375 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9376 checking of out parameters to ...
9377 (FlowBranchingToplevel.Merge): ... here.
9378 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9379 set, propagate the origin upward, and only complain if there was
9381 (FlowBranchingException.AddContinueOrigin): Likewise.
9382 (FlowBranchingException.AddReturnOrigin): Likewise.
9383 (FlowBranchingException.AddGotoOrigin): Likewise.
9385 2006-05-23 Raja R Harinath <rharinath@novell.com>
9387 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9388 unreachable, skip it.
9389 (FlowBranchingException.Merge): Always propagate jumps, even if
9390 the finally block renders subsequent code unreachable.
9392 2006-05-18 Raja R Harinath <rharinath@novell.com>
9395 * statement.cs (Goto.Resolve): Move responsibility for resolving
9396 'goto' to FlowBranching.AddGotoOrigin.
9397 (Goto.SetResolvedTarget): New. Callback to set the
9398 LabeledStatement that's the target of the goto.
9399 (Goto.DoEmit): Use Leave instead of Br when crossing an
9400 unwind-protect boundary.
9401 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9402 LookupLabel and adjust to new semantics.
9403 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9404 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9405 Goto.SetResolvedTarget to update target.
9406 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9407 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9408 AddBreakOrigin & co. Delay propagation until ...
9409 (FlowBranchingException.Merge): ... this.
9411 * statement.cs (Block.Resolve): Always depend on flow-branching to
9412 determine unreachability. Kill workaround that originally emitted
9413 only one statement after an "unreachable" label (see infloop in
9416 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9417 This is still "wrong", but anything better would probably need a
9418 multi-pass algorithm.
9419 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9420 usage vector. Force current usage vector to be reachable, to
9421 optimistically signify backward jumps.
9422 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9424 (FlowBranchingLabeled.Merge): New. If no backward jump was
9425 detected, return the original salted-away usage vector instead,
9426 updated with appropriate changes. Print unreachable warning if
9428 * statement.cs (Block.Resolve): Don't print unreachable warning on
9429 a labeled statement.
9431 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9433 * driver.cs: Pass filename without path to AssemblyBuilder's
9434 AddResourceFile. Fixes bug #78407.
9436 2006-05-17 Raja R Harinath <rharinath@novell.com>
9438 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9439 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9440 (FlowBranching.MergeChild): Overwrite
9441 reachability information from Labeled branchings too.
9443 2006-05-16 Raja R Harinath <rharinath@novell.com>
9445 * statement.cs (Goto.Resolve): Merge jump origins here ...
9446 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9448 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9449 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9450 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9451 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9453 * statement.cs (Goto.Resolve): ... not here.
9454 (Goto.Emit): Remove CS1632 check.
9456 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9458 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9461 2006-05-11 Raja R Harinath <rharinath@novell.com>
9463 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9464 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9465 (FlowBranchingException.Label): Likewise.
9467 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9469 (MyBitVector.Or): Use it to avoid losing information (Count).
9470 (FlowBranching.MergeOrigins): Likewise.
9472 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9473 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9474 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9475 (UsageVector.ToString): Simplify.
9476 (UsageVector.MergeSiblings): Move here from ...
9477 (FlowBranching.Merge): ... here.
9478 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9481 2006-05-10 Raja R Harinath <rharinath@novell.com>
9483 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9484 null bitvector is treated as all-true.
9486 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9487 (MyBitVector): Rationalize invariants. 'vector != null' implies
9488 that we have our own copy of the bitvector. Otherwise,
9489 'InheritsFrom == null' implies all inherited bits are true.
9491 2006-05-09 Marek Safar <marek.safar@seznam.cz>
9493 * statement.cs (LocalInfo): Add IsConstant.
9494 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
9495 local variable for constants.
9497 2006-05-09 Raja R Harinath <rharinath@novell.com>
9499 * flowanalysis.cs (MyBitVector.Empty): New.
9500 (MyBitVector): Don't allow InheritedFrom to be null.
9501 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
9502 (UsageVector, FlowBranching): Update to changes.
9504 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
9505 recursion. The 'Parent == null' condition isn't sufficient for
9507 (FlowBranching.AddBreakOrigin): Likewise.
9508 (FlowBranching.AddContinueOrigin): Likewise.
9509 (FlowBranching.AddReturnOrigin): Likewise.
9510 (FlowBranching.StealFinallyClauses): Likewise.
9511 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
9512 (FlowBranching.CheckOutParameters): Likewise.
9513 (FlowBranchingToplevel): Terminate all the above recursions here.
9514 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
9515 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
9517 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
9519 (FlowBranchingToplevel): New. Empty for now.
9520 (FlowBranching.MergeTopBlock): Update.
9521 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
9522 branching for the anonymous delegate.
9523 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
9525 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
9526 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
9527 information at the start of the merge. Reorganize.
9529 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9531 * class.cs (MethodData.Define): Method cannot implement interface accessor.
9533 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9535 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
9536 to newly introduced ctor.
9538 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
9539 message to one place.
9540 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
9543 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9545 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
9547 * ecore.cs (Expression.ResolveAsConstant): Updated.
9549 * statement.cs (ResolveMeta): Updated.
9551 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9553 * cs-parser.jay: __arglist cannot be used in initializer.
9555 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9558 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
9561 2006-05-05 Raja R Harinath <rharinath@novell.com>
9563 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
9564 (LabeledStatement): Add 'name' parameter.
9565 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
9566 (Block.AddLabel): Update to changes.
9567 * cs-parser.jay (labeled_statement): Likewise.
9569 * flowanalysis.cs (BranchingType.Labeled): New.
9570 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
9571 (FlowBranchingLabeled): New. Does nothing for now, but will
9572 eventually handle 'goto' flows.
9573 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
9574 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
9575 that's terminated ...
9576 (Block.Resolve): ... here.
9578 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
9579 (UsageVector.MergeFinallyOrigins): Likewise.
9580 (FlowBranching.InTryOrCatch): Likewise.
9581 (FlowBranching.AddFinallyVector): Likewise.
9582 (FlowBranchingException): Update to changes.
9585 * statement.cs (Return.Resolve): Move error checking to ...
9586 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
9587 (FlowBranchingException): Handle return origins like break and
9589 (FlowBranching.UsageVector.CheckOutParameters): Remove.
9591 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9594 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
9597 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9600 * class.cs (MethodData.Define): Do public accessor check only when method
9601 implements an interface.
9603 2006-05-04 Raja R Harinath <rharinath@novell.com>
9605 Remove special handling of 'break'
9606 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
9607 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
9608 (UsageVector.Break): Remove.
9609 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
9611 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
9613 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
9614 UsageVector.Breaks (). Don't set NeedsReturnLabel.
9616 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9619 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
9620 be the interface member.
9622 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9625 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
9626 for emitting small (int) values.
9628 2006-05-03 Raja R Harinath <rharinath@novell.com>
9631 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
9632 control-flow passes through the 'finally' after merging-in all the
9633 control-flows from 'try' and the 'catch' clauses.
9635 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
9636 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
9637 always true at the only non-recursive entry point.
9638 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
9639 FlowBranchingBreakable.
9640 (FlowBranchingLoop): Remove.
9641 * statement.cs (Return.DoResolve): Update to changes.
9644 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
9645 (FlowBranching.CreateBranching): Handle it: create a
9646 FlowBranchingContinuable.
9647 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
9648 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
9649 except that it handles the 'continue' command.
9650 (FlowBranching.UsageVector.MergeOrigins): Rename from
9652 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
9653 except that it overrides AddContinueOrigin.
9654 (FlowBranchingException): Override AddContinueOrigin, similar to
9656 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
9657 Create a new branching around the embedded statement.
9658 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
9659 control flow after the embedded statement.
9660 (Continue.Resolve): Move all error checking to AddContinueOrigin.
9662 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
9663 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
9664 FlowBranchingBreakable.
9665 (FlowBranchingSwitch): Remove.
9668 * statement.cs (Break.Resolve): Simplify. Move responsibility for
9669 error reporting to ...
9670 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
9671 Rename from 'AddBreakVector'. Add new location argument. Return
9672 a bool indicating whether the 'break' crosses an unwind-protect.
9673 (FlowBranchingException.AddBreakOrigin): Add.
9674 (FlowBranchingException.Merge): Propagate 'break's to surrounding
9675 flowbranching after updating with the effects of the 'finally'
9677 (FlowBranchingBreakable): New common base class for
9678 FlowBranchingLoop and FlowBranchingSwitch.
9680 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
9682 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
9684 2006-05-02 Raja R Harinath <rharinath@novell.com>
9686 * statement.cs (Do.Resolve): If the loop is infinite, set the
9688 (While.Resolve, For.Resolve): Set a barrier after the embedded
9689 statement. There's no direct control flow that goes from the end
9690 of the embedded statement to the end of the loop.
9691 * flowanalysis.cs (FlowBranching.Infinite): Remove.
9692 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
9693 above ensure that the reachability is correctly computed.
9695 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
9696 (UsageVector.MergeBreakOrigins): If the current path is
9697 unreachable, treat it as if all parameters/locals are initialized.
9698 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
9699 infinite loops before merging-in break origins.
9701 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
9702 (Reachability.Reachable): Split part into ...
9703 (Reachability.Unreachable): ... this. Simplify.
9704 (Reachability.IsUnreachable): Use 'Unreachable' instead.
9706 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
9707 (Reachability.SetThrowsSometimes): Likewise.
9708 (FlowBranchingBlock.MergeTopBlock): Don't compare against
9709 TriState.Always, use corresponding property.
9710 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
9711 (Block.Resolve): Likewise. Remove some redundant checks.
9713 2006-05-02 Raja R Harinath <harinath@gmail.com>
9715 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
9716 (Reachability.Meet): Don't bother checking AlwaysThrows --
9717 barrier is always set.
9718 (FlowBranchingBlock.Merge): Likewise.
9720 2006-05-01 Raja R Harinath <harinath@gmail.com>
9722 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
9723 checks for unreachable.
9725 2006-05-01 Marek Safar <marek.safar@seznam.cz>
9728 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
9730 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
9731 whether field is really assigned.
9733 2006-04-30 Raja R Harinath <harinath@gmail.com>
9735 * flowanalysis.cs (Reachability): Make 4-argument constructor
9737 (Reachability.Meet): Rename from 'And'. Remove static variant.
9738 (Reachability.Always): Rename from the highly misleading
9739 'Reachability.Never'.
9740 (FlowBranching.Merge): Update to changes. Mark an impossible
9741 situation with a 'throw'.
9742 (*): Update to changes.
9744 2006-04-29 Raja R Harinath <harinath@gmail.com>
9746 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
9748 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
9749 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
9750 (*): Update to changes.
9751 * statement.cs: Update to changes.
9753 2006-04-28 Marek Safar <marek.safar@seznam.cz>
9756 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
9758 2006-04-28 Raja R Harinath <harinath@gmail.com>
9760 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
9763 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
9764 argument to two arguments: an usage-vector and a bool. Move call
9765 to FlowBranching.Merge () ...
9766 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
9768 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
9769 handling of loop and switch reachability to ...
9770 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
9772 2006-04-27 Raja R Harinath <harinath@gmail.com>
9774 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
9775 handling to FlowBranchingLoop.InLoop.
9776 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
9778 2006-04-26 Marek Safar <marek.safar@seznam.cz>
9781 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
9782 anonymous method is allowed from AnonymousContainer here.
9784 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
9786 2006-04-24 Raja R Harinath <rharinath@novell.com>
9789 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
9791 2006-04-23 Marek Safar <marek.safar@seznam.cz>
9794 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
9795 (DoubleConstant.Reduce): Ditto.
9797 2006-04-23 Raja R Harinath <rharinath@novell.com>
9799 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
9800 Remove 'lvalue_right_side' argument. Move parts to ...
9801 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
9802 (LocalVariable.DoResolveLValue): ... these.
9804 2006-04-21 Raja R Harinath <rharinath@novell.com>
9807 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
9808 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
9809 (LocalVariableReference.DoResolveBase): Use it to implement new
9811 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
9812 (Argument.Resolve): Simplify. Move CS1510 check ...
9813 * ecore.cs (Expression.ResolveLValue): ... here.
9814 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
9815 (PropertyExpr.DoResolveLValue): Likewise.
9816 (FieldExpr.Report_AssignToReadonly): Likewise.
9817 (FieldExpr.DoResolve): Add 'out_access' argument. Use
9818 LValueMemberAccess or LValueMemberOutAccess on instance depending
9820 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
9821 DoResolve as appropriate.
9823 2006-04-20 Raja R Harinath <rharinath@novell.com>
9826 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
9827 implicit conversions on 'out' and 'ref' arguments.
9829 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
9830 improve clarity. Remove dead code.
9833 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
9834 (Catch.Resolve): Resolve VarBlock if it exists.
9836 2006-04-19 Miguel de Icaza <miguel@novell.com>
9838 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
9839 twice, this was some residual code, the enumerator was emitted
9840 properly in the two branche of if later.
9842 2006-04-19 Raja R Harinath <rharinath@novell.com>
9844 * expression.cs (Cast.ResolveLValue): Remove. The result of a
9845 cast is never an lvalue.
9846 (Cast.DoResolve, Cast.ResolveRest): Combine.
9847 (Argument.Emit): Simplify slightly. Move 'Expr is
9848 IMemoryLocation' check ...
9849 (Argument.Resolve): ... here.
9850 (Argument.Error_LValueRequired): Remove. Inline into only user.
9852 Simplifications. Fix cs0191-2.cs
9853 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
9854 CS1649 and CS1651 to ...
9855 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
9856 the actual selection of the error code and message to a lookup
9857 table. Add a dummy return value to simplify callsites.
9858 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
9859 readonly fields of other instances of the same type. Move CS0197
9861 * expression.cs (Argument.Resolve): ... here. Simplify code.
9862 Ensure that ec.InRefOutArgumentResolving is only set during LValue
9863 resolution of an out or ref argument. The code simplification
9864 above uses this invariant.
9866 2006-04-18 Raja R Harinath <rharinath@novell.com>
9868 Possibly fix #77752. Fix cs1690-[4-7].cs.
9869 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
9870 CheckMarshallByRefAccess. Drop parameter.
9871 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
9873 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
9875 * report.cs (AllWarnings): Add CS1690.
9876 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
9878 (LocalVariableReference.DoResolveBase): Update.
9880 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9882 * class.cs (MethodOrOperator): Moved common parts from method class.
9883 detect obsolete attributes.
9884 (Method.Define): Simplified as it reuses code from base.
9885 (Constructor.ValidAttributeTargets): Fixed issue found during
9887 (Destructor.ValidAttributeTargets): Fixed issue found during
9889 (Operator): Finished refactoring set off by #78020. Operator class is now
9890 ordinary method class.
9892 * anonymous.cs: Updated.
9894 * decl.cs (DeclSpace): Add IsGeneric
9896 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9898 * class.cs (Constructor.Emit): Don't emit the attributes twice.
9900 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9902 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
9903 detect obsolete attributes.
9904 (Method.CreateEmitContext): Moved to MethodOrOperator.
9906 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9909 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
9910 customized exception to make crash detection easier.
9911 (MethodOrOperator): Started to work on new base class for methods and
9913 (Method): Derives from MethodOrOperator.
9914 (Constructor.Emit): Emits its own attributes.
9915 (AbstractPropertyEventMethod.Emit): Ditto.
9916 (Operator): Derives from MethodOrOperator, will refactor fully in extra
9918 (Operator.Emit): It's temporary more tricky than should be.
9920 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
9922 * report.cs (InternalErrorException): Add ctor with inner exception.
9924 2006-04-08 Marek Safar <marek.safar@seznam.cz>
9927 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
9930 2006-04-07 Marek Safar <marek.safar@seznam.cz>
9933 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
9936 2006-04-06 Marek Safar <marek.safar@seznam.cz>
9938 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
9939 attribute is present and Guid not.
9940 (Interface.ApplyAttributeBuilder): Ditto.
9942 * attribute.cs: Add error message.
9944 2006-04-06 Marek Safar <marek.safar@seznam.cz>
9948 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
9949 sources (it's composite) so hold them in extra array as they are used in
9950 Emit phase only. It worked in the previous versions by mistake.
9951 (Attribute.Emit): Emit attribute for more owners when exist.
9953 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
9954 it has now different behaviour.
9956 2006-04-04 Marek Safar <marek.safar@seznam.cz>
9958 * constant.cs (Constant.IsDefaultInitializer): New method.
9960 * class.cs: Updated.
9962 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
9963 re-initialize default values. It saves KBs almost for every assembly.
9964 Thanks Zoltan for the idea.
9965 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
9966 (ArrayCreation.DoResolve): Resolve only once.
9967 (ArrayCreation.Emit): Emit static initializer only when it is faster.
9968 (ArrayCreation.GetAttributableValue): Cope with optimized values.
9970 2006-04-03 Zoltan Varga <vargaz@gmail.com>
9972 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
9975 2006-04-01 Marek Safar <marek.safar@seznam.cz>
9977 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
9978 in an embedded statement too.
9980 2006-04-01 Raja R Harinath <rharinath@novell.com>
9983 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
9985 2006-04-01 Marek Safar <marek.safar@seznam.cz>
9989 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
9992 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
9994 2006-03-31 Marek Safar <marek.safar@seznam.cz>
9996 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
9999 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10000 LocalTemporary change.
10002 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10004 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10005 initializers optimization.
10006 (ClassOrStruct.TypeAttr): Moved from modifiers.
10007 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10008 (FieldBase.ResolveInitializer): Resolves initializer.
10009 (FieldBase.HasDefaultInitializer): New property.
10011 * cs-parser.jay: Removed message.
10013 * expression.cs (CompilerGeneratedThis): New specialization.
10015 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10017 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10019 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10021 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10023 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10024 be now EnumConstants only.
10026 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10028 * attribute.cs, driver.cs: Reset more caches.
10030 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10032 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10034 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10036 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10037 for easier reuse. Updated all overrides.
10038 (IntegralConstant): New base class for all integral constants.
10039 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10040 of the constant range, report custom error.
10041 (UIntConstant.Reduce): Fixed uint conversion.
10043 * ecore.cs, literal.cs: Reduce updates.
10045 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10049 * class.cs (Constructor.Define): Removed extra if for default ctors.
10050 A patch from Atsushi Enomoto.
10052 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10054 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10055 GetAttributableValue.
10057 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10060 * convert.cs (ImplicitConversionRequired): Error message moved to
10063 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10064 automatic implicit conversion of an output value.
10065 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10067 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10069 (TypeOf.GetAttributableValue): Add extra handling for object type.
10071 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10072 special error message.
10074 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10076 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10078 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10079 compatible with MS runtime.
10081 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10083 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10084 attribute arguments here.
10086 * class.cs (Indexer.Define): The check was moved to attribute class.
10088 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10090 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10091 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10094 2006-03-22 Raja R Harinath <rharinath@novell.com>
10096 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10097 mcs to keep code differences small.
10098 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10099 * typemanager.cs (parameter_default_value_attribute_type): New.
10100 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10103 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10105 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10107 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10109 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10111 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10114 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10116 * doc-bootstrap.cs : fix build.
10118 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10120 * expression.cs (StringConcat.Append): Issue a warning when empty string
10121 is going to append.
10123 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10125 * assign.cs (CompoundAssign.ResolveSource): Removed.
10127 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10130 * class.cs (TypeContainer.FindMethods): Removed.
10131 (TypeContainer.CheckMemberUsage): Made static.
10133 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10135 * constant.cs (CheckRange): Removed unused type argument.
10136 (CheckUnsigned): Removed unused type argument.
10138 * cs-parser.jay: Updated after MemberAccess clean up.
10139 Uses Length for empty string test.
10141 * cs-tokenizer.cs: Uses Length for empty string test.
10142 (IsCastToken): Made static.
10143 (is_hex): Made static.
10144 (real_type_suffix): Made static.
10146 * decl.cs (SetupCache): Made static.
10147 (OnGenerateDocComment): Removed unused ds argument.
10149 * delegate.cs (VerifyDelegate): Removed unused argument.
10151 * doc.cs: Uses Length for empty string test.
10153 * driver.cs: Uses Length for empty string test.
10155 * enum.cs (IsValidEnumType): Made static
10157 * expression.cs (EnumLiftUp): Removed unused argument.
10158 (ResolveMethodGroup): Ditto.
10159 (BetterConversion): Ditto.
10160 (GetVarargsTypes): Ditto.
10161 (UpdateIndices): Ditto.
10162 (ValidateInitializers): Ditto.
10163 (MemberAccess.ctor): Ditto.
10164 (GetIndexersForType): Ditto.
10166 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10168 * iterators.cs: Updated after MemberAccess clean up.
10170 * location.cs: Uses Length for empty string test.
10172 * namespace.cs: Uses Length for empty string test.
10174 * report.cs (CheckWarningCode): Made static.
10176 * statement.cs (LabeledStatement): Removed unused argument.
10178 * typemanager.cs (FilterNone): Removed.
10180 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10182 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10185 * class.cs: Updated.
10187 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10189 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10191 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10195 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10196 reporting, it's more tricky than I thought.
10198 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10202 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10204 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10205 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10206 Add more error reporting; Fixed issue with params.
10208 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10210 * cs-parser.jay: AnonymousMethod requires host container.
10212 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10214 2006-03-18 Raja R Harinath <harinath@gmail.com>
10216 * class.cs: Change 'TypeContainer ds' constructor argument to
10217 'DeclSpace parent'. Some classes were missed below due to
10218 different naming convention.
10220 * class.cs (MemberCore.Parent): Delete. This makes the
10221 ParentContainer changes below enforceable by the compiler.
10223 Treat pointers to enclosing declaration space as 'DeclSpace', not
10225 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10226 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10228 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10230 (Block.AddThisVariable): Likewise.
10231 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10232 (AbstractPropertyEventMethod.Emit): Likewise.
10233 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10234 (GetMethod.Define, SetMethod.Define): Likewise.
10235 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10236 (DelegateMethod.EmitMethod): Likewise.
10238 Fix regression test-partial-13.cs.
10239 Rationalize use of PartialContainer. Ensure that the partial
10240 class semantics can be tied to type-correctness, i.e., any
10241 violation will cause a compile error.
10242 * class.cs, const.cs: Access all fields that belong to class
10243 TypeContainer via ParentContainer. Arguments of EmitContexts and
10244 Resolve()-like functions still use 'Parent'.
10246 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10247 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10248 (PropertyMethod.CheckModifiers): Remove unused argument.
10249 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10252 2006-03-17 Raja R Harinath <harinath@gmail.com>
10254 Make semantics of PartialContainer simpler.
10255 * decl.cs (DeclSpace.IsPartial): Remove.
10256 * class.cs (TypeContainer.IsPartial): Likewise.
10257 (TypeContainer..ctor): Set PartialContainer to point to self.
10258 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10259 (TypeContainer.FindNestedType): Likewise.
10260 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10262 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10264 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10266 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10268 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10271 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10273 * class.cs (Operator.Define): An error for base conversion was not
10274 reported correctly.
10276 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10278 * iterator.cs : yield break is allowed in try statement which has
10279 catch clauses. Fixed bug #77767.
10281 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10283 A fix for #77593, #77574.
10285 * class.cs (MethodCore.CheckBase): Another if for operator.
10287 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10289 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10292 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10293 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10296 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10299 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10300 Updated after another emitcontext usage was clean up. It should help us to
10301 synchronize with gmcs easier.
10303 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10307 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10308 (Event.Define): ditto
10309 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10311 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10312 Removed redundant code and set NewSlot for Invoke method too.
10314 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10315 (Parameters.MergeGenerated): New method. Use this method when you merge
10316 compiler generated argument with user arguments.
10318 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10320 * attribute.cs (ResolveAsTypeTerminal): Removed.
10322 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10323 specialization for predefined types; 30% speed up.
10324 Finally placed obsolete check to right place.
10325 (Expression.ResolveType): Removed.
10327 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10328 Updated after ResolveType was removed.
10330 * expression.cs (Cast.ctor): Check void cast.
10331 (Binary.ResolveAsTypeTerminal): Is never type.
10332 (Conditional.ResolveAsTypeTerminal): Is never type.
10334 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10336 2006-03-01 Raja R Harinath <rharinath@novell.com>
10339 * expression.cs (ParameterReference.DoResolveBase): Change return
10341 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10345 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10348 * typemanager.cs (GetFullNameSignature): Don't nullref on
10349 protected accessors.
10351 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10353 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10354 these two separated members to simplify the code.
10355 (Attribute.Resolve): Refactored to use new fields and methods.
10356 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10357 implemented obsolete attribute checking.
10358 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10359 implemented obsolete checking again. It look line never ending quest ;-)
10360 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10362 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10364 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10366 *class.cs (Property.Define): Add RegisterProperty call.
10368 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10369 argument groups (only 2).
10371 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10372 encoding expression to arguments.
10373 (Expression.ExprClassToResolveFlags): Just turned to property.
10375 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10376 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10377 optimized as well as implemented support for zero-length attributes.
10379 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10380 Add caching of PropertyInfo's.
10382 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10384 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10385 error multiple times.
10387 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10389 New partial class implementation.
10390 A fix for #77027, #77029, #77403
10392 * attribute.cs (Attributable): Made attributes protected.
10394 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10395 the replacements of ClassPart and PartialContainer.
10396 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10397 (TypeContainer.AddInterface): Ditto.
10398 (TypeContainer.AddPartial): The main method for partial classes. It checks
10399 for errors and merges ModFlags and attributes. At the end class is added to
10400 partial_parts list.
10401 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10403 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10404 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10405 from the rest of partial classes.
10406 (TypeContainer.GetClassBases): Simplified.
10407 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10409 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10410 (TypeContainer.HasExplicitLayout): Uses Flags now.
10411 (PartialContainer): Removed.
10412 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10413 (StaticClass): Was merged with Class.
10414 (Class.GetClassBases): class and static class bases are verified here.
10415 (Class.TypeAttr): Added static attributes when class is static.
10416 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10417 (MemberBase): In some cases we need to call parent container for partial
10418 class. It should be eliminated but it's not easy now.
10420 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10422 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10423 partial classed to accumulate class comments.
10424 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10426 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10428 * driver.cs (MainDriver): Tree.GetDecl was removed.
10430 * modifiers.cs (Modifiers): Add partial modifier.
10432 * tree.cs (Tree.decl): Removed.
10433 (RootTypes): Started to use this class more often for root types
10436 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10440 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10441 external interface does not have an attribute.
10443 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10445 Another prerequisites for new partial classs implementation.
10447 * attribute.cs (Attribute.Equal): Implemented.
10448 (Attribute.Emit): Changed as attributes can be applied more than twice.
10449 (Attributes.Emit): Check for duplicate attributes here.
10451 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10452 as a parameter, clean-up.
10454 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10458 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10459 contains obsolete attribute check which can in some cases look for base
10460 type of current class which is not initialized yet.
10461 (TypeContainer.BaseType): Replacement of ptype.
10463 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10465 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10467 First of prerequisites for new partial classs implemention.
10469 * attribute.cs (Attributable): Extended by ResolveContext;
10470 Attributes finally have correct context for resolving in all cases.
10471 (AttachTo): Attribute owner is assigned here.
10473 * codegen.cs (IResolveContext): Introduce new interface to hold
10474 all information needed in resolving phase.
10475 (EmitContext): Implements IResolveContext; more clean-up needed here.
10477 * decl.cs (MemberCore): Implemented IResolveContext.
10479 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10480 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10481 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10482 Refactored to use new IResolveContext instead of EmitContext; cleanup
10484 2006-02-06 Miguel de Icaza <miguel@novell.com>
10486 * codegen.cs (EmitScopeInitFromBlock): check here the
10487 capture_context, there is no need to make two calls to the
10490 * anonymous.cs: Add some debugging messages that might help me
10491 track other instances of this problem in the future (the
10492 regression of test 467).
10494 * cs-parser.jay: track the variable block, as we need to initalize
10495 any captured variables declared in this block for the "catch"
10496 portion of the "Try" statement.
10498 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
10499 scope initialization for captured variables.
10501 Also, move the emit for the variables after the block location has
10504 2006-02-06 Marek Safar <marek.safar@seznam.cz>
10506 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
10508 2006-02-02 Miguel de Icaza <miguel@novell.com>
10510 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
10511 commit yesterday, the initialization for the roots is necessary.
10512 What is not necessary is the scope activation.
10514 2006-02-02 Raja R Harinath <rharinath@novell.com>
10516 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
10517 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
10519 (Argument.Resolve): Remove CS0206 checks.
10521 2006-02-01 Miguel de Icaza <miguel@novell.com>
10523 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
10524 scopes for all the roots, the scopes will now be emitted when the
10525 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
10527 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
10528 code. This reduces a lot of existing cruft.
10530 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
10531 that the ScopeInfo is generated as we enter the scope, not at the
10532 time of use, which is what we used to do before.
10534 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
10535 every time a Block is about to be emitted if we have a
10538 2006-02-01 Raja R Harinath <rharinath@novell.com>
10540 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
10542 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
10544 * typemanager.cs (cons_param_array_attribute): Make private.
10545 (Reset): Set it to null.
10546 (InitCoreHelpers): Don't initialize it.
10547 (ConsParamArrayAttribute): New. Initialize it as needed.
10548 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
10550 2006-01-31 Miguel de Icaza <miguel@novell.com>
10552 * expression.cs: There might be errors reported during the
10553 selection of applicable methods. If there are errors, do not
10554 continue execution as it will lead the compiler to crash.
10556 2006-01-30 Miguel de Icaza <miguel@novell.com>
10558 * expression.cs: Member access is not allowed on anonymous
10559 methods. Fixes #77402.
10561 2006-01-30 Raja R Harinath <rharinath@novell.com>
10564 * cs-parser.jay (VariableDeclaration): Don't set
10565 current_array_type to null.
10566 (field_declaration, event_declaration, declaration_statement):
10567 Set it to null here.
10569 2006-01-28 Raja R Harinath <harinath@gmail.com>
10571 * typemanager.cs (GenericParameterPosition): New.
10574 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
10576 * doc.cs : To process "include" elements, first we should create
10577 another list than XmlNodeList, because it could result in node
10578 removal, which could result in that the XmlNodeList gives up
10579 yielding next node.
10581 (Also made code identical to gmcs again.)
10583 2006-01-25 Miguel de Icaza <miguel@novell.com>
10585 * ecore.cs: Introduce an error report that we were not catching
10586 before, if not silent, we must report the error. Gonzalo ran into
10589 2006-01-23 Miguel de Icaza <miguel@novell.com>
10591 A fix for bug: #76957
10593 * iterators.cs (MoveNextMethod.CreateMethodHost): call
10594 ComputeMethodHost before creating the method, this is a new
10597 * anonymous.cs (AnonymousContainer): Now we track all the scopes
10598 that this method references (RegisterScope). The actual scope
10599 where the method is hosted is computed with the ComputeMethodHost
10600 before we create the method.
10602 Moved the Deepest routine here.
10604 (AnonymousContainer.ComputeMethodHost): New routine used to
10605 compute the proper ScopeInfo that will host the anonymous method.
10607 (ScopeInfo): Deal with multiple roots. The problem was that we
10608 did not have a unique root where all ScopeInfos could be hanged
10609 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
10612 Remove AdjustMethodScope which is now computed at the end. Remove
10613 LinkScope which did a partial link, instead link all ScopeInfos
10614 before code generation from the new "LinkScopes" routine.
10616 Simplify all the Add* routines as they no longer need to maintain
10617 the tree, they just need to record that they are using variables
10620 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
10621 routines to produce the forest of ScopeInfo trees.
10623 * class.cs (TypeContainer.AppendMethod): This is just like
10624 AddMethod, but ensures that an interface implementation method
10625 (IEnumerable.XXX) is not inserted at the beginning of the queue of
10626 methods, but at the end.
10628 We use this functionality to ensure that the generated MoveNext
10629 method in the iterator class is resolved/emitted before the
10630 enumerator methods created.
10632 This is required because the MoveNext method computes the right
10633 ScopeInfo for the method. And the other methods will eventually
10634 need to resolve and fetch information computed from the anonymous
10637 2006-01-21 Raja R Harinath <harinath@gmail.com>
10638 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10640 Fix rest of #76995.
10641 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
10642 the 'aliases' hash.
10643 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
10644 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
10646 2006-01-18 Raja R Harinath <rharinath@novell.com>
10648 Fix #76656, cs0231-2.cs.
10649 * cs-parser.jay (formal_parameter_list): Make error case catch
10651 (parenthesized_expression_0): Add CS1026 check.
10652 (invocation_expression): Remove unused { $$ = lexer.Location }.
10654 2006-01-17 Raja R Harinath <rharinath@novell.com>
10657 * cs-parser.jay (statement_expression): Don't list out the
10658 individual statement-expressions. Convert syntax error into
10661 2006-01-16 Raja R Harinath <rharinath@novell.com>
10664 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
10665 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
10666 CheckIntermediateModification.
10667 (FieldExpr.DoResolve): Add new two-argument version that
10668 allows us to resolve the InstanceExpression as an lvalue.
10669 The one-argument variant is now just a wrapper.
10670 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
10671 Resolve the lhs as an lvalue if the it has a value type.
10672 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
10673 from Assign.DoResolve.
10674 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
10675 resolved as an lvalue.
10676 (PropertyExpr.DoResolve): Update.
10677 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
10678 has a value type. Move CS1612 check here from
10679 CheckIntermediateModification.
10680 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
10681 * expression.cs (EmptyExpression.OutAccess): New. Used as the
10682 'right_side' of a ResolveLValue on an 'out' argument.
10683 (EmptyExpression.LValueMemberAccess): New. Used as the
10684 'right_side' of a propagated ResolveLValue on a value type.
10685 (LocalVariableReference.DoResolveBase): Recognize
10686 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
10688 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
10689 EmptyExpression.Null.
10691 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
10693 * typemanager.cs : added IsGenericParameter(). In mcs it always
10695 * doc.cs : for generic parameters, use GenericParameterPosition,
10698 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
10700 * expression.cs: Fix Console.WriteLine ((this = x).foo);
10702 2006-01-12 Miguel de Icaza <miguel@novell.com>
10704 This fixes the problem where we used ldfld instead of ldflda to
10705 load the "THIS" pointer on captured parameters, when THIS is a
10706 value type. See bug #77205.
10708 * iterators.cs (CapturedThisReference.Emit): Pass false to
10709 EmitThis (we do not need the address).
10711 * codegen.cs (EmitThis): it needs to know whether we need the
10712 address of `this' or not. This is used by value types.
10714 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
10715 every other call passes false.
10717 2006-01-12 Raja R Harinath <rharinath@novell.com>
10720 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
10722 * expression.cs (Invocation.OverloadResolve): Update.
10723 (Invocation.DoResolve): Avoid double resolution of invocation.
10725 2006-01-11 Raja R Harinath <rharinath@novell.com>
10728 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
10729 unary negation of floating point types as 0-expr; negation cannot
10730 overflow in floating point types.
10733 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
10734 on operands of 'void' type.
10737 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
10738 and ExclusiveOr for boolean constants too.
10740 2006-01-09 Raja R Harinath <rharinath@novell.com>
10743 * expression.cs (Invocation.OverloadResolve): Replace reflected
10744 override methods with their base virtual methods, rather than
10745 skipping over them.
10746 * typemanager.cs (TypeManager.GetOverride): New.
10748 2006-01-05 Jb Evain <jbevain@gmail.com>
10750 * class.cs (Property.Define, Indexer.Define): do not tag the
10751 properties as SpecialName | RTSpecialName.
10753 2006-01-04 Miguel de Icaza <miguel@novell.com>
10755 * class.cs (MethodCore.IsDuplicateImplementation): This method was
10756 doing a low-level comparission of parameter types. It was lacking
10757 a check for __argslist.
10759 2005-12-30 Miguel de Icaza <miguel@novell.com>
10761 * expression.cs (ParameterReference.DoResolveBase): Allow
10762 reference parameters if they are local to this block.
10764 This allows the ref and out parameters of a delegate to be used in
10765 an anonymous method, for example:
10767 delegate void set (out int x);
10769 set s = delegate (out int x){
10773 This is used by functionality introduced late in the C# language.
10775 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
10776 method that take ref and out parameters.
10778 Fixes #77119 which was a late change in the spec.
10780 2005-12-23 Miguel de Icaza <miguel@novell.com>
10782 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
10783 parent if its the same scope. Fixes #77060.
10785 2005-12-21 Miguel de Icaza <miguel@novell.com>
10787 * driver.cs: Report the case of no source files and no -out:
10790 2005-12-20 Raja R Harinath <rharinath@novell.com>
10793 * expression.cs (ComposedCast.GetSignatureForError): Define.
10795 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10799 * namespace.cs (NamespaceEntry): Add extern_aliases as a
10800 ListDictionary, to contain the ExternAliasEntry entries (in
10801 addition to the NamespaceEntry.aliases hashtable). This field is
10802 shared between the original entry and its doppelganger (bodyless
10804 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
10805 extern_aliases field.
10806 (NamespaceEntry.Lookup): Move the IsImplicit check after the
10807 lookup in extern_aliases.
10809 2005-12-16 Raja R Harinath <rharinath@novell.com>
10812 * class.cs (TypeContainer.Mark_HasEquals): New.
10813 (TypeContainer.Mark_HasGetHashCode): New.
10814 (ClassPart): Override them.
10815 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
10818 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
10819 'parent' argument to the base constructor.
10821 Remove all mention of TypeContainer from decl.cs.
10822 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
10823 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
10824 (DeclSpace.DeclSpace): Likewise.
10825 (DeclSpace.DefineMembers): Remove unused argument.
10826 * cs-parser.jay (pop_current_class): Update to changes. Simplify
10827 debugging check -- we don't care if the debug code throws an
10828 InvalidCastException instead of an InternalErrorException.
10829 * class.cs (TypeContainer.DefineMembers): Update to changes.
10830 (TypeContainer.DoDefineMembers): Likewise.
10831 (TypeContainer.GetMethods): Likewise.
10832 (PropertyMember.Define): Likewise.
10833 (MemberBase.Parent): New property that forwards to
10834 MemberCore.Parent, but ensures that we get a TypeContainer.
10835 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
10836 (RootContext.PopulateTypes): Likewise. Remove special case code
10837 for !RootContext.StdLib: DefineMembers is idempotent.
10839 2005-12-14 Miguel de Icaza <miguel@novell.com>
10841 * convert.cs (ExplicitConversionCore): Check the return value from
10842 ExplicitConversionCore which can return null on failure. Fixes #76914
10844 2005-12-13 Marek Safar <marek.safar@seznam.cz>
10846 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
10848 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
10850 * doc.cs : The search for referenced namespace was insufficient to
10851 get global one as it used to do. Fixed bug #76965.
10853 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
10855 * doc.cs : check name in cref in the last phase that whether it is
10858 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10860 * cs-tokenizer.cs : reverted the latest change: it somehow broke
10863 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10865 * doc.cs : so it turned out that we cannot skip override check for
10866 interface members. Fixed bug #76954.
10868 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10870 * cs-tokenizer.cs : fixed bug #75984:
10871 - #warning and #error should not be handled when the source line
10873 - #line is not checked strictly when the source line is disabled.
10874 - #define and #undef is on the other hand checked strictly at any
10877 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
10879 * cs-tokenizer.cs : missing Location (actually, filename) in one of
10882 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10884 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
10886 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
10887 event initializers.
10888 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
10889 (FieldBase.Initializer): Initializer is now optional.
10890 (EventField.Define): Only event field can have initializer.
10892 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
10894 * const.cs (Const): Reuse initializer.
10896 * cs-parser.jay: Updated after FieldBase changes.
10897 Added current_array_type to simplify array initializers.
10899 * ecore.cs (NullCast.IsDefaultValue): Implemented.
10901 * expression.cs, iterators.cs: Updated.
10903 * namespace.cs (NamespaceEntry): Made UsingFound private.
10905 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10907 * parameterCollection.cs: Obsolete, removed.
10908 * parser.cs: Obsolete, removed.
10910 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10913 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
10915 * enum.cs (Enum.Define): Set obsolete context here.
10917 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
10920 - FindDocumentedMember() now expects 1) paramList as null
10921 when "we don't have to check the number of parameters" and
10922 2) Type.EmptyTypes when "there is no arguments".
10923 - Introduced FoundMember struct to hold the exact type which was
10924 used to find the documented member (the above change broke
10925 test-xml-044; it might be better just to use DeclaringType than
10926 what MS does, like this change does, but it depends on usage.)
10928 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
10930 * doc.cs : documented member might be from DeclaringType for nested
10931 types. Fixed bug #76782.
10933 2005-12-03 Ben Maurer <bmaurer@ximian.com>
10935 * anonymous.cs: Have the param code handle leaving copies on the
10936 stack etc. Allows anonymous params to take part in the assignment
10937 code (++, +=, etc). Fixes bug #76550
10939 * expression.cs: Handle the prepare_for_load/leave_copy by passing
10940 it down to the anon code.
10942 * iterators.cs: Use dummy var here
10944 * codegen.cs: Handle new vars
10946 2005-12-01 Marek Safar <marek.safar@seznam.cz>
10949 * class.cs (MethodData.Define): Set proper Obsolete context.
10951 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
10953 (FieldExpr.DoResolve): Ditto.
10955 2005-12-01 Marek Safar <marek.safar@seznam.cz>
10958 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
10959 parent is not obsolete.
10961 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
10963 * doc.cs : (FindDocumentedMember) find parameterless members first
10964 and get CS0419 in the early stage. Fixed first case of bug #76727.
10966 2005-11-30 Marek Safar <marek.safar@seznam.cz>
10969 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
10970 no error was reported.
10972 *expression.cs (Binary.DoResolve): left can be null.
10974 2005-11-22 Marek Safar <marek.safar@seznam.cz>
10977 * class.cs (MethodData.Emit): Parameters should be labeled first.
10979 2005-11-21 Marek Safar <marek.safar@seznam.cz>
10982 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
10984 2005-11-18 Marek Safar <marek.safar@seznam.cz>
10986 * attribute.cs (AreParametersCompliant): Moved to Parameter.
10988 * class.cs (MethodCore): Parameter clean up.
10989 (IMethodData): Added ParameterInfo.
10990 (MethodData): Parameter clean up.
10991 (Indexer.Define): Parameter clean up.
11003 * typemanager.cs: Parameter clean up.
11005 * delegate.cs (Define): Get rid of duplicated code.
11007 * expression.cs (ParameterReference): Removed useless parameters
11009 (Invocation): Ditto.
11011 * parameter.cs (ParamsParameter): New class, params specialization.
11012 (ArglistParameter): Attemp to separate arglist.
11013 (Parameter): Refactored to be reusable and faster.
11014 (Parameter.Modifier): Made understandable.
11015 (Parameters): Changed to be used as a class for `this' assembly
11016 parameters. Refactored to use new specialized classes.
11018 * support.cs (ParameterData): Added Types property.
11019 (InternalParameters): Deleted.
11021 2005-08-20 Martin Baulig <martin@ximian.com>
11023 Merging this patch from GMCS to fix #75867.
11025 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11026 scope if we don't already have it.
11028 2005-11-17 Martin Baulig <martin@ximian.com>
11031 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11032 inherit the scope from our parent. Fixes #76653.
11034 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11036 * doc.cs : the previous patch does not actually fix the bug.
11037 PropertyInfo override check is now implemented and really fixed it.
11038 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11040 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11042 * doc.cs : apply "override filter" also to properties.
11045 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11047 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11048 no need to check overrides. For classes, omit those results from
11049 interfaces since they must exist in the class. Fixed bug #76726.
11051 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11053 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11054 with different parameters. Fixed the second problem in #76685.
11056 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11058 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11059 get expected 'protected' access in CheckValidFamilyAccess()).
11062 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11064 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11065 Fixed bug #76705. CS1569 was incorrectly commented out.
11067 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11069 * doc.cs : use Invocation.IsOverride() to do real override check.
11070 * expression.cs : made Invocation.IsOverride() internal.
11072 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11074 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11075 TypeBuilder.FindMembers() and filter overriden base members out.
11078 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11080 * doc.cs : ref/out parameters are represented as '@' (instead of
11081 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11083 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11085 * doc.cs : when there was no '.' in cref to methods in doc comment,
11086 then parameters were missing in the output. Fixed bug #76691.
11088 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11090 * driver.cs : don't output docs when there is an error.
11093 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11096 Now it should detect indexers. Fixed primary concern in bug #76685.
11097 Fixed CS0419 message to not show the identical member signature in
11100 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11102 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11103 instead of Type.FindMembers() since it does not handle events.
11106 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11108 * codegen.cs: Fixed typo (speficied -> specified).
11110 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11113 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11115 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11117 * attribute.cs: Changed error message.
11119 * cs-tokenizer.cs: One more check.
11121 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11123 * statement.cs (Block.Resolve): Ignore empty statement.
11125 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11127 * report.cs: Made error/warning methods more strict to avoid
11130 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11131 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11132 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11133 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11135 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11137 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11138 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11140 * class.cs (TypeContainer.IsComImport): New property.
11141 (Constructor.Define): Create proper ctor for ComImport types.
11143 * expression.cs (New.CheckComImport): Fixed.
11145 2005-11-07 Miguel de Icaza <miguel@novell.com>
11147 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11148 that a parameter has been captured does not mean that we do not
11149 have to do the rest of the processing. This fixes the second part
11150 of #76592. If there was another anonymous method capturing
11151 values in the past, the Scope would never be set for the second
11152 method that captured the same parameter.
11154 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11155 properly manipulate the stack. Second part of fix for #76592.
11157 * expression.cs (New): Add support for invoking "new" on
11158 interfaces that have been flagged with the ComImport attribute and
11159 the CoClass. Fixes #76637
11161 * statement.cs (Try.DoEmit): When a variable is captured, do not
11162 try to emit the vi.LocalBuilder variable as it has been captured.
11163 Create a temporary variable and store the results on the
11164 FieldBuilder. Fixes #76642
11166 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11168 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11170 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11172 * expression.cs (Binary.DoResolve): Added && optimalization.
11174 * typemanager.cs (AddUserType): Removed useless argument.
11176 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11178 * statement.cs (Block.variables): Uses ListDictionary.
11180 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11183 * class.cs (PartialContainer.EmitType): Customized to emit
11184 security attributes.
11185 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11186 for partial classes.
11188 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11191 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11192 access has to be fixed.
11194 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11196 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11199 * ecore.cs (NullCast.Reduce): Implemented.
11201 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11204 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11206 (Foreach.Resolve): Catch null properly.
11208 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11210 * cs-tokenizer.cs: Warning text fix.
11212 * driver.cs: AllWarningNumbers exposed on public interface.
11214 * report.cs (): Reviewed warning numbers.
11215 (IsValidWarning): Use binary search.
11217 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11219 * driver.cs: Implemeted resource visibility.
11220 (Resources): New class for code sharing between /res: and
11223 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11226 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11229 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11232 * ecore.cs (NullCast): Child is contant only.
11234 * literal.cs (NullLiteral.Reduce): null can be converted to any
11237 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11239 * driver.cs: Use Encoding.Default as default code page instead
11242 2005-10-27 Raja R Harinath <rharinath@novell.com>
11245 * expression.cs (Invocation.Error_InvalidArguments): Handle
11246 __arglist parameters.
11247 (Invocation.VerifyArgumentsCompat): Likewise.
11248 * support.cs (ReflectionParameters.GetSignatureForError): Print
11249 __arglist parameters.
11250 (InternalParamters.GetSignatureForError): Likewise.
11251 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11253 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11255 * attribute.cs (GetPropertyValue): Made public.
11257 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11259 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11261 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11264 * driver.cs: Reflect method name change.
11266 * statement.cs (Try.Resolve): Warn when try has both general
11267 exception handlers.
11269 * typemanager.cs: runtime_compatibility_attr_type new predefined
11272 2005-10-26 Raja R Harinath <harinath@gmail.com>
11275 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11276 treat it as an empty parameter list.
11278 2005-10-26 Raja R Harinath <rharinath@novell.com>
11281 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11282 ResolveAsTypeStep silent.
11283 * statement.cs (Block.AddConstant): Mark block as used.
11284 (Block.ResolveMeta): Avoid piling on error messages
11285 if a constant initializer resolution fails.
11287 2005-10-25 Raja R Harinath <rharinath@novell.com>
11289 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11291 (NamespaceEntry.VerifyAllUsing): New.
11292 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11293 behaviour. Delegates actual resolution of alias to ...
11294 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11295 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11297 * driver.cs (Driver.MainDriver): Update.
11299 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11300 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11302 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11304 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11305 RootNamespace.DefineNamespacesForAll.
11307 2005-10-24 Raja R Harinath <harinath@gmail.com>
11309 * typemanager.cs (assemblies, external_aliases, modules)
11310 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11311 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11312 overhead. Move resposibility ...
11313 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11314 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11316 2005-10-23 Raja R Harinath <harinath@gmail.com>
11318 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11319 cached_namespaces. Improve usage.
11320 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11321 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11322 Move from GlobalRootNamespace and simplify.
11323 (RootNamespace.Global): Make instance variable.
11324 (RootNamespace.RootNamespace): Add "alias name" parameter.
11325 (GlobalRootNamespace): Simplify drastically.
11326 (Namespace.Lookup): Don't use GetNamespace.
11327 * typemanager.cs (GetRootNamespace): Rename from
11328 ComputeNamespaceForAlias.
11329 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11331 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11333 * anonymous.cs (AnonymousContainer): Don't crash when container
11336 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11338 * expression.cs (Binary.DoResolve): Warn when comparing same
11341 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11344 * expression.cs (Binary.DoResolve): It looks like there are no
11345 convetsion rules in enum context.
11347 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11349 Add support for extern alias qualifiers.
11350 * typemanager.cs: Move some LookupTypeReflection code
11351 to namespace.cs, to have cleaner code. Added some methods
11352 to help us keep track of the extern aliased references.
11353 * driver.cs: Add suport for extern alias assemblies on command
11354 line and check for their warnings/errors. Also keep track of the
11355 extern aliased assemblies.
11356 * namespace.cs: Move the global functionality of Namespace
11357 to GlobalRootNamespace/RootNamespace. Now the global namespace
11358 is GlobalRootNamespace.Globa. Also the code moved from
11359 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11360 Finally added LocalAliasEntry (AliasEntry before) and
11361 ExternAliasEntry, to handle alias statements.
11362 * cs-parser.jay: Add support in the grammar for extern alias
11364 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11365 Update callings to Namespace (now in GlobalRootNamespace).
11367 2005-10-18 Raja R Harinath <rharinath@novell.com>
11370 * class.cs (TypeContainer.DefineType): Move updating of
11371 topological sort earlier in the code.
11372 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11374 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11377 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11379 * constant.cs (Constant.TryReduce): Moved from Cast class.
11380 (Reduce): Made little bit more OO and fixed missing conversions.
11382 * ecore.cs (Reduce): Implemented.
11383 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11385 * literal.cs (Reduce): Implemented.
11387 * class.cs: Reverted Miguel's wrong commit.
11389 2005-10-14 Miguel de Icaza <miguel@novell.com>
11391 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11393 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11395 * cs-parser.jay, expression.cs : CS0214 was missing error location
11396 for constants. Fixed bug #76404.
11398 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11401 * convert.cs (ExplicitConversionCore): Fixed object->enum
11404 2005-10-10 Raja R Harinath <rharinath@novell.com>
11406 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11407 InstanceExpression.
11408 (PropertyExpr.EmitCall): Likewise.
11409 * expression.cs (Invocation.EmitArguments): Handle case where
11411 (Invocation.EmitCall): Avoid allocating temporary variable if
11412 there are no arguments.
11414 2005-10-07 Raja R Harinath <rharinath@novell.com>
11417 * convert.cs (ImplicitConversionStandard): Move conversion of
11418 void* to arbitrary pointer types ...
11419 (ExplicitConversionStandard): .. here.
11420 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11421 error to always print typenames.
11423 2005-10-07 Raja R Harinath <rharinath@novell.com>
11425 * convert.cs (GetConversionOperator): Rename from
11426 GetConversionOperators. Move operator selection code from ...
11427 (UserDefinedConversion): ... here.
11429 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11431 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11434 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11436 * assign.cs (Assign.DoResolve): Error method changed.
11438 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11440 * const.cs (ResolveValue): Reset in_transit immediately.
11442 * constant.cs: Error method changed.
11444 * convert.cs: Removed useless location parameter.
11445 (ExplicitNumericConversion): Don't do double enum check.
11446 (ExplicitConversionCore): Renamed from ExplicitConversion.
11447 (ExplicitUnsafe): Extracted from ExplicitConversion.
11448 (ExplicitConversion): Uses for error reporting.
11450 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11452 (ResolveBoolean): Uses common error method.
11453 (CastToDecimal): Get rid of ec.
11454 (CastFromDecimal): Optimized.
11455 (ConvCast): Get rid of ec.
11457 * enum.cs (ResolveValue): Reset in_transit immediately.
11458 (Emit): Return after first error.
11460 * expression.cs: Convert changes.
11462 * literal.cs: Error method changed.
11464 * statement.cs: Error method changed.
11466 2005-10-03 Raja R Harinath <rharinath@novell.com>
11468 * support.cs (SeekableStreamReader.Position): Don't error out when
11469 the requested position is just beyond the end of the current
11472 2005-09-28 Raja R Harinath <rharinath@novell.com>
11474 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11475 try to keep in sync with the byte count of the underlying Stream.
11476 However, this limits us to a window size of 2048 characters: i.e.,
11477 the maximum lookahead of our lexer/parser can be 2048 characters.
11479 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11482 * driver.cs: Fix compilation files with full root path.
11484 2005-09-25 Miguel de Icaza <miguel@novell.com>
11486 * report.cs (SymbolRelatedToPreviousError): Format the output so
11487 it does not use an open parenthesis that is never closed.
11489 * driver.cs: Follow coding guidelines
11491 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11494 * const.cs (Const.ResolveValue): Check for assigning non-null
11495 value to reference type.
11497 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11499 * anonymous.cs: Implemented ExprClassName.
11501 * assign.cs (Assign.DoResolve): Don't chrash when type is not
11504 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
11507 * class.cs (StaticClass.DefineContainerMembers): Report protected
11510 * codegen.cs: if(ed) PRODUCTION.
11512 * convert.cs (Error_CannotImplicitConversion): Better error
11515 * cs-parser.jay: More error checks.
11517 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
11519 * driver.cs (CSCParseOption): Enabled wrong option check.
11521 * ecore.cs (Expression.ExprClassName): Turned to property.
11522 (MemberExpr.CheckIntermediateModification): For checking boxed
11523 value types modification.
11525 * statement.cs (Fixed.Resolve): Expression type must be
11526 convertible to fixed type.
11527 (CollectionForeach.GetEnumeratorFilter,TryType):
11528 Small refactoring for easier error checking.
11530 2005-09-26 Marek Safar <marek.safar@seznam.cz>
11532 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
11535 * class.cs (GeneratedBaseInitializer): New class for customization
11536 compiler generated initializers.
11537 (MemberBase.DoDefine): Check Obsolete attribute here.
11538 (FieldMember.DoDefine): Ditto.
11540 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
11543 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
11544 (MemberCore.GetObsoleteAttribute): Removed argument.
11545 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
11546 (MemberCore.CheckObsoleteType): New helper.
11550 * statement.cs: Updates after MemberCore changes.
11552 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
11553 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
11555 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
11556 obsolete attribute for compiler construct.
11557 (As.DoResolve): Cache result.
11559 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
11561 2005-09-26 Raja R Harinath <rharinath@novell.com>
11564 * expression.cs (This.VerifyFixed): In a value type T, the type of
11565 'this' is T&, iow, 'this' is either an out or ref parameter. In a
11566 value type R, 'this' is treated as a value parameter.
11568 2005-09-22 Miguel de Icaza <miguel@novell.com>
11570 * statement.cs (Lock): Use the TemporaryVariable class instead of
11571 manually using local variables as those do not work when variables
11574 * ecore.cs: Moved the TemporaryVariable class from being a nested
11575 class inside Foreach to be a public class that can be employed in
11578 2005-09-19 Marek Safar <marek.safar@seznam.cz>
11580 * cs-parser.jay: interface_accessors replaced by
11581 accessor_declarations.
11583 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
11586 * statement.cs (GotoCase.Resolve): Convert null constant to
11588 (SwitchLabel.ResolveAndReduce): Ditto.
11589 (SwitchLabel.NullStringCase): Custom null stamp.
11590 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
11592 typemanager.cs (CSharpSignature): Don't skip first argument
11595 2005-09-18 Miguel de Icaza <miguel@novell.com>
11597 * driver.cs: Set InEmacs based on the environment variable EMACS.
11599 * location.cs (InEmacs): in this mode, do not report column
11600 location as it confuses Emacs.
11602 2005-09-16 Marek Safar <marek.safar@seznam.cz>
11604 * cfold.cs, constant.cs, convert.cs, ecore.cs,
11605 expression.cs, iterators.cs, literal.cs: Store constants and
11608 * class.cs (MemberBase.ShortName): Pass location.
11610 * cs-parser.jay: Some location fixes.
11612 * ecore.cs (Expression.Location): Made virtual.
11614 2005-09-05 Miguel de Icaza <miguel@novell.com>
11616 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
11617 if the underlying types are the same, otherwise we need to produce
11618 code that will do the proper cast.
11620 This was exposed by Marek's constant rewrite which produced
11621 invalid code for the call site:
11623 enum X : long { a }
11624 void Method (X v) {}
11628 This fixes test-49.cs
11630 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11632 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
11633 Type/Object should be allowed as well. Fixed bug #75968.
11635 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11637 * expression.cs : (Binary.DoResolve): when one is enum constant and
11638 another is constant 0, then return enum one *as enum type*.
11641 2005-09-02 Raja R Harinath <rharinath@novell.com>
11643 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
11647 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
11648 flow-branching for LocalVariableReferences in case we were invoked
11649 from a MemberAccess.
11650 * expression.cs (LocalVariableReference.VerifyAssigned): New.
11652 (LocalVariableReference.DoResolveBase): ... this.
11653 (MemberAccess.Resolve): Do the check that was disabled during
11656 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11659 (PartialContainer.Create): check abstract/sealed/static strictly
11660 but abstract/sealed can exist only at one side. Fixed bug #75883.
11662 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
11665 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
11666 specified, don't default to UnmanagedType.I4.
11668 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11670 * expression.cs : conditional operator should check possibly
11671 incorrect assign expression. Fixed bug #75946.
11673 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11675 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
11676 Reverting the change. gmcs is much complex than mcs on this matter.
11678 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11680 * cs-tokenizer.cs : To read another token ahead of the actual
11681 consumption, use new SavedToken and cache token instead of moving
11682 back the stream with SeekableStreamReader (it seemed problematic).
11684 driver.cs : Thus use StreamReader directly.
11685 * support.cs : Thus removed SeekableStreamReader.
11687 2005-08-30 Raja R Harinath <rharinath@novell.com>
11690 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
11691 (ScopeInfo.EmitScopeType): Use it to construct field names from
11692 names of captured locals.
11695 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
11696 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
11697 Pass 'target_type' to BoxedCast. Don't default to 'object'.
11698 (ExplicitConversion): Remove enum cases already handled by
11699 implicit conversion. Move implicit conversion check to the beginning.
11700 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
11701 * expression.cs (ArrayCreation.EmitDynamicInitializers):
11702 Don't treat System.Enum as a struct.
11704 2005-08-30 Jb Evain <jbevain@gmail.com>
11706 * attribute.cs: handles as expression in parameters.
11708 2005-08-30 Raja R Harinath <rharinath@novell.com>
11711 * class.cs (TypeContainer.VerifyClsName): Don't use a
11712 PartialContainer when verifying CLS compliance.
11713 (AbstractPropertyEventMethod): Set Parent here, ...
11714 (PropertyMethod): ... not here.
11716 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
11718 * attribute.cs : escaped attribute name should not be allowed to be
11719 resolved (e.g. @class as classAttribute). Fixed bug #75930.
11721 2005-08-29 Raja R Harinath <rharinath@novell.com>
11724 * convert.cs (ImplicitStandardConversionExists): Allow zero also
11725 when converting a long constant to unsigned long.
11726 * expression.cs (Invocation.OverloadResolve): Add sanity check to
11727 detect where IsApplicable and VerifyArgumentsCompat disagree.
11729 2005-08-29 Raja R Harinath <rharinath@novell.com>
11730 and Carlos Alberto Cortez <carlos@unixmexico.org>
11733 * class.cs (TypeContainer.CanElideInitializer): New helper.
11734 (TypeContainer.EmitFieldInitializers): Use it to determine if we
11735 can safely emitting the initializer of a field.
11737 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11739 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
11740 allowed inside a switch (without loop). Fixed bug #75433.
11742 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
11744 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
11745 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
11747 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11749 * driver.cs : kinda reverting the default encoding changes (not exact
11750 revert since I noticed that "codepage:reset" might not work fine).
11752 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11754 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
11755 Location. Now getter and setter store location correctly.
11756 (errors/cs0111-12.cs now reports the expected location.)
11758 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11760 * driver.cs : Use default encoding on the environment.
11761 Removed (now that) extra parameter for SeekableStreamReader.
11762 * support.cs : (SeekableStreamReader) third .ctor() argument for
11763 StreamReader is not required (always true). preamble size could
11764 be acquired in simpler and safe way.
11766 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
11768 * cs-parser.jay: report CS0642 at warning level 3
11769 and report CS0642 for an if else statement also
11770 fixes bug #74745. Patch by John Luke (and a bit
11772 Removed extra CS0642 warning check for "while",
11774 * statement.cs: In Block.Resolve(), CS0642 check
11775 is reimplemented to check a sequence of an empty
11776 statement and a block.
11778 Both fix bug #66777.
11780 2005-08-24 Marek Safar <marek.safar@seznam.cz>
11782 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
11783 detection until I fix it.
11785 * cs-tokenizer.cs: Changed error message.
11787 * cs-parser.jay: Fixed 2 error locations.
11789 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
11790 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
11793 * enum.cs (GetSignatureForError): Fixed.
11795 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
11799 * typemanager.cs (RegisterProperty): Removed.
11801 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
11803 2005-08-24 Raja R Harinath <rharinath@novell.com>
11806 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
11807 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
11809 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11811 * expression.cs : tiny fix is required for not warning positive ulong.
11814 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11816 * expression.cs : add CS0652 check for constant and integral
11817 expression. Fixed bug #53974.
11819 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11821 * expression.cs : in DoNumericPromotions(), check if there is implicit
11822 conversion overload for string (to check CS0034). Fixed bug #52492.
11824 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11826 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
11828 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11830 * ecore.cs : report location when it is *not* Null.
11832 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11838 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
11839 correctly. Fixed bug #75721.
11841 2005-08-23 Raja R Harinath <rharinath@novell.com>
11843 * support.cs (SeekableStreamReader.Position): Avoid an expensive
11844 loop that performs 'min (pos, char_count)'.
11847 * expression.cs (Unary.ResolveOperator): Don't discard implicit
11848 converted value in Operator.OnesComplement.
11850 2005-08-22 Ben Maurer <bmaurer@ximian.com>
11852 * anonymous.cs: If the anon method is pulled into a helper class,
11853 it needs to be `internal' not `private'. Fixes runtime behavior on
11856 2005-08-20 Martin Baulig <martin@ximian.com>
11858 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11859 scope if we don't already have it.
11861 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
11862 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
11865 2005-08-17 Marek Safar <marek.safar@seznam.cz>
11868 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
11869 is a partial class.
11871 2005-08-16 Marek Safar <marek.safar@seznam.cz>
11873 The big constants rewrite
11874 Fix #75746, #75685 and more
11875 As a side effect saved 1MB for MWF ;-)
11877 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
11878 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
11879 enum based for corlib compilation.
11881 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
11884 * class.cs (FixedField.Define): Use ResolveAsConstant.
11886 * const.cs (IConstant): Interface constants and enums.
11887 (Const.ResolveValue): New method for constant resolvning.
11888 (ExternalConstant): Constants from imported assemblies.
11890 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
11891 conversion; like enums.
11892 (Constant.ToType): Converts this constant to different type.
11893 (Constant.Increment): Adds 1.
11895 * convert.cs (ImplicitConversionRequired): Simplified.
11897 * cs-parser.jay: Create EnumMember directly.
11899 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
11901 * doc.cs (GenerateEnumDocComment): Removed.
11903 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
11904 (ConvertIntLiteral): Removed.
11905 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
11907 * enum.cs (EnumMember): Implement IConstant.
11908 (Enum.IsValidEnumConstant): Removed.
11909 (Enum.GetNextDefaultValue): Removed.
11910 (Enum.FindMembers): Updated.
11911 (Enum.GenerateDocComment): Iterate enum members.
11913 * expression.cs (Cast.TryReduce): Handle enums correctly.
11914 (New.Constantify): Made public.
11915 (MemberAccess.DoResolve): Removed contant specific if(s).
11917 * literal.cs (NullLiteral): Implement new abstract methods.
11919 * statement.cs (GotoCase.Resolve): Use new constant methods.
11920 (SwitchLabel.ResolveAndReduce): Use new constant methods.
11922 * typemanager.cs (LookupEnum): Removed.
11923 (IsEnumType): Fixed to work with corlib.
11924 (RegisterConstant): Removed.
11925 (LookupConstant): Removed.
11926 (GetConstant): Changed to work with IConstant.
11928 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
11930 * location.cs : Fixed overflown (>255) column number.
11932 2005-08-03 Raja R Harinath <rharinath@novell.com>
11934 First cut of the qualified-alias-member feature.
11935 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
11937 * cs-parser.jay (DOUBLE_COLON): New token.
11938 (namespace_or_type_name): Add rule for recognizing
11939 qualified-alias-members.
11940 (primary_expression): Likewise.
11941 (element_access): Allow QualifiedAliasMember as a possible
11942 type-bearing expression.
11943 (local_variable_type, local_variable_pointer_type): Likewise.
11944 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
11945 aliases in the current and enclosing namespace declarations.
11946 (NamespaceEntry.UsingAlias): Add CS0440 warning.
11947 * decl.cs (MemberName.is_double_colon): New.
11948 (MemberName.MemberName): Add new constructor for alias-member.
11949 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
11950 * expression.cs (QualifiedAliasMember): New expression type.
11952 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11954 * location.cs : it borked when no argument was specified.
11956 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11958 * location.cs : tiny ToString() format fix.
11960 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11962 * statement.cs : oops, it was missing.
11964 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11966 A set of fixes for precise line/column location.
11969 "token" field now holds a file/line "delta", a line number offset
11970 from the segment, and a column number. See also:
11971 http://lists.ximian.com/pipermail/mono-devel-list/2004-
11972 December/009508.html
11973 Removed static IsNull. Use instance IsNull property instead.
11974 * cs-tokenizer.cs :
11975 For some tokens it stores Location. For Identifier it stores
11976 LocatedToken which is a pair of string name and location.
11977 Column numbers are adjusted only at getChar().
11979 Use Location.ToString() for reporting (it now contains column).
11981 Largely modified to use LocatedToken instead of
11982 string (IDENTIFIER), and to acquire Location from some tokens.
11983 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
11984 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
11986 Now MemberName holds Location. DeclSpace.ctor() receives Location
11987 as a parameter. Removed extra parameters to all derived classes.
11988 Replaced Location.IsNull() with instance property.
11989 * assign.cs, expression.cs :
11990 Added .ctor() overload that omits Location.
11992 Added "nameEscaped" flag that indicates the identifier was escaped
11993 in the source file. This fixes bug #57047.
11995 2005-08-02 Marek Safar <marek.safar@seznam.cz>
11997 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
11998 New method, looking for lo-case imported cls type.
12000 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12003 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12005 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12007 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12008 all_imported_types.
12009 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12011 Optimized to save 3.5 MB for SWF compilation.
12013 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12015 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12016 (PartialContainer.Create): Moved logic AddToContainer.
12017 (PartialContainer.MarkForDuplicationCheck): Shares name.
12019 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12022 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12024 (Namespace.GetSignatureForError): New method.
12026 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12027 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12029 2005-08-01 Raja R Harinath <rharinath@novell.com>
12032 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12033 member lookup rather than qualifier_type, since qualifier_type can
12036 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12038 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12041 2005-07-31 Miguel de Icaza <miguel@novell.com>
12043 * statement.cs: Copy the local exception into the exception
12044 captured local. Fixes 75674
12046 2005-07-31 Raja R Harinath <harinath@gmail.com>
12049 * expression.cs (Invocation.OverloadResolve): Don't report error
12050 CS1501 if error CS1502 has been reported.
12051 (New.DoResolve): Delegate CS1501 reporting to
12052 Invocation.OverloadResolve.
12055 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12056 invariant-meaning-in-block property in an enclosing block if
12059 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12061 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12062 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12063 (Switch.CheckSwitch): Just save 50kb for SWF.
12065 2005-07-27 Martin Baulig <martin@ximian.com>
12067 * anonymous.cs (CaptureContext.AddField): Added
12068 `AnonymousContainer am' argument; compute its toplevel scope if
12069 it's not already computed. Fixes #75649.
12071 2005-07-26 Raja R Harinath <rharinath@novell.com>
12074 * class.cs (Constructor.Emit): Reset block to null if the block
12077 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12079 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12081 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12083 * class.cs (MethodData.Define): Check whether accessor implementing
12084 interface is public.
12086 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12088 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12091 * namespace.cs (LookupType): Moved same type check to...
12093 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12094 with the same name.
12096 2005-07-21 Raja R Harinath <rharinath@novell.com>
12098 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12099 already found a typebuilder.
12100 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12101 MemberNames, not strings.
12103 * const.cs (Error_ExpressionMustBeConst):
12104 Rename from Error_EpressionMustBeConst.
12105 * const.cs, class.cs, statement.cd: Update.
12107 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12111 * const.cs (Const.LookupConstantValue): Report missing contant expression
12113 (Error_EpressionMustBeConstant): Only one error method.
12115 * class.cs, statement.c: Updated.
12117 2005-07-20 Raja R Harinath <rharinath@novell.com>
12119 * statement.cs (Block.Flags): Add back HasVarargs.
12120 (Block.flags): Make protected.
12121 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12123 * typemanager.cs (types, typecontainers, user_types): Remove.
12124 (UserTypes, TypeContainers): Likewise.
12125 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12126 (CleanUp, Reset): Update.
12127 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12128 (GetNestedType): Use Type.GetNestedType.
12129 (CoreLookupType): Take two arguments, the namespace and the
12130 basename of the type. Update to use the Namespace.Lookup
12132 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12133 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12134 string concatenation and substring matches.
12135 * class.cs, enum.cs, delegate.cs: Update to changes.
12137 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12139 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12140 Expression and made virtual.
12142 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12143 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12145 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12147 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12150 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12153 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12156 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12157 AssemblyCultureAttribute is not used on executable.
12160 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12162 2005-07-16 Raja R Harinath <rharinath@novell.com>
12165 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12166 New. Reports CS0252/CS0253.
12167 Mostly taken from preliminary patch by Duncak Mak.
12168 (Binary.DoResolveOperator): Store results of operator lookup.
12169 Use them to detect if we need to warn about unintended reference
12172 2005-07-15 Raja R Harinath <rharinath@novell.com>
12175 * namespace.cs (Namespace.Lookup): Add back location parameter.
12176 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12177 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12179 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12180 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12181 (Namespace.LookupType): ... this.
12182 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12184 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12185 purported to handle pointers.
12186 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12189 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12191 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12194 2005-07-15 Raja R Harinath <rharinath@novell.com>
12196 * namespace.cs (Namespace.Lookup): Drop location parameter.
12197 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12198 (NamespaceEntry.Lookup): ... this.
12199 (NamespaceEntry.Error_AmbiguousTypeReference):
12200 Move here from DeclSpace.
12201 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12203 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12204 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12205 Move to NamespaceEntry.
12206 * delegate.cs, expression.cs: Update to changes.
12208 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12210 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12211 CheckAttributeType and refactored.
12212 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12213 ResolveAsTypeTerminal error handling.
12214 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12216 (GetSignatureForError): Print errors in same way.
12219 * codegen.cs: Reflect attribute GetSignatureForError change.
12222 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12224 * namespace.cs (UsingEntry): Refactored to make fields private.
12227 statement.cs: Error_UnexpectedKind has extra parameter.
12229 2005-07-14 Raja R Harinath <rharinath@novell.com>
12231 * ecore.cs (IAlias): Remove.
12232 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12233 that implement the interface.
12234 * namespace.cs (Namespace): Likewise.
12235 (Namespace.declspaces): Renamed from 'defined_names'.
12236 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12237 DeclSpace instead of an IAlias.
12238 * tree.cs (Tree.AddDecl): Update.
12240 2005-07-12 Raja R Harinath <rharinath@novell.com>
12242 * statement.cs (Block.Flags); Remove HasVarargs.
12243 (Block.HasVarargs): Move to ToplevelBlock.
12244 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12245 (Block.Variables): Make protected. Initialize variable hashtable
12247 (Block.AddVariable): Update.
12248 (Block.Resolve): Update to changes.
12249 (ToplevelBlock.HasVarargs): New boolean.
12250 (ToplevelBlock.ThisVariable): Move here from Block.
12251 (ToplevelBlock.AddThisVariable): Likewise.
12252 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12253 * expression.cs (This.ResolveBase): Update to changes.
12254 (ArglistAccess.DoResolve): Likewise.
12256 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12259 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12261 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12262 not used and not used & assigned.
12263 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12265 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12268 * expression.cs (Is.DoResolve): null is never provided type.
12270 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12273 * cs-parser.jay: Less strict event error rule to catch more errors.
12275 2005-07-08 Martin Baulig <martin@ximian.com>
12277 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12278 gettter (allowed) or setter (not allowed).
12280 * class.cs (Accessor): Implement IIteratorContainer.
12281 (Accessor.Yields): New public field.
12282 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12283 per-accessor basis.
12286 (get_accessor_declaration, set_accessor_declaration): Set the
12287 `yields' flag on the accessor, not the property.
12288 (property_declaration): Do the iterators check on a per-accessor
12289 basis and not for the whole property.
12291 2005-07-08 Martin Baulig <martin@ximian.com>
12293 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12294 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12296 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12299 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12300 (ExtractSecurityPermissionSet): Cope with self referencing security
12301 attributes properly.
12303 * driver.cs (SetOutputFile): Made public property OutputFile.
12305 2005-07-07 Raja R Harinath <rharinath@novell.com>
12308 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12309 has_nonstatic_fields. Make into a FieldBase pointer.
12310 (TypeContainer.AddField): Add CS0282 check.
12311 (TypeContainer.EmitType): Update.
12313 2005-07-06 Miguel de Icaza <miguel@novell.com>
12315 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12316 compare if they start with __.
12318 2005-07-06 Raja R Harinath <rharinath@novell.com>
12320 * statement.cs (Switch.SwitchGoverningType): Only look at
12321 UserCasts that don't need implicit standard conversions to one of
12322 the allowed switch types (Fixes test-322.cs).
12323 (LocalInfo.Resolve): Re-enable sanity-test.
12325 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12327 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12329 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12331 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12333 2005-07-06 Raja R Harinath <rharinath@novell.com>
12336 * ecore.cs (SimpleName.GetSignatureForError): Add.
12337 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12338 (MemberAccess.GetSignatureForError): Add.
12340 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12342 The big error and warning messages review.
12372 * typemanager.cs: Updated.
12374 * class.cs: (MethodCore.SetYields): Moved here to share.
12375 (PropertyMethod.Define): Moved iterator setup here.
12377 * iterators.cs: Add orig_method to have full access to parent
12380 2005-07-05 Raja R Harinath <rharinath@novell.com>
12382 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12383 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12384 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12385 variable of struct type.
12386 * expression.cs (Unary.ResolveOperator): Update to change.
12387 (Indirection.VerifyFixed): Likewise.
12388 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12389 (ParameterReference.VerifyFixed): Value parameters are fixed.
12390 (This.VerifyFixed): Treat 'this' as a value parameter.
12391 * statement.cs (LocalInfo.IsFixed): Remove.
12393 2005-07-01 Martin Baulig <martin@ximian.com>
12395 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12396 `ec.EmitThis ()' to get the correct scope.
12398 2005-07-01 Martin Baulig <martin@ximian.com>
12400 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12401 instance is a ParameterReference; fixes #75299.
12403 2005-07-01 Martin Baulig <martin@ximian.com>
12405 Reverted Marek's latest patch (r46725):
12406 - it contains structural changes which are neither mentioned in
12407 the ChangeLog nor explained anywhere; for example the additional
12408 argument of EmitContext's and Iterator's .ctor's and the
12409 TypeContainer.DefineMembers() change.
12410 - structural changes like this should go in in seperate patches
12411 and not be hidden in a huge patch which just seems to affect
12412 warnings and errors.
12413 a big and hard to understand patch.
12414 - it breaks iterators and causes regressions, for instance in
12417 2005-06-30 Raja R Harinath <rharinath@novell.com>
12420 * expression.cs (Indexers.map): Remove.
12421 (Indexers.Append): Filter out inaccessible setters and getters.
12422 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12425 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12426 Refactored from ...
12427 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12428 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12429 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12430 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12432 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12435 * class.cs (FieldBase.GetInitializerExpression): One more field
12438 2005-06-28 Miguel de Icaza <miguel@novell.com>
12440 * pending.cs: Do not define a proxy if the base method is virtual,
12441 it will be picked up by the runtime (bug 75270).
12443 2005-06-08 Martin Baulig <martin@ximian.com>
12445 The big Iterators rewrite :-)
12447 * iterators.cs: Rewrite this to use the anonymous methods framework.
12449 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12450 before the TypeContainers; see 2test-21.cs.
12453 (TypeContainer.DefineType): Don't create a new EmitContext if we
12454 already have one (this only happens if we're an Iterator).
12455 (TypeContainer.Define): Also call Define() on all our iterators.
12456 (Method.CreateEmitContext): Added support for iterators.
12459 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12460 (AnonymousContainer.CreateMethodHost): Moved here from
12461 AnonymousMethod and made abstract.
12462 (AnonymousContainer.CreateScopeType): New abstract method.
12463 (AnonymousContainer.IsIterator): New public property.
12464 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12465 get the ScopeTypeBuilder rather than manually defining it here.
12466 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12469 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12470 before RootContext.DefineTypes().
12472 * codegen.cs (EmitContext.RemapToProxy): Removed.
12473 (EmitContext.CurrentAnonymousMethod): Changed type from
12474 AnonymousMethod -> AnonymousContainer.
12475 (EmitContext.ResolveTopBlock): Protect from being called twice.
12476 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12477 (EmitContext.EmitThis): Removed the iterators hacks; use the
12478 anonymous methods framework for that.
12481 (ToplevelBlock.Container): Make this a property, not a field.
12482 (ToplevelBlock.ReParent): New public method; move the
12483 ToplevelBlock into a new container.
12484 (Foreach.TemporaryVariable): Simplify.
12486 2005-06-05 Martin Baulig <martin@ximian.com>
12488 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12489 (Block.AddTemporaryVariable): New public method; creates a new
12490 `LocalInfo' for a temporary variable.
12491 (Block.EmitMeta): Create the LocalBuilders for all the temporary
12493 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
12494 non-iterator variables.
12496 2005-06-05 Martin Baulig <martin@ximian.com>
12498 * statement.cs (Foreach.TemporaryVariable): Create the
12499 LocalBuilder in the Emit phase and not in Resolve since in some
12500 situations, we don't have an ILGenerator during Resolve; see
12501 2test-19.cs for an example.
12503 2005-06-04 Martin Baulig <martin@ximian.com>
12505 **** Merged r45395 from GCS ****
12507 The big Foreach rewrite - Part II.
12509 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
12510 with `PropertyInfo ienumerator_getcurrent'.
12512 * codegen.cs (VariableStorage): Removed.
12515 (Foreach): Derive from Statement, not ExceptionStatement.
12516 (Foreach.CollectionForeach): New nested class. Moved all the code
12517 dealing with collection foreach here.
12518 (Foreach.ForeachHelperMethods): Removed.
12519 (Foreach.TemporaryVariable): Implement IMemoryLocation.
12521 2005-05-23 Martin Baulig <martin@ximian.com>
12523 * statement.cs (Try.DoResolve): Don't create a `finally' if we
12524 don't need to. Fix #75014.
12526 2005-05-20 Martin Baulig <martin@ximian.com>
12528 Merged r44808 from GMCS.
12530 * class.cs (TypeContainer.CircularDepException): Removed.
12531 (TypeContainer.DefineType): Removed the `InTransit' stuff.
12532 (TypeContainer.CheckRecursiveDefinition): Check for circular class
12533 (CS0146) and interface (CS0529) dependencies here.
12535 2005-06-21 Raja R Harinath <rharinath@novell.com>
12537 * expression.cs (Invocation.EmitCall): Fix initialization
12538 'this_call' to reflect current behaviour. Fix indentation.
12540 * convert.cs (FindMostEncompassedType): Add two trivial special
12541 cases (number_of_types == 0 || number_of_types == 1).
12542 (FindMostEncompasingType): Likewise.
12544 2005-06-17 Raja R Harinath <rharinath@novell.com>
12546 Some cleanups preparing for the fix of #75283.
12547 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
12549 (EventExpr.InstanceResolve): Likewise.
12550 (EventExpr.DoResolve): Remove redundant checks.
12552 2005-06-10 Duncan Mak <duncan@novell.com>
12554 * cs-tokenizer.cs (process_directives): New flag for controlling
12555 the processing of preprocessor directives.
12556 (x_token): After seeing a '#', return Token.NONE instead of going
12557 to handle_preprocessing_directive() when not processing
12558 directives. This avoids unnecessary processing during the token peek in
12563 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
12564 the existing error reporting methods instead of Report.Error.
12566 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
12567 after Raja's rewrite.
12569 2005-06-08 Miguel de Icaza <miguel@novell.com>
12571 * class.cs: Small fix.
12573 2005-06-08 Raja R Harinath <rharinath@novell.com>
12576 * class.cs (GetPartialBases): Fix return value check of
12577 part.GetClassBases.
12579 2005-06-07 Raja R Harinath <rharinath@novell.com>
12581 Ensure that partial classes are registered in their enclosing
12582 namespace. Initial part of fix of #75160.
12583 * tree.cs (Tree.RecordDecl): Add new namespace argument.
12584 Register declspace with namespace here, not in
12585 DeclSpace.RecordDecl.
12586 * cs-parser.jay: Pass namespace to RecordDecl.
12587 * class.cs (PartialContainer.Create): Likewise.
12588 (ClassPart.DefineType): New sanity-check. Throws an exception if
12590 * decl.cs (Declspace.RecordDecl): Remove.
12591 * namespace.cs (NamespaceEntry.DefineName): Remove.
12593 2005-06-06 Marek Safar <marek.safar@seznam.cz>
12595 * rootcontext.cs: Reset TargetExt as well.
12597 2005-06-03 Raja R Harinath <rharinath@novell.com>
12599 * ecore.cs (Expression.Resolve): Emit CS0654 error when
12600 -langversion:ISO-1.
12602 2005-06-02 Raja R Harinath <rharinath@novell.com>
12604 Fix #75080, cs0119.cs.
12605 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
12607 (Expression.Resolve): ... this. Use it. Remove bogus code
12608 allowing ExprClass.Type and ExprClass.Namespace for
12609 ResolveFlags.VariableOrValue.
12610 (Expression.Resolve) [1-argument variant]: Change default resolve
12611 flags based on language version.
12612 (Expression.Error_UnexpectedKind): Use a simple string array
12613 rather than an ArrayList.
12614 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
12615 not ExprClass.Type.
12616 (TypeOfVoid.DoResolve): Likewise.
12617 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
12618 flags argument -- it always has the same value.
12620 2005-05-31 Raja R Harinath <rharinath@novell.com>
12623 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
12624 Use it in the error message.
12625 * assign.cs, expression.cs, statement.cs: Update.
12627 2005-05-30 Raja R Harinath <rharinath@novell.com>
12630 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
12631 the "almostMatchedMember" case too.
12632 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
12633 that failed the accessibility checks to 'almost_match'.
12635 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
12637 * attribute.cs: Use internal MethodBuilder methods to set
12638 ExactSpelling and SetLastError on PInvoke methods, instead
12639 of passing them via charset. Fixes #75060.
12641 2005-05-27 Raja R Harinath <rharinath@novell.com>
12643 * parameter.cs (Parameter): Remove TODO comment.
12644 (Parameter.DefineParameter): Remove Location parameter.
12645 (Parameters.LabelParameters): Likewise.
12646 * class.cs (Constructor.Emit): Update to change.
12647 (MethodData.Emit): Likewise.
12648 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
12649 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
12651 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
12654 Removed Parameters.Location and added Parameter.Location instead.
12655 Removed Location parameter from Emit() and GetSignature().
12662 Modified all related calls.
12664 2005-05-26 Raja R Harinath <rharinath@novell.com>
12666 Improve user-defined conversion handling.
12667 * convert.cs (GetConversionOperators): Rewrite. Return only the
12668 applicable operators.
12669 (AddConversionOperators): New. Helper for GetConversionOperators.
12670 (FindMostEncompassedType, FindMostEncompassingType): Verify that
12671 there is only one most encompassed/encompassing type.
12672 (FindMostSpecificSource, FindMostSpecificTarget): Remove
12673 "applicable operator" handling.
12674 (UserConversion): Move cache here from GetConversionOperators.
12675 Directly cache the chosen operator, rather than the whole
12677 (ExplicitNumericConversion): Fix buggy implementation of Decimal
12678 case. Allow conversion of decimal to sbyte and byte too.
12679 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
12680 New static methods. Used to avoid allocating EmptyExpressions in
12683 2005-05-24 Duncan Mak <duncan@novell.com>
12685 * ecore.cs (CastFromDecimal): New class for casting a decimal to
12686 another class, used in Convert.ExplicitNumericConversion.
12687 (CastToDecimal): New class, similar to above, but casts to
12688 System.Decimal, used in Convert.ImplicitNumericConversion and also
12689 in explicit convesion from double/float to decimal.
12691 * convert.cs (ImplicitNumericConversion): Handle implicit
12692 conversions to System.Decimal.
12693 (ExplicitNumericConversion): handle explicit conversions to
12698 2005-05-20 Miguel de Icaza <miguel@novell.com>
12700 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
12701 know the type at this stage, just break through. Fixes #75008
12703 2005-05-19 Martin Baulig <martin@ximian.com>
12706 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
12707 to disable error reporting.
12709 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
12710 here since we don't want to report an error; see the new test-336.cs.
12712 2005-05-19 Raja R Harinath <rharinath@novell.com>
12714 * statement.cs (ToplevelBlock.GetParameterReference)
12715 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
12716 Move here from class Block.
12717 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
12718 * expression.cs (ParameterReference.DoResolveBase): Likewise.
12720 2005-05-18 Martin Baulig <martin@ximian.com>
12725 (FlowBranching.Reachability): Add non-static public And() and Or()
12727 (FlowBranchingSwitch): New class; do the `break_origins' thing
12728 like in FlowBranchingLoop.
12729 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
12730 reachability, not just locals and parameters.
12731 (FlowBranching.MergeChild): Remove some of the hacks for loop and
12732 switch; MergeBreakOrigins() now takes care of that.
12734 2005-05-18 Martin Baulig <martin@ximian.com>
12736 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12737 a loop and may leave it, reset the barrier; fixes #74974.
12739 2005-05-17 Marek Safar <marek.safar@seznam.cz>
12741 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
12744 * cs-parser.jay: Catch more lexical errors.
12746 * report.cs: Add one more Error method.
12749 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
12751 2005-05-17 Martin Baulig <martin@ximian.com>
12753 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
12756 2005-05-16 Raja R Harinath <rharinath@novell.com>
12758 Fix test-382.cs. Emit values of decimal constants.
12759 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
12761 (TypeContainer.AddField): ... this.
12762 (TypeContainer.EmitFieldInitializers): Allow the list of fields
12763 with initializers to include 'Const's.
12764 (ClassPart.RegisterFieldForInitialization): Forward to
12766 * const.cs (Const.Const): Pass initializer to base class.
12767 (Const.Define): In case of decimal constants, register them for
12768 initialization in a static constructor.
12770 2005-05-14 Martin Baulig <martin@ximian.com>
12772 * statement.cs (Block.Resolve): Correctly handle unreachable code;
12773 do not call ResolveUnreachable() on unreachable statements in
12774 here, see the comment in the source code.
12776 2005-05-13 Raja R Harinath <rharinath@novell.com>
12779 * expression.cs (BinaryResolveOperator): If one of the operands of
12780 an equality comparison is 'null' and the other is a pointer type,
12781 convert the null to a NullPointer.
12782 * convert.cs (ImplicitReferenceConversion): If the expression is a
12783 NullLiteral and the target type is a pointer type, return a
12784 NullPointer instead.
12785 (ImplicitConversionStandard): Likewise.
12787 2005-05-13 Marek Safar <marek.safar@seznam.cz>
12789 * cs-parser.jay: Set readonly context based on special constructs.
12791 * expression.cs (LocalVariableReference.DoResolveBase): Improved
12792 readonly variable error handling.
12794 * rootcontext.cs (EmitCode): Don't verify members when error
12797 * statement.cs (LocalInfo): Add reaodnly context information.
12798 (SetReadOnlyContext, GetReadOnlyContext): New methods.
12800 2005-05-13 Raja R Harinath <rharinath@novell.com>
12802 * statement.cs (Block.Resolve): Revert change below. Modify fix
12803 for #74041 to initialize 'resolved' to false only for explicit
12804 blocks. Fixes #74873.
12806 2005-05-12 Raja R Harinath <harinath@gmail.com>
12809 * typemanager.cs (unmanaged_enclosing_types): New.
12810 (IsUnmanagedType): Avoid infloops by using
12811 'unmanaged_enclosing_types' to talk with recursive invocations.
12813 2005-05-13 Martin Baulig <martin@ximian.com>
12815 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
12816 instance variable, not a local. Fix #74873.
12817 (Block.ResolveUnreachable): Set it to true here.
12819 2005-05-11 Duncan Mak <duncan@novell.com>
12821 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
12822 continuing to process for 'arg'.
12823 (handle_preprocessing_directive): Check the argument of the #endif
12824 directive and report error CS1025 if there are any trailing
12827 According to the C# spec, having even whitespace after the #endif
12828 directive is illegal; however, because we call arg.TrimEnd ()
12829 beforehand, we have the same behavior as csc, allowing whitespace
12830 after the directive.
12834 2005-05-11 Marek Safar <marek.safar@seznam.cz>
12838 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
12839 (Constructor.GetObsoleteAttribute): Implemented correctly.
12841 2005-05-10 Martin Baulig <martin@ximian.com>
12843 * support.cs (ReflectionParameters.ParameterModifier): Use
12844 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
12845 and `ParameterAttributes.In'. Fixes #74884.
12847 2005-05-10 Marek Safar <marek.safar@seznam.cz>
12849 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
12851 * expression.cs (Argument.GetParameterModifier): Turned to property.
12852 (Invocation.Error_InvalidArguments): Add more descriptive errors.
12854 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
12857 2005-05-09 Raja R Harinath <rharinath@novell.com>
12860 * decl.cs (MemberCache.AddMethods): Register override methods,
12861 rather than non-override methods.
12862 * typemanager.cs (RegisterOverride): New.
12863 (IsOverride): Update.
12865 2005-05-09 Marek Safar <marek.safar@seznam.cz>
12869 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
12870 recursive declaration.
12872 * statement.cs (Block.ResolveMeta): Report any error in resolving.
12874 2005-05-06 Marek Safar <marek.safar@seznam.cz>
12876 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
12878 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
12880 2005-05-05 Raja R Harinath <rharinath@novell.com>
12883 * decl.cs (DeclSpace.FamilyAccessible):
12884 Use TypeManager.IsNestedFamilyAccessible.
12886 Fix reopened #64812.
12887 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
12890 2005-05-04 Raja R Harinath <rharinath@novell.com>
12891 Abin Thomas <projectmonokochi@rediffmail.com>
12892 Anoob V E <projectmonokochi@rediffmail.com>
12893 Harilal P R <projectmonokochi@rediffmail.com>
12896 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
12897 allow access to all static members.
12899 2005-05-04 Martin Baulig <martin@ximian.com>
12901 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
12903 2005-05-04 Martin Baulig <martin@ximian.com>
12907 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
12908 section at the end; make things work if `default' is not the last
12911 2005-05-04 Martin Baulig <martin@ximian.com>
12915 * statement.cs (Switch): Replaced the `got_default' field with a
12916 `default_section' one.
12917 (Switch.CheckSwitch): Set `default_section' here.
12918 (Switch.Resolve): If we're a constant switch and the constant is
12919 not found, use the default section.
12921 2005-05-03 Martin Baulig <martin@ximian.com>
12923 * expression.cs (ArrayAccess.EmitGetLength): New public method.
12925 * statement.cs (Foreach.ArrayForeach): New nested class.
12926 (Foreach.TemporaryVariable): New nested class.
12927 (Foreach.EmitArrayForeach): Removed; this is now in the new
12928 ArrayForeach class.
12930 2005-05-03 Raja R Harinath <rharinath@novell.com>
12932 * pending.cs (BaseImplements): Move the #74773 fix here. This is
12934 (VerifyPendingMethods): Revert change below.
12936 * typemanager.cs (IsOverride, RegisterNonOverride): New.
12937 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
12938 that used to trigger warning -28. Remove warning -28.
12939 * expression.cs (Invocation.OverloadResolve): Use
12940 TypeManager.IsOverride to distinguish override methods.
12943 * pending.cs (VerifyPendingMethods): If a base type implements the
12944 requested interface, don't bother checking individual methods of
12945 the base type. As a side-effect, this prevents the creation of
12946 unnecessary proxies.
12948 2005-05-02 Martin Baulig <martin@ximian.com>
12952 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12953 Also `And' the locals if the old vector is null.
12954 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
12955 null; in this case we basically reset all the variables.
12957 2005-05-02 Martin Baulig <martin@ximian.com>
12961 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
12962 Added `FlowBranching branching' argument; always `and' the
12963 variables instead of `or'ing them unless we're an infinite loop.
12965 * statement.cs (While.Resolve): Create a new sibling unless we're
12968 2005-05-02 Martin Baulig <martin@ximian.com>
12972 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
12973 arguments; use it instead of creating a new TopLevelBlock.
12974 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
12975 our ConstructorInitializer.
12978 (TopLevelBlock.TopLevelBranching): New public property.
12979 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
12980 and create our `TopLevelBranching'.
12982 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
12983 anonymous method host, use `block.TopLevelBranching' rather than
12984 creating a new branching.
12986 2005-04-20 Miguel de Icaza <miguel@novell.com>
12988 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
12989 a ScopeInfo, if any of the current children is a child of the new
12990 entry, move those children there.
12992 2005-04-30 Martin Baulig <martin@ximian.com>
12994 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
12995 at the beginning of a SwitchSection. Fix #73335.
12997 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13000 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13002 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13003 (FieldExpr.DoResolve): Obsolete members are ignored for field
13006 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13008 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13009 of arrays detection.
13011 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13013 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13015 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13018 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13020 * cs-parser.jay: Use the prefered version of -unsafe in error
13023 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13025 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13028 2005-04-20 John Luke <john.luke@gmail.com>
13030 * driver.cs: fix typo in error message, --outout to --output
13032 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13034 * codegen.cs (InRefOutArgumentResolving): New field.
13036 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13037 fields outside contructor.
13039 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13041 2005-04-19 Miguel de Icaza <miguel@novell.com>
13043 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13044 parameter code was not completed ever, so it was not as up-to-date
13045 as local variables. Must finish it.
13047 The bug fix was to compare the Toplevel of the block, not the
13048 current block. Thanks for Ben for pointing this out.
13050 2005-04-19 Raja R Harinath <rharinath@novell.com>
13052 * decl.cs (AddMethods): Use the declaring type of the problem
13053 method to determine if we want to squash a warning.
13055 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13057 * attribute.cs: Removed debug output.
13059 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13061 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13064 2005-04-18 Raja R Harinath <rharinath@novell.com>
13067 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13068 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13069 all null comparisons against reference types.
13071 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13074 * class.cs (TypeContainer.CircularDepException) New nested
13076 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13077 (TypeContainer.DefineType): Removed error, reset InTransit before
13079 (Class.DefineType): Throw exception when is in Transit.
13080 Catch exception and report error.
13081 (Struct.DefineType): Throw exception when is in Transit.
13082 Catch exception and report error.
13083 (Interface.DefineType): Throw exception when is in Transit.
13084 Catch exception and report error.
13086 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13087 handle nested exception handlers.
13089 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13092 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13093 InFinally and InCatch storage.
13095 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13096 (Catch.Resolve): Set and Restore ec.InCatch.
13097 (Try.Resolve): Set and Restore ec.InFinally.
13098 (Try.HasCatch): True when try has catch.
13100 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13102 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13103 for the same event member, so exclude such cases from warning 419.
13106 2005-04-16 Miguel de Icaza <miguel@novell.com>
13108 * expression.cs (Binary.ResolveOperator): Apply patch from John
13109 Luke to fix bug 59864: operators &, | and ^ on enumerations
13110 require that the same enum type on both sides.
13112 * driver.cs: Add warnings to old flag usage, this is to assist
13113 people who produce Makefiles and hope that the Makefiles will be
13116 * class.cs (TypeContainer.EmitType): Moved the definition of the
13117 special $PRIVATE$ field from the resolve phase to the Emit phase.
13118 During resolve we do not know if we are a struct with
13119 HasExplicitLayout, we know this only after the attributes for the
13122 Set the FieldOffset to zero on the dummy field that we create for
13123 the class. Fixes 74590.
13125 2005-04-16 Raja R Harinath <rharinath@novell.com>
13128 * ecore.cs (PropertyExpr.resolved): New.
13129 (DoResolve): Use it to handle a case of double resolution here.
13130 Handle a case of identical-name-and-type-name.
13131 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13132 resolution by storing the results of expression resolution back
13133 into the "probes" array.
13135 2005-04-15 Raja R Harinath <rharinath@novell.com>
13137 Fix cs0208-7.cs and cs0208-8.cs.
13138 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13139 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13140 error reporting to point out the reason a struct is not unmanaged.
13142 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13144 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13145 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13147 2005-04-13 Raja R Harinath <rharinath@novell.com>
13150 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13151 IdenticalNameAndTypeName here.
13152 (EventExpr.InstanceResolve): Likewise.
13154 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13156 C# 2.0 DefaultCharSetAttribute implementation
13158 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13159 which allows us to set GlobalNamespace for every resolve.
13160 (Attribute.ResolveArguments): Cut from Resolve.
13161 (Attribute.GetCharSetValue): Returns CharSet named argument.
13162 (Attribute.DefinePInvokeMethod): Gets default charset from
13164 (GlobalAttribute.ResolveAsTypeStep): Override.
13165 (GlobalAttribute.ResolveArguments): Override.
13167 * class.cs (TypeAttr): Is protected.
13169 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13170 (ModuleClass.DefaultCharSetType): New memeber.
13171 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13173 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13174 charset from module.
13176 * delegate.cs (TypeAttr): Override.
13177 (Delegate.DefineType): Use this TypeAttr.
13179 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13180 at very early stage (before types are defined) to resolve model
13181 module attributes. It will probably not work with corlib but it
13184 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13185 charset from module.
13187 * typemanager.cs (default_charset_type): New type.
13189 2005-04-13 Raja R Harinath <rharinath@novell.com>
13191 * decl.cs (MemberCache.AddMethods): Don't warn if
13192 System.Object.Finalize has buggy MethodAttributes.
13194 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13197 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13199 * doc.cs : detect ambiguous reference to overloaded members.
13200 Fixed bug #71603. MS 1.1 csc does not detect it.
13202 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13204 * doc.cs : delegates must not be referenced with parameters.
13207 2005-04-12 Miguel de Icaza <miguel@novell.com>
13209 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13211 2005-04-10 Miguel de Icaza <miguel@novell.com>
13213 * driver.cs (MainDriver): Stop processing if the CLS stage found
13216 (CompilerCallableEntryPoint.InvokeCompiler): Always
13217 reset after execution; Take a TextWriter argument for the
13220 * report.cs: Use the error stream instead of hardcoding stderr.
13222 2005-04-09 Miguel de Icaza <miguel@novell.com>
13224 * class.cs: Reduce code paths to test, too small of an
13225 optimization to make it worth the extra testing. Always perform
13228 2005-04-08 Raja R Harinath <rharinath@novell.com>
13231 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13232 operators that had errors reported on them.
13234 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13236 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13238 (Attribute.Resolve): Add named argument type checking.
13240 * class.cs (FixedField.Define): Use IsPrimitiveType
13242 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13244 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13245 unsafe parameter types.
13247 * statement.cs (Using.ResolveExpression): Add better error description.
13249 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13251 2005-04-08 Raja R Harinath <rharinath@novell.com>
13254 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13255 AttributeUsageAttribute in the emitcontext of the attribute class,
13256 not in the emitcontext of the attributable entity it was attached to.
13257 * cs-parser.jay: Use 'current_class', not 'current_container',
13258 when creating a GlobalAttribute.
13260 2005-04-08 Alp Toker <alp@atoker.com>
13262 * pending.cs: The fix to #58413 failed to compile methods implementing
13263 interfaces with/without params modifiers and vice versa, even though
13264 params modifiers aren't part of the signature. Make the modifier check
13265 less strict as in csc.
13267 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13268 Anoob V E <projectmonokochi@rediffmail.com>
13269 Harilal P R <projectmonokochi@rediffmail.com>
13272 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13273 modifiers of pending methods.
13274 (PendingImplementation.PendingImplementation): Initialize it.
13275 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13276 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13277 with ParameterData. Add check for modifiers.
13278 * class.cs (MethodData.Define): Update to changes.
13280 2005-04-07 Raja R Harinath <rharinath@novell.com>
13282 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13284 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13286 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13289 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13292 * typemanager.cs: Registered RequiredAttributeAttribute.
13294 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13296 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13297 Warning CS0169 is back at level 3.
13298 (IMethodData.SetMemberIsUsed): New method.
13300 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13301 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13303 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13305 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13307 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13310 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13313 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13314 to avoid the problems with nested types.
13316 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13317 Anoob V.E <projectmonokochi@rediffmail.com>
13318 Harilal P.R <projectmonokochi@rediffmail.com>
13319 Raja R Harinath <rharinath@novell.com>
13322 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13324 * typemanager (GetConstructor): Make public.
13326 2005-04-05 John Luke <john.luke@gmail.com>
13327 Raja R Harinath <rharinath@novell.com>
13330 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13331 struct too. Return false quicker in a few cases.
13332 (VerifyUnManaged): Use it.
13334 2005-04-05 Raja R Harinath <rharinath@novell.com>
13337 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13338 not 'unreachable_seen'.
13340 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13342 * attribute.cs (Attribute.GetValue): Removed unused.
13344 * codegen.cs (CodeGen.TrimExt): Removed unused.
13346 * cs-parser.jay (output): Removed unused.
13348 * cs-tokenizer.cs (hex_digits): Removed unused.
13350 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13352 * expression.cs (Indirection.LoadExprValue): Removed unused.
13353 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13355 * iterators.cs (Iterator.param_types): Removed unused.
13357 * statement.cs (Goto.block): Removed unused.
13358 (ToplevelBlock.did): Removed unused.
13359 (Switch.ResolveConstantSwitch): Removed unused.
13361 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13363 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13366 2005-04-01 Raja R Harinath <rharinath@novell.com>
13368 Fix #74232 and cs0208-3.cs.
13369 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13370 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13371 unmanaged type. Don't use FieldBuilders when 't' is a
13372 TypeBuilder. Use ModFlags and MemberType fields.
13373 * class.cs (MemberBase.member_type): Rename from MemberType.
13374 (MemberBase.MemberType): New property. Determines member_type on
13376 (MemberBase.DoDefine): Don't initialize MemberType here.
13377 (FieldMember.Define): Likewise.
13379 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13382 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13383 Attributes are emitted there.
13385 2005-04-01 Raja R Harinath <rharinath@novell.com>
13387 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13388 keyword in 'partial enum' too.
13389 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13391 Report from Kamil Skalski <nazgul@omega.pl>.
13394 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13395 have partial containers too.
13397 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13398 in block' checks to Block.CheckInvariantMeaningInBlock.
13399 * statement.cs (Block.GetKnownVariableInfo): Make private.
13400 (Block.IsVariableUsedInChildBlock): Remove.
13401 (Block.IsVariableUsedInBlock): Likewise.
13402 (Block.CheckInvariantMeaningInBlock): New. Show location of
13403 conflicting declaration.
13404 (Block.AddVariable): Make error messages less long-winded and more
13405 specific. Show location of conflicting declaration.
13406 * parameter.cs (Parameters.Location): New readonly property.
13408 2005-03-31 Raja R Harinath <rharinath@novell.com>
13410 Clean up semantics of invoking ResolveMemberAccess.
13411 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13412 can have an instance, ensure that we pass in a non-TypeExpression
13413 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13414 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13415 argument. Update to changes and simplify.
13416 (FieldExpr.Emitinstance): Remove CS0120 check.
13417 (PropertyExpr.EmitInstance): Likewise.
13418 * expression.cs (Argument.Resolve): Likewise.
13419 (Invocation.DoResolve): Update to changes in semantics of
13420 InstanceExpression.
13422 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13425 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13428 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13430 2005-03-31 Raja R Harinath <rharinath@novell.com>
13432 Fix difference in behaviour with commandline invocation.
13433 * driver.cs (Driver.Reset): New.
13434 (CompilerCallableEntryPoint): Call it.
13436 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13437 variable" warnings if the boolean expression failed to resolve.
13439 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13441 * attribute.cs: Fix the union of several permissions when some of them
13442 are unrestricted (so the result isn't an unrestricted permission set).
13445 2005-03-30 Raja R Harinath <rharinath@novell.com>
13447 * ecore.cs (MemberExpr): New class. Convert from interface
13449 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13450 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13452 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13453 (MethodGroupExpr.IsExplicitImpl): Remove.
13454 (Expression.GetFieldFromEvent): Remove.
13455 (SimpleName.MemberStaticCheck): Remove.
13456 (SimpleName.DoSimpleNameResolve): Update to changes.
13457 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13458 (MemberAccess.IdenticalNameAndTypeName): Remove.
13459 (MemberAccess.error176): Move to MemberExpr.
13460 (MemberAccess.DoResolve): Update to changes.
13461 (BaseAccess.DoResolve): Likewise.
13463 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13465 C# 2.0 Conditional attribute class implementation
13467 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13468 Analyzes class whether it has attribute which has ConditionalAttribute
13469 and its condition is not defined.
13471 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13472 (Class.IsExcluded): New method. Search for at least one defined
13473 condition in ConditionalAttribute of attribute class.
13475 2005-03-30 Raja R Harinath <rharinath@novell.com>
13477 * ecore.cs (PropertyExpr): Derive from Expression, not
13478 ExpressionStatement.
13479 (PropertyExpr.EmitStatement): Remove.
13481 2005-03-29 Raja R Harinath <rharinath@novell.com>
13484 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13485 internal field "value__" of an enum be private. The examples for
13486 "value__" that I found on MSDN all used FieldAttributes.Private.
13488 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13489 Don't mention IL method attribute names.
13491 Fix #47991. Remove a TODO.
13492 * statement.cs (Block.Toplevel): Make into a field.
13493 (Block.Parameters): Move into ToplevelBlock.
13494 (Block.known_variables): Rename from child_variable_names.
13495 (Block.Block): Remove variants that take Parameters. Initialize
13496 'Toplevel' with the immediately surrounding toplevel block.
13497 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
13498 LocalInfo parameter.
13499 (Block.GetKnownVariableInfo): New.
13500 (Block.IsVariableNameUsedInChildBlock): Update.
13501 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
13502 the block, even though it may not be in scope.
13503 (Block.AddVariable): Remove Parameters parameter. Use
13504 Toplevel.Parameters instead.
13505 (Block.AddConstant): Remove Parameters parameter.
13506 (Block.GetParameterReference): Update to use Toplevel.Parameters.
13507 (Block.IsParamaterReference): Likewise.
13508 (Block.IsLocalParameter): Likewise. Simplify a lot.
13509 (ToplevelBlock.Parameters): New. Moved from Block.
13510 (ToplevelBlock.ToplevelBlock): Update to changes. Always
13511 initialize Parameters to a non-null value.
13512 * cs-parser.jay: Update to changes.
13513 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
13514 simple names that mean different things in the same block. Use
13515 Block.IsVariableNameUsedInBlock.
13517 2005-03-28 Raja R Harinath <rharinath@novell.com>
13519 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
13520 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
13521 GetTypeHandle. It is possible for a reflected type to derive from
13522 a TypeBuilder (e.g., int[] derives from the TypeBuilder
13523 System.Array during mscorlib compilation).
13524 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
13525 contain a method_hash, don't create one either. Don't create a
13526 deep copy of the base cache's method_hash.
13527 (MemberCache.SetupCache): Rename back from DeepCopy.
13528 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
13529 already initialized. If we see an override function, add its
13530 underlying base virtual function to the member_hash too.
13532 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
13534 2005-03-26 Raja R Harinath <harinath@acm.org>
13537 * assign.cs (Assign.DoResolve): When the RHS of an assignment
13538 fails to resolve, ensure that the LHS is still resolved as an
13541 2005-03-25 Raja R Harinath <harinath@acm.org>
13543 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
13545 (Enum.current_ec): Remove.
13546 (Enum.LookupEnumValue): Remove EmitContext argument.
13547 Just uses the one created during DefineType.
13548 (Enum.FindMembers): Update.
13549 * expression.cs (MemberAccess.DoResolve): Update.
13551 2005-03-22 Marek Safar <marek.safar@seznam.cz>
13553 * assign.cs (Assign.DoResolve): Check for CS1717 when
13554 source and target are same (uses Equals).
13556 * expression.cs (LocalVariableReference, ParameterReference,
13557 This): Implemented Equals, GetHashCode.
13559 * statement.cs (Block.GetParameterReference): Removed useless
13562 2005-03-22 Raja R Harinath <rharinath@novell.com>
13565 * statement.cs (Block.AddVariable): Ensure that we skip implicit
13566 blocks before deciding whether the error is cs0136 or cs0128.
13568 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
13569 (using_alias_directive, using_namespace_directive): Pass
13570 MemberName, not an expression to Namespace.UsingAlias and
13572 (MakeName): Use the MemberName of the namespace.
13573 * namespace.cs (Namespace.MemberName): New.
13574 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
13575 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
13577 * decl.cs (MemberName.Name): Make readonly.
13578 (MemberName.FromDotted): New "constructor".
13579 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
13580 (MemberCore.Name): Compute from MemberName on demand.
13581 (MemberCore.SetMemberName): Provide a way to change the
13583 (MemberCore.AddToContainer): Don't take a fullname parameter.
13584 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
13585 fully qualified name of the container to the member name.
13586 (TypeContainer.AddToTypeContainer): Use a fully qualified name
13587 only if the type is a member of the root container.
13588 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
13589 MemberName.Left rather than searching for an embedded ".".
13590 (PartialContainer.CreatePart): Update to changes in RootContext.
13591 (MemberBase.ShortName): Turn into a property. Use
13592 MemberCore.SetMemberName.
13593 (MemberBase.ExplicitInterfaceName): Remove.
13594 (MemberBase.UpdateMemberName): Remove.
13595 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
13596 (PropertyBase.SetMemberName): New override.
13597 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
13598 (Tree.GetDecl): New.
13599 (Tree.AllDecls): Rename from Decls.
13600 * attribute.cs, enum.cs, report.cs: Update to changes.
13601 * driver.cs (MainDriver): Use MemberName.FromDotted on
13602 RootContext.MainClass.
13604 2005-03-21 Marek Safar <marek.safar@seznam.cz>
13606 * class.cs (FixedField.Define): Check for CS1664 and more sanity
13609 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
13611 2005-03-18 Marek Safar <marek.safar@seznam.cz>
13613 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
13614 property accessor modifiers.
13616 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
13617 fixed buffer attribute (CS1716).
13618 (PropertyMethod.HasCustomAccessModifier): When property accessor
13619 has custom modifier.
13621 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
13623 (PropertyExpr.DoResolveLValue): Add CS0272.
13625 2005-03-17 Miguel de Icaza <miguel@novell.com>
13627 * convert.cs: When converting to a pointer, use the proper Conv.U
13628 or Conv.I depending on the source data type.
13630 * cs-tokenizer.cs: Make the size for large decimal constants,
13633 2005-03-17 Martin Baulig <martin@ximian.com>
13635 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
13636 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
13638 2005-03-17 Martin Baulig <martin@ximian.com>
13640 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
13641 to bool so we can return an error condition.
13642 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
13645 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
13647 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
13650 2005-03-16 Raja R Harinath <rharinath@novell.com>
13652 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
13653 Refactor to avoid traversing the list of assemblies, and to avoid
13654 string concatenation.
13655 * typemanager.cs (guid_attr_type): Remove.
13656 (negative_hits, pointers, references): Remove hashes.
13658 (GetConstructedType): New. Uses type_hash to handle constructed
13659 types (arrays, references, pointers).
13660 (GetReferenceType, GetPointerType): Use it.
13661 (GetNestedType): New. Uses type_hash to handle nested types of
13663 (LookupType, LookupTypeDirect): Remove.
13664 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
13665 'types' hash and LookupTypeReflection directly.
13666 (params_string, params_object): Use GetConstructedType.
13667 * namespace.cs (Namespace.cached_types): New. Cache of reflected
13669 (Namespace.Lookup): Use cached_types.
13670 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
13671 provided by old TypeManager.LookupType.
13672 * rootcontext.cs (MakeFQN): Remove.
13673 * decl.cs (DeclSpace.MakeFQN): Likewise.
13674 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
13675 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13676 TypeManager.GetConstructedType.
13677 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
13679 2005-03-15 Marek Safar <marek.safar@seznam.cz>
13681 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
13684 * cs-parser.jay: Reports CS1527 for any namespace element.
13686 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
13689 * expression.cs (ParameterReference.IsAssigned): Changed error to
13691 (Error_WrongNumArguments): Moved CS0245 detection here.
13693 * statement.cs (Return.Resolve): Add CS1622 report.
13695 2005-03-11 Marek Safar <marek.safar@seznam.cz>
13697 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
13699 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
13701 * attribute.cs expression.cs: Get rid of some allocations.
13703 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
13705 * doc.cs : just eliminate the latest change.
13707 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13709 * doc.cs : commented out the latest change. It breaks xml-030.cs
13711 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13713 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
13714 fail. So invoke CreateType() in FindDocumentedType().
13716 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13718 * cs-tokenizer.cs : added IsKeyword().
13719 * doc.cs : Detect keyword incorrectly used as identifier.
13720 Allow identifiers prefixed by @.
13722 2005-03-10 Marek Safar <marek.safar@seznam.cz>
13724 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
13725 It caused exception in namespace resolving (again!).
13727 * class.cs (Class.ctor): Removed exit.
13728 (PropertyMethod.ctor): ditto.
13730 * codegen.cs (Codegen.Reset): Reset static data.
13731 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
13733 * cs-tokenizer.cs (Cleanup): Removed.
13735 * driver.cs (GetSystemDir): Rewrote to one line command.
13736 It caused problem with unloaded dynamic modules.
13737 (UnixParseOption): Removed Exit.
13738 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
13739 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
13740 Now can be mcs used as library.
13742 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
13745 * location.cs (Reset): Reset static data.
13747 * namespace.cs (Reset): Reset static data.
13749 * report.cs (Report.Reset): Reset static data.
13751 * rootcontext.cs (RootContext.Reset): Reset static data.
13753 * tree.cs (RootTypes.ctor): Use Location.Null
13755 * typemanager.cs (TypeManager.Reset): Reset static data.
13756 (CoreLookupType): Removed Exit.
13757 (TypeHandle.Reset): Reset static data.
13759 2005-03-10 Raja R Harinath <rharinath@novell.com>
13762 * typemanager.cs (ComputeNamespaces): Import namespaces from
13763 referenced modules too.
13765 2005-03-09 Raja R Harinath <rharinath@novell.com>
13767 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
13770 2005-03-09 Raja R Harinath <rharinath@novell.com>
13772 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
13773 enclosing DeclSpace. This ensures that a name-lookup populates
13774 more caches and there are fewer 'TypeExpression's. Carve out
13775 nested type lookup into ...
13776 (LookupNestedTypeInHierarchy): ... this.
13778 2005-03-09 Raja R Harinath <rharinath@novell.com>
13780 Clean up a few partial-class semantics.
13781 Fixes test-357.cs and cs1618-2.cs.
13782 * cs-parser.jay (struct_declaration): Use 'current_class' as
13783 parent of newly-created struct. Remove call to Register ().
13784 Use 'pop_current_class' to complete handing the current struct.
13785 (interface_declaration): Likewise.
13786 (class_declaration): Likewise.
13787 (enum_declaration): Use 'current_class' as parent of newly created
13789 (delegate_declaration): Likewise.
13790 (pop_current_class): New function. This is used to handle closing
13791 up the 'current_class' and 'current_container', and pointing them
13792 to the enclosing class/container.
13793 (CSharpParser): Initialize 'current_class' too.
13794 * decl.cs (MemberCore): Add check for invariant: a partial
13795 container is not a parsed entity, and thus does not enclose any
13797 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
13798 (DeclSpace.BaseTypeExpr): Use it.
13799 (DeclSpace.LookupType): Add check for invariant.
13800 * class.cs (TypeContainer): Add check for invariant: a nested
13801 class should have the same NamespaceEntry as its enclosing class.
13802 (TypeContainer.EmitFieldInitializers): Make virtual.
13803 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
13805 (TypeContainer.Register): Remove.
13806 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
13807 null. Use TypeResolveEmitContext for resolving base types and
13808 interfaces. Move initialization of Parts.TypeBuilder here from
13810 (TypeContainer.DefineNestedTypes): ... here.
13811 (PartialContainer): Take a Namespace not a NamespaceEntry.
13812 (PartialContainer.Create): Don't use Register. Call the
13813 appropriate Add... function directly.
13814 (ClassPart): Take both the PartialContainer and the enclosing
13815 class as constructor arguments.
13816 (ClassPart.EmitFieldInitializers): Override.
13817 (ClassPart.PartFindNestedTypes): Remove.
13818 (FieldBase.GetInitializerExpression): Resolve the initializer
13819 expression in the emit context of the enclosing class.
13820 * tree.cs (RootTypes): Remove Register ().
13822 2005-03-08 Marek Safar <marek.safar@seznam.cz>
13824 * cs-parser.jay: Removed CS0134.
13826 * driver.cs: Removed CS1901.
13828 * expression.cs (SizeOf.DoResolve): Don't report CS0233
13829 for predefined types.
13831 2005-03-07 Duncan Mak <duncan@novell.com>
13833 * codegen.cs (Save): Catch UnauthorizedAccessException as
13834 well. Fixes bug #73454.
13836 2005-03-07 Marek Safar <marek.safar@seznam.cz>
13838 * cs-tokenizer.cs (xtoken): Add CS1035.
13840 * class.cs (MethodData.Define): Add CS0683.
13841 (FieldMember.ctor): Add CS0681.
13843 2005-03-07 Raja R Harinath <rharinath@novell.com>
13845 * ecore.cs (SimpleName.DoResolve): Rename from
13846 SimpleName.DoResolveAllowStatic.
13847 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
13848 Pass 'intermediate' flag to MemberStaticCheck.
13849 (SimpleName.MemberStaticCheck): Skip "static check" only in case
13850 of "intermediate" lookups via MemberAccess.
13851 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
13852 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
13854 2005-03-07 Raja R Harinath <rharinath@novell.com>
13857 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
13858 slipped in because of variable names that are identical to a
13859 builtin type's BCL equivalent ('string String;', 'int Int32;').
13860 (PropertyExpr.EmitInstance): Likewise.
13862 2005-03-04 Marek Safar <marek.safar@seznam.cz>
13864 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
13866 * report.cs (warning_ignore_table): Made public.
13868 2005-03-04 Raja R Harinath <rharinath@novell.com>
13871 * class.cs (MethodData.Emit): Pass 'container' to
13872 container.GetObsoleteAttribute instead of 'container.Parent'.
13874 2005-03-03 Marek Safar <marek.safar@seznam.cz>
13876 * cs-parser.jay: Add 1534 error test.
13878 * iterators.cs (Yield.CheckContext): Add error 1629.
13879 (Iterator.ctor): Save unsafe modifier.
13880 (MoveNextMethod.DoEmit): Restore unsafe context.
13882 * namespace.cs (UsingAlias): Better error message.
13884 2005-03-03 Dan Winship <danw@novell.com>
13886 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
13887 the warning message [#73219]
13889 2005-03-03 Raja R Harinath <rharinath@novell.com>
13891 Fix compile with MCS 1.0.0.0.
13892 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
13893 w_restore to not depend on string constant folding.
13895 2005-03-03 Raja R Harinath <rharinath@novell.com>
13897 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
13898 CS0246 check to users who passed 'silent = false'.
13899 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
13901 (SimpleName.SimpleNameResolve): Update.
13902 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
13903 (MemberAccess.IdenticalNameAndTypeName): Update.
13904 * doc.cs (FindDocumentedTypeNonArray): Update.
13906 2005-03-03 Raja R Harinath <rharinath@novell.com>
13908 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
13909 * parameters.cs (ComputeAndDefineParameters): Remove.
13910 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
13911 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
13912 Use GetParameterInfo.
13914 2005-03-02 Marek Safar <marek.safar@seznam.cz>
13916 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
13918 2005-03-02 Raja R Harinath <rharinath@novell.com>
13920 Unify DeclSpace.LookupType and DeclSpace.FindType.
13921 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
13922 is in charge of defining nested types on demand.
13923 (DeclSpace.LookupType): Use it when the current_type is a
13924 TypeBuilder. Use LookupTypeDirect for reflected types.
13925 (DeclSpace.FindType): Remove.
13926 (DeclSpace.LookupInterfaceOrClass): Likewise.
13927 (DeclSpace.DefineTypeAndParents): Likewise.
13928 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
13929 DeclSpace.LookupType.
13930 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
13931 * typemanager.cs (LookupType): Simplify.
13932 (AddUserType): Remove type from negative_hits.
13933 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
13934 * class.cs (TypeContainer.FindMembers): Move handling of nested
13936 (TypeContainer.FindMembers_NestedTypes): ... here.
13937 (TypeContainer.FindNestedType): Implement override.
13938 (ClassPart.FindNestedType): Delegate to PartialContainer.
13939 (ClassPart.PartFindNestedType): Looks up the nested types of the
13942 2005-03-02 Martin Baulig <martin@ximian.com>
13944 * class.cs (TypeContainer.DoDefineMembers): We also need a default
13945 static constructor in static classes.
13947 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
13949 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
13950 sizeParamIndex is not specified.
13952 2005-03-01 Marek Safar <marek.safar@seznam.cz>
13955 * report.cs (WarningMessage.IsEnabled): Missing null check.
13957 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13959 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
13960 in the fields and not in the properties.
13962 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
13964 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
13967 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13969 * attribute.cs: Small refactoring (improved robustness).
13970 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
13971 (ValidateGuid): Removed.
13972 (Resolve): Removed referenced to above mentioned.
13973 (GetAttributeUsage): Made private and changed to work without
13975 (GetIndexerAttributeValue): Don't crash.
13976 (GetConditionalAttributeValue): Ditto.
13977 (GetClsCompliantAttributeValue): Ditto.
13978 (ExtractSecurityPermissionSet): All attributes exceptions are
13980 (GetPropertyValue): New helper.
13981 (GetMethodImplOptions): New method.
13982 (DefinePInvokeMethod): Reuse common code. Implemented handling of
13983 some missing properties.
13985 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
13986 (Method.ApplyAttributeBuilder): Updated.
13988 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
13991 2005-02-28 Raja R Harinath <rharinath@novell.com>
13994 * report.cs (Report.SymbolRelatedToPreviousError): Handle
13995 non-simple types (array, pointer, reference).
13997 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13999 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14001 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14003 (Method.CheckBase): Catch wrong destructor here.
14004 (MethodData.Define): Add errors 550, 668.
14006 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14008 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14010 * pending.cs (VerifyPendingMethods): Add error 551.
14012 * typemanager.cs (CSharpName): Next error report helper.
14014 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14016 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14017 attributes. Removed useless attribute double check.
14018 It saves almost 2MBs for corlib.
14020 2005-02-25 Raja R Harinath <rharinath@novell.com>
14023 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14024 called twice in case of error.
14026 2005-02-23 Chris Toshok <toshok@ximian.com>
14028 Fix compiler portions of #72827.
14029 * statement.cs (Block.Emit): call Begin/EndScope on the
14030 EmitContext instead of the ILGenerator.
14032 * codegen.cs (EmitContext.BeginScope): new method, call
14033 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14035 (EmitContext.BeginScope): same, but EndScope and CloseScope
14037 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14038 offset and call the superclass's OpenScope(int) with it.
14039 (SymbolWriter.CloseScope): get the current il
14040 offset and call superclass's CloseScope(int) with it.
14042 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14044 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14045 CS1677 for out and ref as well.
14047 * class.cs (Method.Define): Add error CS1599 detection.
14049 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14051 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14053 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14055 * support.cs.cs (ModifierDesc): New helper method.
14057 2005-02-23 Raja R Harinath <rharinath@novell.com>
14058 Abin Thomas <projectmonokochi@rediffmail.com>
14059 Anoob V E <projectmonokochi@rediffmail.com>
14060 Harilal P R <projectmonokochi@rediffmail.com>
14062 Fix #57851, #72718.
14063 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14064 MemberLookup (used for error reporting) actually returns a result.
14065 Fix error report number (122, not 112).
14067 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14068 Anoob V E <projectmonokochi@rediffmail.com>
14069 Harilal P R <projectmonokochi@rediffmail.com>
14072 * pending.cs (PendingImplementation.GetAbstractMethods):
14073 Find NonPublic members too.
14075 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14077 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14080 * class.cs (MethodCore.CheckMethodAgainstBase):
14081 Add error 239 report.
14083 2005-02-21 Raja R Harinath <rharinath@novell.com>
14086 * expression.cs (Invocation.IsApplicable): Make public.
14087 (Invocation.IsParamsMethodApplicable): Likewise.
14088 * delegate.cs (Delegate.VerifyApplicability): Don't use
14089 Invocation.VerifyArgumentCompat for parameter applicability
14090 testing. Use Invocation.IsApplicable and
14091 Invocation.IsParamsMethodApplicable.
14093 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14095 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14097 * class.cs (Operator.Define): Add error 217 report.
14099 2005-02-21 Raja R Harinath <rharinath@novell.com>
14101 * namespace.cs (UsingEntry.Resolve): Undo change below.
14103 2005-02-21 Raja R Harinath <rharinath@novell.com>
14106 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14107 disable the error message when the extended MemberLookup also
14109 (Expression.MemberLookupFinal): Update.
14110 (SimpleName.DoSimpleNameResolve): Update.
14111 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14112 Don't use MemberLookupFinal.
14113 (New.DoResolve): Update.
14114 (BaseAccess.CommonResolve): Update.
14116 2005-02-21 Raja R Harinath <rharinath@novell.com>
14119 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14120 occured previously, don't resolve again.
14122 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14125 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14126 argument. Call ResolveAttributeUsage for unresolved.
14127 when types doesn't match ctor arguments.
14129 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14130 for nested attribute classes.
14131 (Class.attribute_usage): Removed.
14132 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14133 for attribute class.
14135 * ecore.cs (IsAttribute): Removed.
14137 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14139 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14141 (attribute_types): Removed.
14142 (EmitCode): Global attributes are emited as the latest.
14144 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14146 * class.cs (EmitFieldInitializers): Don't emit field initializer
14147 for default values when optimilization is on.
14149 * constant.cs (Constant.IsDefaultValue): New property.
14151 * driver.cs: Add /optimize handling.
14155 * literal.cs: Implement new IsDefaultValue property.
14157 * rootcontext.cs (Optimize): New field, holds /optimize option.
14159 2005-02-18 Raja R Harinath <rharinath@novell.com>
14161 Fix crasher in re-opened #72347.
14162 * namespace.cs (Namespace.Lookup): Return null if
14163 DeclSpace.DefineType returns null.
14166 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14168 2005-02-18 Raja R Harinath <rharinath@novell.com>
14170 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14171 now returns null if it cannot resolve to an lvalue.
14172 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14173 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14174 returned null. Remove check for SimpleName.
14175 (EventExpr.DoResolveLValue): New.
14176 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14177 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14179 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14180 avoid CS0131 error.
14181 (Unary.ResolveOperator): Move CS0211 check ...
14182 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14184 (Unary.DoResolveLValue): Simplify.
14185 (AddressOf.DoResolveLValue): New.
14186 (ArrayAccess.DoResolveLValue): New.
14188 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14190 * attribute.cs (Attribute.Resolve): Add arguments casting for
14191 when types doesn't match ctor arguments.
14193 2005-02-16 Raja R Harinath <rharinath@novell.com>
14195 Fix parts of #63202.
14196 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14197 lookup of operator in base type. Ensure that all checks happen
14198 when the operator resolves to an "op_..." method.
14200 2005-02-15 Raja R Harinath <rharinath@novell.com>
14203 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14204 'ignore_cs0104' parameter. Pass it to ...
14205 (NamespaceEntry.Lookup): ... this.
14206 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14207 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14208 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14209 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14210 Update. Request that cs0104 errors be ignored.
14211 (ComposedCast.ResolveAsTypeStep): Update.
14213 2005-02-14 Raja R Harinath <rharinath@novell.com>
14216 * expression.cs (Invocation.BetterFunction): Remove support for
14217 comparing virtual functions and their overrides.
14218 (Invocation.IsOverride): New.
14219 (Invocation.OverloadResolve): Don't consider 'override' functions
14220 during candidate selection. Store them in a lookaside list.
14221 If the selected method is a 'virtual' function, use the list to
14222 find any overrides that are closer to the LHS type.
14224 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14226 * expression.cs (New.DoResolve): Add complex core type reduction.
14227 (New.Constantify): Converts complex core type syntax like 'new int ()'
14228 to simple constant.
14230 2005-02-14 Raja R Harinath <rharinath@novell.com>
14232 * decl.cs (EntryType.EntryType): New constructor to create an
14233 updated copy of a cache entry.
14234 (MemberCache.AddMethods): Use it.
14235 (MemberCache.ClearDeclaredOnly): Remove.
14236 (MemberCache.MemberCache): Update.
14238 2005-02-11 Miguel de Icaza <miguel@novell.com>
14240 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14241 variable. This one is represents the actual low-level declaration
14242 of the method, as opposed to the semantic level `IsStatic'.
14244 An anonymous method which is hosted into a static method might be
14245 actually an instance method. IsStatic would reflect the
14246 container, while MethodIsStatic represents the actual code
14249 * expression.cs (ParameterReference): Use the new MethodIsStatic
14250 instead of IsStatic.
14252 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14253 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14254 set on the current EmitContext.
14256 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14257 resolve our casted expression as an LValue. This triggers the
14258 proper LValue processing that is later required by Assign.
14262 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14264 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14266 C# 2.0 Fixed buffer implementation
14268 * anonymous.cs: Update after RegisterHelperClass renaming.
14270 * attribute.cs (AttributeTester.fixed_buffer_cache):
14271 Cache of external fixed buffers.
14272 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14273 implementation if field is fixed buffer else null.
14276 (TypeContainer.AddField): Accept FieldMember instead of Field.
14277 (FieldBase.IsFieldClsCompliant): Extracted code from
14278 VerifyClsCompliance descendant customization.
14279 (FixedField): New class handles fixed buffer fields.
14280 (FixedFieldExternal): Keeps information about imported fixed
14282 (IFixedField): Make access to internal or external fixed buffer
14285 * cs-parser.jay: Add fixed buffer parsing.
14287 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14290 * expression.cs (Indirection): Extended implementation to accept
14291 fixed buffer field.
14292 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14293 (ElementAccess.MakePointerAccess): Get type as parameter.
14294 (DoResolve): Add fixed buffer field expression conversion.
14295 (DoResolveLValue): Ditto.
14296 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14297 (ArrayPtr): Derives from FixedBufferPtr.
14298 (ArrayPtr.Emit): Add extra emit for array elements.
14300 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14302 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14303 for compiler generated types.
14304 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14306 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14307 and consume less memory.
14308 (Fixed.Resolve): Add fixed buffer case.
14310 * typemanager.cs (compiler_generated_attr_ctor,
14311 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14312 (HasElementType): Add our own implementation to work on every
14315 2005-02-11 Miguel de Icaza <miguel@novell.com>
14317 * anonymous.cs (CaptureContext): Track whether `this' has been
14320 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14321 only captured `this' if it was implicitly done (instance
14322 methods/variables were used).
14324 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14325 `this' must be captured.
14327 2005-01-30 Miguel de Icaza <miguel@novell.com>
14329 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14330 is null it means that there has been no need to capture anything,
14331 so we just create a sibling.
14333 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14335 Just a partial fix. The other half is fairly elusive.
14337 2005-02-10 Raja R Harinath <rharinath@novell.com>
14339 Fix #52586, cs0121-4.cs.
14340 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14341 and return a hashtable.
14342 (MemberCache.ClearDeclaredOnly): New.
14343 (MemberCache.MemberCache): Update to change. Make a deep copy of
14344 the method_hash of a base type too.
14345 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14346 type methods. Overwrite entries with the same MethodHandle so
14347 that the ReflectedType is correct. The process leaves in base
14348 virtual functions and their overrides as distinct entries.
14349 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14350 matters since it was boxed in a ArrayList before.
14351 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14353 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14354 case of a virtual function and its override (choose the overload
14356 (Invocation.OverloadResolve): Avoid 'override' members during
14357 'applicable_type' calculation.
14359 2005-02-09 Raja R Harinath <rharinath@novell.com>
14361 Combine two near-redundant caches.
14362 * typemanager.cs (method_params): Rename from method_internal_params.
14363 (TypeManager.GetParameterData): New. Replace
14364 Invocation.GetParameterData.
14365 (TypeManager.LookupParametersByBuilder): Remove.
14366 * expression.cs (Invocation.method_parameter_cache): Remove.
14367 (Invocation.GetParameterData): Remove.
14369 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14372 2005-02-08 Raja R Harinath <rharinath@novell.com>
14375 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14376 TypeManager.multicast_delegate_type is null, resolve it by looking
14377 up "System.MulticastDelegate".
14378 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14380 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14381 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14382 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14385 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14386 (LabeledStatement.AddReference): New. Set 'referenced'.
14387 (Goto.Resolve): Use it.
14389 2005-02-05 John Luke <john.luke@gmail.com>
14391 * driver.cs: remove duplicate -doc line in Usage ()
14393 2005-02-04 Raja R Harinath <rharinath@novell.com>
14395 * location.cs (Location.AddFile): Fix CS2002 error report.
14397 2005-02-02 Martin Baulig <martin@ximian.com>
14399 * delegate.cs (Delegate.DefineType): Report an internal error if
14400 TypeManager.multicast_delegate_type is null. See bug #72015 for
14403 2005-02-02 Raja R Harinath <rharinath@novell.com>
14405 Fix a crasher in a variant of #31984.
14406 * const.cs (Constant.CheckBase): New override that defers the
14407 new-or-override check in case the base type hasn't been populated
14409 (Constant.Define): Ensure the new-or-override check is performed.
14411 2005-02-01 Duncan Mak <duncan@ximian.com>
14413 * const.cs (LookupConstantValue): Check that `ce' is not null
14414 before calling GetValue ().
14416 2005-02-01 Raja R Harinath <rharinath@novell.com>
14418 Fix test-334.cs (#69519).
14419 * cs-parser.jay (using_alias_directive): Pass in an expression to
14420 NamespaceEntry.UsingAlias.
14421 (using_namespace_directive): Pass in an expression to
14422 NamespaceEntry.Using.
14423 (namespace_name): Don't flatten to a string.
14424 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14425 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14427 (NamespaceEntry.UsingEntry): Likewise.
14428 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14430 (NamespaceEntry.LookupForUsing): Remove.
14431 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14433 (NamespaceEntry.Lookup): Remove support for dotted names.
14435 2005-02-01 Raja R Harinath <rharinath@novell.com>
14437 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14439 (NamespaceEntry.ImplicitParent): Compute on demand.
14440 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14441 parallels the current.
14442 (NamespaceEntry.LookupForUsing): Use it.
14443 (NamespaceEntry.Lookup): If the current namespace-entry is
14444 implicit, don't search aliases and using tables.
14446 2005-02-01 Raja R Harinath <rharinath@novell.com>
14449 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14451 (TypeContainer.BaseCache): Compute on demand.
14452 (TypeContainer.FindMembers): Define constants and types if they're
14453 not already created.
14454 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14456 * const.cs (Constant.Define): Make idempotent.
14458 2005-01-29 Miguel de Icaza <miguel@novell.com>
14460 * pending.cs: Produce better code (no nops produced by using Ldarg
14463 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14464 i - 1' it should be arg + 1.
14468 2005-01-28 Raja R Harinath <rharinath@novell.com>
14470 * attribute.cs (Attribute.CheckAttributeType): Make private
14472 (Attribute.ResolveType): Make virtual.
14473 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14474 handling of RootContext.Tree.Types.
14476 2005-01-27 Raja R Harinath <rharinath@novell.com>
14478 Update attribute-handling to use the SimpleName/MemberAccess
14480 * cs-parser.jay (attribute): Pass in an expression to the
14481 constructors of Attribute and GlobalAttribute.
14482 * attribute.cs (Attribute): Take an expression for the name.
14483 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14484 passed in attribute name expression.
14485 (Attribute.CheckAttributeType): Use it.
14486 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14487 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14488 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14489 argument to prevent error messages if the lookup fails.
14491 2005-01-27 Marek Safar <marek.safar@seznam.cz>
14493 * expression.cs (Indirection): Implemented IVariable interface
14494 to support indirection in AddressOf operator.
14495 (PointerArithmetic.Emit): Add optimalization for case where
14496 result can be precomputed.
14498 2005-01-26 Martin Baulig <martin@ximian.com>
14500 * class.cs (TypeContainer.AttributeTargets): Return the correct
14501 AttributeTargets depending on our `Kind' instead of throwing an
14502 exception; fixes #71632.
14504 2005-01-26 Marek Safar <marek.safar@seznam.cz>
14507 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
14510 2005-01-25 Raja R Harinath <rharinath@novell.com>
14513 * expression.cs (MemberAccess.DoResolve): Don't complain with
14514 cs0572 when the LHS of a member access has identical name and type
14517 2005-01-25 Marek Safar <marek.safar@seznam.cz>
14520 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
14522 Create custom PermissionSet only for PermissionSetAttribute.
14524 2005-01-24 Marek Safar <marek.safar@seznam.cz>
14527 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
14528 delegates in static class.
14530 2005-01-24 Martin Baulig <martin@ximian.com>
14532 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14533 merging an implicit block, just use its reachability.
14535 * statement.cs (Block.Resolve): Make the unreachable code check
14536 work wrt. implicit blocks; see test-337 from #63842.
14538 2005-01-21 Alp Toker <alp@atoker.com>
14540 * cs-parser.jay: destructor_declaration's container is PartialContainer
14541 not Class when partial types are used, so use Kind prop instead of
14544 2005-01-22 Miguel de Icaza <miguel@ximian.com>
14546 * cs-parser.jay: Improve error reporting when an interface
14547 declares new types.
14549 2005-01-20 Dick Porter <dick@ximian.com>
14551 * support.cs: SeekableStreamReader fix from Sandor Dobos
14552 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
14553 chars are read. Fixes bug 70369.
14555 2005-01-20 Raja R Harinath <rharinath@novell.com>
14557 * cs-parser.jay (catch_clause): Simplify current_block handling
14560 2005-01-17 Miguel de Icaza <miguel@ximian.com>
14562 * convert.cs (ImplicitStandardConversionExists): Synchronize the
14563 code with ImplicitStandardConversion to handle the implicit
14564 conversion of method groups into valid delegate invocations.
14566 The problem is that in parameter handling we were using this code
14567 path. Fixes bug #64698
14569 2005-01-19 Raja R Harinath <rharinath@novell.com>
14571 * cs-parser.jay: Fix several infelicities.
14572 - Avoid assigning to the parser value stack. Code like
14573 '$3 = null' is unclean. Synthesize a value for the code block
14575 - Avoid using oob_stack for storing location information. Use ...
14576 (_mark_): ... this. New (empty) rule. Saves the current location
14578 (foreach_statement): Avoid using oob_stack for current_block
14579 handling. Use technique used in for_statement and
14580 using_statement. Synthesize a value for the code block to store
14581 additional intermediate information.
14583 2005-01-13 Miguel de Icaza <miguel@ximian.com>
14585 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
14586 of a different type is only allowed to private fields of a
14587 containing type, not on fields of a base class.
14589 See test-174.cs and error cs0122-9.cs
14591 2005-01-13 Raja R Harinath <rharinath@novell.com>
14593 Fix test-335.cs (bug #58126).
14594 * cs-parser.jay (argument): Split out non-expression parts of the
14595 rule into 'non_simple_argument'.
14596 (invocation_expression): Support parenthesized invocations with
14597 multiple arguments, and with single non-simple arguments.
14599 2005-01-13 Raja R Harinath <rharinath@novell.com>
14601 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
14604 2005-01-12 Raja R Harinath <rharinath@novell.com>
14606 Fix cs0038-1.cs, cs1640-6.cs.
14607 * ecore.cs (Expression.Resolve): Remove special-case for
14608 SimpleName in error-handling.
14609 (Expression.almostMatchedMembers): Relax access permission to
14611 (Expression.MemberLookupFailed): Handle duplicates in
14612 almostMatchedMembers list.
14613 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
14614 * expression.cs (New.DoResolve): Report CS1540 for more cases.
14615 * typemanager.cs (GetFullNameSignature): Use the MethodBase
14616 overload if the passed in MemberInfo is a MethodBase.
14618 2005-01-12 Marek Safar <marek.safar@seznam.cz>
14621 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
14622 for non-CAS & merge permission sets properly.
14624 2005-01-11 Raja R Harinath <rharinath@novell.com>
14626 Improve standard-compliance of simple name and member access
14627 resolution. Fixes bugs #52697, #57200, #67520, #69519.
14628 * ecore.cs (FullNamedExpression): New abstract base class
14629 for Namespaces and TypeExpressions.
14630 (ResolveFlags.SimpleName): Remove.
14631 (SimpleName): Remove support for dotted names.
14632 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
14633 DeclSpace.FindType and DeclSpace.LookupType.
14634 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
14635 (Expression.ExprClassName): Make member function.
14636 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
14637 a namespace. Remove creation of dotted "SimpleName"s.
14638 (MemberAccess.DoResolve): Likewise.
14639 * decl.cs (DeclSpace.Cache): Make private.
14640 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
14641 (DeclSpace.FindType): Update.
14642 (DeclSpace.LookupType): Move here from RootContext. Return a
14643 FullNamedExpression.
14644 * namespace.cs (Namespace): Derive from FullNamedExpression
14645 so that it can be part of expression resolution.
14646 (Namespace.Lookup): Return an FullNamedExpression.
14647 (NamespaceEntry.LookupAlias): Lookup aliases only in current
14649 * rootcontext.cs (NamespaceLookup): Remove.
14650 (LookupType): Move to DeclSpace.
14651 * attribute.cs (CheckAttributeType): Update.
14652 * doc.cs (FindDocumentedType): Remove allowAlias argument.
14653 (FindDocumentedTypeNonArray): Likewise.
14655 2005-01-11 Raja R Harinath <rharinath@novell.com>
14657 Fix cs0509.cs, cs1632.cs.
14658 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
14659 is the same as IsInterface.
14660 (TypeContainer.GetClassBases): Likewise.
14661 * statement.cs (LabeledStatement.ig): New field.
14662 (LabeledStatement.LabelTarget): Save ILGenerator which created the
14664 (LabeledStatement.DoEmit): Check that the label was created with
14665 the same ILGenerator.
14667 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14670 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
14671 accessors to its properties.
14673 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
14674 from accessors to property.
14676 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14679 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
14680 only for overrides.
14682 2005-01-08 Miguel de Icaza <miguel@ximian.com>
14684 * attribute.cs: Check for null and empty strings.
14686 I have lost another battle to Paolo.
14688 2005-01-07 Marek Safar <marek.safar@seznam.cz>
14691 * class.cs (PropertyMethod): Set Parent field in ctors.
14692 (SetMethod.InternalParameters): Add unsafe switch hack.
14693 Override MarkForDuplicationCheck where it is appropriate.
14695 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
14696 It says whether container allows members with the same name.
14697 Base default is no.
14698 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
14699 Removed is_method parameter.
14701 2005-01-06 Duncan Mak <duncan@ximian.com>
14703 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
14704 because the previous change led to incorrect reporting of CS1032
14705 ("Cannot define/undefine preprocessor symbols after first token in
14706 file"). Instead of using `tokens_seen' as the only flag that
14707 triggers CS1040, introduce `comments_seen'. This new flag is used
14708 to signify having seen comments on the current line, so it is
14709 unset after a newline.
14711 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14713 * doc.cs : When searching for a type, find nested type too.
14714 This fixes bug #71040.
14716 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14719 - Warn missing member comment on those classes which also does not
14720 have doc comments. Fixed bug #71041.
14721 - Don't warn missing doc comment on default constructor.
14724 2005-01-06 Duncan Mak <duncan@ximian.com>
14726 * cs-tokenizer.cs (xtoken): After handling traditional C-style
14727 comments, set `tokens_seen' to true. This allows us to detect
14728 misplaced preprocessor directives (i.e. not at the beginning of
14729 the a line, nor after whitespaces). In that case, report error
14730 CS1040. This fixes bug #56460.
14732 * cs-parser.jay (interface_member_declaration): Add checks for
14733 IsExplicitImpl, and report CS0541 error if an interface member is
14734 defined as an explicit interface declaration.
14736 2005-01-06 Marek Safar <marek.safar@seznam.cz>
14739 * class.cs (PropertyMethod): Set Parent field in ctors.
14740 (SetMethod.InternalParameters): Add unsafe switch hack.
14742 * decl.cs (MemberCore.Parent): Cannot be readonly.
14744 2005-01-06 Raja R Harinath <rharinath@novell.com>
14746 * decl.cs (DeclSpace.ResolveType): Remove.
14747 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
14748 Merge in code from ...
14749 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
14750 * class.cs, enum.cs: Update to changes.
14752 2005-01-06 Miguel de Icaza <miguel@ximian.com>
14754 * anonymous.cs: Ensure that we init the scope of our parent if it
14755 has not been initialized yet.
14757 2004-12-30 Duncan Mak <duncan@ximian.com>
14759 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
14760 if field.FieldBuilder is null. Fixes #70758.
14762 * convert.cs: Fixed some typos and updated some of the comments.
14763 (ImplicitStandardConversionExists):
14764 (TryImplicitIntConversion): If `target_type' is an interface and
14765 the type of `ic' implements this interface, return true or a new
14766 BoxedCast instead of null. This fixes #70468.
14768 2004-12-29 Duncan Mak <duncan@ximian.com>
14770 * expression.cs (Argument.Emit): Check that Expr is
14771 IMemoryLocation before casting to it, and report CS1510 otherwise.
14775 2004-12-21 Ben Maurer <bmaurer@ximian.com>
14777 * statement.cs (Block.ThisVariable): remove the recursion here, to
14778 make the --profile more sane.
14780 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
14782 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
14783 assembly, by JB Evain.
14785 2004-12-17 Raja R Harinath <rharinath@novell.com>
14787 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
14788 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
14789 "parent" refers to enclosing type/class. "base" refers to superclass.
14791 2004-12-17 Raja R Harinath <rharinath@novell.com>
14793 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14794 Ensure that we only have GlobalAttributes.
14795 * attribute.cs (Attribute.Emit): Make non-virtual.
14796 (GlobalAttribute.Emit): Remove.
14797 (Attribute.Resolve): Make virtual.
14798 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
14799 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
14800 the argument. Don't create one.
14801 (Attribute.GetObsoleteAttribute): Likewise.
14802 (Attribute.GetClsCompliantAttributeValue): Likewise.
14803 * class.cs, decl.cs: Update to changes.
14805 2004-12-17 Marek Safar <marek.safar@seznam.cz>
14807 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
14809 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
14811 * statement.cs (Foreach.Resolve): Add error 186 report.
14813 2004-12-16 Marek Safar <marek.safar@seznam.cz>
14815 * expression.cs (Conditional.DoResolve): Add warning 429.
14817 * statement.cs (If.Resolve): Add warning 665.
14819 2004-12-16 Raja R Harinath <rharinath@novell.com>
14821 New invariant: RootContext.Tree.Types.NamespaceEntry == null
14822 except when in the parser, and in GlobalAttribute.
14823 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
14824 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
14825 RootContext.Tree.Types.NamespaceEntry once work is done.
14826 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
14827 and resets RootContext.Tree.Types.NamespaceEntry.
14829 2004-12-15 Marek Safar <marek.safar@seznam.cz>
14831 * cs-parser.jay: Don't create a block for every variable.
14833 2004-12-14 Miguel de Icaza <miguel@ximian.com>
14835 * location.cs: Provide extra information.
14837 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
14838 variables from the captured environment, it is the ldarg_0.
14840 2004-12-14 Marek Safar <marek.safar@seznam.cz>
14842 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
14845 * class.cs: Changed warning level for 169 to avoid developer
14846 displeasure from warning flooding. It will be changed back when they
14847 fix most of current BCL warnings.
14849 * RootContext.cs: Pushed default WarningLevel to 3.
14851 * statement.cs: Removed unused variable.
14853 2004-12-14 Marek Safar <marek.safar@seznam.cz>
14855 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
14856 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
14857 Add error 502 report.
14858 (StaticClass.DefineType): Add error 441 report.
14859 (Class.AllowedModifiersProp): New virtual property as temporary
14860 extension to AllowedModifiers.
14861 (Class.DefineType): Add error 418 report. Moved ModFlags check here
14862 to share implementation with StaticClass and don't call virtual
14865 * driver.cs (MainDriver): Add error 1558 test.
14867 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
14868 report. Moved error 36 test here.
14870 * statement.cs (Throw.Resolve): Add error 724 report.
14872 * typemanager.cs: Add out_attribute_type core type.
14874 2004-12-13 Marek Safar <marek.safar@seznam.cz>
14876 * class.cs (TypeContainer.VerifyClsCompliance): Add error
14878 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
14880 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
14883 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
14885 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
14886 Add error 3023 report.
14887 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
14889 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
14892 2004-12-12 John Luke <john.luke@gmail.com>
14894 * driver.cs (AddArgs): take -- into account when
14895 adding arguments, fixes bug 65710
14897 2004-12-12 Martin Baulig <martin@ximian.com>
14899 * expression.cs (Unary.TryReduceNegative): Added support for
14900 SByteConstant and ByteConstant.
14901 (Unary.Reduce): Check error values from TryReduceNegative().
14903 2004-12-10 Marek Safar <marek.safar@seznam.cz>
14905 * attributes.cs (Attribute.Resolve): Avoid multiple error report
14906 and report exception as error 182.
14908 2004-12-10 Raja R Harinath <rharinath@novell.com>
14910 * driver.cs (Main): Fix message when there are warnings.
14912 2004-12-09 Miguel de Icaza <miguel@ximian.com>
14914 * delegate.cs: Fixed my fix from yesterday, sorry about that.
14916 2004-12-09 Marek Safar <marek.safar@seznam.cz>
14918 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
14919 Reduced number of warnings.
14921 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
14923 2004-12-08 Miguel de Icaza <miguel@ximian.com>
14925 * driver.cs: Removed message.
14927 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
14929 2004-12-08 <vargaz@freemail.hu>
14931 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
14933 2004-12-08 Martin Baulig <martin@ximian.com>
14935 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
14936 instead of a CS3002 for properties and indexer.
14938 2004-12-08 Martin Baulig <martin@ximian.com>
14940 * decl.cs (MemberName.ToString): Make this work again.
14942 2004-12-08 Marek Safar <marek.safar@seznam.cz>
14944 * attribute.cs (Resolve): Add error 591 detection.
14946 * class.cs (FieldMember.Define): Add error 1547 detection.
14947 (Indexer.Define): Add error 620 detection.
14948 (Operator.Define): Add error 590 detection.
14950 * ecore.cs: Missing argument for error 79.
14952 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
14955 2004-12-07 Marek Safar <marek.safar@seznam.cz>
14958 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
14961 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
14963 * cs-parser.jay : handle doc comments on implicit/explicit operators.
14964 Some operator comments were suppressed.
14965 * doc.cs : Implicit/explicit operator name in doc comments are like
14966 "op_Explicit(type)~returnType", so added suffix handling.
14968 2004-12-07 Martin Baulig <martin@ximian.com>
14971 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
14972 (MemberCore.GetClsCompliantAttributeValue): Likewise.
14973 (DeclSpace.ec): New protected field; store the EmitContext here.
14974 (DeclSpace.EmitContext): New public property; moved here from
14976 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
14979 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
14980 (Enum.Emit): Don't create a new EmitContext.
14982 * delegate.cs (Delegate.DefineType): Always create the
14985 * iterators.cs (Iterators.DefineIterator): Create a new
14986 EmitContext and store it in `ec'.
14988 2004-08-24 Martin Baulig <martin@ximian.com>
14991 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
14992 this for accessibility checks.
14993 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
14994 IsNestedFamilyAccessible.
14995 (TypeManager.IsSubclassOf): New method, do what the name actually
14998 2004-12-06 Raja R Harinath <rharinath@novell.com>
15000 Fix crash on cs0657-17.cs.
15001 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15002 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15003 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15004 the case where the NamespaceEntry gets overwritten.
15006 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15008 Fixed #69195, #56821
15009 * ecore.cs (ResolveBoolean): Tiny refactoring.
15011 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15012 of right expression resolving when left is false constant and
15013 operator is LogicalAnd OR true constant and operator is LogicalOr.
15015 * statement.cs (ResolveUnreachable): Always reports warning.
15017 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15019 * class.cs: Distinguish between 1721 and 1722 (just a little help
15020 for the programmer).
15022 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15024 * delegate.cs: Only allow this on new versions of the language.
15026 2004-12-02 Duncan Mak <duncan@ximian.com>
15028 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15030 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15031 here as a static method. Take an additional bool out parameter
15032 `must_do_cs1540_check' for signaling to InstanceResolve.
15033 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15034 member field from PropertyExpr class and made it an argument of
15035 the method instead.
15036 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15037 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15038 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15039 and `remove_accessor' as well as InstanceResolve: report CS0122
15044 2004-12-03 Raja R Harinath <rharinath@novell.com>
15046 Fix test-327.cs, test-328.cs, and put in early infrastructure
15047 for eventually fixing #52697.
15048 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15049 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15050 from other methods.
15051 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15052 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15053 (VerifyUsing, error246): Update.
15054 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15055 'NamespaceEntry.LookupNamespaceOrType'.
15057 2004-12-03 Martin Baulig <martin@ximian.com>
15059 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15060 method as our child, call AnonymousMethod.Compatible() on it.
15062 2004-12-03 Raja R Harinath <rharinath@novell.com>
15064 Disable XML documentation support in 'basic' profile.
15065 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15066 Redirect XmlElement to System.Object.
15067 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15068 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15069 * mcs.exe.sources: Add doc-bootstrap.cs.
15070 * doc-bootstrap.cs: New file. Contains empty stub implementation
15073 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15075 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15076 comments are allowed.
15078 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15080 * delegate.cs: Add checks for subtypes in paramaters and return values
15081 in VerifyMethod () to add support for Covariance/Contravariance
15084 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15086 * report.cs: Remove extra closing parenthesis.
15088 * convert.cs (Error_CannotImplicitConversion): If the name of the
15089 types are the same, provide some extra information.
15091 * class.cs (FieldBase): Use an unused bit field from the field to
15092 encode the `has_offset' property from the FieldMember. This saves
15093 a couple of Ks on bootstrap compilation.
15095 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15096 method as our child, return the AnonymousMethod resolved
15099 * expression.cs (New.DoResolve): Allow return values from
15100 NewDelegate to also include AnonymousMethods.
15104 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15107 * attribute.cs (Resolve): Improved implementation of params
15108 attribute arguments.
15110 * support.cs (ParameterData): Add HasParams to be faster.
15112 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15114 all things are for /doc support:
15116 * doc.cs: new file that supports XML documentation generation.
15117 * mcs.exe.sources: added doc.cs.
15119 Handle /doc command line option.
15120 Report error 2006 instead of 5 for missing file name for /doc.
15121 Generate XML documentation when required, after type resolution.
15123 Added support for picking up documentation (/// and /** ... */),
15124 including a new XmlCommentState enumeration.
15126 Added lines to fill Documentation element for field, constant,
15127 property, indexer, method, constructor, destructor, operator, event
15128 and class, struct, interface, delegate, enum.
15129 Added lines to warn incorrect comment.
15131 Added Documentation field (passed only when /doc was specified).
15133 Added DocComment, DocCommentHeader, GenerateDocComment() and
15134 OnGenerateDocComment() and some supporting private members for
15135 /doc feature to MemberCore.
15137 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15139 Added overriden DocCommentHeader.
15141 Added overriden DocCommentHeader and GenerateDocComment().
15143 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15145 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15146 unwrapping the enumeration values, chain to
15147 DoConstantNumericPromotions again, so we can promote things to the
15148 fundamental types (takes care of enums that are bytes, sbytes).
15152 2004-12-01 Raja R Harinath <rharinath@novell.com>
15154 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15155 Fix long-standing bug in type-lookup. Use FindType instead of
15156 LookupType when ec.ResolvingTypeTree.
15157 (Attribute.ResolveType, Attribute.Resolve)
15158 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15160 (Attributes.Search): Remove internal version. Update.
15161 (Attributes.SearchMulti): Update.
15162 (Attributes.GetClsCompliantAttribute): Remove.
15163 (Attributes.GetIndexerNameAttribute): Remove.
15164 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15165 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15166 * class.cs (Indexer.Define): Likewise.
15168 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15171 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15172 MarshallByReference members access.
15174 * expression.cs: Use CheckMarshallByRefAccess;
15175 Better error CS0197 message.
15177 * report.cs: Print whole related error message.
15179 2004-11-30 Raja R Harinath <rharinath@novell.com>
15181 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15182 the current directory to help debugging.
15184 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15186 * class (GetClassBases): Better error 60 report.
15187 (EventProperty): Disabled warning 67 detection.
15189 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15192 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15194 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15197 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15200 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15202 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15204 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15206 * attribute.cs (Attribute.Resolve): Refine error reporting and
15207 report a cs0117 if the identifier does not exist, to distinguish
15208 from 0617 which is a miss-use of the actual identifier.
15210 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15211 between cs0070 and cs0079.
15213 * class.cs (MemberBase.DoDefine): When reporting a wrong
15214 accessibility level, we use MethodCore to compare instead of
15215 Method (this was a regression in some refactoring effort).
15217 So now we correctly report cs0056 again.
15219 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15220 testing the target_type (which was known to be object_type) and
15221 not the source type (which is anonymous_method).
15223 Fixed reporting of error cs1660.
15225 * expression.cs (UserCast.Source): Expose the underlying cast.
15227 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15228 allowed types to find a match to int32 first (most common).
15230 In addition, it ignores any ImplicitUserConversions that did an
15231 internal implicit conversion (as the switch statement allows only
15232 one integral conversion to exist).
15234 * class.cs (PartialContainer.Create): rename `name' to
15235 `member_name' for clarity. Then replace the string calls with a
15236 call to MemberName.GetPartialName, as now using
15237 MemberName.ToString is an error (this is due to the side effects
15238 it had, that were fixed in the past).
15240 This will restore the error reporting on a number of partial class
15241 errors that were missusing this (and getting an exception as a
15242 results, which is now just a plain textual warning, because
15243 yyparse debug output would crash otherwise).
15245 2004-11-26 Raja R Harinath <rharinath@novell.com>
15247 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15249 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15251 * rootcontext.cs (LookupType): Make sure to cache lookups that
15252 don't give us a negative result. This saves about 5% of corlib
15255 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15257 * report.cs (AbstractMessage.Print): messages are sent to stderr
15259 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15260 non-interface in the list of interfaces (at this point, either
15261 parent was properly set, or a base class is being listed in the
15262 interfaces section).
15264 This flags error 1722, and resolves the crash from bug 69259.
15266 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15268 * statement.cs (Using.EmitExpressionFinally): make this work right
15269 for valuetypes. Fixes 69926.
15271 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15273 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15274 converted to an enum" here, before we try to change the underlying
15275 type. This code exists, but it is a different code path than the
15276 one used while encoding constants.
15278 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15279 old bug: when converting from the null literal to a pointer,
15280 return an EmptyCast, not the NullLiteral.
15282 This fixes #69921, the recent null_type changes probably made this
15283 bug more prominent.
15285 (ImplicitReferenceConversionExists): In addition, resynchronized
15286 the code here, so it matches the same code in
15287 ImplicitReferenceConversionExists for the `from any class-type S
15288 to any interface-type T'.
15291 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15293 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15295 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15297 * cs-parser.jay: Use verbosity accordingly.
15299 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15301 * expression.cs (Unary.ResolveOperator): Do not report warning;
15302 AddressOf reads from variable.
15304 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15306 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15310 * attribute.cs (Attributable): Removed CheckTargets.
15311 (Attributes.Emit): Explicit attribute targets are tested here.
15313 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15314 not enabled for interfaces.
15316 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15317 (GetAssemblyName): Ouch next bug there.
15319 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15321 * expression.cs: Error 275 added.
15323 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15325 Fix bug #69177 (Implemented decimal constant support)
15327 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15328 (BinaryFold): Add DecimalConstant.
15330 * const.cs (Define): Decimal constant
15332 (ChangeType): Add decimal type handling.
15333 (LookupConstantValue): Don't set value for decimal type but
15334 emit DecimalConstantAttribute. Needed for constant optimization.
15336 * constant.cs (ToDecimal): New method.
15337 (ConvertToDecimal): New method.
15338 (IntConstant): Implemented ConvertToDecimal.
15339 (DecimalConstant.Emit): Emit optimized version for decimals in
15342 * expression.cs (ResolveOperator): Changed order of constant
15343 reduction to work correctly with native types which have
15344 overloaded operators.
15345 (ResolveMemberAccess): Extract constant value from attribute
15348 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15350 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15351 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15352 (ChangeType): Decimal is special.
15353 (TypeToCoreType): Add decimal type.
15355 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15357 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15360 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15362 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15365 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15367 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15369 * pending.cs (PendingImplementation): Grab only interfaces.
15371 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15373 * statement.cs (ForeachHelperMethods): Add location member and
15374 error 202 detection.
15376 2004-11-19 Raja R Harinath <rharinath@novell.com>
15378 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15379 automatically handled by executable.make.
15380 (PROGRAM): Make profile-specific.
15382 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15384 * expression.cs (DoResolveBase): Fixed wrong warning for out
15387 2004-11-18 Martin Baulig <martin@ximian.com>
15389 Merged latest changes into gmcs. Please keep this comment in
15390 here, it makes it easier for me to see what changed in MCS since
15391 the last time I merged.
15393 2004-11-17 Raja R Harinath <rharinath@novell.com>
15395 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15396 (TypeHandle.GetMemberCache): New.
15397 (TypeHandle.TypeHandle): Update.
15398 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15399 (TypeManager.LookupParentInterfacesCache):
15400 Rename from LookupInterfaceCache. Optimize slightly.
15401 (TypeManager.MemberLookup_FindMembers): Update.
15402 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15403 multi-type variant.
15404 (AddCacheContents): Rename from AddHashtable.
15405 * class.cs (TypeContainer.parent_container): Remove.
15406 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15407 (TypeContainer.DoDefineMembers): Don't initialize it.
15408 Update to name changes.
15410 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15412 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15413 that factors the code to check access modifiers on override.
15415 (PropertyBase): Use the code here.
15417 Patch from Lluis S'anchez, fixes bug #69361.
15419 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15421 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15422 routine that is used to report the use of a captured variable
15423 whose address has been taken.
15425 There are two checks: one when variables are being captured and
15426 the other check is when the address of a variable is taken.
15428 (because an anonymous methods might be resolved before *or* after
15429 the address has been taken) and
15431 * expression.cs (Conditional.DoResolve): Remove the special
15432 casing that Martin added to trueExpr and falseExpr being both
15433 NullLiteral. We get the right behavior now just by introducing
15434 the null_type into the compiler.
15436 * convert.cs (ExplicitConversion): Change the code to use
15437 null_type instead of testing `expr is NullLiteral'.
15438 (ImplicitConversionStandard): use null_type too.
15439 (ImplicitReferenceConversionExists): use null_type too.
15440 (ImplicitReferenceConversion): use null_type too.
15442 * literal.cs: The type of `NullLiteral' is now null_type instead
15444 (Resolve): Set the type here.
15446 * typemanager.cs: Introduce null_type.
15448 2004-11-17 Martin Baulig <martin@ximian.com>
15450 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15451 direction, like FindMembers() does. Fixes #69546, testcase is in
15454 2004-11-16 Martin Baulig <martin@ximian.com>
15456 This is based on a patch from Marek Safar, see bug #69082.
15457 Fixes bugs #63705 and #67130.
15459 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15460 method; create a MemberCache for an interface type and cache the
15463 * decl.cs (IMemberContainer.ParentContainer): Removed.
15464 (IMemberContainer.ParentCache): New property.
15465 (MemberCache.SetupCacheForInterface): Removed.
15466 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15467 to create a cache for an interface's "parent".
15469 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15472 2004-11-16 Martin Baulig <martin@ximian.com>
15474 Merged back from gmcs; these changes already went into gmcs a
15475 couple of weeks ago.
15478 (TypeManager.AddUserType): Removed the `ifaces' argument.
15479 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15481 (TypeManager.AddUserInterface): Removed.
15482 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15484 (TypeManager.GetInterfaces): Likewise.
15485 (TypeManager.GetExplicitInterfaces): Likewise.
15487 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15489 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15490 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
15492 2004-11-14 Ben Maurer <bmaurer@ximian.com>
15494 * statement.cs: Avoid adding bools to a hashtable.
15496 2004-11-07 Miguel de Icaza <miguel@ximian.com>
15498 * expression.cs (Invocation.OverloadResolve): Flag error if we are
15499 calling an unsafe method from a safe location.
15501 2004-11-06 Marek Safar <marek.safar@seznam.cz>
15504 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
15506 2004-11-06 Miguel de Icaza <miguel@ximian.com>
15508 * namespace.cs (VerifyUsing): use GetPartialName instead of
15511 2004-11-05 Miguel de Icaza <miguel@ximian.com>
15513 * statement.cs (Return.Resolve): Fix regression in typo: if
15514 `in_exc', we have to request a NeedReturnLabel, this was a typo
15515 introduced in the anonymous method check-in. Fixes #69131.
15517 * Indexers were using the ShortName when defining themselves,
15518 causing a regression in the compiler bootstrap when applying the
15519 patch from 2004-11-02 (first part), now they use their full name
15520 and the bug is gone.
15522 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
15524 * driver.cs: Strip the path from the names of embedded resources. Fixes
15527 2004-11-04 Raja R Harinath <rharinath@novell.com>
15529 Fix error message regression: cs0104-2.cs.
15530 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
15531 (AliasEntry.Resolve): Update.
15532 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
15534 (RootContext.LookupType): Update.
15536 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
15538 * cs-parser.jay: Add support for handling accessor modifiers
15539 * class: Add support port accessor modifiers and error checking,
15540 define PropertyMethod.Define as virtual (not abstract anymore)
15541 * ecore.cs: Add checking for proeprties access with access modifiers
15542 * iterators.cs: Modify Accessor constructor call based in the modified
15544 2004-11-02 Ben Maurer <bmaurer@ximian.com>
15546 * expression.cs (StringConcat): Handle being called twice,
15547 as when we have a concat in a field init with more than two
15550 2004-11-02 Miguel de Icaza <miguel@ximian.com>
15552 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
15553 special case explicit implementations, we should always produce
15554 the .property or .event declaration.
15556 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
15557 since it will not return correct data if people use this
15558 unresolved in the presence of using statements (see test-313).
15560 * class.cs (MethodData.Define): If we are an explicit interface
15561 implementation, set the method name to the full name of the
15562 interface plus the name of the method.
15564 Notice that using the method.MethodName.GetFullName() does not
15565 work, as it will only contain the name as declared on the source
15566 file (it can be a shorthand in the presence of using statements)
15567 and not the fully qualifed type name, for example:
15571 class D : ICloneable {
15572 object ICloneable.Clone () {
15576 Would produce a method called `ICloneable.Clone' instead of
15577 `System.ICloneable.Clone'.
15579 * namespace.cs (Alias.Resolve): Use GetPartialName.
15581 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15583 * cs-parser.jay: Add error 1055 report.
15585 2004-11-01 Miguel de Icaza <miguel@ximian.com>
15587 * assign.cs (Assign.DoResolve): Only do the transform of
15588 assignment into a New if the types are compatible, if not, fall
15589 through and let the implicit code deal with the errors and with
15590 the necessary conversions.
15592 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15594 * cs-parser.jay: Add error 1031 report.
15596 * cs-tokenizer.cs: Add location for error 1038.
15598 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15600 * cs-parser.jay: Add error 1016 report.
15602 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15604 * cs-parser.jay: Add errors 1575,1611 report.
15606 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15608 * cs-parser.jay: Add error 1001 report.
15610 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15613 * attribute.cs (GetMarshal): Add method argument for
15614 caller identification.
15616 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
15617 agument for GetMarshal and RuntimeMissingSupport.
15619 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15621 * attribute.cs (ExtractSecurityPermissionSet): Removed
15622 TypeManager.code_access_permission_type.
15624 * typemanager.cs: Removed TypeManager.code_access_permission_type.
15626 2004-10-27 Miguel de Icaza <miguel@ximian.com>
15628 * expression.cs (LocalVariableReference.DoResolveLValue): Check
15629 for obsolete use of a variable here. Fixes regression on errors
15630 cs0619-25 and cs0619-26.
15632 2004-10-27 Marek Safar <marek.safar@seznam.cz>
15634 Fix #62358, implemented security attribute encoding.
15636 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
15637 Tests permitted SecurityAction for assembly or other types.
15638 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
15639 data from SecurityPermissionAttribute to PermisionSet class.
15641 * class.cs (ApplyAttributeBuilder): Added special handling
15642 for System.Security.Permissions.SecurityAttribute based types.
15644 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
15645 special handling for System.Security.Permissions.SecurityAttribute
15648 * enum.cs (ApplyAttributeBuilder): Added special handling
15649 for System.Security.Permissions.SecurityAttribute based types.
15651 * parameter.cs (ApplyAttributeBuilder): Added special handling
15652 for System.Security.Permissions.SecurityAttribute based types.
15654 * rootcontext.cs: Next 2 core types.
15656 * typemanager.cs (TypeManager.security_permission_attr_type):
15657 Built in type for the SecurityPermission Attribute.
15658 (code_access_permission_type): Build in type.
15660 2004-10-17 Miguel de Icaza <miguel@ximian.com>
15662 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
15663 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
15664 all of this information into
15665 EmitContext.EmitCapturedVariableInstance.
15667 * codegen.cs (EmitCapturedVariableInstance): move here the
15668 funcionality of emitting an ldarg.0 in the presence of a
15669 remapping. This centralizes the instance emit code.
15671 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
15672 then emit a load of this: it means that we have reached the
15673 topmost ScopeInfo: the one that contains the pointer to the
15674 instance of the class hosting the anonymous method.
15676 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
15677 captures to the topmost CaptureContext.
15679 2004-10-12 Miguel de Icaza <miguel@ximian.com>
15681 * expression.cs (LocalVariableReference): Move the knowledge about
15682 the iterators into codegen's EmitCapturedVariableInstance.
15684 2004-10-11 Miguel de Icaza <miguel@ximian.com>
15686 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
15687 all code paths return a value from an anonymous method (it is the
15688 same as the 161 error, but for anonymous methods).
15690 2004-10-08 Miguel de Icaza <miguel@ximian.com>
15692 The introduction of anonymous methods in the compiler changed
15693 various ways of doing things in the compiler. The most
15694 significant one is the hard split between the resolution phase
15695 and the emission phases of the compiler.
15697 For instance, routines that referenced local variables no
15698 longer can safely create temporary variables during the
15699 resolution phase: they must do so from the emission phase,
15700 since the variable might have been "captured", hence access to
15701 it can not be done with the local-variable operations from the runtime.
15705 (Block.Flags): New flag `IsTopLevel' to indicate that this block
15706 is a toplevel block.
15708 (ToplevelBlock): A new kind of Block, these are the blocks that
15709 are created by the parser for all toplevel method bodies. These
15710 include methods, accessors and anonymous methods.
15712 These contain some extra information not found in regular blocks:
15713 A pointer to an optional CaptureContext (for tracking captured
15714 local variables and parameters). A pointer to the parent
15717 (Return.Resolve): Catch missmatches when returning a value from an
15718 anonymous method (error 1662).
15719 Invoke NeedReturnLabel from the Resolve phase instead of the emit
15722 (Break.Resolve): ditto.
15724 (SwitchLabel): instead of defining the labels during the
15725 resolution phase, we now turned the public ILLabel and ILLabelCode
15726 labels into methods called GetILLabelCode() and GetILLabel() that
15727 only define the label during the Emit phase.
15729 (GotoCase): Track the SwitchLabel instead of the computed label
15730 (its contained therein). Emit the code by using
15731 SwitchLabel.GetILLabelCode ().
15733 (LocalInfo.Flags.Captured): A new flag has been introduce to track
15734 whether the Local has been captured or not.
15736 (LocalInfo.IsCaptured): New property, used to tell whether the
15737 local has been captured.
15739 * anonymous.cs: Vastly updated to contain the anonymous method
15742 The main classes here are: CaptureContext which tracks any
15743 captured information for a toplevel block and ScopeInfo used to
15744 track the activation frames for various local variables.
15746 Each toplevel block has an optional capture context associated
15747 with it. When a method contains an anonymous method both the
15748 toplevel method and the anonymous method will create a capture
15749 context. When variables or parameters are captured, they are
15750 recorded on the CaptureContext that owns them, for example:
15754 MyDelegate d = delegate {
15759 Here `a' will be recorded as captured on the toplevel
15760 CapturedContext, the inner captured context will not have anything
15761 (it will only have data if local variables or parameters from it
15762 are captured in a nested anonymous method.
15764 The ScopeInfo is used to track the activation frames for local
15765 variables, for example:
15767 for (int i = 0; i < 10; i++)
15768 for (int j = 0; j < 10; j++){
15769 MyDelegate d = delegate {
15774 At runtime this captures a single captured variable `i', but it
15775 captures 10 different versions of the variable `j'. The variable
15776 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
15777 recorded on a child.
15779 The toplevel ScopeInfo will also track information like the `this'
15780 pointer if instance variables were referenced (this is necessary
15781 as the anonymous method lives inside a nested class in the host
15782 type of the method).
15784 (AnonymousMethod): Expanded to track the Toplevel, implement
15785 `AnonymousMethod.Compatible' to tell whether an anonymous method
15786 can be converted to a target delegate type.
15788 The routine now also produces the anonymous method content
15790 (AnonymousDelegate): A helper class that derives from
15791 DelegateCreation, this is used to generate the code necessary to
15792 produce the delegate for the anonymous method that was created.
15794 * assign.cs: API adjustments for new changes in
15795 Convert.ImplicitStandardConversionExists.
15797 * class.cs: Adjustments to cope with the fact that now toplevel
15798 blocks are of type `ToplevelBlock'.
15800 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
15801 insteda of standard blocks.
15803 Flag errors if params arguments are passed to anonymous methods.
15805 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
15806 `CurrentAnonymousMethod' which points to the current Anonymous
15807 Method. The variable points to the AnonymousMethod class that
15808 holds the code being compiled. It is set in the new EmitContext
15809 created for the anonymous method.
15811 (EmitContext.Phase): Introduce a variable and an enumeration to
15812 assist in enforcing some rules about when and where we are allowed
15813 to invoke certain methods (EmitContext.NeedsReturnLabel is the
15814 only one that enfonces this right now).
15816 (EmitContext.HaveCaptureInfo): new helper method that returns
15817 whether we have a CapturedContext initialized.
15819 (EmitContext.CaptureVariable): New method used to register that a
15820 LocalInfo must be flagged for capturing.
15822 (EmitContext.CapturedParameter): New method used to register that a
15823 parameters must be flagged for capturing.
15825 (EmitContext.CapturedField): New method used to register that a
15826 field must be flagged for capturing.
15828 (EmitContext.HaveCapturedVariables,
15829 EmitContext.HaveCapturedFields): Return whether there are captured
15830 variables or fields.
15832 (EmitContext.EmitMethodHostInstance): This is used to emit the
15833 instance for the anonymous method. The instance might be null
15834 (static methods), this (for anonymous methods that capture nothing
15835 and happen to live side-by-side with the current method body) or a
15836 more complicated expression if the method has a CaptureContext.
15838 (EmitContext.EmitTopBlock): Routine that drives the emission of
15839 code: it will first resolve the top block, then emit any metadata
15840 and then emit the code. The split is done so that we can extract
15841 any anonymous methods and flag any captured variables/parameters.
15843 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
15844 during this phase, the ILGenerator should not be used as labels
15845 and local variables declared here might not be accessible to any
15846 code that is part of an anonymous method.
15848 Exceptions to this include the temporary variables that are
15849 created by some statements internally for holding temporary
15852 (EmitContext.EmitMeta): New routine, in charge of emitting all the
15855 (EmitContext.TemporaryReturn): This method is typically called
15856 from the Emit phase, and its the only place where we allow the
15857 ReturnLabel to be defined other than the EmitMeta. The reason is
15858 that otherwise we would have to duplicate a lot of logic in the
15859 Resolve phases of various methods that today is on the Emit
15862 (EmitContext.NeedReturnLabel): This no longer creates the label,
15863 as the ILGenerator is not valid during the resolve phase.
15865 (EmitContext.EmitThis): Extended the knowledge in this class to
15866 work in anonymous methods in addition to iterators.
15868 (EmitContext.EmitCapturedVariableInstance): This emits whatever
15869 code is necessary on the stack to access the instance to a local
15870 variable (the variable will be accessed as a field).
15872 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
15873 EmitContext.EmitAddressOfParameter): Routines to support
15874 parameters (not completed at this point).
15876 Removals: Removed RemapLocal and RemapLocalLValue. We probably
15877 will also remove the parameters.
15879 * convert.cs (Convert): Define a `ConstantEC' which points to a
15880 null. This is just to prefity some code that uses
15881 ImplicitStandardConversion code and do not have an EmitContext
15884 The idea is to flag explicitly that at that point in time, it is
15885 known that the conversion will not trigger the delegate checking
15886 code in implicit conversions (which requires a valid
15889 Everywhere: pass new EmitContext parameter since
15890 ImplicitStandardConversionExists now requires it to check for
15891 anonymous method conversions.
15893 (Convert.ImplicitStandardConversionExists): If the type of an
15894 expression is the anonymous_method_type, and the type is a
15895 delegate, we invoke the AnonymousMethod.Compatible method to check
15896 whether an implicit conversion is possible.
15898 (Convert.ImplicitConversionStandard): Only do implicit method
15899 group conversions if the language level is not ISO_1.
15901 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
15902 MethodInfo for the Invoke method. used by Delegate and
15905 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
15906 method conversions if the target type is a delegate.
15908 Removed extra debugging nops.
15910 (LocalVariableReference): Turn the `local_info' into a public
15913 Add `prepared' field, the same hack used for FieldExprs to cope
15914 with composed assignments, as Local variables do not necessarily
15915 operate purely on the stack as they used to: they can be captured
15918 Add `temp' for a temporary result, like fields.
15920 Refactor DoResolve and DoResolveLValue into DoResolveBase.
15922 It now copes with Local variables that are captured and emits the
15923 proper instance variable to load it from a field in the captured
15926 (ParameterReference.DoResolveBase): During the resolve phase,
15927 capture parameters if we are in an anonymous method.
15929 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
15930 anonymous method, use the EmitContext helper routines to emit the
15931 parameter reference.
15933 * iterators.cs: Set RemapToProxy to true/false during the
15936 * parameters.cs (GetParameterByName): New helper method.
15938 * typemanager.cs (anonymous_method_type) a new type that
15939 represents an anonyous method. This is always an internal type,
15940 used as a fencepost to test against the anonymous-methodness of an
15943 2004-10-20 Marek Safar <marek.safar@seznam.cz>
15945 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
15947 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
15949 2004-10-18 Martin Baulig <martin@ximian.com>
15951 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
15952 `Type' directly, but call ResolveType() on it.
15953 (Catch.Resolve): Likewise.
15954 (Foreach.Resolve): Likewise.
15956 2004-10-18 Martin Baulig <martin@ximian.com>
15958 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
15959 `Type' directly, but call ResolveType() on it.
15960 (Probe.DoResolve): Likewise.
15961 (ArrayCreation.LookupType): Likewise.
15962 (TypeOf.DoResolve): Likewise.
15963 (SizeOf.DoResolve): Likewise.
15965 2004-10-18 Martin Baulig <martin@ximian.com>
15967 * expression.cs (Invocation.BetterFunction): Put back
15968 TypeManager.TypeToCoreType().
15970 2004-10-18 Raja R Harinath <rharinath@novell.com>
15972 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
15975 2004-10-18 Martin Baulig <martin@ximian.com>
15977 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
15978 `Type' directly, but call ResolveType() on it.
15980 2004-10-18 Martin Baulig <martin@ximian.com>
15982 * class.cs (FieldMember.Define): Don't access the TypeExpr's
15983 `Type' directly, but call ResolveType() on it.
15984 (MemberBase.DoDefine): Likewise.
15986 * expression.cs (New.DoResolve): Don't access the TypeExpr's
15987 `Type' directly, but call ResolveType() on it.
15988 (ComposedCast.DoResolveAsTypeStep): Likewise.
15990 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
15991 `Type' directly, but call ResolveType() on it.
15993 2004-10-17 John Luke <john.luke@gmail.com>
15995 * class.cs (Operator.GetSignatureForError): use CSharpName
15997 * parameter.cs (Parameter.GetSignatureForError): Returns
15998 correct name even if was not defined.
16000 2004-10-13 Raja R Harinath <rharinath@novell.com>
16003 * class.cs (TypeContainer.EmitContext): New property.
16004 (DefineNestedTypes): Create an emitcontext for each part.
16005 (MethodCore.DoDefineParameters): Use container's emitcontext.
16006 Pass type array to InternalParameters.
16007 (MemberBase.DoDefine): Use container's emitcontext.
16008 (FieldMember.Define): Likewise.
16009 (Event.Define): Likewise.
16010 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16011 Pass type array to InternalParameters.
16012 (SetIndexerMethod.GetParameterInfo): Likewise.
16013 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16014 * delegate.cs (Define): Pass emitcontext to
16015 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16016 array to InternalParameters.
16017 * expression.cs (ParameterReference.DoResolveBase): Pass
16018 emitcontext to GetParameterInfo.
16019 (ComposedCast.DoResolveAsTypeStep): Remove check on
16020 ec.ResolvingTypeTree.
16021 * parameter.cs (Parameter.Resolve): Change argument to
16022 EmitContext. Use ResolveAsTypeTerminal.
16023 (Parameter.GetSignature): Change argument to EmitContext.
16024 (Parameters.ComputeSignature): Likewise.
16025 (Parameters.ComputeParameterTypes): Likewise.
16026 (Parameters.GetParameterInfo): Likewise.
16027 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16028 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16029 * support.cs (InternalParameters..ctor): Remove variant that takes
16031 * typemanager.cs (system_intptr_expr): New.
16032 (InitExpressionTypes): Initialize it.
16034 2004-10-12 Chris Toshok <toshok@ximian.com>
16036 * cs-parser.jay: fix location for try_statement and catch_clause.
16038 2004-10-11 Martin Baulig <martin@ximian.com>
16040 * report.cs: Don't make --fatal abort on warnings, we have
16041 -warnaserror for that.
16043 2004-10-07 Raja R Harinath <rharinath@novell.com>
16045 More DeclSpace.ResolveType avoidance.
16046 * decl.cs (MemberCore.InUnsafe): New property.
16047 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16048 with newly created EmitContext.
16049 (FieldMember.Define): Likewise.
16050 * delegate.cs (Delegate.Define): Likewise.
16051 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16052 only if normal name-lookup fails.
16053 (TypeExpr.DoResolve): Enable error-checking.
16054 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16055 (SizeOf.DoResolve): Likewise.
16056 (ComposedCast.DoResolveAsTypeStep): Likewise.
16057 (StackAlloc.DoResolve): Likewise.
16058 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16059 (Block.Unsafe): New property.
16060 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16061 (Unsafe): Set 'unsafe' flag of contained block.
16062 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16063 (Fixed.Resolve): Likewise.
16064 (Catch.Resolve): Likewise.
16065 (Using.ResolveLocalVariableDecls): Likewise.
16066 (Foreach.Resolve): Likewise.
16068 2004-10-05 John Luke <john.luke@gmail.com>
16070 * cs-parser.jay: add location to error CS0175
16072 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16074 * ecore.cs (Expression.Constantity): Add support for turning null
16077 * const.cs (Const.Define): Allow constants to be reference types
16078 as long as the value is Null.
16080 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16082 * namespace.cs (NamespaceEntry.Using): No matter which warning
16083 level is set, check if this namespace name has already been added.
16085 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16087 * expression.cs: reftype [!=]= null should always use br[true,false].
16090 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16093 * attribute.cs: Enum conversion moved to
16094 GetAttributeArgumentExpression to be applied to the all
16097 2004-10-01 Raja R Harinath <rharinath@novell.com>
16099 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16100 * class.c (TypeContainer.DefineType): Flag error if
16101 base types aren't accessible due to access permissions.
16102 * decl.cs (DeclSpace.ResolveType): Move logic to
16103 Expression.ResolveAsTypeTerminal.
16104 (DeclSpace.ResolveTypeExpr): Thin layer over
16105 Expression.ResolveAsTypeTerminal.
16106 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16107 Refactor code into NestedAccess. Use it.
16108 (DeclSpace.NestedAccess): New.
16109 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16110 argument to silence errors. Check access permissions.
16111 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16112 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16113 (Cast.DoResolve): Likewise.
16114 (New.DoResolve): Likewise.
16115 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16116 (TypeOf.DoResolve): Likewise.
16118 * expression.cs (Invocation.BetterConversion): Return the Type of
16119 the better conversion. Implement section 14.4.2.3 more faithfully.
16120 (Invocation.BetterFunction): Make boolean. Make correspondence to
16121 section 14.4.2.2 explicit.
16122 (Invocation.OverloadResolve): Update.
16123 (Invocation): Remove is_base field.
16124 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16125 (Invocation.Emit): Likewise.
16127 2004-09-27 Raja R Harinath <rharinath@novell.com>
16129 * README: Update to changes.
16131 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16133 * cs-parser.jay: Reverted 642 warning fix.
16135 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16138 * decl.cs (FindMemberWithSameName): Indexer can have more than
16141 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16143 * expression.cs (LocalVariableReference.DoResolveLValue):
16144 Do not report warning 219 for out values.
16145 (EmptyExpression.Null): New member to avoid extra allocations.
16147 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16149 * cs-parser.jay: Fix wrong warning 642 report.
16151 * cs-tokenizer.cs (CheckNextToken): New helper;
16152 Inspect next character if is same as expected.
16154 2004-09-23 Martin Baulig <martin@ximian.com>
16156 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16157 (Convert.ImplicitReferenceConversionExists): Likewise.
16159 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16161 * class.cs (Operator.Define): Add error 448 and 559 report.
16163 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16165 * class.cs (MemberBase.IsTypePermitted): New protected
16166 method for checking error CS0610.
16168 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16170 * class.cs (TypeContainer.HasExplicitLayout): New property
16171 Returns whether container has StructLayout attribute set Explicit.
16172 (FieldMember): New abstract class for consts and fields.
16173 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16174 (Field): Reuse FieldMember.
16176 * const.cs (Const): Reuse FieldMember.
16178 * rootcontext.cs: EmitConstants call moved to class.
16180 2004-09-22 Martin Baulig <martin@ximian.com>
16182 Thanks to Peter Sestoft for this bug report.
16184 * expression.cs (Conditional): If both the `trueExpr' and the
16185 `falseExpr' is a NullLiteral, return a NullLiteral.
16187 2004-09-22 Martin Baulig <martin@ximian.com>
16189 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16190 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16191 for the "get_Current" call.
16193 2004-09-22 Martin Baulig <martin@ximian.com>
16195 Marek and me just fixed one of our oldest bugs: #28562 :-)
16197 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16199 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16200 we're an EnumConstant, just return that.
16201 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16202 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16203 to get the value which'll actually be written into the attribute.
16204 However, we have to use GetValue() to access the attribute's value
16207 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16209 * constant.cs (Constant.IsNegative): New abstract property
16212 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16213 (StackAlloc.DoResolve): Reused IsNegative.
16215 2004-09-21 Martin Baulig <martin@ximian.com>
16217 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16218 if we're used in an iterator, we may be called from different
16221 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16222 we actually have an exception block.
16224 2004-09-20 John Luke <jluke@cfl.rr.com>
16226 * class.cs, cs-parser.jay: Improve the error report for 1520:
16227 report the actual line where the error happens, not where the
16228 class was declared.
16230 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16231 Pass location information that was available elsewhere.
16233 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16235 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16236 runtime to delay sign assemblies.
16238 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16240 * cs-parser.jay: Do not report the stack trace, this is barely
16243 2004-08-22 John Luke <john.luke@gmail.com>
16245 * driver.cs : check that a resource id is not already used
16246 before adding it, report CS1508 if it is, bug #63637
16248 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16250 * ecore.cs: Removed dead code.
16252 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16254 * class.cs: Do not report warning CS0067 on the interfaces.
16256 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16258 * cs-parser.jay: Add error 504 report.
16260 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16262 * rootcontext.cs: WarningLevel is 4 by default now.
16264 * statement.cs (Fixed.Resolve): Do not null
16267 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16270 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16271 deep search when property is not virtual.
16272 (PropertyExpr.ResolveAccessors): Make one call for both
16275 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16278 * statement.cs: Error 152 report constains also location.
16280 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16283 * const.cs: Explicitly set constant as static.
16285 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16288 * cs-parser.jay: Add error 1017 report.
16290 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16292 Fixed bug #59980, #64224
16293 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16295 * typemanager.cs (IsSpecialMethod): Simplified
16297 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16299 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16300 condition with better params.
16302 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16305 * attribute.cs (Resolve): Property has to have both
16308 2004-09-14 Martin Baulig <martin@ximian.com>
16310 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16312 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16315 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16316 called and is obsolete then this member suppress message
16317 when call is inside next [Obsolete] method or type.
16319 * expression.cs: Use TestObsoleteMethodUsage member.
16321 2004-09-14 Martin Baulig <martin@ximian.com>
16323 * cs-parser.jay: Sync a bit with the GMCS version.
16325 2004-09-14 Martin Baulig <martin@ximian.com>
16327 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16328 (CSharpParser.yacc_verbose_flag): New public field.
16330 * genericparser.cs: Removed.
16332 2004-09-14 Raja R Harinath <rharinath@novell.com>
16334 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16336 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16338 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16340 2004-09-10 Martin Baulig <martin@ximian.com>
16342 Backported my MemberName changes from GMCS into MCS.
16344 - we are now using a special `MemberName' class instead of using
16345 strings; in GMCS, the `MemberName' also contains the type
16348 - changed the grammar rules a bit:
16349 * the old `member_name' is now a `namespace_or_type_name':
16350 The rule is that we use `namespace_or_type_name' everywhere
16351 where we expect either a "member name" (GetEnumerator) or a
16352 "member name" with an explicit interface name
16353 (IEnumerable.GetEnumerator).
16354 In GMCS, the explicit interface name may include type arguments
16355 (IEnumerable<T>.GetEnumerator).
16356 * we use `member_name' instead of just `IDENTIFIER' for
16358 The rule is that we use `member_name' wherever a member may
16359 have type parameters in GMCS.
16361 * decl.cs (MemberName): New public class.
16362 (MemberCore.MemberName): New public readonly field.
16363 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16364 (DeclSpace): Likewise.
16366 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16367 * enum.cs (Enum.ctor): Likewise.
16369 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16371 (AliasEntry.ctor): Take a MemberName, not an Expression.
16372 (AliasEntry.UsingAlias): Likewise.
16374 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16375 (IMethodData.MemberName): Changed type from string to MemberName.
16376 (MemberBase.ExplicitInterfaceName): Likewise.
16377 (AbstractPropertyEventMethod.SetupName): Make this private.
16378 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16379 argument; compute the member name here.
16380 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16381 on the `member.MemberName' and the `prefix'.
16383 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16385 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16386 thus, we get a `MemberName' instead of a `string'. These
16387 declarations may have type parameters in GMCS.
16388 (interface_method_declaration, delegate_declaration): Likewise.
16389 (class_declaration, interface_declaration): Likewise.
16390 (method_header): Use `namespace_or_type_name' instead of
16391 `member_name'. We may be an explicit interface implementation.
16392 (property_declaration, event_declaration): Likewise.
16393 (member_name): This is now just an `IDENTIFIER', not a
16394 `namespace_or_type_name'.
16395 (type_name, interface_type): Removed.
16396 (namespace_or_type_name): Return a MemberName, not an Expression.
16397 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16398 call GetTypeExpression() on the MemberName to get an expression.
16399 (IndexerDeclaration.interface_type): Changed type from string to
16401 (MakeName): Operate on MemberName's instead of string's.
16403 2004-09-13 Raja R Harinath <rharinath@novell.com>
16406 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16407 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16408 lookup to avoid symbols introduced by 'using'.
16409 * rootcontext.cs (NamespaceLookup): Update.
16411 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16413 * class.cs (TypeContainer.DoDefineMembers): Do not call
16414 DefineDefaultConstructor for static classes.
16416 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16418 * attribute.cs (Attribute.Resolve): Add error 653 report.
16420 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16422 (Method.ApplyAttributeBuilder): Add error 685 report.
16423 (Operator.Define): Add error 564 report.
16425 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16427 * expression.cs (Invocation.DoResolve): Add error
16428 245 and 250 report.
16430 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16433 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16435 * class.cs (ConstructorInitializer.Resolve):
16436 Wrong error number (515->516).
16438 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16440 * class.cs (Indexer.Define): Add error 631 report.
16442 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16444 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16446 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16448 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16450 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16452 * cs-parser.jay: Added error CS0241 report.
16454 2004-09-10 Raja R Harinath <rharinath@novell.com>
16456 * cs-parser.jay (fixed_statement): Introduce a scope for the
16457 declaration in the 'fixed' statement.
16459 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16461 * cs-parser.jay: Added CS0230 error report.
16463 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16465 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16467 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16469 * expression.cs (Argument.Resolve): Added error CS0192 and
16472 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16474 C# 2.0 #pragma warning feature
16476 * cs-tokenizer.cs (PreProcessPragma): New method;
16477 Handles #pragma directive.
16479 * report.cs (WarningRegions): New class; Support
16480 class for #pragma warning directive. It tests whether
16481 warning is enabled for a given line.
16483 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16485 * const.cs: Add more descriptive error report, tahnks to
16488 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16490 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
16492 2004-09-07 Miguel de Icaza <miguel@ximian.com>
16494 * expression.cs: Apply patch from Ben: Remove dead code from
16495 ArrayCreation, and remove the TurnintoConstant call in const.cs,
16496 as that code just threw an exception anwyays.
16498 * const.cs: Remove the call to the turnintoconstant, for details
16501 * literal.cs: The type of the null-literal is the null type; So
16502 we use a placeholder type (literal.cs:System.Null, defined here)
16505 * expression.cs (Conditional.DoResolve): Remove some old code that
16506 is no longer needed, conversions have been fixed.
16508 (ArrayCreationExpression.DoResolve): Return false if we fail to
16509 resolve the inner expression.
16511 2004-09-07 Raja R Harinath <rharinath@novell.com>
16514 * cs-parser.jay (delegate_declaration): Record a delegate
16515 declaration as a type declaration.
16516 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
16518 2004-09-06 Miguel de Icaza <miguel@ximian.com>
16520 * parameter.cs: Do not crash if the type can not be resolved.
16522 * expression.cs: Report errors with unsafe pointers, fixes #64896
16524 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
16526 * expression.cs: Pointer arith always needs to do a conv.i
16527 if the operand is a long. fix 65320
16529 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16531 Fixed cs0619-37.cs, cs0619-38.cs
16533 * enum.cs (GetObsoleteAttribute): Removed.
16535 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
16536 on Enum member is double staged. The first is tested member
16539 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16541 Fixed #56986, #63631, #65231
16543 * class.cs: (TypeContainer.AddToMemberContainer): New method,
16544 adds member to name container.
16545 (TypeContainer.AddToTypeContainer): New method, adds type to
16547 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
16548 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
16549 AddOperator): Simplified by reusing AddToMemberContainer.
16550 (TypeContainer.UserDefinedStaticConstructor): Changed to property
16552 (Method.CheckForDuplications): Fixed implementation to test all
16554 (MemberBase): Detection whether member is explicit interface
16555 implementation is now in constructor.
16556 (MemberBase.UpdateMemberName): Handles IndexerName.
16557 (Accessor): Changed to keep also location information.
16558 (AbstractPropertyEventMethod): Is derived from MemberCore.
16559 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
16560 will be emited or not.
16561 (PropertyBase.AreAccessorsDuplicateImplementation):
16562 Tests whether accessors are not in collision with some method.
16563 (Operator): Is derived from MethodCore to simplify common
16566 * decl.cs (Flags.TestMethodDuplication): Test for duplication
16568 (DeclSpace.AddToContainer): Adds the member to defined_names
16569 table. It tests for duplications and enclosing name conflicts.
16571 * enum.cs (EnumMember): Clean up to reuse the base structures
16573 2004-09-03 Martin Baulig <martin@ximian.com>
16575 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
16576 into TypeContainer, to make partial classes work again.
16578 2004-09-03 Martin Baulig <martin@ximian.com>
16580 * rootcontext.cs (RootContext.V2): Removed.
16582 2004-03-23 Martin Baulig <martin@ximian.com>
16584 * expression.cs (Invocation.OverloadResolve): Added `bool
16585 may_fail' argument and use it instead of the Location.IsNull() hack.
16587 2004-09-03 Martin Baulig <martin@ximian.com>
16589 Merged latest changes into gmcs. Please keep this comment in
16590 here, it makes it easier for me to see what changed in MCS since
16591 the last time I merged.
16593 2004-09-03 Raja R Harinath <rharinath@novell.com>
16596 * expression.cs (BetterConversion): Don't allow either conversion
16597 to be null. Remove redundant implicit conversion test when 'q ==
16598 null' -- when this function is invoked, we already know that the
16599 implicit conversion exists.
16600 (BetterFunction): Assume that 'best' is non-null. Remove
16601 redundant reimplementation of IsApplicable when 'best' is null.
16602 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
16603 number of arguments.
16604 (IsAncestralType): Extract from OverloadResolve.
16605 (OverloadResolve): Make robust to the MethodGroupExpr being
16606 unsorted. Implement all the logic of Section 14.5.5.1, and
16607 support overloading of methods from multiple applicable types.
16608 Clean up logic somewhat. Don't pass null methods to BetterFunction.
16610 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
16611 (RealError, Warning): Append type of report to related symbol.
16613 2004-09-03 Marek Safar <marek.safar@seznam.cz>
16615 * enum.cs: Fixed CLS-Compliance checks for enum members.
16616 Error tests cs3008-8.cs, cs3014-8.cs
16618 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16620 Fixed bug #62342, #63102
16621 * class.cs: ImplementIndexer uses member.IsExplicitImpl
16622 like ImplementMethod.
16624 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16626 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16629 2004-09-02 Martin Baulig <martin@ximian.com>
16631 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
16632 TypeManager.GetArgumentTypes() rather than calling GetParameters()
16635 2004-09-01 Marek Safar <marek.safar@seznam.cz>
16637 C# 2.0 Static classes implemented
16639 * class.cs (TypeContainer): instance_constructors,
16640 initialized_fields, initialized_static_fields,
16641 default_constructor, base_inteface_types are protected to be
16642 accessible from StaticClass.
16643 (TypeContainer.DefineDefaultConstructor): New virtual method
16644 for custom default constructor generating
16645 (StaticClass): New class to handle "Static classes" feature.
16647 * cs-parser.jay: Handle static keyword on class like instance
16650 * driver.cs: Added "/langversion" command line switch with two
16651 options (iso-1, default).
16653 2004-08-31 Marek Safar <marek.safar@seznam.cz>
16655 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
16657 2004-08-31 Miguel de Icaza <miguel@ximian.com>
16659 * delegate.cs: Style.
16661 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
16663 * delegate.cs: Add seperate instance expr field for miguel.
16665 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16667 * PointerArithmetic (Resolve): make sure we are not doing
16668 pointer arith on void*. Also, make sure we are resolved
16669 by not setting eclass until resolve.
16671 All callers: Make sure that PointerArithmetic gets resolved.
16673 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16675 * ArrayCreation (LookupType): If the type does not resolve
16676 to an array, give an error.
16678 2004-08-27 Marek Safar <marek.safar@seznam.cz>
16680 * statement.cs (Try.Resolve): Fixed bug #64222
16682 2004-08-27 Martin Baulig <martin@ximian.com>
16685 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
16688 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16690 * ecore.cs (Constantify): Get underlying type via
16691 System.Enum.GetUnderlyingType to avoid StackOverflow on the
16692 Windows in special cases.
16694 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16696 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
16697 for obtaining also private methods.
16698 (GetRemoveMethod): Used GetRemoveMethod (true)
16699 for obtaining also private methods.
16701 2004-08-24 Martin Baulig <martin@ximian.com>
16703 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
16704 MethodAttributes.HideBySig for operators.
16706 2004-08-23 Martin Baulig <martin@ximian.com>
16708 Back to the old error reporting system :-)
16710 * report.cs (Message): Removed.
16711 (Report.MessageData, ErrorData, WarningData): Removed.
16712 (Report.Error, Warning): Back to the old system.
16714 2004-08-23 Martin Baulig <martin@ximian.com>
16716 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
16718 * class.cs (TypeContainer.ParentContainer): New public virtual
16719 method; replaces the explicit interface implementation.
16720 (ClassPart.ParentContainer): Override.
16722 2004-08-23 Martin Baulig <martin@ximian.com>
16724 * statement.cs (Switch): Added support for constant switches; see
16725 #59428 or test-285.cs.
16727 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16730 * statement.cs (GetEnumeratorFilter): Removed useless
16731 logic because C# specs is strict. GetEnumerator must be
16734 2004-08-22 Martin Baulig <martin@ximian.com>
16736 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
16737 a switch and may break, reset the barrier. Fixes #59867.
16739 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16741 CLS-Compliance speed up (~5% for corlib)
16743 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
16744 New method. Tests container for CLS-Compliant names
16746 * class.cs (TypeContainer.VerifyClsName): New method.
16747 Checks whether container name is CLS Compliant.
16748 (Constructor): Implements IMethodData.
16750 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
16751 low-case table for CLS Compliance test.
16752 (MemberCache.VerifyClsParameterConflict): New method.
16753 Checks method parameters for CS3006 error.
16755 * enum.cs (EnumMember): Is derived from MemberCore.
16756 (Enum.VerifyClsName): Optimized for better performance.
16758 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16760 * report.cs: Renamed Error_T to Error and changed all
16763 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16765 * class.cs (TypeContainer.IndexerArrayList): New inner class
16766 container for indexers.
16767 (TypeContainer.DefaultIndexerName): New constant for default
16768 indexer name. Replaced all "Item" with this constant.
16769 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
16771 * typemanager.cs (TypeManager.default_member_ctor): Cache here
16772 DefaultMemberAttribute constructor.
16774 2004-08-05 Martin Baulig <martin@ximian.com>
16776 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
16779 2004-08-05 Marek Safar <marek.safar@seznam.cz>
16781 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
16782 multi platforms problem.
16784 * compiler.csproj: Included shared files.
16786 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16788 Fix bug 60333, 55971 in the more general way
16789 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16790 Added arg_type argument for constant conversion.
16791 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
16793 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16796 * class.cs (TypeContainer ): New inner classes MethodArrayList,
16797 OperatorArrayList, MethodCoreArrayList for typecontainer
16798 containers. Changed class member types to these new types.
16799 (MethodArrayList.DefineMembers): Added test for CS0659.
16801 2004-08-04 Miguel de Icaza <miguel@ximian.com>
16803 * cfold.cs: Synchronize the folding with the code in expression.cs
16804 Binary.DoNumericPromotions for uint operands.
16806 * attribute.cs: Revert patch from Raja, it introduced a regression
16807 while building Blam-1.2.1 (hard to isolate a test case).
16809 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16813 (TypeContainer.Define): Renamed to DefineContainerMembers because of
16815 (MethodCore.parent_method): New member. The method we're overriding
16816 if this is an override method.
16817 (MethodCore.CheckBase): Moved from Method class and made common.
16818 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
16820 (MethodCore.CheckForDuplications): New abstract method. For custom
16821 member duplication search in a container
16822 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
16823 method and its return type.
16824 (Event.conflict_symbol): New member. Symbol with same name in the
16828 (MemberCache.FindMemberWithSameName): New method. The method
16829 is looking for conflict with inherited symbols.
16831 2004-08-04 Martin Baulig <martin@ximian.com>
16833 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
16835 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
16837 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16839 * report.cs (Message): New enum for better error, warning reference in
16841 (MessageData): New inner abstract class. It generally handles printing of
16842 error and warning messages.
16843 Removed unused Error, Warning, Message methods.
16845 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16847 Fix for cs0592-8.cs test
16849 (Attributable.ValidAttributeTargets): Made public.
16850 (Attribute.ExplicitTarget): New member for explicit target value.
16851 (Attribute.CheckTargets): Now we translate explicit attribute
16852 target to Target here.
16854 2004-08-03 Ben Maurer <bmaurer@ximian.com>
16856 * ecore.cs (MethodGroupExpr): new IsBase property.
16858 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
16860 * delegate.cs (DelegateCreation): store a MethodGroupExpr
16861 rather than an instance expr.
16863 (DelegateCreation.Emit): Use the method group rather than
16864 the instance expression. Also, if you have base.Foo as the
16865 method for a delegate, make sure to emit ldftn, not ldftnvirt.
16867 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
16869 (NewDelegate.DoResolve): Only check for the existance of Invoke
16870 if the method is going to be needed. Use MethodGroupExpr.
16872 (NewDelegate.Emit): Remove, DelegateCreation implements this.
16874 * expression.cs: For pointer arith., make sure to use
16875 the size of the type, not the size of the pointer to
16878 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16881 * class.cs (Class): Added error CS0502 test.
16883 2004-08-03 John Luke <jluke@cfl.rr.com>
16884 Raja R Harinath <rharinath@novell.com>
16887 * attribute.cs (Attribute.complained_before): New flag.
16888 (Attribute.ResolveType, Attribute.Resolve),
16889 (Attribute.DefinePInvokeMethod): Set it.
16890 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
16892 2004-08-03 Martin Baulig <martin@ximian.com>
16894 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
16895 use a user-defined operator; we still need to do numeric
16896 promotions in case one argument is a builtin type and the other
16897 one has an implicit conversion to that type. Fixes #62322.
16899 2004-08-02 Martin Baulig <martin@ximian.com>
16901 * statement.cs (LocalInfo.Flags): Added `IsThis'.
16902 (LocalInfo.IsThis): New public property.
16903 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
16905 2004-08-01 Martin Baulig <martin@ximian.com>
16907 * class.cs (TypeContainer.GetClassBases): Don't set the default
16908 here since we may get called from GetPartialBases().
16909 (TypeContainer.DefineType): If GetClassBases() didn't return a
16910 parent, use the default one.
16912 2004-07-30 Duncan Mak <duncan@ximian.com>
16914 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
16916 2004-07-30 Martin Baulig <martin@ximian.com>
16918 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
16920 * class.cs (SourceMethod): New public class, derive from the
16921 symbol writer's ISourceMethod.
16922 (Method): Use the new symbol writer API.
16924 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
16925 as argument and use the new symbol writer.
16928 (SourceFile): Implement the symbol writer's ISourceFile.
16929 (Location.SymbolDocument): Removed.
16930 (Location.SourceFile): New public property.
16932 * symbolwriter.cs: Use the new symbol writer API.
16934 2004-07-30 Raja R Harinath <rharinath@novell.com>
16936 * Makefile (install-local): Remove. Functionality moved to
16939 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
16941 * Makefile: Install mcs.exe.config file together with mcs.exe.
16942 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
16943 correct runtime version.
16945 2004-07-25 Martin Baulig <martin@ximian.com>
16948 (TypeContainer.RegisterOrder): Removed, this was unused.
16949 (TypeContainer, interface_order): Removed.
16950 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
16951 TypeContainer as argument since we can also be called with a
16952 `PartialContainer' for a partial class/struct/interface.
16953 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
16954 of checking whether we're an `Interface' - we could be a
16955 `PartialContainer'.
16956 (PartialContainer.Register): Override; call
16957 AddClass()/AddStruct()/AddInterface() on our parent.
16959 * cs-parser.jay (interface_member_declaration): Add things to the
16960 `current_container', not the `current_class'.
16962 * rootcontext.cs (RegisterOrder): The overloaded version which
16963 takes an `Interface' was unused, removed.
16965 * typemanager.cs (TypeManager.LookupInterface): Return a
16966 `TypeContainer', not an `Interface'.
16967 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
16968 contain a `PartialContainer' for an interface, so check it's
16969 `Kind' to figure out what it is.
16971 2004-07-25 Martin Baulig <martin@ximian.com>
16973 * class.cs (Class.DefaultTypeAttributes): New public constant.
16974 (Struct.DefaultTypeAttributes): Likewise.
16975 (Interface.DefaultTypeAttributes): Likewise.
16976 (PartialContainer.TypeAttr): Override this and add the
16977 DefaultTypeAttributes.
16979 2004-07-25 Martin Baulig <martin@ximian.com>
16981 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
16982 we can just use the `Parent' field instead.
16984 2004-07-25 Martin Baulig <martin@ximian.com>
16986 * class.cs (TypeContainer.Emit): Renamed to EmitType().
16988 2004-07-25 Martin Baulig <martin@ximian.com>
16990 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
16991 our parts before defining any methods.
16992 (TypeContainer.VerifyImplements): Make this virtual.
16993 (ClassPart.VerifyImplements): Override and call VerifyImplements()
16994 on our PartialContainer.
16996 2004-07-25 Martin Baulig <martin@ximian.com>
16998 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17000 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17001 argument, we can just use the `Parent' field instead.
17004 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17005 (MemberBase.DoDefine): Likewise.
17007 2004-07-24 Martin Baulig <martin@ximian.com>
17009 * decl.cs (MemberCore.Parent): New public field.
17010 (DeclSpace.Parent): Moved to MemberCore.
17012 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17013 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17015 (FieldBase, Field, Operator): Likewise.
17016 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17017 (EventField, Event): Likewise.
17019 2004-07-23 Martin Baulig <martin@ximian.com>
17021 * class.cs (PartialContainer): New public class.
17022 (ClassPart): New public class.
17023 (TypeContainer): Added support for partial classes.
17024 (TypeContainer.GetClassBases): Splitted some of the functionality
17025 out into GetNormalBases() and GetPartialBases().
17027 * cs-tokenizer.cs (Token.PARTIAL): New token.
17028 (Tokenizer.consume_identifier): Added some hacks to recognize
17029 `partial', but only if it's immediately followed by `class',
17030 `struct' or `interface'.
17032 * cs-parser.jay: Added support for partial clases.
17034 2004-07-23 Martin Baulig <martin@ximian.com>
17036 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17037 a `DeclSpace' and also made it readonly.
17038 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17039 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17040 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17042 * cs-parser.jay: Pass the `current_class', not the
17043 `current_container' (at the moment, this is still the same thing)
17044 to a new Method, Property, Event, Indexer or Constructor.
17046 2004-07-23 Martin Baulig <martin@ximian.com>
17048 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17049 and removed the `current_interface' one.
17050 (struct_declaration, class_declaration, interface_declaration):
17051 Set `current_class' to the newly created class/struct/interface;
17052 set their `Bases' and call Register() before parsing their body.
17054 2004-07-23 Martin Baulig <martin@ximian.com>
17056 * class.cs (Kind): New public enum.
17057 (TypeContainer): Made this class abstract.
17058 (TypeContainer.Kind): New public readonly field.
17059 (TypeContainer.CheckDef): New public method; moved here from
17061 (TypeContainer.Register): New public abstract method.
17062 (TypeContainer.GetPendingImplementations): New public abstract
17064 (TypeContainer.GetClassBases): Removed the `is_class' and
17065 `is_iface' parameters.
17066 (TypeContainer.DefineNestedTypes): Formerly known as
17068 (ClassOrStruct): Made this class abstract.
17070 * tree.cs (RootTypes): New public type.
17072 2004-07-20 Martin Baulig <martin@ximian.com>
17074 * tree.cs (Tree.RecordNamespace): Removed.
17075 (Tree.Namespaces): Removed.
17077 * rootcontext.cs (RootContext.IsNamespace): Removed.
17079 * cs-parser.jay (namespace_declaration): Just create a new
17080 NamespaceEntry here.
17082 2004-07-20 Martin Baulig <martin@ximian.com>
17084 * statement.cs (ExceptionStatement): New abstract class. This is
17085 now used as a base class for everyone who's using `finally'.
17086 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17087 our local variables before using them.
17089 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17090 virtual method. This is used by Yield.Resolve() to "steal" an
17091 outer block's `finally' clauses.
17092 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17095 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17096 version which takes an ExceptionStatement. This version must be
17097 used to create exception branchings.
17100 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17101 (Iterator.EmitMoveNext): Added exception support; protect the
17102 block with a `fault' clause, properly handle 'finally' clauses.
17103 (Iterator.EmitDispose): Run all the `finally' clauses here.
17105 2004-07-20 Martin Baulig <martin@ximian.com>
17107 * iterator.cs: This is the first of a set of changes in the
17108 iterator code. Match the spec more closely: if we're an
17109 IEnumerable, then GetEnumerator() must be called. The first time
17110 GetEnumerator() is called, it returns the current instance; all
17111 subsequent invocations (if any) must create a copy.
17113 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17115 * expression.cs: Resolve the constant expression before returning
17118 2004-07-19 Martin Baulig <martin@ximian.com>
17120 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17121 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17122 the return type of the new EmitContext.
17124 2004-07-18 Martin Baulig <martin@ximian.com>
17126 * class.cs (Property.Define): Fix iterators.
17128 * iterators.cs (Iterator.Define): Moved the
17129 `container.AddInterator (this)' call here from the .ctor; only do
17130 it if we resolved successfully.
17132 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17134 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17135 `true' for preprocessing directives that we parse. The return
17136 value indicates whether we should return to regular tokenizing or
17137 not, not whether it was parsed successfully.
17139 In the past if we were in: #if false ... #line #endif, we would
17140 resume parsing after `#line'. See bug 61604.
17142 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17143 building: IsEnumType should return true only for enums, not for
17144 enums or System.Enum itself. This fixes #61593.
17146 Likely what happened is that corlib was wrong: mcs depended on
17147 this bug in some places. The bug got fixed, we had to add the
17148 hack, which caused bug 61593.
17150 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17151 that was a workaround for the older conditions.
17153 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17155 * assign.cs: IAssignMethod has a new interface, as documented
17156 inline. All assignment code now uses this new api.
17158 * ecore.cs, expression.cs: All classes which implement
17159 IAssignMethod now use the new interface.
17161 * expression.cs (Invocation): add a hack to EmitCall so that
17162 IndexerAccess can be the target of a compound assignment without
17163 evaluating its arguments twice.
17165 * statement.cs: Handle changes in Invocation api.
17167 2004-07-16 Martin Baulig <martin@ximian.com>
17169 * iterators.cs: Rewrote this. We're now using one single Proxy
17170 class for both the IEnumerable and the IEnumerator interface and
17171 `Iterator' derives from Class so we can use the high-level API.
17173 * class.cs (TypeContainer.AddIterator): New method.
17174 (TypeContainer.DoDefineType): New protected virtual method, which
17175 is called from DefineType().
17176 (TypeContainer.DoDefineMembers): Call DefineType() and
17177 DefineMembers() on all our iterators.
17178 (TypeContainer.Emit): Call Emit() on all our iterators.
17179 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17181 * codegen.cs (EmitContext.CurrentIterator): New public field.
17183 2004-07-15 Martin Baulig <martin@ximian.com>
17186 (TypeManager.not_supported_exception_type): New type.
17188 2004-07-14 Martin Baulig <martin@ximian.com>
17190 * iterators.cs: Use real error numbers.
17192 2004-07-14 Martin Baulig <martin@ximian.com>
17194 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17195 requires this to be a System.Collection.IEnumerable and not a
17196 class implementing that interface.
17197 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17199 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17201 * class.cs: Fixed previous fix, it broke some error tests.
17203 2004-07-12 Martin Baulig <martin@ximian.com>
17205 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17208 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17210 * assign.cs (LocalTemporary): Add new argument: is_address,If
17211 `is_address' is true, then the value that we store is the address
17212 to the real value, and not the value itself.
17214 * ecore.cs (PropertyExpr): use the new local temporary
17215 stuff to allow us to handle X.Y += z (where X is a struct)
17217 2004-07-08 Martin Baulig <martin@ximian.com>
17219 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17220 not always return, just like we're doing in Using.Resolve().
17222 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17224 * cs-parser.jay (fixed_statement): flag this as Pinned.
17226 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17228 * typemanager.cs (TypeManager): Removed MakePinned method, this
17229 mechanism is replaced with the .NET 2.x compatible mechanism of
17230 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17232 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17233 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17234 `IsFixed' property which has a different meaning.
17236 2004-07-02 Raja R Harinath <rharinath@novell.com>
17238 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17239 visible from inside a nested class, not just the names of the
17240 immediately enclosing class.
17241 Fix for bug #60730.
17243 2004-06-24 Raja R Harinath <rharinath@novell.com>
17245 * expression.cs (BetterConversion): Remove buggy special-case
17246 handling of "implicit constant expression conversions". At this
17247 point, we already know that the conversion is possible -- we're
17248 only checking to see which is better.
17250 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17252 * cs-parser.jay: Added error CS0210 test.
17254 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17256 * cs-parser.jay: Added error CS0134 test.
17258 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17261 * cs-parser.jay: Added error CS0145 test.
17263 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17265 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17267 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17269 * expression.cs (StackAlloc.Resolve): The argument may not
17270 be a constant; deal with this case.
17272 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17274 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17275 GetIndexerAttributeValue.
17276 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17278 * class.cs (Indexer.Define): Added error tests for CS0415,
17281 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17283 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17286 2004-06-23 Martin Baulig <martin@ximian.com>
17288 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17289 neither return nor throw, reset the barrier as well. Fixes #60457.
17291 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17293 * class.cs : EventAttributes is now set to None by default.
17294 This fixes bug #60459.
17296 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17299 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17300 Don't throw exception but return null (it's sufficient now).
17302 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17304 * typemanager.cs (GetArgumentTypes): Faster implementation.
17306 2004-06-18 Martin Baulig <martin@ximian.com>
17308 * attribute.cs (Attribute.Resolve): Check whether we're an
17309 EmptyCast which a Constant child. Fixes #60333.
17311 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17313 * statement.cs (EmitCollectionForeach): Account for the fact that
17314 not all valuetypes are in areas which we can take the address of.
17315 For these variables, we store to a temporary variable. Also, make
17316 sure that we dont emit a `callvirt' on a valuetype method.
17318 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17320 * expression.cs (StackAlloc.DoReSolve): Added test for
17321 negative parameter (CS0247).
17323 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17326 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17328 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17331 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17334 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17336 Fix bug #58254 & cs1555.cs, cs1556.cs
17337 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17339 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17341 * cs-parser.jay: Added error CS1669 test for indexers.
17343 2004-06-11 Martin Baulig <martin@ximian.com>
17345 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17346 call this twice: for params and varargs methods.
17348 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17351 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17353 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17355 * attribute.cs (Attribute.GetValidTargets): Made public.
17358 (AbstractPropertyEventMethod): New class for better code sharing.
17359 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17361 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17363 2004-06-11 Raja R Harinath <rharinath@novell.com>
17366 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17367 that the call to Resolve is part of a MemberAccess.
17368 (Expression.Resolve): Use it for SimpleName resolution.
17369 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17370 Add 'intermediate' boolean argument.
17371 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17372 error message when the SimpleName can be resolved ambiguously
17373 between an expression and a type.
17374 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17376 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17377 call on the left-side.
17379 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17382 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17384 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17386 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17388 2004-06-11 Martin Baulig <martin@ximian.com>
17390 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17391 varargs methods if applicable.
17393 2004-06-11 Martin Baulig <martin@ximian.com>
17395 * expression.cs (Invocation.EmitCall): Don't use
17396 `method.CallingConvention == CallingConventions.VarArgs' since the
17397 method could also have `CallingConventions.HasThis'.
17399 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17401 * class.cs (Event.GetSignatureForError): Implemented.
17402 Fixed crash in error test cs3010.cs
17404 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17406 * cs-tokenizer.cs: Change the way we track __arglist to be
17407 consistent with the other keywords.
17409 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17411 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17414 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17416 * codegen.cs: Check that all referenced assemblies have a strongname
17417 before strongnaming the compiled assembly. If not report error CS1577.
17418 Fix bug #56563. Patch by Jackson Harper.
17419 * typemanager.cs: Added a method to return all referenced assemblies.
17420 Fix bug #56563. Patch by Jackson Harper.
17422 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17425 (Method.ApplyAttributeBuilder): Moved and added conditional
17426 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17429 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17431 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17434 * class.cs: (EventField.attribute_targets): Changed default target.
17436 2004-06-08 Martin Baulig <martin@ximian.com>
17438 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17440 2004-06-08 Martin Baulig <martin@ximian.com>
17442 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17444 2004-06-07 Martin Baulig <martin@ximian.com>
17446 Added support for varargs methods.
17448 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17451 * cs-parser.jay: Added support for `__arglist'.
17453 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17455 * expression.cs (Argument.AType): Added `ArgList'.
17456 (Invocation): Added support for varargs methods.
17457 (ArglistAccess): New public class.
17458 (Arglist): New public class.
17460 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17462 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17463 a method's top-level block if the method has varargs.
17465 * support.cs (ReflectionParameters, InternalParameters): Added
17466 support for varargs methods.
17468 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17470 * class.cs: Provide location in indexer error report.
17472 * driver.cs: Use standard names.
17474 * namespace.cs: Catch the use of using after a namespace has been
17475 declared also on using aliases.
17477 2004-06-03 Raja R Harinath <rharinath@novell.com>
17480 * typemanager.cs (closure_private_ok, closure_invocation_type)
17481 (closure_qualifier_type, closure_invocation_assembly)
17482 (FilterWithClosure): Move to ...
17483 (Closure): New internal nested class.
17484 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17485 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17486 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17487 (MemberLookup, MemberLookupFailed): Use it.
17488 * expression.cs (New.DoResolve): Treat the lookup for the
17489 constructor as being qualified by the 'new'ed type.
17490 (Indexers.GetIndexersForTypeOrInterface): Update.
17492 2004-06-03 Marek Safar <marek.safar@seznam.cz>
17495 (GetConditionalAttributeValue): New method. Returns
17496 condition of ConditionalAttribute.
17497 (SearchMulti): New method. Returns all attributes of type 't'.
17498 Use it when attribute is AllowMultiple = true.
17499 (IsConditionalMethodExcluded): New method.
17502 (Method.IsExcluded): Implemented. Returns true if method has conditional
17503 attribute and the conditions is not defined (method is excluded).
17504 (IMethodData): Extended interface for ConditionalAttribute support.
17505 (PropertyMethod.IsExcluded): Implemented.
17508 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
17511 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
17514 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
17516 * expression.cs (ArrayCreationExpression): Make this just an
17517 `expression'. It can't be a statement, so the code here was
17520 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17523 * typemanager.cs (GetFullNameSignature): New method for
17526 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17529 * class.cs (MemberBase.GetSignatureForError): New virtual method.
17530 Use this method when MethodBuilder is null.
17531 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
17532 Added test for error CS0626 (MONO reports error for this situation).
17533 (IMethodData.GetSignatureForError): Extended interface.
17535 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17538 (AttributeTester.GetObsoleteAttribute): Returns instance of
17539 ObsoleteAttribute when type is obsolete.
17542 (TypeContainer.VerifyObsoleteAttribute): Override.
17543 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
17544 (MethodCode.VerifyObsoleteAttribute): Override.
17545 (MemberBase.VerifyObsoleteAttribute): Override.
17548 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
17549 and report proper error.
17552 Delegate.VerifyObsoleteAttribute): Override.
17555 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
17556 and report proper error.
17557 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
17560 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
17564 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
17565 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
17566 Added test for ObsoleteAttribute.
17569 (Catch): Derived from Statement.
17571 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17573 Fixed bug #59071 & cs0160.cs
17575 * statement.cs (Try.Resolve): Check here whether order of catch
17576 clauses matches their dependencies.
17578 2004-05-31 Miguel de Icaza <miguel@ximian.com>
17580 * Reverted patch to namespace.cs (Use lookuptypedirect). This
17581 caused a regression: #59343. Referencing nested classes from an
17582 assembly stopped working.
17584 2004-05-31 Martin Baulig <martin@ximian.com>
17586 MCS is now frozen for beta 2.
17588 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17590 * convert.cs: add a trivial cache for overload operator resolution.
17592 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17594 * decl.cs: If possible, use lookuptypedirect here. We can only do
17595 this if there is no `.' after the namespace. Avoids using
17596 LookupType, which does lots of slow processing.
17597 (FindNestedType) New method, does what it says :-).
17598 * namespace.cs: use LookupTypeDirect.
17599 * rootcontext.cs: use membercache, if possible.
17600 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
17602 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17605 According to the spec,
17607 In a member access of the form E.I, if E is a single identifier,
17608 and if the meaning of E as a simple-name (§7.5.2) is a constant,
17609 field, property, localvariable, or parameter with the same type as
17610 the meaning of E as a type-name (§3.8), then both possible
17611 meanings of E are permitted.
17613 We did not check that E as a simple-name had the same type as E as
17616 This trivial check gives us 5-7% on bootstrap time.
17618 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17620 * expression.cs (Invocation.OverloadResolve): Avoid the
17621 use of hashtables and boxing here by allocating on demand.
17623 2004-05-30 Martin Baulig <martin@ximian.com>
17625 * rootcontext.cs (RootContext.LookupType): Don't cache things if
17626 we're doing a silent lookup. Don't try to lookup nested types in
17627 TypeManager.object_type (thanks to Ben Maurer).
17629 2004-05-30 Martin Baulig <martin@ximian.com>
17631 Committing a patch from Ben Maurer.
17633 * rootcontext.cs (RootContext.LookupType): Cache negative results.
17635 2004-05-29 Martin Baulig <martin@ximian.com>
17637 * class.cs (IMethodData.ShouldIgnore): New method.
17639 * typemanager.cs (TypeManager.MethodFlags): Don't take a
17640 `Location' argument, we don't need it anywhere. Use
17641 `IMethodData.ShouldIgnore ()' instead of
17642 `MethodData.GetMethodFlags ()'.
17643 (TypeManager.AddMethod): Removed.
17644 (TypeManager.AddMethod2): Renamed to AddMethod.
17646 2004-05-29 Martin Baulig <martin@ximian.com>
17648 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
17650 * convert.cs (Convert.ImplicitReferenceConversion): If we're
17651 converting from a class type S to an interface type and we already
17652 have an object on the stack, don't box it again. Fixes #52578.
17654 2004-05-29 Martin Baulig <martin@ximian.com>
17656 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17657 Added support for `params' parameters. Fixes #59267.
17659 2004-05-29 Martin Baulig <martin@ximian.com>
17661 * literal.cs (NullPointer): Provide a private .ctor which sets
17662 `type' to TypeManager.object_type. Fixes #59048.
17664 2004-05-29 Martin Baulig <martin@ximian.com>
17666 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
17667 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
17669 * ecore.cs (EventExpr.instance_expr): Make the field private.
17671 2004-05-26 Marek Safar <marek.safar@seznam.cz>
17673 Fixed bug #50080 & cs0214-2.cs
17674 * expression.cs (Cast.DoResolve): Check unsafe context here.
17676 * statement.cs (Resolve.DoResolve): Likewise.
17678 2004-05-26 Martin Baulig <martin@ximian.com>
17680 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
17682 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
17683 (RootContext.LookupType): Pass down the `silent' flag.
17685 2004-05-25 Martin Baulig <martin@ximian.com>
17688 (MethodGroupExpr.IdenticalTypeName): New public property.
17689 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
17690 expression actually refers to a type.
17692 2004-05-25 Martin Baulig <martin@ximian.com>
17694 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
17695 for #56176 and made it actually work.
17697 2004-05-25 Martin Baulig <martin@ximian.com>
17699 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
17700 (FieldExpr, PropertyExpr): Override and implement
17701 CacheTemporaries. Fixes #52279.
17703 2004-05-25 Miguel de Icaza <miguel@ximian.com>
17705 * location.cs: In the new compiler listing a file twice is a
17706 warning, not an error.
17708 2004-05-24 Martin Baulig <martin@ximian.com>
17710 * enum.cs (Enum.DefineType): For the `BaseType' to be a
17711 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
17713 2004-05-24 Martin Baulig <martin@ximian.com>
17715 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
17716 walking the `using' list. Fixes #53921.
17718 2004-05-24 Martin Baulig <martin@ximian.com>
17720 * const.cs (Const.LookupConstantValue): Added support for
17721 EmptyCast's; fixes #55251.
17723 2004-05-24 Martin Baulig <martin@ximian.com>
17725 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
17726 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
17727 which does the CS0135 check. The reason is that we first need to
17728 check whether the variable actually exists.
17730 2004-05-24 Martin Baulig <martin@ximian.com>
17732 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
17733 than RootContext.LookupType() to find the explicit interface
17734 type. Fixes #58584.
17736 2004-05-24 Raja R Harinath <rharinath@novell.com>
17738 * Makefile: Simplify. Use executable.make.
17739 * mcs.exe.sources: New file. List of sources of mcs.exe.
17741 2004-05-24 Anders Carlsson <andersca@gnome.org>
17745 Use the invariant culture when doing String.Compare for CLS case
17748 2004-05-23 Martin Baulig <martin@ximian.com>
17750 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
17751 don't have any dots. Fixes #52622, added cs0246-8.cs.
17753 * namespace.cs (NamespaceEntry.Lookup): Likewise.
17755 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17757 * class.cs (MemberBase.Define): Reuse MemberType member for
17758 resolved type. Other methods can use it too.
17760 2004-05-23 Martin Baulig <martin@ximian.com>
17762 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
17763 the variable also exists in the current block (otherwise, we need
17764 to report a CS0103). Fixes #58670.
17766 2004-05-23 Martin Baulig <martin@ximian.com>
17768 * flowanalysis.cs (Reachability.Reachable): Compute this
17769 on-the-fly rather than storing it as a field.
17771 2004-05-23 Martin Baulig <martin@ximian.com>
17773 * flowanalysis.cs (Reachability.And): Manually compute the
17774 resulting `barrier' from the reachability.
17776 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17779 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
17780 instance of ObsoleteAttribute when symbol is obsolete.
17783 (IMethodData): Extended interface for ObsoleteAttribute support.
17785 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17787 * attribute.cs: Fix bug #55970
17789 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17793 (GetObsoleteAttribute): New method. Creates the instance of
17795 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
17796 ObsoleteAttribute when member is obsolete.
17797 (AttributeTester.Report_ObsoleteMessage): Common method for
17798 Obsolete error/warning reporting.
17801 (TypeContainer.base_classs_type): New member for storing parent type.
17804 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
17805 for this MemberCore.
17807 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17809 * attribute.cs, const.cs: Fix bug #58590
17811 2004-05-21 Martin Baulig <martin@ximian.com>
17813 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
17814 out parameters if the end of the method is unreachable. Fixes
17817 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17819 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
17820 Hari was right, why extra method.
17822 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17824 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
17826 2004-05-20 Martin Baulig <martin@ximian.com>
17828 Merged this back from gmcs to keep the differences to a minumum.
17830 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
17831 instead of a Declspace.
17832 (Attribute.ResolveType): Likewise.
17833 (Attributes.Search): Likewise.
17834 (Attributes.Contains): Likewise.
17835 (Attributes.GetClsCompliantAttribute): Likewise.
17837 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
17839 (MethodData.ApplyAttributes): Take an EmitContext instead of a
17842 2004-05-19 Marek Safar <marek.safar@seznam.cz>
17844 Fix bug #58688 (MCS does not report error when the same attribute
17847 * attribute.cs (Attribute.Emit): Distinction between null and default.
17849 2004-05-19 Raja R Harinath <rharinath@novell.com>
17851 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
17852 of a top-level attribute without an attribute target.
17853 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
17855 (Attribute.Conditional_GetConditionName),
17856 (Attribute.Obsolete_GetObsoleteMessage): Update.
17857 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
17858 part of ScanForIndexerName.
17859 (Attribute.CanIgnoreInvalidAttribute): New function.
17860 (Attribute.ScanForIndexerName): Move to ...
17861 (Attributes.ScanForIndexerName): ... here.
17862 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
17863 (Attributes.Search): New internal variant that can choose not to
17864 complain if types aren't resolved. The original signature now
17866 (Attributes.GetClsCompliantAttribute): Use internal variant, with
17867 complaints suppressed.
17868 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
17869 only if it not useful.
17870 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
17871 top-level for attributes that are shared between the assembly
17872 and a top-level class.
17873 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
17874 * class.cs: Update to reflect changes.
17875 (DefineIndexers): Fuse loops.
17876 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
17877 a couple more variants of attribute names.
17879 2004-05-18 Marek Safar <marek.safar@seznam.cz>
17881 Fix bug #52585 (Implemented explicit attribute declaration)
17884 (Attributable.ValidAttributeTargets): New abstract method. It gets
17885 list of valid attribute targets for explicit target declaration.
17886 (Attribute.Target): It holds target itself.
17887 (AttributeSection): Removed.
17888 (Attribute.CheckTargets): New method. It checks whether attribute
17889 target is valid for the current element.
17892 (EventProperty): New class. For events that are declared like
17893 property (with add and remove accessors).
17894 (EventField): New class. For events that are declared like field.
17897 * cs-parser.jay: Implemented explicit attribute target declaration.
17899 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
17900 Override ValidAttributeTargets.
17903 (ReturnParameter): Class for applying custom attributes on
17905 (ParameterAtribute): New class. Class for applying custom
17906 attributes on the parameter type.
17908 2004-05-17 Miguel de Icaza <miguel@ximian.com>
17910 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
17913 (Method): Allow UNSAFE here.
17915 * modifiers.cs: Support unsafe reporting.
17917 2004-05-17 Marek Safar <marek.safar@seznam.cz>
17919 * decl.cs: Fix bug #58478.
17921 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17923 * statement.cs: When checking for unreachable code on an EmptyStatement,
17924 set the location. Fixes bug #58488.
17926 2004-05-13 Miguel de Icaza <miguel@ximian.com>
17928 * driver.cs: Add -pkg handling.
17930 From Gonzalo: UseShelLExecute=false
17932 2004-05-12 Marek Safar <marek.safar@seznam.cz>
17935 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
17937 (Attribute.IsClsCompliaceRequired): Moved to base for better
17939 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
17940 when attribute is AttributeUsageAttribute.
17941 (Attribute.GetValidTargets): Simplified.
17942 (Attribute.GetAttributeUsage): New method returns AttributeUsage
17943 attribute for this type.
17944 (Attribute.ApplyAttributes): Method renamed to Emit and make
17946 (GlobalAttributeSection): New class for special handling of global
17947 attributes (assembly, module).
17948 (AttributeSection.Emit): New method.
17950 * class.cs: Implemented Attributable abstract methods.
17951 (MethodCore.LabelParameters): Moved to Parameter class.
17952 (Accessor): Is back simple class.
17953 (PropertyMethod): Implemented Attributable abstract class.
17954 (DelegateMethod): Implemented Attributable abstract class.
17955 (Event): New constructor for disctintion between normal Event
17956 and Event with accessors.
17958 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
17960 * codegen.cs, const.cs, decl.cs, delegate.cs:
17961 (CommonAssemblyModulClass): Implemented Attributable abstract class
17964 * enum.cs: Implement IAttributeSupport interface.
17965 (EnumMember): New class for emum members. Implemented Attributable
17969 (ParameterBase): Is abstract.
17970 (ReturnParameter): New class for easier [return:] attribute handling.
17972 * typemanager.cs: Removed builder_to_attr.
17974 2004-05-11 Raja R Harinath <rharinath@novell.com>
17977 * attribute.cs (Attribute.GetPositionalValue): New function.
17978 * class.cs (TypeContainer.VerifyMembers): New function.
17979 (TypeContainer.Emit): Use it.
17980 (ClassOrStruct): New base class for Class and Struct.
17981 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
17982 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
17984 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
17985 then each non-static field should have a FieldOffset attribute.
17986 Otherwise, none of the fields should have a FieldOffset attribute.
17987 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
17988 and FieldOffset attributes.
17989 * typemanager.cs (TypeManager.struct_layout_attribute_type)
17990 (TypeManager.field_offset_attribute_type): New core types.
17991 (TypeManager.InitCoreTypes): Initialize them.
17993 2004-05-11 Michal Moskal <malekith@pld-linux.org>
17995 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
17996 Return correct type.
17999 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18001 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18002 be implicitly converted to ulong.
18004 * expression.cs: The logic for allowing operator &, | and ^ worked
18005 was wrong, it worked before because we did not report an error in
18006 an else branch. Fixes 57895.
18008 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18009 allow volatile fields to be reference types.
18011 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18013 * driver.cs: Add support for /debug-
18015 2004-05-07 Raja R Harinath <rharinath@novell.com>
18017 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18018 Add a 'complain' parameter to silence errors.
18019 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18020 silently overlooked type-resolutions.
18021 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18022 to reflect changes.
18023 (Attributes.Search): New function.
18024 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18025 (Attributes.GetAttributeFullName): Remove hack.
18026 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18027 Update to reflect changes.
18028 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18029 Use Attributes.Search instead of nested loops.
18031 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18034 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18035 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18036 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18038 * report.cs: (Report.Warning): Renamed to Warning_T because of
18039 parameter collision.
18041 2004-05-05 Raja R Harinath <rharinath@novell.com>
18043 * expression.cs (MemberAccess.ResolveMemberAccess):
18044 Exit with non-zero status after Report.Error.
18045 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18047 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18049 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18051 * support.cs: Don't hang when the file is empty.
18053 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18055 * support.cs: In SeekableStreamReader, compute the preamble size of the
18056 underlying stream. Position changes should take into account that initial
18059 2004-05-03 Todd Berman <tberman@sevenl.net>
18061 * driver.cs: remove unused GetSysVersion function.
18063 2004-05-03 Todd Berman <tberman@sevenl.net>
18065 * driver.cs: Remove the hack from saturday, as well as the hack
18066 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18067 link_paths to get that bit proper.
18069 2004-05-01 Todd Berman <tberman@sevenl.net>
18071 * driver.cs: Try a LoadFrom before a Load, this checks the current
18072 path. This is currently a bug in mono that is be fixed, however, this
18073 provides a workaround for now. This will be removed when the bug
18076 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18078 * CryptoConvert.cs: Updated to latest version. Fix issue with
18079 incomplete key pairs (#57941).
18081 2004-05-01 Todd Berman <tberman@sevenl.net>
18083 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18086 2004-04-30 Jackson Harper <jackson@ximian.com>
18088 * codegen.cs: Open keys readonly.
18090 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18092 * typemanager.cs: don't report cyclic struct layout when a struct
18093 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18094 which has 2 Pango.Rectangle fields.
18096 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18098 * expression.cs: Handle IntPtr comparisons with IL code
18099 rather than a method call.
18101 2004-04-29 Martin Baulig <martin@ximian.com>
18103 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18104 the list of PropertyInfo's in class hierarchy and find the
18105 accessor. Fixes #56013.
18107 2004-04-29 Martin Baulig <martin@ximian.com>
18109 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18111 2004-04-29 Martin Baulig <martin@ximian.com>
18113 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18115 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18117 2004-04-29 Martin Baulig <martin@ximian.com>
18119 * class.cs (ConstructorInitializer.Resolve): Check whether the
18120 parent .ctor is accessible. Fixes #52146.
18122 2004-04-29 Martin Baulig <martin@ximian.com>
18124 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18126 * statement.cs (Using.EmitLocalVariableDecls): Use
18127 TypeManager.idisposable_type, not typeof (IDisposable).
18128 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18130 2004-04-29 Martin Baulig <martin@ximian.com>
18132 * class.cs (Event.Define): Don't emit the field and don't set
18133 RTSpecialName and SpecialName for events on interfaces. Fixes
18136 2004-04-29 Raja R Harinath <rharinath@novell.com>
18138 Refactor Attribute.ApplyAttributes.
18139 * attribute.cs (Attributable): New base class for objects that can
18140 have Attributes applied on them.
18141 (Attribute): Make AttributeUsage fields public.
18142 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18143 (Attribute.IsInternalCall): New property.
18144 (Attribute.UsageAttr): Convert to a public read-only property.
18145 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18146 (Attribute.ResolveType, Attribute.Resolve)
18147 (Attribute.ScanForIndexerName): Update to reflect changes.
18148 (Attribute.CheckAttributeTarget): Re-format.
18149 (Attribute.ApplyAttributes): Refactor, to various
18150 Attributable.ApplyAttributeBuilder methods.
18151 * decl.cs (MemberCore): Make Attributable.
18152 * class.cs (Accessor): Make Attributable.
18153 (MethodData.ApplyAttributes): Use proper attribute types, not
18155 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18156 (TypeContainer.ApplyAttributeBuilder)
18157 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18158 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18159 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18160 (Operator.ApplyAttributeBuilder): New factored-out methods.
18161 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18162 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18163 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18164 * parameter.cs (ParameterBase): New Attributable base class
18165 that can also represent Return types.
18166 (Parameter): Update to the changes.
18168 2004-04-29 Jackson Harper <jackson@ximian.com>
18170 * driver.cs: Prefer the corlib system version when looking for
18171 assemblies in the GAC. This is still a hack, but its a better hack
18174 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18176 * decl.cs, enum.cs: Improved error 3005 reporting.
18178 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18179 (related_symbols): New private member for list of symbols
18180 related to reported error/warning.
18182 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18184 2004-04-29 Martin Baulig <martin@ximian.com>
18186 * ecore.cs (Expression.Constantify): If we're an enum and
18187 TypeManager.TypeToCoreType() doesn't give us another type, use
18188 t.UnderlyingSystemType. Fixes #56178.
18190 2004-04-29 Martin Baulig <martin@ximian.com>
18192 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18193 interfaces and for each interface, only add members directly
18194 declared in that interface. Fixes #53255.
18196 2004-04-28 Martin Baulig <martin@ximian.com>
18198 * expression.cs (ConditionalLogicalOperator): Use a temporary
18199 variable for `left' to avoid that we evaluate it more than once;
18202 2004-04-28 Martin Baulig <martin@ximian.com>
18204 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18207 2004-04-28 Martin Baulig <martin@ximian.com>
18209 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18212 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18213 whether the type is not void (CS1547).
18215 2004-04-28 Martin Baulig <martin@ximian.com>
18217 * expression.cs (Unary.DoResolveLValue): Override this and report
18218 CS0131 for anything but Operator.Indirection.
18220 2004-04-28 Martin Baulig <martin@ximian.com>
18222 Committing a patch from Ben Maurer; see bug #50820.
18224 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18227 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18230 2004-04-28 Martin Baulig <martin@ximian.com>
18232 Committing a patch from Ben Maurer; see bug #50820.
18234 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18237 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18240 2004-04-28 Martin Baulig <martin@ximian.com>
18242 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18243 (Block.AddLabel): Call DoLookupLabel() to only search in the
18246 2004-04-28 Martin Baulig <martin@ximian.com>
18248 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18249 comparing StringConstants and NullLiterals in Equality and Inequality.
18251 2004-04-28 Jackson Harper <jackson@ximian.com>
18253 * driver.cs: Attempt to load referenced assemblies from the
18254 GAC. This is the quick and dirty version of this method that
18255 doesnt take into account versions and just takes the first
18256 canidate found. Will be good enough for now as we will not have more
18257 then one version installed into the GAC until I update this method.
18259 2004-04-28 Martin Baulig <martin@ximian.com>
18261 * typemanager.cs (TypeManager.CheckStructCycles): New public
18262 static method to check for cycles in the struct layout.
18264 * rootcontext.cs (RootContext.PopulateTypes): Call
18265 TypeManager.CheckStructCycles() for each TypeContainer.
18266 [Note: We only need to visit each type once.]
18268 2004-04-28 Martin Baulig <martin@ximian.com>
18270 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18272 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18273 success and added `out object value'. Use a `bool resolved' field
18274 to check whether we've already been called rather than
18275 `ConstantValue != null' since this breaks for NullLiterals.
18277 2004-04-28 Raja R Harinath <rharinath@novell.com>
18279 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18280 setting of this flag, since the 'set' method may be non-public.
18282 2004-04-28 Raja R Harinath <rharinath@novell.com>
18284 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18285 check on current_vector.Block.
18287 2004-04-27 Martin Baulig <martin@ximian.com>
18289 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18290 a field initializer. Fixes #56459.
18292 2004-04-27 Martin Baulig <martin@ximian.com>
18294 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18295 we're not attempting to use an indexer. Fixes #52154.
18297 2004-04-27 Martin Baulig <martin@ximian.com>
18299 * statement.cs (Return): Don't create a return label if we don't
18300 need it; reverts my change from January 20th. Thanks to Ben
18303 2004-04-27 Martin Baulig <martin@ximian.com>
18305 According to the spec, `goto' can only leave a nested scope, but
18308 * statement.cs (Block.LookupLabel): Only lookup in the current
18309 block, don't recurse into parent or child blocks.
18310 (Block.AddLabel): Check in parent and child blocks, report
18311 CS0140/CS0158 if we find a duplicate.
18312 (Block): Removed this indexer for label lookups.
18313 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18314 this already does the error reporting for us.
18317 (FlowBranching.UsageVector.Block): New public variable; may be null.
18318 (FlowBranching.CreateSibling): Added `Block' argument.
18319 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18320 label for the target of a `goto' and check whether we're not
18321 leaving a `finally'.
18323 2004-04-27 Martin Baulig <martin@ximian.com>
18325 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18326 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18329 2004-04-27 Martin Baulig <martin@ximian.com>
18331 * statement.cs (Block.AddLabel): Also check for implicit blocks
18332 and added a CS0158 check.
18334 2004-04-27 Martin Baulig <martin@ximian.com>
18336 * flowanalysis.cs (FlowBranchingLoop): New class.
18337 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18338 UsageVector's instead of an ArrayList.
18339 (FlowBranching.Label): Likewise.
18340 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18341 (FlowBranching.AddBreakVector): New method.
18343 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18345 * attribute.cs: Small regression fix: only convert the type if we
18346 the type is different, fixes System.Drawing build.
18348 2004-04-27 Martin Baulig <martin@ximian.com>
18350 * attribute.cs (Attribute.Resolve): If we have a constant value
18351 for a named field or property, implicity convert it to the correct
18354 2004-04-27 Raja R Harinath <rharinath@novell.com>
18356 * statement.cs (Block.Block): Implicit blocks share
18357 'child_variable_names' fields with parent blocks.
18358 (Block.AddChildVariableNames): Remove.
18359 (Block.AddVariable): Mark variable as "used by a child block" in
18360 every surrounding block.
18361 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18362 been used in a child block, complain about violation of "Invariant
18363 meaning in blocks" rule.
18364 * cs-parser.jay (declare_local_variables): Don't use
18365 AddChildVariableNames.
18366 (foreach_statement): Don't create an implicit block: 'foreach'
18367 introduces a scope.
18369 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18371 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18372 converting from 0L to ulong. Fixes 57522.
18374 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18376 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18377 derived class hides via 'new' keyword field from base class (test-242.cs).
18378 TODO: Handle this in the more general way.
18380 * class.cs (CheckBase): Ditto.
18382 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18384 * decl.cs (caching_flags): New member for storing cached values
18386 (MemberCore.Flags): New enum where bit flags for caching_flags
18388 (MemberCore.cls_compliance): Moved to caching_flags.
18389 (DeclSpace.Created): Moved to caching_flags.
18391 * class.cs: Use caching_flags instead of DeclSpace.Created
18393 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18395 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18396 if we are only a derived class, not a nested class.
18398 * typemanager.cs: Same as above, but do this at the MemberLookup
18399 level (used by field and methods, properties are handled in
18400 PropertyExpr). Allow for the qualified access if we are a nested
18403 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18405 * class.cs: Refactoring.
18406 (IMethodData): New inteface; Holds links to parent members
18407 to avoid member duplication (reduced memory allocation).
18408 (Method): Implemented IMethodData interface.
18409 (PropertyBase): New inner classes for get/set methods.
18410 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18411 (Event): New inner classes for add/remove methods.
18412 (Event.DelegateMethod): Implemented IMethodData interface.
18414 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18415 EmitContext (related to class.cs refactoring).
18417 2004-04-21 Raja R Harinath <rharinath@novell.com>
18419 * delegate.cs (Delegate.VerifyApplicability): If the number of
18420 arguments are the same as the number of parameters, first try to
18421 verify applicability ignoring any 'params' modifier on the last
18425 2004-04-16 Raja R Harinath <rharinath@novell.com>
18427 * class.cs (TypeContainer.AddIndexer): Use
18428 'ExplicitInterfaceName' to determine if interface name was
18429 explicitly specified. 'InterfaceType' is not initialized at this time.
18430 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18431 Indexers array is already in the required order. Initialize
18432 'IndexerName' only if there are normal indexers.
18433 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18434 (TypeContainer.Emit): Emit DefaultMember attribute only if
18435 IndexerName is initialized.
18438 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18440 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18443 2004-04-15 Raja R Harinath <rharinath@novell.com>
18445 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18449 * attribute.cs (Attribute.Resolve): Check for duplicate named
18453 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18455 * iterators.cs (MarkYield): track whether we are in an exception,
18456 and generate code accordingly. Use a temporary value to store the
18457 result for our state.
18459 I had ignored a bit the interaction of try/catch with iterators
18460 since their behavior was not entirely obvious, but now it is
18461 possible to verify that our behavior is the same as MS .NET 2.0
18465 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18467 * iterators.cs: Avoid creating temporaries if there is no work to
18470 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18471 Enumerations, use TypeManager.EnumToUnderlying and call
18474 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18477 (This.Emit): Use EmitContext.EmitThis to emit our
18480 (This.EmitAssign): Ditto.
18482 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18483 codepaths, we will move all the functionality into
18486 (FieldExpr.EmitAssign): Ditto.
18488 This fixes several hidden bugs that I uncovered while doing a code
18489 review of this today.
18491 * codegen.cs (EmitThis): reworked so the semantics are more clear
18492 and also support value types "this" instances.
18494 * iterators.cs: Changed so that for iterators in value types, we
18495 do not pass the value type as a parameter.
18497 Initialization of the enumerator helpers is now done in the caller
18498 instead of passing the parameters to the constructors and having
18499 the constructor set the fields.
18501 The fields have now `assembly' visibility instead of private.
18503 2004-04-11 Miguel de Icaza <miguel@ximian.com>
18505 * expression.cs (Argument.Resolve): Check if fields passed as ref
18506 or out are contained in a MarshalByRefObject.
18508 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
18509 another compiler type.
18511 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
18513 * class.cs (Indexer.Define): use the new name checking method.
18514 Also, return false on an error.
18515 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
18516 (is_identifier_[start/part]_character): make static.
18518 2004-04-10 Miguel de Icaza <miguel@ximian.com>
18520 * expression.cs (Binary.ResolveOperator): Do no append strings
18521 twice: since we can be invoked more than once (array evaluation)
18522 on the same concatenation, take care of this here. Based on a fix
18523 from Ben (bug #56454)
18525 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
18527 * codegen.cs: Fix another case where CS1548 must be reported (when
18528 delay-sign isn't specified and no private is available #56564). Fix
18529 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
18530 error when MCS is used on the MS runtime and we need to delay-sign
18531 (which seems unsupported by AssemblyBuilder - see #56621).
18533 2004-04-08 Marek Safar <marek.safar@seznam.cz>
18535 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
18536 (TypeManager.ComputeNamespaces): Faster implementation for
18539 * compiler.csproj: Updated AssemblyName to mcs.
18541 2004-04-07 Miguel de Icaza <miguel@ximian.com>
18543 * rootcontext.cs: Add new types to the boot resolution.
18545 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
18546 MulticastDelegate is not allowed.
18548 * typemanager.cs: Add new types to lookup: System.TypedReference
18551 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
18552 check for TypedReference or ArgIterator, they are not allowed.
18554 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
18555 makes us properly catch 1510 in some conditions (see bug 56016 for
18558 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
18560 * CryptoConvert.cs: update from corlib version
18563 2004-04-05 Miguel de Icaza <miguel@ximian.com>
18565 * class.cs (Indexer.Define): Check indexername declaration
18567 2004-04-05 Marek Safar <marek.safar@seznam.cz>
18569 * attribute.cs (IsClsCompliant): Fixed problem with handling
18570 all three states (compliant, not-compliant, undetected).
18572 2004-03-30 Marek Safar <marek.safar@seznam.cz>
18574 * attribute.cs (Attribute): Location is now public.
18575 (Resolve): Store resolved arguments (pos_values) in attribute class.
18576 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
18577 (GetClsCompliantAttributeValue): New method that gets
18578 CLSCompliantAttribute value.
18579 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
18580 if exists else null.
18581 (AttributeTester): New class for CLS-Compliant verification routines.
18583 * class.cs (Emit): Add CLS-Compliant verification.
18584 (Method.GetSignatureForError): Implemented.
18585 (Constructor.GetSignatureForError): Implemented
18586 (Constructor.HasCompliantArgs): Returns if constructor has
18587 CLS-Compliant arguments.
18588 (Constructor.Emit): Override.
18589 (Construcor.IsIdentifierClsCompliant): New method; For constructors
18590 is needed to test only parameters.
18591 (FieldBase.GetSignatureForError): Implemented.
18592 (TypeContainer): New member for storing base interfaces.
18593 (TypeContainer.FindMembers): Search in base interfaces too.
18595 * codegen.cs (GetClsComplianceAttribute): New method that gets
18596 assembly or module CLSCompliantAttribute value.
18597 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
18599 (ModuleClass.Emit): Add error 3012 test.
18601 * const.cs (Emit): Override and call base for CLS-Compliant tests.
18603 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
18604 state for all decl types.
18605 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
18606 if CLS-Compliant tests are required.
18607 (IsClsCompliaceRequired): New method. Analyze whether code
18608 must be CLS-Compliant.
18609 (IsExposedFromAssembly): New method. Returns true when MemberCore
18610 is exposed from assembly.
18611 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
18612 value or gets cached value.
18613 (HasClsCompliantAttribute): New method. Returns true if MemberCore
18614 is explicitly marked with CLSCompliantAttribute.
18615 (IsIdentifierClsCompliant): New abstract method. This method is
18616 used to testing error 3005.
18617 (IsIdentifierAndParamClsCompliant): New method. Common helper method
18618 for identifier and parameters CLS-Compliant testing.
18619 (VerifyClsCompliance): New method. The main virtual method for
18620 CLS-Compliant verifications.
18621 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
18622 null. I don't know why is null (too many public members !).
18623 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
18624 and get value of first CLSCompliantAttribute that found.
18626 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
18627 (VerifyClsCompliance): Override and add extra tests.
18629 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
18630 clscheck- disable CLS-Compliant verification event if assembly is has
18631 CLSCompliantAttribute(true).
18633 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
18634 ApllyAttribute is now called in emit section as in the other cases.
18635 Possible future Emit integration.
18636 (IsIdentifierClsCompliant): New override.
18637 (VerifyClsCompliance): New override.
18638 (GetEnumeratorName): Returns full enum name.
18640 * parameter.cs (GetSignatureForError): Implemented.
18642 * report.cs (WarningData): New struct for Warning message information.
18643 (LocationOfPreviousError): New method.
18644 (Warning): New method. Reports warning based on the warning table.
18645 (Error_T): New method. Reports error based on the error table.
18647 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
18648 verifications are done here.
18650 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
18652 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
18653 CLSCompliantAttribute.
18654 (all_imported_types): New member holds all imported types from other
18656 (LoadAllImportedTypes): New method fills static table with exported types
18657 from all referenced assemblies.
18658 (Modules): New property returns all assembly modules.
18660 2004-03-30 Miguel de Icaza <miguel@ximian.com>
18662 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
18663 throwing a parser error.
18665 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
18666 which removes the hardcoded get_/set_ prefixes for properties, as
18667 IL allows for the properties to be named something else.
18671 * expression.cs: Do not override operand before we know if it is
18672 non-null. Fix 56207
18674 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18676 * typemanager.cs: support for pinned variables.
18678 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18680 * decl.cs, typemanager.cs: Avoid using an arraylist
18681 as a buffer if there is only one result set.
18683 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18685 * expression.cs: Make sure you cant call a static method
18686 with an instance expression, bug #56174.
18688 2004-03-29 Miguel de Icaza <miguel@ximian.com>
18690 * class.cs (IsDuplicateImplementation): Improve error reporting to
18691 flag 663 (method only differs in parameter modifier).
18693 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
18694 in preprocessor directives.
18696 * location.cs (LookupFile): Allow for the empty path.
18698 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
18699 better approach for some of that patch, but its failing with the
18700 CharSet enumeration. For now try/catch will do.
18702 * typemanager.cs: Do not crash if a struct does not have fields.
18705 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18707 * expression.cs: cs0213, cant fix a fixed expression.
18710 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18712 * cs-parser.jay: detect invalid embeded statements gracefully.
18715 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18717 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
18720 the invocation type may not be a subclass of the tye of the item/
18721 The type of the item must be a subclass of the invocation item.
18726 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
18728 * attribute.cs: Added methods to get a string and a bool from an
18729 attribute. Required to information from AssemblyKeyFileAttribute,
18730 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
18731 * codegen.cs: Modified AssemblyName creation to include support for
18732 strongnames. Catch additional exceptions to report them as CS1548.
18733 * compiler.csproj: Updated include CryptoConvert.cs.
18734 * compiler.csproj.user: Removed file - user specific configuration.
18735 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
18736 Mono.Security assembly. The original class is maintained and tested in
18737 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
18738 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
18739 like CSC 8.0 (C# v2) supports.
18740 * Makefile: Added CryptoConvert.cs to mcs sources.
18741 * rootcontext.cs: Added new options for strongnames.
18743 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
18745 * driver.cs: For --expect-error, report error code `2'
18746 if the program compiled with no errors, error code `1' if
18747 it compiled with an error other than the one expected.
18749 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
18751 * compiler.csproj: Updated for Visual Studio .NET 2003.
18752 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
18753 * compiler.sln: Updated for Visual Studio .NET 2003.
18755 2004-03-24 Ravi Pratap M <ravi@ximian.com>
18757 * expression.cs: Fix bug #47234. We basically need to apply the
18758 rule that we prefer the conversion of null to a reference type
18759 when faced with a conversion to 'object' (csc behaviour).
18761 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18763 * statement.cs: Shorter form for foreach, eliminates
18764 a local variable. r=Martin.
18766 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18768 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
18769 checks if we can use brtrue/brfalse to test for 0.
18770 * expression.cs: use the above in the test for using brtrue/brfalse.
18771 cleanup code a bit.
18773 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18775 * expression.cs: Rewrite string concat stuff. Benefits:
18777 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
18778 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
18779 rather than a concat chain.
18781 * typemanager.cs: Add lookups for more concat overloads.
18783 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18785 * expression.cs: Emit shorter il code for array init.
18802 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
18804 * statement.cs: Before, two switch blocks would be merged if the
18805 total size of the blocks (end_item - begin_item + 1) was less than
18806 two times the combined sizes of the blocks.
18808 Now, it will only merge if after the merge at least half of the
18813 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
18815 * class.cs : csc build fix for GetMethods(). See bug #52503.
18817 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
18819 * expression.cs: Make sure fp comparisons work with NaN.
18820 This fixes bug #54303. Mig approved this patch a long
18821 time ago, but we were not able to test b/c the runtime
18824 2004-03-19 Miguel de Icaza <miguel@ximian.com>
18826 * ecore.cs (TypExpr.GetHashCode): implement this overload.
18828 2004-03-19 Martin Baulig <martin@ximian.com>
18830 * class.cs (MemberCore.IsDuplicateImplementation): Report the
18831 error here and not in our caller.
18833 2004-03-19 Martin Baulig <martin@ximian.com>
18835 * interface.cs: Completely killed this file.
18836 (Interface): We're now a TypeContainer and live in class.cs.
18838 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
18839 argument; we're now also called for interfaces.
18840 (TypeContainer.DefineMembers): Allow this method being called
18842 (TypeContainer.GetMethods): New public method; formerly known as
18843 Interface.GetMethod(). This is used by PendingImplementation.
18844 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
18845 it's now private and non-static.
18846 (Interface): Moved this here; it's now implemented similar to
18848 (Method, Property, Event, Indexer): Added `bool is_interface'
18849 argument to their .ctor's.
18850 (MemberBase.IsInterface): New public field.
18852 * cs-parser.jay: Create normal Method, Property, Event, Indexer
18853 instances instead of InterfaceMethod, InterfaceProperty, etc.
18854 (opt_interface_base): Removed; we now use `opt_class_base' instead.
18855 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
18857 2004-03-19 Martin Baulig <martin@ximian.com>
18859 * class.cs (MethodCore.IsDuplicateImplementation): New private
18860 method which does the CS0111 checking.
18861 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
18862 Use IsDuplicateImplementation().
18864 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
18866 * decl.cs (FindMemberToOverride): New method to find the correct
18867 method or property to override in the base class.
18869 - Make Method/Property use the above method to find the
18870 version in the base class.
18871 - Remove the InheritableMemberSignatureCompare as it is now
18874 This patch makes large code bases much faster to compile, as it is
18875 O(n) rather than O(n^2) to do this validation.
18877 Also, it fixes bug 52458 which is that nested classes are not
18878 taken into account when finding the base class member.
18880 Reviewed/Approved by Martin.
18882 2004-03-17 Marek Safar <marek.safar@seznam.cz>
18884 * interface.cs: In all interface classes removed redundant
18885 member initialization.
18887 2004-03-16 Martin Baulig <martin@ximian.com>
18889 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
18891 2004-03-15 Miguel de Icaza <miguel@ximian.com>
18893 * decl.cs (DefineTypeAndParents): New helper method to define a
18894 type's containers before the type itself is defined; This is a
18895 bug exposed by the recent changes to Windows.Forms when an
18896 implemented interface was defined inside a class that had not been
18899 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
18901 (Check): Loop correctly to report errors modifiers
18902 (UNSAFE was not in the loop, since it was the same as TOP).
18904 * interface.cs: Every interface member now takes a ModFlags,
18905 instead of a "is_new" bool, which we set on the base MemberCore.
18907 Every place where we called "UnsafeOk" in the interface, now we
18908 call the proper member (InterfaceMethod.UnsafeOK) instead to get
18909 the unsafe settings from the member declaration instead of the
18910 container interface.
18912 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
18914 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
18915 `set_indexer_name' to the pending bits (one per type).
18917 We fixed a bug today that was picking the wrong method to
18918 override, since for properties the existing InterfaceMethod code
18919 basically ignored the method name. Now we make sure that the
18920 method name is one of the valid indexer names.
18922 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
18924 * support.cs (SeekableStreamReader): Keep track of stream byte
18925 positions and don't mix them with character offsets to the buffer.
18927 Patch from Gustavo Giráldez
18929 2004-03-15 Marek Safar <marek.safar@seznam.cz>
18931 * interface.cs (InterfaceSetGetBase): Removed double member
18932 initialization, base class does it as well.
18934 2004-03-13 Martin Baulig <martin@ximian.com>
18936 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
18937 when compiling corlib.
18939 2004-03-13 Miguel de Icaza <miguel@ximian.com>
18941 * convert.cs (ExplicitConversion): We were reporting an error on
18942 certain conversions (object_type source to a value type, when the
18943 expression was `null') before we had a chance to pass it through
18944 the user defined conversions.
18946 * driver.cs: Replace / and \ in resource specifications to dots.
18949 * class.cs: Add check for duplicate operators. Fixes 52477
18951 2004-03-11 Miguel de Icaza <miguel@ximian.com>
18953 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
18954 that are in the middle of the statements, not only at the end.
18957 * class.cs (TypeContainer.AddField): No longer set the
18958 `HaveStaticConstructor' flag, now we call it
18959 `UserDefineStaticConstructor' to diferentiate the slightly
18960 semantic difference.
18962 The situation is that we were not adding BeforeFieldInit (from
18963 Modifiers.TypeAttr) to classes that could have it.
18964 BeforeFieldInit should be set to classes that have no static
18969 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
18971 And most importantly Zoltan's comment:
18973 http://bugzilla.ximian.com/show_bug.cgi?id=44229
18975 "I think beforefieldinit means 'it's ok to initialize the type sometime
18976 before its static fields are used', i.e. initialization does not need
18977 to be triggered by the first access to the type. Setting this flag
18978 helps the JIT to compile better code, since it can run the static
18979 constructor at JIT time, and does not need to generate code to call it
18980 (possibly lots of times) at runtime. Unfortunately, mcs does not set
18981 this flag for lots of classes like String.
18983 csc sets this flag if the type does not have an explicit static
18984 constructor. The reasoning seems to be that if there are only static
18985 initalizers for a type, and no static constructor, then the programmer
18986 does not care when this initialization happens, so beforefieldinit
18989 This bug prevents the AOT compiler from being usable, since it
18990 generates so many calls to mono_runtime_class_init that the AOT code
18991 is much slower than the JITted code. The JITted code is faster,
18992 because it does not generate these calls if the vtable is type is
18993 already initialized, which is true in the majority of cases. But the
18994 AOT compiler can't do this."
18996 2004-03-10 Miguel de Icaza <miguel@ximian.com>
18998 * class.cs (MethodData.Emit): Refactor the code so symbolic
18999 information is generated for destructors; For some reasons we
19000 were taking a code path that did not generate symbolic information
19003 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19005 * class.cs: Create a Constructor.CheckBase method that
19006 takes care of all validation type code. The method
19007 contains some code that was moved from Define.
19009 It also includes new code that checks for duplicate ctors.
19010 This fixes bug #55148.
19012 2004-03-09 Joshua Tauberer <tauberer@for.net>
19014 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19015 a { ... }-style array creation invokes EmitStaticInitializers
19016 which is not good for reference-type arrays. String, decimal
19017 and now null constants (NullCast) are not counted toward
19018 static initializers.
19020 2004-03-05 Martin Baulig <martin@ximian.com>
19022 * location.cs (SourceFile.HasLineDirective): New public field;
19023 specifies whether the file contains or is referenced by a "#line"
19025 (Location.DefineSymbolDocuments): Ignore source files which
19026 either contain or are referenced by a "#line" directive.
19028 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19030 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19031 direct access to our parent, so check the method inline there.
19033 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19035 * expression.cs (Invocation.EmitCall): Miguel's last commit
19036 caused a regression. If you had:
19041 In Foo the implict this would be null.
19043 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19045 * expression.cs (Invocation.EmitCall): If the method is not
19046 virtual, do not emit a CallVirt to it, use Call.
19048 * typemanager.cs (GetFullNameSignature): Improve the method to
19049 cope with ".ctor" and replace it with the type name.
19051 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19052 as an argument the ConstructorBuilder where it is being defined,
19053 to catch the recursive constructor invocations.
19055 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19057 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19058 routines to check if a type is an enumerable/enumerator allow
19059 classes that implement the IEnumerable or IEnumerator interfaces.
19061 * class.cs (Property, Operator): Implement IIteratorContainer, and
19062 implement SetYields.
19064 (Property.Define): Do the block swapping for get_methods in the
19065 context of iterators. We need to check if Properties also
19066 include indexers or not.
19068 (Operator): Assign the Block before invoking the
19069 OperatorMethod.Define, so we can trigger the Iterator code
19072 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19073 Property and Operator classes are not created when we parse the
19074 declarator but until we have the block completed, so we use a
19075 singleton SimpleIteratorContainer.Simple to flag whether the
19076 SetYields has been invoked.
19078 We propagate this setting then to the Property or the Operator to
19079 allow the `yield' to function.
19081 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19083 * codegen.cs: Implemented attribute support for modules.
19084 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19085 Assembly/Module functionality.
19087 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19088 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19089 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19091 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19093 * interface.cs (FindMembers): The operation is performed on all base
19094 interfaces and not only on the first. It is required for future CLS Compliance patch.
19096 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19098 * statement.cs, codegen.cs:
19099 This patch deals with patterns such as:
19101 public class List : IEnumerable {
19103 public MyEnumerator GetEnumerator () {
19104 return new MyEnumerator(this);
19107 IEnumerator IEnumerable.GetEnumerator () {
19111 public struct MyEnumerator : IEnumerator {
19116 Before, there were a few things we did wrong:
19117 1) we would emit callvirt on a struct, which is illegal
19118 2) we emited ldarg when we needed to emit ldarga
19119 3) we would mistakenly call the interface methods on an enumerator
19120 type that derived from IEnumerator and was in another assembly. For example:
19122 public class MyEnumerator : IEnumerator
19124 Would have the interface methods called, even if there were public impls of the
19125 method. In a struct, this lead to invalid IL code.
19127 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19129 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19132 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19134 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19136 * cs-parser.jay: Fix small regression: we were not testing V2
19137 compiler features correctly.
19139 * interface.cs: If the emit context is null, then create one
19141 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19143 * decl.cs (GetSignatureForError): New virtual method to get full name
19144 for error messages.
19146 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19147 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19149 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19150 Duplicated members and code in these classes has been removed.
19151 Better encapsulation in these classes.
19153 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19155 * assign.cs (Assign.DoResolve): When dealing with compound
19156 assignments, there is a new rule in ECMA C# 2.4 (might have been
19157 there before, but it is documented here) that states that in:
19161 If b is of type int, and the `op' is a shift-operator, then the
19162 above is evaluated as:
19166 * expression.cs (Binary.ResolveOperator): Instead of testing for
19167 int/uint/long/ulong, try to implicitly convert to any of those
19168 types and use that in pointer arithmetic.
19170 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19171 method to print information for from the type, not from the
19172 null-method we were given.
19174 2004-02-01 Duncan Mak <duncan@ximian.com>
19176 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19177 parsing for cmd, fixes bug #53694.
19179 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19181 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19182 in the member name duplication tests. Property and operator name duplication
19183 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19185 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19187 * interface.cs (PopulateMethod): Fixed crash when interface method
19188 returns not existing type (error test cs0246-3.cs).
19190 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19192 * cs-parser.jay (interface_accessors): Re-write actions to also
19193 store attributes attached to get and set methods. Fix spelling
19196 (inteface_property_declaration): Modify accordingly.
19198 (InterfaceAccessorInfo): New helper class to store information to pass
19199 around between rules that use interface_accessors.
19201 * interface.cs (Emit): Apply attributes on the get and set
19202 accessors of properties and indexers too.
19204 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19205 right MethodBuilder when applying attributes to the get and set accessors.
19207 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19209 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19211 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19213 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19215 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19217 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19218 changes that treat `yield' specially when present before `break'
19219 or `return' tokens.
19221 * cs-tokenizer.cs: yield is no longer a keyword.
19223 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19225 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19226 setting for default constructors.
19227 For default constructors are almost every time set wrong Modifier. The
19228 generated IL code has been alright. But inside mcs this values was
19229 wrong and this was reason why several of my CLS Compliance tests
19232 2004-01-22 Martin Baulig <martin@ximian.com>
19234 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19235 not a QualifiedIdentifier. This is what `type_name_expression'
19236 was previously doing.
19237 (type_name_expression): Removed; the code is now in
19238 `namespace_or_type_name'.
19239 (qualified_identifier): Removed, use `namespace_or_type_name'
19241 (QualifiedIdentifier): Removed this class.
19243 2004-01-22 Martin Baulig <martin@ximian.com>
19245 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19246 not a string as alias name.
19248 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19250 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19251 #52730 bug, and instead compute correctly the need to use a
19252 temporary variable when requesting an address based on the
19253 static/instace modified of the field and the constructor.
19255 2004-01-21 Martin Baulig <martin@ximian.com>
19257 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19258 class and namespace before looking up aliases. Fixes #52517.
19260 2004-01-21 Martin Baulig <martin@ximian.com>
19262 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19263 assinged in a 'try'; fixes exception4.cs.
19265 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19266 * class.cs : Implemented parameter-less constructor for TypeContainer
19268 * decl.cs: Attributes are now stored here. New property OptAttributes
19270 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19272 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19274 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19276 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19277 (CSharpSignature): New method for indexer and property signature.
19279 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19281 * pending.cs (IsVirtualFilter): Faster implementation.
19283 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19285 * typemanager.cs: Avoid inclusion of same assembly more than once.
19287 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19289 * cs-parser.jay: Fixed problem where the last assembly attribute
19290 has been applied also to following declaration (class, struct, etc.)
19292 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19294 * class.cs: Added error CS0538, CS0539 reporting.
19295 Fixed crash on Microsoft runtime when field type is void.
19297 * cs-parser.jay: Added error CS0537 reporting.
19299 * pending.cs: Added error CS0535 reporting.
19300 Improved error report for errors CS0536, CS0534.
19302 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19304 Merge a few bits from the Anonymous Method MCS tree.
19306 * statement.cs (ToplevelBlock): New class for toplevel methods,
19307 will hold anonymous methods, lifted variables.
19309 * cs-parser.jay: Create toplevel blocks for delegates and for
19310 regular blocks of code.
19312 2004-01-20 Martin Baulig <martin@ximian.com>
19314 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19315 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19316 and `NeedExplicitReturn'; added `IsLastStatement'.
19317 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19318 have a `ReturnLabel' or we're not unreachable.
19320 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19321 child's reachability; don't just override ours with it. Fixes
19322 #58058 (lluis's example).
19323 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19324 InFinally(), InLoop(), InSwitch() and
19325 BreakCrossesTryCatchBoundary() methods.
19327 * statement.cs (Return): Do all error checking in Resolve().
19328 Unless we are the last statement in a top-level block, always
19329 create a return label and jump to it.
19330 (Break, Continue): Do all error checking in Resolve(); also make
19331 sure we aren't leaving a `finally'.
19332 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19333 statement in a top-level block.
19334 (Block.Flags): Added `IsDestructor'.
19335 (Block.IsDestructor): New public property.
19337 2004-01-20 Martin Baulig <martin@ximian.com>
19339 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19341 2004-01-20 Martin Baulig <martin@ximian.com>
19343 * statement.cs (Statement.ResolveUnreachable): New public method.
19344 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19345 (Block.Resolve): Resolve unreachable statements.
19347 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19349 * expression.cs: We need to fix the case where we do
19350 not have a temp variable here.
19352 * assign.cs: Only expression compound assignments need
19353 temporary variables.
19355 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19357 * flowanalysis.cs: Reduce memory allocation in a few ways:
19358 - A block with no variables should not allocate a bit
19360 - A method with no out parameters does not need any tracking
19361 for assignment of the parameters, so we need not allocate
19364 public readonly Type[] VariableTypes;
19365 public readonly string[] VariableNames;
19366 Are redundant. The data is already stored in the variable
19367 map, so we need not allocate another array for it.
19368 - We need to add alot of checks for if (params | locals) == null
19369 due to the first two changes.
19371 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19373 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19374 implement IMemoryLocation, we store a copy on a local variable and
19375 take the address of it. Patch from Benjamin Jemlich
19377 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19378 to use a special "type_name_expression" rule which reduces the
19379 number of "QualifiedIdentifier" classes created, and instead
19380 directly creates MemberAccess expressions.
19382 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19384 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19385 that fixes #52853. Null literal assignment to ValueType
19387 * class.cs (MethodData.Emit): Instead of checking the name of the
19388 method to determine if its a destructor, create a new derived
19389 class from Method called Destructor, and test for that.
19391 * cs-parser.jay: Create a Destructor object instead of a Method.
19393 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19397 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19399 * expression.cs (Binary.ResolveOperator): Perform an implicit
19400 conversion from MethodGroups to their delegate types on the
19401 Addition operation.
19403 * delegate.cs: Introduce a new class DelegateCreation that is the
19404 base class for `NewDelegate' and `ImplicitDelegateCreation',
19405 factor some code in here.
19407 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19408 conversion from MethodGroups to compatible delegate types.
19410 * ecore.cs (Expression.Resolve): Do not flag error 654
19411 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19412 we allow conversions from MethodGroups to delegate types now.
19414 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19415 assignments in v2 either.
19417 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19419 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19420 static read-only fields in ctors.
19422 Applied patch from Benjamin Jemlich
19424 * expression.cs (UnaryMutator): Avoid leaking local variables.
19426 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19428 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19429 here to return true, as they can be used like this:
19431 (XXX) int.MEMBER ()
19433 Fixed 49836 and all the other dups
19435 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19437 * driver.cs: Implement /win32res and /win32icon.
19439 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19441 * cs-parser.jay: Add a rule to improve error handling for the
19442 common mistake of placing modifiers after the type.
19444 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19446 * cs-parser.jay (interface_event_declaration): Catch
19447 initialization of events on interfaces, and report cs0068
19449 * cs-parser.jay (interface_event_declaration): Catch
19450 initialization of events.
19452 * ecore.cs: Better report missing constructors.
19454 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19455 the error reporting done in the wrong place. Fix.
19457 * expression.cs (Binary.ResolveOperator): Catch the
19458 operator + (E x, E y) error earlier, and later allow for implicit
19459 conversions in operator +/- (E e, U x) from U to the underlying
19462 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19463 52596, if the container class is abstract, the default constructor
19464 is protected otherwise its public (before, we were always public).
19466 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19469 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19470 Jemlich that fixes bug #52597, MCS was generating invalid code for
19471 idisposable structs. Thanks to Ben for following up with this
19474 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19476 * driver.cs: Allow assemblies without code to be generated, fixes
19479 2004-01-07 Nick Drochak <ndrochak@gol.com>
19481 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19483 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19485 * cs-parser.jay: Add rules to improve error reporting if fields or
19486 methods are declared at the namespace level (error 116)
19488 * Add rules to catch event add/remove
19490 2004-01-04 David Sheldon <dave-mono@earth.li>
19492 * expression.cs: Added matching ")" to error message for
19495 2004-01-03 Todd Berman <tberman@gentoo.org>
19497 * ecore.cs, attribute.cs:
19498 Applying fix from #52429.
19500 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19502 * ecore.cs, expression.cs, statement.cs:
19503 Total rewrite of how we handle branching. We
19504 now handle complex boolean expressions with fewer
19505 jumps. As well if (x == 0) no longer emits a ceq.
19507 if (x is Foo) is much faster now, because we generate
19510 Overall, we get a pretty big improvement on our benchmark
19511 tests. The code we generate is smaller and more readable.
19513 I did a full two-stage bootstrap. The patch was reviewed
19514 by Martin and Miguel.
19516 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19518 * cs-parser.jay: Make primary_expression not take a QI.
19519 we dont need this because the member_access rule covers
19520 us here. So we replace the rule with just IDENTIFIER.
19522 This has two good effects. First, we remove a s/r conflict.
19523 Second, we allocate many fewer QualifiedIdentifier objects.
19525 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19527 * attribute.cs: Handle MarshalAs attributes as pseudo, and
19528 set the correct information via SRE. This prevents
19529 hanging on the MS runtime. Fixes #29374.
19531 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19533 * convert.cs: correctly handle conversions to value types
19534 from Enum and ValueType as unboxing conversions.
19536 Fixes bug #52569. Patch by Benjamin Jemlich.
19538 2004-01-02 Ravi Pratap <ravi@ximian.com>
19540 * expression.cs (BetterConversion): Prefer int -> uint
19541 over int -> ulong (csc's behaviour). This fixed bug #52046.
19543 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
19545 * decl.cs (MemberCache.FindMembers): now returns a
19548 * typemanager.cs: In general, go with with ^^.
19549 (CopyNewMethods): take an IList.
19550 (RealMemberLookup): Only allocate an arraylist
19551 if we copy from two sets of methods.
19553 This change basically does two things:
19554 1) Fewer array lists allocated due to CopyNewMethods.
19555 2) the explicit cast in MemberList costed ALOT.
19557 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
19559 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
19560 a hashtable to avoid needless string allocations when an identifier is
19561 used more than once (the common case).
19563 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19565 * pending.cs: MS's TypeBuilder.GetInterfaces ()
19566 is broken, it will not return anything. So, we
19567 have to use the information we have in mcs to
19570 * typemanager.cs: Add a cache for GetInterfaces,
19571 since this will now be used more often (due to ^^)
19573 (GetExplicitInterfaces) New method that gets the
19574 declared, not effective, interfaces on a type
19575 builder (eg, if you have interface IFoo, interface
19576 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
19579 This patch makes MCS able to bootstrap itself on
19582 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19584 * expression.cs: Remove the Nop's that Miguel put
19587 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19589 * report.cs, codegen.cs: Give the real stack trace to
19590 the error when an exception is thrown.
19592 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19594 * decl.cs: only allocate hashtables for ifaces if
19597 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19599 * expression.cs: fix the error from cs0121-2.cs
19600 (a parent interface has two child interfaces that
19601 have a function with the same name and 0 params
19602 and the function is called through the parent).
19604 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
19606 * class.cs, rootcontext.cs, typmanager.cs: do not
19609 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
19611 * codegen.cs: remove stack for the ec flow branching.
19612 It is already a linked list, so no need.
19614 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
19616 * Makefile: Allow custom profiler here.
19618 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19620 * typemanager.cs (LookupType):
19621 - Use a static char [], because split takes
19622 a param array for args, so it was allocating
19624 - Do not store true in a hashtable, it boxes.
19626 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19628 * flowanalysis.cs: bytify common enums.
19630 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19632 * modifiers.cs: Add a new set of flags for the
19633 flags allowed on explicit interface impls.
19634 * cs-parser.jay: catch the use of modifiers in
19635 interfaces correctly.
19636 * class.cs: catch private void IFoo.Blah ().
19638 All related to bug #50572.
19640 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19642 * decl.cs: Rewrite the consistant accessability checking.
19643 Accessability is not linear, it must be implemented in
19644 a tableish way. Fixes #49704.
19646 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19648 * expression.cs: Handle negation in a checked context.
19649 We must use subtraction from zero. Fixes #38674.
19651 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19653 * class.cs: Ignore static void main in DLLs.
19654 * rootcontext.cs: Handle the target type here,
19655 since we are have to access it from class.cs
19656 * driver.cs: account for the above.
19658 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19660 * report.cs: Give line numbers and files if available.
19662 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
19664 * driver.cs: Implement /addmodule.
19666 * typemanager.cs: Change 'modules' field so it now contains Modules not
19669 2003-12-20 Martin Baulig <martin@ximian.com>
19671 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
19672 (FieldBase.IsAssigned): Removed this field.
19673 (FieldBase.SetAssigned): New public method.
19674 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
19676 2003-12-20 Martin Baulig <martin@ximian.com>
19678 * expression.cs (LocalVariableReference.DoResolve): Don't set
19679 `vi.Used' if we're called from DoResolveLValue().
19681 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
19682 returns the usage vector it just merged into the current one -
19683 pass this one to UsageWarning().
19684 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
19685 of the `EmitContext', don't call this recursively on our children.
19687 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
19689 * driver.cs: Implement /target:module.
19691 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
19693 * support.cs (CharArrayHashtable): New helper class.
19695 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
19696 char arrays, not strings, so we can avoid creating a string in
19697 consume_identifier if the identifier is a keyword.
19699 2003-12-16 Martin Baulig <martin@ximian.com>
19701 * statement.cs (LocalInfo.Assigned): Removed this property.
19702 (LocalInfo.Flags): Removed `Assigned'.
19703 (LocalInfo.IsAssigned): New public method; takes the EmitContext
19704 and uses flow analysis.
19705 (Block.UsageWarning): Made this method private.
19706 (Block.Resolve): Call UsageWarning() if appropriate.
19708 * expression.cs (LocalVariableReference.DoResolve): Always set
19709 LocalInfo.Used here.
19711 2003-12-13 Martin Baulig <martin@ximian.com>
19713 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
19714 any value here; we're now using flow analysis to figure out
19715 whether a statement/block returns a value.
19717 2003-12-13 Martin Baulig <martin@ximian.com>
19719 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
19721 (FlowBranching.MergeFinally): Don't call
19722 `branching.CheckOutParameters()' here, this is called in
19724 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
19725 when adding the `finally' vector.
19727 2003-12-13 Martin Baulig <martin@ximian.com>
19730 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
19731 actually work and also fix #48962.
19733 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
19735 * decl.cs: Do not check System.Object for nested types,
19736 since we know it does not have any. Big bang for buck:
19739 Run 1: 8.35 seconds
19740 Run 2: 8.32 seconds
19741 corlib: 17.99 seconds
19743 Run 1: 8.17 seconds
19744 Run 2: 8.17 seconds
19745 corlib: 17.39 seconds
19747 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
19749 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
19750 time we are returning 0 members, so we save alot here.
19752 2003-12-11 Martin Baulig <martin@ximian.com>
19754 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
19755 `MergeChild()', also just take the `FlowBranching' as argument;
19756 call Merge() on it and return the result.
19757 (FlowBranching.Merge): We don't need to do anything if we just
19760 2003-12-11 Martin Baulig <martin@ximian.com>
19762 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
19763 them in an `ArrayList' to reduce memory usage. Thanks to Ben
19764 Maurer for this idea.
19766 2003-12-11 Martin Baulig <martin@ximian.com>
19768 * flowanalysis.cs (MergeResult): This class is now gone; we now
19769 use the `UsageVector' for this. The reason for this is that if a
19770 branching just has one sibling, we don't need to "merge" them at
19771 all - that's the next step to do.
19772 (FlowBranching.Merge): We now return a `UsageVector' instead of a
19775 2003-12-11 Martin Baulig <martin@ximian.com>
19777 Reworked flow analyis and made it more precise and bug-free. The
19778 most important change is that we're now using a special `Reachability'
19779 class instead of having "magic" meanings of `FlowReturns'. I'll
19780 do some more cleanups and optimizations and also add some more
19781 documentation this week.
19783 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
19784 largely reworked this class.
19785 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
19786 the new `Reachability' class instead of having "magic" values here.
19787 (FlowBranching): We're now using an instance of `Reachability'
19788 instead of having separate `Returns', `Breaks' etc. fields.
19790 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
19791 based on flow analysis; ignore the return value of block.Emit ().
19793 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
19795 * driver.cs typemanager.cs: Find the mono extensions to corlib even
19796 if they are private.
19798 2003-12-09 Martin Baulig <martin@ximian.com>
19800 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
19801 call them directly on the UsageVector.
19803 2003-12-09 Martin Baulig <martin@ximian.com>
19805 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
19806 Changed return type from `FlowReturns' to `Reachability'.
19808 2003-12-09 Martin Baulig <martin@ximian.com>
19810 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
19811 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
19812 `Reachable' fields with a single `Reachability' one.
19814 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19816 * class.cs (FindMembers): Remove foreach's.
19821 Run 1: 8.74 seconds
19822 Run 2: 8.71 seconds
19825 Run 1: 8.64 seconds
19826 Run 2: 8.58 seconds
19829 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19834 This patch does a few things:
19835 1. EmptyStatement is now a singleton, so it is never reallocated.
19836 2. All blah is EmptyStatement constructs have been changed to
19837 blah == EmptyStatement.Value, which is much faster and valid
19838 now that EmptyStatement is a singleton.
19839 3. When resolving a block, rather than allocating a new array for
19840 the non-empty statements, empty statements are replaced with
19841 EmptyStatement.Value
19842 4. Some recursive functions have been made non-recursive.
19843 Mainly the performance impact is from (3), however (1) and (2) are needed for
19844 this to work. (4) does not make a big difference in normal situations, however
19845 it makes the profile look saner.
19850 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
19851 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
19852 Total memory allocated: 56397 KB
19855 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
19856 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
19857 Total memory allocated: 55666 KB
19859 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19861 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
19862 than the hashtable in a hashtable version
19864 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
19865 we always end up concating a string. This results in a huge perf
19866 loss, because many strings have to be tracked by the GC. In this
19867 patch, we first use a hashtable that works with two keys, so that
19868 the strings do not need to be concat'ed.
19872 Run 1: 8.74 seconds
19873 Run 2: 8.71 seconds
19876 Run 1: 8.65 seconds
19877 Run 2: 8.56 seconds
19879 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19881 * Makefile: Add a new target `do-time' that does a quick and simple
19882 profile, leaving easy to parse output.
19884 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
19886 * codegen.cs (Init): Create the dynamic assembly with
19887 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
19889 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
19891 * support.cs: Make the PtrHashtable use only one
19892 instance of its comparer.
19894 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
19896 * typemanager.cs: Fix lookup of GetNamespaces.
19898 2003-11-29 Miguel de Icaza <miguel@ximian.com>
19900 * expression.cs: Removed redundant line.
19902 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
19903 ArrayLists, use for loops with bounds.
19905 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
19908 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
19909 arraylists, use for loop with bounds.
19911 The above three changes give us a 0.071 second performance
19912 improvement out of 3.294 seconds down to 3.223. On my machine
19913 the above changes reduced the memory usage by 1,387 KB during
19914 compiler bootstrap.
19916 * cs-parser.jay (QualifiedIdentifier): New class used to represent
19917 QualifiedIdentifiers. Before we created a new string through
19918 concatenation, and mostly later on, the result would be
19919 manipulated by DecomposeQI through string manipulation.
19921 This reduced the compiler memory usage for bootstrapping from
19922 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
19923 compile times in 0.05 seconds.
19925 2003-11-28 Dick Porter <dick@ximian.com>
19927 * support.cs: Do string compares with the Invariant culture.
19935 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
19936 the comparison is done with the Invariant culture.
19938 2003-11-27 Miguel de Icaza <miguel@ximian.com>
19940 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
19941 GetEnumerator method.
19943 (ProbeCollectionType): Iterate starting at the most specific type
19944 upwards looking for a GetEnumerator
19946 * expression.cs: Shift count can be up to 31 for int/uint and 63
19949 2003-11-26 Miguel de Icaza <miguel@ximian.com>
19951 * statement.cs (Block.LookupLabel): Also look for the label on the
19952 children blocks. Use a hash table to keep track of visited
19955 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
19956 we actually did transform the other operand, otherwise fall back
19957 to the common codepath that casts to long.
19959 * cs-tokenizer.cs: Use the same code pattern as the int case.
19960 Maybe I should do the parsing myself, and avoid depending on the
19961 Parse routines to get this done.
19963 2003-11-25 Miguel de Icaza <miguel@ximian.com>
19965 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
19966 which fixes bug 51347. This time test it.
19968 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
19969 attributes for example can not tell the difference between these.
19970 The difference was only a syntax feature of the language.
19972 * attribute.cs: Apply attributes to delegates.
19974 * delegate.cs: Call the apply attributes method.
19976 2003-11-24 Miguel de Icaza <miguel@ximian.com>
19978 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
19979 comparing 0 vs Byte.MinValue, not the value
19981 (ImplicitConversionRequired): When reporting a conversion error,
19982 use error 31 to print out the constant error instead of the
19985 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
19986 which fixes bug 51347.
19988 2003-11-22 Miguel de Icaza <miguel@ximian.com>
19990 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
19991 which fixes the -warnaserror command line option.
19993 2003-11-21 Miguel de Icaza <miguel@ximian.com>
19995 * cfold.cs (DoNumericPromotions): During constant folding of
19996 additions on UIntConstant, special case intconstants with
19997 IntConstants like we do on the expression binary operator.
19999 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20001 * convert.cs (ImplicitReferenceConversion): We were missing a case
20002 (System.Enum are not value types or class types, so we need to
20003 classify them separatedly).
20005 * driver.cs: We do not support error 2007.
20007 2003-11-12 Jackson Harper <jackson@ximian.com>
20009 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20010 system directory. Also use the full file name so users can
20011 libraries names mscorlib-o-tron.dll in a non system dir.
20013 2003-11-10 Martin Baulig <martin@ximian.com>
20015 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20016 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20017 calling `ResolveType()' on them, directly assign their `Type'.
20019 2003-11-08 Martin Baulig <martin@ximian.com>
20021 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20022 return value and the `out parent' parameter.
20023 (TypeContainer.DefineType): Moved the CS0644 check into
20024 GetClassBases(). Don't pass the interface types to the
20025 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20026 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20028 * ecore.cs (TypeExpr.IsAttribute): New property.
20029 (TypeExpr.GetInterfaces): New method.
20031 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20032 TypeExpr instead of a Type.
20033 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20034 (Interface.DefineType): Don't pass the interface types to the
20035 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20036 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20038 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20039 instead of a `Type[]'.
20040 (TypeManager.RegisterBuilder): Likewise.
20041 (TypeManager.AddUserInterface): Likewise.
20042 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20043 `Type[]' and also return a `TypeExpr[]'.
20044 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20046 2003-11-08 Martin Baulig <martin@ximian.com>
20048 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20051 2003-11-08 Martin Baulig <martin@ximian.com>
20053 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20054 TypeManager.ResolveExpressionTypes().
20056 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20057 instead of an Expression.
20058 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20059 (TypeExpression): New public class; formerly known as `TypeExpr'.
20061 * expression.cs (ComposedCast): Derive from TypeExpr.
20063 * typemanager.cs (TypeManager.system_*_expr): These are now
20064 TypExpr's instead of Expression's.
20065 (TypeManager.ResolveExpressionTypes): New public static function;
20066 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20069 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20071 * expression.cs (New.DoResolve): Do not dereference value that
20072 might be a null return.
20074 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20075 sure that the constant value has the right type. Fixes an
20076 unreported bug, similar to 50425.
20078 * const.cs (Const.LookupConstantValue): Call
20079 ImplicitStandardConversionExists before doing a conversion to
20080 avoid havng the TypeManager.ChangeType do conversions.
20082 Reduced the number of casts used
20084 (Const.ChangeType): New routine to enable reuse of the constant
20085 type changing code from statement.
20087 * typemanager.cs (ChangeType): Move common initialization to
20088 static global variables.
20092 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20093 every value type to go through, even if it was void. Fix that.
20095 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20096 character of the define, and the is_identifier_part_character for
20097 the rest of the string.
20099 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20101 * expression.cs (UnaryMutator.EmitCode): When I updated
20102 LocalVariableReference.DoResolve, I overdid it, and dropped an
20103 optimization done on local variable references.
20105 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20107 * ecore.cs: Convert the return from Ldlen into an int.
20109 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20111 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20112 the accessibility, this is a special case for toplevel non-public
20113 classes (internal for instance).
20115 2003-10-20 Nick Drochak <ndrochak@gol.com>
20117 * ecore.cs: Fix typo and build. Needed another right paren.
20119 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20121 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20122 `internal' case regular and protected, but not allowing protected
20123 to be evaluated later. Bug 49840
20125 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20127 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20128 to kb.Nlast, and not the kb.nFirst to isolate the switch
20131 Extract the underlying type, so enumerations of long/ulong are
20132 treated like long/ulong.
20134 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20136 * expression.cs (New): Overload the meaning of RequestedType to
20137 track the possible creation of the NewDelegate type, since
20138 DoResolve is invoked more than once for new constructors on field
20141 See bugs: #48800 and #37014
20143 * cs-parser.jay (declare_local_constants): Take an arraylist
20144 instead of a single constant.
20146 (local_constant_declaration): It should take a
20147 constant_declarators, not a constant_declarator. Fixes 49487
20149 * convert.cs: Fix error report.
20151 2003-10-13 Jackson Harper <jackson@ximian.com>
20153 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20156 2003-10-09 Martin Baulig <martin@ximian.com>
20158 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20160 (MethodCore.DoDefineParameters): Removed the TypeContainer
20161 argument; use the DeclSpace which was passed to the .ctor instead.
20162 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20163 TypeContainer; we only need a DeclSpace here.
20165 2003-10-09 Martin Baulig <martin@ximian.com>
20167 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20169 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20170 EmitContext's .ctor.
20172 2003-10-09 Martin Baulig <martin@ximian.com>
20174 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20175 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20176 AsAccessible(), moved them as well.
20178 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20180 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20182 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20184 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20186 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20187 generation for >=, as spotted by Paolo, bug 48679.
20188 Patch from David Waite.
20190 * cs-tokenizer.cs: Add handling for #pragma.
20192 * cs-parser.jay: Allow for both yield and yield return in the
20193 syntax. The anti-cobolization of C# fight will go on!
20195 * class.cs (TypeBuilder.DefineType): Catch error condition here
20196 (Parent.DefineType erroring out and returning null).
20198 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20199 coping with enumerations variables, we were mistakenly processing
20200 them as a regular value type instead of built-in types. Fixes the
20203 * typemanager.cs (IsBuiltinOrEnum): New method.
20205 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20207 * cs-parser.jay: Upgrade: yield now needs the return clause.
20209 2003-09-19 Martin Baulig <martin@ximian.com>
20211 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20212 `MemberCache parent' argument. Normally, an interface doesn't
20213 have a parent type except System.Object, but we use this in gmcs
20214 for generic type parameters.
20216 2003-09-18 Martin Baulig <martin@ximian.com>
20218 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20219 on `type.IsInterface'; don't check whether the type has a parent
20220 to determine whether it's an interface.
20222 2003-09-15 Martin Baulig <martin@ximian.com>
20224 * class.cs (TypeContainer.DefineType): Added an error flag to
20225 avoid reporting duplicate CS0146's ("class definition is
20228 * driver.cs (Driver.MainDriver): Abort if
20229 RootContext.ResolveTree() reported any errors.
20231 2003-09-07 Martin Baulig <martin@ximian.com>
20233 * report.cs (Error, Warning): Added overloaded versions which take
20234 a `params object[] args' and call String.Format().
20236 2003-09-07 Martin Baulig <martin@ximian.com>
20238 * decl.cs (DeclSpace..ctor): Don't call
20239 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20240 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20241 (DeclSpace.RecordDecl): New method.
20243 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20245 2003-09-02 Ravi Pratap <ravi@ximian.com>
20247 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20248 value attributes to be applied to ParameterBuilders.
20250 * class.cs (MethodCore.LabelParameters): Make static and more
20251 generic so that it can be used from other places - like interface
20252 methods, for instance.
20254 * interface.cs (Interface.Emit): Call LabelParameters before
20255 emitting attributes on the InterfaceMethod.
20257 2003-08-26 Martin Baulig <martin@ximian.com>
20259 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20260 resolving aliases; fixes #47927.
20262 2003-08-26 Martin Baulig <martin@ximian.com>
20264 * statement.cs (Using.DoResolve): This is internally emitting a
20265 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20266 do not always return. Fixes #47681.
20268 2003-08-26 Martin Baulig <martin@ximian.com>
20270 * decl.cs (MemberCore): Moved WarningNotHiding(),
20271 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20273 (AdditionResult): Make this nested in DeclSpace.
20274 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20275 argument; call NamespaceEntry.Define() unless we're nested in a
20278 * namespace.cs (Namespace.DefineName): New public function. This
20279 is called from DeclSpace's .ctor to add
20280 (Namespace.Lookup): Include DeclSpaces in the lookup.
20282 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20284 * const.cs (Const): Derive from MemberBase, not MemberCore.
20286 2003-08-25 Martin Baulig <martin@ximian.com>
20288 * convert.cs (Convert.ExplicitReferenceConversion): When
20289 converting from an interface type to a class, unbox if the target
20290 type is a struct type. Fixes #47822.
20292 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20294 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20297 2003-08-22 Martin Baulig <martin@ximian.com>
20299 * class.cs (TypeManager.DefineType): When defining a nested type,
20300 call DefineType() on our parent; fixes #47801.
20302 2003-08-22 Martin Baulig <martin@ximian.com>
20304 * class.cs (MethodData.Define): While checking if a method is an
20305 interface implementation, improve the test a bit more to fix #47654.
20307 2003-08-22 Martin Baulig <martin@ximian.com>
20309 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20310 correctly; fixes #47722.
20312 2003-08-22 Martin Baulig <martin@ximian.com>
20314 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20315 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20317 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20319 2003-08-22 Martin Baulig <martin@ximian.com>
20321 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20322 can only be assigned in static constructors. Fixes #47161.
20324 2003-08-22 Martin Baulig <martin@ximian.com>
20326 Rewrote and improved the flow analysis code.
20328 * flowbranching.cs (FlowBranching): Make this class abstract.
20329 (FlowBranching.CreateBranching): New static function to create a
20330 new flow branching.
20331 (FlowBranchingBlock, FlowBranchingException): New classes.
20332 (FlowBranching.UsageVector.Type): New public readonly field.
20333 (FlowBranching.UsageVector.Breaks): Removed the setter.
20334 (FlowBranching.UsageVector.Returns): Removed the setter.
20335 (FlowBranching.UsageVector): Added Break(), Return(),
20336 NeverReachable() and Throw() methods to modify the reachability.
20337 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20338 done by FlowBranching.Merge().
20339 (FlowBranching.UsageVector.MergeChild): New method; merges the
20340 merge result into the current vector.
20341 (FlowBranching.Merge): New abstract method to merge a branching.
20343 2003-08-12 Martin Baulig <martin@ximian.com>
20345 * expression.cs (Indirection.CacheTemporaries): Create the
20346 LocalTemporary with the pointer type, not its element type.
20348 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20350 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20351 token was a keyword or not.
20353 Add `error' options where an IDENTIFIER was expected; Provide
20354 CheckToken and CheckIdentifierToken convenience error reporting
20357 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20359 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20360 NameSpaceEntry NameSpaceEntry.
20362 (LookupInterfaceOrClass): Avoid creating a full qualified name
20363 from namespace and name: avoid doing lookups when we know the
20364 namespace is non-existant. Use new Tree.LookupByNamespace which
20365 looks up DeclSpaces based on their namespace, name pair.
20367 * driver.cs: Provide a new `parser verbose' to display the
20368 exception thrown during parsing. This is turned off by default
20369 now, so the output of a failure from mcs is more graceful.
20371 * namespace.cs: Track all the namespaces defined in a hashtable
20374 (IsNamespace): New method
20376 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20378 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20379 we know that we need to concatenate (full typename can never be
20384 * statement.cs: Use a bitfield; Do not initialize to null things
20385 which are done by the constructor by default.
20387 * cs-parser.jay: bug fix, parameter was 4, not 3.
20389 * expression.cs: Just use the property;
20391 * statement.cs: No need for GetVariableInfo method.
20393 2003-08-08 Martin Baulig <martin@ximian.com>
20395 * flowanalysis.cs (FlowReturns): This is now nested in the
20396 `FlowBranching' class.
20397 (MyBitVector): Moved this here from statement.cs.
20398 (FlowBranching.SiblingType): New enum type.
20399 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20401 2003-08-07 Martin Baulig <martin@ximian.com>
20403 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20404 `FlowBranching' class and called `BranchingType'.
20406 2003-08-07 Martin Baulig <martin@ximian.com>
20408 * flowanalysis.cs: Moved all the control flow analysis code into
20411 2003-08-07 Martin Baulig <martin@ximian.com>
20413 * assign.cs (Assign.DoResolve): `target' must either be an
20414 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20417 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20419 * expression.cs (BinaryMethod): This kind of expression is created by the
20420 Binary class if it determines that the operator has to be handled
20423 (BinaryDelegate): This kind of expression is created if we are
20424 dealing with a + or - operator on delegates.
20426 (Binary): remove method, argumetns, and DelegateOperator: when
20427 dealing with methods,
20429 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20431 * statement.cs (Block): use bitfields for the three extra booleans
20432 we had in use. Remove unused topblock parameter.
20434 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20436 * assign.cs: Drop extra unneeded tests.
20438 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20440 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20442 * statement.cs (Foreach): Use VariableStorage instead of
20445 * codegen.cs (VariableStorage): New class used by clients that
20446 require a variable stored: locals or fields for variables that
20447 need to live across yield.
20449 Maybe provide a convenience api for EmitThis+EmitLoad?
20451 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20454 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20456 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20457 RemapParameterLValue): New methods that are used to turn a
20458 precomputed FieldInfo into an expression like this:
20462 The idea is to use this instead of making LocalVariableReference
20463 have more than one meaning.
20465 * cs-parser.jay: Add error production to BASE.
20467 * ecore.cs: Deal with TypeManager.GetField returning null, which
20468 is now a valid return value.
20470 (FieldExprNoAddress): New expression for Fields whose address can
20473 * expression.cs (LocalVariableReference): During the resolve
20474 phases, create new expressions if we are in a remapping context.
20475 Remove code that dealt with remapping here.
20477 (ParameterReference): same.
20479 (ProxyInstance): New expression, like the `This' expression, but
20480 it is born fully resolved. We know what we are doing, so remove
20481 the errors that are targeted to user-provided uses of `this'.
20483 * statement.cs (Foreach): our variable is now stored as an
20484 Expression; During resolution, follow the protocol, dont just
20485 assume it will return this.
20487 2003-08-06 Martin Baulig <martin@ximian.com>
20489 * support.cs (SeekableStreamReader.cs): New public class.
20491 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
20492 SeekableStreamReader instead of the normal StreamReader.
20494 2003-08-04 Martin Baulig <martin@ximian.com>
20496 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
20497 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
20498 deambiguate casts and delegate invocations.
20499 (parenthesized_expression): Use the new tokens to ensure this is
20500 not a cast of method invocation.
20502 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
20503 when reading a `)' and Deambiguate_CloseParens () was previously
20506 * expression.cs (ParenthesizedExpression): New class. This is
20507 just used for the CS0075 test.
20508 (Binary.DoResolve): Check for CS0075.
20510 2003-07-29 Ravi Pratap <ravi@ximian.com>
20512 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
20513 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
20514 reference comparison.
20516 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
20517 examine the ReturnType for equality - this is necessary in the
20518 cases of implicit and explicit operators whose signature also
20519 includes the return type.
20521 2003-07-26 Miguel de Icaza <miguel@ximian.com>
20523 * namespace.cs: Cache the result of the namespace computation,
20524 instead of computing it every time.
20526 2003-07-24 Miguel de Icaza <miguel@ximian.com>
20528 * decl.cs: Use a global arraylist that we reuse over invocations
20529 to avoid excesive memory consumption. Reduces memory usage on an
20530 mcs compile by one meg (45 average).
20532 * typemanager.cs (LookupTypeReflection): In .NET pointers are
20533 private, work around that.
20535 2003-07-23 Miguel de Icaza <miguel@ximian.com>
20537 * literal.cs (IntLiteral): Define Zero and One static literals.
20539 * cs-parser.jay (integer_literal): use static literals to reduce
20540 memory usage for the most used literals (0, 1 and -1). 211kb
20541 reduced in memory usage.
20543 Replace all calls to `new ArrayList' with `new
20544 ArrayList(4)' which is a good average number for most allocations,
20545 and also requires only 16 bytes of memory for its buffer by
20548 This reduced MCS memory usage in seven megabytes for the RSS after
20551 2003-07-28 Ravi Pratap <ravi@ximian.com>
20553 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
20554 handle params methods the correct way by forming only one
20555 applicable set with params and normal methods in them. Earlier we
20556 were looking at params methods only if we found no normal methods
20557 which was not the correct thing to do.
20559 (Invocation.BetterFunction): Take separate arguments indicating
20560 when candidate and the best method are params methods in their
20563 This fixes bugs #43367 and #46199.
20565 * attribute.cs: Documentation updates.
20567 (CheckAttribute): Rename to CheckAttributeTarget.
20568 (GetValidPlaces): Rename to GetValidTargets.
20570 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
20571 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
20575 2003-07-28 Martin Baulig <martin@ximian.com>
20577 * class.cs (TypeContainer.DefineMembers): Use the base type's full
20578 name when looking up the base class of a nested class. Fixes #46977.
20580 2003-07-26 Martin Baulig <martin@ximian.com>
20582 * expression.cs (Indexers.Indexer): New nested struct; contains
20583 getter, setter and the indexer's type.
20584 (Indexers.Properties): This is now an ArrayList of
20585 Indexers.Indexer's.
20586 (IndexerAccess.DoResolveLValue): Correctly set the type if the
20587 indexer doesn't have any getters.
20589 * assign.cs (Assign.DoResolve): Also do the implicit conversions
20590 for embedded property and indexer assignments.
20592 2003-07-26 Martin Baulig <martin@ximian.com>
20594 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
20595 preprocessor directive is not the first non-whitespace character
20598 2003-07-26 Martin Baulig <martin@ximian.com>
20600 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
20601 namespace parsing, follow the spec more closely.
20603 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
20604 NamespaceEntry.Lookup().
20606 2003-07-25 Martin Baulig <martin@ximian.com>
20608 * MethodCore.cs (OverridesSomething): New public field; it's set
20609 from TypeContainer.DefineMembers if this method overrides
20610 something (which doesn't need to be a method). Fix #39462.
20612 2003-07-25 Ravi Pratap <ravi@ximian.com>
20614 * typemanager.cs (GetMembers): Ensure that the list of members is
20615 reversed. This keeps things in sync.
20617 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
20618 find an AttributeUsage attribute.
20620 * expression.cs (Invocation.OverloadResolve): Perform the check
20621 which disallows Invoke to be directly called on a Delegate.
20623 (Error_InvokeOnDelegate): Report error cs1533.
20625 2003-07-25 Martin Baulig <martin@ximian.com>
20627 * expression.cs (Indexers.GetIndexersForType): Only look in the
20628 interface hierarchy if the requested type is already an
20629 interface. Fixes #46788 while keeping #46502 fixed.
20631 2003-07-25 Martin Baulig <martin@ximian.com>
20633 * class.cs (TypeContainer.DefineMembers): Check whether all
20634 readonly fields have been assigned and report warning CS0649 if
20637 * statement.cs (LocalInfo.IsFixed): Always return true if this is
20640 2003-07-24 Ravi Pratap <ravi@ximian.com>
20642 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
20643 returned from GetMethods to make things consistent with the
20644 assumptions MCS makes about ordering of methods.
20646 This should comprehensively fix bug #45127 and it does :-)
20648 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
20649 ordering is actually reverse.
20651 * Clean up some debug messages I left lying around.
20653 * interface.cs (Populate*): Get rid of code which emits attributes
20654 since the stage in which we emit attributes is the 'Emit' stage,
20655 not the define stage.
20657 (Emit): Move attribute emission for interface members here.
20659 2003-07-22 Ravi Pratap <ravi@ximian.com>
20661 * expression.cs (Invocation.OverloadResolve): Follow the spec more
20662 closely: we eliminate methods in base types when we have an
20663 applicable method in a top-level type.
20665 Please see section 14.5.5.1 for an exact description of what goes
20668 This fixes bug #45127 and a host of other related to corlib compilation.
20670 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
20671 array is the method corresponding to the top-level type (this is
20672 because of the changes made to icall.c) so we change this
20675 (MethodGroupExpr.Name): This too.
20677 * typemanager.cs (GetElementType): New method which does the right
20678 thing when compiling corlib.
20680 * everywhere: Make use of the above in the relevant places.
20682 2003-07-22 Martin Baulig <martin@ximian.com>
20684 * cs-parser.jay (invocation_expression): Moved
20685 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
20686 `cast_expression', but create a InvocationOrCast which later
20687 resolves to either an Invocation or a Cast.
20689 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
20690 method; call this before EmitStatement() to make sure that this
20691 expression can be used as a statement.
20693 * expression.cs (InvocationOrCast): New class; resolves to either
20694 an Invocation or a Cast.
20696 * statement.cs (StatementExpression): Call ResolveStatement() on
20697 the ExpressionStatement before emitting it.
20699 2003-07-21 Martin Baulig <martin@ximian.com>
20701 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
20702 `ref' and `out' attributes match; fixes #46220.
20703 (MemberAccess.ResolveMemberAccess): You can't reference a type
20704 through an expression; fixes #33180.
20705 (Indexers.GetIndexersForType): Don't return the indexers from
20706 interfaces the class implements; fixes #46502.
20708 2003-07-21 Martin Baulig <martin@ximian.com>
20710 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
20711 CS0661 checks; fixes bug #30442.
20713 2003-07-21 Martin Baulig <martin@ximian.com>
20715 * decl.cs (AdditionResult): Added `Error'.
20717 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
20719 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
20720 makes cs0031.cs actually work.
20722 2003-07-20 Martin Baulig <martin@ximian.com>
20724 * namespace.cs: Fixed that bug which caused a crash when compiling
20725 the debugger's GUI.
20727 2003-07-20 Miguel de Icaza <miguel@ximian.com>
20729 * typemanager.cs (LookupTypeReflection): Never expose types which
20730 are NotPublic, NestedPrivate, NestedAssembly, or
20731 NestedFamANDAssem. We used to return these, and later do a check
20732 that would report a meaningful error, but the problem is that we
20733 would not get the real match, if there was a name override.
20735 2003-07-18 Miguel de Icaza <miguel@ximian.com>
20737 * namespace.cs (Namespace, Name): Do not compute the namespace
20738 name dynamically, compute it in the constructor. This reduced
20739 memory usage by 1697 KB.
20741 * driver.cs: Use --pause to pause at the end.
20743 2003-07-17 Peter Williams <peter@newton.cx>
20745 * Makefile: Change the name of the test target so that it doesn't
20746 conflict with the recursive test target.
20748 2003-07-17 Miguel de Icaza <miguel@ximian.com>
20750 * expression.cs (LocalVariableReference.Emit, EmitAssign,
20751 AddressOf): Do not use EmitThis, that was wrong, use the actual
20754 2003-07-15 Miguel de Icaza <miguel@ximian.com>
20756 * class.cs (MethodData.Define): While checking if a method is an
20757 interface implementation, improve the test: If we are not public
20758 (use new test here: use the computed MethodAttributes directly,
20759 instead of the parsed modifier flags) check if the `implementing'
20760 method comes from an interface or not.
20762 * pending.cs (VerifyPendingMethods): Slightly better error
20765 * makefile: add test target that does the mcs bootstrap.
20767 2003-07-16 Ravi Pratap <ravi@ximian.com>
20769 * interface.cs (Define): Do nothing here since there are no
20770 members to populate etc. Move the attribute emission out of here
20771 since this was just totally the wrong place to put it. Attribute
20772 application happens during the 'Emit' phase, not in the 'Define'
20775 (Emit): Add this method and move the attribute emission here
20777 * rootcontext.cs (EmitCode): Call the Emit method on interface
20780 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20782 * expression.cs (OverloadResolve): Report error only if Location
20783 is not 'Null' which means that there was a probe going on.
20785 2003-07-14 Martin Baulig <martin@ximian.com>
20787 * expression.cs (ConditionalLogicalOperator): New public class to
20788 implement user defined conditional logical operators.
20789 This is section 14.11.2 in the spec and bug #40505.
20791 2003-07-14 Martin Baulig <martin@ximian.com>
20793 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
20795 2003-07-14 Martin Baulig <martin@ximian.com>
20797 * codegen.cs (EmitContext.InFixedInitializer): New public field.
20799 * ecore.cs (IVariable.VerifyFixed): New interface method.
20801 * expression.cs (Unary.ResolveOperator): When resolving the `&'
20802 operator, check whether the variable is actually fixed. Fixes bug
20803 #36055. Set a variable definitely assigned when taking its
20804 address as required by the spec.
20806 * statement.cs (LocalInfo.IsFixed): New field.
20807 (LocalInfo.MakePinned): Set `IsFixed' to true.
20809 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20811 * attribute.cs (Attribute.Resolve): While doing a Member lookup
20812 for .ctors, ensure that we only ask for members declared in the
20813 attribute type (BindingFlags.DeclaredOnly).
20817 * expression.cs (Error_WrongNumArguments): Report error 1501
20818 correctly the way CSC does.
20820 2003-07-13 Martin Baulig <martin@ximian.com>
20822 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
20823 lookup on the fully qualified name, to make things like "X.X" work
20824 where "X.X" is a fully qualified type name, but we also have a
20825 namespace "X" in the using list. Fixes #41975.
20827 2003-07-13 Martin Baulig <martin@ximian.com>
20829 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
20830 function. If we're a CompoundAssign, we need to create an embedded
20831 CompoundAssign, not an embedded Assign.
20832 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
20835 2003-07-13 Martin Baulig <martin@ximian.com>
20837 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
20838 work to fix bug #46088.
20840 2003-07-13 Ravi Pratap <ravi@ximian.com>
20842 * class.cs (Operator.Emit): Do not emit attributes here - it is
20843 taken care of by the Method class that we delegate too. This takes
20844 care of bug #45876.
20846 2003-07-10 Martin Baulig <martin@ximian.com>
20848 * expression.cs (TypeOfVoid): New class.
20849 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
20851 2003-07-10 Martin Baulig <martin@ximian.com>
20853 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
20856 2003-07-10 Martin Baulig <martin@ximian.com>
20858 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
20859 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
20861 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
20863 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
20865 2003-07-10 Martin Baulig <martin@ximian.com>
20867 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
20868 of decimal. Fixes #42850.
20870 NOTE: I also fixed the created byte blob, but this doesn't work on
20871 the MS runtime and csc never produces any byte blobs for decimal
20874 2003-07-10 Martin Baulig <martin@ximian.com>
20876 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
20877 structs; fixes #32068.
20878 (Block.AddChildVariableNames): Fixed #44302.
20880 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20882 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
20884 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20886 * attribute.cs: And this test is onger needed.
20888 2003-07-08 Martin Baulig <martin@ximian.com>
20890 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
20891 inaccessible types. Fixes #36313.
20893 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
20895 * namespace.cs (NamespaceEntry): Create implicit entries for all
20896 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
20897 implicit entries for N1.N2 and N1.
20899 2003-07-08 Martin Baulig <martin@ximian.com>
20901 Rewrote the handling of namespaces to fix a lot of the issues
20902 wrt. `using' aliases etc.
20904 * namespace.cs (Namespace): Splitted this class into a
20905 per-assembly `Namespace' and a per-file `NamespaceEntry'.
20907 * typemanager.cs (TypeManager.IsNamespace): Removed.
20908 (TypeManager.ComputeNamespaces): Only compute namespaces from
20909 loaded assemblies here, not the namespaces from the assembly we're
20910 currently compiling.
20912 2003-07-08 Martin Baulig <martin@ximian.com>
20914 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
20916 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20918 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
20921 I thought about the memory savings here, but LookupTypeReflection
20922 is used under already very constrained scenarios. Compiling
20923 corlib or mcs only exposes one hit, so it would not really reduce
20924 any memory consumption.
20926 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20928 * typemanager.cs: fixes bug #45889 by only adding public types from
20929 other assemblies to the list of known types.
20931 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20933 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
20934 on the type we resolved.
20936 2003-07-05 Martin Baulig <martin@ximian.com>
20938 * pending.cs (PendingImplementation.ParentImplements): Don't
20939 create the proxy if the parent is abstract.
20941 * class.cs (TypeContainer.DefineIndexers): Process explicit
20942 interface implementations first. Fixes #37714.
20944 2003-07-04 Miguel de Icaza <miguel@ximian.com>
20946 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
20947 defined recursively; but since we modify the input parameters
20948 (left is set to `this' temporarily), we reset this value if the
20949 left_is_explicit is false, which gives the original semantics to
20952 * literal.cs (NullPointer): new class used to represent a null
20953 literal in a pointer context.
20955 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
20956 type is a pointer, use a NullPointer object instead of a
20957 NullLiteral. Closes 43687
20959 (ExplicitConversion): Convert pointer values using
20960 the conv opcode to the proper type.
20962 * ecore.cs (New): change ValueTypeVariable property into a method,
20963 that returns whether the valuetype is suitable for being used.
20965 * expression.cs (Binary.DoNumericPromotions): Only return if we
20966 the int constant was a valid uint, and we can return both left and
20967 right as uints. If not, we continue processing, to trigger the
20968 type conversion. This fixes 39018.
20970 * statement.cs (Block.EmitMeta): During constant resolution, set
20971 the CurrentBlock property on the emitcontext, so that we resolve
20972 constants propertly.
20974 2003-07-02 Martin Baulig <martin@ximian.com>
20976 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
20977 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
20979 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
20980 than emitting it here.
20982 * statement.cs: Fixed some more flow analysis bugs.
20984 2003-07-02 Martin Baulig <martin@ximian.com>
20986 * class.cs (MethodData.Define): When implementing interface
20987 methods, set Final unless we're Virtual.
20989 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
20990 check work for interface methods.
20992 2003-07-01 Martin Baulig <martin@ximian.com>
20994 * ecore.cs (EmitContext.This): Replaced this property with a
20995 GetThis() method which takes a Location argument. This ensures
20996 that we get the correct error location for a CS0188.
20998 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21000 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21001 ImplicitStandardConversion.
21003 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21005 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21007 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21010 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21012 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21015 (MethodData.Define): Turn off initlocals for unsafe methods.
21017 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21019 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21020 complete; Fixes #37521.
21022 * delegate.cs: Use Modifiers.TypeAttr to compute the
21023 TypeAttributes, instead of rolling our own. This makes the flags
21024 correct for the delegates.
21026 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21028 * class.cs (Constructor.Define): Set the private flag for static
21029 constructors as well.
21031 * cs-parser.jay (statement_expression): Set the return value to
21032 null, to avoid a crash when we catch an error.
21034 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21036 * cs-parser.jay: Applied patch from Jackson that adds support for
21037 extern and unsafe modifiers to destructor declarations.
21039 * expression.cs: Report error 21 if the user is trying to index a
21042 * driver.cs: Add an error message, suggested by the bug report.
21044 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21045 if we do not have a ": this ()" constructor initializer. Fixes 45149
21047 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21049 * namespace.cs: Add some information to reduce FAQs.
21051 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21053 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21054 underlying enumeration types. Fixes #43915.
21056 * expression.cs: Treat ushort/short as legal values to be used in
21057 bitwise operations.
21059 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21061 * delegate.cs: transfer custom attributes for paramenters from
21062 the delegate declaration to Invoke and BeginInvoke.
21064 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21066 * attribute.cs: handle custom marshalers and emit marshal info
21069 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21071 * makefile.gnu: Added anonymous.cs to the compiler sources.
21073 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21075 * iterators.cs: Change the name of the proxy class to include two
21078 * cs-parser.jay: Update grammar to include anonymous methods.
21080 * anonymous.cs: new file.
21082 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21084 * class.cs (Field.Define): Add missing test for pointers and
21087 2003-05-27 Ravi Pratap <ravi@ximian.com>
21089 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21090 we use the stobj opcode.
21092 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21093 since it wasn't the correct fix.
21095 It still is puzzling that we are required to use stobj for IntPtr
21096 which seems to be a ValueType.
21098 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21100 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21101 during regular simple name resolution. Now, the trick is that
21102 instead of returning for processing the simplename, we do a
21103 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21104 contextual lookup type). If a match is found, return that, if
21105 not, return for further composition.
21107 This fixes long-standing 30485.
21109 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21110 using the address to initialize an object, do an Stobj instead of
21111 using the regular Stelem.
21113 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21114 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21115 Because if we are a BaseIndexerAccess that value will be true.
21118 * statement.cs (GotoCase.Resolve): Return after reporting an
21119 error, do not attempt to continue.
21121 * expression.cs (PointerArithmetic.Emit): If our operand is a
21122 long, convert our constants to match the operand before
21123 multiplying. Convert to I type before adding. Fixes 43670.
21125 2003-05-14 Ravi Pratap <ravi@ximian.com>
21127 * enum.cs (ImplicitConversionExists) : Rename to
21128 ImplicitEnumConversionExists to remove ambiguity.
21130 * ecore.cs (NullCast): New type of cast expression class which
21131 basically is very similar to EmptyCast with the difference being
21132 it still is a constant since it is used only to cast a null to
21134 (eg. (string) null)
21136 * convert.cs (ImplicitReferenceConversion): When casting a null
21137 literal, we return a NullCast.
21139 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21140 should be around anymore.
21142 The renaming (reported was slightly wrong). Corrections:
21144 ConvertImplicitStandard -> ImplicitConversionStandard
21145 ConvertExplicitStandard -> ExplicitConversionStandard
21147 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21148 before passing them in !
21150 * convert.cs (ImplicitConversionStandard): When comparing for
21151 equal expr and target types, ensure that expr is not a
21154 In general, we must not be checking (expr_type ==
21155 target_type) in the top level conversion methods
21156 (ImplicitConversion, ExplicitConversion etc). This checking is
21157 done in the methods that they delegate to.
21159 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21161 * convert.cs: Move Error_CannotConvertType,
21162 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21163 ImplicitNumericConversion, ImplicitConversionExists,
21164 ImplicitUserConversionExists, StandardConversionExists,
21165 FindMostEncompassedType, FindMostSpecificSource,
21166 FindMostSpecificTarget, ImplicitUserConversion,
21167 ExplicitUserConversion, GetConversionOperators,
21168 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21169 TryImplicitIntConversion, Error_CannotConvertImplicit,
21170 ConvertImplicitRequired, ConvertNumericExplicit,
21171 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21172 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21175 Perform the following renames:
21177 StandardConversionExists -> ImplicitStandardConversionExists
21178 ConvertImplicit -> ImplicitConversion
21179 ConvertImplicitStandard -> ImplicitStandardConversion
21180 TryImplicitIntConversion -> ImplicitIntConversion
21181 ConvertImplicitRequired -> ImplicitConversionRequired
21182 ConvertNumericExplicit -> ExplicitNumericConversion
21183 ConvertReferenceExplicit -> ExplicitReferenceConversion
21184 ConvertExplicit -> ExplicitConversion
21185 ConvertExplicitStandard -> ExplicitStandardConversion
21187 2003-05-19 Martin Baulig <martin@ximian.com>
21189 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21190 (TypeInfo): Added support for structs having structs as fields.
21192 * ecore.cs (FieldExpr): Implement IVariable.
21193 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21194 VariableInfo for the field.
21196 2003-05-18 Martin Baulig <martin@ximian.com>
21198 * expression.cs (This.DoResolve): Report a CS0027 if we're
21199 emitting a field initializer.
21201 2003-05-18 Martin Baulig <martin@ximian.com>
21203 * expression.cs (This.ResolveBase): New public function.
21204 (This.DoResolve): Check for CS0188.
21206 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21209 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21210 `instance_expression' to null if we don't have any non-static
21213 2003-05-18 Martin Baulig <martin@ximian.com>
21215 Reworked the way how local variables and parameters are handled by
21216 the flow analysis code.
21218 * statement.cs (TypeInfo, VariableMap): New public classes.
21219 (VariableInfo): New public class. This is now responsible for
21220 checking whether a variable has been assigned. It is used for
21221 parameters and local variables.
21222 (Block.EmitMeta): Take the InternalParameters as argument; compute
21223 the layout of the flow vectors here.
21224 (Block.LocalMap, Block.ParameterMap): New public properties.
21225 (FlowBranching): The .ctor doesn't get the InternalParameters
21226 anymore since Block.EmitMeta() now computes the layout of the flow
21228 (MyStructInfo): This class is now known as `StructInfo' and nested
21229 in `TypeInfo'; we don't access this directly anymore.
21231 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21232 property and removed IsAssigned(), IsFieldAssigned(),
21233 SetAssigned() and SetFieldAssigned(); we now call them on the
21234 VariableInfo so we don't need to duplicate this code everywhere.
21236 * expression.cs (ParameterReference): Added `Block block' argument
21238 (LocalVariableReference, ParameterReference, This): The new
21239 VariableInfo class is now responsible for all the definite
21242 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21243 IsParameterAssigned, SetParameterAssigned): Removed.
21245 2003-05-18 Martin Baulig <martin@ximian.com>
21247 * typemanager.cs (InitCoreTypes): Try calling
21248 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21249 the 3-args-version. Corlib now also needs our `void_type'.
21250 (GetMethod): Added overloaded version which takes an optional
21251 `bool report_errors' to allow lookups of optional methods.
21253 2003-05-12 Martin Baulig <martin@ximian.com>
21255 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21256 only used for locals and not for parameters.
21258 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21260 * support.cs (InternalParameters.ParameterType): Return the
21261 ExternalType of the parameter.
21263 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21266 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21268 * class.cs (MethodData.Define): Do not set the `newslot' on
21269 interface members, if they are also flagged as "override".
21271 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21272 better code for ++i and i++. This only works for static fields
21273 and local variables.
21275 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21276 want to pull the DeclSpace out of the builder_to_declspace instead
21277 of the TypeBuilder (like in TypeContainer.FindMembers).
21279 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21280 instead of LookupTypeContainer. Fixes the crash on .NET for
21281 looking up interface members.
21283 * const.cs: Create our own emit context during the Definition
21284 stage, so that constants are evaluated in the proper context, when
21285 a recursive definition happens.
21287 2003-05-11 Martin Baulig <martin@ximian.com>
21289 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21290 new block for a switch section.
21291 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21292 the adding/lookup in the switch block. Fixes #39828.
21294 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21296 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21297 functionality: I needed to convert the data after I had performed
21298 the add/sub operation into the operands type size.
21300 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21301 pass the type for the box operation, otherwise the resulting
21302 object would have been of type object.
21304 (BoxedCast): Add constructor to specify the type to box as.
21306 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21308 * iterators.cs: I was reusing the `count' variable inadvertently,
21309 take steps to not allow this to happen.
21311 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21313 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21314 by creating an array at the point where the params starts and
21315 putting all those arguments there, then adjusting the size of the
21318 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21320 * expression.cs (New.AddressOf): Implement interface
21321 IMemoryLocation. This is used when the `new' operator is used in
21322 the context of an invocation to a method on a value type.
21324 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21327 * namespace.cs: Also check the using aliases here.
21329 * driver.cs: Move the test for using validity after the types have
21330 been entered, so we do a single pass that also includes the using
21333 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21334 in the regular case. CreateSiblingForFinally is doing extra
21337 * attribute.cs (GetAttributeArgumentExpression): Store the result
21338 on an out value, and use the return value to indicate failure
21339 instead of using null (which is a valid return for Constant.GetValue).
21341 * statement.cs: Perform the analysis flow for the increment
21342 portion after the statement, because this will be the real flow of
21343 execution. Fixes #42385
21345 * codegen.cs (EmitContext.EmitArgument,
21346 EmitContext.EmitStoreArgument): New helper functions when the
21347 RemapToProxy flag is set.
21349 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21352 Add support for remapping parameters.
21354 * iterators.cs: Propagate parameter values; Store parameter
21355 values in the proxy classes.
21357 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21359 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21360 need a proxy reference; I do not know what I was thinking
21362 * cs-parser.jay (constructor_initializer): catch another error,
21363 and display nice message.
21365 (field_declaration): catch void field declaration
21366 to flag a better error.
21368 * class.cs (MemberBase.CheckBase): Report an error instead of a
21369 warning if a new protected member is declared in a struct.
21370 (Field.Define): catch the error of readonly/volatile.
21372 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21374 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21375 volatile variable is taken
21377 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21379 * statement.cs (Fixed.Resolve): Report an error if we are not in
21382 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21384 * typemanager.cs: reuse the code that handles type clashes for
21385 delegates and enumerations.
21387 * class.cs (Report28): Always report.
21389 * expression.cs (EncodeAsAttribute): Allow nulls here.
21391 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21393 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21394 the functionality for testing whether an expression is valid for
21395 an attribute here. Also handle the case of arrays of elements
21398 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21399 encoding a linear array into an array of objects that are suitable
21400 to be passed to an CustomAttributeBuilder.
21402 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21404 * ecore.cs: (FieldExpr): Handle field remapping here.
21406 * iteratators.cs: Pass the instance variable (if the method is an
21407 instance method) to the constructors, so we can access the field
21408 variables on the class.
21410 TODO: Test this with structs. I think the THIS variable on
21411 structs might have to be a pointer, and not a refenrece
21413 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21415 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21416 local variables to fields in a proxy class.
21418 * iterators.cs (PopulateProxy): Rename our internal fields to
21420 Create a <THIS> field if we are an instance method, so we can
21421 reference our parent container variables.
21422 (MapVariable): Called back from the EmitContext code to enter a
21423 new variable to field mapping into the proxy class (we just create
21427 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21428 for using the remapped locals to fields.
21430 I placed the code here, because that gives the same semantics to
21431 local variables, and only changes the Emit code.
21433 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21434 statements inside iterators.
21435 (VariableInfo): Add a FieldBuilder for the cases when we are
21436 remapping local variables to fields in a proxy class
21438 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21439 current_block != null.
21441 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21442 not cope with strings, as it has been moved to the
21443 TableSwitchEmit. Fixed bug in switch generation.
21445 * expression.cs (New.DoResolve): Provide more context for the user
21446 when reporting an error.
21448 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21451 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21452 check the permissions for it. Note than in a type-resolution
21453 context the check was already present in DeclSpace.ResolveType,
21454 but was missing from the MemberAccess.
21456 (ArrayCreation.CheckIndices): warn if the user has
21457 more nested levels of expressions, but there are no more
21458 dimensions specified. Avoids crash on bug 41906.
21460 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21462 * statement.cs (Block): replace Implicit bool, for a generic
21464 New flag: `Unchecked'. This is used during the EmitMeta phase
21465 (which is out-of-line with the regular Resolve/Emit process for a
21466 statement, as this is done ahead of time, but still gets a chance
21467 to call constant resolve).
21469 (Block.Flags): new enum for adding a new flag.
21471 (Block.EmitMeta): track the state of unchecked.
21473 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21474 to enable constant resolution to work there as well.
21476 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21478 * typemanager.cs (ienumerable_type): Also look up
21479 System.Collections.IEnumerable.
21481 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21483 TODO: Test more than one conditional per method.
21485 * class.cs (Indexer.Define): Report the location where the user is
21486 referencing the unsupported feature.
21488 (MethodData): Overload the use of `conditionals' to
21489 minimize the creation of needless ArrayLists. This saves roughly
21490 212kb on my machine.
21492 (Method): Implement the new IIteratorContainer interface.
21493 (Method.SetYields): Implement the method by setting the ModFlags
21494 to contain METHOD_YIELDS.
21496 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
21497 which just got set to null.
21499 * iterators.cs: New file.
21501 (Yield, YieldBreak): New statements.
21503 * statement.cs (Return.Resolve): Flag an error if we are used in
21504 an iterator method.
21506 * codegen.cs (InIterator): New flag set if the code is being
21507 compiled in an iterator method.
21509 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
21510 internal modifier, and we just use it to avoid adding extra
21511 fields, as this is seldom used.
21513 * cs-parser.jay: Add yield_statement (yield and yield break).
21515 * driver.cs: New flag -v2 to turn on version 2 features.
21517 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
21518 hashtable when v2 is enabled.
21520 2003-04-20 Miguel de Icaza <miguel@ximian.com>
21522 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
21523 there is already a namespace defined with this name.
21525 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
21526 people upgraded their corlibs.
21528 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
21529 always use fully qualified types, no need to use the compiler
21532 (TypeManager.IsNamespace): Use binarysearch.
21534 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
21535 AddDelegate): I did not quite use the new IsValid API properly: I
21536 have to pass the short-name and the fullname. I was passing only
21537 the basename instead of the fullname sometimes.
21539 (TypeContainer.DefineType): call NamespaceClash.
21541 * interface.cs (Interface.DefineType): use NamespaceClash before
21544 * delegate.cs (Delegate.DefineType): use NamespaceClash before
21547 * enum.cs: (Enum.DefineType): use NamespaceClash before
21550 * typemanager.cs (: 3-line patch that gives us some tasty 11%
21551 speed increase. First, use the negative_hits cache when we get a
21552 negative. Second, add the type with its full original name
21553 instead of the new . and + encoded name (reflection uses + to
21554 separate type from a nested type). Use LookupTypeReflection
21555 directly which bypasses the type->name hashtable (that we already
21556 know does not contain the type.
21558 * decl.cs (DeclSpace.ResolveTypeExpr): track the
21559 location/container type.
21561 * driver.cs: When passing utf8, use directly the UTF8Encoding.
21563 2003-04-19 Miguel de Icaza <miguel@ximian.com>
21565 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
21567 * delegate.cs (NewDelegate.Resolve): Test whether an instance
21568 method is being referenced in the method group from a static
21569 context, and report error 120 if so.
21571 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
21574 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
21575 is created, we create the A namespace).
21577 * cs-parser.jay: A namespace also introduces a DeclarationFound.
21580 2003-04-18 Miguel de Icaza <miguel@ximian.com>
21582 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
21583 invocation to ModuleBuilder.GetType with the same values will
21584 return a new type instance, so we need to cache its return
21587 * expression.cs (Binary.ResolveOperator): Only allow the compare
21588 operators on enums if they are of the same type.
21590 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
21591 types of ValueType on their own case. Before we were giving them
21592 the same treatment as objects.
21594 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
21595 fullname. Short name is used to compare against container name.
21596 Fullname is used to check against defined namespace names.
21598 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
21599 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
21601 (Method.CheckBase): Call parent.
21602 (MemberBase.CheckBase): Check for protected members on sealed
21604 (PropertyBase.CheckBase): Call parent.
21605 (Field.Define): Call parent.
21607 * report.cs: Negative error codes are now mapped to 8000 - code,
21608 so that the display is render more nicely.
21610 * typemanager.cs: Do not use try/catch, instead report a regular
21613 (GetPointerType, GetReferenceType): These methods provide
21614 mechanisms to obtain the T* and T& from a T. We had the code
21615 previously scattered around the code base, and it also used
21616 TypeManager.LookupType that would go through plenty of caches.
21617 This one goes directly to the type source.
21619 In some places we did the Type.GetType followed by
21620 ModuleBuilder.GetType, but not in others, so this unifies the
21621 processing as well.
21623 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
21624 statements now that we have namespace information.
21626 * typemanager.cs (IsNamespace): New method, returns whether the
21627 string presented is a namespace or not.
21629 (ComputeNamespaces): New public entry point, computes the list of
21630 available namespaces, using the GetNamespaces API call in Mono, or
21631 the slower version in MS.NET.
21633 Now before we start the semantic analysis phase, we have a
21634 complete list of namespaces including everything that the user has
21637 Deleted old code to cache namespaces in .nsc files.
21639 2003-04-17 Miguel de Icaza <miguel@ximian.com>
21641 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
21642 class/struct location definition Location for the implicit
21643 constructor location.
21645 (Operator.Define): Use the location of the operator for the
21646 implicit Method definition.
21648 (Constructor.Emit): use the constructor location for the implicit
21649 base initializer constructor.
21651 * ecore.cs: Remove ITypeExpression. This interface is now gone,
21652 and the Expression class now contains two new methods:
21654 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
21655 isolate type lookup from the rest of the resolution process.
21657 Since we use Expressions to hold type definitions due to the way
21658 we parse the input we have historically overloaded Resolve to
21659 perform the Type lookups if a special flag is passed. Now this is
21660 eliminated and two methods take their place.
21662 The differences in the two methods between xStep and xTerminal is
21663 that xStep is involved in our current lookup system that uses
21664 SimpleNames to compose a name, while xTerminal is used just to
21665 catch the case where the simplename lookup failed.
21667 2003-04-16 Miguel de Icaza <miguel@ximian.com>
21669 * expression.cs (ResolveMemberAccess): Remove redundant code.
21670 TypeExpr expressions are always born fully resolved.
21672 * interface.cs (PopulateMethod): Do not lookup the types twice.
21673 We were doing it once during SemanticAnalysis and once during
21676 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
21677 in local variable type definitions, were being returned as a
21678 SimpleName (we decomposed everything into a string), that is
21679 because primary_expression was being used instead of a type in the
21680 grammar (reduce/reduce conflicts).
21682 The part that was wrong is that we converted the expression into a
21683 string (an oversimplification in one hand, compounded with primary
21684 expressions doing string concatenation).
21690 Would return "A.B.C[]" as a SimpleName. This stopped things like
21691 using clauses from working on this particular context. And a type
21692 was being matched directly against "A.B.C[]".
21694 We now use the correct approach, and allow for ComposedCast to be
21695 part of the unary expression. So the "A.B.C []" become a composed
21696 cast of "A.B.C" (as a nested group of MemberAccess with a
21697 SimpleName at the end) plus the rank composition "[]".
21701 2003-04-10 Miguel de Icaza <miguel@ximian.com>
21703 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
21704 for the access level checking.
21706 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
21707 `TypeContainer container', because I kept getting confused when I
21708 was debugging this code.
21710 * expression.cs (Indexers): Instead of tracking getters/setters,
21711 we now track them in parallel. We create one arraylist less, but
21712 most importantly it is possible now for the LValue code to find a
21713 matching get for a set.
21715 (IndexerAccess.DoResolveLValue): Update the code.
21716 GetIndexersForType has been modified already to extract all the
21717 indexers from a type. The code assumed it did not.
21719 Also make the code set the correct return type for the indexer.
21720 This was fixed a long time ago for properties, but was missing for
21721 indexers. It used to be void_type.
21723 (Binary.Emit): Test first for doubles instead of
21724 floats, as they are more common.
21726 (Binary.EmitBranchable): Use the .un version of the branch opcodes
21727 when dealing with floats and the <=, >= operators. This fixes bug
21730 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
21731 to load the array value by emitting a load on the foreach variable
21732 type. This was incorrect.
21734 We now emit the code to load an element using the the array
21735 variable type, and then we emit the conversion operator.
21739 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
21741 * attribute.cs: Avoid allocation of ArrayLists in the common case.
21743 2003-04-09 Miguel de Icaza <miguel@ximian.com>
21745 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
21746 test for protection before we test for signatures.
21748 (MethodSignature.ToString): implement.
21750 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
21751 to the case where we reduced into a LongConstant.
21753 * decl.cs (CheckAccessLevel): If the type is an array, we can not
21754 depend on whether the information is acurrate, because the
21755 Microsoft runtime will always claim that the array type is public,
21756 regardless of the real state.
21758 If the type is a pointer, another problem happens: the type is
21759 reported as non-public in Microsoft.
21761 In both cases we have to call CheckAccessLevel recursively with
21762 the underlying type as the argument to be tested.
21764 2003-04-08 Miguel de Icaza <miguel@ximian.com>
21766 * assign.cs (Assign.Emit): If we are dealing with a compound
21767 assignment expression, we should use the code path that stores the
21768 intermediate result in a temporary value. This fixes #40903.
21770 *expression.cs (Indirection.ToString): Provide ToString method for
21773 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
21775 * class.cs: Null out fields holding references to Block objects so
21776 they can be garbage collected.
21778 * expression.cs (OverloadResolve): Remove unused local.
21780 2003-04-07 Martin Baulig <martin@ximian.com>
21782 * codegen.cs (EmitContext.CurrentFile): New public field.
21783 (EmitContext.Mark): Use the CurrentFile to check whether the
21784 location is in the correct file.
21785 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
21787 2003-04-07 Martin Baulig <martin@ximian.com>
21789 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
21791 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
21792 location. [FIXME: The location argument which gets passed to this
21793 method is sometimes wrong!]
21795 2003-04-07 Nick Drochak <ndrochak@gol.com>
21797 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
21799 2003-04-07 Miguel de Icaza <miguel@ximian.com>
21801 * expression.cs (Indirection.EmitAssign): We were using the
21802 temporary, but returning immediately instead of continuing the
21805 2003-04-06 Martin Baulig <martin@ximian.com>
21807 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
21808 if it's a nested child, but also deriving from the outer class.
21811 * typemanager.cs (IsNestedChildOf): Make this work if it's a
21812 nested child, but also deriving from the outer class. See
21814 (FilterWithClosure): We may access private members of the outer
21815 class if we're a nested child and deriving from the outer class.
21816 (RealMemberLookup): Only set `closure_private_ok' if the
21817 `original_bf' contained BindingFlags.NonPublic.
21819 2003-04-05 Martin Baulig <martin@ximian.com>
21821 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
21823 2003-04-02 Miguel de Icaza <miguel@ximian.com>
21825 * class.cs (Event.Define): Do not allow abstract events to have
21828 2003-04-01 Miguel de Icaza <miguel@ximian.com>
21830 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
21831 block in event declarations.
21833 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
21834 value type, get its address.
21836 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
21837 leaving a class on the stack instead of a boolean value (int
21838 0/1). Change the code so we compare against null, and then the
21839 result against zero.
21841 * class.cs (TypeContainer.GetClassBases): We were checking for the
21842 parent class being sealed too late.
21844 * expression.cs (Binary.Emit): For <= and >= when dealing with
21845 floating point values, use cgt.un and clt.un instead of cgt and
21848 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
21850 * statement.cs: Apply the same optimization as MS: skip the
21851 GetEnumerator returning an IEnumerator, and use the one returning a
21852 CharEnumerator instead. This allows us to avoid the try-finally block
21855 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
21857 * cs-parser.jay: Attributes cannot be applied to
21858 namespaces. Fixes #40473
21860 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21863 (Add*): check if the name is valid using the full name for constants,
21864 fields, properties and events.
21866 2003-03-28 Miguel de Icaza <miguel@ximian.com>
21868 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
21869 char constants to be part of the enumeration.
21871 * expression.cs (Conditional.DoResolve): Add support for operator
21872 true. Implements the missing functionality from 14.12
21874 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
21875 operator true/false as required by the spec.
21877 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
21878 implicit conversion to boolean.
21880 * statement.cs (Statement.ResolveBoolean): A boolean expression is
21881 also one where the type implements `operator true'.
21883 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
21884 get an expression that will invoke operator true based on an
21887 (GetConversionOperators): Removed the hack that called op_True
21890 (Expression.ResolveBoolean): Move this from Statement.
21892 2003-03-17 Miguel de Icaza <miguel@ximian.com>
21894 * ecore.cs (FieldExpr): do not allow initialization of initonly
21895 fields on derived classes
21897 2003-03-13 Martin Baulig <martin@ximian.com>
21899 * statement.cs (Block.Emit): Call ig.BeginScope() and
21900 ig.EndScope() when compiling with debugging info; call
21901 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
21903 2003-03-08 Miguel de Icaza <miguel@ximian.com>
21905 * expression.cs (Indexers): Do not construct immediately, allow
21906 for new members to be appended as we go. Fixes 38143
21908 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21910 * expression.cs: save/restore context when resolving an unchecked
21913 2003-03-05 Miguel de Icaza <miguel@ximian.com>
21915 * cfold.cs: Catch division by zero in modulus operator during
21918 2003-03-03 Miguel de Icaza <miguel@ximian.com>
21920 * interface.cs (Interface.DefineMembers): Avoid defining members
21923 2003-02-27 Miguel de Icaza <miguel@ximian.com>
21925 * driver.cs: handle the +/- options for -noconfig
21927 * statement.cs (Unckeched.Resolve): Also track the state of
21928 unchecked in the Resolve phase.
21930 2003-02-27 Martin Baulig <martin@ximian.com>
21932 * ecore.cs (Expression.MemberLookup): Don't create a
21933 MethodGroupExpr for something which is not a method. Fixes #38291.
21935 2003-02-25 Miguel de Icaza <miguel@ximian.com>
21937 * class.cs (MemberBase.CheckParameters): Also check that the type
21938 is unmanaged if it is a pointer.
21940 * expression.cs (SizeOf.Resolve): Add location information.
21942 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
21943 a managed type is declared.
21945 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
21946 parameter modifiers as well. Fixes bug 38606
21948 * class.cs: Very sad. Am backing out the speed up changes
21949 introduced by the ArrayList -> Array in the TypeContainer, as they
21950 were not actually that much faster, and introduced a bug (no error
21951 reports on duplicated methods).
21953 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
21954 source first, this will guarantee that we have a valid expression
21955 before calling in lower levels functions that will require a
21956 resolved object. Then use this original_source in the
21957 target.ResolveLValue instead of the original source that was
21960 Another change. Use target.Resolve instead of LValueResolve.
21961 Although we are resolving for LValues, we will let the Assign code
21962 take care of that (it will be called again from Resolve). This
21963 basically allows code like this:
21965 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
21966 class Y { void A (X x) { x [0] += o; }
21968 The problem was that the indexer was trying to resolve for
21969 set_Item (idx, object o) and never finding one. The real set_Item
21970 was set_Item (idx, X). By delaying the process we get the right
21975 2003-02-23 Martin Baulig <martin@ximian.com>
21977 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
21978 while calling DoEmit ().
21980 * codegen.cs (EmitContext.Mark): Don't mark locations in other
21981 source files; if you use the #line directive inside a method, the
21982 compiler stops emitting line numbers for the debugger until it
21983 reaches the end of the method or another #line directive which
21984 restores the original file.
21986 2003-02-23 Martin Baulig <martin@ximian.com>
21988 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
21990 2003-02-23 Martin Baulig <martin@ximian.com>
21992 * statement.cs (Block.AddChildVariableNames): We need to call this
21993 recursively, not just for our immediate children.
21995 2003-02-23 Martin Baulig <martin@ximian.com>
21997 * class.cs (Event.Define): Always make the field private, like csc does.
21999 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22000 actually work, fixes bug #37521.
22002 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22004 * delegate.cs: When creating the various temporary "Parameters"
22005 classes, make sure that we call the ComputeAndDefineParameterTypes
22006 on those new parameters (just like we do with the formal ones), to
22007 allow them to be resolved in the context of the DeclSpace.
22009 This fixes the bug that Dick observed in Bugzilla #38530.
22011 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22013 * expression.cs (ResolveMemberAccess): When resolving a constant,
22014 do not attempt to pull a constant if the value was not able to
22015 generate a valid constant.
22017 * const.cs (LookupConstantValue): Do not report more errors than required.
22019 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22021 * expression.cs: fixes bug #38328.
22023 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22025 * class.cs: Changed all the various members that can be part of a
22026 class from being an ArrayList to be an Array of the right type.
22027 During the DefineType type_list, interface_list, delegate_list and
22028 enum_list are turned into types, interfaces, delegates and enums
22031 And during the member population, indexer_list, event_list,
22032 constant_list, field_list, instance_constructor_list, method_list,
22033 operator_list and property_list are turned into their real arrays.
22035 Although we could probably perform this operation earlier, for
22036 good error reporting we need to keep the lists and remove the
22037 lists for longer than required.
22039 This optimization was triggered by Paolo profiling the compiler
22040 speed on the output of `gen-sample-program.pl' perl script.
22042 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22043 not crash in methods like MemberLookupFailed that use this field.
22045 This problem arises when the compiler fails to resolve a type
22046 during interface type definition for example.
22048 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22050 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22051 inherit from System.Object, so we have to stop at null, not only
22052 when reaching System.Object.
22054 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22056 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22057 DeclaredOnly because the parent indexer might have had a different
22058 name, but did not loop until the top of the hierarchy was reached.
22060 The problem this one fixes is 35492: when a class implemented an
22061 indexer from an interface, we were getting the interface method
22062 (which was abstract) and we were flagging an error (can not invoke
22065 This also keeps bug 33089 functioning, and test-148 functioning.
22067 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22068 out if a method is special is to see if it is declared in a
22069 property or event, or whether it is one of the predefined operator
22070 names. This should fix correctly #36804.
22072 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22074 The goal here is to remove the dependency on EmptyCast.Peel ().
22075 Killing it completely.
22077 The problem is that currently in a number of places where
22078 constants are expected, we have to "probe" for an EmptyCast, and
22079 Peel, which is not the correct thing to do, as this will be
22080 repetitive and will likely lead to errors.
22082 The idea is to remove any EmptyCasts that are used in casts that
22083 can be reduced to constants, so we only have to cope with
22086 This bug hunt was triggered by Bug 37363 and the desire to remove
22087 the duplicate pattern where we were "peeling" emptycasts to check
22088 whether they were constants. Now constants will always be
22091 * ecore.cs: Use an enumconstant here instead of wrapping with
22094 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22095 throwing me off. By handling this we can get rid of a few hacks.
22097 * statement.cs (Switch): Removed Peel() code.
22099 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22101 * class.cs: Location information for error 508
22103 * expression.cs (New.DoResolve): Add a guard against double
22104 resolution of an expression.
22106 The New DoResolve might be called twice when initializing field
22107 expressions (see EmitFieldInitializers, the call to
22108 GetInitializerExpression will perform a resolve on the expression,
22109 and later the assign will trigger another resolution
22111 This leads to bugs (#37014)
22113 * delegate.cs: The signature for EndInvoke should contain any ref
22114 or out parameters as well. We were not doing this in the past.
22116 * class.cs (Field.Define): Do not overwrite the type definition
22117 inside the `volatile' group. Turns out that volatile enumerations
22118 were changing the type here to perform a validity test, which
22121 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22123 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22124 and structs, we do not want to load the instance variable
22126 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22127 enum_type has to be handled like an object reference (implicit
22128 conversions exists from this to object), but the regular IsClass
22129 and IsValueType tests will never return true for this one.
22131 Also we use TypeManager.IsValueType instead of type.IsValueType,
22132 just for consistency with the rest of the code (this is only
22133 needed if we ever use the construct exposed by test-180.cs inside
22134 corlib, which we dont today).
22136 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22138 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22141 2003-02-09 Martin Baulig <martin@ximian.com>
22143 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22144 (Namespace.DefineNamespaces): New static public method; this is
22145 called when we're compiling with debugging to add all namespaces
22146 to the symbol file.
22148 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22149 pass it to the Namespace's .ctor.
22151 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22152 and MethodBase arguments; pass the namespace ID to the symwriter;
22153 pass the MethodBase instead of the token to the symwriter.
22154 (SymbolWriter.DefineNamespace): New method to add a namespace to
22157 2003-02-09 Martin Baulig <martin@ximian.com>
22159 * symbolwriter.cs: New file. This is a wrapper around
22160 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22161 methods here in near future.
22163 2003-02-09 Martin Baulig <martin@ximian.com>
22165 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22166 ILGenerator.MarkSequencePoint() which are actually used by the
22169 2003-02-09 Martin Baulig <martin@ximian.com>
22171 * location.cs (SourceFile): New public sealed class. This
22172 contains the name and an index which is used in the location's token.
22173 (Location): Reserve an appropriate number of bits in the token for
22174 the source file instead of walking over that list, this gives us a
22175 really huge performance improvement when compiling with debugging.
22177 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22178 `SourceFile' argument instead of a string.
22179 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22180 but don't parse/tokenize here, we need to generate the list of all
22181 source files before we do that.
22182 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22185 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22186 instead of a string.
22188 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22191 2003-02-09 Martin Baulig <martin@ximian.com>
22193 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22194 filename on `#line default'.
22196 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22198 * statement.cs: don't clear the pinned var when the fixed statement
22199 returns from the method (fixes bug#37752).
22201 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22203 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22206 2003-02-07 Martin Baulig <martin@ximian.com>
22208 * driver.cs: Removed the `--debug-args' command line argument.
22210 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22211 automatically by the AsssemblyBuilder.
22212 (CodeGen.InitializeSymbolWriter): We don't need to call any
22213 initialization function on the symbol writer anymore. This method
22214 doesn't take any arguments.
22216 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22218 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22219 from referenced assemblies as well.
22221 2003-02-02 Martin Baulig <martin@ximian.com>
22223 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22225 2003-02-02 Martin Baulig <martin@ximian.com>
22227 * class.cs (Constructor.Emit): Open the symbol writer before
22228 emitting the constructor initializer.
22229 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22230 single-stepping through constructor initializers.
22232 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22234 * class.cs: Handle error 549: do not allow virtual methods in
22237 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22239 * decl.cs: Check access levels when resolving types
22241 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22243 * statement.cs: Add parameters and locals set in catch blocks that might
22244 return to set vector
22246 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22248 * class.cs (Operator): Set the SpecialName flags for operators.
22250 * expression.cs (Invocation.DoResolve): Only block calls to
22251 accessors and operators on SpecialName methods.
22253 (Cast.TryReduce): Handle conversions from char constants.
22256 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22258 * statement.cs: small memory and time optimization in FlowBranching.
22260 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22262 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22263 problem that the last fix but in the other sid (Set).
22265 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22266 access when there is no indexer in the hierarchy.
22268 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22270 * class.cs: Combine some if statements.
22272 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22274 * driver.cs: fixed bug #37187.
22276 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22278 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22279 any indexer, it's needed to build a list with all the indexers in the
22280 hierarchy (AllGetters), else we have problems. Fixes #35653.
22282 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22284 * class.cs (MethodData.Define): It is wrong for an interface
22285 implementation to be static in both cases: explicit and implicit.
22286 We were only handling this in one case.
22288 Improve the if situation there to not have negations.
22290 * class.cs (Field.Define): Turns out that we do not need to check
22291 the unsafe bit on field definition, only on usage. Remove the test.
22293 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22295 * driver.cs: use assembly.Location instead of Codebase (the latest
22296 patch made mcs fail when using MS assemblies).
22298 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22300 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22301 get the path to *corlib.dll.
22303 2003-01-21 Nick Drochak <ndrochak@gol.com>
22307 * typemanager.cs: Remove compiler warnings
22309 2003-01-20 Duncan Mak <duncan@ximian.com>
22311 * AssemblyInfo.cs: Bump the version number to 0.19.
22313 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22315 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22317 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22319 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22321 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22323 * cs-parser.jay: Small fix: we were not comparing the constructor
22324 name correctly. Thanks to Zoltan for the initial pointer.
22326 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22328 * cs-tokenizer.cs: Set file name when specified with #line
22330 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22332 * cs-parser.jay: Only perform the constructor checks here if we
22333 are named like the class; This will help provider a better
22334 error. The constructor path is taken when a type definition is
22335 not found, but most likely the user forgot to add the type, so
22336 report that rather than the constructor error.
22338 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22340 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22343 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22345 * cs-parser.jay: Add cleanup call.
22347 2003-01-13 Duncan Mak <duncan@ximian.com>
22349 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22350 consistent with other methods.
22352 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22354 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22356 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22358 * attribute.cs: only set GuidAttr to true when we have a
22361 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22365 * typemanager.cs: fixes to allow mcs compile corlib with the new
22366 Type.IsSubclassOf fix.
22368 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22370 * expression.cs (LocalVariableReference.DoResolve): Classify a
22371 constant as a value, not as a variable. Also, set the type for
22374 * cs-parser.jay (fixed_statement): take a type instead of a
22375 pointer_type, so we can produce a better error message later.
22377 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22380 (For.DoEmit): Make inifinite loops have a
22381 non-conditional branch back.
22383 (Fixed.DoEmit): First populate the pinned variables, then emit the
22384 statement, then clear the variables. Before I was emitting the
22385 code once for each fixed piece.
22388 2003-01-08 Martin Baulig <martin@ximian.com>
22390 * statement.cs (FlowBranching.MergeChild): A break in a
22391 SWITCH_SECTION does not leave a loop. Fixes #36155.
22393 2003-01-08 Martin Baulig <martin@ximian.com>
22395 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22396 lives in the same number space than `param_map'. Fixes #36154.
22398 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22400 * cs-parser.jay (constructor_declaration): Set the
22401 Constructor.ModFlags before probing for it. This makes the
22402 compiler report 514, 515 and 132 (the code was there, but got
22405 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22406 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22407 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22409 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22411 * enum.cs: create the enum static fields using the enum type.
22413 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22415 * class.cs: don't try to create the ParamBuilder for the return
22416 type if it's not needed (and handle it breaking for the ms runtime
22419 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22421 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22423 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22425 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22426 the command. This showed up while compiling the JANET source
22427 code, which used \r as its only newline separator.
22429 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22431 * class.cs (Method.Define): If we are an operator (because it
22432 reuses our code), then set the SpecialName and HideBySig. #36128
22434 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22436 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22437 exception, report error 120 `object reference required'.
22439 * driver.cs: Add --pause option, used during to measure the size
22440 of the process as it goes with --timestamp.
22442 * expression.cs (Invocation.DoResolve): Do not allow methods with
22443 SpecialName to be invoked.
22445 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22447 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22448 number before adding it.
22450 2002-12-21 Ravi Pratap <ravi@ximian.com>
22452 * ecore.cs (StandardImplicitConversion): When in an unsafe
22453 context, we allow conversion between void * to any other pointer
22454 type. This fixes bug #35973.
22456 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22458 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22459 is not thrown when extensionless outputs are used
22461 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22463 * rootcontext.cs: fixed compilation of corlib.
22465 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22467 * attribute.cs (Attributes.Contains): Add new method.
22469 * class.cs (MethodCore.LabelParameters): if the parameter is an
22470 `out' parameter, check that no attribute `[In]' has been passed.
22472 * enum.cs: Handle the `value__' name in an enumeration.
22474 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22476 * decl.cs: Added special case to allow overrides on "protected
22479 2002-12-18 Ravi Pratap <ravi@ximian.com>
22481 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22482 since it makes much more sense.
22484 (Attributes.ctor): Don't require a Location parameter.
22486 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22488 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22489 since we already have that information per attribute.
22491 * everywhere : make appropriate changes.
22493 * class.cs (LabelParameters): Write the code which actually
22494 applies attributes to the return type. We can't do this on the MS
22495 .NET runtime so we flag a warning in the case an exception is
22498 2002-12-18 Miguel de Icaza <miguel@ximian.com>
22500 * const.cs: Handle implicit null conversions here too.
22502 2002-12-17 Ravi Pratap <ravi@ximian.com>
22504 * class.cs (MethodCore.LabelParameters): Remove the extra
22505 Type [] parameter since it is completely unnecessary. Instead
22506 pass in the method's attributes so that we can extract
22507 the "return" attribute.
22509 2002-12-17 Miguel de Icaza <miguel@ximian.com>
22511 * cs-parser.jay (parse): Use Report.Error to flag errors instead
22512 of ignoring it and letting the compile continue.
22514 * typemanager.cs (ChangeType): use an extra argument to return an
22515 error condition instead of throwing an exception.
22517 2002-12-15 Miguel de Icaza <miguel@ximian.com>
22519 * expression.cs (Unary.TryReduce): mimic the code for the regular
22520 code path. Perform an implicit cast in the cases where we can
22521 implicitly convert to one of the integral types, and then reduce
22522 based on that constant. This fixes bug #35483.
22524 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22526 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
22528 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22530 * namespace.cs: fixed bug #35489.
22532 2002-12-12 Miguel de Icaza <miguel@ximian.com>
22534 * class.cs: Remove some dead code.
22536 * cs-parser.jay: Estimate the number of methods needed
22537 (RootContext.MethodCount);
22539 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
22540 numbers instead of StringBuilders.
22542 * support.cs (PtrHashtable): Add constructor with initial size;
22543 We can now reduce reallocations of the method table.
22545 2002-12-10 Ravi Pratap <ravi@ximian.com>
22547 * attribute.cs (ApplyAttributes): Keep track of the emitted
22548 attributes on a per-target basis. This fixes bug #35413.
22550 2002-12-10 Miguel de Icaza <miguel@ximian.com>
22552 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
22553 default to the Windows 1252 encoding.
22555 (UnixParseOption): Support version, thanks to Alp for the missing
22558 * AssemblyInfo.cs: Add nice assembly information.
22560 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
22563 * cs-parser.jay: Allow a trailing comma before the close bracked
22564 in the attribute_section production.
22566 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
22567 address of the instance was being taken, I will take this out,
22568 because we take the address of the object immediately here.
22570 2002-12-09 Ravi Pratap <ravi@ximian.com>
22572 * typemanager.cs (AreMultipleAllowed): Take care of the most
22573 obvious case where attribute type is not in the current assembly -
22576 2002-12-08 Miguel de Icaza <miguel@ximian.com>
22578 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
22579 definitions, instead of doing that afterwards.
22581 Also we use a nice little hack, depending on the constructor, we
22582 know if we are a "composed" name or a simple name. Hence, we
22583 avoid the IndexOf test, and we avoid
22585 * codegen.cs: Add code to assist in a bug reporter to track down
22586 the source of a compiler crash.
22588 2002-12-07 Ravi Pratap <ravi@ximian.com>
22590 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
22591 types have been emitted for a given element and flag an error
22592 if something which does not have AllowMultiple set is used more
22595 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
22596 attribute types and their corresponding AllowMultiple properties
22598 (AreMultipleAllowed): Check the property for a given type.
22600 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
22601 property in the case we have a TypeContainer.
22603 (Attributes.AddAttribute): Detect duplicates and just skip on
22604 adding them. This trivial fix catches a pretty gross error in our
22605 attribute emission - global attributes were being emitted twice!
22607 Bugzilla bug #33187 is now fixed.
22609 2002-12-06 Miguel de Icaza <miguel@ximian.com>
22611 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
22612 instead of pp_and).
22614 * expression.cs (Binary.ResolveOperator): I can only use the
22615 Concat (string, string, string) and Concat (string, string,
22616 string, string) if the child is actually a concatenation of
22619 2002-12-04 Miguel de Icaza <miguel@ximian.com>
22621 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
22622 context where we need a 2-character lookahead.
22624 * pending.cs (PendingImplementation): Rework so we can keep track
22625 of interface types all the time, and flag those which were
22626 implemented by parents as optional.
22628 2002-12-03 Miguel de Icaza <miguel@ximian.com>
22630 * expression.cs (Binary.ResolveOperator): Use
22631 String.Concat(string,string,string) or
22632 String.Concat(string,string,string,string) when possible.
22634 * typemanager: More helper methods.
22637 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
22639 * pending.cs: remove the bogus return from GetMissingInterfaces()
22640 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
22642 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22644 * namespace.cs: avoid duplicated 'using xxx' being added to
22645 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
22646 when we get more than one 'using' statement for the same namespace.
22647 Report a CS0105 warning for it.
22649 2002-11-30 Miguel de Icaza <miguel@ximian.com>
22651 * cs-tokenizer.cs (consume_identifier): use read directly, instead
22652 of calling getChar/putback, uses internal knowledge of it.
22654 (xtoken): Reorder tokenizer so most common patterns are checked
22655 first. This reduces the compilation time in another 5% (from 8.11s
22656 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
22658 The parsing time is 22% of the compilation in mcs, and from that
22659 64% is spent on the tokenization process.
22661 I tried using a binary search for keywords, but this is slower
22662 than the hashtable. Another option would be to do a couple of
22665 * Not use a StringBuilder, instead use an array of chars,
22666 with a set value. Notice that this way we could catch
22667 the 645 error without having to do it *afterwards*.
22669 * We could write a hand-parser to avoid the hashtable
22670 compares altogether.
22672 The identifier consumption process takes 37% of the tokenization
22673 time. Another 15% is spent on is_number. 56% of the time spent
22674 on is_number is spent on Int64.Parse:
22676 * We could probably choose based on the string length to
22677 use Int32.Parse or Int64.Parse and avoid all the 64-bit
22680 Another 3% is spend on wrapping `xtoken' in the `token' function.
22682 Handle 0xa0 as whitespace (#34752)
22684 2002-11-26 Miguel de Icaza <miguel@ximian.com>
22686 * typemanager.cs (IsCLRType): New routine to tell whether a type
22687 is one of the builtin types.
22689 Maybe it needs to use TypeCodes to be faster. Maybe we could use
22690 typecode in more places instead of doing pointer comparissions.
22691 We could leverage some knowledge about the way the typecodes are
22694 New code to cache namespaces in assemblies, it is currently not
22695 invoked, to be used soon.
22697 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
22699 * expression.cs (Binary.ResolveOperator): specially handle
22700 strings, and do not perform user-defined operator overloading for
22703 2002-11-24 Miguel de Icaza <miguel@ximian.com>
22705 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
22706 internalcall as it is a pretty simple operation; Avoid whenever
22707 possible to call Char.IsLetter.
22709 (consume_identifier): Cut by half the number of
22710 hashtable calls by merging the is_keyword and GetKeyword behavior.
22712 Do not short-circuit, because if we do, we
22713 report errors (ie, #if false && true would produce an invalid
22717 2002-11-24 Martin Baulig <martin@ximian.com>
22719 * expression.cs (Cast.TryReduce): If we're in checked syntax,
22720 check constant ranges and report a CS0221. Fixes #33186.
22722 2002-11-24 Martin Baulig <martin@ximian.com>
22724 * cs-parser.jay: Make this work for uninitialized variable
22725 declarations in the `for' initializer. Fixes #32416.
22727 2002-11-24 Martin Baulig <martin@ximian.com>
22729 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
22730 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
22732 2002-11-24 Martin Baulig <martin@ximian.com>
22734 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
22735 argument; if true, we also check for user-defined conversions.
22736 This is only needed if both arguments are of a user-defined type.
22737 Fixes #30443, added test-175.cs.
22738 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
22740 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
22742 2002-11-24 Martin Baulig <martin@ximian.com>
22744 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
22745 function to get the store opcode.
22746 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
22747 only emit the Ldelema if the store opcode is Stobj. You must run
22748 both test-34 and test-167 to test this. Fixes #34529.
22750 2002-11-23 Martin Baulig <martin@ximian.com>
22752 * ecore.cs (Expression.MemberLookup): Added additional
22753 `qualifier_type' argument which is used when we're being called
22754 from MemberAccess.DoResolve() and null if we're called from a
22756 (Expression.MemberLookupFailed): New method to report errors; this
22757 does the CS1540 check and reports the correct error message.
22759 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
22760 argument for the CS1540 check and redone the way how we're dealing
22761 with private members. See the comment in the source code for details.
22762 (FilterWithClosure): Reverted this back to revision 1.197; renamed
22763 `closure_start_type' to `closure_qualifier_type' and check whether
22764 it's not null. It was not this filter being broken, it was just
22765 being called with the wrong arguments.
22767 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
22768 and pass it the correct `qualifier_type'; this also does the error
22771 2002-11-22 Miguel de Icaza <miguel@ximian.com>
22773 * expression.cs (Invocation.EmitParams): If the we are dealing
22774 with a non-built-in value type, load its address as well.
22776 (ArrayCreation): Use a a pretty constant instead
22777 of the hardcoded value 2. Use 6 instead of 2 for the number of
22778 static initializers.
22780 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
22781 because they are not really value types, just glorified integers.
22783 * driver.cs: Do not append .exe, the CSC compiler does not do it.
22785 * ecore.cs: Remove redundant code for enumerations, make them use
22786 the same code path as everything else, fixes the casting issue
22787 with enumerations in Windows.Forms.
22789 * attribute.cs: Do only cast to string if it is a string, the
22790 validation happens later.
22792 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
22793 people upgrade their corlibs.
22795 * ecore.cs: Oops, enumerations were not following the entire code path
22797 2002-11-21 Miguel de Icaza <miguel@ximian.com>
22799 * typemanager.cs (FilterWithClosure): Commented out the test for
22800 1540 in typemanager.cs, as it has problems when accessing
22801 protected methods from a parent class (see test-174.cs).
22803 * attribute.cs (Attribute.ValidateGuid): new method.
22804 (Attribute.Resolve): Use above.
22806 2002-11-19 Miguel de Icaza <miguel@ximian.com>
22808 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
22810 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
22811 handling for enumerations, as we only needed the TypeContainer
22812 functionality to begin with (this is required for the fix below to
22813 work for enums that reference constants in a container class for
22816 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
22818 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
22819 a valid TypeBuilder to perform lookups on.o
22821 * class.cs (InheritableMemberSignatureCompare): Use true in the
22822 call to GetGetMethod and GetSetMethod, because we are comparing
22823 the signature, and we need to get the methods *even* if they are
22826 (PropertyBase.CheckBase): ditto.
22828 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
22829 GotoCase.Resolve): Use Peel on EmpytCasts.
22831 * ecore.cs (EmptyCast): drop child, add Peel method.
22833 2002-11-17 Martin Baulig <martin@ximian.com>
22835 * ecore.cs (EmptyCast.Child): New public property.
22837 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
22838 label resolved to an EmptyCast. Fixes #34162.
22839 (GotoCase.Resolve): Likewise.
22840 (Block.EmitMeta): Likewise.
22842 2002-11-17 Martin Baulig <martin@ximian.com>
22844 * expression.cs (Invocation.BetterConversion): Prefer int over
22845 uint; short over ushort; long over ulong for integer literals.
22846 Use ImplicitConversionExists instead of StandardConversionExists
22847 since we also need to check for user-defined implicit conversions.
22848 Fixes #34165. Added test-173.cs.
22850 2002-11-16 Martin Baulig <martin@ximian.com>
22852 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
22853 with the `true' and `false' literals. Fixes #33151.
22855 2002-11-16 Martin Baulig <martin@ximian.com>
22857 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
22858 October 22nd; don't do the cs1540 check for static members.
22860 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
22861 now using our own filter here and doing the cs1540 check again.
22863 2002-11-16 Martin Baulig <martin@ximian.com>
22865 * support.cs (InternalParameters): Don't crash if we don't have
22866 any fixed parameters. Fixes #33532.
22868 2002-11-16 Martin Baulig <martin@ximian.com>
22870 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
22871 when looking up static methods to make this work on Windows.
22874 2002-11-16 Martin Baulig <martin@ximian.com>
22876 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
22877 a setter rather than using PropertyInfo.CanWrite.
22879 2002-11-15 Nick Drochak <ndrochak@gol.com>
22881 * class.cs: Allow acces to block member by subclasses. Fixes build
22884 2002-11-14 Martin Baulig <martin@ximian.com>
22886 * class.cs (Constructor.Emit): Added the extern/block check.
22889 2002-11-14 Martin Baulig <martin@ximian.com>
22891 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
22892 iteration while looking for indexers, this is needed because the
22893 indexer may have a different name in our base classes. Fixed the
22894 error reporting (no indexers at all, not get accessor, no
22895 overloaded match). Fixes bug #33089.
22896 (IndexerAccess.DoResolveLValue): Likewise.
22898 2002-11-14 Martin Baulig <martin@ximian.com>
22900 * class.cs (PropertyBase.CheckBase): Make this work for multiple
22901 indexers. Fixes the first part of bug #33089.
22902 (MethodSignature.InheritableMemberSignatureCompare): Added support
22905 2002-11-13 Ravi Pratap <ravi@ximian.com>
22907 * attribute.cs (Attribute.Resolve): Catch the
22908 NullReferenceException and report it since it isn't supposed to
22911 2002-11-12 Miguel de Icaza <miguel@ximian.com>
22913 * expression.cs (Binary.EmitBranchable): Also handle the cases for
22914 LogicalOr and LogicalAnd that can benefit from recursively
22915 handling EmitBranchable. The code now should be nice for Paolo.
22917 2002-11-08 Miguel de Icaza <miguel@ximian.com>
22919 * typemanager.cs (LookupType): Added a negative-hit hashtable for
22920 the Type lookups, as we perform quite a number of lookups on
22921 non-Types. This can be removed once we can deterministically tell
22922 whether we have a type or a namespace in advance.
22924 But this might require special hacks from our corlib.
22928 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
22929 and double which avoids a conversion from an integer to a double.
22931 * expression.cs: tiny optimization, avoid calling IsConstant,
22932 because it effectively performs the lookup twice.
22934 2002-11-06 Miguel de Icaza <miguel@ximian.com>
22936 But a bogus return here to keep the semantics of the old code
22937 until the Mono runtime is fixed.
22939 * pending.cs (GetMissingInterfaces): New method used to remove all
22940 the interfaces that are already implemented by our parent
22941 classes from the list of pending methods.
22943 * interface.cs: Add checks for calls after ResolveTypeExpr.
22945 2002-11-05 Miguel de Icaza <miguel@ximian.com>
22947 * class.cs (Class.Emit): Report warning 67: event not used if the
22948 warning level is beyond 3.
22950 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
22951 being a NullLiteral.
22953 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
22956 * class.cs (TypeContainer.GetClassBases): Cover a missing code
22957 path that might fail if a type can not be resolved.
22959 * expression.cs (Binary.Emit): Emit unsigned versions of the
22962 * driver.cs: use error 5.
22964 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
22966 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
22968 2002-11-01 Miguel de Icaza <miguel@ximian.com>
22970 * cs-parser.jay (switch_section): A beautiful patch from Martin
22971 Baulig that fixed 33094.
22973 2002-10-31 Miguel de Icaza <miguel@ximian.com>
22975 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
22976 Check whether the base is abstract and report an error if so.
22978 * expression.cs (IndexerAccess.DoResolveLValue,
22979 IndexerAccess.DoResolve): ditto.
22981 (Invocation.DoResolve): ditto.
22983 (Invocation.FullMethodDesc): Improve the report string.
22985 * statement.cs (Block): Eliminate IsVariableDefined as it is
22986 basically just a wrapper for GetVariableInfo.
22988 * ecore.cs (SimpleName): Use new
22990 * support.cs (ReflectionParamter.ParameterType): We unwrap the
22991 type, as we return the actual parameter ref/unref state on a
22994 2002-10-30 Miguel de Icaza <miguel@ximian.com>
22996 * support.cs: Return proper flags REF/OUT fixing the previous
22999 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23000 not used to mean `ref' but `ref or out' in ParameterReference
23002 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23003 full type signature instead of calling TypeManger.CSharpName
23006 * support.cs (InternalParameters.ParameterDesc): Do not compare
23007 directly to the modflags, because REF/OUT will actually be bitsets
23010 * delegate.cs (VerifyMethod): Check also the modifiers.
23012 * cs-tokenizer.cs: Fix bug where floating point values with an
23013 exponent where a sign was missing was ignored.
23015 * driver.cs: Allow multiple assemblies to be specified in a single
23018 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23020 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23021 because identifiers after a parenthesis would end up in this kind
23022 of production, and we needed to desamiguate it for having casts
23025 (UserDefinedType *) xxx
23027 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23029 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23030 we should set on the Bindingflags.NonPublic, but not turn on
23031 private_ok. private_ok controls whether a Private member is
23032 returned (this is chekced on the filter routine), while the
23033 BindingFlags.NonPublic just controls whether private/protected
23034 will be allowed. This fixes the problem part of the problem of
23035 private properties being allowed to be used in derived classes.
23037 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23038 so we can call the children DoResolveLValue method (this will
23039 properly signal errors on lvalue assignments to base properties)
23041 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23042 getter are null, and we have a property info, we know that this
23043 happened because the lookup failed, so we report an error 122 for
23044 protection level violation.
23046 We also silently return if setter and getter are null in the
23047 resolve functions, this condition only happens if we have flagged
23048 the error before. This is the other half of the problem.
23050 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23051 not have accessibility information, that is why we were returning
23052 true in the filter function in typemanager.cs.
23054 To properly report 122 (property is inaccessible because of its
23055 protection level) correctly, we report this error in ResolveAccess
23056 by failing if both the setter and the getter are lacking (ie, the
23059 DoResolve and DoLResolve have been modified to check for both
23060 setter/getter being null and returning silently, the reason being
23061 that I did not want to put the knowledge about this error in upper
23064 int old = Report.Errors;
23065 x = new PropertyExpr (...);
23066 if (old != Report.Errors)
23071 So the property expr is returned, but it is invalid, so the error
23072 will be flagged during the resolve process.
23074 * class.cs: Remove InheritablePropertySignatureCompare from the
23075 class, as we no longer depend on the property signature to compute
23076 whether it is possible to implement a method or not.
23078 The reason is that calling PropertyInfo.GetGetMethod will return
23079 null (in .NET, in Mono it works, and we should change this), in
23080 cases where the Get Method does not exist in that particular
23085 class X { public virtual int A { get { return 1; } } }
23087 class Z : Y { public override int A { get { return 2; } } }
23089 Would fail in Z because the parent (Y) would not have the property
23090 defined. So we avoid this completely now (because the alternative
23091 fix was ugly and slow), and we now depend exclusively on the
23094 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23095 reference method, instead of using the property.
23097 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23098 routines are gone now.
23100 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23101 names, they were incorrectly named.
23103 * cs-tokenizer.cs: Return are more gentle token on failure.
23105 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23106 had an out-of-sync index variable, which caused it to remove from
23107 the list of pending methods the wrong method sometimes.
23109 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23111 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23112 CanWrite, because those refer to this particular instance of the
23113 property, and do not take into account the fact that we can
23114 override single members of a property.
23116 Constructor requires an EmitContext. The resolution process does
23117 not happen here, but we need to compute the accessors before,
23118 because the resolution does not always happen for properties.
23120 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23121 subclass, before we did not update this flag, but we did update
23124 (GetAccessors): Drop this routine, as it did not work in the
23125 presence of partially overwritten set/get methods.
23127 Notice that this broke the cs1540 detection, but that will require
23130 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23134 * driver.cs: issue a warning instead of an error if we don't support
23135 debugging for the platform. Also ignore a couple of errors that may
23136 arise when trying to write the symbols. Undo my previous patch.
23138 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23140 * driver.cs: ignore /debug switch except for Unix platforms.
23142 2002-10-23 Nick Drochak <ndrochak@gol.com>
23144 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23146 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23148 * driver.cs: Do not make mcs-debug conditional, so we do not break
23149 builds that use it.
23151 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23152 review this patch. But basically after all the children variables
23153 have been merged, the value of "Breaks" was not being set to
23154 new_breaks for Switch blocks. I think that it should be set after
23155 it has executed. Currently I set this to the value of new_breaks,
23156 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23157 conservative, but I do not understand this code very well.
23159 I did not break anything in the build, so that is good ;-)
23161 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23163 2002-10-20 Mark Crichton <crichton@gimp.org>
23165 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23167 2002-10-20 Nick Drochak <ndrochak@gol.com>
23169 * cfold.cs: Fixed compile blocker.
23171 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23173 * driver.cs: I was chekcing the key, not the file.
23175 2002-10-19 Ravi Pratap <ravi@ximian.com>
23177 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23178 message that we were generating - we just need to silently return
23181 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23183 * class.cs (Event.Define): Change my previous commit, as this
23184 breaks the debugger. This is a temporary hack, as it seems like
23185 the compiler is generating events incorrectly to begin with.
23187 * expression.cs (Binary.ResolveOperator): Added support for
23188 "U operator - (E x, E y)"
23190 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23193 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23194 init-only variables, but this path did not take into account that
23195 there might be also instance readonly variables. Correct this
23198 This fixes bug 32253
23200 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23203 * driver.cs: Change the extension for modules to `netmodule'
23205 * cs-parser.jay: Improved slightly the location tracking for
23206 the debugger symbols.
23208 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23209 modifiers that were specified instead of the hardcoded value
23210 (FamAndAssem). This was basically ignoring the static modifier,
23211 and others. Fixes 32429.
23213 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23214 fixed a bug in the process (32476)
23216 * expression.cs (ArrayAccess.EmitAssign): Patch from
23217 hwang_rob@yahoo.ca that fixes bug 31834.3
23219 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23221 * driver.cs: Make the module extension .netmodule.
23223 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23225 * driver.cs: Report an error if the resource file is not found
23226 instead of crashing.
23228 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23229 false, like Emit does.
23231 2002-10-16 Nick Drochak <ndrochak@gol.com>
23233 * typemanager.cs: Remove unused private member. Also reported mcs
23234 bug to report this as a warning like csc.
23236 2002-10-15 Martin Baulig <martin@gnome.org>
23238 * statement.cs (Statement.Emit): Made this a virtual method; emits
23239 the line number info and calls DoEmit().
23240 (Statement.DoEmit): New protected abstract method, formerly knows
23241 as Statement.Emit().
23243 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23245 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23247 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23248 have fixed a remaining problem: not every AddXXXX was adding a
23249 fully qualified name.
23251 Now everyone registers a fully qualified name in the DeclSpace as
23252 being defined instead of the partial name.
23254 Downsides: we are slower than we need to be due to the excess
23255 copies and the names being registered this way.
23257 The reason for this is that we currently depend (on the corlib
23258 bootstrap for instance) that types are fully qualified, because
23259 we dump all the types in the namespace, and we should really have
23260 types inserted into the proper namespace, so we can only store the
23261 basenames in the defined_names array.
23263 2002-10-10 Martin Baulig <martin@gnome.org>
23265 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23266 from bug #31834, see the bug report for a testcase which is
23269 2002-10-10 Martin Baulig <martin@gnome.org>
23271 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23272 flow analysis code for this.
23274 * statement.cs (Do, While, For): Tell the flow analysis code about
23276 (FlowBranching.UsageVector): Added support for infinite loops.
23277 (Block.Resolve): Moved the dead code elimination here and use flow
23280 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23282 * class.cs (Field.Define): Catch cycles on struct type
23285 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23286 fields if the fields are static. We only need to check instance
23289 * expression.cs (As.DoResolve): Test for reference type.
23291 * statement.cs (Using.ResolveExpression): Use
23292 ConvertImplicitRequired, not ConvertImplicit which reports an
23294 (Using.ResolveLocalVariableDecls): ditto.
23296 * expression.cs (Binary.ResolveOperator): Report errors in a few
23297 places where we had to.
23299 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23301 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23303 * expression.cs: Use StoreFromPtr instead of extracting the type
23304 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23306 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23307 an enumeration value to a System.Enum, but System.Enum is not a
23308 value type, but an class type, so we need to box.
23310 (Expression.ConvertExplicit): One codepath could return
23311 errors but not flag them. Fix this. Fixes #31853
23313 * parameter.cs (Resolve): Do not allow void as a parameter type.
23315 2002-10-06 Martin Baulig <martin@gnome.org>
23317 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23318 if it's a class type and not a struct. Fixes #31815.
23320 2002-10-06 Martin Baulig <martin@gnome.org>
23322 * statement.cs: Reworked the flow analysis code a bit to make it
23323 usable for dead code elimination.
23325 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23327 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23329 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23331 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23332 to fix the test 165, will investigate deeper.
23334 2002-10-04 Martin Baulig <martin@gnome.org>
23336 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23337 finally blocks actually work.
23338 (Try.Resolve): We don't need to create a sibling for `finally' if
23339 there is no finally block.
23341 2002-10-04 Martin Baulig <martin@gnome.org>
23343 * class.cs (Constructor.Define): The default accessibility for a
23344 non-default constructor is private, not public.
23346 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23348 * class.cs (Constructor): Make AllowedModifiers public, add
23351 * cs-parser.jay: Perform the modifiers test here, as the
23352 constructor for the Constructor class usually receives a zero
23353 because of the way we create it (first we create, later we
23354 customize, and we were never checking the modifiers).
23356 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23357 is a version of LookupTypeReflection that includes the type-name
23358 cache. This can be used as a fast path for functions that know
23359 the fully qualified name and are only calling into *.GetType() to
23360 obtain a composed type.
23362 This is also used by TypeManager.LookupType during its type
23365 (LookupType): We now also track the real type name, as sometimes
23366 we can get a quey for the real type name from things like
23367 ComposedCast. This fixes bug 31422.
23369 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23370 complete type fullname, it does not have to go through the type
23371 resolution system to obtain the composed version of the type (for
23372 obtaining arrays or pointers).
23374 (Conditional.Emit): Use the EmitBoolExpression to
23375 generate nicer code, as requested by Paolo.
23377 (ArrayCreation.CheckIndices): Use the patch from
23378 hwang_rob@yahoo.ca to validate the array initializers.
23380 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23382 * class.cs (ConstructorInitializer.Emit): simplify code by using
23383 Invocation.EmitCall, and at the same time, fix the bugs in calling
23384 parent constructors that took variable arguments.
23386 * ecore.cs (Expression.ConvertNumericExplicit,
23387 Expression.ImplicitNumericConversion): Remove the code that
23388 manually wrapped decimal (InternalTypeConstructor call is now gone
23391 * expression.cs (Cast.TryReduce): Also handle decimal types when
23392 trying to perform a constant fold on the type.
23394 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23396 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23397 that only turned off an error report, and did nothing else.
23399 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23401 * driver.cs: Handle and ignore /fullpaths
23403 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23405 * expression.cs (Binary.ResolveOperator): Catch the case where
23406 DoNumericPromotions returns true,
23408 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23410 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23412 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23415 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23417 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23418 conversion exists, but it is also required that the conversion be
23419 performed. This manifested in "(Type64Enum) 2".
23421 * class.cs (TypeManager.AddMethod): The fix is not to change
23422 AddEnum, because that one was using a fully qualified name (every
23423 DeclSpace derivative does), but to change the AddMethod routine
23424 that was using an un-namespaced name. This now correctly reports
23425 the duplicated name.
23427 Revert patch until I can properly fix it. The issue
23428 is that we have a shared Type space across all namespaces
23429 currently, which is wrong.
23431 Options include making the Namespace a DeclSpace, and merge
23432 current_namespace/current_container in the parser.
23434 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23436 * cs-parser.jay: Improve error reporting when we get a different
23437 kind of expression in local_variable_type and
23438 local_variable_pointer_type.
23440 Propagate this to avoid missleading errors being reported.
23442 * ecore.cs (ImplicitReferenceConversion): treat
23443 TypeManager.value_type as a target just like object_type. As
23448 Is valid, and needs to result in the int 1 being boxed before it
23449 is assigned to the value type v.
23451 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23452 to validate the enumeration name.
23454 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23455 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23456 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23458 * ecore.cs (TryImplicitIntConversion): When doing an
23459 implicit-enumeration-conversion, check if the type is 64-bits and
23460 perform a conversion before passing to EnumConstant.
23462 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23464 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23465 report ambiguous type references. Unlike the MS version, we
23466 report what the ambiguity is. Innovation at work ;-)
23468 (DeclSpace.FindType): Require a location argument to
23469 display when we display an ambiguous error.
23471 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23473 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23475 * expression.cs (EmitDynamicInitializers): Apply patch from
23476 hwang_rob@yahoo.ca that fixes the order in which we emit our
23479 2002-09-21 Martin Baulig <martin@gnome.org>
23481 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23482 delegate takes no arguments.
23484 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23486 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23489 * expression.cs: Extract the underlying type.
23491 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
23493 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
23495 2002-09-19 Miguel de Icaza <miguel@ximian.com>
23497 * class.cs (TypeContainer.DefineType): We can not use the nice
23498 PackingSize with the size set to 1 DefineType method, because it
23499 will not allow us to define the interfaces that the struct
23502 This completes the fixing of bug 27287
23504 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
23505 means also structs. This fixes part of the problem.
23506 (Expresion.ImplicitReferenceConversionExists): ditto.
23508 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
23509 error if there were no errors reported during the type lookup
23510 process, to avoid duplicates or redundant errors. Without this
23511 you would get an ambiguous errors plus a type not found. We have
23512 beaten the user enough with the first error.
23514 (DeclSparce.FindType): Emit a warning if we have an ambiguous
23517 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
23518 during the resolution process, stop the lookup, this avoids
23519 repeated error reports (same error twice).
23521 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
23523 * typemanager.cs (LookupType): Redo the type lookup code to match
23524 the needs of System.Reflection.
23526 The issue is that System.Reflection requires references to nested
23527 types to begin with a "+" sign instead of a dot. So toplevel
23528 types look like: "NameSpace.TopLevelClass", and nested ones look
23529 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
23532 2002-09-19 Martin Baulig <martin@gnome.org>
23534 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
23535 says that a method always returns or always throws an exception,
23536 don't report the CS0161.
23538 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
23539 set `Returns = new_returns'.
23541 2002-09-19 Martin Baulig <martin@gnome.org>
23543 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
23544 to an enum constant, check for a CS0176.
23546 2002-09-18 Miguel de Icaza <miguel@ximian.com>
23548 * class.cs (TypeContainer.CheckPairedOperators): Now we check
23549 for operators that must be in pairs and report errors.
23551 * ecore.cs (SimpleName.DoResolveType): During the initial type
23552 resolution process, when we define types recursively, we must
23553 check first for types in our current scope before we perform
23554 lookups in the enclosing scopes.
23556 * expression.cs (MakeByteBlob): Handle Decimal blobs.
23558 (Invocation.VerifyArgumentsCompat): Call
23559 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
23560 I thought we were supposed to always call this, but there are a
23561 few places in the code where we dont do it.
23563 2002-09-17 Miguel de Icaza <miguel@ximian.com>
23565 * driver.cs: Add support in -linkres and -resource to specify the
23566 name of the identifier.
23568 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23570 * ecore.cs (StandardConversionExists): Sync with the conversion
23571 code: allow anything-* to void* conversions.
23573 (FindMostSpecificSource): Use an Expression argument
23574 instead of a Type, because we might be handed over a Literal which
23575 gets a few more implicit conversions that plain types do not. So
23576 this information was being lost.
23578 Also, we drop the temporary type-holder expression when not
23581 2002-09-17 Martin Baulig <martin@gnome.org>
23583 * class.cs (PropertyBase.CheckBase): Don't check the base class if
23584 this is an explicit interface implementation.
23586 2002-09-17 Martin Baulig <martin@gnome.org>
23588 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
23589 different `IndexerName' attributes.
23591 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
23592 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
23593 virtual CommonResolve().
23595 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23597 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
23598 and convert that to the UnderlyingType.
23600 * statement.cs (Foreach.Resolve): Indexers are just like variables
23601 or PropertyAccesses.
23603 * cs-tokenizer.cs (consume_string): Track line numbers and columns
23604 inside quoted strings, we were not doing this before.
23606 2002-09-16 Martin Baulig <martin@gnome.org>
23608 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
23609 resolve it. This is needed for the definite assignment check of the
23610 instance expression, fixes bug #29846.
23611 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
23613 2002-09-16 Nick Drochak <ndrochak@gol.com>
23615 * parameter.cs: Fix compile error. Cannot reference static member
23616 from an instance object. Is this an mcs bug?
23618 2002-09-14 Martin Baulig <martin@gnome.org>
23620 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
23621 multiple times. Fixes bug #30295, added test-166.cs.
23623 2002-09-14 Martin Baulig <martin@gnome.org>
23625 * statement.cs (Block.Emit): Don't emit unreachable code.
23626 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
23627 `break' statements.
23628 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
23630 2002-09-14 Martin Baulig <martin@gnome.org>
23632 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
23635 2002-09-14 Martin Baulig <martin@gnome.org>
23637 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
23638 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
23639 be false on the ms runtime.
23641 2002-09-13 Martin Baulig <martin@gnome.org>
23643 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
23644 the CS0038 error message.
23646 2002-09-12 Miguel de Icaza <miguel@ximian.com>
23648 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
23649 constant inside, return it.
23651 2002-09-12 Martin Baulig <martin@gnome.org>
23653 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
23654 implicit conversion can be done between enum types.
23656 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
23657 check whether an implicit conversion to the current enum's UnderlyingType
23658 exists and report an error if not.
23660 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
23661 without debugging support.
23663 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
23664 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
23666 2002-09-12 Martin Baulig <martin@gnome.org>
23668 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
23670 * ecore.cs (IMemberExpr.DeclaringType): New property.
23671 (SimpleName.SimpleNameResolve): Check whether we're accessing a
23672 nonstatic member of an outer type (CS0038).
23674 2002-09-11 Miguel de Icaza <miguel@ximian.com>
23676 * driver.cs: Activate the using-error detector at warning level
23677 4 (at least for MS-compatible APIs).
23679 * namespace.cs (VerifyUsing): Small buglett fix.
23681 * pending.cs (PendingImplementation): pass the container pointer.
23683 * interface.cs (GetMethods): Allow for recursive definition. Long
23684 term, I would like to move every type to support recursive
23685 definitions, not the current ordering mechanism that we have right
23688 The situation is this: Attributes are handled before interfaces,
23689 so we can apply attributes to interfaces. But some attributes
23690 implement interfaces, we will now handle the simple cases
23691 (recursive definitions will just get an error).
23693 * parameter.cs: Only invalidate types at the end if we fail to
23696 2002-09-09 Martin Baulig <martin@gnome.org>
23698 * ecore.cs (PropertyExpr.Emit): Also check for
23699 TypeManager.system_int_array_get_length so this'll also work when
23700 compiling corlib. Fixes #30003.
23702 2002-09-09 Martin Baulig <martin@gnome.org>
23704 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
23705 and throw an exception if we can't get the type's size. Fixed #30040,
23708 2002-09-09 Martin Baulig <martin@gnome.org>
23710 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
23712 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
23713 context. Fixes bug #30027.
23715 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
23716 virtual functions. Fixes bug #30043, added test-164.cs.
23718 2002-09-08 Ravi Pratap <ravi@ximian.com>
23720 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
23722 2002-09-08 Nick Drochak <ndrochak@gol.com>
23724 * driver.cs: Use an object to get the windows codepage since it's not a
23727 2002-09-08 Miguel de Icaza <miguel@ximian.com>
23729 * statement.cs (For.Emit): for infinite loops (test == null)
23730 return whether there is a break inside, not always "true".
23732 * namespace.cs (UsingEntry): New struct to hold the name of the
23733 using definition, the location where it is defined, and whether it
23734 has been used in a successful type lookup.
23736 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
23741 2002-09-06 Ravi Pratap <ravi@ximian.com>
23743 * attribute.cs : Fix incorrect code which relied on catching
23744 a NullReferenceException to detect a null being passed in
23745 where an object was expected.
23747 2002-09-06 Miguel de Icaza <miguel@ximian.com>
23749 * statement.cs (Try): flag the catch variable as assigned
23751 * expression.cs (Cast): Simplified by using ResolveType instead of
23752 manually resolving.
23754 * statement.cs (Catch): Fix bug by using ResolveType.
23756 2002-09-06 Ravi Pratap <ravi@ximian.com>
23758 * expression.cs (BetterConversion): Special case for when we have
23759 a NullLiteral as the argument and we have to choose between string
23760 and object types - we choose string the way csc does.
23762 * attribute.cs (Attribute.Resolve): Catch the
23763 NullReferenceException and report error #182 since the Mono
23764 runtime no more has the bug and having this exception raised means
23765 we tried to select a constructor which takes an object and is
23768 2002-09-05 Ravi Pratap <ravi@ximian.com>
23770 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
23771 message (1502, 1503) when we can't locate a method after overload
23772 resolution. This is much more informative and closes the bug
23775 * interface.cs (PopulateMethod): Return if there are no argument
23776 types. Fixes a NullReferenceException bug.
23778 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
23779 expressions too. Previously we were checking only in one place for
23780 positional arguments leaving out named arguments.
23782 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
23783 type to the enum type is not allowed. Remove code corresponding to
23786 (ConvertNumericExplicit): Allow explicit conversions from
23787 the underlying type to enum type. This precisely follows the spec
23788 and closes a bug filed by Gonzalo.
23790 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23793 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
23795 2002-09-03 Miguel de Icaza <miguel@ximian.com>
23797 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
23798 it was important that we stored the right value after the
23799 reduction in `converted'.
23801 2002-09-04 Martin Baulig <martin@gnome.org>
23803 * location.cs (Location.SymbolDocument): Use full pathnames for the
23806 2002-08-30 Miguel de Icaza <miguel@ximian.com>
23808 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
23809 of the expression resolve mechanism, because that will catch the
23810 SimpleName error failures.
23812 (Conditional): If we can not resolve the
23813 expression, return, do not crash.
23815 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23818 (location): display token name instead of its number.
23820 2002-08-28 Martin Baulig <martin@gnome.org>
23822 * expression.cs (Binary.ResolveOperator): Don't silently return
23823 but return an error if an operator cannot be applied between two
23826 2002-08-28 Martin Baulig <martin@gnome.org>
23828 * class.cs (Constructor.Define): Set the permission attributes
23829 correctly instead of making all constructors public.
23831 2002-08-28 Martin Baulig <martin@gnome.org>
23833 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
23834 for private members before reporting a CS0103; if we find anything,
23837 2002-08-28 Martin Baulig <martin@gnome.org>
23839 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
23840 to check whether `closure_start_type == closure_invocation_type',
23841 we also need to check whether `m.DeclaringType == closure_invocation_type'
23842 before bypassing the permission checks. We might be accessing
23843 protected/private members from the base class.
23844 (TypeManager.RealMemberLookup): Only set private_ok if private
23845 members were requested via BindingFlags.NonPublic.
23847 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
23849 * expression.cs (MemberAccess.ResolveMemberAccess): Set
23850 MethodGroupExpr.IsExplicitImpl if appropriate.
23851 (Invocation.DoResolve): Don't report the CS0120 for explicit
23852 interface implementations.
23854 2002-08-27 Martin Baulig <martin@gnome.org>
23856 * expression.cs (Invocation.DoResolve): If this is a static
23857 method and we don't have an InstanceExpression, we must report
23860 2002-08-25 Martin Baulig <martin@gnome.org>
23862 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
23863 `==' between a valuetype and an object.
23865 2002-08-25 Miguel de Icaza <miguel@ximian.com>
23867 * ecore.cs (TypeExpr): Provide a ToString method.
23869 2002-08-24 Martin Baulig <martin@gnome.org>
23871 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
23872 now called proggie.dbg and it's a binary file.
23874 2002-08-23 Martin Baulig <martin@gnome.org>
23876 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
23878 2002-08-23 Martin Baulig <martin@gnome.org>
23880 * struct.cs (MyStructInfo.ctor): Make this work with empty
23881 structs; it's not allowed to use foreach() on null.
23883 2002-08-23 Martin Baulig <martin@gnome.org>
23885 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
23886 writer the full pathname of the generated assembly.
23888 2002-08-23 Martin Baulig <martin@gnome.org>
23890 * statements.cs (FlowBranching.UsageVector.MergeChildren):
23891 A `finally' block never returns or breaks; improved handling of
23894 2002-08-23 Martin Baulig <martin@gnome.org>
23896 * statement.cs (Throw.Resolve): Allow `throw null'.
23898 2002-08-23 Martin Baulig <martin@gnome.org>
23900 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
23901 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
23902 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
23903 MemberLookup would return a wrong event if this is an explicit
23904 interface implementation and the class has an event with the same
23907 2002-08-23 Martin Baulig <martin@gnome.org>
23909 * statement.cs (Block.AddChildVariableNames): New public method.
23910 (Block.AddChildVariableName): Likewise.
23911 (Block.IsVariableNameUsedInChildBlock): Likewise.
23912 (Block.AddVariable): Check whether a variable name has already
23913 been used in a child block.
23915 * cs-parser.jay (declare_local_variables): Mark all variable names
23916 from the current block as being used in a child block in the
23919 2002-08-23 Martin Baulig <martin@gnome.org>
23921 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
23922 find the symbol writer.
23924 * driver.cs: csc also allows the arguments to /define being
23925 separated by commas, not only by semicolons.
23927 2002-08-23 Martin Baulig <martin@gnome.org>
23929 * interface.cs (Interface.GetMembers): Added static check for events.
23931 2002-08-15 Martin Baulig <martin@gnome.org>
23933 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
23934 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
23936 * ecore.cs (Expression.MemberLookup): Added documentation and explained
23937 why the MethodData.EmitDestructor() change was necessary.
23939 2002-08-20 Martin Baulig <martin@gnome.org>
23941 * class.cs (TypeContainer.FindMembers): Added static check for events.
23943 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
23945 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
23946 use Type.GetEvents(), not Type.FindMembers().
23948 2002-08-20 Martin Baulig <martin@gnome.org>
23950 * decl.cs (MemberCache): Added a special method cache which will
23951 be used for method-only searched. This ensures that a method
23952 search will return a MethodInfo with the correct ReflectedType for
23955 2002-08-20 Martin Baulig <martin@gnome.org>
23957 * decl.cs (DeclSpace.FindMembers): Made this public.
23959 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23961 * delegate.cs: fixed build on windows.
23962 [FIXME: Filed as bug #29150: MCS must report these errors.]
23964 2002-08-19 Ravi Pratap <ravi@ximian.com>
23966 * ecore.cs (StandardConversionExists): Return a false
23967 if we are trying to convert the void type to anything else
23968 since that is not allowed.
23970 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
23971 we flag error 70 in the event an event is trying to be accessed
23972 directly from outside the declaring type.
23974 2002-08-20 Martin Baulig <martin@gnome.org>
23976 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
23977 MemberCache from typemanager.cs to decl.cs.
23979 2002-08-19 Martin Baulig <martin@gnome.org>
23981 * class.cs (TypeContainer): Implement IMemberContainer.
23982 (TypeContainer.DefineMembers): Create the MemberCache.
23983 (TypeContainer.FindMembers): Do better BindingFlags checking; only
23984 return public members if BindingFlags.Public was given, check
23985 whether members are static.
23987 2002-08-16 Martin Baulig <martin@gnome.org>
23989 * decl.cs (DeclSpace.Define): Splitted this in Define and
23990 DefineMembers. DefineMembers is called first and initializes the
23993 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
23994 DefineMembers() on all our DeclSpaces.
23996 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
23997 but call DefineMembers() on all nested interfaces. We call their
23998 Define() in our new Define() function.
24000 * interface.cs (Interface): Implement IMemberContainer.
24001 (Interface.Define): Moved all code except the attribute stuf to
24003 (Interface.DefineMembers): Initialize the member cache.
24005 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24006 need this anymore since we can use MemberCache.FindMembers directly.
24008 2002-08-19 Martin Baulig <martin@gnome.org>
24010 * typemanager.cs (MemberCache): When creating the cache for an
24011 interface type, add all inherited members.
24012 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24013 to `out bool used_cache' and documented it.
24014 (TypeManager.MemberLookup): If we already used the cache in the first
24015 iteration, we don't need to do the interfaces check.
24017 2002-08-19 Martin Baulig <martin@gnome.org>
24019 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24020 here from IMemberFinder and don't implement this interface anymore.
24021 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24023 * typemanager.cs (IMemberFinder): This interface is now only used by
24024 classes which actually support the member cache.
24025 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24026 since we only put DeclSpaces into this Hashtable.
24027 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24028 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24030 2002-08-16 Martin Baulig <martin@gnome.org>
24032 * typemanager.cs (ICachingMemberFinder): Removed.
24033 (IMemberFinder.MemberCache): New property.
24034 (TypeManager.FindMembers): Merged this with RealFindMembers().
24035 This function will never be called from TypeManager.MemberLookup()
24036 so we can't use the cache here, just the IMemberFinder.
24037 (TypeManager.MemberLookup_FindMembers): Check whether the
24038 IMemberFinder has a MemberCache and call the cache's FindMembers
24040 (MemberCache): Rewrote larger parts of this yet another time and
24041 cleaned it up a bit.
24043 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24045 * driver.cs (LoadArgs): Support quoting.
24047 (Usage): Show the CSC-like command line arguments.
24049 Improved a few error messages.
24051 2002-08-15 Martin Baulig <martin@gnome.org>
24053 * typemanager.cs (IMemberContainer.Type): New property.
24054 (IMemberContainer.IsInterface): New property.
24056 The following changes are conditional to BROKEN_RUNTIME, which is
24057 defined at the top of the file.
24059 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24060 class'es members, but add all members from TypeHandle.ObjectType
24061 if we're an interface.
24062 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24063 is the current type.
24064 (MemberCache.CacheEntry.Container): Removed this field.
24065 (TypeHandle.GetMembers): Include inherited members.
24067 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24069 * typemanager.cs: fixed compilation and added a comment on a field that
24072 2002-08-15 Martin Baulig <martin@gnome.org>
24074 * class.cs (ConstructorInitializer.Resolve): In the
24075 Expression.MemberLookup call, use the queried_type as
24078 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24079 declared' attribute, it's always true.
24080 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24081 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24082 temporary wrapper for FindMembers which tells MemberLookup whether
24083 members from the base classes are included in the return value.
24084 This will go away soon.
24085 (TypeManager.MemberLookup): Use this temporary hack here; once the
24086 new MemberCache is completed, we don't need to do the DeclaredOnly
24087 looping here anymore since the MemberCache will take care of this.
24088 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24089 (MemberCache): When creating the MemberCache for a class, get
24090 members from the current class and all its base classes.
24091 (MemberCache.CacheEntry.Container): New field. This is a
24092 temporary hack until the Mono runtime is fixed to distinguish
24093 between ReflectedType and DeclaringType. It allows us to use MCS
24094 with both the MS runtime and the unfixed Mono runtime without
24095 problems and without accecting performance.
24096 (MemberCache.SearchMembers): The DeclaredOnly looping from
24097 TypeManager.MemberLookup is now done here.
24099 2002-08-14 Martin Baulig <martin@gnome.org>
24101 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24102 Type.GetFields on dynamic types but get the fields from the
24103 corresponding TypeContainer.
24104 (MyStructInfo.GetStructInfo): Added check for enum types.
24106 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24107 (MemberList.SyncRoot): Implemented.
24108 (TypeManager.FilterWithClosure): No need to check permissions if
24109 closure_start_type == closure_invocation_type, don't crash if
24110 closure_invocation_type is null.
24112 2002-08-13 Martin Baulig <martin@gnome.org>
24114 Rewrote TypeContainer.FindMembers to use a member cache. This
24115 gives us a speed increase of about 35% for the self-hosting MCS
24116 build and of about 15-20% for the class libs (both on GNU/Linux).
24118 * report.cs (Timer): New class to get enhanced profiling. This
24119 whole class is "TIMER" conditional since it remarkably slows down
24122 * class.cs (MemberList): New class. This is an IList wrapper
24123 which we're now using instead of passing MemberInfo[]'s around to
24124 avoid copying this array unnecessarily.
24125 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24126 (ICachingMemberFinder, IMemberContainer): New interface.
24127 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24128 has already been checked, otherwise use it for the name comparision.
24129 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24130 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24131 if possible. Returns a MemberList, not a MemberInfo [].
24132 (TypeHandle): New class, implements IMemberContainer. We create
24133 one instance of this class per type, it contains a MemberCache
24134 which is used to do the member lookups.
24135 (MemberCache): New class. Each instance of this class contains
24136 all members of a type and a name-based hash table.
24137 (MemberCache.FindMembers): This is our new member lookup
24138 function. First, it looks up all members of the requested name in
24139 the hash table. Then, it walks this list and sorts out all
24140 applicable members and returns them.
24142 2002-08-13 Martin Baulig <martin@gnome.org>
24144 In addition to a nice code cleanup, this gives us a performance
24145 increase of about 1.4% on GNU/Linux - not much, but it's already
24146 half a second for the self-hosting MCS compilation.
24148 * typemanager.cs (IMemberFinder): New interface. It is used by
24149 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24150 Enum, Delegate or Interface.
24151 (TypeManager.finder_to_member_finder): New PtrHashtable.
24152 (TypeManager.finder_to_container): Removed.
24153 (TypeManager.finder_to_delegate): Removed.
24154 (TypeManager.finder_to_interface): Removed.
24155 (TypeManager.finder_to_enum): Removed.
24157 * interface.cs (Interface): Implement IMemberFinder.
24159 * delegate.cs (Delegate): Implement IMemberFinder.
24161 * enum.cs (Enum): Implement IMemberFinder.
24163 * class.cs (TypeContainer): Implement IMemberFinder.
24165 2002-08-12 Martin Baulig <martin@gnome.org>
24167 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24169 2002-08-12 Martin Baulig <martin@gnome.org>
24171 * ecore.cs (ITypeExpression): New interface for expressions which
24173 (TypeExpression): Renamed to TypeLookupExpression.
24174 (Expression.DoResolve): If we're doing a types-only lookup, the
24175 expression must implement the ITypeExpression interface and we
24176 call DoResolveType() on it.
24177 (SimpleName): Implement the new ITypeExpression interface.
24178 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24179 hack, the situation that we're only looking up types can't happen
24180 anymore when this method is called. Moved the type lookup code to
24181 DoResolveType() and call it.
24182 (SimpleName.DoResolveType): This ITypeExpression interface method
24183 is now doing the types-only lookup.
24184 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24185 (ResolveFlags): Added MaskExprClass.
24187 * expression.cs (MemberAccess): Implement the ITypeExpression
24189 (MemberAccess.DoResolve): Added support for a types-only lookup
24190 when we're called via ITypeExpression.DoResolveType().
24191 (ComposedCast): Implement the ITypeExpression interface.
24193 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24194 Expression.Resolve() with ResolveFlags.Type instead.
24196 2002-08-12 Martin Baulig <martin@gnome.org>
24198 * interface.cs (Interface.Define): Apply attributes.
24200 * attribute.cs (Attribute.ApplyAttributes): Added support for
24201 interface attributes.
24203 2002-08-11 Martin Baulig <martin@gnome.org>
24205 * statement.cs (Block.Emit): Only check the "this" variable if we
24206 do not always throw an exception.
24208 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24209 whether the property has a set accessor.
24211 2002-08-11 Martin Baulig <martin@gnome.org>
24213 Added control flow analysis support for structs.
24215 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24216 with control flow analysis turned off.
24217 (IVariable): New interface.
24218 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24219 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24220 (FieldExpr.DoResolve): Resolve the instance expression with flow
24221 analysis turned off and do the definite assignment check after the
24222 resolving when we know what the expression will resolve to.
24224 * expression.cs (LocalVariableReference, ParameterReference):
24225 Implement the new IVariable interface, only call the flow analysis
24226 code if ec.DoFlowAnalysis is true.
24227 (This): Added constructor which takes a Block argument. Implement
24228 the new IVariable interface.
24229 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24230 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24231 This does the definite assignment checks for struct members.
24233 * class.cs (Constructor.Emit): If this is a non-static `struct'
24234 constructor which doesn't have any initializer, call
24235 Block.AddThisVariable() to tell the flow analysis code that all
24236 struct elements must be initialized before control returns from
24239 * statement.cs (MyStructInfo): New public class.
24240 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24241 argument to this indexer. If non-zero, check an individual struct
24242 member, not the whole struct.
24243 (FlowBranching.CheckOutParameters): Check struct members.
24244 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24245 overloaded versions of these methods which take an additional
24246 `int field_idx' argument to check struct members.
24247 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24248 overloaded versions of these methods which take an additional
24249 `string field_name' argument to check struct member.s
24250 (VariableInfo): Implement the IVariable interface.
24251 (VariableInfo.StructInfo): New public property. Returns the
24252 MyStructInfo instance of the variable if it's a struct or null.
24253 (Block.AddThisVariable): New public method. This is called from
24254 Constructor.Emit() for non-static `struct' constructor which do
24255 not have any initializer. It creates a special variable for the
24256 "this" instance variable which will be checked by the flow
24257 analysis code to ensure that all of the struct's fields are
24258 initialized before control returns from the constructor.
24259 (UsageVector): Added support for struct members. If a
24260 variable/parameter is a struct with N members, we reserve a slot
24261 in the usage vector for each member. A struct is considered fully
24262 initialized if either the struct itself (slot 0) or all its
24263 members are initialized.
24265 2002-08-08 Martin Baulig <martin@gnome.org>
24267 * driver.cs (Driver.MainDriver): Only report an error CS5001
24268 if there were no compilation errors.
24270 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24271 `UnsafeContext' property to determine whether the parent is in
24272 unsafe context rather than checking the parent's ModFlags:
24273 classes nested in an unsafe class are unsafe as well.
24275 2002-08-08 Martin Baulig <martin@gnome.org>
24277 * statement.cs (UsageVector.MergeChildren): Distinguish between
24278 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24279 we return. Added test17() and test18() to test-154.cs.
24281 2002-08-08 Martin Baulig <martin@gnome.org>
24283 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24284 Family access, make sure the invoking type isn't a subclass of the
24285 queried type (that'd be a CS1540).
24287 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24288 this method which takes an additional `Type invocation_type'.
24290 * expression.cs (BaseAccess.DoResolve): Use the base type as
24291 invocation and query type.
24292 (MemberAccess.DoResolve): If the lookup failed and we're about to
24293 report a CS0122, try a lookup with the ec.ContainerType - if this
24294 succeeds, we must report a CS1540.
24296 2002-08-08 Martin Baulig <martin@gnome.org>
24298 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24299 (MethodGroupExpr): Implement the IMemberExpr interface.
24301 * expression (MemberAccess.ResolveMemberAccess): No need to have
24302 any special code for MethodGroupExprs anymore, they're now
24305 2002-08-08 Martin Baulig <martin@gnome.org>
24307 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24308 Family, FamANDAssem and FamORAssem permissions.
24309 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24311 2002-08-08 Martin Baulig <martin@gnome.org>
24313 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24314 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24317 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24319 * driver.cs: implemented /resource option to embed managed resources.
24321 2002-08-07 Martin Baulig <martin@gnome.org>
24323 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24324 (FieldBase.HasFieldInitializer): New public property.
24325 (FieldBase.GetInitializerExpression): New public method. Resolves and
24326 returns the field initializer and makes sure it is only resolved once.
24327 (TypeContainer.EmitFieldInitializers): Call
24328 FieldBase.GetInitializerExpression to get the initializer, this ensures
24329 that it isn't resolved multiple times.
24331 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24332 the resolving process (SimpleName/MemberLookup) that we're currently
24333 emitting a field initializer (which must not access any instance members,
24334 this is an error CS0236).
24336 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24337 argument, if the `IsFieldInitializer' flag is set, we must report and
24338 error CS0236 and not an error CS0120.
24340 2002-08-07 Martin Baulig <martin@gnome.org>
24342 * ecore.cs (IMemberExpr): New public interface.
24343 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24344 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24345 if the expression is an IMemberExpr.
24347 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24348 to be null, implicitly default to `this' if we're non-static in
24349 this case. Simplified the code a lot by using the new IMemberExpr
24350 interface. Also fixed bug #28176 here.
24352 2002-08-06 Martin Baulig <martin@gnome.org>
24354 * cs-parser.jay (SimpleLookup): Removed. We need to create
24355 ParameterReferences during semantic analysis so that we can do a
24356 type-only search when resolving Cast, TypeOf and SizeOf.
24357 (block): Pass the `current_local_parameters' to the Block's
24360 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24361 argument to the constructor.
24362 (ConstructorInitializer.Resolve): Create a temporary implicit
24363 block with the parameters.
24365 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24366 references here if we aren't doing a type-only search.
24368 * statement.cs (Block): Added constructor which takes a
24369 `Parameters parameters' argument.
24370 (Block.Parameters): New public property.
24372 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24373 to `Parameters' and made it public readonly.
24375 2002-08-06 Martin Baulig <martin@gnome.org>
24377 * ecore.cs (Expression.Warning): Made this public as well.
24379 * report.cs (Report.Debug): Print the contents of collections.
24381 2002-08-06 Martin Baulig <martin@gnome.org>
24383 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24384 used to tell Resolve() which kinds of expressions it may return.
24385 (Expression.Resolve): Added overloaded version of this method which
24386 takes a `ResolveFlags flags' argument. This can be used to tell
24387 Resolve() which kinds of expressions it may return. Reports a
24389 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24390 ResolveFlags.SimpleName.
24391 (Expression.Error118): Added overloaded version of this method which
24392 takes a `ResolveFlags flags' argument. It uses the flags to determine
24393 which kinds of expressions are allowed.
24395 * expression.cs (Argument.ResolveMethodGroup): New public method.
24396 Resolves an argument, but allows a MethodGroup to be returned.
24397 This is used when invoking a delegate.
24399 * TODO: Updated a bit.
24401 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24403 Fixed compilation with csc.
24405 * ecore.cs: Expression.Error made public. Is this correct? Should
24406 Warning be made public too?
24408 * expression.cs: use ea.Location instead of ea.loc.
24409 [FIXME: Filed as bug #28607: MCS must report these errors.]
24411 2002-08-06 Martin Baulig <martin@gnome.org>
24413 * ecore.cs (Expression.loc): Moved the location here instead of
24414 duplicating it in all derived classes.
24415 (Expression.Location): New public property.
24416 (Expression.Error, Expression.Warning): Made them non-static and
24417 removed the location argument.
24418 (Expression.Warning): Added overloaded version which takes an
24419 `int level' argument.
24420 (Expression.Error118): Make this non-static and removed the
24421 expression and location arguments.
24422 (TypeExpr): Added location argument to the constructor.
24424 * expression.cs (StaticCallExpr): Added location argument to
24426 (Indirection, PointerArithmetic): Likewise.
24427 (CheckedExpr, UnCheckedExpr): Likewise.
24428 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24429 (StringPtr): Likewise.
24432 2002-08-05 Martin Baulig <martin@gnome.org>
24434 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24436 * assign.cs (Assign.DoResolve): Check whether the source
24437 expression is a value or variable.
24439 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24440 while resolving the corresponding blocks.
24442 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24443 an error, don't silently return null.
24445 * statement.cs (Block.AddVariable): Do the error reporting here
24446 and distinguish between CS0128 and CS0136.
24447 (Block.DoResolve): Report all unused labels (warning CS0164).
24448 (LabeledStatement): Pass the location to the constructor.
24449 (LabeledStatement.HasBeenReferenced): New property.
24450 (LabeledStatement.Resolve): Set it to true here.
24452 * statement.cs (Return.Emit): Return success even after reporting
24453 a type mismatch error (CS0126 or CS0127), this is what csc does and
24454 it avoids confusing the users with any consecutive errors.
24456 2002-08-05 Martin Baulig <martin@gnome.org>
24458 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24460 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24462 * expression.cs (MemberAccess.DoResolve): Silently return if an
24463 error has already been reported.
24465 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24466 error has already been reported.
24468 2002-08-05 Martin Baulig <martin@gnome.org>
24470 * statement.cs (UsageVector): Only initialize the `parameters'
24471 vector if we actually have any "out" parameters.
24473 2002-08-05 Martin Baulig <martin@gnome.org>
24475 * expression.cs (Binary.ResolveOperator): When combining delegates,
24476 they must have the same type.
24478 2002-08-05 Martin Baulig <martin@gnome.org>
24480 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24481 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24482 work with the ms runtime and we also don't need it: if we're a
24483 PropertyBuilder and not in the `indexer_arguments' hash, then we
24484 are a property and not an indexer.
24486 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24487 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24488 since the latter one doesn't work with the ms runtime.
24490 2002-08-03 Martin Baulig <martin@gnome.org>
24492 Fixed bugs #27998 and #22735.
24494 * class.cs (Method.IsOperator): New public field.
24495 (Method.CheckBase): Report CS0111 if there's already a method
24496 with the same parameters in the current class. Report CS0508 when
24497 attempting to change the return type of an inherited method.
24498 (MethodData.Emit): Report CS0179 if a method doesn't have a body
24499 and it's not marked abstract or extern.
24500 (PropertyBase): New abstract base class for Property and Indexer.
24501 (PropertyBase.CheckBase): Moved here from Property and made it work
24503 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
24504 the same so we can reuse it there.
24505 (Property, Indexer): Derive from PropertyBase.
24506 (MethodSignature.inheritable_property_signature_filter): New delegate
24507 to find properties and indexers.
24509 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
24510 argument and improved error reporting.
24512 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
24513 EmptyReadOnlyParameters and made it a property.
24515 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
24516 version of this method which takes a `PropertyInfo indexer'.
24517 (TypeManager.RegisterIndexer): New method.
24519 * class.cs: Added myself as author of this file :-)
24521 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24523 * class.cs: fixed compilation on windoze.
24525 2002-08-03 Martin Baulig <martin@gnome.org>
24527 * interface.cs (Interface.GetInterfaceBases): Check whether all
24528 base interfaces are at least as accessible than the current one.
24530 * class.cs (TypeContainer.GetClassBases): Check whether base types
24531 are at least as accessible than the current type.
24532 (TypeContainer.AsAccessible): Implemented and made non-static.
24533 (MemberBase.CheckParameters): Report errors if the accessibility
24536 * delegate.cs (Delegate.Delegate): The default visibility is
24537 internal for top-level types and private for nested types.
24538 (Delegate.Define): Report errors if the accessibility checks fail.
24540 * enum.cs (Enum.Enum): The default visibility is internal for
24541 top-level types and private for nested types.
24542 (Enum.DefineType): Compute the correct visibility.
24544 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
24545 function which takes a `bool is_toplevel' instead of a TypeContainer.
24547 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
24550 2002-08-02 Martin Baulig <martin@gnome.org>
24552 * expression.cs (LocalVariableReferenc): Added constructor which
24553 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
24554 (LocalVariableReference.IsReadOnly): New property.
24555 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
24556 variable is readonly, use our own readonly flag to do this; you can
24557 use the new constructor to get a writable reference to a read-only
24560 * cs-parser.jay (foreach_statement, using_statement): Get a writable
24561 reference to the local variable.
24563 2002-08-01 Miguel de Icaza <miguel@ximian.com>
24565 * rootcontext.cs (ResolveCore): Also include System.Exception
24567 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
24568 we reach an EmptyStatement.
24570 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
24573 * expression.cs (Binary.ResolveOperator): Check error result in
24576 use brtrue/brfalse directly and avoid compares to null.
24578 2002-08-02 Martin Baulig <martin@gnome.org>
24580 * class.cs (TypeContainer.Define): Define all nested interfaces here.
24581 Fixes bug #28407, added test-155.cs.
24583 2002-08-01 Martin Baulig <martin@gnome.org>
24585 * class.cs (Event.EmitDefaultMethod): Make this work with static
24586 events. Fixes #28311, added verify-3.cs.
24588 2002-08-01 Martin Baulig <martin@gnome.org>
24590 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
24591 `is_disposable' fields.
24592 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
24593 `hm.is_disposable' if we're using the collection pattern.
24594 (Foreach.EmitCollectionForeach): Use the correct type for the
24595 enumerator's local variable, only emit the try/finally block if
24596 necessary (fixes #27713).
24598 2002-08-01 Martin Baulig <martin@gnome.org>
24600 * ecore.cs (Expression.report118): Renamed to Error118 and made
24603 * statement.cs (Throw.Resolve): Check whether the expression is of
24604 the correct type (CS0118) and whether the type derives from
24605 System.Exception (CS0155).
24606 (Catch.Resolve): New method. Do the type lookup here and check
24607 whether it derives from System.Exception (CS0155).
24608 (Catch.CatchType, Catch.IsGeneral): New public properties.
24610 * typemanager.cs (TypeManager.exception_type): Added.
24612 2002-07-31 Miguel de Icaza <miguel@ximian.com>
24614 * driver.cs: Updated About function.
24616 2002-07-31 Martin Baulig <martin@gnome.org>
24618 Implemented Control Flow Analysis.
24620 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
24621 (EmitContext.CurrentBranching): Added.
24622 (EmitContext.StartFlowBranching): Added.
24623 (EmitContext.EndFlowBranching): Added.
24624 (EmitContext.KillFlowBranching): Added.
24625 (EmitContext.IsVariableAssigned): Added.
24626 (EmitContext.SetVariableAssigned): Added.
24627 (EmitContext.IsParameterAssigned): Added.
24628 (EmitContext.SetParameterAssigned): Added.
24629 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
24630 Added control flow analysis stuff here.
24632 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
24633 resolve the expression as lvalue.
24634 (LocalVariableReference.DoResolve): Check whether the variable has
24635 already been assigned.
24636 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
24637 the parameter as assigned here.
24638 (ParameterReference.DoResolve): Check whether the parameter has already
24640 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
24641 expression as lvalue.
24643 * statement.cs (FlowBranching): New class for the flow analysis code.
24644 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
24645 (LabeledStatement.IsDefined): New public property.
24646 (LabeledStatement.AddUsageVector): New public method to tell flow
24647 analyis that the label may be reached via a forward jump.
24648 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
24650 (VariableInfo.Number): New public field. This is used by flow analysis
24651 to number all locals of a block.
24652 (Block.CountVariables): New public property. This is the number of
24653 local variables in this block (including the locals from all parent
24655 (Block.EmitMeta): Number all the variables.
24657 * statement.cs: Added flow analysis support to all classes.
24659 2002-07-31 Martin Baulig <martin@gnome.org>
24661 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
24662 To get debugging messages, compile mcs with /define:MCS_DEBUG and
24663 then use this argument.
24665 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
24667 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
24668 use this to specify /define options.
24670 2002-07-29 Martin Baulig <martin@gnome.org>
24672 * statement.cs (Fixed): Moved all code that does variable lookups
24673 and resolvings from Emit to Resolve.
24675 * statement.cs (For): Moved all code that does variable lookups
24676 and resolvings from Emit to Resolve.
24678 * statement.cs (Using): Moved all code that does variable lookups
24679 and resolvings from Emit to Resolve.
24681 2002-07-29 Martin Baulig <martin@gnome.org>
24683 * attribute.cs (Attribute.Resolve): Explicitly catch a
24684 System.NullReferenceException when creating the
24685 CustromAttributeBuilder and report a different warning message.
24687 2002-07-29 Martin Baulig <martin@gnome.org>
24689 * support.cs (ParameterData.ParameterName): Added method to
24690 get the name of a parameter.
24692 * typemanager.cs (TypeManager.IsValueType): New public method.
24694 2002-07-29 Martin Baulig <martin@gnome.org>
24696 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
24697 is a flag which specifies that it's either ref or out.
24698 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
24699 the out parameter to `out Parameter.Modifier mod', also set the
24700 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
24702 * support.cs (InternalParameters.ParameterModifier): Distinguish
24703 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24704 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24706 * expression.cs (Argument.GetParameterModifier): Distinguish
24707 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24708 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24710 2002-07-29 Martin Baulig <martin@gnome.org>
24712 * expression.cs (ParameterReference.ParameterReference): Added
24713 `Location loc' argument to the constructor.
24715 * cs-parser.jay: Pass location to ParameterReference.
24717 2002-07-28 Miguel de Icaza <miguel@ximian.com>
24719 * statement.cs (Try): Initialize the location.
24721 * cs-parser.jay: pass location to Try.
24723 * expression.cs (Unary.Reduce): Change the prototype to return
24724 whether a constant fold could be performed or not. The result is
24725 returned in an out parameters. In the case of Indirection and
24726 AddressOf, we want to perform the full tests.
24728 2002-07-26 Miguel de Icaza <miguel@ximian.com>
24730 * statement.cs (Statement.Emit): Flag dead code.
24732 2002-07-27 Andrew Birkett <andy@nobugs.org>
24734 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
24736 2002-07-27 Martin Baulig <martin@gnome.org>
24738 * class.cs (MethodData.Define): Put back call to
24739 TypeManager.AddMethod(), accidentally commented this out.
24741 * report.cs (Debug): New public method to print debugging information,
24742 this is `[Conditional ("DEBUG")]'.
24744 2002-07-26 Martin Baulig <martin@gnome.org>
24746 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
24747 (switch_statement): Push the current_block to the switch_stack and
24748 pop it again when we're done with the switch.
24749 (switch_section): The new block is a child of the current_block.
24750 Fixes bug #24007, added test-152.cs.
24752 2002-07-27 Martin Baulig <martin@gnome.org>
24754 * expression.cs (Invocation.EmitArguments): When calling a varargs
24755 function with only its fixed arguments, we need to pass an empty
24758 2002-07-27 Martin Baulig <martin@gnome.org>
24760 Mono 0.13 has been released.
24762 2002-07-25 Miguel de Icaza <miguel@ximian.com>
24764 * driver.cs: Rename --resource to --linkres, because that is what
24765 we do currently, we dont support --resource yet.
24767 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
24769 2002-07-25 Martin Baulig <martin@gnome.org>
24771 * class.cs (MethodData): New public class. This is a `method builder'
24772 class for a method or one accessor of a Property/Indexer/Event.
24773 (MethodData.GetMethodFlags): Moved here from MemberBase.
24774 (MethodData.ApplyAttributes): Likewise.
24775 (MethodData.ApplyObsoleteAttribute): Likewise.
24776 (MethodData.ApplyConditionalAttribute): Likewise.
24777 (MethodData.ApplyDllImportAttribute): Likewise.
24778 (MethodData.CheckAbstractAndExternal): Likewise.
24779 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
24780 (MethodData.Emit): Formerly known as Method.Emit().
24781 (MemberBase): Moved everything which was specific to a single
24782 accessor/method to MethodData.
24783 (Method): Create a new MethodData and call Define() and Emit() on it.
24784 (Property, Indexer, Event): Create a new MethodData objects for each
24785 accessor and call Define() and Emit() on them.
24787 2002-07-25 Martin Baulig <martin@gnome.org>
24789 Made MethodCore derive from MemberBase to reuse the code from there.
24790 MemberBase now also checks for attributes.
24792 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
24793 (MemberBase.GetMethodFlags): Moved here from class Method and marked
24795 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
24796 `CallingConventions cc' and `Attributes opt_attrs' arguments.
24797 (MemberBase.ApplyAttributes): New virtual method; applies the
24798 attributes to a method or accessor.
24799 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
24800 (MemberBase.ApplyConditionalAttribute): Likewise.
24801 (MemberBase.ApplyDllImportAttribute): Likewise.
24802 (MemberBase.CheckAbstractAndExternal): Likewise.
24803 (MethodCore.ParameterTypes): This is now a property instead of a
24804 method, it's initialized from DoDefineParameters().
24805 (MethodCore.ParameterInfo): Removed the set accessor.
24806 (MethodCore.DoDefineParameters): New protected virtual method to
24807 initialize ParameterTypes and ParameterInfo.
24808 (Method.GetReturnType): We can now simply return the MemberType.
24809 (Method.GetMethodFlags): Override the MemberBase version and add
24810 the conditional flags.
24811 (Method.CheckBase): Moved some code from Define() here, call
24812 DoDefineParameters() here.
24813 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
24814 here to avoid some larger code duplication.
24815 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
24816 ensure that abstract and external accessors don't declare a body.
24818 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
24819 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
24820 lookup in the attribute's parent classes, so we need to abort as soon
24821 as we found the first match.
24822 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
24823 the attribute has no arguments.
24825 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
24828 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24830 * cs-parser.jay: reverted previous patch.
24832 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24834 * cs-parser.jay: fixed bug #22119.
24836 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24838 * attribute.cs: fixed compilation. The error was:
24839 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
24840 be assigned to before control leaves the current method."
24841 [FIXME: Filed as bug #28186: MCS must report this error.]
24843 2002-07-25 Martin Baulig <martin@gnome.org>
24845 * attribute.cs (Attribute.Conditional_GetConditionName): New static
24846 method to pull the condition name ouf of a Conditional attribute.
24847 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
24848 the obsolete message and error flag out of an Obsolete attribute.
24850 * class.cs (Method.GetMethodFlags): New public method to get the
24851 TypeManager.MethodFlags for this method.
24852 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
24854 (Method.Define): Get and apply the Obsolete and Conditional attributes;
24855 if we're overriding a virtual function, set the new private variable
24856 `parent_method'; call the new TypeManager.AddMethod().
24858 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
24859 the MethodBuilder and the Method in a PtrHashtable.
24860 (TypeManager.builder_to_method): Added for this purpose.
24861 (TypeManager.MethodFlags): Added IsObsoleteError.
24862 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
24863 Obsolete and Conditional arguments in MethodBuilders. If we discover
24864 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
24865 the message from the attribute.
24867 2002-07-24 Martin Baulig <martin@gnome.org>
24869 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
24870 preprocessor directives, ensure that the argument to #define/#undef is
24871 exactly one identifier and that it's actually an identifier.
24873 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
24876 2002-07-24 Martin Baulig <martin@gnome.org>
24878 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
24879 initialize it to TypeManager.object_type in the constructor.
24880 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
24881 of the `hm.get_current' method if we're using the collection pattern.
24882 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
24883 for the explicit conversion to make it work when we're using the collection
24884 pattern and the `Current' property has a different return type than `object'.
24887 2002-07-24 Martin Baulig <martin@gnome.org>
24889 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
24890 does not match, but don't report any errors. This method is called in
24891 order for all methods in a MethodGroupExpr until a matching method is
24892 found, so we don't want to bail out if the first method doesn't match.
24893 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
24894 matches, report the 123. Fixes #28070.
24896 2002-07-24 Martin Baulig <martin@gnome.org>
24898 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
24899 TypeManager.TypeToCoreType() to the top of the method so the
24900 following equality checks will work. Fixes #28107.
24902 2002-07-24 Martin Baulig <martin@gnome.org>
24904 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
24905 operand is of type uint, and the other operand is of type sbyte,
24906 short or int, the operands are converted to type long." -
24907 Actually do what this comment already told us. Fixes bug #28106,
24910 2002-07-24 Martin Baulig <martin@gnome.org>
24912 * class.cs (MethodBase): New abstract class. This is now a base
24913 class for Property, Indexer and Event to avoid some code duplication
24914 in their Define() and DefineMethods() methods.
24915 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
24916 generic methods for Define() and DefineMethods().
24917 (FieldBase): Derive from MemberBase, not MemberCore.
24918 (Property): Derive from MemberBase, not MemberCore.
24919 (Property.DefineMethod): Moved all the code from this method to the
24920 new MethodBase.DefineAccessor(), just call it with appropriate
24922 (Property.Define): Call the new Property.DoDefine(), this does some
24923 sanity checks and we don't need to duplicate the code everywhere.
24924 (Event): Derive from MemberBase, not MemberCore.
24925 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
24926 accessors, this will also make them work with interface events.
24927 (Indexer): Derive from MemberBase, not MemberCore.
24928 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
24929 (Indexer.Define): Use the new MethodBase functions.
24931 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
24932 argument to the constructor.
24933 (Interface.FindMembers): Added support for interface events.
24934 (Interface.PopluateEvent): Implemented.
24936 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
24938 2002-07-22 Miguel de Icaza <miguel@ximian.com>
24940 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
24941 but this is required to check for a method name being the same as
24942 the containing class.
24946 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24948 * interface.cs: initialize variable.
24950 2002-07-23 Martin Baulig <martin@gnome.org>
24952 Implemented the IndexerName attribute in interfaces.
24954 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
24955 name if this is an explicit interface implementation.
24956 (Indexer.InterfaceIndexerName): New public variable. If we're
24957 implementing an interface indexer, this is the IndexerName in that
24958 interface. Otherwise, it's the IndexerName.
24959 (Indexer.DefineMethod): If we're implementing interface indexer,
24960 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
24961 and Pending.ImplementIndexer methods.
24962 (Indexer.Define): Also define the PropertyBuilder if we're
24963 implementing an interface indexer and this is neither an explicit
24964 interface implementation nor do the IndexerName match the one in
24967 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
24968 If a method is defined here, then we always need to create a proxy
24969 for it. This is used when implementing interface indexers.
24970 (Pending.IsInterfaceIndexer): New public method.
24971 (Pending.ImplementIndexer): New public method.
24972 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
24973 This is used when implementing interface indexers to define a proxy
24975 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
24976 define a proxy if necessary.
24978 * interface.cs (Interface.IndexerName): New public variable.
24979 (Interface.PopulateIndexer): Set the IndexerName.
24980 (Interface.DefineIndexers): New private method. Populate all the
24981 indexers and make sure their IndexerNames match.
24983 * typemanager.cs (IndexerPropertyName): Added support for interface
24986 2002-07-22 Martin Baulig <martin@gnome.org>
24988 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
24989 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
24990 ret if HasReturnLabel.
24991 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
24994 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
24995 and set the ec.LoopBeginTryCatchLevel.
24996 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
24997 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
24998 the current ec.TryCatchLevel, the branch goes out of an exception
24999 block. In this case, we need to use Leave and not Br.
25001 2002-07-22 Martin Baulig <martin@gnome.org>
25003 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25004 block unless the block does not always return or it is contained in
25005 another try { ... } catch { ... } block. Fixes bug #26506.
25006 Added verify-1.cs to the test suite.
25008 2002-07-22 Martin Baulig <martin@gnome.org>
25010 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25011 then we do not always return. Fixes bug #24985.
25013 2002-07-22 Martin Baulig <martin@gnome.org>
25015 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25016 lookup on a per-class level; ie. walk up the class hierarchy until we
25017 found at least one applicable method, then choose the best among them.
25018 Fixes bug #24463 and test-29.cs.
25020 2002-07-22 Martin Baulig <martin@gnome.org>
25022 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25023 return types of the methods. The return type is not part of the
25024 signature and we must not check it to make the `new' modifier work.
25025 Fixes bug #27999, also added test-147.cs.
25026 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25028 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25029 on the method's return type.
25031 2002-07-21 Martin Baulig <martin@gnome.org>
25033 * assign.cs: Make this work if the rightmost source is a constant and
25034 we need to do an implicit type conversion. Also adding a few more tests
25035 to test-38.cs which should have caught this.
25037 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25038 target in the makefile for this. The makefile.gnu is primarily intended
25039 for end-users who don't want to debug the compiler.
25041 2002-07-21 Martin Baulig <martin@gnome.org>
25043 * assign.cs: Improved the Assign class so it can now handle embedded
25044 assignments (X = Y = Z = something). As a side-effect this'll now also
25045 consume less local variables. test-38.cs now passes with MCS, added
25046 a few new test cases to that test.
25048 2002-07-20 Martin Baulig <martin@gnome.org>
25050 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25051 instructions. Fixes bug #27977, also added test-146.cs.
25053 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25055 * cs-tokenizer.cs: fixed getHex ().
25057 2002-07-19 Martin Baulig <martin@gnome.org>
25059 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25060 not Type.GetType() to lookup the array type. This is needed when
25061 we're constructing an array of a user-defined type.
25062 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25063 single-dimensional arrays, but also for single-dimensial arrays of
25066 2002-07-19 Martin Baulig <martin@gnome.org>
25068 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25069 this function is called, it's not allowed to share LocalBuilders
25070 among ILGenerators.
25072 2002-07-19 Martin Baulig <martin@gnome.org>
25074 * expression.cs (Argument.Resolve): Report an error 118 when trying
25075 to pass a type as argument.
25077 2002-07-18 Martin Baulig <martin@gnome.org>
25079 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25080 Conv_R_Un for the signed `long' type.
25082 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25084 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25085 `expr' for the temporary result, as that will fail if we do
25086 multiple resolves on the same expression.
25088 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25090 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25091 ec.TypeContainer for looking up aliases.
25093 * class.cs (TypeContainer): Remove LookupAlias from here.
25095 * decl.cs (DeclSpace); Move here.
25097 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25099 * class.cs (FindMembers): Only call filter if the constructor
25100 bulider is not null.
25102 Also handle delegates in `NestedTypes' now. Now we will perform
25103 type lookups using the standard resolution process. This also
25106 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25107 This uses Expressions (the limited kind that can be parsed by the
25108 tree) instead of strings.
25110 * expression.cs (ComposedCast.ToString): Implement, used to flag
25111 errors since now we have to render expressions.
25113 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25116 * ecore.cs (SimpleName.ToString): ditto.
25118 * cs-parser.jay: Instead of using strings to assemble types, use
25119 Expressions to assemble the type (using SimpleName, ComposedCast,
25120 MemberAccess). This should fix the type lookups in declarations,
25121 because we were using a different code path for this.
25123 * statement.cs (Block.Resolve): Continue processing statements
25124 even when there is an error.
25126 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25128 * class.cs (Event.Define): Also remove the `remove' method from
25129 the list of pending items.
25131 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25132 generate more compact code.
25134 2002-07-17 Martin Baulig <martin@gnome.org>
25136 * const.cs (Const.LookupConstantValue): Add support for constant
25137 `unchecked' and `checked' expressions.
25138 Also adding test case test-140.cs for this.
25140 2002-07-17 Martin Baulig <martin@gnome.org>
25142 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25143 check whether mi.ReturnType implements the IEnumerator interface; the
25144 `==' and the IsAssignableFrom() will fail in this situation.
25146 2002-07-16 Ravi Pratap <ravi@ximian.com>
25148 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25151 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25153 * expression.cs: fixed bug #27811.
25155 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25157 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25158 Molaro: when we are a ref, the value already contains a pointer
25159 value, do not take the address of it.
25161 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25162 * removed mb-parser.jay and mb-tokenizer.cs
25164 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25166 * expression.cs: check against the building corlib void type.
25168 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25170 * ecore.cs: fix for valuetype static readonly fields: when
25171 initializing them, we need their address, not the address of a copy.
25173 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25175 * typemanager.cs: register also enum_type in corlib.
25177 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25179 * class.cs: allow calling this (but not base) initializers in structs.
25181 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25183 * ecore.cs: make sure we compare against the building base types
25186 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25188 * typemanager.cs: fix TypeToCoreType() to handle void and object
25189 (corlib gets no more typerefs after this change).
25191 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25193 * expression.cs (ArrayCreation.EmitArrayArguments): use
25194 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25196 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25197 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25198 array indexes, the runtime actually forbids them.
25200 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25201 for array arguments here.
25203 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25204 instead of the default for ValueTypes.
25206 (New.DoEmit): Use IsValueType instead of
25207 IsSubclassOf (value_type)
25208 (New.DoResolve): ditto.
25209 (Invocation.EmitCall): ditto.
25211 * assign.cs (Assign): ditto.
25213 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25214 Statements *are* currently doing part of their resolution during
25217 Expressions do always resolve during resolve, but statements are
25218 only required to propagate resolution to their children.
25220 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25222 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25224 (LoadAssembly): Do not add the dll if it is already specified
25226 (MainDriver): Add the System directory to the link path at the end,
25227 after all the other -L arguments.
25229 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25230 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25231 ldelem.u1) and using the opposite for sbytes.
25233 This fixes Digger, and we can finally run it.
25235 * driver.cs (UnixParseOption): Move the option parsing here.
25236 (CSCParseOption): Implement CSC-like parsing of options.
25238 We now support both modes of operation, the old Unix way, and the
25239 new CSC-like way. This should help those who wanted to make cross
25240 platform makefiles.
25242 The only thing broken is that /r:, /reference: and /lib: are not
25243 implemented, because I want to make those have the same semantics
25244 as the CSC compiler has, and kill once and for all the confussion
25245 around this. Will be doing this tomorrow.
25247 * statement.cs (Unsafe.Resolve): The state is checked during
25248 resolve, not emit, so we have to set the flags for IsUnsfe here.
25250 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25252 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25253 not catch the Error_ObjectRefRequired in SimpleName (as it is
25254 possible to have a class/instance variable name that later gets
25255 deambiguated), we have to check this here.
25257 2002-07-10 Ravi Pratap <ravi@ximian.com>
25259 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25260 make static and put into Expression.
25262 (Event.Define): Register the private field of the event with the
25263 TypeManager so that GetFieldFromEvent can get at it.
25265 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25266 keep track of the private field associated with an event which
25269 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25272 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25274 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25276 * expression.cs (Binary.EmitBranchable): this routine emits the
25277 Binary expression in a branchable context. This basically means:
25278 we need to branch somewhere, not just get the value on the stack.
25280 This works together with Statement.EmitBoolExpression.
25282 * statement.cs (Statement.EmitBoolExpression): Use
25285 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25287 * statement.cs (For): Reduce the number of jumps in loops.
25289 (For): Implement loop inversion for the For statement.
25291 (Break): We can be breaking out of a Try/Catch controlled section
25292 (foreach might have an implicit try/catch clause), so we need to
25293 use Leave instead of Br.
25295 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25296 now). If the instace expression supports IMemoryLocation, we use
25297 the AddressOf method from the IMemoryLocation to extract the
25298 address instead of emitting the instance.
25300 This showed up with `This', as we were emitting the instance
25301 always (Emit) instead of the Address of This. Particularly
25302 interesting when This is a value type, as we dont want the Emit
25303 effect (which was to load the object).
25305 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25307 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25309 * statement.cs (Checked): Set the CheckedState during the resolve
25310 process too, as the ConvCast operations track the checked state on
25311 the resolve process, and not emit.
25313 * cs-parser.jay (namespace_member_declaration): Flag that we have
25314 found a declaration when we do. This is used to flag error 1529
25316 * driver.cs: Report ok when we display the help only.
25318 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25320 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25322 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25324 * cs-tokenizer.cs (define): We also have to track locally the
25325 defines. AllDefines is just used for the Conditional Attribute,
25326 but we also need the local defines for the current source code.
25328 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25330 * statement.cs (While, For, Do): These loops can exit through a
25331 Break statement, use this information to tell whether the
25332 statement is the last piece of code.
25334 (Break): Flag that we break.
25336 * codegen.cs (EmitContexts): New `Breaks' state variable.
25338 2002-07-03 Martin Baulig <martin@gnome.org>
25340 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25341 modifiers in method declarations in structs. Otherwise, you won't
25342 be able to override things like Object.Equals().
25344 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25346 * class.cs (Method, Property, Indexer): Do not allow the public
25347 modifier to be used in explicit interface implementations.
25349 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25350 override modifiers in method declarations in structs
25352 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25354 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25355 integer or real overflow, report an error
25357 2002-07-02 Martin Baulig <martin@gnome.org>
25359 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25360 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25361 to tell the runtime about our newly created System.Object and
25362 System.ValueType types.
25364 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25366 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25367 struct instead of Ldarg/Starg.
25369 2002-07-02 Martin Baulig <martin@gnome.org>
25371 * expression.cs (Indirection.Indirection): Call
25372 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25374 2002-07-02 Martin Baulig <martin@gnome.org>
25376 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25377 ValueType, call TypeManager.TypeToCoreType() on it.
25378 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25379 the OpCodes.Newarr argument.
25381 2002-07-02 Martin Baulig <martin@gnome.org>
25383 * expression.cs (Invocation.EmitCall): When compiling corlib,
25384 replace all calls to the system's System.Array type to calls to
25385 the newly created one.
25387 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25388 System.Array methods.
25389 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25390 from the system's System.Array type which must be replaced.
25392 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25394 * typemanager.cs: load unverifiable_code_ctor so we can build
25395 corlib using the correct type. Avoid using GetTypeCode() with
25397 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25398 TypeManager.object_type to allow building corlib.
25400 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25402 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25404 2002-07-01 Martin Baulig <martin@gnome.org>
25406 * class.cs: Make the last change actually work, we need to check
25407 whether `ifaces != null' to avoid a crash.
25409 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25411 * class.cs: when we build structs without fields that implement
25412 interfaces, we need to add the interfaces separately, since there is
25413 no API to both set the size and add the interfaces at type creation
25416 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25418 * expression.cs: the dimension arguments to the array constructors
25419 need to be converted if they are a long.
25421 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25423 * class.cs: don't emit ldarg.0 if there is no parent constructor
25424 (fixes showstopper for corlib).
25426 2002-06-29 Martin Baulig <martin@gnome.org>
25428 MCS now compiles corlib on GNU/Linux :-)
25430 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25431 ie. check for MethodImplOptions.InternalCall.
25433 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25434 and TypeManager.attribute_type are null, so we must explicitly check
25435 whether parent is not null to find out whether it's an attribute type.
25436 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25437 and SetBuilder, not only if the property is neither abstract nor external.
25438 This is necessary to set the MethodImplOptions on the accessor methods.
25439 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25440 SetBuilder, see Property.Emit().
25442 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25443 populate "System.Object", "System.ValueType" and "System.Attribute" since
25444 they've already been populated from BootCorlib_PopulateCoreTypes().
25446 2002-06-29 Martin Baulig <martin@gnome.org>
25448 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25449 is the NullLiteral, we also need to make sure that target_type is not
25452 2002-06-29 Martin Baulig <martin@gnome.org>
25454 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25455 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25456 before calling BootstrapCorlib_ResolveDelegate ().
25458 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25460 * statement.cs: fixed build-breaker. All tests passed ok.
25462 2002-06-27 Martin Baulig <martin@gnome.org>
25464 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25465 for System.Decimal when compiling corlib.
25467 2002-06-27 Martin Baulig <martin@gnome.org>
25469 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25470 switch blocks which contain nothing but a default clause.
25472 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25474 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25476 2002-06-27 Martin Baulig <martin@gnome.org>
25478 * ecore.cs (PropertyExpr.PropertyExpr): Call
25479 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25481 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25482 is already a TypeBuilder.
25484 2002-06-27 Martin Baulig <martin@gnome.org>
25486 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25487 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25488 the "from an array-type to System.Array" case. This makes it work
25489 when compiling corlib.
25491 2002-06-27 Martin Baulig <martin@gnome.org>
25493 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
25494 non-static PropertyExpr, set its InstanceExpression. This makes
25495 the `ICollection.Count' property work in System/Array.cs.
25497 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
25499 * driver.cs: Made error handling more consistent. Errors now
25500 tracked by Report class, so many methods which used to return int
25501 now return void. Main() now prints success/failure and
25502 errors/warnings message.
25504 Renamed '--probe' compiler argument to '--expect-error'. Removed
25505 the magic number return values (123 and 124). Now, if the
25506 expected error occurs, the compiler exits with success (exit value
25507 0). If the compilation completes without seeing that particular
25508 error, the compiler exits with failure (exit value 1). The
25509 makefile in mcs/errors has been changed to handle the new behaviour.
25511 * report.cs: Made 'expected error' number a property and renamed
25512 it from 'Probe' to 'ExpectedError'.
25514 * genericparser.cs: Removed error handling support, since it is
25515 now all done by Report class.
25517 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
25518 class, so parse() no longer returns an int.
25520 * namespace.cs: Use Report.Error instead of GenericParser.error
25522 2002-06-22 Miguel de Icaza <miguel@ximian.com>
25524 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
25525 TypeContainer.AddOperator): At the front of the list put the
25526 explicit implementations, so they get resolved/defined first.
25528 2002-06-21 Miguel de Icaza <miguel@ximian.com>
25530 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
25531 interface type is implemented by this TypeContainer. Used during
25532 explicit interface implementation.
25534 (Property.Define, Indexer.Define, Method.Define): Validate that
25535 the given interface in the explicit implementation is one of the
25536 base classes for the containing type.
25538 Also if we are explicitly implementing an interface, but there is
25539 no match in the pending implementation table, report an error.
25541 (Property.Define): Only define the property if we are
25542 not explicitly implementing a property from an interface. Use the
25543 correct name also for those properties (the same CSC uses,
25544 although that is really not needed).
25546 (Property.Emit): Do not emit attributes for explicitly implemented
25547 properties, as there is no TypeBuilder.
25549 (Indexer.Emit): ditto.
25551 Hiding then means that we do not really *implement* a pending
25552 implementation, which makes code fail.
25554 2002-06-22 Martin Baulig <martin@gnome.org>
25556 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
25557 the return value of Object.GetType(). [FIXME: we need to do this whenever
25558 we get a type back from the reflection library].
25560 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
25562 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
25564 2002-06-20 Miguel de Icaza <miguel@ximian.com>
25566 * attribute.cs: Return null if we can not look up the type.
25568 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
25569 the interface types found.
25571 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
25572 interface types found.
25574 * typemanager.cs (GetInterfaces): Make this routine returns alll
25575 the interfaces and work around the lame differences between
25576 System.Type and System.Reflection.Emit.TypeBuilder in the results
25577 result for GetInterfaces.
25579 (ExpandInterfaces): Given an array of interface types, expand and
25580 eliminate repeated ocurrences of an interface. This expands in
25581 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
25584 2002-06-21 Martin Baulig <martin@gnome.org>
25586 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
25589 2002-06-21 Martin Baulig <martin@gnome.org>
25591 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
25592 and called with one of the core types, return the corresponding typebuilder for
25595 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
25598 2002-06-21 Martin Baulig <martin@gnome.org>
25600 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
25601 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
25602 (Expression.ConvertReferenceExplicit): Likewise.
25604 * expression.cs (ElementAccess.DoResolve): Likewise.
25605 (ElementAccess.DoResolveLValue): Likewise.
25607 2002-06-10 Martin Baulig <martin@gnome.org>
25609 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
25610 add the "value" parameter to the parameter list.
25612 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
25615 2002-06-19 Miguel de Icaza <miguel@ximian.com>
25617 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
25618 the argument to an int, uint, long or ulong, per the spec. Also
25619 catch negative constants in array creation.
25621 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
25623 * class.cs: do not allow the same interface to appear twice in
25624 the definition list.
25626 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
25628 * ecore.cs: don't use ldlen with System.Array.
25630 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
25632 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
25634 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
25636 * modifiers.cs: produce correct field attributes for protected
25637 internal. Easy fix so miguel can work on ther harder stuff:-)
25639 2002-06-18 Miguel de Icaza <miguel@ximian.com>
25641 * pending.cs: New file. Move the code from class.cs here.
25642 Support clearning the pending flag for all methods (when not doing
25643 explicit interface implementation).
25645 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
25647 * rootcontext.cs: added a couple more types needed to bootstrap.
25649 2002-06-17 Miguel de Icaza <miguel@ximian.com>
25651 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
25652 constructor in the type, instead of any constructor in the type
25653 hierarchy. Thanks to Paolo for finding this bug (it showed up as
25654 a bug in the Mono runtime when applying the params attribute).
25656 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25657 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
25659 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
25661 * expression.cs (Unary.ResolveOperator): Use TypeManager
25662 to resolve the type.
25664 2002-06-13 Ravi Pratap <ravi@ximian.com>
25666 * cs-parser.jay (enum_member_declaration): Pass in the attributes
25669 * enum.cs (AddEnumMember): Add support to store the attributes associated
25670 with each member too.
25672 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
25673 field builders too - this takes care of the enum member case.
25675 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
25677 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
25678 address-of operator on both value types and pointers.
25680 2002-06-10 Martin Baulig <martin@gnome.org>
25682 * interface.cs (Interface.PopulateIndexer): Add the indexer's
25683 PropertyBuilder to the `property_builders' list.
25685 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
25686 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
25687 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
25688 find any indexers which are inherited from an interface.
25690 2002-06-09 Martin Baulig <martin@gnome.org>
25692 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
25693 the same type as the constant if necessary. There's also a test-130.cs
25696 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
25698 * typemanager.cs (TypeManager.ChangeType): Previously known as
25699 Enum.ChangeEnumType().
25701 2002-06-09 Martin Baulig <martin@gnome.org>
25703 * expression.cs (Cast.TryReduce): Added support for consts.
25705 2002-06-08 Ravi Pratap <ravi@ximian.com>
25707 * class.cs (Accessor): Hold attributes information so we can pass
25710 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
25711 Modify to pass in attributes attached to the methods.
25713 (add_accessor_declaration, remove_accessor_declaration): Ditto.
25715 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
25716 to handle the Accessor kind :-)
25718 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
25720 2002-06-08 Martin Baulig <martin@gnome.org>
25722 * expression.cs (Unary.TryReduceNegative): Added support for
25725 2002-06-08 Martin Baulig <martin@gnome.org>
25727 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
25728 name can't be found in the `defined_names' - the caller will do a
25729 MemberLookup in this case and thus find methods in System.Enum
25730 such as Enum.IsDefined().
25732 2002-06-08 Martin Baulig <martin@gnome.org>
25734 * enum.cs (Enum.ChangeEnumType): This is a custom version of
25735 Convert.ChangeType() which works with TypeBuilder created types.
25736 (Enum.LookupEnumValue, Enum.Define): Use it here.
25738 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
25739 `TypeBuilder.BaseType != null' check.
25740 (TypeContainer.FindMembers): Only lookup parent members if we
25741 actually have a parent.
25742 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
25743 (ConstructorInitializer.Resolve): Likewise.
25745 * interface.cs (Interface.FindMembers): Added
25746 `TypeBuilder.BaseType != null' check.
25748 * rootcontext.cs (RootContext.ResolveCore): Added
25749 "System.Runtime.CompilerServices.IndexerNameAttribute" to
25750 classes_second_stage.
25752 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
25753 debug_type and trace_type when compiling with --nostdlib.
25755 2002-06-07 Martin Baulig <martin@gnome.org>
25757 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
25758 (AddField): Set it to true when adding a non-static field.
25759 (DefineType): Use `have_nonstatic_fields' to find out whether we
25760 have non-static fields, not `Fields != null'.
25762 2002-06-02 Miguel de Icaza <miguel@ximian.com>
25764 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
25765 dereferencing a null on the static-field code path)
25767 2002-05-30 Martin Baulig <martin@gnome.org>
25769 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
25770 to take command line arguments. Use reflection to call the new
25771 custom `Initialize' function on the symbol writer and pass it the
25772 command line arguments.
25774 * driver.cs (--debug-args): New command line argument to pass command
25775 line arguments to the symbol writer.
25777 2002-05-28 Miguel de Icaza <miguel@ximian.com>
25779 * assign.cs (DoResolve): Forgot to do the implicit conversion to
25780 the target type for indexers and properties. Thanks to Joe for
25783 2002-05-27 Miguel de Icaza <miguel@ximian.com>
25785 * typemanager.cs (MethodFlags): returns the method flags
25786 (Obsolete/ShouldIgnore) that control warning emission and whether
25787 the invocation should be made, or ignored.
25789 * expression.cs (Invocation.Emit): Remove previous hack, we should
25790 not do this on matching a base type, we should do this based on an attribute
25792 Only emit calls to System.Diagnostics.Debug and
25793 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
25794 on the command line.
25796 * rootcontext.cs: Global settings for tracing and debugging.
25798 * cs-tokenizer.cs (define): New utility function to track
25799 defines. Set the global settings for TRACE and DEBUG if found.
25801 2002-05-25 Ravi Pratap <ravi@ximian.com>
25803 * interface.cs (Populate*): Pass in the TypeContainer as well as
25804 the DeclSpace as parameters so that we can create EmitContexts and
25805 then use that to apply attributes etc.
25807 (PopulateMethod, PopulateEvent, PopulateProperty)
25808 (PopulateIndexer): Apply attributes everywhere.
25810 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
25813 (ApplyAttributes): Update accordingly.
25815 We now apply interface attributes for all members too.
25817 2002-05-26 Miguel de Icaza <miguel@ximian.com>
25819 * class.cs (Indexer.Define); Correctly check if we are explicit
25820 implementation (instead of checking the Name for a ".", we
25821 directly look up if the InterfaceType was specified).
25823 Delay the creation of the PropertyBuilder.
25825 Only create the PropertyBuilder if we are not an explicit
25826 interface implementation. This means that explicit interface
25827 implementation members do not participate in regular function
25828 lookups, and hence fixes another major ambiguity problem in
25829 overload resolution (that was the visible effect).
25831 (DefineMethod): Return whether we are doing an interface
25834 * typemanager.cs: Temporary hack until we get attributes in
25835 interfaces (Ravi is working on that) and we get IndexerName
25836 support in interfaces.
25838 * interface.cs: Register the indexers as properties.
25840 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
25841 warning, I have verified that this is a bug in the .NET runtime
25842 (JavaScript suffers of the same problem).
25844 * typemanager.cs (MemberLookup): When looking up members for
25845 interfaces, the parent of an interface is the implicit
25846 System.Object (so we succeed in searches of Object methods in an
25847 interface method invocation. Example: IEnumerable x; x.ToString
25850 2002-05-25 Miguel de Icaza <miguel@ximian.com>
25852 * class.cs (Event): Events should also register if they do
25853 implement the methods that an interface requires.
25855 * typemanager.cs (MemberLookup); use the new GetInterfaces
25858 (GetInterfaces): The code used to lookup interfaces for a type is
25859 used in more than one place, factor it here.
25861 * driver.cs: Track the errors at the bottom of the file, we kept
25864 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
25865 instance if the method we are calling is static!
25867 2002-05-24 Miguel de Icaza <miguel@ximian.com>
25869 * attribute.cs (ApplyAttributes): Make this function filter out
25870 the IndexerName attribute (as that attribute in reality is never
25871 applied) and return the string constant for the IndexerName
25874 * class.cs (TypeContainer.Emit): Validate that all the indexers
25875 have the same IndexerName attribute, and if so, set the
25876 DefaultName attribute on the class.
25878 * typemanager.cs: The return value might contain other stuff (not
25879 only methods). For instance, consider a method with an "Item"
25880 property and an Item method.
25882 * class.cs: If there is a problem with the parameter types,
25885 2002-05-24 Ravi Pratap <ravi@ximian.com>
25887 * ecore.cs (ImplicitConversionExists): Wrapper function which also
25888 looks at user defined conversion after making a call to
25889 StandardConversionExists - we need this for overload resolution.
25891 * expression.cs : Update accordingly the various method calls.
25893 This fixes 2 bugs filed against implicit user defined conversions
25895 2002-05-22 Miguel de Icaza <miguel@ximian.com>
25897 * statement.cs: Track the result of the assignment.
25899 2002-05-21 Miguel de Icaza <miguel@ximian.com>
25901 * expression.cs (MemberAccess): Improved error reporting for
25902 inaccessible members.
25904 2002-05-22 Martin Baulig <martin@gnome.org>
25906 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
25907 itself with debugging support.
25909 2002-05-22 Martin Baulig <martin@gnome.org>
25911 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
25912 Removed, this isn't needed anymore.
25914 2002-05-20 Martin Baulig <martin@gnome.org>
25916 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
25917 be underlying type for an enum.
25919 2002-05-20 Miguel de Icaza <miguel@ximian.com>
25921 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
25922 that splits out the loading of just the core types.
25924 * rootcontext.cs (ResolveCore): Split the struct resolution in
25925 two, so we can load the enumeration underlying types before any
25928 * expression.cs (Is): Bandaid until we fix properly Switch (see
25929 bug #24985 for details).
25931 * typemanager.cs (ImplementsInterface): The hashtable will contain
25932 a null if there are no interfaces implemented.
25934 2002-05-18 Miguel de Icaza <miguel@ximian.com>
25936 * cs-parser.jay (indexer_declarator): It is fine to have array
25939 2002-05-17 Miguel de Icaza <miguel@ximian.com>
25941 * typemanager.cs: (RegisterBuilder): New function used to register
25942 TypeBuilders that implement interfaces. Since
25943 TypeBuilder.GetInterfaces (as usual) does not work with lame
25945 (AddUserType): register interfaces.
25947 (ImplementsInterface): Use the builder_to_ifaces hash if we are
25948 dealing with TypeBuilder. Also, arrays are showing up as
25949 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
25950 methods can not be invoked on them!
25952 * ecore.cs (ExplicitReferenceConversionExists): Made public.
25953 (ImplicitReferenceConversionExists): Split out from
25954 StandardConversionExists.
25956 * expression.cs (As): We were only implementing one of the three
25957 cases for the as operator. We now implement them all.
25958 (Is): Implement the various other cases for Is as well.
25960 * typemanager.cs (CACHE): New define used to control if we want or
25961 not the FindMembers cache. Seems to have a negative impact on
25962 performance currently
25964 (MemberLookup): Nested types have full acess to
25965 enclosing type members
25967 Remove code that coped with instance/static returns for events, we
25968 now catch this in RealFindMembers.
25970 (RealFindMembers): only perform static lookup if the instance
25971 lookup did not return a type or an event.
25973 2002-05-17 Miguel de Icaza <miguel@ximian.com>
25975 * assign.cs (CompoundAssign): We pass more semantic information
25976 now to Compound Assignments than we did before: now we have all
25977 the information at hand, and now we resolve the target *before* we
25978 do the expression expansion, which allows the "CacheValue" method
25979 to have the effect we intended (before, a [x] += 1 would generate
25980 two differen ArrayAccess expressions from the ElementAccess,
25981 during the resolution process).
25983 (CompoundAssign.DoResolve): Resolve target and original_source here.
25985 2002-05-16 Miguel de Icaza <miguel@ximian.com>
25987 * expression.cs (ArrayAccess): dropped debugging information.
25989 * typemanager.cs: Small bug fix: I was always returning i_members,
25990 instead of one of i_members or s_members (depending on which had
25993 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
25994 method is invoked before any code generation takes place, and it
25995 is a mechanism to inform that the expression will be invoked more
25996 than once, and that the method should use temporary values to
25997 avoid having side effects
25999 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26001 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26004 * expression.cs (Indirection, ArrayAccess): Add support for
26005 CacheTemporaries in these two bad boys.
26007 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26008 ldobj or ldind_ref.
26009 (StoreFromPtr): Handle stobj as well.
26011 * expression.cs (UnaryMutator): Share more code.
26013 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26014 down: I was not tracking the Filter function as well, which
26015 was affecting the results of the cache.
26017 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26019 * attribute.cs: Remove the hack to handle the CharSet property on
26022 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26024 * attribute.cs (DoResolve): More uglyness, we now only try to
26025 resolve the attribute partially, to extract the CharSet
26026 information (only if we are a StructLayout attribute). Otherwise
26028 (GetExtraTypeInfo): Add some code to conditionally kill in the
26029 future this. I am more and more convinced that the .NET
26030 framework has special code to handle the attribute setting on
26033 * expression.cs (IsParamsMethodApplicable): Revert my previous
26034 foreach change here, it was wrong.
26036 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26038 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26039 (pp_expr): do not abort on unknown input, just return.
26040 (eval): abort if there are pending chars.
26042 * attribute.cs (Attribute.Resolve): Positional parameters are
26043 optional. Deal with that case.
26045 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26046 the Ansi/Unicode/Auto information for the type.
26048 (TypeContainer.DefineType): instantiate the EmitContext here, as
26049 we will be using it during the type definition (to resolve
26050 attributes) and during the emit phase.
26052 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26053 to pull type information out of the attributes
26055 (Attribute.Resolve): track the constructor builder, and allow for
26056 multiple invocations (structs and classes will use this).
26058 * ecore.cs (MemberLookupFinal): new version with all the
26059 parameters customizable.
26061 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26062 constructors. Return if the result value is null (as the error
26063 would have been flagged already by MemberLookupFinal)
26065 Do not allow instances of abstract classes or interfaces to be
26068 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26069 We have to compare the assembly property here when dealing with
26070 FamANDAssem and Assembly access modifiers, because we might be
26071 creating an assembly from *modules* (that means that we are not
26072 getting TypeBuilders for types defined in other modules that are
26073 part of this assembly).
26075 (Method.Emit): If the method is marked abstract and has a body,
26078 (TypeContainer.DefineMembers): If both the defined member and the
26079 parent name match are methods, then do not emit any warnings: let
26080 the Method.Define routine take care of flagging warnings. But if
26081 there is a mismatch (method overrides something else, or method is
26082 overriwritten by something, then emit warning).
26084 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26085 set to null, this means `do not check for the return type on the
26088 (Method.Define): set the return type for the method signature to
26089 null, so that we get methods with the same name and parameters and
26090 different return types. This is used to flag warning 114 (you are
26091 hiding a method, and you probably want to use the new/override
26094 * typemanager.cs (MemberLookup): Implemented proper access
26095 control, closing a long standing set of bug reports. The problem
26096 was that the Framework only has two bits: Public and NonPublic,
26097 and NonPublic includes private and protected methods, but we need
26098 to enforce the FamANDAssem, FamOrAssem and Family.
26100 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26102 * statement.cs (GotoCase): Return true: Ammounts to giving up
26103 knowledge on whether we return or not, and letting the other case
26104 be responsible for it.
26106 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26108 * driver.cs: Do not load directories for each file processed, only
26109 do it if there is a pattern.
26111 * ecore.cs: Report readonly assigns here as well, as we might have
26112 been resolved only by MemberAccess.
26114 (SimpleName.SimpleNameResolve): Also be useful for LValue
26115 resolution. We need this to propagate assign to local readonly variables
26117 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26118 do not want to reuse potential criteria memory.
26120 * class.cs (MyEventBuilder): Set reflected_type;
26122 * ecore.cs (Constantify): Added support for constifying bools.
26124 (RootContext.LookupType): Added a cache for values looked up in
26125 the declaration space.
26127 * typemanager.cs (FindMembers): Now is a front-end to
26128 RealFindMembers, and provides a two-level hashtable-based cache to
26131 15% performance improvement: from 22.5 to 19.2 seconds.
26133 * expression.cs (IsParamsMethodApplicable): use foreach.
26134 (Invocation.DoResolve): ditto.
26135 (New.DoResolve): ditto.
26136 (ArrayCreation.DoResolve): ditto.
26138 * ecore.cs (FindMostEncompassingType): use foreach.
26140 * delegate.cs (NewDelegate.DoResolve): Use foreach
26142 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26143 (RemoveMethods): use foreach.
26145 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26146 nested foreach statements instead of for, and also break out of
26147 the inner loop once a match is found.
26149 (Invocation.OverloadResolve): Use foreach, simplify the code.
26151 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26153 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26154 we actually unwrap the expression to allow for extra information
26157 * expression.cs: Use Shr_Un on unsigned operations.
26159 2002-05-08 Ravi Pratap <ravi@ximian.com>
26161 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26162 applicable operators was not being considered correctly. This closes
26163 the bug Miguel reported.
26165 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26167 * attribute.cs: check that the type derives from System.Attribute
26168 and report the correct error in that case (moved the duplicate code to
26169 its own method, too).
26171 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26173 * attribute.cs: lookup attribute type name as the spec says: first the
26174 bare attribute name and then name + "Attribute" (nant compiles with
26175 mcs after this fix).
26177 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26179 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26180 Because of the way we parse things, we should try to see if a
26181 UIntConstant can fit in an integer.
26183 2002-05-07 Ravi Pratap <ravi@ximian.com>
26185 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26186 when we are in an explicit context.
26188 (ConvertReferenceExplicit): When converting from Iface type S to Class
26189 T make sure the rules are implemented as an OR.
26191 * parameter.cs (ParameterType): Make it a property for now although the
26192 purpose really isn't anything immediate.
26194 * expression.cs (Is*Applicable): Do better checking on the parameter type
26195 of a ref/out parameter. The ones from the system assemblies are already
26196 marked with the correct type so we don't need to do any correction.
26198 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26199 the object type is standard too so include that.
26201 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26203 * ecore.cs (StandardConversionExists): Augment with missing code:
26204 deal with IntConstant, LongConstants and Enumerations.
26206 * assign.cs: Report the error, instead of failing silently
26208 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26209 typecontainer that they are declared, because the
26210 typecontainer/namespace will have the list of using clauses that
26211 need to be applied.
26213 Assembly Attributes were escaping the normal registration
26216 (EmitCode): Apply attributes within an EmitContext that represents
26217 the container they were declared on.
26219 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26221 2002-05-06 Ravi Pratap <ravi@ximian.com>
26223 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26224 Revamp completely - make much cleaner as we now operate only
26227 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26228 to implement the logic detailed in the spec more correctly.
26230 (UserDefinedConversion): Update accordingly.
26232 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26234 * statement.cs: Return flow analysis information up.
26236 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26239 (token): Do not consume an extra character before calling
26242 2002-05-06 Piers Haken <piersh@friskit.com>
26244 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26246 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26248 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26249 EmitContext during the instance constructor initializer
26250 resolution, to stop access to instance variables.
26252 This is mandated by the spec, last paragraph of the `constructor
26253 initializers' section.
26255 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26257 * cs-parser.jay, class.cs (Accessor): new class used to represent
26258 an accessor (get or set). In the past we used `null' to represent
26259 a missing accessor. But this is ambiguous because there was no
26260 way to tell in abstract indexers/properties if one of them was
26263 Now there is a way of addressing that.
26265 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26266 instead of FindMembers.
26268 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26269 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26271 * attribute.cs: Treat indexers and properties as the same in terms
26272 of applying attributes
26274 * ecore.cs (FindMostEncompassedType): Use statically initialized
26275 EmptyExpressions()s like we do elsewhere to avoid creating useless
26276 objects (and we take this out of the tight loop).
26278 (GetConversionOperators): Move the code to extract the actual
26279 operators to a separate routine to clean things up.
26281 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26283 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26284 events are always registered FieldBuilders.
26286 * class.cs (FieldBase): New class shared by Fields
26288 * delegate.cs: If we are a toplevel delegate, use our full name.
26289 If we are a nested delegate, then only use our tail name.
26291 2002-05-02 Ravi Pratap <ravi@ximian.com>
26293 * expression.cs (IsApplicable): Ensure that we add the "&" to
26294 ref/out types before comparing it with the type of the argument.
26296 (IsParamsMethodApplicable): Ditto.
26298 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26301 * delegate.cs : Handle the case when we have more than one applicable
26302 method. Flag an error only when we finish checking all.
26304 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26306 * expression.cs: Add support for boolean static initializers.
26308 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26310 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26312 * parameter.cs (ComputeParameterTypes,
26313 ComputeAndDefineParameterTypes): Better error handling: now we
26314 clear the `types' cache if we fail during any of the type lookups.
26315 We also return the status code correctly to our caller
26317 * delegate.cs: If we fail to define a delegate, abort the extra
26320 * expression.cs (Binary.ResolveOperator): for
26321 operator==(object,object) and operator !=(object, object) we also
26322 have to verify that there is an implicit conversion from one to
26325 (ArrayAccess.DoResolve): Array Access can operate on
26328 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26330 * assign.cs (CompoundAssign): A new class used as a "flag" that
26331 the assignment actually is happening as part of a compound
26332 assignment operator.
26334 During compound assignment, a few new rules exist to enable things
26341 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26342 to the type of x) if y is implicitly convertible to the type of x,
26343 and the operator is a builtin operator and the return type of the
26344 operator is explicitly convertible to the type of x.
26346 * rootcontext.cs: Reset warning level to 2. 4 catches various
26347 "interesting" features in mcs, we must clean this up at some
26348 point, but currently am trying to kill other bugs ;-)
26350 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26351 in container classes as well.
26353 * expression.cs (Binary.ResolveOperator): Handle string case
26354 before anything else (as operator overloading does emit an error
26355 before doing anything else).
26357 This code could go away when we move to a table driven model, but
26358 i could not come up with a good plan last night.
26360 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26362 * typemanager.cs (CSharpName): reimplementation using regex.
26363 * class.cs: added null check for fields in Emit
26364 * rootcontext.cs: set warninglevel to 4
26366 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26368 * typemanager.cs (CSharpName): reimplemented with Lupus
26371 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26373 * statement.cs (If): correclty implement Resolve, because we were
26374 not catching sem errors in there. The same process is needed
26376 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26379 (Statement.Warning_DeadCodeFound): Factorize code.
26380 (While): Report dead code here too.
26382 (Statement): Added Resolve virtual method to allow
26383 for resolution split from the emit code.
26385 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26387 * statement.cs (EmitBoolExpression): No longer try to resolve the
26389 (MakeBoolean): New utility function that resolve, implicitly
26390 converts to boolean and tags the expression.
26393 (If, Do): Implement dead code elimination.
26394 (While): Implement loop inversion
26396 (Do, While, For, If): Resolve the expression prior to calling our
26399 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26402 - added method Report28 (warning: program has more than one entry point)
26403 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26404 - modified method Method.Define, the part at the end of the method
26406 * rootcontext.cs: added static public Location EntryPointLocation;
26408 * ../errors/cs0028.cs : Add test case for the above warning.
26411 - modified method CSharpName to allow arrays of primitive type to
26412 be printed nicely (e.g. instead of System.Int32[][] it now prints
26414 - added method CSharpSignature: returns the signature of a method
26415 in string format to be used in reporting errors, warnings, etc.
26417 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26420 2002-04-26 Ravi Pratap <ravi@ximian.com>
26422 * delegate.cs (Define): Fix extremely silly bug where I was
26423 setting the type of the 'object' parameter of the BeginInvoke
26424 method to System.IAsyncResult instead of System.Object ;-)
26426 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26428 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26431 (Constructor.Emit): return if we fail to initialize the
26432 constructor. Another door closed!
26434 * expression.cs (New.DoResolve): Improve error message (from -6 to
26435 1501). Use DeclaredOnly lookup to find the exact constructor.
26437 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26438 loop. This is useful.
26440 * cs-parser.jay: Adjust the default parameters so that destructors
26441 have the proper signature.
26443 2002-04-26 Martin Baulig <martin@gnome.org>
26445 * driver.cs (LoadAssembly): If `assembly' contains any characters
26446 which are only valid in path names and not in assembly names
26447 (currently slash, backslash and point), use Assembly.LoadFrom ()
26448 instead of Assembly.Load () on the `assembly' (before iteration
26449 over the link_paths).
26451 2002-04-26 Martin Baulig <martin@gnome.org>
26453 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26455 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26457 * class.cs (Property): use the new typemanager.MemberLookup
26459 (TypeContainer.MemberLookup): Implement using the
26460 TypeManager.MemberLookup now.
26462 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26463 and return MemberInfos, so that these can be used without an
26464 EmitContext (what we had before).
26466 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26468 * expression.cs: Fix the case where the argument to params if the
26469 type of the params. I omitted handling this before. Fixed
26471 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26473 * driver.cs: Call BootCorlib_PopulateCoreType
26475 * class.cs (Property.CheckBase): Check for properties only, not
26478 * interface.cs: Temporary hack: try/catch around the
26479 CustomAttributeBuilder, because I am getting an exception that I
26482 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26483 types whose definitions are required to be there (attributes are
26484 defined before standard types).
26486 Compute definitions as we boot the various types, as they are used
26487 immediately (value_type class will need object_type, but if we do
26488 not initialize object_type, we will pass a null, which will let
26489 the runtime pick the System.Object from the existing corlib, which
26490 is not what we want).
26492 2002-04-22 Patrik Torstensson <totte@labs2.com>
26494 * cs-tokenizer.cs: fixed a number of trim() issues.
26496 2002-04-22 Ravi Pratap <ravi@ximian.com>
26498 * expression.cs (Argument.Type): Ensure that we return the correct
26499 type when we have out or ref parameters [in which case we
26502 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26504 * class.cs (Property, Indexer): Allow extern modifier in there.
26506 * typemanager.cs (InitBaseTypes): Initializes object_type and
26507 value_type, since those will be used early on during the bootstrap
26508 process to compile corlib.
26510 (InitCoreTypes): Move code from here to InitBaseTypes.
26512 2002-04-21 Miguel de Icaza <miguel@ximian.com>
26514 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
26515 single-dimension arrays as using the ldlen opcode.
26517 Daniel Lewis discovered this optimization.
26519 * typemanager.cs: Add signature for System.Array::get_Length
26521 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26523 * statement.cs: report the error when the foreach does not apply to an
26524 array nor a collection.
26526 2002-04-19 Miguel de Icaza <miguel@ximian.com>
26528 * expression.cs: Add implicit conversions to the operator ~.
26530 * constant.cs (DecimalConstant.Emit): Emit decimal value.
26532 * typemanager.cs: Locate the decimal constructor.
26534 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26536 * attribute.cs: use the new property of TypeOf.
26537 * expression.cs: added 'get' property around typearg.
26539 These changes fix a build breaker reported by NickD. Is this the
26540 correct way to fix? If not, please, revert my changes and make it
26543 2002-04-17 Miguel de Icaza <miguel@ximian.com>
26545 * attribute.cs: Add support for typeof in attribute invocations.
26546 I am not sure that this is right though.
26548 2002-04-14 Duncan Mak <duncan@ximian.com>
26550 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
26551 Binary.Operator.Division case.
26553 2002-04-13 Ravi Pratap <ravi@ximian.com>
26555 * class.cs (DefineType): Ensure that we do a proper check on
26556 attribute types and also register it with the TypeManager.
26558 (TypeContainer.Targets): The default for attribute types is
26559 AttributeTargets.All.
26561 * attribute.cs (ApplyAttributes): Registering the attribute type
26562 is done elsewhere, not when we discover we have a Usage attribute.
26564 2002-04-12 Ravi Pratap <ravi@ximian.com>
26566 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
26567 and get rid of is_delegate parameter.
26569 * everywhere : update.
26571 2002-04-12 Ravi Pratap <ravi@ximian.com>
26573 * cs-parser.jay (compilation_unit): Revamp completely to use
26574 some new ideas that I got from Rhys' grammar to solve the problems
26575 with assembly level attributes.
26577 (outer_declaration): New grammar production.
26579 (attribute_sections): Add.
26581 (opt_attributes): Base on attribute_sections
26583 (namespace_declaration): Allow opt_attributes to tackle the case
26584 when we have assembly level attributes - we are clever in this
26587 * attribute.cs (ApplyAttributes): Do not worry about assembly
26588 attributes in the non-global context.
26590 * rootcontext.cs (AddGlobalAttributes): Go back to using this
26591 instead of SetGlobalAttributes.
26593 * class.cs, rootcontext.cs : Ensure we define and generate
26594 attribute types before anything else.
26596 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
26597 and flag the new error -20 for the case when the attribute type
26598 does not have valid targets specified. csc does not catch this.
26600 * ../errors/errors.txt : update for error # -20
26602 2002-04-11 Ravi Pratap <ravi@ximian.com>
26604 * support.cs (InternalParameters.ParameterModifier): Do some null
26605 checking and return sane values.
26607 * class.cs (Method.Define): If we are a PInvoke method, ensure
26608 that we are static and extern. Report error # 601
26610 * ../errors/cs0601.cs : Add test case for the above error.
26612 2002-04-07 Ravi Pratap <ravi@ximian.com>
26614 * rootcontext.cs (attribute_types): We need to keep type of
26615 all attribute types separately and emit code for them first.
26617 (RegisterAttribute) : Implement.
26619 * class.cs (DefineType): Check if the current Type is a custom
26620 attribute type and register it accordingly.
26622 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
26623 adding the first attribute twice and rename to
26625 (SetGlobalAttributes): this.
26627 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
26630 * attribute.cs (ApplyAttributes): Take an additional argument telling us
26631 if we are processing global arguments. Hmm, I am unsure of this.
26633 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26635 * expression.cs: added static array of strings to avoid calling
26636 Enum.ToString () for Operator in Binary. Significant recover of
26639 2002-04-10 Miguel de Icaza <miguel@ximian.com>
26641 * class.cs (FindMembers): Allow the Builders of the various
26642 members to be null. If they are skip them. This only happens
26643 during the PInvoke declaration.
26645 2002-04-09 Miguel de Icaza <miguel@ximian.com>
26647 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
26648 failure, so we do not keep going afterwards.
26650 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
26651 wanted to pass `false' as the `is_delegate' argument. If this is
26652 the case, why not use delegate_type == null to mean `is_delegate =
26653 false' and anything else as is_delegate = true.
26655 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
26657 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
26658 code for the section, not the beginning of the tests.
26660 2002-04-08 Miguel de Icaza <miguel@ximian.com>
26662 * cfold.cs: Handle operator + (Enum x, Underlying x)
26664 * expression.cs (Binary): same. Warn about errors where we have
26665 Enum/Enum in operator + as well.
26667 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
26670 - added support for switch(bool)
26671 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
26672 - add TableSwitchEmit() to handle table-based switch statements
26674 2002-04-05 Ravi Pratap <ravi@ximian.com>
26676 * expression.cs (Invocation.OverloadResolve): Factor out code which
26677 does parameter compatibility checking with arguments so that we can
26678 re-use the code even from Delegate.VerifyApplicability
26680 (VerifyArgumentsCompat): Move above code here.
26682 * delegate.cs (VerifyApplicability): Get rid of duplicate code
26683 and instead make a call to the above method.
26685 2002-03-31 Ravi Pratap <ravi@ximian.com>
26687 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
26688 We use it to keep track of classes which are attribute types.
26690 2002-04-02 Miguel de Icaza <miguel@ximian.com>
26692 * delegate.cs (Delegate.Define): Correctly define the types in the
26693 presence of fixed and array parameters.
26695 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
26698 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
26699 include NonPublic after the first iteration.
26701 * class.cs (Indexer.CheckBase): Only check if both parents are
26704 * cs-parser.jay (accessor_body): If empty, set to null.
26706 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
26707 same code path here to resolve constants names that we did have in
26708 MemberAccess.DoResolve. There is too much code duplicated here.
26710 2002-04-01 Miguel de Icaza <miguel@ximian.com>
26712 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
26714 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
26717 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
26718 tokens, numbers and strings.
26720 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
26723 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
26724 asyncronous parameters and the regular parameters.
26726 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
26727 specify the target directory.
26729 * expression.cs: (This.DoResolve): Simplify
26730 (As.Emit): Optimize, do not generate IsInst if the expression is
26731 always of the given type.
26733 (Is.DoResolve): Bug fix, we were reporting both always/never for
26736 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
26737 creating too many unnecessary arrays.
26739 2002-03-31 Miguel de Icaza <miguel@ximian.com>
26741 * class.cs (EmitFieldInitializer): Use Assign expression to assign
26742 fields instead of rolling our own initializer. Takes care of all
26743 implicit conversions, and drops unnecessary static checks/argument.
26745 2002-03-31 Dick Porter <dick@ximian.com>
26747 * driver.cs: use the GetDirectories() return values properly, and
26748 use "/" as path separator.
26750 2002-03-30 Miguel de Icaza <miguel@ximian.com>
26752 * expression.cs (Unary): Optimize - - expr into expr.
26753 (Binary): Optimize a + (-b) into a -b.
26755 * codegen.cs (CodeGen): Made all methods static.
26757 2002-03-29 Miguel de Icaza <miguel@ximian.com>
26761 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
26762 TypeBuilder property.
26764 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
26767 * tree.cs: Removed the various RecordXXXX, and replaced with a
26768 single RecordDecl. Removed all the accessor methods, and just
26769 left a single access point Type
26771 * enum.cs: Rename DefineEnum to DefineType.
26773 * decl.cs: New abstract method `DefineType' used to unify the
26774 Defines for Enumerations, Interfaces, TypeContainers and
26777 (FindType): Moved LookupInterfaceOrClass here. Moved the
26778 LookupBaseClasses method that used to live in class.cs and
26779 interface.cs here, and renamed to FindType.
26781 * delegate.cs: Implement DefineType. Take advantage of the
26782 refactored pattern for locating the parent builder without taking
26783 the parent_builder argument (which we know does not work if we are
26784 nested, and triggering a toplevel definition).
26786 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26788 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
26789 accessibility of a member has changed during override and report
26792 * class.cs (Method.Define, Property.Define): Only complain on
26793 overrides if the method is private, any other accessibility is
26794 fine (and since we just checked the permission is the same, we are
26797 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
26798 and elif are processed always. The other pre-processing
26799 directives are only processed if we are "taking" the path
26801 2002-03-29 Martin Baulig <martin@gnome.org>
26803 * class.cs (Method.Emit): Only emit symbolic debugging info if the
26804 current location is not Null.
26806 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
26807 a separate method so we can profile it.
26809 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
26810 `span.Seconds' are just seconds, but no minutes or hours.
26811 (MainDriver): Profile the CodeGen.SaveSymbols calls.
26813 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26815 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
26816 Remove the gratuitous set of Final:
26818 // If an interface implementation, then we can set Final.
26819 if (((flags & MethodAttributes.Abstract) == 0) &&
26820 implementing.DeclaringType.IsInterface)
26821 flags |= MethodAttributes.Final;
26823 I do not know what I was smoking when I used that.
26826 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
26827 step into fixing the name resolution issues for delegates and
26828 unifying the toplevel name resolution.
26830 2002-03-28 Martin Baulig <martin@gnome.org>
26832 * class.cs (Method.Emit): If we have a symbol writer, call its
26833 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
26834 tell it about the current method.
26836 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
26837 writer that we're going to emit the first byte of IL code for a new
26838 statement (a new source line).
26839 (EmitContext.EmitTopBlock): If we have a symbol writer, call
26840 EmitContext.Mark() before emitting any code.
26842 * location.cs (SymbolDocument): Return null when we're Null.
26844 * statement.cs (Statement): Moved the `Location loc' variable here.
26845 (Statement.EmitBoolExpression): If we have a symbol writer, call
26846 ec.Mark() before emitting any code to tell it that we're at the
26847 beginning of a new statement.
26848 (StatementExpression): Added `Location' argument to the constructor.
26849 (Block): Added public readonly variable `StartLocation' and public
26850 variable `EndLocation'. The latter is to be set using SetEndLocation().
26851 (Block): Added constructor which takes a start and end location.
26852 (Block.SetEndLocation): New method. This sets the end location.
26853 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
26854 local variables we create.
26855 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
26856 each statement and do also mark the begin and end of the block.
26858 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
26859 tell it the current lexer.Location, use Location.Null for the end of the
26861 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
26862 current block, set its end location using SetEndLocation().
26863 (statement_expression): StatementExpression constructor now takes the
26864 lexer.Location as additional argument.
26865 (for_statement, declare_local_variables): Likewise.
26866 (declare_local_variables): When creating a new implicit block, use the
26867 new Block constructor and pass it the lexer.Location.
26869 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26871 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
26872 members also on the parent interfaces recursively.
26874 2002-03-27 Miguel de Icaza <miguel@ximian.com>
26876 * report.cs: Use new formats, since Gonzalo finished the missing
26879 * expression.cs (Binary.ResolveOperator): added missing operator|
26880 operator& and operator^ for bool/bool.
26882 * cs-parser.jay: CheckDef now takes a Location argument that is
26883 used to report errors more precisly (instead of reporting the end
26884 of a definition, we try to track something which is a lot closer
26885 to the source of the problem).
26887 * cs-tokenizer.cs: Track global token use, so we can properly flag
26888 the use of #define/#undef after the first token has been seen.
26890 Also, rename the reportXXXX to Error_DescriptiveName
26892 * decl.cs (DeclSpace.IsTopLevel): Move property here from
26893 TypeContainer, so that Enum and Interface can use this too.
26895 * class.cs (TypeContainer.LookupInterfaceOrClass,
26896 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
26897 `builder' argument. Typically this was used to pass the parent
26898 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
26901 The problem is that a nested class could trigger the definition of
26902 a toplevel class, and the builder would be obviously wrong in that
26905 So we drop this argument, and we compute dynamically the
26906 TypeBuilder/ModuleBuilder (the correct information was available
26907 to us anyways from DeclSpace.Parent)
26909 * interface.cs (Interface.DefineInterface): Drop builder
26910 parameter cleanup like class.cs
26912 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
26915 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
26918 (Try.Emit): Propagate the returns value from the statement.
26920 (Return.Emit): Even if we are leavning
26922 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
26924 * modifiers.cs: Fix the computation of MethodAttributes flags.
26926 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
26928 * driver.cs: allow compilation of files that start with '/'.
26929 Add a default case when checking the argument of --target.
26931 2002-03-25 Miguel de Icaza <miguel@ximian.com>
26933 * interface.cs: Implement the same search algorithm for types in
26934 the interface code.
26936 * delegate.cs: Do not allow multiple definition.
26938 * Recovered ChangeLog that got accidentally amputated
26940 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
26942 * rootcontext.cs: Load manually enum to allow core classes to
26943 contain enumerations.
26945 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
26946 Update to new static methods in TypeManager.
26948 * typemanager.cs (GetMethod, GetConstructor): Use our
26949 implementation of FindMembers to find the members, since during
26950 corlib compilation, the types are TypeBuilders and GetMethod and
26951 GetConstructor do not work.
26953 Make all methods in TypeManager static.
26955 (InitCodeHelpers): Split the functionality from
26956 the InitCodeTypes function.
26958 * driver.cs: Call InitCodeHelpers after we have populated the
26961 * cs-parser.jay (delegate_declaration): we did not used to compute
26962 the delegate name correctly for void delegates.
26964 2002-03-24 Miguel de Icaza <miguel@ximian.com>
26966 * rootcontext.cs (RootContext): Init the interface_resolve_order
26967 and type_container_resolve_order always.
26969 (ResolveCore, BootstrapCorlib_ResolveClass,
26970 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
26971 compiler when compiling with --nostdlib
26973 * class.cs (TypeContainer.DefineType): Check that our parent is
26974 not null. This test is most important when we are bootstraping
26977 * codegen.cs: Split out the symbol writing code.
26979 2002-03-25 Martin Baulig <martin@gnome.org>
26981 * driver.cs (-g): Made -g an alias for --debug.
26983 2002-03-24 Martin Baulig <martin@gnome.org>
26985 * codegen.cs (SymbolWriter): New public variable. Returns the
26986 current symbol writer.
26987 (CodeGen): Added `bool want_debugging_support' argument to the
26988 constructor. If true, tell the ModuleBuild that we want debugging
26989 support and ask it for the ISymbolWriter.
26990 (Save): If we have a symbol writer, call it's Close() method after
26991 saving the assembly.
26993 * driver.c (--debug): New command line argument to create a
26994 debugger information file.
26996 * location.cs (SymbolDocument): New public property. Returns an
26997 ISymbolDocumentWriter object for the current source file or null
26998 if we don't have a symbol writer.
27000 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27002 * driver.cs (LoadAssembly): Correctly return when all the paths
27003 have been tried and not before.
27005 * statement.cs (Switch.Emit): return the actual coverage for this
27006 statement (returns/not-returns)
27008 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27009 switch of the statement if we are the last switch section. That
27010 kills two problems: try/catch problems (we used to emit an empty
27011 nop at the end) and switch statements where all branches would
27014 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27016 * driver.cs: Add default assemblies (the equivalent to the
27017 Microsoft CSC.RSP file)
27019 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27020 also update tokens_seen and set it to false.
27022 * driver.cs: Implement --recurse for Mike.
27024 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27025 correctly splitting out the paths.
27027 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27029 * interface.cs (Interface.PopulateProperty): Instead of using
27030 `parent' as the declaration space for the set parameters, use
27033 * support.cs (InternalParameters): InternalParameters constructor
27034 takes a DeclSpace instead of a TypeContainer.
27036 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27037 types are being initialized, load the address of it before calling
27040 (New): Provide a mechanism to disable the generation of local
27041 value type temporaries when the caller will be providing us with
27042 an address to store it.
27044 (ArrayCreation.EmitDynamicInitializers): Use it.
27046 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27048 * expression.cs (Invocation.EmitArguments): Only probe for array
27049 property if there is more than one argument. Sorry about that.
27051 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27052 empty param arrays.
27054 * class.cs (Method.LabelParameters): Fix incorrect code path that
27055 prevented the `ParamArrayAttribute' from being applied to the
27058 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27060 * support.cs (ReflectionParameters): Correctly compute whether the
27061 last argument is a params array. Fixes the problem with
27064 * typemanager.cs: Make the assemblies array always be non-null
27065 (empty, but non-null)
27067 * tree.cs (RecordDecl): New function that abstracts the recording
27068 of names. This reports error 101, and provides a pointer to the
27069 previous declaration. Fixes a crash in the compiler.
27071 * cs-parser.jay (constructor_declaration): Update to new grammar,
27072 and provide a constructor_body that can be empty.
27074 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27076 * driver.cs: Add support for --resources.
27078 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27079 Make all types for the various array helper methods be integer.
27081 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27082 CheckState to ConvCast.
27084 (ConvCast): Now it takes a `checked' state argument, to avoid
27085 depending on the emit context for the conversion, and just using
27086 the resolve time setting.
27088 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27089 instead of Invocation.EmitArguments. We do not emit the original
27090 arguments, instead we emit those which have been converted to
27091 unsigned int expressions.
27093 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27095 * codegen.cs: ditto.
27097 * expression.cs (LocalVariableReference): Drop the use of the
27098 Store function that depended on the variable index.
27100 * statement.cs (VariableInfo): Drop the `Idx' property from this
27101 class, as this is not taking into account the indexes for
27102 temporaries tat we generate during the execution, getting the
27105 * class.cs: First emit class initializers, then call the parent
27108 * expression.cs (Binary): Fix opcode emision.
27109 (UnaryMutator.EmitCode): Support checked code generation
27111 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27112 matches for events for both the Static and Instance scans,
27113 pointing to the same element. Fix that.
27115 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27117 * rootcontext.cs (ResolveTree): Always set the
27118 interface_resolve_order, because nested interfaces will be calling
27121 * class.cs (GetInterfaceOrClass): Track the same resolution
27122 process used by TypeManager.LookupType. This fixes the nested
27123 type lookups in class declarations (separate path from
27126 (TypeContainer.DefineType): Also define nested interfaces.
27127 (TypeContainer.RegisterOrder): New public function used to
27128 register the order in which child interfaces need to be closed.
27130 Nested interfaces need to be closed after their parents have been
27133 * interface.cs (InterfaceAttr): Put all the logic for computing
27134 the interface attribute here.
27136 (DefineInterface): Register our interface order with the
27137 RootContext or with the TypeContainer depending on the case.
27139 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27141 * cs-parser.jay: rework foreach statement to work with the new
27142 changes to the policy on SimpleNames.
27144 * report.cs: support Stacktrace on warnings as well.
27146 * makefile: drop --unsafe and /unsafe from the compile.
27148 2002-03-13 Ravi Pratap <ravi@ximian.com>
27150 * ecore.cs (StandardConversionExists): Modify to take an Expression
27151 as the first parameter. Ensure we do null -> reference type conversion
27154 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27155 temporary Expression objects.
27157 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27159 * interface.cs: workaround bug in method overloading resolution
27160 (there is already a bugzilla bug for it).
27162 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27164 We could also solve this problem by having a separate path for
27165 performing type lookups, instead of DoResolve, we could have a
27166 ResolveType entry point, and only participating pieces of the
27167 production (simplename, deref, array) would implement this.
27169 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27170 signal SimpleName to only resolve type names and not attempt to
27171 resolve anything else.
27173 * expression.cs (Cast): Set the flag.
27175 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27177 * class.cs: Only report 108 if there is no `new' modifier.
27179 * cs-parser.jay: rework foreach statement to work with the new
27180 changes to the policy on SimpleNames.
27182 * report.cs: support Stacktrace on warnings as well.
27184 * makefile: drop --unsafe and /unsafe from the compile.
27186 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27188 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27189 lookups here, instead of doing that at parse time. This means
27190 that our grammar will not introduce `LocalVariableReferences' as
27191 expressions at this point. That solves the problem of code like
27195 static void Main ()
27199 This is only half the fix. The full fix requires parameters to
27200 also be handled in this way.
27202 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27203 makes the use more obvious of the DeclSpace. The
27204 ec.TypeContainer.TypeBuilder is now only used to pull the
27205 TypeBuilder for it.
27207 My theory is that I can get rid of the TypeBuilder completely from
27208 the EmitContext, and have typecasts where it is used (from
27209 DeclSpace to where it matters).
27211 The only pending problem is that the code that implements Aliases
27212 is on TypeContainer, and probably should go in DeclSpace.
27214 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27215 lookups here, instead of doing that at parse time. This means
27216 that our grammar will not introduce `LocalVariableReferences' as
27217 expressions at this point. That solves the problem of code like
27221 static void Main ()
27225 This is only half the fix. The full fix requires parameters to
27226 also be handled in this way.
27228 * class.cs (Property.DefineMethod): When implementing an interface
27229 method, set newslot, when implementing an abstract method, do not
27230 set the flag (before we tried never setting it, or always setting
27231 it, which is the difference).
27232 (Indexer.DefineMethod): same.
27233 (Method.DefineMethod): same.
27235 * ecore.cs: Only set the status used flag if we get back a Field.
27237 * attribute.cs: Temporary hack, so Paolo can keep working.
27239 2002-03-08 Ravi Pratap <ravi@ximian.com>
27241 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27242 the unmanaged type in the case we have a MarshalAs attribute.
27244 (Resolve): Handle the case when we are parsing the special MarshalAs
27245 attribute [we need to store the unmanaged type to use later]
27247 * typemanager.cs (marshal_as_attr_type): Built in type for the
27248 MarshalAs Attribute.
27250 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27251 on parameters and accordingly set the marshalling info.
27253 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27255 * class.cs: Optimizing slightly by removing redundant code after
27256 we switched to the `NoTypes' return value.
27257 (Property.DefineMethod): use NoTypes here too.
27259 This fixes the bug I introduced in my last batch of changes.
27261 2002-03-05 Ravi Pratap <ravi@ximian.com>
27263 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27265 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27266 Enums since those are types too.
27268 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27270 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27271 thanks to a call during the lookup process.
27273 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27275 * statement.cs (Foreach): Lots of work to accomodate a particular
27276 kind of foreach statement that I had not kept in mind. It is
27277 possible to have foreachs on classes that provide a GetEnumerator
27278 method that return objects that implement the "pattern" for using
27279 a foreach, there is no need to support GetEnumerator
27282 This is needed to compile nant.
27284 * decl.cs: Only report 114 if the member is not `Finalize' and if
27285 the warning level is at least 2.
27287 * class.cs: Moved the compare function from Method to
27290 (MethodSignature.InheritableMemberSignatureCompare): Add new
27291 filter function that is used to extract inheritable methods from a
27294 (Method.Define): Use the new `inheritable_method_signature_filter'
27297 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27300 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27302 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27304 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27306 * expression.cs: Pass location information to
27307 ConvertImplicitStandard.
27309 * class.cs: Added debugging code to track return values from
27312 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27314 * expression.cs (Is.DoResolve): If either side of the `is' is an
27315 interface, do not flag the warning.
27317 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27320 * report.cs: Allow for --fatal to be used with --probe.
27322 * typemanager.cs (NoTypes): Move the definition for the empty Type
27325 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27327 (TypeContainer.DefineProxy): New function used to proxy to parent
27328 implementations when implementing interfaces.
27329 (TypeContainer.ParentImplements): used to lookup if our parent
27330 implements a public function that is required by an interface.
27331 (TypeContainer.VerifyPendingMethods): Hook this up.
27333 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27334 `modules' and `assemblies' arraylists into arrays. We only grow
27335 these are the very early start up of the program, so this improves
27336 the speedof LookupType (nicely measured).
27338 * expression.cs (MakeByteBlob): Replaced unsafe code with
27339 BitConverter, as suggested by Paolo.
27341 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27342 folding of string concatenation, but if either side is a string,
27343 and the other is not, then return null, and let the runtime use
27344 the concatenation on the string plus the object (using
27345 `Object.ToString').
27347 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27349 Constant Folding has been implemented now.
27351 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27352 the error instead on types that are not supported in one's
27355 * constant.cs (Constant and all children): New set of functions to
27356 perform implict and explicit conversions.
27358 * ecore.cs (EnumConstant): Implement the new functions to perform
27359 conversion by proxying to the child expression.
27361 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27362 own separate setting that can not be turned off from the command
27363 line using --unchecked or --checked and is only controlled using
27364 the checked/unchecked statements and expressions. This setting is
27365 used by the constant folder to flag errors.
27367 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27368 ConstantCheckState as well.
27370 During Resolve, they also have to flag the state, because the
27371 constant folder runs completely in the Resolve phase.
27373 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27376 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27378 * cfold.cs: New file, this file contains the constant folder.
27380 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27381 argument to track whether we are using the resulting address to
27382 load or store a value and provide better error messages.
27384 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27385 new AddressOf arguments.
27387 * statement.cs (Foreach.EmitCollectionForeach): Update
27389 * expression.cs (Argument.Emit): Call AddressOf with proper
27390 arguments to track usage.
27392 (New.DoEmit): Call AddressOf with new arguments.
27394 (Unary.Emit): Adjust AddressOf call.
27396 2002-03-01 Ravi Pratap <ravi@ximian.com>
27398 * cs-parser.jay (member_access): Change the case for pre-defined types
27399 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27402 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27405 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27406 essentially like methods and apply attributes like MethodImplOptions to them too.
27408 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27411 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27412 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27415 * Update code everywhere accordingly.
27417 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27419 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27421 2002-02-28 Ravi Pratap <ravi@ximian.com>
27423 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27424 try performing lookups against those instead of jumping straight into using
27425 the 'using' clauses.
27427 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27429 (LookupType): Perform lookups in implicit parents too.
27431 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27432 sequence as RootContext.LookupType.
27434 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27435 the various cases of namespace lookups into this method.
27437 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27439 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27440 in positional arguments)
27442 * class.cs (Operator): Update the AllowedModifiers to contain
27445 * cs-parser.jay: Update operator declaration to allow for the
27446 operator body to be empty.
27448 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27451 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27453 * class.cs (Method.Emit): Label parameters.
27455 * driver.cs: Return 1 or 0 as the program exit code.
27457 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27459 * expression.cs: Special case the `null' object when trying to
27460 auto-compute the type, as anything can be explicitly converted to
27463 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27464 spotting this Paolo.
27466 (Expression.ImplicitNumericConversion): Perform comparissions of
27467 the type using the underlying type in the case of an enumeration
27468 rather than using the enumeration type for the compare.
27470 Cope with the underlying == type case, which is not possible to
27473 (Expression.ConvertNumericExplicit): Perform comparissions of
27474 the type using the underlying type in the case of an enumeration
27475 rather than using the enumeration type for the compare.
27477 * driver.cs: If the user does not supply an extension, assume .exe
27479 * cs-parser.jay (if_statement): Rewrote so that we can track the
27480 location for the if statement.
27482 * expression.cs (Binary.ConstantFold): Only concat strings when
27483 the operation is "+", not everything ;-)
27485 * statement.cs (Statement.EmitBoolExpression): Take a location
27487 (If, While, Do): Track location.
27489 * expression.cs (Binary.ResolveOperator): In the object + string
27490 case, I was missing a call to ConvertImplicit
27492 2002-02-25 Ravi Pratap <ravi@ximian.com>
27494 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
27495 Location arguments. Ensure we use RootContext.LookupType to do our work
27496 and not try to do a direct Type.GetType and ModuleBuilder.GetType
27498 * interface.cs (PopulateMethod): Handle the type of the parameter being
27501 * expression.cs (Invocation.BetterFunction): Handle the case when we
27502 have a params method with no fixed arguments and a call is made with no
27505 2002-02-25 Miguel de Icaza <miguel@ximian.com>
27507 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
27508 the verbatim-string-literal
27510 * support.cs (InternalParameters.ParameterModifier): handle null
27512 (InternalParameters.ParameterType): ditto.
27514 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
27515 duplicating the name of the variable parameter.
27516 (GetParameterByName): Fix bug where we were not looking up array
27517 paramters if they were the only present (thanks Paolo!).
27518 (GetParameterInfo): We only have an empty set of types if both
27519 fixed and array are set to null.
27520 (GetParameterInfo-idx): Handle FixedParameter == null
27522 * cs-parser.jay: Handle the case where there is no catch
27523 statements (missing null test).
27525 2002-02-22 Miguel de Icaza <miguel@ximian.com>
27527 * driver.cs (MainDriver): Be conservative on our command line
27530 Catch DirectoryNotFoundException when calling GetFiles.
27532 (SplitPathAndPattern): Used to split the input specification into
27533 a path and a pattern that we can feed to Directory.GetFiles.
27535 2002-02-21 Miguel de Icaza <miguel@ximian.com>
27537 * statement.cs (Fixed): Implement the last case of the Fixed
27538 statement (string handling).
27540 * expression.cs (StringPtr): New class used to return a char * to
27541 a string; Used by the Fixed statement.
27543 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
27545 * expression.cs (Binary.ResolveOperator): Remove redundant
27546 MemberLookup pn parent type.
27547 Optimize union call, we do not need a union if the types are the same.
27548 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
27551 Specialize the use of MemberLookup everywhere, instead of using
27552 the default settings.
27554 (StackAlloc): Implement stackalloc keyword.
27556 * cs-parser.jay: Add rule to parse stackalloc.
27558 * driver.cs: Handle /h, /help, /?
27560 * expression.cs (MakeByteBlob): Removed the hacks we had in place
27561 before we supported unsafe code.
27563 * makefile: add --unsafe to the self compilation of mcs.
27565 2002-02-20 Miguel de Icaza <miguel@ximian.com>
27567 * expression.cs (PointerArithmetic): New class that is used to
27568 perform pointer arithmetic.
27569 (Binary.Resolve): Handle pointer arithmetic
27570 Handle pointer comparission.
27571 (ArrayPtr): Utility expression class that is used to take the
27572 address of an array.
27574 (ElementAccess): Implement array access for pointers
27576 * statement.cs (Fixed): Implement fixed statement for arrays, we
27577 are missing one more case before we are done.
27579 * expression.cs (Indirection): Implement EmitAssign and set the
27580 ExprClass to Variable. This allows pointer dereferences to be
27581 treated as variables, and to have values assigned to them.
27583 * ecore.cs (Expression.StoreFromPtr): New utility function to
27584 store values dereferencing.
27586 2002-02-20 Ravi Pratap <ravi@ximian.com>
27588 * expression.cs (Binary.ResolveOperator): Ensure that we are
27589 not trying to operate on a void type - this fixes the reported
27592 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
27593 the parent implementation is sealed.
27595 * ../errors/cs0239.cs : Add.
27597 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
27599 * typemanager.cs (unverifiable_code_type): Corresponds to
27600 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
27601 which have unsafe code in them.
27603 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
27606 2002-02-19 Miguel de Icaza <miguel@ximian.com>
27608 * cs-tokenizer.cs: Add support for @"litreal strings"
27610 Make tokenizer accept pre-processor directives
27611 on any column (remove the old C-like limitation).
27613 * rootcontext.cs (EmitCode): Emit any global attributes.
27614 (AddGlobalAttributes): Used to keep track of assembly attributes.
27616 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
27618 * cs-parser.jay: Add support for global attributes.
27620 2002-02-17 Miguel de Icaza <miguel@ximian.com>
27622 * expression.cs (Indirection): New helper class. Unary will
27623 create Indirection classes to be able to implement the
27624 IMemoryLocation interface on it.
27626 2002-02-16 Miguel de Icaza <miguel@ximian.com>
27628 * cs-parser.jay (fixed_statement): reference the right statement.
27630 * statement.cs (Fixed.Emit): Finish implementing the fixed
27631 statement for the &x case.
27633 2002-02-14 Miguel de Icaza <miguel@ximian.com>
27635 * class.cs (Property.Define, Method.Define): Remove newslot when
27638 * modifiers.cs: My use of NewSlot when `Abstract' was set was
27639 wrong. NewSlot should only be used if the `new' keyword is present.
27641 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
27642 locating our system dir. Sorry about this.
27644 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27646 * driver.cs (GetSystemDir): Compute correctly the location of our
27647 system assemblies. I was using the compiler directory instead of
27648 the library directory.
27650 2002-02-13 Ravi Pratap <ravi@ximian.com>
27652 * expression.cs (BetterFunction): Put back in what Miguel commented out
27653 since it is the correct fix. The problem is elsewhere ;-)
27655 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
27656 parameters of the parms method are themselves compatible or not !
27658 (StandardConversionExists): Fix very dangerous bug where we were forgetting
27659 to check that a class implements an interface before saying that an implicit
27660 conversion was allowed. Use ImplementsInterface to do the checking.
27662 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27664 * class.cs (Method.Define): Track whether we are an explicit
27665 implementation or not. And only call DefineMethodOverride if we
27666 are an explicit implementation.
27668 (Property.DefineMethod): Ditto.
27670 2002-02-11 Ravi Pratap <ravi@ximian.com>
27672 * expression.cs (BetterFunction): Catch hideous bug which was
27673 preventing us from detecting ambiguous calls due to implicit casts i.e
27676 2002-01-29 Miguel de Icaza <miguel@ximian.com>
27678 * support.cs (Pair): Remove un-needed method. I figured why I was
27679 getting the error in cs-parser.jay, the variable in a foreach loop
27680 is readonly, and the compiler does not really treat this as a variable.
27682 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
27683 instead of EQUALS in grammar.
27685 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
27687 * expression.cs (Unary.DoResolve): Check whether the argument is
27690 2002-01-28 Miguel de Icaza <miguel@ximian.com>
27692 * support.cs: Api for Pair to set a value. Despite the fact that
27693 the variables are public the MS C# compiler refuses to compile
27694 code that accesses the field if the variable is part of a foreach
27697 * statement.cs (Fixed): Begin implementation of the fixed
27700 (Block.AddVariable): Return the VariableInfo on success and null
27701 on failure instead of true/false.
27703 * cs-parser.jay (foreach): Catch errors on variables already
27704 defined (we were ignoring this value before) and properly unwind
27705 the block hierarchy
27707 (fixed_statement): grammar for the fixed statement.
27709 2002-01-25 Miguel de Icaza <miguel@ximian.com>
27711 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
27712 pointer types to be incretemented.
27714 (SizeOf): Implement.
27716 * cs-parser.jay (pointer_member_access): Implement
27717 expr->IDENTIFIER production.
27719 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
27720 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
27723 (Unary): Implement indirection.
27725 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
27726 use in non-unsafe context).
27728 (SimpleName.DoResolve): Check for pointers in field access on safe
27731 (Expression.LoadFromPtr): Factor the load-indirect code in this
27732 function. This was duplicated in UnboxCast and ParameterReference
27734 2002-01-24 Miguel de Icaza <miguel@ximian.com>
27736 * expression.cs (ComposedCast): report an error if a pointer cast
27737 is used in a safe region.
27739 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
27740 pointer type casts in unsafe context.
27742 * codegen.cs (EmitContext): Set up IsUnsafe.
27744 * cs-parser.jay (non_expression_type): Add productions for pointer
27747 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
27748 code. We should not use force into static mode if the method is
27749 not virtual. Fixes bug in MIS
27751 * statement.cs (Do.Emit, While.Emit, For.Emit,
27752 Statement.EmitBoolExpression): Add support to Do and While to
27753 propagate infinite loop as `I do return' semantics.
27755 Improve the For case to also test for boolean constants.
27757 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
27758 to the list of attributes we can add.
27760 Remove `EmitContext' argument.
27762 * class.cs (Method.Define): Apply parameter attributes.
27763 (Constructor.Define): Apply parameter attributes.
27764 (MethodCore.LabelParameters): Move here the core of labeling
27767 * support.cs (ReflectionParameters.ParameterModifier,
27768 InternalParameters.ParameterModifier): Use IsByRef on the type and
27769 only return the OUT bit for these parameters instead of in/out/ref
27772 This is because I miss-understood things. The ParameterInfo.IsIn
27773 and IsOut represent whether the parameter has the [In] and [Out]
27776 2002-01-22 Miguel de Icaza <miguel@ximian.com>
27778 * ecore.cs (FieldExpr.Emit): Release temporaries.
27780 * assign.cs (LocalTemporary.Release): new function.
27782 * codegen.cs (EmitContext.GetTemporaryStorage,
27783 EmitContext.FreeTemporaryStorage): Rework the way we deal with
27784 temporary storage. Now we can "put back" localbuilders when we
27787 2002-01-21 Miguel de Icaza <miguel@ximian.com>
27789 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
27790 need to make a copy of the variable to generate verifiable code.
27792 2002-01-19 Miguel de Icaza <miguel@ximian.com>
27794 * driver.cs: Compute dynamically the system directory.
27796 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
27797 Slower, but more generally useful. Used by the abstract
27798 registering implementation.
27800 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
27801 the rules for the special rule on Type/instances. First check if
27802 we have the same name, and if so, try that special static path
27803 rather than the instance path.
27805 2002-01-18 Miguel de Icaza <miguel@ximian.com>
27807 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
27810 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
27811 Enum, ValueType, Delegate or Array for non-corlib compiles.
27813 * cs-tokenizer.cs: Catch long identifiers (645)
27815 * typemanager.cs (IndexerPropetyName): Ravi never tested this
27818 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
27819 fix, we were returning too early, so we were not registering
27820 pending methods from abstract classes.
27822 Do not register pending methods if the class is abstract.
27824 * expression.cs (Conditional.DoResolve): Report circular implicit
27825 conversions when we neecd to compute it for conditional
27828 (Is.DoResolve): If the expression is always of the provided type,
27829 flag warning 183. If the expression can not ever be of the
27830 provided type flag warning 184.
27832 * class.cs: Catch 169 as well.
27834 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
27837 2002-01-18 Nick Drochak <ndrochak@gol.com>
27839 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
27841 2002-01-17 Miguel de Icaza <miguel@ximian.com>
27843 * interface.cs: (PopulateMethod): Check for pointers being defined
27844 only if the unsafe context is active.
27845 (PopulateProperty): ditto.
27846 (PopulateIndexer): ditto.
27848 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
27849 specified. If pointers are present, make sure that they are
27850 present in an unsafe context.
27851 (Constructor, Constructor.Define): ditto.
27852 (Field, Field.Define): ditto.
27853 (Property, Property.Define): ditto.
27854 (Event, Event.Define): ditto.
27856 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
27857 hashtable if there are classes or structs defined.
27859 * expression.cs (LocalVariableReference.DoResolve): Simplify this
27860 code, as the constant resolution moved.
27862 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
27863 the metadata, so we can flag error 133.
27865 * decl.cs (MemberCore.UnsafeOK): New function to test that a
27866 pointer is being declared in an unsafe context.
27868 2002-01-16 Miguel de Icaza <miguel@ximian.com>
27870 * modifiers.cs (Modifiers.Check): Require a Location argument.
27871 Report error 227 for Unsafe use.
27873 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
27875 * statement.cs (For.Emit): If the test is null, then report that
27876 we do `return', as we wont reach anything afterwards.
27878 (Switch.SwitchGoverningType): Track the expression that matched
27881 * driver.cs: Allow negative numbers as an error code to flag.
27883 * cs-parser.jay: Handle 1551.
27885 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
27887 2002-01-15 Miguel de Icaza <miguel@ximian.com>
27889 * cs-parser.jay: Report 1518 (type declaration can only contain
27890 class, struct, interface, enum or delegate)
27892 (switch_label): Report 1523 (keywords `case' or `default' must
27895 (opt_switch_sections): Report 1522 (empty switch)
27897 * driver.cs: Report 1515 (response file specified multiple times)
27898 Report 1516 (Source file specified multiple times).
27900 * expression.cs (Argument.Resolve): Signal 1510
27902 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
27903 access not allowed in static code)
27905 2002-01-11 Ravi Pratap <ravi@ximian.com>
27907 * typemanager.cs (IsPointerType): Utility method which we are going
27910 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
27911 the object type, so we take care of that.
27913 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
27915 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
27916 added to non-params parameters :-)
27918 * typemanager.cs (CSharpName): Include 'void' type too.
27920 (void_ptr_type): Include in the set of core types.
27922 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
27925 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
27928 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
27929 completely forgotten about it.
27931 2002-01-10 Ravi Pratap <ravi@ximian.com>
27933 * cs-parser.jay (pointer_type): Add. This begins our implementation
27934 of parsing rules for unsafe code.
27936 (unsafe_statement): Implement.
27938 (embedded_statement): Modify to include the above.
27940 * statement.cs (Unsafe): Implement new class for unsafe blocks.
27942 * codegen.cs (EmitContext.InUnsafe): Add. This determines
27943 if the current context is an unsafe one.
27945 * cs-parser.jay (local_variable_pointer_type): Since local variable types
27946 are handled differently, we need separate rules for them.
27948 (local_variable_declaration): Update to use local_variable_pointer_type
27949 to allow variable declarations of unmanaged pointer types.
27951 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
27952 in unsafe contexts.
27954 * ../errors/cs0214.cs : Add.
27956 2002-01-16 Nick Drochak <ndrochak@gol.com>
27958 * makefile: remove 'response' file when cleaning.
27960 2002-01-15 Miguel de Icaza <miguel@ximian.com>
27962 * cs-parser.jay: Report 1524.
27964 2002-01-14 Miguel de Icaza <miguel@ximian.com>
27966 * typemanager.cs (RegisterMethod): drop checking if we have
27967 registered this from here
27969 2002-01-12 Miguel de Icaza <miguel@ximian.com>
27971 * class.cs (Method.EmitDestructor): Implement calling our base
27974 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
27975 value of InFinally.
27977 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
27978 this routine and will wrap the call in a try/catch block. Deal
27981 2002-01-11 Miguel de Icaza <miguel@ximian.com>
27983 * ecore.cs (Expression.MemberLookup): instead of taking a
27984 parameter `same_type' that was used to tell whether we could
27985 access private members we compute our containing type from the
27988 (FieldExpr): Added partial support for volatile fields. This does
27989 not work for volatile fields exposed from assemblies, as I can not
27990 figure out how to extract the modreq from it.
27992 Updated all the source files to use this.
27994 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
27995 because it is referenced by MemberLookup very often.
27997 2002-01-09 Ravi Pratap <ravi@ximian.com>
27999 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28000 TypeBuilder.GetCustomAttributes to retrieve what we need.
28002 Get rid of redundant default_member_attr_type as this is the same as
28003 default_member_type which already exists.
28005 * interface.cs, attribute.cs : Update accordingly.
28007 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28009 * typemanager.cs: Enable IndexerPropertyName again. It does not
28010 work for TYpeBuilders though. Ravi, can you please fix this?
28012 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28014 * expression.cs (Argument.Emit): Handle the case of ref objects
28015 being passed to ref functions;
28017 (ParameterReference.EmitLoad): Loads the content of the pointer
28018 without dereferencing.
28020 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28022 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28024 2002-01-08 Ravi Pratap <ravi@ximian.com>
28026 * class.cs (Indexer.DefineMethod): Incorporate the interface
28027 type in the name of the method if we are doing explicit interface
28030 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28032 (BetterConversion): Fix extremely trivial bug where we were referring to
28033 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28036 * ../errors/bug16.cs : Add although we have fixed it.
28038 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28040 * expression.cs (BaseIndexer): Begin implementation.
28042 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28044 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28045 production directly to remove a shift/reduce, and implement
28046 explicit interface implementation.
28048 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28049 after a floating point suffix.
28051 * expression.cs (DoNumericPromotions): Improved the conversion for
28052 uint/uint. If we have a constant, we avoid doing a typecast to a
28055 * class.cs (Indexer): Implement explicit interface implementation
28058 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28060 * class.cs: make the default instance constructor public and hidebysig.
28062 2001-01-03 Ravi Pratap <ravi@ximian.com>
28064 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28065 so we can call it from elsewhere.
28067 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28068 we emit it internally if the class has a defined indexer; otherwise the user
28069 emits it by decorating the class definition with the DefaultMemberAttribute.
28071 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28072 attribute is not used on a type which defines an indexer.
28074 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28075 character when we skip whitespace.
28077 * ../errors/cs0646.cs : Add.
28079 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28081 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28084 * makefile: Add practical target `mcs3.exe' which builds the third
28085 generation compiler.
28087 * expression.cs (New): Fix structures constructor calling.
28089 * class.cs (Property, Method, Indexer): Emit Final flag on the
28090 method if we are an interface implementation and we are not
28093 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28094 whether this property is referencing a `base' method.
28096 * expression.cs (Invocation.EmitCall): take an extra argument:
28097 is_base, this is used to determine whether the `call' or
28098 `callvirt' opcode should be used.
28101 * delegate.cs: update EmitCall.
28103 * class.cs (Method.Define): Set NewSlot for the cases where we are
28104 not implementing an interface method.
28106 (Property.Define): ditto.
28108 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28110 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28111 'r'. Allows mcs to parse itself fully.
28113 2002-01-02 Ravi Pratap <ravi@ximian.com>
28115 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28116 of the number of initializers that require the InitializeArray method.
28118 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28119 update the above field where necessary.
28121 (MakeByteBlob): Update accordingly.
28123 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28126 (EmitDynamicInitializers): Update in accordance with the new optimization.
28128 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28129 same OpCode applies.
28131 * cs-parser.jay : Fix some glaring errors I introduced.
28133 2002-01-01 Ravi Pratap <ravi@ximian.com>
28135 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28136 so that we can check for name clashes there too.
28138 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28139 for interface indexers.
28141 * interfaces.cs (Define): Emit the default member attribute.
28143 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28144 variable was being referred to while setting the value ;-)
28146 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28148 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28149 byte-by-byte information when we know the data is zero.
28151 Make the block always a multiple of 4, because
28152 DefineInitializedData has a bug.
28154 * assign.cs: Fix, we should assign from the temporary, not from
28157 * expression.cs (MakeByteBlob): Fix my incorrect code.
28159 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28161 * typemanager.cs (EnumToUnderlying): This function is used to get
28162 the underlying type from an enumeration, because it does not
28165 * constant.cs: Use the I4_S form for values between -128 and 127.
28167 * statement.cs (Block.LookupLabel): Looks up a label.
28168 (Block): Drop support for labeled blocks.
28170 (LabeledStatement): New kind of statement that represents a label
28173 (Goto): Finally implement this bad boy.
28175 * cs-parser.jay: Update to reflect new mechanism to implement
28178 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28180 * codegen.cs (EmitContext.This): a codegen property that keeps the
28181 a single instance of this instead of creating many different this
28184 * delegate.cs (Delegate.DoResolve): Update to use the property;
28186 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28188 * expression.cs (BaseAccess.DoResolve): Ditto.
28190 2001-12-29 Ravi Pratap <ravi@ximian.com>
28192 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28193 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28195 (InitCoreTypes): Update accordingly.
28197 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28198 so we can quickly store the state.
28200 (ApplyAttributes): Set the correct implementation flags
28201 for InternalCall methods.
28203 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28205 * expression.cs (EmitCall): if a method is not virtual, then do
28206 not use callvirt on it.
28208 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28209 user defined stuff) requires the use of stobj, which takes an
28210 address on the stack instead of an array and an index. So emit
28211 the Ldelema operation for it.
28213 (EmitStoreOpcode): Use stobj for valuetypes.
28215 (UnaryMutator.EmitCode): Use the right 1 value depending on
28216 whether we are dealing with int64/uint64, float or doubles.
28218 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28219 constructors that I implemented last night.
28221 (Constructor.IsDefault): Fix to work properly for static
28224 * cs-parser.jay (CheckDef): report method signature errors.
28225 Update error number 103 to be 132.
28227 * decl.cs: New AdditionResult enumeration value: MethodExists.
28228 Although we do this check for methods later on in the semantic
28229 analysis, catching repeated default constructors is so easy that
28230 we catch these here.
28232 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28235 (ParameterReference.EmitAssign, Emit): handle
28238 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28239 (ArrayAccess.EmitStoreOpcode): ditto.
28241 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28243 * expression.cs (MakeByteBlob): Complete all the missing types
28244 (uint, short, ushort, byte, sbyte)
28246 * class.cs: Only init instance field initializers on instance
28249 Rename `constructors' to instance_constructors.
28251 (TypeContainer.AddConstructor): Only add constructors to the list
28252 if it is not static.
28254 Make sure that we handle default_static_constructor independently
28255 everywhere where we handle instance_constructors
28257 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28259 * class.cs: Do not lookup or create a base initializer for a
28260 static constructor.
28262 (ConstructorInitializer.Resolve): use the proper type to lookup
28265 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28267 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28270 * decl.cs: CloseType is now an virtual method, the default
28271 implementation just closes this type.
28273 2001-12-28 Ravi Pratap <ravi@ximian.com>
28275 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28276 to PreserveSig by default. Also emit HideBySig on such methods.
28278 Basically, set the defaults to standard values.
28280 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28281 argument, if candidate is better, it can't be worse than the best !
28283 (Invocation): Re-write bits to differentiate between methods being
28284 applicable in their expanded form and their normal form - for params
28287 Get rid of use_standard everywhere as only standard conversions are allowed
28288 in overload resolution.
28290 More spec conformance.
28292 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28294 * driver.cs: Add --timestamp, to see where the compiler spends
28297 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28298 `this' in static code.
28300 (SimpleName.DoResolve): Implement in terms of a helper function
28301 that allows static-references to be passed upstream to
28304 (Expression.ResolveWithSimpleName): Resolve specially simple
28305 names when called by MemberAccess to implement the special
28308 (Expression.ImplicitReferenceConversion): Handle conversions from
28309 Null to reference types before others, as Null's type is
28312 * expression.cs (Invocation.EmitCall): Handle the special case of
28313 calling methods declared on a reference type from a ValueType
28314 (Base classes System.Object and System.Enum)
28316 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28317 the left hand side is a TypeExpr, not on every enumeration.
28319 (Binary.Resolve): If types are reference types, then do a cast to
28320 object on operators != and == of both arguments.
28322 * typemanager.cs (FindMembers): Extract instance and static
28323 members if requested.
28325 * interface.cs (PopulateProperty): Use void_type instead of null
28326 as the return type for the setter method.
28328 (PopulateIndexer): ditto.
28330 2001-12-27 Ravi Pratap <ravi@ximian.com>
28332 * support.cs (ReflectionParameters): Fix minor bug where we
28333 were examining the wrong parameter for the ParamArray attribute.
28335 Cope with requests for the type of the parameter at position
28336 greater than the params parameter's. We now return the element
28337 type of the params array as that makes more sense.
28339 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28340 accordingly as we no longer have to extract the element type
28343 (Invocation.OverloadResolve): Update.
28345 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28347 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28348 against IEnumerator, test whether the return value is a descendant
28349 of the IEnumerator interface.
28351 * class.cs (Indexer.Define): Use an auxiliary method to implement
28352 the other bits of the method definition. Begin support for
28353 explicit interface implementation.
28355 (Property.DefineMethod): Use TypeManager.void_type instead of null
28356 for an empty return value.
28358 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28360 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28361 dealing with a FieldExpr which is composed of a FieldBuilder, in
28362 the code path we did extract the constant, but we should have
28363 obtained the underlying value to be able to cast it (otherwise we
28364 end up in an infinite loop, this is what Ravi was running into).
28366 (ArrayCreation.UpdateIndices): Arrays might be empty.
28368 (MemberAccess.ResolveMemberAccess): Add support for section
28369 14.5.4.1 that deals with the special case of E.I when E is a type
28370 and something else, that I can be a reference to a static member.
28372 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28373 handle a particular array type to create byte blobs, it is just
28374 something we dont generate byteblobs for.
28376 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28379 * location.cs (Push): remove the key from the hashtable that we
28380 are about to add. This happens for empty files.
28382 * driver.cs: Dispose files after we have parsed them.
28384 (tokenize): new function that only runs the tokenizer on its
28385 input, for speed testing.
28387 2001-12-26 Ravi Pratap <ravi@ximian.com>
28389 * class.cs (Event.Define): Define the private field only if there
28390 are no accessors defined.
28392 * expression.cs (ResolveMemberAccess): If there is no associated
28393 field with the event, that means we have an event defined with its
28394 own accessors and we should flag error cs0070 since transforming
28395 ourselves into a field is not valid in that case.
28397 * ecore.cs (SimpleName.DoResolve): Same as above.
28399 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28400 and charset to sane values.
28402 2001-12-25 Ravi Pratap <ravi@ximian.com>
28404 * assign.cs (DoResolve): Perform check on events only if they
28405 are being accessed outside the declaring type.
28407 * cs-parser.jay (event_declarations): Update rules to correctly
28408 set the type of the implicit parameter etc.
28410 (add_accessor, remove_accessor): Set current local parameters.
28412 * expression.cs (Binary): For delegate addition and subtraction,
28413 cast the return value from the method into the appropriate delegate
28416 2001-12-24 Ravi Pratap <ravi@ximian.com>
28418 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28419 of these as the workaround is unnecessary.
28421 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28422 delegate data - none of that is needed at all.
28424 Re-write bits to extract the instance expression and the delegate method
28427 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28430 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28431 of attaching attributes instead of duplicating code everywhere.
28433 * everywhere : Update code to do attribute emission using the above method.
28435 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28437 * expression.cs (IsParamsMethodApplicable): if there are not
28438 parameters, return immediately.
28440 * ecore.cs: The 0 literal can be implicity converted to an enum
28443 (SimpleName.DoResolve): First lookup the type, then lookup the
28446 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28447 want to get its address. If the InstanceExpression is not
28448 addressable, store the result in a temporary variable, then get
28451 * codegen.cs: Only display 219 errors on warning level or above.
28453 * expression.cs (ArrayAccess): Make it implement the
28454 IMemoryLocation interface.
28456 (Binary.DoResolve): handle the operator == (object a, object b)
28457 and operator != (object a, object b) without incurring into a
28458 BoxedCast (because 5 != o should never be performed).
28460 Handle binary enumerator operators.
28462 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28463 value type, otherwise use Ldelem_ref.
28465 Use precomputed names;
28467 (AddressOf): Implement address of
28469 * cs-parser.jay (labeled_statement): Fix recursive block
28470 addition by reworking the production.
28472 * expression.cs (New.DoEmit): New has a special case:
28474 If we are dealing with a ValueType, we have a few
28475 situations to deal with:
28477 * The target of New is a ValueType variable, that is
28478 easy, we just pass this as the variable reference
28480 * The target of New is being passed as an argument,
28481 to a boxing operation or a function that takes a
28484 In this case, we need to create a temporary variable
28485 that is the argument of New.
28488 2001-12-23 Ravi Pratap <ravi@ximian.com>
28490 * rootcontext.cs (LookupType): Check that current_type is not null before
28491 going about looking at nested types.
28493 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
28494 not implement the IAssignMethod interface any more.
28496 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
28497 where we tranform them into FieldExprs if they are being resolved from within
28498 the declaring type.
28500 * ecore.cs (SimpleName.DoResolve): Do the same here.
28502 * assign.cs (DoResolve, Emit): Clean up code considerably.
28504 * ../errors/bug10.cs : Add.
28506 * ../errors/cs0070.cs : Add.
28508 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
28510 * assign.cs : Get rid of EventIsLocal everywhere.
28512 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28514 * ecore.cs (ConvertIntLiteral): finished the implementation.
28516 * statement.cs (SwitchLabel): Convert the value we are using as a
28517 key before looking up the table.
28519 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28521 * codegen.cs (EmitTopBlock): Require a Location argument now.
28523 * cs-parser.jay (constructor_declarator): We need to setup
28524 current_local_parameters before we parse the
28525 opt_constructor_initializer, to allow the variables to be bound
28526 to the constructor arguments.
28528 * rootcontext.cs (LookupType): First lookup nested classes in our
28529 class and our parents before we go looking outside our class.
28531 * expression.cs (ConstantFold): Extract/debox the values at the
28534 * rootcontext.cs (EmitCode): Resolve the constants first before we
28535 resolve the types. This is not really needed, but it helps debugging.
28537 * statement.cs: report location.
28539 * cs-parser.jay: pass location to throw statement.
28541 * driver.cs: Small bug fix.
28543 * report.cs: Updated format to be 4-zero filled digits.
28545 2001-12-22 Ravi Pratap <ravi@ximian.com>
28547 * expression.cs (CheckIndices): Fix minor bug where the wrong
28548 variable was being referred to ;-)
28550 (DoEmit): Do not call EmitStaticInitializers when the
28551 underlying type is System.Object.
28553 2001-12-21 Ravi Pratap <ravi@ximian.com>
28555 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
28556 and do the usual workaround for SRE.
28558 * class.cs (MyEventBuilder.EventType): New member to get at the type
28559 of the event, quickly.
28561 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
28563 * assign.cs (Assign.DoResolve): Handle the case when the target
28564 is an EventExpr and perform the necessary checks.
28566 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
28569 (SimpleName.MemberStaticCheck): Include check for EventExpr.
28571 (EventExpr): Set the type in the constructor itself since we
28572 are meant to be born fully resolved.
28574 (EventExpr.Define): Revert code I wrote earlier.
28576 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
28577 instance expression is null. The instance expression is a This in that case
28578 or a null, depending on whether it is a static method or not.
28580 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
28581 refers to more than one method.
28583 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
28584 and accordingly flag errors.
28586 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28588 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
28590 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28592 * location.cs (ToString): Provide useful rutine.
28594 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28596 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
28597 objects, return the actual integral boxed.
28599 * statement.cs (SwitchLabel): define an ILLabel for each
28602 (Switch.CheckSwitch): If the value is a Literal, extract
28603 the underlying literal.
28605 Also in the unused hashtable we had, add the SwitchLabel so we can
28606 quickly look this value up.
28608 * constant.cs: Implement a bunch of new constants. Rewrite
28609 Literal based on this. Made changes everywhere to adapt to this.
28611 * expression.cs (Expression.MakeByteBlob): Optimize routine by
28612 dereferencing array only once, and also copes with enumrations.
28614 bytes are two bytes wide, not one.
28616 (Cast): Perform constant conversions.
28618 * ecore.cs (TryImplicitIntConversion): Return literals instead of
28619 wrappers to the literals here.
28621 * expression.cs (DoNumericPromotions): long literals can converted
28622 to ulong implicity (this is taken care of elsewhere, but I was
28623 missing this spot).
28625 * ecore.cs (Expression.Literalize): Make the return type Literal,
28626 to improve type checking.
28628 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
28630 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28632 * literal.cs: Revert code from ravi that checked the bounds. The
28633 bounds are sane by the definition of the type itself.
28635 * typemanager.cs: Fix implementation of ImplementsInterface. We
28636 need to actually look up in our parent hierarchy for interfaces
28639 * const.cs: Use the underlying type for enumerations
28641 * delegate.cs: Compute the basename for the delegate creation,
28642 that should fix the delegate test case, and restore the correct
28643 Type Lookup semantics in rootcontext
28645 * rootcontext.cs: Revert Ravi's last patch. The correct way of
28646 referencing a nested type with the Reflection API is using the "+"
28649 * cs-parser.jay: Do not require EOF token at the end.
28651 2001-12-20 Ravi Pratap <ravi@ximian.com>
28653 * rootcontext.cs (LookupType): Concatenate type names with
28654 a '.' instead of a '+' The test suite passes again.
28656 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
28657 field of the enumeration.
28659 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
28660 the case when the member is an EventExpr.
28662 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
28663 static has an associated instance expression.
28665 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
28667 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
28669 * class.cs (Event.Define): Register event and perform appropriate checks
28672 We define the Add and Remove methods even if the use provides none because
28673 in that case, we provide default implementations ourselves.
28675 Define a private field of the type of the event. This is done by the CSC compiler
28676 and we should be doing it too ;-)
28678 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
28679 More methods we use in code we generate.
28681 (multicast_delegate_type, delegate_type): Two separate types since the distinction
28684 (InitCoreTypes): Update accordingly for the above.
28686 * class.cs (Event.Emit): Generate code for default accessors that we provide
28688 (EmitDefaultMethod): Do the job in the above.
28690 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
28693 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28695 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
28696 builders even if we were missing one.
28698 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
28699 pass the Basename as our class name instead of the Name. The
28700 basename will be correctly composed for us.
28702 * parameter.cs (Paramters): Now takes a Location argument.
28704 * decl.cs (DeclSpace.LookupType): Removed convenience function and
28705 make all the code call directly LookupType in RootContext and take
28706 this chance to pass the Location information everywhere.
28708 * Everywhere: pass Location information.
28710 2001-12-19 Miguel de Icaza <miguel@ximian.com>
28712 * class.cs (Constructor.Define): Updated way of detecting the
28713 length of the parameters.
28715 (TypeContainer.DefineType): Use basename as the type name for
28718 (TypeContainer.Define): Do not recursively define types here, as
28719 definition is taken care in order by the RootContext.
28721 * tree.cs: Keep track of namespaces in a per-file basis.
28723 * parameter.cs (Parameter.ComputeSignature): Update to use
28726 (Parameters.GetSignature): ditto.
28728 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
28729 instead of a TypeContainer.
28731 (Interface.SemanticAnalysis): Use `this' instead of our parent to
28732 resolve names. Because we need to be resolve in our context, not
28735 * driver.cs: Implement response files.
28737 * class.cs (TypeContainer.DefineType): If we are defined, do not
28738 redefine ourselves.
28740 (Event.Emit): Emit the code for add/remove handlers.
28741 (Event.Define): Save the MethodBuilders for add/remove.
28743 * typemanager.cs: Use pair here too.
28745 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
28746 DictionaryEntry requires the first argument to be non-null.
28748 (enum_declaration): Compute full name for registering the
28751 (delegate_declaration): Instead of using
28752 formal_parameter_list, use opt_formal_parameter_list as the list
28755 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
28756 (EventParsing): New property that controls whether `add' and
28757 `remove' are returned as tokens or identifiers (for events);
28759 2001-12-19 Ravi Pratap <ravi@ximian.com>
28761 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
28762 use MyEventBuilder only and let it wrap the real builder for us.
28764 (MyEventBuilder): Revamp constructor etc.
28766 Implement all operations that we perform on EventBuilder in precisely the same
28769 (FindMembers): Update to use the EventBuilder member.
28771 (Event.Emit): Update accordingly.
28773 2001-12-18 Ravi Pratap <ravi@ximian.com>
28775 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
28776 by calling the appropriate methods.
28778 (GetCustomAttributes): Make stubs as they cannot possibly do anything
28781 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
28783 2001-12-17 Ravi Pratap <ravi@ximian.com>
28785 * delegate.cs (Delegate.Populate): Check that the return type
28786 and various parameters types are indeed accessible.
28788 * class.cs (Constructor.Define): Same here.
28790 (Field.Define): Ditto.
28792 (Event.Define): Ditto.
28794 (Operator.Define): Check that the underlying Method defined itself
28795 correctly - so it's MethodBuilder should not be null.
28797 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
28798 expression happens to be null.
28800 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
28801 members but as of now we don't seem to be able to do anything really useful with it.
28803 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
28804 not the EventBuilder.
28806 2001-12-18 Miguel de Icaza <miguel@ximian.com>
28808 * cs-tokenizer.cs: Add support for defines.
28809 Add support for #if, #elif, #else, #endif
28811 (eval_var): evaluates a variable.
28812 (eval): stubbed for evaluating functions.
28814 * cs-parser.jay: Pass the defines information
28816 * driver.cs: Add --define command line option.
28818 * decl.cs: Move MemberCore here.
28820 Make it the base class for DeclSpace. This allows us to catch and
28821 report 108 and 109 for everything now.
28823 * class.cs (TypeContainer.Define): Extract all the members
28824 before populating and emit the warning 108 (new keyword required
28825 to override) instead of having each member implement this.
28827 (MemberCore.Define): New abstract method, we will be using this in
28828 the warning reporting engine in Populate.
28830 (Operator.Define): Adjust to new MemberCore protocol.
28832 * const.cs (Const): This does not derive from Expression, it is a
28833 temporary object we use to create fields, it is a MemberCore.
28835 * class.cs (Method.Define): Allow the entry point to be in a
28838 * driver.cs: Rewrite the argument handler to clean it up a bit.
28840 * rootcontext.cs: Made it just an auxiliary namespace feature by
28841 making everything static.
28843 * driver.cs: Adapt code to use RootContext type name instead of
28846 * delegate.cs: Remove RootContext argument.
28848 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
28851 * class.cs (Event.Define): The lookup can fail.
28853 * cs-tokenizer.cs: Begin implementation of pre-procesor.
28855 * expression.cs: Resolve the this instance before invoking the code.
28857 2001-12-17 Miguel de Icaza <miguel@ximian.com>
28859 * cs-parser.jay: Add a production in element_access that allows
28860 the thing to become a "type" reference. This way we can parse
28861 things like "(string [])" as a type.
28863 Note that this still does not handle the more complex rules of
28867 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
28869 * ecore.cs: (CopyNewMethods): new utility function used to
28870 assemble the list of methods from running FindMembers.
28872 (MemberLookup): Rework FindMembers so that
28874 2001-12-16 Miguel de Icaza <miguel@ximian.com>
28876 * class.cs (TypeContainer): Remove Delegates who fail to be
28879 * delegate.cs (Populate): Verify that we dont get null return
28880 values. TODO: Check for AsAccessible.
28882 * cs-parser.jay: Use basename to emit error 574 (destructor should
28883 have the same name as container class), not the full name.
28885 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
28886 possible representation.
28888 Also implements integer type suffixes U and L.
28890 2001-12-15 Miguel de Icaza <miguel@ximian.com>
28892 * expression.cs (ArrayCreation.DoResolve): We need to do the
28893 argument resolution *always*.
28895 * decl.cs: Make this hold the namespace. Hold the root context as
28897 (LookupType): Move here.
28899 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
28901 * location.cs (Row, Name): Fixed the code, it was always returning
28902 references to the first file.
28904 * interface.cs: Register properties defined through interfaces.
28906 * driver.cs: Add support for globbing on the command line
28908 * class.cs (Field): Make it derive from MemberCore as well.
28911 2001-12-15 Ravi Pratap <ravi@ximian.com>
28913 * class.cs (Event::Define): Check that the type of the event is a delegate
28914 type else flag error #66.
28916 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
28919 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
28920 values of EntryPoint, CharSet etc etc.
28922 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
28924 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
28925 be null and we should ignore this. I am not sure if this is really clean. Apparently,
28926 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
28927 which needs this to do its work.
28929 * ../errors/cs0066.cs : Add.
28931 2001-12-14 Miguel de Icaza <miguel@ximian.com>
28933 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
28936 * class.cs: (MethodSignature.MethodSignature): Removed hack that
28937 clears out the parameters field.
28938 (MemberSignatureCompare): Cleanup
28940 (MemberCore): New base class used to share code between MethodCore
28943 (RegisterRequiredImplementations) BindingFlags.Public requires
28944 either BindingFlags.Instace or Static. Use instance here.
28946 (Property): Refactored code to cope better with the full spec.
28948 * parameter.cs (GetParameterInfo): Return an empty array instead
28951 * class.cs (Property): Abstract or extern properties have no bodies.
28953 * parameter.cs (GetParameterInfo): return a zero-sized array.
28955 * class.cs (TypeContainer.MethodModifiersValid): Move all the
28956 method modifier validation to the typecontainer so we can reuse
28957 this on properties.
28959 (MethodCore.ParameterTypes): return an empty sized array of types.
28961 (Property.Define): Test property modifier validity.
28963 Add tests for sealed/override too.
28965 (Method.Emit): abstract or extern methods have no bodies.
28967 2001-12-14 Ravi Pratap <ravi@ximian.com>
28969 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
28972 (Method::Define, ::Emit): Modify accordingly.
28974 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
28976 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
28978 * makefile: Pass in /unsafe.
28980 2001-12-13 Miguel de Icaza <miguel@ximian.com>
28982 * class.cs (MakeKey): Kill routine.
28984 * class.cs (TypeContainer.Define): Correctly define explicit
28985 method implementations (they require the full interface name plus
28988 * typemanager.cs: Deply the PtrHashtable here and stop using the
28989 lame keys. Things work so much better.
28991 This of course broke everyone who depended on `RegisterMethod' to
28992 do the `test for existance' test. This has to be done elsewhere.
28994 * support.cs (PtrHashtable): A hashtable that avoid comparing with
28995 the object stupid Equals method (because, that like fails all over
28996 the place). We still do not use it.
28998 * class.cs (TypeContainer.SetRequiredInterface,
28999 TypeContainer.RequireMethods): Killed these two routines and moved
29000 all the functionality to RegisterRequiredImplementations.
29002 (TypeContainer.RegisterRequiredImplementations): This routine now
29003 registers all the implementations required in an array for the
29004 interfaces and abstract methods. We use an array of structures
29005 which can be computed ahead of time to reduce memory usage and we
29006 also assume that lookups are cheap as most classes will not
29007 implement too many interfaces.
29009 We also avoid creating too many MethodSignatures.
29011 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29012 clear the "pending" bit if we find that there are problems with
29015 (TypeContainer.VerifyPendingMethods): Update to report errors of
29016 methods that look like implementations but are not.
29018 (TypeContainer.Define): Add support for explicit interface method
29021 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29023 * typemanager.cs: Keep track of the parameters here instead of
29024 being a feature of the TypeContainer.
29026 * class.cs: Drop the registration of parameters here, as
29027 InterfaceMethods are also interface declarations.
29029 * delegate.cs: Register methods with the TypeManager not only with
29030 the TypeContainer. This code was buggy.
29032 * interface.cs: Full registation here.
29034 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29036 * expression.cs: Remove reducer for binary expressions, it can not
29039 * const.cs: Put here the code that used to go into constant.cs
29041 * constant.cs: Put here the code for constants, this is a new base
29042 class for Literals.
29044 * literal.cs: Make Literal derive from Constant.
29046 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29048 * statement.cs (Return.Emit): Report error 157 if the user
29049 attempts to return from a finally block.
29051 (Return.Emit): Instead of emitting a return, jump to the end of
29054 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29055 LocalBuilder to store the result of the function. ReturnLabel is
29056 the target where we jump.
29059 2001-12-09 Radek Doulik <rodo@ximian.com>
29061 * cs-parser.jay: remember alias in current namespace
29063 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29066 * class.cs (LookupAlias): lookup alias in my_namespace
29068 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29070 (LookupAlias): lookup alias in this and if needed in parent
29073 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29077 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29078 making things static. I need this to avoid passing the
29079 TypeContainer when calling ParameterType.
29081 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29082 that did string manipulation to compute the type and then call
29083 GetType. Use Parameter.ParameterType instead.
29085 * cs-tokenizer.cs: Consume the suffix for floating values.
29087 * expression.cs (ParameterReference): figure out whether this is a
29088 reference parameter or not. Kill an extra variable by computing
29089 the arg_idx during emission.
29091 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29092 function that returns whether a parameter is an out/ref value or not.
29094 (Parameter.ParameterType): The type of the parameter (base,
29095 without ref/out applied).
29097 (Parameter.Resolve): Perform resolution here.
29098 (Parameter.ExternalType): The full type (with ref/out applied).
29100 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29101 support for expressions on the using statement.
29103 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29105 * statement.cs (Using.EmitLocalVariableDecls): Split the
29106 localvariable handling of the using statement.
29108 (Block.EmitMeta): Keep track of variable count across blocks. We
29109 were reusing slots on separate branches of blocks.
29111 (Try.Emit): Emit the general code block, we were not emitting it.
29113 Check the type of the declaration to be an IDisposable or
29114 something that can be implicity converted to it.
29116 Emit conversions if required.
29118 * ecore.cs (EmptyExpression): New utility class.
29119 (Expression.ImplicitConversionExists): New utility function.
29121 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29123 * statement.cs (Using): Implement.
29125 * expression.cs (LocalVariableReference): Support read only variables.
29127 * statement.cs: Remove the explicit emit for the Leave opcode.
29128 (VariableInfo): Add a readonly field.
29130 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29132 * ecore.cs (ConvCast): new class used to encapsulate the various
29133 explicit integer conversions that works in both checked and
29134 unchecked contexts.
29136 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29137 properly generate the overflow opcodes.
29139 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29141 * statement.cs: The correct type for the EmptyExpression is the
29142 element_type, not the variable type. Ravi pointed this out.
29144 2001-12-04 Ravi Pratap <ravi@ximian.com>
29146 * class.cs (Method::Define): Handle PInvoke methods specially
29147 by using DefinePInvokeMethod instead of the usual one.
29149 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29150 above to do the task of extracting information and defining the method.
29152 2001-12-04 Ravi Pratap <ravi@ximian.com>
29154 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29155 of the condition for string type.
29157 (Emit): Move that here.
29159 (ArrayCreation::CheckIndices): Keep string literals in their expression
29162 (EmitDynamicInitializers): Handle strings appropriately.
29164 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29166 * codegen.cs (EmitContext): Replace multiple variables with a
29167 single pointer to the current Switch statement.
29169 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29172 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29176 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29179 (Foreach.Emit): Foreach on arrays was not setting
29180 up the loop variables (for break/continue).
29182 (GotoCase): Semi-implented.
29184 2001-12-03 Ravi Pratap <ravi@ximian.com>
29186 * attribute.cs (CheckAttribute): Handle system attributes by using
29187 Attribute.GetAttributes to examine information we need.
29189 (GetValidPlaces): Same here.
29191 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29193 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29195 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29197 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29199 (Method::Emit): Handle the case when we are a PInvoke method.
29201 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29203 * expression.cs: Use ResolveWithSimpleName on compound names.
29205 2001-12-02 Ravi Pratap <ravi@ximian.com>
29207 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29208 before trying to reduce it.
29210 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29212 * constant.cs (LookupConstantValue): Implement.
29214 (EmitConstant): Use the above in emitting the constant.
29216 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29217 that are user-defined by doing a LookupConstantValue on them.
29219 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29222 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29224 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29226 (BaseAccess.DoResolve): Implement.
29228 (MemberAccess.DoResolve): Split this routine into a
29229 ResolveMemberAccess routine that can be used independently
29231 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29233 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29234 As that share bits of the implementation. Is returns a boolean,
29235 while As returns the Type that is being probed.
29237 2001-12-01 Ravi Pratap <ravi@ximian.com>
29239 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29240 instead of a Literal - much easier.
29242 (EnumInTransit): Remove - utterly useless :-)
29244 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29246 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29248 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29249 chain when we have no associated expression.
29251 2001-11-30 Ravi Pratap <ravi@ximian.com>
29253 * constant.cs (Define): Use Location while reporting the errror.
29255 Also emit a warning when 'new' is used and there is no inherited
29258 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29261 (LookupEnumValue): Implement to lookup an enum member's value and define it
29264 (Populate): Re-write accordingly to use the above routine.
29266 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29268 * expression.cs (This): Fix prototype for DoResolveLValue to
29269 override the base class DoResolveLValue.
29271 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29274 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29275 (we need to load the address of the field here). This fixes
29278 (FieldExpr.DoResolveLValue): Call the DoResolve
29279 function to initialize the Instance expression.
29281 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29282 correctly the GetEnumerator operation on a value type.
29284 * cs-parser.jay: Add more simple parsing error catches.
29286 * statement.cs (Switch): Add support for string switches.
29287 Handle null specially.
29289 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29291 2001-11-28 Ravi Pratap <ravi@ximian.com>
29293 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29295 (declare_local_constant): New helper function.
29297 * statement.cs (AddConstant): Keep a separate record of constants
29299 (IsConstant): Implement to determine if a variable is a constant.
29301 (GetConstantExpression): Implement.
29303 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29305 * statement.cs (IsVariableDefined): Re-write.
29307 2001-11-27 Ravi Pratap <ravi@ximian.com>
29309 * class.cs (TypeContainer::FindMembers): Look for constants
29310 in the case when we are looking for MemberTypes.Field
29312 * expression.cs (MemberAccess::DoResolve): Check that in the
29313 case we are a FieldExpr and a Literal, we are not being accessed
29314 by an instance reference.
29316 * cs-parser.jay (local_constant_declaration): Implement.
29318 (declaration_statement): Implement for constant declarations.
29320 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29322 * statement.cs (Switch): Catch double defaults.
29324 (Switch): More work on the switch() statement
29325 implementation. It works for integral values now, need to finish
29329 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29331 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29332 integer literals into other integer literals. To be used by
29335 2001-11-24 Ravi Pratap <ravi@ximian.com>
29337 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29340 (EmitDynamicInitializers): Cope with the above since we extract data
29341 directly from ArrayData now.
29343 (ExpectInitializers): Keep track of whether initializers are mandatory
29346 (Bounds): Make it a hashtable to prevent the same dimension being
29347 recorded for every element in that dimension.
29349 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29352 Also fix bug which was causing the indices to be emitted in the reverse
29355 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29357 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29358 unfinished. They do not work, because the underlying code is
29361 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29363 * cs-parser.jay: Remove bogus fixme.
29365 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29366 on Switch statement.
29368 2001-11-23 Ravi Pratap <ravi@ximian.com>
29370 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29373 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29374 parameter. Apparently, any expression is allowed.
29376 (ValidateInitializers): Update accordingly.
29378 (CheckIndices): Fix some tricky bugs thanks to recursion.
29380 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29381 I was being completely brain-dead.
29383 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29384 and re-write acordingly.
29386 (DelegateInvocation): Re-write accordingly.
29388 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29390 (MakeByteBlob): Handle types more correctly.
29392 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29393 initialization from expressions but it is incomplete because I am a complete
29396 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29398 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29399 on If. Basically, we have to return `true' (ie, we do return to
29400 our caller) only if both branches of the if return.
29402 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29403 short-circuit operators, handle them as short circuit operators.
29405 (Cast.DoResolve): Resolve type.
29406 (Cast.Cast): Take an expression as the target type.
29408 * cs-parser.jay (cast_expression): Remove old hack that only
29409 allowed a limited set of types to be handled. Now we take a
29410 unary_expression and we resolve to a type during semantic
29413 Use the grammar productions from Rhys to handle casts (this is
29414 not complete like Rhys syntax yet, we fail to handle that corner
29415 case that C# has regarding (-x), but we will get there.
29417 2001-11-22 Ravi Pratap <ravi@ximian.com>
29419 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29420 field which is an array type.
29422 * cs-parser.jay (declare_local_variables): Support array initialization too.
29424 * typemanager.cs (MakeKey): Implement.
29426 (everywhere): Use the above appropriately.
29428 * cs-parser.jay (for_statement): Update for array initialization while
29429 declaring variables.
29431 * ecore.cs : The error message was correct, it's the variable's names that
29432 were misleading ;-) Make the code more readable.
29434 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29435 the correct type etc.
29437 (ConvertExplicit): Handle Enum types by examining the underlying type.
29439 2001-11-21 Ravi Pratap <ravi@ximian.com>
29441 * parameter.cs (GetCallingConvention): Always return
29442 CallingConventions.Standard for now.
29444 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29446 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29447 and `r' after calling DoNumericPromotions.
29449 * ecore.cs: Fix error message (the types were in the wrong order).
29451 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29452 BindingFlags.Instance as well
29454 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29455 implicit int literal conversion in an empty cast so that we
29456 propagate the right type upstream.
29458 (UnboxCast): new class used to unbox value types.
29459 (Expression.ConvertExplicit): Add explicit type conversions done
29462 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29463 the target type before applying the implicit LongLiterals to ULong
29466 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29468 * cs-parser.jay (for_statement): Reworked the way For works: now
29469 we declare manually any variables that are introduced in
29470 for_initializer to solve the problem of having out-of-band code
29471 emition (that is what got for broken).
29473 (declaration_statement): Perform the actual variable declaration
29474 that used to be done in local_variable_declaration here.
29476 (local_variable_declaration): Do not declare anything, just pass
29477 the information on a DictionaryEntry
29479 2001-11-20 Ravi Pratap <ravi@ximian.com>
29481 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29482 re-write of the logic to now make it recursive.
29484 (UpdateIndices): Re-write accordingly.
29486 Store element data in a separate ArrayData list in the above methods.
29488 (MakeByteBlob): Implement to dump the array data into a byte array.
29490 2001-11-19 Ravi Pratap <ravi@ximian.com>
29492 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
29495 * constant.cs (Define): Implement.
29497 (EmitConstant): Re-write fully.
29499 Pass in location info.
29501 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
29504 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
29505 DictionaryEntry since we need location info too.
29507 (constant_declaration): Update accordingly.
29509 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
29510 code into another method : UpdateIndices.
29512 2001-11-18 Ravi Pratap <ravi@ximian.com>
29514 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
29515 some type checking etc.
29517 2001-11-17 Ravi Pratap <ravi@ximian.com>
29519 * expression.cs (ArrayCreation::ValidateInitializers): Implement
29520 bits to provide dimension info if the user skips doing that.
29522 Update second constructor to store the rank correctly.
29524 2001-11-16 Ravi Pratap <ravi@ximian.com>
29526 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
29527 and try to implement.
29529 * ../errors/cs0150.cs : Add.
29531 * ../errors/cs0178.cs : Add.
29533 2001-11-16 Miguel de Icaza <miguel@ximian.com>
29535 * statement.cs: Implement foreach on multi-dimensional arrays.
29537 * parameter.cs (Parameters.GetParameterByName): Also lookup the
29538 name of the params argument.
29540 * expression.cs: Use EmitStoreOpcode to get the right opcode while
29541 initializing the array.
29543 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
29544 we can use this elsewhere.
29546 * statement.cs: Finish implementation of foreach for single
29549 * cs-parser.jay: Use an out-of-band stack to pass information
29550 around, I wonder why I need this.
29552 foreach_block: Make the new foreach_block the current_block.
29554 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
29555 function used to return a static Parameters structure. Used for
29556 empty parameters, as those are created very frequently.
29558 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
29560 2001-11-15 Ravi Pratap <ravi@ximian.com>
29562 * interface.cs : Default modifier is private, not public. The
29563 make verify test passes again.
29565 2001-11-15 Ravi Pratap <ravi@ximian.com>
29567 * support.cs (ReflectionParameters): Fix logic to determine
29568 whether the last parameter is a params one. Test 9 passes again.
29570 * delegate.cs (Populate): Register the builders we define with
29571 RegisterParameterForBuilder. Test 19 passes again.
29573 * cs-parser.jay (property_declaration): Reference $6 instead
29574 of $$ to get at the location.
29576 (indexer_declaration): Similar stuff.
29578 (attribute): Ditto.
29580 * class.cs (Property): Register parameters for the Get and Set methods
29581 if they exist. Test 23 passes again.
29583 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
29584 call to EmitArguments as we are sure there aren't any params arguments.
29585 Test 32 passes again.
29587 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
29588 IndexOutOfRangeException.
29590 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
29591 Test 33 now passes again.
29593 2001-11-15 Miguel de Icaza <miguel@ximian.com>
29595 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
29596 broke a bunch of things. Will have to come up with a better way
29597 of tracking locations.
29599 * statement.cs: Implemented foreach for single dimension arrays.
29601 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29603 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
29604 an error. This removes the lookup from the critical path.
29606 * cs-parser.jay: Removed use of temporary_loc, which is completely
29609 2001-11-14 Miguel de Icaza <miguel@ximian.com>
29611 * support.cs (ReflectionParameters.ParameterModifier): Report
29612 whether the argument is a PARAMS argument or not.
29614 * class.cs: Set the attribute `ParamArrayAttribute' on the
29615 parameter argument.
29617 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
29618 and cons_param_array_attribute (ConstructorInfo for
29619 ParamArrayAttribute).,
29621 * codegen.cs: Emit the return using the `Return' statement, that
29622 way we can report the error correctly for missing return values.
29624 * class.cs (Method.Emit): Clean up.
29626 * expression.cs (Argument.Resolve): Take another argument: the
29627 location where this argument is used. Notice that this is not
29628 part of the "Argument" class as to reduce the size of the
29629 structure (we know the approximate location anyways).
29631 Test if the argument is a variable-reference, if not, then
29632 complain with a 206.
29634 (Argument.Emit): Emit addresses of variables.
29636 (Argument.FullDesc): Simplify.
29638 (Invocation.DoResolve): Update for Argument.Resolve.
29640 (ElementAccess.DoResolve): ditto.
29642 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
29643 method should be virtual, as this method is always virtual.
29645 (NewDelegate.DoResolve): Update for Argument.Resolve.
29647 * class.cs (ConstructorInitializer.DoResolve): ditto.
29649 * attribute.cs (Attribute.Resolve): ditto.
29651 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29653 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
29655 * expression.cs (ParameterReference): Drop IStackStorage and implement
29656 IAssignMethod instead.
29658 (LocalVariableReference): ditto.
29660 * ecore.cs (FieldExpr): Drop IStackStorage and implement
29661 IAssignMethod instead.
29663 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29665 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
29666 enumerations that are used in heavily used structures derive from
29667 byte in a laughable and pathetic attempt to reduce memory usage.
29668 This is the kind of pre-optimzations that you should not do at
29669 home without adult supervision.
29671 * expression.cs (UnaryMutator): New class, used to handle ++ and
29672 -- separatedly from the other unary operators. Cleans up the
29673 code, and kills the ExpressionStatement dependency in Unary.
29675 (Unary): Removed `method' and `Arguments' from this class, making
29676 it smaller, and moving it all to SimpleCall, so I can reuse this
29677 code in other locations and avoid creating a lot of transient data
29678 strucutres when not required.
29680 * cs-parser.jay: Adjust for new changes.
29682 2001-11-11 Miguel de Icaza <miguel@ximian.com>
29684 * enum.cs (Enum.Populate): If there is a failure during
29687 * cs-parser.jay (opt_enum_base): we used to catch type errors
29688 here, but this is really incorrect. The type error should be
29689 catched during semantic analysis.
29691 2001-12-11 Ravi Pratap <ravi@ximian.com>
29693 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
29694 current_local_parameters as expected since I, in my stupidity, had forgotten
29697 * attribute.cs (GetValidPlaces): Fix stupid bug.
29699 * class.cs (Method::Emit): Perform check on applicability of attributes.
29701 (Constructor::Emit): Ditto.
29703 (Field::Emit): Ditto.
29705 (Field.Location): Store location information.
29707 (Property, Event, Indexer, Operator): Ditto.
29709 * cs-parser.jay (field_declaration): Pass in location for each field.
29711 * ../errors/cs0592.cs : Add.
29713 2001-11-12 Ravi Pratap <ravi@ximian.com>
29715 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
29717 (InitCoreTypes): Update accordingly.
29719 (RegisterAttrType, LookupAttr): Implement.
29721 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
29722 info about the same.
29724 (Resolve): Update to populate the above as necessary.
29726 (Error592): Helper.
29728 (GetValidPlaces): Helper to the above.
29730 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
29732 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
29734 2001-11-12 Ravi Pratap <ravi@ximian.com>
29736 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
29738 * ../errors/cs0617.cs : Add.
29740 2001-11-11 Ravi Pratap <ravi@ximian.com>
29742 * enum.cs (Emit): Rename to Populate to be more consistent with what
29743 we expect it to do and when exactly it is called.
29745 * class.cs, rootcontext.cs : Update accordingly.
29747 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
29748 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
29750 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
29752 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
29753 of a fieldinfo using the above, when dealing with a FieldBuilder.
29755 2001-11-10 Ravi Pratap <ravi@ximian.com>
29757 * ../errors/cs0031.cs : Add.
29759 * ../errors/cs1008.cs : Add.
29761 * ../errrors/cs0543.cs : Add.
29763 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
29766 (FindMembers): Implement.
29768 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
29769 enums and delegates too.
29771 (enum_types): Rename to builder_to_enum.
29773 (delegate_types): Rename to builder_to_delegate.
29775 * delegate.cs (FindMembers): Implement.
29777 2001-11-09 Ravi Pratap <ravi@ximian.com>
29779 * typemanager.cs (IsEnumType): Implement.
29781 * enum.cs (Emit): Re-write parts to account for the underlying type
29782 better and perform checking etc.
29784 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
29785 of the underlying type.
29787 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
29790 * enum.cs (error31): Helper to report error #31.
29792 * cs-parser.jay (enum_declaration): Store location of each member too.
29794 * enum.cs (member_to_location): New hashtable.
29796 (AddEnumMember): Update location hashtable.
29798 (Emit): Use the location of each member while reporting errors.
29800 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29802 * cs-parser.jay: A for_initializer if is a
29803 local_variable_declaration really ammount to have an implicit
29804 block with the variable declaration and no initializer for for.
29806 * statement.cs (For.Emit): Cope with null initializers.
29808 This fixes the infinite loop on for initializers.
29810 2001-11-08 Miguel de Icaza <miguel@ximian.com>
29812 * enum.cs: More cleanup.
29814 * ecore.cs: Remove dead code.
29816 * class.cs (Property.Emit): More simplification.
29817 (Event.Emit): ditto.
29819 Reworked to have less levels of indentation.
29821 2001-11-08 Ravi Pratap <ravi@ximian.com>
29823 * class.cs (Property): Emit attributes.
29833 * enum.cs (Emit): Ditto.
29835 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
29838 * class.cs (Field, Event, etc.): Move attribute generation into the
29839 Emit method everywhere.
29841 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
29842 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
29843 as we had no way of defining nested enums !
29845 * rootcontext.cs : Adjust code accordingly.
29847 * typemanager.cs (AddEnumType): To keep track of enum types separately.
29849 2001-11-07 Ravi Pratap <ravi@ximian.com>
29851 * expression.cs (EvalConstantExpression): Move into ecore.cs
29853 * enum.cs (Enum): Rename some members and make them public and readonly
29854 according to our convention.
29856 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
29859 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
29861 (Enum::Emit): Write a simple version for now which doesn't try to compute
29862 expressions. I shall modify this to be more robust in just a while.
29864 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
29866 (TypeContainer::CloseType): Create the Enum types too.
29868 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
29870 * expression.cs (EvalConstantExpression): Get rid of completely.
29872 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
29873 user-defined values and other cases.
29875 (IsValidEnumLiteral): Helper function.
29877 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
29878 out there in the case we had a literal FieldExpr.
29880 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
29882 (Literalize): Revamp a bit to take two arguments.
29884 (EnumLiteral): New class which derives from Literal to wrap enum literals.
29886 2001-11-06 Ravi Pratap <ravi@ximian.com>
29888 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
29890 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
29892 (Resolve): Use the above to ensure we have proper initializers.
29894 2001-11-05 Ravi Pratap <ravi@ximian.com>
29896 * expression.cs (Expression::EvalConstantExpression): New method to
29897 evaluate constant expressions.
29899 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
29901 2001-11-07 Miguel de Icaza <miguel@ximian.com>
29903 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
29906 (Binary.ResolveOperator): Handle operator != (object a, object b)
29907 and operator == (object a, object b);
29909 (Binary.DoNumericPromotions): Indicate whether the numeric
29910 promotion was possible.
29912 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
29915 Made the ArrayAccess implement interface IAssignMethod instead of
29916 IStackStore as the order in which arguments are passed reflects
29919 * assign.cs: Instead of using expr.ExprClass to select the way of
29920 assinging, probe for the IStackStore/IAssignMethod interfaces.
29922 * typemanager.cs: Load InitializeArray definition.
29924 * rootcontext.cs (RootContext.MakeStaticData): Used to define
29925 static data that can be used to initialize arrays.
29927 2001-11-05 Miguel de Icaza <miguel@ximian.com>
29929 * expression.cs: Handle operator== and operator!= for booleans.
29931 (Conditioal.Reduce): Implement reducer for the ?: operator.
29933 (Conditional.Resolve): Implement dead code elimination.
29935 (Binary.Resolve): Catch string literals and return a new
29936 concatenated string.
29938 (Unary.Reduce): Implement reduction of unary expressions.
29940 * ecore.cs: Split out the expression core handling here.
29942 (Expression.Reduce): New method used to perform constant folding
29943 and CSE. This is needed to support constant-expressions.
29945 * statement.cs (Statement.EmitBoolExpression): Pass true and false
29946 targets, and optimize for !x.
29948 2001-11-04 Ravi Pratap <ravi@ximian.com>
29950 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
29951 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
29952 set custom atttributes.
29954 * literal.cs (Literal::GetValue): New abstract method to return the actual
29955 value of the literal, cast as an object.
29957 (*Literal): Implement GetValue method.
29959 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
29960 expressions to the arraylist but objects of type Argument.
29962 * class.cs (TypeContainer::Emit): Emit our attributes too.
29964 (Method::Emit, Constructor::Emit): Ditto.
29966 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
29967 to be ignoring earlier.
29969 2001-11-03 Ravi Pratap <ravi@ximian.com>
29971 * attribute.cs (AttributeSection::Define): Implement to do the business
29972 of constructing a CustomAttributeBuilder.
29974 (Attribute): New trivial class. Increases readability of code.
29976 * cs-parser.jay : Update accordingly.
29978 (positional_argument_list, named_argument_list, named_argument): New rules
29980 (attribute_arguments): Use the above so that we are more correct.
29982 2001-11-02 Ravi Pratap <ravi@ximian.com>
29984 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
29985 to perform all checks for a method with a params parameter.
29987 (Invocation::OverloadResolve): Update to use the above method and therefore
29988 cope correctly with params method invocations.
29990 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
29993 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
29994 constructors in our parent too because we can't afford to miss out on
29997 * attribute.cs (AttributeSection): New name for the class Attribute
29999 Other trivial changes to improve readability.
30001 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30002 use the new class names.
30004 2001-11-01 Ravi Pratap <ravi@ximian.com>
30006 * class.cs (Method::Define): Complete definition for params types too
30008 (Indexer::Define): Ditto.
30010 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30011 Cope everywhere with a request for info about the array parameter.
30013 2001-11-01 Ravi Pratap <ravi@ximian.com>
30015 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30017 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30018 local_variable_type to extract the string corresponding to the type.
30020 (local_variable_type): Fixup the action to use the new helper method.
30022 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30025 * expression.cs : Clean out code which uses the above.
30027 2001-10-31 Ravi Pratap <ravi@ximian.com>
30029 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30030 and bale out if necessary by returning a false.
30032 (RegisterProperty): Ditto.
30034 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30035 and print out appropriate error messages.
30037 * interface.cs (everywhere): Ditto.
30039 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30040 location to constructor.
30042 * class.cs (Property, Event, Indexer): Update accordingly.
30044 * ../errors/cs111.cs : Added.
30046 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30047 of a method, as laid down by the spec.
30049 (Invocation::OverloadResolve): Use the above method.
30051 2001-10-31 Ravi Pratap <ravi@ximian.com>
30053 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30054 now take a TypeContainer and a Parameters object.
30056 (ParameterData): Modify return type of ParameterModifier method to be
30057 Parameter.Modifier and not a string.
30059 (ReflectionParameters, InternalParameters): Update accordingly.
30061 * expression.cs (Argument::GetParameterModifier): Same here.
30063 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30064 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30065 symbol in it at all so maybe this is only for now.
30067 2001-10-30 Ravi Pratap <ravi@ximian.com>
30069 * support.cs (InternalParameters): Constructor now takes an extra argument
30070 which is the actual Parameters class.
30072 (ParameterDesc): Update to provide info on ref/out modifiers.
30074 * class.cs (everywhere): Update call to InternalParameters to pass in
30075 the second argument too.
30077 * support.cs (ParameterData): Add ParameterModifier, which is a method
30078 to return the modifier info [ref/out etc]
30080 (InternalParameters, ReflectionParameters): Implement the above.
30082 * expression.cs (Argument::ParameterModifier): Similar function to return
30083 info about the argument's modifiers.
30085 (Invocation::OverloadResolve): Update to take into account matching modifiers
30088 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30089 a new SetFormalParameters object which we pass to InternalParameters.
30091 2001-10-30 Ravi Pratap <ravi@ximian.com>
30093 * expression.cs (NewArray): Merge into the ArrayCreation class.
30095 2001-10-29 Ravi Pratap <ravi@ximian.com>
30097 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30098 NewUserdefinedArray into one as there wasn't much of a use in having
30101 * expression.cs (Argument): Change field's name to ArgType from Type.
30103 (Type): New readonly property which returns the proper type, taking into
30104 account ref/out modifiers.
30106 (everywhere): Adjust code accordingly for the above.
30108 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30109 whether we are emitting for a ref or out parameter.
30111 * expression.cs (Argument::Emit): Use the above field to set the state.
30113 (LocalVariableReference::Emit): Update to honour the flag and emit the
30116 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30118 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30120 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30122 (ReflectionParameters, InternalParameters): Implement the above method.
30124 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30127 (Invocation::FullMethodDesc): Ditto.
30129 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30131 * cs-parser.jay: Add extra production for the second form of array
30134 * expression.cs (ArrayCreation): Update to reflect the above
30137 * Small changes to prepare for Array initialization.
30139 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30141 * typemanager.cs (ImplementsInterface): interface might be null;
30142 Deal with this problem;
30144 Also, we do store negative hits on the cache (null values), so use
30145 this instead of calling t.GetInterfaces on the type everytime.
30147 2001-10-28 Ravi Pratap <ravi@ximian.com>
30149 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30151 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30152 split functionality out into different classes.
30154 (New::FormArrayType): Move into NewBuiltinArray.
30156 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30159 (NewBuiltinArray): New class to handle creation of built-in arrays.
30161 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30162 account creation of one-dimensional arrays.
30164 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30166 (NewUserdefinedArray::DoResolve): Implement.
30168 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30170 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30171 we maintain inside the TypeManager. This is necessary to perform lookups on the
30174 (LookupType): Update to perform GetType on the module builders too.
30176 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30178 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30180 2001-10-23 Ravi Pratap <ravi@ximian.com>
30182 * expression.cs (New::DoResolve): Implement guts of array creation.
30184 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30186 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30188 * expression.cs: Fix bug I introduced lsat night that broke
30191 (Expression.Resolve): Report a 246 error (can not resolve name)
30192 if we find a SimpleName in the stream.
30194 (Expression.ResolveLValue): Ditto.
30196 (Expression.ResolveWithSimpleName): This function is a variant of
30197 ResolveName, this one allows SimpleNames to be returned without a
30198 warning. The only consumer of SimpleNames is MemberAccess
30200 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30202 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30203 might arrive here. I have my doubts that this is correct.
30205 * statement.cs (Lock): Implement lock statement.
30207 * cs-parser.jay: Small fixes to support `lock' and `using'
30209 * cs-tokenizer.cs: Remove extra space
30211 * driver.cs: New flag --checked, allows to turn on integer math
30214 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30215 Threading.Monitor.Exit
30217 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30219 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30220 Expression Class to be IndexerAccess.
30222 Notice that Indexer::DoResolve sets the eclass to Value.
30224 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30226 * class.cs (TypeContainer::Emit): Emit code for indexers.
30228 * assign.cs (IAssignMethod): New interface implemented by Indexers
30229 and Properties for handling assignment.
30231 (Assign::Emit): Simplify and reuse code.
30233 * expression.cs (IndexerAccess, PropertyExpr): Implement
30234 IAssignMethod, clean up old code.
30236 2001-10-22 Ravi Pratap <ravi@ximian.com>
30238 * typemanager.cs (ImplementsInterface): New method to determine if a type
30239 implements a given interface. Provides a nice cache too.
30241 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30244 (ConvertReferenceExplicit): Ditto.
30246 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30247 various methods, with correct names etc.
30249 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30250 Operator.UnaryNegation.
30252 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30253 we have a unary plus or minus operator.
30255 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30258 * everywhere : update accordingly.
30260 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30263 * class.cs (Method::Define): For the case where we are implementing a method
30264 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30265 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30267 2001-10-21 Ravi Pratap <ravi@ximian.com>
30269 * interface.cs (FindMembers): Implement to work around S.R.E
30272 * typemanager.cs (IsInterfaceType): Implement.
30274 (FindMembers): Update to handle interface types too.
30276 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30277 use IsAssignableFrom as that is not correct - it doesn't work.
30279 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30280 and accordingly override EmitStatement.
30282 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30283 using the correct logic :-)
30285 2001-10-19 Ravi Pratap <ravi@ximian.com>
30287 * ../errors/cs-11.cs : Add to demonstrate error -11
30289 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30291 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30292 then pass this as a hint to ResolveLValue.
30294 * expression.cs (FieldExpr): Add Location information
30296 (FieldExpr::LValueResolve): Report assignment to readonly
30299 (Expression::ExprClassFromMemberInfo): Pass location information.
30301 (Expression::ResolveLValue): Add new method that resolves an
30304 (Expression::DoResolveLValue): Default invocation calls
30307 (Indexers): New class used to keep track of indexers in a given
30310 (IStackStore): Renamed from LValue, as it did not really describe
30311 what this did. Also ResolveLValue is gone from this interface and
30312 now is part of Expression.
30314 (ElementAccess): Depending on the element access type
30316 * typemanager.cs: Add `indexer_name_type' as a Core type
30317 (System.Runtime.CompilerServices.IndexerNameAttribute)
30319 * statement.cs (Goto): Take a location.
30321 2001-10-18 Ravi Pratap <ravi@ximian.com>
30323 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30324 if two delegates are compatible.
30326 (NewDelegate::DoResolve): Update to take care of the case when
30327 we instantiate a delegate from another delegate.
30329 * typemanager.cs (FindMembers): Don't even try to look up members
30330 of Delegate types for now.
30332 2001-10-18 Ravi Pratap <ravi@ximian.com>
30334 * delegate.cs (NewDelegate): New class to take care of delegate
30337 * expression.cs (New): Split the delegate related code out into
30338 the NewDelegate class.
30340 * delegate.cs (DelegateInvocation): New class to handle delegate
30343 * expression.cs (Invocation): Split out delegate related code into
30344 the DelegateInvocation class.
30346 2001-10-17 Ravi Pratap <ravi@ximian.com>
30348 * expression.cs (New::DoResolve): Implement delegate creation fully
30349 and according to the spec.
30351 (New::DoEmit): Update to handle delegates differently.
30353 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30354 because of which we were printing out arguments in reverse order !
30356 * delegate.cs (VerifyMethod): Implement to check if the given method
30357 matches the delegate.
30359 (FullDelegateDesc): Implement.
30361 (VerifyApplicability): Implement.
30363 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30364 delegate invocations too.
30366 (Invocation::Emit): Ditto.
30368 * ../errors/cs1593.cs : Added.
30370 * ../errors/cs1594.cs : Added.
30372 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30374 2001-10-16 Ravi Pratap <ravi@ximian.com>
30376 * typemanager.cs (intptr_type): Core type for System.IntPtr
30378 (InitCoreTypes): Update for the same.
30380 (iasyncresult_type, asynccallback_type): Ditto.
30382 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30385 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30388 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30389 the builders for the 4 members of a delegate type :-)
30391 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30394 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30396 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30398 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30400 * statement.cs (Break::Emit): Implement.
30401 (Continue::Emit): Implement.
30403 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30404 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30405 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30406 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30409 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30410 properties that track the label for the current loop (begin of the
30411 loop and end of the loop).
30413 2001-10-15 Ravi Pratap <ravi@ximian.com>
30415 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30416 use of emitting anything at all.
30418 * class.cs, rootcontext.cs : Get rid of calls to the same.
30420 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30422 (Populate): Define the constructor correctly and set the implementation
30425 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30428 (AddDelegateType): Implement.
30430 (IsDelegateType): Implement helper method.
30432 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30434 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30435 and accordingly handle it.
30437 * delegate.cs (Populate): Take TypeContainer argument.
30438 Implement bits to define the Invoke method. However, I still haven't figured out
30439 how to take care of the native int bit :-(
30441 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30442 Qualify the name of the delegate, not its return type !
30444 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30447 (StandardConversionExists): Checking for array types turns out to be recursive.
30449 (ConvertReferenceExplicit): Implement array conversion.
30451 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30453 2001-10-12 Ravi Pratap <ravi@ximian.com>
30455 * cs-parser.jay (delegate_declaration): Store the fully qualified
30456 name as it is a type declaration.
30458 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30461 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30462 as TypeContainer::DefineType.
30464 (Populate): Method in which all the definition of the various methods (Invoke)
30467 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30470 (CloseDelegate): Finally creates the delegate.
30472 * class.cs (TypeContainer::DefineType): Update to define delegates.
30473 (Populate, Emit and CloseType): Do the same thing here too.
30475 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30476 delegates in all these operations.
30478 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30480 * expression.cs: LocalTemporary: a new expression used to
30481 reference a temporary that has been created.
30483 * assign.cs: Handle PropertyAccess back here, so that we can
30484 provide the proper semantic access to properties.
30486 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30487 a few more explicit conversions.
30489 * modifiers.cs: `NEW' modifier maps to HideBySig.
30491 * expression.cs (PropertyExpr): Make this into an
30492 ExpressionStatement, and support the EmitStatement code path.
30494 Perform get/set error checking, clean up the interface.
30496 * assign.cs: recognize PropertyExprs as targets, and if so, turn
30497 them into toplevel access objects.
30499 2001-10-12 Miguel de Icaza <miguel@ximian.com>
30501 * expression.cs: PropertyExpr::PropertyExpr: use work around the
30504 * typemanager.cs: Keep track here of our PropertyBuilders again to
30505 work around lameness in SRE.
30507 2001-10-11 Miguel de Icaza <miguel@ximian.com>
30509 * expression.cs (LValue::LValueResolve): New method in the
30510 interface, used to perform a second resolution pass for LValues.
30512 (This::DoResolve): Catch the use of this in static methods.
30514 (This::LValueResolve): Implement.
30516 (This::Store): Remove warning, assigning to `this' in structures
30519 (Invocation::Emit): Deal with invocation of
30520 methods on value types. We need to pass the address to structure
30521 methods rather than the object itself. (The equivalent code to
30522 emit "this" for structures leaves the entire structure on the
30523 stack instead of a pointer to it).
30525 (ParameterReference::DoResolve): Compute the real index for the
30526 argument based on whether the method takes or not a `this' pointer
30527 (ie, the method is static).
30529 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
30530 value types returned from functions when we need to invoke a
30531 method on the sturcture.
30534 2001-10-11 Ravi Pratap <ravi@ximian.com>
30536 * class.cs (TypeContainer::DefineType): Method to actually do the business of
30537 defining the type in the Modulebuilder or Typebuilder. This is to take
30538 care of nested types which need to be defined on the TypeBuilder using
30539 DefineNestedMethod.
30541 (TypeContainer::GetClassBases): Implement. Essentially the code from the
30542 methods in RootContext, only ported to be part of TypeContainer.
30544 (TypeContainer::GetInterfaceOrClass): Ditto.
30546 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
30548 * interface.cs (Interface::DefineInterface): New method. Does exactly
30549 what RootContext.CreateInterface did earlier, only it takes care of nested types
30552 (Interface::GetInterfaces): Move from RootContext here and port.
30554 (Interface::GetInterfaceByName): Same here.
30556 * rootcontext.cs (ResolveTree): Re-write.
30558 (PopulateTypes): Re-write.
30560 * class.cs (TypeContainer::Populate): Populate nested types too.
30561 (TypeContainer::Emit): Emit nested members too.
30563 * typemanager.cs (AddUserType): Do not make use of the FullName property,
30564 instead just use the name argument passed in as it is already fully
30567 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
30568 to TypeContainer mapping to see if a type is user-defined.
30570 * class.cs (TypeContainer::CloseType): Implement.
30572 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
30573 the default constructor.
30575 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
30578 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
30580 * interface.cs (CloseType): Create the type here.
30582 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
30585 Remove all the methods which are now in TypeContainer.
30587 2001-10-10 Ravi Pratap <ravi@ximian.com>
30589 * delegate.cs (Define): Re-write bits to define the delegate
30592 2001-10-10 Miguel de Icaza <miguel@ximian.com>
30594 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
30596 * expression.cs (ImplicitReferenceConversion): handle null as well
30597 as a source to convert to any reference type.
30599 * statement.cs (Return): Perform any implicit conversions to
30600 expected return type.
30602 Validate use of return statement.
30604 * codegen.cs (EmitContext): Pass the expected return type here.
30606 * class.cs (Method, Constructor, Property): Pass expected return
30607 type to EmitContext.
30609 2001-10-09 Miguel de Icaza <miguel@ximian.com>
30611 * expression.cs: Make DoResolve take an EmitContext instead of a
30614 Replaced `l' and `location' for `loc', for consistency.
30616 (Error, Warning): Remove unneeded Tc argument.
30618 * assign.cs, literal.cs, constant.cs: Update to new calling
30621 * codegen.cs: EmitContext now contains a flag indicating whether
30622 code is being generated in a static method or not.
30624 * cs-parser.jay: DecomposeQI, new function that replaces the old
30625 QualifiedIdentifier. Now we always decompose the assembled
30626 strings from qualified_identifier productions into a group of
30629 2001-10-08 Miguel de Icaza <miguel@ximian.com>
30631 * rootcontext.cs: Deal with field-less struct types correctly now
30632 by passing the size option to Define Type.
30634 * class.cs: Removed hack that created one static field.
30636 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30638 * statement.cs: Moved most of the code generation here.
30640 2001-10-09 Ravi Pratap <ravi@ximian.com>
30642 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
30645 (ElementAccess): Remove useless bits for now - keep checks as the spec
30648 2001-10-08 Ravi Pratap <ravi@ximian.com>
30650 * expression.cs (ElementAccess::DoResolve): Remove my crap code
30651 and start performing checks according to the spec.
30653 2001-10-07 Ravi Pratap <ravi@ximian.com>
30655 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
30656 rank_specifiers instead.
30658 (rank_specifiers): Change the order in which the rank specifiers are stored
30660 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
30662 * expression.cs (ElementAccess): Implement the LValue interface too.
30664 2001-10-06 Ravi Pratap <ravi@ximian.com>
30666 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
30667 except that user defined conversions are not included.
30669 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
30670 perform the conversion of the return type, if necessary.
30672 (New::DoResolve): Check whether we are creating an array or an object
30673 and accordingly do the needful.
30675 (New::Emit): Same here.
30677 (New::DoResolve): Implement guts of array creation.
30679 (New::FormLookupType): Helper function.
30681 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30683 * codegen.cs: Removed most of the code generation here, and move the
30684 corresponding code generation bits to the statement classes.
30686 Added support for try/catch/finalize and throw.
30688 * cs-parser.jay: Added support for try/catch/finalize.
30690 * class.cs: Catch static methods having the flags override,
30691 virtual or abstract.
30693 * expression.cs (UserCast): This user cast was not really doing
30694 what it was supposed to do. Which is to be born in fully resolved
30695 state. Parts of the resolution were being performed at Emit time!
30699 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30701 * expression.cs: Implicity convert the result from UserCast.
30703 2001-10-05 Ravi Pratap <ravi@ximian.com>
30705 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
30706 prevented it from working correctly.
30708 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
30709 merely ConvertImplicit.
30711 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30713 * typemanager.cs: Make the LookupTypeContainer function static,
30714 and not per-instance.
30716 * class.cs: Make static FindMembers (the one that takes a Type
30719 * codegen.cs: Add EmitForeach here.
30721 * cs-parser.jay: Make foreach a toplevel object instead of the
30722 inline expansion, as we need to perform semantic analysis on it.
30724 2001-10-05 Ravi Pratap <ravi@ximian.com>
30726 * expression.cs (Expression::ImplicitUserConversion): Rename to
30727 UserDefinedConversion.
30729 (Expression::UserDefinedConversion): Take an extra argument specifying
30730 whether we look for explicit user conversions too.
30732 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
30734 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
30736 (ExplicitUserConversion): Make it a call to UserDefinedConversion
30737 with the appropriate arguments.
30739 * cs-parser.jay (cast_expression): Record location too.
30741 * expression.cs (Cast): Record location info.
30743 (Expression::ConvertExplicit): Take location argument.
30745 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
30746 to determine if we are doing explicit conversions.
30748 (UserCast::Emit): Update accordingly.
30750 (Expression::ConvertExplicit): Report an error if everything fails.
30752 * ../errors/cs0030.cs : Add.
30754 2001-10-04 Miguel de Icaza <miguel@ximian.com>
30756 * modifiers.cs: If the ABSTRACT keyword is present, also set the
30757 virtual and newslot bits.
30759 * class.cs (TypeContainer::RegisterRequiredImplementations):
30760 Record methods we need.
30762 (TypeContainer::MakeKey): Helper function to make keys for
30763 MethodBases, since the Methodbase key is useless.
30765 (TypeContainer::Populate): Call RegisterRequiredImplementations
30766 before defining the methods.
30768 Create a mapping for method_builders_to_methods ahead of time
30769 instead of inside a tight loop.
30771 (::RequireMethods): Accept an object as the data to set into the
30772 hashtable so we can report interface vs abstract method mismatch.
30774 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30776 * report.cs: Make all of it static.
30778 * rootcontext.cs: Drop object_type and value_type computations, as
30779 we have those in the TypeManager anyways.
30781 Drop report instance variable too, now it is a global.
30783 * driver.cs: Use try/catch on command line handling.
30785 Add --probe option to debug the error reporting system with a test
30788 * report.cs: Add support for exiting program when a probe
30789 condition is reached.
30791 2001-10-03 Ravi Pratap <ravi@ximian.com>
30793 * expression.cs (Binary::DoNumericPromotions): Fix the case when
30794 we do a forcible conversion regardless of type, to check if
30795 ForceConversion returns a null.
30797 (Binary::error19): Use location to report error.
30799 (Unary::error23): Use location here too.
30801 * ../errors/cs0019.cs : Check in.
30803 * ../errors/cs0023.cs : Check in.
30805 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
30806 case of a non-null MethodInfo object with a length of 0 !
30808 (Binary::ResolveOperator): Flag error if overload resolution fails to find
30809 an applicable member - according to the spec :-)
30810 Also fix logic to find members in base types.
30812 (Unary::ResolveOperator): Same here.
30814 (Unary::report23): Change name to error23 and make first argument a TypeContainer
30815 as I was getting thoroughly confused between this and error19 :-)
30817 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
30818 (::FindMostEncompassedType): Implement.
30819 (::FindMostEncompassingType): Implement.
30820 (::StandardConversionExists): Implement.
30822 (UserImplicitCast): Re-vamp. We now need info about most specific
30823 source and target types so that we can do the necessary conversions.
30825 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
30826 mathematical union with no duplicates.
30828 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30830 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
30831 in order from base classes to child classes, so that we can in
30832 child classes look up in our parent for method names and
30833 attributes (required for handling abstract, virtual, new, override
30834 constructs: we need to instrospect our base class, and if we dont
30835 populate the classes in order, the introspection might be
30836 incorrect. For example, a method could query its parent before
30837 the parent has any methods and would determine that the parent has
30838 no abstract methods (while it could have had them)).
30840 (RootContext::CreateType): Record the order in which we define the
30843 2001-10-02 Miguel de Icaza <miguel@ximian.com>
30845 * class.cs (TypeContainer::Populate): Also method definitions can
30846 fail now, keep track of this.
30848 (TypeContainer::FindMembers): Implement support for
30849 DeclaredOnly/noDeclaredOnly flag.
30851 (Constructor::Emit) Return the ConstructorBuilder.
30853 (Method::Emit) Return the MethodBuilder.
30854 Check for abstract or virtual methods to be public.
30856 * rootcontext.cs (RootContext::CreateType): Register all the
30857 abstract methods required for the class to be complete and the
30858 interface methods that must be implemented.
30860 * cs-parser.jay: Report error 501 (method requires body if it is
30861 not marked abstract or extern).
30863 * expression.cs (TypeOf::Emit): Implement.
30865 * typemanager.cs: runtime_handle_type, new global type.
30867 * class.cs (Property::Emit): Generate code for properties.
30869 2001-10-02 Ravi Pratap <ravi@ximian.com>
30871 * expression.cs (Unary::ResolveOperator): Find operators on base type
30872 too - we now conform exactly to the spec.
30874 (Binary::ResolveOperator): Same here.
30876 * class.cs (Operator::Define): Fix minor quirk in the tests.
30878 * ../errors/cs0215.cs : Added.
30880 * ../errors/cs0556.cs : Added.
30882 * ../errors/cs0555.cs : Added.
30884 2001-10-01 Miguel de Icaza <miguel@ximian.com>
30886 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
30887 single integer which is really efficient
30889 2001-10-01 Ravi Pratap <ravi@ximian.com>
30891 * expression.cs (Expression::ImplicitUserConversion): Use location
30892 even in the case when we are examining True operators.
30894 * class.cs (Operator::Define): Perform extensive checks to conform
30895 with the rules for operator overloading in the spec.
30897 * expression.cs (Expression::ImplicitReferenceConversion): Implement
30898 some of the other conversions mentioned in the spec.
30900 * typemanager.cs (array_type): New static member for the System.Array built-in
30903 (cloneable_interface): For System.ICloneable interface.
30905 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
30906 we start resolving the tree and populating types.
30908 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
30910 2001-10-01 Miguel de Icaza <miguel@ximian.com>
30912 * expression.cs (Expression::ExprClassFromMemberInfo,
30913 Expression::Literalize): Create literal expressions from
30914 FieldInfos which are literals.
30916 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
30917 type casts, because they were wrong. The test suite in tests
30920 (ImplicitNumericConversion): ushort to ulong requires a widening
30923 Int32 constant to long requires widening cast as well.
30925 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
30926 for integers because the type on the stack is not i4.
30928 2001-09-30 Miguel de Icaza <miguel@ximian.com>
30930 * expression.cs (report118): require location argument.
30932 * parameter.cs: Do not dereference potential null value.
30934 * class.cs: Catch methods that lack the `new' keyword when
30935 overriding a name. Report warnings when `new' is used without
30936 anything being there to override.
30938 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
30940 * class.cs: Only add constructor to hashtable if it is non-null
30941 (as now constructors can fail on define).
30943 (TypeManager, Class, Struct): Take location arguments.
30945 Catch field instance initialization in structs as errors.
30947 accepting_filter: a new filter for FindMembers that is static so
30948 that we dont create an instance per invocation.
30950 (Constructor::Define): Catch errors where a struct constructor is
30953 * cs-parser.jay: Pass location information for various new
30956 * delegate.cs (Delegate): take a location argument.
30958 * driver.cs: Do not call EmitCode if there were problesm in the
30959 Definition of the types, as many Builders wont be there.
30961 * decl.cs (Decl::Decl): Require a location argument.
30963 * cs-tokenizer.cs: Handle properly hex constants that can not fit
30964 into integers, and find the most appropiate integer for it.
30966 * literal.cs: Implement ULongLiteral.
30968 * rootcontext.cs: Provide better information about the location of
30969 failure when CreateType fails.
30971 2001-09-29 Miguel de Icaza <miguel@ximian.com>
30973 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
30976 * expression.cs (Binary::CheckShiftArguments): Add missing type
30978 (Binary::ResolveOperator): Add type to the logical and and logical
30979 or, Bitwise And/Or and Exclusive Or code paths, it was missing
30982 (Binary::DoNumericPromotions): In the case where either argument
30983 is ulong (and most signed types combined with ulong cause an
30984 error) perform implicit integer constant conversions as well.
30986 2001-09-28 Miguel de Icaza <miguel@ximian.com>
30988 * expression.cs (UserImplicitCast): Method should always be
30990 (Invocation::BetterConversion): Simplified test for IntLiteral.
30992 (Expression::ImplicitNumericConversion): Split this routine out.
30993 Put the code that performs implicit constant integer conversions
30996 (Expression::Resolve): Become a wrapper around DoResolve so we can
30997 check eclass and type being set after resolve.
30999 (Invocation::Badness): Remove this dead function
31001 (Binary::ResolveOperator): Do not compute the expensive argumnets
31002 unless we have a union for it.
31004 (Probe::Emit): Is needs to do an isinst and then
31005 compare against null.
31007 (::CanConvert): Added Location argument. If the Location argument
31008 is null (Location.Null), then we do not report errors. This is
31009 used by the `probe' mechanism of the Explicit conversion. We do
31010 not want to generate an error for something that the user
31011 explicitly requested to be casted. But the pipeline for an
31012 explicit cast first tests for potential implicit casts.
31014 So for now, if the Location is null, it means `Probe only' to
31015 avoid adding another argument. Might have to revise this
31018 (ClassCast): New class used to type cast objects into arbitrary
31019 classes (used in Explicit Reference Conversions).
31021 Implement `as' as well.
31023 Reverted all the patches from Ravi below: they were broken:
31025 * The use of `level' as a mechanism to stop recursive
31026 invocations is wrong. That was there just to catch the
31027 bug with a strack trace but not as a way of addressing
31030 To fix the problem we have to *understand* what is going
31031 on and the interactions and come up with a plan, not
31032 just get things going.
31034 * The use of the type conversion cache that I proposed
31035 last night had an open topic: How does this work across
31036 protection domains. A user defined conversion might not
31037 be public in the location where we are applying the
31038 conversion, a different conversion might be selected
31039 (ie, private A->B (better) but public B->A (worse),
31040 inside A, A->B applies, but outside it, B->A will
31043 * On top of that (ie, even if the above is solved),
31044 conversions in a cache need to be abstract. Ie, `To
31045 convert from an Int to a Short use an OpcodeCast', not
31046 `To convert from an Int to a Short use the OpcodeCast on
31047 the variable 5' (which is what this patch was doing).
31049 2001-09-28 Ravi Pratap <ravi@ximian.com>
31051 * expression.cs (Invocation::ConversionExists): Re-write to use
31052 the conversion cache
31054 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31055 cache all conversions done, not just user-defined ones.
31057 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31058 to determine if a conversion exists instead of acutually trying to
31059 perform the conversion. It's faster too.
31061 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31062 and only then attempt the implicit conversion.
31064 2001-09-28 Ravi Pratap <ravi@ximian.com>
31066 * expression.cs (ConvertImplicit): Use a cache for conversions
31067 already found. Check level of recursion and bail out if necessary.
31069 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31071 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31072 Export standard methods that we expect for string operations.
31074 * statement.cs (Block::UsageWarning): Track usage of variables and
31075 report the errors for not used variables.
31077 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31080 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31082 * codegen.cs: remove unnneded code
31084 * expression.cs: Removed BuiltinTypeAccess class
31086 Fix the order in which implicit conversions are
31089 The previous fixed dropped support for boxed conversions (adding a
31090 test to the test suite now)
31092 (UserImplicitCast::CanConvert): Remove test for source being null,
31093 that code is broken. We should not feed a null to begin with, if
31094 we do, then we should track the bug where the problem originates
31095 and not try to cover it up here.
31097 Return a resolved expression of type UserImplicitCast on success
31098 rather than true/false. Ravi: this is what I was talking about,
31099 the pattern is to use a static method as a "constructor" for
31102 Also, do not create arguments until the very last minute,
31103 otherwise we always create the arguments even for lookups that
31104 will never be performed.
31106 (UserImplicitCast::Resolve): Eliminate, objects of type
31107 UserImplicitCast are born in a fully resolved state.
31109 * typemanager.cs (InitCoreTypes): Init also value_type
31110 (System.ValueType).
31112 * expression.cs (Cast::Resolve): First resolve the child expression.
31114 (LValue): Add new method AddressOf to be used by
31117 Change the argument of Store to take an EmitContext instead of an
31118 ILGenerator, because things like FieldExpr need to be able to call
31119 their children expression to generate the instance code.
31121 (Expression::Error, Expression::Warning): Sugar functions for
31124 (Expression::MemberLookup): Accept a TypeContainer instead of a
31125 Report as the first argument.
31127 (Expression::ResolvePrimary): Killed. I still want to improve
31128 this as currently the code is just not right.
31130 (Expression::ResolveMemberAccess): Simplify, but it is still
31133 (Unary::Resolve): Catch errors in AddressOf operators.
31135 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31136 index to a byte for the short-version, or the compiler will choose
31137 the wrong Emit call, which generates the wrong data.
31139 (ParameterReference::Emit, ::Store): same.
31141 (FieldExpr::AddressOf): Implement.
31143 * typemanager.cs: TypeManager: made public variable instead of
31146 * driver.cs: document --fatal.
31148 * report.cs (ErrorMessage, WarningMessage): new names for the old
31149 Error and Warning classes.
31151 * cs-parser.jay (member_access): Turn built-in access to types
31152 into a normal simplename
31154 2001-09-27 Ravi Pratap <ravi@ximian.com>
31156 * expression.cs (Invocation::BetterConversion): Fix to cope
31157 with q being null, since this was introducing a bug.
31159 * expression.cs (ConvertImplicit): Do built-in conversions first.
31161 2001-09-27 Ravi Pratap <ravi@ximian.com>
31163 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31165 2001-09-27 Ravi Pratap <ravi@ximian.com>
31167 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31168 I had introduced long ago (what's new ?).
31170 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31171 the work of all the checking.
31172 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31173 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31175 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31176 that is the right way.
31178 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31179 overloading resolution. Use everywhere instead of cutting and pasting code.
31181 (Binary::ResolveOperator): Use MakeUnionSet.
31183 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31184 we have to convert to bool types. Not complete yet.
31186 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31188 * typemanager.cs (TypeManager::CSharpName): support ushort.
31190 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31191 to provide an expression that performsn an implicit constant int
31192 conversion (section 6.1.6).
31193 (Expression::ConvertImplicitRequired): Reworked to include
31194 implicit constant expression conversions.
31196 (Expression::ConvertNumericExplicit): Finished.
31198 (Invocation::Emit): If InstanceExpression is null, then it means
31199 that we perform a call on this.
31201 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31203 * expression.cs (Unary::Emit): Remove some dead code.
31204 (Probe): Implement Resolve and Emit for `is'.
31205 (Expression::ConvertImplicitRequired): Attempt to do constant
31206 expression conversions here. Maybe should be moved to
31207 ConvertImplicit, but I am not sure.
31208 (Expression::ImplicitLongConstantConversionPossible,
31209 Expression::ImplicitIntConstantConversionPossible): New functions
31210 that tell whether is it possible to apply an implicit constant
31211 expression conversion.
31213 (ConvertNumericExplicit): Started work on explicit numeric
31216 * cs-parser.jay: Update operator constants.
31218 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31219 (Parameters::GetSignature): Hook up VerifyArgs here.
31220 (Parameters::VerifyArgs): Verifies that no two arguments have the
31223 * class.cs (Operator): Update the operator names to reflect the
31224 ones that the spec expects (as we are just stringizing the
31227 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31228 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31229 previous usage did only work for our methods.
31230 (Expression::ConvertImplicit): Handle decimal implicit numeric
31231 conversions as well.
31232 (Expression::InternalTypeConstructor): Used to invoke constructors
31233 on internal types for default promotions.
31235 (Unary::Emit): Implement special handling for the pre/post
31236 increment/decrement for overloaded operators, as they need to have
31237 the same semantics as the other operators.
31239 (Binary::ResolveOperator): ditto.
31240 (Invocation::ConversionExists): ditto.
31241 (UserImplicitCast::Resolve): ditto.
31243 2001-09-26 Ravi Pratap <ravi@ximian.com>
31245 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31246 operator, return after emitting body. Regression tests pass again !
31248 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31249 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31250 (Invocation::OverloadResolve): Ditto.
31251 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31253 * everywhere : update calls to the above methods accordingly.
31255 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31257 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31259 * expression.cs (ExpressionStatement): New base class used for
31260 expressions that can appear in statements, so that we can provide
31261 an alternate path to generate expression that do not leave a value
31264 (Expression::Emit, and all the derivatives): We no longer return
31265 whether a value is left on the stack or not. Every expression
31266 after being emitted leaves a single value on the stack.
31268 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31269 facilties of ExpressionStatement if possible.
31271 * cs-parser.jay: Update statement_expression.
31273 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31275 * driver.cs: Change the wording of message
31277 2001-09-25 Ravi Pratap <ravi@ximian.com>
31279 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31280 the type of the expression to the return type of the method if
31281 we have an overloaded operator match ! The regression tests pass again !
31282 (Unary::ResolveOperator): Ditto.
31284 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31285 to find "op_Implicit", not "implicit" ;-)
31286 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31287 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31289 * everywhere : Correct calls to the above accordingly.
31291 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31292 (ConvertImplicit): Do user-defined conversion if it exists.
31294 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31296 * assign.cs: track location.
31297 (Resolve): Use implicit conversions on assignment.
31299 * literal.cs: Oops. Not good, Emit of short access values should
31300 pass (Bytes) or the wrong argument will be selected.
31302 * expression.cs (Unary::Emit): Emit code for -expr.
31304 (Unary::ResolveOperator): Handle `Substract' for non-constants
31305 (substract from zero from the non-constants).
31306 Deal with Doubles as well.
31308 (Expression::ConvertImplicitRequired): New routine that reports an
31309 error if no implicit conversion exists.
31311 (Invocation::OverloadResolve): Store the converted implicit
31312 expressions if we make them
31314 2001-09-24 Ravi Pratap <ravi@ximian.com>
31316 * class.cs (ConstructorInitializer): Take a Location argument.
31317 (ConstructorBaseInitializer): Same here.
31318 (ConstructorThisInitializer): Same here.
31320 * cs-parser.jay : Update all calls accordingly.
31322 * expression.cs (Unary, Binary, New): Take location argument.
31323 Update accordingly everywhere.
31325 * cs-parser.jay : Update all calls to the above to take a location
31328 * class.cs : Ditto.
31330 2001-09-24 Ravi Pratap <ravi@ximian.com>
31332 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31333 (Invocation::BetterConversion): Same here
31334 (Invocation::ConversionExists): Ditto.
31336 (Invocation::ConversionExists): Implement.
31338 2001-09-22 Ravi Pratap <ravi@ximian.com>
31340 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31341 Also take an additional TypeContainer argument.
31343 * All over : Pass in TypeContainer as argument to OverloadResolve.
31345 * typemanager.cs (CSharpName): Update to check for the string type and return
31348 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31351 2001-09-21 Ravi Pratap <ravi@ximian.com>
31353 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31354 (Invocation::BetterFunction): Implement.
31355 (Invocation::BetterConversion): Implement.
31356 (Invocation::ConversionExists): Skeleton, no implementation yet.
31358 Okay, things work fine !
31360 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31362 * typemanager.cs: declare and load enum_type, delegate_type and
31365 * expression.cs (Expression::Emit): Now emit returns a value that
31366 tells whether a value is left on the stack or not. This strategy
31367 might be reveted tomorrow with a mechanism that would address
31368 multiple assignments.
31369 (Expression::report118): Utility routine to report mismatches on
31372 (Unary::Report23): Report impossible type/operator combination
31375 (Unary::IsIncrementableNumber): Whether the type can be
31376 incremented or decremented with add.
31377 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31379 (Unary::ResolveOperator): Implement ++, !, ~,
31381 (Invocation::Emit): Deal with new Emit convetion.
31383 * All Expression derivatives: Updated their Emit method to return
31384 whether they leave values on the stack or not.
31386 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31387 stack for expressions that are statements.
31389 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31391 * expression.cs (LValue): New interface. Must be implemented by
31393 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31396 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31397 interface for generating code, simplifies the code.
31399 2001-09-20 Ravi Pratap <ravi@ximian.com>
31401 * expression.cs (everywhere): Comment out return statements in ::Resolve
31402 methods to avoid the warnings.
31404 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31406 * driver.cs (parse): Report error 2001 if we can not open the
31409 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31412 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31415 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31416 otherwise nested blocks end up with the same index.
31418 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31420 * expression.cs: Instead of having FIXMEs in the Resolve
31421 functions, throw exceptions so it is obvious that we are facing a
31424 * cs-parser.jay (invocation_expression): Pass Location information.
31426 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31427 Use a basename for those routines because .NET does not like paths
31430 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31433 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31435 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31436 are loading the correct data types (throws an exception if not).
31437 (TypeManager::InitCoreTypes): Use CoreLookupType
31439 * expression.cs (Unary::ResolveOperator): return the child
31440 expression for expressions which are just +expr.
31441 (Unary::ResolveOperator): Return negative literals for -LITERAL
31442 expressions (otherwise they are Unary {Literal}).
31443 (Invocation::Badness): Take into account `Implicit constant
31444 expression conversions'.
31446 * literal.cs (LongLiteral): Implement long literal class.
31447 (IntLiteral): export the `Value' of the intliteral.
31449 2001-09-19 Ravi Pratap <ravi@ximian.com>
31451 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31453 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31454 instead of 'Operator'
31456 * expression.cs (Binary::ResolveOperator): Update accordingly.
31457 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31460 * cs-parser.jay (unary_expression): Update to use the new names.
31462 * gen-treedump.cs (GetUnary): Same here.
31464 * expression.cs (Unary::Resolve): Implement.
31465 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31466 operators are found instead of making noise ;-)
31467 (Unary::ResolveOperator): New method to do precisely the same thing which
31468 Binary::ResolveOperator does for Binary expressions.
31469 (Unary.method, .Arguments): Add.
31470 (Unary::OperName): Implement.
31471 (Unary::ForceConversion): Copy and Paste !
31473 * class.cs (Operator::Define): Fix a small bug for the case when we have
31476 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31477 for the inbuilt operators. Only overloading works for now ;-)
31479 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31481 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31482 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31484 * expression.cs (This::Emit): Implement.
31485 (This::Resolve): Implement.
31486 (TypeOf:Resolve): Implement.
31487 (Expression::ResolveSimpleName): Add an implicit this to instance
31489 (MemberAccess::Resolve): Deal with Parameters and Fields.
31490 Bind instance variable to Field expressions.
31491 (FieldExpr::Instance): New field used to track the expression that
31492 represents the object instance.
31493 (FieldExpr::Resolve): Track potential errors from MemberLookup not
31495 (FieldExpr::Emit): Implement.
31497 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
31498 the last instruction contains a return opcode to avoid generating
31499 the last `ret' instruction (this generates correct code, and it is
31500 nice to pass the peverify output).
31502 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
31503 initializer for static and instance variables.
31504 (Constructor::Emit): Allow initializer to be null in the case of
31505 static constructors. Only emit initializer for instance
31508 (TypeContainer::FindMembers): Return a null array if there are no
31511 Also fix the code for the MemberTypes.Method branch, as it was not
31512 scanning that for operators (or tried to access null variables before).
31514 * assign.cs (Assign::Emit): Handle instance and static fields.
31518 * driver.cs: Stop compilation if there are parse errors.
31520 * cs-parser.jay (constructor_declaration): Provide default base
31521 initializer for non-static constructors.
31522 (constructor_declarator): Do not provide a default base
31523 initializers if none was specified.
31524 Catch the fact that constructors should not have parameters.
31526 * class.cs: Do not emit parent class initializers for static
31527 constructors, that should be flagged as an error.
31529 2001-09-18 Ravi Pratap <ravi@ximian.com>
31531 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
31532 Move back code into TypeContainer::Populate.
31534 2001-09-18 Ravi Pratap <ravi@ximian.com>
31536 * class.cs (TypeContainer::AddConstructor): Fix the check to
31537 compare against Name, not Basename.
31538 (Operator::OpType): Change Plus and Minus to Add and Subtract.
31540 * cs-parser.jay : Update accordingly.
31542 * class.cs (TypeContainer::FindMembers): For the case where we are searching
31543 for methods, don't forget to look into the operators too.
31544 (RegisterMethodBuilder): Helper method to take care of this for
31545 methods, constructors and operators.
31546 (Operator::Define): Completely revamp.
31547 (Operator.OperatorMethod, MethodName): New fields.
31548 (TypeContainer::Populate): Move the registering of builders into
31549 RegisterMethodBuilder.
31550 (Operator::Emit): Re-write.
31552 * expression.cs (Binary::Emit): Comment out code path to emit method
31553 invocation stuff for the case when we have a user defined operator. I am
31554 just not able to get it right !
31556 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31558 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
31561 (Expression::MemberLookup): Provide a version that allows to
31562 specify the MemberTypes and BindingFlags.
31564 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
31565 so it was not fetching variable information from outer blocks.
31567 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
31568 Beforefieldinit as it was buggy.
31570 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
31571 that Ravi put here.
31573 * class.cs (Constructor::Emit): Only emit if block is not null.
31574 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
31575 deal with this by semantically definining it as if the user had
31578 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
31579 constructors as we now "emit" them at a higher level.
31581 (TypeContainer::DefineDefaultConstructor): Used to define the
31582 default constructors if none was provided.
31584 (ConstructorInitializer): Add methods Resolve and Emit.
31586 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
31588 2001-09-17 Ravi Pratap <ravi@ximian.com>
31590 * class.cs (TypeContainer::EmitDefaultConstructor): Register
31591 the default constructor builder with our hashtable for methodbuilders
31594 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
31595 and argument_count is 0 in which case we have a match.
31596 (Binary::ResolveOperator): More null checking and miscellaneous coding
31599 2001-09-17 Ravi Pratap <ravi@ximian.com>
31601 * rootcontext.cs (IsNameSpace): Compare against null.
31603 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
31605 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
31606 and Unary::Operator.
31608 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
31611 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
31612 we have overloaded operators.
31613 (Binary::ResolveOperator): Implement the part which does the operator overload
31616 * class.cs (Operator::Emit): Implement.
31617 (TypeContainer::Emit): Emit the operators we have too.
31619 * expression.cs (Binary::Emit): Update to emit the appropriate code for
31620 the case when we have a user-defined operator.
31622 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31624 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
31626 2001-09-16 Ravi Pratap <ravi@ximian.com>
31628 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
31629 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
31630 (Constructor::Emit): Implement.
31631 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
31632 if we have no work to do.
31633 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
31636 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
31637 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
31639 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
31642 2001-09-15 Ravi Pratap <ravi@ximian.com>
31644 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
31646 (Tree::RecordNamespace): Method to do what the name says ;-)
31647 (Tree::Namespaces): Property to get at the namespaces hashtable.
31649 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
31652 * rootcontext.cs (IsNamespace): Fixed it :-)
31654 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31656 * class.cs (TypeContainer::FindMembers): Add support for
31658 (MethodCore): New class that encapsulates both the shared aspects
31659 of a Constructor and a Method.
31660 (Method, Constructor): Factored pieces into MethodCore.
31662 * driver.cs: Added --fatal which makes errors throw exceptions.
31663 Load System assembly as well as part of the standard library.
31665 * report.cs: Allow throwing exceptions on errors for debugging.
31667 * modifiers.cs: Do not use `parent', instead use the real type
31668 container to evaluate permission settings.
31670 * class.cs: Put Ravi's patch back in. He is right, and we will
31671 have to cope with the
31673 2001-09-14 Ravi Pratap <ravi@ximian.com>
31675 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
31676 FamORAssem, not FamANDAssem.
31678 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31680 * driver.cs: Added --parse option that only parses its input files
31683 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
31684 incorrect. IsTopLevel is not used to tell whether an object is
31685 root_types or not (that can be achieved by testing this ==
31686 root_types). But to see if this is a top-level *class* (not
31687 necessarly our "toplevel" container).
31689 2001-09-14 Ravi Pratap <ravi@ximian.com>
31691 * enum.cs (Enum::Define): Modify to call the Lookup method on the
31692 parent instead of a direct call to GetType.
31694 2001-09-14 Ravi Pratap <ravi@ximian.com>
31696 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
31697 Modifiers.TypeAttr. This should just be a call to that method.
31699 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
31700 object so that we can determine if we are top-level or not.
31702 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
31705 * enum.cs (Enum::Define): Ditto.
31707 * modifiers.cs (FieldAttr): Re-write.
31709 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
31710 (TypeContainer::HaveStaticConstructor): New property to provide access
31711 to precisely that info.
31713 * modifiers.cs (MethodAttr): Re-write.
31714 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
31716 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
31717 of top-level types as claimed.
31719 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31721 * expression.cs (MemberLookup): Fruitless attempt to lookup
31722 constructors. Maybe I need to emit default constructors? That
31723 might be it (currently .NET emits this for me automatically).
31724 (Invocation::OverloadResolve): Cope with Arguments == null.
31725 (Invocation::EmitArguments): new function, shared by the new
31726 constructor and us.
31727 (Invocation::Emit): Handle static and instance methods. Emit
31728 proper call instruction for virtual or non-virtual invocations.
31729 (New::Emit): Implement.
31730 (New::Resolve): Implement.
31731 (MemberAccess:Resolve): Implement.
31732 (MethodGroupExpr::InstanceExpression): used conforming to the spec
31733 to track instances.
31734 (FieldExpr::Resolve): Set type.
31736 * support.cs: Handle empty arguments.
31738 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
31739 SimpleLookup): Auxiliary routines to help parse a qualifier
31742 Update qualifier_identifier rule.
31744 * codegen.cs: Removed debugging messages.
31746 * class.cs: Make this a global thing, this acts just as a "key" to
31747 objects that we might have around.
31749 (Populate): Only initialize method_builders_to_methods once.
31751 * expression.cs (PropertyExpr): Initialize type from the
31754 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
31755 Resolve pattern. Attempt to implicitly convert value to boolean.
31758 * expression.cs: Set the type for the int32/int32 argument case.
31759 (Binary::ResolveOperator): Set the return type to boolean for
31760 comparission operators
31762 * typemanager.cs: Remove debugging print code.
31764 (Invocation::Resolve): resolve type.
31766 * class.cs: Allocate a MemberInfo of the correct size, as the code
31767 elsewhere depends on the test to reflect the correct contents.
31769 (Method::) Keep track of parameters, due to System.Reflection holes
31771 (TypeContainer::Populate): Keep track of MethodBuilders to Method
31774 (TypeContainer::FindMembers): Use ArrayList and then copy an array
31775 of the exact size and return that.
31777 (Class::LookupMethodByBuilder): New function that maps
31778 MethodBuilders to its methods. Required to locate the information
31779 on methods because System.Reflection bit us again.
31781 * support.cs: New file, contains an interface ParameterData and
31782 two implementations: ReflectionParameters and InternalParameters
31783 used to access Parameter information. We will need to grow this
31786 * expression.cs (Invocation::GetParameterData): implement a cache
31787 and a wrapper around the ParameterData creation for methods.
31788 (Invocation::OverloadResolve): Use new code.
31790 2001-09-13 Ravi Pratap <ravi@ximian.com>
31792 * class.cs (TypeContainer::EmitField): Remove and move into
31793 (Field::Define): here and modify accordingly.
31794 (Field.FieldBuilder): New member.
31795 (TypeContainer::Populate): Update accordingly.
31796 (TypeContainer::FindMembers): Implement.
31798 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31800 * statement.cs: (VariableInfo::VariableType): New field to be
31801 initialized with the full type once it is resolved.
31803 2001-09-12 Miguel de Icaza <miguel@ximian.com>
31805 * parameter.cs (GetParameterInfo): Use a type cache to compute
31806 things only once, and to reuse this information
31808 * expression.cs (LocalVariableReference::Emit): Implement.
31809 (OpcodeCast::Emit): fix.
31811 (ParameterReference::Resolve): Implement.
31812 (ParameterReference::Emit): Implement.
31814 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
31815 that are expressions need to stay as Expressions.
31817 * typemanager.cs (CSharpName): Returns the C# name of a type if
31820 * expression.cs (Expression::ConvertImplicit): New function that
31821 implements implicit type conversions.
31823 (Expression::ImplicitReferenceConversion): Implements implicit
31824 reference conversions.
31826 (EmptyCast): New type for transparent casts.
31828 (OpcodeCast): New type for casts of types that are performed with
31829 a sequence of bytecodes.
31831 (BoxedCast): New type used for casting value types into reference
31832 types. Emits a box opcode.
31834 (Binary::DoNumericPromotions): Implements numeric promotions of
31835 and computation of the Binary::Type.
31837 (Binary::EmitBranchable): Optimization.
31839 (Binary::Emit): Implement code emission for expressions.
31841 * typemanager.cs (TypeManager): Added two new core types: sbyte
31844 2001-09-12 Ravi Pratap <ravi@ximian.com>
31846 * class.cs (TypeContainer::FindMembers): Method which does exactly
31847 what Type.FindMembers does, only we don't have to use reflection. No
31848 implementation yet.
31850 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
31851 typecontainer objects as we need to get at them.
31852 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
31854 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
31855 typecontainer object.
31857 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
31858 of just a Report object.
31860 2001-09-11 Ravi Pratap <ravi@ximian.com>
31862 * class.cs (Event::Define): Go back to using the prefixes "add_" and
31864 (TypeContainer::Populate): Now define the delegates of the type too.
31865 (TypeContainer.Delegates): Property to access the list of delegates defined
31868 * delegates.cs (Delegate::Define): Implement partially.
31870 * modifiers.cs (TypeAttr): Handle more flags.
31872 2001-09-11 Ravi Pratap <ravi@ximian.com>
31874 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
31876 (Operator::Define): Re-write logic to get types by using the LookupType method
31877 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
31878 (Indexer::Define): Ditto.
31879 (Event::Define): Ditto.
31880 (Property::Define): Ditto.
31882 2001-09-10 Ravi Pratap <ravi@ximian.com>
31884 * class.cs (TypeContainer::Populate): Now define operators too.
31885 (TypeContainer.Operators): New property to access the list of operators
31887 (Operator.OperatorMethodBuilder): New member to hold the method builder
31888 for the operator we are defining.
31889 (Operator::Define): Implement.
31891 2001-09-10 Ravi Pratap <ravi@ximian.com>
31893 * class.cs (Event::Define): Make the prefixes of the accessor methods
31894 addOn_ and removeOn_
31896 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
31897 of the location being passed in too. Ideally, this should go later since all
31898 error reporting should be done through the Report object.
31900 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
31901 (Populate): Iterate thru the indexers we have and define them too.
31902 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
31903 for the get and set accessors.
31904 (Indexer::Define): Implement.
31906 2001-09-09 Miguel de Icaza <miguel@ximian.com>
31908 * expression.cs (Binary::Resolve): Beginning of it. I scratched
31909 my previous implementation, did not work.
31911 * typemanager.cs: Add a couple of missing types (the longs).
31913 * literal.cs: Use TypeManager.bool_type instead of getting it.
31915 * expression.cs (EventExpr): New kind of expressions.
31916 (Expressio::ExprClassFromMemberInfo): finish
31918 2001-09-08 Miguel de Icaza <miguel@ximian.com>
31920 * assign.cs: Emit stores to static fields differently.
31922 2001-09-08 Ravi Pratap <ravi@ximian.com>
31924 * Merge in changes and adjust code to tackle conflicts. Backed out my
31925 code in Assign::Resolve ;-)
31927 2001-09-08 Ravi Pratap <ravi@ximian.com>
31929 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
31930 instead Report.Error and also pass in the location.
31931 (CSharpParser::Lexer): New readonly property to return the reference
31932 to the Tokenizer object.
31933 (declare_local_variables): Use Report.Error with location instead of plain
31937 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
31938 (Operator.CheckBinaryOperator): Ditto.
31940 * cs-parser.jay (operator_declarator): Update accordingly.
31942 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
31943 (CheckBinaryOperator): Same here.
31945 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
31946 on the name without any prefixes of namespace names etc. This is because we
31947 already might have something already fully qualified like
31948 'System.Console.WriteLine'
31950 * assign.cs (Resolve): Begin implementation. Stuck ;-)
31952 2001-09-07 Ravi Pratap <ravi@ximian.com>
31954 * cs-tokenizer.cs (location): Return a string which also contains
31957 * expression.cs (ElementAccess): New class for expressions of the
31958 type 'element access.'
31959 (BaseAccess): New class for expressions of the type 'base access.'
31960 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
31963 * cs-parser.jay (element_access): Implement action.
31964 (base_access): Implement actions.
31965 (checked_expression, unchecked_expression): Implement.
31967 * cs-parser.jay (local_variable_type): Correct and implement.
31968 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
31970 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
31972 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
31973 name and the specifiers.
31975 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
31977 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
31978 making them all public ;-)
31980 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
31983 2001-09-07 Miguel de Icaza <miguel@ximian.com>
31985 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
31987 (FieldExpr, PropertyExprs): New resolved expressions.
31988 (SimpleName::MemberStaticCheck): Perform static checks for access
31989 to non-static fields on static methods. Maybe this should be
31990 generalized for MemberAccesses.
31991 (SimpleName::ResolveSimpleName): More work on simple name
31994 * cs-parser.jay (primary_expression/qualified_identifier): track
31995 the parameter index.
31997 * codegen.cs (CodeGen::Save): Catch save exception, report error.
31998 (EmitContext::EmitBoolExpression): Chain to expression generation
31999 instead of temporary hack.
32000 (::EmitStatementExpression): Put generic expression code generation.
32002 * assign.cs (Assign::Emit): Implement variable assignments to
32003 local variables, parameters and fields.
32005 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32007 * statement.cs (Block::GetVariableInfo): New method, returns the
32008 VariableInfo for a variable name in a block.
32009 (Block::GetVariableType): Implement in terms of GetVariableInfo
32011 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32012 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32014 2001-09-06 Ravi Pratap <ravi@ximian.com>
32016 * cs-parser.jay (operator_declaration): Continue on my quest : update
32017 to take attributes argument.
32018 (event_declaration): Ditto.
32019 (enum_declaration): Ditto.
32020 (indexer_declaration): Ditto.
32022 * class.cs (Operator::Operator): Update constructor accordingly.
32023 (Event::Event): Ditto.
32025 * delegate.cs (Delegate::Delegate): Same here.
32027 * enum.cs (Enum::Enum): Same here.
32029 2001-09-05 Ravi Pratap <ravi@ximian.com>
32031 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32033 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32035 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32036 being passed around as an arraylist.
32037 (Attributes::AddAttribute): Method to add attribute sections.
32039 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32040 (struct_declaration): Update accordingly.
32041 (constant_declaration): Update.
32042 (field_declaration): Update.
32043 (method_header): Update.
32044 (fixed_parameter): Update.
32045 (parameter_array): Ditto.
32046 (property_declaration): Ditto.
32047 (destructor_declaration): Ditto.
32049 * class.cs (Struct::Struct): Update constructors accordingly.
32050 (Class::Class): Ditto.
32051 (Field::Field): Ditto.
32052 (Method::Method): Ditto.
32053 (Property::Property): Ditto.
32054 (TypeContainer::OptAttribute): update property's return type.
32056 * interface.cs (Interface.opt_attributes): New member.
32057 (Interface::Interface): Update to take the extra Attributes argument.
32059 * parameter.cs (Parameter::Parameter): Ditto.
32061 * constant.cs (Constant::Constant): Ditto.
32063 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32064 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32065 the attributes as a parameter.
32066 (InterfaceProperty): Update constructor call.
32067 (InterfaceEvent): Ditto.
32068 (InterfaceMethod): Ditto.
32069 (InterfaceIndexer): Ditto.
32071 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32072 pass the attributes too.
32073 (interface_event_declaration): Ditto.
32074 (interface_property_declaration): Ditto.
32075 (interface_method_declaration): Ditto.
32076 (interface_declaration): Ditto.
32078 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32080 * class.cs (Method::Define): Track the "static Main" definition to
32081 create an entry point.
32083 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32084 EntryPoint if we find it.
32086 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32087 (EmitContext::ig): Make this variable public.
32089 * driver.cs: Make the default output file be the first file name
32090 with the .exe extension.
32092 Detect empty compilations
32094 Handle various kinds of output targets. Handle --target and
32095 rename -t to --dumper.
32097 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32098 methods inherited from Expression return now an Expression. This
32099 will is used during the tree rewriting as we resolve them during
32102 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32103 the spec. Missing entirely is the information about
32104 accessability of elements of it.
32106 (Expression::ExprClassFromMemberInfo): New constructor for
32107 Expressions that creates a fully initialized Expression based on
32108 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32111 (Invocation::Resolve): Begin implementing resolution of invocations.
32113 * literal.cs (StringLiteral): Implement Emit.
32115 2001-09-05 Ravi Pratap <ravi@ximian.com>
32117 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32120 2001-09-04 Ravi Pratap <ravi@ximian.com>
32122 * cs-parser.jay (attribute_arguments): Implement actions.
32123 (attribute): Fix bug in production. Implement action.
32124 (attribute_list): Implement.
32125 (attribute_target): Implement.
32126 (attribute_target_specifier, opt_target_specifier): Implement
32127 (CheckAttributeTarget): New method to check if the attribute target
32129 (attribute_section): Implement.
32130 (opt_attributes): Implement.
32132 * attribute.cs : New file to handle attributes.
32133 (Attribute): Class to hold attribute info.
32135 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32136 (attribute_section): Modify production to use 2 different rules to
32137 achieve the same thing. 1 s/r conflict down !
32138 Clean out commented, useless, non-reducing dimension_separator rules.
32140 * class.cs (TypeContainer.attributes): New member to hold list
32141 of attributes for a type.
32142 (Struct::Struct): Modify to take one more argument, the attribute list.
32143 (Class::Class): Ditto.
32144 (Field::Field): Ditto.
32145 (Method::Method): Ditto.
32146 (Property::Property): Ditto.
32148 * cs-parser.jay (struct_declaration): Update constructor call to
32149 pass in the attributes too.
32150 (class_declaration): Ditto.
32151 (constant_declaration): Ditto.
32152 (field_declaration): Ditto.
32153 (method_header): Ditto.
32154 (fixed_parameter): Ditto.
32155 (parameter_array): Ditto.
32156 (property_declaration): Ditto.
32158 * constant.cs (Constant::Constant): Update constructor similarly.
32159 Use System.Collections.
32161 * parameter.cs (Parameter::Parameter): Update as above.
32163 2001-09-02 Ravi Pratap <ravi@ximian.com>
32165 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32166 (TypeContainer.delegates): New member to hold list of delegates.
32168 * cs-parser.jay (delegate_declaration): Implement the action correctly
32169 this time as I seem to be on crack ;-)
32171 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32173 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32174 tell whether an identifier represents a namespace.
32176 * expression.cs (NamespaceExpr): A namespace expression, used only
32177 temporarly during expression resolution.
32178 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32179 utility functions to resolve names on expressions.
32181 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32183 * codegen.cs: Add hook for StatementExpressions.
32185 * class.cs: Fix inverted test for static flag in methods.
32187 2001-09-02 Ravi Pratap <ravi@ximian.com>
32189 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32190 to make it coincide with MS' number.
32191 (Operator::CheckBinaryOperator): Ditto.
32193 * ../errors/errors.txt : Remove error numbers added earlier.
32195 * ../errors/cs1019.cs : Test case for error # 1019
32197 * ../errros/cs1020.cs : Test case for error # 1020
32199 * cs-parser.jay : Clean out commented cruft.
32200 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32201 used anywhere - non-reducing rule.
32202 (namespace_declarations): Non-reducing rule - comment out.
32204 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32205 with TypeContainer::AddEnum.
32207 * delegate.cs : New file for delegate handling classes.
32208 (Delegate): Class for declaring delegates.
32210 * makefile : Update.
32212 * cs-parser.jay (delegate_declaration): Implement.
32214 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32216 * class.cs (Event::Define): Implement.
32217 (Event.EventBuilder): New member.
32219 * class.cs (TypeContainer::Populate): Update to define all enums and events
32221 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32222 readonly fields for all these cases ?
32224 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32226 * class.cs (Property): Revamp to use the convention of making fields readonly.
32227 Accordingly modify code elsewhere.
32229 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32230 the Define method of the Property class.
32232 * class.cs : Clean up applied patch and update references to variables etc. Fix
32234 (TypeContainer::Populate): Update to define all the properties we have. Also
32235 define all enumerations.
32237 * enum.cs (Define): Implement.
32239 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32241 * cs-parser.jay (overloadable_operator): The semantic value is an
32242 enum of the Operator class.
32243 (operator_declarator): Implement actions.
32244 (operator_declaration): Implement.
32246 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32247 validity of definitions.
32248 (Operator::CheckBinaryOperator): Static method to check for binary operators
32249 (TypeContainer::AddOperator): New method to add an operator to a type.
32251 * cs-parser.jay (indexer_declaration): Added line to actually call the
32252 AddIndexer method so it gets added ;-)
32254 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32255 already taken care of by the MS compiler ?
32257 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32259 * class.cs (Operator): New class for operator declarations.
32260 (Operator::OpType): Enum for the various operators.
32262 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32264 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32265 ostensibly handle this in semantic analysis.
32267 * cs-parser.jay (general_catch_clause): Comment out
32268 (specific_catch_clauses, specific_catch_clause): Ditto.
32269 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32270 (catch_args, opt_catch_args): New productions.
32271 (catch_clause): Rewrite to use the new productions above
32272 (catch_clauses): Modify accordingly.
32273 (opt_catch_clauses): New production to use in try_statement
32274 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32275 and re-write the code in the actions to extract the specific and
32276 general catch clauses by being a little smart ;-)
32278 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32279 Hooray, try and catch statements parse fine !
32281 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32283 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32284 string from the hashtable of variables.
32286 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32287 I end up making that mistake ;-)
32288 (catch_clauses): Fixed gross error which made Key and Value of the
32289 DictionaryEntry the same : $1 !!
32291 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32293 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32295 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32296 when the add and remove accessors are specified.
32298 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32300 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32301 information about indexer_declarator.
32302 (indexer_declarator): Implement actions.
32303 (parsing_indexer): New local boolean used to keep track of whether
32304 we are parsing indexers or properties. This is necessary because
32305 implicit_parameters come into picture even for the get accessor in the
32306 case of an indexer.
32307 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32309 * class.cs (Indexer): New class for indexer declarations.
32310 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32311 (TypeContainer::indexers): New member to hold list of indexers for the
32314 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32316 * cs-parser.jay (add_accessor_declaration): Implement action.
32317 (remove_accessor_declaration): Implement action.
32318 (event_accessors_declaration): Implement
32319 (variable_declarators): swap statements for first rule - trivial.
32321 * class.cs (Event): New class to hold information about event
32323 (TypeContainer::AddEvent): New method to add an event to a type
32324 (TypeContainer::events): New member to hold list of events.
32326 * cs-parser.jay (event_declaration): Implement actions.
32328 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32330 * cs-parser.jay (dim_separators): Implement. Make it a string
32331 concatenating all the commas together, just as they appear.
32332 (opt_dim_separators): Modify accordingly
32333 (rank_specifiers): Update accordingly. Basically do the same
32334 thing - instead, collect the brackets here.
32335 (opt_rank_sepcifiers): Modify accordingly.
32336 (array_type): Modify to actually return the complete type string
32337 instead of ignoring the rank_specifiers.
32338 (expression_list): Implement to collect the expressions
32339 (variable_initializer): Implement. We make it a list of expressions
32340 essentially so that we can handle the array_initializer case neatly too.
32341 (variable_initializer_list): Implement.
32342 (array_initializer): Make it a list of variable_initializers
32343 (opt_array_initializer): Modify accordingly.
32345 * expression.cs (New::NType): Add enumeration to help us
32346 keep track of whether we have an object/delegate creation
32347 or an array creation.
32348 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32349 members to hold data about array creation.
32350 (New:New): Modify to update NewType
32351 (New:New): New Overloaded contructor for the array creation
32354 * cs-parser.jay (array_creation_expression): Implement to call
32355 the overloaded New constructor.
32357 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32359 * class.cs (TypeContainer::Constructors): Return member
32360 constructors instead of returning null.
32362 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32364 * typemanager.cs (InitCoreTypes): Initialize the various core
32365 types after we have populated the type manager with the user
32366 defined types (this distinction will be important later while
32367 compiling corlib.dll)
32369 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32370 on Expression Classification. Now all expressions have a method
32371 `Resolve' and a method `Emit'.
32373 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32374 generation from working. Also add some temporary debugging
32377 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32379 * codegen.cs: Lots of code generation pieces. This is only the
32380 beginning, will continue tomorrow with more touches of polish. We
32381 handle the fundamentals of if, while, do, for, return. Others are
32382 trickier and I need to start working on invocations soon.
32384 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32387 * codegen.cs (EmitContext): New struct, used during code
32388 emission to keep a context. Most of the code generation will be
32391 * cs-parser.jay: Add embedded blocks to the list of statements of
32392 this block. So code generation proceeds in a top down fashion.
32394 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32396 * statement.cs: Add support for multiple child blocks.
32398 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32400 * codegen.cs (EmitCode): New function, will emit the code for a
32401 Block of code given a TypeContainer and its ILGenerator.
32403 * statement.cs (Block): Standard public readonly optimization.
32404 (Block::Block constructors): Link children.
32405 (Block::Child): Child Linker.
32406 (Block::EmitVariables): Emits IL variable declarations.
32408 * class.cs: Drop support for MethodGroups here, delay until
32410 (Method::): Applied the same simplification that I did before, and
32411 move from Properties to public readonly fields.
32412 (Method::ParameterTypes): Returns the parameter types for the
32413 function, and implements a cache that will be useful later when I
32414 do error checking and the semantic analysis on the methods is
32416 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32417 and made a method, optional argument tells whether this is a class
32418 or a structure to apply the `has-this' bit.
32419 (Method::GetCallingConvention): Implement, returns the calling
32421 (Method::Define): Defines the type, a second pass is performed
32422 later to populate the methods.
32424 (Constructor::ParameterTypes): implement a cache similar to the
32425 one on Method::ParameterTypes, useful later when we do semantic
32428 (TypeContainer::EmitMethod): New method. Emits methods.
32430 * expression.cs: Removed MethodGroup class from here.
32432 * parameter.cs (Parameters::GetCallingConvention): new method.
32434 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32436 * class.cs (TypeContainer::Populate): Drop RootContext from the
32439 (Constructor::CallingConvention): Returns the calling convention.
32440 (Constructor::ParameterTypes): Returns the constructor parameter
32443 (TypeContainer::AddConstructor): Keep track of default constructor
32444 and the default static constructor.
32446 (Constructor::) Another class that starts using `public readonly'
32447 instead of properties.
32449 (Constructor::IsDefault): Whether this is a default constructor.
32451 (Field::) use readonly public fields instead of properties also.
32453 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32454 track of static constructors; If none is used, turn on
32455 BeforeFieldInit in the TypeAttributes.
32457 * cs-parser.jay (opt_argument_list): now the return can be null
32458 for the cases where there are no arguments.
32460 (constructor_declarator): If there is no implicit `base' or
32461 `this', then invoke the default parent constructor.
32463 * modifiers.cs (MethodAttr): New static function maps a set of
32464 modifiers flags into a MethodAttributes enum
32465 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32466 MethodAttr, TypeAttr to represent the various mappings where the
32467 modifiers are used.
32468 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32470 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32472 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32475 * interface.cs (PopulateIndexer): Implemented the code generator
32476 for interface indexers.
32478 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32480 * interface.cs (InterfaceMemberBase): Now we track the new status
32483 (PopulateProperty): Implement property population. Woohoo! Got
32484 Methods and Properties going today.
32486 Removed all the properties for interfaces, and replaced them with
32487 `public readonly' fields.
32489 2001-08-16 Miguel de Icaza <miguel@ximian.com>
32491 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
32492 initialize their hashtables/arraylists only when they are needed
32493 instead of doing this always.
32495 * parameter.cs: Handle refs and out parameters.
32497 * cs-parser.jay: Use an ArrayList to construct the arguments
32498 instead of the ParameterCollection, and then cast that to a
32501 * parameter.cs: Drop the use of ParameterCollection and use
32502 instead arrays of Parameters.
32504 (GetParameterInfo): Use the Type, not the Name when resolving
32507 2001-08-13 Miguel de Icaza <miguel@ximian.com>
32509 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
32510 and instead use public readonly fields.
32512 * class.cs: Put back walking code for type containers.
32514 2001-08-11 Miguel de Icaza <miguel@ximian.com>
32516 * class.cs (MakeConstant): Code to define constants.
32518 * rootcontext.cs (LookupType): New function. Used to locate types
32521 2001-08-08 Miguel de Icaza <miguel@ximian.com>
32523 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
32524 this System.Reflection code is. Kudos to Microsoft
32526 * typemanager.cs: Implement a type cache and avoid loading all
32527 types at boot time. Wrap in LookupType the internals. This made
32528 the compiler so much faster. Wow. I rule!
32530 * driver.cs: Make sure we always load mscorlib first (for
32531 debugging purposes, nothing really important).
32533 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
32534 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
32536 * rootcontext.cs: Lookup types on their namespace; Lookup types
32537 on namespaces that have been imported using the `using' keyword.
32539 * class.cs (TypeContainer::TypeAttr): Virtualize.
32540 (Class::TypeAttr): Return attributes suitable for this bad boy.
32541 (Struct::TypeAttr): ditto.
32542 Handle nested classes.
32543 (TypeContainer::) Remove all the type visiting code, it is now
32544 replaced with the rootcontext.cs code
32546 * rootcontext.cs (GetClassBases): Added support for structs.
32548 2001-08-06 Miguel de Icaza <miguel@ximian.com>
32550 * interface.cs, statement.cs, class.cs, parameter.cs,
32551 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
32552 Drop use of TypeRefs, and use strings instead.
32554 2001-08-04 Miguel de Icaza <miguel@ximian.com>
32558 * class.cs (Struct::Struct): set the SEALED flags after
32559 checking the modifiers.
32560 (TypeContainer::TypeAttr): new property, returns the
32561 TypeAttributes for a class.
32563 * cs-parser.jay (type_list): Oops, list production was creating a
32564 new list of base types.
32566 * rootcontext.cs (StdLib): New property.
32567 (GetInterfaceTypeByName): returns an interface by type name, and
32568 encapsulates error handling here.
32569 (GetInterfaces): simplified.
32570 (ResolveTree): Encapsulated all the tree resolution here.
32571 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
32574 * driver.cs: Add support for --nostdlib, to avoid loading the
32575 default assemblies.
32576 (Main): Do not put tree resolution here.
32578 * rootcontext.cs: Beginning of the class resolution.
32580 2001-08-03 Miguel de Icaza <miguel@ximian.com>
32582 * rootcontext.cs: Provide better error reporting.
32584 * cs-parser.jay (interface_base): set our $$ to be interfaces.
32586 * rootcontext.cs (CreateInterface): Handle the case where there
32587 are no parent interfaces.
32589 (CloseTypes): Routine to flush types at the end.
32590 (CreateInterface): Track types.
32591 (GetInterfaces): Returns an array of Types from the list of
32592 defined interfaces.
32594 * typemanager.c (AddUserType): Mechanism to track user types (puts
32595 the type on the global type hash, and allows us to close it at the
32598 2001-08-02 Miguel de Icaza <miguel@ximian.com>
32600 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
32601 RecordInterface instead.
32603 * cs-parser.jay: Updated to reflect changes above.
32605 * decl.cs (Definition): Keep track of the TypeBuilder type that
32606 represents this type here. Not sure we will use it in the long
32607 run, but wont hurt for now.
32609 * driver.cs: Smaller changes to accomodate the new code.
32611 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
32614 * rootcontext.cs (CreateInterface): New method, used to create
32615 the System.TypeBuilder type for interfaces.
32616 (ResolveInterfaces): new entry point to resolve the interface
32618 (CodeGen): Property, used to keep track of the code generator.
32620 2001-07-26 Miguel de Icaza <miguel@ximian.com>
32622 * cs-parser.jay: Add a second production for delegate_declaration
32625 (enum_body): Put an opt_comma here instead of putting it on
32626 enum_body or enum_member_declarations so we can handle trailing
32627 commas on enumeration members. Gets rid of a shift/reduce.
32629 (type_list): Need a COMMA in the middle.
32631 (indexer_declaration): Tell tokenizer to recognize get/set
32633 * Remove old targets.
32635 * Re-add the parser target.
32637 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32639 * cs-parser.jay: Add precendence rules for a number of operators
32640 ot reduce the number of shift/reduce conflicts in the grammar.
32642 2001-07-17 Miguel de Icaza <miguel@ximian.com>
32644 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
32647 Get rid of old crufty code.
32649 * rootcontext.cs: Use this to keep track of the parsed
32650 representation and the defined types available to the program.
32652 * gen-treedump.cs: adjust for new convention.
32654 * type.cs: Split out the type manager, and the assembly builder
32657 * typemanager.cs: the type manager will live here now.
32659 * cil-codegen.cs: And the code generator here.
32661 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
32663 * makefile: Fixed up for easy making.
32665 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32667 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
32670 (unary_expression): Expand pre_increment_expression and
32671 post_decrement_expression to reduce a shift/reduce.
32673 2001-07-11 Simon Cozens
32675 * cs-tokenizer.cs: Hex numbers should begin with a 0.
32677 Improve allow_keyword_as_indent name.
32679 2001-06-19 Miguel de Icaza <miguel@ximian.com>
32681 * Adjustments for Beta2.
32683 2001-06-13 Miguel de Icaza <miguel@ximian.com>
32685 * decl.cs: Added `Define' abstract method.
32686 (InTransit): new property, used to catch recursive definitions.
32688 * interface.cs: Implement `Define'.
32690 * modifiers.cs: Map Modifiers.constants to
32691 System.Reflection.TypeAttribute flags.
32693 * class.cs: Keep track of types and user-defined types.
32694 (BuilderInit): New method for creating an assembly
32695 (ResolveType): New function to launch the resolution process, only
32696 used by interfaces for now.
32698 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
32699 that are inserted into the name space.
32701 2001-06-08 Miguel de Icaza <miguel@ximian.com>
32703 * ARGH. I have screwed up my tree so many times due to the use of
32704 rsync rather than using CVS. Going to fix this at once.
32706 * driver.cs: Objetify driver. Load assemblies, use assemblies to
32709 2001-06-07 Miguel de Icaza <miguel@ximian.com>
32711 * Experiment successful: Use System.Type rather that our own
32714 2001-05-25 Miguel de Icaza <miguel@ximian.com>
32716 * cs-parser.jay: Removed nsAliases from here.
32718 Use new namespaces, handle `using XXX;'
32720 * namespace.cs: Reimplemented namespace handling, use a recursive
32721 definition of the class. Now we can keep track of using clauses
32722 and catch invalid using clauses.
32724 2001-05-24 Miguel de Icaza <miguel@ximian.com>
32726 * gen-treedump.cs: Adapted for all the renaming.
32728 * expression.cs (Expression): this class now has a Type property
32729 which returns an expression Type.
32731 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
32732 `Type', as this has a different meaning now in the base
32734 2001-05-22 Miguel de Icaza <miguel@ximian.com>
32736 * interface.cs, class.cs: Removed from all the sources the
32737 references to signature computation, as we can not do method
32738 signature computation during the parsing time, as we are not
32739 trying to solve at that point distinguishing:
32743 void a (NS.Blah x) {}
32746 Which depending on the context might be valid or not, as we do not
32747 know if Blah is the same thing as NS.Blah at that point.
32749 * Redid everything so the code uses TypeRefs now instead of
32750 Types. TypeRefs are just temporary type placeholders, that need
32751 to be resolved. They initially have a pointer to a string and the
32752 current scope in which they are used. This is used later by the
32753 compiler to resolve the reference to an actual Type.
32755 * DeclSpace is no longer a CIR.Type, and neither are
32756 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
32757 are all DeclSpaces, but no Types.
32759 * type.cs (TypeRefManager): This implements the TypeRef manager,
32760 which keeps track of all the types that need to be resolved after
32761 the parsing has finished.
32763 2001-05-13 Miguel de Icaza <miguel@ximian.com>
32765 * ARGH. We are going to have to store `foreach' as a class rather
32766 than resolving it, as we need to verify error 1579 after name
32767 resolution. *OR* we could keep a flag that says `This request to
32768 IEnumerator comes from a foreach statement' which we can then use
32769 to generate the error.
32771 2001-05-10 Miguel de Icaza <miguel@ximian.com>
32773 * class.cs (TypeContainer.AddMethod): we now add methods to the
32774 MethodGroup instead of the method hashtable.
32776 * expression.cs: Add MethodGroup abstraction, which gets us one
32777 step closer to the specification in the way we handle method
32780 * cs-parser.jay (primary_expression): qualified_identifier now
32781 tried to match up an identifier to a local variable reference or
32782 to a parameter reference.
32784 current_local_parameters is now a parser global variable that
32785 points to the current parameters for the block, used during name
32788 (property_declaration): Now creates an implicit `value' argument to
32791 2001-05-09 Miguel de Icaza <miguel@ximian.com>
32793 * parameter.cs: Do not use `param' arguments as part of the
32794 signature, per the spec.
32796 2001-05-08 Miguel de Icaza <miguel@ximian.com>
32798 * decl.cs: Base class for classes, structs and interfaces. This
32799 is the "Declaration Space"
32801 * cs-parser.jay: Use CheckDef for checking declaration errors
32802 instead of having one on each function.
32804 * class.cs: Factor out some code for handling error handling in
32805 accordance to the "Declarations" section in the "Basic Concepts"
32806 chapter in the ECMA C# spec.
32808 * interface.cs: Make all interface member classes derive from
32809 InterfaceMemberBase.
32811 2001-05-07 Miguel de Icaza <miguel@ximian.com>
32813 * Many things: all interfaces are parsed and generated in
32814 gen-treedump. Support for member variables, constructors,
32815 destructors, properties, constants is there.
32817 Beginning of the IL backend, but very little done, just there for
32820 2001-04-29 Miguel de Icaza <miguel@ximian.com>
32822 * cs-parser.jay: Fix labeled statement.
32824 * cs-tokenizer.cs (escape): Escape " and ' always.
32825 ref_line, ref_name: keep track of the line/filename as instructed
32826 by #line by the compiler.
32829 2001-04-27 Miguel de Icaza <miguel@ximian.com>
32831 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
32832 to match the values in System.CodeDOM.
32834 Divid renamed to Divide.
32836 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
32838 (Statements.set): remove.
32840 * System.CodeDOM/CodeCatchClause.cs: always have a valid
32843 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
32844 falseStatements always have valid values.
32846 * cs-parser.jay: Use System.CodeDOM now.